d111e7debab8b65fcfe826b3c045378b291f6f4f
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-11-18  Adam Roben  <aroben@apple.com>
2
3         Implement layoutTestController.waitForPolicyDelegate on Windows
4
5         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
6
7         Reviewed by Simon Fraser.
8
9         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
10         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
11         code from LayoutTestControllerMac.mm.
12
13 2010-11-18  Hayato Ito  <hayato@chromium.org>
14
15         Reviewed by Shinichiro Hamaji.
16
17         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
18
19         https://bugs.webkit.org/show_bug.cgi?id=49740
20
21         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
22
23 2010-11-18  Tony Chang  <tony@chromium.org>
24
25         Reviewed by Adam Barth.
26
27         run platform/chromium/plugins/refcount-leaks.html on all platforms
28         https://bugs.webkit.org/show_bug.cgi?id=49485
29
30         Add PluginObject.testObjectCount which returns the number of allocated
31         TestObjects. Add PluginObject.testCreateTestObject which allocates
32         and returns a TestObject.
33
34         Add TestObject.refCount which returns the number of refs on the
35         TestObject.
36
37         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
38         (pluginGetProperty):
39         (pluginInvoke):
40         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
41         (getTestObjectCount):
42         (testAllocate):
43         (testDeallocate):
44         (testGetProperty):
45         (testScriptObjectInvoke): Release a ref to a plugin object that was
46             previously leaked.
47         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
48
49 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
50
51         Reviewed by Adam Roben.
52
53         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
54         https://bugs.webkit.org/show_bug.cgi?id=49711
55
56         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
57         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
58         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
59         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
60         * record-memory-win/record-memory-win-common.vsprops: Added.
61         * record-memory-win/record-memory-win.vcproj:
62
63 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
64
65         Reviewed by Csaba Osztrogonác.
66
67         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
68
69         * MiniBrowser/qt/BrowserWindow.cpp:
70         (BrowserWindow::updateUserAgentList):
71
72 2010-11-17  Adam Roben  <aroben@apple.com>
73
74         Don't trigger Windows builds when chromium-win test results change
75
76         Reviewed by Mark Rowe.
77
78         * Scripts/webkitpy/common/config/build.py:
79         (_should_file_trigger_build): Changed the regular expression used to
80         search for directory names to only consider full directory names,
81         rather than matching directory names where the string we care about is
82         a suffix of the name.
83
84         * Scripts/webkitpy/common/config/build_unittest.py:
85         (ShouldBuildTest): Added a test.
86
87 2010-11-17  Hayato Ito  <hayato@chromium.org>
88
89         Reviewed by Shinichiro Hamaji.
90
91         Remove a uri member from TestInput class.
92
93         https://bugs.webkit.org/show_bug.cgi?id=49691
94
95         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
96         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
97
98 2010-11-17  Adam Roben  <aroben@apple.com>
99
100         Move FindSafari's settings into a vsprops file
101
102         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
103
104         Reviewed by Steve Falkenburg.
105
106         * FindSafari/FindSafari.vcproj:
107         * FindSafari/FindSafariCommon.vsprops: Added.
108
109 2010-11-17  Adam Roben  <aroben@apple.com>
110
111         Use a minimum font size of 0 in DRT on Windows
112
113         This is the Windows equivalent of r72164.
114
115         Rubber-stamped by Dave Hyatt.
116
117         * DumpRenderTree/win/DumpRenderTree.cpp:
118         (resetDefaultsToConsistentValues):
119
120 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
121
122         Reviewed by Andreas Kling.
123
124         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
125         https://bugs.webkit.org/show_bug.cgi?id=49639
126
127         * Scripts/webkitpy/common/checkout/scm.py:
128
129 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
130
131         Reviewed by Tony Chang.
132
133         Rebaseline server: add loupe for image diffs
134         https://bugs.webkit.org/show_bug.cgi?id=49692
135         
136         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
137         enlarged area of the expected, actual and diff images side by side.
138
139         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
140         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
141         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
142         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
143
144 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
145
146         Reviewed by Adam Roben.
147
148         WebKitLauncherWin should use vsprops for shared build settings
149         https://bugs.webkit.org/show_bug.cgi?id=49696
150
151         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
152         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
153
154 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
155
156         Reviewed by Adam Roben.
157
158         WinLauncher should use vsprops for shared build settings
159         https://bugs.webkit.org/show_bug.cgi?id=49695
160
161         * WinLauncher/WinLauncher.cpp:
162         (_tWinMain):
163         (PrintView):
164         (WndProc):
165         (MyEditProc):
166         * WinLauncher/WinLauncher.vcproj:
167         * WinLauncher/WinLauncherCommon.vsprops: Added.
168
169 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
170
171         Delete unused file unintentionally added in last change.
172
173         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
174
175 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
176
177         Reviewed by Adam Roben.
178
179         DumpRenderTree on Windows should use a vsprops file for shared project settings
180         https://bugs.webkit.org/show_bug.cgi?id=49690
181
182         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
183         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
184         * DumpRenderTree/win/DumpRenderTree.vcproj:
185         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
186         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
187         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
188         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
189         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
190         * DumpRenderTree/win/ImageDiff.vcproj:
191         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
192
193 2010-11-17  Hayato Ito  <hayato@chromium.org>
194
195         Refactor TestTypeBase.compare_output().
196
197         Introduce a TestOutput class and update compare_output() of each test
198         types so that they can take both actual and expected TestOutput objects.
199
200         https://bugs.webkit.org/show_bug.cgi?id=49431
201
202         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
203         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
204         * Scripts/webkitpy/layout_tests/port/base.py:
205         * Scripts/webkitpy/layout_tests/port/chromium.py:
206         * Scripts/webkitpy/layout_tests/port/dryrun.py:
207         * Scripts/webkitpy/layout_tests/port/test.py:
208         * Scripts/webkitpy/layout_tests/port/webkit.py:
209         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
210         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
211         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
212         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
213
214 2010-11-17  Adam Roben  <aroben@apple.com>
215
216         Make each Windows Test builder use the same OS for all its slaves
217
218         Currently each WebKit1 Windows Test builder has one Windows XP slave
219         and one Windows 7 slave. Having different OSes in a single builder
220         meant that the builders would alternate between red and green when
221         there were OS-specific failures.
222
223         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
224         between red and green because of multiple OS versions
225
226         Reviewed by Mark Rowe.
227
228         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
229         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
230         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
231         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
232         builders for the two WebKit1 builders so that they would all use the
233         appropriate OS.
234
235 2010-11-17  James Robinson  <jamesr@chromium.org>
236
237         Reviewed by Dan Bernstein.
238
239         [chromium] Set minimum font size to 0 for DRT
240         https://bugs.webkit.org/show_bug.cgi?id=49677
241
242         Followup for http://trac.webkit.org/changeset/72141.
243
244         Test: http/tests/misc/acid3.html
245
246         * DumpRenderTree/chromium/WebPreferences.cpp:
247         (WebPreferences::reset):
248
249 2010-11-17  Andras Becsi  <abecsi@webkit.org>
250
251         Unreviewed build fix.
252
253         [Qt] Add missing file I forgot in r72220.
254
255         * MiniBrowser/MiniBrowser.qrc: Added.
256
257 2010-11-17  Andras Becsi  <abecsi@webkit.org>
258
259         Reviewed by Andreas Kling.
260
261         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
262         https://bugs.webkit.org/show_bug.cgi?id=49627
263
264         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
265
266         * MiniBrowser/MiniBrowser.qrc: Added.
267         Add it here to prevent qmake from detecting it
268         since it needs to be copied to the build directory.
269         * MiniBrowser/qt/BrowserWindow.cpp:
270         (BrowserWindow::BrowserWindow):
271         (BrowserWindow::updateUserAgentList):
272         (BrowserWindow::showUserAgentDialog):
273         * MiniBrowser/qt/BrowserWindow.h:
274         * MiniBrowser/qt/MiniBrowser.pro:
275
276 2010-11-17  Adam Roben  <aroben@apple.com>
277
278         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
279
280         We use that file on Windows!
281
282         Fixes <http://webkit.org/b/49643> Changes to
283         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
284
285         Reviewed by Steve Falkenburg.
286
287         * Scripts/webkitpy/common/config/build.py:
288         (_should_file_trigger_build): Added the mac-wk2 directory and make it
289         trigger builds on SnowLeopard and Windows.
290
291         * Scripts/webkitpy/common/config/build_unittest.py:
292         (ShouldBuildTest.test_should_build): Added a test.
293
294 2010-11-17  Satish Sampath  <satish@chromium.org>
295
296         Reviewed by Jeremy Orlow.
297
298         Clear the speech input mock explicitly before each test.
299         https://bugs.webkit.org/show_bug.cgi?id=49660
300
301         * DumpRenderTree/chromium/LayoutTestController.cpp:
302         (LayoutTestController::setMockSpeechInputResult):
303         * DumpRenderTree/chromium/LayoutTestController.h:
304         * DumpRenderTree/chromium/WebViewHost.cpp:
305         (WebViewHost::speechInputController):
306         (WebViewHost::reset): Invoke speech input mock's clearResults method.
307         * DumpRenderTree/chromium/WebViewHost.h:
308         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
309
310 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
311
312         Unreviewed, specify IRC nickname in committers.py.
313
314         * Scripts/webkitpy/common/config/committers.py:
315
316 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
317
318         Reviewed by Tony Chang.
319
320         [NRWT] Make http locking similar to perl implementation
321         https://bugs.webkit.org/show_bug.cgi?id=49187
322
323         * Scripts/webkitpy/common/system/file_lock.py: Added.
324         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
325         * Scripts/webkitpy/layout_tests/port/http_lock.py:
326
327 2010-11-17  MORITA Hajime  <morrita@google.com>
328
329         Reviewed by Kent Tamura.
330
331         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
332         https://bugs.webkit.org/show_bug.cgi?id=49366
333
334         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
335           according to the spellchecker suggestion
336         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
337
338         test_expectations.txt will be changed after this change is ported to test_shell.
339         
340         * DumpRenderTree/chromium/EventSender.cpp:
341         (makeMenuItemStringsFor):
342         (EventSender::contextClick):
343         * DumpRenderTree/chromium/MockSpellCheck.cpp:
344         (MockSpellCheck::fillSuggestionList):
345         (MockSpellCheck::initializeIfNeeded):
346         * DumpRenderTree/chromium/MockSpellCheck.h:
347         * DumpRenderTree/chromium/WebViewHost.cpp:
348         (WebViewHost::mockSpellCheck):
349         * DumpRenderTree/chromium/WebViewHost.h:
350
351 2010-11-16  Dave Hyatt  <hyatt@apple.com>
352
353         Reviewed by Sam Weinig.
354
355         Make sure the pref for minimum font size is just explicitly set to 0 every time,
356         since the bots have 1 stuck in their plist otherwise.
357
358         * DumpRenderTree/mac/DumpRenderTree.mm:
359         (resetDefaultsToConsistentValues):
360
361 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
362
363         Reviewed by Tony Chang.
364
365         Rebaseline server: compute diffs client-side
366         https://bugs.webkit.org/show_bug.cgi?id=49640
367         
368         The image diff output from the DRT is pretty bad on some ports (at
369         least the Mac one), so it's better to compute diffs on the client by
370         using <canvas>.
371
372         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
373         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
374         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
375
376 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
377
378         Reviewed by Tony Chang.
379
380         Rebaseline server: display test results
381         https://bugs.webkit.org/show_bug.cgi?id=49626
382         
383         Adds basic result display to the rebaseline server. On the Python side
384         this involves:
385         - Parsing the unexpected_results.json into a dictionary.
386         - Serving it as JSON under /results.json.
387         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
388         but I'll need to have access to the parsed results on the Python side
389         for follow-up changes).
390         
391         On the web UI side this adds:
392         - Markup for display image and text results (expected, actual, diff),
393           and JS for populating it.
394         - Markup for breaking down test results by failure type and directory,
395           and JS for populating it.
396
397         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
398         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
399         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
400         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
401         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
402
403 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
404
405         Reviewed by Ojan Vafai.
406
407         See Chromium issue http://codereview.chromium.org/5133001/ - we
408         are modifying the build bots to pass in the builder name with
409         the "GPU" string appended instead of appending it in the code.
410
411         https://bugs.webkit.org/show_bug.cgi?id=49636
412
413         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
414
415 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
416
417         Reviewed by Adam Roben.
418
419         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
420         https://bugs.webkit.org/show_bug.cgi?id=49632
421
422         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
423         * DumpRenderTree/win/DumpRenderTree.vcproj:
424         * DumpRenderTree/win/ImageDiff.vcproj:
425         * MiniBrowser/MiniBrowser.vcproj:
426         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
427         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
428         * WebKitTestRunner/win/InjectedBundle.vcproj:
429         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
430         * WinLauncher/WinLauncher.vcproj:
431         * record-memory-win/record-memory-win.vcproj:
432
433 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
434
435         Reviewed by Ojan Vafai.
436
437         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
438
439         Rename the TestInfo class to TestInput to be clearer about its
440         function, and move the checksum-reading code into dump_render_tree_thread
441         to avoid cross-thread access.
442
443         https://bugs.webkit.org/show_bug.cgi?id=49573
444
445         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
446         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
447         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
448
449 2010-11-16  Dave Hyatt  <hyatt@apple.com>
450
451         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
452
453         * DumpRenderTree/mac/DumpRenderTree.mm:
454         (resetDefaultsToConsistentValues):
455
456 2010-11-16  Stephanie Lewis  <slewis@apple.com>
457
458         Reviewed by Geoff Garen.
459
460         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
461
462         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
463         for every WebView, and the WebKit API doesn't support that ownership model.
464
465         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
466
467         * DumpRenderTree/mac/DumpRenderTree.mm:
468         (createWebViewAndOffscreenWindow):
469         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
470         (LayoutTestController::setMockDeviceOrientation):
471
472 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
473
474         Reviewed by Ojan Vafai.
475
476         new-run-webkit-tests: log the process id in --verbose mode
477
478         As part of the switch to multi-process mode, we should log the
479         process id when running w/ --verbose.
480
481         https://bugs.webkit.org/show_bug.cgi?id=49571
482
483         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
484
485 2010-11-16  Adam Roben  <aroben@apple.com>
486
487         Only trigger Windows builds when files that we actually use on Windows
488         are changed
489
490         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
491         It uses the new webkitpy.common.config.build module to determine
492         whether a particular change should trigger a build on a particular
493         platform. The Windows builders have been switched to use a
494         PlatformSpecificScheduler.
495
496         The logic to determine whether or not a particular change should
497         trigger a build on a given platform has only been implemented/tested
498         for Windows. I tried to make it easy to add more platforms in the
499         future, but I don't have enough familiarity with all platforms to be
500         able to implement it for them.
501
502         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
503         lots irrelevant changes (e.g., rebaselining Chromium test results)
504
505         Reviewed by Eric Seidel.
506
507         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
508         PlatformSpecificScheduler for the Windows builders.
509
510         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
511         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
512         up a ChangeFilter that filters to our branch and will call through to
513         our filter method, and calls up to our base class.
514         (PlatformSpecificScheduler.filter): Calls through to
515         build.should_build to find out whether we should trigger a build for
516         this change.
517
518         * Scripts/webkitpy/common/net/build.py: Added.
519         (_should_file_trigger_build): Uses a set of directories and regexp
520         patterns to determine whether the given file should trigger a build on
521         the given platform. As mentioned earlier, this has only been
522         implemented for Windows, though I did try to make some guesses about
523         other platforms.
524         (should_build): Returns true if any of the files should trigger a
525         build on the given platform.
526
527         * Scripts/webkitpy/common/net/build_unittest.py: Added.
528         (ShouldBuildTest.test_should_build): Does some basic testing to make
529         sure we're triggering builds for the right files. It only tests
530         Windows for now, though I tried to make some guesses about other
531         platforms.
532
533 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
534
535         Reviewed by Andreas Kling.
536
537         [Qt] Remove synchronous QWebPage::checkPermissions signal
538         https://bugs.webkit.org/show_bug.cgi?id=46810
539
540         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
541         (WebCore::WebPage::WebPage):
542         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
543         (LayoutTestController::grantDesktopNotificationPermission): When granting
544         permission, grant it directly on the QWebPage/Frame, that will remember it.
545         * QtTestBrowser/webpage.cpp:
546         (WebPage::WebPage):
547         * QtTestBrowser/webpage.h:
548
549
550 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
551
552         Reviewed by Csaba Osztrogonác.
553
554         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
555
556         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
557         (LayoutTestController::reset):
558         * DumpRenderTree/qt/LayoutTestControllerQt.h:
559         (LayoutTestController::isPrinting):
560         (LayoutTestController::setPrinting):
561
562 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
563
564         Reviewed by Andreas Kling.
565
566         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
567         https://bugs.webkit.org/show_bug.cgi?id=49587
568
569         * MiniBrowser/qt/BrowserView.cpp:
570         (BrowserView::BrowserView): Added BackingStoreType
571         argument to ctor. Propagating it to the QGraphicsWKView.
572         * MiniBrowser/qt/BrowserView.h:
573         * MiniBrowser/qt/BrowserWindow.cpp:
574         (BrowserWindow::BrowserWindow):
575         (BrowserWindow::newWindow): Create the new BrowserWindow
576         with the same BackingStoreType that this instance has.
577         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
578         * MiniBrowser/qt/main.cpp:
579         (main): Use tiled backing store if got -tiled command line argument.
580         Avoid redundant copy of command line args.
581
582 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
583
584         Reviewed by Jeremy Orlow.
585
586         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
587         https://bugs.webkit.org/show_bug.cgi?id=48506
588
589         This ensures that there is one mock per page WebView / WebViewHost. This is a
590         design constraint of the DeviceOrientationClientMock because the m_controller
591         field can only store a pointer to a single instance of the corresponding
592         DeviceOrientationController.
593
594         Test: fast/dom/DeviceOrientation/no-page-cache.html
595
596         * DumpRenderTree/chromium/LayoutTestController.cpp:
597         (LayoutTestController::setMockDeviceOrientation):
598         (LayoutTestController::deviceOrientationClientMock):
599         * DumpRenderTree/chromium/LayoutTestController.h:
600         * DumpRenderTree/chromium/WebViewHost.cpp:
601         (WebViewHost::deviceOrientationClientMock):
602         (WebViewHost::deviceOrientationClient):
603         (WebViewHost::reset):
604         * DumpRenderTree/chromium/WebViewHost.h:
605
606 2010-11-15  Andras Becsi  <abecsi@webkit.org>
607
608         Reviewed by Andreas Kling.
609
610         [Qt][WK2] Avoid polling in WebKitTestRunner.
611         https://bugs.webkit.org/show_bug.cgi?id=49542
612
613         Make the WK2 testing session about 10-15% faster and decrease random flakiness
614         resulting from timing skew by removing the millisecond polling from TestControllerQt.
615
616         * WebKitTestRunner/TestController.cpp:
617         (WTR::TestController::didFinishLoadForFrame):
618         * WebKitTestRunner/TestController.h:
619         * WebKitTestRunner/TestInvocation.cpp:
620         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
621         * WebKitTestRunner/mac/TestControllerMac.mm:
622         (WTR::TestController::notifyDone): Add method stub.
623         * WebKitTestRunner/qt/TestControllerQt.cpp:
624         (WTR::TestControllerRunLoop::instance):
625         (WTR::TestControllerRunLoop::start):
626         (WTR::TestControllerRunLoop::stop):
627         (WTR::TestControllerRunLoop::TestControllerRunLoop):
628         (WTR::TestControllerRunLoop::timerEvent):
629         (WTR::TestController::notifyDone):
630         (WTR::TestController::platformRunUntil):
631         * WebKitTestRunner/win/TestControllerWin.cpp:
632         (WTR::TestController::notifyDone): Add method stub.
633
634 2010-11-15  Darin Adler  <darin@apple.com>
635
636         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
637
638 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
639
640         Reviewed by Andreas Kling.
641
642         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
643         https://bugs.webkit.org/show_bug.cgi?id=49544
644
645         Add the shortcut to BrowserWindow.
646
647         * MiniBrowser/qt/BrowserWindow.cpp:
648         (BrowserWindow::BrowserWindow):
649         (BrowserWindow::openLocation):
650         * MiniBrowser/qt/BrowserWindow.h:
651
652 2010-11-14  David Levin  <levin@chromium.org>
653
654         Reviewed by Daniel Bates.
655
656         check-webkit-style should detect PassRefPtr usage in functions.
657         https://bugs.webkit.org/show_bug.cgi?id=49513
658
659         * Scripts/webkitpy/style/checkers/cpp.py:
660         (check_for_function_lengths): Revert a comment change that I
661          accidentally made in r71986.
662         (check_pass_ptr_usage): Added the code to do the check.
663         (process_line): Added the call to check_pass_ptr_usage.
664         (CppChecker): Added the new error category.
665         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
666         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
667          testing purposes.
668         (PassPtrTest::*): The class/functions to unit test the new
669          functionality.
670
671 2010-11-14  David Levin  <levin@chromium.org>
672
673         Reviewed by Shinichiro Hamaji.
674
675         check-webkit-style function detection and the line count style checks should be separate.
676         https://bugs.webkit.org/show_bug.cgi?id=49512
677
678         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
679         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
680           call the detection function and fix line counts in two places now that
681           the code really only counts the lines in the body of the function.
682
683 2010-11-14  Andreas Kling  <kling@webkit.org>
684
685         Reviewed by Antonio Gomes.
686
687         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
688         https://bugs.webkit.org/show_bug.cgi?id=33438
689
690         Stifle "Unhandled variable" warning to match what the other
691         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
692         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
693
694         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
695         (webkit_test_plugin_get_value):
696
697 2010-11-13  David Levin  <levin@chromium.org>
698
699         Reviewed by Eric Seidel.
700
701         check-webkit-style function detection crashes on functions in templates.
702         https://bugs.webkit.org/show_bug.cgi?id=49504
703
704         For example "template <bool shouldClose(const Element*)>".
705
706         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
707         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
708           function detection test to expose this issue.
709
710 2010-11-12  David Levin  <levin@chromium.org>
711
712         Reviewed by Shinichiro Hamaji.
713
714         check-webkit-style function detection doesn't detect indented functions declaractions.
715         https://bugs.webkit.org/show_bug.cgi?id=49446
716
717         Indented function declarations occur inside class definitions, so
718         they are a pretty common (and worth detecting).
719
720         * Scripts/webkitpy/style/checkers/cpp.py:
721           Changed regex to allow indentation.
722           Changed the function start detection to only happen when not in a
723           function.
724           Changed function end detection to work based on matching braces
725           instead of finding a close brace at the beginning of the line.
726           Fixed close_expression to do what it says when it doesn't find
727           the close.
728         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
729
730 2010-11-12  Daniel Bates  <dbates@rim.com>
731
732         Rubber-stamped by Nikolas Zimmermann.
733
734         Make do-file-rename rename files in the directory WebKit2.
735
736         This also makes the list of searched directories in do-file-rename
737         consistent with the list of searched directories in the script do-webcore-rename.
738
739         * Scripts/do-file-rename:
740
741 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
742
743         Reviewed by James Robinson.
744
745         Attempt yet again to land the fix for bug 49360 (respecting
746         set-webkit-configuration). We need to handle the cases where
747         trying to run webkit-build-directory to find out where the
748         default configuration might be fails (that shows up on some
749         Chromium bots that apparently don't have perl installed).
750
751         https://bugs.webkit.org/show_bug.cgi?id=49360
752
753         * Scripts/webkitpy/layout_tests/port/config.py:
754         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
755         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
756
757 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
758
759         Reviewed by Adam Barth.
760
761         webkit-patch land logs commit message twice
762         https://bugs.webkit.org/show_bug.cgi?id=49482
763         
764         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
765         that's just the commit message, which we now output following the
766         actual commit.
767
768         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
769
770 2010-11-12  Tony Chang  <tony@chromium.org>
771
772         Reviewed by Adam Barth.
773
774         run platform/chromium/plugins/script-object-invoke.html on all platforms
775         https://bugs.webkit.org/show_bug.cgi?id=49280
776
777         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
778         (testScriptObjectInvoke):
779         (pluginInvoke):
780
781 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
782
783         Reviewed by Adam Barth.
784
785         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
786         https://bugs.webkit.org/show_bug.cgi?id=49471
787
788         Right now there's no indication of a successful commit.
789         
790         * Scripts/webkitpy/tool/commands/download_unittest.py:
791         * Scripts/webkitpy/tool/steps/commit.py:
792
793 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
794
795         Reviewed by Ojan Vafai.
796
797         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
798         https://bugs.webkit.org/show_bug.cgi?id=49354
799
800         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
801
802         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
803         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
804         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
805         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
806
807 2010-11-12  Tony Chang  <tony@chromium.org>
808
809         Reviewed by Kent Tamura.
810
811         [chromium] Load a blank page when closing DRT WebViewHosts
812         https://bugs.webkit.org/show_bug.cgi?id=49417
813
814         In test_shell, when we close a window, we first load about:blank
815         and run GC to fire the destruction logic of the page.  In test_shell,
816         this happens in ~TestShell.  In DRT, we manage virtual windows as
817         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
818
819         Managing focus is a bit trickier, since normally you would get window
820         events to reset the focus to the right window.  We do it manually
821         instead.
822
823         This fixes 2 plugin tests on DRT.
824
825         * DumpRenderTree/chromium/TestShell.cpp:
826         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
827         (TestShell::closeWindow): Move widget close() to WVH destructor and
828             manage focus manually.
829         (TestShell::closeRemainingWindows): Comment typo.
830         * DumpRenderTree/chromium/WebViewHost.cpp:
831         (WebViewHost::closeWidget):
832         (invokeCloseWidget):
833         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
834             test_shell).
835         (WebViewHost::~WebViewHost):
836         * DumpRenderTree/chromium/WebViewHost.h:
837
838 2010-11-12  David Levin  <levin@chromium.org>
839
840         Reviewed by Adam Barth.
841
842         cpp.py needs some tidying.
843         https://bugs.webkit.org/show_bug.cgi?id=49443
844
845         * Scripts/webkitpy/style/checkers/cpp.py:
846           Fix parameter ordering for iteratively_replace_matches_with_char
847           to mirror other similar functions (and improved comments, etc.)
848           Also, use a python-ism (for/else) to get rid of a variable that
849           was there to determine if something had been found in the loop.
850
851 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
852
853         Reviewed by James Robinson.
854
855         [Chromium/DRT] Make EventSendingController send complete touch events.
856         https://bugs.webkit.org/show_bug.cgi?id=49285
857
858         * DumpRenderTree/chromium/EventSender.cpp:
859         (EventSender::addTouchPoint):
860         (EventSender::updateTouchPoint):
861         (EventSender::sendCurrentTouchEvent):
862
863 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
864
865         Unreviewed rollout of r71858.
866
867         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
868         NaCl tests.
869
870         * Scripts/webkitpy/layout_tests/port/config.py:
871         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
872         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
873
874 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
875
876         Reviewed by Kenneth Rohde Christiansen.
877
878         [Qt] TestController::runUntil doesn't honor the timeout parameter
879         https://bugs.webkit.org/show_bug.cgi?id=48941
880
881         Implement the missing timeout of WebKitTestRunner for Qt.
882
883         A QElapsedTimer has been added to RunUntilConditionLoop in order
884         to measure how long the loop has been running. When the timer
885         is bigger or equal than the timeout, the loop ends even if the
886         condition is not met.
887
888         * WebKitTestRunner/qt/TestControllerQt.cpp:
889         (WTR::RunUntilConditionLoop::start):
890         (WTR::RunUntilConditionLoop::run):
891         (WTR::RunUntilConditionLoop::timerEvent):
892         (WTR::TestController::platformRunUntil):
893
894 2010-11-11  David Levin  <levin@chromium.org>
895
896         Reviewed by Shinichiro Hamaji.
897
898         check-webkit-style function detection doesn't handle templates with spaces.
899         https://bugs.webkit.org/show_bug.cgi?id=49427
900
901         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
902           finding the function name.
903         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
904           template with a space.
905
906 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
907
908         Reviewed by Shinichiro Hamaji.
909
910         Enable check-webkit-style on Qt files
911         https://bugs.webkit.org/show_bug.cgi?id=48322
912
913         Adding exception for _q_... private slots and
914         ..._data() methods in tests
915
916         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
917         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
918
919 2010-11-11  David Levin  <levin@chromium.org>
920
921         Reviewed by Shinichiro Hamaji.
922
923         check-webkit-style function detection doesn't work for templates and destructors.
924         https://bugs.webkit.org/show_bug.cgi?id=49425
925
926         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
927         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
928
929 2010-11-11  Joone Hur  <joone@kldp.org>
930
931         Reviewed by Antonio Gomes.
932
933         [GTK][DRT] Implement LayoutTestController::nodesFromRect
934         https://bugs.webkit.org/show_bug.cgi?id=46598
935
936         Support nodesFromRect in DRT
937
938         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
939         (LayoutTestController::nodesFromRect):
940
941 2010-11-11  MORITA Hajime  <morrita@google.com>
942
943         Reviewed by Kent Tamura.
944
945         editing/selection/context-menu-on-text.html fails on chromium
946         https://bugs.webkit.org/show_bug.cgi?id=45898
947
948         Enhance Chromium's EventSender::contextClick() to return
949         array of menu strings. The implementation incomplete because
950         Although actual context menu is implemented by the browser,
951         it reflects editability of underlying context thus makes
952         context-menu-on-text.html passed.
953         
954         * DumpRenderTree/chromium/EventSender.cpp:
955         (makeMenuItemStringsFor): Added.
956         (EventSender::contextClick): Now returns array of menu strings.
957         * DumpRenderTree/chromium/WebViewHost.cpp:
958         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
959         (WebViewHost::clearContextMenuData): Added.
960         (WebViewHost::lastContextMenuData): Added.
961         * DumpRenderTree/chromium/WebViewHost.h:
962
963 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
964
965         Unreviewed, build fix.
966
967         fix build breakage caused by fix for bug 49380 (r71858).
968
969         config_standalone needs to ensure that the packages it needs are
970         in sys.path.
971
972         https://bugs.webkit.org/show_bug.cgi?id=49419
973
974         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
975
976 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
977
978         Reviewed by Adam Roben.
979
980         Fix NRWT to respect set-webkit-configuration again :(
981
982         This change fixes a typo in config.py that was causing the wrong
983         value to be read initially and us never actually looking into
984         the filesystem to get the default configuration.
985         
986         * Scripts/webkitpy/layout_tests/port/config.py:
987         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
988         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
989
990 2010-11-11  Eric Seidel  <eric@webkit.org>
991
992         Reviewed by Adam Barth.
993
994         Split out Bug, Attachment and CommitterValidator from bugzilla.py
995         https://bugs.webkit.org/show_bug.cgi?id=49403
996
997         CommitterValidator really had nothing to do with bugzilla.py.
998         I've put it next to committers.py for now since its rather tied to that file.
999
1000         * Scripts/webkitpy/common/config/committervalidator.py: Added.
1001         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
1002         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
1003         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
1004         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
1005         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
1006         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1007         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1008         * Scripts/webkitpy/tool/bot/feeders.py:
1009         * Scripts/webkitpy/tool/commands/queues.py:
1010
1011 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
1012
1013         Reviewed by Eric Seidel.
1014
1015         fix missing 'pid' argument for http lockfile checking on win32
1016         https://bugs.webkit.org/show_bug.cgi?id=49363
1017
1018         * Scripts/webkitpy/common/system/executive.py:
1019
1020 2010-11-11  Eric Seidel  <eric@webkit.org>
1021
1022         Rubber-stamped by Adam Barth.
1023
1024         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
1025         https://bugs.webkit.org/show_bug.cgi?id=49402
1026
1027         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
1028         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
1029         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
1030
1031 2010-11-10  Chris Guillory  <chris.guillory@google.com>
1032
1033         Reviewed by Chris Fleizach.
1034
1035         Use IAccessibleComparable to compare accessibility objects.
1036         https://bugs.webkit.org/show_bug.cgi?id=49118
1037
1038         * DumpRenderTree/AccessibilityUIElement.cpp:
1039         (AccessibilityUIElement::isEqual):
1040         * DumpRenderTree/AccessibilityUIElement.h:
1041         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1042         (comparableObject):
1043         (AccessibilityUIElement::isEqual):
1044
1045 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
1046
1047         Reviewed by David Hyatt.
1048
1049         HTML5 Ruby support should be mandatory feature
1050         https://bugs.webkit.org/show_bug.cgi?id=49272
1051
1052         Remove Ruby as optional feature.
1053
1054         * Scripts/build-webkit:
1055
1056 2010-11-10  Adam Roben  <aroben@apple.com>
1057
1058         Print VC++ Express build logs in the same order that the projects are
1059         built
1060
1061         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
1062         in an unhelpful order
1063
1064         Reviewed by Eric Seidel.
1065
1066         * Scripts/print-vse-failure-logs:
1067         (PrintVisualStudioExpressLogs._build_order): Added. Uses
1068         print-msvc-project-dependencies to figure out the order in which
1069         projects are built.
1070         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
1071         based on their build order and project name.
1072         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
1073         scripts directory from here...
1074         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
1075         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
1076         them.
1077
1078 2010-11-10  Adam Roben  <aroben@apple.com>
1079
1080         Only print the interesting text from VC++ Express build logs
1081
1082         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
1083         output from print-vse-failure-logs
1084
1085         Reviewed by Eric Seidel.
1086
1087         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
1088         added newly-required imports. Removed a comment that was essentially a
1089         FIXME, and is now fixed.
1090         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
1091         BeautifulSoup to extract the relevant text from the build log.
1092         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
1093
1094 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
1095
1096         Reviewed by Tony Chang.
1097
1098         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
1099         https://bugs.webkit.org/show_bug.cgi?id=49286
1100         
1101         The tests in http/tests/security/XFrameOptions started to fail after
1102         r71297, since it changed the WebViewHost::assignIdentifierToRequest
1103         logic to always assign identifiers to requests, even if we're not going
1104         to be dumping resource load callbacks at that point. These tests
1105         only call LayoutTestController.dumpResourceLoadCallbacks after the
1106         request is started, thus their expectations have "<unknown>" as the
1107         identifier. Change WebViewHost to the previous behavior, which also
1108         match the other ports'.
1109
1110         * DumpRenderTree/chromium/WebViewHost.cpp:
1111         (WebViewHost::assignIdentifierToRequest):
1112         (WebViewHost::removeIdentifierForRequest):
1113
1114 2010-11-08  Tony Chang  <tony@chromium.org>
1115
1116         Reviewed by Adam Barth.
1117
1118         run platform/chromium/plugins/return-npobject.html on all platforms
1119         https://bugs.webkit.org/show_bug.cgi?id=49103
1120
1121         This tests that we can get an NPObject returned through a method on
1122         an NPAPI Object.
1123
1124         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1125         (testCallbackReturn):
1126         (pluginInvoke):
1127
1128 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1129
1130         Unreviewed, rolling out r71672.
1131         http://trac.webkit.org/changeset/71672
1132         https://bugs.webkit.org/show_bug.cgi?id=49276
1133
1134         It doesn't work on Chromium Windows bot (Requested by Ossy on
1135         #webkit).
1136
1137         * Scripts/webkitpy/common/system/file_lock.py: Removed.
1138         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
1139         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1140
1141 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1142
1143         Reviewed by Tony Chang.
1144
1145         [NRWT] Make http locking similar to perl implementation
1146         https://bugs.webkit.org/show_bug.cgi?id=49187
1147
1148         * Scripts/webkitpy/common/system/file_lock.py: Added.
1149         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
1150         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1151
1152 2010-11-09  James Kozianski  <koz@chromium.org>
1153
1154         Reviewed by Eric Seidel.
1155
1156         Clean up imports for webkit-patch.
1157         https://bugs.webkit.org/show_bug.cgi?id=49083
1158
1159         Move some imports from commands into main.py where they are used.
1160         Move command imports into the __init__ of the commands module.
1161
1162         * Scripts/webkitpy/tool/commands/__init__.py:
1163         * Scripts/webkitpy/tool/commands/download.py:
1164         * Scripts/webkitpy/tool/commands/queues.py:
1165         * Scripts/webkitpy/tool/main.py:
1166
1167 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
1168
1169         Reviewed by Andreas Kling.
1170
1171         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
1172         https://bugs.webkit.org/show_bug.cgi?id=49047
1173
1174         * QtTestBrowser/mainwindow.cpp:
1175         (MainWindow::setAddressUrl):
1176
1177 2010-11-09  Andras Becsi  <abecsi@webkit.org>
1178
1179         Reviewed by Csaba Osztrogonác.
1180
1181         Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
1182         https://bugs.webkit.org/show_bug.cgi?id=49252
1183
1184         * Scripts/old-run-webkit-tests:
1185
1186 2010-11-09  Csaba Osztrogonác  <ossy@webkit.org>
1187
1188         Reviewed by Tor Arne Vestbø.
1189
1190         Output of old-run-webkit-tests is buggy in verbose mode
1191         https://bugs.webkit.org/show_bug.cgi?id=49249
1192
1193         * Scripts/old-run-webkit-tests: Redundant outputs removed.
1194
1195 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
1196
1197         Reviewed by Martin Robinson.
1198
1199         [GTK] Link with target name set does not work
1200         https://bugs.webkit.org/show_bug.cgi?id=48865
1201
1202         When a new page is created with a name (target=myFrame), the new
1203         mainFrame could not be found because they where not stored in the
1204         same PageGroup. As PageGroup are not exposed externally so the
1205         simpliest solution is to use a global page group name. This also fixes
1206         issue with visited link coloration across pages. After this change the
1207         private function webkit_web_view_set_group_name() was no longer used
1208         so it was removed completly.
1209
1210         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1211         (createWebView):
1212
1213 2010-11-08  John Knottenbelt  <jknotten@chromium.org>
1214
1215         Reviewed by Kent Tamura.
1216
1217         WebViewHost::reset() uses placement new.
1218         https://bugs.webkit.org/show_bug.cgi?id=49069
1219
1220         WebViewHost is using placement destruction / new to simulate a fresh
1221         WebViewHost object at the same address. This is because the WebView remains
1222         open across tests and maintains a pointer to the WebViewHost.
1223         This change resets member variables explictly instead of the placement new dance.
1224
1225         * DumpRenderTree/chromium/WebViewHost.cpp:
1226         (WebViewHost::WebViewHost):
1227         (WebViewHost::reset):
1228
1229 2010-11-08  Dirk Pranke <dpranke@chromium.org>
1230
1231         Reviewed by Eric Seidel.
1232
1233         Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py. 
1234         It turns out that NRWT can't use the code in scm.find_checkout_root()
1235         because the Chromium bots don't do full checkouts of the WebKit
1236         tree; they only check out subdirectories like WebKitTools/Scripts.
1237         Until we can figure out a better approach for this, I've
1238         restored the base_dir-detecting code from NRWT, which works in
1239         any directory tree, scm or no.
1240
1241         This also restores the files modified in r71475 and r71474.
1242
1243         https://bugs.webkit.org/show_bug.cgi?id=49151
1244
1245         * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
1246         * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
1247
1248 2010-11-08  Eric Seidel  <eric@webkit.org>
1249
1250         Reviewed by Adam Barth.
1251
1252         webkit-patch failure-reason explodes if a build is missing
1253         https://bugs.webkit.org/show_bug.cgi?id=49195
1254
1255         This is likely a recent regression.  Adding a unit test for this case.
1256
1257         * Scripts/webkitpy/common/net/buildbot.py:
1258         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1259
1260 2010-11-08  Dan Bernstein  <mitz@apple.com>
1261
1262         Reviewed by Darin Adler.
1263
1264         Ignore the system scrollbar setting.
1265
1266         * DumpRenderTree/mac/DumpRenderTree.mm:
1267         (resetDefaultsToConsistentValues): Set the scrollbar default.
1268
1269 2010-11-05  Adam Roben  <aroben@apple.com>
1270
1271         Make webkitpy.common.system.executive_unittest pass when running under
1272         Win32 Python
1273
1274         Fixes <http://webkit.org/b/49033>.
1275
1276         Reviewed by Dave Levin and Eric Seidel.
1277
1278         * Scripts/webkitpy/common/system/executive.py:
1279         (Executive._run_command_with_teed_output): Pass the arguments through
1280         encode_argument_if_needed rather than using Cygwin-specific code here.
1281         (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
1282         the output.
1283         (Executive.run_command): Use encode_argument_if_needed to encode the
1284         arguments and child_process_encoding to decode the output.
1285         (Executive._child_process_encoding): Returns the encoding that should be
1286         used when communicating with child processes. On Windows we use mbcs,
1287         which maps to the current code page. On all other platforms we use
1288         UTF-8.
1289         (Executive._should_encode_child_process_arguments): Returns True if
1290         arguments to child processes need to be encoded. This is currently
1291         only needed on Cygwin and Win32 Python 2.x.
1292         (Executive._encode_argument_if_needed): Encode the argument using
1293         child_process_encoding if we need to encode arguments to child
1294         processes on this platform.
1295
1296         * Scripts/webkitpy/common/system/executive_unittest.py:
1297         (never_ending_command): Added. Returns arguments to run a command that
1298         will not quit until we kill it. On Windows we use wmic, on other
1299         platforms we use yes.
1300         (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
1301         mbcs encoding to be used and for output from the child processes to
1302         have been roundtripped through encode/decode on Win32 Python. When
1303         UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
1304         it's possible that some characters will not be able to be converted
1305         and will be replaced by question marks; the round-tripping allows us
1306         to expect this result.
1307
1308         (ExecutiveTest.test_kill_process):
1309         (ExecutiveTest.test_kill_all):
1310         Use never_ending_command instead of invoking "yes" directly. Expect an
1311         exit code of 1 when using Win32 Python, as that's what seems to happen.
1312
1313 2010-11-08  Adam Roben  <aroben@apple.com>
1314
1315         Roll out r71532
1316
1317         It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
1318         .bashrc unsets %TEMP%, which broke copy-tools.cmd.
1319
1320         * Scripts/webkitdirs.pm:
1321
1322 2010-11-08  Tony Chang  <tony@chromium.org>
1323
1324         Reviewed by Adam Barth.
1325
1326         run platform/chromium/plugins/nested-plugin-objects.html on all platforms
1327         https://bugs.webkit.org/show_bug.cgi?id=49094
1328
1329         This tests that objects created by plugins are proplery cleaned up.
1330
1331         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1332         (testPassTestObject):
1333         (pluginInvoke):
1334         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1335         (testAllocate):
1336         (testDeallocate):
1337         (testGetProperty):
1338         (testConstruct):
1339
1340 2010-11-08  Adam Roben  <aroben@apple.com>
1341
1342         Mark Windows builds triggered from Perl as being non-interactive
1343
1344         This affects whether some of our scripts will show alerts vs. printing
1345         to the build log.
1346
1347         Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
1348         .vsprops files are updated
1349
1350         Reviewed by Steve Falkenburg.
1351
1352         * Scripts/webkitdirs.pm:
1353         (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
1354
1355 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1356
1357         Reviewed by Ojan Vafai.
1358
1359         Make http locking default in NRWT.
1360         https://bugs.webkit.org/show_bug.cgi?id=48053
1361
1362         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1363         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1364
1365 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1366
1367         Reviewed by Csaba Osztrogonác.
1368
1369         [NRWT] If the http lock fails we shouldn't do any locking
1370         https://bugs.webkit.org/show_bug.cgi?id=49164
1371
1372         If something goes wrong with the locking, the test should keep going.
1373
1374         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1375
1376 2010-11-08  Adam Roben  <aroben@apple.com>
1377
1378         Switch back to using kCGImageAlphaPremultipliedFirst when generating
1379         pixel dumps on Windows
1380
1381         I changed this behavior in r71418 thinking that it was required for
1382         getting plugins to show up in pixel dumps. But it doesn't seem to be
1383         necessary, and was making it impossible to compare new Windows pixel
1384         dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
1385         compare an image with alpha to an image without alpha).
1386
1387         Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
1388         new Windows pixel results to existing Windows or Mac results
1389
1390         Reviewed by Antti Koivisto.
1391
1392         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1393         (createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
1394         with kCGImageAlphaPremultipliedFirst.
1395
1396 2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
1397
1398         Unreviewed, rolling out r71466.
1399         http://trac.webkit.org/changeset/71466
1400         https://bugs.webkit.org/show_bug.cgi?id=48865
1401
1402         It broke layout tests on GTK bots.
1403
1404         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1405         (createWebView):
1406
1407 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1408
1409         Reviewed by Csaba Osztrogonác.
1410
1411         Enable running of Qt API tests on BuildBot
1412         https://bugs.webkit.org/show_bug.cgi?id=49004
1413
1414         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1415
1416 2010-11-08  Eric Seidel  <eric@webkit.org>
1417
1418         Reviewed by Adam Barth.
1419
1420         Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
1421         https://bugs.webkit.org/show_bug.cgi?id=49160
1422
1423         Bugzilla doesn't automatically remove r? when a bug gets closed.
1424         This script takes care of that for webkit.org.
1425
1426         * Scripts/webkitpy/common/net/bugzilla.py:
1427         * Scripts/webkitpy/tool/commands/upload.py:
1428
1429 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
1430
1431         Unreviewed, rolling out r71474.
1432         http://trac.webkit.org/changeset/71474
1433         https://bugs.webkit.org/show_bug.cgi?id=48280
1434
1435         breaks chromium webkit tests
1436         https://bugs.webkit.org/show_bug.cgi?id=49151
1437
1438         * Scripts/webkitpy/layout_tests/port/base.py:
1439         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1440         * Scripts/webkitpy/layout_tests/port/config.py:
1441         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1442         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1443         * Scripts/webkitpy/layout_tests/port/webkit.py:
1444         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1445         * Scripts/webkitpy/tool/mocktool.py:
1446
1447 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
1448
1449         Unreviewed, rolling out r71475.
1450         http://trac.webkit.org/changeset/71475
1451  
1452         breaks chromium webkit tests
1453         https://bugs.webkit.org/show_bug.cgi?id=49151
1454
1455         * Scripts/webkitpy/common/newstringio.py: Removed.
1456         * Scripts/webkitpy/common/newstringio_unittest.py: Removed.
1457         * Scripts/webkitpy/common/system/executive_mock.py: Removed.
1458         * Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
1459         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
1460
1461 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
1462
1463         Unreviewed, build fix.
1464
1465         Add files inexplicably not committed in r71474 as part of the
1466         fix for bug 48280.
1467
1468         * Scripts/webkitpy/common/newstringio.py: Added.
1469         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
1470         * Scripts/webkitpy/common/system/executive_mock.py: Added.
1471         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
1472         * Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
1473
1474 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
1475
1476         Reviewed by Eric Siedel.
1477
1478         new-run-webkit-tests: update port/base and port/webkit to use the
1479         new FileSystem and Config abstractions, pulling more logic out of
1480         the base Port classes into separate, mockable objects.
1481
1482         Also create a MockFileSystem object, a MockConfig object, move
1483         MockExecutive into common/system to be next to executive, and
1484         update the config object to use a FileSystem.
1485
1486         https://bugs.webkit.org/show_bug.cgi?id=48280
1487
1488         * Scripts/webkitpy/common/newstringio.py: Added.
1489         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
1490         * Scripts/webkitpy/common/system/executive_mock.py: Added.
1491         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
1492         * Scripts/webkitpy/layout_tests/port/base.py:
1493         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1494         * Scripts/webkitpy/layout_tests/port/config.py:
1495         * Scripts/webkitpy/layout_tests/port/config_mock.py:
1496         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1497         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1498         * Scripts/webkitpy/layout_tests/port/webkit.py:
1499         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1500         * Scripts/webkitpy/tool/mocktool.py:
1501
1502 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
1503
1504         Unreviewed, build breakage.
1505
1506         Apparently I uploaded the wrong version of the file to fix 49122
1507         and neither Eric or I noticed - it was missing a dirname() call.
1508         Fixing ...
1509
1510         https://bugs.webkit.org/show_bug.cgi?id=49122
1511
1512         * Scripts/webkitpy/common/checkout/scm.py:
1513
1514 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
1515
1516         Reviewed by Eric Seidel.
1517
1518         webkitpy/tool/* unittests change cwd and don't clean up properly
1519
1520         https://bugs.webkit.org/show_bug.cgi?id=49122
1521
1522         * Scripts/webkitpy/common/checkout/scm.py:
1523
1524 2010-11-05  Chris Marrin  <cmarrin@apple.com>
1525
1526         Reviewed by Simon Fraser.
1527
1528         suspendAnimations/resumeAnimations not present in WebKit2
1529         https://bugs.webkit.org/show_bug.cgi?id=49109
1530
1531         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1532         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1533         (WTR::LayoutTestController::suspendAnimations):
1534         (WTR::LayoutTestController::resumeAnimations):
1535         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1536
1537 2010-11-05  Tony Chang  <tony@chromium.org>
1538
1539         Reviewed by David Levin.
1540
1541         cleanup style in TestNetscapePlugIn/PluginObject.cpp
1542         https://bugs.webkit.org/show_bug.cgi?id=49044
1543
1544         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1545         (getPluginClass):
1546         (pluginGetProperty):
1547         (pluginSetProperty):
1548         (variantToIdentifier):
1549         (testCallback):
1550         (getURL):
1551         (getURLNotify):
1552         (testInvokeDefault):
1553         (testGetProperty):
1554         (testDocumentOpen):
1555         (testWindowOpen):
1556         (pluginInvoke):
1557         (handleCallback):
1558         (notifyStream):
1559         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1560
1561 2010-11-05  Eric Seidel  <eric@webkit.org>
1562
1563         Reviewed by David Levin.
1564
1565         Add QueueStatusServer/__init__.py so others can run the QueueStatusServer tests
1566         https://bugs.webkit.org/show_bug.cgi?id=49032
1567
1568         I wrote this file as part of bug 47847, but I forgot to commit it.
1569         No one else noticed it missing because test-webkitpy knows how
1570         to recover in the case where it can't import QueueStatusServer
1571         (which generally occurs due to not having installed the AppEngine SDK).
1572
1573         * QueueStatusServer/__init__.py: Added.
1574         * QueueStatusServer/model/workitems_unittest.py:
1575          - Remove a test which fails.  This was probably landed (by me)
1576            from my other machine, which since this __init__.py was missing
1577            I never noticed the failure and landed this invalid test.
1578            Sadly we can't really test remove_work_item as it depends
1579            on .key() working.  .key() will throw unless the object
1580            has already been saved it seems.
1581            This may be a mis-design in our remove_work_item implementation,
1582            but for now, just removing the test.
1583
1584 2010-11-04  Adam Roben  <aroben@apple.com>
1585
1586         Teach check-webkit-style about TestNetscapePlugIn
1587
1588         Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
1589         TestNetscapePlugIn's coding conventions
1590
1591         Reviewed by John Sullivan.
1592
1593         * Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with
1594         WebKitAPITest and TestWebKitAPI in having different include order and
1595         naming conventions than WebCore. Added some comments about why the
1596         exceptions exist.
1597
1598 2010-11-04  Adam Roben  <aroben@apple.com>
1599
1600         Add a test that shows that windowed plugins are able to paint
1601
1602         Somehow we never had a test for this before.
1603
1604         Fixes <http://webkit.org/b/49029> Should add a test that shows
1605         windowed plugins can paint
1606
1607         Reviewed by Jon Honeycutt.
1608
1609         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.
1610         (DrawsGradient::DrawsGradient):
1611         (DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.
1612
1613         (DrawsGradient::onPaint):
1614         (DrawsGradient::onPrintClient):
1615         These both just call through to paint.
1616
1617         (DrawsGradient::paint): Fills our client area with some gradients.
1618
1619         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link
1620         against Msimg32.lib for ::GradientFill and added DrawsGradient.
1621
1622         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1623         (createBitmapContextFromWebView): Use WM_PRINT instead of
1624         WM_PRINTCLIENT so that ::DefWindowProc will send
1625         WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
1626         Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
1627         because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
1628         kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
1629         will run on a big-endian platform.
1630
1631 2010-11-04  Adam Roben  <aroben@apple.com>
1632
1633         Extract much of NPNInvalidateRectInvalidatesWindow's code into a
1634         WindowedPluginTest base class
1635
1636         The base class takes care of subclassing the plugin's window so that a
1637         custom WNDPROC is called. This will make it easier to write tests that
1638         need to handle window messages.
1639
1640         Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
1641         a custom WNDPROC
1642
1643         Reviewed by Jon Honeycutt.
1644
1645         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
1646         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
1647         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
1648         (NPNInvalidateRectInvalidatesWindow::wndProc):
1649         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
1650         Moved code from here to WindowedPluginTest. Changed to use window()
1651         instead of m_window.
1652
1653         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1654         Added WindowedPluginTest and added TestNetscapePlugIn/win to the
1655         include path. Also reordered the include path to make a little more
1656         sense and simplified the entry that added TestNetscapePlugIn itself to
1657         the include path.
1658
1659         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.
1660         (WindowedPluginTest::WindowedPluginTest):
1661         (WindowedPluginTest::NPP_SetWindow):
1662         (WindowedPluginTest::staticWndProc):
1663         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.
1664         (WindowedPluginTest::window):
1665         Code came from NPNInvalidateRectInvalidatesWindow.
1666
1667 2010-11-04  Adam Roben  <aroben@apple.com>
1668
1669         Add a plugin test to show that windowed plugins are clipped correctly
1670
1671         Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
1672         plugins aren't clipped in WebKit2 on Windows
1673
1674         Reviewed by Jon Honeycutt.
1675
1676         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.
1677         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
1678         (WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
1679         region matches the clip rect we know we should have based on
1680         window-region-is-set-to-clip-rect.html, and check that our window class
1681         doesn't have the CS_PARENTDC style.
1682
1683         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1684         Added WindowRegionIsSetToClipRect.
1685
1686 2010-11-05  Alejandro G. Castro  <alex@igalia.com>
1687
1688         Reviewed by Martin Robinson.
1689
1690         [GTK] Avoid font hinting in the DRT
1691         https://bugs.webkit.org/show_bug.cgi?id=48548
1692
1693         Change the settings to avoid font hinting, it was causing
1694         different results depending on the distribution.
1695
1696         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1697         (initializeGtkFontSettings):
1698         * DumpRenderTree/gtk/fonts/fonts.conf:
1699
1700 2010-11-05  Eric Seidel  <eric@webkit.org>
1701
1702         Reviewed by Adam Barth.
1703
1704         build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
1705         https://bugs.webkit.org/show_bug.cgi?id=49051
1706
1707         This is a speculative fix.  The unit tests cover these methods, however
1708         I don't know if this will fully stop the system.log spam.
1709
1710         * Scripts/webkitpy/layout_tests/port/base.py:
1711         * Scripts/webkitpy/layout_tests/port/webkit.py:
1712
1713 2010-11-05  Eric Seidel  <eric@webkit.org>
1714
1715         Reviewed by Adam Barth.
1716
1717         Add basic support for showing bot id on /queue-status/ pages
1718         https://bugs.webkit.org/show_bug.cgi?id=49037
1719
1720         This support is really simple.  Eventually we'll want to
1721         show the bot id in the lock table too, but we don't have
1722         that information stored in the server yet.
1723
1724         * QueueStatusServer/handlers/queuestatus.py:
1725         * QueueStatusServer/handlers/queuestatus_unittest.py: Added.
1726         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1727
1728 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
1729
1730         Reviewed by Adam Barth.
1731
1732         Create a filesystem wrapper that we can use to enforce
1733         particular conventions and use for mocking and dependency
1734         injection down the line.
1735
1736         https://bugs.webkit.org/show_bug.cgi?id=48144
1737
1738         * Scripts/webkitpy/common/system/filesystem.py: Added.
1739         * Scripts/webkitpy/common/system/filesystem_unittest.py: Added.
1740
1741 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
1742
1743         Reviewed by Tony Chang.
1744
1745         run_webkit_tests_unittest fails under Python 2.5
1746         https://bugs.webkit.org/show_bug.cgi?id=49043
1747         
1748         Switch from itertools.chain.from_iterable (which was added in 2.6)
1749         to using itertools.chain directly.
1750
1751         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1752
1753 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
1754
1755         Unreviewed fix to webkit-patch rebaseline-server so that it runs under
1756         Python 2.5 (it needs an import to use the with statement).
1757
1758         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1759
1760 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
1761
1762         Reviewed by Adam Barth.
1763
1764         new-run-webkit-tests: split out webkit-specific configuration stuff into a new module
1765
1766         The current NRWT code has webkit-specific configuration code (like
1767         _script_path, default configuration, etc.) mixed in with
1768         layout-test-specific stuff in port/base. The configuration code
1769         should be split out into a separate module for easier mocking,
1770         testing, and isolation.
1771
1772         https://bugs.webkit.org/show_bug.cgi?id=48264
1773
1774         * Scripts/webkitpy/layout_tests/port/config.py: Added.
1775         * Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.
1776
1777 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
1778
1779         Reviewed by Tony Chang.
1780
1781         Rebaseline server: initial framework
1782         https://bugs.webkit.org/show_bug.cgi?id=48892
1783         
1784         Adds the basic framework for the rebaseline server (details at 
1785         http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
1786         command, which starts an HTTP server that can serve static files or
1787         invoke handler methods on a class.
1788
1789         * Scripts/webkitpy/tool/commands/__init__.py:
1790         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
1791         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
1792         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
1793         * Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.
1794
1795 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
1796
1797         Reviewed by James Robinson.
1798
1799         new-run-webkit-tests wasn't using DRT by default for
1800         --platform chromium-gpu
1801
1802         The default value was set to False instead of None, which meant
1803         that the platform specific logic wasn't firing to change the
1804         value to True (b/c we were afraid we'd be overriding the user
1805         preference).
1806
1807         https://bugs.webkit.org/show_bug.cgi?id=49038
1808
1809         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1810
1811 2010-11-04  Tony Chang  <tony@chromium.org>
1812
1813         Reviewed by Adam Barth.
1814
1815         make platform/chromium/plugins/multiple-plugins.html pass on all platforms
1816         https://bugs.webkit.org/show_bug.cgi?id=49026
1817
1818         Have the testObject.bar property return the string "bar".  This lets
1819         us run and pass platform/chromium/plugins/multiple-plugins.html on all
1820         platforms.
1821
1822         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1823         (testGetProperty):
1824
1825 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
1826
1827         Reviewed by Tony Chang.
1828
1829         NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc.
1830         https://bugs.webkit.org/show_bug.cgi?id=48878
1831         
1832         Add get_tests_run so that it's easy to see which tests get run (and with
1833         what batching) for a given flag combination. Flesh out the various
1834         test cases that have FIXMEs.
1835         
1836         Also fixes an off-by-one error (batch sizes were one larger than 
1837         expected) and makes --run-part also have wraparound behavior, like
1838         --run-chunk.
1839
1840         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1841         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1842         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1843
1844 2010-11-04  Erik Arvidsson  <arv@chromium.org>
1845
1846         Reviewed by Dimitri Glazkov.
1847
1848         Support box-sizing without the vendor prefix
1849         https://bugs.webkit.org/show_bug.cgi?id=36713
1850
1851         Based on patch by Peter Beverloo <peter@lvp-media.com>
1852
1853         * iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing.
1854
1855 2010-11-04  Csaba Osztrogonác  <ossy@webkit.org>
1856
1857         Unreviewed rollout r71340, because it broke Chromium Windows bot.
1858
1859         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1860         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1861
1862 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1863
1864         Reviewed by Ojan Vafai.
1865
1866         Make http locking default in NRWT.
1867         https://bugs.webkit.org/show_bug.cgi?id=48053
1868
1869         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1870         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1871
1872 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1873
1874         Reviewed by Eric Seidel.
1875
1876         [NRWT] Clear invalid http locks on Windows platform as well
1877         https://bugs.webkit.org/show_bug.cgi?id=48515
1878
1879         * Scripts/webkitpy/common/system/executive.py:
1880         * Scripts/webkitpy/common/system/executive_unittest.py:
1881         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1882
1883 2010-11-02  Adam Roben  <aroben@apple.com>
1884
1885         Reduce our dependence on coreutils when running Python tests
1886
1887         This patch introduces versions of the standard echo and cat utilities
1888         implemented in Python. They are probably missing features of their
1889         coreutils equivalents, but they can do what's necessary for our Python
1890         tests. This is useful on Windows, where these utilities typically
1891         aren't available.
1892
1893         Fixes <http://webkit.org/b/48883> executive_unittest relies on echo
1894         and cat utilities from coreutils, which are not present on Windows
1895
1896         Reviewed by Eric Seidel.
1897
1898         * Scripts/webkitpy/common/system/executive_unittest.py: Changed to use
1899         our Python-based echo and cat.
1900
1901         * Scripts/webkitpy/common/system/fileutils.py: Added.
1902         (make_stdout_binary): On Windows, puts sys.stdout into binary mode so
1903         that \n won't be translated into \r\n. I couldn't think of a good way
1904         to test this directly without touching the filesystem, but it is tested
1905         indirectly by echo_unittest.
1906
1907         * Scripts/webkitpy/test/cat.py: Added.
1908         (command_arguments): Returns a list for invoking cat with the given arguments.
1909         (main): Acts like a simplified version of the coreutils cat utility.
1910
1911         * Scripts/webkitpy/test/cat_unittest.py: Added.
1912         (CatTest.assert_cat): Runs cat with the given input and ensures the
1913         output matches the input.
1914         (CatTest.test_basic): Performs a simple test of cat.
1915         (CatTest.test_no_newline): Tests what happens when the input string
1916         doesn't have a trailing newline.
1917         (CatTest.test_unicode): Tests passing a unicode string to cat.
1918         (CatTest.test_as_command): Tests running cat as a separate command.
1919
1920         * Scripts/webkitpy/test/echo.py: Added.
1921         (command_arguments): Returns a list for invoking echo with the given arguments.
1922         (main): Acts like a simplified version of the coreutils echo utility.
1923
1924         * Scripts/webkitpy/test/echo_unittest.py: Added.
1925         (EchoTest.test_basic): Performs a simple test of echo.
1926         (EchoTest.test_no_newline): Tests passing -n to echo to suppress the
1927         trailing newline.
1928         (EchoTest.test_unicode): Tests passing unicode and non-unicode strings
1929         to echo.
1930         (EchoTest.test_argument_order): Tests what happens when -n is not the
1931         first argument.
1932         (EchoTest.test_empty_arguments): Tests what happens when you pass [] to
1933         echo.main.
1934         (EchoTest.test_no_arguments): Tests what happens when you call
1935         echo.main with no arguments.
1936         (EchoTest.test_as_command): Tests running echo as a separate command.
1937
1938 2010-11-04  Renata Hodovan  <reni@inf.u-szeged.hu>
1939
1940         Unreviewed: Add myself to the list of Committers.
1941
1942         * Scripts/webkitpy/common/config/committers.py:
1943
1944 2010-11-04  Andreas Kling  <kling@webkit.org>
1945
1946         Reviewed by Kenneth Rohde Christiansen.
1947
1948         [Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode
1949
1950         In RTC mode the QGraphicsWebView item is the size of the contents,
1951         scrolling works a bit differently  (we need to react to scrollRequested.)
1952
1953         Normally QGraphicsView will replay the last mouse event when scrolling,
1954         so to prevent WebKit from getting confused by this we temporarily make
1955         the QGraphicsView non-interactive.
1956
1957         * QtTestBrowser/webview.cpp:
1958         (WebViewGraphicsBased::setPage):
1959         (WebViewGraphicsBased::scrollRequested):
1960         * QtTestBrowser/webview.h:
1961
1962 2010-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1963
1964         Reviewed by Andreas Kling.
1965
1966         Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt
1967
1968         PLATFORM(MAC) is not defined for the Qt port, as it refers to
1969         the Mac-port, not the Mac OS X operating system.
1970
1971         * WebKitTestRunner/qt/TestControllerQt.cpp:
1972         (WTR::isExistingLibrary):
1973
1974 2010-11-04  Leonid Ebril  <leonid.ebril@nokia.com>
1975
1976         Reviewed by Andreas Kling.
1977
1978         [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
1979         https://bugs.webkit.org/show_bug.cgi?id=48869
1980
1981         * QtTestBrowser/useragentlist.txt:
1982
1983 2010-11-03  Adam Roben  <aroben@apple.com>
1984
1985         Always use uppercase drive names in strings returned by abspath_to_uri
1986
1987         Some versions of cygpath use lowercase drive letters while others use
1988         uppercase, which makes it hard to test the output of code that uses
1989         cygpath.
1990
1991         Fixes <http://webkit.org/b/48914> webkitpy.common.system.path_unittest
1992         fails with Cygwin 1.5
1993
1994         Reviewed by Eric Seidel.
1995
1996         * Scripts/webkitpy/common/system/path.py:
1997         (cygpath): Updated the docstring to indicate that only absolute paths
1998         should be passed for now (though relative paths will work fine).
1999         (_Cygpath.convert): Upper-case the first letter of the converted Windows path.
2000
2001 2010-11-03  George Guo  <George.Guo@Nokia.com>
2002
2003         Reviewed by Andreas Kling.
2004
2005         [Qt] QtTestBrowser : set mmp rule pageddata in Symbian
2006         https://bugs.webkit.org/show_bug.cgi?id=48767
2007     
2008         Paging is needd on Symbian devices to support benchmarks tests like
2009         dromaeo.com and Celtic Kane that need a lot of memory to run  
2010
2011         * QtTestBrowser/QtTestBrowser.pro:
2012
2013 2010-11-03  Jenn Braithwaite  <jennb@chromium.org>
2014
2015         Reviewed by Dmitry Titov.
2016
2017         Chromium: Update resource tracking when moving a frame between documents
2018         https://bugs.webkit.org/show_bug.cgi?id=48363
2019
2020         * DumpRenderTree/chromium/WebViewHost.cpp:
2021         (WebViewHost::assignIdentifierToRequest):
2022         Always put resource id in map so we can make assumptions about its
2023         presence.
2024         (WebViewHost::removeIdentifierForRequest):
2025         Added.
2026         (WebViewHost::didFinishResourceLoad):
2027         (WebViewHost::didFailResourceLoad):
2028         Check existence of resource id before removing from map.
2029         * DumpRenderTree/chromium/WebViewHost.h:
2030
2031 2010-11-03  Victor Wang  <victorw@chromium.org>
2032
2033         Reviewed by Adam Barth.
2034
2035         [Chromium] update buildbot names in chromium rebaseline tool.
2036
2037         https://bugs.webkit.org/show_bug.cgi?id=48881
2038
2039         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2040
2041 2010-11-03  Darin Adler  <darin@apple.com>
2042
2043         Updated Xcode projects by opening them with Xcode 3.2.4.
2044         Updated svn:ignore for Xcode projects.
2045
2046         * MiniBrowser/MiniBrowser.xcodeproj: Added property svn:ignore.
2047         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added property svn:ignore.
2048         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2049         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
2050
2051 2010-11-03  Adam Roben  <aroben@apple.com>
2052
2053         Stop waiting for messages from the web process after a timeout elapses
2054
2055         TestController::runUntil now takes a timeout parameter that specifies
2056         how long to wait for the condition to become true. WebKitTestRunner
2057         takes a --timeout flag that specifies how long the timeout should be.
2058         run-webkit-tests passes this flag to WebKitTestRunner so its timeout
2059         will be similar to run-webkit-tests.
2060
2061         Fixes <http://webkit.org/b/43047> <rdar://problem/8365833>
2062         WebKitTestRunner waits forever if the web process crashes
2063
2064         Reviewed by Darin Adler and Anders Carlsson.
2065
2066         * Scripts/old-run-webkit-tests:
2067         (top level): Moved the GuardMalloc timeout adjustment here from
2068         readFromDumpToolWithTimer.
2069         (openDumpTool): Make WTR use a timeout similar to but slightly shorter
2070         than the one that was specified on the command line.
2071
2072         * WebKitTestRunner/TestController.cpp:
2073         (WTR::TestController::TestController): Initialize our timeout values.
2074         (WTR::TestController::initialize): Parse the --timeout flag and use it
2075         to modify our timeout values.
2076         (WTR::TestController::resetStateToConsistentValues): Changed to use a
2077         short timeout while waiting for the web process to reset and to return
2078         a boolean indicating whether we were able to reset the web process.
2079         Uses a 5-second timeout while waiting for the process to be reset.
2080         (WTR::TestController::runTest): Changed to return a boolean indicating
2081         whether we were able to reset the web process (and thus run the test).
2082         (WTR::TestController::runUntil): Call through to platformRunUntil.
2083
2084         (WTR::TestController::runTestingServerLoop):
2085         (WTR::TestController::run):
2086         Changed to bail if any test can't be run. This will cause the process
2087         to exit. (Unfortunately this will make run-webkit-tests think we
2088         crashed; see <http://webkit.org/b/48943>.)
2089
2090         * WebKitTestRunner/TestController.h: Added platformRunUntil,
2091         m_longTimeout, and m_shortTimeout.
2092
2093         * WebKitTestRunner/TestInvocation.cpp:
2094         (WTR::TestInvocation::invoke): Use a short timeout when waiting for the
2095         initial response and a long timeout when waiting for the test to
2096         complete. Check whether runUntil timed out and print an error message
2097         if so.
2098
2099         * WebKitTestRunner/mac/TestControllerMac.mm:
2100         (WTR::TestController::platformRunUntil): Renamed from runUntil. Pass
2101         [NSDate distantPast] to -[NSRunLoop runMode:beforeDate:] so that we
2102         won't block waiting for the run loop. Only loop until the timeout
2103         elapses.
2104
2105         * WebKitTestRunner/qt/TestControllerQt.cpp:
2106         (WTR::TestController::platformRunUntil): Renamed from runUntil. Added a
2107         FIXME about honoring the timeout.
2108
2109         * WebKitTestRunner/win/TestControllerWin.cpp:
2110         (WTR::TestController::platformRunUntil): Renamed from runUntil. Use
2111         ::MsgWaitForMultipleObjectsEx to implement the timeout. Changed to use
2112         ::PeekMessageW so that we don't block waiting for messages to become
2113         available.
2114
2115 2010-11-03  Adam Roben  <aroben@apple.com>
2116
2117         Add a plugin test that evaluates JS after removing the plugin element
2118         from the document
2119
2120         This test replaces platform/win/plugins/plugin-delayed-destroy.html.
2121         That test was made to prevent a crash very similar to this one, but
2122         unfortunately tested only the mechanism that prevented the crash and
2123         not whether the crash itself was prevented. Since WebKit2 uses a
2124         different mechanism to prevent the crash, the test was failing even
2125         though WebKit2 was not vulnerable to the crash. This new test crashes
2126         if there is no mechanism in place to prevent it and passes in both
2127         WebKit1 and WebKit2.
2128
2129         Fixes <http://webkit.org/b/46711> <rdar://problem/8485903>
2130         platform/win/plugins/plugin-delayed-destroy.html fails in WebKit2
2131
2132         Reviewed by Anders Carlsson.
2133
2134         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2135         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2136         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2137         * GNUmakefile.am:
2138         Added new file.
2139
2140         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2141         (pluginDeallocate): Make sure we delete the PluginTest object. This
2142         prevents a leak and also allows us to test the crash.
2143
2144         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2145         (PluginTest::executeScript): Made this into a non-static member
2146         function.
2147
2148         (PluginTest::waitUntilDone):
2149         (PluginTest::notifyDone):
2150         Updated for changes to executeScript.
2151
2152         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added executeScript.
2153
2154         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp: Added.
2155         (EvaluateJSAfterRemovingPluginElement::EvaluateJSAfterRemovingPluginElement):
2156         Initialize ourselves and tell the test harness to wait.
2157         (EvaluateJSAfterRemovingPluginElement::NPP_DestroyStream): Remove our
2158         plugin element from the document, then execute some JavaScript. If
2159         WebKit does not have appropriate mechanisms in place, we'll be
2160         destroyed inside the first call to executeScript and crash on the
2161         second call.
2162
2163 2010-11-02  Stephen White  <senorblanco@chromium.org>
2164
2165         Reviewed by Tony Chang.
2166
2167         [chromium] Fix LayoutTestController UMRs.
2168         https://bugs.webkit.org/show_bug.cgi?id=48872
2169
2170         * DumpRenderTree/chromium/LayoutTestController.cpp:
2171         (LayoutTestController::LayoutTestController):
2172
2173 2010-11-03  Kent Tamura  <tkent@chromium.org>
2174
2175         Reviewed by Dimitri Glazkov.
2176
2177         REGRESSION: rebaseline-chromium-webkit-tests uses non-zero tolerance for
2178         image dup detection
2179         https://bugs.webkit.org/show_bug.cgi?id=48744
2180
2181         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2182          - Make a function for option parsing for ease of test
2183          - Set 0 to options.tolerance
2184         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2185          - Add a test for this change
2186
2187 2010-11-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2188
2189         Unreviewed: Add myself to the list of Committers.
2190
2191         * Scripts/webkitpy/common/config/committers.py:
2192
2193 2010-11-02  Anders Carlsson  <andersca@apple.com>
2194
2195         Fix build.
2196
2197         * TestWebKitAPI/PlatformUtilities.cpp:
2198         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2199
2200 2010-11-02  Sam Weinig  <sam@webkit.org>
2201
2202         Reviewed by Anders Carlsson.
2203
2204         Add a way to send startup messages on the context which can be posted when a process launches
2205         <rdar://problem/8617928>
2206         https://bugs.webkit.org/show_bug.cgi?id=48838
2207
2208         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2209         (WKBundleInitialize):
2210         * TestWebKitAPI/InjectedBundleController.cpp:
2211         (TestWebKitAPI::InjectedBundleController::initialize):
2212         (TestWebKitAPI::InjectedBundleController::didReceiveMessage):
2213         * TestWebKitAPI/InjectedBundleController.h:
2214         * TestWebKitAPI/InjectedBundleMain.cpp:
2215         (WKBundleInitialize):
2216         * TestWebKitAPI/PlatformUtilities.cpp:
2217         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2218         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2219         (WKBundleInitialize):
2220         Update implementations of WKBundleInitialize to take an initial userData
2221         argument.  Change TestWebKitAPI to use the new initial userData to initialize
2222         each test's bundle.
2223
2224 2010-11-02  Benjamin Kalman  <kalman@google.com>
2225
2226         Reviewed by Ojan Vafai.
2227
2228         new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests
2229         https://bugs.webkit.org/show_bug.cgi?id=48794
2230
2231         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Strip the "LayoutTests/" prefix from test argument paths.
2232
2233 2010-11-02  Adam Roben  <aroben@apple.com>
2234
2235         Skip webkitpy.layout_tests.run_webkit_tests_unittest.MainTest on Cygwin
2236         Python 2.5.x
2237
2238         It is known to hang on that version of Python. See
2239         <http://webkit.org/b/48614>.
2240
2241         Reviewed by Adam Barth.
2242
2243         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Use
2244         skip_if to skip MainTest on Cygwin Python 2.5.x.
2245
2246         * Scripts/webkitpy/test/skip.py: Added.
2247         (skip_if): If the passed-in condition is false, find all the test_*
2248         methods of the given class and replace them with a function that just
2249         logs that we're skipping these tests. This is loosely based on the
2250         unittest.skip_if decorator added in Python 3.1.
2251         (_skipped_method): Returns a function that just logs that the tests are
2252         being skipped. This is used in place of the actual test_* functions.
2253
2254         * Scripts/webkitpy/test/skip_unittest.py: Added.
2255         (SkipTest.setUp): Create a logger for ourselves and give it a handler
2256         that logs to a private stream.
2257         (SkipTest.tearDown): Reset the logger.
2258         (SkipTest.create_fixture_class): Returns a class that we use to test
2259         skip_if. It has a single test_* method, test_foo, that just calls
2260         through to a callback.
2261         (SkipTest.foo_callback): Record that test_foo was called.
2262         (SkipTest.test_skip_if_false): Pass skip_if a False condition and test
2263         that test_foo does get called.
2264         (SkipTest.test_skip_if_true): Pass skip_if a True condition and test
2265         that test_foo does not get called and the appropriate message gets
2266         logged.
2267
2268 2010-11-02  Adam Barth  <abarth@webkit.org>
2269
2270         Reviewed by Eric Seidel.
2271
2272         webkit-patch should tell check-webkit-style which files were changed so
2273         check-webkit-style doesn't have to stat the whole working copy again
2274         https://bugs.webkit.org/show_bug.cgi?id=48792
2275
2276         * Scripts/webkitpy/tool/mocktool.py:
2277         * Scripts/webkitpy/tool/steps/checkstyle.py:
2278
2279 2010-11-02  Robert Kroeger  <rjkroege@chromium.org>
2280
2281         Reviewed by James Robinson.
2282
2283         [Chromium/DRT] Make EventSendingController honour leapForward for touch events.
2284         https://bugs.webkit.org/show_bug.cgi?id=48777
2285
2286         * DumpRenderTree/chromium/EventSender.cpp:
2287         (EventSender::sendCurrentTouchEvent):
2288
2289 2010-11-02  Adam Roben  <aroben@apple.com>
2290
2291         Only track resource identifiers in DRT when dumpResourceLoadCallbacks
2292         is on
2293
2294         This reverts Windows to our pre-r71097 behavior. That patch made us
2295         track all resource identifiers, including the main resource, so the
2296         main resource's URL started appearing in test output instead of
2297         "<unknown>". Arguably having the main resource's URL is better, but all
2298         other platforms print "<unknown>" and we want to match.
2299
2300         Fixes <http://webkit.org/b/48837> <rdar://problem/8620351> REGRESSION
2301         (r71097): Many http tests failing on Windows
2302
2303         Reviewed by Anders Carlsson.
2304
2305         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2306         (ResourceLoadDelegate::identifierForInitialRequest): Don't add the
2307         identifier to the URL map if we're not supposed to dump resource load
2308         callbacks.
2309         (ResourceLoadDelegate::removeIdentifierForRequest): Always remove the
2310         identifier from the URL map even if we're already "done". There's no
2311         point in keeping out-of-date identifiers around.
2312
2313 2010-11-01  Jenn Braithwaite  <jennb@chromium.org>
2314
2315         Reviewed by Adam Roben.
2316
2317         Windows: Update resource tracking when moving a frame between documents
2318         https://bugs.webkit.org/show_bug.cgi?id=48364
2319
2320         * DumpRenderTree/win/DumpRenderTree.cpp:
2321         (createWebViewAndOffscreenWindow):
2322         (main):
2323         Give each WebView its own ResourceLoadDelegate instance in order to
2324         make assertions about resource ids on a particular WebView.
2325         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2326         (ResourceLoadDelegate::identifierForInitialRequest):
2327         Always add id to the map.
2328         (ResourceLoadDelegate::removeIdentifierForRequest):
2329         Added.
2330         (ResourceLoadDelegate::willSendRequest):
2331         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2332         (ResourceLoadDelegate::didReceiveResponse):
2333         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2334         (ResourceLoadDelegate::didFailLoadingWithError):
2335         (ResourceLoadDelegate::descriptionSuitableForTestResult):
2336         Replace static descriptionSuitableForTestResult with static member function to access identifier map.
2337         * DumpRenderTree/win/ResourceLoadDelegate.h:
2338         (ResourceLoadDelegate::urlMap):
2339         Moved within class so that each WebView has its own id map.
2340
2341 2010-11-01  Ojan Vafai  <ojan@chromium.org>
2342
2343         Reviewed by Dimitri Glazkov.
2344
2345         remove debug code from run_webkit_tests.py
2346         https://bugs.webkit.org/show_bug.cgi?id=48800
2347
2348         Remove temporary debug code and make --master-name required
2349         if --test-results-server is set now that all clients set
2350         --master-name.
2351
2352         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2353
2354 2010-11-01  Tony Chang  <tony@chromium.org>
2355
2356         Reviewed by Kent Tamura.
2357
2358         add plugin event logging for linux
2359         https://bugs.webkit.org/show_bug.cgi?id=48779
2360
2361         This is taken from Chromium's fork of the layout test plugin:
2362         http://git.chromium.org/gitweb/?p=chromium.git/.git;a=blob;f=webkit/tools/npapi_layout_test_plugin/main.cpp;h=3ebdada2f049b3624756438cff852364f86a2ede;hb=HEAD#l348
2363
2364         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2365         (handleEventX11):
2366         (NPP_HandleEvent):
2367
2368 2010-11-01  Dirk Pranke  <dpranke@chromium.org>
2369
2370         Reviewed by James Robinson.
2371
2372         new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default
2373         https://bugs.webkit.org/show_bug.cgi?id=48790
2374
2375         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2376         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2377
2378 2010-11-01  Adam Barth  <abarth@webkit.org>
2379
2380         Reviewed by Eric Seidel.
2381
2382         Teach check-webkit-style how to accept a list of files to diff on the
2383         command line
2384         https://bugs.webkit.org/show_bug.cgi?id=48784
2385
2386         In a future patch, webkit-patch will use this option to improve
2387         performance.  I'm landing this in two pieces to avoid causing a version
2388         skew problem for the style-bot.
2389
2390         * Scripts/check-webkit-style:
2391         * Scripts/webkitpy/style/optparser.py:
2392         * Scripts/webkitpy/style/optparser_unittest.py:
2393         * Scripts/webkitpy/style_references.py:
2394
2395 2010-11-01  Anders Carlsson  <andersca@apple.com>
2396
2397         Reviewed by John Sullivan.
2398
2399         Tear down the related WebProcessProxy when a WebContext is deallocated
2400         https://bugs.webkit.org/show_bug.cgi?id=48769
2401
2402         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2403         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2404         We don't support empty URLs anymore, update test to expect a null URL instead.
2405
2406 2010-11-01  Søren Gjesse  <sgjesse@chromium.org>
2407
2408         Reviewed by Andreas Kling.
2409
2410         Fix warning when compiling the chromium port of DumpRenderShell
2411         with clang.
2412         https://bugs.webkit.org/show_bug.cgi?id=48414
2413
2414         * DumpRenderTree/chromium/TestShell.h:
2415         (TestShell::javaScriptFlagsForLoad):
2416
2417 2010-11-01  Adam Roben  <aroben@apple.com>
2418
2419         Fix typo from r71022
2420
2421         * BuildSlaveSupport/build.webkit.org-config/config.json:
2422
2423 2010-11-01  Adam Roben  <aroben@apple.com>
2424
2425         Trigger the Windows Release WebKit2 tests when a Release build
2426         finishes, not when a Debug build finishes
2427
2428         Fixes <http://webkit.org/b/48754> Windows Release WebKit2 tests are
2429         triggered at the wrong time
2430
2431         Reviewed by Sam Weinig.
2432
2433         * BuildSlaveSupport/build.webkit.org-config/config.json: Fixed
2434         triggerable name and trigger.
2435
2436 2010-11-01  Mario Sanchez Prada  <msanchez@igalia.com>
2437
2438         Unreviewed. Adding my IRC nickname to the list of committers.
2439
2440         * Scripts/webkitpy/common/config/committers.py:
2441
2442 2010-10-31  Robert Hogan  <robert@webkit.org>
2443
2444         Reviewed by Antonio Gomes.
2445
2446         [Qt] [Gtk] Plug-ins having upper case in mime type are failing to load
2447
2448         Qt and Gtk are case-sensitive when storing the declared mime-type
2449         of plugins. Since plugin mime-types are lowercased prior to searching
2450         for them in the plugin database, ensure they are loaded with the
2451         mime-type in lower case too.
2452
2453         Change the test netscape plugin to declare its mimetype in sentence
2454         case so that the correct behaviour is enforced.
2455
2456         https://bugs.webkit.org/show_bug.cgi?id=36815
2457
2458         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2459         (NP_GetMIMEDescription):
2460
2461 2010-10-31  Robert Hogan  <robert@webkit.org>
2462
2463         Reviewed by Antonio Gomes.
2464
2465         [Qt] Support nodesFromRect in DRT
2466
2467         https://bugs.webkit.org/show_bug.cgi?id=48716
2468
2469         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2470         (LayoutTestController::nodesFromRect):
2471         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2472
2473 2010-10-30  Andreas Kling  <kling@webkit.org>
2474
2475         Reviewed by Antonio Gomes.
2476
2477         [Qt] QtTestBrowser: Switching view type moves the embedded inspector
2478         https://bugs.webkit.org/show_bug.cgi?id=48705
2479
2480         Reinsert the embedded inspector into the splitter after changing
2481         between QWebView/QGraphicsWebView.
2482
2483         * QtTestBrowser/launcherwindow.cpp:
2484         (LauncherWindow::init):
2485         (LauncherWindow::initializeView):
2486         * QtTestBrowser/webinspector.h:
2487         (WebInspector::WebInspector):
2488
2489 2010-10-28  Antonio Gomes  <agomes@rim.com>
2490
2491         Reviewed by Ojan Vafai.
2492
2493         Needs a "LinuxEditingBehavior", perhaps with a better name
2494         https://bugs.webkit.org/show_bug.cgi?id=36627
2495
2496         Adding support to Mac's, GTK+'s, Windows' and Chromium's LayoutTestController class to test the newly introduced Unix editing behavior.
2497
2498         * DumpRenderTree/chromium/LayoutTestController.cpp:
2499         (LayoutTestController::setEditingBehavior):
2500         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2501         (LayoutTestController::setEditingBehavior):
2502         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2503         (LayoutTestController::setEditingBehavior):
2504         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2505         (LayoutTestController::setEditingBehavior):
2506
2507 2010-10-29  Andreas Kling  <kling@webkit.org>
2508
2509         Reviewed by Kenneth Rohde Christiansen.
2510
2511         [Qt] QtTestBrowser: Add keyboard shortcut to toggle full screen (F11)
2512         https://bugs.webkit.org/show_bug.cgi?id=48695
2513
2514         * QtTestBrowser/launcherwindow.cpp:
2515         (LauncherWindow::createChrome):
2516
2517 2010-10-29  Andreas Kling  <kling@webkit.org>
2518
2519         Reviewed by Kenneth Rohde Christiansen.
2520
2521         [Qt] QtTestBrowser: Fix uninitialized read in FpsTimer
2522         https://bugs.webkit.org/show_bug.cgi?id=48675
2523
2524         FpsTimer::m_timer was never initialized and passed to QObject::killTimer()
2525         on startup with in -graphicsbased mode.
2526
2527         * QtTestBrowser/fpstimer.cpp:
2528         (FpsTimer::FpsTimer):
2529         (FpsTimer::numFrames):
2530         (FpsTimer::stop):
2531         (FpsTimer::timerEvent):
2532         * QtTestBrowser/fpstimer.h:
2533
2534 2010-10-29  Dirk Pranke  <dpranke@chromium.org>
2535
2536         Reviewed by Tony Chang.
2537
2538         new-run-webkit-tests: change TestResults to be serializable
2539
2540         In preparation for changing new-run-webkit-tests from
2541         multithreaded to multiprocess, we need to make sure the data
2542         going between the threads is easily serialized over a socket.
2543
2544         This change adds serialization/pickling for the TestResults and
2545         TestFailure objects (using cPickle).
2546
2547         The TestFailure objects included a "has_wdiff" flag for Text
2548         results, but the flag wasn't being used, so I've removed it,
2549         simplifying the state to basically a set of enum objects with
2550         associated methods.
2551
2552         https://bugs.webkit.org/show_bug.cgi?id=48616
2553
2554         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2555         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2556         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2557         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
2558         * Scripts/webkitpy/layout_tests/layout_package/test_results.py: Added.
2559         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:Added. 
2560         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2561         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2562
2563 2010-10-29  Dirk Pranke  <dpranke@chromium.org>
2564
2565         Reviewed by Ojan Vafai.
2566
2567         new-run-webkit-tests: need to provide separate dashboard results for GPU tests
2568         https://bugs.webkit.org/show_bug.cgi?id=48687
2569
2570         Modify the steps to upload the JSON files to the dashboards so
2571         that the GPU tests don't conflict with the regular tests on a
2572         port. We do this by modifying the --builder-name parameter to
2573         append " - GPU", which should cause the app to treat the results
2574         as a completely new builder. This is a little non-obvious, but
2575         keeps us from having to restructure the app.
2576
2577         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2578         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2579         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2580
2581 2010-10-29  Ojan Vafai  <ojan@chromium.org>
2582
2583         Reviewed by Tony Chang.
2584
2585         [chromium] add debug logging to help diagnose flakiness dashboard issues
2586         https://bugs.webkit.org/show_bug.cgi?id=48657
2587
2588         The appengine app thinks it's getting empty files uploaded. Add some logging
2589         to see if new-run-webkit-tests agrees.
2590         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2591
2592 2010-10-29  Dimitri Glazkov  <dglazkov@chromium.org>
2593
2594         Reviewed by Ojan Vafai.
2595
2596         [Chromium/DRT] Add master-name flag to new-run-webkit-tests.
2597         https://bugs.webkit.org/show_bug.cgi?id=48649
2598
2599         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added flag.
2600
2601 2010-10-29  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2602
2603         Reviewed by Martin Robinson.
2604
2605         Enable popup window in GtkLauncher
2606         https://bugs.webkit.org/show_bug.cgi?id=48335
2607
2608         The GtkLauncher application does not support opening new window when
2609         a link with "target=_blank" is clicked or similar call to
2610         window.open(). Instead, GtkLauncher does nothing which breaks
2611         navigation of some websites.
2612
2613         * GtkLauncher/main.c:
2614         (activate_uri_entry_cb):
2615         (update_title):
2616         (link_hover_cb):
2617         (notify_title_cb):
2618         (notify_load_status_cb):
2619         (notify_progress_cb):
2620         (destroy_cb):
2621         (go_back_cb):
2622         (go_forward_cb):
2623         (create_web_view_cb):
2624         (web_view_ready_cb):
2625         (close_web_view_cb):
2626         (create_browser):
2627         (create_statusbar):
2628         (create_toolbar):
2629         (create_window):
2630         (main):
2631
2632 2010-10-29  Adam Roben  <aroben@apple.com>
2633
2634         Teach check-webkit-style about WebKit2's idiosyncracies
2635
2636         Fixes <http://webkit.org/b/48638> Style bot complains about a number
2637         of WebKit2 conventions
2638
2639         Reviewed by Anders Carlsson.
2640
2641         * Scripts/webkitpy/style/checker.py: Excluded some rules for various
2642         WebKit2-related files. Also updated the excluded rules for
2643         WebKitAPITest to match the current code.
2644
2645 2010-10-29  Csaba Osztrogonác  <ossy@webkit.org>
2646
2647         Reviewed by Adam Roben and David Kilzer.
2648
2649         Fix and cleanup of build systems
2650         https://bugs.webkit.org/show_bug.cgi?id=48342
2651
2652         * Scripts/build-webkit:
2653          - Remove unnecessary ENABLE_SANDBOX option.
2654          - Add ENABLE_FULLSCREEN_API option.
2655
2656 2010-10-28  Adam Roben  <aroben@apple.com>
2657
2658         Switch the Windows WebKit2 bot to the Release configuration
2659
2660         We only have one machine testing WebKit2 on Windows right now, and
2661         Debug is just too slow for it to keep up.
2662
2663         Fixes (hopefully!) <http://webkit.org/b/48615> Windows WebKit2 bot is
2664         always way behind
2665
2666         Reviewed by Jon Honeycutt.
2667
2668         * BuildSlaveSupport/build.webkit.org-config/config.json:
2669
2670 2010-10-29  Leandro Gracia Gil  <leandrogracia@google.com>
2671
2672         Reviewed by Jeremy Orlow.
2673
2674         Added a second parameter to setMockSpeechInputResult for
2675         the language used in speech input.
2676         https://bugs.webkit.org/show_bug.cgi?id=47089
2677
2678         * DumpRenderTree/LayoutTestController.cpp:
2679         (setMockSpeechInputResultCallback):
2680         * DumpRenderTree/LayoutTestController.h:
2681         * DumpRenderTree/chromium/LayoutTestController.cpp:
2682         (LayoutTestController::setMockSpeechInputResult):
2683         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2684         (LayoutTestController::setMockSpeechInputResult):
2685         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2686         (LayoutTestController::setMockSpeechInputResult):
2687         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2688         (LayoutTestController::setMockSpeechInputResult):
2689         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2690         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2691         (LayoutTestController::setMockSpeechInputResult):
2692         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2693         (LayoutTestController::setMockSpeechInputResult):
2694         (LayoutTestController::pageSizeAndMarginsInPixels):
2695
2696 2010-10-28  Ojan Vafai  <ojan@chromium.org>
2697
2698         Reviewed by Tony Chang.
2699
2700         [chromium] add a result-small.json file for the test dashboard
2701         https://bugs.webkit.org/show_bug.cgi?id=48547
2702
2703         Output both a results.json file and a results-small.json file.
2704         The dashboard will load results-small.json by default so it loads faster.
2705
2706         * TestResultServer/model/jsonresults.py:
2707         * TestResultServer/model/jsonresults_unittest.py:
2708         Added a bunch of sys.path hackery. Unforunately, this uses hardcoded
2709         paths. That obviously needs to be fixed, but at least this way it
2710         clearly documents what paths are necessary.
2711
2712 2010-10-28  Eric Seidel  <eric@webkit.org>
2713
2714         Reviewed by Adam Barth.
2715
2716         webkit-patch upload calls changed_files more often than it should
2717         https://bugs.webkit.org/show_bug.cgi?id=48567
2718
2719         Passing changed_files around everywhere isn't a very elegant solution
2720         but it's the one we have for the moment.  I think keeping an explicit
2721         cache on Checkout (or making StepState() a real class) is a better
2722         long-term option.
2723
2724         Previously bug_id_for_this_commit was calling changed_files and the
2725         result was never getting cached on the state.  Now we're explicitly
2726         caching the result on the state and passing that to the bug_id_for_this_commit call.
2727
2728         I looked into building unit tests for this.  Doing so would require
2729         using a real Checkout object with a MockSCM and overriding the appropriate
2730         calls on SCM to count how often we're stating the file system.
2731         That's a useful set of tests to build for a separate change.
2732
2733         * Scripts/webkitpy/common/checkout/api.py:
2734         * Scripts/webkitpy/tool/commands/download.py:
2735         * Scripts/webkitpy/tool/commands/upload.py:
2736         * Scripts/webkitpy/tool/mocktool.py:
2737
2738 2010-10-28  Eric Seidel  <eric@webkit.org>
2739
2740         Reviewed by Adam Barth.
2741
2742         Make suggest-reviewers slightly faster
2743         https://bugs.webkit.org/show_bug.cgi?id=48562
2744
2745         Add @memoized to one more common call.
2746
2747         * Scripts/webkitpy/common/checkout/api.py:
2748
2749 2010-10-28  Eric Seidel  <eric@webkit.org>
2750
2751         Reviewed by Adam Barth.
2752
2753         webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is still very slow
2754         https://bugs.webkit.org/show_bug.cgi?id=48536
2755
2756         This patch makes it about 40 seconds faster, but it still
2757         takes 1:40.  This will require more refinement.
2758
2759         The suggested reviewers list appears to be the same.
2760
2761         I think the next step may be to have it stop the search after
2762         5 reviewers are found.  We never want to suggest 30 people.
2763
2764         * Scripts/webkitpy/common/checkout/scm.py:
2765          - Using --remove-empty to theoretically stop lookups past
2766            when a file is removed.  I'm not entirely clear that the option
2767            does what it says it does.  Example:
2768            git log --pretty=format:%H -5 --remove-empty -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
2769            returns only one commit
2770            vs.
2771            git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
2772            which returns 5.  I was not aware that wx files were ever removed from the repository?
2773
2774 2010-10-28  Kinuko Yasuda  <kinuko@chromium.org>
2775
2776         Reviewed by David Levin.
2777
2778         [Chromium] Support FileSystem in chromium DRT
2779         https://bugs.webkit.org/show_bug.cgi?id=47643
2780
2781         * DumpRenderTree/chromium/WebViewHost.cpp:
2782         (WebViewHost::openFileSystem): Added.
2783         * DumpRenderTree/chromium/WebViewHost.h:
2784         (WebViewHost::openFileSystem): Added.
2785
2786 2010-10-28  Sam Weinig  <sam@webkit.org>
2787
2788         Reviewed by Anders Carlsson.
2789
2790         WKURLRefs should be allowed to be null
2791         <rdar://problem/8575621>
2792         https://bugs.webkit.org/show_bug.cgi?id=48535
2793
2794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2795         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2796         (TestWebKitAPI::didStartProvisionalLoadForFrame):
2797         (TestWebKitAPI::didCommitLoadForFrame):
2798         (TestWebKitAPI::didFinishLoadForFrame):
2799         Test that URLs are null pointers when unset.
2800
2801 2010-10-28  Chris Fleizach  <cfleizach@apple.com>
2802
2803         Reviewed by Adele Peterson.
2804
2805         AX: multi select group option does not handle setting of AXSelectedChildren correctly
2806         https://bugs.webkit.org/show_bug.cgi?id=48464
2807
2808         Add support for querying information about selected children to DRT, including:
2809            selectedChildAtIndex
2810            selectedChildrenCount
2811            setSelectedChild
2812
2813         * DumpRenderTree/AccessibilityUIElement.cpp:
2814         (selectedChildAtIndexCallback):
2815         (setSelectedChildCallback):
2816         (selectedChildrenCountCallback):
2817         (AccessibilityUIElement::setSelectedChild):
2818         (AccessibilityUIElement::selectedChildrenCount):
2819         (AccessibilityUIElement::selectedChildAtIndex):
2820         (AccessibilityUIElement::getJSClass):
2821         * DumpRenderTree/AccessibilityUIElement.h:
2822         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2823         (AccessibilityUIElement::selectedChildAtIndex):
2824         (AccessibilityUIElement::selectedChildrenCount):
2825         (AccessibilityUIElement::setSelectedChild):
2826
2827 2010-10-27  Sam Weinig  <sam@webkit.org>
2828
2829         Reviewed by Anders Carlsson.
2830
2831         Add WebKit2 API for window feature getter/setters
2832         <rdar://problem/8590373>
2833         https://bugs.webkit.org/show_bug.cgi?id=48496
2834
2835         * MiniBrowser/mac/BrowserWindowController.m:
2836         (-[BrowserWindowController awakeFromNib]):
2837         * MiniBrowser/win/BrowserView.cpp:
2838         (BrowserView::create):
2839         * WebKitTestRunner/TestController.cpp:
2840         (WTR::createOtherPage):
2841         (WTR::TestController::initialize):
2842
2843 2010-10-28  Søren Gjesse  <sgjesse@chromium.org>
2844
2845         Reviewed by Tony Chang.
2846
2847         Added support for the DumpRenderTree flags --multiple-loads and --js-flags to the Python test runner.
2848         https://bugs.webkit.org/show_bug.cgi?id=48236
2849
2850         * Scripts/webkitpy/layout_tests/port/chromium.py:
2851         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2852
2853 2010-10-28  Sergio Villar Senin  <svillar@igalia.com>
2854
2855         Reviewed by Martin Robinson.
2856
2857         [GTK] WebKitWebFrame's load-status is not properly notified to the tests
2858         https://bugs.webkit.org/show_bug.cgi?id=48048
2859
2860         DRT now listens to WebKitWebFrame load-status signals for each
2861         created frame instead of the load-status signal of the
2862         WebKitWebView that only notifies about changes in the main frame.
2863
2864         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2865         (webViewLoadFinished):
2866         (webFrameLoadStatusNotified):
2867         (frameCreatedCallback):
2868         (createWebView):
2869         (main):
2870
2871 2010-10-28  Tony Chang  <tony@chromium.org>
2872
2873         Reviewed by Kent Tamura.
2874
2875         [chromium] fix textInputController.{selectedRange,markedRange}
2876         https://bugs.webkit.org/show_bug.cgi?id=48487
2877
2878         * DumpRenderTree/chromium/TextInputController.cpp:
2879         (TextInputController::markedRange): Return arrays of ints, rather than a string
2880         (TextInputController::selectedRange): Ditto.
2881
2882 2010-10-27  Ojan Vafai  <ojan@chromium.org>
2883
2884         Reviewed by Tony Chang.
2885
2886         [chromium] add a master-name flag to new-run-webkit-tests
2887         https://bugs.webkit.org/show_bug.cgi?id=48488
2888
2889         The test results server now allows adding a master name to
2890         the uploaded files. This lets us distinguish bots that have
2891         the same name, but are on different masters.
2892
2893         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2894
2895 2010-10-28  Adam Roben  <aroben@apple.com>
2896
2897         Don't append a newline to the test output if the frame has no document
2898         element in WebKitTestRunner
2899
2900         Fixes <http://webkit.org/b/48526> Extra trailing newline when running
2901         plugins/document-open.html in WebKitTestRunner
2902
2903         Reviewed by Anders Carlsson.
2904
2905         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2906         (WTR::toJS): Added. Turns a UTF-8 C string into a JSStringRef.
2907         (WTR::hasDocumentElement): Added. Uses the JSC API to figure out
2908         whether the frame has a document element.
2909         (WTR::dumpFrameText): Match DRT by bailing (rather than appending an
2910         empty string and a newline) if the frame has no document element.
2911
2912 2010-10-28  Adam Roben  <aroben@apple.com>
2913
2914         Skip npn-invalidate-rect-invalidates-window.html on headless XP
2915         machines
2916
2917         TestNetscapePlugIn never receives a WM_PAINT message on headless XP
2918         machines, so this test times out. Fixing the test is covered by
2919         <http://webkit.org/b/48333>.
2920
2921         * Scripts/old-run-webkit-tests: Skip
2922         npn-invalidate-rect-invalidates-window.html on Windows if accelerated
2923         compositing support is disabled, which likely means we're on a headless
2924         XP machine.
2925
2926 2010-10-28  Kimmo Kinnunen  <kimmok@iki.fi>
2927
2928         Adding myself as a committer.
2929
2930         * Scripts/webkitpy/common/config/committers.py:
2931
2932 2010-10-27  Eric Seidel  <eric@webkit.org>
2933
2934         Reviewed by Adam Barth.
2935
2936         webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is very slow
2937         https://bugs.webkit.org/show_bug.cgi?id=48500
2938
2939         This doesn't fix the problem, but it makes things slightly better.
2940         Each git svn find-rev call takes about .25 seconds on my desktop.
2941         This patch uses a new memoized class to avoid those calls when possible.
2942
2943         The real slowness is still git log on some files, like:
2944         git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
2945         I'm not yet sure how to make the pathological git logs better.
2946
2947         * Scripts/webkitpy/common/checkout/scm.py:
2948         * Scripts/webkitpy/common/memoized.py: Added.
2949         * Scripts/webkitpy/common/memoized_unittest.py: Added.
2950
2951 2010-10-27  Eric Seidel  <eric@webkit.org>
2952
2953         Reviewed by Ojan Vafai.
2954
2955         EWS bots should not use --quiet when running build-webkit
2956         https://bugs.webkit.org/show_bug.cgi?id=48482
2957
2958         --quiet is only correct when the sub-process does the error reporting.
2959         In the case of _can_build() the parent process is reporting the error.
2960         We'd like the full build log at queues.webkit.org so someone can look
2961         at the log and understand why the EWS is failing to build trunk.
2962
2963         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2964         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2965         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2966         * Scripts/webkitpy/tool/mocktool.py:
2967
2968 2010-10-27  Brian Weinstein  <bweinstein@apple.com>
2969
2970         More Windows build fixage. Rename a variable that was named string.
2971
2972         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2973         (WTR::hasPrefix):
2974
2975 2010-10-27  Ojan Vafai  <ojan@chromium.org>
2976
2977         Reviewed by Dimitri Glazkov.
2978
2979         [chromium] Make the test results server store which master the bot is on
2980         https://bugs.webkit.org/show_bug.cgi?id=48478
2981
2982         The chromium bots recently changed so that there are multiple slaves with
2983         the same name on different masters. Up till now, the test results server
2984         assumed slave names were unique. Adds a master field to the file in order
2985         to distinguish.
2986
2987         Also, for files that currently lack a master or testtype, set them appropriately.
2988
2989         * TestResultServer/handlers/testfilehandler.py:
2990         * TestResultServer/index.yaml:
2991         * TestResultServer/model/jsonresults.py:
2992         * TestResultServer/model/testfile.py:
2993         * TestResultServer/templates/showfilelist.html:
2994         * TestResultServer/templates/uploadform.html:
2995
2996 2010-10-26  Darin Adler  <darin@apple.com>
2997
2998         Reviewed by Sam Weinig.
2999
3000         WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
3001         https://bugs.webkit.org/show_bug.cgi?id=42322
3002         rdar://problem/8193631
3003
3004         WebKitTestRunner needs to support layoutTestController.clearBackForwardList
3005         https://bugs.webkit.org/show_bug.cgi?id=42333
3006         rdar://problem/8193643
3007
3008         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3009         Renamed the product to WebKitTestRunnerInjectedBundle to avoid
3010         name conflicts in the build directory.
3011
3012         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3013         Added dumpBackForwardList and clearBackForwardList.
3014
3015         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3016         (WTR::InjectedBundle::InjectedBundle): Removed initialization of m_mainPage.
3017         (WTR::InjectedBundle::didCreatePage): Removed unneeded underscore.
3018         (WTR::InjectedBundle::willDestroyPage): Ditto.
3019         (WTR::InjectedBundle::didReceiveMessage): Ditto.
3020         (WTR::InjectedBundle::initialize): Ditto.
3021         (WTR::InjectedBundle::didCreatePage): Changed code to use m_pages
3022         instead of m_mainPage and m_otherPages.
3023         (WTR::InjectedBundle::willDestroyPage): Ditto.
3024         (WTR::InjectedBundle::page): Ditto.
3025         (WTR::InjectedBundle::beginTesting): Ditto.
3026         (WTR::InjectedBundle::done): Ditto.
3027         (WTR::InjectedBundle::closeOtherPages): Ditto.
3028         (WTR::InjectedBundle::dumpBackForwardListsForAllPages): Added.
3029
3030         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Changed
3031         page function to longer be inline, and pageCount function
3032         to use m_pages. Added dumpBackForwardListsForAllPages, and
3033         removed some underscores. Replaced m_mainPage and m_otherPageas
3034         with m_pages.
3035
3036         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3037         (WTR::adoptWK): Added.
3038         (WTR::hasPrefix): Added.
3039         (WTR::InjectedBundlePage::reset): Added code to set up
3040         m_previousTestBackForwardListItem.
3041         (WTR::InjectedBundlePage::dump): Added code to call
3042         dumpBackForwardListsForAllPages.
3043         (WTR::compareByTargetName): Added.
3044         (WTR::dumpBackForwardListItem): Added.
3045         (WTR::InjectedBundlePage::dumpBackForwardList): Added.
3046
3047         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added
3048         dumpBackForwardList and m_previousTestBackForwardListItem.
3049
3050         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3051         (WTR::LayoutTestController::LayoutTestController): Initialize
3052         m_shouldDumpBackForwardListsForAllWindows to false.
3053         (WTR::LayoutTestController::clearBackForwardList): Added.
3054
3055         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3056         Added dumpBackForwardList, clearBackForwardList,
3057         shouldDumpBackForwardListsForAllWindows, and
3058         m_shouldDumpBackForwardListsForAllWindows.
3059
3060         * WebKitTestRunner/TestController.cpp:
3061         (WTR::TestController::initialize): Set up
3062         didReceiveSynchronousMessageFromInjectedBundle.
3063         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3064         Added.
3065         * WebKitTestRunner/TestController.h: Ditto.
3066
3067         * WebKitTestRunner/TestInvocation.cpp:
3068         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3069         Added.
3070         * WebKitTestRunner/TestInvocation.h: Ditto.
3071
3072         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3073         Renamed bundle to WebKitTestRunnerInjectedBundle (see above).
3074         * WebKitTestRunner/mac/TestControllerMac.mm:
3075         (WTR::TestController::initializeInjectedBundlePath): Ditto.
3076
3077 2010-10-27  Chris Rogers  <crogers@google.com>
3078
3079         Reviewed by Chris Marrin.
3080
3081         Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
3082         https://bugs.webkit.org/show_bug.cgi?id=48279
3083
3084         * Scripts/build-webkit:
3085
3086 2010-10-27  Eric Seidel  <eric@webkit.org>
3087
3088         Unreviewed.
3089
3090         build-webkit should collect Visual Studio Express logs and display them
3091         https://bugs.webkit.org/show_bug.cgi?id=39199
3092
3093         It turns out my previous patch wasn't actually working on the win-ews
3094         machine.  So I've fixed my mistakes from before.
3095
3096         * Scripts/build-webkit:
3097          - Windows VSE builds change the CWD while building.  Why?  Who knows.
3098         * Scripts/print-vse-failure-logs:
3099          - windows VSE builds don't use Debug/Release as I expected, so I've
3100            moved off of --configuration to --top-level and added the /obj
3101            optimization while I was there.
3102
3103 2010-10-27  Dimitri Glazkov  <dglazkov@chromium.org>
3104
3105         Unreviewed, rolling out r70674.
3106         http://trac.webkit.org/changeset/70674
3107         https://bugs.webkit.org/show_bug.cgi?id=48053
3108
3109         Broke Chromium Windows build.
3110
3111         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3112         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3113
3114 2010-10-25  Tony Chang  <tony@chromium.org>
3115
3116         Reviewed by Anders Carlsson.
3117
3118         compile TestNetscapePlugIn on chromium linux
3119         https://bugs.webkit.org/show_bug.cgi?id=48274
3120
3121         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3122         (NP_Initialize): On Linux, plugin funcs are set in initialize.
3123         (NPP_New): Mark the plugin as windowless.
3124         (NPP_GetValue): Handle mime type values.
3125         (NP_GetMIMEDescription):
3126         (NP_GetValue):
3127         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: define TRUE and FALSE, which are in webkit's npapi.h.
3128         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Pull in npapi.h to get TRUE/FALSE (matches webkit's npfunctions.h)
3129
3130 2010-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3131
3132         Reviewed by Anders Carlsson.
3133
3134         Remove contentSizeChanged callbacks as it is no longer
3135         part of the public UIClient.
3136
3137         Make WKPageContentsSizeChangedCallback be a private API
3138         https://bugs.webkit.org/show_bug.cgi?id=48409
3139
3140         * MiniBrowser/mac/BrowserWindowController.m:
3141         (-[BrowserWindowController awakeFromNib]):
3142         * MiniBrowser/win/BrowserView.cpp:
3143         (BrowserView::create):
3144         * WebKitTestRunner/TestController.cpp:
3145         (WTR::createOtherPage):
3146         (WTR::TestController::initialize):
3147
3148 2010-10-27  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3149
3150         Reviewed by Ojan Vafai.
3151
3152         Make http locking default in NRWT.
3153         https://bugs.webkit.org/show_bug.cgi?id=48053
3154
3155         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3156         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3157
3158 2010-10-27  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3159
3160         Reviewed by Tony Chang.
3161
3162         [NRWT] Fix http lock on Windows platform
3163         https://bugs.webkit.org/show_bug.cgi?id=48321
3164
3165         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3166
3167 2010-10-27  Satish Sampath  <satish@chromium.org>
3168
3169         Unreviewed, rolling out r70665.
3170         http://trac.webkit.org/changeset/70665
3171         https://bugs.webkit.org/show_bug.cgi?id=47089
3172
3173         Need to address Alexey's review comments.
3174
3175         * DumpRenderTree/LayoutTestController.cpp:
3176         (setMockSpeechInputResultCallback):
3177         * DumpRenderTree/LayoutTestController.h:
3178         * DumpRenderTree/chromium/LayoutTestController.cpp:
3179         (LayoutTestController::setMockSpeechInputResult):
3180         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3181         (LayoutTestController::setMockSpeechInputResult):
3182         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3183         (LayoutTestController::setMockSpeechInputResult):
3184         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3185         (LayoutTestController::setMockSpeechInputResult):
3186         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3187         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3188         (LayoutTestController::setMockSpeechInputResult):
3189         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3190         (LayoutTestController::setMockSpeechInputResult):
3191
3192 2010-10-27  Leandro Gracia Gil  <leandrogracia@google.com>
3193
3194         Reviewed by Jeremy Orlow.
3195
3196         Added a second parameter to setMockSpeechInputResult for
3197         the language used in speech input.
3198         https://bugs.webkit.org/show_bug.cgi?id=47089
3199
3200         * DumpRenderTree/LayoutTestController.cpp:
3201         (setMockSpeechInputResultCallback):
3202         * DumpRenderTree/LayoutTestController.h:
3203         * DumpRenderTree/chromium/LayoutTestController.cpp:
3204         (LayoutTestController::setMockSpeechInputResult):
3205         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3206         (LayoutTestController::setMockSpeechInputResult):
3207         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3208         (LayoutTestController::setMockSpeechInputResult):
3209         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3210         (LayoutTestController::setMockSpeechInputResult):
3211         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3212         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3213         (LayoutTestController::setMockSpeechInputResult):
3214         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3215         (LayoutTestController::setMockSpeechInputResult):
3216         (LayoutTestController::pageSizeAndMarginsInPixels):
3217
3218 2010-10-27  Adam Roben  <aroben@apple.com>
3219
3220         Reset TestNetscapePlugIn's NPP_GetValue pointer when
3221         NullNPPGetValuePointer finishes running
3222
3223         Fixes <http://webkit.org/b/48435> REGRESSION (r70655): Many plugins
3224         tests are failing on Qt
3225
3226         Reviewed by Anders Carlsson.
3227
3228         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3229         (PluginTest::NPP_Destroy):
3230         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3231         Added a do-nothing NPP_Destroy implementation.
3232
3233         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
3234         (NullNPPGetValuePointer::NullNPPGetValuePointer): Save the original
3235         NPP_GetValue pointer in m_originalNPPGetValuePointer so we can restore
3236         it later.
3237         (NullNPPGetValuePointer::NPP_Destroy): Added. Restores the original
3238         NPP_GetValue pointer so it can be used in other tests.
3239
3240         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3241         (NPP_Destroy):
3242         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3243         (webkit_test_plugin_destroy_instance):
3244         Call through to the PluginTest when NPP_Destroy is called.
3245
3246 2010-10-26  Brian Weinstein  <bweinstein@apple.com>
3247
3248         Reviewed by Adam Roben.
3249
3250         WebKit2 shouldn't try to send an empty user agent
3251         https://bugs.webkit.org/show_bug.cgi?id=48397
3252         
3253         Add a test that when we set our custom user agent to an empty string, we don't send
3254         an empty user agent.
3255
3256         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Added.
3257         (TestWebKitAPI::didRunJavaScript): Make sure that the result of navigator.userAgent isn't empty.
3258         (TestWebKitAPI::TEST): Set our custom user agent to the empty string, and run navigator.userAgent.
3259         
3260         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add the new file.
3261         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
3262
3263 2010-10-27  Adam Roben  <aroben@apple.com>
3264
3265         Check in file I forgot in r70653
3266
3267         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3268         (NP_Initialize): Save the NPPluginFuncs struct the browser passed to us
3269         so we can be naughty and modify it later.
3270
3271 2010-10-27  Adam Roben  <aroben@apple.com>
3272
3273         Test that WebKit doesn't crash if the plugin passes 0 for its
3274         NPP_GetValue pointer
3275
3276         Test for <http://webkit.org/b/48433> Crash in
3277         NetscapePlugin::shouldLoadSrcURL when using Shockwave Director 10.3 in
3278         WebKit2 on Windows
3279
3280         Reviewed by Eric Carlson.
3281
3282         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3283         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3284         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3285         * GNUmakefile.am:
3286         Added NullNPPGetValuePointer.cpp.
3287
3288         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3289         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3290         Set up a place to store the NPPluginFuncs struct the browser passed to us.
3291
3292         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp: Added.
3293         (NullNPPGetValuePointer::NullNPPGetValuePointer): Null out the
3294         NPP_GetValue pointer we passed to the browser to simulate a plugin that
3295         doesn't implement NPP_GetValue.
3296         (NullNPPGetValuePointer::NPP_GetValue): Print an error message. If this
3297         function is called, it means that WebKit has changed in a way that
3298         makes this test invalid.
3299
3300         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3301         (NP_GetEntryPoints): Save the NPPluginFuncs struct the browser passed
3302         to us so we can be naughty and modify it later.
3303
3304 2010-10-27  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3305
3306         Reviewed by Andreas Kling.
3307
3308         Remove references to ancient QGVLauncher and QtLauncher
3309         https://bugs.webkit.org/show_bug.cgi?id=48430
3310
3311         QtTestBrowser substitutes both and has checks enabled.
3312
3313         * Scripts/webkitpy/style/checker.py: remove references
3314         * Scripts/webkitpy/style/checker_unittest.py: ditto
3315
3316 2010-10-27  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3317
3318         Reviewed by Ojan Vafai.
3319
3320         [NRWT] Don't use image hash when it's no need in single test mode.
3321         https://bugs.webkit.org/show_bug.cgi?id=48326
3322
3323         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3324
3325 2010-10-27  David Kilzer  <ddkilzer@apple.com>
3326
3327         Fix leak of CFMutableDictionaryRef in createXMLStringFromWebArchiveData()
3328
3329         Reviewed by Adam Roben.
3330
3331         Follow-up fix for: <https://bugs.webkit.org/show_bug.cgi?id=48278>
3332
3333         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3334         (createXMLStringFromWebArchiveData): Use RetainPtr<> to fix a
3335         leak introduced in r70613.
3336
3337 2010-10-27  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3338
3339         Reviewed by Csaba Osztrogonác.
3340
3341         [NRWT] Add platform specific baseline search paths for Qt port
3342         https://bugs.webkit.org/show_bug.cgi?id=48428
3343
3344         * Scripts/webkitpy/layout_tests/port/qt.py:
3345
3346 2010-10-27  Adam Roben  <aroben@apple.com>
3347
3348         Catch exceptions when checking if we're inside a git working directory
3349
3350         Fixes <http://webkit.org/b/48420> REGRESSION (r70562): test-webkitpy
3351         fails on systems without git installed
3352
3353         Reviewed by Anders Carlsson.
3354
3355         * Scripts/webkitpy/common/net/credentials.py:
3356         (Credentials._credentials_from_git): Put the call to
3357         Git.in_working_directory inside the try/except since it, too, attempts
3358         to execute git and thus will throw on systems that don't have git
3359         installed.
3360
3361 2010-10-27  Nikolas Zimmermann  <nzimmermann@rim.com>
3362
3363         Reviewed by David Kilzer.
3364
3365         Convert DumpRenderTree webarchive code to CoreFoundation
3366         https://bugs.webkit.org/show_bug.cgi?id=48278
3367
3368         CFPropertyListCreateWithData and CFPropertyListCreateData are only available in 10.6+.
3369         Replace CFPropertyListCreateWithData by a combination of CFReadStreamCreateWithBytesNoCopy and CFPropertyListCreateFromStream.
3370         Replace CFPropertyListCreateData by CFPropertyListCreateXMLData.
3371
3372         These changes are wrapped in BUILDING_ON_LEOPARD, as the methods are deprecated on 10.6+.
3373
3374         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3375         (createXMLStringFromWebArchiveData):
3376
3377 2010-10-26  Antonio Gomes  <agomes@rim.com>
3378
3379         Reviewed by Martin Robinson.
3380
3381         Remove the absolute path used to include DumpRenderTreeSupportGtk.h from LayoutTestController.h
3382
3383         It turns out this is rather unneeded since WebKitTools/GNUMakefile.am has WebKit/gtk/ in its include
3384         path, and then we can just do #include "WebCoreSupport/DumpRenderTreeSupportGtk.h"
3385
3386         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3387
3388 2010-10-26  David Kilzer  <ddkilzer@apple.com>
3389
3390         Rename WebArchiveDumpSupport.mm to WebArchiveDumpSupport.cpp
3391
3392         Reviewed by Adam Roben.
3393
3394         Part 4 of 4: <http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation
3395
3396         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3397         Updated for file moves and renames.
3398         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Renamed from DumpRenderTree/mac/WebArchiveDumpSupport.mm.
3399         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Renamed from DumpRenderTree/mac/WebArchiveDumpSupport.h.
3400
3401 2010-10-26  David Kilzer  <ddkilzer@apple.com>
3402
3403         Convert WebArchiveDumpSupport.mm from NS objects to CF types
3404
3405         Reviewed by Adam Roben.
3406
3407         Part 3 of 4: <http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation
3408
3409         In order to share WebArchive code between the Mac and Windows
3410         ports, the code in WebArchiveDumpSupport.mm was converted from
3411         Cocoa to C++ using CoreFoundation (CF) types.
3412
3413         * DumpRenderTree/mac/DumpRenderTree.mm:
3414         (dump): Renamed serializeWebArchiveToXML() to
3415         createXMLStringFromWebArchiveData() and added HardAutorelease()
3416         to prevent leaks.
3417         * DumpRenderTree/mac/WebArchiveDumpSupport.h:
3418         (createXMLStringFromWebArchiveData): Renamed from
3419         serializeWebArchiveToXML().  Changed to use CF types.
3420         (createCFURLResponseFromResponseData): Renamed from
3421         unarchiveNSURLResponseFromResponseData().  Changed to use CF
3422         types for its parameter and return type.
3423         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Replaced use of
3424         NS objects with CF types.  It will be renamed to *.cpp in a
3425         future commit.
3426         (convertMIMEType): Changed to use case-insensitive string
3427         comparisons.
3428         (convertWebResourceDataToString):
3429         (normalizeHTTPResponseHeaderFields):
3430         (normalizeWebResourceURL):
3431         (convertWebResourceResponseToDictionary):
3432         (compareResourceURLs):
3433         (createXMLStringFromWebArchiveData):
3434         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
3435         (createCFURLResponseFromResponseData): Renamed from
3436         unarchiveNSURLResponseFromResponseData().  Changed to use CF
3437         types for its parameter and return type.
3438
3439 2010-10-26  David Kilzer  <ddkilzer@apple.com>
3440
3441         Extract use of NSKeyedUnarchiver from WebArchiveDumpSupport.mm
3442
3443         Reviewed by Adam Roben.
3444
3445         Part 2 of 4: <http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation
3446
3447         There is no equivalent to NSKeyedUnarchiver in CoreFoundation,
3448         so extract it into a platform-specific source file.
3449
3450         * DumpRenderTree/mac/WebArchiveDumpSupport.h:
3451         (unarchiveNSURLResponseFromResponseData): Added declaration.
3452         * DumpRenderTree/mac/WebArchiveDumpSupport.mm:
3453         (convertWebResourceResponseToDictionary): Extracted code to
3454         unarchiveNSURLResponseFromResponseData() in
3455         WebArchiveDumpSupportMac.mm.  Updated logic to return early if
3456         nil is returned from unarchiveNSURLResponseFromResponseData().
3457         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
3458         (unarchiveNSURLResponseFromResponseData): Added.  Extracted
3459         code from convertWebResourceResponseToDictionary() in
3460         WebArchiveDumpSupport.mm.
3461
3462 2010-10-26  David Kilzer  <ddkilzer@apple.com>
3463
3464         Extract call to -[WebHTMLRepresentation supportedNonImageMIMETypes] from WebArchiveDumpSupport.mm
3465
3466         Reviewed by Adam Roben.
3467
3468         Part 1 of 4: <http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation
3469
3470         The call to -[WebHTMLRepresentation supportedNonImageMIMETypes]
3471         is not cross-platform between Mac and Windows, so extract it
3472         into a platform-specific source file.
3473
3474         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
3475         WebArchiveDumpSupportMac.mm to the project.
3476         * DumpRenderTree/mac/WebArchiveDumpSupport.h:
3477         (supportedNonImageMIMETypes): Added declaration.
3478         * DumpRenderTree/mac/WebArchiveDumpSupport.mm:
3479         (convertWebResourceDataToString): Replaced call to
3480         -[WebHTMLRepresentation supportedNonImageMIMETypes] with
3481         supportedNonImageMIMETypes().
3482         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Added.
3483         (supportedNonImageMIMETypes): Added.  Extracted from
3484         WebArchiveDumpSupport.mm.
3485
3486 2010-10-26  Antonio Gomes  <agomes@rim.com>
3487
3488         Reviewed by Martin Robinson.
3489
3490         [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea)
3491         https://bugs.webkit.org/show_bug.cgi?id=48199
3492
3493         Implements support to WebKitTabToLinksPreferenceKey through LayoutTestController::overridePreference.
3494         The corresponding DumpRenderTreeSupportGtk method is called in the DRT context only.
3495
3496         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3497         (resetDefaultsToConsistentValues):
3498         (createWebView):
3499         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3500         (LayoutTestController::overridePreference):
3501
3502 2010-10-26  Ariya Hidayat  <ariya@sencha.com>
3503
3504         Unreviewed, change the order of my emails for bugzilla autocompletion.
3505
3506         * Scripts/webkitpy/common/config/committers.py:
3507
3508 2010-10-26  Eric Seidel  <eric@webkit.org>
3509
3510         Reviewed by David Kilzer.
3511
3512         build-webkit should collect Visual Studio Express logs and display them
3513         https://bugs.webkit.org/show_bug.cgi?id=39199
3514
3515         * Scripts/build-webkit:
3516         * Scripts/print-vse-failure-logs: Added.
3517         * Scripts/webkitdirs.pm:
3518
3519 2010-10-26  David Kilzer  <ddkilzer@apple.com>
3520
3521         <http://webkit.org/b/48224> build-webkit: add support for --meter-tag switch
3522
3523         Reviewed by Csaba Osztrogonác.
3524
3525         * Scripts/build-webkit: Added support for --meter-tag switch.
3526         It should have been added with r60820.
3527
3528 2010-10-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3529
3530         Reviewed by Dumitru Daniliuc.
3531
3532         check-webkit-style fails on operator+=, operator-=, ... methods
3533         https://bugs.webkit.org/show_bug.cgi?id=48258
3534
3535         * Scripts/webkitpy/style/checkers/cpp.py: Added exceptions
3536         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit-tests
3537
3538 2010-10-26  Ojan Vafai  <ojan@chromium.org>
3539
3540         Reviewed by Tony Chang.
3541
3542         remove DEFER support from new-run-webkit-tests
3543         https://bugs.webkit.org/show_bug.cgi?id=48387
3544
3545         DEFER was needed when we were trying to ship Chrome beta.
3546         Now it's just extra complication.
3547
3548         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3549         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3550         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3551         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3552         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3553         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3554
3555 2010-10-26  Eric Seidel  <eric@webkit.org>
3556
3557         Unreviewed.  Adding import with_statement to fix python 2.5.
3558
3559         Teach webkit-patch how to read credentials from the environment
3560         https://bugs.webkit.org/show_bug.cgi?id=48275
3561
3562         * Scripts/webkitpy/common/net/credentials_unittest.py:
3563          - import with_statement to fix python 2.5.
3564
3565 2010-10-26  Alexey Proskuryakov  <ap@apple.com>
3566
3567         Reviewed by Sam Weinig.
3568
3569         https://bugs.webkit.org/show_bug.cgi?id=48375
3570         <rdar://problem/8392724> Need delegate calls in PageLoaderClient to indicate if we have
3571         loaded insecure content
3572
3573         Updated for WebKit2 changes.
3574
3575         * MiniBrowser/mac/BrowserWindowController.m:
3576         (didDisplayInsecureContentForFrame):
3577         (didRunInsecureContentForFrame):
3578         (-[BrowserWindowController awakeFromNib]):
3579         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3580         (WTR::InjectedBundlePage::InjectedBundlePage):
3581         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
3582         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
3583         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3584         * WebKitTestRunner/TestController.cpp:
3585         (WTR::TestController::initialize):
3586
3587 2010-10-26  Adam Roben  <aroben@apple.com>
3588
3589         Clear up confusion between "3D rendering" and "accelerated compositing"
3590
3591         WebKit has no software-based 3D rendering implementation, so 3D
3592         rendering can only be enabled when accelerated compositing is. But DRT
3593         was falsely reporting that 3D rendering was available on machines that
3594         don't support accelerated compositing, leading to much confusion.
3595
3596         Reviewed by Darin Adler.
3597
3598         Fixes <http://webkit.org/b/48370> REGRESSION (r70540): Many
3599         transforms/3d tests are failing on the XP bots
3600
3601         * DumpRenderTree/win/DumpRenderTree.cpp:
3602         (main): When ENABLE(3D_RENDERING) is turned on, only report that 3D
3603         rendering is available when acclerated compositing is also available.
3604
3605         * Scripts/old-run-webkit-tests: Skip tests that use the
3606         -webkit-transform-3d media query when 3D rendering is disabled,
3607         rather than when accelerated compositing is disabled.
3608
3609 2010-10-26  Eric Seidel  <eric@webkit.org>
3610
3611         Reviewed by Ojan Vafai.
3612
3613         Remove rietveld code now that it's unused
3614         https://bugs.webkit.org/show_bug.cgi?id=48359
3615
3616         Was cool that we added this support, but now that it's
3617         not used it makes little sense to keep it around.
3618         We can always restore this code from SVN if we need it.
3619
3620         * Scripts/webkitpy/common/config/__init__.py:
3621         * Scripts/webkitpy/common/net/bugzilla.py:
3622         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3623         * Scripts/webkitpy/common/net/rietveld.py: Removed.
3624         * Scripts/webkitpy/common/net/rietveld_unittest.py: Removed.
3625         * Scripts/webkitpy/thirdparty/__init__.py:
3626         * Scripts/webkitpy/tool/commands/download.py:
3627         * Scripts/webkitpy/tool/commands/download_unittest.py:
3628         * Scripts/webkitpy/tool/commands/queues.py:
3629         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3630         * Scripts/webkitpy/tool/main.py:
3631         * Scripts/webkitpy/tool/mocktool.py:
3632         * Scripts/webkitpy/tool/steps/__init__.py:
3633         * Scripts/webkitpy/tool/steps/postcodereview.py: Removed.
3634
3635 2010-10-26  Anders Carlsson  <andersca@apple.com>
3636
3637         Reviewed by Sam Weinig.
3638
3639         pageDidScroll callback should be on the UI process client rather than (or in addition to) the web process client
3640         https://bugs.webkit.org/show_bug.cgi?id=48366
3641         <rdar://problem/8595202>
3642
3643         * MiniBrowser/mac/BrowserWindowController.m:
3644         (-[BrowserWindowController awakeFromNib]):
3645         * WebKitTestRunner/TestController.cpp:
3646         (WTR::createOtherPage):
3647         (WTR::TestController::initialize):
3648
3649 2010-10-26  Eric Seidel  <eric@webkit.org>
3650
3651         Reviewed by Tony Chang.
3652
3653         Teach webkit-patch how to read credentials from the environment
3654         https://bugs.webkit.org/show_bug.cgi?id=48275
3655
3656         This makes it possible for svn users to have their bugzilla credentials
3657         stored in their environment instead of typing them every time.
3658
3659         We need this for making it easy to run the win-ews bot (which currently
3660         uses svn instead of git).
3661
3662         * Scripts/webkitpy/common/net/credentials.py:
3663         * Scripts/webkitpy/common/net/credentials_unittest.py:
3664
3665 2010-10-26  Kenichi Ishibashi  <bashi@google.com>
3666
3667         Reviewed by Kent Tamura.
3668
3669         Input Method inserts conversion candidates unexpectedly
3670         https://bugs.webkit.org/show_bug.cgi?id=46868
3671
3672         Adds setComposition() to TextInputController to make DRT emulate
3673         an input method behavior.
3674
3675         * DumpRenderTree/chromium/TextInputController.cpp:
3676         (TextInputController::TextInputController):
3677         (TextInputController::setComposition): Added.
3678         * DumpRenderTree/chromium/TextInputController.h:
3679
3680 2010-10-26  Simon Fraser  <simon.fraser@apple.com>
3681
3682         Reviewed by Sam Weinig.
3683
3684         Support layoutTestController.layerTreeAsText in WebKitTestRunner
3685         https://bugs.webkit.org/show_bug.cgi?id=42145
3686         
3687         Implement layerTreeAsText() in WebKitTestRunner.
3688
3689         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3690         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3691         (WTR::LayoutTestController::layerTreeAsText):
3692         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3693
3694 2010-10-26  Adam Barth  <abarth@webkit.org>
3695
3696         Reviewed by Eric Seidel.
3697
3698         webkit-patch rollout produces incorrect patch when using svn move
3699         https://bugs.webkit.org/show_bug.cgi?id=48244
3700
3701         We need to flush our caches when we modify the working copy.
3702
3703         * Scripts/webkitpy/tool/steps/revertrevision.py:
3704
3705 2010-10-26  Eric Seidel  <eric@webkit.org>
3706
3707         Reviewed by Adam Barth.
3708
3709         commit-queue flaky test message can list the same author more than once
3710         https://bugs.webkit.org/show_bug.cgi?id=48268
3711
3712         tonikitoo reported to me over IRC this morning that he's seen
3713         the commit-queue report flaky tests with author lists like:
3714         "adam, adam and adam", suggesting we're not uniquing authors
3715         before writing the message.
3716
3717         I fixed the uniquing and added a bunch more unit testing.
3718
3719         * Scripts/webkitpy/tool/commands/queues.py:
3720         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3721         * Scripts/webkitpy/tool/mocktool.py:
3722
3723 2010-10-26  Adam Roben  <aroben@apple.com>
3724
3725         Pull in the FeatureDefines*.vsprops files when building DRT
3726
3727         This ensures that various ENABLE() macros will get set correctly.
3728         (Prior to r70320 we were picking up the ENABLE(3D_RENDERING) flag
3729         through wtf/Platform.h.)
3730
3731         Fixes <http://webkit.org/b/48343> REGRESSION (r70320): DumpRenderTree
3732         says 3D_RENDERING is disabled even when it is enabled
3733
3734         Reviewed by Ada Chan.
3735
3736         * DumpRenderTree/win/DumpRenderTree.vcproj: Added
3737         FeaturesDefines*.vsprops to all configurations.
3738
3739         * DumpRenderTree/win/DumpRenderTreeWin.h: Touched to force a rebuild.
3740
3741 2010-10-26  Søren Gjesse  <sgjesse@chromium.org>
3742
3743         Reviewed by Dimitri Glazkov.
3744
3745         Added options --multiple-loads and --js-flags to chromium DumpRenderTree. The option --multiple-loads=X
3746         is used to have DumpRenderTree load each test it runs X times. To be able to have more fine-grained control
3747         of how the JavaScript engine behaves for each load the flag --js-flags can specify a list of flag-sets like this
3748
3749           --js-flags="--xxx,--noxxx --yyy,--noyyy"
3750
3751         First load will run with --xxx, the second with --yyy and the third without any (the 'no' prefix is handled by
3752         V8 to turn off the flag).
3753
3754         The changes to the Python test runner will be in a separate change.
3755
3756
3757         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3758         (runTest):
3759         (main):
3760         * DumpRenderTree/chromium/TestShell.cpp:
3761         (TestShell::TestShell):
3762         (TestShell::runFileTest):
3763         (TestShell::testFinished):
3764         * DumpRenderTree/chromium/TestShell.h:
3765         (TestShell::loadCount):
3766         (TestShell::setLoadCount):
3767         (TestShell::javaScriptFlagsForLoad):
3768         (TestShell::setJavaScriptFlags):
3769         (TestShell::setDumpWhenFinished):
3770
3771 2010-10-26  Adam Roben  <aroben@apple.com>
3772
3773         Skip more tests that depend on accelerated compositing when accelerated
3774         compositing is disabled
3775
3776         Fixes <http://webkit.org/b/48329> Some tests fail when accelerated
3777         compositing is disabled
3778
3779         Reviewed by John Sullivan.
3780
3781         * Scripts/old-run-webkit-tests: Added more tests to skip when
3782         accelerated compositing is disable. The tests all have output that
3783         changes depending on whether accelerated compositing is enabled.
3784
3785 2010-10-25  Eric Seidel  <eric@webkit.org>
3786
3787         Reviewed by Adam Barth.
3788
3789         webkit-patch should clean up svn locks when passed --force-clean
3790         https://bugs.webkit.org/show_bug.cgi?id=48269
3791
3792         * Scripts/webkitpy/common/checkout/scm.py:
3793
3794 2010-10-25  Anders Carlsson  <andersca@apple.com>
3795
3796         Reviewed by Adam Roben.
3797
3798         Add a pageDidScroll BundleUIClient callback
3799         https://bugs.webkit.org/show_bug.cgi?id=48260
3800         <rdar://problem/8531159>
3801
3802         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3803         (WTR::InjectedBundlePage::InjectedBundlePage):
3804
3805 2010-10-25  Johnny Ding  <jnd@chromium.org>
3806
3807         Reviewed by Tony Chang.
3808
3809         Dump the gesture status of frame in frame load callbacks in DumpRenderTree
3810         by adding a new method dumpUserGestureInFrameLoadCallbacks.
3811         Now only dump the gesture status in "DidStartProvisionalLoad" callback.
3812         https://bugs.webkit.org/show_bug.cgi?id=47849
3813
3814         * DumpRenderTree/LayoutTestController.cpp:
3815         (LayoutTestController::LayoutTestController):
3816         (dumpUserGestureInFrameLoadCallbacksCallback):
3817         (LayoutTestController::staticFunctions):
3818         * DumpRenderTree/LayoutTestController.h:
3819         (LayoutTestController::dumpUserGestureInFrameLoadCallbacks):
3820         (LayoutTestController::setDumpUserGestureInFrameLoadCallbacks):
3821         * DumpRenderTree/chromium/LayoutTestController.cpp:
3822         (LayoutTestController::LayoutTestController):
3823         (LayoutTestController::dumpUserGestureInFrameLoadCallbacks):
3824         (LayoutTestController::reset):
3825         * DumpRenderTree/chromium/LayoutTestController.h:
3826         (LayoutTestController::shouldDumpUserGestureInFrameLoadCallbacks):
3827         (LayoutTestController::setShouldDumpUserGestureInFrameLoadCallbacks):
3828         * DumpRenderTree/chromium/TestShell.h:
3829         (TestShell::shouldDumpUserGestureInFrameLoadCallbacks):
3830         * DumpRenderTree/chromium/WebViewHost.cpp:
3831         (WebViewHost::didStartProvisionalLoad):
3832         (WebViewHost::printFrameUserGestureStatus):
3833         * DumpRenderTree/chromium/WebViewHost.h:
3834         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3835         (-[WebFrame _drt_printFrameUserGestureStatus]):
3836         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3837         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3838         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3839         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3840         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3841         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3842         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3843         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3844         (LayoutTestController::reset):
3845         (LayoutTestController::dumpUserGestureInFrameLoadCallbacks):
3846         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3847
3848 2010-10-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3849
3850         Unreviewed, rolling out r70442.
3851         http://trac.webkit.org/changeset/70442
3852         https://bugs.webkit.org/show_bug.cgi?id=48248
3853
3854         http locking doesn't work on Windows (Requested by Ossy on
3855         #webkit).
3856
3857         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3858         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3859
3860 2010-10-25  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3861
3862         Reviewed by Ojan Vafai.
3863
3864         Make http locking default in NRWT.
3865         https://bugs.webkit.org/show_bug.cgi?id=48053
3866
3867         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3868         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3869
3870 2010-10-25  David Kilzer  <ddkilzer@apple.com>
3871
3872         <http://webkit.org/b/48185> build-webkit: add support for --progress-tag switch
3873         (Re-landing r70413 after Qt minimal buildfix: r70440.)
3874
3875         Reviewed by Kenneth Rohde Christiansen.
3876
3877         * Scripts/build-webkit: Added support for --progress-tag switch.
3878         It should have been added with r57051.
3879
3880 2010-10-24  Adam Barth  <abarth@webkit.org>
3881
3882         Reviewed by David Kilzer.
3883
3884         webkit-patch upload fails when the patch removes a file
3885         https://bugs.webkit.org/show_bug.cgi?id=48187
3886
3887         We need to use "--" to separate file names from the rest of the
3888         command.
3889
3890         * Scripts/webkitpy/common/checkout/scm.py:
3891
3892 2010-10-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3893
3894         Unreviewed, rolling out r70413.
3895         http://trac.webkit.org/changeset/70413
3896         https://bugs.webkit.org/show_bug.cgi?id=48210
3897
3898         It broke Qt minimal build (Requested by Ossy on #webkit).
3899
3900         * Scripts/build-webkit:
3901
3902 2010-10-24  Yi Shen  <yi.4.shen@nokia.com>
3903
3904         Reviewed by Andreas Kling.
3905
3906         [Qt][QtTestBrowser] Toggle use of QGraphicsView messes up the menu
3907         https://bugs.webkit.org/show_bug.cgi?id=48141
3908
3909         * QtTestBrowser/launcherwindow.cpp:
3910         (LauncherWindow::init):
3911         (LauncherWindow::initializeView):
3912         (LauncherWindow::toggleWebView):
3913
3914 2010-10-24  Daniel Bates  <dbates@rim.com>
3915
3916         Reviewed by David Kilzer.
3917
3918         Fix Perl uninitialized warnings in VCSUtils::svnStatus()
3919         and VCSUtils::removeEOL().
3920         https://bugs.webkit.org/show_bug.cgi?id=48196
3921
3922         VCSUtils::svnStatus() concatenates the output of svn status with
3923         a new line character and svn status may return no output (say for
3924         a file that has not been added, deleted, or modified). We should
3925         only concatenate the output of svn status if there is some.
3926
3927         Also, VCSUtils::removeEOL() should ensure that its argument
3928         is initialized before performing a string substitution.
3929
3930         * Scripts/VCSUtils.pm:
3931           - Modified removeEOL() to return "" if its argument is undefined.
3932           - Exported removeEOL() so that it can be tested. 
3933         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Added.
3934
3935 2010-10-24  David Kilzer  <ddkilzer@apple.com>
3936
3937         <http://webkit.org/b/48185> build-webkit: add support for --progress-tag switch
3938
3939         Reviewed by Kenneth Rohde Christiansen.
3940
3941         * Scripts/build-webkit: Added support for --progress-tag switch.
3942         It should have been added with r57051.
3943
3944 2010-10-24  David Kilzer  <ddkilzer@apple.com>
3945
3946         <http://webkit.org/b/48184> build-webkit: reformat support variables for better maintainability
3947
3948         Reviewed by Daniel Bates.
3949
3950         * Scripts/build-webkit: Alphabetized the @features array based
3951         on the name of the feature.  Reformatted the list of support
3952         variables so that they match the order of @features, and so that
3953         each has its own line.  This makes it easy to add new variables
3954         in the correct order.
3955
3956 2010-10-23  Eric Seidel  <eric@webkit.org>
3957
3958         Reviewed by Adam Barth.
3959
3960         EWS never removes invalid patch ids
3961         https://bugs.webkit.org/show_bug.cgi?id=48173
3962
3963         This is just sticking another finger in the dam.
3964         However this adds more unit testing which will help
3965         us make sure we're always releasing patches once we
3966         redesign the release_patch API and call these from
3967         a more central place.
3968
3969         * Scripts/webkitpy/tool/commands/queues.py:
3970         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3971         * Scripts/webkitpy/tool/mocktool.py:
3972          - Added the ability to request invalid patches.
3973            Log a warning message to make sure we don't ever have
3974            tests use invalid patch fetches by mistake.
3975
3976 2010-10-23  Dan Bernstein  <mitz@apple.com>
3977
3978         Build fix. Add stub implementations for required NSDraggingInfo methods.
3979
3980         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3981         (-[DumpRenderTreeDraggingInfo draggingFormation]):
3982         (-[DumpRenderTreeDraggingInfo setDraggingFormation:]):
3983         (-[DumpRenderTreeDraggingInfo animatesToDestination]):
3984         (-[DumpRenderTreeDraggingInfo setAnimatesToDestination:]):
3985         (-[DumpRenderTreeDraggingInfo numberOfValidItemsForDrop]):
3986         (-[DumpRenderTreeDraggingInfo setNumberOfValidItemsForDrop:]):
3987         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3988
3989 2010-10-23  David Kilzer  <ddkilzer@apple.com>
3990
3991         <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
3992
3993         Reviewed by Sam Weinig.
3994
3995         The only method defined in WebHTMLRepresentationInternal.h is
3996         also defined in WebHTMLRepresentation.h, so use that instead.
3997
3998         * DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Removed.
3999         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Switched to use
4000         WebHTMLRepresentation.h.
4001
4002 2010-10-23  Sheriff Bot  <webkit.review.bot@gmail.com>
4003
4004         Unreviewed, rolling out r70367.
4005         http://trac.webkit.org/changeset/70367
4006         https://bugs.webkit.org/show_bug.cgi?id=48176
4007
4008         It made 8-10 tests crash on Qt bot (Requested by Ossy on
4009         #webkit).
4010
4011         * DumpRenderTree/LayoutTestController.cpp:
4012         (setCustomPolicyDelegateCallback):
4013         * DumpRenderTree/LayoutTestController.h:
4014         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4015         (LayoutTestController::setCustomPolicyDelegate):
4016         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4017         (LayoutTestController::setCustomPolicyDelegate):
4018         * DumpRenderTree/mac/PolicyDelegate.h:
4019         * DumpRenderTree/mac/PolicyDelegate.mm:
4020         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
4021         (-[PolicyDelegate setPermissive:]):
4022         (-[PolicyDelegate setControllerToNotifyDone:]):
4023         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4024         (LayoutTestController::setCustomPolicyDelegate):
4025         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4026         (LayoutTestController::setCustomPolicyDelegate):
4027
4028 2010-10-22  Eric Seidel  <eric@webkit.org>
4029
4030         Reviewed by Adam Barth.
4031
4032         EWS never releases patches which fail to apply
4033         https://bugs.webkit.org/show_bug.cgi?id=48171
4034
4035         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4036         * Scripts/webkitpy/tool/commands/queues.py:
4037
4038 2010-10-22  Eric Seidel  <eric@webkit.org>
4039
4040         Unreviewed.
4041
4042         Make the EWS queues restart themselves more often.
4043         This matches the commit-queue.
4044
4045         * EWSTools/start-queue.sh:
4046
4047 2010-10-22  Eric Seidel  <eric@webkit.org>
4048
4049         Reviewed by Adam Barth.
4050
4051         commit-queue should not pass --quiet to subcommands now that the parent command does the reporting
4052         https://bugs.webkit.org/show_bug.cgi?id=48165
4053
4054         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4055         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4056         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4057
4058 2010-10-22  Mario Sanchez Prada  <msanchez@igalia.com>
4059
4060         Adding myself as a committer.
4061
4062         * Scripts/webkitpy/common/config/committers.py:
4063
4064 2010-10-20  Anders Carlsson  <andersca@apple.com>
4065
4066         Reviewed by Adam Barth and Darin Adler.
4067
4068         Using the decidePolicyForMIMEType delegate message in an asynchronous manner does not work
4069         https://bugs.webkit.org/show_bug.cgi?id=48014
4070         <rdar://problem/8202716>
4071         
4072         * DumpRenderTree/LayoutTestController.cpp:
4073         (setCustomPolicyDelegateCallback):
4074         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
4075
4076         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4077         (LayoutTestController::setCustomPolicyDelegate):
4078         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
4079
4080         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4081         (LayoutTestController::setCustomPolicyDelegate):
4082         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
4083
4084         * DumpRenderTree/mac/PolicyDelegate.h:
4085         * DumpRenderTree/mac/PolicyDelegate.mm:
4086         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
4087         If _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond is true, call [listener ignore] after one second.
4088
4089         (-[PolicyDelegate setCallIgnoreInDecidePolicyForMIMETypeAfterOneSecond:]):
4090         Update _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond.
4091         
4092         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4093         (LayoutTestController::setCustomPolicyDelegate):
4094         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
4095
4096         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4097         (LayoutTestController::setCustomPolicyDelegate):
4098         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
4099
4100 2010-10-22  Sam Weinig  <sam@webkit.org>
4101
4102         Reviewed by Anders Carlsson.
4103
4104         Rename the InjectedBundle for TestWebKitAPI to InjectedBundleTestWebKitAPI.bundle
4105
4106         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
4107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4108         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
4109         (TestWebKitAPI::Util::createInjectedBundlePath):
4110
4111 2010-10-22  Dirk Pranke  <dpranke@chromium.org>
4112
4113         Reviewed by Eric Seidel.
4114
4115         test-webkitpy fails when passed -v (or any other option)
4116
4117         Fix port/base_unittest to pass an explicit list of arguments
4118         rather than accidentally picking up sys.argv.
4119
4120         https://bugs.webkit.org/show_bug.cgi?id=48071
4121
4122         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4123
4124 2010-10-22  Brian Weinstein  <bweinstein@apple.com>
4125
4126         Windows build fix. Update the createNewPage callback to account for the new
4127         arguments.
4128
4129         * MiniBrowser/win/BrowserView.cpp:
4130         (createNewPage):
4131
4132 2010-10-22  Sam Weinig  <sam@webkit.org>
4133
4134         Reviewed by Anders Carlsson.
4135
4136         WebKit2 needs to pass the current event modifier flags when requesting a new window
4137         https://bugs.webkit.org/show_bug.cgi?id=48140
4138
4139         * MiniBrowser/mac/BrowserWindowController.m:
4140         (createNewPage):
4141         * WebKitTestRunner/TestController.cpp:
4142         (WTR::createOtherPage):
4143         Update for new signature for the WKPageCreateNewPageCallback.
4144
4145 2010-10-22  Eric Seidel  <eric@webkit.org>
4146
4147         Unreviewed.  Just adding a test case.
4148
4149         The style-queue was not recognizing new patches.  It turns
4150         out I had fixed this in an earlier change, but just not
4151         deployed to queues.webkit.org.  As part of investigating why it
4152         was broken, I wrote a test for my previous change which I'm now landing.
4153
4154         * QueueStatusServer/model/queues_unittest.py:
4155
4156 2010-10-22  Eric Seidel  <eric@webkit.org>
4157
4158         Reviewed by Adam Barth.
4159
4160         EWS does not need to process obsolete patches
4161         https://bugs.webkit.org/show_bug.cgi?id=48093
4162
4163         This was an easy change, but to test it I had to pipe
4164         real Attachment objects into the queue testing system.
4165         Doing so revealed a whole bunch of bugs in our unit tests,
4166         which I fixed as part of this patch.
4167
4168         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4169          - This is the actual code change.  This will not reduce the
4170            backlog in the EWS queues much, but it will make rejections
4171            much quicker for obsolete patches or closed bugs.
4172         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4173          - Test my new code.
4174          - Used a real attachment object and got rid of MockPatch
4175          - Shared code between the mac-ews and cr-mac-ews tests.
4176         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4177          - Can't use MockPatch anymore.
4178          - Removing MockPatch found more bugs here!
4179         * Scripts/webkitpy/tool/commands/queuestest.py:
4180         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
4181         * Scripts/webkitpy/tool/mocktool.py:
4182          - MockBugzilla should not be a "Mock" object.  Right now tool.bugs()
4183            is allowed, but wrong.  Making it not a Mock will make tool.bugs() correctly fail.
4184
4185 2010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>
4186
4187         Unreviewed, rolling out r70301.
4188         http://trac.webkit.org/changeset/70301
4189         https://bugs.webkit.org/show_bug.cgi?id=48126
4190
4191         "Lang attribute layout tests failing" (Requested by satish on
4192         #webkit).
4193
4194         * DumpRenderTree/LayoutTestController.cpp:
4195         (setMockSpeechInputResultCallback):
4196         * DumpRenderTree/LayoutTestController.h:
4197         * DumpRenderTree/chromium/LayoutTestController.cpp:
4198         (LayoutTestController::setMockSpeechInputResult):
4199         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4200         (LayoutTestController::setMockSpeechInputResult):
4201         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4202         (LayoutTestController::setMockSpeechInputResult):
4203         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4204         (LayoutTestController::setMockSpeechInputResult):
4205         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4206         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4207         (LayoutTestController::setMockSpeechInputResult):
4208         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4209         (LayoutTestController::setMockSpeechInputResult):
4210
4211 2010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>
4212
4213         Reviewed by Jeremy Orlow.
4214
4215         Added a second parameter to setMockSpeechInputResult for
4216         the language used in speech input.
4217         https://bugs.webkit.org/show_bug.cgi?id=47089
4218
4219         * DumpRenderTree/LayoutTestController.cpp: