WebKitTools/ChangeLog

   1 2009-11-27  Adam Barth  <abarth@webkit.org>
   2
   3         Reviewed by Eric Seidel.
   4
   5         [bzt] Unit test download commands
   6         https://bugs.webkit.org/show_bug.cgi?id=31923
   7
   8         Adds download_unittest and fixes a bug found while testing.
   9
  10         * Scripts/modules/commands/commandtest.py:
  11         * Scripts/modules/commands/download.py:
  12             Fixed a bug where we'd throw an error because [].append returns
  13             None.
  14         * Scripts/modules/commands/download_unittest.py: Added.
  15         * Scripts/modules/mock_bugzillatool.py:
  16         * Scripts/run-webkit-unittests:
  17
  18 2009-11-27  Adam Barth  <abarth@webkit.org>
  19
  20         Unreviewed "build" fix found while writing unit tests.
  21
  22         * Scripts/modules/commands/download.py:
  23
  24 2009-11-27  Adam Barth  <abarth@webkit.org>
  25
  26         Reviewed by Eric Seidel.
  27
  28         [bzt] Kill WebKitLandingScripts
  29         https://bugs.webkit.org/show_bug.cgi?id=31904
  30
  31         Step 6: Kill the rest.
  32
  33         * Scripts/modules/buildsteps.py:
  34         * Scripts/modules/commands/download.py:
  35         * Scripts/modules/commands/queries.py:
  36         * Scripts/modules/commands/upload.py:
  37         * Scripts/modules/landingsequence.py:
  38         * Scripts/modules/scm.py:
  39         * Scripts/modules/webkitlandingscripts.py: Removed.
  40
  41 2009-11-27  Adam Barth  <abarth@webkit.org>
  42
  43         Reviewed by Eric Seidel.
  44
  45         [bzt] Unit test upload commands
  46         https://bugs.webkit.org/show_bug.cgi?id=31903
  47
  48         Adds unit tests for all but two of the upload commands.  The two
  49         remaining ones are more difficult.  I'll return to them later.  The
  50         goal of these tests is just to run the commands.  We can test more
  51         detailed behavior later.
  52
  53         * Scripts/modules/commands/commandtest.py:
  54         * Scripts/modules/commands/upload.py:
  55         * Scripts/modules/commands/upload_unittest.py:
  56         * Scripts/modules/mock.py: Added.
  57         * Scripts/modules/mock_bugzillatool.py:
  58
  59 2009-11-26  Adam Barth  <abarth@webkit.org>
  60
  61         Reviewed by Eric Seidel.
  62
  63         [bzt] Kill WebKitLandingScripts
  64         https://bugs.webkit.org/show_bug.cgi?id=31904
  65
  66         Step 5: Kill run_and_throw_if_fail.
  67
  68         * Scripts/modules/buildsteps.py:
  69         * Scripts/modules/processutils.py: Added.
  70         * Scripts/modules/webkitlandingscripts.py:
  71
  72 2009-11-26  Adam Barth  <abarth@webkit.org>
  73
  74         Reviewed by Eric Seidel.
  75
  76         [bzt] Kill WebKitLandingScripts
  77         https://bugs.webkit.org/show_bug.cgi?id=31904
  78
  79         Step 4: Kill run_webkit_script.
  80
  81         * Scripts/modules/buildsteps.py:
  82         * Scripts/modules/commands/download.py:
  83         * Scripts/modules/webkitlandingscripts.py:
  84
  85 2009-11-26  Adam Barth  <abarth@webkit.org>
  86
  87         Reviewed by Eric Seidel.
  88
  89         [bzt] Kill WebKitLandingScripts
  90         https://bugs.webkit.org/show_bug.cgi?id=31904
  91
  92         Step 3: Kill build_webkit.
  93
  94         * Scripts/modules/buildsteps.py:
  95         * Scripts/modules/landingsequence.py:
  96         * Scripts/modules/webkitlandingscripts.py:
  97
  98 2009-11-26  Adam Barth  <abarth@webkit.org>
  99
 100         Reviewed by Eric Seidel.
 101
 102         [bzt] Kill WebKitLandingScripts
 103         https://bugs.webkit.org/show_bug.cgi?id=31904
 104
 105         Step 2: Kill ensure_builders_are_green.
 106
 107         * Scripts/modules/buildsteps.py:
 108         * Scripts/modules/commands/download.py:
 109         * Scripts/modules/landingsequence.py:
 110         * Scripts/modules/webkitlandingscripts.py:
 111
 112 2009-11-26  Adam Barth  <abarth@webkit.org>
 113
 114         Reviewed by Eric Seidel.
 115
 116         [bzt] Kill WebKitLandingScripts
 117         https://bugs.webkit.org/show_bug.cgi?id=31904
 118
 119         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
 120
 121         * Scripts/bugzilla-tool:
 122         * Scripts/modules/buildsteps.py: Added.
 123         * Scripts/modules/commands/download.py:
 124         * Scripts/modules/landingsequence.py:
 125         * Scripts/modules/webkitlandingscripts.py:
 126
 127 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
 128
 129         Reviewed by Adam Barth.
 130
 131         Remove directory prefixes from linux commands
 132
 133         SCM unittests can cause errors on some systems if we use absolute reference to
 134         the commands, so directory prefixes have been removed.
 135
 136         * Scripts/modules/scm_unittest.py:
 137
 138 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
 139
 140         Reviewed by Kenneth Rohde Christiansen.
 141
 142         Link DumpRenderTree to the Qt Ui Tools
 143         https://bugs.webkit.org/show_bug.cgi?id=31203
 144
 145         Implement QWebPage::createPlugin using the Qt Ui Tools
 146         to be able to create classes like QProgressBar from within
 147         the <object></object> tags This is required for the
 148         new automatic test of Qt Plugins.
 149
 150         * DumpRenderTree/qt/DumpRenderTree.cpp:
 151         (WebCore::WebPage::createPlugin):
 152         * DumpRenderTree/qt/DumpRenderTree.h:
 153         * DumpRenderTree/qt/DumpRenderTree.pro:
 154
 155 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
 156
 157         Reviewed by Eric Seidel.
 158
 159         Update pywebsocket to 0.4.2
 160
 161         Update pywebsocket to 0.4.2
 162         https://bugs.webkit.org/show_bug.cgi?id=31861
 163
 164         * pywebsocket/example/echo_client.py:
 165         * pywebsocket/example/echo_wsh.py:
 166         * pywebsocket/mod_pywebsocket/__init__.py:
 167         * pywebsocket/mod_pywebsocket/dispatch.py:
 168         * pywebsocket/mod_pywebsocket/msgutil.py:
 169         * pywebsocket/mod_pywebsocket/standalone.py:
 170         * pywebsocket/setup.py:
 171         * pywebsocket/test/test_dispatch.py:
 172         * pywebsocket/test/test_msgutil.py:
 173
 174 2009-11-25  Adam Barth  <abarth@webkit.org>
 175
 176         Reviewed by Eric Seidel.
 177
 178         Add unit test for mark-fixed
 179         https://bugs.webkit.org/show_bug.cgi?id=31896
 180
 181         * Scripts/modules/commands/commandtest.py: Added.
 182         * Scripts/modules/commands/queries_unittest.py:
 183         * Scripts/modules/commands/upload_unittest.py: Added.
 184         * Scripts/modules/mock_bugzillatool.py:
 185         * Scripts/run-webkit-unittests:
 186
 187 2009-11-25  Adam Barth  <abarth@webkit.org>
 188
 189         Reviewed by Eric Seidel.
 190
 191         bugzilla-tool should have a mark-fixed command
 192         https://bugs.webkit.org/show_bug.cgi?id=31853
 193
 194         Pretty simple stuff.
 195
 196         * Scripts/modules/commands/upload.py:
 197
 198 2009-11-25  Eric Seidel  <eric@webkit.org>
 199
 200         Reviewed by Adam Barth.
 201
 202         'bugzilla-tool help' should only show common commands like how 'git help' does
 203         https://bugs.webkit.org/show_bug.cgi?id=31772
 204
 205         I also took this opportunity to make 'help' a real Command.
 206         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
 207
 208         * Scripts/bugzilla-tool:
 209          - change should_show_command_help to should_show_in_main_help
 210         * Scripts/modules/commands/download.py:
 211          - Mark commands as being shown in main help or not.
 212          - show_in_main_help = False is not required (default is false),
 213            but it seemed to make the commands more self-documenting.
 214         * Scripts/modules/commands/queries.py: ditto
 215         * Scripts/modules/commands/queues.py: ditto
 216         * Scripts/modules/commands/upload.py: ditto
 217         * Scripts/modules/multicommandtool.py:
 218          - Make Command hold a pointer to tool in self.tool.  Most Command
 219            subclasses do not take advantage of this yet, but it was required
 220            for HelpCommand to be able to reach the tool from _help_epilog().
 221          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
 222          - Move MultiCommandTool._help_epilog to Command._help_epilog
 223          - Move "help" logic into HelpCommand.execute()
 224          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
 225         * Scripts/modules/multicommandtool_unittest.py:
 226          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
 227
 228 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
 229
 230         Reviewed by Dan Bernstein.
 231
 232         Patch by Mark Rowe.
 233
 234         The buildbots are failing on Windows because when they were upgraded
 235         to 4.0.4, Apple Application Support was not in their path. Add it to
 236         the path to fix the buildots.
 237
 238         * Scripts/webkitdirs.pm:
 239
 240 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
 241
 242         Reviewed by David Kilzer.
 243
 244         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
 245         https://bugs.webkit.org/show_bug.cgi?id=31799
 246
 247         * Scripts/run-webkit-tests: Fixed.
 248
 249 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
 250
 251         Reviewed by Eric Seidel.
 252
 253         Change run_command to give back stderr by default
 254         https://bugs.webkit.org/show_bug.cgi?id=31734
 255
 256         Change run_command to give back stderr by default.
 257         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
 258         Change the related unittest call.
 259
 260         * Scripts/modules/scm.py:
 261         * Scripts/modules/scm_unittest.py:
 262
 263 2009-11-25  Eric Seidel  <eric@webkit.org>
 264
 265         Reviewed by Adam Barth.
 266
 267         Centralize required argument parsing in Command
 268         https://bugs.webkit.org/show_bug.cgi?id=31872
 269
 270         * Scripts/modules/commands/download.py: remove custom required arg message.
 271         * Scripts/modules/commands/upload.py: ditto.
 272         * Scripts/modules/multicommandtool.py:
 273          - Add _parse_required_arguments.
 274          - Pass program name off to OptionParser.
 275          - Add name() for access to tool name.
 276          - Add check_arguments_and_execute and make it return a return code.
 277          - Replace a couple uses of + with %.
 278         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
 279
 280 2009-11-25  Eric Seidel  <eric@webkit.org>
 281
 282         Reviewed by Adam Barth.
 283
 284         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
 285         https://bugs.webkit.org/show_bug.cgi?id=31870
 286
 287         * Scripts/modules/commands/queries_unittest.py: Use the new class.
 288         * Scripts/modules/multicommandtool_unittest.py: Ditto.
 289         * Scripts/modules/outputcapture.py: Added.
 290
 291 2009-11-24  Dmitry Titov  <dimich@chromium.org>
 292
 293         Reviewed by Eric Seidel.
 294
 295         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
 296         https://bugs.webkit.org/show_bug.cgi?id=31444
 297
 298         * Scripts/build-webkit:
 299
 300 2009-11-24  Chris Marrin  <cmarrin@apple.com>
 301
 302         Reviewed by Simon Fraser.
 303
 304         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
 305         https://bugs.webkit.org/show_bug.cgi?id=27314
 306
 307         Now the script allows the directories with these tests to be included on all
 308         platforms but Mac, where they behave the same as always. For all other platforms
 309         the tests need to be excluded using the Skipped files, which is currently done
 310         for all platforms (including win since we're not turned on yet)
 311
 312         * Scripts/webkitdirs.pm:
 313
 314 2009-11-24  Eric Seidel  <eric@webkit.org>
 315
 316         Reviewed by Adam Barth.
 317
 318         queries_unittest.py should test command output
 319         https://bugs.webkit.org/show_bug.cgi?id=31845
 320
 321         * Scripts/modules/commands/queries_unittest.py:
 322          - Capture stdout and stderr and compare with expected strings.
 323
 324 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
 325
 326         No Review.
 327
 328         Fix spelling error ("depenedencies").
 329
 330         * Scripts/build-webkit:
 331
 332 2009-11-24  Mark Rowe  <mrowe@apple.com>
 333
 334         Land the configuration that includes the two debug GTK Linux builders.
 335
 336         * BuildSlaveSupport/build.webkit.org-config/config.json:
 337
 338 2009-11-24  David Kilzer  <ddkilzer@apple.com>
 339
 340         <http://webkit.org/b/31840> bisect-builds broke after r50080
 341
 342         Reviewed by Dan Bernstein.
 343
 344         * Scripts/bisect-builds:
 345         (mountAndRunNightly): Switched back to using backticks to run
 346         the hdiutil command since exec() will terminate the existing
 347         script, which is not what we want.  Store the output of
 348         File::Spec->devnull() in a variable for use in the hdiutil
 349         detach commands.
 350
 351 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 352
 353         Reviewed by Kenneth Rohde Christiansen.
 354
 355         Include "config.h" to meet Coding Style Guidelines
 356         https://bugs.webkit.org/show_bug.cgi?id=31792
 357
 358         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
 359         * DumpRenderTree/qt/jsobjects.cpp:
 360         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
 361
 362 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 363
 364         Reviewed by Oliver Hunt.
 365
 366         Implement new required function to pass test we used to pass. This
 367         change is required since r51294.
 368
 369         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 370         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 371
 372 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
 373
 374         Reviewed by Kenneth Rohde Christiansen.
 375
 376         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
 377         https://bugs.webkit.org/show_bug.cgi?id=31775
 378
 379         LayoutTestController::dumpBackForwardList() should work with local URLs
 380         as well as with normal URLs (in http tests for instance).
 381         Currently it does not output the latter properly.
 382
 383         Unskip a bunch of passing http/navigation tests.
 384
 385         * DumpRenderTree/qt/DumpRenderTree.cpp:
 386         (WebCore::dumpHistoryItem):
 387
 388 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
 389
 390         Reviewed by Oliver Hunt.
 391
 392         ARIA: support aria-flowto
 393         https://bugs.webkit.org/show_bug.cgi?id=31762
 394
 395         * DumpRenderTree/AccessibilityUIElement.cpp:
 396         (ariaFlowToElementAtIndexCallback):
 397         (AccessibilityUIElement::getJSClass):
 398         * DumpRenderTree/AccessibilityUIElement.h:
 399         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 400         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 401         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 402         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 403         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 404         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 405
 406 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
 407
 408         Reviewed by Kenneth Christiansen.
 409
 410         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
 411         https://bugs.webkit.org/show_bug.cgi?id=31638
 412
 413         Unfreeze WorkQueue after each test execution.
 414
 415         * DumpRenderTree/qt/DumpRenderTree.cpp:
 416         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 417
 418 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
 419
 420         Reviewed by Adam Barth.
 421
 422         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
 423         for localhost and 127.0.0.1.
 424         https://bugs.webkit.org/show_bug.cgi?id=31783
 425
 426         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
 427
 428         * DumpRenderTree/qt/DumpRenderTree.cpp:
 429         (WebCore::NetworkAccessManager::NetworkAccessManager):
 430         (WebCore::NetworkAccessManager::sslErrorsEncountered):
 431         (WebCore::WebPage::WebPage):
 432         * DumpRenderTree/qt/DumpRenderTree.h:
 433
 434 2009-11-22  Chris Evans  <cevans@chromium.org>
 435
 436         Reviewed by Adam Barth.
 437
 438         Disable access to file:/// directory listings
 439         https://bugs.webkit.org/show_bug.cgi?id=31329
 440
 441         Implemented setAllowUniversalAccessFromFileURLs to support testing of
 442         file URL security.
 443
 444         * DumpRenderTree/LayoutTestController.cpp:
 445         (setAllowUniversalAccessFromFileURLsCallback):
 446         (LayoutTestController::staticFunctions):
 447         * DumpRenderTree/LayoutTestController.h:
 448         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 449         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 450         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 451         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 452         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 453         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 454         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 455         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 456
 457 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
 458
 459         Reviewed by Kenneth Rohde Christiansen.
 460
 461         [Qt] Fix the timeout of fast/frames/frame-navigation.html
 462         https://bugs.webkit.org/show_bug.cgi?id=31638
 463
 464         The test is timeouting, because it uses the WorkQueue to load a document in one
 465         of the child frames and once the loading is finished, the DRT does not dump the
 466         tree. This is because it waits for the QWebFrame::loadFinished() signal from
 467         the main frame, while it should connect to QWebPage::loadFinished().
 468
 469         * DumpRenderTree/qt/DumpRenderTree.cpp:
 470         (WebCore::DumpRenderTree::DumpRenderTree):
 471
 472 2009-11-21  Eric Seidel  <eric@webkit.org>
 473
 474         Reviewed by Adam Barth.
 475
 476         bugzilla-tool --help spews way too much text
 477         https://bugs.webkit.org/show_bug.cgi?id=31771
 478
 479         * Scripts/bugzilla-tool:
 480          - Remove self.cached_scm initialization hack.
 481         * Scripts/modules/buildbot.py:
 482          - Make default_host accessible to callers.
 483         * Scripts/modules/commands/download.py:
 484          - Phrase help for all commands consistently and remove spurious help text punctuation.
 485         * Scripts/modules/commands/queries.py: Ditto.
 486         * Scripts/modules/commands/queues.py: Ditto.
 487         * Scripts/modules/commands/upload.py: Ditto.
 488         * Scripts/modules/multicommandtool.py:
 489          - Add HelpPrintingOptionParser.format_epilog to replace
 490            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
 491            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
 492          - Make --help only show a list of commands like "svn help" and "git help" do --
 493            previously --help was listing all commands and options.
 494          - Sort list of commands alphabetically.
 495
 496 2009-11-21  Eric Seidel  <eric@webkit.org>
 497
 498         No review.  Fixing a typo from the previous patch for bug 31767.
 499
 500         AbstractQueue.run_bugzilla_tool throws an exception
 501         https://bugs.webkit.org/show_bug.cgi?id=31769
 502
 503         * Scripts/modules/commands/queues.py:
 504
 505 2009-11-21  Eric Seidel  <eric@webkit.org>
 506
 507         Reviewed by Adam Barth.
 508
 509         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
 510         https://bugs.webkit.org/show_bug.cgi?id=31767
 511
 512         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
 513         Since we don't have a good way to test BugzillaTool pieces, I've
 514         left out a test for now.
 515
 516         * Scripts/bugzilla-tool:
 517          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
 518         * Scripts/modules/commands/queues.py:
 519          - Use tool.path() instead of __file__.
 520         * Scripts/modules/multicommandtool.py:
 521          - Add a new path() method to MultiComandTool.
 522         * Scripts/modules/multicommandtool_unittest.py:
 523          - Provide a path() method.  Little point in testing this mock implementation.
 524
 525 2009-11-21  Adam Barth  <abarth@webkit.org>
 526
 527         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
 528         WebKitTools.
 529
 530         * Scripts/modules/commands/download.py:
 531
 532 2009-11-21  Adam Barth  <abarth@webkit.org>
 533
 534         Reviewed by Eric Seidel.
 535
 536         Convert check-style to use LandingSequence
 537         https://bugs.webkit.org/show_bug.cgi?id=31763
 538
 539         Instead of manipulating the working copy by hand, we should use the
 540         LandingSequence in CheckStyle.  This will make this code eaiser to
 541         test.
 542
 543         * Scripts/modules/commands/download.py:
 544
 545 2009-11-20  Adam Barth  <abarth@webkit.org>
 546
 547         Reviewed by Eric Seidel.
 548
 549         Unit test query commands
 550         https://bugs.webkit.org/show_bug.cgi?id=31755
 551
 552         These tests are pretty rough, but hopefully they'll grow.
 553
 554         * Scripts/modules/commands/queries_unittest.py: Added.
 555         * Scripts/modules/mock_bugzillatool.py: Added.
 556         * Scripts/run-webkit-unittests:
 557
 558 2009-11-20  Eric Seidel  <eric@webkit.org>
 559
 560         Reviewed by Adam Barth.
 561
 562         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
 563         https://bugs.webkit.org/show_bug.cgi?id=31758
 564
 565         * Scripts/modules/multicommandtool.py:
 566          - Allow passing of explicit commands to MultiCommandTool.__init__
 567         * Scripts/modules/multicommandtool_unittest.py:
 568          - Use new Command.name naming system.
 569          - Test Command auto-discovery.
 570         * Scripts/modules/workqueue.py:
 571          - bug_id no longer exists, use patch['bug_id'] instead.
 572         * Scripts/modules/workqueue_unittest.py:
 573          - WorkQueues require names now.
 574          - should_proceed_with_work_item must return a patch object.
 575
 576 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
 577
 578         Reviewed by Beth Dakin.
 579
 580         WAI-ARIA: add support for aria-owns
 581         https://bugs.webkit.org/show_bug.cgi?id=31702
 582
 583         * DumpRenderTree/AccessibilityUIElement.cpp:
 584         (ariaOwnsElementAtIndexCallback):
 585         (AccessibilityUIElement::getJSClass):
 586         * DumpRenderTree/AccessibilityUIElement.h:
 587         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 588         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 589         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 590         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 591         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 592         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 593
 594 2009-11-20  Eric Seidel  <eric@webkit.org>
 595
 596         Reviewed by Adam Barth.
 597
 598         Fix exception thrown when running the commit-queue.
 599
 600         * Scripts/modules/statusbot.py: patch is optional.
 601         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
 602
 603 2009-11-20  Eric Seidel  <eric@webkit.org>
 604
 605         Reviewed by Adam Barth.
 606
 607         Teach the StatusBot how to support more than just the commit-queue
 608         https://bugs.webkit.org/show_bug.cgi?id=31754
 609
 610         * Scripts/modules/workqueue.py: Another typo.
 611
 612 2009-11-20  Eric Seidel  <eric@webkit.org>
 613
 614         Reviewed by Adam Barth.
 615
 616         Teach the StatusBot how to support more than just the commit-queue
 617         https://bugs.webkit.org/show_bug.cgi?id=31754
 618
 619         * Scripts/modules/commands/queues.py: Fix silly typo.
 620
 621 2009-11-20  Eric Seidel  <eric@webkit.org>
 622
 623         Reviewed by Adam Barth.
 624
 625         Teach the StatusBot how to support more than just the commit-queue
 626         https://bugs.webkit.org/show_bug.cgi?id=31754
 627
 628         * CommitQueueStatus/index.yaml:
 629          - Add indices required for the new queries.
 630         * CommitQueueStatus/queue_status.py:
 631          - Add a patch-status page and move update_status to update-status.
 632          - Only display "commit-queue" status records for the commit-queue.
 633          - Add support for a queue_name property on status records.
 634          - Fix _int_from_request to actually work.
 635         * CommitQueueStatus/update_status.html:
 636          - Add support for a queue_name on status records.
 637          - Remove unused list of bug ids.
 638          * Scripts/modules/commands/queues.py
 639           - Make the queues pass the patch instead of the bug_id to StatusBot.
 640         * Scripts/modules/statusbot.py:
 641          - Support passing the queue_name to the status updates.
 642          - Support fetching patch status with patch_status().
 643         * Scripts/modules/workqueue.py:
 644          - Pass the patch to the StatusBot instead of the bug_id.
 645          - Let WorkQueues have a name.
 646
 647 2009-11-20  Adam Barth  <abarth@webkit.org>
 648
 649         Reviewed by Eric Seidel.
 650
 651         Move bugzilla-tool commands into their own file
 652         https://bugs.webkit.org/show_bug.cgi?id=31752
 653
 654         This will let us write unit tests.
 655
 656         * Scripts/bugzilla-tool:
 657         * Scripts/modules/commands/__init__.py: Added.
 658         * Scripts/modules/commands/download.py: Added.
 659         * Scripts/modules/commands/queries.py: Added.
 660         * Scripts/modules/commands/queues.py: Added.
 661         * Scripts/modules/commands/upload.py: Added.
 662         * Scripts/modules/grammar.py: Added.
 663
 664 2009-11-20  Adam Barth  <abarth@webkit.org>
 665
 666         Reviewed by Eric Seidel.
 667
 668         BuildQueue should check if the tree is currently buildable
 669         https://bugs.webkit.org/show_bug.cgi?id=31744
 670
 671         * Scripts/bugzilla-tool:
 672         * Scripts/modules/landingsequence.py:
 673         * Scripts/modules/webkitlandingscripts.py:
 674
 675 2009-11-20  Adam Barth  <abarth@webkit.org>
 676
 677         Reviewed by Eric Seidel.
 678
 679         Move prepare_clean_working_directory into the LandingSequence
 680         https://bugs.webkit.org/show_bug.cgi?id=31743
 681
 682         * Scripts/bugzilla-tool:
 683         * Scripts/modules/landingsequence.py:
 684
 685 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
 686
 687         Reviewed by Kenneth Rohde Christiansen.
 688
 689         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
 690         https://bugs.webkit.org/show_bug.cgi?id=30460
 691
 692         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
 693
 694         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 695         (pluginInvoke):
 696
 697 2009-11-20  Adam Barth  <abarth@webkit.org>
 698
 699         Reviewed by Eric Seidel.
 700
 701         Pass the port information to the child process
 702         https://bugs.webkit.org/show_bug.cgi?id=31736
 703
 704         We need to do this so the child process knows what to build!
 705
 706         * Scripts/bugzilla-tool:
 707         * Scripts/modules/landingsequence.py:
 708         * Scripts/modules/webkitport.py:
 709         * Scripts/modules/webkitport_unittest.py:
 710
 711 2009-11-20  Adam Barth  <abarth@webkit.org>
 712
 713         Reviewed by Eric Seidel.
 714
 715         Support Qt port in build-queue
 716         https://bugs.webkit.org/show_bug.cgi?id=31733
 717
 718         * Scripts/bugzilla-tool:
 719
 720 2009-11-20  Adam Barth  <abarth@webkit.org>
 721
 722         Reviewed by Eric Seidel.
 723
 724         Implement a build-queue
 725         https://bugs.webkit.org/show_bug.cgi?id=31725
 726
 727         Currently this just builds the first 10 patches in the review queue.
 728         We'll want to do something smarter soon.
 729
 730         * Scripts/bugzilla-tool:
 731
 732 2009-11-20  Adam Barth  <abarth@webkit.org>
 733
 734         Reviewed by Eric Seidel.
 735
 736         Make commit-queue and style-queue show up in help
 737         https://bugs.webkit.org/show_bug.cgi?id=31724
 738
 739         We need to store their names on their class to make these commands
 740         properly register themselves with MultiCommandTool.
 741
 742         * Scripts/bugzilla-tool:
 743
 744 2009-11-20  Adam Barth  <abarth@webkit.org>
 745
 746         Reviewed by Eric Seidel.
 747
 748         Implement bugzilla-tool build-attachment
 749         https://bugs.webkit.org/show_bug.cgi?id=31722
 750
 751         This command builds an attachment from bugzilla.  It leaves the built
 752         patch in the working copy.
 753
 754         * Scripts/bugzilla-tool:
 755         * Scripts/modules/landingsequence.py:
 756         * Scripts/modules/webkitlandingscripts.py:
 757
 758 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
 759
 760         Reviewed by Xan Lopez.
 761
 762         [GTK] DRT release event does not create the state correctly
 763         https://bugs.webkit.org/show_bug.cgi?id=31717
 764
 765         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
 766
 767 2009-11-20  Eric Seidel  <eric@webkit.org>
 768
 769         Reviewed by Adam Barth.
 770
 771         MultiCommandTool should find Command objects automatically instead of with a manual list
 772         https://bugs.webkit.org/show_bug.cgi?id=31710
 773
 774         * Scripts/bugzilla-tool:
 775         * Scripts/modules/multicommandtool.py:
 776          - Use some wild python-fu to crawl all the known subclasses of Command.
 777
 778 2009-11-20  Adam Barth  <abarth@webkit.org>
 779
 780         Unreviewed "build" fix.  Added missing import.
 781
 782         * Scripts/bugzilla-tool:
 783
 784 2009-11-20  Adam Barth  <abarth@webkit.org>
 785
 786         Unreviewed "build" fix.  I failed to update LandingSequence.test
 787         properly.
 788
 789         * Scripts/modules/landingsequence.py:
 790
 791 2009-11-20  Adam Barth  <abarth@webkit.org>
 792
 793         Reviewed by Eric Seidel.
 794
 795         Create LandingSequence as the all-sing, all-dance landing class
 796         https://bugs.webkit.org/show_bug.cgi?id=31709
 797
 798         Client can inherit from this class to carefully control exactly which
 799         steps they wish to have happen in the landing sequence.
 800
 801         * Scripts/bugzilla-tool:
 802         * Scripts/modules/landingsequence.py: Added.
 803         * Scripts/modules/webkitlandingscripts.py: Added.
 804
 805 2009-11-19  Adam Barth  <abarth@webkit.org>
 806
 807         Reviewed by Eric Seidel.
 808
 809         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
 810         https://bugs.webkit.org/show_bug.cgi?id=31707
 811
 812         This is to help when we implement build-attachment.
 813
 814         * Scripts/bugzilla-tool:
 815
 816 2009-11-19  Adam Barth  <abarth@webkit.org>
 817
 818         Reviewed by Eric Seidel.
 819
 820         Support Qt port in bugzilla-tool
 821         https://bugs.webkit.org/show_bug.cgi?id=31701
 822
 823         Now we support building with Qt!
 824
 825         * Scripts/bugzilla-tool:
 826         * Scripts/modules/webkitport.py: Added.
 827         * Scripts/modules/webkitport_unittest.py: Added.
 828         * Scripts/run-webkit-unittests:
 829
 830 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
 831
 832         Reviewed by Adam Barth.
 833
 834         Remove inserting stderr into patch in bugzilla-tool
 835         https://bugs.webkit.org/show_bug.cgi?id=29914
 836
 837         Modify SCM python module's run_command function to avoid return of stderr
 838         by default, so stderr won't be inserted into the patches.
 839         Modify the related unit test.
 840
 841         * Scripts/modules/scm.py:
 842         * Scripts/modules/scm_unittest.py:
 843
 844 2009-11-19  Eric Seidel  <eric@webkit.org>
 845
 846         Reviewed by Adam Barth.
 847
 848         bugzilla-tool needs per-command help
 849         https://bugs.webkit.org/show_bug.cgi?id=31697
 850
 851         Added support for "bugzilla-tool help command-name"
 852         and a unit test to make sure it works.
 853
 854         * Scripts/modules/multicommandtool.py:
 855         * Scripts/modules/multicommandtool_unittest.py:
 856
 857 2009-11-19  Eric Seidel  <eric@webkit.org>
 858
 859         Reviewed by Adam Barth.
 860
 861         Move MultiCommandTool and Command into a separate file and add some basic unit tests
 862         https://bugs.webkit.org/show_bug.cgi?id=31695
 863
 864         * Scripts/bugzilla-tool:
 865         * Scripts/modules/multicommandtool.py: Added.
 866         * Scripts/modules/multicommandtool_unittest.py: Added.
 867         * Scripts/run-webkit-unittests:
 868
 869 2009-11-19  Eric Seidel  <eric@webkit.org>
 870
 871         No review, just adding a FIXME.
 872
 873         Split out command parsing and help printing from BugzillaTool
 874         https://bugs.webkit.org/show_bug.cgi?id=31688
 875
 876         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
 877
 878 2009-11-19  Eric Seidel  <eric@webkit.org>
 879
 880         Reviewed by Adam Barth.
 881
 882         Split out command parsing and help printing from BugzillaTool
 883         https://bugs.webkit.org/show_bug.cgi?id=31688
 884
 885         * Scripts/bugzilla-tool:
 886          - Add new MultiCommandTool class to contain option parsing and help printing logic.
 887          - Rename private methods to use _ pattern.
 888          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
 889          -
 890
 891 2009-11-19  Eric Seidel  <eric@webkit.org>
 892
 893         Reviewed by Adam Barth.
 894
 895         Re-factor help printing to use modern python idioms
 896         https://bugs.webkit.org/show_bug.cgi?id=31685
 897
 898         * Scripts/bugzilla-tool:
 899
 900 2009-11-19  Eric Seidel  <eric@webkit.org>
 901
 902         Reviewed by Darin Adler.
 903
 904         commit-queue empty queue logs twice
 905         https://bugs.webkit.org/show_bug.cgi?id=31679
 906
 907         * Scripts/bugzilla-tool:
 908
 909 2009-11-19  Eric Seidel  <eric@webkit.org>
 910
 911         Reviewed by Darin Adler.
 912
 913         bugzilla-tool's reviewer/committer rejection message should be clearer
 914         https://bugs.webkit.org/show_bug.cgi?id=31126
 915
 916         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
 917
 918         * Scripts/modules/bugzilla.py:
 919
 920 2009-11-19  Eric Z. Ayers  <zundel@google.com>
 921
 922         Reviewed by Pavel Feldman.
 923
 924         Forces a WM_PAINT event on calling layoutTestController.display()
 925         in order to enable the timeline-paint.html test on Windows.
 926         ::UpdateWindow() does not force an event becaue the window is
 927         not visible.
 928
 929         https://bugs.webkit.org/show_bug.cgi?id=31402
 930
 931         * DumpRenderTree/win/DumpRenderTree.cpp:
 932         (displayWebView):
 933
 934 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
 935
 936         No review needed.
 937
 938         Added myself to committers list.
 939
 940         * Scripts/modules/committers.py:
 941
 942 2009-11-19  Adam Barth  <abarth@webkit.org>
 943
 944         Reviewed by Eric Seidel.
 945
 946         Bugzilla-tool command classes should match command names
 947         https://bugs.webkit.org/show_bug.cgi?id=31666
 948
 949         I renamed all the commands except CommitMessageForCurrentDiff because
 950         the new name would conflict with an existing class.
 951
 952         * Scripts/bugzilla-tool:
 953
 954 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
 955
 956         Reviewed by Gustavo Noronha Silva.
 957
 958         Web Inspector: Implement "show inspector" in WebKit GTK
 959         API and enable console tests.
 960
 961         https://bugs.webkit.org/show_bug.cgi?id=31669
 962
 963         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 964         (LayoutTestController::showWebInspector):
 965
 966 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 967
 968         Reviewed by Simon Hausmann.
 969
 970         Minor refactoring + more documentation.
 971
 972         * DumpRenderTree/qt/DumpRenderTree.cpp:
 973         (WebCore::clearHistory):
 974         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 975
 976 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
 977
 978         Reviewed by Eric Seidel.
 979
 980         Ignore websocket tests when --no-http is specified.
 981         https://bugs.webkit.org/show_bug.cgi?id=31662
 982
 983         * Scripts/run-webkit-tests:
 984
 985 2009-11-18  Adam Barth  <abarth@webkit.org>
 986
 987         Reviewed by Eric Seidel.
 988
 989         Normalize ' and " in bugzilla-tool
 990         https://bugs.webkit.org/show_bug.cgi?id=31655
 991
 992         We decided " is better than ' and we should be consistent.
 993
 994         * Scripts/bugzilla-tool:
 995
 996 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 997
 998         Reviewed by Kenneth Rohde Christiansen.
 999
1000         [Qt] Remove support for Qt v4.3 or older versions
1001         https://bugs.webkit.org/show_bug.cgi?id=29469
1002
1003         * DumpRenderTree/qt/DumpRenderTree.pro:
1004         * DumpRenderTree/qt/ImageDiff.pro:
1005
1006 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1007
1008         Reviewed by Eric Seidel.
1009
1010         GitTest.test_create_binary_patch fails if /tmp is symlink
1011         https://bugs.webkit.org/show_bug.cgi?id=31536
1012
1013         * Scripts/modules/scm_unittest.py:
1014
1015 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1016
1017         Reviewed by Darin Adler.
1018
1019         Configuration for Chromium Build Slaves.
1020
1021         https://bugs.webkit.org/show_bug.cgi?id=31442
1022
1023         * BuildSlaveSupport/build.webkit.org-config/config.json:
1024         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1025
1026 2009-11-18  Eric Seidel  <eric@webkit.org>
1027
1028         Reviewed by Darin Adler.
1029
1030         workqueue.py results in totally broken commit-queue UI
1031         https://bugs.webkit.org/show_bug.cgi?id=31645
1032
1033         * Scripts/bugzilla-tool:
1034          - Remove unneeded use of PatchCollection.
1035          - Grab a new copy of the cq'd patches every run of the queue.
1036
1037 2009-11-18  Sam Weinig  <sam@webkit.org>
1038
1039         Reviewed by Anders Carlsson.
1040
1041         Make the Mac Geolocation API async.
1042
1043         Update DRT to use the new async Mac Geolocation API.
1044
1045         * DumpRenderTree/mac/UIDelegate.mm:
1046         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1047
1048 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1049
1050         Reviewed by Kenneth Rohde Christiansen.
1051
1052         Add and option to toggle HTML5 datalist support to build-webkit
1053         https://bugs.webkit.org/show_bug.cgi?id=31599
1054
1055         * Scripts/build-webkit:
1056
1057 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1058
1059         Reviewed by Kevin Ollivier.
1060
1061         Enable wx plugin support using the Windows implementation as a base.
1062
1063         https://bugs.webkit.org/show_bug.cgi?id=31636
1064
1065         * wx/build/settings.py:
1066
1067 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1068
1069         Reviewed by Simon Hausmann.
1070
1071         Change the initialization order so that the controllers
1072         will be created before exporting them to the JS DOM window.
1073
1074         * DumpRenderTree/qt/DumpRenderTree.cpp:
1075         (WebCore::DumpRenderTree::DumpRenderTree):
1076
1077 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1078
1079         Reviewed by Simon Hausmann.
1080
1081         Fix a code copy and paste error. m_page should be page.
1082
1083         * DumpRenderTree/qt/DumpRenderTree.cpp:
1084         (WebCore::DumpRenderTree::createWindow):
1085
1086 2009-11-17  Mark Rowe  <mrowe@apple.com>
1087
1088         Reviewed by Alexey Proskuryakov.
1089
1090         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1091
1092         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1093         This prevents symlinks from confusing the descendant check.
1094
1095 2009-11-17  Mark Rowe  <mrowe@apple.com>
1096
1097         Reviewed by Alexey Proskuryakov.
1098
1099         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1100
1101         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1102         server to be up rather than having run-webkit-tests abort immediately.
1103
1104         * Scripts/run-webkit-tests:
1105
1106 2009-11-17  Eric Seidel  <eric@webkit.org>
1107
1108         Reviewed by Darin Adler.
1109
1110         commit-queue is failing to set reviewer in ChangeLogs
1111         https://bugs.webkit.org/show_bug.cgi?id=31592
1112
1113         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1114         * Scripts/modules/bugzilla.py:
1115          - Add a new _validate_committer_and_reviewer function as a
1116            temporary solution until we can make a real Attachment object
1117            which knows how to fill in its committer/reviewer fields automatically.
1118
1119 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1120
1121         Unreviewed buildbot fix.
1122
1123         Revert part of earlier patch and add comment, as it
1124         was causing timeouts on the buildbot.
1125
1126         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1127         (LayoutTestController::notifyDone):
1128
1129 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1130
1131         Reviewed by Oliver Hunt.
1132
1133         Make the timeout 15 sec as for the other DRT's and make
1134         it print out the same output when a test timeout.
1135
1136         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1137         (LayoutTestController::waitUntilDone):
1138         (LayoutTestController::notifyDone):
1139         (LayoutTestController::timerEvent):
1140
1141 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1142
1143         Reviewed by Timothy Hatcher.
1144
1145         Fixed typos in comments.
1146
1147         * Scripts/modules/committers.py:
1148
1149 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1150
1151         Reviewed by Timothy Hatcher.
1152
1153         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1154         - Updated DRT to show/close inspector for all tests under /inspector
1155         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1156           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1157         - Removed reload on each inspector test
1158         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1159         inspector for those.
1160         - Reimplemented timeline tests in order to get rid of reload there.
1161         - Moved tests that don't require harness into the fast group.
1162
1163         https://bugs.webkit.org/show_bug.cgi?id=31472
1164
1165         * DumpRenderTree/LayoutTestController.cpp:
1166         (setTimelineProfilingEnabledCallback):
1167         (closeWebInspectorCallback):
1168         (LayoutTestController::staticFunctions):
1169         * DumpRenderTree/LayoutTestController.h:
1170         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1171         (shouldOpenWebInspector):
1172         (runTest):
1173         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1174         (LayoutTestController::setTimelineProfilingEnabled):
1175         * DumpRenderTree/mac/DumpRenderTree.mm:
1176         (shouldOpenWebInspector):
1177         (runTest):
1178         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1179         (LayoutTestController::setTimelineProfilingEnabled):
1180         * DumpRenderTree/win/DumpRenderTree.cpp:
1181         (shouldOpenWebInspector):
1182         (runTest):
1183         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1184         (LayoutTestController::setTimelineProfilingEnabled):
1185
1186 2009-11-17  Oliver Hunt  <oliver@apple.com>
1187
1188         Reviewed by Maciej Stachowiak.
1189
1190         Incorrect use of JavaScriptCore API in DumpRenderTree
1191         https://bugs.webkit.org/show_bug.cgi?id=31577
1192
1193         Return undefined rather than a literal null.
1194
1195         * DumpRenderTree/AccessibilityUIElement.cpp:
1196         (setSelectedTextRangeCallback):
1197         (incrementCallback):
1198         (decrementCallback):
1199         (showMenuCallback):
1200
1201 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1202
1203         Reviewed by Beth Dakin.
1204
1205         AX: aria-labelledby duplicates some of its WAI-ARIA label
1206         https://bugs.webkit.org/show_bug.cgi?id=31565
1207
1208         * DumpRenderTree/AccessibilityUIElement.cpp:
1209         (titleUIElementCallback):
1210         (getIsValidCallback):
1211         (AccessibilityUIElement::getJSClass):
1212
1213 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1214
1215         Reviewed by Simon Hausmann.
1216
1217         r50942 broke output from created windows. Make the
1218         m_enableTextOutput a member of the DRT and not the
1219         WebPage.
1220
1221         * DumpRenderTree/qt/DumpRenderTree.cpp:
1222         (WebCore::WebPage::WebPage):
1223         (WebCore::WebPage::javaScriptAlert):
1224         (WebCore::WebPage::javaScriptConsoleMessage):
1225         (WebCore::WebPage::javaScriptConfirm):
1226         (WebCore::WebPage::javaScriptPrompt):
1227         (WebCore::WebPage::acceptNavigationRequest):
1228         (WebCore::DumpRenderTree::DumpRenderTree):
1229         (WebCore::DumpRenderTree::open):
1230         (WebCore::DumpRenderTree::createWindow):
1231         * DumpRenderTree/qt/DumpRenderTree.h:
1232         (WebCore::DumpRenderTree::setTextOutputEnabled):
1233         (WebCore::DumpRenderTree::isTextOutputEnabled):
1234         (WebCore::WebPage::shouldInterruptJavaScript):
1235         (WebCore::WebPage::isTextOutputEnabled):
1236         (WebCore::WebPage::setViewGeometry):
1237
1238 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1239
1240         Reviewed by Gustavo Noronha Silva.
1241
1242         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1243         as the implementation is being used by at least Qt and Gtk+.
1244
1245         Update buildsystems as well.
1246
1247         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1248         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1249         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1250         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1251         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1252         * GNUmakefile.am:
1253
1254 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1255
1256         Reviewed by Alexey Proskuryakov.
1257
1258         Disable wss until all platforms support pyOpenSSL
1259
1260         https://bugs.webkit.org/show_bug.cgi?id=31479
1261
1262         * Scripts/run-webkit-tests:
1263
1264 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1265
1266         Reviewed by Kenneth Christiansen.
1267
1268         [Qt] Implement load error pages support for Qt's DRT.
1269         https://bugs.webkit.org/show_bug.cgi?id=31509
1270
1271         For now, it will not be a default feature, and layout tests
1272         that want to make use of this have to explicitily call
1273         'handleErrorPages();' for the test source.
1274
1275         Any of the other DumpRenderTree's (mac, win and gtk)
1276         support handling error pages. Qt's will be the first.
1277
1278         * DumpRenderTree/qt/DumpRenderTree.cpp:
1279         (WebCore::WebPage::supportsExtension):
1280         (WebCore::WebPage::extension):
1281         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1282         (LayoutTestController::reset):
1283         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1284         (LayoutTestController::shouldHandleErrorPages):
1285         (LayoutTestController::handleErrorPages):
1286
1287 2009-11-16  Eric Seidel  <eric@webkit.org>
1288
1289         Reviewed by Adam Barth.
1290
1291         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1292         https://bugs.webkit.org/show_bug.cgi?id=31549
1293
1294         Renamed --commit-queue to --non-interactive in most places
1295         and remove the code in land-patches which is no longer needed.
1296
1297         * Scripts/bugzilla-tool:
1298
1299 2009-11-16  Eric Seidel  <eric@webkit.org>
1300
1301         Reviewed by Adam Barth.
1302
1303         The commit-queue should use land-attachment
1304         https://bugs.webkit.org/show_bug.cgi?id=31548
1305
1306         * Scripts/bugzilla-tool:
1307
1308 2009-11-16  Adam Barth  <abarth@webkit.org>
1309
1310         Reviewed by Eric Seidel.
1311
1312         Convert CommitQueue over to PatchCollection
1313         https://bugs.webkit.org/show_bug.cgi?id=31547
1314
1315         Also fixes a bug in workqueue and adds a test!
1316
1317         * Scripts/bugzilla-tool:
1318         * Scripts/modules/workqueue.py:
1319         * Scripts/modules/workqueue_unittest.py:
1320
1321 2009-11-16  Adam Barth  <abarth@webkit.org>
1322
1323         Reviewed by Eric Seidel.
1324
1325         Move StyleQueue over to using PatchCollection
1326         https://bugs.webkit.org/show_bug.cgi?id=31544
1327
1328         That's what the class it's for.
1329
1330         * Scripts/bugzilla-tool:
1331         * Scripts/modules/patchcollection.py:
1332         * Scripts/modules/patchcollection_unittest.py:
1333
1334 2009-11-16  Eric Seidel  <eric@webkit.org>
1335
1336         Reviewed by Adam Barth.
1337
1338         bugzilla-tool needs a land-attachment command
1339         https://bugs.webkit.org/show_bug.cgi?id=31546
1340
1341         * Scripts/bugzilla-tool:
1342          - Move all the logic into AbstractLandingCommand and
1343            add a new LandAttachment command subclass.
1344          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1345
1346 2009-11-16  Eric Seidel  <eric@webkit.org>
1347
1348         Reviewed by Adam Barth.
1349
1350         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1351         https://bugs.webkit.org/show_bug.cgi?id=31543
1352
1353         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1354
1355         * Scripts/bugzilla-tool:
1356
1357 2009-11-16  Eric Seidel  <eric@webkit.org>
1358
1359         Reviewed by Adam Barth.
1360
1361         Disable the style queue from posting to the commit queue status page.
1362
1363         * Scripts/bugzilla-tool:
1364
1365 2009-11-16  Adam Barth  <abarth@webkit.org>
1366
1367         Reviewed by Eric Seidel.
1368
1369         Implement PatchCollection
1370         https://bugs.webkit.org/show_bug.cgi?id=31541
1371
1372         This class holds a set of patches and lets clients iterate through
1373         them.  Optionally, clients can install a filter.
1374
1375         * Scripts/modules/patchcollection.py: Added.
1376         * Scripts/modules/patchcollection_unittest.py: Added.
1377         * Scripts/run-webkit-unittests:
1378
1379 2009-11-16  Eric Seidel  <eric@webkit.org>
1380
1381         Reviewed by Adam Barth.
1382
1383         bugzilla-tool land-patches will close bugs with patches r=?
1384         https://bugs.webkit.org/show_bug.cgi?id=28230
1385
1386         The commit-queue shouldn't close patches with outstanding reviews on them,
1387         even if many reviewers seem to be against multi-patch bugs.
1388
1389         * Scripts/bugzilla-tool:
1390
1391 2009-11-16  Eric Seidel  <eric@webkit.org>
1392
1393         Reviewed by Adam Barth.
1394
1395         bugzilla-tool check-style should work with attachment ids instead of bug ids
1396         https://bugs.webkit.org/show_bug.cgi?id=31540
1397
1398         * Scripts/bugzilla-tool:
1399
1400 2009-11-16  Eric Seidel  <eric@webkit.org>
1401
1402         Reviewed by Adam Barth.
1403
1404         WorkQueue is the only place that should know about special exit codes
1405         https://bugs.webkit.org/show_bug.cgi?id=31534
1406
1407         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1408         and add tests for handling exit codes.
1409         I also cleaned up workqueue_unittest.py more.
1410
1411         * Scripts/bugzilla-tool:
1412         * Scripts/modules/workqueue.py:
1413         * Scripts/modules/workqueue_unittest.py:
1414
1415 2009-11-16  Eric Seidel  <eric@webkit.org>
1416
1417         Reviewed by Adam Barth.
1418
1419         Re-factor workqueue_unittest to allow for more than one test.
1420         https://bugs.webkit.org/show_bug.cgi?id=31535
1421
1422         * Scripts/modules/workqueue_unittest.py:
1423
1424 2009-11-16  Eric Seidel  <eric@webkit.org>
1425
1426         Reviewed by Adam Barth.
1427
1428         land-patches needs to be re-factored into smaller chunks
1429         https://bugs.webkit.org/show_bug.cgi?id=31532
1430
1431         * Scripts/bugzilla-tool: fix a couple obvious typos.
1432
1433 2009-11-16  Eric Seidel  <eric@webkit.org>
1434
1435         Reviewed by Adam Barth.
1436
1437         land-patches needs to be re-factored into smaller chunks
1438         https://bugs.webkit.org/show_bug.cgi?id=31532
1439
1440         The next patch will move these methods into WebKitLandingScripts.
1441
1442         * Scripts/bugzilla-tool:
1443          - Split out _land_patch and _close_bug_if_no_active_patches.
1444
1445 2009-11-16  Adam Barth  <abarth@webkit.org>
1446
1447         Reviewed by Eric Seidel.
1448
1449         Fix silly copy-and-paste code.  I am a terrible coder.
1450
1451         * Scripts/modules/bugzilla.py:
1452
1453 2009-11-16  Adam Barth  <abarth@webkit.org>
1454
1455         Reviewed by Eric Seidel.
1456
1457         Implement a StyleQueue
1458         https://bugs.webkit.org/show_bug.cgi?id=31537
1459
1460         The first iteration of the style queue only produces output locally.
1461         There is also a limit of 10 patches because it's not that useful to
1462         iterate through the entire review queue at this point.  We can remove
1463         the limit later.
1464
1465         * Scripts/bugzilla-tool:
1466         * Scripts/modules/bugzilla.py:
1467
1468 2009-11-16  Adam Barth  <abarth@webkit.org>
1469
1470         Reviewed by Eric Seidel.
1471
1472         Unit test WorkQueue
1473         https://bugs.webkit.org/show_bug.cgi?id=31531
1474
1475         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1476
1477         * Scripts/bugzilla-tool:
1478         * Scripts/modules/statusbot.py:
1479         * Scripts/modules/workqueue.py:
1480         * Scripts/modules/workqueue_unittest.py: Added.
1481         * Scripts/run-webkit-unittests:
1482
1483 2009-11-16  Eric Seidel  <eric@webkit.org>
1484
1485         Reviewed by Adam Barth.
1486
1487         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1488         https://bugs.webkit.org/show_bug.cgi?id=31530
1489
1490         * Scripts/bugzilla-tool:
1491
1492 2009-11-16  Eric Seidel  <eric@webkit.org>
1493
1494         Reviewed by Adam Barth.
1495
1496         bugzilla-tool needs apply-attachment
1497         https://bugs.webkit.org/show_bug.cgi?id=31528
1498
1499         * Scripts/bugzilla-tool:
1500          - Add ApplyAttachment command.
1501          - Abstract applying code into WebKitApplyingScripts.
1502          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1503         * Scripts/modules/bugzilla.py:
1504          - Add fetch_attachment and bug_id_for_attachment_id.
1505         * Scripts/modules/bugzilla_unittest.py:
1506          - Add test for new parsing.
1507          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1508
1509 2009-11-16  Eric Seidel  <eric@webkit.org>
1510
1511         Reviewed by Adam Barth.
1512
1513         Document check-style's use of force_clean.
1514
1515         * Scripts/bugzilla-tool:
1516         * Scripts/modules/scm.py:
1517
1518 2009-11-16  Adam Barth  <abarth@webkit.org>
1519
1520         Reviewed by Eric Seidel.
1521
1522         Move WorkQueue to its own file
1523         https://bugs.webkit.org/show_bug.cgi?id=31529
1524
1525         WorkQueue and WorkQueueDelegate are separate concerns from
1526         bugzilla-tool.  Also added a missing include to logging.py.
1527
1528         * Scripts/bugzilla-tool:
1529         * Scripts/modules/logging.py:
1530         * Scripts/modules/workqueue.py:
1531
1532 2009-11-16  Adam Barth  <abarth@webkit.org>
1533
1534         Reviewed by Eric Seidel.
1535
1536         Move OutputTee to logging.py.
1537
1538         * Scripts/bugzilla-tool:
1539         * Scripts/modules/logging.py:
1540
1541 2009-11-15  Adam Barth  <abarth@webkit.org>
1542
1543         Reviewed by Eric Seidel.
1544
1545         Refactor bugzilla-tool to allow for multiple queues
1546         https://bugs.webkit.org/show_bug.cgi?id=31513
1547
1548         Divide the commit queue class into three class to make creating
1549         additional queues easier.
1550
1551         * Scripts/bugzilla-tool:
1552
1553 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1554
1555         Reviewed by Eric Seidel.
1556
1557         svn-apply may not handle git patches created by bugzilla-tool
1558         https://bugs.webkit.org/show_bug.cgi?id=31457
1559
1560         * Scripts/modules/scm.py:
1561         * Scripts/modules/scm_unittest.py:
1562
1563 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1564
1565         Reviewed by Eric Seidel.
1566
1567         bugzilla-tool should post git binary diff
1568         https://bugs.webkit.org/show_bug.cgi?id=31458
1569
1570         Add --binary option to Git.create_patch.
1571
1572         * Scripts/modules/scm.py:
1573         * Scripts/modules/scm_unittest.py:
1574
1575 2009-11-15  Adam Barth  <abarth@webkit.org>
1576
1577         Reviewed by Darin Adler.
1578
1579         Add bugzilla-tool check-style
1580         https://bugs.webkit.org/show_bug.cgi?id=31515
1581
1582         * Scripts/bugzilla-tool:
1583         * Scripts/modules/bugzilla.py:
1584
1585 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1586
1587         Reviewed by Simon Hausmann.
1588
1589         Make the Qt Linux only --valgrind feature, suppress errors
1590         defined in the SuppressedValgrindErrors file.
1591
1592         * Scripts/run-webkit-tests:
1593
1594 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1595
1596         Reviewed by Simon Hausmann.
1597
1598         Set the locale to C and not to the current one in use on the system.
1599
1600         * DumpRenderTree/qt/DumpRenderTree.cpp:
1601         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1602
1603 2009-11-13  Adam Roben  <aroben@apple.com>
1604
1605         Add support for
1606         http/tests/security/isolatedWorld/didClearWindowObject.html
1607
1608         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1609         window objects in isolated worlds are cleared
1610
1611         Reviewed by Dave Hyatt.
1612
1613         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1614
1615         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1616         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1617         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1618         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1619         Added. Sets a __worldID property on the global object whose value is
1620         the ID of this world.
1621         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1622         Respond to this new delegate callback by calling through to one of the
1623         above new methods.
1624         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1625         (worldMap): Added. Returns a HashMap containing all the worlds we've
1626         created.
1627         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1628         haven't kept track of this world.
1629         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1630         instead of declaring our own.
1631
1632         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1633
1634         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1635         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1636         didClearWindowObjectForFrameInStandardWorld.
1637         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1638         Respond to this new delegate callback by calling through to one of the
1639         below new methods.
1640         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1641         Added. Sets a __worldID property on the gobal object whose value is
1642         the ID of this world.
1643         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1644         Added. Moved code here from didClearWindowObject.
1645
1646         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1647         didClearWindowObjectForFrame* functions.
1648
1649         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1650         (worldMap): Added. Returns a HashMap containing all the worlds we've
1651         created.
1652         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1653         haven't kept track of this world.
1654         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1655         instead of declaring our own.
1656
1657 2009-11-13  Adam Roben  <aroben@apple.com>
1658
1659         Finish replacing worldIDs with world objects
1660
1661         The only remaining use of worldIDs was in a method only used by DRT
1662         for the isolated worlds tests.
1663
1664         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1665
1666         Reviewed by Mark Rowe.
1667
1668         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1669         (LayoutTestController::evaluateScriptInIsolatedWorld):
1670         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1671         (LayoutTestController::evaluateScriptInIsolatedWorld):
1672         Updated for changes to WebFrame. Now holds the map of worldID -> world
1673         at this level instead of making WebKit do it.
1674
1675 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1676
1677         Reviewed by Simon Hausmann.
1678
1679         [Qt] Ensure the DRT does not output anything until first test is run
1680
1681         * DumpRenderTree/qt/DumpRenderTree.cpp:
1682         * DumpRenderTree/qt/DumpRenderTree.h:
1683
1684 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1685
1686         Reviewed by Tor Arne Vestbø.
1687
1688         Clear the undo stack in before each new test run.
1689
1690         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1691
1692         * DumpRenderTree/qt/DumpRenderTree.cpp:
1693         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1694
1695 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1696
1697         Reviewed by Kenneth Rohde Christiansen.
1698
1699         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1700
1701         * DumpRenderTree/qt/DumpRenderTree.cpp:
1702         (WebCore::WebPage::resetSettings):
1703         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1704         (LayoutTestController::overridePreference):
1705
1706 2009-11-13  Eric Seidel  <eric@webkit.org>
1707
1708         Reviewed by Adam Barth.
1709
1710         Update committers.py based on svn records
1711         https://bugs.webkit.org/show_bug.cgi?id=31366
1712
1713         This list was generated using validate-committer-lists from
1714         https://bugs.webkit.org/show_bug.cgi?id=30970
1715         and makes committers.py current for committers who have
1716         committed in the last 3 years.
1717
1718         * Scripts/modules/committers.py:
1719
1720 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1721
1722         Reviewed by Adam Barth.
1723
1724         The document-open.html test was flaky at times. The test invokes the layout test plugin
1725         which in its destroy stream handler opens a new document. This basically tears down the
1726         stream and the associated plugin instance. The pluginLog function in the layout test
1727         plugin attempts to retrieve the window script object on a torn down plugin instance
1728         which crashed consistently on windows in the debugger. The functions which issue
1729         these logs already have a valid window script object. We now have variants of the pluginLog
1730         function which take in a window script object with and without variable arguments.
1731
1732         https://bugs.webkit.org/show_bug.cgi?id=31067
1733
1734         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1735         (pluginLogWithWindowObject):
1736         (pluginLogWithWindowObjectVariableArgs):
1737         (pluginLog):
1738         (notifyTestCompletion):
1739         (testDocumentOpen):
1740         (testWindowOpen):
1741
1742 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1743
1744         Reviewed by Gustavo Noronha Silva.
1745
1746         https://bugs.webkit.org/show_bug.cgi?id=30997
1747         [Gtk] Implemment AtkDocument
1748
1749         Added testing support.
1750
1751         * DumpRenderTree/AccessibilityUIElement.cpp:
1752         * DumpRenderTree/AccessibilityUIElement.h:
1753         (getDocumentEncodingCallback):
1754         (getDocumentURICallback):
1755         (AccessibilityUIElement::getJSClass):
1756         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1757         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1758         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1759         (AccessibilityUIElement::documentEncoding):
1760         (AccessibilityUIElement::documentURI):
1761
1762 2009-11-12  Adam Roben  <aroben@apple.com>
1763
1764         Replace worldIDs with world objects
1765
1766         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1767         user scripts/stylesheets and isolated worlds
1768
1769         Reviewed by Sam Weinig.
1770
1771         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1772         (LayoutTestController::addUserScript):
1773         (LayoutTestController::addUserStyleSheet):
1774         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1775         (LayoutTestController::addUserScript):
1776         (LayoutTestController::addUserStyleSheet):
1777         Changed these functions to create a new WebJSWorld each time they're
1778         called and to pass that world to WebKit.
1779
1780 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1781
1782         Reviewed by Oliver Hunt.
1783
1784         need to implement aria tree roles
1785         https://bugs.webkit.org/show_bug.cgi?id=31284
1786
1787         * DumpRenderTree/AccessibilityUIElement.cpp:
1788         (disclosedRowAtIndexCallback):
1789         (selectedRowAtIndexCallback):
1790         (isEqualCallback):
1791         (isAttributeSettableCallback):
1792         (isActionSupportedCallback):
1793         (disclosedByRowCallback):
1794         (hierarchicalLevelCallback):
1795         (AccessibilityUIElement::getJSClass):
1796         * DumpRenderTree/AccessibilityUIElement.h:
1797         (AccessibilityUIElement::isEqual):
1798         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1799         (AccessibilityUIElement::hierarchicalLevel):
1800         (AccessibilityUIElement::disclosedRowAtIndex):
1801         (AccessibilityUIElement::selectedRowAtIndex):
1802         (AccessibilityUIElement::disclosedByRow):
1803         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1804         (AccessibilityUIElement::getChildAtIndex):
1805         (AccessibilityUIElement::disclosedRowAtIndex):
1806         (AccessibilityUIElement::selectedRowAtIndex):
1807         (AccessibilityUIElement::titleUIElement):
1808         (AccessibilityUIElement::parentElement):
1809         (AccessibilityUIElement::disclosedByRow):
1810         (AccessibilityUIElement::hierarchicalLevel):
1811         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1812         (AccessibilityUIElement::hierarchicalLevel):
1813         (AccessibilityUIElement::disclosedRowAtIndex):
1814         (AccessibilityUIElement::selectedRowAtIndex):
1815         (AccessibilityUIElement::disclosedByRow):
1816
1817 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1818
1819         Reviewed by Darin Adler.
1820
1821         svn-apply can not handle git binary diffs
1822         https://bugs.webkit.org/show_bug.cgi?id=26830
1823
1824         Support "literal" type git binary diffs.
1825
1826         * Scripts/VCSUtils.pm:
1827         * Scripts/modules/scm_unittest.py:
1828         * Scripts/svn-apply:
1829
1830 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1831
1832         Not reviewed, removing duplicate entry for myself in committers.py.
1833
1834         * Scripts/modules/committers.py:
1835
1836 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1837
1838         Reviewed by Darin Adler and Mark Rowe.
1839
1840         https://bugs.webkit.org/show_bug.cgi?id=31200
1841         Tests in http/tests/security/mixedContent start to fail when new tests are added
1842
1843         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1844
1845 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1846
1847         Reviewed by Jan Alonzo.
1848
1849         Create, and display a window for the inspector, for inspector
1850         tests.
1851
1852         Need to also show/hide the inspector window to avoid having
1853         problems with code assuming it is realized
1854         https://bugs.webkit.org/show_bug.cgi?id=31347
1855
1856         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1857         (webInspectorShowWindow):
1858         (webInspectorCloseWindow):
1859         (webInspectorInspectWebView):
1860         (createWebView):
1861
1862 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1863
1864         Unreviewed Qt buildbot fix.
1865
1866         My previous fix was wrong, so revert that change and fix it by
1867         returning when the document of the frame has no document element.
1868         Idea is borrowed from mac and win DRT.
1869
1870         * DumpRenderTree/qt/DumpRenderTree.cpp:
1871         (WebCore::DumpRenderTree::dumpFramesAsText):
1872
1873 2009-11-11  Eric Seidel  <eric@webkit.org>
1874
1875         Reviewed byg Kenneth Rohde Christiansen.
1876
1877         Update Kenneth's committer record to include the email he
1878         uses on lists.webkit.org.
1879
1880         * Scripts/modules/committers.py:
1881
1882 2009-11-11  Eric Seidel  <eric@webkit.org>
1883
1884         Reviewed by Gustavo Noronha Silva.
1885
1886         Several committers use separate email addresses for bugzilla and svn.webkit.org
1887         https://bugs.webkit.org/show_bug.cgi?id=31364
1888
1889         Update records for existing committers to include email addresses
1890         used in svn.webkit.org and lists.webkit.org.
1891         Most committers use the same email address in all 3 places, but some use
1892         separate addresses.  committers.py needs record of each of these addresses.
1893
1894         * Scripts/modules/committers.py:
1895
1896 2009-11-11  Eric Seidel  <eric@webkit.org>
1897
1898         No review, adding second email address for an existing committer.
1899
1900         Add Yong Li's second bugzilla account to his committer record.
1901         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1902
1903         * Scripts/modules/committers.py:
1904
1905 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1906
1907         Reviewed by Simon Hausmann.
1908
1909         If the frame has no innerText don't append it, and
1910         do not add a newline which breaks some cross platform
1911         results.
1912
1913         * DumpRenderTree/qt/DumpRenderTree.cpp:
1914         (WebCore::DumpRenderTree::dumpFramesAsText):
1915
1916 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1917
1918         Reviewed by Simon Hausmann.
1919
1920         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1921
1922         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1923         (webkit_test_plugin_new_instance):
1924         (webkit_test_plugin_destroy_instance):
1925         (webkit_test_plugin_destroy_stream):
1926
1927 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1928
1929         Reviewed by Mark Rowe.
1930
1931         Implement the functionality needed by plugins/window-open.html
1932
1933         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1934         (webkit_test_plugin_new_instance):
1935         (webkit_test_plugin_set_window):
1936
1937 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1938
1939         Reviewed by Simon Hausmann.
1940
1941         [Qt] Force -graphicssystem raster and -style windows when running DRT
1942
1943         * DumpRenderTree/qt/main.cpp:
1944         * Scripts/run-webkit-tests:
1945
1946 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1947
1948         Reviewed by Simon Hausmann.
1949
1950         Compute correct library paths for Qt
1951
1952         * Scripts/webkitdirs.pm:
1953
1954 2009-11-10  Mark Rowe  <mrowe@apple.com>
1955
1956         Reviewed by Sam Weinig.
1957
1958         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1959
1960         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1961         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1962         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1963         that had enabled frame load delegate logging this would result in extra log messages being generated,
1964         causing the test to fail.
1965
1966         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1967         tests.
1968
1969         * DumpRenderTree/mac/DumpRenderTree.mm:
1970         (dumpRenderTree):
1971         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1972         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1973
1974 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1975
1976         Reviewed by Kenneth Rohde Christiansen.
1977
1978         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1979
1980         * DumpRenderTree/qt/DumpRenderTree.cpp:
1981         (WebCore::DumpRenderTree::DumpRenderTree):
1982
1983 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1984
1985         Reviewed by Jan Alonzo.
1986
1987         [GTK] Remove WebSocket configuration from WebKitWebSettings
1988         https://bugs.webkit.org/show_bug.cgi?id=31244
1989
1990         Follow-up of r50724. Don't set the enable-web-socket property
1991         anymore.
1992
1993         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1994         (resetDefaultsToConsistentValues):
1995
1996 2009-11-10  Oliver Hunt  <oliver@apple.com>
1997
1998         Reviewed by Maciej Stachowiak.
1999
2000         Rename 3D Canvas related classes to use WebGL prefix
2001         https://bugs.webkit.org/show_bug.cgi?id=29095
2002
2003         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2004         and upate webkitdirs script to new method of testing for WebGL.
2005
2006         * Scripts/do-webcore-rename:
2007         * Scripts/webkitdirs.pm:
2008
2009 2009-11-09  Oliver Hunt  <oliver@apple.com>
2010
2011         Reviewed by Geoff Garen.
2012
2013         Make do-webcore-rename work with git.
2014
2015         * Scripts/do-webcore-rename:
2016
2017 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2018
2019         Adding Kenneth to the reviewers list.
2020
2021         * Scripts/modules/committers.py:
2022
2023 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2024
2025         Reviewed by Jan Alonzo.
2026
2027         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2028         https://bugs.webkit.org/show_bug.cgi?id=30482
2029
2030         LayoutTestControllerGtk now uses the exposed
2031         Page::tabKeyCyclesThroughElements API
2032
2033         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2034         (LayoutTestController::setTabKeyCyclesThroughElements):
2035
2036 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2037
2038         Reviewed by Holger Freyther.
2039
2040         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2041         This helps to pass the test case below. Also replaced hardcoded
2042         code numbers with defined constants.
2043         https://bugs.webkit.org/show_bug.cgi?id=31185
2044
2045         Test: editing/undo/undo-deleteWord.html
2046
2047         * DumpRenderTree/qt/EventSenderQt.cpp:
2048         (EventSender::keyDown):
2049
2050 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2051
2052         Reviewed by Holger Freyther.
2053
2054         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2055         https://bugs.webkit.org/show_bug.cgi?id=31164
2056
2057         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2058
2059         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2060         (LayoutTestController::processWork):
2061
2062 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2063
2064         Reviewed by Holger Freyther.
2065
2066         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2067         https://bugs.webkit.org/show_bug.cgi?id=31158
2068
2069         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2070         always, which from WorkQueue prospective means that a load has been started
2071         and the queue processing should stop and wait for the load to finish.
2072         Spinning it off into a loading and a non-loading variants was the solution
2073         adopted by Mac's DRT to work around this problem. The former keeps returning
2074         'true' while the later executes the script synchronously and returns 'false'
2075         making it possible to the WorkQueue to proceed right away.
2076
2077         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2078         (LayoutTestController::processWork):
2079         (LayoutTestController::queueLoadingScript):
2080         (LayoutTestController::queueNonLoadingScript):
2081         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2082         * DumpRenderTree/qt/WorkQueueItem.h:
2083         (LoadingScriptItem::LoadingScriptItem):
2084         (LoadingScriptItem::invoke):
2085         (NonLoadingScriptItem::NonLoadingScriptItem):
2086         (NonLoadingScriptItem::invoke):
2087
2088 2009-11-07  Mark Rowe  <mrowe@apple.com>
2089
2090         Rubber-stamped by Cameron Zwarich.
2091
2092         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2093
2094         * Scripts/commit-log-editor:
2095
2096 2009-11-07  Mark Rowe  <mrowe@apple.com>
2097
2098         Reviewed by Darin Adler.
2099
2100         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2101         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2102
2103         Move logic for determining the name and email address to use in a ChangeLog entry from
2104         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2105         whether the author of the patch matches committer, and therefore needs access to the
2106         email address that would be used in a ChangeLog entry.
2107
2108         Based on a patch by Pierre d'Herbemont.
2109
2110         * Scripts/VCSUtils.pm:
2111         * Scripts/commit-log-editor:
2112         * Scripts/prepare-ChangeLog:
2113         * Scripts/webkitdirs.pm:
2114
2115 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2116
2117         Reviewed by Adam Barth.
2118
2119         Added functionality to the layout test plugin to invoke document.open and
2120         window.open with default arguments. The associated webkit bug is
2121         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2122         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2123         work in Chromium (V8) if there is no calling javascript context. To achieve this
2124         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2125         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2126
2127         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2128         (testDocumentOpen):
2129         (testWindowOpen):
2130         (pluginAllocate):
2131         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2132         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2133         (NPP_New):
2134         (NPP_SetWindow):
2135         (NPP_DestroyStream):
2136         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2137         (NPP_New):
2138         (NPP_SetWindow):
2139         (NPP_NewStream):
2140         (NPP_DestroyStream):
2141
2142 2009-11-06  Eric Seidel  <eric@webkit.org>
2143
2144         Reviewed by Adam Barth.
2145
2146         bugzilla-tool crashed with exception
2147         https://bugs.webkit.org/show_bug.cgi?id=31092
2148
2149         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2150
2151 2009-11-04  Eric Seidel  <eric@webkit.org>
2152
2153         No review, just add a line which got left out of the patch uploaded for commit.
2154
2155         commit-queue is crashing when trying to reject patches after unknown failures
2156         https://bugs.webkit.org/show_bug.cgi?id=31091
2157
2158         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2159
2160 2009-11-04  Adam Roben  <aroben@apple.com>
2161
2162         Remove bogus else clause in bugzilla-tool
2163
2164         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2165         create-bug raises exception after entering bug description
2166
2167         Reviewed by David Kilzer.
2168
2169         * Scripts/bugzilla-tool:
2170         (CreateBug): else clauses are only hit if no exception is raised, so
2171         it makes no sense to try to re-raise the exception in an else clause.
2172         The exception will automatically be re-raised if it doesn't match any
2173         of the except clauses, so we don't have to do anything special here at
2174         all to get the desired behavior.
2175
2176 2009-11-04  Eric Seidel  <eric@webkit.org>
2177
2178         Reviewed by David Kilzer.
2179
2180         svn-apply's fixChangeLogPatch function seems broken
2181         https://bugs.webkit.org/show_bug.cgi?id=30683
2182
2183         Update fixChangeLogPatch to be able to handle patches which
2184         don't start at line 1.
2185         Add unit tests for svn-apply to scm_unittest.py.
2186
2187         * Scripts/VCSUtils.pm:
2188         * Scripts/modules/scm_unittest.py:
2189
2190 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2191
2192         Reviewed by Beth Dakin.
2193
2194         Need to implement ARIA role="combobox"
2195         https://bugs.webkit.org/show_bug.cgi?id=31096
2196
2197         * DumpRenderTree/AccessibilityUIElement.cpp:
2198         (showMenuCallback):
2199         (getIsExpandedCallback):
2200         (AccessibilityUIElement::getJSClass):
2201         * DumpRenderTree/AccessibilityUIElement.h:
2202         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2203         (AccessibilityUIElement::isExpanded):
2204         (AccessibilityUIElement::showMenu):
2205         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2206         (AccessibilityUIElement::isExpanded):
2207         (AccessibilityUIElement::showMenu):
2208         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2209         (AccessibilityUIElement::isSelected):
2210         (AccessibilityUIElement::isExpanded):
2211         (AccessibilityUIElement::showMenu):
2212
2213 2009-11-04  Eric Seidel  <eric@webkit.org>
2214
2215         Reviewed by Adam Barth.
2216
2217         commit-queue is crashing when trying to reject patches after unknown failures
2218         https://bugs.webkit.org/show_bug.cgi?id=31091
2219
2220         * Scripts/bugzilla-tool:
2221          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2222            so we have to find out what the current patch is by asking bugzilla again.
2223          - Discovered that this code was also leaking file descriptors, so fixed that.
2224
2225 2009-11-04  Adam Roben  <aroben@apple.com>
2226
2227         Make run-webkit-tests work for the Debug_Internal Windows
2228         configuration
2229
2230         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2231         suffix.
2232
2233         Fixes <http://webkit.org/b/31123>.
2234
2235         Reviewed by Sam Weinig.
2236
2237         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2238         Debug_Internal, either.
2239
2240 2009-11-04  Eric Seidel  <eric@webkit.org>
2241
2242         Reviewed by Adam Barth.
2243
2244         committers.py needs a way to store non-bugzilla email addresses
2245         https://bugs.webkit.org/show_bug.cgi?id=31037
2246
2247         Make Committer and Reviewer constructors take a single email or a list of emails.
2248         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2249         Expose reviewers(), used by validate-committer-lists on bug 30970.
2250
2251         * Scripts/modules/committers.py:
2252         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2253
2254 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2255
2256         Reviewed by David Levin.
2257
2258         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2259         https://bugs.webkit.org/show_bug.cgi?id=27491
2260
2261         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2262         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2263
2264         Functions to start or stop Web Socket servers are added.
2265
2266         * Scripts/run-webkit-tests:
2267
2268 2009-11-03  Eric Seidel  <eric@webkit.org>
2269
2270         No review, just changing wording of log message.
2271
2272         Change log string to say "failed" instead of "rejected"
2273         when a commit fails due to an out of date checkout.
2274         This makes grepping the commit-queue log for rejected patches easier.
2275
2276         * Scripts/bugzilla-tool:
2277
2278 2009-11-03  Eric Seidel  <eric@webkit.org>
2279
2280         No review, adding commonly known committers missing from the file.
2281
2282         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2283
2284 2009-11-03  Eric Seidel  <eric@webkit.org>
2285
2286         No review, just sort-order cleanup.
2287
2288         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2289
2290 2009-11-03  Stephen White  <senorblanco@chromium.org>
2291
2292         (Unreviewed).
2293
2294         Add myself to committers.py.
2295
2296         * Scripts/modules/committers.py:
2297
2298 2009-11-03  Robin Dunn  <robin@alldunn.com>
2299
2300         Reviewed by Kevin Ollviier.
2301
2302         Add packaging scripts for Debian-based Linux distros.
2303
2304         https://bugs.webkit.org/show_bug.cgi?id=31075
2305
2306         * wx/packaging/build-debian-installer.py: Added.
2307         * wx/packaging/debian: Added.
2308
2309 2009-11-03  Dan Bernstein  <mitz@apple.com>
2310
2311         Reviewed by Anders Carlsson and Beth Dakin.
2312
2313         https://bugs.webkit.org/show_bug.cgi?id=31070
2314
2315         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2316         destroyed, it executes the value of the 'ondestroy' parameter as a
2317         script.
2318
2319         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2320         (pluginAllocate): Initialize onDestroy.
2321         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2322         onDestroy.
2323         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2324         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2325         specified.
2326         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2327
2328 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2329
2330         Reviewed by Xan Lopez.
2331
2332         https://bugs.webkit.org/show_bug.cgi?id=31035
2333         [GTK] some accessibility tests hitting assertion in debug builds
2334
2335         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2336
2337         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2338         (AccessibilityController::rootElement):
2339
2340 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2341
2342         Reviewed by Beth Dakin.
2343
2344         Support ARIA "tab" roles
2345         https://bugs.webkit.org/show_bug.cgi?id=30842
2346
2347         * DumpRenderTree/AccessibilityUIElement.cpp:
2348         * DumpRenderTree/AccessibilityUIElement.h:
2349         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2350         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2351         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2352
2353 2009-11-01  Eric Seidel  <eric@webkit.org>
2354
2355         Reviewed by David Levin.
2356
2357         buildbots should use --exit-after-N-failures
2358         https://bugs.webkit.org/show_bug.cgi?id=30809
2359
2360         Make the bots exit after 20 failures to prevent never-ending
2361         test runs where every test spends a minute crashing.
2362
2363         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2364
2365 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2366
2367         Reviewed by Eric Seidel.
2368
2369         Turn on warnings for QtWebKit for gcc
2370         https://bugs.webkit.org/show_bug.cgi?id=30958
2371
2372         * DumpRenderTree/qt/main.cpp:
2373         (crashHandler): Mark function NO_RETURN
2374
2375 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2376
2377         Adding myself to the committers list.
2378
2379         * Scripts/modules/committers.py:
2380
2381 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2382
2383         Fix an issue that Adam noticed in DRT.
2384
2385         Reviewed by Darin Adler.
2386
2387         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2388         (AccessibilityUIElement::role):
2389         Get the length of the role text, and create a buffer dynamically.
2390
2391 2009-10-30  Eric Seidel  <eric@webkit.org>
2392
2393         No review, rolling out r50105.
2394         http://trac.webkit.org/changeset/50105
2395
2396         This commit was causing:
2397         https://bugs.webkit.org/show_bug.cgi?id=30869
2398         We'll re-implement the feature a different way.
2399
2400         * Scripts/bugzilla-tool:
2401
2402 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2403
2404         Test for MSAA: Accessibility of headings is not correct
2405
2406         https://bugs.webkit.org/show_bug.cgi?id=30937
2407
2408         Reviewed by Adam Roben.
2409
2410         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2411         (AccessibilityUIElement::role):
2412         Allow the role returned to be a BSTR.
2413         (AccessibilityUIElement::description):
2414         Fix a copy/paste error.
2415
2416 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2417
2418         Test for MSAA: Accessibility of links is wrong
2419
2420         https://bugs.webkit.org/show_bug.cgi?id=30928
2421
2422         Reviewed by Darin Adler.
2423
2424         * DumpRenderTree/AccessibilityUIElement.cpp:
2425         (getAccessibilityValueCallback):
2426         Return the accessibility value.
2427         (AccessibilityUIElement::getJSClass):
2428         Added "accessibilityValue" value.
2429
2430         * DumpRenderTree/AccessibilityUIElement.h:
2431
2432         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2433         (AccessibilityUIElement::accessibilityValue):
2434         Stubbed.
2435
2436         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2437         (AccessibilityUIElement::accessibilityValue):
2438         Stubbed.
2439
2440         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2441         (AccessibilityUIElement::accessibilityValue):
2442         Get the object's value, and return it as a JS string.
2443
2444 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2445
2446         Fix typo in command name used by wx build system.
2447
2448         * wx/build/build_utils.py:
2449
2450 2009-10-30  Adam Barth  <abarth@webkit.org>
2451
2452         Reviewed by Darin Adler.
2453
2454         Patch v1 is a dumb default name for patches
2455         https://bugs.webkit.org/show_bug.cgi?id=30952
2456
2457         Let's use "Patch" instead.
2458
2459         * Scripts/bugzilla-tool:
2460
2461 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2462
2463         Unreviewed trivial buildfix.
2464
2465         [Qt] Buildfix for r50333.
2466
2467         * DumpRenderTree/qt/DumpRenderTree.pro:
2468
2469 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2470
2471         Reviewed by Holger Freyther.
2472
2473         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2474         https://bugs.webkit.org/show_bug.cgi?id=30953
2475
2476         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2477         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2478         makes qt DRT to share this implementation (as gtk and mac ports do).
2479
2480         * DumpRenderTree/qt/DumpRenderTree.pro:
2481         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2482         * DumpRenderTree/qt/WorkQueue.h: Removed.
2483
2484 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2485
2486         Unreviewed potential buildbot fix.
2487
2488         Second try: Reset page history before running each test.
2489
2490         Apparently the QWebHistory::clear() keeps the current page
2491         in history which is not what we want, so we not additionally
2492         sets the history capacity to 0 (forces removing everything)
2493         and then sets it back to its original value.
2494
2495         * DumpRenderTree/qt/DumpRenderTree.cpp:
2496         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2497
2498 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2499
2500         Unreviewed potential buildbot fix.
2501
2502         Reset page history before running each test.
2503
2504         * DumpRenderTree/qt/DumpRenderTree.cpp:
2505         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2506
2507 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2508
2509         Reviewed by Eric Seidel.
2510
2511         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2512
2513         Bug 28420 -  Implement HTML5 <ruby> rendering
2514         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2515
2516         No new tests (no functional change).
2517
2518         * Scripts/build-webkit:
2519
2520 2009-10-29  Dan Bernstein  <mitz@apple.com>
2521
2522         Reviewed by Mark Rowe.
2523
2524         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2525         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2526         define it.
2527
2528         * Scripts/VCSUtils.pm:
2529         * Scripts/svn-apply:
2530         * Scripts/svn-unapply:
2531
2532 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2533
2534         Reviewed by Gustavo Noronha.
2535
2536         Use the GTK+ main loop instead of rolling our own mini-version of
2537         it.
2538
2539         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2540         (dump):
2541         (runTest):
2542         (webViewLoadFinished):
2543
2544 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2545
2546         Reviewed by Oliver Hunt.
2547
2548         Implement the Qt version of DRT dumpBackForwardList().
2549
2550         * DumpRenderTree/qt/DumpRenderTree.cpp:
2551         (WebCore::dumpHistoryItem):
2552         (WebCore::DumpRenderTree::dumpBackForwardList):
2553
2554 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2555
2556         Reviewed by Adam Roben.
2557
2558         Implement DRT functionality for Qt introduced in
2559         r28690 and r28705.
2560
2561         - Implemented pathToLocalResource which exposes the functionality of
2562         converting a given unix path to the correct location on Windows.
2563         - Implemented a way to remove machine-dependent information from paths
2564         in layout test results.
2565
2566         * DumpRenderTree/qt/DumpRenderTree.cpp:
2567         (WebCore::urlSuitableForTestResult):
2568         (WebCore::WebPage::javaScriptConsoleMessage):
2569         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2570         (LayoutTestController::pathToLocalResource):
2571         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2572
2573 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2574
2575         Adding myself to the committers list.
2576
2577         * Scripts/modules/committers.py:
2578
2579 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2580
2581         Adding myself to the committers list.
2582
2583         * Scripts/modules/committers.py:
2584
2585 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2586
2587         Reviewed by Jan Alonzo.
2588
2589         [GTK] API to start inspector for a WebView
2590         https://bugs.webkit.org/show_bug.cgi?id=22551
2591
2592         Use the new inspector API to implement the LayoutTestController
2593         interfaces used to test the inspector.
2594
2595         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2596         (webInspectorInspectWebView):
2597         (createWebView):
2598         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2599         (LayoutTestController::showWebInspector):
2600         (LayoutTestController::closeWebInspector):
2601         (LayoutTestController::evaluateInWebInspector):
2602
2603 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2604
2605         Reviewed by Eric Seidel.
2606
2607         [Qt] WebFrame::counterValueForElementById must not be exposed
2608         https://bugs.webkit.org/show_bug.cgi?id=30882
2609
2610         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2611         (LayoutTestController::counterValueForElementById):
2612
2613 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2614
2615         Rubberstamped by Oliver Hunt.
2616
2617         Fix the warning:
2618
2619         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2620         declared with attribute warn_unused_result".
2621
2622         by actually checking the result. In the case it is null, an
2623         error has occoured, so treat it as the other fatal errors.
2624
2625         * DumpRenderTree/qt/DumpRenderTree.cpp:
2626         (WebCore::DumpRenderTree::initializeFonts):
2627
2628 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2629
2630         Reviewed by Darin Adler.
2631
2632         Provide a way to get counter values with layoutTestContoller
2633         https://bugs.webkit.org/show_bug.cgi?id=30555
2634
2635         Define layoutTestContoller.counterValueForElementById.
2636
2637         * DumpRenderTree/LayoutTestController.cpp:
2638         (counterValueForElementByIdCallback):
2639         (LayoutTestController::staticFunctions):
2640         * DumpRenderTree/LayoutTestController.h:
2641         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2642         (LayoutTestController::counterValueForElementById):
2643
2644 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2645
2646         Rubberstamped by Oliver Hunt.
2647
2648         Change two methods to be internal for DRT use only.
2649
2650         Part of [Qt] Review all new API in Qt 4.6
2651         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2652
2653         * DumpRenderTree/qt/DumpRenderTree.cpp:
2654         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2655         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2656         (LayoutTestController::whiteListAccessFromOrigin):
2657
2658 2009-10-27  Eric Seidel  <eric@webkit.org>
2659
2660         Reviewed by Adam Barth.
2661
2662         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2663         https://bugs.webkit.org/show_bug.cgi?id=30826
2664
2665         * Scripts/svn-apply:
2666          - Add () around all system() calls.
2667          - Use the correct system() == 0 or die instead of system() or die
2668          - Add descriptive messages to all die statements.
2669
2670 2009-10-27  Steve Block  <steveblock@google.com>
2671
2672         Reviewed by NOBODY.
2673
2674         Adds steveblock@google.com to list of committers.
2675
2676         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2677
2678 2009-10-27  Eric Seidel  <eric@webkit.org>
2679
2680         Reviewed by Adam Barth.
2681
2682         svn-apply can exit(0) even on patch failure
2683         https://bugs.webkit.org/show_bug.cgi?id=29622
2684
2685         * Scripts/svn-apply:
2686          - Add a bunch of "or die" statements, hopefully catching all
2687            possible cases where failure could still exit(0).
2688
2689 2009-10-27  Eric Seidel  <eric@webkit.org>
2690
2691         Reviewed by Adam Barth.
2692
2693         svn-* scripts should share code through VCSUtils.pm
2694         https://bugs.webkit.org/show_bug.cgi?id=30791
2695
2696         Just moving code into a shared location.
2697
2698         * Scripts/VCSUtils.pm:
2699         * Scripts/prepare-ChangeLog:
2700         * Scripts/resolve-ChangeLogs:
2701         * Scripts/svn-apply:
2702         * Scripts/svn-create-patch:
2703         * Scripts/svn-unapply:
2704         * Scripts/update-webkit:
2705
2706 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2707
2708         Suppress a huge number of MSVC warnings when building wxWebKit.
2709
2710         * wx/build/settings.py:
2711
2712 2009-10-26  Eric Seidel  <eric@webkit.org>
2713
2714         No review, just adding Mike Belshe to the committers list.
2715
2716         * Scripts/modules/committers.py:
2717
2718 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2719
2720         Reviewed by Darin Adler.
2721
2722         Make .rc files compile on Windows without depending on MFC headers
2723         https://bugs.webkit.org/show_bug.cgi?id=30750
2724
2725         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2726         windows.h instead of afxres.h because it exists even when MFC is not
2727         installed, and is all that's needed here.
2728
2729         * FindSafari/FindSafari.rc: Ditto
2730
2731 2009-10-24  Eric Seidel  <eric@webkit.org>
2732
2733         Reviewed by Adam Barth.
2734
2735         bugzilla-tool post-diff should know how to mark commit-queue=?
2736         https://bugs.webkit.org/show_bug.cgi?id=29202
2737
2738         * Scripts/bugzilla-tool:
2739          - Add --commit-queue option to post-diff, post-commits and create-bug.
2740         * Scripts/modules/bugzilla.py:
2741          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2742          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2743
2744 2009-10-23  Eric Seidel  <eric@webkit.org>
2745
2746         Reviewed by Adam Barth.
2747
2748         bugzilla-tool commit-queue does not notice modifications to committers.py
2749         https://bugs.webkit.org/show_bug.cgi?id=30084
2750
2751         * Scripts/bugzilla-tool:
2752          - Make commit-queue re-exec itself instead of using while(1).
2753          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2754          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2755
2756 2009-10-22  Eric Seidel  <eric@webkit.org>
2757
2758         Reviewed by Adam Barth.
2759
2760         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2761         https://bugs.webkit.org/show_bug.cgi?id=30634
2762
2763         * Scripts/bugzilla-tool:
2764          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2765          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2766
2767 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2768
2769         Reviewed by Eric Seidel.
2770
2771         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2772
2773         https://bugs.webkit.org/show_bug.cgi?id=30763
2774
2775         * pywebsocket/mod_pywebsocket/__init__.py:
2776         * pywebsocket/mod_pywebsocket/dispatch.py:
2777         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2778         * pywebsocket/mod_pywebsocket/standalone.py:
2779         * pywebsocket/setup.py:
2780         * pywebsocket/test/test_dispatch.py:
2781
2782 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2783
2784         Reviewed by David Levin.
2785
2786         REGRESSION: 2 failures in run-webkit-unittests
2787         https://bugs.webkit.org/show_bug.cgi?id=30645
2788
2789         * Scripts/modules/cpp_style_unittest.py:
2790         Fixed a few test scenarios which apparently lost some spaces from
2791         text literals.
2792
2793 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2794
2795         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2796
2797         * Scripts/webkitdirs.pm:
2798
2799 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2800
2801         Reviewed by Darin Adler.
2802
2803         Unification of using null device in perl scripts.
2804         https://bugs.webkit.org/show_bug.cgi?id=30572
2805
2806         * Scripts/VCSUtils.pm:
2807         * Scripts/bisect-builds:
2808         * Scripts/resolve-ChangeLogs:
2809         * Scripts/run-iexploder-tests:
2810         * Scripts/run-jsc:
2811         * Scripts/run-mangleme-tests:
2812         * Scripts/run-webkit-tests:
2813         * Scripts/webkitdirs.pm:
2814         Using File::Spec->devnull() instead of hard coded /dev/null.
2815
2816 2009-10-26  Eric Seidel  <eric@webkit.org>
2817
2818         Reviewed by Holger Freyther.
2819
2820         Reviewers are missing from committers.py
2821         https://bugs.webkit.org/show_bug.cgi?id=30733
2822
2823         * Scripts/modules/committers.py:
2824
2825 2009-10-23  Eric Seidel  <eric@webkit.org>
2826
2827         No review, only adding Alice to the list of reviewers.
2828
2829         * Scripts/modules/committers.py:
2830
2831 2009-10-23  Eric Seidel  <eric@webkit.org>
2832
2833         Reviewed by Eric Carlson.
2834
2835         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2836         https://bugs.webkit.org/show_bug.cgi?id=30700
2837
2838         * DumpRenderTree/mac/DumpRenderTree.mm:
2839         (resetDefaultsToConsistentValues): Update QuickTime version check.
2840
2841 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2842
2843         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
2844         character measurement APIs that are private on Tiger.
2845
2846         * wx/build/settings.py:
2847
2848 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2849
2850         Reviewed by NOBODY (build fix).
2851         Build fix following bug #30696.
2852
2853         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2854         (LayoutTestController::evaluateScriptInIsolatedWorld):
2855
2856 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2857
2858         Reviewed by Sam Weinig & Geoff Garen.
2859
2860         https://bugs.webkit.org/show_bug.cgi?id=30696
2861         Enable isolated-worlds tests on mac.
2862
2863         Add private interface for DRT to invoke execution in a given world.
2864
2865         * DumpRenderTree/LayoutTestController.cpp:
2866         (evaluateScriptInIsolatedWorldCallback):
2867         (LayoutTestController::staticFunctions):
2868         * DumpRenderTree/LayoutTestController.h:
2869         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2870         (LayoutTestController::evaluateScriptInIsolatedWorld):
2871         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2872         (LayoutTestController::evaluateScriptInIsolatedWorld):
2873
2874 2009-10-21  Eric Seidel  <eric@webkit.org>
2875
2876         Reviewed by Adam Barth.
2877
2878         bugzilla-tool's "patch failed to download an apply" error should give more information
2879         https://bugs.webkit.org/show_bug.cgi?id=30632
2880
2881         * Scripts/modules/scm.py:
2882          - Use the common run_command method instead of custom POpen code.
2883          - Make run_command know how to take pipes as input.
2884         * Scripts/modules/scm_unittest.py:
2885          - Add new tests to cover change.
2886          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2887
2888 2009-10-21  Kent Tamura  <tkent@chromium.org>
2889
2890         Unreviewed.  Adding myself to the committers list.
2891
2892         * Scripts/modules/committers.py:
2893
2894 2009-10-21  Robin Dunn  <robin@alldunn.com>
2895
2896         Reviewed by Kevin Ollivier.
2897
2898         Update the Windows installer builder to work with Vista / Win 7 and with git.
2899
2900         https://bugs.webkit.org/show_bug.cgi?id=30649
2901
2902         * wx/build/build_utils.py:
2903         * wx/packaging/build-mac-installer.py:
2904         * wx/packaging/build-win-installer.py:
2905         * wx/packaging/wxWebKitInstaller.iss.in:
2906
2907 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2908
2909         Reviewed by Gustavo Noronha.
2910
2911         [GTK] Added conditional code to avoid using
2912         gdk_window_get_root_coords if we do not have a gtk+ release newer
2913         than 2.17.3.
2914         https://bugs.webkit.org/show_bug.cgi?id=30636
2915
2916         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2917
2918 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2919
2920         Reviewed by Eric Seidel.
2921
2922         [Qt] Added dummy implementation for keepWebHistory()
2923         https://bugs.webkit.org/show_bug.cgi?id=30592
2924
2925         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2926         (LayoutTestController::keepWebHistory):
2927         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2928
2929 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2930
2931         Reviewed by Xan Lopez.
2932
2933         [GTK] Fixed the double click condition, it is not double click if
2934         we move in just in one direction.
2935         https://bugs.webkit.org/show_bug.cgi?id=30636
2936
2937         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2938
2939 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2940
2941         Reviewed by Xan Lopez.
2942
2943         [GTK] Initialize the events completly before emitting them.
2944         https://bugs.webkit.org/show_bug.cgi?id=30633
2945
2946         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2947
2948 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2949
2950         wx build fix. Fix for when linking using --as-needed with gcc.
2951
2952         * wx/browser/wscript:
2953
2954 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2955
2956         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2957         to support all the features used by CURL backend.
2958
2959         * wx/build/settings.py:
2960         * wx/install-unix-extras:
2961
2962 2009-10-20  Anton Muhin  <antonm@chromium.org>
2963
2964         Reviewed by Adam Barth.
2965
2966         Add {ager,antonm,yurys}@chromium.org into committers.py
2967         https://bugs.webkit.org/show_bug.cgi?id=30560
2968
2969         * Scripts/modules/committers.py:
2970
2971 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2972
2973         Reviewed by Tor Arne Vestbø.
2974
2975         Make the Netscape Test plugin available to the Qt launcher.
2976
2977         * Scripts/run-launcher:
2978
2979 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2980
2981         Reviewed by David Levin.
2982
2983         Removed WebSocket runtime settings.
2984         https://bugs.webkit.org/show_bug.cgi?id=29896
2985
2986         WebSocket runtime configuration is supported by chromium/v8 only.
2987
2988         * DumpRenderTree/mac/DumpRenderTree.mm:
2989         (resetDefaultsToConsistentValues):
2990         * DumpRenderTree/win/DumpRenderTree.cpp:
2991         (resetDefaultsToConsistentValues):
2992
2993 2009-10-19  Nate Chapin  <japhet@chromium.org>
2994
2995         Reviewed by Adam Barth.
2996
2997         Add testFail() to test plugin so we can test our handling of a
2998         plugin invoke call returning false.
2999
3000         https://bugs.webkit.org/show_bug.cgi?id=30239
3001
3002         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3003         (pluginInvoke):
3004         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3005
3006 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3007
3008         Reviewed by Gustavo Noronha.
3009
3010         Enable DOM pasting when running layout tests.
3011
3012         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3013         (resetDefaultsToConsistentValues):
3014
3015 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3016
3017         Reviewed by Simon Hausmann.
3018
3019         Use the setPreferredContentsSize method instead
3020         of setFixedContentsSize, as the method has been renamed.
3021
3022         * DumpRenderTree/qt/DumpRenderTree.cpp:
3023         (WebCore::DumpRenderTree::open):
3024         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3025         (LayoutTestController::setFixedContentsSize):
3026
3027 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3028
3029         Reviewed by Dan Bernstein.
3030
3031         https://bugs.webkit.org/show_bug.cgi?id=30456
3032         Fixes for new Debug_All Windows build configuration.
3033
3034         * DumpRenderTree/win/DumpRenderTree.cpp:
3035         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3036         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3037
3038 2009-10-16  Eric Seidel  <eric@webkit.org>
3039
3040         Reviewed by Adam Barth.
3041
3042         commit-queue status bot should list which buildbot is blocking the queue
3043         https://bugs.webkit.org/show_bug.cgi?id=30452
3044
3045         Add new methods and testing.
3046
3047         * Scripts/bugzilla-tool:
3048         * Scripts/modules/buildbot.py:
3049         * Scripts/modules/buildbot_unittest.py:
3050
3051 2009-10-16  Eric Seidel  <eric@webkit.org>
3052
3053         Reviewed by Adam Barth.
3054
3055         run-webkit-tests fails when CWD is not inside a WebKit checkout
3056         https://bugs.webkit.org/show_bug.cgi?id=30451
3057
3058         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3059         * Scripts/modules/scm_unittest.py:
3060           - Remove use of original_path (we don't need to restore the CWD).
3061           - Don't use '.' to find the webkit checkout, use __file__ instead.
3062
3063 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3064
3065         Reviewed by Adam Roben.
3066
3067         Add a Debug_All configuration to build entire stack as debug.
3068         Change Debug_Internal to:
3069         - stop using _debug suffix for all WebKit/Safari binaries
3070         - not use _debug as a DLL naming suffix
3071         - use non-debug C runtime lib.
3072
3073         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3074         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3075         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3076         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3077         Add missing debug.vsprops inherited property sheet.
3078         Add Debug_All configuration.
3079         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3080         * WinLauncher/WinLauncher.vcproj:
3081         Removed extraneous definitions inherited from vsprops.
3082         Add Debug_All configuration.
3083
3084 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3085
3086         Reviewed by David Levin.
3087
3088         check-webkit-style is wrong about indent checking in namespaces
3089         in header files and a few other things
3090         https://bugs.webkit.org/show_bug.cgi?id=30362
3091
3092         The few other things include:
3093         + check-webkit-style does not require spaces around the equal sign
3094           inside 'if' statements and around binary operators that take
3095           numeric literals.
3096         + check-webkit-style reports false errors for the / operator
3097           when part of a filename in the #include directive.
3098
3099         * Scripts/modules/cpp_style.py:
3100         Improved indentation checking and space checking around
3101         binary operators. While the checks are still not perfect,
3102         they are clearly better than before.
3103         * Scripts/modules/cpp_style_unittest.py:
3104         Added test cases for the newly supported checks and modified old
3105         test cases to match the new guidelines
3106
3107 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3108
3109         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3110
3111         * wx/build/settings.py:
3112
3113 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3114
3115         Reviewed by David Levin.
3116
3117         Add mod_pywebsocket to test Web Sockets.
3118         http://code.google.com/p/pywebsocket/
3119         https://bugs.webkit.org/show_bug.cgi?id=27490
3120
3121         * pywebsocket/COPYING: Added.
3122         * pywebsocket/MANIFEST.in: Added.
3123         * pywebsocket/README: Added.
3124         * pywebsocket/example/echo_client.py: Added.
3125         * pywebsocket/example/echo_wsh.py: Added.
3126         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3127         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3128         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3129         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3130         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3131         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3132         * pywebsocket/mod_pywebsocket/util.py: Added.
3133         * pywebsocket/setup.py: Added.
3134         * pywebsocket/test/config.py: Added.
3135         * pywebsocket/test/mock.py: Added.
3136         * pywebsocket/test/run_all.py: Added.
3137         * pywebsocket/test/test_dispatch.py: Added.
3138         * pywebsocket/test/test_handshake.py: Added.
3139         * pywebsocket/test/test_mock.py: Added.
3140         * pywebsocket/test/test_msgutil.py: Added.
3141         * pywebsocket/test/test_util.py: Added.
3142         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3143         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3144         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3145         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3146         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3147         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3148         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3149         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3150
3151 2009-10-15  James Robinson  <jamesr@google.com>
3152
3153         Reviewed by David Levin.
3154
3155         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3156
3157         https://bugs.webkit.org/show_bug.cgi?id=30426
3158
3159         * Scripts/modules/cpp_style.py:
3160         * Scripts/modules/cpp_style_unittest.py:
3161
3162 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3163
3164         Reviewed by Adam Roben.
3165
3166         Fixes <http://webkit.org/b/30411>.
3167         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3168
3169         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3170         building Chromium.
3171
3172         * Scripts/pdevenv:
3173
3174 2009-10-15  Robin Dunn  <robin@alldunn.com>
3175
3176         Reviewed by Kevin Ollivier.
3177
3178         Add Mac package building scripts for wx.
3179
3180         https://bugs.webkit.org/show_bug.cgi?id=30405
3181
3182         * wx/build/build_utils.py:
3183         * wx/build/settings.py:
3184         * wx/packaging/build-mac-installer.py: Added.
3185
3186 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3187
3188         Reviewed by Gustavo Noronha.
3189
3190         Enable Web Sockets support when running layout tests.
3191
3192         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3193         (resetDefaultsToConsistentValues):
3194
3195 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3196
3197         Reviewed by Gustavo Noronha.
3198
3199         Need to initialize event.button.button, since in most cases a
3200         button number is not passed as an argument.
3201
3202         * DumpRenderTree/gtk/EventSender.cpp:
3203         (mouseDownCallback):
3204         (mouseUpCallback):
3205
3206 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3207
3208         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3209         the OS if none was explicitly set.
3210
3211         * wx/build/settings.py:
3212
3213 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3214
3215         Reviewed by Timothy Hatcher.
3216
3217         Web Inspector: enable developers extras within inspector layout tests.
3218
3219         https://bugs.webkit.org/show_bug.cgi?id=30014
3220
3221         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3222         (LayoutTestController::showWebInspector):
3223         (LayoutTestController::closeWebInspector):
3224         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3225         (LayoutTestController::showWebInspector):
3226         (LayoutTestController::closeWebInspector):
3227
3228 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3229
3230         Reviewed by Jan Alonzo.
3231
3232         GtkLauncher is using a deprecated signal
3233         https://bugs.webkit.org/show_bug.cgi?id=30364
3234
3235         Modified GtkLauncher to use notify::title signal instead of
3236         deprecated title-changed signal
3237
3238         * GtkLauncher/main.c:
3239         (notify_title_cb):
3240         (create_browser):
3241
3242 2009-10-14  Brady Eidson  <beidson@apple.com>
3243
3244         Reviewed by Sam Weinig.
3245
3246         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3247         1 - Disables WebHistory
3248         2 - Doesn't make sense in that context anyway.
3249
3250         * DumpRenderTree/win/DumpRenderTree.cpp:
3251         (createWebViewAndOffscreenWindow):
3252
3253 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3254
3255         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3256         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3257
3258         * wx/build/settings.py:
3259         * wx/install-unix-extras:
3260
3261 2009-10-14  Brady Eidson  <beidson@apple.com>
3262
3263         Reviewed by Sam Weinig.
3264
3265         WebKit Win API should provide a delegate interface for global history.
3266         https://bugs.webkit.org/show_bug.cgi?id=29905
3267
3268         * DumpRenderTree/LayoutTestController.cpp:
3269         (LayoutTestController::LayoutTestController):
3270         * DumpRenderTree/LayoutTestController.h:
3271         (LayoutTestController::dumpHistoryDelegateCallbacks):
3272         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3273
3274         * DumpRenderTree/win/DumpRenderTree.cpp:
3275         (shouldLogHistoryDelegates):
3276         (runTest):
3277         (createWebViewAndOffscreenWindow):
3278         (main):
3279         * DumpRenderTree/win/DumpRenderTree.vcproj:
3280
3281         Add the IWebHistoryDelegate to DRT Windows:
3282         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3283         (wstringFromBSTR):
3284         (HistoryDelegate::HistoryDelegate):
3285         (HistoryDelegate::~HistoryDelegate):
3286         (HistoryDelegate::QueryInterface):
3287         (HistoryDelegate::AddRef):
3288         (HistoryDelegate::Release):
3289         (HistoryDelegate::didNavigateWithNavigationData):
3290         (HistoryDelegate::didPerformClientRedirectFromURL):
3291         (HistoryDelegate::didPerformServerRedirectFromURL):
3292         (HistoryDelegate::updateHistoryTitle):
3293         (HistoryDelegate::populateVisitedLinksForWebView):
3294         * DumpRenderTree/win/HistoryDelegate.h: Added.
3295
3296         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3297         (LayoutTestController::removeAllVisitedLinks):
3298
3299 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3300
3301         Reviewed by Simon Hausmann.
3302
3303         [Qt] Implement support for setPOSIXLocale on Qt.
3304         https://bugs.webkit.org/show_bug.cgi?id=30268
3305
3306         * DumpRenderTree/qt/DumpRenderTree.cpp:
3307         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3308         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3309         (LayoutTestController::setPOSIXLocale):
3310         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3311
3312 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3313
3314         Unreviewed, adding myself to reviewers list.
3315
3316         * Scripts/modules/committers.py:
3317
3318 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3319
3320         Reviewed by Mark Rowe.
3321
3322         Fix null assignment so root tests work again.
3323
3324         * Scripts/webkitdirs.pm:
3325
3326 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3327
3328         Reviewed by Simon Hausmann.
3329
3330         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3331         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3332         This is done in preparation of implementing missing features in DRT.
3333         No functionality changes made yet.
3334
3335         * DumpRenderTree/qt/DumpRenderTree.cpp:
3336         * DumpRenderTree/qt/DumpRenderTree.pro:
3337         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3338         (EventSender::EventSender):
3339         (EventSender::mouseDown):
3340         (EventSender::mouseUp):
3341         (EventSender::mouseMoveTo):
3342         (EventSender::leapForward):
3343         (EventSender::keyDown):
3344         (EventSender::contextClick):
3345         (EventSender::scheduleAsynchronousClick):
3346         (EventSender::frameUnderMouse):
3347         * DumpRenderTree/qt/EventSenderQt.h: Added.
3348         (EventSender::clearKillRing):
3349         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3350         (LayoutTestController::LayoutTestController):
3351         (LayoutTestController::reset):
3352         (LayoutTestController::processWork):
3353         (LayoutTestController::maybeDump):
3354         (LayoutTestController::waitUntilDone):
3355         (LayoutTestController::notifyDone):
3356         (LayoutTestController::windowCount):
3357         (LayoutTestController::clearBackForwardList):
3358         (LayoutTestController::dumpEditingCallbacks):
3359         (LayoutTestController::dumpResourceLoadCallbacks):
3360         (LayoutTestController::queueBackNavigation):
3361         (LayoutTestController::queueForwardNavigation):
3362         (LayoutTestController::queueLoad):
3363         (LayoutTestController::queueReload):
3364         (LayoutTestController::queueScript):
3365         (LayoutTestController::provisionalLoad):
3366         (LayoutTestController::timerEvent):
3367         (LayoutTestController::encodeHostName):
3368         (LayoutTestController::decodeHostName):
3369         (LayoutTestController::setJavaScriptProfilingEnabled):
3370         (LayoutTestController::setFixedContentsSize):
3371         (LayoutTestController::setPrivateBrowsingEnabled):
3372         (LayoutTestController::setPopupBlockingEnabled):
3373         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3374         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3375         (LayoutTestController::numberOfActiveAnimations):
3376         (LayoutTestController::disableImageLoading):
3377         (LayoutTestController::dispatchPendingLoadRequests):
3378         (LayoutTestController::setDatabaseQuota):
3379         (LayoutTestController::clearAllDatabases):
3380         (LayoutTestController::whiteListAccessFromOrigin):
3381         (LayoutTestController::waitForPolicyDelegate):
3382         (LayoutTestController::overridePreference):
3383         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3384         (LayoutTestController::isLoading):
3385         (LayoutTestController::setLoading):
3386         (LayoutTestController::shouldDumpAsText):
3387         (LayoutTestController::shouldDumpBackForwardList):
3388         (LayoutTestController::shouldDumpChildrenAsText):
3389         (LayoutTestController::shouldDumpDatabaseCallbacks):
3390         (LayoutTestController::shouldDumpStatusCallbacks):
3391         (LayoutTestController::shouldWaitUntilDone):
3392         (LayoutTestController::canOpenWindows):
3393         (LayoutTestController::shouldDumpTitleChanges):
3394         (LayoutTestController::waitForPolicy):
3395         (LayoutTestController::dumpAsText):
3396         (LayoutTestController::dumpChildFramesAsText):
3397         (LayoutTestController::dumpDatabaseCallbacks):
3398         (LayoutTestController::dumpStatusCallbacks):
3399         (LayoutTestController::setCanOpenWindows):
3400         (LayoutTestController::dumpBackForwardList):
3401         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3402         (LayoutTestController::display):
3403         (LayoutTestController::dumpTitleChanges):
3404         (LayoutTestController::dumpSelectionRect):
3405         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3406         (TextInputController::TextInputController):
3407         (TextInputController::doCommand):
3408         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3409         * DumpRenderTree/qt/WorkQueue.cpp:
3410         * DumpRenderTree/qt/WorkQueue.h:
3411         * DumpRenderTree/qt/WorkQueueItem.h:
3412         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3413         (findFrameNamed):
3414         (LoadItem::invoke):
3415         (ReloadItem::invoke):
3416         (ScriptItem::invoke):
3417         (BackForwardItem::invoke):
3418         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3419         * DumpRenderTree/qt/jsobjects.h:
3420
3421 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3422
3423         Not reviewed, adding myself to the list of reviewers.
3424
3425         * Scripts/modules/committers.py:
3426
3427 2009-10-13  Anders Carlsson  <andersca@apple.com>
3428
3429         Reviewed by Sam Weinig.
3430
3431         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3432
3433         Make the private browsing mode testable by the test plug-in.
3434
3435         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3436         (pluginGetProperty):
3437         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3438         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3439         (NPP_New):
3440         (NPP_SetValue):
3441
3442 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3443
3444         No review, just adding self to the list of reviewers.
3445
3446         * Scripts/modules/committers.py:
3447
3448 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3449
3450         Reviewed by Adam Roben.
3451
3452         Web Inspector: Use proper web view in inspector layout
3453         tests for windows.
3454
3455         https://bugs.webkit.org/show_bug.cgi?id=30298
3456
3457         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3458         (LayoutTestController::showWebInspector):
3459         (LayoutTestController::closeWebInspector):
3460         (LayoutTestController::evaluateInWebInspector):
3461
3462 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3463
3464         Reviewed by Sam Weinig.
3465
3466         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3467         https://bugs.webkit.org/show_bug.cgi?id=29841
3468
3469         * DumpRenderTree/mac/DumpRenderTree.mm:
3470         (resetDefaultsToConsistentValues):
3471         * DumpRenderTree/win/DumpRenderTree.cpp:
3472         (resetDefaultsToConsistentValues):
3473
3474 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3475
3476         Reviewed by Dimitri Glazkov.
3477
3478         Chromium Port - Windows
3479         https://bugs.webkit.org/show_bug.cgi?id=29969
3480
3481         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3482         * Scripts/webkitdirs.pm:
3483
3484 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3485
3486         Reviewed by Darin Adler.
3487
3488         jsc scripts cleanup and Qt/GTK fix
3489         https://bugs.webkit.org/show_bug.cgi?id=30288
3490
3491         Duplicated jscPath() moved to webkitdirs.pm.
3492         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3493         Configuration added (release/debug) to path for Qt-port on Windows.
3494
3495         * Scripts/run-javascriptcore-tests:
3496         * Scripts/run-jsc:
3497         * Scripts/run-sunspider:
3498         * Scripts/sunspider-compare-results:
3499         * Scripts/webkitdirs.pm:
3500
3501 2009-10-11  Adam Barth  <abarth@webkit.org>
3502
3503         Unreviewed.  Add Collin to committers.py.
3504
3505         * Scripts/modules/committers.py:
3506
3507 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3508
3509         wx build fix, add bindings to source/include dirs now that there are sources there.
3510
3511         * wx/build/settings.py:
3512
3513 2009-10-09  Mark Rowe  <mrowe@apple.com>
3514
3515         Reviewed by Brady Eidson.
3516
3517         Enable plug-in halting in DumpRenderTree.
3518
3519         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3520         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3521
3522         * DumpRenderTree/mac/DumpRenderTree.mm:
3523         (resetDefaultsToConsistentValues):
3524         * DumpRenderTree/mac/UIDelegate.mm:
3525         (-[UIDelegate webView:shouldHaltPlugin:]):
3526
3527 2009-10-08  Brady Eidson  <beidson@apple.com>
3528
3529         Reviewed by Dan Bernstein.
3530
3531         Ask the History Delegate to populate the visited links hash.
3532         <rdar://problem/7285293> and https://webkit.org/b/29904
3533
3534         Add the ability for LayoutTestController to clear all visited links.
3535         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3536
3537         * DumpRenderTree/LayoutTestController.cpp:
3538         (LayoutTestController::LayoutTestController):
3539         (removeAllVisitedLinksCallback):
3540         (LayoutTestController::staticFunctions):
3541         * DumpRenderTree/LayoutTestController.h:
3542         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3543         (LayoutTestController::removeAllVisitedLinks):
3544
3545         * DumpRenderTree/mac/HistoryDelegate.mm:
3546         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3547
3548         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3549         (LayoutTestController::removeAllVisitedLinks):
3550         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3551         (LayoutTestController::removeAllVisitedLinks):
3552         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3553         (LayoutTestController::removeAllVisitedLinks):
3554
3555
3556 2009-10-08  Daniel Bates  <dbates@webkit.org>
3557
3558         Reviewed by Adam Roben.
3559
3560         https://bugs.webkit.org/show_bug.cgi?id=30175
3561
3562         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3563         the OLE drag-and-drop return value like the function it emulates. Currently,
3564         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
3565         whether the drag-and-drop operation was successful or was cancelled.
3566
3567         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
3568         return value according to whether the drop operation was successful or not.
3569
3570         * DumpRenderTree/win/EventSender.cpp:
3571         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3572         (replaySavedEvents): Ditto.
3573         * DumpRenderTree/win/EventSender.h:
3574         * DumpRenderTree/win/UIDelegate.cpp:
3575         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3576
3577 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3578
3579         Reviewed by Xan Lopez.
3580
3581         [GTK] Added support for a parameter setting the button that was
3582         pressed in the mouseDown function.
3583         https://bugs.webkit.org/show_bug.cgi?id=30220
3584
3585         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3586
3587 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3588
3589         Reviewed by Xan Lopez.
3590
3591         [GTK] Added a line to the bottom of the expected result to match
3592         the output of the test.
3593         https://bugs.webkit.org/show_bug.cgi?id=30220
3594
3595         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3596         expected.txt:
3597
3598 2009-10-08  Adam Roben  <aroben@apple.com>
3599
3600         Use QueryInterface to get IWebInspectorPrivate
3601
3602         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3603         accessed in a more standard way
3604
3605         Reviewed by John Sullivan and Tim Hatcher.
3606
3607         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3608         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3609         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3610         to the IWebInspectorPrivate interface.
3611
3612 2009-10-07  Adam Roben  <aroben@apple.com>
3613
3614         Implement DRT support for origin whitelisting
3615
3616         Fixes <http://webkit.org/b/30185>.
3617
3618         Reviewed by Eric Seidel.
3619
3620         * DumpRenderTree/win/DumpRenderTree.cpp:
3621         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3622         whitelist, to match Mac DRT.
3623         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3624         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3625         IWebViewPrivate::whiteListAccessFromOrigin.
3626
3627 2009-10-07  Brady Eidson  <beidson@apple.com>
3628
3629         Reviewed by Darin Adler.
3630
3631         Send title changes to the global history delegate.
3632         <rdar://problem/7285293> and https://webkit.org/b/29904
3633
3634         * DumpRenderTree/mac/HistoryDelegate.mm:
3635         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3636
3637 2009-10-07  Adam Barth  <abarth@webkit.org>
3638
3639         Unreviewed.  Remove some folks from committers.py who were listed on
3640         the WebKit Team wiki page but who weren't actually listed as commit+.
3641         At some point, we should coorelate this list with the committers
3642         mailing list.
3643
3644         * Scripts/modules/committers.py:
3645
3646 2009-10-07  Adam Barth  <abarth@webkit.org>
3647
3648         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3649         the wiki into committers.py.
3650
3651         * Scripts/modules/committers.py:
3652
3653 2009-10-07  Adam Barth  <abarth@webkit.org>
3654
3655         Unreviewed.  Added Aaron Boodman to committers.py.
3656
3657         * Scripts/modules/committers.py:
3658
3659 2009-10-07  Evan Martin  <evan@chromium.org>
3660
3661         Reviewed by Darin Adler.
3662
3663         Add API to LayoutTestController for re/setting the system locale.
3664         https://bugs.webkit.org/show_bug.cgi?id=18994
3665
3666         * DumpRenderTree/LayoutTestController.cpp:
3667         (setLocaleCallback):
3668         (LayoutTestController::staticFunctions):
3669         (LayoutTestController::setLocale):
3670         * DumpRenderTree/LayoutTestController.h:
3671
3672 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3673
3674         Reviewed by Jan Alonzo.
3675
3676         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3677         https://bugs.webkit.org/show_bug.cgi?id=29689
3678
3679         Build fix by adding -lfontconfig for DumpRenderTree.
3680
3681         * GNUmakefile.am:
3682
3683 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3684
3685         Reviewed by Simon Hausmann.
3686