ce42efd2c49af5cbc6646216f294ed011f4c1e5b
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-11-14  Anders Carlsson  <andersca@apple.com>
2
3         Reviewed by Adam.
4
5         <rdar://problem/5141186>
6         window.layoutTestController.setWindowIsKey is not implemented in DRT.
7         
8         Implement setWindowIsKey.
9         
10         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
11         (LayoutTestController::setWindowIsKey):
12
13 2007-11-13  Sam Weinig  <sam@webkit.org>
14
15         Reviewed by Adam Roben.
16
17         Fix for <rdar://problem/5382579>
18         http/tests/security/cross-frame-access-put.html reports large 
19         negative numbers for screenLeft and screenTop (Mac reports "0")
20
21         * DumpRenderTree/win/UIDelegate.cpp:
22         (UIDelegate::UIDelegate): Initialize the RECT.
23         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
24         (UIDelegate::webViewFrame): ditto.
25         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
26
27 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
28
29         Reviewed by Adam.
30
31         - Make Drosera show source, source URLs, and function stack on Windows,
32         and some minor fixes.
33
34         * Drosera/DebuggerDocument.cpp: Force source to always update display.
35         (DebuggerDocument::updateFileSource):
36         * Drosera/debugger.js: Force source to always update display.
37         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
38         menu controls.
39         (DebuggerClient::resume):
40         (DebuggerClient::pause):
41         (DebuggerClient::stepInto):
42         (DebuggerClient::stepOver):
43         (DebuggerClient::stepOut):
44         (DebuggerClient::showConsole):
45         (DebuggerClient::closeCurrentFile):
46         * Drosera/win/DebuggerClient.h: Ditto.
47         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
48         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
49         removed two bugs.  1) caller could be in a bad state when asked to
50         assign into it. 2) BSTRs were not created correctly.
51         (DebuggerDocument::getPlatformCurrentFunctionStack):
52         * Drosera/win/Drosera.cpp: Hook up the menu controls.
53         (droseraWndProc):
54         (handleCommand):
55         (Drosera::resume):
56         (Drosera::pause):
57         (Drosera::stepInto):
58         (Drosera::stepOver):
59         (Drosera::stepOut):
60         (Drosera::showConsole):
61         (Drosera::closeCurrentFile):
62         * Drosera/win/Drosera.h: Hook up the menu controls.
63         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
64         functions, added a null check, and fixed another bug where caller could
65         be in a bad state when asked to assign into it.
66         (ServerConnection::didLoadMainResourceForDataSource):
67         (ServerConnection::getCallerFrame):
68         * Drosera/win/ServerConnection.h: Safety first.
69
70 2007-11-13  Dan Bernstein  <mitz@apple.com>
71
72         Reviewed by Darin Adler.
73
74         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
75           DumpRenderTree --pixel-tests renders each test twice
76
77         * DumpRenderTree/mac/DumpRenderTree.mm:
78         (dumpRenderTree): Removed the --paint option because the painting code
79         is always exercised as a result of
80         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
81         calling -displayIfNeeded.
82         (dump): Changed to always grab the image from the window since the view
83         is always displayed.
84         (runTest):
85         (displayWebView):
86         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
87         because it always paints.
88
89 2007-11-12  Antti Koivisto  <antti@apple.com>
90
91         Reviewed by Adele.
92         
93         Add support for http media tests
94
95         * Scripts/run-webkit-tests:
96
97 2007-11-12  Sam Weinig  <sam@webkit.org>
98
99         Reviewed by Adam Roben.
100
101         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
102
103         * DumpRenderTree/win/DumpRenderTree.cpp:
104         (runTest):
105         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
106         (LayoutTestController::setPrivateBrowsingEnabled):
107
108 2007-11-12  Adam Roben  <aroben@apple.com>
109
110         * Scripts/update-webkit-localizable-strings: Changed to only scan the
111         mac and win subdirectories.
112
113 2007-11-11  Adam Roben  <aroben@apple.com>
114
115         Fix <rdar://5133816> keepWebHistory is not implemented
116
117         Fixes fast/history/clicked-link-is-visited.html.
118
119         Reviewed by Darin.
120
121         * DumpRenderTree/win/DumpRenderTree.cpp:
122         (runTest): Clear the optionalSharedHistory.
123         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
124         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
125
126 2007-11-10  Sam Weinig  <sam@webkit.org>
127
128         Reviewed by Tim Hatcher.
129
130         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
131         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
132         is turned on)
133
134         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
135
136         Added test: http/tests/security/cross-frame-access-private-browsing.html
137
138         * DumpRenderTree/LayoutTestController.cpp:
139         (setPrivateBrowsingEnabledCallback):
140         (LayoutTestController::staticFunctions):
141         * DumpRenderTree/LayoutTestController.h:
142         * DumpRenderTree/mac/DumpRenderTree.mm:
143         (runTest): Default to private browsing disabled.
144         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
145         (LayoutTestController::setPrivateBrowsingEnabled):
146         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
147         (LayoutTestController::setPrivateBrowsingEnabled):
148
149 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
150
151         Reviewed by Adam.
152
153         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
154         WebCore's!
155
156         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
157         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
158         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
159         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
160         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
161         * Drosera/win/Drosera.cpp:
162         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
163
164 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
165
166         Reviewed by Sam.
167
168         - Use the new IWebFrame [local] function signature and get the shared
169         server correctly.
170
171         * Drosera/win/DebuggerClient.cpp:
172         (DebuggerClient::didFinishLoadForFrame):
173         * Drosera/win/ServerConnection.cpp:
174         (ServerConnection::attemptToCreateServerConnection):
175
176 2007-11-07  Dan Bernstein  <mitz@apple.com>
177
178         Reviewed by Darin Adler.
179
180         - add an option to run-webkit-tests to ignore pixel test failures where
181           all pixels differ by no more than a specified threshold
182
183         * DumpRenderTree/mac/ImageDiff.m:
184         (main):
185         (compareImages):
186         (computePercentageDifferent):
187         * Scripts/run-webkit-tests:
188
189 2007-11-07  Simon Hausmann  <hausmann@kde.org>
190
191         Reviewed by Lars.
192
193         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
194
195         * DumpRenderTree/qt/DumpRenderTree.cpp:
196
197 2007-11-07  Simon Hausmann  <hausmann@kde.org>
198
199         Reviewed by Lars.
200
201         Reworked the QWebSettings API.
202         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
203
204         * DumpRenderTree/qt/DumpRenderTree.cpp:
205
206 2007-11-07  Simon Hausmann  <hausmann@kde.org>
207
208         Reviewed by Lars.
209
210         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
211
212         * DumpRenderTree/qt/jsobjects.cpp:
213
214 2007-11-07  Simon Hausmann  <hausmann@kde.org>
215
216         Reviewed by Lars Knoll <lars@trolltech.com>.
217
218         Add a QWebPage::frameCreated() signal and fix DRT
219         
220         The removal of createFrame in QWebPage broke the re-implementation
221         in DumpRenderTree. Instead emit a frameCreated() signal and
222         connect to it in DumpRenderTree.
223         
224
225         * DumpRenderTree/qt/DumpRenderTree.cpp:
226         (WebCore::WebPage::WebPage):
227         (WebCore::DumpRenderTree::dump):
228         (WebCore::DumpRenderTree::connectFrame):
229         * DumpRenderTree/qt/DumpRenderTree.h:
230
231 2007-11-07  Simon Hausmann  <hausmann@kde.org>
232
233         Reviewed by Lars Knoll <lars@trolltech.com>.
234
235         Moved all the event handlers from QWebFrame into QWebPage.
236         
237         This cleans up the public API and allows us to remove the
238         HackWebFrame hack in DumpRenderTree.
239         
240
241         * DumpRenderTree/qt/jsobjects.cpp:
242         (EventSender::mouseDown):
243         (EventSender::mouseUp):
244         (EventSender::mouseMoveTo):
245
246 2007-11-07  Simon Hausmann  <hausmann@kde.org>
247
248         Reviewed by Mark.
249
250         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
251         to prevent the default implementation from popping up messageboxes.
252
253         * DumpRenderTree/qt/DumpRenderTree.cpp:
254         (WebCore::WebPage::javaScriptConfirm):
255         (WebCore::WebPage::javaScriptPrompt):
256
257 2007-11-06  Eric Seidel  <eric@webkit.org>
258
259         * Scripts/build-testkjs: build fix... too many $$
260
261 2007-11-06  Eric Seidel  <eric@webkit.org>
262
263         Reviewed by Mark Rowe.
264
265         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
266
267 2007-11-05  Adam Roben  <aroben@apple.com>
268
269         Add support on Windows for WEBKIT_TESTFONTS
270
271         This environment variable lets you specify where the fonts to be used
272         by DumpRenderTree reside. The Qt port is already using this, so I'm
273         just following their lead.
274
275         Reviewed by Darin.
276
277         * DumpRenderTree/win/DumpRenderTree.cpp:
278         (exePath): Refactored code out of initialize().
279         (fontsPath): Returns either $WEBKIT_TESTFONTS or
280         DumpRenderTree.resources.
281         (initialize): Use the new fontsPath function.
282         (main): Use the new exePath function.
283         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
284         variable to DRT, like Qt does.
285
286 2007-11-05  Mark Rowe  <mrowe@apple.com>
287
288         Rubber-stamped by Alp Toker.
289
290         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
291
292         * GtkLauncher/main.cpp:
293         (goToURLBarText):
294         (main):
295
296 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
297
298         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
299         <http://bugs.webkit.org/show_bug.cgi?id=15830>
300
301         Reviewed by Timothy.
302
303         Restrict the range of nightly builds used by the bisect-builds script
304         based on the version of Safari and the version of Mac OS X being used.
305
306         Mac OS X 10.4: Safari 2.0: r11976 or newer
307         Mac OS X 10.4: Safari 3.0: r19992 or newer
308
309         Mac OS X 10.5: Safari 2.0: r19594 or newer
310         Mac OS X 10.5: Safari 3.0: r25124 or newer
311
312         * Scripts/bisect-builds:
313         (findMacOSXVersion): Added.
314         (makeNightlyList): Added argument to provide version of Mac OS X.
315         Restrict range of nightly builds based on Safari and Mac OS X versions.
316
317 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
318
319         Reviewed by Maciej.
320
321         - This patch involves several changes, all of them were noticed that
322         they were needed by the work being done in WebKit to get Drosera and
323         WebKit working together on Windows.
324         - The changes are:
325         1) Added a debugger console for output messages.
326         2) Drosera now listens for the WebKit server (before, the server would
327         have to be running before Drosera was started.)
328         3) Fixed a bug where the WebView started out as 0x0 pixels.
329         4) Fixed a bug when there is no scope.
330         5) Added the HTML, JS, and CSS to the project file to make them easy to
331         find.
332         6) Made the ServerConnection functions virtual.
333
334         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
335         for the WebKit server.
336         (DebuggerClient::DebuggerClient):
337         (DebuggerClient::~DebuggerClient):
338         (DebuggerClient::didFinishLoadForFrame):
339         (DebuggerClient::serverConnected):
340         (DebuggerClient::attemptToCreateServerConnection):
341         * Drosera/win/DebuggerClient.h: Ditto.
342         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
343         scope.
344         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
345         (DebuggerDocument::platformValueForScopeVariableNamed):
346         * Drosera/win/Drosera.cpp:
347         (_tWinMain): Added a console in debug for output messages.
348         (Drosera::Drosera): Listen for server.
349         (Drosera::initUI): The server now Initializes COM.
350         (Drosera::serverConnected): Part of the listening for the server.
351         (Drosera::attemptToCreateServerConnection): Ditto.
352         * Drosera/win/Drosera.h: New interface for listening for the server.
353         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
354         files to the VS project.
355         * Drosera/win/ServerConnection.cpp: Part of listening for the server
356         connection.
357         (ServerConnection::ServerConnection):
358         (ServerConnection::attemptToCreateServerConnection):
359         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
360         methods.
361         (ServerConnection::serverConnected):
362
363 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
364
365         Reviewed by Maciej.
366
367         http://bugs.webkit.org/show_bug.cgi?id=15832
368         fast/dom/gc-10.html crashes when run alone
369
370         Check for !done before using objects that can be already deallocated.
371
372         * DumpRenderTree/mac/EditingDelegate.mm:
373         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
374         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
375         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
376         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
377         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
378         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
379         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
380         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
381         (-[EditingDelegate webViewDidBeginEditing:]):
382         (-[EditingDelegate webViewDidChange:]):
383         (-[EditingDelegate webViewDidEndEditing:]):
384         (-[EditingDelegate webViewDidChangeTypingStyle:]):
385         (-[EditingDelegate webViewDidChangeSelection:]):
386         * DumpRenderTree/mac/FrameLoadDelegate.mm:
387         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
388         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
389         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
390         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
391         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
392         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
393         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
394         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
395         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
396         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
397         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
398         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
399         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
400         (-[FrameLoadDelegate webView:willCloseFrame:]):
401         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
402         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
403         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
404         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
405         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
406         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
407         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
408         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
409         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
410
411 2007-11-04  Mark Rowe  <mrowe@apple.com>
412
413         Build fix.  Don't use Carbon.h as the prefix header as it triggers
414         warnings that would otherwise be suppressed due to it being a system header.
415
416         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
417
418 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
419
420         Rubber stamped by Adam.
421         
422         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
423
424         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
425
426 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
427
428         Sort files(...); sections of Xcode project files.
429
430         Rubber-stamped by Darin.
431
432         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
433         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
434         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
435         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
436
437 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
438
439         Script to sort "files(...);" sections in Xcode project.pbxproj files.
440
441         Reviewed by Darin.
442
443         * Scripts/sort-Xcode-project-file: Added.
444
445 2007-11-02  Darin Adler  <darin@apple.com>
446
447         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
448
449 2007-11-02  Darin Adler  <darin@apple.com>
450
451         Reviewed by Maciej.
452
453         * Scripts/run-sunspider: Pass the "--base" option through.
454
455         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
456         the real script do that. Default configuration to Release to match run-sunspider
457         so we don't end up building Debug just to compare results.
458
459 2007-11-01  Adam Roben  <aroben@apple.com>
460
461         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
462
463         Reviewed by Sam.
464
465         * Scripts/commit-log-editor: Show all the directories beneath the
466         source root, instead of just the last one.
467
468 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
469
470         Reviewed by Adam Roben.
471
472         Print out an error message when the Windows build fails
473         and provide guidance on how to find out what went wrong.
474
475         * Scripts/build-webkit:
476         * Scripts/webkitdirs.pm:
477
478 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
479
480         Rubber-stamped by Adam Roben.
481
482         Rolled out r27326 - debug CRT seems to cause no problems after all.
483
484         * DumpRenderTree/win/DumpRenderTree.vcproj:
485
486 2007-10-31  Adam Roben  <aroben@apple.com>
487
488         Switch the Debug configuration to using the non-debug CRT
489
490         This matches WebKit.
491
492         Reviewed by Steve.
493
494         * DumpRenderTree/win/DumpRenderTree.vcproj:
495
496 2007-10-31  Antti Koivisto  <antti@apple.com>
497
498         Reviewed by bdash.
499         
500         Disable media tests when doing leak checking on Tiger.
501         They crash in QuickTime (rdar://problem/5537157).
502
503         * Scripts/run-webkit-tests:
504
505 2007-10-29  Antti Koivisto  <antti@apple.com>
506
507         Reviewed by Maciej.
508         
509         Build media support by default on OSX only.
510
511         * Scripts/build-webkit:
512
513 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
514
515         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
516         get caught by the pre-commit hooks.
517
518 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
519
520         Reviewed by Adam.
521
522         - This is a collection of relatively unrelated changes and cleanups
523         to Drosera to prepare it for interacting with WebKit.  A lot of these
524         changes are just correcting mistakes, for example removing included
525         headers that are no longer needed.
526
527         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
528         this will be needed by the DebuggerClient.
529         (DebuggerDocument::server):
530         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
531         * Drosera/win/DebuggerClient.cpp: 
532         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
533         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
534         (DebuggerClient::createWebViewWithRequest): Added comment about its
535         purpose. 
536         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
537         declarations.
538         (DebuggerClient::webViewLoaded): Moved.
539         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
540         file, since this was the only place it was used.
541         (cfStringToBSTR):
542         * Drosera/win/Drosera.h: Cleaned up the includes.
543         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
544         * Drosera/win/HelperFunctions.h: Removed.
545
546 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
547
548         Reviewed by Adam.
549
550         - Small cleanup in the ServerConnection class.
551
552         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
553         and added an include.
554         (ServerConnection::currentFrame):
555         (ServerConnection::getCallerFrame):
556         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
557         made a pointer into a COMPtr, and cleaned up the includes.
558
559 2007-10-29  Timothy Hatcher  <timothy@apple.com>
560
561         Reviewed by John Sullivan.
562         
563         - Place the Localizable.strings file in mac or win directories
564           if that location exists.
565         - Also look for UI_STRING in .c files.
566
567         * Scripts/extract-localizable-strings:
568
569 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
570
571         Reviewed by Adam.
572
573         - Set the eol-style to native and made all the line endings the same
574         so that I avoid messy diffs that show eol changes.
575
576         * Drosera/win/ServerConnection.cpp:
577         (ServerConnection::didParseSource):
578         (ServerConnection::didEnterCallFrame):
579         (ServerConnection::willExecuteStatement):
580         (ServerConnection::willLeaveCallFrame):
581         (ServerConnection::exceptionWasRaised):
582
583 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
584
585         Reviewed by Adam.
586
587         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
588         functionality that could not have existed previously without the new
589         interfaces.
590         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
591         from a BSTR to a JSValueRef.
592         (DebuggerDocument::platformEvaluateScript): Implemented.
593         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
594         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
595         Implemented.
596         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
597         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
598         * Drosera/win/ServerConnection.cpp: Added a helper function.
599         (ServerConnection::getCallerFrame):
600         * Drosera/win/ServerConnection.h: Added a helper function.
601
602 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
603
604         updated reviewers for my previous changelog.
605
606 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
607         Reviewed by Maciej and Adam and Geoff.
608
609         - Minor mac-side improvements including moving a function to a more
610         appropriate location, fixing a warning, and correctly checking
611         exceptions.
612
613         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
614         (DebuggerDocument::willExecuteStatement):
615         (DebuggerDocument::didEnterCallFrame):
616         (DebuggerDocument::willLeaveCallFrame):
617         (DebuggerDocument::windowScriptObjectAvailable):
618         (DebuggerDocument::callFunctionOnObject):
619         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
620         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
621         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
622         because it doesn't require the ServerConnection at all.
623         (NSStringCreateWithJSStringRef): Made an argument const.
624         (JSValueRefCreateWithNSString): Made an argument const.
625         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
626         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
627         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
628         * Drosera/mac/ServerConnection.mm: Ditto.
629         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
630
631 2007-10-29  Sam Weinig  <sam@webkit.org>
632
633         Reviewed by Adam Roben.
634
635         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
636
637         * DumpRenderTree/LayoutTestController.cpp:
638         (LayoutTestController::LayoutTestController):
639         (getGlobalFlagCallback):
640         (setGlobalFlagCallback):
641         (LayoutTestController::getJSClass):
642         (LayoutTestController::staticValues):
643         * DumpRenderTree/LayoutTestController.h:
644         (LayoutTestController::globalFlag):
645         (LayoutTestController::setGlobalFlag):
646
647 2007-10-29  Darin Adler  <darin@apple.com>
648
649         Reviewed by Maciej.
650
651         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
652         resolution instead of its default.
653
654 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
655
656         Fixed showStatus() to print status for successfully resolved conflicts when using git.
657
658         Reviewed by Mark Rowe.
659
660         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
661         was successfully resolved, but this would not show any status because the change had
662         already been cached in the index using "git add".  The solution is to add an optional
663         second argument to showStatus() which adds the "--cached" switch to the command.
664
665         * Scripts/resolve-ChangeLogs:
666         (showStatus):
667
668 2007-10-28  Eric Seidel  <eric@webkit.org>
669
670         Reviewed by Maciej and Geoff, in unison.
671
672         * Scripts/run-webkit-tests: remove broken --svg option
673
674 2007-10-28  Darin Adler  <darin@apple.com>
675
676         Reviewed by Adam.
677
678         * Scripts/run-sunspider: Default to "Release" configuration rather than
679         defaulting to the last configuration used as other scripts do. This can
680         still be overriden on the command line with "--debug" if there's some
681         reason to do so. Also fix a typo.
682
683         * Scripts/sunspider-compare-results: Fix a typo.
684
685 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
686
687         Reviewed by Adam.
688
689         - Implemented the WebScriptDebugListener functions now that the
690         WebScriptDebugServer exists
691
692         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
693         functions.
694         (ServerConnection::currentFrame):
695         (ServerConnection::didLoadMainResourceForDataSource):
696         (ServerConnection::didParseSource):
697         (ServerConnection::failedToParseSource):
698         (ServerConnection::didEnterCallFrame):
699         (ServerConnection::willExecuteStatement):
700         (ServerConnection::willLeaveCallFrame):
701         (ServerConnection::exceptionWasRaised):
702         * Drosera/win/ServerConnection.h: Removed unused arguments from the
703         members arguments list.
704
705 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
706
707         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
708         <http://bugs.webkit.org/show_bug.cgi?id=15600>
709
710         Reviewed by Darin.
711
712         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
713         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
714         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
715         file.  Note that it may also be used as a stand-alone script.
716
717         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
718         * Scripts/resolve-ChangeLogs: Added.
719         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
720
721 2007-10-26  Mark Rowe  <mrowe@apple.com>
722
723         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
724         to the Qt port on the assumption that it was an implementation of the cross-platform
725         LayoutTestController class.  It is not, so it did not need to be changed.
726
727         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
728
729 2007-10-25  Mark Rowe  <mrowe@apple.com>
730
731         Reviewed by Maciej.
732
733         Fix builds with code coverage enabled.
734
735         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
736
737 2007-10-25  Darin Adler  <darin@apple.com>
738
739         Reviewed by Mark Rowe.
740
741         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
742         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
743
744 2007-10-25  Stephanie  <slewis@apple.com>
745
746         build Fix
747
748         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
749
750 2007-10-25  Stephanie  <slewis@apple.com>
751
752         Reviewed by Mark Rowe, Adam Roben.
753
754         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
755
756         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
757
758 2007-10-25  Alice Liu  <alice.liu@apple.com>
759
760         Reviewed by Adam.
761
762         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
763
764         Moving destructor into platform-specific files
765         * DumpRenderTree/LayoutTestController.cpp:
766         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
767         (LayoutTestController::~LayoutTestController):
768         * DumpRenderTree/qt/jsobjects.cpp:
769         (LayoutTestController::~LayoutTestController):
770
771         LayoutTestController wasn't being destroyed
772         * DumpRenderTree/win/DumpRenderTree.cpp:
773         (runTest):
774
775         Added declspec
776         * DumpRenderTree/win/EditingDelegate.h:
777
778         Reset certain values on the webview (or related delegate) that might 
779         have changed while running a test
780         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
781         (LayoutTestController::~LayoutTestController):
782
783 2007-10-25  Adam Roben  <aroben@apple.com>
784
785         Make sunspider-compare-results work with relative paths
786
787         Reviewed by Sam.
788
789         * Scripts/sunspider-compare-results: Convert arguments to absolute
790         paths before we chdir.
791
792 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
793
794         Reviewed by Sam.
795
796         - Implemented server calls now the WebScriptDebugServer exists.
797         - Also removed no longer needed call to initialize CG.
798
799         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
800         automatically now.
801         (_tWinMain):
802         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
803         (ServerConnection::ServerConnection):
804         (ServerConnection::~ServerConnection):
805         (ServerConnection::pause):
806         (ServerConnection::resume):
807         (ServerConnection::stepInto):
808         (ServerConnection::applicationTerminating):
809         (ServerConnection::serverConnectionDidDie):
810         * Drosera/win/ServerConnection.h: Now uses the COM class.
811
812 2007-10-24  George Staikos  <staikos@kde.org>
813
814         Unbreak Qt build.
815
816         * Scripts/build-webkit:
817
818 2007-10-24  Adam Roben  <aroben@apple.com>
819
820         Remove now-unnecessary call to InitializeCoreGraphics
821
822         WebKit takes care of this now.
823
824         Reviewed by Ada.
825
826         * DumpRenderTree/win/DumpRenderTree.cpp:
827         (initialize):
828
829 2007-10-24  Adam Roben  <aroben@apple.com>
830
831         Use WebTextRenderer in DRT
832
833         Reviewed by Ada.
834
835         * DumpRenderTree/win/DumpRenderTree.cpp:
836         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
837
838 2007-10-24  Sven Herzberg  <sven@imendio.com>
839
840         Reviewed by Mark Rowe.
841
842         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
843         Bug 15614: [GTK] qmake based backends don't build on OS X
844
845         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
846         GTK backend on a Mac
847         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
848         isDarwin() to make it reusable in other places (like the workaround-
849         for-prebuilt-qmake in build-webkit)
850
851 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
852
853         Refurbish update-webkit script.
854
855         Reviewed by Adam.
856
857         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
858         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
859         multi-argument version of system() for flexibility and security.  Check for existence
860         of Internal directory using -d test instead of -x.
861
862 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
863
864         Minor clean-up of prepare-ChangeLog script.
865
866         Reviewed by Adam.
867
868         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
869         of a string.  Use multi-argument versions of open() and system() for flexibility and
870         security.
871
872 2007-10-24  Alice Liu  <alice.liu@apple.com>
873
874         Reviewed by Oliver.
875
876         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
877
878         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
879         replay the saved events when we're still processing the mousedown that starts the drag
880         * DumpRenderTree/win/EventSender.cpp:
881         (doMouseMove):
882         * DumpRenderTree/win/UIDelegate.cpp:
883         (UIDelegate::doDragDrop):
884
885 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
886
887         Reviewed by Sam, Steve and Darin.
888
889         - Stubbed out the WebScriptDebugListener functionality in the Server
890         Connection class to prepare it for receiving those callbacks.
891         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
892         and the ServerConnection to not need to be initialized with a server
893         name, since that is not the way we connect to the WebKit server. 
894
895         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
896         no exception.  Now it only loggs when there is an exception
897         (DebuggerDocument::willExecuteStatement):
898         (DebuggerDocument::didEnterCallFrame):
899         (DebuggerDocument::willLeaveCallFrame):
900         (DebuggerDocument::windowScriptObjectAvailable):
901         (DebuggerDocument::callFunctionOnObject):
902         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
903         to be instantiated with a server's name.
904         (DebuggerClient::DebuggerClient):
905         (DebuggerClient::didFinishLoadForFrame):
906         * Drosera/win/DebuggerClient.h: Removed unsued variable.
907         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
908         a server name.
909         (Drosera::init):
910         (Drosera::initServer):
911         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
912         instantiated with a server's name.
913         * Drosera/win/ServerConnection.cpp: 
914         (ServerConnection::ServerConnection): No longer needs a server name
915         (ServerConnection::~ServerConnection): Only release the global context
916         if there is one.
917         (ServerConnection::serverConnectionDidDie): Stub for
918         IWebScriptDebugListener
919         (ServerConnection::QueryInterface): ditto
920         (ServerConnection::AddRef): ditto
921         (ServerConnection::Release): ditto
922         (ServerConnection::didLoadMainResourceForDataSource): ditto
923         (ServerConnection::didParseSource): ditto
924         (ServerConnection::failedToParseSource): ditto
925         (ServerConnection::didEnterCallFrame): ditto
926         (ServerConnection::willExecuteStatement): ditto
927         (ServerConnection::willLeaveCallFrame): ditto
928         (ServerConnection::exceptionWasRaised): ditto
929         * Drosera/win/ServerConnection.h: Stubbed out the
930         IWebScriptDebugListener functions, and this class no longer needs to be
931         instantiated with a server name.
932
933 2007-10-24  Lars Knoll  <lars@trolltech.com>
934
935         Reviewed by Simon.
936
937         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
938
939         * DumpRenderTree/qt/jsobjects.h:
940
941 2007-10-24  Lars Knoll  <lars@trolltech.com>
942
943         Reviewed by Simon.
944
945         add another command.
946
947         * DumpRenderTree/qt/jsobjects.cpp:
948         (TextInputController::doCommand):
949
950 2007-10-24  Lars Knoll  <lars@trolltech.com>
951
952         Reviewed by Simon.
953
954         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
955
956         * DumpRenderTree/qt/jsobjects.cpp:
957         (EventSender::keyDown):
958         * DumpRenderTree/qt/jsobjects.h:
959
960 2007-10-24  Lars Knoll  <lars@trolltech.com>
961
962         Reviewed by Simon.
963
964         implement eventSender.keyDown().
965
966         * DumpRenderTree/qt/jsobjects.cpp:
967         (EventSender::keyDown):
968
969 2007-10-24  Lars Knoll  <lars@trolltech.com>
970
971         Reviewed by Simon.
972
973         some smaller fixes to the editing support in DRT. Makes another few tests pass.
974
975         * DumpRenderTree/qt/DumpRenderTree.cpp:
976         (WebCore::DumpRenderTree::DumpRenderTree):
977         (WebCore::DumpRenderTree::initJSObjects):
978         * DumpRenderTree/qt/jsobjects.cpp:
979         (TextInputController::doCommand):
980
981 2007-10-24  Lars Knoll  <lars@trolltech.com>
982
983         Reviewed by Simon.
984
985         first bit of implementation for the textinputcontroller.
986
987         * DumpRenderTree/qt/DumpRenderTree.cpp:
988         (WebCore::DumpRenderTree::DumpRenderTree):
989         * DumpRenderTree/qt/DumpRenderTree.h:
990         * DumpRenderTree/qt/jsobjects.cpp:
991         (TextInputController::TextInputController):
992         (TextInputController::doCommand):
993         * DumpRenderTree/qt/jsobjects.h:
994
995 2007-10-24  Lars Knoll  <lars@trolltech.com>
996
997         Reviewed by Simon.
998
999         make the man webpage believe it has focus, so the editing tests work correctly.
1000
1001         * DumpRenderTree/qt/DumpRenderTree.cpp:
1002         (WebCore::DumpRenderTree::DumpRenderTree):
1003
1004 2007-10-24  Lars Knoll  <lars@trolltech.com>
1005
1006         Reviewed by Simon.
1007
1008         implement layoutTestController.dumpEditingCallbacks() correctly.
1009
1010         * DumpRenderTree/qt/DumpRenderTree.cpp:
1011         (WebCore::DumpRenderTree::DumpRenderTree):
1012         * DumpRenderTree/qt/jsobjects.cpp:
1013         (LayoutTestController::reset):
1014         (LayoutTestController::dumpEditingCallbacks):
1015
1016 2007-10-24  Lars Knoll  <lars@trolltech.com>
1017
1018         Reviewed by Simon.
1019
1020         Implement support for testing editing.
1021
1022         * DumpRenderTree/qt/DumpRenderTree.cpp:
1023         (WebCore::DumpRenderTree::DumpRenderTree):
1024
1025 2007-10-23  Sam Weinig  <sam@webkit.org>
1026
1027         Check for null BSTR that can be passed to the UIDelegate methods
1028         from javascript null and undefined.  Fixes a failing test case on
1029         Windows (fast/dom/Window/alert-undefined.html)
1030
1031         Reviewed by Eric Seidel.
1032
1033         * DumpRenderTree/win/UIDelegate.cpp:
1034         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1035         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1036         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1037         (UIDelegate::webViewAddMessageToConsole):
1038
1039 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1040
1041         Reviewed by Darin.
1042         
1043         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1044
1045         * Scripts/build-testkjs:
1046
1047 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1048
1049         Reviewed by Darin.
1050
1051         - add wrapper that finds the right copy of testkjs
1052         
1053         * Scripts/sunspider-compare-results: Added.
1054
1055 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1056
1057         Reviewed by Sam.
1058
1059         - After talking with Steve I now see that the WebKit server must be
1060         running for DCOM to create the distributed objects, which makes sense
1061         and currently WebKit only allows one instance to be running at a time
1062         which avoids accidentally connecting to the wrong server
1063         - In light of this I have removed the code for the attach box and
1064         NotificationServer and known server names, since they are all extranious
1065         now.
1066
1067         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1068         names.
1069         (_tWinMain): Uses init instead of initUI.
1070         (droseraWndProc): No longer creats an attach dialog box.
1071         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1072         it's not manditory to call init before doing COM stuff.
1073         (Drosera::init): calls initUI and will call attach when the
1074         functionality exists. 
1075         (Drosera::initUI): Has changed very little.
1076         (Drosera::attach): Changed the signature to reflect that we no longer
1077         need the dictionary of known server names.
1078         * Drosera/win/Drosera.h: Removed notification classes and known server
1079         names.  Also renamed and moved some functions.
1080         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1081         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1082         headers to the resources folder. 
1083         * Drosera/win/resource.h: Removed the Attach box.
1084
1085 2007-10-22  Adam Roben  <aroben@apple.com>
1086
1087         Windows build fix
1088
1089         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1090
1091 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1092
1093         - Removed a leak that was fixed.
1094
1095         * Scripts/run-webkit-tests:
1096
1097 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1098
1099         Reviewed by Darin.
1100
1101         - Changed the Client so that the DebuggerDocument now own the
1102         ServerConnection.  This simplifies ownership and cleanup. 
1103
1104         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1105         ServerConnection.
1106         (DebuggerClient::initWithServerName):
1107         (DebuggerClient::didFinishLoadForFrame):
1108         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
1109         ServerConnection.
1110         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1111         until after we have a server which we are attached to.
1112         (Drosera::initUI):
1113         (Drosera::attach):
1114         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1115         out previously.
1116
1117 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1118
1119         Reviewed by Nikolas.
1120
1121         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1122
1123         * Scripts/run-javascriptcore-tests:
1124
1125 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1126
1127         Reviewed by Nikolas.
1128
1129         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1130
1131         * Scripts/build-drosera:
1132         * Scripts/build-dumprendertree:
1133         * Scripts/build-testkjs:
1134         * Scripts/build-webkit:
1135         * Scripts/run-javascriptcore-tests:
1136         * Scripts/run-sunspider:
1137         * Scripts/run-webkit-tests:
1138         * Scripts/webkitdirs.pm:
1139
1140 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1141
1142         Reviewed by Mark Rowe.
1143         
1144         Fix for local database support after r26879
1145         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1146
1147         * Scripts/build-webkit:
1148
1149 2007-10-22  Holger Freyther  <zecke@selfish.org>
1150
1151         Reviewed by Simon Hausmann <hausmann@kde.org>.
1152
1153         - Do not build testkjs as an application bundle. This is
1154         needed for run-javascriptcore-tests on OSX.
1155         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1156         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1157         as we do not have -rpath on OSX.
1158
1159         * DumpRenderTree/qt/DumpRenderTree.pro:
1160         * Scripts/run-webkit-tests:
1161
1162 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1163
1164         Reviewed by aroben.
1165
1166         Fix support for Signed-off-by detection in prepare-ChangeLog
1167         --git-commit. The Signed-off-by tag does not appear in the header
1168         but usually at the end.
1169
1170         * Scripts/prepare-ChangeLog:
1171
1172 2007-10-21  Mark Rowe  <mrowe@apple.com>
1173
1174         Reviewed by Eric.
1175
1176         Fix run-javascriptcore-tests for Gtk.
1177
1178         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1179
1180 2007-10-20  Eric Seidel  <eric@webkit.org>
1181
1182         Reviewed by aroben.
1183
1184         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1185
1186 2007-10-20  Eric Seidel  <eric@webkit.org>
1187
1188         Reviewed by darin.
1189         
1190         Add improved argument handling to run-sunspider, including
1191         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1192         Also re-factor code into subroutines
1193
1194         * Scripts/build-dumprendertree: removed bogus comments
1195         * Scripts/build-testkjs: Added.
1196         * Scripts/run-javascriptcore-tests: use build-testkjs
1197         * Scripts/run-sunspider: improved argument handling, abstraction
1198         * Scripts/run-webkit-tests: improved abstraction
1199
1200 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1201
1202         Not reviewed, Windows build fix.
1203
1204         * DumpRenderTree/win/EventSender.cpp:
1205         (keyDownCallback):
1206
1207 2007-10-20  Darin Adler  <darin@apple.com>
1208
1209         Reviewed by Tim Hatcher.
1210
1211         - http://bugs.webkit.org/show_bug.cgi?id=15544
1212           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
1213           not rely on Apple-specific key codes
1214
1215         * DumpRenderTree/mac/EventSendingController.mm:
1216         (-[EventSendingController keyDown:withModifiers:]):
1217         Added named key "rightArrow". Later we could have a whole table of these.
1218         Also tweaked modifiers code a little.
1219
1220         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
1221
1222 2007-10-19  Darin Adler  <darin@apple.com>
1223
1224         Reviewed by Eric.
1225
1226         - http://bugs.webkit.org/show_bug.cgi?id=15566
1227           possible fix for leak seen in DumpRenderTree
1228
1229         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
1230         Delete the item if it's not put on the queue, since the caller has
1231         no way of knowing that. Would be better to have the parameter type
1232         be auto_ptr to express the fact that we take ownership.
1233
1234         - unrelated change
1235
1236         * Drosera/mac/main.m: Add missing include.
1237
1238 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1239
1240         Reviewed by Adam.
1241
1242         - This change should be identical but for some reason was not working
1243         on my machine.
1244
1245         * Scripts/prepare-ChangeLog:
1246
1247 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1248
1249         Reviewed by Oliver and Tim.
1250
1251         - Made use of RetainPtr to avoid retain and release issues and moved the
1252         log function to DebuggerDocumentPlatform, which seems to be a more
1253         logical place for it to live.
1254         - Also moved knownServers from the ServerConnection to
1255         DebuggerApplication to match the Windows code and because it makes sense
1256         that a connection knows its own server but not all of them.
1257
1258         * Drosera/mac/DebuggerClient.h: Moved the log function to
1259           DebuggerDocumentPlatform.
1260         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
1261           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
1262           call for the server name up from the ServerConnection class.
1263         (-[DebuggerClient dealloc]):
1264         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
1265           for the server name up from the ServerConnection.
1266         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
1267         (DebuggerDocument::platformPause):
1268         (DebuggerDocument::platformResume):
1269         (DebuggerDocument::platformStepInto):
1270         (DebuggerDocument::platformEvaluateScript):
1271         (DebuggerDocument::getPlatformCurrentFunctionStack):
1272         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1273         (DebuggerDocument::platformValueForScopeVariableNamed):
1274         (DebuggerDocument::platformLog): Log directly from here. No need to call
1275           DebuggerClient.
1276         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
1277           way I see it, a ServerConnection should only know about its connection
1278           and the group of all possible servers should be kept by the
1279           application.
1280         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
1281           currentServerName, it makes sense that the connection should know that
1282           name.
1283         (-[ServerConnection currentServerName]):
1284
1285 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1286
1287         Reviewed by Adam.
1288
1289         - Integrated changes from mac drosera.  Recently I've encapsulated
1290         out the server connection object from the rest of Drosera because
1291         it is very platform dependent right now and RPC is not implemented on
1292         windows.  This functionality, of communicating with the WebKit server
1293         is the next area I will be focusing on in Windows.
1294
1295         - Other changes and cleanup were made to organize the code and add notes
1296         on which parts still need work.  Also some mac code is added and
1297         commented out, to act as pseudocode for the logic of those parts.
1298
1299         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
1300           pointer.
1301         * Drosera/config.h: Added whitespace.
1302         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
1303           these files got moved into Drosera.h/cpp
1304         * Drosera/win/DebuggerApplication.h: Removed.
1305         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
1306           happened here to better match the logic flow of the same code on the 
1307           mac side and to use the new ServerConnection class.
1308         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
1309         (DebuggerClient::initWithServerName): Initializer that will set up the
1310           class to use a ServerConnection object.  This was necessary so I could
1311           create a DebuggerClient without having to initilaize it at
1312           construction.
1313         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
1314           will be the UIDelegate and FrameLoadDelegate.
1315         (DebuggerClient::AddRef): For IUnknown.
1316         (DebuggerClient::Release): For IUnknown.
1317         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
1318           this still needs to set the global context of the server, but
1319           IWebFrame does not have an accessor for the global context yet. 
1320         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
1321           this is a pass through for the same function in the document.
1322         (DebuggerClient::didReceiveTitle): Unimplemented part of
1323           FrameLoadDelegate this would change the title of the window.
1324         (DebuggerClient::createWebViewWithRequest): Part of the
1325           FrameLoadDelegate.  This is about new windows via Window.open() and
1326           how their delegates are set.
1327         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
1328           UIDelegate.  Just a debug function for printing messages.
1329         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
1330           because the Client should be the UIDelegate and FrameLoadDelegate
1331           to match the delegates on mac.
1332         (DebuggerClient::webViewLoaded): Added accessor method.
1333         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
1334           forgotten to add this file before.  This is where the platform
1335           dependent versions of the Documents functions live. Most of these are
1336           unimplemented because some piece of functionality does not exist on
1337           Windows yet.
1338         (DebuggerDocument::platformPause):
1339         (DebuggerDocument::platformResume):
1340         (DebuggerDocument::platformStepInto):
1341         (DebuggerDocument::platformEvaluateScript):
1342         (DebuggerDocument::getPlatformCurrentFunctionStack):
1343         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1344         (DebuggerDocument::platformValueForScopeVariableNamed):
1345         (DebuggerDocument::platformLog):
1346         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
1347           responsibilities becaue they belong in the Client. Also I laid the
1348           groundwork for attaching Drosera to a WebKit process
1349         (attachWndProc): Now if a server is selected the Client becomes it's
1350           delegate.
1351         (Drosera::Drosera): Added the construction of the Client and dictionary
1352           of server names. 
1353         (Drosera::initUI): This is no longer the delegates, the Client is.
1354         (Drosera::webViewLoaded): Now asks the Client instead of holding local
1355           state. 
1356         (Drosera::applicationDidFinishLaunching): Placeholder for needed
1357           notification registration when it's possible to implement.
1358         (Drosera::serverLoaded): Ditto
1359         (Drosera::serverUnloaded): Ditto
1360         (Drosera::attach): Attach Drosera to the WebKit server.
1361         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
1362         (Drosera::getInst): 
1363         (Drosera::setInst):
1364         (Drosera::knownServers):
1365         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
1366           and added the ServerConnection.
1367         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
1368         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
1369           Most of the functions are completely unimlemented because they cannot
1370           connect with the WebKit server, because one does not exist on Windows
1371           yet.
1372         (ServerConnection::initWithServerName): 
1373         (ServerConnection::~ServerConnection):
1374         (ServerConnection::setGlobalContext):
1375         (ServerConnection::pause):
1376         (ServerConnection::resume):
1377         (ServerConnection::stepInto):
1378         (ServerConnection::switchToServerNamed):
1379         (ServerConnection::applicationTerminating):
1380         (ServerConnection::serverConnectionDidDie):
1381         (ServerConnection::currentFrame):
1382         * Drosera/win/ServerConnection.h: Added. Ditto.
1383         (ServerConnection::ServerConnection):
1384
1385 2007-10-19  Alice Liu  <alice.liu@apple.com>
1386
1387         Reviewed by Darin.
1388
1389         Fix for these broken layout tests on Windows:
1390         
1391         fast/forms/focus-selection-input.html
1392         fast/forms/focus-selection-textarea.html
1393         fast/forms/select-accesskey.html
1394         
1395         * DumpRenderTree/win/EventSender.cpp:
1396         (keyDownCallback):
1397         correct the VK code for alt key.
1398         
1399 2007-10-19  Eric Seidel  <eric@webkit.org>
1400
1401         Reviewed by Mark Rowe.
1402         
1403         Make the GtkLauncher code slightly more readable.
1404
1405         * GtkLauncher/main.cpp:
1406         (setupMainMenu): Added.
1407         (setupMainWindowUI): Added.
1408         (main):
1409
1410 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
1411
1412         Rubber stamped by Adam.
1413         
1414         - don't delay-load WebKit in DumpRenderTree.
1415
1416         * DumpRenderTree/win/DumpRenderTree.vcproj:
1417
1418 2007-10-18  Dan Bernstein  <mitz@apple.com>
1419
1420         Reviewed by Adam Roben.
1421
1422         - fix <rdar://problem/5313523>
1423         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
1424
1425         * DumpRenderTree/mac/DumpRenderTree.mm:
1426         (dump): Changed to use _responseMIMEType.
1427
1428 2007-10-17  Adam Roben  <aroben@apple.com>
1429
1430         Make it possible to have Windows-specific tests and results
1431
1432         When searching for tests to run and the Skipped file, we will only
1433         look in platform/win and the cross-platform directory. When looking
1434         for expected results, we will look in platform/win, then
1435         platform/mac-leopard, then platform/mac, then finally the
1436         cross-platform directory.
1437
1438         Reviewed by Sam.
1439
1440         * Scripts/run-webkit-tests:
1441         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
1442         searching in the cross-platform directory.
1443         (sub buildPlatformHierarchy): Removed some unneeded calls to
1444         dirname/basename.
1445
1446 2007-10-17  Adam Roben  <aroben@apple.com>
1447
1448         Add back the call to register WebKit that we had before WebKitInitializer existed
1449
1450         This is needed to ensure that the right WebKit is used when
1451         instantiating COM objects.
1452
1453         Reviewed by Oliver.
1454
1455         * DumpRenderTree/win/debug_internal.vsprops: Define
1456         DEBUG_WEBKIT_HAS_SUFFIX.
1457         * DumpRenderTree/win/DumpRenderTree.cpp:
1458         (initialize):
1459
1460 2007-10-17  Adam Roben  <aroben@apple.com>
1461
1462         Import File::Basename in webkitdirs since we use it
1463
1464         * Scripts/webkitdirs.pm:
1465
1466 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
1467
1468         - Updated the tiger leaks list to make the internal bots green.
1469
1470         * Scripts/run-webkit-tests:
1471
1472 2007-10-17  Adam Roben  <aroben@apple.com>
1473
1474         Build fix for VC++ Express
1475
1476         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
1477         and ole32.lib.
1478
1479 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1480
1481         Reviewed by Sam.
1482
1483         - Minor mac improvements based on observations I made while implementing the
1484         Windows code.
1485
1486         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
1487         then hand it to the Client who will retain it, it should just be the client who
1488         creates and owns the server.
1489         (-[DebuggerApplication attach:]):
1490         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
1491         * Drosera/mac/DebuggerClient.mm: Creates the server.
1492         (-[DebuggerClient initWithServerName:]):
1493         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
1494         can instead forward declare what it needs.
1495
1496 2007-10-16  Darin Adler  <darin@apple.com>
1497
1498         Reviewed by Geoff Garen.
1499
1500         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
1501         want to turn failing tests into platform-specific test results. Also did a
1502         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
1503         would take the type of results into account only some of the time.
1504
1505 2007-10-16  Adam Roben  <aroben@apple.com>
1506
1507         Add a new nightly launcher script for Windows
1508
1509         This new script is for versions of Safari that don't delay-load
1510         WebKit. I had to make FindSafari be able to print out the nightly
1511         launcher script on stdout because Windows shell scripts can't capture
1512         the output from a command into an environment variable.
1513
1514         Reviewed by Steve.
1515
1516         * FindSafari/FindSafari.cpp:
1517         (_tmain): Added /printSafariLauncher option.
1518         * Scripts/run-webkit-nightly.cmd: Added.
1519
1520 2007-10-16  Adam Roben  <aroben@apple.com>
1521
1522         Replace WebKitInitializer with FindSafari
1523
1524         We now rely on setting the PATH environment variable to tell Windows
1525         where to find WebKit and its dependencies (similar to
1526         DYLD_FRAMEWORK_PATH on Mac).
1527
1528         This change also make DumpRenderTree no longer delay-load WebKit.
1529
1530         Reviewed by Sam.
1531
1532         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
1533         FindSafari.
1534         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
1535         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
1536         WebKitInitializer, don't delay-load WebKit.
1537         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
1538         * Scripts/run-webkit-tests: Ditto.
1539         * Scripts/webkitdirs.pm:
1540         (sub setPathForRunningWebKitApp): Added.
1541         * WebKitInitializer/WebKitInitializer.cpp: Removed.
1542         * WebKitInitializer/WebKitInitializer.h: Removed.
1543         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
1544         * WebKitInitializer/debug.vsprops: Removed.
1545         * WebKitInitializer/debug_internal.vsprops: Removed.
1546         * WebKitInitializer/release.vsprops: Removed.
1547
1548 2007-10-16  Adam Roben  <aroben@apple.com>
1549
1550         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
1551
1552         http://bugs.webkit.org/show_bug.cgi?id=15532
1553
1554         FindSafari simply prints the location of an installed Safari.exe on
1555         stdout.
1556
1557         Reviewed by Darin.
1558
1559         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
1560         (getStringValue):
1561         (getWebViewCLSID):
1562         (getInstalledWebKitDirectory):
1563         (_tmain):
1564         * FindSafari/FindSafari.vcproj: Added.
1565         * Scripts/webkitdirs.pm:
1566         (sub installedSafariPath): Added. Calls FindSafari on Windows.
1567
1568 2007-10-16  Adam Roben  <aroben@apple.com>
1569
1570         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
1571
1572         Reviewed by Kevin McCullough.
1573
1574         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
1575         when referring to WebKit.dll.
1576         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
1577         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
1578         * DumpRenderTree/win/release.vsprops: Ditto.
1579         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
1580         never have a _debug suffix on WebKit.dll.
1581         * WebKitInitializer/WebKitInitializer.cpp:
1582         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
1583         specified.
1584         * WebKitInitializer/debug_internal.vsprops: Added
1585         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
1586
1587 2007-10-16  Darin Adler  <darin@apple.com>
1588
1589         Reviewed by Adele.
1590
1591         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1592         Remove now-unneeded control/alt key hack; the tests have been updated.
1593
1594 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1595
1596         - Updated leaks list because our internal bot upgraded it's version of leopard and 
1597         one of the leaks was fixed between that revision and the bot's previous version of
1598         leopard.
1599
1600         * Scripts/run-webkit-tests:
1601
1602 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
1603
1604         Reviewed by Tim.
1605
1606         - I encapsulated out the server connecton functionality because it is a specific part
1607         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
1608         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
1609         Windows.  So the majority of this patch is moving preexisting functionality.
1610
1611         - Also I removed the prefix header and changed to use config.h because it is more
1612         standard on how we use config.h in windows and it didn't make much sense to keep
1613         the prefix header and the config.h
1614
1615         * Drosera/DebuggerDocument.cpp:
1616         (DebuggerDocument::DebuggerDocument):
1617         * Drosera/DebuggerDocument.h:
1618         * Drosera/config.h:
1619         * Drosera/mac/DebuggerApplication.mm:
1620         (-[DebuggerApplication attach:]):
1621         * Drosera/mac/DebuggerClient.h:
1622         * Drosera/mac/DebuggerClient.mm:
1623         (-[DebuggerClient initWithServerConnection:]):
1624         (-[DebuggerClient dealloc]):
1625         (-[DebuggerClient windowDidLoad]):
1626         (-[DebuggerClient windowWillClose:]):
1627         (-[DebuggerClient webView:didFinishLoadForFrame:]):
1628         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
1629         * Drosera/mac/DebuggerDocumentPlatform.mm:
1630         (DebuggerDocument::platformPause):
1631         (DebuggerDocument::platformResume):
1632         (DebuggerDocument::platformStepInto):
1633         (DebuggerDocument::platformEvaluateScript):
1634         (DebuggerDocument::getPlatformCurrentFunctionStack):
1635         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1636         (DebuggerDocument::platformValueForScopeVariableNamed):
1637         (DebuggerDocument::platformLog):
1638         * Drosera/mac/Drosera.pch: Removed.
1639         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1640         * Drosera/mac/ServerConnection.h: Added.
1641         * Drosera/mac/ServerConnection.mm: Added.
1642         (-[ServerConnection initWithServerName:]):
1643         (-[ServerConnection dealloc]):
1644         (-[ServerConnection setGlobalContext:]):
1645         (-[ServerConnection pause]):
1646         (-[ServerConnection resume]):
1647         (-[ServerConnection stepInto]):
1648         (-[ServerConnection switchToServerNamed:]):
1649         (-[ServerConnection applicationTerminating:]):
1650         (-[ServerConnection serverConnectionDidDie:]):
1651         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1652         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1653         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1654         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1655         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1656         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1657         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1658         (-[ServerConnection currentFrame]):
1659         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1660         (-[ServerConnection knownServers]):
1661
1662 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1663
1664         Reviewed by Eric.
1665
1666         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1667           Script to automatically search nightly builds for regressions (bisect-builds)
1668
1669         * Scripts/bisect-builds: Added.
1670
1671 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1672
1673         Reviewed by Darin.
1674
1675         - New JavaScript benchmark
1676         http://bugs.webkit.org/show_bug.cgi?id=15515
1677
1678         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1679         current development or release build of JavaScriptCore.
1680
1681 2007-10-15  Mark Rowe  <mrowe@apple.com>
1682
1683         Reviewed by Sam.
1684
1685         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1686
1687         * Scripts/webkitdirs.pm:
1688         - Change checkArgv to remove the options from @ARGV to prevent
1689         them from interfering with further option processing.
1690         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1691         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1692         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1693         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1694
1695 2007-10-15  Darin Adler  <darin@apple.com>
1696
1697         Reviewed by Sam.
1698
1699         - added logging of window.prompt and window.confirm
1700
1701         * DumpRenderTree/mac/UIDelegate.mm:
1702         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1703         Implement the recommended delegate rather than the deprecated one.
1704         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1705         Added.
1706         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1707         Added.
1708
1709         * DumpRenderTree/win/UIDelegate.h:
1710         * DumpRenderTree/win/UIDelegate.cpp:
1711         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1712         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1713         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
1714         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
1715
1716 2007-10-15  Alice Liu  <alice.liu@apple.com>
1717
1718         Reviewed by Sam Weinig.
1719
1720         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
1721
1722         * DumpRenderTree/win/DumpRenderTree.cpp:
1723         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
1724         (main): allocate the global policy delegate for DRT's custom use
1725         * DumpRenderTree/win/DumpRenderTree.vcproj:
1726         Adding files to project
1727         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
1728         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1729         (LayoutTestController::setCustomPolicyDelegate):
1730         set the webview's policy delegate to DRT's custom one if the test requests it.
1731         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
1732         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
1733         (PolicyDelegate::PolicyDelegate):
1734         (PolicyDelegate::QueryInterface):
1735         (PolicyDelegate::AddRef):
1736         (PolicyDelegate::Release):
1737         (PolicyDelegate::decidePolicyForNavigationAction):
1738         * DumpRenderTree/win/PolicyDelegate.h: Added.
1739         (PolicyDelegate::decidePolicyForNewWindowAction):
1740         (PolicyDelegate::decidePolicyForMIMEType):
1741         (PolicyDelegate::unableToImplementPolicyWithError):
1742
1743 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1744
1745         Reviewed by Mark.
1746
1747         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
1748         when querying for QMAKE_MKSPECS.
1749
1750 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
1751
1752         Reviewed by Adam Roben.
1753         
1754         Fix run-webkit-tests is too greedy calculating platform hierarchy
1755         http://bugs.webkit.org/show_bug.cgi?id=15465
1756         
1757         Fix run-webkit-tests being too greedy in trying to split the platform name up
1758         causing it to try and find tests in every directory above the first "-" in the
1759         path to the LayoutTests
1760
1761         * Scripts/run-webkit-tests:
1762
1763 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
1764
1765         Reviewed by Darin.
1766
1767         http://bugs.webkit.org/show_bug.cgi?id=15006
1768         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
1769         to reduce code duplication.
1770
1771         * Scripts/build-webkit:
1772         * Scripts/webkitdirs.pm:
1773         buildQMakeProject() renamed to buildQMakeQtProject().
1774         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
1775         unused $colorize has been removed.
1776
1777 === Start merge of feature-branch 2007-10-12 ===
1778
1779 2007-10-08  Eric Seidel  <eric@webkit.org>
1780
1781         Reviewed by Mark Rowe.
1782
1783         * Scripts/build-webkit: add --help, remove unused --color
1784
1785 2007-10-07  Eric Seidel  <eric@webkit.org>
1786
1787         Reviewed by darin.
1788
1789         * Drosera/mac/DebuggerDocumentPlatform.mm:
1790         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
1791
1792 2007-10-03  Rob Buis  <buis@kde.org>
1793
1794         Reviewed by Olliej.
1795
1796         Adapt to changed location of Ahem font.
1797
1798         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1799
1800 2007-10-02  Eric Seidel  <eric@webkit.org>
1801
1802         Reviewed by Adam Roben.
1803         
1804         Make pixel tests more useful!
1805         Finally fix the image diff 0.00% mystery problem
1806         Highlight any image differences in the image diff.
1807         Add a link from image diffs back to original test file.
1808
1809         * DumpRenderTree/mac/ImageDiff.m:
1810         (compareImages): highlight any differences
1811         (computePercentageDifferent): round to two decimal places
1812         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
1813
1814 2007-10-02  Eric Seidel  <eric@webkit.org>
1815
1816         Reviewed by Alexey Proskuryakov.
1817
1818         * Scripts/run-webkit-tests: print the % image difference on main results page
1819
1820 2007-10-02  Mark Rowe  <mrowe@apple.com>
1821
1822         Reviewed by Oliver.
1823
1824         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1825
1826         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1827         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1828
1829 2007-10-01  Mark Rowe  <mrowe@apple.com>
1830
1831         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1832
1833 2007-09-25  Eric Seidel  <eric@webkit.org>
1834
1835         Reviewed by Mark Rowe.
1836         
1837         DerivedSources.make was finding "ENABLE_SVG" in the string
1838         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
1839         quite correctly.
1840
1841         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
1842
1843 2007-09-25  Mark Rowe  <mrowe@apple.com>
1844
1845         Rubber-stamped by Eric.
1846
1847         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1848         This makes it possible to automate nightly builds for the feature-branch.
1849
1850 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
1851
1852         Rubber stamped by Mark.
1853
1854         Enable svg experimental features as default here in feature-branch.
1855
1856         * Scripts/build-webkit:
1857
1858 2007-06-29  Antti Koivisto  <antti@apple.com>
1859
1860         Reviewed by Weinig.
1861         
1862         Add VIDEO flag for timed media features
1863
1864         * Scripts/build-webkit
1865         
1866 === End merge of feature-branch 2007-10-12 ===
1867
1868 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1869
1870         Reviewed by Darin.
1871
1872         - Updated rational for the leaks list to be more clear.
1873
1874         * Scripts/run-webkit-tests:
1875
1876 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1877
1878         Rubber Stamp by Sam.
1879
1880         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
1881         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
1882
1883         * Scripts/run-webkit-tests:
1884
1885 2007-10-10  Simon Hausmann  <hausmann@kde.org>
1886
1887         Reviewed by Lars.
1888
1889         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
1890         includes are needed for INT_MAX, std::auto_ptr and the like.
1891
1892         * DumpRenderTree/qt/main.cpp:
1893
1894 2007-10-09  Lars Knoll  <lars@trolltech.com>
1895
1896         Reviewed by Simon.
1897
1898         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
1899
1900         * DumpRenderTree/qt/jsobjects.cpp:
1901         (LayoutTestController::encodeHostName):
1902         (LayoutTestController::decodeHostName):
1903         * DumpRenderTree/qt/jsobjects.h:
1904
1905 2007-10-09  Lars Knoll  <lars@trolltech.com>
1906
1907         Reviewed by Simon.
1908
1909         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
1910
1911         * DumpRenderTree/qt/DumpRenderTree.cpp:
1912         (WebCore::WebPage::createFrame):
1913         (WebCore::DumpRenderTree::DumpRenderTree):
1914         (WebCore::DumpRenderTree::titleChanged):
1915         * DumpRenderTree/qt/DumpRenderTree.h:
1916         * DumpRenderTree/qt/jsobjects.cpp:
1917         (LayoutTestController::reset):
1918         * DumpRenderTree/qt/jsobjects.h:
1919
1920 2007-10-09  Lars Knoll  <lars@trolltech.com>
1921
1922         Reviewed by Simon.
1923
1924         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
1925
1926         * DumpRenderTree/qt/DumpRenderTree.h:
1927         * DumpRenderTree/qt/jsobjects.cpp:
1928         (LayoutTestController::clearBackForwardList):
1929         * DumpRenderTree/qt/jsobjects.h:
1930
1931 2007-10-09  Lars Knoll  <lars@trolltech.com>
1932
1933         Reviewed by Simon.
1934
1935         make --git-reviewer work again.
1936
1937         * Scripts/prepare-ChangeLog:
1938
1939 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
1940
1941         Rubber stamped by Eric.
1942
1943         Connect to the "hovering-over-link" signal emitted by WebKitPage and
1944         show the current link inside the statusbar.
1945         This shows how to make use of this signal and allows to easily test
1946         http://bugs.webkit.org/show_bug.cgi?id=15299.
1947
1948         * GtkLauncher/main.cpp:
1949         (hoveringOverLink):
1950         (main):
1951
1952 2007-10-05  Lars Knoll  <lars@trolltech.com>
1953
1954         add proper error messages to the FrameLoaderClient.
1955         Implement ChromeClientQt::closeWindowSoon and
1956         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
1957         Some fixes in DRT to make it work correctly with multiple windows.
1958
1959         Reviewed by Maciej.
1960
1961         * DumpRenderTree/qt/DumpRenderTree.cpp:
1962         (WebCore::DumpRenderTree::DumpRenderTree):
1963         (WebCore::DumpRenderTree::createWindow):
1964         (WebCore::DumpRenderTree::windowCount):
1965         * DumpRenderTree/qt/DumpRenderTree.h:
1966         * DumpRenderTree/qt/jsobjects.cpp:
1967         (LayoutTestController::maybeDump):
1968         (LayoutTestController::windowCount):
1969         * DumpRenderTree/qt/jsobjects.h:
1970
1971 2007-10-05  Lars Knoll  <lars@trolltech.com>
1972
1973         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
1974         Add support for layoutTextController.setCanOpenWindows() to DRT
1975         fixing another 2 test cases in fast/dom/Window.
1976
1977         Reviewed by Maciej.
1978
1979         * DumpRenderTree/qt/DumpRenderTree.cpp:
1980         (WebCore::WebPage::WebPage):
1981         (WebCore::WebPage::createWindow):
1982         (WebCore::DumpRenderTree::resetJSObjects):
1983         (WebCore::DumpRenderTree::createWindow):
1984         * DumpRenderTree/qt/DumpRenderTree.h:
1985         * DumpRenderTree/qt/DumpRenderTree.pro:
1986         * DumpRenderTree/qt/jsobjects.cpp:
1987         (LayoutTestController::LayoutTestController):
1988         (LayoutTestController::reset):
1989         * DumpRenderTree/qt/jsobjects.h:
1990         * DumpRenderTree/qt/main.cpp:
1991         * DumpRenderTree/qt/testplugin.cpp: Added.
1992         * DumpRenderTree/qt/testplugin.h: Added.
1993
1994 2007-10-04  Sam Weinig  <sam@webkit.org>
1995
1996         Rubber stamped by Adam.
1997
1998         Remove empty directories.
1999
2000         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2001         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2002
2003 2007-10-03  Darin Adler  <darin@apple.com>
2004
2005         Reviewed by Adam.
2006
2007         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2008         we find the internal libraries in the libraries directory. This
2009         is helpful for Safari team engineers at Apple.
2010
2011 2007-10-03  Adam Roben  <aroben@apple.com>
2012
2013         Update the location of AHEM___.TTF after r25968
2014
2015         Reviewed by Sam.
2016
2017         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2018
2019 2007-10-03  Alp Toker  <alp@atoker.com>
2020
2021         Reviewed by Adam.
2022
2023         http://bugs.webkit.org/show_bug.cgi?id=14726
2024         [gtk] API design. Mapping the WebView delegates to signals.
2025
2026         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2027
2028         * GtkLauncher/main.cpp:
2029         (goToURLBarText):
2030         (titleChanged):
2031         (progressChanged):
2032         (menuMainBackCallback):
2033         (menuMainForwardCallback):
2034         (main):
2035
2036 2007-10-03  Lars Knoll  <lars@trolltech.com>
2037
2038         Reviewed by Rob.
2039
2040         This fixes --strict mode in run-webkit-tests again after
2041         the platform dependent test results have been moved.
2042
2043         * Scripts/run-webkit-tests:
2044
2045 2007-10-03  Lars Knoll  <lars@trolltech.com>
2046
2047         Reviewed by bdash.
2048
2049         remove the hack in run-webkit-tests that forced text only test
2050         to be taken from the platform independent dir. It was only left
2051         there from early days.
2052         
2053         Remove platform dependent results for tests that are text only nowadays,
2054         and add one platform dependent result for a text only test that requires it.
2055
2056         * Scripts/run-webkit-tests:
2057
2058 2007-10-03  Lars Knoll  <lars@trolltech.com>
2059
2060         Reviewed by olliej.
2061
2062         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2063
2064         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2065         (WebCore::WebFrame::WebFrame):
2066         (WebCore::WebPage::WebPage):
2067         (WebCore::WebPage::createFrame):
2068         (WebCore::WebPage::javaScriptAlert):
2069         (WebCore::WebPage::javaScriptConsoleMessage):
2070         (WebCore::DumpRenderTree::DumpRenderTree):
2071         (WebCore::DumpRenderTree::~DumpRenderTree):
2072         (WebCore::DumpRenderTree::open):
2073         (WebCore::DumpRenderTree::readStdin):
2074         (WebCore::DumpRenderTree::resetJSObjects):
2075         (WebCore::DumpRenderTree::initJSObjects):
2076         (WebCore::DumpRenderTree::dumpFramesAsText):
2077         (WebCore::DumpRenderTree::dump):
2078         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2079         (WebCore::DumpRenderTree::layoutTestController):
2080         (WebCore::DumpRenderTree::eventSender):
2081         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2082         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2083         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2084         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2085         (HackWebFrame::mousePressEvent):
2086         (HackWebFrame::mouseReleaseEvent):
2087         (HackWebFrame::mouseMoveEvent):
2088         (HackWebFrame::HackWebFrame):
2089         (HackWebFrame::~HackWebFrame):
2090         (LayoutTestController::LayoutTestController):
2091         (LayoutTestController::reset):
2092         (LayoutTestController::maybeDump):
2093         (LayoutTestController::waitUntilDone):
2094         (LayoutTestController::notifyDone):
2095         (LayoutTestController::dumpEditingCallbacks):
2096         (LayoutTestController::queueReload):
2097         (LayoutTestController::provisionalLoad):
2098         (LayoutTestController::timerEvent):
2099         (EventSender::EventSender):
2100         (EventSender::mouseDown):
2101         (EventSender::mouseUp):
2102         (EventSender::mouseMoveTo):
2103         (EventSender::leapForward):
2104         (EventSender::keyDown):
2105         (EventSender::frameUnderMouse):
2106         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2107         (LayoutTestController::isLoading):
2108         (LayoutTestController::setLoading):
2109         (LayoutTestController::shouldDumpAsText):
2110         (LayoutTestController::shouldDumpChildrenAsText):
2111         (LayoutTestController::shouldWaitUntilDone):
2112         (LayoutTestController::dumpAsText):
2113         (LayoutTestController::dumpChildFramesAsText):
2114         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2115         (messageHandler):
2116         (crashHandler):
2117         (main):
2118         * Scripts/run-webkit-tests:
2119
2120 2007-10-03  Mark Rowe  <mrowe@apple.com>
2121
2122         Reviewed by Alp Toker.
2123
2124         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2125         should take precedence over QTDIR when determining which port we are working with.
2126
2127         * Scripts/webkitdirs.pm: 
2128
2129 2007-10-02  Adam Roben  <aroben@apple.com>
2130
2131         Add keychain to the list of default packages to install
2132
2133         Rubberstamped by Sam.
2134
2135         * CygwinDownloader/cygwin-downloader.py:
2136         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2137
2138 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2139
2140         Reviewed by Adam.
2141
2142         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2143         Also makes WebCore regression test case logic work when using git.
2144
2145         * Scripts/prepare-ChangeLog:
2146         (reviewerAndDescriptionForGitCommit): Added.
2147
2148 2007-10-02  Lars Knoll  <lars@trolltech.com>
2149
2150         Reviewed by bdash.
2151
2152         Add API to retrieve the frame name from QWebFrame.
2153         Implement support for DRT::dumpChildrenAsText.
2154
2155         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2156         (WebCore::DumpRenderTree::dumpFramesAsText):
2157         (WebCore::DumpRenderTree::dump):
2158         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2159         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2160         (LayoutTestController::LayoutTestController):
2161         (LayoutTestController::reset):
2162         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2163
2164 2007-10-02  Lars Knoll  <lars@trolltech.com>
2165
2166         Reviewed by bdash.
2167
2168         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2169
2170         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2171         (WebCore::DumpRenderTree::readStdin):
2172
2173 2007-10-02  Mark Rowe  <mrowe@apple.com>
2174
2175         Reviewed by Oliver.
2176
2177         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2178
2179         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2180         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2181
2182 2007-10-02  Mark Rowe  <mrowe@apple.com>
2183
2184         Rubber-stamped by Maciej.
2185
2186         Configuration changes from build.webkit.org.  The major change is refactoring to work
2187         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2188         last few weeks.
2189
2190         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2191         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2192         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2193         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2194         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2195         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2196         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2197         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2198
2199 2007-10-02  Lars Knoll  <lars@trolltech.com>
2200
2201         Reviewed by Maciej.
2202
2203         Add support for eventSender.mouseMove to DRT.
2204         Fixes fast/css/hover-affects-child.html
2205
2206         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2207         (EventSender::mouseMoveTo):
2208
2209 2007-10-01  Mark Rowe  <mrowe@apple.com>
2210
2211         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2212
2213 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
2214
2215         Reviewed by Hyatt.
2216
2217         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
2218
2219         * Scripts/svn-apply:
2220         (gitdiff2svndiff): Ignore lines beginning with "new file".
2221         * Scripts/svn-unapply:
2222         (gitdiff2svndiff): Ditto.
2223
2224 2007-09-30  George Staikos  <staikos@kde.org>
2225
2226         Qt build fix (Mac OS X specific)
2227
2228         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2229
2230 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2231
2232         Reviewed by Mark.
2233
2234         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
2235         Remove Bakefiles from svn.
2236
2237         * GtkLauncher/Bakefiles.bkgen: Removed.
2238         * GtkLauncher/ENV: Removed.
2239         * GtkLauncher/gdklauncher.bkl: Removed.
2240         * GtkLauncher/mk: Removed.
2241         * Scripts/regenerate-makefiles: Removed.
2242
2243 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
2244
2245         Reviewed by John.
2246
2247         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
2248
2249         * Scripts/run-webkit-tests:
2250
2251 2007-09-26  Adam Roben  <aroben@apple.com>
2252
2253         Make not finding an installed WebKit non-fatal
2254
2255         What really matters is that we are able to load WebKit and its
2256         dependencies, not whether we think we've found an installed WebKit.
2257
2258         Reviewed by Sam.
2259
2260         * WebKitInitializer/WebKitInitializer.cpp:
2261         (getWebViewCLSID): Use new LOG_WARNING macro.
2262         (getInstalledWebKitDirectory): Ditto.
2263         (initializeWebKit): Don't die if we didn't find an installed WebKit,
2264         and use new macros.
2265         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
2266
2267 2007-09-26  Adam Roben  <aroben@apple.com>
2268
2269         Committed this file before saving it
2270
2271         * WebKitInitializer/debug_internal.vsprops:
2272
2273 2007-09-26  Adam Roben  <aroben@apple.com>
2274
2275         Load WebKit and its dependencies manually so they come from DllDirectory
2276
2277         I had to change WebKitInitializer to use malloc/free instead of
2278         new/delete to avoid pulling in WebKit (and its dependencies) early
2279         through use of fastMalloc.
2280
2281         Reviewed by Oliver.
2282
2283         * WebKitInitializer/WebKitInitializer.cpp:
2284         (getStringValue): Changed to use malloc/free.
2285         (getInstalledWebKitDirectory): Ditto.
2286         (initializeWebKit): Call SetDllDirectory first, then load all of
2287         WebKit's dependencies manually, finally followed by WebKit itself.
2288         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
2289         configuration to match our other projects.
2290         * WebKitInitializer/debug_internal.vsprops: Added.
2291
2292 2007-09-25  Adam Roben  <aroben@apple.com>
2293
2294         Actually define DEBUG/NDEBUG so that we load WebKit correctly
2295
2296         Rubberstamped by Sam.
2297
2298         * WebKitInitializer/WebKitInitializer.vcproj:
2299
2300 2007-09-25  Adam Roben  <aroben@apple.com>
2301
2302         Make DumpRenderTree delay-load its dependencies
2303
2304         This lets WebKitInitializer re-route the dependencies to be loaded out
2305         of the Safari installation directory.
2306
2307         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
2308         same thing), since we can't import the kCFAllocatorDefault symbol when
2309         delay-loading CoreFoundation.dll.
2310
2311         Rubberstamped by Sam.
2312
2313         * DumpRenderTree/win/DumpRenderTree.cpp:
2314         (runTest):
2315         (javaScriptThreads):
2316         * DumpRenderTree/win/DumpRenderTree.vcproj:
2317         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2318         (LayoutTestController::setWaitToDump):
2319
2320 2007-09-25  Adam Roben  <aroben@apple.com>
2321
2322         Pull ole32.lib into WebKitInitializer
2323
2324         Rubberstamped by Sam.
2325
2326         * WebKitInitializer/WebKitInitializer.vcproj:
2327
2328 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2329
2330         Reviewed by Adam.
2331
2332         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
2333           LGPL'ed files contain incorrect FSF address
2334
2335         * Drosera/config.h:
2336
2337 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2338
2339         Reviewed by Adam.
2340
2341         Make svn-apply and svn-unapply work with git-diff formatted patches.
2342
2343         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
2344         (gitdiff2svndiff): Added.
2345         * Scripts/svn-unapply: Ditto.
2346         (gitdiff2svndiff): Added.
2347
2348 2007-09-25  Adam Roben  <aroben@apple.com>
2349
2350         Pull advapi32.lib into WebKitInitializer
2351
2352         This is needed to get the registry functions we use.
2353
2354         Rubberstamped by Sam.
2355
2356         * WebKitInitializer/WebKitInitializer.vcproj:
2357
2358 2007-09-25  Adam Roben  <aroben@apple.com>
2359
2360         Add python and rsync to cygwin-downloader
2361
2362         Our build slaves need this, and it can't hurt for everyone else to
2363         have it, too.
2364
2365         Reviewed by Sam.
2366
2367         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
2368         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2369
2370 2007-09-25  Adam Roben  <aroben@apple.com>
2371
2372         Add WebKitInitializer and use it in DumpRenderTree
2373
2374         WebKitInitializer is a static library that has one function,
2375         initializeWebKit(). This registers WebKit and sets up the DLL search
2376         path so that WebKit's dependencies that are installed with Safari can
2377         be found.
2378
2379         Reviewed by Sam.
2380
2381         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
2382         DumpRenderTree depend on it.
2383         * DumpRenderTree/win/DumpRenderTree.cpp:
2384         (initialize): Call initializeWebKit.
2385         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
2386         WebKitInitializer.lib.
2387         * WebKitInitializer/WebKitInitializer.cpp: Added.
2388         (getStringValue):
2389         (getWebViewCLSID):
2390         (getInstalledWebKitDirectory):
2391         (initializeWebKit):
2392         * WebKitInitializer/WebKitInitializer.h: Added.
2393         * WebKitInitializer/WebKitInitializer.vcproj: Added.
2394         * WebKitInitializer/debug.vsprops: Added.
2395         * WebKitInitializer/release.vsprops: Added.
2396
2397 2007-09-25  Adam Roben  <aroben@apple.com>
2398
2399         Make run-webkit-tests respect set-webkit-configuration
2400
2401         Reviewed by Sam.
2402
2403         * Scripts/run-webkit-tests: Initialize $configuration to whatever
2404         set-webkit-configuration was last set to.
2405
2406 2007-09-25  Mark Rowe  <mrowe@apple.com>
2407
2408         Rubber-stamped by Eric.
2409
2410         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2411         This makes it possible to automate nightly builds for the feature-branch.
2412
2413 2007-09-25  Adam Roben  <aroben@apple.com>
2414
2415         A couple of fixes/enhancements to update-webkit-*-libs
2416
2417         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
2418         to tell update-webkit-support-libraries where it should find the
2419         WebKitSupportLibrary.zip file you downloaded.
2420
2421         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
2422         Windows-style path.
2423
2424         Reviewed by Sam.
2425
2426         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
2427         to $auxiliaryLibsURL and removed an irrelevant comment.
2428         * Scripts/update-webkit-support-libs:
2429
2430 2007-09-25  Adam Treat  <treat@kde.org>
2431
2432         Reviewed by Simon and Lars.
2433
2434         Refactors and cleans up Qt DRT member variable names, member variable
2435         initialization, style fixes and general code cleanup.
2436
2437         Adds queueReload slot to LayoutTestController that some tests require.
2438
2439         Subclasses QWebFrame to make sure that all frames have an associated
2440         LayoutTestController JS window object.
2441
2442         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
2443         aren't dumped twice.
2444
2445         EOF fixes.
2446
2447         Together, this patch fixes some 20+ layout tests in QtWebKit.
2448
2449         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2450         (WebCore::WebFrame::WebFrame):
2451         (WebCore::WebPage::WebPage):
2452         (WebCore::WebPage::createFrame):
2453         (WebCore::DumpRenderTree::DumpRenderTree):
2454         (WebCore::DumpRenderTree::open):
2455         (WebCore::DumpRenderTree::readStdin):
2456         (WebCore::DumpRenderTree::initJSObjects):
2457         (WebCore::DumpRenderTree::dump):
2458         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2459         (WebCore::DumpRenderTree::layoutTestController):
2460         (WebCore::DumpRenderTree::eventSender):
2461         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2462         (LayoutTestController::LayoutTestController):
2463         (LayoutTestController::reset):
2464         (LayoutTestController::maybeDump):
2465         (LayoutTestController::waitUntilDone):
2466         (LayoutTestController::notifyDone):
2467         (LayoutTestController::queueReload):
2468         (LayoutTestController::provisionalLoad):
2469         (EventSender::EventSender):
2470         (EventSender::mouseDown):
2471         (EventSender::mouseUp):
2472         (EventSender::mouseMoveTo):
2473         (EventSender::frameUnderMouse):
2474         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2475         (LayoutTestController::isLoading):
2476         (LayoutTestController::setLoading):
2477         (LayoutTestController::dumpAsText):
2478         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2479         (main):
2480
2481 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2482
2483
2484         - Reverted an accidentally checked in file.
2485
2486         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
2487
2488 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2489         Reviewed by Sam.
2490
2491         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
2492
2493         * DumpRenderTree/win/DumpRenderTree.vcproj:
2494         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2495
2496 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2497
2498         Rubber stamped by Adam.
2499
2500         * GdkLauncher: Removed.
2501         * GdkLauncher/Bakefiles.bkgen: Removed.
2502         * GdkLauncher/ENV: Removed.
2503         * GdkLauncher/GdkLauncher.pro: Removed.
2504         * GdkLauncher/gdklauncher.bkl: Removed.
2505         * GdkLauncher/main.cpp: Removed.
2506         * GdkLauncher/mk: Removed.
2507         * GdkLauncher/simple.svg: Removed.
2508         * GdkLauncher/text.html: Removed.
2509         * GtkLauncher: Added.
2510         * GtkLauncher/GdkLauncher.pro: Removed.
2511         * GtkLauncher/GtkLauncher.pro: Added.
2512         * GtkLauncher/main.cpp:
2513         (updateWindowTitle):
2514         (main):
2515         * Scripts/build-webkit:
2516         * Scripts/regenerate-makefiles:
2517         * Scripts/run-javascriptcore-tests:
2518         * Scripts/run-launcher:
2519         * Scripts/run-webkit-tests:
2520         * Scripts/webkitdirs.pm:
2521
2522 2007-09-21  Timothy Hatcher  <timothy@apple.com>
2523
2524         Reviewed by Darin.
2525
2526         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
2527
2528         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
2529         This is tested by plugins/root-object-premature-delete-crash.html.
2530
2531         * DumpRenderTree/mac/ObjCController.m:
2532         (-[ObjCController accessStoredWebScriptObject]):
2533
2534 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
2535
2536         Reviewed by Oliver.
2537
2538         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
2539
2540         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2541         (FrameLoadDelegate::FrameLoadDelegate):
2542
2543 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
2544
2545         Reviewed by Adam.
2546
2547         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
2548         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
2549
2550         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
2551         Now isQt() and isGdk() use global variables that are only set once.
2552
2553         An array of all the parameters is now given to build-dumprender which includes
2554         the platform on linux.
2555
2556         * Scripts/build-dumprendertree:
2557         * Scripts/run-webkit-tests:
2558         * Scripts/webkitdirs.pm:
2559
2560 2007-09-19  Adam Roben  <aroben@apple.com>
2561
2562         Rubberstamped by Hyatt.
2563
2564         * Spinneret: Removed.
2565
2566 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
2567
2568         Reviewed by David Kilzer.
2569
2570         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
2571
2572 2007-09-18  Sam Weinig  <sam@webkit.org>
2573
2574         Add JSRetainPtr.h #include to fix some builds.
2575
2576         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2577
2578 2007-09-18  Mike Hommey  <glandium@debian.org>
2579
2580         Reviewed by Adam.
2581
2582         * Scripts/prepare-ChangeLog:
2583         - Properly parse GECOS field.
2584         - Use git configuration for user name and email when appropriate.
2585
2586 2007-09-17  Sam Weinig  <sam@webkit.org>
2587
2588         Build fix.
2589
2590         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2591
2592 2007-09-17  Sam Weinig  <sam@webkit.org>
2593
2594         Reviewed by Adam Roben.
2595
2596         Share more code between mac and windows DRT.
2597             - GCController is now shared.
2598             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
2599
2600         * DumpRenderTree/GCController.cpp:
2601         * DumpRenderTree/win/DumpRenderTree.cpp:
2602         * DumpRenderTree/win/DumpRenderTree.vcproj:
2603         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
2604         (FrameLoadDelegate::FrameLoadDelegate):
2605         (FrameLoadDelegate::~FrameLoadDelegate):
2606         (FrameLoadDelegate::windowScriptObjectAvailable):
2607         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
2608         * DumpRenderTree/win/GCController.cpp: Removed.
2609         * DumpRenderTree/win/GCController.h: Removed.
2610         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
2611         (GCController::collect):
2612         (GCController::collectOnAlternateThread):
2613         (GCController::getJSObjectCount):
2614         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
2615         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
2616
2617 2007-09-17  Sam Weinig  <sam@webkit.org>
2618
2619         Reviewed by Adam Roben.
2620
2621         Begin sharing code between mac and windows DRT.
2622             - both now share LayoutTestController.h/cpp and implement platform dependant 
2623               operations in LayoutTestControllerMac/Win.
2624             - DumpRenderTree.h is now shared.
2625             - WorkQueue and WorkQueueItem are also shared.
2626
2627         * DumpRenderTree/DumpRenderTree.h:
2628         * DumpRenderTree/LayoutTestController.cpp:
2629         * DumpRenderTree/win/DumpRenderTree.cpp:
2630         (displayWebView):
2631         (dumpFrameScrollPosition):
2632         (dumpFramesAsText):
2633         (dump):
2634         (runTest):
2635         * DumpRenderTree/win/DumpRenderTree.h: Removed.
2636         * DumpRenderTree/win/DumpRenderTree.vcproj:
2637         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
2638         * DumpRenderTree/win/EditingDelegate.cpp:
2639         (EditingDelegate::shouldBeginEditingInDOMRange):
2640         (EditingDelegate::shouldEndEditingInDOMRange):
2641         (EditingDelegate::shouldInsertNode):
2642         (EditingDelegate::shouldInsertText):
2643         (EditingDelegate::shouldDeleteDOMRange):
2644         (EditingDelegate::shouldChangeSelectedDOMRange):
2645         (EditingDelegate::shouldApplyStyle):
2646         (EditingDelegate::shouldChangeTypingStyle):
2647         (EditingDelegate::doPlatformCommand):
2648         (EditingDelegate::webViewDidBeginEditing):
2649         (EditingDelegate::webViewDidChange):
2650         (EditingDelegate::webViewDidEndEditing):
2651         (EditingDelegate::webViewDidChangeTypingStyle):
2652         (EditingDelegate::webViewDidChangeSelection):
2653         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2654         * DumpRenderTree/win/LayoutTestController.h: Removed.
2655         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2656         (LayoutTestController::addDisallowedURL):
2657         (LayoutTestController::clearBackForwardList):
2658         (LayoutTestController::copyDecodedHostName):
2659         (LayoutTestController::copyEncodedHostName):
2660         (LayoutTestController::display):
2661         (LayoutTestController::keepWebHistory):
2662         (LayoutTestController::notifyDone):
2663         (LayoutTestController::queueBackNavigation):
2664         (LayoutTestController::queueForwardNavigation):
2665         (jsStringRefToWString):
2666         (LayoutTestController::queueLoad):
2667         (LayoutTestController::queueReload):
2668         (LayoutTestController::queueScript):
2669         (LayoutTestController::setAcceptsEditing):
2670         (LayoutTestController::setCustomPolicyDelegate):
2671         (LayoutTestController::setMainFrameIsFirstResponder):
2672         (LayoutTestController::setTabKeyCyclesThroughElements):
2673         (LayoutTestController::setUseDashboardCompatibilityMode):
2674         (LayoutTestController::setUserStyleSheetEnabled):
2675         (LayoutTestController::setUserStyleSheetLocation):
2676         (LayoutTestController::setWindowIsKey):
2677         (waitUntilDoneWatchdogFired):
2678         (LayoutTestController::setWaitToDump):
2679         (LayoutTestController::windowCount):
2680         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2681         (FrameLoadDelegate::didReceiveTitle):
2682         (FrameLoadDelegate::processWork):
2683         (FrameLoadDelegate::locationChangeDone):
2684         (FrameLoadDelegate::windowScriptObjectAvailable):
2685         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2686         * DumpRenderTree/win/WorkQueue.h: Removed.
2687         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2688         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2689         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2690         (jsStringRefToWString):
2691         (LoadItem::invoke):
2692         (ScriptItem::invoke):
2693
2694 2007-09-17  Sam Weinig  <sam@webkit.org>
2695
2696         Reviewed by Adam Roben.
2697
2698         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2699
2700         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2701         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2702         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2703         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2704         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2705         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2706         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2707         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2708         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2709         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2710         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2711         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2712         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2713         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
2714         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
2715         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
2716         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
2717         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
2718         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
2719         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
2720         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
2721         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
2722         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
2723         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
2724         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
2725         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
2726         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
2727         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
2728         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2729         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2730         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2731         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
2732         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
2733         * DumpRenderTree/win: Added.
2734         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
2735         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
2736         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
2737         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
2738         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
2739         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
2740         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
2741         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
2742         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
2743         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
2744         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
2745         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
2746         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
2747         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2748         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
2749         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
2750         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
2751         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
2752         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2753         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2754         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
2755         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2756         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
2757         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
2758         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
2759         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
2760
2761 2007-09-15  Mark Rowe  <mrowe@apple.com>
2762
2763         Build fix for DumpRenderTree.
2764
2765         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
2766
2767 2007-09-14  Sam Weinig  <sam@webkit.org>
2768
2769         Rubber stamped by Adam Roben.
2770
2771         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
2772           - The UIDelegate was put into a new file while the FrameLoadDelegate was
2773             kept in the WaitUntilDoneDelegate file for the time being.
2774
2775         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2776         (main):
2777         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
2778         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
2779         (UIDelegate::QueryInterface):
2780         (UIDelegate::AddRef):
2781         (UIDelegate::Release):
2782         (UIDelegate::hasCustomMenuImplementation):
2783         (UIDelegate::setFrame):
2784         (UIDelegate::webViewFrame):
2785         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2786         (UIDelegate::webViewAddMessageToConsole):
2787         (UIDelegate::doDragDrop):
2788         (UIDelegate::webViewGetDlgCode):
2789         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
2790         (UIDelegate::UIDelegate):
2791         (UIDelegate::createWebViewWithRequest):
2792         (UIDelegate::webViewShow):
2793         (UIDelegate::webViewClose):
2794         (UIDelegate::webViewFocus):
2795         (UIDelegate::webViewUnfocus):
2796         (UIDelegate::webViewFirstResponder):
2797         (UIDelegate::makeFirstResponder):
2798         (UIDelegate::setStatusText):
2799         (UIDelegate::webViewStatusText):
2800         (UIDelegate::webViewAreToolbarsVisible):
2801         (UIDelegate::setToolbarsVisible):
2802         (UIDelegate::webViewIsStatusBarVisible):
2803         (UIDelegate::setStatusBarVisible):
2804         (UIDelegate::webViewIsResizable):
2805         (UIDelegate::setResizable):
2806         (UIDelegate::setContentRect):
2807         (UIDelegate::webViewContentRect):
2808         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2809         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2810         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2811         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
2812         (UIDelegate::mouseDidMoveOverElement):
2813         (UIDelegate::contextMenuItemsForElement):
2814         (UIDelegate::validateUserInterfaceItem):
2815         (UIDelegate::shouldPerformAction):
2816         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
2817         (UIDelegate::willPerformDragDestinationAction):
2818         (UIDelegate::dragSourceActionMaskForPoint):
2819         (UIDelegate::willPerformDragSourceAction):
2820         (UIDelegate::contextMenuItemSelected):
2821         (UIDelegate::trackCustomPopupMenu):
2822         (UIDelegate::measureCustomMenuItem):
2823         (UIDelegate::drawCustomMenuItem):
2824         (UIDelegate::addCustomMenuDrawingData):
2825         (UIDelegate::cleanUpCustomMenuDrawingData):
2826         (UIDelegate::canTakeFocus):
2827         (UIDelegate::takeFocus):
2828         (UIDelegate::registerUndoWithTarget):
2829         (UIDelegate::removeAllActionsWithTarget):
2830         (UIDelegate::setActionTitle):
2831         (UIDelegate::undo):
2832         (UIDelegate::redo):
2833         (UIDelegate::canUndo):
2834         (UIDelegate::canRedo):
2835         (UIDelegate::webViewResizerRect):
2836         (UIDelegate::webViewDrawResizer):
2837         (UIDelegate::webViewScrolled):
2838         (UIDelegate::webViewShouldInterruptJavaScript):
2839         (UIDelegate::webViewReceivedFocus):
2840         (UIDelegate::webViewLostFocus):
2841         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
2842         (FrameLoadDelegate::QueryInterface):
2843         (FrameLoadDelegate::AddRef):
2844         (FrameLoadDelegate::Release):
2845         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2846         (FrameLoadDelegate::didCommitLoadForFrame):
2847         (FrameLoadDelegate::didReceiveTitle):
2848         (FrameLoadDelegate::processWork):
2849         (processWorkTimer):
2850         (FrameLoadDelegate::locationChangeDone):
2851         (FrameLoadDelegate::didFinishLoadForFrame):
2852         (FrameLoadDelegate::didFailLoadWithError):
2853         (FrameLoadDelegate::windowScriptObjectAvailable):
2854         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
2855         (FrameLoadDelegate::FrameLoadDelegate):
2856
2857 2007-09-14  Sam Weinig  <sam@webkit.org>
2858
2859         Reviewed by Kevin McCullough.
2860
2861         Move mac specific globals in to mac/DumpRenderTreeMac.h
2862
2863         * DumpRenderTree/DumpRenderTree.h:
2864         * DumpRenderTree/DumpRenderTree.mm: Removed.
2865         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2866         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
2867         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
2868
2869 2007-09-14  Brady Eidson  <beidson@apple.com>
2870
2871         Rubberstamped by Weinig
2872
2873         You know, Sam, some of us use case-sensitve filesystems...
2874
2875         * DumpRenderTree/DumpRenderTree.h:
2876         * DumpRenderTree/mac/UIDelegate.mm:
2877
2878 2007-09-14  Sam Weinig  <sam@webkit.org>
2879
2880         Rubber stamped by Adam Roben.
2881
2882         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
2883         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
2884
2885         * DumpRenderTree/AppleScriptController.h: Removed.
2886         * DumpRenderTree/AppleScriptController.m: Removed.
2887         * DumpRenderTree/DumpRenderTree.h:
2888         * DumpRenderTree/DumpRenderTree.mm:
2889         (startJavaScriptThreads):
2890         (stopJavaScriptThreads):
2891         (activateAhemFont):
2892         (setDefaultColorProfileToRGB):
2893         (makeLargeMallocFailSilently):
2894         (dumpFrameScrollPosition):
2895         (dumpFramesAsText):
2896         (dump):
2897         (runTest):
2898         (-[DumpRenderTreeWindow isKeyWindow]):
2899         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2900         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
2901         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
2902         * DumpRenderTree/EditingDelegate.h: Removed.
2903         * DumpRenderTree/EditingDelegate.m: Removed.
2904         * DumpRenderTree/EventSendingController.h: Removed.
2905         * DumpRenderTree/EventSendingController.m: Removed.
2906         * DumpRenderTree/FrameLoadDelegate.h: Removed.
2907         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
2908         * DumpRenderTree/GCController.mm: Removed.
2909         * DumpRenderTree/ImageDiff.m: Removed.
2910         * DumpRenderTree/LayoutTestController.cpp:
2911         (LayoutTestController::LayoutTestController):
2912         (dumpAsTextCallback):
2913         (dumpBackForwardListCallback):
2914         (dumpChildFramesAsTextCallback):
2915         (dumpChildFrameScrollPositionsCallback):
2916         (dumpDOMAsWebArchiveCallback):
2917         (dumpEditingCallbacksCallback):
2918         (dumpFrameLoadCallbacksCallback):
2919         (dumpResourceLoadCallbacksCallback):
2920         (dumpSelectionRectCallback):
2921         (dumpSourceAsWebArchiveCallback):
2922         (dumpTitleChangesCallback):
2923         (repaintSweepHorizontallyCallback):
2924         (setCallCloseOnWebViewsCallback):
2925         (setCanOpenWindowsCallback):
2926         (setCloseRemainingWindowsWhenCompleteCallback):
2927         (testRepaintCallback):
2928         (addFileToPasteboardOnDragCallback):
2929         (waitUntilDoneCallback):
2930         * DumpRenderTree/LayoutTestController.h:
2931         (LayoutTestController::dumpAsText):
2932         (LayoutTestController::setDumpAsText):
2933         (LayoutTestController::dumpBackForwardList):
2934         (LayoutTestController::setDumpBackForwardList):
2935         (LayoutTestController::dumpChildFrameScrollPositions):
2936         (LayoutTestController::setDumpChildFrameScrollPositions):
2937         (LayoutTestController::dumpChildFramesAsText):
2938         (LayoutTestController::setDumpChildFramesAsText):
2939         (LayoutTestController::dumpDOMAsWebArchive):
2940         (LayoutTestController::setDumpDOMAsWebArchive):
2941         (LayoutTestController::dumpSelectionRect):
2942         (LayoutTestController::setDumpSelectionRect):
2943         (LayoutTestController::dumpSourceAsWebArchive):
2944         (LayoutTestController::setDumpSourceAsWebArchive):
2945         (LayoutTestController::dumpTitleChanges):
2946         (LayoutTestController::setDumpTitleChanges):
2947         (LayoutTestController::dumpEditingCallbacks):
2948         (LayoutTestController::setDumpEditingCallbacks):
2949         (LayoutTestController::dumpResourceLoadCallbacks):
2950         (LayoutTestController::setDumpResourceLoadCallbacks):
2951         (LayoutTestController::dumpFrameLoadCallbacks):
2952         (LayoutTestController::setDumpFrameLoadCallbacks):
2953         (LayoutTestController::addFileToPasteboardOnDrag):
2954         (LayoutTestController::setAddFileToPasteboardOnDrag):
2955         (LayoutTestController::callCloseOnWebViews):
2956         (LayoutTestController::setCallCloseOnWebViews):
2957         (LayoutTestController::canOpenWindows):
2958         (LayoutTestController::setCanOpenWindows):
2959         (LayoutTestController::closeRemainingWindowsWhenComplete):
2960         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2961         (LayoutTestController::testRepaint):
2962         (LayoutTestController::setTestRepaint):
2963         (LayoutTestController::testRepaintSweepHorizontally):
2964         (LayoutTestController::setTestRepaintSweepHorizontally):
2965         (LayoutTestController::waitToDump):
2966         (LayoutTestController::windowIsKey):
2967         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
2968         * DumpRenderTree/NavigationController.h: Removed.
2969         * DumpRenderTree/NavigationController.m: Removed.
2970         * DumpRenderTree/ObjCController.h: Removed.
2971         * DumpRenderTree/ObjCController.m: Removed.
2972         * DumpRenderTree/ObjCPlugin.h: Removed.
2973         * DumpRenderTree/ObjCPlugin.m: Removed.
2974         * DumpRenderTree/ObjCPluginFunction.h: Removed.
2975         * DumpRenderTree/ObjCPluginFunction.m: Removed.
2976         * DumpRenderTree/PolicyDelegate.h: Removed.
2977         * DumpRenderTree/PolicyDelegate.m: Removed.
2978         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
2979         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
2980         * DumpRenderTree/TextInputController.h: Removed.
2981         * DumpRenderTree/TextInputController.m: Removed.
2982         * DumpRenderTree/UIDelegate.h: Removed.
2983         * DumpRenderTree/UIDelegate.mm: Removed.
2984         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
2985         * DumpRenderTree/mac: Added.
2986         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
2987         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
2988         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
2989         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
2990         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
2991         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
2992         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2993         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2994         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2995         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2996         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2997         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2998         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2999         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3000         (-[EditingDelegate webViewDidBeginEditing:]):
3001         (-[EditingDelegate webViewDidChange:]):
3002         (-[EditingDelegate webViewDidEndEditing:]):
3003         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3004         (-[EditingDelegate webViewDidChangeSelection:]):
3005         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
3006         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
3007         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
3008         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
3009         (-[FrameLoadDelegate init]):
3010         (-[FrameLoadDelegate dealloc]):
3011         (-[FrameLoadDelegate processWork:]):
3012         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3013         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3014         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3015         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3016         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3017         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3018         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3019         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3020         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3021         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3022         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3023         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3024         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3025         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3026         (-[FrameLoadDelegate webView:willCloseFrame:]):
3027         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3028         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3029         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
3030         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
3031         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
3032         (LayoutTestController::notifyDone):
3033         (LayoutTestController::setWindowIsKey):
3034         (LayoutTestController::setWaitToDump):
3035         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
3036         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
3037         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
3038         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
3039         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
3040         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
3041         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
3042         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
3043         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
3044         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
3045         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
3046         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
3047         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3048         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3049         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3050         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3051         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3052         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3053         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
3054         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
3055         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
3056         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
3057         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
3058         (-[UIDelegate webViewFocus:]):
3059         (-[UIDelegate webView:createWebViewWithRequest:]):
3060         (-[UIDelegate webViewClose:]):
3061         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
3062
3063 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
3064
3065         Reviewed by Adam.
3066
3067         - Changing Win version of Drosera work with recent changes.
3068
3069         * Drosera/DebuggerDocument.cpp:
3070         * Drosera/DebuggerDocument.h:
3071         * Drosera/mac/DebuggerDocumentPlatform.mm:
3072         (NSStringCreateWithJSStringRef):
3073         (JSValueRefCreateWithNSString):
3074         * Drosera/win/DebuggerClient.cpp:
3075         (DebuggerClient::stepInto):
3076         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3077
3078 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
3079
3080         Reviewed by Tim.
3081
3082         - Moved isPaused into the JS for efficiency and simplicity.
3083
3084         * Drosera/DebuggerDocument.cpp:
3085         (DebuggerDocument::DebuggerDocument):
3086         (DebuggerDocument::pauseCallback):
3087         (DebuggerDocument::resumeCallback):
3088         (DebuggerDocument::isPaused):
3089         (DebuggerDocument::staticFunctions):
3090         * Drosera/DebuggerDocument.h:
3091         * Drosera/console.js:
3092         * Drosera/debugger.js:
3093         * Drosera/mac/DebuggerClient.mm:
3094         (-[DebuggerClient validateUserInterfaceItem:]):
3095
3096 2007-09-13  Sam Weinig  <sam@webkit.org>
3097
3098         Rubber stamped by Darin.
3099
3100         Make DumpRenderTree more cross platform ready.
3101         - Convert GCController to use the JSCore API instead of the WebScriptObject.
3102         - Use CF types instead of NS objects.
3103         - General cleanup.
3104
3105         * DumpRenderTree/DumpRenderTree.h:
3106         * DumpRenderTree/DumpRenderTree.mm:
3107         (dumpRenderTree):
3108         (dump):
3109         (runTest):
3110         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3111         * DumpRenderTree/EditingDelegate.m:
3112         * DumpRenderTree/FrameLoadDelegate.h:
3113         * DumpRenderTree/FrameLoadDelegate.mm:
3114         (-[FrameLoadDelegate init]):
3115         (-[FrameLoadDelegate dealloc]):
3116         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3117         * DumpRenderTree/GCController.cpp: Added.
3118         (GCController::GCController):
3119         (GCController::~GCController):
3120         (collectCallback):
3121         (collectOnAlternateThreadCallback):
3122         (getJSObjectCountCallback):
3123         (GCController::makeWindowObject):
3124         (GCController::getJSClass):
3125         (GCController::staticFunctions):
3126         * DumpRenderTree/GCController.h:
3127         * DumpRenderTree/GCController.mm:
3128         (GCController::collect):
3129         (GCController::collectOnAlternateThread):
3130         (GCController::getJSObjectCount):
3131         * DumpRenderTree/LayoutTestController.cpp:
3132         (LayoutTestController::makeWindowObject):
3133         (LayoutTestController::getJSClass):
3134         * DumpRenderTree/LayoutTestController.h:
3135         * DumpRenderTree/LayoutTestControllerMac.mm:
3136         (LayoutTestController::addDisallowedURL):
3137         (waitUntilDoneWatchdogFired):
3138         (LayoutTestController::waitUntilDone):
3139         * DumpRenderTree/ResourceLoadDelegate.m:
3140         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3141
3142 2007-09-12  Sam Weinig  <sam@webkit.org>
3143
3144         Reviewed by Stephanie.
3145
3146         Fix leaks in mac DumpRenderTree.
3147
3148         * DumpRenderTree/FrameLoadDelegate.mm:
3149         (-[FrameLoadDelegate init]): Initalize in the correct order.
3150         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
3151         * DumpRenderTree/LayoutTestController.cpp:
3152         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
3153         (encodeHostNameCallback): ditto.
3154         * DumpRenderTree/LayoutTestController.h:
3155         * DumpRenderTree/LayoutTestControllerMac.mm:
3156         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
3157         (LayoutTestController::copyEncodedHostName): ditto
3158         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
3159
3160 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3161
3162         Reviewed by Geof.
3163
3164         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
3165
3166         * Scripts/run-webkit-tests:
3167
3168 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3169
3170         Reviewed by Darin.
3171
3172         - Simplified code paths and extracted out functions to increase encapsulation.
3173
3174         * Drosera/DebuggerDocument.cpp:
3175         (DebuggerDocument::breakpointEditorHTMLCallback):
3176         (DebuggerDocument::isPausedCallback):
3177         (DebuggerDocument::pauseCallback):
3178         (DebuggerDocument::resumeCallback):
3179         (DebuggerDocument::stepIntoCallback):
3180         (DebuggerDocument::evaluateScriptCallback):
3181         (DebuggerDocument::currentFunctionStackCallback):
3182         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3183         (DebuggerDocument::valueForScopeVariableNamedCallback):
3184         (DebuggerDocument::logCallback):
3185         * Drosera/DebuggerDocument.h:
3186         (DebuggerDocument::getPaused):
3187         * Drosera/mac/DebuggerClient.mm:
3188         (-[DebuggerClient pause:]):
3189         (-[DebuggerClient resume:]):
3190         (-[DebuggerClient stepInto:]):
3191         (-[DebuggerClient stepOver:]):
3192         (-[DebuggerClient stepOut:]):
3193         (-[DebuggerClient showConsole:]):
3194         (-[DebuggerClient closeCurrentFile:]):
3195         (-[DebuggerClient validateUserInterfaceItem:]):
3196         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
3197         (+[NSString stringOrNilFromWebScriptResult:]):
3198         (DebuggerDocument::platformPause):
3199         (DebuggerDocument::platformResume):
3200         (DebuggerDocument::platformStepInto):
3201         (DebuggerDocument::platformEvaluateScript):
3202         (DebuggerDocument::getPlatformCurrentFunctionStack):
3203         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3204         (DebuggerDocument::platformValueForScopeVariableNamed):
3205         (DebuggerDocument::platformLog):
3206         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3207
3208 2007-09-12  Sam Weinig  <sam@webkit.org>
3209
3210         Build fix for Buildbot.
3211
3212         * DumpRenderTree/DumpRenderTree.mm:
3213         (dump):
3214
3215 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3216
3217         Reviewed by Geoff.
3218
3219         - Updated the leaks list for leopard to help identify regressions.
3220
3221         * Scripts/run-webkit-tests:
3222
3223 2007-09-12  Sam Weinig  <sam@webkit.org>
3224
3225         Rubber stamped by Darin.
3226
3227         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
3228
3229         * DumpRenderTree/DumpRenderTree.h: Re-order variables. 
3230         * DumpRenderTree/DumpRenderTree.m: Removed.
3231         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
3232         (stopJavaScriptThreads): Fix initialization.
3233         (setDefaultColorProfileToRGB): Add explicit cast from void*.
3234         (dumpRenderTree): Ditto.
3235         (runTest):
3236         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
3237
3238         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3239         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
3240         * DumpRenderTree/FrameLoadDelegate.m: Removed.
3241         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
3242         (-[FrameLoadDelegate init]):
3243         (-[FrameLoadDelegate dealloc]):
3244         (-[FrameLoadDelegate processWork:]):
3245         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3246         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3247         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
3248         
3249         * DumpRenderTree/LayoutTestController.cpp: Added.
3250         (LayoutTestController::LayoutTestController):
3251         (LayoutTestController::~LayoutTestController):
3252         (dumpAsTextCallback):
3253         (dumpBackForwardListCallback):
3254         (dumpChildFramesAsTextCallback):
3255         (dumpChildFrameScrollPositionsCallback):
3256         (dumpDOMAsWebArchiveCallback):
3257         (dumpEditingCallbacksCallback):
3258         (dumpFrameLoadCallbacksCallback):
3259         (dumpResourceLoadCallbacksCallback):
3260         (dumpSelectionRectCallback):
3261         (dumpSourceAsWebArchiveCallback):
3262         (dumpTitleChangesCallback):
3263         (repaintSweepHorizontallyCallback):
3264         (setCallCloseOnWebViewsCallback):
3265         (setCanOpenWindowsCallback):
3266         (setCloseRemainingWindowsWhenCompleteCallback):
3267         (testRepaintCallback):
3268         (addFileToPasteboardOnDragCallback):
3269         (addDisallowedURLCallback):
3270         (clearBackForwardListCallback):
3271         (decodeHostNameCallback):
3272         (displayCallback):
3273         (encodeHostNameCallback):
3274         (keepWebHistoryCallback):
3275         (notifyDoneCallback):
3276         (queueBackNavigationCallback):
3277         (queueForwardNavigationCallback):
3278         (queueLoadCallback):
3279         (queueReloadCallback):
3280         (queueScriptCallback):
3281         (setAcceptsEditingCallback):
3282         (setCustomPolicyDelegateCallback):
3283         (setMainFrameIsFirstResponderCallback):
3284         (setTabKeyCyclesThroughElementsCallback):
3285         (setUseDashboardCompatibilityModeCallback):
3286         (setUserStyleSheetEnabledCallback):
3287         (setUserStyleSheetLocationCallback):
3288         (setWindowIsKeyCallback):
3289         (waitUntilDoneCallback):
3290         (windowCountCallback):
3291         (LayoutTestController::makeWindowObject):
3292         (LayoutTestController::getLayoutTestControllerJSClass):
3293         (LayoutTestController::staticFunctions):
3294         * DumpRenderTree/LayoutTestController.h: Replaced.
3295         * DumpRenderTree/LayoutTestController.m: Removed.
3296         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
3297         (LayoutTestController::dumpAsText):
3298         (LayoutTestController::dumpBackForwardList):
3299         (LayoutTestController::dumpChildFramesAsText):
3300         (LayoutTestController::dumpChildFrameScrollPositions):
3301         (LayoutTestController::dumpDOMAsWebArchive):
3302         (LayoutTestController::dumpEditingCallbacks):
3303         (LayoutTestController::dumpFrameLoadCallbacks):
3304         (LayoutTestController::dumpResourceLoadCallbacks):
3305         (LayoutTestController::dumpSelectionRect):
3306         (LayoutTestController::dumpSourceAsWebArchive):
3307         (LayoutTestController::dumpTitleChanges):
3308         (LayoutTestController::repaintSweepHorizontally):
3309         (LayoutTestController::setCallCloseOnWebViews):
3310         (LayoutTestController::setCanOpenWindows):
3311         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3312         (LayoutTestController::testRepaint):
3313         (LayoutTestController::addFileToPasteboardOnDrag):
3314         (LayoutTestController::addDisallowedURL):
3315         (LayoutTestController::clearBackForwardList):
3316         (LayoutTestController::decodeHostName):
3317         (LayoutTestController::encodeHostName):
3318         (LayoutTestController::display):
3319         (LayoutTestController::keepWebHistory):
3320         (LayoutTestController::notifyDone):
3321         (LayoutTestController::queueBackNavigation):
3322         (LayoutTestController::queueForwardNavigation):
3323         (LayoutTestController::queueLoad):
3324         (LayoutTestController::queueReload):
3325         (LayoutTestController::queueScript):
3326         (LayoutTestController::setAcceptsEditing):
3327         (LayoutTestController::setCustomPolicyDelegate):
3328         (LayoutTestController::setMainFrameIsFirstResponder):
3329         (LayoutTestController::setTabKeyCyclesThroughElements):
3330         (LayoutTestController::setUseDashboardCompatibilityMode):
3331         (LayoutTestController::setUserStyleSheetEnabled):
3332         (LayoutTestController::setUserStyleSheetLocation):
3333         (LayoutTestController::setWindowIsKey):
3334         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
3335         (LayoutTestController::waitUntilDone):
3336         (LayoutTestController::windowCount):
3337         Use the JSCore API to implement the LayoutTestController.
3338
3339         * DumpRenderTree/ObjCController.h:
3340         * DumpRenderTree/ObjCController.m:
3341         (+[ObjCController isSelectorExcludedFromWebScript:]):
3342         (+[ObjCController webScriptNameForSelector:]):
3343         (-[ObjCController accessStoredWebScriptObject]):
3344         (-[ObjCController storeWebScriptObject:]):
3345         (-[ObjCController dealloc]):
3346         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
3347         Move WebScriptObject tests to ObjCController.
3348
3349         * DumpRenderTree/UIDelegate.m: Removed.
3350         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
3351
3352         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3353         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3354         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3355         (WorkQueueItem::~WorkQueueItem):
3356         (LoadItem::LoadItem):
3357         (LoadItem::url):
3358         (LoadItem::target):
3359         (ScriptItem::ScriptItem):
3360         (ScriptItem::script):
3361         * DumpRenderTree/WorkQueueItemMac.mm: Added.
3362         (LoadItem::invoke):
3363         (ReloadItem::invoke):
3364         (ScriptItem::invoke):
3365         (BackForwardItem::invoke):
3366         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
3367         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
3368         sharing code.
3369
3370 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3371
3372         Reviewed by Maciej.
3373
3374         - Updated Win side to take advantage of the platform separating changes.
3375
3376         * Drosera/DebuggerDocument.cpp:
3377         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3378         * Drosera/DebuggerDocument.h:
3379         * Drosera/win/DebuggerClient.cpp:
3380         (DebuggerClient::pause):
3381         (DebuggerClient::resume):
3382         (DebuggerClient::stepInto):
3383         (DebuggerDocument::platformPause):
3384         (DebuggerDocument::platformResume):
3385         (DebuggerDocument::platformStepInto):
3386         (DebuggerDocument::platformEvaluateScript):
3387         (DebuggerDocument::getPlatformCurrentFunctionStack):
3388         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3389         (DebuggerDocument::platformValueForScopeVariableNamed):
3390         (DebuggerDocument::platformLog):
3391         * Drosera/win/DebuggerClient.h:
3392         * Drosera/win/Drosera.cpp:
3393         (Drosera::Drosera):
3394         (Drosera::windowScriptObjectAvailable):
3395         (Drosera::initWithServerName):
3396         (Drosera::switchToServerNamed):
3397         * Drosera/win/Drosera.h:
3398         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3399
3400 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3401
3402         Reviewed by Adam.
3403
3404         - Just doing the moves in a separate patch so the changes are easier to see.
3405
3406         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
3407         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
3408         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
3409         * Drosera/win/DebuggerDocumentWin.h: Removed.
3410         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3411
3412 2007-09-11  Sven Herzberg  <sven@imendio.com>
3413
3414         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
3415         http://bugs.webkit.org/show_bug.cgi?id=15176
3416
3417         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
3418         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
3419         other paths eg. from jhbuild)
3420
3421 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3422
3423         Reviewed by Adam.
3424
3425         - Made an order-of-deletion mistake.
3426
3427         * Drosera/DebuggerDocument.h:
3428         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
3429         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
3430         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
3431         * Drosera/mac/DebuggerClient.mm:
3432         (DebuggerDocument::platformPause):
3433         (DebuggerDocument::platformResume):
3434         (DebuggerDocument::platformStepInto):
3435         (DebuggerDocument::platformEvaluateScript):
3436         (DebuggerDocument::getPlatformCurrentFunctionStack):
3437         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3438         (DebuggerDocument::platformValueForScopeVariableNamed):
3439         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3440
3441 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3442
3443         Reviewed by Darin.
3444
3445         - Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
3446
3447         * Drosera/DebuggerDocument.cpp:
3448         (DebuggerDocument::DebuggerDocument):
3449         * Drosera/DebuggerDocument.h:
3450         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3451         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3452         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3453         * Drosera/mac/DebuggerApplication.mm:
3454         (-[DebuggerApplication attach:]):
3455         * Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
3456         * Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm.
3457         (DebuggerDocument::platformPause):
3458         (DebuggerDocument::platformResume):
3459         (DebuggerDocument::platformStepInto):
3460         (DebuggerDocument::platformEvaluateScript):
3461         (DebuggerDocument::getPlatformCurrentFunctionStack):
3462         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3463         (DebuggerDocument::platformValueForScopeVariableNamed):
3464         (DebuggerDocument::platformLog):
3465         * Drosera/mac/DebuggerDocumentMac.h: Removed.
3466         * Drosera/mac/DebuggerDocumentMac.mm: Removed.
3467         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3468
3469 2007-09-09  Sam Weinig  <sam@webkit.org>
3470
3471         Reviewed by Mark Rowe.
3472
3473         Remove 'objC' prefix from methods now in the ObjCController. 
3474
3475         * DumpRenderTree/ObjCController.m:
3476         (+[ObjCController isSelectorExcludedFromWebScript:]):
3477         (+[ObjCController webScriptNameForSelector:]):
3478         (-[ObjCController classNameOf:]):
3479         (-[ObjCController objectOfClass:]):
3480         (-[ObjCController identityIsEqual::]):
3481         (-[ObjCController longLongRoundTrip:]):
3482         (-[ObjCController unsignedLongLongRoundTrip:]):
3483
3484 2007-09-09  Sam Weinig  <sam@webkit.org>
3485
3486         Reviewed by Oliver.
3487
3488         Initial refactor of DumpRenderTree in preparation of making it more platform independent. 
3489         - Move LayoutTestController into its own file.
3490         - Move Objective-C only functions on LayoutTestController into a new controller called the
3491           ObjCController. 
3492
3493         * DumpRenderTree/DumpRenderTree.h:
3494         * DumpRenderTree/DumpRenderTree.m:
3495         (displayWebView):
3496         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3497         * DumpRenderTree/FrameLoadDelegate.m:
3498         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3499         * DumpRenderTree/LayoutTestController.h: Added.
3500         * DumpRenderTree/LayoutTestController.m: Added.
3501         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3502         (+[LayoutTestController webScriptNameForSelector:]):
3503         (-[LayoutTestController clearBackForwardList]):
3504         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
3505         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
3506         (-[LayoutTestController setCustomPolicyDelegate:]):
3507         (-[LayoutTestController keepWebHistory]):
3508         (-[LayoutTestController setCallCloseOnWebViews:]):
3509         (-[LayoutTestController setCanOpenWindows]):
3510         (-[LayoutTestController waitUntilDone]):
3511         (-[LayoutTestController waitUntilDoneWatchdogFired]):
3512         (-[LayoutTestController notifyDone]):
3513         (-[LayoutTestController dumpAsText]):
3514         (-[LayoutTestController addFileToPasteboardOnDrag]):
3515         (-[LayoutTestController addDisallowedURL:]):
3516         (-[LayoutTestController setUserStyleSheetLocation:]):
3517         (-[LayoutTestController setUserStyleSheetEnabled:]):
3518         (-[LayoutTestController dumpDOMAsWebArchive]):
3519         (-[LayoutTestController dumpSourceAsWebArchive]):
3520         (-[LayoutTestController dumpSelectionRect]):
3521         (-[LayoutTestController dumpTitleChanges]):
3522         (-[LayoutTestController dumpBackForwardList]):
3523         (-[LayoutTestController windowCount]):
3524         (-[LayoutTestController dumpChildFrameScrollPositions]):
3525         (-[LayoutTestController dumpChildFramesAsText]):
3526         (-[LayoutTestController dumpEditingCallbacks]):
3527         (-[LayoutTestController dumpResourceLoadCallbacks]):
3528         (-[LayoutTestController dumpFrameLoadCallbacks]):
3529         (-[LayoutTestController setWindowIsKey:]):
3530         (-[LayoutTestController setMainFrameIsFirstResponder:]):
3531         (-[LayoutTestController display]):
3532         (-[LayoutTestController testRepaint]):
3533         (-[LayoutTestController repaintSweepHorizontally]):
3534         (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
3535         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
3536         (-[LayoutTestController _doLoad:target:]):
3537         (-[LayoutTestController _doBackOrForwardNavigation:]):
3538         (-[LayoutTestController queueBackNavigation:]):
3539         (-[LayoutTestController queueForwardNavigation:]):
3540         (-[LayoutTestController queueReload]):
3541         (-[LayoutTestController queueScript:]):
3542         (-[LayoutTestController queueLoad:target:]):
3543         (-[LayoutTestController setAcceptsEditing:]):
3544         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
3545         (-[LayoutTestController storeWebScriptObject:]):
3546         (-[LayoutTestController accessStoredWebScriptObject]):
3547         (-[LayoutTestController dealloc]):
3548         (-[LayoutTestController decodeHostName:]):
3549         (-[LayoutTestController encodeHostName:]):
3550         * DumpRenderTree/ObjCController.h: Added.
3551         * DumpRenderTree/ObjCController.m: Added.
3552         (+[ObjCController isSelectorExcludedFromWebScript:]):
3553         (+[ObjCController webScriptNameForSelector:]):
3554         (-[ObjCController objCClassNameOf:]):
3555         (-[ObjCController objCObjectOfClass:]):
3556         (-[ObjCController objCIdentityIsEqual::]):
3557         (-[ObjCController objCLongLongRoundTrip:]):
3558         (-[ObjCController objCUnsignedLongLongRoundTrip:]):
3559         (-[ObjCController testWrapperRoundTripping:]):
3560
3561 2007-09-07  Sam Weinig  <sam@webkit.org>
3562
3563         Reviewed by Alice.
3564
3565         Strip trailing and leading space/newline characters from skiplist file names.
3566
3567         * Scripts/run-webkit-tests:
3568
3569 2007-09-06  Kevin McCullough  <kmccullough@apple.com>
3570
3571         Reviewed by Maciej.
3572
3573         - Changed Drosera to take advantage of the JSRetainPtr changes.
3574
3575         * Drosera/DebuggerDocument.cpp:
3576         (DebuggerDocument::breakpointEditorHTML):
3577         (DebuggerDocument::evaluateScript):
3578         (DebuggerDocument::valueForScopeVariableNamed):
3579         (DebuggerDocument::log):
3580         (DebuggerDocument::windowScriptObjectAvailable):
3581         (DebuggerDocument::toJSArray):
3582         (DebuggerDocument::callFunctionOnObject):
3583         (DebuggerDocument::logException):
3584         * Drosera/mac/DebuggerDocumentMac.mm:
3585         (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
3586         (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3587         (DebuggerDocument::platformEvaluateScript):
3588         (DebuggerDocument::getPlatformCurrentFunctionStack):
3589         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3590         (DebuggerDocument::platformValueForScopeVariableNamed):
3591
3592 2007-09-05  Kevin McCullough  <kmccullough@apple.com>
3593
3594         Reviewed by Adam, Sam, Darin.
3595
3596         - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.
3597
3598         * Drosera/Debugger.h: Added.
3599         * Drosera/DebuggerDocument.cpp:
3600         (DebuggerDocument::breakpointEditorHTMLCallback):
3601         (DebuggerDocument::isPausedCallback):
3602         (DebuggerDocument::pauseCallback):
3603         (DebuggerDocument::resumeCallback):
3604         (DebuggerDocument::stepIntoCallback):
3605         (DebuggerDocument::evaluateScriptCallback):
3606         (DebuggerDocument::currentFunctionStackCallback):
3607         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3608         (DebuggerDocument::valueForScopeVariableNamedCallback):
3609         (DebuggerDocument::logCallback):
3610         (DebuggerDocument::breakpointEditorHTML):
3611         (DebuggerDocument::isPaused):
3612         (DebuggerDocument::pause):
3613         (DebuggerDocument::resume):
3614         (DebuggerDocument::stepInto):
3615         (DebuggerDocument::evaluateScript):
3616         (DebuggerDocument::currentFunctionStack):
3617         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3618         (DebuggerDocument::valueForScopeVariableNamed):
3619         (DebuggerDocument::log):
3620         (DebuggerDocument::toolbarPause):
3621         (DebuggerDocument::toolbarResume):
3622         (DebuggerDocument::toolbarStepInto):
3623         (DebuggerDocument::toolbarStepOver):
3624         (DebuggerDocument::toolbarStepOut):
3625         (DebuggerDocument::toolbarShowConsole):
3626         (DebuggerDocument::toolbarCloseCurrentFile):
3627         (DebuggerDocument::updateFileSource):
3628         (DebuggerDocument::didParseScript):
3629         (DebuggerDocument::willExecuteStatement):
3630         (DebuggerDocument::didEnterCallFrame):
3631         (DebuggerDocument::willLeaveCallFrame):
3632         (DebuggerDocument::exceptionWasRaised):
3633         (DebuggerDocument::windowScriptObjectAvailable):
3634         (DebuggerDocument::toJSArray):
3635         (DebuggerDocument::callGlobalFunction):
3636         (DebuggerDocument::callFunctionOnObject):
3637         (DebuggerDocument::getDroseraJSClass):
3638         (DebuggerDocument::staticFunctions):
3639         (DebuggerDocument::logException):
3640         * Drosera/DebuggerDocument.h:
3641         (DebuggerDocument::DebuggerDocument):
3642         * Drosera/ForwardingHeaders: Added.
3643         * Drosera/ForwardingHeaders/wtf: Added.
3644         * Drosera/ForwardingHeaders/wtf/Platform.h: Added.
3645         * Drosera/config.h:
3646         * Drosera/console.html:
3647         * Drosera/console.js:
3648         * Drosera/debugger.js:
3649         * Drosera/mac/DebuggerApplication.mm:
3650         (-[DebuggerApplication attach:]):
3651         * Drosera/mac/DebuggerDocumentMac.h:
3652         * Drosera/mac/DebuggerDocumentMac.mm:
3653         (+[NSString stringOrNilFromWebScriptResult:]):
3654         (+[DebuggerClientMac log:]):
3655         (-[DebuggerClientMac initWithServerName:]):
3656         (-[DebuggerClientMac dealloc]):
3657         (-[DebuggerClientMac pause]):
3658         (-[DebuggerClientMac resume]):
3659         (-[DebuggerClientMac pause:]):
3660         (-[DebuggerClientMac resume:]):
3661         (-[DebuggerClientMac stepInto:]):
3662         (-[DebuggerClientMac stepOver:]):
3663         (-[DebuggerClientMac stepOut:]):
3664         (-[DebuggerClientMac showConsole:]):
3665         (-[DebuggerClientMac closeCurrentFile:]):
3666         (-[DebuggerClientMac validateUserInterfaceItem:]):
3667         (-[DebuggerClientMac webView:windowScriptObjectAvailable:]):
3668         (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3669         (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3670         (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3671         (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3672         (DebuggerDocument::platformPause):
3673         (DebuggerDocument::platformResume):
3674         (DebuggerDocument::platformStepInto):
3675         (DebuggerDocument::platformEvaluateScript):
3676         (DebuggerDocument::platformCurrentFunctionStack):
3677         (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame):
3678         (DebuggerDocument::platformValueForScopeVariableNamed):
3679         (DebuggerDocument::platformLog):
3680         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3681
3682 2007-09-06  Sam Weinig  <sam@webkit.org>
3683
3684         Reviewed by Adam Roben.
3685
3686         Register the WebKit DLL on initialization of the DumpRenderTree.
3687
3688         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3689         (initialize):
3690
3691 2007-09-05  Sam Weinig  <sam@webkit.org>
3692
3693         Reviewed by Oliver.
3694
3695         Fix many layout test failures caused by r25364.
3696         Set text size to standand size at the begining of each test matching the mac.
3697
3698         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3699         (runTest):
3700
3701 2007-09-04  Sam Weinig  <sam@webkit.org>
3702
3703         Reviewed by Adam.
3704
3705         Fix for <rdar://problem/5382277>
3706         Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.
3707
3708         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
3709         (textZoomInCallback):
3710         (textZoomOutCallback):
3711
3712 2007-08-29  David Kilzer  <ddkilzer@apple.com>
3713
3714         Reviewed by Adam.
3715
3716         Added case-insensitivity to checks for adding regression tests.
3717
3718         * Scripts/prepare-ChangeLog:
3719         (generateFileList):
3720
3721 2007-08-28  David Kilzer  <ddkilzer@apple.com>
3722
3723         Reviewed by Maciej.
3724
3725         Ignore files in /resources/ subdirectories when creating a list of added tests.
3726
3727         * Scripts/prepare-ChangeLog:
3728         (generateFileList):
3729
3730 2007-08-27  Kevin McCullough  <kmccullough@apple.com>
3731
3732         Reviewed by John.
3733
3734         - Removed Leopard leaks list since all of those radars were fixed.
3735
3736         * Scripts/run-webkit-tests:
3737
3738 2007-08-27  Adam Roben  <aroben@apple.com>
3739
3740         Rubberstamped by Mark.
3741
3742         * Scripts/pdevenv: Pass arguments along to devenv.com.
3743
3744 2007-08-26  David Kilzer  <ddkilzer@webkit.org>
3745
3746         Reviewed by Mark Rowe.
3747
3748         Update prepare-ChangeLog to generate the datestamp in the correct timezone.
3749
3750         * Scripts/prepare-ChangeLog:
3751         (changeLogDate): Added.
3752
3753 2007-08-24  Sam Weinig  <sam@webkit.org>
3754
3755         Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.
3756
3757 2007-08-24  Sam Weinig  <sam@webkit.org>
3758
3759         Rubber-stamped by Adam Roben.
3760
3761         <rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration
3762
3763         Rename COM DOM bindings to use Deprecated prefix.
3764
3765         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3766         (dumpFramesAsText):
3767         (dump):
3768         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp:
3769         (dumpPath):
3770         (dump):
3771         (EditingDelegate::shouldBeginEditingInDOMRange):
3772         (EditingDelegate::shouldEndEditingInDOMRange):
3773         (EditingDelegate::shouldInsertNode):
3774         (EditingDelegate::shouldInsertText):
3775         (EditingDelegate::shouldDeleteDOMRange):
3776         (EditingDelegate::shouldChangeSelectedDOMRange):
3777         (EditingDelegate::shouldApplyStyle):
3778         (EditingDelegate::shouldChangeTypingStyle):
3779         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h:
3780
3781 2007-08-24  Oliver Hunt  <oliver@apple.com>
3782
3783         Reviewed by John H.
3784
3785         WebDataSource::response can legitimately have a null response, so we
3786         must check that case.
3787
3788         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3789         (queueLoadCallback):
3790
3791 2007-08-23  Mitz Pettel  <mitz@webkit.org>
3792
3793         Reviewed by Darin and Adam.
3794
3795         - DumpRenderTree changes to allow testing for
3796           http://bugs.webkit.org/show_bug.cgi?id=11756
3797           REGRESSION: link targeting a frame in another window does not work
3798           <rdar://problem/5286420>
3799
3800         Use a frame group name for all WebViews created by DumpRenderTree to
3801         allow testing of cross-page frame lookup.
3802
3803         * DumpRenderTree/DumpRenderTree.m:
3804         (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
3805         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3806         (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).
3807
3808 2007-08-23  David Kilzer  <ddkilzer@webkit.org>
3809
3810         Reviewed by Adam.
3811
3812         Quote the $sslCertificate path in case it contains a space.
3813
3814         * Scripts/run-webkit-httpd:
3815         * Scripts/run-webkit-tests:
3816
3817 2007-08-22  Oliver Hunt  <oliver@apple.com>
3818
3819         Reviewed by John and Adam.
3820         
3821         WebDataSource::response can legitimately have a null response, so we
3822         must check that case.
3823
3824         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3825         (dump):
3826
3827 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
3828
3829         Reviewed by Geof.
3830
3831         - Changing the usage to be more clear.
3832
3833         * Scripts/run-testkjs:
3834
3835 2007-08-20  John Sullivan  <sullivan@apple.com>
3836
3837         Reviewed by Adam Roben
3838
3839         * DumpRenderTree/DumpRenderTree.m:
3840         (runTest):
3841         call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors
3842         in layout tests on Tiger and Leopard
3843
3844 2007-08-20  Adam Roben  <aroben@apple.com>
3845
3846         Put LayoutTests after all other ChangeLogs in commit logs
3847
3848         We use "~" to sort LayoutTests after all the other ChangeLogs because
3849         "~" is the last ASCII character (other than "DEL").
3850
3851         Reviewed by Sam.
3852
3853         * Scripts/commit-log-editor:
3854
3855 2007-08-20  Adam Roben  <aroben@apple.com>
3856
3857         Detect that DRT crashed even if a crash dialog is running
3858
3859         On Windows, when DRT crashes a crash dialog commonly appears. The DRT
3860         process is still running at this point, so run-webkit-tests wouldn't
3861         detect that DRT had crashed. We now record the crash in our SIGPIPE
3862         handler so that we know if DRT crashed even if the crash dialog is up.
3863
3864         Reviewed by Sam.
3865
3866         * Scripts/run-webkit-tests:
3867         (sub catch_pipe): Set the crashed bit.
3868         (sub openDumpTool): Reset the crashed bit.
3869         (sub dumpToolDidCrash): Check the crashed bit.
3870
3871 2007-08-20  Adam Roben  <aroben@apple.com>
3872
3873         Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog
3874
3875         http://bugs.webkit.org/show_bug.cgi?id=15026
3876
3877         Reviewed by David Kilzer and Darin Adler.
3878
3879         * Scripts/prepare-ChangeLog:
3880         (sub isModifiedStatus): Split out from isModifiedOrAddedStatus.
3881         (sub isAddedStatus): Ditto.
3882         (sub testListForChangeLog): Added.
3883
3884 2007-08-19  Oleg Sukhodolsky  <son.two@gmail.com>
3885
3886         Reviewed by Mark.
3887
3888         -fixes http://bugs.webkit.org/show_bug.cgi?id=14632
3889
3890         * Scripts/webkitdirs.pm:
3891         qt and gtk ports now explicitly pass debug (or release) mode to qmake.
3892
3893 2007-08-17  Darin Adler  <darin@apple.com>
3894
3895         Reviewed by Oliver Hunt.
3896
3897         - don't look for Apple-style localizable strings in the GTK version of WebKit
3898
3899         * Scripts/extract-localizable-strings: Add a feature where you can pass in the
3900         name of subdirectories to skip.
3901         * Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory
3902         to skip.
3903
3904 2007-08-17  Anders Carlsson  <andersca@apple.com>
3905
3906         Build fix.
3907         
3908         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3909         (NPP_SetWindow):
3910
3911 2007-08-17  Anders Carlsson  <andersca@apple.com>
3912
3913         Reviewed by Dave Hyatt.
3914
3915         <rdar://problem/5379040>
3916         REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes
3917
3918         Add a way for the plug-in to dump the width and height when it gets its  NPP_SetWindow call.
3919         
3920         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
3921         (pluginAllocate):
3922         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3923         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3924         (NPP_New):
3925         (NPP_SetWindow):
3926
3927 2007-08-16  Alice Liu  <alice.liu@apple.com>
3928
3929         Reviewed by Maciej.
3930
3931         Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail
3932
3933         * DumpRenderTree/DumpRenderTree.m:
3934         (createWebView):
3935         Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow.
3936         (dumpRenderTree):
3937         Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow. 
3938
3939 2007-08-16  Kevin McCullough  <kmccullough@apple.com>
3940
3941         Reviewed by Adam.
3942
3943         - Added tests for regressions in other components.  In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
3944
3945         * Scripts/run-webkit-tests:
3946
3947 2007-08-15  Timothy Hatcher  <timothy@apple.com>
3948
3949         Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
3950         The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.
3951
3952         Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
3953         this prevents making "build" directories in each project folder.
3954
3955         * Scripts/webkitdirs.pm:
3956
3957 2007-08-14  Geoffrey Garen  <ggaren@apple.com>
3958
3959         Reviewed by Kevin Mccullough.
3960         
3961         Removed special case that didn't belong. (It would allow a global 
3962         initializer to sneak into production builds, which would cause a 
3963         system-wide performance regression on Mac OS X.)
3964
3965         * Scripts/check-for-global-initializers:
3966
3967 2007-08-14  Justin Garcia  <justin.garcia@apple.com>
3968
3969         Reviewed by Tim.
3970         
3971         <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
3972
3973         * DumpRenderTree/EditingDelegate.m:
3974         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES
3975         only for elements with the class needsDeletionUI.
3976
3977 2007-08-14  David Kilzer  <ddkilzer@webkit.org>
3978
3979         Reviewed by Darin.
3980
3981         - fix http://bugs.webkit.org/show_bug.cgi?id=14965
3982           svn-create-patch uses deprecated tail switch
3983
3984         * Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.
3985
3986 2007-08-13  Sam Weinig  <sam@webkit.org>
3987
3988         Reviewed by Adam Roben.
3989
3990         Use the cygwin specific Apache config file under cygwin.
3991
3992         * Scripts/run-webkit-httpd:
3993
3994 2007-08-12  Adam Roben  <aroben@apple.com>
3995
3996         Generate results for new tests in a more logical location
3997
3998         New platform-specific tests always have their results generated right
3999         next to the test. New cross-platform tests will have their results
4000         generated a) in the cross-platform directory, if they are text-only,
4001         or b) in the least-specific platform directory, if they are render
4002         tree dumps.
4003
4004         Reviewed by Lars.
4005
4006         * Scripts/run-webkit-tests:
4007
4008 2007-08-12  Adam Roben  <aroben@apple.com>
4009
4010         Print the actual directory where new results are generated.
4011
4012         Before, we were printing an unpredictable, context-specific substring
4013         of the directory.
4014
4015         Reviewed by Lars.
4016
4017         * Scripts/run-webkit-tests:
4018
4019 2007-08-12  Adam Roben  <aroben@apple.com>
4020
4021         Factor some common code into a stripExtension() subroutine.
4022
4023         Reviewed by Lars.
4024
4025         * Scripts/run-webkit-tests: Also removed some debugging output.
4026
4027 2007-08-11  Matt Lilek  <pewtermoose@gmail.com>
4028
4029         Reviewed over and over and over by Adam Roben.
4030
4031         Bug 14740: Hierarchical layout tests and platform organization
4032         http://bugs.webkit.org/show_bug.cgi?id=14740
4033
4034         Add support for platform-specific layout tests and results.
4035
4036         * Scripts/run-webkit-tests:
4037
4038 2007-08-11  David Kilzer  <ddkilzer@webkit.org>
4039
4040         Reviewed by Adam.
4041
4042         Refactored svn-create-path to use a hash-of-hashes data structure to keep
4043         track of changed files.  In the top level hash, keys are paths to files and
4044         values are 'fileData' hashes with the following keys and values:
4045
4046         - isBinary: boolean value (set to true for non-text files like images, etc.)
4047         - isTestFile: boolean value (set to true if file exists within a known test
4048           directory)
4049         - modificationType: string equal to one of 'addition', 'additionWithHistory',
4050           'modification' or 'deletion'
4051         - path: string equal to the path to the file (this may seem redundant, but it
4052           is required to use the second-level 'fileData' hash independent of the
4053           top-level hash)
4054         - sourceFile: [optional] string equal to the path of the original file that was
4055           copied or moved
4056         - sourceRevision: [optional] string equal to the revision of the original file
4057           that was copied or moved
4058
4059         * Scripts/svn-create-patch: Moved call to GetOptions() to its own statement
4060         that saves the return value in $result, then checks it before printing help.
4061         Combined sourceFiles, %testFiles, and %binaryFiles into single %diffFiles hash
4062         and eliminated two for() loops.
4063         (binarycmp): Added.  Used with sort() to order non-binary files before binary
4064         files.
4065         (findBaseUrl): Added.  Extracted from findSourceFileAndRevision().
4066         (findMimeType): Added optional second argument that takes a revision number.
4067         (generateDiff): Updated to take one fileData argument instead of three ($file,
4068         $modificationType, $isBinary).
4069         (generateFileList): Updated to take one hash ref argument (%diffFiles)
4070         instead of three (%sourceFiles, %testFiles, %binaryFiles).  Populates
4071         %diffFiles using paths for keys and fileData hashes for values.
4072         (manufacturePatchForAdditionWithHistory): Updated to take one fileData
4073         argument.
4074         (pathcmp): Updated to take two fileData arguments instead of two strings.
4075         (testfilecmp): Added.  Used with sort() to order non-test files before test
4076         files.
4077
4078 2007-08-11  Darin Adler  <darin@apple.com>
4079
4080         * Scripts/run-webkit-tests: Give a different message when only the pixel test failed.
4081
4082 2007-08-06  Nigel Tao  <nigeltao@gnome.org>
4083
4084         Reviewed by David Kilzer.
4085
4086         Fix bug 14745: WebKitTools/Scripts/run-launcher doesn't speak --gdk
4087         http://bugs.webkit.org/show_bug.cgi?id=14745
4088
4089         * Scripts/run-launcher:
4090         Scrub the "--gdk" out of the command line args, if given, so that
4091         GdkLauncher doesn't try to interpret it as a URL.
4092
4093 2007-08-03  Adam Roben  <aroben@apple.com>
4094
4095         Catch SIGPIPE on Windows so that run-webkit-tests doesn't quit when DRT crashes
4096
4097         Reviewed by Sam.
4098
4099         * Scripts/run-webkit-tests: Also close ERROR when we finish running the tests.
4100
4101 2007-08-03  Sam Weinig  <sam@webkit.org>
4102
4103         Reviewed by Darin.
4104
4105         Recursively dump all frames as text using new
4106         layoutTestController.dumpChildFramesAsText() function.
4107
4108         * DumpRenderTree/DumpRenderTree.m:
4109         (dumpFramesAsText):
4110         (dump):
4111         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
4112         (-[LayoutTestController dumpChildFramesAsText]):
4113         (runTest):
4114         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
4115         (dumpFramesAsText):
4116         (dump):
4117         (runTest):
4118         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
4119         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
4120         (dumpChildFramesAsTextCallback):
4121         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4122
4123 2007-08-02  Adam Roben  <aroben@apple.com>
4124
4125         Fix fast/dom/Window/alert-undefined.html
4126
4127         Reviewed by Sam.
4128
4129         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
4130         (WaitUntilDoneDelegate::runJavaScriptAlertPanelWithMessage): Don't let
4131         Windows translate a null BSTR into "(null)"
4132
4133 2007-08-02  Kevin McCullough  <kmccullough@apple.com>
4134
4135         Reviewed by Tim. 
4136
4137         - It would help if I actually called the right function.
4138
4139         * Drosera/DebuggerDocument.cpp:
4140         (DebuggerDocument::showConsole):
4141
4142 2007-08-02  Adam Roben  <aroben@apple.com>
4143
4144         Don't delete the stderr file right after creating it
4145
4146         * Scripts/run-webkit-tests:
4147
4148 2007-08-01  Adam Roben  <aroben@apple.com>
4149
4150         When DRT crashes, record stderr and restart DRT
4151
4152         This prevents a DRT crash from causing the next few hundred tests to
4153         "fail" because DRT is no longer running. 
4154
4155         I also changed the terminology that run-webkit-tests uses in its
4156         output a bit, so that crashing tests are referred to as "crashes"
4157         instead of "failures".
4158
4159         Reviewed by Mark.
4160
4161         * Scripts/run-webkit-tests: Detect a crash and record it as a tool
4162         failure.
4163         (sub openDumpTool): Use open3 so that we can access stderr.
4164         (sub dumpToolCrashed): Added.
4165         (sub printFailureMessageForTest): Added.
4166         (sub htmlForExpectedAndActualResults): Added.
4167         (sub deleteExpectedAndActualResults): Added.
4168         (sub recordActualResultsAndDiff): Added.
4169
4170 2007-07-30  Darin Adler  <darin@apple.com>
4171
4172         Reviewed by Tim Hatcher.
4173
4174         * DumpRenderTree/DumpRenderTree.m: (dump): Fix dumping for documents that include null
4175         characters. This turned out not to be needed for the test case that motivated me to
4176         do it, but it's nice to have this for the future.
4177
4178 2007-07-30  Simon Hausmann  <hausmann@kde.org>
4179
4180         Reviewed by Lars.