WebCore:
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-02-15  Adam Roben  <aroben@apple.com>
2
3         Fix a typo that broke the Mac build
4
5         Reviewed by Mark.
6
7         * Scripts/build-webkit:
8
9 2008-02-14  Adam Roben  <aroben@apple.com>
10
11         Turn on cross-document messaging support by default
12
13         Reviewed by Darin.
14
15         * Scripts/build-webkit:
16
17 2008-02-14  Adam Roben  <aroben@apple.com>
18
19         Conditionalize cross-document messaging support
20
21         The cross-document messaging parts of HTML 5 are in flux and we want
22         ports to be able to turn off the support as needed.
23
24         Note that the support is turned off by default right now. A subsequent
25         commit will turn it on by default.
26
27         Reviewed by Darin.
28
29         * Scripts/build-webkit:
30
31 2008-02-14  Darin Adler  <darin@apple.com>
32
33        - fix Windows build
34
35         * DumpRenderTree/win/UIDelegate.cpp:
36         (UIDelegate::setStatusText): Update parameter types to match declaration.
37
38 2008-02-14  Oliver Hunt  <oliver@apple.com>
39
40         Reviewed by Geoff G and Weinig.
41
42         Add ability for DRT to report tests setting the status text.
43
44         * DumpRenderTree/LayoutTestController.cpp:
45         (LayoutTestController::LayoutTestController):
46         (dumpStatusCallbacksCallback):
47         (LayoutTestController::staticFunctions):
48         * DumpRenderTree/LayoutTestController.h:
49         * DumpRenderTree/mac/UIDelegate.mm:
50         (-[UIDelegate webView:setStatusText:]):
51         * DumpRenderTree/win/UIDelegate.cpp:
52         * DumpRenderTree/win/UIDelegate.h:
53
54 2008-02-13  Adam Roben  <aroben@apple.com>
55
56         Windows build fix
57
58         * DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.
59
60 2008-02-13  Adam Roben  <aroben@apple.com>
61
62         Windows/GTK+ build fix
63
64         * DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to
65         get isnan.
66
67 2008-02-13  Brady Eidson  <beidson@apple.com>
68
69         Reviewed by Darin Adler
70
71         Add some much needed Database support to DRT
72
73         * DumpRenderTree/LayoutTestController.cpp:
74         (LayoutTestController::LayoutTestController):
75         (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to
76           databases are called
77         (clearAllDatabasesCallback): Allow a test to delete all databases
78         (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get
79         (LayoutTestController::staticFunctions):
80
81         * DumpRenderTree/LayoutTestController.h:
82         (LayoutTestController::dumpDatabaseCallbacks):
83         (LayoutTestController::setDumpDatabaseCallbacks):
84
85         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
86         (LayoutTestController::clearAllDatabases):
87         (LayoutTestController::setDatabaseQuota):
88
89         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
90         (LayoutTestController::clearAllDatabases): Stubbed out
91         (LayoutTestController::setDatabaseQuota): Ditto
92         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
93         (LayoutTestController::clearAllDatabases): Stubbed out with error message
94         (LayoutTestController::setDatabaseQuota): Ditto
95
96         * DumpRenderTree/mac/UIDelegate.mm:
97         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a
98           message with details about the event then return a 5mb quota like before
99
100
101 2008-02-12  Steve Falkenburg  <sfalken@apple.com>
102
103         Changes to support merged MIDL output.
104
105         All COM interfaces are now generated to WebKit.h.
106
107         Reviewed by Sam, Ada.
108
109         * Drosera/win/BaseDelegate.h:
110         * Drosera/win/DebuggerClient.cpp:
111         * Drosera/win/DebuggerDocumentPlatform.cpp:
112         * Drosera/win/Drosera.cpp:
113         * Drosera/win/ServerConnection.cpp:
114         * Drosera/win/ServerConnection.h:
115         * DumpRenderTree/win/DumpRenderTree.cpp:
116         * DumpRenderTree/win/EditingDelegate.h:
117         * DumpRenderTree/win/EventSender.cpp:
118         * DumpRenderTree/win/FrameLoadDelegate.cpp:
119         * DumpRenderTree/win/FrameLoadDelegate.h:
120         * DumpRenderTree/win/GCControllerWin.cpp:
121         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
122         * DumpRenderTree/win/PolicyDelegate.h:
123         * DumpRenderTree/win/ResourceLoadDelegate.h:
124         * DumpRenderTree/win/UIDelegate.cpp:
125         * DumpRenderTree/win/UIDelegate.h:
126         * DumpRenderTree/win/WorkQueueItemWin.cpp:
127
128 2008-02-10  Dan Bernstein  <mitz@apple.com>
129
130         Reviewed by Oliver Hunt.
131
132         - fix a memory leak
133
134         * DumpRenderTree/cg/ImageDiffCG.cpp:
135         (getDifferenceBitmap): Use a static CFMutableData instead of allocating
136         and leaking the buffer each time.
137
138 2008-02-07  Adam Roben  <aroben@apple.com>
139
140         Fix error in bisect-builds when responding "broken" for the first
141         build
142
143         Reviewed by Dave Kilzer.
144
145         * Scripts/bisect-builds: Only try to test the build if the nightly
146         info for the current index has not been deleted.
147
148 2008-02-07  Geoffrey Garen  <ggaren@apple.com>
149
150         Reviewed by Alexey Proskuryakov.
151
152         Fixed two minor typos in the --root option, to get it working.
153
154         * Scripts/run-sunspider:
155             1. Actually assign the function argument to our local variable.
156             2. Actually set the $root variable, so we don't try to build later.
157
158 2008-02-05  Oliver Hunt  <oliver@apple.com>
159
160         RS=Eric.
161
162         Re-enable foreignObject by default as it is needed for a number of non-fO
163         related SVG tests and none of the old known crashes occur anymore.
164
165         * Scripts/build-webkit:
166
167 2008-02-05  Steve Falkenburg  <sfalken@apple.com>
168
169         Build fix.  Don't override intermediate directory.
170
171         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
172
173 2008-02-05  Holger Hans Peter Freyther  <zecke@selfish.org>
174
175         Build fix for Windows. willCloseFrame is a pure virtual and we are
176         forced to have an implementation.
177         
178         This partially reverts r30014.
179
180         * DumpRenderTree/win/FrameLoadDelegate.cpp:
181         (FrameLoadDelegate::willCloseFrame):
182         * DumpRenderTree/win/FrameLoadDelegate.h:
183
184 2008-02-05  Nikolas Zimmermann  <zimmermann@kde.org>
185
186         Reviewed by Holger.
187
188         Don't build wrapper for SVGTestCase.js (special file for svg/dynamic-updates)
189
190         * Scripts/make-js-test-wrappers:
191
192 2008-02-05  Holger Freyther  <zecke@selfish.org>
193
194         Reviewed by Darin.
195
196         In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
197         the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
198         depends on the order the tests are executed.
199         
200         Propose to remove willCloseFrame and didlCearWindowObject output from the
201         FrameLoadDelegate and update the test results. The output of didClearWindowObject
202         is not interesting for any of the current tests and we have other ways to find
203         out if a frame was closed or not.
204
205         * DumpRenderTree/mac/FrameLoadDelegate.mm:
206         * DumpRenderTree/win/FrameLoadDelegate.cpp:
207         (FrameLoadDelegate::didClearWindowObject):
208         * DumpRenderTree/win/FrameLoadDelegate.h:
209
210 2008-02-04  Mark Rowe  <mrowe@apple.com>
211
212         Reviewed by Oliver Hunt.
213
214         Workaround for http://bugs.webkit.org/show_bug.cgi?id=16842
215         Bug 16842: Hang in DRT in leaks mode due to signal handler doing unsafe things
216
217         Don't install the signal handler unless we are running the pixel tests.
218         It is currently only used to restore the color profile, but by catching
219         signals we can trigger a deadlock in DRT while running leak tests.
220         The deadlock is tracked by http://bugs.webkit.org/show_bug.cgi?id=16842,
221         and a more complete fix will need to be developed to address this for
222         pixel tests as well.
223
224         * DumpRenderTree/mac/DumpRenderTree.mm:
225         (dumpRenderTree):
226
227 2008-02-04  Mark Rowe  <mrowe@apple.com>
228
229        Gtk qmake build fix.
230
231         * Scripts/webkitdirs.pm:  Fix perl's complaint about an odd number of elements in anonymous hash.
232
233 2008-02-04  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
234
235         Reviewed by Alp Toker and Mark Rowe.
236
237         http://bugs.webkit.org/show_bug.cgi?id=16618
238         [GTK] build-webkit and run-webkit-tests autootools support
239
240         * Scripts/build-webkit: added --database and --icon-database options
241         * Scripts/run-launcher:
242         * Scripts/run-webkit-tests:
243         * Scripts/webkitdirs.pm:
244
245 2008-02-04  Oliver Hunt  <oliver@apple.com>
246
247         Reviewed by Steve F.
248
249         Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT
250
251         Implement required DRT functionality to allow majority of Drag and Drop testcases to work.
252         Issues include:
253           * Uses Sleep() to implement leapForward reliably.
254           * 3 DND tests still fail for reasons that i have not yet determined
255           * Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain 
256
257         * DumpRenderTree/win/EventSender.cpp:
258         (leapForwardCallback):
259         (mouseDownCallback):
260         (doMouseUp):
261         (mouseUpCallback):
262         (doMouseMove):
263         (mouseMoveToCallback):
264           Minor updates to these functions to handle the different message queue structure.
265
266         (replaySavedEvents):
267           More complicated now.  Where possible we just use the old while-loop model of execution,
268           but when leapForward has been used we have to jump through some hoops and set up an 
269           inner event loop so that we can ensure messages get the correct time stamp.
270
271         * DumpRenderTree/win/UIDelegate.cpp:
272         (UIDelegate::doDragDrop):
273           Call replaySavedEvents directly to force synchronous handling of drag and drop.
274
275 2008-02-04  Rodney Dawes  <dobey@wayofthemonkey.com>
276
277         Reviewed by Alp Toker and Mark Rowe.
278
279         Fix http://bugs.webkit.org/show_bug.cgi?id=17175.
280         Bug 17175: Use of C++ compiler flags in CFLAGS
281
282         * GNUmakefile.am: Use global_cxxflags as well as global_cflags in CXXFLAGS.
283
284 2008-02-04  Darin Adler  <darin@apple.com>
285
286         Reviewed by Geoff.
287
288         * Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast
289         and svg subdirectories. Added some more exceptions for the benefit of the fast/dom
290         subdirectory.
291
292 2008-02-04  Adam Roben  <aroben@apple.com>
293
294         Windows Apple-only build fix
295
296         * DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include
297         directory.
298
299 2008-02-04  Alp Toker  <alp@atoker.com>
300
301         Rubber-stamped by Mark Rowe.
302
303         Remove all trailing whitespace in the GTK+ port and related
304         components.
305
306         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
307         * DumpRenderTree/gtk/GCControllerGtk.cpp:
308         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
309         * GNUmakefile.am:
310
311 2008-02-01  Eric Seidel  <eric@webkit.org>
312
313         Reviewed by Oliver.
314
315         Also search LayoutTests/svg for js-based tests.
316
317         * Scripts/make-js-test-wrappers:
318
319 2008-01-31  Alp Toker  <alp@atoker.com>
320
321         Rubber-stamped by Adam Roben.
322
323         http://bugs.webkit.org/show_bug.cgi?id=17006
324         [GTK] Header path should be webkit/webkit.h
325
326         Move the GTK+ API sources as needed and update the build systems.
327
328         * DumpRenderTree/gtk/DumpRenderTree.cpp:
329         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
330         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
331         * GNUmakefile.am:
332         * GtkLauncher/main.c:
333
334 2008-01-30  Stephanie  <slewis@apple.com>
335
336         Reviewed by Geoff.
337
338         Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
339
340         * Scripts/run-webkit-tests:
341
342 2008-01-30  Alexey Proskuryakov  <ap@webkit.org>
343
344         Reviewed by Adam Roben.
345
346         One more debug (external) fix.
347
348         * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
349         and Debug configurations. 
350
351 2008-01-29  Geoffrey Garen  <ggaren@apple.com>
352
353         Reviewed by Sam Weinig. Sam Weinig.
354         
355         Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
356         fails when run after fast/dom/Window/window-property-shadowing.html (16902)
357
358         Modified our policy delegates not to output window.name. Since a
359         previous test may have explicitly set window.name, we can't rely on its
360         implicit value in test results.
361
362         * DumpRenderTree/mac/PolicyDelegate.mm:
363         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
364
365         * DumpRenderTree/win/PolicyDelegate.cpp:
366         (PolicyDelegate::decidePolicyForNavigationAction):
367
368 2008-01-29  Mark Rowe  <mrowe@apple.com>
369
370         Reviewed by Tim Hatcher.
371
372         <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
373
374         * Scripts/build-webkit: Copy SQLite static library and headers into the build directory.
375
376 2008-01-29  David Kilzer  <ddkilzer@apple.com>
377
378         Refactor ChangeLog path code
379
380         Reviewed by Adam.
381
382         * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
383         duplicate code in another foreach() loop.
384
385 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
386
387         Reviewed by Darin.
388
389         <rdar://problem/5710692> All storage tests fail/crash
390
391         * DumpRenderTree/mac/UIDelegate.mm:
392         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an
393         arbitrary quota of 5 megabytes.
394
395         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
396         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
397         Removed unused (I think) code.
398         
399         * DumpRenderTree/win/UIDelegate.cpp:
400         (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported.
401         (UIDelegate::webViewPainted): A stub implementation.
402         (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
403         * DumpRenderTree/win/UIDelegate.h:
404
405 2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
406
407         GTK+ DRT build fix for breakage introduced in r29822.
408
409         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
410         (LayoutTestController::setPersistentUserStyleSheetLocation):
411         (LayoutTestController::clearPersistentUserStyleSheet):
412
413 2008-01-27  Dan Bernstein  <mitz@apple.com>
414
415         Reviewed by Darin Adler.
416
417         - add support for directory prologues and epilogues to run-webkit-tests
418         - allow setting a persistent user style sheet in DumpRenderTree
419         - activate the WebKit Layout Tests font in Windows DumpRenderTree
420
421         * DumpRenderTree/LayoutTestController.cpp:
422         (clearPersistentUserStyleSheetCallback): Added.
423         (setPersistentUserStyleSheetLocationCallback): Added.
424         (LayoutTestController::staticFunctions): Added.
425         clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
426         * DumpRenderTree/LayoutTestController.h:
427         * DumpRenderTree/mac/DumpRenderTree.mm:
428         (setPersistentUserStyleSheetLocation): Added.
429         (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
430         to the set of things this function resets. Now it either disables the
431         user style sheet or sets it to the persistent user style sheet and
432         enables it.
433         * DumpRenderTree/mac/DumpRenderTreeMac.h:
434         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
435         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
436         (LayoutTestController::clearPersistentUserStyleSheet): Added.
437         * DumpRenderTree/win/DumpRenderTree.cpp:
438         (setPersistentUserStyleSheetLocation): Added.
439         (initialize): Added the WebKit Layout Tests font to the set of fonts to
440         install.
441         (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
442         * DumpRenderTree/win/DumpRenderTreeWin.h:
443         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
444         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
445         (LayoutTestController::clearPersistentUserStyleSheet): Added.
446         * Scripts/run-webkit-tests: Changed to look for, and if found process in
447         DumpRenderTree, files named run-webkit-tests-prologue.html and
448         run-webkit-tests-epilogue.html in the resources subdirectory of any
449         test directory and platform test results directory. The prologues are
450         processed before the first test from the directory (and its
451         subdirectories) is run, and the epilogues are processed after the last
452         test from the directory is run. Platform-specific prologues and
453         epilogues are processed in order of specificity.
454
455 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
456
457         Reviewed by Mark Rowe.
458
459         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
460
461         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
462         (matching Mac DRT).
463         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
464
465 2008-01-24  Sam Weinig  <sam@webkit.org>
466
467         Reviewed by Ada Chan.
468
469         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
470
471         - Adds simplified UndoManager to windows DRT to allow testing the
472           undo/redo code paths in WebCore and WebKit.  This is a temporary
473           solution to an issue that should eventually be solved by having a
474           shared UndoManager in WebKit.
475
476         * DumpRenderTree/win/DumpRenderTree.cpp:
477         (runTest):
478         * DumpRenderTree/win/UIDelegate.cpp:
479         (DRTUndoObject::DRTUndoObject):
480         (DRTUndoObject::invoke):
481         (DRTUndoStack::~DRTUndoStack):
482         (DRTUndoStack::isEmpty):
483         (DRTUndoStack::clear):
484         (DRTUndoStack::push):
485         (DRTUndoStack::pop):
486         (DRTUndoManager::canRedo):
487         (DRTUndoManager::canUndo):
488         (DRTUndoManager::DRTUndoManager):
489         (DRTUndoManager::removeAllActions):
490         (DRTUndoManager::registerUndoWithTarget):
491         (DRTUndoManager::redo):
492         (DRTUndoManager::undo):
493         (UIDelegate::UIDelegate):
494         (UIDelegate::resetUndoManager):
495         (UIDelegate::registerUndoWithTarget):
496         (UIDelegate::removeAllActionsWithTarget):
497         (UIDelegate::setActionTitle):
498         (UIDelegate::undo):
499         (UIDelegate::redo):
500         (UIDelegate::canUndo):
501         (UIDelegate::canRedo):
502         * DumpRenderTree/win/UIDelegate.h:
503
504 2008-01-23  Adam Roben  <aroben@apple.com>
505
506         Allow directories containing ChangeLogs to be passed to
507         resolve-ChangeLogs
508
509         Reviewed by David Kilzer.
510
511         * Scripts/resolve-ChangeLogs:
512         (sub findChangeLog): Return a ChangeLog contained within the specified
513         directory if one exists.
514
515 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
516
517         <rdar://problem/5698732> Copyright strings should include 2008
518
519         Reviewed by Sam.
520
521         * Drosera/win/Drosera.vcproj/Drosera.rc:
522         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
523
524 2008-01-23  Alp Toker  <alp@atoker.com>
525
526         Rubber-stamped by Mark Rowe.
527
528         Remove whitespace after -I in automake include lists.
529
530         * GNUmakefile.am:
531
532 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
533
534         Reviewed by Lars Knoll <lars@trolltech.com>.
535
536         Reworked the JavaScriptCore Qt bindings:
537         
538         * Update JS DRT controller for Qt JS binding changes.
539         There were two functions that needed some changes
540         so that the layout tests would work, so this makes
541         a few tests pass again.
542         
543         * Bump the timeout for layout tests up to 11s.
544         At least some tests have an internal timeout of
545         10 seconds, so make the waitUntilDone approach
546         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
547         is one of these - now the failure message is more
548         accurate.
549         
550
551         * DumpRenderTree/qt/jsobjects.cpp:
552         (LayoutTestController::waitUntilDone):
553         * DumpRenderTree/qt/jsobjects.h:
554
555 2008-01-22  Anders Carlsson  <andersca@apple.com>
556
557         Reviewed by Darin and Adam.
558
559         <rdar://problem/5688975>
560         div element on microsoft site has wrong left offset.
561         
562         Add new method for testing the return vale of NPN_GetProperty.
563         
564         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
565         (pluginInvoke):
566
567 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
568
569         Reviewed by Adam Roben.
570
571         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
572
573         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
574
575 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
576
577         Reviewed by Alp Toker.
578
579         http://bugs.webkit.org/show_bug.cgi?id=16955
580         Get errors when cross-compile webkit-gtk
581
582         * GNUmakefile.am: Removed ICU_CFLAGS 
583
584 2008-01-21  Darin Adler  <darin@apple.com>
585
586         Reviewed by Mitz and Adam.
587
588         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
589         sorting speed by doing all sort criteria in a single pass instead of three sorts.
590
591 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
592
593         Reviewed by Holger.
594
595         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
596         
597         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
598         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
599         and make the return value depend on whether we successfully determined a focusable
600         node or not.
601         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
602         if we could not handle the focus chain ourselves.
603         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
604         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
605         used to control the situation of stepping out of the focus chain inside the page.
606         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
607         The layout tests expect this to be disabled but for the user it seems sensible to have it
608         on by default, hence the default in qwebsettings.cpp
609         
610
611         * DumpRenderTree/qt/DumpRenderTree.cpp:
612         (WebCore::WebPage::WebPage):
613
614 2008-01-19  Mark Rowe  <mrowe@apple.com>
615
616         Reviewed by Alp Toker.
617
618         Allow the --http flag to run-webkit-tests to override
619         the default behaviour of disabling HTTP tests for Qt,
620         Gtk and Wx.
621
622         * Scripts/run-webkit-tests:
623
624 2008-01-19  David Kilzer  <ddkilzer@apple.com>
625
626         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
627
628         Reviewed by Darin.
629
630         We now touch a check-for-global-initializers.timestamp file in
631         the TARGET_TEMP_DIR directory to determine when new object files
632         have been compiled and thus need to be checked.  If the timestamp
633         file doesn't exist, all object files will be checked.
634
635         Previously the modification time of the "executable" (the
636         framework binary, e.g., WebKit.framework/WebKit) was used, but
637         since this was the last file modified at the end of the compile
638         phase, no object files would ever get checked!
639
640         Also added JSCustomSQLTransactionCallback.o to the list of files
641         since it has static initializers in Debug builds of WebCore.
642
643         * Scripts/check-for-global-initializers:
644
645 2008-01-18  Adam Roben  <aroben@apple.com>
646
647         Build fix
648
649         * Scripts/build-webkit:
650
651 2008-01-18  Beth Dakin  <bdakin@apple.com>
652
653         Reviewed by Oliver.
654
655         Update build-webkit to account for foreign-object being disabled by 
656         default.
657
658         * Scripts/build-webkit:
659
660 2008-01-18  Adam Roben  <aroben@apple.com>
661
662         Updated for method renames
663
664         Reviewed by Adele.
665
666         * DumpRenderTree/mac/FrameLoadDelegate.mm:
667         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
668         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
669         (LayoutTestController::setMainFrameIsFirstResponder):
670         (LayoutTestController::setWindowIsKey):
671         * DumpRenderTree/mac/UIDelegate.mm:
672         (-[UIDelegate webViewFocus:]):
673         * DumpRenderTree/win/FrameLoadDelegate.cpp:
674         (FrameLoadDelegate::didCommitLoadForFrame):
675
676 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
677
678         Reviewed by Adam Roben.
679
680         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
681         between DRT and TestNetscapePlugin.
682
683         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
684         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
685
686 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
687
688         Reviewed by Holger.
689
690         Fix fast/dom/Window/window-resize.html
691         
692         In DRT connect the page's geometryChangeRequest signal to a slot that
693         sets the geometry of the view widget.
694         
695
696         * DumpRenderTree/qt/DumpRenderTree.cpp:
697         (WebCore::WebPage::setViewGeometry):
698         (WebCore::WebPage::WebPage):
699
700 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
701
702         Build fix.
703
704         * Drosera/DroseraWin.make:
705
706 2008-01-17  Darin Adler  <darin@apple.com>
707
708         * Scripts/run-webkit-tests: Fixed a bug number.
709
710 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
711
712         Reviewed by Adam Roben.
713
714         http://bugs.webkit.org/show_bug.cgi?id=16908
715         run-webkit-tests complains about missing FindSafari.exe
716
717         * Scripts/webkitdirs.pm: Append _debug as appropriate.
718
719 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
720
721         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
722         
723         Rubber-stamped by Jon Honeycutt.
724
725         * DumpRenderTree/win/DumpRenderTree.vcproj:
726
727 2008-01-16  Alp Toker  <alp@atoker.com>
728
729         Reviewed by Mark Rowe.
730
731         http://bugs.webkit.org/show_bug.cgi?id=16218
732         [GTK] API: Should this entry point be called go_back rather than go_backward?
733
734         Track back/forward API changes in the tools.
735
736         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
737         (BackForwardItem::invoke):
738         * GtkLauncher/main.c:
739         (go_back_cb):
740
741 2008-01-16  Adam Roben  <aroben@apple.com>
742
743         Windows build fix after r29488
744
745         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
746         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
747         expects to find the plugin.
748
749 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
750
751         Reviewed by Sam Weinig.
752         
753         Fixed the waitUntilDone watchdog timer -- the old code never added the
754         timer to the run loop, so it didn't do anything.
755
756         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
757         (LayoutTestController::setWaitToDump):
758         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
759         (LayoutTestController::setWaitToDump):
760
761 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
762
763         Use shared vsprops for most vcproj properties.
764         
765         Reviewed by Darin.
766
767         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
768         * DumpRenderTree/win/DumpRenderTree.vcproj:
769         * DumpRenderTree/win/ImageDiff.vcproj:
770         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
771         * FindSafari/FindSafari.vcproj:
772
773 2008-01-14  Stephanie  <slewis@apple.com>
774
775        Reviewed by NOBODY.
776   
777        revert accidental character.
778
779        * Scripts/run-webkit-tests:
780
781 2008-01-14  Stephanie  <slewis@apple.com>
782
783         RS=Oliver
784
785         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
786
787         * Scripts/run-webkit-tests:
788
789 2008-01-14  Darin Adler  <darin@apple.com>
790
791         * Scripts/do-webcore-rename: Queue up another rename.
792
793 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
794
795         Reviewed by Darin.
796
797         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
798         the tests were ran.
799         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
800
801         * Scripts/run-webkit-tests:
802
803 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
804
805         Reviewed by Darin.
806
807         * Randomize tests array to spot test cases where the results depends on the order
808         the tests are ran.
809         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
810
811         * Scripts/run-webkit-tests:
812
813 2008-01-14  Darin Adler  <darin@apple.com>
814
815         * Scripts/run-webkit-tests: More ignore list tweaking.
816
817 2008-01-14  Darin Adler  <darin@apple.com>
818
819         * Scripts/run-webkit-tests: Add another leak to the ignore list.
820
821 2008-01-14  Dan Bernstein  <mitz@apple.com>
822
823         Reviewed by Adam Roben.
824
825         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
826           build bots
827
828         * DumpRenderTree/win/DumpRenderTree.cpp:
829         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
830
831 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
832
833         Share common files across projects.
834         
835         Unify vsprops files
836         Debug:          common.vsprops, debug.vsprops
837         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
838         Release:        common.vsprops, release.vsprops
839         
840         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
841         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
842
843         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
844
845         Reviewed by Adam Roben.
846
847         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
848         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
849         * Drosera/win/Drosera.vcproj/VERSION: Removed.
850         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
851         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
852         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
853         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
854         * DumpRenderTree/win/DumpRenderTree.vcproj:
855         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
856         * DumpRenderTree/win/debug.vsprops: Removed.
857         * DumpRenderTree/win/debug_internal.vsprops: Removed.
858         * DumpRenderTree/win/release.vsprops: Removed.
859
860 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
861
862         Reviewed by Maciej.
863
864         - http://bugs.webkit.org/show_bug.cgi?id=16314
865           Script to launch Drosera
866
867         * Scripts/gdb-drosera: Added.
868         * Scripts/run-drosera: Added.
869         * Scripts/run-drosera-nightly.cmd: Added.
870         * Scripts/webkitdirs.pm: Added runDrosera function.
871
872 2008-01-13  Dan Bernstein  <mitz@apple.com>
873
874         - fix breakage due to last-minute change
875
876         * DumpRenderTree/win/DumpRenderTree.cpp:
877         (runTest): Declare the loop variable.
878
879 2008-01-13  Dan Bernstein  <mitz@apple.com>
880
881         Reviewed by Adam Roben.
882
883         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
884
885         * DumpRenderTree/win/DumpRenderTree.cpp:
886         (DumpRenderTreeWndProc):
887         (initialize):
888         (dumpBackForwardList):
889         (dumpBackForwardListForAllWindows):
890         (dump):
891         (resetWebViewToConsistentStateBeforeTesting): Factored out of
892         runTest().
893         (runTest):
894         (allWindows): Added. Returns a vector of all open windows.
895         (windowToWebViewMap): Added. Returns a map from open windows to their
896         WebViews.
897         (createWebViewAndOffscreenWindow): Factored out of main() to be
898         reusable for creating extra windows.
899         (main):
900         * DumpRenderTree/win/DumpRenderTreeWin.h:
901         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
902         (LayoutTestController::windowCount): Implemented.
903         * DumpRenderTree/win/UIDelegate.cpp:
904         (UIDelegate::createWebViewWithRequest): Implemented.
905         (UIDelegate::webViewClose): Implemented.
906         * DumpRenderTree/win/UIDelegate.h:
907
908 2008-01-12  Alp Toker  <alp@atoker.com>
909
910         Reviewed by Mark Rowe.
911
912         Hide non-public symbols in GTK+/autotools release builds.
913
914         * GNUmakefile.am:
915
916 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
917
918         Reviewed by Ap.
919
920         * Make launching of the WebKit httpd work on GNU/Debian/Linux
921         
922         The configuration of Apache2 and installation does not depend on
923         the kernel but on the distribution policy. Make launching of httpd
924         work for Debian derived distributions.
925
926         * Scripts/run-webkit-httpd:
927         * Scripts/run-webkit-tests:
928         * Scripts/webkitdirs.pm:
929
930 2008-01-12  Mark Rowe  <mrowe@apple.com>
931
932         Reviewed by Maciej Stachowiak.
933
934         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
935
936         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
937         match the callers expectations that it can take ownership of the string.
938
939 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
940
941         Reviewed by Adam Roben.
942
943         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
944
945         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
946         as these are only posted because the test window is not a normal visible one, and
947         they confuse drag&drop machinery.
948
949 2008-01-11  Adam Roben  <aroben@apple.com>
950
951         Fix a crash when pathToLocalResource fails and a leak
952
953         Reviewed by Darin.
954
955         * DumpRenderTree/LayoutTestController.cpp:
956         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
957         sure not to pass null to JSValueMakeString.
958         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
959         (LayoutTestController::pathToLocalResource): Print an error message if
960         the conversion fails so it's clear what happened.
961
962 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
963
964         Reviewed by John Sullivan.
965
966         * DumpRenderTree/mac/GCControllerMac.mm:
967         (GCController::collectOnAlternateThread): Updated for name change.
968
969 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
970
971         wx build fix. Don't build dftables any longer since it's now a Perl
972         script.
973
974         * wx/build-wxwebkit:
975
976 2008-01-10  Sam Weinig  <sam@webkit.org>
977
978         Reviewed by Anders Carlsson.
979
980         Make DRT track open windows instead of allocated windows so that
981         we can avoid ASSERTION due to late deallocs out of our control.
982
983         * DumpRenderTree/mac/DumpRenderTree.mm:
984         (dumpBackForwardListForAllWindows):
985         (runTest):
986         * DumpRenderTree/mac/DumpRenderTreeMac.h:
987         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
988         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
989         (+[DumpRenderTreeWindow openWindows]):
990         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
991         (-[DumpRenderTreeWindow close]):
992         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
993         (LayoutTestController::windowCount):
994
995 2008-01-10  Ada Chan  <adachan@apple.com>
996
997         Meta key is not the same as Alt key on windows.
998
999         Reviewed by Darin.
1000
1001         * DumpRenderTree/win/EventSender.cpp:
1002         (keyDownCallback):
1003
1004 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
1005
1006         Reviewed by Darin, Sam and Adam.
1007
1008         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
1009         link in gmail message displays JavaScript alert falsely complaining
1010         about pop-up blocking.
1011         - Added the ability to enable the pop-up blocker via the
1012         LayoutTestController.
1013
1014         * DumpRenderTree/LayoutTestController.cpp:
1015         (setPopupBlockingEnabledCallback):
1016         (LayoutTestController::staticFunctions):
1017         * DumpRenderTree/LayoutTestController.h:
1018         * DumpRenderTree/mac/DumpRenderTree.mm:
1019         (setDefaultsToConsistentValuesForTesting):
1020         (resetWebViewToConsistentStateBeforeTesting):
1021         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1022         (LayoutTestController::setPopupBlockingEnabled):
1023
1024 2008-01-10  Lars Knoll  <lars@trolltech.com>
1025
1026         Reviewed by Simon.
1027
1028         rename QWebPageHistory to QWebHistory.
1029         
1030
1031         * DumpRenderTree/qt/jsobjects.cpp:
1032
1033 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
1034
1035         Reviewed by Darin.
1036         
1037         - add some more renames, adjust some
1038
1039         * Scripts/do-webcore-rename:
1040
1041 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1042
1043         Reviewed by Oliver.
1044
1045         Enable SVG Fonts support by default.
1046
1047         * Scripts/build-webkit:
1048
1049 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1050
1051         Reviewed by Adam.
1052
1053         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
1054         DRT doesn't handle platform specific pixel test results correctly.
1055
1056         <test>-expected.txt files and <test>-expected.png files may now live
1057         in different directories (ie. a cross-platform <test>-expected.txt file
1058         and a platform-specific <test>-expected.png file).
1059
1060         * Scripts/run-webkit-tests:
1061
1062 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
1063
1064         Reviewed by Darin.
1065
1066         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
1067         DRT did not correctly handle printing the '\0' char.  Now it does.
1068
1069         * DumpRenderTree/win/DumpRenderTree.cpp:
1070         (dumpFramesAsText):
1071         (dump):
1072
1073 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
1074
1075         Reviewed by Lars.
1076
1077         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
1078         
1079
1080         * DumpRenderTree/qt/main.cpp:
1081         * DumpRenderTree/qt/testplugin.cpp:
1082         * DumpRenderTree/qt/testplugin.h:
1083
1084 2008-01-05  Mark Rowe  <mrowe@apple.com>
1085
1086         Reviewed by Alp Toker.
1087
1088         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
1089
1090         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1091         (processWork): Process pending work.
1092         (webViewLoadFinished): Schedule processing of pending work.
1093         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
1094
1095 2008-01-05  Darin Adler  <darin@apple.com>
1096
1097         * Scripts/do-webcore-rename: Some more renaming plans.
1098
1099 2008-01-04  Alice Liu  <alice.liu@apple.com>
1100
1101         Reviewed by Alexey and Darin.
1102
1103         Adding "home" and "end" to DRT's keydown since
1104         DOM key events can't handle keyIdentifiers at this point. 
1105
1106         * DumpRenderTree/mac/EventSendingController.mm:
1107         (-[EventSendingController keyDown:withModifiers:]):
1108         * DumpRenderTree/win/EventSender.cpp:
1109         (keyDownCallback):
1110
1111 2008-01-04  Lars Knoll  <lars@trolltech.com>
1112
1113         Reviewed by Simon.
1114
1115         fix DRT after the changes to QWebPage.
1116         
1117         The great thing is that we actually don't have
1118         any regressions from the QWebPage change :)
1119         
1120
1121         * DumpRenderTree/qt/DumpRenderTree.cpp:
1122         (WebCore::DumpRenderTree::DumpRenderTree):
1123
1124 2008-01-04  Lars Knoll  <lars@trolltech.com>
1125
1126         Reviewed by Simon.
1127
1128         make QWebPage a QObject and get things to compile.
1129         
1130         Nothing works currently though.
1131         
1132
1133         * DumpRenderTree/qt/DumpRenderTree.cpp:
1134         (WebCore::DumpRenderTree::DumpRenderTree):
1135
1136 2008-01-04  Lars Knoll  <lars@trolltech.com>
1137
1138         Reviewed by Simon.
1139
1140         take a QString as identifier in QWebFrame::addToJSWindowObject.
1141
1142         * DumpRenderTree/qt/DumpRenderTree.cpp:
1143         (WebCore::DumpRenderTree::initJSObjects):
1144
1145 2008-01-04  Alp Toker  <alp@atoker.com>
1146
1147         GTK+ DRT build fix for breakage introduced in r29149.
1148
1149         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1150         (LayoutTestController::execCommand):
1151
1152 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1153
1154         Reviewed by Darin.
1155
1156         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
1157
1158         Added layoutTestController.execCommand to access editor commands that are not available
1159         via document.execCommand.
1160
1161         * DumpRenderTree/LayoutTestController.cpp:
1162         (execCommandCallback):
1163         (LayoutTestController::staticFunctions):
1164         * DumpRenderTree/LayoutTestController.h:
1165         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1166         (LayoutTestController::execCommand):
1167         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1168         (LayoutTestController::queueLoad):
1169         (LayoutTestController::execCommand):
1170
1171 2008-01-03  Alice Liu  <alice.liu@apple.com>
1172
1173         Reviewed by Darin, Mitz.
1174
1175         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
1176
1177         the clickcount should not increase if the last click was at a different location.  it's a new click.
1178
1179         * DumpRenderTree/mac/DumpRenderTree.mm:
1180         (runTest):
1181         * DumpRenderTree/mac/EventSendingController.h:
1182         * DumpRenderTree/mac/EventSendingController.mm:
1183         (-[EventSendingController mouseDown]):
1184         (-[EventSendingController mouseUp]):
1185
1186 2008-01-03  Darin Adler  <darin@apple.com>
1187
1188         Reviewed by Adam.
1189
1190         * Scripts/update-webkit: Make this work a little better for the people at Apple
1191         who have a directory named Internal.
1192
1193 2008-01-03  Adam Roben  <aroben@apple.com>
1194
1195         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
1196
1197         Rubberstamped by Mark.
1198
1199         * Scripts/update-webkit-auxiliary-libs:
1200
1201 2008-01-03  Adam Roben  <aroben@apple.com>
1202
1203         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
1204
1205         http://bugs.webkit.org/show_bug.cgi?id=15663
1206
1207         Added a fuzz factor into the Last-Modified comparison for downloading
1208         WebKitAuxiliaryLibrary.zip.
1209
1210         The zip file is served from a set of mirrors who give Last-Modified
1211         times that are off by 1-3 seconds from each other. This was causing
1212         the build bots to redownload WebKitAuxiliaryLibrary for every build,
1213         which would then cause all of WebCore to rebuild each time.
1214
1215         Reviewed by Mark.
1216
1217         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
1218         at least 30 seconds newer than the old one -- otherwise we assume that
1219         the difference in time is due to the mirrors being slightly offset
1220         from each other.
1221         (sub lastModifiedToUnixTime): Added.
1222
1223 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1224
1225         Windows build fix.
1226
1227         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
1228
1229 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1230
1231         Reviewed by Lars.
1232
1233         Moved QWebPage::open to QWebFrame::load and added setHtml.
1234         
1235
1236         * DumpRenderTree/qt/DumpRenderTree.cpp:
1237         (WebCore::DumpRenderTree::open):
1238
1239 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1240
1241         Reviewed by Lars.
1242
1243         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
1244         
1245
1246         * DumpRenderTree/qt/DumpRenderTree.cpp:
1247         (WebCore::DumpRenderTree::DumpRenderTree):
1248
1249 2008-01-02  Sam Weinig  <sam@webkit.org>
1250
1251         * Scripts/do-webcore-rename: Yet more renaming ideas.
1252
1253 2008-01-02  Darin Adler  <darin@apple.com>
1254
1255         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
1256
1257 2008-01-02  Alice Liu  <alice.liu@apple.com>
1258
1259         Reviewed by Sam Weinig.
1260
1261         fixing assertion hit with editing/selection/move-begin-end.html
1262
1263         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
1264         * DumpRenderTree/win/DumpRenderTree.vcproj:
1265         * DumpRenderTree/win/EventSender.cpp:
1266         (keyDownCallback):
1267         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
1268
1269 2008-01-02  Darin Adler  <darin@apple.com>
1270
1271         * Scripts/do-webcore-rename: Some more name change plans.
1272
1273 2008-01-02  Alice Liu  <alice.liu@apple.com>
1274
1275         Reviewed by Maciej.
1276
1277         Added handling for page up and page down in EventSender
1278
1279         * DumpRenderTree/mac/EventSendingController.mm:
1280         (-[EventSendingController keyDown:withModifiers:]):
1281         * DumpRenderTree/win/EventSender.cpp:
1282         (keyDownCallback):
1283
1284 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
1285
1286         Reviewed by Darin.
1287
1288         Fix fast/events/arrow-keys-on-body.html for real.
1289
1290         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
1291
1292 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
1293
1294         Reviewed by Darin.
1295
1296         http://bugs.webkit.org/show_bug.cgi?id=16674
1297         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
1298
1299         * Scripts/run-launcher:
1300
1301 2007-12-31  Darin Adler  <darin@apple.com>
1302
1303         Suggested by Antti.
1304
1305         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
1306         we get it installed on the build bots.
1307
1308 2007-12-30  Eric Seidel  <eric@webkit.org>
1309
1310         Reviewed by Sam.
1311
1312         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
1313
1314 2007-12-29  Darin Adler  <darin@apple.com>
1315
1316         Reviewed by Oliver.
1317
1318         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
1319           leak bot shows createCStringFromNPVariant result leaking
1320
1321         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1322         (pluginInvoke): Added a missing free.
1323
1324 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1325
1326         Reviewed by Alp Toker.
1327
1328         http://bugs.webkit.org/show_bug.cgi?id=16390
1329         Use autotools or GNU make as the build system for the GTK port
1330
1331         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
1332         * GNUmakefile.am: Added.
1333
1334 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
1335
1336         Reviewed by Oliver.
1337
1338         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
1339
1340         * DumpRenderTree/win/EventSender.cpp:
1341         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
1342         of 1, even though WebKit currently ignores it.
1343
1344 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
1345
1346         wx buildbot fix. Update libpng dl script to the latest version.
1347
1348         * wx/install-unix-extras:
1349
1350 2007-12-22  Antti Koivisto  <antti@apple.com>
1351
1352         Fix a typo.
1353
1354         * Scripts/webkitdirs.pm:
1355
1356 2007-12-21  Sam Weinig  <sam@webkit.org>
1357
1358         Reviewed by Mark Rowe.
1359
1360         - Disable the back/forward cache using the new WebPreferences API
1361           instead of through the BackForwardList.  This makes us match what
1362           we do on Windows.
1363
1364         * DumpRenderTree/mac/DumpRenderTree.mm:
1365         (createWebViewAndOffscreenWindow):
1366         (setDefaultsToConsistentValuesForTesting):
1367
1368 2007-12-21  Dan Bernstein  <mitz@apple.com>
1369
1370         Reviewed by Mark Rowe.
1371
1372         - disable the back/forward cache in Windows DumpRenderTree. It is
1373           already disabled in Mac DumpRenderTree.
1374
1375         * DumpRenderTree/win/DumpRenderTree.cpp:
1376         (initializePreferences):
1377
1378 2007-12-13  Antti Koivisto  <antti@apple.com>
1379
1380         Reviewed by Darin and Steve.
1381         
1382         - check for QuickTime SDK on Windows.
1383         - build media support on Windows by default
1384
1385         * Scripts/build-webkit:
1386         * Scripts/webkitdirs.pm:
1387
1388 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
1389
1390         Build script fix for buildbot.
1391
1392         * wx/build-wxwebkit:
1393
1394 2007-12-20  Eric Seidel  <eric@webkit.org>
1395
1396         Reviewed by mjs.
1397
1398         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
1399
1400 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1401
1402         Reviewed by Steve.
1403
1404         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
1405         WebKit.
1406
1407         - Drosera and Safari need to use the same ProgIDs in order for
1408         CoCreateInstance to work properly.  The most robust way to do this is
1409         for WebKit to dynamically publish those ProgIDs.
1410
1411         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
1412         (DebuggerClient::createWebViewWithRequest):
1413         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
1414         statics.
1415         (Drosera::initUI):
1416         (Drosera::attach):
1417         (Drosera::attemptToCreateServerConnection):
1418         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
1419         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
1420         make use of the published ProgIDs.
1421         (ServerConnection::attemptToCreateServerConnection):
1422
1423 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1424
1425         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
1426         - Build bot and leak fix.
1427
1428         * DumpRenderTree/LayoutTestController.cpp:
1429         (pathToLocalResourceCallback):
1430
1431 2007-12-19  David Kilzer  <ddkilzer@apple.com>
1432
1433         Make svn-apply/svn-unapply work with patches from git-format-patch.
1434
1435         Reviewed by Darin.
1436
1437         * Scripts/svn-apply:
1438         (patch): If 'Index:' can't be found in the text passed in, print it
1439         out with a warning and return early.
1440         * Scripts/svn-unapply:
1441         (patch): Ditto.
1442
1443 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
1444
1445         Reviewed by Alp Toker.
1446
1447         Build related fixes.
1448
1449         * wx/build-wxwebkit:
1450         - Check to make sure the user is running a supported wx port
1451         - More robust checks for Cygwin
1452         - Only run install-unix-extras on Mac, it's not the right solution
1453           for Linux distros.
1454         - Remove outdated Linux instructions after successful build
1455         - Clean Bakefile-generated files during a clean operation
1456
1457 2007-12-18  Darin Adler  <darin@apple.com>
1458
1459         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
1460
1461 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
1462
1463         Add script to run Drosera as part of the nightly.
1464         
1465         Reviewed by Kevin M.
1466
1467         * Scripts/run-drosera.cmd: Added.
1468
1469 2007-12-18  Darin Adler  <darin@apple.com>
1470
1471         * Scripts/do-webcore-rename: Remove a stray K.
1472
1473 2007-12-18  Darin Adler  <darin@apple.com>
1474
1475         * Scripts/do-webcore-rename: Plan more renaming.
1476
1477 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
1478
1479         Reviewed by Alp Toker.
1480
1481         http://bugs.webkit.org/show_bug.cgi?id=16042
1482         [GTK] Eliminate webkit_init()
1483
1484         Moving webkit initialization to WebView class init.
1485
1486         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1487         (main):
1488         * GtkLauncher/main.c:
1489         (main):
1490
1491 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
1492
1493         Reviewed by Alp Toker.
1494
1495         http://bugs.webkit.org/show_bug.cgi?id=13542
1496         gdklauncher doesnt change URL in adress GTKEntry.
1497
1498         * GtkLauncher/main.c:
1499         (load_commit_cb): added
1500         (title_change_cb):
1501         (create_browser):
1502
1503 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
1504
1505         Reviewed by Adam Roben.
1506
1507         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
1508
1509         * FindSafari/FindSafari.cpp:
1510         (_tmain):
1511
1512 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
1513
1514         Reviewed by Adam Roben.
1515
1516         http://bugs.webkit.org/show_bug.cgi?id=16315
1517         FindSafari needs a path-only option.
1518
1519         * FindSafari/FindSafari.cpp:
1520         (_tmain):
1521
1522 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
1523
1524         Reviewed by Darin.
1525
1526         http://bugs.webkit.org/show_bug.cgi?id=16462
1527         REGRESSION: access keys broken on Windows
1528
1529         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
1530         if Alt is pressed.
1531
1532 2007-12-15  Sam Weinig  <sam@webkit.org>
1533
1534         Reviewed by Mark Rowe.
1535
1536         Fix urlSuitableForTestResult to correctly identify wstring::npos as
1537         the case when wstring.find doesn't find anything.
1538
1539         * DumpRenderTree/win/DumpRenderTree.cpp:
1540         (urlSuitableForTestResult):
1541
1542 2007-12-15  Alp Toker  <alp@atoker.com>
1543
1544         GTK+ DRT build fix for GLib < 2.14.
1545
1546         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1547         (LayoutTestController::setWaitToDump):
1548
1549 2007-12-05  Mark Rowe  <mrowe@apple.com>
1550
1551         Reviewed by Alp Toker.
1552
1553         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
1554         many layout tests from hanging while waiting on user responses to dialogs.
1555
1556         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1557         (invalidateAnyPreviousWaitToDumpWatchdog):
1558         (webViewScriptAlert):
1559         (webViewScriptPrompt):
1560         (webViewScriptConfirm):
1561         (main):
1562         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1563         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1564         (waitToDumpWatchdogFired):
1565         (LayoutTestController::setWaitToDump):
1566
1567 2007-12-05  Mark Rowe  <mrowe@apple.com>
1568
1569         Reviewed by Alp Toker.
1570
1571         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
1572
1573         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1574         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1575         (dump):
1576         (runTest):
1577         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
1578         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
1579         work queue is empty.
1580         (webViewWindowObjectCleared): Set up window.layoutTestController.
1581         (webViewConsoleMessage): Match the console message format expected by the layout test results.
1582         (main): Hook up the new signals.
1583         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1584         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
1585         dumping multiple times.
1586         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
1587         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
1588
1589 2007-12-14  Anders Carlsson  <andersca@apple.com>
1590
1591         Reviewed by Brady.
1592
1593         Assert that a web frame that's loading a resource always has either a data source or 
1594         a provisional data source.
1595         
1596         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1597         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1598
1599 2007-12-14  Darin Adler  <darin@apple.com>
1600
1601         - fix mistake causing nearly all tests to fail on Windows
1602
1603         * DumpRenderTree/win/UIDelegate.cpp:
1604         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1605         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1606
1607         * DumpRenderTree/mac/UIDelegate.mm:
1608         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1609         than passing the entire message.
1610
1611 2007-12-14  Darin Adler  <darin@apple.com>
1612
1613         - fix Tiger build
1614
1615         * DumpRenderTree/mac/UIDelegate.mm:
1616         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1617         new-to-Leopard methods.
1618
1619 2007-12-14  Darin Adler  <darin@apple.com>
1620
1621         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1622         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1623         delegate methods here.
1624
1625 2007-12-14  Anders Carlsson  <andersca@apple.com>
1626
1627         Reviewed by Darin and Geoff.
1628
1629         <rdar://problem/5619295> 
1630         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1631         
1632         Add property getting methods to the plug-in.
1633         
1634         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1635         (pluginInvoke):
1636
1637 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1638
1639         Reviewed by Darin.
1640
1641         - Layout test fix for mac. When dumped to the console local file paths
1642         now only show the name of the resource not the whole path.  This is to
1643         make the results machine and OS independent.
1644
1645         * DumpRenderTree/mac/UIDelegate.mm:
1646         (-[UIDelegate webView:addMessageToConsole:]):
1647
1648 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1649
1650         Reviewed by Adam.
1651
1652         - Layout tests fix.  We need a way to remove machine-dependent
1653         information from paths in layout test results. The UIDelegate now does
1654         this.
1655
1656         * DumpRenderTree/DumpRenderTree.h:
1657         * DumpRenderTree/win/DumpRenderTree.cpp:
1658         (urlSuitableForTestResult):
1659         * DumpRenderTree/win/DumpRenderTreeWin.h:
1660         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1661         * DumpRenderTree/win/UIDelegate.cpp:
1662         (UIDelegate::webViewAddMessageToConsole):
1663
1664 2007-12-13  Alp Toker  <alp@atoker.com>
1665
1666         Build fix for DRT breakage introduced in r28690.
1667
1668         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1669         (LayoutTestController::pathToLocalResource):
1670
1671 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1672
1673         Reviewed by Alice and Sam.
1674
1675         - <rdar://5621435> Need a way to specify local resources (being loaded
1676         from HTTP tests) on Windows.
1677         - Implemented pathToLocalResource which exposes the functionality of
1678         converting a given unix path to the correct location on Windows.
1679
1680         * DumpRenderTree/LayoutTestController.cpp:
1681         (pathToLocalResourceCallback):
1682         (LayoutTestController::staticFunctions):
1683         * DumpRenderTree/LayoutTestController.h:
1684         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1685         (LayoutTestController::pathToLocalResource):
1686         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1687         (LayoutTestController::pathToLocalResource):
1688
1689 2007-12-12  Anders Carlsson  <andersca@apple.com>
1690
1691         Reviewed by Sam.
1692
1693         <rdar://problem/5132003>
1694         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1695
1696         * DumpRenderTree/win/DumpRenderTree.cpp:
1697         (main):
1698         Set the resource load delegate.
1699         
1700         * DumpRenderTree/win/DumpRenderTree.vcproj:
1701         
1702         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1703         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1704
1705 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1706
1707         Reviewed by Adam Roben.
1708
1709         Fix conversion from double to LPARAM in dispatchMessage().
1710
1711         * DumpRenderTree/win/EventSender.cpp:
1712         (dispatchMessageCallback):
1713
1714 2007-12-11  Dan Bernstein  <mitz@apple.com>
1715
1716         Reviewed by Mark Rowe and Sam Weinig too!
1717
1718         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1719           fonts DumpRenderTree registers.
1720
1721         * DumpRenderTree/win/DumpRenderTree.cpp:
1722         (initialize):
1723
1724 2007-12-11  Brady Eidson  <beidson@apple.com>
1725
1726         Reviewed by Anders
1727
1728         Make DumpRenderTree on mac use its own path for Databases testing
1729
1730         * DumpRenderTree/mac/DumpRenderTree.mm:
1731         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1732           for future DRT-only use, then use it to construct the Databases path and set that default
1733
1734 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1735
1736         Reviewed by Darin.
1737
1738         <rdar://problem/5535636>
1739         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1740
1741         http://bugs.webkit.org/show_bug.cgi?id=13916
1742         JavaScript detects Tab as a character input on a textfield validation
1743
1744         * DumpRenderTree/mac/EventSendingController.mm:
1745         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1746         Dispatch a keyup to better match what happens when a key is physically pressed.
1747
1748         * DumpRenderTree/win/EventSender.cpp:
1749         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1750         returning from keyDown().
1751         (getConstantCallback): Fixed a couple copy/paste mistakes.
1752
1753 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1754
1755         Reviewed by Oliver.
1756
1757         - <rdar://5599845> Drosera: Does not show loal files in the file list
1758         on the left side.
1759
1760         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1761         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1762         so the open source community can build.
1763
1764 2007-12-10  Brady Eidson  <beidson@apple.com>
1765
1766         Rubberstamped by Sam Weinig
1767
1768         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1769
1770         * DumpRenderTree/mac/UIDelegate.mm:
1771         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1772         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1773
1774 2007-12-08  Oliver Hunt  <oliver@apple.com>
1775
1776         Reviewed by Sam W.
1777
1778         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1779         
1780         Fixes <rdar://problem/5620249> Must disable SVG animation
1781         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1782         
1783         In order to allow finer grained control over the set of SVG features
1784         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1785         distinct flags:
1786         ENABLE_SVG_ANIMATION
1787         ENABLE_SVG_FILTERS
1788         ENABLE_SVG_FONTS
1789         ENABLE_SVG_AS_IMAGE
1790         ENABLE_SVG_USE
1791         
1792         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1793         
1794         Script handles all the new build flags, and allows --svg-experimental
1795         to automatically enable all features.
1796
1797         * Scripts/build-webkit:
1798
1799 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1800
1801         Fix version parsing.
1802
1803         Rubber-stamped by Oliver.
1804
1805         * Drosera/win/Drosera.vcproj/auto-version.sh:
1806
1807 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1808
1809         Build modifications for Drosera.
1810
1811         Reviewed by Adam.
1812
1813         * Drosera/DroseraWin.make: Added.
1814         * Drosera/win/Drosera.vcproj/Drosera.rc:
1815         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1816         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1817         * Drosera/win/Drosera.vcproj/VERSION: Added.
1818         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1819
1820 2007-12-06  Adam Roben  <aroben@apple.com>
1821
1822         Explicitly turn on the Mac font ascent hack on Windows
1823
1824         This keeps our font metrics matching those from Mac.
1825
1826         Reviewed by Hyatt.
1827
1828         * DumpRenderTree/win/DumpRenderTree.cpp:
1829         (main):
1830
1831 2007-12-06  Anders Carlsson  <andersca@apple.com>
1832
1833         Rename main.c to main.cpp here too.
1834         
1835         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1836
1837 2007-12-06  Sam Weinig  <sam@webkit.org>
1838
1839         Rubber stamped by Geoff.
1840
1841         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1842
1843 2007-12-06  Darin Adler  <darin@apple.com>
1844
1845         * Scripts/do-webcore-rename: Some more renaming plans.
1846
1847 2007-12-06  Anders Carlsson  <andersca@apple.com>
1848
1849         Restore implementation of testGetIntIdentifier that was accidentally
1850         removed somehow (possibly when I made PluginObject be a cpp file).
1851         
1852         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1853         (pluginInvoke):
1854
1855 2007-12-05  Anders Carlsson  <andersca@apple.com>
1856
1857         Make the entry points extern "C".
1858         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1859         
1860 2007-12-05  Anders Carlsson  <andersca@apple.com>
1861
1862         C++ warning fixes.
1863         
1864         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1865         (NPP_New):
1866         (NPP_Destroy):
1867         (NPP_SetWindow):
1868         (NPP_NewStream):
1869         (NPP_HandleEvent):
1870         (NPP_URLNotify):
1871         (NPP_GetValue):
1872
1873 2007-12-05  Anders Carlsson  <andersca@apple.com>
1874
1875         Add the .cpp files to the TestNetscapePlugIn target.
1876
1877         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1878
1879 2007-12-05  Anders Carlsson  <andersca@apple.com>
1880
1881         Reviewed by Geoff.
1882         
1883         Rename the TestNetscapePlugIn .c files to be .cpp.
1884
1885         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1886         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1887         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1888         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1889         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1890         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1891         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1892         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1893
1894 2007-12-05  Adam Roben  <aroben@apple.com>
1895
1896         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1897
1898         This fixes several regression tests.
1899
1900         Reviewed by Alice.
1901
1902         * DumpRenderTree/win/EventSender.cpp:
1903         (keyDownCallback): Virtual keycodes for ASCII characters are always
1904         uppercase, so we need to check the case of the original character
1905         passed in to eventSender.keyDown.
1906
1907 2007-12-05  Adam Roben  <aroben@apple.com>
1908
1909         Learn from Tim's mistakes
1910
1911         * DumpRenderTree/win/DumpRenderTree.cpp:
1912         (runTest): Reset the authorAndUserStylesEnabled preference for each
1913         test.
1914
1915 2007-12-05  Alp Toker  <alp@atoker.com>
1916
1917         Reviewed by Mark Rowe.
1918
1919         Initialize GTK+ and WebKit so the tests can run.
1920
1921         Reorganize the headers a little.
1922
1923         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1924         (main):
1925
1926 2007-12-04  Anders Carlsson  <andersca@apple.com>
1927
1928         Remove IWebScriptScope include.
1929         
1930         * Drosera/win/DebuggerDocumentPlatform.cpp:
1931
1932 2007-12-04  Sam Weinig  <sam@webkit.org>
1933
1934         Rubber stamped by Mark Rowe.
1935
1936         Define CF as platform for mac and revert r28409
1937
1938         * DumpRenderTree/DumpRenderTree.h:
1939         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1940
1941 2007-12-04  Sam Weinig  <sam@webkit.org>
1942
1943         Define CF as platform for windows.
1944
1945         Reviewed by Adam Roben.
1946
1947         * DumpRenderTree/win/DumpRenderTreeWin.h:
1948
1949 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1950
1951         Reviewed by Adam and Darin.
1952
1953         - Removed a needless BSTR cleanup.
1954
1955         * Drosera/win/DebuggerDocumentPlatform.cpp:
1956         (DebuggerDocument::getPlatformCurrentFunctionStack):
1957
1958 2007-11-27  Adam Roben  <aroben@apple.com>
1959
1960         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1961
1962         Reviewed by Maciej.
1963
1964         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1965         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1966
1967 2007-12-04  Alp Toker  <alp@atoker.com>
1968
1969         Prospective Win DRT build fix.
1970
1971         * DumpRenderTree/DumpRenderTree.h:
1972
1973 2007-12-04  Alp Toker  <alp@atoker.com>
1974
1975         Fix a clobbered copyright header.
1976
1977         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1978
1979 2007-12-04  Xan Lopez  <xan@gnome.org>
1980
1981         Reviewed by Alp Toker.
1982
1983         http://bugs.webkit.org/show_bug.cgi?id=15561
1984         GTK port needs DumpRenderTree implementation
1985
1986         Start work on the GTK+ DRT.
1987
1988         This does not work yet, and there are a few lingering style issues
1989         (nothing major) but this patch has been stuck in the bug tracker for
1990         too long already.
1991
1992         * DumpRenderTree/DumpRenderTree.h:
1993         * DumpRenderTree/gtk: Added.
1994         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1995         (autocorrectURL):
1996         (shouldLogFrameLoadDelegates):
1997         (dumpFrameScrollPosition):
1998         (displayWebView):
1999         (appendString):
2000         (dumpFramesAsText):
2001         (dumpRenderTreeAsText):
2002         (dump):
2003         (runTest):
2004         (main):
2005         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
2006         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
2007         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
2008         (GCController::collect):
2009         (GCController::collectOnAlternateThread):
2010         (GCController::getJSObjectCount):
2011         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
2012         (LayoutTestController::~LayoutTestController):
2013         (LayoutTestController::addDisallowedURL):
2014         (LayoutTestController::clearBackForwardList):
2015         (LayoutTestController::copyDecodedHostName):
2016         (LayoutTestController::copyEncodedHostName):
2017         (LayoutTestController::display):
2018         (LayoutTestController::keepWebHistory):
2019         (LayoutTestController::notifyDone):
2020         (LayoutTestController::queueBackNavigation):
2021         (LayoutTestController::queueForwardNavigation):
2022         (LayoutTestController::queueLoad):
2023         (LayoutTestController::queueReload):
2024         (LayoutTestController::queueScript):
2025         (LayoutTestController::setAcceptsEditing):
2026         (LayoutTestController::setCustomPolicyDelegate):
2027         (LayoutTestController::setMainFrameIsFirstResponder):
2028         (LayoutTestController::setTabKeyCyclesThroughElements):
2029         (LayoutTestController::setUseDashboardCompatibilityMode):
2030         (LayoutTestController::setUserStyleSheetEnabled):
2031         (LayoutTestController::setUserStyleSheetLocation):
2032         (LayoutTestController::setWindowIsKey):
2033         (LayoutTestController::setWaitToDump):
2034         (LayoutTestController::windowCount):
2035         (LayoutTestController::setPrivateBrowsingEnabled):
2036         (LayoutTestController::setAuthorAndUserStylesEnabled):
2037         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
2038         (JSStringCopyUTF8CString):
2039         (LoadItem::invoke):
2040         (ReloadItem::invoke):
2041         (ScriptItem::invoke):
2042         (BackForwardItem::invoke):
2043
2044 2007-12-03  Sam Weinig  <sam@webkit.org>
2045
2046         Move JavaScriptCore thread testing code to pthread specific directory
2047         and remove the dependance on CoreFoundation by using WTF::HashSet.
2048
2049         Reviewed by Geoff and Oliver.
2050
2051         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2052         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
2053         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
2054         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
2055         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
2056         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
2057         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
2058         * DumpRenderTree/pthreads: Added.
2059         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
2060         (javaScriptThreads):
2061         (runJavaScriptThread):
2062         (startJavaScriptThreads):
2063         (stopJavaScriptThreads):
2064
2065 2007-12-03  Andrew Bonventre  <andybons@google.com>
2066
2067         Reviewed by Darin Adler.
2068
2069         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
2070         Symbol lookup menu broken in debugger view
2071
2072         * Drosera/debugger.js: Fixed javascript error where document property
2073         should have been used instead of contentDocument in switchFunction that
2074         was breaking the select symbol dropdown menu.  This is because
2075         window.frames will return a Window object and not a frame object like
2076         the author was originally expecting.
2077
2078 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
2079
2080         Reviewed by Adam.
2081
2082         - <rdar://5618942> Drosera: Console window does not process everything
2083         correctly.
2084         - <rdar://5619005> Drosera: could be sped up by moving the 
2085         WebScriptScope stuff into the WebScriptCallFrame.
2086         - Now the console can correctly process objects and does not receive
2087         notifications from JavaScriptCore about the JavaScript in Drosera's
2088         own process.
2089
2090         * Drosera/win/DebuggerDocumentPlatform.cpp:
2091         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2092         (DebuggerDocument::platformValueForScopeVariableNamed):
2093
2094 2007-12-03  Stephanie  <slewis@apple.com>
2095
2096         Reviewed by Darin.
2097
2098         Check to see if we are building a debug root
2099
2100         * Scripts/check-for-global-initializers: 
2101
2102 2007-12-03  Dan Bernstein  <mitz@apple.com>
2103
2104         Reviewed by Darin Adler.
2105
2106         - added a testGetIntIdentifier() method to TestNetscapePlugIn
2107
2108         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
2109         (pluginInvoke):
2110
2111 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
2112
2113         Reviewed by Oliver.
2114
2115         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
2116         in a more fine-grained manner than eventSender.keyDown().
2117
2118         * DumpRenderTree/win/EventSender.cpp:
2119         (getConstantCallback):
2120         (dispatchMessageCallback):
2121
2122 2007-12-02  Darin Adler  <darin@apple.com>
2123
2124         * Scripts/do-webcore-rename: More planned renaming.
2125
2126 2007-12-02  Sam Weinig  <sam@webkit.org>
2127
2128         Rubber stamped by Anders.
2129
2130         Use [NSURL absoluteString] instead of [NSURL description] in order to get
2131         more uniform results cross platform.
2132
2133         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2134         (-[NSURL _drt_descriptionSuitableForTestResult]):
2135
2136 2007-12-02  Sam Weinig  <sam@webkit.org>
2137
2138         Rubber stamped by Niko.
2139
2140         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
2141
2142         * DumpRenderTree/win/DumpRenderTree.cpp:
2143         * DumpRenderTree/win/DumpRenderTree.vcproj:
2144         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
2145         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
2146         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
2147         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
2148
2149 2007-12-01  Alp Toker  <alp@atoker.com>
2150
2151         Reviewed by Adam Roben.
2152
2153         Make use of the newly introduced webkit.h convenience header.
2154
2155         * GtkLauncher/main.c:
2156
2157 2007-12-01  Adam Treat  <treat@kde.org>
2158
2159         Reviewed by Simon.
2160
2161         * Check to see if the directory exists and exit if not.
2162
2163         * DumpRenderTree/qt/main.cpp:
2164         (main):
2165
2166 2007-12-01  Adam Treat  <treat@kde.org>
2167
2168         Reviewed by Simon.
2169
2170         * Don't hide symbols when in Debug mode
2171         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
2172
2173
2174         * DumpRenderTree/qt/main.cpp:
2175         (messageHandler):
2176
2177 2007-11-30  Alp Toker  <alp@atoker.com>
2178
2179         Reviewed by Adam Roben.
2180
2181         http://bugs.webkit.org/show_bug.cgi?id=15691
2182         [GTK] Public API does not follow GTK+ conventions
2183
2184         Refactor the WebKit/GTK+ public API. Changes:
2185           WebKitPage -> WebKitWebView
2186           WebKitFrame -> WebKitWebFrame
2187
2188         Public API source and header names have been updated to mirror the API
2189         changes.
2190
2191         The API is now kept in WebKit/gtk/WebView to match other ports in the
2192         same class such as Mac and Win.
2193
2194         * GtkLauncher/main.c:
2195         (activate_uri_entry_cb):
2196         (link_hover_cb):
2197         (title_change_cb):
2198         (progress_change_cb):
2199         (go_back_cb):
2200         (go_forward_cb):
2201         (create_browser):
2202         (main):
2203
2204 2007-11-30  Adam Roben  <aroben@apple.com>
2205
2206         Hopefully the final build fix
2207
2208         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
2209         pull in WTF's assertion/logging functions.
2210
2211 2007-11-30  Adam Roben  <aroben@apple.com>
2212
2213         Another build fix
2214
2215         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
2216         WebKit.lib.
2217
2218 2007-11-30  Adam Roben  <aroben@apple.com>
2219
2220         Debug build fix
2221
2222         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
2223         configuration.
2224         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
2225         projects.
2226         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
2227         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
2228         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
2229
2230 2007-11-30  Sam Weinig  <sam@webkit.org>
2231
2232         Reviewed by Adam Roben.
2233
2234         Fix drawSelectionRect to actually draw the selection rect.
2235
2236         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2237         (drawSelectionRect):
2238
2239 2007-11-30  Darin Adler  <darin@apple.com>
2240
2241         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
2242
2243 2007-11-30  Darin Adler  <darin@apple.com>
2244
2245         * Scripts/do-webcore-rename: Get ready for some future renaming.
2246
2247 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2248
2249         Reviewed by Adam.
2250
2251         - Removed some unnecessary functions and changed an unused return type. 
2252
2253         * Drosera/win/DebuggerClient.cpp:
2254         (registerConsoleClass):
2255         * Drosera/win/DebuggerClient.h:
2256         * Drosera/win/Drosera.cpp:
2257         (registerDroseraClass):
2258
2259 2007-11-28  Alp Toker  <alp@atoker.com>
2260
2261         Reviewed by Timothy Hatcher.
2262
2263         http://bugs.webkit.org/show_bug.cgi?id=16174
2264         [GTK] Use "URI" not "URL" in public API
2265
2266         Replace use of the term "URL" with "URI" in public headers,
2267         documentation and some internal code to match GLib/GTK+ convention.
2268
2269         This is now mentioned in the API guidelines:
2270           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
2271
2272         * GtkLauncher/main.c:
2273         (activate_uri_entry_cb):
2274         (title_change_cb):
2275         (create_toolbar):
2276         (main):
2277
2278 2007-11-29  Anders Carlsson  <andersca@apple.com>
2279
2280         Reviewed by Sam.
2281
2282         <rdar://problem/5230478>
2283         FrameLoadDelegate callbacks are not dumped in DRT.
2284         
2285         * DumpRenderTree/win/DumpRenderTree.cpp:
2286         (shouldLogFrameLoadDelegates):
2287         (runTest):
2288         (main):
2289         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2290         (BSTRtoString):
2291         (descriptionSuitableForTestResult):
2292         (FrameLoadDelegate::QueryInterface):
2293         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2294         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2295         (FrameLoadDelegate::didCommitLoadForFrame):
2296         (FrameLoadDelegate::didFinishLoadForFrame):
2297         (FrameLoadDelegate::willCloseFrame):
2298         (FrameLoadDelegate::didClearWindowObject):
2299         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2300         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2301         * DumpRenderTree/win/FrameLoaderDelegate.h:
2302         (FrameLoadDelegate::windowScriptObjectAvailable):
2303         (FrameLoadDelegate::didFirstLayoutInFrame):
2304
2305 2007-11-29  Sam Weinig  <sam@webkit.org>
2306
2307         Reviewed by Anders.
2308
2309         Add database quota UIDelegates methods to DRT UIDelegate.
2310
2311         * DumpRenderTree/mac/UIDelegate.mm:
2312         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2313         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
2314
2315 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2316
2317         Reviewed by Sam.
2318
2319         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
2320         dying and vice versa.
2321         - This fix will allow Drosera and Safari to reconnect if either of them
2322         closes correctly, but does not fix the case where one of them dies
2323         silently.
2324
2325         * Drosera/win/ServerConnection.cpp:
2326         (ServerConnection::attemptToCreateServerConnection): Added a safety
2327         check, because it's possilbe to try to connect to a server that's dying.
2328         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
2329         the server has died.
2330         * Drosera/win/ServerConnection.h: Added the new function and removed
2331         an unnecessary member.
2332
2333 2007-11-29  Anders Carlsson  <andersca@apple.com>
2334
2335         * DumpRenderTree/win/DumpRenderTree.vcproj:
2336         Add shlwapi.lib to all configurations.
2337
2338 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2339
2340         - Build fix.  Added additional includes for VS Express to the Release
2341         project.
2342
2343         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2344
2345 2007-11-29  Anders Carlsson  <andersca@apple.com>
2346
2347         Reviewed by Adam.
2348
2349         <rdar://problem/5132005>
2350         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
2351         
2352         * DumpRenderTree/win/DumpRenderTree.vcproj:
2353         Add shlwapi.lib
2354         
2355         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2356         (LayoutTestController::setUserStyleSheetEnabled):
2357         Implement this.
2358         
2359         (appendComponentToPath):
2360         New method which wraps the Win32 API PathAppend.
2361         
2362         (followShortcuts):
2363         New method which checks if a file points to a shortcut and
2364         follows the shortcut.
2365         
2366         (resolveCygwinPath):
2367         New method that takes a cygwin unix-style path and returns the Win32 path.
2368         
2369         (cfStringRefToWString):
2370         
2371         (LayoutTestController::setUserStyleSheetLocation):
2372         Implement this.
2373
2374 2007-11-29  Alice Liu  <alice.liu@apple.com>
2375
2376         Reviewed by Adam.
2377
2378         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
2379
2380         * DumpRenderTree/win/EventSender.cpp:
2381         (keyDownCallback):
2382         uppercase letters were being sent as lowercase letters without the shift key down.
2383
2384 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2385
2386         - Windows build fix. VS express needs some love.
2387
2388         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2389
2390 2007-11-28  Darin Adler  <darin@apple.com>
2391
2392         Reviewed by Adam Roben.
2393
2394         * DumpRenderTree/mac/EventSendingController.mm:
2395         (-[EventSendingController keyDown:withModifiers:]):
2396         Send capital letters through as lowercase letters with the shift key down
2397         rather than sending them as if they were highly unusual "capital letter keys".
2398
2399         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
2400         where you need to update results and more tests are failing than before.
2401
2402 2007-11-28  Anders Carlsson  <andersca@apple.com>
2403
2404         Reviewed by Darin.
2405
2406         <rdar://problem/5132001>
2407         contextClick is not implemented in DRT on Windows.
2408         
2409         * DumpRenderTree/win/EventSender.cpp:
2410         (contextClickCallback):
2411         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
2412         by a WM_RBUTTONUP message.
2413         
2414         * DumpRenderTree/win/UIDelegate.cpp:
2415         (UIDelegate::hasCustomMenuImplementation):
2416         (UIDelegate::trackCustomPopupMenu):
2417         * DumpRenderTree/win/UIDelegate.h:
2418         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
2419         menu from being shown (and causing the DRT to hang).
2420
2421 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
2422
2423         Reviewed by Darin.
2424
2425         Fix DumpRenderTree ObjC bug comparing strings.
2426
2427         * DumpRenderTree/mac/ObjCController.m:
2428         (-[ObjCController identityIsEqual::]): Compare strings with string
2429         equality instead of identiy equality.
2430
2431 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2432
2433         Reviewed by Sam.
2434
2435         Reset the authorAndUserStylesEnabled preference
2436         back to YES for each test. Fixes the broken tests.
2437
2438         * DumpRenderTree/mac/DumpRenderTree.mm:
2439         (resetWebViewToConsistentStateBeforeTesting):
2440
2441 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
2442
2443         Reviewed by Adam.
2444
2445         - Drosera now displays the console window, although it cannot currently
2446         process JavaScript.
2447
2448         * Drosera/win/DebuggerClient.cpp: Shows the console window.
2449         (registerConsoleClass): Implemented.
2450         (consoleWndProc): Implemented.
2451         (DebuggerClient::onSize): Implemented.
2452         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
2453         new window.
2454         * Drosera/win/DebuggerClient.h: Added needed method and members for 
2455         creating and maintaining a new window.
2456         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
2457         lines of code to more appropriate places.
2458         (Drosera::handleCommand):
2459         (Drosera::initUI):
2460         (Drosera::onSize):
2461         (Drosera::attach):
2462
2463 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2464
2465         Reviewed by Dave Hyatt.
2466
2467         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
2468         
2469         Add support for disabling author and user styles for testing.
2470
2471         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2472         * DumpRenderTree/LayoutTestController.cpp:
2473         (setAuthorAndUserStylesEnabledCallback):
2474         (LayoutTestController::staticFunctions):
2475         * DumpRenderTree/LayoutTestController.h:
2476         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2477         (LayoutTestController::setAuthorAndUserStylesEnabled):
2478         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2479         (LayoutTestController::setAuthorAndUserStylesEnabled):
2480
2481 2007-11-26  Dan Bernstein  <mitz@apple.com>
2482
2483         - Tiger build fix.
2484
2485         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2486
2487 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
2488
2489         Reviewed by Maciej.
2490
2491         - Implemented displaying variables for Drosera on Win.
2492
2493         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
2494         that retrieve variables to not hold onto the return value since it's
2495         not returned.  Also changed to use the new signatures of the retrieval
2496         functions.
2497         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2498         (DebuggerDocument::platformValueForScopeVariableNamed):
2499         * Drosera/win/Drosera.cpp: Removed a needless TODO.
2500         (droseraWndProc):
2501
2502 2007-11-26  Sam Weinig  <sam@webkit.org>
2503
2504         Cleanup names of painting and repainting functions.
2505
2506         Reviewed by Adam Roben.
2507
2508         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2509         (drawSelectionRect): was drawSelectionRectIntoContext.
2510         (dumpWebViewAsPixelsAndCompareWithExpected):
2511         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2512         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2513         (paintWebView): was drawWebViewIntoContext.
2514         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
2515
2516 2007-11-26  Sam Weinig  <sam@webkit.org>
2517
2518         Reviewed by Dan Bernstein.
2519
2520         - Leopard build fix
2521
2522         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2523
2524 2007-11-26  Sam Weinig  <sam@webkit.org>
2525
2526         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
2527         Use shared PixelDumpSupport for Mac DRT
2528
2529         Reviewed by Adam Roben.
2530
2531         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2532         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
2533         * DumpRenderTree/cg/ImageDiffCG.cpp:
2534         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2535         (drawSelectionRectIntoContext):
2536         (dumpWebViewAsPixelsAndCompareWithExpected):
2537         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2538         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2539         * DumpRenderTree/mac/DumpRenderTree.mm:
2540         (dump):
2541         * DumpRenderTree/mac/ImageDiff.m: Removed.
2542         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
2543         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
2544         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
2545         (setDefaultColorProfileToRGB):
2546         (getBitmapContextFromWebView):
2547         (drawWebViewIntoContext):
2548         (repaintWithVerticalSweep):
2549         (repaintWithHorizontalSweep):
2550         (getSelectionRect):
2551         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
2552
2553 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
2554
2555         Bug 16052: prepare-ChangeLog doesn't report deleted files
2556         <http://bugs.webkit.org/show_bug.cgi?id=16052>
2557
2558         Reviewed by Sam.
2559
2560         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
2561
2562 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
2563
2564         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
2565         <http://bugs.webkit.org/show_bug.cgi?id=15864>
2566
2567         Reviewed by Adam.
2568
2569         Roll functionality of merge-changelog into resolve-ChangeLogs
2570         script.  The script now checks for ChangeLog.rej and
2571         ChangeLog.orig files first.  If it finds them, it uses the
2572         ChangeLog.rej file as a patch (in old contextual diff format) to
2573         apply with --fuzz=3.
2574
2575         * Scripts/merge-changelog: Removed.
2576         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2577
2578 2007-11-25  Sam Weinig  <sam@webkit.org>
2579
2580         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
2581
2582         Reviewed by Mark Rowe.
2583
2584         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2585         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2586         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2587         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
2588         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
2589
2590 2007-11-25  Sam Weinig  <sam@webkit.org>
2591
2592         Convert DumpRenderTree to ues .xcconfig files.
2593
2594         Reviewed by Mark Rowe.
2595
2596         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2597         * DumpRenderTree/mac/Configurations: Added.
2598         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2599         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2600         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2601
2602 2007-11-25  Sam Weinig  <sam@webkit.org>
2603
2604         Add ForwardingHeaders to wtf for DumpRenderTree.
2605
2606         Reviewed by Mark Rowe.
2607
2608         * DumpRenderTree/DumpRenderTree.h:
2609         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2610         * DumpRenderTree/ForwardingHeaders: Added.
2611         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2612         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2613         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2614         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2615         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2616         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2617         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2618         * DumpRenderTree/LayoutTestController.cpp:
2619         * DumpRenderTree/WorkQueue.cpp:
2620         * DumpRenderTree/mac/DumpRenderTree.mm:
2621         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2622         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2623         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2624         * DumpRenderTree/mac/ObjCController.m:
2625         * DumpRenderTree/mac/UIDelegate.mm:
2626         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2627
2628 2007-11-25  Adam Roben  <aroben@apple.com>
2629
2630         Fix some test failures caused by r28019
2631
2632         Now that stdout is in binary mode, we need to always use printf
2633         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2634         the output.
2635
2636         Reviewed by Sam.
2637
2638         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2639         printf.
2640         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2641         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2642         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2643         (UIDelegate::webViewAddMessageToConsole):
2644
2645 2007-11-25  Adam Roben  <aroben@apple.com>
2646
2647         Set the font smoothing preference in DRT
2648
2649         This makes the pixel results on Windows closer to the Mac results.
2650
2651         Reviewed by Mitz.
2652
2653         * DumpRenderTree/win/DumpRenderTree.cpp:
2654         (initializePreferences):
2655
2656 2007-11-25  Adam Roben  <aroben@apple.com>
2657
2658         Port ImageDiff to CG and C++
2659
2660         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2661         <rdar://5071708>
2662
2663         Reviewed by Sam.
2664
2665         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2666         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2667         (main):
2668         (createImageFromStdin):
2669         (compareImages):
2670         (getDifferenceBitmap):
2671         (computePercentageDifferent):
2672         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2673
2674 2007-11-25  Adam Roben  <aroben@apple.com>
2675
2676         Fix image diff link generation on Windows
2677
2678         Reviewed by Sam.
2679
2680         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2681         to toURL.
2682
2683 2007-11-25  Adam Roben  <aroben@apple.com>
2684
2685         Implement pixel dumping in Windows DRT
2686
2687         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2688         <rdar://5071708>
2689
2690         Reviewed by Sam.
2691
2692         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2693         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2694         Content-Length header.
2695         (getMD5HashStringForBitmap):
2696         (dumpWebViewAsPixelsAndCompareWithExpected):
2697         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2698         * DumpRenderTree/win/DumpRenderTree.cpp:
2699         (dump): Do a pixel dump if requested.
2700         (main): Parse pixel test options.
2701         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2702         the cg/ subdirectory to the include path.
2703         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2704         available in a header or import library, so we have to go through this
2705         LoadLibrary/GetProcAddress dance to use them.
2706         (cryptDLL):
2707         (init):
2708         (update):
2709         (final):
2710         (MD5_Init):
2711         (MD5_Update):
2712         (MD5_Final):
2713         * DumpRenderTree/win/MD5.h: Added.
2714         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2715         moved up to the top level to share it with Mac eventually.
2716         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2717         (getBitmapContextFromWebView): Forces the WebView to paint using a
2718         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2719
2720 2007-11-25  Adam Roben  <aroben@apple.com>
2721
2722         Clean up Windows DRT's option parsing a little bit
2723
2724         Reviewed by Sam.
2725
2726         * DumpRenderTree/win/DumpRenderTree.cpp:
2727         (main): Put non-option arguments into a Vector.
2728
2729 2007-11-25  Adam Roben  <aroben@apple.com>
2730
2731         Make Windows DRT stop changing LF into CRLF
2732
2733         Reviewed by Sam.
2734
2735         * DumpRenderTree/win/DumpRenderTree.cpp:
2736         (main): Put stdout in binary mode.
2737         * Scripts/run-webkit-tests: Remove the CRLF hack.
2738
2739 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2740
2741         Removed empty directory.
2742
2743         * Scripts/resources: Removed.
2744
2745 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2746
2747         Fix bisect-builds to work with recent WebKit nightly builds.
2748
2749         Reviewed by Dan.
2750
2751         * Scripts/bisect-builds: Check for the 
2752         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2753         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2754         to WebKit.app/Contents/Resources.
2755
2756 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2757
2758         Reviewed by Maciej.
2759
2760         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2761         not closed (affects digg.com)
2762
2763         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2764         one after finishing with a test to avoid having its delayed onload handler firing when
2765         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2766         but it helps somewhat.
2767
2768 2007-11-22  Mark Rowe  <mrowe@apple.com>
2769
2770         Reviewed by Alp Toker.
2771
2772         Fix build-webkit to propagate make's exit status if it fails.
2773
2774         * Scripts/webkitdirs.pm:
2775
2776 2007-11-22  Dan Bernstein  <mitz@apple.com>
2777
2778         Reviewed by Mark Rowe.
2779
2780         - fix crash when running pixel tests
2781
2782         * DumpRenderTree/mac/DumpRenderTree.mm:
2783         (dumpRenderTree): Parse the command line options before setting up the
2784         environment so that we know if we need to set up the pixel dump
2785         machinery.
2786
2787 2007-11-21  Eric Seidel  <eric@webkit.org>
2788
2789         Speculative build fix for Tiger.
2790
2791         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2792
2793 2007-11-21  Eric Seidel  <eric@webkit.org>
2794
2795         Reviewed by Tim Hatcher.
2796
2797         Break out more of DumpRenderTree.mm into individual files
2798
2799         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2800         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2801         (checkedMalloc):
2802         (checkedRealloc):
2803         (makeLargeMallocFailSilently):
2804         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2805         * DumpRenderTree/mac/DumpRenderTree.mm:
2806         (crashHandler):
2807         (dump):
2808         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2809         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2810         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2811         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2812         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2813         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2814         (javaScriptThreads):
2815         (runJavaScriptThread):
2816         (startJavaScriptThreads):
2817         (stopJavaScriptThreads):
2818         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2819         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2820         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2821         (restoreColorSpace):
2822         (setDefaultColorProfileToRGB):
2823         (initializeColorSpaceAndScreeBufferForPixelTests):
2824         (md5HashStringForBitmap):
2825         (dumpWebViewAsPixelsAndCompareWithExpected):
2826
2827 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2828
2829         Move install-unix-extras to wx directory as it seems only to be used by that 
2830         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2831         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2832         have install-unix-extras install into WebKitLibraries as per
2833         convention.
2834         
2835         Reviewed by Mark Rowe.
2836
2837         * Scripts/install-unix-extras: Removed.
2838         * wx/build-wxwebkit:
2839         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2840
2841 2007-11-21  Eric Seidel  <eric@webkit.org>
2842
2843         Reviewed by Adam.
2844
2845         More refactoring for greater code readability
2846
2847         * DumpRenderTree/mac/DumpRenderTree.mm:
2848         (initializeGlobalsFromCommandLineOptions):
2849         (initializeColorSpaceAndScreeBufferForPixelTests):
2850         (addTestPluginsToPluginSearchPath):
2851         (useLongRunningServerMode):
2852         (runTestingServerLoop):
2853         (prepareConsistentTestingEnvironment):
2854         (dumpRenderTree):
2855         (main):
2856         (dumpFramesAsText):
2857         (dumpBackForwardListForWebView):
2858         (sizeWebViewForCurrentTest):
2859         (methodNameStringForFailedTest):
2860         (dumpBackForwardListForAllWindows):
2861         (dumpWebViewAsPixelsAndCompareWithExpected):
2862         (invalidateAnyPreviousWaitToDumpWatchdog):
2863         (dump):
2864         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2865         * DumpRenderTree/mac/UIDelegate.mm:
2866         (-[UIDelegate webView:createWebViewWithRequest:]):
2867
2868 2007-11-21  Eric Seidel  <eric@webkit.org>
2869
2870         Reviewed by Tim Hatcher.
2871
2872         Abstract more of DRT into static methods
2873
2874         * DumpRenderTree/mac/DumpRenderTree.mm:
2875         (setDefaultsToConsistentValuesForTesting):
2876         (setupSignalHandlers):
2877         (allocateGlobalControllers):
2878         (releaseAndZero):
2879         (releaseGlobalControllers):
2880         (dumpRenderTree):
2881         (shouldLogFrameLoadDelegates):
2882         (createCFURLFromPathOrURL):
2883         (resetWebViewToConsistentStateBeforeTesting):
2884         (runTest):
2885
2886 2007-11-21  Eric Seidel  <eric@webkit.org>
2887
2888         Reviewed by Tim Hatcher.
2889
2890         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2891
2892         * DumpRenderTree/DumpRenderTree.h:
2893         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2894         * DumpRenderTree/mac/DumpRenderTree.mm:
2895         (dumpRenderTree):
2896         (dump):
2897         (runTest):
2898         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2899         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2900         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2901         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2902         (-[DumpRenderTreePasteboard declareType:owner:]):
2903         (+[LocalPasteboard alloc]):
2904         (-[LocalPasteboard init]):
2905         (-[LocalPasteboard dealloc]):
2906         (-[LocalPasteboard name]):
2907         (-[LocalPasteboard releaseGlobally]):
2908         (-[LocalPasteboard declareTypes:owner:]):
2909         (-[LocalPasteboard addTypes:owner:]):
2910         (-[LocalPasteboard changeCount]):
2911         (-[LocalPasteboard types]):
2912         (-[LocalPasteboard availableTypeFromArray:]):
2913         (-[LocalPasteboard setData:forType:]):
2914         (-[LocalPasteboard dataForType:]):
2915         (-[LocalPasteboard setPropertyList:forType:]):
2916         (-[LocalPasteboard setString:forType:]):
2917         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2918         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2919         (+[DumpRenderTreeWindow allWindows]):
2920         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2921         (-[DumpRenderTreeWindow dealloc]):
2922         (-[DumpRenderTreeWindow isKeyWindow]):
2923         (-[DumpRenderTreeWindow keyDown:]):
2924
2925 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2926
2927         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2928         it indiscriminately copies any headers inside JavaScriptCore,
2929         which includes Tiger ICU headers. 
2930
2931         * wx/build-wxwebkit:
2932         Don't run WebCore/move-js-headers.sh any longer.
2933
2934 2007-11-20  Adam Treat  <treat@kde.org>
2935
2936         Reviewed by David Kilzer.
2937
2938         * Prepend git branch name to $baseProductDir
2939
2940         * Scripts/VCSUtils.pm:
2941         * Scripts/webkitdirs.pm:
2942
2943 2007-11-20  Mark Rowe  <mrowe@apple.com>
2944
2945         Reviewed by Simon Hausmann.
2946
2947         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2948         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2949         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2950         built product and generated Makefile's are removed.
2951
2952 2007-11-19  Alp Toker  <alp@atoker.com>
2953
2954         Reviewed by Mark Rowe.
2955
2956         http://bugs.webkit.org/show_bug.cgi?id=16040
2957         [GTK] GtkLauncher should be written in C
2958
2959         Port GtkLauncher to plain C.
2960
2961         Use a more conventional GTK+ coding style.
2962
2963         Use a toolbar instead of menus.
2964
2965         Various signature fixes and cleanups.
2966
2967         Add a license header. Assume all previous modifications were copyright
2968         assigned to Apple Inc. by default.
2969
2970         * GtkLauncher/GtkLauncher.pro:
2971         * GtkLauncher/main.c: Added.
2972         (activate_url_entry_cb):
2973         (update_title):
2974         (link_hover_cb):
2975         (title_change_cb):
2976         (progress_change_cb):
2977         (destroy_cb):
2978         (go_back_cb):
2979         (go_forward_cb):
2980         (create_browser):
2981         (create_statusbar):
2982         (create_toolbar):
2983         (create_window):
2984         (main):
2985         * GtkLauncher/main.cpp: Removed.
2986
2987 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2988
2989         Build script fixes to ensure they do the right thing for the 
2990         wx port, and update build-wxwebkit to reflect the way the
2991         build scripts now work.
2992
2993         Reviewed by Adam.
2994
2995         * Scripts/build-testkjs:
2996         * Scripts/build-webkit:
2997         * Scripts/run-javascriptcore-tests:
2998         * Scripts/webkitdirs.pm:
2999         * wx/build-wxwebkit:
3000
3001 2007-11-18  Eric Seidel  <eric@webkit.org>
3002
3003         Reviewed by Anders.
3004
3005         Make run-javascriptcore-tests report failures on exit (to support git bisect)
3006
3007         * Scripts/run-javascriptcore-tests:
3008
3009 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
3010
3011         Reviewed by Adam Roben.
3012
3013         Make run-webkit-tests work with Windows debug build.
3014
3015         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
3016         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
3017         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
3018         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
3019         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
3020
3021 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
3022
3023         Add wxWebKit sample and build script, and integrate it with 
3024         build-webkit. Also make build-webkit --clean work for all
3025         ports.
3026
3027         Reviewed by Darin Adler.
3028
3029         * Scripts/build-webkit:
3030         * Scripts/webkitdirs.pm:
3031         * wx: Added.
3032         * wx/browser: Added.
3033         * wx/browser/browser.bkl: Added.
3034         * wx/browser/browser.cpp: Added.
3035         * wx/build-wxwebkit: Added.
3036
3037 2007-11-17  Adam Roben  <aroben@apple.com>
3038
3039         Make it easy to run Safari in the debugger on Windows
3040
3041         I've added a new script, debug-safari, which launches Safari in the
3042         debugger. On OS X it just calls gdb-safari.
3043
3044         Reviewed by Mark Rowe.
3045
3046         * FindSafari/FindSafari.cpp:
3047         (_tmain): Added a /debugger flag, which in combination with
3048         /printSafariLauncher will print a script that launches Safari in the
3049         debugger.
3050         * Scripts/debug-safari: Added.
3051         * Scripts/run-safari: Changed to call runSafari().
3052         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
3053         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
3054         first argument along to FindSafari.
3055         * Scripts/webkitdirs.pm:
3056         (sub runSafari): Added.
3057
3058 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
3059
3060         Reviewed by Adam Roben.
3061
3062         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
3063
3064 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
3065
3066         Reviewed by David Kilzer.
3067
3068         The git config command was renamed to repo-config at some point. This
3069         change tries git config and then git repo-config if the first fails.
3070
3071         * Scripts/prepare-ChangeLog:
3072         (gitConfig):
3073
3074 2007-11-16  Dan Bernstein  <mitz@apple.com>
3075
3076         Reviewed by Darin Adler and Sam Weinig.
3077
3078         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
3079
3080         * DumpRenderTree/win/EventSender.cpp:
3081         (keyDownCallback): For characters that cannot be entered on the active
3082         keyboard layout, send a WM_CHAR message with the character along with
3083         a WM_KEYDOWN message with a virtual key code of 255.
3084
3085 2007-11-16  Mark Rowe  <mrowe@apple.com>
3086
3087         Reviewed by Tim Hatcher.
3088
3089         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
3090
3091         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3092         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3093
3094 2007-11-15  Adam Roben  <aroben@apple.com>
3095
3096         Make run-safari actually work on Windows
3097
3098         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
3099         chdir call.
3100
3101 2007-11-14  Adam Roben  <aroben@apple.com>
3102
3103         Updates to Safari launching now that 3.0.4 is released
3104
3105         Reviewed by Sam.
3106
3107         * FindSafari/FindSafari.cpp:
3108         (getWebViewCLSID): Use version-independent ProgID.
3109         * Scripts/run-safari: Use run-webkit-nightly.cmd.
3110
3111 2007-11-14  Anders Carlsson  <andersca@apple.com>
3112
3113         Reviewed by Adam.
3114
3115         <rdar://problem/5309081>
3116         In DRT, "plugin.logDestroy = true" not working on Windows.
3117         
3118         * DumpRenderTree/win/TestNetscapePlugin/main.c:
3119         (NPP_Destroy):
3120
3121 2007-11-14  Eric Seidel  <eric@webkit.org>
3122
3123         Reviewed by Sam.
3124
3125         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
3126
3127 2007-11-14  Anders Carlsson  <andersca@apple.com>
3128
3129         Reviewed by Adam.
3130
3131         <rdar://problem/5141186>
3132         window.layoutTestController.setWindowIsKey is not implemented in DRT.
3133         
3134         Implement setWindowIsKey.
3135         
3136         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3137         (LayoutTestController::setWindowIsKey):
3138
3139 2007-11-13  Sam Weinig  <sam@webkit.org>
3140
3141         Reviewed by Adam Roben.
3142
3143         Fix for <rdar://problem/5382579>
3144         http/tests/security/cross-frame-access-put.html reports large 
3145         negative numbers for screenLeft and screenTop (Mac reports "0")
3146
3147         * DumpRenderTree/win/UIDelegate.cpp:
3148         (UIDelegate::UIDelegate): Initialize the RECT.
3149         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
3150         (UIDelegate::webViewFrame): ditto.
3151         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
3152
3153 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
3154
3155         Reviewed by Adam.
3156
3157         - Make Drosera show source, source URLs, and function stack on Windows,
3158         and some minor fixes.
3159
3160         * Drosera/DebuggerDocument.cpp: Force source to always update display.
3161         (DebuggerDocument::updateFileSource):
3162         * Drosera/debugger.js: Force source to always update display.
3163         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
3164         menu controls.
3165         (DebuggerClient::resume):
3166         (DebuggerClient::pause):
3167         (DebuggerClient::stepInto):
3168         (DebuggerClient::stepOver):
3169         (DebuggerClient::stepOut):
3170         (DebuggerClient::showConsole):
3171         (DebuggerClient::closeCurrentFile):
3172         * Drosera/win/DebuggerClient.h: Ditto.
3173         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
3174         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
3175         removed two bugs.  1) caller could be in a bad state when asked to
3176         assign into it. 2) BSTRs were not created correctly.
3177         (DebuggerDocument::getPlatformCurrentFunctionStack):
3178         * Drosera/win/Drosera.cpp: Hook up the menu controls.
3179         (droseraWndProc):
3180         (handleCommand):
3181         (Drosera::resume):
3182         (Drosera::pause):
3183         (Drosera::stepInto):
3184         (Drosera::stepOver):
3185         (Drosera::stepOut):
3186         (Drosera::showConsole):
3187         (Drosera::closeCurrentFile):
3188         * Drosera/win/Drosera.h: Hook up the menu controls.
3189         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
3190         functions, added a null check, and fixed another bug where caller could
3191         be in a bad state when asked to assign into it.
3192         (ServerConnection::didLoadMainResourceForDataSource):
3193         (ServerConnection::getCallerFrame):
3194         * Drosera/win/ServerConnection.h: Safety first.
3195
3196 2007-11-13  Dan Bernstein  <mitz@apple.com>
3197
3198         Reviewed by Darin Adler.
3199
3200         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
3201           DumpRenderTree --pixel-tests renders each test twice
3202
3203         * DumpRenderTree/mac/DumpRenderTree.mm:
3204         (dumpRenderTree): Removed the --paint option because the painting code
3205         is always exercised as a result of
3206         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
3207         calling -displayIfNeeded.
3208         (dump): Changed to always grab the image from the window since the view
3209         is always displayed.
3210         (runTest):
3211         (displayWebView):
3212         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
3213         because it always paints.
3214
3215 2007-11-12  Antti Koivisto  <antti@apple.com>
3216
3217         Reviewed by Adele.
3218         
3219         Add support for http media tests
3220
3221         * Scripts/run-webkit-tests:
3222
3223 2007-11-12  Sam Weinig  <sam@webkit.org>
3224
3225         Reviewed by Adam Roben.
3226
3227         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
3228
3229         * DumpRenderTree/win/DumpRenderTree.cpp:
3230         (runTest):
3231         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3232         (LayoutTestController::setPrivateBrowsingEnabled):
3233
3234 2007-11-12  Adam Roben  <aroben@apple.com>
3235
3236         * Scripts/update-webkit-localizable-strings: Changed to only scan the
3237         mac and win subdirectories.
3238
3239 2007-11-11  Adam Roben  <aroben@apple.com>
3240
3241         Fix <rdar://5133816> keepWebHistory is not implemented
3242
3243         Fixes fast/history/clicked-link-is-visited.html.
3244
3245         Reviewed by Darin.
3246
3247         * DumpRenderTree/win/DumpRenderTree.cpp:
3248         (runTest): Clear the optionalSharedHistory.
3249         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3250         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
3251
3252 2007-11-10  Sam Weinig  <sam@webkit.org>
3253
3254         Reviewed by Tim Hatcher.
3255
3256         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
3257         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
3258         is turned on)
3259
3260         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
3261
3262         Added test: http/tests/security/cross-frame-access-private-browsing.html
3263
3264         * DumpRenderTree/LayoutTestController.cpp:
3265         (setPrivateBrowsingEnabledCallback):
3266         (LayoutTestController::staticFunctions):
3267         * DumpRenderTree/LayoutTestController.h:
3268         * DumpRenderTree/mac/DumpRenderTree.mm:
3269         (runTest): Default to private browsing disabled.
3270         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3271         (LayoutTestController::setPrivateBrowsingEnabled):
3272         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3273         (LayoutTestController::setPrivateBrowsingEnabled):
3274
3275 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3276
3277         Reviewed by Adam.
3278
3279         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
3280         WebCore's!
3281
3282         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3283         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
3284         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3285         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3286         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
3287         * Drosera/win/Drosera.cpp:
3288         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3289
3290 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3291
3292         Reviewed by Sam.
3293
3294         - Use the new IWebFrame [local] function signature and get the shared
3295         server correctly.
3296
3297         * Drosera/win/DebuggerClient.cpp:
3298         (DebuggerClient::didFinishLoadForFrame):
3299         * Drosera/win/ServerConnection.cpp:
3300         (ServerConnection::attemptToCreateServerConnection):
3301
3302 2007-11-07  Dan Bernstein  <mitz@apple.com>
3303
3304         Reviewed by Darin Adler.
3305
3306         - add an option to run-webkit-tests to ignore pixel test failures where
3307           all pixels differ by no more than a specified threshold
3308
3309         * DumpRenderTree/mac/ImageDiff.m:
3310         (main):
3311         (compareImages):
3312         (computePercentageDifferent):
3313         * Scripts/run-webkit-tests:
3314
3315 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3316
3317         Reviewed by Lars.
3318
3319         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
3320
3321         * DumpRenderTree/qt/DumpRenderTree.cpp:
3322
3323 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3324
3325         Reviewed by Lars.
3326
3327         Reworked the QWebSettings API.
3328         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
3329
3330         * DumpRenderTree/qt/DumpRenderTree.cpp:
3331
3332 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3333
3334         Reviewed by Lars.
3335
3336         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
3337
3338         * DumpRenderTree/qt/jsobjects.cpp:
3339
3340 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3341
3342         Reviewed by Lars Knoll <lars@trolltech.com>.
3343
3344         Add a QWebPage::frameCreated() signal and fix DRT
3345         
3346         The removal of createFrame in QWebPage broke the re-implementation
3347         in DumpRenderTree. Instead emit a frameCreated() signal and
3348         connect to it in DumpRenderTree.
3349         
3350
3351         * DumpRenderTree/qt/DumpRenderTree.cpp:
3352         (WebCore::WebPage::WebPage):
3353         (WebCore::DumpRenderTree::dump):
3354         (WebCore::DumpRenderTree::connectFrame):
3355         * DumpRenderTree/qt/DumpRenderTree.h:
3356
3357 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3358
3359         Reviewed by Lars Knoll <lars@trolltech.com>.
3360
3361         Moved all the event handlers from QWebFrame into QWebPage.
3362         
3363         This cleans up the public API and allows us to remove the
3364         HackWebFrame hack in DumpRenderTree.
3365         
3366
3367         * DumpRenderTree/qt/jsobjects.cpp:
3368         (EventSender::mouseDown):
3369         (EventSender::mouseUp):
3370         (EventSender::mouseMoveTo):
3371
3372 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3373
3374         Reviewed by Mark.
3375
3376         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
3377         to prevent the default implementation from popping up messageboxes.
3378
3379         * DumpRenderTree/qt/DumpRenderTree.cpp:
3380         (WebCore::WebPage::javaScriptConfirm):
3381         (WebCore::WebPage::javaScriptPrompt):
3382
3383 2007-11-06  Eric Seidel  <eric@webkit.org>
3384
3385         * Scripts/build-testkjs: build fix... too many $$
3386
3387 2007-11-06  Eric Seidel  <eric@webkit.org>
3388
3389         Reviewed by Mark Rowe.
3390
3391         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
3392
3393 2007-11-05  Adam Roben  <aroben@apple.com>
3394
3395         Add support on Windows for WEBKIT_TESTFONTS
3396
3397         This environment variable lets you specify where the fonts to be used
3398         by DumpRenderTree reside. The Qt port is already using this, so I'm
3399         just following their lead.
3400
3401         Reviewed by Darin.
3402
3403         * DumpRenderTree/win/DumpRenderTree.cpp:
3404         (exePath): Refactored code out of initialize().
3405         (fontsPath): Returns either $WEBKIT_TESTFONTS or
3406         DumpRenderTree.resources.
3407         (initialize): Use the new fontsPath function.
3408         (main): Use the new exePath function.
3409         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
3410         variable to DRT, like Qt does.
3411
3412 2007-11-05  Mark Rowe  <mrowe@apple.com>
3413
3414         Rubber-stamped by Alp Toker.
3415
3416         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
3417
3418         * GtkLauncher/main.cpp:
3419         (goToURLBarText):
3420         (main):
3421
3422 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
3423
3424         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
3425         <http://bugs.webkit.org/show_bug.cgi?id=15830>
3426
3427         Reviewed by Timothy.
3428
3429         Restrict the range of nightly builds used by the bisect-builds script
3430         based on the version of Safari and the version of Mac OS X being used.
3431
3432         Mac OS X 10.4: Safari 2.0: r11976 or newer
3433         Mac OS X 10.4: Safari 3.0: r19992 or newer
3434
3435         Mac OS X 10.5: Safari 2.0: r19594 or newer
3436         Mac OS X 10.5: Safari 3.0: r25124 or newer
3437
3438         * Scripts/bisect-builds:
3439         (findMacOSXVersion): Added.
3440         (makeNightlyList): Added argument to provide version of Mac OS X.
3441         Restrict range of nightly builds based on Safari and Mac OS X versions.
3442
3443 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
3444
3445         Reviewed by Maciej.
3446
3447         - This patch involves several changes, all of them were noticed that
3448         they were needed by the work being done in WebKit to get Drosera and
3449         WebKit working together on Windows.
3450         - The changes are:
3451         1) Added a debugger console for output messages.
3452         2) Drosera now listens for the WebKit server (before, the server would
3453         have to be running before Drosera was started.)
3454         3) Fixed a bug where the WebView started out as 0x0 pixels.
3455         4) Fixed a bug when there is no scope.
3456         5) Added the HTML, JS, and CSS to the project file to make them easy to
3457         find.
3458         6) Made the ServerConnection functions virtual.
3459
3460         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
3461         for the WebKit server.
3462         (DebuggerClient::DebuggerClient):
3463         (DebuggerClient::~DebuggerClient):
3464         (DebuggerClient::didFinishLoadForFrame):
3465         (DebuggerClient::serverConnected):
3466         (DebuggerClient::attemptToCreateServerConnection):
3467         * Drosera/win/DebuggerClient.h: Ditto.
3468         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
3469         scope.
3470         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3471         (DebuggerDocument::platformValueForScopeVariableNamed):
3472         * Drosera/win/Drosera.cpp:
3473         (_tWinMain): Added a console in debug for output messages.
3474         (Drosera::Drosera): Listen for server.
3475         (Drosera::initUI): The server now Initializes COM.
3476         (Drosera::serverConnected): Part of the listening for the server.
3477         (Drosera::attemptToCreateServerConnection): Ditto.
3478         * Drosera/win/Drosera.h: New interface for listening for the server.
3479         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
3480         files to the VS project.
3481         * Drosera/win/ServerConnection.cpp: Part of listening for the server
3482         connection.
3483         (ServerConnection::ServerConnection):
3484         (ServerConnection::attemptToCreateServerConnection):
3485         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
3486         methods.
3487         (ServerConnection::serverConnected):
3488
3489 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
3490
3491         Reviewed by Maciej.
3492
3493         http://bugs.webkit.org/show_bug.cgi?id=15832
3494         fast/dom/gc-10.html crashes when run alone
3495
3496         Check for !done before using objects that can be already deallocated.
3497
3498         * DumpRenderTree/mac/EditingDelegate.mm:
3499         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3500         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3501         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3502         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3503         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3504         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3505         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3506         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3507         (-[EditingDelegate webViewDidBeginEditing:]):
3508         (-[EditingDelegate webViewDidChange:]):
3509         (-[EditingDelegate webViewDidEndEditing:]):
3510         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3511         (-[EditingDelegate webViewDidChangeSelection:]):
3512         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3513         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3514         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3515         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3516         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3517         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3518         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3519         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3520         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3521         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3522         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3523         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3524         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3525         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3526         (-[FrameLoadDelegate webView:willCloseFrame:]):
3527         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3528         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3529         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3530         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3531         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3532         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3533         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3534         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3535         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3536
3537 2007-11-04  Mark Rowe  <mrowe@apple.com>
3538
3539         Build fix.  Don't use Carbon.h as the prefix header as it triggers
3540         warnings that would otherwise be suppressed due to it being a system header.
3541
3542         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3543
3544 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
3545
3546         Rubber stamped by Adam.
3547         
3548         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
3549
3550         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3551
3552 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3553
3554         Sort files(...); sections of Xcode project files.
3555
3556         Rubber-stamped by Darin.
3557
3558         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3559         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3560         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3561         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3562
3563 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3564
3565         Script to sort "files(...);" sections in Xcode project.pbxproj files.
3566
3567         Reviewed by Darin.
3568
3569         * Scripts/sort-Xcode-project-file: Added.
3570
3571 2007-11-02  Darin Adler  <darin@apple.com>
3572
3573         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
3574
3575 2007-11-02  Darin Adler  <darin@apple.com>
3576
3577         Reviewed by Maciej.
3578
3579         * Scripts/run-sunspider: Pass the "--base" option through.
3580
3581         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
3582         the real script do that. Default configuration to Release to match run-sunspider
3583         so we don't end up building Debug just to compare results.
3584
3585 2007-11-01  Adam Roben  <aroben@apple.com>
3586
3587         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
3588
3589         Reviewed by Sam.
3590
3591         * Scripts/commit-log-editor: Show all the directories beneath the
3592         source root, instead of just the last one.
3593
3594 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
3595
3596         Reviewed by Adam Roben.
3597
3598         Print out an error message when the Windows build fails
3599         and provide guidance on how to find out what went wrong.
3600
3601         * Scripts/build-webkit:
3602         * Scripts/webkitdirs.pm:
3603
3604 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
3605
3606         Rubber-stamped by Adam Roben.
3607
3608         Rolled out r27326 - debug CRT seems to cause no problems after all.
3609
3610         * DumpRenderTree/win/DumpRenderTree.vcproj:
3611
3612 2007-10-31  Adam Roben  <aroben@apple.com>
3613
3614         Switch the Debug configuration to using the non-debug CRT
3615
3616         This matches WebKit.
3617
3618         Reviewed by Steve.
3619
3620         * DumpRenderTree/win/DumpRenderTree.vcproj:
3621
3622 2007-10-31  Antti Koivisto  <antti@apple.com>
3623
3624         Reviewed by bdash.
3625         
3626         Disable media tests when doing leak checking on Tiger.
3627         They crash in QuickTime (rdar://problem/5537157).
3628
3629         * Scripts/run-webkit-tests:
3630
3631 2007-10-29  Antti Koivisto  <antti@apple.com>
3632
3633         Reviewed by Maciej.
3634         
3635         Build media support by default on OSX only.
3636
3637         * Scripts/build-webkit:
3638
3639 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3640
3641         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
3642         get caught by the pre-commit hooks.
3643
3644 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3645
3646         Reviewed by Adam.
3647
3648         - This is a collection of relatively unrelated changes and cleanups
3649         to Drosera to prepare it for interacting with WebKit.  A lot of these
3650         changes are just correcting mistakes, for example removing included
3651         headers that are no longer needed.
3652
3653         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3654         this will be needed by the DebuggerClient.
3655         (DebuggerDocument::server):
3656         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3657         * Drosera/win/DebuggerClient.cpp: 
3658         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3659         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3660         (DebuggerClient::createWebViewWithRequest): Added comment about its
3661         purpose. 
3662         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3663         declarations.