WebKitTools/ChangeLog

   1 2007-12-11  Brady Eidson  <beidson@apple.com>
   2
   3         Reviewed by Anders
   4
   5         Make DumpRenderTree on mac use its own path for Databases testing
   6
   7         * DumpRenderTree/mac/DumpRenderTree.mm:
   8         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree
   9           for future DRT-only use, then use it to construct the Databases path and set that default
  10
  11 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
  12
  13         Reviewed by Darin.
  14
  15         <rdar://problem/5535636>
  16         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
  17
  18         http://bugs.webkit.org/show_bug.cgi?id=13916
  19         JavaScript detects Tab as a character input on a textfield validation
  20
  21         * DumpRenderTree/mac/EventSendingController.mm:
  22         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
  23         Dispatch a keyup to better match what happens when a key is physically pressed.
  24
  25         * DumpRenderTree/win/EventSender.cpp:
  26         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
  27         returning from keyDown().
  28         (getConstantCallback): Fixed a couple copy/paste mistakes.
  29
  30 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
  31
  32         Reviewed by Oliver.
  33
  34         - <rdar://5599845> Drosera: Does not show loal files in the file list
  35         on the left side.
  36
  37         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
  38         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
  39         so the open source community can build.
  40
  41 2007-12-10  Brady Eidson  <beidson@apple.com>
  42
  43         Rubberstamped by Sam Weinig
  44
  45         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
  46
  47         * DumpRenderTree/mac/UIDelegate.mm:
  48         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
  49         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
  50
  51 2007-12-08  Oliver Hunt  <oliver@apple.com>
  52
  53         Reviewed by Sam W.
  54
  55         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
  56
  57         Fixes <rdar://problem/5620249> Must disable SVG animation
  58         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
  59
  60         In order to allow finer grained control over the set of SVG features
  61         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
  62         distinct flags:
  63         ENABLE_SVG_ANIMATION
  64         ENABLE_SVG_FILTERS
  65         ENABLE_SVG_FONTS
  66         ENABLE_SVG_AS_IMAGE
  67         ENABLE_SVG_USE
  68
  69         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
  70
  71         Script handles all the new build flags, and allows --svg-experimental
  72         to automatically enable all features.
  73
  74         * Scripts/build-webkit:
  75
  76 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
  77
  78         Fix version parsing.
  79
  80         Rubber-stamped by Oliver.
  81
  82         * Drosera/win/Drosera.vcproj/auto-version.sh:
  83
  84 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
  85
  86         Build modifications for Drosera.
  87
  88         Reviewed by Adam.
  89
  90         * Drosera/DroseraWin.make: Added.
  91         * Drosera/win/Drosera.vcproj/Drosera.rc:
  92         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
  93         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
  94         * Drosera/win/Drosera.vcproj/VERSION: Added.
  95         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
  96
  97 2007-12-06  Adam Roben  <aroben@apple.com>
  98
  99         Explicitly turn on the Mac font ascent hack on Windows
 100
 101         This keeps our font metrics matching those from Mac.
 102
 103         Reviewed by Hyatt.
 104
 105         * DumpRenderTree/win/DumpRenderTree.cpp:
 106         (main):
 107
 108 2007-12-06  Anders Carlsson  <andersca@apple.com>
 109
 110         Rename main.c to main.cpp here too.
 111
 112         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
 113
 114 2007-12-06  Sam Weinig  <sam@webkit.org>
 115
 116         Rubber stamped by Geoff.
 117
 118         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
 119
 120 2007-12-06  Darin Adler  <darin@apple.com>
 121
 122         * Scripts/do-webcore-rename: Some more renaming plans.
 123
 124 2007-12-06  Anders Carlsson  <andersca@apple.com>
 125
 126         Restore implementation of testGetIntIdentifier that was accidentally
 127         removed somehow (possibly when I made PluginObject be a cpp file).
 128
 129         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 130         (pluginInvoke):
 131
 132 2007-12-05  Anders Carlsson  <andersca@apple.com>
 133
 134         Make the entry points extern "C".
 135         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
 136
 137 2007-12-05  Anders Carlsson  <andersca@apple.com>
 138
 139         C++ warning fixes.
 140
 141         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
 142         (NPP_New):
 143         (NPP_Destroy):
 144         (NPP_SetWindow):
 145         (NPP_NewStream):
 146         (NPP_HandleEvent):
 147         (NPP_URLNotify):
 148         (NPP_GetValue):
 149
 150 2007-12-05  Anders Carlsson  <andersca@apple.com>
 151
 152         Add the .cpp files to the TestNetscapePlugIn target.
 153
 154         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 155
 156 2007-12-05  Anders Carlsson  <andersca@apple.com>
 157
 158         Reviewed by Geoff.
 159
 160         Rename the TestNetscapePlugIn .c files to be .cpp.
 161
 162         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 163         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
 164         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
 165         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
 166         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
 167         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
 168         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
 169         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
 170
 171 2007-12-05  Adam Roben  <aroben@apple.com>
 172
 173         Fix case of keypresses from the Windows implementation of eventSender.keyDown
 174
 175         This fixes several regression tests.
 176
 177         Reviewed by Alice.
 178
 179         * DumpRenderTree/win/EventSender.cpp:
 180         (keyDownCallback): Virtual keycodes for ASCII characters are always
 181         uppercase, so we need to check the case of the original character
 182         passed in to eventSender.keyDown.
 183
 184 2007-12-05  Adam Roben  <aroben@apple.com>
 185
 186         Learn from Tim's mistakes
 187
 188         * DumpRenderTree/win/DumpRenderTree.cpp:
 189         (runTest): Reset the authorAndUserStylesEnabled preference for each
 190         test.
 191
 192 2007-12-05  Alp Toker  <alp@atoker.com>
 193
 194         Reviewed by Mark Rowe.
 195
 196         Initialize GTK+ and WebKit so the tests can run.
 197
 198         Reorganize the headers a little.
 199
 200         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 201         (main):
 202
 203 2007-12-04  Anders Carlsson  <andersca@apple.com>
 204
 205         Remove IWebScriptScope include.
 206
 207         * Drosera/win/DebuggerDocumentPlatform.cpp:
 208
 209 2007-12-04  Sam Weinig  <sam@webkit.org>
 210
 211         Rubber stamped by Mark Rowe.
 212
 213         Define CF as platform for mac and revert r28409
 214
 215         * DumpRenderTree/DumpRenderTree.h:
 216         * DumpRenderTree/mac/DumpRenderTreeMac.h:
 217
 218 2007-12-04  Sam Weinig  <sam@webkit.org>
 219
 220         Define CF as platform for windows.
 221
 222         Reviewed by Adam Roben.
 223
 224         * DumpRenderTree/win/DumpRenderTreeWin.h:
 225
 226 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
 227
 228         Reviewed by Adam and Darin.
 229
 230         - Removed a needless BSTR cleanup.
 231
 232         * Drosera/win/DebuggerDocumentPlatform.cpp:
 233         (DebuggerDocument::getPlatformCurrentFunctionStack):
 234
 235 2007-11-27  Adam Roben  <aroben@apple.com>
 236
 237         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
 238
 239         Reviewed by Maciej.
 240
 241         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 242         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
 243
 244 2007-12-04  Alp Toker  <alp@atoker.com>
 245
 246         Prospective Win DRT build fix.
 247
 248         * DumpRenderTree/DumpRenderTree.h:
 249
 250 2007-12-04  Alp Toker  <alp@atoker.com>
 251
 252         Fix a clobbered copyright header.
 253
 254         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 255
 256 2007-12-04  Xan Lopez  <xan@gnome.org>
 257
 258         Reviewed by Alp Toker.
 259
 260         http://bugs.webkit.org/show_bug.cgi?id=15561
 261         GTK port needs DumpRenderTree implementation
 262
 263         Start work on the GTK+ DRT.
 264
 265         This does not work yet, and there are a few lingering style issues
 266         (nothing major) but this patch has been stuck in the bug tracker for
 267         too long already.
 268
 269         * DumpRenderTree/DumpRenderTree.h:
 270         * DumpRenderTree/gtk: Added.
 271         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
 272         (autocorrectURL):
 273         (shouldLogFrameLoadDelegates):
 274         (dumpFrameScrollPosition):
 275         (displayWebView):
 276         (appendString):
 277         (dumpFramesAsText):
 278         (dumpRenderTreeAsText):
 279         (dump):
 280         (runTest):
 281         (main):
 282         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
 283         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
 284         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
 285         (GCController::collect):
 286         (GCController::collectOnAlternateThread):
 287         (GCController::getJSObjectCount):
 288         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
 289         (LayoutTestController::~LayoutTestController):
 290         (LayoutTestController::addDisallowedURL):
 291         (LayoutTestController::clearBackForwardList):
 292         (LayoutTestController::copyDecodedHostName):
 293         (LayoutTestController::copyEncodedHostName):
 294         (LayoutTestController::display):
 295         (LayoutTestController::keepWebHistory):
 296         (LayoutTestController::notifyDone):
 297         (LayoutTestController::queueBackNavigation):
 298         (LayoutTestController::queueForwardNavigation):
 299         (LayoutTestController::queueLoad):
 300         (LayoutTestController::queueReload):
 301         (LayoutTestController::queueScript):
 302         (LayoutTestController::setAcceptsEditing):
 303         (LayoutTestController::setCustomPolicyDelegate):
 304         (LayoutTestController::setMainFrameIsFirstResponder):
 305         (LayoutTestController::setTabKeyCyclesThroughElements):
 306         (LayoutTestController::setUseDashboardCompatibilityMode):
 307         (LayoutTestController::setUserStyleSheetEnabled):
 308         (LayoutTestController::setUserStyleSheetLocation):
 309         (LayoutTestController::setWindowIsKey):
 310         (LayoutTestController::setWaitToDump):
 311         (LayoutTestController::windowCount):
 312         (LayoutTestController::setPrivateBrowsingEnabled):
 313         (LayoutTestController::setAuthorAndUserStylesEnabled):
 314         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
 315         (JSStringCopyUTF8CString):
 316         (LoadItem::invoke):
 317         (ReloadItem::invoke):
 318         (ScriptItem::invoke):
 319         (BackForwardItem::invoke):
 320
 321 2007-12-03  Sam Weinig  <sam@webkit.org>
 322
 323         Move JavaScriptCore thread testing code to pthread specific directory
 324         and remove the dependance on CoreFoundation by using WTF::HashSet.
 325
 326         Reviewed by Geoff and Oliver.
 327
 328         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 329         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
 330         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
 331         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
 332         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
 333         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
 334         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
 335         * DumpRenderTree/pthreads: Added.
 336         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
 337         (javaScriptThreads):
 338         (runJavaScriptThread):
 339         (startJavaScriptThreads):
 340         (stopJavaScriptThreads):
 341
 342 2007-12-03  Andrew Bonventre  <andybons@google.com>
 343
 344         Reviewed by Darin Adler.
 345
 346         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
 347         Symbol lookup menu broken in debugger view
 348
 349         * Drosera/debugger.js: Fixed javascript error where document property
 350         should have been used instead of contentDocument in switchFunction that
 351         was breaking the select symbol dropdown menu.  This is because
 352         window.frames will return a Window object and not a frame object like
 353         the author was originally expecting.
 354
 355 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
 356
 357         Reviewed by Adam.
 358
 359         - <rdar://5618942> Drosera: Console window does not process everything
 360         correctly.
 361         - <rdar://5619005> Drosera: could be sped up by moving the
 362         WebScriptScope stuff into the WebScriptCallFrame.
 363         - Now the console can correctly process objects and does not receive
 364         notifications from JavaScriptCore about the JavaScript in Drosera's
 365         own process.
 366
 367         * Drosera/win/DebuggerDocumentPlatform.cpp:
 368         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 369         (DebuggerDocument::platformValueForScopeVariableNamed):
 370
 371 2007-12-03  Stephanie  <slewis@apple.com>
 372
 373         Reviewed by Darin.
 374
 375         Check to see if we are building a debug root
 376
 377         * Scripts/check-for-global-initializers:
 378
 379 2007-12-03  Dan Bernstein  <mitz@apple.com>
 380
 381         Reviewed by Darin Adler.
 382
 383         - added a testGetIntIdentifier() method to TestNetscapePlugIn
 384
 385         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
 386         (pluginInvoke):
 387
 388 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
 389
 390         Reviewed by Oliver.
 391
 392         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
 393         in a more fine-grained manner than eventSender.keyDown().
 394
 395         * DumpRenderTree/win/EventSender.cpp:
 396         (getConstantCallback):
 397         (dispatchMessageCallback):
 398
 399 2007-12-02  Darin Adler  <darin@apple.com>
 400
 401         * Scripts/do-webcore-rename: More planned renaming.
 402
 403 2007-12-02  Sam Weinig  <sam@webkit.org>
 404
 405         Rubber stamped by Anders.
 406
 407         Use [NSURL absoluteString] instead of [NSURL description] in order to get
 408         more uniform results cross platform.
 409
 410         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 411         (-[NSURL _drt_descriptionSuitableForTestResult]):
 412
 413 2007-12-02  Sam Weinig  <sam@webkit.org>
 414
 415         Rubber stamped by Niko.
 416
 417         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
 418
 419         * DumpRenderTree/win/DumpRenderTree.cpp:
 420         * DumpRenderTree/win/DumpRenderTree.vcproj:
 421         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
 422         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
 423         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
 424         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
 425
 426 2007-12-01  Alp Toker  <alp@atoker.com>
 427
 428         Reviewed by Adam Roben.
 429
 430         Make use of the newly introduced webkit.h convenience header.
 431
 432         * GtkLauncher/main.c:
 433
 434 2007-12-01  Adam Treat  <treat@kde.org>
 435
 436         Reviewed by Simon.
 437
 438         * Check to see if the directory exists and exit if not.
 439
 440         * DumpRenderTree/qt/main.cpp:
 441         (main):
 442
 443 2007-12-01  Adam Treat  <treat@kde.org>
 444
 445         Reviewed by Simon.
 446
 447         * Don't hide symbols when in Debug mode
 448         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
 449
 450
 451         * DumpRenderTree/qt/main.cpp:
 452         (messageHandler):
 453
 454 2007-11-30  Alp Toker  <alp@atoker.com>
 455
 456         Reviewed by Adam Roben.
 457
 458         http://bugs.webkit.org/show_bug.cgi?id=15691
 459         [GTK] Public API does not follow GTK+ conventions
 460
 461         Refactor the WebKit/GTK+ public API. Changes:
 462           WebKitPage -> WebKitWebView
 463           WebKitFrame -> WebKitWebFrame
 464
 465         Public API source and header names have been updated to mirror the API
 466         changes.
 467
 468         The API is now kept in WebKit/gtk/WebView to match other ports in the
 469         same class such as Mac and Win.
 470
 471         * GtkLauncher/main.c:
 472         (activate_uri_entry_cb):
 473         (link_hover_cb):
 474         (title_change_cb):
 475         (progress_change_cb):
 476         (go_back_cb):
 477         (go_forward_cb):
 478         (create_browser):
 479         (main):
 480
 481 2007-11-30  Adam Roben  <aroben@apple.com>
 482
 483         Hopefully the final build fix
 484
 485         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
 486         pull in WTF's assertion/logging functions.
 487
 488 2007-11-30  Adam Roben  <aroben@apple.com>
 489
 490         Another build fix
 491
 492         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
 493         WebKit.lib.
 494
 495 2007-11-30  Adam Roben  <aroben@apple.com>
 496
 497         Debug build fix
 498
 499         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
 500         configuration.
 501         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
 502         projects.
 503         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
 504         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
 505         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
 506
 507 2007-11-30  Sam Weinig  <sam@webkit.org>
 508
 509         Reviewed by Adam Roben.
 510
 511         Fix drawSelectionRect to actually draw the selection rect.
 512
 513         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 514         (drawSelectionRect):
 515
 516 2007-11-30  Darin Adler  <darin@apple.com>
 517
 518         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
 519
 520 2007-11-30  Darin Adler  <darin@apple.com>
 521
 522         * Scripts/do-webcore-rename: Get ready for some future renaming.
 523
 524 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 525
 526         Reviewed by Adam.
 527
 528         - Removed some unnecessary functions and changed an unused return type.
 529
 530         * Drosera/win/DebuggerClient.cpp:
 531         (registerConsoleClass):
 532         * Drosera/win/DebuggerClient.h:
 533         * Drosera/win/Drosera.cpp:
 534         (registerDroseraClass):
 535
 536 2007-11-28  Alp Toker  <alp@atoker.com>
 537
 538         Reviewed by Timothy Hatcher.
 539
 540         http://bugs.webkit.org/show_bug.cgi?id=16174
 541         [GTK] Use "URI" not "URL" in public API
 542
 543         Replace use of the term "URL" with "URI" in public headers,
 544         documentation and some internal code to match GLib/GTK+ convention.
 545
 546         This is now mentioned in the API guidelines:
 547           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
 548
 549         * GtkLauncher/main.c:
 550         (activate_uri_entry_cb):
 551         (title_change_cb):
 552         (create_toolbar):
 553         (main):
 554
 555 2007-11-29  Anders Carlsson  <andersca@apple.com>
 556
 557         Reviewed by Sam.
 558
 559         <rdar://problem/5230478>
 560         FrameLoadDelegate callbacks are not dumped in DRT.
 561
 562         * DumpRenderTree/win/DumpRenderTree.cpp:
 563         (shouldLogFrameLoadDelegates):
 564         (runTest):
 565         (main):
 566         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
 567         (BSTRtoString):
 568         (descriptionSuitableForTestResult):
 569         (FrameLoadDelegate::QueryInterface):
 570         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
 571         (FrameLoadDelegate::didFailProvisionalLoadWithError):
 572         (FrameLoadDelegate::didCommitLoadForFrame):
 573         (FrameLoadDelegate::didFinishLoadForFrame):
 574         (FrameLoadDelegate::willCloseFrame):
 575         (FrameLoadDelegate::didClearWindowObject):
 576         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
 577         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
 578         * DumpRenderTree/win/FrameLoaderDelegate.h:
 579         (FrameLoadDelegate::windowScriptObjectAvailable):
 580         (FrameLoadDelegate::didFirstLayoutInFrame):
 581
 582 2007-11-29  Sam Weinig  <sam@webkit.org>
 583
 584         Reviewed by Anders.
 585
 586         Add database quota UIDelegates methods to DRT UIDelegate.
 587
 588         * DumpRenderTree/mac/UIDelegate.mm:
 589         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
 590         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
 591
 592 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 593
 594         Reviewed by Sam.
 595
 596         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
 597         dying and vice versa.
 598         - This fix will allow Drosera and Safari to reconnect if either of them
 599         closes correctly, but does not fix the case where one of them dies
 600         silently.
 601
 602         * Drosera/win/ServerConnection.cpp:
 603         (ServerConnection::attemptToCreateServerConnection): Added a safety
 604         check, because it's possilbe to try to connect to a server that's dying.
 605         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
 606         the server has died.
 607         * Drosera/win/ServerConnection.h: Added the new function and removed
 608         an unnecessary member.
 609
 610 2007-11-29  Anders Carlsson  <andersca@apple.com>
 611
 612         * DumpRenderTree/win/DumpRenderTree.vcproj:
 613         Add shlwapi.lib to all configurations.
 614
 615 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 616
 617         - Build fix.  Added additional includes for VS Express to the Release
 618         project.
 619
 620         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 621
 622 2007-11-29  Anders Carlsson  <andersca@apple.com>
 623
 624         Reviewed by Adam.
 625
 626         <rdar://problem/5132005>
 627         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
 628
 629         * DumpRenderTree/win/DumpRenderTree.vcproj:
 630         Add shlwapi.lib
 631
 632         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 633         (LayoutTestController::setUserStyleSheetEnabled):
 634         Implement this.
 635
 636         (appendComponentToPath):
 637         New method which wraps the Win32 API PathAppend.
 638
 639         (followShortcuts):
 640         New method which checks if a file points to a shortcut and
 641         follows the shortcut.
 642
 643         (resolveCygwinPath):
 644         New method that takes a cygwin unix-style path and returns the Win32 path.
 645
 646         (cfStringRefToWString):
 647
 648         (LayoutTestController::setUserStyleSheetLocation):
 649         Implement this.
 650
 651 2007-11-29  Alice Liu  <alice.liu@apple.com>
 652
 653         Reviewed by Adam.
 654
 655         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
 656
 657         * DumpRenderTree/win/EventSender.cpp:
 658         (keyDownCallback):
 659         uppercase letters were being sent as lowercase letters without the shift key down.
 660
 661 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 662
 663         - Windows build fix. VS express needs some love.
 664
 665         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 666
 667 2007-11-28  Darin Adler  <darin@apple.com>
 668
 669         Reviewed by Adam Roben.
 670
 671         * DumpRenderTree/mac/EventSendingController.mm:
 672         (-[EventSendingController keyDown:withModifiers:]):
 673         Send capital letters through as lowercase letters with the shift key down
 674         rather than sending them as if they were highly unusual "capital letter keys".
 675
 676         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
 677         where you need to update results and more tests are failing than before.
 678
 679 2007-11-28  Anders Carlsson  <andersca@apple.com>
 680
 681         Reviewed by Darin.
 682
 683         <rdar://problem/5132001>
 684         contextClick is not implemented in DRT on Windows.
 685
 686         * DumpRenderTree/win/EventSender.cpp:
 687         (contextClickCallback):
 688         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
 689         by a WM_RBUTTONUP message.
 690
 691         * DumpRenderTree/win/UIDelegate.cpp:
 692         (UIDelegate::hasCustomMenuImplementation):
 693         (UIDelegate::trackCustomPopupMenu):
 694         * DumpRenderTree/win/UIDelegate.h:
 695         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
 696         menu from being shown (and causing the DRT to hang).
 697
 698 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
 699
 700         Reviewed by Darin.
 701
 702         Fix DumpRenderTree ObjC bug comparing strings.
 703
 704         * DumpRenderTree/mac/ObjCController.m:
 705         (-[ObjCController identityIsEqual::]): Compare strings with string
 706         equality instead of identiy equality.
 707
 708 2007-11-27  Timothy Hatcher  <timothy@apple.com>
 709
 710         Reviewed by Sam.
 711
 712         Reset the authorAndUserStylesEnabled preference
 713         back to YES for each test. Fixes the broken tests.
 714
 715         * DumpRenderTree/mac/DumpRenderTree.mm:
 716         (resetWebViewToConsistentStateBeforeTesting):
 717
 718 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
 719
 720         Reviewed by Adam.
 721
 722         - Drosera now displays the console window, although it cannot currently
 723         process JavaScript.
 724
 725         * Drosera/win/DebuggerClient.cpp: Shows the console window.
 726         (registerConsoleClass): Implemented.
 727         (consoleWndProc): Implemented.
 728         (DebuggerClient::onSize): Implemented.
 729         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
 730         new window.
 731         * Drosera/win/DebuggerClient.h: Added needed method and members for
 732         creating and maintaining a new window.
 733         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
 734         lines of code to more appropriate places.
 735         (Drosera::handleCommand):
 736         (Drosera::initUI):
 737         (Drosera::onSize):
 738         (Drosera::attach):
 739
 740 2007-11-27  Timothy Hatcher  <timothy@apple.com>
 741
 742         Reviewed by Dave Hyatt.
 743
 744         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
 745
 746         Add support for disabling author and user styles for testing.
 747
 748         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 749         * DumpRenderTree/LayoutTestController.cpp:
 750         (setAuthorAndUserStylesEnabledCallback):
 751         (LayoutTestController::staticFunctions):
 752         * DumpRenderTree/LayoutTestController.h:
 753         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 754         (LayoutTestController::setAuthorAndUserStylesEnabled):
 755         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 756         (LayoutTestController::setAuthorAndUserStylesEnabled):
 757
 758 2007-11-26  Dan Bernstein  <mitz@apple.com>
 759
 760         - Tiger build fix.
 761
 762         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 763
 764 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
 765
 766         Reviewed by Maciej.
 767
 768         - Implemented displaying variables for Drosera on Win.
 769
 770         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
 771         that retrieve variables to not hold onto the return value since it's
 772         not returned.  Also changed to use the new signatures of the retrieval
 773         functions.
 774         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 775         (DebuggerDocument::platformValueForScopeVariableNamed):
 776         * Drosera/win/Drosera.cpp: Removed a needless TODO.
 777         (droseraWndProc):
 778
 779 2007-11-26  Sam Weinig  <sam@webkit.org>
 780
 781         Cleanup names of painting and repainting functions.
 782
 783         Reviewed by Adam Roben.
 784
 785         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 786         (drawSelectionRect): was drawSelectionRectIntoContext.
 787         (dumpWebViewAsPixelsAndCompareWithExpected):
 788         * DumpRenderTree/cg/PixelDumpSupportCG.h:
 789         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
 790         (paintWebView): was drawWebViewIntoContext.
 791         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
 792
 793 2007-11-26  Sam Weinig  <sam@webkit.org>
 794
 795         Reviewed by Dan Bernstein.
 796
 797         - Leopard build fix
 798
 799         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 800
 801 2007-11-26  Sam Weinig  <sam@webkit.org>
 802
 803         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
 804         Use shared PixelDumpSupport for Mac DRT
 805
 806         Reviewed by Adam Roben.
 807
 808         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 809         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
 810         * DumpRenderTree/cg/ImageDiffCG.cpp:
 811         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 812         (drawSelectionRectIntoContext):
 813         (dumpWebViewAsPixelsAndCompareWithExpected):
 814         * DumpRenderTree/cg/PixelDumpSupportCG.h:
 815         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 816         * DumpRenderTree/mac/DumpRenderTree.mm:
 817         (dump):
 818         * DumpRenderTree/mac/ImageDiff.m: Removed.
 819         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
 820         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
 821         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
 822         (setDefaultColorProfileToRGB):
 823         (getBitmapContextFromWebView):
 824         (drawWebViewIntoContext):
 825         (repaintWithVerticalSweep):
 826         (repaintWithHorizontalSweep):
 827         (getSelectionRect):
 828         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
 829
 830 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
 831
 832         Bug 16052: prepare-ChangeLog doesn't report deleted files
 833         <http://bugs.webkit.org/show_bug.cgi?id=16052>
 834
 835         Reviewed by Sam.
 836
 837         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
 838
 839 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
 840
 841         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
 842         <http://bugs.webkit.org/show_bug.cgi?id=15864>
 843
 844         Reviewed by Adam.
 845
 846         Roll functionality of merge-changelog into resolve-ChangeLogs
 847         script.  The script now checks for ChangeLog.rej and
 848         ChangeLog.orig files first.  If it finds them, it uses the
 849         ChangeLog.rej file as a patch (in old contextual diff format) to
 850         apply with --fuzz=3.
 851
 852         * Scripts/merge-changelog: Removed.
 853         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
 854
 855 2007-11-25  Sam Weinig  <sam@webkit.org>
 856
 857         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
 858
 859         Reviewed by Mark Rowe.
 860
 861         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 862         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 863         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
 864         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
 865         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
 866
 867 2007-11-25  Sam Weinig  <sam@webkit.org>
 868
 869         Convert DumpRenderTree to ues .xcconfig files.
 870
 871         Reviewed by Mark Rowe.
 872
 873         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 874         * DumpRenderTree/mac/Configurations: Added.
 875         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
 876         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
 877         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
 878
 879 2007-11-25  Sam Weinig  <sam@webkit.org>
 880
 881         Add ForwardingHeaders to wtf for DumpRenderTree.
 882
 883         Reviewed by Mark Rowe.
 884
 885         * DumpRenderTree/DumpRenderTree.h:
 886         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 887         * DumpRenderTree/ForwardingHeaders: Added.
 888         * DumpRenderTree/ForwardingHeaders/wtf: Added.
 889         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
 890         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
 891         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
 892         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
 893         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
 894         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
 895         * DumpRenderTree/LayoutTestController.cpp:
 896         * DumpRenderTree/WorkQueue.cpp:
 897         * DumpRenderTree/mac/DumpRenderTree.mm:
 898         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 899         * DumpRenderTree/mac/JavaScriptThreading.cpp:
 900         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 901         * DumpRenderTree/mac/ObjCController.m:
 902         * DumpRenderTree/mac/UIDelegate.mm:
 903         * DumpRenderTree/mac/WorkQueueItemMac.mm:
 904
 905 2007-11-25  Adam Roben  <aroben@apple.com>
 906
 907         Fix some test failures caused by r28019
 908
 909         Now that stdout is in binary mode, we need to always use printf
 910         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
 911         the output.
 912
 913         Reviewed by Sam.
 914
 915         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
 916         printf.
 917         (UIDelegate::runJavaScriptAlertPanelWithMessage):
 918         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
 919         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
 920         (UIDelegate::webViewAddMessageToConsole):
 921
 922 2007-11-25  Adam Roben  <aroben@apple.com>
 923
 924         Set the font smoothing preference in DRT
 925
 926         This makes the pixel results on Windows closer to the Mac results.
 927
 928         Reviewed by Mitz.
 929
 930         * DumpRenderTree/win/DumpRenderTree.cpp:
 931         (initializePreferences):
 932
 933 2007-11-25  Adam Roben  <aroben@apple.com>
 934
 935         Port ImageDiff to CG and C++
 936
 937         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
 938         <rdar://5071708>
 939
 940         Reviewed by Sam.
 941
 942         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
 943         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
 944         (main):
 945         (createImageFromStdin):
 946         (compareImages):
 947         (getDifferenceBitmap):
 948         (computePercentageDifferent):
 949         * DumpRenderTree/win/ImageDiff.vcproj: Added.
 950
 951 2007-11-25  Adam Roben  <aroben@apple.com>
 952
 953         Fix image diff link generation on Windows
 954
 955         Reviewed by Sam.
 956
 957         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
 958         to toURL.
 959
 960 2007-11-25  Adam Roben  <aroben@apple.com>
 961
 962         Implement pixel dumping in Windows DRT
 963
 964         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
 965         <rdar://5071708>
 966
 967         Reviewed by Sam.
 968
 969         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
 970         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
 971         Content-Length header.
 972         (getMD5HashStringForBitmap):
 973         (dumpWebViewAsPixelsAndCompareWithExpected):
 974         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
 975         * DumpRenderTree/win/DumpRenderTree.cpp:
 976         (dump): Do a pixel dump if requested.
 977         (main): Parse pixel test options.
 978         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
 979         the cg/ subdirectory to the include path.
 980         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
 981         available in a header or import library, so we have to go through this
 982         LoadLibrary/GetProcAddress dance to use them.
 983         (cryptDLL):
 984         (init):
 985         (update):
 986         (final):
 987         (MD5_Init):
 988         (MD5_Update):
 989         (MD5_Final):
 990         * DumpRenderTree/win/MD5.h: Added.
 991         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
 992         moved up to the top level to share it with Mac eventually.
 993         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
 994         (getBitmapContextFromWebView): Forces the WebView to paint using a
 995         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
 996
 997 2007-11-25  Adam Roben  <aroben@apple.com>
 998
 999         Clean up Windows DRT's option parsing a little bit
1000
1001         Reviewed by Sam.
1002
1003         * DumpRenderTree/win/DumpRenderTree.cpp:
1004         (main): Put non-option arguments into a Vector.
1005
1006 2007-11-25  Adam Roben  <aroben@apple.com>
1007
1008         Make Windows DRT stop changing LF into CRLF
1009
1010         Reviewed by Sam.
1011
1012         * DumpRenderTree/win/DumpRenderTree.cpp:
1013         (main): Put stdout in binary mode.
1014         * Scripts/run-webkit-tests: Remove the CRLF hack.
1015
1016 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1017
1018         Removed empty directory.
1019
1020         * Scripts/resources: Removed.
1021
1022 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1023
1024         Fix bisect-builds to work with recent WebKit nightly builds.
1025
1026         Reviewed by Dan.
1027
1028         * Scripts/bisect-builds: Check for the
1029         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1030         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1031         to WebKit.app/Contents/Resources.
1032
1033 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1034
1035         Reviewed by Maciej.
1036
1037         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1038         not closed (affects digg.com)
1039
1040         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1041         one after finishing with a test to avoid having its delayed onload handler firing when
1042         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1043         but it helps somewhat.
1044
1045 2007-11-22  Mark Rowe  <mrowe@apple.com>
1046
1047         Reviewed by Alp Toker.
1048
1049         Fix build-webkit to propagate make's exit status if it fails.
1050
1051         * Scripts/webkitdirs.pm:
1052
1053 2007-11-22  Dan Bernstein  <mitz@apple.com>
1054
1055         Reviewed by Mark Rowe.
1056
1057         - fix crash when running pixel tests
1058
1059         * DumpRenderTree/mac/DumpRenderTree.mm:
1060         (dumpRenderTree): Parse the command line options before setting up the
1061         environment so that we know if we need to set up the pixel dump
1062         machinery.
1063
1064 2007-11-21  Eric Seidel  <eric@webkit.org>
1065
1066         Speculative build fix for Tiger.
1067
1068         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1069
1070 2007-11-21  Eric Seidel  <eric@webkit.org>
1071
1072         Reviewed by Tim Hatcher.
1073
1074         Break out more of DumpRenderTree.mm into individual files
1075
1076         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1077         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1078         (checkedMalloc):
1079         (checkedRealloc):
1080         (makeLargeMallocFailSilently):
1081         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1082         * DumpRenderTree/mac/DumpRenderTree.mm:
1083         (crashHandler):
1084         (dump):
1085         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1086         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1087         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1088         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1089         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1090         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1091         (javaScriptThreads):
1092         (runJavaScriptThread):
1093         (startJavaScriptThreads):
1094         (stopJavaScriptThreads):
1095         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1096         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1097         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1098         (restoreColorSpace):
1099         (setDefaultColorProfileToRGB):
1100         (initializeColorSpaceAndScreeBufferForPixelTests):
1101         (md5HashStringForBitmap):
1102         (dumpWebViewAsPixelsAndCompareWithExpected):
1103
1104 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1105
1106         Move install-unix-extras to wx directory as it seems only to be used by that
1107         port now. It now supports universal binaries on Mac and adds libpng and libjpeg.
1108         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1109         have install-unix-extras install into WebKitLibraries as per
1110         convention.
1111
1112         Reviewed by Mark Rowe.
1113
1114         * Scripts/install-unix-extras: Removed.
1115         * wx/build-wxwebkit:
1116         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1117
1118 2007-11-21  Eric Seidel  <eric@webkit.org>
1119
1120         Reviewed by Adam.
1121
1122         More refactoring for greater code readability
1123
1124         * DumpRenderTree/mac/DumpRenderTree.mm:
1125         (initializeGlobalsFromCommandLineOptions):
1126         (initializeColorSpaceAndScreeBufferForPixelTests):
1127         (addTestPluginsToPluginSearchPath):
1128         (useLongRunningServerMode):
1129         (runTestingServerLoop):
1130         (prepareConsistentTestingEnvironment):
1131         (dumpRenderTree):
1132         (main):
1133         (dumpFramesAsText):
1134         (dumpBackForwardListForWebView):
1135         (sizeWebViewForCurrentTest):
1136         (methodNameStringForFailedTest):
1137         (dumpBackForwardListForAllWindows):
1138         (dumpWebViewAsPixelsAndCompareWithExpected):
1139         (invalidateAnyPreviousWaitToDumpWatchdog):
1140         (dump):
1141         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1142         * DumpRenderTree/mac/UIDelegate.mm:
1143         (-[UIDelegate webView:createWebViewWithRequest:]):
1144
1145 2007-11-21  Eric Seidel  <eric@webkit.org>
1146
1147         Reviewed by Tim Hatcher.
1148
1149         Abstract more of DRT into static methods
1150
1151         * DumpRenderTree/mac/DumpRenderTree.mm:
1152         (setDefaultsToConsistentValuesForTesting):
1153         (setupSignalHandlers):
1154         (allocateGlobalControllers):
1155         (releaseAndZero):
1156         (releaseGlobalControllers):
1157         (dumpRenderTree):
1158         (shouldLogFrameLoadDelegates):
1159         (createCFURLFromPathOrURL):
1160         (resetWebViewToConsistentStateBeforeTesting):
1161         (runTest):
1162
1163 2007-11-21  Eric Seidel  <eric@webkit.org>
1164
1165         Reviewed by Tim Hatcher.
1166
1167         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1168
1169         * DumpRenderTree/DumpRenderTree.h:
1170         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1171         * DumpRenderTree/mac/DumpRenderTree.mm:
1172         (dumpRenderTree):
1173         (dump):
1174         (runTest):
1175         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1176         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1177         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1178         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1179         (-[DumpRenderTreePasteboard declareType:owner:]):
1180         (+[LocalPasteboard alloc]):
1181         (-[LocalPasteboard init]):
1182         (-[LocalPasteboard dealloc]):
1183         (-[LocalPasteboard name]):
1184         (-[LocalPasteboard releaseGlobally]):
1185         (-[LocalPasteboard declareTypes:owner:]):
1186         (-[LocalPasteboard addTypes:owner:]):
1187         (-[LocalPasteboard changeCount]):
1188         (-[LocalPasteboard types]):
1189         (-[LocalPasteboard availableTypeFromArray:]):
1190         (-[LocalPasteboard setData:forType:]):
1191         (-[LocalPasteboard dataForType:]):
1192         (-[LocalPasteboard setPropertyList:forType:]):
1193         (-[LocalPasteboard setString:forType:]):
1194         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1195         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1196         (+[DumpRenderTreeWindow allWindows]):
1197         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1198         (-[DumpRenderTreeWindow dealloc]):
1199         (-[DumpRenderTreeWindow isKeyWindow]):
1200         (-[DumpRenderTreeWindow keyDown:]):
1201
1202 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1203
1204         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1205         it indiscriminately copies any headers inside JavaScriptCore,
1206         which includes Tiger ICU headers.
1207
1208         * wx/build-wxwebkit:
1209         Don't run WebCore/move-js-headers.sh any longer.
1210
1211 2007-11-20  Adam Treat  <treat@kde.org>
1212
1213         Reviewed by David Kilzer.
1214
1215         * Prepend git branch name to $baseProductDir
1216
1217         * Scripts/VCSUtils.pm:
1218         * Scripts/webkitdirs.pm:
1219
1220 2007-11-20  Mark Rowe  <mrowe@apple.com>
1221
1222         Reviewed by Simon Hausmann.
1223
1224         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1225         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1226         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1227         built product and generated Makefile's are removed.
1228
1229 2007-11-19  Alp Toker  <alp@atoker.com>
1230
1231         Reviewed by Mark Rowe.
1232
1233         http://bugs.webkit.org/show_bug.cgi?id=16040
1234         [GTK] GtkLauncher should be written in C
1235
1236         Port GtkLauncher to plain C.
1237
1238         Use a more conventional GTK+ coding style.
1239
1240         Use a toolbar instead of menus.
1241
1242         Various signature fixes and cleanups.
1243
1244         Add a license header. Assume all previous modifications were copyright
1245         assigned to Apple Inc. by default.
1246
1247         * GtkLauncher/GtkLauncher.pro:
1248         * GtkLauncher/main.c: Added.
1249         (activate_url_entry_cb):
1250         (update_title):
1251         (link_hover_cb):
1252         (title_change_cb):
1253         (progress_change_cb):
1254         (destroy_cb):
1255         (go_back_cb):
1256         (go_forward_cb):
1257         (create_browser):
1258         (create_statusbar):
1259         (create_toolbar):
1260         (create_window):
1261         (main):
1262         * GtkLauncher/main.cpp: Removed.
1263
1264 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1265
1266         Build script fixes to ensure they do the right thing for the
1267         wx port, and update build-wxwebkit to reflect the way the
1268         build scripts now work.
1269
1270         Reviewed by Adam.
1271
1272         * Scripts/build-testkjs:
1273         * Scripts/build-webkit:
1274         * Scripts/run-javascriptcore-tests:
1275         * Scripts/webkitdirs.pm:
1276         * wx/build-wxwebkit:
1277
1278 2007-11-18  Eric Seidel  <eric@webkit.org>
1279
1280         Reviewed by Anders.
1281
1282         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1283
1284         * Scripts/run-javascriptcore-tests:
1285
1286 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1287
1288         Reviewed by Adam Roben.
1289
1290         Make run-webkit-tests work with Windows debug build.
1291
1292         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1293         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1294         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1295         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1296         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1297
1298 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1299
1300         Add wxWebKit sample and build script, and integrate it with
1301         build-webkit. Also make build-webkit --clean work for all
1302         ports.
1303
1304         Reviewed by Darin Adler.
1305
1306         * Scripts/build-webkit:
1307         * Scripts/webkitdirs.pm:
1308         * wx: Added.
1309         * wx/browser: Added.
1310         * wx/browser/browser.bkl: Added.
1311         * wx/browser/browser.cpp: Added.
1312         * wx/build-wxwebkit: Added.
1313
1314 2007-11-17  Adam Roben  <aroben@apple.com>
1315
1316         Make it easy to run Safari in the debugger on Windows
1317
1318         I've added a new script, debug-safari, which launches Safari in the
1319         debugger. On OS X it just calls gdb-safari.
1320
1321         Reviewed by Mark Rowe.
1322
1323         * FindSafari/FindSafari.cpp:
1324         (_tmain): Added a /debugger flag, which in combination with
1325         /printSafariLauncher will print a script that launches Safari in the
1326         debugger.
1327         * Scripts/debug-safari: Added.
1328         * Scripts/run-safari: Changed to call runSafari().
1329         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1330         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1331         first argument along to FindSafari.
1332         * Scripts/webkitdirs.pm:
1333         (sub runSafari): Added.
1334
1335 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1336
1337         Reviewed by Adam Roben.
1338
1339         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.
1340
1341 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1342
1343         Reviewed by David Kilzer.
1344
1345         The git config command was renamed to repo-config at some point. This
1346         change tries git config and then git repo-config if the first fails.
1347
1348         * Scripts/prepare-ChangeLog:
1349         (gitConfig):
1350
1351 2007-11-16  Dan Bernstein  <mitz@apple.com>
1352
1353         Reviewed by Darin Adler and Sam Weinig.
1354
1355         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1356
1357         * DumpRenderTree/win/EventSender.cpp:
1358         (keyDownCallback): For characters that cannot be entered on the active
1359         keyboard layout, send a WM_CHAR message with the character along with
1360         a WM_KEYDOWN message with a virtual key code of 255.
1361
1362 2007-11-16  Mark Rowe  <mrowe@apple.com>
1363
1364         Reviewed by Tim Hatcher.
1365
1366         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1367
1368         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1369         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1370
1371 2007-11-15  Adam Roben  <aroben@apple.com>
1372
1373         Make run-safari actually work on Windows
1374
1375         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1376         chdir call.
1377
1378 2007-11-14  Adam Roben  <aroben@apple.com>
1379
1380         Updates to Safari launching now that 3.0.4 is released
1381
1382         Reviewed by Sam.
1383
1384         * FindSafari/FindSafari.cpp:
1385         (getWebViewCLSID): Use version-independent ProgID.
1386         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1387
1388 2007-11-14  Anders Carlsson  <andersca@apple.com>
1389
1390         Reviewed by Adam.
1391
1392         <rdar://problem/5309081>
1393         In DRT, "plugin.logDestroy = true" not working on Windows.
1394
1395         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1396         (NPP_Destroy):
1397
1398 2007-11-14  Eric Seidel  <eric@webkit.org>
1399
1400         Reviewed by Sam.
1401
1402         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1403
1404 2007-11-14  Anders Carlsson  <andersca@apple.com>
1405
1406         Reviewed by Adam.
1407
1408         <rdar://problem/5141186>
1409         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1410
1411         Implement setWindowIsKey.
1412
1413         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1414         (LayoutTestController::setWindowIsKey):
1415
1416 2007-11-13  Sam Weinig  <sam@webkit.org>
1417
1418         Reviewed by Adam Roben.
1419
1420         Fix for <rdar://problem/5382579>
1421         http/tests/security/cross-frame-access-put.html reports large
1422         negative numbers for screenLeft and screenTop (Mac reports "0")
1423
1424         * DumpRenderTree/win/UIDelegate.cpp:
1425         (UIDelegate::UIDelegate): Initialize the RECT.
1426         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1427         (UIDelegate::webViewFrame): ditto.
1428         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1429
1430 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1431
1432         Reviewed by Adam.
1433
1434         - Make Drosera show source, source URLs, and function stack on Windows,
1435         and some minor fixes.
1436
1437         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1438         (DebuggerDocument::updateFileSource):
1439         * Drosera/debugger.js: Force source to always update display.
1440         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1441         menu controls.
1442         (DebuggerClient::resume):
1443         (DebuggerClient::pause):
1444         (DebuggerClient::stepInto):
1445         (DebuggerClient::stepOver):
1446         (DebuggerClient::stepOut):
1447         (DebuggerClient::showConsole):
1448         (DebuggerClient::closeCurrentFile):
1449         * Drosera/win/DebuggerClient.h: Ditto.
1450         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1451         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1452         removed two bugs.  1) caller could be in a bad state when asked to
1453         assign into it. 2) BSTRs were not created correctly.
1454         (DebuggerDocument::getPlatformCurrentFunctionStack):
1455         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1456         (droseraWndProc):
1457         (handleCommand):
1458         (Drosera::resume):
1459         (Drosera::pause):
1460         (Drosera::stepInto):
1461         (Drosera::stepOver):
1462         (Drosera::stepOut):
1463         (Drosera::showConsole):
1464         (Drosera::closeCurrentFile):
1465         * Drosera/win/Drosera.h: Hook up the menu controls.
1466         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1467         functions, added a null check, and fixed another bug where caller could
1468         be in a bad state when asked to assign into it.
1469         (ServerConnection::didLoadMainResourceForDataSource):
1470         (ServerConnection::getCallerFrame):
1471         * Drosera/win/ServerConnection.h: Safety first.
1472
1473 2007-11-13  Dan Bernstein  <mitz@apple.com>
1474
1475         Reviewed by Darin Adler.
1476
1477         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1478           DumpRenderTree --pixel-tests renders each test twice
1479
1480         * DumpRenderTree/mac/DumpRenderTree.mm:
1481         (dumpRenderTree): Removed the --paint option because the painting code
1482         is always exercised as a result of
1483         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1484         calling -displayIfNeeded.
1485         (dump): Changed to always grab the image from the window since the view
1486         is always displayed.
1487         (runTest):
1488         (displayWebView):
1489         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1490         because it always paints.
1491
1492 2007-11-12  Antti Koivisto  <antti@apple.com>
1493
1494         Reviewed by Adele.
1495
1496         Add support for http media tests
1497
1498         * Scripts/run-webkit-tests:
1499
1500 2007-11-12  Sam Weinig  <sam@webkit.org>
1501
1502         Reviewed by Adam Roben.
1503
1504         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1505
1506         * DumpRenderTree/win/DumpRenderTree.cpp:
1507         (runTest):
1508         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1509         (LayoutTestController::setPrivateBrowsingEnabled):
1510
1511 2007-11-12  Adam Roben  <aroben@apple.com>
1512
1513         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1514         mac and win subdirectories.
1515
1516 2007-11-11  Adam Roben  <aroben@apple.com>
1517
1518         Fix <rdar://5133816> keepWebHistory is not implemented
1519
1520         Fixes fast/history/clicked-link-is-visited.html.
1521
1522         Reviewed by Darin.
1523
1524         * DumpRenderTree/win/DumpRenderTree.cpp:
1525         (runTest): Clear the optionalSharedHistory.
1526         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1527         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1528
1529 2007-11-10  Sam Weinig  <sam@webkit.org>
1530
1531         Reviewed by Tim Hatcher.
1532
1533         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
1534         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
1535         is turned on)
1536
1537         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1538
1539         Added test: http/tests/security/cross-frame-access-private-browsing.html
1540
1541         * DumpRenderTree/LayoutTestController.cpp:
1542         (setPrivateBrowsingEnabledCallback):
1543         (LayoutTestController::staticFunctions):
1544         * DumpRenderTree/LayoutTestController.h:
1545         * DumpRenderTree/mac/DumpRenderTree.mm:
1546         (runTest): Default to private browsing disabled.
1547         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1548         (LayoutTestController::setPrivateBrowsingEnabled):
1549         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1550         (LayoutTestController::setPrivateBrowsingEnabled):
1551
1552 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1553
1554         Reviewed by Adam.
1555
1556         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1557         WebCore's!
1558
1559         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1560         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1561         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1562         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1563         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1564         * Drosera/win/Drosera.cpp:
1565         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1566
1567 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1568
1569         Reviewed by Sam.
1570
1571         - Use the new IWebFrame [local] function signature and get the shared
1572         server correctly.
1573
1574         * Drosera/win/DebuggerClient.cpp:
1575         (DebuggerClient::didFinishLoadForFrame):
1576         * Drosera/win/ServerConnection.cpp:
1577         (ServerConnection::attemptToCreateServerConnection):
1578
1579 2007-11-07  Dan Bernstein  <mitz@apple.com>
1580
1581         Reviewed by Darin Adler.
1582
1583         - add an option to run-webkit-tests to ignore pixel test failures where
1584           all pixels differ by no more than a specified threshold
1585
1586         * DumpRenderTree/mac/ImageDiff.m:
1587         (main):
1588         (compareImages):
1589         (computePercentageDifferent):
1590         * Scripts/run-webkit-tests:
1591
1592 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1593
1594         Reviewed by Lars.
1595
1596         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1597
1598         * DumpRenderTree/qt/DumpRenderTree.cpp:
1599
1600 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1601
1602         Reviewed by Lars.
1603
1604         Reworked the QWebSettings API.
1605         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1606
1607         * DumpRenderTree/qt/DumpRenderTree.cpp:
1608
1609 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1610
1611         Reviewed by Lars.
1612
1613         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1614
1615         * DumpRenderTree/qt/jsobjects.cpp:
1616
1617 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1618
1619         Reviewed by Lars Knoll <lars@trolltech.com>.
1620
1621         Add a QWebPage::frameCreated() signal and fix DRT
1622
1623         The removal of createFrame in QWebPage broke the re-implementation
1624         in DumpRenderTree. Instead emit a frameCreated() signal and
1625         connect to it in DumpRenderTree.
1626
1627
1628         * DumpRenderTree/qt/DumpRenderTree.cpp:
1629         (WebCore::WebPage::WebPage):
1630         (WebCore::DumpRenderTree::dump):
1631         (WebCore::DumpRenderTree::connectFrame):
1632         * DumpRenderTree/qt/DumpRenderTree.h:
1633
1634 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1635
1636         Reviewed by Lars Knoll <lars@trolltech.com>.
1637
1638         Moved all the event handlers from QWebFrame into QWebPage.
1639
1640         This cleans up the public API and allows us to remove the
1641         HackWebFrame hack in DumpRenderTree.
1642
1643
1644         * DumpRenderTree/qt/jsobjects.cpp:
1645         (EventSender::mouseDown):
1646         (EventSender::mouseUp):
1647         (EventSender::mouseMoveTo):
1648
1649 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1650
1651         Reviewed by Mark.
1652
1653         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1654         to prevent the default implementation from popping up messageboxes.
1655
1656         * DumpRenderTree/qt/DumpRenderTree.cpp:
1657         (WebCore::WebPage::javaScriptConfirm):
1658         (WebCore::WebPage::javaScriptPrompt):
1659
1660 2007-11-06  Eric Seidel  <eric@webkit.org>
1661
1662         * Scripts/build-testkjs: build fix... too many $$
1663
1664 2007-11-06  Eric Seidel  <eric@webkit.org>
1665
1666         Reviewed by Mark Rowe.
1667
1668         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1669
1670 2007-11-05  Adam Roben  <aroben@apple.com>
1671
1672         Add support on Windows for WEBKIT_TESTFONTS
1673
1674         This environment variable lets you specify where the fonts to be used
1675         by DumpRenderTree reside. The Qt port is already using this, so I'm
1676         just following their lead.
1677
1678         Reviewed by Darin.
1679
1680         * DumpRenderTree/win/DumpRenderTree.cpp:
1681         (exePath): Refactored code out of initialize().
1682         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1683         DumpRenderTree.resources.
1684         (initialize): Use the new fontsPath function.
1685         (main): Use the new exePath function.
1686         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1687         variable to DRT, like Qt does.
1688
1689 2007-11-05  Mark Rowe  <mrowe@apple.com>
1690
1691         Rubber-stamped by Alp Toker.
1692
1693         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1694
1695         * GtkLauncher/main.cpp:
1696         (goToURLBarText):
1697         (main):
1698
1699 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1700
1701         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1702         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1703
1704         Reviewed by Timothy.
1705
1706         Restrict the range of nightly builds used by the bisect-builds script
1707         based on the version of Safari and the version of Mac OS X being used.
1708
1709         Mac OS X 10.4: Safari 2.0: r11976 or newer
1710         Mac OS X 10.4: Safari 3.0: r19992 or newer
1711
1712         Mac OS X 10.5: Safari 2.0: r19594 or newer
1713         Mac OS X 10.5: Safari 3.0: r25124 or newer
1714
1715         * Scripts/bisect-builds:
1716         (findMacOSXVersion): Added.
1717         (makeNightlyList): Added argument to provide version of Mac OS X.
1718         Restrict range of nightly builds based on Safari and Mac OS X versions.
1719
1720 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1721
1722         Reviewed by Maciej.
1723
1724         - This patch involves several changes, all of them were noticed that
1725         they were needed by the work being done in WebKit to get Drosera and
1726         WebKit working together on Windows.
1727         - The changes are:
1728         1) Added a debugger console for output messages.
1729         2) Drosera now listens for the WebKit server (before, the server would
1730         have to be running before Drosera was started.)
1731         3) Fixed a bug where the WebView started out as 0x0 pixels.
1732         4) Fixed a bug when there is no scope.
1733         5) Added the HTML, JS, and CSS to the project file to make them easy to
1734         find.
1735         6) Made the ServerConnection functions virtual.
1736
1737         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1738         for the WebKit server.
1739         (DebuggerClient::DebuggerClient):
1740         (DebuggerClient::~DebuggerClient):
1741         (DebuggerClient::didFinishLoadForFrame):
1742         (DebuggerClient::serverConnected):
1743         (DebuggerClient::attemptToCreateServerConnection):
1744         * Drosera/win/DebuggerClient.h: Ditto.
1745         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1746         scope.
1747         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1748         (DebuggerDocument::platformValueForScopeVariableNamed):
1749         * Drosera/win/Drosera.cpp:
1750         (_tWinMain): Added a console in debug for output messages.
1751         (Drosera::Drosera): Listen for server.
1752         (Drosera::initUI): The server now Initializes COM.
1753         (Drosera::serverConnected): Part of the listening for the server.
1754         (Drosera::attemptToCreateServerConnection): Ditto.
1755         * Drosera/win/Drosera.h: New interface for listening for the server.
1756         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1757         files to the VS project.
1758         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1759         connection.
1760         (ServerConnection::ServerConnection):
1761         (ServerConnection::attemptToCreateServerConnection):
1762         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1763         methods.
1764         (ServerConnection::serverConnected):
1765
1766 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1767
1768         Reviewed by Maciej.
1769
1770         http://bugs.webkit.org/show_bug.cgi?id=15832
1771         fast/dom/gc-10.html crashes when run alone
1772
1773         Check for !done before using objects that can be already deallocated.
1774
1775         * DumpRenderTree/mac/EditingDelegate.mm:
1776         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1777         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1778         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1779         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1780         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1781         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1782         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1783         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1784         (-[EditingDelegate webViewDidBeginEditing:]):
1785         (-[EditingDelegate webViewDidChange:]):
1786         (-[EditingDelegate webViewDidEndEditing:]):
1787         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1788         (-[EditingDelegate webViewDidChangeSelection:]):
1789         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1790         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1791         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1792         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1793         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1794         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1795         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1796         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1797         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1798         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1799         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1800         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1801         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1802         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1803         (-[FrameLoadDelegate webView:willCloseFrame:]):
1804         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1805         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1806         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1807         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1808         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1809         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1810         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1811         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1812         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1813
1814 2007-11-04  Mark Rowe  <mrowe@apple.com>
1815
1816         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1817         warnings that would otherwise be suppressed due to it being a system header.
1818
1819         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1820
1821 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1822
1823         Rubber stamped by Adam.
1824
1825         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1826
1827         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1828
1829 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1830
1831         Sort files(...); sections of Xcode project files.
1832
1833         Rubber-stamped by Darin.
1834
1835         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1836         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1837         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1838         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1839
1840 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1841
1842         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1843
1844         Reviewed by Darin.
1845
1846         * Scripts/sort-Xcode-project-file: Added.
1847
1848 2007-11-02  Darin Adler  <darin@apple.com>
1849
1850         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1851
1852 2007-11-02  Darin Adler  <darin@apple.com>
1853
1854         Reviewed by Maciej.
1855
1856         * Scripts/run-sunspider: Pass the "--base" option through.
1857
1858         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1859         the real script do that. Default configuration to Release to match run-sunspider
1860         so we don't end up building Debug just to compare results.
1861
1862 2007-11-01  Adam Roben  <aroben@apple.com>
1863
1864         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1865
1866         Reviewed by Sam.
1867
1868         * Scripts/commit-log-editor: Show all the directories beneath the
1869         source root, instead of just the last one.
1870
1871 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1872
1873         Reviewed by Adam Roben.
1874
1875         Print out an error message when the Windows build fails
1876         and provide guidance on how to find out what went wrong.
1877
1878         * Scripts/build-webkit:
1879         * Scripts/webkitdirs.pm:
1880
1881 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1882
1883         Rubber-stamped by Adam Roben.
1884
1885         Rolled out r27326 - debug CRT seems to cause no problems after all.
1886
1887         * DumpRenderTree/win/DumpRenderTree.vcproj:
1888
1889 2007-10-31  Adam Roben  <aroben@apple.com>
1890
1891         Switch the Debug configuration to using the non-debug CRT
1892
1893         This matches WebKit.
1894
1895         Reviewed by Steve.
1896
1897         * DumpRenderTree/win/DumpRenderTree.vcproj:
1898
1899 2007-10-31  Antti Koivisto  <antti@apple.com>
1900
1901         Reviewed by bdash.
1902
1903         Disable media tests when doing leak checking on Tiger.
1904         They crash in QuickTime (rdar://problem/5537157).
1905
1906         * Scripts/run-webkit-tests:
1907
1908 2007-10-29  Antti Koivisto  <antti@apple.com>
1909
1910         Reviewed by Maciej.
1911
1912         Build media support by default on OSX only.
1913
1914         * Scripts/build-webkit:
1915
1916 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1917
1918         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1919         get caught by the pre-commit hooks.
1920
1921 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1922
1923         Reviewed by Adam.
1924
1925         - This is a collection of relatively unrelated changes and cleanups
1926         to Drosera to prepare it for interacting with WebKit.  A lot of these
1927         changes are just correcting mistakes, for example removing included
1928         headers that are no longer needed.
1929
1930         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1931         this will be needed by the DebuggerClient.
1932         (DebuggerDocument::server):
1933         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1934         * Drosera/win/DebuggerClient.cpp:
1935         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1936         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1937         (DebuggerClient::createWebViewWithRequest): Added comment about its
1938         purpose.
1939         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1940         declarations.
1941         (DebuggerClient::webViewLoaded): Moved.
1942         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1943         file, since this was the only place it was used.
1944         (cfStringToBSTR):
1945         * Drosera/win/Drosera.h: Cleaned up the includes.
1946         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1947         * Drosera/win/HelperFunctions.h: Removed.
1948
1949 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1950
1951         Reviewed by Adam.
1952
1953         - Small cleanup in the ServerConnection class.
1954
1955         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1956         and added an include.
1957         (ServerConnection::currentFrame):
1958         (ServerConnection::getCallerFrame):
1959         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1960         made a pointer into a COMPtr, and cleaned up the includes.
1961
1962 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1963
1964         Reviewed by John Sullivan.
1965
1966         - Place the Localizable.strings file in mac or win directories
1967           if that location exists.
1968         - Also look for UI_STRING in .c files.
1969
1970         * Scripts/extract-localizable-strings:
1971
1972 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1973
1974         Reviewed by Adam.
1975
1976         - Set the eol-style to native and made all the line endings the same
1977         so that I avoid messy diffs that show eol changes.
1978
1979         * Drosera/win/ServerConnection.cpp:
1980         (ServerConnection::didParseSource):
1981         (ServerConnection::didEnterCallFrame):
1982         (ServerConnection::willExecuteStatement):
1983         (ServerConnection::willLeaveCallFrame):
1984         (ServerConnection::exceptionWasRaised):
1985
1986 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1987
1988         Reviewed by Adam.
1989
1990         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1991         functionality that could not have existed previously without the new
1992         interfaces.
1993         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1994         from a BSTR to a JSValueRef.
1995         (DebuggerDocument::platformEvaluateScript): Implemented.
1996         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1997         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1998         Implemented.
1999         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2000         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2001         * Drosera/win/ServerConnection.cpp: Added a helper function.
2002         (ServerConnection::getCallerFrame):
2003         * Drosera/win/ServerConnection.h: Added a helper function.
2004
2005 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2006
2007         updated reviewers for my previous changelog.
2008
2009 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2010         Reviewed by Maciej and Adam and Geoff.
2011
2012         - Minor mac-side improvements including moving a function to a more
2013         appropriate location, fixing a warning, and correctly checking
2014         exceptions.
2015
2016         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2017         (DebuggerDocument::willExecuteStatement):
2018         (DebuggerDocument::didEnterCallFrame):
2019         (DebuggerDocument::willLeaveCallFrame):
2020         (DebuggerDocument::windowScriptObjectAvailable):
2021         (DebuggerDocument::callFunctionOnObject):
2022         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2023         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2024         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2025         because it doesn't require the ServerConnection at all.
2026         (NSStringCreateWithJSStringRef): Made an argument const.
2027         (JSValueRefCreateWithNSString): Made an argument const.
2028         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2029         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2030         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2031         * Drosera/mac/ServerConnection.mm: Ditto.
2032         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2033
2034 2007-10-29  Sam Weinig  <sam@webkit.org>
2035
2036         Reviewed by Adam Roben.
2037
2038         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2039
2040         * DumpRenderTree/LayoutTestController.cpp:
2041         (LayoutTestController::LayoutTestController):
2042         (getGlobalFlagCallback):
2043         (setGlobalFlagCallback):
2044         (LayoutTestController::getJSClass):
2045         (LayoutTestController::staticValues):
2046         * DumpRenderTree/LayoutTestController.h:
2047         (LayoutTestController::globalFlag):
2048         (LayoutTestController::setGlobalFlag):
2049
2050 2007-10-29  Darin Adler  <darin@apple.com>
2051
2052         Reviewed by Maciej.
2053
2054         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2055         resolution instead of its default.
2056
2057 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2058
2059         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2060
2061         Reviewed by Mark Rowe.
2062
2063         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2064         was successfully resolved, but this would not show any status because the change had
2065         already been cached in the index using "git add".  The solution is to add an optional
2066         second argument to showStatus() which adds the "--cached" switch to the command.
2067
2068         * Scripts/resolve-ChangeLogs:
2069         (showStatus):
2070
2071 2007-10-28  Eric Seidel  <eric@webkit.org>
2072
2073         Reviewed by Maciej and Geoff, in unison.
2074
2075         * Scripts/run-webkit-tests: remove broken --svg option
2076
2077 2007-10-28  Darin Adler  <darin@apple.com>
2078
2079         Reviewed by Adam.
2080
2081         * Scripts/run-sunspider: Default to "Release" configuration rather than
2082         defaulting to the last configuration used as other scripts do. This can
2083         still be overriden on the command line with "--debug" if there's some
2084         reason to do so. Also fix a typo.
2085
2086         * Scripts/sunspider-compare-results: Fix a typo.
2087
2088 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2089
2090         Reviewed by Adam.
2091
2092         - Implemented the WebScriptDebugListener functions now that the
2093         WebScriptDebugServer exists
2094
2095         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2096         functions.
2097         (ServerConnection::currentFrame):
2098         (ServerConnection::didLoadMainResourceForDataSource):
2099         (ServerConnection::didParseSource):
2100         (ServerConnection::failedToParseSource):
2101         (ServerConnection::didEnterCallFrame):
2102         (ServerConnection::willExecuteStatement):
2103         (ServerConnection::willLeaveCallFrame):
2104         (ServerConnection::exceptionWasRaised):
2105         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2106         members arguments list.
2107
2108 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2109
2110         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2111         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2112
2113         Reviewed by Darin.
2114
2115         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2116         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2117         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2118         file.  Note that it may also be used as a stand-alone script.
2119
2120         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2121         * Scripts/resolve-ChangeLogs: Added.
2122         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2123
2124 2007-10-26  Mark Rowe  <mrowe@apple.com>
2125
2126         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2127         to the Qt port on the assumption that it was an implementation of the cross-platform
2128         LayoutTestController class.  It is not, so it did not need to be changed.
2129
2130         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2131
2132 2007-10-25  Mark Rowe  <mrowe@apple.com>
2133
2134         Reviewed by Maciej.
2135
2136         Fix builds with code coverage enabled.
2137
2138         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2139
2140 2007-10-25  Darin Adler  <darin@apple.com>
2141
2142         Reviewed by Mark Rowe.
2143
2144         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2145         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2146
2147 2007-10-25  Stephanie  <slewis@apple.com>
2148
2149         build Fix
2150
2151         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2152
2153 2007-10-25  Stephanie  <slewis@apple.com>
2154
2155         Reviewed by Mark Rowe, Adam Roben.
2156
2157         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2158
2159         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2160
2161 2007-10-25  Alice Liu  <alice.liu@apple.com>
2162
2163         Reviewed by Adam.
2164
2165         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2166
2167         Moving destructor into platform-specific files
2168         * DumpRenderTree/LayoutTestController.cpp:
2169         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2170         (LayoutTestController::~LayoutTestController):
2171         * DumpRenderTree/qt/jsobjects.cpp:
2172         (LayoutTestController::~LayoutTestController):
2173
2174         LayoutTestController wasn't being destroyed
2175         * DumpRenderTree/win/DumpRenderTree.cpp:
2176         (runTest):
2177
2178         Added declspec
2179         * DumpRenderTree/win/EditingDelegate.h:
2180
2181         Reset certain values on the webview (or related delegate) that might
2182         have changed while running a test
2183         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2184         (LayoutTestController::~LayoutTestController):
2185
2186 2007-10-25  Adam Roben  <aroben@apple.com>
2187
2188         Make sunspider-compare-results work with relative paths
2189
2190         Reviewed by Sam.
2191
2192         * Scripts/sunspider-compare-results: Convert arguments to absolute
2193         paths before we chdir.
2194
2195 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2196
2197         Reviewed by Sam.
2198
2199         - Implemented server calls now the WebScriptDebugServer exists.
2200         - Also removed no longer needed call to initialize CG.
2201
2202         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2203         automatically now.
2204         (_tWinMain):
2205         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2206         (ServerConnection::ServerConnection):
2207         (ServerConnection::~ServerConnection):
2208         (ServerConnection::pause):
2209         (ServerConnection::resume):
2210         (ServerConnection::stepInto):
2211         (ServerConnection::applicationTerminating):
2212         (ServerConnection::serverConnectionDidDie):
2213         * Drosera/win/ServerConnection.h: Now uses the COM class.
2214
2215 2007-10-24  George Staikos  <staikos@kde.org>
2216
2217         Unbreak Qt build.
2218
2219         * Scripts/build-webkit:
2220
2221 2007-10-24  Adam Roben  <aroben@apple.com>
2222
2223         Remove now-unnecessary call to InitializeCoreGraphics
2224
2225         WebKit takes care of this now.
2226
2227         Reviewed by Ada.
2228
2229         * DumpRenderTree/win/DumpRenderTree.cpp:
2230         (initialize):
2231
2232 2007-10-24  Adam Roben  <aroben@apple.com>
2233
2234         Use WebTextRenderer in DRT
2235
2236         Reviewed by Ada.
2237
2238         * DumpRenderTree/win/DumpRenderTree.cpp:
2239         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2240
2241 2007-10-24  Sven Herzberg  <sven@imendio.com>
2242
2243         Reviewed by Mark Rowe.
2244
2245         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2246         Bug 15614: [GTK] qmake based backends don't build on OS X
2247
2248         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2249         GTK backend on a Mac
2250         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2251         isDarwin() to make it reusable in other places (like the workaround-
2252         for-prebuilt-qmake in build-webkit)
2253
2254 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2255
2256         Refurbish update-webkit script.
2257
2258         Reviewed by Adam.
2259
2260         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2261         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2262         multi-argument version of system() for flexibility and security.  Check for existence
2263         of Internal directory using -d test instead of -x.
2264
2265 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2266
2267         Minor clean-up of prepare-ChangeLog script.
2268
2269         Reviewed by Adam.
2270
2271         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2272         of a string.  Use multi-argument versions of open() and system() for flexibility and
2273         security.
2274
2275 2007-10-24  Alice Liu  <alice.liu@apple.com>
2276
2277         Reviewed by Oliver.
2278
2279         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2280
2281         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
2282         replay the saved events when we're still processing the mousedown that starts the drag
2283         * DumpRenderTree/win/EventSender.cpp:
2284         (doMouseMove):
2285         * DumpRenderTree/win/UIDelegate.cpp:
2286         (UIDelegate::doDragDrop):
2287
2288 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2289
2290         Reviewed by Sam, Steve and Darin.
2291
2292         - Stubbed out the WebScriptDebugListener functionality in the Server
2293         Connection class to prepare it for receiving those callbacks.
2294         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2295         and the ServerConnection to not need to be initialized with a server
2296         name, since that is not the way we connect to the WebKit server.
2297
2298         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2299         no exception.  Now it only loggs when there is an exception
2300         (DebuggerDocument::willExecuteStatement):
2301         (DebuggerDocument::didEnterCallFrame):
2302         (DebuggerDocument::willLeaveCallFrame):
2303         (DebuggerDocument::windowScriptObjectAvailable):
2304         (DebuggerDocument::callFunctionOnObject):
2305         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2306         to be instantiated with a server's name.
2307         (DebuggerClient::DebuggerClient):
2308         (DebuggerClient::didFinishLoadForFrame):
2309         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2310         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2311         a server name.
2312         (Drosera::init):
2313         (Drosera::initServer):
2314         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2315         instantiated with a server's name.
2316         * Drosera/win/ServerConnection.cpp:
2317         (ServerConnection::ServerConnection): No longer needs a server name
2318         (ServerConnection::~ServerConnection): Only release the global context
2319         if there is one.
2320         (ServerConnection::serverConnectionDidDie): Stub for
2321         IWebScriptDebugListener
2322         (ServerConnection::QueryInterface): ditto
2323         (ServerConnection::AddRef): ditto
2324         (ServerConnection::Release): ditto
2325         (ServerConnection::didLoadMainResourceForDataSource): ditto
2326         (ServerConnection::didParseSource): ditto
2327         (ServerConnection::failedToParseSource): ditto
2328         (ServerConnection::didEnterCallFrame): ditto
2329         (ServerConnection::willExecuteStatement): ditto
2330         (ServerConnection::willLeaveCallFrame): ditto
2331         (ServerConnection::exceptionWasRaised): ditto
2332         * Drosera/win/ServerConnection.h: Stubbed out the
2333         IWebScriptDebugListener functions, and this class no longer needs to be
2334         instantiated with a server name.
2335
2336 2007-10-24  Lars Knoll  <lars@trolltech.com>
2337
2338         Reviewed by Simon.
2339
2340         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2341
2342         * DumpRenderTree/qt/jsobjects.h:
2343
2344 2007-10-24  Lars Knoll  <lars@trolltech.com>
2345
2346         Reviewed by Simon.
2347
2348         add another command.
2349
2350         * DumpRenderTree/qt/jsobjects.cpp:
2351         (TextInputController::doCommand):
2352
2353 2007-10-24  Lars Knoll  <lars@trolltech.com>
2354
2355         Reviewed by Simon.
2356
2357         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2358
2359         * DumpRenderTree/qt/jsobjects.cpp:
2360         (EventSender::keyDown):
2361         * DumpRenderTree/qt/jsobjects.h:
2362
2363 2007-10-24  Lars Knoll  <lars@trolltech.com>
2364
2365         Reviewed by Simon.
2366
2367         implement eventSender.keyDown().
2368
2369         * DumpRenderTree/qt/jsobjects.cpp:
2370         (EventSender::keyDown):
2371
2372 2007-10-24  Lars Knoll  <lars@trolltech.com>
2373
2374         Reviewed by Simon.
2375
2376         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2377
2378         * DumpRenderTree/qt/DumpRenderTree.cpp:
2379         (WebCore::DumpRenderTree::DumpRenderTree):
2380         (WebCore::DumpRenderTree::initJSObjects):
2381         * DumpRenderTree/qt/jsobjects.cpp:
2382         (TextInputController::doCommand):
2383
2384 2007-10-24  Lars Knoll  <lars@trolltech.com>
2385
2386         Reviewed by Simon.
2387
2388         first bit of implementation for the textinputcontroller.
2389
2390         * DumpRenderTree/qt/DumpRenderTree.cpp:
2391         (WebCore::DumpRenderTree::DumpRenderTree):
2392         * DumpRenderTree/qt/DumpRenderTree.h:
2393         * DumpRenderTree/qt/jsobjects.cpp:
2394         (TextInputController::TextInputController):
2395         (TextInputController::doCommand):
2396         * DumpRenderTree/qt/jsobjects.h:
2397
2398 2007-10-24  Lars Knoll  <lars@trolltech.com>
2399
2400         Reviewed by Simon.
2401
2402         make the man webpage believe it has focus, so the editing tests work correctly.
2403
2404         * DumpRenderTree/qt/DumpRenderTree.cpp:
2405         (WebCore::DumpRenderTree::DumpRenderTree):
2406
2407 2007-10-24  Lars Knoll  <lars@trolltech.com>
2408
2409         Reviewed by Simon.
2410
2411         implement layoutTestController.dumpEditingCallbacks() correctly.
2412
2413         * DumpRenderTree/qt/DumpRenderTree.cpp:
2414         (WebCore::DumpRenderTree::DumpRenderTree):
2415         * DumpRenderTree/qt/jsobjects.cpp:
2416         (LayoutTestController::reset):
2417         (LayoutTestController::dumpEditingCallbacks):
2418
2419 2007-10-24  Lars Knoll  <lars@trolltech.com>
2420
2421         Reviewed by Simon.
2422
2423         Implement support for testing editing.
2424
2425         * DumpRenderTree/qt/DumpRenderTree.cpp:
2426         (WebCore::DumpRenderTree::DumpRenderTree):
2427
2428 2007-10-23  Sam Weinig  <sam@webkit.org>
2429
2430         Check for null BSTR that can be passed to the UIDelegate methods
2431         from javascript null and undefined.  Fixes a failing test case on
2432         Windows (fast/dom/Window/alert-undefined.html)
2433
2434         Reviewed by Eric Seidel.
2435
2436         * DumpRenderTree/win/UIDelegate.cpp:
2437         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2438         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2439         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2440         (UIDelegate::webViewAddMessageToConsole):
2441
2442 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2443
2444         Reviewed by Darin.
2445
2446         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2447
2448         * Scripts/build-testkjs:
2449
2450 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2451
2452         Reviewed by Darin.
2453
2454         - add wrapper that finds the right copy of testkjs
2455
2456         * Scripts/sunspider-compare-results: Added.
2457
2458 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2459
2460         Reviewed by Sam.
2461
2462         - After talking with Steve I now see that the WebKit server must be
2463         running for DCOM to create the distributed objects, which makes sense
2464         and currently WebKit only allows one instance to be running at a time
2465         which avoids accidentally connecting to the wrong server
2466         - In light of this I have removed the code for the attach box and
2467         NotificationServer and known server names, since they are all extranious
2468         now.
2469
2470         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2471         names.
2472         (_tWinMain): Uses init instead of initUI.
2473         (droseraWndProc): No longer creats an attach dialog box.
2474         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2475         it's not manditory to call init before doing COM stuff.
2476         (Drosera::init): calls initUI and will call attach when the
2477         functionality exists.
2478         (Drosera::initUI): Has changed very little.
2479         (Drosera::attach): Changed the signature to reflect that we no longer
2480         need the dictionary of known server names.
2481         * Drosera/win/Drosera.h: Removed notification classes and known server
2482         names.  Also renamed and moved some functions.
2483         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2484         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2485         headers to the resources folder.
2486         * Drosera/win/resource.h: Removed the Attach box.
2487
2488 2007-10-22  Adam Roben  <aroben@apple.com>
2489
2490         Windows build fix
2491
2492         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2493
2494 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2495
2496         - Removed a leak that was fixed.
2497
2498         * Scripts/run-webkit-tests:
2499
2500 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2501
2502         Reviewed by Darin.
2503
2504         - Changed the Client so that the DebuggerDocument now own the
2505         ServerConnection.  This simplifies ownership and cleanup.
2506
2507         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2508         ServerConnection.
2509         (DebuggerClient::initWithServerName):
2510         (DebuggerClient::didFinishLoadForFrame):
2511         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
2512         ServerConnection.
2513         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2514         until after we have a server which we are attached to.
2515         (Drosera::initUI):
2516         (Drosera::attach):
2517         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2518         out previously.
2519
2520 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2521
2522         Reviewed by Nikolas.
2523
2524         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2525
2526         * Scripts/run-javascriptcore-tests:
2527
2528 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2529
2530         Reviewed by Nikolas.
2531
2532         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2533
2534         * Scripts/build-drosera:
2535         * Scripts/build-dumprendertree:
2536         * Scripts/build-testkjs:
2537         * Scripts/build-webkit:
2538         * Scripts/run-javascriptcore-tests:
2539         * Scripts/run-sunspider:
2540         * Scripts/run-webkit-tests:
2541         * Scripts/webkitdirs.pm:
2542
2543 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2544
2545         Reviewed by Mark Rowe.
2546
2547         Fix for local database support after r26879
2548         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2549
2550         * Scripts/build-webkit:
2551
2552 2007-10-22  Holger Freyther  <zecke@selfish.org>
2553
2554         Reviewed by Simon Hausmann <hausmann@kde.org>.
2555
2556         - Do not build testkjs as an application bundle. This is
2557         needed for run-javascriptcore-tests on OSX.
2558         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2559         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2560         as we do not have -rpath on OSX.
2561
2562         * DumpRenderTree/qt/DumpRenderTree.pro:
2563         * Scripts/run-webkit-tests:
2564
2565 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2566
2567         Reviewed by aroben.
2568
2569         Fix support for Signed-off-by detection in prepare-ChangeLog
2570         --git-commit. The Signed-off-by tag does not appear in the header
2571         but usually at the end.
2572
2573         * Scripts/prepare-ChangeLog:
2574
2575 2007-10-21  Mark Rowe  <mrowe@apple.com>
2576
2577         Reviewed by Eric.
2578
2579         Fix run-javascriptcore-tests for Gtk.
2580
2581         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2582
2583 2007-10-20  Eric Seidel  <eric@webkit.org>
2584
2585         Reviewed by aroben.
2586
2587         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2588
2589 2007-10-20  Eric Seidel  <eric@webkit.org>
2590
2591         Reviewed by darin.
2592
2593         Add improved argument handling to run-sunspider, including
2594         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2595         Also re-factor code into subroutines
2596
2597         * Scripts/build-dumprendertree: removed bogus comments
2598         * Scripts/build-testkjs: Added.
2599         * Scripts/run-javascriptcore-tests: use build-testkjs
2600         * Scripts/run-sunspider: improved argument handling, abstraction
2601         * Scripts/run-webkit-tests: improved abstraction
2602
2603 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2604
2605         Not reviewed, Windows build fix.
2606
2607         * DumpRenderTree/win/EventSender.cpp:
2608         (keyDownCallback):
2609
2610 2007-10-20  Darin Adler  <darin@apple.com>
2611
2612         Reviewed by Tim Hatcher.
2613
2614         - http://bugs.webkit.org/show_bug.cgi?id=15544
2615           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2616           not rely on Apple-specific key codes
2617
2618         * DumpRenderTree/mac/EventSendingController.mm:
2619         (-[EventSendingController keyDown:withModifiers:]):
2620         Added named key "rightArrow". Later we could have a whole table of these.
2621         Also tweaked modifiers code a little.
2622
2623         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2624
2625 2007-10-19  Darin Adler  <darin@apple.com>
2626
2627         Reviewed by Eric.
2628
2629         - http://bugs.webkit.org/show_bug.cgi?id=15566
2630           possible fix for leak seen in DumpRenderTree
2631
2632         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2633         Delete the item if it's not put on the queue, since the caller has
2634         no way of knowing that. Would be better to have the parameter type
2635         be auto_ptr to express the fact that we take ownership.
2636
2637         - unrelated change
2638
2639         * Drosera/mac/main.m: Add missing include.
2640
2641 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2642
2643         Reviewed by Adam.
2644
2645         - This change should be identical but for some reason was not working
2646         on my machine.
2647
2648         * Scripts/prepare-ChangeLog:
2649
2650 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2651
2652         Reviewed by Oliver and Tim.
2653
2654         - Made use of RetainPtr to avoid retain and release issues and moved the
2655         log function to DebuggerDocumentPlatform, which seems to be a more
2656         logical place for it to live.
2657         - Also moved knownServers from the ServerConnection to
2658         DebuggerApplication to match the Windows code and because it makes sense
2659         that a connection knows its own server but not all of them.
2660
2661         * Drosera/mac/DebuggerClient.h: Moved the log function to
2662           DebuggerDocumentPlatform.
2663         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2664           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2665           call for the server name up from the ServerConnection class.
2666         (-[DebuggerClient dealloc]):
2667         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2668           for the server name up from the ServerConnection.
2669         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2670         (DebuggerDocument::platformPause):
2671         (DebuggerDocument::platformResume):
2672         (DebuggerDocument::platformStepInto):
2673         (DebuggerDocument::platformEvaluateScript):
2674         (DebuggerDocument::getPlatformCurrentFunctionStack):
2675         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2676         (DebuggerDocument::platformValueForScopeVariableNamed):
2677         (DebuggerDocument::platformLog): Log directly from here. No need to call
2678           DebuggerClient.
2679         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2680           way I see it, a ServerConnection should only know about its connection
2681           and the group of all possible servers should be kept by the
2682           application.
2683         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2684           currentServerName, it makes sense that the connection should know that
2685           name.
2686         (-[ServerConnection currentServerName]):
2687
2688 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2689
2690         Reviewed by Adam.
2691
2692         - Integrated changes from mac drosera.  Recently I've encapsulated
2693         out the server connection object from the rest of Drosera because
2694         it is very platform dependent right now and RPC is not implemented on
2695         windows.  This functionality, of communicating with the WebKit server
2696         is the next area I will be focusing on in Windows.
2697
2698         - Other changes and cleanup were made to organize the code and add notes
2699         on which parts still need work.  Also some mac code is added and
2700         commented out, to act as pseudocode for the logic of those parts.
2701
2702         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2703           pointer.
2704         * Drosera/config.h: Added whitespace.
2705         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2706           these files got moved into Drosera.h/cpp
2707         * Drosera/win/DebuggerApplication.h: Removed.
2708         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
2709           happened here to better match the logic flow of the same code on the
2710           mac side and to use the new ServerConnection class.
2711         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2712         (DebuggerClient::initWithServerName): Initializer that will set up the
2713           class to use a ServerConnection object.  This was necessary so I could
2714           create a DebuggerClient without having to initilaize it at
2715           construction.
2716         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2717           will be the UIDelegate and FrameLoadDelegate.
2718         (DebuggerClient::AddRef): For IUnknown.
2719         (DebuggerClient::Release): For IUnknown.
2720         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2721           this still needs to set the global context of the server, but
2722           IWebFrame does not have an accessor for the global context yet.
2723         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2724           this is a pass through for the same function in the document.
2725         (DebuggerClient::didReceiveTitle): Unimplemented part of
2726           FrameLoadDelegate this would change the title of the window.
2727         (DebuggerClient::createWebViewWithRequest): Part of the
2728           FrameLoadDelegate.  This is about new windows via Window.open() and
2729           how their delegates are set.
2730         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2731           UIDelegate.  Just a debug function for printing messages.
2732         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2733           because the Client should be the UIDelegate and FrameLoadDelegate
2734           to match the delegates on mac.
2735         (DebuggerClient::webViewLoaded): Added accessor method.
2736         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2737           forgotten to add this file before.  This is where the platform
2738           dependent versions of the Documents functions live. Most of these are
2739           unimplemented because some piece of functionality does not exist on
2740           Windows yet.
2741         (DebuggerDocument::platformPause):
2742         (DebuggerDocument::platformResume):
2743         (DebuggerDocument::platformStepInto):
2744         (DebuggerDocument::platformEvaluateScript):
2745         (DebuggerDocument::getPlatformCurrentFunctionStack):
2746         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2747         (DebuggerDocument::platformValueForScopeVariableNamed):
2748         (DebuggerDocument::platformLog):
2749         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2750           responsibilities becaue they belong in the Client. Also I laid the
2751           groundwork for attaching Drosera to a WebKit process
2752         (attachWndProc): Now if a server is selected the Client becomes it's
2753           delegate.
2754         (Drosera::Drosera): Added the construction of the Client and dictionary
2755           of server names.
2756         (Drosera::initUI): This is no longer the delegates, the Client is.
2757         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2758           state.
2759         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2760           notification registration when it's possible to implement.
2761         (Drosera::serverLoaded): Ditto
2762         (Drosera::serverUnloaded): Ditto
2763         (Drosera::attach): Attach Drosera to the WebKit server.
2764         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2765         (Drosera::getInst):
2766         (Drosera::setInst):
2767         (Drosera::knownServers):
2768         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2769           and added the ServerConnection.
2770         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2771         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2772           Most of the functions are completely unimlemented because they cannot
2773           connect with the WebKit server, because one does not exist on Windows
2774           yet.
2775         (ServerConnection::initWithServerName):
2776         (ServerConnection::~ServerConnection):
2777         (ServerConnection::setGlobalContext):
2778         (ServerConnection::pause):
2779         (ServerConnection::resume):
2780         (ServerConnection::stepInto):
2781         (ServerConnection::switchToServerNamed):
2782         (ServerConnection::applicationTerminating):
2783         (ServerConnection::serverConnectionDidDie):
2784         (ServerConnection::currentFrame):
2785         * Drosera/win/ServerConnection.h: Added. Ditto.
2786         (ServerConnection::ServerConnection):
2787
2788 2007-10-19  Alice Liu  <alice.liu@apple.com>
2789
2790         Reviewed by Darin.
2791
2792         Fix for these broken layout tests on Windows:
2793
2794         fast/forms/focus-selection-input.html
2795         fast/forms/focus-selection-textarea.html
2796         fast/forms/select-accesskey.html
2797
2798         * DumpRenderTree/win/EventSender.cpp:
2799         (keyDownCallback):
2800         correct the VK code for alt key.
2801
2802 2007-10-19  Eric Seidel  <eric@webkit.org>
2803
2804         Reviewed by Mark Rowe.
2805
2806         Make the GtkLauncher code slightly more readable.
2807
2808         * GtkLauncher/main.cpp:
2809         (setupMainMenu): Added.
2810         (setupMainWindowUI): Added.
2811         (main):
2812
2813 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2814
2815         Rubber stamped by Adam.
2816
2817         - don't delay-load WebKit in DumpRenderTree.
2818
2819         * DumpRenderTree/win/DumpRenderTree.vcproj:
2820
2821 2007-10-18  Dan Bernstein  <mitz@apple.com>
2822
2823         Reviewed by Adam Roben.
2824
2825         - fix <rdar://problem/5313523>
2826         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2827
2828         * DumpRenderTree/mac/DumpRenderTree.mm:
2829         (dump): Changed to use _responseMIMEType.
2830
2831 2007-10-17  Adam Roben  <aroben@apple.com>
2832
2833         Make it possible to have Windows-specific tests and results
2834
2835         When searching for tests to run and the Skipped file, we will only
2836         look in platform/win and the cross-platform directory. When looking
2837         for expected results, we will look in platform/win, then
2838         platform/mac-leopard, then platform/mac, then finally the
2839         cross-platform directory.
2840
2841         Reviewed by Sam.
2842
2843         * Scripts/run-webkit-tests:
2844         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2845         searching in the cross-platform directory.
2846         (sub buildPlatformHierarchy): Removed some unneeded calls to
2847         dirname/basename.
2848
2849 2007-10-17  Adam Roben  <aroben@apple.com>
2850
2851         Add back the call to register WebKit that we had before WebKitInitializer existed
2852
2853         This is needed to ensure that the right WebKit is used when
2854         instantiating COM objects.
2855
2856         Reviewed by Oliver.
2857
2858         * DumpRenderTree/win/debug_internal.vsprops: Define
2859         DEBUG_WEBKIT_HAS_SUFFIX.
2860         * DumpRenderTree/win/DumpRenderTree.cpp:
2861         (initialize):
2862
2863 2007-10-17  Adam Roben  <aroben@apple.com>
2864
2865         Import File::Basename in webkitdirs since we use it
2866
2867         * Scripts/webkitdirs.pm:
2868
2869 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2870
2871         - Updated the tiger leaks list to make the internal bots green.
2872
2873         * Scripts/run-webkit-tests:
2874
2875 2007-10-17  Adam Roben  <aroben@apple.com>
2876
2877         Build fix for VC++ Express
2878
2879         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2880         and ole32.lib.
2881
2882 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2883
2884         Reviewed by Sam.
2885
2886         - Minor mac improvements based on observations I made while implementing the
2887         Windows code.
2888
2889         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2890         then hand it to the Client who will retain it, it should just be the client who
2891         creates and owns the server.
2892         (-[DebuggerApplication attach:]):
2893         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2894         * Drosera/mac/DebuggerClient.mm: Creates the server.
2895         (-[DebuggerClient initWithServerName:]):
2896         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2897         can instead forward declare what it needs.
2898
2899 2007-10-16  Darin Adler  <darin@apple.com>
2900
2901         Reviewed by Geoff Garen.
2902
2903         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2904         want to turn failing tests into platform-specific test results. Also did a
2905         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2906         would take the type of results into account only some of the time.
2907
2908 2007-10-16  Adam Roben  <aroben@apple.com>
2909
2910         Add a new nightly launcher script for Windows
2911
2912         This new script is for versions of Safari that don't delay-load
2913         WebKit. I had to make FindSafari be able to print out the nightly
2914         launcher script on stdout because Windows shell scripts can't capture
2915         the output from a command into an environment variable.
2916
2917         Reviewed by Steve.
2918
2919         * FindSafari/FindSafari.cpp:
2920         (_tmain): Added /printSafariLauncher option.
2921         * Scripts/run-webkit-nightly.cmd: Added.
2922
2923 2007-10-16  Adam Roben  <aroben@apple.com>
2924
2925         Replace WebKitInitializer with FindSafari
2926
2927         We now rely on setting the PATH environment variable to tell Windows
2928         where to find WebKit and its dependencies (similar to
2929         DYLD_FRAMEWORK_PATH on Mac).
2930
2931         This change also make DumpRenderTree no longer delay-load WebKit.
2932
2933         Reviewed by Sam.
2934
2935         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2936         FindSafari.
2937         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2938         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2939         WebKitInitializer, don't delay-load WebKit.
2940         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2941         * Scripts/run-webkit-tests: Ditto.
2942         * Scripts/webkitdirs.pm:
2943         (sub setPathForRunningWebKitApp): Added.
2944         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2945         * WebKitInitializer/WebKitInitializer.h: Removed.
2946         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2947         * WebKitInitializer/debug.vsprops: Removed.
2948         * WebKitInitializer/debug_internal.vsprops: Removed.
2949         * WebKitInitializer/release.vsprops: Removed.
2950
2951 2007-10-16  Adam Roben  <aroben@apple.com>
2952
2953         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2954
2955         http://bugs.webkit.org/show_bug.cgi?id=15532
2956
2957         FindSafari simply prints the location of an installed Safari.exe on
2958         stdout.
2959
2960         Reviewed by Darin.
2961
2962         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2963         (getStringValue):
2964         (getWebViewCLSID):
2965         (getInstalledWebKitDirectory):
2966         (_tmain):
2967         * FindSafari/FindSafari.vcproj: Added.
2968         * Scripts/webkitdirs.pm:
2969         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2970
2971 2007-10-16  Adam Roben  <aroben@apple.com>
2972
2973         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2974
2975         Reviewed by Kevin McCullough.
2976
2977         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2978         when referring to WebKit.dll.
2979         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2980         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2981         * DumpRenderTree/win/release.vsprops: Ditto.
2982         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2983         never have a _debug suffix on WebKit.dll.
2984         * WebKitInitializer/WebKitInitializer.cpp:
2985         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2986         specified.
2987         * WebKitInitializer/debug_internal.vsprops: Added
2988         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2989
2990 2007-10-16  Darin Adler  <darin@apple.com>
2991
2992         Reviewed by Adele.
2993
2994         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2995         Remove now-unneeded control/alt key hack; the tests have been updated.
2996
2997 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2998
2999         - Updated leaks list because our internal bot upgraded it's version of leopard and
3000         one of the leaks was fixed between that revision and the bot's previous version of
3001         leopard.
3002
3003         * Scripts/run-webkit-tests:
3004
3005 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3006
3007         Reviewed by Tim.
3008
3009         - I encapsulated out the server connecton functionality because it is a specific part
3010         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3011         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3012         Windows.  So the majority of this patch is moving preexisting functionality.
3013
3014         - Also I removed the prefix header and changed to use config.h because it is more
3015         standard on how we use config.h in windows and it didn't make much sense to keep
3016         the prefix header and the config.h
3017
3018         * Drosera/DebuggerDocument.cpp:
3019         (DebuggerDocument::DebuggerDocument):
3020         * Drosera/DebuggerDocument.h:
3021         * Drosera/config.h:
3022         * Drosera/mac/DebuggerApplication.mm:
3023         (-[DebuggerApplication attach:]):
3024         * Drosera/mac/DebuggerClient.h:
3025         * Drosera/mac/DebuggerClient.mm:
3026         (-[DebuggerClient initWithServerConnection:]):
3027         (-[DebuggerClient dealloc]):
3028         (-[DebuggerClient windowDidLoad]):
3029         (-[DebuggerClient windowWillClose:]):
3030         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3031         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3032         * Drosera/mac/DebuggerDocumentPlatform.mm:
3033         (DebuggerDocument::platformPause):
3034         (DebuggerDocument::platformResume):
3035         (DebuggerDocument::platformStepInto):
3036         (DebuggerDocument::platformEvaluateScript):
3037         (DebuggerDocument::getPlatformCurrentFunctionStack):
3038         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3039         (DebuggerDocument::platformValueForScopeVariableNamed):
3040         (DebuggerDocument::platformLog):
3041         * Drosera/mac/Drosera.pch: Removed.
3042         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3043         * Drosera/mac/ServerConnection.h: Added.
3044         * Drosera/mac/ServerConnection.mm: Added.
3045         (-[ServerConnection initWithServerName:]):
3046         (-[ServerConnection dealloc]):
3047         (-[ServerConnection setGlobalContext:]):
3048         (-[ServerConnection pause]):
3049         (-[ServerConnection resume]):
3050         (-[ServerConnection stepInto]):
3051         (-[ServerConnection switchToServerNamed:]):
3052         (-[ServerConnection applicationTerminating:]):
3053         (-[ServerConnection serverConnectionDidDie:]):
3054         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3055         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3056         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3057         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3058         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3059         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3060         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3061         (-[ServerConnection currentFrame]):
3062         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3063         (-[ServerConnection knownServers]):
3064
3065 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3066
3067         Reviewed by Eric.
3068
3069         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3070           Script to automatically search nightly builds for regressions (bisect-builds)
3071
3072         * Scripts/bisect-builds: Added.
3073
3074 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3075
3076         Reviewed by Darin.
3077
3078         - New JavaScript benchmark
3079         http://bugs.webkit.org/show_bug.cgi?id=15515
3080
3081         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3082         current development or release build of JavaScriptCore.
3083
3084 2007-10-15  Mark Rowe  <mrowe@apple.com>
3085
3086         Reviewed by Sam.
3087
3088         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3089
3090         * Scripts/webkitdirs.pm:
3091         - Change checkArgv to remove the options from @ARGV to prevent
3092         them from interfering with further option processing.
3093         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3094         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3095         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3096         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3097
3098 2007-10-15  Darin Adler  <darin@apple.com>
3099
3100         Reviewed by Sam.
3101
3102         - added logging of window.prompt and window.confirm
3103
3104         * DumpRenderTree/mac/UIDelegate.mm:
3105         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3106         Implement the recommended delegate rather than the deprecated one.
3107         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3108         Added.
3109         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3110         Added.
3111
3112         * DumpRenderTree/win/UIDelegate.h:
3113         * DumpRenderTree/win/UIDelegate.cpp:
3114         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3115         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3116         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3117         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3118
3119 2007-10-15  Alice Liu  <alice.liu@apple.com>
3120
3121         Reviewed by Sam Weinig.
3122
3123         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3124
3125         * DumpRenderTree/win/DumpRenderTree.cpp:
3126         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3127         (main): allocate the global policy delegate for DRT's custom use
3128         * DumpRenderTree/win/DumpRenderTree.vcproj:
3129         Adding files to project
3130         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3131         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3132         (LayoutTestController::setCustomPolicyDelegate):
3133         set the webview's policy delegate to DRT's custom one if the test requests it.
3134         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3135         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3136         (PolicyDelegate::PolicyDelegate):
3137         (PolicyDelegate::QueryInterface):
3138         (PolicyDelegate::AddRef):
3139         (PolicyDelegate::Release):
3140         (PolicyDelegate::decidePolicyForNavigationAction):
3141         * DumpRenderTree/win/PolicyDelegate.h: Added.
3142         (PolicyDelegate::decidePolicyForNewWindowAction):
3143         (PolicyDelegate::decidePolicyForMIMEType):
3144         (PolicyDelegate::unableToImplementPolicyWithError):
3145
3146 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3147
3148         Reviewed by Mark.
3149
3150         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3151         when querying for QMAKE_MKSPECS.
3152
3153 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3154
3155         Reviewed by Adam Roben.
3156
3157         Fix run-webkit-tests is too greedy calculating platform hierarchy
3158         http://bugs.webkit.org/show_bug.cgi?id=15465
3159
3160         Fix run-webkit-tests being too greedy in trying to split the platform name up
3161         causing it to try and find tests in every directory above the first "-" in the
3162         path to the LayoutTests
3163
3164         * Scripts/run-webkit-tests:
3165
3166 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3167
3168         Reviewed by Darin.
3169
3170         http://bugs.webkit.org/show_bug.cgi?id=15006
3171         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3172         to reduce code duplication.
3173
3174         * Scripts/build-webkit:
3175         * Scripts/webkitdirs.pm:
3176         buildQMakeProject() renamed to buildQMakeQtProject().
3177         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3178         unused $colorize has been removed.
3179
3180 === Start merge of feature-branch 2007-10-12 ===
3181
3182 2007-10-08  Eric Seidel  <eric@webkit.org>
3183
3184         Reviewed by Mark Rowe.
3185
3186         * Scripts/build-webkit: add --help, remove unused --color
3187
3188 2007-10-07  Eric Seidel  <eric@webkit.org>
3189
3190         Reviewed by darin.
3191
3192         * Drosera/mac/DebuggerDocumentPlatform.mm:
3193         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3194
3195 2007-10-03  Rob Buis  <buis@kde.org>
3196
3197         Reviewed by Olliej.
3198
3199         Adapt to changed location of Ahem font.
3200
3201         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3202
3203 2007-10-02  Eric Seidel  <eric@webkit.org>
3204
3205         Reviewed by Adam Roben.
3206
3207         Make pixel tests more useful!
3208         Finally fix the image diff 0.00% mystery problem
3209         Highlight any image differences in the image diff.
3210         Add a link from image diffs back to original test file.
3211
3212         * DumpRenderTree/mac/ImageDiff.m:
3213         (compareImages): highlight any differences
3214         (computePercentageDifferent): round to two decimal places
3215         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3216
3217 2007-10-02  Eric Seidel  <eric@webkit.org>
3218
3219         Reviewed by Alexey Proskuryakov.
3220
3221         * Scripts/run-webkit-tests: print the % image difference on main results page
3222
3223 2007-10-02  Mark Rowe  <mrowe@apple.com>
3224
3225         Reviewed by Oliver.
3226
3227         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3228
3229         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3230         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3231
3232 2007-10-01  Mark Rowe  <mrowe@apple.com>
3233
3234         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3235
3236 2007-09-25  Eric Seidel  <eric@webkit.org>
3237
3238         Reviewed by Mark Rowe.
3239
3240         DerivedSources.make was finding "ENABLE_SVG" in the string
3241         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3242         quite correctly.
3243
3244         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3245
3246 2007-09-25  Mark Rowe  <mrowe@apple.com>
3247
3248         Rubber-stamped by Eric.
3249
3250         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3251         This makes it possible to automate nightly builds for the feature-branch.
3252
3253 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3254
3255         Rubber stamped by Mark.
3256
3257         Enable svg experimental features as default here in feature-branch.
3258
3259         * Scripts/build-webkit:
3260
3261 2007-06-29  Antti Koivisto  <antti@apple.com>
3262
3263         Reviewed by Weinig.
3264
3265         Add VIDEO flag for timed media features
3266
3267         * Scripts/build-webkit
3268
3269 === End merge of feature-branch 2007-10-12 ===
3270
3271 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3272
3273         Reviewed by Darin.
3274
3275         - Updated rational for the leaks list to be more clear.
3276
3277         * Scripts/run-webkit-tests:
3278
3279 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3280
3281         Rubber Stamp by Sam.
3282
3283         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3284         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3285
3286         * Scripts/run-webkit-tests:
3287
3288 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3289
3290         Reviewed by Lars.
3291
3292         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3293         includes are needed for INT_MAX, std::auto_ptr and the like.
3294
3295         * DumpRenderTree/qt/main.cpp:
3296
3297 2007-10-09  Lars Knoll  <lars@trolltech.com>
3298
3299         Reviewed by Simon.
3300
3301         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3302
3303         * DumpRenderTree/qt/jsobjects.cpp:
3304         (LayoutTestController::encodeHostName):
3305         (LayoutTestController::decodeHostName):
3306         * DumpRenderTree/qt/jsobjects.h:
3307
3308 2007-10-09  Lars Knoll  <lars@trolltech.com>
3309
3310         Reviewed by Simon.
3311
3312         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3313
3314         * DumpRenderTree/qt/DumpRenderTree.cpp:
3315         (WebCore::WebPage::createFrame):
3316         (WebCore::DumpRenderTree::DumpRenderTree):
3317         (WebCore::DumpRenderTree::titleChanged):
3318         * DumpRenderTree/qt/DumpRenderTree.h:
3319         * DumpRenderTree/qt/jsobjects.cpp:
3320         (LayoutTestController::reset):
3321         * DumpRenderTree/qt/jsobjects.h:
3322
3323 2007-10-09  Lars Knoll  <lars@trolltech.com>
3324
3325         Reviewed by Simon.
3326
3327         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3328
3329         * DumpRenderTree/qt/DumpRenderTree.h:
3330         * DumpRenderTree/qt/jsobjects.cpp:
3331         (LayoutTestController::clearBackForwardList):
3332         * DumpRenderTree/qt/jsobjects.h:
3333
3334 2007-10-09  Lars Knoll  <lars@trolltech.com>
3335
3336         Reviewed by Simon.
3337
3338         make --git-reviewer work again.
3339
3340         * Scripts/prepare-ChangeLog:
3341
3342 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3343
3344         Rubber stamped by Eric.
3345
3346         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3347         show the current link inside the statusbar.
3348         This shows how to make use of this signal and allows to easily test
3349         http://bugs.webkit.org/show_bug.cgi?id=15299.
3350
3351         * GtkLauncher/main.cpp:
3352         (hoveringOverLink):
3353         (main):
3354
3355 2007-10-05  Lars Knoll  <lars@trolltech.com>
3356
3357         add proper error messages to the FrameLoaderClient.
3358         Implement ChromeClientQt::closeWindowSoon and
3359         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3360         Some fixes in DRT to make it work correctly with multiple windows.
3361
3362         Reviewed by Maciej.
3363
3364         * DumpRenderTree/qt/DumpRenderTree.cpp:
3365         (WebCore::DumpRenderTree::DumpRenderTree):
3366         (WebCore::DumpRenderTree::createWindow):
3367         (WebCore::DumpRenderTree::windowCount):
3368         * DumpRenderTree/qt/DumpRenderTree.h:
3369         * DumpRenderTree/qt/jsobjects.cpp:
3370         (LayoutTestController::maybeDump):
3371         (LayoutTestController::windowCount):
3372         * DumpRenderTree/qt/jsobjects.h:
3373
3374 2007-10-05  Lars Knoll  <lars@trolltech.com>
3375
3376         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3377         Add support for layoutTextController.setCanOpenWindows() to DRT
3378         fixing another 2 test cases in fast/dom/Window.
3379
3380         Reviewed by Maciej.
3381
3382         * DumpRenderTree/qt/DumpRenderTree.cpp:
3383         (WebCore::WebPage::WebPage):
3384         (WebCore::WebPage::createWindow):
3385         (WebCore::DumpRenderTree::resetJSObjects):
3386         (WebCore::DumpRenderTree::createWindow):
3387         * DumpRenderTree/qt/DumpRenderTree.h:
3388         * DumpRenderTree/qt/DumpRenderTree.pro:
3389         * DumpRenderTree/qt/jsobjects.cpp:
3390         (LayoutTestController::LayoutTestController):
3391         (LayoutTestController::reset):
3392         * DumpRenderTree/qt/jsobjects.h:
3393         * DumpRenderTree/qt/main.cpp:
3394         * DumpRenderTree/qt/testplugin.cpp: Added.
3395         * DumpRenderTree/qt/testplugin.h: Added.
3396
3397 2007-10-04  Sam Weinig  <sam@webkit.org>
3398
3399         Rubber stamped by Adam.
3400
3401         Remove empty directories.
3402
3403         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3404         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3405
3406 2007-10-03  Darin Adler  <darin@apple.com>
3407
3408         Reviewed by Adam.
3409
3410         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3411         we find the internal libraries in the libraries directory. This
3412         is helpful for Safari team engineers at Apple.
3413
3414 2007-10-03  Adam Roben  <aroben@apple.com>
3415
3416         Update the location of AHEM___.TTF after r25968
3417
3418         Reviewed by Sam.
3419
3420         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3421
3422 2007-10-03  Alp Toker  <alp@atoker.com>
3423
3424         Reviewed by Adam.
3425
3426         http://bugs.webkit.org/show_bug.cgi?id=14726
3427         [gtk] API design. Mapping the WebView delegates to signals.
3428
3429         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3430
3431         * GtkLauncher/main.cpp:
3432         (goToURLBarText):
3433         (titleChanged):
3434         (progressChanged):
3435         (menuMainBackCallback):
3436         (menuMainForwardCallback):
3437         (main):
3438
3439 2007-10-03  Lars Knoll  <lars@trolltech.com>
3440
3441         Reviewed by Rob.
3442
3443         This fixes --strict mode in run-webkit-tests again after
3444         the platform dependent test results have been moved.
3445
3446         * Scripts/run-webkit-tests:
3447
3448 2007-10-03  Lars Knoll  <lars@trolltech.com>
3449
3450         Reviewed by bdash.
3451
3452         remove the hack in run-webkit-tests that forced text only test
3453         to be taken from the platform independent dir. It was only left
3454         there from early days.
3455
3456         Remove platform dependent results for tests that are text only nowadays,
3457         and add one platform dependent result for a text only test that requires it.
3458
3459         * Scripts/run-webkit-tests:
3460
3461 2007-10-03  Lars Knoll  <lars@trolltech.com>
3462
3463         Reviewed by olliej.
3464
3465         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3466
3467         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3468         (WebCore::WebFrame::WebFrame):
3469         (WebCore::WebPage::WebPage):
3470         (WebCore::WebPage::createFrame):
3471         (WebCore::WebPage::javaScriptAlert):
3472         (WebCore::WebPage::javaScriptConsoleMessage):
3473         (WebCore::DumpRenderTree::DumpRenderTree):
3474         (WebCore::DumpRenderTree::~DumpRenderTree):
3475         (WebCore::DumpRenderTree::open):
3476         (WebCore::DumpRenderTree::readStdin):
3477         (WebCore::DumpRenderTree::resetJSObjects):
3478         (WebCore::DumpRenderTree::initJSObjects):
3479         (WebCore::DumpRenderTree::dumpFramesAsText):
3480         (WebCore::DumpRenderTree::dump):
3481         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3482         (WebCore::DumpRenderTree::layoutTestController):
3483         (WebCore::DumpRenderTree::eventSender):
3484         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3485         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3486         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3487         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3488         (HackWebFrame::mousePressEvent):
3489         (HackWebFrame::mouseReleaseEvent):
3490         (HackWebFrame::mouseMoveEvent):
3491         (HackWebFrame::HackWebFrame):
3492         (HackWebFrame::~HackWebFrame):
3493         (LayoutTestController::LayoutTestController):
3494         (LayoutTestController::reset):
3495         (LayoutTestController::maybeDump):
3496         (LayoutTestController::waitUntilDone):
3497         (LayoutTestController::notifyDone):
3498         (LayoutTestController::dumpEditingCallbacks):
3499         (LayoutTestController::queueReload):
3500         (LayoutTestController::provisionalLoad):
3501         (LayoutTestController::timerEvent):
3502         (EventSender::EventSender):
3503         (EventSender::mouseDown):
3504         (EventSender::mouseUp):
3505         (EventSender::mouseMoveTo):
3506         (EventSender::leapForward):
3507         (EventSender::keyDown):
3508         (EventSender::frameUnderMouse):
3509         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3510         (LayoutTestController::isLoading):
3511         (LayoutTestController::setLoading):
3512         (LayoutTestController::shouldDumpAsText):
3513         (LayoutTestController::shouldDumpChildrenAsText):
3514         (LayoutTestController::shouldWaitUntilDone):
3515         (LayoutTestController::dumpAsText):
3516         (LayoutTestController::dumpChildFramesAsText):
3517         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3518         (messageHandler):
3519         (crashHandler):
3520         (main):
3521         * Scripts/run-webkit-tests:
3522
3523 2007-10-03  Mark Rowe  <mrowe@apple.com>
3524
3525         Reviewed by Alp Toker.
3526
3527         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3528         should take precedence over QTDIR when determining which port we are working with.
3529
3530         * Scripts/webkitdirs.pm:
3531
3532 2007-10-02  Adam Roben  <aroben@apple.com>
3533
3534         Add keychain to the list of default packages to install
3535
3536         Rubberstamped by Sam.
3537
3538         * CygwinDownloader/cygwin-downloader.py:
3539         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3540
3541 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3542
3543         Reviewed by Adam.
3544
3545         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3546         Also makes WebCore regression test case logic work when using git.
3547
3548         * Scripts/prepare-ChangeLog:
3549         (reviewerAndDescriptionForGitCommit): Added.
3550
3551 2007-10-02  Lars Knoll  <lars@trolltech.com>
3552
3553         Reviewed by bdash.
3554
3555         Add API to retrieve the frame name from QWebFrame.
3556         Implement support for DRT::dumpChildrenAsText.
3557
3558         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3559         (WebCore::DumpRenderTree::dumpFramesAsText):
3560         (WebCore::DumpRenderTree::dump):
3561         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3562         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3563         (LayoutTestController::LayoutTestController):
3564         (LayoutTestController::reset):
3565         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3566
3567 2007-10-02  Lars Knoll  <lars@trolltech.com>
3568
3569         Reviewed by bdash.
3570
3571         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3572
3573         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3574         (WebCore::DumpRenderTree::readStdin):
3575
3576 2007-10-02  Mark Rowe  <mrowe@apple.com>
3577
3578         Reviewed by Oliver.
3579
3580         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3581
3582         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3583         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3584
3585 2007-10-02  Mark Rowe  <mrowe@apple.com>
3586
3587         Rubber-stamped by Maciej.
3588
3589         Configuration changes from build.webkit.org.  The major change is refactoring to work
3590         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3591         last few weeks.
3592
3593         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3594         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3595         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3596         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3597         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3598         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3599         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3600         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3601
3602 2007-10-02  Lars Knoll  <lars@trolltech.com>
3603
3604         Reviewed by Maciej.
3605
3606         Add support for eventSender.mouseMove to DRT.
3607         Fixes fast/css/hover-affects-child.html
3608
3609         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3610         (EventSender::mouseMoveTo):
3611
3612 2007-10-01  Mark Rowe  <mrowe@apple.com>
3613
3614         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3615
3616 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3617
3618         Reviewed by Hyatt.
3619
3620         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3621
3622         * Scripts/svn-apply:
3623         (gitdiff2svndiff): Ignore lines beginning with "new file".
3624         * Scripts/svn-unapply:
3625         (gitdiff2svndiff): Ditto.
3626
3627 2007-09-30  George Staikos  <staikos@kde.org>
3628
3629         Qt build fix (Mac OS X specific)
3630
3631         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3632
3633 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3634
3635         Reviewed by Mark.
3636
3637         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3638         Remove Bakefiles from svn.
3639
3640         * GtkLauncher/Bakefiles.bkgen: Removed.
3641         * GtkLauncher/ENV: Removed.
3642         * GtkLauncher/gdklauncher.bkl: Removed.
3643         * GtkLauncher/mk: Removed.
3644         * Scripts/regenerate-makefiles: Removed.
3645
3646 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3647
3648         Reviewed by John.
3649
3650         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3651
3652         * Scripts/run-webkit-tests:
3653
3654 2007-09-26  Adam Roben  <aroben@apple.com>
3655
3656         Make not finding an installed WebKit non-fatal
3657
3658         What really matters is that we are able to load WebKit and its
3659         dependencies, not whether we think we've found an installed WebKit.
3660
3661         Reviewed by Sam.
3662
3663         * WebKitInitializer/WebKitInitializer.cpp:
3664         (getWebViewCLSID): Use new LOG_WARNING macro.
3665         (getInstalledWebKitDirectory): Ditto.
3666         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3667         and use new macros.
3668         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3669
3670 2007-09-26  Adam Roben  <aroben@apple.com>
3671
3672         Committed this file before saving it
3673
3674         * WebKitInitializer/debug_internal.vsprops:
3675
3676 2007-09-26  Adam Roben  <aroben@apple.com>
3677
3678         Load WebKit and its dependencies manually so they come from DllDirectory
3679
3680         I had to change WebKitInitializer to use malloc/free instead of
3681         new/delete to avoid pulling in WebKit (and its dependencies) early
3682         through use of fastMalloc.
3683
3684         Reviewed by Oliver.
3685
3686         * WebKitInitializer/WebKitInitializer.cpp:
3687         (getStringValue): Changed to use malloc/free.
3688         (getInstalledWebKitDirectory): Ditto.
3689         (initializeWebKit): Call SetDllDirectory first, then load all of
3690         WebKit's dependencies manually, finally followed by WebKit itself.
3691         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3692         configuration to match our other projects.
3693         * WebKitInitializer/debug_internal.vsprops: Added.
3694
3695 2007-09-25  Adam Roben  <aroben@apple.com>
3696
3697         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3698
3699         Rubberstamped by Sam.
3700
3701         * WebKitInitializer/WebKitInitializer.vcproj:
3702
3703 2007-09-25  Adam Roben  <aroben@apple.com>
3704
3705         Make DumpRenderTree delay-load its dependencies
3706
3707         This lets WebKitInitializer re-route the dependencies to be loaded out
3708         of the Safari installation directory.
3709
3710         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3711         same thing), since we can't import the kCFAllocatorDefault symbol when
3712         delay-loading CoreFoundation.dll.
3713
3714         Rubberstamped by Sam.
3715
3716         * DumpRenderTree/win/DumpRenderTree.cpp:
3717         (runTest):
3718         (javaScriptThreads):
3719         * DumpRenderTree/win/DumpRenderTree.vcproj:
3720         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3721         (LayoutTestController::setWaitToDump):
3722
3723 2007-09-25  Adam Roben  <aroben@apple.com>
3724
3725         Pull ole32.lib into WebKitInitializer
3726
3727         Rubberstamped by Sam.
3728
3729         * WebKitInitializer/WebKitInitializer.vcproj:
3730
3731 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3732
3733         Reviewed by Adam.
3734
3735         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3736           LGPL'ed files contain incorrect FSF address
3737
3738         * Drosera/config.h:
3739
3740 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3741
3742         Reviewed by Adam.
3743
3744         Make svn-apply and svn-unapply work with git-diff formatted patches.
3745
3746         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3747         (gitdiff2svndiff): Added.
3748         * Scripts/svn-unapply: Ditto.
3749         (gitdiff2svndiff): Added.
3750
3751 2007-09-25  Adam Roben  <aroben@apple.com>
3752
3753         Pull advapi32.lib into WebKitInitializer
3754
3755         This is needed to get the registry functions we use.
3756
3757         Rubberstamped by Sam.
3758
3759         * WebKitInitializer/WebKitInitializer.vcproj:
3760
3761 2007-09-25  Adam Roben  <aroben@apple.com>
3762
3763         Add python and rsync to cygwin-downloader
3764
3765         Our build slaves need this, and it can't hurt for everyone else to
3766         have it, too.
3767
3768         Reviewed by Sam.
3769
3770         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3771         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3772
3773 2007-09-25  Adam Roben  <aroben@apple.com>
3774
3775         Add WebKitInitializer and use it in DumpRenderTree
3776
3777         WebKitInitializer is a static library that has one function,
3778         initializeWebKit(). This registers WebKit and sets up the DLL search
3779         path so that WebKit's dependencies that are installed with Safari can
3780         be found.
3781
3782         Reviewed by Sam.
3783
3784         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3785         DumpRenderTree depend on it.
3786         * DumpRenderTree/win/DumpRenderTree.cpp:
3787         (initialize): Call initializeWebKit.
3788         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
3789         WebKitInitializer.lib.
3790         * WebKitInitializer/WebKitInitializer.cpp: Added.
3791         (getStringValue):
3792         (getWebViewCLSID):
3793         (getInstalledWebKitDirectory):
3794         (initializeWebKit):
3795         * WebKitInitializer/WebKitInitializer.h: Added.
3796         * WebKitInitializer/WebKitInitializer.vcproj: Added.
3797         * WebKitInitializer/debug.vsprops: Added.
3798         * WebKitInitializer/release.vsprops: Added.
3799
3800 2007-09-25  Adam Roben  <aroben@apple.com>
3801
3802         Make run-webkit-tests respect set-webkit-configuration
3803
3804         Reviewed by Sam.
3805
3806         * Scripts/run-webkit-tests: Initialize $configuration to whatever
3807         set-webkit-configuration was last set to.
3808
3809 2007-09-25  Mark Rowe  <mrowe@apple.com>
3810
3811         Rubber-stamped by Eric.
3812
3813         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3814         This makes it possible to automate nightly builds for the feature-branch.
3815
3816 2007-09-25  Adam Roben  <aroben@apple.com>
3817
3818         A couple of fixes/enhancements to update-webkit-*-libs
3819
3820         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
3821         to tell update-webkit-support-libraries where it should find the
3822         WebKitSupportLibrary.zip file you downloaded.
3823
3824         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
3825         Windows-style path.
3826
3827         Reviewed by Sam.
3828
3829         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
3830         to $auxiliaryLibsURL and removed an irrelevant comment.
3831         * Scripts/update-webkit-support-libs:
3832
3833 2007-09-25  Adam Treat  <treat@kde.org>
3834
3835         Reviewed by Simon and Lars.
3836
3837         Refactors and cleans up Qt DRT member variable names, member variable
3838         initialization, style fixes and general code cleanup.
3839
3840         Adds queueReload slot to LayoutTestController that some tests require.
3841
3842         Subclasses QWebFrame to make sure that all frames have an associated
3843         LayoutTestController JS window object.
3844
3845         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
3846         aren't dumped twice.
3847
3848         EOF fixes.
3849
3850         Together, this patch fixes some 20+ layout tests in QtWebKit.
3851
3852         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3853         (WebCore::WebFrame::WebFrame):
3854         (WebCore::WebPage::WebPage):
3855         (WebCore::WebPage::createFrame):
3856         (WebCore::DumpRenderTree::DumpRenderTree):
3857         (WebCore::DumpRenderTree::open):
3858         (WebCore::DumpRenderTree::readStdin):
3859         (WebCore::DumpRenderTree::initJSObjects):
3860         (WebCore::DumpRenderTree::dump):
3861         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3862         (WebCore::DumpRenderTree::layoutTestController):
3863         (WebCore::DumpRenderTree::eventSender):
3864         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3865         (LayoutTestController::LayoutTestController):
3866         (LayoutTestController::reset):
3867         (LayoutTestController::maybeDump):
3868         (LayoutTestController::waitUntilDone):
3869         (LayoutTestController::notifyDone):
3870         (LayoutTestController::queueReload):
3871         (LayoutTestController::provisionalLoad):
3872         (EventSender::EventSender):
3873         (EventSender::mouseDown):
3874         (EventSender::mouseUp):
3875         (EventSender::mouseMoveTo):
3876         (EventSender::frameUnderMouse):
3877         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3878         (LayoutTestController::isLoading):
3879         (LayoutTestController::setLoading):
3880         (LayoutTestController::dumpAsText):
3881         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3882         (main):
3883
3884 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3885
3886
3887         - Reverted an accidentally checked in file.
3888
3889         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3890
3891 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3892         Reviewed by Sam.
3893
3894         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
3895
3896         * DumpRenderTree/win/DumpRenderTree.vcproj:
3897         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3898
3899 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3900
3901         Rubber stamped by Adam.
3902
3903         * GdkLauncher: Removed.
3904         * GdkLauncher/Bakefiles.bkgen: Removed.
3905         * GdkLauncher/ENV: Removed.
3906         * GdkLauncher/GdkLauncher.pro: Removed.
3907         * GdkLauncher/gdklauncher.bkl: Removed.
3908         * GdkLauncher/main.cpp: Removed.
3909         * GdkLauncher/mk: Removed.
3910         * GdkLauncher/simple.svg: Removed.
3911         * GdkLauncher/text.html: Removed.
3912         * GtkLauncher: Added.
3913         * GtkLauncher/GdkLauncher.pro: Removed.
3914         * GtkLauncher/GtkLauncher.pro: Added.
3915         * GtkLauncher/main.cpp:
3916         (updateWindowTitle):
3917         (main):
3918         * Scripts/build-webkit:
3919         * Scripts/regenerate-makefiles:
3920         * Scripts/run-javascriptcore-tests:
3921         * Scripts/run-launcher:
3922         * Scripts/run-webkit-tests:
3923         * Scripts/webkitdirs.pm:
3924
3925 2007-09-21  Timothy Hatcher  <timothy@apple.com>
3926
3927         Reviewed by Darin.
3928
3929         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3930
3931         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
3932         This is tested by plugins/root-object-premature-delete-crash.html.
3933
3934         * DumpRenderTree/mac/ObjCController.m:
3935         (-[ObjCController accessStoredWebScriptObject]):
3936
3937 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
3938
3939         Reviewed by Oliver.
3940
3941         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
3942
3943         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3944         (FrameLoadDelegate::FrameLoadDelegate):
3945
3946 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
3947
3948         Reviewed by Adam.
3949
3950         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
3951         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
3952
3953         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
3954         Now isQt() and isGdk() use global variables that are only set once.
3955
3956         An array of all the parameters is now given to build-dumprender which includes
3957         the platform on linux.
3958
3959         * Scripts/build-dumprendertree:
3960         * Scripts/run-webkit-tests:
3961         * Scripts/webkitdirs.pm:
3962
3963 2007-09-19  Adam Roben  <aroben@apple.com>
3964
3965         Rubberstamped by Hyatt.
3966
3967         * Spinneret: Removed.
3968
3969 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
3970
3971         Reviewed by David Kilzer.
3972
3973         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
3974
3975 2007-09-18  Sam Weinig  <sam@webkit.org>
3976
3977         Add JSRetainPtr.h #include to fix some builds.
3978
3979         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3980
3981 2007-09-18  Mike Hommey  <glandium@debian.org>
3982
3983         Reviewed by Adam.
3984
3985         * Scripts/prepare-ChangeLog:
3986         - Properly parse GECOS field.
3987         - Use git configuration for user name and email when appropriate.
3988
3989 2007-09-17  Sam Weinig  <sam@webkit.org>
3990
3991         Build fix.
3992
3993         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3994
3995 2007-09-17  Sam Weinig  <sam@webkit.org>
3996
3997         Reviewed by Adam Roben.
3998
3999         Share more code between mac and windows DRT.
4000             - GCController is now shared.
4001             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
4002
4003         * DumpRenderTree/GCController.cpp:
4004         * DumpRenderTree/win/DumpRenderTree.cpp:
4005         * DumpRenderTree/win/DumpRenderTree.vcproj:
4006         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
4007         (FrameLoadDelegate::FrameLoadDelegate):
4008         (FrameLoadDelegate::~FrameLoadDelegate):
4009         (FrameLoadDelegate::windowScriptObjectAvailable):
4010         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
4011         * DumpRenderTree/win/GCController.cpp: Removed.
4012         * DumpRenderTree/win/GCController.h: Removed.
4013         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
4014         (GCController::collect):
4015         (GCController::collectOnAlternateThread):
4016         (GCController::getJSObjectCount):
4017         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
4018         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
4019
4020 2007-09-17  Sam Weinig  <sam@webkit.org>
4021
4022         Reviewed by Adam Roben.
4023
4024         Begin sharing code between mac and windows DRT.
4025             - both now share LayoutTestController.h/cpp and implement platform dependant
4026               operations in LayoutTestControllerMac/Win.
4027             - DumpRenderTree.h is now shared.
4028             - WorkQueue and WorkQueueItem are also shared.
4029
4030         * DumpRenderTree/DumpRenderTree.h:
4031         * DumpRenderTree/LayoutTestController.cpp:
4032         * DumpRenderTree/win/DumpRenderTree.cpp:
4033         (displayWebView):
4034         (dumpFrameScrollPosition):
4035         (dumpFramesAsText):
4036         (dump):
4037         (runTest):
4038         * DumpRenderTree/win/DumpRenderTree.h: Removed.
4039         * DumpRenderTree/win/DumpRenderTree.vcproj:
4040         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
4041         * DumpRenderTree/win/EditingDelegate.cpp:
4042         (EditingDelegate::shouldBeginEditingInDOMRange):
4043         (EditingDelegate::shouldEndEditingInDOMRange):
4044         (EditingDelegate::shouldInsertNode):
4045         (EditingDelegate::shouldInsertText):
4046         (EditingDelegate::shouldDeleteDOMRange):
4047         (EditingDelegate::shouldChangeSelectedDOMRange):
4048         (EditingDelegate::shouldApplyStyle):
4049         (EditingDelegate::shouldChangeTypingStyle):
4050         (EditingDelegate::doPlatformCommand):
4051         (EditingDelegate::webViewDidBeginEditing):
4052         (EditingDelegate::webViewDidChange):
4053         (EditingDelegate::webViewDidEndEditing):
4054         (EditingDelegate::webViewDidChangeTypingStyle):
4055         (EditingDelegate::webViewDidChangeSelection):
4056         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
4057         * DumpRenderTree/win/LayoutTestController.h: Removed.
4058         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
4059         (LayoutTestController::addDisallowedURL):
4060         (LayoutTestController::clearBackForwardList):
4061         (LayoutTestController::copyDecodedHostName):
4062         (LayoutTestController::copyEncodedHostName):
4063         (LayoutTestController::display):
4064         (LayoutTestController::keepWebHistory):
4065         (LayoutTestController::notifyDone):
4066         (LayoutTestController::queueBackNavigation):
4067         (LayoutTestController::queueForwardNavigation):
4068         (jsStringRefToWString):
4069         (LayoutTestController::queueLoad):
4070         (LayoutTestController::queueReload):
4071         (LayoutTestController::queueScript):
4072         (LayoutTestController::setAcceptsEditing):
4073         (LayoutTestController::setCustomPolicyDelegate):
4074         (LayoutTestController::setMainFrameIsFirstResponder):
4075         (LayoutTestController::setTabKeyCyclesThroughElements):
4076         (LayoutTestController::setUseDashboardCompatibilityMode):
4077         (LayoutTestController::setUserStyleSheetEnabled):
4078         (LayoutTestController::setUserStyleSheetLocation):
4079         (LayoutTestController::setWindowIsKey):
4080         (waitUntilDoneWatchdogFired):
4081         (LayoutTestController::setWaitToDump):
4082         (LayoutTestController::windowCount):
4083         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
4084         (FrameLoadDelegate::didReceiveTitle):
4085         (FrameLoadDelegate::processWork):
4086         (FrameLoadDelegate::locationChangeDone):
4087         (FrameLoadDelegate::windowScriptObjectAvailable):
4088         * DumpRenderTree/win/WorkQueue.cpp: Removed.
4089         * DumpRenderTree/win/WorkQueue.h: Removed.
4090         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
4091         * DumpRenderTree/win/WorkQueueItem.h: Removed.
4092         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
4093         (jsStringRefToWString):
4094         (LoadItem::invoke):
4095         (ScriptItem::invoke):
4096
4097 2007-09-17  Sam Weinig  <sam@webkit.org>
4098
4099         Reviewed by Adam Roben.
4100
4101         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
4102
4103         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
4104         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
4105         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
4106         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
4107         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
4108         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
4109         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
4110         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
4111         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
4112         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
4113         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
4114         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
4115         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
4116         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
4117         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
4118         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
4119         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
4120         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
4121         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
4122         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
4123         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
4124         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
4125         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
4126         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
4127         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
4128         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
4129         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
4130         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
4131         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
4132         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
4133         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
4134         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
4135         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
4136         * DumpRenderTree/win: Added.
4137         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
4138         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
4139         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
4140         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
4141         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
4142         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
4143         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
4144         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
4145         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
4146         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
4147         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
4148         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
4149         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
4150         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
4151         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
4152         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
4153         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
4154         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
4155         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
4156         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
4157         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
4158         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
4159         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
4160         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
4161         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
4162         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
4163
4164 2007-09-15  Mark Rowe  <mrowe@apple.com>
4165
4166         Build fix for DumpRenderTree.
4167
4168         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
4169
4170 2007-09-14  Sam Weinig  <sam@webkit.org>
4171
4172         Rubber stamped by Adam Roben.
4173
4174         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
4175           - The UIDelegate was put into a new file while the FrameLoadDelegate was
4176             kept in the WaitUntilDoneDelegate file for the time being.
4177
4178         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
4179         (main):
4180         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
4181         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
4182         (UIDelegate::QueryInterface):
4183         (UIDelegate::AddRef):
4184         (UIDelegate::Release):
4185         (UIDelegate::hasCustomMenuImplementation):
4186         (UIDelegate::setFrame):
4187         (UIDelegate::webViewFrame):
4188         (UIDelegate::runJavaScriptAlertPanelWithMessage):
4189         (UIDelegate::webViewAddMessageToConsole):
4190         (UIDelegate::doDragDrop):
4191         (UIDelegate::webViewGetDlgCode):
4192         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
4193         (UIDelegate::UIDelegate):
4194         (UIDelegate::createWebViewWithRequest):
4195         (UIDelegate::webViewShow):
4196         (UIDelegate::webViewClose):
4197         (UIDelegate::webViewFocus):
4198         (UIDelegate::webViewUnfocus):
4199         (UIDelegate::webViewFirstResponder):
4200         (UIDelegate::makeFirstResponder):
4201         (UIDelegate::setStatusText):
4202         (UIDelegate::webViewStatusText):
4203         (UIDelegate::webViewAreToolbarsVisible):
4204         (UIDelegate::setToolbarsVisible):
4205         (UIDelegate::webViewIsStatusBarVisible):
4206         (UIDelegate::setStatusBarVisible):
4207         (UIDelegate::webViewIsResizable):
4208         (UIDelegate::setResizable):
4209         (UIDelegate::setContentRect):
4210         (UIDelegate::webViewContentRect):
4211         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
4212         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
4213         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
4214         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
4215         (UIDelegate::mouseDidMoveOverElement):
4216         (UIDelegate::contextMenuItemsForElement):
4217         (UIDelegate::validateUserInterfaceItem):
4218         (UIDelegate::shouldPerformAction):
4219         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
4220         (UIDelegate::willPerformDragDestinationAction):
4221         (UIDelegate::dragSourceActionMaskForPoint):
4222         (UIDelegate::willPerformDragSourceAction):
4223         (UIDelegate::contextMenuItemSelected):
4224         (UIDelegate::trackCustomPopupMenu):
4225         (UIDelegate::measureCustomMenuItem):
4226         (UIDelegate::drawCustomMenuItem):
4227         (UIDelegate::addCustomMenuDrawingData):
4228         (UIDelegate::cleanUpCustomMenuDrawingData):
4229         (UIDelegate::canTakeFocus):
4230         (UIDelegate::takeFocus):
4231         (UIDelegate::registerUndoWithTarget):
4232         (UIDelegate::removeAllActionsWithTarget):
4233         (UIDelegate::setActionTitle):
4234         (UIDelegate::undo):
4235         (UIDelegate::redo):
4236         (UIDelegate::canUndo):
4237         (UIDelegate::canRedo):
4238         (UIDelegate::webViewResizerRect):
4239         (UIDelegate::webViewDrawResizer):
4240         (UIDelegate::webViewScrolled):
4241         (UIDelegate::webViewShouldInterruptJavaScript):
4242         (UIDelegate::webViewReceivedFocus):
4243         (UIDelegate::webViewLostFocus):
4244       &nb