ca860cc6d38cffebc98b8f77900602dd55fd24e3
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-04  Sam Weinig  <sam@webkit.org>
2
3         Define CF as platform for windows.
4
5         Reviewed by Adam Roben.
6
7         * DumpRenderTree/win/DumpRenderTreeWin.h:
8
9 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
10
11         Reviewed by Adam and Darin.
12
13         - Removed a needless BSTR cleanup.
14
15         * Drosera/win/DebuggerDocumentPlatform.cpp:
16         (DebuggerDocument::getPlatformCurrentFunctionStack):
17
18 2007-11-27  Adam Roben  <aroben@apple.com>
19
20         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
21
22         Reviewed by Maciej.
23
24         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
25         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
26
27 2007-12-04  Alp Toker  <alp@atoker.com>
28
29         Prospective Win DRT build fix.
30
31         * DumpRenderTree/DumpRenderTree.h:
32
33 2007-12-04  Alp Toker  <alp@atoker.com>
34
35         Fix a clobbered copyright header.
36
37         * DumpRenderTree/gtk/DumpRenderTree.cpp:
38
39 2007-12-04  Xan Lopez  <xan@gnome.org>
40
41         Reviewed by Alp Toker.
42
43         http://bugs.webkit.org/show_bug.cgi?id=15561
44         GTK port needs DumpRenderTree implementation
45
46         Start work on the GTK+ DRT.
47
48         This does not work yet, and there are a few lingering style issues
49         (nothing major) but this patch has been stuck in the bug tracker for
50         too long already.
51
52         * DumpRenderTree/DumpRenderTree.h:
53         * DumpRenderTree/gtk: Added.
54         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
55         (autocorrectURL):
56         (shouldLogFrameLoadDelegates):
57         (dumpFrameScrollPosition):
58         (displayWebView):
59         (appendString):
60         (dumpFramesAsText):
61         (dumpRenderTreeAsText):
62         (dump):
63         (runTest):
64         (main):
65         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
66         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
67         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
68         (GCController::collect):
69         (GCController::collectOnAlternateThread):
70         (GCController::getJSObjectCount):
71         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
72         (LayoutTestController::~LayoutTestController):
73         (LayoutTestController::addDisallowedURL):
74         (LayoutTestController::clearBackForwardList):
75         (LayoutTestController::copyDecodedHostName):
76         (LayoutTestController::copyEncodedHostName):
77         (LayoutTestController::display):
78         (LayoutTestController::keepWebHistory):
79         (LayoutTestController::notifyDone):
80         (LayoutTestController::queueBackNavigation):
81         (LayoutTestController::queueForwardNavigation):
82         (LayoutTestController::queueLoad):
83         (LayoutTestController::queueReload):
84         (LayoutTestController::queueScript):
85         (LayoutTestController::setAcceptsEditing):
86         (LayoutTestController::setCustomPolicyDelegate):
87         (LayoutTestController::setMainFrameIsFirstResponder):
88         (LayoutTestController::setTabKeyCyclesThroughElements):
89         (LayoutTestController::setUseDashboardCompatibilityMode):
90         (LayoutTestController::setUserStyleSheetEnabled):
91         (LayoutTestController::setUserStyleSheetLocation):
92         (LayoutTestController::setWindowIsKey):
93         (LayoutTestController::setWaitToDump):
94         (LayoutTestController::windowCount):
95         (LayoutTestController::setPrivateBrowsingEnabled):
96         (LayoutTestController::setAuthorAndUserStylesEnabled):
97         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
98         (JSStringCopyUTF8CString):
99         (LoadItem::invoke):
100         (ReloadItem::invoke):
101         (ScriptItem::invoke):
102         (BackForwardItem::invoke):
103
104 2007-12-03  Sam Weinig  <sam@webkit.org>
105
106         Move JavaScriptCore thread testing code to pthread specific directory
107         and remove the dependance on CoreFoundation by using WTF::HashSet.
108
109         Reviewed by Geoff and Oliver.
110
111         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
112         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
113         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
114         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
115         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
116         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
117         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
118         * DumpRenderTree/pthreads: Added.
119         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
120         (javaScriptThreads):
121         (runJavaScriptThread):
122         (startJavaScriptThreads):
123         (stopJavaScriptThreads):
124
125 2007-12-03  Andrew Bonventre  <andybons@google.com>
126
127         Reviewed by Darin Adler.
128
129         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
130         Symbol lookup menu broken in debugger view
131
132         * Drosera/debugger.js: Fixed javascript error where document property
133         should have been used instead of contentDocument in switchFunction that
134         was breaking the select symbol dropdown menu.  This is because
135         window.frames will return a Window object and not a frame object like
136         the author was originally expecting.
137
138 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
139
140         Reviewed by Adam.
141
142         - <rdar://5618942> Drosera: Console window does not process everything
143         correctly.
144         - <rdar://5619005> Drosera: could be sped up by moving the 
145         WebScriptScope stuff into the WebScriptCallFrame.
146         - Now the console can correctly process objects and does not receive
147         notifications from JavaScriptCore about the JavaScript in Drosera's
148         own process.
149
150         * Drosera/win/DebuggerDocumentPlatform.cpp:
151         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
152         (DebuggerDocument::platformValueForScopeVariableNamed):
153
154 2007-12-03  Stephanie  <slewis@apple.com>
155
156         Reviewed by Darin.
157
158         Check to see if we are building a debug root
159
160         * Scripts/check-for-global-initializers: 
161
162 2007-12-03  Dan Bernstein  <mitz@apple.com>
163
164         Reviewed by Darin Adler.
165
166         - added a testGetIntIdentifier() method to TestNetscapePlugIn
167
168         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
169         (pluginInvoke):
170
171 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
172
173         Reviewed by Oliver.
174
175         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
176         in a more fine-grained manner than eventSender.keyDown().
177
178         * DumpRenderTree/win/EventSender.cpp:
179         (getConstantCallback):
180         (dispatchMessageCallback):
181
182 2007-12-02  Darin Adler  <darin@apple.com>
183
184         * Scripts/do-webcore-rename: More planned renaming.
185
186 2007-12-02  Sam Weinig  <sam@webkit.org>
187
188         Rubber stamped by Anders.
189
190         Use [NSURL absoluteString] instead of [NSURL description] in order to get
191         more uniform results cross platform.
192
193         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
194         (-[NSURL _drt_descriptionSuitableForTestResult]):
195
196 2007-12-02  Sam Weinig  <sam@webkit.org>
197
198         Rubber stamped by Niko.
199
200         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
201
202         * DumpRenderTree/win/DumpRenderTree.cpp:
203         * DumpRenderTree/win/DumpRenderTree.vcproj:
204         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
205         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
206         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
207         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
208
209 2007-12-01  Alp Toker  <alp@atoker.com>
210
211         Reviewed by Adam Roben.
212
213         Make use of the newly introduced webkit.h convenience header.
214
215         * GtkLauncher/main.c:
216
217 2007-12-01  Adam Treat  <treat@kde.org>
218
219         Reviewed by Simon.
220
221         * Check to see if the directory exists and exit if not.
222
223         * DumpRenderTree/qt/main.cpp:
224         (main):
225
226 2007-12-01  Adam Treat  <treat@kde.org>
227
228         Reviewed by Simon.
229
230         * Don't hide symbols when in Debug mode
231         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
232
233
234         * DumpRenderTree/qt/main.cpp:
235         (messageHandler):
236
237 2007-11-30  Alp Toker  <alp@atoker.com>
238
239         Reviewed by Adam Roben.
240
241         http://bugs.webkit.org/show_bug.cgi?id=15691
242         [GTK] Public API does not follow GTK+ conventions
243
244         Refactor the WebKit/GTK+ public API. Changes:
245           WebKitPage -> WebKitWebView
246           WebKitFrame -> WebKitWebFrame
247
248         Public API source and header names have been updated to mirror the API
249         changes.
250
251         The API is now kept in WebKit/gtk/WebView to match other ports in the
252         same class such as Mac and Win.
253
254         * GtkLauncher/main.c:
255         (activate_uri_entry_cb):
256         (link_hover_cb):
257         (title_change_cb):
258         (progress_change_cb):
259         (go_back_cb):
260         (go_forward_cb):
261         (create_browser):
262         (main):
263
264 2007-11-30  Adam Roben  <aroben@apple.com>
265
266         Hopefully the final build fix
267
268         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
269         pull in WTF's assertion/logging functions.
270
271 2007-11-30  Adam Roben  <aroben@apple.com>
272
273         Another build fix
274
275         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
276         WebKit.lib.
277
278 2007-11-30  Adam Roben  <aroben@apple.com>
279
280         Debug build fix
281
282         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
283         configuration.
284         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
285         projects.
286         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
287         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
288         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
289
290 2007-11-30  Sam Weinig  <sam@webkit.org>
291
292         Reviewed by Adam Roben.
293
294         Fix drawSelectionRect to actually draw the selection rect.
295
296         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
297         (drawSelectionRect):
298
299 2007-11-30  Darin Adler  <darin@apple.com>
300
301         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
302
303 2007-11-30  Darin Adler  <darin@apple.com>
304
305         * Scripts/do-webcore-rename: Get ready for some future renaming.
306
307 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
308
309         Reviewed by Adam.
310
311         - Removed some unnecessary functions and changed an unused return type. 
312
313         * Drosera/win/DebuggerClient.cpp:
314         (registerConsoleClass):
315         * Drosera/win/DebuggerClient.h:
316         * Drosera/win/Drosera.cpp:
317         (registerDroseraClass):
318
319 2007-11-28  Alp Toker  <alp@atoker.com>
320
321         Reviewed by Timothy Hatcher.
322
323         http://bugs.webkit.org/show_bug.cgi?id=16174
324         [GTK] Use "URI" not "URL" in public API
325
326         Replace use of the term "URL" with "URI" in public headers,
327         documentation and some internal code to match GLib/GTK+ convention.
328
329         This is now mentioned in the API guidelines:
330           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
331
332         * GtkLauncher/main.c:
333         (activate_uri_entry_cb):
334         (title_change_cb):
335         (create_toolbar):
336         (main):
337
338 2007-11-29  Anders Carlsson  <andersca@apple.com>
339
340         Reviewed by Sam.
341
342         <rdar://problem/5230478>
343         FrameLoadDelegate callbacks are not dumped in DRT.
344         
345         * DumpRenderTree/win/DumpRenderTree.cpp:
346         (shouldLogFrameLoadDelegates):
347         (runTest):
348         (main):
349         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
350         (BSTRtoString):
351         (descriptionSuitableForTestResult):
352         (FrameLoadDelegate::QueryInterface):
353         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
354         (FrameLoadDelegate::didFailProvisionalLoadWithError):
355         (FrameLoadDelegate::didCommitLoadForFrame):
356         (FrameLoadDelegate::didFinishLoadForFrame):
357         (FrameLoadDelegate::willCloseFrame):
358         (FrameLoadDelegate::didClearWindowObject):
359         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
360         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
361         * DumpRenderTree/win/FrameLoaderDelegate.h:
362         (FrameLoadDelegate::windowScriptObjectAvailable):
363         (FrameLoadDelegate::didFirstLayoutInFrame):
364
365 2007-11-29  Sam Weinig  <sam@webkit.org>
366
367         Reviewed by Anders.
368
369         Add database quota UIDelegates methods to DRT UIDelegate.
370
371         * DumpRenderTree/mac/UIDelegate.mm:
372         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
373         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
374
375 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
376
377         Reviewed by Sam.
378
379         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
380         dying and vice versa.
381         - This fix will allow Drosera and Safari to reconnect if either of them
382         closes correctly, but does not fix the case where one of them dies
383         silently.
384
385         * Drosera/win/ServerConnection.cpp:
386         (ServerConnection::attemptToCreateServerConnection): Added a safety
387         check, because it's possilbe to try to connect to a server that's dying.
388         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
389         the server has died.
390         * Drosera/win/ServerConnection.h: Added the new function and removed
391         an unnecessary member.
392
393 2007-11-29  Anders Carlsson  <andersca@apple.com>
394
395         * DumpRenderTree/win/DumpRenderTree.vcproj:
396         Add shlwapi.lib to all configurations.
397
398 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
399
400         - Build fix.  Added additional includes for VS Express to the Release
401         project.
402
403         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
404
405 2007-11-29  Anders Carlsson  <andersca@apple.com>
406
407         Reviewed by Adam.
408
409         <rdar://problem/5132005>
410         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
411         
412         * DumpRenderTree/win/DumpRenderTree.vcproj:
413         Add shlwapi.lib
414         
415         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
416         (LayoutTestController::setUserStyleSheetEnabled):
417         Implement this.
418         
419         (appendComponentToPath):
420         New method which wraps the Win32 API PathAppend.
421         
422         (followShortcuts):
423         New method which checks if a file points to a shortcut and
424         follows the shortcut.
425         
426         (resolveCygwinPath):
427         New method that takes a cygwin unix-style path and returns the Win32 path.
428         
429         (cfStringRefToWString):
430         
431         (LayoutTestController::setUserStyleSheetLocation):
432         Implement this.
433
434 2007-11-29  Alice Liu  <alice.liu@apple.com>
435
436         Reviewed by Adam.
437
438         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
439
440         * DumpRenderTree/win/EventSender.cpp:
441         (keyDownCallback):
442         uppercase letters were being sent as lowercase letters without the shift key down.
443
444 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
445
446         - Windows build fix. VS express needs some love.
447
448         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
449
450 2007-11-28  Darin Adler  <darin@apple.com>
451
452         Reviewed by Adam Roben.
453
454         * DumpRenderTree/mac/EventSendingController.mm:
455         (-[EventSendingController keyDown:withModifiers:]):
456         Send capital letters through as lowercase letters with the shift key down
457         rather than sending them as if they were highly unusual "capital letter keys".
458
459         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
460         where you need to update results and more tests are failing than before.
461
462 2007-11-28  Anders Carlsson  <andersca@apple.com>
463
464         Reviewed by Darin.
465
466         <rdar://problem/5132001>
467         contextClick is not implemented in DRT on Windows.
468         
469         * DumpRenderTree/win/EventSender.cpp:
470         (contextClickCallback):
471         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
472         by a WM_RBUTTONUP message.
473         
474         * DumpRenderTree/win/UIDelegate.cpp:
475         (UIDelegate::hasCustomMenuImplementation):
476         (UIDelegate::trackCustomPopupMenu):
477         * DumpRenderTree/win/UIDelegate.h:
478         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
479         menu from being shown (and causing the DRT to hang).
480
481 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
482
483         Reviewed by Darin.
484
485         Fix DumpRenderTree ObjC bug comparing strings.
486
487         * DumpRenderTree/mac/ObjCController.m:
488         (-[ObjCController identityIsEqual::]): Compare strings with string
489         equality instead of identiy equality.
490
491 2007-11-27  Timothy Hatcher  <timothy@apple.com>
492
493         Reviewed by Sam.
494
495         Reset the authorAndUserStylesEnabled preference
496         back to YES for each test. Fixes the broken tests.
497
498         * DumpRenderTree/mac/DumpRenderTree.mm:
499         (resetWebViewToConsistentStateBeforeTesting):
500
501 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
502
503         Reviewed by Adam.
504
505         - Drosera now displays the console window, although it cannot currently
506         process JavaScript.
507
508         * Drosera/win/DebuggerClient.cpp: Shows the console window.
509         (registerConsoleClass): Implemented.
510         (consoleWndProc): Implemented.
511         (DebuggerClient::onSize): Implemented.
512         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
513         new window.
514         * Drosera/win/DebuggerClient.h: Added needed method and members for 
515         creating and maintaining a new window.
516         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
517         lines of code to more appropriate places.
518         (Drosera::handleCommand):
519         (Drosera::initUI):
520         (Drosera::onSize):
521         (Drosera::attach):
522
523 2007-11-27  Timothy Hatcher  <timothy@apple.com>
524
525         Reviewed by Dave Hyatt.
526
527         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
528         
529         Add support for disabling author and user styles for testing.
530
531         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
532         * DumpRenderTree/LayoutTestController.cpp:
533         (setAuthorAndUserStylesEnabledCallback):
534         (LayoutTestController::staticFunctions):
535         * DumpRenderTree/LayoutTestController.h:
536         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
537         (LayoutTestController::setAuthorAndUserStylesEnabled):
538         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
539         (LayoutTestController::setAuthorAndUserStylesEnabled):
540
541 2007-11-26  Dan Bernstein  <mitz@apple.com>
542
543         - Tiger build fix.
544
545         * DumpRenderTree/mac/Configurations/Base.xcconfig:
546
547 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
548
549         Reviewed by Maciej.
550
551         - Implemented displaying variables for Drosera on Win.
552
553         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
554         that retrieve variables to not hold onto the return value since it's
555         not returned.  Also changed to use the new signatures of the retrieval
556         functions.
557         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
558         (DebuggerDocument::platformValueForScopeVariableNamed):
559         * Drosera/win/Drosera.cpp: Removed a needless TODO.
560         (droseraWndProc):
561
562 2007-11-26  Sam Weinig  <sam@webkit.org>
563
564         Cleanup names of painting and repainting functions.
565
566         Reviewed by Adam Roben.
567
568         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
569         (drawSelectionRect): was drawSelectionRectIntoContext.
570         (dumpWebViewAsPixelsAndCompareWithExpected):
571         * DumpRenderTree/cg/PixelDumpSupportCG.h:
572         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
573         (paintWebView): was drawWebViewIntoContext.
574         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
575
576 2007-11-26  Sam Weinig  <sam@webkit.org>
577
578         Reviewed by Dan Bernstein.
579
580         - Leopard build fix
581
582         * DumpRenderTree/mac/Configurations/Base.xcconfig:
583
584 2007-11-26  Sam Weinig  <sam@webkit.org>
585
586         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
587         Use shared PixelDumpSupport for Mac DRT
588
589         Reviewed by Adam Roben.
590
591         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
592         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
593         * DumpRenderTree/cg/ImageDiffCG.cpp:
594         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
595         (drawSelectionRectIntoContext):
596         (dumpWebViewAsPixelsAndCompareWithExpected):
597         * DumpRenderTree/cg/PixelDumpSupportCG.h:
598         * DumpRenderTree/mac/Configurations/Base.xcconfig:
599         * DumpRenderTree/mac/DumpRenderTree.mm:
600         (dump):
601         * DumpRenderTree/mac/ImageDiff.m: Removed.
602         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
603         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
604         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
605         (setDefaultColorProfileToRGB):
606         (getBitmapContextFromWebView):
607         (drawWebViewIntoContext):
608         (repaintWithVerticalSweep):
609         (repaintWithHorizontalSweep):
610         (getSelectionRect):
611         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
612
613 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
614
615         Bug 16052: prepare-ChangeLog doesn't report deleted files
616         <http://bugs.webkit.org/show_bug.cgi?id=16052>
617
618         Reviewed by Sam.
619
620         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
621
622 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
623
624         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
625         <http://bugs.webkit.org/show_bug.cgi?id=15864>
626
627         Reviewed by Adam.
628
629         Roll functionality of merge-changelog into resolve-ChangeLogs
630         script.  The script now checks for ChangeLog.rej and
631         ChangeLog.orig files first.  If it finds them, it uses the
632         ChangeLog.rej file as a patch (in old contextual diff format) to
633         apply with --fuzz=3.
634
635         * Scripts/merge-changelog: Removed.
636         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
637
638 2007-11-25  Sam Weinig  <sam@webkit.org>
639
640         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
641
642         Reviewed by Mark Rowe.
643
644         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
645         * DumpRenderTree/mac/Configurations/Base.xcconfig:
646         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
647         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
648         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
649
650 2007-11-25  Sam Weinig  <sam@webkit.org>
651
652         Convert DumpRenderTree to ues .xcconfig files.
653
654         Reviewed by Mark Rowe.
655
656         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
657         * DumpRenderTree/mac/Configurations: Added.
658         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
659         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
660         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
661
662 2007-11-25  Sam Weinig  <sam@webkit.org>
663
664         Add ForwardingHeaders to wtf for DumpRenderTree.
665
666         Reviewed by Mark Rowe.
667
668         * DumpRenderTree/DumpRenderTree.h:
669         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
670         * DumpRenderTree/ForwardingHeaders: Added.
671         * DumpRenderTree/ForwardingHeaders/wtf: Added.
672         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
673         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
674         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
675         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
676         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
677         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
678         * DumpRenderTree/LayoutTestController.cpp:
679         * DumpRenderTree/WorkQueue.cpp:
680         * DumpRenderTree/mac/DumpRenderTree.mm:
681         * DumpRenderTree/mac/FrameLoadDelegate.mm:
682         * DumpRenderTree/mac/JavaScriptThreading.cpp:
683         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
684         * DumpRenderTree/mac/ObjCController.m:
685         * DumpRenderTree/mac/UIDelegate.mm:
686         * DumpRenderTree/mac/WorkQueueItemMac.mm:
687
688 2007-11-25  Adam Roben  <aroben@apple.com>
689
690         Fix some test failures caused by r28019
691
692         Now that stdout is in binary mode, we need to always use printf
693         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
694         the output.
695
696         Reviewed by Sam.
697
698         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
699         printf.
700         (UIDelegate::runJavaScriptAlertPanelWithMessage):
701         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
702         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
703         (UIDelegate::webViewAddMessageToConsole):
704
705 2007-11-25  Adam Roben  <aroben@apple.com>
706
707         Set the font smoothing preference in DRT
708
709         This makes the pixel results on Windows closer to the Mac results.
710
711         Reviewed by Mitz.
712
713         * DumpRenderTree/win/DumpRenderTree.cpp:
714         (initializePreferences):
715
716 2007-11-25  Adam Roben  <aroben@apple.com>
717
718         Port ImageDiff to CG and C++
719
720         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
721         <rdar://5071708>
722
723         Reviewed by Sam.
724
725         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
726         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
727         (main):
728         (createImageFromStdin):
729         (compareImages):
730         (getDifferenceBitmap):
731         (computePercentageDifferent):
732         * DumpRenderTree/win/ImageDiff.vcproj: Added.
733
734 2007-11-25  Adam Roben  <aroben@apple.com>
735
736         Fix image diff link generation on Windows
737
738         Reviewed by Sam.
739
740         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
741         to toURL.
742
743 2007-11-25  Adam Roben  <aroben@apple.com>
744
745         Implement pixel dumping in Windows DRT
746
747         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
748         <rdar://5071708>
749
750         Reviewed by Sam.
751
752         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
753         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
754         Content-Length header.
755         (getMD5HashStringForBitmap):
756         (dumpWebViewAsPixelsAndCompareWithExpected):
757         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
758         * DumpRenderTree/win/DumpRenderTree.cpp:
759         (dump): Do a pixel dump if requested.
760         (main): Parse pixel test options.
761         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
762         the cg/ subdirectory to the include path.
763         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
764         available in a header or import library, so we have to go through this
765         LoadLibrary/GetProcAddress dance to use them.
766         (cryptDLL):
767         (init):
768         (update):
769         (final):
770         (MD5_Init):
771         (MD5_Update):
772         (MD5_Final):
773         * DumpRenderTree/win/MD5.h: Added.
774         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
775         moved up to the top level to share it with Mac eventually.
776         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
777         (getBitmapContextFromWebView): Forces the WebView to paint using a
778         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
779
780 2007-11-25  Adam Roben  <aroben@apple.com>
781
782         Clean up Windows DRT's option parsing a little bit
783
784         Reviewed by Sam.
785
786         * DumpRenderTree/win/DumpRenderTree.cpp:
787         (main): Put non-option arguments into a Vector.
788
789 2007-11-25  Adam Roben  <aroben@apple.com>
790
791         Make Windows DRT stop changing LF into CRLF
792
793         Reviewed by Sam.
794
795         * DumpRenderTree/win/DumpRenderTree.cpp:
796         (main): Put stdout in binary mode.
797         * Scripts/run-webkit-tests: Remove the CRLF hack.
798
799 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
800
801         Removed empty directory.
802
803         * Scripts/resources: Removed.
804
805 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
806
807         Fix bisect-builds to work with recent WebKit nightly builds.
808
809         Reviewed by Dan.
810
811         * Scripts/bisect-builds: Check for the 
812         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
813         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
814         to WebKit.app/Contents/Resources.
815
816 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
817
818         Reviewed by Maciej.
819
820         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
821         not closed (affects digg.com)
822
823         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
824         one after finishing with a test to avoid having its delayed onload handler firing when
825         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
826         but it helps somewhat.
827
828 2007-11-22  Mark Rowe  <mrowe@apple.com>
829
830         Reviewed by Alp Toker.
831
832         Fix build-webkit to propagate make's exit status if it fails.
833
834         * Scripts/webkitdirs.pm:
835
836 2007-11-22  Dan Bernstein  <mitz@apple.com>
837
838         Reviewed by Mark Rowe.
839
840         - fix crash when running pixel tests
841
842         * DumpRenderTree/mac/DumpRenderTree.mm:
843         (dumpRenderTree): Parse the command line options before setting up the
844         environment so that we know if we need to set up the pixel dump
845         machinery.
846
847 2007-11-21  Eric Seidel  <eric@webkit.org>
848
849         Speculative build fix for Tiger.
850
851         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
852
853 2007-11-21  Eric Seidel  <eric@webkit.org>
854
855         Reviewed by Tim Hatcher.
856
857         Break out more of DumpRenderTree.mm into individual files
858
859         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
860         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
861         (checkedMalloc):
862         (checkedRealloc):
863         (makeLargeMallocFailSilently):
864         * DumpRenderTree/mac/CheckedMalloc.h: Added.
865         * DumpRenderTree/mac/DumpRenderTree.mm:
866         (crashHandler):
867         (dump):
868         * DumpRenderTree/mac/DumpRenderTreeMac.h:
869         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
870         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
871         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
872         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
873         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
874         (javaScriptThreads):
875         (runJavaScriptThread):
876         (startJavaScriptThreads):
877         (stopJavaScriptThreads):
878         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
879         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
880         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
881         (restoreColorSpace):
882         (setDefaultColorProfileToRGB):
883         (initializeColorSpaceAndScreeBufferForPixelTests):
884         (md5HashStringForBitmap):
885         (dumpWebViewAsPixelsAndCompareWithExpected):
886
887 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
888
889         Move install-unix-extras to wx directory as it seems only to be used by that 
890         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
891         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
892         have install-unix-extras install into WebKitLibraries as per
893         convention.
894         
895         Reviewed by Mark Rowe.
896
897         * Scripts/install-unix-extras: Removed.
898         * wx/build-wxwebkit:
899         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
900
901 2007-11-21  Eric Seidel  <eric@webkit.org>
902
903         Reviewed by Adam.
904
905         More refactoring for greater code readability
906
907         * DumpRenderTree/mac/DumpRenderTree.mm:
908         (initializeGlobalsFromCommandLineOptions):
909         (initializeColorSpaceAndScreeBufferForPixelTests):
910         (addTestPluginsToPluginSearchPath):
911         (useLongRunningServerMode):
912         (runTestingServerLoop):
913         (prepareConsistentTestingEnvironment):
914         (dumpRenderTree):
915         (main):
916         (dumpFramesAsText):
917         (dumpBackForwardListForWebView):
918         (sizeWebViewForCurrentTest):
919         (methodNameStringForFailedTest):
920         (dumpBackForwardListForAllWindows):
921         (dumpWebViewAsPixelsAndCompareWithExpected):
922         (invalidateAnyPreviousWaitToDumpWatchdog):
923         (dump):
924         * DumpRenderTree/mac/DumpRenderTreeMac.h:
925         * DumpRenderTree/mac/UIDelegate.mm:
926         (-[UIDelegate webView:createWebViewWithRequest:]):
927
928 2007-11-21  Eric Seidel  <eric@webkit.org>
929
930         Reviewed by Tim Hatcher.
931
932         Abstract more of DRT into static methods
933
934         * DumpRenderTree/mac/DumpRenderTree.mm:
935         (setDefaultsToConsistentValuesForTesting):
936         (setupSignalHandlers):
937         (allocateGlobalControllers):
938         (releaseAndZero):
939         (releaseGlobalControllers):
940         (dumpRenderTree):
941         (shouldLogFrameLoadDelegates):
942         (createCFURLFromPathOrURL):
943         (resetWebViewToConsistentStateBeforeTesting):
944         (runTest):
945
946 2007-11-21  Eric Seidel  <eric@webkit.org>
947
948         Reviewed by Tim Hatcher.
949
950         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
951
952         * DumpRenderTree/DumpRenderTree.h:
953         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
954         * DumpRenderTree/mac/DumpRenderTree.mm:
955         (dumpRenderTree):
956         (dump):
957         (runTest):
958         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
959         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
960         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
961         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
962         (-[DumpRenderTreePasteboard declareType:owner:]):
963         (+[LocalPasteboard alloc]):
964         (-[LocalPasteboard init]):
965         (-[LocalPasteboard dealloc]):
966         (-[LocalPasteboard name]):
967         (-[LocalPasteboard releaseGlobally]):
968         (-[LocalPasteboard declareTypes:owner:]):
969         (-[LocalPasteboard addTypes:owner:]):
970         (-[LocalPasteboard changeCount]):
971         (-[LocalPasteboard types]):
972         (-[LocalPasteboard availableTypeFromArray:]):
973         (-[LocalPasteboard setData:forType:]):
974         (-[LocalPasteboard dataForType:]):
975         (-[LocalPasteboard setPropertyList:forType:]):
976         (-[LocalPasteboard setString:forType:]):
977         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
978         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
979         (+[DumpRenderTreeWindow allWindows]):
980         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
981         (-[DumpRenderTreeWindow dealloc]):
982         (-[DumpRenderTreeWindow isKeyWindow]):
983         (-[DumpRenderTreeWindow keyDown:]):
984
985 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
986
987         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
988         it indiscriminately copies any headers inside JavaScriptCore,
989         which includes Tiger ICU headers. 
990
991         * wx/build-wxwebkit:
992         Don't run WebCore/move-js-headers.sh any longer.
993
994 2007-11-20  Adam Treat  <treat@kde.org>
995
996         Reviewed by David Kilzer.
997
998         * Prepend git branch name to $baseProductDir
999
1000         * Scripts/VCSUtils.pm:
1001         * Scripts/webkitdirs.pm:
1002
1003 2007-11-20  Mark Rowe  <mrowe@apple.com>
1004
1005         Reviewed by Simon Hausmann.
1006
1007         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1008         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1009         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1010         built product and generated Makefile's are removed.
1011
1012 2007-11-19  Alp Toker  <alp@atoker.com>
1013
1014         Reviewed by Mark Rowe.
1015
1016         http://bugs.webkit.org/show_bug.cgi?id=16040
1017         [GTK] GtkLauncher should be written in C
1018
1019         Port GtkLauncher to plain C.
1020
1021         Use a more conventional GTK+ coding style.
1022
1023         Use a toolbar instead of menus.
1024
1025         Various signature fixes and cleanups.
1026
1027         Add a license header. Assume all previous modifications were copyright
1028         assigned to Apple Inc. by default.
1029
1030         * GtkLauncher/GtkLauncher.pro:
1031         * GtkLauncher/main.c: Added.
1032         (activate_url_entry_cb):
1033         (update_title):
1034         (link_hover_cb):
1035         (title_change_cb):
1036         (progress_change_cb):
1037         (destroy_cb):
1038         (go_back_cb):
1039         (go_forward_cb):
1040         (create_browser):
1041         (create_statusbar):
1042         (create_toolbar):
1043         (create_window):
1044         (main):
1045         * GtkLauncher/main.cpp: Removed.
1046
1047 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1048
1049         Build script fixes to ensure they do the right thing for the 
1050         wx port, and update build-wxwebkit to reflect the way the
1051         build scripts now work.
1052
1053         Reviewed by Adam.
1054
1055         * Scripts/build-testkjs:
1056         * Scripts/build-webkit:
1057         * Scripts/run-javascriptcore-tests:
1058         * Scripts/webkitdirs.pm:
1059         * wx/build-wxwebkit:
1060
1061 2007-11-18  Eric Seidel  <eric@webkit.org>
1062
1063         Reviewed by Anders.
1064
1065         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1066
1067         * Scripts/run-javascriptcore-tests:
1068
1069 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1070
1071         Reviewed by Adam Roben.
1072
1073         Make run-webkit-tests work with Windows debug build.
1074
1075         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1076         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1077         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1078         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1079         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1080
1081 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1082
1083         Add wxWebKit sample and build script, and integrate it with 
1084         build-webkit. Also make build-webkit --clean work for all
1085         ports.
1086
1087         Reviewed by Darin Adler.
1088
1089         * Scripts/build-webkit:
1090         * Scripts/webkitdirs.pm:
1091         * wx: Added.
1092         * wx/browser: Added.
1093         * wx/browser/browser.bkl: Added.
1094         * wx/browser/browser.cpp: Added.
1095         * wx/build-wxwebkit: Added.
1096
1097 2007-11-17  Adam Roben  <aroben@apple.com>
1098
1099         Make it easy to run Safari in the debugger on Windows
1100
1101         I've added a new script, debug-safari, which launches Safari in the
1102         debugger. On OS X it just calls gdb-safari.
1103
1104         Reviewed by Mark Rowe.
1105
1106         * FindSafari/FindSafari.cpp:
1107         (_tmain): Added a /debugger flag, which in combination with
1108         /printSafariLauncher will print a script that launches Safari in the
1109         debugger.
1110         * Scripts/debug-safari: Added.
1111         * Scripts/run-safari: Changed to call runSafari().
1112         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1113         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1114         first argument along to FindSafari.
1115         * Scripts/webkitdirs.pm:
1116         (sub runSafari): Added.
1117
1118 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1119
1120         Reviewed by Adam Roben.
1121
1122         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1123
1124 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1125
1126         Reviewed by David Kilzer.
1127
1128         The git config command was renamed to repo-config at some point. This
1129         change tries git config and then git repo-config if the first fails.
1130
1131         * Scripts/prepare-ChangeLog:
1132         (gitConfig):
1133
1134 2007-11-16  Dan Bernstein  <mitz@apple.com>
1135
1136         Reviewed by Darin Adler and Sam Weinig.
1137
1138         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1139
1140         * DumpRenderTree/win/EventSender.cpp:
1141         (keyDownCallback): For characters that cannot be entered on the active
1142         keyboard layout, send a WM_CHAR message with the character along with
1143         a WM_KEYDOWN message with a virtual key code of 255.
1144
1145 2007-11-16  Mark Rowe  <mrowe@apple.com>
1146
1147         Reviewed by Tim Hatcher.
1148
1149         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1150
1151         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1152         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1153
1154 2007-11-15  Adam Roben  <aroben@apple.com>
1155
1156         Make run-safari actually work on Windows
1157
1158         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1159         chdir call.
1160
1161 2007-11-14  Adam Roben  <aroben@apple.com>
1162
1163         Updates to Safari launching now that 3.0.4 is released
1164
1165         Reviewed by Sam.
1166
1167         * FindSafari/FindSafari.cpp:
1168         (getWebViewCLSID): Use version-independent ProgID.
1169         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1170
1171 2007-11-14  Anders Carlsson  <andersca@apple.com>
1172
1173         Reviewed by Adam.
1174
1175         <rdar://problem/5309081>
1176         In DRT, "plugin.logDestroy = true" not working on Windows.
1177         
1178         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1179         (NPP_Destroy):
1180
1181 2007-11-14  Eric Seidel  <eric@webkit.org>
1182
1183         Reviewed by Sam.
1184
1185         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1186
1187 2007-11-14  Anders Carlsson  <andersca@apple.com>
1188
1189         Reviewed by Adam.
1190
1191         <rdar://problem/5141186>
1192         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1193         
1194         Implement setWindowIsKey.
1195         
1196         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1197         (LayoutTestController::setWindowIsKey):
1198
1199 2007-11-13  Sam Weinig  <sam@webkit.org>
1200
1201         Reviewed by Adam Roben.
1202
1203         Fix for <rdar://problem/5382579>
1204         http/tests/security/cross-frame-access-put.html reports large 
1205         negative numbers for screenLeft and screenTop (Mac reports "0")
1206
1207         * DumpRenderTree/win/UIDelegate.cpp:
1208         (UIDelegate::UIDelegate): Initialize the RECT.
1209         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1210         (UIDelegate::webViewFrame): ditto.
1211         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1212
1213 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1214
1215         Reviewed by Adam.
1216
1217         - Make Drosera show source, source URLs, and function stack on Windows,
1218         and some minor fixes.
1219
1220         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1221         (DebuggerDocument::updateFileSource):
1222         * Drosera/debugger.js: Force source to always update display.
1223         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1224         menu controls.
1225         (DebuggerClient::resume):
1226         (DebuggerClient::pause):
1227         (DebuggerClient::stepInto):
1228         (DebuggerClient::stepOver):
1229         (DebuggerClient::stepOut):
1230         (DebuggerClient::showConsole):
1231         (DebuggerClient::closeCurrentFile):
1232         * Drosera/win/DebuggerClient.h: Ditto.
1233         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1234         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1235         removed two bugs.  1) caller could be in a bad state when asked to
1236         assign into it. 2) BSTRs were not created correctly.
1237         (DebuggerDocument::getPlatformCurrentFunctionStack):
1238         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1239         (droseraWndProc):
1240         (handleCommand):
1241         (Drosera::resume):
1242         (Drosera::pause):
1243         (Drosera::stepInto):
1244         (Drosera::stepOver):
1245         (Drosera::stepOut):
1246         (Drosera::showConsole):
1247         (Drosera::closeCurrentFile):
1248         * Drosera/win/Drosera.h: Hook up the menu controls.
1249         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1250         functions, added a null check, and fixed another bug where caller could
1251         be in a bad state when asked to assign into it.
1252         (ServerConnection::didLoadMainResourceForDataSource):
1253         (ServerConnection::getCallerFrame):
1254         * Drosera/win/ServerConnection.h: Safety first.
1255
1256 2007-11-13  Dan Bernstein  <mitz@apple.com>
1257
1258         Reviewed by Darin Adler.
1259
1260         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1261           DumpRenderTree --pixel-tests renders each test twice
1262
1263         * DumpRenderTree/mac/DumpRenderTree.mm:
1264         (dumpRenderTree): Removed the --paint option because the painting code
1265         is always exercised as a result of
1266         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1267         calling -displayIfNeeded.
1268         (dump): Changed to always grab the image from the window since the view
1269         is always displayed.
1270         (runTest):
1271         (displayWebView):
1272         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1273         because it always paints.
1274
1275 2007-11-12  Antti Koivisto  <antti@apple.com>
1276
1277         Reviewed by Adele.
1278         
1279         Add support for http media tests
1280
1281         * Scripts/run-webkit-tests:
1282
1283 2007-11-12  Sam Weinig  <sam@webkit.org>
1284
1285         Reviewed by Adam Roben.
1286
1287         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1288
1289         * DumpRenderTree/win/DumpRenderTree.cpp:
1290         (runTest):
1291         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1292         (LayoutTestController::setPrivateBrowsingEnabled):
1293
1294 2007-11-12  Adam Roben  <aroben@apple.com>
1295
1296         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1297         mac and win subdirectories.
1298
1299 2007-11-11  Adam Roben  <aroben@apple.com>
1300
1301         Fix <rdar://5133816> keepWebHistory is not implemented
1302
1303         Fixes fast/history/clicked-link-is-visited.html.
1304
1305         Reviewed by Darin.
1306
1307         * DumpRenderTree/win/DumpRenderTree.cpp:
1308         (runTest): Clear the optionalSharedHistory.
1309         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1310         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1311
1312 2007-11-10  Sam Weinig  <sam@webkit.org>
1313
1314         Reviewed by Tim Hatcher.
1315
1316         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1317         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1318         is turned on)
1319
1320         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1321
1322         Added test: http/tests/security/cross-frame-access-private-browsing.html
1323
1324         * DumpRenderTree/LayoutTestController.cpp:
1325         (setPrivateBrowsingEnabledCallback):
1326         (LayoutTestController::staticFunctions):
1327         * DumpRenderTree/LayoutTestController.h:
1328         * DumpRenderTree/mac/DumpRenderTree.mm:
1329         (runTest): Default to private browsing disabled.
1330         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1331         (LayoutTestController::setPrivateBrowsingEnabled):
1332         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1333         (LayoutTestController::setPrivateBrowsingEnabled):
1334
1335 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1336
1337         Reviewed by Adam.
1338
1339         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1340         WebCore's!
1341
1342         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1343         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1344         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1345         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1346         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1347         * Drosera/win/Drosera.cpp:
1348         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1349
1350 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1351
1352         Reviewed by Sam.
1353
1354         - Use the new IWebFrame [local] function signature and get the shared
1355         server correctly.
1356
1357         * Drosera/win/DebuggerClient.cpp:
1358         (DebuggerClient::didFinishLoadForFrame):
1359         * Drosera/win/ServerConnection.cpp:
1360         (ServerConnection::attemptToCreateServerConnection):
1361
1362 2007-11-07  Dan Bernstein  <mitz@apple.com>
1363
1364         Reviewed by Darin Adler.
1365
1366         - add an option to run-webkit-tests to ignore pixel test failures where
1367           all pixels differ by no more than a specified threshold
1368
1369         * DumpRenderTree/mac/ImageDiff.m:
1370         (main):
1371         (compareImages):
1372         (computePercentageDifferent):
1373         * Scripts/run-webkit-tests:
1374
1375 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1376
1377         Reviewed by Lars.
1378
1379         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1380
1381         * DumpRenderTree/qt/DumpRenderTree.cpp:
1382
1383 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1384
1385         Reviewed by Lars.
1386
1387         Reworked the QWebSettings API.
1388         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1389
1390         * DumpRenderTree/qt/DumpRenderTree.cpp:
1391
1392 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1393
1394         Reviewed by Lars.
1395
1396         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1397
1398         * DumpRenderTree/qt/jsobjects.cpp:
1399
1400 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1401
1402         Reviewed by Lars Knoll <lars@trolltech.com>.
1403
1404         Add a QWebPage::frameCreated() signal and fix DRT
1405         
1406         The removal of createFrame in QWebPage broke the re-implementation
1407         in DumpRenderTree. Instead emit a frameCreated() signal and
1408         connect to it in DumpRenderTree.
1409         
1410
1411         * DumpRenderTree/qt/DumpRenderTree.cpp:
1412         (WebCore::WebPage::WebPage):
1413         (WebCore::DumpRenderTree::dump):
1414         (WebCore::DumpRenderTree::connectFrame):
1415         * DumpRenderTree/qt/DumpRenderTree.h:
1416
1417 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1418
1419         Reviewed by Lars Knoll <lars@trolltech.com>.
1420
1421         Moved all the event handlers from QWebFrame into QWebPage.
1422         
1423         This cleans up the public API and allows us to remove the
1424         HackWebFrame hack in DumpRenderTree.
1425         
1426
1427         * DumpRenderTree/qt/jsobjects.cpp:
1428         (EventSender::mouseDown):
1429         (EventSender::mouseUp):
1430         (EventSender::mouseMoveTo):
1431
1432 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1433
1434         Reviewed by Mark.
1435
1436         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1437         to prevent the default implementation from popping up messageboxes.
1438
1439         * DumpRenderTree/qt/DumpRenderTree.cpp:
1440         (WebCore::WebPage::javaScriptConfirm):
1441         (WebCore::WebPage::javaScriptPrompt):
1442
1443 2007-11-06  Eric Seidel  <eric@webkit.org>
1444
1445         * Scripts/build-testkjs: build fix... too many $$
1446
1447 2007-11-06  Eric Seidel  <eric@webkit.org>
1448
1449         Reviewed by Mark Rowe.
1450
1451         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1452
1453 2007-11-05  Adam Roben  <aroben@apple.com>
1454
1455         Add support on Windows for WEBKIT_TESTFONTS
1456
1457         This environment variable lets you specify where the fonts to be used
1458         by DumpRenderTree reside. The Qt port is already using this, so I'm
1459         just following their lead.
1460
1461         Reviewed by Darin.
1462
1463         * DumpRenderTree/win/DumpRenderTree.cpp:
1464         (exePath): Refactored code out of initialize().
1465         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1466         DumpRenderTree.resources.
1467         (initialize): Use the new fontsPath function.
1468         (main): Use the new exePath function.
1469         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1470         variable to DRT, like Qt does.
1471
1472 2007-11-05  Mark Rowe  <mrowe@apple.com>
1473
1474         Rubber-stamped by Alp Toker.
1475
1476         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1477
1478         * GtkLauncher/main.cpp:
1479         (goToURLBarText):
1480         (main):
1481
1482 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1483
1484         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1485         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1486
1487         Reviewed by Timothy.
1488
1489         Restrict the range of nightly builds used by the bisect-builds script
1490         based on the version of Safari and the version of Mac OS X being used.
1491
1492         Mac OS X 10.4: Safari 2.0: r11976 or newer
1493         Mac OS X 10.4: Safari 3.0: r19992 or newer
1494
1495         Mac OS X 10.5: Safari 2.0: r19594 or newer
1496         Mac OS X 10.5: Safari 3.0: r25124 or newer
1497
1498         * Scripts/bisect-builds:
1499         (findMacOSXVersion): Added.
1500         (makeNightlyList): Added argument to provide version of Mac OS X.
1501         Restrict range of nightly builds based on Safari and Mac OS X versions.
1502
1503 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1504
1505         Reviewed by Maciej.
1506
1507         - This patch involves several changes, all of them were noticed that
1508         they were needed by the work being done in WebKit to get Drosera and
1509         WebKit working together on Windows.
1510         - The changes are:
1511         1) Added a debugger console for output messages.
1512         2) Drosera now listens for the WebKit server (before, the server would
1513         have to be running before Drosera was started.)
1514         3) Fixed a bug where the WebView started out as 0x0 pixels.
1515         4) Fixed a bug when there is no scope.
1516         5) Added the HTML, JS, and CSS to the project file to make them easy to
1517         find.
1518         6) Made the ServerConnection functions virtual.
1519
1520         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1521         for the WebKit server.
1522         (DebuggerClient::DebuggerClient):
1523         (DebuggerClient::~DebuggerClient):
1524         (DebuggerClient::didFinishLoadForFrame):
1525         (DebuggerClient::serverConnected):
1526         (DebuggerClient::attemptToCreateServerConnection):
1527         * Drosera/win/DebuggerClient.h: Ditto.
1528         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1529         scope.
1530         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1531         (DebuggerDocument::platformValueForScopeVariableNamed):
1532         * Drosera/win/Drosera.cpp:
1533         (_tWinMain): Added a console in debug for output messages.
1534         (Drosera::Drosera): Listen for server.
1535         (Drosera::initUI): The server now Initializes COM.
1536         (Drosera::serverConnected): Part of the listening for the server.
1537         (Drosera::attemptToCreateServerConnection): Ditto.
1538         * Drosera/win/Drosera.h: New interface for listening for the server.
1539         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1540         files to the VS project.
1541         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1542         connection.
1543         (ServerConnection::ServerConnection):
1544         (ServerConnection::attemptToCreateServerConnection):
1545         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1546         methods.
1547         (ServerConnection::serverConnected):
1548
1549 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1550
1551         Reviewed by Maciej.
1552
1553         http://bugs.webkit.org/show_bug.cgi?id=15832
1554         fast/dom/gc-10.html crashes when run alone
1555
1556         Check for !done before using objects that can be already deallocated.
1557
1558         * DumpRenderTree/mac/EditingDelegate.mm:
1559         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1560         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1561         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1562         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1563         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1564         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1565         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1566         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1567         (-[EditingDelegate webViewDidBeginEditing:]):
1568         (-[EditingDelegate webViewDidChange:]):
1569         (-[EditingDelegate webViewDidEndEditing:]):
1570         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1571         (-[EditingDelegate webViewDidChangeSelection:]):
1572         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1573         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1574         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1575         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1576         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1577         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1578         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1579         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1580         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1581         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1582         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1583         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1584         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1585         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1586         (-[FrameLoadDelegate webView:willCloseFrame:]):
1587         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1588         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1589         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1590         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1591         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1592         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1593         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1594         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1595         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1596
1597 2007-11-04  Mark Rowe  <mrowe@apple.com>
1598
1599         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1600         warnings that would otherwise be suppressed due to it being a system header.
1601
1602         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1603
1604 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1605
1606         Rubber stamped by Adam.
1607         
1608         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1609
1610         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1611
1612 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1613
1614         Sort files(...); sections of Xcode project files.
1615
1616         Rubber-stamped by Darin.
1617
1618         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1619         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1620         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1621         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1622
1623 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1624
1625         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1626
1627         Reviewed by Darin.
1628
1629         * Scripts/sort-Xcode-project-file: Added.
1630
1631 2007-11-02  Darin Adler  <darin@apple.com>
1632
1633         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1634
1635 2007-11-02  Darin Adler  <darin@apple.com>
1636
1637         Reviewed by Maciej.
1638
1639         * Scripts/run-sunspider: Pass the "--base" option through.
1640
1641         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1642         the real script do that. Default configuration to Release to match run-sunspider
1643         so we don't end up building Debug just to compare results.
1644
1645 2007-11-01  Adam Roben  <aroben@apple.com>
1646
1647         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1648
1649         Reviewed by Sam.
1650
1651         * Scripts/commit-log-editor: Show all the directories beneath the
1652         source root, instead of just the last one.
1653
1654 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1655
1656         Reviewed by Adam Roben.
1657
1658         Print out an error message when the Windows build fails
1659         and provide guidance on how to find out what went wrong.
1660
1661         * Scripts/build-webkit:
1662         * Scripts/webkitdirs.pm:
1663
1664 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1665
1666         Rubber-stamped by Adam Roben.
1667
1668         Rolled out r27326 - debug CRT seems to cause no problems after all.
1669
1670         * DumpRenderTree/win/DumpRenderTree.vcproj:
1671
1672 2007-10-31  Adam Roben  <aroben@apple.com>
1673
1674         Switch the Debug configuration to using the non-debug CRT
1675
1676         This matches WebKit.
1677
1678         Reviewed by Steve.
1679
1680         * DumpRenderTree/win/DumpRenderTree.vcproj:
1681
1682 2007-10-31  Antti Koivisto  <antti@apple.com>
1683
1684         Reviewed by bdash.
1685         
1686         Disable media tests when doing leak checking on Tiger.
1687         They crash in QuickTime (rdar://problem/5537157).
1688
1689         * Scripts/run-webkit-tests:
1690
1691 2007-10-29  Antti Koivisto  <antti@apple.com>
1692
1693         Reviewed by Maciej.
1694         
1695         Build media support by default on OSX only.
1696
1697         * Scripts/build-webkit:
1698
1699 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1700
1701         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1702         get caught by the pre-commit hooks.
1703
1704 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1705
1706         Reviewed by Adam.
1707
1708         - This is a collection of relatively unrelated changes and cleanups
1709         to Drosera to prepare it for interacting with WebKit.  A lot of these
1710         changes are just correcting mistakes, for example removing included
1711         headers that are no longer needed.
1712
1713         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1714         this will be needed by the DebuggerClient.
1715         (DebuggerDocument::server):
1716         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1717         * Drosera/win/DebuggerClient.cpp: 
1718         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1719         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1720         (DebuggerClient::createWebViewWithRequest): Added comment about its
1721         purpose. 
1722         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1723         declarations.
1724         (DebuggerClient::webViewLoaded): Moved.
1725         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1726         file, since this was the only place it was used.
1727         (cfStringToBSTR):
1728         * Drosera/win/Drosera.h: Cleaned up the includes.
1729         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1730         * Drosera/win/HelperFunctions.h: Removed.
1731
1732 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1733
1734         Reviewed by Adam.
1735
1736         - Small cleanup in the ServerConnection class.
1737
1738         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1739         and added an include.
1740         (ServerConnection::currentFrame):
1741         (ServerConnection::getCallerFrame):
1742         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1743         made a pointer into a COMPtr, and cleaned up the includes.
1744
1745 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1746
1747         Reviewed by John Sullivan.
1748         
1749         - Place the Localizable.strings file in mac or win directories
1750           if that location exists.
1751         - Also look for UI_STRING in .c files.
1752
1753         * Scripts/extract-localizable-strings:
1754
1755 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1756
1757         Reviewed by Adam.
1758
1759         - Set the eol-style to native and made all the line endings the same
1760         so that I avoid messy diffs that show eol changes.
1761
1762         * Drosera/win/ServerConnection.cpp:
1763         (ServerConnection::didParseSource):
1764         (ServerConnection::didEnterCallFrame):
1765         (ServerConnection::willExecuteStatement):
1766         (ServerConnection::willLeaveCallFrame):
1767         (ServerConnection::exceptionWasRaised):
1768
1769 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1770
1771         Reviewed by Adam.
1772
1773         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1774         functionality that could not have existed previously without the new
1775         interfaces.
1776         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1777         from a BSTR to a JSValueRef.
1778         (DebuggerDocument::platformEvaluateScript): Implemented.
1779         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1780         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1781         Implemented.
1782         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1783         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1784         * Drosera/win/ServerConnection.cpp: Added a helper function.
1785         (ServerConnection::getCallerFrame):
1786         * Drosera/win/ServerConnection.h: Added a helper function.
1787
1788 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1789
1790         updated reviewers for my previous changelog.
1791
1792 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1793         Reviewed by Maciej and Adam and Geoff.
1794
1795         - Minor mac-side improvements including moving a function to a more
1796         appropriate location, fixing a warning, and correctly checking
1797         exceptions.
1798
1799         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1800         (DebuggerDocument::willExecuteStatement):
1801         (DebuggerDocument::didEnterCallFrame):
1802         (DebuggerDocument::willLeaveCallFrame):
1803         (DebuggerDocument::windowScriptObjectAvailable):
1804         (DebuggerDocument::callFunctionOnObject):
1805         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1806         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1807         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1808         because it doesn't require the ServerConnection at all.
1809         (NSStringCreateWithJSStringRef): Made an argument const.
1810         (JSValueRefCreateWithNSString): Made an argument const.
1811         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1812         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1813         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1814         * Drosera/mac/ServerConnection.mm: Ditto.
1815         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1816
1817 2007-10-29  Sam Weinig  <sam@webkit.org>
1818
1819         Reviewed by Adam Roben.
1820
1821         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1822
1823         * DumpRenderTree/LayoutTestController.cpp:
1824         (LayoutTestController::LayoutTestController):
1825         (getGlobalFlagCallback):
1826         (setGlobalFlagCallback):
1827         (LayoutTestController::getJSClass):
1828         (LayoutTestController::staticValues):
1829         * DumpRenderTree/LayoutTestController.h:
1830         (LayoutTestController::globalFlag):
1831         (LayoutTestController::setGlobalFlag):
1832
1833 2007-10-29  Darin Adler  <darin@apple.com>
1834
1835         Reviewed by Maciej.
1836
1837         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1838         resolution instead of its default.
1839
1840 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1841
1842         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1843
1844         Reviewed by Mark Rowe.
1845
1846         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1847         was successfully resolved, but this would not show any status because the change had
1848         already been cached in the index using "git add".  The solution is to add an optional
1849         second argument to showStatus() which adds the "--cached" switch to the command.
1850
1851         * Scripts/resolve-ChangeLogs:
1852         (showStatus):
1853
1854 2007-10-28  Eric Seidel  <eric@webkit.org>
1855
1856         Reviewed by Maciej and Geoff, in unison.
1857
1858         * Scripts/run-webkit-tests: remove broken --svg option
1859
1860 2007-10-28  Darin Adler  <darin@apple.com>
1861
1862         Reviewed by Adam.
1863
1864         * Scripts/run-sunspider: Default to "Release" configuration rather than
1865         defaulting to the last configuration used as other scripts do. This can
1866         still be overriden on the command line with "--debug" if there's some
1867         reason to do so. Also fix a typo.
1868
1869         * Scripts/sunspider-compare-results: Fix a typo.
1870
1871 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1872
1873         Reviewed by Adam.
1874
1875         - Implemented the WebScriptDebugListener functions now that the
1876         WebScriptDebugServer exists
1877
1878         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1879         functions.
1880         (ServerConnection::currentFrame):
1881         (ServerConnection::didLoadMainResourceForDataSource):
1882         (ServerConnection::didParseSource):
1883         (ServerConnection::failedToParseSource):
1884         (ServerConnection::didEnterCallFrame):
1885         (ServerConnection::willExecuteStatement):
1886         (ServerConnection::willLeaveCallFrame):
1887         (ServerConnection::exceptionWasRaised):
1888         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1889         members arguments list.
1890
1891 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1892
1893         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1894         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1895
1896         Reviewed by Darin.
1897
1898         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1899         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1900         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1901         file.  Note that it may also be used as a stand-alone script.
1902
1903         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1904         * Scripts/resolve-ChangeLogs: Added.
1905         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1906
1907 2007-10-26  Mark Rowe  <mrowe@apple.com>
1908
1909         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1910         to the Qt port on the assumption that it was an implementation of the cross-platform
1911         LayoutTestController class.  It is not, so it did not need to be changed.
1912
1913         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1914
1915 2007-10-25  Mark Rowe  <mrowe@apple.com>
1916
1917         Reviewed by Maciej.
1918
1919         Fix builds with code coverage enabled.
1920
1921         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1922
1923 2007-10-25  Darin Adler  <darin@apple.com>
1924
1925         Reviewed by Mark Rowe.
1926
1927         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1928         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1929
1930 2007-10-25  Stephanie  <slewis@apple.com>
1931
1932         build Fix
1933
1934         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1935
1936 2007-10-25  Stephanie  <slewis@apple.com>
1937
1938         Reviewed by Mark Rowe, Adam Roben.
1939
1940         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1941
1942         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1943
1944 2007-10-25  Alice Liu  <alice.liu@apple.com>
1945
1946         Reviewed by Adam.
1947
1948         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1949
1950         Moving destructor into platform-specific files
1951         * DumpRenderTree/LayoutTestController.cpp:
1952         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1953         (LayoutTestController::~LayoutTestController):
1954         * DumpRenderTree/qt/jsobjects.cpp:
1955         (LayoutTestController::~LayoutTestController):
1956
1957         LayoutTestController wasn't being destroyed
1958         * DumpRenderTree/win/DumpRenderTree.cpp:
1959         (runTest):
1960
1961         Added declspec
1962         * DumpRenderTree/win/EditingDelegate.h:
1963
1964         Reset certain values on the webview (or related delegate) that might 
1965         have changed while running a test
1966         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1967         (LayoutTestController::~LayoutTestController):
1968
1969 2007-10-25  Adam Roben  <aroben@apple.com>
1970
1971         Make sunspider-compare-results work with relative paths
1972
1973         Reviewed by Sam.
1974
1975         * Scripts/sunspider-compare-results: Convert arguments to absolute
1976         paths before we chdir.
1977
1978 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1979
1980         Reviewed by Sam.
1981
1982         - Implemented server calls now the WebScriptDebugServer exists.
1983         - Also removed no longer needed call to initialize CG.
1984
1985         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1986         automatically now.
1987         (_tWinMain):
1988         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1989         (ServerConnection::ServerConnection):
1990         (ServerConnection::~ServerConnection):
1991         (ServerConnection::pause):
1992         (ServerConnection::resume):
1993         (ServerConnection::stepInto):
1994         (ServerConnection::applicationTerminating):
1995         (ServerConnection::serverConnectionDidDie):
1996         * Drosera/win/ServerConnection.h: Now uses the COM class.
1997
1998 2007-10-24  George Staikos  <staikos@kde.org>
1999
2000         Unbreak Qt build.
2001
2002         * Scripts/build-webkit:
2003
2004 2007-10-24  Adam Roben  <aroben@apple.com>
2005
2006         Remove now-unnecessary call to InitializeCoreGraphics
2007
2008         WebKit takes care of this now.
2009
2010         Reviewed by Ada.
2011
2012         * DumpRenderTree/win/DumpRenderTree.cpp:
2013         (initialize):
2014
2015 2007-10-24  Adam Roben  <aroben@apple.com>
2016
2017         Use WebTextRenderer in DRT
2018
2019         Reviewed by Ada.
2020
2021         * DumpRenderTree/win/DumpRenderTree.cpp:
2022         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2023
2024 2007-10-24  Sven Herzberg  <sven@imendio.com>
2025
2026         Reviewed by Mark Rowe.
2027
2028         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2029         Bug 15614: [GTK] qmake based backends don't build on OS X
2030
2031         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2032         GTK backend on a Mac
2033         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2034         isDarwin() to make it reusable in other places (like the workaround-
2035         for-prebuilt-qmake in build-webkit)
2036
2037 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2038
2039         Refurbish update-webkit script.
2040
2041         Reviewed by Adam.
2042
2043         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2044         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2045         multi-argument version of system() for flexibility and security.  Check for existence
2046         of Internal directory using -d test instead of -x.
2047
2048 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2049
2050         Minor clean-up of prepare-ChangeLog script.
2051
2052         Reviewed by Adam.
2053
2054         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2055         of a string.  Use multi-argument versions of open() and system() for flexibility and
2056         security.
2057
2058 2007-10-24  Alice Liu  <alice.liu@apple.com>
2059
2060         Reviewed by Oliver.
2061
2062         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2063
2064         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2065         replay the saved events when we're still processing the mousedown that starts the drag
2066         * DumpRenderTree/win/EventSender.cpp:
2067         (doMouseMove):
2068         * DumpRenderTree/win/UIDelegate.cpp:
2069         (UIDelegate::doDragDrop):
2070
2071 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2072
2073         Reviewed by Sam, Steve and Darin.
2074
2075         - Stubbed out the WebScriptDebugListener functionality in the Server
2076         Connection class to prepare it for receiving those callbacks.
2077         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2078         and the ServerConnection to not need to be initialized with a server
2079         name, since that is not the way we connect to the WebKit server. 
2080
2081         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2082         no exception.  Now it only loggs when there is an exception
2083         (DebuggerDocument::willExecuteStatement):
2084         (DebuggerDocument::didEnterCallFrame):
2085         (DebuggerDocument::willLeaveCallFrame):
2086         (DebuggerDocument::windowScriptObjectAvailable):
2087         (DebuggerDocument::callFunctionOnObject):
2088         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2089         to be instantiated with a server's name.
2090         (DebuggerClient::DebuggerClient):
2091         (DebuggerClient::didFinishLoadForFrame):
2092         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2093         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2094         a server name.
2095         (Drosera::init):
2096         (Drosera::initServer):
2097         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2098         instantiated with a server's name.
2099         * Drosera/win/ServerConnection.cpp: 
2100         (ServerConnection::ServerConnection): No longer needs a server name
2101         (ServerConnection::~ServerConnection): Only release the global context
2102         if there is one.
2103         (ServerConnection::serverConnectionDidDie): Stub for
2104         IWebScriptDebugListener
2105         (ServerConnection::QueryInterface): ditto
2106         (ServerConnection::AddRef): ditto
2107         (ServerConnection::Release): ditto
2108         (ServerConnection::didLoadMainResourceForDataSource): ditto
2109         (ServerConnection::didParseSource): ditto
2110         (ServerConnection::failedToParseSource): ditto
2111         (ServerConnection::didEnterCallFrame): ditto
2112         (ServerConnection::willExecuteStatement): ditto
2113         (ServerConnection::willLeaveCallFrame): ditto
2114         (ServerConnection::exceptionWasRaised): ditto
2115         * Drosera/win/ServerConnection.h: Stubbed out the
2116         IWebScriptDebugListener functions, and this class no longer needs to be
2117         instantiated with a server name.
2118
2119 2007-10-24  Lars Knoll  <lars@trolltech.com>
2120
2121         Reviewed by Simon.
2122
2123         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2124
2125         * DumpRenderTree/qt/jsobjects.h:
2126
2127 2007-10-24  Lars Knoll  <lars@trolltech.com>
2128
2129         Reviewed by Simon.
2130
2131         add another command.
2132
2133         * DumpRenderTree/qt/jsobjects.cpp:
2134         (TextInputController::doCommand):
2135
2136 2007-10-24  Lars Knoll  <lars@trolltech.com>
2137
2138         Reviewed by Simon.
2139
2140         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2141
2142         * DumpRenderTree/qt/jsobjects.cpp:
2143         (EventSender::keyDown):
2144         * DumpRenderTree/qt/jsobjects.h:
2145
2146 2007-10-24  Lars Knoll  <lars@trolltech.com>
2147
2148         Reviewed by Simon.
2149
2150         implement eventSender.keyDown().
2151
2152         * DumpRenderTree/qt/jsobjects.cpp:
2153         (EventSender::keyDown):
2154
2155 2007-10-24  Lars Knoll  <lars@trolltech.com>
2156
2157         Reviewed by Simon.
2158
2159         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2160
2161         * DumpRenderTree/qt/DumpRenderTree.cpp:
2162         (WebCore::DumpRenderTree::DumpRenderTree):
2163         (WebCore::DumpRenderTree::initJSObjects):
2164         * DumpRenderTree/qt/jsobjects.cpp:
2165         (TextInputController::doCommand):
2166
2167 2007-10-24  Lars Knoll  <lars@trolltech.com>
2168
2169         Reviewed by Simon.
2170
2171         first bit of implementation for the textinputcontroller.
2172
2173         * DumpRenderTree/qt/DumpRenderTree.cpp:
2174         (WebCore::DumpRenderTree::DumpRenderTree):
2175         * DumpRenderTree/qt/DumpRenderTree.h:
2176         * DumpRenderTree/qt/jsobjects.cpp:
2177         (TextInputController::TextInputController):
2178         (TextInputController::doCommand):
2179         * DumpRenderTree/qt/jsobjects.h:
2180
2181 2007-10-24  Lars Knoll  <lars@trolltech.com>
2182
2183         Reviewed by Simon.
2184
2185         make the man webpage believe it has focus, so the editing tests work correctly.
2186
2187         * DumpRenderTree/qt/DumpRenderTree.cpp:
2188         (WebCore::DumpRenderTree::DumpRenderTree):
2189
2190 2007-10-24  Lars Knoll  <lars@trolltech.com>
2191
2192         Reviewed by Simon.
2193
2194         implement layoutTestController.dumpEditingCallbacks() correctly.
2195
2196         * DumpRenderTree/qt/DumpRenderTree.cpp:
2197         (WebCore::DumpRenderTree::DumpRenderTree):
2198         * DumpRenderTree/qt/jsobjects.cpp:
2199         (LayoutTestController::reset):
2200         (LayoutTestController::dumpEditingCallbacks):
2201
2202 2007-10-24  Lars Knoll  <lars@trolltech.com>
2203
2204         Reviewed by Simon.
2205
2206         Implement support for testing editing.
2207
2208         * DumpRenderTree/qt/DumpRenderTree.cpp:
2209         (WebCore::DumpRenderTree::DumpRenderTree):
2210
2211 2007-10-23  Sam Weinig  <sam@webkit.org>
2212
2213         Check for null BSTR that can be passed to the UIDelegate methods
2214         from javascript null and undefined.  Fixes a failing test case on
2215         Windows (fast/dom/Window/alert-undefined.html)
2216
2217         Reviewed by Eric Seidel.
2218
2219         * DumpRenderTree/win/UIDelegate.cpp:
2220         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2221         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2222         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2223         (UIDelegate::webViewAddMessageToConsole):
2224
2225 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2226
2227         Reviewed by Darin.
2228         
2229         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2230
2231         * Scripts/build-testkjs:
2232
2233 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2234
2235         Reviewed by Darin.
2236
2237         - add wrapper that finds the right copy of testkjs
2238         
2239         * Scripts/sunspider-compare-results: Added.
2240
2241 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2242
2243         Reviewed by Sam.
2244
2245         - After talking with Steve I now see that the WebKit server must be
2246         running for DCOM to create the distributed objects, which makes sense
2247         and currently WebKit only allows one instance to be running at a time
2248         which avoids accidentally connecting to the wrong server
2249         - In light of this I have removed the code for the attach box and
2250         NotificationServer and known server names, since they are all extranious
2251         now.
2252
2253         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2254         names.
2255         (_tWinMain): Uses init instead of initUI.
2256         (droseraWndProc): No longer creats an attach dialog box.
2257         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2258         it's not manditory to call init before doing COM stuff.
2259         (Drosera::init): calls initUI and will call attach when the
2260         functionality exists. 
2261         (Drosera::initUI): Has changed very little.
2262         (Drosera::attach): Changed the signature to reflect that we no longer
2263         need the dictionary of known server names.
2264         * Drosera/win/Drosera.h: Removed notification classes and known server
2265         names.  Also renamed and moved some functions.
2266         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2267         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2268         headers to the resources folder. 
2269         * Drosera/win/resource.h: Removed the Attach box.
2270
2271 2007-10-22  Adam Roben  <aroben@apple.com>
2272
2273         Windows build fix
2274
2275         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2276
2277 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2278
2279         - Removed a leak that was fixed.
2280
2281         * Scripts/run-webkit-tests:
2282
2283 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2284
2285         Reviewed by Darin.
2286
2287         - Changed the Client so that the DebuggerDocument now own the
2288         ServerConnection.  This simplifies ownership and cleanup. 
2289
2290         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2291         ServerConnection.
2292         (DebuggerClient::initWithServerName):
2293         (DebuggerClient::didFinishLoadForFrame):
2294         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2295         ServerConnection.
2296         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2297         until after we have a server which we are attached to.
2298         (Drosera::initUI):
2299         (Drosera::attach):
2300         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2301         out previously.
2302
2303 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2304
2305         Reviewed by Nikolas.
2306
2307         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2308
2309         * Scripts/run-javascriptcore-tests:
2310
2311 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2312
2313         Reviewed by Nikolas.
2314
2315         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2316
2317         * Scripts/build-drosera:
2318         * Scripts/build-dumprendertree:
2319         * Scripts/build-testkjs:
2320         * Scripts/build-webkit:
2321         * Scripts/run-javascriptcore-tests:
2322         * Scripts/run-sunspider:
2323         * Scripts/run-webkit-tests:
2324         * Scripts/webkitdirs.pm:
2325
2326 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2327
2328         Reviewed by Mark Rowe.
2329         
2330         Fix for local database support after r26879
2331         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2332
2333         * Scripts/build-webkit:
2334
2335 2007-10-22  Holger Freyther  <zecke@selfish.org>
2336
2337         Reviewed by Simon Hausmann <hausmann@kde.org>.
2338
2339         - Do not build testkjs as an application bundle. This is
2340         needed for run-javascriptcore-tests on OSX.
2341         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2342         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2343         as we do not have -rpath on OSX.
2344
2345         * DumpRenderTree/qt/DumpRenderTree.pro:
2346         * Scripts/run-webkit-tests:
2347
2348 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2349
2350         Reviewed by aroben.
2351
2352         Fix support for Signed-off-by detection in prepare-ChangeLog
2353         --git-commit. The Signed-off-by tag does not appear in the header
2354         but usually at the end.
2355
2356         * Scripts/prepare-ChangeLog:
2357
2358 2007-10-21  Mark Rowe  <mrowe@apple.com>
2359
2360         Reviewed by Eric.
2361
2362         Fix run-javascriptcore-tests for Gtk.
2363
2364         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2365
2366 2007-10-20  Eric Seidel  <eric@webkit.org>
2367
2368         Reviewed by aroben.
2369
2370         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2371
2372 2007-10-20  Eric Seidel  <eric@webkit.org>
2373
2374         Reviewed by darin.
2375         
2376         Add improved argument handling to run-sunspider, including
2377         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2378         Also re-factor code into subroutines
2379
2380         * Scripts/build-dumprendertree: removed bogus comments
2381         * Scripts/build-testkjs: Added.
2382         * Scripts/run-javascriptcore-tests: use build-testkjs
2383         * Scripts/run-sunspider: improved argument handling, abstraction
2384         * Scripts/run-webkit-tests: improved abstraction
2385
2386 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2387
2388         Not reviewed, Windows build fix.
2389
2390         * DumpRenderTree/win/EventSender.cpp:
2391         (keyDownCallback):
2392
2393 2007-10-20  Darin Adler  <darin@apple.com>
2394
2395         Reviewed by Tim Hatcher.
2396
2397         - http://bugs.webkit.org/show_bug.cgi?id=15544
2398           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2399           not rely on Apple-specific key codes
2400
2401         * DumpRenderTree/mac/EventSendingController.mm:
2402         (-[EventSendingController keyDown:withModifiers:]):
2403         Added named key "rightArrow". Later we could have a whole table of these.
2404         Also tweaked modifiers code a little.
2405
2406         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2407
2408 2007-10-19  Darin Adler  <darin@apple.com>
2409
2410         Reviewed by Eric.
2411
2412         - http://bugs.webkit.org/show_bug.cgi?id=15566
2413           possible fix for leak seen in DumpRenderTree
2414
2415         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2416         Delete the item if it's not put on the queue, since the caller has
2417         no way of knowing that. Would be better to have the parameter type
2418         be auto_ptr to express the fact that we take ownership.
2419
2420         - unrelated change
2421
2422         * Drosera/mac/main.m: Add missing include.
2423
2424 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2425
2426         Reviewed by Adam.
2427
2428         - This change should be identical but for some reason was not working
2429         on my machine.
2430
2431         * Scripts/prepare-ChangeLog:
2432
2433 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2434
2435         Reviewed by Oliver and Tim.
2436
2437         - Made use of RetainPtr to avoid retain and release issues and moved the
2438         log function to DebuggerDocumentPlatform, which seems to be a more
2439         logical place for it to live.
2440         - Also moved knownServers from the ServerConnection to
2441         DebuggerApplication to match the Windows code and because it makes sense
2442         that a connection knows its own server but not all of them.
2443
2444         * Drosera/mac/DebuggerClient.h: Moved the log function to
2445           DebuggerDocumentPlatform.
2446         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2447           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2448           call for the server name up from the ServerConnection class.
2449         (-[DebuggerClient dealloc]):
2450         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2451           for the server name up from the ServerConnection.
2452         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2453         (DebuggerDocument::platformPause):
2454         (DebuggerDocument::platformResume):
2455         (DebuggerDocument::platformStepInto):
2456         (DebuggerDocument::platformEvaluateScript):
2457         (DebuggerDocument::getPlatformCurrentFunctionStack):
2458         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2459         (DebuggerDocument::platformValueForScopeVariableNamed):
2460         (DebuggerDocument::platformLog): Log directly from here. No need to call
2461           DebuggerClient.
2462         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2463           way I see it, a ServerConnection should only know about its connection
2464           and the group of all possible servers should be kept by the
2465           application.
2466         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2467           currentServerName, it makes sense that the connection should know that
2468           name.
2469         (-[ServerConnection currentServerName]):
2470
2471 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2472
2473         Reviewed by Adam.
2474
2475         - Integrated changes from mac drosera.  Recently I've encapsulated
2476         out the server connection object from the rest of Drosera because
2477         it is very platform dependent right now and RPC is not implemented on
2478         windows.  This functionality, of communicating with the WebKit server
2479         is the next area I will be focusing on in Windows.
2480
2481         - Other changes and cleanup were made to organize the code and add notes
2482         on which parts still need work.  Also some mac code is added and
2483         commented out, to act as pseudocode for the logic of those parts.
2484
2485         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2486           pointer.
2487         * Drosera/config.h: Added whitespace.
2488         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2489           these files got moved into Drosera.h/cpp
2490         * Drosera/win/DebuggerApplication.h: Removed.
2491         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2492           happened here to better match the logic flow of the same code on the 
2493           mac side and to use the new ServerConnection class.
2494         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2495         (DebuggerClient::initWithServerName): Initializer that will set up the
2496           class to use a ServerConnection object.  This was necessary so I could
2497           create a DebuggerClient without having to initilaize it at
2498           construction.
2499         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2500           will be the UIDelegate and FrameLoadDelegate.
2501         (DebuggerClient::AddRef): For IUnknown.
2502         (DebuggerClient::Release): For IUnknown.
2503         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2504           this still needs to set the global context of the server, but
2505           IWebFrame does not have an accessor for the global context yet. 
2506         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2507           this is a pass through for the same function in the document.
2508         (DebuggerClient::didReceiveTitle): Unimplemented part of
2509           FrameLoadDelegate this would change the title of the window.
2510         (DebuggerClient::createWebViewWithRequest): Part of the
2511           FrameLoadDelegate.  This is about new windows via Window.open() and
2512           how their delegates are set.
2513         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2514           UIDelegate.  Just a debug function for printing messages.
2515         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2516           because the Client should be the UIDelegate and FrameLoadDelegate
2517           to match the delegates on mac.
2518         (DebuggerClient::webViewLoaded): Added accessor method.
2519         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2520           forgotten to add this file before.  This is where the platform
2521           dependent versions of the Documents functions live. Most of these are
2522           unimplemented because some piece of functionality does not exist on
2523           Windows yet.
2524         (DebuggerDocument::platformPause):
2525         (DebuggerDocument::platformResume):
2526         (DebuggerDocument::platformStepInto):
2527         (DebuggerDocument::platformEvaluateScript):
2528         (DebuggerDocument::getPlatformCurrentFunctionStack):
2529         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2530         (DebuggerDocument::platformValueForScopeVariableNamed):
2531         (DebuggerDocument::platformLog):
2532         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2533           responsibilities becaue they belong in the Client. Also I laid the
2534           groundwork for attaching Drosera to a WebKit process
2535         (attachWndProc): Now if a server is selected the Client becomes it's
2536           delegate.
2537         (Drosera::Drosera): Added the construction of the Client and dictionary
2538           of server names. 
2539         (Drosera::initUI): This is no longer the delegates, the Client is.
2540         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2541           state. 
2542         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2543           notification registration when it's possible to implement.
2544         (Drosera::serverLoaded): Ditto
2545         (Drosera::serverUnloaded): Ditto
2546         (Drosera::attach): Attach Drosera to the WebKit server.
2547         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2548         (Drosera::getInst): 
2549         (Drosera::setInst):
2550         (Drosera::knownServers):
2551         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2552           and added the ServerConnection.
2553         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2554         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2555           Most of the functions are completely unimlemented because they cannot
2556           connect with the WebKit server, because one does not exist on Windows
2557           yet.
2558         (ServerConnection::initWithServerName): 
2559         (ServerConnection::~ServerConnection):
2560         (ServerConnection::setGlobalContext):
2561         (ServerConnection::pause):
2562         (ServerConnection::resume):
2563         (ServerConnection::stepInto):
2564         (ServerConnection::switchToServerNamed):
2565         (ServerConnection::applicationTerminating):
2566         (ServerConnection::serverConnectionDidDie):
2567         (ServerConnection::currentFrame):
2568         * Drosera/win/ServerConnection.h: Added. Ditto.
2569         (ServerConnection::ServerConnection):
2570
2571 2007-10-19  Alice Liu  <alice.liu@apple.com>
2572
2573         Reviewed by Darin.
2574
2575         Fix for these broken layout tests on Windows:
2576         
2577         fast/forms/focus-selection-input.html
2578         fast/forms/focus-selection-textarea.html
2579         fast/forms/select-accesskey.html
2580         
2581         * DumpRenderTree/win/EventSender.cpp:
2582         (keyDownCallback):
2583         correct the VK code for alt key.
2584         
2585 2007-10-19  Eric Seidel  <eric@webkit.org>
2586
2587         Reviewed by Mark Rowe.
2588         
2589         Make the GtkLauncher code slightly more readable.
2590
2591         * GtkLauncher/main.cpp:
2592         (setupMainMenu): Added.
2593         (setupMainWindowUI): Added.
2594         (main):
2595
2596 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2597
2598         Rubber stamped by Adam.
2599         
2600         - don't delay-load WebKit in DumpRenderTree.
2601
2602         * DumpRenderTree/win/DumpRenderTree.vcproj:
2603
2604 2007-10-18  Dan Bernstein  <mitz@apple.com>
2605
2606         Reviewed by Adam Roben.
2607
2608         - fix <rdar://problem/5313523>
2609         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2610
2611         * DumpRenderTree/mac/DumpRenderTree.mm:
2612         (dump): Changed to use _responseMIMEType.
2613
2614 2007-10-17  Adam Roben  <aroben@apple.com>
2615
2616         Make it possible to have Windows-specific tests and results
2617
2618         When searching for tests to run and the Skipped file, we will only
2619         look in platform/win and the cross-platform directory. When looking
2620         for expected results, we will look in platform/win, then
2621         platform/mac-leopard, then platform/mac, then finally the
2622         cross-platform directory.
2623
2624         Reviewed by Sam.
2625
2626         * Scripts/run-webkit-tests:
2627         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2628         searching in the cross-platform directory.
2629         (sub buildPlatformHierarchy): Removed some unneeded calls to
2630         dirname/basename.
2631
2632 2007-10-17  Adam Roben  <aroben@apple.com>
2633
2634         Add back the call to register WebKit that we had before WebKitInitializer existed
2635
2636         This is needed to ensure that the right WebKit is used when
2637         instantiating COM objects.
2638
2639         Reviewed by Oliver.
2640
2641         * DumpRenderTree/win/debug_internal.vsprops: Define
2642         DEBUG_WEBKIT_HAS_SUFFIX.
2643         * DumpRenderTree/win/DumpRenderTree.cpp:
2644         (initialize):
2645
2646 2007-10-17  Adam Roben  <aroben@apple.com>
2647
2648         Import File::Basename in webkitdirs since we use it
2649
2650         * Scripts/webkitdirs.pm:
2651
2652 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2653
2654         - Updated the tiger leaks list to make the internal bots green.
2655
2656         * Scripts/run-webkit-tests:
2657
2658 2007-10-17  Adam Roben  <aroben@apple.com>
2659
2660         Build fix for VC++ Express
2661
2662         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2663         and ole32.lib.
2664
2665 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2666
2667         Reviewed by Sam.
2668
2669         - Minor mac improvements based on observations I made while implementing the
2670         Windows code.
2671
2672         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2673         then hand it to the Client who will retain it, it should just be the client who
2674         creates and owns the server.
2675         (-[DebuggerApplication attach:]):
2676         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2677         * Drosera/mac/DebuggerClient.mm: Creates the server.
2678         (-[DebuggerClient initWithServerName:]):
2679         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2680         can instead forward declare what it needs.
2681
2682 2007-10-16  Darin Adler  <darin@apple.com>
2683
2684         Reviewed by Geoff Garen.
2685
2686         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2687         want to turn failing tests into platform-specific test results. Also did a
2688         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2689         would take the type of results into account only some of the time.
2690
2691 2007-10-16  Adam Roben  <aroben@apple.com>
2692
2693         Add a new nightly launcher script for Windows
2694
2695         This new script is for versions of Safari that don't delay-load
2696         WebKit. I had to make FindSafari be able to print out the nightly
2697         launcher script on stdout because Windows shell scripts can't capture
2698         the output from a command into an environment variable.
2699
2700         Reviewed by Steve.
2701
2702         * FindSafari/FindSafari.cpp:
2703         (_tmain): Added /printSafariLauncher option.
2704         * Scripts/run-webkit-nightly.cmd: Added.
2705
2706 2007-10-16  Adam Roben  <aroben@apple.com>
2707
2708         Replace WebKitInitializer with FindSafari
2709
2710         We now rely on setting the PATH environment variable to tell Windows
2711         where to find WebKit and its dependencies (similar to
2712         DYLD_FRAMEWORK_PATH on Mac).
2713
2714         This change also make DumpRenderTree no longer delay-load WebKit.
2715
2716         Reviewed by Sam.
2717
2718         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2719         FindSafari.
2720         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2721         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2722         WebKitInitializer, don't delay-load WebKit.
2723         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2724         * Scripts/run-webkit-tests: Ditto.
2725         * Scripts/webkitdirs.pm:
2726         (sub setPathForRunningWebKitApp): Added.
2727         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2728         * WebKitInitializer/WebKitInitializer.h: Removed.
2729         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2730         * WebKitInitializer/debug.vsprops: Removed.
2731         * WebKitInitializer/debug_internal.vsprops: Removed.
2732         * WebKitInitializer/release.vsprops: Removed.
2733
2734 2007-10-16  Adam Roben  <aroben@apple.com>
2735
2736         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2737
2738         http://bugs.webkit.org/show_bug.cgi?id=15532
2739
2740         FindSafari simply prints the location of an installed Safari.exe on
2741         stdout.
2742
2743         Reviewed by Darin.
2744
2745         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2746         (getStringValue):
2747         (getWebViewCLSID):
2748         (getInstalledWebKitDirectory):
2749         (_tmain):
2750         * FindSafari/FindSafari.vcproj: Added.
2751         * Scripts/webkitdirs.pm:
2752         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2753
2754 2007-10-16  Adam Roben  <aroben@apple.com>
2755
2756         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2757
2758         Reviewed by Kevin McCullough.
2759
2760         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2761         when referring to WebKit.dll.
2762         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2763         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2764         * DumpRenderTree/win/release.vsprops: Ditto.
2765         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2766         never have a _debug suffix on WebKit.dll.
2767         * WebKitInitializer/WebKitInitializer.cpp:
2768         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2769         specified.
2770         * WebKitInitializer/debug_internal.vsprops: Added
2771         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2772
2773 2007-10-16  Darin Adler  <darin@apple.com>
2774
2775         Reviewed by Adele.
2776
2777         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2778         Remove now-unneeded control/alt key hack; the tests have been updated.
2779
2780 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2781
2782         - Updated leaks list because our internal bot upgraded it's version of leopard and 
2783         one of the leaks was fixed between that revision and the bot's previous version of
2784         leopard.
2785
2786         * Scripts/run-webkit-tests:
2787
2788 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2789
2790         Reviewed by Tim.
2791
2792         - I encapsulated out the server connecton functionality because it is a specific part
2793         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2794         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2795         Windows.  So the majority of this patch is moving preexisting functionality.
2796
2797         - Also I removed the prefix header and changed to use config.h because it is more
2798         standard on how we use config.h in windows and it didn't make much sense to keep
2799         the prefix header and the config.h
2800
2801         * Drosera/DebuggerDocument.cpp:
2802         (DebuggerDocument::DebuggerDocument):
2803         * Drosera/DebuggerDocument.h:
2804         * Drosera/config.h:
2805         * Drosera/mac/DebuggerApplication.mm:
2806         (-[DebuggerApplication attach:]):
2807         * Drosera/mac/DebuggerClient.h:
2808         * Drosera/mac/DebuggerClient.mm:
2809         (-[DebuggerClient initWithServerConnection:]):
2810         (-[DebuggerClient dealloc]):
2811         (-[DebuggerClient windowDidLoad]):
2812         (-[DebuggerClient windowWillClose:]):
2813         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2814         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2815         * Drosera/mac/DebuggerDocumentPlatform.mm:
2816         (DebuggerDocument::platformPause):
2817         (DebuggerDocument::platformResume):
2818         (DebuggerDocument::platformStepInto):
2819         (DebuggerDocument::platformEvaluateScript):
2820         (DebuggerDocument::getPlatformCurrentFunctionStack):
2821         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2822         (DebuggerDocument::platformValueForScopeVariableNamed):
2823         (DebuggerDocument::platformLog):
2824         * Drosera/mac/Drosera.pch: Removed.
2825         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2826         * Drosera/mac/ServerConnection.h: Added.
2827         * Drosera/mac/ServerConnection.mm: Added.
2828         (-[ServerConnection initWithServerName:]):
2829         (-[ServerConnection dealloc]):
2830         (-[ServerConnection setGlobalContext:]):
2831         (-[ServerConnection pause]):
2832         (-[ServerConnection resume]):
2833         (-[ServerConnection stepInto]):
2834         (-[ServerConnection switchToServerNamed:]):
2835         (-[ServerConnection applicationTerminating:]):
2836         (-[ServerConnection serverConnectionDidDie:]):
2837         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2838         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2839         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2840         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2841         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2842         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2843         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2844         (-[ServerConnection currentFrame]):
2845         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2846         (-[ServerConnection knownServers]):
2847
2848 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2849
2850         Reviewed by Eric.
2851
2852         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2853           Script to automatically search nightly builds for regressions (bisect-builds)
2854
2855         * Scripts/bisect-builds: Added.
2856
2857 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2858
2859         Reviewed by Darin.
2860
2861         - New JavaScript benchmark
2862         http://bugs.webkit.org/show_bug.cgi?id=15515
2863
2864         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2865         current development or release build of JavaScriptCore.
2866
2867 2007-10-15  Mark Rowe  <mrowe@apple.com>
2868
2869         Reviewed by Sam.
2870
2871         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2872
2873         * Scripts/webkitdirs.pm:
2874         - Change checkArgv to remove the options from @ARGV to prevent
2875         them from interfering with further option processing.
2876         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2877         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2878         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2879         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2880
2881 2007-10-15  Darin Adler  <darin@apple.com>
2882
2883         Reviewed by Sam.
2884
2885         - added logging of window.prompt and window.confirm
2886
2887         * DumpRenderTree/mac/UIDelegate.mm:
2888         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2889         Implement the recommended delegate rather than the deprecated one.
2890         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2891         Added.
2892         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2893         Added.
2894
2895         * DumpRenderTree/win/UIDelegate.h:
2896         * DumpRenderTree/win/UIDelegate.cpp:
2897         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2898         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2899         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2900         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2901
2902 2007-10-15  Alice Liu  <alice.liu@apple.com>
2903
2904         Reviewed by Sam Weinig.
2905
2906         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2907
2908         * DumpRenderTree/win/DumpRenderTree.cpp:
2909         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2910         (main): allocate the global policy delegate for DRT's custom use
2911         * DumpRenderTree/win/DumpRenderTree.vcproj:
2912         Adding files to project
2913         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2914         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2915         (LayoutTestController::setCustomPolicyDelegate):
2916         set the webview's policy delegate to DRT's custom one if the test requests it.
2917         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2918         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2919         (PolicyDelegate::PolicyDelegate):
2920         (PolicyDelegate::QueryInterface):
2921         (PolicyDelegate::AddRef):
2922         (PolicyDelegate::Release):
2923         (PolicyDelegate::decidePolicyForNavigationAction):
2924         * DumpRenderTree/win/PolicyDelegate.h: Added.
2925         (PolicyDelegate::decidePolicyForNewWindowAction):
2926         (PolicyDelegate::decidePolicyForMIMEType):
2927         (PolicyDelegate::unableToImplementPolicyWithError):
2928
2929 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2930
2931         Reviewed by Mark.
2932
2933         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2934         when querying for QMAKE_MKSPECS.
2935
2936 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2937
2938         Reviewed by Adam Roben.
2939         
2940         Fix run-webkit-tests is too greedy calculating platform hierarchy
2941         http://bugs.webkit.org/show_bug.cgi?id=15465
2942         
2943         Fix run-webkit-tests being too greedy in trying to split the platform name up
2944         causing it to try and find tests in every directory above the first "-" in the
2945         path to the LayoutTests
2946
2947         * Scripts/run-webkit-tests:
2948
2949 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2950
2951         Reviewed by Darin.
2952
2953         http://bugs.webkit.org/show_bug.cgi?id=15006
2954         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2955         to reduce code duplication.
2956
2957         * Scripts/build-webkit:
2958         * Scripts/webkitdirs.pm:
2959         buildQMakeProject() renamed to buildQMakeQtProject().
2960         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2961         unused $colorize has been removed.
2962
2963 === Start merge of feature-branch 2007-10-12 ===
2964
2965 2007-10-08  Eric Seidel  <eric@webkit.org>
2966
2967         Reviewed by Mark Rowe.
2968
2969         * Scripts/build-webkit: add --help, remove unused --color
2970
2971 2007-10-07  Eric Seidel  <eric@webkit.org>
2972
2973         Reviewed by darin.
2974
2975         * Drosera/mac/DebuggerDocumentPlatform.mm:
2976         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2977
2978 2007-10-03  Rob Buis  <buis@kde.org>
2979
2980         Reviewed by Olliej.
2981
2982         Adapt to changed location of Ahem font.
2983
2984         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2985
2986 2007-10-02  Eric Seidel  <eric@webkit.org>
2987
2988         Reviewed by Adam Roben.
2989         
2990         Make pixel tests more useful!
2991         Finally fix the image diff 0.00% mystery problem
2992         Highlight any image differences in the image diff.
2993         Add a link from image diffs back to original test file.
2994
2995         * DumpRenderTree/mac/ImageDiff.m:
2996         (compareImages): highlight any differences
2997         (computePercentageDifferent): round to two decimal places
2998         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2999
3000 2007-10-02  Eric Seidel  <eric@webkit.org>
3001
3002         Reviewed by Alexey Proskuryakov.
3003
3004         * Scripts/run-webkit-tests: print the % image difference on main results page
3005
3006 2007-10-02  Mark Rowe  <mrowe@apple.com>
3007
3008         Reviewed by Oliver.
3009
3010         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3011
3012         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3013         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3014
3015 2007-10-01  Mark Rowe  <mrowe@apple.com>
3016
3017         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3018
3019 2007-09-25  Eric Seidel  <eric@webkit.org>
3020
3021         Reviewed by Mark Rowe.
3022         
3023         DerivedSources.make was finding "ENABLE_SVG" in the string
3024         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3025         quite correctly.
3026
3027         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3028
3029 2007-09-25  Mark Rowe  <mrowe@apple.com>
3030
3031         Rubber-stamped by Eric.
3032
3033         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3034         This makes it possible to automate nightly builds for the feature-branch.
3035
3036 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3037
3038         Rubber stamped by Mark.
3039
3040         Enable svg experimental features as default here in feature-branch.
3041
3042         * Scripts/build-webkit:
3043
3044 2007-06-29  Antti Koivisto  <antti@apple.com>
3045
3046         Reviewed by Weinig.
3047         
3048         Add VIDEO flag for timed media features
3049
3050         * Scripts/build-webkit
3051         
3052 === End merge of feature-branch 2007-10-12 ===
3053
3054 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3055
3056         Reviewed by Darin.
3057
3058         - Updated rational for the leaks list to be more clear.
3059
3060         * Scripts/run-webkit-tests:
3061
3062 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3063
3064         Rubber Stamp by Sam.
3065
3066         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3067         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3068
3069         * Scripts/run-webkit-tests:
3070
3071 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3072
3073         Reviewed by Lars.
3074
3075         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3076         includes are needed for INT_MAX, std::auto_ptr and the like.
3077
3078         * DumpRenderTree/qt/main.cpp:
3079
3080 2007-10-09  Lars Knoll  <lars@trolltech.com>
3081
3082         Reviewed by Simon.
3083
3084         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3085
3086         * DumpRenderTree/qt/jsobjects.cpp:
3087         (LayoutTestController::encodeHostName):
3088         (LayoutTestController::decodeHostName):
3089         * DumpRenderTree/qt/jsobjects.h:
3090
3091 2007-10-09  Lars Knoll  <lars@trolltech.com>
3092
3093         Reviewed by Simon.
3094
3095         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3096
3097         * DumpRenderTree/qt/DumpRenderTree.cpp:
3098         (WebCore::WebPage::createFrame):
3099         (WebCore::DumpRenderTree::DumpRenderTree):
3100         (WebCore::DumpRenderTree::titleChanged):
3101         * DumpRenderTree/qt/DumpRenderTree.h:
3102         * DumpRenderTree/qt/jsobjects.cpp:
3103         (LayoutTestController::reset):
3104         * DumpRenderTree/qt/jsobjects.h:
3105
3106 2007-10-09  Lars Knoll  <lars@trolltech.com>
3107
3108         Reviewed by Simon.
3109
3110         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3111
3112         * DumpRenderTree/qt/DumpRenderTree.h:
3113         * DumpRenderTree/qt/jsobjects.cpp:
3114         (LayoutTestController::clearBackForwardList):
3115         * DumpRenderTree/qt/jsobjects.h:
3116
3117 2007-10-09  Lars Knoll  <lars@trolltech.com>
3118
3119         Reviewed by Simon.
3120
3121         make --git-reviewer work again.
3122
3123         * Scripts/prepare-ChangeLog:
3124
3125 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3126
3127         Rubber stamped by Eric.
3128
3129         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3130         show the current link inside the statusbar.
3131         This shows how to make use of this signal and allows to easily test
3132         http://bugs.webkit.org/show_bug.cgi?id=15299.
3133
3134         * GtkLauncher/main.cpp:
3135         (hoveringOverLink):
3136         (main):
3137
3138 2007-10-05  Lars Knoll  <lars@trolltech.com>
3139
3140         add proper error messages to the FrameLoaderClient.
3141         Implement ChromeClientQt::closeWindowSoon and
3142         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3143         Some fixes in DRT to make it work correctly with multiple windows.
3144
3145         Reviewed by Maciej.
3146
3147         * DumpRenderTree/qt/DumpRenderTree.cpp:
3148         (WebCore::DumpRenderTree::DumpRenderTree):
3149         (WebCore::DumpRenderTree::createWindow):
3150         (WebCore::DumpRenderTree::windowCount):
3151         * DumpRenderTree/qt/DumpRenderTree.h:
3152         * DumpRenderTree/qt/jsobjects.cpp:
3153         (LayoutTestController::maybeDump):
3154         (LayoutTestController::windowCount):
3155         * DumpRenderTree/qt/jsobjects.h:
3156
3157 2007-10-05  Lars Knoll  <lars@trolltech.com>
3158
3159         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3160         Add support for layoutTextController.setCanOpenWindows() to DRT
3161         fixing another 2 test cases in fast/dom/Window.
3162
3163         Reviewed by Maciej.
3164
3165         * DumpRenderTree/qt/DumpRenderTree.cpp:
3166         (WebCore::WebPage::WebPage):
3167         (WebCore::WebPage::createWindow):
3168         (WebCore::DumpRenderTree::resetJSObjects):
3169         (WebCore::DumpRenderTree::createWindow):
3170         * DumpRenderTree/qt/DumpRenderTree.h:
3171         * DumpRenderTree/qt/DumpRenderTree.pro:
3172         * DumpRenderTree/qt/jsobjects.cpp:
3173         (LayoutTestController::LayoutTestController):
3174         (LayoutTestController::reset):
3175         * DumpRenderTree/qt/jsobjects.h:
3176         * DumpRenderTree/qt/main.cpp:
3177         * DumpRenderTree/qt/testplugin.cpp: Added.
3178         * DumpRenderTree/qt/testplugin.h: Added.
3179
3180 2007-10-04  Sam Weinig  <sam@webkit.org>
3181
3182         Rubber stamped by Adam.
3183
3184         Remove empty directories.
3185
3186         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3187         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3188
3189 2007-10-03  Darin Adler  <darin@apple.com>
3190
3191         Reviewed by Adam.
3192
3193         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3194         we find the internal libraries in the libraries directory. This
3195         is helpful for Safari team engineers at Apple.
3196
3197 2007-10-03  Adam Roben  <aroben@apple.com>
3198
3199         Update the location of AHEM___.TTF after r25968
3200
3201         Reviewed by Sam.
3202
3203         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3204
3205 2007-10-03  Alp Toker  <alp@atoker.com>
3206
3207         Reviewed by Adam.
3208
3209         http://bugs.webkit.org/show_bug.cgi?id=14726
3210         [gtk] API design. Mapping the WebView delegates to signals.
3211
3212         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3213
3214         * GtkLauncher/main.cpp:
3215         (goToURLBarText):
3216         (titleChanged):
3217         (progressChanged):
3218         (menuMainBackCallback):
3219         (menuMainForwardCallback):
3220         (main):
3221
3222 2007-10-03  Lars Knoll  <lars@trolltech.com>
3223
3224         Reviewed by Rob.
3225
3226         This fixes --strict mode in run-webkit-tests again after
3227         the platform dependent test results have been moved.
3228
3229         * Scripts/run-webkit-tests:
3230
3231 2007-10-03  Lars Knoll  <lars@trolltech.com>
3232
3233         Reviewed by bdash.
3234
3235         remove the hack in run-webkit-tests that forced text only test
3236         to be taken from the platform independent dir. It was only left
3237         there from early days.
3238         
3239         Remove platform dependent results for tests that are text only nowadays,
3240         and add one platform dependent result for a text only test that requires it.
3241
3242         * Scripts/run-webkit-tests:
3243
3244 2007-10-03  Lars Knoll  <lars@trolltech.com>
3245
3246         Reviewed by olliej.
3247
3248         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3249
3250         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3251         (WebCore::WebFrame::WebFrame):
3252         (WebCore::WebPage::WebPage):
3253         (WebCore::WebPage::createFrame):
3254         (WebCore::WebPage::javaScriptAlert):
3255         (WebCore::WebPage::javaScriptConsoleMessage):
3256         (WebCore::DumpRenderTree::DumpRenderTree):
3257         (WebCore::DumpRenderTree::~DumpRenderTree):
3258         (WebCore::DumpRenderTree::open):
3259         (WebCore::DumpRenderTree::readStdin):
3260         (WebCore::DumpRenderTree::resetJSObjects):
3261         (WebCore::DumpRenderTree::initJSObjects):
3262         (WebCore::DumpRenderTree::dumpFramesAsText):
3263         (WebCore::DumpRenderTree::dump):
3264         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3265         (WebCore::DumpRenderTree::layoutTestController):
3266         (WebCore::DumpRenderTree::eventSender):
3267         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3268         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3269         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3270         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3271         (HackWebFrame::mousePressEvent):
3272         (HackWebFrame::mouseReleaseEvent):
3273         (HackWebFrame::mouseMoveEvent):
3274         (HackWebFrame::HackWebFrame):
3275         (HackWebFrame::~HackWebFrame):
3276         (LayoutTestController::LayoutTestController):
3277         (LayoutTestController::reset):
3278         (LayoutTestController::maybeDump):
3279         (LayoutTestController::waitUntilDone):
3280         (LayoutTestController::notifyDone):
3281         (LayoutTestController::dumpEditingCallbacks):
3282         (LayoutTestController::queueReload):
3283         (LayoutTestController::provisionalLoad):
3284         (LayoutTestController::timerEvent):
3285         (EventSender::EventSender):
3286         (EventSender::mouseDown):
3287         (EventSender::mouseUp):
3288         (EventSender::mouseMoveTo):
3289         (EventSender::leapForward):
3290         (EventSender::keyDown):
3291         (EventSender::frameUnderMouse):
3292         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3293         (LayoutTestController::isLoading):
3294         (LayoutTestController::setLoading):
3295         (LayoutTestController::shouldDumpAsText):
3296         (LayoutTestController::shouldDumpChildrenAsText):
3297         (LayoutTestController::shouldWaitUntilDone):
3298         (LayoutTestController::dumpAsText):
3299         (LayoutTestController::dumpChildFramesAsText):
3300         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3301         (messageHandler):
3302         (crashHandler):
3303         (main):
3304         * Scripts/run-webkit-tests:
3305
3306 2007-10-03  Mark Rowe  <mrowe@apple.com>
3307
3308         Reviewed by Alp Toker.
3309
3310         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3311         should take precedence over QTDIR when determining which port we are working with.
3312
3313         * Scripts/webkitdirs.pm: 
3314
3315 2007-10-02  Adam Roben  <aroben@apple.com>
3316
3317         Add keychain to the list of default packages to install
3318
3319         Rubberstamped by Sam.
3320
3321         * CygwinDownloader/cygwin-downloader.py:
3322         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3323
3324 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3325
3326         Reviewed by Adam.
3327
3328         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3329         Also makes WebCore regression test case logic work when using git.
3330
3331         * Scripts/prepare-ChangeLog:
3332         (reviewerAndDescriptionForGitCommit): Added.
3333
3334 2007-10-02  Lars Knoll  <lars@trolltech.com>
3335
3336         Reviewed by bdash.
3337
3338         Add API to retrieve the frame name from QWebFrame.
3339         Implement support for DRT::dumpChildrenAsText.
3340
3341         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3342         (WebCore::DumpRenderTree::dumpFramesAsText):
3343         (WebCore::DumpRenderTree::dump):
3344         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3345         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3346         (LayoutTestController::LayoutTestController):
3347         (LayoutTestController::reset):
3348         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3349
3350 2007-10-02  Lars Knoll  <lars@trolltech.com>
3351
3352         Reviewed by bdash.
3353
3354         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3355
3356         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3357         (WebCore::DumpRenderTree::readStdin):
3358
3359 2007-10-02  Mark Rowe  <mrowe@apple.com>
3360
3361         Reviewed by Oliver.
3362
3363         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3364
3365         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3366         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3367
3368 2007-10-02  Mark Rowe  <mrowe@apple.com>
3369
3370         Rubber-stamped by Maciej.
3371
3372         Configuration changes from build.webkit.org.  The major change is refactoring to work
3373         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3374         last few weeks.
3375
3376         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3377         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3378         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3379         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3380         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3381         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3382         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3383         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3384
3385 2007-10-02  Lars Knoll  <lars@trolltech.com>
3386
3387         Reviewed by Maciej.
3388
3389         Add support for eventSender.mouseMove to DRT.
3390         Fixes fast/css/hover-affects-child.html
3391
3392         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3393         (EventSender::mouseMoveTo):
3394
3395 2007-10-01  Mark Rowe  <mrowe@apple.com>
3396
3397         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3398
3399 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3400
3401         Reviewed by Hyatt.
3402
3403         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3404
3405         * Scripts/svn-apply:
3406         (gitdiff2svndiff): Ignore lines beginning with "new file".
3407         * Scripts/svn-unapply:
3408         (gitdiff2svndiff): Ditto.
3409
3410 2007-09-30  George Staikos  <staikos@kde.org>
3411
3412         Qt build fix (Mac OS X specific)
3413
3414         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3415
3416 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3417
3418         Reviewed by Mark.
3419
3420         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3421         Remove Bakefiles from svn.
3422
3423         * GtkLauncher/Bakefiles.bkgen: Removed.
3424         * GtkLauncher/ENV: Removed.
3425         * GtkLauncher/gdklauncher.bkl: Removed.
3426         * GtkLauncher/mk: Removed.
3427         * Scripts/regenerate-makefiles: Removed.
3428
3429 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3430
3431         Reviewed by John.
3432
3433         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3434
3435         * Scripts/run-webkit-tests:
3436
3437 2007-09-26  Adam Roben  <aroben@apple.com>
3438
3439         Make not finding an installed WebKit non-fatal
3440
3441         What really matters is that we are able to load WebKit and its
3442         dependencies, not whether we think we've found an installed WebKit.
3443
3444         Reviewed by Sam.
3445
3446         * WebKitInitializer/WebKitInitializer.cpp:
3447         (getWebViewCLSID): Use new LOG_WARNING macro.
3448         (getInstalledWebKitDirectory): Ditto.
3449         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3450         and use new macros.
3451         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3452
3453 2007-09-26  Adam Roben  <aroben@apple.com>
3454
3455         Committed this file before saving it
3456
3457         * WebKitInitializer/debug_internal.vsprops:
3458
3459 2007-09-26  Adam Roben  <aroben@apple.com>
3460
3461         Load WebKit and its dependencies manually so they come from DllDirectory
3462
3463         I had to change WebKitInitializer to use malloc/free instead of
3464         new/delete to avoid pulling in WebKit (and its dependencies) early
3465         through use of fastMalloc.
3466
3467         Reviewed by Oliver.
3468
3469         * WebKitInitializer/WebKitInitializer.cpp:
3470         (getStringValue): Changed to use malloc/free.
3471         (getInstalledWebKitDirectory): Ditto.
3472         (initializeWebKit): Call SetDllDirectory first, then load all of
3473         WebKit's dependencies manually, finally followed by WebKit itself.
3474         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3475         configuration to match our other projects.
3476         * WebKitInitializer/debug_internal.vsprops: Added.
3477
3478 2007-09-25  Adam Roben  <aroben@apple.com>
3479
3480         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3481
3482         Rubberstamped by Sam.
3483
3484         * WebKitInitializer/WebKitInitializer.vcproj:
3485
3486 2007-09-25  Adam Roben  <aroben@apple.com>
3487
3488         Make DumpRenderTree delay-load its dependencies
3489
3490         This lets WebKitInitializer re-route the dependencies to be loaded out
3491         of the Safari installation directory.
3492
3493         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3494         same thing), since we can't import the kCFAllocatorDefault symbol when
3495         delay-loading CoreFoundation.dll.
3496
3497         Rubberstamped by Sam.
3498
3499         * DumpRenderTree/win/DumpRenderTree.cpp:
3500         (runTest):
3501         (javaScriptThreads):
3502         * DumpRenderTree/win/DumpRenderTree.vcproj:
3503         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3504         (LayoutTestController::setWaitToDump):
3505
3506 2007-09-25  Adam Roben  <aroben@apple.com>
3507
3508         Pull ole32.lib into WebKitInitializer
3509
3510         Rubberstamped by Sam.
3511
3512         * WebKitInitializer/WebKitInitializer.vcproj:
3513
3514 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3515
3516         Reviewed by Adam.
3517
3518         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3519           LGPL'ed files contain incorrect FSF address
3520
3521         * Drosera/config.h:
3522
3523 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3524
3525         Reviewed by Adam.
3526
3527         Make svn-apply and svn-unapply work with git-diff formatted patches.
3528
3529         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3530         (gitdiff2svndiff): Added.
3531         * Scripts/svn-unapply: Ditto.
3532         (gitdiff2svndiff): Added.
3533
3534 2007-09-25  Adam Roben  <aroben@apple.com>
3535
3536         Pull advapi32.lib into WebKitInitializer
3537
3538         This is needed to get the registry functions we use.
3539
3540         Rubberstamped by Sam.
3541
3542         * WebKitInitializer/WebKitInitializer.vcproj:
3543
3544 2007-09-25  Adam Roben  <aroben@apple.com>
3545
3546         Add python and rsync to cygwin-downloader
3547
3548         Our build slaves need this, and it can't hurt for everyone else to
3549         have it, too.
3550
3551         Reviewed by Sam.
3552
3553         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3554         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3555
3556 2007-09-25  Adam Roben  <aroben@apple.com>
3557
3558         Add WebKitInitializer and use it in DumpRenderTree
3559
3560         WebKitInitializer is a static library that has one function,
3561         initializeWebKit(). This registers WebKit and sets up the DLL search
3562         path so that WebKit's dependencies that are installed with Safari can
3563         be found.
3564
3565         Reviewed by Sam.
3566
3567         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3568         DumpRenderTree depend on it.
3569         * DumpRenderTree/win/DumpRenderTree.cpp:
3570         (initialize): Call initializeWebKit.
3571         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
3572         WebKitInitializer.lib.
3573         * WebKitInitializer/WebKitInitializer.cpp: Added.
3574         (getStringValue):
3575         (getWebViewCLSID):
3576         (getInstalledWebKitDirectory):
3577         (initializeWebKit):
3578         * WebKitInitializer/WebKitInitializer.h: Added.
3579         * WebKitInitializer/WebKitInitializer.vcproj: Added.
3580         * WebKitInitializer/debug.vsprops: Added.
3581         * WebKitInitializer/release.vsprops: Added.
3582
3583 2007-09-25  Adam Roben  <aroben@apple.com>
3584
3585         Make run-webkit-tests respect set-webkit-configuration
3586
3587         Reviewed by Sam.
3588
3589         * Scripts/run-webkit-tests: Initialize $configuration to whatever
3590         set-webkit-configuration was last set to.
3591
3592 2007-09-25  Mark Rowe  <mrowe@apple.com>
3593
3594         Rubber-stamped by Eric.
3595
3596         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3597         This makes it possible to automate nightly builds for the feature-branch.
3598
3599 2007-09-25  Adam Roben  <aroben@apple.com>
3600
3601         A couple of fixes/enhancements to update-webkit-*-libs
3602
3603         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
3604         to tell update-webkit-support-libraries where it should find the
3605         WebKitSupportLibrary.zip file you downloaded.
3606
3607         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
3608         Windows-style path.
3609
3610         Reviewed by Sam.
3611
3612         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
3613         to $auxiliaryLibsURL and removed an irrelevant comment.
3614         * Scripts/update-webkit-support-libs:
3615
3616 2007-09-25  Adam Treat  <treat@kde.org>
3617
3618         Reviewed by Simon and Lars.
3619
3620         Refactors and cleans up Qt DRT member variable names, member variable
3621         initialization, style fixes and general code cleanup.
3622
3623         Adds queueReload slot to LayoutTestController that some tests require.
3624
3625         Subclasses QWebFrame to make sure that all frames have an associated
3626         LayoutTestController JS window object.
3627
3628         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
3629         aren't dumped twice.
3630
3631         EOF fixes.
3632
3633         Together, this patch fixes some 20+ layout tests in QtWebKit.
3634
3635         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3636         (WebCore::WebFrame::WebFrame):
3637         (WebCore::WebPage::WebPage):
3638         (WebCore::WebPage::createFrame):
3639         (WebCore::DumpRenderTree::DumpRenderTree):
3640         (WebCore::DumpRenderTree::open):
3641         (WebCore::DumpRenderTree::readStdin):
3642         (WebCore::DumpRenderTree::initJSObjects):
3643         (WebCore::DumpRenderTree::dump):
3644         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3645         (WebCore::DumpRenderTree::layoutTestController):
3646         (WebCore::DumpRenderTree::eventSender):
3647         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3648         (LayoutTestController::LayoutTestController):
3649         (LayoutTestController::reset):
3650         (LayoutTestController::maybeDump):
3651         (LayoutTestController::waitUntilDone):
3652         (LayoutTestController::notifyDone):
3653         (LayoutTestController::queueReload):
3654         (LayoutTestController::provisionalLoad):
3655         (EventSender::EventSender):
3656         (EventSender::mouseDown):
3657         (EventSender::mouseUp):
3658         (EventSender::mouseMoveTo):
3659         (EventSender::frameUnderMouse):
3660         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3661         (LayoutTestController::isLoading):
3662         (LayoutTestController::setLoading):
3663         (LayoutTestController::dumpAsText):
3664         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3665         (main):
3666
3667 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3668
3669
3670         - Reverted an accidentally checked in file.
3671
3672         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3673
3674 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3675         Reviewed by Sam.
3676
3677         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
3678
3679         * DumpRenderTree/win/DumpRenderTree.vcproj:
3680         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3681
3682 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3683
3684         Rubber stamped by Adam.
3685
3686         * GdkLauncher: Removed.
3687         * GdkLauncher/Bakefiles.bkgen: Removed.
3688         * GdkLauncher/ENV: Removed.
3689         * GdkLauncher/GdkLauncher.pro: Removed.
3690         * GdkLauncher/gdklauncher.bkl: Removed.
3691         * GdkLauncher/main.cpp: Removed.
3692         * GdkLauncher/mk: Removed.
3693         * GdkLauncher/simple.svg: Removed.
3694         * GdkLauncher/text.html: Removed.
3695         * GtkLauncher: Added.
3696         * GtkLauncher/GdkLauncher.pro: Removed.
3697         * GtkLauncher/GtkLauncher.pro: Added.
3698         * GtkLauncher/main.cpp:
3699         (updateWindowTitle):
3700         (main):
3701         * Scripts/build-webkit:
3702         * Scripts/regenerate-makefiles:
3703         * Scripts/run-javascriptcore-tests:
3704         * Scripts/run-launcher:
3705         * Scripts/run-webkit-tests:
3706         * Scripts/webkitdirs.pm:
3707
3708 2007-09-21  Timothy Hatcher  <timothy@apple.com>
3709
3710         Reviewed by Darin.
3711
3712         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3713
3714         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
3715         This is tested by plugins/root-object-premature-delete-crash.html.
3716
3717         * DumpRenderTree/mac/ObjCController.m:
3718         (-[ObjCController accessStoredWebScriptObject]):
3719
3720 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
3721
3722         Reviewed by Oliver.
3723
3724         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
3725
3726         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3727         (FrameLoadDelegate::FrameLoadDelegate):
3728
3729 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
3730
3731         Reviewed by Adam.
3732
3733         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
3734         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
3735
3736         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
3737         Now isQt() and isGdk() use global variables that are only set once.
3738
3739         An array of all the parameters is now given to build-dumprender which includes
3740         the platform on linux.
3741
3742         * Scripts/build-dumprendertree:
3743         * Scripts/run-webkit-tests:
3744         * Scripts/webkitdirs.pm:
3745
3746 2007-09-19  Adam Roben  <aroben@apple.com>
3747
3748         Rubberstamped by Hyatt.
3749
3750         * Spinneret: Removed.
3751
3752 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
3753
3754         Reviewed by David Kilzer.
3755
3756         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
3757
3758 2007-09-18  Sam Weinig  <sam@webkit.org>
3759
3760         Add JSRetainPtr.h #include to fix some builds.
3761
3762         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3763
3764 2007-09-18  Mike Hommey  <glandium@debian.org>
3765
3766         Reviewed by Adam.
3767
3768         * Scripts/prepare-ChangeLog:
3769         - Properly parse GECOS field.
3770         - Use git configuration for user name and email when appropriate.
3771
3772 2007-09-17  Sam Weinig  <sam@webkit.org>
3773
3774         Build fix.
3775
3776         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3777
3778 2007-09-17  Sam Weinig  <sam@webkit.org>
3779
3780         Reviewed by Adam Roben.
3781
3782         Share more code between mac and windows DRT.
3783             - GCController is now shared.
3784             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
3785
3786         * DumpRenderTree/GCController.cpp:
3787         * DumpRenderTree/win/DumpRenderTree.cpp:
3788         * DumpRenderTree/win/DumpRenderTree.vcproj:
3789         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
3790         (FrameLoadDelegate::FrameLoadDelegate):
3791         (FrameLoadDelegate::~FrameLoadDelegate):
3792         (FrameLoadDelegate::windowScriptObjectAvailable):
3793         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
3794         * DumpRenderTree/win/GCController.cpp: Removed.
3795         * DumpRenderTree/win/GCController.h: Removed.
3796         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
3797         (GCController::collect):
3798         (GCController::collectOnAlternateThread):
3799         (GCController::getJSObjectCount):
3800         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
3801         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
3802
3803 2007-09-17  Sam Weinig  <sam@webkit.org>
3804
3805         Reviewed by Adam Roben.
3806
3807         Begin sharing code between mac and windows DRT.
3808             - both now share LayoutTestController.h/cpp and implement platform dependant 
3809               operations in LayoutTestControllerMac/Win.
3810             - DumpRenderTree.h is now shared.
3811             - WorkQueue and WorkQueueItem are also shared.
3812
3813         * DumpRenderTree/DumpRenderTree.h:
3814         * DumpRenderTree/LayoutTestController.cpp:
3815         * DumpRenderTree/win/DumpRenderTree.cpp:
3816         (displayWebView):
3817         (dumpFrameScrollPosition):
3818         (dumpFramesAsText):
3819         (dump):
3820         (runTest):
3821         * DumpRenderTree/win/DumpRenderTree.h: Removed.
3822         * DumpRenderTree/win/DumpRenderTree.vcproj:
3823         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
3824         * DumpRenderTree/win/EditingDelegate.cpp:
3825         (EditingDelegate::shouldBeginEditingInDOMRange):
3826         (EditingDelegate::shouldEndEditingInDOMRange):
3827         (EditingDelegate::shouldInsertNode):
3828         (EditingDelegate::shouldInsertText):
3829         (EditingDelegate::shouldDeleteDOMRange):
3830         (EditingDelegate::shouldChangeSelectedDOMRange):
3831         (EditingDelegate::shouldApplyStyle):
3832         (EditingDelegate::shouldChangeTypingStyle):
3833         (EditingDelegate::doPlatformCommand):
3834         (EditingDelegate::webViewDidBeginEditing):
3835         (EditingDelegate::webViewDidChange):
3836         (EditingDelegate::webViewDidEndEditing):
3837         (EditingDelegate::webViewDidChangeTypingStyle):
3838         (EditingDelegate::webViewDidChangeSelection):
3839         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
3840         * DumpRenderTree/win/LayoutTestController.h: Removed.
3841         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
3842         (LayoutTestController::addDisallowedURL):
3843         (LayoutTestController::clearBackForwardList):
3844         (LayoutTestController::copyDecodedHostName):
3845         (LayoutTestController::copyEncodedHostName):
3846         (LayoutTestController::display):
3847         (LayoutTestController::keepWebHistory):
3848         (LayoutTestController::notifyDone):
3849         (LayoutTestController::queueBackNavigation):
3850         (LayoutTestController::queueForwardNavigation):
3851         (jsStringRefToWString):
3852         (LayoutTestController::queueLoad):
3853         (LayoutTestController::queueReload):
3854         (LayoutTestController::queueScript):
3855         (LayoutTestController::setAcceptsEditing):
3856         (LayoutTestController::setCustomPolicyDelegate):
3857         (LayoutTestController::setMainFrameIsFirstResponder):
3858         (LayoutTestController::setTabKeyCyclesThroughElements):
3859         (LayoutTestController::setUseDashboardCompatibilityMode):
3860         (LayoutTestController::setUserStyleSheetEnabled):
3861         (LayoutTestController::setUserStyleSheetLocation):
3862         (LayoutTestController::setWindowIsKey):
3863         (waitUntilDoneWatchdogFired):
3864         (LayoutTestController::setWaitToDump):
3865         (LayoutTestController::windowCount):
3866         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
3867         (FrameLoadDelegate::didReceiveTitle):
3868         (FrameLoadDelegate::processWork):
3869         (FrameLoadDelegate::locationChangeDone):
3870         (FrameLoadDelegate::windowScriptObjectAvailable):
3871         * DumpRenderTree/win/WorkQueue.cpp: Removed.
3872         * DumpRenderTree/win/WorkQueue.h: Removed.
3873         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
3874         * DumpRenderTree/win/WorkQueueItem.h: Removed.
3875         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
3876         (jsStringRefToWString):
3877         (LoadItem::invoke):
3878         (ScriptItem::invoke):
3879
3880 2007-09-17  Sam Weinig  <sam@webkit.org>
3881
3882         Reviewed by Adam Roben.
3883
3884         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
3885
3886         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
3887         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
3888         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
3889         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
3890         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
3891         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
3892         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
3893         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
3894         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
3895         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
3896         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
3897         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
3898         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
3899         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
3900         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
3901         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
3902         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
3903         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
3904         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
3905         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
3906         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
3907         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
3908         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
3909         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
3910         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
3911         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
3912         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
3913         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
3914         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
3915         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
3916         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
3917         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
3918         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
3919         * DumpRenderTree/win: Added.
3920         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
3921         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
3922         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
3923         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
3924         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
3925         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
3926         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
3927         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
3928         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
3929         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
3930         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
3931         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
3932         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
3933         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3934         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
3935         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
3936         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
3937         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
3938         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3939         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3940         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
3941         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3942         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
3943         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
3944         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
3945         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
3946
3947 2007-09-15  Mark Rowe  <mrowe@apple.com>
3948
3949         Build fix for DumpRenderTree.
3950
3951         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
3952
3953 2007-09-14  Sam Weinig  <sam@webkit.org>
3954
3955         Rubber stamped by Adam Roben.
3956
3957         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
3958           - The UIDelegate was put into a new file while the FrameLoadDelegate was
3959             kept in the WaitUntilDoneDelegate file for the time being.
3960
3961         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3962         (main):
3963         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
3964         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
3965         (UIDelegate::QueryInterface):
3966         (UIDelegate::AddRef):
3967         (UIDelegate::Release):
3968         (UIDelegate::hasCustomMenuImplementation):
3969         (UIDelegate::setFrame):
3970         (UIDelegate::webViewFrame):
3971         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3972         (UIDelegate::webViewAddMessageToConsole):
3973         (UIDelegate::doDragDrop):
3974         (UIDelegate::webViewGetDlgCode):
3975         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
3976         (UIDelegate::UIDelegate):
3977         (UIDelegate::createWebViewWithRequest):
3978         (UIDelegate::webViewShow):
3979         (UIDelegate::webViewClose):
3980         (UIDelegate::webViewFocus):
3981         (UIDelegate::webViewUnfocus):
3982         (UIDelegate::webViewFirstResponder):
3983         (UIDelegate::makeFirstResponder):
3984         (UIDelegate::setStatusText):
3985         (UIDelegate::webViewStatusText):
3986         (UIDelegate::webViewAreToolbarsVisible):
3987         (UIDelegate::setToolbarsVisible):
3988         (UIDelegate::webViewIsStatusBarVisible):
3989         (UIDelegate::setStatusBarVisible):
3990         (UIDelegate::webViewIsResizable):
3991         (UIDelegate::setResizable):
3992         (UIDelegate::setContentRect):
3993         (UIDelegate::webViewContentRect):
3994         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3995         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3996         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3997         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
3998         (UIDelegate::mouseDidMoveOverElement):
3999         (UIDelegate::contextMenuItemsForElement):
4000         (UIDelegate::validateUserInterfaceItem):
4001         (UIDelegate::shouldPerformAction):
4002         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
4003         (UIDelegate::willPerformDragDestinationAction):
4004         (UIDelegate::dragSourceActionMaskForPoint):
4005         (UIDelegate::willPerformDragSourceAction):
4006         (UIDelegate::contextMenuItemSelected):
4007         (UIDelegate::trackCustomPopupMenu):
4008         (UIDelegate::measureCustomMenuItem):
4009         (UIDelegate::drawCustomMenuItem):
4010         (UIDelegate::addCustomMenuDrawingData):
4011         (UIDelegate::cleanUpCustomMenuDrawingData):
4012         (UIDelegate::canTakeFocus):
4013         (UIDelegate::takeFocus):
4014         (UIDelegate::registerUndoWithTarget):
4015         (UIDelegate::removeAllActionsWithTarget):
4016         (UIDelegate::setActionTitle):
4017         (UIDelegate::undo):
4018         (UIDelegate::redo):
4019         (UIDelegate::canUndo):
4020         (UIDelegate::canRedo):
4021         (UIDelegate::webViewResizerRect):
4022         (UIDelegate::webViewDrawResizer):
4023         (UIDelegate::webViewScrolled):
4024         (UIDelegate::webViewShouldInterruptJavaScript):
4025         (UIDelegate::webViewReceivedFocus):
4026         (UIDelegate::webViewLostFocus):
4027         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
4028         (FrameLoadDelegate::QueryInterface):
4029         (FrameLoadDelegate::AddRef):
4030         (FrameLoadDelegate::Release):
4031         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
4032         (FrameLoadDelegate::didCommitLoadForFrame):
4033         (FrameLoadDelegate::didReceiveTitle):
4034         (FrameLoadDelegate::processWork):
4035         (processWorkTimer):
4036         (FrameLoadDelegate::locationChangeDone):
4037         (FrameLoadDelegate::didFinishLoadForFrame):
4038         (FrameLoadDelegate::didFailLoadWithError):
4039         (FrameLoadDelegate::windowScriptObjectAvailable):
4040         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
4041         (FrameLoadDelegate::FrameLoadDelegate):
4042
4043 2007-09-14  Sam Weinig  <sam@webkit.org>
4044
4045         Reviewed by Kevin McCullough.
4046
4047         Move mac specific globals in to mac/DumpRenderTreeMac.h
4048
4049         * DumpRenderTree/DumpRenderTree.h:
4050         * DumpRenderTree/DumpRenderTree.mm: Removed.
4051         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4052         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
4053         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
4054
4055 2007-09-14  Brady Eidson  <beidson@apple.com>
4056
4057         Rubberstamped by Weinig
4058
4059         You know, Sam, some of us use case-sensitve filesystems...
4060
4061         * DumpRenderTree/DumpRenderTree.h:
4062         * DumpRenderTree/mac/UIDelegate.mm:
4063
4064 2007-09-14  Sam Weinig  <sam@webkit.org>
4065
4066         Rubber stamped by Adam Roben.
4067
4068         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
4069         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
4070
4071         * DumpRenderTree/AppleScriptController.h: Removed.
4072         * DumpRenderTree/AppleScriptController.m: Removed.
4073         * DumpRenderTree/DumpRenderTree.h:
4074         * DumpRenderTree/DumpRenderTree.mm:
4075         (startJavaScriptThreads):
4076         (stopJavaScriptThreads):
4077         (activateAhemFont):
4078         (setDefaultColorProfileToRGB):
4079         (makeLargeMallocFailSilently):
4080         (dumpFrameScrollPosition):
4081         (dumpFramesAsText):
4082         (dump):
4083         (runTest):
4084         (-[DumpRenderTreeWindow isKeyWindow]):
4085         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4086         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
4087         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
4088         * DumpRenderTree/EditingDelegate.h: Removed.
4089         * DumpRenderTree/EditingDelegate.m: Removed.
4090         * DumpRenderTree/EventSendingController.h: Removed.
4091         * DumpRenderTree/EventSendingController.m: Removed.
4092         * DumpRenderTree/FrameLoadDelegate.h: Removed.
4093         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
4094         * DumpRenderTree/GCController.mm: Removed.
4095         * DumpRenderTree/ImageDiff.m: Removed.
4096         * DumpRenderTree/LayoutTestController.cpp:
4097         (LayoutTestController::LayoutTestController):
4098         (dumpAsTextCallback):
4099         (dumpBackForwardListCallback):
4100         (dumpChildFramesAsTextCallback):
4101         (dumpChildFrameScrollPositionsCallback):
4102         (dumpDOMAsWebArchiveCallback):
4103         (dumpEditingCallbacksCallback):
4104         (dumpFrameLoadCallbacksCallback):
4105         (dumpResourceLoadCallbacksCallback):
4106         (dumpSelectionRectCallback):
4107         (dumpSourceAsWebArchiveCallback):
4108         (dumpTitleChangesCallback):
4109         (repaintSweepHorizontallyCallback):
4110         (setCallCloseOnWebViewsCallback):
4111         (setCanOpenWindowsCallback):
4112         (setCloseRemainingWindowsWhenCompleteCallback):
4113         (testRepaintCallback):
4114         (addFileToPasteboardOnDragCallback):
4115         (waitUntilDoneCallback):
4116         * DumpRenderTree/LayoutTestController.h:
4117         (LayoutTestController::dumpAsText):
4118         (LayoutTestController::setDumpAsText):
4119         (LayoutTestController::dumpBackForwardList):
4120         (LayoutTestController::setDumpBackForwardList):
4121         (LayoutTestController::dumpChildFrameScrollPositions):
4122         (LayoutTestController::setDumpChildFrameScrollPositions):
4123         (LayoutTestController::dumpChildFramesAsText):
4124         (LayoutTestController::setDumpChildFramesAsText):
4125         (LayoutTestController::dumpDOMAsWebArchive):
4126         (LayoutTestController::setDumpDOMAsWebArchive):
4127         (LayoutTestController::dumpSelectionRect):
4128         (LayoutTestController::setDumpSelectionRect):
4129         (LayoutTestController::dumpSourceAsWebArchive):
4130         (LayoutTestController::setDumpSourceAsWebArchive):
4131         (LayoutTestController::dumpTitleChanges):
4132         (LayoutTestController::setDumpTitleChanges):
4133         (LayoutTestController::dumpEditingCallbacks):
4134         (LayoutTestController::setDumpEditingCallbacks):
4135         (LayoutTestController::dumpResourceLoadCallbacks):
4136         (LayoutTestController::setDumpResourceLoadCallbacks):
4137         (LayoutTestController::dumpFrameLoadCallbacks):
4138         (LayoutTestController::setDumpFrameLoadCallbacks):
4139         (LayoutTestController::addFileToPasteboardOnDrag):
4140         (LayoutTestController::setAddFileToPasteboardOnDrag):
4141         (LayoutTestController::callCloseOnWebViews):
4142         (LayoutTestController::setCallCloseOnWebViews):
4143         (LayoutTestController::canOpenWindows):
4144         (LayoutTestController::setCanOpenWindows):
4145         (LayoutTestController::closeRemainingWindowsWhenComplete):
4146         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
4147         (LayoutTestController::testRepaint):
4148         (LayoutTestController::setTestRepaint):
4149         (LayoutTestController::testRepaintSweepHorizontally):
4150         (LayoutTestController::setTestRepaintSweepHorizontally):
4151         (LayoutTestController::waitToDump):
4152         (LayoutTestController::windowIsKey):
4153         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
4154         * DumpRenderTree/NavigationController.h: Removed.
4155         * DumpRenderTree/NavigationController.m: Removed.
4156         * DumpRenderTree/ObjCController.h: Removed.
4157         * DumpRenderTree/ObjCController.m: Removed.
4158         * DumpRenderTree/ObjCPlugin.h: Removed.
4159         * DumpRenderTree/ObjCPlugin.m: Removed.
4160         * DumpRenderTree/ObjCPluginFunction.h: Removed.
4161         * DumpRenderTree/ObjCPluginFunction.m: Removed.
4162         * DumpRenderTree/PolicyDelegate.h: Removed.
4163         * DumpRenderTree/PolicyDelegate.m: Removed.
4164         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
4165         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
4166         * DumpRenderTree/TextInputController.h: Removed.
4167         * DumpRenderTree/TextInputController.m: Removed.
4168         * DumpRenderTree/UIDelegate.h: Removed.
4169         * DumpRenderTree/UIDelegate.mm: Removed.
4170         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
4171         * DumpRenderTree/mac: Added.
4172         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
4173         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
4174         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
4175         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
4176         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
4177         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
4178         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
4179         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
4180         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
4181         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
4182         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
4183         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
4184         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
4185         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
4186         (-[EditingDelegate webViewDidBeginEditing:]):
4187         (-[EditingDelegate webViewDidChange:]):
4188         (-[EditingDelegate webViewDidEndEditing:]):
4189         (-[EditingDelegate webViewDidChangeTypingStyle:]):
4190         (-[EditingDelegate webViewDidChangeSelection:]):
4191         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
4192         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
4193         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
4194         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
4195         (-[FrameLoadDelegate init]):
4196         (-[FrameLoadDelegate dealloc]):
4197         (-[FrameLoadDelegate processWork:]):
4198         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
4199         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
4200         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
4201         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
4202         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
4203         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
4204         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
4205         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
4206         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
4207         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
4208         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
4209         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
4210         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
4211         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
4212         (-[FrameLoadDelegate webView:willCloseFrame:]):
4213         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
4214         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
4215         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
4216         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
4217         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
4218         (LayoutTestController::notifyDone):
4219         (LayoutTestController::setWindowIsKey):
4220         (LayoutTestController::setWaitToDump):
4221         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
4222         *