c9cc356518c0ec1ac637926372e99288f367ccf5
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-07  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Anders Carlsson.
4
5         Change API tester to ask the executable for the list of all
6         tests instead of relying on the directory structure.
7         https://bugs.webkit.org/show_bug.cgi?id=47359
8
9         * Scripts/run-test-webkit-api: Added.
10         * Scripts/webkitdirs.pm:
11         Add additional script to just launch the api tester with the correct settings.
12
13         * Scripts/run-api-tests:
14         Change to use the new --dump-tests options to build the list of tests and change
15         output to reflect a (suite, testcase) tuple for each test. Also adds some color.
16
17         * TestWebKitAPI/Test.h:
18         (TestWebKitAPI::Test::Register::Register):
19         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
20         (TestWebKitAPI::TEST):
21         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
22         (TestWebKitAPI::TEST):
23         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
24         (TestWebKitAPI::TEST):
25         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
26         (TestWebKitAPI::TEST):
27         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
28         (TestWebKitAPI::TEST):
29         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
30         (TestWebKitAPI::TEST):
31         Give each test a suite name in addition to the test name.
32
33         * TestWebKitAPI/TestsController.cpp:
34         (TestWebKitAPI::TestsController::dumpTestNames):
35         (TestWebKitAPI::TestsController::runTestNamed):
36         * TestWebKitAPI/TestsController.h:
37         * TestWebKitAPI/mac/main.mm:
38         (main):
39         Add option to print all registered tests.
40
41 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
42
43         Reviewed by Kenneth Rohde Christiansen.
44
45         [Qt] Add WTR's InjectedBundle build files.
46         https://bugs.webkit.org/show_bug.cgi?id=47333
47
48         * Scripts/webkitdirs.pm:
49         * WebKitTestRunner/DerivedSources.pro: Added.
50         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
51         * WebKitTestRunner/WebKitTestRunner.pro: Added.
52         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
53         Content merged in ../DerivedSources.pro
54
55 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
56
57         Unreviewed. Do a renaming that was recommended by the reviewer
58         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
59
60         * WebKitTestRunner/qt/TestControllerQt.cpp:
61         (WTR::RunUntilConditionLoop::start):
62         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
63         (WTR::TestController::runUntil):
64
65 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
66
67         Reviewed by Kenneth Rohde Christiansen.
68
69         [Qt] Watchdog timer implementation for WTR
70         https://bugs.webkit.org/show_bug.cgi?id=47337
71
72         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
73         the definition of the timer type to a typedef.
74         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
75         Timer implementation with QTimer and a helper QObject class.
76         (WTR::WatchdogTimerHelper::instance):
77         (WTR::WatchdogTimerHelper::timerFired):
78         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
79         (WTR::LayoutTestController::platformInitialize):
80         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
81         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
82
83 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
84
85         Unreviewed buildfix for 69297 again
86
87         * WebKitTestRunner/TestController.cpp:
88         (WTR::blankURL):
89
90 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
91
92         Unreviewed trivial build fix for r69297
93
94         * WebKitTestRunner/TestController.cpp:
95         (WTR::blankURL):
96
97 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
98
99         Reviewed by Kenneth Rohde Christiansen.
100
101         WebKitTestRunner should be portable
102         https://bugs.webkit.org/show_bug.cgi?id=45393
103
104         Use only the WebKit API for working with urls.
105         * WebKitTestRunner/StringFunctions.h:
106         (WTR::createWKURL):
107         * WebKitTestRunner/TestController.cpp:
108         (WTR::blankURL):
109         (WTR::TestController::resetStateToConsistentValues):
110         (WTR::TestController::didFinishLoadForFrame):
111
112 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
113
114         Reviewed by Xan Lopez.
115
116         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
117         https://bugs.webkit.org/show_bug.cgi?id=47332
118
119         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
120         (createBitmapContextFromWebView):
121
122 2010-10-06  Chris Guillory  <chris.guillory@google.com>
123
124         Reviewed by Chris Fleizach.
125
126         Remove unused accessibility functions from webkit.
127         https://bugs.webkit.org/attachment.cgi?bugid=46707
128
129         * DumpRenderTree/chromium/WebViewHost.cpp:
130         (WebViewHost::postAccessibilityNotification):
131         * DumpRenderTree/chromium/WebViewHost.h:
132
133 2010-10-06  Lucas Forschler  <lforschler@apple.com>
134
135         Reviewed by Adam Roben.
136
137         Fix the sunspider-compare-results to actually use the passed in value for $root.
138
139         * Scripts/sunspider-compare-results:
140
141 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
142
143         Reviewed by Kenneth Rohde Christiansen.
144
145         [Qt] Runloop implementation for WTR
146         https://bugs.webkit.org/show_bug.cgi?id=47280
147
148         * WebKitTestRunner/qt/TestControllerQt.cpp:
149         Implemented TestController::runUntil by a timerEvent
150         and a QEventLoop. We step into the event loop from runUntil.
151         While we are waiting in the loop a timerEvent is periodically
152         checking the value of the condition. Once the condition has
153         becoming true the timerEvent wakes us up.
154         (WTR::RunUntilLoop::start):
155         (WTR::RunUntilLoop::RunUntilLoop):
156         (WTR::RunUntilLoop::run):
157         (WTR::RunUntilLoop::timerEvent):
158         (WTR::TestController::platformInitialize):
159         (WTR::TestController::runUntil):
160         * WebKitTestRunner/qt/main.cpp:
161         Start the main event loop first and creating the TestController later.
162         (Launcher::Launcher):
163         (Launcher::~Launcher):
164         (Launcher::launch): Creating the TestController.
165         (main): Setting up a timer for calling Launcher::launch from
166         the main event loop.
167
168 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
169
170         Reviewed by Kenneth Russell.
171
172         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
173         enable 'accelerated-composting' instead of 'accelerated-compositing'.
174
175         https://bugs.webkit.org/show_bug.cgi?id=47312
176
177         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
178         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
179
180 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
181
182         Reviewed by Kenneth Rohde Christiansen.
183
184         [Qt] PlatformWebView implementation for WebKitTestRunner
185         https://bugs.webkit.org/show_bug.cgi?id=47276
186
187         The implementation follows the way how
188         we use the API in MiniBrowser.
189         * WebKitTestRunner/PlatformWebView.h:
190         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
191         (WTR::WebView::wkView):
192         (WTR::WebView::~WebView):
193         (WTR::WebView::WebView):
194         (WTR::PlatformWebView::PlatformWebView):
195         (WTR::PlatformWebView::~PlatformWebView):
196         (WTR::PlatformWebView::resizeTo):
197         (WTR::PlatformWebView::page):
198         (WTR::PlatformWebView::focus):
199         * WebKitTestRunner/qt/WebKitTestRunner.pro:
200
201 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
202
203         Reviewed by Kenneth Rohde Christiansen.
204
205         [Qt] Add WebKitTestRunner's build files
206         https://bugs.webkit.org/show_bug.cgi?id=44155
207
208         Parts was taken by Zoltan Horvath's patch.
209
210         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
211         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
212         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
213         PlatformWKView and PlatformWindow (void* for now).
214         Buildfix the case when __APPLE__ is not defined.
215         * WebKitTestRunner/qt/DerivedSources.pro: Added.
216         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
217         Empty stub implementation.
218         (WTR::registerWindowClass):
219         (WTR::PlatformWebView::PlatformWebView):
220         (WTR::PlatformWebView::~PlatformWebView):
221         (WTR::PlatformWebView::resizeTo):
222         (WTR::PlatformWebView::page):
223         (WTR::PlatformWebView::focus):
224         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
225         Empty stub implementation.
226         (WTR::registerWindowClass):
227         (WTR::TestController::runUntil):
228         (WTR::TestController::platformInitialize):
229         (WTR::TestController::initializeInjectedBundlePath):
230         (WTR::TestController::initializeTestPluginDirectory):
231         (WTR::TestController::platformInitializeContext):
232         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
233         * WebKitTestRunner/qt/main.cpp: Added.
234         (main):
235
236 2010-10-06  Tony Chang  <tony@chromium.org>
237
238         Unreviewed, rolling out r69202.
239         http://trac.webkit.org/changeset/69202
240         https://bugs.webkit.org/show_bug.cgi?id=46937
241
242         Broke compile of test_shell
243
244         * DumpRenderTree/chromium/EventSender.cpp:
245         (EventSender::beginDragWithFiles):
246         * DumpRenderTree/chromium/WebViewHost.cpp:
247         (addDRTFakeFileToDataObject):
248
249 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
250
251         Reviewed by Tony Chang.
252
253         [chromium] Minor naming cleanup in WebDragData, part 2
254         https://bugs.webkit.org/show_bug.cgi?id=46937
255
256         Update DRT to use the renamed methods.
257
258         * DumpRenderTree/chromium/EventSender.cpp:
259         (EventSender::beginDragWithFiles):
260         * DumpRenderTree/chromium/WebViewHost.cpp:
261         (addDRTFakeFileToDataObject):
262
263 2010-10-06  David Kilzer  <ddkilzer@apple.com>
264
265         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
266
267         Reviewed by Adam Roben.
268
269         This is the first step in making webarchive tests work on
270         Windows.
271
272         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
273         new files to the project.
274         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
275         to WebArchiveDumpSupport.mm.
276         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
277         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
278         (serializeWebArchiveToXML):
279
280 2010-10-05  Daniel Bates  <dbates@rim.com>
281
282         Reviewed by David Kilzer.
283
284         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
285         https://bugs.webkit.org/show_bug.cgi?id=46058
286
287         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
288         structure so as to support returning additional information
289         about a change log diff.
290
291         Currently, VCSUtils::fixChangeLogPatch() returns a string that
292         represents the change log diff. Towards supporting the return
293         of additional information, such as whether the change log diff
294         inserts an entry at the top of the ChangeLog file, we need to
295         make VCSUtils::fixChangeLogPatch() return a reference to hash
296         structure.
297
298         * Scripts/VCSUtils.pm:
299           - Modified fixChangeLogPatch() to return a reference to a
300             hash structure.
301           - Added documentation to fixChangeLogPatch().
302           - Modified call site in mergeChangeLogs() as necessary.
303         * Scripts/svn-apply:
304           - Modified call site in patch() as necessary.
305         * Scripts/svn-create-patch:
306           - Modified call site in generateDiff() as necessary.
307         * Scripts/svn-unapply:
308           - Modified call site in patch() as necessary.
309         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
310           - Modified the unit tests as necessary.
311
312 2010-10-05  Tony Chang  <tony@chromium.org>
313
314         Reviewed by Darin Adler.
315
316         fix the link to the expected image on windows
317         https://bugs.webkit.org/show_bug.cgi?id=47228
318
319         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
320             windows, the file must be opened in binary mode when writing
321             binary data.
322
323 2010-10-05  Adam Barth  <abarth@webkit.org>
324
325         Update expected result of unittest to match Tony's change below.
326
327         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
328
329 2010-10-05  Tony Chang  <tony@chromium.org>
330
331         Reviewed by Ojan Vafai (over the shoulder).
332
333         Paper over errors in image_diff so we don't crash the whole test run.
334
335         * Scripts/webkitpy/layout_tests/port/chromium.py:
336
337 2010-10-05  Tony Chang  <tony@chromium.org>
338
339         Unreviewed, make shutil.rmtree more resiliant to errors
340         since windows was raising WindowsError: The process cannot access the file because it
341         is being used by another process.
342
343         * Scripts/webkitpy/layout_tests/port/chromium.py:
344
345 2010-10-05  Tony Chang  <tony@chromium.org>
346
347         Reviewed by Ojan Vafai.
348
349         [chromium] fix image diffing in NRWT
350         https://bugs.webkit.org/show_bug.cgi?id=47128
351
352         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
353             NamedTemporaryFile since it doesn't work on Windows.
354         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
355
356 2010-10-05  Kenneth Russell  <kbr@google.com>
357
358         Reviewed by Tony Chang.
359
360         [chromium] Implement layerTreeAsText in DumpRenderTree
361         https://bugs.webkit.org/show_bug.cgi?id=47216
362
363         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
364         make it callable from DumpRenderTree.
365
366         No new tests; verified with existing compositor layout tests.
367
368         * DumpRenderTree/chromium/LayoutTestController.cpp:
369         (LayoutTestController::LayoutTestController):
370         (LayoutTestController::layerTreeAsText):
371         * DumpRenderTree/chromium/LayoutTestController.h:
372
373 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
374
375         Unreviewed build correction.
376
377         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
378         property sheet so proper libraries are linked.
379
380 2010-10-05  Robert Hogan  <robert@webkit.org>
381
382         Reviewed by Andreas Kling.
383
384         [Qt] Fix url conversion in QWebHistory
385
386         Converting from KURL to WFT::String to QUrl does not
387         permit proper percent encoding later.
388
389         https://bugs.webkit.org/show_bug.cgi?id=47048
390
391         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
392         (WebCore::dumpHistoryItem):
393
394 2010-10-05  Anders Carlsson  <andersca@apple.com>
395
396         Reviewed by Sam Weinig.
397
398         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
399         https://bugs.webkit.org/show_bug.cgi?id=47188
400         <rdar://problem/8514104>
401
402         When constructing the std::string, use the real string length instead of the maximum buffer size.
403
404         * TestWebKitAPI/PlatformUtilities.h:
405         (TestWebKitAPI::Util::toSTD):
406         * WebKitTestRunner/StringFunctions.h:
407         (WTR::toSTD):
408
409 2010-10-04  Sam Weinig  <sam@webkit.org>
410
411         Reviewed by Mark Rowe.
412
413         Add MIMEType accessor to WKFrame
414         <rdar://problem/8347683>
415         https://bugs.webkit.org/show_bug.cgi?id=47138
416
417         * TestWebKitAPI/PlatformUtilities.h:
418         (TestWebKitAPI::Util::toSTD):
419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
420         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
421         (TestWebKitAPI::didStartProvisionalLoadForFrame):
422         (TestWebKitAPI::didCommitLoadForFrame):
423         (TestWebKitAPI::didFinishLoadForFrame):
424         (TestWebKitAPI::TEST):
425         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
426         (TestWebKitAPI::didStartProvisionalLoadForFrame):
427         (TestWebKitAPI::didCommitLoadForFrame):
428         (TestWebKitAPI::didFinishLoadForFrame):
429         (TestWebKitAPI::TEST):
430         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
431         (TestWebKitAPI::TEST):
432         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
433         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
434         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
435         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
436         (TestWebKitAPI::Util::createURLForResource):
437
438 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
439
440         Reviewed by Ojan Vafai.
441
442         [NRWT] Rename current_dir to current_group because it's not a directory
443         https://bugs.webkit.org/show_bug.cgi?id=47169
444
445         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
446         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
447
448 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
449
450         Unreviewed, build fix.
451
452         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
453         which can't always be done. This test uses tempfile.mkdtemp(), which
454         should be safe.
455
456         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
457
458 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
459
460         Unreviewed, build fix.
461
462         Add missing "from __future__ import with_statement" that was
463         breaking test-webkitpy on the Leopard bots (broke in r69040).
464
465         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
466
467 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
468
469         Unreviewed, rolling out r69066.
470         http://trac.webkit.org/changeset/69066
471         https://bugs.webkit.org/show_bug.cgi?id=47163
472
473         Made NRWT reliability worse. (Requested by tkent on #webkit).
474
475         * Scripts/webkitpy/layout_tests/port/chromium.py:
476         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
477
478 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
479
480         Reviewed by Tony Chang.
481
482         [NRWT] Reverse the http tests to alphabetical order.
483         https://bugs.webkit.org/show_bug.cgi?id=47075
484
485         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
486
487 2010-10-04  Robert Hogan  <robert@webkit.org>
488
489         Reviewed by Andreas Kling.
490
491         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
492
493         We need to queue back and forward navigations in the DRT from the
494         LayoutTestController so that maybeDump() knows about them.
495
496         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
497         (LayoutTestController::queueBackNavigation):
498         (LayoutTestController::queueForwardNavigation):
499
500 2010-10-04  Tony Chang  <tony@chromium.org>
501
502         Reviewed by Kent Tamura.
503
504         [chromium] fix image diffing in NRWT
505         https://bugs.webkit.org/show_bug.cgi?id=47128
506
507         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
508               temp file and check the image_diff error code more carefully
509         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
510
511 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
512
513         Reviewed by Adam Barth.
514
515         aroben's change in r68792 actually broke new-run-webkit-tests when
516         running the DRT code path. His change was intended to fix the
517         way we were converting windows paths to URIs when running under
518         Cygwin (the paths were getting one too many "/" on the front).
519         However, the change ended up breaking the chromium_win port, which
520         had slightly different logic.
521
522         This patch removes the port-specific code and adds tests to make
523         sure we're getting the behavior we expect. The Port object no longer
524         exposes a get_absolute_path() method that can be used outside of
525         of converting test filenames, because it's unreliable otherwise
526         (we don't have the right context to know which conversion is intended).
527
528         https://bugs.webkit.org/show_bug.cgi?id=47140
529
530         * Scripts/webkitpy/layout_tests/port/base.py:
531         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
532         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
533         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
534         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
535
536 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
537
538         Unreviewed, build fix.
539
540         Handle crash introduced in r69040 if we are not running in a
541         Chromium checkout.
542
543         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
544
545 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
546
547         Reviewed by Tony Chang.
548
549         Add a way for us to have test expectations that are specific to the
550         official builds of Google Chrome (as opposed to Chromium). This change
551         looks for an additional "test_expectations_chrome.txt" file in
552         Chromium's repository (webkit/tools/layout_tests), and uses the
553         concatenation of that file and the regular test_expectations.txt
554         file for test overrides.
555
556         https://bugs.webkit.org/show_bug.cgi?id=46854
557
558         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
559         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
560
561 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
562
563         Color tests in the list based on existing pass/fail result.
564         
565         Fix the summary data to account for htmlOnly and nonHTML tests.
566
567         * CSSTestSuiteHarness/harness/harness.css:
568         (#test-list > option.pass):
569         (#test-list > option.fail):
570         (#test-list > option.skipped):
571         * CSSTestSuiteHarness/harness/harness.js:
572         (Test):
573         (Test.prototype.statusForFormat):
574         (TestSuite.prototype.fillTestList):
575         (TestSuite.prototype.updateTestList):
576         (TestSuite.prototype.recordResult):
577         (TestSuite.prototype.markTestCompleted):
578         (TestSuite.prototype.countTestsWithFlag):
579         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
580         (TestSuite.prototype.queryDatabaseForSummary):
581
582 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
583
584         Reviewed by Beth Dakin.
585
586         AX: doAXRangeForLine does not work
587         https://bugs.webkit.org/show_bug.cgi?id=47101
588
589         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
590
591         * DumpRenderTree/AccessibilityUIElement.cpp:
592         (rangeForLineCallback):
593         (AccessibilityUIElement::rangeForLine):
594         (AccessibilityUIElement::getJSClass):
595         * DumpRenderTree/AccessibilityUIElement.h:
596         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
597         (AccessibilityUIElement::rangeForLine):
598
599 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
600
601         Unreviewed. Adding myself to the committers list.
602
603         * Scripts/webkitpy/common/config/committers.py:
604
605 2010-10-04  Sam Weinig  <sam@webkit.org>
606
607         Reviewed by Anders Carlsson.
608
609         Add ability to set the CacheModel in Webkit2
610         https://bugs.webkit.org/show_bug.cgi?id=47066
611
612         * MiniBrowser/mac/AppDelegate.m:
613         (-[BrowserAppDelegate init]): Opt minibrowser into
614         a PrimaryWebBrowser cache model.
615
616 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
617
618         Make sure to enter all tests when creating the database
619         for the first time.
620         
621         When migrating to a new version of the suite, be sure to
622         sync up the database and testinfo.data by removing old
623         tests, and inserting new ones.
624
625         * CSSTestSuiteHarness/harness/harness.js:
626         (TestSuite.prototype.openDatabase.creation):
627         (TestSuite.prototype.databaseCreated):
628         (TestSuite.prototype.populateDatabaseFromTestInfoData):
629         (TestSuite.prototype.insertTest):
630
631 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
632
633         More work on treating HTML4 and XHTML1 independently; when 
634         changing the format, rebuild the test list, and update the 
635         numbers in the chapter popup.
636
637         * CSSTestSuiteHarness/harness/harness.js:
638         (Test):
639         (Test.prototype.runForFormat):
640         (Test.prototype.completedForFormat):
641         (ChapterSection):
642         (ChapterSection.prototype.countTests):
643         (Chapter):
644         (Chapter.prototype.description):
645         (Chapter.prototype.countTests):
646         (Chapter.prototype.testCount):
647         (Chapter.prototype.untestedCount):
648         (TestSuite.prototype.buildChapters):
649         (TestSuite.prototype.loadCurrentTest):
650         (TestSuite.prototype.updateProgressLabel):
651         (TestSuite.prototype.processFlags):
652         (TestSuite.prototype.formatChanged):
653
654 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
655
656         Update test suite version 20101001.
657         
658         Handle database migration, and delete tests from the db that are
659         not present in testinfo.data.
660         
661         Load about:blank into the test frame before the test url, to make
662         missing tests more obvious.
663         
664         * CSSTestSuiteHarness/harness/harness.js:
665         (TestSuite.prototype.loadTest):
666         (TestSuite.prototype.openDatabase.creation):
667         (TestSuite.prototype.openDatabase.migration1_0To1_1):
668         (TestSuite.prototype.openDatabase.if.return):
669         (TestSuite.prototype.databaseReady):
670         (TestSuite.prototype.populateDatabaseFromTestInfoData):
671         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
672         (TestSuite.prototype.syncDatabaseWithTestInfoData):
673
674 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
675
676         Add the ability to jump to a specific test.
677
678         * CSSTestSuiteHarness/harness/harness.html:
679         * CSSTestSuiteHarness/harness/harness.js:
680         (TestSuite.prototype.goToTestByName):
681         (TestSuite.prototype.switchToFormat):
682
683 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
684
685         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
686         as the test.
687
688         * CSSTestSuiteHarness/harness/harness.js:
689         (TestSuite.prototype.loadRef):
690
691 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
692
693         Update the UI to reflect the fact that each test needs to be tested
694         in both HTML4 and XHTML1 format.
695         
696         * CSSTestSuiteHarness/harness/harness.js:
697         (Test):
698         (Chapter.prototype.description):
699         (Chapter.prototype.untestedCount):
700         (TestSuite.prototype.fillChapterPopup):
701         (TestSuite.prototype.updateChapterPopup):
702         (TestSuite.prototype.fillTestList):
703         (TestSuite.prototype.updateTestList):
704         (TestSuite.prototype.goToNextIncompleteTest):
705         (TestSuite.prototype.firstIncompleteTestIndex):
706         (TestSuite.prototype.recordResult):
707         (TestSuite.prototype.formatChanged):
708         (TestSuite.prototype.markTestCompleted):
709         (TestSuite.prototype.resetTestStatus):
710
711 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
712
713         Add the ability to remove results for re-testing, and
714         to import results.
715
716         * CSSTestSuiteHarness/harness/harness.css:
717         (.custom button):
718         (#overlay):
719         (#overlay.visible):
720         (.overlay-contents):
721         (.overlay-contents textarea):
722         (.overlay-contents .buttons):
723         (.overlay-contents .note):
724         (.overlay-contents .buttons button):
725         * CSSTestSuiteHarness/harness/harness.html:
726         * CSSTestSuiteHarness/harness/harness.js:
727         (TestSuite.prototype.importResults):
728         (TestSuite.prototype.clearResults):
729         (TestSuite.prototype.markTestCompleted):
730         (TestSuite.prototype.resetTestStatus):
731         (TestSuite.prototype.storeTestResult):
732         (TestSuite.prototype.importTestResults):
733         (TestSuite.prototype.clearTestResults):
734
735 2010-10-01  Sam Weinig  <sam@webkit.org>
736
737         Reviewed by Jon Honeycutt.
738
739         Deploy the new WKString functions to remove most uses of CF from
740         the WebKitTestRunner.
741
742         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
743         (WTR::InjectedBundle::didReceiveMessage):
744         (WTR::InjectedBundle::done):
745         * WebKitTestRunner/StringFunctions.h:
746         (WTR::toWK):
747         (WTR::toJS):
748         (WTR::toSTD):
749         (WTR::operator<<):
750         (WTR::copyURLString):
751         * WebKitTestRunner/TestController.cpp:
752         (WTR::TestController::resetStateToConsistentValues):
753         (WTR::TestController::didFinishLoadForFrame):
754         * WebKitTestRunner/TestInvocation.cpp:
755         (WTR::TestInvocation::invoke):
756         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
757
758 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
759
760         Unreviewed TestResultsServer change.
761
762         Add files introduced by http://crrev.com/61273 to the list of dashboard 
763         files to update.
764
765         * TestResultServer/handlers/dashboardhandler.py:
766
767 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
768
769         Build Fix for Windows.
770
771         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
772             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
773             ForwardingHeaders to the include path.
774
775 2010-10-01  Sam Weinig  <sam@webkit.org>
776
777         Reviewed by Anders Carlsson.
778
779         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
780
781         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
782         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
783         (TestWebKitAPI::TEST):
784         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
785         (TestWebKitAPI::TEST):
786
787 2010-10-01  Sam Weinig  <sam@webkit.org>
788
789         Reviewed by Kenneth Rohde Christiansen.
790
791         Add additional WKString API
792         https://bugs.webkit.org/show_bug.cgi?id=46958
793
794         Add basic WKStringRef tests.
795
796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
797         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
798
799 2010-10-01  Sam Weinig  <sam@webkit.org>
800
801         Reviewed by Dan Bernstein.
802
803         Add makefile for TestWebKitAPI and call it from the base makefile.
804
805         * Makefile:
806         * TestWebKitAPI/Makefile: Added.
807
808 2010-10-01  Sam Weinig  <sam@webkit.org>
809
810         Reviewed by Adam Roben.
811
812         Remove unnecessary ForwardingHeaders from test runners.
813         https://bugs.webkit.org/show_bug.cgi?id=47010
814
815         * TestWebKitAPI/Configurations/Base.xcconfig:
816         * TestWebKitAPI/ForwardingHeaders: Removed.
817         * WebKitTestRunner/Configurations/Base.xcconfig:
818         * WebKitTestRunner/ForwardingHeaders: Removed.
819
820 2010-09-30  Adam Barth  <abarth@webkit.org>
821
822         Reviewed by Eric Seidel.
823
824         WebSocket tests are flaky
825         https://bugs.webkit.org/show_bug.cgi?id=46956
826
827         Update these tools to understand how to run the WebSocket tests off the
828         Apache server.
829
830         * Scripts/old-run-webkit-tests:
831         * Scripts/webkitpy/layout_tests/port/base.py:
832         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
833         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
834
835 2010-10-01  Adam Roben  <aroben@apple.com>
836
837         Encode Executive command arguments using UTF-8 on Cygwin
838
839         Cygwin's Python's os.execv doesn't support unicode command arguments.
840         Cygwin's execv expects arguments to be encoded using the current code
841         page. But code pages are limited in what characters they can handle,
842         and our tests include characters that the English code page can't
843         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
844         which can handle all characters but might confuse some commands, for
845         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
846         good enough, but we can deal with that when the problem arises.
847
848         Reviewed by Adam Barth.
849
850         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
851         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
852         fails on Windows
853
854         * Scripts/webkitpy/common/system/executive.py:
855         (Executive._run_command_with_teed_output):
856         (Executive.run_command):
857         On Cygwin, encode arguments using UTF-8.
858
859 2010-10-01  Sam Weinig  <sam@webkit.org>
860
861         Reviewed by Adam Roben.
862
863         Add simple API tester for WebKit2
864         https://bugs.webkit.org/show_bug.cgi?id=46953
865
866         This adds a very simple testing infrastructure for testing APIs exposed
867         through the WebKit project. It consists of two parts: 1) a project that
868         builds the all the tests 2) a script that searches the tests directory and
869         calls the tester once for each test.
870
871         This adds the infrastructure and two tests:
872         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
873         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
874
875         This currently only works on the mac, but is designed to be easily ported 
876         to any platform.
877
878         * Scripts/run-api-tests: Added.
879         * Scripts/build-api-tests: Added.
880         Scripts to build/run the tests.
881
882         * TestWebKitAPI: Added.
883         * TestWebKitAPI/Configurations: Added.
884         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
885         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
886         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
887         * TestWebKitAPI/ForwardingHeaders: Added.
888         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
889         * TestWebKitAPI/PlatformUtilities.h: Added.
890         * TestWebKitAPI/PlatformWebView.h: Added.
891         (TestWebKitAPI::PlatformWebView::platformView):
892         * TestWebKitAPI/StringFunctions.h: Added.
893         * TestWebKitAPI/Test.h: Added.
894         (TestWebKitAPI::Test::~Test):
895         (TestWebKitAPI::Test::name):
896         (TestWebKitAPI::Test::Register::Register):
897         (TestWebKitAPI::Test::Register::create):
898         (TestWebKitAPI::Test::Test):
899         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
900         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
901         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
902         * TestWebKitAPI/TestsController.cpp: Added.
903         (TestWebKitAPI::TestsController::shared):
904         (TestWebKitAPI::TestsController::TestsController):
905         (TestWebKitAPI::TestsController::runTestNamed):
906         (TestWebKitAPI::TestsController::testFailed):
907         (TestWebKitAPI::TestsController::registerCreateTestFunction):
908         * TestWebKitAPI/TestsController.h: Added.
909         * TestWebKitAPI/mac: Added.
910         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
911         (TestWebKitAPI::Util::run):
912         (TestWebKitAPI::Util::createURLForResource):
913         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
914         (TestWebKitAPI::PlatformWebView::PlatformWebView):
915         (TestWebKitAPI::PlatformWebView::resizeTo):
916         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
917         (TestWebKitAPI::PlatformWebView::page):
918         (TestWebKitAPI::PlatformWebView::focus):
919         * TestWebKitAPI/mac/main.mm: Added.
920         Infrastructure.
921
922         * TestWebKitAPI/Tests: Added.
923         * TestWebKitAPI/Tests/WTF: Added.
924         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
925         * TestWebKitAPI/Tests/WebKit2: Added.
926         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
927         (TestWebKitAPI::State::State):
928         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
929         Proof of concept tests.
930
931 2010-10-01  Adam Roben  <aroben@apple.com>
932
933         Don't assume AccessibleObjectFromEvent succeeds
934
935         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
936         DumpRenderTree!notificationListenerProc when running
937         plugins/access-after-page-destroyed.html
938
939         Reviewed by Sam Weinig.
940
941         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
942         (notificationListenerProc): Check both the return value of
943         AccessibleObjectFromEvent and the object it returns, as MSDN
944         recommends.
945
946 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
947
948         Reviewed by Tony Chang.
949
950         [NRWT] Put the http and websocket tests first in the test list.
951         https://bugs.webkit.org/show_bug.cgi?id=46453
952
953         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
954         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
955
956 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
957
958         Unreviewed, adding myself to the committer list.
959
960         * Scripts/webkitpy/common/config/committers.py:
961
962 2010-10-01  Adam Roben  <aroben@apple.com>
963
964         Test NPN_GetValue(NPNVnetscapeWindow)
965
966         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
967         Right-clicking on windowless Flash plugin in WebKit2 makes a context
968         menu appear in the bottom-right corner of the screen
969
970         Reviewed by Anders Carlsson.
971
972         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
973         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
974
975         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
976
977         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
978         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
979         (GetValueNetscapeWindow::NPP_SetWindow): Test that
980         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
981         isn't our HWND.
982
983         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
984         Added GetValueNetscapeWindow.
985
986 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
987
988         Unreviewed, adding my webkit.org identity to reviewer list.
989
990         * Scripts/webkitpy/common/config/committers.py:
991
992 2010-09-30  Adam Barth  <abarth@webkit.org>
993
994         Reviewed by Eric Seidel.
995
996         The WebSocket server should flush its logs
997         https://bugs.webkit.org/show_bug.cgi?id=46946
998
999         The WebSocket server logs are truncated because the driver just
1000         terminates the child.  It should run Python without buffering so we can
1001         see the end of the log.
1002
1003         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1004
1005 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
1006
1007         Add a button to jump to the next untested test.
1008         
1009         * CSSTestSuiteHarness/harness/harness.css:
1010         (.test-type):
1011         (.name > button):
1012         * CSSTestSuiteHarness/harness/harness.html:
1013         * CSSTestSuiteHarness/harness/harness.js:
1014         (Chapter.prototype.description):
1015         (Chapter.prototype.untestedCount):
1016         (TestSuite.prototype.testInfoDataLoaded):
1017         (TestSuite.prototype.fillChapterPopup):
1018         (TestSuite.prototype.updateChapterPopup):
1019         (TestSuite.prototype.buildTestListForChapter):
1020         (TestSuite.prototype.goToNextIncompleteTest):
1021         (TestSuite.prototype.firstIncompleteTestIndex):
1022         (TestSuite.prototype.testCompletionStateChanged):
1023
1024 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
1025
1026         WebKit2 on Windows should use Windows fonts for the various standard
1027         font families
1028         https://bugs.webkit.org/show_bug.cgi?id=43499
1029         <rdar://problem/8272758>
1030
1031         Reviewed by Adam Roben.
1032
1033         * WebKitTestRunner/TestController.cpp:
1034         (WTR::TestController::resetStateToConsistentValues):
1035         Use the Mac fonts for running tests. This matches DRT behavior.
1036
1037 2010-09-30  Adam Barth  <abarth@webkit.org>
1038
1039         Third attempt.  We need a better integration test environment.
1040
1041         * Scripts/webkitpy/common/net/failuremap.py:
1042         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1043
1044 2010-09-30  Robert Hogan  <robert@webkit.org>
1045
1046         Reviewed by Andreas Kling.
1047
1048         [Qt] Support for PlainTextController
1049
1050         Unskip editing/text-iterator/basic-iteration.html
1051
1052         https://bugs.webkit.org/show_bug.cgi?id=38805
1053
1054         * DumpRenderTree/qt/DumpRenderTree.pro:
1055         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1056         (WebCore::DumpRenderTree::DumpRenderTree):
1057         (WebCore::DumpRenderTree::initJSObjects):
1058         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1059         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
1060         (PlainTextController::PlainTextController):
1061         (PlainTextController::plainText):
1062         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
1063
1064 2010-09-30  Adam Barth  <abarth@webkit.org>
1065
1066         Unreviewed.  Second attempt to fix sheriffbot.
1067
1068         * Scripts/webkitpy/common/net/buildbot.py:
1069
1070 2010-09-30  Adam Barth  <abarth@webkit.org>
1071
1072         Unreviewed.
1073
1074         This patch should stop the sheriffbot from throwing an exception.
1075
1076         * Scripts/webkitpy/common/net/buildbot.py:
1077
1078 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
1079
1080         Reviewed by Adam Roben.
1081
1082         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
1083         https://bugs.webkit.org/show_bug.cgi?id=46926
1084
1085         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
1086             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
1087
1088 2010-09-30  Adam Barth  <abarth@webkit.org>
1089
1090         Reviewed by Eric Seidel.
1091
1092         webkit-patch find-flaky-tests should print results URLs
1093         https://bugs.webkit.org/show_bug.cgi?id=46917
1094
1095         Printing out the results URL makes find-flaky-tests more actionable
1096         because you can see what happens when a test fails.  The output from
1097         the script is still pretty noisy, but it seems useful.
1098
1099         * Scripts/webkitpy/tool/commands/queries.py:
1100
1101 2010-09-30  Chris Marrin  <cmarrin@apple.com>
1102
1103         Reviewed by Simon Fraser.
1104
1105         Make 2D accelerated canvas rendering build on Mac
1106         https://bugs.webkit.org/show_bug.cgi?id=46007
1107         
1108         Added ACCELERATED_2D_CANVAS to build-webkit
1109
1110         * Scripts/build-webkit:
1111
1112 2010-09-29  Kenneth Russell  <kbr@google.com>
1113
1114         Reviewed by Dimitri Glazkov.
1115
1116         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
1117         https://bugs.webkit.org/show_bug.cgi?id=46849
1118
1119         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
1120         works with the compositor integration in both DumpRenderTree and
1121         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
1122         and thereby trigger the compositor's readback code path. Added support
1123         for --enable-accelerated-compositing to DumpRenderTree.
1124
1125         Tested in both test_shell and DumpRenderTree on Linux, the latter by
1126         modifying a compositing layout test, dumping the pixels and verifying
1127         that they matched the output when the compositor was active.
1128
1129         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1130         (main):
1131         * DumpRenderTree/chromium/TestShell.cpp:
1132         (TestShell::TestShell):
1133         (TestShell::resetWebSettings):
1134         * DumpRenderTree/chromium/TestShell.h:
1135         (TestShell::setAcceleratedCompositingEnabled):
1136         * DumpRenderTree/chromium/WebPreferences.cpp:
1137         (WebPreferences::reset):
1138         (WebPreferences::applyTo):
1139         * DumpRenderTree/chromium/WebPreferences.h:
1140         * DumpRenderTree/chromium/WebViewHost.cpp:
1141         (WebViewHost::scheduleComposite):
1142         * DumpRenderTree/chromium/WebViewHost.h:
1143
1144 2010-09-30  Adam Roben  <aroben@apple.com>
1145
1146         Ensure that QueueEngine cleans up its log files when its delegate
1147         tells it to stop processing work
1148
1149         Reviewed by Adam Barth.
1150
1151         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
1152         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
1153         Windows
1154
1155         * Scripts/webkitpy/tool/bot/queueengine.py:
1156         (QueueEngine.run): Stop ourselves normally (including cleaning up log
1157         files) when the delegate tells us to stop processing work.
1158
1159         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1160         (LoggingDelegate.__init__): Moved code here from
1161         RaisingDelegate.__init__.
1162         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
1163         callback.
1164         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
1165         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
1166         care of for us now.
1167         (QueueEngineTest.test_trivial): Make sure we got the expected stop
1168         message.
1169         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
1170         remove the callbacks that are related to processing a single work
1171         item, rather than removing all callbacks after a certain point, as
1172         there are now more callbacks we expect to receive at the end.
1173
1174 2010-09-30  Adam Roben  <aroben@apple.com>
1175
1176         Fix path -> URL conversion on Cygwin
1177
1178         Reviewed by Adam Barth.
1179
1180         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
1181         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
1182
1183         * Scripts/webkitpy/layout_tests/port/base.py:
1184         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
1185         assuming paths already have a leading slash.
1186
1187 2010-09-30  Adam Roben  <aroben@apple.com>
1188
1189         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
1190         be called more than once
1191
1192         The NPP_SetWindow call made when the plugin is torn down was confusing
1193         us, and was causing us to spew an error into the next test.
1194
1195         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
1196         (r68520): plugins/access-after-page-destroyed.html failing on Windows
1197
1198         Reviewed by Anders Carlsson.
1199
1200         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1201         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
1202         Initialize member.
1203         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
1204         this isn't the first time this is called.
1205
1206 2010-09-30  Eric Seidel  <eric@webkit.org>
1207
1208         Reviewed by Adam Barth.
1209
1210         webkit-patch upload warns that I'm using Xcode when I'm not
1211         https://bugs.webkit.org/show_bug.cgi?id=46869
1212
1213         String.find returns -1 when not found, so switched to "in".
1214
1215         * Scripts/webkitpy/common/system/user.py:
1216         * Scripts/webkitpy/common/system/user_unittest.py:
1217
1218 2010-09-30  Eric Seidel  <eric@webkit.org>
1219
1220         Reviewed by Adam Barth.
1221
1222         webkit-patch failure-reason dies if non-trunk commits are in the blame range
1223         https://bugs.webkit.org/show_bug.cgi?id=46866
1224
1225         I also made failure-reason use RegressionWindow in a cleaner way.
1226
1227         * Scripts/webkitpy/tool/commands/queries.py:
1228
1229 2010-09-29  Adam Barth  <abarth@webkit.org>
1230
1231         Reviewed by Eric Seidel.
1232
1233         webkit-patch find-flaky-tests
1234         https://bugs.webkit.org/show_bug.cgi?id=46876
1235
1236         This command helps us find flaky tests so we can squash them.
1237
1238         * Scripts/webkitpy/tool/commands/queries.py:
1239
1240 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1241
1242         Fix export to use '?' instead of 'null' for
1243         tests with no results.
1244         
1245         * CSSTestSuiteHarness/harness/harness.js:
1246
1247 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1248
1249         Add a warning when a test requires special steps.
1250         Add a Print Preview button for 'paged' tests that
1251         brings up the print dialog, allowing the user to 
1252         judge paged media tests.
1253
1254         * CSSTestSuiteHarness/harness/harness.css:
1255         * CSSTestSuiteHarness/harness/harness.html:
1256         * CSSTestSuiteHarness/harness/harness.js:
1257         (TestSuite.prototype.loadTest):
1258         (TestSuite.prototype.processFlags):
1259
1260 2010-09-29  Adam Barth  <abarth@webkit.org>
1261
1262         Reviewed by Eric Seidel.
1263
1264         Remove revisions_casuing_failures
1265         https://bugs.webkit.org/show_bug.cgi?id=46872
1266
1267         This function exists only to be unit tested.
1268
1269         * Scripts/webkitpy/common/net/failuremap.py:
1270         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1271         * Scripts/webkitpy/tool/mocktool.py:
1272
1273 2010-09-29  Adam Barth  <abarth@webkit.org>
1274
1275         Reviewed by Eric Seidel.
1276
1277         SheriffBot should post the list of failing tests to bugs
1278         https://bugs.webkit.org/show_bug.cgi?id=46871
1279
1280         * Scripts/webkitpy/common/net/buildbot.py:
1281         * Scripts/webkitpy/common/net/failuremap.py:
1282         * Scripts/webkitpy/common/net/regressionwindow.py:
1283         * Scripts/webkitpy/tool/bot/sheriff.py:
1284         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1285         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1286         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1287         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1288         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1289         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1290         * Scripts/webkitpy/tool/mocktool.py:
1291
1292 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
1293
1294         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
1295
1296         [WinCairo] Adds a build slave.
1297         https://bugs.webkit.org/show_bug.cgi?id=46360
1298
1299         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
1300         entries for a debug build of the WinCairo port.
1301         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
1302         platform flag to configuration for wincairo (like gtk, chromium, etc.)
1303         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
1304         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
1305
1306 2010-09-29  Adam Barth  <abarth@webkit.org>
1307
1308         Reviewed by Eric Seidel.
1309
1310         Move more SheriffBot smarts into FailureMap
1311         https://bugs.webkit.org/show_bug.cgi?id=46703
1312
1313         This patch pushes the FailureMap model object further into the
1314         SheriffBot machine.  In addition, it moves a couple operations on this
1315         object from SheriffBot itself to the model.
1316
1317         Eventually, FailureMap will be the canonical context object for
1318         SheriffBot operations.  FailureMap represents a map of the current
1319         failures on the bots that might require remediation.
1320
1321         * Scripts/webkitpy/common/net/failuremap.py:
1322         * Scripts/webkitpy/common/net/regressionwindow.py:
1323         * Scripts/webkitpy/tool/commands/queries.py:
1324         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1325         * Scripts/webkitpy/tool/mocktool.py:
1326
1327 2010-09-29  Tony Chang  <tony@chromium.org>
1328
1329         Reviewed by James Robinson.
1330
1331         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
1332         https://bugs.webkit.org/show_bug.cgi?id=46829
1333
1334         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1335         (DRTDevToolsClient::DRTDevToolsClient):
1336         * DumpRenderTree/chromium/TestShell.cpp:
1337         (TestShell::TestShell):
1338         * DumpRenderTree/chromium/WebViewHost.cpp:
1339         (WebViewHost::postAccessibilityNotification):
1340         (WebViewHost::WebViewHost):
1341
1342 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
1343
1344         Reviewed by Darin Adler.
1345
1346         AX: implement CSS3 Speech "speak"
1347         https://bugs.webkit.org/show_bug.cgi?id=46827
1348
1349         * DumpRenderTree/AccessibilityUIElement.cpp:
1350         (speakCallback):
1351         (AccessibilityUIElement::speak):
1352         (AccessibilityUIElement::getJSClass):
1353         * DumpRenderTree/AccessibilityUIElement.h:
1354         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1355         (AccessibilityUIElement::speak):
1356
1357 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
1358
1359         Reviewed by Adam Barth.
1360
1361         Record bot ID when updating queue status
1362         https://bugs.webkit.org/show_bug.cgi?id=46764
1363         
1364         Since we now have multiple bots handling patches from the commit queue,
1365         we need to differentiate status updates from them, so that we can group
1366         the queue status page in a less confusing way.
1367
1368         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
1369         * QueueStatusServer/model/queuestatus.py: Add bot_id property
1370         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
1371         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
1372         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
1373         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
1374         * Scripts/webkitpy/tool/main.py: Add --bot-id
1375         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
1376
1377 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1378
1379         No review.
1380         
1381         References always refert to a file in .xht format, even
1382         for HTML tests, so fix their loading.
1383
1384         * CSSTestSuiteHarness/harness/harness.js:
1385         (TestSuite.prototype.loadRef):
1386
1387 2010-09-28  Johnny Ding  <jnd@chromium.org>
1388
1389         Reviewed by Adam Barth.
1390
1391         https://bugs.webkit.org/show_bug.cgi?id=41292
1392         Add a new parameter to the test plugin to allow specifying a script 
1393         and a mouse/keyboard event. The specified script will be evaluated
1394         in the browser when the specified event is received by the plugin.
1395
1396         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1397         (pluginAllocate):
1398         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1399         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1400         (NPP_New):
1401         (handleEventCarbon):
1402         (handleEventCocoa):
1403
1404 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1405
1406         Fix export by adding missing argument.
1407
1408         * CSSTestSuiteHarness/harness/harness.js:
1409         (TestSuite.prototype.showResultsForAllTests):
1410
1411 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1412
1413         [wx] Build fix, add missing import.
1414
1415         * wx/packaging/build-win-installer.py:
1416
1417 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1418
1419         No review
1420         
1421         Show which tests have been run by dimming them out in the test list.
1422         
1423         Adjust some element sizes.
1424         
1425         * CSSTestSuiteHarness/harness/harness.css:
1426         (#test-list > option.untested):
1427         (#test-list > option.completed):
1428         (#output):
1429         (.output-options):
1430         * CSSTestSuiteHarness/harness/harness.js:
1431         (Test):
1432         (TestSuite.prototype.fillTestList):
1433         (TestSuite.prototype.updateTestList):
1434         (TestSuite.prototype.setSelectedChapter):
1435         (TestSuite.prototype.recordResult):
1436         (TestSuite.prototype.markTestCompleted):
1437         (TestSuite.prototype.testCompletionStateChanged):
1438         (TestSuite.prototype.loadTestStatus):
1439
1440 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1441
1442         No review.
1443         
1444         Implement export of various queries on the test database, sharing
1445         code with that which displays results inline.
1446
1447         * CSSTestSuiteHarness/harness/harness.js:
1448         ():
1449         (TestSuite.prototype.exportResultsCompletion.var):
1450         (TestSuite.prototype.exportResultsCompletion):
1451         (TestSuite.prototype.showResultsForCompletedTests):
1452         (TestSuite.prototype.exportResultsForCompletedTests):
1453         (TestSuite.prototype.showResultsForAllTests):
1454         (TestSuite.prototype.exportResultsForAllTests):
1455         (TestSuite.prototype.exportResultsForTestsNotRun):
1456         (TestSuite.prototype.exportResultsForTestsWithStatus):
1457         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
1458
1459 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1460
1461         No review.
1462
1463         Work around uncertainty about the order of database
1464         transactions when creating the database, so that we don't
1465         try to query the table before it has been created.
1466
1467         * CSSTestSuiteHarness/harness/harness.js:
1468         (TestSuite):
1469         (TestSuite.prototype.databaseCreated):
1470         (TestSuite.prototype.storeTestResult):
1471         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1472         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
1473         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
1474         (TestSuite.prototype.queryDatabaseForCompletedTests):
1475         (TestSuite.prototype.queryDatabaseForTestsNotRun):
1476
1477 2010-09-28  Tony Chang  <tony@chromium.org>
1478
1479         Reviewed by Eric Seidel.
1480
1481         add python keyring support to webkit-patch
1482         https://bugs.webkit.org/show_bug.cgi?id=41269
1483
1484         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
1485             the python keyring module
1486         * Scripts/webkitpy/common/net/credentials_unittest.py:
1487         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
1488         * Scripts/webkitpy/common/system/user_unittest.py:
1489         * Scripts/webkitpy/tool/mocktool.py:
1490
1491 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1492
1493         Reviewed by Gustavo Noronha Silva.
1494
1495         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
1496         https://bugs.webkit.org/show_bug.cgi?id=46740
1497
1498         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
1499         fonts which can be used to fully test FontConfig rendering settings.
1500
1501 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1502
1503         Reviewed by Gustavo Noronha Silva.
1504
1505         [gtk] Fedora has a different path for the liberation fonts
1506         https://bugs.webkit.org/show_bug.cgi?id=46709
1507
1508         When searching for DRT fonts, also look in the path where those fonts
1509         are commonly found on Fedora systems.
1510
1511         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1512         (initializeFonts): Include logic for looking for Fedora-style font paths.
1513
1514 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1515
1516         Reviewed by Andreas Kling.
1517
1518         run-webkit-tests needs an updated list of directories with webgl tests
1519         https://bugs.webkit.org/show_bug.cgi?id=46747
1520
1521         Update the list of directories containing WebGL tests and a unit test
1522         which depends on this list.
1523
1524         * Scripts/old-run-webkit-tests: Update the list of directories.
1525         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
1526         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
1527
1528 2010-09-28  Adam Barth  <abarth@webkit.org>
1529
1530         Reviewed by Eric Seidel.
1531
1532         Introduce FailureMap to summaries the failures status of all the bots
1533         https://bugs.webkit.org/show_bug.cgi?id=46700
1534
1535         This patch gives the SheriffBot a handle on the list of failing tests.
1536
1537         * Scripts/webkitpy/common/net/buildbot.py:
1538         * Scripts/webkitpy/common/net/failuremap.py: Added.
1539         * Scripts/webkitpy/tool/commands/queries.py:
1540         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1541         * Scripts/webkitpy/tool/mocktool.py:
1542
1543 2010-09-28  Adam Roben  <aroben@apple.com>
1544
1545         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
1546
1547         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
1548         tell a WebKit2 client application that a key event was not handled
1549
1550         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
1551
1552         * MiniBrowser/mac/BrowserWindowController.m:
1553         (-[BrowserWindowController awakeFromNib]):
1554         * MiniBrowser/win/BrowserView.cpp:
1555         (BrowserView::create):
1556         * WebKitTestRunner/TestController.cpp:
1557         (WTR::createOtherPage):
1558         (WTR::TestController::initialize):
1559
1560 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1561
1562         Unreviewed.
1563
1564         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
1565         for the test order, but instead use information from testinfo.data.
1566         
1567         * CSSTestSuiteHarness/harness/harness.html:
1568         * CSSTestSuiteHarness/harness/harness.js:
1569
1570 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1571
1572         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
1573         it causes the process to hang on the gitorious repo.
1574
1575         * wx/packaging/build-mac-installer.py:
1576         * wx/packaging/build-win-installer.py:
1577
1578 2010-09-28  Adam Roben  <aroben@apple.com>
1579
1580         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
1581         called
1582
1583         Reviewed by Anders Carlsson.
1584
1585         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
1586         Full-page Adobe Reader does not paint until window is resized
1587
1588         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1589         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
1590         this level.
1591
1592         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
1593         NPP_SetWindow.
1594
1595         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
1596         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
1597         the plugin's HWND has a non-zero size and that its size/position
1598         matches that specified in the NPWindow.
1599
1600         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1601         (NPP_SetWindow): Call through to the PluginTest.
1602
1603         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1604         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
1605         the files as it saw fit.
1606
1607 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1608
1609         Reviewed by Andreas Kling.
1610
1611         [Qt] Remove support for Qt 4.5
1612         https://bugs.webkit.org/show_bug.cgi?id=46718
1613
1614         Remove the code for versions of Qt prior to 4.6.
1615
1616         * DumpRenderTree/qt/EventSenderQt.cpp:
1617         (EventSender::addTouchPoint):
1618         (EventSender::updateTouchPoint):
1619         (EventSender::setTouchModifier):
1620         (EventSender::touchStart):
1621         (EventSender::touchMove):
1622         (EventSender::touchEnd):
1623         (EventSender::clearTouchPoints):
1624         (EventSender::releaseTouchPoint):
1625         (EventSender::sendTouchEvent):
1626         * DumpRenderTree/qt/EventSenderQt.h:
1627         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1628         (TextInputController::setMarkedText):
1629         * QtTestBrowser/launcherwindow.cpp:
1630         (LauncherWindow::LauncherWindow):
1631         (LauncherWindow::initializeView):
1632         (LauncherWindow::createChrome):
1633         (LauncherWindow::sendTouchEvent):
1634         (LauncherWindow::eventFilter):
1635         (LauncherWindow::applyZoom):
1636         (LauncherWindow::setTouchMocking):
1637         * QtTestBrowser/launcherwindow.h:
1638         * QtTestBrowser/utils.cpp:
1639         (urlFromUserInput):
1640         * QtTestBrowser/webview.cpp:
1641         (WebViewGraphicsBased::animatedFlip):
1642         (WebViewGraphicsBased::animatedYFlip):
1643         * QtTestBrowser/webview.h:
1644         (WebViewGraphicsBased::setYRotation):
1645
1646 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
1647
1648         Reviewed by Andreas Kling.
1649
1650         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
1651         which should point to wcecompat installation. Needs wcecompat
1652         library from http://github.com/mauricek/wcecompat .
1653
1654         * DumpRenderTree/qt/DumpRenderTree.pro:
1655         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1656         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1657
1658 2010-09-28  Daniel Bates  <dbates@rim.com>
1659
1660         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
1661         <https://bugs.webkit.org/show_bug.cgi?id=39136>
1662
1663         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
1664         In particular, this change caused Sheriffbot to raise an exception when
1665         trying to parse the bug id on a bug page. We need to look into this
1666         some more.
1667
1668         * Scripts/webkitpy/common/net/bugzilla.py:
1669         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1670         * Scripts/webkitpy/tool/bot/sheriff.py:
1671         * Scripts/webkitpy/tool/commands/download.py:
1672         * Scripts/webkitpy/tool/commands/queues.py:
1673         * Scripts/webkitpy/tool/commands/upload.py:
1674         * Scripts/webkitpy/tool/steps/closebug.py:
1675         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1676         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1677         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1678
1679 2010-09-28  Adam Barth  <abarth@webkit.org>
1680
1681         Reviewed by Eric Seidel.
1682
1683         Move RegressionWindow further up the dependency chain
1684         https://bugs.webkit.org/show_bug.cgi?id=46698
1685
1686         Baby steps towards pushing this information into bug posts.
1687
1688         * Scripts/webkitpy/common/net/buildbot.py:
1689         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1690         * Scripts/webkitpy/common/net/regressionwindow.py:
1691         * Scripts/webkitpy/tool/commands/queries.py:
1692
1693 2010-09-27  Daniel Bates  <dbates@rim.com>
1694
1695         Reviewed by Adam Barth.
1696
1697         sheriffbot can't roll out security patches
1698         https://bugs.webkit.org/show_bug.cgi?id=39136
1699
1700         Make SheriffBot determine if it's authorized to view a bug
1701         whose change it wants to rollout before it tries to rollout
1702         the change.
1703
1704         Moreover, make both webkit-patch and Sheriffbot provide human-
1705         readable error messages when they are not authorized to view
1706         a bug and when a bug number is invalid.
1707
1708         Currently, Sheriffbot does not parse Bugzilla bugs for
1709         <bug error="...">, which indicates an error when retrieving
1710         a bug. In particular, error="NotPermitted" if a person (or bot)
1711         is not authorized to view a bug. For such error="NotPermitted" bugs,
1712         Sheriffbot raises an exception when parsing the bug report and
1713         this exception does not explicitly indicate Sheriffbot's lack
1714         of authorization. Instead, Sheriffbot should explicitly check
1715         for the presence <bug error="..."> before operating on a bug
1716         and error with a human-readable message if it's not permitted
1717         to view it.
1718
1719         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
1720         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1721           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
1722           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
1723           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
1724         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
1725         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1726         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1727         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
1728         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
1729         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
1730         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
1731         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
1732
1733 2010-09-27  Adam Barth  <abarth@webkit.org>
1734
1735         Reviewed by Eric Seidel.
1736
1737         Expose more more failure information from Buildbot to SheriffBot
1738         https://bugs.webkit.org/show_bug.cgi?id=46697
1739
1740         This patch moves the information about what tests failured closer to
1741         SheriffBot.  There are still a couple more patches to go before
1742         SheriffBot can post this information to bugs, but this is a step in
1743         that direction.  Yay for unit tests, which caught some bugs in earlier
1744         versions of this patch.
1745
1746         * Scripts/webkitpy/common/net/buildbot.py:
1747         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1748         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
1749         * Scripts/webkitpy/tool/commands/queries.py:
1750
1751 2010-09-27  Eric Seidel  <eric@webkit.org>
1752
1753         Unreviewed.  Fixing 500 error seen in the status server.
1754
1755         It turns out that a = b = []; b.append(1); then a[0] will be 1!
1756         This should have been obvious to me, I guess, but it was not what I was expecting.
1757
1758         * QueueStatusServer/model/activeworkitems.py:
1759
1760 2010-09-27  Adam Barth  <abarth@webkit.org>
1761
1762         Reviewed by Eric Seidel.
1763
1764         commit-queue should reject patches that fail to land
1765         https://bugs.webkit.org/show_bug.cgi?id=46694
1766
1767         This can happen, for example, if there's no reviewer.  Without this
1768         patch, we'll keep retrying the patch.
1769
1770         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1771         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1772
1773 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
1774
1775         Rubber-stamped by Adele Peterson.
1776
1777         Add a harness for running the CSS 2.1 test suite.
1778         
1779         This harness assumes that you've got a local a copy of the suite
1780         adjacent to the 'harness' directory.
1781         
1782         The harness lets you go through the tests in chapter order,
1783         denoting pass/fail/skipped for each test.
1784         
1785         It uses a client-side database to store the results of testing.
1786
1787         * CSSTestSuiteHarness/harness/harness.css: Added.
1788         * CSSTestSuiteHarness/harness/harness.html: Added.
1789         * CSSTestSuiteHarness/harness/harness.js: Added.
1790
1791 2010-09-27  Eric Seidel  <eric@webkit.org>
1792
1793         Reviewed by Adam Barth.
1794
1795         Patch locks should expire if a patch is marked for retry
1796         https://bugs.webkit.org/show_bug.cgi?id=46682
1797
1798         This was part Adam's original CommitQueueTask design,
1799         but support for it was missing from the server.
1800         I added the support, but triggering lock-release based on this
1801         special "retry" status feels a bit strange so I added a FIXME.
1802
1803         I also changed the text in queuestatus.html to say "Lock Acquired"
1804         since "Last Activity" isn't really true.  We only update the lock
1805         date when the patch is started, not on every status update.
1806
1807         I also noticed an exception in next-patch, which I fixed by re-writing
1808         the unzip logic in activeworkitems.py again.
1809
1810         * QueueStatusServer/handlers/updatestatus.py:
1811         * QueueStatusServer/model/activeworkitems.py:
1812         * QueueStatusServer/templates/queuestatus.html:
1813
1814 2010-09-27  Tony Chang  <tony@chromium.org>
1815
1816         Reviewed by David Levin.
1817
1818         [chromium] fix a warning when compiling DRT on 32-bit linux
1819         https://bugs.webkit.org/show_bug.cgi?id=46641
1820
1821         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1822         (DRTPrinter::handleImage):
1823
1824 2010-09-27  Eric Seidel  <eric@webkit.org>
1825
1826         Reviewed by Adam Barth.
1827
1828         queue-status should report when the patch was last locked to a queue
1829         https://bugs.webkit.org/show_bug.cgi?id=46674
1830
1831         This isn't necessarily the best way to expose this information
1832         but having this accessible via the web interface is very
1833         useful until we come up with a nicer way to display this.
1834
1835         I also cleaned up the code in activeworkitems.py a little
1836         to use list comprehensions and to have the code work with
1837         pairs instead of two lists at once.  Eventually I think those
1838         item/time pairs need to be their own little helper class.
1839
1840         * QueueStatusServer/handlers/queuestatus.py:
1841         * QueueStatusServer/model/activeworkitems.py:
1842         * QueueStatusServer/templates/queuestatus.html:
1843
1844 2010-09-27  Tony Chang  <tony@chromium.org>
1845
1846         Reviewed by David Levin.
1847
1848         [chromium] fix detection of missing fonts on DRT
1849         https://bugs.webkit.org/show_bug.cgi?id=46651
1850
1851         * DumpRenderTree/chromium/TestShellGtk.cpp:
1852         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
1853
1854 2010-09-27  Tony Chang  <tony@chromium.org>
1855
1856         Reviewed by Dimitri Glazkov.
1857
1858         add webkit unit tests to the chromium testers
1859         https://bugs.webkit.org/show_bug.cgi?id=46669
1860
1861         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1862         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
1863
1864 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
1865
1866         Unreviewed.
1867
1868         Adding myself to the committers list.
1869
1870         * Scripts/webkitpy/common/config/committers.py:
1871
1872 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
1873
1874         Reviewed by Eric Seidel.
1875
1876         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
1877         https://bugs.webkit.org/show_bug.cgi?id=46634
1878         
1879         Use OutputCapture to prevent console spam (and also check for expected
1880         output).
1881
1882         * Scripts/webkitpy/common/system/user_unittest.py:
1883
1884 2010-09-27  Eric Seidel  <eric@webkit.org>
1885
1886         Reviewed by James Robinson.
1887
1888         start-commit-queue should abort any rebases in progress
1889         https://bugs.webkit.org/show_bug.cgi?id=46640
1890
1891         webkit-patch commit-queue would do this itself, but this just
1892         helps ensure that the commit-queue script is properly updated
1893         before we run it (in the case where a previous rebase is in
1894         progress the git svn rebase would not work before we run the
1895         commit-queue).
1896
1897         * EWSTools/start-commit-queue.sh:
1898
1899 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
1900
1901         Reviewed by Gustavo Noronha Silva.
1902
1903         [GTK] Clean up the DRT fonts.conf and switch to Liberation
1904         https://bugs.webkit.org/show_bug.cgi?id=46038
1905
1906         Switch to Liberation fonts for GTK+ layout tests. This will make our
1907         test results metric-compatible with many Windows/Chromium results. It
1908         also simplifies the fonts.conf that we load and prepares the way for
1909         fixing many font bugs.
1910
1911         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1912         (initializeFonts): Initialize a known list of fonts instead of loading
1913         every font in the WEBKIT_TESTFONTS directory.
1914         * DumpRenderTree/gtk/fonts.conf: Removed.
1915         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1916         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
1917         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
1918         we can load both fonts.conf and AHEM____.TTF from this location.
1919         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
1920         it is no longer used.
1921
1922 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
1923
1924         Reviewed by Ojan Vafai.
1925
1926         new-run-webkit-httpd fails if Perl is not installed
1927         https://bugs.webkit.org/show_bug.cgi?id=46602
1928         
1929         Make Port._read_configuration catch all exceptions, since trying to run
1930         perl (because of _webkit_build_directory) when it's not installed throws
1931         a WindowsError or OSError, not an IOError (this became an issue after 
1932         r68268, since ChromiumPort ends up calling Port.default_configuration in
1933         its constructor, which means that we're ending up on this codepath in
1934         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
1935         new-run-webkit-httpd).
1936
1937         * Scripts/webkitpy/layout_tests/port/base.py:
1938         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1939
1940 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1941
1942         Reviewed by Antonio Gomes.
1943
1944         [EFL] Add setting API to set a local storage database path.
1945         https://bugs.webkit.org/show_bug.cgi?id=45446
1946
1947         Add a setting API to set local storage database path.
1948
1949         * EWebLauncher/main.c:
1950         (on_key_down):
1951         (browserCreate):
1952         (main):
1953
1954 2010-09-26  Sam Weinig  <sam@webkit.org>
1955
1956         Reviewed by Anders Carlsson.
1957
1958         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
1959         https://bugs.webkit.org/show_bug.cgi?id=46587
1960
1961         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1962
1963 2010-09-26  Antonio Gomes  <agomes@rim.com>
1964
1965         Reviewed by Kenneth Rohde Christiansen.
1966
1967         DRT/Mac nodesFromRect support
1968
1969         [Mac][DRT] Implement LayoutTestController::nodesFromRect
1970         https://bugs.webkit.org/show_bug.cgi?id=46580
1971
1972         Implements LayoutTestController::nodesFromRect for Mac DRT, and
1973         adding stubs for GTK+ and Windows.
1974
1975         * DumpRenderTree/LayoutTestController.cpp:
1976         (nodesFromRectCallback):
1977         (LayoutTestController::staticFunctions):
1978         * DumpRenderTree/LayoutTestController.h:
1979         (LayoutTestController::LayoutTestController::nodesFromRect):
1980         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1981         (LayoutTestController::nodesFromRect):
1982
1983 2010-09-25  Nicolas Weber  <thakis@chromium.org>
1984
1985         Reviewed by Adam Barth.
1986
1987         https://bugs.webkit.org/show_bug.cgi?id=46555
1988         Fix typo in prepare-ChangeLog's help output.
1989
1990         * Scripts/prepare-ChangeLog:
1991
1992 2010-09-24  Sam Weinig  <sam@webkit.org>
1993
1994         Reviewed by Darin Adler.
1995
1996         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
1997         <rdar://problem/8359279>
1998         https://bugs.webkit.org/show_bug.cgi?id=46546
1999
2000         * MiniBrowser/mac/BrowserWindowController.m:
2001         (mouseDidMoveOverElement):
2002         (-[BrowserWindowController awakeFromNib]):
2003         * MiniBrowser/win/BrowserView.cpp:
2004         (mouseDidMoveOverElement):
2005         (BrowserView::create):
2006         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2007         (WTR::InjectedBundlePage::InjectedBundlePage):
2008         * WebKitTestRunner/TestController.cpp:
2009         (WTR::createOtherPage):
2010         (WTR::TestController::initialize):
2011
2012 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2013
2014         Reviewed by Adam Barth.
2015
2016         Allow rebaselines for webkit-patch rebaseline to be chosen
2017         https://bugs.webkit.org/show_bug.cgi?id=46407
2018         
2019         Instead of always rebaselining all failing tests, allow a subset to be
2020         chosen.
2021
2022         * Scripts/webkitpy/common/system/user.py:
2023         * Scripts/webkitpy/tool/commands/rebaseline.py:
2024
2025 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
2026
2027         Reviewed by Tony Chang.
2028
2029         [chromium] Implement TextInputController::firstRectForCharacterRange
2030         https://bugs.webkit.org/show_bug.cgi?id=38100
2031
2032         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
2033         No new tests are added since we need to implement the same feature in chromium side
2034         in order to enable any tests that uses this function.
2035
2036         * DumpRenderTree/chromium/TextInputController.cpp:
2037         (TextInputController::firstRectForCharacterRange): Added.
2038
2039 2010-09-24  Adam Barth  <abarth@webkit.org>
2040
2041         Reviewed by Eric Seidel.
2042
2043         commit-queue reports land failures as "PASS"
2044         https://bugs.webkit.org/show_bug.cgi?id=46530
2045
2046         We were ignoring the return value of land instead of passing it back to
2047         CommitQueue.  Of course, this was the one case I forgot to test!
2048
2049         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2050         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2051
2052 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
2053
2054         Reviewed by Eric Seidel.
2055
2056         new-run-webkit-tests prints out nothing when build-dumprendertree fails
2057         https://bugs.webkit.org/show_bug.cgi?id=37563
2058
2059         Print error message when build-dumprendertree fails.
2060
2061         * Scripts/webkitpy/layout_tests/port/webkit.py:
2062         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2063
2064 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2065
2066         Reviewed by Tony Chang.
2067
2068         NRWT doesn't respect config set with set-webkit-configuration
2069         https://bugs.webkit.org/show_bug.cgi?id=46278
2070         
2071         Use Port.default_configuration() instead of hardcoding Release in
2072         ChromiumPort configuration initialization, so that we still inherit the
2073         configuration set by set-webkit-configuration.
2074
2075         * Scripts/webkitpy/layout_tests/port/chromium.py:
2076         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2077
2078 2010-09-24  Chang Shu  <chang.shu@nokia.com>
2079
2080         Reviewed by Csaba Osztrogonác.
2081
2082         [Qt] Fix the code to check file existence.
2083         https://bugs.webkit.org/show_bug.cgi?id=46465
2084
2085         * QtTestBrowser/main.cpp:
2086         (main):
2087
2088 2010-09-23  Tony Chang  <tony@chromium.org>
2089
2090         Unreviewed, rolling out r68232.
2091         http://trac.webkit.org/changeset/68232
2092
2093         Broken NRWT on the canary bots.
2094
2095         * Scripts/webkitpy/layout_tests/port/chromium.py:
2096
2097 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
2098
2099         Unreviewed, build fix.
2100
2101         r68008 broke new-run-webkit-tests in that the chromium ports no
2102         longer respect set-webkit-configuration. The correct fix for this
2103         is being pursued in bug 46278 (along with a bunch of unit tests),
2104         but in the meantime I'm reverting the particular lines that broke
2105         things. This was tested by hand.
2106
2107         * Scripts/webkitpy/layout_tests/port/chromium.py:
2108
2109 2010-09-23  Sam Weinig  <sam@webkit.org>
2110
2111         Reviewed by Anders Carlsson.
2112
2113         WebKit2 API: Need way to know when a frame is removed from the hierarchy
2114         <rdar://problem/8414062>
2115         https://bugs.webkit.org/show_bug.cgi?id=46432
2116
2117         * MiniBrowser/mac/BrowserWindowController.m:
2118         (didRemoveFrameFromHierarchy):
2119         (-[BrowserWindowController awakeFromNib]):
2120         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2121         (WTR::InjectedBundlePage::InjectedBundlePage):
2122         * WebKitTestRunner/TestController.cpp:
2123         (WTR::TestController::initialize):
2124
2125 2010-09-23  Tony Chang  <tony@chromium.org>
2126
2127         Reviewed by Dimitri Glazkov.
2128
2129         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
2130         https://bugs.webkit.org/show_bug.cgi?id=46426
2131
2132         * DumpRenderTree/chromium/LayoutTestController.cpp:
2133         (LayoutTestController::LayoutTestController):
2134         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2135         * DumpRenderTree/chromium/LayoutTestController.h:
2136
2137 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2138
2139         Reviewed by Nate Chapin.
2140
2141         [GTK] r68199 introduced two test failures
2142         https://bugs.webkit.org/show_bug.cgi?id=46424
2143
2144         Fix a regression handling preference overrides that are attached to boolean properties.
2145
2146         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2147         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
2148         so we must check for that when converting a string to a boolean.
2149
2150 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
2151
2152         Reviewed by David Levin.
2153
2154         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
2155         https://bugs.webkit.org/show_bug.cgi?id=46406
2156
2157         This breaks when the method is called with specified size of data (image data), and the
2158         buffer hasn't yet reached this size.
2159
2160         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
2161           index larger than 0.
2162
2163 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2164
2165         Reviewed by Nate Chapin.
2166
2167         [GTK] Some tests from r68174 fail on the GTK+ bots
2168         https://bugs.webkit.org/show_bug.cgi?id=46396
2169
2170         Simplify LayoutTestController::overridePreference to make it easier for
2171         people unfamiliar with the code to keep the list of preferences up to date.
2172         Add the conversion for enable-hyperlink-auditing.
2173
2174         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2175         (LayoutTestController::overridePreference): Use a simple if-else block to determine
2176         out the property name for overrridePreference. Also simplify the logic for setting
2177         string properties. Add the conversion for enable-hyperlink-auditing.
2178
2179 2010-09-23  Tony Chang  <tony@chromium.org>
2180
2181         Reviewed by David Levin.
2182
2183         [chromium] add caretBrowsingEnabled to WebSettings and DRT
2184         https://bugs.webkit.org/show_bug.cgi?id=46388
2185
2186         * DumpRenderTree/chromium/LayoutTestController.cpp:
2187         (LayoutTestController::overridePreference):
2188         * DumpRenderTree/chromium/WebPreferences.cpp:
2189         (WebPreferences::reset):
2190         (WebPreferences::applyTo):
2191         * DumpRenderTree/chromium/WebPreferences.h:
2192
2193 2010-09-23  Nate Chapin  <japhet@chromium.org>
2194
2195         Reviewed by Darin Fisher.
2196
2197         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
2198         https://bugs.webkit.org/show_bug.cgi?id=30458
2199
2200         * DumpRenderTree/chromium/LayoutTestController.cpp:
2201         (LayoutTestController::overridePreference):
2202         * DumpRenderTree/chromium/WebPreferences.cpp:
2203         (WebPreferences::reset):
2204         (WebPreferences::applyTo):
2205         * DumpRenderTree/chromium/WebPreferences.h:
2206         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2207         (resetDefaultsToConsistentValues):
2208         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2209         (LayoutTestController::overridePreference):
2210
2211 2010-09-21  Stephen White  <senorblanco@chromium.org>
2212
2213         Reviewed by David Levin.
2214
2215         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
2216         https://bugs.webkit.org/show_bug.cgi?id=46208
2217
2218         This flag allows the layout tests to be run with or without accelerated
2219         2D canvas rendering.
2220
2221         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2222         (main):
2223         Declare the new flag string, and check for it on startup.
2224         * DumpRenderTree/chromium/TestShell.cpp:
2225         (TestShell::TestShell):
2226         Add a boolean for the new flag, in order to preserve its value over
2227         preferences reset.
2228         (TestShell::resetWebSettings):
2229         Set the new flag to the stored value on reset.
2230         * DumpRenderTree/chromium/TestShell.h:
2231         (TestShell::setAccelerated2dCanvasEnabled):
2232         Add an accessor for the new flag.
2233         * DumpRenderTree/chromium/WebPreferences.cpp:
2234         (WebPreferences::reset):
2235         Initialize the new flag to false.
2236         (WebPreferences::applyTo):
2237         Copy the flag's value to the WebSettings.
2238         * DumpRenderTree/chromium/WebPreferences.h:
2239         Add the new flag.
2240
2241 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2242
2243         Reviewed by Simon Hausmann.
2244
2245         [Qt] Refactor QtWebKitPlatformPlugin interface
2246
2247         Make it easier to keep source-compability for the
2248         QtWebKitPlatformPlugin interface, and run qmake
2249         on the example (but not build) for convenience. 
2250
2251         https://bugs.webkit.org/show_bug.cgi?id=46345
2252
2253         * Scripts/webkitdirs.pm:
2254
2255 2010-09-23  Adam Barth  <abarth@webkit.org>
2256
2257         Reviewed by Eric Seidel.
2258
2259         Tweak some status messages that Eric thought were confusing
2260         https://bugs.webkit.org/show_bug.cgi?id=46342
2261
2262         * Scripts/webkitpy/tool/commands/queues.py:
2263         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2264
2265 2010-09-22  Adam Barth  <abarth@webkit.org>
2266
2267         Reviewed by Eric Seidel.
2268
2269         Fix comm-queue typo
2270         https://bugs.webkit.org/show_bug.cgi?id=46339
2271
2272         We were missing a "self".  The real problem is that we didn't have an
2273         integration test for the failure case.
2274
2275         * Scripts/webkitpy/tool/commands/queues.py:
2276         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2277
2278 2010-09-22  Adam Barth  <abarth@webkit.org>
2279
2280         Reviewed by Eric Seidel.
2281
2282         commit-queue should log more detailed messages to the QueueStatusServer
2283         https://bugs.webkit.org/show_bug.cgi?id=46333
2284
2285         When I created CommitQueueTask, I removed most of the previous logging.
2286         This patch adds back more detailed logging so folks can see their patch
2287         progress through the queue.
2288
2289         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2290         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2291         * Scripts/webkitpy/tool/commands/queues.py:
2292         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2293
2294 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
2295
2296         Reviewed by Darin Fisher.
2297
2298         [Chromium] User style layout tests don't pass on Chromium
2299         https://bugs.webkit.org/show_bug.cgi?id=46069
2300
2301         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
2302         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
2303         behavior from other ports.
2304
2305         * DumpRenderTree/chromium/LayoutTestController.cpp:
2306         (LayoutTestController::addUserStyleSheet):
2307
2308 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2309
2310         Reviewed by Martin Robinson.
2311
2312         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
2313         https://bugs.webkit.org/show_bug.cgi?id=46303.
2314
2315         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
2316         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
2317         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
2318         property sheet.
2319         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
2320         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
2321         appropriate property sheet for the build types.
2322         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
2323         configuration to use appropriate property sheet for CoreFoundation
2324         and CFLite-style builds.
2325
2326 2010-09-22  Adam Barth  <abarth@webkit.org>
2327
2328         Reviewed by Eric Seidel.
2329
2330         Optimize commit-queue performance for green trees
2331         https://bugs.webkit.org/show_bug.cgi?id=46254
2332
2333         This patch redesigns the controller logic for the commit-queue.  In the
2334         new design, the controller exercises much finer-grained control over
2335         the landing process.  In particular:
2336
2337         - Patches that fail to apply now get rejected almost immediately.
2338         - Patches that fail to build get rejects after two builds (instead of
2339           three builds and one test run).
2340         - Patches that run into a flaky test now get accepted after one build
2341           and two test runs instead of three full build-and-test runs.
2342
2343         The main cost of these optimizations is that we don't find out the tree
2344         has a failing test until the very end of the process, but if the tree
2345         has a busted test, there's not much we can do anyway.  We might as well
2346         burn commit-queue resources spinning optimisticly.
2347
2348         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
2349         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
2350         * Scripts/webkitpy/tool/commands/queues.py:
2351
2352 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2353
2354         Reviewed by Martin Robinson.
2355
2356         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
2357         https://bugs.webkit.org/show_bug.cgi?id=46303.
2358
2359         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
2360         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
2361         WinCairo build.
2362         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
2363         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
2364         build targets that use the new InjectedBundleCFLite.vsprops file.
2365
2366 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2367
2368         Unreviewed, build fix.
2369
2370         Fix bustage of rebaseline-chromium-webkit-tests resulting from
2371         r67974. Really need better unit tests for this tool :(
2372
2373         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2374
2375 2010-09-22  Adam Roben  <aroben@apple.com>
2376
2377         Unbreak test-webkitpy
2378
2379         * Scripts/webkitpy/test/main.py:
2380         (Tester.run_tests): Add a line that mysteriously got deleted.
2381
2382 2010-09-22  Adam Roben  <aroben@apple.com>
2383
2384         Make test-webkitpy test WebKit2's scripts
2385
2386         These scripts can't be in WebKitTools due to limitations of Apple's
2387         build process. But that doesn't mean we can't test them!
2388
2389         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
2390         WebKit2/Scripts
2391
2392         Reviewed by Adam Barth.
2393
2394         * Scripts/test-webkitpy:
2395         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
2396         Now takes an external_package_paths parameter and cleans both webkitpy
2397         and any external packages.
2398         (init): Added an external_package_paths parameter which we pass along
2399         to _clean_packages_with_test.
2400         (top level): Add WebKit2/Scripts/webkit2 as our only external package
2401         and pass it along to init and Tester.run_tests.
2402
2403         * Scripts/webkitpy/test/main.py:
2404         (Tester.run_tests): Added an optional external_package_paths
2405         parameter. We modify sys.path so that the external packages can be
2406         imported, and search for unittest files inside all external packages
2407         in addition to inside webkitpy.
2408
2409 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2410
2411         Reviewed by Tony Chang.
2412
2413         new-run-webkit-tests: r68063 broke linux python tests
2414
2415         Add a missing "from __future__ import with_statement" to this
2416         new file; the perils of testing only on the Mac and by review :(
2417
2418         https://bugs.webkit.org/show_bug.cgi?id=46293
2419
2420         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2421
2422 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2423
2424         Reviewed by Tony Chang.
2425
2426         Add a 'chromium-gpu' set of ports that will test the accelerated
2427         GPU paths. This patch adds:
2428
2429         - support for the '--accelerated-compositing' and
2430           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
2431           'no-' flags)
2432         - adds a new set of Ports that will look under
2433           platform/chromium-gpu-$OS/ for baselines before looking in the
2434           regular chromium search path
2435         - adds a new test_expectations.txt file in platform/chromium-gpu
2436           that skips all but the tests we actually want to run with
2437           acceleration.
2438
2439         This patch will allow us to run both with and without acceleration
2440         and to change the defaults for both the regular and -gpu options
2441         as the code evolves.
2442
2443         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
2444         each test bot.
2445
2446         https://bugs.webkit.org/show_bug.cgi?id=46225
2447
2448         * Scripts/webkitpy/layout_tests/port/chromium.py:
2449         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2450         * Scripts/webkitpy/layout_tests/port/factory.py:
2451         * Scripts/webkitpy/layout_tests/port/webkit.py:
2452
2453 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
2454
2455         Reviewed by Kenneth Rohde Christiansen.
2456
2457         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
2458         https://bugs.webkit.org/show_bug.cgi?id=43988
2459
2460         Runs a web debug server on port specified by QtTestBrowser
2461         argument -remote-inspector-port. Property
2462         _q_webInspectorServerPort of the QWebPage instance will be set
2463         according to the argument. All pages with that property set will
2464         be remotely inspectable.
2465
2466         URL for remote inspection of first QWebPage is
2467             http://localhost:9222/webkit/inspector/inspector.html?page=1
2468         where 1 is the number of the QWebPage instance.
2469
2470         The base URL yields an index page with links to the individual inspectors:
2471             http://localhost:9222/
2472
2473         * QtTestBrowser/launcherwindow.cpp:
2474         (LauncherWindow::init):
2475         * QtTestBrowser/launcherwindow.h:
2476         * QtTestBrowser/main.cpp:
2477         (LauncherApplication::handleUserOptions):
2478
2479 2010-09-22  Adam Roben  <aroben@apple.com>
2480
2481         Fix webkit-patch failure-reason now that build.webkit.org has been
2482         updated
2483
2484         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
2485         every time
2486
2487         Reviewed by Eric Seidel.
2488
2489         * Scripts/webkitpy/common/net/buildbot.py:
2490         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
2491         looking for an element that contains text, then returns it.
2492         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
2493         text out of the cells. This way it doesn't matter whether the cells
2494         have <b> children (as for cells in directory rows) or not (as for
2495         cells in file rows)
2496         (BuildBot._parse_twisted_directory_listing): Look for rows that have
2497         the "directory" or "file" class, rather than rows with any class,
2498         since header rows now have a class attribute.
2499
2500         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2501         (BuildBotTest._example_directory_listing): Updated to more closely
2502         match the markup that build.webkit.org is producing now.
2503
2504 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2505
2506         Unreviewed, build fix.
2507
2508         new-run-webkit-tests: fix bug introduced in r68008 where if you
2509         specify --chromium and no --platform, and you're running on
2510         windows, you use the 'chromium-win' port by default instead of the
2511         version-specific port. This breaks the buildbots.
2512
2513         It will be good for this refactoring to settle down so I can
2514         rewrite the logic for default ports and the unit tests to be
2515         clearer (and the testing more comprehensive).
2516
2517         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2518
2519 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2520
2521         Reviewed by Adam Barth.
2522
2523         Modify the Port interface to take only a series of keyword arguments
2524         in the constructor, and modify Port/factory.get() to accomodate that,
2525         and to accept user=XXX as an argument so we can pass
2526         webkitpy.common.system.user.User objects in.
2527
2528         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
2529         to use the common routine in webkitpy.common.system.user.open_url()
2530         to display HTML files.
2531
2532         There was a routine in the Port interface to do the same thing,
2533         but I see no need for a port-specific hook for this, since it is
2534         something that will always be executed by the host environment
2535         and displaying web pages has nothing to do with running layout tests.
2536
2537         Note that new-run-webkit-tests used to use test_shell to display
2538         the page; this is potentially useful so that you can actually click
2539         from a result to the broken page; however, since DumpRenderTree
2540         doesn't support this functionality, it will be going away eventually.
2541
2542         https://bugs.webkit.org/show_bug.cgi?id=46128
2543
2544         * Scripts/webkitpy/layout_tests/port/base.py:
2545         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2546         * Scripts/webkitpy/layout_tests/port/chromium.py:
2547         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2548         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2549         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2550         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2551         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2552         * Scripts/webkitpy/layout_tests/port/factory.py:
2553         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2554         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2555         * Scripts/webkitpy/layout_tests/port/gtk.py:
2556         * Scripts/webkitpy/layout_tests/port/mac.py:
2557         * Scripts/webkitpy/layout_tests/port/qt.py:
2558         * Scripts/webkitpy/layout_tests/port/test.py:
2559         * Scripts/webkitpy/layout_tests/port/webkit.py:
2560         * Scripts/webkitpy/layout_tests/port/win.py:
2561         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2562         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2563         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2564
2565 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2566
2567         Reviewed by Kenneth Rohde Christiansen.
2568
2569         [EFL] Get fresh theme when running EWebLauncher
2570         https://bugs.webkit.org/show_bug.cgi?id=46210
2571
2572         If user tried to run EWebLauncher outside of the build tree, it would
2573         not find the theme and fallback to the installed one. However, since
2574         EWebLauncher is not installed, we always want to take the theme from
2575         the just compiled source code. If user had never installed WebKit's
2576         EFL port it could even receive a segv since no theme would be found.
2577
2578         Now EWebLauncher does not fallback to the installed theme and CMake
2579         gives as DATA_DIR the directory of the theme it has just built.
2580
2581         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
2582         EWebLauncher.
2583         * EWebLauncher/main.c: Use only the theme from build director. Do not
2584         fallback to others as this could hide real bugs.
2585         (quit):
2586         (browserCreate):
2587         (findThemePath):
2588         (main):
2589
2590 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2591
2592         Unreviewed, build fix.
2593
2594         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
2595         it just confuses it.
2596
2597         https://bugs.webkit.org/show_bug.cgi?id=46230
2598
2599         * Scripts/webkitpy/layout_tests/port/webkit.py:
2600
2601 2010-09-21  Lucas Forschler  <lforschler@apple.com>
2602
2603         Reviewed by Stephanie Lewis.
2604
2605         Make a new buildbot for Leopard Debug Test
2606
2607         * BuildSlaveSupport/build.webkit.org-config/config.json:
2608
2609 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2610
2611         Unreviewed, build fix.
2612
2613         Fix breakage of Chromium Mac DRT port caused by r67905.
2614
2615         https://bugs.webkit.org/show_bug.cgi?id=46230
2616
2617         * Scripts/webkitpy/layout_tests/port/webkit.py:
2618
2619 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2620
2621         Unreviewed, build fix.
2622
2623         Add missing import of 'tempfile'.
2624
2625         * Scripts/webkitpy/layout_tests/port/chromium.py:
2626
2627 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
2628
2629         Reviewed by Ojan Vafai.
2630
2631         new-run-webkit-tests: pull the list of tests from the Port, and
2632            make it possible to run with no actual test files in the filesystem.
2633
2634         This set of changes allows us to delete the special
2635         webkitpy/layout_tests/data directory and test the generic code without
2636         touching the filesystem (except to write results). This speeds up
2637         test-webkitpy substantially.
2638
2639         This also cleans up and removes several code paths in the generic
2640         code and fixes some minor bugs, notably in the test_expectations
2641         parsing, which was previously fragile if the tests weren't present.
2642
2643         We also change the way we diff image results to be able to do so
2644         in memory, without relying on files. This slows down chromium
2645         test_shell, which always writes images to files, but should speed
2646         up DRT and ImageDiff-based implementations slightly.
2647
2648         Note that pulling the list of tests to run from the Port will allow
2649         ports to specify what tests to run as an inclusive list; previously
2650         you could only do this as an exclusive list by using a 
2651         test_expectations file or Skipped files; nothing actually uses this
2652         feature yet and it's unclear if it should be used.
2653
2654         Note that there are no functional changes -- apart from now 
2655         always printing out the location of the checksum file when we are
2656         tracing test runs -- and the total number of lines of non-test code
2657         actually drops by two.
2658
2659         There is some more cleanup that can be done in the Port/Driver 
2660         interface and in some handling of filenames, but I'll save that
2661         for another change.
2662
2663         https://bugs.webkit.org/show_bug.cgi?id=45801
2664
2665         * Scripts/webkitpy/layout_tests/data/*: Removed.
2666             - no longer need special mock layout_tests_directory in the
2667               repository.
2668         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2669             - add code to display missing text files, checksums when tracing
2670             - update to not look at the filesystem directly.
2671         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2672             - add more unit tests
2673         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2674             - remove tests_are_present flag
2675             - update with changes in Port interface - no longer access
2676               the filesystem directly, although we still use os.path for
2677               filename manipulation.
2678         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2679             - add more unit tests
2680         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
2681             - renamed to port/test_files.py
2682         * Scripts/webkitpy/layout_tests/port/base.py:
2683             - change diff_image() to expect actual image data, not filenames
2684             - add expected_checksum(), expected_image(), expected_text() to
2685               return the content of the files so that we don't need a filesystem
2686             - add path_exists(), path_isdir() for filesystem-like access.
2687             - add test_dirs() to keep clobber-test-results from needing to
2688               actually look at a real layout tests dir
2689             - add tests() to return the list of tests to run on the port
2690               (calls port/test_files to do the work).
2691             - add update_baseline() to be able to save new baselines
2692             - add uri_to_test_name() from port/dryrun.py so we can easily check
2693               filename_to_uri()
2694         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2695             - add more unit tests
2696         * Scripts/webkitpy/layout_tests/port/chromium.py:
2697             - change diff_image() to accept image content, not filenames.
2698               This will be slower for test_shell/image_diff, but faster
2699               for DRT/ImageDiff.
2700         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2701             - add more unit tests
2702         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2703             - simplify greatly
2704         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2705             - add more unit tests
2706         * Scripts/webkitpy/layout_tests/port/test.py:
2707             - massive rewrite to use in-script list of tests and expectations
2708         * Scripts/webkitpy/layout_tests/port/test_files.py:
2709             - rename from layout_package/test_files.
2710         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2711             - add unit tests
2712         * Scripts/webkitpy/layout_tests/port/webkit.py:
2713             - update diff_image() to take image contents, not files. Should
2714               make things slightly faster.
2715         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2716             - update with changes to diff_image()
2717         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2718             - update with changes to diff_image()
2719         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2720             - remove tests_are_present from test_expectations
2721             - pull the list of tests from port.tests() instead
2722               of calling test_files.py directly.
2723         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2724             - update unit tests
2725         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2726             - update with changes to 
2727         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2728             - update with change in Port interface
2729         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2730             - update with change in Port interface
2731         * Scripts/webkitpy/style/checkers/test_expectations.py:
2732             - remove the tests_are_present flag
2733
2734 2010-09-21  Anders Carlsson  <andersca@apple.com>
2735
2736         Disable logging.
2737
2738         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2739
2740 2010-09-21  Tony Chang  <tony@chromium.org>
2741
2742         Reviewed by Kent Tamura.
2743
2744         add a script for running webkit_unit_tests
2745         https://bugs.webkit.org/show_bug.cgi?id=46014
2746
2747         * Scripts/run-chromium-webkit-unit-tests: Added.
2748
2749 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
2750
2751         Reviewed by Martin Robinson.
2752
2753         Fix linking problems on Windows.
2754         https://bugs.webkit.org/show_bug.cgi?id=45844
2755
2756         * GNUmakefile.am: link the executables with winmm.dll
2757
2758 2010-09-21  Adam Barth  <abarth@webkit.org>
2759
2760         Reviewed by Eric Seidel.
2761
2762         feeder-queue svn updates more often than needed
2763         https://bugs.webkit.org/show_bug.cgi?id=46171
2764
2765         We don't need to poll SVN every time we feed the feeders.  Rather, we
2766         can count on the wrapper shell script to auto-update the queue.
2767
2768         * Scripts/webkitpy/tool/commands/queues.py:
2769         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2770
2771 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2772
2773         Reviewed by Andreas Kling.
2774
2775         [Qt] Add robot loader timeout and extra time options.
2776         https://bugs.webkit.org/show_bug.cgi?id=46172
2777
2778         [-robot-timeout <s>]: Load the next page after s seconds if the current
2779         page didn't finish loading.
2780         [-robot-extra-time <s>]: Wait s seconds after the current page finished
2781         loading before loading the next one. This should allow some time for the
2782         page's JavaScript to execute.
2783
2784         * QtTestBrowser/launcherwindow.cpp:
2785         (LauncherWindow::applyPrefs):
2786         * QtTestBrowser/main.cpp:
2787         (LauncherApplication::robotTimeout):
2788         (LauncherApplication::robotExtraTime):
2789         (LauncherApplication::LauncherApplication):
2790         (LauncherApplication::handleUserOptions):
2791         (main):
2792         * QtTestBrowser/urlloader.cpp:
2793         (UrlLoader::UrlLoader):
2794         (UrlLoader::loadNext):
2795         (UrlLoader::loadUrlList):
2796         * QtTestBrowser/urlloader.h:
2797
2798 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
2799
2800         Unreviewed.
2801
2802         Adding myself to the committers list.
2803
2804         * Scripts/webkitpy/common/config/committers.py:
2805
2806 2010-09-20  Philippe Normand  <pnormand@igalia.com>
2807
2808         Reviewed by Eric Carlson.
2809
2810         [GTK] enhanced context menu for media elements
2811         https://bugs.webkit.org/show_bug.cgi?id=45021
2812
2813         EventSender::contextClick() now returns an array of js
2814         objects. Each object has a title property and a click() method.
2815
2816         * DumpRenderTree/gtk/EventSender.cpp:
2817         (getMenuItemTitleCallback):
2818         (setMenuItemTitleCallback):
2819         (menuItemClickCallback):
2820         (getMenuItemClass):
2821         (contextClickCallback):
2822
2823 2010-09-20  Hayato Ito  <hayato@chromium.org>
2824
2825         Unreviewed.
2826         Adding myself to the committers list.
2827
2828         * Scripts/webkitpy/common/config/committers.py:
2829
2830 2010-09-20  Adam Barth  <abarth@webkit.org>
2831
2832         Reviewed by Eric Seidel.
2833
2834         The tool member variable should be called _tool
2835         https://bugs.webkit.org/show_bug.cgi?id=46160
2836
2837         Created by find-and-replace.
2838
2839         * Scripts/webkitpy/tool/commands/download.py:
2840         * Scripts/webkitpy/tool/commands/openbugs.py:
2841         * Scripts/webkitpy/tool/commands/queries.py:
2842         * Scripts/webkitpy/tool/commands/queues.py:
2843         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2844         * Scripts/webkitpy/tool/commands/rebaseline.py:
2845         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2846         * Scripts/webkitpy/tool/commands/upload.py:
2847         * Scripts/webkitpy/tool/multicommandtool.py:
2848
2849 2010-09-20  Adam Barth  <abarth@webkit.org>
2850
2851         I ran the tests before landing but ignored the fact that they failed.  :(
2852
2853         * Scripts/webkitpy/tool/commands/queues.py:
2854
2855 2010-09-20  Adam Barth  <abarth@webkit.org>
2856
2857         Reviewed by Eric Seidel.
2858
2859         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
2860         https://bugs.webkit.org/show_bug.cgi?id=46141
2861
2862         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
2863         list of work items on the status server.  The individual commit-cluster
2864         nodes then grab the patches from the server and process them.
2865
2866         * Scripts/webkitpy/tool/bot/feeders.py: Added.
2867         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
2868         * Scripts/webkitpy/tool/commands/queues.py:
2869         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2870         * Scripts/webkitpy/tool/commands/queuestest.py:
2871
2872 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
2873
2874         Reviewed by Darin Adler.
2875
2876         build-webkit: Add support for CMake build system
2877         https://bugs.webkit.org/show_bug.cgi?id=44979
2878
2879         * Scripts/build-webkit: Add "--efl" command-line option to build the
2880         EFL port of WebKit.
2881         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
2882         buildEflCMakeProject() subroutines.
2883
2884 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
2885
2886         Reviewed by Ojan Vafai.
2887
2888         new-run-webkit-tests: refactor command line args getting passed to DRT
2889
2890         This change cleans up some argument parsing between functions to get
2891         rid of some overlapping data structures. There should be no functional
2892         changes in this patch; it is pure refactoring in preparation for
2893         landing the Chrome GPU port and adding a generic way to pass
2894         args to DRT/TestShell.
2895
2896         https://bugs.webkit.org/show_bug.cgi?id=46135
2897
2898         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2899           - pass the options argument explicitly to the threads and drivers,
2900             also consolidate the passing of options to the driver.
2901           - pass options directly to process_output() to remove a couple
2902             parameters (minor cleanup).
2903         * Scripts/webkitpy/layout_tests/port/base.py:
2904           - pass the options argument to Port.create_driver().
2905         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2906           - update Port.create_driver() test
2907         * Scripts/webkitpy/layout_tests/port/chromium.py:
2908           - pass the options argument to Port.create_driver(), and clean up
2909             building of the cmd line for DRT.
2910         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2911           - pass the options argument to Port.create_driver()
2912         * Scripts/webkitpy/layout_tests/port/test.py:
2913           - pass the options argument to Port.create_driver()
2914         * Scripts/webkitpy/layout_tests/port/webkit.py:
2915           - pass the options argument to Port.create_driver(), and clean up
2916             building of the cmd line for DRT.
2917         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2918           - consolidate args in _get_dump_render_tree_args and rename to
2919             _get_test_args(); move all of the command-line args to the
2920             Port implementations.
2921
2922 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
2923
2924         Revert change which was accidentally committed along with some expectation changes.
2925
2926         * Scripts/webkitpy/layout_tests/port/base.py:
2927
2928 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2929
2930         Reviewed by Adam Barth.
2931
2932         Add explicit --force-patch flag to webkitpy tools
2933         https://bugs.webkit.org/show_bug.cgi?id=46103
2934         
2935         It wasn't obvious until I read the applypatch.py source code that
2936         --non-interfactive implies passing --force to patch. Add --force-patch
2937         as an alias to the flag, so that this behavior is more discoverable.
2938
2939         * Scripts/webkitpy/tool/steps/applypatch.py:
2940         * Scripts/webkitpy/tool/steps/options.py:
2941
2942 2010-09-20  Eric Seidel  <eric@webkit.org>
2943
2944         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
2945
2946         commit-queue can't land patches
2947         https://bugs.webkit.org/show_bug.cgi?id=46138
2948
2949         Add a line of code I forgot in my last commit.
2950
2951         * Scripts/webkitpy/common/net/bugzilla.py:
2952         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2953
2954 2010-09-20  Adam Barth  <abarth@webkit.org>
2955
2956         Reviewed by Eric Seidel.
2957
2958         The commit-cluster bots still race to lock patch_ids
2959         https://bugs.webkit.org/show_bug.cgi?id=46130
2960
2961         It turns out we need to use a transaction object to make the
2962         read/modify/write lock operation atomic.  From reading the AppEngine
2963         documentation, I think this patch should do what we want.  It's hard to
2964         test locally because the test instance isn't distributed in the same
2965         way the production instance is.
2966
2967         * QueueStatusServer/handlers/nextpatch.py:
2968         * QueueStatusServer/model/activeworkitems.py: Added.
2969
2970 2010-09-20  Andy Estes  <aestes@apple.com>
2971
2972         Reviewed by Adam Barth.
2973
2974         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
2975         https://bugs.webkit.org/show_bug.cgi?id=40961
2976
2977         Implement WebKitUsePreHTML5ParserQuirks preference.
2978
2979         * DumpRenderTree/mac/DumpRenderTree.mm:
2980         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
2981         to false after a test finishes.
2982
2983 2010-09-20  Adam Roben  <aroben@apple.com>
2984
2985         Windows build fix
2986
2987         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
2988         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
2989         we'll pick up the most recent versions of the headers.
2990
2991 2010-09-20  Eric Seidel  <eric@webkit.org>
2992
2993         Reviewed by Adam Barth.
2994
2995         commit-queue should check commit-queue+ again just before committing
2996         https://bugs.webkit.org/show_bug.cgi?id=32679
2997
2998         Added a _revalidate_patch check, right before landing.
2999
3000         Since _revalidate_patch passes the patch_id from the work item
3001         back to bugzilla, I had to fix all of the previous queue tests to
3002         use valid attachment ids (that's the majority of this change).
3003
3004         In order to validate that the bug was still open, I had to teach
3005         bugzilla.Bug about open/closed states.
3006
3007         * Scripts/webkitpy/common/net/bugzilla.py:
3008         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3009         * Scripts/webkitpy/tool/commands/queues.py:
3010         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3011         * Scripts/webkitpy/tool/commands/queuestest.py:
3012         * Scripts/webkitpy/tool/mocktool.py:
3013
3014 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
3015
3016         Unreviewed.
3017
3018         Adding myself as a comitter.
3019
3020         * Scripts/webkitpy/common/config/committers.py:
3021
3022 2010-09-20  Adam Barth  <abarth@webkit.org>
3023
3024         Reviewed by Eric Seidel.
3025
3026         Two instances of commit-queue try to process the same patch
3027         https://bugs.webkit.org/show_bug.cgi?id=46113
3028
3029         This patch makes next-patch atomic so that the server won't vend the
3030         same patch twice in the same hour.
3031
3032         * QueueStatusServer/handlers/nextpatch.py:
3033
3034 2010-09-20  Adam Roben  <aroben@apple.com>
3035
3036         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
3037
3038         We were previously trying to use a CFRunLoopTimer, but since Windows
3039         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
3040         Windows-style timer on Windows.
3041
3042         I also replaced all uses of "watchdog" with "watchdog timer".
3043
3044         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
3045         watchdog timer doesn't work on Windows
3046
3047         Reviewed by Anders Carlsson.
3048
3049         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3050         (WTR::InjectedBundlePage::dump): Updated for rename.
3051
3052         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
3053         platform-specific functions.
3054         (WTR::LayoutTestController::LayoutTestController): Added call to
3055         platformInitialize.
3056         (WTR::LayoutTestController::waitUntilDone): Changed to call
3057         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
3058         right in this function.
3059         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
3060         rename.
3061
3062         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
3063         members needed to support the watchdog timer abstraction. Replaced
3064         some "watchdog"s with "watchdog timer".
3065
3066         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
3067         Added.
3068         (WTR::LayoutTestController::platformInitialize): Does nothing on this
3069         platform.
3070         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
3071         from LayoutTestController.cpp and changed to use an early return.
3072         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
3073         LayoutTestController.cpp.
3074         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3075         Moved code here from LayoutTestController::waitUntilDone and changed
3076         to use an early return.
3077
3078         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3079         Added.
3080         (WTR::LayoutTestController::platformInitialize): Initialize our
3081         watchdog timer.
3082         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
3083         Kills and clears the watchdog timer.
3084         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
3085         LayoutTestController member function of the same name.
3086         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3087         Added. Sets up the timer if it isn't already set.
3088
3089         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
3090         LayoutTestControllerMac.mm.
3091
3092         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
3093         LayoutTestControllerWin.cpp.
3094
3095 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
3096
3097         Reviewed by Daniel Bates.
3098
3099         [GTK] fast/forms/listbox-selection.html fails
3100         https://bugs.webkit.org/show_bug.cgi?id=45942
3101
3102         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
3103         strings in keyDownCallback.
3104
3105         * DumpRenderTree/gtk/EventSender.cpp:
3106         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
3107         modifier parsing logic.
3108
3109 2010-09-19  Sam Weinig  <sam@webkit.org>
3110
3111         Reviewed by Anders Carlsson.
3112
3113         WebKit2 decidePolicyForNavigationAction should include mouse button information
3114         <rdar://problem/8413165>
3115         https://bugs.webkit.org/show_bug.cgi?id=46060
3116
3117         * MiniBrowser/mac/BrowserWindowController.m:
3118         (decidePolicyForNavigationAction):
3119         (decidePolicyForNewWindowAction):
3120
3121 2010-09-19  Daniel Bates  <dbates@rim.com>
3122
3123         Reviewed by Martin Robinson.
3124
3125         Add unit tests for diffs that delete or modify a change log entry
3126         or describe changes that are far apart
3127         https://bugs.webkit.org/show_bug.cgi?id=46046
3128
3129         Add additional unit tests to test change log diffs that contain
3130         deletions or changes that are far apart from each other in the
3131         ChangeLog file.
3132
3133         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3134           - Added the following unit tests:
3135           "fixChangeLogPatch: [no change] In-place change."
3136           "fixChangeLogPatch: [no change] Remove first entry."
3137           "fixChangeLogPatch: [no change] Remove entry in the middle."
3138           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
3139
3140 2010-09-19  Sam Weinig  <sam@webkit.org>
3141
3142         Reviewed by Anders Carlsson.
3143
3144         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
3145         https://bugs.webkit.org/show_bug.cgi?id=46054
3146
3147         The new one acts like WKBundleNodeHandleRef and allows for getting a
3148         wrapper in a specific world for the handle.
3149
3150         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3151         (WTR::propertyValue):
3152         (WTR::propertyValueDouble):
3153         (WTR::propertyValueInt):
3154         (WTR::numericWindowPropertyValue):
3155         (WTR::toStr):
3156         (WTR::InjectedBundlePage::shouldBeginEditing):
3157         (WTR::InjectedBundlePage::shouldEndEditing):
3158         (WTR::InjectedBundlePage::shouldInsertNode):
3159         (WTR::InjectedBundlePage::shouldInsertText):
3160         (WTR::InjectedBundlePage::shouldDeleteRange):
3161         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3162         (WTR::InjectedBundlePage::shouldApplyStyle):
3163         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3164
3165 2010-09-19  Kent Tamura  <tkent@chromium.org>
3166
3167         Unreviewed. Fix WebGL test regressions by r67809.
3168
3169         * DumpRenderTree/chromium/WebPreferences.cpp:
3170         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
3171
3172 2010-09-19  Kent Tamura  <tkent@chromium.org>
3173
3174         Reviewed by Adam Barth.
3175
3176         [DRT/Chromium] Fix a WebSettings handling bug
3177         https://bugs.webkit.org/show_bug.cgi?id=45945
3178
3179         Before this change, Chromium DRT reset WebSettings for every new
3180         window. It was wrong.
3181         If new window is not the first one, we have to apply the same
3182         settings as the first window.  So, we introduce WebPreference to
3183         store the current settings, and apply it to new windows. It's same
3184         as test_shell's behavior.
3185
3186         * DumpRenderTree/DumpRenderTree.gypi:
3187         * DumpRenderTree/chromium/LayoutTestController.cpp:
3188           Use WebPreferences instead of WebSettings.
3189         (LayoutTestController::setUserStyleSheetEnabled):
3190         (LayoutTestController::setUserStyleSheetLocation):
3191         (LayoutTestController::setAuthorAndUserStylesEnabled):
3192         (LayoutTestController::setPopupBlockingEnabled):
3193         (LayoutTestController::disableImageLoading):
3194         (LayoutTestController::setJavaScriptCanAccessClipboard):
3195         (LayoutTestController::setXSSAuditorEnabled):
3196         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
3197         (LayoutTestController::setAllowFileAccessFromFileURLs):
3198         (LayoutTestController::overridePreference):
3199         (LayoutTestController::setEditingBehavior):
3200         * DumpRenderTree/chromium/TestShell.cpp:
3201         (TestShell::resetWebSettings): Use WebPreferences.
3202         (TestShell::runFileTest): ditto.
3203         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
3204         * DumpRenderTree/chromium/TestShell.h:
3205         (TestShell::preferences):
3206         (TestShell::applyPreferences):
3207         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
3208         * DumpRenderTree/chromium/WebPreferences.h: Added.
3209
3210 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
3211
3212         Reviewed by David Levin.
3213
3214         update-webkit --chromium spitting out a spurious error
3215         https://bugs.webkit.org/show_bug.cgi?id=45868
3216
3217         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
3218
3219 2010-09-18  Sam Weinig  <sam@webkit.org>
3220
3221         Reviewed by Dan Bernstein.
3222
3223         Improve/unify the PageLoadClient interfaces
3224         https://bugs.webkit.org/show_bug.cgi?id=46043
3225
3226         * MiniBrowser/mac/BrowserWindowController.m:
3227         (didStartProvisionalLoadForFrame):
3228         (didReceiveServerRedirectForProvisionalLoadForFrame):
3229         (didFailProvisionalLoadWithErrorForFrame):
3230         (didCommitLoadForFrame):
3231         (didFinishDocumentLoadForFrame):
3232         (didFinishLoadForFrame):
3233         (didFailLoadWithErrorForFrame):
3234         (didReceiveTitleForFrame):
3235         (didFirstLayoutForFrame):
3236         (didFirstVisuallyNonEmptyLayoutForFrame):
3237         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3238         (WTR::InjectedBundlePage::InjectedBundlePage):
3239         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3240         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3241         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3242         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3243         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3244         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3245         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3246         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3247         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3248         * WebKitTestRunner/TestController.cpp:
3249         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3250         (WTR::TestController::didFinishLoadForFrame):
3251         * WebKitTestRunner/TestController.h:
3252
3253 2010-09-17  Eric Seidel  <eric@webkit.org>
3254
3255         Unreviewed.  Adding a shell script I use to run the
3256         commit-queue. Now that multiple machines run the cq,
3257         it makes sense to share the script between them.
3258
3259         * EWSTools/start-commit-queue.sh: Added.
3260
3261 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
3262
3263         Reviewed by Jon Honeycutt.
3264
3265         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
3266         slightly harder to read, so this reverts the previous background colors for various
3267         states, making it easier to read.
3268
3269         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3270         (.success):
3271         (.failure):
3272         (.warnings):
3273         (.exception):
3274         (.start,.running,td.building):
3275         (.offline,td.offline):
3276
3277 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3278
3279         Unreviewed, rolling out r67692.
3280         http://trac.webkit.org/changeset/67692
3281         https://bugs.webkit.org/show_bug.cgi?id=46011
3282
3283         broke layout test dashboard (Requested by johnny_g on
3284         #webkit).
3285
3286         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3287         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3288         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3289
3290 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
3291
3292         Reviewed by Oliver Hunt.
3293
3294         Style bot complains about cairo forward declaration naming
3295         https://bugs.webkit.org/show_bug.cgi?id=45867
3296
3297         Exclude Cairo forward declarations from indentifiers with underscores checks.
3298
3299         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
3300         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3301
3302 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
3303
3304         Reviewed by Ojan Vafai.
3305
3306         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
3307         https://bugs.webkit.org/show_bug.cgi?id=45408
3308
3309         This change also tries to remove duplicated upload_results_json methods
3310         in run_webkit_tests.py and json_results_generator.py.
3311
3312         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3313         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3314         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3315
3316 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
3317
3318         Reviewed by Andreas Kling.
3319
3320         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
3321
3322         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
3323         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
3324         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
3325         all page specific stuff to the UI.
3326
3327         * QtTestBrowser/launcherwindow.cpp:
3328         (LauncherWindow::initializeView):
3329         * QtTestBrowser/mainwindow.cpp:
3330         (MainWindow::MainWindow):
3331         (MainWindow::buildUI):
3332         (MainWindow::setPage):
3333         * QtTestBrowser/mainwindow.h:
3334
3335 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3336
3337         Reviewed by Andreas Kling.
3338
3339         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
3340
3341         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
3342         object will move to the qgraphicsscene instead of the qgraphicsview.
3343
3344         * QtTestBrowser/webview.cpp:
3345         (WebViewGraphicsBased::setPage):
3346         (WebViewGraphicsBased::setResizesToContents):
3347         (WebViewGraphicsBased::resizeEvent):
3348         (WebViewGraphicsBased::animatedFlip):
3349         * QtTestBrowser/webview.h:
3350         (WebViewGraphicsBased::setItemCacheMode):
3351         (WebViewGraphicsBased::itemCacheMode):
3352
3353 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3354
3355         Reviewed by Andreas Kling.
3356
3357         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
3358
3359         We usually separate methods whose body are larger than a few lines from the class definition.
3360
3361         * QtTestBrowser/webview.h:
3362         (WebViewGraphicsBased::yRotation):
3363         (WebViewGraphicsBased::setYRotation):
3364
3365 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3366
3367         Reviewed by Andreas Kling.
3368
3369         Make initializeView method of LauncherWindow private.
3370
3371         No one else needs to be able to call it but LauncherWindow.
3372         Also moving the declation of isGraphicsBased method down in the same file, in order
3373         to better group related methods.
3374
3375         * QtTestBrowser/launcherwindow.h:
3376
3377 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3378
3379         Reviewed by Andreas Kling.
3380
3381         Make the getter 'page' method of MainWindow const.
3382
3383         * QtTestBrowser/mainwindow.cpp:
3384         (MainWindow::page):
3385         * QtTestBrowser/mainwindow.h:
3386
3387 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3388
3389         Reviewed by Andreas Kling.
3390
3391         Remove useless parameter from MainWindow class' constructor.
3392
3393         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
3394         not referred in the constructor body and does not make much sense.
3395
3396         * QtTestBrowser/mainwindow.cpp:
3397         (MainWindow::MainWindow):
3398         * QtTestBrowser/mainwindow.h:
3399
3400 2010-09-15  Tony Chang  <tony@chromium.org>
3401
3402         Reviewed by Kent Tamura.
3403
3404         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
3405         https://bugs.webkit.org/show_bug.cgi?id=42151
3406
3407         * DumpRenderTree/chromium/LayoutTestController.cpp:
3408         (LayoutTestController::LayoutTestController):
3409         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3410         (WorkItemLoadHTMLString::run):
3411         (LayoutTestController::queueLoadHTMLString):
3412         (LayoutTestController::reset):
3413         (LayoutTestController::setDeferMainResourceDataLoad):
3414         * DumpRenderTree/chromium/LayoutTestController.h:
3415         (LayoutTestController::deferMainResourceDataLoad):
3416         * DumpRenderTree/chromium/WebViewHost.cpp:
3417         (WebViewHost::didCreateDataSource):
3418
3419 2010-09-16  Adrienne Walker  <enne@google.com>
3420
3421         Reviewed by Kenneth Russell.
3422
3423         Add script to synchronize WebKit and Khronos WebGL tests
3424         https://bugs.webkit.org/show_bug.cgi?id=42336
3425
3426         * Scripts/update-webgl-conformance-tests: Added.
3427         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
3428         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
3429
3430 2010-09-16  Sam Weinig  <sam@webkit.org>
3431
3432         Reviewed by Anders Carlsson.
3433
3434         Add support for sending synchronous messages from the InjectedBundle to the WKContext
3435         <rdar://problem/8365320>
3436         https://bugs.webkit.org/show_bug.cgi?id=44785
3437
3438         * MiniBrowser/mac/AppDelegate.m:
3439         (didReceiveSynchronousMessageFromInjectedBundle):
3440         (-[BrowserAppDelegate init]):
3441         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3442         (didCreatePage):
3443         * WebKitTestRunner/TestController.cpp:
3444         (WTR::TestController::initialize):
3445
3446 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
3447
3448         Reviewed by Andreas Kling.
3449
3450         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
3451         https://bugs.webkit.org/show_bug.cgi?id=45885
3452
3453         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
3454
3455         * QtTestBrowser/launcherwindow.cpp:
3456         (LauncherWindow::screenshot):
3457
3458 2010-09-16  Anders Carlsson  <andersca@apple.com>
3459
3460         Fix clang++ build.
3461
3462         * MiniBrowser/mac/BrowserWindowController.m:
3463         (-[BrowserWindowController zoomIn:]):
3464         (-[BrowserWindowController zoomOut:]):
3465         (-[BrowserWindowController resetZoom:]):
3466         Remove trailing semicolons.
3467
3468 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3469
3470         Unreviewed, rolling out r67628.
3471         http://trac.webkit.org/changeset/67628
3472         https://bugs.webkit.org/show_bug.cgi?id=45904
3473
3474         broke the build (Requested by eric_carlson on #webkit).
3475
3476         * DumpRenderTree/gtk/EventSender.cpp:
3477         (contextClickCallback):
3478
3479 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
3480
3481         Unreviewed.
3482
3483         Adding myself as a comitter.
3484
3485         * Scripts/webkitpy/common/config/committers.py:
3486
3487 2010-09-15  Philippe Normand  <pnormand@igalia.com>
3488
3489         Reviewed by Eric Carlson.
3490
3491         [GTK] enhanced context menu for media elements
3492         https://bugs.webkit.org/show_bug.cgi?id=45021
3493
3494         EventSender::contextClick() now returns an array of js
3495         objects. Each object has a title property and a click() method.
3496
3497         * DumpRenderTree/gtk/EventSender.cpp:
3498         (getMenuItemTitleCallback):
3499         (setMenuItemTitleCallback):
3500         (menuItemClickCallback):
3501         (getMenuItemClass):
3502         (contextClickCallback):
3503
3504 2010-09-14  Philippe Normand  <pnormand@igalia.com>
3505
3506         Reviewed by Eric Carlson and Martin Robinson.
3507
3508         [GTK] eventSender.contextClick() should return the contents of the context menu
3509         https://bugs.webkit.org/show_bug.cgi?id=39102
3510
3511         Make the eventSender use the new private WebKitGtk+ API to
3512         retrieve the context-menu item titles and store them in an array.
3513
3514         * DumpRenderTree/gtk/EventSender.cpp:
3515         (contextClickCallback):
3516
3517 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
3518
3519         Reviewed by Jian Li.
3520
3521         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
3522         https://bugs.webkit.org/show_bug.cgi?id=45798
3523
3524         * Scripts/build-webkit:
3525
3526 2010-09-16  Robert Hogan  <robert@webkit.org>
3527
3528         Reviewed by Antonio Gomes.
3529
3530         [Qt] Support globalhistory tests
3531         https://bugs.webkit.org/show_bug.cgi?id=45774
3532
3533         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3534         (WebCore::isGlobalHistoryTest):
3535         (WebCore::DumpRenderTree::open):
3536         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3537         (LayoutTestController::reset):
3538         (LayoutTestController::dumpHistoryCallbacks):
3539         (LayoutTestController::removeAllVisitedLinks):
3540         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3541
3542 2010-09-10  Tony Chang  <tony@chromium.org>
3543
3544         Reviewed by Eric Seidel.
3545
3546         deduplicate-tests should be runnable from any WebKit directory
3547         https://bugs.webkit.org/show_bug.cgi?id=44709
3548
3549         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3550         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3551
3552 2010-09-15  Tony Chang  <tony@chromium.org>
3553
3554         Reviewed by Kent Tamura.
3555
3556         [chromium] sort testing methods in DRT
3557         https://bugs.webkit.org/show_bug.cgi?id=45850
3558
3559         * DumpRenderTree/chromium/EventSender.cpp:
3560         (EventSender::EventSender):
3561         * DumpRenderTree/chromium/LayoutTestController.cpp:
3562         (LayoutTestController::LayoutTestController):
3563         * DumpRenderTree/chromium/TextInputController.cpp:
3564         (TextInputController::TextInputController):
3565
3566 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3567
3568         Reviewed by Adam Barth.
3569
3570         CQ status shows items out of order
3571         https://bugs.webkit.org/show_bug.cgi?id=45846
3572         
3573         Only group consecutive status items with the same patch ID into the same
3574         group, so that overall item ordering is preserved.
3575         
3576         Also don't indent status items that only have a single item in their
3577         group.
3578
3579         * QueueStatusServer/handlers/queuestatus.py:
3580         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
3581         * QueueStatusServer/templates/queuestatus.html:
3582
3583 2010-09-15  Eric Seidel  <eric@webkit.org>
3584
3585         Reviewed by Adam Barth.
3586
3587         Add queue start/stop messages
3588         https://bugs.webkit.org/show_bug.cgi?id=45853
3589
3590         I ended up needing to clean up a bunch of our unit testing
3591         in order to test this new code path nicely.
3592
3593         There are also a few PEP8 changes needed to pass check-webkit-style.
3594
3595         * Scripts/webkitpy/tool/bot/queueengine.py:
3596         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3597         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3598         * Scripts/webkitpy/tool/commands/queues.py:
3599         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3600         * Scripts/webkitpy/tool/commands/queuestest.py:
3601         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3602
3603 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
3604
3605         https://bugs.webkit.org/show_bug.cgi?id=45849
3606         WKURLCreateWithCFURL crashes with null url
3607         
3608         Fix MiniBrowser crash when the url is not parseable.
3609
3610         * MiniBrowser/mac/BrowserWindowController.m:
3611         (-[BrowserWindowController fetch:]):
3612
3613 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
3614
3615         Unreviewed.
3616
3617         Adding myself to the committers list.
3618
3619         * Scripts/webkitpy/common/config/committers.py:
3620
3621 2010-09-14  Eric Seidel  <eric@webkit.org>
3622
3623         Reviewed by Adam Barth.
3624
3625         Make it possible to run more than one commit-queue instance
3626         https://bugs.webkit.org/show_bug.cgi?id=45786
3627
3628         Mostly we need to make sure the two (or more) instances get
3629         different patches to work on.  To do this, I re-worked
3630         the code responsible for getting the next work item to
3631         round trip through the status server.  The status server only
3632         vends patches from the work items list, only if those patches
3633         have not had status reported for them in the last hour.
3634
3635         This is another step towards making all queues go through the
3636         status server, thus making it possible to run more than one
3637         instance of various EWS bots (as requested in bug 44292).
3638
3639         The webkitpy changes are already covered by existing unit tests.
3640         The QueueStatusSever sadly has no testing infrastructure yet. :(
3641
3642         * QueueStatusServer/handlers/nextpatch.py: Added.
3643         * QueueStatusServer/index.yaml:
3644         * QueueStatusServer/main.py:
3645         * Scripts/webkitpy/tool/commands/queues.py:
3646
3647 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3648
3649         Reviewed by Tony Chang.
3650
3651         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
3652         https://bugs.webkit.org/show_bug.cgi?id=45791
3653
3654         Force filenames to be raw bytes before running difflib.unified_diff.
3655
3656         * Scripts/webkitpy/layout_tests/port/base.py:
3657         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3658
3659 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
3660
3661         Reviewed by Tor Arne Vestbø.
3662
3663         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
3664         https://bugs.webkit.org/show_bug.cgi?id=35247
3665
3666         The main issue when changing the views is that the plugins and any other components that
3667         depend on view specific attributes such as the native window id are not teared down.
3668         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
3669         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
3670         we decided to work around this in QtTestBrowser by making toggling between QWebView
3671         and QGraphicsWebView also re-create the page.
3672
3673         * QtTestBrowser/launcherwindow.cpp:
3674         (LauncherWindow::initializeView):
3675         * QtTestBrowser/mainwindow.h:
3676
3677 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
3678
3679         Reviewed by Adam Barth.
3680
3681         Send webkit accessibility notifications to Chromium
3682         https://bugs.webkit.org/show_bug.cgi?id=45156
3683
3684         Move printf inside shouldDumpAccessibilityNotifications check.
3685
3686         * DumpRenderTree/chromium/WebViewHost.cpp:
3687         (WebViewHost::postAccessibilityNotification):
3688
3689 2010-09-14  Tony Chang  <tony@chromium.org>
3690
3691         Reviewed by Kent Tamura.
3692
3693         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
3694         https://bugs.webkit.org/show_bug.cgi?id=45788
3695
3696         * DumpRenderTree/chromium/LayoutTestController.cpp:
3697         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
3698
3699 2010-09-14  Tony Chang  <tony@chromium.org>
3700
3701         Reviewed by Ojan Vafai.
3702
3703         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
3704         https://bugs.webkit.org/show_bug.cgi?id=45768
3705
3706         * DumpRenderTree/chromium/TestShell.cpp:
3707         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
3708
3709 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
3710
3711         [wx] Build fix, add newly added directories to the directory list.
3712
3713         * wx/build/settings.py:
3714
3715 2010-09-14  Sam Weinig  <sam@webkit.org>
3716
3717         Reviewed by Anders Carlsson.
3718
3719         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
3720         https://bugs.webkit.org/show_bug.cgi?id=45785
3721
3722         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3723         (WTR::propertyValue):
3724         (WTR::numericWindowPropertyValue):
3725         (WTR::dumpPath):
3726         (WTR::toStr):
3727         (WTR::operator<<):
3728         (WTR::InjectedBundlePage::InjectedBundlePage):
3729         (WTR::InjectedBundlePage::shouldInsertNode):
3730         (WTR::InjectedBundlePage::shouldBeginEditing):
3731         (WTR::InjectedBundlePage::shouldEndEditing):
3732         (WTR::InjectedBundlePage::shouldInsertText):
3733         (WTR::InjectedBundlePage::shouldDeleteRange):
3734         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3735         (WTR::InjectedBundlePage::shouldApplyStyle):
3736         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3737
3738 2010-09-14  Adam Barth  <abarth@webkit.org>
3739
3740         Fix two typos in commit-queue.  The first is harmless.  The second
3741         causes the queue to reject patches when the build is broken.  :(
3742
3743         * Scripts/webkitpy/tool/commands/queues.py:
3744         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3745
3746 2010-09-14  Chris Guillory   <chris.guillory@google.com>
3747
3748         Reviewed by Chris Fleizach.
3749
3750         Send all accessibility notifications to Chromium.
3751         https://bugs.webkit.org/show_bug.cgi?id=45156
3752
3753         * DumpRenderTree/chromium/WebViewHost.cpp:
3754         (WebViewHost::postAccessibilityNotification):
3755         * DumpRenderTree/chromium/WebViewHost.h:
3756
3757 2010-09-14  Adam Barth  <abarth@webkit.org>
3758
3759         Reviewed by Eric Seidel.
3760
3761         commit-queue is slow during the day
3762         https://bugs.webkit.org/show_bug.cgi?id=45780
3763
3764         Thanks to the new logging, we've noticed that checkout-is-out-of-date
3765         errors in the first pass of landing don't retry the land.  Instead,
3766         they're treated as failures and cause the commit-queue to do two more
3767         builds before really trying to land the patch.  Worse, in the second
3768         build, we can get bitten by a flaky test.
3769
3770         This patch takes a slightly different approach to the commit-queue's
3771         main control logic.  We now use a separate subprocess for building and
3772         testing and for landing.  This means we should very rarely see the
3773         checkout-is-out-of-date error, and when we do see it, we should retry
3774         more quickly.  If my understanding is correct, this should be a big
3775         speed win for the commit-queue.
3776
3777         * Scripts/webkitpy/tool/commands/download.py:
3778         * Scripts/webkitpy/tool/commands/queues.py:
3779         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3780
3781 2010-09-14  Tony Chang  <tony@chromium.org>
3782
3783         Reviewed by Dimitri Glazkov.
3784
3785         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
3786         https://bugs.webkit.org/show_bug.cgi?id=45762
3787
3788         * DumpRenderTree/chromium/LayoutTestController.cpp:
3789         (LayoutTestController::LayoutTestController):
3790         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
3791         * DumpRenderTree/chromium/LayoutTestController.h:
3792
3793 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
3794
3795         Adding myself as a reviewer.
3796
3797         * Scripts/webkitpy/common/config/committers.py:
3798
3799 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
3800
3801         Reviewed by Kenneth Rohde Christiansen.
3802
3803         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
3804         https://bugs.webkit.org/show_bug.cgi?id=45736
3805
3806         Build-webkit has showed a warning when WebKitBuild didn't exist, add
3807         an additional condition to avoid it.
3808
3809         * Scripts/build-webkit:
3810
3811 2010-09-13  Eric Seidel  <eric@webkit.org>
3812
3813         Reviewed by Adam Barth.
3814
3815         commit-queue should log when it's retrying due to checkout out of date error
3816         https://bugs.webkit.org/show_bug.cgi?id=45725
3817
3818         This will allow us to better track how often we see these errors
3819         and how long it takes the queue to recover from them.
3820
3821         In order to pass the tests, I had to correct an error
3822         from a previous change.  The UnitTestPort should not have
3823         ever been using the base port method as that will read
3824         a file from disk.  If the unit tests haven't passed the contents
3825         it should raise an IOError as though the file doesn't exist.
3826
3827         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3828         * Scripts/webkitpy/tool/commands/queues.py:
3829         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3830
3831 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
3832
3833         Reviewed by Adam Barth.
3834
3835         Upload results when cq patch landing fails
3836         https://bugs.webkit.org/show_bug.cgi?id=45683
3837         
3838         Include script errors when CommitQueue._land fails.
3839
3840         * Scripts/webkitpy/tool/commands/queues.py:
3841
3842 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
3843
3844         Reviewed by David Kilzer.
3845
3846         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
3847         https://bugs.webkit.org/show_bug.cgi?id=45548
3848
3849         * DumpRenderTree/AccessibilityUIElement.cpp:
3850         (isIgnoredCallback):
3851         (AccessibilityUIElement::getJSClass):
3852         * DumpRenderTree/AccessibilityUIElement.h:
3853         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3854         (AccessibilityUIElement::isIgnored):
3855         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3856         (AccessibilityUIElement::isIgnored):
3857         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3858         (AccessibilityUIElement::isIgnored):
3859
3860 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
3861
3862         Reviewed by Andreas Kling.
3863
3864         jscPath() is incorrect in Windows' cmd.exe shell
3865         https://bugs.webkit.org/show_bug.cgi?id=45651
3866
3867         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
3868
3869 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
3870
3871         Reviewed by Darin Adler.
3872
3873         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
3874         https://bugs.webkit.org/show_bug.cgi?id=43807
3875
3876         * DumpRenderTree/AccessibilityUIElement.cpp:
3877         (textMarkerForPointCallback):
3878         (AccessibilityUIElement::textMarkerForPoint):
3879         (AccessibilityUIElement::getJSClass):
3880         * DumpRenderTree/AccessibilityUIElement.h:
3881         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3882         (AccessibilityUIElement::textMarkerForPoint):
3883
3884 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
3885
3886         Reviewed by Kenneth Rohde Christiansen.
3887
3888         [Qt] build-webkit: Add --v8 option to build against V8
3889
3890         Note that V8 is picked up from QtScript, so this currently requires building
3891         against the experimental qt-script-v8 branch.
3892
3893         * Scripts/build-webkit:
3894
3895 2010-09-13  Hans Wennborg  <hans@chromium.org>
3896
3897         Reviewed by Jeremy Orlow.
3898
3899         Add WebDeviceOrientationClientMock::create() and use it from DRT.
3900         https://bugs.webkit.org/show_bug.cgi?id=45650
3901
3902         Do not use the WebDeviceOrientationClientMock constructor directly,
3903         but use the create() member function.
3904
3905         This should fix the linker errors for the multi-DLL Chromium DRT build.
3906
3907         * DumpRenderTree/chromium/LayoutTestController.cpp:
3908         (LayoutTestController::setMockDeviceOrientation):
3909         (LayoutTestController::deviceOrientationClient):
3910
3911 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
3912
3913         Reviewed by Antti Koivisto.
3914
3915         Add support for testing the viewport meta tag algorithm,
3916         based on the following draft spec:
3917
3918         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
3919
3920         Add common handling of viewport meta tag based on new Opera spec
3921         https://bugs.webkit.org/show_bug.cgi?id=44201
3922
3923         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3924         (LayoutTestController::dumpConfigurationForViewport):
3925         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3926
3927 2010-09-12  Kent Tamura  <tkent@chromium.org>
3928
3929         Reviewed by Tony Chang.
3930
3931         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
3932         https://bugs.webkit.org/show_bug.cgi?id=45517
3933
3934         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
3935
3936         * DumpRenderTree/chromium/ImageDiff.cpp:
3937         (Image::craeteFromStdin):
3938         (Image::createFromFilename):
3939         (diffImages):
3940         * DumpRenderTree/chromium/TestShell.cpp:
3941         (TestShell::dumpImage):
3942
3943 2010-09-10  MORITA Hajime  <morrita@google.com>
3944
3945         Reviewed by Tony Chang.
3946
3947         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
3948         https://bugs.webkit.org/show_bug.cgi?id=45441
3949
3950         Added TextInputController::hasSpellingMarker().
3951         
3952         * DumpRenderTree/chromium/TextInputController.cpp:
3953         (TextInputController::TextInputController):
3954         (TextInputController::hasSpellingMarker):
3955         * DumpRenderTree/chromium/TextInputController.h:
3956
3957 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
3958
3959         Unreviewed, build fix.
3960
3961         My last change accidentally contained a local change to the
3962         rebaselinig script; webkit-patch land picked it up without telling
3963         me and committed it :(
3964
3965         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3966
3967 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
3968
3969         Reviewed by Anders Carlsson.
3970
3971         Attempt to fix Windows MiniBrowser build (untested)
3972         https://bugs.webkit.org/show_bug.cgi?id=45609
3973
3974         * MiniBrowser/win/BrowserView.cpp:
3975         (runJavaScriptConfirm):
3976         (runJavaScriptPrompt):
3977
3978 2010-09-11  Sam Weinig  <sam@webkit.org>
3979
3980         Reviewed by Maciej Stachowiak.
3981
3982         Fix zoom related tests when testing WebKit2.
3983
3984         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3985         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
3986
3987 2010-09-11  Sam Weinig  <sam@webkit.org>
3988
3989         Reviewed by Dan Bernstein.
3990
3991         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
3992         <rdar://problem/8359252>
3993         https://bugs.webkit.org/show_bug.cgi?id=45605
3994
3995         * MiniBrowser/mac/BrowserWindowController.m:
3996         (setStatusText):
3997         (contentsSizeChanged):
3998         (-[BrowserWindowController awakeFromNib]):
3999         * MiniBrowser/win/BrowserView.cpp:
4000         (runJavaScriptConfirm):
4001         (runJavaScriptPrompt):
4002         (setStatusText):
4003         (contentsSizeChanged):
4004         (BrowserView::create):
4005         * WebKitTestRunner/TestController.cpp:
4006         (WTR::createOtherPage):
4007         (WTR::TestController::initialize):
4008
4009 2010-09-11  Sam Weinig  <sam@webkit.org>
4010
4011         Reviewed by Dan Bernstein.
4012
4013         Add callback mechanism for the getting the source of a frame
4014         <rdar://problem/8364681>
4015         https://bugs.webkit.org/show_bug.cgi?id=45604
4016
4017         Add ability to dump the main frame's source to the console.
4018
4019         * MiniBrowser/mac/BrowserWindowController.h:
4020         * MiniBrowser/mac/BrowserWindowController.m:
4021         (-[BrowserWindowController dumpSourceToConsole:]):
4022         * MiniBrowser/mac/MainMenu.xib:
4023
4024 2010-09-11  Eric Seidel  <eric@webkit.org>
4025
4026         Reviewed by Adam Barth.
4027
4028         Remove unneeded Empty Queue messages
4029         https://bugs.webkit.org/show_bug.cgi?id=45602
4030
4031         We already have a /gc job to delete these.
4032         recentstatus.py is already smart enough to use the
4033         most recent of the workitems last update or the most recent status,
4034         so removing these should not change the _last_status_date() return
4035         value more than a few milliseconds.
4036
4037         These messages just spam the recent status log.
4038
4039         * Scripts/webkitpy/tool/commands/queues.py:
4040
4041 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
4042
4043         Reviewed by Adam Barth.
4044
4045         Fix Python exception when generating synthetic patch IDs
4046         https://bugs.webkit.org/show_bug.cgi?id=45592
4047
4048         Can't concatenate strings and numbers directly.
4049
4050         * QueueStatusServer/handlers/queuestatus.py:
4051
4052 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
4053
4054         Reviewed by Adam Barth.
4055
4056         Group statuses in queue status by patch ID
4057         https://bugs.webkit.org/show_bug.cgi?id=45588
4058
4059         Group statuses by patch ID so that the status page is easier
4060         to scan.
4061
4062         * QueueStatusServer/handlers/queuestatus.py:
4063         * QueueStatusServer/stylesheets/dashboard.css:
4064         (.status-group):
4065         (.status-bug):
4066         (.status-group ul):
4067         (.status-group ul li):
4068         (.status-group ul li:hover):
4069         (.status-cell):
4070         (.status-cell:hover):
4071         (.status-cell.pass):
4072         (.status-cell.fail):
4073         (.status-cell.pending):
4074         (.status-cell.error):
4075         * QueueStatusServer/templates/dashboard.html:
4076         * QueueStatusServer/templates/queuestatus.html:
4077
4078 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
4079
4080         Reviewed by Tony Chang.
4081
4082         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
4083         https://bugs.webkit.org/show_bug.cgi?id=45479
4084
4085         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
4086         implementation in ResourceLoadDelegate in the Mac port).
4087
4088         * DumpRenderTree/chromium/LayoutTestController.cpp:
4089         (LayoutTestController::LayoutTestController):
4090         (LayoutTestController::dumpResourceResponseMIMETypes):
4091         (LayoutTestController::reset):
4092         * DumpRenderTree/chromium/LayoutTestController.h:
4093         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
4094         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
4095         * DumpRenderTree/chromium/TestShell.h:
4096         (TestShell::shouldDumpResourceResponseMIMETypes):
4097         * DumpRenderTree/chromium/WebViewHost.cpp:
4098         (WebViewHost::didReceiveResponse):
4099
4100 2010-09-11  Eric Seidel  <eric@webkit.org>
4101
4102         Reviewed by Adam Barth.
4103
4104         queues.webkit.org should expose /remote_api for data upload/download
4105         https://bugs.webkit.org/show_bug.cgi?id=45559
4106
4107         * QueueStatusServer/app.yaml:
4108          - /remote_api is a standard app-engine service which allows use of
4109            the bulk uploader for data upload/download.  Exposing this
4110            (for admin access only) allows us to use 
4111
4112 2010-09-10  Sam Weinig  <sam@webkit.org>
4113
4114         Reviewed by Dan Bernstein.
4115
4116         Add zoom support to WebKit2 API
4117         <rdar://problem/7660657>
4118         https://bugs.webkit.org/show_bug.cgi?id=45585
4119
4120         - Add zoom options to MiniBrowser that mimic Safari's options using
4121           the new WebKit2 zoom APIs.
4122         - Switch uses of float for the zoom APIs to use double.
4123
4124         * MiniBrowser/mac/BrowserWindowController.h:
4125         * MiniBrowser/mac/BrowserWindowController.m:
4126         (-[BrowserWindowController initWithPageNamespace:]):
4127         (-[BrowserWindowController validateMenuItem:]):
4128         (-[BrowserWindowController validateUserInterfaceItem:]):
4129         (-[BrowserWindowController currentZoomFactor]):
4130         (-[BrowserWindowController setCurrentZoomFactor:]):
4131         (-[BrowserWindowController canZoomIn]):
4132         (-[BrowserWindowController zoomIn:]):
4133         (-[BrowserWindowController canZoomOut]):
4134         (-[BrowserWindowController zoomOut:]):
4135         (-[BrowserWindowController canResetZoom]):
4136         (-[BrowserWindowController resetZoom:]):
4137         (-[BrowserWindowController toggleZoomMode:]):
4138         * MiniBrowser/mac/MainMenu.xib:
4139         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4140         (WTR::EventSendingController::textZoomIn):
4141         (WTR::EventSendingController::textZoomOut):
4142         (WTR::EventSendingController::zoomPageIn):
4143         (WTR::EventSendingController::zoomPageOut):
4144
4145 2010-09-10  Robert Hogan  <robert@webkit.org>
4146
4147         Reviewed by Andreas Kling.
4148
4149         [Qt] Fix crash in DRT in standalone mode
4150
4151         https://bugs.webkit.org/show_bug.cgi?id=45454
4152
4153         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4154         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
4155
4156 2010-09-10  Sam Weinig  <sam@webkit.org>
4157
4158         Reviewed by Darin Adler.
4159
4160         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
4161         Precursor to <rdar://problem/7660657>
4162         https://bugs.webkit.org/show_bug.cgi?id=45522
4163
4164         Update for changes to the Bundle API to allow separate control of page and text zoom
4165         levels.
4166
4167         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4168         (WTR::EventSendingController::textZoomIn):
4169         (WTR::EventSendingController::textZoomOut):
4170         (WTR::EventSendingController::zoomPageIn):
4171         (WTR::EventSendingController::zoomPageOut):
4172         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4173         (WTR::InjectedBundlePage::reset):
4174
4175 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
4176
4177         Reviewed by Andreas Kling.
4178
4179         [Qt] Support click event for notifications
4180         https://bugs.webkit.org/show_bug.cgi?id=44836
4181
4182         Add support for simulateDesktopNotificationClick by calling
4183         back to DumpRenderTreeSupportQt.cpp.
4184
4185         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4186         (LayoutTestController::simulateDesktopNotificationClick):
4187         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4188
4189 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
4190
4191         Reviewed by Eric Seidel.
4192
4193         Update queue status when patches fail their first land attempt
4194         https://bugs.webkit.org/show_bug.cgi?id=45583
4195
4196         Add a few more _update_status calls to make it more obvious if a patch is 
4197         being retried because tests failed.
4198
4199         * Scripts/webkitpy/tool/commands/queues.py:
4200
4201 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
4202
4203         Reviewed by Andreas Kling.
4204
4205         [Qt] MiniBrowser crashes with multiply windows when closing one of them
4206         https://bugs.webkit.org/show_bug.cgi?id=45536
4207
4208         * MiniBrowser/qt/BrowserView.cpp:
4209         (BrowserView::BrowserView): Reference the context instead of adopting it
4210         because it can be shared across different views.
4211
4212 2010-09-10  Tony Chang  <tony@chromium.org>
4213
4214         Unreviewed, rolling out r67241.
4215         http://trac.webkit.org/changeset/67241
4216         https://bugs.webkit.org/show_bug.cgi?id=44709
4217
4218         Accidentally committed.
4219
4220         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
4221         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
4222
4223 2010-09-10  Tony Chang  <tony@chromium.org>
4224
4225         Reviewed by Ojan Vafai.
4226
4227         deduplicate-tests should be runnable from any WebKit directory
4228         https://bugs.webkit.org/show_bug.cgi?id=44709
4229
4230         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
4231         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
4232
4233 2010-09-10  Tony Chang  <tony@chromium.org>
4234
4235         Unreviewed, rolling out r67216.
4236         http://trac.webkit.org/changeset/67216
4237         https://bugs.webkit.org/show_bug.cgi?id=44709
4238
4239         Broke
4240
4241         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
4242         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
4243
4244 2010-09-10  Tony Chang  <tony@chromium.org>
4245