2009-11-27 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-27  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         [bzt] unit test ApplyPatches and ApplyAttachment
6         https://bugs.webkit.org/show_bug.cgi?id=31935
7
8         * Scripts/modules/commands/download.py:
9         * Scripts/modules/commands/download_unittest.py:
10
11 2009-11-27  Adam Barth  <abarth@webkit.org>
12
13         Reviewed by Eric Seidel.
14
15         [bzt] Unit test download commands
16         https://bugs.webkit.org/show_bug.cgi?id=31923
17
18         Adds download_unittest and fixes a bug found while testing.
19
20         * Scripts/modules/commands/commandtest.py:
21         * Scripts/modules/commands/download.py:
22             Fixed a bug where we'd throw an error because [].append returns
23             None.
24         * Scripts/modules/commands/download_unittest.py: Added.
25         * Scripts/modules/mock_bugzillatool.py:
26         * Scripts/run-webkit-unittests:
27
28 2009-11-27  Adam Barth  <abarth@webkit.org>
29
30         Unreviewed "build" fix found while writing unit tests.
31
32         * Scripts/modules/commands/download.py:
33
34 2009-11-27  Adam Barth  <abarth@webkit.org>
35
36         Reviewed by Eric Seidel.
37
38         [bzt] Kill WebKitLandingScripts
39         https://bugs.webkit.org/show_bug.cgi?id=31904
40
41         Step 6: Kill the rest.
42
43         * Scripts/modules/buildsteps.py:
44         * Scripts/modules/commands/download.py:
45         * Scripts/modules/commands/queries.py:
46         * Scripts/modules/commands/upload.py:
47         * Scripts/modules/landingsequence.py:
48         * Scripts/modules/scm.py:
49         * Scripts/modules/webkitlandingscripts.py: Removed.
50
51 2009-11-27  Adam Barth  <abarth@webkit.org>
52
53         Reviewed by Eric Seidel.
54
55         [bzt] Unit test upload commands
56         https://bugs.webkit.org/show_bug.cgi?id=31903
57
58         Adds unit tests for all but two of the upload commands.  The two
59         remaining ones are more difficult.  I'll return to them later.  The
60         goal of these tests is just to run the commands.  We can test more
61         detailed behavior later.
62
63         * Scripts/modules/commands/commandtest.py:
64         * Scripts/modules/commands/upload.py:
65         * Scripts/modules/commands/upload_unittest.py:
66         * Scripts/modules/mock.py: Added.
67         * Scripts/modules/mock_bugzillatool.py:
68
69 2009-11-26  Adam Barth  <abarth@webkit.org>
70
71         Reviewed by Eric Seidel.
72
73         [bzt] Kill WebKitLandingScripts
74         https://bugs.webkit.org/show_bug.cgi?id=31904
75
76         Step 5: Kill run_and_throw_if_fail.
77
78         * Scripts/modules/buildsteps.py:
79         * Scripts/modules/processutils.py: Added.
80         * Scripts/modules/webkitlandingscripts.py:
81
82 2009-11-26  Adam Barth  <abarth@webkit.org>
83
84         Reviewed by Eric Seidel.
85
86         [bzt] Kill WebKitLandingScripts
87         https://bugs.webkit.org/show_bug.cgi?id=31904
88
89         Step 4: Kill run_webkit_script.
90
91         * Scripts/modules/buildsteps.py:
92         * Scripts/modules/commands/download.py:
93         * Scripts/modules/webkitlandingscripts.py:
94
95 2009-11-26  Adam Barth  <abarth@webkit.org>
96
97         Reviewed by Eric Seidel.
98
99         [bzt] Kill WebKitLandingScripts
100         https://bugs.webkit.org/show_bug.cgi?id=31904
101
102         Step 3: Kill build_webkit.
103
104         * Scripts/modules/buildsteps.py:
105         * Scripts/modules/landingsequence.py:
106         * Scripts/modules/webkitlandingscripts.py:
107
108 2009-11-26  Adam Barth  <abarth@webkit.org>
109
110         Reviewed by Eric Seidel.
111
112         [bzt] Kill WebKitLandingScripts
113         https://bugs.webkit.org/show_bug.cgi?id=31904
114
115         Step 2: Kill ensure_builders_are_green.
116
117         * Scripts/modules/buildsteps.py:
118         * Scripts/modules/commands/download.py:
119         * Scripts/modules/landingsequence.py:
120         * Scripts/modules/webkitlandingscripts.py:
121
122 2009-11-26  Adam Barth  <abarth@webkit.org>
123
124         Reviewed by Eric Seidel.
125
126         [bzt] Kill WebKitLandingScripts
127         https://bugs.webkit.org/show_bug.cgi?id=31904
128
129         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
130
131         * Scripts/bugzilla-tool:
132         * Scripts/modules/buildsteps.py: Added.
133         * Scripts/modules/commands/download.py:
134         * Scripts/modules/landingsequence.py:
135         * Scripts/modules/webkitlandingscripts.py:
136
137 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
138
139         Reviewed by Adam Barth.
140
141         Remove directory prefixes from linux commands
142
143         SCM unittests can cause errors on some systems if we use absolute reference to
144         the commands, so directory prefixes have been removed.
145
146         * Scripts/modules/scm_unittest.py:
147
148 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
149
150         Reviewed by Kenneth Rohde Christiansen.
151
152         Link DumpRenderTree to the Qt Ui Tools
153         https://bugs.webkit.org/show_bug.cgi?id=31203
154
155         Implement QWebPage::createPlugin using the Qt Ui Tools
156         to be able to create classes like QProgressBar from within
157         the <object></object> tags This is required for the
158         new automatic test of Qt Plugins.
159
160         * DumpRenderTree/qt/DumpRenderTree.cpp:
161         (WebCore::WebPage::createPlugin):
162         * DumpRenderTree/qt/DumpRenderTree.h:
163         * DumpRenderTree/qt/DumpRenderTree.pro:
164
165 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
166
167         Reviewed by Eric Seidel.
168
169         Update pywebsocket to 0.4.2
170
171         Update pywebsocket to 0.4.2
172         https://bugs.webkit.org/show_bug.cgi?id=31861
173
174         * pywebsocket/example/echo_client.py:
175         * pywebsocket/example/echo_wsh.py:
176         * pywebsocket/mod_pywebsocket/__init__.py:
177         * pywebsocket/mod_pywebsocket/dispatch.py:
178         * pywebsocket/mod_pywebsocket/msgutil.py:
179         * pywebsocket/mod_pywebsocket/standalone.py:
180         * pywebsocket/setup.py:
181         * pywebsocket/test/test_dispatch.py:
182         * pywebsocket/test/test_msgutil.py:
183
184 2009-11-25  Adam Barth  <abarth@webkit.org>
185
186         Reviewed by Eric Seidel.
187
188         Add unit test for mark-fixed
189         https://bugs.webkit.org/show_bug.cgi?id=31896
190
191         * Scripts/modules/commands/commandtest.py: Added.
192         * Scripts/modules/commands/queries_unittest.py:
193         * Scripts/modules/commands/upload_unittest.py: Added.
194         * Scripts/modules/mock_bugzillatool.py:
195         * Scripts/run-webkit-unittests:
196
197 2009-11-25  Adam Barth  <abarth@webkit.org>
198
199         Reviewed by Eric Seidel.
200
201         bugzilla-tool should have a mark-fixed command
202         https://bugs.webkit.org/show_bug.cgi?id=31853
203
204         Pretty simple stuff.
205
206         * Scripts/modules/commands/upload.py:
207
208 2009-11-25  Eric Seidel  <eric@webkit.org>
209
210         Reviewed by Adam Barth.
211
212         'bugzilla-tool help' should only show common commands like how 'git help' does
213         https://bugs.webkit.org/show_bug.cgi?id=31772
214
215         I also took this opportunity to make 'help' a real Command.
216         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
217
218         * Scripts/bugzilla-tool:
219          - change should_show_command_help to should_show_in_main_help
220         * Scripts/modules/commands/download.py:
221          - Mark commands as being shown in main help or not.
222          - show_in_main_help = False is not required (default is false),
223            but it seemed to make the commands more self-documenting.
224         * Scripts/modules/commands/queries.py: ditto
225         * Scripts/modules/commands/queues.py: ditto
226         * Scripts/modules/commands/upload.py: ditto
227         * Scripts/modules/multicommandtool.py:
228          - Make Command hold a pointer to tool in self.tool.  Most Command
229            subclasses do not take advantage of this yet, but it was required
230            for HelpCommand to be able to reach the tool from _help_epilog().
231          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
232          - Move MultiCommandTool._help_epilog to Command._help_epilog
233          - Move "help" logic into HelpCommand.execute()
234          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
235         * Scripts/modules/multicommandtool_unittest.py:
236          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
237
238 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
239
240         Reviewed by Dan Bernstein.
241         
242         Patch by Mark Rowe.
243
244         The buildbots are failing on Windows because when they were upgraded
245         to 4.0.4, Apple Application Support was not in their path. Add it to
246         the path to fix the buildots.
247
248         * Scripts/webkitdirs.pm:
249
250 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
251
252         Reviewed by David Kilzer.
253
254         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
255         https://bugs.webkit.org/show_bug.cgi?id=31799
256
257         * Scripts/run-webkit-tests: Fixed.
258
259 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
260
261         Reviewed by Eric Seidel.
262
263         Change run_command to give back stderr by default
264         https://bugs.webkit.org/show_bug.cgi?id=31734
265
266         Change run_command to give back stderr by default.
267         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
268         Change the related unittest call.
269
270         * Scripts/modules/scm.py:
271         * Scripts/modules/scm_unittest.py:
272
273 2009-11-25  Eric Seidel  <eric@webkit.org>
274
275         Reviewed by Adam Barth.
276
277         Centralize required argument parsing in Command
278         https://bugs.webkit.org/show_bug.cgi?id=31872
279
280         * Scripts/modules/commands/download.py: remove custom required arg message.
281         * Scripts/modules/commands/upload.py: ditto.
282         * Scripts/modules/multicommandtool.py:
283          - Add _parse_required_arguments.
284          - Pass program name off to OptionParser.
285          - Add name() for access to tool name.
286          - Add check_arguments_and_execute and make it return a return code.
287          - Replace a couple uses of + with %.
288         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
289
290 2009-11-25  Eric Seidel  <eric@webkit.org>
291
292         Reviewed by Adam Barth.
293
294         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
295         https://bugs.webkit.org/show_bug.cgi?id=31870
296
297         * Scripts/modules/commands/queries_unittest.py: Use the new class.
298         * Scripts/modules/multicommandtool_unittest.py: Ditto.
299         * Scripts/modules/outputcapture.py: Added.
300
301 2009-11-24  Dmitry Titov  <dimich@chromium.org>
302
303         Reviewed by Eric Seidel.
304
305         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
306         https://bugs.webkit.org/show_bug.cgi?id=31444
307
308         * Scripts/build-webkit:
309
310 2009-11-24  Chris Marrin  <cmarrin@apple.com>
311
312         Reviewed by Simon Fraser.
313
314         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
315         https://bugs.webkit.org/show_bug.cgi?id=27314
316         
317         Now the script allows the directories with these tests to be included on all
318         platforms but Mac, where they behave the same as always. For all other platforms
319         the tests need to be excluded using the Skipped files, which is currently done
320         for all platforms (including win since we're not turned on yet)
321
322         * Scripts/webkitdirs.pm:
323
324 2009-11-24  Eric Seidel  <eric@webkit.org>
325
326         Reviewed by Adam Barth.
327
328         queries_unittest.py should test command output
329         https://bugs.webkit.org/show_bug.cgi?id=31845
330
331         * Scripts/modules/commands/queries_unittest.py:
332          - Capture stdout and stderr and compare with expected strings.
333
334 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
335
336         No Review.
337
338         Fix spelling error ("depenedencies").
339
340         * Scripts/build-webkit:
341
342 2009-11-24  Mark Rowe  <mrowe@apple.com>
343
344         Land the configuration that includes the two debug GTK Linux builders.
345
346         * BuildSlaveSupport/build.webkit.org-config/config.json:
347
348 2009-11-24  David Kilzer  <ddkilzer@apple.com>
349
350         <http://webkit.org/b/31840> bisect-builds broke after r50080
351
352         Reviewed by Dan Bernstein.
353
354         * Scripts/bisect-builds:
355         (mountAndRunNightly): Switched back to using backticks to run
356         the hdiutil command since exec() will terminate the existing
357         script, which is not what we want.  Store the output of
358         File::Spec->devnull() in a variable for use in the hdiutil
359         detach commands.
360
361 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
362
363         Reviewed by Kenneth Rohde Christiansen.
364
365         Include "config.h" to meet Coding Style Guidelines
366         https://bugs.webkit.org/show_bug.cgi?id=31792
367
368         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
369         * DumpRenderTree/qt/jsobjects.cpp:
370         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
371
372 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
373
374         Reviewed by Oliver Hunt.
375
376         Implement new required function to pass test we used to pass. This
377         change is required since r51294.
378
379         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
380         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
381
382 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
383
384         Reviewed by Kenneth Rohde Christiansen.
385
386         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
387         https://bugs.webkit.org/show_bug.cgi?id=31775
388
389         LayoutTestController::dumpBackForwardList() should work with local URLs
390         as well as with normal URLs (in http tests for instance).
391         Currently it does not output the latter properly.
392
393         Unskip a bunch of passing http/navigation tests.
394
395         * DumpRenderTree/qt/DumpRenderTree.cpp:
396         (WebCore::dumpHistoryItem):
397
398 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
399
400         Reviewed by Oliver Hunt.
401
402         ARIA: support aria-flowto
403         https://bugs.webkit.org/show_bug.cgi?id=31762
404
405         * DumpRenderTree/AccessibilityUIElement.cpp:
406         (ariaFlowToElementAtIndexCallback):
407         (AccessibilityUIElement::getJSClass):
408         * DumpRenderTree/AccessibilityUIElement.h:
409         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
410         (AccessibilityUIElement::ariaFlowToElementAtIndex):
411         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
412         (AccessibilityUIElement::ariaFlowToElementAtIndex):
413         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
414         (AccessibilityUIElement::ariaFlowToElementAtIndex):
415
416 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
417
418         Reviewed by Kenneth Christiansen.
419
420         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
421         https://bugs.webkit.org/show_bug.cgi?id=31638
422
423         Unfreeze WorkQueue after each test execution.
424
425         * DumpRenderTree/qt/DumpRenderTree.cpp:
426         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
427
428 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
429
430         Reviewed by Adam Barth.
431
432         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
433         for localhost and 127.0.0.1.
434         https://bugs.webkit.org/show_bug.cgi?id=31783
435
436         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
437
438         * DumpRenderTree/qt/DumpRenderTree.cpp:
439         (WebCore::NetworkAccessManager::NetworkAccessManager):
440         (WebCore::NetworkAccessManager::sslErrorsEncountered):
441         (WebCore::WebPage::WebPage):
442         * DumpRenderTree/qt/DumpRenderTree.h:
443
444 2009-11-22  Chris Evans  <cevans@chromium.org>
445
446         Reviewed by Adam Barth.
447
448         Disable access to file:/// directory listings
449         https://bugs.webkit.org/show_bug.cgi?id=31329
450
451         Implemented setAllowUniversalAccessFromFileURLs to support testing of
452         file URL security.
453
454         * DumpRenderTree/LayoutTestController.cpp:
455         (setAllowUniversalAccessFromFileURLsCallback):
456         (LayoutTestController::staticFunctions):
457         * DumpRenderTree/LayoutTestController.h:
458         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
459         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
460         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
461         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
462         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
463         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
464         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
465         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
466
467 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
468
469         Reviewed by Kenneth Rohde Christiansen.
470
471         [Qt] Fix the timeout of fast/frames/frame-navigation.html
472         https://bugs.webkit.org/show_bug.cgi?id=31638
473
474         The test is timeouting, because it uses the WorkQueue to load a document in one
475         of the child frames and once the loading is finished, the DRT does not dump the
476         tree. This is because it waits for the QWebFrame::loadFinished() signal from
477         the main frame, while it should connect to QWebPage::loadFinished().
478
479         * DumpRenderTree/qt/DumpRenderTree.cpp:
480         (WebCore::DumpRenderTree::DumpRenderTree):
481
482 2009-11-21  Eric Seidel  <eric@webkit.org>
483
484         Reviewed by Adam Barth.
485
486         bugzilla-tool --help spews way too much text
487         https://bugs.webkit.org/show_bug.cgi?id=31771
488
489         * Scripts/bugzilla-tool:
490          - Remove self.cached_scm initialization hack.
491         * Scripts/modules/buildbot.py:
492          - Make default_host accessible to callers.
493         * Scripts/modules/commands/download.py:
494          - Phrase help for all commands consistently and remove spurious help text punctuation.
495         * Scripts/modules/commands/queries.py: Ditto.
496         * Scripts/modules/commands/queues.py: Ditto.
497         * Scripts/modules/commands/upload.py: Ditto.
498         * Scripts/modules/multicommandtool.py:
499          - Add HelpPrintingOptionParser.format_epilog to replace
500            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
501            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
502          - Make --help only show a list of commands like "svn help" and "git help" do --
503            previously --help was listing all commands and options.
504          - Sort list of commands alphabetically.
505
506 2009-11-21  Eric Seidel  <eric@webkit.org>
507
508         No review.  Fixing a typo from the previous patch for bug 31767.
509
510         AbstractQueue.run_bugzilla_tool throws an exception
511         https://bugs.webkit.org/show_bug.cgi?id=31769
512
513         * Scripts/modules/commands/queues.py:
514
515 2009-11-21  Eric Seidel  <eric@webkit.org>
516
517         Reviewed by Adam Barth.
518
519         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
520         https://bugs.webkit.org/show_bug.cgi?id=31767
521
522         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
523         Since we don't have a good way to test BugzillaTool pieces, I've
524         left out a test for now.
525
526         * Scripts/bugzilla-tool:
527          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
528         * Scripts/modules/commands/queues.py:
529          - Use tool.path() instead of __file__.
530         * Scripts/modules/multicommandtool.py:
531          - Add a new path() method to MultiComandTool.
532         * Scripts/modules/multicommandtool_unittest.py:
533          - Provide a path() method.  Little point in testing this mock implementation.
534
535 2009-11-21  Adam Barth  <abarth@webkit.org>
536
537         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
538         WebKitTools.
539
540         * Scripts/modules/commands/download.py:
541
542 2009-11-21  Adam Barth  <abarth@webkit.org>
543
544         Reviewed by Eric Seidel.
545
546         Convert check-style to use LandingSequence
547         https://bugs.webkit.org/show_bug.cgi?id=31763
548
549         Instead of manipulating the working copy by hand, we should use the
550         LandingSequence in CheckStyle.  This will make this code eaiser to
551         test.
552
553         * Scripts/modules/commands/download.py:
554
555 2009-11-20  Adam Barth  <abarth@webkit.org>
556
557         Reviewed by Eric Seidel.
558
559         Unit test query commands
560         https://bugs.webkit.org/show_bug.cgi?id=31755
561
562         These tests are pretty rough, but hopefully they'll grow.
563
564         * Scripts/modules/commands/queries_unittest.py: Added.
565         * Scripts/modules/mock_bugzillatool.py: Added.
566         * Scripts/run-webkit-unittests:
567
568 2009-11-20  Eric Seidel  <eric@webkit.org>
569
570         Reviewed by Adam Barth.
571
572         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
573         https://bugs.webkit.org/show_bug.cgi?id=31758
574
575         * Scripts/modules/multicommandtool.py:
576          - Allow passing of explicit commands to MultiCommandTool.__init__
577         * Scripts/modules/multicommandtool_unittest.py:
578          - Use new Command.name naming system.
579          - Test Command auto-discovery.
580         * Scripts/modules/workqueue.py:
581          - bug_id no longer exists, use patch['bug_id'] instead.
582         * Scripts/modules/workqueue_unittest.py:
583          - WorkQueues require names now.
584          - should_proceed_with_work_item must return a patch object.
585
586 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
587
588         Reviewed by Beth Dakin.
589
590         WAI-ARIA: add support for aria-owns
591         https://bugs.webkit.org/show_bug.cgi?id=31702
592
593         * DumpRenderTree/AccessibilityUIElement.cpp:
594         (ariaOwnsElementAtIndexCallback):
595         (AccessibilityUIElement::getJSClass):
596         * DumpRenderTree/AccessibilityUIElement.h:
597         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
598         (AccessibilityUIElement::ariaOwnsElementAtIndex):
599         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
600         (AccessibilityUIElement::ariaOwnsElementAtIndex):
601         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
602         (AccessibilityUIElement::ariaOwnsElementAtIndex):
603
604 2009-11-20  Eric Seidel  <eric@webkit.org>
605
606         Reviewed by Adam Barth.
607
608         Fix exception thrown when running the commit-queue.
609
610         * Scripts/modules/statusbot.py: patch is optional.
611         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
612
613 2009-11-20  Eric Seidel  <eric@webkit.org>
614
615         Reviewed by Adam Barth.
616
617         Teach the StatusBot how to support more than just the commit-queue
618         https://bugs.webkit.org/show_bug.cgi?id=31754
619
620         * Scripts/modules/workqueue.py: Another typo.
621
622 2009-11-20  Eric Seidel  <eric@webkit.org>
623
624         Reviewed by Adam Barth.
625
626         Teach the StatusBot how to support more than just the commit-queue
627         https://bugs.webkit.org/show_bug.cgi?id=31754
628
629         * Scripts/modules/commands/queues.py: Fix silly typo.
630
631 2009-11-20  Eric Seidel  <eric@webkit.org>
632
633         Reviewed by Adam Barth.
634
635         Teach the StatusBot how to support more than just the commit-queue
636         https://bugs.webkit.org/show_bug.cgi?id=31754
637
638         * CommitQueueStatus/index.yaml:
639          - Add indices required for the new queries.
640         * CommitQueueStatus/queue_status.py:
641          - Add a patch-status page and move update_status to update-status.
642          - Only display "commit-queue" status records for the commit-queue.
643          - Add support for a queue_name property on status records.
644          - Fix _int_from_request to actually work.
645         * CommitQueueStatus/update_status.html:
646          - Add support for a queue_name on status records.
647          - Remove unused list of bug ids.
648          * Scripts/modules/commands/queues.py
649           - Make the queues pass the patch instead of the bug_id to StatusBot.
650         * Scripts/modules/statusbot.py:
651          - Support passing the queue_name to the status updates.
652          - Support fetching patch status with patch_status().
653         * Scripts/modules/workqueue.py:
654          - Pass the patch to the StatusBot instead of the bug_id.
655          - Let WorkQueues have a name.
656
657 2009-11-20  Adam Barth  <abarth@webkit.org>
658
659         Reviewed by Eric Seidel.
660
661         Move bugzilla-tool commands into their own file
662         https://bugs.webkit.org/show_bug.cgi?id=31752
663
664         This will let us write unit tests.
665
666         * Scripts/bugzilla-tool:
667         * Scripts/modules/commands/__init__.py: Added.
668         * Scripts/modules/commands/download.py: Added.
669         * Scripts/modules/commands/queries.py: Added.
670         * Scripts/modules/commands/queues.py: Added.
671         * Scripts/modules/commands/upload.py: Added.
672         * Scripts/modules/grammar.py: Added.
673
674 2009-11-20  Adam Barth  <abarth@webkit.org>
675
676         Reviewed by Eric Seidel.
677
678         BuildQueue should check if the tree is currently buildable
679         https://bugs.webkit.org/show_bug.cgi?id=31744
680
681         * Scripts/bugzilla-tool:
682         * Scripts/modules/landingsequence.py:
683         * Scripts/modules/webkitlandingscripts.py:
684
685 2009-11-20  Adam Barth  <abarth@webkit.org>
686
687         Reviewed by Eric Seidel.
688
689         Move prepare_clean_working_directory into the LandingSequence
690         https://bugs.webkit.org/show_bug.cgi?id=31743
691
692         * Scripts/bugzilla-tool:
693         * Scripts/modules/landingsequence.py:
694
695 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
696
697         Reviewed by Kenneth Rohde Christiansen.
698
699         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
700         https://bugs.webkit.org/show_bug.cgi?id=30460
701
702         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
703
704         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
705         (pluginInvoke):
706
707 2009-11-20  Adam Barth  <abarth@webkit.org>
708
709         Reviewed by Eric Seidel.
710
711         Pass the port information to the child process
712         https://bugs.webkit.org/show_bug.cgi?id=31736
713
714         We need to do this so the child process knows what to build!
715
716         * Scripts/bugzilla-tool:
717         * Scripts/modules/landingsequence.py:
718         * Scripts/modules/webkitport.py:
719         * Scripts/modules/webkitport_unittest.py:
720
721 2009-11-20  Adam Barth  <abarth@webkit.org>
722
723         Reviewed by Eric Seidel.
724
725         Support Qt port in build-queue
726         https://bugs.webkit.org/show_bug.cgi?id=31733
727
728         * Scripts/bugzilla-tool:
729
730 2009-11-20  Adam Barth  <abarth@webkit.org>
731
732         Reviewed by Eric Seidel.
733
734         Implement a build-queue
735         https://bugs.webkit.org/show_bug.cgi?id=31725
736
737         Currently this just builds the first 10 patches in the review queue.
738         We'll want to do something smarter soon.
739
740         * Scripts/bugzilla-tool:
741
742 2009-11-20  Adam Barth  <abarth@webkit.org>
743
744         Reviewed by Eric Seidel.
745
746         Make commit-queue and style-queue show up in help
747         https://bugs.webkit.org/show_bug.cgi?id=31724
748
749         We need to store their names on their class to make these commands
750         properly register themselves with MultiCommandTool.
751
752         * Scripts/bugzilla-tool:
753
754 2009-11-20  Adam Barth  <abarth@webkit.org>
755
756         Reviewed by Eric Seidel.
757
758         Implement bugzilla-tool build-attachment
759         https://bugs.webkit.org/show_bug.cgi?id=31722
760
761         This command builds an attachment from bugzilla.  It leaves the built
762         patch in the working copy.
763
764         * Scripts/bugzilla-tool:
765         * Scripts/modules/landingsequence.py:
766         * Scripts/modules/webkitlandingscripts.py:
767
768 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
769
770         Reviewed by Xan Lopez.
771
772         [GTK] DRT release event does not create the state correctly
773         https://bugs.webkit.org/show_bug.cgi?id=31717
774
775         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
776
777 2009-11-20  Eric Seidel  <eric@webkit.org>
778
779         Reviewed by Adam Barth.
780
781         MultiCommandTool should find Command objects automatically instead of with a manual list
782         https://bugs.webkit.org/show_bug.cgi?id=31710
783
784         * Scripts/bugzilla-tool:
785         * Scripts/modules/multicommandtool.py:
786          - Use some wild python-fu to crawl all the known subclasses of Command.
787
788 2009-11-20  Adam Barth  <abarth@webkit.org>
789
790         Unreviewed "build" fix.  Added missing import.
791
792         * Scripts/bugzilla-tool:
793
794 2009-11-20  Adam Barth  <abarth@webkit.org>
795
796         Unreviewed "build" fix.  I failed to update LandingSequence.test
797         properly.
798
799         * Scripts/modules/landingsequence.py:
800
801 2009-11-20  Adam Barth  <abarth@webkit.org>
802
803         Reviewed by Eric Seidel.
804
805         Create LandingSequence as the all-sing, all-dance landing class
806         https://bugs.webkit.org/show_bug.cgi?id=31709
807
808         Client can inherit from this class to carefully control exactly which
809         steps they wish to have happen in the landing sequence.
810
811         * Scripts/bugzilla-tool:
812         * Scripts/modules/landingsequence.py: Added.
813         * Scripts/modules/webkitlandingscripts.py: Added.
814
815 2009-11-19  Adam Barth  <abarth@webkit.org>
816
817         Reviewed by Eric Seidel.
818
819         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
820         https://bugs.webkit.org/show_bug.cgi?id=31707
821
822         This is to help when we implement build-attachment.
823
824         * Scripts/bugzilla-tool:
825
826 2009-11-19  Adam Barth  <abarth@webkit.org>
827
828         Reviewed by Eric Seidel.
829
830         Support Qt port in bugzilla-tool
831         https://bugs.webkit.org/show_bug.cgi?id=31701
832
833         Now we support building with Qt!
834
835         * Scripts/bugzilla-tool:
836         * Scripts/modules/webkitport.py: Added.
837         * Scripts/modules/webkitport_unittest.py: Added.
838         * Scripts/run-webkit-unittests:
839
840 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
841
842         Reviewed by Adam Barth.
843
844         Remove inserting stderr into patch in bugzilla-tool
845         https://bugs.webkit.org/show_bug.cgi?id=29914
846
847         Modify SCM python module's run_command function to avoid return of stderr
848         by default, so stderr won't be inserted into the patches.
849         Modify the related unit test.
850
851         * Scripts/modules/scm.py:
852         * Scripts/modules/scm_unittest.py:
853
854 2009-11-19  Eric Seidel  <eric@webkit.org>
855
856         Reviewed by Adam Barth.
857
858         bugzilla-tool needs per-command help
859         https://bugs.webkit.org/show_bug.cgi?id=31697
860
861         Added support for "bugzilla-tool help command-name"
862         and a unit test to make sure it works.
863
864         * Scripts/modules/multicommandtool.py:
865         * Scripts/modules/multicommandtool_unittest.py:
866
867 2009-11-19  Eric Seidel  <eric@webkit.org>
868
869         Reviewed by Adam Barth.
870
871         Move MultiCommandTool and Command into a separate file and add some basic unit tests
872         https://bugs.webkit.org/show_bug.cgi?id=31695
873
874         * Scripts/bugzilla-tool:
875         * Scripts/modules/multicommandtool.py: Added.
876         * Scripts/modules/multicommandtool_unittest.py: Added.
877         * Scripts/run-webkit-unittests:
878
879 2009-11-19  Eric Seidel  <eric@webkit.org>
880
881         No review, just adding a FIXME.
882
883         Split out command parsing and help printing from BugzillaTool
884         https://bugs.webkit.org/show_bug.cgi?id=31688
885
886         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
887
888 2009-11-19  Eric Seidel  <eric@webkit.org>
889
890         Reviewed by Adam Barth.
891
892         Split out command parsing and help printing from BugzillaTool
893         https://bugs.webkit.org/show_bug.cgi?id=31688
894
895         * Scripts/bugzilla-tool:
896          - Add new MultiCommandTool class to contain option parsing and help printing logic.
897          - Rename private methods to use _ pattern.
898          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
899          - 
900
901 2009-11-19  Eric Seidel  <eric@webkit.org>
902
903         Reviewed by Adam Barth.
904
905         Re-factor help printing to use modern python idioms
906         https://bugs.webkit.org/show_bug.cgi?id=31685
907
908         * Scripts/bugzilla-tool:
909
910 2009-11-19  Eric Seidel  <eric@webkit.org>
911
912         Reviewed by Darin Adler.
913
914         commit-queue empty queue logs twice
915         https://bugs.webkit.org/show_bug.cgi?id=31679
916
917         * Scripts/bugzilla-tool:
918
919 2009-11-19  Eric Seidel  <eric@webkit.org>
920
921         Reviewed by Darin Adler.
922
923         bugzilla-tool's reviewer/committer rejection message should be clearer
924         https://bugs.webkit.org/show_bug.cgi?id=31126
925
926         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
927
928         * Scripts/modules/bugzilla.py:
929
930 2009-11-19  Eric Z. Ayers  <zundel@google.com>
931
932         Reviewed by Pavel Feldman.
933
934         Forces a WM_PAINT event on calling layoutTestController.display()
935         in order to enable the timeline-paint.html test on Windows.
936         ::UpdateWindow() does not force an event becaue the window is 
937         not visible.
938
939         https://bugs.webkit.org/show_bug.cgi?id=31402
940
941         * DumpRenderTree/win/DumpRenderTree.cpp:
942         (displayWebView):
943
944 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
945
946         No review needed.
947
948         Added myself to committers list.
949
950         * Scripts/modules/committers.py:
951
952 2009-11-19  Adam Barth  <abarth@webkit.org>
953
954         Reviewed by Eric Seidel.
955
956         Bugzilla-tool command classes should match command names
957         https://bugs.webkit.org/show_bug.cgi?id=31666
958
959         I renamed all the commands except CommitMessageForCurrentDiff because
960         the new name would conflict with an existing class.
961
962         * Scripts/bugzilla-tool:
963
964 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
965
966         Reviewed by Gustavo Noronha Silva.
967
968         Web Inspector: Implement "show inspector" in WebKit GTK
969         API and enable console tests.
970
971         https://bugs.webkit.org/show_bug.cgi?id=31669
972
973         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
974         (LayoutTestController::showWebInspector):
975
976 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
977
978         Reviewed by Simon Hausmann.
979
980         Minor refactoring + more documentation.
981
982         * DumpRenderTree/qt/DumpRenderTree.cpp:
983         (WebCore::clearHistory):
984         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
985
986 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
987
988         Reviewed by Eric Seidel.
989
990         Ignore websocket tests when --no-http is specified.
991         https://bugs.webkit.org/show_bug.cgi?id=31662
992
993         * Scripts/run-webkit-tests:
994
995 2009-11-18  Adam Barth  <abarth@webkit.org>
996
997         Reviewed by Eric Seidel.
998
999         Normalize ' and " in bugzilla-tool
1000         https://bugs.webkit.org/show_bug.cgi?id=31655
1001
1002         We decided " is better than ' and we should be consistent.
1003
1004         * Scripts/bugzilla-tool:
1005
1006 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1007
1008         Reviewed by Kenneth Rohde Christiansen.
1009
1010         [Qt] Remove support for Qt v4.3 or older versions
1011         https://bugs.webkit.org/show_bug.cgi?id=29469
1012
1013         * DumpRenderTree/qt/DumpRenderTree.pro:
1014         * DumpRenderTree/qt/ImageDiff.pro:
1015
1016 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1017
1018         Reviewed by Eric Seidel.
1019
1020         GitTest.test_create_binary_patch fails if /tmp is symlink
1021         https://bugs.webkit.org/show_bug.cgi?id=31536
1022
1023         * Scripts/modules/scm_unittest.py:
1024
1025 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1026
1027         Reviewed by Darin Adler.
1028
1029         Configuration for Chromium Build Slaves.
1030
1031         https://bugs.webkit.org/show_bug.cgi?id=31442
1032
1033         * BuildSlaveSupport/build.webkit.org-config/config.json:
1034         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1035
1036 2009-11-18  Eric Seidel  <eric@webkit.org>
1037
1038         Reviewed by Darin Adler.
1039
1040         workqueue.py results in totally broken commit-queue UI
1041         https://bugs.webkit.org/show_bug.cgi?id=31645
1042
1043         * Scripts/bugzilla-tool:
1044          - Remove unneeded use of PatchCollection.
1045          - Grab a new copy of the cq'd patches every run of the queue.
1046
1047 2009-11-18  Sam Weinig  <sam@webkit.org>
1048
1049         Reviewed by Anders Carlsson.
1050
1051         Make the Mac Geolocation API async.
1052
1053         Update DRT to use the new async Mac Geolocation API.
1054
1055         * DumpRenderTree/mac/UIDelegate.mm:
1056         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1057
1058 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1059
1060         Reviewed by Kenneth Rohde Christiansen.
1061
1062         Add and option to toggle HTML5 datalist support to build-webkit
1063         https://bugs.webkit.org/show_bug.cgi?id=31599
1064
1065         * Scripts/build-webkit:
1066
1067 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1068
1069         Reviewed by Kevin Ollivier.
1070
1071         Enable wx plugin support using the Windows implementation as a base.
1072         
1073         https://bugs.webkit.org/show_bug.cgi?id=31636
1074
1075         * wx/build/settings.py:
1076
1077 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1078
1079         Reviewed by Simon Hausmann.
1080
1081         Change the initialization order so that the controllers
1082         will be created before exporting them to the JS DOM window.
1083
1084         * DumpRenderTree/qt/DumpRenderTree.cpp:
1085         (WebCore::DumpRenderTree::DumpRenderTree):
1086
1087 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1088
1089         Reviewed by Simon Hausmann.
1090
1091         Fix a code copy and paste error. m_page should be page.
1092
1093         * DumpRenderTree/qt/DumpRenderTree.cpp:
1094         (WebCore::DumpRenderTree::createWindow):
1095
1096 2009-11-17  Mark Rowe  <mrowe@apple.com>
1097
1098         Reviewed by Alexey Proskuryakov.
1099
1100         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1101
1102         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1103         This prevents symlinks from confusing the descendant check.
1104
1105 2009-11-17  Mark Rowe  <mrowe@apple.com>
1106
1107         Reviewed by Alexey Proskuryakov.
1108
1109         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1110
1111         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1112         server to be up rather than having run-webkit-tests abort immediately.
1113
1114         * Scripts/run-webkit-tests:
1115
1116 2009-11-17  Eric Seidel  <eric@webkit.org>
1117
1118         Reviewed by Darin Adler.
1119
1120         commit-queue is failing to set reviewer in ChangeLogs
1121         https://bugs.webkit.org/show_bug.cgi?id=31592
1122
1123         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1124         * Scripts/modules/bugzilla.py:
1125          - Add a new _validate_committer_and_reviewer function as a
1126            temporary solution until we can make a real Attachment object
1127            which knows how to fill in its committer/reviewer fields automatically.
1128
1129 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1130
1131         Unreviewed buildbot fix.
1132
1133         Revert part of earlier patch and add comment, as it
1134         was causing timeouts on the buildbot.
1135
1136         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1137         (LayoutTestController::notifyDone):
1138
1139 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1140
1141         Reviewed by Oliver Hunt.
1142
1143         Make the timeout 15 sec as for the other DRT's and make
1144         it print out the same output when a test timeout.
1145
1146         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1147         (LayoutTestController::waitUntilDone):
1148         (LayoutTestController::notifyDone):
1149         (LayoutTestController::timerEvent):
1150
1151 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1152
1153         Reviewed by Timothy Hatcher.
1154
1155         Fixed typos in comments.
1156
1157         * Scripts/modules/committers.py:
1158
1159 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1160
1161         Reviewed by Timothy Hatcher.
1162
1163         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1164         - Updated DRT to show/close inspector for all tests under /inspector
1165         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1166           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1167         - Removed reload on each inspector test
1168         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1169         inspector for those.
1170         - Reimplemented timeline tests in order to get rid of reload there.
1171         - Moved tests that don't require harness into the fast group.
1172
1173         https://bugs.webkit.org/show_bug.cgi?id=31472
1174
1175         * DumpRenderTree/LayoutTestController.cpp:
1176         (setTimelineProfilingEnabledCallback):
1177         (closeWebInspectorCallback):
1178         (LayoutTestController::staticFunctions):
1179         * DumpRenderTree/LayoutTestController.h:
1180         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1181         (shouldOpenWebInspector):
1182         (runTest):
1183         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1184         (LayoutTestController::setTimelineProfilingEnabled):
1185         * DumpRenderTree/mac/DumpRenderTree.mm:
1186         (shouldOpenWebInspector):
1187         (runTest):
1188         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1189         (LayoutTestController::setTimelineProfilingEnabled):
1190         * DumpRenderTree/win/DumpRenderTree.cpp:
1191         (shouldOpenWebInspector):
1192         (runTest):
1193         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1194         (LayoutTestController::setTimelineProfilingEnabled):
1195
1196 2009-11-17  Oliver Hunt  <oliver@apple.com>
1197
1198         Reviewed by Maciej Stachowiak.
1199
1200         Incorrect use of JavaScriptCore API in DumpRenderTree
1201         https://bugs.webkit.org/show_bug.cgi?id=31577
1202
1203         Return undefined rather than a literal null.
1204
1205         * DumpRenderTree/AccessibilityUIElement.cpp:
1206         (setSelectedTextRangeCallback):
1207         (incrementCallback):
1208         (decrementCallback):
1209         (showMenuCallback):
1210
1211 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1212
1213         Reviewed by Beth Dakin.
1214
1215         AX: aria-labelledby duplicates some of its WAI-ARIA label
1216         https://bugs.webkit.org/show_bug.cgi?id=31565
1217
1218         * DumpRenderTree/AccessibilityUIElement.cpp:
1219         (titleUIElementCallback):
1220         (getIsValidCallback):
1221         (AccessibilityUIElement::getJSClass):
1222
1223 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1224
1225         Reviewed by Simon Hausmann.
1226
1227         r50942 broke output from created windows. Make the
1228         m_enableTextOutput a member of the DRT and not the
1229         WebPage.
1230
1231         * DumpRenderTree/qt/DumpRenderTree.cpp:
1232         (WebCore::WebPage::WebPage):
1233         (WebCore::WebPage::javaScriptAlert):
1234         (WebCore::WebPage::javaScriptConsoleMessage):
1235         (WebCore::WebPage::javaScriptConfirm):
1236         (WebCore::WebPage::javaScriptPrompt):
1237         (WebCore::WebPage::acceptNavigationRequest):
1238         (WebCore::DumpRenderTree::DumpRenderTree):
1239         (WebCore::DumpRenderTree::open):
1240         (WebCore::DumpRenderTree::createWindow):
1241         * DumpRenderTree/qt/DumpRenderTree.h:
1242         (WebCore::DumpRenderTree::setTextOutputEnabled):
1243         (WebCore::DumpRenderTree::isTextOutputEnabled):
1244         (WebCore::WebPage::shouldInterruptJavaScript):
1245         (WebCore::WebPage::isTextOutputEnabled):
1246         (WebCore::WebPage::setViewGeometry):
1247
1248 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1249
1250         Reviewed by Gustavo Noronha Silva.
1251
1252         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1253         as the implementation is being used by at least Qt and Gtk+.
1254
1255         Update buildsystems as well.
1256
1257         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1258         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1259         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1260         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1261         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1262         * GNUmakefile.am:
1263
1264 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1265
1266         Reviewed by Alexey Proskuryakov.
1267
1268         Disable wss until all platforms support pyOpenSSL
1269
1270         https://bugs.webkit.org/show_bug.cgi?id=31479
1271
1272         * Scripts/run-webkit-tests:
1273
1274 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1275
1276         Reviewed by Kenneth Christiansen.
1277
1278         [Qt] Implement load error pages support for Qt's DRT.
1279         https://bugs.webkit.org/show_bug.cgi?id=31509
1280
1281         For now, it will not be a default feature, and layout tests
1282         that want to make use of this have to explicitily call
1283         'handleErrorPages();' for the test source.
1284
1285         Any of the other DumpRenderTree's (mac, win and gtk)
1286         support handling error pages. Qt's will be the first.
1287
1288         * DumpRenderTree/qt/DumpRenderTree.cpp:
1289         (WebCore::WebPage::supportsExtension):
1290         (WebCore::WebPage::extension):
1291         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1292         (LayoutTestController::reset):
1293         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1294         (LayoutTestController::shouldHandleErrorPages):
1295         (LayoutTestController::handleErrorPages):
1296
1297 2009-11-16  Eric Seidel  <eric@webkit.org>
1298
1299         Reviewed by Adam Barth.
1300
1301         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1302         https://bugs.webkit.org/show_bug.cgi?id=31549
1303
1304         Renamed --commit-queue to --non-interactive in most places
1305         and remove the code in land-patches which is no longer needed.
1306
1307         * Scripts/bugzilla-tool:
1308
1309 2009-11-16  Eric Seidel  <eric@webkit.org>
1310
1311         Reviewed by Adam Barth.
1312
1313         The commit-queue should use land-attachment
1314         https://bugs.webkit.org/show_bug.cgi?id=31548
1315
1316         * Scripts/bugzilla-tool:
1317
1318 2009-11-16  Adam Barth  <abarth@webkit.org>
1319
1320         Reviewed by Eric Seidel.
1321
1322         Convert CommitQueue over to PatchCollection
1323         https://bugs.webkit.org/show_bug.cgi?id=31547
1324
1325         Also fixes a bug in workqueue and adds a test!
1326
1327         * Scripts/bugzilla-tool:
1328         * Scripts/modules/workqueue.py:
1329         * Scripts/modules/workqueue_unittest.py:
1330
1331 2009-11-16  Adam Barth  <abarth@webkit.org>
1332
1333         Reviewed by Eric Seidel.
1334
1335         Move StyleQueue over to using PatchCollection
1336         https://bugs.webkit.org/show_bug.cgi?id=31544
1337
1338         That's what the class it's for.
1339
1340         * Scripts/bugzilla-tool:
1341         * Scripts/modules/patchcollection.py:
1342         * Scripts/modules/patchcollection_unittest.py:
1343
1344 2009-11-16  Eric Seidel  <eric@webkit.org>
1345
1346         Reviewed by Adam Barth.
1347
1348         bugzilla-tool needs a land-attachment command
1349         https://bugs.webkit.org/show_bug.cgi?id=31546
1350
1351         * Scripts/bugzilla-tool:
1352          - Move all the logic into AbstractLandingCommand and
1353            add a new LandAttachment command subclass.
1354          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1355
1356 2009-11-16  Eric Seidel  <eric@webkit.org>
1357
1358         Reviewed by Adam Barth.
1359
1360         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1361         https://bugs.webkit.org/show_bug.cgi?id=31543
1362
1363         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1364
1365         * Scripts/bugzilla-tool:
1366
1367 2009-11-16  Eric Seidel  <eric@webkit.org>
1368
1369         Reviewed by Adam Barth.
1370
1371         Disable the style queue from posting to the commit queue status page.
1372
1373         * Scripts/bugzilla-tool:
1374
1375 2009-11-16  Adam Barth  <abarth@webkit.org>
1376
1377         Reviewed by Eric Seidel.
1378
1379         Implement PatchCollection
1380         https://bugs.webkit.org/show_bug.cgi?id=31541
1381
1382         This class holds a set of patches and lets clients iterate through
1383         them.  Optionally, clients can install a filter.
1384
1385         * Scripts/modules/patchcollection.py: Added.
1386         * Scripts/modules/patchcollection_unittest.py: Added.
1387         * Scripts/run-webkit-unittests:
1388
1389 2009-11-16  Eric Seidel  <eric@webkit.org>
1390
1391         Reviewed by Adam Barth.
1392
1393         bugzilla-tool land-patches will close bugs with patches r=?
1394         https://bugs.webkit.org/show_bug.cgi?id=28230
1395
1396         The commit-queue shouldn't close patches with outstanding reviews on them,
1397         even if many reviewers seem to be against multi-patch bugs.
1398
1399         * Scripts/bugzilla-tool:
1400
1401 2009-11-16  Eric Seidel  <eric@webkit.org>
1402
1403         Reviewed by Adam Barth.
1404
1405         bugzilla-tool check-style should work with attachment ids instead of bug ids
1406         https://bugs.webkit.org/show_bug.cgi?id=31540
1407
1408         * Scripts/bugzilla-tool:
1409
1410 2009-11-16  Eric Seidel  <eric@webkit.org>
1411
1412         Reviewed by Adam Barth.
1413
1414         WorkQueue is the only place that should know about special exit codes
1415         https://bugs.webkit.org/show_bug.cgi?id=31534
1416
1417         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1418         and add tests for handling exit codes.
1419         I also cleaned up workqueue_unittest.py more.
1420
1421         * Scripts/bugzilla-tool:
1422         * Scripts/modules/workqueue.py:
1423         * Scripts/modules/workqueue_unittest.py:
1424
1425 2009-11-16  Eric Seidel  <eric@webkit.org>
1426
1427         Reviewed by Adam Barth.
1428
1429         Re-factor workqueue_unittest to allow for more than one test.
1430         https://bugs.webkit.org/show_bug.cgi?id=31535
1431
1432         * Scripts/modules/workqueue_unittest.py:
1433
1434 2009-11-16  Eric Seidel  <eric@webkit.org>
1435
1436         Reviewed by Adam Barth.
1437
1438         land-patches needs to be re-factored into smaller chunks
1439         https://bugs.webkit.org/show_bug.cgi?id=31532
1440
1441         * Scripts/bugzilla-tool: fix a couple obvious typos.
1442
1443 2009-11-16  Eric Seidel  <eric@webkit.org>
1444
1445         Reviewed by Adam Barth.
1446
1447         land-patches needs to be re-factored into smaller chunks
1448         https://bugs.webkit.org/show_bug.cgi?id=31532
1449
1450         The next patch will move these methods into WebKitLandingScripts.
1451
1452         * Scripts/bugzilla-tool:
1453          - Split out _land_patch and _close_bug_if_no_active_patches.
1454
1455 2009-11-16  Adam Barth  <abarth@webkit.org>
1456
1457         Reviewed by Eric Seidel.
1458
1459         Fix silly copy-and-paste code.  I am a terrible coder.
1460
1461         * Scripts/modules/bugzilla.py:
1462
1463 2009-11-16  Adam Barth  <abarth@webkit.org>
1464
1465         Reviewed by Eric Seidel.
1466
1467         Implement a StyleQueue
1468         https://bugs.webkit.org/show_bug.cgi?id=31537
1469
1470         The first iteration of the style queue only produces output locally.
1471         There is also a limit of 10 patches because it's not that useful to
1472         iterate through the entire review queue at this point.  We can remove
1473         the limit later.
1474
1475         * Scripts/bugzilla-tool:
1476         * Scripts/modules/bugzilla.py:
1477
1478 2009-11-16  Adam Barth  <abarth@webkit.org>
1479
1480         Reviewed by Eric Seidel.
1481
1482         Unit test WorkQueue
1483         https://bugs.webkit.org/show_bug.cgi?id=31531
1484
1485         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1486
1487         * Scripts/bugzilla-tool:
1488         * Scripts/modules/statusbot.py:
1489         * Scripts/modules/workqueue.py:
1490         * Scripts/modules/workqueue_unittest.py: Added.
1491         * Scripts/run-webkit-unittests:
1492
1493 2009-11-16  Eric Seidel  <eric@webkit.org>
1494
1495         Reviewed by Adam Barth.
1496
1497         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1498         https://bugs.webkit.org/show_bug.cgi?id=31530
1499
1500         * Scripts/bugzilla-tool:
1501
1502 2009-11-16  Eric Seidel  <eric@webkit.org>
1503
1504         Reviewed by Adam Barth.
1505
1506         bugzilla-tool needs apply-attachment
1507         https://bugs.webkit.org/show_bug.cgi?id=31528
1508
1509         * Scripts/bugzilla-tool:
1510          - Add ApplyAttachment command.
1511          - Abstract applying code into WebKitApplyingScripts.
1512          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1513         * Scripts/modules/bugzilla.py:
1514          - Add fetch_attachment and bug_id_for_attachment_id.
1515         * Scripts/modules/bugzilla_unittest.py:
1516          - Add test for new parsing.
1517          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1518
1519 2009-11-16  Eric Seidel  <eric@webkit.org>
1520
1521         Reviewed by Adam Barth.
1522
1523         Document check-style's use of force_clean.
1524
1525         * Scripts/bugzilla-tool:
1526         * Scripts/modules/scm.py:
1527
1528 2009-11-16  Adam Barth  <abarth@webkit.org>
1529
1530         Reviewed by Eric Seidel.
1531
1532         Move WorkQueue to its own file
1533         https://bugs.webkit.org/show_bug.cgi?id=31529
1534
1535         WorkQueue and WorkQueueDelegate are separate concerns from
1536         bugzilla-tool.  Also added a missing include to logging.py.
1537
1538         * Scripts/bugzilla-tool:
1539         * Scripts/modules/logging.py:
1540         * Scripts/modules/workqueue.py:
1541
1542 2009-11-16  Adam Barth  <abarth@webkit.org>
1543
1544         Reviewed by Eric Seidel.
1545
1546         Move OutputTee to logging.py.
1547
1548         * Scripts/bugzilla-tool:
1549         * Scripts/modules/logging.py:
1550
1551 2009-11-15  Adam Barth  <abarth@webkit.org>
1552
1553         Reviewed by Eric Seidel.
1554
1555         Refactor bugzilla-tool to allow for multiple queues
1556         https://bugs.webkit.org/show_bug.cgi?id=31513
1557
1558         Divide the commit queue class into three class to make creating
1559         additional queues easier.
1560
1561         * Scripts/bugzilla-tool:
1562
1563 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1564
1565         Reviewed by Eric Seidel.
1566
1567         svn-apply may not handle git patches created by bugzilla-tool
1568         https://bugs.webkit.org/show_bug.cgi?id=31457
1569
1570         * Scripts/modules/scm.py:
1571         * Scripts/modules/scm_unittest.py:
1572
1573 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1574
1575         Reviewed by Eric Seidel.
1576
1577         bugzilla-tool should post git binary diff
1578         https://bugs.webkit.org/show_bug.cgi?id=31458
1579
1580         Add --binary option to Git.create_patch.
1581
1582         * Scripts/modules/scm.py:
1583         * Scripts/modules/scm_unittest.py:
1584
1585 2009-11-15  Adam Barth  <abarth@webkit.org>
1586
1587         Reviewed by Darin Adler.
1588
1589         Add bugzilla-tool check-style
1590         https://bugs.webkit.org/show_bug.cgi?id=31515
1591
1592         * Scripts/bugzilla-tool:
1593         * Scripts/modules/bugzilla.py:
1594
1595 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1596
1597         Reviewed by Simon Hausmann.
1598
1599         Make the Qt Linux only --valgrind feature, suppress errors
1600         defined in the SuppressedValgrindErrors file.
1601
1602         * Scripts/run-webkit-tests:
1603
1604 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1605
1606         Reviewed by Simon Hausmann.
1607
1608         Set the locale to C and not to the current one in use on the system.
1609
1610         * DumpRenderTree/qt/DumpRenderTree.cpp:
1611         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1612
1613 2009-11-13  Adam Roben  <aroben@apple.com>
1614
1615         Add support for
1616         http/tests/security/isolatedWorld/didClearWindowObject.html
1617
1618         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1619         window objects in isolated worlds are cleared
1620
1621         Reviewed by Dave Hyatt.
1622
1623         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1624
1625         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1626         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1627         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1628         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1629         Added. Sets a __worldID property on the global object whose value is
1630         the ID of this world.
1631         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1632         Respond to this new delegate callback by calling through to one of the
1633         above new methods.
1634         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1635         (worldMap): Added. Returns a HashMap containing all the worlds we've
1636         created.
1637         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1638         haven't kept track of this world.
1639         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1640         instead of declaring our own.
1641
1642         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1643
1644         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1645         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1646         didClearWindowObjectForFrameInStandardWorld.
1647         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1648         Respond to this new delegate callback by calling through to one of the
1649         below new methods.
1650         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1651         Added. Sets a __worldID property on the gobal object whose value is
1652         the ID of this world.
1653         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1654         Added. Moved code here from didClearWindowObject.
1655
1656         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1657         didClearWindowObjectForFrame* functions.
1658
1659         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1660         (worldMap): Added. Returns a HashMap containing all the worlds we've
1661         created.
1662         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1663         haven't kept track of this world.
1664         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1665         instead of declaring our own.
1666
1667 2009-11-13  Adam Roben  <aroben@apple.com>
1668
1669         Finish replacing worldIDs with world objects
1670
1671         The only remaining use of worldIDs was in a method only used by DRT
1672         for the isolated worlds tests.
1673
1674         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1675
1676         Reviewed by Mark Rowe.
1677
1678         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1679         (LayoutTestController::evaluateScriptInIsolatedWorld):
1680         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1681         (LayoutTestController::evaluateScriptInIsolatedWorld):
1682         Updated for changes to WebFrame. Now holds the map of worldID -> world
1683         at this level instead of making WebKit do it.
1684
1685 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1686
1687         Reviewed by Simon Hausmann.
1688
1689         [Qt] Ensure the DRT does not output anything until first test is run
1690
1691         * DumpRenderTree/qt/DumpRenderTree.cpp:
1692         * DumpRenderTree/qt/DumpRenderTree.h:
1693
1694 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1695
1696         Reviewed by Tor Arne Vestbø.
1697
1698         Clear the undo stack in before each new test run.
1699
1700         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1701
1702         * DumpRenderTree/qt/DumpRenderTree.cpp:
1703         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1704
1705 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1706
1707         Reviewed by Kenneth Rohde Christiansen.
1708
1709         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1710
1711         * DumpRenderTree/qt/DumpRenderTree.cpp:
1712         (WebCore::WebPage::resetSettings):
1713         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1714         (LayoutTestController::overridePreference):
1715
1716 2009-11-13  Eric Seidel  <eric@webkit.org>
1717
1718         Reviewed by Adam Barth.
1719
1720         Update committers.py based on svn records
1721         https://bugs.webkit.org/show_bug.cgi?id=31366
1722
1723         This list was generated using validate-committer-lists from
1724         https://bugs.webkit.org/show_bug.cgi?id=30970
1725         and makes committers.py current for committers who have
1726         committed in the last 3 years.
1727
1728         * Scripts/modules/committers.py:
1729
1730 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1731
1732         Reviewed by Adam Barth.
1733
1734         The document-open.html test was flaky at times. The test invokes the layout test plugin
1735         which in its destroy stream handler opens a new document. This basically tears down the
1736         stream and the associated plugin instance. The pluginLog function in the layout test
1737         plugin attempts to retrieve the window script object on a torn down plugin instance
1738         which crashed consistently on windows in the debugger. The functions which issue
1739         these logs already have a valid window script object. We now have variants of the pluginLog
1740         function which take in a window script object with and without variable arguments. 
1741
1742         https://bugs.webkit.org/show_bug.cgi?id=31067
1743
1744         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1745         (pluginLogWithWindowObject):
1746         (pluginLogWithWindowObjectVariableArgs):
1747         (pluginLog):
1748         (notifyTestCompletion):
1749         (testDocumentOpen):
1750         (testWindowOpen):
1751
1752 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1753
1754         Reviewed by Gustavo Noronha Silva.
1755
1756         https://bugs.webkit.org/show_bug.cgi?id=30997
1757         [Gtk] Implemment AtkDocument
1758
1759         Added testing support.
1760
1761         * DumpRenderTree/AccessibilityUIElement.cpp:
1762         * DumpRenderTree/AccessibilityUIElement.h:
1763         (getDocumentEncodingCallback):
1764         (getDocumentURICallback):
1765         (AccessibilityUIElement::getJSClass):
1766         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1767         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1768         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1769         (AccessibilityUIElement::documentEncoding):
1770         (AccessibilityUIElement::documentURI):
1771
1772 2009-11-12  Adam Roben  <aroben@apple.com>
1773
1774         Replace worldIDs with world objects
1775
1776         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1777         user scripts/stylesheets and isolated worlds
1778
1779         Reviewed by Sam Weinig.
1780
1781         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1782         (LayoutTestController::addUserScript):
1783         (LayoutTestController::addUserStyleSheet):
1784         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1785         (LayoutTestController::addUserScript):
1786         (LayoutTestController::addUserStyleSheet):
1787         Changed these functions to create a new WebJSWorld each time they're
1788         called and to pass that world to WebKit.
1789
1790 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1791
1792         Reviewed by Oliver Hunt.
1793
1794         need to implement aria tree roles
1795         https://bugs.webkit.org/show_bug.cgi?id=31284
1796
1797         * DumpRenderTree/AccessibilityUIElement.cpp:
1798         (disclosedRowAtIndexCallback):
1799         (selectedRowAtIndexCallback):
1800         (isEqualCallback):
1801         (isAttributeSettableCallback):
1802         (isActionSupportedCallback):
1803         (disclosedByRowCallback):
1804         (hierarchicalLevelCallback):
1805         (AccessibilityUIElement::getJSClass):
1806         * DumpRenderTree/AccessibilityUIElement.h:
1807         (AccessibilityUIElement::isEqual):
1808         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1809         (AccessibilityUIElement::hierarchicalLevel):
1810         (AccessibilityUIElement::disclosedRowAtIndex):
1811         (AccessibilityUIElement::selectedRowAtIndex):
1812         (AccessibilityUIElement::disclosedByRow):
1813         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1814         (AccessibilityUIElement::getChildAtIndex):
1815         (AccessibilityUIElement::disclosedRowAtIndex):
1816         (AccessibilityUIElement::selectedRowAtIndex):
1817         (AccessibilityUIElement::titleUIElement):
1818         (AccessibilityUIElement::parentElement):
1819         (AccessibilityUIElement::disclosedByRow):
1820         (AccessibilityUIElement::hierarchicalLevel):
1821         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1822         (AccessibilityUIElement::hierarchicalLevel):
1823         (AccessibilityUIElement::disclosedRowAtIndex):
1824         (AccessibilityUIElement::selectedRowAtIndex):
1825         (AccessibilityUIElement::disclosedByRow):
1826
1827 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1828
1829         Reviewed by Darin Adler.
1830
1831         svn-apply can not handle git binary diffs
1832         https://bugs.webkit.org/show_bug.cgi?id=26830
1833
1834         Support "literal" type git binary diffs.
1835
1836         * Scripts/VCSUtils.pm:
1837         * Scripts/modules/scm_unittest.py:
1838         * Scripts/svn-apply:
1839
1840 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1841
1842         Not reviewed, removing duplicate entry for myself in committers.py.
1843
1844         * Scripts/modules/committers.py:
1845
1846 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1847
1848         Reviewed by Darin Adler and Mark Rowe.
1849
1850         https://bugs.webkit.org/show_bug.cgi?id=31200
1851         Tests in http/tests/security/mixedContent start to fail when new tests are added
1852
1853         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1854
1855 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1856
1857         Reviewed by Jan Alonzo.
1858
1859         Create, and display a window for the inspector, for inspector
1860         tests.
1861
1862         Need to also show/hide the inspector window to avoid having
1863         problems with code assuming it is realized
1864         https://bugs.webkit.org/show_bug.cgi?id=31347
1865
1866         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1867         (webInspectorShowWindow):
1868         (webInspectorCloseWindow):
1869         (webInspectorInspectWebView):
1870         (createWebView):
1871
1872 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1873
1874         Unreviewed Qt buildbot fix.
1875
1876         My previous fix was wrong, so revert that change and fix it by
1877         returning when the document of the frame has no document element.
1878         Idea is borrowed from mac and win DRT.
1879
1880         * DumpRenderTree/qt/DumpRenderTree.cpp:
1881         (WebCore::DumpRenderTree::dumpFramesAsText):
1882
1883 2009-11-11  Eric Seidel  <eric@webkit.org>
1884
1885         Reviewed byg Kenneth Rohde Christiansen.
1886
1887         Update Kenneth's committer record to include the email he
1888         uses on lists.webkit.org.
1889
1890         * Scripts/modules/committers.py:
1891
1892 2009-11-11  Eric Seidel  <eric@webkit.org>
1893
1894         Reviewed by Gustavo Noronha Silva.
1895
1896         Several committers use separate email addresses for bugzilla and svn.webkit.org
1897         https://bugs.webkit.org/show_bug.cgi?id=31364
1898
1899         Update records for existing committers to include email addresses
1900         used in svn.webkit.org and lists.webkit.org.
1901         Most committers use the same email address in all 3 places, but some use
1902         separate addresses.  committers.py needs record of each of these addresses.
1903
1904         * Scripts/modules/committers.py:
1905
1906 2009-11-11  Eric Seidel  <eric@webkit.org>
1907
1908         No review, adding second email address for an existing committer.
1909
1910         Add Yong Li's second bugzilla account to his committer record.
1911         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1912
1913         * Scripts/modules/committers.py:
1914
1915 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1916
1917         Reviewed by Simon Hausmann.
1918
1919         If the frame has no innerText don't append it, and
1920         do not add a newline which breaks some cross platform
1921         results.
1922
1923         * DumpRenderTree/qt/DumpRenderTree.cpp:
1924         (WebCore::DumpRenderTree::dumpFramesAsText):
1925
1926 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1927
1928         Reviewed by Simon Hausmann.
1929
1930         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1931
1932         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1933         (webkit_test_plugin_new_instance):
1934         (webkit_test_plugin_destroy_instance):
1935         (webkit_test_plugin_destroy_stream):
1936
1937 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1938
1939         Reviewed by Mark Rowe.
1940
1941         Implement the functionality needed by plugins/window-open.html
1942
1943         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1944         (webkit_test_plugin_new_instance):
1945         (webkit_test_plugin_set_window):
1946
1947 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1948
1949         Reviewed by Simon Hausmann.
1950
1951         [Qt] Force -graphicssystem raster and -style windows when running DRT
1952
1953         * DumpRenderTree/qt/main.cpp:
1954         * Scripts/run-webkit-tests:
1955
1956 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1957
1958         Reviewed by Simon Hausmann.
1959
1960         Compute correct library paths for Qt
1961
1962         * Scripts/webkitdirs.pm:
1963
1964 2009-11-10  Mark Rowe  <mrowe@apple.com>
1965
1966         Reviewed by Sam Weinig.
1967
1968         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1969
1970         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1971         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1972         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1973         that had enabled frame load delegate logging this would result in extra log messages being generated,
1974         causing the test to fail.
1975
1976         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1977         tests.
1978
1979         * DumpRenderTree/mac/DumpRenderTree.mm:
1980         (dumpRenderTree):
1981         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1982         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1983
1984 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1985
1986         Reviewed by Kenneth Rohde Christiansen.
1987
1988         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1989
1990         * DumpRenderTree/qt/DumpRenderTree.cpp:
1991         (WebCore::DumpRenderTree::DumpRenderTree):
1992
1993 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1994
1995         Reviewed by Jan Alonzo.
1996
1997         [GTK] Remove WebSocket configuration from WebKitWebSettings
1998         https://bugs.webkit.org/show_bug.cgi?id=31244
1999
2000         Follow-up of r50724. Don't set the enable-web-socket property
2001         anymore.
2002
2003         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2004         (resetDefaultsToConsistentValues):
2005
2006 2009-11-10  Oliver Hunt  <oliver@apple.com>
2007
2008         Reviewed by Maciej Stachowiak.
2009
2010         Rename 3D Canvas related classes to use WebGL prefix
2011         https://bugs.webkit.org/show_bug.cgi?id=29095
2012
2013         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2014         and upate webkitdirs script to new method of testing for WebGL.
2015
2016         * Scripts/do-webcore-rename:
2017         * Scripts/webkitdirs.pm:
2018
2019 2009-11-09  Oliver Hunt  <oliver@apple.com>
2020
2021         Reviewed by Geoff Garen.
2022
2023         Make do-webcore-rename work with git.
2024
2025         * Scripts/do-webcore-rename:
2026
2027 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2028
2029         Adding Kenneth to the reviewers list.
2030
2031         * Scripts/modules/committers.py:
2032
2033 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2034
2035         Reviewed by Jan Alonzo.
2036
2037         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2038         https://bugs.webkit.org/show_bug.cgi?id=30482
2039
2040         LayoutTestControllerGtk now uses the exposed
2041         Page::tabKeyCyclesThroughElements API
2042
2043         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2044         (LayoutTestController::setTabKeyCyclesThroughElements):
2045
2046 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2047
2048         Reviewed by Holger Freyther.
2049
2050         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2051         This helps to pass the test case below. Also replaced hardcoded
2052         code numbers with defined constants.
2053         https://bugs.webkit.org/show_bug.cgi?id=31185
2054         
2055         Test: editing/undo/undo-deleteWord.html
2056
2057         * DumpRenderTree/qt/EventSenderQt.cpp:
2058         (EventSender::keyDown):
2059
2060 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2061
2062         Reviewed by Holger Freyther.
2063
2064         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2065         https://bugs.webkit.org/show_bug.cgi?id=31164
2066
2067         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2068
2069         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2070         (LayoutTestController::processWork):
2071
2072 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2073
2074         Reviewed by Holger Freyther.
2075
2076         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2077         https://bugs.webkit.org/show_bug.cgi?id=31158
2078
2079         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2080         always, which from WorkQueue prospective means that a load has been started
2081         and the queue processing should stop and wait for the load to finish.
2082         Spinning it off into a loading and a non-loading variants was the solution
2083         adopted by Mac's DRT to work around this problem. The former keeps returning
2084         'true' while the later executes the script synchronously and returns 'false'
2085         making it possible to the WorkQueue to proceed right away.
2086
2087         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2088         (LayoutTestController::processWork):
2089         (LayoutTestController::queueLoadingScript):
2090         (LayoutTestController::queueNonLoadingScript):
2091         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2092         * DumpRenderTree/qt/WorkQueueItem.h:
2093         (LoadingScriptItem::LoadingScriptItem):
2094         (LoadingScriptItem::invoke):
2095         (NonLoadingScriptItem::NonLoadingScriptItem):
2096         (NonLoadingScriptItem::invoke):
2097
2098 2009-11-07  Mark Rowe  <mrowe@apple.com>
2099
2100         Rubber-stamped by Cameron Zwarich.
2101
2102         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2103
2104         * Scripts/commit-log-editor:
2105
2106 2009-11-07  Mark Rowe  <mrowe@apple.com>
2107
2108         Reviewed by Darin Adler.
2109
2110         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2111         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2112
2113         Move logic for determining the name and email address to use in a ChangeLog entry from
2114         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2115         whether the author of the patch matches committer, and therefore needs access to the
2116         email address that would be used in a ChangeLog entry.
2117
2118         Based on a patch by Pierre d'Herbemont.
2119
2120         * Scripts/VCSUtils.pm:
2121         * Scripts/commit-log-editor:
2122         * Scripts/prepare-ChangeLog:
2123         * Scripts/webkitdirs.pm:
2124
2125 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2126
2127         Reviewed by Adam Barth.
2128
2129         Added functionality to the layout test plugin to invoke document.open and
2130         window.open with default arguments. The associated webkit bug is
2131         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2132         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2133         work in Chromium (V8) if there is no calling javascript context. To achieve this
2134         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2135         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2136
2137         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2138         (testDocumentOpen):
2139         (testWindowOpen):
2140         (pluginAllocate):
2141         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2142         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2143         (NPP_New):
2144         (NPP_SetWindow):
2145         (NPP_DestroyStream):
2146         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2147         (NPP_New):
2148         (NPP_SetWindow):
2149         (NPP_NewStream):
2150         (NPP_DestroyStream):
2151
2152 2009-11-06  Eric Seidel  <eric@webkit.org>
2153
2154         Reviewed by Adam Barth.
2155
2156         bugzilla-tool crashed with exception
2157         https://bugs.webkit.org/show_bug.cgi?id=31092
2158
2159         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2160
2161 2009-11-04  Eric Seidel  <eric@webkit.org>
2162
2163         No review, just add a line which got left out of the patch uploaded for commit.
2164
2165         commit-queue is crashing when trying to reject patches after unknown failures
2166         https://bugs.webkit.org/show_bug.cgi?id=31091
2167
2168         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2169
2170 2009-11-04  Adam Roben  <aroben@apple.com>
2171
2172         Remove bogus else clause in bugzilla-tool
2173
2174         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2175         create-bug raises exception after entering bug description
2176
2177         Reviewed by David Kilzer.
2178
2179         * Scripts/bugzilla-tool:
2180         (CreateBug): else clauses are only hit if no exception is raised, so
2181         it makes no sense to try to re-raise the exception in an else clause.
2182         The exception will automatically be re-raised if it doesn't match any
2183         of the except clauses, so we don't have to do anything special here at
2184         all to get the desired behavior.
2185
2186 2009-11-04  Eric Seidel  <eric@webkit.org>
2187
2188         Reviewed by David Kilzer.
2189
2190         svn-apply's fixChangeLogPatch function seems broken
2191         https://bugs.webkit.org/show_bug.cgi?id=30683
2192
2193         Update fixChangeLogPatch to be able to handle patches which
2194         don't start at line 1.
2195         Add unit tests for svn-apply to scm_unittest.py.
2196
2197         * Scripts/VCSUtils.pm:
2198         * Scripts/modules/scm_unittest.py:
2199
2200 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2201
2202         Reviewed by Beth Dakin.
2203
2204         Need to implement ARIA role="combobox"
2205         https://bugs.webkit.org/show_bug.cgi?id=31096
2206
2207         * DumpRenderTree/AccessibilityUIElement.cpp:
2208         (showMenuCallback):
2209         (getIsExpandedCallback):
2210         (AccessibilityUIElement::getJSClass):
2211         * DumpRenderTree/AccessibilityUIElement.h:
2212         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2213         (AccessibilityUIElement::isExpanded):
2214         (AccessibilityUIElement::showMenu):
2215         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2216         (AccessibilityUIElement::isExpanded):
2217         (AccessibilityUIElement::showMenu):
2218         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2219         (AccessibilityUIElement::isSelected):
2220         (AccessibilityUIElement::isExpanded):
2221         (AccessibilityUIElement::showMenu):
2222
2223 2009-11-04  Eric Seidel  <eric@webkit.org>
2224
2225         Reviewed by Adam Barth.
2226
2227         commit-queue is crashing when trying to reject patches after unknown failures
2228         https://bugs.webkit.org/show_bug.cgi?id=31091
2229
2230         * Scripts/bugzilla-tool:
2231          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2232            so we have to find out what the current patch is by asking bugzilla again.
2233          - Discovered that this code was also leaking file descriptors, so fixed that.
2234
2235 2009-11-04  Adam Roben  <aroben@apple.com>
2236
2237         Make run-webkit-tests work for the Debug_Internal Windows
2238         configuration
2239
2240         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2241         suffix.
2242
2243         Fixes <http://webkit.org/b/31123>.
2244
2245         Reviewed by Sam Weinig.
2246
2247         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2248         Debug_Internal, either.
2249
2250 2009-11-04  Eric Seidel  <eric@webkit.org>
2251
2252         Reviewed by Adam Barth.
2253
2254         committers.py needs a way to store non-bugzilla email addresses
2255         https://bugs.webkit.org/show_bug.cgi?id=31037
2256
2257         Make Committer and Reviewer constructors take a single email or a list of emails.
2258         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2259         Expose reviewers(), used by validate-committer-lists on bug 30970.
2260
2261         * Scripts/modules/committers.py:
2262         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2263
2264 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2265
2266         Reviewed by David Levin.
2267
2268         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2269         https://bugs.webkit.org/show_bug.cgi?id=27491
2270
2271         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2272         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2273
2274         Functions to start or stop Web Socket servers are added.
2275
2276         * Scripts/run-webkit-tests:
2277
2278 2009-11-03  Eric Seidel  <eric@webkit.org>
2279
2280         No review, just changing wording of log message.
2281
2282         Change log string to say "failed" instead of "rejected"
2283         when a commit fails due to an out of date checkout.
2284         This makes grepping the commit-queue log for rejected patches easier.
2285
2286         * Scripts/bugzilla-tool:
2287
2288 2009-11-03  Eric Seidel  <eric@webkit.org>
2289
2290         No review, adding commonly known committers missing from the file.
2291
2292         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2293
2294 2009-11-03  Eric Seidel  <eric@webkit.org>
2295
2296         No review, just sort-order cleanup.
2297
2298         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2299
2300 2009-11-03  Stephen White  <senorblanco@chromium.org>
2301
2302         (Unreviewed).
2303
2304         Add myself to committers.py.
2305
2306         * Scripts/modules/committers.py:
2307
2308 2009-11-03  Robin Dunn  <robin@alldunn.com>
2309
2310         Reviewed by Kevin Ollviier.
2311
2312         Add packaging scripts for Debian-based Linux distros.
2313         
2314         https://bugs.webkit.org/show_bug.cgi?id=31075
2315
2316         * wx/packaging/build-debian-installer.py: Added.
2317         * wx/packaging/debian: Added.
2318
2319 2009-11-03  Dan Bernstein  <mitz@apple.com>
2320
2321         Reviewed by Anders Carlsson and Beth Dakin.
2322
2323         https://bugs.webkit.org/show_bug.cgi?id=31070
2324
2325         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2326         destroyed, it executes the value of the 'ondestroy' parameter as a
2327         script.
2328
2329         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2330         (pluginAllocate): Initialize onDestroy.
2331         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2332         onDestroy.
2333         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2334         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2335         specified.
2336         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2337
2338 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2339
2340         Reviewed by Xan Lopez.
2341
2342         https://bugs.webkit.org/show_bug.cgi?id=31035
2343         [GTK] some accessibility tests hitting assertion in debug builds
2344
2345         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2346
2347         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2348         (AccessibilityController::rootElement):
2349
2350 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2351
2352         Reviewed by Beth Dakin.
2353
2354         Support ARIA "tab" roles
2355         https://bugs.webkit.org/show_bug.cgi?id=30842
2356
2357         * DumpRenderTree/AccessibilityUIElement.cpp:
2358         * DumpRenderTree/AccessibilityUIElement.h:
2359         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2360         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2361         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2362
2363 2009-11-01  Eric Seidel  <eric@webkit.org>
2364
2365         Reviewed by David Levin.
2366
2367         buildbots should use --exit-after-N-failures
2368         https://bugs.webkit.org/show_bug.cgi?id=30809
2369
2370         Make the bots exit after 20 failures to prevent never-ending
2371         test runs where every test spends a minute crashing.
2372
2373         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2374
2375 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2376
2377         Reviewed by Eric Seidel.
2378
2379         Turn on warnings for QtWebKit for gcc
2380         https://bugs.webkit.org/show_bug.cgi?id=30958
2381
2382         * DumpRenderTree/qt/main.cpp: 
2383         (crashHandler): Mark function NO_RETURN
2384
2385 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2386
2387         Adding myself to the committers list.
2388
2389         * Scripts/modules/committers.py:
2390
2391 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2392
2393         Fix an issue that Adam noticed in DRT.
2394
2395         Reviewed by Darin Adler.
2396
2397         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2398         (AccessibilityUIElement::role):
2399         Get the length of the role text, and create a buffer dynamically.
2400
2401 2009-10-30  Eric Seidel  <eric@webkit.org>
2402
2403         No review, rolling out r50105.
2404         http://trac.webkit.org/changeset/50105
2405
2406         This commit was causing:
2407         https://bugs.webkit.org/show_bug.cgi?id=30869
2408         We'll re-implement the feature a different way.
2409
2410         * Scripts/bugzilla-tool:
2411
2412 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2413
2414         Test for MSAA: Accessibility of headings is not correct
2415
2416         https://bugs.webkit.org/show_bug.cgi?id=30937
2417
2418         Reviewed by Adam Roben.
2419
2420         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2421         (AccessibilityUIElement::role):
2422         Allow the role returned to be a BSTR.
2423         (AccessibilityUIElement::description):
2424         Fix a copy/paste error.
2425
2426 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2427
2428         Test for MSAA: Accessibility of links is wrong
2429
2430         https://bugs.webkit.org/show_bug.cgi?id=30928
2431
2432         Reviewed by Darin Adler.
2433
2434         * DumpRenderTree/AccessibilityUIElement.cpp:
2435         (getAccessibilityValueCallback):
2436         Return the accessibility value.
2437         (AccessibilityUIElement::getJSClass):
2438         Added "accessibilityValue" value.
2439
2440         * DumpRenderTree/AccessibilityUIElement.h:
2441
2442         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2443         (AccessibilityUIElement::accessibilityValue):
2444         Stubbed.
2445
2446         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2447         (AccessibilityUIElement::accessibilityValue):
2448         Stubbed.
2449
2450         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2451         (AccessibilityUIElement::accessibilityValue):
2452         Get the object's value, and return it as a JS string.
2453
2454 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2455
2456         Fix typo in command name used by wx build system.
2457
2458         * wx/build/build_utils.py:
2459
2460 2009-10-30  Adam Barth  <abarth@webkit.org>
2461
2462         Reviewed by Darin Adler.
2463
2464         Patch v1 is a dumb default name for patches
2465         https://bugs.webkit.org/show_bug.cgi?id=30952
2466
2467         Let's use "Patch" instead.
2468
2469         * Scripts/bugzilla-tool:
2470
2471 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2472
2473         Unreviewed trivial buildfix.
2474
2475         [Qt] Buildfix for r50333.
2476
2477         * DumpRenderTree/qt/DumpRenderTree.pro:
2478
2479 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2480
2481         Reviewed by Holger Freyther.
2482
2483         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2484         https://bugs.webkit.org/show_bug.cgi?id=30953
2485
2486         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2487         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2488         makes qt DRT to share this implementation (as gtk and mac ports do).
2489
2490         * DumpRenderTree/qt/DumpRenderTree.pro:
2491         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2492         * DumpRenderTree/qt/WorkQueue.h: Removed.
2493
2494 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2495
2496         Unreviewed potential buildbot fix.
2497
2498         Second try: Reset page history before running each test.
2499
2500         Apparently the QWebHistory::clear() keeps the current page
2501         in history which is not what we want, so we not additionally
2502         sets the history capacity to 0 (forces removing everything)
2503         and then sets it back to its original value.
2504
2505         * DumpRenderTree/qt/DumpRenderTree.cpp:
2506         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2507
2508 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2509
2510         Unreviewed potential buildbot fix.
2511
2512         Reset page history before running each test.
2513
2514         * DumpRenderTree/qt/DumpRenderTree.cpp:
2515         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2516
2517 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2518
2519         Reviewed by Eric Seidel.
2520
2521         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2522
2523         Bug 28420 -  Implement HTML5 <ruby> rendering
2524         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2525
2526         No new tests (no functional change).
2527
2528         * Scripts/build-webkit:
2529
2530 2009-10-29  Dan Bernstein  <mitz@apple.com>
2531
2532         Reviewed by Mark Rowe.
2533
2534         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2535         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2536         define it.
2537
2538         * Scripts/VCSUtils.pm:
2539         * Scripts/svn-apply:
2540         * Scripts/svn-unapply:
2541
2542 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2543
2544         Reviewed by Gustavo Noronha.
2545
2546         Use the GTK+ main loop instead of rolling our own mini-version of
2547         it.
2548
2549         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2550         (dump):
2551         (runTest):
2552         (webViewLoadFinished):
2553
2554 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2555
2556         Reviewed by Oliver Hunt.
2557
2558         Implement the Qt version of DRT dumpBackForwardList().
2559
2560         * DumpRenderTree/qt/DumpRenderTree.cpp:
2561         (WebCore::dumpHistoryItem):
2562         (WebCore::DumpRenderTree::dumpBackForwardList):
2563
2564 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2565
2566         Reviewed by Adam Roben.
2567
2568         Implement DRT functionality for Qt introduced in
2569         r28690 and r28705.
2570
2571         - Implemented pathToLocalResource which exposes the functionality of
2572         converting a given unix path to the correct location on Windows.
2573         - Implemented a way to remove machine-dependent information from paths
2574         in layout test results.
2575
2576         * DumpRenderTree/qt/DumpRenderTree.cpp:
2577         (WebCore::urlSuitableForTestResult):
2578         (WebCore::WebPage::javaScriptConsoleMessage):
2579         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2580         (LayoutTestController::pathToLocalResource):
2581         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2582
2583 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2584
2585         Adding myself to the committers list.
2586
2587         * Scripts/modules/committers.py:
2588
2589 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2590
2591         Adding myself to the committers list.
2592
2593         * Scripts/modules/committers.py:
2594
2595 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2596
2597         Reviewed by Jan Alonzo.
2598
2599         [GTK] API to start inspector for a WebView
2600         https://bugs.webkit.org/show_bug.cgi?id=22551
2601
2602         Use the new inspector API to implement the LayoutTestController
2603         interfaces used to test the inspector.
2604
2605         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2606         (webInspectorInspectWebView):
2607         (createWebView):
2608         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2609         (LayoutTestController::showWebInspector):
2610         (LayoutTestController::closeWebInspector):
2611         (LayoutTestController::evaluateInWebInspector):
2612
2613 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2614
2615         Reviewed by Eric Seidel.
2616
2617         [Qt] WebFrame::counterValueForElementById must not be exposed
2618         https://bugs.webkit.org/show_bug.cgi?id=30882
2619
2620         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2621         (LayoutTestController::counterValueForElementById):
2622
2623 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2624
2625         Rubberstamped by Oliver Hunt.
2626
2627         Fix the warning:
2628
2629         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2630         declared with attribute warn_unused_result".
2631
2632         by actually checking the result. In the case it is null, an
2633         error has occoured, so treat it as the other fatal errors.
2634
2635         * DumpRenderTree/qt/DumpRenderTree.cpp:
2636         (WebCore::DumpRenderTree::initializeFonts):
2637
2638 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2639
2640         Reviewed by Darin Adler.
2641
2642         Provide a way to get counter values with layoutTestContoller
2643         https://bugs.webkit.org/show_bug.cgi?id=30555
2644
2645         Define layoutTestContoller.counterValueForElementById.
2646
2647         * DumpRenderTree/LayoutTestController.cpp:
2648         (counterValueForElementByIdCallback):
2649         (LayoutTestController::staticFunctions):
2650         * DumpRenderTree/LayoutTestController.h:
2651         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2652         (LayoutTestController::counterValueForElementById):
2653
2654 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2655
2656         Rubberstamped by Oliver Hunt.
2657
2658         Change two methods to be internal for DRT use only.
2659
2660         Part of [Qt] Review all new API in Qt 4.6
2661         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2662
2663         * DumpRenderTree/qt/DumpRenderTree.cpp:
2664         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2665         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2666         (LayoutTestController::whiteListAccessFromOrigin):
2667
2668 2009-10-27  Eric Seidel  <eric@webkit.org>
2669
2670         Reviewed by Adam Barth.
2671
2672         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2673         https://bugs.webkit.org/show_bug.cgi?id=30826
2674
2675         * Scripts/svn-apply:
2676          - Add () around all system() calls.
2677          - Use the correct system() == 0 or die instead of system() or die
2678          - Add descriptive messages to all die statements.
2679
2680 2009-10-27  Steve Block  <steveblock@google.com>
2681
2682         Reviewed by NOBODY.
2683
2684         Adds steveblock@google.com to list of committers.
2685
2686         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2687
2688 2009-10-27  Eric Seidel  <eric@webkit.org>
2689
2690         Reviewed by Adam Barth.
2691
2692         svn-apply can exit(0) even on patch failure
2693         https://bugs.webkit.org/show_bug.cgi?id=29622
2694
2695         * Scripts/svn-apply:
2696          - Add a bunch of "or die" statements, hopefully catching all
2697            possible cases where failure could still exit(0).
2698
2699 2009-10-27  Eric Seidel  <eric@webkit.org>
2700
2701         Reviewed by Adam Barth.
2702
2703         svn-* scripts should share code through VCSUtils.pm
2704         https://bugs.webkit.org/show_bug.cgi?id=30791
2705
2706         Just moving code into a shared location.
2707
2708         * Scripts/VCSUtils.pm:
2709         * Scripts/prepare-ChangeLog:
2710         * Scripts/resolve-ChangeLogs:
2711         * Scripts/svn-apply:
2712         * Scripts/svn-create-patch:
2713         * Scripts/svn-unapply:
2714         * Scripts/update-webkit:
2715
2716 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2717
2718         Suppress a huge number of MSVC warnings when building wxWebKit.
2719
2720         * wx/build/settings.py:
2721
2722 2009-10-26  Eric Seidel  <eric@webkit.org>
2723
2724         No review, just adding Mike Belshe to the committers list.
2725
2726         * Scripts/modules/committers.py:
2727
2728 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2729
2730         Reviewed by Darin Adler.
2731
2732         Make .rc files compile on Windows without depending on MFC headers
2733         https://bugs.webkit.org/show_bug.cgi?id=30750
2734
2735         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2736         windows.h instead of afxres.h because it exists even when MFC is not 
2737         installed, and is all that's needed here.
2738
2739         * FindSafari/FindSafari.rc: Ditto
2740
2741 2009-10-24  Eric Seidel  <eric@webkit.org>
2742
2743         Reviewed by Adam Barth.
2744
2745         bugzilla-tool post-diff should know how to mark commit-queue=?
2746         https://bugs.webkit.org/show_bug.cgi?id=29202
2747
2748         * Scripts/bugzilla-tool:
2749          - Add --commit-queue option to post-diff, post-commits and create-bug.
2750         * Scripts/modules/bugzilla.py:
2751          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2752          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2753
2754 2009-10-23  Eric Seidel  <eric@webkit.org>
2755
2756         Reviewed by Adam Barth.
2757
2758         bugzilla-tool commit-queue does not notice modifications to committers.py
2759         https://bugs.webkit.org/show_bug.cgi?id=30084
2760
2761         * Scripts/bugzilla-tool:
2762          - Make commit-queue re-exec itself instead of using while(1).
2763          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2764          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2765
2766 2009-10-22  Eric Seidel  <eric@webkit.org>
2767
2768         Reviewed by Adam Barth.
2769
2770         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2771         https://bugs.webkit.org/show_bug.cgi?id=30634
2772
2773         * Scripts/bugzilla-tool:
2774          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2775          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2776
2777 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2778
2779         Reviewed by Eric Seidel.
2780
2781         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2782
2783         https://bugs.webkit.org/show_bug.cgi?id=30763
2784
2785         * pywebsocket/mod_pywebsocket/__init__.py:
2786         * pywebsocket/mod_pywebsocket/dispatch.py:
2787         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2788         * pywebsocket/mod_pywebsocket/standalone.py:
2789         * pywebsocket/setup.py:
2790         * pywebsocket/test/test_dispatch.py:
2791
2792 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2793
2794         Reviewed by David Levin.
2795
2796         REGRESSION: 2 failures in run-webkit-unittests
2797         https://bugs.webkit.org/show_bug.cgi?id=30645
2798
2799         * Scripts/modules/cpp_style_unittest.py:
2800         Fixed a few test scenarios which apparently lost some spaces from 
2801         text literals.
2802
2803 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2804
2805         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2806
2807         * Scripts/webkitdirs.pm:
2808
2809 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2810
2811         Reviewed by Darin Adler.
2812
2813         Unification of using null device in perl scripts.
2814         https://bugs.webkit.org/show_bug.cgi?id=30572
2815
2816         * Scripts/VCSUtils.pm:
2817         * Scripts/bisect-builds:
2818         * Scripts/resolve-ChangeLogs:
2819         * Scripts/run-iexploder-tests:
2820         * Scripts/run-jsc:
2821         * Scripts/run-mangleme-tests:
2822         * Scripts/run-webkit-tests:
2823         * Scripts/webkitdirs.pm:
2824         Using File::Spec->devnull() instead of hard coded /dev/null.
2825
2826 2009-10-26  Eric Seidel  <eric@webkit.org>
2827
2828         Reviewed by Holger Freyther.
2829
2830         Reviewers are missing from committers.py
2831         https://bugs.webkit.org/show_bug.cgi?id=30733
2832
2833         * Scripts/modules/committers.py:
2834
2835 2009-10-23  Eric Seidel  <eric@webkit.org>
2836
2837         No review, only adding Alice to the list of reviewers.
2838
2839         * Scripts/modules/committers.py:
2840
2841 2009-10-23  Eric Seidel  <eric@webkit.org>
2842
2843         Reviewed by Eric Carlson.
2844
2845         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2846         https://bugs.webkit.org/show_bug.cgi?id=30700
2847
2848         * DumpRenderTree/mac/DumpRenderTree.mm:
2849         (resetDefaultsToConsistentValues): Update QuickTime version check.
2850
2851 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2852
2853         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2854         character measurement APIs that are private on Tiger.
2855
2856         * wx/build/settings.py:
2857
2858 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2859
2860         Reviewed by NOBODY (build fix).
2861         Build fix following bug #30696.
2862
2863         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2864         (LayoutTestController::evaluateScriptInIsolatedWorld):
2865
2866 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2867
2868         Reviewed by Sam Weinig & Geoff Garen.
2869
2870         https://bugs.webkit.org/show_bug.cgi?id=30696
2871         Enable isolated-worlds tests on mac.
2872
2873         Add private interface for DRT to invoke execution in a given world.
2874
2875         * DumpRenderTree/LayoutTestController.cpp:
2876         (evaluateScriptInIsolatedWorldCallback):
2877         (LayoutTestController::staticFunctions):
2878         * DumpRenderTree/LayoutTestController.h:
2879         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2880         (LayoutTestController::evaluateScriptInIsolatedWorld):
2881         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2882         (LayoutTestController::evaluateScriptInIsolatedWorld):
2883
2884 2009-10-21  Eric Seidel  <eric@webkit.org>
2885
2886         Reviewed by Adam Barth.
2887
2888         bugzilla-tool's "patch failed to download an apply" error should give more information
2889         https://bugs.webkit.org/show_bug.cgi?id=30632
2890
2891         * Scripts/modules/scm.py:
2892          - Use the common run_command method instead of custom POpen code.
2893          - Make run_command know how to take pipes as input.
2894         * Scripts/modules/scm_unittest.py:
2895          - Add new tests to cover change.
2896          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2897
2898 2009-10-21  Kent Tamura  <tkent@chromium.org>
2899
2900         Unreviewed.  Adding myself to the committers list.
2901
2902         * Scripts/modules/committers.py:
2903
2904 2009-10-21  Robin Dunn  <robin@alldunn.com>
2905
2906         Reviewed by Kevin Ollivier.
2907
2908         Update the Windows installer builder to work with Vista / Win 7 and with git.
2909         
2910         https://bugs.webkit.org/show_bug.cgi?id=30649
2911
2912         * wx/build/build_utils.py:
2913         * wx/packaging/build-mac-installer.py:
2914         * wx/packaging/build-win-installer.py:
2915         * wx/packaging/wxWebKitInstaller.iss.in:
2916
2917 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2918
2919         Reviewed by Gustavo Noronha.
2920
2921         [GTK] Added conditional code to avoid using
2922         gdk_window_get_root_coords if we do not have a gtk+ release newer
2923         than 2.17.3.
2924         https://bugs.webkit.org/show_bug.cgi?id=30636
2925
2926         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2927
2928 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2929
2930         Reviewed by Eric Seidel.
2931
2932         [Qt] Added dummy implementation for keepWebHistory()
2933         https://bugs.webkit.org/show_bug.cgi?id=30592
2934
2935         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2936         (LayoutTestController::keepWebHistory):
2937         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2938
2939 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2940
2941         Reviewed by Xan Lopez.
2942
2943         [GTK] Fixed the double click condition, it is not double click if
2944         we move in just in one direction.
2945         https://bugs.webkit.org/show_bug.cgi?id=30636
2946
2947         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2948
2949 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2950
2951         Reviewed by Xan Lopez.
2952
2953         [GTK] Initialize the events completly before emitting them.
2954         https://bugs.webkit.org/show_bug.cgi?id=30633
2955
2956         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2957
2958 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2959
2960         wx build fix. Fix for when linking using --as-needed with gcc.
2961
2962         * wx/browser/wscript:
2963
2964 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2965
2966         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2967         to support all the features used by CURL backend.
2968         
2969         * wx/build/settings.py:
2970         * wx/install-unix-extras:
2971
2972 2009-10-20  Anton Muhin  <antonm@chromium.org>
2973
2974         Reviewed by Adam Barth.
2975
2976         Add {ager,antonm,yurys}@chromium.org into committers.py
2977         https://bugs.webkit.org/show_bug.cgi?id=30560
2978
2979         * Scripts/modules/committers.py:
2980
2981 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2982
2983         Reviewed by Tor Arne Vestbø.
2984
2985         Make the Netscape Test plugin available to the Qt launcher.
2986
2987         * Scripts/run-launcher:
2988
2989 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2990
2991         Reviewed by David Levin.
2992
2993         Removed WebSocket runtime settings.
2994         https://bugs.webkit.org/show_bug.cgi?id=29896
2995
2996         WebSocket runtime configuration is supported by chromium/v8 only.
2997
2998         * DumpRenderTree/mac/DumpRenderTree.mm:
2999         (resetDefaultsToConsistentValues):
3000         * DumpRenderTree/win/DumpRenderTree.cpp:
3001         (resetDefaultsToConsistentValues):
3002
3003 2009-10-19  Nate Chapin  <japhet@chromium.org>
3004
3005         Reviewed by Adam Barth.
3006
3007         Add testFail() to test plugin so we can test our handling of a
3008         plugin invoke call returning false.
3009
3010         https://bugs.webkit.org/show_bug.cgi?id=30239
3011
3012         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3013         (pluginInvoke):
3014         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3015
3016 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3017
3018         Reviewed by Gustavo Noronha.
3019
3020         Enable DOM pasting when running layout tests.
3021
3022         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3023         (resetDefaultsToConsistentValues):
3024
3025 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3026
3027         Reviewed by Simon Hausmann.
3028
3029         Use the setPreferredContentsSize method instead
3030         of setFixedContentsSize, as the method has been renamed.
3031
3032         * DumpRenderTree/qt/DumpRenderTree.cpp:
3033         (WebCore::DumpRenderTree::open):
3034         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3035         (LayoutTestController::setFixedContentsSize):
3036
3037 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3038
3039         Reviewed by Dan Bernstein.
3040
3041         https://bugs.webkit.org/show_bug.cgi?id=30456
3042         Fixes for new Debug_All Windows build configuration.
3043
3044         * DumpRenderTree/win/DumpRenderTree.cpp:
3045         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3046         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3047
3048 2009-10-16  Eric Seidel  <eric@webkit.org>
3049
3050         Reviewed by Adam Barth.
3051
3052         commit-queue status bot should list which buildbot is blocking the queue
3053         https://bugs.webkit.org/show_bug.cgi?id=30452
3054
3055         Add new methods and testing.
3056
3057         * Scripts/bugzilla-tool:
3058         * Scripts/modules/buildbot.py:
3059         * Scripts/modules/buildbot_unittest.py:
3060
3061 2009-10-16  Eric Seidel  <eric@webkit.org>
3062
3063         Reviewed by Adam Barth.
3064
3065         run-webkit-tests fails when CWD is not inside a WebKit checkout
3066         https://bugs.webkit.org/show_bug.cgi?id=30451
3067
3068         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3069         * Scripts/modules/scm_unittest.py:
3070           - Remove use of original_path (we don't need to restore the CWD).
3071           - Don't use '.' to find the webkit checkout, use __file__ instead.
3072
3073 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3074
3075         Reviewed by Adam Roben.
3076
3077         Add a Debug_All configuration to build entire stack as debug.
3078         Change Debug_Internal to:
3079         - stop using _debug suffix for all WebKit/Safari binaries
3080         - not use _debug as a DLL naming suffix
3081         - use non-debug C runtime lib.
3082
3083         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3084         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3085         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3086         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3087         Add missing debug.vsprops inherited property sheet.
3088         Add Debug_All configuration.
3089         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3090         * WinLauncher/WinLauncher.vcproj:
3091         Removed extraneous definitions inherited from vsprops.
3092         Add Debug_All configuration.
3093
3094 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3095
3096         Reviewed by David Levin.
3097
3098         check-webkit-style is wrong about indent checking in namespaces
3099         in header files and a few other things
3100         https://bugs.webkit.org/show_bug.cgi?id=30362
3101
3102         The few other things include:
3103         + check-webkit-style does not require spaces around the equal sign
3104           inside 'if' statements and around binary operators that take 
3105           numeric literals.
3106         + check-webkit-style reports false errors for the / operator
3107           when part of a filename in the #include directive.
3108
3109         * Scripts/modules/cpp_style.py:
3110         Improved indentation checking and space checking around
3111         binary operators. While the checks are still not perfect,
3112         they are clearly better than before.
3113         * Scripts/modules/cpp_style_unittest.py:
3114         Added test cases for the newly supported checks and modified old
3115         test cases to match the new guidelines
3116
3117 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3118
3119         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3120
3121         * wx/build/settings.py:
3122
3123 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3124
3125         Reviewed by David Levin.
3126
3127         Add mod_pywebsocket to test Web Sockets.
3128         http://code.google.com/p/pywebsocket/
3129         https://bugs.webkit.org/show_bug.cgi?id=27490
3130
3131         * pywebsocket/COPYING: Added.
3132         * pywebsocket/MANIFEST.in: Added.
3133         * pywebsocket/README: Added.
3134         * pywebsocket/example/echo_client.py: Added.
3135         * pywebsocket/example/echo_wsh.py: Added.
3136         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3137         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3138         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3139         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3140         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3141         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3142         * pywebsocket/mod_pywebsocket/util.py: Added.
3143         * pywebsocket/setup.py: Added.
3144         * pywebsocket/test/config.py: Added.
3145         * pywebsocket/test/mock.py: Added.
3146         * pywebsocket/test/run_all.py: Added.
3147         * pywebsocket/test/test_dispatch.py: Added.
3148         * pywebsocket/test/test_handshake.py: Added.
3149         * pywebsocket/test/test_mock.py: Added.
3150         * pywebsocket/test/test_msgutil.py: Added.
3151         * pywebsocket/test/test_util.py: Added.
3152         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3153         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3154         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3155         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3156         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3157         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3158         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3159         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3160
3161 2009-10-15  James Robinson  <jamesr@google.com>
3162
3163         Reviewed by David Levin.
3164
3165         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3166
3167         https://bugs.webkit.org/show_bug.cgi?id=30426
3168
3169         * Scripts/modules/cpp_style.py:
3170         * Scripts/modules/cpp_style_unittest.py:
3171
3172 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3173
3174         Reviewed by Adam Roben.
3175
3176         Fixes <http://webkit.org/b/30411>.
3177         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3178         
3179         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3180         building Chromium.
3181
3182         * Scripts/pdevenv:
3183
3184 2009-10-15  Robin Dunn  <robin@alldunn.com>
3185
3186         Reviewed by Kevin Ollivier.
3187
3188         Add Mac package building scripts for wx.
3189         
3190         https://bugs.webkit.org/show_bug.cgi?id=30405
3191
3192         * wx/build/build_utils.py:
3193         * wx/build/settings.py:
3194         * wx/packaging/build-mac-installer.py: Added.
3195
3196 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3197
3198         Reviewed by Gustavo Noronha.
3199
3200         Enable Web Sockets support when running layout tests.
3201
3202         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3203         (resetDefaultsToConsistentValues):
3204
3205 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3206
3207         Reviewed by Gustavo Noronha.
3208
3209         Need to initialize event.button.button, since in most cases a
3210         button number is not passed as an argument.
3211
3212         * DumpRenderTree/gtk/EventSender.cpp:
3213         (mouseDownCallback):
3214         (mouseUpCallback):
3215
3216 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3217
3218         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3219         the OS if none was explicitly set.
3220
3221         * wx/build/settings.py:
3222
3223 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3224
3225         Reviewed by Timothy Hatcher.
3226
3227         Web Inspector: enable developers extras within inspector layout tests.
3228
3229         https://bugs.webkit.org/show_bug.cgi?id=30014
3230
3231         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3232         (LayoutTestController::showWebInspector):
3233         (LayoutTestController::closeWebInspector):
3234         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3235         (LayoutTestController::showWebInspector):
3236         (LayoutTestController::closeWebInspector):
3237
3238 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3239
3240         Reviewed by Jan Alonzo.
3241
3242         GtkLauncher is using a deprecated signal
3243         https://bugs.webkit.org/show_bug.cgi?id=30364
3244
3245         Modified GtkLauncher to use notify::title signal instead of
3246         deprecated title-changed signal
3247
3248         * GtkLauncher/main.c:
3249         (notify_title_cb):
3250         (create_browser):
3251
3252 2009-10-14  Brady Eidson  <beidson@apple.com>
3253
3254         Reviewed by Sam Weinig.
3255
3256         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3257         1 - Disables WebHistory
3258         2 - Doesn't make sense in that context anyway.
3259
3260         * DumpRenderTree/win/DumpRenderTree.cpp:
3261         (createWebViewAndOffscreenWindow):
3262
3263 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3264
3265         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3266         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3267
3268         * wx/build/settings.py:
3269         * wx/install-unix-extras:
3270
3271 2009-10-14  Brady Eidson  <beidson@apple.com>
3272
3273         Reviewed by Sam Weinig.
3274
3275         WebKit Win API should provide a delegate interface for global history.
3276         https://bugs.webkit.org/show_bug.cgi?id=29905
3277
3278         * DumpRenderTree/LayoutTestController.cpp:
3279         (LayoutTestController::LayoutTestController):
3280         * DumpRenderTree/LayoutTestController.h:
3281         (LayoutTestController::dumpHistoryDelegateCallbacks):
3282         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3283                 
3284         * DumpRenderTree/win/DumpRenderTree.cpp:
3285         (shouldLogHistoryDelegates):
3286         (runTest):
3287         (createWebViewAndOffscreenWindow):
3288         (main):
3289         * DumpRenderTree/win/DumpRenderTree.vcproj:
3290         
3291         Add the IWebHistoryDelegate to DRT Windows:
3292         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3293         (wstringFromBSTR):
3294         (HistoryDelegate::HistoryDelegate):
3295         (HistoryDelegate::~HistoryDelegate):
3296         (HistoryDelegate::QueryInterface):
3297         (HistoryDelegate::AddRef):
3298         (HistoryDelegate::Release):
3299         (HistoryDelegate::didNavigateWithNavigationData):
3300         (HistoryDelegate::didPerformClientRedirectFromURL):
3301         (HistoryDelegate::didPerformServerRedirectFromURL):
3302         (HistoryDelegate::updateHistoryTitle):
3303         (HistoryDelegate::populateVisitedLinksForWebView):
3304         * DumpRenderTree/win/HistoryDelegate.h: Added.
3305
3306         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3307         (LayoutTestController::removeAllVisitedLinks):
3308
3309 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3310
3311         Reviewed by Simon Hausmann.
3312
3313         [Qt] Implement support for setPOSIXLocale on Qt.
3314         https://bugs.webkit.org/show_bug.cgi?id=30268 
3315  
3316         * DumpRenderTree/qt/DumpRenderTree.cpp:
3317         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3318         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3319         (LayoutTestController::setPOSIXLocale):
3320         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3321
3322 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3323
3324         Unreviewed, adding myself to reviewers list.
3325
3326         * Scripts/modules/committers.py:
3327
3328 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3329
3330         Reviewed by Mark Rowe.
3331
3332         Fix null assignment so root tests work again.
3333
3334         * Scripts/webkitdirs.pm:
3335
3336 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3337
3338         Reviewed by Simon Hausmann.
3339
3340         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3341         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3342         This is done in preparation of implementing missing features in DRT.
3343         No functionality changes made yet.
3344
3345         * DumpRenderTree/qt/DumpRenderTree.cpp:
3346         * DumpRenderTree/qt/DumpRenderTree.pro:
3347         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3348         (EventSender::EventSender):
3349         (EventSender::mouseDown):
3350         (EventSender::mouseUp):
3351         (EventSender::mouseMoveTo):
3352         (EventSender::leapForward):
3353         (EventSender::keyDown):
3354         (EventSender::contextClick):
3355         (EventSender::scheduleAsynchronousClick):
3356         (EventSender::frameUnderMouse):
3357         * DumpRenderTree/qt/EventSenderQt.h: Added.
3358         (EventSender::clearKillRing):
3359         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3360         (LayoutTestController::LayoutTestController):
3361         (LayoutTestController::reset):
3362         (LayoutTestController::processWork):
3363         (LayoutTestController::maybeDump):
3364         (LayoutTestController::waitUntilDone):
3365         (LayoutTestController::notifyDone):
3366         (LayoutTestController::windowCount):
3367         (LayoutTestController::clearBackForwardList):
3368         (LayoutTestController::dumpEditingCallbacks):
3369         (LayoutTestController::dumpResourceLoadCallbacks):
3370         (LayoutTestController::queueBackNavigation):
3371         (LayoutTestController::queueForwardNavigation):
3372         (LayoutTestController::queueLoad):
3373         (LayoutTestController::queueReload):
3374         (LayoutTestController::queueScript):
3375         (LayoutTestController::provisionalLoad):
3376         (LayoutTestController::timerEvent):
3377         (LayoutTestController::encodeHostName):
3378         (LayoutTestController::decodeHostName):
3379         (LayoutTestController::setJavaScriptProfilingEnabled):
3380         (LayoutTestController::setFixedContentsSize):
3381         (LayoutTestController::setPrivateBrowsingEnabled):
3382         (LayoutTestController::setPopupBlockingEnabled):
3383         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3384         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3385         (LayoutTestController::numberOfActiveAnimations):
3386         (LayoutTestController::disableImageLoading):
3387         (LayoutTestController::dispatchPendingLoadRequests):
3388         (LayoutTestController::setDatabaseQuota):
3389         (LayoutTestController::clearAllDatabases):
3390         (LayoutTestController::whiteListAccessFromOrigin):
3391         (LayoutTestController::waitForPolicyDelegate):
3392         (LayoutTestController::overridePreference):
3393         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3394         (LayoutTestController::isLoading):
3395         (LayoutTestController::setLoading):
3396         (LayoutTestController::shouldDumpAsText):
3397         (LayoutTestController::shouldDumpBackForwardList):
3398         (LayoutTestController::shouldDumpChildrenAsText):
3399         (LayoutTestController::shouldDumpDatabaseCallbacks):
3400         (LayoutTestController::shouldDumpStatusCallbacks):
3401         (LayoutTestController::shouldWaitUntilDone):
3402         (LayoutTestController::canOpenWindows):
3403         (LayoutTestController::shouldDumpTitleChanges):
3404         (LayoutTestController::waitForPolicy):
3405         (LayoutTestController::dumpAsText):
3406         (LayoutTestController::dumpChildFramesAsText):
3407         (LayoutTestController::dumpDatabaseCallbacks):
3408         (LayoutTestController::dumpStatusCallbacks):
3409         (LayoutTestController::setCanOpenWindows):
3410         (LayoutTestController::dumpBackForwardList):
3411         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3412         (LayoutTestController::display):
3413         (LayoutTestController::dumpTitleChanges):
3414         (LayoutTestController::dumpSelectionRect):
3415         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3416         (TextInputController::TextInputController):
3417         (TextInputController::doCommand):
3418         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3419         * DumpRenderTree/qt/WorkQueue.cpp:
3420         * DumpRenderTree/qt/WorkQueue.h:
3421         * DumpRenderTree/qt/WorkQueueItem.h:
3422         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3423         (findFrameNamed):
3424         (LoadItem::invoke):
3425         (ReloadItem::invoke):
3426         (ScriptItem::invoke):
3427         (BackForwardItem::invoke):
3428         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3429         * DumpRenderTree/qt/jsobjects.h:
3430
3431 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3432
3433         Not reviewed, adding myself to the list of reviewers.
3434
3435         * Scripts/modules/committers.py:
3436
3437 2009-10-13  Anders Carlsson  <andersca@apple.com>
3438
3439         Reviewed by Sam Weinig.
3440
3441         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3442
3443         Make the private browsing mode testable by the test plug-in.
3444         
3445         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3446         (pluginGetProperty):
3447         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3448         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3449         (NPP_New):
3450         (NPP_SetValue):
3451
3452 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3453
3454         No review, just adding self to the list of reviewers.
3455
3456         * Scripts/modules/committers.py:
3457
3458 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3459
3460         Reviewed by Adam Roben.
3461
3462         Web Inspector: Use proper web view in inspector layout
3463         tests for windows.
3464
3465         https://bugs.webkit.org/show_bug.cgi?id=30298
3466
3467         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3468         (LayoutTestController::showWebInspector):
3469         (LayoutTestController::closeWebInspector):
3470         (LayoutTestController::evaluateInWebInspector):
3471
3472 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3473
3474         Reviewed by Sam Weinig.
3475
3476         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3477         https://bugs.webkit.org/show_bug.cgi?id=29841
3478
3479         * DumpRenderTree/mac/DumpRenderTree.mm:
3480         (resetDefaultsToConsistentValues):
3481         * DumpRenderTree/win/DumpRenderTree.cpp:
3482         (resetDefaultsToConsistentValues):
3483
3484 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3485
3486         Reviewed by Dimitri Glazkov.
3487
3488         Chromium Port - Windows
3489         https://bugs.webkit.org/show_bug.cgi?id=29969
3490
3491         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3492         * Scripts/webkitdirs.pm:
3493
3494 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3495
3496         Reviewed by Darin Adler.
3497
3498         jsc scripts cleanup and Qt/GTK fix
3499         https://bugs.webkit.org/show_bug.cgi?id=30288
3500
3501         Duplicated jscPath() moved to webkitdirs.pm.
3502         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3503         Configuration added (release/debug) to path for Qt-port on Windows.
3504
3505         * Scripts/run-javascriptcore-tests:
3506         * Scripts/run-jsc:
3507         * Scripts/run-sunspider:
3508         * Scripts/sunspider-compare-results:
3509         * Scripts/webkitdirs.pm:
3510
3511 2009-10-11  Adam Barth  <abarth@webkit.org>
3512
3513         Unreviewed.  Add Collin to committers.py.
3514
3515         * Scripts/modules/committers.py:
3516
3517 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3518
3519         wx build fix, add bindings to source/include dirs now that there are sources there.
3520
3521         * wx/build/settings.py:
3522
3523 2009-10-09  Mark Rowe  <mrowe@apple.com>
3524
3525         Reviewed by Brady Eidson.
3526
3527         Enable plug-in halting in DumpRenderTree.
3528
3529         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3530         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3531
3532         * DumpRenderTree/mac/DumpRenderTree.mm:
3533         (resetDefaultsToConsistentValues):
3534         * DumpRenderTree/mac/UIDelegate.mm:
3535         (-[UIDelegate webView:shouldHaltPlugin:]):
3536
3537 2009-10-08  Brady Eidson  <beidson@apple.com>
3538
3539         Reviewed by Dan Bernstein.
3540
3541         Ask the History Delegate to populate the visited links hash.
3542         <rdar://problem/7285293> and https://webkit.org/b/29904
3543
3544         Add the ability for LayoutTestController to clear all visited links.
3545         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3546
3547         * DumpRenderTree/LayoutTestController.cpp:
3548         (LayoutTestController::LayoutTestController):
3549         (removeAllVisitedLinksCallback):
3550         (LayoutTestController::staticFunctions):
3551         * DumpRenderTree/LayoutTestController.h:
3552         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3553         (LayoutTestController::removeAllVisitedLinks):
3554
3555         * DumpRenderTree/mac/HistoryDelegate.mm:
3556         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3557
3558         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3559         (LayoutTestController::removeAllVisitedLinks):
3560         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3561         (LayoutTestController::removeAllVisitedLinks):
3562         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3563         (LayoutTestController::removeAllVisitedLinks):
3564
3565
3566 2009-10-08  Daniel Bates  <dbates@webkit.org>
3567
3568         Reviewed by Adam Roben.
3569
3570         https://bugs.webkit.org/show_bug.cgi?id=30175
3571         
3572         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3573         the OLE drag-and-drop return value like the function it emulates. Currently, 
3574         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3575         whether the drag-and-drop operation was successful or was cancelled.
3576         
3577         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3578         return value according to whether the drop operation was successful or not.
3579
3580         * DumpRenderTree/win/EventSender.cpp:
3581         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3582         (replaySavedEvents): Ditto.
3583         * DumpRenderTree/win/EventSender.h:
3584         * DumpRenderTree/win/UIDelegate.cpp:
3585         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3586
3587 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3588
3589         Reviewed by Xan Lopez.
3590
3591         [GTK] Added support for a parameter setting the button that was
3592         pressed in the mouseDown function.
3593         https://bugs.webkit.org/show_bug.cgi?id=30220
3594
3595         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3596
3597 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3598
3599         Reviewed by Xan Lopez.
3600
3601         [GTK] Added a line to the bottom of the expected result to match
3602         the output of the test.
3603         https://bugs.webkit.org/show_bug.cgi?id=30220
3604
3605         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3606         expected.txt:
3607
3608 2009-10-08  Adam Roben  <aroben@apple.com>
3609
3610         Use QueryInterface to get IWebInspectorPrivate
3611
3612         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3613         accessed in a more standard way
3614
3615         Reviewed by John Sullivan and Tim Hatcher.
3616
3617         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3618         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3619         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3620         to the IWebInspectorPrivate interface.
3621
3622 2009-10-07  Adam Roben  <aroben@apple.com>
3623
3624         Implement DRT support for origin whitelisting
3625
3626         Fixes <http://webkit.org/b/30185>.
3627
3628         Reviewed by Eric Seidel.
3629
3630         * DumpRenderTree/win/DumpRenderTree.cpp:
3631         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3632         whitelist, to match Mac DRT.
3633         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3634         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3635         IWebViewPrivate::whiteListAccessFromOrigin.
3636
3637 2009-10-07  Brady Eidson  <beidson@apple.com>
3638
3639         Reviewed by Darin Adler.
3640
3641         Send title changes to the global history delegate.
3642         <rdar://problem/7285293> and https://webkit.org/b/29904
3643
3644         * DumpRenderTree/mac/HistoryDelegate.mm:
3645         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3646
3647 2009-10-07  Adam Barth  <abarth@webkit.org>
3648
3649         Unreviewed.  Remove some folks from committers.py who were listed on
3650         the WebKit Team wiki page but who weren't actually listed as commit+.
3651         At some point, we should coorelate this list with the committers
3652         mailing list.
3653
3654         * Scripts/modules/committers.py:
3655
3656 2009-10-07  Adam Barth  <abarth@webkit.org>
3657
3658         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3659         the wiki into committers.py.
3660
3661         * Scripts/modules/committers.py:
3662
3663 2009-10-07  Adam Barth  <abarth@webkit.org>
3664
3665         Unreviewed.  Added Aaron Boodman to committers.py.
3666
3667         * Scripts/modules/committers.py:
3668
3669 2009-10-07  Evan Martin  <evan@chromium.org>
3670
3671         Reviewed by Darin Adler.
3672
3673         Add API to LayoutTestController for re/setting the system locale.
3674         https://bugs.webkit.org/show_bug.cgi?id=18994
3675
3676         * DumpRenderTree/LayoutTestController.cpp:
3677         (setLocaleCallback):
3678         (LayoutTestController::staticFunctions):
3679         (LayoutTestController::setLocale):
3680         * DumpRenderTree/LayoutTestController.h:
3681
3682 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3683
3684         Reviewed by Jan Alonzo.
3685
3686         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts