2009-11-21 Eric Seidel <eric@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-21  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Adam Barth.
4
5         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
6         https://bugs.webkit.org/show_bug.cgi?id=31767
7
8         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
9         Since we don't have a good way to test BugzillaTool pieces, I've
10         left out a test for now.
11
12         * Scripts/bugzilla-tool:
13          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
14         * Scripts/modules/commands/queues.py:
15          - Use tool.path() instead of __file__.
16         * Scripts/modules/multicommandtool.py:
17          - Add a new path() method to MultiComandTool.
18         * Scripts/modules/multicommandtool_unittest.py:
19          - Provide a path() method.  Little point in testing this mock implementation.
20
21 2009-11-21  Adam Barth  <abarth@webkit.org>
22
23         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
24         WebKitTools.
25
26         * Scripts/modules/commands/download.py:
27
28 2009-11-21  Adam Barth  <abarth@webkit.org>
29
30         Reviewed by Eric Seidel.
31
32         Convert check-style to use LandingSequence
33         https://bugs.webkit.org/show_bug.cgi?id=31763
34
35         Instead of manipulating the working copy by hand, we should use the
36         LandingSequence in CheckStyle.  This will make this code eaiser to
37         test.
38
39         * Scripts/modules/commands/download.py:
40
41 2009-11-20  Adam Barth  <abarth@webkit.org>
42
43         Reviewed by Eric Seidel.
44
45         Unit test query commands
46         https://bugs.webkit.org/show_bug.cgi?id=31755
47
48         These tests are pretty rough, but hopefully they'll grow.
49
50         * Scripts/modules/commands/queries_unittest.py: Added.
51         * Scripts/modules/mock_bugzillatool.py: Added.
52         * Scripts/run-webkit-unittests:
53
54 2009-11-20  Eric Seidel  <eric@webkit.org>
55
56         Reviewed by Adam Barth.
57
58         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
59         https://bugs.webkit.org/show_bug.cgi?id=31758
60
61         * Scripts/modules/multicommandtool.py:
62          - Allow passing of explicit commands to MultiCommandTool.__init__
63         * Scripts/modules/multicommandtool_unittest.py:
64          - Use new Command.name naming system.
65          - Test Command auto-discovery.
66         * Scripts/modules/workqueue.py:
67          - bug_id no longer exists, use patch['bug_id'] instead.
68         * Scripts/modules/workqueue_unittest.py:
69          - WorkQueues require names now.
70          - should_proceed_with_work_item must return a patch object.
71
72 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
73
74         Reviewed by Beth Dakin.
75
76         WAI-ARIA: add support for aria-owns
77         https://bugs.webkit.org/show_bug.cgi?id=31702
78
79         * DumpRenderTree/AccessibilityUIElement.cpp:
80         (ariaOwnsElementAtIndexCallback):
81         (AccessibilityUIElement::getJSClass):
82         * DumpRenderTree/AccessibilityUIElement.h:
83         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
84         (AccessibilityUIElement::ariaOwnsElementAtIndex):
85         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
86         (AccessibilityUIElement::ariaOwnsElementAtIndex):
87         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
88         (AccessibilityUIElement::ariaOwnsElementAtIndex):
89
90 2009-11-20  Eric Seidel  <eric@webkit.org>
91
92         Reviewed by Adam Barth.
93
94         Fix exception thrown when running the commit-queue.
95
96         * Scripts/modules/statusbot.py: patch is optional.
97         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
98
99 2009-11-20  Eric Seidel  <eric@webkit.org>
100
101         Reviewed by Adam Barth.
102
103         Teach the StatusBot how to support more than just the commit-queue
104         https://bugs.webkit.org/show_bug.cgi?id=31754
105
106         * Scripts/modules/workqueue.py: Another typo.
107
108 2009-11-20  Eric Seidel  <eric@webkit.org>
109
110         Reviewed by Adam Barth.
111
112         Teach the StatusBot how to support more than just the commit-queue
113         https://bugs.webkit.org/show_bug.cgi?id=31754
114
115         * Scripts/modules/commands/queues.py: Fix silly typo.
116
117 2009-11-20  Eric Seidel  <eric@webkit.org>
118
119         Reviewed by Adam Barth.
120
121         Teach the StatusBot how to support more than just the commit-queue
122         https://bugs.webkit.org/show_bug.cgi?id=31754
123
124         * CommitQueueStatus/index.yaml:
125          - Add indices required for the new queries.
126         * CommitQueueStatus/queue_status.py:
127          - Add a patch-status page and move update_status to update-status.
128          - Only display "commit-queue" status records for the commit-queue.
129          - Add support for a queue_name property on status records.
130          - Fix _int_from_request to actually work.
131         * CommitQueueStatus/update_status.html:
132          - Add support for a queue_name on status records.
133          - Remove unused list of bug ids.
134          * Scripts/modules/commands/queues.py
135           - Make the queues pass the patch instead of the bug_id to StatusBot.
136         * Scripts/modules/statusbot.py:
137          - Support passing the queue_name to the status updates.
138          - Support fetching patch status with patch_status().
139         * Scripts/modules/workqueue.py:
140          - Pass the patch to the StatusBot instead of the bug_id.
141          - Let WorkQueues have a name.
142
143 2009-11-20  Adam Barth  <abarth@webkit.org>
144
145         Reviewed by Eric Seidel.
146
147         Move bugzilla-tool commands into their own file
148         https://bugs.webkit.org/show_bug.cgi?id=31752
149
150         This will let us write unit tests.
151
152         * Scripts/bugzilla-tool:
153         * Scripts/modules/commands/__init__.py: Added.
154         * Scripts/modules/commands/download.py: Added.
155         * Scripts/modules/commands/queries.py: Added.
156         * Scripts/modules/commands/queues.py: Added.
157         * Scripts/modules/commands/upload.py: Added.
158         * Scripts/modules/grammar.py: Added.
159
160 2009-11-20  Adam Barth  <abarth@webkit.org>
161
162         Reviewed by Eric Seidel.
163
164         BuildQueue should check if the tree is currently buildable
165         https://bugs.webkit.org/show_bug.cgi?id=31744
166
167         * Scripts/bugzilla-tool:
168         * Scripts/modules/landingsequence.py:
169         * Scripts/modules/webkitlandingscripts.py:
170
171 2009-11-20  Adam Barth  <abarth@webkit.org>
172
173         Reviewed by Eric Seidel.
174
175         Move prepare_clean_working_directory into the LandingSequence
176         https://bugs.webkit.org/show_bug.cgi?id=31743
177
178         * Scripts/bugzilla-tool:
179         * Scripts/modules/landingsequence.py:
180
181 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
182
183         Reviewed by Kenneth Rohde Christiansen.
184
185         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
186         https://bugs.webkit.org/show_bug.cgi?id=30460
187
188         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
189
190         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
191         (pluginInvoke):
192
193 2009-11-20  Adam Barth  <abarth@webkit.org>
194
195         Reviewed by Eric Seidel.
196
197         Pass the port information to the child process
198         https://bugs.webkit.org/show_bug.cgi?id=31736
199
200         We need to do this so the child process knows what to build!
201
202         * Scripts/bugzilla-tool:
203         * Scripts/modules/landingsequence.py:
204         * Scripts/modules/webkitport.py:
205         * Scripts/modules/webkitport_unittest.py:
206
207 2009-11-20  Adam Barth  <abarth@webkit.org>
208
209         Reviewed by Eric Seidel.
210
211         Support Qt port in build-queue
212         https://bugs.webkit.org/show_bug.cgi?id=31733
213
214         * Scripts/bugzilla-tool:
215
216 2009-11-20  Adam Barth  <abarth@webkit.org>
217
218         Reviewed by Eric Seidel.
219
220         Implement a build-queue
221         https://bugs.webkit.org/show_bug.cgi?id=31725
222
223         Currently this just builds the first 10 patches in the review queue.
224         We'll want to do something smarter soon.
225
226         * Scripts/bugzilla-tool:
227
228 2009-11-20  Adam Barth  <abarth@webkit.org>
229
230         Reviewed by Eric Seidel.
231
232         Make commit-queue and style-queue show up in help
233         https://bugs.webkit.org/show_bug.cgi?id=31724
234
235         We need to store their names on their class to make these commands
236         properly register themselves with MultiCommandTool.
237
238         * Scripts/bugzilla-tool:
239
240 2009-11-20  Adam Barth  <abarth@webkit.org>
241
242         Reviewed by Eric Seidel.
243
244         Implement bugzilla-tool build-attachment
245         https://bugs.webkit.org/show_bug.cgi?id=31722
246
247         This command builds an attachment from bugzilla.  It leaves the built
248         patch in the working copy.
249
250         * Scripts/bugzilla-tool:
251         * Scripts/modules/landingsequence.py:
252         * Scripts/modules/webkitlandingscripts.py:
253
254 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
255
256         Reviewed by Xan Lopez.
257
258         [GTK] DRT release event does not create the state correctly
259         https://bugs.webkit.org/show_bug.cgi?id=31717
260
261         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
262
263 2009-11-20  Eric Seidel  <eric@webkit.org>
264
265         Reviewed by Adam Barth.
266
267         MultiCommandTool should find Command objects automatically instead of with a manual list
268         https://bugs.webkit.org/show_bug.cgi?id=31710
269
270         * Scripts/bugzilla-tool:
271         * Scripts/modules/multicommandtool.py:
272          - Use some wild python-fu to crawl all the known subclasses of Command.
273
274 2009-11-20  Adam Barth  <abarth@webkit.org>
275
276         Unreviewed "build" fix.  Added missing import.
277
278         * Scripts/bugzilla-tool:
279
280 2009-11-20  Adam Barth  <abarth@webkit.org>
281
282         Unreviewed "build" fix.  I failed to update LandingSequence.test
283         properly.
284
285         * Scripts/modules/landingsequence.py:
286
287 2009-11-20  Adam Barth  <abarth@webkit.org>
288
289         Reviewed by Eric Seidel.
290
291         Create LandingSequence as the all-sing, all-dance landing class
292         https://bugs.webkit.org/show_bug.cgi?id=31709
293
294         Client can inherit from this class to carefully control exactly which
295         steps they wish to have happen in the landing sequence.
296
297         * Scripts/bugzilla-tool:
298         * Scripts/modules/landingsequence.py: Added.
299         * Scripts/modules/webkitlandingscripts.py: Added.
300
301 2009-11-19  Adam Barth  <abarth@webkit.org>
302
303         Reviewed by Eric Seidel.
304
305         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
306         https://bugs.webkit.org/show_bug.cgi?id=31707
307
308         This is to help when we implement build-attachment.
309
310         * Scripts/bugzilla-tool:
311
312 2009-11-19  Adam Barth  <abarth@webkit.org>
313
314         Reviewed by Eric Seidel.
315
316         Support Qt port in bugzilla-tool
317         https://bugs.webkit.org/show_bug.cgi?id=31701
318
319         Now we support building with Qt!
320
321         * Scripts/bugzilla-tool:
322         * Scripts/modules/webkitport.py: Added.
323         * Scripts/modules/webkitport_unittest.py: Added.
324         * Scripts/run-webkit-unittests:
325
326 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
327
328         Reviewed by Adam Barth.
329
330         Remove inserting stderr into patch in bugzilla-tool
331         https://bugs.webkit.org/show_bug.cgi?id=29914
332
333         Modify SCM python module's run_command function to avoid return of stderr
334         by default, so stderr won't be inserted into the patches.
335         Modify the related unit test.
336
337         * Scripts/modules/scm.py:
338         * Scripts/modules/scm_unittest.py:
339
340 2009-11-19  Eric Seidel  <eric@webkit.org>
341
342         Reviewed by Adam Barth.
343
344         bugzilla-tool needs per-command help
345         https://bugs.webkit.org/show_bug.cgi?id=31697
346
347         Added support for "bugzilla-tool help command-name"
348         and a unit test to make sure it works.
349
350         * Scripts/modules/multicommandtool.py:
351         * Scripts/modules/multicommandtool_unittest.py:
352
353 2009-11-19  Eric Seidel  <eric@webkit.org>
354
355         Reviewed by Adam Barth.
356
357         Move MultiCommandTool and Command into a separate file and add some basic unit tests
358         https://bugs.webkit.org/show_bug.cgi?id=31695
359
360         * Scripts/bugzilla-tool:
361         * Scripts/modules/multicommandtool.py: Added.
362         * Scripts/modules/multicommandtool_unittest.py: Added.
363         * Scripts/run-webkit-unittests:
364
365 2009-11-19  Eric Seidel  <eric@webkit.org>
366
367         No review, just adding a FIXME.
368
369         Split out command parsing and help printing from BugzillaTool
370         https://bugs.webkit.org/show_bug.cgi?id=31688
371
372         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
373
374 2009-11-19  Eric Seidel  <eric@webkit.org>
375
376         Reviewed by Adam Barth.
377
378         Split out command parsing and help printing from BugzillaTool
379         https://bugs.webkit.org/show_bug.cgi?id=31688
380
381         * Scripts/bugzilla-tool:
382          - Add new MultiCommandTool class to contain option parsing and help printing logic.
383          - Rename private methods to use _ pattern.
384          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
385          - 
386
387 2009-11-19  Eric Seidel  <eric@webkit.org>
388
389         Reviewed by Adam Barth.
390
391         Re-factor help printing to use modern python idioms
392         https://bugs.webkit.org/show_bug.cgi?id=31685
393
394         * Scripts/bugzilla-tool:
395
396 2009-11-19  Eric Seidel  <eric@webkit.org>
397
398         Reviewed by Darin Adler.
399
400         commit-queue empty queue logs twice
401         https://bugs.webkit.org/show_bug.cgi?id=31679
402
403         * Scripts/bugzilla-tool:
404
405 2009-11-19  Eric Seidel  <eric@webkit.org>
406
407         Reviewed by Darin Adler.
408
409         bugzilla-tool's reviewer/committer rejection message should be clearer
410         https://bugs.webkit.org/show_bug.cgi?id=31126
411
412         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
413
414         * Scripts/modules/bugzilla.py:
415
416 2009-11-19  Eric Z. Ayers  <zundel@google.com>
417
418         Reviewed by Pavel Feldman.
419
420         Forces a WM_PAINT event on calling layoutTestController.display()
421         in order to enable the timeline-paint.html test on Windows.
422         ::UpdateWindow() does not force an event becaue the window is 
423         not visible.
424
425         https://bugs.webkit.org/show_bug.cgi?id=31402
426
427         * DumpRenderTree/win/DumpRenderTree.cpp:
428         (displayWebView):
429
430 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
431
432         No review needed.
433
434         Added myself to committers list.
435
436         * Scripts/modules/committers.py:
437
438 2009-11-19  Adam Barth  <abarth@webkit.org>
439
440         Reviewed by Eric Seidel.
441
442         Bugzilla-tool command classes should match command names
443         https://bugs.webkit.org/show_bug.cgi?id=31666
444
445         I renamed all the commands except CommitMessageForCurrentDiff because
446         the new name would conflict with an existing class.
447
448         * Scripts/bugzilla-tool:
449
450 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
451
452         Reviewed by Gustavo Noronha Silva.
453
454         Web Inspector: Implement "show inspector" in WebKit GTK
455         API and enable console tests.
456
457         https://bugs.webkit.org/show_bug.cgi?id=31669
458
459         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
460         (LayoutTestController::showWebInspector):
461
462 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
463
464         Reviewed by Simon Hausmann.
465
466         Minor refactoring + more documentation.
467
468         * DumpRenderTree/qt/DumpRenderTree.cpp:
469         (WebCore::clearHistory):
470         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
471
472 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
473
474         Reviewed by Eric Seidel.
475
476         Ignore websocket tests when --no-http is specified.
477         https://bugs.webkit.org/show_bug.cgi?id=31662
478
479         * Scripts/run-webkit-tests:
480
481 2009-11-18  Adam Barth  <abarth@webkit.org>
482
483         Reviewed by Eric Seidel.
484
485         Normalize ' and " in bugzilla-tool
486         https://bugs.webkit.org/show_bug.cgi?id=31655
487
488         We decided " is better than ' and we should be consistent.
489
490         * Scripts/bugzilla-tool:
491
492 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
493
494         Reviewed by Kenneth Rohde Christiansen.
495
496         [Qt] Remove support for Qt v4.3 or older versions
497         https://bugs.webkit.org/show_bug.cgi?id=29469
498
499         * DumpRenderTree/qt/DumpRenderTree.pro:
500         * DumpRenderTree/qt/ImageDiff.pro:
501
502 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
503
504         Reviewed by Eric Seidel.
505
506         GitTest.test_create_binary_patch fails if /tmp is symlink
507         https://bugs.webkit.org/show_bug.cgi?id=31536
508
509         * Scripts/modules/scm_unittest.py:
510
511 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
512
513         Reviewed by Darin Adler.
514
515         Configuration for Chromium Build Slaves.
516
517         https://bugs.webkit.org/show_bug.cgi?id=31442
518
519         * BuildSlaveSupport/build.webkit.org-config/config.json:
520         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
521
522 2009-11-18  Eric Seidel  <eric@webkit.org>
523
524         Reviewed by Darin Adler.
525
526         workqueue.py results in totally broken commit-queue UI
527         https://bugs.webkit.org/show_bug.cgi?id=31645
528
529         * Scripts/bugzilla-tool:
530          - Remove unneeded use of PatchCollection.
531          - Grab a new copy of the cq'd patches every run of the queue.
532
533 2009-11-18  Sam Weinig  <sam@webkit.org>
534
535         Reviewed by Anders Carlsson.
536
537         Make the Mac Geolocation API async.
538
539         Update DRT to use the new async Mac Geolocation API.
540
541         * DumpRenderTree/mac/UIDelegate.mm:
542         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
543
544 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
545
546         Reviewed by Kenneth Rohde Christiansen.
547
548         Add and option to toggle HTML5 datalist support to build-webkit
549         https://bugs.webkit.org/show_bug.cgi?id=31599
550
551         * Scripts/build-webkit:
552
553 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
554
555         Reviewed by Kevin Ollivier.
556
557         Enable wx plugin support using the Windows implementation as a base.
558         
559         https://bugs.webkit.org/show_bug.cgi?id=31636
560
561         * wx/build/settings.py:
562
563 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
564
565         Reviewed by Simon Hausmann.
566
567         Change the initialization order so that the controllers
568         will be created before exporting them to the JS DOM window.
569
570         * DumpRenderTree/qt/DumpRenderTree.cpp:
571         (WebCore::DumpRenderTree::DumpRenderTree):
572
573 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
574
575         Reviewed by Simon Hausmann.
576
577         Fix a code copy and paste error. m_page should be page.
578
579         * DumpRenderTree/qt/DumpRenderTree.cpp:
580         (WebCore::DumpRenderTree::createWindow):
581
582 2009-11-17  Mark Rowe  <mrowe@apple.com>
583
584         Reviewed by Alexey Proskuryakov.
585
586         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
587
588         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
589         This prevents symlinks from confusing the descendant check.
590
591 2009-11-17  Mark Rowe  <mrowe@apple.com>
592
593         Reviewed by Alexey Proskuryakov.
594
595         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
596
597         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
598         server to be up rather than having run-webkit-tests abort immediately.
599
600         * Scripts/run-webkit-tests:
601
602 2009-11-17  Eric Seidel  <eric@webkit.org>
603
604         Reviewed by Darin Adler.
605
606         commit-queue is failing to set reviewer in ChangeLogs
607         https://bugs.webkit.org/show_bug.cgi?id=31592
608
609         * Scripts/bugzilla-tool: Clarify the "applying" log message.
610         * Scripts/modules/bugzilla.py:
611          - Add a new _validate_committer_and_reviewer function as a
612            temporary solution until we can make a real Attachment object
613            which knows how to fill in its committer/reviewer fields automatically.
614
615 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
616
617         Unreviewed buildbot fix.
618
619         Revert part of earlier patch and add comment, as it
620         was causing timeouts on the buildbot.
621
622         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
623         (LayoutTestController::notifyDone):
624
625 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
626
627         Reviewed by Oliver Hunt.
628
629         Make the timeout 15 sec as for the other DRT's and make
630         it print out the same output when a test timeout.
631
632         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
633         (LayoutTestController::waitUntilDone):
634         (LayoutTestController::notifyDone):
635         (LayoutTestController::timerEvent):
636
637 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
638
639         Reviewed by Timothy Hatcher.
640
641         Fixed typos in comments.
642
643         * Scripts/modules/committers.py:
644
645 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
646
647         Reviewed by Timothy Hatcher.
648
649         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
650         - Updated DRT to show/close inspector for all tests under /inspector
651         - Introduced LayoutTestController::setTimelineProfilingEnabled and
652           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
653         - Removed reload on each inspector test
654         - Renamed fast/inspector to fast/inspector-support in order not to trigger
655         inspector for those.
656         - Reimplemented timeline tests in order to get rid of reload there.
657         - Moved tests that don't require harness into the fast group.
658
659         https://bugs.webkit.org/show_bug.cgi?id=31472
660
661         * DumpRenderTree/LayoutTestController.cpp:
662         (setTimelineProfilingEnabledCallback):
663         (closeWebInspectorCallback):
664         (LayoutTestController::staticFunctions):
665         * DumpRenderTree/LayoutTestController.h:
666         * DumpRenderTree/gtk/DumpRenderTree.cpp:
667         (shouldOpenWebInspector):
668         (runTest):
669         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
670         (LayoutTestController::setTimelineProfilingEnabled):
671         * DumpRenderTree/mac/DumpRenderTree.mm:
672         (shouldOpenWebInspector):
673         (runTest):
674         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
675         (LayoutTestController::setTimelineProfilingEnabled):
676         * DumpRenderTree/win/DumpRenderTree.cpp:
677         (shouldOpenWebInspector):
678         (runTest):
679         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
680         (LayoutTestController::setTimelineProfilingEnabled):
681
682 2009-11-17  Oliver Hunt  <oliver@apple.com>
683
684         Reviewed by Maciej Stachowiak.
685
686         Incorrect use of JavaScriptCore API in DumpRenderTree
687         https://bugs.webkit.org/show_bug.cgi?id=31577
688
689         Return undefined rather than a literal null.
690
691         * DumpRenderTree/AccessibilityUIElement.cpp:
692         (setSelectedTextRangeCallback):
693         (incrementCallback):
694         (decrementCallback):
695         (showMenuCallback):
696
697 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
698
699         Reviewed by Beth Dakin.
700
701         AX: aria-labelledby duplicates some of its WAI-ARIA label
702         https://bugs.webkit.org/show_bug.cgi?id=31565
703
704         * DumpRenderTree/AccessibilityUIElement.cpp:
705         (titleUIElementCallback):
706         (getIsValidCallback):
707         (AccessibilityUIElement::getJSClass):
708
709 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
710
711         Reviewed by Simon Hausmann.
712
713         r50942 broke output from created windows. Make the
714         m_enableTextOutput a member of the DRT and not the
715         WebPage.
716
717         * DumpRenderTree/qt/DumpRenderTree.cpp:
718         (WebCore::WebPage::WebPage):
719         (WebCore::WebPage::javaScriptAlert):
720         (WebCore::WebPage::javaScriptConsoleMessage):
721         (WebCore::WebPage::javaScriptConfirm):
722         (WebCore::WebPage::javaScriptPrompt):
723         (WebCore::WebPage::acceptNavigationRequest):
724         (WebCore::DumpRenderTree::DumpRenderTree):
725         (WebCore::DumpRenderTree::open):
726         (WebCore::DumpRenderTree::createWindow):
727         * DumpRenderTree/qt/DumpRenderTree.h:
728         (WebCore::DumpRenderTree::setTextOutputEnabled):
729         (WebCore::DumpRenderTree::isTextOutputEnabled):
730         (WebCore::WebPage::shouldInterruptJavaScript):
731         (WebCore::WebPage::isTextOutputEnabled):
732         (WebCore::WebPage::setViewGeometry):
733
734 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
735
736         Reviewed by Gustavo Noronha Silva.
737
738         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
739         as the implementation is being used by at least Qt and Gtk+.
740
741         Update buildsystems as well.
742
743         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
744         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
745         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
746         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
747         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
748         * GNUmakefile.am:
749
750 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
751
752         Reviewed by Alexey Proskuryakov.
753
754         Disable wss until all platforms support pyOpenSSL
755
756         https://bugs.webkit.org/show_bug.cgi?id=31479
757
758         * Scripts/run-webkit-tests:
759
760 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
761
762         Reviewed by Kenneth Christiansen.
763
764         [Qt] Implement load error pages support for Qt's DRT.
765         https://bugs.webkit.org/show_bug.cgi?id=31509
766
767         For now, it will not be a default feature, and layout tests
768         that want to make use of this have to explicitily call
769         'handleErrorPages();' for the test source.
770
771         Any of the other DumpRenderTree's (mac, win and gtk)
772         support handling error pages. Qt's will be the first.
773
774         * DumpRenderTree/qt/DumpRenderTree.cpp:
775         (WebCore::WebPage::supportsExtension):
776         (WebCore::WebPage::extension):
777         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
778         (LayoutTestController::reset):
779         * DumpRenderTree/qt/LayoutTestControllerQt.h:
780         (LayoutTestController::shouldHandleErrorPages):
781         (LayoutTestController::handleErrorPages):
782
783 2009-11-16  Eric Seidel  <eric@webkit.org>
784
785         Reviewed by Adam Barth.
786
787         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
788         https://bugs.webkit.org/show_bug.cgi?id=31549
789
790         Renamed --commit-queue to --non-interactive in most places
791         and remove the code in land-patches which is no longer needed.
792
793         * Scripts/bugzilla-tool:
794
795 2009-11-16  Eric Seidel  <eric@webkit.org>
796
797         Reviewed by Adam Barth.
798
799         The commit-queue should use land-attachment
800         https://bugs.webkit.org/show_bug.cgi?id=31548
801
802         * Scripts/bugzilla-tool:
803
804 2009-11-16  Adam Barth  <abarth@webkit.org>
805
806         Reviewed by Eric Seidel.
807
808         Convert CommitQueue over to PatchCollection
809         https://bugs.webkit.org/show_bug.cgi?id=31547
810
811         Also fixes a bug in workqueue and adds a test!
812
813         * Scripts/bugzilla-tool:
814         * Scripts/modules/workqueue.py:
815         * Scripts/modules/workqueue_unittest.py:
816
817 2009-11-16  Adam Barth  <abarth@webkit.org>
818
819         Reviewed by Eric Seidel.
820
821         Move StyleQueue over to using PatchCollection
822         https://bugs.webkit.org/show_bug.cgi?id=31544
823
824         That's what the class it's for.
825
826         * Scripts/bugzilla-tool:
827         * Scripts/modules/patchcollection.py:
828         * Scripts/modules/patchcollection_unittest.py:
829
830 2009-11-16  Eric Seidel  <eric@webkit.org>
831
832         Reviewed by Adam Barth.
833
834         bugzilla-tool needs a land-attachment command
835         https://bugs.webkit.org/show_bug.cgi?id=31546
836
837         * Scripts/bugzilla-tool:
838          - Move all the logic into AbstractLandingCommand and
839            add a new LandAttachment command subclass.
840          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
841
842 2009-11-16  Eric Seidel  <eric@webkit.org>
843
844         Reviewed by Adam Barth.
845
846         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
847         https://bugs.webkit.org/show_bug.cgi?id=31543
848
849         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
850
851         * Scripts/bugzilla-tool:
852
853 2009-11-16  Eric Seidel  <eric@webkit.org>
854
855         Reviewed by Adam Barth.
856
857         Disable the style queue from posting to the commit queue status page.
858
859         * Scripts/bugzilla-tool:
860
861 2009-11-16  Adam Barth  <abarth@webkit.org>
862
863         Reviewed by Eric Seidel.
864
865         Implement PatchCollection
866         https://bugs.webkit.org/show_bug.cgi?id=31541
867
868         This class holds a set of patches and lets clients iterate through
869         them.  Optionally, clients can install a filter.
870
871         * Scripts/modules/patchcollection.py: Added.
872         * Scripts/modules/patchcollection_unittest.py: Added.
873         * Scripts/run-webkit-unittests:
874
875 2009-11-16  Eric Seidel  <eric@webkit.org>
876
877         Reviewed by Adam Barth.
878
879         bugzilla-tool land-patches will close bugs with patches r=?
880         https://bugs.webkit.org/show_bug.cgi?id=28230
881
882         The commit-queue shouldn't close patches with outstanding reviews on them,
883         even if many reviewers seem to be against multi-patch bugs.
884
885         * Scripts/bugzilla-tool:
886
887 2009-11-16  Eric Seidel  <eric@webkit.org>
888
889         Reviewed by Adam Barth.
890
891         bugzilla-tool check-style should work with attachment ids instead of bug ids
892         https://bugs.webkit.org/show_bug.cgi?id=31540
893
894         * Scripts/bugzilla-tool:
895
896 2009-11-16  Eric Seidel  <eric@webkit.org>
897
898         Reviewed by Adam Barth.
899
900         WorkQueue is the only place that should know about special exit codes
901         https://bugs.webkit.org/show_bug.cgi?id=31534
902
903         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
904         and add tests for handling exit codes.
905         I also cleaned up workqueue_unittest.py more.
906
907         * Scripts/bugzilla-tool:
908         * Scripts/modules/workqueue.py:
909         * Scripts/modules/workqueue_unittest.py:
910
911 2009-11-16  Eric Seidel  <eric@webkit.org>
912
913         Reviewed by Adam Barth.
914
915         Re-factor workqueue_unittest to allow for more than one test.
916         https://bugs.webkit.org/show_bug.cgi?id=31535
917
918         * Scripts/modules/workqueue_unittest.py:
919
920 2009-11-16  Eric Seidel  <eric@webkit.org>
921
922         Reviewed by Adam Barth.
923
924         land-patches needs to be re-factored into smaller chunks
925         https://bugs.webkit.org/show_bug.cgi?id=31532
926
927         * Scripts/bugzilla-tool: fix a couple obvious typos.
928
929 2009-11-16  Eric Seidel  <eric@webkit.org>
930
931         Reviewed by Adam Barth.
932
933         land-patches needs to be re-factored into smaller chunks
934         https://bugs.webkit.org/show_bug.cgi?id=31532
935
936         The next patch will move these methods into WebKitLandingScripts.
937
938         * Scripts/bugzilla-tool:
939          - Split out _land_patch and _close_bug_if_no_active_patches.
940
941 2009-11-16  Adam Barth  <abarth@webkit.org>
942
943         Reviewed by Eric Seidel.
944
945         Fix silly copy-and-paste code.  I am a terrible coder.
946
947         * Scripts/modules/bugzilla.py:
948
949 2009-11-16  Adam Barth  <abarth@webkit.org>
950
951         Reviewed by Eric Seidel.
952
953         Implement a StyleQueue
954         https://bugs.webkit.org/show_bug.cgi?id=31537
955
956         The first iteration of the style queue only produces output locally.
957         There is also a limit of 10 patches because it's not that useful to
958         iterate through the entire review queue at this point.  We can remove
959         the limit later.
960
961         * Scripts/bugzilla-tool:
962         * Scripts/modules/bugzilla.py:
963
964 2009-11-16  Adam Barth  <abarth@webkit.org>
965
966         Reviewed by Eric Seidel.
967
968         Unit test WorkQueue
969         https://bugs.webkit.org/show_bug.cgi?id=31531
970
971         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
972
973         * Scripts/bugzilla-tool:
974         * Scripts/modules/statusbot.py:
975         * Scripts/modules/workqueue.py:
976         * Scripts/modules/workqueue_unittest.py: Added.
977         * Scripts/run-webkit-unittests:
978
979 2009-11-16  Eric Seidel  <eric@webkit.org>
980
981         Reviewed by Adam Barth.
982
983         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
984         https://bugs.webkit.org/show_bug.cgi?id=31530
985
986         * Scripts/bugzilla-tool:
987
988 2009-11-16  Eric Seidel  <eric@webkit.org>
989
990         Reviewed by Adam Barth.
991
992         bugzilla-tool needs apply-attachment
993         https://bugs.webkit.org/show_bug.cgi?id=31528
994
995         * Scripts/bugzilla-tool:
996          - Add ApplyAttachment command.
997          - Abstract applying code into WebKitApplyingScripts.
998          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
999         * Scripts/modules/bugzilla.py:
1000          - Add fetch_attachment and bug_id_for_attachment_id.
1001         * Scripts/modules/bugzilla_unittest.py:
1002          - Add test for new parsing.
1003          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1004
1005 2009-11-16  Eric Seidel  <eric@webkit.org>
1006
1007         Reviewed by Adam Barth.
1008
1009         Document check-style's use of force_clean.
1010
1011         * Scripts/bugzilla-tool:
1012         * Scripts/modules/scm.py:
1013
1014 2009-11-16  Adam Barth  <abarth@webkit.org>
1015
1016         Reviewed by Eric Seidel.
1017
1018         Move WorkQueue to its own file
1019         https://bugs.webkit.org/show_bug.cgi?id=31529
1020
1021         WorkQueue and WorkQueueDelegate are separate concerns from
1022         bugzilla-tool.  Also added a missing include to logging.py.
1023
1024         * Scripts/bugzilla-tool:
1025         * Scripts/modules/logging.py:
1026         * Scripts/modules/workqueue.py:
1027
1028 2009-11-16  Adam Barth  <abarth@webkit.org>
1029
1030         Reviewed by Eric Seidel.
1031
1032         Move OutputTee to logging.py.
1033
1034         * Scripts/bugzilla-tool:
1035         * Scripts/modules/logging.py:
1036
1037 2009-11-15  Adam Barth  <abarth@webkit.org>
1038
1039         Reviewed by Eric Seidel.
1040
1041         Refactor bugzilla-tool to allow for multiple queues
1042         https://bugs.webkit.org/show_bug.cgi?id=31513
1043
1044         Divide the commit queue class into three class to make creating
1045         additional queues easier.
1046
1047         * Scripts/bugzilla-tool:
1048
1049 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1050
1051         Reviewed by Eric Seidel.
1052
1053         svn-apply may not handle git patches created by bugzilla-tool
1054         https://bugs.webkit.org/show_bug.cgi?id=31457
1055
1056         * Scripts/modules/scm.py:
1057         * Scripts/modules/scm_unittest.py:
1058
1059 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1060
1061         Reviewed by Eric Seidel.
1062
1063         bugzilla-tool should post git binary diff
1064         https://bugs.webkit.org/show_bug.cgi?id=31458
1065
1066         Add --binary option to Git.create_patch.
1067
1068         * Scripts/modules/scm.py:
1069         * Scripts/modules/scm_unittest.py:
1070
1071 2009-11-15  Adam Barth  <abarth@webkit.org>
1072
1073         Reviewed by Darin Adler.
1074
1075         Add bugzilla-tool check-style
1076         https://bugs.webkit.org/show_bug.cgi?id=31515
1077
1078         * Scripts/bugzilla-tool:
1079         * Scripts/modules/bugzilla.py:
1080
1081 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1082
1083         Reviewed by Simon Hausmann.
1084
1085         Make the Qt Linux only --valgrind feature, suppress errors
1086         defined in the SuppressedValgrindErrors file.
1087
1088         * Scripts/run-webkit-tests:
1089
1090 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1091
1092         Reviewed by Simon Hausmann.
1093
1094         Set the locale to C and not to the current one in use on the system.
1095
1096         * DumpRenderTree/qt/DumpRenderTree.cpp:
1097         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1098
1099 2009-11-13  Adam Roben  <aroben@apple.com>
1100
1101         Add support for
1102         http/tests/security/isolatedWorld/didClearWindowObject.html
1103
1104         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1105         window objects in isolated worlds are cleared
1106
1107         Reviewed by Dave Hyatt.
1108
1109         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1110
1111         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1112         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1113         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1114         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1115         Added. Sets a __worldID property on the global object whose value is
1116         the ID of this world.
1117         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1118         Respond to this new delegate callback by calling through to one of the
1119         above new methods.
1120         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1121         (worldMap): Added. Returns a HashMap containing all the worlds we've
1122         created.
1123         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1124         haven't kept track of this world.
1125         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1126         instead of declaring our own.
1127
1128         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1129
1130         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1131         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1132         didClearWindowObjectForFrameInStandardWorld.
1133         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1134         Respond to this new delegate callback by calling through to one of the
1135         below new methods.
1136         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1137         Added. Sets a __worldID property on the gobal object whose value is
1138         the ID of this world.
1139         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1140         Added. Moved code here from didClearWindowObject.
1141
1142         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1143         didClearWindowObjectForFrame* functions.
1144
1145         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1146         (worldMap): Added. Returns a HashMap containing all the worlds we've
1147         created.
1148         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1149         haven't kept track of this world.
1150         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1151         instead of declaring our own.
1152
1153 2009-11-13  Adam Roben  <aroben@apple.com>
1154
1155         Finish replacing worldIDs with world objects
1156
1157         The only remaining use of worldIDs was in a method only used by DRT
1158         for the isolated worlds tests.
1159
1160         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1161
1162         Reviewed by Mark Rowe.
1163
1164         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1165         (LayoutTestController::evaluateScriptInIsolatedWorld):
1166         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1167         (LayoutTestController::evaluateScriptInIsolatedWorld):
1168         Updated for changes to WebFrame. Now holds the map of worldID -> world
1169         at this level instead of making WebKit do it.
1170
1171 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1172
1173         Reviewed by Simon Hausmann.
1174
1175         [Qt] Ensure the DRT does not output anything until first test is run
1176
1177         * DumpRenderTree/qt/DumpRenderTree.cpp:
1178         * DumpRenderTree/qt/DumpRenderTree.h:
1179
1180 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1181
1182         Reviewed by Tor Arne Vestbø.
1183
1184         Clear the undo stack in before each new test run.
1185
1186         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1187
1188         * DumpRenderTree/qt/DumpRenderTree.cpp:
1189         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1190
1191 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1192
1193         Reviewed by Kenneth Rohde Christiansen.
1194
1195         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1196
1197         * DumpRenderTree/qt/DumpRenderTree.cpp:
1198         (WebCore::WebPage::resetSettings):
1199         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1200         (LayoutTestController::overridePreference):
1201
1202 2009-11-13  Eric Seidel  <eric@webkit.org>
1203
1204         Reviewed by Adam Barth.
1205
1206         Update committers.py based on svn records
1207         https://bugs.webkit.org/show_bug.cgi?id=31366
1208
1209         This list was generated using validate-committer-lists from
1210         https://bugs.webkit.org/show_bug.cgi?id=30970
1211         and makes committers.py current for committers who have
1212         committed in the last 3 years.
1213
1214         * Scripts/modules/committers.py:
1215
1216 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1217
1218         Reviewed by Adam Barth.
1219
1220         The document-open.html test was flaky at times. The test invokes the layout test plugin
1221         which in its destroy stream handler opens a new document. This basically tears down the
1222         stream and the associated plugin instance. The pluginLog function in the layout test
1223         plugin attempts to retrieve the window script object on a torn down plugin instance
1224         which crashed consistently on windows in the debugger. The functions which issue
1225         these logs already have a valid window script object. We now have variants of the pluginLog
1226         function which take in a window script object with and without variable arguments. 
1227
1228         https://bugs.webkit.org/show_bug.cgi?id=31067
1229
1230         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1231         (pluginLogWithWindowObject):
1232         (pluginLogWithWindowObjectVariableArgs):
1233         (pluginLog):
1234         (notifyTestCompletion):
1235         (testDocumentOpen):
1236         (testWindowOpen):
1237
1238 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1239
1240         Reviewed by Gustavo Noronha Silva.
1241
1242         https://bugs.webkit.org/show_bug.cgi?id=30997
1243         [Gtk] Implemment AtkDocument
1244
1245         Added testing support.
1246
1247         * DumpRenderTree/AccessibilityUIElement.cpp:
1248         * DumpRenderTree/AccessibilityUIElement.h:
1249         (getDocumentEncodingCallback):
1250         (getDocumentURICallback):
1251         (AccessibilityUIElement::getJSClass):
1252         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1253         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1254         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1255         (AccessibilityUIElement::documentEncoding):
1256         (AccessibilityUIElement::documentURI):
1257
1258 2009-11-12  Adam Roben  <aroben@apple.com>
1259
1260         Replace worldIDs with world objects
1261
1262         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1263         user scripts/stylesheets and isolated worlds
1264
1265         Reviewed by Sam Weinig.
1266
1267         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1268         (LayoutTestController::addUserScript):
1269         (LayoutTestController::addUserStyleSheet):
1270         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1271         (LayoutTestController::addUserScript):
1272         (LayoutTestController::addUserStyleSheet):
1273         Changed these functions to create a new WebJSWorld each time they're
1274         called and to pass that world to WebKit.
1275
1276 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1277
1278         Reviewed by Oliver Hunt.
1279
1280         need to implement aria tree roles
1281         https://bugs.webkit.org/show_bug.cgi?id=31284
1282
1283         * DumpRenderTree/AccessibilityUIElement.cpp:
1284         (disclosedRowAtIndexCallback):
1285         (selectedRowAtIndexCallback):
1286         (isEqualCallback):
1287         (isAttributeSettableCallback):
1288         (isActionSupportedCallback):
1289         (disclosedByRowCallback):
1290         (hierarchicalLevelCallback):
1291         (AccessibilityUIElement::getJSClass):
1292         * DumpRenderTree/AccessibilityUIElement.h:
1293         (AccessibilityUIElement::isEqual):
1294         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1295         (AccessibilityUIElement::hierarchicalLevel):
1296         (AccessibilityUIElement::disclosedRowAtIndex):
1297         (AccessibilityUIElement::selectedRowAtIndex):
1298         (AccessibilityUIElement::disclosedByRow):
1299         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1300         (AccessibilityUIElement::getChildAtIndex):
1301         (AccessibilityUIElement::disclosedRowAtIndex):
1302         (AccessibilityUIElement::selectedRowAtIndex):
1303         (AccessibilityUIElement::titleUIElement):
1304         (AccessibilityUIElement::parentElement):
1305         (AccessibilityUIElement::disclosedByRow):
1306         (AccessibilityUIElement::hierarchicalLevel):
1307         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1308         (AccessibilityUIElement::hierarchicalLevel):
1309         (AccessibilityUIElement::disclosedRowAtIndex):
1310         (AccessibilityUIElement::selectedRowAtIndex):
1311         (AccessibilityUIElement::disclosedByRow):
1312
1313 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1314
1315         Reviewed by Darin Adler.
1316
1317         svn-apply can not handle git binary diffs
1318         https://bugs.webkit.org/show_bug.cgi?id=26830
1319
1320         Support "literal" type git binary diffs.
1321
1322         * Scripts/VCSUtils.pm:
1323         * Scripts/modules/scm_unittest.py:
1324         * Scripts/svn-apply:
1325
1326 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1327
1328         Not reviewed, removing duplicate entry for myself in committers.py.
1329
1330         * Scripts/modules/committers.py:
1331
1332 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1333
1334         Reviewed by Darin Adler and Mark Rowe.
1335
1336         https://bugs.webkit.org/show_bug.cgi?id=31200
1337         Tests in http/tests/security/mixedContent start to fail when new tests are added
1338
1339         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1340
1341 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1342
1343         Reviewed by Jan Alonzo.
1344
1345         Create, and display a window for the inspector, for inspector
1346         tests.
1347
1348         Need to also show/hide the inspector window to avoid having
1349         problems with code assuming it is realized
1350         https://bugs.webkit.org/show_bug.cgi?id=31347
1351
1352         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1353         (webInspectorShowWindow):
1354         (webInspectorCloseWindow):
1355         (webInspectorInspectWebView):
1356         (createWebView):
1357
1358 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1359
1360         Unreviewed Qt buildbot fix.
1361
1362         My previous fix was wrong, so revert that change and fix it by
1363         returning when the document of the frame has no document element.
1364         Idea is borrowed from mac and win DRT.
1365
1366         * DumpRenderTree/qt/DumpRenderTree.cpp:
1367         (WebCore::DumpRenderTree::dumpFramesAsText):
1368
1369 2009-11-11  Eric Seidel  <eric@webkit.org>
1370
1371         Reviewed byg Kenneth Rohde Christiansen.
1372
1373         Update Kenneth's committer record to include the email he
1374         uses on lists.webkit.org.
1375
1376         * Scripts/modules/committers.py:
1377
1378 2009-11-11  Eric Seidel  <eric@webkit.org>
1379
1380         Reviewed by Gustavo Noronha Silva.
1381
1382         Several committers use separate email addresses for bugzilla and svn.webkit.org
1383         https://bugs.webkit.org/show_bug.cgi?id=31364
1384
1385         Update records for existing committers to include email addresses
1386         used in svn.webkit.org and lists.webkit.org.
1387         Most committers use the same email address in all 3 places, but some use
1388         separate addresses.  committers.py needs record of each of these addresses.
1389
1390         * Scripts/modules/committers.py:
1391
1392 2009-11-11  Eric Seidel  <eric@webkit.org>
1393
1394         No review, adding second email address for an existing committer.
1395
1396         Add Yong Li's second bugzilla account to his committer record.
1397         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1398
1399         * Scripts/modules/committers.py:
1400
1401 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1402
1403         Reviewed by Simon Hausmann.
1404
1405         If the frame has no innerText don't append it, and
1406         do not add a newline which breaks some cross platform
1407         results.
1408
1409         * DumpRenderTree/qt/DumpRenderTree.cpp:
1410         (WebCore::DumpRenderTree::dumpFramesAsText):
1411
1412 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1413
1414         Reviewed by Simon Hausmann.
1415
1416         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1417
1418         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1419         (webkit_test_plugin_new_instance):
1420         (webkit_test_plugin_destroy_instance):
1421         (webkit_test_plugin_destroy_stream):
1422
1423 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1424
1425         Reviewed by Mark Rowe.
1426
1427         Implement the functionality needed by plugins/window-open.html
1428
1429         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1430         (webkit_test_plugin_new_instance):
1431         (webkit_test_plugin_set_window):
1432
1433 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1434
1435         Reviewed by Simon Hausmann.
1436
1437         [Qt] Force -graphicssystem raster and -style windows when running DRT
1438
1439         * DumpRenderTree/qt/main.cpp:
1440         * Scripts/run-webkit-tests:
1441
1442 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1443
1444         Reviewed by Simon Hausmann.
1445
1446         Compute correct library paths for Qt
1447
1448         * Scripts/webkitdirs.pm:
1449
1450 2009-11-10  Mark Rowe  <mrowe@apple.com>
1451
1452         Reviewed by Sam Weinig.
1453
1454         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1455
1456         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1457         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1458         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1459         that had enabled frame load delegate logging this would result in extra log messages being generated,
1460         causing the test to fail.
1461
1462         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1463         tests.
1464
1465         * DumpRenderTree/mac/DumpRenderTree.mm:
1466         (dumpRenderTree):
1467         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1468         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1469
1470 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1471
1472         Reviewed by Kenneth Rohde Christiansen.
1473
1474         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1475
1476         * DumpRenderTree/qt/DumpRenderTree.cpp:
1477         (WebCore::DumpRenderTree::DumpRenderTree):
1478
1479 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1480
1481         Reviewed by Jan Alonzo.
1482
1483         [GTK] Remove WebSocket configuration from WebKitWebSettings
1484         https://bugs.webkit.org/show_bug.cgi?id=31244
1485
1486         Follow-up of r50724. Don't set the enable-web-socket property
1487         anymore.
1488
1489         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1490         (resetDefaultsToConsistentValues):
1491
1492 2009-11-10  Oliver Hunt  <oliver@apple.com>
1493
1494         Reviewed by Maciej Stachowiak.
1495
1496         Rename 3D Canvas related classes to use WebGL prefix
1497         https://bugs.webkit.org/show_bug.cgi?id=29095
1498
1499         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1500         and upate webkitdirs script to new method of testing for WebGL.
1501
1502         * Scripts/do-webcore-rename:
1503         * Scripts/webkitdirs.pm:
1504
1505 2009-11-09  Oliver Hunt  <oliver@apple.com>
1506
1507         Reviewed by Geoff Garen.
1508
1509         Make do-webcore-rename work with git.
1510
1511         * Scripts/do-webcore-rename:
1512
1513 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1514
1515         Adding Kenneth to the reviewers list.
1516
1517         * Scripts/modules/committers.py:
1518
1519 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1520
1521         Reviewed by Jan Alonzo.
1522
1523         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1524         https://bugs.webkit.org/show_bug.cgi?id=30482
1525
1526         LayoutTestControllerGtk now uses the exposed
1527         Page::tabKeyCyclesThroughElements API
1528
1529         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1530         (LayoutTestController::setTabKeyCyclesThroughElements):
1531
1532 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1533
1534         Reviewed by Holger Freyther.
1535
1536         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1537         This helps to pass the test case below. Also replaced hardcoded
1538         code numbers with defined constants.
1539         https://bugs.webkit.org/show_bug.cgi?id=31185
1540         
1541         Test: editing/undo/undo-deleteWord.html
1542
1543         * DumpRenderTree/qt/EventSenderQt.cpp:
1544         (EventSender::keyDown):
1545
1546 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1547
1548         Reviewed by Holger Freyther.
1549
1550         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1551         https://bugs.webkit.org/show_bug.cgi?id=31164
1552
1553         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1554
1555         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1556         (LayoutTestController::processWork):
1557
1558 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1559
1560         Reviewed by Holger Freyther.
1561
1562         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1563         https://bugs.webkit.org/show_bug.cgi?id=31158
1564
1565         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1566         always, which from WorkQueue prospective means that a load has been started
1567         and the queue processing should stop and wait for the load to finish.
1568         Spinning it off into a loading and a non-loading variants was the solution
1569         adopted by Mac's DRT to work around this problem. The former keeps returning
1570         'true' while the later executes the script synchronously and returns 'false'
1571         making it possible to the WorkQueue to proceed right away.
1572
1573         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1574         (LayoutTestController::processWork):
1575         (LayoutTestController::queueLoadingScript):
1576         (LayoutTestController::queueNonLoadingScript):
1577         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1578         * DumpRenderTree/qt/WorkQueueItem.h:
1579         (LoadingScriptItem::LoadingScriptItem):
1580         (LoadingScriptItem::invoke):
1581         (NonLoadingScriptItem::NonLoadingScriptItem):
1582         (NonLoadingScriptItem::invoke):
1583
1584 2009-11-07  Mark Rowe  <mrowe@apple.com>
1585
1586         Rubber-stamped by Cameron Zwarich.
1587
1588         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1589
1590         * Scripts/commit-log-editor:
1591
1592 2009-11-07  Mark Rowe  <mrowe@apple.com>
1593
1594         Reviewed by Darin Adler.
1595
1596         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1597         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1598
1599         Move logic for determining the name and email address to use in a ChangeLog entry from
1600         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1601         whether the author of the patch matches committer, and therefore needs access to the
1602         email address that would be used in a ChangeLog entry.
1603
1604         Based on a patch by Pierre d'Herbemont.
1605
1606         * Scripts/VCSUtils.pm:
1607         * Scripts/commit-log-editor:
1608         * Scripts/prepare-ChangeLog:
1609         * Scripts/webkitdirs.pm:
1610
1611 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1612
1613         Reviewed by Adam Barth.
1614
1615         Added functionality to the layout test plugin to invoke document.open and
1616         window.open with default arguments. The associated webkit bug is
1617         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1618         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1619         work in Chromium (V8) if there is no calling javascript context. To achieve this
1620         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1621         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1622
1623         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1624         (testDocumentOpen):
1625         (testWindowOpen):
1626         (pluginAllocate):
1627         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1628         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1629         (NPP_New):
1630         (NPP_SetWindow):
1631         (NPP_DestroyStream):
1632         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1633         (NPP_New):
1634         (NPP_SetWindow):
1635         (NPP_NewStream):
1636         (NPP_DestroyStream):
1637
1638 2009-11-06  Eric Seidel  <eric@webkit.org>
1639
1640         Reviewed by Adam Barth.
1641
1642         bugzilla-tool crashed with exception
1643         https://bugs.webkit.org/show_bug.cgi?id=31092
1644
1645         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1646
1647 2009-11-04  Eric Seidel  <eric@webkit.org>
1648
1649         No review, just add a line which got left out of the patch uploaded for commit.
1650
1651         commit-queue is crashing when trying to reject patches after unknown failures
1652         https://bugs.webkit.org/show_bug.cgi?id=31091
1653
1654         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1655
1656 2009-11-04  Adam Roben  <aroben@apple.com>
1657
1658         Remove bogus else clause in bugzilla-tool
1659
1660         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1661         create-bug raises exception after entering bug description
1662
1663         Reviewed by David Kilzer.
1664
1665         * Scripts/bugzilla-tool:
1666         (CreateBug): else clauses are only hit if no exception is raised, so
1667         it makes no sense to try to re-raise the exception in an else clause.
1668         The exception will automatically be re-raised if it doesn't match any
1669         of the except clauses, so we don't have to do anything special here at
1670         all to get the desired behavior.
1671
1672 2009-11-04  Eric Seidel  <eric@webkit.org>
1673
1674         Reviewed by David Kilzer.
1675
1676         svn-apply's fixChangeLogPatch function seems broken
1677         https://bugs.webkit.org/show_bug.cgi?id=30683
1678
1679         Update fixChangeLogPatch to be able to handle patches which
1680         don't start at line 1.
1681         Add unit tests for svn-apply to scm_unittest.py.
1682
1683         * Scripts/VCSUtils.pm:
1684         * Scripts/modules/scm_unittest.py:
1685
1686 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1687
1688         Reviewed by Beth Dakin.
1689
1690         Need to implement ARIA role="combobox"
1691         https://bugs.webkit.org/show_bug.cgi?id=31096
1692
1693         * DumpRenderTree/AccessibilityUIElement.cpp:
1694         (showMenuCallback):
1695         (getIsExpandedCallback):
1696         (AccessibilityUIElement::getJSClass):
1697         * DumpRenderTree/AccessibilityUIElement.h:
1698         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1699         (AccessibilityUIElement::isExpanded):
1700         (AccessibilityUIElement::showMenu):
1701         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1702         (AccessibilityUIElement::isExpanded):
1703         (AccessibilityUIElement::showMenu):
1704         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1705         (AccessibilityUIElement::isSelected):
1706         (AccessibilityUIElement::isExpanded):
1707         (AccessibilityUIElement::showMenu):
1708
1709 2009-11-04  Eric Seidel  <eric@webkit.org>
1710
1711         Reviewed by Adam Barth.
1712
1713         commit-queue is crashing when trying to reject patches after unknown failures
1714         https://bugs.webkit.org/show_bug.cgi?id=31091
1715
1716         * Scripts/bugzilla-tool:
1717          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1718            so we have to find out what the current patch is by asking bugzilla again.
1719          - Discovered that this code was also leaking file descriptors, so fixed that.
1720
1721 2009-11-04  Adam Roben  <aroben@apple.com>
1722
1723         Make run-webkit-tests work for the Debug_Internal Windows
1724         configuration
1725
1726         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1727         suffix.
1728
1729         Fixes <http://webkit.org/b/31123>.
1730
1731         Reviewed by Sam Weinig.
1732
1733         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1734         Debug_Internal, either.
1735
1736 2009-11-04  Eric Seidel  <eric@webkit.org>
1737
1738         Reviewed by Adam Barth.
1739
1740         committers.py needs a way to store non-bugzilla email addresses
1741         https://bugs.webkit.org/show_bug.cgi?id=31037
1742
1743         Make Committer and Reviewer constructors take a single email or a list of emails.
1744         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1745         Expose reviewers(), used by validate-committer-lists on bug 30970.
1746
1747         * Scripts/modules/committers.py:
1748         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1749
1750 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1751
1752         Reviewed by David Levin.
1753
1754         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1755         https://bugs.webkit.org/show_bug.cgi?id=27491
1756
1757         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1758         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1759
1760         Functions to start or stop Web Socket servers are added.
1761
1762         * Scripts/run-webkit-tests:
1763
1764 2009-11-03  Eric Seidel  <eric@webkit.org>
1765
1766         No review, just changing wording of log message.
1767
1768         Change log string to say "failed" instead of "rejected"
1769         when a commit fails due to an out of date checkout.
1770         This makes grepping the commit-queue log for rejected patches easier.
1771
1772         * Scripts/bugzilla-tool:
1773
1774 2009-11-03  Eric Seidel  <eric@webkit.org>
1775
1776         No review, adding commonly known committers missing from the file.
1777
1778         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1779
1780 2009-11-03  Eric Seidel  <eric@webkit.org>
1781
1782         No review, just sort-order cleanup.
1783
1784         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1785
1786 2009-11-03  Stephen White  <senorblanco@chromium.org>
1787
1788         (Unreviewed).
1789
1790         Add myself to committers.py.
1791
1792         * Scripts/modules/committers.py:
1793
1794 2009-11-03  Robin Dunn  <robin@alldunn.com>
1795
1796         Reviewed by Kevin Ollviier.
1797
1798         Add packaging scripts for Debian-based Linux distros.
1799         
1800         https://bugs.webkit.org/show_bug.cgi?id=31075
1801
1802         * wx/packaging/build-debian-installer.py: Added.
1803         * wx/packaging/debian: Added.
1804
1805 2009-11-03  Dan Bernstein  <mitz@apple.com>
1806
1807         Reviewed by Anders Carlsson and Beth Dakin.
1808
1809         https://bugs.webkit.org/show_bug.cgi?id=31070
1810
1811         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1812         destroyed, it executes the value of the 'ondestroy' parameter as a
1813         script.
1814
1815         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1816         (pluginAllocate): Initialize onDestroy.
1817         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1818         onDestroy.
1819         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1820         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
1821         specified.
1822         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
1823
1824 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1825
1826         Reviewed by Xan Lopez.
1827
1828         https://bugs.webkit.org/show_bug.cgi?id=31035
1829         [GTK] some accessibility tests hitting assertion in debug builds
1830
1831         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
1832
1833         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1834         (AccessibilityController::rootElement):
1835
1836 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
1837
1838         Reviewed by Beth Dakin.
1839
1840         Support ARIA "tab" roles
1841         https://bugs.webkit.org/show_bug.cgi?id=30842
1842
1843         * DumpRenderTree/AccessibilityUIElement.cpp:
1844         * DumpRenderTree/AccessibilityUIElement.h:
1845         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1846         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1847         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1848
1849 2009-11-01  Eric Seidel  <eric@webkit.org>
1850
1851         Reviewed by David Levin.
1852
1853         buildbots should use --exit-after-N-failures
1854         https://bugs.webkit.org/show_bug.cgi?id=30809
1855
1856         Make the bots exit after 20 failures to prevent never-ending
1857         test runs where every test spends a minute crashing.
1858
1859         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1860
1861 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1862
1863         Reviewed by Eric Seidel.
1864
1865         Turn on warnings for QtWebKit for gcc
1866         https://bugs.webkit.org/show_bug.cgi?id=30958
1867
1868         * DumpRenderTree/qt/main.cpp: 
1869         (crashHandler): Mark function NO_RETURN
1870
1871 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
1872
1873         Adding myself to the committers list.
1874
1875         * Scripts/modules/committers.py:
1876
1877 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
1878
1879         Fix an issue that Adam noticed in DRT.
1880
1881         Reviewed by Darin Adler.
1882
1883         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1884         (AccessibilityUIElement::role):
1885         Get the length of the role text, and create a buffer dynamically.
1886
1887 2009-10-30  Eric Seidel  <eric@webkit.org>
1888
1889         No review, rolling out r50105.
1890         http://trac.webkit.org/changeset/50105
1891
1892         This commit was causing:
1893         https://bugs.webkit.org/show_bug.cgi?id=30869
1894         We'll re-implement the feature a different way.
1895
1896         * Scripts/bugzilla-tool:
1897
1898 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1899
1900         Test for MSAA: Accessibility of headings is not correct
1901
1902         https://bugs.webkit.org/show_bug.cgi?id=30937
1903
1904         Reviewed by Adam Roben.
1905
1906         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1907         (AccessibilityUIElement::role):
1908         Allow the role returned to be a BSTR.
1909         (AccessibilityUIElement::description):
1910         Fix a copy/paste error.
1911
1912 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1913
1914         Test for MSAA: Accessibility of links is wrong
1915
1916         https://bugs.webkit.org/show_bug.cgi?id=30928
1917
1918         Reviewed by Darin Adler.
1919
1920         * DumpRenderTree/AccessibilityUIElement.cpp:
1921         (getAccessibilityValueCallback):
1922         Return the accessibility value.
1923         (AccessibilityUIElement::getJSClass):
1924         Added "accessibilityValue" value.
1925
1926         * DumpRenderTree/AccessibilityUIElement.h:
1927
1928         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1929         (AccessibilityUIElement::accessibilityValue):
1930         Stubbed.
1931
1932         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1933         (AccessibilityUIElement::accessibilityValue):
1934         Stubbed.
1935
1936         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1937         (AccessibilityUIElement::accessibilityValue):
1938         Get the object's value, and return it as a JS string.
1939
1940 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
1941
1942         Fix typo in command name used by wx build system.
1943
1944         * wx/build/build_utils.py:
1945
1946 2009-10-30  Adam Barth  <abarth@webkit.org>
1947
1948         Reviewed by Darin Adler.
1949
1950         Patch v1 is a dumb default name for patches
1951         https://bugs.webkit.org/show_bug.cgi?id=30952
1952
1953         Let's use "Patch" instead.
1954
1955         * Scripts/bugzilla-tool:
1956
1957 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1958
1959         Unreviewed trivial buildfix.
1960
1961         [Qt] Buildfix for r50333.
1962
1963         * DumpRenderTree/qt/DumpRenderTree.pro:
1964
1965 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
1966
1967         Reviewed by Holger Freyther.
1968
1969         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
1970         https://bugs.webkit.org/show_bug.cgi?id=30953
1971
1972         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
1973         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
1974         makes qt DRT to share this implementation (as gtk and mac ports do).
1975
1976         * DumpRenderTree/qt/DumpRenderTree.pro:
1977         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
1978         * DumpRenderTree/qt/WorkQueue.h: Removed.
1979
1980 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1981
1982         Unreviewed potential buildbot fix.
1983
1984         Second try: Reset page history before running each test.
1985
1986         Apparently the QWebHistory::clear() keeps the current page
1987         in history which is not what we want, so we not additionally
1988         sets the history capacity to 0 (forces removing everything)
1989         and then sets it back to its original value.
1990
1991         * DumpRenderTree/qt/DumpRenderTree.cpp:
1992         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1993
1994 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1995
1996         Unreviewed potential buildbot fix.
1997
1998         Reset page history before running each test.
1999
2000         * DumpRenderTree/qt/DumpRenderTree.cpp:
2001         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2002
2003 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2004
2005         Reviewed by Eric Seidel.
2006
2007         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2008
2009         Bug 28420 -  Implement HTML5 <ruby> rendering
2010         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2011
2012         No new tests (no functional change).
2013
2014         * Scripts/build-webkit:
2015
2016 2009-10-29  Dan Bernstein  <mitz@apple.com>
2017
2018         Reviewed by Mark Rowe.
2019
2020         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2021         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2022         define it.
2023
2024         * Scripts/VCSUtils.pm:
2025         * Scripts/svn-apply:
2026         * Scripts/svn-unapply:
2027
2028 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2029
2030         Reviewed by Gustavo Noronha.
2031
2032         Use the GTK+ main loop instead of rolling our own mini-version of
2033         it.
2034
2035         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2036         (dump):
2037         (runTest):
2038         (webViewLoadFinished):
2039
2040 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2041
2042         Reviewed by Oliver Hunt.
2043
2044         Implement the Qt version of DRT dumpBackForwardList().
2045
2046         * DumpRenderTree/qt/DumpRenderTree.cpp:
2047         (WebCore::dumpHistoryItem):
2048         (WebCore::DumpRenderTree::dumpBackForwardList):
2049
2050 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2051
2052         Reviewed by Adam Roben.
2053
2054         Implement DRT functionality for Qt introduced in
2055         r28690 and r28705.
2056
2057         - Implemented pathToLocalResource which exposes the functionality of
2058         converting a given unix path to the correct location on Windows.
2059         - Implemented a way to remove machine-dependent information from paths
2060         in layout test results.
2061
2062         * DumpRenderTree/qt/DumpRenderTree.cpp:
2063         (WebCore::urlSuitableForTestResult):
2064         (WebCore::WebPage::javaScriptConsoleMessage):
2065         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2066         (LayoutTestController::pathToLocalResource):
2067         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2068
2069 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2070
2071         Adding myself to the committers list.
2072
2073         * Scripts/modules/committers.py:
2074
2075 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2076
2077         Adding myself to the committers list.
2078
2079         * Scripts/modules/committers.py:
2080
2081 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2082
2083         Reviewed by Jan Alonzo.
2084
2085         [GTK] API to start inspector for a WebView
2086         https://bugs.webkit.org/show_bug.cgi?id=22551
2087
2088         Use the new inspector API to implement the LayoutTestController
2089         interfaces used to test the inspector.
2090
2091         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2092         (webInspectorInspectWebView):
2093         (createWebView):
2094         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2095         (LayoutTestController::showWebInspector):
2096         (LayoutTestController::closeWebInspector):
2097         (LayoutTestController::evaluateInWebInspector):
2098
2099 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2100
2101         Reviewed by Eric Seidel.
2102
2103         [Qt] WebFrame::counterValueForElementById must not be exposed
2104         https://bugs.webkit.org/show_bug.cgi?id=30882
2105
2106         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2107         (LayoutTestController::counterValueForElementById):
2108
2109 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2110
2111         Rubberstamped by Oliver Hunt.
2112
2113         Fix the warning:
2114
2115         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2116         declared with attribute warn_unused_result".
2117
2118         by actually checking the result. In the case it is null, an
2119         error has occoured, so treat it as the other fatal errors.
2120
2121         * DumpRenderTree/qt/DumpRenderTree.cpp:
2122         (WebCore::DumpRenderTree::initializeFonts):
2123
2124 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2125
2126         Reviewed by Darin Adler.
2127
2128         Provide a way to get counter values with layoutTestContoller
2129         https://bugs.webkit.org/show_bug.cgi?id=30555
2130
2131         Define layoutTestContoller.counterValueForElementById.
2132
2133         * DumpRenderTree/LayoutTestController.cpp:
2134         (counterValueForElementByIdCallback):
2135         (LayoutTestController::staticFunctions):
2136         * DumpRenderTree/LayoutTestController.h:
2137         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2138         (LayoutTestController::counterValueForElementById):
2139
2140 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2141
2142         Rubberstamped by Oliver Hunt.
2143
2144         Change two methods to be internal for DRT use only.
2145
2146         Part of [Qt] Review all new API in Qt 4.6
2147         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2148
2149         * DumpRenderTree/qt/DumpRenderTree.cpp:
2150         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2151         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2152         (LayoutTestController::whiteListAccessFromOrigin):
2153
2154 2009-10-27  Eric Seidel  <eric@webkit.org>
2155
2156         Reviewed by Adam Barth.
2157
2158         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2159         https://bugs.webkit.org/show_bug.cgi?id=30826
2160
2161         * Scripts/svn-apply:
2162          - Add () around all system() calls.
2163          - Use the correct system() == 0 or die instead of system() or die
2164          - Add descriptive messages to all die statements.
2165
2166 2009-10-27  Steve Block  <steveblock@google.com>
2167
2168         Reviewed by NOBODY.
2169
2170         Adds steveblock@google.com to list of committers.
2171
2172         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2173
2174 2009-10-27  Eric Seidel  <eric@webkit.org>
2175
2176         Reviewed by Adam Barth.
2177
2178         svn-apply can exit(0) even on patch failure
2179         https://bugs.webkit.org/show_bug.cgi?id=29622
2180
2181         * Scripts/svn-apply:
2182          - Add a bunch of "or die" statements, hopefully catching all
2183            possible cases where failure could still exit(0).
2184
2185 2009-10-27  Eric Seidel  <eric@webkit.org>
2186
2187         Reviewed by Adam Barth.
2188
2189         svn-* scripts should share code through VCSUtils.pm
2190         https://bugs.webkit.org/show_bug.cgi?id=30791
2191
2192         Just moving code into a shared location.
2193
2194         * Scripts/VCSUtils.pm:
2195         * Scripts/prepare-ChangeLog:
2196         * Scripts/resolve-ChangeLogs:
2197         * Scripts/svn-apply:
2198         * Scripts/svn-create-patch:
2199         * Scripts/svn-unapply:
2200         * Scripts/update-webkit:
2201
2202 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2203
2204         Suppress a huge number of MSVC warnings when building wxWebKit.
2205
2206         * wx/build/settings.py:
2207
2208 2009-10-26  Eric Seidel  <eric@webkit.org>
2209
2210         No review, just adding Mike Belshe to the committers list.
2211
2212         * Scripts/modules/committers.py:
2213
2214 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2215
2216         Reviewed by Darin Adler.
2217
2218         Make .rc files compile on Windows without depending on MFC headers
2219         https://bugs.webkit.org/show_bug.cgi?id=30750
2220
2221         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2222         windows.h instead of afxres.h because it exists even when MFC is not 
2223         installed, and is all that's needed here.
2224
2225         * FindSafari/FindSafari.rc: Ditto
2226
2227 2009-10-24  Eric Seidel  <eric@webkit.org>
2228
2229         Reviewed by Adam Barth.
2230
2231         bugzilla-tool post-diff should know how to mark commit-queue=?
2232         https://bugs.webkit.org/show_bug.cgi?id=29202
2233
2234         * Scripts/bugzilla-tool:
2235          - Add --commit-queue option to post-diff, post-commits and create-bug.
2236         * Scripts/modules/bugzilla.py:
2237          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2238          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2239
2240 2009-10-23  Eric Seidel  <eric@webkit.org>
2241
2242         Reviewed by Adam Barth.
2243
2244         bugzilla-tool commit-queue does not notice modifications to committers.py
2245         https://bugs.webkit.org/show_bug.cgi?id=30084
2246
2247         * Scripts/bugzilla-tool:
2248          - Make commit-queue re-exec itself instead of using while(1).
2249          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2250          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2251
2252 2009-10-22  Eric Seidel  <eric@webkit.org>
2253
2254         Reviewed by Adam Barth.
2255
2256         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2257         https://bugs.webkit.org/show_bug.cgi?id=30634
2258
2259         * Scripts/bugzilla-tool:
2260          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2261          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2262
2263 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2264
2265         Reviewed by Eric Seidel.
2266
2267         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2268
2269         https://bugs.webkit.org/show_bug.cgi?id=30763
2270
2271         * pywebsocket/mod_pywebsocket/__init__.py:
2272         * pywebsocket/mod_pywebsocket/dispatch.py:
2273         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2274         * pywebsocket/mod_pywebsocket/standalone.py:
2275         * pywebsocket/setup.py:
2276         * pywebsocket/test/test_dispatch.py:
2277
2278 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2279
2280         Reviewed by David Levin.
2281
2282         REGRESSION: 2 failures in run-webkit-unittests
2283         https://bugs.webkit.org/show_bug.cgi?id=30645
2284
2285         * Scripts/modules/cpp_style_unittest.py:
2286         Fixed a few test scenarios which apparently lost some spaces from 
2287         text literals.
2288
2289 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2290
2291         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2292
2293         * Scripts/webkitdirs.pm:
2294
2295 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2296
2297         Reviewed by Darin Adler.
2298
2299         Unification of using null device in perl scripts.
2300         https://bugs.webkit.org/show_bug.cgi?id=30572
2301
2302         * Scripts/VCSUtils.pm:
2303         * Scripts/bisect-builds:
2304         * Scripts/resolve-ChangeLogs:
2305         * Scripts/run-iexploder-tests:
2306         * Scripts/run-jsc:
2307         * Scripts/run-mangleme-tests:
2308         * Scripts/run-webkit-tests:
2309         * Scripts/webkitdirs.pm:
2310         Using File::Spec->devnull() instead of hard coded /dev/null.
2311
2312 2009-10-26  Eric Seidel  <eric@webkit.org>
2313
2314         Reviewed by Holger Freyther.
2315
2316         Reviewers are missing from committers.py
2317         https://bugs.webkit.org/show_bug.cgi?id=30733
2318
2319         * Scripts/modules/committers.py:
2320
2321 2009-10-23  Eric Seidel  <eric@webkit.org>
2322
2323         No review, only adding Alice to the list of reviewers.
2324
2325         * Scripts/modules/committers.py:
2326
2327 2009-10-23  Eric Seidel  <eric@webkit.org>
2328
2329         Reviewed by Eric Carlson.
2330
2331         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2332         https://bugs.webkit.org/show_bug.cgi?id=30700
2333
2334         * DumpRenderTree/mac/DumpRenderTree.mm:
2335         (resetDefaultsToConsistentValues): Update QuickTime version check.
2336
2337 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2338
2339         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2340         character measurement APIs that are private on Tiger.
2341
2342         * wx/build/settings.py:
2343
2344 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2345
2346         Reviewed by NOBODY (build fix).
2347         Build fix following bug #30696.
2348
2349         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2350         (LayoutTestController::evaluateScriptInIsolatedWorld):
2351
2352 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2353
2354         Reviewed by Sam Weinig & Geoff Garen.
2355
2356         https://bugs.webkit.org/show_bug.cgi?id=30696
2357         Enable isolated-worlds tests on mac.
2358
2359         Add private interface for DRT to invoke execution in a given world.
2360
2361         * DumpRenderTree/LayoutTestController.cpp:
2362         (evaluateScriptInIsolatedWorldCallback):
2363         (LayoutTestController::staticFunctions):
2364         * DumpRenderTree/LayoutTestController.h:
2365         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2366         (LayoutTestController::evaluateScriptInIsolatedWorld):
2367         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2368         (LayoutTestController::evaluateScriptInIsolatedWorld):
2369
2370 2009-10-21  Eric Seidel  <eric@webkit.org>
2371
2372         Reviewed by Adam Barth.
2373
2374         bugzilla-tool's "patch failed to download an apply" error should give more information
2375         https://bugs.webkit.org/show_bug.cgi?id=30632
2376
2377         * Scripts/modules/scm.py:
2378          - Use the common run_command method instead of custom POpen code.
2379          - Make run_command know how to take pipes as input.
2380         * Scripts/modules/scm_unittest.py:
2381          - Add new tests to cover change.
2382          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2383
2384 2009-10-21  Kent Tamura  <tkent@chromium.org>
2385
2386         Unreviewed.  Adding myself to the committers list.
2387
2388         * Scripts/modules/committers.py:
2389
2390 2009-10-21  Robin Dunn  <robin@alldunn.com>
2391
2392         Reviewed by Kevin Ollivier.
2393
2394         Update the Windows installer builder to work with Vista / Win 7 and with git.
2395         
2396         https://bugs.webkit.org/show_bug.cgi?id=30649
2397
2398         * wx/build/build_utils.py:
2399         * wx/packaging/build-mac-installer.py:
2400         * wx/packaging/build-win-installer.py:
2401         * wx/packaging/wxWebKitInstaller.iss.in:
2402
2403 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2404
2405         Reviewed by Gustavo Noronha.
2406
2407         [GTK] Added conditional code to avoid using
2408         gdk_window_get_root_coords if we do not have a gtk+ release newer
2409         than 2.17.3.
2410         https://bugs.webkit.org/show_bug.cgi?id=30636
2411
2412         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2413
2414 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2415
2416         Reviewed by Eric Seidel.
2417
2418         [Qt] Added dummy implementation for keepWebHistory()
2419         https://bugs.webkit.org/show_bug.cgi?id=30592
2420
2421         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2422         (LayoutTestController::keepWebHistory):
2423         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2424
2425 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2426
2427         Reviewed by Xan Lopez.
2428
2429         [GTK] Fixed the double click condition, it is not double click if
2430         we move in just in one direction.
2431         https://bugs.webkit.org/show_bug.cgi?id=30636
2432
2433         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2434
2435 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2436
2437         Reviewed by Xan Lopez.
2438
2439         [GTK] Initialize the events completly before emitting them.
2440         https://bugs.webkit.org/show_bug.cgi?id=30633
2441
2442         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2443
2444 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2445
2446         wx build fix. Fix for when linking using --as-needed with gcc.
2447
2448         * wx/browser/wscript:
2449
2450 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2451
2452         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2453         to support all the features used by CURL backend.
2454         
2455         * wx/build/settings.py:
2456         * wx/install-unix-extras:
2457
2458 2009-10-20  Anton Muhin  <antonm@chromium.org>
2459
2460         Reviewed by Adam Barth.
2461
2462         Add {ager,antonm,yurys}@chromium.org into committers.py
2463         https://bugs.webkit.org/show_bug.cgi?id=30560
2464
2465         * Scripts/modules/committers.py:
2466
2467 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2468
2469         Reviewed by Tor Arne Vestbø.
2470
2471         Make the Netscape Test plugin available to the Qt launcher.
2472
2473         * Scripts/run-launcher:
2474
2475 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2476
2477         Reviewed by David Levin.
2478
2479         Removed WebSocket runtime settings.
2480         https://bugs.webkit.org/show_bug.cgi?id=29896
2481
2482         WebSocket runtime configuration is supported by chromium/v8 only.
2483
2484         * DumpRenderTree/mac/DumpRenderTree.mm:
2485         (resetDefaultsToConsistentValues):
2486         * DumpRenderTree/win/DumpRenderTree.cpp:
2487         (resetDefaultsToConsistentValues):
2488
2489 2009-10-19  Nate Chapin  <japhet@chromium.org>
2490
2491         Reviewed by Adam Barth.
2492
2493         Add testFail() to test plugin so we can test our handling of a
2494         plugin invoke call returning false.
2495
2496         https://bugs.webkit.org/show_bug.cgi?id=30239
2497
2498         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2499         (pluginInvoke):
2500         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2501
2502 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2503
2504         Reviewed by Gustavo Noronha.
2505
2506         Enable DOM pasting when running layout tests.
2507
2508         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2509         (resetDefaultsToConsistentValues):
2510
2511 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2512
2513         Reviewed by Simon Hausmann.
2514
2515         Use the setPreferredContentsSize method instead
2516         of setFixedContentsSize, as the method has been renamed.
2517
2518         * DumpRenderTree/qt/DumpRenderTree.cpp:
2519         (WebCore::DumpRenderTree::open):
2520         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2521         (LayoutTestController::setFixedContentsSize):
2522
2523 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2524
2525         Reviewed by Dan Bernstein.
2526
2527         https://bugs.webkit.org/show_bug.cgi?id=30456
2528         Fixes for new Debug_All Windows build configuration.
2529
2530         * DumpRenderTree/win/DumpRenderTree.cpp:
2531         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2532         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2533
2534 2009-10-16  Eric Seidel  <eric@webkit.org>
2535
2536         Reviewed by Adam Barth.
2537
2538         commit-queue status bot should list which buildbot is blocking the queue
2539         https://bugs.webkit.org/show_bug.cgi?id=30452
2540
2541         Add new methods and testing.
2542
2543         * Scripts/bugzilla-tool:
2544         * Scripts/modules/buildbot.py:
2545         * Scripts/modules/buildbot_unittest.py:
2546
2547 2009-10-16  Eric Seidel  <eric@webkit.org>
2548
2549         Reviewed by Adam Barth.
2550
2551         run-webkit-tests fails when CWD is not inside a WebKit checkout
2552         https://bugs.webkit.org/show_bug.cgi?id=30451
2553
2554         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2555         * Scripts/modules/scm_unittest.py:
2556           - Remove use of original_path (we don't need to restore the CWD).
2557           - Don't use '.' to find the webkit checkout, use __file__ instead.
2558
2559 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2560
2561         Reviewed by Adam Roben.
2562
2563         Add a Debug_All configuration to build entire stack as debug.
2564         Change Debug_Internal to:
2565         - stop using _debug suffix for all WebKit/Safari binaries
2566         - not use _debug as a DLL naming suffix
2567         - use non-debug C runtime lib.
2568
2569         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2570         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2571         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2572         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2573         Add missing debug.vsprops inherited property sheet.
2574         Add Debug_All configuration.
2575         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2576         * WinLauncher/WinLauncher.vcproj:
2577         Removed extraneous definitions inherited from vsprops.
2578         Add Debug_All configuration.
2579
2580 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2581
2582         Reviewed by David Levin.
2583
2584         check-webkit-style is wrong about indent checking in namespaces
2585         in header files and a few other things
2586         https://bugs.webkit.org/show_bug.cgi?id=30362
2587
2588         The few other things include:
2589         + check-webkit-style does not require spaces around the equal sign
2590           inside 'if' statements and around binary operators that take 
2591           numeric literals.
2592         + check-webkit-style reports false errors for the / operator
2593           when part of a filename in the #include directive.
2594
2595         * Scripts/modules/cpp_style.py:
2596         Improved indentation checking and space checking around
2597         binary operators. While the checks are still not perfect,
2598         they are clearly better than before.
2599         * Scripts/modules/cpp_style_unittest.py:
2600         Added test cases for the newly supported checks and modified old
2601         test cases to match the new guidelines
2602
2603 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2604
2605         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2606
2607         * wx/build/settings.py:
2608
2609 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2610
2611         Reviewed by David Levin.
2612
2613         Add mod_pywebsocket to test Web Sockets.
2614         http://code.google.com/p/pywebsocket/
2615         https://bugs.webkit.org/show_bug.cgi?id=27490
2616
2617         * pywebsocket/COPYING: Added.
2618         * pywebsocket/MANIFEST.in: Added.
2619         * pywebsocket/README: Added.
2620         * pywebsocket/example/echo_client.py: Added.
2621         * pywebsocket/example/echo_wsh.py: Added.
2622         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2623         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2624         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2625         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2626         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2627         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2628         * pywebsocket/mod_pywebsocket/util.py: Added.
2629         * pywebsocket/setup.py: Added.
2630         * pywebsocket/test/config.py: Added.
2631         * pywebsocket/test/mock.py: Added.
2632         * pywebsocket/test/run_all.py: Added.
2633         * pywebsocket/test/test_dispatch.py: Added.
2634         * pywebsocket/test/test_handshake.py: Added.
2635         * pywebsocket/test/test_mock.py: Added.
2636         * pywebsocket/test/test_msgutil.py: Added.
2637         * pywebsocket/test/test_util.py: Added.
2638         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2639         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2640         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2641         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2642         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2643         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2644         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2645         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2646
2647 2009-10-15  James Robinson  <jamesr@google.com>
2648
2649         Reviewed by David Levin.
2650
2651         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2652
2653         https://bugs.webkit.org/show_bug.cgi?id=30426
2654
2655         * Scripts/modules/cpp_style.py:
2656         * Scripts/modules/cpp_style_unittest.py:
2657
2658 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2659
2660         Reviewed by Adam Roben.
2661
2662         Fixes <http://webkit.org/b/30411>.
2663         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2664         
2665         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2666         building Chromium.
2667
2668         * Scripts/pdevenv:
2669
2670 2009-10-15  Robin Dunn  <robin@alldunn.com>
2671
2672         Reviewed by Kevin Ollivier.
2673
2674         Add Mac package building scripts for wx.
2675         
2676         https://bugs.webkit.org/show_bug.cgi?id=30405
2677
2678         * wx/build/build_utils.py:
2679         * wx/build/settings.py:
2680         * wx/packaging/build-mac-installer.py: Added.
2681
2682 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2683
2684         Reviewed by Gustavo Noronha.
2685
2686         Enable Web Sockets support when running layout tests.
2687
2688         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2689         (resetDefaultsToConsistentValues):
2690
2691 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2692
2693         Reviewed by Gustavo Noronha.
2694
2695         Need to initialize event.button.button, since in most cases a
2696         button number is not passed as an argument.
2697
2698         * DumpRenderTree/gtk/EventSender.cpp:
2699         (mouseDownCallback):
2700         (mouseUpCallback):
2701
2702 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2703
2704         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2705         the OS if none was explicitly set.
2706
2707         * wx/build/settings.py:
2708
2709 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2710
2711         Reviewed by Timothy Hatcher.
2712
2713         Web Inspector: enable developers extras within inspector layout tests.
2714
2715         https://bugs.webkit.org/show_bug.cgi?id=30014
2716
2717         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2718         (LayoutTestController::showWebInspector):
2719         (LayoutTestController::closeWebInspector):
2720         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2721         (LayoutTestController::showWebInspector):
2722         (LayoutTestController::closeWebInspector):
2723
2724 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2725
2726         Reviewed by Jan Alonzo.
2727
2728         GtkLauncher is using a deprecated signal
2729         https://bugs.webkit.org/show_bug.cgi?id=30364
2730
2731         Modified GtkLauncher to use notify::title signal instead of
2732         deprecated title-changed signal
2733
2734         * GtkLauncher/main.c:
2735         (notify_title_cb):
2736         (create_browser):
2737
2738 2009-10-14  Brady Eidson  <beidson@apple.com>
2739
2740         Reviewed by Sam Weinig.
2741
2742         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2743         1 - Disables WebHistory
2744         2 - Doesn't make sense in that context anyway.
2745
2746         * DumpRenderTree/win/DumpRenderTree.cpp:
2747         (createWebViewAndOffscreenWindow):
2748
2749 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2750
2751         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2752         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2753
2754         * wx/build/settings.py:
2755         * wx/install-unix-extras:
2756
2757 2009-10-14  Brady Eidson  <beidson@apple.com>
2758
2759         Reviewed by Sam Weinig.
2760
2761         WebKit Win API should provide a delegate interface for global history.
2762         https://bugs.webkit.org/show_bug.cgi?id=29905
2763
2764         * DumpRenderTree/LayoutTestController.cpp:
2765         (LayoutTestController::LayoutTestController):
2766         * DumpRenderTree/LayoutTestController.h:
2767         (LayoutTestController::dumpHistoryDelegateCallbacks):
2768         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2769                 
2770         * DumpRenderTree/win/DumpRenderTree.cpp:
2771         (shouldLogHistoryDelegates):
2772         (runTest):
2773         (createWebViewAndOffscreenWindow):
2774         (main):
2775         * DumpRenderTree/win/DumpRenderTree.vcproj:
2776         
2777         Add the IWebHistoryDelegate to DRT Windows:
2778         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2779         (wstringFromBSTR):
2780         (HistoryDelegate::HistoryDelegate):
2781         (HistoryDelegate::~HistoryDelegate):
2782         (HistoryDelegate::QueryInterface):
2783         (HistoryDelegate::AddRef):
2784         (HistoryDelegate::Release):
2785         (HistoryDelegate::didNavigateWithNavigationData):
2786         (HistoryDelegate::didPerformClientRedirectFromURL):
2787         (HistoryDelegate::didPerformServerRedirectFromURL):
2788         (HistoryDelegate::updateHistoryTitle):
2789         (HistoryDelegate::populateVisitedLinksForWebView):
2790         * DumpRenderTree/win/HistoryDelegate.h: Added.
2791
2792         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2793         (LayoutTestController::removeAllVisitedLinks):
2794
2795 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2796
2797         Reviewed by Simon Hausmann.
2798
2799         [Qt] Implement support for setPOSIXLocale on Qt.
2800         https://bugs.webkit.org/show_bug.cgi?id=30268 
2801  
2802         * DumpRenderTree/qt/DumpRenderTree.cpp:
2803         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2804         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2805         (LayoutTestController::setPOSIXLocale):
2806         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2807
2808 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2809
2810         Unreviewed, adding myself to reviewers list.
2811
2812         * Scripts/modules/committers.py:
2813
2814 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2815
2816         Reviewed by Mark Rowe.
2817
2818         Fix null assignment so root tests work again.
2819
2820         * Scripts/webkitdirs.pm:
2821
2822 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2823
2824         Reviewed by Simon Hausmann.
2825
2826         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
2827         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
2828         This is done in preparation of implementing missing features in DRT.
2829         No functionality changes made yet.
2830
2831         * DumpRenderTree/qt/DumpRenderTree.cpp:
2832         * DumpRenderTree/qt/DumpRenderTree.pro:
2833         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
2834         (EventSender::EventSender):
2835         (EventSender::mouseDown):
2836         (EventSender::mouseUp):
2837         (EventSender::mouseMoveTo):
2838         (EventSender::leapForward):
2839         (EventSender::keyDown):
2840         (EventSender::contextClick):
2841         (EventSender::scheduleAsynchronousClick):
2842         (EventSender::frameUnderMouse):
2843         * DumpRenderTree/qt/EventSenderQt.h: Added.
2844         (EventSender::clearKillRing):
2845         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
2846         (LayoutTestController::LayoutTestController):
2847         (LayoutTestController::reset):
2848         (LayoutTestController::processWork):
2849         (LayoutTestController::maybeDump):
2850         (LayoutTestController::waitUntilDone):
2851         (LayoutTestController::notifyDone):
2852         (LayoutTestController::windowCount):
2853         (LayoutTestController::clearBackForwardList):
2854         (LayoutTestController::dumpEditingCallbacks):
2855         (LayoutTestController::dumpResourceLoadCallbacks):
2856         (LayoutTestController::queueBackNavigation):
2857         (LayoutTestController::queueForwardNavigation):
2858         (LayoutTestController::queueLoad):
2859         (LayoutTestController::queueReload):
2860         (LayoutTestController::queueScript):
2861         (LayoutTestController::provisionalLoad):
2862         (LayoutTestController::timerEvent):
2863         (LayoutTestController::encodeHostName):
2864         (LayoutTestController::decodeHostName):
2865         (LayoutTestController::setJavaScriptProfilingEnabled):
2866         (LayoutTestController::setFixedContentsSize):
2867         (LayoutTestController::setPrivateBrowsingEnabled):
2868         (LayoutTestController::setPopupBlockingEnabled):
2869         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2870         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2871         (LayoutTestController::numberOfActiveAnimations):
2872         (LayoutTestController::disableImageLoading):
2873         (LayoutTestController::dispatchPendingLoadRequests):
2874         (LayoutTestController::setDatabaseQuota):
2875         (LayoutTestController::clearAllDatabases):
2876         (LayoutTestController::whiteListAccessFromOrigin):
2877         (LayoutTestController::waitForPolicyDelegate):
2878         (LayoutTestController::overridePreference):
2879         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
2880         (LayoutTestController::isLoading):
2881         (LayoutTestController::setLoading):
2882         (LayoutTestController::shouldDumpAsText):
2883         (LayoutTestController::shouldDumpBackForwardList):
2884         (LayoutTestController::shouldDumpChildrenAsText):
2885         (LayoutTestController::shouldDumpDatabaseCallbacks):
2886         (LayoutTestController::shouldDumpStatusCallbacks):
2887         (LayoutTestController::shouldWaitUntilDone):
2888         (LayoutTestController::canOpenWindows):
2889         (LayoutTestController::shouldDumpTitleChanges):
2890         (LayoutTestController::waitForPolicy):
2891         (LayoutTestController::dumpAsText):
2892         (LayoutTestController::dumpChildFramesAsText):
2893         (LayoutTestController::dumpDatabaseCallbacks):
2894         (LayoutTestController::dumpStatusCallbacks):
2895         (LayoutTestController::setCanOpenWindows):
2896         (LayoutTestController::dumpBackForwardList):
2897         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2898         (LayoutTestController::display):
2899         (LayoutTestController::dumpTitleChanges):
2900         (LayoutTestController::dumpSelectionRect):
2901         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
2902         (TextInputController::TextInputController):
2903         (TextInputController::doCommand):
2904         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
2905         * DumpRenderTree/qt/WorkQueue.cpp:
2906         * DumpRenderTree/qt/WorkQueue.h:
2907         * DumpRenderTree/qt/WorkQueueItem.h:
2908         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
2909         (findFrameNamed):
2910         (LoadItem::invoke):
2911         (ReloadItem::invoke):
2912         (ScriptItem::invoke):
2913         (BackForwardItem::invoke):
2914         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
2915         * DumpRenderTree/qt/jsobjects.h:
2916
2917 2009-10-13  Dmitry Titov  <dimich@chromium.org>
2918
2919         Not reviewed, adding myself to the list of reviewers.
2920
2921         * Scripts/modules/committers.py:
2922
2923 2009-10-13  Anders Carlsson  <andersca@apple.com>
2924
2925         Reviewed by Sam Weinig.
2926
2927         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
2928
2929         Make the private browsing mode testable by the test plug-in.
2930         
2931         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2932         (pluginGetProperty):
2933         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2934         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2935         (NPP_New):
2936         (NPP_SetValue):
2937
2938 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
2939
2940         No review, just adding self to the list of reviewers.
2941
2942         * Scripts/modules/committers.py:
2943
2944 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
2945
2946         Reviewed by Adam Roben.
2947
2948         Web Inspector: Use proper web view in inspector layout
2949         tests for windows.
2950
2951         https://bugs.webkit.org/show_bug.cgi?id=30298
2952
2953         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2954         (LayoutTestController::showWebInspector):
2955         (LayoutTestController::closeWebInspector):
2956         (LayoutTestController::evaluateInWebInspector):
2957
2958 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
2959
2960         Reviewed by Sam Weinig.
2961
2962         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
2963         https://bugs.webkit.org/show_bug.cgi?id=29841
2964
2965         * DumpRenderTree/mac/DumpRenderTree.mm:
2966         (resetDefaultsToConsistentValues):
2967         * DumpRenderTree/win/DumpRenderTree.cpp:
2968         (resetDefaultsToConsistentValues):
2969
2970 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
2971
2972         Reviewed by Dimitri Glazkov.
2973
2974         Chromium Port - Windows
2975         https://bugs.webkit.org/show_bug.cgi?id=29969
2976
2977         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
2978         * Scripts/webkitdirs.pm:
2979
2980 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
2981
2982         Reviewed by Darin Adler.
2983
2984         jsc scripts cleanup and Qt/GTK fix
2985         https://bugs.webkit.org/show_bug.cgi?id=30288
2986
2987         Duplicated jscPath() moved to webkitdirs.pm.
2988         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
2989         Configuration added (release/debug) to path for Qt-port on Windows.
2990
2991         * Scripts/run-javascriptcore-tests:
2992         * Scripts/run-jsc:
2993         * Scripts/run-sunspider:
2994         * Scripts/sunspider-compare-results:
2995         * Scripts/webkitdirs.pm:
2996
2997 2009-10-11  Adam Barth  <abarth@webkit.org>
2998
2999         Unreviewed.  Add Collin to committers.py.
3000
3001         * Scripts/modules/committers.py:
3002
3003 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3004
3005         wx build fix, add bindings to source/include dirs now that there are sources there.
3006
3007         * wx/build/settings.py:
3008
3009 2009-10-09  Mark Rowe  <mrowe@apple.com>
3010
3011         Reviewed by Brady Eidson.
3012
3013         Enable plug-in halting in DumpRenderTree.
3014
3015         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3016         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3017
3018         * DumpRenderTree/mac/DumpRenderTree.mm:
3019         (resetDefaultsToConsistentValues):
3020         * DumpRenderTree/mac/UIDelegate.mm:
3021         (-[UIDelegate webView:shouldHaltPlugin:]):
3022
3023 2009-10-08  Brady Eidson  <beidson@apple.com>
3024
3025         Reviewed by Dan Bernstein.
3026
3027         Ask the History Delegate to populate the visited links hash.
3028         <rdar://problem/7285293> and https://webkit.org/b/29904
3029
3030         Add the ability for LayoutTestController to clear all visited links.
3031         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3032
3033         * DumpRenderTree/LayoutTestController.cpp:
3034         (LayoutTestController::LayoutTestController):
3035         (removeAllVisitedLinksCallback):
3036         (LayoutTestController::staticFunctions):
3037         * DumpRenderTree/LayoutTestController.h:
3038         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3039         (LayoutTestController::removeAllVisitedLinks):
3040
3041         * DumpRenderTree/mac/HistoryDelegate.mm:
3042         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3043
3044         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3045         (LayoutTestController::removeAllVisitedLinks):
3046         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3047         (LayoutTestController::removeAllVisitedLinks):
3048         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3049         (LayoutTestController::removeAllVisitedLinks):
3050
3051
3052 2009-10-08  Daniel Bates  <dbates@webkit.org>
3053
3054         Reviewed by Adam Roben.
3055
3056         https://bugs.webkit.org/show_bug.cgi?id=30175
3057         
3058         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3059         the OLE drag-and-drop return value like the function it emulates. Currently, 
3060         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3061         whether the drag-and-drop operation was successful or was cancelled.
3062         
3063         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3064         return value according to whether the drop operation was successful or not.
3065
3066         * DumpRenderTree/win/EventSender.cpp:
3067         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3068         (replaySavedEvents): Ditto.
3069         * DumpRenderTree/win/EventSender.h:
3070         * DumpRenderTree/win/UIDelegate.cpp:
3071         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3072
3073 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3074
3075         Reviewed by Xan Lopez.
3076
3077         [GTK] Added support for a parameter setting the button that was
3078         pressed in the mouseDown function.
3079         https://bugs.webkit.org/show_bug.cgi?id=30220
3080
3081         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3082
3083 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3084
3085         Reviewed by Xan Lopez.
3086
3087         [GTK] Added a line to the bottom of the expected result to match
3088         the output of the test.
3089         https://bugs.webkit.org/show_bug.cgi?id=30220
3090
3091         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3092         expected.txt:
3093
3094 2009-10-08  Adam Roben  <aroben@apple.com>
3095
3096         Use QueryInterface to get IWebInspectorPrivate
3097
3098         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3099         accessed in a more standard way
3100
3101         Reviewed by John Sullivan and Tim Hatcher.
3102
3103         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3104         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3105         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3106         to the IWebInspectorPrivate interface.
3107
3108 2009-10-07  Adam Roben  <aroben@apple.com>
3109
3110         Implement DRT support for origin whitelisting
3111
3112         Fixes <http://webkit.org/b/30185>.
3113
3114         Reviewed by Eric Seidel.
3115
3116         * DumpRenderTree/win/DumpRenderTree.cpp:
3117         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3118         whitelist, to match Mac DRT.
3119         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3120         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3121         IWebViewPrivate::whiteListAccessFromOrigin.
3122
3123 2009-10-07  Brady Eidson  <beidson@apple.com>
3124
3125         Reviewed by Darin Adler.
3126
3127         Send title changes to the global history delegate.
3128         <rdar://problem/7285293> and https://webkit.org/b/29904
3129
3130         * DumpRenderTree/mac/HistoryDelegate.mm:
3131         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3132
3133 2009-10-07  Adam Barth  <abarth@webkit.org>
3134
3135         Unreviewed.  Remove some folks from committers.py who were listed on
3136         the WebKit Team wiki page but who weren't actually listed as commit+.
3137         At some point, we should coorelate this list with the committers
3138         mailing list.
3139
3140         * Scripts/modules/committers.py:
3141
3142 2009-10-07  Adam Barth  <abarth@webkit.org>
3143
3144         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3145         the wiki into committers.py.
3146
3147         * Scripts/modules/committers.py:
3148
3149 2009-10-07  Adam Barth  <abarth@webkit.org>
3150
3151         Unreviewed.  Added Aaron Boodman to committers.py.
3152
3153         * Scripts/modules/committers.py:
3154
3155 2009-10-07  Evan Martin  <evan@chromium.org>
3156
3157         Reviewed by Darin Adler.
3158
3159         Add API to LayoutTestController for re/setting the system locale.
3160         https://bugs.webkit.org/show_bug.cgi?id=18994
3161
3162         * DumpRenderTree/LayoutTestController.cpp:
3163         (setLocaleCallback):
3164         (LayoutTestController::staticFunctions):
3165         (LayoutTestController::setLocale):
3166         * DumpRenderTree/LayoutTestController.h:
3167
3168 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3169
3170         Reviewed by Jan Alonzo.
3171
3172         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3173         https://bugs.webkit.org/show_bug.cgi?id=29689
3174
3175         Build fix by adding -lfontconfig for DumpRenderTree.
3176
3177         * GNUmakefile.am:
3178
3179 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3180
3181         Reviewed by Simon Hausmann.
3182
3183         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3184
3185         * Scripts/run-webkit-tests:
3186
3187 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3188
3189         Reviewed by Gustavo Noronha.
3190
3191         "delete" in EventSender is the backspace key, not the delete one.
3192
3193         * DumpRenderTree/gtk/EventSender.cpp:
3194         (keyDownCallback):
3195
3196 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3197
3198         Reviewed by Gustavo Noronha.
3199
3200         getChildrenWithRange expects as last parameter the end index, not
3201         the length of the range. Correct this and clarify the variable
3202         names to reflect how the code works.
3203
3204         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3205         (AccessibilityUIElement::getChildrenWithRange):
3206         (AccessibilityUIElement::getChildAtIndex):
3207
3208 2009-10-06  Mark Rowe  <mrowe@apple.com>
3209
3210         Reviewed by Simon Fraser.
3211
3212         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3213
3214         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3215         the fact we have already changed the working directory to the top of the open source tree.
3216
3217 2009-10-06  Julie Parent  <jparent@chromium.org>
3218
3219         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3220         rather than my committer email.
3221
3222         * Scripts/modules/committers.py:
3223
3224 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3225
3226         Reviewed by Eric Seidel.
3227
3228         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3229
3230         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3231         it after each layout test as it should do, making the DRT dump additional output
3232         for all of the subsequent layout tests.
3233
3234         * DumpRenderTree/qt/jsobjects.cpp:
3235         (LayoutTestController::reset):
3236
3237 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3238
3239         Reviewed by Simon Hausmann.
3240
3241         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3242         fast/dom/assign-to-window-status.html test, which is passing as a result.
3243
3244         https://bugs.webkit.org/show_bug.cgi?id=30127
3245
3246         * DumpRenderTree/qt/DumpRenderTree.cpp:
3247         (WebCore::DumpRenderTree::DumpRenderTree):
3248         (WebCore::DumpRenderTree::statusBarMessage):
3249         * DumpRenderTree/qt/DumpRenderTree.h:
3250         * DumpRenderTree/qt/jsobjects.h:
3251         (LayoutTestController::shouldDumpStatusCallbacks):
3252         (LayoutTestController::dumpStatusCallbacks):
3253
3254 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3255
3256         Reviewed by Simon Hausmann.
3257
3258         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3259         ignores the argument indicating which mouse button to trigger.
3260         https://bugs.webkit.org/show_bug.cgi?id=30048
3261
3262         This affects the fast/events/mouse-click-events.html layout test.
3263
3264         * DumpRenderTree/qt/jsobjects.cpp:
3265         (EventSender::mouseDown):
3266         (EventSender::mouseUp):
3267         * DumpRenderTree/qt/jsobjects.h:
3268
3269 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3270
3271         Reviewed by Simon Hausmann.
3272
3273         [Qt] Fix the EventSender::keyDown() implementation
3274         https://bugs.webkit.org/show_bug.cgi?id=30043
3275
3276         It should post both a key press event and a key release event,
3277         just like other ports do.
3278
3279         * DumpRenderTree/qt/jsobjects.cpp:
3280         (EventSender::keyDown):
3281
3282 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3283
3284         wx build fix. Add jpeg to the list of libs to link against.
3285
3286         * wx/build/settings.py:
3287
3288 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3289
3290         Reviewed by Simon Hausmann.
3291
3292         [Qt] EventSender::keyDown() cannot send function-key events.
3293         https://bugs.webkit.org/show_bug.cgi?id=30044
3294
3295         This affects the fast/events/keydown-function-keys.html layout test.
3296
3297         * DumpRenderTree/qt/jsobjects.cpp:
3298         (EventSender::keyDown):
3299
3300 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3301
3302         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3303         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3304
3305         * wx/build/settings.py:
3306         * wx/build/wxpresets.py:
3307
3308 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3309
3310         Reviewed by Timothy Hatcher.
3311
3312         Web Inspector: add testing harness for Web Inspector.
3313
3314         https://bugs.webkit.org/show_bug.cgi?id=30010
3315
3316         * DumpRenderTree/LayoutTestController.cpp:
3317         (showWebInspectorCallback):
3318         (closeWebInspectorCallback):
3319         (evaluateInWebInspectorCallback):
3320         (LayoutTestController::staticFunctions):
3321         * DumpRenderTree/LayoutTestController.h:
3322         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3323         (LayoutTestController::showWebInspector):
3324         (LayoutTestController::closeWebInspector):
3325         (LayoutTestController::evaluateInWebInspector):
3326         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3327         (LayoutTestController::showWebInspector):
3328         (LayoutTestController::closeWebInspector):
3329         (LayoutTestController::evaluateInWebInspector):
3330         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3331         (LayoutTestController::showWebInspector):
3332         (LayoutTestController::closeWebInspector):
3333         (LayoutTestController::evaluateInWebInspector):
3334         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3335         (LayoutTestController::showWebInspector):
3336         (LayoutTestController::closeWebInspector):
3337         (LayoutTestController::evaluateInWebInspector):
3338
3339 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3340
3341         Reviewed by Ariyha Hidayat.
3342
3343         Pass arguments to system() as a string instead of array
3344
3345         When passed as an array entries with a space fail to translate
3346         to two arguments to the child process, so instead of manually
3347         splitting all the entries in @buildArgs we pass the whole thing
3348         as a string instead.
3349
3350         * Scripts/webkitdirs.pm:
3351
3352 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3353
3354         Reviewed by David Levin.
3355
3356         check-webkit-style misses whitespace errors for operators:
3357         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3358         https://bugs.webkit.org/show_bug.cgi?id=30021
3359
3360         * Scripts/modules/cpp_style.py:
3361         Added the operators mentioned above to the same list as == and !=.
3362
3363 2009-10-02  Julie Parent  <jparent@chromium.org>
3364
3365         Unreviewed.
3366
3367         Adding myself and Ojan Vafai as committers, because we are committers.
3368
3369         * Scripts/modules/committers.py:
3370
3371 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3372
3373         Reviewed by Adam Roben.
3374
3375         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3376         this will help the patch merging process when TryBots are used.
3377
3378         * Scripts/svn-create-patch:
3379
3380 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3381
3382         Reviewed by Simon Hausmann.
3383
3384         [Qt] Implement layoutTestController.overridePreference().
3385         https://bugs.webkit.org/show_bug.cgi?id=29970
3386
3387         * DumpRenderTree/qt/DumpRenderTree.cpp:
3388         (WebCore::WebPage::WebPage):
3389         (WebCore::WebPage::resetSettings):
3390         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3391         * DumpRenderTree/qt/jsobjects.cpp:
3392         (LayoutTestController::reset):
3393         (LayoutTestController::setPrivateBrowsingEnabled):
3394         (LayoutTestController::setPopupBlockingEnabled):
3395         (LayoutTestController::overridePreference):
3396         * DumpRenderTree/qt/jsobjects.h:
3397
3398 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3399
3400         Reviewed by Oliver Hunt.
3401
3402         Turn on ENABLE_3D_CANVAS in TOT
3403         https://bugs.webkit.org/show_bug.cgi?id=29906
3404
3405         * Scripts/build-webkit:
3406
3407 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3408
3409         Rubberstamped by Simon Hausmann.
3410
3411         Enable HTTP tests for Qt
3412
3413         * Scripts/run-webkit-tests:
3414
3415 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3416
3417         Reviewed by Dimitri Glazkov.
3418
3419         build-webkit --chromium now also works on cygwin.
3420
3421         https://bugs.webkit.org/show_bug.cgi?id=29973
3422
3423         * Scripts/webkitdirs.pm:
3424
3425 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3426
3427         Reviewed by Simon Hausmann.
3428
3429         [Qt] Don't use TCmalloc in DumpRenderTree
3430         https://bugs.webkit.org/show_bug.cgi?id=27029
3431
3432         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3433
3434         * DumpRenderTree/qt/DumpRenderTree.pro:
3435
3436 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3437
3438         Reviewed by Simon Hausmann.
3439
3440         [Qt] Implement eventSender.scheduleAsynchronousClick().
3441
3442         https://bugs.webkit.org/show_bug.cgi?id=29931
3443
3444         * DumpRenderTree/qt/jsobjects.cpp:
3445         (EventSender::scheduleAsynchronousClick):
3446         * DumpRenderTree/qt/jsobjects.h:
3447
3448 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3449
3450         Reviewed by Simon Hausmann.
3451
3452         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3453         fast/events/open-window-from-another-frame.html from the Skipped list.
3454
3455         https://bugs.webkit.org/show_bug.cgi?id=29930
3456
3457         * DumpRenderTree/qt/jsobjects.cpp:
3458         (LayoutTestController::setPopupBlockingEnabled):
3459         * DumpRenderTree/qt/jsobjects.h:
3460
3461 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3462
3463         Unreviewed.
3464
3465         Added myself to the list of committers.
3466
3467         * Scripts/modules/committers.py:
3468
3469 2009-09-30  Eric Seidel  <eric@webkit.org>
3470
3471         No review, just adding Geoff to the list of reviewers.
3472
3473         * Scripts/modules/committers.py:
3474
3475 2009-09-30  Dan Bernstein  <mitz@apple.com>
3476
3477         Reviewed by Sam Weinig.
3478
3479         Added the WebKit Layout Tests fonts that are referenced in
3480         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3481
3482         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3483         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3484
3485 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3486
3487         Reviewed by David Kilzer.
3488
3489         Make sunspider scripts work on Windows platform.
3490         https://bugs.webkit.org/show_bug.cgi?id=29656
3491
3492         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3493         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3494         * Scripts/webkitdirs.pm: currentPerlPath() added.
3495
3496 2009-09-29  Brady Eidson  <beidson@apple.com>
3497
3498         Rubberstamped by Dan Bernstein.
3499
3500         Fix license and some sorting in new files.
3501
3502         * DumpRenderTree/mac/HistoryDelegate.h:
3503         * DumpRenderTree/mac/HistoryDelegate.mm:
3504
3505 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3506
3507         Reviewed by David Kilzer.
3508
3509         Fixed how error codes are handled.
3510         https://bugs.webkit.org/show_bug.cgi?id=29898
3511
3512         * Scripts/update-webkit:
3513         * Scripts/update-webkit-chromium:
3514
3515 2009-09-29  Brady Eidson  <beidson@apple.com>
3516
3517         Reviewed by John Sullivan.
3518
3519         Updated way-out-of-date sorting throughout the dump methods/flags.
3520
3521         * DumpRenderTree/LayoutTestController.cpp:
3522         (LayoutTestController::LayoutTestController):
3523         (dumpAsPDFCallback):
3524         (dumpAsTextCallback):
3525         (dumpFrameLoadCallbacksCallback):
3526         (dumpResourceLoadCallbacksCallback):
3527         (LayoutTestController::staticFunctions):
3528
3529         * DumpRenderTree/LayoutTestController.h:
3530         (LayoutTestController::dumpAsText):
3531         (LayoutTestController::setDumpAsText):
3532         (LayoutTestController::dumpFrameLoadCallbacks):
3533         (LayoutTestController::setDumpFrameLoadCallbacks):
3534         (LayoutTestController::dumpSelectionRect):
3535         (LayoutTestController::setDumpSelectionRect):
3536         (LayoutTestController::dumpSourceAsWebArchive):
3537         (LayoutTestController::setDumpSourceAsWebArchive):
3538         (LayoutTestController::dumpStatusCallbacks):
3539         (LayoutTestController::setDumpStatusCallbacks):
3540         (LayoutTestController::dumpTitleChanges):
3541         (LayoutTestController::setDumpTitleChanges):
3542         (LayoutTestController::dumpWillCacheResponse):
3543         (LayoutTestController::setDumpWillCacheResponse):
3544
3545 2009-09-29  Brady Eidson  <beidson@apple.com>
3546
3547         Reviewed by John Sullivan.
3548
3549         WebKit Mac API should provide a delegate interface for global history.
3550         <rdar://problem/7042773> and https://webkit.org/b/29904
3551
3552         Adding the dumping of global history delegate callbacks.
3553
3554         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3555
3556         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3557         * DumpRenderTree/mac/DumpRenderTree.mm:
3558         (createWebViewAndOffscreenWindow):
3559         (allocateGlobalControllers):
3560         (shouldLogFrameLoadDelegates):
3561         (shouldLogHistoryDelegates):
3562         (runTest):
3563
3564         Dump history delegate callbacks:
3565         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3566         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3567         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3568         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3569         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3570
3571 2009-09-29  Daniel Bates  <dbates@webkit.org>
3572
3573         Reviewed by Adam Roben.
3574
3575         https://bugs.webkit.org/show_bug.cgi?id=28902
3576         
3577         Fixes an issue where the drop effect returned by Window Dump Render Tree 
3578         was always DROPEFFECT_NONE (since it was hard coded to do so).
3579         
3580         This patch corrects this issue by determining the actual drop effect 
3581         performed by the corresponding drag-and-drop operation so that we can 
3582         return it.
3583
3584         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3585         (DraggingInfo::DraggingInfo):
3586         (DraggingInfo::performedDropEffect): Added method.
3587         (DraggingInfo::setPerformedDropEffect): Added method.
3588         * DumpRenderTree/win/EventSender.cpp:
3589         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3590         Moved delete draggingInfo to UIDelegate::doDragDrop.
3591         * DumpRenderTree/win/UIDelegate.cpp:
3592         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3593
3594 2009-09-29  Dan Bernstein  <mitz@apple.com>
3595
3596         Reviewed by Adam Roben.
3597
3598         Remove copying of unnecessary or nonexistent files from the ImageDiff
3599         post-build event.
3600
3601         * DumpRenderTree/win/ImageDiff.vcproj:
3602
3603 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3604
3605         Reviewed by David Kilzer.
3606
3607         [Qt] Make build-webkit script work on Windows
3608         https://bugs.webkit.org/show_bug.cgi?id=29802
3609
3610         * Scripts/run-webkit-tests:
3611         * Scripts/webkitdirs.pm:
3612          - Removed unnecessary -p switch for mkdir on Windows.
3613          - Use canonical path, which uses slashes or backslashes depends on platform.
3614          - isWindows() only test for Windows and not for Cyqwin.
3615
3616 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3617
3618         Reviewed by Simon Hausmann.
3619
3620         Fix time measurement in build-webkit after refactoring done in r48853.
3621
3622         * Scripts/build-webkit:
3623
3624 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3625
3626         Reviewed by Tor Arne Vestbø.
3627
3628         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
3629         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
3630
3631         * DumpRenderTree/qt/DumpRenderTree.cpp:
3632         (WebCore::WebPage::WebPage):
3633
3634 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
3635
3636         Reviewed by Simon Hausmann.
3637
3638         [Qt] Implement eventSender.contextClick().
3639         https://bugs.webkit.org/show_bug.cgi?id=29821
3640
3641         * DumpRenderTree/qt/jsobjects.cpp:
3642         (EventSender::contextClick):
3643         * DumpRenderTree/qt/jsobjects.h:
3644
3645 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3646
3647         Reviewed by Eric Seidel.
3648
3649         Add experimentalWebSocketsEnabled in WebPreferences.
3650         https://bugs.webkit.org/show_bug.cgi?id=28941
3651
3652         * DumpRenderTree/mac/DumpRenderTree.mm:
3653         (resetDefaultsToConsistentValues):
3654         * DumpRenderTree/win/DumpRenderTree.cpp:
3655         (resetDefaultsToConsistentValues):
3656
3657 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
3658
3659         Reviewed by David Kilzer.
3660
3661         Integrated chromium port building into webkit tools update-webkit and
3662         build-webkit.
3663
3664         https://bugs.webkit.org/show_bug.cgi?id=29749
3665
3666         * Scripts/build-webkit: When --chromium is specified, will build
3667           the chromium port (currently only Mac is supported).
3668         * Scripts/update-webkit: When --chromium is specified, delegates to
3669           update-webkit-chromium.
3670         * Scripts/webkitdirs.pm: Added chromium specific defs.
3671         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
3672           chromium port's dependencies and update its project files.
3673
3674 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3675
3676         Unreviewed.
3677
3678         Add myself to list of committers.
3679
3680         * Scripts/modules/committers.py:
3681
3682 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3683
3684         Reviewed by Darin Adler.
3685
3686         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
3687         https://bugs.webkit.org/show_bug.cgi?id=29771
3688
3689         * Scripts/run-webkit-tests:
3690
3691 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3692
3693         Reviewed by Simon Hausmann.
3694
3695         [Qt] Implement layoutTestController.waitForPolicyDelegate.
3696         https://bugs.webkit.org/show_bug.cgi?id=25037