Reviewed by Maciej.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-02  Alice Liu  <alice.liu@apple.com>
2
3         Reviewed by Maciej.
4
5         Added handling for page up and page down in EventSender
6
7         * DumpRenderTree/mac/EventSendingController.mm:
8         (-[EventSendingController keyDown:withModifiers:]):
9         * DumpRenderTree/win/EventSender.cpp:
10         (keyDownCallback):
11
12 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
13
14         Reviewed by Darin.
15
16         Fix fast/events/arrow-keys-on-body.html for real.
17
18         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
19
20 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
21
22         Reviewed by Darin.
23
24         http://bugs.webkit.org/show_bug.cgi?id=16674
25         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
26
27         * Scripts/run-launcher:
28
29 2007-12-31  Darin Adler  <darin@apple.com>
30
31         Suggested by Antti.
32
33         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
34         we get it installed on the build bots.
35
36 2007-12-30  Eric Seidel  <eric@webkit.org>
37
38         Reviewed by Sam.
39
40         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
41
42 2007-12-29  Darin Adler  <darin@apple.com>
43
44         Reviewed by Oliver.
45
46         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
47           leak bot shows createCStringFromNPVariant result leaking
48
49         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
50         (pluginInvoke): Added a missing free.
51
52 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
53
54         Reviewed by Alp Toker.
55
56         http://bugs.webkit.org/show_bug.cgi?id=16390
57         Use autotools or GNU make as the build system for the GTK port
58
59         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
60         * GNUmakefile.am: Added.
61
62 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
63
64         Reviewed by Oliver.
65
66         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
67
68         * DumpRenderTree/win/EventSender.cpp:
69         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
70         of 1, even though WebKit currently ignores it.
71
72 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
73
74         wx buildbot fix. Update libpng dl script to the latest version.
75
76         * wx/install-unix-extras:
77
78 2007-12-22  Antti Koivisto  <antti@apple.com>
79
80         Fix a typo.
81
82         * Scripts/webkitdirs.pm:
83
84 2007-12-21  Sam Weinig  <sam@webkit.org>
85
86         Reviewed by Mark Rowe.
87
88         - Disable the back/forward cache using the new WebPreferences API
89           instead of through the BackForwardList.  This makes us match what
90           we do on Windows.
91
92         * DumpRenderTree/mac/DumpRenderTree.mm:
93         (createWebViewAndOffscreenWindow):
94         (setDefaultsToConsistentValuesForTesting):
95
96 2007-12-21  Dan Bernstein  <mitz@apple.com>
97
98         Reviewed by Mark Rowe.
99
100         - disable the back/forward cache in Windows DumpRenderTree. It is
101           already disabled in Mac DumpRenderTree.
102
103         * DumpRenderTree/win/DumpRenderTree.cpp:
104         (initializePreferences):
105
106 2007-12-13  Antti Koivisto  <antti@apple.com>
107
108         Reviewed by Darin and Steve.
109         
110         - check for QuickTime SDK on Windows.
111         - build media support on Windows by default
112
113         * Scripts/build-webkit:
114         * Scripts/webkitdirs.pm:
115
116 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
117
118         Build script fix for buildbot.
119
120         * wx/build-wxwebkit:
121
122 2007-12-20  Eric Seidel  <eric@webkit.org>
123
124         Reviewed by mjs.
125
126         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
127
128 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
129
130         Reviewed by Steve.
131
132         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
133         WebKit.
134
135         - Drosera and Safari need to use the same ProgIDs in order for
136         CoCreateInstance to work properly.  The most robust way to do this is
137         for WebKit to dynamically publish those ProgIDs.
138
139         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
140         (DebuggerClient::createWebViewWithRequest):
141         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
142         statics.
143         (Drosera::initUI):
144         (Drosera::attach):
145         (Drosera::attemptToCreateServerConnection):
146         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
147         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
148         make use of the published ProgIDs.
149         (ServerConnection::attemptToCreateServerConnection):
150
151 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
152
153         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
154         - Build bot and leak fix.
155
156         * DumpRenderTree/LayoutTestController.cpp:
157         (pathToLocalResourceCallback):
158
159 2007-12-19  David Kilzer  <ddkilzer@apple.com>
160
161         Make svn-apply/svn-unapply work with patches from git-format-patch.
162
163         Reviewed by Darin.
164
165         * Scripts/svn-apply:
166         (patch): If 'Index:' can't be found in the text passed in, print it
167         out with a warning and return early.
168         * Scripts/svn-unapply:
169         (patch): Ditto.
170
171 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
172
173         Reviewed by Alp Toker.
174
175         Build related fixes.
176
177         * wx/build-wxwebkit:
178         - Check to make sure the user is running a supported wx port
179         - More robust checks for Cygwin
180         - Only run install-unix-extras on Mac, it's not the right solution
181           for Linux distros.
182         - Remove outdated Linux instructions after successful build
183         - Clean Bakefile-generated files during a clean operation
184
185 2007-12-18  Darin Adler  <darin@apple.com>
186
187         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
188
189 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
190
191         Add script to run Drosera as part of the nightly.
192         
193         Reviewed by Kevin M.
194
195         * Scripts/run-drosera.cmd: Added.
196
197 2007-12-18  Darin Adler  <darin@apple.com>
198
199         * Scripts/do-webcore-rename: Remove a stray K.
200
201 2007-12-18  Darin Adler  <darin@apple.com>
202
203         * Scripts/do-webcore-rename: Plan more renaming.
204
205 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
206
207         Reviewed by Alp Toker.
208
209         http://bugs.webkit.org/show_bug.cgi?id=16042
210         [GTK] Eliminate webkit_init()
211
212         Moving webkit initialization to WebView class init.
213
214         * DumpRenderTree/gtk/DumpRenderTree.cpp:
215         (main):
216         * GtkLauncher/main.c:
217         (main):
218
219 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
220
221         Reviewed by Alp Toker.
222
223         http://bugs.webkit.org/show_bug.cgi?id=13542
224         gdklauncher doesnt change URL in adress GTKEntry.
225
226         * GtkLauncher/main.c:
227         (load_commit_cb): added
228         (title_change_cb):
229         (create_browser):
230
231 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
232
233         Reviewed by Adam Roben.
234
235         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
236
237         * FindSafari/FindSafari.cpp:
238         (_tmain):
239
240 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
241
242         Reviewed by Adam Roben.
243
244         http://bugs.webkit.org/show_bug.cgi?id=16315
245         FindSafari needs a path-only option.
246
247         * FindSafari/FindSafari.cpp:
248         (_tmain):
249
250 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
251
252         Reviewed by Darin.
253
254         http://bugs.webkit.org/show_bug.cgi?id=16462
255         REGRESSION: access keys broken on Windows
256
257         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
258         if Alt is pressed.
259
260 2007-12-15  Sam Weinig  <sam@webkit.org>
261
262         Reviewed by Mark Rowe.
263
264         Fix urlSuitableForTestResult to correctly identify wstring::npos as
265         the case when wstring.find doesn't find anything.
266
267         * DumpRenderTree/win/DumpRenderTree.cpp:
268         (urlSuitableForTestResult):
269
270 2007-12-15  Alp Toker  <alp@atoker.com>
271
272         GTK+ DRT build fix for GLib < 2.14.
273
274         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
275         (LayoutTestController::setWaitToDump):
276
277 2007-12-05  Mark Rowe  <mrowe@apple.com>
278
279         Reviewed by Alp Toker.
280
281         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
282         many layout tests from hanging while waiting on user responses to dialogs.
283
284         * DumpRenderTree/gtk/DumpRenderTree.cpp:
285         (invalidateAnyPreviousWaitToDumpWatchdog):
286         (webViewScriptAlert):
287         (webViewScriptPrompt):
288         (webViewScriptConfirm):
289         (main):
290         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
291         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
292         (waitToDumpWatchdogFired):
293         (LayoutTestController::setWaitToDump):
294
295 2007-12-05  Mark Rowe  <mrowe@apple.com>
296
297         Reviewed by Alp Toker.
298
299         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
300
301         * DumpRenderTree/gtk/DumpRenderTree.cpp:
302         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
303         (dump):
304         (runTest):
305         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
306         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
307         work queue is empty.
308         (webViewWindowObjectCleared): Set up window.layoutTestController.
309         (webViewConsoleMessage): Match the console message format expected by the layout test results.
310         (main): Hook up the new signals.
311         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
312         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
313         dumping multiple times.
314         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
315         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
316
317 2007-12-14  Anders Carlsson  <andersca@apple.com>
318
319         Reviewed by Brady.
320
321         Assert that a web frame that's loading a resource always has either a data source or 
322         a provisional data source.
323         
324         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
325         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
326
327 2007-12-14  Darin Adler  <darin@apple.com>
328
329         - fix mistake causing nearly all tests to fail on Windows
330
331         * DumpRenderTree/win/UIDelegate.cpp:
332         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
333         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
334
335         * DumpRenderTree/mac/UIDelegate.mm:
336         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
337         than passing the entire message.
338
339 2007-12-14  Darin Adler  <darin@apple.com>
340
341         - fix Tiger build
342
343         * DumpRenderTree/mac/UIDelegate.mm:
344         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
345         new-to-Leopard methods.
346
347 2007-12-14  Darin Adler  <darin@apple.com>
348
349         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
350         since it now triggers unwanted icon loading. We only had it because we implemented "all"
351         delegate methods here.
352
353 2007-12-14  Anders Carlsson  <andersca@apple.com>
354
355         Reviewed by Darin and Geoff.
356
357         <rdar://problem/5619295> 
358         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
359         
360         Add property getting methods to the plug-in.
361         
362         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
363         (pluginInvoke):
364
365 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
366
367         Reviewed by Darin.
368
369         - Layout test fix for mac. When dumped to the console local file paths
370         now only show the name of the resource not the whole path.  This is to
371         make the results machine and OS independent.
372
373         * DumpRenderTree/mac/UIDelegate.mm:
374         (-[UIDelegate webView:addMessageToConsole:]):
375
376 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
377
378         Reviewed by Adam.
379
380         - Layout tests fix.  We need a way to remove machine-dependent
381         information from paths in layout test results. The UIDelegate now does
382         this.
383
384         * DumpRenderTree/DumpRenderTree.h:
385         * DumpRenderTree/win/DumpRenderTree.cpp:
386         (urlSuitableForTestResult):
387         * DumpRenderTree/win/DumpRenderTreeWin.h:
388         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
389         * DumpRenderTree/win/UIDelegate.cpp:
390         (UIDelegate::webViewAddMessageToConsole):
391
392 2007-12-13  Alp Toker  <alp@atoker.com>
393
394         Build fix for DRT breakage introduced in r28690.
395
396         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
397         (LayoutTestController::pathToLocalResource):
398
399 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
400
401         Reviewed by Alice and Sam.
402
403         - <rdar://5621435> Need a way to specify local resources (being loaded
404         from HTTP tests) on Windows.
405         - Implemented pathToLocalResource which exposes the functionality of
406         converting a given unix path to the correct location on Windows.
407
408         * DumpRenderTree/LayoutTestController.cpp:
409         (pathToLocalResourceCallback):
410         (LayoutTestController::staticFunctions):
411         * DumpRenderTree/LayoutTestController.h:
412         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
413         (LayoutTestController::pathToLocalResource):
414         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
415         (LayoutTestController::pathToLocalResource):
416
417 2007-12-12  Anders Carlsson  <andersca@apple.com>
418
419         Reviewed by Sam.
420
421         <rdar://problem/5132003>
422         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
423
424         * DumpRenderTree/win/DumpRenderTree.cpp:
425         (main):
426         Set the resource load delegate.
427         
428         * DumpRenderTree/win/DumpRenderTree.vcproj:
429         
430         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
431         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
432
433 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
434
435         Reviewed by Adam Roben.
436
437         Fix conversion from double to LPARAM in dispatchMessage().
438
439         * DumpRenderTree/win/EventSender.cpp:
440         (dispatchMessageCallback):
441
442 2007-12-11  Dan Bernstein  <mitz@apple.com>
443
444         Reviewed by Mark Rowe and Sam Weinig too!
445
446         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
447           fonts DumpRenderTree registers.
448
449         * DumpRenderTree/win/DumpRenderTree.cpp:
450         (initialize):
451
452 2007-12-11  Brady Eidson  <beidson@apple.com>
453
454         Reviewed by Anders
455
456         Make DumpRenderTree on mac use its own path for Databases testing
457
458         * DumpRenderTree/mac/DumpRenderTree.mm:
459         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
460           for future DRT-only use, then use it to construct the Databases path and set that default
461
462 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
463
464         Reviewed by Darin.
465
466         <rdar://problem/5535636>
467         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
468
469         http://bugs.webkit.org/show_bug.cgi?id=13916
470         JavaScript detects Tab as a character input on a textfield validation
471
472         * DumpRenderTree/mac/EventSendingController.mm:
473         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
474         Dispatch a keyup to better match what happens when a key is physically pressed.
475
476         * DumpRenderTree/win/EventSender.cpp:
477         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
478         returning from keyDown().
479         (getConstantCallback): Fixed a couple copy/paste mistakes.
480
481 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
482
483         Reviewed by Oliver.
484
485         - <rdar://5599845> Drosera: Does not show loal files in the file list
486         on the left side.
487
488         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
489         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
490         so the open source community can build.
491
492 2007-12-10  Brady Eidson  <beidson@apple.com>
493
494         Rubberstamped by Sam Weinig
495
496         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
497
498         * DumpRenderTree/mac/UIDelegate.mm:
499         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
500         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
501
502 2007-12-08  Oliver Hunt  <oliver@apple.com>
503
504         Reviewed by Sam W.
505
506         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
507         
508         Fixes <rdar://problem/5620249> Must disable SVG animation
509         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
510         
511         In order to allow finer grained control over the set of SVG features
512         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
513         distinct flags:
514         ENABLE_SVG_ANIMATION
515         ENABLE_SVG_FILTERS
516         ENABLE_SVG_FONTS
517         ENABLE_SVG_AS_IMAGE
518         ENABLE_SVG_USE
519         
520         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
521         
522         Script handles all the new build flags, and allows --svg-experimental
523         to automatically enable all features.
524
525         * Scripts/build-webkit:
526
527 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
528
529         Fix version parsing.
530
531         Rubber-stamped by Oliver.
532
533         * Drosera/win/Drosera.vcproj/auto-version.sh:
534
535 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
536
537         Build modifications for Drosera.
538
539         Reviewed by Adam.
540
541         * Drosera/DroseraWin.make: Added.
542         * Drosera/win/Drosera.vcproj/Drosera.rc:
543         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
544         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
545         * Drosera/win/Drosera.vcproj/VERSION: Added.
546         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
547
548 2007-12-06  Adam Roben  <aroben@apple.com>
549
550         Explicitly turn on the Mac font ascent hack on Windows
551
552         This keeps our font metrics matching those from Mac.
553
554         Reviewed by Hyatt.
555
556         * DumpRenderTree/win/DumpRenderTree.cpp:
557         (main):
558
559 2007-12-06  Anders Carlsson  <andersca@apple.com>
560
561         Rename main.c to main.cpp here too.
562         
563         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
564
565 2007-12-06  Sam Weinig  <sam@webkit.org>
566
567         Rubber stamped by Geoff.
568
569         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
570
571 2007-12-06  Darin Adler  <darin@apple.com>
572
573         * Scripts/do-webcore-rename: Some more renaming plans.
574
575 2007-12-06  Anders Carlsson  <andersca@apple.com>
576
577         Restore implementation of testGetIntIdentifier that was accidentally
578         removed somehow (possibly when I made PluginObject be a cpp file).
579         
580         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
581         (pluginInvoke):
582
583 2007-12-05  Anders Carlsson  <andersca@apple.com>
584
585         Make the entry points extern "C".
586         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
587         
588 2007-12-05  Anders Carlsson  <andersca@apple.com>
589
590         C++ warning fixes.
591         
592         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
593         (NPP_New):
594         (NPP_Destroy):
595         (NPP_SetWindow):
596         (NPP_NewStream):
597         (NPP_HandleEvent):
598         (NPP_URLNotify):
599         (NPP_GetValue):
600
601 2007-12-05  Anders Carlsson  <andersca@apple.com>
602
603         Add the .cpp files to the TestNetscapePlugIn target.
604
605         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
606
607 2007-12-05  Anders Carlsson  <andersca@apple.com>
608
609         Reviewed by Geoff.
610         
611         Rename the TestNetscapePlugIn .c files to be .cpp.
612
613         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
614         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
615         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
616         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
617         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
618         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
619         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
620         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
621
622 2007-12-05  Adam Roben  <aroben@apple.com>
623
624         Fix case of keypresses from the Windows implementation of eventSender.keyDown
625
626         This fixes several regression tests.
627
628         Reviewed by Alice.
629
630         * DumpRenderTree/win/EventSender.cpp:
631         (keyDownCallback): Virtual keycodes for ASCII characters are always
632         uppercase, so we need to check the case of the original character
633         passed in to eventSender.keyDown.
634
635 2007-12-05  Adam Roben  <aroben@apple.com>
636
637         Learn from Tim's mistakes
638
639         * DumpRenderTree/win/DumpRenderTree.cpp:
640         (runTest): Reset the authorAndUserStylesEnabled preference for each
641         test.
642
643 2007-12-05  Alp Toker  <alp@atoker.com>
644
645         Reviewed by Mark Rowe.
646
647         Initialize GTK+ and WebKit so the tests can run.
648
649         Reorganize the headers a little.
650
651         * DumpRenderTree/gtk/DumpRenderTree.cpp:
652         (main):
653
654 2007-12-04  Anders Carlsson  <andersca@apple.com>
655
656         Remove IWebScriptScope include.
657         
658         * Drosera/win/DebuggerDocumentPlatform.cpp:
659
660 2007-12-04  Sam Weinig  <sam@webkit.org>
661
662         Rubber stamped by Mark Rowe.
663
664         Define CF as platform for mac and revert r28409
665
666         * DumpRenderTree/DumpRenderTree.h:
667         * DumpRenderTree/mac/DumpRenderTreeMac.h:
668
669 2007-12-04  Sam Weinig  <sam@webkit.org>
670
671         Define CF as platform for windows.
672
673         Reviewed by Adam Roben.
674
675         * DumpRenderTree/win/DumpRenderTreeWin.h:
676
677 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
678
679         Reviewed by Adam and Darin.
680
681         - Removed a needless BSTR cleanup.
682
683         * Drosera/win/DebuggerDocumentPlatform.cpp:
684         (DebuggerDocument::getPlatformCurrentFunctionStack):
685
686 2007-11-27  Adam Roben  <aroben@apple.com>
687
688         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
689
690         Reviewed by Maciej.
691
692         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
693         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
694
695 2007-12-04  Alp Toker  <alp@atoker.com>
696
697         Prospective Win DRT build fix.
698
699         * DumpRenderTree/DumpRenderTree.h:
700
701 2007-12-04  Alp Toker  <alp@atoker.com>
702
703         Fix a clobbered copyright header.
704
705         * DumpRenderTree/gtk/DumpRenderTree.cpp:
706
707 2007-12-04  Xan Lopez  <xan@gnome.org>
708
709         Reviewed by Alp Toker.
710
711         http://bugs.webkit.org/show_bug.cgi?id=15561
712         GTK port needs DumpRenderTree implementation
713
714         Start work on the GTK+ DRT.
715
716         This does not work yet, and there are a few lingering style issues
717         (nothing major) but this patch has been stuck in the bug tracker for
718         too long already.
719
720         * DumpRenderTree/DumpRenderTree.h:
721         * DumpRenderTree/gtk: Added.
722         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
723         (autocorrectURL):
724         (shouldLogFrameLoadDelegates):
725         (dumpFrameScrollPosition):
726         (displayWebView):
727         (appendString):
728         (dumpFramesAsText):
729         (dumpRenderTreeAsText):
730         (dump):
731         (runTest):
732         (main):
733         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
734         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
735         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
736         (GCController::collect):
737         (GCController::collectOnAlternateThread):
738         (GCController::getJSObjectCount):
739         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
740         (LayoutTestController::~LayoutTestController):
741         (LayoutTestController::addDisallowedURL):
742         (LayoutTestController::clearBackForwardList):
743         (LayoutTestController::copyDecodedHostName):
744         (LayoutTestController::copyEncodedHostName):
745         (LayoutTestController::display):
746         (LayoutTestController::keepWebHistory):
747         (LayoutTestController::notifyDone):
748         (LayoutTestController::queueBackNavigation):
749         (LayoutTestController::queueForwardNavigation):
750         (LayoutTestController::queueLoad):
751         (LayoutTestController::queueReload):
752         (LayoutTestController::queueScript):
753         (LayoutTestController::setAcceptsEditing):
754         (LayoutTestController::setCustomPolicyDelegate):
755         (LayoutTestController::setMainFrameIsFirstResponder):
756         (LayoutTestController::setTabKeyCyclesThroughElements):
757         (LayoutTestController::setUseDashboardCompatibilityMode):
758         (LayoutTestController::setUserStyleSheetEnabled):
759         (LayoutTestController::setUserStyleSheetLocation):
760         (LayoutTestController::setWindowIsKey):
761         (LayoutTestController::setWaitToDump):
762         (LayoutTestController::windowCount):
763         (LayoutTestController::setPrivateBrowsingEnabled):
764         (LayoutTestController::setAuthorAndUserStylesEnabled):
765         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
766         (JSStringCopyUTF8CString):
767         (LoadItem::invoke):
768         (ReloadItem::invoke):
769         (ScriptItem::invoke):
770         (BackForwardItem::invoke):
771
772 2007-12-03  Sam Weinig  <sam@webkit.org>
773
774         Move JavaScriptCore thread testing code to pthread specific directory
775         and remove the dependance on CoreFoundation by using WTF::HashSet.
776
777         Reviewed by Geoff and Oliver.
778
779         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
780         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
781         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
782         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
783         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
784         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
785         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
786         * DumpRenderTree/pthreads: Added.
787         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
788         (javaScriptThreads):
789         (runJavaScriptThread):
790         (startJavaScriptThreads):
791         (stopJavaScriptThreads):
792
793 2007-12-03  Andrew Bonventre  <andybons@google.com>
794
795         Reviewed by Darin Adler.
796
797         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
798         Symbol lookup menu broken in debugger view
799
800         * Drosera/debugger.js: Fixed javascript error where document property
801         should have been used instead of contentDocument in switchFunction that
802         was breaking the select symbol dropdown menu.  This is because
803         window.frames will return a Window object and not a frame object like
804         the author was originally expecting.
805
806 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
807
808         Reviewed by Adam.
809
810         - <rdar://5618942> Drosera: Console window does not process everything
811         correctly.
812         - <rdar://5619005> Drosera: could be sped up by moving the 
813         WebScriptScope stuff into the WebScriptCallFrame.
814         - Now the console can correctly process objects and does not receive
815         notifications from JavaScriptCore about the JavaScript in Drosera's
816         own process.
817
818         * Drosera/win/DebuggerDocumentPlatform.cpp:
819         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
820         (DebuggerDocument::platformValueForScopeVariableNamed):
821
822 2007-12-03  Stephanie  <slewis@apple.com>
823
824         Reviewed by Darin.
825
826         Check to see if we are building a debug root
827
828         * Scripts/check-for-global-initializers: 
829
830 2007-12-03  Dan Bernstein  <mitz@apple.com>
831
832         Reviewed by Darin Adler.
833
834         - added a testGetIntIdentifier() method to TestNetscapePlugIn
835
836         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
837         (pluginInvoke):
838
839 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
840
841         Reviewed by Oliver.
842
843         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
844         in a more fine-grained manner than eventSender.keyDown().
845
846         * DumpRenderTree/win/EventSender.cpp:
847         (getConstantCallback):
848         (dispatchMessageCallback):
849
850 2007-12-02  Darin Adler  <darin@apple.com>
851
852         * Scripts/do-webcore-rename: More planned renaming.
853
854 2007-12-02  Sam Weinig  <sam@webkit.org>
855
856         Rubber stamped by Anders.
857
858         Use [NSURL absoluteString] instead of [NSURL description] in order to get
859         more uniform results cross platform.
860
861         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
862         (-[NSURL _drt_descriptionSuitableForTestResult]):
863
864 2007-12-02  Sam Weinig  <sam@webkit.org>
865
866         Rubber stamped by Niko.
867
868         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
869
870         * DumpRenderTree/win/DumpRenderTree.cpp:
871         * DumpRenderTree/win/DumpRenderTree.vcproj:
872         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
873         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
874         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
875         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
876
877 2007-12-01  Alp Toker  <alp@atoker.com>
878
879         Reviewed by Adam Roben.
880
881         Make use of the newly introduced webkit.h convenience header.
882
883         * GtkLauncher/main.c:
884
885 2007-12-01  Adam Treat  <treat@kde.org>
886
887         Reviewed by Simon.
888
889         * Check to see if the directory exists and exit if not.
890
891         * DumpRenderTree/qt/main.cpp:
892         (main):
893
894 2007-12-01  Adam Treat  <treat@kde.org>
895
896         Reviewed by Simon.
897
898         * Don't hide symbols when in Debug mode
899         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
900
901
902         * DumpRenderTree/qt/main.cpp:
903         (messageHandler):
904
905 2007-11-30  Alp Toker  <alp@atoker.com>
906
907         Reviewed by Adam Roben.
908
909         http://bugs.webkit.org/show_bug.cgi?id=15691
910         [GTK] Public API does not follow GTK+ conventions
911
912         Refactor the WebKit/GTK+ public API. Changes:
913           WebKitPage -> WebKitWebView
914           WebKitFrame -> WebKitWebFrame
915
916         Public API source and header names have been updated to mirror the API
917         changes.
918
919         The API is now kept in WebKit/gtk/WebView to match other ports in the
920         same class such as Mac and Win.
921
922         * GtkLauncher/main.c:
923         (activate_uri_entry_cb):
924         (link_hover_cb):
925         (title_change_cb):
926         (progress_change_cb):
927         (go_back_cb):
928         (go_forward_cb):
929         (create_browser):
930         (main):
931
932 2007-11-30  Adam Roben  <aroben@apple.com>
933
934         Hopefully the final build fix
935
936         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
937         pull in WTF's assertion/logging functions.
938
939 2007-11-30  Adam Roben  <aroben@apple.com>
940
941         Another build fix
942
943         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
944         WebKit.lib.
945
946 2007-11-30  Adam Roben  <aroben@apple.com>
947
948         Debug build fix
949
950         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
951         configuration.
952         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
953         projects.
954         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
955         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
956         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
957
958 2007-11-30  Sam Weinig  <sam@webkit.org>
959
960         Reviewed by Adam Roben.
961
962         Fix drawSelectionRect to actually draw the selection rect.
963
964         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
965         (drawSelectionRect):
966
967 2007-11-30  Darin Adler  <darin@apple.com>
968
969         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
970
971 2007-11-30  Darin Adler  <darin@apple.com>
972
973         * Scripts/do-webcore-rename: Get ready for some future renaming.
974
975 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
976
977         Reviewed by Adam.
978
979         - Removed some unnecessary functions and changed an unused return type. 
980
981         * Drosera/win/DebuggerClient.cpp:
982         (registerConsoleClass):
983         * Drosera/win/DebuggerClient.h:
984         * Drosera/win/Drosera.cpp:
985         (registerDroseraClass):
986
987 2007-11-28  Alp Toker  <alp@atoker.com>
988
989         Reviewed by Timothy Hatcher.
990
991         http://bugs.webkit.org/show_bug.cgi?id=16174
992         [GTK] Use "URI" not "URL" in public API
993
994         Replace use of the term "URL" with "URI" in public headers,
995         documentation and some internal code to match GLib/GTK+ convention.
996
997         This is now mentioned in the API guidelines:
998           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
999
1000         * GtkLauncher/main.c:
1001         (activate_uri_entry_cb):
1002         (title_change_cb):
1003         (create_toolbar):
1004         (main):
1005
1006 2007-11-29  Anders Carlsson  <andersca@apple.com>
1007
1008         Reviewed by Sam.
1009
1010         <rdar://problem/5230478>
1011         FrameLoadDelegate callbacks are not dumped in DRT.
1012         
1013         * DumpRenderTree/win/DumpRenderTree.cpp:
1014         (shouldLogFrameLoadDelegates):
1015         (runTest):
1016         (main):
1017         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1018         (BSTRtoString):
1019         (descriptionSuitableForTestResult):
1020         (FrameLoadDelegate::QueryInterface):
1021         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1022         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1023         (FrameLoadDelegate::didCommitLoadForFrame):
1024         (FrameLoadDelegate::didFinishLoadForFrame):
1025         (FrameLoadDelegate::willCloseFrame):
1026         (FrameLoadDelegate::didClearWindowObject):
1027         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1028         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1029         * DumpRenderTree/win/FrameLoaderDelegate.h:
1030         (FrameLoadDelegate::windowScriptObjectAvailable):
1031         (FrameLoadDelegate::didFirstLayoutInFrame):
1032
1033 2007-11-29  Sam Weinig  <sam@webkit.org>
1034
1035         Reviewed by Anders.
1036
1037         Add database quota UIDelegates methods to DRT UIDelegate.
1038
1039         * DumpRenderTree/mac/UIDelegate.mm:
1040         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1041         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1042
1043 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1044
1045         Reviewed by Sam.
1046
1047         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1048         dying and vice versa.
1049         - This fix will allow Drosera and Safari to reconnect if either of them
1050         closes correctly, but does not fix the case where one of them dies
1051         silently.
1052
1053         * Drosera/win/ServerConnection.cpp:
1054         (ServerConnection::attemptToCreateServerConnection): Added a safety
1055         check, because it's possilbe to try to connect to a server that's dying.
1056         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1057         the server has died.
1058         * Drosera/win/ServerConnection.h: Added the new function and removed
1059         an unnecessary member.
1060
1061 2007-11-29  Anders Carlsson  <andersca@apple.com>
1062
1063         * DumpRenderTree/win/DumpRenderTree.vcproj:
1064         Add shlwapi.lib to all configurations.
1065
1066 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1067
1068         - Build fix.  Added additional includes for VS Express to the Release
1069         project.
1070
1071         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1072
1073 2007-11-29  Anders Carlsson  <andersca@apple.com>
1074
1075         Reviewed by Adam.
1076
1077         <rdar://problem/5132005>
1078         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1079         
1080         * DumpRenderTree/win/DumpRenderTree.vcproj:
1081         Add shlwapi.lib
1082         
1083         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1084         (LayoutTestController::setUserStyleSheetEnabled):
1085         Implement this.
1086         
1087         (appendComponentToPath):
1088         New method which wraps the Win32 API PathAppend.
1089         
1090         (followShortcuts):
1091         New method which checks if a file points to a shortcut and
1092         follows the shortcut.
1093         
1094         (resolveCygwinPath):
1095         New method that takes a cygwin unix-style path and returns the Win32 path.
1096         
1097         (cfStringRefToWString):
1098         
1099         (LayoutTestController::setUserStyleSheetLocation):
1100         Implement this.
1101
1102 2007-11-29  Alice Liu  <alice.liu@apple.com>
1103
1104         Reviewed by Adam.
1105
1106         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1107
1108         * DumpRenderTree/win/EventSender.cpp:
1109         (keyDownCallback):
1110         uppercase letters were being sent as lowercase letters without the shift key down.
1111
1112 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1113
1114         - Windows build fix. VS express needs some love.
1115
1116         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1117
1118 2007-11-28  Darin Adler  <darin@apple.com>
1119
1120         Reviewed by Adam Roben.
1121
1122         * DumpRenderTree/mac/EventSendingController.mm:
1123         (-[EventSendingController keyDown:withModifiers:]):
1124         Send capital letters through as lowercase letters with the shift key down
1125         rather than sending them as if they were highly unusual "capital letter keys".
1126
1127         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1128         where you need to update results and more tests are failing than before.
1129
1130 2007-11-28  Anders Carlsson  <andersca@apple.com>
1131
1132         Reviewed by Darin.
1133
1134         <rdar://problem/5132001>
1135         contextClick is not implemented in DRT on Windows.
1136         
1137         * DumpRenderTree/win/EventSender.cpp:
1138         (contextClickCallback):
1139         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1140         by a WM_RBUTTONUP message.
1141         
1142         * DumpRenderTree/win/UIDelegate.cpp:
1143         (UIDelegate::hasCustomMenuImplementation):
1144         (UIDelegate::trackCustomPopupMenu):
1145         * DumpRenderTree/win/UIDelegate.h:
1146         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1147         menu from being shown (and causing the DRT to hang).
1148
1149 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1150
1151         Reviewed by Darin.
1152
1153         Fix DumpRenderTree ObjC bug comparing strings.
1154
1155         * DumpRenderTree/mac/ObjCController.m:
1156         (-[ObjCController identityIsEqual::]): Compare strings with string
1157         equality instead of identiy equality.
1158
1159 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1160
1161         Reviewed by Sam.
1162
1163         Reset the authorAndUserStylesEnabled preference
1164         back to YES for each test. Fixes the broken tests.
1165
1166         * DumpRenderTree/mac/DumpRenderTree.mm:
1167         (resetWebViewToConsistentStateBeforeTesting):
1168
1169 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1170
1171         Reviewed by Adam.
1172
1173         - Drosera now displays the console window, although it cannot currently
1174         process JavaScript.
1175
1176         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1177         (registerConsoleClass): Implemented.
1178         (consoleWndProc): Implemented.
1179         (DebuggerClient::onSize): Implemented.
1180         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1181         new window.
1182         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1183         creating and maintaining a new window.
1184         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1185         lines of code to more appropriate places.
1186         (Drosera::handleCommand):
1187         (Drosera::initUI):
1188         (Drosera::onSize):
1189         (Drosera::attach):
1190
1191 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1192
1193         Reviewed by Dave Hyatt.
1194
1195         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1196         
1197         Add support for disabling author and user styles for testing.
1198
1199         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1200         * DumpRenderTree/LayoutTestController.cpp:
1201         (setAuthorAndUserStylesEnabledCallback):
1202         (LayoutTestController::staticFunctions):
1203         * DumpRenderTree/LayoutTestController.h:
1204         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1205         (LayoutTestController::setAuthorAndUserStylesEnabled):
1206         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1207         (LayoutTestController::setAuthorAndUserStylesEnabled):
1208
1209 2007-11-26  Dan Bernstein  <mitz@apple.com>
1210
1211         - Tiger build fix.
1212
1213         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1214
1215 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1216
1217         Reviewed by Maciej.
1218
1219         - Implemented displaying variables for Drosera on Win.
1220
1221         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1222         that retrieve variables to not hold onto the return value since it's
1223         not returned.  Also changed to use the new signatures of the retrieval
1224         functions.
1225         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1226         (DebuggerDocument::platformValueForScopeVariableNamed):
1227         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1228         (droseraWndProc):
1229
1230 2007-11-26  Sam Weinig  <sam@webkit.org>
1231
1232         Cleanup names of painting and repainting functions.
1233
1234         Reviewed by Adam Roben.
1235
1236         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1237         (drawSelectionRect): was drawSelectionRectIntoContext.
1238         (dumpWebViewAsPixelsAndCompareWithExpected):
1239         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1240         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1241         (paintWebView): was drawWebViewIntoContext.
1242         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1243
1244 2007-11-26  Sam Weinig  <sam@webkit.org>
1245
1246         Reviewed by Dan Bernstein.
1247
1248         - Leopard build fix
1249
1250         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1251
1252 2007-11-26  Sam Weinig  <sam@webkit.org>
1253
1254         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1255         Use shared PixelDumpSupport for Mac DRT
1256
1257         Reviewed by Adam Roben.
1258
1259         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1260         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1261         * DumpRenderTree/cg/ImageDiffCG.cpp:
1262         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1263         (drawSelectionRectIntoContext):
1264         (dumpWebViewAsPixelsAndCompareWithExpected):
1265         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1266         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1267         * DumpRenderTree/mac/DumpRenderTree.mm:
1268         (dump):
1269         * DumpRenderTree/mac/ImageDiff.m: Removed.
1270         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1271         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1272         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1273         (setDefaultColorProfileToRGB):
1274         (getBitmapContextFromWebView):
1275         (drawWebViewIntoContext):
1276         (repaintWithVerticalSweep):
1277         (repaintWithHorizontalSweep):
1278         (getSelectionRect):
1279         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1280
1281 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1282
1283         Bug 16052: prepare-ChangeLog doesn't report deleted files
1284         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1285
1286         Reviewed by Sam.
1287
1288         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1289
1290 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1291
1292         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1293         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1294
1295         Reviewed by Adam.
1296
1297         Roll functionality of merge-changelog into resolve-ChangeLogs
1298         script.  The script now checks for ChangeLog.rej and
1299         ChangeLog.orig files first.  If it finds them, it uses the
1300         ChangeLog.rej file as a patch (in old contextual diff format) to
1301         apply with --fuzz=3.
1302
1303         * Scripts/merge-changelog: Removed.
1304         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1305
1306 2007-11-25  Sam Weinig  <sam@webkit.org>
1307
1308         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1309
1310         Reviewed by Mark Rowe.
1311
1312         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1313         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1314         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1315         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1316         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1317
1318 2007-11-25  Sam Weinig  <sam@webkit.org>
1319
1320         Convert DumpRenderTree to ues .xcconfig files.
1321
1322         Reviewed by Mark Rowe.
1323
1324         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1325         * DumpRenderTree/mac/Configurations: Added.
1326         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1327         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1328         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1329
1330 2007-11-25  Sam Weinig  <sam@webkit.org>
1331
1332         Add ForwardingHeaders to wtf for DumpRenderTree.
1333
1334         Reviewed by Mark Rowe.
1335
1336         * DumpRenderTree/DumpRenderTree.h:
1337         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1338         * DumpRenderTree/ForwardingHeaders: Added.
1339         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1340         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1341         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1342         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1343         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1344         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1345         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1346         * DumpRenderTree/LayoutTestController.cpp:
1347         * DumpRenderTree/WorkQueue.cpp:
1348         * DumpRenderTree/mac/DumpRenderTree.mm:
1349         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1350         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1351         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1352         * DumpRenderTree/mac/ObjCController.m:
1353         * DumpRenderTree/mac/UIDelegate.mm:
1354         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1355
1356 2007-11-25  Adam Roben  <aroben@apple.com>
1357
1358         Fix some test failures caused by r28019
1359
1360         Now that stdout is in binary mode, we need to always use printf
1361         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1362         the output.
1363
1364         Reviewed by Sam.
1365
1366         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1367         printf.
1368         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1369         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1370         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1371         (UIDelegate::webViewAddMessageToConsole):
1372
1373 2007-11-25  Adam Roben  <aroben@apple.com>
1374
1375         Set the font smoothing preference in DRT
1376
1377         This makes the pixel results on Windows closer to the Mac results.
1378
1379         Reviewed by Mitz.
1380
1381         * DumpRenderTree/win/DumpRenderTree.cpp:
1382         (initializePreferences):
1383
1384 2007-11-25  Adam Roben  <aroben@apple.com>
1385
1386         Port ImageDiff to CG and C++
1387
1388         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1389         <rdar://5071708>
1390
1391         Reviewed by Sam.
1392
1393         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1394         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1395         (main):
1396         (createImageFromStdin):
1397         (compareImages):
1398         (getDifferenceBitmap):
1399         (computePercentageDifferent):
1400         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1401
1402 2007-11-25  Adam Roben  <aroben@apple.com>
1403
1404         Fix image diff link generation on Windows
1405
1406         Reviewed by Sam.
1407
1408         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1409         to toURL.
1410
1411 2007-11-25  Adam Roben  <aroben@apple.com>
1412
1413         Implement pixel dumping in Windows DRT
1414
1415         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1416         <rdar://5071708>
1417
1418         Reviewed by Sam.
1419
1420         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1421         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1422         Content-Length header.
1423         (getMD5HashStringForBitmap):
1424         (dumpWebViewAsPixelsAndCompareWithExpected):
1425         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1426         * DumpRenderTree/win/DumpRenderTree.cpp:
1427         (dump): Do a pixel dump if requested.
1428         (main): Parse pixel test options.
1429         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1430         the cg/ subdirectory to the include path.
1431         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1432         available in a header or import library, so we have to go through this
1433         LoadLibrary/GetProcAddress dance to use them.
1434         (cryptDLL):
1435         (init):
1436         (update):
1437         (final):
1438         (MD5_Init):
1439         (MD5_Update):
1440         (MD5_Final):
1441         * DumpRenderTree/win/MD5.h: Added.
1442         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1443         moved up to the top level to share it with Mac eventually.
1444         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1445         (getBitmapContextFromWebView): Forces the WebView to paint using a
1446         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1447
1448 2007-11-25  Adam Roben  <aroben@apple.com>
1449
1450         Clean up Windows DRT's option parsing a little bit
1451
1452         Reviewed by Sam.
1453
1454         * DumpRenderTree/win/DumpRenderTree.cpp:
1455         (main): Put non-option arguments into a Vector.
1456
1457 2007-11-25  Adam Roben  <aroben@apple.com>
1458
1459         Make Windows DRT stop changing LF into CRLF
1460
1461         Reviewed by Sam.
1462
1463         * DumpRenderTree/win/DumpRenderTree.cpp:
1464         (main): Put stdout in binary mode.
1465         * Scripts/run-webkit-tests: Remove the CRLF hack.
1466
1467 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1468
1469         Removed empty directory.
1470
1471         * Scripts/resources: Removed.
1472
1473 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1474
1475         Fix bisect-builds to work with recent WebKit nightly builds.
1476
1477         Reviewed by Dan.
1478
1479         * Scripts/bisect-builds: Check for the 
1480         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1481         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1482         to WebKit.app/Contents/Resources.
1483
1484 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1485
1486         Reviewed by Maciej.
1487
1488         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1489         not closed (affects digg.com)
1490
1491         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1492         one after finishing with a test to avoid having its delayed onload handler firing when
1493         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1494         but it helps somewhat.
1495
1496 2007-11-22  Mark Rowe  <mrowe@apple.com>
1497
1498         Reviewed by Alp Toker.
1499
1500         Fix build-webkit to propagate make's exit status if it fails.
1501
1502         * Scripts/webkitdirs.pm:
1503
1504 2007-11-22  Dan Bernstein  <mitz@apple.com>
1505
1506         Reviewed by Mark Rowe.
1507
1508         - fix crash when running pixel tests
1509
1510         * DumpRenderTree/mac/DumpRenderTree.mm:
1511         (dumpRenderTree): Parse the command line options before setting up the
1512         environment so that we know if we need to set up the pixel dump
1513         machinery.
1514
1515 2007-11-21  Eric Seidel  <eric@webkit.org>
1516
1517         Speculative build fix for Tiger.
1518
1519         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1520
1521 2007-11-21  Eric Seidel  <eric@webkit.org>
1522
1523         Reviewed by Tim Hatcher.
1524
1525         Break out more of DumpRenderTree.mm into individual files
1526
1527         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1528         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1529         (checkedMalloc):
1530         (checkedRealloc):
1531         (makeLargeMallocFailSilently):
1532         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1533         * DumpRenderTree/mac/DumpRenderTree.mm:
1534         (crashHandler):
1535         (dump):
1536         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1537         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1538         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1539         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1540         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1541         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1542         (javaScriptThreads):
1543         (runJavaScriptThread):
1544         (startJavaScriptThreads):
1545         (stopJavaScriptThreads):
1546         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1547         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1548         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1549         (restoreColorSpace):
1550         (setDefaultColorProfileToRGB):
1551         (initializeColorSpaceAndScreeBufferForPixelTests):
1552         (md5HashStringForBitmap):
1553         (dumpWebViewAsPixelsAndCompareWithExpected):
1554
1555 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1556
1557         Move install-unix-extras to wx directory as it seems only to be used by that 
1558         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1559         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1560         have install-unix-extras install into WebKitLibraries as per
1561         convention.
1562         
1563         Reviewed by Mark Rowe.
1564
1565         * Scripts/install-unix-extras: Removed.
1566         * wx/build-wxwebkit:
1567         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1568
1569 2007-11-21  Eric Seidel  <eric@webkit.org>
1570
1571         Reviewed by Adam.
1572
1573         More refactoring for greater code readability
1574
1575         * DumpRenderTree/mac/DumpRenderTree.mm:
1576         (initializeGlobalsFromCommandLineOptions):
1577         (initializeColorSpaceAndScreeBufferForPixelTests):
1578         (addTestPluginsToPluginSearchPath):
1579         (useLongRunningServerMode):
1580         (runTestingServerLoop):
1581         (prepareConsistentTestingEnvironment):
1582         (dumpRenderTree):
1583         (main):
1584         (dumpFramesAsText):
1585         (dumpBackForwardListForWebView):
1586         (sizeWebViewForCurrentTest):
1587         (methodNameStringForFailedTest):
1588         (dumpBackForwardListForAllWindows):
1589         (dumpWebViewAsPixelsAndCompareWithExpected):
1590         (invalidateAnyPreviousWaitToDumpWatchdog):
1591         (dump):
1592         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1593         * DumpRenderTree/mac/UIDelegate.mm:
1594         (-[UIDelegate webView:createWebViewWithRequest:]):
1595
1596 2007-11-21  Eric Seidel  <eric@webkit.org>
1597
1598         Reviewed by Tim Hatcher.
1599
1600         Abstract more of DRT into static methods
1601
1602         * DumpRenderTree/mac/DumpRenderTree.mm:
1603         (setDefaultsToConsistentValuesForTesting):
1604         (setupSignalHandlers):
1605         (allocateGlobalControllers):
1606         (releaseAndZero):
1607         (releaseGlobalControllers):
1608         (dumpRenderTree):
1609         (shouldLogFrameLoadDelegates):
1610         (createCFURLFromPathOrURL):
1611         (resetWebViewToConsistentStateBeforeTesting):
1612         (runTest):
1613
1614 2007-11-21  Eric Seidel  <eric@webkit.org>
1615
1616         Reviewed by Tim Hatcher.
1617
1618         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1619
1620         * DumpRenderTree/DumpRenderTree.h:
1621         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1622         * DumpRenderTree/mac/DumpRenderTree.mm:
1623         (dumpRenderTree):
1624         (dump):
1625         (runTest):
1626         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1627         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1628         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1629         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1630         (-[DumpRenderTreePasteboard declareType:owner:]):
1631         (+[LocalPasteboard alloc]):
1632         (-[LocalPasteboard init]):
1633         (-[LocalPasteboard dealloc]):
1634         (-[LocalPasteboard name]):
1635         (-[LocalPasteboard releaseGlobally]):
1636         (-[LocalPasteboard declareTypes:owner:]):
1637         (-[LocalPasteboard addTypes:owner:]):
1638         (-[LocalPasteboard changeCount]):
1639         (-[LocalPasteboard types]):
1640         (-[LocalPasteboard availableTypeFromArray:]):
1641         (-[LocalPasteboard setData:forType:]):
1642         (-[LocalPasteboard dataForType:]):
1643         (-[LocalPasteboard setPropertyList:forType:]):
1644         (-[LocalPasteboard setString:forType:]):
1645         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1646         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1647         (+[DumpRenderTreeWindow allWindows]):
1648         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1649         (-[DumpRenderTreeWindow dealloc]):
1650         (-[DumpRenderTreeWindow isKeyWindow]):
1651         (-[DumpRenderTreeWindow keyDown:]):
1652
1653 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1654
1655         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1656         it indiscriminately copies any headers inside JavaScriptCore,
1657         which includes Tiger ICU headers. 
1658
1659         * wx/build-wxwebkit:
1660         Don't run WebCore/move-js-headers.sh any longer.
1661
1662 2007-11-20  Adam Treat  <treat@kde.org>
1663
1664         Reviewed by David Kilzer.
1665
1666         * Prepend git branch name to $baseProductDir
1667
1668         * Scripts/VCSUtils.pm:
1669         * Scripts/webkitdirs.pm:
1670
1671 2007-11-20  Mark Rowe  <mrowe@apple.com>
1672
1673         Reviewed by Simon Hausmann.
1674
1675         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1676         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1677         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1678         built product and generated Makefile's are removed.
1679
1680 2007-11-19  Alp Toker  <alp@atoker.com>
1681
1682         Reviewed by Mark Rowe.
1683
1684         http://bugs.webkit.org/show_bug.cgi?id=16040
1685         [GTK] GtkLauncher should be written in C
1686
1687         Port GtkLauncher to plain C.
1688
1689         Use a more conventional GTK+ coding style.
1690
1691         Use a toolbar instead of menus.
1692
1693         Various signature fixes and cleanups.
1694
1695         Add a license header. Assume all previous modifications were copyright
1696         assigned to Apple Inc. by default.
1697
1698         * GtkLauncher/GtkLauncher.pro:
1699         * GtkLauncher/main.c: Added.
1700         (activate_url_entry_cb):
1701         (update_title):
1702         (link_hover_cb):
1703         (title_change_cb):
1704         (progress_change_cb):
1705         (destroy_cb):
1706         (go_back_cb):
1707         (go_forward_cb):
1708         (create_browser):
1709         (create_statusbar):
1710         (create_toolbar):
1711         (create_window):
1712         (main):
1713         * GtkLauncher/main.cpp: Removed.
1714
1715 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1716
1717         Build script fixes to ensure they do the right thing for the 
1718         wx port, and update build-wxwebkit to reflect the way the
1719         build scripts now work.
1720
1721         Reviewed by Adam.
1722
1723         * Scripts/build-testkjs:
1724         * Scripts/build-webkit:
1725         * Scripts/run-javascriptcore-tests:
1726         * Scripts/webkitdirs.pm:
1727         * wx/build-wxwebkit:
1728
1729 2007-11-18  Eric Seidel  <eric@webkit.org>
1730
1731         Reviewed by Anders.
1732
1733         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1734
1735         * Scripts/run-javascriptcore-tests:
1736
1737 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1738
1739         Reviewed by Adam Roben.
1740
1741         Make run-webkit-tests work with Windows debug build.
1742
1743         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1744         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1745         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1746         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1747         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1748
1749 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1750
1751         Add wxWebKit sample and build script, and integrate it with 
1752         build-webkit. Also make build-webkit --clean work for all
1753         ports.
1754
1755         Reviewed by Darin Adler.
1756
1757         * Scripts/build-webkit:
1758         * Scripts/webkitdirs.pm:
1759         * wx: Added.
1760         * wx/browser: Added.
1761         * wx/browser/browser.bkl: Added.
1762         * wx/browser/browser.cpp: Added.
1763         * wx/build-wxwebkit: Added.
1764
1765 2007-11-17  Adam Roben  <aroben@apple.com>
1766
1767         Make it easy to run Safari in the debugger on Windows
1768
1769         I've added a new script, debug-safari, which launches Safari in the
1770         debugger. On OS X it just calls gdb-safari.
1771
1772         Reviewed by Mark Rowe.
1773
1774         * FindSafari/FindSafari.cpp:
1775         (_tmain): Added a /debugger flag, which in combination with
1776         /printSafariLauncher will print a script that launches Safari in the
1777         debugger.
1778         * Scripts/debug-safari: Added.
1779         * Scripts/run-safari: Changed to call runSafari().
1780         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1781         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1782         first argument along to FindSafari.
1783         * Scripts/webkitdirs.pm:
1784         (sub runSafari): Added.
1785
1786 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1787
1788         Reviewed by Adam Roben.
1789
1790         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1791
1792 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1793
1794         Reviewed by David Kilzer.
1795
1796         The git config command was renamed to repo-config at some point. This
1797         change tries git config and then git repo-config if the first fails.
1798
1799         * Scripts/prepare-ChangeLog:
1800         (gitConfig):
1801
1802 2007-11-16  Dan Bernstein  <mitz@apple.com>
1803
1804         Reviewed by Darin Adler and Sam Weinig.
1805
1806         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1807
1808         * DumpRenderTree/win/EventSender.cpp:
1809         (keyDownCallback): For characters that cannot be entered on the active
1810         keyboard layout, send a WM_CHAR message with the character along with
1811         a WM_KEYDOWN message with a virtual key code of 255.
1812
1813 2007-11-16  Mark Rowe  <mrowe@apple.com>
1814
1815         Reviewed by Tim Hatcher.
1816
1817         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1818
1819         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1820         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1821
1822 2007-11-15  Adam Roben  <aroben@apple.com>
1823
1824         Make run-safari actually work on Windows
1825
1826         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1827         chdir call.
1828
1829 2007-11-14  Adam Roben  <aroben@apple.com>
1830
1831         Updates to Safari launching now that 3.0.4 is released
1832
1833         Reviewed by Sam.
1834
1835         * FindSafari/FindSafari.cpp:
1836         (getWebViewCLSID): Use version-independent ProgID.
1837         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1838
1839 2007-11-14  Anders Carlsson  <andersca@apple.com>
1840
1841         Reviewed by Adam.
1842
1843         <rdar://problem/5309081>
1844         In DRT, "plugin.logDestroy = true" not working on Windows.
1845         
1846         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1847         (NPP_Destroy):
1848
1849 2007-11-14  Eric Seidel  <eric@webkit.org>
1850
1851         Reviewed by Sam.
1852
1853         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1854
1855 2007-11-14  Anders Carlsson  <andersca@apple.com>
1856
1857         Reviewed by Adam.
1858
1859         <rdar://problem/5141186>
1860         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1861         
1862         Implement setWindowIsKey.
1863         
1864         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1865         (LayoutTestController::setWindowIsKey):
1866
1867 2007-11-13  Sam Weinig  <sam@webkit.org>
1868
1869         Reviewed by Adam Roben.
1870
1871         Fix for <rdar://problem/5382579>
1872         http/tests/security/cross-frame-access-put.html reports large 
1873         negative numbers for screenLeft and screenTop (Mac reports "0")
1874
1875         * DumpRenderTree/win/UIDelegate.cpp:
1876         (UIDelegate::UIDelegate): Initialize the RECT.
1877         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1878         (UIDelegate::webViewFrame): ditto.
1879         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1880
1881 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1882
1883         Reviewed by Adam.
1884
1885         - Make Drosera show source, source URLs, and function stack on Windows,
1886         and some minor fixes.
1887
1888         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1889         (DebuggerDocument::updateFileSource):
1890         * Drosera/debugger.js: Force source to always update display.
1891         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1892         menu controls.
1893         (DebuggerClient::resume):
1894         (DebuggerClient::pause):
1895         (DebuggerClient::stepInto):
1896         (DebuggerClient::stepOver):
1897         (DebuggerClient::stepOut):
1898         (DebuggerClient::showConsole):
1899         (DebuggerClient::closeCurrentFile):
1900         * Drosera/win/DebuggerClient.h: Ditto.
1901         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1902         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1903         removed two bugs.  1) caller could be in a bad state when asked to
1904         assign into it. 2) BSTRs were not created correctly.
1905         (DebuggerDocument::getPlatformCurrentFunctionStack):
1906         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1907         (droseraWndProc):
1908         (handleCommand):
1909         (Drosera::resume):
1910         (Drosera::pause):
1911         (Drosera::stepInto):
1912         (Drosera::stepOver):
1913         (Drosera::stepOut):
1914         (Drosera::showConsole):
1915         (Drosera::closeCurrentFile):
1916         * Drosera/win/Drosera.h: Hook up the menu controls.
1917         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1918         functions, added a null check, and fixed another bug where caller could
1919         be in a bad state when asked to assign into it.
1920         (ServerConnection::didLoadMainResourceForDataSource):
1921         (ServerConnection::getCallerFrame):
1922         * Drosera/win/ServerConnection.h: Safety first.
1923
1924 2007-11-13  Dan Bernstein  <mitz@apple.com>
1925
1926         Reviewed by Darin Adler.
1927
1928         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1929           DumpRenderTree --pixel-tests renders each test twice
1930
1931         * DumpRenderTree/mac/DumpRenderTree.mm:
1932         (dumpRenderTree): Removed the --paint option because the painting code
1933         is always exercised as a result of
1934         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1935         calling -displayIfNeeded.
1936         (dump): Changed to always grab the image from the window since the view
1937         is always displayed.
1938         (runTest):
1939         (displayWebView):
1940         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1941         because it always paints.
1942
1943 2007-11-12  Antti Koivisto  <antti@apple.com>
1944
1945         Reviewed by Adele.
1946         
1947         Add support for http media tests
1948
1949         * Scripts/run-webkit-tests:
1950
1951 2007-11-12  Sam Weinig  <sam@webkit.org>
1952
1953         Reviewed by Adam Roben.
1954
1955         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1956
1957         * DumpRenderTree/win/DumpRenderTree.cpp:
1958         (runTest):
1959         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1960         (LayoutTestController::setPrivateBrowsingEnabled):
1961
1962 2007-11-12  Adam Roben  <aroben@apple.com>
1963
1964         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1965         mac and win subdirectories.
1966
1967 2007-11-11  Adam Roben  <aroben@apple.com>
1968
1969         Fix <rdar://5133816> keepWebHistory is not implemented
1970
1971         Fixes fast/history/clicked-link-is-visited.html.
1972
1973         Reviewed by Darin.
1974
1975         * DumpRenderTree/win/DumpRenderTree.cpp:
1976         (runTest): Clear the optionalSharedHistory.
1977         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1978         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1979
1980 2007-11-10  Sam Weinig  <sam@webkit.org>
1981
1982         Reviewed by Tim Hatcher.
1983
1984         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1985         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1986         is turned on)
1987
1988         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1989
1990         Added test: http/tests/security/cross-frame-access-private-browsing.html
1991
1992         * DumpRenderTree/LayoutTestController.cpp:
1993         (setPrivateBrowsingEnabledCallback):
1994         (LayoutTestController::staticFunctions):
1995         * DumpRenderTree/LayoutTestController.h:
1996         * DumpRenderTree/mac/DumpRenderTree.mm:
1997         (runTest): Default to private browsing disabled.
1998         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1999         (LayoutTestController::setPrivateBrowsingEnabled):
2000         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2001         (LayoutTestController::setPrivateBrowsingEnabled):
2002
2003 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2004
2005         Reviewed by Adam.
2006
2007         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2008         WebCore's!
2009
2010         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2011         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2012         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2013         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2014         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2015         * Drosera/win/Drosera.cpp:
2016         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2017
2018 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2019
2020         Reviewed by Sam.
2021
2022         - Use the new IWebFrame [local] function signature and get the shared
2023         server correctly.
2024
2025         * Drosera/win/DebuggerClient.cpp:
2026         (DebuggerClient::didFinishLoadForFrame):
2027         * Drosera/win/ServerConnection.cpp:
2028         (ServerConnection::attemptToCreateServerConnection):
2029
2030 2007-11-07  Dan Bernstein  <mitz@apple.com>
2031
2032         Reviewed by Darin Adler.
2033
2034         - add an option to run-webkit-tests to ignore pixel test failures where
2035           all pixels differ by no more than a specified threshold
2036
2037         * DumpRenderTree/mac/ImageDiff.m:
2038         (main):
2039         (compareImages):
2040         (computePercentageDifferent):
2041         * Scripts/run-webkit-tests:
2042
2043 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2044
2045         Reviewed by Lars.
2046
2047         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2048
2049         * DumpRenderTree/qt/DumpRenderTree.cpp:
2050
2051 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2052
2053         Reviewed by Lars.
2054
2055         Reworked the QWebSettings API.
2056         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2057
2058         * DumpRenderTree/qt/DumpRenderTree.cpp:
2059
2060 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2061
2062         Reviewed by Lars.
2063
2064         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2065
2066         * DumpRenderTree/qt/jsobjects.cpp:
2067
2068 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2069
2070         Reviewed by Lars Knoll <lars@trolltech.com>.
2071
2072         Add a QWebPage::frameCreated() signal and fix DRT
2073         
2074         The removal of createFrame in QWebPage broke the re-implementation
2075         in DumpRenderTree. Instead emit a frameCreated() signal and
2076         connect to it in DumpRenderTree.
2077         
2078
2079         * DumpRenderTree/qt/DumpRenderTree.cpp:
2080         (WebCore::WebPage::WebPage):
2081         (WebCore::DumpRenderTree::dump):
2082         (WebCore::DumpRenderTree::connectFrame):
2083         * DumpRenderTree/qt/DumpRenderTree.h:
2084
2085 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2086
2087         Reviewed by Lars Knoll <lars@trolltech.com>.
2088
2089         Moved all the event handlers from QWebFrame into QWebPage.
2090         
2091         This cleans up the public API and allows us to remove the
2092         HackWebFrame hack in DumpRenderTree.
2093         
2094
2095         * DumpRenderTree/qt/jsobjects.cpp:
2096         (EventSender::mouseDown):
2097         (EventSender::mouseUp):
2098         (EventSender::mouseMoveTo):
2099
2100 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2101
2102         Reviewed by Mark.
2103
2104         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2105         to prevent the default implementation from popping up messageboxes.
2106
2107         * DumpRenderTree/qt/DumpRenderTree.cpp:
2108         (WebCore::WebPage::javaScriptConfirm):
2109         (WebCore::WebPage::javaScriptPrompt):
2110
2111 2007-11-06  Eric Seidel  <eric@webkit.org>
2112
2113         * Scripts/build-testkjs: build fix... too many $$
2114
2115 2007-11-06  Eric Seidel  <eric@webkit.org>
2116
2117         Reviewed by Mark Rowe.
2118
2119         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2120
2121 2007-11-05  Adam Roben  <aroben@apple.com>
2122
2123         Add support on Windows for WEBKIT_TESTFONTS
2124
2125         This environment variable lets you specify where the fonts to be used
2126         by DumpRenderTree reside. The Qt port is already using this, so I'm
2127         just following their lead.
2128
2129         Reviewed by Darin.
2130
2131         * DumpRenderTree/win/DumpRenderTree.cpp:
2132         (exePath): Refactored code out of initialize().
2133         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2134         DumpRenderTree.resources.
2135         (initialize): Use the new fontsPath function.
2136         (main): Use the new exePath function.
2137         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2138         variable to DRT, like Qt does.
2139
2140 2007-11-05  Mark Rowe  <mrowe@apple.com>
2141
2142         Rubber-stamped by Alp Toker.
2143
2144         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2145
2146         * GtkLauncher/main.cpp:
2147         (goToURLBarText):
2148         (main):
2149
2150 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2151
2152         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2153         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2154
2155         Reviewed by Timothy.
2156
2157         Restrict the range of nightly builds used by the bisect-builds script
2158         based on the version of Safari and the version of Mac OS X being used.
2159
2160         Mac OS X 10.4: Safari 2.0: r11976 or newer
2161         Mac OS X 10.4: Safari 3.0: r19992 or newer
2162
2163         Mac OS X 10.5: Safari 2.0: r19594 or newer
2164         Mac OS X 10.5: Safari 3.0: r25124 or newer
2165
2166         * Scripts/bisect-builds:
2167         (findMacOSXVersion): Added.
2168         (makeNightlyList): Added argument to provide version of Mac OS X.
2169         Restrict range of nightly builds based on Safari and Mac OS X versions.
2170
2171 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2172
2173         Reviewed by Maciej.
2174
2175         - This patch involves several changes, all of them were noticed that
2176         they were needed by the work being done in WebKit to get Drosera and
2177         WebKit working together on Windows.
2178         - The changes are:
2179         1) Added a debugger console for output messages.
2180         2) Drosera now listens for the WebKit server (before, the server would
2181         have to be running before Drosera was started.)
2182         3) Fixed a bug where the WebView started out as 0x0 pixels.
2183         4) Fixed a bug when there is no scope.
2184         5) Added the HTML, JS, and CSS to the project file to make them easy to
2185         find.
2186         6) Made the ServerConnection functions virtual.
2187
2188         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2189         for the WebKit server.
2190         (DebuggerClient::DebuggerClient):
2191         (DebuggerClient::~DebuggerClient):
2192         (DebuggerClient::didFinishLoadForFrame):
2193         (DebuggerClient::serverConnected):
2194         (DebuggerClient::attemptToCreateServerConnection):
2195         * Drosera/win/DebuggerClient.h: Ditto.
2196         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2197         scope.
2198         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2199         (DebuggerDocument::platformValueForScopeVariableNamed):
2200         * Drosera/win/Drosera.cpp:
2201         (_tWinMain): Added a console in debug for output messages.
2202         (Drosera::Drosera): Listen for server.
2203         (Drosera::initUI): The server now Initializes COM.
2204         (Drosera::serverConnected): Part of the listening for the server.
2205         (Drosera::attemptToCreateServerConnection): Ditto.
2206         * Drosera/win/Drosera.h: New interface for listening for the server.
2207         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2208         files to the VS project.
2209         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2210         connection.
2211         (ServerConnection::ServerConnection):
2212         (ServerConnection::attemptToCreateServerConnection):
2213         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2214         methods.
2215         (ServerConnection::serverConnected):
2216
2217 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2218
2219         Reviewed by Maciej.
2220
2221         http://bugs.webkit.org/show_bug.cgi?id=15832
2222         fast/dom/gc-10.html crashes when run alone
2223
2224         Check for !done before using objects that can be already deallocated.
2225
2226         * DumpRenderTree/mac/EditingDelegate.mm:
2227         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2228         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2229         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2230         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2231         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2232         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2233         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2234         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2235         (-[EditingDelegate webViewDidBeginEditing:]):
2236         (-[EditingDelegate webViewDidChange:]):
2237         (-[EditingDelegate webViewDidEndEditing:]):
2238         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2239         (-[EditingDelegate webViewDidChangeSelection:]):
2240         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2241         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2242         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2243         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2244         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2245         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2246         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2247         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2248         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2249         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2250         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2251         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2252         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2253         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2254         (-[FrameLoadDelegate webView:willCloseFrame:]):
2255         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2256         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2257         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2258         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2259         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2260         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2261         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2262         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2263         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2264
2265 2007-11-04  Mark Rowe  <mrowe@apple.com>
2266
2267         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2268         warnings that would otherwise be suppressed due to it being a system header.
2269
2270         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2271
2272 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2273
2274         Rubber stamped by Adam.
2275         
2276         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2277
2278         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2279
2280 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2281
2282         Sort files(...); sections of Xcode project files.
2283
2284         Rubber-stamped by Darin.
2285
2286         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2287         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2288         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2289         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2290
2291 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2292
2293         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2294
2295         Reviewed by Darin.
2296
2297         * Scripts/sort-Xcode-project-file: Added.
2298
2299 2007-11-02  Darin Adler  <darin@apple.com>
2300
2301         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2302
2303 2007-11-02  Darin Adler  <darin@apple.com>
2304
2305         Reviewed by Maciej.
2306
2307         * Scripts/run-sunspider: Pass the "--base" option through.
2308
2309         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2310         the real script do that. Default configuration to Release to match run-sunspider
2311         so we don't end up building Debug just to compare results.
2312
2313 2007-11-01  Adam Roben  <aroben@apple.com>
2314
2315         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2316
2317         Reviewed by Sam.
2318
2319         * Scripts/commit-log-editor: Show all the directories beneath the
2320         source root, instead of just the last one.
2321
2322 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2323
2324         Reviewed by Adam Roben.
2325
2326         Print out an error message when the Windows build fails
2327         and provide guidance on how to find out what went wrong.
2328
2329         * Scripts/build-webkit:
2330         * Scripts/webkitdirs.pm:
2331
2332 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2333
2334         Rubber-stamped by Adam Roben.
2335
2336         Rolled out r27326 - debug CRT seems to cause no problems after all.
2337
2338         * DumpRenderTree/win/DumpRenderTree.vcproj:
2339
2340 2007-10-31  Adam Roben  <aroben@apple.com>
2341
2342         Switch the Debug configuration to using the non-debug CRT
2343
2344         This matches WebKit.
2345
2346         Reviewed by Steve.
2347
2348         * DumpRenderTree/win/DumpRenderTree.vcproj:
2349
2350 2007-10-31  Antti Koivisto  <antti@apple.com>
2351
2352         Reviewed by bdash.
2353         
2354         Disable media tests when doing leak checking on Tiger.
2355         They crash in QuickTime (rdar://problem/5537157).
2356
2357         * Scripts/run-webkit-tests:
2358
2359 2007-10-29  Antti Koivisto  <antti@apple.com>
2360
2361         Reviewed by Maciej.
2362         
2363         Build media support by default on OSX only.
2364
2365         * Scripts/build-webkit:
2366
2367 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2368
2369         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2370         get caught by the pre-commit hooks.
2371
2372 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2373
2374         Reviewed by Adam.
2375
2376         - This is a collection of relatively unrelated changes and cleanups
2377         to Drosera to prepare it for interacting with WebKit.  A lot of these
2378         changes are just correcting mistakes, for example removing included
2379         headers that are no longer needed.
2380
2381         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2382         this will be needed by the DebuggerClient.
2383         (DebuggerDocument::server):
2384         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2385         * Drosera/win/DebuggerClient.cpp: 
2386         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2387         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2388         (DebuggerClient::createWebViewWithRequest): Added comment about its
2389         purpose. 
2390         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2391         declarations.
2392         (DebuggerClient::webViewLoaded): Moved.
2393         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2394         file, since this was the only place it was used.
2395         (cfStringToBSTR):
2396         * Drosera/win/Drosera.h: Cleaned up the includes.
2397         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2398         * Drosera/win/HelperFunctions.h: Removed.
2399
2400 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2401
2402         Reviewed by Adam.
2403
2404         - Small cleanup in the ServerConnection class.
2405
2406         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2407         and added an include.
2408         (ServerConnection::currentFrame):
2409         (ServerConnection::getCallerFrame):
2410         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2411         made a pointer into a COMPtr, and cleaned up the includes.
2412
2413 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2414
2415         Reviewed by John Sullivan.
2416         
2417         - Place the Localizable.strings file in mac or win directories
2418           if that location exists.
2419         - Also look for UI_STRING in .c files.
2420
2421         * Scripts/extract-localizable-strings:
2422
2423 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2424
2425         Reviewed by Adam.
2426
2427         - Set the eol-style to native and made all the line endings the same
2428         so that I avoid messy diffs that show eol changes.
2429
2430         * Drosera/win/ServerConnection.cpp:
2431         (ServerConnection::didParseSource):
2432         (ServerConnection::didEnterCallFrame):
2433         (ServerConnection::willExecuteStatement):
2434         (ServerConnection::willLeaveCallFrame):
2435         (ServerConnection::exceptionWasRaised):
2436
2437 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2438
2439         Reviewed by Adam.
2440
2441         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2442         functionality that could not have existed previously without the new
2443         interfaces.
2444         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2445         from a BSTR to a JSValueRef.
2446         (DebuggerDocument::platformEvaluateScript): Implemented.
2447         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2448         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2449         Implemented.
2450         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2451         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2452         * Drosera/win/ServerConnection.cpp: Added a helper function.
2453         (ServerConnection::getCallerFrame):
2454         * Drosera/win/ServerConnection.h: Added a helper function.
2455
2456 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2457
2458         updated reviewers for my previous changelog.
2459
2460 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2461         Reviewed by Maciej and Adam and Geoff.
2462
2463         - Minor mac-side improvements including moving a function to a more
2464         appropriate location, fixing a warning, and correctly checking
2465         exceptions.
2466
2467         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2468         (DebuggerDocument::willExecuteStatement):
2469         (DebuggerDocument::didEnterCallFrame):
2470         (DebuggerDocument::willLeaveCallFrame):
2471         (DebuggerDocument::windowScriptObjectAvailable):
2472         (DebuggerDocument::callFunctionOnObject):
2473         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2474         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2475         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2476         because it doesn't require the ServerConnection at all.
2477         (NSStringCreateWithJSStringRef): Made an argument const.
2478         (JSValueRefCreateWithNSString): Made an argument const.
2479         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2480         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2481         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2482         * Drosera/mac/ServerConnection.mm: Ditto.
2483         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2484
2485 2007-10-29  Sam Weinig  <sam@webkit.org>
2486
2487         Reviewed by Adam Roben.
2488
2489         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2490
2491         * DumpRenderTree/LayoutTestController.cpp:
2492         (LayoutTestController::LayoutTestController):
2493         (getGlobalFlagCallback):
2494         (setGlobalFlagCallback):
2495         (LayoutTestController::getJSClass):
2496         (LayoutTestController::staticValues):
2497         * DumpRenderTree/LayoutTestController.h:
2498         (LayoutTestController::globalFlag):
2499         (LayoutTestController::setGlobalFlag):
2500
2501 2007-10-29  Darin Adler  <darin@apple.com>
2502
2503         Reviewed by Maciej.
2504
2505         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2506         resolution instead of its default.
2507
2508 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2509
2510         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2511
2512         Reviewed by Mark Rowe.
2513
2514         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2515         was successfully resolved, but this would not show any status because the change had
2516         already been cached in the index using "git add".  The solution is to add an optional
2517         second argument to showStatus() which adds the "--cached" switch to the command.
2518
2519         * Scripts/resolve-ChangeLogs:
2520         (showStatus):
2521
2522 2007-10-28  Eric Seidel  <eric@webkit.org>
2523
2524         Reviewed by Maciej and Geoff, in unison.
2525
2526         * Scripts/run-webkit-tests: remove broken --svg option
2527
2528 2007-10-28  Darin Adler  <darin@apple.com>
2529
2530         Reviewed by Adam.
2531
2532         * Scripts/run-sunspider: Default to "Release" configuration rather than
2533         defaulting to the last configuration used as other scripts do. This can
2534         still be overriden on the command line with "--debug" if there's some
2535         reason to do so. Also fix a typo.
2536
2537         * Scripts/sunspider-compare-results: Fix a typo.
2538
2539 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2540
2541         Reviewed by Adam.
2542
2543         - Implemented the WebScriptDebugListener functions now that the
2544         WebScriptDebugServer exists
2545
2546         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2547         functions.
2548         (ServerConnection::currentFrame):
2549         (ServerConnection::didLoadMainResourceForDataSource):
2550         (ServerConnection::didParseSource):
2551         (ServerConnection::failedToParseSource):
2552         (ServerConnection::didEnterCallFrame):
2553         (ServerConnection::willExecuteStatement):
2554         (ServerConnection::willLeaveCallFrame):
2555         (ServerConnection::exceptionWasRaised):
2556         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2557         members arguments list.
2558
2559 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2560
2561         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2562         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2563
2564         Reviewed by Darin.
2565
2566         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2567         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2568         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2569         file.  Note that it may also be used as a stand-alone script.
2570
2571         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2572         * Scripts/resolve-ChangeLogs: Added.
2573         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2574
2575 2007-10-26  Mark Rowe  <mrowe@apple.com>
2576
2577         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2578         to the Qt port on the assumption that it was an implementation of the cross-platform
2579         LayoutTestController class.  It is not, so it did not need to be changed.
2580
2581         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2582
2583 2007-10-25  Mark Rowe  <mrowe@apple.com>
2584
2585         Reviewed by Maciej.
2586
2587         Fix builds with code coverage enabled.
2588
2589         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2590
2591 2007-10-25  Darin Adler  <darin@apple.com>
2592
2593         Reviewed by Mark Rowe.
2594
2595         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2596         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2597
2598 2007-10-25  Stephanie  <slewis@apple.com>
2599
2600         build Fix
2601
2602         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2603
2604 2007-10-25  Stephanie  <slewis@apple.com>
2605
2606         Reviewed by Mark Rowe, Adam Roben.
2607
2608         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2609
2610         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2611
2612 2007-10-25  Alice Liu  <alice.liu@apple.com>
2613
2614         Reviewed by Adam.
2615
2616         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2617
2618         Moving destructor into platform-specific files
2619         * DumpRenderTree/LayoutTestController.cpp:
2620         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2621         (LayoutTestController::~LayoutTestController):
2622         * DumpRenderTree/qt/jsobjects.cpp:
2623         (LayoutTestController::~LayoutTestController):
2624
2625         LayoutTestController wasn't being destroyed
2626         * DumpRenderTree/win/DumpRenderTree.cpp:
2627         (runTest):
2628
2629         Added declspec
2630         * DumpRenderTree/win/EditingDelegate.h:
2631
2632         Reset certain values on the webview (or related delegate) that might 
2633         have changed while running a test
2634         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2635         (LayoutTestController::~LayoutTestController):
2636
2637 2007-10-25  Adam Roben  <aroben@apple.com>
2638
2639         Make sunspider-compare-results work with relative paths
2640
2641         Reviewed by Sam.
2642
2643         * Scripts/sunspider-compare-results: Convert arguments to absolute
2644         paths before we chdir.
2645
2646 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2647
2648         Reviewed by Sam.
2649
2650         - Implemented server calls now the WebScriptDebugServer exists.
2651         - Also removed no longer needed call to initialize CG.
2652
2653         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2654         automatically now.
2655         (_tWinMain):
2656         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2657         (ServerConnection::ServerConnection):
2658         (ServerConnection::~ServerConnection):
2659         (ServerConnection::pause):
2660         (ServerConnection::resume):
2661         (ServerConnection::stepInto):
2662         (ServerConnection::applicationTerminating):
2663         (ServerConnection::serverConnectionDidDie):
2664         * Drosera/win/ServerConnection.h: Now uses the COM class.
2665
2666 2007-10-24  George Staikos  <staikos@kde.org>
2667
2668         Unbreak Qt build.
2669
2670         * Scripts/build-webkit:
2671
2672 2007-10-24  Adam Roben  <aroben@apple.com>
2673
2674         Remove now-unnecessary call to InitializeCoreGraphics
2675
2676         WebKit takes care of this now.
2677
2678         Reviewed by Ada.
2679
2680         * DumpRenderTree/win/DumpRenderTree.cpp:
2681         (initialize):
2682
2683 2007-10-24  Adam Roben  <aroben@apple.com>
2684
2685         Use WebTextRenderer in DRT
2686
2687         Reviewed by Ada.
2688
2689         * DumpRenderTree/win/DumpRenderTree.cpp:
2690         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2691
2692 2007-10-24  Sven Herzberg  <sven@imendio.com>
2693
2694         Reviewed by Mark Rowe.
2695
2696         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2697         Bug 15614: [GTK] qmake based backends don't build on OS X
2698
2699         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2700         GTK backend on a Mac
2701         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2702         isDarwin() to make it reusable in other places (like the workaround-
2703         for-prebuilt-qmake in build-webkit)
2704
2705 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2706
2707         Refurbish update-webkit script.
2708
2709         Reviewed by Adam.
2710
2711         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2712         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2713         multi-argument version of system() for flexibility and security.  Check for existence
2714         of Internal directory using -d test instead of -x.
2715
2716 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2717
2718         Minor clean-up of prepare-ChangeLog script.
2719
2720         Reviewed by Adam.
2721
2722         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2723         of a string.  Use multi-argument versions of open() and system() for flexibility and
2724         security.
2725
2726 2007-10-24  Alice Liu  <alice.liu@apple.com>
2727
2728         Reviewed by Oliver.
2729
2730         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2731
2732         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2733         replay the saved events when we're still processing the mousedown that starts the drag
2734         * DumpRenderTree/win/EventSender.cpp:
2735         (doMouseMove):
2736         * DumpRenderTree/win/UIDelegate.cpp:
2737         (UIDelegate::doDragDrop):
2738
2739 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2740
2741         Reviewed by Sam, Steve and Darin.
2742
2743         - Stubbed out the WebScriptDebugListener functionality in the Server
2744         Connection class to prepare it for receiving those callbacks.
2745         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2746         and the ServerConnection to not need to be initialized with a server
2747         name, since that is not the way we connect to the WebKit server. 
2748
2749         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2750         no exception.  Now it only loggs when there is an exception
2751         (DebuggerDocument::willExecuteStatement):
2752         (DebuggerDocument::didEnterCallFrame):
2753         (DebuggerDocument::willLeaveCallFrame):
2754         (DebuggerDocument::windowScriptObjectAvailable):
2755         (DebuggerDocument::callFunctionOnObject):
2756         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2757         to be instantiated with a server's name.
2758         (DebuggerClient::DebuggerClient):
2759         (DebuggerClient::didFinishLoadForFrame):
2760         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2761         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2762         a server name.
2763         (Drosera::init):
2764         (Drosera::initServer):
2765         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2766         instantiated with a server's name.
2767         * Drosera/win/ServerConnection.cpp: 
2768         (ServerConnection::ServerConnection): No longer needs a server name
2769         (ServerConnection::~ServerConnection): Only release the global context
2770         if there is one.
2771         (ServerConnection::serverConnectionDidDie): Stub for
2772         IWebScriptDebugListener
2773         (ServerConnection::QueryInterface): ditto
2774         (ServerConnection::AddRef): ditto
2775         (ServerConnection::Release): ditto
2776         (ServerConnection::didLoadMainResourceForDataSource): ditto
2777         (ServerConnection::didParseSource): ditto
2778         (ServerConnection::failedToParseSource): ditto
2779         (ServerConnection::didEnterCallFrame): ditto
2780         (ServerConnection::willExecuteStatement): ditto
2781         (ServerConnection::willLeaveCallFrame): ditto
2782         (ServerConnection::exceptionWasRaised): ditto
2783         * Drosera/win/ServerConnection.h: Stubbed out the
2784         IWebScriptDebugListener functions, and this class no longer needs to be
2785         instantiated with a server name.
2786
2787 2007-10-24  Lars Knoll  <lars@trolltech.com>
2788
2789         Reviewed by Simon.
2790
2791         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2792
2793         * DumpRenderTree/qt/jsobjects.h:
2794
2795 2007-10-24  Lars Knoll  <lars@trolltech.com>
2796
2797         Reviewed by Simon.
2798
2799         add another command.
2800
2801         * DumpRenderTree/qt/jsobjects.cpp:
2802         (TextInputController::doCommand):
2803
2804 2007-10-24  Lars Knoll  <lars@trolltech.com>
2805
2806         Reviewed by Simon.
2807
2808         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2809
2810         * DumpRenderTree/qt/jsobjects.cpp:
2811         (EventSender::keyDown):
2812         * DumpRenderTree/qt/jsobjects.h:
2813
2814 2007-10-24  Lars Knoll  <lars@trolltech.com>
2815
2816         Reviewed by Simon.
2817
2818         implement eventSender.keyDown().
2819
2820         * DumpRenderTree/qt/jsobjects.cpp:
2821         (EventSender::keyDown):
2822
2823 2007-10-24  Lars Knoll  <lars@trolltech.com>
2824
2825         Reviewed by Simon.
2826
2827         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2828
2829         * DumpRenderTree/qt/DumpRenderTree.cpp:
2830         (WebCore::DumpRenderTree::DumpRenderTree):
2831         (WebCore::DumpRenderTree::initJSObjects):
2832         * DumpRenderTree/qt/jsobjects.cpp:
2833         (TextInputController::doCommand):
2834
2835 2007-10-24  Lars Knoll  <lars@trolltech.com>
2836
2837         Reviewed by Simon.
2838
2839         first bit of implementation for the textinputcontroller.
2840
2841         * DumpRenderTree/qt/DumpRenderTree.cpp:
2842         (WebCore::DumpRenderTree::DumpRenderTree):
2843         * DumpRenderTree/qt/DumpRenderTree.h:
2844         * DumpRenderTree/qt/jsobjects.cpp:
2845         (TextInputController::TextInputController):
2846         (TextInputController::doCommand):
2847         * DumpRenderTree/qt/jsobjects.h:
2848
2849 2007-10-24  Lars Knoll  <lars@trolltech.com>
2850
2851         Reviewed by Simon.
2852
2853         make the man webpage believe it has focus, so the editing tests work correctly.
2854
2855         * DumpRenderTree/qt/DumpRenderTree.cpp:
2856         (WebCore::DumpRenderTree::DumpRenderTree):
2857
2858 2007-10-24  Lars Knoll  <lars@trolltech.com>
2859
2860         Reviewed by Simon.
2861
2862         implement layoutTestController.dumpEditingCallbacks() correctly.
2863
2864         * DumpRenderTree/qt/DumpRenderTree.cpp:
2865         (WebCore::DumpRenderTree::DumpRenderTree):
2866         * DumpRenderTree/qt/jsobjects.cpp:
2867         (LayoutTestController::reset):
2868         (LayoutTestController::dumpEditingCallbacks):
2869
2870 2007-10-24  Lars Knoll  <lars@trolltech.com>
2871
2872         Reviewed by Simon.
2873
2874         Implement support for testing editing.
2875
2876         * DumpRenderTree/qt/DumpRenderTree.cpp:
2877         (WebCore::DumpRenderTree::DumpRenderTree):
2878
2879 2007-10-23  Sam Weinig  <sam@webkit.org>
2880
2881         Check for null BSTR that can be passed to the UIDelegate methods
2882         from javascript null and undefined.  Fixes a failing test case on
2883         Windows (fast/dom/Window/alert-undefined.html)
2884
2885         Reviewed by Eric Seidel.
2886
2887         * DumpRenderTree/win/UIDelegate.cpp:
2888         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2889         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2890         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2891         (UIDelegate::webViewAddMessageToConsole):
2892
2893 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2894
2895         Reviewed by Darin.
2896         
2897         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2898
2899         * Scripts/build-testkjs:
2900
2901 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2902
2903         Reviewed by Darin.
2904
2905         - add wrapper that finds the right copy of testkjs
2906         
2907         * Scripts/sunspider-compare-results: Added.
2908
2909 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2910
2911         Reviewed by Sam.
2912
2913         - After talking with Steve I now see that the WebKit server must be
2914         running for DCOM to create the distributed objects, which makes sense
2915         and currently WebKit only allows one instance to be running at a time
2916         which avoids accidentally connecting to the wrong server
2917         - In light of this I have removed the code for the attach box and
2918         NotificationServer and known server names, since they are all extranious
2919         now.
2920
2921         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2922         names.
2923         (_tWinMain): Uses init instead of initUI.
2924         (droseraWndProc): No longer creats an attach dialog box.
2925         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2926         it's not manditory to call init before doing COM stuff.
2927         (Drosera::init): calls initUI and will call attach when the
2928         functionality exists. 
2929         (Drosera::initUI): Has changed very little.
2930         (Drosera::attach): Changed the signature to reflect that we no longer
2931         need the dictionary of known server names.
2932         * Drosera/win/Drosera.h: Removed notification classes and known server
2933         names.  Also renamed and moved some functions.
2934         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2935         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2936         headers to the resources folder. 
2937         * Drosera/win/resource.h: Removed the Attach box.
2938
2939 2007-10-22  Adam Roben  <aroben@apple.com>
2940
2941         Windows build fix
2942
2943         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2944
2945 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2946
2947         - Removed a leak that was fixed.
2948
2949         * Scripts/run-webkit-tests:
2950
2951 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2952
2953         Reviewed by Darin.
2954
2955         - Changed the Client so that the DebuggerDocument now own the
2956         ServerConnection.  This simplifies ownership and cleanup. 
2957
2958         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2959         ServerConnection.
2960         (DebuggerClient::initWithServerName):
2961         (DebuggerClient::didFinishLoadForFrame):
2962         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2963         ServerConnection.
2964         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2965         until after we have a server which we are attached to.
2966         (Drosera::initUI):
2967         (Drosera::attach):
2968         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2969         out previously.
2970
2971 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2972
2973         Reviewed by Nikolas.
2974
2975         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2976
2977         * Scripts/run-javascriptcore-tests:
2978
2979 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2980
2981         Reviewed by Nikolas.
2982
2983         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2984
2985         * Scripts/build-drosera:
2986         * Scripts/build-dumprendertree:
2987         * Scripts/build-testkjs:
2988         * Scripts/build-webkit:
2989         * Scripts/run-javascriptcore-tests:
2990         * Scripts/run-sunspider:
2991         * Scripts/run-webkit-tests:
2992         * Scripts/webkitdirs.pm:
2993
2994 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2995
2996         Reviewed by Mark Rowe.
2997         
2998         Fix for local database support after r26879
2999         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
3000
3001         * Scripts/build-webkit:
3002
3003 2007-10-22  Holger Freyther  <zecke@selfish.org>
3004
3005         Reviewed by Simon Hausmann <hausmann@kde.org>.
3006
3007         - Do not build testkjs as an application bundle. This is
3008         needed for run-javascriptcore-tests on OSX.
3009         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
3010         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
3011         as we do not have -rpath on OSX.
3012
3013         * DumpRenderTree/qt/DumpRenderTree.pro:
3014         * Scripts/run-webkit-tests:
3015
3016 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3017
3018         Reviewed by aroben.
3019
3020         Fix support for Signed-off-by detection in prepare-ChangeLog
3021         --git-commit. The Signed-off-by tag does not appear in the header
3022         but usually at the end.
3023
3024         * Scripts/prepare-ChangeLog:
3025
3026 2007-10-21  Mark Rowe  <mrowe@apple.com>
3027
3028         Reviewed by Eric.
3029
3030         Fix run-javascriptcore-tests for Gtk.
3031
3032         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
3033
3034 2007-10-20  Eric Seidel  <eric@webkit.org>
3035
3036         Reviewed by aroben.
3037
3038         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
3039
3040 2007-10-20  Eric Seidel  <eric@webkit.org>
3041
3042         Reviewed by darin.
3043         
3044         Add improved argument handling to run-sunspider, including
3045         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
3046         Also re-factor code into subroutines
3047
3048         * Scripts/build-dumprendertree: removed bogus comments
3049         * Scripts/build-testkjs: Added.
3050         * Scripts/run-javascriptcore-tests: use build-testkjs
3051         * Scripts/run-sunspider: improved argument handling, abstraction
3052         * Scripts/run-webkit-tests: improved abstraction
3053
3054 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
3055
3056         Not reviewed, Windows build fix.
3057
3058         * DumpRenderTree/win/EventSender.cpp:
3059         (keyDownCallback):
3060
3061 2007-10-20  Darin Adler  <darin@apple.com>
3062
3063         Reviewed by Tim Hatcher.
3064
3065         - http://bugs.webkit.org/show_bug.cgi?id=15544
3066           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
3067           not rely on Apple-specific key codes
3068
3069         * DumpRenderTree/mac/EventSendingController.mm:
3070         (-[EventSendingController keyDown:withModifiers:]):
3071         Added named key "rightArrow". Later we could have a whole table of these.
3072         Also tweaked modifiers code a little.
3073
3074         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
3075
3076 2007-10-19  Darin Adler  <darin@apple.com>
3077
3078         Reviewed by Eric.
3079
3080         - http://bugs.webkit.org/show_bug.cgi?id=15566
3081           possible fix for leak seen in DumpRenderTree
3082
3083         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
3084         Delete the item if it's not put on the queue, since the caller has
3085         no way of knowing that. Would be better to have the parameter type
3086         be auto_ptr to express the fact that we take ownership.
3087
3088         - unrelated change
3089
3090         * Drosera/mac/main.m: Add missing include.
3091
3092 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3093
3094         Reviewed by Adam.
3095
3096         - This change should be identical but for some reason was not working
3097         on my machine.
3098
3099         * Scripts/prepare-ChangeLog:
3100
3101 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3102
3103         Reviewed by Oliver and Tim.
3104
3105         - Made use of RetainPtr to avoid retain and release issues and moved the
3106         log function to DebuggerDocumentPlatform, which seems to be a more
3107         logical place for it to live.
3108         - Also moved knownServers from the ServerConnection to
3109         DebuggerApplication to match the Windows code and because it makes sense
3110         that a connection knows its own server but not all of them.
3111
3112         * Drosera/mac/DebuggerClient.h: Moved the log function to
3113           DebuggerDocumentPlatform.
3114         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
3115           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
3116           call for the server name up from the ServerConnection class.
3117         (-[DebuggerClient dealloc]):
3118         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
3119           for the server name up from the ServerConnection.
3120         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
3121         (DebuggerDocument::platformPause):
3122         (DebuggerDocument::platformResume):
3123         (DebuggerDocument::platformStepInto):
3124         (DebuggerDocument::platformEvaluateScript):
3125         (DebuggerDocument::getPlatformCurrentFunctionStack):
3126         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3127         (DebuggerDocument::platformValueForScopeVariableNamed):
3128         (DebuggerDocument::platformLog): Log directly from here. No need to call
3129           DebuggerClient.
3130         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
3131           way I see it, a ServerConnection should only know about its connection
3132           and the group of all possible servers should be kept by the
3133           application.
3134         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
3135           currentServerName, it makes sense that the connection should know that
3136           name.
3137         (-[ServerConnection currentServerName]):
3138
3139 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3140
3141         Reviewed by Adam.
3142
3143         - Integrated changes from mac drosera.  Recently I've encapsulated
3144         out the server connection object from the rest of Drosera because
3145         it is very platform dependent right now and RPC is not implemented on
3146         windows.  This functionality, of communicating with the WebKit server
3147         is the next area I will be focusing on in Windows.
3148
3149         - Other changes and cleanup were made to organize the code and add notes
3150         on which parts still need work.  Also some mac code is added and
3151         commented out, to act as pseudocode for the logic of those parts.
3152
3153         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
3154           pointer.
3155         * Drosera/config.h: Added whitespace.
3156         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
3157           these files got moved into Drosera.h/cpp
3158         * Drosera/win/DebuggerApplication.h: Removed.
3159         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
3160           happened here to better match the logic flow of the same code on the 
3161           mac side and to use the new ServerConnection class.
3162         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
3163         (DebuggerClient::initWithServerName): Initializer that will set up the
3164           class to use a ServerConnection object.  This was necessary so I could
3165           create a DebuggerClient without having to initilaize it at
3166           construction.
3167         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
3168           will be the UIDelegate and FrameLoadDelegate.
3169         (DebuggerClient::AddRef): For IUnknown.
3170         (DebuggerClient::Release): For IUnknown.
3171         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
3172           this still needs to set the global context of the server, but
3173           IWebFrame does not have an accessor for the global context yet. 
3174         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
3175           this is a pass through for the same function in the document.
3176         (DebuggerClient::didReceiveTitle): Unimplemented part of
3177           FrameLoadDelegate this would change the title of the window.
3178         (DebuggerClient::createWebViewWithRequest): Part of the
3179           FrameLoadDelegate.  This is about new windows via Window.open() and
3180           how their delegates are set.
3181         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
3182           UIDelegate.  Just a debug function for printing messages.
3183         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
3184           because the Client should be the UIDelegate and FrameLoadDelegate
3185           to match the delegates on mac.
3186         (DebuggerClient::webViewLoaded): Added accessor method.
3187         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3188           forgotten to add this file before.  This is where the platform
3189           dependent versions of the Documents functions live. Most of these are
3190           unimplemented because some piece of functionality does not exist on
3191           Windows yet.
3192         (DebuggerDocument::platformPause):
3193         (DebuggerDocument::platformResume):
3194         (DebuggerDocument::platformStepInto):
3195         (DebuggerDocument::platformEvaluateScript):
3196         (DebuggerDocument::getPlatformCurrentFunctionStack):
3197         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3198         (DebuggerDocument::platformValueForScopeVariableNamed):
3199         (DebuggerDocument::platformLog):
3200         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3201           responsibilities becaue they belong in the Client. Also I laid the
3202           groundwork for attaching Drosera to a WebKit process
3203         (attachWndProc): Now if a server is selected the Client becomes it's
3204           delegate.
3205         (Drosera::Drosera): Added the construction of the Client and dictionary
3206           of server names. 
3207         (Drosera::initUI): This is no longer the delegates, the Client is.
3208         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3209           state. 
3210         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3211           notification registration when it's possible to implement.
3212         (Drosera::serverLoaded): Ditto
3213         (Drosera::serverUnloaded): Ditto
3214         (Drosera::attach): Attach Drosera to the WebKit server.
3215         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3216         (Drosera::getInst): 
3217         (Drosera::setInst):
3218         (Drosera::knownServers):
3219         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3220           and added the ServerConnection.
3221         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3222         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3223           Most of the functions are completely unimlemented because they cannot
3224           connect with the WebKit server, because one does not exist on Windows
3225           yet.
3226         (ServerConnection::initWithServerName): 
3227         (ServerConnection::~ServerConnection):
3228         (ServerConnection::setGlobalContext):
3229         (ServerConnection::pause):
3230         (ServerConnection::resume):
3231         (ServerConnection::stepInto):
3232         (ServerConnection::switchToServerNamed):
3233         (ServerConnection::applicationTerminating):
3234         (ServerConnection::serverConnectionDidDie):
3235         (ServerConnection::currentFrame):
3236         * Drosera/win/ServerConnection.h: Added. Ditto.
3237         (ServerConnection::ServerConnection):
3238
3239 2007-10-19  Alice Liu  <alice.liu@apple.com>
3240
3241         Reviewed by Darin.
3242
3243         Fix for these broken layout tests on Windows:
3244         
3245         fast/forms/focus-selection-input.html
3246         fast/forms/focus-selection-textarea.html
3247         fast/forms/select-accesskey.html
3248         
3249         * DumpRenderTree/win/EventSender.cpp:
3250         (keyDownCallback):
3251         correct the VK code for alt key.
3252         
3253 2007-10-19  Eric Seidel  <eric@webkit.org>
3254
3255         Reviewed by Mark Rowe.
3256         
3257         Make the GtkLauncher code slightly more readable.
3258
3259         * GtkLauncher/main.cpp:
3260         (setupMainMenu): Added.
3261         (setupMainWindowUI): Added.
3262         (main):
3263
3264 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3265
3266         Rubber stamped by Adam.
3267         
3268         - don't delay-load WebKit in DumpRenderTree.
3269
3270         * DumpRenderTree/win/DumpRenderTree.vcproj:
3271
3272 2007-10-18  Dan Bernstein  <mitz@apple.com>
3273
3274         Reviewed by Adam Roben.
3275
3276         - fix <rdar://problem/5313523>
3277         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3278
3279         * DumpRenderTree/mac/DumpRenderTree.mm:
3280         (dump): Changed to use _responseMIMEType.
3281
3282 2007-10-17  Adam Roben  <aroben@apple.com>
3283
3284         Make it possible to have Windows-specific tests and results
3285
3286         When searching for tests to run and the Skipped file, we will only
3287         look in platform/win and the cross-platform directory. When looking
3288         for expected results, we will look in platform/win, then
3289         platform/mac-leopard, then platform/mac, then finally the
3290         cross-platform directory.
3291
3292         Reviewed by Sam.
3293
3294         * Scripts/run-webkit-tests:
3295         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3296         searching in the cross-platform directory.
3297         (sub buildPlatformHierarchy): Removed some unneeded calls to
3298         dirname/basename.
3299
3300 2007-10-17  Adam Roben  <aroben@apple.com>
3301
3302         Add back the call to register WebKit that we had before WebKitInitializer existed
3303
3304         This is needed to ensure that the right WebKit is used when
3305         instantiating COM objects.
3306
3307         Reviewed by Oliver.
3308
3309         * DumpRenderTree/win/debug_internal.vsprops: Define
3310         DEBUG_WEBKIT_HAS_SUFFIX.
3311         * DumpRenderTree/win/DumpRenderTree.cpp:
3312         (initialize):
3313
3314 2007-10-17  Adam Roben  <aroben@apple.com>
3315
3316         Import File::Basename in webkitdirs since we use it
3317
3318         * Scripts/webkitdirs.pm:
3319
3320 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3321
3322         - Updated the tiger leaks list to make the internal bots green.
3323
3324         * Scripts/run-webkit-tests:
3325
3326 2007-10-17  Adam Roben  <aroben@apple.com>
3327
3328         Build fix for VC++ Express
3329
3330         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3331         and ole32.lib.
3332
3333 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3334
3335         Reviewed by Sam.
3336
3337         - Minor mac improvements based on observations I made while implementing the
3338         Windows code.
3339
3340         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3341         then hand it to the Client who will retain it, it should just be the client who
3342         creates and owns the server.
3343         (-[DebuggerApplication attach:]):
3344         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3345         * Drosera/mac/DebuggerClient.mm: Creates the server.
3346         (-[DebuggerClient initWithServerName:]):
3347         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3348         can instead forward declare what it needs.
3349
3350 2007-10-16  Darin Adler  <darin@apple.com>
3351
3352         Reviewed by Geoff Garen.
3353
3354         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3355         want to turn failing tests into platform-specific test results. Also did a
3356         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3357         would take the type of results into account only some of the time.
3358
3359 2007-10-16  Adam Roben  <aroben@apple.com>
3360
3361         Add a new nightly launcher script for Windows
3362
3363         This new script is for versions of Safari that don't delay-load
3364         WebKit. I had to make FindSafari be able to print out the nightly
3365         launcher script on stdout because Windows shell scripts can't capture
3366         the output from a command into an environment variable.
3367
3368         Reviewed by Steve.
3369
3370         * FindSafari/FindSafari.cpp:
3371         (_tmain): Added /printSafariLauncher option.
3372         * Scripts/run-webkit-nightly.cmd: Added.
3373
3374 2007-10-16  Adam Roben  <aroben@apple.com>
3375
3376         Replace WebKitInitializer with FindSafari
3377
3378         We now rely on setting the PATH environment variable to tell Windows
3379         where to find WebKit and its dependencies (similar to
3380         DYLD_FRAMEWORK_PATH on Mac).
3381
3382         This change also make DumpRenderTree no longer delay-load WebKit.
3383
3384         Reviewed by Sam.
3385
3386         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3387         FindSafari.
3388         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3389         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3390         WebKitInitializer, don't delay-load WebKit.
3391         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3392         * Scripts/run-webkit-tests: Ditto.
3393         * Scripts/webkitdirs.pm:
3394         (sub setPathForRunningWebKitApp): Added.
3395         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3396         * WebKitInitializer/WebKitInitializer.h: Removed.
3397         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3398         * WebKitInitializer/debug.vsprops: Removed.
3399         * WebKitInitializer/debug_internal.vsprops: Removed.
3400         * WebKitInitializer/release.vsprops: Removed.
3401
3402 2007-10-16  Adam Roben  <aroben@apple.com>
3403
3404         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3405
3406         http://bugs.webkit.org/show_bug.cgi?id=15532
3407
3408         FindSafari simply prints the location of an installed Safari.exe on
3409         stdout.
3410
3411         Reviewed by Darin.
3412
3413         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3414         (getStringValue):
3415         (getWebViewCLSID):
3416         (getInstalledWebKitDirectory):
3417         (_tmain):
3418         * FindSafari/FindSafari.vcproj: Added.
3419         * Scripts/webkitdirs.pm:
3420         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3421
3422 2007-10-16  Adam Roben  <aroben@apple.com>
3423
3424         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3425
3426         Reviewed by Kevin McCullough.
3427
3428         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3429         when referring to WebKit.dll.
3430         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3431         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3432         * DumpRenderTree/win/release.vsprops: Ditto.
3433         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3434         never have a _debug suffix on WebKit.dll.
3435         * WebKitInitializer/WebKitInitializer.cpp:
3436         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3437         specified.
3438         * WebKitInitializer/debug_internal.vsprops: Added
3439         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3440
3441 2007-10-16  Darin Adler  <darin@apple.com>
3442
3443         Reviewed by Adele.
3444
3445         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3446         Remove now-unneeded control/alt key hack; the tests have been updated.
3447
3448 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3449
3450         - Updated leaks list because our internal bot upgraded it's version of leopard and 
3451         one of the leaks was fixed between that revision and the bot's previous version of
3452         leopard.
3453
3454         * Scripts/run-webkit-tests:
3455
3456 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3457
3458         Reviewed by Tim.
3459
3460         - I encapsulated out the server connecton functionality because it is a specific part
3461         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3462         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3463         Windows.  So the majority of this patch is moving preexisting functionality.
3464
3465         - Also I removed the prefix header and changed to use config.h because it is more
3466         standard on how we use config.h in windows and it didn't make much sense to keep
3467         the prefix header and the config.h
3468
3469         * Drosera/DebuggerDocument.cpp:
3470         (DebuggerDocument::DebuggerDocument):
3471         * Drosera/DebuggerDocument.h:
3472         * Drosera/config.h:
3473         * Drosera/mac/DebuggerApplication.mm:
3474         (-[DebuggerApplication attach:]):
3475         * Drosera/mac/DebuggerClient.h:
3476         * Drosera/mac/DebuggerClient.mm:
3477         (-[DebuggerClient initWithServerConnection:]):
3478         (-[DebuggerClient dealloc]):
3479         (-[DebuggerClient windowDidLoad]):
3480         (-[DebuggerClient windowWillClose:]):
3481         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3482         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3483         * Drosera/mac/DebuggerDocumentPlatform.mm:
3484         (DebuggerDocument::platformPause):
3485         (DebuggerDocument::platformResume):
3486         (DebuggerDocument::platformStepInto):
3487         (DebuggerDocument::platformEvaluateScript):
3488         (DebuggerDocument::getPlatformCurrentFunctionStack):
3489         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3490         (DebuggerDocument::platformValueForScopeVariableNamed):
3491         (DebuggerDocument::platformLog):
3492         * Drosera/mac/Drosera.pch: Removed.
3493         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3494         * Drosera/mac/ServerConnection.h: Added.
3495         * Drosera/mac/ServerConnection.mm: Added.
3496         (-[ServerConnection initWithServerName:]):
3497         (-[ServerConnection dealloc]):
3498         (-[ServerConnection setGlobalContext:]):
3499         (-[ServerConnection pause]):
3500         (-[ServerConnection resume]):
3501         (-[ServerConnection stepInto]):
3502         (-[ServerConnection switchToServerNamed:]):
3503         (-[ServerConnection applicationTerminating:]):
3504         (-[ServerConnection serverConnectionDidDie:]):
3505         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3506         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3507         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3508         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3509         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3510         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3511         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3512         (-[ServerConnection currentFrame]):
3513         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3514         (-[ServerConnection knownServers]):
3515
3516 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3517
3518         Reviewed by Eric.
3519
3520         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3521           Script to automatically search nightly builds for regressions (bisect-builds)
3522
3523         * Scripts/bisect-builds: Added.
3524
3525 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3526
3527         Reviewed by Darin.
3528
3529         - New JavaScript benchmark
3530         http://bugs.webkit.org/show_bug.cgi?id=15515
3531
3532         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3533         current development or release build of JavaScriptCore.
3534
3535 2007-10-15  Mark Rowe  <mrowe@apple.com>
3536
3537         Reviewed by Sam.
3538
3539         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3540
3541         * Scripts/webkitdirs.pm:
3542         - Change checkArgv to remove the options from @ARGV to prevent
3543         them from interfering with further option processing.
3544         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3545         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3546         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3547         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3548
3549 2007-10-15  Darin Adler  <darin@apple.com>
3550
3551         Reviewed by Sam.
3552
3553         - added logging of window.prompt and window.confirm
3554
3555         * DumpRenderTree/mac/UIDelegate.mm:
3556         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3557         Implement the recommended delegate rather than the deprecated one.
3558         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3559         Added.
3560         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3561         Added.
3562
3563         * DumpRenderTree/win/UIDelegate.h:
3564         * DumpRenderTree/win/UIDelegate.cpp:
3565         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3566         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3567         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3568         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3569
3570 2007-10-15  Alice Liu  <alice.liu@apple.com>
3571
3572         Reviewed by Sam Weinig.
3573
3574         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3575
3576         * DumpRenderTree/win/DumpRenderTree.cpp:
3577         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3578         (main): allocate the global policy delegate for DRT's custom use
3579         * DumpRenderTree/win/DumpRenderTree.vcproj:
3580         Adding files to project
3581         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3582         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3583         (LayoutTestController::setCustomPolicyDelegate):
3584         set the webview's policy delegate to DRT's custom one if the test requests it.
3585         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3586         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3587         (PolicyDelegate::PolicyDelegate):
3588         (PolicyDelegate::QueryInterface):
3589         (PolicyDelegate::AddRef):
3590         (PolicyDelegate::Release):
3591         (PolicyDelegate::decidePolicyForNavigationAction):
3592         * DumpRenderTree/win/PolicyDelegate.h: Added.
3593         (PolicyDelegate::decidePolicyForNewWindowAction):
3594         (PolicyDelegate::decidePolicyForMIMEType):
3595         (PolicyDelegate::unableToImplementPolicyWithError):
3596
3597 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3598
3599         Reviewed by Mark.
3600
3601         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3602         when querying for QMAKE_MKSPECS.
3603
3604 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3605
3606         Reviewed by Adam Roben.
3607         
3608         Fix run-webkit-tests is too greedy calculating platform hierarchy
3609         http://bugs.webkit.org/show_bug.cgi?id=15465
3610         
3611         Fix run-webkit-tests being too greedy in trying to split the platform name up
3612         causing it to try and find tests in every directory above the first "-" in the
3613         path to the LayoutTests
3614
3615         * Scripts/run-webkit-tests:
3616
3617 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com