WebKitTools/ChangeLog

   1 2009-11-21  Eric Seidel  <eric@webkit.org>
   2
   3         No review.  Fixing a typo from the previous patch for bug 31767.
   4
   5         AbstractQueue.run_bugzilla_tool throws an exception
   6         https://bugs.webkit.org/show_bug.cgi?id=31769
   7
   8         * Scripts/modules/commands/queues.py:
   9
  10 2009-11-21  Eric Seidel  <eric@webkit.org>
  11
  12         Reviewed by Adam Barth.
  13
  14         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
  15         https://bugs.webkit.org/show_bug.cgi?id=31767
  16
  17         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
  18         Since we don't have a good way to test BugzillaTool pieces, I've
  19         left out a test for now.
  20
  21         * Scripts/bugzilla-tool:
  22          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
  23         * Scripts/modules/commands/queues.py:
  24          - Use tool.path() instead of __file__.
  25         * Scripts/modules/multicommandtool.py:
  26          - Add a new path() method to MultiComandTool.
  27         * Scripts/modules/multicommandtool_unittest.py:
  28          - Provide a path() method.  Little point in testing this mock implementation.
  29
  30 2009-11-21  Adam Barth  <abarth@webkit.org>
  31
  32         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
  33         WebKitTools.
  34
  35         * Scripts/modules/commands/download.py:
  36
  37 2009-11-21  Adam Barth  <abarth@webkit.org>
  38
  39         Reviewed by Eric Seidel.
  40
  41         Convert check-style to use LandingSequence
  42         https://bugs.webkit.org/show_bug.cgi?id=31763
  43
  44         Instead of manipulating the working copy by hand, we should use the
  45         LandingSequence in CheckStyle.  This will make this code eaiser to
  46         test.
  47
  48         * Scripts/modules/commands/download.py:
  49
  50 2009-11-20  Adam Barth  <abarth@webkit.org>
  51
  52         Reviewed by Eric Seidel.
  53
  54         Unit test query commands
  55         https://bugs.webkit.org/show_bug.cgi?id=31755
  56
  57         These tests are pretty rough, but hopefully they'll grow.
  58
  59         * Scripts/modules/commands/queries_unittest.py: Added.
  60         * Scripts/modules/mock_bugzillatool.py: Added.
  61         * Scripts/run-webkit-unittests:
  62
  63 2009-11-20  Eric Seidel  <eric@webkit.org>
  64
  65         Reviewed by Adam Barth.
  66
  67         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
  68         https://bugs.webkit.org/show_bug.cgi?id=31758
  69
  70         * Scripts/modules/multicommandtool.py:
  71          - Allow passing of explicit commands to MultiCommandTool.__init__
  72         * Scripts/modules/multicommandtool_unittest.py:
  73          - Use new Command.name naming system.
  74          - Test Command auto-discovery.
  75         * Scripts/modules/workqueue.py:
  76          - bug_id no longer exists, use patch['bug_id'] instead.
  77         * Scripts/modules/workqueue_unittest.py:
  78          - WorkQueues require names now.
  79          - should_proceed_with_work_item must return a patch object.
  80
  81 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
  82
  83         Reviewed by Beth Dakin.
  84
  85         WAI-ARIA: add support for aria-owns
  86         https://bugs.webkit.org/show_bug.cgi?id=31702
  87
  88         * DumpRenderTree/AccessibilityUIElement.cpp:
  89         (ariaOwnsElementAtIndexCallback):
  90         (AccessibilityUIElement::getJSClass):
  91         * DumpRenderTree/AccessibilityUIElement.h:
  92         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  93         (AccessibilityUIElement::ariaOwnsElementAtIndex):
  94         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  95         (AccessibilityUIElement::ariaOwnsElementAtIndex):
  96         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  97         (AccessibilityUIElement::ariaOwnsElementAtIndex):
  98
  99 2009-11-20  Eric Seidel  <eric@webkit.org>
 100
 101         Reviewed by Adam Barth.
 102
 103         Fix exception thrown when running the commit-queue.
 104
 105         * Scripts/modules/statusbot.py: patch is optional.
 106         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
 107
 108 2009-11-20  Eric Seidel  <eric@webkit.org>
 109
 110         Reviewed by Adam Barth.
 111
 112         Teach the StatusBot how to support more than just the commit-queue
 113         https://bugs.webkit.org/show_bug.cgi?id=31754
 114
 115         * Scripts/modules/workqueue.py: Another typo.
 116
 117 2009-11-20  Eric Seidel  <eric@webkit.org>
 118
 119         Reviewed by Adam Barth.
 120
 121         Teach the StatusBot how to support more than just the commit-queue
 122         https://bugs.webkit.org/show_bug.cgi?id=31754
 123
 124         * Scripts/modules/commands/queues.py: Fix silly typo.
 125
 126 2009-11-20  Eric Seidel  <eric@webkit.org>
 127
 128         Reviewed by Adam Barth.
 129
 130         Teach the StatusBot how to support more than just the commit-queue
 131         https://bugs.webkit.org/show_bug.cgi?id=31754
 132
 133         * CommitQueueStatus/index.yaml:
 134          - Add indices required for the new queries.
 135         * CommitQueueStatus/queue_status.py:
 136          - Add a patch-status page and move update_status to update-status.
 137          - Only display "commit-queue" status records for the commit-queue.
 138          - Add support for a queue_name property on status records.
 139          - Fix _int_from_request to actually work.
 140         * CommitQueueStatus/update_status.html:
 141          - Add support for a queue_name on status records.
 142          - Remove unused list of bug ids.
 143          * Scripts/modules/commands/queues.py
 144           - Make the queues pass the patch instead of the bug_id to StatusBot.
 145         * Scripts/modules/statusbot.py:
 146          - Support passing the queue_name to the status updates.
 147          - Support fetching patch status with patch_status().
 148         * Scripts/modules/workqueue.py:
 149          - Pass the patch to the StatusBot instead of the bug_id.
 150          - Let WorkQueues have a name.
 151
 152 2009-11-20  Adam Barth  <abarth@webkit.org>
 153
 154         Reviewed by Eric Seidel.
 155
 156         Move bugzilla-tool commands into their own file
 157         https://bugs.webkit.org/show_bug.cgi?id=31752
 158
 159         This will let us write unit tests.
 160
 161         * Scripts/bugzilla-tool:
 162         * Scripts/modules/commands/__init__.py: Added.
 163         * Scripts/modules/commands/download.py: Added.
 164         * Scripts/modules/commands/queries.py: Added.
 165         * Scripts/modules/commands/queues.py: Added.
 166         * Scripts/modules/commands/upload.py: Added.
 167         * Scripts/modules/grammar.py: Added.
 168
 169 2009-11-20  Adam Barth  <abarth@webkit.org>
 170
 171         Reviewed by Eric Seidel.
 172
 173         BuildQueue should check if the tree is currently buildable
 174         https://bugs.webkit.org/show_bug.cgi?id=31744
 175
 176         * Scripts/bugzilla-tool:
 177         * Scripts/modules/landingsequence.py:
 178         * Scripts/modules/webkitlandingscripts.py:
 179
 180 2009-11-20  Adam Barth  <abarth@webkit.org>
 181
 182         Reviewed by Eric Seidel.
 183
 184         Move prepare_clean_working_directory into the LandingSequence
 185         https://bugs.webkit.org/show_bug.cgi?id=31743
 186
 187         * Scripts/bugzilla-tool:
 188         * Scripts/modules/landingsequence.py:
 189
 190 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
 191
 192         Reviewed by Kenneth Rohde Christiansen.
 193
 194         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
 195         https://bugs.webkit.org/show_bug.cgi?id=30460
 196
 197         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
 198
 199         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 200         (pluginInvoke):
 201
 202 2009-11-20  Adam Barth  <abarth@webkit.org>
 203
 204         Reviewed by Eric Seidel.
 205
 206         Pass the port information to the child process
 207         https://bugs.webkit.org/show_bug.cgi?id=31736
 208
 209         We need to do this so the child process knows what to build!
 210
 211         * Scripts/bugzilla-tool:
 212         * Scripts/modules/landingsequence.py:
 213         * Scripts/modules/webkitport.py:
 214         * Scripts/modules/webkitport_unittest.py:
 215
 216 2009-11-20  Adam Barth  <abarth@webkit.org>
 217
 218         Reviewed by Eric Seidel.
 219
 220         Support Qt port in build-queue
 221         https://bugs.webkit.org/show_bug.cgi?id=31733
 222
 223         * Scripts/bugzilla-tool:
 224
 225 2009-11-20  Adam Barth  <abarth@webkit.org>
 226
 227         Reviewed by Eric Seidel.
 228
 229         Implement a build-queue
 230         https://bugs.webkit.org/show_bug.cgi?id=31725
 231
 232         Currently this just builds the first 10 patches in the review queue.
 233         We'll want to do something smarter soon.
 234
 235         * Scripts/bugzilla-tool:
 236
 237 2009-11-20  Adam Barth  <abarth@webkit.org>
 238
 239         Reviewed by Eric Seidel.
 240
 241         Make commit-queue and style-queue show up in help
 242         https://bugs.webkit.org/show_bug.cgi?id=31724
 243
 244         We need to store their names on their class to make these commands
 245         properly register themselves with MultiCommandTool.
 246
 247         * Scripts/bugzilla-tool:
 248
 249 2009-11-20  Adam Barth  <abarth@webkit.org>
 250
 251         Reviewed by Eric Seidel.
 252
 253         Implement bugzilla-tool build-attachment
 254         https://bugs.webkit.org/show_bug.cgi?id=31722
 255
 256         This command builds an attachment from bugzilla.  It leaves the built
 257         patch in the working copy.
 258
 259         * Scripts/bugzilla-tool:
 260         * Scripts/modules/landingsequence.py:
 261         * Scripts/modules/webkitlandingscripts.py:
 262
 263 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
 264
 265         Reviewed by Xan Lopez.
 266
 267         [GTK] DRT release event does not create the state correctly
 268         https://bugs.webkit.org/show_bug.cgi?id=31717
 269
 270         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
 271
 272 2009-11-20  Eric Seidel  <eric@webkit.org>
 273
 274         Reviewed by Adam Barth.
 275
 276         MultiCommandTool should find Command objects automatically instead of with a manual list
 277         https://bugs.webkit.org/show_bug.cgi?id=31710
 278
 279         * Scripts/bugzilla-tool:
 280         * Scripts/modules/multicommandtool.py:
 281          - Use some wild python-fu to crawl all the known subclasses of Command.
 282
 283 2009-11-20  Adam Barth  <abarth@webkit.org>
 284
 285         Unreviewed "build" fix.  Added missing import.
 286
 287         * Scripts/bugzilla-tool:
 288
 289 2009-11-20  Adam Barth  <abarth@webkit.org>
 290
 291         Unreviewed "build" fix.  I failed to update LandingSequence.test
 292         properly.
 293
 294         * Scripts/modules/landingsequence.py:
 295
 296 2009-11-20  Adam Barth  <abarth@webkit.org>
 297
 298         Reviewed by Eric Seidel.
 299
 300         Create LandingSequence as the all-sing, all-dance landing class
 301         https://bugs.webkit.org/show_bug.cgi?id=31709
 302
 303         Client can inherit from this class to carefully control exactly which
 304         steps they wish to have happen in the landing sequence.
 305
 306         * Scripts/bugzilla-tool:
 307         * Scripts/modules/landingsequence.py: Added.
 308         * Scripts/modules/webkitlandingscripts.py: Added.
 309
 310 2009-11-19  Adam Barth  <abarth@webkit.org>
 311
 312         Reviewed by Eric Seidel.
 313
 314         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
 315         https://bugs.webkit.org/show_bug.cgi?id=31707
 316
 317         This is to help when we implement build-attachment.
 318
 319         * Scripts/bugzilla-tool:
 320
 321 2009-11-19  Adam Barth  <abarth@webkit.org>
 322
 323         Reviewed by Eric Seidel.
 324
 325         Support Qt port in bugzilla-tool
 326         https://bugs.webkit.org/show_bug.cgi?id=31701
 327
 328         Now we support building with Qt!
 329
 330         * Scripts/bugzilla-tool:
 331         * Scripts/modules/webkitport.py: Added.
 332         * Scripts/modules/webkitport_unittest.py: Added.
 333         * Scripts/run-webkit-unittests:
 334
 335 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
 336
 337         Reviewed by Adam Barth.
 338
 339         Remove inserting stderr into patch in bugzilla-tool
 340         https://bugs.webkit.org/show_bug.cgi?id=29914
 341
 342         Modify SCM python module's run_command function to avoid return of stderr
 343         by default, so stderr won't be inserted into the patches.
 344         Modify the related unit test.
 345
 346         * Scripts/modules/scm.py:
 347         * Scripts/modules/scm_unittest.py:
 348
 349 2009-11-19  Eric Seidel  <eric@webkit.org>
 350
 351         Reviewed by Adam Barth.
 352
 353         bugzilla-tool needs per-command help
 354         https://bugs.webkit.org/show_bug.cgi?id=31697
 355
 356         Added support for "bugzilla-tool help command-name"
 357         and a unit test to make sure it works.
 358
 359         * Scripts/modules/multicommandtool.py:
 360         * Scripts/modules/multicommandtool_unittest.py:
 361
 362 2009-11-19  Eric Seidel  <eric@webkit.org>
 363
 364         Reviewed by Adam Barth.
 365
 366         Move MultiCommandTool and Command into a separate file and add some basic unit tests
 367         https://bugs.webkit.org/show_bug.cgi?id=31695
 368
 369         * Scripts/bugzilla-tool:
 370         * Scripts/modules/multicommandtool.py: Added.
 371         * Scripts/modules/multicommandtool_unittest.py: Added.
 372         * Scripts/run-webkit-unittests:
 373
 374 2009-11-19  Eric Seidel  <eric@webkit.org>
 375
 376         No review, just adding a FIXME.
 377
 378         Split out command parsing and help printing from BugzillaTool
 379         https://bugs.webkit.org/show_bug.cgi?id=31688
 380
 381         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
 382
 383 2009-11-19  Eric Seidel  <eric@webkit.org>
 384
 385         Reviewed by Adam Barth.
 386
 387         Split out command parsing and help printing from BugzillaTool
 388         https://bugs.webkit.org/show_bug.cgi?id=31688
 389
 390         * Scripts/bugzilla-tool:
 391          - Add new MultiCommandTool class to contain option parsing and help printing logic.
 392          - Rename private methods to use _ pattern.
 393          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
 394          -
 395
 396 2009-11-19  Eric Seidel  <eric@webkit.org>
 397
 398         Reviewed by Adam Barth.
 399
 400         Re-factor help printing to use modern python idioms
 401         https://bugs.webkit.org/show_bug.cgi?id=31685
 402
 403         * Scripts/bugzilla-tool:
 404
 405 2009-11-19  Eric Seidel  <eric@webkit.org>
 406
 407         Reviewed by Darin Adler.
 408
 409         commit-queue empty queue logs twice
 410         https://bugs.webkit.org/show_bug.cgi?id=31679
 411
 412         * Scripts/bugzilla-tool:
 413
 414 2009-11-19  Eric Seidel  <eric@webkit.org>
 415
 416         Reviewed by Darin Adler.
 417
 418         bugzilla-tool's reviewer/committer rejection message should be clearer
 419         https://bugs.webkit.org/show_bug.cgi?id=31126
 420
 421         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
 422
 423         * Scripts/modules/bugzilla.py:
 424
 425 2009-11-19  Eric Z. Ayers  <zundel@google.com>
 426
 427         Reviewed by Pavel Feldman.
 428
 429         Forces a WM_PAINT event on calling layoutTestController.display()
 430         in order to enable the timeline-paint.html test on Windows.
 431         ::UpdateWindow() does not force an event becaue the window is
 432         not visible.
 433
 434         https://bugs.webkit.org/show_bug.cgi?id=31402
 435
 436         * DumpRenderTree/win/DumpRenderTree.cpp:
 437         (displayWebView):
 438
 439 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
 440
 441         No review needed.
 442
 443         Added myself to committers list.
 444
 445         * Scripts/modules/committers.py:
 446
 447 2009-11-19  Adam Barth  <abarth@webkit.org>
 448
 449         Reviewed by Eric Seidel.
 450
 451         Bugzilla-tool command classes should match command names
 452         https://bugs.webkit.org/show_bug.cgi?id=31666
 453
 454         I renamed all the commands except CommitMessageForCurrentDiff because
 455         the new name would conflict with an existing class.
 456
 457         * Scripts/bugzilla-tool:
 458
 459 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
 460
 461         Reviewed by Gustavo Noronha Silva.
 462
 463         Web Inspector: Implement "show inspector" in WebKit GTK
 464         API and enable console tests.
 465
 466         https://bugs.webkit.org/show_bug.cgi?id=31669
 467
 468         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 469         (LayoutTestController::showWebInspector):
 470
 471 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 472
 473         Reviewed by Simon Hausmann.
 474
 475         Minor refactoring + more documentation.
 476
 477         * DumpRenderTree/qt/DumpRenderTree.cpp:
 478         (WebCore::clearHistory):
 479         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 480
 481 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
 482
 483         Reviewed by Eric Seidel.
 484
 485         Ignore websocket tests when --no-http is specified.
 486         https://bugs.webkit.org/show_bug.cgi?id=31662
 487
 488         * Scripts/run-webkit-tests:
 489
 490 2009-11-18  Adam Barth  <abarth@webkit.org>
 491
 492         Reviewed by Eric Seidel.
 493
 494         Normalize ' and " in bugzilla-tool
 495         https://bugs.webkit.org/show_bug.cgi?id=31655
 496
 497         We decided " is better than ' and we should be consistent.
 498
 499         * Scripts/bugzilla-tool:
 500
 501 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 502
 503         Reviewed by Kenneth Rohde Christiansen.
 504
 505         [Qt] Remove support for Qt v4.3 or older versions
 506         https://bugs.webkit.org/show_bug.cgi?id=29469
 507
 508         * DumpRenderTree/qt/DumpRenderTree.pro:
 509         * DumpRenderTree/qt/ImageDiff.pro:
 510
 511 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
 512
 513         Reviewed by Eric Seidel.
 514
 515         GitTest.test_create_binary_patch fails if /tmp is symlink
 516         https://bugs.webkit.org/show_bug.cgi?id=31536
 517
 518         * Scripts/modules/scm_unittest.py:
 519
 520 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
 521
 522         Reviewed by Darin Adler.
 523
 524         Configuration for Chromium Build Slaves.
 525
 526         https://bugs.webkit.org/show_bug.cgi?id=31442
 527
 528         * BuildSlaveSupport/build.webkit.org-config/config.json:
 529         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 530
 531 2009-11-18  Eric Seidel  <eric@webkit.org>
 532
 533         Reviewed by Darin Adler.
 534
 535         workqueue.py results in totally broken commit-queue UI
 536         https://bugs.webkit.org/show_bug.cgi?id=31645
 537
 538         * Scripts/bugzilla-tool:
 539          - Remove unneeded use of PatchCollection.
 540          - Grab a new copy of the cq'd patches every run of the queue.
 541
 542 2009-11-18  Sam Weinig  <sam@webkit.org>
 543
 544         Reviewed by Anders Carlsson.
 545
 546         Make the Mac Geolocation API async.
 547
 548         Update DRT to use the new async Mac Geolocation API.
 549
 550         * DumpRenderTree/mac/UIDelegate.mm:
 551         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
 552
 553 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 554
 555         Reviewed by Kenneth Rohde Christiansen.
 556
 557         Add and option to toggle HTML5 datalist support to build-webkit
 558         https://bugs.webkit.org/show_bug.cgi?id=31599
 559
 560         * Scripts/build-webkit:
 561
 562 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
 563
 564         Reviewed by Kevin Ollivier.
 565
 566         Enable wx plugin support using the Windows implementation as a base.
 567
 568         https://bugs.webkit.org/show_bug.cgi?id=31636
 569
 570         * wx/build/settings.py:
 571
 572 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 573
 574         Reviewed by Simon Hausmann.
 575
 576         Change the initialization order so that the controllers
 577         will be created before exporting them to the JS DOM window.
 578
 579         * DumpRenderTree/qt/DumpRenderTree.cpp:
 580         (WebCore::DumpRenderTree::DumpRenderTree):
 581
 582 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 583
 584         Reviewed by Simon Hausmann.
 585
 586         Fix a code copy and paste error. m_page should be page.
 587
 588         * DumpRenderTree/qt/DumpRenderTree.cpp:
 589         (WebCore::DumpRenderTree::createWindow):
 590
 591 2009-11-17  Mark Rowe  <mrowe@apple.com>
 592
 593         Reviewed by Alexey Proskuryakov.
 594
 595         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
 596
 597         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
 598         This prevents symlinks from confusing the descendant check.
 599
 600 2009-11-17  Mark Rowe  <mrowe@apple.com>
 601
 602         Reviewed by Alexey Proskuryakov.
 603
 604         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
 605
 606         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
 607         server to be up rather than having run-webkit-tests abort immediately.
 608
 609         * Scripts/run-webkit-tests:
 610
 611 2009-11-17  Eric Seidel  <eric@webkit.org>
 612
 613         Reviewed by Darin Adler.
 614
 615         commit-queue is failing to set reviewer in ChangeLogs
 616         https://bugs.webkit.org/show_bug.cgi?id=31592
 617
 618         * Scripts/bugzilla-tool: Clarify the "applying" log message.
 619         * Scripts/modules/bugzilla.py:
 620          - Add a new _validate_committer_and_reviewer function as a
 621            temporary solution until we can make a real Attachment object
 622            which knows how to fill in its committer/reviewer fields automatically.
 623
 624 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 625
 626         Unreviewed buildbot fix.
 627
 628         Revert part of earlier patch and add comment, as it
 629         was causing timeouts on the buildbot.
 630
 631         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 632         (LayoutTestController::notifyDone):
 633
 634 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 635
 636         Reviewed by Oliver Hunt.
 637
 638         Make the timeout 15 sec as for the other DRT's and make
 639         it print out the same output when a test timeout.
 640
 641         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 642         (LayoutTestController::waitUntilDone):
 643         (LayoutTestController::notifyDone):
 644         (LayoutTestController::timerEvent):
 645
 646 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
 647
 648         Reviewed by Timothy Hatcher.
 649
 650         Fixed typos in comments.
 651
 652         * Scripts/modules/committers.py:
 653
 654 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
 655
 656         Reviewed by Timothy Hatcher.
 657
 658         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
 659         - Updated DRT to show/close inspector for all tests under /inspector
 660         - Introduced LayoutTestController::setTimelineProfilingEnabled and
 661           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
 662         - Removed reload on each inspector test
 663         - Renamed fast/inspector to fast/inspector-support in order not to trigger
 664         inspector for those.
 665         - Reimplemented timeline tests in order to get rid of reload there.
 666         - Moved tests that don't require harness into the fast group.
 667
 668         https://bugs.webkit.org/show_bug.cgi?id=31472
 669
 670         * DumpRenderTree/LayoutTestController.cpp:
 671         (setTimelineProfilingEnabledCallback):
 672         (closeWebInspectorCallback):
 673         (LayoutTestController::staticFunctions):
 674         * DumpRenderTree/LayoutTestController.h:
 675         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 676         (shouldOpenWebInspector):
 677         (runTest):
 678         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 679         (LayoutTestController::setTimelineProfilingEnabled):
 680         * DumpRenderTree/mac/DumpRenderTree.mm:
 681         (shouldOpenWebInspector):
 682         (runTest):
 683         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 684         (LayoutTestController::setTimelineProfilingEnabled):
 685         * DumpRenderTree/win/DumpRenderTree.cpp:
 686         (shouldOpenWebInspector):
 687         (runTest):
 688         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 689         (LayoutTestController::setTimelineProfilingEnabled):
 690
 691 2009-11-17  Oliver Hunt  <oliver@apple.com>
 692
 693         Reviewed by Maciej Stachowiak.
 694
 695         Incorrect use of JavaScriptCore API in DumpRenderTree
 696         https://bugs.webkit.org/show_bug.cgi?id=31577
 697
 698         Return undefined rather than a literal null.
 699
 700         * DumpRenderTree/AccessibilityUIElement.cpp:
 701         (setSelectedTextRangeCallback):
 702         (incrementCallback):
 703         (decrementCallback):
 704         (showMenuCallback):
 705
 706 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
 707
 708         Reviewed by Beth Dakin.
 709
 710         AX: aria-labelledby duplicates some of its WAI-ARIA label
 711         https://bugs.webkit.org/show_bug.cgi?id=31565
 712
 713         * DumpRenderTree/AccessibilityUIElement.cpp:
 714         (titleUIElementCallback):
 715         (getIsValidCallback):
 716         (AccessibilityUIElement::getJSClass):
 717
 718 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 719
 720         Reviewed by Simon Hausmann.
 721
 722         r50942 broke output from created windows. Make the
 723         m_enableTextOutput a member of the DRT and not the
 724         WebPage.
 725
 726         * DumpRenderTree/qt/DumpRenderTree.cpp:
 727         (WebCore::WebPage::WebPage):
 728         (WebCore::WebPage::javaScriptAlert):
 729         (WebCore::WebPage::javaScriptConsoleMessage):
 730         (WebCore::WebPage::javaScriptConfirm):
 731         (WebCore::WebPage::javaScriptPrompt):
 732         (WebCore::WebPage::acceptNavigationRequest):
 733         (WebCore::DumpRenderTree::DumpRenderTree):
 734         (WebCore::DumpRenderTree::open):
 735         (WebCore::DumpRenderTree::createWindow):
 736         * DumpRenderTree/qt/DumpRenderTree.h:
 737         (WebCore::DumpRenderTree::setTextOutputEnabled):
 738         (WebCore::DumpRenderTree::isTextOutputEnabled):
 739         (WebCore::WebPage::shouldInterruptJavaScript):
 740         (WebCore::WebPage::isTextOutputEnabled):
 741         (WebCore::WebPage::setViewGeometry):
 742
 743 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 744
 745         Reviewed by Gustavo Noronha Silva.
 746
 747         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
 748         as the implementation is being used by at least Qt and Gtk+.
 749
 750         Update buildsystems as well.
 751
 752         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 753         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
 754         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
 755         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
 756         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
 757         * GNUmakefile.am:
 758
 759 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
 760
 761         Reviewed by Alexey Proskuryakov.
 762
 763         Disable wss until all platforms support pyOpenSSL
 764
 765         https://bugs.webkit.org/show_bug.cgi?id=31479
 766
 767         * Scripts/run-webkit-tests:
 768
 769 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
 770
 771         Reviewed by Kenneth Christiansen.
 772
 773         [Qt] Implement load error pages support for Qt's DRT.
 774         https://bugs.webkit.org/show_bug.cgi?id=31509
 775
 776         For now, it will not be a default feature, and layout tests
 777         that want to make use of this have to explicitily call
 778         'handleErrorPages();' for the test source.
 779
 780         Any of the other DumpRenderTree's (mac, win and gtk)
 781         support handling error pages. Qt's will be the first.
 782
 783         * DumpRenderTree/qt/DumpRenderTree.cpp:
 784         (WebCore::WebPage::supportsExtension):
 785         (WebCore::WebPage::extension):
 786         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 787         (LayoutTestController::reset):
 788         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 789         (LayoutTestController::shouldHandleErrorPages):
 790         (LayoutTestController::handleErrorPages):
 791
 792 2009-11-16  Eric Seidel  <eric@webkit.org>
 793
 794         Reviewed by Adam Barth.
 795
 796         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
 797         https://bugs.webkit.org/show_bug.cgi?id=31549
 798
 799         Renamed --commit-queue to --non-interactive in most places
 800         and remove the code in land-patches which is no longer needed.
 801
 802         * Scripts/bugzilla-tool:
 803
 804 2009-11-16  Eric Seidel  <eric@webkit.org>
 805
 806         Reviewed by Adam Barth.
 807
 808         The commit-queue should use land-attachment
 809         https://bugs.webkit.org/show_bug.cgi?id=31548
 810
 811         * Scripts/bugzilla-tool:
 812
 813 2009-11-16  Adam Barth  <abarth@webkit.org>
 814
 815         Reviewed by Eric Seidel.
 816
 817         Convert CommitQueue over to PatchCollection
 818         https://bugs.webkit.org/show_bug.cgi?id=31547
 819
 820         Also fixes a bug in workqueue and adds a test!
 821
 822         * Scripts/bugzilla-tool:
 823         * Scripts/modules/workqueue.py:
 824         * Scripts/modules/workqueue_unittest.py:
 825
 826 2009-11-16  Adam Barth  <abarth@webkit.org>
 827
 828         Reviewed by Eric Seidel.
 829
 830         Move StyleQueue over to using PatchCollection
 831         https://bugs.webkit.org/show_bug.cgi?id=31544
 832
 833         That's what the class it's for.
 834
 835         * Scripts/bugzilla-tool:
 836         * Scripts/modules/patchcollection.py:
 837         * Scripts/modules/patchcollection_unittest.py:
 838
 839 2009-11-16  Eric Seidel  <eric@webkit.org>
 840
 841         Reviewed by Adam Barth.
 842
 843         bugzilla-tool needs a land-attachment command
 844         https://bugs.webkit.org/show_bug.cgi?id=31546
 845
 846         * Scripts/bugzilla-tool:
 847          - Move all the logic into AbstractLandingCommand and
 848            add a new LandAttachment command subclass.
 849          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
 850
 851 2009-11-16  Eric Seidel  <eric@webkit.org>
 852
 853         Reviewed by Adam Barth.
 854
 855         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
 856         https://bugs.webkit.org/show_bug.cgi?id=31543
 857
 858         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
 859
 860         * Scripts/bugzilla-tool:
 861
 862 2009-11-16  Eric Seidel  <eric@webkit.org>
 863
 864         Reviewed by Adam Barth.
 865
 866         Disable the style queue from posting to the commit queue status page.
 867
 868         * Scripts/bugzilla-tool:
 869
 870 2009-11-16  Adam Barth  <abarth@webkit.org>
 871
 872         Reviewed by Eric Seidel.
 873
 874         Implement PatchCollection
 875         https://bugs.webkit.org/show_bug.cgi?id=31541
 876
 877         This class holds a set of patches and lets clients iterate through
 878         them.  Optionally, clients can install a filter.
 879
 880         * Scripts/modules/patchcollection.py: Added.
 881         * Scripts/modules/patchcollection_unittest.py: Added.
 882         * Scripts/run-webkit-unittests:
 883
 884 2009-11-16  Eric Seidel  <eric@webkit.org>
 885
 886         Reviewed by Adam Barth.
 887
 888         bugzilla-tool land-patches will close bugs with patches r=?
 889         https://bugs.webkit.org/show_bug.cgi?id=28230
 890
 891         The commit-queue shouldn't close patches with outstanding reviews on them,
 892         even if many reviewers seem to be against multi-patch bugs.
 893
 894         * Scripts/bugzilla-tool:
 895
 896 2009-11-16  Eric Seidel  <eric@webkit.org>
 897
 898         Reviewed by Adam Barth.
 899
 900         bugzilla-tool check-style should work with attachment ids instead of bug ids
 901         https://bugs.webkit.org/show_bug.cgi?id=31540
 902
 903         * Scripts/bugzilla-tool:
 904
 905 2009-11-16  Eric Seidel  <eric@webkit.org>
 906
 907         Reviewed by Adam Barth.
 908
 909         WorkQueue is the only place that should know about special exit codes
 910         https://bugs.webkit.org/show_bug.cgi?id=31534
 911
 912         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
 913         and add tests for handling exit codes.
 914         I also cleaned up workqueue_unittest.py more.
 915
 916         * Scripts/bugzilla-tool:
 917         * Scripts/modules/workqueue.py:
 918         * Scripts/modules/workqueue_unittest.py:
 919
 920 2009-11-16  Eric Seidel  <eric@webkit.org>
 921
 922         Reviewed by Adam Barth.
 923
 924         Re-factor workqueue_unittest to allow for more than one test.
 925         https://bugs.webkit.org/show_bug.cgi?id=31535
 926
 927         * Scripts/modules/workqueue_unittest.py:
 928
 929 2009-11-16  Eric Seidel  <eric@webkit.org>
 930
 931         Reviewed by Adam Barth.
 932
 933         land-patches needs to be re-factored into smaller chunks
 934         https://bugs.webkit.org/show_bug.cgi?id=31532
 935
 936         * Scripts/bugzilla-tool: fix a couple obvious typos.
 937
 938 2009-11-16  Eric Seidel  <eric@webkit.org>
 939
 940         Reviewed by Adam Barth.
 941
 942         land-patches needs to be re-factored into smaller chunks
 943         https://bugs.webkit.org/show_bug.cgi?id=31532
 944
 945         The next patch will move these methods into WebKitLandingScripts.
 946
 947         * Scripts/bugzilla-tool:
 948          - Split out _land_patch and _close_bug_if_no_active_patches.
 949
 950 2009-11-16  Adam Barth  <abarth@webkit.org>
 951
 952         Reviewed by Eric Seidel.
 953
 954         Fix silly copy-and-paste code.  I am a terrible coder.
 955
 956         * Scripts/modules/bugzilla.py:
 957
 958 2009-11-16  Adam Barth  <abarth@webkit.org>
 959
 960         Reviewed by Eric Seidel.
 961
 962         Implement a StyleQueue
 963         https://bugs.webkit.org/show_bug.cgi?id=31537
 964
 965         The first iteration of the style queue only produces output locally.
 966         There is also a limit of 10 patches because it's not that useful to
 967         iterate through the entire review queue at this point.  We can remove
 968         the limit later.
 969
 970         * Scripts/bugzilla-tool:
 971         * Scripts/modules/bugzilla.py:
 972
 973 2009-11-16  Adam Barth  <abarth@webkit.org>
 974
 975         Reviewed by Eric Seidel.
 976
 977         Unit test WorkQueue
 978         https://bugs.webkit.org/show_bug.cgi?id=31531
 979
 980         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
 981
 982         * Scripts/bugzilla-tool:
 983         * Scripts/modules/statusbot.py:
 984         * Scripts/modules/workqueue.py:
 985         * Scripts/modules/workqueue_unittest.py: Added.
 986         * Scripts/run-webkit-unittests:
 987
 988 2009-11-16  Eric Seidel  <eric@webkit.org>
 989
 990         Reviewed by Adam Barth.
 991
 992         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
 993         https://bugs.webkit.org/show_bug.cgi?id=31530
 994
 995         * Scripts/bugzilla-tool:
 996
 997 2009-11-16  Eric Seidel  <eric@webkit.org>
 998
 999         Reviewed by Adam Barth.
1000
1001         bugzilla-tool needs apply-attachment
1002         https://bugs.webkit.org/show_bug.cgi?id=31528
1003
1004         * Scripts/bugzilla-tool:
1005          - Add ApplyAttachment command.
1006          - Abstract applying code into WebKitApplyingScripts.
1007          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1008         * Scripts/modules/bugzilla.py:
1009          - Add fetch_attachment and bug_id_for_attachment_id.
1010         * Scripts/modules/bugzilla_unittest.py:
1011          - Add test for new parsing.
1012          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1013
1014 2009-11-16  Eric Seidel  <eric@webkit.org>
1015
1016         Reviewed by Adam Barth.
1017
1018         Document check-style's use of force_clean.
1019
1020         * Scripts/bugzilla-tool:
1021         * Scripts/modules/scm.py:
1022
1023 2009-11-16  Adam Barth  <abarth@webkit.org>
1024
1025         Reviewed by Eric Seidel.
1026
1027         Move WorkQueue to its own file
1028         https://bugs.webkit.org/show_bug.cgi?id=31529
1029
1030         WorkQueue and WorkQueueDelegate are separate concerns from
1031         bugzilla-tool.  Also added a missing include to logging.py.
1032
1033         * Scripts/bugzilla-tool:
1034         * Scripts/modules/logging.py:
1035         * Scripts/modules/workqueue.py:
1036
1037 2009-11-16  Adam Barth  <abarth@webkit.org>
1038
1039         Reviewed by Eric Seidel.
1040
1041         Move OutputTee to logging.py.
1042
1043         * Scripts/bugzilla-tool:
1044         * Scripts/modules/logging.py:
1045
1046 2009-11-15  Adam Barth  <abarth@webkit.org>
1047
1048         Reviewed by Eric Seidel.
1049
1050         Refactor bugzilla-tool to allow for multiple queues
1051         https://bugs.webkit.org/show_bug.cgi?id=31513
1052
1053         Divide the commit queue class into three class to make creating
1054         additional queues easier.
1055
1056         * Scripts/bugzilla-tool:
1057
1058 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1059
1060         Reviewed by Eric Seidel.
1061
1062         svn-apply may not handle git patches created by bugzilla-tool
1063         https://bugs.webkit.org/show_bug.cgi?id=31457
1064
1065         * Scripts/modules/scm.py:
1066         * Scripts/modules/scm_unittest.py:
1067
1068 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1069
1070         Reviewed by Eric Seidel.
1071
1072         bugzilla-tool should post git binary diff
1073         https://bugs.webkit.org/show_bug.cgi?id=31458
1074
1075         Add --binary option to Git.create_patch.
1076
1077         * Scripts/modules/scm.py:
1078         * Scripts/modules/scm_unittest.py:
1079
1080 2009-11-15  Adam Barth  <abarth@webkit.org>
1081
1082         Reviewed by Darin Adler.
1083
1084         Add bugzilla-tool check-style
1085         https://bugs.webkit.org/show_bug.cgi?id=31515
1086
1087         * Scripts/bugzilla-tool:
1088         * Scripts/modules/bugzilla.py:
1089
1090 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1091
1092         Reviewed by Simon Hausmann.
1093
1094         Make the Qt Linux only --valgrind feature, suppress errors
1095         defined in the SuppressedValgrindErrors file.
1096
1097         * Scripts/run-webkit-tests:
1098
1099 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1100
1101         Reviewed by Simon Hausmann.
1102
1103         Set the locale to C and not to the current one in use on the system.
1104
1105         * DumpRenderTree/qt/DumpRenderTree.cpp:
1106         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1107
1108 2009-11-13  Adam Roben  <aroben@apple.com>
1109
1110         Add support for
1111         http/tests/security/isolatedWorld/didClearWindowObject.html
1112
1113         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1114         window objects in isolated worlds are cleared
1115
1116         Reviewed by Dave Hyatt.
1117
1118         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1119
1120         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1121         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1122         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1123         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1124         Added. Sets a __worldID property on the global object whose value is
1125         the ID of this world.
1126         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1127         Respond to this new delegate callback by calling through to one of the
1128         above new methods.
1129         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1130         (worldMap): Added. Returns a HashMap containing all the worlds we've
1131         created.
1132         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1133         haven't kept track of this world.
1134         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1135         instead of declaring our own.
1136
1137         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1138
1139         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1140         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1141         didClearWindowObjectForFrameInStandardWorld.
1142         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1143         Respond to this new delegate callback by calling through to one of the
1144         below new methods.
1145         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1146         Added. Sets a __worldID property on the gobal object whose value is
1147         the ID of this world.
1148         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1149         Added. Moved code here from didClearWindowObject.
1150
1151         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1152         didClearWindowObjectForFrame* functions.
1153
1154         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1155         (worldMap): Added. Returns a HashMap containing all the worlds we've
1156         created.
1157         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1158         haven't kept track of this world.
1159         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1160         instead of declaring our own.
1161
1162 2009-11-13  Adam Roben  <aroben@apple.com>
1163
1164         Finish replacing worldIDs with world objects
1165
1166         The only remaining use of worldIDs was in a method only used by DRT
1167         for the isolated worlds tests.
1168
1169         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1170
1171         Reviewed by Mark Rowe.
1172
1173         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1174         (LayoutTestController::evaluateScriptInIsolatedWorld):
1175         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1176         (LayoutTestController::evaluateScriptInIsolatedWorld):
1177         Updated for changes to WebFrame. Now holds the map of worldID -> world
1178         at this level instead of making WebKit do it.
1179
1180 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1181
1182         Reviewed by Simon Hausmann.
1183
1184         [Qt] Ensure the DRT does not output anything until first test is run
1185
1186         * DumpRenderTree/qt/DumpRenderTree.cpp:
1187         * DumpRenderTree/qt/DumpRenderTree.h:
1188
1189 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1190
1191         Reviewed by Tor Arne Vestbø.
1192
1193         Clear the undo stack in before each new test run.
1194
1195         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1196
1197         * DumpRenderTree/qt/DumpRenderTree.cpp:
1198         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1199
1200 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1201
1202         Reviewed by Kenneth Rohde Christiansen.
1203
1204         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1205
1206         * DumpRenderTree/qt/DumpRenderTree.cpp:
1207         (WebCore::WebPage::resetSettings):
1208         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1209         (LayoutTestController::overridePreference):
1210
1211 2009-11-13  Eric Seidel  <eric@webkit.org>
1212
1213         Reviewed by Adam Barth.
1214
1215         Update committers.py based on svn records
1216         https://bugs.webkit.org/show_bug.cgi?id=31366
1217
1218         This list was generated using validate-committer-lists from
1219         https://bugs.webkit.org/show_bug.cgi?id=30970
1220         and makes committers.py current for committers who have
1221         committed in the last 3 years.
1222
1223         * Scripts/modules/committers.py:
1224
1225 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1226
1227         Reviewed by Adam Barth.
1228
1229         The document-open.html test was flaky at times. The test invokes the layout test plugin
1230         which in its destroy stream handler opens a new document. This basically tears down the
1231         stream and the associated plugin instance. The pluginLog function in the layout test
1232         plugin attempts to retrieve the window script object on a torn down plugin instance
1233         which crashed consistently on windows in the debugger. The functions which issue
1234         these logs already have a valid window script object. We now have variants of the pluginLog
1235         function which take in a window script object with and without variable arguments.
1236
1237         https://bugs.webkit.org/show_bug.cgi?id=31067
1238
1239         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1240         (pluginLogWithWindowObject):
1241         (pluginLogWithWindowObjectVariableArgs):
1242         (pluginLog):
1243         (notifyTestCompletion):
1244         (testDocumentOpen):
1245         (testWindowOpen):
1246
1247 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1248
1249         Reviewed by Gustavo Noronha Silva.
1250
1251         https://bugs.webkit.org/show_bug.cgi?id=30997
1252         [Gtk] Implemment AtkDocument
1253
1254         Added testing support.
1255
1256         * DumpRenderTree/AccessibilityUIElement.cpp:
1257         * DumpRenderTree/AccessibilityUIElement.h:
1258         (getDocumentEncodingCallback):
1259         (getDocumentURICallback):
1260         (AccessibilityUIElement::getJSClass):
1261         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1262         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1263         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1264         (AccessibilityUIElement::documentEncoding):
1265         (AccessibilityUIElement::documentURI):
1266
1267 2009-11-12  Adam Roben  <aroben@apple.com>
1268
1269         Replace worldIDs with world objects
1270
1271         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1272         user scripts/stylesheets and isolated worlds
1273
1274         Reviewed by Sam Weinig.
1275
1276         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1277         (LayoutTestController::addUserScript):
1278         (LayoutTestController::addUserStyleSheet):
1279         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1280         (LayoutTestController::addUserScript):
1281         (LayoutTestController::addUserStyleSheet):
1282         Changed these functions to create a new WebJSWorld each time they're
1283         called and to pass that world to WebKit.
1284
1285 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1286
1287         Reviewed by Oliver Hunt.
1288
1289         need to implement aria tree roles
1290         https://bugs.webkit.org/show_bug.cgi?id=31284
1291
1292         * DumpRenderTree/AccessibilityUIElement.cpp:
1293         (disclosedRowAtIndexCallback):
1294         (selectedRowAtIndexCallback):
1295         (isEqualCallback):
1296         (isAttributeSettableCallback):
1297         (isActionSupportedCallback):
1298         (disclosedByRowCallback):
1299         (hierarchicalLevelCallback):
1300         (AccessibilityUIElement::getJSClass):
1301         * DumpRenderTree/AccessibilityUIElement.h:
1302         (AccessibilityUIElement::isEqual):
1303         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1304         (AccessibilityUIElement::hierarchicalLevel):
1305         (AccessibilityUIElement::disclosedRowAtIndex):
1306         (AccessibilityUIElement::selectedRowAtIndex):
1307         (AccessibilityUIElement::disclosedByRow):
1308         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1309         (AccessibilityUIElement::getChildAtIndex):
1310         (AccessibilityUIElement::disclosedRowAtIndex):
1311         (AccessibilityUIElement::selectedRowAtIndex):
1312         (AccessibilityUIElement::titleUIElement):
1313         (AccessibilityUIElement::parentElement):
1314         (AccessibilityUIElement::disclosedByRow):
1315         (AccessibilityUIElement::hierarchicalLevel):
1316         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1317         (AccessibilityUIElement::hierarchicalLevel):
1318         (AccessibilityUIElement::disclosedRowAtIndex):
1319         (AccessibilityUIElement::selectedRowAtIndex):
1320         (AccessibilityUIElement::disclosedByRow):
1321
1322 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1323
1324         Reviewed by Darin Adler.
1325
1326         svn-apply can not handle git binary diffs
1327         https://bugs.webkit.org/show_bug.cgi?id=26830
1328
1329         Support "literal" type git binary diffs.
1330
1331         * Scripts/VCSUtils.pm:
1332         * Scripts/modules/scm_unittest.py:
1333         * Scripts/svn-apply:
1334
1335 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1336
1337         Not reviewed, removing duplicate entry for myself in committers.py.
1338
1339         * Scripts/modules/committers.py:
1340
1341 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1342
1343         Reviewed by Darin Adler and Mark Rowe.
1344
1345         https://bugs.webkit.org/show_bug.cgi?id=31200
1346         Tests in http/tests/security/mixedContent start to fail when new tests are added
1347
1348         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1349
1350 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1351
1352         Reviewed by Jan Alonzo.
1353
1354         Create, and display a window for the inspector, for inspector
1355         tests.
1356
1357         Need to also show/hide the inspector window to avoid having
1358         problems with code assuming it is realized
1359         https://bugs.webkit.org/show_bug.cgi?id=31347
1360
1361         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1362         (webInspectorShowWindow):
1363         (webInspectorCloseWindow):
1364         (webInspectorInspectWebView):
1365         (createWebView):
1366
1367 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1368
1369         Unreviewed Qt buildbot fix.
1370
1371         My previous fix was wrong, so revert that change and fix it by
1372         returning when the document of the frame has no document element.
1373         Idea is borrowed from mac and win DRT.
1374
1375         * DumpRenderTree/qt/DumpRenderTree.cpp:
1376         (WebCore::DumpRenderTree::dumpFramesAsText):
1377
1378 2009-11-11  Eric Seidel  <eric@webkit.org>
1379
1380         Reviewed byg Kenneth Rohde Christiansen.
1381
1382         Update Kenneth's committer record to include the email he
1383         uses on lists.webkit.org.
1384
1385         * Scripts/modules/committers.py:
1386
1387 2009-11-11  Eric Seidel  <eric@webkit.org>
1388
1389         Reviewed by Gustavo Noronha Silva.
1390
1391         Several committers use separate email addresses for bugzilla and svn.webkit.org
1392         https://bugs.webkit.org/show_bug.cgi?id=31364
1393
1394         Update records for existing committers to include email addresses
1395         used in svn.webkit.org and lists.webkit.org.
1396         Most committers use the same email address in all 3 places, but some use
1397         separate addresses.  committers.py needs record of each of these addresses.
1398
1399         * Scripts/modules/committers.py:
1400
1401 2009-11-11  Eric Seidel  <eric@webkit.org>
1402
1403         No review, adding second email address for an existing committer.
1404
1405         Add Yong Li's second bugzilla account to his committer record.
1406         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1407
1408         * Scripts/modules/committers.py:
1409
1410 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1411
1412         Reviewed by Simon Hausmann.
1413
1414         If the frame has no innerText don't append it, and
1415         do not add a newline which breaks some cross platform
1416         results.
1417
1418         * DumpRenderTree/qt/DumpRenderTree.cpp:
1419         (WebCore::DumpRenderTree::dumpFramesAsText):
1420
1421 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1422
1423         Reviewed by Simon Hausmann.
1424
1425         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1426
1427         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1428         (webkit_test_plugin_new_instance):
1429         (webkit_test_plugin_destroy_instance):
1430         (webkit_test_plugin_destroy_stream):
1431
1432 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1433
1434         Reviewed by Mark Rowe.
1435
1436         Implement the functionality needed by plugins/window-open.html
1437
1438         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1439         (webkit_test_plugin_new_instance):
1440         (webkit_test_plugin_set_window):
1441
1442 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1443
1444         Reviewed by Simon Hausmann.
1445
1446         [Qt] Force -graphicssystem raster and -style windows when running DRT
1447
1448         * DumpRenderTree/qt/main.cpp:
1449         * Scripts/run-webkit-tests:
1450
1451 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1452
1453         Reviewed by Simon Hausmann.
1454
1455         Compute correct library paths for Qt
1456
1457         * Scripts/webkitdirs.pm:
1458
1459 2009-11-10  Mark Rowe  <mrowe@apple.com>
1460
1461         Reviewed by Sam Weinig.
1462
1463         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1464
1465         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1466         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1467         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1468         that had enabled frame load delegate logging this would result in extra log messages being generated,
1469         causing the test to fail.
1470
1471         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1472         tests.
1473
1474         * DumpRenderTree/mac/DumpRenderTree.mm:
1475         (dumpRenderTree):
1476         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1477         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1478
1479 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1480
1481         Reviewed by Kenneth Rohde Christiansen.
1482
1483         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1484
1485         * DumpRenderTree/qt/DumpRenderTree.cpp:
1486         (WebCore::DumpRenderTree::DumpRenderTree):
1487
1488 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1489
1490         Reviewed by Jan Alonzo.
1491
1492         [GTK] Remove WebSocket configuration from WebKitWebSettings
1493         https://bugs.webkit.org/show_bug.cgi?id=31244
1494
1495         Follow-up of r50724. Don't set the enable-web-socket property
1496         anymore.
1497
1498         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1499         (resetDefaultsToConsistentValues):
1500
1501 2009-11-10  Oliver Hunt  <oliver@apple.com>
1502
1503         Reviewed by Maciej Stachowiak.
1504
1505         Rename 3D Canvas related classes to use WebGL prefix
1506         https://bugs.webkit.org/show_bug.cgi?id=29095
1507
1508         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1509         and upate webkitdirs script to new method of testing for WebGL.
1510
1511         * Scripts/do-webcore-rename:
1512         * Scripts/webkitdirs.pm:
1513
1514 2009-11-09  Oliver Hunt  <oliver@apple.com>
1515
1516         Reviewed by Geoff Garen.
1517
1518         Make do-webcore-rename work with git.
1519
1520         * Scripts/do-webcore-rename:
1521
1522 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1523
1524         Adding Kenneth to the reviewers list.
1525
1526         * Scripts/modules/committers.py:
1527
1528 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1529
1530         Reviewed by Jan Alonzo.
1531
1532         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1533         https://bugs.webkit.org/show_bug.cgi?id=30482
1534
1535         LayoutTestControllerGtk now uses the exposed
1536         Page::tabKeyCyclesThroughElements API
1537
1538         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1539         (LayoutTestController::setTabKeyCyclesThroughElements):
1540
1541 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1542
1543         Reviewed by Holger Freyther.
1544
1545         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1546         This helps to pass the test case below. Also replaced hardcoded
1547         code numbers with defined constants.
1548         https://bugs.webkit.org/show_bug.cgi?id=31185
1549
1550         Test: editing/undo/undo-deleteWord.html
1551
1552         * DumpRenderTree/qt/EventSenderQt.cpp:
1553         (EventSender::keyDown):
1554
1555 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1556
1557         Reviewed by Holger Freyther.
1558
1559         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1560         https://bugs.webkit.org/show_bug.cgi?id=31164
1561
1562         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1563
1564         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1565         (LayoutTestController::processWork):
1566
1567 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1568
1569         Reviewed by Holger Freyther.
1570
1571         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1572         https://bugs.webkit.org/show_bug.cgi?id=31158
1573
1574         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1575         always, which from WorkQueue prospective means that a load has been started
1576         and the queue processing should stop and wait for the load to finish.
1577         Spinning it off into a loading and a non-loading variants was the solution
1578         adopted by Mac's DRT to work around this problem. The former keeps returning
1579         'true' while the later executes the script synchronously and returns 'false'
1580         making it possible to the WorkQueue to proceed right away.
1581
1582         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1583         (LayoutTestController::processWork):
1584         (LayoutTestController::queueLoadingScript):
1585         (LayoutTestController::queueNonLoadingScript):
1586         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1587         * DumpRenderTree/qt/WorkQueueItem.h:
1588         (LoadingScriptItem::LoadingScriptItem):
1589         (LoadingScriptItem::invoke):
1590         (NonLoadingScriptItem::NonLoadingScriptItem):
1591         (NonLoadingScriptItem::invoke):
1592
1593 2009-11-07  Mark Rowe  <mrowe@apple.com>
1594
1595         Rubber-stamped by Cameron Zwarich.
1596
1597         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1598
1599         * Scripts/commit-log-editor:
1600
1601 2009-11-07  Mark Rowe  <mrowe@apple.com>
1602
1603         Reviewed by Darin Adler.
1604
1605         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1606         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1607
1608         Move logic for determining the name and email address to use in a ChangeLog entry from
1609         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1610         whether the author of the patch matches committer, and therefore needs access to the
1611         email address that would be used in a ChangeLog entry.
1612
1613         Based on a patch by Pierre d'Herbemont.
1614
1615         * Scripts/VCSUtils.pm:
1616         * Scripts/commit-log-editor:
1617         * Scripts/prepare-ChangeLog:
1618         * Scripts/webkitdirs.pm:
1619
1620 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1621
1622         Reviewed by Adam Barth.
1623
1624         Added functionality to the layout test plugin to invoke document.open and
1625         window.open with default arguments. The associated webkit bug is
1626         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1627         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1628         work in Chromium (V8) if there is no calling javascript context. To achieve this
1629         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1630         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1631
1632         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1633         (testDocumentOpen):
1634         (testWindowOpen):
1635         (pluginAllocate):
1636         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1637         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1638         (NPP_New):
1639         (NPP_SetWindow):
1640         (NPP_DestroyStream):
1641         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1642         (NPP_New):
1643         (NPP_SetWindow):
1644         (NPP_NewStream):
1645         (NPP_DestroyStream):
1646
1647 2009-11-06  Eric Seidel  <eric@webkit.org>
1648
1649         Reviewed by Adam Barth.
1650
1651         bugzilla-tool crashed with exception
1652         https://bugs.webkit.org/show_bug.cgi?id=31092
1653
1654         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1655
1656 2009-11-04  Eric Seidel  <eric@webkit.org>
1657
1658         No review, just add a line which got left out of the patch uploaded for commit.
1659
1660         commit-queue is crashing when trying to reject patches after unknown failures
1661         https://bugs.webkit.org/show_bug.cgi?id=31091
1662
1663         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1664
1665 2009-11-04  Adam Roben  <aroben@apple.com>
1666
1667         Remove bogus else clause in bugzilla-tool
1668
1669         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1670         create-bug raises exception after entering bug description
1671
1672         Reviewed by David Kilzer.
1673
1674         * Scripts/bugzilla-tool:
1675         (CreateBug): else clauses are only hit if no exception is raised, so
1676         it makes no sense to try to re-raise the exception in an else clause.
1677         The exception will automatically be re-raised if it doesn't match any
1678         of the except clauses, so we don't have to do anything special here at
1679         all to get the desired behavior.
1680
1681 2009-11-04  Eric Seidel  <eric@webkit.org>
1682
1683         Reviewed by David Kilzer.
1684
1685         svn-apply's fixChangeLogPatch function seems broken
1686         https://bugs.webkit.org/show_bug.cgi?id=30683
1687
1688         Update fixChangeLogPatch to be able to handle patches which
1689         don't start at line 1.
1690         Add unit tests for svn-apply to scm_unittest.py.
1691
1692         * Scripts/VCSUtils.pm:
1693         * Scripts/modules/scm_unittest.py:
1694
1695 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1696
1697         Reviewed by Beth Dakin.
1698
1699         Need to implement ARIA role="combobox"
1700         https://bugs.webkit.org/show_bug.cgi?id=31096
1701
1702         * DumpRenderTree/AccessibilityUIElement.cpp:
1703         (showMenuCallback):
1704         (getIsExpandedCallback):
1705         (AccessibilityUIElement::getJSClass):
1706         * DumpRenderTree/AccessibilityUIElement.h:
1707         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1708         (AccessibilityUIElement::isExpanded):
1709         (AccessibilityUIElement::showMenu):
1710         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1711         (AccessibilityUIElement::isExpanded):
1712         (AccessibilityUIElement::showMenu):
1713         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1714         (AccessibilityUIElement::isSelected):
1715         (AccessibilityUIElement::isExpanded):
1716         (AccessibilityUIElement::showMenu):
1717
1718 2009-11-04  Eric Seidel  <eric@webkit.org>
1719
1720         Reviewed by Adam Barth.
1721
1722         commit-queue is crashing when trying to reject patches after unknown failures
1723         https://bugs.webkit.org/show_bug.cgi?id=31091
1724
1725         * Scripts/bugzilla-tool:
1726          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1727            so we have to find out what the current patch is by asking bugzilla again.
1728          - Discovered that this code was also leaking file descriptors, so fixed that.
1729
1730 2009-11-04  Adam Roben  <aroben@apple.com>
1731
1732         Make run-webkit-tests work for the Debug_Internal Windows
1733         configuration
1734
1735         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1736         suffix.
1737
1738         Fixes <http://webkit.org/b/31123>.
1739
1740         Reviewed by Sam Weinig.
1741
1742         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1743         Debug_Internal, either.
1744
1745 2009-11-04  Eric Seidel  <eric@webkit.org>
1746
1747         Reviewed by Adam Barth.
1748
1749         committers.py needs a way to store non-bugzilla email addresses
1750         https://bugs.webkit.org/show_bug.cgi?id=31037
1751
1752         Make Committer and Reviewer constructors take a single email or a list of emails.
1753         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1754         Expose reviewers(), used by validate-committer-lists on bug 30970.
1755
1756         * Scripts/modules/committers.py:
1757         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1758
1759 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1760
1761         Reviewed by David Levin.
1762
1763         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1764         https://bugs.webkit.org/show_bug.cgi?id=27491
1765
1766         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1767         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1768
1769         Functions to start or stop Web Socket servers are added.
1770
1771         * Scripts/run-webkit-tests:
1772
1773 2009-11-03  Eric Seidel  <eric@webkit.org>
1774
1775         No review, just changing wording of log message.
1776
1777         Change log string to say "failed" instead of "rejected"
1778         when a commit fails due to an out of date checkout.
1779         This makes grepping the commit-queue log for rejected patches easier.
1780
1781         * Scripts/bugzilla-tool:
1782
1783 2009-11-03  Eric Seidel  <eric@webkit.org>
1784
1785         No review, adding commonly known committers missing from the file.
1786
1787         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1788
1789 2009-11-03  Eric Seidel  <eric@webkit.org>
1790
1791         No review, just sort-order cleanup.
1792
1793         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1794
1795 2009-11-03  Stephen White  <senorblanco@chromium.org>
1796
1797         (Unreviewed).
1798
1799         Add myself to committers.py.
1800
1801         * Scripts/modules/committers.py:
1802
1803 2009-11-03  Robin Dunn  <robin@alldunn.com>
1804
1805         Reviewed by Kevin Ollviier.
1806
1807         Add packaging scripts for Debian-based Linux distros.
1808
1809         https://bugs.webkit.org/show_bug.cgi?id=31075
1810
1811         * wx/packaging/build-debian-installer.py: Added.
1812         * wx/packaging/debian: Added.
1813
1814 2009-11-03  Dan Bernstein  <mitz@apple.com>
1815
1816         Reviewed by Anders Carlsson and Beth Dakin.
1817
1818         https://bugs.webkit.org/show_bug.cgi?id=31070
1819
1820         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1821         destroyed, it executes the value of the 'ondestroy' parameter as a
1822         script.
1823
1824         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1825         (pluginAllocate): Initialize onDestroy.
1826         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1827         onDestroy.
1828         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1829         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
1830         specified.
1831         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
1832
1833 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1834
1835         Reviewed by Xan Lopez.
1836
1837         https://bugs.webkit.org/show_bug.cgi?id=31035
1838         [GTK] some accessibility tests hitting assertion in debug builds
1839
1840         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
1841
1842         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1843         (AccessibilityController::rootElement):
1844
1845 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
1846
1847         Reviewed by Beth Dakin.
1848
1849         Support ARIA "tab" roles
1850         https://bugs.webkit.org/show_bug.cgi?id=30842
1851
1852         * DumpRenderTree/AccessibilityUIElement.cpp:
1853         * DumpRenderTree/AccessibilityUIElement.h:
1854         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1855         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1856         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1857
1858 2009-11-01  Eric Seidel  <eric@webkit.org>
1859
1860         Reviewed by David Levin.
1861
1862         buildbots should use --exit-after-N-failures
1863         https://bugs.webkit.org/show_bug.cgi?id=30809
1864
1865         Make the bots exit after 20 failures to prevent never-ending
1866         test runs where every test spends a minute crashing.
1867
1868         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1869
1870 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1871
1872         Reviewed by Eric Seidel.
1873
1874         Turn on warnings for QtWebKit for gcc
1875         https://bugs.webkit.org/show_bug.cgi?id=30958
1876
1877         * DumpRenderTree/qt/main.cpp:
1878         (crashHandler): Mark function NO_RETURN
1879
1880 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
1881
1882         Adding myself to the committers list.
1883
1884         * Scripts/modules/committers.py:
1885
1886 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
1887
1888         Fix an issue that Adam noticed in DRT.
1889
1890         Reviewed by Darin Adler.
1891
1892         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1893         (AccessibilityUIElement::role):
1894         Get the length of the role text, and create a buffer dynamically.
1895
1896 2009-10-30  Eric Seidel  <eric@webkit.org>
1897
1898         No review, rolling out r50105.
1899         http://trac.webkit.org/changeset/50105
1900
1901         This commit was causing:
1902         https://bugs.webkit.org/show_bug.cgi?id=30869
1903         We'll re-implement the feature a different way.
1904
1905         * Scripts/bugzilla-tool:
1906
1907 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1908
1909         Test for MSAA: Accessibility of headings is not correct
1910
1911         https://bugs.webkit.org/show_bug.cgi?id=30937
1912
1913         Reviewed by Adam Roben.
1914
1915         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1916         (AccessibilityUIElement::role):
1917         Allow the role returned to be a BSTR.
1918         (AccessibilityUIElement::description):
1919         Fix a copy/paste error.
1920
1921 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1922
1923         Test for MSAA: Accessibility of links is wrong
1924
1925         https://bugs.webkit.org/show_bug.cgi?id=30928
1926
1927         Reviewed by Darin Adler.
1928
1929         * DumpRenderTree/AccessibilityUIElement.cpp:
1930         (getAccessibilityValueCallback):
1931         Return the accessibility value.
1932         (AccessibilityUIElement::getJSClass):
1933         Added "accessibilityValue" value.
1934
1935         * DumpRenderTree/AccessibilityUIElement.h:
1936
1937         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1938         (AccessibilityUIElement::accessibilityValue):
1939         Stubbed.
1940
1941         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1942         (AccessibilityUIElement::accessibilityValue):
1943         Stubbed.
1944
1945         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1946         (AccessibilityUIElement::accessibilityValue):
1947         Get the object's value, and return it as a JS string.
1948
1949 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
1950
1951         Fix typo in command name used by wx build system.
1952
1953         * wx/build/build_utils.py:
1954
1955 2009-10-30  Adam Barth  <abarth@webkit.org>
1956
1957         Reviewed by Darin Adler.
1958
1959         Patch v1 is a dumb default name for patches
1960         https://bugs.webkit.org/show_bug.cgi?id=30952
1961
1962         Let's use "Patch" instead.
1963
1964         * Scripts/bugzilla-tool:
1965
1966 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1967
1968         Unreviewed trivial buildfix.
1969
1970         [Qt] Buildfix for r50333.
1971
1972         * DumpRenderTree/qt/DumpRenderTree.pro:
1973
1974 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
1975
1976         Reviewed by Holger Freyther.
1977
1978         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
1979         https://bugs.webkit.org/show_bug.cgi?id=30953
1980
1981         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
1982         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
1983         makes qt DRT to share this implementation (as gtk and mac ports do).
1984
1985         * DumpRenderTree/qt/DumpRenderTree.pro:
1986         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
1987         * DumpRenderTree/qt/WorkQueue.h: Removed.
1988
1989 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1990
1991         Unreviewed potential buildbot fix.
1992
1993         Second try: Reset page history before running each test.
1994
1995         Apparently the QWebHistory::clear() keeps the current page
1996         in history which is not what we want, so we not additionally
1997         sets the history capacity to 0 (forces removing everything)
1998         and then sets it back to its original value.
1999
2000         * DumpRenderTree/qt/DumpRenderTree.cpp:
2001         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2002
2003 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2004
2005         Unreviewed potential buildbot fix.
2006
2007         Reset page history before running each test.
2008
2009         * DumpRenderTree/qt/DumpRenderTree.cpp:
2010         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2011
2012 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2013
2014         Reviewed by Eric Seidel.
2015
2016         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2017
2018         Bug 28420 -  Implement HTML5 <ruby> rendering
2019         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2020
2021         No new tests (no functional change).
2022
2023         * Scripts/build-webkit:
2024
2025 2009-10-29  Dan Bernstein  <mitz@apple.com>
2026
2027         Reviewed by Mark Rowe.
2028
2029         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2030         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2031         define it.
2032
2033         * Scripts/VCSUtils.pm:
2034         * Scripts/svn-apply:
2035         * Scripts/svn-unapply:
2036
2037 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2038
2039         Reviewed by Gustavo Noronha.
2040
2041         Use the GTK+ main loop instead of rolling our own mini-version of
2042         it.
2043
2044         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2045         (dump):
2046         (runTest):
2047         (webViewLoadFinished):
2048
2049 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2050
2051         Reviewed by Oliver Hunt.
2052
2053         Implement the Qt version of DRT dumpBackForwardList().
2054
2055         * DumpRenderTree/qt/DumpRenderTree.cpp:
2056         (WebCore::dumpHistoryItem):
2057         (WebCore::DumpRenderTree::dumpBackForwardList):
2058
2059 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2060
2061         Reviewed by Adam Roben.
2062
2063         Implement DRT functionality for Qt introduced in
2064         r28690 and r28705.
2065
2066         - Implemented pathToLocalResource which exposes the functionality of
2067         converting a given unix path to the correct location on Windows.
2068         - Implemented a way to remove machine-dependent information from paths
2069         in layout test results.
2070
2071         * DumpRenderTree/qt/DumpRenderTree.cpp:
2072         (WebCore::urlSuitableForTestResult):
2073         (WebCore::WebPage::javaScriptConsoleMessage):
2074         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2075         (LayoutTestController::pathToLocalResource):
2076         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2077
2078 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2079
2080         Adding myself to the committers list.
2081
2082         * Scripts/modules/committers.py:
2083
2084 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2085
2086         Adding myself to the committers list.
2087
2088         * Scripts/modules/committers.py:
2089
2090 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2091
2092         Reviewed by Jan Alonzo.
2093
2094         [GTK] API to start inspector for a WebView
2095         https://bugs.webkit.org/show_bug.cgi?id=22551
2096
2097         Use the new inspector API to implement the LayoutTestController
2098         interfaces used to test the inspector.
2099
2100         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2101         (webInspectorInspectWebView):
2102         (createWebView):
2103         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2104         (LayoutTestController::showWebInspector):
2105         (LayoutTestController::closeWebInspector):
2106         (LayoutTestController::evaluateInWebInspector):
2107
2108 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2109
2110         Reviewed by Eric Seidel.
2111
2112         [Qt] WebFrame::counterValueForElementById must not be exposed
2113         https://bugs.webkit.org/show_bug.cgi?id=30882
2114
2115         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2116         (LayoutTestController::counterValueForElementById):
2117
2118 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2119
2120         Rubberstamped by Oliver Hunt.
2121
2122         Fix the warning:
2123
2124         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2125         declared with attribute warn_unused_result".
2126
2127         by actually checking the result. In the case it is null, an
2128         error has occoured, so treat it as the other fatal errors.
2129
2130         * DumpRenderTree/qt/DumpRenderTree.cpp:
2131         (WebCore::DumpRenderTree::initializeFonts):
2132
2133 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2134
2135         Reviewed by Darin Adler.
2136
2137         Provide a way to get counter values with layoutTestContoller
2138         https://bugs.webkit.org/show_bug.cgi?id=30555
2139
2140         Define layoutTestContoller.counterValueForElementById.
2141
2142         * DumpRenderTree/LayoutTestController.cpp:
2143         (counterValueForElementByIdCallback):
2144         (LayoutTestController::staticFunctions):
2145         * DumpRenderTree/LayoutTestController.h:
2146         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2147         (LayoutTestController::counterValueForElementById):
2148
2149 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2150
2151         Rubberstamped by Oliver Hunt.
2152
2153         Change two methods to be internal for DRT use only.
2154
2155         Part of [Qt] Review all new API in Qt 4.6
2156         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2157
2158         * DumpRenderTree/qt/DumpRenderTree.cpp:
2159         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2160         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2161         (LayoutTestController::whiteListAccessFromOrigin):
2162
2163 2009-10-27  Eric Seidel  <eric@webkit.org>
2164
2165         Reviewed by Adam Barth.
2166
2167         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2168         https://bugs.webkit.org/show_bug.cgi?id=30826
2169
2170         * Scripts/svn-apply:
2171          - Add () around all system() calls.
2172          - Use the correct system() == 0 or die instead of system() or die
2173          - Add descriptive messages to all die statements.
2174
2175 2009-10-27  Steve Block  <steveblock@google.com>
2176
2177         Reviewed by NOBODY.
2178
2179         Adds steveblock@google.com to list of committers.
2180
2181         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2182
2183 2009-10-27  Eric Seidel  <eric@webkit.org>
2184
2185         Reviewed by Adam Barth.
2186
2187         svn-apply can exit(0) even on patch failure
2188         https://bugs.webkit.org/show_bug.cgi?id=29622
2189
2190         * Scripts/svn-apply:
2191          - Add a bunch of "or die" statements, hopefully catching all
2192            possible cases where failure could still exit(0).
2193
2194 2009-10-27  Eric Seidel  <eric@webkit.org>
2195
2196         Reviewed by Adam Barth.
2197
2198         svn-* scripts should share code through VCSUtils.pm
2199         https://bugs.webkit.org/show_bug.cgi?id=30791
2200
2201         Just moving code into a shared location.
2202
2203         * Scripts/VCSUtils.pm:
2204         * Scripts/prepare-ChangeLog:
2205         * Scripts/resolve-ChangeLogs:
2206         * Scripts/svn-apply:
2207         * Scripts/svn-create-patch:
2208         * Scripts/svn-unapply:
2209         * Scripts/update-webkit:
2210
2211 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2212
2213         Suppress a huge number of MSVC warnings when building wxWebKit.
2214
2215         * wx/build/settings.py:
2216
2217 2009-10-26  Eric Seidel  <eric@webkit.org>
2218
2219         No review, just adding Mike Belshe to the committers list.
2220
2221         * Scripts/modules/committers.py:
2222
2223 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2224
2225         Reviewed by Darin Adler.
2226
2227         Make .rc files compile on Windows without depending on MFC headers
2228         https://bugs.webkit.org/show_bug.cgi?id=30750
2229
2230         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2231         windows.h instead of afxres.h because it exists even when MFC is not
2232         installed, and is all that's needed here.
2233
2234         * FindSafari/FindSafari.rc: Ditto
2235
2236 2009-10-24  Eric Seidel  <eric@webkit.org>
2237
2238         Reviewed by Adam Barth.
2239
2240         bugzilla-tool post-diff should know how to mark commit-queue=?
2241         https://bugs.webkit.org/show_bug.cgi?id=29202
2242
2243         * Scripts/bugzilla-tool:
2244          - Add --commit-queue option to post-diff, post-commits and create-bug.
2245         * Scripts/modules/bugzilla.py:
2246          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2247          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2248
2249 2009-10-23  Eric Seidel  <eric@webkit.org>
2250
2251         Reviewed by Adam Barth.
2252
2253         bugzilla-tool commit-queue does not notice modifications to committers.py
2254         https://bugs.webkit.org/show_bug.cgi?id=30084
2255
2256         * Scripts/bugzilla-tool:
2257          - Make commit-queue re-exec itself instead of using while(1).
2258          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2259          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2260
2261 2009-10-22  Eric Seidel  <eric@webkit.org>
2262
2263         Reviewed by Adam Barth.
2264
2265         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2266         https://bugs.webkit.org/show_bug.cgi?id=30634
2267
2268         * Scripts/bugzilla-tool:
2269          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2270          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2271
2272 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2273
2274         Reviewed by Eric Seidel.
2275
2276         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2277
2278         https://bugs.webkit.org/show_bug.cgi?id=30763
2279
2280         * pywebsocket/mod_pywebsocket/__init__.py:
2281         * pywebsocket/mod_pywebsocket/dispatch.py:
2282         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2283         * pywebsocket/mod_pywebsocket/standalone.py:
2284         * pywebsocket/setup.py:
2285         * pywebsocket/test/test_dispatch.py:
2286
2287 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2288
2289         Reviewed by David Levin.
2290
2291         REGRESSION: 2 failures in run-webkit-unittests
2292         https://bugs.webkit.org/show_bug.cgi?id=30645
2293
2294         * Scripts/modules/cpp_style_unittest.py:
2295         Fixed a few test scenarios which apparently lost some spaces from
2296         text literals.
2297
2298 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2299
2300         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2301
2302         * Scripts/webkitdirs.pm:
2303
2304 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2305
2306         Reviewed by Darin Adler.
2307
2308         Unification of using null device in perl scripts.
2309         https://bugs.webkit.org/show_bug.cgi?id=30572
2310
2311         * Scripts/VCSUtils.pm:
2312         * Scripts/bisect-builds:
2313         * Scripts/resolve-ChangeLogs:
2314         * Scripts/run-iexploder-tests:
2315         * Scripts/run-jsc:
2316         * Scripts/run-mangleme-tests:
2317         * Scripts/run-webkit-tests:
2318         * Scripts/webkitdirs.pm:
2319         Using File::Spec->devnull() instead of hard coded /dev/null.
2320
2321 2009-10-26  Eric Seidel  <eric@webkit.org>
2322
2323         Reviewed by Holger Freyther.
2324
2325         Reviewers are missing from committers.py
2326         https://bugs.webkit.org/show_bug.cgi?id=30733
2327
2328         * Scripts/modules/committers.py:
2329
2330 2009-10-23  Eric Seidel  <eric@webkit.org>
2331
2332         No review, only adding Alice to the list of reviewers.
2333
2334         * Scripts/modules/committers.py:
2335
2336 2009-10-23  Eric Seidel  <eric@webkit.org>
2337
2338         Reviewed by Eric Carlson.
2339
2340         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2341         https://bugs.webkit.org/show_bug.cgi?id=30700
2342
2343         * DumpRenderTree/mac/DumpRenderTree.mm:
2344         (resetDefaultsToConsistentValues): Update QuickTime version check.
2345
2346 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2347
2348         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
2349         character measurement APIs that are private on Tiger.
2350
2351         * wx/build/settings.py:
2352
2353 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2354
2355         Reviewed by NOBODY (build fix).
2356         Build fix following bug #30696.
2357
2358         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2359         (LayoutTestController::evaluateScriptInIsolatedWorld):
2360
2361 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2362
2363         Reviewed by Sam Weinig & Geoff Garen.
2364
2365         https://bugs.webkit.org/show_bug.cgi?id=30696
2366         Enable isolated-worlds tests on mac.
2367
2368         Add private interface for DRT to invoke execution in a given world.
2369
2370         * DumpRenderTree/LayoutTestController.cpp:
2371         (evaluateScriptInIsolatedWorldCallback):
2372         (LayoutTestController::staticFunctions):
2373         * DumpRenderTree/LayoutTestController.h:
2374         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2375         (LayoutTestController::evaluateScriptInIsolatedWorld):
2376         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2377         (LayoutTestController::evaluateScriptInIsolatedWorld):
2378
2379 2009-10-21  Eric Seidel  <eric@webkit.org>
2380
2381         Reviewed by Adam Barth.
2382
2383         bugzilla-tool's "patch failed to download an apply" error should give more information
2384         https://bugs.webkit.org/show_bug.cgi?id=30632
2385
2386         * Scripts/modules/scm.py:
2387          - Use the common run_command method instead of custom POpen code.
2388          - Make run_command know how to take pipes as input.
2389         * Scripts/modules/scm_unittest.py:
2390          - Add new tests to cover change.
2391          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2392
2393 2009-10-21  Kent Tamura  <tkent@chromium.org>
2394
2395         Unreviewed.  Adding myself to the committers list.
2396
2397         * Scripts/modules/committers.py:
2398
2399 2009-10-21  Robin Dunn  <robin@alldunn.com>
2400
2401         Reviewed by Kevin Ollivier.
2402
2403         Update the Windows installer builder to work with Vista / Win 7 and with git.
2404
2405         https://bugs.webkit.org/show_bug.cgi?id=30649
2406
2407         * wx/build/build_utils.py:
2408         * wx/packaging/build-mac-installer.py:
2409         * wx/packaging/build-win-installer.py:
2410         * wx/packaging/wxWebKitInstaller.iss.in:
2411
2412 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2413
2414         Reviewed by Gustavo Noronha.
2415
2416         [GTK] Added conditional code to avoid using
2417         gdk_window_get_root_coords if we do not have a gtk+ release newer
2418         than 2.17.3.
2419         https://bugs.webkit.org/show_bug.cgi?id=30636
2420
2421         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2422
2423 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2424
2425         Reviewed by Eric Seidel.
2426
2427         [Qt] Added dummy implementation for keepWebHistory()
2428         https://bugs.webkit.org/show_bug.cgi?id=30592
2429
2430         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2431         (LayoutTestController::keepWebHistory):
2432         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2433
2434 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2435
2436         Reviewed by Xan Lopez.
2437
2438         [GTK] Fixed the double click condition, it is not double click if
2439         we move in just in one direction.
2440         https://bugs.webkit.org/show_bug.cgi?id=30636
2441
2442         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2443
2444 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2445
2446         Reviewed by Xan Lopez.
2447
2448         [GTK] Initialize the events completly before emitting them.
2449         https://bugs.webkit.org/show_bug.cgi?id=30633
2450
2451         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2452
2453 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2454
2455         wx build fix. Fix for when linking using --as-needed with gcc.
2456
2457         * wx/browser/wscript:
2458
2459 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2460
2461         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2462         to support all the features used by CURL backend.
2463
2464         * wx/build/settings.py:
2465         * wx/install-unix-extras:
2466
2467 2009-10-20  Anton Muhin  <antonm@chromium.org>
2468
2469         Reviewed by Adam Barth.
2470
2471         Add {ager,antonm,yurys}@chromium.org into committers.py
2472         https://bugs.webkit.org/show_bug.cgi?id=30560
2473
2474         * Scripts/modules/committers.py:
2475
2476 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2477
2478         Reviewed by Tor Arne Vestbø.
2479
2480         Make the Netscape Test plugin available to the Qt launcher.
2481
2482         * Scripts/run-launcher:
2483
2484 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2485
2486         Reviewed by David Levin.
2487
2488         Removed WebSocket runtime settings.
2489         https://bugs.webkit.org/show_bug.cgi?id=29896
2490
2491         WebSocket runtime configuration is supported by chromium/v8 only.
2492
2493         * DumpRenderTree/mac/DumpRenderTree.mm:
2494         (resetDefaultsToConsistentValues):
2495         * DumpRenderTree/win/DumpRenderTree.cpp:
2496         (resetDefaultsToConsistentValues):
2497
2498 2009-10-19  Nate Chapin  <japhet@chromium.org>
2499
2500         Reviewed by Adam Barth.
2501
2502         Add testFail() to test plugin so we can test our handling of a
2503         plugin invoke call returning false.
2504
2505         https://bugs.webkit.org/show_bug.cgi?id=30239
2506
2507         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2508         (pluginInvoke):
2509         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2510
2511 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2512
2513         Reviewed by Gustavo Noronha.
2514
2515         Enable DOM pasting when running layout tests.
2516
2517         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2518         (resetDefaultsToConsistentValues):
2519
2520 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2521
2522         Reviewed by Simon Hausmann.
2523
2524         Use the setPreferredContentsSize method instead
2525         of setFixedContentsSize, as the method has been renamed.
2526
2527         * DumpRenderTree/qt/DumpRenderTree.cpp:
2528         (WebCore::DumpRenderTree::open):
2529         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2530         (LayoutTestController::setFixedContentsSize):
2531
2532 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2533
2534         Reviewed by Dan Bernstein.
2535
2536         https://bugs.webkit.org/show_bug.cgi?id=30456
2537         Fixes for new Debug_All Windows build configuration.
2538
2539         * DumpRenderTree/win/DumpRenderTree.cpp:
2540         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2541         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2542
2543 2009-10-16  Eric Seidel  <eric@webkit.org>
2544
2545         Reviewed by Adam Barth.
2546
2547         commit-queue status bot should list which buildbot is blocking the queue
2548         https://bugs.webkit.org/show_bug.cgi?id=30452
2549
2550         Add new methods and testing.
2551
2552         * Scripts/bugzilla-tool:
2553         * Scripts/modules/buildbot.py:
2554         * Scripts/modules/buildbot_unittest.py:
2555
2556 2009-10-16  Eric Seidel  <eric@webkit.org>
2557
2558         Reviewed by Adam Barth.
2559
2560         run-webkit-tests fails when CWD is not inside a WebKit checkout
2561         https://bugs.webkit.org/show_bug.cgi?id=30451
2562
2563         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2564         * Scripts/modules/scm_unittest.py:
2565           - Remove use of original_path (we don't need to restore the CWD).
2566           - Don't use '.' to find the webkit checkout, use __file__ instead.
2567
2568 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2569
2570         Reviewed by Adam Roben.
2571
2572         Add a Debug_All configuration to build entire stack as debug.
2573         Change Debug_Internal to:
2574         - stop using _debug suffix for all WebKit/Safari binaries
2575         - not use _debug as a DLL naming suffix
2576         - use non-debug C runtime lib.
2577
2578         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2579         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2580         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2581         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2582         Add missing debug.vsprops inherited property sheet.
2583         Add Debug_All configuration.
2584         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2585         * WinLauncher/WinLauncher.vcproj:
2586         Removed extraneous definitions inherited from vsprops.
2587         Add Debug_All configuration.
2588
2589 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2590
2591         Reviewed by David Levin.
2592
2593         check-webkit-style is wrong about indent checking in namespaces
2594         in header files and a few other things
2595         https://bugs.webkit.org/show_bug.cgi?id=30362
2596
2597         The few other things include:
2598         + check-webkit-style does not require spaces around the equal sign
2599           inside 'if' statements and around binary operators that take
2600           numeric literals.
2601         + check-webkit-style reports false errors for the / operator
2602           when part of a filename in the #include directive.
2603
2604         * Scripts/modules/cpp_style.py:
2605         Improved indentation checking and space checking around
2606         binary operators. While the checks are still not perfect,
2607         they are clearly better than before.
2608         * Scripts/modules/cpp_style_unittest.py:
2609         Added test cases for the newly supported checks and modified old
2610         test cases to match the new guidelines
2611
2612 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2613
2614         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2615
2616         * wx/build/settings.py:
2617
2618 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2619
2620         Reviewed by David Levin.
2621
2622         Add mod_pywebsocket to test Web Sockets.
2623         http://code.google.com/p/pywebsocket/
2624         https://bugs.webkit.org/show_bug.cgi?id=27490
2625
2626         * pywebsocket/COPYING: Added.
2627         * pywebsocket/MANIFEST.in: Added.
2628         * pywebsocket/README: Added.
2629         * pywebsocket/example/echo_client.py: Added.
2630         * pywebsocket/example/echo_wsh.py: Added.
2631         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2632         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2633         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2634         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2635         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2636         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2637         * pywebsocket/mod_pywebsocket/util.py: Added.
2638         * pywebsocket/setup.py: Added.
2639         * pywebsocket/test/config.py: Added.
2640         * pywebsocket/test/mock.py: Added.
2641         * pywebsocket/test/run_all.py: Added.
2642         * pywebsocket/test/test_dispatch.py: Added.
2643         * pywebsocket/test/test_handshake.py: Added.
2644         * pywebsocket/test/test_mock.py: Added.
2645         * pywebsocket/test/test_msgutil.py: Added.
2646         * pywebsocket/test/test_util.py: Added.
2647         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2648         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2649         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2650         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2651         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2652         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2653         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2654         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2655
2656 2009-10-15  James Robinson  <jamesr@google.com>
2657
2658         Reviewed by David Levin.
2659
2660         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2661
2662         https://bugs.webkit.org/show_bug.cgi?id=30426
2663
2664         * Scripts/modules/cpp_style.py:
2665         * Scripts/modules/cpp_style_unittest.py:
2666
2667 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2668
2669         Reviewed by Adam Roben.
2670
2671         Fixes <http://webkit.org/b/30411>.
2672         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2673
2674         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2675         building Chromium.
2676
2677         * Scripts/pdevenv:
2678
2679 2009-10-15  Robin Dunn  <robin@alldunn.com>
2680
2681         Reviewed by Kevin Ollivier.
2682
2683         Add Mac package building scripts for wx.
2684
2685         https://bugs.webkit.org/show_bug.cgi?id=30405
2686
2687         * wx/build/build_utils.py:
2688         * wx/build/settings.py:
2689         * wx/packaging/build-mac-installer.py: Added.
2690
2691 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2692
2693         Reviewed by Gustavo Noronha.
2694
2695         Enable Web Sockets support when running layout tests.
2696
2697         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2698         (resetDefaultsToConsistentValues):
2699
2700 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2701
2702         Reviewed by Gustavo Noronha.
2703
2704         Need to initialize event.button.button, since in most cases a
2705         button number is not passed as an argument.
2706
2707         * DumpRenderTree/gtk/EventSender.cpp:
2708         (mouseDownCallback):
2709         (mouseUpCallback):
2710
2711 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2712
2713         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2714         the OS if none was explicitly set.
2715
2716         * wx/build/settings.py:
2717
2718 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2719
2720         Reviewed by Timothy Hatcher.
2721
2722         Web Inspector: enable developers extras within inspector layout tests.
2723
2724         https://bugs.webkit.org/show_bug.cgi?id=30014
2725
2726         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2727         (LayoutTestController::showWebInspector):
2728         (LayoutTestController::closeWebInspector):
2729         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2730         (LayoutTestController::showWebInspector):
2731         (LayoutTestController::closeWebInspector):
2732
2733 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2734
2735         Reviewed by Jan Alonzo.
2736
2737         GtkLauncher is using a deprecated signal
2738         https://bugs.webkit.org/show_bug.cgi?id=30364
2739
2740         Modified GtkLauncher to use notify::title signal instead of
2741         deprecated title-changed signal
2742
2743         * GtkLauncher/main.c:
2744         (notify_title_cb):
2745         (create_browser):
2746
2747 2009-10-14  Brady Eidson  <beidson@apple.com>
2748
2749         Reviewed by Sam Weinig.
2750
2751         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2752         1 - Disables WebHistory
2753         2 - Doesn't make sense in that context anyway.
2754
2755         * DumpRenderTree/win/DumpRenderTree.cpp:
2756         (createWebViewAndOffscreenWindow):
2757
2758 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2759
2760         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2761         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2762
2763         * wx/build/settings.py:
2764         * wx/install-unix-extras:
2765
2766 2009-10-14  Brady Eidson  <beidson@apple.com>
2767
2768         Reviewed by Sam Weinig.
2769
2770         WebKit Win API should provide a delegate interface for global history.
2771         https://bugs.webkit.org/show_bug.cgi?id=29905
2772
2773         * DumpRenderTree/LayoutTestController.cpp:
2774         (LayoutTestController::LayoutTestController):
2775         * DumpRenderTree/LayoutTestController.h:
2776         (LayoutTestController::dumpHistoryDelegateCallbacks):
2777         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2778
2779         * DumpRenderTree/win/DumpRenderTree.cpp:
2780         (shouldLogHistoryDelegates):
2781         (runTest):
2782         (createWebViewAndOffscreenWindow):
2783         (main):
2784         * DumpRenderTree/win/DumpRenderTree.vcproj:
2785
2786         Add the IWebHistoryDelegate to DRT Windows:
2787         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2788         (wstringFromBSTR):
2789         (HistoryDelegate::HistoryDelegate):
2790         (HistoryDelegate::~HistoryDelegate):
2791         (HistoryDelegate::QueryInterface):
2792         (HistoryDelegate::AddRef):
2793         (HistoryDelegate::Release):
2794         (HistoryDelegate::didNavigateWithNavigationData):
2795         (HistoryDelegate::didPerformClientRedirectFromURL):
2796         (HistoryDelegate::didPerformServerRedirectFromURL):
2797         (HistoryDelegate::updateHistoryTitle):
2798         (HistoryDelegate::populateVisitedLinksForWebView):
2799         * DumpRenderTree/win/HistoryDelegate.h: Added.
2800
2801         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2802         (LayoutTestController::removeAllVisitedLinks):
2803
2804 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2805
2806         Reviewed by Simon Hausmann.
2807
2808         [Qt] Implement support for setPOSIXLocale on Qt.
2809         https://bugs.webkit.org/show_bug.cgi?id=30268
2810
2811         * DumpRenderTree/qt/DumpRenderTree.cpp:
2812         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2813         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2814         (LayoutTestController::setPOSIXLocale):
2815         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2816
2817 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2818
2819         Unreviewed, adding myself to reviewers list.
2820
2821         * Scripts/modules/committers.py:
2822
2823 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2824
2825         Reviewed by Mark Rowe.
2826
2827         Fix null assignment so root tests work again.
2828
2829         * Scripts/webkitdirs.pm:
2830
2831 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2832
2833         Reviewed by Simon Hausmann.
2834
2835         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
2836         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
2837         This is done in preparation of implementing missing features in DRT.
2838         No functionality changes made yet.
2839
2840         * DumpRenderTree/qt/DumpRenderTree.cpp:
2841         * DumpRenderTree/qt/DumpRenderTree.pro:
2842         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
2843         (EventSender::EventSender):
2844         (EventSender::mouseDown):
2845         (EventSender::mouseUp):
2846         (EventSender::mouseMoveTo):
2847         (EventSender::leapForward):
2848         (EventSender::keyDown):
2849         (EventSender::contextClick):
2850         (EventSender::scheduleAsynchronousClick):
2851         (EventSender::frameUnderMouse):
2852         * DumpRenderTree/qt/EventSenderQt.h: Added.
2853         (EventSender::clearKillRing):
2854         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
2855         (LayoutTestController::LayoutTestController):
2856         (LayoutTestController::reset):
2857         (LayoutTestController::processWork):
2858         (LayoutTestController::maybeDump):
2859         (LayoutTestController::waitUntilDone):
2860         (LayoutTestController::notifyDone):
2861         (LayoutTestController::windowCount):
2862         (LayoutTestController::clearBackForwardList):
2863         (LayoutTestController::dumpEditingCallbacks):
2864         (LayoutTestController::dumpResourceLoadCallbacks):
2865         (LayoutTestController::queueBackNavigation):
2866         (LayoutTestController::queueForwardNavigation):
2867         (LayoutTestController::queueLoad):
2868         (LayoutTestController::queueReload):
2869         (LayoutTestController::queueScript):
2870         (LayoutTestController::provisionalLoad):
2871         (LayoutTestController::timerEvent):
2872         (LayoutTestController::encodeHostName):
2873         (LayoutTestController::decodeHostName):
2874         (LayoutTestController::setJavaScriptProfilingEnabled):
2875         (LayoutTestController::setFixedContentsSize):
2876         (LayoutTestController::setPrivateBrowsingEnabled):
2877         (LayoutTestController::setPopupBlockingEnabled):
2878         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2879         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2880         (LayoutTestController::numberOfActiveAnimations):
2881         (LayoutTestController::disableImageLoading):
2882         (LayoutTestController::dispatchPendingLoadRequests):
2883         (LayoutTestController::setDatabaseQuota):
2884         (LayoutTestController::clearAllDatabases):
2885         (LayoutTestController::whiteListAccessFromOrigin):
2886         (LayoutTestController::waitForPolicyDelegate):
2887         (LayoutTestController::overridePreference):
2888         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
2889         (LayoutTestController::isLoading):
2890         (LayoutTestController::setLoading):
2891         (LayoutTestController::shouldDumpAsText):
2892         (LayoutTestController::shouldDumpBackForwardList):
2893         (LayoutTestController::shouldDumpChildrenAsText):
2894         (LayoutTestController::shouldDumpDatabaseCallbacks):
2895         (LayoutTestController::shouldDumpStatusCallbacks):
2896         (LayoutTestController::shouldWaitUntilDone):
2897         (LayoutTestController::canOpenWindows):
2898         (LayoutTestController::shouldDumpTitleChanges):
2899         (LayoutTestController::waitForPolicy):
2900         (LayoutTestController::dumpAsText):
2901         (LayoutTestController::dumpChildFramesAsText):
2902         (LayoutTestController::dumpDatabaseCallbacks):
2903         (LayoutTestController::dumpStatusCallbacks):
2904         (LayoutTestController::setCanOpenWindows):
2905         (LayoutTestController::dumpBackForwardList):
2906         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2907         (LayoutTestController::display):
2908         (LayoutTestController::dumpTitleChanges):
2909         (LayoutTestController::dumpSelectionRect):
2910         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
2911         (TextInputController::TextInputController):
2912         (TextInputController::doCommand):
2913         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
2914         * DumpRenderTree/qt/WorkQueue.cpp:
2915         * DumpRenderTree/qt/WorkQueue.h:
2916         * DumpRenderTree/qt/WorkQueueItem.h:
2917         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
2918         (findFrameNamed):
2919         (LoadItem::invoke):
2920         (ReloadItem::invoke):
2921         (ScriptItem::invoke):
2922         (BackForwardItem::invoke):
2923         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
2924         * DumpRenderTree/qt/jsobjects.h:
2925
2926 2009-10-13  Dmitry Titov  <dimich@chromium.org>
2927
2928         Not reviewed, adding myself to the list of reviewers.
2929
2930         * Scripts/modules/committers.py:
2931
2932 2009-10-13  Anders Carlsson  <andersca@apple.com>
2933
2934         Reviewed by Sam Weinig.
2935
2936         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
2937
2938         Make the private browsing mode testable by the test plug-in.
2939
2940         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2941         (pluginGetProperty):
2942         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2943         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2944         (NPP_New):
2945         (NPP_SetValue):
2946
2947 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
2948
2949         No review, just adding self to the list of reviewers.
2950
2951         * Scripts/modules/committers.py:
2952
2953 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
2954
2955         Reviewed by Adam Roben.
2956
2957         Web Inspector: Use proper web view in inspector layout
2958         tests for windows.
2959
2960         https://bugs.webkit.org/show_bug.cgi?id=30298
2961
2962         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2963         (LayoutTestController::showWebInspector):
2964         (LayoutTestController::closeWebInspector):
2965         (LayoutTestController::evaluateInWebInspector):
2966
2967 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
2968
2969         Reviewed by Sam Weinig.
2970
2971         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
2972         https://bugs.webkit.org/show_bug.cgi?id=29841
2973
2974         * DumpRenderTree/mac/DumpRenderTree.mm:
2975         (resetDefaultsToConsistentValues):
2976         * DumpRenderTree/win/DumpRenderTree.cpp:
2977         (resetDefaultsToConsistentValues):
2978
2979 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
2980
2981         Reviewed by Dimitri Glazkov.
2982
2983         Chromium Port - Windows
2984         https://bugs.webkit.org/show_bug.cgi?id=29969
2985
2986         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
2987         * Scripts/webkitdirs.pm:
2988
2989 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
2990
2991         Reviewed by Darin Adler.
2992
2993         jsc scripts cleanup and Qt/GTK fix
2994         https://bugs.webkit.org/show_bug.cgi?id=30288
2995
2996         Duplicated jscPath() moved to webkitdirs.pm.
2997         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
2998         Configuration added (release/debug) to path for Qt-port on Windows.
2999
3000         * Scripts/run-javascriptcore-tests:
3001         * Scripts/run-jsc:
3002         * Scripts/run-sunspider:
3003         * Scripts/sunspider-compare-results:
3004         * Scripts/webkitdirs.pm:
3005
3006 2009-10-11  Adam Barth  <abarth@webkit.org>
3007
3008         Unreviewed.  Add Collin to committers.py.
3009
3010         * Scripts/modules/committers.py:
3011
3012 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3013
3014         wx build fix, add bindings to source/include dirs now that there are sources there.
3015
3016         * wx/build/settings.py:
3017
3018 2009-10-09  Mark Rowe  <mrowe@apple.com>
3019
3020         Reviewed by Brady Eidson.
3021
3022         Enable plug-in halting in DumpRenderTree.
3023
3024         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3025         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3026
3027         * DumpRenderTree/mac/DumpRenderTree.mm:
3028         (resetDefaultsToConsistentValues):
3029         * DumpRenderTree/mac/UIDelegate.mm:
3030         (-[UIDelegate webView:shouldHaltPlugin:]):
3031
3032 2009-10-08  Brady Eidson  <beidson@apple.com>
3033
3034         Reviewed by Dan Bernstein.
3035
3036         Ask the History Delegate to populate the visited links hash.
3037         <rdar://problem/7285293> and https://webkit.org/b/29904
3038
3039         Add the ability for LayoutTestController to clear all visited links.
3040         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3041
3042         * DumpRenderTree/LayoutTestController.cpp:
3043         (LayoutTestController::LayoutTestController):
3044         (removeAllVisitedLinksCallback):
3045         (LayoutTestController::staticFunctions):
3046         * DumpRenderTree/LayoutTestController.h:
3047         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3048         (LayoutTestController::removeAllVisitedLinks):
3049
3050         * DumpRenderTree/mac/HistoryDelegate.mm:
3051         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3052
3053         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3054         (LayoutTestController::removeAllVisitedLinks):
3055         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3056         (LayoutTestController::removeAllVisitedLinks):
3057         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3058         (LayoutTestController::removeAllVisitedLinks):
3059
3060
3061 2009-10-08  Daniel Bates  <dbates@webkit.org>
3062
3063         Reviewed by Adam Roben.
3064
3065         https://bugs.webkit.org/show_bug.cgi?id=30175
3066
3067         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3068         the OLE drag-and-drop return value like the function it emulates. Currently,
3069         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
3070         whether the drag-and-drop operation was successful or was cancelled.
3071
3072         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
3073         return value according to whether the drop operation was successful or not.
3074
3075         * DumpRenderTree/win/EventSender.cpp:
3076         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3077         (replaySavedEvents): Ditto.
3078         * DumpRenderTree/win/EventSender.h:
3079         * DumpRenderTree/win/UIDelegate.cpp:
3080         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3081
3082 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3083
3084         Reviewed by Xan Lopez.
3085
3086         [GTK] Added support for a parameter setting the button that was
3087         pressed in the mouseDown function.
3088         https://bugs.webkit.org/show_bug.cgi?id=30220
3089
3090         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3091
3092 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3093
3094         Reviewed by Xan Lopez.
3095
3096         [GTK] Added a line to the bottom of the expected result to match
3097         the output of the test.
3098         https://bugs.webkit.org/show_bug.cgi?id=30220
3099
3100         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3101         expected.txt:
3102
3103 2009-10-08  Adam Roben  <aroben@apple.com>
3104
3105         Use QueryInterface to get IWebInspectorPrivate
3106
3107         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3108         accessed in a more standard way
3109
3110         Reviewed by John Sullivan and Tim Hatcher.
3111
3112         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3113         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3114         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3115         to the IWebInspectorPrivate interface.
3116
3117 2009-10-07  Adam Roben  <aroben@apple.com>
3118
3119         Implement DRT support for origin whitelisting
3120
3121         Fixes <http://webkit.org/b/30185>.
3122
3123         Reviewed by Eric Seidel.
3124
3125         * DumpRenderTree/win/DumpRenderTree.cpp:
3126         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3127         whitelist, to match Mac DRT.
3128         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3129         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3130         IWebViewPrivate::whiteListAccessFromOrigin.
3131
3132 2009-10-07  Brady Eidson  <beidson@apple.com>
3133
3134         Reviewed by Darin Adler.
3135
3136         Send title changes to the global history delegate.
3137         <rdar://problem/7285293> and https://webkit.org/b/29904
3138
3139         * DumpRenderTree/mac/HistoryDelegate.mm:
3140         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3141
3142 2009-10-07  Adam Barth  <abarth@webkit.org>
3143
3144         Unreviewed.  Remove some folks from committers.py who were listed on
3145         the WebKit Team wiki page but who weren't actually listed as commit+.
3146         At some point, we should coorelate this list with the committers
3147         mailing list.
3148
3149         * Scripts/modules/committers.py:
3150
3151 2009-10-07  Adam Barth  <abarth@webkit.org>
3152
3153         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3154         the wiki into committers.py.
3155
3156         * Scripts/modules/committers.py:
3157
3158 2009-10-07  Adam Barth  <abarth@webkit.org>
3159
3160         Unreviewed.  Added Aaron Boodman to committers.py.
3161
3162         * Scripts/modules/committers.py:
3163
3164 2009-10-07  Evan Martin  <evan@chromium.org>
3165
3166         Reviewed by Darin Adler.
3167
3168         Add API to LayoutTestController for re/setting the system locale.
3169         https://bugs.webkit.org/show_bug.cgi?id=18994
3170
3171         * DumpRenderTree/LayoutTestController.cpp:
3172         (setLocaleCallback):
3173         (LayoutTestController::staticFunctions):
3174         (LayoutTestController::setLocale):
3175         * DumpRenderTree/LayoutTestController.h:
3176
3177 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3178
3179         Reviewed by Jan Alonzo.
3180
3181         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3182         https://bugs.webkit.org/show_bug.cgi?id=29689
3183
3184         Build fix by adding -lfontconfig for DumpRenderTree.
3185
3186         * GNUmakefile.am:
3187
3188 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3189
3190         Reviewed by Simon Hausmann.
3191
3192         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3193
3194         * Scripts/run-webkit-tests:
3195
3196 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3197
3198         Reviewed by Gustavo Noronha.
3199
3200         "delete" in EventSender is the backspace key, not the delete one.
3201
3202         * DumpRenderTree/gtk/EventSender.cpp:
3203         (keyDownCallback):
3204
3205 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3206
3207         Reviewed by Gustavo Noronha.
3208
3209         getChildrenWithRange expects as last parameter the end index, not
3210         the length of the range. Correct this and clarify the variable
3211         names to reflect how the code works.
3212
3213         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3214         (AccessibilityUIElement::getChildrenWithRange):
3215         (AccessibilityUIElement::getChildAtIndex):
3216
3217 2009-10-06  Mark Rowe  <mrowe@apple.com>
3218
3219         Reviewed by Simon Fraser.
3220
3221         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3222
3223         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3224         the fact we have already changed the working directory to the top of the open source tree.
3225
3226 2009-10-06  Julie Parent  <jparent@chromium.org>
3227
3228         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3229         rather than my committer email.
3230
3231         * Scripts/modules/committers.py:
3232
3233 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3234
3235         Reviewed by Eric Seidel.
3236
3237         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3238
3239         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3240         it after each layout test as it should do, making the DRT dump additional output
3241         for all of the subsequent layout tests.
3242
3243         * DumpRenderTree/qt/jsobjects.cpp:
3244         (LayoutTestController::reset):
3245
3246 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3247
3248         Reviewed by Simon Hausmann.
3249
3250         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3251         fast/dom/assign-to-window-status.html test, which is passing as a result.
3252
3253         https://bugs.webkit.org/show_bug.cgi?id=30127
3254
3255         * DumpRenderTree/qt/DumpRenderTree.cpp:
3256         (WebCore::DumpRenderTree::DumpRenderTree):
3257         (WebCore::DumpRenderTree::statusBarMessage):
3258         * DumpRenderTree/qt/DumpRenderTree.h:
3259         * DumpRenderTree/qt/jsobjects.h:
3260         (LayoutTestController::shouldDumpStatusCallbacks):
3261         (LayoutTestController::dumpStatusCallbacks):
3262
3263 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3264
3265         Reviewed by Simon Hausmann.
3266
3267         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3268         ignores the argument indicating which mouse button to trigger.
3269         https://bugs.webkit.org/show_bug.cgi?id=30048
3270
3271         This affects the fast/events/mouse-click-events.html layout test.
3272
3273         * DumpRenderTree/qt/jsobjects.cpp:
3274         (EventSender::mouseDown):
3275         (EventSender::mouseUp):
3276         * DumpRenderTree/qt/jsobjects.h:
3277
3278 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3279
3280         Reviewed by Simon Hausmann.
3281
3282         [Qt] Fix the EventSender::keyDown() implementation
3283         https://bugs.webkit.org/show_bug.cgi?id=30043
3284
3285         It should post both a key press event and a key release event,
3286         just like other ports do.
3287
3288         * DumpRenderTree/qt/jsobjects.cpp:
3289         (EventSender::keyDown):
3290
3291 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3292
3293         wx build fix. Add jpeg to the list of libs to link against.
3294
3295         * wx/build/settings.py:
3296
3297 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3298
3299         Reviewed by Simon Hausmann.
3300
3301         [Qt] EventSender::keyDown() cannot send function-key events.
3302         https://bugs.webkit.org/show_bug.cgi?id=30044
3303
3304         This affects the fast/events/keydown-function-keys.html layout test.
3305
3306         * DumpRenderTree/qt/jsobjects.cpp:
3307         (EventSender::keyDown):
3308
3309 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3310
3311         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3312         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3313
3314         * wx/build/settings.py:
3315         * wx/build/wxpresets.py:
3316
3317 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3318
3319         Reviewed by Timothy Hatcher.
3320
3321         Web Inspector: add testing harness for Web Inspector.
3322
3323         https://bugs.webkit.org/show_bug.cgi?id=30010
3324
3325         * DumpRenderTree/LayoutTestController.cpp:
3326         (showWebInspectorCallback):
3327         (closeWebInspectorCallback):
3328         (evaluateInWebInspectorCallback):
3329         (LayoutTestController::staticFunctions):
3330         * DumpRenderTree/LayoutTestController.h:
3331         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3332         (LayoutTestController::showWebInspector):
3333         (LayoutTestController::closeWebInspector):
3334         (LayoutTestController::evaluateInWebInspector):
3335         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3336         (LayoutTestController::showWebInspector):
3337         (LayoutTestController::closeWebInspector):
3338         (LayoutTestController::evaluateInWebInspector):
3339         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3340         (LayoutTestController::showWebInspector):
3341         (LayoutTestController::closeWebInspector):
3342         (LayoutTestController::evaluateInWebInspector):
3343         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3344         (LayoutTestController::showWebInspector):
3345         (LayoutTestController::closeWebInspector):
3346         (LayoutTestController::evaluateInWebInspector):
3347
3348 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3349
3350         Reviewed by Ariyha Hidayat.
3351
3352         Pass arguments to system() as a string instead of array
3353
3354         When passed as an array entries with a space fail to translate
3355         to two arguments to the child process, so instead of manually
3356         splitting all the entries in @buildArgs we pass the whole thing
3357         as a string instead.
3358
3359         * Scripts/webkitdirs.pm:
3360
3361 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3362
3363         Reviewed by David Levin.
3364
3365         check-webkit-style misses whitespace errors for operators:
3366         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3367         https://bugs.webkit.org/show_bug.cgi?id=30021
3368
3369         * Scripts/modules/cpp_style.py:
3370         Added the operators mentioned above to the same list as == and !=.
3371
3372 2009-10-02  Julie Parent  <jparent@chromium.org>
3373
3374         Unreviewed.
3375
3376         Adding myself and Ojan Vafai as committers, because we are committers.
3377
3378         * Scripts/modules/committers.py:
3379
3380 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3381
3382         Reviewed by Adam Roben.
3383
3384         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3385         this will help the patch merging process when TryBots are used.
3386
3387         * Scripts/svn-create-patch:
3388
3389 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3390
3391         Reviewed by Simon Hausmann.
3392
3393         [Qt] Implement layoutTestController.overridePreference().
3394         https://bugs.webkit.org/show_bug.cgi?id=29970
3395
3396         * DumpRenderTree/qt/DumpRenderTree.cpp:
3397         (WebCore::WebPage::WebPage):
3398         (WebCore::WebPage::resetSettings):
3399         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3400         * DumpRenderTree/qt/jsobjects.cpp:
3401         (LayoutTestController::reset):
3402         (LayoutTestController::setPrivateBrowsingEnabled):
3403         (LayoutTestController::setPopupBlockingEnabled):
3404         (LayoutTestController::overridePreference):
3405         * DumpRenderTree/qt/jsobjects.h:
3406
3407 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3408
3409         Reviewed by Oliver Hunt.
3410
3411         Turn on ENABLE_3D_CANVAS in TOT
3412         https://bugs.webkit.org/show_bug.cgi?id=29906
3413
3414         * Scripts/build-webkit:
3415
3416 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3417
3418         Rubberstamped by Simon Hausmann.
3419
3420         Enable HTTP tests for Qt
3421
3422         * Scripts/run-webkit-tests:
3423
3424 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3425
3426         Reviewed by Dimitri Glazkov.
3427
3428         build-webkit --chromium now also works on cygwin.
3429
3430         https://bugs.webkit.org/show_bug.cgi?id=29973
3431
3432         * Scripts/webkitdirs.pm:
3433
3434 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3435
3436         Reviewed by Simon Hausmann.
3437
3438         [Qt] Don't use TCmalloc in DumpRenderTree
3439         https://bugs.webkit.org/show_bug.cgi?id=27029
3440
3441         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3442
3443         * DumpRenderTree/qt/DumpRenderTree.pro:
3444
3445 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3446
3447         Reviewed by Simon Hausmann.
3448
3449         [Qt] Implement eventSender.scheduleAsynchronousClick().
3450
3451         https://bugs.webkit.org/show_bug.cgi?id=29931
3452
3453         * DumpRenderTree/qt/jsobjects.cpp:
3454         (EventSender::scheduleAsynchronousClick):
3455         * DumpRenderTree/qt/jsobjects.h:
3456
3457 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3458
3459         Reviewed by Simon Hausmann.
3460
3461         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3462         fast/events/open-window-from-another-frame.html from the Skipped list.
3463
3464         https://bugs.webkit.org/show_bug.cgi?id=29930
3465
3466         * DumpRenderTree/qt/jsobjects.cpp:
3467         (LayoutTestController::setPopupBlockingEnabled):
3468         * DumpRenderTree/qt/jsobjects.h:
3469
3470 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3471
3472         Unreviewed.
3473
3474         Added myself to the list of committers.
3475
3476         * Scripts/modules/committers.py:
3477
3478 2009-09-30  Eric Seidel  <eric@webkit.org>
3479
3480         No review, just adding Geoff to the list of reviewers.
3481
3482         * Scripts/modules/committers.py:
3483
3484 2009-09-30  Dan Bernstein  <mitz@apple.com>
3485
3486         Reviewed by Sam Weinig.
3487
3488         Added the WebKit Layout Tests fonts that are referenced in
3489         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3490
3491         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3492         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3493
3494 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3495
3496         Reviewed by David Kilzer.
3497
3498         Make sunspider scripts work on Windows platform.
3499         https://bugs.webkit.org/show_bug.cgi?id=29656
3500
3501         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3502         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3503         * Scripts/webkitdirs.pm: currentPerlPath() added.
3504
3505 2009-09-29  Brady Eidson  <beidson@apple.com>
3506
3507         Rubberstamped by Dan Bernstein.
3508
3509         Fix license and some sorting in new files.
3510
3511         * DumpRenderTree/mac/HistoryDelegate.h:
3512         * DumpRenderTree/mac/HistoryDelegate.mm:
3513
3514 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3515
3516         Reviewed by David Kilzer.
3517
3518         Fixed how error codes are handled.
3519         https://bugs.webkit.org/show_bug.cgi?id=29898
3520
3521         * Scripts/update-webkit:
3522         * Scripts/update-webkit-chromium:
3523
3524 2009-09-29  Brady Eidson  <beidson@apple.com>
3525
3526         Reviewed by John Sullivan.
3527
3528         Updated way-out-of-date sorting throughout the dump methods/flags.
3529
3530         * DumpRenderTree/LayoutTestController.cpp:
3531         (LayoutTestController::LayoutTestController):
3532         (dumpAsPDFCallback):
3533         (dumpAsTextCallback):
3534         (dumpFrameLoadCallbacksCallback):
3535         (dumpResourceLoadCallbacksCallback):
3536         (LayoutTestController::staticFunctions):
3537
3538         * DumpRenderTree/LayoutTestController.h:
3539         (LayoutTestController::dumpAsText):
3540         (LayoutTestController::setDumpAsText):
3541         (LayoutTestController::dumpFrameLoadCallbacks):
3542         (LayoutTestController::setDumpFrameLoadCallbacks):
3543         (LayoutTestController::dumpSelectionRect):
3544         (LayoutTestController::setDumpSelectionRect):
3545         (LayoutTestController::dumpSourceAsWebArchive):
3546         (LayoutTestController::setDumpSourceAsWebArchive):
3547         (LayoutTestController::dumpStatusCallbacks):
3548         (LayoutTestController::setDumpStatusCallbacks):
3549         (LayoutTestController::dumpTitleChanges):
3550         (LayoutTestController::setDumpTitleChanges):
3551         (LayoutTestController::dumpWillCacheResponse):
3552         (LayoutTestController::setDumpWillCacheResponse):
3553
3554 2009-09-29  Brady Eidson  <beidson@apple.com>
3555
3556         Reviewed by John Sullivan.
3557
3558         WebKit Mac API should provide a delegate interface for global history.
3559         <rdar://problem/7042773> and https://webkit.org/b/29904
3560
3561         Adding the dumping of global history delegate callbacks.
3562
3563         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3564
3565         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3566         * DumpRenderTree/mac/DumpRenderTree.mm:
3567         (createWebViewAndOffscreenWindow):
3568         (allocateGlobalControllers):
3569         (shouldLogFrameLoadDelegates):
3570         (shouldLogHistoryDelegates):
3571         (runTest):
3572
3573         Dump history delegate callbacks:
3574         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3575         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3576         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3577         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3578         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3579
3580 2009-09-29  Daniel Bates  <dbates@webkit.org>
3581
3582         Reviewed by Adam Roben.
3583
3584         https://bugs.webkit.org/show_bug.cgi?id=28902
3585
3586         Fixes an issue where the drop effect returned by Window Dump Render Tree
3587         was always DROPEFFECT_NONE (since it was hard coded to do so).
3588
3589         This patch corrects this issue by determining the actual drop effect
3590         performed by the corresponding drag-and-drop operation so that we can
3591         return it.
3592
3593         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3594         (DraggingInfo::DraggingInfo):
3595         (DraggingInfo::performedDropEffect): Added method.
3596         (DraggingInfo::setPerformedDropEffect): Added method.
3597         * DumpRenderTree/win/EventSender.cpp:
3598         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3599         Moved delete draggingInfo to UIDelegate::doDragDrop.
3600         * DumpRenderTree/win/UIDelegate.cpp:
3601         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3602
3603 2009-09-29  Dan Bernstein  <mitz@apple.com>
3604
3605         Reviewed by Adam Roben.
3606
3607         Remove copying of unnecessary or nonexistent files from the ImageDiff
3608         post-build event.
3609
3610         * DumpRenderTree/win/ImageDiff.vcproj:
3611
3612 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3613
3614         Reviewed by David Kilzer.
3615
3616         [Qt] Make build-webkit script work on Windows
3617         https://bugs.webkit.org/show_bug.cgi?id=29802
3618
3619         * Scripts/run-webkit-tests:
3620         * Scripts/webkitdirs.pm:
3621          - Removed unnecessary -p switch for mkdir on Windows.
3622          - Use canonical path, which uses slashes or backslashes depends on platform.
3623          - isWindows() only test for Windows and not for Cyqwin.
3624
3625 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3626
3627         Reviewed by Simon Hausmann.
3628
3629         Fix time measurement in build-webkit after refactoring done in r48853.
3630
3631         * Scripts/build-webkit:
3632
3633 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3634
3635         Reviewed by Tor Arne Vestbø.
3636
3637         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
3638         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
3639
3640         * DumpRenderTree/qt/DumpRenderTree.cpp:
3641         (WebCore::WebPage::WebPage):
3642
3643 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
3644
3645         Reviewed by Simon Hausmann.
3646
3647         [Qt] Implement eventSender.contextClick().
3648         https://bugs.webkit.org/show_bug.cgi?id=29821
3649
3650         * DumpRenderTree/qt/jsobjects.cpp:
3651         (EventSender::contextClick):
3652         * DumpRenderTree/qt/jsobjects.h:
3653
3654 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3655
3656         Reviewed by Eric Seidel.
3657
3658         Add experimentalWebSocketsEnabled in WebPreferences.
3659         https://bugs.webkit.org/show_bug.cgi?id=28941
3660
3661         * DumpRenderTree/mac/DumpRenderTree.mm:
3662         (resetDefaultsToConsistentValues):
3663         * DumpRenderTree/win/DumpRenderTree.cpp:
3664         (resetDefaultsToConsistentValues):
3665
3666 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
3667
3668         Reviewed by David Kilzer.
3669
3670         Integrated chromium port building into webkit tools update-webkit and
3671         build-webkit.
3672
3673         https://bugs.webkit.org/show_bug.cgi?id=29749
3674
3675         * Scripts/build-webkit: When --chromium is specified, will build
3676           the chromium port (currently only Mac is supported).
3677         * Scripts/update-webkit: When --chromium is specified, delegates to
3678           update-webkit-chromium.
3679         * Scripts/webkitdirs.pm: Added chromium specific defs.
3680         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
3681           chromium port's dependencies and update its project files.
3682
3683 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3684
3685         Unreviewed.
3686
3687         Add myself to list of committers.
3688
3689         * Scripts/modules/committers.py:
3690
3691 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3692
3693         Reviewed by Darin Adler.
3694
3695         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
3696         https://bugs.webkit.org/show_bug.cgi?id=29771