c18e7d0d1ecd71f44afc2548ffb1e6beaeef0144
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-03-07  Stephanie Lewis <slewis@apple.com>
2
3         Reviewed by Geoff.
4
5         <rdar://problem/5693690> run-webkit-tests swallows STDERR output, including WebCore LEAK messages
6
7         * DumpRenderTree/mac/DumpRenderTree.mm:
8         (dump): push EOF to stderr after every test
9         * Scripts/run-webkit-tests: collect stderr output and print it
10
11 2008-03-07  Steve Falkenburg  <sfalken@apple.com>
12
13         Get pdevenv working with Visual Studio Express.
14         
15         Reviewed by Adam.
16
17         * Scripts/pdevenv:
18
19 2008-03-06  Adele Peterson  <adele@apple.com>
20
21         Reviewed by Darin.
22
23         Updated for testing <rdar://problem/5785895> Implement hasFocus() for HTMLDocument (HTML5)
24
25         * DumpRenderTree/mac/UIDelegate.mm:
26         (-[UIDelegate webViewFocus:]): Remove duplicate code that was also in LayoutTestController::setWindowIsKey
27         (-[UIDelegate webViewUnfocus:]): Added.  In Safari, the default is to focus another window if there is one.
28          To easily test cases where the window is unfocused, I made this just call setWindowIsKey(false).
29
30 2008-03-06  Matt Lilek  <webkit@mattlilek.com>
31
32         Reviewed by Adam Roben.
33
34         Bug 17691: REGRESSION: FindSafari doesn't work
35         http://bugs.webkit.org/show_bug.cgi?id=17691
36
37         Swap my change from r30394 to use the Release libraries instead of Debug
38         since some machines don't have the Debug version.
39
40         * FindSafari/FindSafari.vcproj:
41
42 2008-03-06  Kevin McCullough  <kmccullough@apple.com>
43
44         Reviewed by Sam and Tim.
45
46         <rdar://5631450> Drosera: breakpoint indicators disappear after the
47         script is finished running.
48         - If there is a pre-existing breakpoint on a line when the file is
49         updated we need to redraw it.
50
51         * Drosera/debugger.js:
52
53 2008-03-06  Brady Eidson  <beidson@apple.com>
54
55         Tiger build fix...?
56
57         * DumpRenderTree/mac/WatchdogMac.mm:
58
59 2008-03-06  Brady Eidson  <beidson@apple.com>
60
61         Reviewed by Darin
62
63         Added a cross-platform Watchdog thread to DRT.
64
65         The current watchdog in both DRTWin and DRTMac is Timer based.  Therefore, deadlocks and long running
66         main thread hangs still affect DRT.
67
68         By placing the watchdog on a thread and having DRT "check in" after each test, long-running hangs
69         and true deadlocks can be caught.
70
71         There is one hook for platform specific code.  As I did my development and testing on Mac, and Mac has
72         `sample` available, the Mac implementation of this hook samples the process before it is killed.
73
74         I arbitrarily chose 30 seconds as the timeout for now - this can be tweaked easily if we find a need.
75
76         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
77         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added LINKER_DISPLAYS_MANGLED_NAMES
78
79         * DumpRenderTree/ForwardingHeaders/wtf/Locker.h: Added.
80         * DumpRenderTree/ForwardingHeaders/wtf/Threading.h: Added.
81
82         * DumpRenderTree/Watchdog.cpp: Added.
83         (Watchdog::Watchdog):
84         (Watchdog::~Watchdog):
85         (Watchdog::start):
86         (Watchdog::stop):
87         (Watchdog::checkIn):
88         (Watchdog::setWatchdogInterval):
89         (Watchdog::handleHang):
90         (Watchdog::watchdogThreadStart):
91         (Watchdog::watchdogThread):
92         * DumpRenderTree/Watchdog.h: Added.
93
94         * DumpRenderTree/mac/WatchdogMac.h: Added.
95         * DumpRenderTree/mac/WatchdogMac.mm: Added.
96         (WatchdogMac::handleHang): Sample the process and write it out to a file
97
98         * DumpRenderTree/mac/DumpRenderTree.mm:
99         (dumpRenderTree): Setup and start the watchdog before running any tests
100         (runTest): Checkin with the watchdog after each test
101
102 2008-03-05  Alp Toker  <alp@atoker.com>
103
104         Attempt to get the autotools build working again on the bot with
105         build-webkit.
106
107         Force the use of /bin/bash since we seem to have bash-isms in the
108         configure script right now.
109
110         * Scripts/webkitdirs.pm:
111
112 2008-03-05  Alp Toker  <alp@atoker.com>
113
114         Re-attempt to switch to the autotools build system for GTK+.
115
116         Change scripts to continue when distclean fails.
117
118         * Scripts/webkitdirs.pm:
119
120 2008-03-05  Alp Toker  <alp@atoker.com>
121
122         Force qmake for the GTK+ build until we get the build bot to succeed
123         with autotools (currently dies at make distclean)
124
125         * Scripts/webkitdirs.pm:
126
127 2008-03-04  Alp Toker  <alp@atoker.com>
128
129         Reviewed by Mark Rowe.
130
131         Switch the default GTK+ build system from qmake to autotools.
132
133         qmake can still be used by defining WEBKIT_BUILD_SYSTEM=qmake
134
135         * Scripts/build-webkit:
136         * Scripts/run-launcher:
137         * Scripts/run-webkit-tests:
138         * Scripts/webkitdirs.pm:
139
140 2008-03-04  Sam Weinig  <sam@webkit.org>
141
142         Reviewed by Darin Adler.
143
144         * Scripts/do-webcore-rename: Update renaming plan.
145
146 2008-03-02  Brent Fulgham  <bfulgham@gmail.com>
147
148         Reviewed by Alp Toker.
149
150         Remove some needless LIBS.
151
152         * GNUmakefile.am:
153
154 2008-03-02  Alp Toker  <alp@atoker.com>
155
156         Reviewed by Mark Rowe.
157
158         Split the WebKit GTK+ build out of the WebCore build and change the
159         shared object name to match the package name.
160
161         * GNUmakefile.am:
162
163 2008-03-01  Mark Rowe  <mrowe@apple.com>
164
165         Reviewed by Tim Hatcher.
166
167         Update Xcode configuration to support building debug and release from the mysterious future.
168
169         * DumpRenderTree/mac/Configurations/Base.xcconfig:
170
171 2008-02-29  David Kilzer  <ddkilzer@apple.com>
172
173         Pass the correct configuration switch (--Debug|--Release) to build-testkjs.
174
175         Reviewed by Dan.
176
177         Originally broken in r26838.
178
179         * Scripts/run-javascriptcore-tests: Push configuration switch onto @xcodeArgs
180         not local, unused @args variable.
181
182 2008-02-29  David Kilzer  <ddkilzer@apple.com>
183
184         Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks
185
186         <http://bugs.webkit.org/show_bug.cgi?id=15754>
187
188         Reviewed by Geoff and Darin.
189
190         We were using -[NSFileManager currentDirectoryPath] to get the current working directory,
191         then removing that path from all file:/// URLs in the WebArchive output so these tests
192         would pass no matter where they were run.
193
194         The problem was that -[NSFileManager currentDirectoryPath] resolves symlinks in the
195         current working directory, but the WebArchive does not.  This left the current working
196         directory in all file:/// URLs in the test output, and thus all tests failed, for any
197         developer that used symlinks to get to their WebKit source directory.
198
199         The fix is to look backwards for "/LayoutTests/" in the URL we're passed, and simply
200         remove the current working directory path (no matter what it is) after "file://" but
201         before "/LayoutTests/".  
202
203         * DumpRenderTree/mac/DumpRenderTree.mm:
204         (normalizeWebResourceURL): Removed unused oldURLBase argument.  We now replace the
205         current working directory as described above.
206         (convertWebResourceResponseToDictionary): Remove unused oldURLBase argument.  Update
207         calls to normalizeWebResourceURL().
208         (serializeWebArchiveToXML): Removed now unused cwdURL variable.  Update calls to
209         normalizeWebResourceURL() and convertWebResourceResponseToDictionary().
210
211 2008-02-26  Robin Dunn <robin@alldunn.com>
212
213         Reviewed by Kevin Ollivier.
214
215         Improvements to the wx build script.
216
217         http://bugs.webkit.org/show_bug.cgi?id=17492
218
219         * wx/build-wxwebkit:
220         - Update the Windows dll copying logic to copy dlls inside WebKitLibraries/win
221         - Allow the build script to properly find wxPython includes under different setups
222         - Make sure WX_PREFIX is set to WXWIN (wxWindows dir environment var.) if not defined
223
224 2008-02-26  Timothy Hatcher  <timothy@apple.com>
225
226         Reviewed by Darin Adler.
227
228         * Scripts/build-webkit: Add --universal and --64-bit flags to make building
229         64-bit architectures easy. Combine the two flags to build 4-way universal.
230         * Makefile: Add "64" and "64u" make rules. Fix the universal rule to return
231         non-zero when the build failes.
232
233 2008-02-26  Jessica Kahn  <jess@apple.com>
234
235         Reviewed by Darin.
236
237         * Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment,
238         so that Safari inherits it when launched. Preexisting code in WebKit checks this
239         environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications
240         launched by Safari continue to use the standard system WebKit.
241
242 2008-02-25  Adam Roben  <aroben@apple.com>
243
244         Fix run-webkit-tests after r30394
245
246         * Scripts/webkitdirs.pm: Never append _debug to FindSafari's
247         executable name.
248
249 2008-02-24  Darin Adler  <darin@apple.com>
250
251         * Scripts/do-webcore-rename: Make some updates based on a trial run of
252         the renaming script.
253
254 2008-02-24  Darin Adler  <darin@apple.com>
255
256         * Scripts/do-webcore-rename: More renaming plans.
257
258 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
259
260         Rubber stamped by Darin.
261
262         Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
263         whitespaces introduced in the previous commit.
264
265         * GNUmakefile.am:
266
267 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
268
269         Rubber-stamped by Darin.
270
271         * GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
272
273 2008-02-23  David Kilzer  <ddkilzer@apple.com>
274
275         Please clarify licensing for some files
276         <http://bugs.webkit.org/show_bug.cgi?id=14970>
277
278         Reviewed by Darin.
279
280         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Added
281         copyright statement.  Replaced license with newer Apple BSD-style license.
282         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Ditto.
283         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Ditto.
284         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Ditto.
285         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Ditto.
286         * DumpRenderTree/win/TestNetscapePlugin/main.c: Ditto.
287         * mangleme/LICENSE: Added (LGPL).
288
289 2008-02-22  Anders Carlsson  <andersca@apple.com>
290
291         Reviewed by Adam.
292
293         <rdar://problem/5748781> 
294         https://bugs.webkit.org/show_bug.cgi?id=17413
295         REGRESSION: Latest Nightly doesn't load Java plugin w/Safari 3.1b
296         
297         Copy the Java plug-in over to the new location.
298         
299         * FindSafari/FindSafari.cpp:
300         (_tmain):
301
302 2008-02-22  Anders Carlsson  <andersca@apple.com>
303
304         Reviewed by Adam.
305
306         <rdar://problem/5747325> REGRESSION: HTTP layout tests hang
307         
308         * DumpRenderTree/win/DumpRenderTree.cpp:
309         (runTest):
310         Init the URL request with the correct timeout.
311
312 2008-02-21  Mike Auty  <mike.auty@gmail.com>
313
314         Reviewed by Alp Toker.
315
316         http://bugs.webkit.org/show_bug.cgi?id=17445
317         [GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed"
318
319         GTK+/autotools build system improvements
320
321         The GNUmakefile.am files make use of the LDFLAGS variable to include library
322         additions such as -ljpeg etc.  Unfortunately, if these inclusions aren't made
323         in LIBADD/LDADD variables, then they are mis-ordered during the linking.
324
325         The as-needed flag discards libraries whose functions have not been needed by
326         earlier libraries, which therefore makes the ordering important.
327
328         This moves all -l library inclusion statements from LDFLAGS variables to
329         LIBADD/LDADD variables.
330
331         * GNUmakefile.am:
332
333 2008-02-20  Brent Fulgham  <bfulgham@gmail.com>
334
335         Reviewed by Alp.
336
337         - http://bugs.webkit.org/show_bug.cgi?id=17428
338           Reenable a Windows-based launcher
339
340         This patch reenables the venerable Spinneret application,
341         changing its name to match the other lanch applications.
342
343         * WinLauncher: Added.
344         * WinLauncher/WinLauncher.cpp: Added.
345         (WinLauncherWebHost::updateAddressBar):
346         (WinLauncherWebHost::QueryInterface):
347         (WinLauncherWebHost::AddRef):
348         (WinLauncherWebHost::Release):
349         (resizeSubViews):
350         (_tWinMain):
351         (MyRegisterClass):
352         (InitInstance):
353         (WndProc):
354         (MyEditProc):
355         (About):
356         (loadURL):
357         * WinLauncher/WinLauncher.h: Added.
358         (WinLauncherWebHost::WinLauncherWebHost):
359         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
360         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
361         (WinLauncherWebHost::didFailProvisionalLoadWithError):
362         (WinLauncherWebHost::didCommitLoadForFrame):
363         (WinLauncherWebHost::didReceiveTitle):
364         (WinLauncherWebHost::didReceiveIcon):
365         (WinLauncherWebHost::didFinishLoadForFrame):
366         (WinLauncherWebHost::didFailLoadWithError):
367         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
368         (WinLauncherWebHost::willPerformClientRedirectToURL):
369         (WinLauncherWebHost::didCancelClientRedirectForFrame):
370         (WinLauncherWebHost::willCloseFrame):
371         (WinLauncherWebHost::windowScriptObjectAvailable):
372         * WinLauncher/WinLauncher.ico: Added.
373         * WinLauncher/WinLauncher.rc: Added.
374         * WinLauncher/WinLauncher.vcproj: Added.
375         * WinLauncher/resource.h: Added.
376         * WinLauncher/small.ico: Added.
377         * WinLauncher/stdafx.cpp: Added.
378         * WinLauncher/stdafx.h: Added.
379
380 2008-02-19  Brady Eidson  <beidson@apple.com>
381
382         Reviewed by Geoff
383
384         Fixed a bug in DRT --threaded mode
385
386         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
387         (startJavaScriptThreads): Don't detach the newly created thread.  The later call to stopJavaScriptThreads() tries
388           to pthread_join() each thread that had been created, but you can't join a detached thread!
389
390 2008-02-18  Brady Eidson  <beidson@apple.com>
391
392         Changes by Geoff Garen, Reviewed by Darin
393
394         Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
395
396         DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html
397
398         [WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
399         This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread.  If the lock has leaked,
400         this series of method calls will deadlock.  If things are good, it will complete successfully.
401
402         * DumpRenderTree/mac/ObjCController.m:
403         (runJavaScriptThread):
404         (+[ObjCController isSelectorExcludedFromWebScript:]):
405         (+[ObjCController webScriptNameForSelector:]):
406         (-[ObjCController testValueForKey]):
407
408 2008-02-18  Matt Lilek  <webkit@mattlilek.com>
409
410         Reviewed by Adam.
411
412         Remove FindSafari's Release configuration.
413
414         * FindSafari/FindSafari.vcproj:
415
416 2008-02-15  Adam Roben  <aroben@apple.com>
417
418         Fix a typo that broke the Mac build
419
420         Reviewed by Mark.
421
422         * Scripts/build-webkit:
423
424 2008-02-14  Adam Roben  <aroben@apple.com>
425
426         Turn on cross-document messaging support by default
427
428         Reviewed by Darin.
429
430         * Scripts/build-webkit:
431
432 2008-02-14  Adam Roben  <aroben@apple.com>
433
434         Conditionalize cross-document messaging support
435
436         The cross-document messaging parts of HTML 5 are in flux and we want
437         ports to be able to turn off the support as needed.
438
439         Note that the support is turned off by default right now. A subsequent
440         commit will turn it on by default.
441
442         Reviewed by Darin.
443
444         * Scripts/build-webkit:
445
446 2008-02-14  Darin Adler  <darin@apple.com>
447
448        - fix Windows build
449
450         * DumpRenderTree/win/UIDelegate.cpp:
451         (UIDelegate::setStatusText): Update parameter types to match declaration.
452
453 2008-02-14  Oliver Hunt  <oliver@apple.com>
454
455         Reviewed by Geoff G and Weinig.
456
457         Add ability for DRT to report tests setting the status text.
458
459         * DumpRenderTree/LayoutTestController.cpp:
460         (LayoutTestController::LayoutTestController):
461         (dumpStatusCallbacksCallback):
462         (LayoutTestController::staticFunctions):
463         * DumpRenderTree/LayoutTestController.h:
464         * DumpRenderTree/mac/UIDelegate.mm:
465         (-[UIDelegate webView:setStatusText:]):
466         * DumpRenderTree/win/UIDelegate.cpp:
467         * DumpRenderTree/win/UIDelegate.h:
468
469 2008-02-13  Adam Roben  <aroben@apple.com>
470
471         Windows build fix
472
473         * DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.
474
475 2008-02-13  Adam Roben  <aroben@apple.com>
476
477         Windows/GTK+ build fix
478
479         * DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to
480         get isnan.
481
482 2008-02-13  Brady Eidson  <beidson@apple.com>
483
484         Reviewed by Darin Adler
485
486         Add some much needed Database support to DRT
487
488         * DumpRenderTree/LayoutTestController.cpp:
489         (LayoutTestController::LayoutTestController):
490         (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to
491           databases are called
492         (clearAllDatabasesCallback): Allow a test to delete all databases
493         (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get
494         (LayoutTestController::staticFunctions):
495
496         * DumpRenderTree/LayoutTestController.h:
497         (LayoutTestController::dumpDatabaseCallbacks):
498         (LayoutTestController::setDumpDatabaseCallbacks):
499
500         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
501         (LayoutTestController::clearAllDatabases):
502         (LayoutTestController::setDatabaseQuota):
503
504         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
505         (LayoutTestController::clearAllDatabases): Stubbed out
506         (LayoutTestController::setDatabaseQuota): Ditto
507         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
508         (LayoutTestController::clearAllDatabases): Stubbed out with error message
509         (LayoutTestController::setDatabaseQuota): Ditto
510
511         * DumpRenderTree/mac/UIDelegate.mm:
512         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a
513           message with details about the event then return a 5mb quota like before
514
515
516 2008-02-12  Steve Falkenburg  <sfalken@apple.com>
517
518         Changes to support merged MIDL output.
519
520         All COM interfaces are now generated to WebKit.h.
521
522         Reviewed by Sam, Ada.
523
524         * Drosera/win/BaseDelegate.h:
525         * Drosera/win/DebuggerClient.cpp:
526         * Drosera/win/DebuggerDocumentPlatform.cpp:
527         * Drosera/win/Drosera.cpp:
528         * Drosera/win/ServerConnection.cpp:
529         * Drosera/win/ServerConnection.h:
530         * DumpRenderTree/win/DumpRenderTree.cpp:
531         * DumpRenderTree/win/EditingDelegate.h:
532         * DumpRenderTree/win/EventSender.cpp:
533         * DumpRenderTree/win/FrameLoadDelegate.cpp:
534         * DumpRenderTree/win/FrameLoadDelegate.h:
535         * DumpRenderTree/win/GCControllerWin.cpp:
536         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
537         * DumpRenderTree/win/PolicyDelegate.h:
538         * DumpRenderTree/win/ResourceLoadDelegate.h:
539         * DumpRenderTree/win/UIDelegate.cpp:
540         * DumpRenderTree/win/UIDelegate.h:
541         * DumpRenderTree/win/WorkQueueItemWin.cpp:
542
543 2008-02-10  Dan Bernstein  <mitz@apple.com>
544
545         Reviewed by Oliver Hunt.
546
547         - fix a memory leak
548
549         * DumpRenderTree/cg/ImageDiffCG.cpp:
550         (getDifferenceBitmap): Use a static CFMutableData instead of allocating
551         and leaking the buffer each time.
552
553 2008-02-07  Adam Roben  <aroben@apple.com>
554
555         Fix error in bisect-builds when responding "broken" for the first
556         build
557
558         Reviewed by Dave Kilzer.
559
560         * Scripts/bisect-builds: Only try to test the build if the nightly
561         info for the current index has not been deleted.
562
563 2008-02-07  Geoffrey Garen  <ggaren@apple.com>
564
565         Reviewed by Alexey Proskuryakov.
566
567         Fixed two minor typos in the --root option, to get it working.
568
569         * Scripts/run-sunspider:
570             1. Actually assign the function argument to our local variable.
571             2. Actually set the $root variable, so we don't try to build later.
572
573 2008-02-05  Oliver Hunt  <oliver@apple.com>
574
575         RS=Eric.
576
577         Re-enable foreignObject by default as it is needed for a number of non-fO
578         related SVG tests and none of the old known crashes occur anymore.
579
580         * Scripts/build-webkit:
581
582 2008-02-05  Steve Falkenburg  <sfalken@apple.com>
583
584         Build fix.  Don't override intermediate directory.
585
586         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
587
588 2008-02-05  Holger Hans Peter Freyther  <zecke@selfish.org>
589
590         Build fix for Windows. willCloseFrame is a pure virtual and we are
591         forced to have an implementation.
592         
593         This partially reverts r30014.
594
595         * DumpRenderTree/win/FrameLoadDelegate.cpp:
596         (FrameLoadDelegate::willCloseFrame):
597         * DumpRenderTree/win/FrameLoadDelegate.h:
598
599 2008-02-05  Nikolas Zimmermann  <zimmermann@kde.org>
600
601         Reviewed by Holger.
602
603         Don't build wrapper for SVGTestCase.js (special file for svg/dynamic-updates)
604
605         * Scripts/make-js-test-wrappers:
606
607 2008-02-05  Holger Freyther  <zecke@selfish.org>
608
609         Reviewed by Darin.
610
611         In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
612         the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
613         depends on the order the tests are executed.
614         
615         Propose to remove willCloseFrame and didlCearWindowObject output from the
616         FrameLoadDelegate and update the test results. The output of didClearWindowObject
617         is not interesting for any of the current tests and we have other ways to find
618         out if a frame was closed or not.
619
620         * DumpRenderTree/mac/FrameLoadDelegate.mm:
621         * DumpRenderTree/win/FrameLoadDelegate.cpp:
622         (FrameLoadDelegate::didClearWindowObject):
623         * DumpRenderTree/win/FrameLoadDelegate.h:
624
625 2008-02-04  Mark Rowe  <mrowe@apple.com>
626
627         Reviewed by Oliver Hunt.
628
629         Workaround for http://bugs.webkit.org/show_bug.cgi?id=16842
630         Bug 16842: Hang in DRT in leaks mode due to signal handler doing unsafe things
631
632         Don't install the signal handler unless we are running the pixel tests.
633         It is currently only used to restore the color profile, but by catching
634         signals we can trigger a deadlock in DRT while running leak tests.
635         The deadlock is tracked by http://bugs.webkit.org/show_bug.cgi?id=16842,
636         and a more complete fix will need to be developed to address this for
637         pixel tests as well.
638
639         * DumpRenderTree/mac/DumpRenderTree.mm:
640         (dumpRenderTree):
641
642 2008-02-04  Mark Rowe  <mrowe@apple.com>
643
644        Gtk qmake build fix.
645
646         * Scripts/webkitdirs.pm:  Fix perl's complaint about an odd number of elements in anonymous hash.
647
648 2008-02-04  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
649
650         Reviewed by Alp Toker and Mark Rowe.
651
652         http://bugs.webkit.org/show_bug.cgi?id=16618
653         [GTK] build-webkit and run-webkit-tests autootools support
654
655         * Scripts/build-webkit: added --database and --icon-database options
656         * Scripts/run-launcher:
657         * Scripts/run-webkit-tests:
658         * Scripts/webkitdirs.pm:
659
660 2008-02-04  Oliver Hunt  <oliver@apple.com>
661
662         Reviewed by Steve F.
663
664         Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT
665
666         Implement required DRT functionality to allow majority of Drag and Drop testcases to work.
667         Issues include:
668           * Uses Sleep() to implement leapForward reliably.
669           * 3 DND tests still fail for reasons that i have not yet determined
670           * Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain 
671
672         * DumpRenderTree/win/EventSender.cpp:
673         (leapForwardCallback):
674         (mouseDownCallback):
675         (doMouseUp):
676         (mouseUpCallback):
677         (doMouseMove):
678         (mouseMoveToCallback):
679           Minor updates to these functions to handle the different message queue structure.
680
681         (replaySavedEvents):
682           More complicated now.  Where possible we just use the old while-loop model of execution,
683           but when leapForward has been used we have to jump through some hoops and set up an 
684           inner event loop so that we can ensure messages get the correct time stamp.
685
686         * DumpRenderTree/win/UIDelegate.cpp:
687         (UIDelegate::doDragDrop):
688           Call replaySavedEvents directly to force synchronous handling of drag and drop.
689
690 2008-02-04  Rodney Dawes  <dobey@wayofthemonkey.com>
691
692         Reviewed by Alp Toker and Mark Rowe.
693
694         Fix http://bugs.webkit.org/show_bug.cgi?id=17175.
695         Bug 17175: Use of C++ compiler flags in CFLAGS
696
697         * GNUmakefile.am: Use global_cxxflags as well as global_cflags in CXXFLAGS.
698
699 2008-02-04  Darin Adler  <darin@apple.com>
700
701         Reviewed by Geoff.
702
703         * Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast
704         and svg subdirectories. Added some more exceptions for the benefit of the fast/dom
705         subdirectory.
706
707 2008-02-04  Adam Roben  <aroben@apple.com>
708
709         Windows Apple-only build fix
710
711         * DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include
712         directory.
713
714 2008-02-04  Alp Toker  <alp@atoker.com>
715
716         Rubber-stamped by Mark Rowe.
717
718         Remove all trailing whitespace in the GTK+ port and related
719         components.
720
721         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
722         * DumpRenderTree/gtk/GCControllerGtk.cpp:
723         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
724         * GNUmakefile.am:
725
726 2008-02-01  Eric Seidel  <eric@webkit.org>
727
728         Reviewed by Oliver.
729
730         Also search LayoutTests/svg for js-based tests.
731
732         * Scripts/make-js-test-wrappers:
733
734 2008-01-31  Alp Toker  <alp@atoker.com>
735
736         Rubber-stamped by Adam Roben.
737
738         http://bugs.webkit.org/show_bug.cgi?id=17006
739         [GTK] Header path should be webkit/webkit.h
740
741         Move the GTK+ API sources as needed and update the build systems.
742
743         * DumpRenderTree/gtk/DumpRenderTree.cpp:
744         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
745         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
746         * GNUmakefile.am:
747         * GtkLauncher/main.c:
748
749 2008-01-30  Stephanie  <slewis@apple.com>
750
751         Reviewed by Geoff.
752
753         Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
754
755         * Scripts/run-webkit-tests:
756
757 2008-01-30  Alexey Proskuryakov  <ap@webkit.org>
758
759         Reviewed by Adam Roben.
760
761         One more debug (external) fix.
762
763         * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
764         and Debug configurations. 
765
766 2008-01-29  Geoffrey Garen  <ggaren@apple.com>
767
768         Reviewed by Sam Weinig. Sam Weinig.
769         
770         Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
771         fails when run after fast/dom/Window/window-property-shadowing.html (16902)
772
773         Modified our policy delegates not to output window.name. Since a
774         previous test may have explicitly set window.name, we can't rely on its
775         implicit value in test results.
776
777         * DumpRenderTree/mac/PolicyDelegate.mm:
778         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
779
780         * DumpRenderTree/win/PolicyDelegate.cpp:
781         (PolicyDelegate::decidePolicyForNavigationAction):
782
783 2008-01-29  Mark Rowe  <mrowe@apple.com>
784
785         Reviewed by Tim Hatcher.
786
787         <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
788
789         * Scripts/build-webkit: Copy SQLite static library and headers into the build directory.
790
791 2008-01-29  David Kilzer  <ddkilzer@apple.com>
792
793         Refactor ChangeLog path code
794
795         Reviewed by Adam.
796
797         * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
798         duplicate code in another foreach() loop.
799
800 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
801
802         Reviewed by Darin.
803
804         <rdar://problem/5710692> All storage tests fail/crash
805
806         * DumpRenderTree/mac/UIDelegate.mm:
807         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an
808         arbitrary quota of 5 megabytes.
809
810         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
811         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
812         Removed unused (I think) code.
813         
814         * DumpRenderTree/win/UIDelegate.cpp:
815         (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported.
816         (UIDelegate::webViewPainted): A stub implementation.
817         (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
818         * DumpRenderTree/win/UIDelegate.h:
819
820 2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
821
822         GTK+ DRT build fix for breakage introduced in r29822.
823
824         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
825         (LayoutTestController::setPersistentUserStyleSheetLocation):
826         (LayoutTestController::clearPersistentUserStyleSheet):
827
828 2008-01-27  Dan Bernstein  <mitz@apple.com>
829
830         Reviewed by Darin Adler.
831
832         - add support for directory prologues and epilogues to run-webkit-tests
833         - allow setting a persistent user style sheet in DumpRenderTree
834         - activate the WebKit Layout Tests font in Windows DumpRenderTree
835
836         * DumpRenderTree/LayoutTestController.cpp:
837         (clearPersistentUserStyleSheetCallback): Added.
838         (setPersistentUserStyleSheetLocationCallback): Added.
839         (LayoutTestController::staticFunctions): Added.
840         clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
841         * DumpRenderTree/LayoutTestController.h:
842         * DumpRenderTree/mac/DumpRenderTree.mm:
843         (setPersistentUserStyleSheetLocation): Added.
844         (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
845         to the set of things this function resets. Now it either disables the
846         user style sheet or sets it to the persistent user style sheet and
847         enables it.
848         * DumpRenderTree/mac/DumpRenderTreeMac.h:
849         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
850         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
851         (LayoutTestController::clearPersistentUserStyleSheet): Added.
852         * DumpRenderTree/win/DumpRenderTree.cpp:
853         (setPersistentUserStyleSheetLocation): Added.
854         (initialize): Added the WebKit Layout Tests font to the set of fonts to
855         install.
856         (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
857         * DumpRenderTree/win/DumpRenderTreeWin.h:
858         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
859         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
860         (LayoutTestController::clearPersistentUserStyleSheet): Added.
861         * Scripts/run-webkit-tests: Changed to look for, and if found process in
862         DumpRenderTree, files named run-webkit-tests-prologue.html and
863         run-webkit-tests-epilogue.html in the resources subdirectory of any
864         test directory and platform test results directory. The prologues are
865         processed before the first test from the directory (and its
866         subdirectories) is run, and the epilogues are processed after the last
867         test from the directory is run. Platform-specific prologues and
868         epilogues are processed in order of specificity.
869
870 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
871
872         Reviewed by Mark Rowe.
873
874         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
875
876         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
877         (matching Mac DRT).
878         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
879
880 2008-01-24  Sam Weinig  <sam@webkit.org>
881
882         Reviewed by Ada Chan.
883
884         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
885
886         - Adds simplified UndoManager to windows DRT to allow testing the
887           undo/redo code paths in WebCore and WebKit.  This is a temporary
888           solution to an issue that should eventually be solved by having a
889           shared UndoManager in WebKit.
890
891         * DumpRenderTree/win/DumpRenderTree.cpp:
892         (runTest):
893         * DumpRenderTree/win/UIDelegate.cpp:
894         (DRTUndoObject::DRTUndoObject):
895         (DRTUndoObject::invoke):
896         (DRTUndoStack::~DRTUndoStack):
897         (DRTUndoStack::isEmpty):
898         (DRTUndoStack::clear):
899         (DRTUndoStack::push):
900         (DRTUndoStack::pop):
901         (DRTUndoManager::canRedo):
902         (DRTUndoManager::canUndo):
903         (DRTUndoManager::DRTUndoManager):
904         (DRTUndoManager::removeAllActions):
905         (DRTUndoManager::registerUndoWithTarget):
906         (DRTUndoManager::redo):
907         (DRTUndoManager::undo):
908         (UIDelegate::UIDelegate):
909         (UIDelegate::resetUndoManager):
910         (UIDelegate::registerUndoWithTarget):
911         (UIDelegate::removeAllActionsWithTarget):
912         (UIDelegate::setActionTitle):
913         (UIDelegate::undo):
914         (UIDelegate::redo):
915         (UIDelegate::canUndo):
916         (UIDelegate::canRedo):
917         * DumpRenderTree/win/UIDelegate.h:
918
919 2008-01-23  Adam Roben  <aroben@apple.com>
920
921         Allow directories containing ChangeLogs to be passed to
922         resolve-ChangeLogs
923
924         Reviewed by David Kilzer.
925
926         * Scripts/resolve-ChangeLogs:
927         (sub findChangeLog): Return a ChangeLog contained within the specified
928         directory if one exists.
929
930 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
931
932         <rdar://problem/5698732> Copyright strings should include 2008
933
934         Reviewed by Sam.
935
936         * Drosera/win/Drosera.vcproj/Drosera.rc:
937         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
938
939 2008-01-23  Alp Toker  <alp@atoker.com>
940
941         Rubber-stamped by Mark Rowe.
942
943         Remove whitespace after -I in automake include lists.
944
945         * GNUmakefile.am:
946
947 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
948
949         Reviewed by Lars Knoll <lars@trolltech.com>.
950
951         Reworked the JavaScriptCore Qt bindings:
952         
953         * Update JS DRT controller for Qt JS binding changes.
954         There were two functions that needed some changes
955         so that the layout tests would work, so this makes
956         a few tests pass again.
957         
958         * Bump the timeout for layout tests up to 11s.
959         At least some tests have an internal timeout of
960         10 seconds, so make the waitUntilDone approach
961         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
962         is one of these - now the failure message is more
963         accurate.
964         
965
966         * DumpRenderTree/qt/jsobjects.cpp:
967         (LayoutTestController::waitUntilDone):
968         * DumpRenderTree/qt/jsobjects.h:
969
970 2008-01-22  Anders Carlsson  <andersca@apple.com>
971
972         Reviewed by Darin and Adam.
973
974         <rdar://problem/5688975>
975         div element on microsoft site has wrong left offset.
976         
977         Add new method for testing the return vale of NPN_GetProperty.
978         
979         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
980         (pluginInvoke):
981
982 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
983
984         Reviewed by Adam Roben.
985
986         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
987
988         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
989
990 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
991
992         Reviewed by Alp Toker.
993
994         http://bugs.webkit.org/show_bug.cgi?id=16955
995         Get errors when cross-compile webkit-gtk
996
997         * GNUmakefile.am: Removed ICU_CFLAGS 
998
999 2008-01-21  Darin Adler  <darin@apple.com>
1000
1001         Reviewed by Mitz and Adam.
1002
1003         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
1004         sorting speed by doing all sort criteria in a single pass instead of three sorts.
1005
1006 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
1007
1008         Reviewed by Holger.
1009
1010         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
1011         
1012         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
1013         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
1014         and make the return value depend on whether we successfully determined a focusable
1015         node or not.
1016         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
1017         if we could not handle the focus chain ourselves.
1018         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
1019         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
1020         used to control the situation of stepping out of the focus chain inside the page.
1021         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
1022         The layout tests expect this to be disabled but for the user it seems sensible to have it
1023         on by default, hence the default in qwebsettings.cpp
1024         
1025
1026         * DumpRenderTree/qt/DumpRenderTree.cpp:
1027         (WebCore::WebPage::WebPage):
1028
1029 2008-01-19  Mark Rowe  <mrowe@apple.com>
1030
1031         Reviewed by Alp Toker.
1032
1033         Allow the --http flag to run-webkit-tests to override
1034         the default behaviour of disabling HTTP tests for Qt,
1035         Gtk and Wx.
1036
1037         * Scripts/run-webkit-tests:
1038
1039 2008-01-19  David Kilzer  <ddkilzer@apple.com>
1040
1041         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
1042
1043         Reviewed by Darin.
1044
1045         We now touch a check-for-global-initializers.timestamp file in
1046         the TARGET_TEMP_DIR directory to determine when new object files
1047         have been compiled and thus need to be checked.  If the timestamp
1048         file doesn't exist, all object files will be checked.
1049
1050         Previously the modification time of the "executable" (the
1051         framework binary, e.g., WebKit.framework/WebKit) was used, but
1052         since this was the last file modified at the end of the compile
1053         phase, no object files would ever get checked!
1054
1055         Also added JSCustomSQLTransactionCallback.o to the list of files
1056         since it has static initializers in Debug builds of WebCore.
1057
1058         * Scripts/check-for-global-initializers:
1059
1060 2008-01-18  Adam Roben  <aroben@apple.com>
1061
1062         Build fix
1063
1064         * Scripts/build-webkit:
1065
1066 2008-01-18  Beth Dakin  <bdakin@apple.com>
1067
1068         Reviewed by Oliver.
1069
1070         Update build-webkit to account for foreign-object being disabled by 
1071         default.
1072
1073         * Scripts/build-webkit:
1074
1075 2008-01-18  Adam Roben  <aroben@apple.com>
1076
1077         Updated for method renames
1078
1079         Reviewed by Adele.
1080
1081         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1082         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1083         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1084         (LayoutTestController::setMainFrameIsFirstResponder):
1085         (LayoutTestController::setWindowIsKey):
1086         * DumpRenderTree/mac/UIDelegate.mm:
1087         (-[UIDelegate webViewFocus:]):
1088         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1089         (FrameLoadDelegate::didCommitLoadForFrame):
1090
1091 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
1092
1093         Reviewed by Adam Roben.
1094
1095         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
1096         between DRT and TestNetscapePlugin.
1097
1098         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
1099         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
1100
1101 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
1102
1103         Reviewed by Holger.
1104
1105         Fix fast/dom/Window/window-resize.html
1106         
1107         In DRT connect the page's geometryChangeRequest signal to a slot that
1108         sets the geometry of the view widget.
1109         
1110
1111         * DumpRenderTree/qt/DumpRenderTree.cpp:
1112         (WebCore::WebPage::setViewGeometry):
1113         (WebCore::WebPage::WebPage):
1114
1115 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
1116
1117         Build fix.
1118
1119         * Drosera/DroseraWin.make:
1120
1121 2008-01-17  Darin Adler  <darin@apple.com>
1122
1123         * Scripts/run-webkit-tests: Fixed a bug number.
1124
1125 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
1126
1127         Reviewed by Adam Roben.
1128
1129         http://bugs.webkit.org/show_bug.cgi?id=16908
1130         run-webkit-tests complains about missing FindSafari.exe
1131
1132         * Scripts/webkitdirs.pm: Append _debug as appropriate.
1133
1134 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
1135
1136         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
1137         
1138         Rubber-stamped by Jon Honeycutt.
1139
1140         * DumpRenderTree/win/DumpRenderTree.vcproj:
1141
1142 2008-01-16  Alp Toker  <alp@atoker.com>
1143
1144         Reviewed by Mark Rowe.
1145
1146         http://bugs.webkit.org/show_bug.cgi?id=16218
1147         [GTK] API: Should this entry point be called go_back rather than go_backward?
1148
1149         Track back/forward API changes in the tools.
1150
1151         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1152         (BackForwardItem::invoke):
1153         * GtkLauncher/main.c:
1154         (go_back_cb):
1155
1156 2008-01-16  Adam Roben  <aroben@apple.com>
1157
1158         Windows build fix after r29488
1159
1160         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1161         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
1162         expects to find the plugin.
1163
1164 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
1165
1166         Reviewed by Sam Weinig.
1167         
1168         Fixed the waitUntilDone watchdog timer -- the old code never added the
1169         timer to the run loop, so it didn't do anything.
1170
1171         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1172         (LayoutTestController::setWaitToDump):
1173         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1174         (LayoutTestController::setWaitToDump):
1175
1176 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
1177
1178         Use shared vsprops for most vcproj properties.
1179         
1180         Reviewed by Darin.
1181
1182         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1183         * DumpRenderTree/win/DumpRenderTree.vcproj:
1184         * DumpRenderTree/win/ImageDiff.vcproj:
1185         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1186         * FindSafari/FindSafari.vcproj:
1187
1188 2008-01-14  Stephanie  <slewis@apple.com>
1189
1190        Reviewed by NOBODY.
1191   
1192        revert accidental character.
1193
1194        * Scripts/run-webkit-tests:
1195
1196 2008-01-14  Stephanie  <slewis@apple.com>
1197
1198         RS=Oliver
1199
1200         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
1201
1202         * Scripts/run-webkit-tests:
1203
1204 2008-01-14  Darin Adler  <darin@apple.com>
1205
1206         * Scripts/do-webcore-rename: Queue up another rename.
1207
1208 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1209
1210         Reviewed by Darin.
1211
1212         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
1213         the tests were ran.
1214         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
1215
1216         * Scripts/run-webkit-tests:
1217
1218 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1219
1220         Reviewed by Darin.
1221
1222         * Randomize tests array to spot test cases where the results depends on the order
1223         the tests are ran.
1224         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
1225
1226         * Scripts/run-webkit-tests:
1227
1228 2008-01-14  Darin Adler  <darin@apple.com>
1229
1230         * Scripts/run-webkit-tests: More ignore list tweaking.
1231
1232 2008-01-14  Darin Adler  <darin@apple.com>
1233
1234         * Scripts/run-webkit-tests: Add another leak to the ignore list.
1235
1236 2008-01-14  Dan Bernstein  <mitz@apple.com>
1237
1238         Reviewed by Adam Roben.
1239
1240         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
1241           build bots
1242
1243         * DumpRenderTree/win/DumpRenderTree.cpp:
1244         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
1245
1246 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
1247
1248         Share common files across projects.
1249         
1250         Unify vsprops files
1251         Debug:          common.vsprops, debug.vsprops
1252         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
1253         Release:        common.vsprops, release.vsprops
1254         
1255         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
1256         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
1257
1258         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
1259
1260         Reviewed by Adam Roben.
1261
1262         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1263         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
1264         * Drosera/win/Drosera.vcproj/VERSION: Removed.
1265         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
1266         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
1267         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
1268         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
1269         * DumpRenderTree/win/DumpRenderTree.vcproj:
1270         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1271         * DumpRenderTree/win/debug.vsprops: Removed.
1272         * DumpRenderTree/win/debug_internal.vsprops: Removed.
1273         * DumpRenderTree/win/release.vsprops: Removed.
1274
1275 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
1276
1277         Reviewed by Maciej.
1278
1279         - http://bugs.webkit.org/show_bug.cgi?id=16314
1280           Script to launch Drosera
1281
1282         * Scripts/gdb-drosera: Added.
1283         * Scripts/run-drosera: Added.
1284         * Scripts/run-drosera-nightly.cmd: Added.
1285         * Scripts/webkitdirs.pm: Added runDrosera function.
1286
1287 2008-01-13  Dan Bernstein  <mitz@apple.com>
1288
1289         - fix breakage due to last-minute change
1290
1291         * DumpRenderTree/win/DumpRenderTree.cpp:
1292         (runTest): Declare the loop variable.
1293
1294 2008-01-13  Dan Bernstein  <mitz@apple.com>
1295
1296         Reviewed by Adam Roben.
1297
1298         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
1299
1300         * DumpRenderTree/win/DumpRenderTree.cpp:
1301         (DumpRenderTreeWndProc):
1302         (initialize):
1303         (dumpBackForwardList):
1304         (dumpBackForwardListForAllWindows):
1305         (dump):
1306         (resetWebViewToConsistentStateBeforeTesting): Factored out of
1307         runTest().
1308         (runTest):
1309         (allWindows): Added. Returns a vector of all open windows.
1310         (windowToWebViewMap): Added. Returns a map from open windows to their
1311         WebViews.
1312         (createWebViewAndOffscreenWindow): Factored out of main() to be
1313         reusable for creating extra windows.
1314         (main):
1315         * DumpRenderTree/win/DumpRenderTreeWin.h:
1316         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1317         (LayoutTestController::windowCount): Implemented.
1318         * DumpRenderTree/win/UIDelegate.cpp:
1319         (UIDelegate::createWebViewWithRequest): Implemented.
1320         (UIDelegate::webViewClose): Implemented.
1321         * DumpRenderTree/win/UIDelegate.h:
1322
1323 2008-01-12  Alp Toker  <alp@atoker.com>
1324
1325         Reviewed by Mark Rowe.
1326
1327         Hide non-public symbols in GTK+/autotools release builds.
1328
1329         * GNUmakefile.am:
1330
1331 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1332
1333         Reviewed by Ap.
1334
1335         * Make launching of the WebKit httpd work on GNU/Debian/Linux
1336         
1337         The configuration of Apache2 and installation does not depend on
1338         the kernel but on the distribution policy. Make launching of httpd
1339         work for Debian derived distributions.
1340
1341         * Scripts/run-webkit-httpd:
1342         * Scripts/run-webkit-tests:
1343         * Scripts/webkitdirs.pm:
1344
1345 2008-01-12  Mark Rowe  <mrowe@apple.com>
1346
1347         Reviewed by Maciej Stachowiak.
1348
1349         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
1350
1351         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
1352         match the callers expectations that it can take ownership of the string.
1353
1354 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
1355
1356         Reviewed by Adam Roben.
1357
1358         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
1359
1360         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
1361         as these are only posted because the test window is not a normal visible one, and
1362         they confuse drag&drop machinery.
1363
1364 2008-01-11  Adam Roben  <aroben@apple.com>
1365
1366         Fix a crash when pathToLocalResource fails and a leak
1367
1368         Reviewed by Darin.
1369
1370         * DumpRenderTree/LayoutTestController.cpp:
1371         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
1372         sure not to pass null to JSValueMakeString.
1373         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1374         (LayoutTestController::pathToLocalResource): Print an error message if
1375         the conversion fails so it's clear what happened.
1376
1377 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
1378
1379         Reviewed by John Sullivan.
1380
1381         * DumpRenderTree/mac/GCControllerMac.mm:
1382         (GCController::collectOnAlternateThread): Updated for name change.
1383
1384 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
1385
1386         wx build fix. Don't build dftables any longer since it's now a Perl
1387         script.
1388
1389         * wx/build-wxwebkit:
1390
1391 2008-01-10  Sam Weinig  <sam@webkit.org>
1392
1393         Reviewed by Anders Carlsson.
1394
1395         Make DRT track open windows instead of allocated windows so that
1396         we can avoid ASSERTION due to late deallocs out of our control.
1397
1398         * DumpRenderTree/mac/DumpRenderTree.mm:
1399         (dumpBackForwardListForAllWindows):
1400         (runTest):
1401         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1402         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1403         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1404         (+[DumpRenderTreeWindow openWindows]):
1405         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1406         (-[DumpRenderTreeWindow close]):
1407         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1408         (LayoutTestController::windowCount):
1409
1410 2008-01-10  Ada Chan  <adachan@apple.com>
1411
1412         Meta key is not the same as Alt key on windows.
1413
1414         Reviewed by Darin.
1415
1416         * DumpRenderTree/win/EventSender.cpp:
1417         (keyDownCallback):
1418
1419 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
1420
1421         Reviewed by Darin, Sam and Adam.
1422
1423         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
1424         link in gmail message displays JavaScript alert falsely complaining
1425         about pop-up blocking.
1426         - Added the ability to enable the pop-up blocker via the
1427         LayoutTestController.
1428
1429         * DumpRenderTree/LayoutTestController.cpp:
1430         (setPopupBlockingEnabledCallback):
1431         (LayoutTestController::staticFunctions):
1432         * DumpRenderTree/LayoutTestController.h:
1433         * DumpRenderTree/mac/DumpRenderTree.mm:
1434         (setDefaultsToConsistentValuesForTesting):
1435         (resetWebViewToConsistentStateBeforeTesting):
1436         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1437         (LayoutTestController::setPopupBlockingEnabled):
1438
1439 2008-01-10  Lars Knoll  <lars@trolltech.com>
1440
1441         Reviewed by Simon.
1442
1443         rename QWebPageHistory to QWebHistory.
1444         
1445
1446         * DumpRenderTree/qt/jsobjects.cpp:
1447
1448 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
1449
1450         Reviewed by Darin.
1451         
1452         - add some more renames, adjust some
1453
1454         * Scripts/do-webcore-rename:
1455
1456 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1457
1458         Reviewed by Oliver.
1459
1460         Enable SVG Fonts support by default.
1461
1462         * Scripts/build-webkit:
1463
1464 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1465
1466         Reviewed by Adam.
1467
1468         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
1469         DRT doesn't handle platform specific pixel test results correctly.
1470
1471         <test>-expected.txt files and <test>-expected.png files may now live
1472         in different directories (ie. a cross-platform <test>-expected.txt file
1473         and a platform-specific <test>-expected.png file).
1474
1475         * Scripts/run-webkit-tests:
1476
1477 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
1478
1479         Reviewed by Darin.
1480
1481         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
1482         DRT did not correctly handle printing the '\0' char.  Now it does.
1483
1484         * DumpRenderTree/win/DumpRenderTree.cpp:
1485         (dumpFramesAsText):
1486         (dump):
1487
1488 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
1489
1490         Reviewed by Lars.
1491
1492         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
1493         
1494
1495         * DumpRenderTree/qt/main.cpp:
1496         * DumpRenderTree/qt/testplugin.cpp:
1497         * DumpRenderTree/qt/testplugin.h:
1498
1499 2008-01-05  Mark Rowe  <mrowe@apple.com>
1500
1501         Reviewed by Alp Toker.
1502
1503         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
1504
1505         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1506         (processWork): Process pending work.
1507         (webViewLoadFinished): Schedule processing of pending work.
1508         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
1509
1510 2008-01-05  Darin Adler  <darin@apple.com>
1511
1512         * Scripts/do-webcore-rename: Some more renaming plans.
1513
1514 2008-01-04  Alice Liu  <alice.liu@apple.com>
1515
1516         Reviewed by Alexey and Darin.
1517
1518         Adding "home" and "end" to DRT's keydown since
1519         DOM key events can't handle keyIdentifiers at this point. 
1520
1521         * DumpRenderTree/mac/EventSendingController.mm:
1522         (-[EventSendingController keyDown:withModifiers:]):
1523         * DumpRenderTree/win/EventSender.cpp:
1524         (keyDownCallback):
1525
1526 2008-01-04  Lars Knoll  <lars@trolltech.com>
1527
1528         Reviewed by Simon.
1529
1530         fix DRT after the changes to QWebPage.
1531         
1532         The great thing is that we actually don't have
1533         any regressions from the QWebPage change :)
1534         
1535
1536         * DumpRenderTree/qt/DumpRenderTree.cpp:
1537         (WebCore::DumpRenderTree::DumpRenderTree):
1538
1539 2008-01-04  Lars Knoll  <lars@trolltech.com>
1540
1541         Reviewed by Simon.
1542
1543         make QWebPage a QObject and get things to compile.
1544         
1545         Nothing works currently though.
1546         
1547
1548         * DumpRenderTree/qt/DumpRenderTree.cpp:
1549         (WebCore::DumpRenderTree::DumpRenderTree):
1550
1551 2008-01-04  Lars Knoll  <lars@trolltech.com>
1552
1553         Reviewed by Simon.
1554
1555         take a QString as identifier in QWebFrame::addToJSWindowObject.
1556
1557         * DumpRenderTree/qt/DumpRenderTree.cpp:
1558         (WebCore::DumpRenderTree::initJSObjects):
1559
1560 2008-01-04  Alp Toker  <alp@atoker.com>
1561
1562         GTK+ DRT build fix for breakage introduced in r29149.
1563
1564         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1565         (LayoutTestController::execCommand):
1566
1567 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1568
1569         Reviewed by Darin.
1570
1571         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
1572
1573         Added layoutTestController.execCommand to access editor commands that are not available
1574         via document.execCommand.
1575
1576         * DumpRenderTree/LayoutTestController.cpp:
1577         (execCommandCallback):
1578         (LayoutTestController::staticFunctions):
1579         * DumpRenderTree/LayoutTestController.h:
1580         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1581         (LayoutTestController::execCommand):
1582         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1583         (LayoutTestController::queueLoad):
1584         (LayoutTestController::execCommand):
1585
1586 2008-01-03  Alice Liu  <alice.liu@apple.com>
1587
1588         Reviewed by Darin, Mitz.
1589
1590         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
1591
1592         the clickcount should not increase if the last click was at a different location.  it's a new click.
1593
1594         * DumpRenderTree/mac/DumpRenderTree.mm:
1595         (runTest):
1596         * DumpRenderTree/mac/EventSendingController.h:
1597         * DumpRenderTree/mac/EventSendingController.mm:
1598         (-[EventSendingController mouseDown]):
1599         (-[EventSendingController mouseUp]):
1600
1601 2008-01-03  Darin Adler  <darin@apple.com>
1602
1603         Reviewed by Adam.
1604
1605         * Scripts/update-webkit: Make this work a little better for the people at Apple
1606         who have a directory named Internal.
1607
1608 2008-01-03  Adam Roben  <aroben@apple.com>
1609
1610         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
1611
1612         Rubberstamped by Mark.
1613
1614         * Scripts/update-webkit-auxiliary-libs:
1615
1616 2008-01-03  Adam Roben  <aroben@apple.com>
1617
1618         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
1619
1620         http://bugs.webkit.org/show_bug.cgi?id=15663
1621
1622         Added a fuzz factor into the Last-Modified comparison for downloading
1623         WebKitAuxiliaryLibrary.zip.
1624
1625         The zip file is served from a set of mirrors who give Last-Modified
1626         times that are off by 1-3 seconds from each other. This was causing
1627         the build bots to redownload WebKitAuxiliaryLibrary for every build,
1628         which would then cause all of WebCore to rebuild each time.
1629
1630         Reviewed by Mark.
1631
1632         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
1633         at least 30 seconds newer than the old one -- otherwise we assume that
1634         the difference in time is due to the mirrors being slightly offset
1635         from each other.
1636         (sub lastModifiedToUnixTime): Added.
1637
1638 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1639
1640         Windows build fix.
1641
1642         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
1643
1644 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1645
1646         Reviewed by Lars.
1647
1648         Moved QWebPage::open to QWebFrame::load and added setHtml.
1649         
1650
1651         * DumpRenderTree/qt/DumpRenderTree.cpp:
1652         (WebCore::DumpRenderTree::open):
1653
1654 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1655
1656         Reviewed by Lars.
1657
1658         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
1659         
1660
1661         * DumpRenderTree/qt/DumpRenderTree.cpp:
1662         (WebCore::DumpRenderTree::DumpRenderTree):
1663
1664 2008-01-02  Sam Weinig  <sam@webkit.org>
1665
1666         * Scripts/do-webcore-rename: Yet more renaming ideas.
1667
1668 2008-01-02  Darin Adler  <darin@apple.com>
1669
1670         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
1671
1672 2008-01-02  Alice Liu  <alice.liu@apple.com>
1673
1674         Reviewed by Sam Weinig.
1675
1676         fixing assertion hit with editing/selection/move-begin-end.html
1677
1678         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
1679         * DumpRenderTree/win/DumpRenderTree.vcproj:
1680         * DumpRenderTree/win/EventSender.cpp:
1681         (keyDownCallback):
1682         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
1683
1684 2008-01-02  Darin Adler  <darin@apple.com>
1685
1686         * Scripts/do-webcore-rename: Some more name change plans.
1687
1688 2008-01-02  Alice Liu  <alice.liu@apple.com>
1689
1690         Reviewed by Maciej.
1691
1692         Added handling for page up and page down in EventSender
1693
1694         * DumpRenderTree/mac/EventSendingController.mm:
1695         (-[EventSendingController keyDown:withModifiers:]):
1696         * DumpRenderTree/win/EventSender.cpp:
1697         (keyDownCallback):
1698
1699 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
1700
1701         Reviewed by Darin.
1702
1703         Fix fast/events/arrow-keys-on-body.html for real.
1704
1705         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
1706
1707 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
1708
1709         Reviewed by Darin.
1710
1711         http://bugs.webkit.org/show_bug.cgi?id=16674
1712         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
1713
1714         * Scripts/run-launcher:
1715
1716 2007-12-31  Darin Adler  <darin@apple.com>
1717
1718         Suggested by Antti.
1719
1720         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
1721         we get it installed on the build bots.
1722
1723 2007-12-30  Eric Seidel  <eric@webkit.org>
1724
1725         Reviewed by Sam.
1726
1727         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
1728
1729 2007-12-29  Darin Adler  <darin@apple.com>
1730
1731         Reviewed by Oliver.
1732
1733         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
1734           leak bot shows createCStringFromNPVariant result leaking
1735
1736         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1737         (pluginInvoke): Added a missing free.
1738
1739 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1740
1741         Reviewed by Alp Toker.
1742
1743         http://bugs.webkit.org/show_bug.cgi?id=16390
1744         Use autotools or GNU make as the build system for the GTK port
1745
1746         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
1747         * GNUmakefile.am: Added.
1748
1749 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
1750
1751         Reviewed by Oliver.
1752
1753         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
1754
1755         * DumpRenderTree/win/EventSender.cpp:
1756         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
1757         of 1, even though WebKit currently ignores it.
1758
1759 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
1760
1761         wx buildbot fix. Update libpng dl script to the latest version.
1762
1763         * wx/install-unix-extras:
1764
1765 2007-12-22  Antti Koivisto  <antti@apple.com>
1766
1767         Fix a typo.
1768
1769         * Scripts/webkitdirs.pm:
1770
1771 2007-12-21  Sam Weinig  <sam@webkit.org>
1772
1773         Reviewed by Mark Rowe.
1774
1775         - Disable the back/forward cache using the new WebPreferences API
1776           instead of through the BackForwardList.  This makes us match what
1777           we do on Windows.
1778
1779         * DumpRenderTree/mac/DumpRenderTree.mm:
1780         (createWebViewAndOffscreenWindow):
1781         (setDefaultsToConsistentValuesForTesting):
1782
1783 2007-12-21  Dan Bernstein  <mitz@apple.com>
1784
1785         Reviewed by Mark Rowe.
1786
1787         - disable the back/forward cache in Windows DumpRenderTree. It is
1788           already disabled in Mac DumpRenderTree.
1789
1790         * DumpRenderTree/win/DumpRenderTree.cpp:
1791         (initializePreferences):
1792
1793 2007-12-13  Antti Koivisto  <antti@apple.com>
1794
1795         Reviewed by Darin and Steve.
1796         
1797         - check for QuickTime SDK on Windows.
1798         - build media support on Windows by default
1799
1800         * Scripts/build-webkit:
1801         * Scripts/webkitdirs.pm:
1802
1803 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
1804
1805         Build script fix for buildbot.
1806
1807         * wx/build-wxwebkit:
1808
1809 2007-12-20  Eric Seidel  <eric@webkit.org>
1810
1811         Reviewed by mjs.
1812
1813         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
1814
1815 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1816
1817         Reviewed by Steve.
1818
1819         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
1820         WebKit.
1821
1822         - Drosera and Safari need to use the same ProgIDs in order for
1823         CoCreateInstance to work properly.  The most robust way to do this is
1824         for WebKit to dynamically publish those ProgIDs.
1825
1826         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
1827         (DebuggerClient::createWebViewWithRequest):
1828         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
1829         statics.
1830         (Drosera::initUI):
1831         (Drosera::attach):
1832         (Drosera::attemptToCreateServerConnection):
1833         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
1834         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
1835         make use of the published ProgIDs.
1836         (ServerConnection::attemptToCreateServerConnection):
1837
1838 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1839
1840         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
1841         - Build bot and leak fix.
1842
1843         * DumpRenderTree/LayoutTestController.cpp:
1844         (pathToLocalResourceCallback):
1845
1846 2007-12-19  David Kilzer  <ddkilzer@apple.com>
1847
1848         Make svn-apply/svn-unapply work with patches from git-format-patch.
1849
1850         Reviewed by Darin.
1851
1852         * Scripts/svn-apply:
1853         (patch): If 'Index:' can't be found in the text passed in, print it
1854         out with a warning and return early.
1855         * Scripts/svn-unapply:
1856         (patch): Ditto.
1857
1858 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
1859
1860         Reviewed by Alp Toker.
1861
1862         Build related fixes.
1863
1864         * wx/build-wxwebkit:
1865         - Check to make sure the user is running a supported wx port
1866         - More robust checks for Cygwin
1867         - Only run install-unix-extras on Mac, it's not the right solution
1868           for Linux distros.
1869         - Remove outdated Linux instructions after successful build
1870         - Clean Bakefile-generated files during a clean operation
1871
1872 2007-12-18  Darin Adler  <darin@apple.com>
1873
1874         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
1875
1876 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
1877
1878         Add script to run Drosera as part of the nightly.
1879         
1880         Reviewed by Kevin M.
1881
1882         * Scripts/run-drosera.cmd: Added.
1883
1884 2007-12-18  Darin Adler  <darin@apple.com>
1885
1886         * Scripts/do-webcore-rename: Remove a stray K.
1887
1888 2007-12-18  Darin Adler  <darin@apple.com>
1889
1890         * Scripts/do-webcore-rename: Plan more renaming.
1891
1892 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
1893
1894         Reviewed by Alp Toker.
1895
1896         http://bugs.webkit.org/show_bug.cgi?id=16042
1897         [GTK] Eliminate webkit_init()
1898
1899         Moving webkit initialization to WebView class init.
1900
1901         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1902         (main):
1903         * GtkLauncher/main.c:
1904         (main):
1905
1906 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
1907
1908         Reviewed by Alp Toker.
1909
1910         http://bugs.webkit.org/show_bug.cgi?id=13542
1911         gdklauncher doesnt change URL in adress GTKEntry.
1912
1913         * GtkLauncher/main.c:
1914         (load_commit_cb): added
1915         (title_change_cb):
1916         (create_browser):
1917
1918 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
1919
1920         Reviewed by Adam Roben.
1921
1922         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
1923
1924         * FindSafari/FindSafari.cpp:
1925         (_tmain):
1926
1927 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
1928
1929         Reviewed by Adam Roben.
1930
1931         http://bugs.webkit.org/show_bug.cgi?id=16315
1932         FindSafari needs a path-only option.
1933
1934         * FindSafari/FindSafari.cpp:
1935         (_tmain):
1936
1937 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
1938
1939         Reviewed by Darin.
1940
1941         http://bugs.webkit.org/show_bug.cgi?id=16462
1942         REGRESSION: access keys broken on Windows
1943
1944         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
1945         if Alt is pressed.
1946
1947 2007-12-15  Sam Weinig  <sam@webkit.org>
1948
1949         Reviewed by Mark Rowe.
1950
1951         Fix urlSuitableForTestResult to correctly identify wstring::npos as
1952         the case when wstring.find doesn't find anything.
1953
1954         * DumpRenderTree/win/DumpRenderTree.cpp:
1955         (urlSuitableForTestResult):
1956
1957 2007-12-15  Alp Toker  <alp@atoker.com>
1958
1959         GTK+ DRT build fix for GLib < 2.14.
1960
1961         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1962         (LayoutTestController::setWaitToDump):
1963
1964 2007-12-05  Mark Rowe  <mrowe@apple.com>
1965
1966         Reviewed by Alp Toker.
1967
1968         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
1969         many layout tests from hanging while waiting on user responses to dialogs.
1970
1971         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1972         (invalidateAnyPreviousWaitToDumpWatchdog):
1973         (webViewScriptAlert):
1974         (webViewScriptPrompt):
1975         (webViewScriptConfirm):
1976         (main):
1977         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1978         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1979         (waitToDumpWatchdogFired):
1980         (LayoutTestController::setWaitToDump):
1981
1982 2007-12-05  Mark Rowe  <mrowe@apple.com>
1983
1984         Reviewed by Alp Toker.
1985
1986         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
1987
1988         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1989         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1990         (dump):
1991         (runTest):
1992         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
1993         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
1994         work queue is empty.
1995         (webViewWindowObjectCleared): Set up window.layoutTestController.
1996         (webViewConsoleMessage): Match the console message format expected by the layout test results.
1997         (main): Hook up the new signals.
1998         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1999         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
2000         dumping multiple times.
2001         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
2002         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
2003
2004 2007-12-14  Anders Carlsson  <andersca@apple.com>
2005
2006         Reviewed by Brady.
2007
2008         Assert that a web frame that's loading a resource always has either a data source or 
2009         a provisional data source.
2010         
2011         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2012         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2013
2014 2007-12-14  Darin Adler  <darin@apple.com>
2015
2016         - fix mistake causing nearly all tests to fail on Windows
2017
2018         * DumpRenderTree/win/UIDelegate.cpp:
2019         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
2020         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
2021
2022         * DumpRenderTree/mac/UIDelegate.mm:
2023         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
2024         than passing the entire message.
2025
2026 2007-12-14  Darin Adler  <darin@apple.com>
2027
2028         - fix Tiger build
2029
2030         * DumpRenderTree/mac/UIDelegate.mm:
2031         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
2032         new-to-Leopard methods.
2033
2034 2007-12-14  Darin Adler  <darin@apple.com>
2035
2036         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
2037         since it now triggers unwanted icon loading. We only had it because we implemented "all"
2038         delegate methods here.
2039
2040 2007-12-14  Anders Carlsson  <andersca@apple.com>
2041
2042         Reviewed by Darin and Geoff.
2043
2044         <rdar://problem/5619295> 
2045         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
2046         
2047         Add property getting methods to the plug-in.
2048         
2049         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2050         (pluginInvoke):
2051
2052 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
2053
2054         Reviewed by Darin.
2055
2056         - Layout test fix for mac. When dumped to the console local file paths
2057         now only show the name of the resource not the whole path.  This is to
2058         make the results machine and OS independent.
2059
2060         * DumpRenderTree/mac/UIDelegate.mm:
2061         (-[UIDelegate webView:addMessageToConsole:]):
2062
2063 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
2064
2065         Reviewed by Adam.
2066
2067         - Layout tests fix.  We need a way to remove machine-dependent
2068         information from paths in layout test results. The UIDelegate now does
2069         this.
2070
2071         * DumpRenderTree/DumpRenderTree.h:
2072         * DumpRenderTree/win/DumpRenderTree.cpp:
2073         (urlSuitableForTestResult):
2074         * DumpRenderTree/win/DumpRenderTreeWin.h:
2075         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2076         * DumpRenderTree/win/UIDelegate.cpp:
2077         (UIDelegate::webViewAddMessageToConsole):
2078
2079 2007-12-13  Alp Toker  <alp@atoker.com>
2080
2081         Build fix for DRT breakage introduced in r28690.
2082
2083         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2084         (LayoutTestController::pathToLocalResource):
2085
2086 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
2087
2088         Reviewed by Alice and Sam.
2089
2090         - <rdar://5621435> Need a way to specify local resources (being loaded
2091         from HTTP tests) on Windows.
2092         - Implemented pathToLocalResource which exposes the functionality of
2093         converting a given unix path to the correct location on Windows.
2094
2095         * DumpRenderTree/LayoutTestController.cpp:
2096         (pathToLocalResourceCallback):
2097         (LayoutTestController::staticFunctions):
2098         * DumpRenderTree/LayoutTestController.h:
2099         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2100         (LayoutTestController::pathToLocalResource):
2101         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2102         (LayoutTestController::pathToLocalResource):
2103
2104 2007-12-12  Anders Carlsson  <andersca@apple.com>
2105
2106         Reviewed by Sam.
2107
2108         <rdar://problem/5132003>
2109         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
2110
2111         * DumpRenderTree/win/DumpRenderTree.cpp:
2112         (main):
2113         Set the resource load delegate.
2114         
2115         * DumpRenderTree/win/DumpRenderTree.vcproj:
2116         
2117         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
2118         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
2119
2120 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
2121
2122         Reviewed by Adam Roben.
2123
2124         Fix conversion from double to LPARAM in dispatchMessage().
2125
2126         * DumpRenderTree/win/EventSender.cpp:
2127         (dispatchMessageCallback):
2128
2129 2007-12-11  Dan Bernstein  <mitz@apple.com>
2130
2131         Reviewed by Mark Rowe and Sam Weinig too!
2132
2133         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
2134           fonts DumpRenderTree registers.
2135
2136         * DumpRenderTree/win/DumpRenderTree.cpp:
2137         (initialize):
2138
2139 2007-12-11  Brady Eidson  <beidson@apple.com>
2140
2141         Reviewed by Anders
2142
2143         Make DumpRenderTree on mac use its own path for Databases testing
2144
2145         * DumpRenderTree/mac/DumpRenderTree.mm:
2146         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
2147           for future DRT-only use, then use it to construct the Databases path and set that default
2148
2149 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
2150
2151         Reviewed by Darin.
2152
2153         <rdar://problem/5535636>
2154         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
2155
2156         http://bugs.webkit.org/show_bug.cgi?id=13916
2157         JavaScript detects Tab as a character input on a textfield validation
2158
2159         * DumpRenderTree/mac/EventSendingController.mm:
2160         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
2161         Dispatch a keyup to better match what happens when a key is physically pressed.
2162
2163         * DumpRenderTree/win/EventSender.cpp:
2164         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
2165         returning from keyDown().
2166         (getConstantCallback): Fixed a couple copy/paste mistakes.
2167
2168 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
2169
2170         Reviewed by Oliver.
2171
2172         - <rdar://5599845> Drosera: Does not show loal files in the file list
2173         on the left side.
2174
2175         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
2176         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
2177         so the open source community can build.
2178
2179 2007-12-10  Brady Eidson  <beidson@apple.com>
2180
2181         Rubberstamped by Sam Weinig
2182
2183         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
2184
2185         * DumpRenderTree/mac/UIDelegate.mm:
2186         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2187         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
2188
2189 2007-12-08  Oliver Hunt  <oliver@apple.com>
2190
2191         Reviewed by Sam W.
2192
2193         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
2194         
2195         Fixes <rdar://problem/5620249> Must disable SVG animation
2196         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
2197         
2198         In order to allow finer grained control over the set of SVG features
2199         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
2200         distinct flags:
2201         ENABLE_SVG_ANIMATION
2202         ENABLE_SVG_FILTERS
2203         ENABLE_SVG_FONTS
2204         ENABLE_SVG_AS_IMAGE
2205         ENABLE_SVG_USE
2206         
2207         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
2208         
2209         Script handles all the new build flags, and allows --svg-experimental
2210         to automatically enable all features.
2211
2212         * Scripts/build-webkit:
2213
2214 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
2215
2216         Fix version parsing.
2217
2218         Rubber-stamped by Oliver.
2219
2220         * Drosera/win/Drosera.vcproj/auto-version.sh:
2221
2222 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
2223
2224         Build modifications for Drosera.
2225
2226         Reviewed by Adam.
2227
2228         * Drosera/DroseraWin.make: Added.
2229         * Drosera/win/Drosera.vcproj/Drosera.rc:
2230         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2231         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
2232         * Drosera/win/Drosera.vcproj/VERSION: Added.
2233         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
2234
2235 2007-12-06  Adam Roben  <aroben@apple.com>
2236
2237         Explicitly turn on the Mac font ascent hack on Windows
2238
2239         This keeps our font metrics matching those from Mac.
2240
2241         Reviewed by Hyatt.
2242
2243         * DumpRenderTree/win/DumpRenderTree.cpp:
2244         (main):
2245
2246 2007-12-06  Anders Carlsson  <andersca@apple.com>
2247
2248         Rename main.c to main.cpp here too.
2249         
2250         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
2251
2252 2007-12-06  Sam Weinig  <sam@webkit.org>
2253
2254         Rubber stamped by Geoff.
2255
2256         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
2257
2258 2007-12-06  Darin Adler  <darin@apple.com>
2259
2260         * Scripts/do-webcore-rename: Some more renaming plans.
2261
2262 2007-12-06  Anders Carlsson  <andersca@apple.com>
2263
2264         Restore implementation of testGetIntIdentifier that was accidentally
2265         removed somehow (possibly when I made PluginObject be a cpp file).
2266         
2267         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2268         (pluginInvoke):
2269
2270 2007-12-05  Anders Carlsson  <andersca@apple.com>
2271
2272         Make the entry points extern "C".
2273         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2274         
2275 2007-12-05  Anders Carlsson  <andersca@apple.com>
2276
2277         C++ warning fixes.
2278         
2279         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2280         (NPP_New):
2281         (NPP_Destroy):
2282         (NPP_SetWindow):
2283         (NPP_NewStream):
2284         (NPP_HandleEvent):
2285         (NPP_URLNotify):
2286         (NPP_GetValue):
2287
2288 2007-12-05  Anders Carlsson  <andersca@apple.com>
2289
2290         Add the .cpp files to the TestNetscapePlugIn target.
2291
2292         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2293
2294 2007-12-05  Anders Carlsson  <andersca@apple.com>
2295
2296         Reviewed by Geoff.
2297         
2298         Rename the TestNetscapePlugIn .c files to be .cpp.
2299
2300         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2301         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
2302         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
2303         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
2304         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
2305         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
2306         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
2307         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2308
2309 2007-12-05  Adam Roben  <aroben@apple.com>
2310
2311         Fix case of keypresses from the Windows implementation of eventSender.keyDown
2312
2313         This fixes several regression tests.
2314
2315         Reviewed by Alice.
2316
2317         * DumpRenderTree/win/EventSender.cpp:
2318         (keyDownCallback): Virtual keycodes for ASCII characters are always
2319         uppercase, so we need to check the case of the original character
2320         passed in to eventSender.keyDown.
2321
2322 2007-12-05  Adam Roben  <aroben@apple.com>
2323
2324         Learn from Tim's mistakes
2325
2326         * DumpRenderTree/win/DumpRenderTree.cpp:
2327         (runTest): Reset the authorAndUserStylesEnabled preference for each
2328         test.
2329
2330 2007-12-05  Alp Toker  <alp@atoker.com>
2331
2332         Reviewed by Mark Rowe.
2333
2334         Initialize GTK+ and WebKit so the tests can run.
2335
2336         Reorganize the headers a little.
2337
2338         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2339         (main):
2340
2341 2007-12-04  Anders Carlsson  <andersca@apple.com>
2342
2343         Remove IWebScriptScope include.
2344         
2345         * Drosera/win/DebuggerDocumentPlatform.cpp:
2346
2347 2007-12-04  Sam Weinig  <sam@webkit.org>
2348
2349         Rubber stamped by Mark Rowe.
2350
2351         Define CF as platform for mac and revert r28409
2352
2353         * DumpRenderTree/DumpRenderTree.h:
2354         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2355
2356 2007-12-04  Sam Weinig  <sam@webkit.org>
2357
2358         Define CF as platform for windows.
2359
2360         Reviewed by Adam Roben.
2361
2362         * DumpRenderTree/win/DumpRenderTreeWin.h:
2363
2364 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
2365
2366         Reviewed by Adam and Darin.
2367
2368         - Removed a needless BSTR cleanup.
2369
2370         * Drosera/win/DebuggerDocumentPlatform.cpp:
2371         (DebuggerDocument::getPlatformCurrentFunctionStack):
2372
2373 2007-11-27  Adam Roben  <aroben@apple.com>
2374
2375         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
2376
2377         Reviewed by Maciej.
2378
2379         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2380         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
2381
2382 2007-12-04  Alp Toker  <alp@atoker.com>
2383
2384         Prospective Win DRT build fix.
2385
2386         * DumpRenderTree/DumpRenderTree.h:
2387
2388 2007-12-04  Alp Toker  <alp@atoker.com>
2389
2390         Fix a clobbered copyright header.
2391
2392         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2393
2394 2007-12-04  Xan Lopez  <xan@gnome.org>
2395
2396         Reviewed by Alp Toker.
2397
2398         http://bugs.webkit.org/show_bug.cgi?id=15561
2399         GTK port needs DumpRenderTree implementation
2400
2401         Start work on the GTK+ DRT.
2402
2403         This does not work yet, and there are a few lingering style issues
2404         (nothing major) but this patch has been stuck in the bug tracker for
2405         too long already.
2406
2407         * DumpRenderTree/DumpRenderTree.h:
2408         * DumpRenderTree/gtk: Added.
2409         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
2410         (autocorrectURL):
2411         (shouldLogFrameLoadDelegates):
2412         (dumpFrameScrollPosition):
2413         (displayWebView):
2414         (appendString):
2415         (dumpFramesAsText):
2416         (dumpRenderTreeAsText):
2417         (dump):
2418         (runTest):
2419         (main):
2420         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
2421         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
2422         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
2423         (GCController::collect):
2424         (GCController::collectOnAlternateThread):
2425         (GCController::getJSObjectCount):
2426         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
2427         (LayoutTestController::~LayoutTestController):
2428         (LayoutTestController::addDisallowedURL):
2429         (LayoutTestController::clearBackForwardList):
2430         (LayoutTestController::copyDecodedHostName):
2431         (LayoutTestController::copyEncodedHostName):
2432         (LayoutTestController::display):
2433         (LayoutTestController::keepWebHistory):
2434         (LayoutTestController::notifyDone):
2435         (LayoutTestController::queueBackNavigation):
2436         (LayoutTestController::queueForwardNavigation):
2437         (LayoutTestController::queueLoad):
2438         (LayoutTestController::queueReload):
2439         (LayoutTestController::queueScript):
2440         (LayoutTestController::setAcceptsEditing):
2441         (LayoutTestController::setCustomPolicyDelegate):
2442         (LayoutTestController::setMainFrameIsFirstResponder):
2443         (LayoutTestController::setTabKeyCyclesThroughElements):
2444         (LayoutTestController::setUseDashboardCompatibilityMode):
2445         (LayoutTestController::setUserStyleSheetEnabled):
2446         (LayoutTestController::setUserStyleSheetLocation):
2447         (LayoutTestController::setWindowIsKey):
2448         (LayoutTestController::setWaitToDump):
2449         (LayoutTestController::windowCount):
2450         (LayoutTestController::setPrivateBrowsingEnabled):
2451         (LayoutTestController::setAuthorAndUserStylesEnabled):
2452         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
2453         (JSStringCopyUTF8CString):
2454         (LoadItem::invoke):
2455         (ReloadItem::invoke):
2456         (ScriptItem::invoke):
2457         (BackForwardItem::invoke):
2458
2459 2007-12-03  Sam Weinig  <sam@webkit.org>
2460
2461         Move JavaScriptCore thread testing code to pthread specific directory
2462         and remove the dependance on CoreFoundation by using WTF::HashSet.
2463
2464         Reviewed by Geoff and Oliver.
2465
2466         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2467         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
2468         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
2469         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
2470         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
2471         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
2472         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
2473         * DumpRenderTree/pthreads: Added.
2474         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
2475         (javaScriptThreads):
2476         (runJavaScriptThread):
2477         (startJavaScriptThreads):
2478         (stopJavaScriptThreads):
2479
2480 2007-12-03  Andrew Bonventre  <andybons@google.com>
2481
2482         Reviewed by Darin Adler.
2483
2484         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
2485         Symbol lookup menu broken in debugger view
2486
2487         * Drosera/debugger.js: Fixed javascript error where document property
2488         should have been used instead of contentDocument in switchFunction that
2489         was breaking the select symbol dropdown menu.  This is because
2490         window.frames will return a Window object and not a frame object like
2491         the author was originally expecting.
2492
2493 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
2494
2495         Reviewed by Adam.
2496
2497         - <rdar://5618942> Drosera: Console window does not process everything
2498         correctly.
2499         - <rdar://5619005> Drosera: could be sped up by moving the 
2500         WebScriptScope stuff into the WebScriptCallFrame.
2501         - Now the console can correctly process objects and does not receive
2502         notifications from JavaScriptCore about the JavaScript in Drosera's
2503         own process.
2504
2505         * Drosera/win/DebuggerDocumentPlatform.cpp:
2506         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2507         (DebuggerDocument::platformValueForScopeVariableNamed):
2508
2509 2007-12-03  Stephanie  <slewis@apple.com>
2510
2511         Reviewed by Darin.
2512
2513         Check to see if we are building a debug root
2514
2515         * Scripts/check-for-global-initializers: 
2516
2517 2007-12-03  Dan Bernstein  <mitz@apple.com>
2518
2519         Reviewed by Darin Adler.
2520
2521         - added a testGetIntIdentifier() method to TestNetscapePlugIn
2522
2523         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
2524         (pluginInvoke):
2525
2526 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
2527
2528         Reviewed by Oliver.
2529
2530         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
2531         in a more fine-grained manner than eventSender.keyDown().
2532
2533         * DumpRenderTree/win/EventSender.cpp:
2534         (getConstantCallback):
2535         (dispatchMessageCallback):
2536
2537 2007-12-02  Darin Adler  <darin@apple.com>
2538
2539         * Scripts/do-webcore-rename: More planned renaming.
2540
2541 2007-12-02  Sam Weinig  <sam@webkit.org>
2542
2543         Rubber stamped by Anders.
2544
2545         Use [NSURL absoluteString] instead of [NSURL description] in order to get
2546         more uniform results cross platform.
2547
2548         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2549         (-[NSURL _drt_descriptionSuitableForTestResult]):
2550
2551 2007-12-02  Sam Weinig  <sam@webkit.org>
2552
2553         Rubber stamped by Niko.
2554
2555         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
2556
2557         * DumpRenderTree/win/DumpRenderTree.cpp:
2558         * DumpRenderTree/win/DumpRenderTree.vcproj:
2559         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
2560         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
2561         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
2562         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
2563
2564 2007-12-01  Alp Toker  <alp@atoker.com>
2565
2566         Reviewed by Adam Roben.
2567
2568         Make use of the newly introduced webkit.h convenience header.
2569
2570         * GtkLauncher/main.c:
2571
2572 2007-12-01  Adam Treat  <treat@kde.org>
2573
2574         Reviewed by Simon.
2575
2576         * Check to see if the directory exists and exit if not.
2577
2578         * DumpRenderTree/qt/main.cpp:
2579         (main):
2580
2581 2007-12-01  Adam Treat  <treat@kde.org>
2582
2583         Reviewed by Simon.
2584
2585         * Don't hide symbols when in Debug mode
2586         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
2587
2588
2589         * DumpRenderTree/qt/main.cpp:
2590         (messageHandler):
2591
2592 2007-11-30  Alp Toker  <alp@atoker.com>
2593
2594         Reviewed by Adam Roben.
2595
2596         http://bugs.webkit.org/show_bug.cgi?id=15691
2597         [GTK] Public API does not follow GTK+ conventions
2598
2599         Refactor the WebKit/GTK+ public API. Changes:
2600           WebKitPage -> WebKitWebView
2601           WebKitFrame -> WebKitWebFrame
2602
2603         Public API source and header names have been updated to mirror the API
2604         changes.
2605
2606         The API is now kept in WebKit/gtk/WebView to match other ports in the
2607         same class such as Mac and Win.
2608
2609         * GtkLauncher/main.c:
2610         (activate_uri_entry_cb):
2611         (link_hover_cb):
2612         (title_change_cb):
2613         (progress_change_cb):
2614         (go_back_cb):
2615         (go_forward_cb):
2616         (create_browser):
2617         (main):
2618
2619 2007-11-30  Adam Roben  <aroben@apple.com>
2620
2621         Hopefully the final build fix
2622
2623         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
2624         pull in WTF's assertion/logging functions.
2625
2626 2007-11-30  Adam Roben  <aroben@apple.com>
2627
2628         Another build fix
2629
2630         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
2631         WebKit.lib.
2632
2633 2007-11-30  Adam Roben  <aroben@apple.com>
2634
2635         Debug build fix
2636
2637         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
2638         configuration.
2639         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
2640         projects.
2641         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
2642         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
2643         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
2644
2645 2007-11-30  Sam Weinig  <sam@webkit.org>
2646
2647         Reviewed by Adam Roben.
2648
2649         Fix drawSelectionRect to actually draw the selection rect.
2650
2651         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2652         (drawSelectionRect):
2653
2654 2007-11-30  Darin Adler  <darin@apple.com>
2655
2656         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
2657
2658 2007-11-30  Darin Adler  <darin@apple.com>
2659
2660         * Scripts/do-webcore-rename: Get ready for some future renaming.
2661
2662 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2663
2664         Reviewed by Adam.
2665
2666         - Removed some unnecessary functions and changed an unused return type. 
2667
2668         * Drosera/win/DebuggerClient.cpp:
2669         (registerConsoleClass):
2670         * Drosera/win/DebuggerClient.h:
2671         * Drosera/win/Drosera.cpp:
2672         (registerDroseraClass):
2673
2674 2007-11-28  Alp Toker  <alp@atoker.com>
2675
2676         Reviewed by Timothy Hatcher.
2677
2678         http://bugs.webkit.org/show_bug.cgi?id=16174
2679         [GTK] Use "URI" not "URL" in public API
2680
2681         Replace use of the term "URL" with "URI" in public headers,
2682         documentation and some internal code to match GLib/GTK+ convention.
2683
2684         This is now mentioned in the API guidelines:
2685           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
2686
2687         * GtkLauncher/main.c:
2688         (activate_uri_entry_cb):
2689         (title_change_cb):
2690         (create_toolbar):
2691         (main):
2692
2693 2007-11-29  Anders Carlsson  <andersca@apple.com>
2694
2695         Reviewed by Sam.
2696
2697         <rdar://problem/5230478>
2698         FrameLoadDelegate callbacks are not dumped in DRT.
2699         
2700         * DumpRenderTree/win/DumpRenderTree.cpp:
2701         (shouldLogFrameLoadDelegates):
2702         (runTest):
2703         (main):
2704         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2705         (BSTRtoString):
2706         (descriptionSuitableForTestResult):
2707         (FrameLoadDelegate::QueryInterface):
2708         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2709         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2710         (FrameLoadDelegate::didCommitLoadForFrame):
2711         (FrameLoadDelegate::didFinishLoadForFrame):
2712         (FrameLoadDelegate::willCloseFrame):
2713         (FrameLoadDelegate::didClearWindowObject):
2714         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2715         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2716         * DumpRenderTree/win/FrameLoaderDelegate.h:
2717         (FrameLoadDelegate::windowScriptObjectAvailable):
2718         (FrameLoadDelegate::didFirstLayoutInFrame):
2719
2720 2007-11-29  Sam Weinig  <sam@webkit.org>
2721
2722         Reviewed by Anders.
2723
2724         Add database quota UIDelegates methods to DRT UIDelegate.
2725
2726         * DumpRenderTree/mac/UIDelegate.mm:
2727         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2728         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
2729
2730 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2731
2732         Reviewed by Sam.
2733
2734         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
2735         dying and vice versa.
2736         - This fix will allow Drosera and Safari to reconnect if either of them
2737         closes correctly, but does not fix the case where one of them dies
2738         silently.
2739
2740         * Drosera/win/ServerConnection.cpp:
2741         (ServerConnection::attemptToCreateServerConnection): Added a safety
2742         check, because it's possilbe to try to connect to a server that's dying.
2743         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
2744         the server has died.
2745         * Drosera/win/ServerConnection.h: Added the new function and removed
2746         an unnecessary member.
2747
2748 2007-11-29  Anders Carlsson  <andersca@apple.com>
2749
2750         * DumpRenderTree/win/DumpRenderTree.vcproj:
2751         Add shlwapi.lib to all configurations.
2752
2753 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2754
2755         - Build fix.  Added additional includes for VS Express to the Release
2756         project.
2757
2758         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2759
2760 2007-11-29  Anders Carlsson  <andersca@apple.com>
2761
2762         Reviewed by Adam.
2763
2764         <rdar://problem/5132005>
2765         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
2766         
2767         * DumpRenderTree/win/DumpRenderTree.vcproj:
2768         Add shlwapi.lib
2769         
2770         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2771         (LayoutTestController::setUserStyleSheetEnabled):
2772         Implement this.
2773         
2774         (appendComponentToPath):
2775         New method which wraps the Win32 API PathAppend.
2776         
2777         (followShortcuts):
2778         New method which checks if a file points to a shortcut and
2779         follows the shortcut.
2780         
2781         (resolveCygwinPath):
2782         New method that takes a cygwin unix-style path and returns the Win32 path.
2783         
2784         (cfStringRefToWString):
2785         
2786         (LayoutTestController::setUserStyleSheetLocation):
2787         Implement this.
2788
2789 2007-11-29  Alice Liu  <alice.liu@apple.com>
2790
2791         Reviewed by Adam.
2792
2793         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
2794
2795         * DumpRenderTree/win/EventSender.cpp:
2796         (keyDownCallback):
2797         uppercase letters were being sent as lowercase letters without the shift key down.
2798
2799 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2800
2801         - Windows build fix. VS express needs some love.
2802
2803         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2804
2805 2007-11-28  Darin Adler  <darin@apple.com>
2806
2807         Reviewed by Adam Roben.
2808
2809         * DumpRenderTree/mac/EventSendingController.mm:
2810         (-[EventSendingController keyDown:withModifiers:]):
2811         Send capital letters through as lowercase letters with the shift key down
2812         rather than sending them as if they were highly unusual "capital letter keys".
2813
2814         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
2815         where you need to update results and more tests are failing than before.
2816
2817 2007-11-28  Anders Carlsson  <andersca@apple.com>
2818
2819         Reviewed by Darin.
2820
2821         <rdar://problem/5132001>
2822         contextClick is not implemented in DRT on Windows.
2823         
2824         * DumpRenderTree/win/EventSender.cpp:
2825         (contextClickCallback):
2826         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
2827         by a WM_RBUTTONUP message.
2828         
2829         * DumpRenderTree/win/UIDelegate.cpp:
2830         (UIDelegate::hasCustomMenuImplementation):
2831         (UIDelegate::trackCustomPopupMenu):
2832         * DumpRenderTree/win/UIDelegate.h:
2833         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
2834         menu from being shown (and causing the DRT to hang).
2835
2836 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
2837
2838         Reviewed by Darin.
2839
2840         Fix DumpRenderTree ObjC bug comparing strings.
2841
2842         * DumpRenderTree/mac/ObjCController.m:
2843         (-[ObjCController identityIsEqual::]): Compare strings with string
2844         equality instead of identiy equality.
2845
2846 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2847
2848         Reviewed by Sam.
2849
2850         Reset the authorAndUserStylesEnabled preference
2851         back to YES for each test. Fixes the broken tests.
2852
2853         * DumpRenderTree/mac/DumpRenderTree.mm:
2854         (resetWebViewToConsistentStateBeforeTesting):
2855
2856 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
2857
2858         Reviewed by Adam.
2859
2860         - Drosera now displays the console window, although it cannot currently
2861         process JavaScript.
2862
2863         * Drosera/win/DebuggerClient.cpp: Shows the console window.
2864         (registerConsoleClass): Implemented.
2865         (consoleWndProc): Implemented.
2866         (DebuggerClient::onSize): Implemented.
2867         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
2868         new window.
2869         * Drosera/win/DebuggerClient.h: Added needed method and members for 
2870         creating and maintaining a new window.
2871         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
2872         lines of code to more appropriate places.
2873         (Drosera::handleCommand):
2874         (Drosera::initUI):
2875         (Drosera::onSize):
2876         (Drosera::attach):
2877
2878 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2879
2880         Reviewed by Dave Hyatt.
2881
2882         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
2883         
2884         Add support for disabling author and user styles for testing.
2885
2886         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2887         * DumpRenderTree/LayoutTestController.cpp:
2888         (setAuthorAndUserStylesEnabledCallback):
2889         (LayoutTestController::staticFunctions):
2890         * DumpRenderTree/LayoutTestController.h:
2891         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2892         (LayoutTestController::setAuthorAndUserStylesEnabled):
2893         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2894         (LayoutTestController::setAuthorAndUserStylesEnabled):
2895
2896 2007-11-26  Dan Bernstein  <mitz@apple.com>
2897
2898         - Tiger build fix.
2899
2900         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2901
2902 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
2903
2904         Reviewed by Maciej.
2905
2906         - Implemented displaying variables for Drosera on Win.
2907
2908         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
2909         that retrieve variables to not hold onto the return value since it's
2910         not returned.  Also changed to use the new signatures of the retrieval
2911         functions.
2912         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2913         (DebuggerDocument::platformValueForScopeVariableNamed):
2914         * Drosera/win/Drosera.cpp: Removed a needless TODO.
2915         (droseraWndProc):
2916
2917 2007-11-26  Sam Weinig  <sam@webkit.org>
2918
2919         Cleanup names of painting and repainting functions.
2920
2921         Reviewed by Adam Roben.
2922
2923         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2924         (drawSelectionRect): was drawSelectionRectIntoContext.
2925         (dumpWebViewAsPixelsAndCompareWithExpected):
2926         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2927         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2928         (paintWebView): was drawWebViewIntoContext.
2929         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
2930
2931 2007-11-26  Sam Weinig  <sam@webkit.org>
2932
2933         Reviewed by Dan Bernstein.
2934
2935         - Leopard build fix
2936
2937         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2938
2939 2007-11-26  Sam Weinig  <sam@webkit.org>
2940
2941         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
2942         Use shared PixelDumpSupport for Mac DRT
2943
2944         Reviewed by Adam Roben.
2945
2946         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2947         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
2948         * DumpRenderTree/cg/ImageDiffCG.cpp:
2949         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2950         (drawSelectionRectIntoContext):
2951         (dumpWebViewAsPixelsAndCompareWithExpected):
2952         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2953         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2954         * DumpRenderTree/mac/DumpRenderTree.mm:
2955         (dump):
2956         * DumpRenderTree/mac/ImageDiff.m: Removed.
2957         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
2958         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
2959         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
2960         (setDefaultColorProfileToRGB):
2961         (getBitmapContextFromWebView):
2962         (drawWebViewIntoContext):
2963         (repaintWithVerticalSweep):
2964         (repaintWithHorizontalSweep):
2965         (getSelectionRect):
2966         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
2967
2968 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
2969
2970         Bug 16052: prepare-ChangeLog doesn't report deleted files
2971         <http://bugs.webkit.org/show_bug.cgi?id=16052>
2972
2973         Reviewed by Sam.
2974
2975         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
2976
2977 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
2978
2979         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
2980         <http://bugs.webkit.org/show_bug.cgi?id=15864>
2981
2982         Reviewed by Adam.
2983
2984         Roll functionality of merge-changelog into resolve-ChangeLogs
2985         script.  The script now checks for ChangeLog.rej and
2986         ChangeLog.orig files first.  If it finds them, it uses the
2987         ChangeLog.rej file as a patch (in old contextual diff format) to
2988         apply with --fuzz=3.
2989
2990         * Scripts/merge-changelog: Removed.
2991         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2992
2993 2007-11-25  Sam Weinig  <sam@webkit.org>
2994
2995         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
2996
2997         Reviewed by Mark Rowe.
2998
2999         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3000         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3001         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3002         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
3003         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
3004
3005 2007-11-25  Sam Weinig  <sam@webkit.org>
3006
3007         Convert DumpRenderTree to ues .xcconfig files.
3008
3009         Reviewed by Mark Rowe.
3010
3011         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3012         * DumpRenderTree/mac/Configurations: Added.
3013         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
3014         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
3015         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
3016
3017 2007-11-25  Sam Weinig  <sam@webkit.org>
3018
3019         Add ForwardingHeaders to wtf for DumpRenderTree.
3020
3021         Reviewed by Mark Rowe.
3022
3023         * DumpRenderTree/DumpRenderTree.h:
3024         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3025         * DumpRenderTree/ForwardingHeaders: Added.
3026         * DumpRenderTree/ForwardingHeaders/wtf: Added.
3027         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
3028         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
3029         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
3030         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
3031         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
3032         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
3033         * DumpRenderTree/LayoutTestController.cpp:
3034         * DumpRenderTree/WorkQueue.cpp:
3035         * DumpRenderTree/mac/DumpRenderTree.mm:
3036         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3037         * DumpRenderTree/mac/JavaScriptThreading.cpp:
3038         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3039         * DumpRenderTree/mac/ObjCController.m:
3040         * DumpRenderTree/mac/UIDelegate.mm:
3041         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3042
3043 2007-11-25  Adam Roben  <aroben@apple.com>
3044
3045         Fix some test failures caused by r28019
3046
3047         Now that stdout is in binary mode, we need to always use printf
3048         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
3049         the output.
3050
3051         Reviewed by Sam.
3052
3053         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
3054         printf.
3055         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3056         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3057         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3058         (UIDelegate::webViewAddMessageToConsole):
3059
3060 2007-11-25  Adam Roben  <aroben@apple.com>
3061
3062         Set the font smoothing preference in DRT
3063
3064         This makes the pixel results on Windows closer to the Mac results.
3065
3066         Reviewed by Mitz.
3067
3068         * DumpRenderTree/win/DumpRenderTree.cpp:
3069         (initializePreferences):
3070
3071 2007-11-25  Adam Roben  <aroben@apple.com>
3072
3073         Port ImageDiff to CG and C++
3074
3075         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
3076         <rdar://5071708>
3077
3078         Reviewed by Sam.
3079
3080         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
3081         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
3082         (main):
3083         (createImageFromStdin):
3084         (compareImages):
3085         (getDifferenceBitmap):
3086         (computePercentageDifferent):
3087         * DumpRenderTree/win/ImageDiff.vcproj: Added.
3088
3089 2007-11-25  Adam Roben  <aroben@apple.com>
3090
3091         Fix image diff link generation on Windows
3092
3093         Reviewed by Sam.
3094
3095         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
3096         to toURL.
3097
3098 2007-11-25  Adam Roben  <aroben@apple.com>
3099
3100         Implement pixel dumping in Windows DRT
3101
3102         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
3103         <rdar://5071708>
3104
3105         Reviewed by Sam.
3106
3107         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
3108         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
3109         Content-Length header.
3110         (getMD5HashStringForBitmap):
3111         (dumpWebViewAsPixelsAndCompareWithExpected):
3112         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
3113         * DumpRenderTree/win/DumpRenderTree.cpp:
3114         (dump): Do a pixel dump if requested.
3115         (main): Parse pixel test options.
3116         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
3117         the cg/ subdirectory to the include path.
3118         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
3119         available in a header or import library, so we have to go through this
3120         LoadLibrary/GetProcAddress dance to use them.
3121         (cryptDLL):
3122         (init):
3123         (update):
3124         (final):
3125         (MD5_Init):
3126         (MD5_Update):
3127         (MD5_Final):
3128         * DumpRenderTree/win/MD5.h: Added.
3129         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
3130         moved up to the top level to share it with Mac eventually.
3131         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
3132         (getBitmapContextFromWebView): Forces the WebView to paint using a
3133         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
3134
3135 2007-11-25  Adam Roben  <aroben@apple.com>
3136
3137         Clean up Windows DRT's option parsing a little bit
3138
3139         Reviewed by Sam.
3140
3141         * DumpRenderTree/win/DumpRenderTree.cpp:
3142         (main): Put non-option arguments into a Vector.
3143
3144 2007-11-25  Adam Roben  <aroben@apple.com>
3145
3146         Make Windows DRT stop changing LF into CRLF
3147
3148         Reviewed by Sam.
3149
3150         * DumpRenderTree/win/DumpRenderTree.cpp:
3151         (main): Put stdout in binary mode.
3152         * Scripts/run-webkit-tests: Remove the CRLF hack.
3153
3154 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
3155
3156         Removed empty directory.
3157
3158         * Scripts/resources: Removed.
3159
3160 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
3161
3162         Fix bisect-builds to work with recent WebKit nightly builds.
3163
3164         Reviewed by Dan.
3165
3166         * Scripts/bisect-builds: Check for the 
3167         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
3168         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
3169         to WebKit.app/Contents/Resources.
3170
3171 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
3172
3173         Reviewed by Maciej.
3174
3175         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
3176         not closed (affects digg.com)
3177
3178         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
3179         one after finishing with a test to avoid having its delayed onload handler firing when
3180         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
3181         but it helps somewhat.
3182
3183 2007-11-22  Mark Rowe  <mrowe@apple.com>
3184
3185         Reviewed by Alp Toker.
3186
3187         Fix build-webkit to propagate make's exit status if it fails.
3188
3189         * Scripts/webkitdirs.pm:
3190
3191 2007-11-22  Dan Bernstein  <mitz@apple.com>
3192
3193         Reviewed by Mark Rowe.
3194
3195         - fix crash when running pixel tests
3196
3197         * DumpRenderTree/mac/DumpRenderTree.mm:
3198         (dumpRenderTree): Parse the command line options before setting up the
3199         environment so that we know if we need to set up the pixel dump
3200         machinery.
3201
3202 2007-11-21  Eric Seidel  <eric@webkit.org>
3203
3204         Speculative build fix for Tiger.
3205
3206         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
3207
3208 2007-11-21  Eric Seidel  <eric@webkit.org>
3209
3210         Reviewed by Tim Hatcher.
3211
3212         Break out more of DumpRenderTree.mm into individual files
3213
3214         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3215         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
3216         (checkedMalloc):
3217         (checkedRealloc):
3218         (makeLargeMallocFailSilently):
3219         * DumpRenderTree/mac/CheckedMalloc.h: Added.
3220         * DumpRenderTree/mac/DumpRenderTree.mm:
3221         (crashHandler):
3222         (dump):
3223         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3224         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3225         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3226         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3227         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3228         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
3229         (javaScriptThreads):
3230         (runJavaScriptThread):
3231         (startJavaScriptThreads):
3232         (stopJavaScriptThreads):
3233         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
3234         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
3235         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
3236         (restoreColorSpace):
3237         (setDefaultColorProfileToRGB):
3238         (initializeColorSpaceAndScreeBufferForPixelTests):
3239         (md5HashStringForBitmap):
3240         (dumpWebViewAsPixelsAndCompareWithExpected):
3241
3242 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
3243
3244         Move install-unix-extras to wx directory as it seems only to be used by that 
3245         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
3246         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
3247         have install-unix-extras install into WebKitLibraries as per
3248         convention.
3249         
3250         Reviewed by Mark Rowe.
3251
3252         * Scripts/install-unix-extras: Removed.
3253         * wx/build-wxwebkit:
3254         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
3255
3256 2007-11-21  Eric Seidel  <eric@webkit.org>
3257
3258         Reviewed by Adam.
3259
3260         More refactoring for greater code readability
3261
3262         * DumpRenderTree/mac/DumpRenderTree.mm:
3263         (initializeGlobalsFromCommandLineOptions):
3264         (initializeColorSpaceAndScreeBufferForPixelTests):
3265         (addTestPluginsToPluginSearchPath):
3266         (useLongRunningServerMode):
3267         (runTestingServerLoop):
3268         (prepareConsistentTestingEnvironment):
3269         (dumpRenderTree):
3270         (main):
3271         (dumpFramesAsText):
3272         (dumpBackForwardListForWebView):
3273         (sizeWebViewForCurrentTest):
3274         (methodNameStringForFailedTest):
3275         (dumpBackForwardListForAllWindows):
3276         (dumpWebViewAsPixelsAndCompareWithExpected):
3277         (invalidateAnyPreviousWaitToDumpWatchdog):
3278         (dump):
3279         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3280         * DumpRenderTree/mac/UIDelegate.mm:
3281         (-[UIDelegate webView:createWebViewWithRequest:]):
3282
3283 2007-11-21  Eric Seidel  <eric@webkit.org>
3284
3285         Reviewed by Tim Hatcher.
3286
3287         Abstract more of DRT into static methods
3288
3289         * DumpRenderTree/mac/DumpRenderTree.mm:
3290         (setDefaultsToConsistentValuesForTesting):
3291         (setupSignalHandlers):
3292         (allocateGlobalControllers):
3293         (releaseAndZero):
3294         (releaseGlobalControllers):
3295         (dumpRenderTree):
3296         (shouldLogFrameLoadDelegates):
3297         (createCFURLFromPathOrURL):
3298         (resetWebViewToConsistentStateBeforeTesting):
3299         (runTest):
3300
3301 2007-11-21  Eric Seidel  <eric@webkit.org>
3302
3303         Reviewed by Tim Hatcher.
3304
3305         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
3306
3307         * DumpRenderTree/DumpRenderTree.h:
3308         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3309         * DumpRenderTree/mac/DumpRenderTree.mm:
3310         (dumpRenderTree):
3311         (dump):
3312         (runTest):
3313         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
3314         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
3315         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
3316         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
3317         (-[DumpRenderTreePasteboard declareType:owner:]):
3318         (+[LocalPasteboard alloc]):
3319         (-[LocalPasteboard init]):
3320         (-[LocalPasteboard dealloc]):
3321         (-[LocalPasteboard name]):
3322         (-[LocalPasteboard releaseGlobally]):
3323         (-[LocalPasteboard declareTypes:owner:]):
3324         (-[LocalPasteboard addTypes:owner:]):
3325         (-[LocalPasteboard changeCount]):
3326         (-[LocalPasteboard types]):
3327         (-[LocalPasteboard availableTypeFromArray:]):
3328         (-[LocalPasteboard setData:forType:]):
3329         (-[LocalPasteboard dataForType:]):
3330         (-[LocalPasteboard setPropertyList:forType:]):
3331         (-[LocalPasteboard setString:forType:]):
3332         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
3333         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
3334         (+[DumpRenderTreeWindow allWindows]):
3335         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
3336         (-[DumpRenderTreeWindow dealloc]):
3337         (-[DumpRenderTreeWindow isKeyWindow]):
3338         (-[DumpRenderTreeWindow keyDown:]):
3339
3340 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
3341
3342         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
3343         it indiscriminately copies any headers inside JavaScriptCore,
3344         which includes Tiger ICU headers. 
3345
3346         * wx/build-wxwebkit:
3347         Don't run WebCore/move-js-headers.sh any longer.
3348
3349 2007-11-20  Adam Treat  <treat@kde.org>
3350
3351         Reviewed by David Kilzer.
3352
3353         * Prepend git branch name to $baseProductDir
3354
3355         * Scripts/VCSUtils.pm:
3356         * Scripts/webkitdirs.pm:
3357
3358 2007-11-20  Mark Rowe  <mrowe@apple.com>
3359
3360         Reviewed by Simon Hausmann.
3361
3362         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
3363         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
3364         Have it trigger a "make distclean" rather than "make clean" to ensure that the
3365         built product and generated Makefile's are removed.
3366
3367 2007-11-19  Alp Toker  <alp@atoker.com>
3368
3369         Reviewed by Mark Rowe.
3370
3371         http://bugs.webkit.org/show_bug.cgi?id=16040
3372         [GTK] GtkLauncher should be written in C
3373
3374         Port GtkLauncher to plain C.
3375
3376         Use a more conventional GTK+ coding style.
3377
3378         Use a toolbar instead of menus.
3379
3380         Various signature fixes and cleanups.
3381
3382         Add a license header. Assume all previous modifications were copyright
3383         assigned to Apple Inc. by default.
3384
3385         * GtkLauncher/GtkLauncher.pro:
3386         * GtkLauncher/main.c: Added.
3387         (activate_url_entry_cb):
3388         (update_title):
3389         (link_hover_cb):
3390         (title_change_cb):
3391         (progress_change_cb):
3392         (destroy_cb):
3393         (go_back_cb):
3394         (go_forward_cb):
3395         (create_browser):
3396         (create_statusbar):
3397         (create_toolbar):
3398         (create_window):
3399         (main):
3400         * GtkLauncher/main.cpp: Removed.
3401
3402 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
3403
3404         Build script fixes to ensure they do the right thing for the 
3405         wx port, and update build-wxwebkit to reflect the way the
3406         build scripts now work.
3407
3408         Reviewed by Adam.
3409
3410         * Scripts/build-testkjs:
3411         * Scripts/build-webkit:
3412         * Scripts/run-javascriptcore-tests:
3413         * Scripts/webkitdirs.pm:
3414         * wx/build-wxwebkit:
3415
3416 2007-11-18  Eric Seidel  <eric@webkit.org>
3417
3418         Reviewed by Anders.
3419
3420         Make run-javascriptcore-tests report failures on exit (to support git bisect)
3421
3422         * Scripts/run-javascriptcore-tests:
3423
3424 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
3425
3426         Reviewed by Adam Roben.
3427
3428         Make run-webkit-tests work with Windows debug build.
3429
3430         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
3431         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
3432         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
3433         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
3434         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
3435
3436 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
3437
3438         Add wxWebKit sample and build script, and integrate it with 
3439         build-webkit. Also make build-webkit --clean work for all
3440         ports.
3441
3442         Reviewed by Darin Adler.
3443
3444         * Scripts/build-webkit:
3445         * Scripts/webkitdirs.pm:
3446         * wx: Added.
3447         * wx/browser: Added.
3448         * wx/browser/browser.bkl: Added.
3449         * wx/browser/browser.cpp: Added.
3450         * wx/build-wxwebkit: Added.
3451
3452 2007-11-17  Adam Roben  <aroben@apple.com>
3453
3454         Make it easy to run Safari in the debugger on Windows
3455
3456         I've added a new script, debug-safari, which launches Safari in the
3457         debugger. On OS X it just calls gdb-safari.
3458
3459         Reviewed by Mark Rowe.
3460
3461         * FindSafari/FindSafari.cpp:
3462         (_tmain): Added a /debugger flag, which in combination with
3463         /printSafariLauncher will print a script that launches Safari in the
3464         debugger.
3465         * Scripts/debug-safari: Added.
3466         * Scripts/run-safari: Changed to call runSafari().
3467         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
3468         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
3469         first argument along to FindSafari.
3470         * Scripts/webkitdirs.pm:
3471         (sub runSafari): Added.
3472
3473 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
3474
3475         Reviewed by Adam Roben.
3476
3477         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
3478
3479 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
3480
3481         Reviewed by David Kilzer.
3482
3483         The git config command was renamed to repo-config at some point. This
3484         change tries git config and then git repo-config if the first fails.
3485
3486         * Scripts/prepare-ChangeLog:
3487         (gitConfig):
3488
3489 2007-11-16  Dan Bernstein  <mitz@apple.com>
3490
3491         Reviewed by Darin Adler and Sam Weinig.
3492
3493         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
3494
3495         * DumpRenderTree/win/EventSender.cpp:
3496         (keyDownCallback): For characters that cannot be entered on the active
3497         keyboard layout, send a WM_CHAR message with the character along with
3498         a WM_KEYDOWN message with a virtual key code of 255.
3499
3500 2007-11-16  Mark Rowe  <mrowe@apple.com>
3501
3502         Reviewed by Tim Hatcher.
3503
3504         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
3505
3506         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3507         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3508
3509 2007-11-15  Adam Roben  <aroben@apple.com>
3510
3511         Make run-safari actually work on Windows
3512
3513         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
3514         chdir call.
3515
3516 2007-11-14  Adam Roben  <aroben@apple.com>
3517
3518         Updates to Safari launching now that 3.0.4 is released
3519
3520         Reviewed by Sam.
3521
3522         * FindSafari/FindSafari.cpp:
3523         (getWebViewCLSID): Use version-independent ProgID.
3524         * Scripts/run-safari: Use run-webkit-nightly.cmd.
3525
3526 2007-11-14  Anders Carlsson  <andersca@apple.com>
3527
3528         Reviewed by Adam.
3529
3530         <rdar://problem/5309081>
3531         In DRT, "plugin.logDestroy = true" not working on Windows.
3532         
3533         * DumpRenderTree/win/TestNetscapePlugin/main.c:
3534         (NPP_Destroy):
3535
3536 2007-11-14  Eric Seidel  <eric@webkit.org>
3537
3538         Reviewed by Sam.
3539
3540         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
3541
3542 2007-11-14  Anders Carlsson  <andersca@apple.com>
3543
3544         Reviewed by Adam.
3545
3546         <rdar://problem/5141186>
3547         window.layoutTestController.setWindowIsKey is not implemented in DRT.
3548         
3549         Implement setWindowIsKey.
3550         
3551         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3552         (LayoutTestController::setWindowIsKey):
3553
3554 2007-11-13  Sam Weinig  <sam@webkit.org>
3555
3556         Reviewed by Adam Roben.
3557
3558         Fix for <rdar://problem/5382579>
3559         http/tests/security/cross-frame-access-put.html reports large 
3560         negative numbers for screenLeft and screenTop (Mac reports "0")
3561
3562         * DumpRenderTree/win/UIDelegate.cpp:
3563         (UIDelegate::UIDelegate): Initialize the RECT.
3564         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
3565         (UIDelegate::webViewFrame): ditto.
3566         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
3567
3568 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
3569
3570         Reviewed by Adam.
3571
3572         - Make Drosera show source, source URLs, and function stack on Windows,
3573         and some minor fixes.
3574
3575         * Drosera/DebuggerDocument.cpp: Force source to always update display.
3576         (DebuggerDocument::updateFileSource):
3577         * Drosera/debugger.js: Force source to always update display.
3578         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
3579         menu controls.
3580         (DebuggerClient::resume):
3581         (DebuggerClient::pause):
3582         (DebuggerClient::stepInto):
3583         (DebuggerClient::stepOver):
3584         (DebuggerClient::stepOut):
3585         (DebuggerClient::showConsole):
3586         (DebuggerClient::closeCurrentFile):
3587         * Drosera/win/DebuggerClient.h: Ditto.
3588         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
3589         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
3590         removed two bugs.  1) caller could be in a bad state when asked to
3591         assign into it. 2) BSTRs were not created correctly.
3592         (DebuggerDocument::getPlatformCurrentFunctionStack):
3593         * Drosera/win/Drosera.cpp: Hook up the menu controls.
3594         (droseraWndProc):
3595         (handleCommand):
3596         (Drosera::resume):
3597         (Drosera::pause):
3598         (Drosera::stepInto):
3599         (Drosera::stepOver):
3600         (Drosera::stepOut):
3601         (Drosera::showConsole):
3602         (Drosera::closeCurrentFile):
3603         * Drosera/win/Drosera.h: Hook up the menu controls.
3604         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
3605         functions, added a null check, and fixed another bug where caller could
3606         be in a bad state when asked to assign into it.
3607         (ServerConnection::didLoadMainResourceForDataSource):
3608         (ServerConnection::getCallerFrame):
3609         * Drosera/win/ServerConnection.h: Safety first.
3610
3611 2007-11-13  Dan Bernstein  <mitz@apple.com>
3612
3613         Reviewed by Darin Adler.
3614
3615         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
3616           DumpRenderTree --pixel-tests renders each test twice
3617
3618         * DumpRenderTree/mac/DumpRenderTree.mm:
3619         (dumpRenderTree): Removed the --paint option because the painting code
3620         is always exercised as a result of
3621         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
3622         calling -displayIfNeeded.
3623         (dump): Changed to always grab the image from the window since the view
3624         is always displayed.
3625         (runTest):
3626         (displayWebView):
3627         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
3628         because it always paints.
3629
3630 2007-11-12  Antti Koivisto  <antti@apple.com>
3631
3632         Reviewed by Adele.
3633         
3634         Add support for http media tests
3635
3636         * Scripts/run-webkit-tests:
3637
3638 2007-11-12  Sam Weinig  <sam@webkit.org>
3639
3640         Reviewed by Adam Roben.
3641
3642         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
3643
3644         * DumpRenderTree/win/DumpRenderTree.cpp:
3645         (runTest):
3646         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3647         (LayoutTestController::setPrivateBrowsingEnabled):
3648
3649 2007-11-12  Adam Roben  <aroben@apple.com>
3650
3651         * Scripts/update-webkit-localizable-strings: Changed to only scan the
3652         mac and win subdirectories.
3653
3654 2007-11-11  Adam Roben  <aroben@apple.com>
3655
3656         Fix <rdar://5133816> keepWebHistory is not implemented
3657
3658         Fixes fast/history/clicked-link-is-visited.html.
3659
3660         Reviewed by Darin.
3661
3662         * DumpRenderTree/win/DumpRenderTree.cpp:
3663         (runTest): Clear the optionalSharedHistory.
3664         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3665         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
3666
3667 2007-11-10  Sam Weinig  <sam@webkit.org>
3668
3669         Reviewed by Tim Hatcher.
3670
3671         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
3672         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
3673         is turned on)
3674
3675         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
3676
3677         Added test: http/tests/security/cross-frame-access-private-browsing.html
3678
3679         * DumpRenderTree/LayoutTestController.cpp:
3680         (setPrivateBrowsingEnabledCallback):
3681         (LayoutTestController::staticFunctions):
3682         * DumpRenderTree/LayoutTestController.h:
3683         * DumpRenderTree/mac/DumpRenderTree.mm:
3684         (runTest): Default to private browsing disabled.
3685         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3686         (LayoutTestController::setPrivateBrowsingEnabled):
3687         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3688         (LayoutTestController::setPrivateBrowsingEnabled):
3689
3690 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3691
3692         Reviewed by Adam.
3693
3694         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
3695         WebCore's!
3696
3697         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3698         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
3699         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3700         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3701         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
3702         * Drosera/win/Drosera.cpp:
3703         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3704
3705 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3706
3707         Reviewed by Sam.
3708
3709         - Use the new IWebFrame [local] function signature and get the shared
3710         server correctly.
3711
3712         * Drosera/win/DebuggerClient.cpp:
3713         (DebuggerClient::didFinishLoadForFrame):
3714         * Drosera/win/ServerConnection.cpp:
3715         (ServerConnection::attemptToCreateServerConnection):
3716
3717 2007-11-07  Dan Bernstein  <mitz@apple.com>
3718
3719         Reviewed by Darin Adler.
3720
3721         - add an option to run-webkit-tests to ignore pixel test failures where
3722           all pixels differ by no more than a specified threshold
3723
3724         * DumpRenderTree/mac/ImageDiff.m:
3725         (main):
3726         (compareImages):
3727         (computePercentageDifferent):
3728         * Scripts/run-webkit-tests:
3729
3730 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3731
3732         Reviewed by Lars.
3733
3734         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
3735
3736         * DumpRenderTree/qt/DumpRenderTree.cpp:
3737
3738 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3739
3740         Reviewed by Lars.
3741
3742         Reworked the QWebSettings API.
3743         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
3744
3745         * DumpRenderTree/qt/DumpRenderTree.cpp:
3746
3747 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3748
3749         Reviewed by Lars.
3750
3751         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
3752
3753         * DumpRenderTree/qt/jsobjects.cpp:
3754
3755 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3756
3757         Reviewed by Lars Knoll <lars@trolltech.com>.
3758
3759         Add a QWebPage::frameCreated() signal and fix DRT
3760         
3761         The removal of createFrame in QWebPage broke the re-implementation
3762         in DumpRenderTree. Instead emit a frameCreated() signal and
3763         connect to it in DumpRenderTree.
3764         
3765
3766         * DumpRenderTree/qt/DumpRenderTree.cpp:
3767         (WebCore::WebPage::WebPage):
3768         (WebCore::DumpRenderTree::dump):
3769         (WebCore::DumpRenderTree::connectFrame):
3770         * DumpRenderTree/qt/DumpRenderTree.h:
3771
3772 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3773
3774         Reviewed by Lars Knoll <lars@trolltech.com>.
3775
3776         Moved all the event handlers from QWebFrame into QWebPage.
3777         
3778         This cleans up the public API and allows us to remove the
3779         HackWebFrame hack in DumpRenderTree.
3780         
3781
3782         * DumpRenderTree/qt/jsobjects.cpp:
3783         (EventSender::mouseDown):
3784         (EventSender::mouseUp):
3785         (EventSender::mouseMoveTo):
3786
3787 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3788
3789         Reviewed by Mark.
3790
3791         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
3792         to prevent the default implementation from popping up messageboxes.
3793
3794         * DumpRenderTree/qt/DumpRenderTree.cpp:
3795         (WebCore::WebPage::javaScriptConfirm):
3796         (WebCore::WebPage::javaScriptPrompt):
3797
3798 2007-11-06  Eric Seidel  <eric@webkit.org>
3799
3800         * Scripts/build-testkjs: build fix... too many $$
3801
3802 2007-11-06  Eric Seidel  <eric@webkit.org>
3803
3804         Reviewed by Mark Rowe.
3805
3806         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
3807
3808 2007-11-05  Adam Roben  <aroben@apple.com>
3809
3810         Add support on Windows for WEBKIT_TESTFONTS
3811
3812         This environment variable lets you specify where the fonts to be used
3813         by DumpRenderTree reside. The Qt port is already using this, so I'm
3814         just following their lead.
3815
3816         Reviewed by Darin.
3817
3818         * DumpRenderTree/win/DumpRenderTree.cpp:
3819         (exePath): Refactored code out of initialize().
3820         (fontsPath): Returns either $WEBKIT_TESTFONTS or
3821         DumpRenderTree.resources.
3822         (initialize): Use the new fontsPath function.
3823         (main): Use the new exePath function.
3824         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
3825         variable to DRT, like Qt does.
3826
3827 2007-11-05  Mark Rowe  <mrowe@apple.com>
3828
3829         Rubber-stamped by Alp Toker.
3830
3831         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
3832
3833         * GtkLauncher/main.cpp:
3834         (goToURLBarText):
3835         (main):
3836
3837 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
3838
3839         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
3840         <http://bugs.webkit.org/show_bug.cgi?id=15830>
3841
3842         Reviewed by Timothy.
3843
3844         Restrict the range of nightly builds used by the bisect-builds script
3845         based on the version of Safari and the version of Mac OS X being used.
3846
3847         Mac OS X 10.4: Safari 2.0: r11976 or newer
3848         Mac OS X 10.4: Safari 3.0: r19992 or newer
3849
3850         Mac OS X 10.5: Safari 2.0: r19594 or newer
3851         Mac OS X 10.5: Safari 3.0: r25124 or newer
3852
3853         * Scripts/bisect-builds:
3854         (findMacOSXVersion): Added.
3855         (makeNightlyList): Added argument to provide version of Mac OS X.
3856         Restrict range of nightly builds based on Safari and Mac OS X versions.
3857
3858 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
3859
3860         Reviewed by Maciej.
3861
3862         - This patch involves several changes, all of them were noticed that
3863         they were needed by the work being done in WebKit to get Drosera and
3864         WebKit working together on Windows.
3865         - The changes are:
3866         1) Added a debugger console for output messages.
3867         2) Drosera now listens for the WebKit server (before, the server would
3868         have to be running before Drosera was started.)
3869         3) Fixed a bug where the WebView started out as 0x0 pixels.
3870         4) Fixed a bug when there is no scope.
3871         5) Added the HTML, JS, and CSS to the project file to make them easy to
3872         find.
3873         6) Made the ServerConnection functions virtual.
3874
3875         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
3876         for the WebKit server.
3877         (DebuggerClient::DebuggerClient):
3878         (DebuggerClient::~DebuggerClient):
3879         (DebuggerClient::didFinishLoadForFrame):
3880         (DebuggerClient::serverConnected):
3881         (DebuggerClient::attemptToCreateServerConnection):
3882         * Drosera/win/DebuggerClient.h: Ditto.
3883         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
3884         scope.
3885         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3886         (DebuggerDocument::platformValueForScopeVariableNamed):
3887         * Drosera/win/Drosera.cpp:
3888         (_tWinMain): Added a console in debug for output messages.
3889         (Drosera::Drosera): Listen for server.
3890         (Drosera::initUI): The server now Initializes COM.
3891         (Drosera::serverConnected): Part of the listening for the server.
3892         (Drosera::attemptToCreateServerConnection): Ditto.
3893         * Drosera/win/Drosera.h: New interface for listening for the server.
3894         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
3895         files to the VS project.
3896         * Drosera/win/ServerConnection.cpp: Part of listening for the server
3897         connection.
3898         (ServerConnection::ServerConnection):
3899         (ServerConnection::attemptToCreateServerConnection):
3900         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
3901         methods.
3902         (ServerConnection::serverConnected):
3903
3904 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
3905
3906         Reviewed by Maciej.
3907
3908         http://bugs.webkit.org/show_bug.cgi?id=15832
3909         fast/dom/gc-10.html crashes when run alone
3910
3911         Check for !done before using objects that can be already deallocated.
3912
3913         * DumpRenderTree/mac/EditingDelegate.mm:
3914         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3915         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3916         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3917         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3918         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3919         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3920         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3921         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3922         (-[EditingDelegate webViewDidBeginEditing:]):
3923         (-[EditingDelegate webViewDidChange:]):
3924         (-[EditingDelegate webViewDidEndEditing:]):
3925         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3926         (-[EditingDelegate webViewDidChangeSelection:]):
3927         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3928         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3929         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3930         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3931         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3932         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3933         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3934         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3935         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3936         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3937         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3938         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3939         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3940         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3941         (-[FrameLoadDelegate webView:willCloseFrame:]):
3942         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3943         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3944         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3945         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3946         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3947         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3948         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3949         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3950         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3951
3952 2007-11-04  Mark Rowe  <mrowe@apple.com>
3953
3954         Build fix.  Don't use Carbon.h as the prefix header as it triggers
3955         warnings that would otherwise be suppressed due to it being a system header.
3956
3957         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3958
3959 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
3960
3961         Rubber stamped by Adam.
3962         
3963         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
3964
3965         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3966
3967 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3968
3969         Sort files(...); sections of Xcode project files.
3970
3971         Rubber-stamped by Darin.
3972
3973         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3974         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3975         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3976         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3977
3978 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3979
3980         Script to sort "files(...);" sections in Xcode project.pbxproj files.
3981
3982         Reviewed by Darin.
3983
3984         * Scripts/sort-Xcode-project-file: Added.
3985
3986 2007-11-02  Darin Adler  <darin@apple.com>
3987
3988         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
3989
3990 2007-11-02  Darin Adler  <darin@apple.com>
3991
3992         Reviewed by Maciej.
3993
3994         * Scripts/run-sunspider: Pass the "--base" option through.
3995
3996         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
3997         the real script do that. Default configuration to Release to match run-sunspider
3998         so we don't end up building Debug just to compare results.
3999
4000 2007-11-01  Adam Roben  <aroben@apple.com>
4001
4002         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
4003
4004         Reviewed by Sam.
4005
4006         * Scripts/commit-log-editor: Show all the directories beneath the
4007         source root, instead of just the last one.
4008
4009 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
4010
4011         Reviewed by Adam Roben.
4012
4013         Print out an error message when the Windows build fails
4014         and provide guidance on how to find out what went wrong.
4015
4016         * Scripts/build-webkit:
4017         * Scripts/webkitdirs.pm:
4018
4019 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
4020
4021         Rubber-stamped by Adam Roben.
4022
4023         Rolled out r27326 - debug CRT seems to cause no problems after all.
4024
4025         * DumpRenderTree/win/DumpRenderTree.vcproj:
4026
4027 2007-10-31  Adam Roben  <aroben@apple.com>
4028
4029         Switch the Debug configuration to using the non-debug CRT
4030
4031         This matches WebKit.
4032
4033         Reviewed by Steve.
4034
4035         * DumpRenderTree/win/DumpRenderTree.vcproj:
4036
4037 2007-10-31  Antti Koivisto  <antti@apple.com>
4038
4039         Reviewed by bdash.
4040         
4041         Disable media tests when doing leak checking on Tiger.
4042         They crash in QuickTime (rdar://problem/5537157).
4043
4044         * Scripts/run-webkit-tests:
4045
4046 2007-10-29  Antti Koivisto  <antti@apple.com>
4047
4048         Reviewed by Maciej.
4049         
4050         Build media support by default on OSX only.
4051
4052         * Scripts/build-webkit:
4053
4054 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
4055
4056         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
4057         get caught by the pre-commit hooks.
4058
4059 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
4060
4061         Reviewed by Adam.
4062
4063         - This is a collection of relatively unrelated changes and cleanups
4064         to Drosera to prepare it for interacting with WebKit.  A lot of these
4065         changes are just correcting mistakes, for example removing included
4066         headers that are no longer needed.
4067
4068         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
4069         this will be needed by the DebuggerClient.
4070         (DebuggerDocument::server):
4071         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
4072         * Drosera/win/DebuggerClient.cpp: 
4073         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
4074         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
4075         (DebuggerClient::createWebViewWithRequest): Added comment about its
4076         purpose. 
4077         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
4078         declarations.
4079         (DebuggerClient::webViewLoaded): Moved.
4080         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
4081         file, since this was the only place it was used.
4082         (cfStringToBSTR):
4083         * Drosera/win/Drosera.h: Cleaned up the includes.
4084         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
4085         * Drosera/win/HelperFunctions.h: Removed.
4086
4087 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
4088
4089         Reviewed by Adam.
4090
4091         - Small cleanup in the ServerConnection class.
4092
4093         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
4094         and added an include.
4095         (ServerConnection::currentFrame):
4096         (ServerConnection::getCallerFrame):
4097         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
4098         made a pointer into a COMPtr, and cleaned up the includes.
4099
4100 2007-10-29  Timothy Hatcher  <timothy@apple.com>
4101
4102         Reviewed by John Sullivan.
4103         
4104         - Place the Localizable.strings file in mac or win directories
4105           if that location exists.
4106         - Also look for UI_STRING in .c files.
4107
4108         * Scripts/extract-localizable-strings:
4109
4110 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
4111
4112         Reviewed by Adam.
4113
4114         - Set the eol-style to native and made all the line endings the same
4115         so that I avoid messy diffs that show eol changes.
4116
4117         * Drosera/win/ServerConnection.cpp:
4118         (ServerConnection::didParseSource):
4119         (ServerConnection::didEnterCallFrame):
4120         (ServerConnection::willExecuteStatement):
4121         (ServerConnection::willLeaveCallFrame):
4122         (ServerConnection::exceptionWasRaised):
4123
4124 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
4125
4126         Reviewed by Adam.
4127
4128         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
4129         functionality that could not have existed previously without the new
4130         interfaces.
4131         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
4132         from a BSTR to a JSValueRef.
4133         (DebuggerDocument::platformEvaluateScript): Implemented.
4134         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
4135         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
4136         Implemented.
4137         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
4138         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
4139         * Drosera/win/ServerConnection.cpp: Added a helper function.
4140         (ServerConnection::getCallerFrame):
4141         * Drosera/win/ServerConnection.h: Added a helper function.
4142
4143 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
4144
4145         updated reviewers for my previous changelog.
4146
4147 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
4148         Reviewed by Maciej and Adam and Geoff.
4149
4150         - Minor mac-side improvements including moving a function to a more
4151         appropriate location, fixing a warning, and correctly checking
4152         exceptions.
4153
4154         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
4155         (DebuggerDocument::willExecuteStatement):
4156         (DebuggerDocument::didEnterCallFrame):
4157         (DebuggerDocument::willLeaveCallFrame):
4158         (DebuggerDocument::windowScriptObjectAvailable):
4159         (DebuggerDocument::callFunctionOnObject):
4160         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
4161         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
4162         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
4163         because it doesn't require the ServerConnection at all.
4164         (NSStringCreateWithJSStringRef): Made an argument const.
4165         (JSValueRefCreateWithNSString): Made an argument const.
4166         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
4167         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
4168         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
4169         * Drosera/mac/ServerConnection.mm: Ditto.
4170         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
4171
4172 2007-10-29  Sam Weinig  <sam@webkit.org>
4173
4174         Reviewed by Adam Roben.
4175
4176         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
4177
4178         * DumpRenderTree/LayoutTestController.cpp:
4179         (LayoutTestController::LayoutTestController):
4180         (getGlobalFlagCallback):
4181         (setGlobalFlagCallback):
4182         (LayoutTestController::getJSClass):
4183         (LayoutTestController::staticValues):
4184         * DumpRenderTree/LayoutTestController.h:
4185         (LayoutTestController::globalFlag):
4186         (LayoutTestController::setGlobalFlag):
4187
4188 2007-10-29  Darin Adler  <darin@apple.com>
4189
4190         Reviewed by Maciej.
4191
4192         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
4193         resolution instead of its default.
4194
4195 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
4196
4197         Fixed showStatus() to print status for successfully resolved conflicts when using git.
4198
4199         Reviewed by Mark Rowe.
4200
4201         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
4202         was successfully resolved, but this would not show any status because the change had
4203         already been cached in the index using "git add".  The solution is to add an optional
4204         second argument to showStatus() which adds the "--cached" switch to the command.
4205
4206         * Scripts/resolve-ChangeLogs:
4207         (showStatus):
4208
4209 2007-10-28  Eric Seidel  <eric@webkit.org>
4210
4211         Reviewed by Maciej and Geoff, in unison.
4212
4213         * Scripts/run-webkit-tests: remove broken --svg option
4214
4215 2007-10-28  Darin Adler  <darin@apple.com>
4216
4217         Reviewed by Adam.
4218
4219         * Scripts/run-sunspider: Default to "Release" configuration rather than
4220         defaulting to the last configuration used as other scripts do. This can
4221         still be overriden on the command line with "--debug" if there's some
4222         reason to do so. Also fix a typo.
4223
4224         * Scripts/sunspider-compare-results: Fix a typo.
4225
4226 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
4227
4228         Reviewed by Adam.
4229
4230         - Implemented the WebScriptDebugListener functions now that the
4231         WebScriptDebugServer exists
4232
4233         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
4234         functions.
4235         (ServerConnection::currentFrame):
4236         (ServerConnection::didLoadMainResourceForDataSource):
4237         (ServerConnection::didParseSource):
4238         (ServerConnection::failedToParseSource):
4239         (ServerConnection::didEnterCallFrame):
4240         (ServerConnection::willExecuteStatement):
4241         (ServerConnection::willLeaveCallFrame):
4242         (ServerConnection::exceptionWasRaised):
4243         * Drosera/win/ServerConnection.h: Removed unused arguments from the
4244         members arguments list.
4245
4246 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
4247
4248         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
4249         <http://bugs.webkit.org/show_bug.cgi?id=15600>
4250
4251         Reviewed by Darin.
4252
4253         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
4254         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
4255         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
4256         file.  Note that it may also be used as a stand-alone script.
4257
4258         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
4259         * Scripts/resolve-ChangeLogs: Added.
4260         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
4261
4262 2007-10-26  Mark Rowe  <mrowe@apple.com>
4263
4264         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
4265         to the Qt port on the assumption that it was an implementation of the cross-platform
4266         LayoutTestController class.  It is not, so it did not need to be changed.
4267
4268         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
4269
4270 2007-10-25  Mark Rowe  <mrowe@apple.com>
4271
4272         Reviewed by Maciej.
4273
4274         Fix builds with code coverage enabled.
4275
4276         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
4277
4278 2007-10-25  Darin Adler  <darin@apple.com>
4279
4280         Reviewed by Mark Rowe.
4281
4282         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
4283         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
4284
4285 2007-10-25  Stephanie  <slewis@apple.com>
4286
4287         build Fix
4288
4289         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4290
4291 2007-10-25  Stephanie  <slewis@apple.com>
4292
4293         Reviewed by Mark Rowe, Adam Roben.
4294
4295         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
4296
4297         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
4298
4299 2007-10-25  Alice Liu  <alice.liu@apple.com>
4300
4301         Reviewed by Adam.
4302
4303         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
4304
4305         Moving destructor into platform-specific files
4306         * DumpRenderTree/LayoutTestController.cpp:
4307         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4308         (LayoutTestController::~LayoutTestController):
4309         * DumpRenderTree/qt/jsobjects.cpp:
4310         (LayoutTestController::~LayoutTestController):
4311
4312         LayoutTestController wasn't being destroyed
4313         * DumpRenderTree/win/DumpRenderTree.cpp:
4314         (runTest):
4315
4316         Added declspec
4317         * DumpRenderTree/win/EditingDelegate.h:
4318
4319         Reset certain values on the webview (or related delegate) that might 
4320         have changed while running a test
4321         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4322         (LayoutTestController::~LayoutTestController):