WebKitTools/ChangeLog

   1 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
   2
   3         Reviewed by Adam Roben.
   4
   5         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
   6
   7         * FindSafari/FindSafari.cpp:
   8         (_tmain):
   9
  10 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
  11
  12         Reviewed by Adam Roben.
  13
  14         http://bugs.webkit.org/show_bug.cgi?id=16315
  15         FindSafari needs a path-only option.
  16
  17         * FindSafari/FindSafari.cpp:
  18         (_tmain):
  19
  20 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
  21
  22         Reviewed by Darin.
  23
  24         http://bugs.webkit.org/show_bug.cgi?id=16462
  25         REGRESSION: access keys broken on Windows
  26
  27         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
  28         if Alt is pressed.
  29
  30 2007-12-15  Sam Weinig  <sam@webkit.org>
  31
  32         Reviewed by Mark Rowe.
  33
  34         Fix urlSuitableForTestResult to correctly identify wstring::npos as
  35         the case when wstring.find doesn't find anything.
  36
  37         * DumpRenderTree/win/DumpRenderTree.cpp:
  38         (urlSuitableForTestResult):
  39
  40 2007-12-15  Alp Toker  <alp@atoker.com>
  41
  42         GTK+ DRT build fix for GLib < 2.14.
  43
  44         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  45         (LayoutTestController::setWaitToDump):
  46
  47 2007-12-05  Mark Rowe  <mrowe@apple.com>
  48
  49         Reviewed by Alp Toker.
  50
  51         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
  52         many layout tests from hanging while waiting on user responses to dialogs.
  53
  54         * DumpRenderTree/gtk/DumpRenderTree.cpp:
  55         (invalidateAnyPreviousWaitToDumpWatchdog):
  56         (webViewScriptAlert):
  57         (webViewScriptPrompt):
  58         (webViewScriptConfirm):
  59         (main):
  60         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
  61         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  62         (waitToDumpWatchdogFired):
  63         (LayoutTestController::setWaitToDump):
  64
  65 2007-12-05  Mark Rowe  <mrowe@apple.com>
  66
  67         Reviewed by Alp Toker.
  68
  69         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
  70
  71         * DumpRenderTree/gtk/DumpRenderTree.cpp:
  72         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
  73         (dump):
  74         (runTest):
  75         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
  76         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
  77         work queue is empty.
  78         (webViewWindowObjectCleared): Set up window.layoutTestController.
  79         (webViewConsoleMessage): Match the console message format expected by the layout test results.
  80         (main): Hook up the new signals.
  81         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
  82         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
  83         dumping multiple times.
  84         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
  85         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
  86
  87 2007-12-14  Anders Carlsson  <andersca@apple.com>
  88
  89         Reviewed by Brady.
  90
  91         Assert that a web frame that's loading a resource always has either a data source or
  92         a provisional data source.
  93
  94         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
  95         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
  96
  97 2007-12-14  Darin Adler  <darin@apple.com>
  98
  99         - fix mistake causing nearly all tests to fail on Windows
 100
 101         * DumpRenderTree/win/UIDelegate.cpp:
 102         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
 103         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
 104
 105         * DumpRenderTree/mac/UIDelegate.mm:
 106         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
 107         than passing the entire message.
 108
 109 2007-12-14  Darin Adler  <darin@apple.com>
 110
 111         - fix Tiger build
 112
 113         * DumpRenderTree/mac/UIDelegate.mm:
 114         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
 115         new-to-Leopard methods.
 116
 117 2007-12-14  Darin Adler  <darin@apple.com>
 118
 119         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
 120         since it now triggers unwanted icon loading. We only had it because we implemented "all"
 121         delegate methods here.
 122
 123 2007-12-14  Anders Carlsson  <andersca@apple.com>
 124
 125         Reviewed by Darin and Geoff.
 126
 127         <rdar://problem/5619295>
 128         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
 129
 130         Add property getting methods to the plug-in.
 131
 132         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 133         (pluginInvoke):
 134
 135 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
 136
 137         Reviewed by Darin.
 138
 139         - Layout test fix for mac. When dumped to the console local file paths
 140         now only show the name of the resource not the whole path.  This is to
 141         make the results machine and OS independent.
 142
 143         * DumpRenderTree/mac/UIDelegate.mm:
 144         (-[UIDelegate webView:addMessageToConsole:]):
 145
 146 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
 147
 148         Reviewed by Adam.
 149
 150         - Layout tests fix.  We need a way to remove machine-dependent
 151         information from paths in layout test results. The UIDelegate now does
 152         this.
 153
 154         * DumpRenderTree/DumpRenderTree.h:
 155         * DumpRenderTree/win/DumpRenderTree.cpp:
 156         (urlSuitableForTestResult):
 157         * DumpRenderTree/win/DumpRenderTreeWin.h:
 158         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
 159         * DumpRenderTree/win/UIDelegate.cpp:
 160         (UIDelegate::webViewAddMessageToConsole):
 161
 162 2007-12-13  Alp Toker  <alp@atoker.com>
 163
 164         Build fix for DRT breakage introduced in r28690.
 165
 166         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 167         (LayoutTestController::pathToLocalResource):
 168
 169 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
 170
 171         Reviewed by Alice and Sam.
 172
 173         - <rdar://5621435> Need a way to specify local resources (being loaded
 174         from HTTP tests) on Windows.
 175         - Implemented pathToLocalResource which exposes the functionality of
 176         converting a given unix path to the correct location on Windows.
 177
 178         * DumpRenderTree/LayoutTestController.cpp:
 179         (pathToLocalResourceCallback):
 180         (LayoutTestController::staticFunctions):
 181         * DumpRenderTree/LayoutTestController.h:
 182         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 183         (LayoutTestController::pathToLocalResource):
 184         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 185         (LayoutTestController::pathToLocalResource):
 186
 187 2007-12-12  Anders Carlsson  <andersca@apple.com>
 188
 189         Reviewed by Sam.
 190
 191         <rdar://problem/5132003>
 192         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
 193
 194         * DumpRenderTree/win/DumpRenderTree.cpp:
 195         (main):
 196         Set the resource load delegate.
 197
 198         * DumpRenderTree/win/DumpRenderTree.vcproj:
 199
 200         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
 201         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
 202
 203 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
 204
 205         Reviewed by Adam Roben.
 206
 207         Fix conversion from double to LPARAM in dispatchMessage().
 208
 209         * DumpRenderTree/win/EventSender.cpp:
 210         (dispatchMessageCallback):
 211
 212 2007-12-11  Dan Bernstein  <mitz@apple.com>
 213
 214         Reviewed by Mark Rowe and Sam Weinig too!
 215
 216         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
 217           fonts DumpRenderTree registers.
 218
 219         * DumpRenderTree/win/DumpRenderTree.cpp:
 220         (initialize):
 221
 222 2007-12-11  Brady Eidson  <beidson@apple.com>
 223
 224         Reviewed by Anders
 225
 226         Make DumpRenderTree on mac use its own path for Databases testing
 227
 228         * DumpRenderTree/mac/DumpRenderTree.mm:
 229         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree
 230           for future DRT-only use, then use it to construct the Databases path and set that default
 231
 232 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
 233
 234         Reviewed by Darin.
 235
 236         <rdar://problem/5535636>
 237         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
 238
 239         http://bugs.webkit.org/show_bug.cgi?id=13916
 240         JavaScript detects Tab as a character input on a textfield validation
 241
 242         * DumpRenderTree/mac/EventSendingController.mm:
 243         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
 244         Dispatch a keyup to better match what happens when a key is physically pressed.
 245
 246         * DumpRenderTree/win/EventSender.cpp:
 247         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
 248         returning from keyDown().
 249         (getConstantCallback): Fixed a couple copy/paste mistakes.
 250
 251 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
 252
 253         Reviewed by Oliver.
 254
 255         - <rdar://5599845> Drosera: Does not show loal files in the file list
 256         on the left side.
 257
 258         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
 259         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
 260         so the open source community can build.
 261
 262 2007-12-10  Brady Eidson  <beidson@apple.com>
 263
 264         Rubberstamped by Sam Weinig
 265
 266         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
 267
 268         * DumpRenderTree/mac/UIDelegate.mm:
 269         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
 270         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
 271
 272 2007-12-08  Oliver Hunt  <oliver@apple.com>
 273
 274         Reviewed by Sam W.
 275
 276         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
 277
 278         Fixes <rdar://problem/5620249> Must disable SVG animation
 279         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
 280
 281         In order to allow finer grained control over the set of SVG features
 282         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
 283         distinct flags:
 284         ENABLE_SVG_ANIMATION
 285         ENABLE_SVG_FILTERS
 286         ENABLE_SVG_FONTS
 287         ENABLE_SVG_AS_IMAGE
 288         ENABLE_SVG_USE
 289
 290         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
 291
 292         Script handles all the new build flags, and allows --svg-experimental
 293         to automatically enable all features.
 294
 295         * Scripts/build-webkit:
 296
 297 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
 298
 299         Fix version parsing.
 300
 301         Rubber-stamped by Oliver.
 302
 303         * Drosera/win/Drosera.vcproj/auto-version.sh:
 304
 305 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
 306
 307         Build modifications for Drosera.
 308
 309         Reviewed by Adam.
 310
 311         * Drosera/DroseraWin.make: Added.
 312         * Drosera/win/Drosera.vcproj/Drosera.rc:
 313         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 314         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
 315         * Drosera/win/Drosera.vcproj/VERSION: Added.
 316         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
 317
 318 2007-12-06  Adam Roben  <aroben@apple.com>
 319
 320         Explicitly turn on the Mac font ascent hack on Windows
 321
 322         This keeps our font metrics matching those from Mac.
 323
 324         Reviewed by Hyatt.
 325
 326         * DumpRenderTree/win/DumpRenderTree.cpp:
 327         (main):
 328
 329 2007-12-06  Anders Carlsson  <andersca@apple.com>
 330
 331         Rename main.c to main.cpp here too.
 332
 333         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
 334
 335 2007-12-06  Sam Weinig  <sam@webkit.org>
 336
 337         Rubber stamped by Geoff.
 338
 339         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
 340
 341 2007-12-06  Darin Adler  <darin@apple.com>
 342
 343         * Scripts/do-webcore-rename: Some more renaming plans.
 344
 345 2007-12-06  Anders Carlsson  <andersca@apple.com>
 346
 347         Restore implementation of testGetIntIdentifier that was accidentally
 348         removed somehow (possibly when I made PluginObject be a cpp file).
 349
 350         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 351         (pluginInvoke):
 352
 353 2007-12-05  Anders Carlsson  <andersca@apple.com>
 354
 355         Make the entry points extern "C".
 356         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
 357
 358 2007-12-05  Anders Carlsson  <andersca@apple.com>
 359
 360         C++ warning fixes.
 361
 362         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
 363         (NPP_New):
 364         (NPP_Destroy):
 365         (NPP_SetWindow):
 366         (NPP_NewStream):
 367         (NPP_HandleEvent):
 368         (NPP_URLNotify):
 369         (NPP_GetValue):
 370
 371 2007-12-05  Anders Carlsson  <andersca@apple.com>
 372
 373         Add the .cpp files to the TestNetscapePlugIn target.
 374
 375         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 376
 377 2007-12-05  Anders Carlsson  <andersca@apple.com>
 378
 379         Reviewed by Geoff.
 380
 381         Rename the TestNetscapePlugIn .c files to be .cpp.
 382
 383         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 384         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
 385         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
 386         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
 387         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
 388         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
 389         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
 390         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
 391
 392 2007-12-05  Adam Roben  <aroben@apple.com>
 393
 394         Fix case of keypresses from the Windows implementation of eventSender.keyDown
 395
 396         This fixes several regression tests.
 397
 398         Reviewed by Alice.
 399
 400         * DumpRenderTree/win/EventSender.cpp:
 401         (keyDownCallback): Virtual keycodes for ASCII characters are always
 402         uppercase, so we need to check the case of the original character
 403         passed in to eventSender.keyDown.
 404
 405 2007-12-05  Adam Roben  <aroben@apple.com>
 406
 407         Learn from Tim's mistakes
 408
 409         * DumpRenderTree/win/DumpRenderTree.cpp:
 410         (runTest): Reset the authorAndUserStylesEnabled preference for each
 411         test.
 412
 413 2007-12-05  Alp Toker  <alp@atoker.com>
 414
 415         Reviewed by Mark Rowe.
 416
 417         Initialize GTK+ and WebKit so the tests can run.
 418
 419         Reorganize the headers a little.
 420
 421         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 422         (main):
 423
 424 2007-12-04  Anders Carlsson  <andersca@apple.com>
 425
 426         Remove IWebScriptScope include.
 427
 428         * Drosera/win/DebuggerDocumentPlatform.cpp:
 429
 430 2007-12-04  Sam Weinig  <sam@webkit.org>
 431
 432         Rubber stamped by Mark Rowe.
 433
 434         Define CF as platform for mac and revert r28409
 435
 436         * DumpRenderTree/DumpRenderTree.h:
 437         * DumpRenderTree/mac/DumpRenderTreeMac.h:
 438
 439 2007-12-04  Sam Weinig  <sam@webkit.org>
 440
 441         Define CF as platform for windows.
 442
 443         Reviewed by Adam Roben.
 444
 445         * DumpRenderTree/win/DumpRenderTreeWin.h:
 446
 447 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
 448
 449         Reviewed by Adam and Darin.
 450
 451         - Removed a needless BSTR cleanup.
 452
 453         * Drosera/win/DebuggerDocumentPlatform.cpp:
 454         (DebuggerDocument::getPlatformCurrentFunctionStack):
 455
 456 2007-11-27  Adam Roben  <aroben@apple.com>
 457
 458         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
 459
 460         Reviewed by Maciej.
 461
 462         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 463         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
 464
 465 2007-12-04  Alp Toker  <alp@atoker.com>
 466
 467         Prospective Win DRT build fix.
 468
 469         * DumpRenderTree/DumpRenderTree.h:
 470
 471 2007-12-04  Alp Toker  <alp@atoker.com>
 472
 473         Fix a clobbered copyright header.
 474
 475         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 476
 477 2007-12-04  Xan Lopez  <xan@gnome.org>
 478
 479         Reviewed by Alp Toker.
 480
 481         http://bugs.webkit.org/show_bug.cgi?id=15561
 482         GTK port needs DumpRenderTree implementation
 483
 484         Start work on the GTK+ DRT.
 485
 486         This does not work yet, and there are a few lingering style issues
 487         (nothing major) but this patch has been stuck in the bug tracker for
 488         too long already.
 489
 490         * DumpRenderTree/DumpRenderTree.h:
 491         * DumpRenderTree/gtk: Added.
 492         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
 493         (autocorrectURL):
 494         (shouldLogFrameLoadDelegates):
 495         (dumpFrameScrollPosition):
 496         (displayWebView):
 497         (appendString):
 498         (dumpFramesAsText):
 499         (dumpRenderTreeAsText):
 500         (dump):
 501         (runTest):
 502         (main):
 503         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
 504         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
 505         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
 506         (GCController::collect):
 507         (GCController::collectOnAlternateThread):
 508         (GCController::getJSObjectCount):
 509         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
 510         (LayoutTestController::~LayoutTestController):
 511         (LayoutTestController::addDisallowedURL):
 512         (LayoutTestController::clearBackForwardList):
 513         (LayoutTestController::copyDecodedHostName):
 514         (LayoutTestController::copyEncodedHostName):
 515         (LayoutTestController::display):
 516         (LayoutTestController::keepWebHistory):
 517         (LayoutTestController::notifyDone):
 518         (LayoutTestController::queueBackNavigation):
 519         (LayoutTestController::queueForwardNavigation):
 520         (LayoutTestController::queueLoad):
 521         (LayoutTestController::queueReload):
 522         (LayoutTestController::queueScript):
 523         (LayoutTestController::setAcceptsEditing):
 524         (LayoutTestController::setCustomPolicyDelegate):
 525         (LayoutTestController::setMainFrameIsFirstResponder):
 526         (LayoutTestController::setTabKeyCyclesThroughElements):
 527         (LayoutTestController::setUseDashboardCompatibilityMode):
 528         (LayoutTestController::setUserStyleSheetEnabled):
 529         (LayoutTestController::setUserStyleSheetLocation):
 530         (LayoutTestController::setWindowIsKey):
 531         (LayoutTestController::setWaitToDump):
 532         (LayoutTestController::windowCount):
 533         (LayoutTestController::setPrivateBrowsingEnabled):
 534         (LayoutTestController::setAuthorAndUserStylesEnabled):
 535         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
 536         (JSStringCopyUTF8CString):
 537         (LoadItem::invoke):
 538         (ReloadItem::invoke):
 539         (ScriptItem::invoke):
 540         (BackForwardItem::invoke):
 541
 542 2007-12-03  Sam Weinig  <sam@webkit.org>
 543
 544         Move JavaScriptCore thread testing code to pthread specific directory
 545         and remove the dependance on CoreFoundation by using WTF::HashSet.
 546
 547         Reviewed by Geoff and Oliver.
 548
 549         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 550         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
 551         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
 552         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
 553         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
 554         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
 555         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
 556         * DumpRenderTree/pthreads: Added.
 557         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
 558         (javaScriptThreads):
 559         (runJavaScriptThread):
 560         (startJavaScriptThreads):
 561         (stopJavaScriptThreads):
 562
 563 2007-12-03  Andrew Bonventre  <andybons@google.com>
 564
 565         Reviewed by Darin Adler.
 566
 567         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
 568         Symbol lookup menu broken in debugger view
 569
 570         * Drosera/debugger.js: Fixed javascript error where document property
 571         should have been used instead of contentDocument in switchFunction that
 572         was breaking the select symbol dropdown menu.  This is because
 573         window.frames will return a Window object and not a frame object like
 574         the author was originally expecting.
 575
 576 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
 577
 578         Reviewed by Adam.
 579
 580         - <rdar://5618942> Drosera: Console window does not process everything
 581         correctly.
 582         - <rdar://5619005> Drosera: could be sped up by moving the
 583         WebScriptScope stuff into the WebScriptCallFrame.
 584         - Now the console can correctly process objects and does not receive
 585         notifications from JavaScriptCore about the JavaScript in Drosera's
 586         own process.
 587
 588         * Drosera/win/DebuggerDocumentPlatform.cpp:
 589         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 590         (DebuggerDocument::platformValueForScopeVariableNamed):
 591
 592 2007-12-03  Stephanie  <slewis@apple.com>
 593
 594         Reviewed by Darin.
 595
 596         Check to see if we are building a debug root
 597
 598         * Scripts/check-for-global-initializers:
 599
 600 2007-12-03  Dan Bernstein  <mitz@apple.com>
 601
 602         Reviewed by Darin Adler.
 603
 604         - added a testGetIntIdentifier() method to TestNetscapePlugIn
 605
 606         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
 607         (pluginInvoke):
 608
 609 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
 610
 611         Reviewed by Oliver.
 612
 613         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
 614         in a more fine-grained manner than eventSender.keyDown().
 615
 616         * DumpRenderTree/win/EventSender.cpp:
 617         (getConstantCallback):
 618         (dispatchMessageCallback):
 619
 620 2007-12-02  Darin Adler  <darin@apple.com>
 621
 622         * Scripts/do-webcore-rename: More planned renaming.
 623
 624 2007-12-02  Sam Weinig  <sam@webkit.org>
 625
 626         Rubber stamped by Anders.
 627
 628         Use [NSURL absoluteString] instead of [NSURL description] in order to get
 629         more uniform results cross platform.
 630
 631         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 632         (-[NSURL _drt_descriptionSuitableForTestResult]):
 633
 634 2007-12-02  Sam Weinig  <sam@webkit.org>
 635
 636         Rubber stamped by Niko.
 637
 638         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
 639
 640         * DumpRenderTree/win/DumpRenderTree.cpp:
 641         * DumpRenderTree/win/DumpRenderTree.vcproj:
 642         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
 643         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
 644         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
 645         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
 646
 647 2007-12-01  Alp Toker  <alp@atoker.com>
 648
 649         Reviewed by Adam Roben.
 650
 651         Make use of the newly introduced webkit.h convenience header.
 652
 653         * GtkLauncher/main.c:
 654
 655 2007-12-01  Adam Treat  <treat@kde.org>
 656
 657         Reviewed by Simon.
 658
 659         * Check to see if the directory exists and exit if not.
 660
 661         * DumpRenderTree/qt/main.cpp:
 662         (main):
 663
 664 2007-12-01  Adam Treat  <treat@kde.org>
 665
 666         Reviewed by Simon.
 667
 668         * Don't hide symbols when in Debug mode
 669         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
 670
 671
 672         * DumpRenderTree/qt/main.cpp:
 673         (messageHandler):
 674
 675 2007-11-30  Alp Toker  <alp@atoker.com>
 676
 677         Reviewed by Adam Roben.
 678
 679         http://bugs.webkit.org/show_bug.cgi?id=15691
 680         [GTK] Public API does not follow GTK+ conventions
 681
 682         Refactor the WebKit/GTK+ public API. Changes:
 683           WebKitPage -> WebKitWebView
 684           WebKitFrame -> WebKitWebFrame
 685
 686         Public API source and header names have been updated to mirror the API
 687         changes.
 688
 689         The API is now kept in WebKit/gtk/WebView to match other ports in the
 690         same class such as Mac and Win.
 691
 692         * GtkLauncher/main.c:
 693         (activate_uri_entry_cb):
 694         (link_hover_cb):
 695         (title_change_cb):
 696         (progress_change_cb):
 697         (go_back_cb):
 698         (go_forward_cb):
 699         (create_browser):
 700         (main):
 701
 702 2007-11-30  Adam Roben  <aroben@apple.com>
 703
 704         Hopefully the final build fix
 705
 706         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
 707         pull in WTF's assertion/logging functions.
 708
 709 2007-11-30  Adam Roben  <aroben@apple.com>
 710
 711         Another build fix
 712
 713         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
 714         WebKit.lib.
 715
 716 2007-11-30  Adam Roben  <aroben@apple.com>
 717
 718         Debug build fix
 719
 720         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
 721         configuration.
 722         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
 723         projects.
 724         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
 725         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
 726         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
 727
 728 2007-11-30  Sam Weinig  <sam@webkit.org>
 729
 730         Reviewed by Adam Roben.
 731
 732         Fix drawSelectionRect to actually draw the selection rect.
 733
 734         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 735         (drawSelectionRect):
 736
 737 2007-11-30  Darin Adler  <darin@apple.com>
 738
 739         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
 740
 741 2007-11-30  Darin Adler  <darin@apple.com>
 742
 743         * Scripts/do-webcore-rename: Get ready for some future renaming.
 744
 745 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 746
 747         Reviewed by Adam.
 748
 749         - Removed some unnecessary functions and changed an unused return type.
 750
 751         * Drosera/win/DebuggerClient.cpp:
 752         (registerConsoleClass):
 753         * Drosera/win/DebuggerClient.h:
 754         * Drosera/win/Drosera.cpp:
 755         (registerDroseraClass):
 756
 757 2007-11-28  Alp Toker  <alp@atoker.com>
 758
 759         Reviewed by Timothy Hatcher.
 760
 761         http://bugs.webkit.org/show_bug.cgi?id=16174
 762         [GTK] Use "URI" not "URL" in public API
 763
 764         Replace use of the term "URL" with "URI" in public headers,
 765         documentation and some internal code to match GLib/GTK+ convention.
 766
 767         This is now mentioned in the API guidelines:
 768           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
 769
 770         * GtkLauncher/main.c:
 771         (activate_uri_entry_cb):
 772         (title_change_cb):
 773         (create_toolbar):
 774         (main):
 775
 776 2007-11-29  Anders Carlsson  <andersca@apple.com>
 777
 778         Reviewed by Sam.
 779
 780         <rdar://problem/5230478>
 781         FrameLoadDelegate callbacks are not dumped in DRT.
 782
 783         * DumpRenderTree/win/DumpRenderTree.cpp:
 784         (shouldLogFrameLoadDelegates):
 785         (runTest):
 786         (main):
 787         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
 788         (BSTRtoString):
 789         (descriptionSuitableForTestResult):
 790         (FrameLoadDelegate::QueryInterface):
 791         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
 792         (FrameLoadDelegate::didFailProvisionalLoadWithError):
 793         (FrameLoadDelegate::didCommitLoadForFrame):
 794         (FrameLoadDelegate::didFinishLoadForFrame):
 795         (FrameLoadDelegate::willCloseFrame):
 796         (FrameLoadDelegate::didClearWindowObject):
 797         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
 798         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
 799         * DumpRenderTree/win/FrameLoaderDelegate.h:
 800         (FrameLoadDelegate::windowScriptObjectAvailable):
 801         (FrameLoadDelegate::didFirstLayoutInFrame):
 802
 803 2007-11-29  Sam Weinig  <sam@webkit.org>
 804
 805         Reviewed by Anders.
 806
 807         Add database quota UIDelegates methods to DRT UIDelegate.
 808
 809         * DumpRenderTree/mac/UIDelegate.mm:
 810         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
 811         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
 812
 813 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 814
 815         Reviewed by Sam.
 816
 817         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
 818         dying and vice versa.
 819         - This fix will allow Drosera and Safari to reconnect if either of them
 820         closes correctly, but does not fix the case where one of them dies
 821         silently.
 822
 823         * Drosera/win/ServerConnection.cpp:
 824         (ServerConnection::attemptToCreateServerConnection): Added a safety
 825         check, because it's possilbe to try to connect to a server that's dying.
 826         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
 827         the server has died.
 828         * Drosera/win/ServerConnection.h: Added the new function and removed
 829         an unnecessary member.
 830
 831 2007-11-29  Anders Carlsson  <andersca@apple.com>
 832
 833         * DumpRenderTree/win/DumpRenderTree.vcproj:
 834         Add shlwapi.lib to all configurations.
 835
 836 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 837
 838         - Build fix.  Added additional includes for VS Express to the Release
 839         project.
 840
 841         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 842
 843 2007-11-29  Anders Carlsson  <andersca@apple.com>
 844
 845         Reviewed by Adam.
 846
 847         <rdar://problem/5132005>
 848         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
 849
 850         * DumpRenderTree/win/DumpRenderTree.vcproj:
 851         Add shlwapi.lib
 852
 853         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 854         (LayoutTestController::setUserStyleSheetEnabled):
 855         Implement this.
 856
 857         (appendComponentToPath):
 858         New method which wraps the Win32 API PathAppend.
 859
 860         (followShortcuts):
 861         New method which checks if a file points to a shortcut and
 862         follows the shortcut.
 863
 864         (resolveCygwinPath):
 865         New method that takes a cygwin unix-style path and returns the Win32 path.
 866
 867         (cfStringRefToWString):
 868
 869         (LayoutTestController::setUserStyleSheetLocation):
 870         Implement this.
 871
 872 2007-11-29  Alice Liu  <alice.liu@apple.com>
 873
 874         Reviewed by Adam.
 875
 876         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
 877
 878         * DumpRenderTree/win/EventSender.cpp:
 879         (keyDownCallback):
 880         uppercase letters were being sent as lowercase letters without the shift key down.
 881
 882 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 883
 884         - Windows build fix. VS express needs some love.
 885
 886         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 887
 888 2007-11-28  Darin Adler  <darin@apple.com>
 889
 890         Reviewed by Adam Roben.
 891
 892         * DumpRenderTree/mac/EventSendingController.mm:
 893         (-[EventSendingController keyDown:withModifiers:]):
 894         Send capital letters through as lowercase letters with the shift key down
 895         rather than sending them as if they were highly unusual "capital letter keys".
 896
 897         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
 898         where you need to update results and more tests are failing than before.
 899
 900 2007-11-28  Anders Carlsson  <andersca@apple.com>
 901
 902         Reviewed by Darin.
 903
 904         <rdar://problem/5132001>
 905         contextClick is not implemented in DRT on Windows.
 906
 907         * DumpRenderTree/win/EventSender.cpp:
 908         (contextClickCallback):
 909         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
 910         by a WM_RBUTTONUP message.
 911
 912         * DumpRenderTree/win/UIDelegate.cpp:
 913         (UIDelegate::hasCustomMenuImplementation):
 914         (UIDelegate::trackCustomPopupMenu):
 915         * DumpRenderTree/win/UIDelegate.h:
 916         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
 917         menu from being shown (and causing the DRT to hang).
 918
 919 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
 920
 921         Reviewed by Darin.
 922
 923         Fix DumpRenderTree ObjC bug comparing strings.
 924
 925         * DumpRenderTree/mac/ObjCController.m:
 926         (-[ObjCController identityIsEqual::]): Compare strings with string
 927         equality instead of identiy equality.
 928
 929 2007-11-27  Timothy Hatcher  <timothy@apple.com>
 930
 931         Reviewed by Sam.
 932
 933         Reset the authorAndUserStylesEnabled preference
 934         back to YES for each test. Fixes the broken tests.
 935
 936         * DumpRenderTree/mac/DumpRenderTree.mm:
 937         (resetWebViewToConsistentStateBeforeTesting):
 938
 939 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
 940
 941         Reviewed by Adam.
 942
 943         - Drosera now displays the console window, although it cannot currently
 944         process JavaScript.
 945
 946         * Drosera/win/DebuggerClient.cpp: Shows the console window.
 947         (registerConsoleClass): Implemented.
 948         (consoleWndProc): Implemented.
 949         (DebuggerClient::onSize): Implemented.
 950         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
 951         new window.
 952         * Drosera/win/DebuggerClient.h: Added needed method and members for
 953         creating and maintaining a new window.
 954         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
 955         lines of code to more appropriate places.
 956         (Drosera::handleCommand):
 957         (Drosera::initUI):
 958         (Drosera::onSize):
 959         (Drosera::attach):
 960
 961 2007-11-27  Timothy Hatcher  <timothy@apple.com>
 962
 963         Reviewed by Dave Hyatt.
 964
 965         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
 966
 967         Add support for disabling author and user styles for testing.
 968
 969         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 970         * DumpRenderTree/LayoutTestController.cpp:
 971         (setAuthorAndUserStylesEnabledCallback):
 972         (LayoutTestController::staticFunctions):
 973         * DumpRenderTree/LayoutTestController.h:
 974         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 975         (LayoutTestController::setAuthorAndUserStylesEnabled):
 976         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 977         (LayoutTestController::setAuthorAndUserStylesEnabled):
 978
 979 2007-11-26  Dan Bernstein  <mitz@apple.com>
 980
 981         - Tiger build fix.
 982
 983         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 984
 985 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
 986
 987         Reviewed by Maciej.
 988
 989         - Implemented displaying variables for Drosera on Win.
 990
 991         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
 992         that retrieve variables to not hold onto the return value since it's
 993         not returned.  Also changed to use the new signatures of the retrieval
 994         functions.
 995         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 996         (DebuggerDocument::platformValueForScopeVariableNamed):
 997         * Drosera/win/Drosera.cpp: Removed a needless TODO.
 998         (droseraWndProc):
 999
1000 2007-11-26  Sam Weinig  <sam@webkit.org>
1001
1002         Cleanup names of painting and repainting functions.
1003
1004         Reviewed by Adam Roben.
1005
1006         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1007         (drawSelectionRect): was drawSelectionRectIntoContext.
1008         (dumpWebViewAsPixelsAndCompareWithExpected):
1009         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1010         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1011         (paintWebView): was drawWebViewIntoContext.
1012         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1013
1014 2007-11-26  Sam Weinig  <sam@webkit.org>
1015
1016         Reviewed by Dan Bernstein.
1017
1018         - Leopard build fix
1019
1020         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1021
1022 2007-11-26  Sam Weinig  <sam@webkit.org>
1023
1024         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1025         Use shared PixelDumpSupport for Mac DRT
1026
1027         Reviewed by Adam Roben.
1028
1029         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1030         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1031         * DumpRenderTree/cg/ImageDiffCG.cpp:
1032         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1033         (drawSelectionRectIntoContext):
1034         (dumpWebViewAsPixelsAndCompareWithExpected):
1035         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1036         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1037         * DumpRenderTree/mac/DumpRenderTree.mm:
1038         (dump):
1039         * DumpRenderTree/mac/ImageDiff.m: Removed.
1040         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1041         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1042         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1043         (setDefaultColorProfileToRGB):
1044         (getBitmapContextFromWebView):
1045         (drawWebViewIntoContext):
1046         (repaintWithVerticalSweep):
1047         (repaintWithHorizontalSweep):
1048         (getSelectionRect):
1049         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1050
1051 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1052
1053         Bug 16052: prepare-ChangeLog doesn't report deleted files
1054         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1055
1056         Reviewed by Sam.
1057
1058         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1059
1060 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1061
1062         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1063         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1064
1065         Reviewed by Adam.
1066
1067         Roll functionality of merge-changelog into resolve-ChangeLogs
1068         script.  The script now checks for ChangeLog.rej and
1069         ChangeLog.orig files first.  If it finds them, it uses the
1070         ChangeLog.rej file as a patch (in old contextual diff format) to
1071         apply with --fuzz=3.
1072
1073         * Scripts/merge-changelog: Removed.
1074         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1075
1076 2007-11-25  Sam Weinig  <sam@webkit.org>
1077
1078         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1079
1080         Reviewed by Mark Rowe.
1081
1082         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1083         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1084         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1085         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1086         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1087
1088 2007-11-25  Sam Weinig  <sam@webkit.org>
1089
1090         Convert DumpRenderTree to ues .xcconfig files.
1091
1092         Reviewed by Mark Rowe.
1093
1094         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1095         * DumpRenderTree/mac/Configurations: Added.
1096         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1097         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1098         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1099
1100 2007-11-25  Sam Weinig  <sam@webkit.org>
1101
1102         Add ForwardingHeaders to wtf for DumpRenderTree.
1103
1104         Reviewed by Mark Rowe.
1105
1106         * DumpRenderTree/DumpRenderTree.h:
1107         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1108         * DumpRenderTree/ForwardingHeaders: Added.
1109         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1110         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1111         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1112         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1113         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1114         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1115         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1116         * DumpRenderTree/LayoutTestController.cpp:
1117         * DumpRenderTree/WorkQueue.cpp:
1118         * DumpRenderTree/mac/DumpRenderTree.mm:
1119         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1120         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1121         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1122         * DumpRenderTree/mac/ObjCController.m:
1123         * DumpRenderTree/mac/UIDelegate.mm:
1124         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1125
1126 2007-11-25  Adam Roben  <aroben@apple.com>
1127
1128         Fix some test failures caused by r28019
1129
1130         Now that stdout is in binary mode, we need to always use printf
1131         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1132         the output.
1133
1134         Reviewed by Sam.
1135
1136         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1137         printf.
1138         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1139         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1140         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1141         (UIDelegate::webViewAddMessageToConsole):
1142
1143 2007-11-25  Adam Roben  <aroben@apple.com>
1144
1145         Set the font smoothing preference in DRT
1146
1147         This makes the pixel results on Windows closer to the Mac results.
1148
1149         Reviewed by Mitz.
1150
1151         * DumpRenderTree/win/DumpRenderTree.cpp:
1152         (initializePreferences):
1153
1154 2007-11-25  Adam Roben  <aroben@apple.com>
1155
1156         Port ImageDiff to CG and C++
1157
1158         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1159         <rdar://5071708>
1160
1161         Reviewed by Sam.
1162
1163         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1164         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1165         (main):
1166         (createImageFromStdin):
1167         (compareImages):
1168         (getDifferenceBitmap):
1169         (computePercentageDifferent):
1170         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1171
1172 2007-11-25  Adam Roben  <aroben@apple.com>
1173
1174         Fix image diff link generation on Windows
1175
1176         Reviewed by Sam.
1177
1178         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1179         to toURL.
1180
1181 2007-11-25  Adam Roben  <aroben@apple.com>
1182
1183         Implement pixel dumping in Windows DRT
1184
1185         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1186         <rdar://5071708>
1187
1188         Reviewed by Sam.
1189
1190         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1191         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1192         Content-Length header.
1193         (getMD5HashStringForBitmap):
1194         (dumpWebViewAsPixelsAndCompareWithExpected):
1195         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1196         * DumpRenderTree/win/DumpRenderTree.cpp:
1197         (dump): Do a pixel dump if requested.
1198         (main): Parse pixel test options.
1199         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1200         the cg/ subdirectory to the include path.
1201         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1202         available in a header or import library, so we have to go through this
1203         LoadLibrary/GetProcAddress dance to use them.
1204         (cryptDLL):
1205         (init):
1206         (update):
1207         (final):
1208         (MD5_Init):
1209         (MD5_Update):
1210         (MD5_Final):
1211         * DumpRenderTree/win/MD5.h: Added.
1212         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1213         moved up to the top level to share it with Mac eventually.
1214         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1215         (getBitmapContextFromWebView): Forces the WebView to paint using a
1216         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1217
1218 2007-11-25  Adam Roben  <aroben@apple.com>
1219
1220         Clean up Windows DRT's option parsing a little bit
1221
1222         Reviewed by Sam.
1223
1224         * DumpRenderTree/win/DumpRenderTree.cpp:
1225         (main): Put non-option arguments into a Vector.
1226
1227 2007-11-25  Adam Roben  <aroben@apple.com>
1228
1229         Make Windows DRT stop changing LF into CRLF
1230
1231         Reviewed by Sam.
1232
1233         * DumpRenderTree/win/DumpRenderTree.cpp:
1234         (main): Put stdout in binary mode.
1235         * Scripts/run-webkit-tests: Remove the CRLF hack.
1236
1237 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1238
1239         Removed empty directory.
1240
1241         * Scripts/resources: Removed.
1242
1243 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1244
1245         Fix bisect-builds to work with recent WebKit nightly builds.
1246
1247         Reviewed by Dan.
1248
1249         * Scripts/bisect-builds: Check for the
1250         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1251         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1252         to WebKit.app/Contents/Resources.
1253
1254 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1255
1256         Reviewed by Maciej.
1257
1258         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1259         not closed (affects digg.com)
1260
1261         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1262         one after finishing with a test to avoid having its delayed onload handler firing when
1263         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1264         but it helps somewhat.
1265
1266 2007-11-22  Mark Rowe  <mrowe@apple.com>
1267
1268         Reviewed by Alp Toker.
1269
1270         Fix build-webkit to propagate make's exit status if it fails.
1271
1272         * Scripts/webkitdirs.pm:
1273
1274 2007-11-22  Dan Bernstein  <mitz@apple.com>
1275
1276         Reviewed by Mark Rowe.
1277
1278         - fix crash when running pixel tests
1279
1280         * DumpRenderTree/mac/DumpRenderTree.mm:
1281         (dumpRenderTree): Parse the command line options before setting up the
1282         environment so that we know if we need to set up the pixel dump
1283         machinery.
1284
1285 2007-11-21  Eric Seidel  <eric@webkit.org>
1286
1287         Speculative build fix for Tiger.
1288
1289         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1290
1291 2007-11-21  Eric Seidel  <eric@webkit.org>
1292
1293         Reviewed by Tim Hatcher.
1294
1295         Break out more of DumpRenderTree.mm into individual files
1296
1297         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1298         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1299         (checkedMalloc):
1300         (checkedRealloc):
1301         (makeLargeMallocFailSilently):
1302         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1303         * DumpRenderTree/mac/DumpRenderTree.mm:
1304         (crashHandler):
1305         (dump):
1306         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1307         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1308         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1309         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1310         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1311         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1312         (javaScriptThreads):
1313         (runJavaScriptThread):
1314         (startJavaScriptThreads):
1315         (stopJavaScriptThreads):
1316         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1317         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1318         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1319         (restoreColorSpace):
1320         (setDefaultColorProfileToRGB):
1321         (initializeColorSpaceAndScreeBufferForPixelTests):
1322         (md5HashStringForBitmap):
1323         (dumpWebViewAsPixelsAndCompareWithExpected):
1324
1325 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1326
1327         Move install-unix-extras to wx directory as it seems only to be used by that
1328         port now. It now supports universal binaries on Mac and adds libpng and libjpeg.
1329         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1330         have install-unix-extras install into WebKitLibraries as per
1331         convention.
1332
1333         Reviewed by Mark Rowe.
1334
1335         * Scripts/install-unix-extras: Removed.
1336         * wx/build-wxwebkit:
1337         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1338
1339 2007-11-21  Eric Seidel  <eric@webkit.org>
1340
1341         Reviewed by Adam.
1342
1343         More refactoring for greater code readability
1344
1345         * DumpRenderTree/mac/DumpRenderTree.mm:
1346         (initializeGlobalsFromCommandLineOptions):
1347         (initializeColorSpaceAndScreeBufferForPixelTests):
1348         (addTestPluginsToPluginSearchPath):
1349         (useLongRunningServerMode):
1350         (runTestingServerLoop):
1351         (prepareConsistentTestingEnvironment):
1352         (dumpRenderTree):
1353         (main):
1354         (dumpFramesAsText):
1355         (dumpBackForwardListForWebView):
1356         (sizeWebViewForCurrentTest):
1357         (methodNameStringForFailedTest):
1358         (dumpBackForwardListForAllWindows):
1359         (dumpWebViewAsPixelsAndCompareWithExpected):
1360         (invalidateAnyPreviousWaitToDumpWatchdog):
1361         (dump):
1362         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1363         * DumpRenderTree/mac/UIDelegate.mm:
1364         (-[UIDelegate webView:createWebViewWithRequest:]):
1365
1366 2007-11-21  Eric Seidel  <eric@webkit.org>
1367
1368         Reviewed by Tim Hatcher.
1369
1370         Abstract more of DRT into static methods
1371
1372         * DumpRenderTree/mac/DumpRenderTree.mm:
1373         (setDefaultsToConsistentValuesForTesting):
1374         (setupSignalHandlers):
1375         (allocateGlobalControllers):
1376         (releaseAndZero):
1377         (releaseGlobalControllers):
1378         (dumpRenderTree):
1379         (shouldLogFrameLoadDelegates):
1380         (createCFURLFromPathOrURL):
1381         (resetWebViewToConsistentStateBeforeTesting):
1382         (runTest):
1383
1384 2007-11-21  Eric Seidel  <eric@webkit.org>
1385
1386         Reviewed by Tim Hatcher.
1387
1388         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1389
1390         * DumpRenderTree/DumpRenderTree.h:
1391         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1392         * DumpRenderTree/mac/DumpRenderTree.mm:
1393         (dumpRenderTree):
1394         (dump):
1395         (runTest):
1396         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1397         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1398         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1399         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1400         (-[DumpRenderTreePasteboard declareType:owner:]):
1401         (+[LocalPasteboard alloc]):
1402         (-[LocalPasteboard init]):
1403         (-[LocalPasteboard dealloc]):
1404         (-[LocalPasteboard name]):
1405         (-[LocalPasteboard releaseGlobally]):
1406         (-[LocalPasteboard declareTypes:owner:]):
1407         (-[LocalPasteboard addTypes:owner:]):
1408         (-[LocalPasteboard changeCount]):
1409         (-[LocalPasteboard types]):
1410         (-[LocalPasteboard availableTypeFromArray:]):
1411         (-[LocalPasteboard setData:forType:]):
1412         (-[LocalPasteboard dataForType:]):
1413         (-[LocalPasteboard setPropertyList:forType:]):
1414         (-[LocalPasteboard setString:forType:]):
1415         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1416         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1417         (+[DumpRenderTreeWindow allWindows]):
1418         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1419         (-[DumpRenderTreeWindow dealloc]):
1420         (-[DumpRenderTreeWindow isKeyWindow]):
1421         (-[DumpRenderTreeWindow keyDown:]):
1422
1423 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1424
1425         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1426         it indiscriminately copies any headers inside JavaScriptCore,
1427         which includes Tiger ICU headers.
1428
1429         * wx/build-wxwebkit:
1430         Don't run WebCore/move-js-headers.sh any longer.
1431
1432 2007-11-20  Adam Treat  <treat@kde.org>
1433
1434         Reviewed by David Kilzer.
1435
1436         * Prepend git branch name to $baseProductDir
1437
1438         * Scripts/VCSUtils.pm:
1439         * Scripts/webkitdirs.pm:
1440
1441 2007-11-20  Mark Rowe  <mrowe@apple.com>
1442
1443         Reviewed by Simon Hausmann.
1444
1445         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1446         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1447         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1448         built product and generated Makefile's are removed.
1449
1450 2007-11-19  Alp Toker  <alp@atoker.com>
1451
1452         Reviewed by Mark Rowe.
1453
1454         http://bugs.webkit.org/show_bug.cgi?id=16040
1455         [GTK] GtkLauncher should be written in C
1456
1457         Port GtkLauncher to plain C.
1458
1459         Use a more conventional GTK+ coding style.
1460
1461         Use a toolbar instead of menus.
1462
1463         Various signature fixes and cleanups.
1464
1465         Add a license header. Assume all previous modifications were copyright
1466         assigned to Apple Inc. by default.
1467
1468         * GtkLauncher/GtkLauncher.pro:
1469         * GtkLauncher/main.c: Added.
1470         (activate_url_entry_cb):
1471         (update_title):
1472         (link_hover_cb):
1473         (title_change_cb):
1474         (progress_change_cb):
1475         (destroy_cb):
1476         (go_back_cb):
1477         (go_forward_cb):
1478         (create_browser):
1479         (create_statusbar):
1480         (create_toolbar):
1481         (create_window):
1482         (main):
1483         * GtkLauncher/main.cpp: Removed.
1484
1485 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1486
1487         Build script fixes to ensure they do the right thing for the
1488         wx port, and update build-wxwebkit to reflect the way the
1489         build scripts now work.
1490
1491         Reviewed by Adam.
1492
1493         * Scripts/build-testkjs:
1494         * Scripts/build-webkit:
1495         * Scripts/run-javascriptcore-tests:
1496         * Scripts/webkitdirs.pm:
1497         * wx/build-wxwebkit:
1498
1499 2007-11-18  Eric Seidel  <eric@webkit.org>
1500
1501         Reviewed by Anders.
1502
1503         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1504
1505         * Scripts/run-javascriptcore-tests:
1506
1507 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1508
1509         Reviewed by Adam Roben.
1510
1511         Make run-webkit-tests work with Windows debug build.
1512
1513         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1514         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1515         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1516         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1517         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1518
1519 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1520
1521         Add wxWebKit sample and build script, and integrate it with
1522         build-webkit. Also make build-webkit --clean work for all
1523         ports.
1524
1525         Reviewed by Darin Adler.
1526
1527         * Scripts/build-webkit:
1528         * Scripts/webkitdirs.pm:
1529         * wx: Added.
1530         * wx/browser: Added.
1531         * wx/browser/browser.bkl: Added.
1532         * wx/browser/browser.cpp: Added.
1533         * wx/build-wxwebkit: Added.
1534
1535 2007-11-17  Adam Roben  <aroben@apple.com>
1536
1537         Make it easy to run Safari in the debugger on Windows
1538
1539         I've added a new script, debug-safari, which launches Safari in the
1540         debugger. On OS X it just calls gdb-safari.
1541
1542         Reviewed by Mark Rowe.
1543
1544         * FindSafari/FindSafari.cpp:
1545         (_tmain): Added a /debugger flag, which in combination with
1546         /printSafariLauncher will print a script that launches Safari in the
1547         debugger.
1548         * Scripts/debug-safari: Added.
1549         * Scripts/run-safari: Changed to call runSafari().
1550         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1551         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1552         first argument along to FindSafari.
1553         * Scripts/webkitdirs.pm:
1554         (sub runSafari): Added.
1555
1556 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1557
1558         Reviewed by Adam Roben.
1559
1560         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.
1561
1562 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1563
1564         Reviewed by David Kilzer.
1565
1566         The git config command was renamed to repo-config at some point. This
1567         change tries git config and then git repo-config if the first fails.
1568
1569         * Scripts/prepare-ChangeLog:
1570         (gitConfig):
1571
1572 2007-11-16  Dan Bernstein  <mitz@apple.com>
1573
1574         Reviewed by Darin Adler and Sam Weinig.
1575
1576         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1577
1578         * DumpRenderTree/win/EventSender.cpp:
1579         (keyDownCallback): For characters that cannot be entered on the active
1580         keyboard layout, send a WM_CHAR message with the character along with
1581         a WM_KEYDOWN message with a virtual key code of 255.
1582
1583 2007-11-16  Mark Rowe  <mrowe@apple.com>
1584
1585         Reviewed by Tim Hatcher.
1586
1587         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1588
1589         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1590         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1591
1592 2007-11-15  Adam Roben  <aroben@apple.com>
1593
1594         Make run-safari actually work on Windows
1595
1596         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1597         chdir call.
1598
1599 2007-11-14  Adam Roben  <aroben@apple.com>
1600
1601         Updates to Safari launching now that 3.0.4 is released
1602
1603         Reviewed by Sam.
1604
1605         * FindSafari/FindSafari.cpp:
1606         (getWebViewCLSID): Use version-independent ProgID.
1607         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1608
1609 2007-11-14  Anders Carlsson  <andersca@apple.com>
1610
1611         Reviewed by Adam.
1612
1613         <rdar://problem/5309081>
1614         In DRT, "plugin.logDestroy = true" not working on Windows.
1615
1616         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1617         (NPP_Destroy):
1618
1619 2007-11-14  Eric Seidel  <eric@webkit.org>
1620
1621         Reviewed by Sam.
1622
1623         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1624
1625 2007-11-14  Anders Carlsson  <andersca@apple.com>
1626
1627         Reviewed by Adam.
1628
1629         <rdar://problem/5141186>
1630         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1631
1632         Implement setWindowIsKey.
1633
1634         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1635         (LayoutTestController::setWindowIsKey):
1636
1637 2007-11-13  Sam Weinig  <sam@webkit.org>
1638
1639         Reviewed by Adam Roben.
1640
1641         Fix for <rdar://problem/5382579>
1642         http/tests/security/cross-frame-access-put.html reports large
1643         negative numbers for screenLeft and screenTop (Mac reports "0")
1644
1645         * DumpRenderTree/win/UIDelegate.cpp:
1646         (UIDelegate::UIDelegate): Initialize the RECT.
1647         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1648         (UIDelegate::webViewFrame): ditto.
1649         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1650
1651 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1652
1653         Reviewed by Adam.
1654
1655         - Make Drosera show source, source URLs, and function stack on Windows,
1656         and some minor fixes.
1657
1658         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1659         (DebuggerDocument::updateFileSource):
1660         * Drosera/debugger.js: Force source to always update display.
1661         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1662         menu controls.
1663         (DebuggerClient::resume):
1664         (DebuggerClient::pause):
1665         (DebuggerClient::stepInto):
1666         (DebuggerClient::stepOver):
1667         (DebuggerClient::stepOut):
1668         (DebuggerClient::showConsole):
1669         (DebuggerClient::closeCurrentFile):
1670         * Drosera/win/DebuggerClient.h: Ditto.
1671         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1672         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1673         removed two bugs.  1) caller could be in a bad state when asked to
1674         assign into it. 2) BSTRs were not created correctly.
1675         (DebuggerDocument::getPlatformCurrentFunctionStack):
1676         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1677         (droseraWndProc):
1678         (handleCommand):
1679         (Drosera::resume):
1680         (Drosera::pause):
1681         (Drosera::stepInto):
1682         (Drosera::stepOver):
1683         (Drosera::stepOut):
1684         (Drosera::showConsole):
1685         (Drosera::closeCurrentFile):
1686         * Drosera/win/Drosera.h: Hook up the menu controls.
1687         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1688         functions, added a null check, and fixed another bug where caller could
1689         be in a bad state when asked to assign into it.
1690         (ServerConnection::didLoadMainResourceForDataSource):
1691         (ServerConnection::getCallerFrame):
1692         * Drosera/win/ServerConnection.h: Safety first.
1693
1694 2007-11-13  Dan Bernstein  <mitz@apple.com>
1695
1696         Reviewed by Darin Adler.
1697
1698         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1699           DumpRenderTree --pixel-tests renders each test twice
1700
1701         * DumpRenderTree/mac/DumpRenderTree.mm:
1702         (dumpRenderTree): Removed the --paint option because the painting code
1703         is always exercised as a result of
1704         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1705         calling -displayIfNeeded.
1706         (dump): Changed to always grab the image from the window since the view
1707         is always displayed.
1708         (runTest):
1709         (displayWebView):
1710         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1711         because it always paints.
1712
1713 2007-11-12  Antti Koivisto  <antti@apple.com>
1714
1715         Reviewed by Adele.
1716
1717         Add support for http media tests
1718
1719         * Scripts/run-webkit-tests:
1720
1721 2007-11-12  Sam Weinig  <sam@webkit.org>
1722
1723         Reviewed by Adam Roben.
1724
1725         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1726
1727         * DumpRenderTree/win/DumpRenderTree.cpp:
1728         (runTest):
1729         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1730         (LayoutTestController::setPrivateBrowsingEnabled):
1731
1732 2007-11-12  Adam Roben  <aroben@apple.com>
1733
1734         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1735         mac and win subdirectories.
1736
1737 2007-11-11  Adam Roben  <aroben@apple.com>
1738
1739         Fix <rdar://5133816> keepWebHistory is not implemented
1740
1741         Fixes fast/history/clicked-link-is-visited.html.
1742
1743         Reviewed by Darin.
1744
1745         * DumpRenderTree/win/DumpRenderTree.cpp:
1746         (runTest): Clear the optionalSharedHistory.
1747         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1748         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1749
1750 2007-11-10  Sam Weinig  <sam@webkit.org>
1751
1752         Reviewed by Tim Hatcher.
1753
1754         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
1755         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
1756         is turned on)
1757
1758         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1759
1760         Added test: http/tests/security/cross-frame-access-private-browsing.html
1761
1762         * DumpRenderTree/LayoutTestController.cpp:
1763         (setPrivateBrowsingEnabledCallback):
1764         (LayoutTestController::staticFunctions):
1765         * DumpRenderTree/LayoutTestController.h:
1766         * DumpRenderTree/mac/DumpRenderTree.mm:
1767         (runTest): Default to private browsing disabled.
1768         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1769         (LayoutTestController::setPrivateBrowsingEnabled):
1770         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1771         (LayoutTestController::setPrivateBrowsingEnabled):
1772
1773 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1774
1775         Reviewed by Adam.
1776
1777         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1778         WebCore's!
1779
1780         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1781         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1782         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1783         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1784         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1785         * Drosera/win/Drosera.cpp:
1786         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1787
1788 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1789
1790         Reviewed by Sam.
1791
1792         - Use the new IWebFrame [local] function signature and get the shared
1793         server correctly.
1794
1795         * Drosera/win/DebuggerClient.cpp:
1796         (DebuggerClient::didFinishLoadForFrame):
1797         * Drosera/win/ServerConnection.cpp:
1798         (ServerConnection::attemptToCreateServerConnection):
1799
1800 2007-11-07  Dan Bernstein  <mitz@apple.com>
1801
1802         Reviewed by Darin Adler.
1803
1804         - add an option to run-webkit-tests to ignore pixel test failures where
1805           all pixels differ by no more than a specified threshold
1806
1807         * DumpRenderTree/mac/ImageDiff.m:
1808         (main):
1809         (compareImages):
1810         (computePercentageDifferent):
1811         * Scripts/run-webkit-tests:
1812
1813 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1814
1815         Reviewed by Lars.
1816
1817         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1818
1819         * DumpRenderTree/qt/DumpRenderTree.cpp:
1820
1821 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1822
1823         Reviewed by Lars.
1824
1825         Reworked the QWebSettings API.
1826         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1827
1828         * DumpRenderTree/qt/DumpRenderTree.cpp:
1829
1830 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1831
1832         Reviewed by Lars.
1833
1834         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1835
1836         * DumpRenderTree/qt/jsobjects.cpp:
1837
1838 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1839
1840         Reviewed by Lars Knoll <lars@trolltech.com>.
1841
1842         Add a QWebPage::frameCreated() signal and fix DRT
1843
1844         The removal of createFrame in QWebPage broke the re-implementation
1845         in DumpRenderTree. Instead emit a frameCreated() signal and
1846         connect to it in DumpRenderTree.
1847
1848
1849         * DumpRenderTree/qt/DumpRenderTree.cpp:
1850         (WebCore::WebPage::WebPage):
1851         (WebCore::DumpRenderTree::dump):
1852         (WebCore::DumpRenderTree::connectFrame):
1853         * DumpRenderTree/qt/DumpRenderTree.h:
1854
1855 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1856
1857         Reviewed by Lars Knoll <lars@trolltech.com>.
1858
1859         Moved all the event handlers from QWebFrame into QWebPage.
1860
1861         This cleans up the public API and allows us to remove the
1862         HackWebFrame hack in DumpRenderTree.
1863
1864
1865         * DumpRenderTree/qt/jsobjects.cpp:
1866         (EventSender::mouseDown):
1867         (EventSender::mouseUp):
1868         (EventSender::mouseMoveTo):
1869
1870 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1871
1872         Reviewed by Mark.
1873
1874         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1875         to prevent the default implementation from popping up messageboxes.
1876
1877         * DumpRenderTree/qt/DumpRenderTree.cpp:
1878         (WebCore::WebPage::javaScriptConfirm):
1879         (WebCore::WebPage::javaScriptPrompt):
1880
1881 2007-11-06  Eric Seidel  <eric@webkit.org>
1882
1883         * Scripts/build-testkjs: build fix... too many $$
1884
1885 2007-11-06  Eric Seidel  <eric@webkit.org>
1886
1887         Reviewed by Mark Rowe.
1888
1889         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1890
1891 2007-11-05  Adam Roben  <aroben@apple.com>
1892
1893         Add support on Windows for WEBKIT_TESTFONTS
1894
1895         This environment variable lets you specify where the fonts to be used
1896         by DumpRenderTree reside. The Qt port is already using this, so I'm
1897         just following their lead.
1898
1899         Reviewed by Darin.
1900
1901         * DumpRenderTree/win/DumpRenderTree.cpp:
1902         (exePath): Refactored code out of initialize().
1903         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1904         DumpRenderTree.resources.
1905         (initialize): Use the new fontsPath function.
1906         (main): Use the new exePath function.
1907         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1908         variable to DRT, like Qt does.
1909
1910 2007-11-05  Mark Rowe  <mrowe@apple.com>
1911
1912         Rubber-stamped by Alp Toker.
1913
1914         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1915
1916         * GtkLauncher/main.cpp:
1917         (goToURLBarText):
1918         (main):
1919
1920 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1921
1922         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1923         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1924
1925         Reviewed by Timothy.
1926
1927         Restrict the range of nightly builds used by the bisect-builds script
1928         based on the version of Safari and the version of Mac OS X being used.
1929
1930         Mac OS X 10.4: Safari 2.0: r11976 or newer
1931         Mac OS X 10.4: Safari 3.0: r19992 or newer
1932
1933         Mac OS X 10.5: Safari 2.0: r19594 or newer
1934         Mac OS X 10.5: Safari 3.0: r25124 or newer
1935
1936         * Scripts/bisect-builds:
1937         (findMacOSXVersion): Added.
1938         (makeNightlyList): Added argument to provide version of Mac OS X.
1939         Restrict range of nightly builds based on Safari and Mac OS X versions.
1940
1941 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1942
1943         Reviewed by Maciej.
1944
1945         - This patch involves several changes, all of them were noticed that
1946         they were needed by the work being done in WebKit to get Drosera and
1947         WebKit working together on Windows.
1948         - The changes are:
1949         1) Added a debugger console for output messages.
1950         2) Drosera now listens for the WebKit server (before, the server would
1951         have to be running before Drosera was started.)
1952         3) Fixed a bug where the WebView started out as 0x0 pixels.
1953         4) Fixed a bug when there is no scope.
1954         5) Added the HTML, JS, and CSS to the project file to make them easy to
1955         find.
1956         6) Made the ServerConnection functions virtual.
1957
1958         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1959         for the WebKit server.
1960         (DebuggerClient::DebuggerClient):
1961         (DebuggerClient::~DebuggerClient):
1962         (DebuggerClient::didFinishLoadForFrame):
1963         (DebuggerClient::serverConnected):
1964         (DebuggerClient::attemptToCreateServerConnection):
1965         * Drosera/win/DebuggerClient.h: Ditto.
1966         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1967         scope.
1968         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1969         (DebuggerDocument::platformValueForScopeVariableNamed):
1970         * Drosera/win/Drosera.cpp:
1971         (_tWinMain): Added a console in debug for output messages.
1972         (Drosera::Drosera): Listen for server.
1973         (Drosera::initUI): The server now Initializes COM.
1974         (Drosera::serverConnected): Part of the listening for the server.
1975         (Drosera::attemptToCreateServerConnection): Ditto.
1976         * Drosera/win/Drosera.h: New interface for listening for the server.
1977         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1978         files to the VS project.
1979         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1980         connection.
1981         (ServerConnection::ServerConnection):
1982         (ServerConnection::attemptToCreateServerConnection):
1983         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1984         methods.
1985         (ServerConnection::serverConnected):
1986
1987 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1988
1989         Reviewed by Maciej.
1990
1991         http://bugs.webkit.org/show_bug.cgi?id=15832
1992         fast/dom/gc-10.html crashes when run alone
1993
1994         Check for !done before using objects that can be already deallocated.
1995
1996         * DumpRenderTree/mac/EditingDelegate.mm:
1997         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1998         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1999         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2000         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2001         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2002         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2003         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2004         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2005         (-[EditingDelegate webViewDidBeginEditing:]):
2006         (-[EditingDelegate webViewDidChange:]):
2007         (-[EditingDelegate webViewDidEndEditing:]):
2008         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2009         (-[EditingDelegate webViewDidChangeSelection:]):
2010         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2011         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2012         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2013         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2014         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2015         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2016         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2017         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2018         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2019         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2020         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2021         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2022         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2023         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2024         (-[FrameLoadDelegate webView:willCloseFrame:]):
2025         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2026         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2027         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2028         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2029         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2030         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2031         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2032         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2033         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2034
2035 2007-11-04  Mark Rowe  <mrowe@apple.com>
2036
2037         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2038         warnings that would otherwise be suppressed due to it being a system header.
2039
2040         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2041
2042 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2043
2044         Rubber stamped by Adam.
2045
2046         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2047
2048         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2049
2050 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2051
2052         Sort files(...); sections of Xcode project files.
2053
2054         Rubber-stamped by Darin.
2055
2056         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2057         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2058         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2059         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2060
2061 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2062
2063         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2064
2065         Reviewed by Darin.
2066
2067         * Scripts/sort-Xcode-project-file: Added.
2068
2069 2007-11-02  Darin Adler  <darin@apple.com>
2070
2071         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2072
2073 2007-11-02  Darin Adler  <darin@apple.com>
2074
2075         Reviewed by Maciej.
2076
2077         * Scripts/run-sunspider: Pass the "--base" option through.
2078
2079         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2080         the real script do that. Default configuration to Release to match run-sunspider
2081         so we don't end up building Debug just to compare results.
2082
2083 2007-11-01  Adam Roben  <aroben@apple.com>
2084
2085         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2086
2087         Reviewed by Sam.
2088
2089         * Scripts/commit-log-editor: Show all the directories beneath the
2090         source root, instead of just the last one.
2091
2092 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2093
2094         Reviewed by Adam Roben.
2095
2096         Print out an error message when the Windows build fails
2097         and provide guidance on how to find out what went wrong.
2098
2099         * Scripts/build-webkit:
2100         * Scripts/webkitdirs.pm:
2101
2102 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2103
2104         Rubber-stamped by Adam Roben.
2105
2106         Rolled out r27326 - debug CRT seems to cause no problems after all.
2107
2108         * DumpRenderTree/win/DumpRenderTree.vcproj:
2109
2110 2007-10-31  Adam Roben  <aroben@apple.com>
2111
2112         Switch the Debug configuration to using the non-debug CRT
2113
2114         This matches WebKit.
2115
2116         Reviewed by Steve.
2117
2118         * DumpRenderTree/win/DumpRenderTree.vcproj:
2119
2120 2007-10-31  Antti Koivisto  <antti@apple.com>
2121
2122         Reviewed by bdash.
2123
2124         Disable media tests when doing leak checking on Tiger.
2125         They crash in QuickTime (rdar://problem/5537157).
2126
2127         * Scripts/run-webkit-tests:
2128
2129 2007-10-29  Antti Koivisto  <antti@apple.com>
2130
2131         Reviewed by Maciej.
2132
2133         Build media support by default on OSX only.
2134
2135         * Scripts/build-webkit:
2136
2137 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2138
2139         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2140         get caught by the pre-commit hooks.
2141
2142 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2143
2144         Reviewed by Adam.
2145
2146         - This is a collection of relatively unrelated changes and cleanups
2147         to Drosera to prepare it for interacting with WebKit.  A lot of these
2148         changes are just correcting mistakes, for example removing included
2149         headers that are no longer needed.
2150
2151         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2152         this will be needed by the DebuggerClient.
2153         (DebuggerDocument::server):
2154         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2155         * Drosera/win/DebuggerClient.cpp:
2156         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2157         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2158         (DebuggerClient::createWebViewWithRequest): Added comment about its
2159         purpose.
2160         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2161         declarations.
2162         (DebuggerClient::webViewLoaded): Moved.
2163         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2164         file, since this was the only place it was used.
2165         (cfStringToBSTR):
2166         * Drosera/win/Drosera.h: Cleaned up the includes.
2167         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2168         * Drosera/win/HelperFunctions.h: Removed.
2169
2170 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2171
2172         Reviewed by Adam.
2173
2174         - Small cleanup in the ServerConnection class.
2175
2176         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2177         and added an include.
2178         (ServerConnection::currentFrame):
2179         (ServerConnection::getCallerFrame):
2180         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2181         made a pointer into a COMPtr, and cleaned up the includes.
2182
2183 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2184
2185         Reviewed by John Sullivan.
2186
2187         - Place the Localizable.strings file in mac or win directories
2188           if that location exists.
2189         - Also look for UI_STRING in .c files.
2190
2191         * Scripts/extract-localizable-strings:
2192
2193 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2194
2195         Reviewed by Adam.
2196
2197         - Set the eol-style to native and made all the line endings the same
2198         so that I avoid messy diffs that show eol changes.
2199
2200         * Drosera/win/ServerConnection.cpp:
2201         (ServerConnection::didParseSource):
2202         (ServerConnection::didEnterCallFrame):
2203         (ServerConnection::willExecuteStatement):
2204         (ServerConnection::willLeaveCallFrame):
2205         (ServerConnection::exceptionWasRaised):
2206
2207 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2208
2209         Reviewed by Adam.
2210
2211         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2212         functionality that could not have existed previously without the new
2213         interfaces.
2214         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2215         from a BSTR to a JSValueRef.
2216         (DebuggerDocument::platformEvaluateScript): Implemented.
2217         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2218         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2219         Implemented.
2220         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2221         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2222         * Drosera/win/ServerConnection.cpp: Added a helper function.
2223         (ServerConnection::getCallerFrame):
2224         * Drosera/win/ServerConnection.h: Added a helper function.
2225
2226 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2227
2228         updated reviewers for my previous changelog.
2229
2230 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2231         Reviewed by Maciej and Adam and Geoff.
2232
2233         - Minor mac-side improvements including moving a function to a more
2234         appropriate location, fixing a warning, and correctly checking
2235         exceptions.
2236
2237         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2238         (DebuggerDocument::willExecuteStatement):
2239         (DebuggerDocument::didEnterCallFrame):
2240         (DebuggerDocument::willLeaveCallFrame):
2241         (DebuggerDocument::windowScriptObjectAvailable):
2242         (DebuggerDocument::callFunctionOnObject):
2243         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2244         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2245         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2246         because it doesn't require the ServerConnection at all.
2247         (NSStringCreateWithJSStringRef): Made an argument const.
2248         (JSValueRefCreateWithNSString): Made an argument const.
2249         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2250         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2251         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2252         * Drosera/mac/ServerConnection.mm: Ditto.
2253         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2254
2255 2007-10-29  Sam Weinig  <sam@webkit.org>
2256
2257         Reviewed by Adam Roben.
2258
2259         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2260
2261         * DumpRenderTree/LayoutTestController.cpp:
2262         (LayoutTestController::LayoutTestController):
2263         (getGlobalFlagCallback):
2264         (setGlobalFlagCallback):
2265         (LayoutTestController::getJSClass):
2266         (LayoutTestController::staticValues):
2267         * DumpRenderTree/LayoutTestController.h:
2268         (LayoutTestController::globalFlag):
2269         (LayoutTestController::setGlobalFlag):
2270
2271 2007-10-29  Darin Adler  <darin@apple.com>
2272
2273         Reviewed by Maciej.
2274
2275         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2276         resolution instead of its default.
2277
2278 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2279
2280         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2281
2282         Reviewed by Mark Rowe.
2283
2284         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2285         was successfully resolved, but this would not show any status because the change had
2286         already been cached in the index using "git add".  The solution is to add an optional
2287         second argument to showStatus() which adds the "--cached" switch to the command.
2288
2289         * Scripts/resolve-ChangeLogs:
2290         (showStatus):
2291
2292 2007-10-28  Eric Seidel  <eric@webkit.org>
2293
2294         Reviewed by Maciej and Geoff, in unison.
2295
2296         * Scripts/run-webkit-tests: remove broken --svg option
2297
2298 2007-10-28  Darin Adler  <darin@apple.com>
2299
2300         Reviewed by Adam.
2301
2302         * Scripts/run-sunspider: Default to "Release" configuration rather than
2303         defaulting to the last configuration used as other scripts do. This can
2304         still be overriden on the command line with "--debug" if there's some
2305         reason to do so. Also fix a typo.
2306
2307         * Scripts/sunspider-compare-results: Fix a typo.
2308
2309 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2310
2311         Reviewed by Adam.
2312
2313         - Implemented the WebScriptDebugListener functions now that the
2314         WebScriptDebugServer exists
2315
2316         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2317         functions.
2318         (ServerConnection::currentFrame):
2319         (ServerConnection::didLoadMainResourceForDataSource):
2320         (ServerConnection::didParseSource):
2321         (ServerConnection::failedToParseSource):
2322         (ServerConnection::didEnterCallFrame):
2323         (ServerConnection::willExecuteStatement):
2324         (ServerConnection::willLeaveCallFrame):
2325         (ServerConnection::exceptionWasRaised):
2326         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2327         members arguments list.
2328
2329 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2330
2331         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2332         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2333
2334         Reviewed by Darin.
2335
2336         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2337         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2338         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2339         file.  Note that it may also be used as a stand-alone script.
2340
2341         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2342         * Scripts/resolve-ChangeLogs: Added.
2343         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2344
2345 2007-10-26  Mark Rowe  <mrowe@apple.com>
2346
2347         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2348         to the Qt port on the assumption that it was an implementation of the cross-platform
2349         LayoutTestController class.  It is not, so it did not need to be changed.
2350
2351         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2352
2353 2007-10-25  Mark Rowe  <mrowe@apple.com>
2354
2355         Reviewed by Maciej.
2356
2357         Fix builds with code coverage enabled.
2358
2359         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2360
2361 2007-10-25  Darin Adler  <darin@apple.com>
2362
2363         Reviewed by Mark Rowe.
2364
2365         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2366         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2367
2368 2007-10-25  Stephanie  <slewis@apple.com>
2369
2370         build Fix
2371
2372         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2373
2374 2007-10-25  Stephanie  <slewis@apple.com>
2375
2376         Reviewed by Mark Rowe, Adam Roben.
2377
2378         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2379
2380         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2381
2382 2007-10-25  Alice Liu  <alice.liu@apple.com>
2383
2384         Reviewed by Adam.
2385
2386         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2387
2388         Moving destructor into platform-specific files
2389         * DumpRenderTree/LayoutTestController.cpp:
2390         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2391         (LayoutTestController::~LayoutTestController):
2392         * DumpRenderTree/qt/jsobjects.cpp:
2393         (LayoutTestController::~LayoutTestController):
2394
2395         LayoutTestController wasn't being destroyed
2396         * DumpRenderTree/win/DumpRenderTree.cpp:
2397         (runTest):
2398
2399         Added declspec
2400         * DumpRenderTree/win/EditingDelegate.h:
2401
2402         Reset certain values on the webview (or related delegate) that might
2403         have changed while running a test
2404         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2405         (LayoutTestController::~LayoutTestController):
2406
2407 2007-10-25  Adam Roben  <aroben@apple.com>
2408
2409         Make sunspider-compare-results work with relative paths
2410
2411         Reviewed by Sam.
2412
2413         * Scripts/sunspider-compare-results: Convert arguments to absolute
2414         paths before we chdir.
2415
2416 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2417
2418         Reviewed by Sam.
2419
2420         - Implemented server calls now the WebScriptDebugServer exists.
2421         - Also removed no longer needed call to initialize CG.
2422
2423         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2424         automatically now.
2425         (_tWinMain):
2426         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2427         (ServerConnection::ServerConnection):
2428         (ServerConnection::~ServerConnection):
2429         (ServerConnection::pause):
2430         (ServerConnection::resume):
2431         (ServerConnection::stepInto):
2432         (ServerConnection::applicationTerminating):
2433         (ServerConnection::serverConnectionDidDie):
2434         * Drosera/win/ServerConnection.h: Now uses the COM class.
2435
2436 2007-10-24  George Staikos  <staikos@kde.org>
2437
2438         Unbreak Qt build.
2439
2440         * Scripts/build-webkit:
2441
2442 2007-10-24  Adam Roben  <aroben@apple.com>
2443
2444         Remove now-unnecessary call to InitializeCoreGraphics
2445
2446         WebKit takes care of this now.
2447
2448         Reviewed by Ada.
2449
2450         * DumpRenderTree/win/DumpRenderTree.cpp:
2451         (initialize):
2452
2453 2007-10-24  Adam Roben  <aroben@apple.com>
2454
2455         Use WebTextRenderer in DRT
2456
2457         Reviewed by Ada.
2458
2459         * DumpRenderTree/win/DumpRenderTree.cpp:
2460         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2461
2462 2007-10-24  Sven Herzberg  <sven@imendio.com>
2463
2464         Reviewed by Mark Rowe.
2465
2466         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2467         Bug 15614: [GTK] qmake based backends don't build on OS X
2468
2469         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2470         GTK backend on a Mac
2471         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2472         isDarwin() to make it reusable in other places (like the workaround-
2473         for-prebuilt-qmake in build-webkit)
2474
2475 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2476
2477         Refurbish update-webkit script.
2478
2479         Reviewed by Adam.
2480
2481         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2482         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2483         multi-argument version of system() for flexibility and security.  Check for existence
2484         of Internal directory using -d test instead of -x.
2485
2486 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2487
2488         Minor clean-up of prepare-ChangeLog script.
2489
2490         Reviewed by Adam.
2491
2492         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2493         of a string.  Use multi-argument versions of open() and system() for flexibility and
2494         security.
2495
2496 2007-10-24  Alice Liu  <alice.liu@apple.com>
2497
2498         Reviewed by Oliver.
2499
2500         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2501
2502         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
2503         replay the saved events when we're still processing the mousedown that starts the drag
2504         * DumpRenderTree/win/EventSender.cpp:
2505         (doMouseMove):
2506         * DumpRenderTree/win/UIDelegate.cpp:
2507         (UIDelegate::doDragDrop):
2508
2509 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2510
2511         Reviewed by Sam, Steve and Darin.
2512
2513         - Stubbed out the WebScriptDebugListener functionality in the Server
2514         Connection class to prepare it for receiving those callbacks.
2515         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2516         and the ServerConnection to not need to be initialized with a server
2517         name, since that is not the way we connect to the WebKit server.
2518
2519         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2520         no exception.  Now it only loggs when there is an exception
2521         (DebuggerDocument::willExecuteStatement):
2522         (DebuggerDocument::didEnterCallFrame):
2523         (DebuggerDocument::willLeaveCallFrame):
2524         (DebuggerDocument::windowScriptObjectAvailable):
2525         (DebuggerDocument::callFunctionOnObject):
2526         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2527         to be instantiated with a server's name.
2528         (DebuggerClient::DebuggerClient):
2529         (DebuggerClient::didFinishLoadForFrame):
2530         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2531         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2532         a server name.
2533         (Drosera::init):
2534         (Drosera::initServer):
2535         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2536         instantiated with a server's name.
2537         * Drosera/win/ServerConnection.cpp:
2538         (ServerConnection::ServerConnection): No longer needs a server name
2539         (ServerConnection::~ServerConnection): Only release the global context
2540         if there is one.
2541         (ServerConnection::serverConnectionDidDie): Stub for
2542         IWebScriptDebugListener
2543         (ServerConnection::QueryInterface): ditto
2544         (ServerConnection::AddRef): ditto
2545         (ServerConnection::Release): ditto
2546         (ServerConnection::didLoadMainResourceForDataSource): ditto
2547         (ServerConnection::didParseSource): ditto
2548         (ServerConnection::failedToParseSource): ditto
2549         (ServerConnection::didEnterCallFrame): ditto
2550         (ServerConnection::willExecuteStatement): ditto
2551         (ServerConnection::willLeaveCallFrame): ditto
2552         (ServerConnection::exceptionWasRaised): ditto
2553         * Drosera/win/ServerConnection.h: Stubbed out the
2554         IWebScriptDebugListener functions, and this class no longer needs to be
2555         instantiated with a server name.
2556
2557 2007-10-24  Lars Knoll  <lars@trolltech.com>
2558
2559         Reviewed by Simon.
2560
2561         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2562
2563         * DumpRenderTree/qt/jsobjects.h:
2564
2565 2007-10-24  Lars Knoll  <lars@trolltech.com>
2566
2567         Reviewed by Simon.
2568
2569         add another command.
2570
2571         * DumpRenderTree/qt/jsobjects.cpp:
2572         (TextInputController::doCommand):
2573
2574 2007-10-24  Lars Knoll  <lars@trolltech.com>
2575
2576         Reviewed by Simon.
2577
2578         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2579
2580         * DumpRenderTree/qt/jsobjects.cpp:
2581         (EventSender::keyDown):
2582         * DumpRenderTree/qt/jsobjects.h:
2583
2584 2007-10-24  Lars Knoll  <lars@trolltech.com>
2585
2586         Reviewed by Simon.
2587
2588         implement eventSender.keyDown().
2589
2590         * DumpRenderTree/qt/jsobjects.cpp:
2591         (EventSender::keyDown):
2592
2593 2007-10-24  Lars Knoll  <lars@trolltech.com>
2594
2595         Reviewed by Simon.
2596
2597         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2598
2599         * DumpRenderTree/qt/DumpRenderTree.cpp:
2600         (WebCore::DumpRenderTree::DumpRenderTree):
2601         (WebCore::DumpRenderTree::initJSObjects):
2602         * DumpRenderTree/qt/jsobjects.cpp:
2603         (TextInputController::doCommand):
2604
2605 2007-10-24  Lars Knoll  <lars@trolltech.com>
2606
2607         Reviewed by Simon.
2608
2609         first bit of implementation for the textinputcontroller.
2610
2611         * DumpRenderTree/qt/DumpRenderTree.cpp:
2612         (WebCore::DumpRenderTree::DumpRenderTree):
2613         * DumpRenderTree/qt/DumpRenderTree.h:
2614         * DumpRenderTree/qt/jsobjects.cpp:
2615         (TextInputController::TextInputController):
2616         (TextInputController::doCommand):
2617         * DumpRenderTree/qt/jsobjects.h:
2618
2619 2007-10-24  Lars Knoll  <lars@trolltech.com>
2620
2621         Reviewed by Simon.
2622
2623         make the man webpage believe it has focus, so the editing tests work correctly.
2624
2625         * DumpRenderTree/qt/DumpRenderTree.cpp:
2626         (WebCore::DumpRenderTree::DumpRenderTree):
2627
2628 2007-10-24  Lars Knoll  <lars@trolltech.com>
2629
2630         Reviewed by Simon.
2631
2632         implement layoutTestController.dumpEditingCallbacks() correctly.
2633
2634         * DumpRenderTree/qt/DumpRenderTree.cpp:
2635         (WebCore::DumpRenderTree::DumpRenderTree):
2636         * DumpRenderTree/qt/jsobjects.cpp:
2637         (LayoutTestController::reset):
2638         (LayoutTestController::dumpEditingCallbacks):
2639
2640 2007-10-24  Lars Knoll  <lars@trolltech.com>
2641
2642         Reviewed by Simon.
2643
2644         Implement support for testing editing.
2645
2646         * DumpRenderTree/qt/DumpRenderTree.cpp:
2647         (WebCore::DumpRenderTree::DumpRenderTree):
2648
2649 2007-10-23  Sam Weinig  <sam@webkit.org>
2650
2651         Check for null BSTR that can be passed to the UIDelegate methods
2652         from javascript null and undefined.  Fixes a failing test case on
2653         Windows (fast/dom/Window/alert-undefined.html)
2654
2655         Reviewed by Eric Seidel.
2656
2657         * DumpRenderTree/win/UIDelegate.cpp:
2658         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2659         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2660         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2661         (UIDelegate::webViewAddMessageToConsole):
2662
2663 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2664
2665         Reviewed by Darin.
2666
2667         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2668
2669         * Scripts/build-testkjs:
2670
2671 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2672
2673         Reviewed by Darin.
2674
2675         - add wrapper that finds the right copy of testkjs
2676
2677         * Scripts/sunspider-compare-results: Added.
2678
2679 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2680
2681         Reviewed by Sam.
2682
2683         - After talking with Steve I now see that the WebKit server must be
2684         running for DCOM to create the distributed objects, which makes sense
2685         and currently WebKit only allows one instance to be running at a time
2686         which avoids accidentally connecting to the wrong server
2687         - In light of this I have removed the code for the attach box and
2688         NotificationServer and known server names, since they are all extranious
2689         now.
2690
2691         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2692         names.
2693         (_tWinMain): Uses init instead of initUI.
2694         (droseraWndProc): No longer creats an attach dialog box.
2695         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2696         it's not manditory to call init before doing COM stuff.
2697         (Drosera::init): calls initUI and will call attach when the
2698         functionality exists.
2699         (Drosera::initUI): Has changed very little.
2700         (Drosera::attach): Changed the signature to reflect that we no longer
2701         need the dictionary of known server names.
2702         * Drosera/win/Drosera.h: Removed notification classes and known server
2703         names.  Also renamed and moved some functions.
2704         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2705         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2706         headers to the resources folder.
2707         * Drosera/win/resource.h: Removed the Attach box.
2708
2709 2007-10-22  Adam Roben  <aroben@apple.com>
2710
2711         Windows build fix
2712
2713         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2714
2715 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2716
2717         - Removed a leak that was fixed.
2718
2719         * Scripts/run-webkit-tests:
2720
2721 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2722
2723         Reviewed by Darin.
2724
2725         - Changed the Client so that the DebuggerDocument now own the
2726         ServerConnection.  This simplifies ownership and cleanup.
2727
2728         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2729         ServerConnection.
2730         (DebuggerClient::initWithServerName):
2731         (DebuggerClient::didFinishLoadForFrame):
2732         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
2733         ServerConnection.
2734         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2735         until after we have a server which we are attached to.
2736         (Drosera::initUI):
2737         (Drosera::attach):
2738         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2739         out previously.
2740
2741 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2742
2743         Reviewed by Nikolas.
2744
2745         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2746
2747         * Scripts/run-javascriptcore-tests:
2748
2749 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2750
2751         Reviewed by Nikolas.
2752
2753         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2754
2755         * Scripts/build-drosera:
2756         * Scripts/build-dumprendertree:
2757         * Scripts/build-testkjs:
2758         * Scripts/build-webkit:
2759         * Scripts/run-javascriptcore-tests:
2760         * Scripts/run-sunspider:
2761         * Scripts/run-webkit-tests:
2762         * Scripts/webkitdirs.pm:
2763
2764 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2765
2766         Reviewed by Mark Rowe.
2767
2768         Fix for local database support after r26879
2769         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2770
2771         * Scripts/build-webkit:
2772
2773 2007-10-22  Holger Freyther  <zecke@selfish.org>
2774
2775         Reviewed by Simon Hausmann <hausmann@kde.org>.
2776
2777         - Do not build testkjs as an application bundle. This is
2778         needed for run-javascriptcore-tests on OSX.
2779         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2780         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2781         as we do not have -rpath on OSX.
2782
2783         * DumpRenderTree/qt/DumpRenderTree.pro:
2784         * Scripts/run-webkit-tests:
2785
2786 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2787
2788         Reviewed by aroben.
2789
2790         Fix support for Signed-off-by detection in prepare-ChangeLog
2791         --git-commit. The Signed-off-by tag does not appear in the header
2792         but usually at the end.
2793
2794         * Scripts/prepare-ChangeLog:
2795
2796 2007-10-21  Mark Rowe  <mrowe@apple.com>
2797
2798         Reviewed by Eric.
2799
2800         Fix run-javascriptcore-tests for Gtk.
2801
2802         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2803
2804 2007-10-20  Eric Seidel  <eric@webkit.org>
2805
2806         Reviewed by aroben.
2807
2808         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2809
2810 2007-10-20  Eric Seidel  <eric@webkit.org>
2811
2812         Reviewed by darin.
2813
2814         Add improved argument handling to run-sunspider, including
2815         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2816         Also re-factor code into subroutines
2817
2818         * Scripts/build-dumprendertree: removed bogus comments
2819         * Scripts/build-testkjs: Added.
2820         * Scripts/run-javascriptcore-tests: use build-testkjs
2821         * Scripts/run-sunspider: improved argument handling, abstraction
2822         * Scripts/run-webkit-tests: improved abstraction
2823
2824 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2825
2826         Not reviewed, Windows build fix.
2827
2828         * DumpRenderTree/win/EventSender.cpp:
2829         (keyDownCallback):
2830
2831 2007-10-20  Darin Adler  <darin@apple.com>
2832
2833         Reviewed by Tim Hatcher.
2834
2835         - http://bugs.webkit.org/show_bug.cgi?id=15544
2836           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2837           not rely on Apple-specific key codes
2838
2839         * DumpRenderTree/mac/EventSendingController.mm:
2840         (-[EventSendingController keyDown:withModifiers:]):
2841         Added named key "rightArrow". Later we could have a whole table of these.
2842         Also tweaked modifiers code a little.
2843
2844         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2845
2846 2007-10-19  Darin Adler  <darin@apple.com>
2847
2848         Reviewed by Eric.
2849
2850         - http://bugs.webkit.org/show_bug.cgi?id=15566
2851           possible fix for leak seen in DumpRenderTree
2852
2853         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2854         Delete the item if it's not put on the queue, since the caller has
2855         no way of knowing that. Would be better to have the parameter type
2856         be auto_ptr to express the fact that we take ownership.
2857
2858         - unrelated change
2859
2860         * Drosera/mac/main.m: Add missing include.
2861
2862 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2863
2864         Reviewed by Adam.
2865
2866         - This change should be identical but for some reason was not working
2867         on my machine.
2868
2869         * Scripts/prepare-ChangeLog:
2870
2871 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2872
2873         Reviewed by Oliver and Tim.
2874
2875         - Made use of RetainPtr to avoid retain and release issues and moved the
2876         log function to DebuggerDocumentPlatform, which seems to be a more
2877         logical place for it to live.
2878         - Also moved knownServers from the ServerConnection to
2879         DebuggerApplication to match the Windows code and because it makes sense
2880         that a connection knows its own server but not all of them.
2881
2882         * Drosera/mac/DebuggerClient.h: Moved the log function to
2883           DebuggerDocumentPlatform.
2884         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2885           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2886           call for the server name up from the ServerConnection class.
2887         (-[DebuggerClient dealloc]):
2888         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2889           for the server name up from the ServerConnection.
2890         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2891         (DebuggerDocument::platformPause):
2892         (DebuggerDocument::platformResume):
2893         (DebuggerDocument::platformStepInto):
2894         (DebuggerDocument::platformEvaluateScript):
2895         (DebuggerDocument::getPlatformCurrentFunctionStack):
2896         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2897         (DebuggerDocument::platformValueForScopeVariableNamed):
2898         (DebuggerDocument::platformLog): Log directly from here. No need to call
2899           DebuggerClient.
2900         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2901           way I see it, a ServerConnection should only know about its connection
2902           and the group of all possible servers should be kept by the
2903           application.
2904         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2905           currentServerName, it makes sense that the connection should know that
2906           name.
2907         (-[ServerConnection currentServerName]):
2908
2909 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2910
2911         Reviewed by Adam.
2912
2913         - Integrated changes from mac drosera.  Recently I've encapsulated
2914         out the server connection object from the rest of Drosera because
2915         it is very platform dependent right now and RPC is not implemented on
2916         windows.  This functionality, of communicating with the WebKit server
2917         is the next area I will be focusing on in Windows.
2918
2919         - Other changes and cleanup were made to organize the code and add notes
2920         on which parts still need work.  Also some mac code is added and
2921         commented out, to act as pseudocode for the logic of those parts.
2922
2923         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2924           pointer.
2925         * Drosera/config.h: Added whitespace.
2926         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2927           these files got moved into Drosera.h/cpp
2928         * Drosera/win/DebuggerApplication.h: Removed.
2929         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
2930           happened here to better match the logic flow of the same code on the
2931           mac side and to use the new ServerConnection class.
2932         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2933         (DebuggerClient::initWithServerName): Initializer that will set up the
2934           class to use a ServerConnection object.  This was necessary so I could
2935           create a DebuggerClient without having to initilaize it at
2936           construction.
2937         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2938           will be the UIDelegate and FrameLoadDelegate.
2939         (DebuggerClient::AddRef): For IUnknown.
2940         (DebuggerClient::Release): For IUnknown.
2941         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2942           this still needs to set the global context of the server, but
2943           IWebFrame does not have an accessor for the global context yet.
2944         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2945           this is a pass through for the same function in the document.
2946         (DebuggerClient::didReceiveTitle): Unimplemented part of
2947           FrameLoadDelegate this would change the title of the window.
2948         (DebuggerClient::createWebViewWithRequest): Part of the
2949           FrameLoadDelegate.  This is about new windows via Window.open() and
2950           how their delegates are set.
2951         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2952           UIDelegate.  Just a debug function for printing messages.
2953         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2954           because the Client should be the UIDelegate and FrameLoadDelegate
2955           to match the delegates on mac.
2956         (DebuggerClient::webViewLoaded): Added accessor method.
2957         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2958           forgotten to add this file before.  This is where the platform
2959           dependent versions of the Documents functions live. Most of these are
2960           unimplemented because some piece of functionality does not exist on
2961           Windows yet.
2962         (DebuggerDocument::platformPause):
2963         (DebuggerDocument::platformResume):
2964         (DebuggerDocument::platformStepInto):
2965         (DebuggerDocument::platformEvaluateScript):
2966         (DebuggerDocument::getPlatformCurrentFunctionStack):
2967         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2968         (DebuggerDocument::platformValueForScopeVariableNamed):
2969         (DebuggerDocument::platformLog):
2970         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2971           responsibilities becaue they belong in the Client. Also I laid the
2972           groundwork for attaching Drosera to a WebKit process
2973         (attachWndProc): Now if a server is selected the Client becomes it's
2974           delegate.
2975         (Drosera::Drosera): Added the construction of the Client and dictionary
2976           of server names.
2977         (Drosera::initUI): This is no longer the delegates, the Client is.
2978         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2979           state.
2980         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2981           notification registration when it's possible to implement.
2982         (Drosera::serverLoaded): Ditto
2983         (Drosera::serverUnloaded): Ditto
2984         (Drosera::attach): Attach Drosera to the WebKit server.
2985         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2986         (Drosera::getInst):
2987         (Drosera::setInst):
2988         (Drosera::knownServers):
2989         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2990           and added the ServerConnection.
2991         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2992         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2993           Most of the functions are completely unimlemented because they cannot
2994           connect with the WebKit server, because one does not exist on Windows
2995           yet.
2996         (ServerConnection::initWithServerName):
2997         (ServerConnection::~ServerConnection):
2998         (ServerConnection::setGlobalContext):
2999         (ServerConnection::pause):
3000         (ServerConnection::resume):
3001         (ServerConnection::stepInto):
3002         (ServerConnection::switchToServerNamed):
3003         (ServerConnection::applicationTerminating):
3004         (ServerConnection::serverConnectionDidDie):
3005         (ServerConnection::currentFrame):
3006         * Drosera/win/ServerConnection.h: Added. Ditto.
3007         (ServerConnection::ServerConnection):
3008
3009 2007-10-19  Alice Liu  <alice.liu@apple.com>
3010
3011         Reviewed by Darin.
3012
3013         Fix for these broken layout tests on Windows:
3014
3015         fast/forms/focus-selection-input.html
3016         fast/forms/focus-selection-textarea.html
3017         fast/forms/select-accesskey.html
3018
3019         * DumpRenderTree/win/EventSender.cpp:
3020         (keyDownCallback):
3021         correct the VK code for alt key.
3022
3023 2007-10-19  Eric Seidel  <eric@webkit.org>
3024
3025         Reviewed by Mark Rowe.
3026
3027         Make the GtkLauncher code slightly more readable.
3028
3029         * GtkLauncher/main.cpp:
3030         (setupMainMenu): Added.
3031         (setupMainWindowUI): Added.
3032         (main):
3033
3034 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3035
3036         Rubber stamped by Adam.
3037
3038         - don't delay-load WebKit in DumpRenderTree.
3039
3040         * DumpRenderTree/win/DumpRenderTree.vcproj:
3041
3042 2007-10-18  Dan Bernstein  <mitz@apple.com>
3043
3044         Reviewed by Adam Roben.
3045
3046         - fix <rdar://problem/5313523>
3047         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3048
3049         * DumpRenderTree/mac/DumpRenderTree.mm:
3050         (dump): Changed to use _responseMIMEType.
3051
3052 2007-10-17  Adam Roben  <aroben@apple.com>
3053
3054         Make it possible to have Windows-specific tests and results
3055
3056         When searching for tests to run and the Skipped file, we will only
3057         look in platform/win and the cross-platform directory. When looking
3058         for expected results, we will look in platform/win, then
3059         platform/mac-leopard, then platform/mac, then finally the
3060         cross-platform directory.
3061
3062         Reviewed by Sam.
3063
3064         * Scripts/run-webkit-tests:
3065         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3066         searching in the cross-platform directory.
3067         (sub buildPlatformHierarchy): Removed some unneeded calls to
3068         dirname/basename.
3069
3070 2007-10-17  Adam Roben  <aroben@apple.com>
3071
3072         Add back the call to register WebKit that we had before WebKitInitializer existed
3073
3074         This is needed to ensure that the right WebKit is used when
3075         instantiating COM objects.
3076
3077         Reviewed by Oliver.
3078
3079         * DumpRenderTree/win/debug_internal.vsprops: Define
3080         DEBUG_WEBKIT_HAS_SUFFIX.
3081         * DumpRenderTree/win/DumpRenderTree.cpp:
3082         (initialize):
3083
3084 2007-10-17  Adam Roben  <aroben@apple.com>
3085
3086         Import File::Basename in webkitdirs since we use it
3087
3088         * Scripts/webkitdirs.pm:
3089
3090 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3091
3092         - Updated the tiger leaks list to make the internal bots green.
3093
3094         * Scripts/run-webkit-tests:
3095
3096 2007-10-17  Adam Roben  <aroben@apple.com>
3097
3098         Build fix for VC++ Express
3099
3100         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3101         and ole32.lib.
3102
3103 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3104
3105         Reviewed by Sam.
3106
3107         - Minor mac improvements based on observations I made while implementing the
3108         Windows code.
3109
3110         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3111         then hand it to the Client who will retain it, it should just be the client who
3112         creates and owns the server.
3113         (-[DebuggerApplication attach:]):
3114         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3115         * Drosera/mac/DebuggerClient.mm: Creates the server.
3116         (-[DebuggerClient initWithServerName:]):
3117         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3118         can instead forward declare what it needs.
3119
3120 2007-10-16  Darin Adler  <darin@apple.com>
3121
3122         Reviewed by Geoff Garen.
3123
3124         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3125         want to turn failing tests into platform-specific test results. Also did a
3126         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3127         would take the type of results into account only some of the time.
3128
3129 2007-10-16  Adam Roben  <aroben@apple.com>
3130
3131         Add a new nightly launcher script for Windows
3132
3133         This new script is for versions of Safari that don't delay-load
3134         WebKit. I had to make FindSafari be able to print out the nightly
3135         launcher script on stdout because Windows shell scripts can't capture
3136         the output from a command into an environment variable.
3137
3138         Reviewed by Steve.
3139
3140         * FindSafari/FindSafari.cpp:
3141         (_tmain): Added /printSafariLauncher option.
3142         * Scripts/run-webkit-nightly.cmd: Added.
3143
3144 2007-10-16  Adam Roben  <aroben@apple.com>
3145
3146         Replace WebKitInitializer with FindSafari
3147
3148         We now rely on setting the PATH environment variable to tell Windows
3149         where to find WebKit and its dependencies (similar to
3150         DYLD_FRAMEWORK_PATH on Mac).
3151
3152         This change also make DumpRenderTree no longer delay-load WebKit.
3153
3154         Reviewed by Sam.
3155
3156         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3157         FindSafari.
3158         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3159         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3160         WebKitInitializer, don't delay-load WebKit.
3161         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3162         * Scripts/run-webkit-tests: Ditto.
3163         * Scripts/webkitdirs.pm:
3164         (sub setPathForRunningWebKitApp): Added.
3165         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3166         * WebKitInitializer/WebKitInitializer.h: Removed.
3167         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3168         * WebKitInitializer/debug.vsprops: Removed.
3169         * WebKitInitializer/debug_internal.vsprops: Removed.
3170         * WebKitInitializer/release.vsprops: Removed.
3171
3172 2007-10-16  Adam Roben  <aroben@apple.com>
3173
3174         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3175
3176         http://bugs.webkit.org/show_bug.cgi?id=15532
3177
3178         FindSafari simply prints the location of an installed Safari.exe on
3179         stdout.
3180
3181         Reviewed by Darin.
3182
3183         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3184         (getStringValue):
3185         (getWebViewCLSID):
3186         (getInstalledWebKitDirectory):
3187         (_tmain):
3188         * FindSafari/FindSafari.vcproj: Added.
3189         * Scripts/webkitdirs.pm:
3190         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3191
3192 2007-10-16  Adam Roben  <aroben@apple.com>
3193
3194         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3195
3196         Reviewed by Kevin McCullough.
3197
3198         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3199         when referring to WebKit.dll.
3200         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3201         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3202         * DumpRenderTree/win/release.vsprops: Ditto.
3203         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3204         never have a _debug suffix on WebKit.dll.
3205         * WebKitInitializer/WebKitInitializer.cpp:
3206         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3207         specified.
3208         * WebKitInitializer/debug_internal.vsprops: Added
3209         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3210
3211 2007-10-16  Darin Adler  <darin@apple.com>
3212
3213         Reviewed by Adele.
3214
3215         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3216         Remove now-unneeded control/alt key hack; the tests have been updated.
3217
3218 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3219
3220         - Updated leaks list because our internal bot upgraded it's version of leopard and
3221         one of the leaks was fixed between that revision and the bot's previous version of
3222         leopard.
3223
3224         * Scripts/run-webkit-tests:
3225
3226 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3227
3228         Reviewed by Tim.
3229
3230         - I encapsulated out the server connecton functionality because it is a specific part
3231         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3232         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3233         Windows.  So the majority of this patch is moving preexisting functionality.
3234
3235         - Also I removed the prefix header and changed to use config.h because it is more
3236         standard on how we use config.h in windows and it didn't make much sense to keep
3237         the prefix header and the config.h
3238
3239         * Drosera/DebuggerDocument.cpp:
3240         (DebuggerDocument::DebuggerDocument):
3241         * Drosera/DebuggerDocument.h:
3242         * Drosera/config.h:
3243         * Drosera/mac/DebuggerApplication.mm:
3244         (-[DebuggerApplication attach:]):
3245         * Drosera/mac/DebuggerClient.h:
3246         * Drosera/mac/DebuggerClient.mm:
3247         (-[DebuggerClient initWithServerConnection:]):
3248         (-[DebuggerClient dealloc]):
3249         (-[DebuggerClient windowDidLoad]):
3250         (-[DebuggerClient windowWillClose:]):
3251         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3252         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3253         * Drosera/mac/DebuggerDocumentPlatform.mm:
3254         (DebuggerDocument::platformPause):
3255         (DebuggerDocument::platformResume):
3256         (DebuggerDocument::platformStepInto):
3257         (DebuggerDocument::platformEvaluateScript):
3258         (DebuggerDocument::getPlatformCurrentFunctionStack):
3259         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3260         (DebuggerDocument::platformValueForScopeVariableNamed):
3261         (DebuggerDocument::platformLog):
3262         * Drosera/mac/Drosera.pch: Removed.
3263         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3264         * Drosera/mac/ServerConnection.h: Added.
3265         * Drosera/mac/ServerConnection.mm: Added.
3266         (-[ServerConnection initWithServerName:]):
3267         (-[ServerConnection dealloc]):
3268         (-[ServerConnection setGlobalContext:]):
3269         (-[ServerConnection pause]):
3270         (-[ServerConnection resume]):
3271         (-[ServerConnection stepInto]):
3272         (-[ServerConnection switchToServerNamed:]):
3273         (-[ServerConnection applicationTerminating:]):
3274         (-[ServerConnection serverConnectionDidDie:]):
3275         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3276         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3277         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3278         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3279         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3280         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3281         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3282         (-[ServerConnection currentFrame]):
3283         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3284         (-[ServerConnection knownServers]):
3285
3286 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3287
3288         Reviewed by Eric.
3289
3290         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3291           Script to automatically search nightly builds for regressions (bisect-builds)
3292
3293         * Scripts/bisect-builds: Added.
3294
3295 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3296
3297         Reviewed by Darin.
3298
3299         - New JavaScript benchmark
3300         http://bugs.webkit.org/show_bug.cgi?id=15515
3301
3302         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3303         current development or release build of JavaScriptCore.
3304
3305 2007-10-15  Mark Rowe  <mrowe@apple.com>
3306
3307         Reviewed by Sam.
3308
3309         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3310
3311         * Scripts/webkitdirs.pm:
3312         - Change checkArgv to remove the options from @ARGV to prevent
3313         them from interfering with further option processing.
3314         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3315         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3316         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3317         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3318
3319 2007-10-15  Darin Adler  <darin@apple.com>
3320
3321         Reviewed by Sam.
3322
3323         - added logging of window.prompt and window.confirm
3324
3325         * DumpRenderTree/mac/UIDelegate.mm:
3326         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3327         Implement the recommended delegate rather than the deprecated one.
3328         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3329         Added.
3330         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3331         Added.
3332
3333         * DumpRenderTree/win/UIDelegate.h:
3334         * DumpRenderTree/win/UIDelegate.cpp:
3335         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3336         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3337         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3338         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3339
3340 2007-10-15  Alice Liu  <alice.liu@apple.com>
3341
3342         Reviewed by Sam Weinig.
3343
3344         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3345
3346         * DumpRenderTree/win/DumpRenderTree.cpp:
3347         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3348         (main): allocate the global policy delegate for DRT's custom use
3349         * DumpRenderTree/win/DumpRenderTree.vcproj:
3350         Adding files to project
3351         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3352         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3353         (LayoutTestController::setCustomPolicyDelegate):
3354         set the webview's policy delegate to DRT's custom one if the test requests it.
3355         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3356         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3357         (PolicyDelegate::PolicyDelegate):
3358         (PolicyDelegate::QueryInterface):
3359         (PolicyDelegate::AddRef):
3360         (PolicyDelegate::Release):
3361         (PolicyDelegate::decidePolicyForNavigationAction):
3362         * DumpRenderTree/win/PolicyDelegate.h: Added.
3363         (PolicyDelegate::decidePolicyForNewWindowAction):
3364         (PolicyDelegate::decidePolicyForMIMEType):
3365         (PolicyDelegate::unableToImplementPolicyWithError):
3366
3367 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3368
3369         Reviewed by Mark.
3370
3371         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3372         when querying for QMAKE_MKSPECS.
3373
3374 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3375
3376         Reviewed by Adam Roben.
3377
3378         Fix run-webkit-tests is too greedy calculating platform hierarchy
3379         http://bugs.webkit.org/show_bug.cgi?id=15465
3380
3381         Fix run-webkit-tests being too greedy in trying to split the platform name up
3382         causing it to try and find tests in every directory above the first "-" in the
3383         path to the LayoutTests
3384
3385         * Scripts/run-webkit-tests:
3386
3387 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3388
3389         Reviewed by Darin.
3390
3391         http://bugs.webkit.org/show_bug.cgi?id=15006
3392         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3393         to reduce code duplication.
3394
3395         * Scripts/build-webkit:
3396         * Scripts/webkitdirs.pm:
3397         buildQMakeProject() renamed to buildQMakeQtProject().
3398         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3399         unused $colorize has been removed.
3400
3401 === Start merge of feature-branch 2007-10-12 ===
3402
3403 2007-10-08  Eric Seidel  <eric@webkit.org>
3404
3405         Reviewed by Mark Rowe.
3406
3407         * Scripts/build-webkit: add --help, remove unused --color
3408
3409 2007-10-07  Eric Seidel  <eric@webkit.org>
3410
3411         Reviewed by darin.
3412
3413         * Drosera/mac/DebuggerDocumentPlatform.mm:
3414         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3415
3416 2007-10-03  Rob Buis  <buis@kde.org>
3417
3418         Reviewed by Olliej.
3419
3420         Adapt to changed location of Ahem font.
3421
3422         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3423
3424 2007-10-02  Eric Seidel  <eric@webkit.org>
3425
3426         Reviewed by Adam Roben.
3427
3428         Make pixel tests more useful!
3429         Finally fix the image diff 0.00% mystery problem
3430         Highlight any image differences in the image diff.
3431         Add a link from image diffs back to original test file.
3432
3433         * DumpRenderTree/mac/ImageDiff.m:
3434         (compareImages): highlight any differences
3435         (computePercentageDifferent): round to two decimal places
3436         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3437
3438 2007-10-02  Eric Seidel  <eric@webkit.org>
3439
3440         Reviewed by Alexey Proskuryakov.
3441
3442         * Scripts/run-webkit-tests: print the % image difference on main results page
3443
3444 2007-10-02  Mark Rowe  <mrowe@apple.com>
3445
3446         Reviewed by Oliver.
3447
3448         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3449
3450         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3451         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3452
3453 2007-10-01  Mark Rowe  <mrowe@apple.com>
3454
3455         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3456
3457 2007-09-25  Eric Seidel  <eric@webkit.org>
3458
3459         Reviewed by Mark Rowe.
3460
3461         DerivedSources.make was finding "ENABLE_SVG" in the string
3462         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3463         quite correctly.
3464
3465         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3466
3467 2007-09-25  Mark Rowe  <mrowe@apple.com>
3468
3469         Rubber-stamped by Eric.
3470
3471         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3472         This makes it possible to automate nightly builds for the feature-branch.
3473
3474 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3475
3476         Rubber stamped by Mark.
3477
3478         Enable svg experimental features as default here in feature-branch.
3479
3480         * Scripts/build-webkit:
3481
3482 2007-06-29  Antti Koivisto  <antti@apple.com>
3483
3484         Reviewed by Weinig.
3485
3486         Add VIDEO flag for timed media features
3487
3488         * Scripts/build-webkit
3489
3490 === End merge of feature-branch 2007-10-12 ===
3491
3492 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3493
3494         Reviewed by Darin.
3495
3496         - Updated rational for the leaks list to be more clear.
3497
3498         * Scripts/run-webkit-tests:
3499
3500 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3501
3502         Rubber Stamp by Sam.
3503
3504         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3505         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3506
3507         * Scripts/run-webkit-tests:
3508
3509 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3510
3511         Reviewed by Lars.
3512
3513         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3514         includes are needed for INT_MAX, std::auto_ptr and the like.
3515
3516         * DumpRenderTree/qt/main.cpp:
3517
3518 2007-10-09  Lars Knoll  <lars@trolltech.com>
3519
3520         Reviewed by Simon.
3521
3522         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3523
3524         * DumpRenderTree/qt/jsobjects.cpp:
3525         (LayoutTestController::encodeHostName):
3526         (LayoutTestController::decodeHostName):
3527         * DumpRenderTree/qt/jsobjects.h:
3528
3529 2007-10-09  Lars Knoll  <lars@trolltech.com>
3530
3531         Reviewed by Simon.
3532
3533         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3534
3535         * DumpRenderTree/qt/DumpRenderTree.cpp:
3536         (WebCore::WebPage::createFrame):
3537         (WebCore::DumpRenderTree::DumpRenderTree):
3538         (WebCore::DumpRenderTree::titleChanged):
3539         * DumpRenderTree/qt/DumpRenderTree.h:
3540         * DumpRenderTree/qt/jsobjects.cpp:
3541         (LayoutTestController::reset):
3542         * DumpRenderTree/qt/jsobjects.h:
3543
3544 2007-10-09  Lars Knoll  <lars@trolltech.com>
3545
3546         Reviewed by Simon.
3547
3548         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3549
3550         * DumpRenderTree/qt/DumpRenderTree.h:
3551         * DumpRenderTree/qt/jsobjects.cpp:
3552         (LayoutTestController::clearBackForwardList):
3553         * DumpRenderTree/qt/jsobjects.h:
3554
3555 2007-10-09  Lars Knoll  <lars@trolltech.com>
3556
3557         Reviewed by Simon.
3558
3559         make --git-reviewer work again.
3560
3561         * Scripts/prepare-ChangeLog:
3562
3563 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3564
3565         Rubber stamped by Eric.
3566
3567         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3568         show the current link inside the statusbar.
3569         This shows how to make use of this signal and allows to easily test
3570         http://bugs.webkit.org/show_bug.cgi?id=15299.
3571
3572         * GtkLauncher/main.cpp:
3573         (hoveringOverLink):
3574         (main):
3575
3576 2007-10-05  Lars Knoll  <lars@trolltech.com>
3577
3578         add proper error messages to the FrameLoaderClient.
3579         Implement ChromeClientQt::closeWindowSoon and
3580         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3581         Some fixes in DRT to make it work correctly with multiple windows.
3582
3583         Reviewed by Maciej.
3584
3585         * DumpRenderTree/qt/DumpRenderTree.cpp:
3586         (WebCore::DumpRenderTree::DumpRenderTree):
3587         (WebCore::DumpRenderTree::createWindow):
3588         (WebCore::DumpRenderTree::windowCount):
3589         * DumpRenderTree/qt/DumpRenderTree.h:
3590         * DumpRenderTree/qt/jsobjects.cpp:
3591         (LayoutTestController::maybeDump):
3592         (LayoutTestController::windowCount):
3593         * DumpRenderTree/qt/jsobjects.h:
3594
3595 2007-10-05  Lars Knoll  <lars@trolltech.com>
3596
3597         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3598         Add support for layoutTextController.setCanOpenWindows() to DRT
3599         fixing another 2 test cases in fast/dom/Window.
3600
3601         Reviewed by Maciej.
3602
3603         * DumpRenderTree/qt/DumpRenderTree.cpp:
3604         (WebCore::WebPage::WebPage):
3605         (WebCore::WebPage::createWindow):
3606         (WebCore::DumpRenderTree::resetJSObjects):
3607         (WebCore::DumpRenderTree::createWindow):
3608         * DumpRenderTree/qt/DumpRenderTree.h:
3609         * DumpRenderTree/qt/DumpRenderTree.pro:
3610         * DumpRenderTree/qt/jsobjects.cpp:
3611         (LayoutTestController::LayoutTestController):