2010-01-04 Eric Seidel <eric@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-01-04  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Adam Barth.
4
5         bugzilla-tool should not require users to install mechanize
6         https://bugs.webkit.org/show_bug.cgi?id=32635
7
8         Use the nifty "autoinstall" module from Daniel Krech:
9         http://pypi.python.org/pypi/autoinstall/0.2
10         http://code.google.com/p/pyautoinstall/
11         It's available under a WebKit-compatible BSD license.
12
13         * Scripts/webkitpy/__init__.py:
14          - bind "mechanize" to an autoinstall importer which will
15            auto-download mechanize if necessary.
16         * Scripts/webkitpy/autoinstall.py: Added.
17         * Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize
18         * Scripts/webkitpy/statusbot.py: ditto.
19         * Scripts/webkitpy/webkit_mechanize.py: Removed.
20
21 2010-01-04  Adam Barth  <abarth@webkit.org>
22
23         Reviewed by Eric Seidel.
24
25         [bzt] Move AbstractSequencedCommand to a more general location
26         https://bugs.webkit.org/show_bug.cgi?id=33137
27
28         I do what the FIXME tell me to do.
29
30         * Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
31         * Scripts/webkitpy/commands/download.py:
32         * Scripts/webkitpy/commands/upload.py:
33
34 2010-01-04  Adam Barth  <abarth@webkit.org>
35
36         Reviewed by Eric Seidel.
37
38         Rename StatusBot to StatusServer
39         https://bugs.webkit.org/show_bug.cgi?id=33139
40
41         It's not a bot.  It's a server.
42
43         * Scripts/bugzilla-tool:
44         * Scripts/webkitpy/bugzilla.py:
45         * Scripts/webkitpy/commands/early_warning_system.py:
46         * Scripts/webkitpy/commands/queues.py:
47         * Scripts/webkitpy/mock_bugzillatool.py:
48         * Scripts/webkitpy/queueengine.py:
49         * Scripts/webkitpy/statusbot.py: Removed.
50
51 2010-01-04  Adam Barth  <abarth@webkit.org>
52
53         Reviewed by Eric Seidel.
54
55         [bzt] submit-pach should have a -o/--open option to open the bug after submit
56         https://bugs.webkit.org/show_bug.cgi?id=33136
57
58         Python makes this very easy.
59
60         * Scripts/webkitpy/mock_bugzillatool.py:
61         * Scripts/webkitpy/steps/options.py:
62         * Scripts/webkitpy/steps/postdiff.py:
63         * Scripts/webkitpy/user.py:
64
65 2010-01-04  Adam Barth  <abarth@webkit.org>
66
67         Reviewed by Eric Seidel.
68
69         [bzt] Move steps to a submodule
70         https://bugs.webkit.org/show_bug.cgi?id=33135
71
72         For great victory.  This will probably introduce some regressions
73         because our test coverage isn't perfect, but I've tried to be careful.
74
75         * Scripts/test-webkitpy:
76         * Scripts/webkitpy/buildsteps.py: Removed.
77         * Scripts/webkitpy/buildsteps_unittest.py: Removed.
78         * Scripts/webkitpy/commands/download.py:
79         * Scripts/webkitpy/commands/upload.py:
80         * Scripts/webkitpy/steps/__init__.py: Added.
81         * Scripts/webkitpy/steps/abstractstep.py: Added.
82         * Scripts/webkitpy/steps/applypatch.py: Added.
83         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added.
84         * Scripts/webkitpy/steps/build.py: Added.
85         * Scripts/webkitpy/steps/checkstyle.py: Added.
86         * Scripts/webkitpy/steps/cleanworkingdirectory.py: Added.
87         * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added.
88         * Scripts/webkitpy/steps/closebug.py: Added.
89         * Scripts/webkitpy/steps/closebugforlanddiff.py: Added.
90         * Scripts/webkitpy/steps/closepatch.py: Added.
91         * Scripts/webkitpy/steps/commit.py: Added.
92         * Scripts/webkitpy/steps/completerollout.py: Added.
93         * Scripts/webkitpy/steps/confirmdiff.py: Added.
94         * Scripts/webkitpy/steps/createbug.py: Added.
95         * Scripts/webkitpy/steps/editchangelog.py: Added.
96         * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added.
97         * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added.
98         * Scripts/webkitpy/steps/metastep.py: Added.
99         * Scripts/webkitpy/steps/obsoletepatches.py: Added.
100         * Scripts/webkitpy/steps/options.py: Added.
101         * Scripts/webkitpy/steps/postdiff.py: Added.
102         * Scripts/webkitpy/steps/preparechangelog.py: Added.
103         * Scripts/webkitpy/steps/preparechangelogforrevert.py: Added.
104         * Scripts/webkitpy/steps/promptforbugortitle.py: Added.
105         * Scripts/webkitpy/steps/revertrevision.py: Added.
106         * Scripts/webkitpy/steps/runtests.py: Added.
107         * Scripts/webkitpy/steps/steps_unittest.py: Added.
108         * Scripts/webkitpy/steps/update.py: Added.
109         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added.
110         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added.
111         * Scripts/webkitpy/stepsequence.py:
112
113 2010-01-04  Daniel Bates  <dbates@webkit.org>
114
115         Reviewed by Eric Seidel.
116
117         https://bugs.webkit.org/show_bug.cgi?id=33097
118
119         Cleans up the File menu to better conform to the File menu in Safari
120         both in terms of options and keyboard shortcuts. Adds a "Quit" menu
121         options to close all open windows. Also, renames the Tools menu to
122         Develop.
123
124         * QtLauncher/main.cpp:
125         (MainWindow::setupUI):
126
127 2010-01-04  Daniel Bates  <dbates@webkit.org>
128
129         https://bugs.webkit.org/show_bug.cgi?id=33039
130         
131         Unreviewed fix.
132
133         * Scripts/webkitpy/credentials.py:
134         * Scripts/webkitpy/credentials_unittest.py:
135
136 2010-01-04  Daniel Bates  <dbates@webkit.org>
137
138         Reviewed by Eric Seidel.
139
140         https://bugs.webkit.org/show_bug.cgi?id=33039
141
142         [bzt] Second attempt to fix an issue where bugzilla-tool dies
143         when the keychain lookup fails to find an entry for bugs.webkit.org.
144
145         * Scripts/webkitpy/credentials.py:
146         * Scripts/webkitpy/credentials_unittest.py:
147
148 2010-01-04  Eric Seidel  <eric@webkit.org>
149
150         Reviewed by Adam Barth.
151
152         Make Rollout an AbstractSequencedCommmand
153         https://bugs.webkit.org/show_bug.cgi?id=33133
154
155         As suggested by Adam in:
156         https://bugs.webkit.org/show_bug.cgi?id=33131#c2
157
158         * Scripts/webkitpy/commands/download.py:
159
160 2010-01-04  Eric Seidel  <eric@webkit.org>
161
162         Reviewed by Adam Barth.
163
164         Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses
165         https://bugs.webkit.org/show_bug.cgi?id=33131
166
167         Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command
168         but for now we just deploy it everywhere and don't try to fix up the few valid uses
169         of Command.
170
171         * Scripts/webkitpy/commands/download.py:
172         * Scripts/webkitpy/commands/queries.py:
173         * Scripts/webkitpy/commands/upload.py:
174         * Scripts/webkitpy/multicommandtool.py:
175
176 2010-01-03  Adam Barth  <abarth@webkit.org>
177
178         Unreviewed "build" fix.  Need to import ScriptError.
179
180         * Scripts/webkitpy/buildsteps.py:
181
182 2010-01-03  Adam Barth  <abarth@webkit.org>
183
184         Reviewed by Eric Seidel.
185
186         [bzt] Make it easier to run submit-patch when previous run cancelled
187         https://bugs.webkit.org/show_bug.cgi?id=33070
188
189         This patch renames create-review to submit-patch (as requested by
190         Maciej).
191
192         This patch makes it easier to run submit-patch after the user has
193         already cancelled a previous run of submit-patch by detecting when we
194         already have ChangeLogs and reading the bug number from them (and not
195         attempting to recreate them).  Aside from performance and the extra
196         edit step, this command should not subsume post-dif.
197
198         Also, added a --email command line argument so that the output of
199         prepare-ChangeLog makes sense when it can't find the user's email
200         address.
201
202         * Scripts/webkitpy/bugzilla.py:
203         * Scripts/webkitpy/buildsteps.py:
204         * Scripts/webkitpy/commands/upload.py:
205         * Scripts/webkitpy/commands/upload_unittest.py:
206         * Scripts/webkitpy/mock_bugzillatool.py:
207         * Scripts/webkitpy/user.py:
208
209 2010-01-03  Eric Seidel  <eric@webkit.org>
210
211         Reviewed by Adam Barth.
212
213         Rename Scripts/modules to Scripts/webkitpy
214         https://bugs.webkit.org/show_bug.cgi?id=33128
215
216         Just search-replace and svn mv commands.
217
218         * Scripts/bugzilla-tool:
219         * Scripts/check-webkit-style:
220         * Scripts/modules: Removed.
221         * Scripts/modules/BeautifulSoup.py: Removed.
222         * Scripts/modules/__init__.py: Removed.
223         * Scripts/modules/bugzilla.py: Removed.
224         * Scripts/modules/bugzilla_unittest.py: Removed.
225         * Scripts/modules/buildbot.py: Removed.
226         * Scripts/modules/buildbot_unittest.py: Removed.
227         * Scripts/modules/buildsteps.py: Removed.
228         * Scripts/modules/buildsteps_unittest.py: Removed.
229         * Scripts/modules/changelogs.py: Removed.
230         * Scripts/modules/changelogs_unittest.py: Removed.
231         * Scripts/modules/commands: Removed.
232         * Scripts/modules/commands/__init__.py: Removed.
233         * Scripts/modules/commands/commandtest.py: Removed.
234         * Scripts/modules/commands/download.py: Removed.
235         * Scripts/modules/commands/download_unittest.py: Removed.
236         * Scripts/modules/commands/early_warning_system.py: Removed.
237         * Scripts/modules/commands/early_warning_system_unittest.py: Removed.
238         * Scripts/modules/commands/queries.py: Removed.
239         * Scripts/modules/commands/queries_unittest.py: Removed.
240         * Scripts/modules/commands/queues.py: Removed.
241         * Scripts/modules/commands/queues_unittest.py: Removed.
242         * Scripts/modules/commands/queuestest.py: Removed.
243         * Scripts/modules/commands/upload.py: Removed.
244         * Scripts/modules/commands/upload_unittest.py: Removed.
245         * Scripts/modules/comments.py: Removed.
246         * Scripts/modules/committers.py: Removed.
247         * Scripts/modules/committers_unittest.py: Removed.
248         * Scripts/modules/cpp_style.py: Removed.
249         * Scripts/modules/cpp_style_unittest.py: Removed.
250         * Scripts/modules/credentials.py: Removed.
251         * Scripts/modules/credentials_unittest.py: Removed.
252         * Scripts/modules/diff_parser.py: Removed.
253         * Scripts/modules/diff_parser_unittest.py: Removed.
254         * Scripts/modules/executive.py: Removed.
255         * Scripts/modules/executive_unittest.py: Removed.
256         * Scripts/modules/grammar.py: Removed.
257         * Scripts/modules/mock.py: Removed.
258         * Scripts/modules/mock_bugzillatool.py: Removed.
259         * Scripts/modules/multicommandtool.py: Removed.
260         * Scripts/modules/multicommandtool_unittest.py: Removed.
261         * Scripts/modules/outputcapture.py: Removed.
262         * Scripts/modules/patchcollection.py: Removed.
263         * Scripts/modules/queueengine.py: Removed.
264         * Scripts/modules/queueengine_unittest.py: Removed.
265         * Scripts/modules/scm.py: Removed.
266         * Scripts/modules/scm_unittest.py: Removed.
267         * Scripts/modules/statusbot.py: Removed.
268         * Scripts/modules/stepsequence.py: Removed.
269         * Scripts/modules/style: Removed.
270         * Scripts/modules/style.py: Removed.
271         * Scripts/modules/style_unittest.py: Removed.
272         * Scripts/modules/text_style.py: Removed.
273         * Scripts/modules/text_style_unittest.py: Removed.
274         * Scripts/modules/user.py: Removed.
275         * Scripts/modules/webkit_logging.py: Removed.
276         * Scripts/modules/webkit_logging_unittest.py: Removed.
277         * Scripts/modules/webkit_mechanize.py: Removed.
278         * Scripts/modules/webkitport.py: Removed.
279         * Scripts/modules/webkitport_unittest.py: Removed.
280         * Scripts/test-webkit-python: Removed.
281         * Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python.
282         * Scripts/validate-committer-lists:
283         * Scripts/webkitpy: Copied from WebKitTools/Scripts/modules.
284         * Scripts/webkitpy/bugzilla.py:
285         * Scripts/webkitpy/bugzilla_unittest.py:
286         * Scripts/webkitpy/buildbot.py:
287         * Scripts/webkitpy/buildbot_unittest.py:
288         * Scripts/webkitpy/buildsteps.py:
289         * Scripts/webkitpy/buildsteps_unittest.py:
290         * Scripts/webkitpy/commands/commandtest.py:
291         * Scripts/webkitpy/commands/download.py:
292         * Scripts/webkitpy/commands/download_unittest.py:
293         * Scripts/webkitpy/commands/early_warning_system.py:
294         * Scripts/webkitpy/commands/early_warning_system_unittest.py:
295         * Scripts/webkitpy/commands/queries.py:
296         * Scripts/webkitpy/commands/queries_unittest.py:
297         * Scripts/webkitpy/commands/queues.py:
298         * Scripts/webkitpy/commands/queues_unittest.py:
299         * Scripts/webkitpy/commands/queuestest.py:
300         * Scripts/webkitpy/commands/upload.py:
301         * Scripts/webkitpy/commands/upload_unittest.py:
302         * Scripts/webkitpy/comments.py:
303         * Scripts/webkitpy/credentials.py:
304         * Scripts/webkitpy/credentials_unittest.py:
305         * Scripts/webkitpy/executive.py:
306         * Scripts/webkitpy/executive_unittest.py:
307         * Scripts/webkitpy/mock_bugzillatool.py:
308         * Scripts/webkitpy/multicommandtool.py:
309         * Scripts/webkitpy/multicommandtool_unittest.py:
310         * Scripts/webkitpy/queueengine.py:
311         * Scripts/webkitpy/queueengine_unittest.py:
312         * Scripts/webkitpy/scm.py:
313         * Scripts/webkitpy/scm_unittest.py:
314         * Scripts/webkitpy/statusbot.py:
315         * Scripts/webkitpy/stepsequence.py:
316         * Scripts/webkitpy/webkit_logging_unittest.py:
317         * Scripts/webkitpy/webkitport_unittest.py:
318
319 2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>
320
321         Reviewed by Eric Seidel.
322
323         Added script to test both Perl and Python, and renamed
324         run-webkit-unittests to test-webkit-python.
325
326         https://bugs.webkit.org/show_bug.cgi?id=33045
327
328         * Scripts/VCSUtils_unittest.pl:
329           - Tweaked so it can be run from outside Scripts directory.
330
331         * Scripts/run-webkit-unittests: Removed.
332           - Renamed to test-webkit-python.
333
334         * Scripts/test-webkit-perl:
335           - Tweaked so it can be run from outside Scripts directory.
336
337         * Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests.
338
339         * Scripts/test-webkit-scripts: Added.
340           - Runs both test-webkit-perl and test-webkit-python.
341
342 2010-01-03  Adam Barth  <abarth@webkit.org>
343
344         Reviewed by Eric Seidel.
345
346         commit-queue/bugzilla-tool should build both Debug and Release
347         https://bugs.webkit.org/show_bug.cgi?id=28450
348
349         Add a --build-style command that lets the master process tell the child
350         process to build both debug and release.  Eventually we want to teach
351         the test step to understand this option too, but that's a patch for
352         another day.
353
354         * Scripts/modules/buildsteps.py:
355         * Scripts/modules/commands/queues.py:
356         * Scripts/modules/webkitport.py:
357         * Scripts/modules/webkitport_unittest.py:
358
359 2010-01-03  Jakub Wieczorek  <faw217@gmail.com>
360
361         Reviewed by Eric Seidel.
362
363         [Qt] EventSender: add support for Enter key events
364         https://bugs.webkit.org/show_bug.cgi?id=33064
365
366         Unskip 5 tests that are fixed now.
367
368         * DumpRenderTree/qt/EventSenderQt.cpp:
369         (EventSender::keyDown):
370
371 2010-01-03  Adam Barth  <abarth@webkit.org>
372
373         Reviewed by Eric Seidel.
374
375         [bzt] Add test for previous typo fix
376         https://bugs.webkit.org/show_bug.cgi?id=33083
377
378         A trivial test for a trivial fix, as requested by Eric.
379
380         * Scripts/modules/bugzilla_unittest.py:
381
382 2010-01-03  Adam Barth  <abarth@webkit.org>
383
384         Reviewed by Eric Seidel.
385
386         Implement mac-ews
387         https://bugs.webkit.org/show_bug.cgi?id=33072
388
389         The mac-ews is slightly different than the other early warning systems
390         because we can't run Mac OS X inside a VM.  For that reason, we only
391         process patches that were uploaded by committers.  This isn't as much
392         coverage as the other EWS bots, but it's better than nothing.
393
394         * Scripts/modules/commands/early_warning_system.py:
395         * Scripts/modules/commands/early_warning_system_unittest.py:
396         * Scripts/modules/commands/queues.py:
397         * Scripts/modules/commands/queuestest.py:
398         * Scripts/modules/mock_bugzillatool.py:
399
400 2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>
401
402         Reviewed by David Kilzer.
403
404         Refactored svn-apply and svn-unapply to use a common "patch"
405         command method, and added unit tests for this new method.
406
407         https://bugs.webkit.org/show_bug.cgi?id=33098
408
409         * Scripts/VCSUtils.pm:
410           - Added generateRunPatchCommand().
411           - Added runPatchCommand().
412           - Added exitStatus() from webkitdirs.pm to address FIXME.
413
414         * Scripts/VCSUtils_unittest.pl:
415           - Added 10 unit tests for generateRunPatchCommand().
416           - Added 4 unit tests for runPatchCommand().
417           - Added callSilently() method.
418
419         * Scripts/svn-apply:
420           - Refactored applyPatch().
421           - Removed $pathScriptWasRunFrom global variable.
422           - Addressed issue where "--force" option was getting added twice.
423
424         * Scripts/svn-unapply:
425           - Refactored applyPatch().
426           - Removed $pathScriptWasRunFrom global variable.
427           - Added support for --force option.
428           - Enhanced to return meaningful exit status.
429
430         * Scripts/webkitdirs.pm:
431           - Moved exitStatus() implementation to VCSUtils.pm.
432
433 2009-12-31  Adam Barth  <abarth@webkit.org>
434
435         Reviewed by Eric Seidel.
436
437         [bzt] Implement build-and-test
438         https://bugs.webkit.org/show_bug.cgi?id=33073
439
440         Some of the early warning system bots want to use build-and-test so
441         they can cover LayoutTests in addition to just compilation.
442
443         * Scripts/modules/commands/download.py:
444         * Scripts/modules/commands/download_unittest.py:
445
446 2009-12-31  Adam Barth  <abarth@webkit.org>
447
448         Reviewed by Eric Seidel.
449
450         Show mac-ews status on QueueStatusServer
451         https://bugs.webkit.org/show_bug.cgi?id=33076
452
453         Also make error status purple.
454
455         * QueueStatusServer/model/attachment.py:
456         * QueueStatusServer/model/queues.py:
457         * QueueStatusServer/templates/dashboard.html:
458         * QueueStatusServer/templates/statusbubble.html:
459
460 2009-12-31  Adam Barth  <abarth@webkit.org>
461
462         Unreviewed.
463
464         [bzt] REGRESSION: Bugzila is a typo
465         https://bugs.webkit.org/show_bug.cgi?id=33074
466
467         Eric should test his code before landing!  :)
468
469         * Scripts/modules/bugzilla.py:
470
471 2009-12-31  Adam Barth  <abarth@webkit.org>
472
473         Unreviewed.  Fix the unit tests!
474
475         * Scripts/run-webkit-unittests:
476
477 2009-12-30  Kevin Watters  <kevinwatters@gmail.com>
478
479         Reviewed by Kevin Ollivier.
480
481         [wx] Alter a couple of default settings in the test app.
482         
483         https://bugs.webkit.org/show_bug.cgi?id=32956
484
485         * wx/browser/browser.cpp:
486         (MyApp::OnInit):
487
488 2009-12-30  Eric Seidel  <eric@webkit.org>
489
490         Reviewed by Adam Barth.
491
492         logging.py should be renamed to webkit_logging.py and eventually die
493         https://bugs.webkit.org/show_bug.cgi?id=33058
494
495         Change all imports of "logging" to webkit_logging,
496         except the ones which came from Google's cpp_lint.py and diff_parser.py
497         which clearly are assuming python's logging.py.
498
499         * Scripts/modules/bugzilla.py:
500         * Scripts/modules/buildbot.py:
501         * Scripts/modules/buildsteps.py:
502         * Scripts/modules/commands/download.py:
503         * Scripts/modules/commands/queries.py:
504         * Scripts/modules/commands/queues.py:
505         * Scripts/modules/commands/upload.py:
506         * Scripts/modules/credentials.py:
507         * Scripts/modules/executive.py:
508         * Scripts/modules/multicommandtool.py:
509         * Scripts/modules/queueengine.py:
510         * Scripts/modules/scm.py:
511         * Scripts/modules/statusbot.py:
512         * Scripts/modules/stepsequence.py:
513         * Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py.
514         * Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py.
515
516 2009-12-30  Jakub Wieczorek  <faw217@gmail.com>
517
518         Reviewed by Simon Hausmann.
519
520         [Qt] layoutTestController.pathToLocalResource() should return a path, not an URL
521         https://bugs.webkit.org/show_bug.cgi?id=33051
522
523         Moreover, its primary function is to normalize the path in regard of platform
524         specific directory separators. Therefore, it can simply make use of the
525         QDir::toNativeSeparators function.
526
527         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
528         (LayoutTestController::pathToLocalResource):
529
530 2009-12-30  David D. Kilzer  <ddkilzer@webkit.org>
531
532         Fix executable bits for r52646
533
534         * Scripts/VCSUtils_unittest.pl: Added property svn:executable.
535         * Scripts/test-webkit-perl: Ditto.
536
537 2009-12-29  Chris Jerdonek  <chris.jerdonek@gmail.com>
538
539         Reviewed by David Kilzer.
540
541         Fixed a bug in fixChangeLogPatch, made it work correctly in
542         more circumstances, and added unit tests.
543
544         https://bugs.webkit.org/show_bug.cgi?id=32919
545
546         * Scripts/VCSUtils.pm:
547           Rewrote fixChangeLogPatch.
548           
549         * Scripts/VCSUtils_unittest.pl: Added.
550           Added 7 unit tests for fixChangeLogPatch.
551
552         * Scripts/test-webkit-perl: Added.
553           Added test harness for unit tests of Perl code.
554
555 2009-12-29  Eric Seidel  <eric@webkit.org>
556
557         Reviewed by Adam Barth.
558
559         Split out BugzillaQueries class from Bugzilla
560         https://bugs.webkit.org/show_bug.cgi?id=33042
561
562         * Scripts/modules/bugzilla.py:
563          - Split out BugzillaQueries from Bugzilla.
564          - Try to isolate self.bugzilla usage into helper functions whenever possible.
565          - Add a bunch of FIXMEs.
566          - Rename fetch_bug_ids_from_needs_commit_list to fetch_bug_ids_from_pending_commit_list
567         * Scripts/modules/bugzilla_unittest.py:
568          - Create a new BugzillaQueriesTest testcase and move logic there.
569         * Scripts/modules/buildsteps_unittest.py:
570          - Use Bug 75 instead of 1 since bug 1 doesn't actually exist.
571         * Scripts/modules/commands/queries.py:
572          - Update to use bugzilla.queries
573         * Scripts/modules/commands/queues.py:
574          - Ditto.
575         * Scripts/modules/commands/upload.py:
576          - Ditto.
577         * Scripts/modules/mock_bugzillatool.py:
578          - Add a MockBugzillaQueries.
579          - Make patches and bugs global privates.
580          - Let _id_to_object_dictionary take a variable argument list instead of an array.
581
582 2009-12-29  Daniel Bates  <dbates@webkit.org>
583
584         Reviewed by Eric Seidel.
585
586         https://bugs.webkit.org/show_bug.cgi?id=33041
587
588         Speed up the test method test_read_credentials_with_SVN by not actually
589         creating an SVN repository to test against (by default). Instead, it is
590         sufficient to create a temporary directory that does not contain a Git
591         repository.
592
593         Also, renamed method test_read_credentials_with_SVN to
594         test_read_credentials_without_git_repo, to better reflect what it is
595         testing.
596
597         * Scripts/modules/credentials_unittest.py:
598
599 2009-12-29  Daniel Bates  <dbates@webkit.org>
600
601         Reviewed by Adam Barth.
602
603         https://bugs.webkit.org/show_bug.cgi?id=33039
604
605         [bzt] Fixes an issue where bugzilla-tool dies when the keychain lookup
606         fails to find an entry for bugs.webkit.org.
607         
608         Under Mac OS X, bugzilla-tool tries to query the keychain and Security
609         framework (via /usr/sbin/security) for an internet-password entry for
610         bugs.webkit.org so that it can use it to login to bugs.webkit.org.
611         However, if no such entry exists then bugzilla-tool dies with an error.
612
613         * Scripts/modules/credentials.py: Modified method _parse_security_tool_output to return
614         [None, None] if /usr/sbin/security cannot find keychain entry for bugs.webkit.org.
615         * Scripts/modules/credentials_unittest.py: Added method test_security_output_parse_entry_not_found.
616
617 2009-12-29  Eric Seidel  <eric@webkit.org>
618
619         Rubber-stamped by Adam Barth.
620
621         Remove unused BugzillaException.
622
623         * Scripts/modules/bugzilla.py:
624
625 2009-12-29  Eric Seidel  <eric@webkit.org>
626
627         Reviewed by Adam Barth.
628
629         Need a script to assign bugs with r+ patches to committers for landing
630         https://bugs.webkit.org/show_bug.cgi?id=33009
631
632         This is just one more small tool to help in the fight against our
633         ever-growing list of to-be-committed patches.
634
635         * Scripts/modules/bugzilla.py:
636          - Rename assign_to_email to assigned_to_email (typo).
637          - Add assigned_to_email() method on Bug.
638          - Add reassign_bug method.
639          - Add Bugzilla.unassigned_email, eventually should move to some webkit_config.py module.
640         * Scripts/modules/bugzilla_unittest.py:
641          - Update test after assigned_to_email rename.
642         * Scripts/modules/commands/commandtest.py:
643          - Call bind_to_tool to that self.tool works in Command testing.
644         * Scripts/modules/commands/download.py:
645          - Move AbstractDeclarativeCommmand multicommandtool.py, it should be part of Command.
646         * Scripts/modules/commands/queries_unittest.py:
647          - One of the test patches is now posted by "eric@webkit.org" which is a committer.
648          - Eventually we'll mock out CommitterList and be able to better control what's a committer and what's not.
649         * Scripts/modules/commands/upload.py:
650          - Add new assign-to-committer command.
651         * Scripts/modules/commands/upload_unittest.py:
652          - Add basic assign-to-committer test.
653         * Scripts/modules/committers.py:
654          - Add bugzilla_email() accessor.
655         * Scripts/modules/committers_unittest.py:
656          - Test our assumption that bugzilla_email is the first email.
657         * Scripts/modules/mock_bugzillatool.py:
658          - Add _id_to_object_dictionary for generating bug_cache from list of bugs.
659          - Remove unused fetch_attachments_from_bug.
660          - Add fetch_bug support and a bug_cache.
661         * Scripts/modules/multicommandtool.py:
662          - Move AbstractDeclarativeCommmand here from download.py
663
664 2009-12-29  Adam Barth  <abarth@webkit.org>
665
666         Reviewed by Eric Seidel.
667
668         [bzt] Don't crash if user types a number during PromptForBugOrTitleStep
669         https://bugs.webkit.org/show_bug.cgi?id=33038
670
671         Simple fix with test.
672
673         * Scripts/modules/buildsteps.py:
674         * Scripts/modules/buildsteps_unittest.py:
675
676 2009-12-29  Adam Barth  <abarth@webkit.org>
677
678         Reviewed by Eric Seidel.
679
680         [bzt] post-diff requires reading to the end
681         https://bugs.webkit.org/show_bug.cgi?id=33036
682
683         Catch the IOError caused by not reading to the end of the diff.  We
684         don't have a good way to test this currently.
685
686         * Scripts/modules/user.py:
687
688 2009-12-29  Chang Shu  <Chang.Shu@nokia.com>
689
690         Reviewed by Adam Barth.
691
692         [Qt] Move logic that handles Qt headers before primary headers
693         so that Qt headers won't be treated as primary headers by mistake.
694         https://bugs.webkit.org/show_bug.cgi?id=32991
695
696         * Scripts/modules/cpp_style.py:
697         * Scripts/modules/cpp_style_unittest.py:
698
699 2009-12-29  Eric Seidel  <eric@webkit.org>
700
701         Reviewed by Adam Barth.
702
703         Add the start of a Bug object for bugzilla.py
704         https://bugs.webkit.org/show_bug.cgi?id=32995
705
706         This allowed us to get rid of some duplicated "is_obsolete" checks.
707
708         * Scripts/modules/bugzilla.py:
709          - Add a new Bug class, and move patches/unreviewed_patches filtering logic there.
710          - Add _fetch_bug_page for possible future mocking.
711            (I did not try to test fetch_*_from_bug now due to difficulties with our current validate_reviewer logic.)
712          - Rename fetch_bug to fetch_bug_dictionary and add a new fetch_bug which returns a Bug object.
713          - Use fetch_bug and attachments(), patches(), etc. instead of custom fetch_*_from_bug methods.
714          - Reduce code in fetch_patches_from_pending_commit_list and fetch_patches_from_review_queue
715            using list comprehensions. Use a sum(list, []) trick to flatten a list of lists into a single list.
716         * Scripts/modules/bugzilla_unittest.py:
717          - Remove an unneeded unicode string marker.
718         * Scripts/modules/buildsteps.py:
719          - define __all__ to include just the BuildSteps
720         * Scripts/modules/commands/download.py:
721          - import * now that we have an __all__ defined.
722         * Scripts/modules/commands/upload.py:
723          - Use fetch_bug_dictionary instead of fetch_bug.
724
725 2009-12-29  Daniel Bates  <dbates@webkit.org>
726
727         Reviewed by Ariya Hidayat.
728
729         https://bugs.webkit.org/show_bug.cgi?id=32925
730
731         Adds an Open File dialog to make it convenient to open a file
732         to view in the browser.
733
734         Currently a person must either specify the path to a file as a
735         command-line argument or type a file URL. Instead, we should
736         have a file dialog to allow a person to open a file without
737         memorizing its path.
738
739         * QtLauncher/main.cpp:
740         (MainWindow::MainWindow): Changed urlEdit->setText(qurl.toEncoded())
741         to urlEdit->setText(qurl.toString()). 
742         (MainWindow::openFile): Added.
743         (MainWindow::changeLocation): Moved code to load URL into method
744         MainWindow::loadURL.
745         (MainWindow::loadURL): Added.
746         (MainWindow::setupUI): Added menu item Open File.
747
748 2009-12-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
749
750         Reviewed by Holger Freyther.
751
752         [GTK] fails fast/harness/use-page-cache.html
753         https://bugs.webkit.org/show_bug.cgi?id=33013
754
755         Make sure settings are forwarded to child WebViews.
756
757         * DumpRenderTree/gtk/DumpRenderTree.cpp:
758         (createWebView):
759
760 2009-12-29  Daniel Bates  <dbates@webkit.org>
761
762         Reviewed by Eric Seidel.
763
764         https://bugs.webkit.org/show_bug.cgi?id=32778
765
766         Changes $diffPercentage to be a number to resolve Perl
767         warning about comparing a string to a number.
768
769         * Scripts/run-webkit-tests:
770
771 2009-12-29  Jakub Wieczorek  <faw217@gmail.com>
772
773         Reviewed by Eric Seidel.
774
775         [Qt] DRT: Frame loader callbacks differ from the Mac port
776         https://bugs.webkit.org/show_bug.cgi?id=32989
777
778         Remove messages from the callbacks that should not dump them to match
779         the expected results for the http/loading tests.
780
781         Unskip some http/loading tests which succeed now.
782
783         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
784         (WebCore::DumpRenderTree::dump):
785
786 2009-12-29  Robert Hogan  <robert@roberthogan.net>
787
788         Reviewed by Eric Seidel.
789
790         [Qt] fix fast/dom/Window/window-onFocus.html
791         
792         Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
793         window.onblur was getting dispatched twice from QtWebKit.
794         
795         https://bugs.webkit.org/show_bug.cgi?id=32990
796
797         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
798         (WebCore::DumpRenderTree::DumpRenderTree):
799         (WebCore::DumpRenderTree::switchFocus):
800         * DumpRenderTree/qt/DumpRenderTreeQt.h:
801         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
802         (LayoutTestController::setWindowIsKey):
803         (LayoutTestController::setMainFrameIsFirstResponder):
804         * DumpRenderTree/qt/LayoutTestControllerQt.h:
805
806 2009-12-28  Kinuko Yasuda  <kinuko@chromium.org>
807
808         Reviewed by Maciej Stachowiak.
809
810         Extended EventSender.keyDown method to take another (3rd) argument
811         for indicating the keyLocation to make numeric pad key events testable.
812         Expected values for the argument is one of the KeyLocationCode
813         specified in DOM Level 3
814         (http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents).
815         https://bugs.webkit.org/show_bug.cgi?id=28247
816
817         Test: fast/events/keydown-numpad-keys.html
818
819         * DumpRenderTree/mac/EventSendingController.mm:
820         (+[EventSendingController isSelectorExcludedFromWebScript:]):
821         (+[EventSendingController webScriptNameForSelector:]):
822         (-[EventSendingController keyDown:withModifiers:withLocation:]):
823
824 2009-12-28  Ariya Hidayat  <ariya.hidayat@gmail.com>
825
826         Unreviewed, update my email address.
827
828         * Scripts/modules/committers.py:
829
830 2009-12-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
831
832         Reviewed by Adam Barth.
833
834         [Qt] Fix build break for Qt 4.4
835         https://bugs.webkit.org/show_bug.cgi?id=30327
836
837         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Include QLocale
838         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Ditto.
839         * QtLauncher/main.cpp:
840         (MainWindow::MainWindow): Qt::WA_TranslucentBackground was
841         introduced in Qt version 4.5
842
843 2009-12-28  Adam Barth  <abarth@webkit.org>
844
845         Reviewed by Eric Seidel.
846
847         [bzt] Add an edit-changelog command
848         https://bugs.webkit.org/show_bug.cgi?id=32986
849
850         This command makes it easier to edit ChangeLogs.  It's similar to
851         prepare-ChangeLog -o, except it works with already existing ChangeLogs.
852
853         * Scripts/modules/commands/upload.py:
854         * Scripts/modules/commands/upload_unittest.py:
855
856 2009-12-28  Adam Barth  <abarth@webkit.org>
857
858         Reviewed by Eric Seidel.
859
860         [bzt] Create an ASAD command for uploading a patch
861         https://bugs.webkit.org/show_bug.cgi?id=32979
862
863         The create-review command goes through the whole process of preparing a
864         code review, including creating a bug, editing the ChangeLogs, and
865         uploading the patch.  It is indeed the All Sing, All Dance upload
866         command.
867
868         * Scripts/modules/buildsteps.py:
869         * Scripts/modules/commands/upload.py:
870         * Scripts/modules/commands/upload_unittest.py:
871         * Scripts/modules/mock_bugzillatool.py:
872         * Scripts/modules/user.py:
873
874 2009-12-28  Adam Barth  <abarth@webkit.org>
875
876         Unreviewed "build" fix (with test!).
877
878         * Scripts/modules/bugzilla.py:
879         * Scripts/modules/bugzilla_unittest.py:
880
881 2009-12-27  Eric Seidel  <eric@webkit.org>
882
883         Reviewed by Adam Barth.
884
885         Add more awesome bug-parsing logic to bugzilla.py in preparation for assign-to-committer command
886         https://bugs.webkit.org/show_bug.cgi?id=32980
887
888         * Scripts/modules/bugzilla.py:
889          - Add a new _parse_bug_page function and use it in fetch_attachments_from_bug
890          - Replace fetch_title_from_bug with a new fetch_bug call instead.
891          - Use list comprehensions where possible to reduce code duplication.
892         * Scripts/modules/bugzilla_unittest.py:
893          - Add a minimal bug parsing test.
894          - Share code between bug parsing and attachment parsing tests with _assert_dictionaries_equal
895         * Scripts/modules/commands/upload.py:
896          - Use fetch_bug(bug_id)["title"] instead of fetch_title_from_bug
897
898 2009-12-27  Adam Barth  <abarth@webkit.org>
899
900         Reviewed by Eric Seidel.
901
902         Status bubble shouldn't be transparent for bots that haven't run yet
903         https://bugs.webkit.org/show_bug.cgi?id=32977
904
905         * QueueStatusServer/templates/statusbubble.html:
906
907 2009-12-27  Adam Barth  <abarth@webkit.org>
908
909         Reviewed by Eric Seidel.
910
911         [QueueStatusServer] Run gc cron job less often
912         https://bugs.webkit.org/show_bug.cgi?id=32958
913
914         Now that we've cleaned out the backlog of idle messages, we don't need
915         to run the gc job every half hour.  We could also stop logging the idle
916         messages, but this seems easier for the time being.
917
918         * QueueStatusServer/cron.yaml:
919
920 2009-12-27  Daniel Bates  <dbates@webkit.org>
921
922         Reviewed by Adam Barth.
923
924         https://bugs.webkit.org/show_bug.cgi?id=32896
925
926         Fixes an issue where bugzilla-tool tries to read the username and password from
927         Git regardless of whether Git is installed. In particular, if Git is not
928         installed then bugzilla-tool dies (with a trace) when it attempts to query Git
929         for the authentication credentials to log into bugs.webkit.org.
930
931         Moreover, modifies Executive.run_command to catch and pass OSError exceptions to
932         the specified error handler. For instance, the specified error handler will now
933         be called when the command does not exist (i.e. OSError errno 2).
934
935         * Scripts/modules/credentials.py: Added check for Git.
936         * Scripts/modules/credentials_unittest.py: Added test method
937         test_read_credentials_with_SVN.
938         * Scripts/modules/executive.py: Modified method run_command to catch
939         OSError exceptions (i.e [Errno 2] No such file or directory) and call
940         the specified error handler.
941         * Scripts/modules/executive_unittest.py: Added.
942         * Scripts/run-webkit-unittests: Added import executive_unittest.py.
943
944 2009-12-27  Daniel Bates  <dbates@webkit.org>
945
946         Unreviewed. Added missing file style_unittest.py that wasn't committed
947         in change set 52541 (http://trac.webkit.org/changeset/52541) as part of
948         the patch for bug #32592.
949
950         * Scripts/modules/style_unittest.py: Added.
951
952 2009-12-27  Daniel Bates  <dbates@webkit.org>
953
954         Reviewed by Eric Seidel.
955
956         https://bugs.webkit.org/show_bug.cgi?id=32964
957
958         [bzt] Updated the unit test based on the change made in bug #32951.
959
960         The change made in bug #32951 added the command-line argument:
961         --makeargs="-j8" to the build-webkit command. However, the associated
962         unit test was not updated.
963
964         * Scripts/modules/webkitport_unittest.py:
965
966 2009-12-27  Yael Aharon  <yael.aharon@nokia.com>
967
968         Reviewed by Darin Adler.
969
970         check-webkit-style should not mark moc files inclusion as errors
971         https://bugs.webkit.org/show_bug.cgi?id=32669
972
973         Add a new header type for moc files, and skip them when checking the order of header files.
974
975         * Scripts/modules/cpp_style.py:
976
977 2009-12-26  Adam Barth  <abarth@webkit.org>
978
979         Reviewed by Eric Seidel.
980
981         [bzt] Make the qt build go fast
982         https://bugs.webkit.org/show_bug.cgi?id=32951
983
984         Make use of multiple cores, if available.
985
986         * Scripts/modules/webkitport.py:
987
988 2009-12-25  Daniel Bates  <dbates@rim.com>
989
990         Reviewed by Eric Seidel.
991
992         https://bugs.webkit.org/show_bug.cgi?id=32682
993
994         Fixes an issue where checkFrameworks always dies with an error under Windows
995         since the clause "unless (-x $path)" is always satisfied because files under
996         Windows do not have an explict executable bit.
997
998         * Scripts/webkitdirs.pm:
999
1000 2009-12-23  Eric Seidel  <eric@webkit.org>
1001
1002         Reviewed by Adam Barth.
1003
1004         bugzilla-tool should accept global options anywhere
1005         https://bugs.webkit.org/show_bug.cgi?id=26912
1006
1007         * Scripts/bugzilla-tool:
1008          - Use the new global_options class property.
1009          - Add a handle_global_options callback to avoid needing callbacks for each global option.
1010         * Scripts/modules/multicommandtool.py:
1011          - Make the code use one combined option parser.
1012            This allows us to accept global options anywhere and
1013            individual command options before commands.
1014          - Add a handle_global_options callback to avoid needing callbacks for each global option.
1015          - Make the Command hold the option parser, but allow the tool to override it.
1016          - The default option parser is used for help printing and when Commands are run stand alone,
1017            but are otherwise not used.
1018          - Add Command.main to codify the idea that Commands should support being run stand-alone.
1019          - Change _split_args to _split_command_name_from_args now that args are unified.
1020         * Scripts/modules/multicommandtool_unittest.py:
1021          - Test that "tool" and "tool help" show the same help.
1022          - Test that args are accepted before commands
1023
1024 2009-12-20  Chris Jerdonek  <chris.jerdonek@gmail.com>
1025
1026         Reviewed by David Levin.
1027
1028         Moved some sections of code in preparation to refactor
1029         check-webkit-style's argument parser to avoid setting
1030         global variables.
1031
1032         https://bugs.webkit.org/show_bug.cgi?id=32592
1033
1034         * Scripts/check-webkit-style:
1035           - Moved _USAGE string to style.py.
1036           - Addressed FIXME by eliminating dependencies on cpp_style.py.
1037
1038         * Scripts/modules/cpp_style.py:
1039           - Moved default arguments and style categories to style.py.
1040           - Moved exit_with_usage(), exit_with_categories(), and
1041             parse_arguments() to style.py.
1042           - Removed references in _CppStyleState to the global
1043             variables now in style.py.
1044
1045         * Scripts/modules/cpp_style_unittest.py:
1046           - Moved parse_arguments() unit tests to style_unittest.py.
1047
1048         * Scripts/modules/style.py:
1049           - Added _USAGE string from check-webkit-style.
1050           - Added default arguments and style categories from cpp_style.py.
1051           - Added exit_with_usage(), exit_with_categories(), and
1052             parse_arguments() from cpp_sstyle.py.
1053
1054         * Scripts/modules/style_unittest.py: Added.
1055           - Added parse_arguments() unit tests from cpp_style_unittest.py.
1056
1057         * Scripts/run-webkit-unittests:
1058           - Added unit tests from style_unittest.py.
1059
1060 2009-12-23  Eric Seidel  <eric@webkit.org>
1061
1062         Reviewed by Adam Barth.
1063
1064         commit-queue should mention bug 30084 when rejecting patches until it can be fixed
1065         https://bugs.webkit.org/show_bug.cgi?id=32911
1066
1067         * Scripts/modules/bugzilla.py: Make the message even more fancy.
1068         * Scripts/modules/bugzilla_unittest.py: Test our new fancy message.
1069
1070 2009-12-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1071
1072         Not reviewed, adding myself to the reviewers list.
1073
1074         * Scripts/modules/committers.py:
1075
1076 2009-12-23  Adam Barth  <abarth@webkit.org>
1077
1078         Reviewed by Eric Seidel.
1079
1080         [bzt] Create a prepare-diff command that creates a bug and a ChangeLog
1081         https://bugs.webkit.org/show_bug.cgi?id=32895
1082
1083         The workflow Maciej and I discussed is as follows:
1084
1085         1) Write code.
1086         2) bugzilla-tool prepare-diff
1087         3) Edit ChangeLogs
1088         4) bugzilla-tool post-diff
1089
1090         We might want to experimenting with combining 2-4 into a single
1091         command, but that might be stressful to edit the ChangeLogs modally.
1092
1093         Removed submit-patch since it has the modal ChangeLog editing but none
1094         oof the bug creating fun.
1095
1096         * Scripts/modules/bugzilla.py:
1097         * Scripts/modules/buildsteps.py:
1098         * Scripts/modules/commands/upload.py:
1099         * Scripts/modules/commands/upload_unittest.py:
1100
1101 2009-12-23  Gabor Loki  <loki@webkit.org>
1102
1103         Unreviewed; added myself to the committers list.
1104
1105         * Scripts/modules/committers.py:
1106
1107 2009-12-22  Adam Barth  <abarth@webkit.org>
1108
1109         Reviewed by Maciej Stachowiak.
1110
1111         [bzt] Don't call create-patch twice during post-diff
1112         https://bugs.webkit.org/show_bug.cgi?id=32893
1113
1114         If we call create-patch to get the bug number, cache the diff in the
1115         state so we don't need to call it again.
1116
1117         * Scripts/modules/buildsteps.py:
1118         * Scripts/modules/commands/upload.py:
1119
1120 2009-12-22  Daniel Bates  <dbates@rim.com>
1121
1122         Reviewed by Eric Seidel.
1123
1124         https://bugs.webkit.org/show_bug.cgi?id=32680
1125
1126         Fixes an issue in builtDylibPathForName so that it returns the correct
1127         path to the built QtWebKit library on the Qt Windows port. Currently,
1128         it returns the path to the file named QtWebKit.dll but this file does
1129         not exist on the Qt Windows build. Instead, the file is named
1130         QtWebKit4.dll.
1131
1132         * Scripts/webkitdirs.pm:
1133
1134 2009-12-22  Marc-Antoine Ruel  <maruel@chromium.org>
1135
1136         Reviewed by Adam Roben.
1137
1138         Remove the only dependency on perl-libwin32 in cygwin
1139
1140         * Scripts/num-cpus:
1141
1142 2009-12-22  Darin Adler  <darin@apple.com>
1143
1144         * pywebsocket/mod_pywebsocket: Added property svn:ignore to ignore
1145         generated ".pyc" files.
1146
1147 2009-12-22  Darin Adler  <darin@apple.com>
1148
1149         Reviewed by Mark Rowe.
1150
1151         Turn off datagrid by default, at least for all platforms Apple ships.
1152         The datagrid implementation isn't ready for general web use yet.
1153
1154         * Scripts/build-webkit: Turn off datagrid by default.
1155
1156 2009-12-22  Eric Seidel  <eric@webkit.org>
1157
1158         Reviewed by Darin Adler.
1159
1160         validate-committer-lists fails when run from an SVN checkout
1161         https://bugs.webkit.org/show_bug.cgi?id=31974
1162
1163         * Scripts/validate-committer-lists:
1164          - Make it print a warning message instead of throwing
1165            an exception when running from an SVN checkout.
1166
1167 2009-12-22  Philippe Normand  <pnormand@igalia.com>
1168
1169         Reviewed by Adam Barth.
1170
1171         check-webkit-style should not warn about NULL usage in g_object_{get,set}
1172         https://bugs.webkit.org/show_bug.cgi?id=32858
1173
1174         * Scripts/modules/cpp_style.py:
1175         * Scripts/modules/cpp_style_unittest.py:
1176
1177 2009-12-22  Simon Hausmann  <simon.hausmann@nokia.com>
1178
1179         Rubber-stamped by Holger Freyther.
1180
1181         Moved QtLauncher from WebKit/qt.
1182
1183         * QtLauncher: Copied from WebKit/qt/QtLauncher.
1184         * QtLauncher/QtLauncher.pro:
1185
1186 2009-12-21  Adam Barth  <abarth@webkit.org>
1187
1188         Reviewed by Eric Seidel.
1189
1190         [bzt] Automate the process of calling prepare-ChangeLog
1191         https://bugs.webkit.org/show_bug.cgi?id=32816
1192
1193         This patch automates the process of creating a bug and patch and
1194         uploading it to bugzilla.  The first cut just calls
1195         prepare-ChangeLog.
1196
1197         This patch required some refactoring of upload.py to the Step
1198         model, but that's worth doing anyway.
1199
1200         * Scripts/bugzilla-tool:
1201         * Scripts/modules/buildsteps.py:
1202         * Scripts/modules/commands/download.py:
1203         * Scripts/modules/commands/upload.py:
1204         * Scripts/modules/commands/upload_unittest.py:
1205         * Scripts/modules/mock_bugzillatool.py:
1206
1207 2009-12-21  Darin Adler  <darin@apple.com>
1208
1209         * Scripts/do-webcore-rename: Did a rename, so checking in the
1210         version of the script I used.
1211
1212 2009-12-21  Adam Barth  <abarth@webkit.org>
1213
1214         Reviewed by Eric Seidel.
1215
1216         Update status-bubble to show all the queues
1217         https://bugs.webkit.org/show_bug.cgi?id=32838
1218
1219         Also, move statusbubble over to use memcache.
1220
1221         * QueueStatusServer/handlers/statusbubble.py:
1222         * QueueStatusServer/templates/statusbubble.html:
1223
1224 2009-12-21  Adam Barth  <abarth@webkit.org>
1225
1226         Reviewed by Eric Seidel.
1227
1228         Delete the boring "Empty queue" status messages in QueueStatusServer
1229         https://bugs.webkit.org/show_bug.cgi?id=32818
1230
1231         * QueueStatusServer/app.yaml:
1232         * QueueStatusServer/cron.yaml:
1233         * QueueStatusServer/handlers/gc.py:
1234         * QueueStatusServer/main.py:
1235
1236 2009-12-21  Adam Barth  <abarth@webkit.org>
1237
1238         Reviewed by Eric Seidel.
1239
1240         Exception on queue status server
1241         https://bugs.webkit.org/show_bug.cgi?id=32812
1242
1243         Turns out we need to pass the id to the filter.
1244
1245         * QueueStatusServer/filters/webkit_extras.py:
1246         * QueueStatusServer/templates/patch.html:
1247         * QueueStatusServer/templates/recentstatus.html:
1248
1249 2009-12-20  Chris Jerdonek  <chris.jerdonek@gmail.com>
1250
1251         Reviewed by Eric Seidel.
1252
1253         Created "style" folder for code supporting check-webkit-style.
1254
1255         * Scripts/modules/style: Added.
1256
1257 2009-12-20  Adam Barth  <abarth@webkit.org>
1258
1259         Reviewed by Eric Seidel.
1260
1261         REGRESSION: error when running commit-queue
1262         https://bugs.webkit.org/show_bug.cgi?id=32806
1263
1264         Fix typo and add test!
1265
1266         * Scripts/modules/bugzilla.py:
1267         * Scripts/modules/bugzilla_unittest.py:
1268
1269 2009-12-20  Adam Barth  <abarth@webkit.org>
1270
1271         [bzt] Optimize status updates for new dashboard
1272         https://bugs.webkit.org/show_bug.cgi?id=32797
1273
1274         This patch makes the queues slightly more chatty with the web service.
1275         Also, this patch introduces some testing for the queues!
1276
1277         * Scripts/modules/commands/early_warning_system.py:
1278         * Scripts/modules/commands/early_warning_system_unittest.py: Added.
1279         * Scripts/modules/commands/queues.py:
1280         * Scripts/modules/commands/queues_unittest.py:
1281         * Scripts/modules/commands/queuestest.py: Added.
1282         * Scripts/modules/mock_bugzillatool.py:
1283         * Scripts/modules/patchcollection.py:
1284         * Scripts/modules/queueengine.py:
1285         * Scripts/run-webkit-unittests:
1286
1287 2009-12-20  Adam Barth  <abarth@webkit.org>
1288
1289         Reviewed by Eric Seidel.
1290
1291         Prepare QueueStatusServer for new status messages
1292         https://bugs.webkit.org/show_bug.cgi?id=32805
1293
1294         * QueueStatusServer/handlers/recentstatus.py:
1295         * QueueStatusServer/index.html: Removed.
1296         * QueueStatusServer/model/attachment.py:
1297         * QueueStatusServer/model/queues.py: Added.
1298         * QueueStatusServer/templates/recentstatus.html: Added.
1299
1300 2009-12-20  Shinichiro Hamaji  <hamaji@chromium.org>
1301
1302         Reviewed by Adam Barth.
1303
1304         [check-webkit-style] static_cast is not misnamed!
1305         https://bugs.webkit.org/show_bug.cgi?id=32796
1306
1307         * Scripts/modules/cpp_style.py:
1308         * Scripts/modules/cpp_style_unittest.py:
1309
1310 2009-12-20  Alejandro G. Castro  <alex@igalia.com>
1311
1312         Reviewed by Gustavo Noronha Silva.
1313
1314         [GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
1315         https://bugs.webkit.org/show_bug.cgi?id=32788
1316
1317         Do not increase the click count if we are using a different button.
1318
1319         * DumpRenderTree/gtk/EventSender.cpp:
1320
1321 2009-12-20  Adam Barth  <abarth@webkit.org>
1322
1323         Reviewed by Eric Seidel.
1324
1325         [QueueStatusServer] Add a per-patch details page
1326         https://bugs.webkit.org/show_bug.cgi?id=32784
1327
1328         This is a first cut at a per-patch details page.  I'm sure we'll have
1329         to iterate.
1330
1331         * QueueStatusServer/filters/webkit_extras.py:
1332         * QueueStatusServer/handlers/patch.py: Added.
1333         * QueueStatusServer/index.yaml:
1334         * QueueStatusServer/main.py:
1335         * QueueStatusServer/model/attachment.py:
1336         * QueueStatusServer/stylesheets/dashboard.css:
1337         * QueueStatusServer/templates/dashboard.html:
1338         * QueueStatusServer/templates/patch.html: Added.
1339
1340 2009-12-20  Adam Barth  <abarth@webkit.org>
1341
1342         Reviewed by Eric Seidel.
1343
1344         Use memcache to make dashboard to fast
1345         https://bugs.webkit.org/show_bug.cgi?id=32780
1346
1347         * QueueStatusServer/app.yaml:
1348         * QueueStatusServer/handlers/dashboard.py:
1349         * QueueStatusServer/handlers/updatestatus.py:
1350         * QueueStatusServer/model/attachment.py: Added.
1351
1352 2009-12-19  Brent Fulgham  <bfulgham@webkit.org>
1353
1354         Reviewed by Adam Roben.
1355
1356         Provide an example implementation for printing under Windows.
1357         http://bugs.webkit.org/show_bug.cgi?id=32504.`
1358
1359         * WinLauncher/PrintWebUIDelegate.cpp: Added.
1360         (PrintWebUIDelegate::QueryInterface):
1361         (PrintWebUIDelegate::AddRef):
1362         (PrintWebUIDelegate::Release):
1363         (PrintWebUIDelegate::webViewPrintingMarginRect):
1364         * WinLauncher/PrintWebUIDelegate.h: Added.
1365         (PrintWebUIDelegate::PrintWebUIDelegate):
1366         (PrintWebUIDelegate::createWebViewWithRequest):
1367         (PrintWebUIDelegate::webViewShow):
1368         (PrintWebUIDelegate::webViewClose):
1369         (PrintWebUIDelegate::webViewFocus):
1370         (PrintWebUIDelegate::webViewUnfocus):
1371         (PrintWebUIDelegate::webViewFirstResponder):
1372         (PrintWebUIDelegate::makeFirstResponder):
1373         (PrintWebUIDelegate::setStatusText):
1374         (PrintWebUIDelegate::webViewStatusText):
1375         (PrintWebUIDelegate::webViewAreToolbarsVisible):
1376         (PrintWebUIDelegate::setToolbarsVisible):
1377         (PrintWebUIDelegate::webViewIsStatusBarVisible):
1378         (PrintWebUIDelegate::setStatusBarVisible):
1379         (PrintWebUIDelegate::webViewIsResizable):
1380         (PrintWebUIDelegate::setResizable):
1381         (PrintWebUIDelegate::setFrame):
1382         (PrintWebUIDelegate::webViewFrame):
1383         (PrintWebUIDelegate::setContentRect):
1384         (PrintWebUIDelegate::webViewContentRect):
1385         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage):
1386         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage):
1387         (PrintWebUIDelegate::runJavaScriptTextInputPanelWithPrompt):
1388         (PrintWebUIDelegate::runBeforeUnloadConfirmPanelWithMessage):
1389         (PrintWebUIDelegate::runOpenPanelForFileButtonWithResultListener):
1390         (PrintWebUIDelegate::mouseDidMoveOverElement):
1391         (PrintWebUIDelegate::contextMenuItemsForElement):
1392         (PrintWebUIDelegate::validateUserInterfaceItem):
1393         (PrintWebUIDelegate::shouldPerformAction):
1394         (PrintWebUIDelegate::dragDestinationActionMaskForDraggingInfo):
1395         (PrintWebUIDelegate::willPerformDragDestinationAction):
1396         (PrintWebUIDelegate::dragSourceActionMaskForPoint):
1397         (PrintWebUIDelegate::willPerformDragSourceAction):
1398         (PrintWebUIDelegate::contextMenuItemSelected):
1399         (PrintWebUIDelegate::hasCustomMenuImplementation):
1400         (PrintWebUIDelegate::trackCustomPopupMenu):
1401         (PrintWebUIDelegate::measureCustomMenuItem):
1402         (PrintWebUIDelegate::drawCustomMenuItem):
1403         (PrintWebUIDelegate::addCustomMenuDrawingData):
1404         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
1405         (PrintWebUIDelegate::canTakeFocus):
1406         (PrintWebUIDelegate::takeFocus):
1407         (PrintWebUIDelegate::registerUndoWithTarget):
1408         (PrintWebUIDelegate::removeAllActionsWithTarget):
1409         (PrintWebUIDelegate::setActionTitle):
1410         (PrintWebUIDelegate::undo):
1411         (PrintWebUIDelegate::redo):
1412         (PrintWebUIDelegate::canUndo):
1413         (PrintWebUIDelegate::canRedo):
1414         (PrintWebUIDelegate::printFrame):
1415         (PrintWebUIDelegate::ftpDirectoryTemplatePath):
1416         (PrintWebUIDelegate::webViewHeaderHeight):
1417         (PrintWebUIDelegate::webViewFooterHeight):
1418         (PrintWebUIDelegate::drawHeaderInRect):
1419         (PrintWebUIDelegate::drawFooterInRect):
1420         (PrintWebUIDelegate::canRunModal):
1421         (PrintWebUIDelegate::createModalDialog):
1422         (PrintWebUIDelegate::runModal):
1423         (PrintWebUIDelegate::isMenuBarVisible):
1424         (PrintWebUIDelegate::setMenuBarVisible):
1425         (PrintWebUIDelegate::runDatabaseSizeLimitPrompt):
1426         (PrintWebUIDelegate::paintCustomScrollbar):
1427         (PrintWebUIDelegate::paintCustomScrollCorner):
1428         * WinLauncher/WinLauncher.cpp: Add new UI delegate for print support.
1429         (WinLauncherWebHost::updateAddressBar): check-webkit-style fixes.
1430         (WinLauncherWebHost::QueryInterface): check-webkit-style fixes.
1431         (WinLauncherWebHost::AddRef): check-webkit-style fixes.
1432         (WinLauncherWebHost::Release): check-webkit-style fixes.
1433         (resizeSubViews): check-webkit-style fixes.
1434         (_tWinMain): check-webkit-style fixes.
1435         (MyRegisterClass): check-webkit-style fixes.
1436         (InitInstance): check-webkit-style fixes.
1437         (AbortProc): New print support function.
1438         (getPrinterDC): New print support function.
1439         (initDocStruct): New print support function.
1440         (PrintView): New printing implementation.
1441         (WndProc): Add support for printing.
1442         (MyEditProc): check-webkit-style fixes.
1443         (About): check-webkit-style fixes.
1444         (loadURL): check-webkit-style fixes.
1445         * WinLauncher/WinLauncher.h:
1446         (WinLauncherWebHost::WinLauncherWebHost):
1447         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
1448         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
1449         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1450         (WinLauncherWebHost::didCommitLoadForFrame):
1451         (WinLauncherWebHost::didReceiveTitle):
1452         (WinLauncherWebHost::didReceiveIcon):
1453         (WinLauncherWebHost::didFinishLoadForFrame):
1454         (WinLauncherWebHost::didFailLoadWithError):
1455         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
1456         (WinLauncherWebHost::willPerformClientRedirectToURL):
1457         (WinLauncherWebHost::didCancelClientRedirectForFrame):
1458         (WinLauncherWebHost::willCloseFrame):
1459         (WinLauncherWebHost::windowScriptObjectAvailable):
1460         * WinLauncher/WinLauncher.rc: Add menu entry for printing.
1461         * WinLauncher/WinLauncher.vcproj: Add new files.
1462         * WinLauncher/resource.h: Add menu entry for printing.
1463
1464 2009-12-19  Adam Barth  <abarth@webkit.org>
1465
1466         Unreviewed.  Tweak the CSS to make the dashboard prettier.
1467
1468         * QueueStatusServer/stylesheets/dashboard.css:
1469         * QueueStatusServer/templates/dashboard.html:
1470
1471 2009-12-19  Adam Barth  <abarth@webkit.org>
1472
1473         Reviewed by Eric Seidel.
1474
1475         QueueStatusServer needs a human readable dashboard
1476         https://bugs.webkit.org/show_bug.cgi?id=32769
1477
1478         Here is a first cut at the dashboard.  There's a lot left to do.
1479
1480         * QueueStatusServer/filters/webkit_extras.py:
1481         * QueueStatusServer/handlers/dashboard.py: Added.
1482         * QueueStatusServer/handlers/patchstatus.py:
1483         * QueueStatusServer/handlers/recentstatus.py:
1484         * QueueStatusServer/handlers/showresults.py:
1485         * QueueStatusServer/handlers/statusbubble.py:
1486         * QueueStatusServer/handlers/updatestatus.py:
1487         * QueueStatusServer/main.py:
1488         * QueueStatusServer/model/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
1489         * QueueStatusServer/model/queuestatus.py: Renamed from WebKitTools/QueueStatusServer/model.py.
1490         * QueueStatusServer/stylesheets/dashboard.css: Added.
1491         * QueueStatusServer/templates/dashboard.html: Added.
1492         * QueueStatusServer/templates/statusbubble.html: Renamed from WebKitTools/QueueStatusServer/status_bubble.html.
1493         * QueueStatusServer/templates/updatestatus.html: Renamed from WebKitTools/QueueStatusServer/update_status.html.
1494
1495 2009-12-19  Daniel Bates  <dbates@webkit.org>
1496
1497         Reviewed by Timothy Hatcher.
1498
1499         https://bugs.webkit.org/show_bug.cgi?id=32462
1500
1501         Added --inspector-frontend flag to build-webkit to copy any changes
1502         to the inspector front-end files to the built WebCore framework. This
1503         will make inspector development more consistent with the rest of
1504         WebKit development.
1505
1506         * Scripts/build-webkit:
1507         * Scripts/webkitdirs.pm:
1508
1509 2009-12-19  Adam Barth  <abarth@webkit.org>
1510
1511         Unreviewed fixes for me being terrible at python.
1512
1513         * Scripts/modules/bugzilla.py:
1514         * Scripts/run-webkit-unittests:
1515
1516 2009-12-18  Adam Barth  <abarth@webkit.org>
1517
1518         Reviewed by Eric Seidel.
1519
1520         Split QueueStatus server into modules
1521         https://bugs.webkit.org/show_bug.cgi?id=32768
1522
1523         One monolithic file is no good.
1524
1525         * QueueStatusServer/app.yaml:
1526         * QueueStatusServer/handlers/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
1527         * QueueStatusServer/handlers/patchstatus.py: Added.
1528         * QueueStatusServer/handlers/recentstatus.py: Added.
1529         * QueueStatusServer/handlers/showresults.py: Added.
1530         * QueueStatusServer/handlers/statusbubble.py: Added.
1531         * QueueStatusServer/handlers/updatestatus.py: Added.
1532         * QueueStatusServer/main.py: Added.
1533         * QueueStatusServer/model.py: Added.
1534         * QueueStatusServer/queue_status.py: Removed.
1535
1536 2009-12-18  Adam Barth  <abarth@webkit.org>
1537
1538         Rubber stamped by Eric Seidel.
1539
1540         Renamed WorkQueue to QueueEngine.  WorkQueue is not a queue.
1541
1542         * Scripts/modules/commands/queues.py:
1543         * Scripts/modules/queueengine.py: Added.
1544         * Scripts/modules/queueengine_unittest.py: Added.
1545         * Scripts/modules/stepsequence.py:
1546         * Scripts/modules/workqueue.py: Removed.
1547         * Scripts/modules/workqueue_unittest.py: Removed.
1548
1549 2009-12-18  Adam Barth  <abarth@webkit.org>
1550
1551         Reviewed by Eric Seidel.
1552
1553         Add watches for EWS
1554         https://bugs.webkit.org/show_bug.cgi?id=32767
1555
1556         dglazkov wanted to be added.
1557
1558         * Scripts/modules/bugzilla.py:
1559         * Scripts/modules/commands/early_warning_system.py:
1560         * Scripts/modules/commands/queues.py:
1561
1562 2009-12-18  Eric Seidel  <eric@webkit.org>
1563
1564         Reviewed by David Levin.
1565
1566         move bugzilla.py off of urllib2
1567         https://bugs.webkit.org/show_bug.cgi?id=32729
1568
1569         * Scripts/modules/bugzilla.py: use mechanize for all url fetching.
1570
1571 2009-12-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1572
1573         Rubber-stamped by Xan Lopez.
1574
1575         [GTK] New events (pageshow and pagehide) tests failing
1576         https://bugs.webkit.org/show_bug.cgi?id=28823
1577
1578         Original patch by Jan Michael Alonzo.
1579
1580         Disable page cache for tests.
1581
1582         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1583         (resetDefaultsToConsistentValues):
1584         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1585         (copyWebSettingKey):
1586         (LayoutTestController::overridePreference):
1587
1588 2009-12-18  Fumitoshi Ukai  <ukai@chromium.org>
1589
1590         Reviewed by David Levin.
1591
1592         Check one space before end of line comments.
1593         https://bugs.webkit.org/show_bug.cgi?id=32597
1594         
1595         Fix to check one space before end of line comments in whitespace and build/header_guard.
1596         Also fix build/header_guard to use WebKit header guard defines.
1597
1598         * Scripts/modules/cpp_style.py:
1599         * Scripts/modules/cpp_style_unittest.py:
1600
1601 2009-12-17  Sam Weinig  <sam@webkit.org>
1602
1603         Reviewed by Mark Rowe.
1604
1605         Add BUILDING_ON_SNOW_LEOPARD #define.
1606
1607         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1608
1609 2009-12-17  Yuzo Fujishima  <yuzo@google.com>
1610
1611         Reviewed by Alexey Proskuryakov.
1612
1613         Update pywebsocket to 0.4.5 and make handshake checking stricter
1614         https://bugs.webkit.org/show_bug.cgi?id=32249
1615
1616         * Scripts/run-webkit-tests:
1617         * pywebsocket/mod_pywebsocket/handshake.py:
1618         * pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
1619         * pywebsocket/mod_pywebsocket/standalone.py:
1620         * pywebsocket/setup.py:
1621         * pywebsocket/test/test_handshake.py:
1622         * pywebsocket/test/test_memorizingfile.py: Added.
1623
1624 2009-12-17  Eric Seidel  <eric@webkit.org>
1625
1626         Reviewed by Adam Barth.
1627
1628         Command.show_in_main_help should default to False
1629         https://bugs.webkit.org/show_bug.cgi?id=32686
1630
1631         * Scripts/modules/commands/download.py:
1632         * Scripts/modules/commands/queries.py:
1633         * Scripts/modules/commands/queues.py:
1634         * Scripts/modules/commands/upload.py:
1635         * Scripts/modules/multicommandtool.py:
1636
1637 2009-12-17  Alejandro G. Castro  <alex@igalia.com>
1638
1639         Reviewed by Eric Seidel.
1640
1641         Added the key WebKitEnableCaretBrowsing to the
1642         layoutTestController.overridePreference in order to activate caret
1643         browsing.
1644         https://bugs.webkit.org/show_bug.cgi?id=32612
1645
1646         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added the reset value of
1647         the setting.
1648         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Inserted the new
1649         key in the keytable.
1650
1651 2009-12-17  Chris Fleizach  <cfleizach@apple.com>
1652
1653         Reviewed by David Kilzer.
1654
1655         AX: DRT needs to support URL for accessibility
1656         https://bugs.webkit.org/show_bug.cgi?id=32666
1657
1658         * DumpRenderTree/AccessibilityUIElement.cpp:
1659         (getURLCallback):
1660         (AccessibilityUIElement::getJSClass):
1661         * DumpRenderTree/AccessibilityUIElement.h:
1662         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1663         (AccessibilityUIElement::url):
1664         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1665         (AccessibilityUIElement::url):
1666         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1667         (AccessibilityUIElement::url):
1668
1669 2009-12-17  Philippe Normand  <pnormand@igalia.com>
1670
1671         Unreviewed; added myself to committers
1672
1673         * Scripts/modules/committers.py:
1674
1675 2009-12-17  Benjamin Otte  <otte@gnome.org>
1676
1677         Unreviewed; added myself to committers
1678
1679         * Scripts/modules/committers.py:
1680
1681 2009-12-17  Adam Barth  <abarth@webkit.org>
1682
1683         Rubber stamp by Seidel.
1684
1685         Clean up exception handling in WorkQueue.  Basically, a bunch of the
1686         delegate messages can throw exceptions because of network errors.  We
1687         want the queues to keep on ticking instead of erroring out.  That means
1688         we want to catch generic exceptions and continue looping.
1689
1690         Also, cleaned up the exception handling in the EWS to properly log
1691         failures.
1692
1693         * Scripts/modules/commands/early_warning_system.py:
1694         * Scripts/modules/commands/queues.py:
1695         * Scripts/modules/workqueue.py:
1696
1697 2009-12-16  Adam Barth  <abarth@webkit.org>
1698
1699         Reviewed by Eric Seidel.
1700
1701         [bzt] Make UpdateStep quiet
1702         https://bugs.webkit.org/show_bug.cgi?id=32599
1703
1704         * Scripts/modules/buildsteps.py:
1705         * Scripts/modules/buildsteps_unittest.py:
1706
1707 2009-12-16  Evan Martin  <evan@chromium.org>
1708
1709         Reviewed by Adam Barth.
1710
1711         Add Gtk to the early warning system WebKit port list.
1712
1713         https://bugs.webkit.org/show_bug.cgi?id=32629
1714
1715         * Scripts/modules/commands/early_warning_system.py:
1716         * Scripts/modules/webkitport.py:
1717         * Scripts/modules/webkitport_unittest.py:
1718
1719 2009-12-16  Eric Seidel  <eric@webkit.org>
1720
1721         Reviewed by Adam Barth.
1722
1723         post-diff is failing with exception under guess_reviewer_from_bug
1724         https://bugs.webkit.org/show_bug.cgi?id=32642
1725
1726         Also refactor output capturing code into
1727         OutputCapture.assert_outputs to share more code between tests.
1728
1729         * Scripts/modules/buildsteps.py:
1730          - Add the missing include.
1731          - Give guess_reviewer_from_bug a private underscore.
1732         * Scripts/modules/buildsteps_unittest.py: Added.
1733          - Test to make sure _guess_reviewer_from_bug works as expected.
1734         * Scripts/modules/commands/commandtest.py:
1735          - Custom code is now obsoleted by OutputCapture.assert_outputs
1736         * Scripts/modules/commands/queues_unittest.py:
1737          - ditto
1738         * Scripts/modules/credentials_unittest.py:
1739          - ditto
1740         * Scripts/modules/mock_bugzillatool.py:
1741          - fetch_reviewed_patches_from_bug can never return None
1742         * Scripts/modules/multicommandtool_unittest.py:
1743          - Custom code is now obsoleted by OutputCapture.assert_outputs
1744         * Scripts/modules/outputcapture.py:
1745          - Add assert_outputs to share more code between tests.
1746         * Scripts/run-webkit-unittests:
1747          - Add buildsteps_unittest.py
1748
1749 2009-12-16  Adam Barth  <abarth@webkit.org>
1750
1751         Unreviewed.  Added a default argument to _update_status so that callers
1752         don't have to explictly pass None when they don't have a patch object.
1753
1754         * Scripts/modules/commands/queues.py:
1755
1756 2009-12-16  Kent Tamura  <tkent@chromium.org>
1757
1758         Reviewed by David Levin.
1759
1760         check-webkit-style supports for TAB check against text files.
1761         https://bugs.webkit.org/show_bug.cgi?id=32538
1762
1763         * Scripts/check-webkit-style:
1764           Move process_patch() to style.py.
1765         * Scripts/modules/cpp_style.py:
1766           Add can_handle().
1767         * Scripts/modules/cpp_style_unittest.py:
1768           Add tests for can_handle().
1769         * Scripts/modules/style.py:
1770           Added. This is a front-end of cpp_style and text_style. It dispatches
1771           files to an appropriate linter.
1772         * Scripts/modules/text_style.py:
1773           Added. This is a linter module for generic text files. It supports
1774           only for TAB checking at this moment.
1775         * Scripts/modules/text_style_unittest.py:
1776           Added. Tests for text_style.py.
1777         * Scripts/run-webkit-unittests:
1778           Add text_style_unittest.
1779
1780 2009-12-16  Eric Seidel  <eric@webkit.org>
1781
1782         Reviewed by David Levin.
1783
1784         bugzilla-tool should not require users to install mechanize
1785         https://bugs.webkit.org/show_bug.cgi?id=32635
1786
1787         Centralize our import logic.
1788
1789         * Scripts/modules/bugzilla.py: use webkit_mechanize
1790         * Scripts/modules/statusbot.py: use webkit_mechanize
1791         * Scripts/modules/webkit_mechanize.py: Added.
1792
1793 2009-12-16  Eric Seidel  <eric@webkit.org>
1794
1795         Reviewed by Adam Barth.
1796
1797         Generalize commit-queue recent status page for all queues
1798         https://bugs.webkit.org/show_bug.cgi?id=32633
1799
1800         * QueueStatusServer/index.html:
1801          - Generalize to support other queues.
1802         * QueueStatusServer/queue_status.py:
1803          - Generalize MainPage to support other queues.
1804
1805 2009-12-16  Evan Martin  <evan@chromium.org>
1806
1807         Reviewed by Adam Barth.
1808
1809         Early warning system server should display output as UTF-8.
1810
1811         https://bugs.webkit.org/show_bug.cgi?id=32625
1812
1813         * QueueStatusServer/queue_status.py:
1814
1815 2009-12-16  Adam Barth  <abarth@webkit.org>
1816
1817         Reviewed by Eric Seidel.
1818
1819         [bzt] Add error handling to the early warning system
1820         https://bugs.webkit.org/show_bug.cgi?id=32594
1821
1822         This should be the last step in making the EWS operational.  When we
1823         have a build error, we post the log to QueueStatusServer and add a link
1824         to the bug.
1825
1826         * Scripts/modules/commands/early_warning_system.py:
1827         * Scripts/modules/commands/queues.py:
1828         * Scripts/modules/executive.py:
1829
1830 2009-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
1831
1832         Reviewed by Holger Freyther.
1833
1834         Fix crash with tests that use custom font faces.
1835
1836         https://bugs.webkit.org/show_bug.cgi?id=32600
1837
1838         In the DRT we call QApplication::removeAllApplicationFonts(), to make sure
1839         that custom font faces between tests don't influence each other. Calling this
1840         function in Qt however also invalidates all existing handles with QFontDatabase.
1841
1842         In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(),
1843         which implies a call to WebCore::FontCache::fontCache()->invalidate().
1844
1845         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1846         (WebCore::DumpRenderTree::open):
1847
1848 2009-12-16  Andreas Kling  <andreas.kling@nokia.com>
1849
1850         Reviewed by Simon Hausmann.
1851
1852         [Qt] Maintain button state between mouse events.
1853
1854         This allows eventSender to generate drag events.
1855
1856         https://bugs.webkit.org/show_bug.cgi?id=32601
1857
1858         * DumpRenderTree/qt/EventSenderQt.cpp:
1859         (EventSender::mouseDown):
1860         (EventSender::mouseUp):
1861         (EventSender::mouseMoveTo):
1862         * DumpRenderTree/qt/EventSenderQt.h:
1863
1864 2009-12-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
1865
1866         Reviewed by David Levin.
1867
1868         Code clean-up in check-webkit-style as described below.
1869         The only functional changes are minor improvements to the
1870         script's help output.
1871         
1872         https://bugs.webkit.org/show_bug.cgi?id=32487
1873
1874         * Scripts/check-webkit-style:
1875           - Added the module docstring from cpp_style.py.
1876           - Improved wording of the --help output and added some of the
1877             default values as substitution strings.
1878           - Called cpp_style.exit_with_usage instead of sys.stderr.write
1879             in main function.
1880           - Made changes caused by changes to cpp_style.py.
1881
1882         * Scripts/modules/cpp_style.py:
1883           - Removed module docstring, as well as redundant _USAGE string
1884             and main() function obsoleted by check-webkit-style.
1885           - Moved specification of default script values from within a
1886             function definition to global variables.
1887           - Moved the default webkit filter rules to be near the other
1888             global variables.
1889           - Renamed "FILTER" global variables to "FILTER_RULES" to
1890             establish unambiguous terminology.
1891           - Renamed _ERROR_CATEGORIES to _STYLE_CATEGORIES.
1892           - Changed _STYLE_CATEGORIES from a string to a list.
1893           - Added default webkit filter rules to --filter= output.
1894           - Renamed "print_" methods to "exit_with_" since they exist
1895             and added a temporary display_help parameter.
1896           - Added a temporary display_help parameter to parse_arguments.
1897
1898         * Scripts/modules/cpp_style_unittest.py:
1899           - Made changes caused by changes to cpp_style.py.
1900           - Lower-cased ErrorCollector's ERROR_CATEGORIES instance 
1901             variables since they are not global.
1902
1903 2009-12-15  Adam Barth  <abarth@webkit.org>
1904
1905         Unreviewed fix for the style-queue.
1906         Typo: _updates_status -> _update_status
1907
1908         We need to improve our testing infrastructure for the queues.
1909
1910         * Scripts/modules/commands/queues.py:
1911
1912 2009-12-15  Adam Barth  <abarth@webkit.org>
1913
1914         Unreviewed fix for the style-queue.  I suspect this is a recent
1915         regression from Eric's change below.
1916
1917         * Scripts/modules/commands/queues.py:
1918
1919 2009-12-15  Yaar Schnitman  <yaar@chromium.org>
1920
1921         Reviewed by Darin Fisher.
1922
1923         update-webkit-chromium to auto-install gclient
1924
1925         https://bugs.webkit.org/show_bug.cgi?id=32587
1926
1927         * Scripts/update-webkit-chromium:
1928
1929 2009-12-15  Eric Seidel  <eric@webkit.org>
1930
1931         Reviewed by Adam Barth.
1932
1933         bugzilla-tool / commit-queue should add results links to bugs when more results are available on the status bot
1934         https://bugs.webkit.org/show_bug.cgi?id=32546
1935
1936         You can see an example of this working in:
1937         https://bugs.webkit.org/show_bug.cgi?id=32585#c3
1938
1939         * QueueStatusServer/queue_status.py:
1940          - Output the id of the newly created status.
1941         * Scripts/modules/commands/queues.py:
1942          - Tweak the commit-queue logging to include a full status link.
1943         * Scripts/modules/statusbot.py:
1944          - update_status should return the newly created status id.
1945
1946 2009-12-15  Andras Becsi  <abecsi@inf.u-szeged.hu>
1947
1948         Reviewed by Tor Arne Vestbø.
1949
1950         [Qt] Rename Qt DRT components to match other ports' naming convention and to be more understandable.
1951
1952         * DumpRenderTree/qt/DumpRenderTree.cpp: Removed.
1953         * DumpRenderTree/qt/DumpRenderTree.h: Removed.
1954         * DumpRenderTree/qt/DumpRenderTree.pro: Updated.
1955         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp.
1956         * DumpRenderTree/qt/DumpRenderTreeQt.h: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.h.
1957         * DumpRenderTree/qt/GCControllerQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.cpp.
1958         (GCController::GCController):
1959         * DumpRenderTree/qt/GCControllerQt.h: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.h.
1960         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1961         * DumpRenderTree/qt/WorkQueueItem.h: Removed.
1962         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Updated includes.
1963         * DumpRenderTree/qt/WorkQueueItemQt.h: Copied from WebKitTools/DumpRenderTree/qt/WorkQueueItem.h.
1964         * DumpRenderTree/qt/jsobjects.cpp: Removed.
1965         * DumpRenderTree/qt/jsobjects.h: Removed.
1966         * DumpRenderTree/qt/main.cpp: Updated includes.
1967
1968 2009-12-15  Adam Barth  <abarth@webkit.org>
1969
1970         Reviewed by Eric Seidel.
1971
1972         We have two mark-fixed commands
1973         https://bugs.webkit.org/show_bug.cgi?id=32073
1974
1975         * Scripts/mark-bug-fixed: Removed.
1976         * Scripts/modules/commands/upload.py:
1977         * Scripts/modules/commands/upload_unittest.py:
1978
1979 2009-12-15  Eric Seidel  <eric@webkit.org>
1980
1981         Reviewed by Adam Barth.
1982
1983         bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected
1984         https://bugs.webkit.org/show_bug.cgi?id=28286
1985
1986         * QueueStatusServer/index.html:
1987          - Show [results] links if a results log was uploaded.
1988         * QueueStatusServer/queue_status.py:
1989          - Empty file uploads appear as u"" and Blob does not handle unicode, so convert to str().
1990         * Scripts/modules/commands/queues.py:
1991          - Post to the status bot when a patch fails and include the failure log as a results file.
1992
1993 2009-12-15  Eric Seidel  <eric@webkit.org>
1994
1995         Reviewed by Adam Barth.
1996
1997         queue sub-commands need --status-host so they can report status
1998         https://bugs.webkit.org/show_bug.cgi?id=32313
1999
2000         Make --status-bot a global option and make
2001         run_bugzilla_tool pass --status-bot to sub-commands.
2002
2003         * Scripts/bugzilla-tool:
2004          - Rename _status to status_bot and make it non-lazy.
2005         * Scripts/modules/commands/queues.py:
2006          - Move status updates out of WorkQueue and into individual queues.
2007         * Scripts/modules/commands/queues_unittest.py:
2008          - Test that --status-host is passed to bugzilla-tool when run as subcommand.
2009         * Scripts/modules/mock_bugzillatool.py:
2010          - Add a MockStatusBot
2011         * Scripts/modules/workqueue.py:
2012          - Remove status_host and work_work_logs_directory callbacks.
2013          - Add new work_item_log_path callback so that WorkQueue doesn't need to know about patches!
2014         * Scripts/modules/workqueue_unittest.py:
2015          - Update unit tests to reflect new callbacks.
2016
2017 2009-12-15  Adam Barth  <abarth@webkit.org>
2018
2019         Reviewed by Eric Seidel.
2020
2021         scm_unittest.py is too slow
2022         https://bugs.webkit.org/show_bug.cgi?id=31818
2023
2024         Now we don't run the SCM unit tests unless we get the --all flag on the
2025         command line.  Eric and I were commenting out this test because it was
2026         too painful to run.
2027
2028         * Scripts/run-webkit-unittests:
2029
2030 2009-12-14  Adam Barth  <abarth@webkit.org>
2031
2032         Unreviewed.  Fix failing unittest.
2033
2034         * Scripts/modules/bugzilla_unittest.py:
2035
2036 2009-12-14  Eric Seidel  <eric@webkit.org>
2037
2038         Reviewed by Adam Barth.
2039
2040         Move Credential handling out into a separate module
2041         https://bugs.webkit.org/show_bug.cgi?id=32531
2042
2043         * Scripts/modules/bugzilla.py:
2044         * Scripts/modules/credentials.py: Added.
2045         * Scripts/modules/credentials_unittest.py: Added.
2046         * Scripts/run-webkit-unittests:
2047
2048 2009-12-14  Adam Barth  <abarth@webkit.org>
2049
2050         Reviewed by Eric Seidel.
2051
2052         Kill _create_step_sequence
2053         https://bugs.webkit.org/show_bug.cgi?id=32539
2054
2055         It's cleaner to represent not having these sequences as an empty
2056         sequence instead of None.
2057
2058         * Scripts/modules/commands/download.py:
2059         * Scripts/modules/stepsequence.py:
2060
2061 2009-12-14  Adam Barth  <abarth@webkit.org>
2062
2063         Unreviewed.  Address reviewer comments from an earlier patch.  I didn't
2064         do this earlier because I was worried about conflicts in dependent
2065         patches.
2066
2067         * Scripts/modules/commands/download.py:
2068
2069 2009-12-14  Adam Barth  <abarth@webkit.org>
2070
2071         Reviewed by Eric Seidel.
2072
2073         [bzt] Make download commands declarative
2074         https://bugs.webkit.org/show_bug.cgi?id=32469
2075
2076         This patch "properly" factors most of the download commands.  These
2077         commands are now largely declarative, which is the final step of this
2078         grand refactoring.
2079
2080         * Scripts/modules/buildsteps.py:
2081         * Scripts/modules/commands/download.py:
2082
2083 2009-12-14  Adam Barth  <abarth@webkit.org>
2084
2085         Reviewed by Eric Seidel.
2086
2087         [bzt] Add AbstractPatchSequencingCommand to remove redundant code
2088         https://bugs.webkit.org/show_bug.cgi?id=32468
2089
2090         Redundant code is bad.  This patch moves us towards more declarative
2091         commands.
2092
2093         * Scripts/modules/commands/download.py:
2094
2095 2009-12-14  Adam Barth  <abarth@webkit.org>
2096
2097         Reviewed by Eric Seidel.
2098
2099         [bzt] Kill WebKitApplyingScripts
2100         https://bugs.webkit.org/show_bug.cgi?id=32467
2101
2102         Ah!  I've been wanting to do this for a long time.  This patch brings
2103         the applying commands into the patch processing fold.
2104
2105         * Scripts/bugzilla-tool:
2106         * Scripts/modules/buildsteps.py:
2107         * Scripts/modules/commands/download.py:
2108         * Scripts/modules/commands/download_unittest.py:
2109         * Scripts/modules/mock_bugzillatool.py:
2110
2111 2009-12-14  Adam Barth  <abarth@webkit.org>
2112
2113         Reviewed by Eric Seidel.
2114
2115         [bzt] Convert rollout to StepSequence
2116         https://bugs.webkit.org/show_bug.cgi?id=32406
2117
2118         * Scripts/modules/buildsteps.py:
2119         * Scripts/modules/commands/download.py:
2120         * Scripts/modules/commands/download_unittest.py:
2121         * Scripts/modules/mock_bugzillatool.py:
2122
2123 2009-12-14  Adam Barth  <abarth@webkit.org>
2124
2125         Reviewed by Eric Seidel.
2126
2127         [bzt] Kill LandingSequence
2128         https://bugs.webkit.org/show_bug.cgi?id=32464
2129
2130         Removes LandingSequence in favor of StepSequence.  This required
2131         changing the Step API slightly to carry a general notion of state
2132         instead of carrying patches specifically.
2133
2134         * Scripts/modules/buildsteps.py:
2135         * Scripts/modules/commands/download.py:
2136         * Scripts/modules/commands/queues.py:
2137         * Scripts/modules/landingsequence.py: Removed.
2138         * Scripts/modules/stepsequence.py:
2139
2140 2009-12-14  Robert Hogan  <robert@roberthogan.net>
2141
2142         Reviewed by Eric Seidel.
2143
2144         [Qt] Fix https://bugs.webkit.org/show_bug.cgi?id=32437
2145         
2146         Amend the behaviour of DRT::notifyDone to dump only when
2147         the page has finished loading.
2148         
2149         This fix permits removal of the following tests from the Qt skipped list:
2150         fast/forms/textarea-linewrap-dynamic.html
2151         fast/forms/textarea-setvalue-submit.html
2152         fast/forms/textarea-hard-linewrap-empty.html
2153         fast/forms/submit-to-url-fragment.html
2154         http/tests/misc/percent-sign-in-form-field-name.html
2155         http/tests/security/escape-form-data-field-names.html
2156         
2157         However it also requires the following two to be added to the skipped list:
2158         
2159         http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
2160         svg/custom/use-instanceRoot-as-event-target.xhtml
2161         
2162         It appears the behaviour of notifyDone was masking problems with these two
2163         tests.
2164
2165         * DumpRenderTree/qt/DumpRenderTree.cpp:
2166         (WebCore::DumpRenderTree::DumpRenderTree):
2167         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2168         (LayoutTestController::reset):
2169         (LayoutTestController::processWork):
2170         (LayoutTestController::maybeDump):
2171         (LayoutTestController::notifyDone):
2172         (LayoutTestController::provisionalLoad):
2173         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2174         (LayoutTestController::resetLoadFinished):
2175
2176 2009-12-14  Simon Hausmann  <hausmann@webkit.org>
2177
2178         Reviewed by Holger Freyther.
2179
2180         [Qt] Add support for keyboard modifiers to Qt DRT's EventSender for touch events
2181
2182         https://bugs.webkit.org/show_bug.cgi?id=32482
2183
2184         * DumpRenderTree/qt/EventSenderQt.cpp:
2185         (EventSender::setTouchModifier):
2186         (EventSender::clearTouchPoints):
2187         (EventSender::sendTouchEvent):
2188         * DumpRenderTree/qt/EventSenderQt.h:
2189
2190 2009-12-13  Maciej Stachowiak  <mjs@apple.com>
2191
2192         Reviewed by Gavin Barraclaugh.
2193
2194         Fix minor problem in sunspider-compare-results which left it broken.
2195
2196         * Scripts/sunspider-compare-results: Declare $parseonly
2197
2198 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
2199
2200         Reviewed by Oliver Hunt.
2201
2202         Give command-line sunspider the ability to handle multiple suites and versions
2203         https://bugs.webkit.org/show_bug.cgi?id=32477
2204
2205         * Scripts/run-sunspider: Updated for changes to command-line parameters.
2206         * Scripts/sunspider-compare-results: ditto
2207
2208 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
2209
2210         Not reviewed, fixing previous comment.
2211
2212         Remove accidental change to sunspider-compare-results
2213
2214         * Scripts/sunspider-compare-results:
2215
2216 2009-12-11  Yael Aharon  <yael.aharon@nokia.com>
2217
2218         Unreviewed build fix for Qt versions < 4.6. 
2219         Guard every slot individually with #ifdef.
2220
2221         * DumpRenderTree/qt/EventSenderQt.cpp:
2222         (EventSender::addTouchPoint):
2223         (EventSender::updateTouchPoint):
2224         (EventSender::touchStart):
2225         (EventSender::touchMove):
2226         (EventSender::touchEnd):
2227         (EventSender::clearTouchPoints):
2228         (EventSender::releaseTouchPoint):
2229         (EventSender::sendTouchEvent):
2230         * DumpRenderTree/qt/EventSenderQt.h:
2231
2232 2009-12-11  Eric Seidel  <eric@webkit.org>
2233
2234         Reviewed by Adam Barth.
2235
2236         CommandsTest.assert_execute_outputs doesn't check stderr
2237         https://bugs.webkit.org/show_bug.cgi?id=32352
2238
2239         Fix assert_execute_outputs to check stderr
2240         and then fix all the unit tests which needed to
2241         pass stderr output.
2242
2243         * Scripts/modules/commands/commandtest.py:
2244         * Scripts/modules/commands/download_unittest.py:
2245         * Scripts/modules/commands/upload_unittest.py:
2246
2247 2009-12-11  Adam Barth  <abarth@webkit.org>
2248
2249         Reviewed by Eric Seidel.
2250
2251         [check-webkit-style] False positive for tst_QWebFrame
2252         https://bugs.webkit.org/show_bug.cgi?id=32436
2253
2254         Add an exception for function names that start with "tst_".  These are
2255         used by the Qt unit testing framework.
2256
2257         * Scripts/modules/cpp_style.py:
2258         * Scripts/modules/cpp_style_unittest.py:
2259
2260 2009-12-11  Simon Hausmann  <hausmann@webkit.org>, Kim Grönholm  <kim.gronholm@nomovok.com>
2261
2262         Reviewed by Antti Koivisto.
2263
2264         Added support for creating synthetic touch events with EventSender
2265         in Qt's DumpRenderTree.
2266
2267         https://bugs.webkit.org/show_bug.cgi?id=32114
2268
2269         * DumpRenderTree/qt/EventSenderQt.cpp:
2270         (EventSender::addTouchPoint):
2271         (EventSender::updateTouchPoint):
2272         (EventSender::touchStart):
2273         (EventSender::touchMove):
2274         (EventSender::touchEnd):
2275         (EventSender::clearTouchPoints):
2276         (EventSender::releaseTouchPoint):
2277         (EventSender::sendTouchEvent):
2278         * DumpRenderTree/qt/EventSenderQt.h:
2279
2280 2009-12-11  Benjamin Poulain  <benjamin.poulain@nokia.com>
2281
2282         Reviewed by Darin Adler.
2283
2284         The values of RuntimeArray are not enumerable
2285         https://bugs.webkit.org/show_bug.cgi?id=29005
2286
2287         * DumpRenderTree/mac/ObjCController.m:
2288         (+[ObjCController isSelectorExcludedFromWebScript:]):
2289         (+[ObjCController webScriptNameForSelector:]):
2290         (-[ObjCController arrayOfString]):
2291
2292 2009-12-10  Eric Seidel  <eric@webkit.org>
2293
2294         No review, just updating unit tests to match recent checkins.
2295
2296         * Scripts/modules/mock_bugzillatool.py:
2297          - Add missing red_core_builders_names method causing exception.
2298         * Scripts/modules/workqueue_unittest.py:
2299          - processutils is dead, use executive.py instead.
2300
2301 2009-12-10  Eric Seidel  <eric@webkit.org>
2302
2303         Reviewed by Adam Barth.
2304
2305         Move run_command onto Executive to make code which uses run_command testable
2306         https://bugs.webkit.org/show_bug.cgi?id=32396
2307
2308         * Scripts/modules/executive.py:
2309          - Move run_command and error handlers onto Executive.
2310         * Scripts/modules/scm.py:
2311         * Scripts/modules/scm_unittest.py:
2312
2313 2009-12-09  Eric Seidel  <eric@webkit.org>
2314
2315         Reviewed by Adam Barth.
2316
2317         bugzilla-tool needs a command to list patches needing cq+
2318         https://bugs.webkit.org/show_bug.cgi?id=32351
2319
2320         * Scripts/modules/bugzilla.py:
2321          - Parse attacher_email from attachment xml.
2322         * Scripts/modules/bugzilla_unittest.py:
2323          - Test new attacher_email parsing.
2324         * Scripts/modules/commands/queries.py:
2325          - Add PatchesToCommitQueue
2326         * Scripts/modules/commands/queries_unittest.py:
2327          - Tests for PatchesToCommitQueue
2328         * Scripts/modules/mock_bugzillatool.py:
2329          - Add necessary mock methods for running PatchesToCommitQueue
2330
2331 2009-12-10  Adam Barth  <abarth@webkit.org>
2332
2333         Unreviewed.  Turns out every StepSequence command needs a --quiet
2334         option.
2335
2336         * Scripts/modules/stepsequence.py:
2337
2338 2009-12-10  Eric Z. Ayers  <zundel@google.com>
2339
2340         Reviewed by Pavel Feldman.
2341
2342         Implements displayWebView() to force an invalidation and repaint.
2343         This fixes a problem running the timeline-paint.html unit test.
2344
2345         https://bugs.webkit.org/show_bug.cgi?id=31729
2346
2347         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2348         (displayWebView):
2349
2350 2009-12-10  Adam Barth  <abarth@webkit.org>
2351
2352         Reviewed by Eric Seidel.
2353
2354         [bzt] Convert more commands to StepSequences
2355         https://bugs.webkit.org/show_bug.cgi?id=32362
2356
2357         We should eventually convert all the commands, but I'm starting with
2358         the easy ones.
2359
2360         * Scripts/modules/commands/download.py:
2361
2362 2009-12-10  Xan Lopez  <xlopez@igalia.com>
2363
2364         Reviewed by Jan Alonzo.
2365
2366         [GTK] editing/selection/shrink-selection-after-shift-pagedown.html failing
2367         https://bugs.webkit.org/show_bug.cgi?id=31103
2368
2369         Give focus to the webviews when we create them, since some tests expect this.
2370
2371         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2372         (main):
2373
2374 2009-12-10  Eric Seidel  <eric@webkit.org>
2375
2376         Reviewed by Adam Barth.
2377
2378         bugzilla-tool "builders are red" error should tell you which builders
2379         https://bugs.webkit.org/show_bug.cgi?id=32211
2380
2381         * Scripts/modules/buildsteps.py:
2382
2383 2009-12-09  Marwan Al Jubeh  <marwan.aljubeh@gmail.com>
2384
2385         Reviewed by Adam Roben.
2386
2387         Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228
2388         Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
2389         in Windows as part of running update_webkit.
2390
2391         * Scripts/update-webkit:
2392          - Run setupAppleWinEnv() on Apple's Windows port.
2393         * Scripts/webkitdirs.pm:
2394          - Added functions that return the source directory, libraries directory and default build directory on Windows.
2395          - Added isWindowsNT() which tests if the current Windows version is from the Windows NT family.
2396          - Implemented setupAppleWinEnv() which sets the environment variables WebKitOutputDir, WebKitLibrariesDir
2397            and Cygwin to their desired values.
2398
2399 2009-12-09  Adam Barth  <abarth@webkit.org>
2400
2401         Reviewed by Eric Seidel.
2402
2403         exception thrown when running apply-patches
2404         https://bugs.webkit.org/show_bug.cgi?id=32344
2405
2406         The update step now takes a port option.  Once we finish the Steps
2407         refactoring, we won't have to worry about this kind of bug again.
2408
2409         * Scripts/modules/commands/download.py:
2410
2411 2009-12-09  Adam Barth  <abarth@webkit.org>
2412
2413         Unreviewed.  Fix ScriptError includes.  I don't understand why these
2414         didn't throw during unit testing...
2415
2416         * Scripts/modules/commands/download.py:
2417         * Scripts/modules/logging_unittest.py:
2418         * Scripts/modules/workqueue.py:
2419
2420 2009-12-09  Adam Barth  <abarth@webkit.org>
2421
2422         Reviewed by Eric Seidel.
2423
2424         [bzt] Remove unused PatchCollection class
2425         https://bugs.webkit.org/show_bug.cgi?id=32312
2426
2427         It's dead code.
2428
2429         * Scripts/modules/patchcollection.py:
2430         * Scripts/modules/patchcollection_unittest.py: Removed.
2431
2432 2009-12-09  Adam Barth  <abarth@webkit.org>
2433
2434         Unreviewed "build" fix.  CheckStyle needs a --no-upate option.
2435
2436         * Scripts/modules/commands/download.py:
2437
2438 2009-12-09  Adam Barth  <abarth@webkit.org>
2439
2440         Reviewed by Eric Seidel.
2441
2442         [bzt] Convert Build to use Sequence
2443         https://bugs.webkit.org/show_bug.cgi?id=32310
2444
2445         So much prettier.
2446
2447         * Scripts/modules/buildsteps.py:
2448         * Scripts/modules/commands/download.py:
2449         * Scripts/modules/landingsequence.py:
2450         * Scripts/modules/stepsequence.py: Added.
2451
2452 2009-12-09  Adam Barth  <abarth@webkit.org>
2453
2454         Add missing file.
2455
2456         * Scripts/modules/executive.py: Added.
2457
2458 2009-12-09  Adam Barth  <abarth@webkit.org>
2459
2460         Unreviewed "build" fix.
2461
2462         * Scripts/modules/landingsequence.py:
2463
2464 2009-12-09  Adam Barth  <abarth@webkit.org>
2465
2466         Reviewed by Eric Seidel.
2467
2468         [bzt] Implement abstract Steps
2469         https://bugs.webkit.org/show_bug.cgi?id=32212
2470
2471         This is a fairly disruptive change that refactors how we build
2472         commands.  Instead of using a landing sequence, we can now assemble a
2473         sequence of steps directly.  We still use the landing sequence in the
2474         interim, but this will be removed soon.
2475
2476         * Scripts/bugzilla-tool:
2477         * Scripts/modules/buildsteps.py:
2478         * Scripts/modules/commands/download.py:
2479         * Scripts/modules/commands/early_warning_system.py:
2480         * Scripts/modules/commands/queues.py:
2481         * Scripts/modules/commands/queues_unittest.py:
2482         * Scripts/modules/landingsequence.py:
2483         * Scripts/modules/mock_bugzillatool.py:
2484         * Scripts/modules/processutils.py: Removed.
2485         * Scripts/modules/scm.py:
2486         * Scripts/modules/scm_unittest.py:
2487         * Scripts/modules/webkitport.py:
2488
2489 2009-12-08  Eric Seidel  <eric@webkit.org>
2490
2491         Reviewed by Adam Barth.
2492
2493         run_command and ScriptError should move into processutils.py
2494         https://bugs.webkit.org/show_bug.cgi?id=32305
2495
2496         Turns out there are a zillion callers to run_command.
2497
2498         * Scripts/modules/commands/download.py:
2499         * Scripts/modules/commands/early_warning_system.py:
2500         * Scripts/modules/commands/queues.py:
2501         * Scripts/modules/landingsequence.py:
2502         * Scripts/modules/logging_unittest.py:
2503         * Scripts/modules/processutils.py:
2504         * Scripts/modules/scm.py:
2505         * Scripts/modules/scm_unittest.py:
2506         * Scripts/modules/workqueue.py:
2507         * Scripts/modules/workqueue_unittest.py:
2508
2509 2009-12-08  Kevin Watters  <kevinwatters@gmail.com>
2510
2511         Reviewed by Kevin Ollivier.
2512
2513         [wx] Mac plugins support.
2514         
2515         https://bugs.webkit.org/show_bug.cgi?id=32236
2516
2517         * wx/browser/wscript:
2518
2519 2009-12-08  David Levin  <levin@chromium.org>
2520
2521         Reviewed by Adam Barth.
2522
2523         [check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) {
2524         https://bugs.webkit.org/show_bug.cgi?id=32193
2525
2526         * Scripts/modules/cpp_style.py: For the function { rule, if there is space
2527           at the beginning of line, ignore lines which then have a macro.
2528         * Scripts/modules/cpp_style_unittest.py: Add tests to verify the
2529           new behavior.
2530
2531 2009-12-08  Dmitry Titov  <dimich@chromium.org>
2532
2533         Rubber-stamped by David Levin.
2534
2535         Revert and reopen "Add asserts to RefCounted to make sure ref/deref happens on the right thread."
2536         It may have caused massive increase of reported leaks on the bots.
2537         https://bugs.webkit.org/show_bug.cgi?id=31639
2538
2539         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
2540
2541 2009-12-08  Dmitry Titov  <dimich@chromium.org>
2542
2543         Reviewed by Darin Adler.
2544
2545         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
2546         https://bugs.webkit.org/show_bug.cgi?id=31639
2547
2548         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Added.
2549
2550 2009-12-08  David Levin  <levin@chromium.org>
2551
2552         Reviewed by Adam Barth.
2553
2554         [check-webkit-style] False positive for camel case of JSC op codes
2555         https://bugs.webkit.org/show_bug.cgi?id=32192
2556
2557         * Scripts/modules/cpp_style.py: Added an exception for the JSC op
2558           code functions and const_iterator as well since I noticed a false
2559           positive there when testing the fix.
2560         * Scripts/modules/cpp_style_unittest.py: Added tests for these
2561           changes.
2562
2563 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
2564
2565         Rubber-stamped by Maciej Stachowiak.
2566
2567         Turn on (SVG) Filters for Win.
2568         https://bugs.webkit.org/show_bug.cgi?id=32224
2569
2570         * Scripts/webkitdirs.pm:
2571
2572 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
2573
2574         Rubber-stamped by Maciej Stachowiak.
2575
2576         Turn on (SVG) Filters for Gtk.
2577         https://bugs.webkit.org/show_bug.cgi?id=32224
2578
2579         * Scripts/build-webkit:
2580
2581 2009-12-07  Shinichiro Hamaji  <hamaji@chromium.org>
2582
2583         Reviewed by David Levin.
2584
2585         [check-webkit-style] S_OK is a fine identifier
2586         https://bugs.webkit.org/show_bug.cgi?id=32225
2587
2588         * Scripts/modules/cpp_style.py:
2589         * Scripts/modules/cpp_style_unittest.py:
2590
2591 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
2592
2593         Rubber-stamped by Maciej Stachowiak.
2594
2595         Turn on (SVG) Filters for Qt.
2596         https://bugs.webkit.org/show_bug.cgi?id=32224
2597
2598         * Scripts/build-webkit:
2599
2600 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
2601
2602         Reviewed by Alexey Proskuryakov.
2603
2604         Make run-webkit-websocketserver log to stderr rather than to a file.
2605         https://bugs.webkit.org/show_bug.cgi?id=32234
2606
2607         * Scripts/run-webkit-websocketserver:
2608
2609 2009-12-07  Dmitry Titov  <dimich@chromium.org>
2610
2611         Rubber-stamped by Darin Adler.
2612
2613         Remove ENABLE_SHARED_SCRIPT flags
2614         https://bugs.webkit.org/show_bug.cgi?id=32245
2615         This patch was obtained by "git revert" command and then un-reverting of ChangeLog files.
2616
2617         * Scripts/build-webkit:
2618
2619 2009-12-07  Simon Fraser  <simon.fraser@apple.com>
2620
2621         Reviewed by Darin Adler.
2622
2623         <rdar://problem/7450481> One compositing test keeps DRT in "compositing mode", breaks repaint tests
2624
2625         The counter that WebView used to keep track of the number of enclosed WebHTMLViews using
2626         accelerated compositing was hard to manage, and maintained incorrectly in a number of cases.
2627         This caused one compositing test make DumpRenderTree think that all subsequent tests
2628         were compositing too.
2629
2630         Replace this counter with notifications, which are only fired if a client (DRT) requests them. The
2631         notification informs the client that a WebHTMLView entered compositing mode (or an already-
2632         compositing WebHTML was added); it does not say when a view becomes uncomposited, or all
2633         compositing subviews were removed, since this is tricky to get right.
2634         
2635         DumpRenderTreeWindow listens for this notification, and uses it to turn on window
2636         autodisplay, which is necessary to kick-start Core Animation rendering and animations.
2637         We ensure that window autodisplay is turned off before every test.
2638
2639         * DumpRenderTree/mac/DumpRenderTree.mm:
2640         (createWebViewAndOffscreenWindow):
2641         (resetWebViewToConsistentStateBeforeTesting):
2642         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2643         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2644         (-[DumpRenderTreeWindow close]):
2645         (-[DumpRenderTreeWindow startListeningForAcceleratedCompositingChanges]):
2646         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
2647
2648 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
2649
2650         Reviewed by Holger Hans Peter Freyther.
2651
2652         Turn on (SVG) Filters support, by default.
2653         https://bugs.webkit.org/show_bug.cgi?id=32224
2654
2655         For now only enable FILTERS build flag on WebKit/mac. Other platforms will follow soon.
2656
2657         * Scripts/build-webkit:
2658
2659 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
2660
2661         Reviewed by Darin Fisher.
2662
2663         Chromium buildbots are not red when they fail
2664         https://bugs.webkit.org/show_bug.cgi?id=32235
2665
2666         * Scripts/build-webkit:
2667
2668 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
2669
2670         Reviewed by Darin Fisher.
2671
2672         Typo in chromium linux builder
2673         https://bugs.webkit.org/show_bug.cgi?id=32238
2674
2675         * Scripts/webkitdirs.pm:
2676
2677 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
2678
2679         Reviewed by Darin Fisher.
2680
2681         fixes to build-webkit --chromium
2682         https://bugs.webkit.org/show_bug.cgi?id=32179
2683
2684         * Scripts/webkitdirs.pm:
2685
2686 2009-12-07  Eric Seidel  <eric@webkit.org>
2687
2688         No review, just adding two recently approved committers.
2689
2690         * Scripts/modules/committers.py:
2691
2692 2009-12-07  Alexey Proskuryakov  <ap@apple.com>
2693
2694         * Scripts/run-webkit-websocketserver: Added property svn:executable.
2695
2696 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
2697
2698         Reviewed by Alexey Proskuryakov.
2699
2700         Add run-webkit-websocketserver
2701
2702         https://bugs.webkit.org/show_bug.cgi?id=31390
2703
2704         * Scripts/run-webkit-websocketserver: Added.
2705
2706 2009-12-07  Steve Falkenburg  <sfalken@apple.com>
2707
2708         Build fix. Be flexible about which version of ICU is used on Windows.
2709
2710         * DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2.
2711
2712 2009-12-07  Dirk Schulze  <krit@webkit.org>
2713
2714         Not reviewed, adding myself to the reviewers list.
2715
2716         * Scripts/modules/committers.py:
2717
2718 2009-12-06  Eric Seidel  <eric@webkit.org>
2719
2720         Reviewed by Adam Barth.
2721
2722         Add an API for uploading results files to StatusBot
2723         https://bugs.webkit.org/show_bug.cgi?id=32210
2724
2725         Add Content-Type: plain/text which was forgotten
2726         from the previous commit when I landed with land-patches
2727         instead of land-diff.
2728
2729         * QueueStatusServer/queue_status.py:
2730
2731 2009-12-06  Eric Seidel  <eric@webkit.org>
2732
2733         Reviewed by Adam Barth.
2734
2735         Status Server needs a way to handle uploaded results
2736         https://bugs.webkit.org/show_bug.cgi?id=32209
2737
2738         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
2739         * QueueStatusServer/update_status.html: Add file upload.
2740
2741 2009-12-06  Eric Seidel  <eric@webkit.org>
2742
2743         Reviewed by Adam Barth.
2744
2745         Add an API for uploading results files to StatusBot
2746         https://bugs.webkit.org/show_bug.cgi?id=32210
2747
2748         * Scripts/modules/statusbot.py:
2749
2750 2009-12-06  Eric Seidel  <eric@webkit.org>
2751
2752         Reviewed by Adam Barth.
2753
2754         Status Server needs a way to handle uploaded results
2755         https://bugs.webkit.org/show_bug.cgi?id=32209
2756
2757         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
2758         * QueueStatusServer/update_status.html: Add file upload.
2759
2760 2009-12-06  Adam Barth  <abarth@webkit.org>
2761
2762         Reviewed by Eric Seidel.
2763
2764         [bzt] BuildAttachment should not check the builders
2765         https://bugs.webkit.org/show_bug.cgi?id=32207
2766
2767         This is code that got copied here by accident when the class was created.
2768
2769         * Scripts/modules/commands/download.py:
2770
2771 2009-12-06  Adam Barth  <abarth@webkit.org>
2772
2773         Reviewed by Eric Seidel.
2774
2775         [bzt] Make LandingSequence.update aware of ports
2776         https://bugs.webkit.org/show_bug.cgi?id=32208
2777
2778         This is required to make build work on the Chromium port because
2779         Chromium has a custom update-webkit.
2780
2781         * Scripts/modules/landingsequence.py:
2782
2783 2009-12-06  Adam Barth  <abarth@webkit.org>
2784
2785         Reviewed by Eric Seidel.
2786
2787         Add early warning system commands to bugzilla-tool.
2788
2789         * Scripts/bugzilla-tool:
2790         * Scripts/modules/landingsequence.py:
2791         * Scripts/modules/webkitport.py:
2792
2793 2009-12-06  Adam Barth  <abarth@webkit.org>
2794
2795         Reviewed by Eric Seidel.
2796
2797         [bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem
2798         https://bugs.webkit.org/show_bug.cgi?id=32205
2799
2800         * Scripts/modules/commands/early_warning_system.py: Added.
2801         * Scripts/modules/commands/queues.py:
2802
2803 2009-12-06  Dan Bernstein  <mitz@apple.com>
2804
2805         Reviewed by Adele Peterson.
2806
2807         REGRESSION (r51728): update-webkit fails when the current directory is
2808         not inside a Subversion working copy
2809         https://bugs.webkit.org/show_bug.cgi?id=32204
2810
2811         * Scripts/update-webkit: Invoke isSVN() in the correct working
2812         directory.
2813
2814 2009-12-06  Adam Barth  <abarth@webkit.org>
2815
2816         Reviewed by Eric Seidel.
2817
2818         [bzt] Rename AbstractTryQueue to AbstractReviewQueue
2819         https://bugs.webkit.org/show_bug.cgi?id=32202
2820
2821         * Scripts/modules/commands/queues.py:
2822
2823 2009-12-05  Adam Barth  <abarth@webkit.org>
2824
2825         Reviewed by Eric Seidel.
2826
2827         [bzt] Implement ChromiumPort
2828         https://bugs.webkit.org/show_bug.cgi?id=32182
2829
2830         * Scripts/modules/webkitport.py:
2831         * Scripts/modules/webkitport_unittest.py:
2832
2833 2009-12-05  Adam Barth  <abarth@webkit.org>
2834
2835         Reviewed by Eric Seidel.
2836
2837         Move update-webkit into BuildSteps
2838         https://bugs.webkit.org/show_bug.cgi?id=32181
2839
2840         We need to move update-webkit out of SCM.py because SCM isn't supposed to know
2841         that WebKit exists.  The proper place for the knowledge of the existence of
2842         update-webkit is in WebKitPort because some ports have specialized update
2843         scripts (analogous to build-webkit).
2844
2845         * Scripts/modules/buildsteps.py:
2846         * Scripts/modules/commands/download.py:
2847         * Scripts/modules/landingsequence.py:
2848         * Scripts/modules/scm.py:
2849         * Scripts/modules/webkitport.py:
2850
2851 2009-12-05  Adam Barth  <abarth@webkit.org>
2852
2853         Reviewed by Eric Seidel.
2854
2855         update-webkit should call git svn rebase and resolve-ChangeLogs -f
2856         https://bugs.webkit.org/show_bug.cgi?id=27162
2857
2858         Teach update-webkit about Git.  I didn't add the call to
2859         resolve-ChangeLogs -f because sometimes that script goes bananas.  We
2860         can iterate from here, however.
2861
2862         * Scripts/update-webkit:
2863
2864 2009-12-04  Yael Aharon  <yael.aharon@nokia.com>
2865
2866         Unreviewed build fix.
2867
2868         [Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.
2869
2870         * DumpRenderTree/qt/DumpRenderTree.cpp:
2871
2872 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2873
2874         Reviewed by Adam Treat.
2875
2876         Add some missing methods for showing and hiding the
2877         Web Inspector.
2878
2879         * DumpRenderTree/qt/DumpRenderTree.cpp:
2880         (WebCore::WebPage::WebPage):
2881         (WebCore::WebPage::~WebPage):
2882         (WebCore::WebPage::webInspector):
2883         * DumpRenderTree/qt/DumpRenderTree.h:
2884         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2885         (LayoutTestController::showWebInspector):
2886         (LayoutTestController::hideWebInspector):
2887         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2888
2889 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2890
2891         Reviewed by Adam Treat.
2892
2893         Implement the setAllowUniversalAccessFromFileURLs method
2894         for the Qt LayoutTestController.
2895
2896         * DumpRenderTree/qt/DumpRenderTree.cpp:
2897         (WebCore::WebPage::resetSettings):
2898         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2899         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2900         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2901
2902 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
2903
2904         Reviewed by Darin Adler.
2905
2906         REGRESSION: AX: buttons now extremely repetitive
2907         https://bugs.webkit.org/show_bug.cgi?id=32164
2908
2909         * DumpRenderTree/AccessibilityUIElement.cpp:
2910         (isAttributeSupportedCallback):
2911         (AccessibilityUIElement::getJSClass):
2912         * DumpRenderTree/AccessibilityUIElement.h:
2913         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2914         (AccessibilityUIElement::isAttributeSupported):
2915         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2916         (AccessibilityUIElement::isAttributeSupported):
2917         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2918         (AccessibilityUIElement::isAttributeSupported):
2919
2920 2009-12-03  Shinichiro Hamaji  <hamaji@chromium.org>
2921
2922         Reviewed by David Levin.
2923
2924         check-webkit-style should check for camelCase variable names
2925         https://bugs.webkit.org/show_bug.cgi?id=32051
2926
2927         * Scripts/modules/cpp_style.py:
2928         * Scripts/modules/cpp_style_unittest.py:
2929
2930 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
2931
2932         Reviewed by Eric Seidel.
2933
2934         AX: VO just says "term" on many web sites
2935         https://bugs.webkit.org/show_bug.cgi?id=32139
2936
2937         * DumpRenderTree/AccessibilityUIElement.cpp:
2938         (getRoleDescriptionCallback):
2939         (AccessibilityUIElement::getJSClass):
2940         * DumpRenderTree/AccessibilityUIElement.h:
2941         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2942         (AccessibilityUIElement::roleDescription):
2943         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2944         (AccessibilityUIElement::roleDescription):
2945         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2946         (AccessibilityUIElement::roleDescription):
2947
2948 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
2949
2950         Reviewed by Beth Dakin.
2951
2952         Implement WAI-ARIA scrollbar role and related property aria-orientation
2953         https://bugs.webkit.org/show_bug.cgi?id=32126
2954
2955         * DumpRenderTree/AccessibilityUIElement.cpp:
2956         (getOrientationCallback):
2957         (AccessibilityUIElement::getJSClass):
2958         * DumpRenderTree/AccessibilityUIElement.h:
2959         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2960         (AccessibilityUIElement::orientation):
2961         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2962         (AccessibilityUIElement::orientation):
2963         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2964         (AccessibilityUIElement::orientation):
2965
2966 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
2967
2968         Reviewed by Adam Roben.
2969
2970         Minor correction to r51663.
2971
2972         * DumpRenderTree/win/DumpRenderTree.cpp:
2973         (addQTDirToPATH):
2974             GetEnvironmentVariable -> GetEnvironmentVariableW.
2975
2976 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
2977
2978         Reviewed by Adam Roben.
2979
2980         ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
2981         https://bugs.webkit.org/show_bug.cgi?id=30256
2982
2983         Add the QuickTime dll directory to the PATH environment variable so
2984         inialization can succeed.
2985
2986         * DumpRenderTree/win/DumpRenderTree.cpp:
2987         (addQTDirToPATH):
2988         (initialize):
2989
2990 2009-12-03  Shu Chang  <Chang.Shu@nokia.com>
2991
2992         Reviewed by Kenneth Rohde Christiansen.
2993
2994         [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.
2995
2996         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2997         (LayoutTestController::maybeDump):
2998
2999 2009-12-03  Yuzo Fujishima  <yuzo@google.com>
3000
3001         Reviewed by Eric Seidel.
3002
3003         Update pywebsocket to 0.4.3
3004         This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
3005         Stack trace is logged now in INFO level.
3006         https://bugs.webkit.org/show_bug.cgi?id=32097
3007
3008         * pywebsocket/mod_pywebsocket/dispatch.py:
3009         * pywebsocket/mod_pywebsocket/msgutil.py:
3010         * pywebsocket/mod_pywebsocket/standalone.py:
3011         * pywebsocket/mod_pywebsocket/util.py:
3012         * pywebsocket/setup.py:
3013         * pywebsocket/test/test_dispatch.py:
3014         * pywebsocket/test/test_util.py:
3015
3016 2009-12-03  Sam Weinig  <sam@webkit.org>
3017
3018         Reviewed by Gavin Barraclough.
3019
3020         Fix JSClassRef leak.
3021
3022         * DumpRenderTree/AccessibilityController.cpp:
3023         (AccessibilityController::makeWindowObject):
3024         * DumpRenderTree/GCController.cpp:
3025         (GCController::makeWindowObject):
3026         * DumpRenderTree/LayoutTestController.cpp:
3027         (LayoutTestController::makeWindowObject):
3028
3029 2009-12-03  Brady Eidson  <beidson@apple.com>
3030
3031         Reviewed by Sam Weinig.
3032
3033         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
3034
3035         Keep DRT-win building...
3036
3037         * DumpRenderTree/win/FrameLoadDelegate.h:
3038         (FrameLoadDelegate::didPushStateWithinPageForFrame):
3039         (FrameLoadDelegate::didReplaceStateWithinPageForFrame):
3040         (FrameLoadDelegate::didPopStateWithinPageForFrame):
3041
3042 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
3043
3044         Unreviewed build fix.
3045
3046         [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
3047
3048         * DumpRenderTree/qt/DumpRenderTree.cpp:
3049
3050 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
3051
3052         Reviewed by Kenneth Rohde Christiansen.
3053
3054         [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
3055         Prevent DRT from showing the main view if these childs get deleted.
3056         This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
3057
3058         * DumpRenderTree/qt/DumpRenderTree.cpp:
3059         (WebCore::WebPage::WebPage):
3060         (WebCore::DumpRenderTree::DumpRenderTree):
3061         (WebCore::DumpRenderTree::~DumpRenderTree):
3062         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3063         (WebCore::DumpRenderTree::open):
3064         (WebCore::DumpRenderTree::closeRemainingWindows):
3065         (WebCore::DumpRenderTree::createWindow):
3066         (WebCore::DumpRenderTree::windowCount):
3067         * DumpRenderTree/qt/DumpRenderTree.h:
3068
3069 2009-12-02  Eric Seidel  <eric@webkit.org>
3070
3071         Reviewed by Adam Barth.
3072
3073         REGRESSION(51595): commit-queue is throwing exceptions
3074         https://bugs.webkit.org/show_bug.cgi?id=32083
3075
3076         * Scripts/modules/commands/queues.py:
3077          - Don't use default value of [] as it ends up getting shared.
3078          - Make log_progress accept arrays of ints as well as strings.
3079          - Return an exit code from execute()
3080         * Scripts/modules/commands/queues_unittest.py: Added.
3081          - Test to make sure log_progress will accept ints.
3082          - Test to make sure run_bugzilla_tool will accept ints.
3083         * Scripts/modules/workqueue.py:
3084          - Print the stack trace on unexpected exceptions for easier debugging.
3085         * Scripts/run-webkit-unittests:
3086          - Add queues_unittest.
3087
3088         * Scripts/modules/commands/queues.py:
3089         * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
3090         * Scripts/modules/mock_bugzillatool.py:
3091         * Scripts/modules/workqueue.py:
3092         * Scripts/run-webkit-unittests:
3093
3094 2009-12-02  David Levin  <levin@chromium.org>
3095
3096         Reviewed by Adam Barth.
3097
3098         check-webkit-style is too noisy about namespace indenting issues.
3099         https://bugs.webkit.org/show_bug.cgi?id=32096
3100
3101         * Scripts/modules/cpp_style.py:
3102         Added a _FileState object to be able to track file level information. In this
3103         case, it simply tracks whether the error has already been given, so that it isn't
3104         done again.
3105         * Scripts/modules/cpp_style_unittest.py:
3106         Modified test cases to pass in the _FileState object and fix a test that expected
3107         to see the namespace error twice (now it only occurs once). No new tests because
3108         existing tests cover the change in functionality.
3109
3110 2009-12-01  Kevin Ollivier  <kevino@theolliviers.com>
3111
3112         Reviewed by Eric Seidel.
3113
3114         [wx] Get DumpRenderTree building after waf switch.
3115         
3116         https://bugs.webkit.org/show_bug.cgi?id=32041
3117
3118         * DumpRenderTree/wscript: Added.
3119         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3120         (LayoutTestController::setTimelineProfilingEnabled):
3121         (LayoutTestController::evaluateScriptInIsolatedWorld):
3122         (LayoutTestController::disableImageLoading):
3123         (LayoutTestController::whiteListAccessFromOrigin):
3124         (LayoutTestController::counterValueForElementById):
3125         * Scripts/build-webkit:
3126
3127 2009-12-02  Adam Barth  <abarth@webkit.org>
3128
3129         Reviewed by Eric Seidel.
3130
3131         [bzt] build-attachment shouldn't check whether the builders are red
3132         https://bugs.webkit.org/show_bug.cgi?id=32062
3133
3134         build-attachment doesn't touch the remote repository, so there isn't a
3135         need to hold off when the builders are red.
3136
3137         * Scripts/modules/commands/download.py:
3138         * Scripts/modules/landingsequence.py:
3139
3140 2009-12-02  Eric Seidel  <eric@webkit.org>
3141
3142         Reviewed by Adam Barth.
3143
3144         REGRESSION(51590): style-queue and build-queue think their empty when they are not
3145         https://bugs.webkit.org/show_bug.cgi?id=32061
3146
3147         * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
3148         * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
3149
3150 2009-12-02  Eric Seidel  <eric@webkit.org>
3151
3152         Reviewed by Adam Barth.
3153
3154         build-queue is throwing exceptions and complaining about
3155         lack of --no-update on build-attachment.  Make it stop.
3156
3157         * Scripts/modules/buildsteps.py:
3158         * Scripts/modules/commands/download.py:
3159
3160 2009-12-02  Adam Barth  <abarth@webkit.org>
3161
3162         Unreviewed "build" fix.  Forgot to declare my variables.  :(
3163
3164         * QueueStatusServer/queue_status.py:
3165
3166 2009-12-02  Adam Barth  <abarth@webkit.org>
3167
3168         Reviewed by Eric Seidel.
3169
3170         [bzt] Implement status bubble view
3171         https://bugs.webkit.org/show_bug.cgi?id=32057
3172
3173         The status bubble is a compact representation of the queue status for a
3174         given patch.  This will eventually help us reduce the comment spam from
3175         the queues.
3176
3177         * QueueStatusServer/index.html: Added HTML5 doctype for sanity.
3178         * QueueStatusServer/queue_status.py:
3179         * QueueStatusServer/status_bubble.html: Added.
3180
3181 2009-12-02  Eric Seidel  <eric@webkit.org>
3182
3183         Reviewed by Adam Barth.
3184
3185         trim commands/*.py includes now that commands are unit tested
3186         https://bugs.webkit.org/show_bug.cgi?id=32056
3187
3188         In the course of ensuring that the unit tests still
3189         passed after this change, I had to actually make them
3190         pass in the first place.
3191
3192         * Scripts/modules/bugzilla.py:
3193          - Fix _parse_attachment_ids_request_query to return ints instead of strings.
3194         * Scripts/modules/commands/download.py: Remove unneeded imports.
3195         * Scripts/modules/commands/queries.py: Ditto.
3196         * Scripts/modules/commands/queues.py: Ditto.
3197         * Scripts/modules/commands/upload.py: Ditto.
3198         * Scripts/modules/scm_unittest.py:
3199          - Fix to expect the \n after the path since echo adds an \n.
3200
3201 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
3202
3203         build-webkit: Remove flex,bison,gperf check for chromium
3204         https://bugs.webkit.org/show_bug.cgi?id=32043
3205
3206         * Scripts/webkitdirs.pm:
3207
3208 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
3209
3210         Build fixage for Windows/GTK for DumpRenderTree.
3211
3212         WAI-ARIA: implement support for ARIA drag and drop
3213         https://bugs.webkit.org/show_bug.cgi?id=32007
3214
3215         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3216         (AccessibilityUIElement::ariaIsGrabbed):
3217         (AccessibilityUIElement::ariaDropEffects):
3218         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3219         (AccessibilityUIElement::ariaIsGrabbed):
3220         (AccessibilityUIElement::ariaDropEffects):
3221
3222 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
3223
3224         Reviewed by Darin Adler.
3225
3226         WAI-ARIA: implement support for ARIA drag and drop
3227         https://bugs.webkit.org/show_bug.cgi?id=32007
3228
3229         * DumpRenderTree/AccessibilityUIElement.cpp:
3230         (getARIADropEffectsCallback):
3231         (getARIAIsGrabbedCallback):
3232         (AccessibilityUIElement::getJSClass):
3233         * DumpRenderTree/AccessibilityUIElement.h:
3234         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3235         (AccessibilityUIElement::ariaIsGrabbed):
3236         (AccessibilityUIElement::ariaDropEffects):
3237
3238 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
3239
3240         Not reviewed. GTK DRT try 2.
3241
3242         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3243         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3244
3245 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
3246
3247         Not reviewed. Try to fix gtk DRT build.
3248
3249         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3250
3251 2009-12-01  David Levin  <levin@chromium.org>
3252
3253         Reviewed by Eric Seidel.
3254
3255         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
3256         https://bugs.webkit.org/show_bug.cgi?id=32033
3257
3258         * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
3259                                         instead of startswith.
3260         * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
3261
3262 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
3263
3264         Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
3265
3266         * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature.
3267
3268 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
3269
3270         Reviewed by Simon Fraser.
3271
3272         Add SVG animation test framework with 'snapshot' functionality
3273         https://bugs.webkit.org/show_bug.cgi?id=31897
3274
3275         Add new 'sampleSVGAnimationForElementAtTime' DRT method,
3276         used by the new SVG animation testing framework, implemented
3277         for qt/gtk/win/mac.
3278
3279         * DumpRenderTree/LayoutTestController.cpp:
3280         (sampleSVGAnimationForElementAtTimeCallback):
3281         (LayoutTestController::staticFunctions):
3282         * DumpRenderTree/LayoutTestController.h:
3283         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3284         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3285         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3286         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3287         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3288         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3289         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3290         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3291         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3292         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3293         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3294
3295 2009-12-01  Adam Roben  <aroben@apple.com>
3296
3297         Remove user content before running each test on Windows
3298
3299         Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
3300
3301         Reviewed by Alexey Proskuryakov.
3302
3303         * DumpRenderTree/win/DumpRenderTree.cpp:
3304         (resetWebViewToConsistentStateBeforeTesting): Remove all user content
3305         before each test, which matches Mac.
3306
3307 2009-12-01  Yuzo Fujishima  <yuzo@google.com>
3308
3309         Reviewed by Alexey Proskuryakov.
3310
3311         Make pywebsocket log errors to a file
3312         https://bugs.webkit.org/show_bug.cgi?id=31604
3313
3314         * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
3315         (by passing the path to the server via a recently added -l option).
3316
3317 2009-12-01  Adam Roben  <aroben@apple.com>
3318
3319         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
3320
3321         Reviewed by Ada Chan.
3322
3323         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
3324         TestNetscapePlugin fail in Debug_Internal builds
3325
3326         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
3327         directory in Debug and Debug_All builds, but not in Debug_Internal
3328         builds.
3329
3330 2009-12-01  Adam Roben  <aroben@apple.com>
3331
3332         Re-enable DRT's watchdog timer on Windows
3333
3334         It was accidentally disabled in r50907.
3335
3336         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3337         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
3338         into an if condition.
3339
3340 2009-12-01  Adam Barth  <abarth@webkit.org>
3341
3342         Reviewed by Eric Seidel.
3343
3344         check-webkit-style complains about #imports with / in them
3345         https://bugs.webkit.org/show_bug.cgi?id=32022
3346
3347         We need to exclude #import directives in addition to #include from the
3348         binary operator whitespace checks.
3349
3350         * Scripts/modules/cpp_style.py:
3351         * Scripts/modules/cpp_style_unittest.py:
3352
3353 2009-11-30  Adam Barth  <abarth@webkit.org>
3354
3355         Reviewed by Eric Seidel.
3356
3357         check-webkit-style is slightly too verbose
3358         https://bugs.webkit.org/show_bug.cgi?id=32010
3359
3360         check-webkit-style prints out a bunch of "done" lines that seem redundant,
3361         especially for the style-queue.
3362
3363         * Scripts/modules/cpp_style.py:
3364
3365 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
3366
3367         Reviewed by Eric Seidel.
3368
3369         [GTK] Moved the functions that are closing the result log of the
3370         tests to the last line of the runTest function, this avoids
3371         reporting crashes in the wrong test if there is a problem when
3372         reseting the state after the test.
3373
3374         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3375         (dump):
3376         (runTest):
3377
3378 2009-11-30  Sam Weinig  <sam@webkit.org>
3379
3380         Reviewed by Geoffrey Garen.
3381
3382         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
3383         fast/js/date-proto-generic-invocation breaks another test
3384
3385         Don't cache JSClassRefs, a change to the prototype chain will
3386         last between tests.
3387
3388         * DumpRenderTree/AccessibilityController.cpp:
3389         (AccessibilityController::getJSClass):
3390         * DumpRenderTree/GCController.cpp:
3391         (GCController::getJSClass):
3392         * DumpRenderTree/GCController.h:
3393         * DumpRenderTree/LayoutTestController.cpp:
3394         (LayoutTestController::getJSClass):
3395
3396 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
3397
3398         Reviewed by Alexey Proskuryakov.
3399
3400         Update pywebsocket to 0.4.2.1.
3401         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
3402         https://bugs.webkit.org/show_bug.cgi?id=31976
3403
3404         * pywebsocket/mod_pywebsocket/standalone.py:
3405         * pywebsocket/setup.py:
3406
3407 2009-11-30  Adam Barth  <abarth@webkit.org>
3408
3409         Reviewed by Eric Seidel.
3410
3411         [bzt] Generate pass messages for style-queue
3412         https://bugs.webkit.org/show_bug.cgi?id=31995
3413
3414         With this change, the style-queue posts "pass" messages to bugs as
3415         well.  Also, added more information to the state store w.r.t. passing
3416         and failing.
3417
3418         * Scripts/modules/commands/queues.py:
3419         * Scripts/modules/patchcollection.py:
3420
3421 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3422
3423         Reviewed by Simon Fraser.
3424
3425         Check for WEBKIT_TESTFONTS environment variable in
3426         run-webkit-tests, for GTK+, to have a more prominent error
3427         message.
3428
3429         * Scripts/run-webkit-tests:
3430
3431 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
3432
3433         Reviewed by Dimitri Glazkov.
3434
3435         update-webkit --chromium forces gclient sync
3436
3437         https://bugs.webkit.org/show_bug.cgi?id=31967
3438
3439         * Scripts/update-webkit-chromium:
3440
3441 2009-11-29  Eric Seidel  <eric@webkit.org>
3442
3443         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
3444
3445         * Scripts/modules/committers.py:
3446
3447 2009-11-29  Eric Seidel  <eric@webkit.org>
3448
3449         No review, just adding missing svn property.
3450
3451         Set svn:executable property on new scripts.
3452         These were added by commit-queue commits, but the executable
3453         property was lost due to a bug in svn-apply:
3454         https://bugs.webkit.org/show_bug.cgi?id=27204
3455
3456         * Scripts/update-webkit-chromium: Added property svn:executable.
3457         * Scripts/validate-committer-lists: Added property svn:executable.
3458
3459 2009-11-29  Eric Seidel  <eric@webkit.org>
3460
3461         Reviewed by Adam Barth.
3462
3463         Need a way to validate that committers.py includes all committers/reviewers
3464         https://bugs.webkit.org/show_bug.cgi?id=30970
3465
3466         Add a script which knows how to compare our public committer/reviewer
3467         lists and show discrepancies between them.
3468
3469         Validates mailing lists vs. committers.py:
3470         - committers.py committers missing from webkit-committers@lists
3471         - webkit-committers@lists members missing from committers.py
3472         - committers.py reviewers missing from webkit-reviewers@lists
3473         - webkit-reviewers@lists members missing from committers.py
3474         - webkit-reviewers@lists members missing from committers.py reviewer list
3475
3476         Validates committers.py vs. trunk/ SVN history:
3477         - committers who have not committed in over a year
3478         - SVN committers missing from committers.py
3479         - committers.py members who have no record in SVN.
3480
3481         All of these lists still show "false positives" until a few more committers.py updates are made, like:
3482         https://bugs.webkit.org/show_bug.cgi?id=31366
3483
3484         * Scripts/validate-committer-lists: Added.
3485
3486 2009-11-28  Adam Barth  <abarth@webkit.org>
3487
3488         Reviewed by Eric Seidel.
3489
3490         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
3491         https://bugs.webkit.org/show_bug.cgi?id=31950
3492
3493         Now we cache the last status that we get back from QueueStatusServer.
3494         Eventually we'll have to do something more fancy if we want to support
3495         a "try again" button on QueueStatusServer, but we can cross that bridge
3496         when we come to it.
3497
3498         * Scripts/modules/patchcollection.py:
3499
3500 2009-11-28  Adam Barth  <abarth@webkit.org>
3501
3502         Reviewed by Eric Seidel.
3503
3504         StyleQueue scans ~100 bug pages every 5 minutes
3505         https://bugs.webkit.org/show_bug.cgi?id=31947
3506
3507         Instead of getting the pending-review attachment ids by scanning each
3508         bug (which results in a network request), we should just get them all
3509         from webkit.org/pending-review in one shot.
3510
3511         * Scripts/modules/bugzilla.py:
3512         * Scripts/modules/bugzilla_unittest.py:
3513         * Scripts/modules/commands/queries.py:
3514         * Scripts/modules/commands/queries_unittest.py:
3515         * Scripts/modules/commands/queues.py:
3516         * Scripts/modules/mock_bugzillatool.py:
3517         * Scripts/modules/patchcollection.py:
3518
3519 2009-11-28  Adam Barth  <abarth@webkit.org>
3520
3521         Reviewed by Eric Seidel.
3522
3523         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
3524         https://bugs.webkit.org/show_bug.cgi?id=31952
3525
3526         The mailing list is open for anyone to subscribe.
3527
3528         * Scripts/modules/bugzilla.py:
3529         * Scripts/modules/commands/queues.py:
3530
3531 2009-11-28  Adam Barth  <abarth@webkit.org>
3532
3533         Reviewed by Eric Seidel.
3534
3535         [bzt] style-queue should report style errors to bugzilla
3536         https://bugs.webkit.org/show_bug.cgi?id=31945
3537
3538         Currently, we're just logging the style errors locally.  With this
3539         patch we'll actually log the errors to bugzilla.  Note: I plan to run
3540         with the "local-only" logging during development.
3541
3542         * Scripts/modules/commands/queues.py:
3543         * Scripts/modules/scm.py:
3544
3545 2009-11-28  Adam Barth  <abarth@webkit.org>
3546
3547         Reviewed by Eric Seidel.
3548
3549         [bzt] style-queue shouldn't reject patches from the commit-queue
3550         https://bugs.webkit.org/show_bug.cgi?id=31944
3551
3552         Currently the style-queue subprocess gets confused and thinks its the
3553         commit-queue.  If the patch has an error, it rejects it from the
3554         commit-queue.  Instead, we should have style-queue specific logic.
3555         This patch doesn't add that logic, but it gives us a callback we can
3556         use to add that logic.
3557
3558         * Scripts/modules/buildsteps.py:
3559         * Scripts/modules/commands/queues.py:
3560         * Scripts/modules/landingsequence.py:
3561
3562 2009-11-27  Adam Barth  <abarth@webkit.org>
3563
3564         Rubber stamped by Eric Seidel.
3565
3566         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
3567
3568         * CommitQueueStatus: Removed.
3569         * CommitQueueStatus/app.yaml: Removed.
3570         * CommitQueueStatus/filters: Removed.
3571         * CommitQueueStatus/filters/__init__.py: Removed.
3572         * CommitQueueStatus/filters/webkit_extras.py: Removed.
3573         * CommitQueueStatus/index.html: Removed.
3574         * CommitQueueStatus/index.yaml: Removed.
3575         * CommitQueueStatus/queue_status.py: Removed.
3576         * CommitQueueStatus/stylesheets: Removed.
3577         * CommitQueueStatus/stylesheets/main.css: Removed.
3578         * CommitQueueStatus/update_status.html: Removed.
3579         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
3580
3581 2009-11-27  Adam Barth  <abarth@webkit.org>
3582
3583         Reviewed by Eric Seidel.
3584
3585         style-queue should only process each patch once
3586         https://bugs.webkit.org/show_bug.cgi?id=31939
3587
3588         Actually address reviewer comments!
3589
3590         * Scripts/bugzilla-tool:
3591
3592 2009-11-27  Adam Barth  <abarth@webkit.org>
3593
3594         Reviewed by Eric Seidel.
3595
3596         [bzt] style-queue fails to apply a bunch of patches for no reason
3597         https://bugs.webkit.org/show_bug.cgi?id=31942
3598
3599         By passing --non-interactive to check-style, we convince check-style
3600         to pass --force to svn-apply, which lets it apply more patches.
3601
3602         * Scripts/modules/commands/queues.py:
3603
3604 2009-11-27  Adam Barth  <abarth@webkit.org>
3605
3606         Reviewed by Eric Seidel.
3607
3608         [bzt] Support --status-host in style-queue
3609         https://bugs.webkit.org/show_bug.cgi?id=31941
3610
3611         * Scripts/modules/commands/queues.py:
3612         * Scripts/modules/statusbot.py:
3613
3614 2009-11-27  Adam Barth  <abarth@webkit.org>
3615
3616         Reviewed by Eric Seidel.
3617
3618         style-queue should only process each patch once
3619         https://bugs.webkit.org/show_bug.cgi?id=31939
3620
3621         Before processing a patch, the try-queues now ask the web service
3622         whether they have already processed the patch.  This is an initial cut
3623         of this functionality.  I expect we're make it richer over time.
3624
3625         * Scripts/bugzilla-tool:
3626         * Scripts/modules/commands/queues.py:
3627         * Scripts/modules/patchcollection.py:
3628
3629 2009-11-27  Adam Barth  <abarth@webkit.org>
3630
3631         Reviewed by Eric Seidel.
3632
3633         PatchStatus does not return status
3634         https://bugs.webkit.org/show_bug.cgi?id=31938
3635
3636         We need to parse attachment_id as an int.  Otherwise, we can't find
3637         anything in the datastore.
3638