Windows build fix.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
2
3         No Review.
4
5         Fix spelling error ("depenedencies").
6
7         * Scripts/build-webkit:
8
9 2009-11-24  Mark Rowe  <mrowe@apple.com>
10
11         Land the configuration that includes the two debug GTK Linux builders.
12
13         * BuildSlaveSupport/build.webkit.org-config/config.json:
14
15 2009-11-24  David Kilzer  <ddkilzer@apple.com>
16
17         <http://webkit.org/b/31840> bisect-builds broke after r50080
18
19         Reviewed by Dan Bernstein.
20
21         * Scripts/bisect-builds:
22         (mountAndRunNightly): Switched back to using backticks to run
23         the hdiutil command since exec() will terminate the existing
24         script, which is not what we want.  Store the output of
25         File::Spec->devnull() in a variable for use in the hdiutil
26         detach commands.
27
28 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
29
30         Reviewed by Kenneth Rohde Christiansen.
31
32         Include "config.h" to meet Coding Style Guidelines
33         https://bugs.webkit.org/show_bug.cgi?id=31792
34
35         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
36         * DumpRenderTree/qt/jsobjects.cpp:
37         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
38
39 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
40
41         Reviewed by Oliver Hunt.
42
43         Implement new required function to pass test we used to pass. This
44         change is required since r51294.
45
46         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
47         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
48
49 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
50
51         Reviewed by Kenneth Rohde Christiansen.
52
53         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
54         https://bugs.webkit.org/show_bug.cgi?id=31775
55
56         LayoutTestController::dumpBackForwardList() should work with local URLs
57         as well as with normal URLs (in http tests for instance).
58         Currently it does not output the latter properly.
59
60         Unskip a bunch of passing http/navigation tests.
61
62         * DumpRenderTree/qt/DumpRenderTree.cpp:
63         (WebCore::dumpHistoryItem):
64
65 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
66
67         Reviewed by Oliver Hunt.
68
69         ARIA: support aria-flowto
70         https://bugs.webkit.org/show_bug.cgi?id=31762
71
72         * DumpRenderTree/AccessibilityUIElement.cpp:
73         (ariaFlowToElementAtIndexCallback):
74         (AccessibilityUIElement::getJSClass):
75         * DumpRenderTree/AccessibilityUIElement.h:
76         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
77         (AccessibilityUIElement::ariaFlowToElementAtIndex):
78         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
79         (AccessibilityUIElement::ariaFlowToElementAtIndex):
80         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
81         (AccessibilityUIElement::ariaFlowToElementAtIndex):
82
83 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
84
85         Reviewed by Kenneth Christiansen.
86
87         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
88         https://bugs.webkit.org/show_bug.cgi?id=31638
89
90         Unfreeze WorkQueue after each test execution.
91
92         * DumpRenderTree/qt/DumpRenderTree.cpp:
93         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
94
95 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
96
97         Reviewed by Adam Barth.
98
99         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
100         for localhost and 127.0.0.1.
101         https://bugs.webkit.org/show_bug.cgi?id=31783
102
103         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
104
105         * DumpRenderTree/qt/DumpRenderTree.cpp:
106         (WebCore::NetworkAccessManager::NetworkAccessManager):
107         (WebCore::NetworkAccessManager::sslErrorsEncountered):
108         (WebCore::WebPage::WebPage):
109         * DumpRenderTree/qt/DumpRenderTree.h:
110
111 2009-11-22  Chris Evans  <cevans@chromium.org>
112
113         Reviewed by Adam Barth.
114
115         Disable access to file:/// directory listings
116         https://bugs.webkit.org/show_bug.cgi?id=31329
117
118         Implemented setAllowUniversalAccessFromFileURLs to support testing of
119         file URL security.
120
121         * DumpRenderTree/LayoutTestController.cpp:
122         (setAllowUniversalAccessFromFileURLsCallback):
123         (LayoutTestController::staticFunctions):
124         * DumpRenderTree/LayoutTestController.h:
125         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
126         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
127         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
128         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
129         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
130         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
131         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
132         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
133
134 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
135
136         Reviewed by Kenneth Rohde Christiansen.
137
138         [Qt] Fix the timeout of fast/frames/frame-navigation.html
139         https://bugs.webkit.org/show_bug.cgi?id=31638
140
141         The test is timeouting, because it uses the WorkQueue to load a document in one
142         of the child frames and once the loading is finished, the DRT does not dump the
143         tree. This is because it waits for the QWebFrame::loadFinished() signal from
144         the main frame, while it should connect to QWebPage::loadFinished().
145
146         * DumpRenderTree/qt/DumpRenderTree.cpp:
147         (WebCore::DumpRenderTree::DumpRenderTree):
148
149 2009-11-21  Eric Seidel  <eric@webkit.org>
150
151         Reviewed by Adam Barth.
152
153         bugzilla-tool --help spews way too much text
154         https://bugs.webkit.org/show_bug.cgi?id=31771
155
156         * Scripts/bugzilla-tool:
157          - Remove self.cached_scm initialization hack.
158         * Scripts/modules/buildbot.py:
159          - Make default_host accessible to callers.
160         * Scripts/modules/commands/download.py:
161          - Phrase help for all commands consistently and remove spurious help text punctuation.
162         * Scripts/modules/commands/queries.py: Ditto.
163         * Scripts/modules/commands/queues.py: Ditto.
164         * Scripts/modules/commands/upload.py: Ditto.
165         * Scripts/modules/multicommandtool.py:
166          - Add HelpPrintingOptionParser.format_epilog to replace
167            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
168            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
169          - Make --help only show a list of commands like "svn help" and "git help" do --
170            previously --help was listing all commands and options.
171          - Sort list of commands alphabetically.
172
173 2009-11-21  Eric Seidel  <eric@webkit.org>
174
175         No review.  Fixing a typo from the previous patch for bug 31767.
176
177         AbstractQueue.run_bugzilla_tool throws an exception
178         https://bugs.webkit.org/show_bug.cgi?id=31769
179
180         * Scripts/modules/commands/queues.py:
181
182 2009-11-21  Eric Seidel  <eric@webkit.org>
183
184         Reviewed by Adam Barth.
185
186         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
187         https://bugs.webkit.org/show_bug.cgi?id=31767
188
189         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
190         Since we don't have a good way to test BugzillaTool pieces, I've
191         left out a test for now.
192
193         * Scripts/bugzilla-tool:
194          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
195         * Scripts/modules/commands/queues.py:
196          - Use tool.path() instead of __file__.
197         * Scripts/modules/multicommandtool.py:
198          - Add a new path() method to MultiComandTool.
199         * Scripts/modules/multicommandtool_unittest.py:
200          - Provide a path() method.  Little point in testing this mock implementation.
201
202 2009-11-21  Adam Barth  <abarth@webkit.org>
203
204         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
205         WebKitTools.
206
207         * Scripts/modules/commands/download.py:
208
209 2009-11-21  Adam Barth  <abarth@webkit.org>
210
211         Reviewed by Eric Seidel.
212
213         Convert check-style to use LandingSequence
214         https://bugs.webkit.org/show_bug.cgi?id=31763
215
216         Instead of manipulating the working copy by hand, we should use the
217         LandingSequence in CheckStyle.  This will make this code eaiser to
218         test.
219
220         * Scripts/modules/commands/download.py:
221
222 2009-11-20  Adam Barth  <abarth@webkit.org>
223
224         Reviewed by Eric Seidel.
225
226         Unit test query commands
227         https://bugs.webkit.org/show_bug.cgi?id=31755
228
229         These tests are pretty rough, but hopefully they'll grow.
230
231         * Scripts/modules/commands/queries_unittest.py: Added.
232         * Scripts/modules/mock_bugzillatool.py: Added.
233         * Scripts/run-webkit-unittests:
234
235 2009-11-20  Eric Seidel  <eric@webkit.org>
236
237         Reviewed by Adam Barth.
238
239         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
240         https://bugs.webkit.org/show_bug.cgi?id=31758
241
242         * Scripts/modules/multicommandtool.py:
243          - Allow passing of explicit commands to MultiCommandTool.__init__
244         * Scripts/modules/multicommandtool_unittest.py:
245          - Use new Command.name naming system.
246          - Test Command auto-discovery.
247         * Scripts/modules/workqueue.py:
248          - bug_id no longer exists, use patch['bug_id'] instead.
249         * Scripts/modules/workqueue_unittest.py:
250          - WorkQueues require names now.
251          - should_proceed_with_work_item must return a patch object.
252
253 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
254
255         Reviewed by Beth Dakin.
256
257         WAI-ARIA: add support for aria-owns
258         https://bugs.webkit.org/show_bug.cgi?id=31702
259
260         * DumpRenderTree/AccessibilityUIElement.cpp:
261         (ariaOwnsElementAtIndexCallback):
262         (AccessibilityUIElement::getJSClass):
263         * DumpRenderTree/AccessibilityUIElement.h:
264         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
265         (AccessibilityUIElement::ariaOwnsElementAtIndex):
266         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
267         (AccessibilityUIElement::ariaOwnsElementAtIndex):
268         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
269         (AccessibilityUIElement::ariaOwnsElementAtIndex):
270
271 2009-11-20  Eric Seidel  <eric@webkit.org>
272
273         Reviewed by Adam Barth.
274
275         Fix exception thrown when running the commit-queue.
276
277         * Scripts/modules/statusbot.py: patch is optional.
278         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
279
280 2009-11-20  Eric Seidel  <eric@webkit.org>
281
282         Reviewed by Adam Barth.
283
284         Teach the StatusBot how to support more than just the commit-queue
285         https://bugs.webkit.org/show_bug.cgi?id=31754
286
287         * Scripts/modules/workqueue.py: Another typo.
288
289 2009-11-20  Eric Seidel  <eric@webkit.org>
290
291         Reviewed by Adam Barth.
292
293         Teach the StatusBot how to support more than just the commit-queue
294         https://bugs.webkit.org/show_bug.cgi?id=31754
295
296         * Scripts/modules/commands/queues.py: Fix silly typo.
297
298 2009-11-20  Eric Seidel  <eric@webkit.org>
299
300         Reviewed by Adam Barth.
301
302         Teach the StatusBot how to support more than just the commit-queue
303         https://bugs.webkit.org/show_bug.cgi?id=31754
304
305         * CommitQueueStatus/index.yaml:
306          - Add indices required for the new queries.
307         * CommitQueueStatus/queue_status.py:
308          - Add a patch-status page and move update_status to update-status.
309          - Only display "commit-queue" status records for the commit-queue.
310          - Add support for a queue_name property on status records.
311          - Fix _int_from_request to actually work.
312         * CommitQueueStatus/update_status.html:
313          - Add support for a queue_name on status records.
314          - Remove unused list of bug ids.
315          * Scripts/modules/commands/queues.py
316           - Make the queues pass the patch instead of the bug_id to StatusBot.
317         * Scripts/modules/statusbot.py:
318          - Support passing the queue_name to the status updates.
319          - Support fetching patch status with patch_status().
320         * Scripts/modules/workqueue.py:
321          - Pass the patch to the StatusBot instead of the bug_id.
322          - Let WorkQueues have a name.
323
324 2009-11-20  Adam Barth  <abarth@webkit.org>
325
326         Reviewed by Eric Seidel.
327
328         Move bugzilla-tool commands into their own file
329         https://bugs.webkit.org/show_bug.cgi?id=31752
330
331         This will let us write unit tests.
332
333         * Scripts/bugzilla-tool:
334         * Scripts/modules/commands/__init__.py: Added.
335         * Scripts/modules/commands/download.py: Added.
336         * Scripts/modules/commands/queries.py: Added.
337         * Scripts/modules/commands/queues.py: Added.
338         * Scripts/modules/commands/upload.py: Added.
339         * Scripts/modules/grammar.py: Added.
340
341 2009-11-20  Adam Barth  <abarth@webkit.org>
342
343         Reviewed by Eric Seidel.
344
345         BuildQueue should check if the tree is currently buildable
346         https://bugs.webkit.org/show_bug.cgi?id=31744
347
348         * Scripts/bugzilla-tool:
349         * Scripts/modules/landingsequence.py:
350         * Scripts/modules/webkitlandingscripts.py:
351
352 2009-11-20  Adam Barth  <abarth@webkit.org>
353
354         Reviewed by Eric Seidel.
355
356         Move prepare_clean_working_directory into the LandingSequence
357         https://bugs.webkit.org/show_bug.cgi?id=31743
358
359         * Scripts/bugzilla-tool:
360         * Scripts/modules/landingsequence.py:
361
362 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
363
364         Reviewed by Kenneth Rohde Christiansen.
365
366         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
367         https://bugs.webkit.org/show_bug.cgi?id=30460
368
369         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
370
371         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
372         (pluginInvoke):
373
374 2009-11-20  Adam Barth  <abarth@webkit.org>
375
376         Reviewed by Eric Seidel.
377
378         Pass the port information to the child process
379         https://bugs.webkit.org/show_bug.cgi?id=31736
380
381         We need to do this so the child process knows what to build!
382
383         * Scripts/bugzilla-tool:
384         * Scripts/modules/landingsequence.py:
385         * Scripts/modules/webkitport.py:
386         * Scripts/modules/webkitport_unittest.py:
387
388 2009-11-20  Adam Barth  <abarth@webkit.org>
389
390         Reviewed by Eric Seidel.
391
392         Support Qt port in build-queue
393         https://bugs.webkit.org/show_bug.cgi?id=31733
394
395         * Scripts/bugzilla-tool:
396
397 2009-11-20  Adam Barth  <abarth@webkit.org>
398
399         Reviewed by Eric Seidel.
400
401         Implement a build-queue
402         https://bugs.webkit.org/show_bug.cgi?id=31725
403
404         Currently this just builds the first 10 patches in the review queue.
405         We'll want to do something smarter soon.
406
407         * Scripts/bugzilla-tool:
408
409 2009-11-20  Adam Barth  <abarth@webkit.org>
410
411         Reviewed by Eric Seidel.
412
413         Make commit-queue and style-queue show up in help
414         https://bugs.webkit.org/show_bug.cgi?id=31724
415
416         We need to store their names on their class to make these commands
417         properly register themselves with MultiCommandTool.
418
419         * Scripts/bugzilla-tool:
420
421 2009-11-20  Adam Barth  <abarth@webkit.org>
422
423         Reviewed by Eric Seidel.
424
425         Implement bugzilla-tool build-attachment
426         https://bugs.webkit.org/show_bug.cgi?id=31722
427
428         This command builds an attachment from bugzilla.  It leaves the built
429         patch in the working copy.
430
431         * Scripts/bugzilla-tool:
432         * Scripts/modules/landingsequence.py:
433         * Scripts/modules/webkitlandingscripts.py:
434
435 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
436
437         Reviewed by Xan Lopez.
438
439         [GTK] DRT release event does not create the state correctly
440         https://bugs.webkit.org/show_bug.cgi?id=31717
441
442         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
443
444 2009-11-20  Eric Seidel  <eric@webkit.org>
445
446         Reviewed by Adam Barth.
447
448         MultiCommandTool should find Command objects automatically instead of with a manual list
449         https://bugs.webkit.org/show_bug.cgi?id=31710
450
451         * Scripts/bugzilla-tool:
452         * Scripts/modules/multicommandtool.py:
453          - Use some wild python-fu to crawl all the known subclasses of Command.
454
455 2009-11-20  Adam Barth  <abarth@webkit.org>
456
457         Unreviewed "build" fix.  Added missing import.
458
459         * Scripts/bugzilla-tool:
460
461 2009-11-20  Adam Barth  <abarth@webkit.org>
462
463         Unreviewed "build" fix.  I failed to update LandingSequence.test
464         properly.
465
466         * Scripts/modules/landingsequence.py:
467
468 2009-11-20  Adam Barth  <abarth@webkit.org>
469
470         Reviewed by Eric Seidel.
471
472         Create LandingSequence as the all-sing, all-dance landing class
473         https://bugs.webkit.org/show_bug.cgi?id=31709
474
475         Client can inherit from this class to carefully control exactly which
476         steps they wish to have happen in the landing sequence.
477
478         * Scripts/bugzilla-tool:
479         * Scripts/modules/landingsequence.py: Added.
480         * Scripts/modules/webkitlandingscripts.py: Added.
481
482 2009-11-19  Adam Barth  <abarth@webkit.org>
483
484         Reviewed by Eric Seidel.
485
486         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
487         https://bugs.webkit.org/show_bug.cgi?id=31707
488
489         This is to help when we implement build-attachment.
490
491         * Scripts/bugzilla-tool:
492
493 2009-11-19  Adam Barth  <abarth@webkit.org>
494
495         Reviewed by Eric Seidel.
496
497         Support Qt port in bugzilla-tool
498         https://bugs.webkit.org/show_bug.cgi?id=31701
499
500         Now we support building with Qt!
501
502         * Scripts/bugzilla-tool:
503         * Scripts/modules/webkitport.py: Added.
504         * Scripts/modules/webkitport_unittest.py: Added.
505         * Scripts/run-webkit-unittests:
506
507 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
508
509         Reviewed by Adam Barth.
510
511         Remove inserting stderr into patch in bugzilla-tool
512         https://bugs.webkit.org/show_bug.cgi?id=29914
513
514         Modify SCM python module's run_command function to avoid return of stderr
515         by default, so stderr won't be inserted into the patches.
516         Modify the related unit test.
517
518         * Scripts/modules/scm.py:
519         * Scripts/modules/scm_unittest.py:
520
521 2009-11-19  Eric Seidel  <eric@webkit.org>
522
523         Reviewed by Adam Barth.
524
525         bugzilla-tool needs per-command help
526         https://bugs.webkit.org/show_bug.cgi?id=31697
527
528         Added support for "bugzilla-tool help command-name"
529         and a unit test to make sure it works.
530
531         * Scripts/modules/multicommandtool.py:
532         * Scripts/modules/multicommandtool_unittest.py:
533
534 2009-11-19  Eric Seidel  <eric@webkit.org>
535
536         Reviewed by Adam Barth.
537
538         Move MultiCommandTool and Command into a separate file and add some basic unit tests
539         https://bugs.webkit.org/show_bug.cgi?id=31695
540
541         * Scripts/bugzilla-tool:
542         * Scripts/modules/multicommandtool.py: Added.
543         * Scripts/modules/multicommandtool_unittest.py: Added.
544         * Scripts/run-webkit-unittests:
545
546 2009-11-19  Eric Seidel  <eric@webkit.org>
547
548         No review, just adding a FIXME.
549
550         Split out command parsing and help printing from BugzillaTool
551         https://bugs.webkit.org/show_bug.cgi?id=31688
552
553         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
554
555 2009-11-19  Eric Seidel  <eric@webkit.org>
556
557         Reviewed by Adam Barth.
558
559         Split out command parsing and help printing from BugzillaTool
560         https://bugs.webkit.org/show_bug.cgi?id=31688
561
562         * Scripts/bugzilla-tool:
563          - Add new MultiCommandTool class to contain option parsing and help printing logic.
564          - Rename private methods to use _ pattern.
565          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
566          - 
567
568 2009-11-19  Eric Seidel  <eric@webkit.org>
569
570         Reviewed by Adam Barth.
571
572         Re-factor help printing to use modern python idioms
573         https://bugs.webkit.org/show_bug.cgi?id=31685
574
575         * Scripts/bugzilla-tool:
576
577 2009-11-19  Eric Seidel  <eric@webkit.org>
578
579         Reviewed by Darin Adler.
580
581         commit-queue empty queue logs twice
582         https://bugs.webkit.org/show_bug.cgi?id=31679
583
584         * Scripts/bugzilla-tool:
585
586 2009-11-19  Eric Seidel  <eric@webkit.org>
587
588         Reviewed by Darin Adler.
589
590         bugzilla-tool's reviewer/committer rejection message should be clearer
591         https://bugs.webkit.org/show_bug.cgi?id=31126
592
593         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
594
595         * Scripts/modules/bugzilla.py:
596
597 2009-11-19  Eric Z. Ayers  <zundel@google.com>
598
599         Reviewed by Pavel Feldman.
600
601         Forces a WM_PAINT event on calling layoutTestController.display()
602         in order to enable the timeline-paint.html test on Windows.
603         ::UpdateWindow() does not force an event becaue the window is 
604         not visible.
605
606         https://bugs.webkit.org/show_bug.cgi?id=31402
607
608         * DumpRenderTree/win/DumpRenderTree.cpp:
609         (displayWebView):
610
611 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
612
613         No review needed.
614
615         Added myself to committers list.
616
617         * Scripts/modules/committers.py:
618
619 2009-11-19  Adam Barth  <abarth@webkit.org>
620
621         Reviewed by Eric Seidel.
622
623         Bugzilla-tool command classes should match command names
624         https://bugs.webkit.org/show_bug.cgi?id=31666
625
626         I renamed all the commands except CommitMessageForCurrentDiff because
627         the new name would conflict with an existing class.
628
629         * Scripts/bugzilla-tool:
630
631 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
632
633         Reviewed by Gustavo Noronha Silva.
634
635         Web Inspector: Implement "show inspector" in WebKit GTK
636         API and enable console tests.
637
638         https://bugs.webkit.org/show_bug.cgi?id=31669
639
640         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
641         (LayoutTestController::showWebInspector):
642
643 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
644
645         Reviewed by Simon Hausmann.
646
647         Minor refactoring + more documentation.
648
649         * DumpRenderTree/qt/DumpRenderTree.cpp:
650         (WebCore::clearHistory):
651         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
652
653 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
654
655         Reviewed by Eric Seidel.
656
657         Ignore websocket tests when --no-http is specified.
658         https://bugs.webkit.org/show_bug.cgi?id=31662
659
660         * Scripts/run-webkit-tests:
661
662 2009-11-18  Adam Barth  <abarth@webkit.org>
663
664         Reviewed by Eric Seidel.
665
666         Normalize ' and " in bugzilla-tool
667         https://bugs.webkit.org/show_bug.cgi?id=31655
668
669         We decided " is better than ' and we should be consistent.
670
671         * Scripts/bugzilla-tool:
672
673 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
674
675         Reviewed by Kenneth Rohde Christiansen.
676
677         [Qt] Remove support for Qt v4.3 or older versions
678         https://bugs.webkit.org/show_bug.cgi?id=29469
679
680         * DumpRenderTree/qt/DumpRenderTree.pro:
681         * DumpRenderTree/qt/ImageDiff.pro:
682
683 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
684
685         Reviewed by Eric Seidel.
686
687         GitTest.test_create_binary_patch fails if /tmp is symlink
688         https://bugs.webkit.org/show_bug.cgi?id=31536
689
690         * Scripts/modules/scm_unittest.py:
691
692 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
693
694         Reviewed by Darin Adler.
695
696         Configuration for Chromium Build Slaves.
697
698         https://bugs.webkit.org/show_bug.cgi?id=31442
699
700         * BuildSlaveSupport/build.webkit.org-config/config.json:
701         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
702
703 2009-11-18  Eric Seidel  <eric@webkit.org>
704
705         Reviewed by Darin Adler.
706
707         workqueue.py results in totally broken commit-queue UI
708         https://bugs.webkit.org/show_bug.cgi?id=31645
709
710         * Scripts/bugzilla-tool:
711          - Remove unneeded use of PatchCollection.
712          - Grab a new copy of the cq'd patches every run of the queue.
713
714 2009-11-18  Sam Weinig  <sam@webkit.org>
715
716         Reviewed by Anders Carlsson.
717
718         Make the Mac Geolocation API async.
719
720         Update DRT to use the new async Mac Geolocation API.
721
722         * DumpRenderTree/mac/UIDelegate.mm:
723         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
724
725 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
726
727         Reviewed by Kenneth Rohde Christiansen.
728
729         Add and option to toggle HTML5 datalist support to build-webkit
730         https://bugs.webkit.org/show_bug.cgi?id=31599
731
732         * Scripts/build-webkit:
733
734 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
735
736         Reviewed by Kevin Ollivier.
737
738         Enable wx plugin support using the Windows implementation as a base.
739         
740         https://bugs.webkit.org/show_bug.cgi?id=31636
741
742         * wx/build/settings.py:
743
744 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
745
746         Reviewed by Simon Hausmann.
747
748         Change the initialization order so that the controllers
749         will be created before exporting them to the JS DOM window.
750
751         * DumpRenderTree/qt/DumpRenderTree.cpp:
752         (WebCore::DumpRenderTree::DumpRenderTree):
753
754 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
755
756         Reviewed by Simon Hausmann.
757
758         Fix a code copy and paste error. m_page should be page.
759
760         * DumpRenderTree/qt/DumpRenderTree.cpp:
761         (WebCore::DumpRenderTree::createWindow):
762
763 2009-11-17  Mark Rowe  <mrowe@apple.com>
764
765         Reviewed by Alexey Proskuryakov.
766
767         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
768
769         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
770         This prevents symlinks from confusing the descendant check.
771
772 2009-11-17  Mark Rowe  <mrowe@apple.com>
773
774         Reviewed by Alexey Proskuryakov.
775
776         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
777
778         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
779         server to be up rather than having run-webkit-tests abort immediately.
780
781         * Scripts/run-webkit-tests:
782
783 2009-11-17  Eric Seidel  <eric@webkit.org>
784
785         Reviewed by Darin Adler.
786
787         commit-queue is failing to set reviewer in ChangeLogs
788         https://bugs.webkit.org/show_bug.cgi?id=31592
789
790         * Scripts/bugzilla-tool: Clarify the "applying" log message.
791         * Scripts/modules/bugzilla.py:
792          - Add a new _validate_committer_and_reviewer function as a
793            temporary solution until we can make a real Attachment object
794            which knows how to fill in its committer/reviewer fields automatically.
795
796 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
797
798         Unreviewed buildbot fix.
799
800         Revert part of earlier patch and add comment, as it
801         was causing timeouts on the buildbot.
802
803         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
804         (LayoutTestController::notifyDone):
805
806 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
807
808         Reviewed by Oliver Hunt.
809
810         Make the timeout 15 sec as for the other DRT's and make
811         it print out the same output when a test timeout.
812
813         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
814         (LayoutTestController::waitUntilDone):
815         (LayoutTestController::notifyDone):
816         (LayoutTestController::timerEvent):
817
818 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
819
820         Reviewed by Timothy Hatcher.
821
822         Fixed typos in comments.
823
824         * Scripts/modules/committers.py:
825
826 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
827
828         Reviewed by Timothy Hatcher.
829
830         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
831         - Updated DRT to show/close inspector for all tests under /inspector
832         - Introduced LayoutTestController::setTimelineProfilingEnabled and
833           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
834         - Removed reload on each inspector test
835         - Renamed fast/inspector to fast/inspector-support in order not to trigger
836         inspector for those.
837         - Reimplemented timeline tests in order to get rid of reload there.
838         - Moved tests that don't require harness into the fast group.
839
840         https://bugs.webkit.org/show_bug.cgi?id=31472
841
842         * DumpRenderTree/LayoutTestController.cpp:
843         (setTimelineProfilingEnabledCallback):
844         (closeWebInspectorCallback):
845         (LayoutTestController::staticFunctions):
846         * DumpRenderTree/LayoutTestController.h:
847         * DumpRenderTree/gtk/DumpRenderTree.cpp:
848         (shouldOpenWebInspector):
849         (runTest):
850         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
851         (LayoutTestController::setTimelineProfilingEnabled):
852         * DumpRenderTree/mac/DumpRenderTree.mm:
853         (shouldOpenWebInspector):
854         (runTest):
855         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
856         (LayoutTestController::setTimelineProfilingEnabled):
857         * DumpRenderTree/win/DumpRenderTree.cpp:
858         (shouldOpenWebInspector):
859         (runTest):
860         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
861         (LayoutTestController::setTimelineProfilingEnabled):
862
863 2009-11-17  Oliver Hunt  <oliver@apple.com>
864
865         Reviewed by Maciej Stachowiak.
866
867         Incorrect use of JavaScriptCore API in DumpRenderTree
868         https://bugs.webkit.org/show_bug.cgi?id=31577
869
870         Return undefined rather than a literal null.
871
872         * DumpRenderTree/AccessibilityUIElement.cpp:
873         (setSelectedTextRangeCallback):
874         (incrementCallback):
875         (decrementCallback):
876         (showMenuCallback):
877
878 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
879
880         Reviewed by Beth Dakin.
881
882         AX: aria-labelledby duplicates some of its WAI-ARIA label
883         https://bugs.webkit.org/show_bug.cgi?id=31565
884
885         * DumpRenderTree/AccessibilityUIElement.cpp:
886         (titleUIElementCallback):
887         (getIsValidCallback):
888         (AccessibilityUIElement::getJSClass):
889
890 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
891
892         Reviewed by Simon Hausmann.
893
894         r50942 broke output from created windows. Make the
895         m_enableTextOutput a member of the DRT and not the
896         WebPage.
897
898         * DumpRenderTree/qt/DumpRenderTree.cpp:
899         (WebCore::WebPage::WebPage):
900         (WebCore::WebPage::javaScriptAlert):
901         (WebCore::WebPage::javaScriptConsoleMessage):
902         (WebCore::WebPage::javaScriptConfirm):
903         (WebCore::WebPage::javaScriptPrompt):
904         (WebCore::WebPage::acceptNavigationRequest):
905         (WebCore::DumpRenderTree::DumpRenderTree):
906         (WebCore::DumpRenderTree::open):
907         (WebCore::DumpRenderTree::createWindow):
908         * DumpRenderTree/qt/DumpRenderTree.h:
909         (WebCore::DumpRenderTree::setTextOutputEnabled):
910         (WebCore::DumpRenderTree::isTextOutputEnabled):
911         (WebCore::WebPage::shouldInterruptJavaScript):
912         (WebCore::WebPage::isTextOutputEnabled):
913         (WebCore::WebPage::setViewGeometry):
914
915 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
916
917         Reviewed by Gustavo Noronha Silva.
918
919         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
920         as the implementation is being used by at least Qt and Gtk+.
921
922         Update buildsystems as well.
923
924         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
925         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
926         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
927         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
928         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
929         * GNUmakefile.am:
930
931 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
932
933         Reviewed by Alexey Proskuryakov.
934
935         Disable wss until all platforms support pyOpenSSL
936
937         https://bugs.webkit.org/show_bug.cgi?id=31479
938
939         * Scripts/run-webkit-tests:
940
941 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
942
943         Reviewed by Kenneth Christiansen.
944
945         [Qt] Implement load error pages support for Qt's DRT.
946         https://bugs.webkit.org/show_bug.cgi?id=31509
947
948         For now, it will not be a default feature, and layout tests
949         that want to make use of this have to explicitily call
950         'handleErrorPages();' for the test source.
951
952         Any of the other DumpRenderTree's (mac, win and gtk)
953         support handling error pages. Qt's will be the first.
954
955         * DumpRenderTree/qt/DumpRenderTree.cpp:
956         (WebCore::WebPage::supportsExtension):
957         (WebCore::WebPage::extension):
958         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
959         (LayoutTestController::reset):
960         * DumpRenderTree/qt/LayoutTestControllerQt.h:
961         (LayoutTestController::shouldHandleErrorPages):
962         (LayoutTestController::handleErrorPages):
963
964 2009-11-16  Eric Seidel  <eric@webkit.org>
965
966         Reviewed by Adam Barth.
967
968         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
969         https://bugs.webkit.org/show_bug.cgi?id=31549
970
971         Renamed --commit-queue to --non-interactive in most places
972         and remove the code in land-patches which is no longer needed.
973
974         * Scripts/bugzilla-tool:
975
976 2009-11-16  Eric Seidel  <eric@webkit.org>
977
978         Reviewed by Adam Barth.
979
980         The commit-queue should use land-attachment
981         https://bugs.webkit.org/show_bug.cgi?id=31548
982
983         * Scripts/bugzilla-tool:
984
985 2009-11-16  Adam Barth  <abarth@webkit.org>
986
987         Reviewed by Eric Seidel.
988
989         Convert CommitQueue over to PatchCollection
990         https://bugs.webkit.org/show_bug.cgi?id=31547
991
992         Also fixes a bug in workqueue and adds a test!
993
994         * Scripts/bugzilla-tool:
995         * Scripts/modules/workqueue.py:
996         * Scripts/modules/workqueue_unittest.py:
997
998 2009-11-16  Adam Barth  <abarth@webkit.org>
999
1000         Reviewed by Eric Seidel.
1001
1002         Move StyleQueue over to using PatchCollection
1003         https://bugs.webkit.org/show_bug.cgi?id=31544
1004
1005         That's what the class it's for.
1006
1007         * Scripts/bugzilla-tool:
1008         * Scripts/modules/patchcollection.py:
1009         * Scripts/modules/patchcollection_unittest.py:
1010
1011 2009-11-16  Eric Seidel  <eric@webkit.org>
1012
1013         Reviewed by Adam Barth.
1014
1015         bugzilla-tool needs a land-attachment command
1016         https://bugs.webkit.org/show_bug.cgi?id=31546
1017
1018         * Scripts/bugzilla-tool:
1019          - Move all the logic into AbstractLandingCommand and
1020            add a new LandAttachment command subclass.
1021          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1022
1023 2009-11-16  Eric Seidel  <eric@webkit.org>
1024
1025         Reviewed by Adam Barth.
1026
1027         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1028         https://bugs.webkit.org/show_bug.cgi?id=31543
1029
1030         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1031
1032         * Scripts/bugzilla-tool:
1033
1034 2009-11-16  Eric Seidel  <eric@webkit.org>
1035
1036         Reviewed by Adam Barth.
1037
1038         Disable the style queue from posting to the commit queue status page.
1039
1040         * Scripts/bugzilla-tool:
1041
1042 2009-11-16  Adam Barth  <abarth@webkit.org>
1043
1044         Reviewed by Eric Seidel.
1045
1046         Implement PatchCollection
1047         https://bugs.webkit.org/show_bug.cgi?id=31541
1048
1049         This class holds a set of patches and lets clients iterate through
1050         them.  Optionally, clients can install a filter.
1051
1052         * Scripts/modules/patchcollection.py: Added.
1053         * Scripts/modules/patchcollection_unittest.py: Added.
1054         * Scripts/run-webkit-unittests:
1055
1056 2009-11-16  Eric Seidel  <eric@webkit.org>
1057
1058         Reviewed by Adam Barth.
1059
1060         bugzilla-tool land-patches will close bugs with patches r=?
1061         https://bugs.webkit.org/show_bug.cgi?id=28230
1062
1063         The commit-queue shouldn't close patches with outstanding reviews on them,
1064         even if many reviewers seem to be against multi-patch bugs.
1065
1066         * Scripts/bugzilla-tool:
1067
1068 2009-11-16  Eric Seidel  <eric@webkit.org>
1069
1070         Reviewed by Adam Barth.
1071
1072         bugzilla-tool check-style should work with attachment ids instead of bug ids
1073         https://bugs.webkit.org/show_bug.cgi?id=31540
1074
1075         * Scripts/bugzilla-tool:
1076
1077 2009-11-16  Eric Seidel  <eric@webkit.org>
1078
1079         Reviewed by Adam Barth.
1080
1081         WorkQueue is the only place that should know about special exit codes
1082         https://bugs.webkit.org/show_bug.cgi?id=31534
1083
1084         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1085         and add tests for handling exit codes.
1086         I also cleaned up workqueue_unittest.py more.
1087
1088         * Scripts/bugzilla-tool:
1089         * Scripts/modules/workqueue.py:
1090         * Scripts/modules/workqueue_unittest.py:
1091
1092 2009-11-16  Eric Seidel  <eric@webkit.org>
1093
1094         Reviewed by Adam Barth.
1095
1096         Re-factor workqueue_unittest to allow for more than one test.
1097         https://bugs.webkit.org/show_bug.cgi?id=31535
1098
1099         * Scripts/modules/workqueue_unittest.py:
1100
1101 2009-11-16  Eric Seidel  <eric@webkit.org>
1102
1103         Reviewed by Adam Barth.
1104
1105         land-patches needs to be re-factored into smaller chunks
1106         https://bugs.webkit.org/show_bug.cgi?id=31532
1107
1108         * Scripts/bugzilla-tool: fix a couple obvious typos.
1109
1110 2009-11-16  Eric Seidel  <eric@webkit.org>
1111
1112         Reviewed by Adam Barth.
1113
1114         land-patches needs to be re-factored into smaller chunks
1115         https://bugs.webkit.org/show_bug.cgi?id=31532
1116
1117         The next patch will move these methods into WebKitLandingScripts.
1118
1119         * Scripts/bugzilla-tool:
1120          - Split out _land_patch and _close_bug_if_no_active_patches.
1121
1122 2009-11-16  Adam Barth  <abarth@webkit.org>
1123
1124         Reviewed by Eric Seidel.
1125
1126         Fix silly copy-and-paste code.  I am a terrible coder.
1127
1128         * Scripts/modules/bugzilla.py:
1129
1130 2009-11-16  Adam Barth  <abarth@webkit.org>
1131
1132         Reviewed by Eric Seidel.
1133
1134         Implement a StyleQueue
1135         https://bugs.webkit.org/show_bug.cgi?id=31537
1136
1137         The first iteration of the style queue only produces output locally.
1138         There is also a limit of 10 patches because it's not that useful to
1139         iterate through the entire review queue at this point.  We can remove
1140         the limit later.
1141
1142         * Scripts/bugzilla-tool:
1143         * Scripts/modules/bugzilla.py:
1144
1145 2009-11-16  Adam Barth  <abarth@webkit.org>
1146
1147         Reviewed by Eric Seidel.
1148
1149         Unit test WorkQueue
1150         https://bugs.webkit.org/show_bug.cgi?id=31531
1151
1152         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1153
1154         * Scripts/bugzilla-tool:
1155         * Scripts/modules/statusbot.py:
1156         * Scripts/modules/workqueue.py:
1157         * Scripts/modules/workqueue_unittest.py: Added.
1158         * Scripts/run-webkit-unittests:
1159
1160 2009-11-16  Eric Seidel  <eric@webkit.org>
1161
1162         Reviewed by Adam Barth.
1163
1164         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1165         https://bugs.webkit.org/show_bug.cgi?id=31530
1166
1167         * Scripts/bugzilla-tool:
1168
1169 2009-11-16  Eric Seidel  <eric@webkit.org>
1170
1171         Reviewed by Adam Barth.
1172
1173         bugzilla-tool needs apply-attachment
1174         https://bugs.webkit.org/show_bug.cgi?id=31528
1175
1176         * Scripts/bugzilla-tool:
1177          - Add ApplyAttachment command.
1178          - Abstract applying code into WebKitApplyingScripts.
1179          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1180         * Scripts/modules/bugzilla.py:
1181          - Add fetch_attachment and bug_id_for_attachment_id.
1182         * Scripts/modules/bugzilla_unittest.py:
1183          - Add test for new parsing.
1184          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1185
1186 2009-11-16  Eric Seidel  <eric@webkit.org>
1187
1188         Reviewed by Adam Barth.
1189
1190         Document check-style's use of force_clean.
1191
1192         * Scripts/bugzilla-tool:
1193         * Scripts/modules/scm.py:
1194
1195 2009-11-16  Adam Barth  <abarth@webkit.org>
1196
1197         Reviewed by Eric Seidel.
1198
1199         Move WorkQueue to its own file
1200         https://bugs.webkit.org/show_bug.cgi?id=31529
1201
1202         WorkQueue and WorkQueueDelegate are separate concerns from
1203         bugzilla-tool.  Also added a missing include to logging.py.
1204
1205         * Scripts/bugzilla-tool:
1206         * Scripts/modules/logging.py:
1207         * Scripts/modules/workqueue.py:
1208
1209 2009-11-16  Adam Barth  <abarth@webkit.org>
1210
1211         Reviewed by Eric Seidel.
1212
1213         Move OutputTee to logging.py.
1214
1215         * Scripts/bugzilla-tool:
1216         * Scripts/modules/logging.py:
1217
1218 2009-11-15  Adam Barth  <abarth@webkit.org>
1219
1220         Reviewed by Eric Seidel.
1221
1222         Refactor bugzilla-tool to allow for multiple queues
1223         https://bugs.webkit.org/show_bug.cgi?id=31513
1224
1225         Divide the commit queue class into three class to make creating
1226         additional queues easier.
1227
1228         * Scripts/bugzilla-tool:
1229
1230 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1231
1232         Reviewed by Eric Seidel.
1233
1234         svn-apply may not handle git patches created by bugzilla-tool
1235         https://bugs.webkit.org/show_bug.cgi?id=31457
1236
1237         * Scripts/modules/scm.py:
1238         * Scripts/modules/scm_unittest.py:
1239
1240 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1241
1242         Reviewed by Eric Seidel.
1243
1244         bugzilla-tool should post git binary diff
1245         https://bugs.webkit.org/show_bug.cgi?id=31458
1246
1247         Add --binary option to Git.create_patch.
1248
1249         * Scripts/modules/scm.py:
1250         * Scripts/modules/scm_unittest.py:
1251
1252 2009-11-15  Adam Barth  <abarth@webkit.org>
1253
1254         Reviewed by Darin Adler.
1255
1256         Add bugzilla-tool check-style
1257         https://bugs.webkit.org/show_bug.cgi?id=31515
1258
1259         * Scripts/bugzilla-tool:
1260         * Scripts/modules/bugzilla.py:
1261
1262 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1263
1264         Reviewed by Simon Hausmann.
1265
1266         Make the Qt Linux only --valgrind feature, suppress errors
1267         defined in the SuppressedValgrindErrors file.
1268
1269         * Scripts/run-webkit-tests:
1270
1271 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1272
1273         Reviewed by Simon Hausmann.
1274
1275         Set the locale to C and not to the current one in use on the system.
1276
1277         * DumpRenderTree/qt/DumpRenderTree.cpp:
1278         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1279
1280 2009-11-13  Adam Roben  <aroben@apple.com>
1281
1282         Add support for
1283         http/tests/security/isolatedWorld/didClearWindowObject.html
1284
1285         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1286         window objects in isolated worlds are cleared
1287
1288         Reviewed by Dave Hyatt.
1289
1290         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1291
1292         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1293         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1294         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1295         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1296         Added. Sets a __worldID property on the global object whose value is
1297         the ID of this world.
1298         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1299         Respond to this new delegate callback by calling through to one of the
1300         above new methods.
1301         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1302         (worldMap): Added. Returns a HashMap containing all the worlds we've
1303         created.
1304         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1305         haven't kept track of this world.
1306         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1307         instead of declaring our own.
1308
1309         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1310
1311         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1312         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1313         didClearWindowObjectForFrameInStandardWorld.
1314         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1315         Respond to this new delegate callback by calling through to one of the
1316         below new methods.
1317         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1318         Added. Sets a __worldID property on the gobal object whose value is
1319         the ID of this world.
1320         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1321         Added. Moved code here from didClearWindowObject.
1322
1323         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1324         didClearWindowObjectForFrame* functions.
1325
1326         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1327         (worldMap): Added. Returns a HashMap containing all the worlds we've
1328         created.
1329         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1330         haven't kept track of this world.
1331         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1332         instead of declaring our own.
1333
1334 2009-11-13  Adam Roben  <aroben@apple.com>
1335
1336         Finish replacing worldIDs with world objects
1337
1338         The only remaining use of worldIDs was in a method only used by DRT
1339         for the isolated worlds tests.
1340
1341         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1342
1343         Reviewed by Mark Rowe.
1344
1345         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1346         (LayoutTestController::evaluateScriptInIsolatedWorld):
1347         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1348         (LayoutTestController::evaluateScriptInIsolatedWorld):
1349         Updated for changes to WebFrame. Now holds the map of worldID -> world
1350         at this level instead of making WebKit do it.
1351
1352 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1353
1354         Reviewed by Simon Hausmann.
1355
1356         [Qt] Ensure the DRT does not output anything until first test is run
1357
1358         * DumpRenderTree/qt/DumpRenderTree.cpp:
1359         * DumpRenderTree/qt/DumpRenderTree.h:
1360
1361 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1362
1363         Reviewed by Tor Arne Vestbø.
1364
1365         Clear the undo stack in before each new test run.
1366
1367         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1368
1369         * DumpRenderTree/qt/DumpRenderTree.cpp:
1370         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1371
1372 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1373
1374         Reviewed by Kenneth Rohde Christiansen.
1375
1376         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1377
1378         * DumpRenderTree/qt/DumpRenderTree.cpp:
1379         (WebCore::WebPage::resetSettings):
1380         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1381         (LayoutTestController::overridePreference):
1382
1383 2009-11-13  Eric Seidel  <eric@webkit.org>
1384
1385         Reviewed by Adam Barth.
1386
1387         Update committers.py based on svn records
1388         https://bugs.webkit.org/show_bug.cgi?id=31366
1389
1390         This list was generated using validate-committer-lists from
1391         https://bugs.webkit.org/show_bug.cgi?id=30970
1392         and makes committers.py current for committers who have
1393         committed in the last 3 years.
1394
1395         * Scripts/modules/committers.py:
1396
1397 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1398
1399         Reviewed by Adam Barth.
1400
1401         The document-open.html test was flaky at times. The test invokes the layout test plugin
1402         which in its destroy stream handler opens a new document. This basically tears down the
1403         stream and the associated plugin instance. The pluginLog function in the layout test
1404         plugin attempts to retrieve the window script object on a torn down plugin instance
1405         which crashed consistently on windows in the debugger. The functions which issue
1406         these logs already have a valid window script object. We now have variants of the pluginLog
1407         function which take in a window script object with and without variable arguments. 
1408
1409         https://bugs.webkit.org/show_bug.cgi?id=31067
1410
1411         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1412         (pluginLogWithWindowObject):
1413         (pluginLogWithWindowObjectVariableArgs):
1414         (pluginLog):
1415         (notifyTestCompletion):
1416         (testDocumentOpen):
1417         (testWindowOpen):
1418
1419 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1420
1421         Reviewed by Gustavo Noronha Silva.
1422
1423         https://bugs.webkit.org/show_bug.cgi?id=30997
1424         [Gtk] Implemment AtkDocument
1425
1426         Added testing support.
1427
1428         * DumpRenderTree/AccessibilityUIElement.cpp:
1429         * DumpRenderTree/AccessibilityUIElement.h:
1430         (getDocumentEncodingCallback):
1431         (getDocumentURICallback):
1432         (AccessibilityUIElement::getJSClass):
1433         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1434         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1435         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1436         (AccessibilityUIElement::documentEncoding):
1437         (AccessibilityUIElement::documentURI):
1438
1439 2009-11-12  Adam Roben  <aroben@apple.com>
1440
1441         Replace worldIDs with world objects
1442
1443         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1444         user scripts/stylesheets and isolated worlds
1445
1446         Reviewed by Sam Weinig.
1447
1448         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1449         (LayoutTestController::addUserScript):
1450         (LayoutTestController::addUserStyleSheet):
1451         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1452         (LayoutTestController::addUserScript):
1453         (LayoutTestController::addUserStyleSheet):
1454         Changed these functions to create a new WebJSWorld each time they're
1455         called and to pass that world to WebKit.
1456
1457 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1458
1459         Reviewed by Oliver Hunt.
1460
1461         need to implement aria tree roles
1462         https://bugs.webkit.org/show_bug.cgi?id=31284
1463
1464         * DumpRenderTree/AccessibilityUIElement.cpp:
1465         (disclosedRowAtIndexCallback):
1466         (selectedRowAtIndexCallback):
1467         (isEqualCallback):
1468         (isAttributeSettableCallback):
1469         (isActionSupportedCallback):
1470         (disclosedByRowCallback):
1471         (hierarchicalLevelCallback):
1472         (AccessibilityUIElement::getJSClass):
1473         * DumpRenderTree/AccessibilityUIElement.h:
1474         (AccessibilityUIElement::isEqual):
1475         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1476         (AccessibilityUIElement::hierarchicalLevel):
1477         (AccessibilityUIElement::disclosedRowAtIndex):
1478         (AccessibilityUIElement::selectedRowAtIndex):
1479         (AccessibilityUIElement::disclosedByRow):
1480         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1481         (AccessibilityUIElement::getChildAtIndex):
1482         (AccessibilityUIElement::disclosedRowAtIndex):
1483         (AccessibilityUIElement::selectedRowAtIndex):
1484         (AccessibilityUIElement::titleUIElement):
1485         (AccessibilityUIElement::parentElement):
1486         (AccessibilityUIElement::disclosedByRow):
1487         (AccessibilityUIElement::hierarchicalLevel):
1488         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1489         (AccessibilityUIElement::hierarchicalLevel):
1490         (AccessibilityUIElement::disclosedRowAtIndex):
1491         (AccessibilityUIElement::selectedRowAtIndex):
1492         (AccessibilityUIElement::disclosedByRow):
1493
1494 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1495
1496         Reviewed by Darin Adler.
1497
1498         svn-apply can not handle git binary diffs
1499         https://bugs.webkit.org/show_bug.cgi?id=26830
1500
1501         Support "literal" type git binary diffs.
1502
1503         * Scripts/VCSUtils.pm:
1504         * Scripts/modules/scm_unittest.py:
1505         * Scripts/svn-apply:
1506
1507 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1508
1509         Not reviewed, removing duplicate entry for myself in committers.py.
1510
1511         * Scripts/modules/committers.py:
1512
1513 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1514
1515         Reviewed by Darin Adler and Mark Rowe.
1516
1517         https://bugs.webkit.org/show_bug.cgi?id=31200
1518         Tests in http/tests/security/mixedContent start to fail when new tests are added
1519
1520         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1521
1522 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1523
1524         Reviewed by Jan Alonzo.
1525
1526         Create, and display a window for the inspector, for inspector
1527         tests.
1528
1529         Need to also show/hide the inspector window to avoid having
1530         problems with code assuming it is realized
1531         https://bugs.webkit.org/show_bug.cgi?id=31347
1532
1533         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1534         (webInspectorShowWindow):
1535         (webInspectorCloseWindow):
1536         (webInspectorInspectWebView):
1537         (createWebView):
1538
1539 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1540
1541         Unreviewed Qt buildbot fix.
1542
1543         My previous fix was wrong, so revert that change and fix it by
1544         returning when the document of the frame has no document element.
1545         Idea is borrowed from mac and win DRT.
1546
1547         * DumpRenderTree/qt/DumpRenderTree.cpp:
1548         (WebCore::DumpRenderTree::dumpFramesAsText):
1549
1550 2009-11-11  Eric Seidel  <eric@webkit.org>
1551
1552         Reviewed byg Kenneth Rohde Christiansen.
1553
1554         Update Kenneth's committer record to include the email he
1555         uses on lists.webkit.org.
1556
1557         * Scripts/modules/committers.py:
1558
1559 2009-11-11  Eric Seidel  <eric@webkit.org>
1560
1561         Reviewed by Gustavo Noronha Silva.
1562
1563         Several committers use separate email addresses for bugzilla and svn.webkit.org
1564         https://bugs.webkit.org/show_bug.cgi?id=31364
1565
1566         Update records for existing committers to include email addresses
1567         used in svn.webkit.org and lists.webkit.org.
1568         Most committers use the same email address in all 3 places, but some use
1569         separate addresses.  committers.py needs record of each of these addresses.
1570
1571         * Scripts/modules/committers.py:
1572
1573 2009-11-11  Eric Seidel  <eric@webkit.org>
1574
1575         No review, adding second email address for an existing committer.
1576
1577         Add Yong Li's second bugzilla account to his committer record.
1578         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1579
1580         * Scripts/modules/committers.py:
1581
1582 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1583
1584         Reviewed by Simon Hausmann.
1585
1586         If the frame has no innerText don't append it, and
1587         do not add a newline which breaks some cross platform
1588         results.
1589
1590         * DumpRenderTree/qt/DumpRenderTree.cpp:
1591         (WebCore::DumpRenderTree::dumpFramesAsText):
1592
1593 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1594
1595         Reviewed by Simon Hausmann.
1596
1597         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1598
1599         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1600         (webkit_test_plugin_new_instance):
1601         (webkit_test_plugin_destroy_instance):
1602         (webkit_test_plugin_destroy_stream):
1603
1604 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1605
1606         Reviewed by Mark Rowe.
1607
1608         Implement the functionality needed by plugins/window-open.html
1609
1610         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1611         (webkit_test_plugin_new_instance):
1612         (webkit_test_plugin_set_window):
1613
1614 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1615
1616         Reviewed by Simon Hausmann.
1617
1618         [Qt] Force -graphicssystem raster and -style windows when running DRT
1619
1620         * DumpRenderTree/qt/main.cpp:
1621         * Scripts/run-webkit-tests:
1622
1623 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1624
1625         Reviewed by Simon Hausmann.
1626
1627         Compute correct library paths for Qt
1628
1629         * Scripts/webkitdirs.pm:
1630
1631 2009-11-10  Mark Rowe  <mrowe@apple.com>
1632
1633         Reviewed by Sam Weinig.
1634
1635         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1636
1637         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1638         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1639         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1640         that had enabled frame load delegate logging this would result in extra log messages being generated,
1641         causing the test to fail.
1642
1643         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1644         tests.
1645
1646         * DumpRenderTree/mac/DumpRenderTree.mm:
1647         (dumpRenderTree):
1648         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1649         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1650
1651 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1652
1653         Reviewed by Kenneth Rohde Christiansen.
1654
1655         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1656
1657         * DumpRenderTree/qt/DumpRenderTree.cpp:
1658         (WebCore::DumpRenderTree::DumpRenderTree):
1659
1660 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1661
1662         Reviewed by Jan Alonzo.
1663
1664         [GTK] Remove WebSocket configuration from WebKitWebSettings
1665         https://bugs.webkit.org/show_bug.cgi?id=31244
1666
1667         Follow-up of r50724. Don't set the enable-web-socket property
1668         anymore.
1669
1670         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1671         (resetDefaultsToConsistentValues):
1672
1673 2009-11-10  Oliver Hunt  <oliver@apple.com>
1674
1675         Reviewed by Maciej Stachowiak.
1676
1677         Rename 3D Canvas related classes to use WebGL prefix
1678         https://bugs.webkit.org/show_bug.cgi?id=29095
1679
1680         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1681         and upate webkitdirs script to new method of testing for WebGL.
1682
1683         * Scripts/do-webcore-rename:
1684         * Scripts/webkitdirs.pm:
1685
1686 2009-11-09  Oliver Hunt  <oliver@apple.com>
1687
1688         Reviewed by Geoff Garen.
1689
1690         Make do-webcore-rename work with git.
1691
1692         * Scripts/do-webcore-rename:
1693
1694 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1695
1696         Adding Kenneth to the reviewers list.
1697
1698         * Scripts/modules/committers.py:
1699
1700 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1701
1702         Reviewed by Jan Alonzo.
1703
1704         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1705         https://bugs.webkit.org/show_bug.cgi?id=30482
1706
1707         LayoutTestControllerGtk now uses the exposed
1708         Page::tabKeyCyclesThroughElements API
1709
1710         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1711         (LayoutTestController::setTabKeyCyclesThroughElements):
1712
1713 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1714
1715         Reviewed by Holger Freyther.
1716
1717         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1718         This helps to pass the test case below. Also replaced hardcoded
1719         code numbers with defined constants.
1720         https://bugs.webkit.org/show_bug.cgi?id=31185
1721         
1722         Test: editing/undo/undo-deleteWord.html
1723
1724         * DumpRenderTree/qt/EventSenderQt.cpp:
1725         (EventSender::keyDown):
1726
1727 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1728
1729         Reviewed by Holger Freyther.
1730
1731         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1732         https://bugs.webkit.org/show_bug.cgi?id=31164
1733
1734         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1735
1736         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1737         (LayoutTestController::processWork):
1738
1739 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1740
1741         Reviewed by Holger Freyther.
1742
1743         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1744         https://bugs.webkit.org/show_bug.cgi?id=31158
1745
1746         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1747         always, which from WorkQueue prospective means that a load has been started
1748         and the queue processing should stop and wait for the load to finish.
1749         Spinning it off into a loading and a non-loading variants was the solution
1750         adopted by Mac's DRT to work around this problem. The former keeps returning
1751         'true' while the later executes the script synchronously and returns 'false'
1752         making it possible to the WorkQueue to proceed right away.
1753
1754         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1755         (LayoutTestController::processWork):
1756         (LayoutTestController::queueLoadingScript):
1757         (LayoutTestController::queueNonLoadingScript):
1758         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1759         * DumpRenderTree/qt/WorkQueueItem.h:
1760         (LoadingScriptItem::LoadingScriptItem):
1761         (LoadingScriptItem::invoke):
1762         (NonLoadingScriptItem::NonLoadingScriptItem):
1763         (NonLoadingScriptItem::invoke):
1764
1765 2009-11-07  Mark Rowe  <mrowe@apple.com>
1766
1767         Rubber-stamped by Cameron Zwarich.
1768
1769         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1770
1771         * Scripts/commit-log-editor:
1772
1773 2009-11-07  Mark Rowe  <mrowe@apple.com>
1774
1775         Reviewed by Darin Adler.
1776
1777         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1778         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1779
1780         Move logic for determining the name and email address to use in a ChangeLog entry from
1781         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1782         whether the author of the patch matches committer, and therefore needs access to the
1783         email address that would be used in a ChangeLog entry.
1784
1785         Based on a patch by Pierre d'Herbemont.
1786
1787         * Scripts/VCSUtils.pm:
1788         * Scripts/commit-log-editor:
1789         * Scripts/prepare-ChangeLog:
1790         * Scripts/webkitdirs.pm:
1791
1792 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1793
1794         Reviewed by Adam Barth.
1795
1796         Added functionality to the layout test plugin to invoke document.open and
1797         window.open with default arguments. The associated webkit bug is
1798         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1799         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1800         work in Chromium (V8) if there is no calling javascript context. To achieve this
1801         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1802         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1803
1804         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1805         (testDocumentOpen):
1806         (testWindowOpen):
1807         (pluginAllocate):
1808         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1809         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1810         (NPP_New):
1811         (NPP_SetWindow):
1812         (NPP_DestroyStream):
1813         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1814         (NPP_New):
1815         (NPP_SetWindow):
1816         (NPP_NewStream):
1817         (NPP_DestroyStream):
1818
1819 2009-11-06  Eric Seidel  <eric@webkit.org>
1820
1821         Reviewed by Adam Barth.
1822
1823         bugzilla-tool crashed with exception
1824         https://bugs.webkit.org/show_bug.cgi?id=31092
1825
1826         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1827
1828 2009-11-04  Eric Seidel  <eric@webkit.org>
1829
1830         No review, just add a line which got left out of the patch uploaded for commit.
1831
1832         commit-queue is crashing when trying to reject patches after unknown failures
1833         https://bugs.webkit.org/show_bug.cgi?id=31091
1834
1835         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1836
1837 2009-11-04  Adam Roben  <aroben@apple.com>
1838
1839         Remove bogus else clause in bugzilla-tool
1840
1841         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1842         create-bug raises exception after entering bug description
1843
1844         Reviewed by David Kilzer.
1845
1846         * Scripts/bugzilla-tool:
1847         (CreateBug): else clauses are only hit if no exception is raised, so
1848         it makes no sense to try to re-raise the exception in an else clause.
1849         The exception will automatically be re-raised if it doesn't match any
1850         of the except clauses, so we don't have to do anything special here at
1851         all to get the desired behavior.
1852
1853 2009-11-04  Eric Seidel  <eric@webkit.org>
1854
1855         Reviewed by David Kilzer.
1856
1857         svn-apply's fixChangeLogPatch function seems broken
1858         https://bugs.webkit.org/show_bug.cgi?id=30683
1859
1860         Update fixChangeLogPatch to be able to handle patches which
1861         don't start at line 1.
1862         Add unit tests for svn-apply to scm_unittest.py.
1863
1864         * Scripts/VCSUtils.pm:
1865         * Scripts/modules/scm_unittest.py:
1866
1867 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1868
1869         Reviewed by Beth Dakin.
1870
1871         Need to implement ARIA role="combobox"
1872         https://bugs.webkit.org/show_bug.cgi?id=31096
1873
1874         * DumpRenderTree/AccessibilityUIElement.cpp:
1875         (showMenuCallback):
1876         (getIsExpandedCallback):
1877         (AccessibilityUIElement::getJSClass):
1878         * DumpRenderTree/AccessibilityUIElement.h:
1879         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1880         (AccessibilityUIElement::isExpanded):
1881         (AccessibilityUIElement::showMenu):
1882         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1883         (AccessibilityUIElement::isExpanded):
1884         (AccessibilityUIElement::showMenu):
1885         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1886         (AccessibilityUIElement::isSelected):
1887         (AccessibilityUIElement::isExpanded):
1888         (AccessibilityUIElement::showMenu):
1889
1890 2009-11-04  Eric Seidel  <eric@webkit.org>
1891
1892         Reviewed by Adam Barth.
1893
1894         commit-queue is crashing when trying to reject patches after unknown failures
1895         https://bugs.webkit.org/show_bug.cgi?id=31091
1896
1897         * Scripts/bugzilla-tool:
1898          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1899            so we have to find out what the current patch is by asking bugzilla again.
1900          - Discovered that this code was also leaking file descriptors, so fixed that.
1901
1902 2009-11-04  Adam Roben  <aroben@apple.com>
1903
1904         Make run-webkit-tests work for the Debug_Internal Windows
1905         configuration
1906
1907         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1908         suffix.
1909
1910         Fixes <http://webkit.org/b/31123>.
1911
1912         Reviewed by Sam Weinig.
1913
1914         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1915         Debug_Internal, either.
1916
1917 2009-11-04  Eric Seidel  <eric@webkit.org>
1918
1919         Reviewed by Adam Barth.
1920
1921         committers.py needs a way to store non-bugzilla email addresses
1922         https://bugs.webkit.org/show_bug.cgi?id=31037
1923
1924         Make Committer and Reviewer constructors take a single email or a list of emails.
1925         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1926         Expose reviewers(), used by validate-committer-lists on bug 30970.
1927
1928         * Scripts/modules/committers.py:
1929         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1930
1931 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1932
1933         Reviewed by David Levin.
1934
1935         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1936         https://bugs.webkit.org/show_bug.cgi?id=27491
1937
1938         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1939         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1940
1941         Functions to start or stop Web Socket servers are added.
1942
1943         * Scripts/run-webkit-tests:
1944
1945 2009-11-03  Eric Seidel  <eric@webkit.org>
1946
1947         No review, just changing wording of log message.
1948
1949         Change log string to say "failed" instead of "rejected"
1950         when a commit fails due to an out of date checkout.
1951         This makes grepping the commit-queue log for rejected patches easier.
1952
1953         * Scripts/bugzilla-tool:
1954
1955 2009-11-03  Eric Seidel  <eric@webkit.org>
1956
1957         No review, adding commonly known committers missing from the file.
1958
1959         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1960
1961 2009-11-03  Eric Seidel  <eric@webkit.org>
1962
1963         No review, just sort-order cleanup.
1964
1965         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1966
1967 2009-11-03  Stephen White  <senorblanco@chromium.org>
1968
1969         (Unreviewed).
1970
1971         Add myself to committers.py.
1972
1973         * Scripts/modules/committers.py:
1974
1975 2009-11-03  Robin Dunn  <robin@alldunn.com>
1976
1977         Reviewed by Kevin Ollviier.
1978
1979         Add packaging scripts for Debian-based Linux distros.
1980         
1981         https://bugs.webkit.org/show_bug.cgi?id=31075
1982
1983         * wx/packaging/build-debian-installer.py: Added.
1984         * wx/packaging/debian: Added.
1985
1986 2009-11-03  Dan Bernstein  <mitz@apple.com>
1987
1988         Reviewed by Anders Carlsson and Beth Dakin.
1989
1990         https://bugs.webkit.org/show_bug.cgi?id=31070
1991
1992         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1993         destroyed, it executes the value of the 'ondestroy' parameter as a
1994         script.
1995
1996         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1997         (pluginAllocate): Initialize onDestroy.
1998         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1999         onDestroy.
2000         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2001         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2002         specified.
2003         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2004
2005 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2006
2007         Reviewed by Xan Lopez.
2008
2009         https://bugs.webkit.org/show_bug.cgi?id=31035
2010         [GTK] some accessibility tests hitting assertion in debug builds
2011
2012         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2013
2014         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2015         (AccessibilityController::rootElement):
2016
2017 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2018
2019         Reviewed by Beth Dakin.
2020
2021         Support ARIA "tab" roles
2022         https://bugs.webkit.org/show_bug.cgi?id=30842
2023
2024         * DumpRenderTree/AccessibilityUIElement.cpp:
2025         * DumpRenderTree/AccessibilityUIElement.h:
2026         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2027         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2028         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2029
2030 2009-11-01  Eric Seidel  <eric@webkit.org>
2031
2032         Reviewed by David Levin.
2033
2034         buildbots should use --exit-after-N-failures
2035         https://bugs.webkit.org/show_bug.cgi?id=30809
2036
2037         Make the bots exit after 20 failures to prevent never-ending
2038         test runs where every test spends a minute crashing.
2039
2040         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2041
2042 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2043
2044         Reviewed by Eric Seidel.
2045
2046         Turn on warnings for QtWebKit for gcc
2047         https://bugs.webkit.org/show_bug.cgi?id=30958
2048
2049         * DumpRenderTree/qt/main.cpp: 
2050         (crashHandler): Mark function NO_RETURN
2051
2052 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2053
2054         Adding myself to the committers list.
2055
2056         * Scripts/modules/committers.py:
2057
2058 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2059
2060         Fix an issue that Adam noticed in DRT.
2061
2062         Reviewed by Darin Adler.
2063
2064         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2065         (AccessibilityUIElement::role):
2066         Get the length of the role text, and create a buffer dynamically.
2067
2068 2009-10-30  Eric Seidel  <eric@webkit.org>
2069
2070         No review, rolling out r50105.
2071         http://trac.webkit.org/changeset/50105
2072
2073         This commit was causing:
2074         https://bugs.webkit.org/show_bug.cgi?id=30869
2075         We'll re-implement the feature a different way.
2076
2077         * Scripts/bugzilla-tool:
2078
2079 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2080
2081         Test for MSAA: Accessibility of headings is not correct
2082
2083         https://bugs.webkit.org/show_bug.cgi?id=30937
2084
2085         Reviewed by Adam Roben.
2086
2087         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2088         (AccessibilityUIElement::role):
2089         Allow the role returned to be a BSTR.
2090         (AccessibilityUIElement::description):
2091         Fix a copy/paste error.
2092
2093 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2094
2095         Test for MSAA: Accessibility of links is wrong
2096
2097         https://bugs.webkit.org/show_bug.cgi?id=30928
2098
2099         Reviewed by Darin Adler.
2100
2101         * DumpRenderTree/AccessibilityUIElement.cpp:
2102         (getAccessibilityValueCallback):
2103         Return the accessibility value.
2104         (AccessibilityUIElement::getJSClass):
2105         Added "accessibilityValue" value.
2106
2107         * DumpRenderTree/AccessibilityUIElement.h:
2108
2109         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2110         (AccessibilityUIElement::accessibilityValue):
2111         Stubbed.
2112
2113         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2114         (AccessibilityUIElement::accessibilityValue):
2115         Stubbed.
2116
2117         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2118         (AccessibilityUIElement::accessibilityValue):
2119         Get the object's value, and return it as a JS string.
2120
2121 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2122
2123         Fix typo in command name used by wx build system.
2124
2125         * wx/build/build_utils.py:
2126
2127 2009-10-30  Adam Barth  <abarth@webkit.org>
2128
2129         Reviewed by Darin Adler.
2130
2131         Patch v1 is a dumb default name for patches
2132         https://bugs.webkit.org/show_bug.cgi?id=30952
2133
2134         Let's use "Patch" instead.
2135
2136         * Scripts/bugzilla-tool:
2137
2138 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2139
2140         Unreviewed trivial buildfix.
2141
2142         [Qt] Buildfix for r50333.
2143
2144         * DumpRenderTree/qt/DumpRenderTree.pro:
2145
2146 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2147
2148         Reviewed by Holger Freyther.
2149
2150         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2151         https://bugs.webkit.org/show_bug.cgi?id=30953
2152
2153         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2154         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2155         makes qt DRT to share this implementation (as gtk and mac ports do).
2156
2157         * DumpRenderTree/qt/DumpRenderTree.pro:
2158         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2159         * DumpRenderTree/qt/WorkQueue.h: Removed.
2160
2161 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2162
2163         Unreviewed potential buildbot fix.
2164
2165         Second try: Reset page history before running each test.
2166
2167         Apparently the QWebHistory::clear() keeps the current page
2168         in history which is not what we want, so we not additionally
2169         sets the history capacity to 0 (forces removing everything)
2170         and then sets it back to its original value.
2171
2172         * DumpRenderTree/qt/DumpRenderTree.cpp:
2173         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2174
2175 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2176
2177         Unreviewed potential buildbot fix.
2178
2179         Reset page history before running each test.
2180
2181         * DumpRenderTree/qt/DumpRenderTree.cpp:
2182         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2183
2184 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2185
2186         Reviewed by Eric Seidel.
2187
2188         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2189
2190         Bug 28420 -  Implement HTML5 <ruby> rendering
2191         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2192
2193         No new tests (no functional change).
2194
2195         * Scripts/build-webkit:
2196
2197 2009-10-29  Dan Bernstein  <mitz@apple.com>
2198
2199         Reviewed by Mark Rowe.
2200
2201         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2202         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2203         define it.
2204
2205         * Scripts/VCSUtils.pm:
2206         * Scripts/svn-apply:
2207         * Scripts/svn-unapply:
2208
2209 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2210
2211         Reviewed by Gustavo Noronha.
2212
2213         Use the GTK+ main loop instead of rolling our own mini-version of
2214         it.
2215
2216         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2217         (dump):
2218         (runTest):
2219         (webViewLoadFinished):
2220
2221 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2222
2223         Reviewed by Oliver Hunt.
2224
2225         Implement the Qt version of DRT dumpBackForwardList().
2226
2227         * DumpRenderTree/qt/DumpRenderTree.cpp:
2228         (WebCore::dumpHistoryItem):
2229         (WebCore::DumpRenderTree::dumpBackForwardList):
2230
2231 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2232
2233         Reviewed by Adam Roben.
2234
2235         Implement DRT functionality for Qt introduced in
2236         r28690 and r28705.
2237
2238         - Implemented pathToLocalResource which exposes the functionality of
2239         converting a given unix path to the correct location on Windows.
2240         - Implemented a way to remove machine-dependent information from paths
2241         in layout test results.
2242
2243         * DumpRenderTree/qt/DumpRenderTree.cpp:
2244         (WebCore::urlSuitableForTestResult):
2245         (WebCore::WebPage::javaScriptConsoleMessage):
2246         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2247         (LayoutTestController::pathToLocalResource):
2248         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2249
2250 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2251
2252         Adding myself to the committers list.
2253
2254         * Scripts/modules/committers.py:
2255
2256 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2257
2258         Adding myself to the committers list.
2259
2260         * Scripts/modules/committers.py:
2261
2262 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2263
2264         Reviewed by Jan Alonzo.
2265
2266         [GTK] API to start inspector for a WebView
2267         https://bugs.webkit.org/show_bug.cgi?id=22551
2268
2269         Use the new inspector API to implement the LayoutTestController
2270         interfaces used to test the inspector.
2271
2272         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2273         (webInspectorInspectWebView):
2274         (createWebView):
2275         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2276         (LayoutTestController::showWebInspector):
2277         (LayoutTestController::closeWebInspector):
2278         (LayoutTestController::evaluateInWebInspector):
2279
2280 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2281
2282         Reviewed by Eric Seidel.
2283
2284         [Qt] WebFrame::counterValueForElementById must not be exposed
2285         https://bugs.webkit.org/show_bug.cgi?id=30882
2286
2287         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2288         (LayoutTestController::counterValueForElementById):
2289
2290 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2291
2292         Rubberstamped by Oliver Hunt.
2293
2294         Fix the warning:
2295
2296         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2297         declared with attribute warn_unused_result".
2298
2299         by actually checking the result. In the case it is null, an
2300         error has occoured, so treat it as the other fatal errors.
2301
2302         * DumpRenderTree/qt/DumpRenderTree.cpp:
2303         (WebCore::DumpRenderTree::initializeFonts):
2304
2305 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2306
2307         Reviewed by Darin Adler.
2308
2309         Provide a way to get counter values with layoutTestContoller
2310         https://bugs.webkit.org/show_bug.cgi?id=30555
2311
2312         Define layoutTestContoller.counterValueForElementById.
2313
2314         * DumpRenderTree/LayoutTestController.cpp:
2315         (counterValueForElementByIdCallback):
2316         (LayoutTestController::staticFunctions):
2317         * DumpRenderTree/LayoutTestController.h:
2318         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2319         (LayoutTestController::counterValueForElementById):
2320
2321 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2322
2323         Rubberstamped by Oliver Hunt.
2324
2325         Change two methods to be internal for DRT use only.
2326
2327         Part of [Qt] Review all new API in Qt 4.6
2328         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2329
2330         * DumpRenderTree/qt/DumpRenderTree.cpp:
2331         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2332         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2333         (LayoutTestController::whiteListAccessFromOrigin):
2334
2335 2009-10-27  Eric Seidel  <eric@webkit.org>
2336
2337         Reviewed by Adam Barth.
2338
2339         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2340         https://bugs.webkit.org/show_bug.cgi?id=30826
2341
2342         * Scripts/svn-apply:
2343          - Add () around all system() calls.
2344          - Use the correct system() == 0 or die instead of system() or die
2345          - Add descriptive messages to all die statements.
2346
2347 2009-10-27  Steve Block  <steveblock@google.com>
2348
2349         Reviewed by NOBODY.
2350
2351         Adds steveblock@google.com to list of committers.
2352
2353         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2354
2355 2009-10-27  Eric Seidel  <eric@webkit.org>
2356
2357         Reviewed by Adam Barth.
2358
2359         svn-apply can exit(0) even on patch failure
2360         https://bugs.webkit.org/show_bug.cgi?id=29622
2361
2362         * Scripts/svn-apply:
2363          - Add a bunch of "or die" statements, hopefully catching all
2364            possible cases where failure could still exit(0).
2365
2366 2009-10-27  Eric Seidel  <eric@webkit.org>
2367
2368         Reviewed by Adam Barth.
2369
2370         svn-* scripts should share code through VCSUtils.pm
2371         https://bugs.webkit.org/show_bug.cgi?id=30791
2372
2373         Just moving code into a shared location.
2374
2375         * Scripts/VCSUtils.pm:
2376         * Scripts/prepare-ChangeLog:
2377         * Scripts/resolve-ChangeLogs:
2378         * Scripts/svn-apply:
2379         * Scripts/svn-create-patch:
2380         * Scripts/svn-unapply:
2381         * Scripts/update-webkit:
2382
2383 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2384
2385         Suppress a huge number of MSVC warnings when building wxWebKit.
2386
2387         * wx/build/settings.py:
2388
2389 2009-10-26  Eric Seidel  <eric@webkit.org>
2390
2391         No review, just adding Mike Belshe to the committers list.
2392
2393         * Scripts/modules/committers.py:
2394
2395 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2396
2397         Reviewed by Darin Adler.
2398
2399         Make .rc files compile on Windows without depending on MFC headers
2400         https://bugs.webkit.org/show_bug.cgi?id=30750
2401
2402         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2403         windows.h instead of afxres.h because it exists even when MFC is not 
2404         installed, and is all that's needed here.
2405
2406         * FindSafari/FindSafari.rc: Ditto
2407
2408 2009-10-24  Eric Seidel  <eric@webkit.org>
2409
2410         Reviewed by Adam Barth.
2411
2412         bugzilla-tool post-diff should know how to mark commit-queue=?
2413         https://bugs.webkit.org/show_bug.cgi?id=29202
2414
2415         * Scripts/bugzilla-tool:
2416          - Add --commit-queue option to post-diff, post-commits and create-bug.
2417         * Scripts/modules/bugzilla.py:
2418          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2419          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2420
2421 2009-10-23  Eric Seidel  <eric@webkit.org>
2422
2423         Reviewed by Adam Barth.
2424
2425         bugzilla-tool commit-queue does not notice modifications to committers.py
2426         https://bugs.webkit.org/show_bug.cgi?id=30084
2427
2428         * Scripts/bugzilla-tool:
2429          - Make commit-queue re-exec itself instead of using while(1).
2430          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2431          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2432
2433 2009-10-22  Eric Seidel  <eric@webkit.org>
2434
2435         Reviewed by Adam Barth.
2436
2437         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2438         https://bugs.webkit.org/show_bug.cgi?id=30634
2439
2440         * Scripts/bugzilla-tool:
2441          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2442          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2443
2444 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2445
2446         Reviewed by Eric Seidel.
2447
2448         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2449
2450         https://bugs.webkit.org/show_bug.cgi?id=30763
2451
2452         * pywebsocket/mod_pywebsocket/__init__.py:
2453         * pywebsocket/mod_pywebsocket/dispatch.py:
2454         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2455         * pywebsocket/mod_pywebsocket/standalone.py:
2456         * pywebsocket/setup.py:
2457         * pywebsocket/test/test_dispatch.py:
2458
2459 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2460
2461         Reviewed by David Levin.
2462
2463         REGRESSION: 2 failures in run-webkit-unittests
2464         https://bugs.webkit.org/show_bug.cgi?id=30645
2465
2466         * Scripts/modules/cpp_style_unittest.py:
2467         Fixed a few test scenarios which apparently lost some spaces from 
2468         text literals.
2469
2470 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2471
2472         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2473
2474         * Scripts/webkitdirs.pm:
2475
2476 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2477
2478         Reviewed by Darin Adler.
2479
2480         Unification of using null device in perl scripts.
2481         https://bugs.webkit.org/show_bug.cgi?id=30572
2482
2483         * Scripts/VCSUtils.pm:
2484         * Scripts/bisect-builds:
2485         * Scripts/resolve-ChangeLogs:
2486         * Scripts/run-iexploder-tests:
2487         * Scripts/run-jsc:
2488         * Scripts/run-mangleme-tests:
2489         * Scripts/run-webkit-tests:
2490         * Scripts/webkitdirs.pm:
2491         Using File::Spec->devnull() instead of hard coded /dev/null.
2492
2493 2009-10-26  Eric Seidel  <eric@webkit.org>
2494
2495         Reviewed by Holger Freyther.
2496
2497         Reviewers are missing from committers.py
2498         https://bugs.webkit.org/show_bug.cgi?id=30733
2499
2500         * Scripts/modules/committers.py:
2501
2502 2009-10-23  Eric Seidel  <eric@webkit.org>
2503
2504         No review, only adding Alice to the list of reviewers.
2505
2506         * Scripts/modules/committers.py:
2507
2508 2009-10-23  Eric Seidel  <eric@webkit.org>
2509
2510         Reviewed by Eric Carlson.
2511
2512         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2513         https://bugs.webkit.org/show_bug.cgi?id=30700
2514
2515         * DumpRenderTree/mac/DumpRenderTree.mm:
2516         (resetDefaultsToConsistentValues): Update QuickTime version check.
2517
2518 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2519
2520         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2521         character measurement APIs that are private on Tiger.
2522
2523         * wx/build/settings.py:
2524
2525 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2526
2527         Reviewed by NOBODY (build fix).
2528         Build fix following bug #30696.
2529
2530         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2531         (LayoutTestController::evaluateScriptInIsolatedWorld):
2532
2533 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2534
2535         Reviewed by Sam Weinig & Geoff Garen.
2536
2537         https://bugs.webkit.org/show_bug.cgi?id=30696
2538         Enable isolated-worlds tests on mac.
2539
2540         Add private interface for DRT to invoke execution in a given world.
2541
2542         * DumpRenderTree/LayoutTestController.cpp:
2543         (evaluateScriptInIsolatedWorldCallback):
2544         (LayoutTestController::staticFunctions):
2545         * DumpRenderTree/LayoutTestController.h:
2546         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2547         (LayoutTestController::evaluateScriptInIsolatedWorld):
2548         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2549         (LayoutTestController::evaluateScriptInIsolatedWorld):
2550
2551 2009-10-21  Eric Seidel  <eric@webkit.org>
2552
2553         Reviewed by Adam Barth.
2554
2555         bugzilla-tool's "patch failed to download an apply" error should give more information
2556         https://bugs.webkit.org/show_bug.cgi?id=30632
2557
2558         * Scripts/modules/scm.py:
2559          - Use the common run_command method instead of custom POpen code.
2560          - Make run_command know how to take pipes as input.
2561         * Scripts/modules/scm_unittest.py:
2562          - Add new tests to cover change.
2563          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2564
2565 2009-10-21  Kent Tamura  <tkent@chromium.org>
2566
2567         Unreviewed.  Adding myself to the committers list.
2568
2569         * Scripts/modules/committers.py:
2570
2571 2009-10-21  Robin Dunn  <robin@alldunn.com>
2572
2573         Reviewed by Kevin Ollivier.
2574
2575         Update the Windows installer builder to work with Vista / Win 7 and with git.
2576         
2577         https://bugs.webkit.org/show_bug.cgi?id=30649
2578
2579         * wx/build/build_utils.py:
2580         * wx/packaging/build-mac-installer.py:
2581         * wx/packaging/build-win-installer.py:
2582         * wx/packaging/wxWebKitInstaller.iss.in:
2583
2584 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2585
2586         Reviewed by Gustavo Noronha.
2587
2588         [GTK] Added conditional code to avoid using
2589         gdk_window_get_root_coords if we do not have a gtk+ release newer
2590         than 2.17.3.
2591         https://bugs.webkit.org/show_bug.cgi?id=30636
2592
2593         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2594
2595 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2596
2597         Reviewed by Eric Seidel.
2598
2599         [Qt] Added dummy implementation for keepWebHistory()
2600         https://bugs.webkit.org/show_bug.cgi?id=30592
2601
2602         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2603         (LayoutTestController::keepWebHistory):
2604         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2605
2606 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2607
2608         Reviewed by Xan Lopez.
2609
2610         [GTK] Fixed the double click condition, it is not double click if
2611         we move in just in one direction.
2612         https://bugs.webkit.org/show_bug.cgi?id=30636
2613
2614         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2615
2616 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2617
2618         Reviewed by Xan Lopez.
2619
2620         [GTK] Initialize the events completly before emitting them.
2621         https://bugs.webkit.org/show_bug.cgi?id=30633
2622
2623         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2624
2625 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2626
2627         wx build fix. Fix for when linking using --as-needed with gcc.
2628
2629         * wx/browser/wscript:
2630
2631 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2632
2633         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2634         to support all the features used by CURL backend.
2635         
2636         * wx/build/settings.py:
2637         * wx/install-unix-extras:
2638
2639 2009-10-20  Anton Muhin  <antonm@chromium.org>
2640
2641         Reviewed by Adam Barth.
2642
2643         Add {ager,antonm,yurys}@chromium.org into committers.py
2644         https://bugs.webkit.org/show_bug.cgi?id=30560
2645
2646         * Scripts/modules/committers.py:
2647
2648 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2649
2650         Reviewed by Tor Arne Vestbø.
2651
2652         Make the Netscape Test plugin available to the Qt launcher.
2653
2654         * Scripts/run-launcher:
2655
2656 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2657
2658         Reviewed by David Levin.
2659
2660         Removed WebSocket runtime settings.
2661         https://bugs.webkit.org/show_bug.cgi?id=29896
2662
2663         WebSocket runtime configuration is supported by chromium/v8 only.
2664
2665         * DumpRenderTree/mac/DumpRenderTree.mm:
2666         (resetDefaultsToConsistentValues):
2667         * DumpRenderTree/win/DumpRenderTree.cpp:
2668         (resetDefaultsToConsistentValues):
2669
2670 2009-10-19  Nate Chapin  <japhet@chromium.org>
2671
2672         Reviewed by Adam Barth.
2673
2674         Add testFail() to test plugin so we can test our handling of a
2675         plugin invoke call returning false.
2676
2677         https://bugs.webkit.org/show_bug.cgi?id=30239
2678
2679         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2680         (pluginInvoke):
2681         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2682
2683 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2684
2685         Reviewed by Gustavo Noronha.
2686
2687         Enable DOM pasting when running layout tests.
2688
2689         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2690         (resetDefaultsToConsistentValues):
2691
2692 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2693
2694         Reviewed by Simon Hausmann.
2695
2696         Use the setPreferredContentsSize method instead
2697         of setFixedContentsSize, as the method has been renamed.
2698
2699         * DumpRenderTree/qt/DumpRenderTree.cpp:
2700         (WebCore::DumpRenderTree::open):
2701         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2702         (LayoutTestController::setFixedContentsSize):
2703
2704 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2705
2706         Reviewed by Dan Bernstein.
2707
2708         https://bugs.webkit.org/show_bug.cgi?id=30456
2709         Fixes for new Debug_All Windows build configuration.
2710
2711         * DumpRenderTree/win/DumpRenderTree.cpp:
2712         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2713         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2714
2715 2009-10-16  Eric Seidel  <eric@webkit.org>
2716
2717         Reviewed by Adam Barth.
2718
2719         commit-queue status bot should list which buildbot is blocking the queue
2720         https://bugs.webkit.org/show_bug.cgi?id=30452
2721
2722         Add new methods and testing.
2723
2724         * Scripts/bugzilla-tool:
2725         * Scripts/modules/buildbot.py:
2726         * Scripts/modules/buildbot_unittest.py:
2727
2728 2009-10-16  Eric Seidel  <eric@webkit.org>
2729
2730         Reviewed by Adam Barth.
2731
2732         run-webkit-tests fails when CWD is not inside a WebKit checkout
2733         https://bugs.webkit.org/show_bug.cgi?id=30451
2734
2735         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2736         * Scripts/modules/scm_unittest.py:
2737           - Remove use of original_path (we don't need to restore the CWD).
2738           - Don't use '.' to find the webkit checkout, use __file__ instead.
2739
2740 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2741
2742         Reviewed by Adam Roben.
2743
2744         Add a Debug_All configuration to build entire stack as debug.
2745         Change Debug_Internal to:
2746         - stop using _debug suffix for all WebKit/Safari binaries
2747         - not use _debug as a DLL naming suffix
2748         - use non-debug C runtime lib.
2749
2750         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2751         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2752         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2753         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2754         Add missing debug.vsprops inherited property sheet.
2755         Add Debug_All configuration.
2756         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2757         * WinLauncher/WinLauncher.vcproj:
2758         Removed extraneous definitions inherited from vsprops.
2759         Add Debug_All configuration.
2760
2761 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2762
2763         Reviewed by David Levin.
2764
2765         check-webkit-style is wrong about indent checking in namespaces
2766         in header files and a few other things
2767         https://bugs.webkit.org/show_bug.cgi?id=30362
2768
2769         The few other things include:
2770         + check-webkit-style does not require spaces around the equal sign
2771           inside 'if' statements and around binary operators that take 
2772           numeric literals.
2773         + check-webkit-style reports false errors for the / operator
2774           when part of a filename in the #include directive.
2775
2776         * Scripts/modules/cpp_style.py:
2777         Improved indentation checking and space checking around
2778         binary operators. While the checks are still not perfect,
2779         they are clearly better than before.
2780         * Scripts/modules/cpp_style_unittest.py:
2781         Added test cases for the newly supported checks and modified old
2782         test cases to match the new guidelines
2783
2784 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2785
2786         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2787
2788         * wx/build/settings.py:
2789
2790 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2791
2792         Reviewed by David Levin.
2793
2794         Add mod_pywebsocket to test Web Sockets.
2795         http://code.google.com/p/pywebsocket/
2796         https://bugs.webkit.org/show_bug.cgi?id=27490
2797
2798         * pywebsocket/COPYING: Added.
2799         * pywebsocket/MANIFEST.in: Added.
2800         * pywebsocket/README: Added.
2801         * pywebsocket/example/echo_client.py: Added.
2802         * pywebsocket/example/echo_wsh.py: Added.
2803         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2804         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2805         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2806         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2807         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2808         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2809         * pywebsocket/mod_pywebsocket/util.py: Added.
2810         * pywebsocket/setup.py: Added.
2811         * pywebsocket/test/config.py: Added.
2812         * pywebsocket/test/mock.py: Added.
2813         * pywebsocket/test/run_all.py: Added.
2814         * pywebsocket/test/test_dispatch.py: Added.
2815         * pywebsocket/test/test_handshake.py: Added.
2816         * pywebsocket/test/test_mock.py: Added.
2817         * pywebsocket/test/test_msgutil.py: Added.
2818         * pywebsocket/test/test_util.py: Added.
2819         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2820         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2821         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2822         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2823         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2824         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2825         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2826         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2827
2828 2009-10-15  James Robinson  <jamesr@google.com>
2829
2830         Reviewed by David Levin.
2831
2832         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2833
2834         https://bugs.webkit.org/show_bug.cgi?id=30426
2835
2836         * Scripts/modules/cpp_style.py:
2837         * Scripts/modules/cpp_style_unittest.py:
2838
2839 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2840
2841         Reviewed by Adam Roben.
2842
2843         Fixes <http://webkit.org/b/30411>.
2844         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2845         
2846         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2847         building Chromium.
2848
2849         * Scripts/pdevenv:
2850
2851 2009-10-15  Robin Dunn  <robin@alldunn.com>
2852
2853         Reviewed by Kevin Ollivier.
2854
2855         Add Mac package building scripts for wx.
2856         
2857         https://bugs.webkit.org/show_bug.cgi?id=30405
2858
2859         * wx/build/build_utils.py:
2860         * wx/build/settings.py:
2861         * wx/packaging/build-mac-installer.py: Added.
2862
2863 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2864
2865         Reviewed by Gustavo Noronha.
2866
2867         Enable Web Sockets support when running layout tests.
2868
2869         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2870         (resetDefaultsToConsistentValues):
2871
2872 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2873
2874         Reviewed by Gustavo Noronha.
2875
2876         Need to initialize event.button.button, since in most cases a
2877         button number is not passed as an argument.
2878
2879         * DumpRenderTree/gtk/EventSender.cpp:
2880         (mouseDownCallback):
2881         (mouseUpCallback):
2882
2883 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2884
2885         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2886         the OS if none was explicitly set.
2887
2888         * wx/build/settings.py:
2889
2890 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2891
2892         Reviewed by Timothy Hatcher.
2893
2894         Web Inspector: enable developers extras within inspector layout tests.
2895
2896         https://bugs.webkit.org/show_bug.cgi?id=30014
2897
2898         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2899         (LayoutTestController::showWebInspector):
2900         (LayoutTestController::closeWebInspector):
2901         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2902         (LayoutTestController::showWebInspector):
2903         (LayoutTestController::closeWebInspector):
2904
2905 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2906
2907         Reviewed by Jan Alonzo.
2908
2909         GtkLauncher is using a deprecated signal
2910         https://bugs.webkit.org/show_bug.cgi?id=30364
2911
2912         Modified GtkLauncher to use notify::title signal instead of
2913         deprecated title-changed signal
2914
2915         * GtkLauncher/main.c:
2916         (notify_title_cb):
2917         (create_browser):
2918
2919 2009-10-14  Brady Eidson  <beidson@apple.com>
2920
2921         Reviewed by Sam Weinig.
2922
2923         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2924         1 - Disables WebHistory
2925         2 - Doesn't make sense in that context anyway.
2926
2927         * DumpRenderTree/win/DumpRenderTree.cpp:
2928         (createWebViewAndOffscreenWindow):
2929
2930 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2931
2932         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2933         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2934
2935         * wx/build/settings.py:
2936         * wx/install-unix-extras:
2937
2938 2009-10-14  Brady Eidson  <beidson@apple.com>
2939
2940         Reviewed by Sam Weinig.
2941
2942         WebKit Win API should provide a delegate interface for global history.
2943         https://bugs.webkit.org/show_bug.cgi?id=29905
2944
2945         * DumpRenderTree/LayoutTestController.cpp:
2946         (LayoutTestController::LayoutTestController):
2947         * DumpRenderTree/LayoutTestController.h:
2948         (LayoutTestController::dumpHistoryDelegateCallbacks):
2949         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2950                 
2951         * DumpRenderTree/win/DumpRenderTree.cpp:
2952         (shouldLogHistoryDelegates):
2953         (runTest):
2954         (createWebViewAndOffscreenWindow):
2955         (main):
2956         * DumpRenderTree/win/DumpRenderTree.vcproj:
2957         
2958         Add the IWebHistoryDelegate to DRT Windows:
2959         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2960         (wstringFromBSTR):
2961         (HistoryDelegate::HistoryDelegate):
2962         (HistoryDelegate::~HistoryDelegate):
2963         (HistoryDelegate::QueryInterface):
2964         (HistoryDelegate::AddRef):
2965         (HistoryDelegate::Release):
2966         (HistoryDelegate::didNavigateWithNavigationData):
2967         (HistoryDelegate::didPerformClientRedirectFromURL):
2968         (HistoryDelegate::didPerformServerRedirectFromURL):
2969         (HistoryDelegate::updateHistoryTitle):
2970         (HistoryDelegate::populateVisitedLinksForWebView):
2971         * DumpRenderTree/win/HistoryDelegate.h: Added.
2972
2973         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2974         (LayoutTestController::removeAllVisitedLinks):
2975
2976 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2977
2978         Reviewed by Simon Hausmann.
2979
2980         [Qt] Implement support for setPOSIXLocale on Qt.
2981         https://bugs.webkit.org/show_bug.cgi?id=30268 
2982  
2983         * DumpRenderTree/qt/DumpRenderTree.cpp:
2984         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2985         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2986         (LayoutTestController::setPOSIXLocale):
2987         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2988
2989 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2990
2991         Unreviewed, adding myself to reviewers list.
2992
2993         * Scripts/modules/committers.py:
2994
2995 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2996
2997         Reviewed by Mark Rowe.
2998
2999         Fix null assignment so root tests work again.
3000
3001         * Scripts/webkitdirs.pm:
3002
3003 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3004
3005         Reviewed by Simon Hausmann.
3006
3007         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3008         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3009         This is done in preparation of implementing missing features in DRT.
3010         No functionality changes made yet.
3011
3012         * DumpRenderTree/qt/DumpRenderTree.cpp:
3013         * DumpRenderTree/qt/DumpRenderTree.pro:
3014         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3015         (EventSender::EventSender):
3016         (EventSender::mouseDown):
3017         (EventSender::mouseUp):
3018         (EventSender::mouseMoveTo):
3019         (EventSender::leapForward):
3020         (EventSender::keyDown):
3021         (EventSender::contextClick):
3022         (EventSender::scheduleAsynchronousClick):
3023         (EventSender::frameUnderMouse):
3024         * DumpRenderTree/qt/EventSenderQt.h: Added.
3025         (EventSender::clearKillRing):
3026         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3027         (LayoutTestController::LayoutTestController):
3028         (LayoutTestController::reset):
3029         (LayoutTestController::processWork):
3030         (LayoutTestController::maybeDump):
3031         (LayoutTestController::waitUntilDone):
3032         (LayoutTestController::notifyDone):
3033         (LayoutTestController::windowCount):
3034         (LayoutTestController::clearBackForwardList):
3035         (LayoutTestController::dumpEditingCallbacks):
3036         (LayoutTestController::dumpResourceLoadCallbacks):
3037         (LayoutTestController::queueBackNavigation):
3038         (LayoutTestController::queueForwardNavigation):
3039         (LayoutTestController::queueLoad):
3040         (LayoutTestController::queueReload):
3041         (LayoutTestController::queueScript):
3042         (LayoutTestController::provisionalLoad):
3043         (LayoutTestController::timerEvent):
3044         (LayoutTestController::encodeHostName):
3045         (LayoutTestController::decodeHostName):
3046         (LayoutTestController::setJavaScriptProfilingEnabled):
3047         (LayoutTestController::setFixedContentsSize):
3048         (LayoutTestController::setPrivateBrowsingEnabled):
3049         (LayoutTestController::setPopupBlockingEnabled):
3050         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3051         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3052         (LayoutTestController::numberOfActiveAnimations):
3053         (LayoutTestController::disableImageLoading):
3054         (LayoutTestController::dispatchPendingLoadRequests):
3055         (LayoutTestController::setDatabaseQuota):
3056         (LayoutTestController::clearAllDatabases):
3057         (LayoutTestController::whiteListAccessFromOrigin):
3058         (LayoutTestController::waitForPolicyDelegate):
3059         (LayoutTestController::overridePreference):
3060         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3061         (LayoutTestController::isLoading):
3062         (LayoutTestController::setLoading):
3063         (LayoutTestController::shouldDumpAsText):
3064         (LayoutTestController::shouldDumpBackForwardList):
3065         (LayoutTestController::shouldDumpChildrenAsText):
3066         (LayoutTestController::shouldDumpDatabaseCallbacks):
3067         (LayoutTestController::shouldDumpStatusCallbacks):
3068         (LayoutTestController::shouldWaitUntilDone):
3069         (LayoutTestController::canOpenWindows):
3070         (LayoutTestController::shouldDumpTitleChanges):
3071         (LayoutTestController::waitForPolicy):
3072         (LayoutTestController::dumpAsText):
3073         (LayoutTestController::dumpChildFramesAsText):
3074         (LayoutTestController::dumpDatabaseCallbacks):
3075         (LayoutTestController::dumpStatusCallbacks):
3076         (LayoutTestController::setCanOpenWindows):
3077         (LayoutTestController::dumpBackForwardList):
3078         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3079         (LayoutTestController::display):
3080         (LayoutTestController::dumpTitleChanges):
3081         (LayoutTestController::dumpSelectionRect):
3082         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3083         (TextInputController::TextInputController):
3084         (TextInputController::doCommand):
3085         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3086         * DumpRenderTree/qt/WorkQueue.cpp:
3087         * DumpRenderTree/qt/WorkQueue.h:
3088         * DumpRenderTree/qt/WorkQueueItem.h:
3089         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3090         (findFrameNamed):
3091         (LoadItem::invoke):
3092         (ReloadItem::invoke):
3093         (ScriptItem::invoke):
3094         (BackForwardItem::invoke):
3095         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3096         * DumpRenderTree/qt/jsobjects.h:
3097
3098 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3099
3100         Not reviewed, adding myself to the list of reviewers.
3101
3102         * Scripts/modules/committers.py:
3103
3104 2009-10-13  Anders Carlsson  <andersca@apple.com>
3105
3106         Reviewed by Sam Weinig.
3107
3108         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3109
3110         Make the private browsing mode testable by the test plug-in.
3111         
3112         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3113         (pluginGetProperty):
3114         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3115         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3116         (NPP_New):
3117         (NPP_SetValue):
3118
3119 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3120
3121         No review, just adding self to the list of reviewers.
3122
3123         * Scripts/modules/committers.py:
3124
3125 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3126
3127         Reviewed by Adam Roben.
3128
3129         Web Inspector: Use proper web view in inspector layout
3130         tests for windows.
3131
3132         https://bugs.webkit.org/show_bug.cgi?id=30298
3133
3134         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3135         (LayoutTestController::showWebInspector):
3136         (LayoutTestController::closeWebInspector):
3137         (LayoutTestController::evaluateInWebInspector):
3138
3139 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3140
3141         Reviewed by Sam Weinig.
3142
3143         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3144         https://bugs.webkit.org/show_bug.cgi?id=29841
3145
3146         * DumpRenderTree/mac/DumpRenderTree.mm:
3147         (resetDefaultsToConsistentValues):
3148         * DumpRenderTree/win/DumpRenderTree.cpp:
3149         (resetDefaultsToConsistentValues):
3150
3151 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3152
3153         Reviewed by Dimitri Glazkov.
3154
3155         Chromium Port - Windows
3156         https://bugs.webkit.org/show_bug.cgi?id=29969
3157
3158         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3159         * Scripts/webkitdirs.pm:
3160
3161 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3162
3163         Reviewed by Darin Adler.
3164
3165         jsc scripts cleanup and Qt/GTK fix
3166         https://bugs.webkit.org/show_bug.cgi?id=30288
3167
3168         Duplicated jscPath() moved to webkitdirs.pm.
3169         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3170         Configuration added (release/debug) to path for Qt-port on Windows.
3171
3172         * Scripts/run-javascriptcore-tests:
3173         * Scripts/run-jsc:
3174         * Scripts/run-sunspider:
3175         * Scripts/sunspider-compare-results:
3176         * Scripts/webkitdirs.pm:
3177
3178 2009-10-11  Adam Barth  <abarth@webkit.org>
3179
3180         Unreviewed.  Add Collin to committers.py.
3181
3182         * Scripts/modules/committers.py:
3183
3184 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3185
3186         wx build fix, add bindings to source/include dirs now that there are sources there.
3187
3188         * wx/build/settings.py:
3189
3190 2009-10-09  Mark Rowe  <mrowe@apple.com>
3191
3192         Reviewed by Brady Eidson.
3193
3194         Enable plug-in halting in DumpRenderTree.
3195
3196         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3197         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3198
3199         * DumpRenderTree/mac/DumpRenderTree.mm:
3200         (resetDefaultsToConsistentValues):
3201         * DumpRenderTree/mac/UIDelegate.mm:
3202         (-[UIDelegate webView:shouldHaltPlugin:]):
3203
3204 2009-10-08  Brady Eidson  <beidson@apple.com>
3205
3206         Reviewed by Dan Bernstein.
3207
3208         Ask the History Delegate to populate the visited links hash.
3209         <rdar://problem/7285293> and https://webkit.org/b/29904
3210
3211         Add the ability for LayoutTestController to clear all visited links.
3212         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3213
3214         * DumpRenderTree/LayoutTestController.cpp:
3215         (LayoutTestController::LayoutTestController):
3216         (removeAllVisitedLinksCallback):
3217         (LayoutTestController::staticFunctions):
3218         * DumpRenderTree/LayoutTestController.h:
3219         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3220         (LayoutTestController::removeAllVisitedLinks):
3221
3222         * DumpRenderTree/mac/HistoryDelegate.mm:
3223         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3224
3225         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3226         (LayoutTestController::removeAllVisitedLinks):
3227         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3228         (LayoutTestController::removeAllVisitedLinks):
3229         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3230         (LayoutTestController::removeAllVisitedLinks):
3231
3232
3233 2009-10-08  Daniel Bates  <dbates@webkit.org>
3234
3235         Reviewed by Adam Roben.
3236
3237         https://bugs.webkit.org/show_bug.cgi?id=30175
3238         
3239         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3240         the OLE drag-and-drop return value like the function it emulates. Currently, 
3241         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3242         whether the drag-and-drop operation was successful or was cancelled.
3243         
3244         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3245         return value according to whether the drop operation was successful or not.
3246
3247         * DumpRenderTree/win/EventSender.cpp:
3248         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3249         (replaySavedEvents): Ditto.
3250         * DumpRenderTree/win/EventSender.h:
3251         * DumpRenderTree/win/UIDelegate.cpp:
3252         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3253
3254 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3255
3256         Reviewed by Xan Lopez.
3257
3258         [GTK] Added support for a parameter setting the button that was
3259         pressed in the mouseDown function.
3260         https://bugs.webkit.org/show_bug.cgi?id=30220
3261
3262         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3263
3264 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3265
3266         Reviewed by Xan Lopez.
3267
3268         [GTK] Added a line to the bottom of the expected result to match
3269         the output of the test.
3270         https://bugs.webkit.org/show_bug.cgi?id=30220
3271
3272         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3273         expected.txt:
3274
3275 2009-10-08  Adam Roben  <aroben@apple.com>
3276
3277         Use QueryInterface to get IWebInspectorPrivate
3278
3279         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3280         accessed in a more standard way
3281
3282         Reviewed by John Sullivan and Tim Hatcher.
3283
3284         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3285         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3286         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3287         to the IWebInspectorPrivate interface.
3288
3289 2009-10-07  Adam Roben  <aroben@apple.com>
3290
3291         Implement DRT support for origin whitelisting
3292
3293         Fixes <http://webkit.org/b/30185>.
3294
3295         Reviewed by Eric Seidel.
3296
3297         * DumpRenderTree/win/DumpRenderTree.cpp:
3298         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3299         whitelist, to match Mac DRT.
3300         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3301         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3302         IWebViewPrivate::whiteListAccessFromOrigin.
3303
3304 2009-10-07  Brady Eidson  <beidson@apple.com>
3305
3306         Reviewed by Darin Adler.
3307
3308         Send title changes to the global history delegate.
3309         <rdar://problem/7285293> and https://webkit.org/b/29904
3310
3311         * DumpRenderTree/mac/HistoryDelegate.mm:
3312         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3313
3314 2009-10-07  Adam Barth  <abarth@webkit.org>
3315
3316         Unreviewed.  Remove some folks from committers.py who were listed on
3317         the WebKit Team wiki page but who weren't actually listed as commit+.
3318         At some point, we should coorelate this list with the committers
3319         mailing list.
3320
3321         * Scripts/modules/committers.py:
3322
3323 2009-10-07  Adam Barth  <abarth@webkit.org>
3324
3325         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3326         the wiki into committers.py.
3327
3328         * Scripts/modules/committers.py:
3329
3330 2009-10-07  Adam Barth  <abarth@webkit.org>
3331
3332         Unreviewed.  Added Aaron Boodman to committers.py.
3333
3334         * Scripts/modules/committers.py:
3335
3336 2009-10-07  Evan Martin  <evan@chromium.org>
3337
3338         Reviewed by Darin Adler.
3339
3340         Add API to LayoutTestController for re/setting the system locale.
3341         https://bugs.webkit.org/show_bug.cgi?id=18994
3342
3343         * DumpRenderTree/LayoutTestController.cpp:
3344         (setLocaleCallback):
3345         (LayoutTestController::staticFunctions):
3346         (LayoutTestController::setLocale):
3347         * DumpRenderTree/LayoutTestController.h:
3348
3349 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3350
3351         Reviewed by Jan Alonzo.
3352
3353         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3354         https://bugs.webkit.org/show_bug.cgi?id=29689
3355
3356         Build fix by adding -lfontconfig for DumpRenderTree.
3357
3358         * GNUmakefile.am:
3359
3360 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3361
3362         Reviewed by Simon Hausmann.
3363
3364         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3365
3366         * Scripts/run-webkit-tests:
3367
3368 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3369
3370         Reviewed by Gustavo Noronha.
3371
3372         "delete" in EventSender is the backspace key, not the delete one.
3373
3374         * DumpRenderTree/gtk/EventSender.cpp:
3375         (keyDownCallback):
3376
3377 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3378
3379         Reviewed by Gustavo Noronha.
3380
3381         getChildrenWithRange expects as last parameter the end index, not
3382         the length of the range. Correct this and clarify the variable
3383         names to reflect how the code works.
3384
3385         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3386         (AccessibilityUIElement::getChildrenWithRange):
3387         (AccessibilityUIElement::getChildAtIndex):
3388
3389 2009-10-06  Mark Rowe  <mrowe@apple.com>
3390
3391         Reviewed by Simon Fraser.
3392
3393         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3394
3395         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3396         the fact we have already changed the working directory to the top of the open source tree.
3397
3398 2009-10-06  Julie Parent  <jparent@chromium.org>
3399
3400         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3401         rather than my committer email.
3402
3403         * Scripts/modules/committers.py:
3404
3405 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3406
3407         Reviewed by Eric Seidel.
3408
3409         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3410
3411         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3412         it after each layout test as it should do, making the DRT dump additional output
3413         for all of the subsequent layout tests.
3414
3415         * DumpRenderTree/qt/jsobjects.cpp:
3416         (LayoutTestController::reset):
3417
3418 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3419
3420         Reviewed by Simon Hausmann.
3421
3422         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3423         fast/dom/assign-to-window-status.html test, which is passing as a result.
3424
3425         https://bugs.webkit.org/show_bug.cgi?id=30127
3426
3427         * DumpRenderTree/qt/DumpRenderTree.cpp:
3428         (WebCore::DumpRenderTree::DumpRenderTree):
3429         (WebCore::DumpRenderTree::statusBarMessage):
3430         * DumpRenderTree/qt/DumpRenderTree.h:
3431         * DumpRenderTree/qt/jsobjects.h:
3432         (LayoutTestController::shouldDumpStatusCallbacks):
3433         (LayoutTestController::dumpStatusCallbacks):
3434
3435 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3436
3437         Reviewed by Simon Hausmann.
3438
3439         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3440         ignores the argument indicating which mouse button to trigger.
3441         https://bugs.webkit.org/show_bug.cgi?id=30048
3442
3443         This affects the fast/events/mouse-click-events.html layout test.
3444
3445         * DumpRenderTree/qt/jsobjects.cpp:
3446         (EventSender::mouseDown):
3447         (EventSender::mouseUp):
3448         * DumpRenderTree/qt/jsobjects.h:
3449
3450 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3451
3452         Reviewed by Simon Hausmann.
3453
3454         [Qt] Fix the EventSender::keyDown() implementation
3455         https://bugs.webkit.org/show_bug.cgi?id=30043
3456
3457         It should post both a key press event and a key release event,
3458         just like other ports do.
3459
3460         * DumpRenderTree/qt/jsobjects.cpp:
3461         (EventSender::keyDown):
3462
3463 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3464
3465         wx build fix. Add jpeg to the list of libs to link against.
3466
3467         * wx/build/settings.py:
3468
3469 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3470
3471         Reviewed by Simon Hausmann.
3472
3473         [Qt] EventSender::keyDown() cannot send function-key events.
3474         https://bugs.webkit.org/show_bug.cgi?id=30044
3475
3476         This affects the fast/events/keydown-function-keys.html layout test.
3477
3478         * DumpRenderTree/qt/jsobjects.cpp:
3479         (EventSender::keyDown):
3480
3481 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3482
3483         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3484         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3485
3486         * wx/build/settings.py:
3487         * wx/build/wxpresets.py:
3488
3489 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3490
3491         Reviewed by Timothy Hatcher.
3492
3493         Web Inspector: add testing harness for Web Inspector.
3494
3495         https://bugs.webkit.org/show_bug.cgi?id=30010
3496
3497         * DumpRenderTree/LayoutTestController.cpp:
3498         (showWebInspectorCallback):
3499         (closeWebInspectorCallback):
3500         (evaluateInWebInspectorCallback):
3501         (LayoutTestController::staticFunctions):
3502         * DumpRenderTree/LayoutTestController.h:
3503         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3504         (LayoutTestController::showWebInspector):
3505         (LayoutTestController::closeWebInspector):
3506         (LayoutTestController::evaluateInWebInspector):
3507         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3508         (LayoutTestController::showWebInspector):
3509         (LayoutTestController::closeWebInspector):
3510         (LayoutTestController::evaluateInWebInspector):
3511         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3512         (LayoutTestController::showWebInspector):
3513         (LayoutTestController::closeWebInspector):
3514         (LayoutTestController::evaluateInWebInspector):
3515         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3516         (LayoutTestController::showWebInspector):
3517         (LayoutTestController::closeWebInspector):
3518         (LayoutTestController::evaluateInWebInspector):
3519
3520 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3521
3522         Reviewed by Ariyha Hidayat.
3523
3524         Pass arguments to system() as a string instead of array
3525
3526         When passed as an array entries with a space fail to translate
3527         to two arguments to the child process, so instead of manually
3528         splitting all the entries in @buildArgs we pass the whole thing
3529         as a string instead.
3530
3531         * Scripts/webkitdirs.pm:
3532
3533 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3534
3535         Reviewed by David Levin.
3536
3537         check-webkit-style misses whitespace errors for operators:
3538         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3539         https://bugs.webkit.org/show_bug.cgi?id=30021
3540
3541         * Scripts/modules/cpp_style.py:
3542         Added the operators mentioned above to the same list as == and !=.
3543
3544 2009-10-02  Julie Parent  <jparent@chromium.org>
3545
3546         Unreviewed.
3547
3548         Adding myself and Ojan Vafai as committers, because we are committers.
3549
3550         * Scripts/modules/committers.py:
3551
3552 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3553
3554         Reviewed by Adam Roben.
3555
3556         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3557         this will help the patch merging process when TryBots are used.
3558
3559         * Scripts/svn-create-patch:
3560
3561 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3562
3563         Reviewed by Simon Hausmann.
3564
3565         [Qt] Implement layoutTestController.overridePreference().
3566         https://bugs.webkit.org/show_bug.cgi?id=29970
3567
3568         * DumpRenderTree/qt/DumpRenderTree.cpp:
3569         (WebCore::WebPage::WebPage):
3570         (WebCore::WebPage::resetSettings):
3571         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3572         * DumpRenderTree/qt/jsobjects.cpp:
3573         (LayoutTestController::reset):
3574         (LayoutTestController::setPrivateBrowsingEnabled):
3575         (LayoutTestController::setPopupBlockingEnabled):
3576         (LayoutTestController::overridePreference):
3577         * DumpRenderTree/qt/jsobjects.h:
3578
3579 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3580
3581         Reviewed by Oliver Hunt.
3582
3583         Turn on ENABLE_3D_CANVAS in TOT
3584         https://bugs.webkit.org/show_bug.cgi?id=29906
3585
3586         * Scripts/build-webkit:
3587
3588 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3589
3590         Rubberstamped by Simon Hausmann.
3591
3592         Enable HTTP tests for Qt
3593
3594         * Scripts/run-webkit-tests:
3595
3596 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3597
3598         Reviewed by Dimitri Glazkov.
3599
3600         build-webkit --chromium now also works on cygwin.
3601
3602         https://bugs.webkit.org/show_bug.cgi?id=29973
3603
3604         * Scripts/webkitdirs.pm:
3605
3606 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3607
3608         Reviewed by Simon Hausmann.
3609
3610         [Qt] Don't use TCmalloc in DumpRenderTree
3611         https://bugs.webkit.org/show_bug.cgi?id=27029
3612
3613         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3614
3615         * DumpRenderTree/qt/DumpRenderTree.pro:
3616
3617 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3618
3619         Reviewed by Simon Hausmann.
3620
3621         [Qt] Implement eventSender.scheduleAsynchronousClick().
3622
3623         https://bugs.webkit.org/show_bug.cgi?id=29931
3624
3625         * DumpRenderTree/qt/jsobjects.cpp:
3626         (EventSender::scheduleAsynchronousClick):
3627         * DumpRenderTree/qt/jsobjects.h:
3628
3629 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3630
3631         Reviewed by Simon Hausmann.
3632
3633         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3634         fast/events/open-window-from-another-frame.html from the Skipped list.
3635
3636         https://bugs.webkit.org/show_bug.cgi?id=29930
3637
3638         * DumpRenderTree/qt/jsobjects.cpp:
3639         (LayoutTestController::setPopupBlockingEnabled):
3640         * DumpRenderTree/qt/jsobjects.h:
3641
3642 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3643
3644         Unreviewed.
3645
3646         Added myself to the list of committers.
3647
3648         * Scripts/modules/committers.py:
3649
3650 2009-09-30  Eric Seidel  <eric@webkit.org>
3651
3652         No review, just adding Geoff to the list of reviewers.
3653
3654         * Scripts/modules/committers.py:
3655
3656 2009-09-30  Dan Bernstein  <mitz@apple.com>
3657
3658         Reviewed by Sam Weinig.
3659
3660         Added the WebKit Layout Tests fonts that are referenced in
3661         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3662
3663         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3664         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3665
3666 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3667
3668         Reviewed by David Kilzer.
3669
3670         Make sunspider scripts work on Windows platform.
3671         https://bugs.webkit.org/show_bug.cgi?id=29656
3672
3673         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3674         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3675         * Scripts/webkitdirs.pm: currentPerlPath() added.
3676
3677 2009-09-29  Brady Eidson  <beidson@apple.com>
3678
3679         Rubberstamped by Dan Bernstein.
3680
3681         Fix license and some sorting in new files.
3682
3683         * DumpRenderTree/mac/HistoryDelegate.h:
3684         * DumpRenderTree/mac/HistoryDelegate.mm:
3685
3686 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3687
3688         Reviewed by David Kilzer.
3689
3690         Fixed how error codes are handled.
3691         https://bugs.webkit.org/show_bug.cgi?id=29898
3692
3693         * Scripts/update-webkit:
3694         * Scripts/update-webkit-chromium: