2010-10-07 Balazs Kelemen <kbalazs@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2
3         Reviewed by Kenneth Rohde Christiansen.
4
5         WebKitTestRunner should be portable
6         https://bugs.webkit.org/show_bug.cgi?id=45393
7
8         Use only the WebKit API for working with urls.
9         * WebKitTestRunner/StringFunctions.h:
10         (WTR::createWKURL):
11         * WebKitTestRunner/TestController.cpp:
12         (WTR::blankURL):
13         (WTR::TestController::resetStateToConsistentValues):
14         (WTR::TestController::didFinishLoadForFrame):
15
16 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
17
18         Reviewed by Xan Lopez.
19
20         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
21         https://bugs.webkit.org/show_bug.cgi?id=47332
22
23         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
24         (createBitmapContextFromWebView):
25
26 2010-10-06  Chris Guillory  <chris.guillory@google.com>
27
28         Reviewed by Chris Fleizach.
29
30         Remove unused accessibility functions from webkit.
31         https://bugs.webkit.org/attachment.cgi?bugid=46707
32
33         * DumpRenderTree/chromium/WebViewHost.cpp:
34         (WebViewHost::postAccessibilityNotification):
35         * DumpRenderTree/chromium/WebViewHost.h:
36
37 2010-10-06  Lucas Forschler  <lforschler@apple.com>
38
39         Reviewed by Adam Roben.
40
41         Fix the sunspider-compare-results to actually use the passed in value for $root.
42
43         * Scripts/sunspider-compare-results:
44
45 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
46
47         Reviewed by Kenneth Rohde Christiansen.
48
49         [Qt] Runloop implementation for WTR
50         https://bugs.webkit.org/show_bug.cgi?id=47280
51
52         * WebKitTestRunner/qt/TestControllerQt.cpp:
53         Implemented TestController::runUntil by a timerEvent
54         and a QEventLoop. We step into the event loop from runUntil.
55         While we are waiting in the loop a timerEvent is periodically
56         checking the value of the condition. Once the condition has
57         becoming true the timerEvent wakes us up.
58         (WTR::RunUntilLoop::start):
59         (WTR::RunUntilLoop::RunUntilLoop):
60         (WTR::RunUntilLoop::run):
61         (WTR::RunUntilLoop::timerEvent):
62         (WTR::TestController::platformInitialize):
63         (WTR::TestController::runUntil):
64         * WebKitTestRunner/qt/main.cpp:
65         Start the main event loop first and creating the TestController later.
66         (Launcher::Launcher):
67         (Launcher::~Launcher):
68         (Launcher::launch): Creating the TestController.
69         (main): Setting up a timer for calling Launcher::launch from
70         the main event loop.
71
72 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
73
74         Reviewed by Kenneth Russell.
75
76         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
77         enable 'accelerated-composting' instead of 'accelerated-compositing'.
78
79         https://bugs.webkit.org/show_bug.cgi?id=47312
80
81         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
82         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
83
84 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
85
86         Reviewed by Kenneth Rohde Christiansen.
87
88         [Qt] PlatformWebView implementation for WebKitTestRunner
89         https://bugs.webkit.org/show_bug.cgi?id=47276
90
91         The implementation follows the way how
92         we use the API in MiniBrowser.
93         * WebKitTestRunner/PlatformWebView.h:
94         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
95         (WTR::WebView::wkView):
96         (WTR::WebView::~WebView):
97         (WTR::WebView::WebView):
98         (WTR::PlatformWebView::PlatformWebView):
99         (WTR::PlatformWebView::~PlatformWebView):
100         (WTR::PlatformWebView::resizeTo):
101         (WTR::PlatformWebView::page):
102         (WTR::PlatformWebView::focus):
103         * WebKitTestRunner/qt/WebKitTestRunner.pro:
104
105 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
106
107         Reviewed by Kenneth Rohde Christiansen.
108
109         [Qt] Add WebKitTestRunner's build files
110         https://bugs.webkit.org/show_bug.cgi?id=44155
111
112         Parts was taken by Zoltan Horvath's patch.
113
114         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
115         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
116         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
117         PlatformWKView and PlatformWindow (void* for now).
118         Buildfix the case when __APPLE__ is not defined.
119         * WebKitTestRunner/qt/DerivedSources.pro: Added.
120         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
121         Empty stub implementation.
122         (WTR::registerWindowClass):
123         (WTR::PlatformWebView::PlatformWebView):
124         (WTR::PlatformWebView::~PlatformWebView):
125         (WTR::PlatformWebView::resizeTo):
126         (WTR::PlatformWebView::page):
127         (WTR::PlatformWebView::focus):
128         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
129         Empty stub implementation.
130         (WTR::registerWindowClass):
131         (WTR::TestController::runUntil):
132         (WTR::TestController::platformInitialize):
133         (WTR::TestController::initializeInjectedBundlePath):
134         (WTR::TestController::initializeTestPluginDirectory):
135         (WTR::TestController::platformInitializeContext):
136         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
137         * WebKitTestRunner/qt/main.cpp: Added.
138         (main):
139
140 2010-10-06  Tony Chang  <tony@chromium.org>
141
142         Unreviewed, rolling out r69202.
143         http://trac.webkit.org/changeset/69202
144         https://bugs.webkit.org/show_bug.cgi?id=46937
145
146         Broke compile of test_shell
147
148         * DumpRenderTree/chromium/EventSender.cpp:
149         (EventSender::beginDragWithFiles):
150         * DumpRenderTree/chromium/WebViewHost.cpp:
151         (addDRTFakeFileToDataObject):
152
153 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
154
155         Reviewed by Tony Chang.
156
157         [chromium] Minor naming cleanup in WebDragData, part 2
158         https://bugs.webkit.org/show_bug.cgi?id=46937
159
160         Update DRT to use the renamed methods.
161
162         * DumpRenderTree/chromium/EventSender.cpp:
163         (EventSender::beginDragWithFiles):
164         * DumpRenderTree/chromium/WebViewHost.cpp:
165         (addDRTFakeFileToDataObject):
166
167 2010-10-06  David Kilzer  <ddkilzer@apple.com>
168
169         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
170
171         Reviewed by Adam Roben.
172
173         This is the first step in making webarchive tests work on
174         Windows.
175
176         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
177         new files to the project.
178         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
179         to WebArchiveDumpSupport.mm.
180         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
181         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
182         (serializeWebArchiveToXML):
183
184 2010-10-05  Daniel Bates  <dbates@rim.com>
185
186         Reviewed by David Kilzer.
187
188         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
189         https://bugs.webkit.org/show_bug.cgi?id=46058
190
191         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
192         structure so as to support returning additional information
193         about a change log diff.
194
195         Currently, VCSUtils::fixChangeLogPatch() returns a string that
196         represents the change log diff. Towards supporting the return
197         of additional information, such as whether the change log diff
198         inserts an entry at the top of the ChangeLog file, we need to
199         make VCSUtils::fixChangeLogPatch() return a reference to hash
200         structure.
201
202         * Scripts/VCSUtils.pm:
203           - Modified fixChangeLogPatch() to return a reference to a
204             hash structure.
205           - Added documentation to fixChangeLogPatch().
206           - Modified call site in mergeChangeLogs() as necessary.
207         * Scripts/svn-apply:
208           - Modified call site in patch() as necessary.
209         * Scripts/svn-create-patch:
210           - Modified call site in generateDiff() as necessary.
211         * Scripts/svn-unapply:
212           - Modified call site in patch() as necessary.
213         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
214           - Modified the unit tests as necessary.
215
216 2010-10-05  Tony Chang  <tony@chromium.org>
217
218         Reviewed by Darin Adler.
219
220         fix the link to the expected image on windows
221         https://bugs.webkit.org/show_bug.cgi?id=47228
222
223         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
224             windows, the file must be opened in binary mode when writing
225             binary data.
226
227 2010-10-05  Adam Barth  <abarth@webkit.org>
228
229         Update expected result of unittest to match Tony's change below.
230
231         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
232
233 2010-10-05  Tony Chang  <tony@chromium.org>
234
235         Reviewed by Ojan Vafai (over the shoulder).
236
237         Paper over errors in image_diff so we don't crash the whole test run.
238
239         * Scripts/webkitpy/layout_tests/port/chromium.py:
240
241 2010-10-05  Tony Chang  <tony@chromium.org>
242
243         Unreviewed, make shutil.rmtree more resiliant to errors
244         since windows was raising WindowsError: The process cannot access the file because it
245         is being used by another process.
246
247         * Scripts/webkitpy/layout_tests/port/chromium.py:
248
249 2010-10-05  Tony Chang  <tony@chromium.org>
250
251         Reviewed by Ojan Vafai.
252
253         [chromium] fix image diffing in NRWT
254         https://bugs.webkit.org/show_bug.cgi?id=47128
255
256         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
257             NamedTemporaryFile since it doesn't work on Windows.
258         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
259
260 2010-10-05  Kenneth Russell  <kbr@google.com>
261
262         Reviewed by Tony Chang.
263
264         [chromium] Implement layerTreeAsText in DumpRenderTree
265         https://bugs.webkit.org/show_bug.cgi?id=47216
266
267         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
268         make it callable from DumpRenderTree.
269
270         No new tests; verified with existing compositor layout tests.
271
272         * DumpRenderTree/chromium/LayoutTestController.cpp:
273         (LayoutTestController::LayoutTestController):
274         (LayoutTestController::layerTreeAsText):
275         * DumpRenderTree/chromium/LayoutTestController.h:
276
277 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
278
279         Unreviewed build correction.
280
281         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
282         property sheet so proper libraries are linked.
283
284 2010-10-05  Robert Hogan  <robert@webkit.org>
285
286         Reviewed by Andreas Kling.
287
288         [Qt] Fix url conversion in QWebHistory
289
290         Converting from KURL to WFT::String to QUrl does not
291         permit proper percent encoding later.
292
293         https://bugs.webkit.org/show_bug.cgi?id=47048
294
295         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
296         (WebCore::dumpHistoryItem):
297
298 2010-10-05  Anders Carlsson  <andersca@apple.com>
299
300         Reviewed by Sam Weinig.
301
302         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
303         https://bugs.webkit.org/show_bug.cgi?id=47188
304         <rdar://problem/8514104>
305
306         When constructing the std::string, use the real string length instead of the maximum buffer size.
307
308         * TestWebKitAPI/PlatformUtilities.h:
309         (TestWebKitAPI::Util::toSTD):
310         * WebKitTestRunner/StringFunctions.h:
311         (WTR::toSTD):
312
313 2010-10-04  Sam Weinig  <sam@webkit.org>
314
315         Reviewed by Mark Rowe.
316
317         Add MIMEType accessor to WKFrame
318         <rdar://problem/8347683>
319         https://bugs.webkit.org/show_bug.cgi?id=47138
320
321         * TestWebKitAPI/PlatformUtilities.h:
322         (TestWebKitAPI::Util::toSTD):
323         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
324         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
325         (TestWebKitAPI::didStartProvisionalLoadForFrame):
326         (TestWebKitAPI::didCommitLoadForFrame):
327         (TestWebKitAPI::didFinishLoadForFrame):
328         (TestWebKitAPI::TEST):
329         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
330         (TestWebKitAPI::didStartProvisionalLoadForFrame):
331         (TestWebKitAPI::didCommitLoadForFrame):
332         (TestWebKitAPI::didFinishLoadForFrame):
333         (TestWebKitAPI::TEST):
334         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
335         (TestWebKitAPI::TEST):
336         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
337         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
338         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
339         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
340         (TestWebKitAPI::Util::createURLForResource):
341
342 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
343
344         Reviewed by Ojan Vafai.
345
346         [NRWT] Rename current_dir to current_group because it's not a directory
347         https://bugs.webkit.org/show_bug.cgi?id=47169
348
349         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
350         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
351
352 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
353
354         Unreviewed, build fix.
355
356         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
357         which can't always be done. This test uses tempfile.mkdtemp(), which
358         should be safe.
359
360         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
361
362 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
363
364         Unreviewed, build fix.
365
366         Add missing "from __future__ import with_statement" that was
367         breaking test-webkitpy on the Leopard bots (broke in r69040).
368
369         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
370
371 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
372
373         Unreviewed, rolling out r69066.
374         http://trac.webkit.org/changeset/69066
375         https://bugs.webkit.org/show_bug.cgi?id=47163
376
377         Made NRWT reliability worse. (Requested by tkent on #webkit).
378
379         * Scripts/webkitpy/layout_tests/port/chromium.py:
380         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
381
382 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
383
384         Reviewed by Tony Chang.
385
386         [NRWT] Reverse the http tests to alphabetical order.
387         https://bugs.webkit.org/show_bug.cgi?id=47075
388
389         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
390
391 2010-10-04  Robert Hogan  <robert@webkit.org>
392
393         Reviewed by Andreas Kling.
394
395         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
396
397         We need to queue back and forward navigations in the DRT from the
398         LayoutTestController so that maybeDump() knows about them.
399
400         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
401         (LayoutTestController::queueBackNavigation):
402         (LayoutTestController::queueForwardNavigation):
403
404 2010-10-04  Tony Chang  <tony@chromium.org>
405
406         Reviewed by Kent Tamura.
407
408         [chromium] fix image diffing in NRWT
409         https://bugs.webkit.org/show_bug.cgi?id=47128
410
411         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
412               temp file and check the image_diff error code more carefully
413         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
414
415 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
416
417         Reviewed by Adam Barth.
418
419         aroben's change in r68792 actually broke new-run-webkit-tests when
420         running the DRT code path. His change was intended to fix the
421         way we were converting windows paths to URIs when running under
422         Cygwin (the paths were getting one too many "/" on the front).
423         However, the change ended up breaking the chromium_win port, which
424         had slightly different logic.
425
426         This patch removes the port-specific code and adds tests to make
427         sure we're getting the behavior we expect. The Port object no longer
428         exposes a get_absolute_path() method that can be used outside of
429         of converting test filenames, because it's unreliable otherwise
430         (we don't have the right context to know which conversion is intended).
431
432         https://bugs.webkit.org/show_bug.cgi?id=47140
433
434         * Scripts/webkitpy/layout_tests/port/base.py:
435         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
436         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
437         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
438         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
439
440 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
441
442         Unreviewed, build fix.
443
444         Handle crash introduced in r69040 if we are not running in a
445         Chromium checkout.
446
447         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
448
449 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
450
451         Reviewed by Tony Chang.
452
453         Add a way for us to have test expectations that are specific to the
454         official builds of Google Chrome (as opposed to Chromium). This change
455         looks for an additional "test_expectations_chrome.txt" file in
456         Chromium's repository (webkit/tools/layout_tests), and uses the
457         concatenation of that file and the regular test_expectations.txt
458         file for test overrides.
459
460         https://bugs.webkit.org/show_bug.cgi?id=46854
461
462         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
463         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
464
465 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
466
467         Color tests in the list based on existing pass/fail result.
468         
469         Fix the summary data to account for htmlOnly and nonHTML tests.
470
471         * CSSTestSuiteHarness/harness/harness.css:
472         (#test-list > option.pass):
473         (#test-list > option.fail):
474         (#test-list > option.skipped):
475         * CSSTestSuiteHarness/harness/harness.js:
476         (Test):
477         (Test.prototype.statusForFormat):
478         (TestSuite.prototype.fillTestList):
479         (TestSuite.prototype.updateTestList):
480         (TestSuite.prototype.recordResult):
481         (TestSuite.prototype.markTestCompleted):
482         (TestSuite.prototype.countTestsWithFlag):
483         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
484         (TestSuite.prototype.queryDatabaseForSummary):
485
486 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
487
488         Reviewed by Beth Dakin.
489
490         AX: doAXRangeForLine does not work
491         https://bugs.webkit.org/show_bug.cgi?id=47101
492
493         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
494
495         * DumpRenderTree/AccessibilityUIElement.cpp:
496         (rangeForLineCallback):
497         (AccessibilityUIElement::rangeForLine):
498         (AccessibilityUIElement::getJSClass):
499         * DumpRenderTree/AccessibilityUIElement.h:
500         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
501         (AccessibilityUIElement::rangeForLine):
502
503 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
504
505         Unreviewed. Adding myself to the committers list.
506
507         * Scripts/webkitpy/common/config/committers.py:
508
509 2010-10-04  Sam Weinig  <sam@webkit.org>
510
511         Reviewed by Anders Carlsson.
512
513         Add ability to set the CacheModel in Webkit2
514         https://bugs.webkit.org/show_bug.cgi?id=47066
515
516         * MiniBrowser/mac/AppDelegate.m:
517         (-[BrowserAppDelegate init]): Opt minibrowser into
518         a PrimaryWebBrowser cache model.
519
520 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
521
522         Make sure to enter all tests when creating the database
523         for the first time.
524         
525         When migrating to a new version of the suite, be sure to
526         sync up the database and testinfo.data by removing old
527         tests, and inserting new ones.
528
529         * CSSTestSuiteHarness/harness/harness.js:
530         (TestSuite.prototype.openDatabase.creation):
531         (TestSuite.prototype.databaseCreated):
532         (TestSuite.prototype.populateDatabaseFromTestInfoData):
533         (TestSuite.prototype.insertTest):
534
535 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
536
537         More work on treating HTML4 and XHTML1 independently; when 
538         changing the format, rebuild the test list, and update the 
539         numbers in the chapter popup.
540
541         * CSSTestSuiteHarness/harness/harness.js:
542         (Test):
543         (Test.prototype.runForFormat):
544         (Test.prototype.completedForFormat):
545         (ChapterSection):
546         (ChapterSection.prototype.countTests):
547         (Chapter):
548         (Chapter.prototype.description):
549         (Chapter.prototype.countTests):
550         (Chapter.prototype.testCount):
551         (Chapter.prototype.untestedCount):
552         (TestSuite.prototype.buildChapters):
553         (TestSuite.prototype.loadCurrentTest):
554         (TestSuite.prototype.updateProgressLabel):
555         (TestSuite.prototype.processFlags):
556         (TestSuite.prototype.formatChanged):
557
558 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
559
560         Update test suite version 20101001.
561         
562         Handle database migration, and delete tests from the db that are
563         not present in testinfo.data.
564         
565         Load about:blank into the test frame before the test url, to make
566         missing tests more obvious.
567         
568         * CSSTestSuiteHarness/harness/harness.js:
569         (TestSuite.prototype.loadTest):
570         (TestSuite.prototype.openDatabase.creation):
571         (TestSuite.prototype.openDatabase.migration1_0To1_1):
572         (TestSuite.prototype.openDatabase.if.return):
573         (TestSuite.prototype.databaseReady):
574         (TestSuite.prototype.populateDatabaseFromTestInfoData):
575         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
576         (TestSuite.prototype.syncDatabaseWithTestInfoData):
577
578 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
579
580         Add the ability to jump to a specific test.
581
582         * CSSTestSuiteHarness/harness/harness.html:
583         * CSSTestSuiteHarness/harness/harness.js:
584         (TestSuite.prototype.goToTestByName):
585         (TestSuite.prototype.switchToFormat):
586
587 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
588
589         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
590         as the test.
591
592         * CSSTestSuiteHarness/harness/harness.js:
593         (TestSuite.prototype.loadRef):
594
595 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
596
597         Update the UI to reflect the fact that each test needs to be tested
598         in both HTML4 and XHTML1 format.
599         
600         * CSSTestSuiteHarness/harness/harness.js:
601         (Test):
602         (Chapter.prototype.description):
603         (Chapter.prototype.untestedCount):
604         (TestSuite.prototype.fillChapterPopup):
605         (TestSuite.prototype.updateChapterPopup):
606         (TestSuite.prototype.fillTestList):
607         (TestSuite.prototype.updateTestList):
608         (TestSuite.prototype.goToNextIncompleteTest):
609         (TestSuite.prototype.firstIncompleteTestIndex):
610         (TestSuite.prototype.recordResult):
611         (TestSuite.prototype.formatChanged):
612         (TestSuite.prototype.markTestCompleted):
613         (TestSuite.prototype.resetTestStatus):
614
615 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
616
617         Add the ability to remove results for re-testing, and
618         to import results.
619
620         * CSSTestSuiteHarness/harness/harness.css:
621         (.custom button):
622         (#overlay):
623         (#overlay.visible):
624         (.overlay-contents):
625         (.overlay-contents textarea):
626         (.overlay-contents .buttons):
627         (.overlay-contents .note):
628         (.overlay-contents .buttons button):
629         * CSSTestSuiteHarness/harness/harness.html:
630         * CSSTestSuiteHarness/harness/harness.js:
631         (TestSuite.prototype.importResults):
632         (TestSuite.prototype.clearResults):
633         (TestSuite.prototype.markTestCompleted):
634         (TestSuite.prototype.resetTestStatus):
635         (TestSuite.prototype.storeTestResult):
636         (TestSuite.prototype.importTestResults):
637         (TestSuite.prototype.clearTestResults):
638
639 2010-10-01  Sam Weinig  <sam@webkit.org>
640
641         Reviewed by Jon Honeycutt.
642
643         Deploy the new WKString functions to remove most uses of CF from
644         the WebKitTestRunner.
645
646         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
647         (WTR::InjectedBundle::didReceiveMessage):
648         (WTR::InjectedBundle::done):
649         * WebKitTestRunner/StringFunctions.h:
650         (WTR::toWK):
651         (WTR::toJS):
652         (WTR::toSTD):
653         (WTR::operator<<):
654         (WTR::copyURLString):
655         * WebKitTestRunner/TestController.cpp:
656         (WTR::TestController::resetStateToConsistentValues):
657         (WTR::TestController::didFinishLoadForFrame):
658         * WebKitTestRunner/TestInvocation.cpp:
659         (WTR::TestInvocation::invoke):
660         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
661
662 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
663
664         Unreviewed TestResultsServer change.
665
666         Add files introduced by http://crrev.com/61273 to the list of dashboard 
667         files to update.
668
669         * TestResultServer/handlers/dashboardhandler.py:
670
671 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
672
673         Build Fix for Windows.
674
675         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
676             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
677             ForwardingHeaders to the include path.
678
679 2010-10-01  Sam Weinig  <sam@webkit.org>
680
681         Reviewed by Anders Carlsson.
682
683         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
684
685         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
686         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
687         (TestWebKitAPI::TEST):
688         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
689         (TestWebKitAPI::TEST):
690
691 2010-10-01  Sam Weinig  <sam@webkit.org>
692
693         Reviewed by Kenneth Rohde Christiansen.
694
695         Add additional WKString API
696         https://bugs.webkit.org/show_bug.cgi?id=46958
697
698         Add basic WKStringRef tests.
699
700         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
701         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
702
703 2010-10-01  Sam Weinig  <sam@webkit.org>
704
705         Reviewed by Dan Bernstein.
706
707         Add makefile for TestWebKitAPI and call it from the base makefile.
708
709         * Makefile:
710         * TestWebKitAPI/Makefile: Added.
711
712 2010-10-01  Sam Weinig  <sam@webkit.org>
713
714         Reviewed by Adam Roben.
715
716         Remove unnecessary ForwardingHeaders from test runners.
717         https://bugs.webkit.org/show_bug.cgi?id=47010
718
719         * TestWebKitAPI/Configurations/Base.xcconfig:
720         * TestWebKitAPI/ForwardingHeaders: Removed.
721         * WebKitTestRunner/Configurations/Base.xcconfig:
722         * WebKitTestRunner/ForwardingHeaders: Removed.
723
724 2010-09-30  Adam Barth  <abarth@webkit.org>
725
726         Reviewed by Eric Seidel.
727
728         WebSocket tests are flaky
729         https://bugs.webkit.org/show_bug.cgi?id=46956
730
731         Update these tools to understand how to run the WebSocket tests off the
732         Apache server.
733
734         * Scripts/old-run-webkit-tests:
735         * Scripts/webkitpy/layout_tests/port/base.py:
736         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
737         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
738
739 2010-10-01  Adam Roben  <aroben@apple.com>
740
741         Encode Executive command arguments using UTF-8 on Cygwin
742
743         Cygwin's Python's os.execv doesn't support unicode command arguments.
744         Cygwin's execv expects arguments to be encoded using the current code
745         page. But code pages are limited in what characters they can handle,
746         and our tests include characters that the English code page can't
747         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
748         which can handle all characters but might confuse some commands, for
749         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
750         good enough, but we can deal with that when the problem arises.
751
752         Reviewed by Adam Barth.
753
754         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
755         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
756         fails on Windows
757
758         * Scripts/webkitpy/common/system/executive.py:
759         (Executive._run_command_with_teed_output):
760         (Executive.run_command):
761         On Cygwin, encode arguments using UTF-8.
762
763 2010-10-01  Sam Weinig  <sam@webkit.org>
764
765         Reviewed by Adam Roben.
766
767         Add simple API tester for WebKit2
768         https://bugs.webkit.org/show_bug.cgi?id=46953
769
770         This adds a very simple testing infrastructure for testing APIs exposed
771         through the WebKit project. It consists of two parts: 1) a project that
772         builds the all the tests 2) a script that searches the tests directory and
773         calls the tester once for each test.
774
775         This adds the infrastructure and two tests:
776         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
777         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
778
779         This currently only works on the mac, but is designed to be easily ported 
780         to any platform.
781
782         * Scripts/run-api-tests: Added.
783         * Scripts/build-api-tests: Added.
784         Scripts to build/run the tests.
785
786         * TestWebKitAPI: Added.
787         * TestWebKitAPI/Configurations: Added.
788         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
789         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
790         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
791         * TestWebKitAPI/ForwardingHeaders: Added.
792         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
793         * TestWebKitAPI/PlatformUtilities.h: Added.
794         * TestWebKitAPI/PlatformWebView.h: Added.
795         (TestWebKitAPI::PlatformWebView::platformView):
796         * TestWebKitAPI/StringFunctions.h: Added.
797         * TestWebKitAPI/Test.h: Added.
798         (TestWebKitAPI::Test::~Test):
799         (TestWebKitAPI::Test::name):
800         (TestWebKitAPI::Test::Register::Register):
801         (TestWebKitAPI::Test::Register::create):
802         (TestWebKitAPI::Test::Test):
803         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
805         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
806         * TestWebKitAPI/TestsController.cpp: Added.
807         (TestWebKitAPI::TestsController::shared):
808         (TestWebKitAPI::TestsController::TestsController):
809         (TestWebKitAPI::TestsController::runTestNamed):
810         (TestWebKitAPI::TestsController::testFailed):
811         (TestWebKitAPI::TestsController::registerCreateTestFunction):
812         * TestWebKitAPI/TestsController.h: Added.
813         * TestWebKitAPI/mac: Added.
814         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
815         (TestWebKitAPI::Util::run):
816         (TestWebKitAPI::Util::createURLForResource):
817         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
818         (TestWebKitAPI::PlatformWebView::PlatformWebView):
819         (TestWebKitAPI::PlatformWebView::resizeTo):
820         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
821         (TestWebKitAPI::PlatformWebView::page):
822         (TestWebKitAPI::PlatformWebView::focus):
823         * TestWebKitAPI/mac/main.mm: Added.
824         Infrastructure.
825
826         * TestWebKitAPI/Tests: Added.
827         * TestWebKitAPI/Tests/WTF: Added.
828         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
829         * TestWebKitAPI/Tests/WebKit2: Added.
830         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
831         (TestWebKitAPI::State::State):
832         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
833         Proof of concept tests.
834
835 2010-10-01  Adam Roben  <aroben@apple.com>
836
837         Don't assume AccessibleObjectFromEvent succeeds
838
839         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
840         DumpRenderTree!notificationListenerProc when running
841         plugins/access-after-page-destroyed.html
842
843         Reviewed by Sam Weinig.
844
845         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
846         (notificationListenerProc): Check both the return value of
847         AccessibleObjectFromEvent and the object it returns, as MSDN
848         recommends.
849
850 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
851
852         Reviewed by Tony Chang.
853
854         [NRWT] Put the http and websocket tests first in the test list.
855         https://bugs.webkit.org/show_bug.cgi?id=46453
856
857         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
858         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
859
860 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
861
862         Unreviewed, adding myself to the committer list.
863
864         * Scripts/webkitpy/common/config/committers.py:
865
866 2010-10-01  Adam Roben  <aroben@apple.com>
867
868         Test NPN_GetValue(NPNVnetscapeWindow)
869
870         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
871         Right-clicking on windowless Flash plugin in WebKit2 makes a context
872         menu appear in the bottom-right corner of the screen
873
874         Reviewed by Anders Carlsson.
875
876         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
877         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
878
879         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
880
881         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
882         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
883         (GetValueNetscapeWindow::NPP_SetWindow): Test that
884         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
885         isn't our HWND.
886
887         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
888         Added GetValueNetscapeWindow.
889
890 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
891
892         Unreviewed, adding my webkit.org identity to reviewer list.
893
894         * Scripts/webkitpy/common/config/committers.py:
895
896 2010-09-30  Adam Barth  <abarth@webkit.org>
897
898         Reviewed by Eric Seidel.
899
900         The WebSocket server should flush its logs
901         https://bugs.webkit.org/show_bug.cgi?id=46946
902
903         The WebSocket server logs are truncated because the driver just
904         terminates the child.  It should run Python without buffering so we can
905         see the end of the log.
906
907         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
908
909 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
910
911         Add a button to jump to the next untested test.
912         
913         * CSSTestSuiteHarness/harness/harness.css:
914         (.test-type):
915         (.name > button):
916         * CSSTestSuiteHarness/harness/harness.html:
917         * CSSTestSuiteHarness/harness/harness.js:
918         (Chapter.prototype.description):
919         (Chapter.prototype.untestedCount):
920         (TestSuite.prototype.testInfoDataLoaded):
921         (TestSuite.prototype.fillChapterPopup):
922         (TestSuite.prototype.updateChapterPopup):
923         (TestSuite.prototype.buildTestListForChapter):
924         (TestSuite.prototype.goToNextIncompleteTest):
925         (TestSuite.prototype.firstIncompleteTestIndex):
926         (TestSuite.prototype.testCompletionStateChanged):
927
928 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
929
930         WebKit2 on Windows should use Windows fonts for the various standard
931         font families
932         https://bugs.webkit.org/show_bug.cgi?id=43499
933         <rdar://problem/8272758>
934
935         Reviewed by Adam Roben.
936
937         * WebKitTestRunner/TestController.cpp:
938         (WTR::TestController::resetStateToConsistentValues):
939         Use the Mac fonts for running tests. This matches DRT behavior.
940
941 2010-09-30  Adam Barth  <abarth@webkit.org>
942
943         Third attempt.  We need a better integration test environment.
944
945         * Scripts/webkitpy/common/net/failuremap.py:
946         * Scripts/webkitpy/common/net/failuremap_unittest.py:
947
948 2010-09-30  Robert Hogan  <robert@webkit.org>
949
950         Reviewed by Andreas Kling.
951
952         [Qt] Support for PlainTextController
953
954         Unskip editing/text-iterator/basic-iteration.html
955
956         https://bugs.webkit.org/show_bug.cgi?id=38805
957
958         * DumpRenderTree/qt/DumpRenderTree.pro:
959         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
960         (WebCore::DumpRenderTree::DumpRenderTree):
961         (WebCore::DumpRenderTree::initJSObjects):
962         * DumpRenderTree/qt/DumpRenderTreeQt.h:
963         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
964         (PlainTextController::PlainTextController):
965         (PlainTextController::plainText):
966         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
967
968 2010-09-30  Adam Barth  <abarth@webkit.org>
969
970         Unreviewed.  Second attempt to fix sheriffbot.
971
972         * Scripts/webkitpy/common/net/buildbot.py:
973
974 2010-09-30  Adam Barth  <abarth@webkit.org>
975
976         Unreviewed.
977
978         This patch should stop the sheriffbot from throwing an exception.
979
980         * Scripts/webkitpy/common/net/buildbot.py:
981
982 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
983
984         Reviewed by Adam Roben.
985
986         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
987         https://bugs.webkit.org/show_bug.cgi?id=46926
988
989         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
990             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
991
992 2010-09-30  Adam Barth  <abarth@webkit.org>
993
994         Reviewed by Eric Seidel.
995
996         webkit-patch find-flaky-tests should print results URLs
997         https://bugs.webkit.org/show_bug.cgi?id=46917
998
999         Printing out the results URL makes find-flaky-tests more actionable
1000         because you can see what happens when a test fails.  The output from
1001         the script is still pretty noisy, but it seems useful.
1002
1003         * Scripts/webkitpy/tool/commands/queries.py:
1004
1005 2010-09-30  Chris Marrin  <cmarrin@apple.com>
1006
1007         Reviewed by Simon Fraser.
1008
1009         Make 2D accelerated canvas rendering build on Mac
1010         https://bugs.webkit.org/show_bug.cgi?id=46007
1011         
1012         Added ACCELERATED_2D_CANVAS to build-webkit
1013
1014         * Scripts/build-webkit:
1015
1016 2010-09-29  Kenneth Russell  <kbr@google.com>
1017
1018         Reviewed by Dimitri Glazkov.
1019
1020         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
1021         https://bugs.webkit.org/show_bug.cgi?id=46849
1022
1023         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
1024         works with the compositor integration in both DumpRenderTree and
1025         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
1026         and thereby trigger the compositor's readback code path. Added support
1027         for --enable-accelerated-compositing to DumpRenderTree.
1028
1029         Tested in both test_shell and DumpRenderTree on Linux, the latter by
1030         modifying a compositing layout test, dumping the pixels and verifying
1031         that they matched the output when the compositor was active.
1032
1033         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1034         (main):
1035         * DumpRenderTree/chromium/TestShell.cpp:
1036         (TestShell::TestShell):
1037         (TestShell::resetWebSettings):
1038         * DumpRenderTree/chromium/TestShell.h:
1039         (TestShell::setAcceleratedCompositingEnabled):
1040         * DumpRenderTree/chromium/WebPreferences.cpp:
1041         (WebPreferences::reset):
1042         (WebPreferences::applyTo):
1043         * DumpRenderTree/chromium/WebPreferences.h:
1044         * DumpRenderTree/chromium/WebViewHost.cpp:
1045         (WebViewHost::scheduleComposite):
1046         * DumpRenderTree/chromium/WebViewHost.h:
1047
1048 2010-09-30  Adam Roben  <aroben@apple.com>
1049
1050         Ensure that QueueEngine cleans up its log files when its delegate
1051         tells it to stop processing work
1052
1053         Reviewed by Adam Barth.
1054
1055         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
1056         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
1057         Windows
1058
1059         * Scripts/webkitpy/tool/bot/queueengine.py:
1060         (QueueEngine.run): Stop ourselves normally (including cleaning up log
1061         files) when the delegate tells us to stop processing work.
1062
1063         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1064         (LoggingDelegate.__init__): Moved code here from
1065         RaisingDelegate.__init__.
1066         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
1067         callback.
1068         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
1069         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
1070         care of for us now.
1071         (QueueEngineTest.test_trivial): Make sure we got the expected stop
1072         message.
1073         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
1074         remove the callbacks that are related to processing a single work
1075         item, rather than removing all callbacks after a certain point, as
1076         there are now more callbacks we expect to receive at the end.
1077
1078 2010-09-30  Adam Roben  <aroben@apple.com>
1079
1080         Fix path -> URL conversion on Cygwin
1081
1082         Reviewed by Adam Barth.
1083
1084         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
1085         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
1086
1087         * Scripts/webkitpy/layout_tests/port/base.py:
1088         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
1089         assuming paths already have a leading slash.
1090
1091 2010-09-30  Adam Roben  <aroben@apple.com>
1092
1093         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
1094         be called more than once
1095
1096         The NPP_SetWindow call made when the plugin is torn down was confusing
1097         us, and was causing us to spew an error into the next test.
1098
1099         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
1100         (r68520): plugins/access-after-page-destroyed.html failing on Windows
1101
1102         Reviewed by Anders Carlsson.
1103
1104         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1105         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
1106         Initialize member.
1107         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
1108         this isn't the first time this is called.
1109
1110 2010-09-30  Eric Seidel  <eric@webkit.org>
1111
1112         Reviewed by Adam Barth.
1113
1114         webkit-patch upload warns that I'm using Xcode when I'm not
1115         https://bugs.webkit.org/show_bug.cgi?id=46869
1116
1117         String.find returns -1 when not found, so switched to "in".
1118
1119         * Scripts/webkitpy/common/system/user.py:
1120         * Scripts/webkitpy/common/system/user_unittest.py:
1121
1122 2010-09-30  Eric Seidel  <eric@webkit.org>
1123
1124         Reviewed by Adam Barth.
1125
1126         webkit-patch failure-reason dies if non-trunk commits are in the blame range
1127         https://bugs.webkit.org/show_bug.cgi?id=46866
1128
1129         I also made failure-reason use RegressionWindow in a cleaner way.
1130
1131         * Scripts/webkitpy/tool/commands/queries.py:
1132
1133 2010-09-29  Adam Barth  <abarth@webkit.org>
1134
1135         Reviewed by Eric Seidel.
1136
1137         webkit-patch find-flaky-tests
1138         https://bugs.webkit.org/show_bug.cgi?id=46876
1139
1140         This command helps us find flaky tests so we can squash them.
1141
1142         * Scripts/webkitpy/tool/commands/queries.py:
1143
1144 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1145
1146         Fix export to use '?' instead of 'null' for
1147         tests with no results.
1148         
1149         * CSSTestSuiteHarness/harness/harness.js:
1150
1151 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1152
1153         Add a warning when a test requires special steps.
1154         Add a Print Preview button for 'paged' tests that
1155         brings up the print dialog, allowing the user to 
1156         judge paged media tests.
1157
1158         * CSSTestSuiteHarness/harness/harness.css:
1159         * CSSTestSuiteHarness/harness/harness.html:
1160         * CSSTestSuiteHarness/harness/harness.js:
1161         (TestSuite.prototype.loadTest):
1162         (TestSuite.prototype.processFlags):
1163
1164 2010-09-29  Adam Barth  <abarth@webkit.org>
1165
1166         Reviewed by Eric Seidel.
1167
1168         Remove revisions_casuing_failures
1169         https://bugs.webkit.org/show_bug.cgi?id=46872
1170
1171         This function exists only to be unit tested.
1172
1173         * Scripts/webkitpy/common/net/failuremap.py:
1174         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1175         * Scripts/webkitpy/tool/mocktool.py:
1176
1177 2010-09-29  Adam Barth  <abarth@webkit.org>
1178
1179         Reviewed by Eric Seidel.
1180
1181         SheriffBot should post the list of failing tests to bugs
1182         https://bugs.webkit.org/show_bug.cgi?id=46871
1183
1184         * Scripts/webkitpy/common/net/buildbot.py:
1185         * Scripts/webkitpy/common/net/failuremap.py:
1186         * Scripts/webkitpy/common/net/regressionwindow.py:
1187         * Scripts/webkitpy/tool/bot/sheriff.py:
1188         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1189         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1190         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1191         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1192         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1193         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1194         * Scripts/webkitpy/tool/mocktool.py:
1195
1196 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
1197
1198         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
1199
1200         [WinCairo] Adds a build slave.
1201         https://bugs.webkit.org/show_bug.cgi?id=46360
1202
1203         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
1204         entries for a debug build of the WinCairo port.
1205         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
1206         platform flag to configuration for wincairo (like gtk, chromium, etc.)
1207         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
1208         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
1209
1210 2010-09-29  Adam Barth  <abarth@webkit.org>
1211
1212         Reviewed by Eric Seidel.
1213
1214         Move more SheriffBot smarts into FailureMap
1215         https://bugs.webkit.org/show_bug.cgi?id=46703
1216
1217         This patch pushes the FailureMap model object further into the
1218         SheriffBot machine.  In addition, it moves a couple operations on this
1219         object from SheriffBot itself to the model.
1220
1221         Eventually, FailureMap will be the canonical context object for
1222         SheriffBot operations.  FailureMap represents a map of the current
1223         failures on the bots that might require remediation.
1224
1225         * Scripts/webkitpy/common/net/failuremap.py:
1226         * Scripts/webkitpy/common/net/regressionwindow.py:
1227         * Scripts/webkitpy/tool/commands/queries.py:
1228         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1229         * Scripts/webkitpy/tool/mocktool.py:
1230
1231 2010-09-29  Tony Chang  <tony@chromium.org>
1232
1233         Reviewed by James Robinson.
1234
1235         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
1236         https://bugs.webkit.org/show_bug.cgi?id=46829
1237
1238         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1239         (DRTDevToolsClient::DRTDevToolsClient):
1240         * DumpRenderTree/chromium/TestShell.cpp:
1241         (TestShell::TestShell):
1242         * DumpRenderTree/chromium/WebViewHost.cpp:
1243         (WebViewHost::postAccessibilityNotification):
1244         (WebViewHost::WebViewHost):
1245
1246 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
1247
1248         Reviewed by Darin Adler.
1249
1250         AX: implement CSS3 Speech "speak"
1251         https://bugs.webkit.org/show_bug.cgi?id=46827
1252
1253         * DumpRenderTree/AccessibilityUIElement.cpp:
1254         (speakCallback):
1255         (AccessibilityUIElement::speak):
1256         (AccessibilityUIElement::getJSClass):
1257         * DumpRenderTree/AccessibilityUIElement.h:
1258         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1259         (AccessibilityUIElement::speak):
1260
1261 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
1262
1263         Reviewed by Adam Barth.
1264
1265         Record bot ID when updating queue status
1266         https://bugs.webkit.org/show_bug.cgi?id=46764
1267         
1268         Since we now have multiple bots handling patches from the commit queue,
1269         we need to differentiate status updates from them, so that we can group
1270         the queue status page in a less confusing way.
1271
1272         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
1273         * QueueStatusServer/model/queuestatus.py: Add bot_id property
1274         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
1275         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
1276         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
1277         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
1278         * Scripts/webkitpy/tool/main.py: Add --bot-id
1279         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
1280
1281 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1282
1283         No review.
1284         
1285         References always refert to a file in .xht format, even
1286         for HTML tests, so fix their loading.
1287
1288         * CSSTestSuiteHarness/harness/harness.js:
1289         (TestSuite.prototype.loadRef):
1290
1291 2010-09-28  Johnny Ding  <jnd@chromium.org>
1292
1293         Reviewed by Adam Barth.
1294
1295         https://bugs.webkit.org/show_bug.cgi?id=41292
1296         Add a new parameter to the test plugin to allow specifying a script 
1297         and a mouse/keyboard event. The specified script will be evaluated
1298         in the browser when the specified event is received by the plugin.
1299
1300         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1301         (pluginAllocate):
1302         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1303         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1304         (NPP_New):
1305         (handleEventCarbon):
1306         (handleEventCocoa):
1307
1308 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1309
1310         Fix export by adding missing argument.
1311
1312         * CSSTestSuiteHarness/harness/harness.js:
1313         (TestSuite.prototype.showResultsForAllTests):
1314
1315 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1316
1317         [wx] Build fix, add missing import.
1318
1319         * wx/packaging/build-win-installer.py:
1320
1321 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1322
1323         No review
1324         
1325         Show which tests have been run by dimming them out in the test list.
1326         
1327         Adjust some element sizes.
1328         
1329         * CSSTestSuiteHarness/harness/harness.css:
1330         (#test-list > option.untested):
1331         (#test-list > option.completed):
1332         (#output):
1333         (.output-options):
1334         * CSSTestSuiteHarness/harness/harness.js:
1335         (Test):
1336         (TestSuite.prototype.fillTestList):
1337         (TestSuite.prototype.updateTestList):
1338         (TestSuite.prototype.setSelectedChapter):
1339         (TestSuite.prototype.recordResult):
1340         (TestSuite.prototype.markTestCompleted):
1341         (TestSuite.prototype.testCompletionStateChanged):
1342         (TestSuite.prototype.loadTestStatus):
1343
1344 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1345
1346         No review.
1347         
1348         Implement export of various queries on the test database, sharing
1349         code with that which displays results inline.
1350
1351         * CSSTestSuiteHarness/harness/harness.js:
1352         ():
1353         (TestSuite.prototype.exportResultsCompletion.var):
1354         (TestSuite.prototype.exportResultsCompletion):
1355         (TestSuite.prototype.showResultsForCompletedTests):
1356         (TestSuite.prototype.exportResultsForCompletedTests):
1357         (TestSuite.prototype.showResultsForAllTests):
1358         (TestSuite.prototype.exportResultsForAllTests):
1359         (TestSuite.prototype.exportResultsForTestsNotRun):
1360         (TestSuite.prototype.exportResultsForTestsWithStatus):
1361         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
1362
1363 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1364
1365         No review.
1366
1367         Work around uncertainty about the order of database
1368         transactions when creating the database, so that we don't
1369         try to query the table before it has been created.
1370
1371         * CSSTestSuiteHarness/harness/harness.js:
1372         (TestSuite):
1373         (TestSuite.prototype.databaseCreated):
1374         (TestSuite.prototype.storeTestResult):
1375         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1376         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
1377         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
1378         (TestSuite.prototype.queryDatabaseForCompletedTests):
1379         (TestSuite.prototype.queryDatabaseForTestsNotRun):
1380
1381 2010-09-28  Tony Chang  <tony@chromium.org>
1382
1383         Reviewed by Eric Seidel.
1384
1385         add python keyring support to webkit-patch
1386         https://bugs.webkit.org/show_bug.cgi?id=41269
1387
1388         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
1389             the python keyring module
1390         * Scripts/webkitpy/common/net/credentials_unittest.py:
1391         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
1392         * Scripts/webkitpy/common/system/user_unittest.py:
1393         * Scripts/webkitpy/tool/mocktool.py:
1394
1395 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1396
1397         Reviewed by Gustavo Noronha Silva.
1398
1399         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
1400         https://bugs.webkit.org/show_bug.cgi?id=46740
1401
1402         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
1403         fonts which can be used to fully test FontConfig rendering settings.
1404
1405 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1406
1407         Reviewed by Gustavo Noronha Silva.
1408
1409         [gtk] Fedora has a different path for the liberation fonts
1410         https://bugs.webkit.org/show_bug.cgi?id=46709
1411
1412         When searching for DRT fonts, also look in the path where those fonts
1413         are commonly found on Fedora systems.
1414
1415         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1416         (initializeFonts): Include logic for looking for Fedora-style font paths.
1417
1418 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1419
1420         Reviewed by Andreas Kling.
1421
1422         run-webkit-tests needs an updated list of directories with webgl tests
1423         https://bugs.webkit.org/show_bug.cgi?id=46747
1424
1425         Update the list of directories containing WebGL tests and a unit test
1426         which depends on this list.
1427
1428         * Scripts/old-run-webkit-tests: Update the list of directories.
1429         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
1430         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
1431
1432 2010-09-28  Adam Barth  <abarth@webkit.org>
1433
1434         Reviewed by Eric Seidel.
1435
1436         Introduce FailureMap to summaries the failures status of all the bots
1437         https://bugs.webkit.org/show_bug.cgi?id=46700
1438
1439         This patch gives the SheriffBot a handle on the list of failing tests.
1440
1441         * Scripts/webkitpy/common/net/buildbot.py:
1442         * Scripts/webkitpy/common/net/failuremap.py: Added.
1443         * Scripts/webkitpy/tool/commands/queries.py:
1444         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1445         * Scripts/webkitpy/tool/mocktool.py:
1446
1447 2010-09-28  Adam Roben  <aroben@apple.com>
1448
1449         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
1450
1451         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
1452         tell a WebKit2 client application that a key event was not handled
1453
1454         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
1455
1456         * MiniBrowser/mac/BrowserWindowController.m:
1457         (-[BrowserWindowController awakeFromNib]):
1458         * MiniBrowser/win/BrowserView.cpp:
1459         (BrowserView::create):
1460         * WebKitTestRunner/TestController.cpp:
1461         (WTR::createOtherPage):
1462         (WTR::TestController::initialize):
1463
1464 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1465
1466         Unreviewed.
1467
1468         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
1469         for the test order, but instead use information from testinfo.data.
1470         
1471         * CSSTestSuiteHarness/harness/harness.html:
1472         * CSSTestSuiteHarness/harness/harness.js:
1473
1474 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1475
1476         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
1477         it causes the process to hang on the gitorious repo.
1478
1479         * wx/packaging/build-mac-installer.py:
1480         * wx/packaging/build-win-installer.py:
1481
1482 2010-09-28  Adam Roben  <aroben@apple.com>
1483
1484         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
1485         called
1486
1487         Reviewed by Anders Carlsson.
1488
1489         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
1490         Full-page Adobe Reader does not paint until window is resized
1491
1492         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1493         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
1494         this level.
1495
1496         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
1497         NPP_SetWindow.
1498
1499         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
1500         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
1501         the plugin's HWND has a non-zero size and that its size/position
1502         matches that specified in the NPWindow.
1503
1504         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1505         (NPP_SetWindow): Call through to the PluginTest.
1506
1507         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1508         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
1509         the files as it saw fit.
1510
1511 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1512
1513         Reviewed by Andreas Kling.
1514
1515         [Qt] Remove support for Qt 4.5
1516         https://bugs.webkit.org/show_bug.cgi?id=46718
1517
1518         Remove the code for versions of Qt prior to 4.6.
1519
1520         * DumpRenderTree/qt/EventSenderQt.cpp:
1521         (EventSender::addTouchPoint):
1522         (EventSender::updateTouchPoint):
1523         (EventSender::setTouchModifier):
1524         (EventSender::touchStart):
1525         (EventSender::touchMove):
1526         (EventSender::touchEnd):
1527         (EventSender::clearTouchPoints):
1528         (EventSender::releaseTouchPoint):
1529         (EventSender::sendTouchEvent):
1530         * DumpRenderTree/qt/EventSenderQt.h:
1531         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1532         (TextInputController::setMarkedText):
1533         * QtTestBrowser/launcherwindow.cpp:
1534         (LauncherWindow::LauncherWindow):
1535         (LauncherWindow::initializeView):
1536         (LauncherWindow::createChrome):
1537         (LauncherWindow::sendTouchEvent):
1538         (LauncherWindow::eventFilter):
1539         (LauncherWindow::applyZoom):
1540         (LauncherWindow::setTouchMocking):
1541         * QtTestBrowser/launcherwindow.h:
1542         * QtTestBrowser/utils.cpp:
1543         (urlFromUserInput):
1544         * QtTestBrowser/webview.cpp:
1545         (WebViewGraphicsBased::animatedFlip):
1546         (WebViewGraphicsBased::animatedYFlip):
1547         * QtTestBrowser/webview.h:
1548         (WebViewGraphicsBased::setYRotation):
1549
1550 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
1551
1552         Reviewed by Andreas Kling.
1553
1554         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
1555         which should point to wcecompat installation. Needs wcecompat
1556         library from http://github.com/mauricek/wcecompat .
1557
1558         * DumpRenderTree/qt/DumpRenderTree.pro:
1559         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1560         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1561
1562 2010-09-28  Daniel Bates  <dbates@rim.com>
1563
1564         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
1565         <https://bugs.webkit.org/show_bug.cgi?id=39136>
1566
1567         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
1568         In particular, this change caused Sheriffbot to raise an exception when
1569         trying to parse the bug id on a bug page. We need to look into this
1570         some more.
1571
1572         * Scripts/webkitpy/common/net/bugzilla.py:
1573         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1574         * Scripts/webkitpy/tool/bot/sheriff.py:
1575         * Scripts/webkitpy/tool/commands/download.py:
1576         * Scripts/webkitpy/tool/commands/queues.py:
1577         * Scripts/webkitpy/tool/commands/upload.py:
1578         * Scripts/webkitpy/tool/steps/closebug.py:
1579         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1580         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1581         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1582
1583 2010-09-28  Adam Barth  <abarth@webkit.org>
1584
1585         Reviewed by Eric Seidel.
1586
1587         Move RegressionWindow further up the dependency chain
1588         https://bugs.webkit.org/show_bug.cgi?id=46698
1589
1590         Baby steps towards pushing this information into bug posts.
1591
1592         * Scripts/webkitpy/common/net/buildbot.py:
1593         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1594         * Scripts/webkitpy/common/net/regressionwindow.py:
1595         * Scripts/webkitpy/tool/commands/queries.py:
1596
1597 2010-09-27  Daniel Bates  <dbates@rim.com>
1598
1599         Reviewed by Adam Barth.
1600
1601         sheriffbot can't roll out security patches
1602         https://bugs.webkit.org/show_bug.cgi?id=39136
1603
1604         Make SheriffBot determine if it's authorized to view a bug
1605         whose change it wants to rollout before it tries to rollout
1606         the change.
1607
1608         Moreover, make both webkit-patch and Sheriffbot provide human-
1609         readable error messages when they are not authorized to view
1610         a bug and when a bug number is invalid.
1611
1612         Currently, Sheriffbot does not parse Bugzilla bugs for
1613         <bug error="...">, which indicates an error when retrieving
1614         a bug. In particular, error="NotPermitted" if a person (or bot)
1615         is not authorized to view a bug. For such error="NotPermitted" bugs,
1616         Sheriffbot raises an exception when parsing the bug report and
1617         this exception does not explicitly indicate Sheriffbot's lack
1618         of authorization. Instead, Sheriffbot should explicitly check
1619         for the presence <bug error="..."> before operating on a bug
1620         and error with a human-readable message if it's not permitted
1621         to view it.
1622
1623         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
1624         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1625           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
1626           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
1627           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
1628         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
1629         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1630         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1631         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
1632         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
1633         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
1634         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
1635         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
1636
1637 2010-09-27  Adam Barth  <abarth@webkit.org>
1638
1639         Reviewed by Eric Seidel.
1640
1641         Expose more more failure information from Buildbot to SheriffBot
1642         https://bugs.webkit.org/show_bug.cgi?id=46697
1643
1644         This patch moves the information about what tests failured closer to
1645         SheriffBot.  There are still a couple more patches to go before
1646         SheriffBot can post this information to bugs, but this is a step in
1647         that direction.  Yay for unit tests, which caught some bugs in earlier
1648         versions of this patch.
1649
1650         * Scripts/webkitpy/common/net/buildbot.py:
1651         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1652         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
1653         * Scripts/webkitpy/tool/commands/queries.py:
1654
1655 2010-09-27  Eric Seidel  <eric@webkit.org>
1656
1657         Unreviewed.  Fixing 500 error seen in the status server.
1658
1659         It turns out that a = b = []; b.append(1); then a[0] will be 1!
1660         This should have been obvious to me, I guess, but it was not what I was expecting.
1661
1662         * QueueStatusServer/model/activeworkitems.py:
1663
1664 2010-09-27  Adam Barth  <abarth@webkit.org>
1665
1666         Reviewed by Eric Seidel.
1667
1668         commit-queue should reject patches that fail to land
1669         https://bugs.webkit.org/show_bug.cgi?id=46694
1670
1671         This can happen, for example, if there's no reviewer.  Without this
1672         patch, we'll keep retrying the patch.
1673
1674         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1675         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1676
1677 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
1678
1679         Rubber-stamped by Adele Peterson.
1680
1681         Add a harness for running the CSS 2.1 test suite.
1682         
1683         This harness assumes that you've got a local a copy of the suite
1684         adjacent to the 'harness' directory.
1685         
1686         The harness lets you go through the tests in chapter order,
1687         denoting pass/fail/skipped for each test.
1688         
1689         It uses a client-side database to store the results of testing.
1690
1691         * CSSTestSuiteHarness/harness/harness.css: Added.
1692         * CSSTestSuiteHarness/harness/harness.html: Added.
1693         * CSSTestSuiteHarness/harness/harness.js: Added.
1694
1695 2010-09-27  Eric Seidel  <eric@webkit.org>
1696
1697         Reviewed by Adam Barth.
1698
1699         Patch locks should expire if a patch is marked for retry
1700         https://bugs.webkit.org/show_bug.cgi?id=46682
1701
1702         This was part Adam's original CommitQueueTask design,
1703         but support for it was missing from the server.
1704         I added the support, but triggering lock-release based on this
1705         special "retry" status feels a bit strange so I added a FIXME.
1706
1707         I also changed the text in queuestatus.html to say "Lock Acquired"
1708         since "Last Activity" isn't really true.  We only update the lock
1709         date when the patch is started, not on every status update.
1710
1711         I also noticed an exception in next-patch, which I fixed by re-writing
1712         the unzip logic in activeworkitems.py again.
1713
1714         * QueueStatusServer/handlers/updatestatus.py:
1715         * QueueStatusServer/model/activeworkitems.py:
1716         * QueueStatusServer/templates/queuestatus.html:
1717
1718 2010-09-27  Tony Chang  <tony@chromium.org>
1719
1720         Reviewed by David Levin.
1721
1722         [chromium] fix a warning when compiling DRT on 32-bit linux
1723         https://bugs.webkit.org/show_bug.cgi?id=46641
1724
1725         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1726         (DRTPrinter::handleImage):
1727
1728 2010-09-27  Eric Seidel  <eric@webkit.org>
1729
1730         Reviewed by Adam Barth.
1731
1732         queue-status should report when the patch was last locked to a queue
1733         https://bugs.webkit.org/show_bug.cgi?id=46674
1734
1735         This isn't necessarily the best way to expose this information
1736         but having this accessible via the web interface is very
1737         useful until we come up with a nicer way to display this.
1738
1739         I also cleaned up the code in activeworkitems.py a little
1740         to use list comprehensions and to have the code work with
1741         pairs instead of two lists at once.  Eventually I think those
1742         item/time pairs need to be their own little helper class.
1743
1744         * QueueStatusServer/handlers/queuestatus.py:
1745         * QueueStatusServer/model/activeworkitems.py:
1746         * QueueStatusServer/templates/queuestatus.html:
1747
1748 2010-09-27  Tony Chang  <tony@chromium.org>
1749
1750         Reviewed by David Levin.
1751
1752         [chromium] fix detection of missing fonts on DRT
1753         https://bugs.webkit.org/show_bug.cgi?id=46651
1754
1755         * DumpRenderTree/chromium/TestShellGtk.cpp:
1756         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
1757
1758 2010-09-27  Tony Chang  <tony@chromium.org>
1759
1760         Reviewed by Dimitri Glazkov.
1761
1762         add webkit unit tests to the chromium testers
1763         https://bugs.webkit.org/show_bug.cgi?id=46669
1764
1765         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1766         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
1767
1768 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
1769
1770         Unreviewed.
1771
1772         Adding myself to the committers list.
1773
1774         * Scripts/webkitpy/common/config/committers.py:
1775
1776 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
1777
1778         Reviewed by Eric Seidel.
1779
1780         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
1781         https://bugs.webkit.org/show_bug.cgi?id=46634
1782         
1783         Use OutputCapture to prevent console spam (and also check for expected
1784         output).
1785
1786         * Scripts/webkitpy/common/system/user_unittest.py:
1787
1788 2010-09-27  Eric Seidel  <eric@webkit.org>
1789
1790         Reviewed by James Robinson.
1791
1792         start-commit-queue should abort any rebases in progress
1793         https://bugs.webkit.org/show_bug.cgi?id=46640
1794
1795         webkit-patch commit-queue would do this itself, but this just
1796         helps ensure that the commit-queue script is properly updated
1797         before we run it (in the case where a previous rebase is in
1798         progress the git svn rebase would not work before we run the
1799         commit-queue).
1800
1801         * EWSTools/start-commit-queue.sh:
1802
1803 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
1804
1805         Reviewed by Gustavo Noronha Silva.
1806
1807         [GTK] Clean up the DRT fonts.conf and switch to Liberation
1808         https://bugs.webkit.org/show_bug.cgi?id=46038
1809
1810         Switch to Liberation fonts for GTK+ layout tests. This will make our
1811         test results metric-compatible with many Windows/Chromium results. It
1812         also simplifies the fonts.conf that we load and prepares the way for
1813         fixing many font bugs.
1814
1815         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1816         (initializeFonts): Initialize a known list of fonts instead of loading
1817         every font in the WEBKIT_TESTFONTS directory.
1818         * DumpRenderTree/gtk/fonts.conf: Removed.
1819         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1820         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
1821         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
1822         we can load both fonts.conf and AHEM____.TTF from this location.
1823         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
1824         it is no longer used.
1825
1826 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
1827
1828         Reviewed by Ojan Vafai.
1829
1830         new-run-webkit-httpd fails if Perl is not installed
1831         https://bugs.webkit.org/show_bug.cgi?id=46602
1832         
1833         Make Port._read_configuration catch all exceptions, since trying to run
1834         perl (because of _webkit_build_directory) when it's not installed throws
1835         a WindowsError or OSError, not an IOError (this became an issue after 
1836         r68268, since ChromiumPort ends up calling Port.default_configuration in
1837         its constructor, which means that we're ending up on this codepath in
1838         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
1839         new-run-webkit-httpd).
1840
1841         * Scripts/webkitpy/layout_tests/port/base.py:
1842         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1843
1844 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1845
1846         Reviewed by Antonio Gomes.
1847
1848         [EFL] Add setting API to set a local storage database path.
1849         https://bugs.webkit.org/show_bug.cgi?id=45446
1850
1851         Add a setting API to set local storage database path.
1852
1853         * EWebLauncher/main.c:
1854         (on_key_down):
1855         (browserCreate):
1856         (main):
1857
1858 2010-09-26  Sam Weinig  <sam@webkit.org>
1859
1860         Reviewed by Anders Carlsson.
1861
1862         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
1863         https://bugs.webkit.org/show_bug.cgi?id=46587
1864
1865         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1866
1867 2010-09-26  Antonio Gomes  <agomes@rim.com>
1868
1869         Reviewed by Kenneth Rohde Christiansen.
1870
1871         DRT/Mac nodesFromRect support
1872
1873         [Mac][DRT] Implement LayoutTestController::nodesFromRect
1874         https://bugs.webkit.org/show_bug.cgi?id=46580
1875
1876         Implements LayoutTestController::nodesFromRect for Mac DRT, and
1877         adding stubs for GTK+ and Windows.
1878
1879         * DumpRenderTree/LayoutTestController.cpp:
1880         (nodesFromRectCallback):
1881         (LayoutTestController::staticFunctions):
1882         * DumpRenderTree/LayoutTestController.h:
1883         (LayoutTestController::LayoutTestController::nodesFromRect):
1884         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1885         (LayoutTestController::nodesFromRect):
1886
1887 2010-09-25  Nicolas Weber  <thakis@chromium.org>
1888
1889         Reviewed by Adam Barth.
1890
1891         https://bugs.webkit.org/show_bug.cgi?id=46555
1892         Fix typo in prepare-ChangeLog's help output.
1893
1894         * Scripts/prepare-ChangeLog:
1895
1896 2010-09-24  Sam Weinig  <sam@webkit.org>
1897
1898         Reviewed by Darin Adler.
1899
1900         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
1901         <rdar://problem/8359279>
1902         https://bugs.webkit.org/show_bug.cgi?id=46546
1903
1904         * MiniBrowser/mac/BrowserWindowController.m:
1905         (mouseDidMoveOverElement):
1906         (-[BrowserWindowController awakeFromNib]):
1907         * MiniBrowser/win/BrowserView.cpp:
1908         (mouseDidMoveOverElement):
1909         (BrowserView::create):
1910         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1911         (WTR::InjectedBundlePage::InjectedBundlePage):
1912         * WebKitTestRunner/TestController.cpp:
1913         (WTR::createOtherPage):
1914         (WTR::TestController::initialize):
1915
1916 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
1917
1918         Reviewed by Adam Barth.
1919
1920         Allow rebaselines for webkit-patch rebaseline to be chosen
1921         https://bugs.webkit.org/show_bug.cgi?id=46407
1922         
1923         Instead of always rebaselining all failing tests, allow a subset to be
1924         chosen.
1925
1926         * Scripts/webkitpy/common/system/user.py:
1927         * Scripts/webkitpy/tool/commands/rebaseline.py:
1928
1929 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
1930
1931         Reviewed by Tony Chang.
1932
1933         [chromium] Implement TextInputController::firstRectForCharacterRange
1934         https://bugs.webkit.org/show_bug.cgi?id=38100
1935
1936         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
1937         No new tests are added since we need to implement the same feature in chromium side
1938         in order to enable any tests that uses this function.
1939
1940         * DumpRenderTree/chromium/TextInputController.cpp:
1941         (TextInputController::firstRectForCharacterRange): Added.
1942
1943 2010-09-24  Adam Barth  <abarth@webkit.org>
1944
1945         Reviewed by Eric Seidel.
1946
1947         commit-queue reports land failures as "PASS"
1948         https://bugs.webkit.org/show_bug.cgi?id=46530
1949
1950         We were ignoring the return value of land instead of passing it back to
1951         CommitQueue.  Of course, this was the one case I forgot to test!
1952
1953         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1954         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1955
1956 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
1957
1958         Reviewed by Eric Seidel.
1959
1960         new-run-webkit-tests prints out nothing when build-dumprendertree fails
1961         https://bugs.webkit.org/show_bug.cgi?id=37563
1962
1963         Print error message when build-dumprendertree fails.
1964
1965         * Scripts/webkitpy/layout_tests/port/webkit.py:
1966         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1967
1968 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
1969
1970         Reviewed by Tony Chang.
1971
1972         NRWT doesn't respect config set with set-webkit-configuration
1973         https://bugs.webkit.org/show_bug.cgi?id=46278
1974         
1975         Use Port.default_configuration() instead of hardcoding Release in
1976         ChromiumPort configuration initialization, so that we still inherit the
1977         configuration set by set-webkit-configuration.
1978
1979         * Scripts/webkitpy/layout_tests/port/chromium.py:
1980         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1981
1982 2010-09-24  Chang Shu  <chang.shu@nokia.com>
1983
1984         Reviewed by Csaba Osztrogonác.
1985
1986         [Qt] Fix the code to check file existence.
1987         https://bugs.webkit.org/show_bug.cgi?id=46465
1988
1989         * QtTestBrowser/main.cpp:
1990         (main):
1991
1992 2010-09-23  Tony Chang  <tony@chromium.org>
1993
1994         Unreviewed, rolling out r68232.
1995         http://trac.webkit.org/changeset/68232
1996
1997         Broken NRWT on the canary bots.
1998
1999         * Scripts/webkitpy/layout_tests/port/chromium.py:
2000
2001 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
2002
2003         Unreviewed, build fix.
2004
2005         r68008 broke new-run-webkit-tests in that the chromium ports no
2006         longer respect set-webkit-configuration. The correct fix for this
2007         is being pursued in bug 46278 (along with a bunch of unit tests),
2008         but in the meantime I'm reverting the particular lines that broke
2009         things. This was tested by hand.
2010
2011         * Scripts/webkitpy/layout_tests/port/chromium.py:
2012
2013 2010-09-23  Sam Weinig  <sam@webkit.org>
2014
2015         Reviewed by Anders Carlsson.
2016
2017         WebKit2 API: Need way to know when a frame is removed from the hierarchy
2018         <rdar://problem/8414062>
2019         https://bugs.webkit.org/show_bug.cgi?id=46432
2020
2021         * MiniBrowser/mac/BrowserWindowController.m:
2022         (didRemoveFrameFromHierarchy):
2023         (-[BrowserWindowController awakeFromNib]):
2024         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2025         (WTR::InjectedBundlePage::InjectedBundlePage):
2026         * WebKitTestRunner/TestController.cpp:
2027         (WTR::TestController::initialize):
2028
2029 2010-09-23  Tony Chang  <tony@chromium.org>
2030
2031         Reviewed by Dimitri Glazkov.
2032
2033         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
2034         https://bugs.webkit.org/show_bug.cgi?id=46426
2035
2036         * DumpRenderTree/chromium/LayoutTestController.cpp:
2037         (LayoutTestController::LayoutTestController):
2038         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2039         * DumpRenderTree/chromium/LayoutTestController.h:
2040
2041 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2042
2043         Reviewed by Nate Chapin.
2044
2045         [GTK] r68199 introduced two test failures
2046         https://bugs.webkit.org/show_bug.cgi?id=46424
2047
2048         Fix a regression handling preference overrides that are attached to boolean properties.
2049
2050         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2051         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
2052         so we must check for that when converting a string to a boolean.
2053
2054 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
2055
2056         Reviewed by David Levin.
2057
2058         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
2059         https://bugs.webkit.org/show_bug.cgi?id=46406
2060
2061         This breaks when the method is called with specified size of data (image data), and the
2062         buffer hasn't yet reached this size.
2063
2064         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
2065           index larger than 0.
2066
2067 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2068
2069         Reviewed by Nate Chapin.
2070
2071         [GTK] Some tests from r68174 fail on the GTK+ bots
2072         https://bugs.webkit.org/show_bug.cgi?id=46396
2073
2074         Simplify LayoutTestController::overridePreference to make it easier for
2075         people unfamiliar with the code to keep the list of preferences up to date.
2076         Add the conversion for enable-hyperlink-auditing.
2077
2078         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2079         (LayoutTestController::overridePreference): Use a simple if-else block to determine
2080         out the property name for overrridePreference. Also simplify the logic for setting
2081         string properties. Add the conversion for enable-hyperlink-auditing.
2082
2083 2010-09-23  Tony Chang  <tony@chromium.org>
2084
2085         Reviewed by David Levin.
2086
2087         [chromium] add caretBrowsingEnabled to WebSettings and DRT
2088         https://bugs.webkit.org/show_bug.cgi?id=46388
2089
2090         * DumpRenderTree/chromium/LayoutTestController.cpp:
2091         (LayoutTestController::overridePreference):
2092         * DumpRenderTree/chromium/WebPreferences.cpp:
2093         (WebPreferences::reset):
2094         (WebPreferences::applyTo):
2095         * DumpRenderTree/chromium/WebPreferences.h:
2096
2097 2010-09-23  Nate Chapin  <japhet@chromium.org>
2098
2099         Reviewed by Darin Fisher.
2100
2101         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
2102         https://bugs.webkit.org/show_bug.cgi?id=30458
2103
2104         * DumpRenderTree/chromium/LayoutTestController.cpp:
2105         (LayoutTestController::overridePreference):
2106         * DumpRenderTree/chromium/WebPreferences.cpp:
2107         (WebPreferences::reset):
2108         (WebPreferences::applyTo):
2109         * DumpRenderTree/chromium/WebPreferences.h:
2110         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2111         (resetDefaultsToConsistentValues):
2112         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2113         (LayoutTestController::overridePreference):
2114
2115 2010-09-21  Stephen White  <senorblanco@chromium.org>
2116
2117         Reviewed by David Levin.
2118
2119         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
2120         https://bugs.webkit.org/show_bug.cgi?id=46208
2121
2122         This flag allows the layout tests to be run with or without accelerated
2123         2D canvas rendering.
2124
2125         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2126         (main):
2127         Declare the new flag string, and check for it on startup.
2128         * DumpRenderTree/chromium/TestShell.cpp:
2129         (TestShell::TestShell):
2130         Add a boolean for the new flag, in order to preserve its value over
2131         preferences reset.
2132         (TestShell::resetWebSettings):
2133         Set the new flag to the stored value on reset.
2134         * DumpRenderTree/chromium/TestShell.h:
2135         (TestShell::setAccelerated2dCanvasEnabled):
2136         Add an accessor for the new flag.
2137         * DumpRenderTree/chromium/WebPreferences.cpp:
2138         (WebPreferences::reset):
2139         Initialize the new flag to false.
2140         (WebPreferences::applyTo):
2141         Copy the flag's value to the WebSettings.
2142         * DumpRenderTree/chromium/WebPreferences.h:
2143         Add the new flag.
2144
2145 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2146
2147         Reviewed by Simon Hausmann.
2148
2149         [Qt] Refactor QtWebKitPlatformPlugin interface
2150
2151         Make it easier to keep source-compability for the
2152         QtWebKitPlatformPlugin interface, and run qmake
2153         on the example (but not build) for convenience. 
2154
2155         https://bugs.webkit.org/show_bug.cgi?id=46345
2156
2157         * Scripts/webkitdirs.pm:
2158
2159 2010-09-23  Adam Barth  <abarth@webkit.org>
2160
2161         Reviewed by Eric Seidel.
2162
2163         Tweak some status messages that Eric thought were confusing
2164         https://bugs.webkit.org/show_bug.cgi?id=46342
2165
2166         * Scripts/webkitpy/tool/commands/queues.py:
2167         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2168
2169 2010-09-22  Adam Barth  <abarth@webkit.org>
2170
2171         Reviewed by Eric Seidel.
2172
2173         Fix comm-queue typo
2174         https://bugs.webkit.org/show_bug.cgi?id=46339
2175
2176         We were missing a "self".  The real problem is that we didn't have an
2177         integration test for the failure case.
2178
2179         * Scripts/webkitpy/tool/commands/queues.py:
2180         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2181
2182 2010-09-22  Adam Barth  <abarth@webkit.org>
2183
2184         Reviewed by Eric Seidel.
2185
2186         commit-queue should log more detailed messages to the QueueStatusServer
2187         https://bugs.webkit.org/show_bug.cgi?id=46333
2188
2189         When I created CommitQueueTask, I removed most of the previous logging.
2190         This patch adds back more detailed logging so folks can see their patch
2191         progress through the queue.
2192
2193         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2194         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2195         * Scripts/webkitpy/tool/commands/queues.py:
2196         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2197
2198 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
2199
2200         Reviewed by Darin Fisher.
2201
2202         [Chromium] User style layout tests don't pass on Chromium
2203         https://bugs.webkit.org/show_bug.cgi?id=46069
2204
2205         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
2206         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
2207         behavior from other ports.
2208
2209         * DumpRenderTree/chromium/LayoutTestController.cpp:
2210         (LayoutTestController::addUserStyleSheet):
2211
2212 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2213
2214         Reviewed by Martin Robinson.
2215
2216         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
2217         https://bugs.webkit.org/show_bug.cgi?id=46303.
2218
2219         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
2220         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
2221         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
2222         property sheet.
2223         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
2224         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
2225         appropriate property sheet for the build types.
2226         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
2227         configuration to use appropriate property sheet for CoreFoundation
2228         and CFLite-style builds.
2229
2230 2010-09-22  Adam Barth  <abarth@webkit.org>
2231
2232         Reviewed by Eric Seidel.
2233
2234         Optimize commit-queue performance for green trees
2235         https://bugs.webkit.org/show_bug.cgi?id=46254
2236
2237         This patch redesigns the controller logic for the commit-queue.  In the
2238         new design, the controller exercises much finer-grained control over
2239         the landing process.  In particular:
2240
2241         - Patches that fail to apply now get rejected almost immediately.
2242         - Patches that fail to build get rejects after two builds (instead of
2243           three builds and one test run).
2244         - Patches that run into a flaky test now get accepted after one build
2245           and two test runs instead of three full build-and-test runs.
2246
2247         The main cost of these optimizations is that we don't find out the tree
2248         has a failing test until the very end of the process, but if the tree
2249         has a busted test, there's not much we can do anyway.  We might as well
2250         burn commit-queue resources spinning optimisticly.
2251
2252         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
2253         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
2254         * Scripts/webkitpy/tool/commands/queues.py:
2255
2256 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2257
2258         Reviewed by Martin Robinson.
2259
2260         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
2261         https://bugs.webkit.org/show_bug.cgi?id=46303.
2262
2263         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
2264         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
2265         WinCairo build.
2266         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
2267         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
2268         build targets that use the new InjectedBundleCFLite.vsprops file.
2269
2270 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2271
2272         Unreviewed, build fix.
2273
2274         Fix bustage of rebaseline-chromium-webkit-tests resulting from
2275         r67974. Really need better unit tests for this tool :(
2276
2277         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2278
2279 2010-09-22  Adam Roben  <aroben@apple.com>
2280
2281         Unbreak test-webkitpy
2282
2283         * Scripts/webkitpy/test/main.py:
2284         (Tester.run_tests): Add a line that mysteriously got deleted.
2285
2286 2010-09-22  Adam Roben  <aroben@apple.com>
2287
2288         Make test-webkitpy test WebKit2's scripts
2289
2290         These scripts can't be in WebKitTools due to limitations of Apple's
2291         build process. But that doesn't mean we can't test them!
2292
2293         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
2294         WebKit2/Scripts
2295
2296         Reviewed by Adam Barth.
2297
2298         * Scripts/test-webkitpy:
2299         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
2300         Now takes an external_package_paths parameter and cleans both webkitpy
2301         and any external packages.
2302         (init): Added an external_package_paths parameter which we pass along
2303         to _clean_packages_with_test.
2304         (top level): Add WebKit2/Scripts/webkit2 as our only external package
2305         and pass it along to init and Tester.run_tests.
2306
2307         * Scripts/webkitpy/test/main.py:
2308         (Tester.run_tests): Added an optional external_package_paths
2309         parameter. We modify sys.path so that the external packages can be
2310         imported, and search for unittest files inside all external packages
2311         in addition to inside webkitpy.
2312
2313 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2314
2315         Reviewed by Tony Chang.
2316
2317         new-run-webkit-tests: r68063 broke linux python tests
2318
2319         Add a missing "from __future__ import with_statement" to this
2320         new file; the perils of testing only on the Mac and by review :(
2321
2322         https://bugs.webkit.org/show_bug.cgi?id=46293
2323
2324         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2325
2326 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2327
2328         Reviewed by Tony Chang.
2329
2330         Add a 'chromium-gpu' set of ports that will test the accelerated
2331         GPU paths. This patch adds:
2332
2333         - support for the '--accelerated-compositing' and
2334           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
2335           'no-' flags)
2336         - adds a new set of Ports that will look under
2337           platform/chromium-gpu-$OS/ for baselines before looking in the
2338           regular chromium search path
2339         - adds a new test_expectations.txt file in platform/chromium-gpu
2340           that skips all but the tests we actually want to run with
2341           acceleration.
2342
2343         This patch will allow us to run both with and without acceleration
2344         and to change the defaults for both the regular and -gpu options
2345         as the code evolves.
2346
2347         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
2348         each test bot.
2349
2350         https://bugs.webkit.org/show_bug.cgi?id=46225
2351
2352         * Scripts/webkitpy/layout_tests/port/chromium.py:
2353         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2354         * Scripts/webkitpy/layout_tests/port/factory.py:
2355         * Scripts/webkitpy/layout_tests/port/webkit.py:
2356
2357 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
2358
2359         Reviewed by Kenneth Rohde Christiansen.
2360
2361         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
2362         https://bugs.webkit.org/show_bug.cgi?id=43988
2363
2364         Runs a web debug server on port specified by QtTestBrowser
2365         argument -remote-inspector-port. Property
2366         _q_webInspectorServerPort of the QWebPage instance will be set
2367         according to the argument. All pages with that property set will
2368         be remotely inspectable.
2369
2370         URL for remote inspection of first QWebPage is
2371             http://localhost:9222/webkit/inspector/inspector.html?page=1
2372         where 1 is the number of the QWebPage instance.
2373
2374         The base URL yields an index page with links to the individual inspectors:
2375             http://localhost:9222/
2376
2377         * QtTestBrowser/launcherwindow.cpp:
2378         (LauncherWindow::init):
2379         * QtTestBrowser/launcherwindow.h:
2380         * QtTestBrowser/main.cpp:
2381         (LauncherApplication::handleUserOptions):
2382
2383 2010-09-22  Adam Roben  <aroben@apple.com>
2384
2385         Fix webkit-patch failure-reason now that build.webkit.org has been
2386         updated
2387
2388         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
2389         every time
2390
2391         Reviewed by Eric Seidel.
2392
2393         * Scripts/webkitpy/common/net/buildbot.py:
2394         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
2395         looking for an element that contains text, then returns it.
2396         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
2397         text out of the cells. This way it doesn't matter whether the cells
2398         have <b> children (as for cells in directory rows) or not (as for
2399         cells in file rows)
2400         (BuildBot._parse_twisted_directory_listing): Look for rows that have
2401         the "directory" or "file" class, rather than rows with any class,
2402         since header rows now have a class attribute.
2403
2404         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2405         (BuildBotTest._example_directory_listing): Updated to more closely
2406         match the markup that build.webkit.org is producing now.
2407
2408 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2409
2410         Unreviewed, build fix.
2411
2412         new-run-webkit-tests: fix bug introduced in r68008 where if you
2413         specify --chromium and no --platform, and you're running on
2414         windows, you use the 'chromium-win' port by default instead of the
2415         version-specific port. This breaks the buildbots.
2416
2417         It will be good for this refactoring to settle down so I can
2418         rewrite the logic for default ports and the unit tests to be
2419         clearer (and the testing more comprehensive).
2420
2421         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2422
2423 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2424
2425         Reviewed by Adam Barth.
2426
2427         Modify the Port interface to take only a series of keyword arguments
2428         in the constructor, and modify Port/factory.get() to accomodate that,
2429         and to accept user=XXX as an argument so we can pass
2430         webkitpy.common.system.user.User objects in.
2431
2432         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
2433         to use the common routine in webkitpy.common.system.user.open_url()
2434         to display HTML files.
2435
2436         There was a routine in the Port interface to do the same thing,
2437         but I see no need for a port-specific hook for this, since it is
2438         something that will always be executed by the host environment
2439         and displaying web pages has nothing to do with running layout tests.
2440
2441         Note that new-run-webkit-tests used to use test_shell to display
2442         the page; this is potentially useful so that you can actually click
2443         from a result to the broken page; however, since DumpRenderTree
2444         doesn't support this functionality, it will be going away eventually.
2445
2446         https://bugs.webkit.org/show_bug.cgi?id=46128
2447
2448         * Scripts/webkitpy/layout_tests/port/base.py:
2449         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2450         * Scripts/webkitpy/layout_tests/port/chromium.py:
2451         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2452         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2453         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2454         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2455         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2456         * Scripts/webkitpy/layout_tests/port/factory.py:
2457         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2458         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2459         * Scripts/webkitpy/layout_tests/port/gtk.py:
2460         * Scripts/webkitpy/layout_tests/port/mac.py:
2461         * Scripts/webkitpy/layout_tests/port/qt.py:
2462         * Scripts/webkitpy/layout_tests/port/test.py:
2463         * Scripts/webkitpy/layout_tests/port/webkit.py:
2464         * Scripts/webkitpy/layout_tests/port/win.py:
2465         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2466         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2467         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2468
2469 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2470
2471         Reviewed by Kenneth Rohde Christiansen.
2472
2473         [EFL] Get fresh theme when running EWebLauncher
2474         https://bugs.webkit.org/show_bug.cgi?id=46210
2475
2476         If user tried to run EWebLauncher outside of the build tree, it would
2477         not find the theme and fallback to the installed one. However, since
2478         EWebLauncher is not installed, we always want to take the theme from
2479         the just compiled source code. If user had never installed WebKit's
2480         EFL port it could even receive a segv since no theme would be found.
2481
2482         Now EWebLauncher does not fallback to the installed theme and CMake
2483         gives as DATA_DIR the directory of the theme it has just built.
2484
2485         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
2486         EWebLauncher.
2487         * EWebLauncher/main.c: Use only the theme from build director. Do not
2488         fallback to others as this could hide real bugs.
2489         (quit):
2490         (browserCreate):
2491         (findThemePath):
2492         (main):
2493
2494 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2495
2496         Unreviewed, build fix.
2497
2498         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
2499         it just confuses it.
2500
2501         https://bugs.webkit.org/show_bug.cgi?id=46230
2502
2503         * Scripts/webkitpy/layout_tests/port/webkit.py:
2504
2505 2010-09-21  Lucas Forschler  <lforschler@apple.com>
2506
2507         Reviewed by Stephanie Lewis.
2508
2509         Make a new buildbot for Leopard Debug Test
2510
2511         * BuildSlaveSupport/build.webkit.org-config/config.json:
2512
2513 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2514
2515         Unreviewed, build fix.
2516
2517         Fix breakage of Chromium Mac DRT port caused by r67905.
2518
2519         https://bugs.webkit.org/show_bug.cgi?id=46230
2520
2521         * Scripts/webkitpy/layout_tests/port/webkit.py:
2522
2523 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2524
2525         Unreviewed, build fix.
2526
2527         Add missing import of 'tempfile'.
2528
2529         * Scripts/webkitpy/layout_tests/port/chromium.py:
2530
2531 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
2532
2533         Reviewed by Ojan Vafai.
2534
2535         new-run-webkit-tests: pull the list of tests from the Port, and
2536            make it possible to run with no actual test files in the filesystem.
2537
2538         This set of changes allows us to delete the special
2539         webkitpy/layout_tests/data directory and test the generic code without
2540         touching the filesystem (except to write results). This speeds up
2541         test-webkitpy substantially.
2542
2543         This also cleans up and removes several code paths in the generic
2544         code and fixes some minor bugs, notably in the test_expectations
2545         parsing, which was previously fragile if the tests weren't present.
2546
2547         We also change the way we diff image results to be able to do so
2548         in memory, without relying on files. This slows down chromium
2549         test_shell, which always writes images to files, but should speed
2550         up DRT and ImageDiff-based implementations slightly.
2551
2552         Note that pulling the list of tests to run from the Port will allow
2553         ports to specify what tests to run as an inclusive list; previously
2554         you could only do this as an exclusive list by using a 
2555         test_expectations file or Skipped files; nothing actually uses this
2556         feature yet and it's unclear if it should be used.
2557
2558         Note that there are no functional changes -- apart from now 
2559         always printing out the location of the checksum file when we are
2560         tracing test runs -- and the total number of lines of non-test code
2561         actually drops by two.
2562
2563         There is some more cleanup that can be done in the Port/Driver 
2564         interface and in some handling of filenames, but I'll save that
2565         for another change.
2566
2567         https://bugs.webkit.org/show_bug.cgi?id=45801
2568
2569         * Scripts/webkitpy/layout_tests/data/*: Removed.
2570             - no longer need special mock layout_tests_directory in the
2571               repository.
2572         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2573             - add code to display missing text files, checksums when tracing
2574             - update to not look at the filesystem directly.
2575         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2576             - add more unit tests
2577         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2578             - remove tests_are_present flag
2579             - update with changes in Port interface - no longer access
2580               the filesystem directly, although we still use os.path for
2581               filename manipulation.
2582         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2583             - add more unit tests
2584         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
2585             - renamed to port/test_files.py
2586         * Scripts/webkitpy/layout_tests/port/base.py:
2587             - change diff_image() to expect actual image data, not filenames
2588             - add expected_checksum(), expected_image(), expected_text() to
2589               return the content of the files so that we don't need a filesystem
2590             - add path_exists(), path_isdir() for filesystem-like access.
2591             - add test_dirs() to keep clobber-test-results from needing to
2592               actually look at a real layout tests dir
2593             - add tests() to return the list of tests to run on the port
2594               (calls port/test_files to do the work).
2595             - add update_baseline() to be able to save new baselines
2596             - add uri_to_test_name() from port/dryrun.py so we can easily check
2597               filename_to_uri()
2598         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2599             - add more unit tests
2600         * Scripts/webkitpy/layout_tests/port/chromium.py:
2601             - change diff_image() to accept image content, not filenames.
2602               This will be slower for test_shell/image_diff, but faster
2603               for DRT/ImageDiff.
2604         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2605             - add more unit tests
2606         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2607             - simplify greatly
2608         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2609             - add more unit tests
2610         * Scripts/webkitpy/layout_tests/port/test.py:
2611             - massive rewrite to use in-script list of tests and expectations
2612         * Scripts/webkitpy/layout_tests/port/test_files.py:
2613             - rename from layout_package/test_files.
2614         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2615             - add unit tests
2616         * Scripts/webkitpy/layout_tests/port/webkit.py:
2617             - update diff_image() to take image contents, not files. Should
2618               make things slightly faster.
2619         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2620             - update with changes to diff_image()
2621         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2622             - update with changes to diff_image()
2623         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2624             - remove tests_are_present from test_expectations
2625             - pull the list of tests from port.tests() instead
2626               of calling test_files.py directly.
2627         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2628             - update unit tests
2629         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2630             - update with changes to 
2631         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2632             - update with change in Port interface
2633         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2634             - update with change in Port interface
2635         * Scripts/webkitpy/style/checkers/test_expectations.py:
2636             - remove the tests_are_present flag
2637
2638 2010-09-21  Anders Carlsson  <andersca@apple.com>
2639
2640         Disable logging.
2641
2642         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2643
2644 2010-09-21  Tony Chang  <tony@chromium.org>
2645
2646         Reviewed by Kent Tamura.
2647
2648         add a script for running webkit_unit_tests
2649         https://bugs.webkit.org/show_bug.cgi?id=46014
2650
2651         * Scripts/run-chromium-webkit-unit-tests: Added.
2652
2653 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
2654
2655         Reviewed by Martin Robinson.
2656
2657         Fix linking problems on Windows.
2658         https://bugs.webkit.org/show_bug.cgi?id=45844
2659
2660         * GNUmakefile.am: link the executables with winmm.dll
2661
2662 2010-09-21  Adam Barth  <abarth@webkit.org>
2663
2664         Reviewed by Eric Seidel.
2665
2666         feeder-queue svn updates more often than needed
2667         https://bugs.webkit.org/show_bug.cgi?id=46171
2668
2669         We don't need to poll SVN every time we feed the feeders.  Rather, we
2670         can count on the wrapper shell script to auto-update the queue.
2671
2672         * Scripts/webkitpy/tool/commands/queues.py:
2673         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2674
2675 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2676
2677         Reviewed by Andreas Kling.
2678
2679         [Qt] Add robot loader timeout and extra time options.
2680         https://bugs.webkit.org/show_bug.cgi?id=46172
2681
2682         [-robot-timeout <s>]: Load the next page after s seconds if the current
2683         page didn't finish loading.
2684         [-robot-extra-time <s>]: Wait s seconds after the current page finished
2685         loading before loading the next one. This should allow some time for the
2686         page's JavaScript to execute.
2687
2688         * QtTestBrowser/launcherwindow.cpp:
2689         (LauncherWindow::applyPrefs):
2690         * QtTestBrowser/main.cpp:
2691         (LauncherApplication::robotTimeout):
2692         (LauncherApplication::robotExtraTime):
2693         (LauncherApplication::LauncherApplication):
2694         (LauncherApplication::handleUserOptions):
2695         (main):
2696         * QtTestBrowser/urlloader.cpp:
2697         (UrlLoader::UrlLoader):
2698         (UrlLoader::loadNext):
2699         (UrlLoader::loadUrlList):
2700         * QtTestBrowser/urlloader.h:
2701
2702 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
2703
2704         Unreviewed.
2705
2706         Adding myself to the committers list.
2707
2708         * Scripts/webkitpy/common/config/committers.py:
2709
2710 2010-09-20  Philippe Normand  <pnormand@igalia.com>
2711
2712         Reviewed by Eric Carlson.
2713
2714         [GTK] enhanced context menu for media elements
2715         https://bugs.webkit.org/show_bug.cgi?id=45021
2716
2717         EventSender::contextClick() now returns an array of js
2718         objects. Each object has a title property and a click() method.
2719
2720         * DumpRenderTree/gtk/EventSender.cpp:
2721         (getMenuItemTitleCallback):
2722         (setMenuItemTitleCallback):
2723         (menuItemClickCallback):
2724         (getMenuItemClass):
2725         (contextClickCallback):
2726
2727 2010-09-20  Hayato Ito  <hayato@chromium.org>
2728
2729         Unreviewed.
2730         Adding myself to the committers list.
2731
2732         * Scripts/webkitpy/common/config/committers.py:
2733
2734 2010-09-20  Adam Barth  <abarth@webkit.org>
2735
2736         Reviewed by Eric Seidel.
2737
2738         The tool member variable should be called _tool
2739         https://bugs.webkit.org/show_bug.cgi?id=46160
2740
2741         Created by find-and-replace.
2742
2743         * Scripts/webkitpy/tool/commands/download.py:
2744         * Scripts/webkitpy/tool/commands/openbugs.py:
2745         * Scripts/webkitpy/tool/commands/queries.py:
2746         * Scripts/webkitpy/tool/commands/queues.py:
2747         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2748         * Scripts/webkitpy/tool/commands/rebaseline.py:
2749         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2750         * Scripts/webkitpy/tool/commands/upload.py:
2751         * Scripts/webkitpy/tool/multicommandtool.py:
2752
2753 2010-09-20  Adam Barth  <abarth@webkit.org>
2754
2755         I ran the tests before landing but ignored the fact that they failed.  :(
2756
2757         * Scripts/webkitpy/tool/commands/queues.py:
2758
2759 2010-09-20  Adam Barth  <abarth@webkit.org>
2760
2761         Reviewed by Eric Seidel.
2762
2763         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
2764         https://bugs.webkit.org/show_bug.cgi?id=46141
2765
2766         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
2767         list of work items on the status server.  The individual commit-cluster
2768         nodes then grab the patches from the server and process them.
2769
2770         * Scripts/webkitpy/tool/bot/feeders.py: Added.
2771         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
2772         * Scripts/webkitpy/tool/commands/queues.py:
2773         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2774         * Scripts/webkitpy/tool/commands/queuestest.py:
2775
2776 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
2777
2778         Reviewed by Darin Adler.
2779
2780         build-webkit: Add support for CMake build system
2781         https://bugs.webkit.org/show_bug.cgi?id=44979
2782
2783         * Scripts/build-webkit: Add "--efl" command-line option to build the
2784         EFL port of WebKit.
2785         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
2786         buildEflCMakeProject() subroutines.
2787
2788 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
2789
2790         Reviewed by Ojan Vafai.
2791
2792         new-run-webkit-tests: refactor command line args getting passed to DRT
2793
2794         This change cleans up some argument parsing between functions to get
2795         rid of some overlapping data structures. There should be no functional
2796         changes in this patch; it is pure refactoring in preparation for
2797         landing the Chrome GPU port and adding a generic way to pass
2798         args to DRT/TestShell.
2799
2800         https://bugs.webkit.org/show_bug.cgi?id=46135
2801
2802         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2803           - pass the options argument explicitly to the threads and drivers,
2804             also consolidate the passing of options to the driver.
2805           - pass options directly to process_output() to remove a couple
2806             parameters (minor cleanup).
2807         * Scripts/webkitpy/layout_tests/port/base.py:
2808           - pass the options argument to Port.create_driver().
2809         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2810           - update Port.create_driver() test
2811         * Scripts/webkitpy/layout_tests/port/chromium.py:
2812           - pass the options argument to Port.create_driver(), and clean up
2813             building of the cmd line for DRT.
2814         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2815           - pass the options argument to Port.create_driver()
2816         * Scripts/webkitpy/layout_tests/port/test.py:
2817           - pass the options argument to Port.create_driver()
2818         * Scripts/webkitpy/layout_tests/port/webkit.py:
2819           - pass the options argument to Port.create_driver(), and clean up
2820             building of the cmd line for DRT.
2821         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2822           - consolidate args in _get_dump_render_tree_args and rename to
2823             _get_test_args(); move all of the command-line args to the
2824             Port implementations.
2825
2826 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
2827
2828         Revert change which was accidentally committed along with some expectation changes.
2829
2830         * Scripts/webkitpy/layout_tests/port/base.py:
2831
2832 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2833
2834         Reviewed by Adam Barth.
2835
2836         Add explicit --force-patch flag to webkitpy tools
2837         https://bugs.webkit.org/show_bug.cgi?id=46103
2838         
2839         It wasn't obvious until I read the applypatch.py source code that
2840         --non-interfactive implies passing --force to patch. Add --force-patch
2841         as an alias to the flag, so that this behavior is more discoverable.
2842
2843         * Scripts/webkitpy/tool/steps/applypatch.py:
2844         * Scripts/webkitpy/tool/steps/options.py:
2845
2846 2010-09-20  Eric Seidel  <eric@webkit.org>
2847
2848         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
2849
2850         commit-queue can't land patches
2851         https://bugs.webkit.org/show_bug.cgi?id=46138
2852
2853         Add a line of code I forgot in my last commit.
2854
2855         * Scripts/webkitpy/common/net/bugzilla.py:
2856         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2857
2858 2010-09-20  Adam Barth  <abarth@webkit.org>
2859
2860         Reviewed by Eric Seidel.
2861
2862         The commit-cluster bots still race to lock patch_ids
2863         https://bugs.webkit.org/show_bug.cgi?id=46130
2864
2865         It turns out we need to use a transaction object to make the
2866         read/modify/write lock operation atomic.  From reading the AppEngine
2867         documentation, I think this patch should do what we want.  It's hard to
2868         test locally because the test instance isn't distributed in the same
2869         way the production instance is.
2870
2871         * QueueStatusServer/handlers/nextpatch.py:
2872         * QueueStatusServer/model/activeworkitems.py: Added.
2873
2874 2010-09-20  Andy Estes  <aestes@apple.com>
2875
2876         Reviewed by Adam Barth.
2877
2878         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
2879         https://bugs.webkit.org/show_bug.cgi?id=40961
2880
2881         Implement WebKitUsePreHTML5ParserQuirks preference.
2882
2883         * DumpRenderTree/mac/DumpRenderTree.mm:
2884         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
2885         to false after a test finishes.
2886
2887 2010-09-20  Adam Roben  <aroben@apple.com>
2888
2889         Windows build fix
2890
2891         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
2892         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
2893         we'll pick up the most recent versions of the headers.
2894
2895 2010-09-20  Eric Seidel  <eric@webkit.org>
2896
2897         Reviewed by Adam Barth.
2898
2899         commit-queue should check commit-queue+ again just before committing
2900         https://bugs.webkit.org/show_bug.cgi?id=32679
2901
2902         Added a _revalidate_patch check, right before landing.
2903
2904         Since _revalidate_patch passes the patch_id from the work item
2905         back to bugzilla, I had to fix all of the previous queue tests to
2906         use valid attachment ids (that's the majority of this change).
2907
2908         In order to validate that the bug was still open, I had to teach
2909         bugzilla.Bug about open/closed states.
2910
2911         * Scripts/webkitpy/common/net/bugzilla.py:
2912         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2913         * Scripts/webkitpy/tool/commands/queues.py:
2914         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2915         * Scripts/webkitpy/tool/commands/queuestest.py:
2916         * Scripts/webkitpy/tool/mocktool.py:
2917
2918 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2919
2920         Unreviewed.
2921
2922         Adding myself as a comitter.
2923
2924         * Scripts/webkitpy/common/config/committers.py:
2925
2926 2010-09-20  Adam Barth  <abarth@webkit.org>
2927
2928         Reviewed by Eric Seidel.
2929
2930         Two instances of commit-queue try to process the same patch
2931         https://bugs.webkit.org/show_bug.cgi?id=46113
2932
2933         This patch makes next-patch atomic so that the server won't vend the
2934         same patch twice in the same hour.
2935
2936         * QueueStatusServer/handlers/nextpatch.py:
2937
2938 2010-09-20  Adam Roben  <aroben@apple.com>
2939
2940         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
2941
2942         We were previously trying to use a CFRunLoopTimer, but since Windows
2943         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
2944         Windows-style timer on Windows.
2945
2946         I also replaced all uses of "watchdog" with "watchdog timer".
2947
2948         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
2949         watchdog timer doesn't work on Windows
2950
2951         Reviewed by Anders Carlsson.
2952
2953         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2954         (WTR::InjectedBundlePage::dump): Updated for rename.
2955
2956         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
2957         platform-specific functions.
2958         (WTR::LayoutTestController::LayoutTestController): Added call to
2959         platformInitialize.
2960         (WTR::LayoutTestController::waitUntilDone): Changed to call
2961         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
2962         right in this function.
2963         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
2964         rename.
2965
2966         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
2967         members needed to support the watchdog timer abstraction. Replaced
2968         some "watchdog"s with "watchdog timer".
2969
2970         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
2971         Added.
2972         (WTR::LayoutTestController::platformInitialize): Does nothing on this
2973         platform.
2974         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
2975         from LayoutTestController.cpp and changed to use an early return.
2976         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
2977         LayoutTestController.cpp.
2978         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2979         Moved code here from LayoutTestController::waitUntilDone and changed
2980         to use an early return.
2981
2982         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2983         Added.
2984         (WTR::LayoutTestController::platformInitialize): Initialize our
2985         watchdog timer.
2986         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
2987         Kills and clears the watchdog timer.
2988         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
2989         LayoutTestController member function of the same name.
2990         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2991         Added. Sets up the timer if it isn't already set.
2992
2993         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
2994         LayoutTestControllerMac.mm.
2995
2996         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
2997         LayoutTestControllerWin.cpp.
2998
2999 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
3000
3001         Reviewed by Daniel Bates.
3002
3003         [GTK] fast/forms/listbox-selection.html fails
3004         https://bugs.webkit.org/show_bug.cgi?id=45942
3005
3006         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
3007         strings in keyDownCallback.
3008
3009         * DumpRenderTree/gtk/EventSender.cpp:
3010         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
3011         modifier parsing logic.
3012
3013 2010-09-19  Sam Weinig  <sam@webkit.org>
3014
3015         Reviewed by Anders Carlsson.
3016
3017         WebKit2 decidePolicyForNavigationAction should include mouse button information
3018         <rdar://problem/8413165>
3019         https://bugs.webkit.org/show_bug.cgi?id=46060
3020
3021         * MiniBrowser/mac/BrowserWindowController.m:
3022         (decidePolicyForNavigationAction):
3023         (decidePolicyForNewWindowAction):
3024
3025 2010-09-19  Daniel Bates  <dbates@rim.com>
3026
3027         Reviewed by Martin Robinson.
3028
3029         Add unit tests for diffs that delete or modify a change log entry
3030         or describe changes that are far apart
3031         https://bugs.webkit.org/show_bug.cgi?id=46046
3032
3033         Add additional unit tests to test change log diffs that contain
3034         deletions or changes that are far apart from each other in the
3035         ChangeLog file.
3036
3037         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3038           - Added the following unit tests:
3039           "fixChangeLogPatch: [no change] In-place change."
3040           "fixChangeLogPatch: [no change] Remove first entry."
3041           "fixChangeLogPatch: [no change] Remove entry in the middle."
3042           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
3043
3044 2010-09-19  Sam Weinig  <sam@webkit.org>
3045
3046         Reviewed by Anders Carlsson.
3047
3048         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
3049         https://bugs.webkit.org/show_bug.cgi?id=46054
3050
3051         The new one acts like WKBundleNodeHandleRef and allows for getting a
3052         wrapper in a specific world for the handle.
3053
3054         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3055         (WTR::propertyValue):
3056         (WTR::propertyValueDouble):
3057         (WTR::propertyValueInt):
3058         (WTR::numericWindowPropertyValue):
3059         (WTR::toStr):
3060         (WTR::InjectedBundlePage::shouldBeginEditing):
3061         (WTR::InjectedBundlePage::shouldEndEditing):
3062         (WTR::InjectedBundlePage::shouldInsertNode):
3063         (WTR::InjectedBundlePage::shouldInsertText):
3064         (WTR::InjectedBundlePage::shouldDeleteRange):
3065         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3066         (WTR::InjectedBundlePage::shouldApplyStyle):
3067         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3068
3069 2010-09-19  Kent Tamura  <tkent@chromium.org>
3070
3071         Unreviewed. Fix WebGL test regressions by r67809.
3072
3073         * DumpRenderTree/chromium/WebPreferences.cpp:
3074         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
3075
3076 2010-09-19  Kent Tamura  <tkent@chromium.org>
3077
3078         Reviewed by Adam Barth.
3079
3080         [DRT/Chromium] Fix a WebSettings handling bug
3081         https://bugs.webkit.org/show_bug.cgi?id=45945
3082
3083         Before this change, Chromium DRT reset WebSettings for every new
3084         window. It was wrong.
3085         If new window is not the first one, we have to apply the same
3086         settings as the first window.  So, we introduce WebPreference to
3087         store the current settings, and apply it to new windows. It's same
3088         as test_shell's behavior.
3089
3090         * DumpRenderTree/DumpRenderTree.gypi:
3091         * DumpRenderTree/chromium/LayoutTestController.cpp:
3092           Use WebPreferences instead of WebSettings.
3093         (LayoutTestController::setUserStyleSheetEnabled):
3094         (LayoutTestController::setUserStyleSheetLocation):
3095         (LayoutTestController::setAuthorAndUserStylesEnabled):
3096         (LayoutTestController::setPopupBlockingEnabled):
3097         (LayoutTestController::disableImageLoading):
3098         (LayoutTestController::setJavaScriptCanAccessClipboard):
3099         (LayoutTestController::setXSSAuditorEnabled):
3100         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
3101         (LayoutTestController::setAllowFileAccessFromFileURLs):
3102         (LayoutTestController::overridePreference):
3103         (LayoutTestController::setEditingBehavior):
3104         * DumpRenderTree/chromium/TestShell.cpp:
3105         (TestShell::resetWebSettings): Use WebPreferences.
3106         (TestShell::runFileTest): ditto.
3107         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
3108         * DumpRenderTree/chromium/TestShell.h:
3109         (TestShell::preferences):
3110         (TestShell::applyPreferences):
3111         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
3112         * DumpRenderTree/chromium/WebPreferences.h: Added.
3113
3114 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
3115
3116         Reviewed by David Levin.
3117
3118         update-webkit --chromium spitting out a spurious error
3119         https://bugs.webkit.org/show_bug.cgi?id=45868
3120
3121         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
3122
3123 2010-09-18  Sam Weinig  <sam@webkit.org>
3124
3125         Reviewed by Dan Bernstein.
3126
3127         Improve/unify the PageLoadClient interfaces
3128         https://bugs.webkit.org/show_bug.cgi?id=46043
3129
3130         * MiniBrowser/mac/BrowserWindowController.m:
3131         (didStartProvisionalLoadForFrame):
3132         (didReceiveServerRedirectForProvisionalLoadForFrame):
3133         (didFailProvisionalLoadWithErrorForFrame):
3134         (didCommitLoadForFrame):
3135         (didFinishDocumentLoadForFrame):
3136         (didFinishLoadForFrame):
3137         (didFailLoadWithErrorForFrame):
3138         (didReceiveTitleForFrame):
3139         (didFirstLayoutForFrame):
3140         (didFirstVisuallyNonEmptyLayoutForFrame):
3141         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3142         (WTR::InjectedBundlePage::InjectedBundlePage):
3143         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3144         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3145         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3146         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3147         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3148         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3149         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3150         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3151         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3152         * WebKitTestRunner/TestController.cpp:
3153         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3154         (WTR::TestController::didFinishLoadForFrame):
3155         * WebKitTestRunner/TestController.h:
3156
3157 2010-09-17  Eric Seidel  <eric@webkit.org>
3158
3159         Unreviewed.  Adding a shell script I use to run the
3160         commit-queue. Now that multiple machines run the cq,
3161         it makes sense to share the script between them.
3162
3163         * EWSTools/start-commit-queue.sh: Added.
3164
3165 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
3166
3167         Reviewed by Jon Honeycutt.
3168
3169         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
3170         slightly harder to read, so this reverts the previous background colors for various
3171         states, making it easier to read.
3172
3173         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3174         (.success):
3175         (.failure):
3176         (.warnings):
3177         (.exception):
3178         (.start,.running,td.building):
3179         (.offline,td.offline):
3180
3181 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3182
3183         Unreviewed, rolling out r67692.
3184         http://trac.webkit.org/changeset/67692
3185         https://bugs.webkit.org/show_bug.cgi?id=46011
3186
3187         broke layout test dashboard (Requested by johnny_g on
3188         #webkit).
3189
3190         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3191         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3192         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3193
3194 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
3195
3196         Reviewed by Oliver Hunt.
3197
3198         Style bot complains about cairo forward declaration naming
3199         https://bugs.webkit.org/show_bug.cgi?id=45867
3200
3201         Exclude Cairo forward declarations from indentifiers with underscores checks.
3202
3203         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
3204         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3205
3206 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
3207
3208         Reviewed by Ojan Vafai.
3209
3210         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
3211         https://bugs.webkit.org/show_bug.cgi?id=45408
3212
3213         This change also tries to remove duplicated upload_results_json methods
3214         in run_webkit_tests.py and json_results_generator.py.
3215
3216         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3217         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3218         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3219
3220 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
3221
3222         Reviewed by Andreas Kling.
3223
3224         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
3225
3226         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
3227         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
3228         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
3229         all page specific stuff to the UI.
3230
3231         * QtTestBrowser/launcherwindow.cpp:
3232         (LauncherWindow::initializeView):
3233         * QtTestBrowser/mainwindow.cpp:
3234         (MainWindow::MainWindow):
3235         (MainWindow::buildUI):
3236         (MainWindow::setPage):
3237         * QtTestBrowser/mainwindow.h:
3238
3239 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3240
3241         Reviewed by Andreas Kling.
3242
3243         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
3244
3245         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
3246         object will move to the qgraphicsscene instead of the qgraphicsview.
3247
3248         * QtTestBrowser/webview.cpp:
3249         (WebViewGraphicsBased::setPage):
3250         (WebViewGraphicsBased::setResizesToContents):
3251         (WebViewGraphicsBased::resizeEvent):
3252         (WebViewGraphicsBased::animatedFlip):
3253         * QtTestBrowser/webview.h:
3254         (WebViewGraphicsBased::setItemCacheMode):
3255         (WebViewGraphicsBased::itemCacheMode):
3256
3257 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3258
3259         Reviewed by Andreas Kling.
3260
3261         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
3262
3263         We usually separate methods whose body are larger than a few lines from the class definition.
3264
3265         * QtTestBrowser/webview.h:
3266         (WebViewGraphicsBased::yRotation):
3267         (WebViewGraphicsBased::setYRotation):
3268
3269 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3270
3271         Reviewed by Andreas Kling.
3272
3273         Make initializeView method of LauncherWindow private.
3274
3275         No one else needs to be able to call it but LauncherWindow.
3276         Also moving the declation of isGraphicsBased method down in the same file, in order
3277         to better group related methods.
3278
3279         * QtTestBrowser/launcherwindow.h:
3280
3281 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3282
3283         Reviewed by Andreas Kling.
3284
3285         Make the getter 'page' method of MainWindow const.
3286
3287         * QtTestBrowser/mainwindow.cpp:
3288         (MainWindow::page):
3289         * QtTestBrowser/mainwindow.h:
3290
3291 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3292
3293         Reviewed by Andreas Kling.
3294
3295         Remove useless parameter from MainWindow class' constructor.
3296
3297         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
3298         not referred in the constructor body and does not make much sense.
3299
3300         * QtTestBrowser/mainwindow.cpp:
3301         (MainWindow::MainWindow):
3302         * QtTestBrowser/mainwindow.h:
3303
3304 2010-09-15  Tony Chang  <tony@chromium.org>
3305
3306         Reviewed by Kent Tamura.
3307
3308         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
3309         https://bugs.webkit.org/show_bug.cgi?id=42151
3310
3311         * DumpRenderTree/chromium/LayoutTestController.cpp:
3312         (LayoutTestController::LayoutTestController):
3313         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3314         (WorkItemLoadHTMLString::run):
3315         (LayoutTestController::queueLoadHTMLString):
3316         (LayoutTestController::reset):
3317         (LayoutTestController::setDeferMainResourceDataLoad):
3318         * DumpRenderTree/chromium/LayoutTestController.h:
3319         (LayoutTestController::deferMainResourceDataLoad):
3320         * DumpRenderTree/chromium/WebViewHost.cpp:
3321         (WebViewHost::didCreateDataSource):
3322
3323 2010-09-16  Adrienne Walker  <enne@google.com>
3324
3325         Reviewed by Kenneth Russell.
3326
3327         Add script to synchronize WebKit and Khronos WebGL tests
3328         https://bugs.webkit.org/show_bug.cgi?id=42336
3329
3330         * Scripts/update-webgl-conformance-tests: Added.
3331         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
3332         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
3333
3334 2010-09-16  Sam Weinig  <sam@webkit.org>
3335
3336         Reviewed by Anders Carlsson.
3337
3338         Add support for sending synchronous messages from the InjectedBundle to the WKContext
3339         <rdar://problem/8365320>
3340         https://bugs.webkit.org/show_bug.cgi?id=44785
3341
3342         * MiniBrowser/mac/AppDelegate.m:
3343         (didReceiveSynchronousMessageFromInjectedBundle):
3344         (-[BrowserAppDelegate init]):
3345         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3346         (didCreatePage):
3347         * WebKitTestRunner/TestController.cpp:
3348         (WTR::TestController::initialize):
3349
3350 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
3351
3352         Reviewed by Andreas Kling.
3353
3354         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
3355         https://bugs.webkit.org/show_bug.cgi?id=45885
3356
3357         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
3358
3359         * QtTestBrowser/launcherwindow.cpp:
3360         (LauncherWindow::screenshot):
3361
3362 2010-09-16  Anders Carlsson  <andersca@apple.com>
3363
3364         Fix clang++ build.
3365
3366         * MiniBrowser/mac/BrowserWindowController.m:
3367         (-[BrowserWindowController zoomIn:]):
3368         (-[BrowserWindowController zoomOut:]):
3369         (-[BrowserWindowController resetZoom:]):
3370         Remove trailing semicolons.
3371
3372 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3373
3374         Unreviewed, rolling out r67628.
3375         http://trac.webkit.org/changeset/67628
3376         https://bugs.webkit.org/show_bug.cgi?id=45904
3377
3378         broke the build (Requested by eric_carlson on #webkit).
3379
3380         * DumpRenderTree/gtk/EventSender.cpp:
3381         (contextClickCallback):
3382
3383 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
3384
3385         Unreviewed.
3386
3387         Adding myself as a comitter.
3388
3389         * Scripts/webkitpy/common/config/committers.py:
3390
3391 2010-09-15  Philippe Normand  <pnormand@igalia.com>
3392
3393         Reviewed by Eric Carlson.
3394
3395         [GTK] enhanced context menu for media elements
3396         https://bugs.webkit.org/show_bug.cgi?id=45021
3397
3398         EventSender::contextClick() now returns an array of js
3399         objects. Each object has a title property and a click() method.
3400
3401         * DumpRenderTree/gtk/EventSender.cpp:
3402         (getMenuItemTitleCallback):
3403         (setMenuItemTitleCallback):
3404         (menuItemClickCallback):
3405         (getMenuItemClass):
3406         (contextClickCallback):
3407
3408 2010-09-14  Philippe Normand  <pnormand@igalia.com>
3409
3410         Reviewed by Eric Carlson and Martin Robinson.
3411
3412         [GTK] eventSender.contextClick() should return the contents of the context menu
3413         https://bugs.webkit.org/show_bug.cgi?id=39102
3414
3415         Make the eventSender use the new private WebKitGtk+ API to
3416         retrieve the context-menu item titles and store them in an array.
3417
3418         * DumpRenderTree/gtk/EventSender.cpp:
3419         (contextClickCallback):
3420
3421 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
3422
3423         Reviewed by Jian Li.
3424
3425         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
3426         https://bugs.webkit.org/show_bug.cgi?id=45798
3427
3428         * Scripts/build-webkit:
3429
3430 2010-09-16  Robert Hogan  <robert@webkit.org>
3431
3432         Reviewed by Antonio Gomes.
3433
3434         [Qt] Support globalhistory tests
3435         https://bugs.webkit.org/show_bug.cgi?id=45774
3436
3437         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3438         (WebCore::isGlobalHistoryTest):
3439         (WebCore::DumpRenderTree::open):
3440         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3441         (LayoutTestController::reset):
3442         (LayoutTestController::dumpHistoryCallbacks):
3443         (LayoutTestController::removeAllVisitedLinks):
3444         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3445
3446 2010-09-10  Tony Chang  <tony@chromium.org>
3447
3448         Reviewed by Eric Seidel.
3449
3450         deduplicate-tests should be runnable from any WebKit directory
3451         https://bugs.webkit.org/show_bug.cgi?id=44709
3452
3453         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3454         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3455
3456 2010-09-15  Tony Chang  <tony@chromium.org>
3457
3458         Reviewed by Kent Tamura.
3459
3460         [chromium] sort testing methods in DRT
3461         https://bugs.webkit.org/show_bug.cgi?id=45850
3462
3463         * DumpRenderTree/chromium/EventSender.cpp:
3464         (EventSender::EventSender):
3465         * DumpRenderTree/chromium/LayoutTestController.cpp:
3466         (LayoutTestController::LayoutTestController):
3467         * DumpRenderTree/chromium/TextInputController.cpp:
3468         (TextInputController::TextInputController):
3469
3470 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3471
3472         Reviewed by Adam Barth.
3473
3474         CQ status shows items out of order
3475         https://bugs.webkit.org/show_bug.cgi?id=45846
3476         
3477         Only group consecutive status items with the same patch ID into the same
3478         group, so that overall item ordering is preserved.
3479         
3480         Also don't indent status items that only have a single item in their
3481         group.
3482
3483         * QueueStatusServer/handlers/queuestatus.py:
3484         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
3485         * QueueStatusServer/templates/queuestatus.html:
3486
3487 2010-09-15  Eric Seidel  <eric@webkit.org>
3488
3489         Reviewed by Adam Barth.
3490
3491         Add queue start/stop messages
3492         https://bugs.webkit.org/show_bug.cgi?id=45853
3493
3494         I ended up needing to clean up a bunch of our unit testing
3495         in order to test this new code path nicely.
3496
3497         There are also a few PEP8 changes needed to pass check-webkit-style.
3498
3499         * Scripts/webkitpy/tool/bot/queueengine.py:
3500         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3501         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3502         * Scripts/webkitpy/tool/commands/queues.py:
3503         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3504         * Scripts/webkitpy/tool/commands/queuestest.py:
3505         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3506
3507 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
3508
3509         https://bugs.webkit.org/show_bug.cgi?id=45849
3510         WKURLCreateWithCFURL crashes with null url
3511         
3512         Fix MiniBrowser crash when the url is not parseable.
3513
3514         * MiniBrowser/mac/BrowserWindowController.m:
3515         (-[BrowserWindowController fetch:]):
3516
3517 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
3518
3519         Unreviewed.
3520
3521         Adding myself to the committers list.
3522
3523         * Scripts/webkitpy/common/config/committers.py:
3524
3525 2010-09-14  Eric Seidel  <eric@webkit.org>
3526
3527         Reviewed by Adam Barth.
3528
3529         Make it possible to run more than one commit-queue instance
3530         https://bugs.webkit.org/show_bug.cgi?id=45786
3531
3532         Mostly we need to make sure the two (or more) instances get
3533         different patches to work on.  To do this, I re-worked
3534         the code responsible for getting the next work item to
3535         round trip through the status server.  The status server only
3536         vends patches from the work items list, only if those patches
3537         have not had status reported for them in the last hour.
3538
3539         This is another step towards making all queues go through the
3540         status server, thus making it possible to run more than one
3541         instance of various EWS bots (as requested in bug 44292).
3542
3543         The webkitpy changes are already covered by existing unit tests.
3544         The QueueStatusSever sadly has no testing infrastructure yet. :(
3545
3546         * QueueStatusServer/handlers/nextpatch.py: Added.
3547         * QueueStatusServer/index.yaml:
3548         * QueueStatusServer/main.py:
3549         * Scripts/webkitpy/tool/commands/queues.py:
3550
3551 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3552
3553         Reviewed by Tony Chang.
3554
3555         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
3556         https://bugs.webkit.org/show_bug.cgi?id=45791
3557
3558         Force filenames to be raw bytes before running difflib.unified_diff.
3559
3560         * Scripts/webkitpy/layout_tests/port/base.py:
3561         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3562
3563 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
3564
3565         Reviewed by Tor Arne Vestbø.
3566
3567         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
3568         https://bugs.webkit.org/show_bug.cgi?id=35247
3569
3570         The main issue when changing the views is that the plugins and any other components that
3571         depend on view specific attributes such as the native window id are not teared down.
3572         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
3573         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
3574         we decided to work around this in QtTestBrowser by making toggling between QWebView
3575         and QGraphicsWebView also re-create the page.
3576
3577         * QtTestBrowser/launcherwindow.cpp:
3578         (LauncherWindow::initializeView):
3579         * QtTestBrowser/mainwindow.h:
3580
3581 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
3582
3583         Reviewed by Adam Barth.
3584
3585         Send webkit accessibility notifications to Chromium
3586         https://bugs.webkit.org/show_bug.cgi?id=45156
3587