2007-12-14 Juan A. Suarez Romero <jasuarez@igalia.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
2
3         Reviewed by Alp Toker.
4
5         http://bugs.webkit.org/show_bug.cgi?id=16042
6         [GTK] Eliminate webkit_init()
7
8         Moving webkit initialization to WebView class init.
9
10         * DumpRenderTree/gtk/DumpRenderTree.cpp:
11         (main):
12         * GtkLauncher/main.c:
13         (main):
14
15 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
16
17         Reviewed by Alp Toker.
18
19         http://bugs.webkit.org/show_bug.cgi?id=13542
20         gdklauncher doesnt change URL in adress GTKEntry.
21
22         * GtkLauncher/main.c:
23         (load_commit_cb): added
24         (title_change_cb):
25         (create_browser):
26
27 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
28
29         Reviewed by Adam Roben.
30
31         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
32
33         * FindSafari/FindSafari.cpp:
34         (_tmain):
35
36 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
37
38         Reviewed by Adam Roben.
39
40         http://bugs.webkit.org/show_bug.cgi?id=16315
41         FindSafari needs a path-only option.
42
43         * FindSafari/FindSafari.cpp:
44         (_tmain):
45
46 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
47
48         Reviewed by Darin.
49
50         http://bugs.webkit.org/show_bug.cgi?id=16462
51         REGRESSION: access keys broken on Windows
52
53         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
54         if Alt is pressed.
55
56 2007-12-15  Sam Weinig  <sam@webkit.org>
57
58         Reviewed by Mark Rowe.
59
60         Fix urlSuitableForTestResult to correctly identify wstring::npos as
61         the case when wstring.find doesn't find anything.
62
63         * DumpRenderTree/win/DumpRenderTree.cpp:
64         (urlSuitableForTestResult):
65
66 2007-12-15  Alp Toker  <alp@atoker.com>
67
68         GTK+ DRT build fix for GLib < 2.14.
69
70         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
71         (LayoutTestController::setWaitToDump):
72
73 2007-12-05  Mark Rowe  <mrowe@apple.com>
74
75         Reviewed by Alp Toker.
76
77         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
78         many layout tests from hanging while waiting on user responses to dialogs.
79
80         * DumpRenderTree/gtk/DumpRenderTree.cpp:
81         (invalidateAnyPreviousWaitToDumpWatchdog):
82         (webViewScriptAlert):
83         (webViewScriptPrompt):
84         (webViewScriptConfirm):
85         (main):
86         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
87         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
88         (waitToDumpWatchdogFired):
89         (LayoutTestController::setWaitToDump):
90
91 2007-12-05  Mark Rowe  <mrowe@apple.com>
92
93         Reviewed by Alp Toker.
94
95         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
96
97         * DumpRenderTree/gtk/DumpRenderTree.cpp:
98         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
99         (dump):
100         (runTest):
101         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
102         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
103         work queue is empty.
104         (webViewWindowObjectCleared): Set up window.layoutTestController.
105         (webViewConsoleMessage): Match the console message format expected by the layout test results.
106         (main): Hook up the new signals.
107         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
108         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
109         dumping multiple times.
110         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
111         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
112
113 2007-12-14  Anders Carlsson  <andersca@apple.com>
114
115         Reviewed by Brady.
116
117         Assert that a web frame that's loading a resource always has either a data source or 
118         a provisional data source.
119         
120         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
121         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
122
123 2007-12-14  Darin Adler  <darin@apple.com>
124
125         - fix mistake causing nearly all tests to fail on Windows
126
127         * DumpRenderTree/win/UIDelegate.cpp:
128         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
129         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
130
131         * DumpRenderTree/mac/UIDelegate.mm:
132         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
133         than passing the entire message.
134
135 2007-12-14  Darin Adler  <darin@apple.com>
136
137         - fix Tiger build
138
139         * DumpRenderTree/mac/UIDelegate.mm:
140         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
141         new-to-Leopard methods.
142
143 2007-12-14  Darin Adler  <darin@apple.com>
144
145         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
146         since it now triggers unwanted icon loading. We only had it because we implemented "all"
147         delegate methods here.
148
149 2007-12-14  Anders Carlsson  <andersca@apple.com>
150
151         Reviewed by Darin and Geoff.
152
153         <rdar://problem/5619295> 
154         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
155         
156         Add property getting methods to the plug-in.
157         
158         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
159         (pluginInvoke):
160
161 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
162
163         Reviewed by Darin.
164
165         - Layout test fix for mac. When dumped to the console local file paths
166         now only show the name of the resource not the whole path.  This is to
167         make the results machine and OS independent.
168
169         * DumpRenderTree/mac/UIDelegate.mm:
170         (-[UIDelegate webView:addMessageToConsole:]):
171
172 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
173
174         Reviewed by Adam.
175
176         - Layout tests fix.  We need a way to remove machine-dependent
177         information from paths in layout test results. The UIDelegate now does
178         this.
179
180         * DumpRenderTree/DumpRenderTree.h:
181         * DumpRenderTree/win/DumpRenderTree.cpp:
182         (urlSuitableForTestResult):
183         * DumpRenderTree/win/DumpRenderTreeWin.h:
184         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
185         * DumpRenderTree/win/UIDelegate.cpp:
186         (UIDelegate::webViewAddMessageToConsole):
187
188 2007-12-13  Alp Toker  <alp@atoker.com>
189
190         Build fix for DRT breakage introduced in r28690.
191
192         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
193         (LayoutTestController::pathToLocalResource):
194
195 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
196
197         Reviewed by Alice and Sam.
198
199         - <rdar://5621435> Need a way to specify local resources (being loaded
200         from HTTP tests) on Windows.
201         - Implemented pathToLocalResource which exposes the functionality of
202         converting a given unix path to the correct location on Windows.
203
204         * DumpRenderTree/LayoutTestController.cpp:
205         (pathToLocalResourceCallback):
206         (LayoutTestController::staticFunctions):
207         * DumpRenderTree/LayoutTestController.h:
208         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
209         (LayoutTestController::pathToLocalResource):
210         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
211         (LayoutTestController::pathToLocalResource):
212
213 2007-12-12  Anders Carlsson  <andersca@apple.com>
214
215         Reviewed by Sam.
216
217         <rdar://problem/5132003>
218         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
219
220         * DumpRenderTree/win/DumpRenderTree.cpp:
221         (main):
222         Set the resource load delegate.
223         
224         * DumpRenderTree/win/DumpRenderTree.vcproj:
225         
226         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
227         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
228
229 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
230
231         Reviewed by Adam Roben.
232
233         Fix conversion from double to LPARAM in dispatchMessage().
234
235         * DumpRenderTree/win/EventSender.cpp:
236         (dispatchMessageCallback):
237
238 2007-12-11  Dan Bernstein  <mitz@apple.com>
239
240         Reviewed by Mark Rowe and Sam Weinig too!
241
242         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
243           fonts DumpRenderTree registers.
244
245         * DumpRenderTree/win/DumpRenderTree.cpp:
246         (initialize):
247
248 2007-12-11  Brady Eidson  <beidson@apple.com>
249
250         Reviewed by Anders
251
252         Make DumpRenderTree on mac use its own path for Databases testing
253
254         * DumpRenderTree/mac/DumpRenderTree.mm:
255         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
256           for future DRT-only use, then use it to construct the Databases path and set that default
257
258 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
259
260         Reviewed by Darin.
261
262         <rdar://problem/5535636>
263         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
264
265         http://bugs.webkit.org/show_bug.cgi?id=13916
266         JavaScript detects Tab as a character input on a textfield validation
267
268         * DumpRenderTree/mac/EventSendingController.mm:
269         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
270         Dispatch a keyup to better match what happens when a key is physically pressed.
271
272         * DumpRenderTree/win/EventSender.cpp:
273         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
274         returning from keyDown().
275         (getConstantCallback): Fixed a couple copy/paste mistakes.
276
277 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
278
279         Reviewed by Oliver.
280
281         - <rdar://5599845> Drosera: Does not show loal files in the file list
282         on the left side.
283
284         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
285         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
286         so the open source community can build.
287
288 2007-12-10  Brady Eidson  <beidson@apple.com>
289
290         Rubberstamped by Sam Weinig
291
292         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
293
294         * DumpRenderTree/mac/UIDelegate.mm:
295         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
296         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
297
298 2007-12-08  Oliver Hunt  <oliver@apple.com>
299
300         Reviewed by Sam W.
301
302         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
303         
304         Fixes <rdar://problem/5620249> Must disable SVG animation
305         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
306         
307         In order to allow finer grained control over the set of SVG features
308         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
309         distinct flags:
310         ENABLE_SVG_ANIMATION
311         ENABLE_SVG_FILTERS
312         ENABLE_SVG_FONTS
313         ENABLE_SVG_AS_IMAGE
314         ENABLE_SVG_USE
315         
316         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
317         
318         Script handles all the new build flags, and allows --svg-experimental
319         to automatically enable all features.
320
321         * Scripts/build-webkit:
322
323 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
324
325         Fix version parsing.
326
327         Rubber-stamped by Oliver.
328
329         * Drosera/win/Drosera.vcproj/auto-version.sh:
330
331 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
332
333         Build modifications for Drosera.
334
335         Reviewed by Adam.
336
337         * Drosera/DroseraWin.make: Added.
338         * Drosera/win/Drosera.vcproj/Drosera.rc:
339         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
340         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
341         * Drosera/win/Drosera.vcproj/VERSION: Added.
342         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
343
344 2007-12-06  Adam Roben  <aroben@apple.com>
345
346         Explicitly turn on the Mac font ascent hack on Windows
347
348         This keeps our font metrics matching those from Mac.
349
350         Reviewed by Hyatt.
351
352         * DumpRenderTree/win/DumpRenderTree.cpp:
353         (main):
354
355 2007-12-06  Anders Carlsson  <andersca@apple.com>
356
357         Rename main.c to main.cpp here too.
358         
359         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
360
361 2007-12-06  Sam Weinig  <sam@webkit.org>
362
363         Rubber stamped by Geoff.
364
365         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
366
367 2007-12-06  Darin Adler  <darin@apple.com>
368
369         * Scripts/do-webcore-rename: Some more renaming plans.
370
371 2007-12-06  Anders Carlsson  <andersca@apple.com>
372
373         Restore implementation of testGetIntIdentifier that was accidentally
374         removed somehow (possibly when I made PluginObject be a cpp file).
375         
376         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
377         (pluginInvoke):
378
379 2007-12-05  Anders Carlsson  <andersca@apple.com>
380
381         Make the entry points extern "C".
382         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
383         
384 2007-12-05  Anders Carlsson  <andersca@apple.com>
385
386         C++ warning fixes.
387         
388         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
389         (NPP_New):
390         (NPP_Destroy):
391         (NPP_SetWindow):
392         (NPP_NewStream):
393         (NPP_HandleEvent):
394         (NPP_URLNotify):
395         (NPP_GetValue):
396
397 2007-12-05  Anders Carlsson  <andersca@apple.com>
398
399         Add the .cpp files to the TestNetscapePlugIn target.
400
401         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
402
403 2007-12-05  Anders Carlsson  <andersca@apple.com>
404
405         Reviewed by Geoff.
406         
407         Rename the TestNetscapePlugIn .c files to be .cpp.
408
409         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
410         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
411         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
412         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
413         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
414         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
415         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
416         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
417
418 2007-12-05  Adam Roben  <aroben@apple.com>
419
420         Fix case of keypresses from the Windows implementation of eventSender.keyDown
421
422         This fixes several regression tests.
423
424         Reviewed by Alice.
425
426         * DumpRenderTree/win/EventSender.cpp:
427         (keyDownCallback): Virtual keycodes for ASCII characters are always
428         uppercase, so we need to check the case of the original character
429         passed in to eventSender.keyDown.
430
431 2007-12-05  Adam Roben  <aroben@apple.com>
432
433         Learn from Tim's mistakes
434
435         * DumpRenderTree/win/DumpRenderTree.cpp:
436         (runTest): Reset the authorAndUserStylesEnabled preference for each
437         test.
438
439 2007-12-05  Alp Toker  <alp@atoker.com>
440
441         Reviewed by Mark Rowe.
442
443         Initialize GTK+ and WebKit so the tests can run.
444
445         Reorganize the headers a little.
446
447         * DumpRenderTree/gtk/DumpRenderTree.cpp:
448         (main):
449
450 2007-12-04  Anders Carlsson  <andersca@apple.com>
451
452         Remove IWebScriptScope include.
453         
454         * Drosera/win/DebuggerDocumentPlatform.cpp:
455
456 2007-12-04  Sam Weinig  <sam@webkit.org>
457
458         Rubber stamped by Mark Rowe.
459
460         Define CF as platform for mac and revert r28409
461
462         * DumpRenderTree/DumpRenderTree.h:
463         * DumpRenderTree/mac/DumpRenderTreeMac.h:
464
465 2007-12-04  Sam Weinig  <sam@webkit.org>
466
467         Define CF as platform for windows.
468
469         Reviewed by Adam Roben.
470
471         * DumpRenderTree/win/DumpRenderTreeWin.h:
472
473 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
474
475         Reviewed by Adam and Darin.
476
477         - Removed a needless BSTR cleanup.
478
479         * Drosera/win/DebuggerDocumentPlatform.cpp:
480         (DebuggerDocument::getPlatformCurrentFunctionStack):
481
482 2007-11-27  Adam Roben  <aroben@apple.com>
483
484         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
485
486         Reviewed by Maciej.
487
488         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
489         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
490
491 2007-12-04  Alp Toker  <alp@atoker.com>
492
493         Prospective Win DRT build fix.
494
495         * DumpRenderTree/DumpRenderTree.h:
496
497 2007-12-04  Alp Toker  <alp@atoker.com>
498
499         Fix a clobbered copyright header.
500
501         * DumpRenderTree/gtk/DumpRenderTree.cpp:
502
503 2007-12-04  Xan Lopez  <xan@gnome.org>
504
505         Reviewed by Alp Toker.
506
507         http://bugs.webkit.org/show_bug.cgi?id=15561
508         GTK port needs DumpRenderTree implementation
509
510         Start work on the GTK+ DRT.
511
512         This does not work yet, and there are a few lingering style issues
513         (nothing major) but this patch has been stuck in the bug tracker for
514         too long already.
515
516         * DumpRenderTree/DumpRenderTree.h:
517         * DumpRenderTree/gtk: Added.
518         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
519         (autocorrectURL):
520         (shouldLogFrameLoadDelegates):
521         (dumpFrameScrollPosition):
522         (displayWebView):
523         (appendString):
524         (dumpFramesAsText):
525         (dumpRenderTreeAsText):
526         (dump):
527         (runTest):
528         (main):
529         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
530         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
531         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
532         (GCController::collect):
533         (GCController::collectOnAlternateThread):
534         (GCController::getJSObjectCount):
535         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
536         (LayoutTestController::~LayoutTestController):
537         (LayoutTestController::addDisallowedURL):
538         (LayoutTestController::clearBackForwardList):
539         (LayoutTestController::copyDecodedHostName):
540         (LayoutTestController::copyEncodedHostName):
541         (LayoutTestController::display):
542         (LayoutTestController::keepWebHistory):
543         (LayoutTestController::notifyDone):
544         (LayoutTestController::queueBackNavigation):
545         (LayoutTestController::queueForwardNavigation):
546         (LayoutTestController::queueLoad):
547         (LayoutTestController::queueReload):
548         (LayoutTestController::queueScript):
549         (LayoutTestController::setAcceptsEditing):
550         (LayoutTestController::setCustomPolicyDelegate):
551         (LayoutTestController::setMainFrameIsFirstResponder):
552         (LayoutTestController::setTabKeyCyclesThroughElements):
553         (LayoutTestController::setUseDashboardCompatibilityMode):
554         (LayoutTestController::setUserStyleSheetEnabled):
555         (LayoutTestController::setUserStyleSheetLocation):
556         (LayoutTestController::setWindowIsKey):
557         (LayoutTestController::setWaitToDump):
558         (LayoutTestController::windowCount):
559         (LayoutTestController::setPrivateBrowsingEnabled):
560         (LayoutTestController::setAuthorAndUserStylesEnabled):
561         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
562         (JSStringCopyUTF8CString):
563         (LoadItem::invoke):
564         (ReloadItem::invoke):
565         (ScriptItem::invoke):
566         (BackForwardItem::invoke):
567
568 2007-12-03  Sam Weinig  <sam@webkit.org>
569
570         Move JavaScriptCore thread testing code to pthread specific directory
571         and remove the dependance on CoreFoundation by using WTF::HashSet.
572
573         Reviewed by Geoff and Oliver.
574
575         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
576         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
577         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
578         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
579         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
580         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
581         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
582         * DumpRenderTree/pthreads: Added.
583         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
584         (javaScriptThreads):
585         (runJavaScriptThread):
586         (startJavaScriptThreads):
587         (stopJavaScriptThreads):
588
589 2007-12-03  Andrew Bonventre  <andybons@google.com>
590
591         Reviewed by Darin Adler.
592
593         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
594         Symbol lookup menu broken in debugger view
595
596         * Drosera/debugger.js: Fixed javascript error where document property
597         should have been used instead of contentDocument in switchFunction that
598         was breaking the select symbol dropdown menu.  This is because
599         window.frames will return a Window object and not a frame object like
600         the author was originally expecting.
601
602 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
603
604         Reviewed by Adam.
605
606         - <rdar://5618942> Drosera: Console window does not process everything
607         correctly.
608         - <rdar://5619005> Drosera: could be sped up by moving the 
609         WebScriptScope stuff into the WebScriptCallFrame.
610         - Now the console can correctly process objects and does not receive
611         notifications from JavaScriptCore about the JavaScript in Drosera's
612         own process.
613
614         * Drosera/win/DebuggerDocumentPlatform.cpp:
615         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
616         (DebuggerDocument::platformValueForScopeVariableNamed):
617
618 2007-12-03  Stephanie  <slewis@apple.com>
619
620         Reviewed by Darin.
621
622         Check to see if we are building a debug root
623
624         * Scripts/check-for-global-initializers: 
625
626 2007-12-03  Dan Bernstein  <mitz@apple.com>
627
628         Reviewed by Darin Adler.
629
630         - added a testGetIntIdentifier() method to TestNetscapePlugIn
631
632         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
633         (pluginInvoke):
634
635 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
636
637         Reviewed by Oliver.
638
639         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
640         in a more fine-grained manner than eventSender.keyDown().
641
642         * DumpRenderTree/win/EventSender.cpp:
643         (getConstantCallback):
644         (dispatchMessageCallback):
645
646 2007-12-02  Darin Adler  <darin@apple.com>
647
648         * Scripts/do-webcore-rename: More planned renaming.
649
650 2007-12-02  Sam Weinig  <sam@webkit.org>
651
652         Rubber stamped by Anders.
653
654         Use [NSURL absoluteString] instead of [NSURL description] in order to get
655         more uniform results cross platform.
656
657         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
658         (-[NSURL _drt_descriptionSuitableForTestResult]):
659
660 2007-12-02  Sam Weinig  <sam@webkit.org>
661
662         Rubber stamped by Niko.
663
664         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
665
666         * DumpRenderTree/win/DumpRenderTree.cpp:
667         * DumpRenderTree/win/DumpRenderTree.vcproj:
668         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
669         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
670         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
671         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
672
673 2007-12-01  Alp Toker  <alp@atoker.com>
674
675         Reviewed by Adam Roben.
676
677         Make use of the newly introduced webkit.h convenience header.
678
679         * GtkLauncher/main.c:
680
681 2007-12-01  Adam Treat  <treat@kde.org>
682
683         Reviewed by Simon.
684
685         * Check to see if the directory exists and exit if not.
686
687         * DumpRenderTree/qt/main.cpp:
688         (main):
689
690 2007-12-01  Adam Treat  <treat@kde.org>
691
692         Reviewed by Simon.
693
694         * Don't hide symbols when in Debug mode
695         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
696
697
698         * DumpRenderTree/qt/main.cpp:
699         (messageHandler):
700
701 2007-11-30  Alp Toker  <alp@atoker.com>
702
703         Reviewed by Adam Roben.
704
705         http://bugs.webkit.org/show_bug.cgi?id=15691
706         [GTK] Public API does not follow GTK+ conventions
707
708         Refactor the WebKit/GTK+ public API. Changes:
709           WebKitPage -> WebKitWebView
710           WebKitFrame -> WebKitWebFrame
711
712         Public API source and header names have been updated to mirror the API
713         changes.
714
715         The API is now kept in WebKit/gtk/WebView to match other ports in the
716         same class such as Mac and Win.
717
718         * GtkLauncher/main.c:
719         (activate_uri_entry_cb):
720         (link_hover_cb):
721         (title_change_cb):
722         (progress_change_cb):
723         (go_back_cb):
724         (go_forward_cb):
725         (create_browser):
726         (main):
727
728 2007-11-30  Adam Roben  <aroben@apple.com>
729
730         Hopefully the final build fix
731
732         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
733         pull in WTF's assertion/logging functions.
734
735 2007-11-30  Adam Roben  <aroben@apple.com>
736
737         Another build fix
738
739         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
740         WebKit.lib.
741
742 2007-11-30  Adam Roben  <aroben@apple.com>
743
744         Debug build fix
745
746         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
747         configuration.
748         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
749         projects.
750         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
751         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
752         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
753
754 2007-11-30  Sam Weinig  <sam@webkit.org>
755
756         Reviewed by Adam Roben.
757
758         Fix drawSelectionRect to actually draw the selection rect.
759
760         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
761         (drawSelectionRect):
762
763 2007-11-30  Darin Adler  <darin@apple.com>
764
765         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
766
767 2007-11-30  Darin Adler  <darin@apple.com>
768
769         * Scripts/do-webcore-rename: Get ready for some future renaming.
770
771 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
772
773         Reviewed by Adam.
774
775         - Removed some unnecessary functions and changed an unused return type. 
776
777         * Drosera/win/DebuggerClient.cpp:
778         (registerConsoleClass):
779         * Drosera/win/DebuggerClient.h:
780         * Drosera/win/Drosera.cpp:
781         (registerDroseraClass):
782
783 2007-11-28  Alp Toker  <alp@atoker.com>
784
785         Reviewed by Timothy Hatcher.
786
787         http://bugs.webkit.org/show_bug.cgi?id=16174
788         [GTK] Use "URI" not "URL" in public API
789
790         Replace use of the term "URL" with "URI" in public headers,
791         documentation and some internal code to match GLib/GTK+ convention.
792
793         This is now mentioned in the API guidelines:
794           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
795
796         * GtkLauncher/main.c:
797         (activate_uri_entry_cb):
798         (title_change_cb):
799         (create_toolbar):
800         (main):
801
802 2007-11-29  Anders Carlsson  <andersca@apple.com>
803
804         Reviewed by Sam.
805
806         <rdar://problem/5230478>
807         FrameLoadDelegate callbacks are not dumped in DRT.
808         
809         * DumpRenderTree/win/DumpRenderTree.cpp:
810         (shouldLogFrameLoadDelegates):
811         (runTest):
812         (main):
813         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
814         (BSTRtoString):
815         (descriptionSuitableForTestResult):
816         (FrameLoadDelegate::QueryInterface):
817         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
818         (FrameLoadDelegate::didFailProvisionalLoadWithError):
819         (FrameLoadDelegate::didCommitLoadForFrame):
820         (FrameLoadDelegate::didFinishLoadForFrame):
821         (FrameLoadDelegate::willCloseFrame):
822         (FrameLoadDelegate::didClearWindowObject):
823         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
824         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
825         * DumpRenderTree/win/FrameLoaderDelegate.h:
826         (FrameLoadDelegate::windowScriptObjectAvailable):
827         (FrameLoadDelegate::didFirstLayoutInFrame):
828
829 2007-11-29  Sam Weinig  <sam@webkit.org>
830
831         Reviewed by Anders.
832
833         Add database quota UIDelegates methods to DRT UIDelegate.
834
835         * DumpRenderTree/mac/UIDelegate.mm:
836         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
837         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
838
839 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
840
841         Reviewed by Sam.
842
843         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
844         dying and vice versa.
845         - This fix will allow Drosera and Safari to reconnect if either of them
846         closes correctly, but does not fix the case where one of them dies
847         silently.
848
849         * Drosera/win/ServerConnection.cpp:
850         (ServerConnection::attemptToCreateServerConnection): Added a safety
851         check, because it's possilbe to try to connect to a server that's dying.
852         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
853         the server has died.
854         * Drosera/win/ServerConnection.h: Added the new function and removed
855         an unnecessary member.
856
857 2007-11-29  Anders Carlsson  <andersca@apple.com>
858
859         * DumpRenderTree/win/DumpRenderTree.vcproj:
860         Add shlwapi.lib to all configurations.
861
862 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
863
864         - Build fix.  Added additional includes for VS Express to the Release
865         project.
866
867         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
868
869 2007-11-29  Anders Carlsson  <andersca@apple.com>
870
871         Reviewed by Adam.
872
873         <rdar://problem/5132005>
874         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
875         
876         * DumpRenderTree/win/DumpRenderTree.vcproj:
877         Add shlwapi.lib
878         
879         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
880         (LayoutTestController::setUserStyleSheetEnabled):
881         Implement this.
882         
883         (appendComponentToPath):
884         New method which wraps the Win32 API PathAppend.
885         
886         (followShortcuts):
887         New method which checks if a file points to a shortcut and
888         follows the shortcut.
889         
890         (resolveCygwinPath):
891         New method that takes a cygwin unix-style path and returns the Win32 path.
892         
893         (cfStringRefToWString):
894         
895         (LayoutTestController::setUserStyleSheetLocation):
896         Implement this.
897
898 2007-11-29  Alice Liu  <alice.liu@apple.com>
899
900         Reviewed by Adam.
901
902         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
903
904         * DumpRenderTree/win/EventSender.cpp:
905         (keyDownCallback):
906         uppercase letters were being sent as lowercase letters without the shift key down.
907
908 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
909
910         - Windows build fix. VS express needs some love.
911
912         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
913
914 2007-11-28  Darin Adler  <darin@apple.com>
915
916         Reviewed by Adam Roben.
917
918         * DumpRenderTree/mac/EventSendingController.mm:
919         (-[EventSendingController keyDown:withModifiers:]):
920         Send capital letters through as lowercase letters with the shift key down
921         rather than sending them as if they were highly unusual "capital letter keys".
922
923         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
924         where you need to update results and more tests are failing than before.
925
926 2007-11-28  Anders Carlsson  <andersca@apple.com>
927
928         Reviewed by Darin.
929
930         <rdar://problem/5132001>
931         contextClick is not implemented in DRT on Windows.
932         
933         * DumpRenderTree/win/EventSender.cpp:
934         (contextClickCallback):
935         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
936         by a WM_RBUTTONUP message.
937         
938         * DumpRenderTree/win/UIDelegate.cpp:
939         (UIDelegate::hasCustomMenuImplementation):
940         (UIDelegate::trackCustomPopupMenu):
941         * DumpRenderTree/win/UIDelegate.h:
942         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
943         menu from being shown (and causing the DRT to hang).
944
945 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
946
947         Reviewed by Darin.
948
949         Fix DumpRenderTree ObjC bug comparing strings.
950
951         * DumpRenderTree/mac/ObjCController.m:
952         (-[ObjCController identityIsEqual::]): Compare strings with string
953         equality instead of identiy equality.
954
955 2007-11-27  Timothy Hatcher  <timothy@apple.com>
956
957         Reviewed by Sam.
958
959         Reset the authorAndUserStylesEnabled preference
960         back to YES for each test. Fixes the broken tests.
961
962         * DumpRenderTree/mac/DumpRenderTree.mm:
963         (resetWebViewToConsistentStateBeforeTesting):
964
965 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
966
967         Reviewed by Adam.
968
969         - Drosera now displays the console window, although it cannot currently
970         process JavaScript.
971
972         * Drosera/win/DebuggerClient.cpp: Shows the console window.
973         (registerConsoleClass): Implemented.
974         (consoleWndProc): Implemented.
975         (DebuggerClient::onSize): Implemented.
976         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
977         new window.
978         * Drosera/win/DebuggerClient.h: Added needed method and members for 
979         creating and maintaining a new window.
980         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
981         lines of code to more appropriate places.
982         (Drosera::handleCommand):
983         (Drosera::initUI):
984         (Drosera::onSize):
985         (Drosera::attach):
986
987 2007-11-27  Timothy Hatcher  <timothy@apple.com>
988
989         Reviewed by Dave Hyatt.
990
991         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
992         
993         Add support for disabling author and user styles for testing.
994
995         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
996         * DumpRenderTree/LayoutTestController.cpp:
997         (setAuthorAndUserStylesEnabledCallback):
998         (LayoutTestController::staticFunctions):
999         * DumpRenderTree/LayoutTestController.h:
1000         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1001         (LayoutTestController::setAuthorAndUserStylesEnabled):
1002         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1003         (LayoutTestController::setAuthorAndUserStylesEnabled):
1004
1005 2007-11-26  Dan Bernstein  <mitz@apple.com>
1006
1007         - Tiger build fix.
1008
1009         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1010
1011 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1012
1013         Reviewed by Maciej.
1014
1015         - Implemented displaying variables for Drosera on Win.
1016
1017         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1018         that retrieve variables to not hold onto the return value since it's
1019         not returned.  Also changed to use the new signatures of the retrieval
1020         functions.
1021         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1022         (DebuggerDocument::platformValueForScopeVariableNamed):
1023         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1024         (droseraWndProc):
1025
1026 2007-11-26  Sam Weinig  <sam@webkit.org>
1027
1028         Cleanup names of painting and repainting functions.
1029
1030         Reviewed by Adam Roben.
1031
1032         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1033         (drawSelectionRect): was drawSelectionRectIntoContext.
1034         (dumpWebViewAsPixelsAndCompareWithExpected):
1035         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1036         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1037         (paintWebView): was drawWebViewIntoContext.
1038         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1039
1040 2007-11-26  Sam Weinig  <sam@webkit.org>
1041
1042         Reviewed by Dan Bernstein.
1043
1044         - Leopard build fix
1045
1046         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1047
1048 2007-11-26  Sam Weinig  <sam@webkit.org>
1049
1050         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1051         Use shared PixelDumpSupport for Mac DRT
1052
1053         Reviewed by Adam Roben.
1054
1055         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1056         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1057         * DumpRenderTree/cg/ImageDiffCG.cpp:
1058         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1059         (drawSelectionRectIntoContext):
1060         (dumpWebViewAsPixelsAndCompareWithExpected):
1061         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1062         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1063         * DumpRenderTree/mac/DumpRenderTree.mm:
1064         (dump):
1065         * DumpRenderTree/mac/ImageDiff.m: Removed.
1066         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1067         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1068         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1069         (setDefaultColorProfileToRGB):
1070         (getBitmapContextFromWebView):
1071         (drawWebViewIntoContext):
1072         (repaintWithVerticalSweep):
1073         (repaintWithHorizontalSweep):
1074         (getSelectionRect):
1075         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1076
1077 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1078
1079         Bug 16052: prepare-ChangeLog doesn't report deleted files
1080         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1081
1082         Reviewed by Sam.
1083
1084         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1085
1086 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1087
1088         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1089         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1090
1091         Reviewed by Adam.
1092
1093         Roll functionality of merge-changelog into resolve-ChangeLogs
1094         script.  The script now checks for ChangeLog.rej and
1095         ChangeLog.orig files first.  If it finds them, it uses the
1096         ChangeLog.rej file as a patch (in old contextual diff format) to
1097         apply with --fuzz=3.
1098
1099         * Scripts/merge-changelog: Removed.
1100         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1101
1102 2007-11-25  Sam Weinig  <sam@webkit.org>
1103
1104         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1105
1106         Reviewed by Mark Rowe.
1107
1108         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1109         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1110         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1111         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1112         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1113
1114 2007-11-25  Sam Weinig  <sam@webkit.org>
1115
1116         Convert DumpRenderTree to ues .xcconfig files.
1117
1118         Reviewed by Mark Rowe.
1119
1120         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1121         * DumpRenderTree/mac/Configurations: Added.
1122         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1123         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1124         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1125
1126 2007-11-25  Sam Weinig  <sam@webkit.org>
1127
1128         Add ForwardingHeaders to wtf for DumpRenderTree.
1129
1130         Reviewed by Mark Rowe.
1131
1132         * DumpRenderTree/DumpRenderTree.h:
1133         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1134         * DumpRenderTree/ForwardingHeaders: Added.
1135         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1136         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1137         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1138         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1139         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1140         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1141         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1142         * DumpRenderTree/LayoutTestController.cpp:
1143         * DumpRenderTree/WorkQueue.cpp:
1144         * DumpRenderTree/mac/DumpRenderTree.mm:
1145         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1146         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1147         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1148         * DumpRenderTree/mac/ObjCController.m:
1149         * DumpRenderTree/mac/UIDelegate.mm:
1150         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1151
1152 2007-11-25  Adam Roben  <aroben@apple.com>
1153
1154         Fix some test failures caused by r28019
1155
1156         Now that stdout is in binary mode, we need to always use printf
1157         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1158         the output.
1159
1160         Reviewed by Sam.
1161
1162         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1163         printf.
1164         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1165         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1166         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1167         (UIDelegate::webViewAddMessageToConsole):
1168
1169 2007-11-25  Adam Roben  <aroben@apple.com>
1170
1171         Set the font smoothing preference in DRT
1172
1173         This makes the pixel results on Windows closer to the Mac results.
1174
1175         Reviewed by Mitz.
1176
1177         * DumpRenderTree/win/DumpRenderTree.cpp:
1178         (initializePreferences):
1179
1180 2007-11-25  Adam Roben  <aroben@apple.com>
1181
1182         Port ImageDiff to CG and C++
1183
1184         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1185         <rdar://5071708>
1186
1187         Reviewed by Sam.
1188
1189         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1190         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1191         (main):
1192         (createImageFromStdin):
1193         (compareImages):
1194         (getDifferenceBitmap):
1195         (computePercentageDifferent):
1196         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1197
1198 2007-11-25  Adam Roben  <aroben@apple.com>
1199
1200         Fix image diff link generation on Windows
1201
1202         Reviewed by Sam.
1203
1204         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1205         to toURL.
1206
1207 2007-11-25  Adam Roben  <aroben@apple.com>
1208
1209         Implement pixel dumping in Windows DRT
1210
1211         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1212         <rdar://5071708>
1213
1214         Reviewed by Sam.
1215
1216         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1217         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1218         Content-Length header.
1219         (getMD5HashStringForBitmap):
1220         (dumpWebViewAsPixelsAndCompareWithExpected):
1221         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1222         * DumpRenderTree/win/DumpRenderTree.cpp:
1223         (dump): Do a pixel dump if requested.
1224         (main): Parse pixel test options.
1225         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1226         the cg/ subdirectory to the include path.
1227         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1228         available in a header or import library, so we have to go through this
1229         LoadLibrary/GetProcAddress dance to use them.
1230         (cryptDLL):
1231         (init):
1232         (update):
1233         (final):
1234         (MD5_Init):
1235         (MD5_Update):
1236         (MD5_Final):
1237         * DumpRenderTree/win/MD5.h: Added.
1238         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1239         moved up to the top level to share it with Mac eventually.
1240         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1241         (getBitmapContextFromWebView): Forces the WebView to paint using a
1242         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1243
1244 2007-11-25  Adam Roben  <aroben@apple.com>
1245
1246         Clean up Windows DRT's option parsing a little bit
1247
1248         Reviewed by Sam.
1249
1250         * DumpRenderTree/win/DumpRenderTree.cpp:
1251         (main): Put non-option arguments into a Vector.
1252
1253 2007-11-25  Adam Roben  <aroben@apple.com>
1254
1255         Make Windows DRT stop changing LF into CRLF
1256
1257         Reviewed by Sam.
1258
1259         * DumpRenderTree/win/DumpRenderTree.cpp:
1260         (main): Put stdout in binary mode.
1261         * Scripts/run-webkit-tests: Remove the CRLF hack.
1262
1263 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1264
1265         Removed empty directory.
1266
1267         * Scripts/resources: Removed.
1268
1269 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1270
1271         Fix bisect-builds to work with recent WebKit nightly builds.
1272
1273         Reviewed by Dan.
1274
1275         * Scripts/bisect-builds: Check for the 
1276         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1277         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1278         to WebKit.app/Contents/Resources.
1279
1280 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1281
1282         Reviewed by Maciej.
1283
1284         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1285         not closed (affects digg.com)
1286
1287         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1288         one after finishing with a test to avoid having its delayed onload handler firing when
1289         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1290         but it helps somewhat.
1291
1292 2007-11-22  Mark Rowe  <mrowe@apple.com>
1293
1294         Reviewed by Alp Toker.
1295
1296         Fix build-webkit to propagate make's exit status if it fails.
1297
1298         * Scripts/webkitdirs.pm:
1299
1300 2007-11-22  Dan Bernstein  <mitz@apple.com>
1301
1302         Reviewed by Mark Rowe.
1303
1304         - fix crash when running pixel tests
1305
1306         * DumpRenderTree/mac/DumpRenderTree.mm:
1307         (dumpRenderTree): Parse the command line options before setting up the
1308         environment so that we know if we need to set up the pixel dump
1309         machinery.
1310
1311 2007-11-21  Eric Seidel  <eric@webkit.org>
1312
1313         Speculative build fix for Tiger.
1314
1315         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1316
1317 2007-11-21  Eric Seidel  <eric@webkit.org>
1318
1319         Reviewed by Tim Hatcher.
1320
1321         Break out more of DumpRenderTree.mm into individual files
1322
1323         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1324         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1325         (checkedMalloc):
1326         (checkedRealloc):
1327         (makeLargeMallocFailSilently):
1328         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1329         * DumpRenderTree/mac/DumpRenderTree.mm:
1330         (crashHandler):
1331         (dump):
1332         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1333         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1334         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1335         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1336         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1337         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1338         (javaScriptThreads):
1339         (runJavaScriptThread):
1340         (startJavaScriptThreads):
1341         (stopJavaScriptThreads):
1342         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1343         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1344         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1345         (restoreColorSpace):
1346         (setDefaultColorProfileToRGB):
1347         (initializeColorSpaceAndScreeBufferForPixelTests):
1348         (md5HashStringForBitmap):
1349         (dumpWebViewAsPixelsAndCompareWithExpected):
1350
1351 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1352
1353         Move install-unix-extras to wx directory as it seems only to be used by that 
1354         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1355         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1356         have install-unix-extras install into WebKitLibraries as per
1357         convention.
1358         
1359         Reviewed by Mark Rowe.
1360
1361         * Scripts/install-unix-extras: Removed.
1362         * wx/build-wxwebkit:
1363         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1364
1365 2007-11-21  Eric Seidel  <eric@webkit.org>
1366
1367         Reviewed by Adam.
1368
1369         More refactoring for greater code readability
1370
1371         * DumpRenderTree/mac/DumpRenderTree.mm:
1372         (initializeGlobalsFromCommandLineOptions):
1373         (initializeColorSpaceAndScreeBufferForPixelTests):
1374         (addTestPluginsToPluginSearchPath):
1375         (useLongRunningServerMode):
1376         (runTestingServerLoop):
1377         (prepareConsistentTestingEnvironment):
1378         (dumpRenderTree):
1379         (main):
1380         (dumpFramesAsText):
1381         (dumpBackForwardListForWebView):
1382         (sizeWebViewForCurrentTest):
1383         (methodNameStringForFailedTest):
1384         (dumpBackForwardListForAllWindows):
1385         (dumpWebViewAsPixelsAndCompareWithExpected):
1386         (invalidateAnyPreviousWaitToDumpWatchdog):
1387         (dump):
1388         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1389         * DumpRenderTree/mac/UIDelegate.mm:
1390         (-[UIDelegate webView:createWebViewWithRequest:]):
1391
1392 2007-11-21  Eric Seidel  <eric@webkit.org>
1393
1394         Reviewed by Tim Hatcher.
1395
1396         Abstract more of DRT into static methods
1397
1398         * DumpRenderTree/mac/DumpRenderTree.mm:
1399         (setDefaultsToConsistentValuesForTesting):
1400         (setupSignalHandlers):
1401         (allocateGlobalControllers):
1402         (releaseAndZero):
1403         (releaseGlobalControllers):
1404         (dumpRenderTree):
1405         (shouldLogFrameLoadDelegates):
1406         (createCFURLFromPathOrURL):
1407         (resetWebViewToConsistentStateBeforeTesting):
1408         (runTest):
1409
1410 2007-11-21  Eric Seidel  <eric@webkit.org>
1411
1412         Reviewed by Tim Hatcher.
1413
1414         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1415
1416         * DumpRenderTree/DumpRenderTree.h:
1417         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1418         * DumpRenderTree/mac/DumpRenderTree.mm:
1419         (dumpRenderTree):
1420         (dump):
1421         (runTest):
1422         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1423         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1424         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1425         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1426         (-[DumpRenderTreePasteboard declareType:owner:]):
1427         (+[LocalPasteboard alloc]):
1428         (-[LocalPasteboard init]):
1429         (-[LocalPasteboard dealloc]):
1430         (-[LocalPasteboard name]):
1431         (-[LocalPasteboard releaseGlobally]):
1432         (-[LocalPasteboard declareTypes:owner:]):
1433         (-[LocalPasteboard addTypes:owner:]):
1434         (-[LocalPasteboard changeCount]):
1435         (-[LocalPasteboard types]):
1436         (-[LocalPasteboard availableTypeFromArray:]):
1437         (-[LocalPasteboard setData:forType:]):
1438         (-[LocalPasteboard dataForType:]):
1439         (-[LocalPasteboard setPropertyList:forType:]):
1440         (-[LocalPasteboard setString:forType:]):
1441         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1442         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1443         (+[DumpRenderTreeWindow allWindows]):
1444         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1445         (-[DumpRenderTreeWindow dealloc]):
1446         (-[DumpRenderTreeWindow isKeyWindow]):
1447         (-[DumpRenderTreeWindow keyDown:]):
1448
1449 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1450
1451         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1452         it indiscriminately copies any headers inside JavaScriptCore,
1453         which includes Tiger ICU headers. 
1454
1455         * wx/build-wxwebkit:
1456         Don't run WebCore/move-js-headers.sh any longer.
1457
1458 2007-11-20  Adam Treat  <treat@kde.org>
1459
1460         Reviewed by David Kilzer.
1461
1462         * Prepend git branch name to $baseProductDir
1463
1464         * Scripts/VCSUtils.pm:
1465         * Scripts/webkitdirs.pm:
1466
1467 2007-11-20  Mark Rowe  <mrowe@apple.com>
1468
1469         Reviewed by Simon Hausmann.
1470
1471         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1472         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1473         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1474         built product and generated Makefile's are removed.
1475
1476 2007-11-19  Alp Toker  <alp@atoker.com>
1477
1478         Reviewed by Mark Rowe.
1479
1480         http://bugs.webkit.org/show_bug.cgi?id=16040
1481         [GTK] GtkLauncher should be written in C
1482
1483         Port GtkLauncher to plain C.
1484
1485         Use a more conventional GTK+ coding style.
1486
1487         Use a toolbar instead of menus.
1488
1489         Various signature fixes and cleanups.
1490
1491         Add a license header. Assume all previous modifications were copyright
1492         assigned to Apple Inc. by default.
1493
1494         * GtkLauncher/GtkLauncher.pro:
1495         * GtkLauncher/main.c: Added.
1496         (activate_url_entry_cb):
1497         (update_title):
1498         (link_hover_cb):
1499         (title_change_cb):
1500         (progress_change_cb):
1501         (destroy_cb):
1502         (go_back_cb):
1503         (go_forward_cb):
1504         (create_browser):
1505         (create_statusbar):
1506         (create_toolbar):
1507         (create_window):
1508         (main):
1509         * GtkLauncher/main.cpp: Removed.
1510
1511 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1512
1513         Build script fixes to ensure they do the right thing for the 
1514         wx port, and update build-wxwebkit to reflect the way the
1515         build scripts now work.
1516
1517         Reviewed by Adam.
1518
1519         * Scripts/build-testkjs:
1520         * Scripts/build-webkit:
1521         * Scripts/run-javascriptcore-tests:
1522         * Scripts/webkitdirs.pm:
1523         * wx/build-wxwebkit:
1524
1525 2007-11-18  Eric Seidel  <eric@webkit.org>
1526
1527         Reviewed by Anders.
1528
1529         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1530
1531         * Scripts/run-javascriptcore-tests:
1532
1533 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1534
1535         Reviewed by Adam Roben.
1536
1537         Make run-webkit-tests work with Windows debug build.
1538
1539         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1540         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1541         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1542         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1543         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1544
1545 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1546
1547         Add wxWebKit sample and build script, and integrate it with 
1548         build-webkit. Also make build-webkit --clean work for all
1549         ports.
1550
1551         Reviewed by Darin Adler.
1552
1553         * Scripts/build-webkit:
1554         * Scripts/webkitdirs.pm:
1555         * wx: Added.
1556         * wx/browser: Added.
1557         * wx/browser/browser.bkl: Added.
1558         * wx/browser/browser.cpp: Added.
1559         * wx/build-wxwebkit: Added.
1560
1561 2007-11-17  Adam Roben  <aroben@apple.com>
1562
1563         Make it easy to run Safari in the debugger on Windows
1564
1565         I've added a new script, debug-safari, which launches Safari in the
1566         debugger. On OS X it just calls gdb-safari.
1567
1568         Reviewed by Mark Rowe.
1569
1570         * FindSafari/FindSafari.cpp:
1571         (_tmain): Added a /debugger flag, which in combination with
1572         /printSafariLauncher will print a script that launches Safari in the
1573         debugger.
1574         * Scripts/debug-safari: Added.
1575         * Scripts/run-safari: Changed to call runSafari().
1576         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1577         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1578         first argument along to FindSafari.
1579         * Scripts/webkitdirs.pm:
1580         (sub runSafari): Added.
1581
1582 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1583
1584         Reviewed by Adam Roben.
1585
1586         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1587
1588 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1589
1590         Reviewed by David Kilzer.
1591
1592         The git config command was renamed to repo-config at some point. This
1593         change tries git config and then git repo-config if the first fails.
1594
1595         * Scripts/prepare-ChangeLog:
1596         (gitConfig):
1597
1598 2007-11-16  Dan Bernstein  <mitz@apple.com>
1599
1600         Reviewed by Darin Adler and Sam Weinig.
1601
1602         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1603
1604         * DumpRenderTree/win/EventSender.cpp:
1605         (keyDownCallback): For characters that cannot be entered on the active
1606         keyboard layout, send a WM_CHAR message with the character along with
1607         a WM_KEYDOWN message with a virtual key code of 255.
1608
1609 2007-11-16  Mark Rowe  <mrowe@apple.com>
1610
1611         Reviewed by Tim Hatcher.
1612
1613         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1614
1615         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1616         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1617
1618 2007-11-15  Adam Roben  <aroben@apple.com>
1619
1620         Make run-safari actually work on Windows
1621
1622         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1623         chdir call.
1624
1625 2007-11-14  Adam Roben  <aroben@apple.com>
1626
1627         Updates to Safari launching now that 3.0.4 is released
1628
1629         Reviewed by Sam.
1630
1631         * FindSafari/FindSafari.cpp:
1632         (getWebViewCLSID): Use version-independent ProgID.
1633         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1634
1635 2007-11-14  Anders Carlsson  <andersca@apple.com>
1636
1637         Reviewed by Adam.
1638
1639         <rdar://problem/5309081>
1640         In DRT, "plugin.logDestroy = true" not working on Windows.
1641         
1642         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1643         (NPP_Destroy):
1644
1645 2007-11-14  Eric Seidel  <eric@webkit.org>
1646
1647         Reviewed by Sam.
1648
1649         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1650
1651 2007-11-14  Anders Carlsson  <andersca@apple.com>
1652
1653         Reviewed by Adam.
1654
1655         <rdar://problem/5141186>
1656         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1657         
1658         Implement setWindowIsKey.
1659         
1660         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1661         (LayoutTestController::setWindowIsKey):
1662
1663 2007-11-13  Sam Weinig  <sam@webkit.org>
1664
1665         Reviewed by Adam Roben.
1666
1667         Fix for <rdar://problem/5382579>
1668         http/tests/security/cross-frame-access-put.html reports large 
1669         negative numbers for screenLeft and screenTop (Mac reports "0")
1670
1671         * DumpRenderTree/win/UIDelegate.cpp:
1672         (UIDelegate::UIDelegate): Initialize the RECT.
1673         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1674         (UIDelegate::webViewFrame): ditto.
1675         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1676
1677 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1678
1679         Reviewed by Adam.
1680
1681         - Make Drosera show source, source URLs, and function stack on Windows,
1682         and some minor fixes.
1683
1684         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1685         (DebuggerDocument::updateFileSource):
1686         * Drosera/debugger.js: Force source to always update display.
1687         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1688         menu controls.
1689         (DebuggerClient::resume):
1690         (DebuggerClient::pause):
1691         (DebuggerClient::stepInto):
1692         (DebuggerClient::stepOver):
1693         (DebuggerClient::stepOut):
1694         (DebuggerClient::showConsole):
1695         (DebuggerClient::closeCurrentFile):
1696         * Drosera/win/DebuggerClient.h: Ditto.
1697         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1698         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1699         removed two bugs.  1) caller could be in a bad state when asked to
1700         assign into it. 2) BSTRs were not created correctly.
1701         (DebuggerDocument::getPlatformCurrentFunctionStack):
1702         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1703         (droseraWndProc):
1704         (handleCommand):
1705         (Drosera::resume):
1706         (Drosera::pause):
1707         (Drosera::stepInto):
1708         (Drosera::stepOver):
1709         (Drosera::stepOut):
1710         (Drosera::showConsole):
1711         (Drosera::closeCurrentFile):
1712         * Drosera/win/Drosera.h: Hook up the menu controls.
1713         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1714         functions, added a null check, and fixed another bug where caller could
1715         be in a bad state when asked to assign into it.
1716         (ServerConnection::didLoadMainResourceForDataSource):
1717         (ServerConnection::getCallerFrame):
1718         * Drosera/win/ServerConnection.h: Safety first.
1719
1720 2007-11-13  Dan Bernstein  <mitz@apple.com>
1721
1722         Reviewed by Darin Adler.
1723
1724         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1725           DumpRenderTree --pixel-tests renders each test twice
1726
1727         * DumpRenderTree/mac/DumpRenderTree.mm:
1728         (dumpRenderTree): Removed the --paint option because the painting code
1729         is always exercised as a result of
1730         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1731         calling -displayIfNeeded.
1732         (dump): Changed to always grab the image from the window since the view
1733         is always displayed.
1734         (runTest):
1735         (displayWebView):
1736         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1737         because it always paints.
1738
1739 2007-11-12  Antti Koivisto  <antti@apple.com>
1740
1741         Reviewed by Adele.
1742         
1743         Add support for http media tests
1744
1745         * Scripts/run-webkit-tests:
1746
1747 2007-11-12  Sam Weinig  <sam@webkit.org>
1748
1749         Reviewed by Adam Roben.
1750
1751         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1752
1753         * DumpRenderTree/win/DumpRenderTree.cpp:
1754         (runTest):
1755         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1756         (LayoutTestController::setPrivateBrowsingEnabled):
1757
1758 2007-11-12  Adam Roben  <aroben@apple.com>
1759
1760         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1761         mac and win subdirectories.
1762
1763 2007-11-11  Adam Roben  <aroben@apple.com>
1764
1765         Fix <rdar://5133816> keepWebHistory is not implemented
1766
1767         Fixes fast/history/clicked-link-is-visited.html.
1768
1769         Reviewed by Darin.
1770
1771         * DumpRenderTree/win/DumpRenderTree.cpp:
1772         (runTest): Clear the optionalSharedHistory.
1773         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1774         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1775
1776 2007-11-10  Sam Weinig  <sam@webkit.org>
1777
1778         Reviewed by Tim Hatcher.
1779
1780         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1781         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1782         is turned on)
1783
1784         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1785
1786         Added test: http/tests/security/cross-frame-access-private-browsing.html
1787
1788         * DumpRenderTree/LayoutTestController.cpp:
1789         (setPrivateBrowsingEnabledCallback):
1790         (LayoutTestController::staticFunctions):
1791         * DumpRenderTree/LayoutTestController.h:
1792         * DumpRenderTree/mac/DumpRenderTree.mm:
1793         (runTest): Default to private browsing disabled.
1794         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1795         (LayoutTestController::setPrivateBrowsingEnabled):
1796         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1797         (LayoutTestController::setPrivateBrowsingEnabled):
1798
1799 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1800
1801         Reviewed by Adam.
1802
1803         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1804         WebCore's!
1805
1806         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1807         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1808         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1809         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1810         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1811         * Drosera/win/Drosera.cpp:
1812         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1813
1814 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1815
1816         Reviewed by Sam.
1817
1818         - Use the new IWebFrame [local] function signature and get the shared
1819         server correctly.
1820
1821         * Drosera/win/DebuggerClient.cpp:
1822         (DebuggerClient::didFinishLoadForFrame):
1823         * Drosera/win/ServerConnection.cpp:
1824         (ServerConnection::attemptToCreateServerConnection):
1825
1826 2007-11-07  Dan Bernstein  <mitz@apple.com>
1827
1828         Reviewed by Darin Adler.
1829
1830         - add an option to run-webkit-tests to ignore pixel test failures where
1831           all pixels differ by no more than a specified threshold
1832
1833         * DumpRenderTree/mac/ImageDiff.m:
1834         (main):
1835         (compareImages):
1836         (computePercentageDifferent):
1837         * Scripts/run-webkit-tests:
1838
1839 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1840
1841         Reviewed by Lars.
1842
1843         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1844
1845         * DumpRenderTree/qt/DumpRenderTree.cpp:
1846
1847 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1848
1849         Reviewed by Lars.
1850
1851         Reworked the QWebSettings API.
1852         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1853
1854         * DumpRenderTree/qt/DumpRenderTree.cpp:
1855
1856 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1857
1858         Reviewed by Lars.
1859
1860         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1861
1862         * DumpRenderTree/qt/jsobjects.cpp:
1863
1864 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1865
1866         Reviewed by Lars Knoll <lars@trolltech.com>.
1867
1868         Add a QWebPage::frameCreated() signal and fix DRT
1869         
1870         The removal of createFrame in QWebPage broke the re-implementation
1871         in DumpRenderTree. Instead emit a frameCreated() signal and
1872         connect to it in DumpRenderTree.
1873         
1874
1875         * DumpRenderTree/qt/DumpRenderTree.cpp:
1876         (WebCore::WebPage::WebPage):
1877         (WebCore::DumpRenderTree::dump):
1878         (WebCore::DumpRenderTree::connectFrame):
1879         * DumpRenderTree/qt/DumpRenderTree.h:
1880
1881 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1882
1883         Reviewed by Lars Knoll <lars@trolltech.com>.
1884
1885         Moved all the event handlers from QWebFrame into QWebPage.
1886         
1887         This cleans up the public API and allows us to remove the
1888         HackWebFrame hack in DumpRenderTree.
1889         
1890
1891         * DumpRenderTree/qt/jsobjects.cpp:
1892         (EventSender::mouseDown):
1893         (EventSender::mouseUp):
1894         (EventSender::mouseMoveTo):
1895
1896 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1897
1898         Reviewed by Mark.
1899
1900         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1901         to prevent the default implementation from popping up messageboxes.
1902
1903         * DumpRenderTree/qt/DumpRenderTree.cpp:
1904         (WebCore::WebPage::javaScriptConfirm):
1905         (WebCore::WebPage::javaScriptPrompt):
1906
1907 2007-11-06  Eric Seidel  <eric@webkit.org>
1908
1909         * Scripts/build-testkjs: build fix... too many $$
1910
1911 2007-11-06  Eric Seidel  <eric@webkit.org>
1912
1913         Reviewed by Mark Rowe.
1914
1915         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1916
1917 2007-11-05  Adam Roben  <aroben@apple.com>
1918
1919         Add support on Windows for WEBKIT_TESTFONTS
1920
1921         This environment variable lets you specify where the fonts to be used
1922         by DumpRenderTree reside. The Qt port is already using this, so I'm
1923         just following their lead.
1924
1925         Reviewed by Darin.
1926
1927         * DumpRenderTree/win/DumpRenderTree.cpp:
1928         (exePath): Refactored code out of initialize().
1929         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1930         DumpRenderTree.resources.
1931         (initialize): Use the new fontsPath function.
1932         (main): Use the new exePath function.
1933         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1934         variable to DRT, like Qt does.
1935
1936 2007-11-05  Mark Rowe  <mrowe@apple.com>
1937
1938         Rubber-stamped by Alp Toker.
1939
1940         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1941
1942         * GtkLauncher/main.cpp:
1943         (goToURLBarText):
1944         (main):
1945
1946 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1947
1948         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1949         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1950
1951         Reviewed by Timothy.
1952
1953         Restrict the range of nightly builds used by the bisect-builds script
1954         based on the version of Safari and the version of Mac OS X being used.
1955
1956         Mac OS X 10.4: Safari 2.0: r11976 or newer
1957         Mac OS X 10.4: Safari 3.0: r19992 or newer
1958
1959         Mac OS X 10.5: Safari 2.0: r19594 or newer
1960         Mac OS X 10.5: Safari 3.0: r25124 or newer
1961
1962         * Scripts/bisect-builds:
1963         (findMacOSXVersion): Added.
1964         (makeNightlyList): Added argument to provide version of Mac OS X.
1965         Restrict range of nightly builds based on Safari and Mac OS X versions.
1966
1967 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1968
1969         Reviewed by Maciej.
1970
1971         - This patch involves several changes, all of them were noticed that
1972         they were needed by the work being done in WebKit to get Drosera and
1973         WebKit working together on Windows.
1974         - The changes are:
1975         1) Added a debugger console for output messages.
1976         2) Drosera now listens for the WebKit server (before, the server would
1977         have to be running before Drosera was started.)
1978         3) Fixed a bug where the WebView started out as 0x0 pixels.
1979         4) Fixed a bug when there is no scope.
1980         5) Added the HTML, JS, and CSS to the project file to make them easy to
1981         find.
1982         6) Made the ServerConnection functions virtual.
1983
1984         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1985         for the WebKit server.
1986         (DebuggerClient::DebuggerClient):
1987         (DebuggerClient::~DebuggerClient):
1988         (DebuggerClient::didFinishLoadForFrame):
1989         (DebuggerClient::serverConnected):
1990         (DebuggerClient::attemptToCreateServerConnection):
1991         * Drosera/win/DebuggerClient.h: Ditto.
1992         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1993         scope.
1994         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1995         (DebuggerDocument::platformValueForScopeVariableNamed):
1996         * Drosera/win/Drosera.cpp:
1997         (_tWinMain): Added a console in debug for output messages.
1998         (Drosera::Drosera): Listen for server.
1999         (Drosera::initUI): The server now Initializes COM.
2000         (Drosera::serverConnected): Part of the listening for the server.
2001         (Drosera::attemptToCreateServerConnection): Ditto.
2002         * Drosera/win/Drosera.h: New interface for listening for the server.
2003         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2004         files to the VS project.
2005         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2006         connection.
2007         (ServerConnection::ServerConnection):
2008         (ServerConnection::attemptToCreateServerConnection):
2009         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2010         methods.
2011         (ServerConnection::serverConnected):
2012
2013 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2014
2015         Reviewed by Maciej.
2016
2017         http://bugs.webkit.org/show_bug.cgi?id=15832
2018         fast/dom/gc-10.html crashes when run alone
2019
2020         Check for !done before using objects that can be already deallocated.
2021
2022         * DumpRenderTree/mac/EditingDelegate.mm:
2023         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2024         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2025         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2026         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2027         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2028         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2029         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2030         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2031         (-[EditingDelegate webViewDidBeginEditing:]):
2032         (-[EditingDelegate webViewDidChange:]):
2033         (-[EditingDelegate webViewDidEndEditing:]):
2034         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2035         (-[EditingDelegate webViewDidChangeSelection:]):
2036         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2037         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2038         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2039         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2040         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2041         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2042         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2043         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2044         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2045         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2046         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2047         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2048         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2049         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2050         (-[FrameLoadDelegate webView:willCloseFrame:]):
2051         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2052         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2053         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2054         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2055         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2056         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2057         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2058         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2059         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2060
2061 2007-11-04  Mark Rowe  <mrowe@apple.com>
2062
2063         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2064         warnings that would otherwise be suppressed due to it being a system header.
2065
2066         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2067
2068 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2069
2070         Rubber stamped by Adam.
2071         
2072         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2073
2074         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2075
2076 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2077
2078         Sort files(...); sections of Xcode project files.
2079
2080         Rubber-stamped by Darin.
2081
2082         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2083         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2084         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2085         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2086
2087 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2088
2089         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2090
2091         Reviewed by Darin.
2092
2093         * Scripts/sort-Xcode-project-file: Added.
2094
2095 2007-11-02  Darin Adler  <darin@apple.com>
2096
2097         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2098
2099 2007-11-02  Darin Adler  <darin@apple.com>
2100
2101         Reviewed by Maciej.
2102
2103         * Scripts/run-sunspider: Pass the "--base" option through.
2104
2105         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2106         the real script do that. Default configuration to Release to match run-sunspider
2107         so we don't end up building Debug just to compare results.
2108
2109 2007-11-01  Adam Roben  <aroben@apple.com>
2110
2111         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2112
2113         Reviewed by Sam.
2114
2115         * Scripts/commit-log-editor: Show all the directories beneath the
2116         source root, instead of just the last one.
2117
2118 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2119
2120         Reviewed by Adam Roben.
2121
2122         Print out an error message when the Windows build fails
2123         and provide guidance on how to find out what went wrong.
2124
2125         * Scripts/build-webkit:
2126         * Scripts/webkitdirs.pm:
2127
2128 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2129
2130         Rubber-stamped by Adam Roben.
2131
2132         Rolled out r27326 - debug CRT seems to cause no problems after all.
2133
2134         * DumpRenderTree/win/DumpRenderTree.vcproj:
2135
2136 2007-10-31  Adam Roben  <aroben@apple.com>
2137
2138         Switch the Debug configuration to using the non-debug CRT
2139
2140         This matches WebKit.
2141
2142         Reviewed by Steve.
2143
2144         * DumpRenderTree/win/DumpRenderTree.vcproj:
2145
2146 2007-10-31  Antti Koivisto  <antti@apple.com>
2147
2148         Reviewed by bdash.
2149         
2150         Disable media tests when doing leak checking on Tiger.
2151         They crash in QuickTime (rdar://problem/5537157).
2152
2153         * Scripts/run-webkit-tests:
2154
2155 2007-10-29  Antti Koivisto  <antti@apple.com>
2156
2157         Reviewed by Maciej.
2158         
2159         Build media support by default on OSX only.
2160
2161         * Scripts/build-webkit:
2162
2163 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2164
2165         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2166         get caught by the pre-commit hooks.
2167
2168 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2169
2170         Reviewed by Adam.
2171
2172         - This is a collection of relatively unrelated changes and cleanups
2173         to Drosera to prepare it for interacting with WebKit.  A lot of these
2174         changes are just correcting mistakes, for example removing included
2175         headers that are no longer needed.
2176
2177         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2178         this will be needed by the DebuggerClient.
2179         (DebuggerDocument::server):
2180         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2181         * Drosera/win/DebuggerClient.cpp: 
2182         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2183         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2184         (DebuggerClient::createWebViewWithRequest): Added comment about its
2185         purpose. 
2186         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2187         declarations.
2188         (DebuggerClient::webViewLoaded): Moved.
2189         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2190         file, since this was the only place it was used.
2191         (cfStringToBSTR):
2192         * Drosera/win/Drosera.h: Cleaned up the includes.
2193         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2194         * Drosera/win/HelperFunctions.h: Removed.
2195
2196 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2197
2198         Reviewed by Adam.
2199
2200         - Small cleanup in the ServerConnection class.
2201
2202         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2203         and added an include.
2204         (ServerConnection::currentFrame):
2205         (ServerConnection::getCallerFrame):
2206         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2207         made a pointer into a COMPtr, and cleaned up the includes.
2208
2209 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2210
2211         Reviewed by John Sullivan.
2212         
2213         - Place the Localizable.strings file in mac or win directories
2214           if that location exists.
2215         - Also look for UI_STRING in .c files.
2216
2217         * Scripts/extract-localizable-strings:
2218
2219 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2220
2221         Reviewed by Adam.
2222
2223         - Set the eol-style to native and made all the line endings the same
2224         so that I avoid messy diffs that show eol changes.
2225
2226         * Drosera/win/ServerConnection.cpp:
2227         (ServerConnection::didParseSource):
2228         (ServerConnection::didEnterCallFrame):
2229         (ServerConnection::willExecuteStatement):
2230         (ServerConnection::willLeaveCallFrame):
2231         (ServerConnection::exceptionWasRaised):
2232
2233 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2234
2235         Reviewed by Adam.
2236
2237         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2238         functionality that could not have existed previously without the new
2239         interfaces.
2240         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2241         from a BSTR to a JSValueRef.
2242         (DebuggerDocument::platformEvaluateScript): Implemented.
2243         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2244         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2245         Implemented.
2246         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2247         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2248         * Drosera/win/ServerConnection.cpp: Added a helper function.
2249         (ServerConnection::getCallerFrame):
2250         * Drosera/win/ServerConnection.h: Added a helper function.
2251
2252 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2253
2254         updated reviewers for my previous changelog.
2255
2256 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2257         Reviewed by Maciej and Adam and Geoff.
2258
2259         - Minor mac-side improvements including moving a function to a more
2260         appropriate location, fixing a warning, and correctly checking
2261         exceptions.
2262
2263         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2264         (DebuggerDocument::willExecuteStatement):
2265         (DebuggerDocument::didEnterCallFrame):
2266         (DebuggerDocument::willLeaveCallFrame):
2267         (DebuggerDocument::windowScriptObjectAvailable):
2268         (DebuggerDocument::callFunctionOnObject):
2269         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2270         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2271         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2272         because it doesn't require the ServerConnection at all.
2273         (NSStringCreateWithJSStringRef): Made an argument const.
2274         (JSValueRefCreateWithNSString): Made an argument const.
2275         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2276         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2277         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2278         * Drosera/mac/ServerConnection.mm: Ditto.
2279         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2280
2281 2007-10-29  Sam Weinig  <sam@webkit.org>
2282
2283         Reviewed by Adam Roben.
2284
2285         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2286
2287         * DumpRenderTree/LayoutTestController.cpp:
2288         (LayoutTestController::LayoutTestController):
2289         (getGlobalFlagCallback):
2290         (setGlobalFlagCallback):
2291         (LayoutTestController::getJSClass):
2292         (LayoutTestController::staticValues):
2293         * DumpRenderTree/LayoutTestController.h:
2294         (LayoutTestController::globalFlag):
2295         (LayoutTestController::setGlobalFlag):
2296
2297 2007-10-29  Darin Adler  <darin@apple.com>
2298
2299         Reviewed by Maciej.
2300
2301         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2302         resolution instead of its default.
2303
2304 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2305
2306         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2307
2308         Reviewed by Mark Rowe.
2309
2310         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2311         was successfully resolved, but this would not show any status because the change had
2312         already been cached in the index using "git add".  The solution is to add an optional
2313         second argument to showStatus() which adds the "--cached" switch to the command.
2314
2315         * Scripts/resolve-ChangeLogs:
2316         (showStatus):
2317
2318 2007-10-28  Eric Seidel  <eric@webkit.org>
2319
2320         Reviewed by Maciej and Geoff, in unison.
2321
2322         * Scripts/run-webkit-tests: remove broken --svg option
2323
2324 2007-10-28  Darin Adler  <darin@apple.com>
2325
2326         Reviewed by Adam.
2327
2328         * Scripts/run-sunspider: Default to "Release" configuration rather than
2329         defaulting to the last configuration used as other scripts do. This can
2330         still be overriden on the command line with "--debug" if there's some
2331         reason to do so. Also fix a typo.
2332
2333         * Scripts/sunspider-compare-results: Fix a typo.
2334
2335 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2336
2337         Reviewed by Adam.
2338
2339         - Implemented the WebScriptDebugListener functions now that the
2340         WebScriptDebugServer exists
2341
2342         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2343         functions.
2344         (ServerConnection::currentFrame):
2345         (ServerConnection::didLoadMainResourceForDataSource):
2346         (ServerConnection::didParseSource):
2347         (ServerConnection::failedToParseSource):
2348         (ServerConnection::didEnterCallFrame):
2349         (ServerConnection::willExecuteStatement):
2350         (ServerConnection::willLeaveCallFrame):
2351         (ServerConnection::exceptionWasRaised):
2352         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2353         members arguments list.
2354
2355 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2356
2357         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2358         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2359
2360         Reviewed by Darin.
2361
2362         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2363         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2364         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2365         file.  Note that it may also be used as a stand-alone script.
2366
2367         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2368         * Scripts/resolve-ChangeLogs: Added.
2369         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2370
2371 2007-10-26  Mark Rowe  <mrowe@apple.com>
2372
2373         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2374         to the Qt port on the assumption that it was an implementation of the cross-platform
2375         LayoutTestController class.  It is not, so it did not need to be changed.
2376
2377         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2378
2379 2007-10-25  Mark Rowe  <mrowe@apple.com>
2380
2381         Reviewed by Maciej.
2382
2383         Fix builds with code coverage enabled.
2384
2385         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2386
2387 2007-10-25  Darin Adler  <darin@apple.com>
2388
2389         Reviewed by Mark Rowe.
2390
2391         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2392         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2393
2394 2007-10-25  Stephanie  <slewis@apple.com>
2395
2396         build Fix
2397
2398         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2399
2400 2007-10-25  Stephanie  <slewis@apple.com>
2401
2402         Reviewed by Mark Rowe, Adam Roben.
2403
2404         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2405
2406         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2407
2408 2007-10-25  Alice Liu  <alice.liu@apple.com>
2409
2410         Reviewed by Adam.
2411
2412         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2413
2414         Moving destructor into platform-specific files
2415         * DumpRenderTree/LayoutTestController.cpp:
2416         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2417         (LayoutTestController::~LayoutTestController):
2418         * DumpRenderTree/qt/jsobjects.cpp:
2419         (LayoutTestController::~LayoutTestController):
2420
2421         LayoutTestController wasn't being destroyed
2422         * DumpRenderTree/win/DumpRenderTree.cpp:
2423         (runTest):
2424
2425         Added declspec
2426         * DumpRenderTree/win/EditingDelegate.h:
2427
2428         Reset certain values on the webview (or related delegate) that might 
2429         have changed while running a test
2430         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2431         (LayoutTestController::~LayoutTestController):
2432
2433 2007-10-25  Adam Roben  <aroben@apple.com>
2434
2435         Make sunspider-compare-results work with relative paths
2436
2437         Reviewed by Sam.
2438
2439         * Scripts/sunspider-compare-results: Convert arguments to absolute
2440         paths before we chdir.
2441
2442 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2443
2444         Reviewed by Sam.
2445
2446         - Implemented server calls now the WebScriptDebugServer exists.
2447         - Also removed no longer needed call to initialize CG.
2448
2449         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2450         automatically now.
2451         (_tWinMain):
2452         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2453         (ServerConnection::ServerConnection):
2454         (ServerConnection::~ServerConnection):
2455         (ServerConnection::pause):
2456         (ServerConnection::resume):
2457         (ServerConnection::stepInto):
2458         (ServerConnection::applicationTerminating):
2459         (ServerConnection::serverConnectionDidDie):
2460         * Drosera/win/ServerConnection.h: Now uses the COM class.
2461
2462 2007-10-24  George Staikos  <staikos@kde.org>
2463
2464         Unbreak Qt build.
2465
2466         * Scripts/build-webkit:
2467
2468 2007-10-24  Adam Roben  <aroben@apple.com>
2469
2470         Remove now-unnecessary call to InitializeCoreGraphics
2471
2472         WebKit takes care of this now.
2473
2474         Reviewed by Ada.
2475
2476         * DumpRenderTree/win/DumpRenderTree.cpp:
2477         (initialize):
2478
2479 2007-10-24  Adam Roben  <aroben@apple.com>
2480
2481         Use WebTextRenderer in DRT
2482
2483         Reviewed by Ada.
2484
2485         * DumpRenderTree/win/DumpRenderTree.cpp:
2486         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2487
2488 2007-10-24  Sven Herzberg  <sven@imendio.com>
2489
2490         Reviewed by Mark Rowe.
2491
2492         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2493         Bug 15614: [GTK] qmake based backends don't build on OS X
2494
2495         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2496         GTK backend on a Mac
2497         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2498         isDarwin() to make it reusable in other places (like the workaround-
2499         for-prebuilt-qmake in build-webkit)
2500
2501 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2502
2503         Refurbish update-webkit script.
2504
2505         Reviewed by Adam.
2506
2507         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2508         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2509         multi-argument version of system() for flexibility and security.  Check for existence
2510         of Internal directory using -d test instead of -x.
2511
2512 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2513
2514         Minor clean-up of prepare-ChangeLog script.
2515
2516         Reviewed by Adam.
2517
2518         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2519         of a string.  Use multi-argument versions of open() and system() for flexibility and
2520         security.
2521
2522 2007-10-24  Alice Liu  <alice.liu@apple.com>
2523
2524         Reviewed by Oliver.
2525
2526         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2527
2528         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2529         replay the saved events when we're still processing the mousedown that starts the drag
2530         * DumpRenderTree/win/EventSender.cpp:
2531         (doMouseMove):
2532         * DumpRenderTree/win/UIDelegate.cpp:
2533         (UIDelegate::doDragDrop):
2534
2535 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2536
2537         Reviewed by Sam, Steve and Darin.
2538
2539         - Stubbed out the WebScriptDebugListener functionality in the Server
2540         Connection class to prepare it for receiving those callbacks.
2541         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2542         and the ServerConnection to not need to be initialized with a server
2543         name, since that is not the way we connect to the WebKit server. 
2544
2545         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2546         no exception.  Now it only loggs when there is an exception
2547         (DebuggerDocument::willExecuteStatement):
2548         (DebuggerDocument::didEnterCallFrame):
2549         (DebuggerDocument::willLeaveCallFrame):
2550         (DebuggerDocument::windowScriptObjectAvailable):
2551         (DebuggerDocument::callFunctionOnObject):
2552         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2553         to be instantiated with a server's name.
2554         (DebuggerClient::DebuggerClient):
2555         (DebuggerClient::didFinishLoadForFrame):
2556         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2557         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2558         a server name.
2559         (Drosera::init):
2560         (Drosera::initServer):
2561         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2562         instantiated with a server's name.
2563         * Drosera/win/ServerConnection.cpp: 
2564         (ServerConnection::ServerConnection): No longer needs a server name
2565         (ServerConnection::~ServerConnection): Only release the global context
2566         if there is one.
2567         (ServerConnection::serverConnectionDidDie): Stub for
2568         IWebScriptDebugListener
2569         (ServerConnection::QueryInterface): ditto
2570         (ServerConnection::AddRef): ditto
2571         (ServerConnection::Release): ditto
2572         (ServerConnection::didLoadMainResourceForDataSource): ditto
2573         (ServerConnection::didParseSource): ditto
2574         (ServerConnection::failedToParseSource): ditto
2575         (ServerConnection::didEnterCallFrame): ditto
2576         (ServerConnection::willExecuteStatement): ditto
2577         (ServerConnection::willLeaveCallFrame): ditto
2578         (ServerConnection::exceptionWasRaised): ditto
2579         * Drosera/win/ServerConnection.h: Stubbed out the
2580         IWebScriptDebugListener functions, and this class no longer needs to be
2581         instantiated with a server name.
2582
2583 2007-10-24  Lars Knoll  <lars@trolltech.com>
2584
2585         Reviewed by Simon.
2586
2587         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2588
2589         * DumpRenderTree/qt/jsobjects.h:
2590
2591 2007-10-24  Lars Knoll  <lars@trolltech.com>
2592
2593         Reviewed by Simon.
2594
2595         add another command.
2596
2597         * DumpRenderTree/qt/jsobjects.cpp:
2598         (TextInputController::doCommand):
2599
2600 2007-10-24  Lars Knoll  <lars@trolltech.com>
2601
2602         Reviewed by Simon.
2603
2604         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2605
2606         * DumpRenderTree/qt/jsobjects.cpp:
2607         (EventSender::keyDown):
2608         * DumpRenderTree/qt/jsobjects.h:
2609
2610 2007-10-24  Lars Knoll  <lars@trolltech.com>
2611
2612         Reviewed by Simon.
2613
2614         implement eventSender.keyDown().
2615
2616         * DumpRenderTree/qt/jsobjects.cpp:
2617         (EventSender::keyDown):
2618
2619 2007-10-24  Lars Knoll  <lars@trolltech.com>
2620
2621         Reviewed by Simon.
2622
2623         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2624
2625         * DumpRenderTree/qt/DumpRenderTree.cpp:
2626         (WebCore::DumpRenderTree::DumpRenderTree):
2627         (WebCore::DumpRenderTree::initJSObjects):
2628         * DumpRenderTree/qt/jsobjects.cpp:
2629         (TextInputController::doCommand):
2630
2631 2007-10-24  Lars Knoll  <lars@trolltech.com>
2632
2633         Reviewed by Simon.
2634
2635         first bit of implementation for the textinputcontroller.
2636
2637         * DumpRenderTree/qt/DumpRenderTree.cpp:
2638         (WebCore::DumpRenderTree::DumpRenderTree):
2639         * DumpRenderTree/qt/DumpRenderTree.h:
2640         * DumpRenderTree/qt/jsobjects.cpp:
2641         (TextInputController::TextInputController):
2642         (TextInputController::doCommand):
2643         * DumpRenderTree/qt/jsobjects.h:
2644
2645 2007-10-24  Lars Knoll  <lars@trolltech.com>
2646
2647         Reviewed by Simon.
2648
2649         make the man webpage believe it has focus, so the editing tests work correctly.
2650
2651         * DumpRenderTree/qt/DumpRenderTree.cpp:
2652         (WebCore::DumpRenderTree::DumpRenderTree):
2653
2654 2007-10-24  Lars Knoll  <lars@trolltech.com>
2655
2656         Reviewed by Simon.
2657
2658         implement layoutTestController.dumpEditingCallbacks() correctly.
2659
2660         * DumpRenderTree/qt/DumpRenderTree.cpp:
2661         (WebCore::DumpRenderTree::DumpRenderTree):
2662         * DumpRenderTree/qt/jsobjects.cpp:
2663         (LayoutTestController::reset):
2664         (LayoutTestController::dumpEditingCallbacks):
2665
2666 2007-10-24  Lars Knoll  <lars@trolltech.com>
2667
2668         Reviewed by Simon.
2669
2670         Implement support for testing editing.
2671
2672         * DumpRenderTree/qt/DumpRenderTree.cpp:
2673         (WebCore::DumpRenderTree::DumpRenderTree):
2674
2675 2007-10-23  Sam Weinig  <sam@webkit.org>
2676
2677         Check for null BSTR that can be passed to the UIDelegate methods
2678         from javascript null and undefined.  Fixes a failing test case on
2679         Windows (fast/dom/Window/alert-undefined.html)
2680
2681         Reviewed by Eric Seidel.
2682
2683         * DumpRenderTree/win/UIDelegate.cpp:
2684         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2685         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2686         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2687         (UIDelegate::webViewAddMessageToConsole):
2688
2689 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2690
2691         Reviewed by Darin.
2692         
2693         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2694
2695         * Scripts/build-testkjs:
2696
2697 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2698
2699         Reviewed by Darin.
2700
2701         - add wrapper that finds the right copy of testkjs
2702         
2703         * Scripts/sunspider-compare-results: Added.
2704
2705 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2706
2707         Reviewed by Sam.
2708
2709         - After talking with Steve I now see that the WebKit server must be
2710         running for DCOM to create the distributed objects, which makes sense
2711         and currently WebKit only allows one instance to be running at a time
2712         which avoids accidentally connecting to the wrong server
2713         - In light of this I have removed the code for the attach box and
2714         NotificationServer and known server names, since they are all extranious
2715         now.
2716
2717         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2718         names.
2719         (_tWinMain): Uses init instead of initUI.
2720         (droseraWndProc): No longer creats an attach dialog box.
2721         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2722         it's not manditory to call init before doing COM stuff.
2723         (Drosera::init): calls initUI and will call attach when the
2724         functionality exists. 
2725         (Drosera::initUI): Has changed very little.
2726         (Drosera::attach): Changed the signature to reflect that we no longer
2727         need the dictionary of known server names.
2728         * Drosera/win/Drosera.h: Removed notification classes and known server
2729         names.  Also renamed and moved some functions.
2730         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2731         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2732         headers to the resources folder. 
2733         * Drosera/win/resource.h: Removed the Attach box.
2734
2735 2007-10-22  Adam Roben  <aroben@apple.com>
2736
2737         Windows build fix
2738
2739         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2740
2741 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2742
2743         - Removed a leak that was fixed.
2744
2745         * Scripts/run-webkit-tests:
2746
2747 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2748
2749         Reviewed by Darin.
2750
2751         - Changed the Client so that the DebuggerDocument now own the
2752         ServerConnection.  This simplifies ownership and cleanup. 
2753
2754         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2755         ServerConnection.
2756         (DebuggerClient::initWithServerName):
2757         (DebuggerClient::didFinishLoadForFrame):
2758         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2759         ServerConnection.
2760         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2761         until after we have a server which we are attached to.
2762         (Drosera::initUI):
2763         (Drosera::attach):
2764         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2765         out previously.
2766
2767 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2768
2769         Reviewed by Nikolas.
2770
2771         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2772
2773         * Scripts/run-javascriptcore-tests:
2774
2775 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2776
2777         Reviewed by Nikolas.
2778
2779         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2780
2781         * Scripts/build-drosera:
2782         * Scripts/build-dumprendertree:
2783         * Scripts/build-testkjs:
2784         * Scripts/build-webkit:
2785         * Scripts/run-javascriptcore-tests:
2786         * Scripts/run-sunspider:
2787         * Scripts/run-webkit-tests:
2788         * Scripts/webkitdirs.pm:
2789
2790 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2791
2792         Reviewed by Mark Rowe.
2793         
2794         Fix for local database support after r26879
2795         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2796
2797         * Scripts/build-webkit:
2798
2799 2007-10-22  Holger Freyther  <zecke@selfish.org>
2800
2801         Reviewed by Simon Hausmann <hausmann@kde.org>.
2802
2803         - Do not build testkjs as an application bundle. This is
2804         needed for run-javascriptcore-tests on OSX.
2805         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2806         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2807         as we do not have -rpath on OSX.
2808
2809         * DumpRenderTree/qt/DumpRenderTree.pro:
2810         * Scripts/run-webkit-tests:
2811
2812 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2813
2814         Reviewed by aroben.
2815
2816         Fix support for Signed-off-by detection in prepare-ChangeLog
2817         --git-commit. The Signed-off-by tag does not appear in the header
2818         but usually at the end.
2819
2820         * Scripts/prepare-ChangeLog:
2821
2822 2007-10-21  Mark Rowe  <mrowe@apple.com>
2823
2824         Reviewed by Eric.
2825
2826         Fix run-javascriptcore-tests for Gtk.
2827
2828         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2829
2830 2007-10-20  Eric Seidel  <eric@webkit.org>
2831
2832         Reviewed by aroben.
2833
2834         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2835
2836 2007-10-20  Eric Seidel  <eric@webkit.org>
2837
2838         Reviewed by darin.
2839         
2840         Add improved argument handling to run-sunspider, including
2841         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2842         Also re-factor code into subroutines
2843
2844         * Scripts/build-dumprendertree: removed bogus comments
2845         * Scripts/build-testkjs: Added.
2846         * Scripts/run-javascriptcore-tests: use build-testkjs
2847         * Scripts/run-sunspider: improved argument handling, abstraction
2848         * Scripts/run-webkit-tests: improved abstraction
2849
2850 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2851
2852         Not reviewed, Windows build fix.
2853
2854         * DumpRenderTree/win/EventSender.cpp:
2855         (keyDownCallback):
2856
2857 2007-10-20  Darin Adler  <darin@apple.com>
2858
2859         Reviewed by Tim Hatcher.
2860
2861         - http://bugs.webkit.org/show_bug.cgi?id=15544
2862           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2863           not rely on Apple-specific key codes
2864
2865         * DumpRenderTree/mac/EventSendingController.mm:
2866         (-[EventSendingController keyDown:withModifiers:]):
2867         Added named key "rightArrow". Later we could have a whole table of these.
2868         Also tweaked modifiers code a little.
2869
2870         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2871
2872 2007-10-19  Darin Adler  <darin@apple.com>
2873
2874         Reviewed by Eric.
2875
2876         - http://bugs.webkit.org/show_bug.cgi?id=15566
2877           possible fix for leak seen in DumpRenderTree
2878
2879         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2880         Delete the item if it's not put on the queue, since the caller has
2881         no way of knowing that. Would be better to have the parameter type
2882         be auto_ptr to express the fact that we take ownership.
2883
2884         - unrelated change
2885
2886         * Drosera/mac/main.m: Add missing include.
2887
2888 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2889
2890         Reviewed by Adam.
2891
2892         - This change should be identical but for some reason was not working
2893         on my machine.
2894
2895         * Scripts/prepare-ChangeLog:
2896
2897 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2898
2899         Reviewed by Oliver and Tim.
2900
2901         - Made use of RetainPtr to avoid retain and release issues and moved the
2902         log function to DebuggerDocumentPlatform, which seems to be a more
2903         logical place for it to live.
2904         - Also moved knownServers from the ServerConnection to
2905         DebuggerApplication to match the Windows code and because it makes sense
2906         that a connection knows its own server but not all of them.
2907
2908         * Drosera/mac/DebuggerClient.h: Moved the log function to
2909           DebuggerDocumentPlatform.
2910         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2911           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2912           call for the server name up from the ServerConnection class.
2913         (-[DebuggerClient dealloc]):
2914         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2915           for the server name up from the ServerConnection.
2916         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2917         (DebuggerDocument::platformPause):
2918         (DebuggerDocument::platformResume):
2919         (DebuggerDocument::platformStepInto):
2920         (DebuggerDocument::platformEvaluateScript):
2921         (DebuggerDocument::getPlatformCurrentFunctionStack):
2922         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2923         (DebuggerDocument::platformValueForScopeVariableNamed):
2924         (DebuggerDocument::platformLog): Log directly from here. No need to call
2925           DebuggerClient.
2926         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2927           way I see it, a ServerConnection should only know about its connection
2928           and the group of all possible servers should be kept by the
2929           application.
2930         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2931           currentServerName, it makes sense that the connection should know that
2932           name.
2933         (-[ServerConnection currentServerName]):
2934
2935 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2936
2937         Reviewed by Adam.
2938
2939         - Integrated changes from mac drosera.  Recently I've encapsulated
2940         out the server connection object from the rest of Drosera because
2941         it is very platform dependent right now and RPC is not implemented on
2942         windows.  This functionality, of communicating with the WebKit server
2943         is the next area I will be focusing on in Windows.
2944
2945         - Other changes and cleanup were made to organize the code and add notes
2946         on which parts still need work.  Also some mac code is added and
2947         commented out, to act as pseudocode for the logic of those parts.
2948
2949         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2950           pointer.
2951         * Drosera/config.h: Added whitespace.
2952         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2953           these files got moved into Drosera.h/cpp
2954         * Drosera/win/DebuggerApplication.h: Removed.
2955         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2956           happened here to better match the logic flow of the same code on the 
2957           mac side and to use the new ServerConnection class.
2958         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2959         (DebuggerClient::initWithServerName): Initializer that will set up the
2960           class to use a ServerConnection object.  This was necessary so I could
2961           create a DebuggerClient without having to initilaize it at
2962           construction.
2963         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2964           will be the UIDelegate and FrameLoadDelegate.
2965         (DebuggerClient::AddRef): For IUnknown.
2966         (DebuggerClient::Release): For IUnknown.
2967         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2968           this still needs to set the global context of the server, but
2969           IWebFrame does not have an accessor for the global context yet. 
2970         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2971           this is a pass through for the same function in the document.
2972         (DebuggerClient::didReceiveTitle): Unimplemented part of
2973           FrameLoadDelegate this would change the title of the window.
2974         (DebuggerClient::createWebViewWithRequest): Part of the
2975           FrameLoadDelegate.  This is about new windows via Window.open() and
2976           how their delegates are set.
2977         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2978           UIDelegate.  Just a debug function for printing messages.
2979         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2980           because the Client should be the UIDelegate and FrameLoadDelegate
2981           to match the delegates on mac.
2982         (DebuggerClient::webViewLoaded): Added accessor method.
2983         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2984           forgotten to add this file before.  This is where the platform
2985           dependent versions of the Documents functions live. Most of these are
2986           unimplemented because some piece of functionality does not exist on
2987           Windows yet.
2988         (DebuggerDocument::platformPause):
2989         (DebuggerDocument::platformResume):
2990         (DebuggerDocument::platformStepInto):
2991         (DebuggerDocument::platformEvaluateScript):
2992         (DebuggerDocument::getPlatformCurrentFunctionStack):
2993         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2994         (DebuggerDocument::platformValueForScopeVariableNamed):
2995         (DebuggerDocument::platformLog):
2996         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2997           responsibilities becaue they belong in the Client. Also I laid the
2998           groundwork for attaching Drosera to a WebKit process
2999         (attachWndProc): Now if a server is selected the Client becomes it's
3000           delegate.
3001         (Drosera::Drosera): Added the construction of the Client and dictionary
3002           of server names. 
3003         (Drosera::initUI): This is no longer the delegates, the Client is.
3004         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3005           state. 
3006         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3007           notification registration when it's possible to implement.
3008         (Drosera::serverLoaded): Ditto
3009         (Drosera::serverUnloaded): Ditto
3010         (Drosera::attach): Attach Drosera to the WebKit server.
3011         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3012         (Drosera::getInst): 
3013         (Drosera::setInst):
3014         (Drosera::knownServers):
3015         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3016           and added the ServerConnection.
3017         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3018         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3019           Most of the functions are completely unimlemented because they cannot
3020           connect with the WebKit server, because one does not exist on Windows
3021           yet.
3022         (ServerConnection::initWithServerName): 
3023         (ServerConnection::~ServerConnection):
3024         (ServerConnection::setGlobalContext):
3025         (ServerConnection::pause):
3026         (ServerConnection::resume):
3027         (ServerConnection::stepInto):
3028         (ServerConnection::switchToServerNamed):
3029         (ServerConnection::applicationTerminating):
3030         (ServerConnection::serverConnectionDidDie):
3031         (ServerConnection::currentFrame):
3032         * Drosera/win/ServerConnection.h: Added. Ditto.
3033         (ServerConnection::ServerConnection):
3034
3035 2007-10-19  Alice Liu  <alice.liu@apple.com>
3036
3037         Reviewed by Darin.
3038
3039         Fix for these broken layout tests on Windows:
3040         
3041         fast/forms/focus-selection-input.html
3042         fast/forms/focus-selection-textarea.html
3043         fast/forms/select-accesskey.html
3044         
3045         * DumpRenderTree/win/EventSender.cpp:
3046         (keyDownCallback):
3047         correct the VK code for alt key.
3048         
3049 2007-10-19  Eric Seidel  <eric@webkit.org>
3050
3051         Reviewed by Mark Rowe.
3052         
3053         Make the GtkLauncher code slightly more readable.
3054
3055         * GtkLauncher/main.cpp:
3056         (setupMainMenu): Added.
3057         (setupMainWindowUI): Added.
3058         (main):
3059
3060 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3061
3062         Rubber stamped by Adam.
3063         
3064         - don't delay-load WebKit in DumpRenderTree.
3065
3066         * DumpRenderTree/win/DumpRenderTree.vcproj:
3067
3068 2007-10-18  Dan Bernstein  <mitz@apple.com>
3069
3070         Reviewed by Adam Roben.
3071
3072         - fix <rdar://problem/5313523>
3073         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3074
3075         * DumpRenderTree/mac/DumpRenderTree.mm:
3076         (dump): Changed to use _responseMIMEType.
3077
3078 2007-10-17  Adam Roben  <aroben@apple.com>
3079
3080         Make it possible to have Windows-specific tests and results
3081
3082         When searching for tests to run and the Skipped file, we will only
3083         look in platform/win and the cross-platform directory. When looking
3084         for expected results, we will look in platform/win, then
3085         platform/mac-leopard, then platform/mac, then finally the
3086         cross-platform directory.
3087
3088         Reviewed by Sam.
3089
3090         * Scripts/run-webkit-tests:
3091         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3092         searching in the cross-platform directory.
3093         (sub buildPlatformHierarchy): Removed some unneeded calls to
3094         dirname/basename.
3095
3096 2007-10-17  Adam Roben  <aroben@apple.com>
3097
3098         Add back the call to register WebKit that we had before WebKitInitializer existed
3099
3100         This is needed to ensure that the right WebKit is used when
3101         instantiating COM objects.
3102
3103         Reviewed by Oliver.
3104
3105         * DumpRenderTree/win/debug_internal.vsprops: Define
3106         DEBUG_WEBKIT_HAS_SUFFIX.
3107         * DumpRenderTree/win/DumpRenderTree.cpp:
3108         (initialize):
3109
3110 2007-10-17  Adam Roben  <aroben@apple.com>
3111
3112         Import File::Basename in webkitdirs since we use it
3113
3114         * Scripts/webkitdirs.pm:
3115
3116 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3117
3118         - Updated the tiger leaks list to make the internal bots green.
3119
3120         * Scripts/run-webkit-tests:
3121
3122 2007-10-17  Adam Roben  <aroben@apple.com>
3123
3124         Build fix for VC++ Express
3125
3126         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3127         and ole32.lib.
3128
3129 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3130
3131         Reviewed by Sam.
3132
3133         - Minor mac improvements based on observations I made while implementing the
3134         Windows code.
3135
3136         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3137         then hand it to the Client who will retain it, it should just be the client who
3138         creates and owns the server.
3139         (-[DebuggerApplication attach:]):
3140         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3141         * Drosera/mac/DebuggerClient.mm: Creates the server.
3142         (-[DebuggerClient initWithServerName:]):
3143         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3144         can instead forward declare what it needs.
3145
3146 2007-10-16  Darin Adler  <darin@apple.com>
3147
3148         Reviewed by Geoff Garen.
3149
3150         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3151         want to turn failing tests into platform-specific test results. Also did a
3152         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3153         would take the type of results into account only some of the time.
3154
3155 2007-10-16  Adam Roben  <aroben@apple.com>
3156
3157         Add a new nightly launcher script for Windows
3158
3159         This new script is for versions of Safari that don't delay-load
3160         WebKit. I had to make FindSafari be able to print out the nightly
3161         launcher script on stdout because Windows shell scripts can't capture
3162         the output from a command into an environment variable.
3163
3164         Reviewed by Steve.
3165
3166         * FindSafari/FindSafari.cpp:
3167         (_tmain): Added /printSafariLauncher option.
3168         * Scripts/run-webkit-nightly.cmd: Added.
3169
3170 2007-10-16  Adam Roben  <aroben@apple.com>
3171
3172         Replace WebKitInitializer with FindSafari
3173
3174         We now rely on setting the PATH environment variable to tell Windows
3175         where to find WebKit and its dependencies (similar to
3176         DYLD_FRAMEWORK_PATH on Mac).
3177
3178         This change also make DumpRenderTree no longer delay-load WebKit.
3179
3180         Reviewed by Sam.
3181
3182         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3183         FindSafari.
3184         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3185         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3186         WebKitInitializer, don't delay-load WebKit.
3187         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3188         * Scripts/run-webkit-tests: Ditto.
3189         * Scripts/webkitdirs.pm:
3190         (sub setPathForRunningWebKitApp): Added.
3191         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3192         * WebKitInitializer/WebKitInitializer.h: Removed.
3193         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3194         * WebKitInitializer/debug.vsprops: Removed.
3195         * WebKitInitializer/debug_internal.vsprops: Removed.
3196         * WebKitInitializer/release.vsprops: Removed.
3197
3198 2007-10-16  Adam Roben  <aroben@apple.com>
3199
3200         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3201
3202         http://bugs.webkit.org/show_bug.cgi?id=15532
3203
3204         FindSafari simply prints the location of an installed Safari.exe on
3205         stdout.
3206
3207         Reviewed by Darin.
3208
3209         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3210         (getStringValue):
3211         (getWebViewCLSID):
3212         (getInstalledWebKitDirectory):
3213         (_tmain):
3214         * FindSafari/FindSafari.vcproj: Added.
3215         * Scripts/webkitdirs.pm:
3216         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3217
3218 2007-10-16  Adam Roben  <aroben@apple.com>
3219
3220         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3221
3222         Reviewed by Kevin McCullough.
3223
3224         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3225         when referring to WebKit.dll.
3226         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3227         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3228         * DumpRenderTree/win/release.vsprops: Ditto.
3229         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3230         never have a _debug suffix on WebKit.dll.
3231         * WebKitInitializer/WebKitInitializer.cpp:
3232         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3233         specified.
3234         * WebKitInitializer/debug_internal.vsprops: Added
3235         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3236
3237 2007-10-16  Darin Adler  <darin@apple.com>
3238
3239         Reviewed by Adele.
3240
3241         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3242         Remove now-unneeded control/alt key hack; the tests have been updated.
3243
3244 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3245
3246         - Updated leaks list because our internal bot upgraded it's version of leopard and 
3247         one of the leaks was fixed between that revision and the bot's previous version of
3248         leopard.
3249
3250         * Scripts/run-webkit-tests:
3251
3252 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3253
3254         Reviewed by Tim.
3255
3256         - I encapsulated out the server connecton functionality because it is a specific part
3257         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3258         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3259         Windows.  So the majority of this patch is moving preexisting functionality.
3260
3261         - Also I removed the prefix header and changed to use config.h because it is more
3262         standard on how we use config.h in windows and it didn't make much sense to keep
3263         the prefix header and the config.h
3264
3265         * Drosera/DebuggerDocument.cpp:
3266         (DebuggerDocument::DebuggerDocument):
3267         * Drosera/DebuggerDocument.h:
3268         * Drosera/config.h:
3269         * Drosera/mac/DebuggerApplication.mm:
3270         (-[DebuggerApplication attach:]):
3271         * Drosera/mac/DebuggerClient.h:
3272         * Drosera/mac/DebuggerClient.mm:
3273         (-[DebuggerClient initWithServerConnection:]):
3274         (-[DebuggerClient dealloc]):
3275         (-[DebuggerClient windowDidLoad]):
3276         (-[DebuggerClient windowWillClose:]):
3277         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3278         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3279         * Drosera/mac/DebuggerDocumentPlatform.mm:
3280         (DebuggerDocument::platformPause):
3281         (DebuggerDocument::platformResume):
3282         (DebuggerDocument::platformStepInto):
3283         (DebuggerDocument::platformEvaluateScript):
3284         (DebuggerDocument::getPlatformCurrentFunctionStack):
3285         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3286         (DebuggerDocument::platformValueForScopeVariableNamed):
3287         (DebuggerDocument::platformLog):
3288         * Drosera/mac/Drosera.pch: Removed.
3289         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3290         * Drosera/mac/ServerConnection.h: Added.
3291         * Drosera/mac/ServerConnection.mm: Added.
3292         (-[ServerConnection initWithServerName:]):
3293         (-[ServerConnection dealloc]):
3294         (-[ServerConnection setGlobalContext:]):
3295         (-[ServerConnection pause]):
3296         (-[ServerConnection resume]):
3297         (-[ServerConnection stepInto]):
3298         (-[ServerConnection switchToServerNamed:]):
3299         (-[ServerConnection applicationTerminating:]):
3300         (-[ServerConnection serverConnectionDidDie:]):
3301         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3302         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3303         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3304         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3305         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3306         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3307         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3308         (-[ServerConnection currentFrame]):
3309         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3310         (-[ServerConnection knownServers]):
3311
3312 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3313
3314         Reviewed by Eric.
3315
3316         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3317           Script to automatically search nightly builds for regressions (bisect-builds)
3318
3319         * Scripts/bisect-builds: Added.
3320
3321 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3322
3323         Reviewed by Darin.
3324
3325         - New JavaScript benchmark
3326         http://bugs.webkit.org/show_bug.cgi?id=15515
3327
3328         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3329         current development or release build of JavaScriptCore.
3330
3331 2007-10-15  Mark Rowe  <mrowe@apple.com>
3332
3333         Reviewed by Sam.
3334
3335         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3336
3337         * Scripts/webkitdirs.pm:
3338         - Change checkArgv to remove the options from @ARGV to prevent
3339         them from interfering with further option processing.
3340         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3341         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3342         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3343         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3344
3345 2007-10-15  Darin Adler  <darin@apple.com>
3346
3347         Reviewed by Sam.
3348
3349         - added logging of window.prompt and window.confirm
3350
3351         * DumpRenderTree/mac/UIDelegate.mm:
3352         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3353         Implement the recommended delegate rather than the deprecated one.
3354         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3355         Added.
3356         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3357         Added.
3358
3359         * DumpRenderTree/win/UIDelegate.h:
3360         * DumpRenderTree/win/UIDelegate.cpp:
3361         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3362         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3363         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3364         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3365
3366 2007-10-15  Alice Liu  <alice.liu@apple.com>
3367
3368         Reviewed by Sam Weinig.
3369
3370         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3371
3372         * DumpRenderTree/win/DumpRenderTree.cpp:
3373         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3374         (main): allocate the global policy delegate for DRT's custom use
3375         * DumpRenderTree/win/DumpRenderTree.vcproj:
3376         Adding files to project
3377         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3378         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3379         (LayoutTestController::setCustomPolicyDelegate):
3380         set the webview's policy delegate to DRT's custom one if the test requests it.
3381         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3382         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3383         (PolicyDelegate::PolicyDelegate):
3384         (PolicyDelegate::QueryInterface):
3385         (PolicyDelegate::AddRef):
3386         (PolicyDelegate::Release):
3387         (PolicyDelegate::decidePolicyForNavigationAction):
3388         * DumpRenderTree/win/PolicyDelegate.h: Added.
3389         (PolicyDelegate::decidePolicyForNewWindowAction):
3390         (PolicyDelegate::decidePolicyForMIMEType):
3391         (PolicyDelegate::unableToImplementPolicyWithError):
3392
3393 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3394
3395         Reviewed by Mark.
3396
3397         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3398         when querying for QMAKE_MKSPECS.
3399
3400 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3401
3402         Reviewed by Adam Roben.
3403         
3404         Fix run-webkit-tests is too greedy calculating platform hierarchy
3405         http://bugs.webkit.org/show_bug.cgi?id=15465
3406         
3407         Fix run-webkit-tests being too greedy in trying to split the platform name up
3408         causing it to try and find tests in every directory above the first "-" in the
3409         path to the LayoutTests
3410
3411         * Scripts/run-webkit-tests:
3412
3413 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3414
3415         Reviewed by Darin.
3416
3417         http://bugs.webkit.org/show_bug.cgi?id=15006
3418         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3419         to reduce code duplication.
3420
3421         * Scripts/build-webkit:
3422         * Scripts/webkitdirs.pm:
3423         buildQMakeProject() renamed to buildQMakeQtProject().
3424         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3425         unused $colorize has been removed.
3426
3427 === Start merge of feature-branch 2007-10-12 ===
3428
3429 2007-10-08  Eric Seidel  <eric@webkit.org>
3430
3431         Reviewed by Mark Rowe.
3432
3433         * Scripts/build-webkit: add --help, remove unused --color
3434
3435 2007-10-07  Eric Seidel  <eric@webkit.org>
3436
3437         Reviewed by darin.
3438
3439         * Drosera/mac/DebuggerDocumentPlatform.mm:
3440         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3441
3442 2007-10-03  Rob Buis  <buis@kde.org>
3443
3444         Reviewed by Olliej.
3445
3446         Adapt to changed location of Ahem font.
3447
3448         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3449
3450 2007-10-02  Eric Seidel  <eric@webkit.org>
3451
3452         Reviewed by Adam Roben.
3453         
3454         Make pixel tests more useful!
3455         Finally fix the image diff 0.00% mystery problem
3456         Highlight any image differences in the image diff.
3457         Add a link from image diffs back to original test file.
3458
3459         * DumpRenderTree/mac/ImageDiff.m:
3460         (compareImages): highlight any differences
3461         (computePercentageDifferent): round to two decimal places
3462         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3463
3464 2007-10-02  Eric Seidel  <eric@webkit.org>
3465
3466         Reviewed by Alexey Proskuryakov.
3467
3468         * Scripts/run-webkit-tests: print the % image difference on main results page
3469
3470 2007-10-02  Mark Rowe  <mrowe@apple.com>
3471
3472         Reviewed by Oliver.
3473
3474         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3475
3476         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3477         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3478
3479 2007-10-01  Mark Rowe  <mrowe@apple.com>
3480
3481         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3482
3483 2007-09-25  Eric Seidel  <eric@webkit.org>
3484
3485         Reviewed by Mark Rowe.
3486         
3487         DerivedSources.make was finding "ENABLE_SVG" in the string
3488         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3489         quite correctly.
3490
3491         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3492
3493 2007-09-25  Mark Rowe  <mrowe@apple.com>
3494
3495         Rubber-stamped by Eric.
3496
3497         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3498         This makes it possible to automate nightly builds for the feature-branch.
3499
3500 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3501
3502         Rubber stamped by Mark.
3503
3504         Enable svg experimental features as default here in feature-branch.
3505
3506         * Scripts/build-webkit:
3507
3508 2007-06-29  Antti Koivisto  <antti@apple.com>
3509
3510         Reviewed by Weinig.
3511         
3512         Add VIDEO flag for timed media features
3513
3514         * Scripts/build-webkit
3515         
3516 === End merge of feature-branch 2007-10-12 ===
3517
3518 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3519
3520         Reviewed by Darin.
3521
3522         - Updated rational for the leaks list to be more clear.
3523
3524         * Scripts/run-webkit-tests:
3525
3526 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3527
3528         Rubber Stamp by Sam.
3529
3530         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3531         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3532
3533         * Scripts/run-webkit-tests:
3534
3535 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3536
3537         Reviewed by Lars.
3538
3539         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3540         includes are needed for INT_MAX, std::auto_ptr and the like.
3541
3542         * DumpRenderTree/qt/main.cpp:
3543
3544 2007-10-09  Lars Knoll  <lars@trolltech.com>
3545
3546         Reviewed by Simon.
3547
3548         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3549
3550         * DumpRenderTree/qt/jsobjects.cpp:
3551         (LayoutTestController::encodeHostName):
3552         (LayoutTestController::decodeHostName):
3553         * DumpRenderTree/qt/jsobjects.h:
3554
3555 2007-10-09  Lars Knoll  <lars@trolltech.com>
3556
3557         Reviewed by Simon.
3558
3559         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3560
3561         * DumpRenderTree/qt/DumpRenderTree.cpp:
3562         (WebCore::WebPage::createFrame):
3563         (WebCore::DumpRenderTree::DumpRenderTree):
3564         (WebCore::DumpRenderTree::titleChanged):
3565         * DumpRenderTree/qt/DumpRenderTree.h:
3566         * DumpRenderTree/qt/jsobjects.cpp:
3567         (LayoutTestController::reset):
3568         * DumpRenderTree/qt/jsobjects.h:
3569
3570 2007-10-09  Lars Knoll  <lars@trolltech.com>
3571
3572         Reviewed by Simon.
3573
3574         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3575
3576         * DumpRenderTree/qt/DumpRenderTree.h:
3577         * DumpRenderTree/qt/jsobjects.cpp:
3578         (LayoutTestController::clearBackForwardList):
3579         * DumpRenderTree/qt/jsobjects.h:
3580
3581 2007-10-09  Lars Knoll  <lars@trolltech.com>
3582
3583         Reviewed by Simon.
3584
3585         make --git-reviewer work again.
3586
3587         * Scripts/prepare-ChangeLog:
3588
3589 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3590
3591         Rubber stamped by Eric.
3592
3593         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3594         show the current link inside the statusbar.
3595         This shows how to make use of this signal and allows to easily test
3596         http://bugs.webkit.org/show_bug.cgi?id=15299.
3597
3598         * GtkLauncher/main.cpp:
3599         (hoveringOverLink):
3600         (main):
3601
3602 2007-10-05  Lars Knoll  <lars@trolltech.com>
3603
3604         add proper error messages to the FrameLoaderClient.
3605         Implement ChromeClientQt::closeWindowSoon and
3606         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3607         Some fixes in DRT to make it work correctly with multiple windows.
3608
3609         Reviewed by Maciej.
3610
3611         * DumpRenderTree/qt/DumpRenderTree.cpp:
3612         (WebCore::DumpRenderTree::DumpRenderTree):
3613         (WebCore::DumpRenderTree::createWindow):