2008-03-07 Alp Toker <alp@atoker.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-03-07  Alp Toker  <alp@atoker.com>
2
3         Back out the r30818, r30819 build fix attempts now the GTK+ build
4         server has been upgraded.
5
6         * Scripts/webkitdirs.pm:
7
8 2008-03-07  Stephanie Lewis <slewis@apple.com>
9
10         Reviewed by Geoff.
11
12         <rdar://problem/5693690> run-webkit-tests swallows STDERR output, including WebCore LEAK messages
13
14         * DumpRenderTree/mac/DumpRenderTree.mm:
15         (dump): push EOF to stderr after every test
16         * Scripts/run-webkit-tests: collect stderr output and print it
17
18 2008-03-07  Steve Falkenburg  <sfalken@apple.com>
19
20         Get pdevenv working with Visual Studio Express.
21         
22         Reviewed by Adam.
23
24         * Scripts/pdevenv:
25
26 2008-03-06  Adele Peterson  <adele@apple.com>
27
28         Reviewed by Darin.
29
30         Updated for testing <rdar://problem/5785895> Implement hasFocus() for HTMLDocument (HTML5)
31
32         * DumpRenderTree/mac/UIDelegate.mm:
33         (-[UIDelegate webViewFocus:]): Remove duplicate code that was also in LayoutTestController::setWindowIsKey
34         (-[UIDelegate webViewUnfocus:]): Added.  In Safari, the default is to focus another window if there is one.
35          To easily test cases where the window is unfocused, I made this just call setWindowIsKey(false).
36
37 2008-03-06  Matt Lilek  <webkit@mattlilek.com>
38
39         Reviewed by Adam Roben.
40
41         Bug 17691: REGRESSION: FindSafari doesn't work
42         http://bugs.webkit.org/show_bug.cgi?id=17691
43
44         Swap my change from r30394 to use the Release libraries instead of Debug
45         since some machines don't have the Debug version.
46
47         * FindSafari/FindSafari.vcproj:
48
49 2008-03-06  Kevin McCullough  <kmccullough@apple.com>
50
51         Reviewed by Sam and Tim.
52
53         <rdar://5631450> Drosera: breakpoint indicators disappear after the
54         script is finished running.
55         - If there is a pre-existing breakpoint on a line when the file is
56         updated we need to redraw it.
57
58         * Drosera/debugger.js:
59
60 2008-03-06  Brady Eidson  <beidson@apple.com>
61
62         Tiger build fix...?
63
64         * DumpRenderTree/mac/WatchdogMac.mm:
65
66 2008-03-06  Brady Eidson  <beidson@apple.com>
67
68         Reviewed by Darin
69
70         Added a cross-platform Watchdog thread to DRT.
71
72         The current watchdog in both DRTWin and DRTMac is Timer based.  Therefore, deadlocks and long running
73         main thread hangs still affect DRT.
74
75         By placing the watchdog on a thread and having DRT "check in" after each test, long-running hangs
76         and true deadlocks can be caught.
77
78         There is one hook for platform specific code.  As I did my development and testing on Mac, and Mac has
79         `sample` available, the Mac implementation of this hook samples the process before it is killed.
80
81         I arbitrarily chose 30 seconds as the timeout for now - this can be tweaked easily if we find a need.
82
83         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
84         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added LINKER_DISPLAYS_MANGLED_NAMES
85
86         * DumpRenderTree/ForwardingHeaders/wtf/Locker.h: Added.
87         * DumpRenderTree/ForwardingHeaders/wtf/Threading.h: Added.
88
89         * DumpRenderTree/Watchdog.cpp: Added.
90         (Watchdog::Watchdog):
91         (Watchdog::~Watchdog):
92         (Watchdog::start):
93         (Watchdog::stop):
94         (Watchdog::checkIn):
95         (Watchdog::setWatchdogInterval):
96         (Watchdog::handleHang):
97         (Watchdog::watchdogThreadStart):
98         (Watchdog::watchdogThread):
99         * DumpRenderTree/Watchdog.h: Added.
100
101         * DumpRenderTree/mac/WatchdogMac.h: Added.
102         * DumpRenderTree/mac/WatchdogMac.mm: Added.
103         (WatchdogMac::handleHang): Sample the process and write it out to a file
104
105         * DumpRenderTree/mac/DumpRenderTree.mm:
106         (dumpRenderTree): Setup and start the watchdog before running any tests
107         (runTest): Checkin with the watchdog after each test
108
109 2008-03-05  Alp Toker  <alp@atoker.com>
110
111         Attempt to get the autotools build working again on the bot with
112         build-webkit.
113
114         Force the use of /bin/bash since we seem to have bash-isms in the
115         configure script right now.
116
117         * Scripts/webkitdirs.pm:
118
119 2008-03-05  Alp Toker  <alp@atoker.com>
120
121         Re-attempt to switch to the autotools build system for GTK+.
122
123         Change scripts to continue when distclean fails.
124
125         * Scripts/webkitdirs.pm:
126
127 2008-03-05  Alp Toker  <alp@atoker.com>
128
129         Force qmake for the GTK+ build until we get the build bot to succeed
130         with autotools (currently dies at make distclean)
131
132         * Scripts/webkitdirs.pm:
133
134 2008-03-04  Alp Toker  <alp@atoker.com>
135
136         Reviewed by Mark Rowe.
137
138         Switch the default GTK+ build system from qmake to autotools.
139
140         qmake can still be used by defining WEBKIT_BUILD_SYSTEM=qmake
141
142         * Scripts/build-webkit:
143         * Scripts/run-launcher:
144         * Scripts/run-webkit-tests:
145         * Scripts/webkitdirs.pm:
146
147 2008-03-04  Sam Weinig  <sam@webkit.org>
148
149         Reviewed by Darin Adler.
150
151         * Scripts/do-webcore-rename: Update renaming plan.
152
153 2008-03-02  Brent Fulgham  <bfulgham@gmail.com>
154
155         Reviewed by Alp Toker.
156
157         Remove some needless LIBS.
158
159         * GNUmakefile.am:
160
161 2008-03-02  Alp Toker  <alp@atoker.com>
162
163         Reviewed by Mark Rowe.
164
165         Split the WebKit GTK+ build out of the WebCore build and change the
166         shared object name to match the package name.
167
168         * GNUmakefile.am:
169
170 2008-03-01  Mark Rowe  <mrowe@apple.com>
171
172         Reviewed by Tim Hatcher.
173
174         Update Xcode configuration to support building debug and release from the mysterious future.
175
176         * DumpRenderTree/mac/Configurations/Base.xcconfig:
177
178 2008-02-29  David Kilzer  <ddkilzer@apple.com>
179
180         Pass the correct configuration switch (--Debug|--Release) to build-testkjs.
181
182         Reviewed by Dan.
183
184         Originally broken in r26838.
185
186         * Scripts/run-javascriptcore-tests: Push configuration switch onto @xcodeArgs
187         not local, unused @args variable.
188
189 2008-02-29  David Kilzer  <ddkilzer@apple.com>
190
191         Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks
192
193         <http://bugs.webkit.org/show_bug.cgi?id=15754>
194
195         Reviewed by Geoff and Darin.
196
197         We were using -[NSFileManager currentDirectoryPath] to get the current working directory,
198         then removing that path from all file:/// URLs in the WebArchive output so these tests
199         would pass no matter where they were run.
200
201         The problem was that -[NSFileManager currentDirectoryPath] resolves symlinks in the
202         current working directory, but the WebArchive does not.  This left the current working
203         directory in all file:/// URLs in the test output, and thus all tests failed, for any
204         developer that used symlinks to get to their WebKit source directory.
205
206         The fix is to look backwards for "/LayoutTests/" in the URL we're passed, and simply
207         remove the current working directory path (no matter what it is) after "file://" but
208         before "/LayoutTests/".  
209
210         * DumpRenderTree/mac/DumpRenderTree.mm:
211         (normalizeWebResourceURL): Removed unused oldURLBase argument.  We now replace the
212         current working directory as described above.
213         (convertWebResourceResponseToDictionary): Remove unused oldURLBase argument.  Update
214         calls to normalizeWebResourceURL().
215         (serializeWebArchiveToXML): Removed now unused cwdURL variable.  Update calls to
216         normalizeWebResourceURL() and convertWebResourceResponseToDictionary().
217
218 2008-02-26  Robin Dunn <robin@alldunn.com>
219
220         Reviewed by Kevin Ollivier.
221
222         Improvements to the wx build script.
223
224         http://bugs.webkit.org/show_bug.cgi?id=17492
225
226         * wx/build-wxwebkit:
227         - Update the Windows dll copying logic to copy dlls inside WebKitLibraries/win
228         - Allow the build script to properly find wxPython includes under different setups
229         - Make sure WX_PREFIX is set to WXWIN (wxWindows dir environment var.) if not defined
230
231 2008-02-26  Timothy Hatcher  <timothy@apple.com>
232
233         Reviewed by Darin Adler.
234
235         * Scripts/build-webkit: Add --universal and --64-bit flags to make building
236         64-bit architectures easy. Combine the two flags to build 4-way universal.
237         * Makefile: Add "64" and "64u" make rules. Fix the universal rule to return
238         non-zero when the build failes.
239
240 2008-02-26  Jessica Kahn  <jess@apple.com>
241
242         Reviewed by Darin.
243
244         * Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment,
245         so that Safari inherits it when launched. Preexisting code in WebKit checks this
246         environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications
247         launched by Safari continue to use the standard system WebKit.
248
249 2008-02-25  Adam Roben  <aroben@apple.com>
250
251         Fix run-webkit-tests after r30394
252
253         * Scripts/webkitdirs.pm: Never append _debug to FindSafari's
254         executable name.
255
256 2008-02-24  Darin Adler  <darin@apple.com>
257
258         * Scripts/do-webcore-rename: Make some updates based on a trial run of
259         the renaming script.
260
261 2008-02-24  Darin Adler  <darin@apple.com>
262
263         * Scripts/do-webcore-rename: More renaming plans.
264
265 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
266
267         Rubber stamped by Darin.
268
269         Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
270         whitespaces introduced in the previous commit.
271
272         * GNUmakefile.am:
273
274 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
275
276         Rubber-stamped by Darin.
277
278         * GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
279
280 2008-02-23  David Kilzer  <ddkilzer@apple.com>
281
282         Please clarify licensing for some files
283         <http://bugs.webkit.org/show_bug.cgi?id=14970>
284
285         Reviewed by Darin.
286
287         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Added
288         copyright statement.  Replaced license with newer Apple BSD-style license.
289         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Ditto.
290         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Ditto.
291         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Ditto.
292         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Ditto.
293         * DumpRenderTree/win/TestNetscapePlugin/main.c: Ditto.
294         * mangleme/LICENSE: Added (LGPL).
295
296 2008-02-22  Anders Carlsson  <andersca@apple.com>
297
298         Reviewed by Adam.
299
300         <rdar://problem/5748781> 
301         https://bugs.webkit.org/show_bug.cgi?id=17413
302         REGRESSION: Latest Nightly doesn't load Java plugin w/Safari 3.1b
303         
304         Copy the Java plug-in over to the new location.
305         
306         * FindSafari/FindSafari.cpp:
307         (_tmain):
308
309 2008-02-22  Anders Carlsson  <andersca@apple.com>
310
311         Reviewed by Adam.
312
313         <rdar://problem/5747325> REGRESSION: HTTP layout tests hang
314         
315         * DumpRenderTree/win/DumpRenderTree.cpp:
316         (runTest):
317         Init the URL request with the correct timeout.
318
319 2008-02-21  Mike Auty  <mike.auty@gmail.com>
320
321         Reviewed by Alp Toker.
322
323         http://bugs.webkit.org/show_bug.cgi?id=17445
324         [GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed"
325
326         GTK+/autotools build system improvements
327
328         The GNUmakefile.am files make use of the LDFLAGS variable to include library
329         additions such as -ljpeg etc.  Unfortunately, if these inclusions aren't made
330         in LIBADD/LDADD variables, then they are mis-ordered during the linking.
331
332         The as-needed flag discards libraries whose functions have not been needed by
333         earlier libraries, which therefore makes the ordering important.
334
335         This moves all -l library inclusion statements from LDFLAGS variables to
336         LIBADD/LDADD variables.
337
338         * GNUmakefile.am:
339
340 2008-02-20  Brent Fulgham  <bfulgham@gmail.com>
341
342         Reviewed by Alp.
343
344         - http://bugs.webkit.org/show_bug.cgi?id=17428
345           Reenable a Windows-based launcher
346
347         This patch reenables the venerable Spinneret application,
348         changing its name to match the other lanch applications.
349
350         * WinLauncher: Added.
351         * WinLauncher/WinLauncher.cpp: Added.
352         (WinLauncherWebHost::updateAddressBar):
353         (WinLauncherWebHost::QueryInterface):
354         (WinLauncherWebHost::AddRef):
355         (WinLauncherWebHost::Release):
356         (resizeSubViews):
357         (_tWinMain):
358         (MyRegisterClass):
359         (InitInstance):
360         (WndProc):
361         (MyEditProc):
362         (About):
363         (loadURL):
364         * WinLauncher/WinLauncher.h: Added.
365         (WinLauncherWebHost::WinLauncherWebHost):
366         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
367         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
368         (WinLauncherWebHost::didFailProvisionalLoadWithError):
369         (WinLauncherWebHost::didCommitLoadForFrame):
370         (WinLauncherWebHost::didReceiveTitle):
371         (WinLauncherWebHost::didReceiveIcon):
372         (WinLauncherWebHost::didFinishLoadForFrame):
373         (WinLauncherWebHost::didFailLoadWithError):
374         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
375         (WinLauncherWebHost::willPerformClientRedirectToURL):
376         (WinLauncherWebHost::didCancelClientRedirectForFrame):
377         (WinLauncherWebHost::willCloseFrame):
378         (WinLauncherWebHost::windowScriptObjectAvailable):
379         * WinLauncher/WinLauncher.ico: Added.
380         * WinLauncher/WinLauncher.rc: Added.
381         * WinLauncher/WinLauncher.vcproj: Added.
382         * WinLauncher/resource.h: Added.
383         * WinLauncher/small.ico: Added.
384         * WinLauncher/stdafx.cpp: Added.
385         * WinLauncher/stdafx.h: Added.
386
387 2008-02-19  Brady Eidson  <beidson@apple.com>
388
389         Reviewed by Geoff
390
391         Fixed a bug in DRT --threaded mode
392
393         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
394         (startJavaScriptThreads): Don't detach the newly created thread.  The later call to stopJavaScriptThreads() tries
395           to pthread_join() each thread that had been created, but you can't join a detached thread!
396
397 2008-02-18  Brady Eidson  <beidson@apple.com>
398
399         Changes by Geoff Garen, Reviewed by Darin
400
401         Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
402
403         DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html
404
405         [WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
406         This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread.  If the lock has leaked,
407         this series of method calls will deadlock.  If things are good, it will complete successfully.
408
409         * DumpRenderTree/mac/ObjCController.m:
410         (runJavaScriptThread):
411         (+[ObjCController isSelectorExcludedFromWebScript:]):
412         (+[ObjCController webScriptNameForSelector:]):
413         (-[ObjCController testValueForKey]):
414
415 2008-02-18  Matt Lilek  <webkit@mattlilek.com>
416
417         Reviewed by Adam.
418
419         Remove FindSafari's Release configuration.
420
421         * FindSafari/FindSafari.vcproj:
422
423 2008-02-15  Adam Roben  <aroben@apple.com>
424
425         Fix a typo that broke the Mac build
426
427         Reviewed by Mark.
428
429         * Scripts/build-webkit:
430
431 2008-02-14  Adam Roben  <aroben@apple.com>
432
433         Turn on cross-document messaging support by default
434
435         Reviewed by Darin.
436
437         * Scripts/build-webkit:
438
439 2008-02-14  Adam Roben  <aroben@apple.com>
440
441         Conditionalize cross-document messaging support
442
443         The cross-document messaging parts of HTML 5 are in flux and we want
444         ports to be able to turn off the support as needed.
445
446         Note that the support is turned off by default right now. A subsequent
447         commit will turn it on by default.
448
449         Reviewed by Darin.
450
451         * Scripts/build-webkit:
452
453 2008-02-14  Darin Adler  <darin@apple.com>
454
455        - fix Windows build
456
457         * DumpRenderTree/win/UIDelegate.cpp:
458         (UIDelegate::setStatusText): Update parameter types to match declaration.
459
460 2008-02-14  Oliver Hunt  <oliver@apple.com>
461
462         Reviewed by Geoff G and Weinig.
463
464         Add ability for DRT to report tests setting the status text.
465
466         * DumpRenderTree/LayoutTestController.cpp:
467         (LayoutTestController::LayoutTestController):
468         (dumpStatusCallbacksCallback):
469         (LayoutTestController::staticFunctions):
470         * DumpRenderTree/LayoutTestController.h:
471         * DumpRenderTree/mac/UIDelegate.mm:
472         (-[UIDelegate webView:setStatusText:]):
473         * DumpRenderTree/win/UIDelegate.cpp:
474         * DumpRenderTree/win/UIDelegate.h:
475
476 2008-02-13  Adam Roben  <aroben@apple.com>
477
478         Windows build fix
479
480         * DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.
481
482 2008-02-13  Adam Roben  <aroben@apple.com>
483
484         Windows/GTK+ build fix
485
486         * DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to
487         get isnan.
488
489 2008-02-13  Brady Eidson  <beidson@apple.com>
490
491         Reviewed by Darin Adler
492
493         Add some much needed Database support to DRT
494
495         * DumpRenderTree/LayoutTestController.cpp:
496         (LayoutTestController::LayoutTestController):
497         (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to
498           databases are called
499         (clearAllDatabasesCallback): Allow a test to delete all databases
500         (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get
501         (LayoutTestController::staticFunctions):
502
503         * DumpRenderTree/LayoutTestController.h:
504         (LayoutTestController::dumpDatabaseCallbacks):
505         (LayoutTestController::setDumpDatabaseCallbacks):
506
507         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
508         (LayoutTestController::clearAllDatabases):
509         (LayoutTestController::setDatabaseQuota):
510
511         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
512         (LayoutTestController::clearAllDatabases): Stubbed out
513         (LayoutTestController::setDatabaseQuota): Ditto
514         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
515         (LayoutTestController::clearAllDatabases): Stubbed out with error message
516         (LayoutTestController::setDatabaseQuota): Ditto
517
518         * DumpRenderTree/mac/UIDelegate.mm:
519         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a
520           message with details about the event then return a 5mb quota like before
521
522
523 2008-02-12  Steve Falkenburg  <sfalken@apple.com>
524
525         Changes to support merged MIDL output.
526
527         All COM interfaces are now generated to WebKit.h.
528
529         Reviewed by Sam, Ada.
530
531         * Drosera/win/BaseDelegate.h:
532         * Drosera/win/DebuggerClient.cpp:
533         * Drosera/win/DebuggerDocumentPlatform.cpp:
534         * Drosera/win/Drosera.cpp:
535         * Drosera/win/ServerConnection.cpp:
536         * Drosera/win/ServerConnection.h:
537         * DumpRenderTree/win/DumpRenderTree.cpp:
538         * DumpRenderTree/win/EditingDelegate.h:
539         * DumpRenderTree/win/EventSender.cpp:
540         * DumpRenderTree/win/FrameLoadDelegate.cpp:
541         * DumpRenderTree/win/FrameLoadDelegate.h:
542         * DumpRenderTree/win/GCControllerWin.cpp:
543         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
544         * DumpRenderTree/win/PolicyDelegate.h:
545         * DumpRenderTree/win/ResourceLoadDelegate.h:
546         * DumpRenderTree/win/UIDelegate.cpp:
547         * DumpRenderTree/win/UIDelegate.h:
548         * DumpRenderTree/win/WorkQueueItemWin.cpp:
549
550 2008-02-10  Dan Bernstein  <mitz@apple.com>
551
552         Reviewed by Oliver Hunt.
553
554         - fix a memory leak
555
556         * DumpRenderTree/cg/ImageDiffCG.cpp:
557         (getDifferenceBitmap): Use a static CFMutableData instead of allocating
558         and leaking the buffer each time.
559
560 2008-02-07  Adam Roben  <aroben@apple.com>
561
562         Fix error in bisect-builds when responding "broken" for the first
563         build
564
565         Reviewed by Dave Kilzer.
566
567         * Scripts/bisect-builds: Only try to test the build if the nightly
568         info for the current index has not been deleted.
569
570 2008-02-07  Geoffrey Garen  <ggaren@apple.com>
571
572         Reviewed by Alexey Proskuryakov.
573
574         Fixed two minor typos in the --root option, to get it working.
575
576         * Scripts/run-sunspider:
577             1. Actually assign the function argument to our local variable.
578             2. Actually set the $root variable, so we don't try to build later.
579
580 2008-02-05  Oliver Hunt  <oliver@apple.com>
581
582         RS=Eric.
583
584         Re-enable foreignObject by default as it is needed for a number of non-fO
585         related SVG tests and none of the old known crashes occur anymore.
586
587         * Scripts/build-webkit:
588
589 2008-02-05  Steve Falkenburg  <sfalken@apple.com>
590
591         Build fix.  Don't override intermediate directory.
592
593         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
594
595 2008-02-05  Holger Hans Peter Freyther  <zecke@selfish.org>
596
597         Build fix for Windows. willCloseFrame is a pure virtual and we are
598         forced to have an implementation.
599         
600         This partially reverts r30014.
601
602         * DumpRenderTree/win/FrameLoadDelegate.cpp:
603         (FrameLoadDelegate::willCloseFrame):
604         * DumpRenderTree/win/FrameLoadDelegate.h:
605
606 2008-02-05  Nikolas Zimmermann  <zimmermann@kde.org>
607
608         Reviewed by Holger.
609
610         Don't build wrapper for SVGTestCase.js (special file for svg/dynamic-updates)
611
612         * Scripts/make-js-test-wrappers:
613
614 2008-02-05  Holger Freyther  <zecke@selfish.org>
615
616         Reviewed by Darin.
617
618         In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
619         the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
620         depends on the order the tests are executed.
621         
622         Propose to remove willCloseFrame and didlCearWindowObject output from the
623         FrameLoadDelegate and update the test results. The output of didClearWindowObject
624         is not interesting for any of the current tests and we have other ways to find
625         out if a frame was closed or not.
626
627         * DumpRenderTree/mac/FrameLoadDelegate.mm:
628         * DumpRenderTree/win/FrameLoadDelegate.cpp:
629         (FrameLoadDelegate::didClearWindowObject):
630         * DumpRenderTree/win/FrameLoadDelegate.h:
631
632 2008-02-04  Mark Rowe  <mrowe@apple.com>
633
634         Reviewed by Oliver Hunt.
635
636         Workaround for http://bugs.webkit.org/show_bug.cgi?id=16842
637         Bug 16842: Hang in DRT in leaks mode due to signal handler doing unsafe things
638
639         Don't install the signal handler unless we are running the pixel tests.
640         It is currently only used to restore the color profile, but by catching
641         signals we can trigger a deadlock in DRT while running leak tests.
642         The deadlock is tracked by http://bugs.webkit.org/show_bug.cgi?id=16842,
643         and a more complete fix will need to be developed to address this for
644         pixel tests as well.
645
646         * DumpRenderTree/mac/DumpRenderTree.mm:
647         (dumpRenderTree):
648
649 2008-02-04  Mark Rowe  <mrowe@apple.com>
650
651        Gtk qmake build fix.
652
653         * Scripts/webkitdirs.pm:  Fix perl's complaint about an odd number of elements in anonymous hash.
654
655 2008-02-04  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
656
657         Reviewed by Alp Toker and Mark Rowe.
658
659         http://bugs.webkit.org/show_bug.cgi?id=16618
660         [GTK] build-webkit and run-webkit-tests autootools support
661
662         * Scripts/build-webkit: added --database and --icon-database options
663         * Scripts/run-launcher:
664         * Scripts/run-webkit-tests:
665         * Scripts/webkitdirs.pm:
666
667 2008-02-04  Oliver Hunt  <oliver@apple.com>
668
669         Reviewed by Steve F.
670
671         Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT
672
673         Implement required DRT functionality to allow majority of Drag and Drop testcases to work.
674         Issues include:
675           * Uses Sleep() to implement leapForward reliably.
676           * 3 DND tests still fail for reasons that i have not yet determined
677           * Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain 
678
679         * DumpRenderTree/win/EventSender.cpp:
680         (leapForwardCallback):
681         (mouseDownCallback):
682         (doMouseUp):
683         (mouseUpCallback):
684         (doMouseMove):
685         (mouseMoveToCallback):
686           Minor updates to these functions to handle the different message queue structure.
687
688         (replaySavedEvents):
689           More complicated now.  Where possible we just use the old while-loop model of execution,
690           but when leapForward has been used we have to jump through some hoops and set up an 
691           inner event loop so that we can ensure messages get the correct time stamp.
692
693         * DumpRenderTree/win/UIDelegate.cpp:
694         (UIDelegate::doDragDrop):
695           Call replaySavedEvents directly to force synchronous handling of drag and drop.
696
697 2008-02-04  Rodney Dawes  <dobey@wayofthemonkey.com>
698
699         Reviewed by Alp Toker and Mark Rowe.
700
701         Fix http://bugs.webkit.org/show_bug.cgi?id=17175.
702         Bug 17175: Use of C++ compiler flags in CFLAGS
703
704         * GNUmakefile.am: Use global_cxxflags as well as global_cflags in CXXFLAGS.
705
706 2008-02-04  Darin Adler  <darin@apple.com>
707
708         Reviewed by Geoff.
709
710         * Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast
711         and svg subdirectories. Added some more exceptions for the benefit of the fast/dom
712         subdirectory.
713
714 2008-02-04  Adam Roben  <aroben@apple.com>
715
716         Windows Apple-only build fix
717
718         * DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include
719         directory.
720
721 2008-02-04  Alp Toker  <alp@atoker.com>
722
723         Rubber-stamped by Mark Rowe.
724
725         Remove all trailing whitespace in the GTK+ port and related
726         components.
727
728         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
729         * DumpRenderTree/gtk/GCControllerGtk.cpp:
730         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
731         * GNUmakefile.am:
732
733 2008-02-01  Eric Seidel  <eric@webkit.org>
734
735         Reviewed by Oliver.
736
737         Also search LayoutTests/svg for js-based tests.
738
739         * Scripts/make-js-test-wrappers:
740
741 2008-01-31  Alp Toker  <alp@atoker.com>
742
743         Rubber-stamped by Adam Roben.
744
745         http://bugs.webkit.org/show_bug.cgi?id=17006
746         [GTK] Header path should be webkit/webkit.h
747
748         Move the GTK+ API sources as needed and update the build systems.
749
750         * DumpRenderTree/gtk/DumpRenderTree.cpp:
751         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
752         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
753         * GNUmakefile.am:
754         * GtkLauncher/main.c:
755
756 2008-01-30  Stephanie  <slewis@apple.com>
757
758         Reviewed by Geoff.
759
760         Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
761
762         * Scripts/run-webkit-tests:
763
764 2008-01-30  Alexey Proskuryakov  <ap@webkit.org>
765
766         Reviewed by Adam Roben.
767
768         One more debug (external) fix.
769
770         * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
771         and Debug configurations. 
772
773 2008-01-29  Geoffrey Garen  <ggaren@apple.com>
774
775         Reviewed by Sam Weinig. Sam Weinig.
776         
777         Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
778         fails when run after fast/dom/Window/window-property-shadowing.html (16902)
779
780         Modified our policy delegates not to output window.name. Since a
781         previous test may have explicitly set window.name, we can't rely on its
782         implicit value in test results.
783
784         * DumpRenderTree/mac/PolicyDelegate.mm:
785         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
786
787         * DumpRenderTree/win/PolicyDelegate.cpp:
788         (PolicyDelegate::decidePolicyForNavigationAction):
789
790 2008-01-29  Mark Rowe  <mrowe@apple.com>
791
792         Reviewed by Tim Hatcher.
793
794         <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
795
796         * Scripts/build-webkit: Copy SQLite static library and headers into the build directory.
797
798 2008-01-29  David Kilzer  <ddkilzer@apple.com>
799
800         Refactor ChangeLog path code
801
802         Reviewed by Adam.
803
804         * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
805         duplicate code in another foreach() loop.
806
807 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
808
809         Reviewed by Darin.
810
811         <rdar://problem/5710692> All storage tests fail/crash
812
813         * DumpRenderTree/mac/UIDelegate.mm:
814         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an
815         arbitrary quota of 5 megabytes.
816
817         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
818         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
819         Removed unused (I think) code.
820         
821         * DumpRenderTree/win/UIDelegate.cpp:
822         (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported.
823         (UIDelegate::webViewPainted): A stub implementation.
824         (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
825         * DumpRenderTree/win/UIDelegate.h:
826
827 2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
828
829         GTK+ DRT build fix for breakage introduced in r29822.
830
831         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
832         (LayoutTestController::setPersistentUserStyleSheetLocation):
833         (LayoutTestController::clearPersistentUserStyleSheet):
834
835 2008-01-27  Dan Bernstein  <mitz@apple.com>
836
837         Reviewed by Darin Adler.
838
839         - add support for directory prologues and epilogues to run-webkit-tests
840         - allow setting a persistent user style sheet in DumpRenderTree
841         - activate the WebKit Layout Tests font in Windows DumpRenderTree
842
843         * DumpRenderTree/LayoutTestController.cpp:
844         (clearPersistentUserStyleSheetCallback): Added.
845         (setPersistentUserStyleSheetLocationCallback): Added.
846         (LayoutTestController::staticFunctions): Added.
847         clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
848         * DumpRenderTree/LayoutTestController.h:
849         * DumpRenderTree/mac/DumpRenderTree.mm:
850         (setPersistentUserStyleSheetLocation): Added.
851         (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
852         to the set of things this function resets. Now it either disables the
853         user style sheet or sets it to the persistent user style sheet and
854         enables it.
855         * DumpRenderTree/mac/DumpRenderTreeMac.h:
856         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
857         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
858         (LayoutTestController::clearPersistentUserStyleSheet): Added.
859         * DumpRenderTree/win/DumpRenderTree.cpp:
860         (setPersistentUserStyleSheetLocation): Added.
861         (initialize): Added the WebKit Layout Tests font to the set of fonts to
862         install.
863         (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
864         * DumpRenderTree/win/DumpRenderTreeWin.h:
865         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
866         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
867         (LayoutTestController::clearPersistentUserStyleSheet): Added.
868         * Scripts/run-webkit-tests: Changed to look for, and if found process in
869         DumpRenderTree, files named run-webkit-tests-prologue.html and
870         run-webkit-tests-epilogue.html in the resources subdirectory of any
871         test directory and platform test results directory. The prologues are
872         processed before the first test from the directory (and its
873         subdirectories) is run, and the epilogues are processed after the last
874         test from the directory is run. Platform-specific prologues and
875         epilogues are processed in order of specificity.
876
877 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
878
879         Reviewed by Mark Rowe.
880
881         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
882
883         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
884         (matching Mac DRT).
885         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
886
887 2008-01-24  Sam Weinig  <sam@webkit.org>
888
889         Reviewed by Ada Chan.
890
891         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
892
893         - Adds simplified UndoManager to windows DRT to allow testing the
894           undo/redo code paths in WebCore and WebKit.  This is a temporary
895           solution to an issue that should eventually be solved by having a
896           shared UndoManager in WebKit.
897
898         * DumpRenderTree/win/DumpRenderTree.cpp:
899         (runTest):
900         * DumpRenderTree/win/UIDelegate.cpp:
901         (DRTUndoObject::DRTUndoObject):
902         (DRTUndoObject::invoke):
903         (DRTUndoStack::~DRTUndoStack):
904         (DRTUndoStack::isEmpty):
905         (DRTUndoStack::clear):
906         (DRTUndoStack::push):
907         (DRTUndoStack::pop):
908         (DRTUndoManager::canRedo):
909         (DRTUndoManager::canUndo):
910         (DRTUndoManager::DRTUndoManager):
911         (DRTUndoManager::removeAllActions):
912         (DRTUndoManager::registerUndoWithTarget):
913         (DRTUndoManager::redo):
914         (DRTUndoManager::undo):
915         (UIDelegate::UIDelegate):
916         (UIDelegate::resetUndoManager):
917         (UIDelegate::registerUndoWithTarget):
918         (UIDelegate::removeAllActionsWithTarget):
919         (UIDelegate::setActionTitle):
920         (UIDelegate::undo):
921         (UIDelegate::redo):
922         (UIDelegate::canUndo):
923         (UIDelegate::canRedo):
924         * DumpRenderTree/win/UIDelegate.h:
925
926 2008-01-23  Adam Roben  <aroben@apple.com>
927
928         Allow directories containing ChangeLogs to be passed to
929         resolve-ChangeLogs
930
931         Reviewed by David Kilzer.
932
933         * Scripts/resolve-ChangeLogs:
934         (sub findChangeLog): Return a ChangeLog contained within the specified
935         directory if one exists.
936
937 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
938
939         <rdar://problem/5698732> Copyright strings should include 2008
940
941         Reviewed by Sam.
942
943         * Drosera/win/Drosera.vcproj/Drosera.rc:
944         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
945
946 2008-01-23  Alp Toker  <alp@atoker.com>
947
948         Rubber-stamped by Mark Rowe.
949
950         Remove whitespace after -I in automake include lists.
951
952         * GNUmakefile.am:
953
954 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
955
956         Reviewed by Lars Knoll <lars@trolltech.com>.
957
958         Reworked the JavaScriptCore Qt bindings:
959         
960         * Update JS DRT controller for Qt JS binding changes.
961         There were two functions that needed some changes
962         so that the layout tests would work, so this makes
963         a few tests pass again.
964         
965         * Bump the timeout for layout tests up to 11s.
966         At least some tests have an internal timeout of
967         10 seconds, so make the waitUntilDone approach
968         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
969         is one of these - now the failure message is more
970         accurate.
971         
972
973         * DumpRenderTree/qt/jsobjects.cpp:
974         (LayoutTestController::waitUntilDone):
975         * DumpRenderTree/qt/jsobjects.h:
976
977 2008-01-22  Anders Carlsson  <andersca@apple.com>
978
979         Reviewed by Darin and Adam.
980
981         <rdar://problem/5688975>
982         div element on microsoft site has wrong left offset.
983         
984         Add new method for testing the return vale of NPN_GetProperty.
985         
986         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
987         (pluginInvoke):
988
989 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
990
991         Reviewed by Adam Roben.
992
993         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
994
995         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
996
997 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
998
999         Reviewed by Alp Toker.
1000
1001         http://bugs.webkit.org/show_bug.cgi?id=16955
1002         Get errors when cross-compile webkit-gtk
1003
1004         * GNUmakefile.am: Removed ICU_CFLAGS 
1005
1006 2008-01-21  Darin Adler  <darin@apple.com>
1007
1008         Reviewed by Mitz and Adam.
1009
1010         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
1011         sorting speed by doing all sort criteria in a single pass instead of three sorts.
1012
1013 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
1014
1015         Reviewed by Holger.
1016
1017         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
1018         
1019         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
1020         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
1021         and make the return value depend on whether we successfully determined a focusable
1022         node or not.
1023         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
1024         if we could not handle the focus chain ourselves.
1025         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
1026         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
1027         used to control the situation of stepping out of the focus chain inside the page.
1028         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
1029         The layout tests expect this to be disabled but for the user it seems sensible to have it
1030         on by default, hence the default in qwebsettings.cpp
1031         
1032
1033         * DumpRenderTree/qt/DumpRenderTree.cpp:
1034         (WebCore::WebPage::WebPage):
1035
1036 2008-01-19  Mark Rowe  <mrowe@apple.com>
1037
1038         Reviewed by Alp Toker.
1039
1040         Allow the --http flag to run-webkit-tests to override
1041         the default behaviour of disabling HTTP tests for Qt,
1042         Gtk and Wx.
1043
1044         * Scripts/run-webkit-tests:
1045
1046 2008-01-19  David Kilzer  <ddkilzer@apple.com>
1047
1048         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
1049
1050         Reviewed by Darin.
1051
1052         We now touch a check-for-global-initializers.timestamp file in
1053         the TARGET_TEMP_DIR directory to determine when new object files
1054         have been compiled and thus need to be checked.  If the timestamp
1055         file doesn't exist, all object files will be checked.
1056
1057         Previously the modification time of the "executable" (the
1058         framework binary, e.g., WebKit.framework/WebKit) was used, but
1059         since this was the last file modified at the end of the compile
1060         phase, no object files would ever get checked!
1061
1062         Also added JSCustomSQLTransactionCallback.o to the list of files
1063         since it has static initializers in Debug builds of WebCore.
1064
1065         * Scripts/check-for-global-initializers:
1066
1067 2008-01-18  Adam Roben  <aroben@apple.com>
1068
1069         Build fix
1070
1071         * Scripts/build-webkit:
1072
1073 2008-01-18  Beth Dakin  <bdakin@apple.com>
1074
1075         Reviewed by Oliver.
1076
1077         Update build-webkit to account for foreign-object being disabled by 
1078         default.
1079
1080         * Scripts/build-webkit:
1081
1082 2008-01-18  Adam Roben  <aroben@apple.com>
1083
1084         Updated for method renames
1085
1086         Reviewed by Adele.
1087
1088         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1089         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1090         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1091         (LayoutTestController::setMainFrameIsFirstResponder):
1092         (LayoutTestController::setWindowIsKey):
1093         * DumpRenderTree/mac/UIDelegate.mm:
1094         (-[UIDelegate webViewFocus:]):
1095         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1096         (FrameLoadDelegate::didCommitLoadForFrame):
1097
1098 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
1099
1100         Reviewed by Adam Roben.
1101
1102         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
1103         between DRT and TestNetscapePlugin.
1104
1105         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
1106         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
1107
1108 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
1109
1110         Reviewed by Holger.
1111
1112         Fix fast/dom/Window/window-resize.html
1113         
1114         In DRT connect the page's geometryChangeRequest signal to a slot that
1115         sets the geometry of the view widget.
1116         
1117
1118         * DumpRenderTree/qt/DumpRenderTree.cpp:
1119         (WebCore::WebPage::setViewGeometry):
1120         (WebCore::WebPage::WebPage):
1121
1122 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
1123
1124         Build fix.
1125
1126         * Drosera/DroseraWin.make:
1127
1128 2008-01-17  Darin Adler  <darin@apple.com>
1129
1130         * Scripts/run-webkit-tests: Fixed a bug number.
1131
1132 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
1133
1134         Reviewed by Adam Roben.
1135
1136         http://bugs.webkit.org/show_bug.cgi?id=16908
1137         run-webkit-tests complains about missing FindSafari.exe
1138
1139         * Scripts/webkitdirs.pm: Append _debug as appropriate.
1140
1141 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
1142
1143         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
1144         
1145         Rubber-stamped by Jon Honeycutt.
1146
1147         * DumpRenderTree/win/DumpRenderTree.vcproj:
1148
1149 2008-01-16  Alp Toker  <alp@atoker.com>
1150
1151         Reviewed by Mark Rowe.
1152
1153         http://bugs.webkit.org/show_bug.cgi?id=16218
1154         [GTK] API: Should this entry point be called go_back rather than go_backward?
1155
1156         Track back/forward API changes in the tools.
1157
1158         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1159         (BackForwardItem::invoke):
1160         * GtkLauncher/main.c:
1161         (go_back_cb):
1162
1163 2008-01-16  Adam Roben  <aroben@apple.com>
1164
1165         Windows build fix after r29488
1166
1167         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1168         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
1169         expects to find the plugin.
1170
1171 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
1172
1173         Reviewed by Sam Weinig.
1174         
1175         Fixed the waitUntilDone watchdog timer -- the old code never added the
1176         timer to the run loop, so it didn't do anything.
1177
1178         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1179         (LayoutTestController::setWaitToDump):
1180         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1181         (LayoutTestController::setWaitToDump):
1182
1183 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
1184
1185         Use shared vsprops for most vcproj properties.
1186         
1187         Reviewed by Darin.
1188
1189         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1190         * DumpRenderTree/win/DumpRenderTree.vcproj:
1191         * DumpRenderTree/win/ImageDiff.vcproj:
1192         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1193         * FindSafari/FindSafari.vcproj:
1194
1195 2008-01-14  Stephanie  <slewis@apple.com>
1196
1197        Reviewed by NOBODY.
1198   
1199        revert accidental character.
1200
1201        * Scripts/run-webkit-tests:
1202
1203 2008-01-14  Stephanie  <slewis@apple.com>
1204
1205         RS=Oliver
1206
1207         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
1208
1209         * Scripts/run-webkit-tests:
1210
1211 2008-01-14  Darin Adler  <darin@apple.com>
1212
1213         * Scripts/do-webcore-rename: Queue up another rename.
1214
1215 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1216
1217         Reviewed by Darin.
1218
1219         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
1220         the tests were ran.
1221         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
1222
1223         * Scripts/run-webkit-tests:
1224
1225 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1226
1227         Reviewed by Darin.
1228
1229         * Randomize tests array to spot test cases where the results depends on the order
1230         the tests are ran.
1231         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
1232
1233         * Scripts/run-webkit-tests:
1234
1235 2008-01-14  Darin Adler  <darin@apple.com>
1236
1237         * Scripts/run-webkit-tests: More ignore list tweaking.
1238
1239 2008-01-14  Darin Adler  <darin@apple.com>
1240
1241         * Scripts/run-webkit-tests: Add another leak to the ignore list.
1242
1243 2008-01-14  Dan Bernstein  <mitz@apple.com>
1244
1245         Reviewed by Adam Roben.
1246
1247         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
1248           build bots
1249
1250         * DumpRenderTree/win/DumpRenderTree.cpp:
1251         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
1252
1253 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
1254
1255         Share common files across projects.
1256         
1257         Unify vsprops files
1258         Debug:          common.vsprops, debug.vsprops
1259         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
1260         Release:        common.vsprops, release.vsprops
1261         
1262         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
1263         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
1264
1265         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
1266
1267         Reviewed by Adam Roben.
1268
1269         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1270         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
1271         * Drosera/win/Drosera.vcproj/VERSION: Removed.
1272         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
1273         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
1274         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
1275         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
1276         * DumpRenderTree/win/DumpRenderTree.vcproj:
1277         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1278         * DumpRenderTree/win/debug.vsprops: Removed.
1279         * DumpRenderTree/win/debug_internal.vsprops: Removed.
1280         * DumpRenderTree/win/release.vsprops: Removed.
1281
1282 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
1283
1284         Reviewed by Maciej.
1285
1286         - http://bugs.webkit.org/show_bug.cgi?id=16314
1287           Script to launch Drosera
1288
1289         * Scripts/gdb-drosera: Added.
1290         * Scripts/run-drosera: Added.
1291         * Scripts/run-drosera-nightly.cmd: Added.
1292         * Scripts/webkitdirs.pm: Added runDrosera function.
1293
1294 2008-01-13  Dan Bernstein  <mitz@apple.com>
1295
1296         - fix breakage due to last-minute change
1297
1298         * DumpRenderTree/win/DumpRenderTree.cpp:
1299         (runTest): Declare the loop variable.
1300
1301 2008-01-13  Dan Bernstein  <mitz@apple.com>
1302
1303         Reviewed by Adam Roben.
1304
1305         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
1306
1307         * DumpRenderTree/win/DumpRenderTree.cpp:
1308         (DumpRenderTreeWndProc):
1309         (initialize):
1310         (dumpBackForwardList):
1311         (dumpBackForwardListForAllWindows):
1312         (dump):
1313         (resetWebViewToConsistentStateBeforeTesting): Factored out of
1314         runTest().
1315         (runTest):
1316         (allWindows): Added. Returns a vector of all open windows.
1317         (windowToWebViewMap): Added. Returns a map from open windows to their
1318         WebViews.
1319         (createWebViewAndOffscreenWindow): Factored out of main() to be
1320         reusable for creating extra windows.
1321         (main):
1322         * DumpRenderTree/win/DumpRenderTreeWin.h:
1323         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1324         (LayoutTestController::windowCount): Implemented.
1325         * DumpRenderTree/win/UIDelegate.cpp:
1326         (UIDelegate::createWebViewWithRequest): Implemented.
1327         (UIDelegate::webViewClose): Implemented.
1328         * DumpRenderTree/win/UIDelegate.h:
1329
1330 2008-01-12  Alp Toker  <alp@atoker.com>
1331
1332         Reviewed by Mark Rowe.
1333
1334         Hide non-public symbols in GTK+/autotools release builds.
1335
1336         * GNUmakefile.am:
1337
1338 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1339
1340         Reviewed by Ap.
1341
1342         * Make launching of the WebKit httpd work on GNU/Debian/Linux
1343         
1344         The configuration of Apache2 and installation does not depend on
1345         the kernel but on the distribution policy. Make launching of httpd
1346         work for Debian derived distributions.
1347
1348         * Scripts/run-webkit-httpd:
1349         * Scripts/run-webkit-tests:
1350         * Scripts/webkitdirs.pm:
1351
1352 2008-01-12  Mark Rowe  <mrowe@apple.com>
1353
1354         Reviewed by Maciej Stachowiak.
1355
1356         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
1357
1358         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
1359         match the callers expectations that it can take ownership of the string.
1360
1361 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
1362
1363         Reviewed by Adam Roben.
1364
1365         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
1366
1367         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
1368         as these are only posted because the test window is not a normal visible one, and
1369         they confuse drag&drop machinery.
1370
1371 2008-01-11  Adam Roben  <aroben@apple.com>
1372
1373         Fix a crash when pathToLocalResource fails and a leak
1374
1375         Reviewed by Darin.
1376
1377         * DumpRenderTree/LayoutTestController.cpp:
1378         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
1379         sure not to pass null to JSValueMakeString.
1380         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1381         (LayoutTestController::pathToLocalResource): Print an error message if
1382         the conversion fails so it's clear what happened.
1383
1384 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
1385
1386         Reviewed by John Sullivan.
1387
1388         * DumpRenderTree/mac/GCControllerMac.mm:
1389         (GCController::collectOnAlternateThread): Updated for name change.
1390
1391 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
1392
1393         wx build fix. Don't build dftables any longer since it's now a Perl
1394         script.
1395
1396         * wx/build-wxwebkit:
1397
1398 2008-01-10  Sam Weinig  <sam@webkit.org>
1399
1400         Reviewed by Anders Carlsson.
1401
1402         Make DRT track open windows instead of allocated windows so that
1403         we can avoid ASSERTION due to late deallocs out of our control.
1404
1405         * DumpRenderTree/mac/DumpRenderTree.mm:
1406         (dumpBackForwardListForAllWindows):
1407         (runTest):
1408         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1409         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1410         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1411         (+[DumpRenderTreeWindow openWindows]):
1412         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1413         (-[DumpRenderTreeWindow close]):
1414         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1415         (LayoutTestController::windowCount):
1416
1417 2008-01-10  Ada Chan  <adachan@apple.com>
1418
1419         Meta key is not the same as Alt key on windows.
1420
1421         Reviewed by Darin.
1422
1423         * DumpRenderTree/win/EventSender.cpp:
1424         (keyDownCallback):
1425
1426 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
1427
1428         Reviewed by Darin, Sam and Adam.
1429
1430         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
1431         link in gmail message displays JavaScript alert falsely complaining
1432         about pop-up blocking.
1433         - Added the ability to enable the pop-up blocker via the
1434         LayoutTestController.
1435
1436         * DumpRenderTree/LayoutTestController.cpp:
1437         (setPopupBlockingEnabledCallback):
1438         (LayoutTestController::staticFunctions):
1439         * DumpRenderTree/LayoutTestController.h:
1440         * DumpRenderTree/mac/DumpRenderTree.mm:
1441         (setDefaultsToConsistentValuesForTesting):
1442         (resetWebViewToConsistentStateBeforeTesting):
1443         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1444         (LayoutTestController::setPopupBlockingEnabled):
1445
1446 2008-01-10  Lars Knoll  <lars@trolltech.com>
1447
1448         Reviewed by Simon.
1449
1450         rename QWebPageHistory to QWebHistory.
1451         
1452
1453         * DumpRenderTree/qt/jsobjects.cpp:
1454
1455 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
1456
1457         Reviewed by Darin.
1458         
1459         - add some more renames, adjust some
1460
1461         * Scripts/do-webcore-rename:
1462
1463 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1464
1465         Reviewed by Oliver.
1466
1467         Enable SVG Fonts support by default.
1468
1469         * Scripts/build-webkit:
1470
1471 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1472
1473         Reviewed by Adam.
1474
1475         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
1476         DRT doesn't handle platform specific pixel test results correctly.
1477
1478         <test>-expected.txt files and <test>-expected.png files may now live
1479         in different directories (ie. a cross-platform <test>-expected.txt file
1480         and a platform-specific <test>-expected.png file).
1481
1482         * Scripts/run-webkit-tests:
1483
1484 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
1485
1486         Reviewed by Darin.
1487
1488         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
1489         DRT did not correctly handle printing the '\0' char.  Now it does.
1490
1491         * DumpRenderTree/win/DumpRenderTree.cpp:
1492         (dumpFramesAsText):
1493         (dump):
1494
1495 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
1496
1497         Reviewed by Lars.
1498
1499         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
1500         
1501
1502         * DumpRenderTree/qt/main.cpp:
1503         * DumpRenderTree/qt/testplugin.cpp:
1504         * DumpRenderTree/qt/testplugin.h:
1505
1506 2008-01-05  Mark Rowe  <mrowe@apple.com>
1507
1508         Reviewed by Alp Toker.
1509
1510         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
1511
1512         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1513         (processWork): Process pending work.
1514         (webViewLoadFinished): Schedule processing of pending work.
1515         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
1516
1517 2008-01-05  Darin Adler  <darin@apple.com>
1518
1519         * Scripts/do-webcore-rename: Some more renaming plans.
1520
1521 2008-01-04  Alice Liu  <alice.liu@apple.com>
1522
1523         Reviewed by Alexey and Darin.
1524
1525         Adding "home" and "end" to DRT's keydown since
1526         DOM key events can't handle keyIdentifiers at this point. 
1527
1528         * DumpRenderTree/mac/EventSendingController.mm:
1529         (-[EventSendingController keyDown:withModifiers:]):
1530         * DumpRenderTree/win/EventSender.cpp:
1531         (keyDownCallback):
1532
1533 2008-01-04  Lars Knoll  <lars@trolltech.com>
1534
1535         Reviewed by Simon.
1536
1537         fix DRT after the changes to QWebPage.
1538         
1539         The great thing is that we actually don't have
1540         any regressions from the QWebPage change :)
1541         
1542
1543         * DumpRenderTree/qt/DumpRenderTree.cpp:
1544         (WebCore::DumpRenderTree::DumpRenderTree):
1545
1546 2008-01-04  Lars Knoll  <lars@trolltech.com>
1547
1548         Reviewed by Simon.
1549
1550         make QWebPage a QObject and get things to compile.
1551         
1552         Nothing works currently though.
1553         
1554
1555         * DumpRenderTree/qt/DumpRenderTree.cpp:
1556         (WebCore::DumpRenderTree::DumpRenderTree):
1557
1558 2008-01-04  Lars Knoll  <lars@trolltech.com>
1559
1560         Reviewed by Simon.
1561
1562         take a QString as identifier in QWebFrame::addToJSWindowObject.
1563
1564         * DumpRenderTree/qt/DumpRenderTree.cpp:
1565         (WebCore::DumpRenderTree::initJSObjects):
1566
1567 2008-01-04  Alp Toker  <alp@atoker.com>
1568
1569         GTK+ DRT build fix for breakage introduced in r29149.
1570
1571         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1572         (LayoutTestController::execCommand):
1573
1574 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1575
1576         Reviewed by Darin.
1577
1578         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
1579
1580         Added layoutTestController.execCommand to access editor commands that are not available
1581         via document.execCommand.
1582
1583         * DumpRenderTree/LayoutTestController.cpp:
1584         (execCommandCallback):
1585         (LayoutTestController::staticFunctions):
1586         * DumpRenderTree/LayoutTestController.h:
1587         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1588         (LayoutTestController::execCommand):
1589         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1590         (LayoutTestController::queueLoad):
1591         (LayoutTestController::execCommand):
1592
1593 2008-01-03  Alice Liu  <alice.liu@apple.com>
1594
1595         Reviewed by Darin, Mitz.
1596
1597         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
1598
1599         the clickcount should not increase if the last click was at a different location.  it's a new click.
1600
1601         * DumpRenderTree/mac/DumpRenderTree.mm:
1602         (runTest):
1603         * DumpRenderTree/mac/EventSendingController.h:
1604         * DumpRenderTree/mac/EventSendingController.mm:
1605         (-[EventSendingController mouseDown]):
1606         (-[EventSendingController mouseUp]):
1607
1608 2008-01-03  Darin Adler  <darin@apple.com>
1609
1610         Reviewed by Adam.
1611
1612         * Scripts/update-webkit: Make this work a little better for the people at Apple
1613         who have a directory named Internal.
1614
1615 2008-01-03  Adam Roben  <aroben@apple.com>
1616
1617         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
1618
1619         Rubberstamped by Mark.
1620
1621         * Scripts/update-webkit-auxiliary-libs:
1622
1623 2008-01-03  Adam Roben  <aroben@apple.com>
1624
1625         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
1626
1627         http://bugs.webkit.org/show_bug.cgi?id=15663
1628
1629         Added a fuzz factor into the Last-Modified comparison for downloading
1630         WebKitAuxiliaryLibrary.zip.
1631
1632         The zip file is served from a set of mirrors who give Last-Modified
1633         times that are off by 1-3 seconds from each other. This was causing
1634         the build bots to redownload WebKitAuxiliaryLibrary for every build,
1635         which would then cause all of WebCore to rebuild each time.
1636
1637         Reviewed by Mark.
1638
1639         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
1640         at least 30 seconds newer than the old one -- otherwise we assume that
1641         the difference in time is due to the mirrors being slightly offset
1642         from each other.
1643         (sub lastModifiedToUnixTime): Added.
1644
1645 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1646
1647         Windows build fix.
1648
1649         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
1650
1651 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1652
1653         Reviewed by Lars.
1654
1655         Moved QWebPage::open to QWebFrame::load and added setHtml.
1656         
1657
1658         * DumpRenderTree/qt/DumpRenderTree.cpp:
1659         (WebCore::DumpRenderTree::open):
1660
1661 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1662
1663         Reviewed by Lars.
1664
1665         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
1666         
1667
1668         * DumpRenderTree/qt/DumpRenderTree.cpp:
1669         (WebCore::DumpRenderTree::DumpRenderTree):
1670
1671 2008-01-02  Sam Weinig  <sam@webkit.org>
1672
1673         * Scripts/do-webcore-rename: Yet more renaming ideas.
1674
1675 2008-01-02  Darin Adler  <darin@apple.com>
1676
1677         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
1678
1679 2008-01-02  Alice Liu  <alice.liu@apple.com>
1680
1681         Reviewed by Sam Weinig.
1682
1683         fixing assertion hit with editing/selection/move-begin-end.html
1684
1685         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
1686         * DumpRenderTree/win/DumpRenderTree.vcproj:
1687         * DumpRenderTree/win/EventSender.cpp:
1688         (keyDownCallback):
1689         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
1690
1691 2008-01-02  Darin Adler  <darin@apple.com>
1692
1693         * Scripts/do-webcore-rename: Some more name change plans.
1694
1695 2008-01-02  Alice Liu  <alice.liu@apple.com>
1696
1697         Reviewed by Maciej.
1698
1699         Added handling for page up and page down in EventSender
1700
1701         * DumpRenderTree/mac/EventSendingController.mm:
1702         (-[EventSendingController keyDown:withModifiers:]):
1703         * DumpRenderTree/win/EventSender.cpp:
1704         (keyDownCallback):
1705
1706 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
1707
1708         Reviewed by Darin.
1709
1710         Fix fast/events/arrow-keys-on-body.html for real.
1711
1712         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
1713
1714 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
1715
1716         Reviewed by Darin.
1717
1718         http://bugs.webkit.org/show_bug.cgi?id=16674
1719         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
1720
1721         * Scripts/run-launcher:
1722
1723 2007-12-31  Darin Adler  <darin@apple.com>
1724
1725         Suggested by Antti.
1726
1727         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
1728         we get it installed on the build bots.
1729
1730 2007-12-30  Eric Seidel  <eric@webkit.org>
1731
1732         Reviewed by Sam.
1733
1734         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
1735
1736 2007-12-29  Darin Adler  <darin@apple.com>
1737
1738         Reviewed by Oliver.
1739
1740         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
1741           leak bot shows createCStringFromNPVariant result leaking
1742
1743         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1744         (pluginInvoke): Added a missing free.
1745
1746 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1747
1748         Reviewed by Alp Toker.
1749
1750         http://bugs.webkit.org/show_bug.cgi?id=16390
1751         Use autotools or GNU make as the build system for the GTK port
1752
1753         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
1754         * GNUmakefile.am: Added.
1755
1756 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
1757
1758         Reviewed by Oliver.
1759
1760         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
1761
1762         * DumpRenderTree/win/EventSender.cpp:
1763         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
1764         of 1, even though WebKit currently ignores it.
1765
1766 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
1767
1768         wx buildbot fix. Update libpng dl script to the latest version.
1769
1770         * wx/install-unix-extras:
1771
1772 2007-12-22  Antti Koivisto  <antti@apple.com>
1773
1774         Fix a typo.
1775
1776         * Scripts/webkitdirs.pm:
1777
1778 2007-12-21  Sam Weinig  <sam@webkit.org>
1779
1780         Reviewed by Mark Rowe.
1781
1782         - Disable the back/forward cache using the new WebPreferences API
1783           instead of through the BackForwardList.  This makes us match what
1784           we do on Windows.
1785
1786         * DumpRenderTree/mac/DumpRenderTree.mm:
1787         (createWebViewAndOffscreenWindow):
1788         (setDefaultsToConsistentValuesForTesting):
1789
1790 2007-12-21  Dan Bernstein  <mitz@apple.com>
1791
1792         Reviewed by Mark Rowe.
1793
1794         - disable the back/forward cache in Windows DumpRenderTree. It is
1795           already disabled in Mac DumpRenderTree.
1796
1797         * DumpRenderTree/win/DumpRenderTree.cpp:
1798         (initializePreferences):
1799
1800 2007-12-13  Antti Koivisto  <antti@apple.com>
1801
1802         Reviewed by Darin and Steve.
1803         
1804         - check for QuickTime SDK on Windows.
1805         - build media support on Windows by default
1806
1807         * Scripts/build-webkit:
1808         * Scripts/webkitdirs.pm:
1809
1810 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
1811
1812         Build script fix for buildbot.
1813
1814         * wx/build-wxwebkit:
1815
1816 2007-12-20  Eric Seidel  <eric@webkit.org>
1817
1818         Reviewed by mjs.
1819
1820         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
1821
1822 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1823
1824         Reviewed by Steve.
1825
1826         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
1827         WebKit.
1828
1829         - Drosera and Safari need to use the same ProgIDs in order for
1830         CoCreateInstance to work properly.  The most robust way to do this is
1831         for WebKit to dynamically publish those ProgIDs.
1832
1833         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
1834         (DebuggerClient::createWebViewWithRequest):
1835         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
1836         statics.
1837         (Drosera::initUI):
1838         (Drosera::attach):
1839         (Drosera::attemptToCreateServerConnection):
1840         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
1841         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
1842         make use of the published ProgIDs.
1843         (ServerConnection::attemptToCreateServerConnection):
1844
1845 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1846
1847         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
1848         - Build bot and leak fix.
1849
1850         * DumpRenderTree/LayoutTestController.cpp:
1851         (pathToLocalResourceCallback):
1852
1853 2007-12-19  David Kilzer  <ddkilzer@apple.com>
1854
1855         Make svn-apply/svn-unapply work with patches from git-format-patch.
1856
1857         Reviewed by Darin.
1858
1859         * Scripts/svn-apply:
1860         (patch): If 'Index:' can't be found in the text passed in, print it
1861         out with a warning and return early.
1862         * Scripts/svn-unapply:
1863         (patch): Ditto.
1864
1865 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
1866
1867         Reviewed by Alp Toker.
1868
1869         Build related fixes.
1870
1871         * wx/build-wxwebkit:
1872         - Check to make sure the user is running a supported wx port
1873         - More robust checks for Cygwin
1874         - Only run install-unix-extras on Mac, it's not the right solution
1875           for Linux distros.
1876         - Remove outdated Linux instructions after successful build
1877         - Clean Bakefile-generated files during a clean operation
1878
1879 2007-12-18  Darin Adler  <darin@apple.com>
1880
1881         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
1882
1883 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
1884
1885         Add script to run Drosera as part of the nightly.
1886         
1887         Reviewed by Kevin M.
1888
1889         * Scripts/run-drosera.cmd: Added.
1890
1891 2007-12-18  Darin Adler  <darin@apple.com>
1892
1893         * Scripts/do-webcore-rename: Remove a stray K.
1894
1895 2007-12-18  Darin Adler  <darin@apple.com>
1896
1897         * Scripts/do-webcore-rename: Plan more renaming.
1898
1899 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
1900
1901         Reviewed by Alp Toker.
1902
1903         http://bugs.webkit.org/show_bug.cgi?id=16042
1904         [GTK] Eliminate webkit_init()
1905
1906         Moving webkit initialization to WebView class init.
1907
1908         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1909         (main):
1910         * GtkLauncher/main.c:
1911         (main):
1912
1913 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
1914
1915         Reviewed by Alp Toker.
1916
1917         http://bugs.webkit.org/show_bug.cgi?id=13542
1918         gdklauncher doesnt change URL in adress GTKEntry.
1919
1920         * GtkLauncher/main.c:
1921         (load_commit_cb): added
1922         (title_change_cb):
1923         (create_browser):
1924
1925 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
1926
1927         Reviewed by Adam Roben.
1928
1929         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
1930
1931         * FindSafari/FindSafari.cpp:
1932         (_tmain):
1933
1934 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
1935
1936         Reviewed by Adam Roben.
1937
1938         http://bugs.webkit.org/show_bug.cgi?id=16315
1939         FindSafari needs a path-only option.
1940
1941         * FindSafari/FindSafari.cpp:
1942         (_tmain):
1943
1944 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
1945
1946         Reviewed by Darin.
1947
1948         http://bugs.webkit.org/show_bug.cgi?id=16462
1949         REGRESSION: access keys broken on Windows
1950
1951         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
1952         if Alt is pressed.
1953
1954 2007-12-15  Sam Weinig  <sam@webkit.org>
1955
1956         Reviewed by Mark Rowe.
1957
1958         Fix urlSuitableForTestResult to correctly identify wstring::npos as
1959         the case when wstring.find doesn't find anything.
1960
1961         * DumpRenderTree/win/DumpRenderTree.cpp:
1962         (urlSuitableForTestResult):
1963
1964 2007-12-15  Alp Toker  <alp@atoker.com>
1965
1966         GTK+ DRT build fix for GLib < 2.14.
1967
1968         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1969         (LayoutTestController::setWaitToDump):
1970
1971 2007-12-05  Mark Rowe  <mrowe@apple.com>
1972
1973         Reviewed by Alp Toker.
1974
1975         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
1976         many layout tests from hanging while waiting on user responses to dialogs.
1977
1978         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1979         (invalidateAnyPreviousWaitToDumpWatchdog):
1980         (webViewScriptAlert):
1981         (webViewScriptPrompt):
1982         (webViewScriptConfirm):
1983         (main):
1984         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1985         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1986         (waitToDumpWatchdogFired):
1987         (LayoutTestController::setWaitToDump):
1988
1989 2007-12-05  Mark Rowe  <mrowe@apple.com>
1990
1991         Reviewed by Alp Toker.
1992
1993         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
1994
1995         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1996         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1997         (dump):
1998         (runTest):
1999         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
2000         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
2001         work queue is empty.
2002         (webViewWindowObjectCleared): Set up window.layoutTestController.
2003         (webViewConsoleMessage): Match the console message format expected by the layout test results.
2004         (main): Hook up the new signals.
2005         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2006         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
2007         dumping multiple times.
2008         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
2009         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
2010
2011 2007-12-14  Anders Carlsson  <andersca@apple.com>
2012
2013         Reviewed by Brady.
2014
2015         Assert that a web frame that's loading a resource always has either a data source or 
2016         a provisional data source.
2017         
2018         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2019         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2020
2021 2007-12-14  Darin Adler  <darin@apple.com>
2022
2023         - fix mistake causing nearly all tests to fail on Windows
2024
2025         * DumpRenderTree/win/UIDelegate.cpp:
2026         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
2027         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
2028
2029         * DumpRenderTree/mac/UIDelegate.mm:
2030         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
2031         than passing the entire message.
2032
2033 2007-12-14  Darin Adler  <darin@apple.com>
2034
2035         - fix Tiger build
2036
2037         * DumpRenderTree/mac/UIDelegate.mm:
2038         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
2039         new-to-Leopard methods.
2040
2041 2007-12-14  Darin Adler  <darin@apple.com>
2042
2043         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
2044         since it now triggers unwanted icon loading. We only had it because we implemented "all"
2045         delegate methods here.
2046
2047 2007-12-14  Anders Carlsson  <andersca@apple.com>
2048
2049         Reviewed by Darin and Geoff.
2050
2051         <rdar://problem/5619295> 
2052         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
2053         
2054         Add property getting methods to the plug-in.
2055         
2056         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2057         (pluginInvoke):
2058
2059 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
2060
2061         Reviewed by Darin.
2062
2063         - Layout test fix for mac. When dumped to the console local file paths
2064         now only show the name of the resource not the whole path.  This is to
2065         make the results machine and OS independent.
2066
2067         * DumpRenderTree/mac/UIDelegate.mm:
2068         (-[UIDelegate webView:addMessageToConsole:]):
2069
2070 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
2071
2072         Reviewed by Adam.
2073
2074         - Layout tests fix.  We need a way to remove machine-dependent
2075         information from paths in layout test results. The UIDelegate now does
2076         this.
2077
2078         * DumpRenderTree/DumpRenderTree.h:
2079         * DumpRenderTree/win/DumpRenderTree.cpp:
2080         (urlSuitableForTestResult):
2081         * DumpRenderTree/win/DumpRenderTreeWin.h:
2082         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2083         * DumpRenderTree/win/UIDelegate.cpp:
2084         (UIDelegate::webViewAddMessageToConsole):
2085
2086 2007-12-13  Alp Toker  <alp@atoker.com>
2087
2088         Build fix for DRT breakage introduced in r28690.
2089
2090         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2091         (LayoutTestController::pathToLocalResource):
2092
2093 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
2094
2095         Reviewed by Alice and Sam.
2096
2097         - <rdar://5621435> Need a way to specify local resources (being loaded
2098         from HTTP tests) on Windows.
2099         - Implemented pathToLocalResource which exposes the functionality of
2100         converting a given unix path to the correct location on Windows.
2101
2102         * DumpRenderTree/LayoutTestController.cpp:
2103         (pathToLocalResourceCallback):
2104         (LayoutTestController::staticFunctions):
2105         * DumpRenderTree/LayoutTestController.h:
2106         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2107         (LayoutTestController::pathToLocalResource):
2108         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2109         (LayoutTestController::pathToLocalResource):
2110
2111 2007-12-12  Anders Carlsson  <andersca@apple.com>
2112
2113         Reviewed by Sam.
2114
2115         <rdar://problem/5132003>
2116         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
2117
2118         * DumpRenderTree/win/DumpRenderTree.cpp:
2119         (main):
2120         Set the resource load delegate.
2121         
2122         * DumpRenderTree/win/DumpRenderTree.vcproj:
2123         
2124         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
2125         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
2126
2127 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
2128
2129         Reviewed by Adam Roben.
2130
2131         Fix conversion from double to LPARAM in dispatchMessage().
2132
2133         * DumpRenderTree/win/EventSender.cpp:
2134         (dispatchMessageCallback):
2135
2136 2007-12-11  Dan Bernstein  <mitz@apple.com>
2137
2138         Reviewed by Mark Rowe and Sam Weinig too!
2139
2140         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
2141           fonts DumpRenderTree registers.
2142
2143         * DumpRenderTree/win/DumpRenderTree.cpp:
2144         (initialize):
2145
2146 2007-12-11  Brady Eidson  <beidson@apple.com>
2147
2148         Reviewed by Anders
2149
2150         Make DumpRenderTree on mac use its own path for Databases testing
2151
2152         * DumpRenderTree/mac/DumpRenderTree.mm:
2153         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
2154           for future DRT-only use, then use it to construct the Databases path and set that default
2155
2156 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
2157
2158         Reviewed by Darin.
2159
2160         <rdar://problem/5535636>
2161         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
2162
2163         http://bugs.webkit.org/show_bug.cgi?id=13916
2164         JavaScript detects Tab as a character input on a textfield validation
2165
2166         * DumpRenderTree/mac/EventSendingController.mm:
2167         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
2168         Dispatch a keyup to better match what happens when a key is physically pressed.
2169
2170         * DumpRenderTree/win/EventSender.cpp:
2171         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
2172         returning from keyDown().
2173         (getConstantCallback): Fixed a couple copy/paste mistakes.
2174
2175 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
2176
2177         Reviewed by Oliver.
2178
2179         - <rdar://5599845> Drosera: Does not show loal files in the file list
2180         on the left side.
2181
2182         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
2183         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
2184         so the open source community can build.
2185
2186 2007-12-10  Brady Eidson  <beidson@apple.com>
2187
2188         Rubberstamped by Sam Weinig
2189
2190         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
2191
2192         * DumpRenderTree/mac/UIDelegate.mm:
2193         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2194         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
2195
2196 2007-12-08  Oliver Hunt  <oliver@apple.com>
2197
2198         Reviewed by Sam W.
2199
2200         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
2201         
2202         Fixes <rdar://problem/5620249> Must disable SVG animation
2203         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
2204         
2205         In order to allow finer grained control over the set of SVG features
2206         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
2207         distinct flags:
2208         ENABLE_SVG_ANIMATION
2209         ENABLE_SVG_FILTERS
2210         ENABLE_SVG_FONTS
2211         ENABLE_SVG_AS_IMAGE
2212         ENABLE_SVG_USE
2213         
2214         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
2215         
2216         Script handles all the new build flags, and allows --svg-experimental
2217         to automatically enable all features.
2218
2219         * Scripts/build-webkit:
2220
2221 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
2222
2223         Fix version parsing.
2224
2225         Rubber-stamped by Oliver.
2226
2227         * Drosera/win/Drosera.vcproj/auto-version.sh:
2228
2229 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
2230
2231         Build modifications for Drosera.
2232
2233         Reviewed by Adam.
2234
2235         * Drosera/DroseraWin.make: Added.
2236         * Drosera/win/Drosera.vcproj/Drosera.rc:
2237         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2238         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
2239         * Drosera/win/Drosera.vcproj/VERSION: Added.
2240         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
2241
2242 2007-12-06  Adam Roben  <aroben@apple.com>
2243
2244         Explicitly turn on the Mac font ascent hack on Windows
2245
2246         This keeps our font metrics matching those from Mac.
2247
2248         Reviewed by Hyatt.
2249
2250         * DumpRenderTree/win/DumpRenderTree.cpp:
2251         (main):
2252
2253 2007-12-06  Anders Carlsson  <andersca@apple.com>
2254
2255         Rename main.c to main.cpp here too.
2256         
2257         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
2258
2259 2007-12-06  Sam Weinig  <sam@webkit.org>
2260
2261         Rubber stamped by Geoff.
2262
2263         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
2264
2265 2007-12-06  Darin Adler  <darin@apple.com>
2266
2267         * Scripts/do-webcore-rename: Some more renaming plans.
2268
2269 2007-12-06  Anders Carlsson  <andersca@apple.com>
2270
2271         Restore implementation of testGetIntIdentifier that was accidentally
2272         removed somehow (possibly when I made PluginObject be a cpp file).
2273         
2274         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2275         (pluginInvoke):
2276
2277 2007-12-05  Anders Carlsson  <andersca@apple.com>
2278
2279         Make the entry points extern "C".
2280         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2281         
2282 2007-12-05  Anders Carlsson  <andersca@apple.com>
2283
2284         C++ warning fixes.
2285         
2286         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2287         (NPP_New):
2288         (NPP_Destroy):
2289         (NPP_SetWindow):
2290         (NPP_NewStream):
2291         (NPP_HandleEvent):
2292         (NPP_URLNotify):
2293         (NPP_GetValue):
2294
2295 2007-12-05  Anders Carlsson  <andersca@apple.com>
2296
2297         Add the .cpp files to the TestNetscapePlugIn target.
2298
2299         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2300
2301 2007-12-05  Anders Carlsson  <andersca@apple.com>
2302
2303         Reviewed by Geoff.
2304         
2305         Rename the TestNetscapePlugIn .c files to be .cpp.
2306
2307         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2308         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
2309         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
2310         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
2311         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
2312         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
2313         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
2314         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2315
2316 2007-12-05  Adam Roben  <aroben@apple.com>
2317
2318         Fix case of keypresses from the Windows implementation of eventSender.keyDown
2319
2320         This fixes several regression tests.
2321
2322         Reviewed by Alice.
2323
2324         * DumpRenderTree/win/EventSender.cpp:
2325         (keyDownCallback): Virtual keycodes for ASCII characters are always
2326         uppercase, so we need to check the case of the original character
2327         passed in to eventSender.keyDown.
2328
2329 2007-12-05  Adam Roben  <aroben@apple.com>
2330
2331         Learn from Tim's mistakes
2332
2333         * DumpRenderTree/win/DumpRenderTree.cpp:
2334         (runTest): Reset the authorAndUserStylesEnabled preference for each
2335         test.
2336
2337 2007-12-05  Alp Toker  <alp@atoker.com>
2338
2339         Reviewed by Mark Rowe.
2340
2341         Initialize GTK+ and WebKit so the tests can run.
2342
2343         Reorganize the headers a little.
2344
2345         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2346         (main):
2347
2348 2007-12-04  Anders Carlsson  <andersca@apple.com>
2349
2350         Remove IWebScriptScope include.
2351         
2352         * Drosera/win/DebuggerDocumentPlatform.cpp:
2353
2354 2007-12-04  Sam Weinig  <sam@webkit.org>
2355
2356         Rubber stamped by Mark Rowe.
2357
2358         Define CF as platform for mac and revert r28409
2359
2360         * DumpRenderTree/DumpRenderTree.h:
2361         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2362
2363 2007-12-04  Sam Weinig  <sam@webkit.org>
2364
2365         Define CF as platform for windows.
2366
2367         Reviewed by Adam Roben.
2368
2369         * DumpRenderTree/win/DumpRenderTreeWin.h:
2370
2371 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
2372
2373         Reviewed by Adam and Darin.
2374
2375         - Removed a needless BSTR cleanup.
2376
2377         * Drosera/win/DebuggerDocumentPlatform.cpp:
2378         (DebuggerDocument::getPlatformCurrentFunctionStack):
2379
2380 2007-11-27  Adam Roben  <aroben@apple.com>
2381
2382         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
2383
2384         Reviewed by Maciej.
2385
2386         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2387         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
2388
2389 2007-12-04  Alp Toker  <alp@atoker.com>
2390
2391         Prospective Win DRT build fix.
2392
2393         * DumpRenderTree/DumpRenderTree.h:
2394
2395 2007-12-04  Alp Toker  <alp@atoker.com>
2396
2397         Fix a clobbered copyright header.
2398
2399         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2400
2401 2007-12-04  Xan Lopez  <xan@gnome.org>
2402
2403         Reviewed by Alp Toker.
2404
2405         http://bugs.webkit.org/show_bug.cgi?id=15561
2406         GTK port needs DumpRenderTree implementation
2407
2408         Start work on the GTK+ DRT.
2409
2410         This does not work yet, and there are a few lingering style issues
2411         (nothing major) but this patch has been stuck in the bug tracker for
2412         too long already.
2413
2414         * DumpRenderTree/DumpRenderTree.h:
2415         * DumpRenderTree/gtk: Added.
2416         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
2417         (autocorrectURL):
2418         (shouldLogFrameLoadDelegates):
2419         (dumpFrameScrollPosition):
2420         (displayWebView):
2421         (appendString):
2422         (dumpFramesAsText):
2423         (dumpRenderTreeAsText):
2424         (dump):
2425         (runTest):
2426         (main):
2427         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
2428         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
2429         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
2430         (GCController::collect):
2431         (GCController::collectOnAlternateThread):
2432         (GCController::getJSObjectCount):
2433         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
2434         (LayoutTestController::~LayoutTestController):
2435         (LayoutTestController::addDisallowedURL):
2436         (LayoutTestController::clearBackForwardList):
2437         (LayoutTestController::copyDecodedHostName):
2438         (LayoutTestController::copyEncodedHostName):
2439         (LayoutTestController::display):
2440         (LayoutTestController::keepWebHistory):
2441         (LayoutTestController::notifyDone):
2442         (LayoutTestController::queueBackNavigation):
2443         (LayoutTestController::queueForwardNavigation):
2444         (LayoutTestController::queueLoad):
2445         (LayoutTestController::queueReload):
2446         (LayoutTestController::queueScript):
2447         (LayoutTestController::setAcceptsEditing):
2448         (LayoutTestController::setCustomPolicyDelegate):
2449         (LayoutTestController::setMainFrameIsFirstResponder):
2450         (LayoutTestController::setTabKeyCyclesThroughElements):
2451         (LayoutTestController::setUseDashboardCompatibilityMode):
2452         (LayoutTestController::setUserStyleSheetEnabled):
2453         (LayoutTestController::setUserStyleSheetLocation):
2454         (LayoutTestController::setWindowIsKey):
2455         (LayoutTestController::setWaitToDump):
2456         (LayoutTestController::windowCount):
2457         (LayoutTestController::setPrivateBrowsingEnabled):
2458         (LayoutTestController::setAuthorAndUserStylesEnabled):
2459         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
2460         (JSStringCopyUTF8CString):
2461         (LoadItem::invoke):
2462         (ReloadItem::invoke):
2463         (ScriptItem::invoke):
2464         (BackForwardItem::invoke):
2465
2466 2007-12-03  Sam Weinig  <sam@webkit.org>
2467
2468         Move JavaScriptCore thread testing code to pthread specific directory
2469         and remove the dependance on CoreFoundation by using WTF::HashSet.
2470
2471         Reviewed by Geoff and Oliver.
2472
2473         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2474         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
2475         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
2476         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
2477         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
2478         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
2479         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
2480         * DumpRenderTree/pthreads: Added.
2481         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
2482         (javaScriptThreads):
2483         (runJavaScriptThread):
2484         (startJavaScriptThreads):
2485         (stopJavaScriptThreads):
2486
2487 2007-12-03  Andrew Bonventre  <andybons@google.com>
2488
2489         Reviewed by Darin Adler.
2490
2491         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
2492         Symbol lookup menu broken in debugger view
2493
2494         * Drosera/debugger.js: Fixed javascript error where document property
2495         should have been used instead of contentDocument in switchFunction that
2496         was breaking the select symbol dropdown menu.  This is because
2497         window.frames will return a Window object and not a frame object like
2498         the author was originally expecting.
2499
2500 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
2501
2502         Reviewed by Adam.
2503
2504         - <rdar://5618942> Drosera: Console window does not process everything
2505         correctly.
2506         - <rdar://5619005> Drosera: could be sped up by moving the 
2507         WebScriptScope stuff into the WebScriptCallFrame.
2508         - Now the console can correctly process objects and does not receive
2509         notifications from JavaScriptCore about the JavaScript in Drosera's
2510         own process.
2511
2512         * Drosera/win/DebuggerDocumentPlatform.cpp:
2513         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2514         (DebuggerDocument::platformValueForScopeVariableNamed):
2515
2516 2007-12-03  Stephanie  <slewis@apple.com>
2517
2518         Reviewed by Darin.
2519
2520         Check to see if we are building a debug root
2521
2522         * Scripts/check-for-global-initializers: 
2523
2524 2007-12-03  Dan Bernstein  <mitz@apple.com>
2525
2526         Reviewed by Darin Adler.
2527
2528         - added a testGetIntIdentifier() method to TestNetscapePlugIn
2529
2530         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
2531         (pluginInvoke):
2532
2533 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
2534
2535         Reviewed by Oliver.
2536
2537         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
2538         in a more fine-grained manner than eventSender.keyDown().
2539
2540         * DumpRenderTree/win/EventSender.cpp:
2541         (getConstantCallback):
2542         (dispatchMessageCallback):
2543
2544 2007-12-02  Darin Adler  <darin@apple.com>
2545
2546         * Scripts/do-webcore-rename: More planned renaming.
2547
2548 2007-12-02  Sam Weinig  <sam@webkit.org>
2549
2550         Rubber stamped by Anders.
2551
2552         Use [NSURL absoluteString] instead of [NSURL description] in order to get
2553         more uniform results cross platform.
2554
2555         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2556         (-[NSURL _drt_descriptionSuitableForTestResult]):
2557
2558 2007-12-02  Sam Weinig  <sam@webkit.org>
2559
2560         Rubber stamped by Niko.
2561
2562         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
2563
2564         * DumpRenderTree/win/DumpRenderTree.cpp:
2565         * DumpRenderTree/win/DumpRenderTree.vcproj:
2566         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
2567         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
2568         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
2569         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
2570
2571 2007-12-01  Alp Toker  <alp@atoker.com>
2572
2573         Reviewed by Adam Roben.
2574
2575         Make use of the newly introduced webkit.h convenience header.
2576
2577         * GtkLauncher/main.c:
2578
2579 2007-12-01  Adam Treat  <treat@kde.org>
2580
2581         Reviewed by Simon.
2582
2583         * Check to see if the directory exists and exit if not.
2584
2585         * DumpRenderTree/qt/main.cpp:
2586         (main):
2587
2588 2007-12-01  Adam Treat  <treat@kde.org>
2589
2590         Reviewed by Simon.
2591
2592         * Don't hide symbols when in Debug mode
2593         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
2594
2595
2596         * DumpRenderTree/qt/main.cpp:
2597         (messageHandler):
2598
2599 2007-11-30  Alp Toker  <alp@atoker.com>
2600
2601         Reviewed by Adam Roben.
2602
2603         http://bugs.webkit.org/show_bug.cgi?id=15691
2604         [GTK] Public API does not follow GTK+ conventions
2605
2606         Refactor the WebKit/GTK+ public API. Changes:
2607           WebKitPage -> WebKitWebView
2608           WebKitFrame -> WebKitWebFrame
2609
2610         Public API source and header names have been updated to mirror the API
2611         changes.
2612
2613         The API is now kept in WebKit/gtk/WebView to match other ports in the
2614         same class such as Mac and Win.
2615
2616         * GtkLauncher/main.c:
2617         (activate_uri_entry_cb):
2618         (link_hover_cb):
2619         (title_change_cb):
2620         (progress_change_cb):
2621         (go_back_cb):
2622         (go_forward_cb):
2623         (create_browser):
2624         (main):
2625
2626 2007-11-30  Adam Roben  <aroben@apple.com>
2627
2628         Hopefully the final build fix
2629
2630         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
2631         pull in WTF's assertion/logging functions.
2632
2633 2007-11-30  Adam Roben  <aroben@apple.com>
2634
2635         Another build fix
2636
2637         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
2638         WebKit.lib.
2639
2640 2007-11-30  Adam Roben  <aroben@apple.com>
2641
2642         Debug build fix
2643
2644         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
2645         configuration.
2646         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
2647         projects.
2648         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
2649         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
2650         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
2651
2652 2007-11-30  Sam Weinig  <sam@webkit.org>
2653
2654         Reviewed by Adam Roben.
2655
2656         Fix drawSelectionRect to actually draw the selection rect.
2657
2658         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2659         (drawSelectionRect):
2660
2661 2007-11-30  Darin Adler  <darin@apple.com>
2662
2663         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
2664
2665 2007-11-30  Darin Adler  <darin@apple.com>
2666
2667         * Scripts/do-webcore-rename: Get ready for some future renaming.
2668
2669 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2670
2671         Reviewed by Adam.
2672
2673         - Removed some unnecessary functions and changed an unused return type. 
2674
2675         * Drosera/win/DebuggerClient.cpp:
2676         (registerConsoleClass):
2677         * Drosera/win/DebuggerClient.h:
2678         * Drosera/win/Drosera.cpp:
2679         (registerDroseraClass):
2680
2681 2007-11-28  Alp Toker  <alp@atoker.com>
2682
2683         Reviewed by Timothy Hatcher.
2684
2685         http://bugs.webkit.org/show_bug.cgi?id=16174
2686         [GTK] Use "URI" not "URL" in public API
2687
2688         Replace use of the term "URL" with "URI" in public headers,
2689         documentation and some internal code to match GLib/GTK+ convention.
2690
2691         This is now mentioned in the API guidelines:
2692           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
2693
2694         * GtkLauncher/main.c:
2695         (activate_uri_entry_cb):
2696         (title_change_cb):
2697         (create_toolbar):
2698         (main):
2699
2700 2007-11-29  Anders Carlsson  <andersca@apple.com>
2701
2702         Reviewed by Sam.
2703
2704         <rdar://problem/5230478>
2705         FrameLoadDelegate callbacks are not dumped in DRT.
2706         
2707         * DumpRenderTree/win/DumpRenderTree.cpp:
2708         (shouldLogFrameLoadDelegates):
2709         (runTest):
2710         (main):
2711         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2712         (BSTRtoString):
2713         (descriptionSuitableForTestResult):
2714         (FrameLoadDelegate::QueryInterface):
2715         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2716         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2717         (FrameLoadDelegate::didCommitLoadForFrame):
2718         (FrameLoadDelegate::didFinishLoadForFrame):
2719         (FrameLoadDelegate::willCloseFrame):
2720         (FrameLoadDelegate::didClearWindowObject):
2721         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2722         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2723         * DumpRenderTree/win/FrameLoaderDelegate.h:
2724         (FrameLoadDelegate::windowScriptObjectAvailable):
2725         (FrameLoadDelegate::didFirstLayoutInFrame):
2726
2727 2007-11-29  Sam Weinig  <sam@webkit.org>
2728
2729         Reviewed by Anders.
2730
2731         Add database quota UIDelegates methods to DRT UIDelegate.
2732
2733         * DumpRenderTree/mac/UIDelegate.mm:
2734         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2735         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
2736
2737 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2738
2739         Reviewed by Sam.
2740
2741         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
2742         dying and vice versa.
2743         - This fix will allow Drosera and Safari to reconnect if either of them
2744         closes correctly, but does not fix the case where one of them dies
2745         silently.
2746
2747         * Drosera/win/ServerConnection.cpp:
2748         (ServerConnection::attemptToCreateServerConnection): Added a safety
2749         check, because it's possilbe to try to connect to a server that's dying.
2750         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
2751         the server has died.
2752         * Drosera/win/ServerConnection.h: Added the new function and removed
2753         an unnecessary member.
2754
2755 2007-11-29  Anders Carlsson  <andersca@apple.com>
2756
2757         * DumpRenderTree/win/DumpRenderTree.vcproj:
2758         Add shlwapi.lib to all configurations.
2759
2760 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2761
2762         - Build fix.  Added additional includes for VS Express to the Release
2763         project.
2764
2765         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2766
2767 2007-11-29  Anders Carlsson  <andersca@apple.com>
2768
2769         Reviewed by Adam.
2770
2771         <rdar://problem/5132005>
2772         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
2773         
2774         * DumpRenderTree/win/DumpRenderTree.vcproj:
2775         Add shlwapi.lib
2776         
2777         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2778         (LayoutTestController::setUserStyleSheetEnabled):
2779         Implement this.
2780         
2781         (appendComponentToPath):
2782         New method which wraps the Win32 API PathAppend.
2783         
2784         (followShortcuts):
2785         New method which checks if a file points to a shortcut and
2786         follows the shortcut.
2787         
2788         (resolveCygwinPath):
2789         New method that takes a cygwin unix-style path and returns the Win32 path.
2790         
2791         (cfStringRefToWString):
2792         
2793         (LayoutTestController::setUserStyleSheetLocation):
2794         Implement this.
2795
2796 2007-11-29  Alice Liu  <alice.liu@apple.com>
2797
2798         Reviewed by Adam.
2799
2800         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
2801
2802         * DumpRenderTree/win/EventSender.cpp:
2803         (keyDownCallback):
2804         uppercase letters were being sent as lowercase letters without the shift key down.
2805
2806 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2807
2808         - Windows build fix. VS express needs some love.
2809
2810         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2811
2812 2007-11-28  Darin Adler  <darin@apple.com>
2813
2814         Reviewed by Adam Roben.
2815
2816         * DumpRenderTree/mac/EventSendingController.mm:
2817         (-[EventSendingController keyDown:withModifiers:]):
2818         Send capital letters through as lowercase letters with the shift key down
2819         rather than sending them as if they were highly unusual "capital letter keys".
2820
2821         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
2822         where you need to update results and more tests are failing than before.
2823
2824 2007-11-28  Anders Carlsson  <andersca@apple.com>
2825
2826         Reviewed by Darin.
2827
2828         <rdar://problem/5132001>
2829         contextClick is not implemented in DRT on Windows.
2830         
2831         * DumpRenderTree/win/EventSender.cpp:
2832         (contextClickCallback):
2833         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
2834         by a WM_RBUTTONUP message.
2835         
2836         * DumpRenderTree/win/UIDelegate.cpp:
2837         (UIDelegate::hasCustomMenuImplementation):
2838         (UIDelegate::trackCustomPopupMenu):
2839         * DumpRenderTree/win/UIDelegate.h:
2840         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
2841         menu from being shown (and causing the DRT to hang).
2842
2843 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
2844
2845         Reviewed by Darin.
2846
2847         Fix DumpRenderTree ObjC bug comparing strings.
2848
2849         * DumpRenderTree/mac/ObjCController.m:
2850         (-[ObjCController identityIsEqual::]): Compare strings with string
2851         equality instead of identiy equality.
2852
2853 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2854
2855         Reviewed by Sam.
2856
2857         Reset the authorAndUserStylesEnabled preference
2858         back to YES for each test. Fixes the broken tests.
2859
2860         * DumpRenderTree/mac/DumpRenderTree.mm:
2861         (resetWebViewToConsistentStateBeforeTesting):
2862
2863 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
2864
2865         Reviewed by Adam.
2866
2867         - Drosera now displays the console window, although it cannot currently
2868         process JavaScript.
2869
2870         * Drosera/win/DebuggerClient.cpp: Shows the console window.
2871         (registerConsoleClass): Implemented.
2872         (consoleWndProc): Implemented.
2873         (DebuggerClient::onSize): Implemented.
2874         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
2875         new window.
2876         * Drosera/win/DebuggerClient.h: Added needed method and members for 
2877         creating and maintaining a new window.
2878         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
2879         lines of code to more appropriate places.
2880         (Drosera::handleCommand):
2881         (Drosera::initUI):
2882         (Drosera::onSize):
2883         (Drosera::attach):
2884
2885 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2886
2887         Reviewed by Dave Hyatt.
2888
2889         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
2890         
2891         Add support for disabling author and user styles for testing.
2892
2893         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2894         * DumpRenderTree/LayoutTestController.cpp:
2895         (setAuthorAndUserStylesEnabledCallback):
2896         (LayoutTestController::staticFunctions):
2897         * DumpRenderTree/LayoutTestController.h:
2898         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2899         (LayoutTestController::setAuthorAndUserStylesEnabled):
2900         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2901         (LayoutTestController::setAuthorAndUserStylesEnabled):
2902
2903 2007-11-26  Dan Bernstein  <mitz@apple.com>
2904
2905         - Tiger build fix.
2906
2907         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2908
2909 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
2910
2911         Reviewed by Maciej.
2912
2913         - Implemented displaying variables for Drosera on Win.
2914
2915         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
2916         that retrieve variables to not hold onto the return value since it's
2917         not returned.  Also changed to use the new signatures of the retrieval
2918         functions.
2919         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2920         (DebuggerDocument::platformValueForScopeVariableNamed):
2921         * Drosera/win/Drosera.cpp: Removed a needless TODO.
2922         (droseraWndProc):
2923
2924 2007-11-26  Sam Weinig  <sam@webkit.org>
2925
2926         Cleanup names of painting and repainting functions.
2927
2928         Reviewed by Adam Roben.
2929
2930         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2931         (drawSelectionRect): was drawSelectionRectIntoContext.
2932         (dumpWebViewAsPixelsAndCompareWithExpected):
2933         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2934         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2935         (paintWebView): was drawWebViewIntoContext.
2936         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
2937
2938 2007-11-26  Sam Weinig  <sam@webkit.org>
2939
2940         Reviewed by Dan Bernstein.
2941
2942         - Leopard build fix
2943
2944         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2945
2946 2007-11-26  Sam Weinig  <sam@webkit.org>
2947
2948         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
2949         Use shared PixelDumpSupport for Mac DRT
2950
2951         Reviewed by Adam Roben.
2952
2953         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2954         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
2955         * DumpRenderTree/cg/ImageDiffCG.cpp:
2956         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2957         (drawSelectionRectIntoContext):
2958         (dumpWebViewAsPixelsAndCompareWithExpected):
2959         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2960         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2961         * DumpRenderTree/mac/DumpRenderTree.mm:
2962         (dump):
2963         * DumpRenderTree/mac/ImageDiff.m: Removed.
2964         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
2965         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
2966         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
2967         (setDefaultColorProfileToRGB):
2968         (getBitmapContextFromWebView):
2969         (drawWebViewIntoContext):
2970         (repaintWithVerticalSweep):
2971         (repaintWithHorizontalSweep):
2972         (getSelectionRect):
2973         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
2974
2975 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
2976
2977         Bug 16052: prepare-ChangeLog doesn't report deleted files
2978         <http://bugs.webkit.org/show_bug.cgi?id=16052>
2979
2980         Reviewed by Sam.
2981
2982         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
2983
2984 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
2985
2986         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
2987         <http://bugs.webkit.org/show_bug.cgi?id=15864>
2988
2989         Reviewed by Adam.
2990
2991         Roll functionality of merge-changelog into resolve-ChangeLogs
2992         script.  The script now checks for ChangeLog.rej and
2993         ChangeLog.orig files first.  If it finds them, it uses the
2994         ChangeLog.rej file as a patch (in old contextual diff format) to
2995         apply with --fuzz=3.
2996
2997         * Scripts/merge-changelog: Removed.
2998         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2999
3000 2007-11-25  Sam Weinig  <sam@webkit.org>
3001
3002         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
3003
3004         Reviewed by Mark Rowe.
3005
3006         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3007         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3008         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3009         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
3010         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
3011
3012 2007-11-25  Sam Weinig  <sam@webkit.org>
3013
3014         Convert DumpRenderTree to ues .xcconfig files.
3015
3016         Reviewed by Mark Rowe.
3017
3018         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3019         * DumpRenderTree/mac/Configurations: Added.
3020         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
3021         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
3022         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
3023
3024 2007-11-25  Sam Weinig  <sam@webkit.org>
3025
3026         Add ForwardingHeaders to wtf for DumpRenderTree.
3027
3028         Reviewed by Mark Rowe.
3029
3030         * DumpRenderTree/DumpRenderTree.h:
3031         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3032         * DumpRenderTree/ForwardingHeaders: Added.
3033         * DumpRenderTree/ForwardingHeaders/wtf: Added.
3034         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
3035         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
3036         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
3037         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
3038         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
3039         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
3040         * DumpRenderTree/LayoutTestController.cpp:
3041         * DumpRenderTree/WorkQueue.cpp:
3042         * DumpRenderTree/mac/DumpRenderTree.mm:
3043         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3044         * DumpRenderTree/mac/JavaScriptThreading.cpp:
3045         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3046         * DumpRenderTree/mac/ObjCController.m:
3047         * DumpRenderTree/mac/UIDelegate.mm:
3048         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3049
3050 2007-11-25  Adam Roben  <aroben@apple.com>
3051
3052         Fix some test failures caused by r28019
3053
3054         Now that stdout is in binary mode, we need to always use printf
3055         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
3056         the output.
3057
3058         Reviewed by Sam.
3059
3060         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
3061         printf.
3062         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3063         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3064         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3065         (UIDelegate::webViewAddMessageToConsole):
3066
3067 2007-11-25  Adam Roben  <aroben@apple.com>
3068
3069         Set the font smoothing preference in DRT
3070
3071         This makes the pixel results on Windows closer to the Mac results.
3072
3073         Reviewed by Mitz.
3074
3075         * DumpRenderTree/win/DumpRenderTree.cpp:
3076         (initializePreferences):
3077
3078 2007-11-25  Adam Roben  <aroben@apple.com>
3079
3080         Port ImageDiff to CG and C++
3081
3082         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
3083         <rdar://5071708>
3084
3085         Reviewed by Sam.
3086
3087         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
3088         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
3089         (main):
3090         (createImageFromStdin):
3091         (compareImages):
3092         (getDifferenceBitmap):
3093         (computePercentageDifferent):
3094         * DumpRenderTree/win/ImageDiff.vcproj: Added.
3095
3096 2007-11-25  Adam Roben  <aroben@apple.com>
3097
3098         Fix image diff link generation on Windows
3099
3100         Reviewed by Sam.
3101
3102         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
3103         to toURL.
3104
3105 2007-11-25  Adam Roben  <aroben@apple.com>
3106
3107         Implement pixel dumping in Windows DRT
3108
3109         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
3110         <rdar://5071708>
3111
3112         Reviewed by Sam.
3113
3114         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
3115         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
3116         Content-Length header.
3117         (getMD5HashStringForBitmap):
3118         (dumpWebViewAsPixelsAndCompareWithExpected):
3119         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
3120         * DumpRenderTree/win/DumpRenderTree.cpp:
3121         (dump): Do a pixel dump if requested.
3122         (main): Parse pixel test options.
3123         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
3124         the cg/ subdirectory to the include path.
3125         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
3126         available in a header or import library, so we have to go through this
3127         LoadLibrary/GetProcAddress dance to use them.
3128         (cryptDLL):
3129         (init):
3130         (update):
3131         (final):
3132         (MD5_Init):
3133         (MD5_Update):
3134         (MD5_Final):
3135         * DumpRenderTree/win/MD5.h: Added.
3136         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
3137         moved up to the top level to share it with Mac eventually.
3138         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
3139         (getBitmapContextFromWebView): Forces the WebView to paint using a
3140         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
3141
3142 2007-11-25  Adam Roben  <aroben@apple.com>
3143
3144         Clean up Windows DRT's option parsing a little bit
3145
3146         Reviewed by Sam.
3147
3148         * DumpRenderTree/win/DumpRenderTree.cpp:
3149         (main): Put non-option arguments into a Vector.
3150
3151 2007-11-25  Adam Roben  <aroben@apple.com>
3152
3153         Make Windows DRT stop changing LF into CRLF
3154
3155         Reviewed by Sam.
3156
3157         * DumpRenderTree/win/DumpRenderTree.cpp:
3158         (main): Put stdout in binary mode.
3159         * Scripts/run-webkit-tests: Remove the CRLF hack.
3160
3161 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
3162
3163         Removed empty directory.
3164
3165         * Scripts/resources: Removed.
3166
3167 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
3168
3169         Fix bisect-builds to work with recent WebKit nightly builds.
3170
3171         Reviewed by Dan.
3172
3173         * Scripts/bisect-builds: Check for the 
3174         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
3175         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
3176         to WebKit.app/Contents/Resources.
3177
3178 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
3179
3180         Reviewed by Maciej.
3181
3182         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
3183         not closed (affects digg.com)
3184
3185         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
3186         one after finishing with a test to avoid having its delayed onload handler firing when
3187         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
3188         but it helps somewhat.
3189
3190 2007-11-22  Mark Rowe  <mrowe@apple.com>
3191
3192         Reviewed by Alp Toker.
3193
3194         Fix build-webkit to propagate make's exit status if it fails.
3195
3196         * Scripts/webkitdirs.pm:
3197
3198 2007-11-22  Dan Bernstein  <mitz@apple.com>
3199
3200         Reviewed by Mark Rowe.
3201
3202         - fix crash when running pixel tests
3203
3204         * DumpRenderTree/mac/DumpRenderTree.mm:
3205         (dumpRenderTree): Parse the command line options before setting up the
3206         environment so that we know if we need to set up the pixel dump
3207         machinery.
3208
3209 2007-11-21  Eric Seidel  <eric@webkit.org>
3210
3211         Speculative build fix for Tiger.
3212
3213         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
3214
3215 2007-11-21  Eric Seidel  <eric@webkit.org>
3216
3217         Reviewed by Tim Hatcher.
3218
3219         Break out more of DumpRenderTree.mm into individual files
3220
3221         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3222         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
3223         (checkedMalloc):
3224         (checkedRealloc):
3225         (makeLargeMallocFailSilently):
3226         * DumpRenderTree/mac/CheckedMalloc.h: Added.
3227         * DumpRenderTree/mac/DumpRenderTree.mm:
3228         (crashHandler):
3229         (dump):
3230         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3231         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3232         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3233         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3234         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3235         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
3236         (javaScriptThreads):
3237         (runJavaScriptThread):
3238         (startJavaScriptThreads):
3239         (stopJavaScriptThreads):
3240         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
3241         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
3242         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
3243         (restoreColorSpace):
3244         (setDefaultColorProfileToRGB):
3245         (initializeColorSpaceAndScreeBufferForPixelTests):
3246         (md5HashStringForBitmap):
3247         (dumpWebViewAsPixelsAndCompareWithExpected):
3248
3249 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
3250
3251         Move install-unix-extras to wx directory as it seems only to be used by that 
3252         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
3253         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
3254         have install-unix-extras install into WebKitLibraries as per
3255         convention.
3256         
3257         Reviewed by Mark Rowe.
3258
3259         * Scripts/install-unix-extras: Removed.
3260         * wx/build-wxwebkit:
3261         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
3262
3263 2007-11-21  Eric Seidel  <eric@webkit.org>
3264
3265         Reviewed by Adam.
3266
3267         More refactoring for greater code readability
3268
3269         * DumpRenderTree/mac/DumpRenderTree.mm:
3270         (initializeGlobalsFromCommandLineOptions):
3271         (initializeColorSpaceAndScreeBufferForPixelTests):
3272         (addTestPluginsToPluginSearchPath):
3273         (useLongRunningServerMode):
3274         (runTestingServerLoop):
3275         (prepareConsistentTestingEnvironment):
3276         (dumpRenderTree):
3277         (main):
3278         (dumpFramesAsText):
3279         (dumpBackForwardListForWebView):
3280         (sizeWebViewForCurrentTest):
3281         (methodNameStringForFailedTest):
3282         (dumpBackForwardListForAllWindows):
3283         (dumpWebViewAsPixelsAndCompareWithExpected):
3284         (invalidateAnyPreviousWaitToDumpWatchdog):
3285         (dump):
3286         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3287         * DumpRenderTree/mac/UIDelegate.mm:
3288         (-[UIDelegate webView:createWebViewWithRequest:]):
3289
3290 2007-11-21  Eric Seidel  <eric@webkit.org>
3291
3292         Reviewed by Tim Hatcher.
3293
3294         Abstract more of DRT into static methods
3295
3296         * DumpRenderTree/mac/DumpRenderTree.mm:
3297         (setDefaultsToConsistentValuesForTesting):
3298         (setupSignalHandlers):
3299         (allocateGlobalControllers):
3300         (releaseAndZero):
3301         (releaseGlobalControllers):
3302         (dumpRenderTree):
3303         (shouldLogFrameLoadDelegates):
3304         (createCFURLFromPathOrURL):
3305         (resetWebViewToConsistentStateBeforeTesting):
3306         (runTest):
3307
3308 2007-11-21  Eric Seidel  <eric@webkit.org>
3309
3310         Reviewed by Tim Hatcher.
3311
3312         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
3313
3314         * DumpRenderTree/DumpRenderTree.h:
3315         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3316         * DumpRenderTree/mac/DumpRenderTree.mm:
3317         (dumpRenderTree):
3318         (dump):
3319         (runTest):
3320         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
3321         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
3322         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
3323         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
3324         (-[DumpRenderTreePasteboard declareType:owner:]):
3325         (+[LocalPasteboard alloc]):
3326         (-[LocalPasteboard init]):
3327         (-[LocalPasteboard dealloc]):
3328         (-[LocalPasteboard name]):
3329         (-[LocalPasteboard releaseGlobally]):
3330         (-[LocalPasteboard declareTypes:owner:]):
3331         (-[LocalPasteboard addTypes:owner:]):
3332         (-[LocalPasteboard changeCount]):
3333         (-[LocalPasteboard types]):
3334         (-[LocalPasteboard availableTypeFromArray:]):
3335         (-[LocalPasteboard setData:forType:]):
3336         (-[LocalPasteboard dataForType:]):
3337         (-[LocalPasteboard setPropertyList:forType:]):
3338         (-[LocalPasteboard setString:forType:]):
3339         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
3340         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
3341         (+[DumpRenderTreeWindow allWindows]):
3342         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
3343         (-[DumpRenderTreeWindow dealloc]):
3344         (-[DumpRenderTreeWindow isKeyWindow]):
3345         (-[DumpRenderTreeWindow keyDown:]):
3346
3347 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
3348
3349         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
3350         it indiscriminately copies any headers inside JavaScriptCore,
3351         which includes Tiger ICU headers. 
3352
3353         * wx/build-wxwebkit:
3354         Don't run WebCore/move-js-headers.sh any longer.
3355
3356 2007-11-20  Adam Treat  <treat@kde.org>
3357
3358         Reviewed by David Kilzer.
3359
3360         * Prepend git branch name to $baseProductDir
3361
3362         * Scripts/VCSUtils.pm:
3363         * Scripts/webkitdirs.pm:
3364
3365 2007-11-20  Mark Rowe  <mrowe@apple.com>
3366
3367         Reviewed by Simon Hausmann.
3368
3369         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
3370         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
3371         Have it trigger a "make distclean" rather than "make clean" to ensure that the
3372         built product and generated Makefile's are removed.
3373
3374 2007-11-19  Alp Toker  <alp@atoker.com>
3375
3376         Reviewed by Mark Rowe.
3377
3378         http://bugs.webkit.org/show_bug.cgi?id=16040
3379         [GTK] GtkLauncher should be written in C
3380
3381         Port GtkLauncher to plain C.
3382
3383         Use a more conventional GTK+ coding style.
3384
3385         Use a toolbar instead of menus.
3386
3387         Various signature fixes and cleanups.
3388
3389         Add a license header. Assume all previous modifications were copyright
3390         assigned to Apple Inc. by default.
3391
3392         * GtkLauncher/GtkLauncher.pro:
3393         * GtkLauncher/main.c: Added.
3394         (activate_url_entry_cb):
3395         (update_title):
3396         (link_hover_cb):
3397         (title_change_cb):
3398         (progress_change_cb):
3399         (destroy_cb):
3400         (go_back_cb):
3401         (go_forward_cb):
3402         (create_browser):
3403         (create_statusbar):
3404         (create_toolbar):
3405         (create_window):
3406         (main):
3407         * GtkLauncher/main.cpp: Removed.
3408
3409 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
3410
3411         Build script fixes to ensure they do the right thing for the 
3412         wx port, and update build-wxwebkit to reflect the way the
3413         build scripts now work.
3414
3415         Reviewed by Adam.
3416
3417         * Scripts/build-testkjs:
3418         * Scripts/build-webkit:
3419         * Scripts/run-javascriptcore-tests:
3420         * Scripts/webkitdirs.pm:
3421         * wx/build-wxwebkit:
3422
3423 2007-11-18  Eric Seidel  <eric@webkit.org>
3424
3425         Reviewed by Anders.
3426
3427         Make run-javascriptcore-tests report failures on exit (to support git bisect)
3428
3429         * Scripts/run-javascriptcore-tests:
3430
3431 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
3432
3433         Reviewed by Adam Roben.
3434
3435         Make run-webkit-tests work with Windows debug build.
3436
3437         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
3438         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
3439         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
3440         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
3441         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
3442
3443 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
3444
3445         Add wxWebKit sample and build script, and integrate it with 
3446         build-webkit. Also make build-webkit --clean work for all
3447         ports.
3448
3449         Reviewed by Darin Adler.
3450
3451         * Scripts/build-webkit:
3452         * Scripts/webkitdirs.pm:
3453         * wx: Added.
3454         * wx/browser: Added.
3455         * wx/browser/browser.bkl: Added.
3456         * wx/browser/browser.cpp: Added.
3457         * wx/build-wxwebkit: Added.
3458
3459 2007-11-17  Adam Roben  <aroben@apple.com>
3460
3461         Make it easy to run Safari in the debugger on Windows
3462
3463         I've added a new script, debug-safari, which launches Safari in the
3464         debugger. On OS X it just calls gdb-safari.
3465
3466         Reviewed by Mark Rowe.
3467
3468         * FindSafari/FindSafari.cpp:
3469         (_tmain): Added a /debugger flag, which in combination with
3470         /printSafariLauncher will print a script that launches Safari in the
3471         debugger.
3472         * Scripts/debug-safari: Added.
3473         * Scripts/run-safari: Changed to call runSafari().
3474         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
3475         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
3476         first argument along to FindSafari.
3477         * Scripts/webkitdirs.pm:
3478         (sub runSafari): Added.
3479
3480 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
3481
3482         Reviewed by Adam Roben.
3483
3484         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
3485
3486 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
3487
3488         Reviewed by David Kilzer.
3489
3490         The git config command was renamed to repo-config at some point. This
3491         change tries git config and then git repo-config if the first fails.
3492
3493         * Scripts/prepare-ChangeLog:
3494         (gitConfig):
3495
3496 2007-11-16  Dan Bernstein  <mitz@apple.com>
3497
3498         Reviewed by Darin Adler and Sam Weinig.
3499
3500         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
3501
3502         * DumpRenderTree/win/EventSender.cpp:
3503         (keyDownCallback): For characters that cannot be entered on the active
3504         keyboard layout, send a WM_CHAR message with the character along with
3505         a WM_KEYDOWN message with a virtual key code of 255.
3506
3507 2007-11-16  Mark Rowe  <mrowe@apple.com>
3508
3509         Reviewed by Tim Hatcher.
3510
3511         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
3512
3513         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3514         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3515
3516 2007-11-15  Adam Roben  <aroben@apple.com>
3517
3518         Make run-safari actually work on Windows
3519
3520         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
3521         chdir call.
3522
3523 2007-11-14  Adam Roben  <aroben@apple.com>
3524
3525         Updates to Safari launching now that 3.0.4 is released
3526
3527         Reviewed by Sam.
3528
3529         * FindSafari/FindSafari.cpp:
3530         (getWebViewCLSID): Use version-independent ProgID.
3531         * Scripts/run-safari: Use run-webkit-nightly.cmd.
3532
3533 2007-11-14  Anders Carlsson  <andersca@apple.com>
3534
3535         Reviewed by Adam.
3536
3537         <rdar://problem/5309081>
3538         In DRT, "plugin.logDestroy = true" not working on Windows.
3539         
3540         * DumpRenderTree/win/TestNetscapePlugin/main.c:
3541         (NPP_Destroy):
3542
3543 2007-11-14  Eric Seidel  <eric@webkit.org>
3544
3545         Reviewed by Sam.
3546
3547         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
3548
3549 2007-11-14  Anders Carlsson  <andersca@apple.com>
3550
3551         Reviewed by Adam.
3552
3553         <rdar://problem/5141186>
3554         window.layoutTestController.setWindowIsKey is not implemented in DRT.
3555         
3556         Implement setWindowIsKey.
3557         
3558         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3559         (LayoutTestController::setWindowIsKey):
3560
3561 2007-11-13  Sam Weinig  <sam@webkit.org>
3562
3563         Reviewed by Adam Roben.
3564
3565         Fix for <rdar://problem/5382579>
3566         http/tests/security/cross-frame-access-put.html reports large 
3567         negative numbers for screenLeft and screenTop (Mac reports "0")
3568
3569         * DumpRenderTree/win/UIDelegate.cpp:
3570         (UIDelegate::UIDelegate): Initialize the RECT.
3571         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
3572         (UIDelegate::webViewFrame): ditto.
3573         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
3574
3575 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
3576
3577         Reviewed by Adam.
3578
3579         - Make Drosera show source, source URLs, and function stack on Windows,
3580         and some minor fixes.
3581
3582         * Drosera/DebuggerDocument.cpp: Force source to always update display.
3583         (DebuggerDocument::updateFileSource):
3584         * Drosera/debugger.js: Force source to always update display.
3585         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
3586         menu controls.
3587         (DebuggerClient::resume):
3588         (DebuggerClient::pause):
3589         (DebuggerClient::stepInto):
3590         (DebuggerClient::stepOver):
3591         (DebuggerClient::stepOut):
3592         (DebuggerClient::showConsole):
3593         (DebuggerClient::closeCurrentFile):
3594         * Drosera/win/DebuggerClient.h: Ditto.
3595         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
3596         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
3597         removed two bugs.  1) caller could be in a bad state when asked to
3598         assign into it. 2) BSTRs were not created correctly.
3599         (DebuggerDocument::getPlatformCurrentFunctionStack):
3600         * Drosera/win/Drosera.cpp: Hook up the menu controls.
3601         (droseraWndProc):
3602         (handleCommand):
3603         (Drosera::resume):
3604         (Drosera::pause):
3605         (Drosera::stepInto):
3606         (Drosera::stepOver):
3607         (Drosera::stepOut):
3608         (Drosera::showConsole):
3609         (Drosera::closeCurrentFile):
3610         * Drosera/win/Drosera.h: Hook up the menu controls.
3611         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
3612         functions, added a null check, and fixed another bug where caller could
3613         be in a bad state when asked to assign into it.
3614         (ServerConnection::didLoadMainResourceForDataSource):
3615         (ServerConnection::getCallerFrame):
3616         * Drosera/win/ServerConnection.h: Safety first.
3617
3618 2007-11-13  Dan Bernstein  <mitz@apple.com>
3619
3620         Reviewed by Darin Adler.
3621
3622         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
3623           DumpRenderTree --pixel-tests renders each test twice
3624
3625         * DumpRenderTree/mac/DumpRenderTree.mm:
3626         (dumpRenderTree): Removed the --paint option because the painting code
3627         is always exercised as a result of
3628         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
3629         calling -displayIfNeeded.
3630         (dump): Changed to always grab the image from the window since the view
3631         is always displayed.
3632         (runTest):
3633         (displayWebView):
3634         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
3635         because it always paints.
3636
3637 2007-11-12  Antti Koivisto  <antti@apple.com>
3638
3639         Reviewed by Adele.
3640         
3641         Add support for http media tests
3642
3643         * Scripts/run-webkit-tests:
3644
3645 2007-11-12  Sam Weinig  <sam@webkit.org>
3646
3647         Reviewed by Adam Roben.
3648
3649         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
3650
3651         * DumpRenderTree/win/DumpRenderTree.cpp:
3652         (runTest):
3653         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3654         (LayoutTestController::setPrivateBrowsingEnabled):
3655
3656 2007-11-12  Adam Roben  <aroben@apple.com>
3657
3658         * Scripts/update-webkit-localizable-strings: Changed to only scan the
3659         mac and win subdirectories.
3660
3661 2007-11-11  Adam Roben  <aroben@apple.com>
3662
3663         Fix <rdar://5133816> keepWebHistory is not implemented
3664
3665         Fixes fast/history/clicked-link-is-visited.html.
3666
3667         Reviewed by Darin.
3668