WebCore: Swedish search (and other languages as well) is broken while fixing Japanese...
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2
3         Reviewed by Gustavo Noronha.
4
5         [GTK] Added conditional code to avoid using
6         gdk_window_get_root_coords if we do not have a gtk+ release newer
7         than 2.17.3.
8         https://bugs.webkit.org/show_bug.cgi?id=30636
9
10         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
11
12 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
13
14         Reviewed by Eric Seidel.
15
16         [Qt] Added dummy implementation for keepWebHistory()
17         https://bugs.webkit.org/show_bug.cgi?id=30592
18
19         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
20         (LayoutTestController::keepWebHistory):
21         * DumpRenderTree/qt/LayoutTestControllerQt.h:
22
23 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
24
25         Reviewed by Xan Lopez.
26
27         [GTK] Fixed the double click condition, it is not double click if
28         we move in just in one direction.
29         https://bugs.webkit.org/show_bug.cgi?id=30636
30
31         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
32
33 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
34
35         Reviewed by Xan Lopez.
36
37         [GTK] Initialize the events completly before emitting them.
38         https://bugs.webkit.org/show_bug.cgi?id=30633
39
40         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
41
42 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
43
44         wx build fix. Fix for when linking using --as-needed with gcc.
45
46         * wx/browser/wscript:
47
48 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
49
50         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
51         to support all the features used by CURL backend.
52         
53         * wx/build/settings.py:
54         * wx/install-unix-extras:
55
56 2009-10-20  Anton Muhin  <antonm@chromium.org>
57
58         Reviewed by Adam Barth.
59
60         Add {ager,antonm,yurys}@chromium.org into committers.py
61         https://bugs.webkit.org/show_bug.cgi?id=30560
62
63         * Scripts/modules/committers.py:
64
65 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
66
67         Reviewed by Tor Arne Vestbø.
68
69         Make the Netscape Test plugin available to the Qt launcher.
70
71         * Scripts/run-launcher:
72
73 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
74
75         Reviewed by David Levin.
76
77         Removed WebSocket runtime settings.
78         https://bugs.webkit.org/show_bug.cgi?id=29896
79
80         WebSocket runtime configuration is supported by chromium/v8 only.
81
82         * DumpRenderTree/mac/DumpRenderTree.mm:
83         (resetDefaultsToConsistentValues):
84         * DumpRenderTree/win/DumpRenderTree.cpp:
85         (resetDefaultsToConsistentValues):
86
87 2009-10-19  Nate Chapin  <japhet@chromium.org>
88
89         Reviewed by Adam Barth.
90
91         Add testFail() to test plugin so we can test our handling of a
92         plugin invoke call returning false.
93
94         https://bugs.webkit.org/show_bug.cgi?id=30239
95
96         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
97         (pluginInvoke):
98         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
99
100 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
101
102         Reviewed by Gustavo Noronha.
103
104         Enable DOM pasting when running layout tests.
105
106         * DumpRenderTree/gtk/DumpRenderTree.cpp:
107         (resetDefaultsToConsistentValues):
108
109 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
110
111         Reviewed by Simon Hausmann.
112
113         Use the setPreferredContentsSize method instead
114         of setFixedContentsSize, as the method has been renamed.
115
116         * DumpRenderTree/qt/DumpRenderTree.cpp:
117         (WebCore::DumpRenderTree::open):
118         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
119         (LayoutTestController::setFixedContentsSize):
120
121 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
122
123         Reviewed by Dan Bernstein.
124
125         https://bugs.webkit.org/show_bug.cgi?id=30456
126         Fixes for new Debug_All Windows build configuration.
127
128         * DumpRenderTree/win/DumpRenderTree.cpp:
129         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
130         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
131
132 2009-10-16  Eric Seidel  <eric@webkit.org>
133
134         Reviewed by Adam Barth.
135
136         commit-queue status bot should list which buildbot is blocking the queue
137         https://bugs.webkit.org/show_bug.cgi?id=30452
138
139         Add new methods and testing.
140
141         * Scripts/bugzilla-tool:
142         * Scripts/modules/buildbot.py:
143         * Scripts/modules/buildbot_unittest.py:
144
145 2009-10-16  Eric Seidel  <eric@webkit.org>
146
147         Reviewed by Adam Barth.
148
149         run-webkit-tests fails when CWD is not inside a WebKit checkout
150         https://bugs.webkit.org/show_bug.cgi?id=30451
151
152         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
153         * Scripts/modules/scm_unittest.py:
154           - Remove use of original_path (we don't need to restore the CWD).
155           - Don't use '.' to find the webkit checkout, use __file__ instead.
156
157 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
158
159         Reviewed by Adam Roben.
160
161         Add a Debug_All configuration to build entire stack as debug.
162         Change Debug_Internal to:
163         - stop using _debug suffix for all WebKit/Safari binaries
164         - not use _debug as a DLL naming suffix
165         - use non-debug C runtime lib.
166
167         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
168         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
169         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
170         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
171         Add missing debug.vsprops inherited property sheet.
172         Add Debug_All configuration.
173         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
174         * WinLauncher/WinLauncher.vcproj:
175         Removed extraneous definitions inherited from vsprops.
176         Add Debug_All configuration.
177
178 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
179
180         Reviewed by David Levin.
181
182         check-webkit-style is wrong about indent checking in namespaces
183         in header files and a few other things
184         https://bugs.webkit.org/show_bug.cgi?id=30362
185
186         The few other things include:
187         + check-webkit-style does not require spaces around the equal sign
188           inside 'if' statements and around binary operators that take 
189           numeric literals.
190         + check-webkit-style reports false errors for the / operator
191           when part of a filename in the #include directive.
192
193         * Scripts/modules/cpp_style.py:
194         Improved indentation checking and space checking around
195         binary operators. While the checks are still not perfect,
196         they are clearly better than before.
197         * Scripts/modules/cpp_style_unittest.py:
198         Added test cases for the newly supported checks and modified old
199         test cases to match the new guidelines
200
201 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
202
203         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
204
205         * wx/build/settings.py:
206
207 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
208
209         Reviewed by David Levin.
210
211         Add mod_pywebsocket to test Web Sockets.
212         http://code.google.com/p/pywebsocket/
213         https://bugs.webkit.org/show_bug.cgi?id=27490
214
215         * pywebsocket/COPYING: Added.
216         * pywebsocket/MANIFEST.in: Added.
217         * pywebsocket/README: Added.
218         * pywebsocket/example/echo_client.py: Added.
219         * pywebsocket/example/echo_wsh.py: Added.
220         * pywebsocket/mod_pywebsocket/__init__.py: Added.
221         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
222         * pywebsocket/mod_pywebsocket/handshake.py: Added.
223         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
224         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
225         * pywebsocket/mod_pywebsocket/standalone.py: Added.
226         * pywebsocket/mod_pywebsocket/util.py: Added.
227         * pywebsocket/setup.py: Added.
228         * pywebsocket/test/config.py: Added.
229         * pywebsocket/test/mock.py: Added.
230         * pywebsocket/test/run_all.py: Added.
231         * pywebsocket/test/test_dispatch.py: Added.
232         * pywebsocket/test/test_handshake.py: Added.
233         * pywebsocket/test/test_mock.py: Added.
234         * pywebsocket/test/test_msgutil.py: Added.
235         * pywebsocket/test/test_util.py: Added.
236         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
237         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
238         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
239         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
240         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
241         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
242         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
243         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
244
245 2009-10-15  James Robinson  <jamesr@google.com>
246
247         Reviewed by David Levin.
248
249         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
250
251         https://bugs.webkit.org/show_bug.cgi?id=30426
252
253         * Scripts/modules/cpp_style.py:
254         * Scripts/modules/cpp_style_unittest.py:
255
256 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
257
258         Reviewed by Adam Roben.
259
260         Fixes <http://webkit.org/b/30411>.
261         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
262         
263         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
264         building Chromium.
265
266         * Scripts/pdevenv:
267
268 2009-10-15  Robin Dunn  <robin@alldunn.com>
269
270         Reviewed by Kevin Ollivier.
271
272         Add Mac package building scripts for wx.
273         
274         https://bugs.webkit.org/show_bug.cgi?id=30405
275
276         * wx/build/build_utils.py:
277         * wx/build/settings.py:
278         * wx/packaging/build-mac-installer.py: Added.
279
280 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
281
282         Reviewed by Gustavo Noronha.
283
284         Enable Web Sockets support when running layout tests.
285
286         * DumpRenderTree/gtk/DumpRenderTree.cpp:
287         (resetDefaultsToConsistentValues):
288
289 2009-10-15  Xan Lopez  <xlopez@igalia.com>
290
291         Reviewed by Gustavo Noronha.
292
293         Need to initialize event.button.button, since in most cases a
294         button number is not passed as an argument.
295
296         * DumpRenderTree/gtk/EventSender.cpp:
297         (mouseDownCallback):
298         (mouseUpCallback):
299
300 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
301
302         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
303         the OS if none was explicitly set.
304
305         * wx/build/settings.py:
306
307 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
308
309         Reviewed by Timothy Hatcher.
310
311         Web Inspector: enable developers extras within inspector layout tests.
312
313         https://bugs.webkit.org/show_bug.cgi?id=30014
314
315         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
316         (LayoutTestController::showWebInspector):
317         (LayoutTestController::closeWebInspector):
318         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
319         (LayoutTestController::showWebInspector):
320         (LayoutTestController::closeWebInspector):
321
322 2009-10-14  José Millán Soto  <jmillan@igalia.com>
323
324         Reviewed by Jan Alonzo.
325
326         GtkLauncher is using a deprecated signal
327         https://bugs.webkit.org/show_bug.cgi?id=30364
328
329         Modified GtkLauncher to use notify::title signal instead of
330         deprecated title-changed signal
331
332         * GtkLauncher/main.c:
333         (notify_title_cb):
334         (create_browser):
335
336 2009-10-14  Brady Eidson  <beidson@apple.com>
337
338         Reviewed by Sam Weinig.
339
340         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
341         1 - Disables WebHistory
342         2 - Doesn't make sense in that context anyway.
343
344         * DumpRenderTree/win/DumpRenderTree.cpp:
345         (createWebViewAndOffscreenWindow):
346
347 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
348
349         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
350         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
351
352         * wx/build/settings.py:
353         * wx/install-unix-extras:
354
355 2009-10-14  Brady Eidson  <beidson@apple.com>
356
357         Reviewed by Sam Weinig.
358
359         WebKit Win API should provide a delegate interface for global history.
360         https://bugs.webkit.org/show_bug.cgi?id=29905
361
362         * DumpRenderTree/LayoutTestController.cpp:
363         (LayoutTestController::LayoutTestController):
364         * DumpRenderTree/LayoutTestController.h:
365         (LayoutTestController::dumpHistoryDelegateCallbacks):
366         (LayoutTestController::setDumpHistoryDelegateCallbacks):
367                 
368         * DumpRenderTree/win/DumpRenderTree.cpp:
369         (shouldLogHistoryDelegates):
370         (runTest):
371         (createWebViewAndOffscreenWindow):
372         (main):
373         * DumpRenderTree/win/DumpRenderTree.vcproj:
374         
375         Add the IWebHistoryDelegate to DRT Windows:
376         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
377         (wstringFromBSTR):
378         (HistoryDelegate::HistoryDelegate):
379         (HistoryDelegate::~HistoryDelegate):
380         (HistoryDelegate::QueryInterface):
381         (HistoryDelegate::AddRef):
382         (HistoryDelegate::Release):
383         (HistoryDelegate::didNavigateWithNavigationData):
384         (HistoryDelegate::didPerformClientRedirectFromURL):
385         (HistoryDelegate::didPerformServerRedirectFromURL):
386         (HistoryDelegate::updateHistoryTitle):
387         (HistoryDelegate::populateVisitedLinksForWebView):
388         * DumpRenderTree/win/HistoryDelegate.h: Added.
389
390         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
391         (LayoutTestController::removeAllVisitedLinks):
392
393 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
394
395         Reviewed by Simon Hausmann.
396
397         [Qt] Implement support for setPOSIXLocale on Qt.
398         https://bugs.webkit.org/show_bug.cgi?id=30268 
399  
400         * DumpRenderTree/qt/DumpRenderTree.cpp:
401         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
402         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
403         (LayoutTestController::setPOSIXLocale):
404         * DumpRenderTree/qt/LayoutTestControllerQt.h:
405
406 2009-10-13  Stephanie Lewis  <slewis@apple.com>
407
408         Unreviewed, adding myself to reviewers list.
409
410         * Scripts/modules/committers.py:
411
412 2009-10-13  Stephanie Lewis  <slewis@apple.com>
413
414         Reviewed by Mark Rowe.
415
416         Fix null assignment so root tests work again.
417
418         * Scripts/webkitdirs.pm:
419
420 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
421
422         Reviewed by Simon Hausmann.
423
424         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
425         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
426         This is done in preparation of implementing missing features in DRT.
427         No functionality changes made yet.
428
429         * DumpRenderTree/qt/DumpRenderTree.cpp:
430         * DumpRenderTree/qt/DumpRenderTree.pro:
431         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
432         (EventSender::EventSender):
433         (EventSender::mouseDown):
434         (EventSender::mouseUp):
435         (EventSender::mouseMoveTo):
436         (EventSender::leapForward):
437         (EventSender::keyDown):
438         (EventSender::contextClick):
439         (EventSender::scheduleAsynchronousClick):
440         (EventSender::frameUnderMouse):
441         * DumpRenderTree/qt/EventSenderQt.h: Added.
442         (EventSender::clearKillRing):
443         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
444         (LayoutTestController::LayoutTestController):
445         (LayoutTestController::reset):
446         (LayoutTestController::processWork):
447         (LayoutTestController::maybeDump):
448         (LayoutTestController::waitUntilDone):
449         (LayoutTestController::notifyDone):
450         (LayoutTestController::windowCount):
451         (LayoutTestController::clearBackForwardList):
452         (LayoutTestController::dumpEditingCallbacks):
453         (LayoutTestController::dumpResourceLoadCallbacks):
454         (LayoutTestController::queueBackNavigation):
455         (LayoutTestController::queueForwardNavigation):
456         (LayoutTestController::queueLoad):
457         (LayoutTestController::queueReload):
458         (LayoutTestController::queueScript):
459         (LayoutTestController::provisionalLoad):
460         (LayoutTestController::timerEvent):
461         (LayoutTestController::encodeHostName):
462         (LayoutTestController::decodeHostName):
463         (LayoutTestController::setJavaScriptProfilingEnabled):
464         (LayoutTestController::setFixedContentsSize):
465         (LayoutTestController::setPrivateBrowsingEnabled):
466         (LayoutTestController::setPopupBlockingEnabled):
467         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
468         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
469         (LayoutTestController::numberOfActiveAnimations):
470         (LayoutTestController::disableImageLoading):
471         (LayoutTestController::dispatchPendingLoadRequests):
472         (LayoutTestController::setDatabaseQuota):
473         (LayoutTestController::clearAllDatabases):
474         (LayoutTestController::whiteListAccessFromOrigin):
475         (LayoutTestController::waitForPolicyDelegate):
476         (LayoutTestController::overridePreference):
477         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
478         (LayoutTestController::isLoading):
479         (LayoutTestController::setLoading):
480         (LayoutTestController::shouldDumpAsText):
481         (LayoutTestController::shouldDumpBackForwardList):
482         (LayoutTestController::shouldDumpChildrenAsText):
483         (LayoutTestController::shouldDumpDatabaseCallbacks):
484         (LayoutTestController::shouldDumpStatusCallbacks):
485         (LayoutTestController::shouldWaitUntilDone):
486         (LayoutTestController::canOpenWindows):
487         (LayoutTestController::shouldDumpTitleChanges):
488         (LayoutTestController::waitForPolicy):
489         (LayoutTestController::dumpAsText):
490         (LayoutTestController::dumpChildFramesAsText):
491         (LayoutTestController::dumpDatabaseCallbacks):
492         (LayoutTestController::dumpStatusCallbacks):
493         (LayoutTestController::setCanOpenWindows):
494         (LayoutTestController::dumpBackForwardList):
495         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
496         (LayoutTestController::display):
497         (LayoutTestController::dumpTitleChanges):
498         (LayoutTestController::dumpSelectionRect):
499         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
500         (TextInputController::TextInputController):
501         (TextInputController::doCommand):
502         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
503         * DumpRenderTree/qt/WorkQueue.cpp:
504         * DumpRenderTree/qt/WorkQueue.h:
505         * DumpRenderTree/qt/WorkQueueItem.h:
506         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
507         (findFrameNamed):
508         (LoadItem::invoke):
509         (ReloadItem::invoke):
510         (ScriptItem::invoke):
511         (BackForwardItem::invoke):
512         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
513         * DumpRenderTree/qt/jsobjects.h:
514
515 2009-10-13  Dmitry Titov  <dimich@chromium.org>
516
517         Not reviewed, adding myself to the list of reviewers.
518
519         * Scripts/modules/committers.py:
520
521 2009-10-13  Anders Carlsson  <andersca@apple.com>
522
523         Reviewed by Sam Weinig.
524
525         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
526
527         Make the private browsing mode testable by the test plug-in.
528         
529         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
530         (pluginGetProperty):
531         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
532         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
533         (NPP_New):
534         (NPP_SetValue):
535
536 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
537
538         No review, just adding self to the list of reviewers.
539
540         * Scripts/modules/committers.py:
541
542 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
543
544         Reviewed by Adam Roben.
545
546         Web Inspector: Use proper web view in inspector layout
547         tests for windows.
548
549         https://bugs.webkit.org/show_bug.cgi?id=30298
550
551         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
552         (LayoutTestController::showWebInspector):
553         (LayoutTestController::closeWebInspector):
554         (LayoutTestController::evaluateInWebInspector):
555
556 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
557
558         Reviewed by Sam Weinig.
559
560         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
561         https://bugs.webkit.org/show_bug.cgi?id=29841
562
563         * DumpRenderTree/mac/DumpRenderTree.mm:
564         (resetDefaultsToConsistentValues):
565         * DumpRenderTree/win/DumpRenderTree.cpp:
566         (resetDefaultsToConsistentValues):
567
568 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
569
570         Reviewed by Dimitri Glazkov.
571
572         Chromium Port - Windows
573         https://bugs.webkit.org/show_bug.cgi?id=29969
574
575         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
576         * Scripts/webkitdirs.pm:
577
578 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
579
580         Reviewed by Darin Adler.
581
582         jsc scripts cleanup and Qt/GTK fix
583         https://bugs.webkit.org/show_bug.cgi?id=30288
584
585         Duplicated jscPath() moved to webkitdirs.pm.
586         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
587         Configuration added (release/debug) to path for Qt-port on Windows.
588
589         * Scripts/run-javascriptcore-tests:
590         * Scripts/run-jsc:
591         * Scripts/run-sunspider:
592         * Scripts/sunspider-compare-results:
593         * Scripts/webkitdirs.pm:
594
595 2009-10-11  Adam Barth  <abarth@webkit.org>
596
597         Unreviewed.  Add Collin to committers.py.
598
599         * Scripts/modules/committers.py:
600
601 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
602
603         wx build fix, add bindings to source/include dirs now that there are sources there.
604
605         * wx/build/settings.py:
606
607 2009-10-09  Mark Rowe  <mrowe@apple.com>
608
609         Reviewed by Brady Eidson.
610
611         Enable plug-in halting in DumpRenderTree.
612
613         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
614         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
615
616         * DumpRenderTree/mac/DumpRenderTree.mm:
617         (resetDefaultsToConsistentValues):
618         * DumpRenderTree/mac/UIDelegate.mm:
619         (-[UIDelegate webView:shouldHaltPlugin:]):
620
621 2009-10-08  Brady Eidson  <beidson@apple.com>
622
623         Reviewed by Dan Bernstein.
624
625         Ask the History Delegate to populate the visited links hash.
626         <rdar://problem/7285293> and https://webkit.org/b/29904
627
628         Add the ability for LayoutTestController to clear all visited links.
629         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
630
631         * DumpRenderTree/LayoutTestController.cpp:
632         (LayoutTestController::LayoutTestController):
633         (removeAllVisitedLinksCallback):
634         (LayoutTestController::staticFunctions):
635         * DumpRenderTree/LayoutTestController.h:
636         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
637         (LayoutTestController::removeAllVisitedLinks):
638
639         * DumpRenderTree/mac/HistoryDelegate.mm:
640         (-[HistoryDelegate populateVisitedLinksForWebView:]):
641
642         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
643         (LayoutTestController::removeAllVisitedLinks):
644         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
645         (LayoutTestController::removeAllVisitedLinks):
646         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
647         (LayoutTestController::removeAllVisitedLinks):
648
649
650 2009-10-08  Daniel Bates  <dbates@webkit.org>
651
652         Reviewed by Adam Roben.
653
654         https://bugs.webkit.org/show_bug.cgi?id=30175
655         
656         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
657         the OLE drag-and-drop return value like the function it emulates. Currently, 
658         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
659         whether the drag-and-drop operation was successful or was cancelled.
660         
661         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
662         return value according to whether the drop operation was successful or not.
663
664         * DumpRenderTree/win/EventSender.cpp:
665         (doMouseUp): Added parameter oleDragAndDropReturnValue.
666         (replaySavedEvents): Ditto.
667         * DumpRenderTree/win/EventSender.h:
668         * DumpRenderTree/win/UIDelegate.cpp:
669         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
670
671 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
672
673         Reviewed by Xan Lopez.
674
675         [GTK] Added support for a parameter setting the button that was
676         pressed in the mouseDown function.
677         https://bugs.webkit.org/show_bug.cgi?id=30220
678
679         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
680
681 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
682
683         Reviewed by Xan Lopez.
684
685         [GTK] Added a line to the bottom of the expected result to match
686         the output of the test.
687         https://bugs.webkit.org/show_bug.cgi?id=30220
688
689         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
690         expected.txt:
691
692 2009-10-08  Adam Roben  <aroben@apple.com>
693
694         Use QueryInterface to get IWebInspectorPrivate
695
696         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
697         accessed in a more standard way
698
699         Reviewed by John Sullivan and Tim Hatcher.
700
701         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
702         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
703         by calling IWebViewPrivate::inspector, then use QueryInterface to get
704         to the IWebInspectorPrivate interface.
705
706 2009-10-07  Adam Roben  <aroben@apple.com>
707
708         Implement DRT support for origin whitelisting
709
710         Fixes <http://webkit.org/b/30185>.
711
712         Reviewed by Eric Seidel.
713
714         * DumpRenderTree/win/DumpRenderTree.cpp:
715         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
716         whitelist, to match Mac DRT.
717         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
718         (LayoutTestController::whiteListAccessFromOrigin): Call through to
719         IWebViewPrivate::whiteListAccessFromOrigin.
720
721 2009-10-07  Brady Eidson  <beidson@apple.com>
722
723         Reviewed by Darin Adler.
724
725         Send title changes to the global history delegate.
726         <rdar://problem/7285293> and https://webkit.org/b/29904
727
728         * DumpRenderTree/mac/HistoryDelegate.mm:
729         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
730
731 2009-10-07  Adam Barth  <abarth@webkit.org>
732
733         Unreviewed.  Remove some folks from committers.py who were listed on
734         the WebKit Team wiki page but who weren't actually listed as commit+.
735         At some point, we should coorelate this list with the committers
736         mailing list.
737
738         * Scripts/modules/committers.py:
739
740 2009-10-07  Adam Barth  <abarth@webkit.org>
741
742         Unreviewed.  Import a bunch of committers from the WebKit Team page on
743         the wiki into committers.py.
744
745         * Scripts/modules/committers.py:
746
747 2009-10-07  Adam Barth  <abarth@webkit.org>
748
749         Unreviewed.  Added Aaron Boodman to committers.py.
750
751         * Scripts/modules/committers.py:
752
753 2009-10-07  Evan Martin  <evan@chromium.org>
754
755         Reviewed by Darin Adler.
756
757         Add API to LayoutTestController for re/setting the system locale.
758         https://bugs.webkit.org/show_bug.cgi?id=18994
759
760         * DumpRenderTree/LayoutTestController.cpp:
761         (setLocaleCallback):
762         (LayoutTestController::staticFunctions):
763         (LayoutTestController::setLocale):
764         * DumpRenderTree/LayoutTestController.h:
765
766 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
767
768         Reviewed by Jan Alonzo.
769
770         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
771         https://bugs.webkit.org/show_bug.cgi?id=29689
772
773         Build fix by adding -lfontconfig for DumpRenderTree.
774
775         * GNUmakefile.am:
776
777 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
778
779         Reviewed by Simon Hausmann.
780
781         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
782
783         * Scripts/run-webkit-tests:
784
785 2009-10-07  Xan Lopez  <xlopez@igalia.com>
786
787         Reviewed by Gustavo Noronha.
788
789         "delete" in EventSender is the backspace key, not the delete one.
790
791         * DumpRenderTree/gtk/EventSender.cpp:
792         (keyDownCallback):
793
794 2009-10-07  Xan Lopez  <xlopez@igalia.com>
795
796         Reviewed by Gustavo Noronha.
797
798         getChildrenWithRange expects as last parameter the end index, not
799         the length of the range. Correct this and clarify the variable
800         names to reflect how the code works.
801
802         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
803         (AccessibilityUIElement::getChildrenWithRange):
804         (AccessibilityUIElement::getChildAtIndex):
805
806 2009-10-06  Mark Rowe  <mrowe@apple.com>
807
808         Reviewed by Simon Fraser.
809
810         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
811
812         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
813         the fact we have already changed the working directory to the top of the open source tree.
814
815 2009-10-06  Julie Parent  <jparent@chromium.org>
816
817         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
818         rather than my committer email.
819
820         * Scripts/modules/committers.py:
821
822 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
823
824         Reviewed by Eric Seidel.
825
826         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
827
828         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
829         it after each layout test as it should do, making the DRT dump additional output
830         for all of the subsequent layout tests.
831
832         * DumpRenderTree/qt/jsobjects.cpp:
833         (LayoutTestController::reset):
834
835 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
836
837         Reviewed by Simon Hausmann.
838
839         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
840         fast/dom/assign-to-window-status.html test, which is passing as a result.
841
842         https://bugs.webkit.org/show_bug.cgi?id=30127
843
844         * DumpRenderTree/qt/DumpRenderTree.cpp:
845         (WebCore::DumpRenderTree::DumpRenderTree):
846         (WebCore::DumpRenderTree::statusBarMessage):
847         * DumpRenderTree/qt/DumpRenderTree.h:
848         * DumpRenderTree/qt/jsobjects.h:
849         (LayoutTestController::shouldDumpStatusCallbacks):
850         (LayoutTestController::dumpStatusCallbacks):
851
852 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
853
854         Reviewed by Simon Hausmann.
855
856         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
857         ignores the argument indicating which mouse button to trigger.
858         https://bugs.webkit.org/show_bug.cgi?id=30048
859
860         This affects the fast/events/mouse-click-events.html layout test.
861
862         * DumpRenderTree/qt/jsobjects.cpp:
863         (EventSender::mouseDown):
864         (EventSender::mouseUp):
865         * DumpRenderTree/qt/jsobjects.h:
866
867 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
868
869         Reviewed by Simon Hausmann.
870
871         [Qt] Fix the EventSender::keyDown() implementation
872         https://bugs.webkit.org/show_bug.cgi?id=30043
873
874         It should post both a key press event and a key release event,
875         just like other ports do.
876
877         * DumpRenderTree/qt/jsobjects.cpp:
878         (EventSender::keyDown):
879
880 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
881
882         wx build fix. Add jpeg to the list of libs to link against.
883
884         * wx/build/settings.py:
885
886 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
887
888         Reviewed by Simon Hausmann.
889
890         [Qt] EventSender::keyDown() cannot send function-key events.
891         https://bugs.webkit.org/show_bug.cgi?id=30044
892
893         This affects the fast/events/keydown-function-keys.html layout test.
894
895         * DumpRenderTree/qt/jsobjects.cpp:
896         (EventSender::keyDown):
897
898 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
899
900         Added --wx-compiler-prefix waf option to allow building wxWebKit with
901         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
902
903         * wx/build/settings.py:
904         * wx/build/wxpresets.py:
905
906 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
907
908         Reviewed by Timothy Hatcher.
909
910         Web Inspector: add testing harness for Web Inspector.
911
912         https://bugs.webkit.org/show_bug.cgi?id=30010
913
914         * DumpRenderTree/LayoutTestController.cpp:
915         (showWebInspectorCallback):
916         (closeWebInspectorCallback):
917         (evaluateInWebInspectorCallback):
918         (LayoutTestController::staticFunctions):
919         * DumpRenderTree/LayoutTestController.h:
920         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
921         (LayoutTestController::showWebInspector):
922         (LayoutTestController::closeWebInspector):
923         (LayoutTestController::evaluateInWebInspector):
924         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
925         (LayoutTestController::showWebInspector):
926         (LayoutTestController::closeWebInspector):
927         (LayoutTestController::evaluateInWebInspector):
928         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
929         (LayoutTestController::showWebInspector):
930         (LayoutTestController::closeWebInspector):
931         (LayoutTestController::evaluateInWebInspector):
932         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
933         (LayoutTestController::showWebInspector):
934         (LayoutTestController::closeWebInspector):
935         (LayoutTestController::evaluateInWebInspector):
936
937 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
938
939         Reviewed by Ariyha Hidayat.
940
941         Pass arguments to system() as a string instead of array
942
943         When passed as an array entries with a space fail to translate
944         to two arguments to the child process, so instead of manually
945         splitting all the entries in @buildArgs we pass the whole thing
946         as a string instead.
947
948         * Scripts/webkitdirs.pm:
949
950 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
951
952         Reviewed by David Levin.
953
954         check-webkit-style misses whitespace errors for operators:
955         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
956         https://bugs.webkit.org/show_bug.cgi?id=30021
957
958         * Scripts/modules/cpp_style.py:
959         Added the operators mentioned above to the same list as == and !=.
960
961 2009-10-02  Julie Parent  <jparent@chromium.org>
962
963         Unreviewed.
964
965         Adding myself and Ojan Vafai as committers, because we are committers.
966
967         * Scripts/modules/committers.py:
968
969 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
970
971         Reviewed by Adam Roben.
972
973         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
974         this will help the patch merging process when TryBots are used.
975
976         * Scripts/svn-create-patch:
977
978 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
979
980         Reviewed by Simon Hausmann.
981
982         [Qt] Implement layoutTestController.overridePreference().
983         https://bugs.webkit.org/show_bug.cgi?id=29970
984
985         * DumpRenderTree/qt/DumpRenderTree.cpp:
986         (WebCore::WebPage::WebPage):
987         (WebCore::WebPage::resetSettings):
988         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
989         * DumpRenderTree/qt/jsobjects.cpp:
990         (LayoutTestController::reset):
991         (LayoutTestController::setPrivateBrowsingEnabled):
992         (LayoutTestController::setPopupBlockingEnabled):
993         (LayoutTestController::overridePreference):
994         * DumpRenderTree/qt/jsobjects.h:
995
996 2009-10-01  Chris Marrin  <cmarrin@apple.com>
997
998         Reviewed by Oliver Hunt.
999
1000         Turn on ENABLE_3D_CANVAS in TOT
1001         https://bugs.webkit.org/show_bug.cgi?id=29906
1002
1003         * Scripts/build-webkit:
1004
1005 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1006
1007         Rubberstamped by Simon Hausmann.
1008
1009         Enable HTTP tests for Qt
1010
1011         * Scripts/run-webkit-tests:
1012
1013 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
1014
1015         Reviewed by Dimitri Glazkov.
1016
1017         build-webkit --chromium now also works on cygwin.
1018
1019         https://bugs.webkit.org/show_bug.cgi?id=29973
1020
1021         * Scripts/webkitdirs.pm:
1022
1023 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
1024
1025         Reviewed by Simon Hausmann.
1026
1027         [Qt] Don't use TCmalloc in DumpRenderTree
1028         https://bugs.webkit.org/show_bug.cgi?id=27029
1029
1030         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
1031
1032         * DumpRenderTree/qt/DumpRenderTree.pro:
1033
1034 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
1035
1036         Reviewed by Simon Hausmann.
1037
1038         [Qt] Implement eventSender.scheduleAsynchronousClick().
1039
1040         https://bugs.webkit.org/show_bug.cgi?id=29931
1041
1042         * DumpRenderTree/qt/jsobjects.cpp:
1043         (EventSender::scheduleAsynchronousClick):
1044         * DumpRenderTree/qt/jsobjects.h:
1045
1046 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
1047
1048         Reviewed by Simon Hausmann.
1049
1050         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
1051         fast/events/open-window-from-another-frame.html from the Skipped list.
1052
1053         https://bugs.webkit.org/show_bug.cgi?id=29930
1054
1055         * DumpRenderTree/qt/jsobjects.cpp:
1056         (LayoutTestController::setPopupBlockingEnabled):
1057         * DumpRenderTree/qt/jsobjects.h:
1058
1059 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
1060
1061         Unreviewed.
1062
1063         Added myself to the list of committers.
1064
1065         * Scripts/modules/committers.py:
1066
1067 2009-09-30  Eric Seidel  <eric@webkit.org>
1068
1069         No review, just adding Geoff to the list of reviewers.
1070
1071         * Scripts/modules/committers.py:
1072
1073 2009-09-30  Dan Bernstein  <mitz@apple.com>
1074
1075         Reviewed by Sam Weinig.
1076
1077         Added the WebKit Layout Tests fonts that are referenced in
1078         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
1079
1080         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
1081         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
1082
1083 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1084
1085         Reviewed by David Kilzer.
1086
1087         Make sunspider scripts work on Windows platform.
1088         https://bugs.webkit.org/show_bug.cgi?id=29656
1089
1090         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
1091         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
1092         * Scripts/webkitdirs.pm: currentPerlPath() added.
1093
1094 2009-09-29  Brady Eidson  <beidson@apple.com>
1095
1096         Rubberstamped by Dan Bernstein.
1097
1098         Fix license and some sorting in new files.
1099
1100         * DumpRenderTree/mac/HistoryDelegate.h:
1101         * DumpRenderTree/mac/HistoryDelegate.mm:
1102
1103 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
1104
1105         Reviewed by David Kilzer.
1106
1107         Fixed how error codes are handled.
1108         https://bugs.webkit.org/show_bug.cgi?id=29898
1109
1110         * Scripts/update-webkit:
1111         * Scripts/update-webkit-chromium:
1112
1113 2009-09-29  Brady Eidson  <beidson@apple.com>
1114
1115         Reviewed by John Sullivan.
1116
1117         Updated way-out-of-date sorting throughout the dump methods/flags.
1118
1119         * DumpRenderTree/LayoutTestController.cpp:
1120         (LayoutTestController::LayoutTestController):
1121         (dumpAsPDFCallback):
1122         (dumpAsTextCallback):
1123         (dumpFrameLoadCallbacksCallback):
1124         (dumpResourceLoadCallbacksCallback):
1125         (LayoutTestController::staticFunctions):
1126
1127         * DumpRenderTree/LayoutTestController.h:
1128         (LayoutTestController::dumpAsText):
1129         (LayoutTestController::setDumpAsText):
1130         (LayoutTestController::dumpFrameLoadCallbacks):
1131         (LayoutTestController::setDumpFrameLoadCallbacks):
1132         (LayoutTestController::dumpSelectionRect):
1133         (LayoutTestController::setDumpSelectionRect):
1134         (LayoutTestController::dumpSourceAsWebArchive):
1135         (LayoutTestController::setDumpSourceAsWebArchive):
1136         (LayoutTestController::dumpStatusCallbacks):
1137         (LayoutTestController::setDumpStatusCallbacks):
1138         (LayoutTestController::dumpTitleChanges):
1139         (LayoutTestController::setDumpTitleChanges):
1140         (LayoutTestController::dumpWillCacheResponse):
1141         (LayoutTestController::setDumpWillCacheResponse):
1142
1143 2009-09-29  Brady Eidson  <beidson@apple.com>
1144
1145         Reviewed by John Sullivan.
1146
1147         WebKit Mac API should provide a delegate interface for global history.
1148         <rdar://problem/7042773> and https://webkit.org/b/29904
1149
1150         Adding the dumping of global history delegate callbacks.
1151
1152         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1153
1154         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
1155         * DumpRenderTree/mac/DumpRenderTree.mm:
1156         (createWebViewAndOffscreenWindow):
1157         (allocateGlobalControllers):
1158         (shouldLogFrameLoadDelegates):
1159         (shouldLogHistoryDelegates):
1160         (runTest):
1161
1162         Dump history delegate callbacks:
1163         * DumpRenderTree/mac/HistoryDelegate.h: Added.
1164         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
1165         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
1166         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
1167         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
1168
1169 2009-09-29  Daniel Bates  <dbates@webkit.org>
1170
1171         Reviewed by Adam Roben.
1172
1173         https://bugs.webkit.org/show_bug.cgi?id=28902
1174         
1175         Fixes an issue where the drop effect returned by Window Dump Render Tree 
1176         was always DROPEFFECT_NONE (since it was hard coded to do so).
1177         
1178         This patch corrects this issue by determining the actual drop effect 
1179         performed by the corresponding drag-and-drop operation so that we can 
1180         return it.
1181
1182         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
1183         (DraggingInfo::DraggingInfo):
1184         (DraggingInfo::performedDropEffect): Added method.
1185         (DraggingInfo::setPerformedDropEffect): Added method.
1186         * DumpRenderTree/win/EventSender.cpp:
1187         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
1188         Moved delete draggingInfo to UIDelegate::doDragDrop.
1189         * DumpRenderTree/win/UIDelegate.cpp:
1190         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
1191
1192 2009-09-29  Dan Bernstein  <mitz@apple.com>
1193
1194         Reviewed by Adam Roben.
1195
1196         Remove copying of unnecessary or nonexistent files from the ImageDiff
1197         post-build event.
1198
1199         * DumpRenderTree/win/ImageDiff.vcproj:
1200
1201 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1202
1203         Reviewed by David Kilzer.
1204
1205         [Qt] Make build-webkit script work on Windows
1206         https://bugs.webkit.org/show_bug.cgi?id=29802
1207
1208         * Scripts/run-webkit-tests:
1209         * Scripts/webkitdirs.pm:
1210          - Removed unnecessary -p switch for mkdir on Windows.
1211          - Use canonical path, which uses slashes or backslashes depends on platform.
1212          - isWindows() only test for Windows and not for Cyqwin.
1213
1214 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1215
1216         Reviewed by Simon Hausmann.
1217
1218         Fix time measurement in build-webkit after refactoring done in r48853.
1219
1220         * Scripts/build-webkit:
1221
1222 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1223
1224         Reviewed by Tor Arne Vestbø.
1225
1226         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
1227         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
1228
1229         * DumpRenderTree/qt/DumpRenderTree.cpp:
1230         (WebCore::WebPage::WebPage):
1231
1232 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
1233
1234         Reviewed by Simon Hausmann.
1235
1236         [Qt] Implement eventSender.contextClick().
1237         https://bugs.webkit.org/show_bug.cgi?id=29821
1238
1239         * DumpRenderTree/qt/jsobjects.cpp:
1240         (EventSender::contextClick):
1241         * DumpRenderTree/qt/jsobjects.h:
1242
1243 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1244
1245         Reviewed by Eric Seidel.
1246
1247         Add experimentalWebSocketsEnabled in WebPreferences.
1248         https://bugs.webkit.org/show_bug.cgi?id=28941
1249
1250         * DumpRenderTree/mac/DumpRenderTree.mm:
1251         (resetDefaultsToConsistentValues):
1252         * DumpRenderTree/win/DumpRenderTree.cpp:
1253         (resetDefaultsToConsistentValues):
1254
1255 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
1256
1257         Reviewed by David Kilzer.
1258
1259         Integrated chromium port building into webkit tools update-webkit and
1260         build-webkit.
1261
1262         https://bugs.webkit.org/show_bug.cgi?id=29749
1263
1264         * Scripts/build-webkit: When --chromium is specified, will build
1265           the chromium port (currently only Mac is supported).
1266         * Scripts/update-webkit: When --chromium is specified, delegates to
1267           update-webkit-chromium.
1268         * Scripts/webkitdirs.pm: Added chromium specific defs.
1269         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
1270           chromium port's dependencies and update its project files.
1271
1272 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1273
1274         Unreviewed.
1275
1276         Add myself to list of committers.
1277
1278         * Scripts/modules/committers.py:
1279
1280 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1281
1282         Reviewed by Darin Adler.
1283
1284         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
1285         https://bugs.webkit.org/show_bug.cgi?id=29771
1286
1287         * Scripts/run-webkit-tests:
1288
1289 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1290
1291         Reviewed by Simon Hausmann.
1292
1293         [Qt] Implement layoutTestController.waitForPolicyDelegate.
1294         https://bugs.webkit.org/show_bug.cgi?id=25037
1295
1296         * DumpRenderTree/qt/DumpRenderTree.cpp:
1297         (WebCore::WebPage::acceptNavigationRequest):
1298         * DumpRenderTree/qt/DumpRenderTree.pro:
1299         * DumpRenderTree/qt/jsobjects.cpp:
1300         (LayoutTestController::reset):
1301         (LayoutTestController::notifyDone):
1302         (LayoutTestController::waitForPolicyDelegate):
1303         * DumpRenderTree/qt/jsobjects.h:
1304         (LayoutTestController::waitForPolicy):
1305
1306 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1307
1308         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
1309
1310         Reviewed by Eric Seidel.
1311
1312         The -o|--open switch uses the open(1) command on Mac OS X to
1313         open the bug URL in the default web browser.  If there are
1314         similar mechanisms on other platforms, they may be added later.
1315
1316         * Scripts/mark-bug-fixed:
1317         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
1318         options.
1319         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
1320         code into main() and extracted prompting code into
1321         _prompt_user_for_correctness().
1322         (MarkBugFixed._open_bug_in_web_browser): Added.
1323         (MarkBugFixed._prompt_user_for_correctness): Added.
1324         (MarkBugFixed.main): Added logging code from
1325         _determine_bug_id_and_svn_revision().  Added code to call
1326         _open_bug_in_web_browser() if the switch is set.  Added code to
1327         call _prompt_user_for_correctness() when needed.
1328         * Scripts/modules/bugzilla.py:
1329         (Bugzilla.short_bug_url_for_bug_id): Added.
1330
1331 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1332
1333         svn-unapply and svn-apply don't work when used outside multiple svn working directories
1334
1335         <http://webkit.org/b/29744>
1336         <rdar://problem/7252905>
1337
1338         Reviewed by Eric Seidel.
1339
1340         Some users have a workflow where svn-create-patch, svn-apply and
1341         svn-unapply are used outside of multiple svn working
1342         directories.  Instead of aborting the scripts in these cases,
1343         print a warning and assume that Subversion is being used.
1344
1345         * Scripts/VCSUtils.pm:
1346         (determineVCSRoot): Call warn() instead of die() if both isGit()
1347         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
1348         to enforce the assumption about Subversion, then return
1349         determineSVNRoot().
1350         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
1351         VCSUtils.pm.  They both already cache their values and checking
1352         here is redundant since determineVCSRoot() is called later.
1353
1354 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
1355
1356         Reviewed by Gustavo Noronha.
1357
1358         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
1359         https://bugs.webkit.org/show_bug.cgi?id=29689
1360
1361         Load test fonts through FontConfig before each test.
1362         This ensures a more proper rendering of the tests.
1363
1364         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1365         (initializeFonts):
1366         (runTest):
1367         (main):
1368         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
1369         * GNUmakefile.am:
1370
1371 2009-09-25  David Kilzer  <ddkilzer@apple.com>
1372
1373         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
1374
1375         Reviewed by Eric Seidel.
1376
1377         * Scripts/mark-bug-fixed:
1378         (MarkBugFixed.__init__): Added -u|--update-only switch to list
1379         of parse options.
1380         (MarkBugFixed.main): When -u|--update-only is specified, add a
1381         comment to the bug without marking it Resolved/Fixed.
1382
1383 2009-09-25  Darin Adler  <darin@apple.com>
1384
1385         Reviewed by Geoffrey Garen.
1386
1387         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
1388         out, just as we do for the resources directory.
1389
1390 2009-09-25  Adam Barth  <abarth@webkit.org>
1391
1392         Unreviewed.  Added Tony to committers.py because he's a
1393         committer now.
1394
1395         * Scripts/modules/committers.py:
1396
1397 2009-09-25  Eric Seidel  <eric@webkit.org>
1398
1399         Reviewed by Simon Fraser.
1400
1401         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
1402         https://bugs.webkit.org/show_bug.cgi?id=28624
1403
1404         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
1405
1406         * DumpRenderTree/mac/DumpRenderTree.mm:
1407         (resetDefaultsToConsistentValues):
1408
1409 2009-09-25  Eric Seidel  <eric@webkit.org>
1410
1411         Reviewed by Adam Barth.
1412
1413         commit-queue should auto-retry patches which fail to commit due to out of date files
1414         https://bugs.webkit.org/show_bug.cgi?id=28316
1415
1416         * Scripts/bugzilla-tool:
1417          - Handle new CheckoutNeedsUpdate exception.
1418         * Scripts/modules/logging_unittest.py:
1419          - Call the ScriptError constructor correctly (this test had regressed).
1420         * Scripts/modules/scm.py:
1421          - Added the ability to define custom error handlers for run_command
1422            and added a commit_error_handler which throws CheckoutNeedsUpdate
1423            instead of ScriptError.
1424          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
1425         * Scripts/modules/scm_unittest.py:
1426          - Added tests of new error handlers.
1427
1428 2009-09-25  Eric Seidel  <eric@webkit.org>
1429
1430         Reviewed by Adam Barth.
1431
1432         commit-queue should give better feedback when failing a patch
1433         https://bugs.webkit.org/show_bug.cgi?id=29316
1434
1435         * Scripts/bugzilla-tool:
1436          - Update ScriptError uses to the new constructor format.
1437          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
1438            so that we can print to both stdout as well as an output buffer for error reporting.
1439          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
1440          - Use e.message_with_output() when failing a patch (this is the real fix here).
1441            I also removed use of "This patch will require manual commit." as that's not always true.
1442          - Add missing word "bug" from log message.
1443         * Scripts/modules/scm.py:
1444          - Make ScriptError save a bunch more data so that error messages can be nicer.
1445          - Update ScriptError callers.
1446
1447 2009-09-24  John Gregg  <johnnyg@google.com>
1448
1449         Reviewed by Eric Seidel.
1450
1451         Enable switch for notifications (experimental) in Page Settings
1452         https://bugs.webkit.org/show_bug.cgi?id=28930
1453
1454         Now that desktop notifications are controlled by run-time switch,
1455         set that switch to true for DumpRenderTree.
1456
1457         * DumpRenderTree/mac/DumpRenderTree.mm:
1458         (resetDefaultsToConsistentValues):
1459         * DumpRenderTree/win/DumpRenderTree.cpp:
1460         (resetDefaultsToConsistentValues):
1461         * DumpRenderTree/win/UIDelegate.cpp:
1462         (UIDelegate::QueryInterface):
1463
1464 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
1465
1466         wx build fix. SnowLeopard fixes for Mac dependencies.
1467
1468         * wx/build/build_utils.py:
1469         * wx/build/settings.py:
1470         * wx/install-unix-extras:
1471
1472 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1473
1474         Reviewed by Oliver Hunt.
1475
1476         Add support for DRT to send mouse wheel events.
1477
1478         https://bugs.webkit.org/show_bug.cgi?id=29348
1479         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
1480
1481         * DumpRenderTree/gtk/EventSender.cpp:
1482         (mouseWheelToCallback):
1483
1484 2009-09-17  Eric Seidel  <eric@webkit.org>
1485
1486         Reviewed by David Levin.
1487
1488         commit-queue needs web-based status reporting
1489         https://bugs.webkit.org/show_bug.cgi?id=29307
1490
1491         Add a first-pass web-based status for the commit-queue.
1492         The bot is currently reachable at:
1493         http://webkit-commit-queue.appspot.com/
1494
1495         * CommitQueueStatus/app.yaml: Added.
1496          - Application description file required by App Engine.
1497         * CommitQueueStatus/filters/__init__.py: Added.
1498          - Required by python to treat 'filters' as a module.
1499         * CommitQueueStatus/filters/webkit_extras.py: Added.
1500          - Support for turning 'bug 123' and 'patch 123' into links.
1501            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
1502         * CommitQueueStatus/index.html: Added.
1503         * CommitQueueStatus/index.yaml: Added.
1504          - Some auto-generated file from app engine.
1505         * CommitQueueStatus/queue_status.py: Added.
1506          - The core logic of this bot.  We could eventually split this file out into pieces.
1507         * CommitQueueStatus/stylesheets/main.css: Added.
1508          - Some basic lame-o CSS to make the page look less awful.
1509         * CommitQueueStatus/update_status.html: Added.
1510          - The form that the commit-queue (or a human) can use to update the status.
1511         * Scripts/bugzilla-tool:
1512          - Add some very basic update_status calls.
1513         * Scripts/modules/statusbot.py: Added.
1514          - Knows how to post to the CommitQueueStatus web application.
1515
1516 2009-09-24  David Kilzer  <ddkilzer@apple.com>
1517
1518         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
1519
1520         Reviewed by Adam Roben.
1521
1522         * Scripts/mark-bug-fixed:
1523         (MarkBugFixed.__init__): Added -m|--comment switch to list of
1524         parse options.
1525         (MarkBugFixed.main): When specified, prepend comment from
1526         -m|--comment command-line switch to the bug comment.
1527
1528 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1529
1530         Reviewed by Jan Alonzo.
1531
1532         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
1533         https://bugs.webkit.org/show_bug.cgi?id=29693
1534
1535         Show the window, to be able to synthesize events correctly.
1536
1537         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1538         (runTest):
1539         (main):
1540
1541 2009-09-24  Oliver Hunt  <oliver@apple.com>
1542
1543         Reviewed by NOBODY(rollout)
1544
1545         Roll out r48712 as it is incorrect.
1546
1547         * DumpRenderTree/mac/ObjCController.m:
1548         (+[ObjCController isSelectorExcludedFromWebScript:]):
1549         (+[ObjCController webScriptNameForSelector:]):
1550
1551 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
1552
1553         Reviewed by Eric Seidel.
1554
1555         https://bugs.webkit.org/show_bug.cgi?id=29005
1556         The indices of RuntimeArray should be enumerated like for a regular array.
1557
1558         * DumpRenderTree/mac/ObjCController.m:
1559         (+[ObjCController isSelectorExcludedFromWebScript:]):
1560         (+[ObjCController webScriptNameForSelector:]):
1561         (-[ObjCController arrayOfString]):
1562
1563 2009-09-23  David Kilzer  <ddkilzer@apple.com>
1564
1565         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
1566
1567         Reviewed by Darin Adler.
1568
1569         Also fixed a bug where specifying a revision on the command-line
1570         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
1571
1572         * Scripts/bugzilla-tool: Updated module import statements.
1573         (parse_bug_id): Removed.  Moved to bugzilla.py.
1574         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
1575         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
1576         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
1577         (BugzillaTool.__init__): Removed mark-fixed subcommand.
1578         * Scripts/mark-bug-fixed: Added.
1579         * Scripts/modules/bugzilla.py:
1580         (parse_bug_id): Added.  Moved from bugzilla-tool.
1581         * Scripts/modules/comments.py: Added.
1582         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
1583         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
1584
1585 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
1586
1587         Reviewed by Eric Seidel.
1588         
1589          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
1590          "false" in non-implemented stub for setAlwaysAcceptCookies.
1591          https://bugs.webkit.org/show_bug.cgi?id=29661
1592
1593         * DumpRenderTree/win/DumpRenderTree.vcproj:
1594         * DumpRenderTree/win/DumpRenderTree.cpp:
1595
1596 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1597
1598         Reviewed by Xan Lopez.
1599
1600         [GTK] need to dump number of pending unload handlers
1601         https://bugs.webkit.org/show_bug.cgi?id=29685
1602
1603         Implement dumping of the number of pending unload handlers.
1604
1605         The following tests will pass:
1606
1607           fast/loader/unload-form-about-blank.html
1608           fast/loader/unload-form-post-about-blank.html
1609           fast/loader/unload-form-post.html
1610           fast/loader/unload-form.html
1611           fast/loader/unload-hyperlink.html
1612           fast/loader/unload-javascript-url.html
1613           fast/loader/unload-reload.html
1614           fast/loader/unload-window-location.html
1615
1616         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1617         (getFrameNameSuitableForTestResult):
1618         (webViewLoadFinished):
1619
1620 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
1621
1622         Reviewed by Eric Seidel.
1623
1624         js tests should move into jstests subdirectory instead of resources/
1625         https://bugs.webkit.org/show_bug.cgi?id=25880
1626
1627         Remove support of resources directory.
1628
1629         * Scripts/make-script-test-wrappers:
1630
1631 2009-09-22  Eric Seidel  <eric@webkit.org>
1632
1633         No review, only fixing typo (missing space character).
1634
1635         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
1636
1637         * Scripts/run-webkit-tests:
1638
1639 2009-09-22  Eric Seidel  <eric@webkit.org>
1640
1641         Reviewed by Darin Adler.
1642
1643         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
1644         https://bugs.webkit.org/show_bug.cgi?id=29220
1645
1646         * Scripts/run-webkit-tests:
1647
1648 2009-09-22  Eric Seidel  <eric@webkit.org>
1649
1650         Reviewed by David Kilzer.
1651
1652         svn-apply can't handle single-line binary file additions
1653         https://bugs.webkit.org/show_bug.cgi?id=29100
1654
1655         Fixed the regexp and added a unit test.
1656
1657         * Scripts/modules/scm_unittest.py:
1658         * Scripts/svn-apply:
1659
1660 2009-09-11  Eric Seidel  <eric@webkit.org>
1661
1662         Reviewed by David Kilzer.
1663
1664         post-diff and post-commits should be able to find bug urls in ChangeLogs.
1665         https://bugs.webkit.org/show_bug.cgi?id=29206
1666
1667         * Scripts/bugzilla-tool:
1668          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
1669          - Rename --no-comment to --add-log-as-comment and reverse behavior.
1670            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
1671          - Split out code into helper functions to try and make execute() more legible.
1672          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
1673          - Fallback to bug urls in commit diffs, instead of just in commit messages,
1674            meaning post-commits will now find bug urls in ChangeLogs.
1675
1676 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1677
1678         Reviewed by Maciej Stachowiak.
1679
1680         --parse-only parameter wasn't passed to SunSpider/sunspider script.
1681         https://bugs.webkit.org/show_bug.cgi?id=29611
1682
1683         * Scripts/run-sunspider: Missing parameter passing added.
1684
1685 2009-09-20  David Kilzer  <ddkilzer@apple.com>
1686
1687         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
1688
1689         Reviewed by Mark Rowe.
1690
1691         The require statement is like the use statement, except that it
1692         is run during script execution instead of during the 'BEGIN'
1693         phase.  This makes it possible to change @INC before the require
1694         statement is run.  See 'require' and 'use' in the perlfunc(1)
1695         manpage and 'BEGIN' in perlmod(1) manpage.
1696
1697         * Scripts/run-webkit-tests: Replace eval statement with require
1698         statement.
1699
1700 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
1701
1702         wx build fixes. Fix the config name under git and allow users to specify
1703         their own waf install for experimenting with new versions.
1704
1705         * Scripts/webkitdirs.pm:
1706         * wx/build/settings.py:
1707
1708 2009-09-18  Alex Milowski  <alex@milowski.com>
1709
1710         Reviewed by Maciej Stachowiak.
1711
1712         Added checkWebCoreMathMLSupport and hasMathMLSupport to support 
1713         checking for whether MathML tests should be run
1714
1715         * Scripts/run-webkit-tests:
1716         * Scripts/webkitdirs.pm:
1717
1718 2009-08-28  Darin Adler  <darin@apple.com>
1719
1720         Reviewed by Mark Rowe.
1721
1722         Break more of run-webkit-tests into separate functions
1723         https://bugs.webkit.org/show_bug.cgi?id=29497
1724
1725         Some small steps toward improving run-webkit-tests. My goal is to
1726         refactor much more of the script into functions. Later we can add
1727         parallel test running to the tool. But better structure may help
1728         even if someone decides to translate this into another scripting
1729         language instead.
1730
1731         * Scripts/run-webkit-tests: Break more pieces of the script into
1732         seprate functions. Added readSkippedFiles, findTestsToRun, and
1733         printResults functions. Removed custom code to skip results.html
1734         and instead just put it into the ignoredFiles hash. Fixed some
1735         indentation. Sorted function declarations, global variables,
1736         and options at the top of the file alphabetically so they're not
1737         in a semi-random order.
1738
1739 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
1740
1741         wx build fix, add missing dependency.
1742
1743         * wx/browser/wscript:
1744
1745 2009-09-16  Mark Rowe  <mrowe@apple.com>
1746
1747         Split the SnowLeopard build across a few machines.
1748
1749         * BuildSlaveSupport/build.webkit.org-config/config.json:
1750
1751 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
1752
1753         wx build fix to support monolithic builds on Windows.
1754
1755         * wx/build/wxpresets.py:
1756
1757 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
1758
1759         wx build fix, improve debug support and 2.9 support on MSW.
1760
1761         * wx/build/settings.py:
1762         * wx/build/wxpresets.py:
1763
1764 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1765
1766         Blind try at fixing new test failure on Windows.
1767
1768         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1769         (FrameLoadDelegate::didReceiveTitle):
1770
1771 2009-09-15  Alex Milowski  <alex@milowski.com>
1772
1773         Reviewed by Tor Arne Vestbø.
1774
1775         Added mathml toggle
1776
1777         * Scripts/build-webkit:
1778
1779 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
1780
1781         wx build fix. Allow waf build to support Python < 2.6.
1782
1783         * wx/build/waf_extensions.py:
1784
1785 2009-09-14  Chris Marrin  <cmarrin@apple.com>
1786
1787         Reviewed by Oliver Hunt.
1788
1789         Add LayoutTests infrastructure to enable and disable webgl tests.
1790         https://bugs.webkit.org/show_bug.cgi?id=29254
1791
1792         * Scripts/run-webkit-tests:
1793         * Scripts/webkitdirs.pm:
1794
1795 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
1796
1797         Reviewed by Darin Adler.
1798         
1799         Add --iterations option to run-webkit-tests to repeat the tests N times
1800         https://bugs.webkit.org/show_bug.cgi?id=29263
1801
1802         When run with --iterations N, run-webkit-tests will repeat the tests N times.
1803
1804         * Scripts/run-webkit-tests:
1805
1806 2009-09-14  Brady Eidson  <beidson@apple.com>
1807
1808         Not reviewed, maybe should've been:
1809
1810         Cleaning up more Windows-specific fallout from the fix for:
1811         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
1812
1813         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1814         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter, 
1815           and call the correct method to get the Sender.
1816
1817 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
1818
1819         GTK build fix.
1820
1821         Unreviewed.
1822
1823         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1824         (AccessibilityController::setLogScrollingStartEvents):
1825
1826 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
1827
1828         DRT/test part of
1829         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
1830         jumping to a named anchor
1831
1832         https://bugs.webkit.org/show_bug.cgi?id=28899
1833
1834         Reviewed by Adam Roben.
1835
1836         * DumpRenderTree/AccessibilityController.cpp:
1837         (logScrollingStartEventsCallback):
1838         Turn on logging of scrolling start events.
1839         (AccessibilityController::getJSClass):
1840         Add a "logScrollingStartEvents" to the AccessibilityController's JS
1841         class definition.
1842         (AccessibilityController::resetToConsistentState):
1843         Turn off logging of scrolling start events.
1844
1845         * DumpRenderTree/AccessibilityController.h:
1846         Declare setLogScrollingStartEvents(). Add a member for the scrolling
1847         start event hook.
1848
1849         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
1850         (AccessibilityController::setLogScrollingStartEvents):
1851         Stubbed.
1852
1853         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1854         (AccessibilityController::AccessibilityController):
1855         Initialize the handle to 0.
1856         (logEventProc):
1857         Renamed from logFocusEventProc; now logs scrolling start events, too.
1858         Removed the assertion that the event is a focus event. Added a switch
1859         to print a message for focus, scrolling start, and other, unknown
1860         events.
1861         (AccessibilityController::setLogFocusEvents):
1862         Changed to use logEventProc.
1863         (AccessibilityController::setLogScrollingStartEvents):
1864         If turning logging off, unhook the scrolling start event hook, and clear
1865         the member holding the handle. If turning on, query for the root
1866         accessible, so that accessibility is enabled for the WebView, and call
1867         SetWinEventHook to setup an event hook using logEventProc as the
1868         callback function.
1869
1870 2009-09-14  Brady Eidson  <beidson@apple.com>
1871
1872         Windows build fix.
1873
1874         * DumpRenderTree/LayoutTestController.cpp:
1875         (setAuthenticationPasswordCallback):
1876         (setAuthenticationUsernameCallback):
1877         
1878         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1879         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1880
1881 2009-09-14  Brady Eidson  <beidson@apple.com>
1882
1883         Reviewed by Alexey Proskuryakov.
1884
1885         Safari 4 cannot be used to update firmware on Linksys routers.
1886         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
1887
1888         Add the ability for DRT to handle authentication challenges.
1889
1890         * DumpRenderTree/LayoutTestController.cpp:
1891         (setAuthenticationPasswordCallback):
1892         (setAuthenticationUsernameCallback):
1893         (setHandlesAuthenticationChallengesCallback):
1894         (LayoutTestController::staticFunctions):
1895
1896         * DumpRenderTree/LayoutTestController.h:
1897         (LayoutTestController::handlesAuthenticationChallenges):
1898         (LayoutTestController::setHandlesAuthenticationChallenges):
1899         (LayoutTestController::authenticationUsername):
1900         (LayoutTestController::setAuthenticationUsername):
1901         (LayoutTestController::authenticationPassword):
1902         (LayoutTestController::setAuthenticationPassword):
1903
1904         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1905         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1906
1907         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1908         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1909         * DumpRenderTree/win/ResourceLoadDelegate.h:
1910
1911 2009-09-12  Mark Rowe  <mrowe@apple.com>
1912
1913         Reviewed by Dan Bernstein.
1914
1915         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
1916
1917         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
1918         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
1919
1920         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1921         (NPP_New):
1922
1923 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
1924
1925         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
1926
1927         * wx/build/build_utils.py:
1928         * wx/build/settings.py:
1929
1930 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1931
1932         Reviewed by Tor Arne Vestbø.
1933
1934         [Qt] Build fix for windows build.
1935
1936         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
1937
1938 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
1939
1940         Fix typo accidently landed in last commit.
1941
1942         * wx/build/settings.py:
1943
1944 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
1945
1946         wx build fix, error out if using the wrong Python.
1947
1948         * wx/build/settings.py:
1949
1950 2009-09-13  Xan Lopez  <xlopez@igalia.com>
1951
1952         Build fix for GTK+ < 2.14.
1953
1954         Do not use gtk_widget_get_window, access the window directly
1955         through the struct.
1956
1957         * DumpRenderTree/gtk/EventSender.cpp:
1958         (contextClickCallback):
1959         (mouseDownCallback):
1960         (mouseUpCallback):
1961         (mouseMoveToCallback):
1962         (keyDownCallback):
1963
1964 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
1965
1966         Reviewed by Xan Lopez and Jan Alonzo.
1967
1968         [GTK] EventSender does not set 'window' property on synthesized GDK events
1969         https://bugs.webkit.org/show_bug.cgi?id=29169
1970
1971         Set the window property on synthesized GDK events in the GTK+ EventSender.
1972
1973         * DumpRenderTree/gtk/EventSender.cpp:
1974         (contextClickCallback):
1975         (mouseDownCallback):
1976         (mouseUpCallback):
1977         (mouseMoveToCallback):
1978         (keyDownCallback):
1979
1980 2009-09-12  Drew Wilson  <atwilson@google.com>
1981
1982         Reviewed by Mark Rowe.
1983
1984         run-webkit-tests has a timeout value that is too low
1985         https://bugs.webkit.org/show_bug.cgi?id=29223
1986
1987         * Scripts/run-webkit-tests:
1988         Changed timeout value to 20 seconds to avoid timing out too early.
1989
1990 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
1991
1992         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
1993         architectures are supported for building wxWebKit.
1994
1995         * wx/build/settings.py:
1996
1997 2009-09-11  Eric Seidel  <eric@webkit.org>
1998
1999         Reviewed by David Levin.
2000
2001         bugzilla-tool rollout threw exception under svn
2002         https://bugs.webkit.org/show_bug.cgi?id=29211
2003
2004         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
2005         * Scripts/modules/scm_unittest.py: add testing for this fix.
2006
2007 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
2008
2009         Add myself to the committers list.
2010
2011         * Scripts/modules/committers.py:
2012
2013 2009-09-11  Eric Seidel  <eric@webkit.org>
2014
2015         Reviewed by Adam Barth.
2016
2017         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
2018         https://bugs.webkit.org/show_bug.cgi?id=29201
2019
2020         * Scripts/bugzilla-tool:
2021
2022 2009-09-11  Adam Roben  <aroben@apple.com>
2023
2024         Make commit-log-editor move common prefixes to the top of the log
2025
2026         Fies <http://webkit.org/b/29190> commit-log-editor should move common
2027         prefixes to the top of the commit log
2028
2029         Reviewed by Darin Adler.
2030
2031         * Scripts/commit-log-editor: Find and remove the longest common prefix
2032         ending in a double newline from each ChangeLog entry, then put that
2033         common prefix at the top of the commit log.
2034         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
2035         removes, and returns the longest common prefix ending in a double
2036         newline from a hash of strings
2037
2038 2009-09-11  Eric Seidel  <eric@webkit.org>
2039
2040         Fix obvious typo in previous commit, no review.
2041
2042         bugzilla-tool should automate rollouts
2043         https://bugs.webkit.org/show_bug.cgi?id=26715
2044
2045         * Scripts/bugzilla-tool: add back missing "scm" argument.
2046
2047 2009-09-11  Eric Seidel  <eric@webkit.org>
2048
2049         Reviewed by Adam Barth.
2050
2051         bugzilla-tool should automate rollouts
2052         https://bugs.webkit.org/show_bug.cgi?id=26715
2053
2054         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
2055         The --complete-rollout option will automatically land and update the bug.
2056         Eventually --complete-rollout will be default, but that will require more testing.
2057
2058         This first pass is good enough for others to try and file bugs about.
2059
2060         * Scripts/bugzilla-tool:
2061          - Move modified_changelogs into scm.py.
2062          - Move svn_revision_from_commit_text logic into scm.py.
2063          - Add RolloutCommit command.
2064         * Scripts/modules/bugzilla.py:
2065          - Add reopen_bug command used by RolloutCommit.
2066         * Scripts/modules/scm.py:
2067          - Add functions to support RolloutCommit.
2068          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
2069          - Add a str() call so that svn_commit_log can take a numeric argument.
2070          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
2071          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
2072         * Scripts/modules/scm_unittest.py:
2073          - Add read_from_path for easy file reading.
2074          - Put test4 on a new line to make reverts work w/o conflict.
2075          - Add an "svn update" call so that the checkout revision matches the server revision.
2076          - Add tests for svn_revision_from_commit_text.
2077          - Add a simple test for apply_reverse_diff.
2078          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
2079          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
2080
2081 2009-09-11  Adam Roben  <aroben@apple.com>
2082
2083         Get user script/stylesheet tests running on Windows
2084
2085         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
2086         skipped on Windows
2087
2088         Reviewed by John Sullivan.
2089
2090         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
2091         against comsuppw.lib so we can use _bstr_t.
2092
2093         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
2094         order, added #include of comutil.h for _bstr_t.
2095
2096         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
2097         (LayoutTestController::addUserScript):
2098         (LayoutTestController::addUserStyleSheet):
2099         Implemented. Implementations were based on those in
2100         LayoutTestControllerMac.mm.
2101
2102 2009-09-10  David Kilzer  <ddkilzer@apple.com>
2103
2104         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help 
2105
2106         Reviewed by Mark Rowe.
2107
2108         * Scripts/run-webkit-tests: Updated to make -h switch show help.
2109
2110 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
2111
2112         Reviewed by Alexey Proskuryakov.
2113
2114         Add WebCore/websockets directory in wx build system.
2115         https://bugs.webkit.org/show_bug.cgi?id=28038
2116
2117         * wx/build/settings.py:
2118
2119 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
2120
2121         [GTK] EventSender does not properly convert some keyDown strings
2122         https://bugs.webkit.org/show_bug.cgi?id=29119
2123
2124         Add more keyDown string to character code conversions for GTK+ EventSender.
2125
2126         * DumpRenderTree/gtk/EventSender.cpp:
2127         (keyDownCallback):
2128
2129 2009-09-09  Steve Block  <steveblock@google.com>
2130
2131         Reviewed by Maciej Stachowiak.
2132
2133         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
2134         https://bugs.webkit.org/show_bug.cgi?id=29080
2135
2136         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
2137
2138 2009-09-09  Eric Seidel  <eric@webkit.org>
2139
2140         Reviewed by Eric Carlson.
2141
2142         reviewer/committer lookups are backwards
2143         https://bugs.webkit.org/show_bug.cgi?id=29113
2144
2145         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
2146
2147         * Scripts/modules/bugzilla.py:
2148         * Scripts/modules/committers.py:
2149
2150 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2151
2152         Reviewed by Eric Seidel.
2153
2154         svn-unapply doesn't revert directories correctly
2155         https://bugs.webkit.org/show_bug.cgi?id=29065
2156
2157         * Scripts/svn-unapply: Make svnStatus consistently return status
2158         lines including a newline.
2159         * Scripts/svn-apply: Keep svnStatus in sync with the one in
2160         svn-unapply, in lieu of moving it to a common file.
2161
2162 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2163
2164         Reviewed by Eric Seidel.
2165
2166         svn-apply doesn't handle changes to files copied to new directories properly
2167         https://bugs.webkit.org/show_bug.cgi?id=29059
2168
2169         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
2170         additions if we know that we've just copied a file to this name.
2171
2172 2009-09-09  Eric Seidel  <eric@webkit.org>
2173
2174         Reviewed by David Levin.
2175
2176         commit-queue hangs if a builder has never built
2177         https://bugs.webkit.org/show_bug.cgi?id=29091
2178
2179         * Scripts/modules/buildbot.py:
2180         * Scripts/modules/buildbot_unittest.py:
2181
2182 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
2183
2184         Reviewed by Gustavo Noronha.
2185
2186         [GTK] DumpRenderTree needs eventSender object and implementation
2187         https://bugs.webkit.org/show_bug.cgi?id=25990
2188
2189         Implements most of the EventSender object's functionality for
2190         the DumpRenderTree tool. Implementation still lacks support
2191         for drag and drop tests and forward leaps.
2192
2193         Based on work by Holger Hans Peter Freyther.
2194
2195         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2196         (runTest): Focus on the view before loading a new test.
2197         (webViewWindowObjectCleared):
2198         * DumpRenderTree/gtk/EventSender.cpp: Added.
2199         (getDragModeCallback):
2200         (setDragModeCallback):
2201         (leapForwardCallback):
2202         (contextClickCallback):
2203         (updateClickCount):
2204         (mouseDownCallback):
2205         (mouseUpCallback):
2206         (mouseMoveToCallback):
2207         (beginDragWithFilesCallback):
2208         (replaySavedEvents):
2209         (keyDownCallback):
2210         (textZoomInCallback):
2211         (textZoomOutCallback):
2212         (zoomPageInCallback):
2213         (zoomPageOutCallback):
2214         (getClass):
2215         (makeEventSender):
2216         * DumpRenderTree/gtk/EventSender.h: Added.
2217         * GNUmakefile.am: Add build rules for EventSender.
2218
2219 2009-09-09  Daniel Bates  <dbates@webkit.org>
2220
2221         Reviewed by Adam Roben.
2222         
2223         https://bugs.webkit.org/show_bug.cgi?id=28953
2224
2225         Added pre- and post- build events so that on build failure, the file 
2226         buildfailed is written to the directory $(WebKitOutputDir).
2227
2228         * WinLauncher/WinLauncher.vcproj:
2229
2230 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2231
2232         Unreviewed.
2233
2234         Add myself to list of committers.
2235
2236         * Scripts/modules/committers.py:
2237
2238 2009-09-08  Eric Seidel  <eric@webkit.org>
2239
2240         Reviewed by David Levin.
2241
2242         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
2243         https://bugs.webkit.org/show_bug.cgi?id=28605
2244         https://bugs.webkit.org/show_bug.cgi?id=28916
2245
2246         * Scripts/bugzilla-tool:
2247          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
2248            comment now that it's used for rejecting patches for invalid committers too.
2249          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
2250          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
2251         * Scripts/modules/bugzilla.py:
2252          - Make _parse_attachment_element not validate reviewer/committer.
2253          - Share flag parsing code in _parse_attachment_flag.
2254          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
2255          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
2256          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
2257         * Scripts/modules/bugzilla_unittest.py:
2258          - Update this test to no longer expect committer/reviewer validation.
2259         * Scripts/modules/committers.py:
2260          - Return None on failed lookups instead of raising Exceptions.
2261         * Scripts/modules/committers_unittest.py:
2262          - Update tests to expect None returns instead of exceptions.
2263
2264 2009-09-09  David Kilzer  <ddkilzer@apple.com>
2265
2266         <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
2267
2268         Reviewed by Mark Rowe.
2269
2270         No change to layout test results.
2271
2272         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2273         (AccessibilityUIElement::clickPointY): Changed to return y value
2274         instead of x value.
2275
2276 2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>
2277
2278         Reviewed by Mark Rowe.
2279
2280         Reduce dglazkov's boboiness by properly concatenating revision value.
2281
2282         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
2283             rather than "+".
2284
2285 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2286
2287         wxWebKit Python extension build fix - get swig.py if it doesn't exist.
2288
2289         * wx/build/build_utils.py:
2290
2291 2009-09-08  Mark Rowe  <mrowe@apple.com>
2292
2293         Fix an incorrect variable name in UpdateChromiumSource.
2294
2295         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2296
2297 2009-09-08  Mark Rowe  <mrowe@apple.com>
2298
2299         Don't check for leaks on the release SnowLeopard builder.
2300
2301         * BuildSlaveSupport/build.webkit.org-config/config.json:
2302
2303 2009-09-08  Mark Rowe  <mrowe@apple.com>
2304
2305         Add a SnowLeopard release builder.
2306
2307         * BuildSlaveSupport/build.webkit.org-config/config.json:
2308
2309 2009-09-08  David Levin  <levin@chromium.org>
2310
2311         Reviewed by Darin Adler.
2312
2313         Remove end of line whitespace check from check-webkit-style.
2314         https://bugs.webkit.org/show_bug.cgi?id=29053
2315
2316         * Scripts/modules/cpp_style.py:
2317
2318 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2319
2320         Reviewed by Darin Adler.
2321
2322         Fix DumpRenderTree build from clean tree on Tiger
2323         https://bugs.webkit.org/show_bug.cgi?id=28927
2324
2325         * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
2326         DerivedSources/DumpRenderTree directory exists when
2327         building on Tiger.
2328
2329 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2330
2331         wx build fix after introduction of platform/mock directory.
2332
2333         * wx/build/settings.py:
2334
2335 2009-09-08  Yael Aharon  <yael.aharon@nokia.com>
2336
2337         Unreviewed.
2338
2339         Add myself to list of committers.
2340
2341         * Scripts/modules/committers.py:
2342
2343 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2344
2345         Unreviewed.
2346
2347         Add myself to list of committers.
2348
2349         * Scripts/modules/committers.py:
2350
2351 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2352
2353         Reviewed by Darin Adler.
2354
2355         prepare-ChangeLog too chatty on file additions
2356         https://bugs.webkit.org/show_bug.cgi?id=29019
2357
2358         * Scripts/prepare-ChangeLog: Omit description of added properties
2359         on newly added files.
2360
2361 2009-09-08  Steve Block  <steveblock@google.com>
2362
2363         Reviewed by Adam Barth.
2364
2365         Adds a LayoutTestController method to set the permission state for Geolocation.
2366         This is required to use the mock Geolocation service for testing.
2367         https://bugs.webkit.org/show_bug.cgi?id=29027
2368
2369         * DumpRenderTree/LayoutTestController.cpp: Modified.
2370         (setDatabaseQuotaCallback): Modified. Style fix.
2371         (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
2372         (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
2373         * DumpRenderTree/LayoutTestController.h: Modified.
2374         (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
2375         (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
2376         (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
2377         * DumpRenderTree/mac/UIDelegate.mm: Modified.
2378         (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
2379
2380 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2381
2382         Reviewed by Simon Hausmann.
2383
2384         [Qt] QtWebKit single API to enable persistency
2385         https://bugs.webkit.org/show_bug.cgi?id=28682
2386
2387         Use the new enablePersistentStorage API instead 
2388         of enabling all persistent features one-by-one.
2389
2390         * DumpRenderTree/qt/DumpRenderTree.cpp:
2391         (WebCore::WebPage::WebPage):
2392         (WebCore::DumpRenderTree::DumpRenderTree):
2393
2394 2009-09-07  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2395
2396         Reviewed by Tor Arne Vestbø.
2397
2398         Refactor --strict switch to --ignore-metrics and correct the
2399         implementation to make the feature usable on all platforms.
2400         https://bugs.webkit.org/show_bug.cgi?id=28907
2401
2402         run-webkit-tests --ignore-metrics strips the font related metrics from
2403         the actual and expected data before comparing them.
2404         In this way the render trees can be checked for obvious differences but
2405         a successful test implies by no means that the layout is actually correct.
2406
2407         * Scripts/run-webkit-tests:
2408
2409 2009-09-07  Steve Block  <steveblock@google.com>
2410
2411         Reviewed by Adam Barth.
2412
2413         Adds a mock Geolocation service. This will be used to provide predictable behavior of the
2414         Geolocation API for use in LayoutTests. Later changes will integrate the the mock
2415         Geolocation service with DumpRenderTree.
2416         https://bugs.webkit.org/show_bug.cgi?id=28264
2417
2418         * DumpRenderTree/LayoutTestController.cpp: Modified.
2419         (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
2420         (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
2421         (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
2422         * DumpRenderTree/LayoutTestController.h: Modified.
2423         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
2424         (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
2425         (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
2426
2427 2009-09-07  Drew Wilson  <atwilson@google.com>
2428
2429         Reviewed by David Levin.
2430
2431         Enable SHARED_WORKERS by default
2432         https://bugs.webkit.org/show_bug.cgi?id=28959
2433
2434         * Scripts/build-webkit:
2435
2436 2009-09-07  Kevin Ollivier  <kevino@theolliviers.com>
2437
2438         wx build fixes for wx SVN trunk.
2439
2440         * wx/build/settings.py:
2441
2442 2009-09-04  Kevin Ollivier  <kevino@theolliviers.com>
2443
2444         wx build fix. Switch USE_ defines over to the compiler so that they can be
2445         checked by files not including config.h (like WebCorePrefix.h).
2446
2447         * wx/build/settings.py:
2448
2449 2009-09-04  Adam Barth  <abarth@webkit.org>
2450
2451         Unreviewed build fix.
2452
2453         Update declaration of FrameLoadDelegate to reflect that
2454         IWebFrameLoadDelegatePrivate2 inherits from
2455         IWebFrameLoadDelegatePrivate.
2456
2457         * DumpRenderTree/win/FrameLoadDelegate.h:
2458
2459 2009-09-04  Adam Barth  <abarth@webkit.org>
2460
2461         Reviewed by Eric Seidel.
2462
2463         https://bugs.webkit.org/show_bug.cgi?id=24696
2464
2465         Add testing instrumentation for mixed content.
2466
2467         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2468         (-[FrameLoadDelegate webView:]):
2469         (-[FrameLoadDelegate webView:didRunInsecureContent:]):
2470         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2471         (descriptionSuitableForTestResult):
2472         (FrameLoadDelegate::QueryInterface):
2473         (FrameLoadDelegate::didDisplayInsecureContent):
2474         (FrameLoadDelegate::didRunInsecureContent):
2475         * DumpRenderTree/win/FrameLoadDelegate.h:
2476
2477 2009-09-03  Kevin Watters  <kevinwatters@gmail.com>
2478
2479         Reviewed by Kevin Ollivier.
2480
2481         [wx] Frames support
2482         https://bugs.webkit.org/show_bug.cgi?id=19041
2483
2484         * wx/build-wxwebkit:
2485
2486 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2487
2488         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
2489
2490         Reviewed by Eric Seidel.
2491
2492         This fixes "svn-apply --force" and adds unit tests for the
2493         scm.apply_patch() method which uses this script.
2494
2495         * Scripts/svn-apply: Created $globalExitCode variable that
2496         defaults to 0.  Exit with a value of $globalExitCode when the
2497         script is finished.
2498         (applyPatch): Ignore a non-zero $exitCode if $force is true, but
2499         set $globalExitCode to $exitCode so that svn-apply exits with a
2500         non-zero status if any patches did not apply cleanly.  Also
2501         print out the actual patch command if $force was not true.
2502
2503         * Scripts/modules/scm.py:
2504         (scripts_directory): Added.  Extracted from script_path().
2505         (script_path): Extracted scripts_directory().
2506         * Scripts/modules/scm_unittest.py: Import urllib.
2507         (SVNTestRepository.setup): Save the original working directory
2508         in test_object since this represents the WebKit repository from
2509         where the unit tests are run.
2510         (SCMTest): Created new super class to hold utility methods.
2511         (SCMTest._create_patch): Creates a patch file on disk and a
2512         dictionary for use with scm.svn_apply().
2513         (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink
2514         back to WebKitTools/Scripts in the test repository so that
2515         scm.apply_patch() is able to find the svn-apply script.
2516         (SVNTest): Inherit from SCMTest instead of unittest.TestCase.
2517         (SVNTest.tearDown): Make sure to change directories back to the
2518         original_path before the next test.
2519         (SVNTest.test_apply_svn_patch): New test case for applying an
2520         svn patch with scm.apply_patch().
2521         (SVNTest.test_apply_svn_patch_force): New test case for applying
2522         an svn patch with scm.apply_patch() that conflicts.
2523         (GitTest): Inherit from SCMTest instead of unittest.TestCase.
2524         (GitTest.tearDown): Make sure to change directories back to the
2525         original_path before the next test.
2526         (GitTest.test_apply_git_patch): New test case for applying a git
2527         patch with scm.apply_patch().
2528         (GitTest.test_apply_git_patch_force): New test case for applying
2529         a git patch with scm.apply_patch() that conflicts.
2530
2531 2009-09-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2532
2533         Reviewed by Mark Rowe.
2534
2535         [Qt] Add support for platform-spesific layout-test results
2536
2537         For the Qt port we use the qt-[mac|linux|win] directories and then fall
2538         back to the generic qt directory for both test results and skipped list.
2539
2540         * Scripts/run-webkit-tests:
2541         * Scripts/webkitdirs.pm:
2542
2543 2009-09-02  Laurent Cerveau  <lcerveau@me.com>
2544
2545         Reviewed by David Kilzer.
2546
2547         <http://webkit.org/b/25517> build-webkit script should print build time at end
2548
2549         * Scripts/build-webkit:
2550         Added startTime and endTime variable so that the build time is computed and printed as
2551         part of the build message; display formatting has been separated in a dedicated subroutine.
2552
2553 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2554
2555         <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root
2556
2557         Reviewed by Eric Seidel.
2558
2559         * Scripts/VCSUtils.pm:
2560         (determineSvnRoot): Added back check for repository root that
2561         was removed in r46134 when this code lived in svn-create-patch.
2562         It's necessary to check both the repository root and the
2563         repository UUID in case two different working directories are
2564         checked out from the same repository.
2565
2566 2009-09-02  Timothy Hatcher  <timothy@apple.com>
2567
2568         Use new 512x512 icons for nightly builds.
2569
2570         Rubber-stamped by Mark Rowe.
2571
2572         * WebKitLauncher/webkit.icns:
2573
2574 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
2575
2576         waf build fix. Remove local variable shadowing global.
2577
2578         * wx/build/settings.py:
2579
2580 2009-09-02  Zan Dobersek  <zandobersek@gmail.com>
2581
2582         Reviewed by David Kilzer.
2583
2584         Calls exitStatus function from the main package where it is also defined.
2585
2586         * Scripts/VCSUtils.pm:
2587
2588 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
2589
2590         waf build fixes for Windows/MSVC and Mac/Snow Leopard.
2591
2592         * wx/browser/wscript:
2593         * wx/build/build_utils.py:
2594         * wx/build/settings.py:
2595
2596 2009-08-10  Kevin Ollivier  <kevino@theolliviers.com>
2597
2598         Reviewed by Eric Seidel.
2599
2600         Changes needed for build-webkit to support the waf build system for the wx port.
2601         
2602         https://bugs.webkit.org/show_bug.cgi?id=27619
2603
2604         * Scripts/build-webkit:
2605         * Scripts/run-launcher:
2606         * Scripts/webkitdirs.pm:
2607
2608 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2609
2610         <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts
2611
2612         Reviewed by Eric Seidel.
2613
2614         * Scripts/update-webkit: Added "--accept postpone" to
2615         @svnOptions when running with svn-1.6 or newer.
2616
2617 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2618
2619         Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()
2620
2621         Reviewed by Eric Seidel.
2622
2623         * Scripts/VCSUtils.pm:
2624         (@EXPORT): Added &isSVNVersion16OrNewer.
2625         (svnVersion): Added.  Internal method that gets the SVN version
2626         and caches it.
2627         (isSVNVersion16OrNewer): Added.  Method that does the SVN 1.6
2628         version check.
2629         * Scripts/prepare-ChangeLog: Switched to use new
2630         isSVNVersion16OrNewer() method.
2631         * Scripts/resolve-ChangeLogs: Ditto.
2632         * Scripts/svn-create-patch: Ditto.
2633
2634 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2635
2636         Clean up VCSUtils.pm
2637
2638         Reviewed by Eric Seidel.
2639
2640         * Scripts/VCSUtils.pm: Added proper package statement.  Fixed
2641         indentation of BEGIN block.  Listed each exported method on a
2642         line by itself.  Added methods to the export list after adding
2643         the package statement.  Sorted module variables.  Moved
2644         definiton of $gitRoot next to other module variables.
2645
2646 2009-09-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2647
2648         Rubber-stamped by Simon Hausmann.
2649
2650         [Qt] Fix layout-test plugins/plugin-javascript-access.html
2651
2652         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2653
2654 2009-09-02  Shinichiro Hamaji  <hamaji@chromium.org>
2655
2656         Reviewed by Eric Seidel.
2657
2658         js tests should move into jstests subdirectory instead of resources/
2659         https://bugs.webkit.org/show_bug.cgi?id=25880
2660
2661         make-script-wrappers supports both resources and script-tests directories.
2662         run-webkit-tests ignores files in script-tests.
2663         Move script tests of animations to check the new script is working.
2664
2665         * Scripts/make-script-test-wrappers:
2666         * Scripts/run-webkit-tests:
2667
2668 2009-09-02  Szabo Carol  <carol.szabo@nokia.com>
2669
2670         Reviewed by David Levin.
2671
2672         check-webkit-style uses python from /usr/bin instead of the PATH
2673         https://bugs.webkit.org/show_bug.cgi?id=28225
2674
2675         * Scripts/bugzilla-tool:
2676         * Scripts/check-webkit-style:
2677         * Scripts/run-webkit-unittests:
2678         * Scripts/update-sources-list.py:
2679           Changed the first line from
2680           #!/usr/bin/python
2681           to
2682           #!/usr/bin/env python
2683           which causes python to be invoked from the path location returned
2684           by "which python" when any of these scripts are launched.
2685           these are currently all the python scripts in WebKitTools/Scripts.
2686
2687 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2688
2689         <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards
2690
2691         Reviewed by Adam Barth.
2692
2693         * Scripts/modules/scm.py:
2694         (Git.commit_ids_from_commitish_arguments): Reverse the list of
2695         commits returned from git-rev-list since we always want to post
2696         the oldest patches first to bugs.webkit.org.
2697         * Scripts/modules/scm_unittest.py:
2698         (run): Added return statement to return the output now that we
2699         want it sometimes.
2700         (SVNTestRepository._setup_test_commits): Added a fourth commit
2701         so the GitTest.test_commitish_order() test has more commits to
2702         work with.
2703         (GitTest.test_commitish_order): Added unit test for change to
2704         Git.commit_ids_from_commitish_arguments() in scm.py.
2705
2706 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2707
2708         <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed
2709
2710         Reviewed by David Levin.
2711
2712         The mark-fixed subcommand is for those times when you don't use
2713         bugzilla-tool to commit a patch, but you want to use it to close
2714         the bug with a committed-revision message.
2715
2716         * Scripts/bugzilla-tool:
2717         (bug_comment_from_svn_revision): Added.  Extracted from
2718         bug_comment_from_commit_text().
2719         (bug_comment_from_commit_text): Extracted
2720         bug_comment_from_svn_revision() from this method.
2721         (MarkBugFixed.__init__): Added.
2722         (MarkBugFixed._fetch_commit_log): Added.  Retrieves the commit
2723         log from the last commit if no svn revision is specified, else
2724         the commit log for the specified svn revision.
2725         (MarkBugFixed._determine_bug_id_and_svn_revision): Added.
2726         Attempts to determine the bug id and svn revision if one or both
2727         were not defined on the command line.
2728         (MarkBugFixed.execute): Added.  Adds a comment about the
2729         revision that fixed the bug and closes the bug.
2730         (BugzillaTool.__init__): Added mark-fixed subcommand.
2731         * Scripts/modules/bugzilla.py:
2732         (Bugzilla.fetch_title_from_bug): Added.  Returns the title of a
2733         bug given a bug id.
2734         * Scripts/modules/scm.py:
2735         (SCM.strip_r_from_svn_revision): Added.  Utility method to strip
2736         the leading 'r' from an svn revision.
2737         (SCM.svn_commit_log): Added.  Subclasses must override.
2738         (SCM.last_svn_commit_log): Added.  Subclasses must override.
2739         (SVN.svn_commit_log): Added.  Returns svn log for a given
2740         revision.
2741         (SVN.last_svn_commit_log): Added.  Uses svnversion to find the
2742         last commit in an svn working directory and then runs svn log.
2743         (Git.svn_commit_log): Added.  Returns svn log for a given
2744         revision.
2745         (Git.last_svn_commit_log): Added.  Runs git-svn-log with a limit
2746         of one log message.
2747
2748 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2749
2750         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
2751
2752         Reviewed by Brady Eidson.
2753
2754         * Scripts/svn-apply:
2755         (applyPatch): Add "--force" to $options arrayref if $force is
2756         set.
2757
2758 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2759
2760         <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch
2761
2762         Reviewed by Adam Roben.
2763
2764         When git-filter-branch has been invoked to rewrite ChangeLog
2765         files on series of git commits, it changes directories into
2766         .git-rewrite/t before re-running resolve-ChangeLogs.  This
2767         causes determineVCSRoot() in VCSUtils.pm to return
2768         ".git-rewrite/t", which causes that path to be prepended to all
2769         ChangeLog paths, which results in an error like this:
2770
2771             error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git.
2772             Died at WebKitTools/Scripts/resolve-ChangeLogs line 376.
2773
2774         The correct way to fix this is not to try to find the repository
2775         root when invoked by git-filter-branch.
2776
2777         * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true,
2778         set $relativePath to '.' instead of calling
2779         chdirReturningRelativePath(determineVCSRoot()).
2780         (isInGitFilterBranch): Added.  Checks for the existence of the
2781         MAPPED_PREVIOUS_COMMIT environment variable.
2782
2783 2009-09-01  Xan Lopez  <xlopez@igalia.com>
2784
2785         Reviewed by Gustavo Noronha.
2786
2787         Add support for Fedora distros in the http tests
2788         https://bugs.webkit.org/show_bug.cgi?id=28263
2789
2790         Add detection code for Fedora distribution, and use the proper
2791         httpd conf file when needed.
2792
2793         * Scripts/run-webkit-httpd:
2794         * Scripts/run-webkit-tests:
2795         * Scripts/webkitdirs.pm:
2796
2797 2009-09-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
2798
2799         Reviewed by Eric Seidel.
2800
2801         [Gtk] DRT needs implementation of overridePreference
2802         https://bugs.webkit.org/show_bug.cgi?id=28830
2803
2804         Implement overridePreference.
2805
2806         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2807         (resetDefaultsToConsistentValues):
2808         (setDefaultsToConsistentStateValuesForTesting):
2809         (runTest):
2810         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2811         (toWebSettingKey):
2812         (LayoutTestController::overridePreference):
2813
2814 2009-09-01  Joseph Pecoraro  <joepeck@webkit.org>
2815
2816         <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying
2817
2818         Reviewed by Eric Seidel.
2819
2820         Jump back and forth between the repository root directory (to apply) and the
2821         directory the script was run from (to find the patch).
2822
2823         * Scripts/svn-apply:
2824         * Scripts/svn-unapply:
2825
2826 2009-08-31  Adam Roben  <aroben@apple.com>
2827
2828         Fall back to a Release version of Safari if a Debug one doesn't exist
2829
2830         <http://webkit.org/b/28849>
2831
2832         Reviewed by Sam Weinig.
2833
2834         * Scripts/webkitdirs.pm:
2835         (safariPath): If the user is working with a Debug build, but there's
2836         no Debug version of Safari present, fall back to using a Release
2837         version of Safari.
2838
2839 2009-08-31  Adam Roben  <aroben@apple.com>
2840
2841         Make safariPath() work for Debug builds of Safari on Windows
2842
2843         <http://webkit.org/b/28849>
2844
2845         Reviewed by Sam Weinig.
2846
2847         * Scripts/webkitdirs.pm:
2848         (safariPath): If the user is working with a Debug build, add the
2849         _debug suffix to Safari.exe.
2850
2851 2009-08-28  Eric Seidel  <eric@webkit.org>
2852
2853         Reviewed by Adam Barth.
2854
2855         commit-queue needs a master process
2856         https://bugs.webkit.org/show_bug.cgi?id=28040
2857
2858         Add a bugzilla-tool commit-queue command
2859         Keeps per-bug logs, but doesn't yet upload them anywhere.
2860
2861         * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
2862         * Scripts/modules/buildbot.py: remove noisy log message
2863         * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
2864
2865 2009-08-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
2866
2867         Reviewed by Gustavo Noronha.
2868
2869         [GTK] Geolocation needs permission API before being enabled by default
2870
2871         Build the Gtk port with geolocation enabled. This option is only
2872         enabled for the buildbot. The autotools option will be enabled by
2873         default once the permissions API is implemented.
2874
2875         * Scripts/build-webkit:
2876
2877 2009-08-26  Cameron McCormack  <cam@mcc.id.au>
2878
2879         Reviewed by David Kilzer.
2880
2881         Make prepare-ChangeLog notice property changes
2882         https://bugs.webkit.org/show_bug.cgi?id=28675
2883
2884         Make the generated ChangeLog entry include a short description of
2885         property changes if there were such changes.  Also make
2886         prepare-ChangeLog not bail if the only changes are property changes.
2887
2888         * Scripts/prepare-ChangeLog:
2889
2890 2009-08-26  Adam Barth  <abarth@webkit.org>
2891
2892         Reviewed by Oliver Hunt.
2893
2894         Don't let local files access web URLs
2895         https://bugs.webkit.org/show_bug.cgi?id=28480
2896
2897         A bunch of our LayoutTests rely on our old behavior, so we explicitly
2898         grant local files universal access during testing.  Mainly, these tests
2899         involve making XMLHttpRequests for data URLs.
2900
2901         * DumpRenderTree/mac/DumpRenderTree.mm:
2902         (resetDefaultsToConsistentValues):
2903         * DumpRenderTree/qt/DumpRenderTree.cpp:
2904         (WebCore::WebPage::WebPage):
2905         * DumpRenderTree/win/DumpRenderTree.cpp:
2906         (resetDefaultsToConsistentValues):
2907
2908 2009-08-26  John Gregg  <johnnyg@google.com>
2909
2910         Reviewed by David Levin.
2911
2912         Minor style correction and include fix for notifications
2913         https://bugs.webkit.org/show_bug.cgi?id=28745
2914
2915         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2916           change to correct EnumStyle
2917         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2918
2919 2009-08-26  David Levin  <levin@chromium.org>
2920
2921         Reviewed by Alexey Proskuryakov.
2922
2923         XMLHttpRequest.withCredentials=false shouldn't save cookies.
2924         https://bugs.webkit.org/show_bug.cgi?id=28743
2925
2926         Added the support to the layout test controller on OSX and
2927         Windows (for CFNETWORK) to allow for changing the accept cookie
2928         policy.
2929
2930         * DumpRenderTree/LayoutTestController.cpp:
2931         (LayoutTestController::LayoutTestController): Added a bool
2932         to track the state of accepting cookies.
2933         (setAlwaysAcceptCookiesCallback): Standard wrapper method
2934         to go from js to a C++ method.
2935         (LayoutTestController::staticFunctions): Added the
2936         setAlwaysAcceptCookies method to the js layoutTestController.
2937         * DumpRenderTree/LayoutTestController.h:
2938         (LayoutTestController::alwaysAcceptCookies): Returns the value.
2939         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2940         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2941         * DumpRenderTree/mac/DumpRenderTree.mm:
2942         (resetDefaultsToConsistentValues): Reset the accept cookie to
2943         its default.
2944         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2945         (LayoutTestController::setAlwaysAcceptCookies): Does the work for
2946         OSX to change the cookie accept policy.
2947         * DumpRenderTree/win/DumpRenderTree.cpp:
2948         (setAlwaysAcceptCookies): Method to handle all the calls necessary
2949         to change the accept cookie policy on Windows.
2950         (resetDefaultsToConsistentValues): Reset the accept cookie to
2951         its default.
2952         * DumpRenderTree/win/DumpRenderTreeWin.h:
2953         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2954         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2955         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2956         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2957
2958 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2959
2960         Unreviewed.
2961
2962         Remove accidentally left in clobber option.
2963         https://bugs.webkit.org/show_bug.cgi?id=28400
2964
2965         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
2966
2967 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2968
2969         Reviewed by Mark Rowe.
2970
2971         Add canary-style Chromium WebKit build slave to the waterfall.
2972         https://bugs.webkit.org/show_bug.cgi?id=28400
2973
2974         * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
2975         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
2976
2977 2009-08-25  Cameron McCormack  <cam@mcc.id.au>
2978
2979         Reviewed by Darin Adler.
2980
2981         make-script-test-wrappers should be executable
2982         https://bugs.webkit.org/show_bug.cgi?id=28669
2983
2984         Make make-script-test-wrappers and update-sources-list.py both be
2985         executable.
2986
2987         * Scripts/update-sources-list.py:
2988         * Scripts/make-script-test-wrappers:
2989
2990 2009-08-25  Brent Fulgham  <bfulgham@webkit.org>
2991
2992         Build fix
2993
2994         Revise Debug_Cairo targets to point inherit from the 
2995         debug_wincairo.vsprops property sheet so that they link
2996         against the proper libraries in Debug build.
2997
2998         * DumpRenderTree/win/DumpRenderTree.vcproj:
2999         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3000         * WinLauncher/WinLauncher.vcproj:
3001
3002 2009-08-25  David Levin  <levin@chromium.org>
3003
3004         Reviewed by Adam Roben.
3005
3006         PLATFORM(CFNETWORK) should be USE(CFNETWORK).
3007         https://bugs.webkit.org/show_bug.cgi?id=28713
3008
3009         * DumpRenderTree/win/DumpRenderTree.cpp:
3010         (main):
3011
3012 2009-08-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3013
3014         Reviewed by Ariya Hidayat.
3015
3016         [Qt/Mac] Use CONFIG+=build_all only when building libraries
3017
3018         If no configuration is specified when building WebKit we pass the
3019         debug_and_release option to QMake which results in Makefiles for
3020         both configurations being generated.
3021
3022         Previously we built both of these configurations by default, for
3023         all targets (both the QtWebKit framework/dyldlib and the various
3024         executables such as QtLauncher and tests). This makes sense for
3025         the libraries, which get the _debug suffix and can be loaded on
3026         demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
3027         ended up building the same executable twice.
3028
3029         We now only build one instance of each executable, and since this
3030         is a developer build we build the debug-version. Passing either
3031         --debug or --release to build-webkit will override this, and
3032         even in the default case the release version can still be built
3033         by running 'make release' in the the build directory of each
3034         target.
3035
3036         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3037         * Scripts/webkitdirs.pm:
3038
3039 2009-08-24  Hironori Bono  <hbono@chromium.org>
3040
3041         Reviewed by Adam Barth.
3042
3043         Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
3044         <https://bugs.webkit.org/show_bug.cgi?id=27827>.
3045
3046         Because of the lack of mappings from GDK key-codes to WebKit key-codes,
3047         Chromium cannot send valid key-codes to JavaScript when a user types
3048         function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.
3049
3050         To write layout tests for this issue, added mappings from function-key
3051         names to platform-specific key-codes to EventSendingController objects
3052         so that eventSender.keyDown() can send function-key events without using
3053         platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
3054         is only for Mac. So this change adds this new test to Skipped tests for other
3055         platforms to prevent this change from crashing the build trees.)
3056
3057         * DumpRenderTree/mac/EventSendingController.mm:
3058         (-[EventSendingController keyDown:withModifiers:]):
3059
3060 2009-08-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
3061
3062         Reviewed by Xan Lopez.
3063
3064         [Gtk] API for disabling local file access to web URLs
3065         https://bugs.webkit.org/show_bug.cgi?id=28663
3066
3067         Enable this setting for DRT.
3068
3069         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3070         (resetWebViewToConsistentStateBeforeTesting):
3071
3072 2009-08-22  Adam Barth  <abarth@webkit.org>
3073
3074         Revert 47684.  We're going to do this later once clients have had a
3075         chance to opt into the setting they like.
3076
3077         * DumpRenderTree/mac/DumpRenderTree.mm:
3078         (resetDefaultsToConsistentValues):
3079         * DumpRenderTree/qt/DumpRenderTree.cpp:
3080         (WebCore::WebPage::WebPage):
3081         * DumpRenderTree/win/DumpRenderTree.cpp:
3082         (resetDefaultsToConsistentValues):
3083
3084 2009-08-22  Adam Barth  <abarth@webkit.org>
3085
3086         Reviewed by Eric Seidel.
3087
3088         Don't let local files access web URLs
3089         https://bugs.webkit.org/show_bug.cgi?id=28480
3090
3091         A bunch of our LayoutTests rely on our old behavior, so we explicitly
3092         grant local files universal access during testing.  Mainly, these tests
3093         involve making XMLHttpRequests for data URLs.
3094
3095         * DumpRenderTree/mac/DumpRenderTree.mm:
3096         (resetDefaultsToConsistentValues):
3097         * DumpRenderTree/qt/DumpRenderTree.cpp:
3098         (WebCore::WebPage::WebPage):
3099         * DumpRenderTree/win/DumpRenderTree.cpp:
3100         (resetDefaultsToConsistentValues):
3101
3102 2009-08-22  Mark Rowe  <mrowe@apple.com>
3103
3104         Rubber-stamped by Anders Carlsson.
3105
3106         Bring signed updates to the Mac nightly builds.
3107
3108         * WebKitLauncher/Info.plist:
3109         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3110         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
3111         (initializeSparkle):
3112         * WebKitLauncher/nightly.webkit.org.public.pem: Added.
3113
3114 2009-08-21  Jan Michael Alonzo  <jmalonzo@webkit.org>
3115
3116         Rubberstamped by Simon Fraser.
3117
3118         Remove GNOME keyring support in build-webkit. This dependency's
3119         already been removed in the Gtk port.
3120
3121         * Scripts/build-webkit:
3122
3123 2009-08-20  Brian Weinstein  <bweinstein@apple.com>
3124
3125         Reviewed by Adam Roben.
3126         Based on original patch by Stephanie Lewis.
3127
3128         Added support of the Windows malloc history format to parse-malloc history, so we can
3129         read and parse it.
3130
3131         * Scripts/parse-malloc-history:
3132
3133 2009-08-20  Chris Fleizach  <cfleizach@apple.com>
3134
3135         Reviewed by Darin Adler.
3136
3137         Enable various "grouping" ARIA roles
3138         https://bugs.webkit.org/show_bug.cgi?id=28486
3139
3140         Expose the ability to retrieve the subrole through accessibility for DRT.
3141
3142         * DumpRenderTree/AccessibilityUIElement.cpp:
3143         * DumpRenderTree/AccessibilityUIElement.h:
3144         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3145         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3146         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3147
3148 2009-08-20  Joseph Pecoraro  <joepeck@webkit.org>
3149
3150         Unreviewed.
3151
3152         Added myself as a committer.
3153
3154         * Scripts/modules/committers.py:
3155
3156 2009-08-20  Xan Lopez  <xlopez@igalia.com>
3157
3158         Reviewed by Gustavo Noronha.
3159
3160         Fix memory leaks.
3161
3162         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3163         (LayoutTestController::whiteListAccessFromOrigin):
3164         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3165         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3166
3167 2009-08-20  Eric Seidel  <eric@webkit.org>
3168
3169         Reviewed by Adam Barth.
3170
3171         bugzilla-tool post-diff can post partial diffs from SVN checkouts.
3172         https://bugs.webkit.org/show_bug.cgi?id=28445
3173
3174         Pass the checkout root as the cwd.  Also wrote a test to ensure this.
3175
3176         * Scripts/modules/scm.py:
3177         * Scripts/modules/scm_unittest.py:
3178
3179 2009-08-20  Mark Rowe  <mrowe@apple.com>
3180
3181         Reviewed by Adele Peterson.
3182
3183         Don't leak the JSStringRef returned by AccessibilityUIElement::attributeValue.
3184
3185         * DumpRenderTree/AccessibilityUIElement.cpp:
3186         (attributeValueCallback):
3187
3188 2009-08-20  Ariya Hidayat  <ariya.hidayat@nokia.com>
3189
3190         Unreviewed, build fix.
3191
3192         [Qt] The template-based qMax() compares two qreals.
3193
3194         * DumpRenderTree/qt/ImageDiff.cpp:
3195         (main):
3196
3197 2009-08-20  David Levin  <levin@chromium.org>
3198
3199         Reviewed by David Kilzer.
3200
3201         bugzilla-tool patch retrieval should handle 302 redirects.
3202         https://bugs.webkit.org/show_bug.cgi?id=28485
3203
3204         * Scripts/modules/scm.py: Pass the --location parameter to curl
3205         so that 302's are followed.
3206
3207 2009-08-20  Aaron Boodman  <aa@chromium.org>
3208
3209         One more speculative build for gtk.
3210
3211         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3212
3213 2009-08-20  Aaron Boodman  <aa@chromium.org>
3214
3215         Speculative build for gtk.
3216
3217         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3218         (LayoutTestController::whiteListAccessFromOrigin):
3219
3220 2009-08-20  Mark Rowe  <mrowe@apple.com>
3221
3222         Ignore some leaks that are known to originate from ImageIO.
3223
3224         * Scripts/run-webkit-tests:
3225
3226 2009-08-20  Aaron Boodman  <aa@chromium.org>
3227
3228         With David Levin.
3229
3230         Speculative build fix for qt.
3231
3232         * DumpRenderTree/qt/jsobjects.cpp:
3233         (LayoutTestController::whiteListAccessFromOrigin):
3234         * DumpRenderTree/qt/jsobjects.h:
3235
3236 2009-08-19  Mark Rowe  <mrowe@apple.com>
3237
3238         Reviewed by Dan Bernstein.
3239
3240         Fix <http://webkit.org/b/28484> Plug-in-related leaks seen on the build bot
3241
3242         Update check-for-global-initializers to accommodate the new uses of RefCountedLeakCounter in WebKit.
3243
3244         * Scripts/check-for-global-initializers:
3245
3246 2009-08-19  Aaron Boodman  <aa@chromium.org>
3247
3248         Reviewed by David Levin.
3249
3250         https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
3251         specify a more granular policy for cross-origin XHR access.
3252
3253         * DumpRenderTree/LayoutTestController.cpp: Expose whiteListAccessFromOrigin() to layout tests.
3254         (whiteListAccessFromOriginCallback): Ditto.
3255         (LayoutTestController::staticFunctions): Ditto.
3256         * DumpRenderTree/LayoutTestController.h: Ditto.
3257         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
3258         (LayoutTestController::whiteListAccessToOrigin): Ditto.
3259         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
3260         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
3261         * DumpRenderTree/qt/jsobjects.cpp: Ditto.
3262         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
3263         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Stub out whiteListAccessFromOrigin().
3264         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
3265         * DumpRenderTree/gtk/DumpRenderTree.cpp: Reset origin access lists before each test.
3266         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3267         * DumpRenderTree/mac/DumpRenderTree.mm: Ditto.
3268         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3269         * DumpRenderTree/qt/DumpRenderTree.cpp: Ditto.
3270         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Ditto.
3271
3272 2009-08-19  Mark Rowe  <mrowe@apple.com>
3273
3274         Rubber-stamped by Dan Bernstein.
3275
3276         Ignore some leaks that are known to originate from QTKit.
3277
3278         * Scripts/run-webkit-tests:
3279
3280 2009-08-19  Eric Seidel  <eric@webkit.org>
3281
3282         Reviewed by Adam Barth.
3283
3284         commit-queue/bugzilla-tool can get wedged if git is mid-rebase
3285         https://bugs.webkit.org/show_bug.cgi?id=28436
3286
3287         Make clean_working_directory cancel rebases too (even though that's a bit of a hack).
3288         This code will only ever be run when --force-clean is passed.
3289
3290         I also added a new unit test to make sure this code actually works. :)
3291
3292         * Scripts/modules/scm.py:
3293         * Scripts/modules/scm_unittest.py:
3294
3295 2009-08-19  Eric Seidel  <eric@webkit.org>
3296
3297         Reviewed by David Levin.
3298
3299         WebKit needs a changelogs.py to hold changelog-related code
3300         https://bugs.webkit.org/show_bug.cgi?id=28477
3301
3302         This is moving code and adding tests.  There was only one functional
3303         change (which was removing a trailing newline from the last_entry() result).
3304
3305         * Scripts/bugzilla-tool:
3306         * Scripts/modules/changelogs.py: Added.
3307         * Scripts/modules/changelogs_unittest.py: Added.
3308         * Scripts/run-webkit-unittests:
3309
3310 2009-08-20  Eric Seidel  <eric@webkit.org>
3311
3312         Reviewed by Adam Barth.
3313
3314         bugzilla-tool needs a way to ask build.webkit.org if the bots are passing
3315         https://bugs.webkit.org/show_bug.cgi?id=28222
3316
3317         Basic support for now.  This has been in testing for 24 hours now and worked great!
3318
3319         * Scripts/bugzilla-tool:
3320         * Scripts/modules/buildbot.py: Added.
3321         * Scripts/modules/buildbot_unittest.py: Added.
3322         * Scripts/run-webkit-unittests:
3323
3324 2009-08-19  Jan Michael Alonzo  <jmalonzo@webkit.org>
3325
3326         Reviewed by Gustavo Noronha.
3327
3328         [Gtk] Bump waitToDumpWatchdog interval to 15 seconds to match the
3329         default timeout used by run-webkit-tests. Mac and Win ports were
3330         recently bumped in http://trac.webkit.org/changeset/r47465.
3331
3332         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3333         (LayoutTestController::setWaitToDump):
3334
3335 2009-08-19  David D. Kilzer  <ddkilzer@webkit.org>
3336
3337         DumpRenderTreeSupport.pm: provide pre-generated swig source for Tiger
3338
3339         Reviewed by Mark Rowe.
3340
3341         Provide pre-generated swig source files for Tiger so it may
3342         benefit from the faster run-webkit-tests.
3343
3344         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm:
3345         Generated by swig.
3346         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c: Added.
3347         Generated by swig.
3348         (swig_type_info::SWIG_TypeNameComp):
3349         (swig_type_info::SWIG_TypeEquiv):
3350         (swig_type_info::SWIG_TypeRegisterTL):
3351         (swig_type_info::SWIG_TypeCheck):
3352         (swig_type_info::SWIG_TypeCast):
3353         (swig_type_info::SWIG_TypeDynamicCast):
3354         (swig_type_info::SWIG_TypeName):
3355         (swig_type_info::SWIG_TypePrettyName):
3356         (swig_type_info::SWIG_TypeQueryTL):
3357         (swig_type_info::SWIG_TypeClientDataTL):
3358         (swig_type_info::SWIG_PackData):
3359         (swig_type_info::SWIG_UnpackData):
3360         (swig_type_info::SWIG_PropagateClientDataTL):
3361         (swig_type_info::SWIG_PackVoidPtr):
3362         (swig_type_info::SWIG_UnpackVoidPtr):
3363         (swig_type_info::SWIG_PackDataName):
3364         (swig_type_info::SWIG_UnpackDataName):
3365         * DumpRenderTree/mac/PerlSupport/Makefile: Updated to build on
3366         Tiger using pre-generated files.
3367
3368 2009-08-18  Shinichiro Hamaji  <hamaji@chromium.org>
3369
3370         Reviewed by David Kilzer.
3371
3372         run-webkit-tests hangs when WebCore tries to log too much
3373         https://bugs.webkit.org/show_bug.cgi?id=15743
3374
3375         Read stdout and stderr in parallel.
3376
3377         * Scripts/run-webkit-tests:
3378
3379 2009-08-18  Mark Rowe  <mrowe@apple.com>
3380
3381         Rubber-stamped by Oliver Hunt.
3382
3383         Add a new build configuration that checks for leaks during the layout tests,
3384         and hook a new machine up to it.
3385
3386         * BuildSlaveSupport/build.webkit.org-config/config.json:
3387         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3388
3389 2009-08-18  Aaron Boodman  <aa@chromium.org>
3390
3391         Reviewed by Maciej Stachowiak.
3392
3393         https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests.
3394
3395         No new tests: Already covered by existing tests.
3396
3397         * Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest.
3398
3399 2009-08-18  Mark Rowe  <mrowe@apple.com>
3400
3401         Rubber-stamped by Geoff Garen.
3402
3403         Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests.
3404
3405         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3406         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3407
3408 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
3409
3410         Rubber-stamped by Adam Roben.
3411
3412         Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them,
3413         and removed include to fix building on VC++ Express.
3414
3415         * DumpRenderTree/win/UIDelegate.cpp:
3416         (UIDelegate::exceededDatabaseQuota):
3417
3418 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
3419
3420         Reviewed by Oliver Hunt.
3421
3422         Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support 
3423         LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
3424         
3425         Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface.
3426         Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac.
3427
3428         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3429         (LayoutTestController::setDatabaseQuota):
3430         * DumpRenderTree/win/UIDelegate.cpp:
3431         (UIDelegate::exceededDatabaseQuota):
3432
3433 2009-08-18  Peter Kasting  <pkasting@google.com>
3434
3435         Reviewed by Eric Seidel.
3436
3437         https://bugs.webkit.org/show_bug.cgi?id=28415
3438         Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
3439         have it.
3440
3441         * record-memory-win/record-memory-win.vcproj:
3442         * WinLauncher/WinLauncher.vcproj:
3443         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3444         * DumpRenderTree/win/ImageDiff.vcproj:
3445         * FindSafari/FindSafari.vcproj:
3446
3447 2009-08-18  Drew Wilson  <atwilson@google.com>
3448
3449         Reviewed by Eric Seidel.
3450
3451         Need to extend DumpRenderTree to expose number of worker threads
3452         https://bugs.webkit.org/show_bug.cgi?id=28292
3453
3454         Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit.
3455
3456         * DumpRenderTree/LayoutTestController.cpp:
3457         (getWorkerThreadCountCallback):
3458         (LayoutTestController::staticValues):
3459         * DumpRenderTree/LayoutTestController.h:
3460         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3461         (LayoutTestController::workerThreadCount):
3462         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3463         (LayoutTestController::workerThreadCount):
3464         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3465         (LayoutTestController::workerThreadCount):
3466         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3467         (LayoutTestController::workerThreadCount):
3468
3469 2009-08-18  Xan Lopez  <xlopez@igalia.com>
3470
3471         Reviewed by Jan Alonzo.
3472
3473         Initialize x and y in the GtkAllocation structure to shut up
3474         valgrind.
3475
3476         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3477         (runTest):
3478
3479 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
3480
3481         Reviewed by Darin Adler.
3482
3483         Some HTMLs are modified by make-script-test-wrappers
3484         https://bugs.webkit.org/show_bug.cgi?id=28213
3485
3486         Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
3487         the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
3488         re-generated wml/* and Geolocation/* .
3489
3490         * Scripts/make-script-test-wrappers:
3491
3492 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
3493
3494         Reviewed by Eric Seidel.
3495
3496         -webkit-box-orient:horizontal doesn't work on <button> tag
3497         https://bugs.webkit.org/show_bug.cgi?id=34445
3498
3499         Make a flexible button's anonymous child flexible and pass the
3500         parent's box-orient to the anonymous child.
3501
3502         Also, added a renderName for anonymous flexible boxes.
3503
3504         * Scripts/make-script-test-wrappers:
3505
3506 2009-08-17  Eric Seidel  <eric@webkit.org>
3507
3508         Reviewed by Darin Adler.
3509
3510         Can no longer --reset-results of a layout test directory
3511         https://bugs.webkit.org/show_bug.cgi?id=28336
3512
3513         --reset-results and --exit-after-n-failures are incompatible.
3514
3515         * Scripts/run-webkit-tests:
3516
3517 2009-08-17  David Kilzer  <ddkilzer@apple.com>
3518
3519         <http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git
3520
3521         Reviewed by Adam Roben.
3522
3523         New commit message:
3524             Committed r12345: <http://trac.webkit.org/changeset/12345>
3525
3526         * Scripts/bugzilla-tool:
3527         (bug_comment_from_commit_text): Print out a compact,
3528         standardized commit message for both git and svn.
3529
3530 2009-08-17  Peter Kasting  <pkasting@google.com>
3531
3532         Reviewed by Steve Falkenburg.
3533
3534         https://bugs.webkit.org/show_bug.cgi?id=27323
3535         Only add Cygwin to the path when it isn't already there.  This avoids
3536         causing problems for people who purposefully have non-Cygwin versions of
3537         executables like svn in front of the Cygwin ones in their paths.
3538
3539         * DumpRenderTree/win/DumpRenderTree.vcproj:
3540         * DumpRenderTree/win/ImageDiff.vcproj:
3541         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3542
3543 2009-08-17  David Kilzer  <ddkilzer@apple.com>
3544
3545         <http://webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()
3546
3547         Reviewed by David Levin.
3548
3549         * Scripts/modules/cpp_style.py:
3550         (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'.
3551         (check_max_min_macros): Added.  Returns level 4 error when MAX()
3552         and MIN() macros are used in header files and C++ source files.
3553         (check_style): Added call to check_max_min_macros().
3554         * Scripts/modules/cpp_style_unittest.py: Added unit tests.
3555         (test_max_macro): Added.
3556         (test_min_macro): Added.
3557
3558 2009-08-13  Mike Fenton  <mike.fenton@torchmobile.com>
3559
3560         Reviewed by Eric Seidel.
3561
3562         Move adjustLineToPixelBoundaries overlapping function to GraphicsContext.cpp
3563         and remove from GraphicsContextCairo.cpp and GraphicsContextQt.cpp.
3564
3565         https://bugs.webkit.org/show_bug.cgi?id=28268
3566
3567         * platform/graphics/GraphicsContext.cpp:
3568         (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
3569         * platform/graphics/GraphicsContext.h:
3570         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3571         * platform/graphics/qt/GraphicsContextQt.cpp:
3572
3573 2009-08-10  Mike Fenton  <mike.fenton@torchmobile.com>
3574
3575         Reviewed by Adam Treat.
3576
3577         Style fixes for DumpRenderTree/qt/jsobjects.cpp based on cpp_style.py and
3578         WebKit style guide.
3579
3580         https://bugs.webkit.org/show_bug.cgi?id=28161
3581
3582         * DumpRenderTree/qt/jsobjects.cpp:
3583         (findFrameNamed):
3584         (LoadItem::invoke):
3585         (LayoutTestController::provisionalLoad):
3586         (LayoutTestController::timerEvent):
3587         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3588         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3589         (LayoutTestController::numberOfActiveAnimations):
3590         (EventSender::keyDown):
3591         (EventSender::frameUnderMouse):
3592         (TextInputController::doCommand):
3593
3594 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3595
3596         <http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements
3597
3598         Reviewed by David Levin.
3599
3600         In <http://webkit.org/b/28355#c1>, it was noted that new source
3601         files use 'using namespace std;' instead of individual
3602         'using std::foo;' statements.  This adds a level 4 check for
3603         such statements.
3604
3605         * Scripts/modules/cpp_style.py:
3606         (_ERROR_CATEGORIES): Added 'build/using_std'.
3607         (check_using_std): Added.
3608         (check_style): Added call to check_using_std().
3609         * Scripts/modules/cpp_style_unittest.py:
3610         (WebKitStyleTest.test_using_std): Added unit test.
3611
3612 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3613
3614         Backed out r47343 which was mistakenly committed
3615
3616         * Scripts/bugzilla-tool:
3617         * Scripts/modules/scm.py:
3618
3619 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3620
3621         <http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class
3622
3623         Reviewed by David Levin.
3624
3625         The ScriptError class doesn't exist in bugzilla.py, so any
3626         errors print error messages about ScriptError instead of the
3627         actual error:
3628
3629             NameError: global name 'ScriptError' is not defined
3630
3631         * Scripts/modules/bugzilla.py:
3632         (BugzillaError): Added class.  Modeled after ScriptError class
3633         in scm.py.
3634         (Bugzilla.authenticate): Changed to use BugzillaError instead of
3635         ScriptError.
3636         (Bugzilla._check_create_bug_response): Ditto.
3637
3638 2009-08-14  Adam Bergkvist  <adam.bergkvist@ericsson.com>
3639
3640         Reviewed by Sam Weinig.
3641
3642         Added EventSource to the build script (default on).