WebKitTools/ChangeLog

   1 2009-11-24  Eric Seidel  <eric@webkit.org>
   2
   3         Reviewed by Adam Barth.
   4
   5         queries_unittest.py should test command output
   6         https://bugs.webkit.org/show_bug.cgi?id=31845
   7
   8         * Scripts/modules/commands/queries_unittest.py:
   9          - Capture stdout and stderr and compare with expected strings.
  10
  11 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
  12
  13         No Review.
  14
  15         Fix spelling error ("depenedencies").
  16
  17         * Scripts/build-webkit:
  18
  19 2009-11-24  Mark Rowe  <mrowe@apple.com>
  20
  21         Land the configuration that includes the two debug GTK Linux builders.
  22
  23         * BuildSlaveSupport/build.webkit.org-config/config.json:
  24
  25 2009-11-24  David Kilzer  <ddkilzer@apple.com>
  26
  27         <http://webkit.org/b/31840> bisect-builds broke after r50080
  28
  29         Reviewed by Dan Bernstein.
  30
  31         * Scripts/bisect-builds:
  32         (mountAndRunNightly): Switched back to using backticks to run
  33         the hdiutil command since exec() will terminate the existing
  34         script, which is not what we want.  Store the output of
  35         File::Spec->devnull() in a variable for use in the hdiutil
  36         detach commands.
  37
  38 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
  39
  40         Reviewed by Kenneth Rohde Christiansen.
  41
  42         Include "config.h" to meet Coding Style Guidelines
  43         https://bugs.webkit.org/show_bug.cgi?id=31792
  44
  45         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
  46         * DumpRenderTree/qt/jsobjects.cpp:
  47         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
  48
  49 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
  50
  51         Reviewed by Oliver Hunt.
  52
  53         Implement new required function to pass test we used to pass. This
  54         change is required since r51294.
  55
  56         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  57         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  58
  59 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
  60
  61         Reviewed by Kenneth Rohde Christiansen.
  62
  63         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
  64         https://bugs.webkit.org/show_bug.cgi?id=31775
  65
  66         LayoutTestController::dumpBackForwardList() should work with local URLs
  67         as well as with normal URLs (in http tests for instance).
  68         Currently it does not output the latter properly.
  69
  70         Unskip a bunch of passing http/navigation tests.
  71
  72         * DumpRenderTree/qt/DumpRenderTree.cpp:
  73         (WebCore::dumpHistoryItem):
  74
  75 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
  76
  77         Reviewed by Oliver Hunt.
  78
  79         ARIA: support aria-flowto
  80         https://bugs.webkit.org/show_bug.cgi?id=31762
  81
  82         * DumpRenderTree/AccessibilityUIElement.cpp:
  83         (ariaFlowToElementAtIndexCallback):
  84         (AccessibilityUIElement::getJSClass):
  85         * DumpRenderTree/AccessibilityUIElement.h:
  86         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  87         (AccessibilityUIElement::ariaFlowToElementAtIndex):
  88         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  89         (AccessibilityUIElement::ariaFlowToElementAtIndex):
  90         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  91         (AccessibilityUIElement::ariaFlowToElementAtIndex):
  92
  93 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
  94
  95         Reviewed by Kenneth Christiansen.
  96
  97         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
  98         https://bugs.webkit.org/show_bug.cgi?id=31638
  99
 100         Unfreeze WorkQueue after each test execution.
 101
 102         * DumpRenderTree/qt/DumpRenderTree.cpp:
 103         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 104
 105 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
 106
 107         Reviewed by Adam Barth.
 108
 109         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
 110         for localhost and 127.0.0.1.
 111         https://bugs.webkit.org/show_bug.cgi?id=31783
 112
 113         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
 114
 115         * DumpRenderTree/qt/DumpRenderTree.cpp:
 116         (WebCore::NetworkAccessManager::NetworkAccessManager):
 117         (WebCore::NetworkAccessManager::sslErrorsEncountered):
 118         (WebCore::WebPage::WebPage):
 119         * DumpRenderTree/qt/DumpRenderTree.h:
 120
 121 2009-11-22  Chris Evans  <cevans@chromium.org>
 122
 123         Reviewed by Adam Barth.
 124
 125         Disable access to file:/// directory listings
 126         https://bugs.webkit.org/show_bug.cgi?id=31329
 127
 128         Implemented setAllowUniversalAccessFromFileURLs to support testing of
 129         file URL security.
 130
 131         * DumpRenderTree/LayoutTestController.cpp:
 132         (setAllowUniversalAccessFromFileURLsCallback):
 133         (LayoutTestController::staticFunctions):
 134         * DumpRenderTree/LayoutTestController.h:
 135         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 136         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 137         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 138         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 139         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 140         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 141         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 142         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 143
 144 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
 145
 146         Reviewed by Kenneth Rohde Christiansen.
 147
 148         [Qt] Fix the timeout of fast/frames/frame-navigation.html
 149         https://bugs.webkit.org/show_bug.cgi?id=31638
 150
 151         The test is timeouting, because it uses the WorkQueue to load a document in one
 152         of the child frames and once the loading is finished, the DRT does not dump the
 153         tree. This is because it waits for the QWebFrame::loadFinished() signal from
 154         the main frame, while it should connect to QWebPage::loadFinished().
 155
 156         * DumpRenderTree/qt/DumpRenderTree.cpp:
 157         (WebCore::DumpRenderTree::DumpRenderTree):
 158
 159 2009-11-21  Eric Seidel  <eric@webkit.org>
 160
 161         Reviewed by Adam Barth.
 162
 163         bugzilla-tool --help spews way too much text
 164         https://bugs.webkit.org/show_bug.cgi?id=31771
 165
 166         * Scripts/bugzilla-tool:
 167          - Remove self.cached_scm initialization hack.
 168         * Scripts/modules/buildbot.py:
 169          - Make default_host accessible to callers.
 170         * Scripts/modules/commands/download.py:
 171          - Phrase help for all commands consistently and remove spurious help text punctuation.
 172         * Scripts/modules/commands/queries.py: Ditto.
 173         * Scripts/modules/commands/queues.py: Ditto.
 174         * Scripts/modules/commands/upload.py: Ditto.
 175         * Scripts/modules/multicommandtool.py:
 176          - Add HelpPrintingOptionParser.format_epilog to replace
 177            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
 178            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
 179          - Make --help only show a list of commands like "svn help" and "git help" do --
 180            previously --help was listing all commands and options.
 181          - Sort list of commands alphabetically.
 182
 183 2009-11-21  Eric Seidel  <eric@webkit.org>
 184
 185         No review.  Fixing a typo from the previous patch for bug 31767.
 186
 187         AbstractQueue.run_bugzilla_tool throws an exception
 188         https://bugs.webkit.org/show_bug.cgi?id=31769
 189
 190         * Scripts/modules/commands/queues.py:
 191
 192 2009-11-21  Eric Seidel  <eric@webkit.org>
 193
 194         Reviewed by Adam Barth.
 195
 196         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
 197         https://bugs.webkit.org/show_bug.cgi?id=31767
 198
 199         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
 200         Since we don't have a good way to test BugzillaTool pieces, I've
 201         left out a test for now.
 202
 203         * Scripts/bugzilla-tool:
 204          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
 205         * Scripts/modules/commands/queues.py:
 206          - Use tool.path() instead of __file__.
 207         * Scripts/modules/multicommandtool.py:
 208          - Add a new path() method to MultiComandTool.
 209         * Scripts/modules/multicommandtool_unittest.py:
 210          - Provide a path() method.  Little point in testing this mock implementation.
 211
 212 2009-11-21  Adam Barth  <abarth@webkit.org>
 213
 214         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
 215         WebKitTools.
 216
 217         * Scripts/modules/commands/download.py:
 218
 219 2009-11-21  Adam Barth  <abarth@webkit.org>
 220
 221         Reviewed by Eric Seidel.
 222
 223         Convert check-style to use LandingSequence
 224         https://bugs.webkit.org/show_bug.cgi?id=31763
 225
 226         Instead of manipulating the working copy by hand, we should use the
 227         LandingSequence in CheckStyle.  This will make this code eaiser to
 228         test.
 229
 230         * Scripts/modules/commands/download.py:
 231
 232 2009-11-20  Adam Barth  <abarth@webkit.org>
 233
 234         Reviewed by Eric Seidel.
 235
 236         Unit test query commands
 237         https://bugs.webkit.org/show_bug.cgi?id=31755
 238
 239         These tests are pretty rough, but hopefully they'll grow.
 240
 241         * Scripts/modules/commands/queries_unittest.py: Added.
 242         * Scripts/modules/mock_bugzillatool.py: Added.
 243         * Scripts/run-webkit-unittests:
 244
 245 2009-11-20  Eric Seidel  <eric@webkit.org>
 246
 247         Reviewed by Adam Barth.
 248
 249         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
 250         https://bugs.webkit.org/show_bug.cgi?id=31758
 251
 252         * Scripts/modules/multicommandtool.py:
 253          - Allow passing of explicit commands to MultiCommandTool.__init__
 254         * Scripts/modules/multicommandtool_unittest.py:
 255          - Use new Command.name naming system.
 256          - Test Command auto-discovery.
 257         * Scripts/modules/workqueue.py:
 258          - bug_id no longer exists, use patch['bug_id'] instead.
 259         * Scripts/modules/workqueue_unittest.py:
 260          - WorkQueues require names now.
 261          - should_proceed_with_work_item must return a patch object.
 262
 263 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
 264
 265         Reviewed by Beth Dakin.
 266
 267         WAI-ARIA: add support for aria-owns
 268         https://bugs.webkit.org/show_bug.cgi?id=31702
 269
 270         * DumpRenderTree/AccessibilityUIElement.cpp:
 271         (ariaOwnsElementAtIndexCallback):
 272         (AccessibilityUIElement::getJSClass):
 273         * DumpRenderTree/AccessibilityUIElement.h:
 274         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 275         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 276         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 277         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 278         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 279         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 280
 281 2009-11-20  Eric Seidel  <eric@webkit.org>
 282
 283         Reviewed by Adam Barth.
 284
 285         Fix exception thrown when running the commit-queue.
 286
 287         * Scripts/modules/statusbot.py: patch is optional.
 288         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
 289
 290 2009-11-20  Eric Seidel  <eric@webkit.org>
 291
 292         Reviewed by Adam Barth.
 293
 294         Teach the StatusBot how to support more than just the commit-queue
 295         https://bugs.webkit.org/show_bug.cgi?id=31754
 296
 297         * Scripts/modules/workqueue.py: Another typo.
 298
 299 2009-11-20  Eric Seidel  <eric@webkit.org>
 300
 301         Reviewed by Adam Barth.
 302
 303         Teach the StatusBot how to support more than just the commit-queue
 304         https://bugs.webkit.org/show_bug.cgi?id=31754
 305
 306         * Scripts/modules/commands/queues.py: Fix silly typo.
 307
 308 2009-11-20  Eric Seidel  <eric@webkit.org>
 309
 310         Reviewed by Adam Barth.
 311
 312         Teach the StatusBot how to support more than just the commit-queue
 313         https://bugs.webkit.org/show_bug.cgi?id=31754
 314
 315         * CommitQueueStatus/index.yaml:
 316          - Add indices required for the new queries.
 317         * CommitQueueStatus/queue_status.py:
 318          - Add a patch-status page and move update_status to update-status.
 319          - Only display "commit-queue" status records for the commit-queue.
 320          - Add support for a queue_name property on status records.
 321          - Fix _int_from_request to actually work.
 322         * CommitQueueStatus/update_status.html:
 323          - Add support for a queue_name on status records.
 324          - Remove unused list of bug ids.
 325          * Scripts/modules/commands/queues.py
 326           - Make the queues pass the patch instead of the bug_id to StatusBot.
 327         * Scripts/modules/statusbot.py:
 328          - Support passing the queue_name to the status updates.
 329          - Support fetching patch status with patch_status().
 330         * Scripts/modules/workqueue.py:
 331          - Pass the patch to the StatusBot instead of the bug_id.
 332          - Let WorkQueues have a name.
 333
 334 2009-11-20  Adam Barth  <abarth@webkit.org>
 335
 336         Reviewed by Eric Seidel.
 337
 338         Move bugzilla-tool commands into their own file
 339         https://bugs.webkit.org/show_bug.cgi?id=31752
 340
 341         This will let us write unit tests.
 342
 343         * Scripts/bugzilla-tool:
 344         * Scripts/modules/commands/__init__.py: Added.
 345         * Scripts/modules/commands/download.py: Added.
 346         * Scripts/modules/commands/queries.py: Added.
 347         * Scripts/modules/commands/queues.py: Added.
 348         * Scripts/modules/commands/upload.py: Added.
 349         * Scripts/modules/grammar.py: Added.
 350
 351 2009-11-20  Adam Barth  <abarth@webkit.org>
 352
 353         Reviewed by Eric Seidel.
 354
 355         BuildQueue should check if the tree is currently buildable
 356         https://bugs.webkit.org/show_bug.cgi?id=31744
 357
 358         * Scripts/bugzilla-tool:
 359         * Scripts/modules/landingsequence.py:
 360         * Scripts/modules/webkitlandingscripts.py:
 361
 362 2009-11-20  Adam Barth  <abarth@webkit.org>
 363
 364         Reviewed by Eric Seidel.
 365
 366         Move prepare_clean_working_directory into the LandingSequence
 367         https://bugs.webkit.org/show_bug.cgi?id=31743
 368
 369         * Scripts/bugzilla-tool:
 370         * Scripts/modules/landingsequence.py:
 371
 372 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
 373
 374         Reviewed by Kenneth Rohde Christiansen.
 375
 376         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
 377         https://bugs.webkit.org/show_bug.cgi?id=30460
 378
 379         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
 380
 381         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 382         (pluginInvoke):
 383
 384 2009-11-20  Adam Barth  <abarth@webkit.org>
 385
 386         Reviewed by Eric Seidel.
 387
 388         Pass the port information to the child process
 389         https://bugs.webkit.org/show_bug.cgi?id=31736
 390
 391         We need to do this so the child process knows what to build!
 392
 393         * Scripts/bugzilla-tool:
 394         * Scripts/modules/landingsequence.py:
 395         * Scripts/modules/webkitport.py:
 396         * Scripts/modules/webkitport_unittest.py:
 397
 398 2009-11-20  Adam Barth  <abarth@webkit.org>
 399
 400         Reviewed by Eric Seidel.
 401
 402         Support Qt port in build-queue
 403         https://bugs.webkit.org/show_bug.cgi?id=31733
 404
 405         * Scripts/bugzilla-tool:
 406
 407 2009-11-20  Adam Barth  <abarth@webkit.org>
 408
 409         Reviewed by Eric Seidel.
 410
 411         Implement a build-queue
 412         https://bugs.webkit.org/show_bug.cgi?id=31725
 413
 414         Currently this just builds the first 10 patches in the review queue.
 415         We'll want to do something smarter soon.
 416
 417         * Scripts/bugzilla-tool:
 418
 419 2009-11-20  Adam Barth  <abarth@webkit.org>
 420
 421         Reviewed by Eric Seidel.
 422
 423         Make commit-queue and style-queue show up in help
 424         https://bugs.webkit.org/show_bug.cgi?id=31724
 425
 426         We need to store their names on their class to make these commands
 427         properly register themselves with MultiCommandTool.
 428
 429         * Scripts/bugzilla-tool:
 430
 431 2009-11-20  Adam Barth  <abarth@webkit.org>
 432
 433         Reviewed by Eric Seidel.
 434
 435         Implement bugzilla-tool build-attachment
 436         https://bugs.webkit.org/show_bug.cgi?id=31722
 437
 438         This command builds an attachment from bugzilla.  It leaves the built
 439         patch in the working copy.
 440
 441         * Scripts/bugzilla-tool:
 442         * Scripts/modules/landingsequence.py:
 443         * Scripts/modules/webkitlandingscripts.py:
 444
 445 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
 446
 447         Reviewed by Xan Lopez.
 448
 449         [GTK] DRT release event does not create the state correctly
 450         https://bugs.webkit.org/show_bug.cgi?id=31717
 451
 452         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
 453
 454 2009-11-20  Eric Seidel  <eric@webkit.org>
 455
 456         Reviewed by Adam Barth.
 457
 458         MultiCommandTool should find Command objects automatically instead of with a manual list
 459         https://bugs.webkit.org/show_bug.cgi?id=31710
 460
 461         * Scripts/bugzilla-tool:
 462         * Scripts/modules/multicommandtool.py:
 463          - Use some wild python-fu to crawl all the known subclasses of Command.
 464
 465 2009-11-20  Adam Barth  <abarth@webkit.org>
 466
 467         Unreviewed "build" fix.  Added missing import.
 468
 469         * Scripts/bugzilla-tool:
 470
 471 2009-11-20  Adam Barth  <abarth@webkit.org>
 472
 473         Unreviewed "build" fix.  I failed to update LandingSequence.test
 474         properly.
 475
 476         * Scripts/modules/landingsequence.py:
 477
 478 2009-11-20  Adam Barth  <abarth@webkit.org>
 479
 480         Reviewed by Eric Seidel.
 481
 482         Create LandingSequence as the all-sing, all-dance landing class
 483         https://bugs.webkit.org/show_bug.cgi?id=31709
 484
 485         Client can inherit from this class to carefully control exactly which
 486         steps they wish to have happen in the landing sequence.
 487
 488         * Scripts/bugzilla-tool:
 489         * Scripts/modules/landingsequence.py: Added.
 490         * Scripts/modules/webkitlandingscripts.py: Added.
 491
 492 2009-11-19  Adam Barth  <abarth@webkit.org>
 493
 494         Reviewed by Eric Seidel.
 495
 496         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
 497         https://bugs.webkit.org/show_bug.cgi?id=31707
 498
 499         This is to help when we implement build-attachment.
 500
 501         * Scripts/bugzilla-tool:
 502
 503 2009-11-19  Adam Barth  <abarth@webkit.org>
 504
 505         Reviewed by Eric Seidel.
 506
 507         Support Qt port in bugzilla-tool
 508         https://bugs.webkit.org/show_bug.cgi?id=31701
 509
 510         Now we support building with Qt!
 511
 512         * Scripts/bugzilla-tool:
 513         * Scripts/modules/webkitport.py: Added.
 514         * Scripts/modules/webkitport_unittest.py: Added.
 515         * Scripts/run-webkit-unittests:
 516
 517 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
 518
 519         Reviewed by Adam Barth.
 520
 521         Remove inserting stderr into patch in bugzilla-tool
 522         https://bugs.webkit.org/show_bug.cgi?id=29914
 523
 524         Modify SCM python module's run_command function to avoid return of stderr
 525         by default, so stderr won't be inserted into the patches.
 526         Modify the related unit test.
 527
 528         * Scripts/modules/scm.py:
 529         * Scripts/modules/scm_unittest.py:
 530
 531 2009-11-19  Eric Seidel  <eric@webkit.org>
 532
 533         Reviewed by Adam Barth.
 534
 535         bugzilla-tool needs per-command help
 536         https://bugs.webkit.org/show_bug.cgi?id=31697
 537
 538         Added support for "bugzilla-tool help command-name"
 539         and a unit test to make sure it works.
 540
 541         * Scripts/modules/multicommandtool.py:
 542         * Scripts/modules/multicommandtool_unittest.py:
 543
 544 2009-11-19  Eric Seidel  <eric@webkit.org>
 545
 546         Reviewed by Adam Barth.
 547
 548         Move MultiCommandTool and Command into a separate file and add some basic unit tests
 549         https://bugs.webkit.org/show_bug.cgi?id=31695
 550
 551         * Scripts/bugzilla-tool:
 552         * Scripts/modules/multicommandtool.py: Added.
 553         * Scripts/modules/multicommandtool_unittest.py: Added.
 554         * Scripts/run-webkit-unittests:
 555
 556 2009-11-19  Eric Seidel  <eric@webkit.org>
 557
 558         No review, just adding a FIXME.
 559
 560         Split out command parsing and help printing from BugzillaTool
 561         https://bugs.webkit.org/show_bug.cgi?id=31688
 562
 563         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
 564
 565 2009-11-19  Eric Seidel  <eric@webkit.org>
 566
 567         Reviewed by Adam Barth.
 568
 569         Split out command parsing and help printing from BugzillaTool
 570         https://bugs.webkit.org/show_bug.cgi?id=31688
 571
 572         * Scripts/bugzilla-tool:
 573          - Add new MultiCommandTool class to contain option parsing and help printing logic.
 574          - Rename private methods to use _ pattern.
 575          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
 576          -
 577
 578 2009-11-19  Eric Seidel  <eric@webkit.org>
 579
 580         Reviewed by Adam Barth.
 581
 582         Re-factor help printing to use modern python idioms
 583         https://bugs.webkit.org/show_bug.cgi?id=31685
 584
 585         * Scripts/bugzilla-tool:
 586
 587 2009-11-19  Eric Seidel  <eric@webkit.org>
 588
 589         Reviewed by Darin Adler.
 590
 591         commit-queue empty queue logs twice
 592         https://bugs.webkit.org/show_bug.cgi?id=31679
 593
 594         * Scripts/bugzilla-tool:
 595
 596 2009-11-19  Eric Seidel  <eric@webkit.org>
 597
 598         Reviewed by Darin Adler.
 599
 600         bugzilla-tool's reviewer/committer rejection message should be clearer
 601         https://bugs.webkit.org/show_bug.cgi?id=31126
 602
 603         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
 604
 605         * Scripts/modules/bugzilla.py:
 606
 607 2009-11-19  Eric Z. Ayers  <zundel@google.com>
 608
 609         Reviewed by Pavel Feldman.
 610
 611         Forces a WM_PAINT event on calling layoutTestController.display()
 612         in order to enable the timeline-paint.html test on Windows.
 613         ::UpdateWindow() does not force an event becaue the window is
 614         not visible.
 615
 616         https://bugs.webkit.org/show_bug.cgi?id=31402
 617
 618         * DumpRenderTree/win/DumpRenderTree.cpp:
 619         (displayWebView):
 620
 621 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
 622
 623         No review needed.
 624
 625         Added myself to committers list.
 626
 627         * Scripts/modules/committers.py:
 628
 629 2009-11-19  Adam Barth  <abarth@webkit.org>
 630
 631         Reviewed by Eric Seidel.
 632
 633         Bugzilla-tool command classes should match command names
 634         https://bugs.webkit.org/show_bug.cgi?id=31666
 635
 636         I renamed all the commands except CommitMessageForCurrentDiff because
 637         the new name would conflict with an existing class.
 638
 639         * Scripts/bugzilla-tool:
 640
 641 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
 642
 643         Reviewed by Gustavo Noronha Silva.
 644
 645         Web Inspector: Implement "show inspector" in WebKit GTK
 646         API and enable console tests.
 647
 648         https://bugs.webkit.org/show_bug.cgi?id=31669
 649
 650         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 651         (LayoutTestController::showWebInspector):
 652
 653 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 654
 655         Reviewed by Simon Hausmann.
 656
 657         Minor refactoring + more documentation.
 658
 659         * DumpRenderTree/qt/DumpRenderTree.cpp:
 660         (WebCore::clearHistory):
 661         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 662
 663 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
 664
 665         Reviewed by Eric Seidel.
 666
 667         Ignore websocket tests when --no-http is specified.
 668         https://bugs.webkit.org/show_bug.cgi?id=31662
 669
 670         * Scripts/run-webkit-tests:
 671
 672 2009-11-18  Adam Barth  <abarth@webkit.org>
 673
 674         Reviewed by Eric Seidel.
 675
 676         Normalize ' and " in bugzilla-tool
 677         https://bugs.webkit.org/show_bug.cgi?id=31655
 678
 679         We decided " is better than ' and we should be consistent.
 680
 681         * Scripts/bugzilla-tool:
 682
 683 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 684
 685         Reviewed by Kenneth Rohde Christiansen.
 686
 687         [Qt] Remove support for Qt v4.3 or older versions
 688         https://bugs.webkit.org/show_bug.cgi?id=29469
 689
 690         * DumpRenderTree/qt/DumpRenderTree.pro:
 691         * DumpRenderTree/qt/ImageDiff.pro:
 692
 693 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
 694
 695         Reviewed by Eric Seidel.
 696
 697         GitTest.test_create_binary_patch fails if /tmp is symlink
 698         https://bugs.webkit.org/show_bug.cgi?id=31536
 699
 700         * Scripts/modules/scm_unittest.py:
 701
 702 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
 703
 704         Reviewed by Darin Adler.
 705
 706         Configuration for Chromium Build Slaves.
 707
 708         https://bugs.webkit.org/show_bug.cgi?id=31442
 709
 710         * BuildSlaveSupport/build.webkit.org-config/config.json:
 711         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 712
 713 2009-11-18  Eric Seidel  <eric@webkit.org>
 714
 715         Reviewed by Darin Adler.
 716
 717         workqueue.py results in totally broken commit-queue UI
 718         https://bugs.webkit.org/show_bug.cgi?id=31645
 719
 720         * Scripts/bugzilla-tool:
 721          - Remove unneeded use of PatchCollection.
 722          - Grab a new copy of the cq'd patches every run of the queue.
 723
 724 2009-11-18  Sam Weinig  <sam@webkit.org>
 725
 726         Reviewed by Anders Carlsson.
 727
 728         Make the Mac Geolocation API async.
 729
 730         Update DRT to use the new async Mac Geolocation API.
 731
 732         * DumpRenderTree/mac/UIDelegate.mm:
 733         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
 734
 735 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 736
 737         Reviewed by Kenneth Rohde Christiansen.
 738
 739         Add and option to toggle HTML5 datalist support to build-webkit
 740         https://bugs.webkit.org/show_bug.cgi?id=31599
 741
 742         * Scripts/build-webkit:
 743
 744 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
 745
 746         Reviewed by Kevin Ollivier.
 747
 748         Enable wx plugin support using the Windows implementation as a base.
 749
 750         https://bugs.webkit.org/show_bug.cgi?id=31636
 751
 752         * wx/build/settings.py:
 753
 754 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 755
 756         Reviewed by Simon Hausmann.
 757
 758         Change the initialization order so that the controllers
 759         will be created before exporting them to the JS DOM window.
 760
 761         * DumpRenderTree/qt/DumpRenderTree.cpp:
 762         (WebCore::DumpRenderTree::DumpRenderTree):
 763
 764 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 765
 766         Reviewed by Simon Hausmann.
 767
 768         Fix a code copy and paste error. m_page should be page.
 769
 770         * DumpRenderTree/qt/DumpRenderTree.cpp:
 771         (WebCore::DumpRenderTree::createWindow):
 772
 773 2009-11-17  Mark Rowe  <mrowe@apple.com>
 774
 775         Reviewed by Alexey Proskuryakov.
 776
 777         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
 778
 779         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
 780         This prevents symlinks from confusing the descendant check.
 781
 782 2009-11-17  Mark Rowe  <mrowe@apple.com>
 783
 784         Reviewed by Alexey Proskuryakov.
 785
 786         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
 787
 788         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
 789         server to be up rather than having run-webkit-tests abort immediately.
 790
 791         * Scripts/run-webkit-tests:
 792
 793 2009-11-17  Eric Seidel  <eric@webkit.org>
 794
 795         Reviewed by Darin Adler.
 796
 797         commit-queue is failing to set reviewer in ChangeLogs
 798         https://bugs.webkit.org/show_bug.cgi?id=31592
 799
 800         * Scripts/bugzilla-tool: Clarify the "applying" log message.
 801         * Scripts/modules/bugzilla.py:
 802          - Add a new _validate_committer_and_reviewer function as a
 803            temporary solution until we can make a real Attachment object
 804            which knows how to fill in its committer/reviewer fields automatically.
 805
 806 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 807
 808         Unreviewed buildbot fix.
 809
 810         Revert part of earlier patch and add comment, as it
 811         was causing timeouts on the buildbot.
 812
 813         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 814         (LayoutTestController::notifyDone):
 815
 816 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 817
 818         Reviewed by Oliver Hunt.
 819
 820         Make the timeout 15 sec as for the other DRT's and make
 821         it print out the same output when a test timeout.
 822
 823         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 824         (LayoutTestController::waitUntilDone):
 825         (LayoutTestController::notifyDone):
 826         (LayoutTestController::timerEvent):
 827
 828 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
 829
 830         Reviewed by Timothy Hatcher.
 831
 832         Fixed typos in comments.
 833
 834         * Scripts/modules/committers.py:
 835
 836 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
 837
 838         Reviewed by Timothy Hatcher.
 839
 840         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
 841         - Updated DRT to show/close inspector for all tests under /inspector
 842         - Introduced LayoutTestController::setTimelineProfilingEnabled and
 843           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
 844         - Removed reload on each inspector test
 845         - Renamed fast/inspector to fast/inspector-support in order not to trigger
 846         inspector for those.
 847         - Reimplemented timeline tests in order to get rid of reload there.
 848         - Moved tests that don't require harness into the fast group.
 849
 850         https://bugs.webkit.org/show_bug.cgi?id=31472
 851
 852         * DumpRenderTree/LayoutTestController.cpp:
 853         (setTimelineProfilingEnabledCallback):
 854         (closeWebInspectorCallback):
 855         (LayoutTestController::staticFunctions):
 856         * DumpRenderTree/LayoutTestController.h:
 857         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 858         (shouldOpenWebInspector):
 859         (runTest):
 860         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 861         (LayoutTestController::setTimelineProfilingEnabled):
 862         * DumpRenderTree/mac/DumpRenderTree.mm:
 863         (shouldOpenWebInspector):
 864         (runTest):
 865         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 866         (LayoutTestController::setTimelineProfilingEnabled):
 867         * DumpRenderTree/win/DumpRenderTree.cpp:
 868         (shouldOpenWebInspector):
 869         (runTest):
 870         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 871         (LayoutTestController::setTimelineProfilingEnabled):
 872
 873 2009-11-17  Oliver Hunt  <oliver@apple.com>
 874
 875         Reviewed by Maciej Stachowiak.
 876
 877         Incorrect use of JavaScriptCore API in DumpRenderTree
 878         https://bugs.webkit.org/show_bug.cgi?id=31577
 879
 880         Return undefined rather than a literal null.
 881
 882         * DumpRenderTree/AccessibilityUIElement.cpp:
 883         (setSelectedTextRangeCallback):
 884         (incrementCallback):
 885         (decrementCallback):
 886         (showMenuCallback):
 887
 888 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
 889
 890         Reviewed by Beth Dakin.
 891
 892         AX: aria-labelledby duplicates some of its WAI-ARIA label
 893         https://bugs.webkit.org/show_bug.cgi?id=31565
 894
 895         * DumpRenderTree/AccessibilityUIElement.cpp:
 896         (titleUIElementCallback):
 897         (getIsValidCallback):
 898         (AccessibilityUIElement::getJSClass):
 899
 900 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 901
 902         Reviewed by Simon Hausmann.
 903
 904         r50942 broke output from created windows. Make the
 905         m_enableTextOutput a member of the DRT and not the
 906         WebPage.
 907
 908         * DumpRenderTree/qt/DumpRenderTree.cpp:
 909         (WebCore::WebPage::WebPage):
 910         (WebCore::WebPage::javaScriptAlert):
 911         (WebCore::WebPage::javaScriptConsoleMessage):
 912         (WebCore::WebPage::javaScriptConfirm):
 913         (WebCore::WebPage::javaScriptPrompt):
 914         (WebCore::WebPage::acceptNavigationRequest):
 915         (WebCore::DumpRenderTree::DumpRenderTree):
 916         (WebCore::DumpRenderTree::open):
 917         (WebCore::DumpRenderTree::createWindow):
 918         * DumpRenderTree/qt/DumpRenderTree.h:
 919         (WebCore::DumpRenderTree::setTextOutputEnabled):
 920         (WebCore::DumpRenderTree::isTextOutputEnabled):
 921         (WebCore::WebPage::shouldInterruptJavaScript):
 922         (WebCore::WebPage::isTextOutputEnabled):
 923         (WebCore::WebPage::setViewGeometry):
 924
 925 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 926
 927         Reviewed by Gustavo Noronha Silva.
 928
 929         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
 930         as the implementation is being used by at least Qt and Gtk+.
 931
 932         Update buildsystems as well.
 933
 934         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 935         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
 936         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
 937         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
 938         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
 939         * GNUmakefile.am:
 940
 941 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
 942
 943         Reviewed by Alexey Proskuryakov.
 944
 945         Disable wss until all platforms support pyOpenSSL
 946
 947         https://bugs.webkit.org/show_bug.cgi?id=31479
 948
 949         * Scripts/run-webkit-tests:
 950
 951 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
 952
 953         Reviewed by Kenneth Christiansen.
 954
 955         [Qt] Implement load error pages support for Qt's DRT.
 956         https://bugs.webkit.org/show_bug.cgi?id=31509
 957
 958         For now, it will not be a default feature, and layout tests
 959         that want to make use of this have to explicitily call
 960         'handleErrorPages();' for the test source.
 961
 962         Any of the other DumpRenderTree's (mac, win and gtk)
 963         support handling error pages. Qt's will be the first.
 964
 965         * DumpRenderTree/qt/DumpRenderTree.cpp:
 966         (WebCore::WebPage::supportsExtension):
 967         (WebCore::WebPage::extension):
 968         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 969         (LayoutTestController::reset):
 970         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 971         (LayoutTestController::shouldHandleErrorPages):
 972         (LayoutTestController::handleErrorPages):
 973
 974 2009-11-16  Eric Seidel  <eric@webkit.org>
 975
 976         Reviewed by Adam Barth.
 977
 978         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
 979         https://bugs.webkit.org/show_bug.cgi?id=31549
 980
 981         Renamed --commit-queue to --non-interactive in most places
 982         and remove the code in land-patches which is no longer needed.
 983
 984         * Scripts/bugzilla-tool:
 985
 986 2009-11-16  Eric Seidel  <eric@webkit.org>
 987
 988         Reviewed by Adam Barth.
 989
 990         The commit-queue should use land-attachment
 991         https://bugs.webkit.org/show_bug.cgi?id=31548
 992
 993         * Scripts/bugzilla-tool:
 994
 995 2009-11-16  Adam Barth  <abarth@webkit.org>
 996
 997         Reviewed by Eric Seidel.
 998
 999         Convert CommitQueue over to PatchCollection
1000         https://bugs.webkit.org/show_bug.cgi?id=31547
1001
1002         Also fixes a bug in workqueue and adds a test!
1003
1004         * Scripts/bugzilla-tool:
1005         * Scripts/modules/workqueue.py:
1006         * Scripts/modules/workqueue_unittest.py:
1007
1008 2009-11-16  Adam Barth  <abarth@webkit.org>
1009
1010         Reviewed by Eric Seidel.
1011
1012         Move StyleQueue over to using PatchCollection
1013         https://bugs.webkit.org/show_bug.cgi?id=31544
1014
1015         That's what the class it's for.
1016
1017         * Scripts/bugzilla-tool:
1018         * Scripts/modules/patchcollection.py:
1019         * Scripts/modules/patchcollection_unittest.py:
1020
1021 2009-11-16  Eric Seidel  <eric@webkit.org>
1022
1023         Reviewed by Adam Barth.
1024
1025         bugzilla-tool needs a land-attachment command
1026         https://bugs.webkit.org/show_bug.cgi?id=31546
1027
1028         * Scripts/bugzilla-tool:
1029          - Move all the logic into AbstractLandingCommand and
1030            add a new LandAttachment command subclass.
1031          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1032
1033 2009-11-16  Eric Seidel  <eric@webkit.org>
1034
1035         Reviewed by Adam Barth.
1036
1037         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1038         https://bugs.webkit.org/show_bug.cgi?id=31543
1039
1040         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1041
1042         * Scripts/bugzilla-tool:
1043
1044 2009-11-16  Eric Seidel  <eric@webkit.org>
1045
1046         Reviewed by Adam Barth.
1047
1048         Disable the style queue from posting to the commit queue status page.
1049
1050         * Scripts/bugzilla-tool:
1051
1052 2009-11-16  Adam Barth  <abarth@webkit.org>
1053
1054         Reviewed by Eric Seidel.
1055
1056         Implement PatchCollection
1057         https://bugs.webkit.org/show_bug.cgi?id=31541
1058
1059         This class holds a set of patches and lets clients iterate through
1060         them.  Optionally, clients can install a filter.
1061
1062         * Scripts/modules/patchcollection.py: Added.
1063         * Scripts/modules/patchcollection_unittest.py: Added.
1064         * Scripts/run-webkit-unittests:
1065
1066 2009-11-16  Eric Seidel  <eric@webkit.org>
1067
1068         Reviewed by Adam Barth.
1069
1070         bugzilla-tool land-patches will close bugs with patches r=?
1071         https://bugs.webkit.org/show_bug.cgi?id=28230
1072
1073         The commit-queue shouldn't close patches with outstanding reviews on them,
1074         even if many reviewers seem to be against multi-patch bugs.
1075
1076         * Scripts/bugzilla-tool:
1077
1078 2009-11-16  Eric Seidel  <eric@webkit.org>
1079
1080         Reviewed by Adam Barth.
1081
1082         bugzilla-tool check-style should work with attachment ids instead of bug ids
1083         https://bugs.webkit.org/show_bug.cgi?id=31540
1084
1085         * Scripts/bugzilla-tool:
1086
1087 2009-11-16  Eric Seidel  <eric@webkit.org>
1088
1089         Reviewed by Adam Barth.
1090
1091         WorkQueue is the only place that should know about special exit codes
1092         https://bugs.webkit.org/show_bug.cgi?id=31534
1093
1094         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1095         and add tests for handling exit codes.
1096         I also cleaned up workqueue_unittest.py more.
1097
1098         * Scripts/bugzilla-tool:
1099         * Scripts/modules/workqueue.py:
1100         * Scripts/modules/workqueue_unittest.py:
1101
1102 2009-11-16  Eric Seidel  <eric@webkit.org>
1103
1104         Reviewed by Adam Barth.
1105
1106         Re-factor workqueue_unittest to allow for more than one test.
1107         https://bugs.webkit.org/show_bug.cgi?id=31535
1108
1109         * Scripts/modules/workqueue_unittest.py:
1110
1111 2009-11-16  Eric Seidel  <eric@webkit.org>
1112
1113         Reviewed by Adam Barth.
1114
1115         land-patches needs to be re-factored into smaller chunks
1116         https://bugs.webkit.org/show_bug.cgi?id=31532
1117
1118         * Scripts/bugzilla-tool: fix a couple obvious typos.
1119
1120 2009-11-16  Eric Seidel  <eric@webkit.org>
1121
1122         Reviewed by Adam Barth.
1123
1124         land-patches needs to be re-factored into smaller chunks
1125         https://bugs.webkit.org/show_bug.cgi?id=31532
1126
1127         The next patch will move these methods into WebKitLandingScripts.
1128
1129         * Scripts/bugzilla-tool:
1130          - Split out _land_patch and _close_bug_if_no_active_patches.
1131
1132 2009-11-16  Adam Barth  <abarth@webkit.org>
1133
1134         Reviewed by Eric Seidel.
1135
1136         Fix silly copy-and-paste code.  I am a terrible coder.
1137
1138         * Scripts/modules/bugzilla.py:
1139
1140 2009-11-16  Adam Barth  <abarth@webkit.org>
1141
1142         Reviewed by Eric Seidel.
1143
1144         Implement a StyleQueue
1145         https://bugs.webkit.org/show_bug.cgi?id=31537
1146
1147         The first iteration of the style queue only produces output locally.
1148         There is also a limit of 10 patches because it's not that useful to
1149         iterate through the entire review queue at this point.  We can remove
1150         the limit later.
1151
1152         * Scripts/bugzilla-tool:
1153         * Scripts/modules/bugzilla.py:
1154
1155 2009-11-16  Adam Barth  <abarth@webkit.org>
1156
1157         Reviewed by Eric Seidel.
1158
1159         Unit test WorkQueue
1160         https://bugs.webkit.org/show_bug.cgi?id=31531
1161
1162         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1163
1164         * Scripts/bugzilla-tool:
1165         * Scripts/modules/statusbot.py:
1166         * Scripts/modules/workqueue.py:
1167         * Scripts/modules/workqueue_unittest.py: Added.
1168         * Scripts/run-webkit-unittests:
1169
1170 2009-11-16  Eric Seidel  <eric@webkit.org>
1171
1172         Reviewed by Adam Barth.
1173
1174         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1175         https://bugs.webkit.org/show_bug.cgi?id=31530
1176
1177         * Scripts/bugzilla-tool:
1178
1179 2009-11-16  Eric Seidel  <eric@webkit.org>
1180
1181         Reviewed by Adam Barth.
1182
1183         bugzilla-tool needs apply-attachment
1184         https://bugs.webkit.org/show_bug.cgi?id=31528
1185
1186         * Scripts/bugzilla-tool:
1187          - Add ApplyAttachment command.
1188          - Abstract applying code into WebKitApplyingScripts.
1189          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1190         * Scripts/modules/bugzilla.py:
1191          - Add fetch_attachment and bug_id_for_attachment_id.
1192         * Scripts/modules/bugzilla_unittest.py:
1193          - Add test for new parsing.
1194          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1195
1196 2009-11-16  Eric Seidel  <eric@webkit.org>
1197
1198         Reviewed by Adam Barth.
1199
1200         Document check-style's use of force_clean.
1201
1202         * Scripts/bugzilla-tool:
1203         * Scripts/modules/scm.py:
1204
1205 2009-11-16  Adam Barth  <abarth@webkit.org>
1206
1207         Reviewed by Eric Seidel.
1208
1209         Move WorkQueue to its own file
1210         https://bugs.webkit.org/show_bug.cgi?id=31529
1211
1212         WorkQueue and WorkQueueDelegate are separate concerns from
1213         bugzilla-tool.  Also added a missing include to logging.py.
1214
1215         * Scripts/bugzilla-tool:
1216         * Scripts/modules/logging.py:
1217         * Scripts/modules/workqueue.py:
1218
1219 2009-11-16  Adam Barth  <abarth@webkit.org>
1220
1221         Reviewed by Eric Seidel.
1222
1223         Move OutputTee to logging.py.
1224
1225         * Scripts/bugzilla-tool:
1226         * Scripts/modules/logging.py:
1227
1228 2009-11-15  Adam Barth  <abarth@webkit.org>
1229
1230         Reviewed by Eric Seidel.
1231
1232         Refactor bugzilla-tool to allow for multiple queues
1233         https://bugs.webkit.org/show_bug.cgi?id=31513
1234
1235         Divide the commit queue class into three class to make creating
1236         additional queues easier.
1237
1238         * Scripts/bugzilla-tool:
1239
1240 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1241
1242         Reviewed by Eric Seidel.
1243
1244         svn-apply may not handle git patches created by bugzilla-tool
1245         https://bugs.webkit.org/show_bug.cgi?id=31457
1246
1247         * Scripts/modules/scm.py:
1248         * Scripts/modules/scm_unittest.py:
1249
1250 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1251
1252         Reviewed by Eric Seidel.
1253
1254         bugzilla-tool should post git binary diff
1255         https://bugs.webkit.org/show_bug.cgi?id=31458
1256
1257         Add --binary option to Git.create_patch.
1258
1259         * Scripts/modules/scm.py:
1260         * Scripts/modules/scm_unittest.py:
1261
1262 2009-11-15  Adam Barth  <abarth@webkit.org>
1263
1264         Reviewed by Darin Adler.
1265
1266         Add bugzilla-tool check-style
1267         https://bugs.webkit.org/show_bug.cgi?id=31515
1268
1269         * Scripts/bugzilla-tool:
1270         * Scripts/modules/bugzilla.py:
1271
1272 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1273
1274         Reviewed by Simon Hausmann.
1275
1276         Make the Qt Linux only --valgrind feature, suppress errors
1277         defined in the SuppressedValgrindErrors file.
1278
1279         * Scripts/run-webkit-tests:
1280
1281 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1282
1283         Reviewed by Simon Hausmann.
1284
1285         Set the locale to C and not to the current one in use on the system.
1286
1287         * DumpRenderTree/qt/DumpRenderTree.cpp:
1288         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1289
1290 2009-11-13  Adam Roben  <aroben@apple.com>
1291
1292         Add support for
1293         http/tests/security/isolatedWorld/didClearWindowObject.html
1294
1295         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1296         window objects in isolated worlds are cleared
1297
1298         Reviewed by Dave Hyatt.
1299
1300         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1301
1302         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1303         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1304         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1305         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1306         Added. Sets a __worldID property on the global object whose value is
1307         the ID of this world.
1308         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1309         Respond to this new delegate callback by calling through to one of the
1310         above new methods.
1311         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1312         (worldMap): Added. Returns a HashMap containing all the worlds we've
1313         created.
1314         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1315         haven't kept track of this world.
1316         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1317         instead of declaring our own.
1318
1319         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1320
1321         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1322         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1323         didClearWindowObjectForFrameInStandardWorld.
1324         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1325         Respond to this new delegate callback by calling through to one of the
1326         below new methods.
1327         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1328         Added. Sets a __worldID property on the gobal object whose value is
1329         the ID of this world.
1330         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1331         Added. Moved code here from didClearWindowObject.
1332
1333         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1334         didClearWindowObjectForFrame* functions.
1335
1336         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1337         (worldMap): Added. Returns a HashMap containing all the worlds we've
1338         created.
1339         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1340         haven't kept track of this world.
1341         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1342         instead of declaring our own.
1343
1344 2009-11-13  Adam Roben  <aroben@apple.com>
1345
1346         Finish replacing worldIDs with world objects
1347
1348         The only remaining use of worldIDs was in a method only used by DRT
1349         for the isolated worlds tests.
1350
1351         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1352
1353         Reviewed by Mark Rowe.
1354
1355         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1356         (LayoutTestController::evaluateScriptInIsolatedWorld):
1357         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1358         (LayoutTestController::evaluateScriptInIsolatedWorld):
1359         Updated for changes to WebFrame. Now holds the map of worldID -> world
1360         at this level instead of making WebKit do it.
1361
1362 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1363
1364         Reviewed by Simon Hausmann.
1365
1366         [Qt] Ensure the DRT does not output anything until first test is run
1367
1368         * DumpRenderTree/qt/DumpRenderTree.cpp:
1369         * DumpRenderTree/qt/DumpRenderTree.h:
1370
1371 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1372
1373         Reviewed by Tor Arne Vestbø.
1374
1375         Clear the undo stack in before each new test run.
1376
1377         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1378
1379         * DumpRenderTree/qt/DumpRenderTree.cpp:
1380         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1381
1382 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1383
1384         Reviewed by Kenneth Rohde Christiansen.
1385
1386         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1387
1388         * DumpRenderTree/qt/DumpRenderTree.cpp:
1389         (WebCore::WebPage::resetSettings):
1390         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1391         (LayoutTestController::overridePreference):
1392
1393 2009-11-13  Eric Seidel  <eric@webkit.org>
1394
1395         Reviewed by Adam Barth.
1396
1397         Update committers.py based on svn records
1398         https://bugs.webkit.org/show_bug.cgi?id=31366
1399
1400         This list was generated using validate-committer-lists from
1401         https://bugs.webkit.org/show_bug.cgi?id=30970
1402         and makes committers.py current for committers who have
1403         committed in the last 3 years.
1404
1405         * Scripts/modules/committers.py:
1406
1407 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1408
1409         Reviewed by Adam Barth.
1410
1411         The document-open.html test was flaky at times. The test invokes the layout test plugin
1412         which in its destroy stream handler opens a new document. This basically tears down the
1413         stream and the associated plugin instance. The pluginLog function in the layout test
1414         plugin attempts to retrieve the window script object on a torn down plugin instance
1415         which crashed consistently on windows in the debugger. The functions which issue
1416         these logs already have a valid window script object. We now have variants of the pluginLog
1417         function which take in a window script object with and without variable arguments.
1418
1419         https://bugs.webkit.org/show_bug.cgi?id=31067
1420
1421         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1422         (pluginLogWithWindowObject):
1423         (pluginLogWithWindowObjectVariableArgs):
1424         (pluginLog):
1425         (notifyTestCompletion):
1426         (testDocumentOpen):
1427         (testWindowOpen):
1428
1429 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1430
1431         Reviewed by Gustavo Noronha Silva.
1432
1433         https://bugs.webkit.org/show_bug.cgi?id=30997
1434         [Gtk] Implemment AtkDocument
1435
1436         Added testing support.
1437
1438         * DumpRenderTree/AccessibilityUIElement.cpp:
1439         * DumpRenderTree/AccessibilityUIElement.h:
1440         (getDocumentEncodingCallback):
1441         (getDocumentURICallback):
1442         (AccessibilityUIElement::getJSClass):
1443         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1444         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1445         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1446         (AccessibilityUIElement::documentEncoding):
1447         (AccessibilityUIElement::documentURI):
1448
1449 2009-11-12  Adam Roben  <aroben@apple.com>
1450
1451         Replace worldIDs with world objects
1452
1453         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1454         user scripts/stylesheets and isolated worlds
1455
1456         Reviewed by Sam Weinig.
1457
1458         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1459         (LayoutTestController::addUserScript):
1460         (LayoutTestController::addUserStyleSheet):
1461         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1462         (LayoutTestController::addUserScript):
1463         (LayoutTestController::addUserStyleSheet):
1464         Changed these functions to create a new WebJSWorld each time they're
1465         called and to pass that world to WebKit.
1466
1467 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1468
1469         Reviewed by Oliver Hunt.
1470
1471         need to implement aria tree roles
1472         https://bugs.webkit.org/show_bug.cgi?id=31284
1473
1474         * DumpRenderTree/AccessibilityUIElement.cpp:
1475         (disclosedRowAtIndexCallback):
1476         (selectedRowAtIndexCallback):
1477         (isEqualCallback):
1478         (isAttributeSettableCallback):
1479         (isActionSupportedCallback):
1480         (disclosedByRowCallback):
1481         (hierarchicalLevelCallback):
1482         (AccessibilityUIElement::getJSClass):
1483         * DumpRenderTree/AccessibilityUIElement.h:
1484         (AccessibilityUIElement::isEqual):
1485         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1486         (AccessibilityUIElement::hierarchicalLevel):
1487         (AccessibilityUIElement::disclosedRowAtIndex):
1488         (AccessibilityUIElement::selectedRowAtIndex):
1489         (AccessibilityUIElement::disclosedByRow):
1490         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1491         (AccessibilityUIElement::getChildAtIndex):
1492         (AccessibilityUIElement::disclosedRowAtIndex):
1493         (AccessibilityUIElement::selectedRowAtIndex):
1494         (AccessibilityUIElement::titleUIElement):
1495         (AccessibilityUIElement::parentElement):
1496         (AccessibilityUIElement::disclosedByRow):
1497         (AccessibilityUIElement::hierarchicalLevel):
1498         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1499         (AccessibilityUIElement::hierarchicalLevel):
1500         (AccessibilityUIElement::disclosedRowAtIndex):
1501         (AccessibilityUIElement::selectedRowAtIndex):
1502         (AccessibilityUIElement::disclosedByRow):
1503
1504 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1505
1506         Reviewed by Darin Adler.
1507
1508         svn-apply can not handle git binary diffs
1509         https://bugs.webkit.org/show_bug.cgi?id=26830
1510
1511         Support "literal" type git binary diffs.
1512
1513         * Scripts/VCSUtils.pm:
1514         * Scripts/modules/scm_unittest.py:
1515         * Scripts/svn-apply:
1516
1517 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1518
1519         Not reviewed, removing duplicate entry for myself in committers.py.
1520
1521         * Scripts/modules/committers.py:
1522
1523 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1524
1525         Reviewed by Darin Adler and Mark Rowe.
1526
1527         https://bugs.webkit.org/show_bug.cgi?id=31200
1528         Tests in http/tests/security/mixedContent start to fail when new tests are added
1529
1530         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1531
1532 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1533
1534         Reviewed by Jan Alonzo.
1535
1536         Create, and display a window for the inspector, for inspector
1537         tests.
1538
1539         Need to also show/hide the inspector window to avoid having
1540         problems with code assuming it is realized
1541         https://bugs.webkit.org/show_bug.cgi?id=31347
1542
1543         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1544         (webInspectorShowWindow):
1545         (webInspectorCloseWindow):
1546         (webInspectorInspectWebView):
1547         (createWebView):
1548
1549 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1550
1551         Unreviewed Qt buildbot fix.
1552
1553         My previous fix was wrong, so revert that change and fix it by
1554         returning when the document of the frame has no document element.
1555         Idea is borrowed from mac and win DRT.
1556
1557         * DumpRenderTree/qt/DumpRenderTree.cpp:
1558         (WebCore::DumpRenderTree::dumpFramesAsText):
1559
1560 2009-11-11  Eric Seidel  <eric@webkit.org>
1561
1562         Reviewed byg Kenneth Rohde Christiansen.
1563
1564         Update Kenneth's committer record to include the email he
1565         uses on lists.webkit.org.
1566
1567         * Scripts/modules/committers.py:
1568
1569 2009-11-11  Eric Seidel  <eric@webkit.org>
1570
1571         Reviewed by Gustavo Noronha Silva.
1572
1573         Several committers use separate email addresses for bugzilla and svn.webkit.org
1574         https://bugs.webkit.org/show_bug.cgi?id=31364
1575
1576         Update records for existing committers to include email addresses
1577         used in svn.webkit.org and lists.webkit.org.
1578         Most committers use the same email address in all 3 places, but some use
1579         separate addresses.  committers.py needs record of each of these addresses.
1580
1581         * Scripts/modules/committers.py:
1582
1583 2009-11-11  Eric Seidel  <eric@webkit.org>
1584
1585         No review, adding second email address for an existing committer.
1586
1587         Add Yong Li's second bugzilla account to his committer record.
1588         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1589
1590         * Scripts/modules/committers.py:
1591
1592 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1593
1594         Reviewed by Simon Hausmann.
1595
1596         If the frame has no innerText don't append it, and
1597         do not add a newline which breaks some cross platform
1598         results.
1599
1600         * DumpRenderTree/qt/DumpRenderTree.cpp:
1601         (WebCore::DumpRenderTree::dumpFramesAsText):
1602
1603 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1604
1605         Reviewed by Simon Hausmann.
1606
1607         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1608
1609         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1610         (webkit_test_plugin_new_instance):
1611         (webkit_test_plugin_destroy_instance):
1612         (webkit_test_plugin_destroy_stream):
1613
1614 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1615
1616         Reviewed by Mark Rowe.
1617
1618         Implement the functionality needed by plugins/window-open.html
1619
1620         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1621         (webkit_test_plugin_new_instance):
1622         (webkit_test_plugin_set_window):
1623
1624 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1625
1626         Reviewed by Simon Hausmann.
1627
1628         [Qt] Force -graphicssystem raster and -style windows when running DRT
1629
1630         * DumpRenderTree/qt/main.cpp:
1631         * Scripts/run-webkit-tests:
1632
1633 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1634
1635         Reviewed by Simon Hausmann.
1636
1637         Compute correct library paths for Qt
1638
1639         * Scripts/webkitdirs.pm:
1640
1641 2009-11-10  Mark Rowe  <mrowe@apple.com>
1642
1643         Reviewed by Sam Weinig.
1644
1645         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1646
1647         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1648         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1649         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1650         that had enabled frame load delegate logging this would result in extra log messages being generated,
1651         causing the test to fail.
1652
1653         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1654         tests.
1655
1656         * DumpRenderTree/mac/DumpRenderTree.mm:
1657         (dumpRenderTree):
1658         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1659         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1660
1661 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1662
1663         Reviewed by Kenneth Rohde Christiansen.
1664
1665         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1666
1667         * DumpRenderTree/qt/DumpRenderTree.cpp:
1668         (WebCore::DumpRenderTree::DumpRenderTree):
1669
1670 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1671
1672         Reviewed by Jan Alonzo.
1673
1674         [GTK] Remove WebSocket configuration from WebKitWebSettings
1675         https://bugs.webkit.org/show_bug.cgi?id=31244
1676
1677         Follow-up of r50724. Don't set the enable-web-socket property
1678         anymore.
1679
1680         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1681         (resetDefaultsToConsistentValues):
1682
1683 2009-11-10  Oliver Hunt  <oliver@apple.com>
1684
1685         Reviewed by Maciej Stachowiak.
1686
1687         Rename 3D Canvas related classes to use WebGL prefix
1688         https://bugs.webkit.org/show_bug.cgi?id=29095
1689
1690         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1691         and upate webkitdirs script to new method of testing for WebGL.
1692
1693         * Scripts/do-webcore-rename:
1694         * Scripts/webkitdirs.pm:
1695
1696 2009-11-09  Oliver Hunt  <oliver@apple.com>
1697
1698         Reviewed by Geoff Garen.
1699
1700         Make do-webcore-rename work with git.
1701
1702         * Scripts/do-webcore-rename:
1703
1704 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1705
1706         Adding Kenneth to the reviewers list.
1707
1708         * Scripts/modules/committers.py:
1709
1710 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1711
1712         Reviewed by Jan Alonzo.
1713
1714         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1715         https://bugs.webkit.org/show_bug.cgi?id=30482
1716
1717         LayoutTestControllerGtk now uses the exposed
1718         Page::tabKeyCyclesThroughElements API
1719
1720         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1721         (LayoutTestController::setTabKeyCyclesThroughElements):
1722
1723 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1724
1725         Reviewed by Holger Freyther.
1726
1727         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1728         This helps to pass the test case below. Also replaced hardcoded
1729         code numbers with defined constants.
1730         https://bugs.webkit.org/show_bug.cgi?id=31185
1731
1732         Test: editing/undo/undo-deleteWord.html
1733
1734         * DumpRenderTree/qt/EventSenderQt.cpp:
1735         (EventSender::keyDown):
1736
1737 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1738
1739         Reviewed by Holger Freyther.
1740
1741         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1742         https://bugs.webkit.org/show_bug.cgi?id=31164
1743
1744         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1745
1746         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1747         (LayoutTestController::processWork):
1748
1749 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1750
1751         Reviewed by Holger Freyther.
1752
1753         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1754         https://bugs.webkit.org/show_bug.cgi?id=31158
1755
1756         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1757         always, which from WorkQueue prospective means that a load has been started
1758         and the queue processing should stop and wait for the load to finish.
1759         Spinning it off into a loading and a non-loading variants was the solution
1760         adopted by Mac's DRT to work around this problem. The former keeps returning
1761         'true' while the later executes the script synchronously and returns 'false'
1762         making it possible to the WorkQueue to proceed right away.
1763
1764         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1765         (LayoutTestController::processWork):
1766         (LayoutTestController::queueLoadingScript):
1767         (LayoutTestController::queueNonLoadingScript):
1768         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1769         * DumpRenderTree/qt/WorkQueueItem.h:
1770         (LoadingScriptItem::LoadingScriptItem):
1771         (LoadingScriptItem::invoke):
1772         (NonLoadingScriptItem::NonLoadingScriptItem):
1773         (NonLoadingScriptItem::invoke):
1774
1775 2009-11-07  Mark Rowe  <mrowe@apple.com>
1776
1777         Rubber-stamped by Cameron Zwarich.
1778
1779         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1780
1781         * Scripts/commit-log-editor:
1782
1783 2009-11-07  Mark Rowe  <mrowe@apple.com>
1784
1785         Reviewed by Darin Adler.
1786
1787         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1788         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1789
1790         Move logic for determining the name and email address to use in a ChangeLog entry from
1791         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1792         whether the author of the patch matches committer, and therefore needs access to the
1793         email address that would be used in a ChangeLog entry.
1794
1795         Based on a patch by Pierre d'Herbemont.
1796
1797         * Scripts/VCSUtils.pm:
1798         * Scripts/commit-log-editor:
1799         * Scripts/prepare-ChangeLog:
1800         * Scripts/webkitdirs.pm:
1801
1802 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1803
1804         Reviewed by Adam Barth.
1805
1806         Added functionality to the layout test plugin to invoke document.open and
1807         window.open with default arguments. The associated webkit bug is
1808         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1809         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1810         work in Chromium (V8) if there is no calling javascript context. To achieve this
1811         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1812         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1813
1814         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1815         (testDocumentOpen):
1816         (testWindowOpen):
1817         (pluginAllocate):
1818         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1819         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1820         (NPP_New):
1821         (NPP_SetWindow):
1822         (NPP_DestroyStream):
1823         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1824         (NPP_New):
1825         (NPP_SetWindow):
1826         (NPP_NewStream):
1827         (NPP_DestroyStream):
1828
1829 2009-11-06  Eric Seidel  <eric@webkit.org>
1830
1831         Reviewed by Adam Barth.
1832
1833         bugzilla-tool crashed with exception
1834         https://bugs.webkit.org/show_bug.cgi?id=31092
1835
1836         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1837
1838 2009-11-04  Eric Seidel  <eric@webkit.org>
1839
1840         No review, just add a line which got left out of the patch uploaded for commit.
1841
1842         commit-queue is crashing when trying to reject patches after unknown failures
1843         https://bugs.webkit.org/show_bug.cgi?id=31091
1844
1845         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1846
1847 2009-11-04  Adam Roben  <aroben@apple.com>
1848
1849         Remove bogus else clause in bugzilla-tool
1850
1851         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1852         create-bug raises exception after entering bug description
1853
1854         Reviewed by David Kilzer.
1855
1856         * Scripts/bugzilla-tool:
1857         (CreateBug): else clauses are only hit if no exception is raised, so
1858         it makes no sense to try to re-raise the exception in an else clause.
1859         The exception will automatically be re-raised if it doesn't match any
1860         of the except clauses, so we don't have to do anything special here at
1861         all to get the desired behavior.
1862
1863 2009-11-04  Eric Seidel  <eric@webkit.org>
1864
1865         Reviewed by David Kilzer.
1866
1867         svn-apply's fixChangeLogPatch function seems broken
1868         https://bugs.webkit.org/show_bug.cgi?id=30683
1869
1870         Update fixChangeLogPatch to be able to handle patches which
1871         don't start at line 1.
1872         Add unit tests for svn-apply to scm_unittest.py.
1873
1874         * Scripts/VCSUtils.pm:
1875         * Scripts/modules/scm_unittest.py:
1876
1877 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1878
1879         Reviewed by Beth Dakin.
1880
1881         Need to implement ARIA role="combobox"
1882         https://bugs.webkit.org/show_bug.cgi?id=31096
1883
1884         * DumpRenderTree/AccessibilityUIElement.cpp:
1885         (showMenuCallback):
1886         (getIsExpandedCallback):
1887         (AccessibilityUIElement::getJSClass):
1888         * DumpRenderTree/AccessibilityUIElement.h:
1889         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1890         (AccessibilityUIElement::isExpanded):
1891         (AccessibilityUIElement::showMenu):
1892         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1893         (AccessibilityUIElement::isExpanded):
1894         (AccessibilityUIElement::showMenu):
1895         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1896         (AccessibilityUIElement::isSelected):
1897         (AccessibilityUIElement::isExpanded):
1898         (AccessibilityUIElement::showMenu):
1899
1900 2009-11-04  Eric Seidel  <eric@webkit.org>
1901
1902         Reviewed by Adam Barth.
1903
1904         commit-queue is crashing when trying to reject patches after unknown failures
1905         https://bugs.webkit.org/show_bug.cgi?id=31091
1906
1907         * Scripts/bugzilla-tool:
1908          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1909            so we have to find out what the current patch is by asking bugzilla again.
1910          - Discovered that this code was also leaking file descriptors, so fixed that.
1911
1912 2009-11-04  Adam Roben  <aroben@apple.com>
1913
1914         Make run-webkit-tests work for the Debug_Internal Windows
1915         configuration
1916
1917         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1918         suffix.
1919
1920         Fixes <http://webkit.org/b/31123>.
1921
1922         Reviewed by Sam Weinig.
1923
1924         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1925         Debug_Internal, either.
1926
1927 2009-11-04  Eric Seidel  <eric@webkit.org>
1928
1929         Reviewed by Adam Barth.
1930
1931         committers.py needs a way to store non-bugzilla email addresses
1932         https://bugs.webkit.org/show_bug.cgi?id=31037
1933
1934         Make Committer and Reviewer constructors take a single email or a list of emails.
1935         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1936         Expose reviewers(), used by validate-committer-lists on bug 30970.
1937
1938         * Scripts/modules/committers.py:
1939         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1940
1941 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1942
1943         Reviewed by David Levin.
1944
1945         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1946         https://bugs.webkit.org/show_bug.cgi?id=27491
1947
1948         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1949         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1950
1951         Functions to start or stop Web Socket servers are added.
1952
1953         * Scripts/run-webkit-tests:
1954
1955 2009-11-03  Eric Seidel  <eric@webkit.org>
1956
1957         No review, just changing wording of log message.
1958
1959         Change log string to say "failed" instead of "rejected"
1960         when a commit fails due to an out of date checkout.
1961         This makes grepping the commit-queue log for rejected patches easier.
1962
1963         * Scripts/bugzilla-tool:
1964
1965 2009-11-03  Eric Seidel  <eric@webkit.org>
1966
1967         No review, adding commonly known committers missing from the file.
1968
1969         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1970
1971 2009-11-03  Eric Seidel  <eric@webkit.org>
1972
1973         No review, just sort-order cleanup.
1974
1975         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1976
1977 2009-11-03  Stephen White  <senorblanco@chromium.org>
1978
1979         (Unreviewed).
1980
1981         Add myself to committers.py.
1982
1983         * Scripts/modules/committers.py:
1984
1985 2009-11-03  Robin Dunn  <robin@alldunn.com>
1986
1987         Reviewed by Kevin Ollviier.
1988
1989         Add packaging scripts for Debian-based Linux distros.
1990
1991         https://bugs.webkit.org/show_bug.cgi?id=31075
1992
1993         * wx/packaging/build-debian-installer.py: Added.
1994         * wx/packaging/debian: Added.
1995
1996 2009-11-03  Dan Bernstein  <mitz@apple.com>
1997
1998         Reviewed by Anders Carlsson and Beth Dakin.
1999
2000         https://bugs.webkit.org/show_bug.cgi?id=31070
2001
2002         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2003         destroyed, it executes the value of the 'ondestroy' parameter as a
2004         script.
2005
2006         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2007         (pluginAllocate): Initialize onDestroy.
2008         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2009         onDestroy.
2010         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2011         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2012         specified.
2013         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2014
2015 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2016
2017         Reviewed by Xan Lopez.
2018
2019         https://bugs.webkit.org/show_bug.cgi?id=31035
2020         [GTK] some accessibility tests hitting assertion in debug builds
2021
2022         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2023
2024         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2025         (AccessibilityController::rootElement):
2026
2027 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2028
2029         Reviewed by Beth Dakin.
2030
2031         Support ARIA "tab" roles
2032         https://bugs.webkit.org/show_bug.cgi?id=30842
2033
2034         * DumpRenderTree/AccessibilityUIElement.cpp:
2035         * DumpRenderTree/AccessibilityUIElement.h:
2036         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2037         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2038         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2039
2040 2009-11-01  Eric Seidel  <eric@webkit.org>
2041
2042         Reviewed by David Levin.
2043
2044         buildbots should use --exit-after-N-failures
2045         https://bugs.webkit.org/show_bug.cgi?id=30809
2046
2047         Make the bots exit after 20 failures to prevent never-ending
2048         test runs where every test spends a minute crashing.
2049
2050         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2051
2052 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2053
2054         Reviewed by Eric Seidel.
2055
2056         Turn on warnings for QtWebKit for gcc
2057         https://bugs.webkit.org/show_bug.cgi?id=30958
2058
2059         * DumpRenderTree/qt/main.cpp:
2060         (crashHandler): Mark function NO_RETURN
2061
2062 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2063
2064         Adding myself to the committers list.
2065
2066         * Scripts/modules/committers.py:
2067
2068 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2069
2070         Fix an issue that Adam noticed in DRT.
2071
2072         Reviewed by Darin Adler.
2073
2074         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2075         (AccessibilityUIElement::role):
2076         Get the length of the role text, and create a buffer dynamically.
2077
2078 2009-10-30  Eric Seidel  <eric@webkit.org>
2079
2080         No review, rolling out r50105.
2081         http://trac.webkit.org/changeset/50105
2082
2083         This commit was causing:
2084         https://bugs.webkit.org/show_bug.cgi?id=30869
2085         We'll re-implement the feature a different way.
2086
2087         * Scripts/bugzilla-tool:
2088
2089 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2090
2091         Test for MSAA: Accessibility of headings is not correct
2092
2093         https://bugs.webkit.org/show_bug.cgi?id=30937
2094
2095         Reviewed by Adam Roben.
2096
2097         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2098         (AccessibilityUIElement::role):
2099         Allow the role returned to be a BSTR.
2100         (AccessibilityUIElement::description):
2101         Fix a copy/paste error.
2102
2103 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2104
2105         Test for MSAA: Accessibility of links is wrong
2106
2107         https://bugs.webkit.org/show_bug.cgi?id=30928
2108
2109         Reviewed by Darin Adler.
2110
2111         * DumpRenderTree/AccessibilityUIElement.cpp:
2112         (getAccessibilityValueCallback):
2113         Return the accessibility value.
2114         (AccessibilityUIElement::getJSClass):
2115         Added "accessibilityValue" value.
2116
2117         * DumpRenderTree/AccessibilityUIElement.h:
2118
2119         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2120         (AccessibilityUIElement::accessibilityValue):
2121         Stubbed.
2122
2123         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2124         (AccessibilityUIElement::accessibilityValue):
2125         Stubbed.
2126
2127         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2128         (AccessibilityUIElement::accessibilityValue):
2129         Get the object's value, and return it as a JS string.
2130
2131 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2132
2133         Fix typo in command name used by wx build system.
2134
2135         * wx/build/build_utils.py:
2136
2137 2009-10-30  Adam Barth  <abarth@webkit.org>
2138
2139         Reviewed by Darin Adler.
2140
2141         Patch v1 is a dumb default name for patches
2142         https://bugs.webkit.org/show_bug.cgi?id=30952
2143
2144         Let's use "Patch" instead.
2145
2146         * Scripts/bugzilla-tool:
2147
2148 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2149
2150         Unreviewed trivial buildfix.
2151
2152         [Qt] Buildfix for r50333.
2153
2154         * DumpRenderTree/qt/DumpRenderTree.pro:
2155
2156 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2157
2158         Reviewed by Holger Freyther.
2159
2160         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2161         https://bugs.webkit.org/show_bug.cgi?id=30953
2162
2163         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2164         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2165         makes qt DRT to share this implementation (as gtk and mac ports do).
2166
2167         * DumpRenderTree/qt/DumpRenderTree.pro:
2168         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2169         * DumpRenderTree/qt/WorkQueue.h: Removed.
2170
2171 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2172
2173         Unreviewed potential buildbot fix.
2174
2175         Second try: Reset page history before running each test.
2176
2177         Apparently the QWebHistory::clear() keeps the current page
2178         in history which is not what we want, so we not additionally
2179         sets the history capacity to 0 (forces removing everything)
2180         and then sets it back to its original value.
2181
2182         * DumpRenderTree/qt/DumpRenderTree.cpp:
2183         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2184
2185 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2186
2187         Unreviewed potential buildbot fix.
2188
2189         Reset page history before running each test.
2190
2191         * DumpRenderTree/qt/DumpRenderTree.cpp:
2192         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2193
2194 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2195
2196         Reviewed by Eric Seidel.
2197
2198         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2199
2200         Bug 28420 -  Implement HTML5 <ruby> rendering
2201         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2202
2203         No new tests (no functional change).
2204
2205         * Scripts/build-webkit:
2206
2207 2009-10-29  Dan Bernstein  <mitz@apple.com>
2208
2209         Reviewed by Mark Rowe.
2210
2211         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2212         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2213         define it.
2214
2215         * Scripts/VCSUtils.pm:
2216         * Scripts/svn-apply:
2217         * Scripts/svn-unapply:
2218
2219 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2220
2221         Reviewed by Gustavo Noronha.
2222
2223         Use the GTK+ main loop instead of rolling our own mini-version of
2224         it.
2225
2226         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2227         (dump):
2228         (runTest):
2229         (webViewLoadFinished):
2230
2231 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2232
2233         Reviewed by Oliver Hunt.
2234
2235         Implement the Qt version of DRT dumpBackForwardList().
2236
2237         * DumpRenderTree/qt/DumpRenderTree.cpp:
2238         (WebCore::dumpHistoryItem):
2239         (WebCore::DumpRenderTree::dumpBackForwardList):
2240
2241 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2242
2243         Reviewed by Adam Roben.
2244
2245         Implement DRT functionality for Qt introduced in
2246         r28690 and r28705.
2247
2248         - Implemented pathToLocalResource which exposes the functionality of
2249         converting a given unix path to the correct location on Windows.
2250         - Implemented a way to remove machine-dependent information from paths
2251         in layout test results.
2252
2253         * DumpRenderTree/qt/DumpRenderTree.cpp:
2254         (WebCore::urlSuitableForTestResult):
2255         (WebCore::WebPage::javaScriptConsoleMessage):
2256         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2257         (LayoutTestController::pathToLocalResource):
2258         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2259
2260 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2261
2262         Adding myself to the committers list.
2263
2264         * Scripts/modules/committers.py:
2265
2266 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2267
2268         Adding myself to the committers list.
2269
2270         * Scripts/modules/committers.py:
2271
2272 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2273
2274         Reviewed by Jan Alonzo.
2275
2276         [GTK] API to start inspector for a WebView
2277         https://bugs.webkit.org/show_bug.cgi?id=22551
2278
2279         Use the new inspector API to implement the LayoutTestController
2280         interfaces used to test the inspector.
2281
2282         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2283         (webInspectorInspectWebView):
2284         (createWebView):
2285         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2286         (LayoutTestController::showWebInspector):
2287         (LayoutTestController::closeWebInspector):
2288         (LayoutTestController::evaluateInWebInspector):
2289
2290 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2291
2292         Reviewed by Eric Seidel.
2293
2294         [Qt] WebFrame::counterValueForElementById must not be exposed
2295         https://bugs.webkit.org/show_bug.cgi?id=30882
2296
2297         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2298         (LayoutTestController::counterValueForElementById):
2299
2300 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2301
2302         Rubberstamped by Oliver Hunt.
2303
2304         Fix the warning:
2305
2306         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2307         declared with attribute warn_unused_result".
2308
2309         by actually checking the result. In the case it is null, an
2310         error has occoured, so treat it as the other fatal errors.
2311
2312         * DumpRenderTree/qt/DumpRenderTree.cpp:
2313         (WebCore::DumpRenderTree::initializeFonts):
2314
2315 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2316
2317         Reviewed by Darin Adler.
2318
2319         Provide a way to get counter values with layoutTestContoller
2320         https://bugs.webkit.org/show_bug.cgi?id=30555
2321
2322         Define layoutTestContoller.counterValueForElementById.
2323
2324         * DumpRenderTree/LayoutTestController.cpp:
2325         (counterValueForElementByIdCallback):
2326         (LayoutTestController::staticFunctions):
2327         * DumpRenderTree/LayoutTestController.h:
2328         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2329         (LayoutTestController::counterValueForElementById):
2330
2331 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2332
2333         Rubberstamped by Oliver Hunt.
2334
2335         Change two methods to be internal for DRT use only.
2336
2337         Part of [Qt] Review all new API in Qt 4.6
2338         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2339
2340         * DumpRenderTree/qt/DumpRenderTree.cpp:
2341         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2342         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2343         (LayoutTestController::whiteListAccessFromOrigin):
2344
2345 2009-10-27  Eric Seidel  <eric@webkit.org>
2346
2347         Reviewed by Adam Barth.
2348
2349         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2350         https://bugs.webkit.org/show_bug.cgi?id=30826
2351
2352         * Scripts/svn-apply:
2353          - Add () around all system() calls.
2354          - Use the correct system() == 0 or die instead of system() or die
2355          - Add descriptive messages to all die statements.
2356
2357 2009-10-27  Steve Block  <steveblock@google.com>
2358
2359         Reviewed by NOBODY.
2360
2361         Adds steveblock@google.com to list of committers.
2362
2363         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2364
2365 2009-10-27  Eric Seidel  <eric@webkit.org>
2366
2367         Reviewed by Adam Barth.
2368
2369         svn-apply can exit(0) even on patch failure
2370         https://bugs.webkit.org/show_bug.cgi?id=29622
2371
2372         * Scripts/svn-apply:
2373          - Add a bunch of "or die" statements, hopefully catching all
2374            possible cases where failure could still exit(0).
2375
2376 2009-10-27  Eric Seidel  <eric@webkit.org>
2377
2378         Reviewed by Adam Barth.
2379
2380         svn-* scripts should share code through VCSUtils.pm
2381         https://bugs.webkit.org/show_bug.cgi?id=30791
2382
2383         Just moving code into a shared location.
2384
2385         * Scripts/VCSUtils.pm:
2386         * Scripts/prepare-ChangeLog:
2387         * Scripts/resolve-ChangeLogs:
2388         * Scripts/svn-apply:
2389         * Scripts/svn-create-patch:
2390         * Scripts/svn-unapply:
2391         * Scripts/update-webkit:
2392
2393 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2394
2395         Suppress a huge number of MSVC warnings when building wxWebKit.
2396
2397         * wx/build/settings.py:
2398
2399 2009-10-26  Eric Seidel  <eric@webkit.org>
2400
2401         No review, just adding Mike Belshe to the committers list.
2402
2403         * Scripts/modules/committers.py:
2404
2405 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2406
2407         Reviewed by Darin Adler.
2408
2409         Make .rc files compile on Windows without depending on MFC headers
2410         https://bugs.webkit.org/show_bug.cgi?id=30750
2411
2412         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2413         windows.h instead of afxres.h because it exists even when MFC is not
2414         installed, and is all that's needed here.
2415
2416         * FindSafari/FindSafari.rc: Ditto
2417
2418 2009-10-24  Eric Seidel  <eric@webkit.org>
2419
2420         Reviewed by Adam Barth.
2421
2422         bugzilla-tool post-diff should know how to mark commit-queue=?
2423         https://bugs.webkit.org/show_bug.cgi?id=29202
2424
2425         * Scripts/bugzilla-tool:
2426          - Add --commit-queue option to post-diff, post-commits and create-bug.
2427         * Scripts/modules/bugzilla.py:
2428          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2429          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2430
2431 2009-10-23  Eric Seidel  <eric@webkit.org>
2432
2433         Reviewed by Adam Barth.
2434
2435         bugzilla-tool commit-queue does not notice modifications to committers.py
2436         https://bugs.webkit.org/show_bug.cgi?id=30084
2437
2438         * Scripts/bugzilla-tool:
2439          - Make commit-queue re-exec itself instead of using while(1).
2440          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2441          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2442
2443 2009-10-22  Eric Seidel  <eric@webkit.org>
2444
2445         Reviewed by Adam Barth.
2446
2447         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2448         https://bugs.webkit.org/show_bug.cgi?id=30634
2449
2450         * Scripts/bugzilla-tool:
2451          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2452          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2453
2454 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2455
2456         Reviewed by Eric Seidel.
2457
2458         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2459
2460         https://bugs.webkit.org/show_bug.cgi?id=30763
2461
2462         * pywebsocket/mod_pywebsocket/__init__.py:
2463         * pywebsocket/mod_pywebsocket/dispatch.py:
2464         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2465         * pywebsocket/mod_pywebsocket/standalone.py:
2466         * pywebsocket/setup.py:
2467         * pywebsocket/test/test_dispatch.py:
2468
2469 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2470
2471         Reviewed by David Levin.
2472
2473         REGRESSION: 2 failures in run-webkit-unittests
2474         https://bugs.webkit.org/show_bug.cgi?id=30645
2475
2476         * Scripts/modules/cpp_style_unittest.py:
2477         Fixed a few test scenarios which apparently lost some spaces from
2478         text literals.
2479
2480 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2481
2482         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2483
2484         * Scripts/webkitdirs.pm:
2485
2486 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2487
2488         Reviewed by Darin Adler.
2489
2490         Unification of using null device in perl scripts.
2491         https://bugs.webkit.org/show_bug.cgi?id=30572
2492
2493         * Scripts/VCSUtils.pm:
2494         * Scripts/bisect-builds:
2495         * Scripts/resolve-ChangeLogs:
2496         * Scripts/run-iexploder-tests:
2497         * Scripts/run-jsc:
2498         * Scripts/run-mangleme-tests:
2499         * Scripts/run-webkit-tests:
2500         * Scripts/webkitdirs.pm:
2501         Using File::Spec->devnull() instead of hard coded /dev/null.
2502
2503 2009-10-26  Eric Seidel  <eric@webkit.org>
2504
2505         Reviewed by Holger Freyther.
2506
2507         Reviewers are missing from committers.py
2508         https://bugs.webkit.org/show_bug.cgi?id=30733
2509
2510         * Scripts/modules/committers.py:
2511
2512 2009-10-23  Eric Seidel  <eric@webkit.org>
2513
2514         No review, only adding Alice to the list of reviewers.
2515
2516         * Scripts/modules/committers.py:
2517
2518 2009-10-23  Eric Seidel  <eric@webkit.org>
2519
2520         Reviewed by Eric Carlson.
2521
2522         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2523         https://bugs.webkit.org/show_bug.cgi?id=30700
2524
2525         * DumpRenderTree/mac/DumpRenderTree.mm:
2526         (resetDefaultsToConsistentValues): Update QuickTime version check.
2527
2528 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2529
2530         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
2531         character measurement APIs that are private on Tiger.
2532
2533         * wx/build/settings.py:
2534
2535 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2536
2537         Reviewed by NOBODY (build fix).
2538         Build fix following bug #30696.
2539
2540         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2541         (LayoutTestController::evaluateScriptInIsolatedWorld):
2542
2543 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2544
2545         Reviewed by Sam Weinig & Geoff Garen.
2546
2547         https://bugs.webkit.org/show_bug.cgi?id=30696
2548         Enable isolated-worlds tests on mac.
2549
2550         Add private interface for DRT to invoke execution in a given world.
2551
2552         * DumpRenderTree/LayoutTestController.cpp:
2553         (evaluateScriptInIsolatedWorldCallback):
2554         (LayoutTestController::staticFunctions):
2555         * DumpRenderTree/LayoutTestController.h:
2556         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2557         (LayoutTestController::evaluateScriptInIsolatedWorld):
2558         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2559         (LayoutTestController::evaluateScriptInIsolatedWorld):
2560
2561 2009-10-21  Eric Seidel  <eric@webkit.org>
2562
2563         Reviewed by Adam Barth.
2564
2565         bugzilla-tool's "patch failed to download an apply" error should give more information
2566         https://bugs.webkit.org/show_bug.cgi?id=30632
2567
2568         * Scripts/modules/scm.py:
2569          - Use the common run_command method instead of custom POpen code.
2570          - Make run_command know how to take pipes as input.
2571         * Scripts/modules/scm_unittest.py:
2572          - Add new tests to cover change.
2573          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2574
2575 2009-10-21  Kent Tamura  <tkent@chromium.org>
2576
2577         Unreviewed.  Adding myself to the committers list.
2578
2579         * Scripts/modules/committers.py:
2580
2581 2009-10-21  Robin Dunn  <robin@alldunn.com>
2582
2583         Reviewed by Kevin Ollivier.
2584
2585         Update the Windows installer builder to work with Vista / Win 7 and with git.
2586
2587         https://bugs.webkit.org/show_bug.cgi?id=30649
2588
2589         * wx/build/build_utils.py:
2590         * wx/packaging/build-mac-installer.py:
2591         * wx/packaging/build-win-installer.py:
2592         * wx/packaging/wxWebKitInstaller.iss.in:
2593
2594 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2595
2596         Reviewed by Gustavo Noronha.
2597
2598         [GTK] Added conditional code to avoid using
2599         gdk_window_get_root_coords if we do not have a gtk+ release newer
2600         than 2.17.3.
2601         https://bugs.webkit.org/show_bug.cgi?id=30636
2602
2603         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2604
2605 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2606
2607         Reviewed by Eric Seidel.
2608
2609         [Qt] Added dummy implementation for keepWebHistory()
2610         https://bugs.webkit.org/show_bug.cgi?id=30592
2611
2612         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2613         (LayoutTestController::keepWebHistory):
2614         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2615
2616 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2617
2618         Reviewed by Xan Lopez.
2619
2620         [GTK] Fixed the double click condition, it is not double click if
2621         we move in just in one direction.
2622         https://bugs.webkit.org/show_bug.cgi?id=30636
2623
2624         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2625
2626 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2627
2628         Reviewed by Xan Lopez.
2629
2630         [GTK] Initialize the events completly before emitting them.
2631         https://bugs.webkit.org/show_bug.cgi?id=30633
2632
2633         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2634
2635 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2636
2637         wx build fix. Fix for when linking using --as-needed with gcc.
2638
2639         * wx/browser/wscript:
2640
2641 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2642
2643         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2644         to support all the features used by CURL backend.
2645
2646         * wx/build/settings.py:
2647         * wx/install-unix-extras:
2648
2649 2009-10-20  Anton Muhin  <antonm@chromium.org>
2650
2651         Reviewed by Adam Barth.
2652
2653         Add {ager,antonm,yurys}@chromium.org into committers.py
2654         https://bugs.webkit.org/show_bug.cgi?id=30560
2655
2656         * Scripts/modules/committers.py:
2657
2658 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2659
2660         Reviewed by Tor Arne Vestbø.
2661
2662         Make the Netscape Test plugin available to the Qt launcher.
2663
2664         * Scripts/run-launcher:
2665
2666 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2667
2668         Reviewed by David Levin.
2669
2670         Removed WebSocket runtime settings.
2671         https://bugs.webkit.org/show_bug.cgi?id=29896
2672
2673         WebSocket runtime configuration is supported by chromium/v8 only.
2674
2675         * DumpRenderTree/mac/DumpRenderTree.mm:
2676         (resetDefaultsToConsistentValues):
2677         * DumpRenderTree/win/DumpRenderTree.cpp:
2678         (resetDefaultsToConsistentValues):
2679
2680 2009-10-19  Nate Chapin  <japhet@chromium.org>
2681
2682         Reviewed by Adam Barth.
2683
2684         Add testFail() to test plugin so we can test our handling of a
2685         plugin invoke call returning false.
2686
2687         https://bugs.webkit.org/show_bug.cgi?id=30239
2688
2689         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2690         (pluginInvoke):
2691         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2692
2693 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2694
2695         Reviewed by Gustavo Noronha.
2696
2697         Enable DOM pasting when running layout tests.
2698
2699         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2700         (resetDefaultsToConsistentValues):
2701
2702 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2703
2704         Reviewed by Simon Hausmann.
2705
2706         Use the setPreferredContentsSize method instead
2707         of setFixedContentsSize, as the method has been renamed.
2708
2709         * DumpRenderTree/qt/DumpRenderTree.cpp:
2710         (WebCore::DumpRenderTree::open):
2711         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2712         (LayoutTestController::setFixedContentsSize):
2713
2714 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2715
2716         Reviewed by Dan Bernstein.
2717
2718         https://bugs.webkit.org/show_bug.cgi?id=30456
2719         Fixes for new Debug_All Windows build configuration.
2720
2721         * DumpRenderTree/win/DumpRenderTree.cpp:
2722         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2723         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2724
2725 2009-10-16  Eric Seidel  <eric@webkit.org>
2726
2727         Reviewed by Adam Barth.
2728
2729         commit-queue status bot should list which buildbot is blocking the queue
2730         https://bugs.webkit.org/show_bug.cgi?id=30452
2731
2732         Add new methods and testing.
2733
2734         * Scripts/bugzilla-tool:
2735         * Scripts/modules/buildbot.py:
2736         * Scripts/modules/buildbot_unittest.py:
2737
2738 2009-10-16  Eric Seidel  <eric@webkit.org>
2739
2740         Reviewed by Adam Barth.
2741
2742         run-webkit-tests fails when CWD is not inside a WebKit checkout
2743         https://bugs.webkit.org/show_bug.cgi?id=30451
2744
2745         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2746         * Scripts/modules/scm_unittest.py:
2747           - Remove use of original_path (we don't need to restore the CWD).
2748           - Don't use '.' to find the webkit checkout, use __file__ instead.
2749
2750 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2751
2752         Reviewed by Adam Roben.
2753
2754         Add a Debug_All configuration to build entire stack as debug.
2755         Change Debug_Internal to:
2756         - stop using _debug suffix for all WebKit/Safari binaries
2757         - not use _debug as a DLL naming suffix
2758         - use non-debug C runtime lib.
2759
2760         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2761         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2762         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2763         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2764         Add missing debug.vsprops inherited property sheet.
2765         Add Debug_All configuration.
2766         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2767         * WinLauncher/WinLauncher.vcproj:
2768         Removed extraneous definitions inherited from vsprops.
2769         Add Debug_All configuration.
2770
2771 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2772
2773         Reviewed by David Levin.
2774
2775         check-webkit-style is wrong about indent checking in namespaces
2776         in header files and a few other things
2777         https://bugs.webkit.org/show_bug.cgi?id=30362
2778
2779         The few other things include:
2780         + check-webkit-style does not require spaces around the equal sign
2781           inside 'if' statements and around binary operators that take
2782           numeric literals.
2783         + check-webkit-style reports false errors for the / operator
2784           when part of a filename in the #include directive.
2785
2786         * Scripts/modules/cpp_style.py:
2787         Improved indentation checking and space checking around
2788         binary operators. While the checks are still not perfect,
2789         they are clearly better than before.
2790         * Scripts/modules/cpp_style_unittest.py:
2791         Added test cases for the newly supported checks and modified old
2792         test cases to match the new guidelines
2793
2794 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2795
2796         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2797
2798         * wx/build/settings.py:
2799
2800 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2801
2802         Reviewed by David Levin.
2803
2804         Add mod_pywebsocket to test Web Sockets.
2805         http://code.google.com/p/pywebsocket/
2806         https://bugs.webkit.org/show_bug.cgi?id=27490
2807
2808         * pywebsocket/COPYING: Added.
2809         * pywebsocket/MANIFEST.in: Added.
2810         * pywebsocket/README: Added.
2811         * pywebsocket/example/echo_client.py: Added.
2812         * pywebsocket/example/echo_wsh.py: Added.
2813         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2814         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2815         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2816         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2817         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2818         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2819         * pywebsocket/mod_pywebsocket/util.py: Added.
2820         * pywebsocket/setup.py: Added.
2821         * pywebsocket/test/config.py: Added.
2822         * pywebsocket/test/mock.py: Added.
2823         * pywebsocket/test/run_all.py: Added.
2824         * pywebsocket/test/test_dispatch.py: Added.
2825         * pywebsocket/test/test_handshake.py: Added.
2826         * pywebsocket/test/test_mock.py: Added.
2827         * pywebsocket/test/test_msgutil.py: Added.
2828         * pywebsocket/test/test_util.py: Added.
2829         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2830         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2831         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2832         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2833         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2834         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2835         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2836         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2837
2838 2009-10-15  James Robinson  <jamesr@google.com>
2839
2840         Reviewed by David Levin.
2841
2842         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2843
2844         https://bugs.webkit.org/show_bug.cgi?id=30426
2845
2846         * Scripts/modules/cpp_style.py:
2847         * Scripts/modules/cpp_style_unittest.py:
2848
2849 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2850
2851         Reviewed by Adam Roben.
2852
2853         Fixes <http://webkit.org/b/30411>.
2854         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2855
2856         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2857         building Chromium.
2858
2859         * Scripts/pdevenv:
2860
2861 2009-10-15  Robin Dunn  <robin@alldunn.com>
2862
2863         Reviewed by Kevin Ollivier.
2864
2865         Add Mac package building scripts for wx.
2866
2867         https://bugs.webkit.org/show_bug.cgi?id=30405
2868
2869         * wx/build/build_utils.py:
2870         * wx/build/settings.py:
2871         * wx/packaging/build-mac-installer.py: Added.
2872
2873 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2874
2875         Reviewed by Gustavo Noronha.
2876
2877         Enable Web Sockets support when running layout tests.
2878
2879         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2880         (resetDefaultsToConsistentValues):
2881
2882 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2883
2884         Reviewed by Gustavo Noronha.
2885
2886         Need to initialize event.button.button, since in most cases a
2887         button number is not passed as an argument.
2888
2889         * DumpRenderTree/gtk/EventSender.cpp:
2890         (mouseDownCallback):
2891         (mouseUpCallback):
2892
2893 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2894
2895         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2896         the OS if none was explicitly set.
2897
2898         * wx/build/settings.py:
2899
2900 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2901
2902         Reviewed by Timothy Hatcher.
2903
2904         Web Inspector: enable developers extras within inspector layout tests.
2905
2906         https://bugs.webkit.org/show_bug.cgi?id=30014
2907
2908         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2909         (LayoutTestController::showWebInspector):
2910         (LayoutTestController::closeWebInspector):
2911         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2912         (LayoutTestController::showWebInspector):
2913         (LayoutTestController::closeWebInspector):
2914
2915 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2916
2917         Reviewed by Jan Alonzo.
2918
2919         GtkLauncher is using a deprecated signal
2920         https://bugs.webkit.org/show_bug.cgi?id=30364
2921
2922         Modified GtkLauncher to use notify::title signal instead of
2923         deprecated title-changed signal
2924
2925         * GtkLauncher/main.c:
2926         (notify_title_cb):
2927         (create_browser):
2928
2929 2009-10-14  Brady Eidson  <beidson@apple.com>
2930
2931         Reviewed by Sam Weinig.
2932
2933         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2934         1 - Disables WebHistory
2935         2 - Doesn't make sense in that context anyway.
2936
2937         * DumpRenderTree/win/DumpRenderTree.cpp:
2938         (createWebViewAndOffscreenWindow):
2939
2940 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2941
2942         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2943         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2944
2945         * wx/build/settings.py:
2946         * wx/install-unix-extras:
2947
2948 2009-10-14  Brady Eidson  <beidson@apple.com>
2949
2950         Reviewed by Sam Weinig.
2951
2952         WebKit Win API should provide a delegate interface for global history.
2953         https://bugs.webkit.org/show_bug.cgi?id=29905
2954
2955         * DumpRenderTree/LayoutTestController.cpp:
2956         (LayoutTestController::LayoutTestController):
2957         * DumpRenderTree/LayoutTestController.h:
2958         (LayoutTestController::dumpHistoryDelegateCallbacks):
2959         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2960
2961         * DumpRenderTree/win/DumpRenderTree.cpp:
2962         (shouldLogHistoryDelegates):
2963         (runTest):
2964         (createWebViewAndOffscreenWindow):
2965         (main):
2966         * DumpRenderTree/win/DumpRenderTree.vcproj:
2967
2968         Add the IWebHistoryDelegate to DRT Windows:
2969         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2970         (wstringFromBSTR):
2971         (HistoryDelegate::HistoryDelegate):
2972         (HistoryDelegate::~HistoryDelegate):
2973         (HistoryDelegate::QueryInterface):
2974         (HistoryDelegate::AddRef):
2975         (HistoryDelegate::Release):
2976         (HistoryDelegate::didNavigateWithNavigationData):
2977         (HistoryDelegate::didPerformClientRedirectFromURL):
2978         (HistoryDelegate::didPerformServerRedirectFromURL):
2979         (HistoryDelegate::updateHistoryTitle):
2980         (HistoryDelegate::populateVisitedLinksForWebView):
2981         * DumpRenderTree/win/HistoryDelegate.h: Added.
2982
2983         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2984         (LayoutTestController::removeAllVisitedLinks):
2985
2986 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2987
2988         Reviewed by Simon Hausmann.
2989
2990         [Qt] Implement support for setPOSIXLocale on Qt.
2991         https://bugs.webkit.org/show_bug.cgi?id=30268
2992
2993         * DumpRenderTree/qt/DumpRenderTree.cpp:
2994         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2995         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2996         (LayoutTestController::setPOSIXLocale):
2997         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2998
2999 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3000
3001         Unreviewed, adding myself to reviewers list.
3002
3003         * Scripts/modules/committers.py:
3004
3005 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3006
3007         Reviewed by Mark Rowe.
3008
3009         Fix null assignment so root tests work again.
3010
3011         * Scripts/webkitdirs.pm:
3012
3013 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3014
3015         Reviewed by Simon Hausmann.
3016
3017         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3018         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3019         This is done in preparation of implementing missing features in DRT.
3020         No functionality changes made yet.
3021
3022         * DumpRenderTree/qt/DumpRenderTree.cpp:
3023         * DumpRenderTree/qt/DumpRenderTree.pro:
3024         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3025         (EventSender::EventSender):
3026         (EventSender::mouseDown):
3027         (EventSender::mouseUp):
3028         (EventSender::mouseMoveTo):
3029         (EventSender::leapForward):
3030         (EventSender::keyDown):
3031         (EventSender::contextClick):
3032         (EventSender::scheduleAsynchronousClick):
3033         (EventSender::frameUnderMouse):
3034         * DumpRenderTree/qt/EventSenderQt.h: Added.
3035         (EventSender::clearKillRing):
3036         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3037         (LayoutTestController::LayoutTestController):
3038         (LayoutTestController::reset):
3039         (LayoutTestController::processWork):
3040         (LayoutTestController::maybeDump):
3041         (LayoutTestController::waitUntilDone):
3042         (LayoutTestController::notifyDone):
3043         (LayoutTestController::windowCount):
3044         (LayoutTestController::clearBackForwardList):
3045         (LayoutTestController::dumpEditingCallbacks):
3046         (LayoutTestController::dumpResourceLoadCallbacks):
3047         (LayoutTestController::queueBackNavigation):
3048         (LayoutTestController::queueForwardNavigation):
3049         (LayoutTestController::queueLoad):
3050         (LayoutTestController::queueReload):
3051         (LayoutTestController::queueScript):
3052         (LayoutTestController::provisionalLoad):
3053         (LayoutTestController::timerEvent):
3054         (LayoutTestController::encodeHostName):
3055         (LayoutTestController::decodeHostName):
3056         (LayoutTestController::setJavaScriptProfilingEnabled):
3057         (LayoutTestController::setFixedContentsSize):
3058         (LayoutTestController::setPrivateBrowsingEnabled):
3059         (LayoutTestController::setPopupBlockingEnabled):
3060         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3061         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3062         (LayoutTestController::numberOfActiveAnimations):
3063         (LayoutTestController::disableImageLoading):
3064         (LayoutTestController::dispatchPendingLoadRequests):
3065         (LayoutTestController::setDatabaseQuota):
3066         (LayoutTestController::clearAllDatabases):
3067         (LayoutTestController::whiteListAccessFromOrigin):
3068         (LayoutTestController::waitForPolicyDelegate):
3069         (LayoutTestController::overridePreference):
3070         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3071         (LayoutTestController::isLoading):
3072         (LayoutTestController::setLoading):
3073         (LayoutTestController::shouldDumpAsText):
3074         (LayoutTestController::shouldDumpBackForwardList):
3075         (LayoutTestController::shouldDumpChildrenAsText):
3076         (LayoutTestController::shouldDumpDatabaseCallbacks):
3077         (LayoutTestController::shouldDumpStatusCallbacks):
3078         (LayoutTestController::shouldWaitUntilDone):
3079         (LayoutTestController::canOpenWindows):
3080         (LayoutTestController::shouldDumpTitleChanges):
3081         (LayoutTestController::waitForPolicy):
3082         (LayoutTestController::dumpAsText):
3083         (LayoutTestController::dumpChildFramesAsText):
3084         (LayoutTestController::dumpDatabaseCallbacks):
3085         (LayoutTestController::dumpStatusCallbacks):
3086         (LayoutTestController::setCanOpenWindows):
3087         (LayoutTestController::dumpBackForwardList):
3088         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3089         (LayoutTestController::display):
3090         (LayoutTestController::dumpTitleChanges):
3091         (LayoutTestController::dumpSelectionRect):
3092         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3093         (TextInputController::TextInputController):
3094         (TextInputController::doCommand):
3095         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3096         * DumpRenderTree/qt/WorkQueue.cpp:
3097         * DumpRenderTree/qt/WorkQueue.h:
3098         * DumpRenderTree/qt/WorkQueueItem.h:
3099         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3100         (findFrameNamed):
3101         (LoadItem::invoke):
3102         (ReloadItem::invoke):
3103         (ScriptItem::invoke):
3104         (BackForwardItem::invoke):
3105         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3106         * DumpRenderTree/qt/jsobjects.h:
3107
3108 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3109
3110         Not reviewed, adding myself to the list of reviewers.
3111
3112         * Scripts/modules/committers.py:
3113
3114 2009-10-13  Anders Carlsson  <andersca@apple.com>
3115
3116         Reviewed by Sam Weinig.
3117
3118         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3119
3120         Make the private browsing mode testable by the test plug-in.
3121
3122         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3123         (pluginGetProperty):
3124         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3125         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3126         (NPP_New):
3127         (NPP_SetValue):
3128
3129 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3130
3131         No review, just adding self to the list of reviewers.
3132
3133         * Scripts/modules/committers.py:
3134
3135 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3136
3137         Reviewed by Adam Roben.
3138
3139         Web Inspector: Use proper web view in inspector layout
3140         tests for windows.
3141
3142         https://bugs.webkit.org/show_bug.cgi?id=30298
3143
3144         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3145         (LayoutTestController::showWebInspector):
3146         (LayoutTestController::closeWebInspector):
3147         (LayoutTestController::evaluateInWebInspector):
3148
3149 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3150
3151         Reviewed by Sam Weinig.
3152
3153         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3154         https://bugs.webkit.org/show_bug.cgi?id=29841
3155
3156         * DumpRenderTree/mac/DumpRenderTree.mm:
3157         (resetDefaultsToConsistentValues):
3158         * DumpRenderTree/win/DumpRenderTree.cpp:
3159         (resetDefaultsToConsistentValues):
3160
3161 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3162
3163         Reviewed by Dimitri Glazkov.
3164
3165         Chromium Port - Windows
3166         https://bugs.webkit.org/show_bug.cgi?id=29969
3167
3168         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3169         * Scripts/webkitdirs.pm:
3170
3171 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3172
3173         Reviewed by Darin Adler.
3174
3175         jsc scripts cleanup and Qt/GTK fix
3176         https://bugs.webkit.org/show_bug.cgi?id=30288
3177
3178         Duplicated jscPath() moved to webkitdirs.pm.
3179         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3180         Configuration added (release/debug) to path for Qt-port on Windows.
3181
3182         * Scripts/run-javascriptcore-tests:
3183         * Scripts/run-jsc:
3184         * Scripts/run-sunspider:
3185         * Scripts/sunspider-compare-results:
3186         * Scripts/webkitdirs.pm:
3187
3188 2009-10-11  Adam Barth  <abarth@webkit.org>
3189
3190         Unreviewed.  Add Collin to committers.py.
3191
3192         * Scripts/modules/committers.py:
3193
3194 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3195
3196         wx build fix, add bindings to source/include dirs now that there are sources there.
3197
3198         * wx/build/settings.py:
3199
3200 2009-10-09  Mark Rowe  <mrowe@apple.com>
3201
3202         Reviewed by Brady Eidson.
3203
3204         Enable plug-in halting in DumpRenderTree.
3205
3206         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3207         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3208
3209         * DumpRenderTree/mac/DumpRenderTree.mm:
3210         (resetDefaultsToConsistentValues):
3211         * DumpRenderTree/mac/UIDelegate.mm:
3212         (-[UIDelegate webView:shouldHaltPlugin:]):
3213
3214 2009-10-08  Brady Eidson  <beidson@apple.com>
3215
3216         Reviewed by Dan Bernstein.
3217
3218         Ask the History Delegate to populate the visited links hash.
3219         <rdar://problem/7285293> and https://webkit.org/b/29904
3220
3221         Add the ability for LayoutTestController to clear all visited links.
3222         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3223
3224         * DumpRenderTree/LayoutTestController.cpp:
3225         (LayoutTestController::LayoutTestController):
3226         (removeAllVisitedLinksCallback):
3227         (LayoutTestController::staticFunctions):
3228         * DumpRenderTree/LayoutTestController.h:
3229         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3230         (LayoutTestController::removeAllVisitedLinks):
3231
3232         * DumpRenderTree/mac/HistoryDelegate.mm:
3233         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3234
3235         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3236         (LayoutTestController::removeAllVisitedLinks):
3237         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3238         (LayoutTestController::removeAllVisitedLinks):
3239         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3240         (LayoutTestController::removeAllVisitedLinks):
3241
3242
3243 2009-10-08  Daniel Bates  <dbates@webkit.org>
3244
3245         Reviewed by Adam Roben.
3246
3247         https://bugs.webkit.org/show_bug.cgi?id=30175
3248
3249         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3250         the OLE drag-and-drop return value like the function it emulates. Currently,
3251         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
3252         whether the drag-and-drop operation was successful or was cancelled.
3253
3254         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
3255         return value according to whether the drop operation was successful or not.
3256
3257         * DumpRenderTree/win/EventSender.cpp:
3258         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3259         (replaySavedEvents): Ditto.
3260         * DumpRenderTree/win/EventSender.h:
3261         * DumpRenderTree/win/UIDelegate.cpp:
3262         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3263
3264 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3265
3266         Reviewed by Xan Lopez.
3267
3268         [GTK] Added support for a parameter setting the button that was
3269         pressed in the mouseDown function.
3270         https://bugs.webkit.org/show_bug.cgi?id=30220
3271
3272         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3273
3274 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3275
3276         Reviewed by Xan Lopez.
3277
3278         [GTK] Added a line to the bottom of the expected result to match
3279         the output of the test.
3280         https://bugs.webkit.org/show_bug.cgi?id=30220
3281
3282         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3283         expected.txt:
3284
3285 2009-10-08  Adam Roben  <aroben@apple.com>
3286
3287         Use QueryInterface to get IWebInspectorPrivate
3288
3289         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3290         accessed in a more standard way
3291
3292         Reviewed by John Sullivan and Tim Hatcher.
3293
3294         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3295         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3296         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3297         to the IWebInspectorPrivate interface.
3298
3299 2009-10-07  Adam Roben  <aroben@apple.com>
3300
3301         Implement DRT support for origin whitelisting
3302
3303         Fixes <http://webkit.org/b/30185>.
3304
3305         Reviewed by Eric Seidel.
3306
3307         * DumpRenderTree/win/DumpRenderTree.cpp:
3308         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3309         whitelist, to match Mac DRT.
3310         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3311         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3312         IWebViewPrivate::whiteListAccessFromOrigin.
3313
3314 2009-10-07  Brady Eidson  <beidson@apple.com>
3315
3316         Reviewed by Darin Adler.
3317
3318         Send title changes to the global history delegate.
3319         <rdar://problem/7285293> and https://webkit.org/b/29904
3320
3321         * DumpRenderTree/mac/HistoryDelegate.mm:
3322         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3323
3324 2009-10-07  Adam Barth  <abarth@webkit.org>
3325
3326         Unreviewed.  Remove some folks from committers.py who were listed on
3327         the WebKit Team wiki page but who weren't actually listed as commit+.
3328         At some point, we should coorelate this list with the committers
3329         mailing list.
3330
3331         * Scripts/modules/committers.py:
3332
3333 2009-10-07  Adam Barth  <abarth@webkit.org>
3334
3335         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3336         the wiki into committers.py.
3337
3338         * Scripts/modules/committers.py:
3339
3340 2009-10-07  Adam Barth  <abarth@webkit.org>
3341
3342         Unreviewed.  Added Aaron Boodman to committers.py.
3343
3344         * Scripts/modules/committers.py:
3345
3346 2009-10-07  Evan Martin  <evan@chromium.org>
3347
3348         Reviewed by Darin Adler.
3349
3350         Add API to LayoutTestController for re/setting the system locale.
3351         https://bugs.webkit.org/show_bug.cgi?id=18994
3352
3353         * DumpRenderTree/LayoutTestController.cpp:
3354         (setLocaleCallback):
3355         (LayoutTestController::staticFunctions):
3356         (LayoutTestController::setLocale):
3357         * DumpRenderTree/LayoutTestController.h:
3358
3359 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3360
3361         Reviewed by Jan Alonzo.
3362
3363         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3364         https://bugs.webkit.org/show_bug.cgi?id=29689
3365
3366         Build fix by adding -lfontconfig for DumpRenderTree.
3367
3368         * GNUmakefile.am:
3369
3370 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3371
3372         Reviewed by Simon Hausmann.
3373
3374         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3375
3376         * Scripts/run-webkit-tests:
3377
3378 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3379
3380         Reviewed by Gustavo Noronha.
3381
3382         "delete" in EventSender is the backspace key, not the delete one.
3383
3384         * DumpRenderTree/gtk/EventSender.cpp:
3385         (keyDownCallback):
3386
3387 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3388
3389         Reviewed by Gustavo Noronha.
3390
3391         getChildrenWithRange expects as last parameter the end index, not
3392         the length of the range. Correct this and clarify the variable
3393         names to reflect how the code works.
3394
3395         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3396         (AccessibilityUIElement::getChildrenWithRange):
3397         (AccessibilityUIElement::getChildAtIndex):
3398
3399 2009-10-06  Mark Rowe  <mrowe@apple.com>
3400
3401         Reviewed by Simon Fraser.
3402
3403         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3404
3405         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3406         the fact we have already changed the working directory to the top of the open source tree.
3407
3408 2009-10-06  Julie Parent  <jparent@chromium.org>
3409
3410         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3411         rather than my committer email.
3412
3413         * Scripts/modules/committers.py:
3414
3415 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3416
3417         Reviewed by Eric Seidel.
3418
3419         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3420
3421         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3422         it after each layout test as it should do, making the DRT dump additional output
3423         for all of the subsequent layout tests.
3424
3425         * DumpRenderTree/qt/jsobjects.cpp:
3426         (LayoutTestController::reset):
3427
3428 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3429
3430         Reviewed by Simon Hausmann.
3431
3432         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3433         fast/dom/assign-to-window-status.html test, which is passing as a result.
3434
3435         https://bugs.webkit.org/show_bug.cgi?id=30127
3436
3437         * DumpRenderTree/qt/DumpRenderTree.cpp:
3438         (WebCore::DumpRenderTree::DumpRenderTree):
3439         (WebCore::DumpRenderTree::statusBarMessage):
3440         * DumpRenderTree/qt/DumpRenderTree.h:
3441         * DumpRenderTree/qt/jsobjects.h:
3442         (LayoutTestController::shouldDumpStatusCallbacks):
3443         (LayoutTestController::dumpStatusCallbacks):
3444
3445 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3446
3447         Reviewed by Simon Hausmann.
3448
3449         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3450         ignores the argument indicating which mouse button to trigger.
3451         https://bugs.webkit.org/show_bug.cgi?id=30048
3452
3453         This affects the fast/events/mouse-click-events.html layout test.
3454
3455         * DumpRenderTree/qt/jsobjects.cpp:
3456         (EventSender::mouseDown):
3457         (EventSender::mouseUp):
3458         * DumpRenderTree/qt/jsobjects.h:
3459
3460 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3461
3462         Reviewed by Simon Hausmann.
3463
3464         [Qt] Fix the EventSender::keyDown() implementation
3465         https://bugs.webkit.org/show_bug.cgi?id=30043
3466
3467         It should post both a key press event and a key release event,
3468         just like other ports do.
3469
3470         * DumpRenderTree/qt/jsobjects.cpp:
3471         (EventSender::keyDown):
3472
3473 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3474
3475         wx build fix. Add jpeg to the list of libs to link against.
3476
3477         * wx/build/settings.py:
3478
3479 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3480
3481         Reviewed by Simon Hausmann.
3482
3483         [Qt] EventSender::keyDown() cannot send function-key events.
3484         https://bugs.webkit.org/show_bug.cgi?id=30044
3485
3486         This affects the fast/events/keydown-function-keys.html layout test.
3487
3488         * DumpRenderTree/qt/jsobjects.cpp:
3489         (EventSender::keyDown):
3490
3491 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3492
3493         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3494         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3495
3496         * wx/build/settings.py:
3497         * wx/build/wxpresets.py:
3498
3499 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3500
3501         Reviewed by Timothy Hatcher.
3502
3503         Web Inspector: add testing harness for Web Inspector.
3504
3505         https://bugs.webkit.org/show_bug.cgi?id=30010
3506
3507         * DumpRenderTree/LayoutTestController.cpp:
3508         (showWebInspectorCallback):
3509         (closeWebInspectorCallback):
3510         (evaluateInWebInspectorCallback):
3511         (LayoutTestController::staticFunctions):
3512         * DumpRenderTree/LayoutTestController.h:
3513         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3514         (LayoutTestController::showWebInspector):
3515         (LayoutTestController::closeWebInspector):
3516         (LayoutTestController::evaluateInWebInspector):
3517         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3518         (LayoutTestController::showWebInspector):
3519         (LayoutTestController::closeWebInspector):
3520         (LayoutTestController::evaluateInWebInspector):
3521         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3522         (LayoutTestController::showWebInspector):
3523         (LayoutTestController::closeWebInspector):
3524         (LayoutTestController::evaluateInWebInspector):
3525         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3526         (LayoutTestController::showWebInspector):
3527         (LayoutTestController::closeWebInspector):
3528         (LayoutTestController::evaluateInWebInspector):
3529
3530 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3531
3532         Reviewed by Ariyha Hidayat.
3533
3534         Pass arguments to system() as a string instead of array
3535
3536         When passed as an array entries with a space fail to translate
3537         to two arguments to the child process, so instead of manually
3538         splitting all the entries in @buildArgs we pass the whole thing
3539         as a string instead.
3540
3541         * Scripts/webkitdirs.pm:
3542
3543 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3544
3545         Reviewed by David Levin.
3546
3547         check-webkit-style misses whitespace errors for operators:
3548         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3549         https://bugs.webkit.org/show_bug.cgi?id=30021
3550
3551         * Scripts/modules/cpp_style.py:
3552         Added the operators mentioned above to the same list as == and !=.
3553
3554 2009-10-02  Julie Parent  <jparent@chromium.org>
3555
3556         Unreviewed.
3557
3558         Adding myself and Ojan Vafai as committers, because we are committers.
3559
3560         * Scripts/modules/committers.py:
3561
3562 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3563
3564         Reviewed by Adam Roben.
3565
3566         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3567         this will help the patch merging process when TryBots are used.
3568
3569         * Scripts/svn-create-patch:
3570
3571 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3572
3573         Reviewed by Simon Hausmann.
3574
3575         [Qt] Implement layoutTestController.overridePreference().
3576         https://bugs.webkit.org/show_bug.cgi?id=29970
3577
3578         * DumpRenderTree/qt/DumpRenderTree.cpp:
3579         (WebCore::WebPage::WebPage):
3580         (WebCore::WebPage::resetSettings):
3581         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3582         * DumpRenderTree/qt/jsobjects.cpp:
3583         (LayoutTestController::reset):
3584         (LayoutTestController::setPrivateBrowsingEnabled):
3585         (LayoutTestController::setPopupBlockingEnabled):
3586         (LayoutTestController::overridePreference):
3587         * DumpRenderTree/qt/jsobjects.h:
3588
3589 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3590
3591         Reviewed by Oliver Hunt.
3592
3593         Turn on ENABLE_3D_CANVAS in TOT
3594         https://bugs.webkit.org/show_bug.cgi?id=29906
3595
3596         * Scripts/build-webkit:
3597
3598 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3599
3600         Rubberstamped by Simon Hausmann.
3601
3602         Enable HTTP tests for Qt
3603
3604         * Scripts/run-webkit-tests:
3605
3606 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3607
3608         Reviewed by Dimitri Glazkov.
3609
3610         build-webkit --chromium now also works on cygwin.
3611
3612         https://bugs.webkit.org/show_bug.cgi?id=29973
3613
3614         * Scripts/webkitdirs.pm:
3615
3616 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3617
3618         Reviewed by Simon Hausmann.
3619
3620         [Qt] Don't use TCmalloc in DumpRenderTree
3621         https://bugs.webkit.org/show_bug.cgi?id=27029
3622
3623         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3624
3625         * DumpRenderTree/qt/DumpRenderTree.pro:
3626
3627 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3628
3629         Reviewed by Simon Hausmann.
3630
3631         [Qt] Implement eventSender.scheduleAsynchronousClick().
3632
3633         https://bugs.webkit.org/show_bug.cgi?id=29931
3634
3635         * DumpRenderTree/qt/jsobjects.cpp:
3636         (EventSender::scheduleAsynchronousClick):
3637         * DumpRenderTree/qt/jsobjects.h:
3638
3639 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3640
3641         Reviewed by Simon Hausmann.
3642
3643         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3644         fast/events/open-window-from-another-frame.html from the Skipped list.
3645
3646         https://bugs.webkit.org/show_bug.cgi?id=29930
3647
3648         * DumpRenderTree/qt/jsobjects.cpp:
3649         (LayoutTestController::setPopupBlockingEnabled):
3650         * DumpRenderTree/qt/jsobjects.h:
3651
3652 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3653
3654         Unreviewed.
3655
3656         Added myself to the list of committers.
3657
3658         * Scripts/modules/committers.py:
3659
3660 2009-09-30  Eric Seidel  <eric@webkit.org>
3661
3662         No review, just adding Geoff to the list of reviewers.
3663
3664         * Scripts/modules/committers.py:
3665
3666 2009-09-30  Dan Bernstein  <mitz@apple.com>
3667
3668         Reviewed by Sam Weinig.
3669
3670         Added the WebKit Layout Tests fonts that are referenced in
3671         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3672
3673         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3674         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3675
3676 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3677
3678         Reviewed by David Kilzer.
3679
3680         Make sunspider scripts work on Windows platform.
3681         https://bugs.webkit.org/show_bug.cgi?id=29656
3682
3683         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3684         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3685         * Scripts/webkitdirs.pm: currentPerlPath() added.
3686
3687 2009-09-29  Brady Eidson  <beidson@apple.com>
3688
3689         Rubberstamped by Dan Bernstein.
3690
3691         Fix license and some sorting in new files.
3692
3693         * DumpRenderTree/mac/HistoryDelegate.h:
3694         * DumpRenderTree/mac/HistoryDelegate.mm: