b5c5c17044a9386ef5df83cfe1c3abe3361edb59
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
2
3         Reviewed by Eric Seidel.
4
5         [GTK] Moved the functions that are closing the result log of the
6         tests to the last line of the runTest function, this avoids
7         reporting crashes in the wrong test if there is a problem when
8         reseting the state after the test.
9
10         * DumpRenderTree/gtk/DumpRenderTree.cpp:
11         (dump):
12         (runTest):
13
14 2009-11-30  Sam Weinig  <sam@webkit.org>
15
16         Reviewed by Geoffrey Garen.
17
18         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
19         fast/js/date-proto-generic-invocation breaks another test
20
21         Don't cache JSClassRefs, a change to the prototype chain will
22         last between tests.
23
24         * DumpRenderTree/AccessibilityController.cpp:
25         (AccessibilityController::getJSClass):
26         * DumpRenderTree/GCController.cpp:
27         (GCController::getJSClass):
28         * DumpRenderTree/GCController.h:
29         * DumpRenderTree/LayoutTestController.cpp:
30         (LayoutTestController::getJSClass):
31
32 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
33
34         Reviewed by Alexey Proskuryakov.
35
36         Update pywebsocket to 0.4.2.1.
37         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
38         https://bugs.webkit.org/show_bug.cgi?id=31976
39
40         * pywebsocket/mod_pywebsocket/standalone.py:
41         * pywebsocket/setup.py:
42
43 2009-11-30  Adam Barth  <abarth@webkit.org>
44
45         Reviewed by Eric Seidel.
46
47         [bzt] Generate pass messages for style-queue
48         https://bugs.webkit.org/show_bug.cgi?id=31995
49
50         With this change, the style-queue posts "pass" messages to bugs as
51         well.  Also, added more information to the state store w.r.t. passing
52         and failing.
53
54         * Scripts/modules/commands/queues.py:
55         * Scripts/modules/patchcollection.py:
56
57 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
58
59         Reviewed by Simon Fraser.
60
61         Check for WEBKIT_TESTFONTS environment variable in
62         run-webkit-tests, for GTK+, to have a more prominent error
63         message.
64
65         * Scripts/run-webkit-tests:
66
67 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
68
69         Reviewed by Dimitri Glazkov.
70
71         update-webkit --chromium forces gclient sync
72
73         https://bugs.webkit.org/show_bug.cgi?id=31967
74
75         * Scripts/update-webkit-chromium:
76
77 2009-11-29  Eric Seidel  <eric@webkit.org>
78
79         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
80
81         * Scripts/modules/committers.py:
82
83 2009-11-29  Eric Seidel  <eric@webkit.org>
84
85         No review, just adding missing svn property.
86
87         Set svn:executable property on new scripts.
88         These were added by commit-queue commits, but the executable
89         property was lost due to a bug in svn-apply:
90         https://bugs.webkit.org/show_bug.cgi?id=27204
91
92         * Scripts/update-webkit-chromium: Added property svn:executable.
93         * Scripts/validate-committer-lists: Added property svn:executable.
94
95 2009-11-29  Eric Seidel  <eric@webkit.org>
96
97         Reviewed by Adam Barth.
98
99         Need a way to validate that committers.py includes all committers/reviewers
100         https://bugs.webkit.org/show_bug.cgi?id=30970
101
102         Add a script which knows how to compare our public committer/reviewer
103         lists and show discrepancies between them.
104
105         Validates mailing lists vs. committers.py:
106         - committers.py committers missing from webkit-committers@lists
107         - webkit-committers@lists members missing from committers.py
108         - committers.py reviewers missing from webkit-reviewers@lists
109         - webkit-reviewers@lists members missing from committers.py
110         - webkit-reviewers@lists members missing from committers.py reviewer list
111
112         Validates committers.py vs. trunk/ SVN history:
113         - committers who have not committed in over a year
114         - SVN committers missing from committers.py
115         - committers.py members who have no record in SVN.
116
117         All of these lists still show "false positives" until a few more committers.py updates are made, like:
118         https://bugs.webkit.org/show_bug.cgi?id=31366
119
120         * Scripts/validate-committer-lists: Added.
121
122 2009-11-28  Adam Barth  <abarth@webkit.org>
123
124         Reviewed by Eric Seidel.
125
126         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
127         https://bugs.webkit.org/show_bug.cgi?id=31950
128
129         Now we cache the last status that we get back from QueueStatusServer.
130         Eventually we'll have to do something more fancy if we want to support
131         a "try again" button on QueueStatusServer, but we can cross that bridge
132         when we come to it.
133
134         * Scripts/modules/patchcollection.py:
135
136 2009-11-28  Adam Barth  <abarth@webkit.org>
137
138         Reviewed by Eric Seidel.
139
140         StyleQueue scans ~100 bug pages every 5 minutes
141         https://bugs.webkit.org/show_bug.cgi?id=31947
142
143         Instead of getting the pending-review attachment ids by scanning each
144         bug (which results in a network request), we should just get them all
145         from webkit.org/pending-review in one shot.
146
147         * Scripts/modules/bugzilla.py:
148         * Scripts/modules/bugzilla_unittest.py:
149         * Scripts/modules/commands/queries.py:
150         * Scripts/modules/commands/queries_unittest.py:
151         * Scripts/modules/commands/queues.py:
152         * Scripts/modules/mock_bugzillatool.py:
153         * Scripts/modules/patchcollection.py:
154
155 2009-11-28  Adam Barth  <abarth@webkit.org>
156
157         Reviewed by Eric Seidel.
158
159         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
160         https://bugs.webkit.org/show_bug.cgi?id=31952
161
162         The mailing list is open for anyone to subscribe.
163
164         * Scripts/modules/bugzilla.py:
165         * Scripts/modules/commands/queues.py:
166
167 2009-11-28  Adam Barth  <abarth@webkit.org>
168
169         Reviewed by Eric Seidel.
170
171         [bzt] style-queue should report style errors to bugzilla
172         https://bugs.webkit.org/show_bug.cgi?id=31945
173
174         Currently, we're just logging the style errors locally.  With this
175         patch we'll actually log the errors to bugzilla.  Note: I plan to run
176         with the "local-only" logging during development.
177
178         * Scripts/modules/commands/queues.py:
179         * Scripts/modules/scm.py:
180
181 2009-11-28  Adam Barth  <abarth@webkit.org>
182
183         Reviewed by Eric Seidel.
184
185         [bzt] style-queue shouldn't reject patches from the commit-queue
186         https://bugs.webkit.org/show_bug.cgi?id=31944
187
188         Currently the style-queue subprocess gets confused and thinks its the
189         commit-queue.  If the patch has an error, it rejects it from the
190         commit-queue.  Instead, we should have style-queue specific logic.
191         This patch doesn't add that logic, but it gives us a callback we can
192         use to add that logic.
193
194         * Scripts/modules/buildsteps.py:
195         * Scripts/modules/commands/queues.py:
196         * Scripts/modules/landingsequence.py:
197
198 2009-11-27  Adam Barth  <abarth@webkit.org>
199
200         Rubber stamped by Eric Seidel.
201
202         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
203
204         * CommitQueueStatus: Removed.
205         * CommitQueueStatus/app.yaml: Removed.
206         * CommitQueueStatus/filters: Removed.
207         * CommitQueueStatus/filters/__init__.py: Removed.
208         * CommitQueueStatus/filters/webkit_extras.py: Removed.
209         * CommitQueueStatus/index.html: Removed.
210         * CommitQueueStatus/index.yaml: Removed.
211         * CommitQueueStatus/queue_status.py: Removed.
212         * CommitQueueStatus/stylesheets: Removed.
213         * CommitQueueStatus/stylesheets/main.css: Removed.
214         * CommitQueueStatus/update_status.html: Removed.
215         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
216
217 2009-11-27  Adam Barth  <abarth@webkit.org>
218
219         Reviewed by Eric Seidel.
220
221         style-queue should only process each patch once
222         https://bugs.webkit.org/show_bug.cgi?id=31939
223
224         Actually address reviewer comments!
225
226         * Scripts/bugzilla-tool:
227
228 2009-11-27  Adam Barth  <abarth@webkit.org>
229
230         Reviewed by Eric Seidel.
231
232         [bzt] style-queue fails to apply a bunch of patches for no reason
233         https://bugs.webkit.org/show_bug.cgi?id=31942
234
235         By passing --non-interactive to check-style, we convince check-style
236         to pass --force to svn-apply, which lets it apply more patches.
237
238         * Scripts/modules/commands/queues.py:
239
240 2009-11-27  Adam Barth  <abarth@webkit.org>
241
242         Reviewed by Eric Seidel.
243
244         [bzt] Support --status-host in style-queue
245         https://bugs.webkit.org/show_bug.cgi?id=31941
246
247         * Scripts/modules/commands/queues.py:
248         * Scripts/modules/statusbot.py:
249
250 2009-11-27  Adam Barth  <abarth@webkit.org>
251
252         Reviewed by Eric Seidel.
253
254         style-queue should only process each patch once
255         https://bugs.webkit.org/show_bug.cgi?id=31939
256
257         Before processing a patch, the try-queues now ask the web service
258         whether they have already processed the patch.  This is an initial cut
259         of this functionality.  I expect we're make it richer over time.
260
261         * Scripts/bugzilla-tool:
262         * Scripts/modules/commands/queues.py:
263         * Scripts/modules/patchcollection.py:
264
265 2009-11-27  Adam Barth  <abarth@webkit.org>
266
267         Reviewed by Eric Seidel.
268
269         PatchStatus does not return status
270         https://bugs.webkit.org/show_bug.cgi?id=31938
271
272         We need to parse attachment_id as an int.  Otherwise, we can't find
273         anything in the datastore.
274
275         * CommitQueueStatus/queue_status.py:
276
277 2009-11-27  Adam Barth  <abarth@webkit.org>
278
279         Reviewed by Eric Seidel.
280
281         Make commit-queue status not throw an exception where there is not
282         status
283         https://bugs.webkit.org/show_bug.cgi?id=31936
284
285         We need to actually fetch the results of the query to see what's in the
286         datastore.
287
288         * CommitQueueStatus/queue_status.py:
289
290 2009-11-27  Adam Barth  <abarth@webkit.org>
291
292         Reviewed by Eric Seidel.
293
294         [bzt] unit test ApplyPatches and ApplyAttachment
295         https://bugs.webkit.org/show_bug.cgi?id=31935
296
297         * Scripts/modules/commands/download.py:
298         * Scripts/modules/commands/download_unittest.py:
299
300 2009-11-27  Adam Barth  <abarth@webkit.org>
301
302         Reviewed by Eric Seidel.
303
304         [bzt] Unit test download commands
305         https://bugs.webkit.org/show_bug.cgi?id=31923
306
307         Adds download_unittest and fixes a bug found while testing.
308
309         * Scripts/modules/commands/commandtest.py:
310         * Scripts/modules/commands/download.py:
311             Fixed a bug where we'd throw an error because [].append returns
312             None.
313         * Scripts/modules/commands/download_unittest.py: Added.
314         * Scripts/modules/mock_bugzillatool.py:
315         * Scripts/run-webkit-unittests:
316
317 2009-11-27  Adam Barth  <abarth@webkit.org>
318
319         Unreviewed "build" fix found while writing unit tests.
320
321         * Scripts/modules/commands/download.py:
322
323 2009-11-27  Adam Barth  <abarth@webkit.org>
324
325         Reviewed by Eric Seidel.
326
327         [bzt] Kill WebKitLandingScripts
328         https://bugs.webkit.org/show_bug.cgi?id=31904
329
330         Step 6: Kill the rest.
331
332         * Scripts/modules/buildsteps.py:
333         * Scripts/modules/commands/download.py:
334         * Scripts/modules/commands/queries.py:
335         * Scripts/modules/commands/upload.py:
336         * Scripts/modules/landingsequence.py:
337         * Scripts/modules/scm.py:
338         * Scripts/modules/webkitlandingscripts.py: Removed.
339
340 2009-11-27  Adam Barth  <abarth@webkit.org>
341
342         Reviewed by Eric Seidel.
343
344         [bzt] Unit test upload commands
345         https://bugs.webkit.org/show_bug.cgi?id=31903
346
347         Adds unit tests for all but two of the upload commands.  The two
348         remaining ones are more difficult.  I'll return to them later.  The
349         goal of these tests is just to run the commands.  We can test more
350         detailed behavior later.
351
352         * Scripts/modules/commands/commandtest.py:
353         * Scripts/modules/commands/upload.py:
354         * Scripts/modules/commands/upload_unittest.py:
355         * Scripts/modules/mock.py: Added.
356         * Scripts/modules/mock_bugzillatool.py:
357
358 2009-11-26  Adam Barth  <abarth@webkit.org>
359
360         Reviewed by Eric Seidel.
361
362         [bzt] Kill WebKitLandingScripts
363         https://bugs.webkit.org/show_bug.cgi?id=31904
364
365         Step 5: Kill run_and_throw_if_fail.
366
367         * Scripts/modules/buildsteps.py:
368         * Scripts/modules/processutils.py: Added.
369         * Scripts/modules/webkitlandingscripts.py:
370
371 2009-11-26  Adam Barth  <abarth@webkit.org>
372
373         Reviewed by Eric Seidel.
374
375         [bzt] Kill WebKitLandingScripts
376         https://bugs.webkit.org/show_bug.cgi?id=31904
377
378         Step 4: Kill run_webkit_script.
379
380         * Scripts/modules/buildsteps.py:
381         * Scripts/modules/commands/download.py:
382         * Scripts/modules/webkitlandingscripts.py:
383
384 2009-11-26  Adam Barth  <abarth@webkit.org>
385
386         Reviewed by Eric Seidel.
387
388         [bzt] Kill WebKitLandingScripts
389         https://bugs.webkit.org/show_bug.cgi?id=31904
390
391         Step 3: Kill build_webkit.
392
393         * Scripts/modules/buildsteps.py:
394         * Scripts/modules/landingsequence.py:
395         * Scripts/modules/webkitlandingscripts.py:
396
397 2009-11-26  Adam Barth  <abarth@webkit.org>
398
399         Reviewed by Eric Seidel.
400
401         [bzt] Kill WebKitLandingScripts
402         https://bugs.webkit.org/show_bug.cgi?id=31904
403
404         Step 2: Kill ensure_builders_are_green.
405
406         * Scripts/modules/buildsteps.py:
407         * Scripts/modules/commands/download.py:
408         * Scripts/modules/landingsequence.py:
409         * Scripts/modules/webkitlandingscripts.py:
410
411 2009-11-26  Adam Barth  <abarth@webkit.org>
412
413         Reviewed by Eric Seidel.
414
415         [bzt] Kill WebKitLandingScripts
416         https://bugs.webkit.org/show_bug.cgi?id=31904
417
418         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
419
420         * Scripts/bugzilla-tool:
421         * Scripts/modules/buildsteps.py: Added.
422         * Scripts/modules/commands/download.py:
423         * Scripts/modules/landingsequence.py:
424         * Scripts/modules/webkitlandingscripts.py:
425
426 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
427
428         Reviewed by Adam Barth.
429
430         Remove directory prefixes from linux commands
431
432         SCM unittests can cause errors on some systems if we use absolute reference to
433         the commands, so directory prefixes have been removed.
434
435         * Scripts/modules/scm_unittest.py:
436
437 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
438
439         Reviewed by Kenneth Rohde Christiansen.
440
441         Link DumpRenderTree to the Qt Ui Tools
442         https://bugs.webkit.org/show_bug.cgi?id=31203
443
444         Implement QWebPage::createPlugin using the Qt Ui Tools
445         to be able to create classes like QProgressBar from within
446         the <object></object> tags This is required for the
447         new automatic test of Qt Plugins.
448
449         * DumpRenderTree/qt/DumpRenderTree.cpp:
450         (WebCore::WebPage::createPlugin):
451         * DumpRenderTree/qt/DumpRenderTree.h:
452         * DumpRenderTree/qt/DumpRenderTree.pro:
453
454 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
455
456         Reviewed by Eric Seidel.
457
458         Update pywebsocket to 0.4.2
459
460         Update pywebsocket to 0.4.2
461         https://bugs.webkit.org/show_bug.cgi?id=31861
462
463         * pywebsocket/example/echo_client.py:
464         * pywebsocket/example/echo_wsh.py:
465         * pywebsocket/mod_pywebsocket/__init__.py:
466         * pywebsocket/mod_pywebsocket/dispatch.py:
467         * pywebsocket/mod_pywebsocket/msgutil.py:
468         * pywebsocket/mod_pywebsocket/standalone.py:
469         * pywebsocket/setup.py:
470         * pywebsocket/test/test_dispatch.py:
471         * pywebsocket/test/test_msgutil.py:
472
473 2009-11-25  Adam Barth  <abarth@webkit.org>
474
475         Reviewed by Eric Seidel.
476
477         Add unit test for mark-fixed
478         https://bugs.webkit.org/show_bug.cgi?id=31896
479
480         * Scripts/modules/commands/commandtest.py: Added.
481         * Scripts/modules/commands/queries_unittest.py:
482         * Scripts/modules/commands/upload_unittest.py: Added.
483         * Scripts/modules/mock_bugzillatool.py:
484         * Scripts/run-webkit-unittests:
485
486 2009-11-25  Adam Barth  <abarth@webkit.org>
487
488         Reviewed by Eric Seidel.
489
490         bugzilla-tool should have a mark-fixed command
491         https://bugs.webkit.org/show_bug.cgi?id=31853
492
493         Pretty simple stuff.
494
495         * Scripts/modules/commands/upload.py:
496
497 2009-11-25  Eric Seidel  <eric@webkit.org>
498
499         Reviewed by Adam Barth.
500
501         'bugzilla-tool help' should only show common commands like how 'git help' does
502         https://bugs.webkit.org/show_bug.cgi?id=31772
503
504         I also took this opportunity to make 'help' a real Command.
505         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
506
507         * Scripts/bugzilla-tool:
508          - change should_show_command_help to should_show_in_main_help
509         * Scripts/modules/commands/download.py:
510          - Mark commands as being shown in main help or not.
511          - show_in_main_help = False is not required (default is false),
512            but it seemed to make the commands more self-documenting.
513         * Scripts/modules/commands/queries.py: ditto
514         * Scripts/modules/commands/queues.py: ditto
515         * Scripts/modules/commands/upload.py: ditto
516         * Scripts/modules/multicommandtool.py:
517          - Make Command hold a pointer to tool in self.tool.  Most Command
518            subclasses do not take advantage of this yet, but it was required
519            for HelpCommand to be able to reach the tool from _help_epilog().
520          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
521          - Move MultiCommandTool._help_epilog to Command._help_epilog
522          - Move "help" logic into HelpCommand.execute()
523          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
524         * Scripts/modules/multicommandtool_unittest.py:
525          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
526
527 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
528
529         Reviewed by Dan Bernstein.
530         
531         Patch by Mark Rowe.
532
533         The buildbots are failing on Windows because when they were upgraded
534         to 4.0.4, Apple Application Support was not in their path. Add it to
535         the path to fix the buildots.
536
537         * Scripts/webkitdirs.pm:
538
539 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
540
541         Reviewed by David Kilzer.
542
543         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
544         https://bugs.webkit.org/show_bug.cgi?id=31799
545
546         * Scripts/run-webkit-tests: Fixed.
547
548 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
549
550         Reviewed by Eric Seidel.
551
552         Change run_command to give back stderr by default
553         https://bugs.webkit.org/show_bug.cgi?id=31734
554
555         Change run_command to give back stderr by default.
556         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
557         Change the related unittest call.
558
559         * Scripts/modules/scm.py:
560         * Scripts/modules/scm_unittest.py:
561
562 2009-11-25  Eric Seidel  <eric@webkit.org>
563
564         Reviewed by Adam Barth.
565
566         Centralize required argument parsing in Command
567         https://bugs.webkit.org/show_bug.cgi?id=31872
568
569         * Scripts/modules/commands/download.py: remove custom required arg message.
570         * Scripts/modules/commands/upload.py: ditto.
571         * Scripts/modules/multicommandtool.py:
572          - Add _parse_required_arguments.
573          - Pass program name off to OptionParser.
574          - Add name() for access to tool name.
575          - Add check_arguments_and_execute and make it return a return code.
576          - Replace a couple uses of + with %.
577         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
578
579 2009-11-25  Eric Seidel  <eric@webkit.org>
580
581         Reviewed by Adam Barth.
582
583         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
584         https://bugs.webkit.org/show_bug.cgi?id=31870
585
586         * Scripts/modules/commands/queries_unittest.py: Use the new class.
587         * Scripts/modules/multicommandtool_unittest.py: Ditto.
588         * Scripts/modules/outputcapture.py: Added.
589
590 2009-11-24  Dmitry Titov  <dimich@chromium.org>
591
592         Reviewed by Eric Seidel.
593
594         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
595         https://bugs.webkit.org/show_bug.cgi?id=31444
596
597         * Scripts/build-webkit:
598
599 2009-11-24  Chris Marrin  <cmarrin@apple.com>
600
601         Reviewed by Simon Fraser.
602
603         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
604         https://bugs.webkit.org/show_bug.cgi?id=27314
605         
606         Now the script allows the directories with these tests to be included on all
607         platforms but Mac, where they behave the same as always. For all other platforms
608         the tests need to be excluded using the Skipped files, which is currently done
609         for all platforms (including win since we're not turned on yet)
610
611         * Scripts/webkitdirs.pm:
612
613 2009-11-24  Eric Seidel  <eric@webkit.org>
614
615         Reviewed by Adam Barth.
616
617         queries_unittest.py should test command output
618         https://bugs.webkit.org/show_bug.cgi?id=31845
619
620         * Scripts/modules/commands/queries_unittest.py:
621          - Capture stdout and stderr and compare with expected strings.
622
623 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
624
625         No Review.
626
627         Fix spelling error ("depenedencies").
628
629         * Scripts/build-webkit:
630
631 2009-11-24  Mark Rowe  <mrowe@apple.com>
632
633         Land the configuration that includes the two debug GTK Linux builders.
634
635         * BuildSlaveSupport/build.webkit.org-config/config.json:
636
637 2009-11-24  David Kilzer  <ddkilzer@apple.com>
638
639         <http://webkit.org/b/31840> bisect-builds broke after r50080
640
641         Reviewed by Dan Bernstein.
642
643         * Scripts/bisect-builds:
644         (mountAndRunNightly): Switched back to using backticks to run
645         the hdiutil command since exec() will terminate the existing
646         script, which is not what we want.  Store the output of
647         File::Spec->devnull() in a variable for use in the hdiutil
648         detach commands.
649
650 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
651
652         Reviewed by Kenneth Rohde Christiansen.
653
654         Include "config.h" to meet Coding Style Guidelines
655         https://bugs.webkit.org/show_bug.cgi?id=31792
656
657         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
658         * DumpRenderTree/qt/jsobjects.cpp:
659         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
660
661 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
662
663         Reviewed by Oliver Hunt.
664
665         Implement new required function to pass test we used to pass. This
666         change is required since r51294.
667
668         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
669         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
670
671 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
672
673         Reviewed by Kenneth Rohde Christiansen.
674
675         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
676         https://bugs.webkit.org/show_bug.cgi?id=31775
677
678         LayoutTestController::dumpBackForwardList() should work with local URLs
679         as well as with normal URLs (in http tests for instance).
680         Currently it does not output the latter properly.
681
682         Unskip a bunch of passing http/navigation tests.
683
684         * DumpRenderTree/qt/DumpRenderTree.cpp:
685         (WebCore::dumpHistoryItem):
686
687 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
688
689         Reviewed by Oliver Hunt.
690
691         ARIA: support aria-flowto
692         https://bugs.webkit.org/show_bug.cgi?id=31762
693
694         * DumpRenderTree/AccessibilityUIElement.cpp:
695         (ariaFlowToElementAtIndexCallback):
696         (AccessibilityUIElement::getJSClass):
697         * DumpRenderTree/AccessibilityUIElement.h:
698         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
699         (AccessibilityUIElement::ariaFlowToElementAtIndex):
700         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
701         (AccessibilityUIElement::ariaFlowToElementAtIndex):
702         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
703         (AccessibilityUIElement::ariaFlowToElementAtIndex):
704
705 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
706
707         Reviewed by Kenneth Christiansen.
708
709         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
710         https://bugs.webkit.org/show_bug.cgi?id=31638
711
712         Unfreeze WorkQueue after each test execution.
713
714         * DumpRenderTree/qt/DumpRenderTree.cpp:
715         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
716
717 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
718
719         Reviewed by Adam Barth.
720
721         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
722         for localhost and 127.0.0.1.
723         https://bugs.webkit.org/show_bug.cgi?id=31783
724
725         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
726
727         * DumpRenderTree/qt/DumpRenderTree.cpp:
728         (WebCore::NetworkAccessManager::NetworkAccessManager):
729         (WebCore::NetworkAccessManager::sslErrorsEncountered):
730         (WebCore::WebPage::WebPage):
731         * DumpRenderTree/qt/DumpRenderTree.h:
732
733 2009-11-22  Chris Evans  <cevans@chromium.org>
734
735         Reviewed by Adam Barth.
736
737         Disable access to file:/// directory listings
738         https://bugs.webkit.org/show_bug.cgi?id=31329
739
740         Implemented setAllowUniversalAccessFromFileURLs to support testing of
741         file URL security.
742
743         * DumpRenderTree/LayoutTestController.cpp:
744         (setAllowUniversalAccessFromFileURLsCallback):
745         (LayoutTestController::staticFunctions):
746         * DumpRenderTree/LayoutTestController.h:
747         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
748         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
749         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
750         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
751         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
752         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
753         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
754         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
755
756 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
757
758         Reviewed by Kenneth Rohde Christiansen.
759
760         [Qt] Fix the timeout of fast/frames/frame-navigation.html
761         https://bugs.webkit.org/show_bug.cgi?id=31638
762
763         The test is timeouting, because it uses the WorkQueue to load a document in one
764         of the child frames and once the loading is finished, the DRT does not dump the
765         tree. This is because it waits for the QWebFrame::loadFinished() signal from
766         the main frame, while it should connect to QWebPage::loadFinished().
767
768         * DumpRenderTree/qt/DumpRenderTree.cpp:
769         (WebCore::DumpRenderTree::DumpRenderTree):
770
771 2009-11-21  Eric Seidel  <eric@webkit.org>
772
773         Reviewed by Adam Barth.
774
775         bugzilla-tool --help spews way too much text
776         https://bugs.webkit.org/show_bug.cgi?id=31771
777
778         * Scripts/bugzilla-tool:
779          - Remove self.cached_scm initialization hack.
780         * Scripts/modules/buildbot.py:
781          - Make default_host accessible to callers.
782         * Scripts/modules/commands/download.py:
783          - Phrase help for all commands consistently and remove spurious help text punctuation.
784         * Scripts/modules/commands/queries.py: Ditto.
785         * Scripts/modules/commands/queues.py: Ditto.
786         * Scripts/modules/commands/upload.py: Ditto.
787         * Scripts/modules/multicommandtool.py:
788          - Add HelpPrintingOptionParser.format_epilog to replace
789            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
790            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
791          - Make --help only show a list of commands like "svn help" and "git help" do --
792            previously --help was listing all commands and options.
793          - Sort list of commands alphabetically.
794
795 2009-11-21  Eric Seidel  <eric@webkit.org>
796
797         No review.  Fixing a typo from the previous patch for bug 31767.
798
799         AbstractQueue.run_bugzilla_tool throws an exception
800         https://bugs.webkit.org/show_bug.cgi?id=31769
801
802         * Scripts/modules/commands/queues.py:
803
804 2009-11-21  Eric Seidel  <eric@webkit.org>
805
806         Reviewed by Adam Barth.
807
808         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
809         https://bugs.webkit.org/show_bug.cgi?id=31767
810
811         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
812         Since we don't have a good way to test BugzillaTool pieces, I've
813         left out a test for now.
814
815         * Scripts/bugzilla-tool:
816          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
817         * Scripts/modules/commands/queues.py:
818          - Use tool.path() instead of __file__.
819         * Scripts/modules/multicommandtool.py:
820          - Add a new path() method to MultiComandTool.
821         * Scripts/modules/multicommandtool_unittest.py:
822          - Provide a path() method.  Little point in testing this mock implementation.
823
824 2009-11-21  Adam Barth  <abarth@webkit.org>
825
826         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
827         WebKitTools.
828
829         * Scripts/modules/commands/download.py:
830
831 2009-11-21  Adam Barth  <abarth@webkit.org>
832
833         Reviewed by Eric Seidel.
834
835         Convert check-style to use LandingSequence
836         https://bugs.webkit.org/show_bug.cgi?id=31763
837
838         Instead of manipulating the working copy by hand, we should use the
839         LandingSequence in CheckStyle.  This will make this code eaiser to
840         test.
841
842         * Scripts/modules/commands/download.py:
843
844 2009-11-20  Adam Barth  <abarth@webkit.org>
845
846         Reviewed by Eric Seidel.
847
848         Unit test query commands
849         https://bugs.webkit.org/show_bug.cgi?id=31755
850
851         These tests are pretty rough, but hopefully they'll grow.
852
853         * Scripts/modules/commands/queries_unittest.py: Added.
854         * Scripts/modules/mock_bugzillatool.py: Added.
855         * Scripts/run-webkit-unittests:
856
857 2009-11-20  Eric Seidel  <eric@webkit.org>
858
859         Reviewed by Adam Barth.
860
861         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
862         https://bugs.webkit.org/show_bug.cgi?id=31758
863
864         * Scripts/modules/multicommandtool.py:
865          - Allow passing of explicit commands to MultiCommandTool.__init__
866         * Scripts/modules/multicommandtool_unittest.py:
867          - Use new Command.name naming system.
868          - Test Command auto-discovery.
869         * Scripts/modules/workqueue.py:
870          - bug_id no longer exists, use patch['bug_id'] instead.
871         * Scripts/modules/workqueue_unittest.py:
872          - WorkQueues require names now.
873          - should_proceed_with_work_item must return a patch object.
874
875 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
876
877         Reviewed by Beth Dakin.
878
879         WAI-ARIA: add support for aria-owns
880         https://bugs.webkit.org/show_bug.cgi?id=31702
881
882         * DumpRenderTree/AccessibilityUIElement.cpp:
883         (ariaOwnsElementAtIndexCallback):
884         (AccessibilityUIElement::getJSClass):
885         * DumpRenderTree/AccessibilityUIElement.h:
886         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
887         (AccessibilityUIElement::ariaOwnsElementAtIndex):
888         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
889         (AccessibilityUIElement::ariaOwnsElementAtIndex):
890         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
891         (AccessibilityUIElement::ariaOwnsElementAtIndex):
892
893 2009-11-20  Eric Seidel  <eric@webkit.org>
894
895         Reviewed by Adam Barth.
896
897         Fix exception thrown when running the commit-queue.
898
899         * Scripts/modules/statusbot.py: patch is optional.
900         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
901
902 2009-11-20  Eric Seidel  <eric@webkit.org>
903
904         Reviewed by Adam Barth.
905
906         Teach the StatusBot how to support more than just the commit-queue
907         https://bugs.webkit.org/show_bug.cgi?id=31754
908
909         * Scripts/modules/workqueue.py: Another typo.
910
911 2009-11-20  Eric Seidel  <eric@webkit.org>
912
913         Reviewed by Adam Barth.
914
915         Teach the StatusBot how to support more than just the commit-queue
916         https://bugs.webkit.org/show_bug.cgi?id=31754
917
918         * Scripts/modules/commands/queues.py: Fix silly typo.
919
920 2009-11-20  Eric Seidel  <eric@webkit.org>
921
922         Reviewed by Adam Barth.
923
924         Teach the StatusBot how to support more than just the commit-queue
925         https://bugs.webkit.org/show_bug.cgi?id=31754
926
927         * CommitQueueStatus/index.yaml:
928          - Add indices required for the new queries.
929         * CommitQueueStatus/queue_status.py:
930          - Add a patch-status page and move update_status to update-status.
931          - Only display "commit-queue" status records for the commit-queue.
932          - Add support for a queue_name property on status records.
933          - Fix _int_from_request to actually work.
934         * CommitQueueStatus/update_status.html:
935          - Add support for a queue_name on status records.
936          - Remove unused list of bug ids.
937          * Scripts/modules/commands/queues.py
938           - Make the queues pass the patch instead of the bug_id to StatusBot.
939         * Scripts/modules/statusbot.py:
940          - Support passing the queue_name to the status updates.
941          - Support fetching patch status with patch_status().
942         * Scripts/modules/workqueue.py:
943          - Pass the patch to the StatusBot instead of the bug_id.
944          - Let WorkQueues have a name.
945
946 2009-11-20  Adam Barth  <abarth@webkit.org>
947
948         Reviewed by Eric Seidel.
949
950         Move bugzilla-tool commands into their own file
951         https://bugs.webkit.org/show_bug.cgi?id=31752
952
953         This will let us write unit tests.
954
955         * Scripts/bugzilla-tool:
956         * Scripts/modules/commands/__init__.py: Added.
957         * Scripts/modules/commands/download.py: Added.
958         * Scripts/modules/commands/queries.py: Added.
959         * Scripts/modules/commands/queues.py: Added.
960         * Scripts/modules/commands/upload.py: Added.
961         * Scripts/modules/grammar.py: Added.
962
963 2009-11-20  Adam Barth  <abarth@webkit.org>
964
965         Reviewed by Eric Seidel.
966
967         BuildQueue should check if the tree is currently buildable
968         https://bugs.webkit.org/show_bug.cgi?id=31744
969
970         * Scripts/bugzilla-tool:
971         * Scripts/modules/landingsequence.py:
972         * Scripts/modules/webkitlandingscripts.py:
973
974 2009-11-20  Adam Barth  <abarth@webkit.org>
975
976         Reviewed by Eric Seidel.
977
978         Move prepare_clean_working_directory into the LandingSequence
979         https://bugs.webkit.org/show_bug.cgi?id=31743
980
981         * Scripts/bugzilla-tool:
982         * Scripts/modules/landingsequence.py:
983
984 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
985
986         Reviewed by Kenneth Rohde Christiansen.
987
988         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
989         https://bugs.webkit.org/show_bug.cgi?id=30460
990
991         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
992
993         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
994         (pluginInvoke):
995
996 2009-11-20  Adam Barth  <abarth@webkit.org>
997
998         Reviewed by Eric Seidel.
999
1000         Pass the port information to the child process
1001         https://bugs.webkit.org/show_bug.cgi?id=31736
1002
1003         We need to do this so the child process knows what to build!
1004
1005         * Scripts/bugzilla-tool:
1006         * Scripts/modules/landingsequence.py:
1007         * Scripts/modules/webkitport.py:
1008         * Scripts/modules/webkitport_unittest.py:
1009
1010 2009-11-20  Adam Barth  <abarth@webkit.org>
1011
1012         Reviewed by Eric Seidel.
1013
1014         Support Qt port in build-queue
1015         https://bugs.webkit.org/show_bug.cgi?id=31733
1016
1017         * Scripts/bugzilla-tool:
1018
1019 2009-11-20  Adam Barth  <abarth@webkit.org>
1020
1021         Reviewed by Eric Seidel.
1022
1023         Implement a build-queue
1024         https://bugs.webkit.org/show_bug.cgi?id=31725
1025
1026         Currently this just builds the first 10 patches in the review queue.
1027         We'll want to do something smarter soon.
1028
1029         * Scripts/bugzilla-tool:
1030
1031 2009-11-20  Adam Barth  <abarth@webkit.org>
1032
1033         Reviewed by Eric Seidel.
1034
1035         Make commit-queue and style-queue show up in help
1036         https://bugs.webkit.org/show_bug.cgi?id=31724
1037
1038         We need to store their names on their class to make these commands
1039         properly register themselves with MultiCommandTool.
1040
1041         * Scripts/bugzilla-tool:
1042
1043 2009-11-20  Adam Barth  <abarth@webkit.org>
1044
1045         Reviewed by Eric Seidel.
1046
1047         Implement bugzilla-tool build-attachment
1048         https://bugs.webkit.org/show_bug.cgi?id=31722
1049
1050         This command builds an attachment from bugzilla.  It leaves the built
1051         patch in the working copy.
1052
1053         * Scripts/bugzilla-tool:
1054         * Scripts/modules/landingsequence.py:
1055         * Scripts/modules/webkitlandingscripts.py:
1056
1057 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
1058
1059         Reviewed by Xan Lopez.
1060
1061         [GTK] DRT release event does not create the state correctly
1062         https://bugs.webkit.org/show_bug.cgi?id=31717
1063
1064         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1065
1066 2009-11-20  Eric Seidel  <eric@webkit.org>
1067
1068         Reviewed by Adam Barth.
1069
1070         MultiCommandTool should find Command objects automatically instead of with a manual list
1071         https://bugs.webkit.org/show_bug.cgi?id=31710
1072
1073         * Scripts/bugzilla-tool:
1074         * Scripts/modules/multicommandtool.py:
1075          - Use some wild python-fu to crawl all the known subclasses of Command.
1076
1077 2009-11-20  Adam Barth  <abarth@webkit.org>
1078
1079         Unreviewed "build" fix.  Added missing import.
1080
1081         * Scripts/bugzilla-tool:
1082
1083 2009-11-20  Adam Barth  <abarth@webkit.org>
1084
1085         Unreviewed "build" fix.  I failed to update LandingSequence.test
1086         properly.
1087
1088         * Scripts/modules/landingsequence.py:
1089
1090 2009-11-20  Adam Barth  <abarth@webkit.org>
1091
1092         Reviewed by Eric Seidel.
1093
1094         Create LandingSequence as the all-sing, all-dance landing class
1095         https://bugs.webkit.org/show_bug.cgi?id=31709
1096
1097         Client can inherit from this class to carefully control exactly which
1098         steps they wish to have happen in the landing sequence.
1099
1100         * Scripts/bugzilla-tool:
1101         * Scripts/modules/landingsequence.py: Added.
1102         * Scripts/modules/webkitlandingscripts.py: Added.
1103
1104 2009-11-19  Adam Barth  <abarth@webkit.org>
1105
1106         Reviewed by Eric Seidel.
1107
1108         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
1109         https://bugs.webkit.org/show_bug.cgi?id=31707
1110
1111         This is to help when we implement build-attachment.
1112
1113         * Scripts/bugzilla-tool:
1114
1115 2009-11-19  Adam Barth  <abarth@webkit.org>
1116
1117         Reviewed by Eric Seidel.
1118
1119         Support Qt port in bugzilla-tool
1120         https://bugs.webkit.org/show_bug.cgi?id=31701
1121
1122         Now we support building with Qt!
1123
1124         * Scripts/bugzilla-tool:
1125         * Scripts/modules/webkitport.py: Added.
1126         * Scripts/modules/webkitport_unittest.py: Added.
1127         * Scripts/run-webkit-unittests:
1128
1129 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
1130
1131         Reviewed by Adam Barth.
1132
1133         Remove inserting stderr into patch in bugzilla-tool
1134         https://bugs.webkit.org/show_bug.cgi?id=29914
1135
1136         Modify SCM python module's run_command function to avoid return of stderr
1137         by default, so stderr won't be inserted into the patches.
1138         Modify the related unit test.
1139
1140         * Scripts/modules/scm.py:
1141         * Scripts/modules/scm_unittest.py:
1142
1143 2009-11-19  Eric Seidel  <eric@webkit.org>
1144
1145         Reviewed by Adam Barth.
1146
1147         bugzilla-tool needs per-command help
1148         https://bugs.webkit.org/show_bug.cgi?id=31697
1149
1150         Added support for "bugzilla-tool help command-name"
1151         and a unit test to make sure it works.
1152
1153         * Scripts/modules/multicommandtool.py:
1154         * Scripts/modules/multicommandtool_unittest.py:
1155
1156 2009-11-19  Eric Seidel  <eric@webkit.org>
1157
1158         Reviewed by Adam Barth.
1159
1160         Move MultiCommandTool and Command into a separate file and add some basic unit tests
1161         https://bugs.webkit.org/show_bug.cgi?id=31695
1162
1163         * Scripts/bugzilla-tool:
1164         * Scripts/modules/multicommandtool.py: Added.
1165         * Scripts/modules/multicommandtool_unittest.py: Added.
1166         * Scripts/run-webkit-unittests:
1167
1168 2009-11-19  Eric Seidel  <eric@webkit.org>
1169
1170         No review, just adding a FIXME.
1171
1172         Split out command parsing and help printing from BugzillaTool
1173         https://bugs.webkit.org/show_bug.cgi?id=31688
1174
1175         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
1176
1177 2009-11-19  Eric Seidel  <eric@webkit.org>
1178
1179         Reviewed by Adam Barth.
1180
1181         Split out command parsing and help printing from BugzillaTool
1182         https://bugs.webkit.org/show_bug.cgi?id=31688
1183
1184         * Scripts/bugzilla-tool:
1185          - Add new MultiCommandTool class to contain option parsing and help printing logic.
1186          - Rename private methods to use _ pattern.
1187          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
1188          - 
1189
1190 2009-11-19  Eric Seidel  <eric@webkit.org>
1191
1192         Reviewed by Adam Barth.
1193
1194         Re-factor help printing to use modern python idioms
1195         https://bugs.webkit.org/show_bug.cgi?id=31685
1196
1197         * Scripts/bugzilla-tool:
1198
1199 2009-11-19  Eric Seidel  <eric@webkit.org>
1200
1201         Reviewed by Darin Adler.
1202
1203         commit-queue empty queue logs twice
1204         https://bugs.webkit.org/show_bug.cgi?id=31679
1205
1206         * Scripts/bugzilla-tool:
1207
1208 2009-11-19  Eric Seidel  <eric@webkit.org>
1209
1210         Reviewed by Darin Adler.
1211
1212         bugzilla-tool's reviewer/committer rejection message should be clearer
1213         https://bugs.webkit.org/show_bug.cgi?id=31126
1214
1215         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1216
1217         * Scripts/modules/bugzilla.py:
1218
1219 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1220
1221         Reviewed by Pavel Feldman.
1222
1223         Forces a WM_PAINT event on calling layoutTestController.display()
1224         in order to enable the timeline-paint.html test on Windows.
1225         ::UpdateWindow() does not force an event becaue the window is 
1226         not visible.
1227
1228         https://bugs.webkit.org/show_bug.cgi?id=31402
1229
1230         * DumpRenderTree/win/DumpRenderTree.cpp:
1231         (displayWebView):
1232
1233 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1234
1235         No review needed.
1236
1237         Added myself to committers list.
1238
1239         * Scripts/modules/committers.py:
1240
1241 2009-11-19  Adam Barth  <abarth@webkit.org>
1242
1243         Reviewed by Eric Seidel.
1244
1245         Bugzilla-tool command classes should match command names
1246         https://bugs.webkit.org/show_bug.cgi?id=31666
1247
1248         I renamed all the commands except CommitMessageForCurrentDiff because
1249         the new name would conflict with an existing class.
1250
1251         * Scripts/bugzilla-tool:
1252
1253 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1254
1255         Reviewed by Gustavo Noronha Silva.
1256
1257         Web Inspector: Implement "show inspector" in WebKit GTK
1258         API and enable console tests.
1259
1260         https://bugs.webkit.org/show_bug.cgi?id=31669
1261
1262         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1263         (LayoutTestController::showWebInspector):
1264
1265 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1266
1267         Reviewed by Simon Hausmann.
1268
1269         Minor refactoring + more documentation.
1270
1271         * DumpRenderTree/qt/DumpRenderTree.cpp:
1272         (WebCore::clearHistory):
1273         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1274
1275 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1276
1277         Reviewed by Eric Seidel.
1278
1279         Ignore websocket tests when --no-http is specified.
1280         https://bugs.webkit.org/show_bug.cgi?id=31662
1281
1282         * Scripts/run-webkit-tests:
1283
1284 2009-11-18  Adam Barth  <abarth@webkit.org>
1285
1286         Reviewed by Eric Seidel.
1287
1288         Normalize ' and " in bugzilla-tool
1289         https://bugs.webkit.org/show_bug.cgi?id=31655
1290
1291         We decided " is better than ' and we should be consistent.
1292
1293         * Scripts/bugzilla-tool:
1294
1295 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1296
1297         Reviewed by Kenneth Rohde Christiansen.
1298
1299         [Qt] Remove support for Qt v4.3 or older versions
1300         https://bugs.webkit.org/show_bug.cgi?id=29469
1301
1302         * DumpRenderTree/qt/DumpRenderTree.pro:
1303         * DumpRenderTree/qt/ImageDiff.pro:
1304
1305 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1306
1307         Reviewed by Eric Seidel.
1308
1309         GitTest.test_create_binary_patch fails if /tmp is symlink
1310         https://bugs.webkit.org/show_bug.cgi?id=31536
1311
1312         * Scripts/modules/scm_unittest.py:
1313
1314 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1315
1316         Reviewed by Darin Adler.
1317
1318         Configuration for Chromium Build Slaves.
1319
1320         https://bugs.webkit.org/show_bug.cgi?id=31442
1321
1322         * BuildSlaveSupport/build.webkit.org-config/config.json:
1323         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1324
1325 2009-11-18  Eric Seidel  <eric@webkit.org>
1326
1327         Reviewed by Darin Adler.
1328
1329         workqueue.py results in totally broken commit-queue UI
1330         https://bugs.webkit.org/show_bug.cgi?id=31645
1331
1332         * Scripts/bugzilla-tool:
1333          - Remove unneeded use of PatchCollection.
1334          - Grab a new copy of the cq'd patches every run of the queue.
1335
1336 2009-11-18  Sam Weinig  <sam@webkit.org>
1337
1338         Reviewed by Anders Carlsson.
1339
1340         Make the Mac Geolocation API async.
1341
1342         Update DRT to use the new async Mac Geolocation API.
1343
1344         * DumpRenderTree/mac/UIDelegate.mm:
1345         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1346
1347 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1348
1349         Reviewed by Kenneth Rohde Christiansen.
1350
1351         Add and option to toggle HTML5 datalist support to build-webkit
1352         https://bugs.webkit.org/show_bug.cgi?id=31599
1353
1354         * Scripts/build-webkit:
1355
1356 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1357
1358         Reviewed by Kevin Ollivier.
1359
1360         Enable wx plugin support using the Windows implementation as a base.
1361         
1362         https://bugs.webkit.org/show_bug.cgi?id=31636
1363
1364         * wx/build/settings.py:
1365
1366 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1367
1368         Reviewed by Simon Hausmann.
1369
1370         Change the initialization order so that the controllers
1371         will be created before exporting them to the JS DOM window.
1372
1373         * DumpRenderTree/qt/DumpRenderTree.cpp:
1374         (WebCore::DumpRenderTree::DumpRenderTree):
1375
1376 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1377
1378         Reviewed by Simon Hausmann.
1379
1380         Fix a code copy and paste error. m_page should be page.
1381
1382         * DumpRenderTree/qt/DumpRenderTree.cpp:
1383         (WebCore::DumpRenderTree::createWindow):
1384
1385 2009-11-17  Mark Rowe  <mrowe@apple.com>
1386
1387         Reviewed by Alexey Proskuryakov.
1388
1389         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1390
1391         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1392         This prevents symlinks from confusing the descendant check.
1393
1394 2009-11-17  Mark Rowe  <mrowe@apple.com>
1395
1396         Reviewed by Alexey Proskuryakov.
1397
1398         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1399
1400         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1401         server to be up rather than having run-webkit-tests abort immediately.
1402
1403         * Scripts/run-webkit-tests:
1404
1405 2009-11-17  Eric Seidel  <eric@webkit.org>
1406
1407         Reviewed by Darin Adler.
1408
1409         commit-queue is failing to set reviewer in ChangeLogs
1410         https://bugs.webkit.org/show_bug.cgi?id=31592
1411
1412         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1413         * Scripts/modules/bugzilla.py:
1414          - Add a new _validate_committer_and_reviewer function as a
1415            temporary solution until we can make a real Attachment object
1416            which knows how to fill in its committer/reviewer fields automatically.
1417
1418 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1419
1420         Unreviewed buildbot fix.
1421
1422         Revert part of earlier patch and add comment, as it
1423         was causing timeouts on the buildbot.
1424
1425         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1426         (LayoutTestController::notifyDone):
1427
1428 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1429
1430         Reviewed by Oliver Hunt.
1431
1432         Make the timeout 15 sec as for the other DRT's and make
1433         it print out the same output when a test timeout.
1434
1435         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1436         (LayoutTestController::waitUntilDone):
1437         (LayoutTestController::notifyDone):
1438         (LayoutTestController::timerEvent):
1439
1440 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1441
1442         Reviewed by Timothy Hatcher.
1443
1444         Fixed typos in comments.
1445
1446         * Scripts/modules/committers.py:
1447
1448 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1449
1450         Reviewed by Timothy Hatcher.
1451
1452         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1453         - Updated DRT to show/close inspector for all tests under /inspector
1454         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1455           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1456         - Removed reload on each inspector test
1457         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1458         inspector for those.
1459         - Reimplemented timeline tests in order to get rid of reload there.
1460         - Moved tests that don't require harness into the fast group.
1461
1462         https://bugs.webkit.org/show_bug.cgi?id=31472
1463
1464         * DumpRenderTree/LayoutTestController.cpp:
1465         (setTimelineProfilingEnabledCallback):
1466         (closeWebInspectorCallback):
1467         (LayoutTestController::staticFunctions):
1468         * DumpRenderTree/LayoutTestController.h:
1469         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1470         (shouldOpenWebInspector):
1471         (runTest):
1472         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1473         (LayoutTestController::setTimelineProfilingEnabled):
1474         * DumpRenderTree/mac/DumpRenderTree.mm:
1475         (shouldOpenWebInspector):
1476         (runTest):
1477         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1478         (LayoutTestController::setTimelineProfilingEnabled):
1479         * DumpRenderTree/win/DumpRenderTree.cpp:
1480         (shouldOpenWebInspector):
1481         (runTest):
1482         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1483         (LayoutTestController::setTimelineProfilingEnabled):
1484
1485 2009-11-17  Oliver Hunt  <oliver@apple.com>
1486
1487         Reviewed by Maciej Stachowiak.
1488
1489         Incorrect use of JavaScriptCore API in DumpRenderTree
1490         https://bugs.webkit.org/show_bug.cgi?id=31577
1491
1492         Return undefined rather than a literal null.
1493
1494         * DumpRenderTree/AccessibilityUIElement.cpp:
1495         (setSelectedTextRangeCallback):
1496         (incrementCallback):
1497         (decrementCallback):
1498         (showMenuCallback):
1499
1500 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1501
1502         Reviewed by Beth Dakin.
1503
1504         AX: aria-labelledby duplicates some of its WAI-ARIA label
1505         https://bugs.webkit.org/show_bug.cgi?id=31565
1506
1507         * DumpRenderTree/AccessibilityUIElement.cpp:
1508         (titleUIElementCallback):
1509         (getIsValidCallback):
1510         (AccessibilityUIElement::getJSClass):
1511
1512 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1513
1514         Reviewed by Simon Hausmann.
1515
1516         r50942 broke output from created windows. Make the
1517         m_enableTextOutput a member of the DRT and not the
1518         WebPage.
1519
1520         * DumpRenderTree/qt/DumpRenderTree.cpp:
1521         (WebCore::WebPage::WebPage):
1522         (WebCore::WebPage::javaScriptAlert):
1523         (WebCore::WebPage::javaScriptConsoleMessage):
1524         (WebCore::WebPage::javaScriptConfirm):
1525         (WebCore::WebPage::javaScriptPrompt):
1526         (WebCore::WebPage::acceptNavigationRequest):
1527         (WebCore::DumpRenderTree::DumpRenderTree):
1528         (WebCore::DumpRenderTree::open):
1529         (WebCore::DumpRenderTree::createWindow):
1530         * DumpRenderTree/qt/DumpRenderTree.h:
1531         (WebCore::DumpRenderTree::setTextOutputEnabled):
1532         (WebCore::DumpRenderTree::isTextOutputEnabled):
1533         (WebCore::WebPage::shouldInterruptJavaScript):
1534         (WebCore::WebPage::isTextOutputEnabled):
1535         (WebCore::WebPage::setViewGeometry):
1536
1537 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1538
1539         Reviewed by Gustavo Noronha Silva.
1540
1541         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1542         as the implementation is being used by at least Qt and Gtk+.
1543
1544         Update buildsystems as well.
1545
1546         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1547         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1548         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1549         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1550         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1551         * GNUmakefile.am:
1552
1553 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1554
1555         Reviewed by Alexey Proskuryakov.
1556
1557         Disable wss until all platforms support pyOpenSSL
1558
1559         https://bugs.webkit.org/show_bug.cgi?id=31479
1560
1561         * Scripts/run-webkit-tests:
1562
1563 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1564
1565         Reviewed by Kenneth Christiansen.
1566
1567         [Qt] Implement load error pages support for Qt's DRT.
1568         https://bugs.webkit.org/show_bug.cgi?id=31509
1569
1570         For now, it will not be a default feature, and layout tests
1571         that want to make use of this have to explicitily call
1572         'handleErrorPages();' for the test source.
1573
1574         Any of the other DumpRenderTree's (mac, win and gtk)
1575         support handling error pages. Qt's will be the first.
1576
1577         * DumpRenderTree/qt/DumpRenderTree.cpp:
1578         (WebCore::WebPage::supportsExtension):
1579         (WebCore::WebPage::extension):
1580         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1581         (LayoutTestController::reset):
1582         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1583         (LayoutTestController::shouldHandleErrorPages):
1584         (LayoutTestController::handleErrorPages):
1585
1586 2009-11-16  Eric Seidel  <eric@webkit.org>
1587
1588         Reviewed by Adam Barth.
1589
1590         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1591         https://bugs.webkit.org/show_bug.cgi?id=31549
1592
1593         Renamed --commit-queue to --non-interactive in most places
1594         and remove the code in land-patches which is no longer needed.
1595
1596         * Scripts/bugzilla-tool:
1597
1598 2009-11-16  Eric Seidel  <eric@webkit.org>
1599
1600         Reviewed by Adam Barth.
1601
1602         The commit-queue should use land-attachment
1603         https://bugs.webkit.org/show_bug.cgi?id=31548
1604
1605         * Scripts/bugzilla-tool:
1606
1607 2009-11-16  Adam Barth  <abarth@webkit.org>
1608
1609         Reviewed by Eric Seidel.
1610
1611         Convert CommitQueue over to PatchCollection
1612         https://bugs.webkit.org/show_bug.cgi?id=31547
1613
1614         Also fixes a bug in workqueue and adds a test!
1615
1616         * Scripts/bugzilla-tool:
1617         * Scripts/modules/workqueue.py:
1618         * Scripts/modules/workqueue_unittest.py:
1619
1620 2009-11-16  Adam Barth  <abarth@webkit.org>
1621
1622         Reviewed by Eric Seidel.
1623
1624         Move StyleQueue over to using PatchCollection
1625         https://bugs.webkit.org/show_bug.cgi?id=31544
1626
1627         That's what the class it's for.
1628
1629         * Scripts/bugzilla-tool:
1630         * Scripts/modules/patchcollection.py:
1631         * Scripts/modules/patchcollection_unittest.py:
1632
1633 2009-11-16  Eric Seidel  <eric@webkit.org>
1634
1635         Reviewed by Adam Barth.
1636
1637         bugzilla-tool needs a land-attachment command
1638         https://bugs.webkit.org/show_bug.cgi?id=31546
1639
1640         * Scripts/bugzilla-tool:
1641          - Move all the logic into AbstractLandingCommand and
1642            add a new LandAttachment command subclass.
1643          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1644
1645 2009-11-16  Eric Seidel  <eric@webkit.org>
1646
1647         Reviewed by Adam Barth.
1648
1649         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1650         https://bugs.webkit.org/show_bug.cgi?id=31543
1651
1652         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1653
1654         * Scripts/bugzilla-tool:
1655
1656 2009-11-16  Eric Seidel  <eric@webkit.org>
1657
1658         Reviewed by Adam Barth.
1659
1660         Disable the style queue from posting to the commit queue status page.
1661
1662         * Scripts/bugzilla-tool:
1663
1664 2009-11-16  Adam Barth  <abarth@webkit.org>
1665
1666         Reviewed by Eric Seidel.
1667
1668         Implement PatchCollection
1669         https://bugs.webkit.org/show_bug.cgi?id=31541
1670
1671         This class holds a set of patches and lets clients iterate through
1672         them.  Optionally, clients can install a filter.
1673
1674         * Scripts/modules/patchcollection.py: Added.
1675         * Scripts/modules/patchcollection_unittest.py: Added.
1676         * Scripts/run-webkit-unittests:
1677
1678 2009-11-16  Eric Seidel  <eric@webkit.org>
1679
1680         Reviewed by Adam Barth.
1681
1682         bugzilla-tool land-patches will close bugs with patches r=?
1683         https://bugs.webkit.org/show_bug.cgi?id=28230
1684
1685         The commit-queue shouldn't close patches with outstanding reviews on them,
1686         even if many reviewers seem to be against multi-patch bugs.
1687
1688         * Scripts/bugzilla-tool:
1689
1690 2009-11-16  Eric Seidel  <eric@webkit.org>
1691
1692         Reviewed by Adam Barth.
1693
1694         bugzilla-tool check-style should work with attachment ids instead of bug ids
1695         https://bugs.webkit.org/show_bug.cgi?id=31540
1696
1697         * Scripts/bugzilla-tool:
1698
1699 2009-11-16  Eric Seidel  <eric@webkit.org>
1700
1701         Reviewed by Adam Barth.
1702
1703         WorkQueue is the only place that should know about special exit codes
1704         https://bugs.webkit.org/show_bug.cgi?id=31534
1705
1706         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1707         and add tests for handling exit codes.
1708         I also cleaned up workqueue_unittest.py more.
1709
1710         * Scripts/bugzilla-tool:
1711         * Scripts/modules/workqueue.py:
1712         * Scripts/modules/workqueue_unittest.py:
1713
1714 2009-11-16  Eric Seidel  <eric@webkit.org>
1715
1716         Reviewed by Adam Barth.
1717
1718         Re-factor workqueue_unittest to allow for more than one test.
1719         https://bugs.webkit.org/show_bug.cgi?id=31535
1720
1721         * Scripts/modules/workqueue_unittest.py:
1722
1723 2009-11-16  Eric Seidel  <eric@webkit.org>
1724
1725         Reviewed by Adam Barth.
1726
1727         land-patches needs to be re-factored into smaller chunks
1728         https://bugs.webkit.org/show_bug.cgi?id=31532
1729
1730         * Scripts/bugzilla-tool: fix a couple obvious typos.
1731
1732 2009-11-16  Eric Seidel  <eric@webkit.org>
1733
1734         Reviewed by Adam Barth.
1735
1736         land-patches needs to be re-factored into smaller chunks
1737         https://bugs.webkit.org/show_bug.cgi?id=31532
1738
1739         The next patch will move these methods into WebKitLandingScripts.
1740
1741         * Scripts/bugzilla-tool:
1742          - Split out _land_patch and _close_bug_if_no_active_patches.
1743
1744 2009-11-16  Adam Barth  <abarth@webkit.org>
1745
1746         Reviewed by Eric Seidel.
1747
1748         Fix silly copy-and-paste code.  I am a terrible coder.
1749
1750         * Scripts/modules/bugzilla.py:
1751
1752 2009-11-16  Adam Barth  <abarth@webkit.org>
1753
1754         Reviewed by Eric Seidel.
1755
1756         Implement a StyleQueue
1757         https://bugs.webkit.org/show_bug.cgi?id=31537
1758
1759         The first iteration of the style queue only produces output locally.
1760         There is also a limit of 10 patches because it's not that useful to
1761         iterate through the entire review queue at this point.  We can remove
1762         the limit later.
1763
1764         * Scripts/bugzilla-tool:
1765         * Scripts/modules/bugzilla.py:
1766
1767 2009-11-16  Adam Barth  <abarth@webkit.org>
1768
1769         Reviewed by Eric Seidel.
1770
1771         Unit test WorkQueue
1772         https://bugs.webkit.org/show_bug.cgi?id=31531
1773
1774         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1775
1776         * Scripts/bugzilla-tool:
1777         * Scripts/modules/statusbot.py:
1778         * Scripts/modules/workqueue.py:
1779         * Scripts/modules/workqueue_unittest.py: Added.
1780         * Scripts/run-webkit-unittests:
1781
1782 2009-11-16  Eric Seidel  <eric@webkit.org>
1783
1784         Reviewed by Adam Barth.
1785
1786         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1787         https://bugs.webkit.org/show_bug.cgi?id=31530
1788
1789         * Scripts/bugzilla-tool:
1790
1791 2009-11-16  Eric Seidel  <eric@webkit.org>
1792
1793         Reviewed by Adam Barth.
1794
1795         bugzilla-tool needs apply-attachment
1796         https://bugs.webkit.org/show_bug.cgi?id=31528
1797
1798         * Scripts/bugzilla-tool:
1799          - Add ApplyAttachment command.
1800          - Abstract applying code into WebKitApplyingScripts.
1801          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1802         * Scripts/modules/bugzilla.py:
1803          - Add fetch_attachment and bug_id_for_attachment_id.
1804         * Scripts/modules/bugzilla_unittest.py:
1805          - Add test for new parsing.
1806          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1807
1808 2009-11-16  Eric Seidel  <eric@webkit.org>
1809
1810         Reviewed by Adam Barth.
1811
1812         Document check-style's use of force_clean.
1813
1814         * Scripts/bugzilla-tool:
1815         * Scripts/modules/scm.py:
1816
1817 2009-11-16  Adam Barth  <abarth@webkit.org>
1818
1819         Reviewed by Eric Seidel.
1820
1821         Move WorkQueue to its own file
1822         https://bugs.webkit.org/show_bug.cgi?id=31529
1823
1824         WorkQueue and WorkQueueDelegate are separate concerns from
1825         bugzilla-tool.  Also added a missing include to logging.py.
1826
1827         * Scripts/bugzilla-tool:
1828         * Scripts/modules/logging.py:
1829         * Scripts/modules/workqueue.py:
1830
1831 2009-11-16  Adam Barth  <abarth@webkit.org>
1832
1833         Reviewed by Eric Seidel.
1834
1835         Move OutputTee to logging.py.
1836
1837         * Scripts/bugzilla-tool:
1838         * Scripts/modules/logging.py:
1839
1840 2009-11-15  Adam Barth  <abarth@webkit.org>
1841
1842         Reviewed by Eric Seidel.
1843
1844         Refactor bugzilla-tool to allow for multiple queues
1845         https://bugs.webkit.org/show_bug.cgi?id=31513
1846
1847         Divide the commit queue class into three class to make creating
1848         additional queues easier.
1849
1850         * Scripts/bugzilla-tool:
1851
1852 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1853
1854         Reviewed by Eric Seidel.
1855
1856         svn-apply may not handle git patches created by bugzilla-tool
1857         https://bugs.webkit.org/show_bug.cgi?id=31457
1858
1859         * Scripts/modules/scm.py:
1860         * Scripts/modules/scm_unittest.py:
1861
1862 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1863
1864         Reviewed by Eric Seidel.
1865
1866         bugzilla-tool should post git binary diff
1867         https://bugs.webkit.org/show_bug.cgi?id=31458
1868
1869         Add --binary option to Git.create_patch.
1870
1871         * Scripts/modules/scm.py:
1872         * Scripts/modules/scm_unittest.py:
1873
1874 2009-11-15  Adam Barth  <abarth@webkit.org>
1875
1876         Reviewed by Darin Adler.
1877
1878         Add bugzilla-tool check-style
1879         https://bugs.webkit.org/show_bug.cgi?id=31515
1880
1881         * Scripts/bugzilla-tool:
1882         * Scripts/modules/bugzilla.py:
1883
1884 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1885
1886         Reviewed by Simon Hausmann.
1887
1888         Make the Qt Linux only --valgrind feature, suppress errors
1889         defined in the SuppressedValgrindErrors file.
1890
1891         * Scripts/run-webkit-tests:
1892
1893 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1894
1895         Reviewed by Simon Hausmann.
1896
1897         Set the locale to C and not to the current one in use on the system.
1898
1899         * DumpRenderTree/qt/DumpRenderTree.cpp:
1900         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1901
1902 2009-11-13  Adam Roben  <aroben@apple.com>
1903
1904         Add support for
1905         http/tests/security/isolatedWorld/didClearWindowObject.html
1906
1907         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1908         window objects in isolated worlds are cleared
1909
1910         Reviewed by Dave Hyatt.
1911
1912         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1913
1914         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1915         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1916         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1917         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1918         Added. Sets a __worldID property on the global object whose value is
1919         the ID of this world.
1920         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1921         Respond to this new delegate callback by calling through to one of the
1922         above new methods.
1923         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1924         (worldMap): Added. Returns a HashMap containing all the worlds we've
1925         created.
1926         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1927         haven't kept track of this world.
1928         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1929         instead of declaring our own.
1930
1931         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1932
1933         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1934         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1935         didClearWindowObjectForFrameInStandardWorld.
1936         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1937         Respond to this new delegate callback by calling through to one of the
1938         below new methods.
1939         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1940         Added. Sets a __worldID property on the gobal object whose value is
1941         the ID of this world.
1942         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1943         Added. Moved code here from didClearWindowObject.
1944
1945         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1946         didClearWindowObjectForFrame* functions.
1947
1948         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1949         (worldMap): Added. Returns a HashMap containing all the worlds we've
1950         created.
1951         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1952         haven't kept track of this world.
1953         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1954         instead of declaring our own.
1955
1956 2009-11-13  Adam Roben  <aroben@apple.com>
1957
1958         Finish replacing worldIDs with world objects
1959
1960         The only remaining use of worldIDs was in a method only used by DRT
1961         for the isolated worlds tests.
1962
1963         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1964
1965         Reviewed by Mark Rowe.
1966
1967         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1968         (LayoutTestController::evaluateScriptInIsolatedWorld):
1969         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1970         (LayoutTestController::evaluateScriptInIsolatedWorld):
1971         Updated for changes to WebFrame. Now holds the map of worldID -> world
1972         at this level instead of making WebKit do it.
1973
1974 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1975
1976         Reviewed by Simon Hausmann.
1977
1978         [Qt] Ensure the DRT does not output anything until first test is run
1979
1980         * DumpRenderTree/qt/DumpRenderTree.cpp:
1981         * DumpRenderTree/qt/DumpRenderTree.h:
1982
1983 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1984
1985         Reviewed by Tor Arne Vestbø.
1986
1987         Clear the undo stack in before each new test run.
1988
1989         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1990
1991         * DumpRenderTree/qt/DumpRenderTree.cpp:
1992         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1993
1994 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1995
1996         Reviewed by Kenneth Rohde Christiansen.
1997
1998         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1999
2000         * DumpRenderTree/qt/DumpRenderTree.cpp:
2001         (WebCore::WebPage::resetSettings):
2002         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2003         (LayoutTestController::overridePreference):
2004
2005 2009-11-13  Eric Seidel  <eric@webkit.org>
2006
2007         Reviewed by Adam Barth.
2008
2009         Update committers.py based on svn records
2010         https://bugs.webkit.org/show_bug.cgi?id=31366
2011
2012         This list was generated using validate-committer-lists from
2013         https://bugs.webkit.org/show_bug.cgi?id=30970
2014         and makes committers.py current for committers who have
2015         committed in the last 3 years.
2016
2017         * Scripts/modules/committers.py:
2018
2019 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
2020
2021         Reviewed by Adam Barth.
2022
2023         The document-open.html test was flaky at times. The test invokes the layout test plugin
2024         which in its destroy stream handler opens a new document. This basically tears down the
2025         stream and the associated plugin instance. The pluginLog function in the layout test
2026         plugin attempts to retrieve the window script object on a torn down plugin instance
2027         which crashed consistently on windows in the debugger. The functions which issue
2028         these logs already have a valid window script object. We now have variants of the pluginLog
2029         function which take in a window script object with and without variable arguments. 
2030
2031         https://bugs.webkit.org/show_bug.cgi?id=31067
2032
2033         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2034         (pluginLogWithWindowObject):
2035         (pluginLogWithWindowObjectVariableArgs):
2036         (pluginLog):
2037         (notifyTestCompletion):
2038         (testDocumentOpen):
2039         (testWindowOpen):
2040
2041 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2042
2043         Reviewed by Gustavo Noronha Silva.
2044
2045         https://bugs.webkit.org/show_bug.cgi?id=30997
2046         [Gtk] Implemment AtkDocument
2047
2048         Added testing support.
2049
2050         * DumpRenderTree/AccessibilityUIElement.cpp:
2051         * DumpRenderTree/AccessibilityUIElement.h:
2052         (getDocumentEncodingCallback):
2053         (getDocumentURICallback):
2054         (AccessibilityUIElement::getJSClass):
2055         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2056         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2057         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2058         (AccessibilityUIElement::documentEncoding):
2059         (AccessibilityUIElement::documentURI):
2060
2061 2009-11-12  Adam Roben  <aroben@apple.com>
2062
2063         Replace worldIDs with world objects
2064
2065         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
2066         user scripts/stylesheets and isolated worlds
2067
2068         Reviewed by Sam Weinig.
2069
2070         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2071         (LayoutTestController::addUserScript):
2072         (LayoutTestController::addUserStyleSheet):
2073         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2074         (LayoutTestController::addUserScript):
2075         (LayoutTestController::addUserStyleSheet):
2076         Changed these functions to create a new WebJSWorld each time they're
2077         called and to pass that world to WebKit.
2078
2079 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
2080
2081         Reviewed by Oliver Hunt.
2082
2083         need to implement aria tree roles
2084         https://bugs.webkit.org/show_bug.cgi?id=31284
2085
2086         * DumpRenderTree/AccessibilityUIElement.cpp:
2087         (disclosedRowAtIndexCallback):
2088         (selectedRowAtIndexCallback):
2089         (isEqualCallback):
2090         (isAttributeSettableCallback):
2091         (isActionSupportedCallback):
2092         (disclosedByRowCallback):
2093         (hierarchicalLevelCallback):
2094         (AccessibilityUIElement::getJSClass):
2095         * DumpRenderTree/AccessibilityUIElement.h:
2096         (AccessibilityUIElement::isEqual):
2097         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2098         (AccessibilityUIElement::hierarchicalLevel):
2099         (AccessibilityUIElement::disclosedRowAtIndex):
2100         (AccessibilityUIElement::selectedRowAtIndex):
2101         (AccessibilityUIElement::disclosedByRow):
2102         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2103         (AccessibilityUIElement::getChildAtIndex):
2104         (AccessibilityUIElement::disclosedRowAtIndex):
2105         (AccessibilityUIElement::selectedRowAtIndex):
2106         (AccessibilityUIElement::titleUIElement):
2107         (AccessibilityUIElement::parentElement):
2108         (AccessibilityUIElement::disclosedByRow):
2109         (AccessibilityUIElement::hierarchicalLevel):
2110         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2111         (AccessibilityUIElement::hierarchicalLevel):
2112         (AccessibilityUIElement::disclosedRowAtIndex):
2113         (AccessibilityUIElement::selectedRowAtIndex):
2114         (AccessibilityUIElement::disclosedByRow):
2115
2116 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
2117
2118         Reviewed by Darin Adler.
2119
2120         svn-apply can not handle git binary diffs
2121         https://bugs.webkit.org/show_bug.cgi?id=26830
2122
2123         Support "literal" type git binary diffs.
2124
2125         * Scripts/VCSUtils.pm:
2126         * Scripts/modules/scm_unittest.py:
2127         * Scripts/svn-apply:
2128
2129 2009-11-11  Dmitry Titov  <dimich@chromium.org>
2130
2131         Not reviewed, removing duplicate entry for myself in committers.py.
2132
2133         * Scripts/modules/committers.py:
2134
2135 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
2136
2137         Reviewed by Darin Adler and Mark Rowe.
2138
2139         https://bugs.webkit.org/show_bug.cgi?id=31200
2140         Tests in http/tests/security/mixedContent start to fail when new tests are added
2141
2142         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
2143
2144 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2145
2146         Reviewed by Jan Alonzo.
2147
2148         Create, and display a window for the inspector, for inspector
2149         tests.
2150
2151         Need to also show/hide the inspector window to avoid having
2152         problems with code assuming it is realized
2153         https://bugs.webkit.org/show_bug.cgi?id=31347
2154
2155         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2156         (webInspectorShowWindow):
2157         (webInspectorCloseWindow):
2158         (webInspectorInspectWebView):
2159         (createWebView):
2160
2161 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2162
2163         Unreviewed Qt buildbot fix.
2164
2165         My previous fix was wrong, so revert that change and fix it by
2166         returning when the document of the frame has no document element.
2167         Idea is borrowed from mac and win DRT.
2168
2169         * DumpRenderTree/qt/DumpRenderTree.cpp:
2170         (WebCore::DumpRenderTree::dumpFramesAsText):
2171
2172 2009-11-11  Eric Seidel  <eric@webkit.org>
2173
2174         Reviewed byg Kenneth Rohde Christiansen.
2175
2176         Update Kenneth's committer record to include the email he
2177         uses on lists.webkit.org.
2178
2179         * Scripts/modules/committers.py:
2180
2181 2009-11-11  Eric Seidel  <eric@webkit.org>
2182
2183         Reviewed by Gustavo Noronha Silva.
2184
2185         Several committers use separate email addresses for bugzilla and svn.webkit.org
2186         https://bugs.webkit.org/show_bug.cgi?id=31364
2187
2188         Update records for existing committers to include email addresses
2189         used in svn.webkit.org and lists.webkit.org.
2190         Most committers use the same email address in all 3 places, but some use
2191         separate addresses.  committers.py needs record of each of these addresses.
2192
2193         * Scripts/modules/committers.py:
2194
2195 2009-11-11  Eric Seidel  <eric@webkit.org>
2196
2197         No review, adding second email address for an existing committer.
2198
2199         Add Yong Li's second bugzilla account to his committer record.
2200         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
2201
2202         * Scripts/modules/committers.py:
2203
2204 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2205
2206         Reviewed by Simon Hausmann.
2207
2208         If the frame has no innerText don't append it, and
2209         do not add a newline which breaks some cross platform
2210         results.
2211
2212         * DumpRenderTree/qt/DumpRenderTree.cpp:
2213         (WebCore::DumpRenderTree::dumpFramesAsText):
2214
2215 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2216
2217         Reviewed by Simon Hausmann.
2218
2219         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2220
2221         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2222         (webkit_test_plugin_new_instance):
2223         (webkit_test_plugin_destroy_instance):
2224         (webkit_test_plugin_destroy_stream):
2225
2226 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2227
2228         Reviewed by Mark Rowe.
2229
2230         Implement the functionality needed by plugins/window-open.html
2231
2232         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2233         (webkit_test_plugin_new_instance):
2234         (webkit_test_plugin_set_window):
2235
2236 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2237
2238         Reviewed by Simon Hausmann.
2239
2240         [Qt] Force -graphicssystem raster and -style windows when running DRT
2241
2242         * DumpRenderTree/qt/main.cpp:
2243         * Scripts/run-webkit-tests:
2244
2245 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2246
2247         Reviewed by Simon Hausmann.
2248
2249         Compute correct library paths for Qt
2250
2251         * Scripts/webkitdirs.pm:
2252
2253 2009-11-10  Mark Rowe  <mrowe@apple.com>
2254
2255         Reviewed by Sam Weinig.
2256
2257         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2258
2259         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2260         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2261         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2262         that had enabled frame load delegate logging this would result in extra log messages being generated,
2263         causing the test to fail.
2264
2265         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2266         tests.
2267
2268         * DumpRenderTree/mac/DumpRenderTree.mm:
2269         (dumpRenderTree):
2270         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2271         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2272
2273 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2274
2275         Reviewed by Kenneth Rohde Christiansen.
2276
2277         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2278
2279         * DumpRenderTree/qt/DumpRenderTree.cpp:
2280         (WebCore::DumpRenderTree::DumpRenderTree):
2281
2282 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2283
2284         Reviewed by Jan Alonzo.
2285
2286         [GTK] Remove WebSocket configuration from WebKitWebSettings
2287         https://bugs.webkit.org/show_bug.cgi?id=31244
2288
2289         Follow-up of r50724. Don't set the enable-web-socket property
2290         anymore.
2291
2292         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2293         (resetDefaultsToConsistentValues):
2294
2295 2009-11-10  Oliver Hunt  <oliver@apple.com>
2296
2297         Reviewed by Maciej Stachowiak.
2298
2299         Rename 3D Canvas related classes to use WebGL prefix
2300         https://bugs.webkit.org/show_bug.cgi?id=29095
2301
2302         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2303         and upate webkitdirs script to new method of testing for WebGL.
2304
2305         * Scripts/do-webcore-rename:
2306         * Scripts/webkitdirs.pm:
2307
2308 2009-11-09  Oliver Hunt  <oliver@apple.com>
2309
2310         Reviewed by Geoff Garen.
2311
2312         Make do-webcore-rename work with git.
2313
2314         * Scripts/do-webcore-rename:
2315
2316 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2317
2318         Adding Kenneth to the reviewers list.
2319
2320         * Scripts/modules/committers.py:
2321
2322 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2323
2324         Reviewed by Jan Alonzo.
2325
2326         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2327         https://bugs.webkit.org/show_bug.cgi?id=30482
2328
2329         LayoutTestControllerGtk now uses the exposed
2330         Page::tabKeyCyclesThroughElements API
2331
2332         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2333         (LayoutTestController::setTabKeyCyclesThroughElements):
2334
2335 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2336
2337         Reviewed by Holger Freyther.
2338
2339         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2340         This helps to pass the test case below. Also replaced hardcoded
2341         code numbers with defined constants.
2342         https://bugs.webkit.org/show_bug.cgi?id=31185
2343         
2344         Test: editing/undo/undo-deleteWord.html
2345
2346         * DumpRenderTree/qt/EventSenderQt.cpp:
2347         (EventSender::keyDown):
2348
2349 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2350
2351         Reviewed by Holger Freyther.
2352
2353         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2354         https://bugs.webkit.org/show_bug.cgi?id=31164
2355
2356         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2357
2358         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2359         (LayoutTestController::processWork):
2360
2361 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2362
2363         Reviewed by Holger Freyther.
2364
2365         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2366         https://bugs.webkit.org/show_bug.cgi?id=31158
2367
2368         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2369         always, which from WorkQueue prospective means that a load has been started
2370         and the queue processing should stop and wait for the load to finish.
2371         Spinning it off into a loading and a non-loading variants was the solution
2372         adopted by Mac's DRT to work around this problem. The former keeps returning
2373         'true' while the later executes the script synchronously and returns 'false'
2374         making it possible to the WorkQueue to proceed right away.
2375
2376         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2377         (LayoutTestController::processWork):
2378         (LayoutTestController::queueLoadingScript):
2379         (LayoutTestController::queueNonLoadingScript):
2380         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2381         * DumpRenderTree/qt/WorkQueueItem.h:
2382         (LoadingScriptItem::LoadingScriptItem):
2383         (LoadingScriptItem::invoke):
2384         (NonLoadingScriptItem::NonLoadingScriptItem):
2385         (NonLoadingScriptItem::invoke):
2386
2387 2009-11-07  Mark Rowe  <mrowe@apple.com>
2388
2389         Rubber-stamped by Cameron Zwarich.
2390
2391         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2392
2393         * Scripts/commit-log-editor:
2394
2395 2009-11-07  Mark Rowe  <mrowe@apple.com>
2396
2397         Reviewed by Darin Adler.
2398
2399         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2400         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2401
2402         Move logic for determining the name and email address to use in a ChangeLog entry from
2403         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2404         whether the author of the patch matches committer, and therefore needs access to the
2405         email address that would be used in a ChangeLog entry.
2406
2407         Based on a patch by Pierre d'Herbemont.
2408
2409         * Scripts/VCSUtils.pm:
2410         * Scripts/commit-log-editor:
2411         * Scripts/prepare-ChangeLog:
2412         * Scripts/webkitdirs.pm:
2413
2414 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2415
2416         Reviewed by Adam Barth.
2417
2418         Added functionality to the layout test plugin to invoke document.open and
2419         window.open with default arguments. The associated webkit bug is
2420         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2421         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2422         work in Chromium (V8) if there is no calling javascript context. To achieve this
2423         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2424         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2425
2426         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2427         (testDocumentOpen):
2428         (testWindowOpen):
2429         (pluginAllocate):
2430         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2431         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2432         (NPP_New):
2433         (NPP_SetWindow):
2434         (NPP_DestroyStream):
2435         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2436         (NPP_New):
2437         (NPP_SetWindow):
2438         (NPP_NewStream):
2439         (NPP_DestroyStream):
2440
2441 2009-11-06  Eric Seidel  <eric@webkit.org>
2442
2443         Reviewed by Adam Barth.
2444
2445         bugzilla-tool crashed with exception
2446         https://bugs.webkit.org/show_bug.cgi?id=31092
2447
2448         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2449
2450 2009-11-04  Eric Seidel  <eric@webkit.org>
2451
2452         No review, just add a line which got left out of the patch uploaded for commit.
2453
2454         commit-queue is crashing when trying to reject patches after unknown failures
2455         https://bugs.webkit.org/show_bug.cgi?id=31091
2456
2457         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2458
2459 2009-11-04  Adam Roben  <aroben@apple.com>
2460
2461         Remove bogus else clause in bugzilla-tool
2462
2463         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2464         create-bug raises exception after entering bug description
2465
2466         Reviewed by David Kilzer.
2467
2468         * Scripts/bugzilla-tool:
2469         (CreateBug): else clauses are only hit if no exception is raised, so
2470         it makes no sense to try to re-raise the exception in an else clause.
2471         The exception will automatically be re-raised if it doesn't match any
2472         of the except clauses, so we don't have to do anything special here at
2473         all to get the desired behavior.
2474
2475 2009-11-04  Eric Seidel  <eric@webkit.org>
2476
2477         Reviewed by David Kilzer.
2478
2479         svn-apply's fixChangeLogPatch function seems broken
2480         https://bugs.webkit.org/show_bug.cgi?id=30683
2481
2482         Update fixChangeLogPatch to be able to handle patches which
2483         don't start at line 1.
2484         Add unit tests for svn-apply to scm_unittest.py.
2485
2486         * Scripts/VCSUtils.pm:
2487         * Scripts/modules/scm_unittest.py:
2488
2489 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2490
2491         Reviewed by Beth Dakin.
2492
2493         Need to implement ARIA role="combobox"
2494         https://bugs.webkit.org/show_bug.cgi?id=31096
2495
2496         * DumpRenderTree/AccessibilityUIElement.cpp:
2497         (showMenuCallback):
2498         (getIsExpandedCallback):
2499         (AccessibilityUIElement::getJSClass):
2500         * DumpRenderTree/AccessibilityUIElement.h:
2501         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2502         (AccessibilityUIElement::isExpanded):
2503         (AccessibilityUIElement::showMenu):
2504         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2505         (AccessibilityUIElement::isExpanded):
2506         (AccessibilityUIElement::showMenu):
2507         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2508         (AccessibilityUIElement::isSelected):
2509         (AccessibilityUIElement::isExpanded):
2510         (AccessibilityUIElement::showMenu):
2511
2512 2009-11-04  Eric Seidel  <eric@webkit.org>
2513
2514         Reviewed by Adam Barth.
2515
2516         commit-queue is crashing when trying to reject patches after unknown failures
2517         https://bugs.webkit.org/show_bug.cgi?id=31091
2518
2519         * Scripts/bugzilla-tool:
2520          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2521            so we have to find out what the current patch is by asking bugzilla again.
2522          - Discovered that this code was also leaking file descriptors, so fixed that.
2523
2524 2009-11-04  Adam Roben  <aroben@apple.com>
2525
2526         Make run-webkit-tests work for the Debug_Internal Windows
2527         configuration
2528
2529         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2530         suffix.
2531
2532         Fixes <http://webkit.org/b/31123>.
2533
2534         Reviewed by Sam Weinig.
2535
2536         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2537         Debug_Internal, either.
2538
2539 2009-11-04  Eric Seidel  <eric@webkit.org>
2540
2541         Reviewed by Adam Barth.
2542
2543         committers.py needs a way to store non-bugzilla email addresses
2544         https://bugs.webkit.org/show_bug.cgi?id=31037
2545
2546         Make Committer and Reviewer constructors take a single email or a list of emails.
2547         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2548         Expose reviewers(), used by validate-committer-lists on bug 30970.
2549
2550         * Scripts/modules/committers.py:
2551         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2552
2553 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2554
2555         Reviewed by David Levin.
2556
2557         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2558         https://bugs.webkit.org/show_bug.cgi?id=27491
2559
2560         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2561         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2562
2563         Functions to start or stop Web Socket servers are added.
2564
2565         * Scripts/run-webkit-tests:
2566
2567 2009-11-03  Eric Seidel  <eric@webkit.org>
2568
2569         No review, just changing wording of log message.
2570
2571         Change log string to say "failed" instead of "rejected"
2572         when a commit fails due to an out of date checkout.
2573         This makes grepping the commit-queue log for rejected patches easier.
2574
2575         * Scripts/bugzilla-tool:
2576
2577 2009-11-03  Eric Seidel  <eric@webkit.org>
2578
2579         No review, adding commonly known committers missing from the file.
2580
2581         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2582
2583 2009-11-03  Eric Seidel  <eric@webkit.org>
2584
2585         No review, just sort-order cleanup.
2586
2587         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2588
2589 2009-11-03  Stephen White  <senorblanco@chromium.org>
2590
2591         (Unreviewed).
2592
2593         Add myself to committers.py.
2594
2595         * Scripts/modules/committers.py:
2596
2597 2009-11-03  Robin Dunn  <robin@alldunn.com>
2598
2599         Reviewed by Kevin Ollviier.
2600
2601         Add packaging scripts for Debian-based Linux distros.
2602         
2603         https://bugs.webkit.org/show_bug.cgi?id=31075
2604
2605         * wx/packaging/build-debian-installer.py: Added.
2606         * wx/packaging/debian: Added.
2607
2608 2009-11-03  Dan Bernstein  <mitz@apple.com>
2609
2610         Reviewed by Anders Carlsson and Beth Dakin.
2611
2612         https://bugs.webkit.org/show_bug.cgi?id=31070
2613
2614         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2615         destroyed, it executes the value of the 'ondestroy' parameter as a
2616         script.
2617
2618         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2619         (pluginAllocate): Initialize onDestroy.
2620         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2621         onDestroy.
2622         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2623         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2624         specified.
2625         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2626
2627 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2628
2629         Reviewed by Xan Lopez.
2630
2631         https://bugs.webkit.org/show_bug.cgi?id=31035
2632         [GTK] some accessibility tests hitting assertion in debug builds
2633
2634         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2635
2636         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2637         (AccessibilityController::rootElement):
2638
2639 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2640
2641         Reviewed by Beth Dakin.
2642
2643         Support ARIA "tab" roles
2644         https://bugs.webkit.org/show_bug.cgi?id=30842
2645
2646         * DumpRenderTree/AccessibilityUIElement.cpp:
2647         * DumpRenderTree/AccessibilityUIElement.h:
2648         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2649         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2650         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2651
2652 2009-11-01  Eric Seidel  <eric@webkit.org>
2653
2654         Reviewed by David Levin.
2655
2656         buildbots should use --exit-after-N-failures
2657         https://bugs.webkit.org/show_bug.cgi?id=30809
2658
2659         Make the bots exit after 20 failures to prevent never-ending
2660         test runs where every test spends a minute crashing.
2661
2662         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2663
2664 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2665
2666         Reviewed by Eric Seidel.
2667
2668         Turn on warnings for QtWebKit for gcc
2669         https://bugs.webkit.org/show_bug.cgi?id=30958
2670
2671         * DumpRenderTree/qt/main.cpp: 
2672         (crashHandler): Mark function NO_RETURN
2673
2674 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2675
2676         Adding myself to the committers list.
2677
2678         * Scripts/modules/committers.py:
2679
2680 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2681
2682         Fix an issue that Adam noticed in DRT.
2683
2684         Reviewed by Darin Adler.
2685
2686         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2687         (AccessibilityUIElement::role):
2688         Get the length of the role text, and create a buffer dynamically.
2689
2690 2009-10-30  Eric Seidel  <eric@webkit.org>
2691
2692         No review, rolling out r50105.
2693         http://trac.webkit.org/changeset/50105
2694
2695         This commit was causing:
2696         https://bugs.webkit.org/show_bug.cgi?id=30869
2697         We'll re-implement the feature a different way.
2698
2699         * Scripts/bugzilla-tool:
2700
2701 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2702
2703         Test for MSAA: Accessibility of headings is not correct
2704
2705         https://bugs.webkit.org/show_bug.cgi?id=30937
2706
2707         Reviewed by Adam Roben.
2708
2709         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2710         (AccessibilityUIElement::role):
2711         Allow the role returned to be a BSTR.
2712         (AccessibilityUIElement::description):
2713         Fix a copy/paste error.
2714
2715 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2716
2717         Test for MSAA: Accessibility of links is wrong
2718
2719         https://bugs.webkit.org/show_bug.cgi?id=30928
2720
2721         Reviewed by Darin Adler.
2722
2723         * DumpRenderTree/AccessibilityUIElement.cpp:
2724         (getAccessibilityValueCallback):
2725         Return the accessibility value.
2726         (AccessibilityUIElement::getJSClass):
2727         Added "accessibilityValue" value.
2728
2729         * DumpRenderTree/AccessibilityUIElement.h:
2730
2731         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2732         (AccessibilityUIElement::accessibilityValue):
2733         Stubbed.
2734
2735         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2736         (AccessibilityUIElement::accessibilityValue):
2737         Stubbed.
2738
2739         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2740         (AccessibilityUIElement::accessibilityValue):
2741         Get the object's value, and return it as a JS string.
2742
2743 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2744
2745         Fix typo in command name used by wx build system.
2746
2747         * wx/build/build_utils.py:
2748
2749 2009-10-30  Adam Barth  <abarth@webkit.org>
2750
2751         Reviewed by Darin Adler.
2752
2753         Patch v1 is a dumb default name for patches
2754         https://bugs.webkit.org/show_bug.cgi?id=30952
2755
2756         Let's use "Patch" instead.
2757
2758         * Scripts/bugzilla-tool:
2759
2760 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2761
2762         Unreviewed trivial buildfix.
2763
2764         [Qt] Buildfix for r50333.
2765
2766         * DumpRenderTree/qt/DumpRenderTree.pro:
2767
2768 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2769
2770         Reviewed by Holger Freyther.
2771
2772         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2773         https://bugs.webkit.org/show_bug.cgi?id=30953
2774
2775         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2776         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2777         makes qt DRT to share this implementation (as gtk and mac ports do).
2778
2779         * DumpRenderTree/qt/DumpRenderTree.pro:
2780         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2781         * DumpRenderTree/qt/WorkQueue.h: Removed.
2782
2783 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2784
2785         Unreviewed potential buildbot fix.
2786
2787         Second try: Reset page history before running each test.
2788
2789         Apparently the QWebHistory::clear() keeps the current page
2790         in history which is not what we want, so we not additionally
2791         sets the history capacity to 0 (forces removing everything)
2792         and then sets it back to its original value.
2793
2794         * DumpRenderTree/qt/DumpRenderTree.cpp:
2795         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2796
2797 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2798
2799         Unreviewed potential buildbot fix.
2800
2801         Reset page history before running each test.
2802
2803         * DumpRenderTree/qt/DumpRenderTree.cpp:
2804         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2805
2806 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2807
2808         Reviewed by Eric Seidel.
2809
2810         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2811
2812         Bug 28420 -  Implement HTML5 <ruby> rendering
2813         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2814
2815         No new tests (no functional change).
2816
2817         * Scripts/build-webkit:
2818
2819 2009-10-29  Dan Bernstein  <mitz@apple.com>
2820
2821         Reviewed by Mark Rowe.
2822
2823         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2824         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2825         define it.
2826
2827         * Scripts/VCSUtils.pm:
2828         * Scripts/svn-apply:
2829         * Scripts/svn-unapply:
2830
2831 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2832
2833         Reviewed by Gustavo Noronha.
2834
2835         Use the GTK+ main loop instead of rolling our own mini-version of
2836         it.
2837
2838         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2839         (dump):
2840         (runTest):
2841         (webViewLoadFinished):
2842
2843 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2844
2845         Reviewed by Oliver Hunt.
2846
2847         Implement the Qt version of DRT dumpBackForwardList().
2848
2849         * DumpRenderTree/qt/DumpRenderTree.cpp:
2850         (WebCore::dumpHistoryItem):
2851         (WebCore::DumpRenderTree::dumpBackForwardList):
2852
2853 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2854
2855         Reviewed by Adam Roben.
2856
2857         Implement DRT functionality for Qt introduced in
2858         r28690 and r28705.
2859
2860         - Implemented pathToLocalResource which exposes the functionality of
2861         converting a given unix path to the correct location on Windows.
2862         - Implemented a way to remove machine-dependent information from paths
2863         in layout test results.
2864
2865         * DumpRenderTree/qt/DumpRenderTree.cpp:
2866         (WebCore::urlSuitableForTestResult):
2867         (WebCore::WebPage::javaScriptConsoleMessage):
2868         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2869         (LayoutTestController::pathToLocalResource):
2870         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2871
2872 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2873
2874         Adding myself to the committers list.
2875
2876         * Scripts/modules/committers.py:
2877
2878 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2879
2880         Adding myself to the committers list.
2881
2882         * Scripts/modules/committers.py:
2883
2884 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2885
2886         Reviewed by Jan Alonzo.
2887
2888         [GTK] API to start inspector for a WebView
2889         https://bugs.webkit.org/show_bug.cgi?id=22551
2890
2891         Use the new inspector API to implement the LayoutTestController
2892         interfaces used to test the inspector.
2893
2894         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2895         (webInspectorInspectWebView):
2896         (createWebView):
2897         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2898         (LayoutTestController::showWebInspector):
2899         (LayoutTestController::closeWebInspector):
2900         (LayoutTestController::evaluateInWebInspector):
2901
2902 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2903
2904         Reviewed by Eric Seidel.
2905
2906         [Qt] WebFrame::counterValueForElementById must not be exposed
2907         https://bugs.webkit.org/show_bug.cgi?id=30882
2908
2909         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2910         (LayoutTestController::counterValueForElementById):
2911
2912 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2913
2914         Rubberstamped by Oliver Hunt.
2915
2916         Fix the warning:
2917
2918         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2919         declared with attribute warn_unused_result".
2920
2921         by actually checking the result. In the case it is null, an
2922         error has occoured, so treat it as the other fatal errors.
2923
2924         * DumpRenderTree/qt/DumpRenderTree.cpp:
2925         (WebCore::DumpRenderTree::initializeFonts):
2926
2927 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2928
2929         Reviewed by Darin Adler.
2930
2931         Provide a way to get counter values with layoutTestContoller
2932         https://bugs.webkit.org/show_bug.cgi?id=30555
2933
2934         Define layoutTestContoller.counterValueForElementById.
2935
2936         * DumpRenderTree/LayoutTestController.cpp:
2937         (counterValueForElementByIdCallback):
2938         (LayoutTestController::staticFunctions):
2939         * DumpRenderTree/LayoutTestController.h:
2940         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2941         (LayoutTestController::counterValueForElementById):
2942
2943 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2944
2945         Rubberstamped by Oliver Hunt.
2946
2947         Change two methods to be internal for DRT use only.
2948
2949         Part of [Qt] Review all new API in Qt 4.6
2950         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2951
2952         * DumpRenderTree/qt/DumpRenderTree.cpp:
2953         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2954         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2955         (LayoutTestController::whiteListAccessFromOrigin):
2956
2957 2009-10-27  Eric Seidel  <eric@webkit.org>
2958
2959         Reviewed by Adam Barth.
2960
2961         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2962         https://bugs.webkit.org/show_bug.cgi?id=30826
2963
2964         * Scripts/svn-apply:
2965          - Add () around all system() calls.
2966          - Use the correct system() == 0 or die instead of system() or die
2967          - Add descriptive messages to all die statements.
2968
2969 2009-10-27  Steve Block  <steveblock@google.com>
2970
2971         Reviewed by NOBODY.
2972
2973         Adds steveblock@google.com to list of committers.
2974
2975         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2976
2977 2009-10-27  Eric Seidel  <eric@webkit.org>
2978
2979         Reviewed by Adam Barth.
2980
2981         svn-apply can exit(0) even on patch failure
2982         https://bugs.webkit.org/show_bug.cgi?id=29622
2983
2984         * Scripts/svn-apply:
2985          - Add a bunch of "or die" statements, hopefully catching all
2986            possible cases where failure could still exit(0).
2987
2988 2009-10-27  Eric Seidel  <eric@webkit.org>
2989
2990         Reviewed by Adam Barth.
2991
2992         svn-* scripts should share code through VCSUtils.pm
2993         https://bugs.webkit.org/show_bug.cgi?id=30791
2994
2995         Just moving code into a shared location.
2996
2997         * Scripts/VCSUtils.pm:
2998         * Scripts/prepare-ChangeLog:
2999         * Scripts/resolve-ChangeLogs:
3000         * Scripts/svn-apply:
3001         * Scripts/svn-create-patch:
3002         * Scripts/svn-unapply:
3003         * Scripts/update-webkit:
3004
3005 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
3006
3007         Suppress a huge number of MSVC warnings when building wxWebKit.
3008
3009         * wx/build/settings.py:
3010
3011 2009-10-26  Eric Seidel  <eric@webkit.org>
3012
3013         No review, just adding Mike Belshe to the committers list.
3014
3015         * Scripts/modules/committers.py:
3016
3017 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3018
3019         Reviewed by Darin Adler.
3020
3021         Make .rc files compile on Windows without depending on MFC headers
3022         https://bugs.webkit.org/show_bug.cgi?id=30750
3023
3024         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
3025         windows.h instead of afxres.h because it exists even when MFC is not 
3026         installed, and is all that's needed here.
3027
3028         * FindSafari/FindSafari.rc: Ditto
3029
3030 2009-10-24  Eric Seidel  <eric@webkit.org>
3031
3032         Reviewed by Adam Barth.
3033
3034         bugzilla-tool post-diff should know how to mark commit-queue=?
3035         https://bugs.webkit.org/show_bug.cgi?id=29202
3036
3037         * Scripts/bugzilla-tool:
3038          - Add --commit-queue option to post-diff, post-commits and create-bug.
3039         * Scripts/modules/bugzilla.py:
3040          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
3041          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
3042
3043 2009-10-23  Eric Seidel  <eric@webkit.org>
3044
3045         Reviewed by Adam Barth.
3046
3047         bugzilla-tool commit-queue does not notice modifications to committers.py
3048         https://bugs.webkit.org/show_bug.cgi?id=30084
3049
3050         * Scripts/bugzilla-tool:
3051          - Make commit-queue re-exec itself instead of using while(1).
3052          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
3053          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
3054
3055 2009-10-22  Eric Seidel  <eric@webkit.org>
3056
3057         Reviewed by Adam Barth.
3058
3059         commit-queue will get stuck on patches if land-patches terminates unexpectedly
3060         https://bugs.webkit.org/show_bug.cgi?id=30634
3061
3062         * Scripts/bugzilla-tool:
3063          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
3064          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
3065
3066 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
3067
3068         Reviewed by Eric Seidel.
3069
3070         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
3071
3072         https://bugs.webkit.org/show_bug.cgi?id=30763
3073
3074         * pywebsocket/mod_pywebsocket/__init__.py:
3075         * pywebsocket/mod_pywebsocket/dispatch.py:
3076         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
3077         * pywebsocket/mod_pywebsocket/standalone.py:
3078         * pywebsocket/setup.py:
3079         * pywebsocket/test/test_dispatch.py:
3080
3081 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
3082
3083         Reviewed by David Levin.
3084
3085         REGRESSION: 2 failures in run-webkit-unittests
3086         https://bugs.webkit.org/show_bug.cgi?id=30645
3087
3088         * Scripts/modules/cpp_style_unittest.py:
3089         Fixed a few test scenarios which apparently lost some spaces from 
3090         text literals.
3091
3092 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
3093
3094         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
3095
3096         * Scripts/webkitdirs.pm:
3097
3098 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
3099
3100         Reviewed by Darin Adler.
3101
3102         Unification of using null device in perl scripts.
3103         https://bugs.webkit.org/show_bug.cgi?id=30572
3104
3105         * Scripts/VCSUtils.pm:
3106         * Scripts/bisect-builds:
3107         * Scripts/resolve-ChangeLogs:
3108         * Scripts/run-iexploder-tests:
3109         * Scripts/run-jsc:
3110         * Scripts/run-mangleme-tests:
3111         * Scripts/run-webkit-tests:
3112         * Scripts/webkitdirs.pm:
3113         Using File::Spec->devnull() instead of hard coded /dev/null.
3114
3115 2009-10-26  Eric Seidel  <eric@webkit.org>
3116
3117         Reviewed by Holger Freyther.
3118
3119         Reviewers are missing from committers.py
3120         https://bugs.webkit.org/show_bug.cgi?id=30733
3121
3122         * Scripts/modules/committers.py:
3123
3124 2009-10-23  Eric Seidel  <eric@webkit.org>
3125
3126         No review, only adding Alice to the list of reviewers.
3127
3128         * Scripts/modules/committers.py:
3129
3130 2009-10-23  Eric Seidel  <eric@webkit.org>
3131
3132         Reviewed by Eric Carlson.
3133
3134         fast/media/mq-transform-02.html failed on Leopard Commit Bot
3135         https://bugs.webkit.org/show_bug.cgi?id=30700
3136
3137         * DumpRenderTree/mac/DumpRenderTree.mm:
3138         (resetDefaultsToConsistentValues): Update QuickTime version check.
3139
3140 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
3141
3142         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
3143         character measurement APIs that are private on Tiger.
3144
3145         * wx/build/settings.py:
3146
3147 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3148
3149         Reviewed by NOBODY (build fix).
3150         Build fix following bug #30696.
3151
3152         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3153         (LayoutTestController::evaluateScriptInIsolatedWorld):
3154
3155 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3156
3157         Reviewed by Sam Weinig & Geoff Garen.
3158
3159         https://bugs.webkit.org/show_bug.cgi?id=30696
3160         Enable isolated-worlds tests on mac.
3161
3162         Add private interface for DRT to invoke execution in a given world.
3163
3164         * DumpRenderTree/LayoutTestController.cpp:
3165         (evaluateScriptInIsolatedWorldCallback):
3166         (LayoutTestController::staticFunctions):
3167         * DumpRenderTree/LayoutTestController.h:
3168         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3169         (LayoutTestController::evaluateScriptInIsolatedWorld):
3170         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3171         (LayoutTestController::evaluateScriptInIsolatedWorld):
3172
3173 2009-10-21  Eric Seidel  <eric@webkit.org>
3174
3175         Reviewed by Adam Barth.
3176
3177         bugzilla-tool's "patch failed to download an apply" error should give more information
3178         https://bugs.webkit.org/show_bug.cgi?id=30632
3179
3180         * Scripts/modules/scm.py:
3181          - Use the common run_command method instead of custom POpen code.
3182          - Make run_command know how to take pipes as input.
3183         * Scripts/modules/scm_unittest.py:
3184          - Add new tests to cover change.
3185          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
3186
3187 2009-10-21  Kent Tamura  <tkent@chromium.org>
3188
3189         Unreviewed.  Adding myself to the committers list.
3190
3191         * Scripts/modules/committers.py:
3192
3193 2009-10-21  Robin Dunn  <robin@alldunn.com>
3194
3195         Reviewed by Kevin Ollivier.
3196
3197         Update the Windows installer builder to work with Vista / Win 7 and with git.
3198         
3199         https://bugs.webkit.org/show_bug.cgi?id=30649
3200
3201         * wx/build/build_utils.py:
3202         * wx/packaging/build-mac-installer.py:
3203         * wx/packaging/build-win-installer.py:
3204         * wx/packaging/wxWebKitInstaller.iss.in:
3205
3206 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3207
3208         Reviewed by Gustavo Noronha.
3209
3210         [GTK] Added conditional code to avoid using
3211         gdk_window_get_root_coords if we do not have a gtk+ release newer
3212         than 2.17.3.
3213         https://bugs.webkit.org/show_bug.cgi?id=30636
3214
3215         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3216
3217 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3218
3219         Reviewed by Eric Seidel.
3220
3221         [Qt] Added dummy implementation for keepWebHistory()
3222         https://bugs.webkit.org/show_bug.cgi?id=30592
3223
3224         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3225         (LayoutTestController::keepWebHistory):
3226         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3227
3228 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3229
3230         Reviewed by Xan Lopez.
3231
3232         [GTK] Fixed the double click condition, it is not double click if
3233         we move in just in one direction.
3234         https://bugs.webkit.org/show_bug.cgi?id=30636
3235
3236         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3237
3238 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3239
3240         Reviewed by Xan Lopez.
3241
3242         [GTK] Initialize the events completly before emitting them.
3243         https://bugs.webkit.org/show_bug.cgi?id=30633
3244
3245         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3246
3247 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3248
3249         wx build fix. Fix for when linking using --as-needed with gcc.
3250
3251         * wx/browser/wscript:
3252
3253 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3254
3255         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3256         to support all the features used by CURL backend.
3257         
3258         * wx/build/settings.py:
3259         * wx/install-unix-extras:
3260
3261 2009-10-20  Anton Muhin  <antonm@chromium.org>
3262
3263         Reviewed by Adam Barth.
3264
3265         Add {ager,antonm,yurys}@chromium.org into committers.py
3266         https://bugs.webkit.org/show_bug.cgi?id=30560
3267
3268         * Scripts/modules/committers.py:
3269
3270 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3271
3272         Reviewed by Tor Arne Vestbø.
3273
3274         Make the Netscape Test plugin available to the Qt launcher.
3275
3276         * Scripts/run-launcher:
3277
3278 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3279
3280         Reviewed by David Levin.
3281
3282         Removed WebSocket runtime settings.
3283         https://bugs.webkit.org/show_bug.cgi?id=29896
3284
3285         WebSocket runtime configuration is supported by chromium/v8 only.
3286
3287         * DumpRenderTree/mac/DumpRenderTree.mm:
3288         (resetDefaultsToConsistentValues):
3289         * DumpRenderTree/win/DumpRenderTree.cpp:
3290         (resetDefaultsToConsistentValues):
3291
3292 2009-10-19  Nate Chapin  <japhet@chromium.org>
3293
3294         Reviewed by Adam Barth.
3295
3296         Add testFail() to test plugin so we can test our handling of a
3297         plugin invoke call returning false.
3298
3299         https://bugs.webkit.org/show_bug.cgi?id=30239
3300
3301         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3302         (pluginInvoke):
3303         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3304
3305 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3306
3307         Reviewed by Gustavo Noronha.
3308
3309         Enable DOM pasting when running layout tests.
3310
3311         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3312         (resetDefaultsToConsistentValues):
3313
3314 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3315
3316         Reviewed by Simon Hausmann.
3317
3318         Use the setPreferredContentsSize method instead
3319         of setFixedContentsSize, as the method has been renamed.
3320
3321         * DumpRenderTree/qt/DumpRenderTree.cpp:
3322         (WebCore::DumpRenderTree::open):
3323         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3324         (LayoutTestController::setFixedContentsSize):
3325
3326 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3327
3328         Reviewed by Dan Bernstein.
3329
3330         https://bugs.webkit.org/show_bug.cgi?id=30456
3331         Fixes for new Debug_All Windows build configuration.
3332
3333         * DumpRenderTree/win/DumpRenderTree.cpp:
3334         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3335         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3336
3337 2009-10-16  Eric Seidel  <eric@webkit.org>
3338
3339         Reviewed by Adam Barth.
3340
3341         commit-queue status bot should list which buildbot is blocking the queue
3342         https://bugs.webkit.org/show_bug.cgi?id=30452
3343
3344         Add new methods and testing.
3345
3346         * Scripts/bugzilla-tool:
3347         * Scripts/modules/buildbot.py:
3348         * Scripts/modules/buildbot_unittest.py:
3349
3350 2009-10-16  Eric Seidel  <eric@webkit.org>
3351
3352         Reviewed by Adam Barth.
3353
3354         run-webkit-tests fails when CWD is not inside a WebKit checkout
3355         https://bugs.webkit.org/show_bug.cgi?id=30451
3356
3357         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3358         * Scripts/modules/scm_unittest.py:
3359           - Remove use of original_path (we don't need to restore the CWD).
3360           - Don't use '.' to find the webkit checkout, use __file__ instead.
3361
3362 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3363
3364         Reviewed by Adam Roben.
3365
3366         Add a Debug_All configuration to build entire stack as debug.
3367         Change Debug_Internal to:
3368         - stop using _debug suffix for all WebKit/Safari binaries
3369         - not use _debug as a DLL naming suffix
3370         - use non-debug C runtime lib.
3371
3372         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3373         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3374         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3375         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3376         Add missing debug.vsprops inherited property sheet.
3377         Add Debug_All configuration.
3378         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3379         * WinLauncher/WinLauncher.vcproj:
3380         Removed extraneous definitions inherited from vsprops.
3381         Add Debug_All configuration.
3382
3383 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3384
3385         Reviewed by David Levin.
3386
3387         check-webkit-style is wrong about indent checking in namespaces
3388         in header files and a few other things
3389         https://bugs.webkit.org/show_bug.cgi?id=30362
3390
3391         The few other things include:
3392         + check-webkit-style does not require spaces around the equal sign
3393           inside 'if' statements and around binary operators that take 
3394           numeric literals.
3395         + check-webkit-style reports false errors for the / operator
3396           when part of a filename in the #include directive.
3397
3398         * Scripts/modules/cpp_style.py:
3399         Improved indentation checking and space checking around
3400         binary operators. While the checks are still not perfect,
3401         they are clearly better than before.
3402         * Scripts/modules/cpp_style_unittest.py:
3403         Added test cases for the newly supported checks and modified old
3404         test cases to match the new guidelines
3405
3406 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3407
3408         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3409
3410         * wx/build/settings.py:
3411
3412 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3413
3414         Reviewed by David Levin.
3415
3416         Add mod_pywebsocket to test Web Sockets.
3417         http://code.google.com/p/pywebsocket/
3418         https://bugs.webkit.org/show_bug.cgi?id=27490
3419
3420         * pywebsocket/COPYING: Added.
3421         * pywebsocket/MANIFEST.in: Added.
3422         * pywebsocket/README: Added.
3423         * pywebsocket/example/echo_client.py: Added.
3424         * pywebsocket/example/echo_wsh.py: Added.
3425         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3426         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3427         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3428         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3429         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3430         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3431         * pywebsocket/mod_pywebsocket/util.py: Added.
3432         * pywebsocket/setup.py: Added.
3433         * pywebsocket/test/config.py: Added.
3434         * pywebsocket/test/mock.py: Added.
3435         * pywebsocket/test/run_all.py: Added.
3436         * pywebsocket/test/test_dispatch.py: Added.
3437         * pywebsocket/test/test_handshake.py: Added.
3438         * pywebsocket/test/test_mock.py: Added.
3439         * pywebsocket/test/test_msgutil.py: Added.
3440         * pywebsocket/test/test_util.py: Added.
3441         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3442         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3443         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3444         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3445         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3446         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3447         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3448         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3449
3450 2009-10-15  James Robinson  <jamesr@google.com>
3451
3452         Reviewed by David Levin.
3453
3454         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3455
3456         https://bugs.webkit.org/show_bug.cgi?id=30426
3457
3458         * Scripts/modules/cpp_style.py:
3459         * Scripts/modules/cpp_style_unittest.py:
3460
3461 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3462
3463         Reviewed by Adam Roben.
3464
3465         Fixes <http://webkit.org/b/30411>.
3466         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3467         
3468         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3469         building Chromium.
3470
3471         * Scripts/pdevenv:
3472
3473 2009-10-15  Robin Dunn  <robin@alldunn.com>
3474
3475         Reviewed by Kevin Ollivier.
3476
3477         Add Mac package building scripts for wx.
3478         
3479         https://bugs.webkit.org/show_bug.cgi?id=30405
3480
3481         * wx/build/build_utils.py:
3482         * wx/build/settings.py:
3483         * wx/packaging/build-mac-installer.py: Added.
3484
3485 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3486
3487         Reviewed by Gustavo Noronha.
3488
3489         Enable Web Sockets support when running layout tests.
3490
3491         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3492         (resetDefaultsToConsistentValues):
3493
3494 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3495
3496         Reviewed by Gustavo Noronha.
3497
3498         Need to initialize event.button.button, since in most cases a
3499         button number is not passed as an argument.
3500
3501         * DumpRenderTree/gtk/EventSender.cpp:
3502         (mouseDownCallback):
3503         (mouseUpCallback):
3504
3505 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3506
3507         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3508         the OS if none was explicitly set.
3509
3510         * wx/build/settings.py:
3511
3512 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3513
3514         Reviewed by Timothy Hatcher.
3515
3516         Web Inspector: enable developers extras within inspector layout tests.
3517
3518         https://bugs.webkit.org/show_bug.cgi?id=30014
3519
3520         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3521         (LayoutTestController::showWebInspector):
3522         (LayoutTestController::closeWebInspector):
3523         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3524         (LayoutTestController::showWebInspector):
3525         (LayoutTestController::closeWebInspector):
3526
3527 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3528
3529         Reviewed by Jan Alonzo.
3530
3531         GtkLauncher is using a deprecated signal
3532         https://bugs.webkit.org/show_bug.cgi?id=30364
3533
3534         Modified GtkLauncher to use notify::title signal instead of
3535         deprecated title-changed signal
3536
3537         * GtkLauncher/main.c:
3538         (notify_title_cb):
3539         (create_browser):
3540
3541 2009-10-14  Brady Eidson  <beidson@apple.com>
3542
3543         Reviewed by Sam Weinig.
3544
3545         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3546         1 - Disables WebHistory
3547         2 - Doesn't make sense in that context anyway.
3548
3549         * DumpRenderTree/win/DumpRenderTree.cpp:
3550         (createWebViewAndOffscreenWindow):
3551
3552 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3553
3554         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3555         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3556
3557         * wx/build/settings.py:
3558         * wx/install-unix-extras:
3559
3560 2009-10-14  Brady Eidson  <beidson@apple.com>
3561
3562         Reviewed by Sam Weinig.
3563
3564         WebKit Win API should provide a delegate interface for global history.
3565         https://bugs.webkit.org/show_bug.cgi?id=29905
3566
3567         * DumpRenderTree/LayoutTestController.cpp:
3568         (LayoutTestController::LayoutTestController):
3569         * DumpRenderTree/LayoutTestController.h:
3570         (LayoutTestController::dumpHistoryDelegateCallbacks):
3571         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3572                 
3573         * DumpRenderTree/win/DumpRenderTree.cpp:
3574         (shouldLogHistoryDelegates):
3575         (runTest):
3576         (createWebViewAndOffscreenWindow):
3577         (main):
3578         * DumpRenderTree/win/DumpRenderTree.vcproj:
3579         
3580         Add the IWebHistoryDelegate to DRT Windows:
3581         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3582         (wstringFromBSTR):
3583         (HistoryDelegate::HistoryDelegate):
3584         (HistoryDelegate::~HistoryDelegate):
3585         (HistoryDelegate::QueryInterface):
3586         (HistoryDelegate::AddRef):
3587         (HistoryDelegate::Release):
3588         (HistoryDelegate::didNavigateWithNavigationData):
3589         (HistoryDelegate::didPerformClientRedirectFromURL):
3590         (HistoryDelegate::didPerformServerRedirectFromURL):
3591         (HistoryDelegate::updateHistoryTitle):
3592         (HistoryDelegate::populateVisitedLinksForWebView):
3593         * DumpRenderTree/win/HistoryDelegate.h: Added.
3594
3595         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3596         (LayoutTestController::removeAllVisitedLinks):
3597
3598 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3599
3600         Reviewed by Simon Hausmann.
3601
3602         [Qt] Implement support for setPOSIXLocale on Qt.
3603         https://bugs.webkit.org/show_bug.cgi?id=30268 
3604  
3605         * DumpRenderTree/qt/DumpRenderTree.cpp:
3606         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3607         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3608         (LayoutTestController::setPOSIXLocale):
3609         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3610
3611 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3612
3613         Unreviewed, adding myself to reviewers list.
3614
3615         * Scripts/modules/committers.py:
3616
3617 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3618
3619         Reviewed by Mark Rowe.
3620
3621         Fix null assignment so root tests work again.
3622
3623         * Scripts/webkitdirs.pm:
3624
3625 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3626
3627         Reviewed by Simon Hausmann.
3628
3629         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3630         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3631         This is done in preparation of implementing missing features in DRT.
3632         No functionality changes made yet.
3633
3634         * DumpRenderTree/qt/DumpRenderTree.cpp:
3635         * DumpRenderTree/qt/DumpRenderTree.pro:
3636         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3637         (EventSender::EventSender):
3638         (EventSender::mouseDown):
3639         (EventSender::mouseUp):
3640         (EventSender::mouseMoveTo):
3641         (EventSender::leapForward):
3642         (EventSender::keyDown):
3643         (EventSender::contextClick):
3644         (EventSender::scheduleAsynchronousClick):
3645         (EventSender::frameUnderMouse):
3646         * DumpRenderTree/qt/EventSenderQt.h: Added.
3647         (EventSender::clearKillRing):
3648         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3649         (LayoutTestController::LayoutTestController):
3650         (LayoutTestController::reset):
3651         (LayoutTestController::processWork):
3652         (LayoutTestController::maybeDump):
3653         (LayoutTestController::waitUntilDone):
3654         (LayoutTestController::notifyDone):
3655         (LayoutTestController::windowCount):
3656         (LayoutTestController::clearBackForwardList):
3657         (LayoutTestController::dumpEditingCallbacks):
3658         (LayoutTestController::dumpResourceLoadCallbacks):
3659         (LayoutTestController::queueBackNavigation):
3660         (LayoutTestController::queueForwardNavigation):
3661         (LayoutTestController::queueLoad):
3662         (LayoutTestController::queueReload):
3663         (LayoutTestController::queueScript):
3664         (LayoutTestController::provisionalLoad):
3665         (LayoutTestController::timerEvent):
3666         (LayoutTestController::encodeHostName):
3667         (LayoutTestController::decodeHostName):
3668         (LayoutTestController::setJavaScriptProfilingEnabled):
3669         (LayoutTestController::setFixedContentsSize):
3670         (LayoutTestController::setPrivateBrowsingEnabled):
3671         (LayoutTestController::setPopupBlockingEnabled):
3672         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3673         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3674         (LayoutTestController::numberOfActiveAnimations):
3675         (LayoutTestController::disableImageLoading):
3676         (LayoutTestController::dispatchPendingLoadRequests):
3677         (LayoutTestController::setDatabaseQuota):
3678         (LayoutTestController::clearAllDatabases):
3679         (LayoutTestController::whiteListAccessFromOrigin):
3680         (LayoutTestController::waitForPolicyDelegate):
3681         (LayoutTestController::overridePreference):
3682         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3683         (LayoutTestController::isLoading):
3684         (LayoutTestController::setLoading):
3685         (LayoutTestController::shouldDumpAsText):
3686         (LayoutTestController::shouldDumpBackForwardList):
3687         (LayoutTestController::shouldDumpChildrenAsText):
3688         (LayoutTestController::shouldDumpDatabaseCallbacks):
3689         (LayoutTestController::shouldDumpStatusCallbacks):
3690         (LayoutTestController::shouldWaitUntilDone):
3691         (LayoutTestController::canOpenWindows):
3692         (LayoutTestController::shouldDumpTitleChanges):
3693         (LayoutTestController::waitForPolicy):
3694         (LayoutTestController::dumpAsText):
3695         (LayoutTestController::dumpChildFramesAsText):
3696         (LayoutTestController::dumpDatabaseCallbacks):
3697         (LayoutTestController::dumpStatusCallbacks):
3698         (LayoutTestController::setCanOpenWindows):
3699         (LayoutTestController::dumpBackForwardList):
3700         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3701         (LayoutTestController::display):
3702         (LayoutTestController::dumpTitleChanges):
3703         (LayoutTestController::dumpSelectionRect):
3704         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3705         (TextInputController::TextInputController):
3706         (TextInputController::doCommand):
3707         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3708         * DumpRenderTree/qt/WorkQueue.cpp:
3709         * DumpRenderTree/qt/WorkQueue.h:
3710         * DumpRenderTree/qt/WorkQueueItem.h:
3711         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3712         (findFrameNamed):
3713         (LoadItem::invoke):
3714         (ReloadItem::invoke):
3715         (ScriptItem::invoke):
3716         (BackForwardItem::invoke):
3717         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3718         * DumpRenderTree/qt/jsobjects.h:
3719
3720 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3721
3722         Not reviewed, adding myself to the list of reviewers.
3723
3724         * Scripts/modules/committers.py:
3725
3726 2009-10-13  Anders Carlsson  <andersca@apple.com>
3727
3728         Reviewed by Sam Weinig.
3729
3730         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3731
3732         Make the private browsing mode testable by the test plug-in.
3733         
3734         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3735         (pluginGetProperty):
3736         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3737         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3738         (NPP_New):
3739         (NPP_SetValue):
3740
3741 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3742
3743         No review, just adding self to the list of reviewers.
3744
3745         * Scripts/modules/committers.py:
3746
3747 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3748
3749         Reviewed by Adam Roben.
3750
3751         Web Inspector: Use proper web view in inspector layout
3752         tests for windows.
3753
3754         https://bugs.webkit.org/show_bug.cgi?id=30298
3755
3756         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3757         (LayoutTestController::showWebInspector):
3758         (LayoutTestController::closeWebInspector):
3759         (LayoutTestController::evaluateInWebInspector):
3760
3761 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3762
3763         Reviewed by Sam Weinig.
3764
3765         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3766         https://bugs.webkit.org/show_bug.cgi?id=29841
3767
3768         * DumpRenderTree/mac/DumpRenderTree.mm:
3769         (resetDefaultsToConsistentValues):
3770         * DumpRenderTree/win/DumpRenderTree.cpp:
3771         (resetDefaultsToConsistentValues):
3772
3773 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3774
3775         Reviewed by Dimitri Glazkov.
3776
3777         Chromium Port - Windows
3778         https://bugs.webkit.org/show_bug.cgi?id=29969
3779
3780         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3781         * Scripts/webkitdirs.pm:
3782
3783 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3784
3785         Reviewed by Darin Adler.
3786
3787         jsc scripts cleanup and Qt/GTK fix
3788         https://bugs.webkit.org/show_bug.cgi?id=30288
3789
3790         Duplicated jscPath() moved to webkitdirs.pm.
3791         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3792         Configuration added (release/debug) to path for Qt-port on Windows.
3793
3794         * Scripts/run-javascriptcore-tests:
3795         * Scripts/run-jsc:
3796         * Scripts/run-sunspider:
3797         * Scripts/sunspider-compare-results:
3798         * Scripts/webkitdirs.pm:
3799
3800 2009-10-11  Adam Barth  <abarth@webkit.org>
3801
3802         Unreviewed.  Add Collin to committers.py.
3803
3804         * Scripts/modules/committers.py:
3805
3806 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3807
3808         wx build fix, add bindings to source/include dirs now that there are sources there.
3809
3810         * wx/build/settings.py:
3811
3812 2009-10-09  Mark Rowe  <mrowe@apple.com>
3813
3814         Reviewed by Brady Eidson.
3815
3816         Enable plug-in halting in DumpRenderTree.
3817
3818         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3819         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3820
3821         * DumpRenderTree/mac/DumpRenderTree.mm:
3822         (resetDefaultsToConsistentValues):
3823         * DumpRenderTree/mac/UIDelegate.mm:
3824         (-[UIDelegate webView:shouldHaltPlugin:]):
3825
3826 2009-10-08  Brady Eidson  <beidson@apple.com>
3827
3828         Reviewed by Dan Bernstein.
3829
3830         Ask the History Delegate to populate the visited links hash.
3831         <rdar://problem/7285293> and https://webkit.org/b/29904
3832
3833         Add the ability for LayoutTestController to clear all visited links.
3834         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3835
3836         * DumpRenderTree/LayoutTestController.cpp:
3837         (LayoutTestController::LayoutTestController):
3838         (removeAllVisitedLinksCallback):
3839         (LayoutTestController::staticFunctions):
3840         * DumpRenderTree/LayoutTestController.h:
3841         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3842         (LayoutTestController::removeAllVisitedLinks):
3843
3844         * DumpRenderTree/mac/HistoryDelegate.mm:
3845         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3846
3847         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3848         (LayoutTestController::removeAllVisitedLinks):
3849         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3850         (LayoutTestController::removeAllVisitedLinks):
3851         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3852         (LayoutTestController::removeAllVisitedLinks):
3853
3854
3855 2009-10-08  Daniel Bates  <dbates@webkit.org>
3856
3857         Reviewed by Adam Roben.
3858
3859         https://bugs.webkit.org/show_bug.cgi?id=30175
3860         
3861         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3862         the OLE drag-and-drop return value like the function it emulates. Currently, 
3863         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3864         whether the drag-and-drop operation was successful or was cancelled.
3865         
3866         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3867         return value according to whether the drop operation was successful or not.
3868
3869         * DumpRenderTree/win/EventSender.cpp:
3870         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3871         (replaySavedEvents): Ditto.
3872         * DumpRenderTree/win/EventSender.h:
3873         * DumpRenderTree/win/UIDelegate.cpp:
3874         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3875
3876 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3877
3878         Reviewed by Xan Lopez.
3879
3880         [GTK] Added support for a parameter setting the button that was
3881         pressed in the mouseDown function.
3882         https://bugs.webkit.org/show_bug.cgi?id=30220
3883
3884         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3885
3886 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3887
3888         Reviewed by Xan Lopez.
3889
3890         [GTK] Added a line to the bottom of the expected result to match
3891         the output of the test.
3892         https://bugs.webkit.org/show_bug.cgi?id=30220
3893
3894         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3895         expected.txt:
3896
3897 2009-10-08  Adam Roben  <aroben@apple.com>
3898
3899         Use QueryInterface to get IWebInspectorPrivate
3900
3901         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3902         accessed in a more standard way
3903
3904         Reviewed by John Sullivan and Tim Hatcher.
3905
3906         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3907         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3908         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3909         to the IWebInspectorPrivate interface.
3910
3911 2009-10-07  Adam Roben  <aroben@apple.com>
3912
3913         Implement DRT support for origin whitelisting
3914
3915         Fixes <http://webkit.org/b/30185>.
3916
3917         Reviewed by Eric Seidel.
3918
3919         * DumpRenderTree/win/DumpRenderTree.cpp:
3920         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3921         whitelist, to match Mac DRT.
3922         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3923         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3924         IWebViewPrivate::whiteListAccessFromOrigin.
3925
3926 2009-10-07  Brady Eidson  <beidson@apple.com>
3927
3928         Reviewed by Darin Adler.
3929
3930         Send title changes to the global history delegate.
3931         <rdar://problem/7285293> and https://webkit.org/b/29904
3932
3933         * DumpRenderTree/mac/HistoryDelegate.mm:
3934         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3935
3936 2009-10-07  Adam Barth  <abarth@webkit.org>
3937
3938         Unreviewed.  Remove some folks from committers.py who were listed on
3939         the WebKit Team wiki page but who weren't actually listed as commit+.
3940         At some point, we should coorelate this list with the committers
3941         mailing list.
3942
3943         * Scripts/modules/committers.py:
3944
3945 2009-10-07  Adam Barth  <abarth@webkit.org>
3946
3947         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3948         the wiki into committers.py.
3949
3950         * Scripts/modules/committers.py:
3951
3952 2009-10-07  Adam Barth  <abarth@webkit.org>
3953
3954         Unreviewed.  Added Aaron Boodman to committers.py.
3955
3956         * Scripts/modules/committers.py:
3957
3958 2009-10-07  Evan Martin  <evan@chromium.org>
3959
3960         Reviewed by Darin Adler.
3961
3962         Add API to LayoutTestController for re/setting the system locale.
3963         https://bugs.webkit.org/show_bug.cgi?id=18994
3964
3965         * DumpRenderTree/LayoutTestController.cpp:
3966         (setLocaleCallback):
3967         (LayoutTestController::staticFunctions):
3968         (LayoutTestController::setLocale):
3969         * DumpRenderTree/LayoutTestController.h:
3970
3971 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3972
3973         Reviewed by Jan Alonzo.
3974
3975         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3976         https://bugs.webkit.org/show_bug.cgi?id=29689
3977
3978         Build fix by adding -lfontconfig for DumpRenderTree.
3979
3980         * GNUmakefile.am:
3981
3982 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3983
3984         Reviewed by Simon Hausmann.
3985
3986         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3987
3988         * Scripts/run-webkit-tests:
3989
3990 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3991
3992         Reviewed by Gustavo Noronha.
3993
3994         "delete" in EventSender is the backspace key, not the delete one.
3995
3996         * DumpRenderTree/gtk/EventSender.cpp:
3997         (keyDownCallback):
3998
3999 2009-10-07  Xan Lopez  <xlopez@igalia.com>
4000
4001         Reviewed by Gustavo Noronha.
4002
4003         getChildrenWithRange expects as last parameter the end index, not
4004         the length of the range. Correct this and clarify the variable
4005         names to reflect how the code works.
4006
4007         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4008         (AccessibilityUIElement::getChildrenWithRange):
4009         (AccessibilityUIElement::getChildAtIndex):
4010
4011 2009-10-06  Mark Rowe  <mrowe@apple.com>
4012
4013         Reviewed by Simon Fraser.
4014
4015         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
4016
4017         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
4018         the fact we have already changed the working directory to the top of the open source tree.
4019
4020 2009-10-06  Julie Parent  <jparent@chromium.org>
4021
4022         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
4023         rather than my committer email.
4024
4025         * Scripts/modules/committers.py:
4026
4027 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4028
4029         Reviewed by Eric Seidel.
4030
4031         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
4032
4033         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
4034         it after each layout test as it should do, making the DRT dump additional output
4035         for all of the subsequent layout tests.
4036
4037         * DumpRenderTree/qt/jsobjects.cpp:
4038         (LayoutTestController::reset):
4039
4040 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4041
4042         Reviewed by Simon Hausmann.
4043
4044         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
4045         fast/dom/assign-to-window-status.html test, which is passing as a result.
4046
4047         https://bugs.webkit.org/show_bug.cgi?id=30127
4048
4049         * DumpRenderTree/qt/DumpRenderTree.cpp:
4050         (WebCore::DumpRenderTree::DumpRenderTree):
4051         (WebCore::DumpRenderTree::statusBarMessage):
4052         * DumpRenderTree/qt/DumpRenderTree.h:
4053         * DumpRenderTree/qt/jsobjects.h:
4054         (LayoutTestController::shouldDumpStatusCallbacks):
4055         (LayoutTestController::dumpStatusCallbacks):
4056
4057 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4058
4059         Reviewed by Simon Hausmann.
4060
4061         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
4062         ignores the argument indicating which mouse button to trigger.
4063         https://bugs.webkit.org/show_bug.cgi?id=30048
4064
4065         This affects the fast/events/mouse-click-events.html layout test.
4066
4067         * DumpRenderTree/qt/jsobjects.cpp:
4068         (EventSender::mouseDown):
4069         (EventSender::mouseUp):
4070         * DumpRenderTree/qt/jsobjects.h:
4071
4072 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4073
4074         Reviewed by Simon Hausmann.
4075
4076         [Qt] Fix the EventSender::keyDown() implementation
4077         https://bugs.webkit.org/show_bug.cgi?id=30043
4078
4079         It should post both a key press event and a key release event,
4080         just like other ports do.
4081
4082         * DumpRenderTree/qt/jsobjects.cpp:
4083         (EventSender::keyDown):
4084
4085 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
4086
4087         wx build fix. Add jpeg to the list of libs to link against.
4088
4089         * wx/build/settings.py:
4090
4091 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
4092
4093         Reviewed by Simon Hausmann.
4094
4095         [Qt] EventSender::keyDown() cannot send function-key events.
4096         https://bugs.webkit.org/show_bug.cgi?id=30044
4097
4098         This affects the fast/events/keydown-function-keys.html layout test.
4099
4100         * DumpRenderTree/qt/jsobjects.cpp:
4101         (EventSender::keyDown):
4102
4103 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
4104
4105         Added --wx-compiler-prefix waf option to allow building wxWebKit with
4106         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
4107
4108         * wx/build/settings.py:
4109         * wx/build/wxpresets.py:
4110
4111 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
4112
4113         Reviewed by Timothy Hatcher.
4114
4115         Web Inspector: add testing harness for Web Inspector.
4116
4117         https://bugs.webkit.org/show_bug.cgi?id=30010
4118
4119         * DumpRenderTree/LayoutTestController.cpp:
4120         (showWebInspectorCallback):
4121         (closeWebInspectorCallback):
4122         (evaluateInWebInspectorCallback):
4123         (LayoutTestController::staticFunctions):
4124         * DumpRenderTree/LayoutTestController.h:
4125         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4126         (LayoutTestController::showWebInspector):
4127         (LayoutTestController::closeWebInspector):
4128         (LayoutTestController::evaluateInWebInspector):
4129         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4130         (LayoutTestController::showWebInspector):
4131         (LayoutTestController::closeWebInspector):
4132         (LayoutTestController::evaluateInWebInspector):
4133         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4134         (LayoutTestController::showWebInspector):
4135         (LayoutTestController::closeWebInspector):
4136         (LayoutTestController::evaluateInWebInspector):
4137         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4138         (LayoutTestController::showWebInspector):
4139         (LayoutTestController::closeWebInspector):
4140         (LayoutTestController::evaluateInWebInspector):
4141
4142 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4143
4144         Reviewed by Ariyha Hidayat.
4145
4146         Pass arguments to system() as a string instead of array
4147
4148         When passed as an array entries with a space fail to translate
4149         to two arguments to the child process, so instead of manually
4150         splitting all the entries in @buildArgs we pass the whole thing
4151         as a string instead.
4152
4153         * Scripts/webkitdirs.pm:
4154
4155 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
4156
4157         Reviewed by David Levin.
4158
4159         check-webkit-style misses whitespace errors for operators:
4160         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
4161         https://bugs.webkit.org/show_bug.cgi?id=30021
4162
4163         * Scripts/modules/cpp_style.py:
4164         Added the operators mentioned above to the same list as == and !=.
4165
4166 2009-10-02  Julie Parent  <jparent@chromium.org>
4167
4168         Unreviewed.
4169
4170         Adding myself and Ojan Vafai as committers, because we are committers.
4171
4172         * Scripts/modules/committers.py:
4173
4174 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
4175
4176         Reviewed by Adam Roben.
4177
4178         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
4179         this will help the patch merging process when TryBots are used.
4180
4181         * Scripts/svn-create-patch:
4182
4183 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
4184
4185         Reviewed by Simon Hausmann.
4186
4187         [Qt] Implement layoutTestController.overridePreference().
4188         https://bugs.webkit.org/show_bug.cgi?id=29970
4189
4190         * DumpRenderTree/qt/DumpRenderTree.cpp:
4191         (WebCore::WebPage::WebPage):
4192         (WebCore::WebPage::resetSettings):
4193         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4194         * DumpRenderTree/qt/jsobjects.cpp:
4195         (LayoutTestController::reset):
4196         (LayoutTestController::setPrivateBrowsingEnabled):
4197         (LayoutTestController::setPopupBlockingEnabled):
4198         (LayoutTestController::overridePreference):
4199         * DumpRenderTree/qt/jsobjects.h:
4200
4201 2009-10-01  Chris Marrin  <cmarrin@apple.com>
4202
4203         Reviewed by Oliver Hunt.
4204
4205         Turn on ENABLE_3D_CANVAS in TOT
4206         https://bugs.webkit.org/show_bug.cgi?id=29906
4207
4208         * Scripts/build-webkit:
4209
4210 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4211
4212         Rubberstamped by Simon Hausmann.
4213
4214         Enable HTTP tests for Qt
4215
4216         * Scripts/run-webkit-tests:
4217
4218 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
4219
4220         Reviewed by Dimitri Glazkov.
4221
4222         build-webkit --chromium now also works on cygwin.
4223
4224         https://bugs.webkit.org/show_bug.cgi?id=29973
4225
4226         * Scripts/webkitdirs.pm:
4227
4228 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
4229
4230         Reviewed by Simon Hausmann.
4231
4232         [Qt] Don't use TCmalloc in DumpRenderTree
4233         https://bugs.webkit.org/show_bug.cgi?id=27029
4234
4235         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
4236
4237         * DumpRenderTree/qt/DumpRenderTree.pro:
4238
4239 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
4240
4241         Reviewed by Simon Hausmann.
4242
4243         [Qt] Implement eventSender.scheduleAsynchronousClick().
4244
4245         https://bugs.webkit.org/show_bug.cgi?id=29931
4246
4247         * DumpRenderTree/qt/jsobjects.cpp:
4248         (EventSender::scheduleAsynchronousClick):
4249         * DumpRenderTree/qt/jsobjects.h:
4250
4251 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
4252
4253         Reviewed by Simon Hausmann.
4254
4255         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
4256         fast/events/open-window-from-another-frame.html from the Skipped list.
4257
4258         https://bugs.webkit.org/show_bug.cgi?id=29930
4259
4260         * DumpRenderTree/qt/jsobjects.cpp:
4261         (LayoutTestController::setPopupBlockingEnabled):
4262         * DumpRenderTree/qt/jsobjects.h:
4263
4264 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
4265
4266         Unreviewed.
4267
4268         Added myself to the list of committers.
4269
4270         * Scripts/modules/committers.py:
4271
4272 2009-09-30  Eric Seidel  <eric@webkit.org>
4273
4274         No review, just adding Geoff to the list of reviewers.
4275
4276         * Scripts/modules/committers.py:
4277
4278 2009-09-30  Dan Bernstein  <mitz@apple.com>
4279
4280         Reviewed by Sam Weinig.
4281
4282         Added the WebKit Layout Tests fonts that are referenced in
4283         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
4284
4285         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
4286         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
4287
4288 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
4289
4290         Reviewed by David Kilzer.
4291
4292         Make sunspider scripts work on Windows platform.
4293         https://bugs.webkit.org/show_bug.cgi?id=29656
4294
4295         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
4296         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
4297         * Scripts/webkitdirs.pm: currentPerlPath() added.
4298
4299 2009-09-29  Brady Eidson  <beidson@apple.com>
4300
4301         Rubberstamped by Dan Bernstein.
4302
4303         Fix license and some sorting in new files.
4304
4305         * DumpRenderTree/mac/HistoryDelegate.h:
4306         * DumpRenderTree/mac/HistoryDelegate.mm:
4307
4308 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
4309
4310         Reviewed by David Kilzer.
4311
4312         Fixed how error codes are handled.
4313         https://bugs.webkit.org/show_bug.cgi?id=29898
4314
4315         * Scripts/update-webkit:
4316         * Scripts/update-webkit-chromium:
4317
4318 2009-09-29  Brady Eidson  <beidson@apple.com>
4319
4320         Reviewed by John Sullivan.
4321
4322         Updated way-out-of-date sorting throughout the dump methods/flags.
4323
4324         * DumpRenderTree/LayoutTestController.cpp:
4325         (LayoutTestController::LayoutTestController):
4326         (dumpAsPDFCallback):
4327         (dumpAsTextCallback):
4328         (dumpFrameLoadCallbacksCallback):
4329         (dumpResourceLoadCallbacksCallback):
4330         (LayoutTestController::staticFunctions):
4331
4332         * DumpRenderTree/LayoutTestController.h:
4333         (LayoutTestController::dumpAsText):
4334         (LayoutTestController::setDumpAsText):
4335         (LayoutTestController::dumpFrameLoadCallbacks):
4336         (LayoutTestController::setDumpFrameLoadCallbacks):
4337         (LayoutTestController::dumpSelectionRect):
4338         (LayoutTestController::setDumpSelectionRect):
4339         (LayoutTestController::dumpSourceAsWebArchive):
4340         (LayoutTestController::setDumpSourceAsWebArchive):
4341         (LayoutTestController::dumpStatusCallbacks):
4342         (LayoutTestController::setDumpStatusCallbacks):
4343         (LayoutTestController::dumpTitleChanges):
4344         (LayoutTestController::setDumpTitleChanges):
4345         (LayoutTestController::dumpWillCacheResponse):
4346         (LayoutTestController::setDumpWillCacheResponse):
4347
4348 2009-09-29  Brady Eidson  <beidson@apple.com>
4349
4350         Reviewed by John Sullivan.
4351
4352         WebKit Mac API should provide a delegate interface for global history.
4353         <rdar://problem/7042773> and https://webkit.org/b/29904
4354
4355         Adding the dumping of global history delegate callbacks.
4356
4357         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4358
4359         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
4360         * DumpRenderTree/mac/DumpRenderTree.mm:
4361         (createWebViewAndOffscreenWindow):
4362         (allocateGlobalControllers):
4363         (shouldLogFrameLoadDelegates):
4364         (shouldLogHistoryDelegates):
4365         (runTest):
4366
4367         Dump history delegate callbacks:
4368         * DumpRenderTree/mac/HistoryDelegate.h: Added.
4369         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
4370         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
4371         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
4372       &n