b238a5f31ac2d76f87b82e93b522bc02526b1d5e
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-12-06  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Adam Barth.
4
5         Add an API for uploading results files to StatusBot
6         https://bugs.webkit.org/show_bug.cgi?id=32210
7
8         Add Content-Type: plain/text which was forgotten
9         from the previous commit when I landed with land-patches
10         instead of land-diff.
11
12         * QueueStatusServer/queue_status.py:
13
14 2009-12-06  Eric Seidel  <eric@webkit.org>
15
16         Reviewed by Adam Barth.
17
18         Status Server needs a way to handle uploaded results
19         https://bugs.webkit.org/show_bug.cgi?id=32209
20
21         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
22         * QueueStatusServer/update_status.html: Add file upload.
23
24 2009-12-06  Eric Seidel  <eric@webkit.org>
25
26         Reviewed by Adam Barth.
27
28         Add an API for uploading results files to StatusBot
29         https://bugs.webkit.org/show_bug.cgi?id=32210
30
31         * Scripts/modules/statusbot.py:
32
33 2009-12-06  Eric Seidel  <eric@webkit.org>
34
35         Reviewed by Adam Barth.
36
37         Status Server needs a way to handle uploaded results
38         https://bugs.webkit.org/show_bug.cgi?id=32209
39
40         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
41         * QueueStatusServer/update_status.html: Add file upload.
42
43 2009-12-06  Adam Barth  <abarth@webkit.org>
44
45         Reviewed by Eric Seidel.
46
47         [bzt] BuildAttachment should not check the builders
48         https://bugs.webkit.org/show_bug.cgi?id=32207
49
50         This is code that got copied here by accident when the class was created.
51
52         * Scripts/modules/commands/download.py:
53
54 2009-12-06  Adam Barth  <abarth@webkit.org>
55
56         Reviewed by Eric Seidel.
57
58         [bzt] Make LandingSequence.update aware of ports
59         https://bugs.webkit.org/show_bug.cgi?id=32208
60
61         This is required to make build work on the Chromium port because
62         Chromium has a custom update-webkit.
63
64         * Scripts/modules/landingsequence.py:
65
66 2009-12-06  Adam Barth  <abarth@webkit.org>
67
68         Reviewed by Eric Seidel.
69
70         Add early warning system commands to bugzilla-tool.
71
72         * Scripts/bugzilla-tool:
73         * Scripts/modules/landingsequence.py:
74         * Scripts/modules/webkitport.py:
75
76 2009-12-06  Adam Barth  <abarth@webkit.org>
77
78         Reviewed by Eric Seidel.
79
80         [bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem
81         https://bugs.webkit.org/show_bug.cgi?id=32205
82
83         * Scripts/modules/commands/early_warning_system.py: Added.
84         * Scripts/modules/commands/queues.py:
85
86 2009-12-06  Dan Bernstein  <mitz@apple.com>
87
88         Reviewed by Adele Peterson.
89
90         REGRESSION (r51728): update-webkit fails when the current directory is
91         not inside a Subversion working copy
92         https://bugs.webkit.org/show_bug.cgi?id=32204
93
94         * Scripts/update-webkit: Invoke isSVN() in the correct working
95         directory.
96
97 2009-12-06  Adam Barth  <abarth@webkit.org>
98
99         Reviewed by Eric Seidel.
100
101         [bzt] Rename AbstractTryQueue to AbstractReviewQueue
102         https://bugs.webkit.org/show_bug.cgi?id=32202
103
104         * Scripts/modules/commands/queues.py:
105
106 2009-12-05  Adam Barth  <abarth@webkit.org>
107
108         Reviewed by Eric Seidel.
109
110         [bzt] Implement ChromiumPort
111         https://bugs.webkit.org/show_bug.cgi?id=32182
112
113         * Scripts/modules/webkitport.py:
114         * Scripts/modules/webkitport_unittest.py:
115
116 2009-12-05  Adam Barth  <abarth@webkit.org>
117
118         Reviewed by Eric Seidel.
119
120         Move update-webkit into BuildSteps
121         https://bugs.webkit.org/show_bug.cgi?id=32181
122
123         We need to move update-webkit out of SCM.py because SCM isn't supposed to know
124         that WebKit exists.  The proper place for the knowledge of the existence of
125         update-webkit is in WebKitPort because some ports have specialized update
126         scripts (analogous to build-webkit).
127
128         * Scripts/modules/buildsteps.py:
129         * Scripts/modules/commands/download.py:
130         * Scripts/modules/landingsequence.py:
131         * Scripts/modules/scm.py:
132         * Scripts/modules/webkitport.py:
133
134 2009-12-05  Adam Barth  <abarth@webkit.org>
135
136         Reviewed by Eric Seidel.
137
138         update-webkit should call git svn rebase and resolve-ChangeLogs -f
139         https://bugs.webkit.org/show_bug.cgi?id=27162
140
141         Teach update-webkit about Git.  I didn't add the call to
142         resolve-ChangeLogs -f because sometimes that script goes bananas.  We
143         can iterate from here, however.
144
145         * Scripts/update-webkit:
146
147 2009-12-04  Yael Aharon  <yael.aharon@nokia.com>
148
149         Unreviewed build fix.
150
151         [Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.
152
153         * DumpRenderTree/qt/DumpRenderTree.cpp:
154
155 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
156
157         Reviewed by Adam Treat.
158
159         Add some missing methods for showing and hiding the
160         Web Inspector.
161
162         * DumpRenderTree/qt/DumpRenderTree.cpp:
163         (WebCore::WebPage::WebPage):
164         (WebCore::WebPage::~WebPage):
165         (WebCore::WebPage::webInspector):
166         * DumpRenderTree/qt/DumpRenderTree.h:
167         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
168         (LayoutTestController::showWebInspector):
169         (LayoutTestController::hideWebInspector):
170         * DumpRenderTree/qt/LayoutTestControllerQt.h:
171
172 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
173
174         Reviewed by Adam Treat.
175
176         Implement the setAllowUniversalAccessFromFileURLs method
177         for the Qt LayoutTestController.
178
179         * DumpRenderTree/qt/DumpRenderTree.cpp:
180         (WebCore::WebPage::resetSettings):
181         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
182         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
183         * DumpRenderTree/qt/LayoutTestControllerQt.h:
184
185 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
186
187         Reviewed by Darin Adler.
188
189         REGRESSION: AX: buttons now extremely repetitive
190         https://bugs.webkit.org/show_bug.cgi?id=32164
191
192         * DumpRenderTree/AccessibilityUIElement.cpp:
193         (isAttributeSupportedCallback):
194         (AccessibilityUIElement::getJSClass):
195         * DumpRenderTree/AccessibilityUIElement.h:
196         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
197         (AccessibilityUIElement::isAttributeSupported):
198         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
199         (AccessibilityUIElement::isAttributeSupported):
200         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
201         (AccessibilityUIElement::isAttributeSupported):
202
203 2009-12-03  Shinichiro Hamaji  <hamaji@chromium.org>
204
205         Reviewed by David Levin.
206
207         check-webkit-style should check for camelCase variable names
208         https://bugs.webkit.org/show_bug.cgi?id=32051
209
210         * Scripts/modules/cpp_style.py:
211         * Scripts/modules/cpp_style_unittest.py:
212
213 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
214
215         Reviewed by Eric Seidel.
216
217         AX: VO just says "term" on many web sites
218         https://bugs.webkit.org/show_bug.cgi?id=32139
219
220         * DumpRenderTree/AccessibilityUIElement.cpp:
221         (getRoleDescriptionCallback):
222         (AccessibilityUIElement::getJSClass):
223         * DumpRenderTree/AccessibilityUIElement.h:
224         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
225         (AccessibilityUIElement::roleDescription):
226         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
227         (AccessibilityUIElement::roleDescription):
228         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
229         (AccessibilityUIElement::roleDescription):
230
231 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
232
233         Reviewed by Beth Dakin.
234
235         Implement WAI-ARIA scrollbar role and related property aria-orientation
236         https://bugs.webkit.org/show_bug.cgi?id=32126
237
238         * DumpRenderTree/AccessibilityUIElement.cpp:
239         (getOrientationCallback):
240         (AccessibilityUIElement::getJSClass):
241         * DumpRenderTree/AccessibilityUIElement.h:
242         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
243         (AccessibilityUIElement::orientation):
244         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
245         (AccessibilityUIElement::orientation):
246         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
247         (AccessibilityUIElement::orientation):
248
249 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
250
251         Reviewed by Adam Roben.
252
253         Minor correction to r51663.
254
255         * DumpRenderTree/win/DumpRenderTree.cpp:
256         (addQTDirToPATH):
257             GetEnvironmentVariable -> GetEnvironmentVariableW.
258
259 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
260
261         Reviewed by Adam Roben.
262
263         ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
264         https://bugs.webkit.org/show_bug.cgi?id=30256
265
266         Add the QuickTime dll directory to the PATH environment variable so
267         inialization can succeed.
268
269         * DumpRenderTree/win/DumpRenderTree.cpp:
270         (addQTDirToPATH):
271         (initialize):
272
273 2009-12-03  Shu Chang  <Chang.Shu@nokia.com>
274
275         Reviewed by Kenneth Rohde Christiansen.
276
277         [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.
278
279         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
280         (LayoutTestController::maybeDump):
281
282 2009-12-03  Yuzo Fujishima  <yuzo@google.com>
283
284         Reviewed by Eric Seidel.
285
286         Update pywebsocket to 0.4.3
287         This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
288         Stack trace is logged now in INFO level.
289         https://bugs.webkit.org/show_bug.cgi?id=32097
290
291         * pywebsocket/mod_pywebsocket/dispatch.py:
292         * pywebsocket/mod_pywebsocket/msgutil.py:
293         * pywebsocket/mod_pywebsocket/standalone.py:
294         * pywebsocket/mod_pywebsocket/util.py:
295         * pywebsocket/setup.py:
296         * pywebsocket/test/test_dispatch.py:
297         * pywebsocket/test/test_util.py:
298
299 2009-12-03  Sam Weinig  <sam@webkit.org>
300
301         Reviewed by Gavin Barraclough.
302
303         Fix JSClassRef leak.
304
305         * DumpRenderTree/AccessibilityController.cpp:
306         (AccessibilityController::makeWindowObject):
307         * DumpRenderTree/GCController.cpp:
308         (GCController::makeWindowObject):
309         * DumpRenderTree/LayoutTestController.cpp:
310         (LayoutTestController::makeWindowObject):
311
312 2009-12-03  Brady Eidson  <beidson@apple.com>
313
314         Reviewed by Sam Weinig.
315
316         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
317
318         Keep DRT-win building...
319
320         * DumpRenderTree/win/FrameLoadDelegate.h:
321         (FrameLoadDelegate::didPushStateWithinPageForFrame):
322         (FrameLoadDelegate::didReplaceStateWithinPageForFrame):
323         (FrameLoadDelegate::didPopStateWithinPageForFrame):
324
325 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
326
327         Unreviewed build fix.
328
329         [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
330
331         * DumpRenderTree/qt/DumpRenderTree.cpp:
332
333 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
334
335         Reviewed by Kenneth Rohde Christiansen.
336
337         [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
338         Prevent DRT from showing the main view if these childs get deleted.
339         This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
340
341         * DumpRenderTree/qt/DumpRenderTree.cpp:
342         (WebCore::WebPage::WebPage):
343         (WebCore::DumpRenderTree::DumpRenderTree):
344         (WebCore::DumpRenderTree::~DumpRenderTree):
345         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
346         (WebCore::DumpRenderTree::open):
347         (WebCore::DumpRenderTree::closeRemainingWindows):
348         (WebCore::DumpRenderTree::createWindow):
349         (WebCore::DumpRenderTree::windowCount):
350         * DumpRenderTree/qt/DumpRenderTree.h:
351
352 2009-12-02  Eric Seidel  <eric@webkit.org>
353
354         Reviewed by Adam Barth.
355
356         REGRESSION(51595): commit-queue is throwing exceptions
357         https://bugs.webkit.org/show_bug.cgi?id=32083
358
359         * Scripts/modules/commands/queues.py:
360          - Don't use default value of [] as it ends up getting shared.
361          - Make log_progress accept arrays of ints as well as strings.
362          - Return an exit code from execute()
363         * Scripts/modules/commands/queues_unittest.py: Added.
364          - Test to make sure log_progress will accept ints.
365          - Test to make sure run_bugzilla_tool will accept ints.
366         * Scripts/modules/workqueue.py:
367          - Print the stack trace on unexpected exceptions for easier debugging.
368         * Scripts/run-webkit-unittests:
369          - Add queues_unittest.
370
371         * Scripts/modules/commands/queues.py:
372         * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
373         * Scripts/modules/mock_bugzillatool.py:
374         * Scripts/modules/workqueue.py:
375         * Scripts/run-webkit-unittests:
376
377 2009-12-02  David Levin  <levin@chromium.org>
378
379         Reviewed by Adam Barth.
380
381         check-webkit-style is too noisy about namespace indenting issues.
382         https://bugs.webkit.org/show_bug.cgi?id=32096
383
384         * Scripts/modules/cpp_style.py:
385         Added a _FileState object to be able to track file level information. In this
386         case, it simply tracks whether the error has already been given, so that it isn't
387         done again.
388         * Scripts/modules/cpp_style_unittest.py:
389         Modified test cases to pass in the _FileState object and fix a test that expected
390         to see the namespace error twice (now it only occurs once). No new tests because
391         existing tests cover the change in functionality.
392
393 2009-12-01  Kevin Ollivier  <kevino@theolliviers.com>
394
395         Reviewed by Eric Seidel.
396
397         [wx] Get DumpRenderTree building after waf switch.
398         
399         https://bugs.webkit.org/show_bug.cgi?id=32041
400
401         * DumpRenderTree/wscript: Added.
402         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
403         (LayoutTestController::setTimelineProfilingEnabled):
404         (LayoutTestController::evaluateScriptInIsolatedWorld):
405         (LayoutTestController::disableImageLoading):
406         (LayoutTestController::whiteListAccessFromOrigin):
407         (LayoutTestController::counterValueForElementById):
408         * Scripts/build-webkit:
409
410 2009-12-02  Adam Barth  <abarth@webkit.org>
411
412         Reviewed by Eric Seidel.
413
414         [bzt] build-attachment shouldn't check whether the builders are red
415         https://bugs.webkit.org/show_bug.cgi?id=32062
416
417         build-attachment doesn't touch the remote repository, so there isn't a
418         need to hold off when the builders are red.
419
420         * Scripts/modules/commands/download.py:
421         * Scripts/modules/landingsequence.py:
422
423 2009-12-02  Eric Seidel  <eric@webkit.org>
424
425         Reviewed by Adam Barth.
426
427         REGRESSION(51590): style-queue and build-queue think their empty when they are not
428         https://bugs.webkit.org/show_bug.cgi?id=32061
429
430         * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
431         * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
432
433 2009-12-02  Eric Seidel  <eric@webkit.org>
434
435         Reviewed by Adam Barth.
436
437         build-queue is throwing exceptions and complaining about
438         lack of --no-update on build-attachment.  Make it stop.
439
440         * Scripts/modules/buildsteps.py:
441         * Scripts/modules/commands/download.py:
442
443 2009-12-02  Adam Barth  <abarth@webkit.org>
444
445         Unreviewed "build" fix.  Forgot to declare my variables.  :(
446
447         * QueueStatusServer/queue_status.py:
448
449 2009-12-02  Adam Barth  <abarth@webkit.org>
450
451         Reviewed by Eric Seidel.
452
453         [bzt] Implement status bubble view
454         https://bugs.webkit.org/show_bug.cgi?id=32057
455
456         The status bubble is a compact representation of the queue status for a
457         given patch.  This will eventually help us reduce the comment spam from
458         the queues.
459
460         * QueueStatusServer/index.html: Added HTML5 doctype for sanity.
461         * QueueStatusServer/queue_status.py:
462         * QueueStatusServer/status_bubble.html: Added.
463
464 2009-12-02  Eric Seidel  <eric@webkit.org>
465
466         Reviewed by Adam Barth.
467
468         trim commands/*.py includes now that commands are unit tested
469         https://bugs.webkit.org/show_bug.cgi?id=32056
470
471         In the course of ensuring that the unit tests still
472         passed after this change, I had to actually make them
473         pass in the first place.
474
475         * Scripts/modules/bugzilla.py:
476          - Fix _parse_attachment_ids_request_query to return ints instead of strings.
477         * Scripts/modules/commands/download.py: Remove unneeded imports.
478         * Scripts/modules/commands/queries.py: Ditto.
479         * Scripts/modules/commands/queues.py: Ditto.
480         * Scripts/modules/commands/upload.py: Ditto.
481         * Scripts/modules/scm_unittest.py:
482          - Fix to expect the \n after the path since echo adds an \n.
483
484 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
485
486         build-webkit: Remove flex,bison,gperf check for chromium
487         https://bugs.webkit.org/show_bug.cgi?id=32043
488
489         * Scripts/webkitdirs.pm:
490
491 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
492
493         Build fixage for Windows/GTK for DumpRenderTree.
494
495         WAI-ARIA: implement support for ARIA drag and drop
496         https://bugs.webkit.org/show_bug.cgi?id=32007
497
498         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
499         (AccessibilityUIElement::ariaIsGrabbed):
500         (AccessibilityUIElement::ariaDropEffects):
501         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
502         (AccessibilityUIElement::ariaIsGrabbed):
503         (AccessibilityUIElement::ariaDropEffects):
504
505 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
506
507         Reviewed by Darin Adler.
508
509         WAI-ARIA: implement support for ARIA drag and drop
510         https://bugs.webkit.org/show_bug.cgi?id=32007
511
512         * DumpRenderTree/AccessibilityUIElement.cpp:
513         (getARIADropEffectsCallback):
514         (getARIAIsGrabbedCallback):
515         (AccessibilityUIElement::getJSClass):
516         * DumpRenderTree/AccessibilityUIElement.h:
517         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
518         (AccessibilityUIElement::ariaIsGrabbed):
519         (AccessibilityUIElement::ariaDropEffects):
520
521 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
522
523         Not reviewed. GTK DRT try 2.
524
525         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
526         (LayoutTestController::sampleSVGAnimationForElementAtTime):
527
528 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
529
530         Not reviewed. Try to fix gtk DRT build.
531
532         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
533
534 2009-12-01  David Levin  <levin@chromium.org>
535
536         Reviewed by Eric Seidel.
537
538         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
539         https://bugs.webkit.org/show_bug.cgi?id=32033
540
541         * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
542                                         instead of startswith.
543         * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
544
545 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
546
547         Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
548
549         * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature.
550
551 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
552
553         Reviewed by Simon Fraser.
554
555         Add SVG animation test framework with 'snapshot' functionality
556         https://bugs.webkit.org/show_bug.cgi?id=31897
557
558         Add new 'sampleSVGAnimationForElementAtTime' DRT method,
559         used by the new SVG animation testing framework, implemented
560         for qt/gtk/win/mac.
561
562         * DumpRenderTree/LayoutTestController.cpp:
563         (sampleSVGAnimationForElementAtTimeCallback):
564         (LayoutTestController::staticFunctions):
565         * DumpRenderTree/LayoutTestController.h:
566         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
567         (LayoutTestController::sampleSVGAnimationForElementAtTime):
568         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
569         (LayoutTestController::sampleSVGAnimationForElementAtTime):
570         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
571         (LayoutTestController::sampleSVGAnimationForElementAtTime):
572         * DumpRenderTree/qt/LayoutTestControllerQt.h:
573         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
574         (LayoutTestController::sampleSVGAnimationForElementAtTime):
575         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
576         (LayoutTestController::sampleSVGAnimationForElementAtTime):
577
578 2009-12-01  Adam Roben  <aroben@apple.com>
579
580         Remove user content before running each test on Windows
581
582         Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
583
584         Reviewed by Alexey Proskuryakov.
585
586         * DumpRenderTree/win/DumpRenderTree.cpp:
587         (resetWebViewToConsistentStateBeforeTesting): Remove all user content
588         before each test, which matches Mac.
589
590 2009-12-01  Yuzo Fujishima  <yuzo@google.com>
591
592         Reviewed by Alexey Proskuryakov.
593
594         Make pywebsocket log errors to a file
595         https://bugs.webkit.org/show_bug.cgi?id=31604
596
597         * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
598         (by passing the path to the server via a recently added -l option).
599
600 2009-12-01  Adam Roben  <aroben@apple.com>
601
602         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
603
604         Reviewed by Ada Chan.
605
606         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
607         TestNetscapePlugin fail in Debug_Internal builds
608
609         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
610         directory in Debug and Debug_All builds, but not in Debug_Internal
611         builds.
612
613 2009-12-01  Adam Roben  <aroben@apple.com>
614
615         Re-enable DRT's watchdog timer on Windows
616
617         It was accidentally disabled in r50907.
618
619         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
620         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
621         into an if condition.
622
623 2009-12-01  Adam Barth  <abarth@webkit.org>
624
625         Reviewed by Eric Seidel.
626
627         check-webkit-style complains about #imports with / in them
628         https://bugs.webkit.org/show_bug.cgi?id=32022
629
630         We need to exclude #import directives in addition to #include from the
631         binary operator whitespace checks.
632
633         * Scripts/modules/cpp_style.py:
634         * Scripts/modules/cpp_style_unittest.py:
635
636 2009-11-30  Adam Barth  <abarth@webkit.org>
637
638         Reviewed by Eric Seidel.
639
640         check-webkit-style is slightly too verbose
641         https://bugs.webkit.org/show_bug.cgi?id=32010
642
643         check-webkit-style prints out a bunch of "done" lines that seem redundant,
644         especially for the style-queue.
645
646         * Scripts/modules/cpp_style.py:
647
648 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
649
650         Reviewed by Eric Seidel.
651
652         [GTK] Moved the functions that are closing the result log of the
653         tests to the last line of the runTest function, this avoids
654         reporting crashes in the wrong test if there is a problem when
655         reseting the state after the test.
656
657         * DumpRenderTree/gtk/DumpRenderTree.cpp:
658         (dump):
659         (runTest):
660
661 2009-11-30  Sam Weinig  <sam@webkit.org>
662
663         Reviewed by Geoffrey Garen.
664
665         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
666         fast/js/date-proto-generic-invocation breaks another test
667
668         Don't cache JSClassRefs, a change to the prototype chain will
669         last between tests.
670
671         * DumpRenderTree/AccessibilityController.cpp:
672         (AccessibilityController::getJSClass):
673         * DumpRenderTree/GCController.cpp:
674         (GCController::getJSClass):
675         * DumpRenderTree/GCController.h:
676         * DumpRenderTree/LayoutTestController.cpp:
677         (LayoutTestController::getJSClass):
678
679 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
680
681         Reviewed by Alexey Proskuryakov.
682
683         Update pywebsocket to 0.4.2.1.
684         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
685         https://bugs.webkit.org/show_bug.cgi?id=31976
686
687         * pywebsocket/mod_pywebsocket/standalone.py:
688         * pywebsocket/setup.py:
689
690 2009-11-30  Adam Barth  <abarth@webkit.org>
691
692         Reviewed by Eric Seidel.
693
694         [bzt] Generate pass messages for style-queue
695         https://bugs.webkit.org/show_bug.cgi?id=31995
696
697         With this change, the style-queue posts "pass" messages to bugs as
698         well.  Also, added more information to the state store w.r.t. passing
699         and failing.
700
701         * Scripts/modules/commands/queues.py:
702         * Scripts/modules/patchcollection.py:
703
704 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
705
706         Reviewed by Simon Fraser.
707
708         Check for WEBKIT_TESTFONTS environment variable in
709         run-webkit-tests, for GTK+, to have a more prominent error
710         message.
711
712         * Scripts/run-webkit-tests:
713
714 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
715
716         Reviewed by Dimitri Glazkov.
717
718         update-webkit --chromium forces gclient sync
719
720         https://bugs.webkit.org/show_bug.cgi?id=31967
721
722         * Scripts/update-webkit-chromium:
723
724 2009-11-29  Eric Seidel  <eric@webkit.org>
725
726         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
727
728         * Scripts/modules/committers.py:
729
730 2009-11-29  Eric Seidel  <eric@webkit.org>
731
732         No review, just adding missing svn property.
733
734         Set svn:executable property on new scripts.
735         These were added by commit-queue commits, but the executable
736         property was lost due to a bug in svn-apply:
737         https://bugs.webkit.org/show_bug.cgi?id=27204
738
739         * Scripts/update-webkit-chromium: Added property svn:executable.
740         * Scripts/validate-committer-lists: Added property svn:executable.
741
742 2009-11-29  Eric Seidel  <eric@webkit.org>
743
744         Reviewed by Adam Barth.
745
746         Need a way to validate that committers.py includes all committers/reviewers
747         https://bugs.webkit.org/show_bug.cgi?id=30970
748
749         Add a script which knows how to compare our public committer/reviewer
750         lists and show discrepancies between them.
751
752         Validates mailing lists vs. committers.py:
753         - committers.py committers missing from webkit-committers@lists
754         - webkit-committers@lists members missing from committers.py
755         - committers.py reviewers missing from webkit-reviewers@lists
756         - webkit-reviewers@lists members missing from committers.py
757         - webkit-reviewers@lists members missing from committers.py reviewer list
758
759         Validates committers.py vs. trunk/ SVN history:
760         - committers who have not committed in over a year
761         - SVN committers missing from committers.py
762         - committers.py members who have no record in SVN.
763
764         All of these lists still show "false positives" until a few more committers.py updates are made, like:
765         https://bugs.webkit.org/show_bug.cgi?id=31366
766
767         * Scripts/validate-committer-lists: Added.
768
769 2009-11-28  Adam Barth  <abarth@webkit.org>
770
771         Reviewed by Eric Seidel.
772
773         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
774         https://bugs.webkit.org/show_bug.cgi?id=31950
775
776         Now we cache the last status that we get back from QueueStatusServer.
777         Eventually we'll have to do something more fancy if we want to support
778         a "try again" button on QueueStatusServer, but we can cross that bridge
779         when we come to it.
780
781         * Scripts/modules/patchcollection.py:
782
783 2009-11-28  Adam Barth  <abarth@webkit.org>
784
785         Reviewed by Eric Seidel.
786
787         StyleQueue scans ~100 bug pages every 5 minutes
788         https://bugs.webkit.org/show_bug.cgi?id=31947
789
790         Instead of getting the pending-review attachment ids by scanning each
791         bug (which results in a network request), we should just get them all
792         from webkit.org/pending-review in one shot.
793
794         * Scripts/modules/bugzilla.py:
795         * Scripts/modules/bugzilla_unittest.py:
796         * Scripts/modules/commands/queries.py:
797         * Scripts/modules/commands/queries_unittest.py:
798         * Scripts/modules/commands/queues.py:
799         * Scripts/modules/mock_bugzillatool.py:
800         * Scripts/modules/patchcollection.py:
801
802 2009-11-28  Adam Barth  <abarth@webkit.org>
803
804         Reviewed by Eric Seidel.
805
806         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
807         https://bugs.webkit.org/show_bug.cgi?id=31952
808
809         The mailing list is open for anyone to subscribe.
810
811         * Scripts/modules/bugzilla.py:
812         * Scripts/modules/commands/queues.py:
813
814 2009-11-28  Adam Barth  <abarth@webkit.org>
815
816         Reviewed by Eric Seidel.
817
818         [bzt] style-queue should report style errors to bugzilla
819         https://bugs.webkit.org/show_bug.cgi?id=31945
820
821         Currently, we're just logging the style errors locally.  With this
822         patch we'll actually log the errors to bugzilla.  Note: I plan to run
823         with the "local-only" logging during development.
824
825         * Scripts/modules/commands/queues.py:
826         * Scripts/modules/scm.py:
827
828 2009-11-28  Adam Barth  <abarth@webkit.org>
829
830         Reviewed by Eric Seidel.
831
832         [bzt] style-queue shouldn't reject patches from the commit-queue
833         https://bugs.webkit.org/show_bug.cgi?id=31944
834
835         Currently the style-queue subprocess gets confused and thinks its the
836         commit-queue.  If the patch has an error, it rejects it from the
837         commit-queue.  Instead, we should have style-queue specific logic.
838         This patch doesn't add that logic, but it gives us a callback we can
839         use to add that logic.
840
841         * Scripts/modules/buildsteps.py:
842         * Scripts/modules/commands/queues.py:
843         * Scripts/modules/landingsequence.py:
844
845 2009-11-27  Adam Barth  <abarth@webkit.org>
846
847         Rubber stamped by Eric Seidel.
848
849         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
850
851         * CommitQueueStatus: Removed.
852         * CommitQueueStatus/app.yaml: Removed.
853         * CommitQueueStatus/filters: Removed.
854         * CommitQueueStatus/filters/__init__.py: Removed.
855         * CommitQueueStatus/filters/webkit_extras.py: Removed.
856         * CommitQueueStatus/index.html: Removed.
857         * CommitQueueStatus/index.yaml: Removed.
858         * CommitQueueStatus/queue_status.py: Removed.
859         * CommitQueueStatus/stylesheets: Removed.
860         * CommitQueueStatus/stylesheets/main.css: Removed.
861         * CommitQueueStatus/update_status.html: Removed.
862         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
863
864 2009-11-27  Adam Barth  <abarth@webkit.org>
865
866         Reviewed by Eric Seidel.
867
868         style-queue should only process each patch once
869         https://bugs.webkit.org/show_bug.cgi?id=31939
870
871         Actually address reviewer comments!
872
873         * Scripts/bugzilla-tool:
874
875 2009-11-27  Adam Barth  <abarth@webkit.org>
876
877         Reviewed by Eric Seidel.
878
879         [bzt] style-queue fails to apply a bunch of patches for no reason
880         https://bugs.webkit.org/show_bug.cgi?id=31942
881
882         By passing --non-interactive to check-style, we convince check-style
883         to pass --force to svn-apply, which lets it apply more patches.
884
885         * Scripts/modules/commands/queues.py:
886
887 2009-11-27  Adam Barth  <abarth@webkit.org>
888
889         Reviewed by Eric Seidel.
890
891         [bzt] Support --status-host in style-queue
892         https://bugs.webkit.org/show_bug.cgi?id=31941
893
894         * Scripts/modules/commands/queues.py:
895         * Scripts/modules/statusbot.py:
896
897 2009-11-27  Adam Barth  <abarth@webkit.org>
898
899         Reviewed by Eric Seidel.
900
901         style-queue should only process each patch once
902         https://bugs.webkit.org/show_bug.cgi?id=31939
903
904         Before processing a patch, the try-queues now ask the web service
905         whether they have already processed the patch.  This is an initial cut
906         of this functionality.  I expect we're make it richer over time.
907
908         * Scripts/bugzilla-tool:
909         * Scripts/modules/commands/queues.py:
910         * Scripts/modules/patchcollection.py:
911
912 2009-11-27  Adam Barth  <abarth@webkit.org>
913
914         Reviewed by Eric Seidel.
915
916         PatchStatus does not return status
917         https://bugs.webkit.org/show_bug.cgi?id=31938
918
919         We need to parse attachment_id as an int.  Otherwise, we can't find
920         anything in the datastore.
921
922         * CommitQueueStatus/queue_status.py:
923
924 2009-11-27  Adam Barth  <abarth@webkit.org>
925
926         Reviewed by Eric Seidel.
927
928         Make commit-queue status not throw an exception where there is not
929         status
930         https://bugs.webkit.org/show_bug.cgi?id=31936
931
932         We need to actually fetch the results of the query to see what's in the
933         datastore.
934
935         * CommitQueueStatus/queue_status.py:
936
937 2009-11-27  Adam Barth  <abarth@webkit.org>
938
939         Reviewed by Eric Seidel.
940
941         [bzt] unit test ApplyPatches and ApplyAttachment
942         https://bugs.webkit.org/show_bug.cgi?id=31935
943
944         * Scripts/modules/commands/download.py:
945         * Scripts/modules/commands/download_unittest.py:
946
947 2009-11-27  Adam Barth  <abarth@webkit.org>
948
949         Reviewed by Eric Seidel.
950
951         [bzt] Unit test download commands
952         https://bugs.webkit.org/show_bug.cgi?id=31923
953
954         Adds download_unittest and fixes a bug found while testing.
955
956         * Scripts/modules/commands/commandtest.py:
957         * Scripts/modules/commands/download.py:
958             Fixed a bug where we'd throw an error because [].append returns
959             None.
960         * Scripts/modules/commands/download_unittest.py: Added.
961         * Scripts/modules/mock_bugzillatool.py:
962         * Scripts/run-webkit-unittests:
963
964 2009-11-27  Adam Barth  <abarth@webkit.org>
965
966         Unreviewed "build" fix found while writing unit tests.
967
968         * Scripts/modules/commands/download.py:
969
970 2009-11-27  Adam Barth  <abarth@webkit.org>
971
972         Reviewed by Eric Seidel.
973
974         [bzt] Kill WebKitLandingScripts
975         https://bugs.webkit.org/show_bug.cgi?id=31904
976
977         Step 6: Kill the rest.
978
979         * Scripts/modules/buildsteps.py:
980         * Scripts/modules/commands/download.py:
981         * Scripts/modules/commands/queries.py:
982         * Scripts/modules/commands/upload.py:
983         * Scripts/modules/landingsequence.py:
984         * Scripts/modules/scm.py:
985         * Scripts/modules/webkitlandingscripts.py: Removed.
986
987 2009-11-27  Adam Barth  <abarth@webkit.org>
988
989         Reviewed by Eric Seidel.
990
991         [bzt] Unit test upload commands
992         https://bugs.webkit.org/show_bug.cgi?id=31903
993
994         Adds unit tests for all but two of the upload commands.  The two
995         remaining ones are more difficult.  I'll return to them later.  The
996         goal of these tests is just to run the commands.  We can test more
997         detailed behavior later.
998
999         * Scripts/modules/commands/commandtest.py:
1000         * Scripts/modules/commands/upload.py:
1001         * Scripts/modules/commands/upload_unittest.py:
1002         * Scripts/modules/mock.py: Added.
1003         * Scripts/modules/mock_bugzillatool.py:
1004
1005 2009-11-26  Adam Barth  <abarth@webkit.org>
1006
1007         Reviewed by Eric Seidel.
1008
1009         [bzt] Kill WebKitLandingScripts
1010         https://bugs.webkit.org/show_bug.cgi?id=31904
1011
1012         Step 5: Kill run_and_throw_if_fail.
1013
1014         * Scripts/modules/buildsteps.py:
1015         * Scripts/modules/processutils.py: Added.
1016         * Scripts/modules/webkitlandingscripts.py:
1017
1018 2009-11-26  Adam Barth  <abarth@webkit.org>
1019
1020         Reviewed by Eric Seidel.
1021
1022         [bzt] Kill WebKitLandingScripts
1023         https://bugs.webkit.org/show_bug.cgi?id=31904
1024
1025         Step 4: Kill run_webkit_script.
1026
1027         * Scripts/modules/buildsteps.py:
1028         * Scripts/modules/commands/download.py:
1029         * Scripts/modules/webkitlandingscripts.py:
1030
1031 2009-11-26  Adam Barth  <abarth@webkit.org>
1032
1033         Reviewed by Eric Seidel.
1034
1035         [bzt] Kill WebKitLandingScripts
1036         https://bugs.webkit.org/show_bug.cgi?id=31904
1037
1038         Step 3: Kill build_webkit.
1039
1040         * Scripts/modules/buildsteps.py:
1041         * Scripts/modules/landingsequence.py:
1042         * Scripts/modules/webkitlandingscripts.py:
1043
1044 2009-11-26  Adam Barth  <abarth@webkit.org>
1045
1046         Reviewed by Eric Seidel.
1047
1048         [bzt] Kill WebKitLandingScripts
1049         https://bugs.webkit.org/show_bug.cgi?id=31904
1050
1051         Step 2: Kill ensure_builders_are_green.
1052
1053         * Scripts/modules/buildsteps.py:
1054         * Scripts/modules/commands/download.py:
1055         * Scripts/modules/landingsequence.py:
1056         * Scripts/modules/webkitlandingscripts.py:
1057
1058 2009-11-26  Adam Barth  <abarth@webkit.org>
1059
1060         Reviewed by Eric Seidel.
1061
1062         [bzt] Kill WebKitLandingScripts
1063         https://bugs.webkit.org/show_bug.cgi?id=31904
1064
1065         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
1066
1067         * Scripts/bugzilla-tool:
1068         * Scripts/modules/buildsteps.py: Added.
1069         * Scripts/modules/commands/download.py:
1070         * Scripts/modules/landingsequence.py:
1071         * Scripts/modules/webkitlandingscripts.py:
1072
1073 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
1074
1075         Reviewed by Adam Barth.
1076
1077         Remove directory prefixes from linux commands
1078
1079         SCM unittests can cause errors on some systems if we use absolute reference to
1080         the commands, so directory prefixes have been removed.
1081
1082         * Scripts/modules/scm_unittest.py:
1083
1084 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
1085
1086         Reviewed by Kenneth Rohde Christiansen.
1087
1088         Link DumpRenderTree to the Qt Ui Tools
1089         https://bugs.webkit.org/show_bug.cgi?id=31203
1090
1091         Implement QWebPage::createPlugin using the Qt Ui Tools
1092         to be able to create classes like QProgressBar from within
1093         the <object></object> tags This is required for the
1094         new automatic test of Qt Plugins.
1095
1096         * DumpRenderTree/qt/DumpRenderTree.cpp:
1097         (WebCore::WebPage::createPlugin):
1098         * DumpRenderTree/qt/DumpRenderTree.h:
1099         * DumpRenderTree/qt/DumpRenderTree.pro:
1100
1101 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
1102
1103         Reviewed by Eric Seidel.
1104
1105         Update pywebsocket to 0.4.2
1106
1107         Update pywebsocket to 0.4.2
1108         https://bugs.webkit.org/show_bug.cgi?id=31861
1109
1110         * pywebsocket/example/echo_client.py:
1111         * pywebsocket/example/echo_wsh.py:
1112         * pywebsocket/mod_pywebsocket/__init__.py:
1113         * pywebsocket/mod_pywebsocket/dispatch.py:
1114         * pywebsocket/mod_pywebsocket/msgutil.py:
1115         * pywebsocket/mod_pywebsocket/standalone.py:
1116         * pywebsocket/setup.py:
1117         * pywebsocket/test/test_dispatch.py:
1118         * pywebsocket/test/test_msgutil.py:
1119
1120 2009-11-25  Adam Barth  <abarth@webkit.org>
1121
1122         Reviewed by Eric Seidel.
1123
1124         Add unit test for mark-fixed
1125         https://bugs.webkit.org/show_bug.cgi?id=31896
1126
1127         * Scripts/modules/commands/commandtest.py: Added.
1128         * Scripts/modules/commands/queries_unittest.py:
1129         * Scripts/modules/commands/upload_unittest.py: Added.
1130         * Scripts/modules/mock_bugzillatool.py:
1131         * Scripts/run-webkit-unittests:
1132
1133 2009-11-25  Adam Barth  <abarth@webkit.org>
1134
1135         Reviewed by Eric Seidel.
1136
1137         bugzilla-tool should have a mark-fixed command
1138         https://bugs.webkit.org/show_bug.cgi?id=31853
1139
1140         Pretty simple stuff.
1141
1142         * Scripts/modules/commands/upload.py:
1143
1144 2009-11-25  Eric Seidel  <eric@webkit.org>
1145
1146         Reviewed by Adam Barth.
1147
1148         'bugzilla-tool help' should only show common commands like how 'git help' does
1149         https://bugs.webkit.org/show_bug.cgi?id=31772
1150
1151         I also took this opportunity to make 'help' a real Command.
1152         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
1153
1154         * Scripts/bugzilla-tool:
1155          - change should_show_command_help to should_show_in_main_help
1156         * Scripts/modules/commands/download.py:
1157          - Mark commands as being shown in main help or not.
1158          - show_in_main_help = False is not required (default is false),
1159            but it seemed to make the commands more self-documenting.
1160         * Scripts/modules/commands/queries.py: ditto
1161         * Scripts/modules/commands/queues.py: ditto
1162         * Scripts/modules/commands/upload.py: ditto
1163         * Scripts/modules/multicommandtool.py:
1164          - Make Command hold a pointer to tool in self.tool.  Most Command
1165            subclasses do not take advantage of this yet, but it was required
1166            for HelpCommand to be able to reach the tool from _help_epilog().
1167          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
1168          - Move MultiCommandTool._help_epilog to Command._help_epilog
1169          - Move "help" logic into HelpCommand.execute()
1170          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
1171         * Scripts/modules/multicommandtool_unittest.py:
1172          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
1173
1174 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
1175
1176         Reviewed by Dan Bernstein.
1177         
1178         Patch by Mark Rowe.
1179
1180         The buildbots are failing on Windows because when they were upgraded
1181         to 4.0.4, Apple Application Support was not in their path. Add it to
1182         the path to fix the buildots.
1183
1184         * Scripts/webkitdirs.pm:
1185
1186 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
1187
1188         Reviewed by David Kilzer.
1189
1190         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
1191         https://bugs.webkit.org/show_bug.cgi?id=31799
1192
1193         * Scripts/run-webkit-tests: Fixed.
1194
1195 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
1196
1197         Reviewed by Eric Seidel.
1198
1199         Change run_command to give back stderr by default
1200         https://bugs.webkit.org/show_bug.cgi?id=31734
1201
1202         Change run_command to give back stderr by default.
1203         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
1204         Change the related unittest call.
1205
1206         * Scripts/modules/scm.py:
1207         * Scripts/modules/scm_unittest.py:
1208
1209 2009-11-25  Eric Seidel  <eric@webkit.org>
1210
1211         Reviewed by Adam Barth.
1212
1213         Centralize required argument parsing in Command
1214         https://bugs.webkit.org/show_bug.cgi?id=31872
1215
1216         * Scripts/modules/commands/download.py: remove custom required arg message.
1217         * Scripts/modules/commands/upload.py: ditto.
1218         * Scripts/modules/multicommandtool.py:
1219          - Add _parse_required_arguments.
1220          - Pass program name off to OptionParser.
1221          - Add name() for access to tool name.
1222          - Add check_arguments_and_execute and make it return a return code.
1223          - Replace a couple uses of + with %.
1224         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
1225
1226 2009-11-25  Eric Seidel  <eric@webkit.org>
1227
1228         Reviewed by Adam Barth.
1229
1230         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
1231         https://bugs.webkit.org/show_bug.cgi?id=31870
1232
1233         * Scripts/modules/commands/queries_unittest.py: Use the new class.
1234         * Scripts/modules/multicommandtool_unittest.py: Ditto.
1235         * Scripts/modules/outputcapture.py: Added.
1236
1237 2009-11-24  Dmitry Titov  <dimich@chromium.org>
1238
1239         Reviewed by Eric Seidel.
1240
1241         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
1242         https://bugs.webkit.org/show_bug.cgi?id=31444
1243
1244         * Scripts/build-webkit:
1245
1246 2009-11-24  Chris Marrin  <cmarrin@apple.com>
1247
1248         Reviewed by Simon Fraser.
1249
1250         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
1251         https://bugs.webkit.org/show_bug.cgi?id=27314
1252         
1253         Now the script allows the directories with these tests to be included on all
1254         platforms but Mac, where they behave the same as always. For all other platforms
1255         the tests need to be excluded using the Skipped files, which is currently done
1256         for all platforms (including win since we're not turned on yet)
1257
1258         * Scripts/webkitdirs.pm:
1259
1260 2009-11-24  Eric Seidel  <eric@webkit.org>
1261
1262         Reviewed by Adam Barth.
1263
1264         queries_unittest.py should test command output
1265         https://bugs.webkit.org/show_bug.cgi?id=31845
1266
1267         * Scripts/modules/commands/queries_unittest.py:
1268          - Capture stdout and stderr and compare with expected strings.
1269
1270 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
1271
1272         No Review.
1273
1274         Fix spelling error ("depenedencies").
1275
1276         * Scripts/build-webkit:
1277
1278 2009-11-24  Mark Rowe  <mrowe@apple.com>
1279
1280         Land the configuration that includes the two debug GTK Linux builders.
1281
1282         * BuildSlaveSupport/build.webkit.org-config/config.json:
1283
1284 2009-11-24  David Kilzer  <ddkilzer@apple.com>
1285
1286         <http://webkit.org/b/31840> bisect-builds broke after r50080
1287
1288         Reviewed by Dan Bernstein.
1289
1290         * Scripts/bisect-builds:
1291         (mountAndRunNightly): Switched back to using backticks to run
1292         the hdiutil command since exec() will terminate the existing
1293         script, which is not what we want.  Store the output of
1294         File::Spec->devnull() in a variable for use in the hdiutil
1295         detach commands.
1296
1297 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1298
1299         Reviewed by Kenneth Rohde Christiansen.
1300
1301         Include "config.h" to meet Coding Style Guidelines
1302         https://bugs.webkit.org/show_bug.cgi?id=31792
1303
1304         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
1305         * DumpRenderTree/qt/jsobjects.cpp:
1306         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1307
1308 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1309
1310         Reviewed by Oliver Hunt.
1311
1312         Implement new required function to pass test we used to pass. This
1313         change is required since r51294.
1314
1315         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1316         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1317
1318 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
1319
1320         Reviewed by Kenneth Rohde Christiansen.
1321
1322         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
1323         https://bugs.webkit.org/show_bug.cgi?id=31775
1324
1325         LayoutTestController::dumpBackForwardList() should work with local URLs
1326         as well as with normal URLs (in http tests for instance).
1327         Currently it does not output the latter properly.
1328
1329         Unskip a bunch of passing http/navigation tests.
1330
1331         * DumpRenderTree/qt/DumpRenderTree.cpp:
1332         (WebCore::dumpHistoryItem):
1333
1334 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
1335
1336         Reviewed by Oliver Hunt.
1337
1338         ARIA: support aria-flowto
1339         https://bugs.webkit.org/show_bug.cgi?id=31762
1340
1341         * DumpRenderTree/AccessibilityUIElement.cpp:
1342         (ariaFlowToElementAtIndexCallback):
1343         (AccessibilityUIElement::getJSClass):
1344         * DumpRenderTree/AccessibilityUIElement.h:
1345         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1346         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1347         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1348         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1349         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1350         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1351
1352 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
1353
1354         Reviewed by Kenneth Christiansen.
1355
1356         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
1357         https://bugs.webkit.org/show_bug.cgi?id=31638
1358
1359         Unfreeze WorkQueue after each test execution.
1360
1361         * DumpRenderTree/qt/DumpRenderTree.cpp:
1362         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1363
1364 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1365
1366         Reviewed by Adam Barth.
1367
1368         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
1369         for localhost and 127.0.0.1.
1370         https://bugs.webkit.org/show_bug.cgi?id=31783
1371
1372         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
1373
1374         * DumpRenderTree/qt/DumpRenderTree.cpp:
1375         (WebCore::NetworkAccessManager::NetworkAccessManager):
1376         (WebCore::NetworkAccessManager::sslErrorsEncountered):
1377         (WebCore::WebPage::WebPage):
1378         * DumpRenderTree/qt/DumpRenderTree.h:
1379
1380 2009-11-22  Chris Evans  <cevans@chromium.org>
1381
1382         Reviewed by Adam Barth.
1383
1384         Disable access to file:/// directory listings
1385         https://bugs.webkit.org/show_bug.cgi?id=31329
1386
1387         Implemented setAllowUniversalAccessFromFileURLs to support testing of
1388         file URL security.
1389
1390         * DumpRenderTree/LayoutTestController.cpp:
1391         (setAllowUniversalAccessFromFileURLsCallback):
1392         (LayoutTestController::staticFunctions):
1393         * DumpRenderTree/LayoutTestController.h:
1394         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1395         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1396         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1397         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1398         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1399         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1400         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1401         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1402
1403 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1404
1405         Reviewed by Kenneth Rohde Christiansen.
1406
1407         [Qt] Fix the timeout of fast/frames/frame-navigation.html
1408         https://bugs.webkit.org/show_bug.cgi?id=31638
1409
1410         The test is timeouting, because it uses the WorkQueue to load a document in one
1411         of the child frames and once the loading is finished, the DRT does not dump the
1412         tree. This is because it waits for the QWebFrame::loadFinished() signal from
1413         the main frame, while it should connect to QWebPage::loadFinished().
1414
1415         * DumpRenderTree/qt/DumpRenderTree.cpp:
1416         (WebCore::DumpRenderTree::DumpRenderTree):
1417
1418 2009-11-21  Eric Seidel  <eric@webkit.org>
1419
1420         Reviewed by Adam Barth.
1421
1422         bugzilla-tool --help spews way too much text
1423         https://bugs.webkit.org/show_bug.cgi?id=31771
1424
1425         * Scripts/bugzilla-tool:
1426          - Remove self.cached_scm initialization hack.
1427         * Scripts/modules/buildbot.py:
1428          - Make default_host accessible to callers.
1429         * Scripts/modules/commands/download.py:
1430          - Phrase help for all commands consistently and remove spurious help text punctuation.
1431         * Scripts/modules/commands/queries.py: Ditto.
1432         * Scripts/modules/commands/queues.py: Ditto.
1433         * Scripts/modules/commands/upload.py: Ditto.
1434         * Scripts/modules/multicommandtool.py:
1435          - Add HelpPrintingOptionParser.format_epilog to replace
1436            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
1437            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
1438          - Make --help only show a list of commands like "svn help" and "git help" do --
1439            previously --help was listing all commands and options.
1440          - Sort list of commands alphabetically.
1441
1442 2009-11-21  Eric Seidel  <eric@webkit.org>
1443
1444         No review.  Fixing a typo from the previous patch for bug 31767.
1445
1446         AbstractQueue.run_bugzilla_tool throws an exception
1447         https://bugs.webkit.org/show_bug.cgi?id=31769
1448
1449         * Scripts/modules/commands/queues.py:
1450
1451 2009-11-21  Eric Seidel  <eric@webkit.org>
1452
1453         Reviewed by Adam Barth.
1454
1455         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
1456         https://bugs.webkit.org/show_bug.cgi?id=31767
1457
1458         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
1459         Since we don't have a good way to test BugzillaTool pieces, I've
1460         left out a test for now.
1461
1462         * Scripts/bugzilla-tool:
1463          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
1464         * Scripts/modules/commands/queues.py:
1465          - Use tool.path() instead of __file__.
1466         * Scripts/modules/multicommandtool.py:
1467          - Add a new path() method to MultiComandTool.
1468         * Scripts/modules/multicommandtool_unittest.py:
1469          - Provide a path() method.  Little point in testing this mock implementation.
1470
1471 2009-11-21  Adam Barth  <abarth@webkit.org>
1472
1473         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
1474         WebKitTools.
1475
1476         * Scripts/modules/commands/download.py:
1477
1478 2009-11-21  Adam Barth  <abarth@webkit.org>
1479
1480         Reviewed by Eric Seidel.
1481
1482         Convert check-style to use LandingSequence
1483         https://bugs.webkit.org/show_bug.cgi?id=31763
1484
1485         Instead of manipulating the working copy by hand, we should use the
1486         LandingSequence in CheckStyle.  This will make this code eaiser to
1487         test.
1488
1489         * Scripts/modules/commands/download.py:
1490
1491 2009-11-20  Adam Barth  <abarth@webkit.org>
1492
1493         Reviewed by Eric Seidel.
1494
1495         Unit test query commands
1496         https://bugs.webkit.org/show_bug.cgi?id=31755
1497
1498         These tests are pretty rough, but hopefully they'll grow.
1499
1500         * Scripts/modules/commands/queries_unittest.py: Added.
1501         * Scripts/modules/mock_bugzillatool.py: Added.
1502         * Scripts/run-webkit-unittests:
1503
1504 2009-11-20  Eric Seidel  <eric@webkit.org>
1505
1506         Reviewed by Adam Barth.
1507
1508         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
1509         https://bugs.webkit.org/show_bug.cgi?id=31758
1510
1511         * Scripts/modules/multicommandtool.py:
1512          - Allow passing of explicit commands to MultiCommandTool.__init__
1513         * Scripts/modules/multicommandtool_unittest.py:
1514          - Use new Command.name naming system.
1515          - Test Command auto-discovery.
1516         * Scripts/modules/workqueue.py:
1517          - bug_id no longer exists, use patch['bug_id'] instead.
1518         * Scripts/modules/workqueue_unittest.py:
1519          - WorkQueues require names now.
1520          - should_proceed_with_work_item must return a patch object.
1521
1522 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
1523
1524         Reviewed by Beth Dakin.
1525
1526         WAI-ARIA: add support for aria-owns
1527         https://bugs.webkit.org/show_bug.cgi?id=31702
1528
1529         * DumpRenderTree/AccessibilityUIElement.cpp:
1530         (ariaOwnsElementAtIndexCallback):
1531         (AccessibilityUIElement::getJSClass):
1532         * DumpRenderTree/AccessibilityUIElement.h:
1533         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1534         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1535         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1536         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1537         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1538         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1539
1540 2009-11-20  Eric Seidel  <eric@webkit.org>
1541
1542         Reviewed by Adam Barth.
1543
1544         Fix exception thrown when running the commit-queue.
1545
1546         * Scripts/modules/statusbot.py: patch is optional.
1547         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
1548
1549 2009-11-20  Eric Seidel  <eric@webkit.org>
1550
1551         Reviewed by Adam Barth.
1552
1553         Teach the StatusBot how to support more than just the commit-queue
1554         https://bugs.webkit.org/show_bug.cgi?id=31754
1555
1556         * Scripts/modules/workqueue.py: Another typo.
1557
1558 2009-11-20  Eric Seidel  <eric@webkit.org>
1559
1560         Reviewed by Adam Barth.
1561
1562         Teach the StatusBot how to support more than just the commit-queue
1563         https://bugs.webkit.org/show_bug.cgi?id=31754
1564
1565         * Scripts/modules/commands/queues.py: Fix silly typo.
1566
1567 2009-11-20  Eric Seidel  <eric@webkit.org>
1568
1569         Reviewed by Adam Barth.
1570
1571         Teach the StatusBot how to support more than just the commit-queue
1572         https://bugs.webkit.org/show_bug.cgi?id=31754
1573
1574         * CommitQueueStatus/index.yaml:
1575          - Add indices required for the new queries.
1576         * CommitQueueStatus/queue_status.py:
1577          - Add a patch-status page and move update_status to update-status.
1578          - Only display "commit-queue" status records for the commit-queue.
1579          - Add support for a queue_name property on status records.
1580          - Fix _int_from_request to actually work.
1581         * CommitQueueStatus/update_status.html:
1582          - Add support for a queue_name on status records.
1583          - Remove unused list of bug ids.
1584          * Scripts/modules/commands/queues.py
1585           - Make the queues pass the patch instead of the bug_id to StatusBot.
1586         * Scripts/modules/statusbot.py:
1587          - Support passing the queue_name to the status updates.
1588          - Support fetching patch status with patch_status().
1589         * Scripts/modules/workqueue.py:
1590          - Pass the patch to the StatusBot instead of the bug_id.
1591          - Let WorkQueues have a name.
1592
1593 2009-11-20  Adam Barth  <abarth@webkit.org>
1594
1595         Reviewed by Eric Seidel.
1596
1597         Move bugzilla-tool commands into their own file
1598         https://bugs.webkit.org/show_bug.cgi?id=31752
1599
1600         This will let us write unit tests.
1601
1602         * Scripts/bugzilla-tool:
1603         * Scripts/modules/commands/__init__.py: Added.
1604         * Scripts/modules/commands/download.py: Added.
1605         * Scripts/modules/commands/queries.py: Added.
1606         * Scripts/modules/commands/queues.py: Added.
1607         * Scripts/modules/commands/upload.py: Added.
1608         * Scripts/modules/grammar.py: Added.
1609
1610 2009-11-20  Adam Barth  <abarth@webkit.org>
1611
1612         Reviewed by Eric Seidel.
1613
1614         BuildQueue should check if the tree is currently buildable
1615         https://bugs.webkit.org/show_bug.cgi?id=31744
1616
1617         * Scripts/bugzilla-tool:
1618         * Scripts/modules/landingsequence.py:
1619         * Scripts/modules/webkitlandingscripts.py:
1620
1621 2009-11-20  Adam Barth  <abarth@webkit.org>
1622
1623         Reviewed by Eric Seidel.
1624
1625         Move prepare_clean_working_directory into the LandingSequence
1626         https://bugs.webkit.org/show_bug.cgi?id=31743
1627
1628         * Scripts/bugzilla-tool:
1629         * Scripts/modules/landingsequence.py:
1630
1631 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
1632
1633         Reviewed by Kenneth Rohde Christiansen.
1634
1635         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
1636         https://bugs.webkit.org/show_bug.cgi?id=30460
1637
1638         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
1639
1640         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1641         (pluginInvoke):
1642
1643 2009-11-20  Adam Barth  <abarth@webkit.org>
1644
1645         Reviewed by Eric Seidel.
1646
1647         Pass the port information to the child process
1648         https://bugs.webkit.org/show_bug.cgi?id=31736
1649
1650         We need to do this so the child process knows what to build!
1651
1652         * Scripts/bugzilla-tool:
1653         * Scripts/modules/landingsequence.py:
1654         * Scripts/modules/webkitport.py:
1655         * Scripts/modules/webkitport_unittest.py:
1656
1657 2009-11-20  Adam Barth  <abarth@webkit.org>
1658
1659         Reviewed by Eric Seidel.
1660
1661         Support Qt port in build-queue
1662         https://bugs.webkit.org/show_bug.cgi?id=31733
1663
1664         * Scripts/bugzilla-tool:
1665
1666 2009-11-20  Adam Barth  <abarth@webkit.org>
1667
1668         Reviewed by Eric Seidel.
1669
1670         Implement a build-queue
1671         https://bugs.webkit.org/show_bug.cgi?id=31725
1672
1673         Currently this just builds the first 10 patches in the review queue.
1674         We'll want to do something smarter soon.
1675
1676         * Scripts/bugzilla-tool:
1677
1678 2009-11-20  Adam Barth  <abarth@webkit.org>
1679
1680         Reviewed by Eric Seidel.
1681
1682         Make commit-queue and style-queue show up in help
1683         https://bugs.webkit.org/show_bug.cgi?id=31724
1684
1685         We need to store their names on their class to make these commands
1686         properly register themselves with MultiCommandTool.
1687
1688         * Scripts/bugzilla-tool:
1689
1690 2009-11-20  Adam Barth  <abarth@webkit.org>
1691
1692         Reviewed by Eric Seidel.
1693
1694         Implement bugzilla-tool build-attachment
1695         https://bugs.webkit.org/show_bug.cgi?id=31722
1696
1697         This command builds an attachment from bugzilla.  It leaves the built
1698         patch in the working copy.
1699
1700         * Scripts/bugzilla-tool:
1701         * Scripts/modules/landingsequence.py:
1702         * Scripts/modules/webkitlandingscripts.py:
1703
1704 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
1705
1706         Reviewed by Xan Lopez.
1707
1708         [GTK] DRT release event does not create the state correctly
1709         https://bugs.webkit.org/show_bug.cgi?id=31717
1710
1711         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1712
1713 2009-11-20  Eric Seidel  <eric@webkit.org>
1714
1715         Reviewed by Adam Barth.
1716
1717         MultiCommandTool should find Command objects automatically instead of with a manual list
1718         https://bugs.webkit.org/show_bug.cgi?id=31710
1719
1720         * Scripts/bugzilla-tool:
1721         * Scripts/modules/multicommandtool.py:
1722          - Use some wild python-fu to crawl all the known subclasses of Command.
1723
1724 2009-11-20  Adam Barth  <abarth@webkit.org>
1725
1726         Unreviewed "build" fix.  Added missing import.
1727
1728         * Scripts/bugzilla-tool:
1729
1730 2009-11-20  Adam Barth  <abarth@webkit.org>
1731
1732         Unreviewed "build" fix.  I failed to update LandingSequence.test
1733         properly.
1734
1735         * Scripts/modules/landingsequence.py:
1736
1737 2009-11-20  Adam Barth  <abarth@webkit.org>
1738
1739         Reviewed by Eric Seidel.
1740
1741         Create LandingSequence as the all-sing, all-dance landing class
1742         https://bugs.webkit.org/show_bug.cgi?id=31709
1743
1744         Client can inherit from this class to carefully control exactly which
1745         steps they wish to have happen in the landing sequence.
1746
1747         * Scripts/bugzilla-tool:
1748         * Scripts/modules/landingsequence.py: Added.
1749         * Scripts/modules/webkitlandingscripts.py: Added.
1750
1751 2009-11-19  Adam Barth  <abarth@webkit.org>
1752
1753         Reviewed by Eric Seidel.
1754
1755         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
1756         https://bugs.webkit.org/show_bug.cgi?id=31707
1757
1758         This is to help when we implement build-attachment.
1759
1760         * Scripts/bugzilla-tool:
1761
1762 2009-11-19  Adam Barth  <abarth@webkit.org>
1763
1764         Reviewed by Eric Seidel.
1765
1766         Support Qt port in bugzilla-tool
1767         https://bugs.webkit.org/show_bug.cgi?id=31701
1768
1769         Now we support building with Qt!
1770
1771         * Scripts/bugzilla-tool:
1772         * Scripts/modules/webkitport.py: Added.
1773         * Scripts/modules/webkitport_unittest.py: Added.
1774         * Scripts/run-webkit-unittests:
1775
1776 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
1777
1778         Reviewed by Adam Barth.
1779
1780         Remove inserting stderr into patch in bugzilla-tool
1781         https://bugs.webkit.org/show_bug.cgi?id=29914
1782
1783         Modify SCM python module's run_command function to avoid return of stderr
1784         by default, so stderr won't be inserted into the patches.
1785         Modify the related unit test.
1786
1787         * Scripts/modules/scm.py:
1788         * Scripts/modules/scm_unittest.py:
1789
1790 2009-11-19  Eric Seidel  <eric@webkit.org>
1791
1792         Reviewed by Adam Barth.
1793
1794         bugzilla-tool needs per-command help
1795         https://bugs.webkit.org/show_bug.cgi?id=31697
1796
1797         Added support for "bugzilla-tool help command-name"
1798         and a unit test to make sure it works.
1799
1800         * Scripts/modules/multicommandtool.py:
1801         * Scripts/modules/multicommandtool_unittest.py:
1802
1803 2009-11-19  Eric Seidel  <eric@webkit.org>
1804
1805         Reviewed by Adam Barth.
1806
1807         Move MultiCommandTool and Command into a separate file and add some basic unit tests
1808         https://bugs.webkit.org/show_bug.cgi?id=31695
1809
1810         * Scripts/bugzilla-tool:
1811         * Scripts/modules/multicommandtool.py: Added.
1812         * Scripts/modules/multicommandtool_unittest.py: Added.
1813         * Scripts/run-webkit-unittests:
1814
1815 2009-11-19  Eric Seidel  <eric@webkit.org>
1816
1817         No review, just adding a FIXME.
1818
1819         Split out command parsing and help printing from BugzillaTool
1820         https://bugs.webkit.org/show_bug.cgi?id=31688
1821
1822         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
1823
1824 2009-11-19  Eric Seidel  <eric@webkit.org>
1825
1826         Reviewed by Adam Barth.
1827
1828         Split out command parsing and help printing from BugzillaTool
1829         https://bugs.webkit.org/show_bug.cgi?id=31688
1830
1831         * Scripts/bugzilla-tool:
1832          - Add new MultiCommandTool class to contain option parsing and help printing logic.
1833          - Rename private methods to use _ pattern.
1834          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
1835          - 
1836
1837 2009-11-19  Eric Seidel  <eric@webkit.org>
1838
1839         Reviewed by Adam Barth.
1840
1841         Re-factor help printing to use modern python idioms
1842         https://bugs.webkit.org/show_bug.cgi?id=31685
1843
1844         * Scripts/bugzilla-tool:
1845
1846 2009-11-19  Eric Seidel  <eric@webkit.org>
1847
1848         Reviewed by Darin Adler.
1849
1850         commit-queue empty queue logs twice
1851         https://bugs.webkit.org/show_bug.cgi?id=31679
1852
1853         * Scripts/bugzilla-tool:
1854
1855 2009-11-19  Eric Seidel  <eric@webkit.org>
1856
1857         Reviewed by Darin Adler.
1858
1859         bugzilla-tool's reviewer/committer rejection message should be clearer
1860         https://bugs.webkit.org/show_bug.cgi?id=31126
1861
1862         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1863
1864         * Scripts/modules/bugzilla.py:
1865
1866 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1867
1868         Reviewed by Pavel Feldman.
1869
1870         Forces a WM_PAINT event on calling layoutTestController.display()
1871         in order to enable the timeline-paint.html test on Windows.
1872         ::UpdateWindow() does not force an event becaue the window is 
1873         not visible.
1874
1875         https://bugs.webkit.org/show_bug.cgi?id=31402
1876
1877         * DumpRenderTree/win/DumpRenderTree.cpp:
1878         (displayWebView):
1879
1880 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1881
1882         No review needed.
1883
1884         Added myself to committers list.
1885
1886         * Scripts/modules/committers.py:
1887
1888 2009-11-19  Adam Barth  <abarth@webkit.org>
1889
1890         Reviewed by Eric Seidel.
1891
1892         Bugzilla-tool command classes should match command names
1893         https://bugs.webkit.org/show_bug.cgi?id=31666
1894
1895         I renamed all the commands except CommitMessageForCurrentDiff because
1896         the new name would conflict with an existing class.
1897
1898         * Scripts/bugzilla-tool:
1899
1900 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1901
1902         Reviewed by Gustavo Noronha Silva.
1903
1904         Web Inspector: Implement "show inspector" in WebKit GTK
1905         API and enable console tests.
1906
1907         https://bugs.webkit.org/show_bug.cgi?id=31669
1908
1909         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1910         (LayoutTestController::showWebInspector):
1911
1912 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1913
1914         Reviewed by Simon Hausmann.
1915
1916         Minor refactoring + more documentation.
1917
1918         * DumpRenderTree/qt/DumpRenderTree.cpp:
1919         (WebCore::clearHistory):
1920         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1921
1922 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1923
1924         Reviewed by Eric Seidel.
1925
1926         Ignore websocket tests when --no-http is specified.
1927         https://bugs.webkit.org/show_bug.cgi?id=31662
1928
1929         * Scripts/run-webkit-tests:
1930
1931 2009-11-18  Adam Barth  <abarth@webkit.org>
1932
1933         Reviewed by Eric Seidel.
1934
1935         Normalize ' and " in bugzilla-tool
1936         https://bugs.webkit.org/show_bug.cgi?id=31655
1937
1938         We decided " is better than ' and we should be consistent.
1939
1940         * Scripts/bugzilla-tool:
1941
1942 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1943
1944         Reviewed by Kenneth Rohde Christiansen.
1945
1946         [Qt] Remove support for Qt v4.3 or older versions
1947         https://bugs.webkit.org/show_bug.cgi?id=29469
1948
1949         * DumpRenderTree/qt/DumpRenderTree.pro:
1950         * DumpRenderTree/qt/ImageDiff.pro:
1951
1952 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1953
1954         Reviewed by Eric Seidel.
1955
1956         GitTest.test_create_binary_patch fails if /tmp is symlink
1957         https://bugs.webkit.org/show_bug.cgi?id=31536
1958
1959         * Scripts/modules/scm_unittest.py:
1960
1961 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1962
1963         Reviewed by Darin Adler.
1964
1965         Configuration for Chromium Build Slaves.
1966
1967         https://bugs.webkit.org/show_bug.cgi?id=31442
1968
1969         * BuildSlaveSupport/build.webkit.org-config/config.json:
1970         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1971
1972 2009-11-18  Eric Seidel  <eric@webkit.org>
1973
1974         Reviewed by Darin Adler.
1975
1976         workqueue.py results in totally broken commit-queue UI
1977         https://bugs.webkit.org/show_bug.cgi?id=31645
1978
1979         * Scripts/bugzilla-tool:
1980          - Remove unneeded use of PatchCollection.
1981          - Grab a new copy of the cq'd patches every run of the queue.
1982
1983 2009-11-18  Sam Weinig  <sam@webkit.org>
1984
1985         Reviewed by Anders Carlsson.
1986
1987         Make the Mac Geolocation API async.
1988
1989         Update DRT to use the new async Mac Geolocation API.
1990
1991         * DumpRenderTree/mac/UIDelegate.mm:
1992         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1993
1994 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1995
1996         Reviewed by Kenneth Rohde Christiansen.
1997
1998         Add and option to toggle HTML5 datalist support to build-webkit
1999         https://bugs.webkit.org/show_bug.cgi?id=31599
2000
2001         * Scripts/build-webkit:
2002
2003 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
2004
2005         Reviewed by Kevin Ollivier.
2006
2007         Enable wx plugin support using the Windows implementation as a base.
2008         
2009         https://bugs.webkit.org/show_bug.cgi?id=31636
2010
2011         * wx/build/settings.py:
2012
2013 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2014
2015         Reviewed by Simon Hausmann.
2016
2017         Change the initialization order so that the controllers
2018         will be created before exporting them to the JS DOM window.
2019
2020         * DumpRenderTree/qt/DumpRenderTree.cpp:
2021         (WebCore::DumpRenderTree::DumpRenderTree):
2022
2023 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2024
2025         Reviewed by Simon Hausmann.
2026
2027         Fix a code copy and paste error. m_page should be page.
2028
2029         * DumpRenderTree/qt/DumpRenderTree.cpp:
2030         (WebCore::DumpRenderTree::createWindow):
2031
2032 2009-11-17  Mark Rowe  <mrowe@apple.com>
2033
2034         Reviewed by Alexey Proskuryakov.
2035
2036         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
2037
2038         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
2039         This prevents symlinks from confusing the descendant check.
2040
2041 2009-11-17  Mark Rowe  <mrowe@apple.com>
2042
2043         Reviewed by Alexey Proskuryakov.
2044
2045         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
2046
2047         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
2048         server to be up rather than having run-webkit-tests abort immediately.
2049
2050         * Scripts/run-webkit-tests:
2051
2052 2009-11-17  Eric Seidel  <eric@webkit.org>
2053
2054         Reviewed by Darin Adler.
2055
2056         commit-queue is failing to set reviewer in ChangeLogs
2057         https://bugs.webkit.org/show_bug.cgi?id=31592
2058
2059         * Scripts/bugzilla-tool: Clarify the "applying" log message.
2060         * Scripts/modules/bugzilla.py:
2061          - Add a new _validate_committer_and_reviewer function as a
2062            temporary solution until we can make a real Attachment object
2063            which knows how to fill in its committer/reviewer fields automatically.
2064
2065 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2066
2067         Unreviewed buildbot fix.
2068
2069         Revert part of earlier patch and add comment, as it
2070         was causing timeouts on the buildbot.
2071
2072         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2073         (LayoutTestController::notifyDone):
2074
2075 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2076
2077         Reviewed by Oliver Hunt.
2078
2079         Make the timeout 15 sec as for the other DRT's and make
2080         it print out the same output when a test timeout.
2081
2082         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2083         (LayoutTestController::waitUntilDone):
2084         (LayoutTestController::notifyDone):
2085         (LayoutTestController::timerEvent):
2086
2087 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
2088
2089         Reviewed by Timothy Hatcher.
2090
2091         Fixed typos in comments.
2092
2093         * Scripts/modules/committers.py:
2094
2095 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
2096
2097         Reviewed by Timothy Hatcher.
2098
2099         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
2100         - Updated DRT to show/close inspector for all tests under /inspector
2101         - Introduced LayoutTestController::setTimelineProfilingEnabled and
2102           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
2103         - Removed reload on each inspector test
2104         - Renamed fast/inspector to fast/inspector-support in order not to trigger
2105         inspector for those.
2106         - Reimplemented timeline tests in order to get rid of reload there.
2107         - Moved tests that don't require harness into the fast group.
2108
2109         https://bugs.webkit.org/show_bug.cgi?id=31472
2110
2111         * DumpRenderTree/LayoutTestController.cpp:
2112         (setTimelineProfilingEnabledCallback):
2113         (closeWebInspectorCallback):
2114         (LayoutTestController::staticFunctions):
2115         * DumpRenderTree/LayoutTestController.h:
2116         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2117         (shouldOpenWebInspector):
2118         (runTest):
2119         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2120         (LayoutTestController::setTimelineProfilingEnabled):
2121         * DumpRenderTree/mac/DumpRenderTree.mm:
2122         (shouldOpenWebInspector):
2123         (runTest):
2124         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2125         (LayoutTestController::setTimelineProfilingEnabled):
2126         * DumpRenderTree/win/DumpRenderTree.cpp:
2127         (shouldOpenWebInspector):
2128         (runTest):
2129         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2130         (LayoutTestController::setTimelineProfilingEnabled):
2131
2132 2009-11-17  Oliver Hunt  <oliver@apple.com>
2133
2134         Reviewed by Maciej Stachowiak.
2135
2136         Incorrect use of JavaScriptCore API in DumpRenderTree
2137         https://bugs.webkit.org/show_bug.cgi?id=31577
2138
2139         Return undefined rather than a literal null.
2140
2141         * DumpRenderTree/AccessibilityUIElement.cpp:
2142         (setSelectedTextRangeCallback):
2143         (incrementCallback):
2144         (decrementCallback):
2145         (showMenuCallback):
2146
2147 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
2148
2149         Reviewed by Beth Dakin.
2150
2151         AX: aria-labelledby duplicates some of its WAI-ARIA label
2152         https://bugs.webkit.org/show_bug.cgi?id=31565
2153
2154         * DumpRenderTree/AccessibilityUIElement.cpp:
2155         (titleUIElementCallback):
2156         (getIsValidCallback):
2157         (AccessibilityUIElement::getJSClass):
2158
2159 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2160
2161         Reviewed by Simon Hausmann.
2162
2163         r50942 broke output from created windows. Make the
2164         m_enableTextOutput a member of the DRT and not the
2165         WebPage.
2166
2167         * DumpRenderTree/qt/DumpRenderTree.cpp:
2168         (WebCore::WebPage::WebPage):
2169         (WebCore::WebPage::javaScriptAlert):
2170         (WebCore::WebPage::javaScriptConsoleMessage):
2171         (WebCore::WebPage::javaScriptConfirm):
2172         (WebCore::WebPage::javaScriptPrompt):
2173         (WebCore::WebPage::acceptNavigationRequest):
2174         (WebCore::DumpRenderTree::DumpRenderTree):
2175         (WebCore::DumpRenderTree::open):
2176         (WebCore::DumpRenderTree::createWindow):
2177         * DumpRenderTree/qt/DumpRenderTree.h:
2178         (WebCore::DumpRenderTree::setTextOutputEnabled):
2179         (WebCore::DumpRenderTree::isTextOutputEnabled):
2180         (WebCore::WebPage::shouldInterruptJavaScript):
2181         (WebCore::WebPage::isTextOutputEnabled):
2182         (WebCore::WebPage::setViewGeometry):
2183
2184 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2185
2186         Reviewed by Gustavo Noronha Silva.
2187
2188         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
2189         as the implementation is being used by at least Qt and Gtk+.
2190
2191         Update buildsystems as well.
2192
2193         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2194         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
2195         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
2196         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
2197         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2198         * GNUmakefile.am:
2199
2200 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
2201
2202         Reviewed by Alexey Proskuryakov.
2203
2204         Disable wss until all platforms support pyOpenSSL
2205
2206         https://bugs.webkit.org/show_bug.cgi?id=31479
2207
2208         * Scripts/run-webkit-tests:
2209
2210 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
2211
2212         Reviewed by Kenneth Christiansen.
2213
2214         [Qt] Implement load error pages support for Qt's DRT.
2215         https://bugs.webkit.org/show_bug.cgi?id=31509
2216
2217         For now, it will not be a default feature, and layout tests
2218         that want to make use of this have to explicitily call
2219         'handleErrorPages();' for the test source.
2220
2221         Any of the other DumpRenderTree's (mac, win and gtk)
2222         support handling error pages. Qt's will be the first.
2223
2224         * DumpRenderTree/qt/DumpRenderTree.cpp:
2225         (WebCore::WebPage::supportsExtension):
2226         (WebCore::WebPage::extension):
2227         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2228         (LayoutTestController::reset):
2229         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2230         (LayoutTestController::shouldHandleErrorPages):
2231         (LayoutTestController::handleErrorPages):
2232
2233 2009-11-16  Eric Seidel  <eric@webkit.org>
2234
2235         Reviewed by Adam Barth.
2236
2237         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
2238         https://bugs.webkit.org/show_bug.cgi?id=31549
2239
2240         Renamed --commit-queue to --non-interactive in most places
2241         and remove the code in land-patches which is no longer needed.
2242
2243         * Scripts/bugzilla-tool:
2244
2245 2009-11-16  Eric Seidel  <eric@webkit.org>
2246
2247         Reviewed by Adam Barth.
2248
2249         The commit-queue should use land-attachment
2250         https://bugs.webkit.org/show_bug.cgi?id=31548
2251
2252         * Scripts/bugzilla-tool:
2253
2254 2009-11-16  Adam Barth  <abarth@webkit.org>
2255
2256         Reviewed by Eric Seidel.
2257
2258         Convert CommitQueue over to PatchCollection
2259         https://bugs.webkit.org/show_bug.cgi?id=31547
2260
2261         Also fixes a bug in workqueue and adds a test!
2262
2263         * Scripts/bugzilla-tool:
2264         * Scripts/modules/workqueue.py:
2265         * Scripts/modules/workqueue_unittest.py:
2266
2267 2009-11-16  Adam Barth  <abarth@webkit.org>
2268
2269         Reviewed by Eric Seidel.
2270
2271         Move StyleQueue over to using PatchCollection
2272         https://bugs.webkit.org/show_bug.cgi?id=31544
2273
2274         That's what the class it's for.
2275
2276         * Scripts/bugzilla-tool:
2277         * Scripts/modules/patchcollection.py:
2278         * Scripts/modules/patchcollection_unittest.py:
2279
2280 2009-11-16  Eric Seidel  <eric@webkit.org>
2281
2282         Reviewed by Adam Barth.
2283
2284         bugzilla-tool needs a land-attachment command
2285         https://bugs.webkit.org/show_bug.cgi?id=31546
2286
2287         * Scripts/bugzilla-tool:
2288          - Move all the logic into AbstractLandingCommand and
2289            add a new LandAttachment command subclass.
2290          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
2291
2292 2009-11-16  Eric Seidel  <eric@webkit.org>
2293
2294         Reviewed by Adam Barth.
2295
2296         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
2297         https://bugs.webkit.org/show_bug.cgi?id=31543
2298
2299         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
2300
2301         * Scripts/bugzilla-tool:
2302
2303 2009-11-16  Eric Seidel  <eric@webkit.org>
2304
2305         Reviewed by Adam Barth.
2306
2307         Disable the style queue from posting to the commit queue status page.
2308
2309         * Scripts/bugzilla-tool:
2310
2311 2009-11-16  Adam Barth  <abarth@webkit.org>
2312
2313         Reviewed by Eric Seidel.
2314
2315         Implement PatchCollection
2316         https://bugs.webkit.org/show_bug.cgi?id=31541
2317
2318         This class holds a set of patches and lets clients iterate through
2319         them.  Optionally, clients can install a filter.
2320
2321         * Scripts/modules/patchcollection.py: Added.
2322         * Scripts/modules/patchcollection_unittest.py: Added.
2323         * Scripts/run-webkit-unittests:
2324
2325 2009-11-16  Eric Seidel  <eric@webkit.org>
2326
2327         Reviewed by Adam Barth.
2328
2329         bugzilla-tool land-patches will close bugs with patches r=?
2330         https://bugs.webkit.org/show_bug.cgi?id=28230
2331
2332         The commit-queue shouldn't close patches with outstanding reviews on them,
2333         even if many reviewers seem to be against multi-patch bugs.
2334
2335         * Scripts/bugzilla-tool:
2336
2337 2009-11-16  Eric Seidel  <eric@webkit.org>
2338
2339         Reviewed by Adam Barth.
2340
2341         bugzilla-tool check-style should work with attachment ids instead of bug ids
2342         https://bugs.webkit.org/show_bug.cgi?id=31540
2343
2344         * Scripts/bugzilla-tool:
2345
2346 2009-11-16  Eric Seidel  <eric@webkit.org>
2347
2348         Reviewed by Adam Barth.
2349
2350         WorkQueue is the only place that should know about special exit codes
2351         https://bugs.webkit.org/show_bug.cgi?id=31534
2352
2353         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
2354         and add tests for handling exit codes.
2355         I also cleaned up workqueue_unittest.py more.
2356
2357         * Scripts/bugzilla-tool:
2358         * Scripts/modules/workqueue.py:
2359         * Scripts/modules/workqueue_unittest.py:
2360
2361 2009-11-16  Eric Seidel  <eric@webkit.org>
2362
2363         Reviewed by Adam Barth.
2364
2365         Re-factor workqueue_unittest to allow for more than one test.
2366         https://bugs.webkit.org/show_bug.cgi?id=31535
2367
2368         * Scripts/modules/workqueue_unittest.py:
2369
2370 2009-11-16  Eric Seidel  <eric@webkit.org>
2371
2372         Reviewed by Adam Barth.
2373
2374         land-patches needs to be re-factored into smaller chunks
2375         https://bugs.webkit.org/show_bug.cgi?id=31532
2376
2377         * Scripts/bugzilla-tool: fix a couple obvious typos.
2378
2379 2009-11-16  Eric Seidel  <eric@webkit.org>
2380
2381         Reviewed by Adam Barth.
2382
2383         land-patches needs to be re-factored into smaller chunks
2384         https://bugs.webkit.org/show_bug.cgi?id=31532
2385
2386         The next patch will move these methods into WebKitLandingScripts.
2387
2388         * Scripts/bugzilla-tool:
2389          - Split out _land_patch and _close_bug_if_no_active_patches.
2390
2391 2009-11-16  Adam Barth  <abarth@webkit.org>
2392
2393         Reviewed by Eric Seidel.
2394
2395         Fix silly copy-and-paste code.  I am a terrible coder.
2396
2397         * Scripts/modules/bugzilla.py:
2398
2399 2009-11-16  Adam Barth  <abarth@webkit.org>
2400
2401         Reviewed by Eric Seidel.
2402
2403         Implement a StyleQueue
2404         https://bugs.webkit.org/show_bug.cgi?id=31537
2405
2406         The first iteration of the style queue only produces output locally.
2407         There is also a limit of 10 patches because it's not that useful to
2408         iterate through the entire review queue at this point.  We can remove
2409         the limit later.
2410
2411         * Scripts/bugzilla-tool:
2412         * Scripts/modules/bugzilla.py:
2413
2414 2009-11-16  Adam Barth  <abarth@webkit.org>
2415
2416         Reviewed by Eric Seidel.
2417
2418         Unit test WorkQueue
2419         https://bugs.webkit.org/show_bug.cgi?id=31531
2420
2421         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
2422
2423         * Scripts/bugzilla-tool:
2424         * Scripts/modules/statusbot.py:
2425         * Scripts/modules/workqueue.py:
2426         * Scripts/modules/workqueue_unittest.py: Added.
2427         * Scripts/run-webkit-unittests:
2428
2429 2009-11-16  Eric Seidel  <eric@webkit.org>
2430
2431         Reviewed by Adam Barth.
2432
2433         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
2434         https://bugs.webkit.org/show_bug.cgi?id=31530
2435
2436         * Scripts/bugzilla-tool:
2437
2438 2009-11-16  Eric Seidel  <eric@webkit.org>
2439
2440         Reviewed by Adam Barth.
2441
2442         bugzilla-tool needs apply-attachment
2443         https://bugs.webkit.org/show_bug.cgi?id=31528
2444
2445         * Scripts/bugzilla-tool:
2446          - Add ApplyAttachment command.
2447          - Abstract applying code into WebKitApplyingScripts.
2448          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
2449         * Scripts/modules/bugzilla.py:
2450          - Add fetch_attachment and bug_id_for_attachment_id.
2451         * Scripts/modules/bugzilla_unittest.py:
2452          - Add test for new parsing.
2453          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
2454
2455 2009-11-16  Eric Seidel  <eric@webkit.org>
2456
2457         Reviewed by Adam Barth.
2458
2459         Document check-style's use of force_clean.
2460
2461         * Scripts/bugzilla-tool:
2462         * Scripts/modules/scm.py:
2463
2464 2009-11-16  Adam Barth  <abarth@webkit.org>
2465
2466         Reviewed by Eric Seidel.
2467
2468         Move WorkQueue to its own file
2469         https://bugs.webkit.org/show_bug.cgi?id=31529
2470
2471         WorkQueue and WorkQueueDelegate are separate concerns from
2472         bugzilla-tool.  Also added a missing include to logging.py.
2473
2474         * Scripts/bugzilla-tool:
2475         * Scripts/modules/logging.py:
2476         * Scripts/modules/workqueue.py:
2477
2478 2009-11-16  Adam Barth  <abarth@webkit.org>
2479
2480         Reviewed by Eric Seidel.
2481
2482         Move OutputTee to logging.py.
2483
2484         * Scripts/bugzilla-tool:
2485         * Scripts/modules/logging.py:
2486
2487 2009-11-15  Adam Barth  <abarth@webkit.org>
2488
2489         Reviewed by Eric Seidel.
2490
2491         Refactor bugzilla-tool to allow for multiple queues
2492         https://bugs.webkit.org/show_bug.cgi?id=31513
2493
2494         Divide the commit queue class into three class to make creating
2495         additional queues easier.
2496
2497         * Scripts/bugzilla-tool:
2498
2499 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2500
2501         Reviewed by Eric Seidel.
2502
2503         svn-apply may not handle git patches created by bugzilla-tool
2504         https://bugs.webkit.org/show_bug.cgi?id=31457
2505
2506         * Scripts/modules/scm.py:
2507         * Scripts/modules/scm_unittest.py:
2508
2509 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2510
2511         Reviewed by Eric Seidel.
2512
2513         bugzilla-tool should post git binary diff
2514         https://bugs.webkit.org/show_bug.cgi?id=31458
2515
2516         Add --binary option to Git.create_patch.
2517
2518         * Scripts/modules/scm.py:
2519         * Scripts/modules/scm_unittest.py:
2520
2521 2009-11-15  Adam Barth  <abarth@webkit.org>
2522
2523         Reviewed by Darin Adler.
2524
2525         Add bugzilla-tool check-style
2526         https://bugs.webkit.org/show_bug.cgi?id=31515
2527
2528         * Scripts/bugzilla-tool:
2529         * Scripts/modules/bugzilla.py:
2530
2531 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2532
2533         Reviewed by Simon Hausmann.
2534
2535         Make the Qt Linux only --valgrind feature, suppress errors
2536         defined in the SuppressedValgrindErrors file.
2537
2538         * Scripts/run-webkit-tests:
2539
2540 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2541
2542         Reviewed by Simon Hausmann.
2543
2544         Set the locale to C and not to the current one in use on the system.
2545
2546         * DumpRenderTree/qt/DumpRenderTree.cpp:
2547         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2548
2549 2009-11-13  Adam Roben  <aroben@apple.com>
2550
2551         Add support for
2552         http/tests/security/isolatedWorld/didClearWindowObject.html
2553
2554         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
2555         window objects in isolated worlds are cleared
2556
2557         Reviewed by Dave Hyatt.
2558
2559         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
2560
2561         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2562         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2563         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
2564         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
2565         Added. Sets a __worldID property on the global object whose value is
2566         the ID of this world.
2567         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
2568         Respond to this new delegate callback by calling through to one of the
2569         above new methods.
2570         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2571         (worldMap): Added. Returns a HashMap containing all the worlds we've
2572         created.
2573         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
2574         haven't kept track of this world.
2575         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2576         instead of declaring our own.
2577
2578         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
2579
2580         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2581         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
2582         didClearWindowObjectForFrameInStandardWorld.
2583         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
2584         Respond to this new delegate callback by calling through to one of the
2585         below new methods.
2586         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
2587         Added. Sets a __worldID property on the gobal object whose value is
2588         the ID of this world.
2589         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2590         Added. Moved code here from didClearWindowObject.
2591
2592         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
2593         didClearWindowObjectForFrame* functions.
2594
2595         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2596         (worldMap): Added. Returns a HashMap containing all the worlds we've
2597         created.
2598         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
2599         haven't kept track of this world.
2600         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2601         instead of declaring our own.
2602
2603 2009-11-13  Adam Roben  <aroben@apple.com>
2604
2605         Finish replacing worldIDs with world objects
2606
2607         The only remaining use of worldIDs was in a method only used by DRT
2608         for the isolated worlds tests.
2609
2610         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
2611
2612         Reviewed by Mark Rowe.
2613
2614         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2615         (LayoutTestController::evaluateScriptInIsolatedWorld):
2616         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2617         (LayoutTestController::evaluateScriptInIsolatedWorld):
2618         Updated for changes to WebFrame. Now holds the map of worldID -> world
2619         at this level instead of making WebKit do it.
2620
2621 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2622
2623         Reviewed by Simon Hausmann.
2624
2625         [Qt] Ensure the DRT does not output anything until first test is run
2626
2627         * DumpRenderTree/qt/DumpRenderTree.cpp:
2628         * DumpRenderTree/qt/DumpRenderTree.h:
2629
2630 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2631
2632         Reviewed by Tor Arne Vestbø.
2633
2634         Clear the undo stack in before each new test run.
2635
2636         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
2637
2638         * DumpRenderTree/qt/DumpRenderTree.cpp:
2639         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2640
2641 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2642
2643         Reviewed by Kenneth Rohde Christiansen.
2644
2645         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
2646
2647         * DumpRenderTree/qt/DumpRenderTree.cpp:
2648         (WebCore::WebPage::resetSettings):
2649         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2650         (LayoutTestController::overridePreference):
2651
2652 2009-11-13  Eric Seidel  <eric@webkit.org>
2653
2654         Reviewed by Adam Barth.
2655
2656         Update committers.py based on svn records
2657         https://bugs.webkit.org/show_bug.cgi?id=31366
2658
2659         This list was generated using validate-committer-lists from
2660         https://bugs.webkit.org/show_bug.cgi?id=30970
2661         and makes committers.py current for committers who have
2662         committed in the last 3 years.
2663
2664         * Scripts/modules/committers.py:
2665
2666 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
2667
2668         Reviewed by Adam Barth.
2669
2670         The document-open.html test was flaky at times. The test invokes the layout test plugin
2671         which in its destroy stream handler opens a new document. This basically tears down the
2672         stream and the associated plugin instance. The pluginLog function in the layout test
2673         plugin attempts to retrieve the window script object on a torn down plugin instance
2674         which crashed consistently on windows in the debugger. The functions which issue
2675         these logs already have a valid window script object. We now have variants of the pluginLog
2676         function which take in a window script object with and without variable arguments. 
2677
2678         https://bugs.webkit.org/show_bug.cgi?id=31067
2679
2680         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2681         (pluginLogWithWindowObject):
2682         (pluginLogWithWindowObjectVariableArgs):
2683         (pluginLog):
2684         (notifyTestCompletion):
2685         (testDocumentOpen):
2686         (testWindowOpen):
2687
2688 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2689
2690         Reviewed by Gustavo Noronha Silva.
2691
2692         https://bugs.webkit.org/show_bug.cgi?id=30997
2693         [Gtk] Implemment AtkDocument
2694
2695         Added testing support.
2696
2697         * DumpRenderTree/AccessibilityUIElement.cpp:
2698         * DumpRenderTree/AccessibilityUIElement.h:
2699         (getDocumentEncodingCallback):
2700         (getDocumentURICallback):
2701         (AccessibilityUIElement::getJSClass):
2702         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2703         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2704         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2705         (AccessibilityUIElement::documentEncoding):
2706         (AccessibilityUIElement::documentURI):
2707
2708 2009-11-12  Adam Roben  <aroben@apple.com>
2709
2710         Replace worldIDs with world objects
2711
2712         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
2713         user scripts/stylesheets and isolated worlds
2714
2715         Reviewed by Sam Weinig.
2716
2717         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2718         (LayoutTestController::addUserScript):
2719         (LayoutTestController::addUserStyleSheet):
2720         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2721         (LayoutTestController::addUserScript):
2722         (LayoutTestController::addUserStyleSheet):
2723         Changed these functions to create a new WebJSWorld each time they're
2724         called and to pass that world to WebKit.
2725
2726 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
2727
2728         Reviewed by Oliver Hunt.
2729
2730         need to implement aria tree roles
2731         https://bugs.webkit.org/show_bug.cgi?id=31284
2732
2733         * DumpRenderTree/AccessibilityUIElement.cpp:
2734         (disclosedRowAtIndexCallback):
2735         (selectedRowAtIndexCallback):
2736         (isEqualCallback):
2737         (isAttributeSettableCallback):
2738         (isActionSupportedCallback):
2739         (disclosedByRowCallback):
2740         (hierarchicalLevelCallback):
2741         (AccessibilityUIElement::getJSClass):
2742         * DumpRenderTree/AccessibilityUIElement.h:
2743         (AccessibilityUIElement::isEqual):
2744         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2745         (AccessibilityUIElement::hierarchicalLevel):
2746         (AccessibilityUIElement::disclosedRowAtIndex):
2747         (AccessibilityUIElement::selectedRowAtIndex):
2748         (AccessibilityUIElement::disclosedByRow):
2749         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2750         (AccessibilityUIElement::getChildAtIndex):
2751         (AccessibilityUIElement::disclosedRowAtIndex):
2752         (AccessibilityUIElement::selectedRowAtIndex):
2753         (AccessibilityUIElement::titleUIElement):
2754         (AccessibilityUIElement::parentElement):
2755         (AccessibilityUIElement::disclosedByRow):
2756         (AccessibilityUIElement::hierarchicalLevel):
2757         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2758         (AccessibilityUIElement::hierarchicalLevel):
2759         (AccessibilityUIElement::disclosedRowAtIndex):
2760         (AccessibilityUIElement::selectedRowAtIndex):
2761         (AccessibilityUIElement::disclosedByRow):
2762
2763 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
2764
2765         Reviewed by Darin Adler.
2766
2767         svn-apply can not handle git binary diffs
2768         https://bugs.webkit.org/show_bug.cgi?id=26830
2769
2770         Support "literal" type git binary diffs.
2771
2772         * Scripts/VCSUtils.pm:
2773         * Scripts/modules/scm_unittest.py:
2774         * Scripts/svn-apply:
2775
2776 2009-11-11  Dmitry Titov  <dimich@chromium.org>
2777
2778         Not reviewed, removing duplicate entry for myself in committers.py.
2779
2780         * Scripts/modules/committers.py:
2781
2782 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
2783
2784         Reviewed by Darin Adler and Mark Rowe.
2785
2786         https://bugs.webkit.org/show_bug.cgi?id=31200
2787         Tests in http/tests/security/mixedContent start to fail when new tests are added
2788
2789         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
2790
2791 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2792
2793         Reviewed by Jan Alonzo.
2794
2795         Create, and display a window for the inspector, for inspector
2796         tests.
2797
2798         Need to also show/hide the inspector window to avoid having
2799         problems with code assuming it is realized
2800         https://bugs.webkit.org/show_bug.cgi?id=31347
2801
2802         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2803         (webInspectorShowWindow):
2804         (webInspectorCloseWindow):
2805         (webInspectorInspectWebView):
2806         (createWebView):
2807
2808 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2809
2810         Unreviewed Qt buildbot fix.
2811
2812         My previous fix was wrong, so revert that change and fix it by
2813         returning when the document of the frame has no document element.
2814         Idea is borrowed from mac and win DRT.
2815
2816         * DumpRenderTree/qt/DumpRenderTree.cpp:
2817         (WebCore::DumpRenderTree::dumpFramesAsText):
2818
2819 2009-11-11  Eric Seidel  <eric@webkit.org>
2820
2821         Reviewed byg Kenneth Rohde Christiansen.
2822
2823         Update Kenneth's committer record to include the email he
2824         uses on lists.webkit.org.
2825
2826         * Scripts/modules/committers.py:
2827
2828 2009-11-11  Eric Seidel  <eric@webkit.org>
2829
2830         Reviewed by Gustavo Noronha Silva.
2831
2832         Several committers use separate email addresses for bugzilla and svn.webkit.org
2833         https://bugs.webkit.org/show_bug.cgi?id=31364
2834
2835         Update records for existing committers to include email addresses
2836         used in svn.webkit.org and lists.webkit.org.
2837         Most committers use the same email address in all 3 places, but some use
2838         separate addresses.  committers.py needs record of each of these addresses.
2839
2840         * Scripts/modules/committers.py:
2841
2842 2009-11-11  Eric Seidel  <eric@webkit.org>
2843
2844         No review, adding second email address for an existing committer.
2845
2846         Add Yong Li's second bugzilla account to his committer record.
2847         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
2848
2849         * Scripts/modules/committers.py:
2850
2851 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2852
2853         Reviewed by Simon Hausmann.
2854
2855         If the frame has no innerText don't append it, and
2856         do not add a newline which breaks some cross platform
2857         results.
2858
2859         * DumpRenderTree/qt/DumpRenderTree.cpp:
2860         (WebCore::DumpRenderTree::dumpFramesAsText):
2861
2862 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2863
2864         Reviewed by Simon Hausmann.
2865
2866         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2867
2868         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2869         (webkit_test_plugin_new_instance):
2870         (webkit_test_plugin_destroy_instance):
2871         (webkit_test_plugin_destroy_stream):
2872
2873 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2874
2875         Reviewed by Mark Rowe.
2876
2877         Implement the functionality needed by plugins/window-open.html
2878
2879         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2880         (webkit_test_plugin_new_instance):
2881         (webkit_test_plugin_set_window):
2882
2883 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2884
2885         Reviewed by Simon Hausmann.
2886
2887         [Qt] Force -graphicssystem raster and -style windows when running DRT
2888
2889         * DumpRenderTree/qt/main.cpp:
2890         * Scripts/run-webkit-tests:
2891
2892 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2893
2894         Reviewed by Simon Hausmann.
2895
2896         Compute correct library paths for Qt
2897
2898         * Scripts/webkitdirs.pm:
2899
2900 2009-11-10  Mark Rowe  <mrowe@apple.com>
2901
2902         Reviewed by Sam Weinig.
2903
2904         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2905
2906         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2907         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2908         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2909         that had enabled frame load delegate logging this would result in extra log messages being generated,
2910         causing the test to fail.
2911
2912         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2913         tests.
2914
2915         * DumpRenderTree/mac/DumpRenderTree.mm:
2916         (dumpRenderTree):
2917         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2918         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2919
2920 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2921
2922         Reviewed by Kenneth Rohde Christiansen.
2923
2924         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2925
2926         * DumpRenderTree/qt/DumpRenderTree.cpp:
2927         (WebCore::DumpRenderTree::DumpRenderTree):
2928
2929 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2930
2931         Reviewed by Jan Alonzo.
2932
2933         [GTK] Remove WebSocket configuration from WebKitWebSettings
2934         https://bugs.webkit.org/show_bug.cgi?id=31244
2935
2936         Follow-up of r50724. Don't set the enable-web-socket property
2937         anymore.
2938
2939         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2940         (resetDefaultsToConsistentValues):
2941
2942 2009-11-10  Oliver Hunt  <oliver@apple.com>
2943
2944         Reviewed by Maciej Stachowiak.
2945
2946         Rename 3D Canvas related classes to use WebGL prefix
2947         https://bugs.webkit.org/show_bug.cgi?id=29095
2948
2949         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2950         and upate webkitdirs script to new method of testing for WebGL.
2951
2952         * Scripts/do-webcore-rename:
2953         * Scripts/webkitdirs.pm:
2954
2955 2009-11-09  Oliver Hunt  <oliver@apple.com>
2956
2957         Reviewed by Geoff Garen.
2958
2959         Make do-webcore-rename work with git.
2960
2961         * Scripts/do-webcore-rename:
2962
2963 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2964
2965         Adding Kenneth to the reviewers list.
2966
2967         * Scripts/modules/committers.py:
2968
2969 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2970
2971         Reviewed by Jan Alonzo.
2972
2973         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2974         https://bugs.webkit.org/show_bug.cgi?id=30482
2975
2976         LayoutTestControllerGtk now uses the exposed
2977         Page::tabKeyCyclesThroughElements API
2978
2979         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2980         (LayoutTestController::setTabKeyCyclesThroughElements):
2981
2982 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2983
2984         Reviewed by Holger Freyther.
2985
2986         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2987         This helps to pass the test case below. Also replaced hardcoded
2988         code numbers with defined constants.
2989         https://bugs.webkit.org/show_bug.cgi?id=31185
2990         
2991         Test: editing/undo/undo-deleteWord.html
2992
2993         * DumpRenderTree/qt/EventSenderQt.cpp:
2994         (EventSender::keyDown):
2995
2996 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2997
2998         Reviewed by Holger Freyther.
2999
3000         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
3001         https://bugs.webkit.org/show_bug.cgi?id=31164
3002
3003         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
3004
3005         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3006         (LayoutTestController::processWork):
3007
3008 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
3009
3010         Reviewed by Holger Freyther.
3011
3012         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
3013         https://bugs.webkit.org/show_bug.cgi?id=31158
3014
3015         By invoking a script queue'd by queueScript(), 'true' was beeing returned
3016         always, which from WorkQueue prospective means that a load has been started
3017         and the queue processing should stop and wait for the load to finish.
3018         Spinning it off into a loading and a non-loading variants was the solution
3019         adopted by Mac's DRT to work around this problem. The former keeps returning
3020         'true' while the later executes the script synchronously and returns 'false'
3021         making it possible to the WorkQueue to proceed right away.
3022
3023         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3024         (LayoutTestController::processWork):
3025         (LayoutTestController::queueLoadingScript):
3026         (LayoutTestController::queueNonLoadingScript):
3027         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3028         * DumpRenderTree/qt/WorkQueueItem.h:
3029         (LoadingScriptItem::LoadingScriptItem):
3030         (LoadingScriptItem::invoke):
3031         (NonLoadingScriptItem::NonLoadingScriptItem):
3032         (NonLoadingScriptItem::invoke):
3033
3034 2009-11-07  Mark Rowe  <mrowe@apple.com>
3035
3036         Rubber-stamped by Cameron Zwarich.
3037
3038         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
3039
3040         * Scripts/commit-log-editor:
3041
3042 2009-11-07  Mark Rowe  <mrowe@apple.com>
3043
3044         Reviewed by Darin Adler.
3045
3046         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
3047         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
3048
3049         Move logic for determining the name and email address to use in a ChangeLog entry from
3050         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
3051         whether the author of the patch matches committer, and therefore needs access to the
3052         email address that would be used in a ChangeLog entry.
3053
3054         Based on a patch by Pierre d'Herbemont.
3055
3056         * Scripts/VCSUtils.pm:
3057         * Scripts/commit-log-editor:
3058         * Scripts/prepare-ChangeLog:
3059         * Scripts/webkitdirs.pm:
3060
3061 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
3062
3063         Reviewed by Adam Barth.
3064
3065         Added functionality to the layout test plugin to invoke document.open and
3066         window.open with default arguments. The associated webkit bug is
3067         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
3068         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
3069         work in Chromium (V8) if there is no calling javascript context. To achieve this
3070         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
3071         for the window.open test case and in NPP_DestroyStream for the document.open test case.
3072
3073         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3074         (testDocumentOpen):
3075         (testWindowOpen):
3076         (pluginAllocate):
3077         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3078         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3079         (NPP_New):
3080         (NPP_SetWindow):
3081         (NPP_DestroyStream):
3082         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3083         (NPP_New):
3084         (NPP_SetWindow):
3085         (NPP_NewStream):
3086         (NPP_DestroyStream):
3087
3088 2009-11-06  Eric Seidel  <eric@webkit.org>
3089
3090         Reviewed by Adam Barth.
3091
3092         bugzilla-tool crashed with exception
3093         https://bugs.webkit.org/show_bug.cgi?id=31092
3094
3095         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
3096
3097 2009-11-04  Eric Seidel  <eric@webkit.org>
3098
3099         No review, just add a line which got left out of the patch uploaded for commit.
3100
3101         commit-queue is crashing when trying to reject patches after unknown failures
3102         https://bugs.webkit.org/show_bug.cgi?id=31091
3103
3104         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
3105
3106 2009-11-04  Adam Roben  <aroben@apple.com>
3107
3108         Remove bogus else clause in bugzilla-tool
3109
3110         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
3111         create-bug raises exception after entering bug description
3112
3113         Reviewed by David Kilzer.
3114
3115         * Scripts/bugzilla-tool:
3116         (CreateBug): else clauses are only hit if no exception is raised, so
3117         it makes no sense to try to re-raise the exception in an else clause.
3118         The exception will automatically be re-raised if it doesn't match any
3119         of the except clauses, so we don't have to do anything special here at
3120         all to get the desired behavior.
3121
3122 2009-11-04  Eric Seidel  <eric@webkit.org>
3123
3124         Reviewed by David Kilzer.
3125
3126         svn-apply's fixChangeLogPatch function seems broken
3127         https://bugs.webkit.org/show_bug.cgi?id=30683
3128
3129         Update fixChangeLogPatch to be able to handle patches which
3130         don't start at line 1.
3131         Add unit tests for svn-apply to scm_unittest.py.
3132
3133         * Scripts/VCSUtils.pm:
3134         * Scripts/modules/scm_unittest.py:
3135
3136 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
3137
3138         Reviewed by Beth Dakin.
3139
3140         Need to implement ARIA role="combobox"
3141         https://bugs.webkit.org/show_bug.cgi?id=31096
3142
3143         * DumpRenderTree/AccessibilityUIElement.cpp:
3144         (showMenuCallback):
3145         (getIsExpandedCallback):
3146         (AccessibilityUIElement::getJSClass):
3147         * DumpRenderTree/AccessibilityUIElement.h:
3148         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3149         (AccessibilityUIElement::isExpanded):
3150         (AccessibilityUIElement::showMenu):
3151         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3152         (AccessibilityUIElement::isExpanded):
3153         (AccessibilityUIElement::showMenu):
3154         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3155         (AccessibilityUIElement::isSelected):
3156         (AccessibilityUIElement::isExpanded):
3157         (AccessibilityUIElement::showMenu):
3158
3159 2009-11-04  Eric Seidel  <eric@webkit.org>
3160
3161         Reviewed by Adam Barth.
3162
3163         commit-queue is crashing when trying to reject patches after unknown failures
3164         https://bugs.webkit.org/show_bug.cgi?id=31091
3165
3166         * Scripts/bugzilla-tool:
3167          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
3168            so we have to find out what the current patch is by asking bugzilla again.
3169          - Discovered that this code was also leaking file descriptors, so fixed that.
3170
3171 2009-11-04  Adam Roben  <aroben@apple.com>
3172
3173         Make run-webkit-tests work for the Debug_Internal Windows
3174         configuration
3175
3176         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
3177         suffix.
3178
3179         Fixes <http://webkit.org/b/31123>.
3180
3181         Reviewed by Sam Weinig.
3182
3183         * Scripts/run-webkit-tests: Don't add the _debug suffix in
3184         Debug_Internal, either.
3185
3186 2009-11-04  Eric Seidel  <eric@webkit.org>
3187
3188         Reviewed by Adam Barth.
3189
3190         committers.py needs a way to store non-bugzilla email addresses
3191         https://bugs.webkit.org/show_bug.cgi?id=31037
3192
3193         Make Committer and Reviewer constructors take a single email or a list of emails.
3194         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
3195         Expose reviewers(), used by validate-committer-lists on bug 30970.
3196
3197         * Scripts/modules/committers.py:
3198         * Scripts/modules/committers_unittest.py: Added tests for the new code.
3199
3200 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
3201
3202         Reviewed by David Levin.
3203
3204         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
3205         https://bugs.webkit.org/show_bug.cgi?id=27491
3206
3207         The test path determination logic is changed to handle websocket and websocket/ssl cases.
3208         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
3209
3210         Functions to start or stop Web Socket servers are added.
3211
3212         * Scripts/run-webkit-tests:
3213
3214 2009-11-03  Eric Seidel  <eric@webkit.org>
3215
3216         No review, just changing wording of log message.
3217
3218         Change log string to say "failed" instead of "rejected"
3219         when a commit fails due to an out of date checkout.
3220         This makes grepping the commit-queue log for rejected patches easier.
3221
3222         * Scripts/bugzilla-tool:
3223
3224 2009-11-03  Eric Seidel  <eric@webkit.org>
3225
3226         No review, adding commonly known committers missing from the file.
3227
3228         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
3229
3230 2009-11-03  Eric Seidel  <eric@webkit.org>
3231
3232         No review, just sort-order cleanup.
3233
3234         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
3235
3236 2009-11-03  Stephen White  <senorblanco@chromium.org>
3237
3238         (Unreviewed).
3239
3240         Add myself to committers.py.
3241
3242         * Scripts/modules/committers.py:
3243
3244 2009-11-03  Robin Dunn  <robin@alldunn.com>
3245
3246         Reviewed by Kevin Ollviier.
3247
3248         Add packaging scripts for Debian-based Linux distros.
3249         
3250         https://bugs.webkit.org/show_bug.cgi?id=31075
3251
3252         * wx/packaging/build-debian-installer.py: Added.
3253         * wx/packaging/debian: Added.
3254
3255 2009-11-03  Dan Bernstein  <mitz@apple.com>
3256
3257         Reviewed by Anders Carlsson and Beth Dakin.
3258
3259         https://bugs.webkit.org/show_bug.cgi?id=31070
3260
3261         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
3262         destroyed, it executes the value of the 'ondestroy' parameter as a
3263         script.
3264
3265         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3266         (pluginAllocate): Initialize onDestroy.
3267         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
3268         onDestroy.
3269         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3270         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
3271         specified.
3272         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
3273
3274 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3275
3276         Reviewed by Xan Lopez.
3277
3278         https://bugs.webkit.org/show_bug.cgi?id=31035
3279         [GTK] some accessibility tests hitting assertion in debug builds
3280
3281         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
3282
3283         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3284         (AccessibilityController::rootElement):
3285
3286 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
3287
3288         Reviewed by Beth Dakin.
3289
3290         Support ARIA "tab" roles
3291         https://bugs.webkit.org/show_bug.cgi?id=30842
3292
3293         * DumpRenderTree/AccessibilityUIElement.cpp:
3294         * DumpRenderTree/AccessibilityUIElement.h:
3295         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3296         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3297         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3298
3299 2009-11-01  Eric Seidel  <eric@webkit.org>
3300
3301         Reviewed by David Levin.
3302
3303         buildbots should use --exit-after-N-failures
3304         https://bugs.webkit.org/show_bug.cgi?id=30809
3305
3306         Make the bots exit after 20 failures to prevent never-ending
3307         test runs where every test spends a minute crashing.
3308
3309         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3310
3311 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3312
3313         Reviewed by Eric Seidel.
3314
3315         Turn on warnings for QtWebKit for gcc
3316         https://bugs.webkit.org/show_bug.cgi?id=30958
3317
3318         * DumpRenderTree/qt/main.cpp: 
3319         (crashHandler): Mark function NO_RETURN
3320
3321 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
3322
3323         Adding myself to the committers list.
3324
3325         * Scripts/modules/committers.py:
3326
3327 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
3328
3329         Fix an issue that Adam noticed in DRT.
3330
3331         Reviewed by Darin Adler.
3332
3333         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3334         (AccessibilityUIElement::role):
3335         Get the length of the role text, and create a buffer dynamically.
3336
3337 2009-10-30  Eric Seidel  <eric@webkit.org>
3338
3339         No review, rolling out r50105.
3340         http://trac.webkit.org/changeset/50105
3341
3342         This commit was causing:
3343         https://bugs.webkit.org/show_bug.cgi?id=30869
3344         We'll re-implement the feature a different way.
3345
3346         * Scripts/bugzilla-tool:
3347
3348 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3349
3350         Test for MSAA: Accessibility of headings is not correct
3351
3352         https://bugs.webkit.org/show_bug.cgi?id=30937
3353
3354         Reviewed by Adam Roben.
3355
3356         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3357         (AccessibilityUIElement::role):
3358         Allow the role returned to be a BSTR.
3359         (AccessibilityUIElement::description):
3360         Fix a copy/paste error.
3361
3362 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3363
3364         Test for MSAA: Accessibility of links is wrong
3365
3366         https://bugs.webkit.org/show_bug.cgi?id=30928
3367
3368         Reviewed by Darin Adler.
3369
3370         * DumpRenderTree/AccessibilityUIElement.cpp:
3371         (getAccessibilityValueCallback):
3372         Return the accessibility value.
3373         (AccessibilityUIElement::getJSClass):
3374         Added "accessibilityValue" value.
3375
3376         * DumpRenderTree/AccessibilityUIElement.h:
3377
3378         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3379         (AccessibilityUIElement::accessibilityValue):
3380         Stubbed.
3381
3382         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3383         (AccessibilityUIElement::accessibilityValue):
3384         Stubbed.
3385
3386         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3387         (AccessibilityUIElement::accessibilityValue):
3388         Get the object's value, and return it as a JS string.
3389
3390 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
3391
3392         Fix typo in command name used by wx build system.
3393
3394         * wx/build/build_utils.py:
3395
3396 2009-10-30  Adam Barth  <abarth@webkit.org>
3397
3398         Reviewed by Darin Adler.
3399
3400         Patch v1 is a dumb default name for patches
3401         https://bugs.webkit.org/show_bug.cgi?id=30952
3402
3403         Let's use "Patch" instead.
3404
3405         * Scripts/bugzilla-tool:
3406
3407 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3408
3409         Unreviewed trivial buildfix.
3410
3411         [Qt] Buildfix for r50333.
3412
3413         * DumpRenderTree/qt/DumpRenderTree.pro:
3414
3415 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
3416
3417         Reviewed by Holger Freyther.
3418
3419         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
3420         https://bugs.webkit.org/show_bug.cgi?id=30953
3421
3422         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
3423         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
3424         makes qt DRT to share this implementation (as gtk and mac ports do).
3425
3426         * DumpRenderTree/qt/DumpRenderTree.pro:
3427         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
3428         * DumpRenderTree/qt/WorkQueue.h: Removed.
3429
3430 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3431
3432         Unreviewed potential buildbot fix.
3433
3434         Second try: Reset page history before running each test.
3435
3436         Apparently the QWebHistory::clear() keeps the current page
3437         in history which is not what we want, so we not additionally
3438         sets the history capacity to 0 (forces removing everything)
3439         and then sets it back to its original value.
3440
3441         * DumpRenderTree/qt/DumpRenderTree.cpp:
3442         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3443
3444 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3445
3446         Unreviewed potential buildbot fix.
3447
3448         Reset page history before running each test.
3449
3450         * DumpRenderTree/qt/DumpRenderTree.cpp:
3451         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3452
3453 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
3454
3455         Reviewed by Eric Seidel.
3456
3457         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
3458
3459         Bug 28420 -  Implement HTML5 <ruby> rendering
3460         (https://bugs.webkit.org/show_bug.cgi?id=28420)
3461
3462         No new tests (no functional change).
3463
3464         * Scripts/build-webkit:
3465
3466 2009-10-29  Dan Bernstein  <mitz@apple.com>
3467
3468         Reviewed by Mark Rowe.
3469
3470         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
3471         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
3472         define it.
3473
3474         * Scripts/VCSUtils.pm:
3475         * Scripts/svn-apply:
3476         * Scripts/svn-unapply:
3477
3478 2009-10-29  Xan Lopez  <xlopez@igalia.com>
3479
3480         Reviewed by Gustavo Noronha.
3481
3482         Use the GTK+ main loop instead of rolling our own mini-version of
3483         it.
3484
3485         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3486         (dump):
3487         (runTest):
3488         (webViewLoadFinished):
3489
3490 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3491
3492         Reviewed by Oliver Hunt.
3493
3494         Implement the Qt version of DRT dumpBackForwardList().
3495
3496         * DumpRenderTree/qt/DumpRenderTree.cpp:
3497         (WebCore::dumpHistoryItem):
3498         (WebCore::DumpRenderTree::dumpBackForwardList):
3499
3500 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3501
3502         Reviewed by Adam Roben.
3503
3504         Implement DRT functionality for Qt introduced in
3505         r28690 and r28705.
3506
3507         - Implemented pathToLocalResource which exposes the functionality of
3508         converting a given unix path to the correct location on Windows.
3509         - Implemented a way to remove machine-dependent information from paths
3510         in layout test results.
3511
3512         * DumpRenderTree/qt/DumpRenderTree.cpp:
3513         (WebCore::urlSuitableForTestResult):
3514         (WebCore::WebPage::javaScriptConsoleMessage):
3515         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3516         (LayoutTestController::pathToLocalResource):
3517         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3518
3519 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
3520
3521         Adding myself to the committers list.
3522
3523         * Scripts/modules/committers.py:
3524
3525 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
3526
3527         Adding myself to the committers list.
3528
3529         * Scripts/modules/committers.py:
3530
3531 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3532
3533         Reviewed by Jan Alonzo.
3534
3535         [GTK] API to start inspector for a WebView
3536         https://bugs.webkit.org/show_bug.cgi?id=22551
3537
3538         Use the new inspector API to implement the LayoutTestController
3539         interfaces used to test the inspector.
3540
3541         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3542         (webInspectorInspectWebView):
3543         (createWebView):
3544         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3545         (LayoutTestController::showWebInspector):
3546         (LayoutTestController::closeWebInspector):
3547         (LayoutTestController::evaluateInWebInspector):
3548
3549 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
3550
3551         Reviewed by Eric Seidel.
3552
3553         [Qt] WebFrame::counterValueForElementById must not be exposed
3554         https://bugs.webkit.org/show_bug.cgi?id=30882
3555
3556         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3557         (LayoutTestController::counterValueForElementById):
3558
3559 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3560
3561         Rubberstamped by Oliver Hunt.
3562
3563         Fix the warning:
3564
3565         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
3566         declared with attribute warn_unused_result".
3567
3568         by actually checking the result. In the case it is null, an
3569         error has occoured, so treat it as the other fatal errors.
3570
3571         * DumpRenderTree/qt/DumpRenderTree.cpp:
3572         (WebCore::DumpRenderTree::initializeFonts):
3573
3574 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
3575
3576         Reviewed by Darin Adler.
3577
3578         Provide a way to get counter values with layoutTestContoller
3579         https://bugs.webkit.org/show_bug.cgi?id=30555
3580
3581         Define layoutTestContoller.counterValueForElementById.
3582
3583         * DumpRenderTree/LayoutTestController.cpp:
3584         (counterValueForElementByIdCallback):
3585         (LayoutTestController::staticFunctions):
3586         * DumpRenderTree/LayoutTestController.h:
3587         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3588         (LayoutTestController::counterValueForElementById):
3589
3590 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3591
3592         Rubberstamped by Oliver Hunt.
3593
3594         Change two methods to be internal for DRT use only.
3595
3596         Part of [Qt] Review all new API in Qt 4.6
3597         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
3598
3599         * DumpRenderTree/qt/DumpRenderTree.cpp:
3600         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3601         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3602         (LayoutTestController::whiteListAccessFromOrigin):
3603
3604 2009-10-27  Eric Seidel  <eric@webkit.org>
3605
3606         Reviewed by Adam Barth.
3607
3608         REGRESSION: svn-apply exits(1) when applying a patch with a file add
3609         https://bugs.webkit.org/show_bug.cgi?id=30826
3610
3611         * Scripts/svn-apply:
3612          - Add () around all system() calls.
3613          - Use the correct system() == 0 or die instead of system() or die
3614          - Add descriptive messages to all die statements.
3615
3616 2009-10-27  Steve Block  <steveblock@google.com>
3617
3618         Reviewed by NOBODY.
3619
3620         Adds steveblock@google.com to list of committers.
3621
3622         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
3623
3624 2009-10-27  Eric Seidel  <eric@webkit.org>
3625
3626         Reviewed by Adam Barth.
3627
3628         svn-apply can exit(0) even on patch failure
3629         https://bugs.webkit.org/show_bug.cgi?id=29622
3630
3631         * Scripts/svn-apply:
3632          - Add a bunch of "or die" statements, hopefully catching all
3633            possible cases where failure could still exit(0).
3634
3635 2009-10-27  Eric Seidel  <eric@webkit.org>
3636
3637         Reviewed by Adam Barth.
3638
3639         svn-* scripts should share code through VCSUtils.pm
3640         https://bugs.webkit.org/show_bug.cgi?id=30791
3641
3642         Just moving code into a shared location.
3643
3644         * Scripts/VCSUtils.pm:
3645         * Scripts/prepare-ChangeLog:
3646         * Scripts/resolve-ChangeLogs:
3647         * Scripts/svn-apply:
3648         * Scripts/svn-create-patch:
3649         * Scripts/svn-unapply:
3650         * Scripts/update-webkit:
3651
3652 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
3653
3654         Suppress a huge number of MSVC warnings when building wxWebKit.
3655
3656         * wx/build/settings.py:
3657
3658 2009-10-26  Eric Seidel  <eric@webkit.org>
3659
3660         No review, just adding Mike Belshe to the committers list.
3661
3662         * Scripts/modules/committers.py:
3663
3664 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3665
3666         Reviewed by Darin Adler.
3667
3668         Make .rc files compile on Windows without depending on MFC headers
3669         https://bugs.webkit.org/show_bug.cgi?id=30750
3670
3671         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
3672         windows.h instead of afxres.h because it exists even when MFC is not 
3673         installed, and is all that's needed here.
3674
3675         * FindSafari/FindSafari.rc: Ditto
3676
3677 2009-10-24  Eric Seidel  <eric@webkit.org>
3678
3679         Reviewed by Adam Barth.
3680
3681         bugzilla-tool post-diff should know how to mark commit-queue=?
3682         https://bugs.webkit.org/show_bug.cgi?id=29202
3683
3684         * Scripts/bugzilla-tool:
3685          - Add --commit-queue option to post-diff, post-commits and create-bug.
3686         * Scripts/modules/bugzilla.py:
3687          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
3688          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
3689
3690 2009-10-23  Eric Seidel  <eric@webkit.org>
3691
3692         Reviewed by Adam Barth.
3693
3694         bugzilla-tool commit-queue does not notice modifications to committers.py
3695         https://bugs.webkit.org/show_bug.cgi?id=30084
3696
3697         * Scripts/bugzilla-tool:
3698          - Make commit-queue re-exec itself instead of using while(1).
3699          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
3700          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
3701
3702 2009-10-22  Eric Seidel  <eric@webkit.org>
3703
3704         Reviewed by Adam Barth.
3705
3706         commit-queue will get stuck on patches if land-patches terminates unexpectedly
3707         https://bugs.webkit.org/show_bug.cgi?id=30634
3708
3709         * Scripts/bugzilla-tool:
3710          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
3711          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
3712
3713 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
3714
3715         Reviewed by Eric Seidel.
3716
3717         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
3718
3719         https://bugs.webkit.org/show_bug.cgi?id=30763
3720
3721         * pywebsocket/mod_pywebsocket/__init__.py:
3722         * pywebsocket/mod_pywebsocket/dispatch.py:
3723         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
3724         * pywebsocket/mod_pywebsocket/standalone.py:
3725         * pywebsocket/setup.py:
3726         * pywebsocket/test/test_dispatch.py:
3727
3728 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
3729
3730         Reviewed by David Levin.
3731
3732         REGRESSION: 2 failures in run-webkit-unittests
3733         https://bugs.webkit.org/show_bug.cgi?id=30645
3734
3735         * Scripts/modules/cpp_style_unittest.py:
3736         Fixed a few test scenarios which apparently lost some spaces from 
3737         text literals.
3738
3739 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
3740
3741         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
3742
3743         * Scripts/webkitdirs.pm:
3744
3745 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
3746
3747         Reviewed by Darin Adler.
3748
3749         Unification of using null device in perl scripts.
3750         https://bugs.webkit.org/show_bug.cgi?id=30572
3751
3752         * Scripts/VCSUtils.pm:
3753         * Scripts/bisect-builds:
3754         * Scripts/resolve-ChangeLogs:
3755         * Scripts/run-iexploder-tests:
3756         * Scripts/run-jsc:
3757         * Scripts/run-mangleme-tests:
3758         * Scripts/run-webkit-tests:
3759         * Scripts/webkitdirs.pm:
3760         Using File::Spec->devnull() instead of hard coded /dev/null.
3761
3762 2009-10-26  Eric Seidel  <eric@webkit.org>
3763
3764         Reviewed by Holger Freyther.
3765
3766         Reviewers are missing from committers.py
3767         https://bugs.webkit.org/show_bug.cgi?id=30733
3768
3769         * Scripts/modules/committers.py:
3770
3771 2009-10-23  Eric Seidel  <eric@webkit.org>
3772
3773         No review, only adding Alice to the list of reviewers.
3774
3775         * Scripts/modules/committers.py:
3776
3777 2009-10-23  Eric Seidel  <eric@webkit.org>
3778
3779         Reviewed by Eric Carlson.
3780
3781         fast/media/mq-transform-02.html failed on Leopard Commit Bot
3782         https://bugs.webkit.org/show_bug.cgi?id=30700
3783
3784         * DumpRenderTree/mac/DumpRenderTree.mm:
3785         (resetDefaultsToConsistentValues): Update QuickTime version check.
3786
3787 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
3788
3789         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
3790         character measurement APIs that are private on Tiger.
3791
3792         * wx/build/settings.py:
3793
3794 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3795
3796         Reviewed by NOBODY (build fix).
3797         Build fix following bug #30696.
3798
3799         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3800         (LayoutTestController::evaluateScriptInIsolatedWorld):
3801
3802 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3803
3804         Reviewed by Sam Weinig & Geoff Garen.
3805
3806         https://bugs.webkit.org/show_bug.cgi?id=30696
3807         Enable isolated-worlds tests on mac.
3808
3809         Add private interface for DRT to invoke execution in a given world.
3810
3811         * DumpRenderTree/LayoutTestController.cpp:
3812         (evaluateScriptInIsolatedWorldCallback):
3813         (LayoutTestController::staticFunctions):
3814         * DumpRenderTree/LayoutTestController.h:
3815         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3816         (LayoutTestController::evaluateScriptInIsolatedWorld):
3817         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3818         (LayoutTestController::evaluateScriptInIsolatedWorld):
3819
3820 2009-10-21  Eric Seidel  <eric@webkit.org>
3821
3822         Reviewed by Adam Barth.
3823
3824         bugzilla-tool's "patch failed to download an apply" error should give more information
3825         https://bugs.webkit.org/show_bug.cgi?id=30632
3826
3827         * Scripts/modules/scm.py:
3828          - Use the common run_command method instead of custom POpen code.
3829          - Make run_command know how to take pipes as input.
3830         * Scripts/modules/scm_unittest.py:
3831          - Add new tests to cover change.
3832          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
3833
3834 2009-10-21  Kent Tamura  <tkent@chromium.org>
3835
3836         Unreviewed.  Adding myself to the committers list.
3837
3838         * Scripts/modules/committers.py:
3839
3840 2009-10-21  Robin Dunn  <robin@alldunn.com>
3841
3842         Reviewed by Kevin Ollivier.
3843
3844         Update the Windows installer builder to work with Vista / Win 7 and with git.
3845         
3846         https://bugs.webkit.org/show_bug.cgi?id=30649
3847
3848         * wx/build/build_utils.py:
3849         * wx/packaging/build-mac-installer.py:
3850         * wx/packaging/build-win-installer.py:
3851         * wx/packaging/wxWebKitInstaller.iss.in:
3852
3853 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3854
3855         Reviewed by Gustavo Noronha.
3856
3857         [GTK] Added conditional code to avoid using
3858         gdk_window_get_root_coords if we do not have a gtk+ release newer
3859         than 2.17.3.
3860         https://bugs.webkit.org/show_bug.cgi?id=30636
3861
3862         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3863
3864 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3865
3866         Reviewed by Eric Seidel.
3867
3868         [Qt] Added dummy implementation for keepWebHistory()
3869         https://bugs.webkit.org/show_bug.cgi?id=30592
3870
3871         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3872         (LayoutTestController::keepWebHistory):
3873         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3874
3875 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3876
3877         Reviewed by Xan Lopez.
3878
3879         [GTK] Fixed the double click condition, it is not double click if
3880         we move in just in one direction.
3881         https://bugs.webkit.org/show_bug.cgi?id=30636
3882
3883         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3884
3885 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3886
3887         Reviewed by Xan Lopez.
3888
3889         [GTK] Initialize the events completly before emitting them.
3890         https://bugs.webkit.org/show_bug.cgi?id=30633
3891
3892         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3893
3894 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3895
3896         wx build fix. Fix for when linking using --as-needed with gcc.
3897
3898         * wx/browser/wscript:
3899
3900 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3901
3902         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3903         to support all the features used by CURL backend.
3904         
3905         * wx/build/settings.py:
3906         * wx/install-unix-extras:
3907
3908 2009-10-20  Anton Muhin  <antonm@chromium.org>
3909
3910         Reviewed by Adam Barth.
3911
3912         Add {ager,antonm,yurys}@chromium.org into committers.py
3913         https://bugs.webkit.org/show_bug.cgi?id=30560
3914
3915         * Scripts/modules/committers.py:
3916
3917 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3918
3919         Reviewed by Tor Arne Vestbø.
3920
3921         Make the Netscape Test plugin available to the Qt launcher.
3922
3923         * Scripts/run-launcher:
3924
3925 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3926
3927         Reviewed by David Levin.
3928
3929         Removed WebSocket runtime settings.
3930         https://bugs.webkit.org/show_bug.cgi?id=29896
3931
3932         WebSocket runtime configuration is supported by chromium/v8 only.
3933
3934         * DumpRenderTree/mac/DumpRenderTree.mm:
3935         (resetDefaultsToConsistentValues):
3936         * DumpRenderTree/win/DumpRenderTree.cpp:
3937         (resetDefaultsToConsistentValues):
3938
3939 2009-10-19  Nate Chapin  <japhet@chromium.org>
3940
3941         Reviewed by Adam Barth.
3942
3943         Add testFail() to test plugin so we can test our handling of a
3944         plugin invoke call returning false.
3945
3946         https://bugs.webkit.org/show_bug.cgi?id=30239
3947
3948         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3949         (pluginInvoke):
3950         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3951
3952 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3953
3954         Reviewed by Gustavo Noronha.
3955
3956         Enable DOM pasting when running layout tests.
3957
3958         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3959         (resetDefaultsToConsistentValues):
3960
3961 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3962
3963         Reviewed by Simon Hausmann.
3964
3965         Use the setPreferredContentsSize method instead
3966         of setFixedContentsSize, as the method has been renamed.
3967
3968         * DumpRenderTree/qt/DumpRenderTree.cpp:
3969         (WebCore::DumpRenderTree::open):
3970         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3971         (LayoutTestController::setFixedContentsSize):
3972
3973 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3974
3975         Reviewed by Dan Bernstein.
3976
3977         https://bugs.webkit.org/show_bug.cgi?id=30456
3978         Fixes for new Debug_All Windows build configuration.
3979
3980         * DumpRenderTree/win/DumpRenderTree.cpp:
3981         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3982         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3983
3984 2009-10-16  Eric Seidel  <eric@webkit.org>
3985
3986         Reviewed by Adam Barth.
3987
3988         commit-queue status bot should list which buildbot is blocking the queue
3989         https://bugs.webkit.org/show_bug.cgi?id=30452
3990
3991         Add new methods and testing.
3992
3993         * Scripts/bugzilla-tool:
3994         * Scripts/modules/buildbot.py:
3995         * Scripts/modules/buildbot_unittest.py:
3996
3997 2009-10-16  Eric Seidel  <eric@webkit.org>
3998
3999         Reviewed by Adam Barth.
4000
4001         run-webkit-tests fails when CWD is not inside a WebKit checkout
4002         https://bugs.webkit.org/show_bug.cgi?id=30451
4003
4004         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
4005         * Scripts/modules/scm_unittest.py:
4006           - Remove use of original_path (we don't need to restore the CWD).
4007           - Don't use '.' to find the webkit checkout, use __file__ instead.
4008
4009 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
4010
4011         Reviewed by Adam Roben.
4012
4013         Add a Debug_All configuration to build entire stack as debug.
4014         Change Debug_Internal to:
4015         - stop using _debug suffix for all WebKit/Safari binaries
4016         - not use _debug as a DLL naming suffix
4017         - use non-debug C runtime lib.
4018
4019         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
4020         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
4021         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
4022         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
4023         Add missing debug.vsprops inherited property sheet.
4024         Add Debug_All configuration.
4025         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
4026         * WinLauncher/WinLauncher.vcproj:
4027         Removed extraneous definitions inherited from vsprops.
4028         Add Debug_All configuration.
4029
4030 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
4031
4032         Reviewed by David Levin.
4033
4034         check-webkit-style is wrong about indent checking in namespaces
4035         in header files and a few other things
4036         https://bugs.webkit.org/show_bug.cgi?id=30362
4037
4038         The few other things include:
4039         + check-webkit-style does not require spaces around the equal sign
4040           inside 'if' statements and around binary operators that take 
4041           numeric literals.
4042         + check-webkit-style reports false errors for the / operator
4043           when part of a filename in the #include directive.
4044
4045         * Scripts/modules/cpp_style.py:
4046         Improved indentation checking and space checking around
4047         binary operators. While the checks are still not perfect,
4048         they are clearly better than before.
4049         * Scripts/modules/cpp_style_unittest.py:
4050         Added test cases for the newly supported checks and modified old
4051         test cases to match the new guidelines
4052
4053 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
4054
4055         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
4056
4057         * wx/build/settings.py:
4058
4059 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
4060
4061         Reviewed by David Levin.
4062
4063         Add mod_pywebsocket to test Web Sockets.
4064         http://code.google.com/p/pywebsocket/
4065         https://bugs.webkit.org/show_bug.cgi?id=27490
4066
4067         * pywebsocket/COPYING: Added.
4068         * pywebsocket/MANIFEST.in: Added.
4069         * pywebsocket/README: Added.
4070         * pywebsocket/example/echo_client.py: Added.
4071         * pywebsocket/example/echo_wsh.py: Added.
4072         * pywebsocket/mod_pywebsocket/__init__.py: Added.
4073         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
4074         * pywebsocket/mod_pywebsocket/handshake.py: Added.
4075         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
4076         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
4077         * pywebsocket/mod_pywebsocket/standalone.py: Added.
4078         * pywebsocket/mod_pywebsocket/util.py: Added.
4079         * pywebsocket/setup.py: Added.
4080         * pywebsocket/test/config.py: Added.
4081         * pywebsocket/test/mock.py: Added.
4082         * pywebsocket/test/run_all.py: Added.
4083         * pywebsocket/test/test_dispatch.py: Added.
4084         * pywebsocket/test/test_handshake.py: Added.
4085         * pywebsocket/test/test_mock.py: Added.
4086         * pywebsocket/test/test_msgutil.py: Added.
4087         * pywebsocket/test/test_util.py: Added.
4088         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
4089         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
4090         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
4091         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
4092         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
4093         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
4094         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
4095         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
4096
4097 2009-10-15  James Robinson  <jamesr@google.com>
4098
4099         Reviewed by David Levin.
4100
4101         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
4102
4103         https://bugs.webkit.org/show_bug.cgi?id=30426
4104
4105         * Scripts/modules/cpp_style.py:
4106         * Scripts/modules/cpp_style_unittest.py:
4107
4108 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
4109
4110         Reviewed by Adam Roben.
4111
4112         Fixes <http://webkit.org/b/30411>.
4113         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
4114         
4115         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
4116         building Chromium.
4117
4118         * Scripts/pdevenv:
4119
4120 2009-10-15  Robin Dunn  <robin@alldunn.com>
4121
4122         Reviewed by Kevin Ollivier.
4123
4124         Add Mac package building scripts for wx.
4125         
4126         https://bugs.webkit.org/show_bug.cgi?id=30405
4127
4128         * wx/build/build_utils.py:
4129         * wx/build/settings.py:
4130         * wx/packaging/build-mac-installer.py: Added.
4131
4132 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
4133
4134         Reviewed by Gustavo Noronha.
4135
4136         Enable Web Sockets support when running layout tests.
4137
4138         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4139         (resetDefaultsToConsistentValues):
4140
4141 2009-10-15  Xan Lopez  <xlopez@igalia.com>
4142
4143         Reviewed by Gustavo Noronha.
4144
4145         Need to initialize event.button.button, since in most cases a
4146         button number is not passed as an argument.
4147
4148         * DumpRenderTree/gtk/EventSender.cpp:
4149         (mouseDownCallback):
4150         (mouseUpCallback):
4151
4152 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
4153
4154         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
4155         the OS if none was explicitly set.
4156
4157         * wx/build/settings.py:
4158
4159 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
4160
4161         Reviewed by Timothy Hatcher.
4162
4163         Web Inspector: enable developers extras within inspector layout tests.
4164
4165         https://bugs.webkit.org/show_bug.cgi?id=30014
4166
4167         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4168         (LayoutTestController::showWebInspector):
4169         (LayoutTestController::closeWebInspector):
4170         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4171         (LayoutTestController::showWebInspector):
4172         (LayoutTestController::closeWebInspector):
4173
4174 2009-10-14  José Millán Soto  <jmillan@igalia.com>
4175
4176         Reviewed by Jan Alonzo.
4177
4178         GtkLauncher is using a deprecated signal
4179         https://bugs.webkit.org/show_bug.cgi?id=30364
4180
4181         Modified GtkLauncher to use notify::title signal instead of
4182         deprecated title-changed signal
4183
4184         * GtkLauncher/main.c:
4185         (notify_title_cb):
4186         (create_browser):
4187
4188 2009-10-14  Brady Eidson  <beidson@apple.com>
4189
4190         Reviewed by Sam Weinig.
4191
4192         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
4193         1 - Disables WebHistory
4194         2 - Doesn't make sense in that context anyway.
4195
4196         * DumpRenderTree/win/DumpRenderTree.cpp:
4197         (createWebViewAndOffscreenWindow):
4198
4199 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
4200
4201         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
4202         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
4203
4204         * wx/build/settings.py:
4205         * wx/install-unix-extras:
4206
4207 2009-10-14  Brady Eidson  <beidson@apple.com>
4208
4209         Reviewed by Sam Weinig.
4210
4211         WebKit Win API should provide a delegate interface for global history.
4212         https://bugs.webkit.org/show_bug.cgi?id=29905
4213
4214         * DumpRenderTree/LayoutTestController.cpp:
4215         (LayoutTestController::LayoutTestController):
4216         * DumpRenderTree/LayoutTestController.h:
4217         (LayoutTestController::dumpHistoryDelegateCallbacks):
4218         (LayoutTestController::setDumpHistoryDelegateCallbacks):
4219                 
4220         * DumpRenderTree/win/DumpRenderTree.cpp:
4221         (shouldLogHistoryDelegates):
4222         (runTest):
4223         (createWebViewAndOffscreenWindow):
4224         (main):
4225         * DumpRenderTree/win/DumpRenderTree.vcproj:
4226         
4227         Add the IWebHistoryDelegate to DRT Windows:
4228         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
4229         (wstringFromBSTR):
4230         (HistoryDelegate::HistoryDelegate):
4231         (HistoryDelegate::~HistoryDelegate):
4232         (HistoryDelegate::QueryInterface):
4233         (HistoryDelegate::AddRef):
4234         (HistoryDelegate::Release):
4235         (HistoryDelegate::didNavigateWithNavigationData):
4236         (HistoryDelegate::didPerformClientRedirectFromURL):
4237         (HistoryDelegate::didPerformServerRedirectFromURL):
4238         (HistoryDelegate::updateHistoryTitle):
4239         (HistoryDelegate::populateVisitedLinksForWebView):
4240         * DumpRenderTree/win/HistoryDelegate.h: Added.
4241
4242         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4243         (LayoutTestController::removeAllVisitedLinks):
4244
4245 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
4246
4247         Reviewed by Simon Hausmann.
4248
4249         [Qt] Implement support for setPOSIXLocale on Qt.
4250         https://bugs.webkit.org/show_bug.cgi?id=30268 
4251  
4252         * DumpRenderTree/qt/DumpRenderTree.cpp:
4253         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4254         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4255         (LayoutTestController::setPOSIXLocale):
4256         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4257
4258 2009-10-13  Stephanie Lewis  <slewis@apple.com>
4259
4260         Unreviewed, adding myself to reviewers list.
4261
4262         * Scripts/modules/committers.py:
4263
4264 2009-10-13  Stephanie Lewis  <slewis@apple.com>
4265
4266         Reviewed by Mark Rowe.
4267
4268         Fix null assignment so root tests work again.
4269
4270         * Scripts/webkitdirs.pm:
4271
4272 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
4273
4274         Reviewed by Simon Hausmann.
4275
4276         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
4277         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
4278         This is done in preparation of implementing missing features in DRT.
4279         No functionality changes made yet.
4280
4281         * DumpRenderTree/qt/DumpRenderTree.cpp:
4282         * DumpRenderTree/qt/DumpRenderTree.pro:
4283         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
4284         (EventSender::EventSender):
4285         (EventSender::mouseDown):
4286         (EventSender::mouseUp):
4287         (EventSender::mouseMoveTo):
4288         (EventSender::leapForward):
4289         (EventSender::keyDown):
4290         (EventSender::contextClick):
4291         (EventSender::scheduleAsynchronousClick):
4292         (EventSender::frameUnderMouse):
4293         * DumpRenderTree/qt/EventSenderQt.h: Added.
4294         (EventSender::clearKillRing):
4295         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
4296         (LayoutTestController::LayoutTestController):
4297         (LayoutTestController::reset):
4298         (LayoutTestController::processWork):
4299         (LayoutTestController::maybeDump):
4300         (LayoutTestController::waitUntilDone):
4301         (LayoutTestController::notifyDone):
4302         (LayoutTestController::windowCount):
4303         (LayoutTestController::clearBackForwardList):
4304         (LayoutTestController::dumpEditingCallbacks):
4305         (LayoutTestController::dumpResourceLoadCallbacks):
4306         (LayoutTestController::queueBackNavigation):
4307         (LayoutTestController::queueForwardNavigation):
4308         (LayoutTestController::queueLoad):
4309         (LayoutTestController::queueReload):
4310         (LayoutTestController::queueScript):
4311         (LayoutTestController::provisionalLoad):
4312         (LayoutTestController::timerEvent):
4313         (LayoutTestController::encodeHostName):
4314         (LayoutTestController::decodeHostName):
4315         (LayoutTestController::setJavaScriptProfilingEnabled):
4316         (LayoutTestController::setFixedContentsSize):
4317         (LayoutTestController::setPrivateBrowsingEnabled):
4318         (LayoutTestController::setPopupBlockingEnabled):
4319         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
4320         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
4321         (LayoutTestController::numberOfActiveAnimations):
4322         (LayoutTestController::disableImageLoading):
4323         (LayoutTestController::dispatchPendingLoadRequests):
4324         (LayoutTestController::setDatabaseQuota):
4325         (LayoutTestController::clearAllDatabases):
4326         (LayoutTestController::whiteListAccessFromOrigin):
4327         (LayoutTestController::waitForPolicyDelegate):
4328         (LayoutTestController::overridePreference):
4329         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
4330         (LayoutTestController::isLoading):
4331         (LayoutTestController::setLoading):
4332         (LayoutTestController::shouldDumpAsText):
4333         (LayoutTestController::shouldDumpBackForwardList):
4334         (LayoutTestController::shouldDumpChildrenAsText):
4335         (LayoutTestController::shouldDumpDatabaseCallbacks):
4336         (LayoutTestController::shouldDumpStatusCallbacks):
4337         (LayoutTestController::shouldWaitUntilDone):
4338         (LayoutTestController::canOpenWindows):
4339         (LayoutTestController::shouldDumpTitleChanges):
4340         (LayoutTestController::waitForPolicy):
4341         (LayoutTestController::dumpAsText):
4342         (LayoutTestController::dumpChildFramesAsText):
4343         (LayoutTestController::dumpDatabaseCallbacks):
4344         (LayoutTestController::dumpStatusCallbacks):
4345         (LayoutTestController::setCanOpenWindows):
4346         (LayoutTestController::dumpBackForwardList):
4347         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
4348         (LayoutTestController::display):
4349         (LayoutTestController::dumpTitleChanges):
4350         (LayoutTestController::dumpSelectionRect):
4351         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
4352         (TextInputController::TextInputController):
4353         (TextInputController::doCommand):
4354         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
4355         * DumpRenderTree/qt/WorkQueue.cpp:
4356         * DumpRenderTree/qt/WorkQueue.h:
4357         * DumpRenderTree/qt/WorkQueueItem.h:
4358         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
4359         (findFrameNamed):
4360         (LoadItem::invoke):
4361         (ReloadItem::invoke):
4362         (ScriptItem::invoke):
4363         (BackForwardItem::invoke):