b1d20897bd983d2c41060e1c9fadf6882a6b09a0
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-19  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         Support Qt port in bugzilla-tool
6         https://bugs.webkit.org/show_bug.cgi?id=31701
7
8         Now we support building with Qt!
9
10         * Scripts/bugzilla-tool:
11         * Scripts/modules/webkitport.py: Added.
12         * Scripts/modules/webkitport_unittest.py: Added.
13         * Scripts/run-webkit-unittests:
14
15 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
16
17         Reviewed by Adam Barth.
18
19         Remove inserting stderr into patch in bugzilla-tool
20         https://bugs.webkit.org/show_bug.cgi?id=29914
21
22         Modify SCM python module's run_command function to avoid return of stderr
23         by default, so stderr won't be inserted into the patches.
24         Modify the related unit test.
25
26         * Scripts/modules/scm.py:
27         * Scripts/modules/scm_unittest.py:
28
29 2009-11-19  Eric Seidel  <eric@webkit.org>
30
31         Reviewed by Adam Barth.
32
33         bugzilla-tool needs per-command help
34         https://bugs.webkit.org/show_bug.cgi?id=31697
35
36         Added support for "bugzilla-tool help command-name"
37         and a unit test to make sure it works.
38
39         * Scripts/modules/multicommandtool.py:
40         * Scripts/modules/multicommandtool_unittest.py:
41
42 2009-11-19  Eric Seidel  <eric@webkit.org>
43
44         Reviewed by Adam Barth.
45
46         Move MultiCommandTool and Command into a separate file and add some basic unit tests
47         https://bugs.webkit.org/show_bug.cgi?id=31695
48
49         * Scripts/bugzilla-tool:
50         * Scripts/modules/multicommandtool.py: Added.
51         * Scripts/modules/multicommandtool_unittest.py: Added.
52         * Scripts/run-webkit-unittests:
53
54 2009-11-19  Eric Seidel  <eric@webkit.org>
55
56         No review, just adding a FIXME.
57
58         Split out command parsing and help printing from BugzillaTool
59         https://bugs.webkit.org/show_bug.cgi?id=31688
60
61         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
62
63 2009-11-19  Eric Seidel  <eric@webkit.org>
64
65         Reviewed by Adam Barth.
66
67         Split out command parsing and help printing from BugzillaTool
68         https://bugs.webkit.org/show_bug.cgi?id=31688
69
70         * Scripts/bugzilla-tool:
71          - Add new MultiCommandTool class to contain option parsing and help printing logic.
72          - Rename private methods to use _ pattern.
73          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
74          - 
75
76 2009-11-19  Eric Seidel  <eric@webkit.org>
77
78         Reviewed by Adam Barth.
79
80         Re-factor help printing to use modern python idioms
81         https://bugs.webkit.org/show_bug.cgi?id=31685
82
83         * Scripts/bugzilla-tool:
84
85 2009-11-19  Eric Seidel  <eric@webkit.org>
86
87         Reviewed by Darin Adler.
88
89         commit-queue empty queue logs twice
90         https://bugs.webkit.org/show_bug.cgi?id=31679
91
92         * Scripts/bugzilla-tool:
93
94 2009-11-19  Eric Seidel  <eric@webkit.org>
95
96         Reviewed by Darin Adler.
97
98         bugzilla-tool's reviewer/committer rejection message should be clearer
99         https://bugs.webkit.org/show_bug.cgi?id=31126
100
101         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
102
103         * Scripts/modules/bugzilla.py:
104
105 2009-11-19  Eric Z. Ayers  <zundel@google.com>
106
107         Reviewed by Pavel Feldman.
108
109         Forces a WM_PAINT event on calling layoutTestController.display()
110         in order to enable the timeline-paint.html test on Windows.
111         ::UpdateWindow() does not force an event becaue the window is 
112         not visible.
113
114         https://bugs.webkit.org/show_bug.cgi?id=31402
115
116         * DumpRenderTree/win/DumpRenderTree.cpp:
117         (displayWebView):
118
119 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
120
121         No review needed.
122
123         Added myself to committers list.
124
125         * Scripts/modules/committers.py:
126
127 2009-11-19  Adam Barth  <abarth@webkit.org>
128
129         Reviewed by Eric Seidel.
130
131         Bugzilla-tool command classes should match command names
132         https://bugs.webkit.org/show_bug.cgi?id=31666
133
134         I renamed all the commands except CommitMessageForCurrentDiff because
135         the new name would conflict with an existing class.
136
137         * Scripts/bugzilla-tool:
138
139 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
140
141         Reviewed by Gustavo Noronha Silva.
142
143         Web Inspector: Implement "show inspector" in WebKit GTK
144         API and enable console tests.
145
146         https://bugs.webkit.org/show_bug.cgi?id=31669
147
148         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
149         (LayoutTestController::showWebInspector):
150
151 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
152
153         Reviewed by Simon Hausmann.
154
155         Minor refactoring + more documentation.
156
157         * DumpRenderTree/qt/DumpRenderTree.cpp:
158         (WebCore::clearHistory):
159         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
160
161 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
162
163         Reviewed by Eric Seidel.
164
165         Ignore websocket tests when --no-http is specified.
166         https://bugs.webkit.org/show_bug.cgi?id=31662
167
168         * Scripts/run-webkit-tests:
169
170 2009-11-18  Adam Barth  <abarth@webkit.org>
171
172         Reviewed by Eric Seidel.
173
174         Normalize ' and " in bugzilla-tool
175         https://bugs.webkit.org/show_bug.cgi?id=31655
176
177         We decided " is better than ' and we should be consistent.
178
179         * Scripts/bugzilla-tool:
180
181 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
182
183         Reviewed by Kenneth Rohde Christiansen.
184
185         [Qt] Remove support for Qt v4.3 or older versions
186         https://bugs.webkit.org/show_bug.cgi?id=29469
187
188         * DumpRenderTree/qt/DumpRenderTree.pro:
189         * DumpRenderTree/qt/ImageDiff.pro:
190
191 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
192
193         Reviewed by Eric Seidel.
194
195         GitTest.test_create_binary_patch fails if /tmp is symlink
196         https://bugs.webkit.org/show_bug.cgi?id=31536
197
198         * Scripts/modules/scm_unittest.py:
199
200 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
201
202         Reviewed by Darin Adler.
203
204         Configuration for Chromium Build Slaves.
205
206         https://bugs.webkit.org/show_bug.cgi?id=31442
207
208         * BuildSlaveSupport/build.webkit.org-config/config.json:
209         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
210
211 2009-11-18  Eric Seidel  <eric@webkit.org>
212
213         Reviewed by Darin Adler.
214
215         workqueue.py results in totally broken commit-queue UI
216         https://bugs.webkit.org/show_bug.cgi?id=31645
217
218         * Scripts/bugzilla-tool:
219          - Remove unneeded use of PatchCollection.
220          - Grab a new copy of the cq'd patches every run of the queue.
221
222 2009-11-18  Sam Weinig  <sam@webkit.org>
223
224         Reviewed by Anders Carlsson.
225
226         Make the Mac Geolocation API async.
227
228         Update DRT to use the new async Mac Geolocation API.
229
230         * DumpRenderTree/mac/UIDelegate.mm:
231         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
232
233 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
234
235         Reviewed by Kenneth Rohde Christiansen.
236
237         Add and option to toggle HTML5 datalist support to build-webkit
238         https://bugs.webkit.org/show_bug.cgi?id=31599
239
240         * Scripts/build-webkit:
241
242 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
243
244         Reviewed by Kevin Ollivier.
245
246         Enable wx plugin support using the Windows implementation as a base.
247         
248         https://bugs.webkit.org/show_bug.cgi?id=31636
249
250         * wx/build/settings.py:
251
252 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
253
254         Reviewed by Simon Hausmann.
255
256         Change the initialization order so that the controllers
257         will be created before exporting them to the JS DOM window.
258
259         * DumpRenderTree/qt/DumpRenderTree.cpp:
260         (WebCore::DumpRenderTree::DumpRenderTree):
261
262 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
263
264         Reviewed by Simon Hausmann.
265
266         Fix a code copy and paste error. m_page should be page.
267
268         * DumpRenderTree/qt/DumpRenderTree.cpp:
269         (WebCore::DumpRenderTree::createWindow):
270
271 2009-11-17  Mark Rowe  <mrowe@apple.com>
272
273         Reviewed by Alexey Proskuryakov.
274
275         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
276
277         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
278         This prevents symlinks from confusing the descendant check.
279
280 2009-11-17  Mark Rowe  <mrowe@apple.com>
281
282         Reviewed by Alexey Proskuryakov.
283
284         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
285
286         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
287         server to be up rather than having run-webkit-tests abort immediately.
288
289         * Scripts/run-webkit-tests:
290
291 2009-11-17  Eric Seidel  <eric@webkit.org>
292
293         Reviewed by Darin Adler.
294
295         commit-queue is failing to set reviewer in ChangeLogs
296         https://bugs.webkit.org/show_bug.cgi?id=31592
297
298         * Scripts/bugzilla-tool: Clarify the "applying" log message.
299         * Scripts/modules/bugzilla.py:
300          - Add a new _validate_committer_and_reviewer function as a
301            temporary solution until we can make a real Attachment object
302            which knows how to fill in its committer/reviewer fields automatically.
303
304 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
305
306         Unreviewed buildbot fix.
307
308         Revert part of earlier patch and add comment, as it
309         was causing timeouts on the buildbot.
310
311         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
312         (LayoutTestController::notifyDone):
313
314 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
315
316         Reviewed by Oliver Hunt.
317
318         Make the timeout 15 sec as for the other DRT's and make
319         it print out the same output when a test timeout.
320
321         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
322         (LayoutTestController::waitUntilDone):
323         (LayoutTestController::notifyDone):
324         (LayoutTestController::timerEvent):
325
326 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
327
328         Reviewed by Timothy Hatcher.
329
330         Fixed typos in comments.
331
332         * Scripts/modules/committers.py:
333
334 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
335
336         Reviewed by Timothy Hatcher.
337
338         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
339         - Updated DRT to show/close inspector for all tests under /inspector
340         - Introduced LayoutTestController::setTimelineProfilingEnabled and
341           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
342         - Removed reload on each inspector test
343         - Renamed fast/inspector to fast/inspector-support in order not to trigger
344         inspector for those.
345         - Reimplemented timeline tests in order to get rid of reload there.
346         - Moved tests that don't require harness into the fast group.
347
348         https://bugs.webkit.org/show_bug.cgi?id=31472
349
350         * DumpRenderTree/LayoutTestController.cpp:
351         (setTimelineProfilingEnabledCallback):
352         (closeWebInspectorCallback):
353         (LayoutTestController::staticFunctions):
354         * DumpRenderTree/LayoutTestController.h:
355         * DumpRenderTree/gtk/DumpRenderTree.cpp:
356         (shouldOpenWebInspector):
357         (runTest):
358         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
359         (LayoutTestController::setTimelineProfilingEnabled):
360         * DumpRenderTree/mac/DumpRenderTree.mm:
361         (shouldOpenWebInspector):
362         (runTest):
363         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
364         (LayoutTestController::setTimelineProfilingEnabled):
365         * DumpRenderTree/win/DumpRenderTree.cpp:
366         (shouldOpenWebInspector):
367         (runTest):
368         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
369         (LayoutTestController::setTimelineProfilingEnabled):
370
371 2009-11-17  Oliver Hunt  <oliver@apple.com>
372
373         Reviewed by Maciej Stachowiak.
374
375         Incorrect use of JavaScriptCore API in DumpRenderTree
376         https://bugs.webkit.org/show_bug.cgi?id=31577
377
378         Return undefined rather than a literal null.
379
380         * DumpRenderTree/AccessibilityUIElement.cpp:
381         (setSelectedTextRangeCallback):
382         (incrementCallback):
383         (decrementCallback):
384         (showMenuCallback):
385
386 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
387
388         Reviewed by Beth Dakin.
389
390         AX: aria-labelledby duplicates some of its WAI-ARIA label
391         https://bugs.webkit.org/show_bug.cgi?id=31565
392
393         * DumpRenderTree/AccessibilityUIElement.cpp:
394         (titleUIElementCallback):
395         (getIsValidCallback):
396         (AccessibilityUIElement::getJSClass):
397
398 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
399
400         Reviewed by Simon Hausmann.
401
402         r50942 broke output from created windows. Make the
403         m_enableTextOutput a member of the DRT and not the
404         WebPage.
405
406         * DumpRenderTree/qt/DumpRenderTree.cpp:
407         (WebCore::WebPage::WebPage):
408         (WebCore::WebPage::javaScriptAlert):
409         (WebCore::WebPage::javaScriptConsoleMessage):
410         (WebCore::WebPage::javaScriptConfirm):
411         (WebCore::WebPage::javaScriptPrompt):
412         (WebCore::WebPage::acceptNavigationRequest):
413         (WebCore::DumpRenderTree::DumpRenderTree):
414         (WebCore::DumpRenderTree::open):
415         (WebCore::DumpRenderTree::createWindow):
416         * DumpRenderTree/qt/DumpRenderTree.h:
417         (WebCore::DumpRenderTree::setTextOutputEnabled):
418         (WebCore::DumpRenderTree::isTextOutputEnabled):
419         (WebCore::WebPage::shouldInterruptJavaScript):
420         (WebCore::WebPage::isTextOutputEnabled):
421         (WebCore::WebPage::setViewGeometry):
422
423 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
424
425         Reviewed by Gustavo Noronha Silva.
426
427         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
428         as the implementation is being used by at least Qt and Gtk+.
429
430         Update buildsystems as well.
431
432         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
433         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
434         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
435         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
436         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
437         * GNUmakefile.am:
438
439 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
440
441         Reviewed by Alexey Proskuryakov.
442
443         Disable wss until all platforms support pyOpenSSL
444
445         https://bugs.webkit.org/show_bug.cgi?id=31479
446
447         * Scripts/run-webkit-tests:
448
449 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
450
451         Reviewed by Kenneth Christiansen.
452
453         [Qt] Implement load error pages support for Qt's DRT.
454         https://bugs.webkit.org/show_bug.cgi?id=31509
455
456         For now, it will not be a default feature, and layout tests
457         that want to make use of this have to explicitily call
458         'handleErrorPages();' for the test source.
459
460         Any of the other DumpRenderTree's (mac, win and gtk)
461         support handling error pages. Qt's will be the first.
462
463         * DumpRenderTree/qt/DumpRenderTree.cpp:
464         (WebCore::WebPage::supportsExtension):
465         (WebCore::WebPage::extension):
466         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
467         (LayoutTestController::reset):
468         * DumpRenderTree/qt/LayoutTestControllerQt.h:
469         (LayoutTestController::shouldHandleErrorPages):
470         (LayoutTestController::handleErrorPages):
471
472 2009-11-16  Eric Seidel  <eric@webkit.org>
473
474         Reviewed by Adam Barth.
475
476         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
477         https://bugs.webkit.org/show_bug.cgi?id=31549
478
479         Renamed --commit-queue to --non-interactive in most places
480         and remove the code in land-patches which is no longer needed.
481
482         * Scripts/bugzilla-tool:
483
484 2009-11-16  Eric Seidel  <eric@webkit.org>
485
486         Reviewed by Adam Barth.
487
488         The commit-queue should use land-attachment
489         https://bugs.webkit.org/show_bug.cgi?id=31548
490
491         * Scripts/bugzilla-tool:
492
493 2009-11-16  Adam Barth  <abarth@webkit.org>
494
495         Reviewed by Eric Seidel.
496
497         Convert CommitQueue over to PatchCollection
498         https://bugs.webkit.org/show_bug.cgi?id=31547
499
500         Also fixes a bug in workqueue and adds a test!
501
502         * Scripts/bugzilla-tool:
503         * Scripts/modules/workqueue.py:
504         * Scripts/modules/workqueue_unittest.py:
505
506 2009-11-16  Adam Barth  <abarth@webkit.org>
507
508         Reviewed by Eric Seidel.
509
510         Move StyleQueue over to using PatchCollection
511         https://bugs.webkit.org/show_bug.cgi?id=31544
512
513         That's what the class it's for.
514
515         * Scripts/bugzilla-tool:
516         * Scripts/modules/patchcollection.py:
517         * Scripts/modules/patchcollection_unittest.py:
518
519 2009-11-16  Eric Seidel  <eric@webkit.org>
520
521         Reviewed by Adam Barth.
522
523         bugzilla-tool needs a land-attachment command
524         https://bugs.webkit.org/show_bug.cgi?id=31546
525
526         * Scripts/bugzilla-tool:
527          - Move all the logic into AbstractLandingCommand and
528            add a new LandAttachment command subclass.
529          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
530
531 2009-11-16  Eric Seidel  <eric@webkit.org>
532
533         Reviewed by Adam Barth.
534
535         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
536         https://bugs.webkit.org/show_bug.cgi?id=31543
537
538         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
539
540         * Scripts/bugzilla-tool:
541
542 2009-11-16  Eric Seidel  <eric@webkit.org>
543
544         Reviewed by Adam Barth.
545
546         Disable the style queue from posting to the commit queue status page.
547
548         * Scripts/bugzilla-tool:
549
550 2009-11-16  Adam Barth  <abarth@webkit.org>
551
552         Reviewed by Eric Seidel.
553
554         Implement PatchCollection
555         https://bugs.webkit.org/show_bug.cgi?id=31541
556
557         This class holds a set of patches and lets clients iterate through
558         them.  Optionally, clients can install a filter.
559
560         * Scripts/modules/patchcollection.py: Added.
561         * Scripts/modules/patchcollection_unittest.py: Added.
562         * Scripts/run-webkit-unittests:
563
564 2009-11-16  Eric Seidel  <eric@webkit.org>
565
566         Reviewed by Adam Barth.
567
568         bugzilla-tool land-patches will close bugs with patches r=?
569         https://bugs.webkit.org/show_bug.cgi?id=28230
570
571         The commit-queue shouldn't close patches with outstanding reviews on them,
572         even if many reviewers seem to be against multi-patch bugs.
573
574         * Scripts/bugzilla-tool:
575
576 2009-11-16  Eric Seidel  <eric@webkit.org>
577
578         Reviewed by Adam Barth.
579
580         bugzilla-tool check-style should work with attachment ids instead of bug ids
581         https://bugs.webkit.org/show_bug.cgi?id=31540
582
583         * Scripts/bugzilla-tool:
584
585 2009-11-16  Eric Seidel  <eric@webkit.org>
586
587         Reviewed by Adam Barth.
588
589         WorkQueue is the only place that should know about special exit codes
590         https://bugs.webkit.org/show_bug.cgi?id=31534
591
592         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
593         and add tests for handling exit codes.
594         I also cleaned up workqueue_unittest.py more.
595
596         * Scripts/bugzilla-tool:
597         * Scripts/modules/workqueue.py:
598         * Scripts/modules/workqueue_unittest.py:
599
600 2009-11-16  Eric Seidel  <eric@webkit.org>
601
602         Reviewed by Adam Barth.
603
604         Re-factor workqueue_unittest to allow for more than one test.
605         https://bugs.webkit.org/show_bug.cgi?id=31535
606
607         * Scripts/modules/workqueue_unittest.py:
608
609 2009-11-16  Eric Seidel  <eric@webkit.org>
610
611         Reviewed by Adam Barth.
612
613         land-patches needs to be re-factored into smaller chunks
614         https://bugs.webkit.org/show_bug.cgi?id=31532
615
616         * Scripts/bugzilla-tool: fix a couple obvious typos.
617
618 2009-11-16  Eric Seidel  <eric@webkit.org>
619
620         Reviewed by Adam Barth.
621
622         land-patches needs to be re-factored into smaller chunks
623         https://bugs.webkit.org/show_bug.cgi?id=31532
624
625         The next patch will move these methods into WebKitLandingScripts.
626
627         * Scripts/bugzilla-tool:
628          - Split out _land_patch and _close_bug_if_no_active_patches.
629
630 2009-11-16  Adam Barth  <abarth@webkit.org>
631
632         Reviewed by Eric Seidel.
633
634         Fix silly copy-and-paste code.  I am a terrible coder.
635
636         * Scripts/modules/bugzilla.py:
637
638 2009-11-16  Adam Barth  <abarth@webkit.org>
639
640         Reviewed by Eric Seidel.
641
642         Implement a StyleQueue
643         https://bugs.webkit.org/show_bug.cgi?id=31537
644
645         The first iteration of the style queue only produces output locally.
646         There is also a limit of 10 patches because it's not that useful to
647         iterate through the entire review queue at this point.  We can remove
648         the limit later.
649
650         * Scripts/bugzilla-tool:
651         * Scripts/modules/bugzilla.py:
652
653 2009-11-16  Adam Barth  <abarth@webkit.org>
654
655         Reviewed by Eric Seidel.
656
657         Unit test WorkQueue
658         https://bugs.webkit.org/show_bug.cgi?id=31531
659
660         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
661
662         * Scripts/bugzilla-tool:
663         * Scripts/modules/statusbot.py:
664         * Scripts/modules/workqueue.py:
665         * Scripts/modules/workqueue_unittest.py: Added.
666         * Scripts/run-webkit-unittests:
667
668 2009-11-16  Eric Seidel  <eric@webkit.org>
669
670         Reviewed by Adam Barth.
671
672         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
673         https://bugs.webkit.org/show_bug.cgi?id=31530
674
675         * Scripts/bugzilla-tool:
676
677 2009-11-16  Eric Seidel  <eric@webkit.org>
678
679         Reviewed by Adam Barth.
680
681         bugzilla-tool needs apply-attachment
682         https://bugs.webkit.org/show_bug.cgi?id=31528
683
684         * Scripts/bugzilla-tool:
685          - Add ApplyAttachment command.
686          - Abstract applying code into WebKitApplyingScripts.
687          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
688         * Scripts/modules/bugzilla.py:
689          - Add fetch_attachment and bug_id_for_attachment_id.
690         * Scripts/modules/bugzilla_unittest.py:
691          - Add test for new parsing.
692          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
693
694 2009-11-16  Eric Seidel  <eric@webkit.org>
695
696         Reviewed by Adam Barth.
697
698         Document check-style's use of force_clean.
699
700         * Scripts/bugzilla-tool:
701         * Scripts/modules/scm.py:
702
703 2009-11-16  Adam Barth  <abarth@webkit.org>
704
705         Reviewed by Eric Seidel.
706
707         Move WorkQueue to its own file
708         https://bugs.webkit.org/show_bug.cgi?id=31529
709
710         WorkQueue and WorkQueueDelegate are separate concerns from
711         bugzilla-tool.  Also added a missing include to logging.py.
712
713         * Scripts/bugzilla-tool:
714         * Scripts/modules/logging.py:
715         * Scripts/modules/workqueue.py:
716
717 2009-11-16  Adam Barth  <abarth@webkit.org>
718
719         Reviewed by Eric Seidel.
720
721         Move OutputTee to logging.py.
722
723         * Scripts/bugzilla-tool:
724         * Scripts/modules/logging.py:
725
726 2009-11-15  Adam Barth  <abarth@webkit.org>
727
728         Reviewed by Eric Seidel.
729
730         Refactor bugzilla-tool to allow for multiple queues
731         https://bugs.webkit.org/show_bug.cgi?id=31513
732
733         Divide the commit queue class into three class to make creating
734         additional queues easier.
735
736         * Scripts/bugzilla-tool:
737
738 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
739
740         Reviewed by Eric Seidel.
741
742         svn-apply may not handle git patches created by bugzilla-tool
743         https://bugs.webkit.org/show_bug.cgi?id=31457
744
745         * Scripts/modules/scm.py:
746         * Scripts/modules/scm_unittest.py:
747
748 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
749
750         Reviewed by Eric Seidel.
751
752         bugzilla-tool should post git binary diff
753         https://bugs.webkit.org/show_bug.cgi?id=31458
754
755         Add --binary option to Git.create_patch.
756
757         * Scripts/modules/scm.py:
758         * Scripts/modules/scm_unittest.py:
759
760 2009-11-15  Adam Barth  <abarth@webkit.org>
761
762         Reviewed by Darin Adler.
763
764         Add bugzilla-tool check-style
765         https://bugs.webkit.org/show_bug.cgi?id=31515
766
767         * Scripts/bugzilla-tool:
768         * Scripts/modules/bugzilla.py:
769
770 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
771
772         Reviewed by Simon Hausmann.
773
774         Make the Qt Linux only --valgrind feature, suppress errors
775         defined in the SuppressedValgrindErrors file.
776
777         * Scripts/run-webkit-tests:
778
779 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
780
781         Reviewed by Simon Hausmann.
782
783         Set the locale to C and not to the current one in use on the system.
784
785         * DumpRenderTree/qt/DumpRenderTree.cpp:
786         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
787
788 2009-11-13  Adam Roben  <aroben@apple.com>
789
790         Add support for
791         http/tests/security/isolatedWorld/didClearWindowObject.html
792
793         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
794         window objects in isolated worlds are cleared
795
796         Reviewed by Dave Hyatt.
797
798         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
799
800         * DumpRenderTree/mac/FrameLoadDelegate.mm:
801         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
802         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
803         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
804         Added. Sets a __worldID property on the global object whose value is
805         the ID of this world.
806         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
807         Respond to this new delegate callback by calling through to one of the
808         above new methods.
809         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
810         (worldMap): Added. Returns a HashMap containing all the worlds we've
811         created.
812         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
813         haven't kept track of this world.
814         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
815         instead of declaring our own.
816
817         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
818
819         * DumpRenderTree/win/FrameLoadDelegate.cpp:
820         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
821         didClearWindowObjectForFrameInStandardWorld.
822         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
823         Respond to this new delegate callback by calling through to one of the
824         below new methods.
825         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
826         Added. Sets a __worldID property on the gobal object whose value is
827         the ID of this world.
828         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
829         Added. Moved code here from didClearWindowObject.
830
831         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
832         didClearWindowObjectForFrame* functions.
833
834         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
835         (worldMap): Added. Returns a HashMap containing all the worlds we've
836         created.
837         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
838         haven't kept track of this world.
839         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
840         instead of declaring our own.
841
842 2009-11-13  Adam Roben  <aroben@apple.com>
843
844         Finish replacing worldIDs with world objects
845
846         The only remaining use of worldIDs was in a method only used by DRT
847         for the isolated worlds tests.
848
849         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
850
851         Reviewed by Mark Rowe.
852
853         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
854         (LayoutTestController::evaluateScriptInIsolatedWorld):
855         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
856         (LayoutTestController::evaluateScriptInIsolatedWorld):
857         Updated for changes to WebFrame. Now holds the map of worldID -> world
858         at this level instead of making WebKit do it.
859
860 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
861
862         Reviewed by Simon Hausmann.
863
864         [Qt] Ensure the DRT does not output anything until first test is run
865
866         * DumpRenderTree/qt/DumpRenderTree.cpp:
867         * DumpRenderTree/qt/DumpRenderTree.h:
868
869 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
870
871         Reviewed by Tor Arne Vestbø.
872
873         Clear the undo stack in before each new test run.
874
875         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
876
877         * DumpRenderTree/qt/DumpRenderTree.cpp:
878         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
879
880 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
881
882         Reviewed by Kenneth Rohde Christiansen.
883
884         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
885
886         * DumpRenderTree/qt/DumpRenderTree.cpp:
887         (WebCore::WebPage::resetSettings):
888         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
889         (LayoutTestController::overridePreference):
890
891 2009-11-13  Eric Seidel  <eric@webkit.org>
892
893         Reviewed by Adam Barth.
894
895         Update committers.py based on svn records
896         https://bugs.webkit.org/show_bug.cgi?id=31366
897
898         This list was generated using validate-committer-lists from
899         https://bugs.webkit.org/show_bug.cgi?id=30970
900         and makes committers.py current for committers who have
901         committed in the last 3 years.
902
903         * Scripts/modules/committers.py:
904
905 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
906
907         Reviewed by Adam Barth.
908
909         The document-open.html test was flaky at times. The test invokes the layout test plugin
910         which in its destroy stream handler opens a new document. This basically tears down the
911         stream and the associated plugin instance. The pluginLog function in the layout test
912         plugin attempts to retrieve the window script object on a torn down plugin instance
913         which crashed consistently on windows in the debugger. The functions which issue
914         these logs already have a valid window script object. We now have variants of the pluginLog
915         function which take in a window script object with and without variable arguments. 
916
917         https://bugs.webkit.org/show_bug.cgi?id=31067
918
919         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
920         (pluginLogWithWindowObject):
921         (pluginLogWithWindowObjectVariableArgs):
922         (pluginLog):
923         (notifyTestCompletion):
924         (testDocumentOpen):
925         (testWindowOpen):
926
927 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
928
929         Reviewed by Gustavo Noronha Silva.
930
931         https://bugs.webkit.org/show_bug.cgi?id=30997
932         [Gtk] Implemment AtkDocument
933
934         Added testing support.
935
936         * DumpRenderTree/AccessibilityUIElement.cpp:
937         * DumpRenderTree/AccessibilityUIElement.h:
938         (getDocumentEncodingCallback):
939         (getDocumentURICallback):
940         (AccessibilityUIElement::getJSClass):
941         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
942         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
943         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
944         (AccessibilityUIElement::documentEncoding):
945         (AccessibilityUIElement::documentURI):
946
947 2009-11-12  Adam Roben  <aroben@apple.com>
948
949         Replace worldIDs with world objects
950
951         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
952         user scripts/stylesheets and isolated worlds
953
954         Reviewed by Sam Weinig.
955
956         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
957         (LayoutTestController::addUserScript):
958         (LayoutTestController::addUserStyleSheet):
959         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
960         (LayoutTestController::addUserScript):
961         (LayoutTestController::addUserStyleSheet):
962         Changed these functions to create a new WebJSWorld each time they're
963         called and to pass that world to WebKit.
964
965 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
966
967         Reviewed by Oliver Hunt.
968
969         need to implement aria tree roles
970         https://bugs.webkit.org/show_bug.cgi?id=31284
971
972         * DumpRenderTree/AccessibilityUIElement.cpp:
973         (disclosedRowAtIndexCallback):
974         (selectedRowAtIndexCallback):
975         (isEqualCallback):
976         (isAttributeSettableCallback):
977         (isActionSupportedCallback):
978         (disclosedByRowCallback):
979         (hierarchicalLevelCallback):
980         (AccessibilityUIElement::getJSClass):
981         * DumpRenderTree/AccessibilityUIElement.h:
982         (AccessibilityUIElement::isEqual):
983         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
984         (AccessibilityUIElement::hierarchicalLevel):
985         (AccessibilityUIElement::disclosedRowAtIndex):
986         (AccessibilityUIElement::selectedRowAtIndex):
987         (AccessibilityUIElement::disclosedByRow):
988         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
989         (AccessibilityUIElement::getChildAtIndex):
990         (AccessibilityUIElement::disclosedRowAtIndex):
991         (AccessibilityUIElement::selectedRowAtIndex):
992         (AccessibilityUIElement::titleUIElement):
993         (AccessibilityUIElement::parentElement):
994         (AccessibilityUIElement::disclosedByRow):
995         (AccessibilityUIElement::hierarchicalLevel):
996         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
997         (AccessibilityUIElement::hierarchicalLevel):
998         (AccessibilityUIElement::disclosedRowAtIndex):
999         (AccessibilityUIElement::selectedRowAtIndex):
1000         (AccessibilityUIElement::disclosedByRow):
1001
1002 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1003
1004         Reviewed by Darin Adler.
1005
1006         svn-apply can not handle git binary diffs
1007         https://bugs.webkit.org/show_bug.cgi?id=26830
1008
1009         Support "literal" type git binary diffs.
1010
1011         * Scripts/VCSUtils.pm:
1012         * Scripts/modules/scm_unittest.py:
1013         * Scripts/svn-apply:
1014
1015 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1016
1017         Not reviewed, removing duplicate entry for myself in committers.py.
1018
1019         * Scripts/modules/committers.py:
1020
1021 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1022
1023         Reviewed by Darin Adler and Mark Rowe.
1024
1025         https://bugs.webkit.org/show_bug.cgi?id=31200
1026         Tests in http/tests/security/mixedContent start to fail when new tests are added
1027
1028         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1029
1030 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1031
1032         Reviewed by Jan Alonzo.
1033
1034         Create, and display a window for the inspector, for inspector
1035         tests.
1036
1037         Need to also show/hide the inspector window to avoid having
1038         problems with code assuming it is realized
1039         https://bugs.webkit.org/show_bug.cgi?id=31347
1040
1041         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1042         (webInspectorShowWindow):
1043         (webInspectorCloseWindow):
1044         (webInspectorInspectWebView):
1045         (createWebView):
1046
1047 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1048
1049         Unreviewed Qt buildbot fix.
1050
1051         My previous fix was wrong, so revert that change and fix it by
1052         returning when the document of the frame has no document element.
1053         Idea is borrowed from mac and win DRT.
1054
1055         * DumpRenderTree/qt/DumpRenderTree.cpp:
1056         (WebCore::DumpRenderTree::dumpFramesAsText):
1057
1058 2009-11-11  Eric Seidel  <eric@webkit.org>
1059
1060         Reviewed byg Kenneth Rohde Christiansen.
1061
1062         Update Kenneth's committer record to include the email he
1063         uses on lists.webkit.org.
1064
1065         * Scripts/modules/committers.py:
1066
1067 2009-11-11  Eric Seidel  <eric@webkit.org>
1068
1069         Reviewed by Gustavo Noronha Silva.
1070
1071         Several committers use separate email addresses for bugzilla and svn.webkit.org
1072         https://bugs.webkit.org/show_bug.cgi?id=31364
1073
1074         Update records for existing committers to include email addresses
1075         used in svn.webkit.org and lists.webkit.org.
1076         Most committers use the same email address in all 3 places, but some use
1077         separate addresses.  committers.py needs record of each of these addresses.
1078
1079         * Scripts/modules/committers.py:
1080
1081 2009-11-11  Eric Seidel  <eric@webkit.org>
1082
1083         No review, adding second email address for an existing committer.
1084
1085         Add Yong Li's second bugzilla account to his committer record.
1086         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1087
1088         * Scripts/modules/committers.py:
1089
1090 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1091
1092         Reviewed by Simon Hausmann.
1093
1094         If the frame has no innerText don't append it, and
1095         do not add a newline which breaks some cross platform
1096         results.
1097
1098         * DumpRenderTree/qt/DumpRenderTree.cpp:
1099         (WebCore::DumpRenderTree::dumpFramesAsText):
1100
1101 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1102
1103         Reviewed by Simon Hausmann.
1104
1105         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1106
1107         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1108         (webkit_test_plugin_new_instance):
1109         (webkit_test_plugin_destroy_instance):
1110         (webkit_test_plugin_destroy_stream):
1111
1112 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1113
1114         Reviewed by Mark Rowe.
1115
1116         Implement the functionality needed by plugins/window-open.html
1117
1118         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1119         (webkit_test_plugin_new_instance):
1120         (webkit_test_plugin_set_window):
1121
1122 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1123
1124         Reviewed by Simon Hausmann.
1125
1126         [Qt] Force -graphicssystem raster and -style windows when running DRT
1127
1128         * DumpRenderTree/qt/main.cpp:
1129         * Scripts/run-webkit-tests:
1130
1131 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1132
1133         Reviewed by Simon Hausmann.
1134
1135         Compute correct library paths for Qt
1136
1137         * Scripts/webkitdirs.pm:
1138
1139 2009-11-10  Mark Rowe  <mrowe@apple.com>
1140
1141         Reviewed by Sam Weinig.
1142
1143         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1144
1145         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1146         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1147         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1148         that had enabled frame load delegate logging this would result in extra log messages being generated,
1149         causing the test to fail.
1150
1151         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1152         tests.
1153
1154         * DumpRenderTree/mac/DumpRenderTree.mm:
1155         (dumpRenderTree):
1156         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1157         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1158
1159 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1160
1161         Reviewed by Kenneth Rohde Christiansen.
1162
1163         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1164
1165         * DumpRenderTree/qt/DumpRenderTree.cpp:
1166         (WebCore::DumpRenderTree::DumpRenderTree):
1167
1168 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1169
1170         Reviewed by Jan Alonzo.
1171
1172         [GTK] Remove WebSocket configuration from WebKitWebSettings
1173         https://bugs.webkit.org/show_bug.cgi?id=31244
1174
1175         Follow-up of r50724. Don't set the enable-web-socket property
1176         anymore.
1177
1178         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1179         (resetDefaultsToConsistentValues):
1180
1181 2009-11-10  Oliver Hunt  <oliver@apple.com>
1182
1183         Reviewed by Maciej Stachowiak.
1184
1185         Rename 3D Canvas related classes to use WebGL prefix
1186         https://bugs.webkit.org/show_bug.cgi?id=29095
1187
1188         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1189         and upate webkitdirs script to new method of testing for WebGL.
1190
1191         * Scripts/do-webcore-rename:
1192         * Scripts/webkitdirs.pm:
1193
1194 2009-11-09  Oliver Hunt  <oliver@apple.com>
1195
1196         Reviewed by Geoff Garen.
1197
1198         Make do-webcore-rename work with git.
1199
1200         * Scripts/do-webcore-rename:
1201
1202 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1203
1204         Adding Kenneth to the reviewers list.
1205
1206         * Scripts/modules/committers.py:
1207
1208 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1209
1210         Reviewed by Jan Alonzo.
1211
1212         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1213         https://bugs.webkit.org/show_bug.cgi?id=30482
1214
1215         LayoutTestControllerGtk now uses the exposed
1216         Page::tabKeyCyclesThroughElements API
1217
1218         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1219         (LayoutTestController::setTabKeyCyclesThroughElements):
1220
1221 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1222
1223         Reviewed by Holger Freyther.
1224
1225         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1226         This helps to pass the test case below. Also replaced hardcoded
1227         code numbers with defined constants.
1228         https://bugs.webkit.org/show_bug.cgi?id=31185
1229         
1230         Test: editing/undo/undo-deleteWord.html
1231
1232         * DumpRenderTree/qt/EventSenderQt.cpp:
1233         (EventSender::keyDown):
1234
1235 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1236
1237         Reviewed by Holger Freyther.
1238
1239         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1240         https://bugs.webkit.org/show_bug.cgi?id=31164
1241
1242         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1243
1244         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1245         (LayoutTestController::processWork):
1246
1247 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1248
1249         Reviewed by Holger Freyther.
1250
1251         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1252         https://bugs.webkit.org/show_bug.cgi?id=31158
1253
1254         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1255         always, which from WorkQueue prospective means that a load has been started
1256         and the queue processing should stop and wait for the load to finish.
1257         Spinning it off into a loading and a non-loading variants was the solution
1258         adopted by Mac's DRT to work around this problem. The former keeps returning
1259         'true' while the later executes the script synchronously and returns 'false'
1260         making it possible to the WorkQueue to proceed right away.
1261
1262         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1263         (LayoutTestController::processWork):
1264         (LayoutTestController::queueLoadingScript):
1265         (LayoutTestController::queueNonLoadingScript):
1266         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1267         * DumpRenderTree/qt/WorkQueueItem.h:
1268         (LoadingScriptItem::LoadingScriptItem):
1269         (LoadingScriptItem::invoke):
1270         (NonLoadingScriptItem::NonLoadingScriptItem):
1271         (NonLoadingScriptItem::invoke):
1272
1273 2009-11-07  Mark Rowe  <mrowe@apple.com>
1274
1275         Rubber-stamped by Cameron Zwarich.
1276
1277         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1278
1279         * Scripts/commit-log-editor:
1280
1281 2009-11-07  Mark Rowe  <mrowe@apple.com>
1282
1283         Reviewed by Darin Adler.
1284
1285         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1286         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1287
1288         Move logic for determining the name and email address to use in a ChangeLog entry from
1289         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1290         whether the author of the patch matches committer, and therefore needs access to the
1291         email address that would be used in a ChangeLog entry.
1292
1293         Based on a patch by Pierre d'Herbemont.
1294
1295         * Scripts/VCSUtils.pm:
1296         * Scripts/commit-log-editor:
1297         * Scripts/prepare-ChangeLog:
1298         * Scripts/webkitdirs.pm:
1299
1300 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1301
1302         Reviewed by Adam Barth.
1303
1304         Added functionality to the layout test plugin to invoke document.open and
1305         window.open with default arguments. The associated webkit bug is
1306         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1307         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1308         work in Chromium (V8) if there is no calling javascript context. To achieve this
1309         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1310         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1311
1312         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1313         (testDocumentOpen):
1314         (testWindowOpen):
1315         (pluginAllocate):
1316         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1317         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1318         (NPP_New):
1319         (NPP_SetWindow):
1320         (NPP_DestroyStream):
1321         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1322         (NPP_New):
1323         (NPP_SetWindow):
1324         (NPP_NewStream):
1325         (NPP_DestroyStream):
1326
1327 2009-11-06  Eric Seidel  <eric@webkit.org>
1328
1329         Reviewed by Adam Barth.
1330
1331         bugzilla-tool crashed with exception
1332         https://bugs.webkit.org/show_bug.cgi?id=31092
1333
1334         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1335
1336 2009-11-04  Eric Seidel  <eric@webkit.org>
1337
1338         No review, just add a line which got left out of the patch uploaded for commit.
1339
1340         commit-queue is crashing when trying to reject patches after unknown failures
1341         https://bugs.webkit.org/show_bug.cgi?id=31091
1342
1343         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1344
1345 2009-11-04  Adam Roben  <aroben@apple.com>
1346
1347         Remove bogus else clause in bugzilla-tool
1348
1349         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1350         create-bug raises exception after entering bug description
1351
1352         Reviewed by David Kilzer.
1353
1354         * Scripts/bugzilla-tool:
1355         (CreateBug): else clauses are only hit if no exception is raised, so
1356         it makes no sense to try to re-raise the exception in an else clause.
1357         The exception will automatically be re-raised if it doesn't match any
1358         of the except clauses, so we don't have to do anything special here at
1359         all to get the desired behavior.
1360
1361 2009-11-04  Eric Seidel  <eric@webkit.org>
1362
1363         Reviewed by David Kilzer.
1364
1365         svn-apply's fixChangeLogPatch function seems broken
1366         https://bugs.webkit.org/show_bug.cgi?id=30683
1367
1368         Update fixChangeLogPatch to be able to handle patches which
1369         don't start at line 1.
1370         Add unit tests for svn-apply to scm_unittest.py.
1371
1372         * Scripts/VCSUtils.pm:
1373         * Scripts/modules/scm_unittest.py:
1374
1375 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1376
1377         Reviewed by Beth Dakin.
1378
1379         Need to implement ARIA role="combobox"
1380         https://bugs.webkit.org/show_bug.cgi?id=31096
1381
1382         * DumpRenderTree/AccessibilityUIElement.cpp:
1383         (showMenuCallback):
1384         (getIsExpandedCallback):
1385         (AccessibilityUIElement::getJSClass):
1386         * DumpRenderTree/AccessibilityUIElement.h:
1387         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1388         (AccessibilityUIElement::isExpanded):
1389         (AccessibilityUIElement::showMenu):
1390         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1391         (AccessibilityUIElement::isExpanded):
1392         (AccessibilityUIElement::showMenu):
1393         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1394         (AccessibilityUIElement::isSelected):
1395         (AccessibilityUIElement::isExpanded):
1396         (AccessibilityUIElement::showMenu):
1397
1398 2009-11-04  Eric Seidel  <eric@webkit.org>
1399
1400         Reviewed by Adam Barth.
1401
1402         commit-queue is crashing when trying to reject patches after unknown failures
1403         https://bugs.webkit.org/show_bug.cgi?id=31091
1404
1405         * Scripts/bugzilla-tool:
1406          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1407            so we have to find out what the current patch is by asking bugzilla again.
1408          - Discovered that this code was also leaking file descriptors, so fixed that.
1409
1410 2009-11-04  Adam Roben  <aroben@apple.com>
1411
1412         Make run-webkit-tests work for the Debug_Internal Windows
1413         configuration
1414
1415         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1416         suffix.
1417
1418         Fixes <http://webkit.org/b/31123>.
1419
1420         Reviewed by Sam Weinig.
1421
1422         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1423         Debug_Internal, either.
1424
1425 2009-11-04  Eric Seidel  <eric@webkit.org>
1426
1427         Reviewed by Adam Barth.
1428
1429         committers.py needs a way to store non-bugzilla email addresses
1430         https://bugs.webkit.org/show_bug.cgi?id=31037
1431
1432         Make Committer and Reviewer constructors take a single email or a list of emails.
1433         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1434         Expose reviewers(), used by validate-committer-lists on bug 30970.
1435
1436         * Scripts/modules/committers.py:
1437         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1438
1439 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1440
1441         Reviewed by David Levin.
1442
1443         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1444         https://bugs.webkit.org/show_bug.cgi?id=27491
1445
1446         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1447         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1448
1449         Functions to start or stop Web Socket servers are added.
1450
1451         * Scripts/run-webkit-tests:
1452
1453 2009-11-03  Eric Seidel  <eric@webkit.org>
1454
1455         No review, just changing wording of log message.
1456
1457         Change log string to say "failed" instead of "rejected"
1458         when a commit fails due to an out of date checkout.
1459         This makes grepping the commit-queue log for rejected patches easier.
1460
1461         * Scripts/bugzilla-tool:
1462
1463 2009-11-03  Eric Seidel  <eric@webkit.org>
1464
1465         No review, adding commonly known committers missing from the file.
1466
1467         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1468
1469 2009-11-03  Eric Seidel  <eric@webkit.org>
1470
1471         No review, just sort-order cleanup.
1472
1473         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1474
1475 2009-11-03  Stephen White  <senorblanco@chromium.org>
1476
1477         (Unreviewed).
1478
1479         Add myself to committers.py.
1480
1481         * Scripts/modules/committers.py:
1482
1483 2009-11-03  Robin Dunn  <robin@alldunn.com>
1484
1485         Reviewed by Kevin Ollviier.
1486
1487         Add packaging scripts for Debian-based Linux distros.
1488         
1489         https://bugs.webkit.org/show_bug.cgi?id=31075
1490
1491         * wx/packaging/build-debian-installer.py: Added.
1492         * wx/packaging/debian: Added.
1493
1494 2009-11-03  Dan Bernstein  <mitz@apple.com>
1495
1496         Reviewed by Anders Carlsson and Beth Dakin.
1497
1498         https://bugs.webkit.org/show_bug.cgi?id=31070
1499
1500         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1501         destroyed, it executes the value of the 'ondestroy' parameter as a
1502         script.
1503
1504         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1505         (pluginAllocate): Initialize onDestroy.
1506         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1507         onDestroy.
1508         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1509         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
1510         specified.
1511         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
1512
1513 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1514
1515         Reviewed by Xan Lopez.
1516
1517         https://bugs.webkit.org/show_bug.cgi?id=31035
1518         [GTK] some accessibility tests hitting assertion in debug builds
1519
1520         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
1521
1522         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1523         (AccessibilityController::rootElement):
1524
1525 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
1526
1527         Reviewed by Beth Dakin.
1528
1529         Support ARIA "tab" roles
1530         https://bugs.webkit.org/show_bug.cgi?id=30842
1531
1532         * DumpRenderTree/AccessibilityUIElement.cpp:
1533         * DumpRenderTree/AccessibilityUIElement.h:
1534         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1535         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1536         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1537
1538 2009-11-01  Eric Seidel  <eric@webkit.org>
1539
1540         Reviewed by David Levin.
1541
1542         buildbots should use --exit-after-N-failures
1543         https://bugs.webkit.org/show_bug.cgi?id=30809
1544
1545         Make the bots exit after 20 failures to prevent never-ending
1546         test runs where every test spends a minute crashing.
1547
1548         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1549
1550 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1551
1552         Reviewed by Eric Seidel.
1553
1554         Turn on warnings for QtWebKit for gcc
1555         https://bugs.webkit.org/show_bug.cgi?id=30958
1556
1557         * DumpRenderTree/qt/main.cpp: 
1558         (crashHandler): Mark function NO_RETURN
1559
1560 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
1561
1562         Adding myself to the committers list.
1563
1564         * Scripts/modules/committers.py:
1565
1566 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
1567
1568         Fix an issue that Adam noticed in DRT.
1569
1570         Reviewed by Darin Adler.
1571
1572         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1573         (AccessibilityUIElement::role):
1574         Get the length of the role text, and create a buffer dynamically.
1575
1576 2009-10-30  Eric Seidel  <eric@webkit.org>
1577
1578         No review, rolling out r50105.
1579         http://trac.webkit.org/changeset/50105
1580
1581         This commit was causing:
1582         https://bugs.webkit.org/show_bug.cgi?id=30869
1583         We'll re-implement the feature a different way.
1584
1585         * Scripts/bugzilla-tool:
1586
1587 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1588
1589         Test for MSAA: Accessibility of headings is not correct
1590
1591         https://bugs.webkit.org/show_bug.cgi?id=30937
1592
1593         Reviewed by Adam Roben.
1594
1595         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1596         (AccessibilityUIElement::role):
1597         Allow the role returned to be a BSTR.
1598         (AccessibilityUIElement::description):
1599         Fix a copy/paste error.
1600
1601 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1602
1603         Test for MSAA: Accessibility of links is wrong
1604
1605         https://bugs.webkit.org/show_bug.cgi?id=30928
1606
1607         Reviewed by Darin Adler.
1608
1609         * DumpRenderTree/AccessibilityUIElement.cpp:
1610         (getAccessibilityValueCallback):
1611         Return the accessibility value.
1612         (AccessibilityUIElement::getJSClass):
1613         Added "accessibilityValue" value.
1614
1615         * DumpRenderTree/AccessibilityUIElement.h:
1616
1617         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1618         (AccessibilityUIElement::accessibilityValue):
1619         Stubbed.
1620
1621         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1622         (AccessibilityUIElement::accessibilityValue):
1623         Stubbed.
1624
1625         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1626         (AccessibilityUIElement::accessibilityValue):
1627         Get the object's value, and return it as a JS string.
1628
1629 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
1630
1631         Fix typo in command name used by wx build system.
1632
1633         * wx/build/build_utils.py:
1634
1635 2009-10-30  Adam Barth  <abarth@webkit.org>
1636
1637         Reviewed by Darin Adler.
1638
1639         Patch v1 is a dumb default name for patches
1640         https://bugs.webkit.org/show_bug.cgi?id=30952
1641
1642         Let's use "Patch" instead.
1643
1644         * Scripts/bugzilla-tool:
1645
1646 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1647
1648         Unreviewed trivial buildfix.
1649
1650         [Qt] Buildfix for r50333.
1651
1652         * DumpRenderTree/qt/DumpRenderTree.pro:
1653
1654 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
1655
1656         Reviewed by Holger Freyther.
1657
1658         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
1659         https://bugs.webkit.org/show_bug.cgi?id=30953
1660
1661         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
1662         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
1663         makes qt DRT to share this implementation (as gtk and mac ports do).
1664
1665         * DumpRenderTree/qt/DumpRenderTree.pro:
1666         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
1667         * DumpRenderTree/qt/WorkQueue.h: Removed.
1668
1669 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1670
1671         Unreviewed potential buildbot fix.
1672
1673         Second try: Reset page history before running each test.
1674
1675         Apparently the QWebHistory::clear() keeps the current page
1676         in history which is not what we want, so we not additionally
1677         sets the history capacity to 0 (forces removing everything)
1678         and then sets it back to its original value.
1679
1680         * DumpRenderTree/qt/DumpRenderTree.cpp:
1681         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1682
1683 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1684
1685         Unreviewed potential buildbot fix.
1686
1687         Reset page history before running each test.
1688
1689         * DumpRenderTree/qt/DumpRenderTree.cpp:
1690         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1691
1692 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
1693
1694         Reviewed by Eric Seidel.
1695
1696         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
1697
1698         Bug 28420 -  Implement HTML5 <ruby> rendering
1699         (https://bugs.webkit.org/show_bug.cgi?id=28420)
1700
1701         No new tests (no functional change).
1702
1703         * Scripts/build-webkit:
1704
1705 2009-10-29  Dan Bernstein  <mitz@apple.com>
1706
1707         Reviewed by Mark Rowe.
1708
1709         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
1710         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
1711         define it.
1712
1713         * Scripts/VCSUtils.pm:
1714         * Scripts/svn-apply:
1715         * Scripts/svn-unapply:
1716
1717 2009-10-29  Xan Lopez  <xlopez@igalia.com>
1718
1719         Reviewed by Gustavo Noronha.
1720
1721         Use the GTK+ main loop instead of rolling our own mini-version of
1722         it.
1723
1724         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1725         (dump):
1726         (runTest):
1727         (webViewLoadFinished):
1728
1729 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1730
1731         Reviewed by Oliver Hunt.
1732
1733         Implement the Qt version of DRT dumpBackForwardList().
1734
1735         * DumpRenderTree/qt/DumpRenderTree.cpp:
1736         (WebCore::dumpHistoryItem):
1737         (WebCore::DumpRenderTree::dumpBackForwardList):
1738
1739 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1740
1741         Reviewed by Adam Roben.
1742
1743         Implement DRT functionality for Qt introduced in
1744         r28690 and r28705.
1745
1746         - Implemented pathToLocalResource which exposes the functionality of
1747         converting a given unix path to the correct location on Windows.
1748         - Implemented a way to remove machine-dependent information from paths
1749         in layout test results.
1750
1751         * DumpRenderTree/qt/DumpRenderTree.cpp:
1752         (WebCore::urlSuitableForTestResult):
1753         (WebCore::WebPage::javaScriptConsoleMessage):
1754         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1755         (LayoutTestController::pathToLocalResource):
1756         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1757
1758 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
1759
1760         Adding myself to the committers list.
1761
1762         * Scripts/modules/committers.py:
1763
1764 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
1765
1766         Adding myself to the committers list.
1767
1768         * Scripts/modules/committers.py:
1769
1770 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1771
1772         Reviewed by Jan Alonzo.
1773
1774         [GTK] API to start inspector for a WebView
1775         https://bugs.webkit.org/show_bug.cgi?id=22551
1776
1777         Use the new inspector API to implement the LayoutTestController
1778         interfaces used to test the inspector.
1779
1780         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1781         (webInspectorInspectWebView):
1782         (createWebView):
1783         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1784         (LayoutTestController::showWebInspector):
1785         (LayoutTestController::closeWebInspector):
1786         (LayoutTestController::evaluateInWebInspector):
1787
1788 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
1789
1790         Reviewed by Eric Seidel.
1791
1792         [Qt] WebFrame::counterValueForElementById must not be exposed
1793         https://bugs.webkit.org/show_bug.cgi?id=30882
1794
1795         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1796         (LayoutTestController::counterValueForElementById):
1797
1798 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1799
1800         Rubberstamped by Oliver Hunt.
1801
1802         Fix the warning:
1803
1804         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
1805         declared with attribute warn_unused_result".
1806
1807         by actually checking the result. In the case it is null, an
1808         error has occoured, so treat it as the other fatal errors.
1809
1810         * DumpRenderTree/qt/DumpRenderTree.cpp:
1811         (WebCore::DumpRenderTree::initializeFonts):
1812
1813 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
1814
1815         Reviewed by Darin Adler.
1816
1817         Provide a way to get counter values with layoutTestContoller
1818         https://bugs.webkit.org/show_bug.cgi?id=30555
1819
1820         Define layoutTestContoller.counterValueForElementById.
1821
1822         * DumpRenderTree/LayoutTestController.cpp:
1823         (counterValueForElementByIdCallback):
1824         (LayoutTestController::staticFunctions):
1825         * DumpRenderTree/LayoutTestController.h:
1826         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1827         (LayoutTestController::counterValueForElementById):
1828
1829 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1830
1831         Rubberstamped by Oliver Hunt.
1832
1833         Change two methods to be internal for DRT use only.
1834
1835         Part of [Qt] Review all new API in Qt 4.6
1836         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
1837
1838         * DumpRenderTree/qt/DumpRenderTree.cpp:
1839         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1840         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1841         (LayoutTestController::whiteListAccessFromOrigin):
1842
1843 2009-10-27  Eric Seidel  <eric@webkit.org>
1844
1845         Reviewed by Adam Barth.
1846
1847         REGRESSION: svn-apply exits(1) when applying a patch with a file add
1848         https://bugs.webkit.org/show_bug.cgi?id=30826
1849
1850         * Scripts/svn-apply:
1851          - Add () around all system() calls.
1852          - Use the correct system() == 0 or die instead of system() or die
1853          - Add descriptive messages to all die statements.
1854
1855 2009-10-27  Steve Block  <steveblock@google.com>
1856
1857         Reviewed by NOBODY.
1858
1859         Adds steveblock@google.com to list of committers.
1860
1861         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
1862
1863 2009-10-27  Eric Seidel  <eric@webkit.org>
1864
1865         Reviewed by Adam Barth.
1866
1867         svn-apply can exit(0) even on patch failure
1868         https://bugs.webkit.org/show_bug.cgi?id=29622
1869
1870         * Scripts/svn-apply:
1871          - Add a bunch of "or die" statements, hopefully catching all
1872            possible cases where failure could still exit(0).
1873
1874 2009-10-27  Eric Seidel  <eric@webkit.org>
1875
1876         Reviewed by Adam Barth.
1877
1878         svn-* scripts should share code through VCSUtils.pm
1879         https://bugs.webkit.org/show_bug.cgi?id=30791
1880
1881         Just moving code into a shared location.
1882
1883         * Scripts/VCSUtils.pm:
1884         * Scripts/prepare-ChangeLog:
1885         * Scripts/resolve-ChangeLogs:
1886         * Scripts/svn-apply:
1887         * Scripts/svn-create-patch:
1888         * Scripts/svn-unapply:
1889         * Scripts/update-webkit:
1890
1891 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
1892
1893         Suppress a huge number of MSVC warnings when building wxWebKit.
1894
1895         * wx/build/settings.py:
1896
1897 2009-10-26  Eric Seidel  <eric@webkit.org>
1898
1899         No review, just adding Mike Belshe to the committers list.
1900
1901         * Scripts/modules/committers.py:
1902
1903 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1904
1905         Reviewed by Darin Adler.
1906
1907         Make .rc files compile on Windows without depending on MFC headers
1908         https://bugs.webkit.org/show_bug.cgi?id=30750
1909
1910         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
1911         windows.h instead of afxres.h because it exists even when MFC is not 
1912         installed, and is all that's needed here.
1913
1914         * FindSafari/FindSafari.rc: Ditto
1915
1916 2009-10-24  Eric Seidel  <eric@webkit.org>
1917
1918         Reviewed by Adam Barth.
1919
1920         bugzilla-tool post-diff should know how to mark commit-queue=?
1921         https://bugs.webkit.org/show_bug.cgi?id=29202
1922
1923         * Scripts/bugzilla-tool:
1924          - Add --commit-queue option to post-diff, post-commits and create-bug.
1925         * Scripts/modules/bugzilla.py:
1926          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
1927          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
1928
1929 2009-10-23  Eric Seidel  <eric@webkit.org>
1930
1931         Reviewed by Adam Barth.
1932
1933         bugzilla-tool commit-queue does not notice modifications to committers.py
1934         https://bugs.webkit.org/show_bug.cgi?id=30084
1935
1936         * Scripts/bugzilla-tool:
1937          - Make commit-queue re-exec itself instead of using while(1).
1938          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
1939          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
1940
1941 2009-10-22  Eric Seidel  <eric@webkit.org>
1942
1943         Reviewed by Adam Barth.
1944
1945         commit-queue will get stuck on patches if land-patches terminates unexpectedly
1946         https://bugs.webkit.org/show_bug.cgi?id=30634
1947
1948         * Scripts/bugzilla-tool:
1949          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
1950          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
1951
1952 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
1953
1954         Reviewed by Eric Seidel.
1955
1956         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
1957
1958         https://bugs.webkit.org/show_bug.cgi?id=30763
1959
1960         * pywebsocket/mod_pywebsocket/__init__.py:
1961         * pywebsocket/mod_pywebsocket/dispatch.py:
1962         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
1963         * pywebsocket/mod_pywebsocket/standalone.py:
1964         * pywebsocket/setup.py:
1965         * pywebsocket/test/test_dispatch.py:
1966
1967 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
1968
1969         Reviewed by David Levin.
1970
1971         REGRESSION: 2 failures in run-webkit-unittests
1972         https://bugs.webkit.org/show_bug.cgi?id=30645
1973
1974         * Scripts/modules/cpp_style_unittest.py:
1975         Fixed a few test scenarios which apparently lost some spaces from 
1976         text literals.
1977
1978 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
1979
1980         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
1981
1982         * Scripts/webkitdirs.pm:
1983
1984 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
1985
1986         Reviewed by Darin Adler.
1987
1988         Unification of using null device in perl scripts.
1989         https://bugs.webkit.org/show_bug.cgi?id=30572
1990
1991         * Scripts/VCSUtils.pm:
1992         * Scripts/bisect-builds:
1993         * Scripts/resolve-ChangeLogs:
1994         * Scripts/run-iexploder-tests:
1995         * Scripts/run-jsc:
1996         * Scripts/run-mangleme-tests:
1997         * Scripts/run-webkit-tests:
1998         * Scripts/webkitdirs.pm:
1999         Using File::Spec->devnull() instead of hard coded /dev/null.
2000
2001 2009-10-26  Eric Seidel  <eric@webkit.org>
2002
2003         Reviewed by Holger Freyther.
2004
2005         Reviewers are missing from committers.py
2006         https://bugs.webkit.org/show_bug.cgi?id=30733
2007
2008         * Scripts/modules/committers.py:
2009
2010 2009-10-23  Eric Seidel  <eric@webkit.org>
2011
2012         No review, only adding Alice to the list of reviewers.
2013
2014         * Scripts/modules/committers.py:
2015
2016 2009-10-23  Eric Seidel  <eric@webkit.org>
2017
2018         Reviewed by Eric Carlson.
2019
2020         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2021         https://bugs.webkit.org/show_bug.cgi?id=30700
2022
2023         * DumpRenderTree/mac/DumpRenderTree.mm:
2024         (resetDefaultsToConsistentValues): Update QuickTime version check.
2025
2026 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2027
2028         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2029         character measurement APIs that are private on Tiger.
2030
2031         * wx/build/settings.py:
2032
2033 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2034
2035         Reviewed by NOBODY (build fix).
2036         Build fix following bug #30696.
2037
2038         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2039         (LayoutTestController::evaluateScriptInIsolatedWorld):
2040
2041 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2042
2043         Reviewed by Sam Weinig & Geoff Garen.
2044
2045         https://bugs.webkit.org/show_bug.cgi?id=30696
2046         Enable isolated-worlds tests on mac.
2047
2048         Add private interface for DRT to invoke execution in a given world.
2049
2050         * DumpRenderTree/LayoutTestController.cpp:
2051         (evaluateScriptInIsolatedWorldCallback):
2052         (LayoutTestController::staticFunctions):
2053         * DumpRenderTree/LayoutTestController.h:
2054         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2055         (LayoutTestController::evaluateScriptInIsolatedWorld):
2056         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2057         (LayoutTestController::evaluateScriptInIsolatedWorld):
2058
2059 2009-10-21  Eric Seidel  <eric@webkit.org>
2060
2061         Reviewed by Adam Barth.
2062
2063         bugzilla-tool's "patch failed to download an apply" error should give more information
2064         https://bugs.webkit.org/show_bug.cgi?id=30632
2065
2066         * Scripts/modules/scm.py:
2067          - Use the common run_command method instead of custom POpen code.
2068          - Make run_command know how to take pipes as input.
2069         * Scripts/modules/scm_unittest.py:
2070          - Add new tests to cover change.
2071          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2072
2073 2009-10-21  Kent Tamura  <tkent@chromium.org>
2074
2075         Unreviewed.  Adding myself to the committers list.
2076
2077         * Scripts/modules/committers.py:
2078
2079 2009-10-21  Robin Dunn  <robin@alldunn.com>
2080
2081         Reviewed by Kevin Ollivier.
2082
2083         Update the Windows installer builder to work with Vista / Win 7 and with git.
2084         
2085         https://bugs.webkit.org/show_bug.cgi?id=30649
2086
2087         * wx/build/build_utils.py:
2088         * wx/packaging/build-mac-installer.py:
2089         * wx/packaging/build-win-installer.py:
2090         * wx/packaging/wxWebKitInstaller.iss.in:
2091
2092 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2093
2094         Reviewed by Gustavo Noronha.
2095
2096         [GTK] Added conditional code to avoid using
2097         gdk_window_get_root_coords if we do not have a gtk+ release newer
2098         than 2.17.3.
2099         https://bugs.webkit.org/show_bug.cgi?id=30636
2100
2101         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2102
2103 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2104
2105         Reviewed by Eric Seidel.
2106
2107         [Qt] Added dummy implementation for keepWebHistory()
2108         https://bugs.webkit.org/show_bug.cgi?id=30592
2109
2110         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2111         (LayoutTestController::keepWebHistory):
2112         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2113
2114 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2115
2116         Reviewed by Xan Lopez.
2117
2118         [GTK] Fixed the double click condition, it is not double click if
2119         we move in just in one direction.
2120         https://bugs.webkit.org/show_bug.cgi?id=30636
2121
2122         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2123
2124 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2125
2126         Reviewed by Xan Lopez.
2127
2128         [GTK] Initialize the events completly before emitting them.
2129         https://bugs.webkit.org/show_bug.cgi?id=30633
2130
2131         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2132
2133 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2134
2135         wx build fix. Fix for when linking using --as-needed with gcc.
2136
2137         * wx/browser/wscript:
2138
2139 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2140
2141         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2142         to support all the features used by CURL backend.
2143         
2144         * wx/build/settings.py:
2145         * wx/install-unix-extras:
2146
2147 2009-10-20  Anton Muhin  <antonm@chromium.org>
2148
2149         Reviewed by Adam Barth.
2150
2151         Add {ager,antonm,yurys}@chromium.org into committers.py
2152         https://bugs.webkit.org/show_bug.cgi?id=30560
2153
2154         * Scripts/modules/committers.py:
2155
2156 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2157
2158         Reviewed by Tor Arne Vestbø.
2159
2160         Make the Netscape Test plugin available to the Qt launcher.
2161
2162         * Scripts/run-launcher:
2163
2164 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2165
2166         Reviewed by David Levin.
2167
2168         Removed WebSocket runtime settings.
2169         https://bugs.webkit.org/show_bug.cgi?id=29896
2170
2171         WebSocket runtime configuration is supported by chromium/v8 only.
2172
2173         * DumpRenderTree/mac/DumpRenderTree.mm:
2174         (resetDefaultsToConsistentValues):
2175         * DumpRenderTree/win/DumpRenderTree.cpp:
2176         (resetDefaultsToConsistentValues):
2177
2178 2009-10-19  Nate Chapin  <japhet@chromium.org>
2179
2180         Reviewed by Adam Barth.
2181
2182         Add testFail() to test plugin so we can test our handling of a
2183         plugin invoke call returning false.
2184
2185         https://bugs.webkit.org/show_bug.cgi?id=30239
2186
2187         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2188         (pluginInvoke):
2189         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2190
2191 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2192
2193         Reviewed by Gustavo Noronha.
2194
2195         Enable DOM pasting when running layout tests.
2196
2197         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2198         (resetDefaultsToConsistentValues):
2199
2200 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2201
2202         Reviewed by Simon Hausmann.
2203
2204         Use the setPreferredContentsSize method instead
2205         of setFixedContentsSize, as the method has been renamed.
2206
2207         * DumpRenderTree/qt/DumpRenderTree.cpp:
2208         (WebCore::DumpRenderTree::open):
2209         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2210         (LayoutTestController::setFixedContentsSize):
2211
2212 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2213
2214         Reviewed by Dan Bernstein.
2215
2216         https://bugs.webkit.org/show_bug.cgi?id=30456
2217         Fixes for new Debug_All Windows build configuration.
2218
2219         * DumpRenderTree/win/DumpRenderTree.cpp:
2220         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2221         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2222
2223 2009-10-16  Eric Seidel  <eric@webkit.org>
2224
2225         Reviewed by Adam Barth.
2226
2227         commit-queue status bot should list which buildbot is blocking the queue
2228         https://bugs.webkit.org/show_bug.cgi?id=30452
2229
2230         Add new methods and testing.
2231
2232         * Scripts/bugzilla-tool:
2233         * Scripts/modules/buildbot.py:
2234         * Scripts/modules/buildbot_unittest.py:
2235
2236 2009-10-16  Eric Seidel  <eric@webkit.org>
2237
2238         Reviewed by Adam Barth.
2239
2240         run-webkit-tests fails when CWD is not inside a WebKit checkout
2241         https://bugs.webkit.org/show_bug.cgi?id=30451
2242
2243         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2244         * Scripts/modules/scm_unittest.py:
2245           - Remove use of original_path (we don't need to restore the CWD).
2246           - Don't use '.' to find the webkit checkout, use __file__ instead.
2247
2248 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2249
2250         Reviewed by Adam Roben.
2251
2252         Add a Debug_All configuration to build entire stack as debug.
2253         Change Debug_Internal to:
2254         - stop using _debug suffix for all WebKit/Safari binaries
2255         - not use _debug as a DLL naming suffix
2256         - use non-debug C runtime lib.
2257
2258         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2259         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2260         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2261         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2262         Add missing debug.vsprops inherited property sheet.
2263         Add Debug_All configuration.
2264         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2265         * WinLauncher/WinLauncher.vcproj:
2266         Removed extraneous definitions inherited from vsprops.
2267         Add Debug_All configuration.
2268
2269 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2270
2271         Reviewed by David Levin.
2272
2273         check-webkit-style is wrong about indent checking in namespaces
2274         in header files and a few other things
2275         https://bugs.webkit.org/show_bug.cgi?id=30362
2276
2277         The few other things include:
2278         + check-webkit-style does not require spaces around the equal sign
2279           inside 'if' statements and around binary operators that take 
2280           numeric literals.
2281         + check-webkit-style reports false errors for the / operator
2282           when part of a filename in the #include directive.
2283
2284         * Scripts/modules/cpp_style.py:
2285         Improved indentation checking and space checking around
2286         binary operators. While the checks are still not perfect,
2287         they are clearly better than before.
2288         * Scripts/modules/cpp_style_unittest.py:
2289         Added test cases for the newly supported checks and modified old
2290         test cases to match the new guidelines
2291
2292 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2293
2294         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2295
2296         * wx/build/settings.py:
2297
2298 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2299
2300         Reviewed by David Levin.
2301
2302         Add mod_pywebsocket to test Web Sockets.
2303         http://code.google.com/p/pywebsocket/
2304         https://bugs.webkit.org/show_bug.cgi?id=27490
2305
2306         * pywebsocket/COPYING: Added.
2307         * pywebsocket/MANIFEST.in: Added.
2308         * pywebsocket/README: Added.
2309         * pywebsocket/example/echo_client.py: Added.
2310         * pywebsocket/example/echo_wsh.py: Added.
2311         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2312         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2313         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2314         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2315         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2316         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2317         * pywebsocket/mod_pywebsocket/util.py: Added.
2318         * pywebsocket/setup.py: Added.
2319         * pywebsocket/test/config.py: Added.
2320         * pywebsocket/test/mock.py: Added.
2321         * pywebsocket/test/run_all.py: Added.
2322         * pywebsocket/test/test_dispatch.py: Added.
2323         * pywebsocket/test/test_handshake.py: Added.
2324         * pywebsocket/test/test_mock.py: Added.
2325         * pywebsocket/test/test_msgutil.py: Added.
2326         * pywebsocket/test/test_util.py: Added.
2327         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2328         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2329         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2330         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2331         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2332         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2333         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2334         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2335
2336 2009-10-15  James Robinson  <jamesr@google.com>
2337
2338         Reviewed by David Levin.
2339
2340         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2341
2342         https://bugs.webkit.org/show_bug.cgi?id=30426
2343
2344         * Scripts/modules/cpp_style.py:
2345         * Scripts/modules/cpp_style_unittest.py:
2346
2347 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2348
2349         Reviewed by Adam Roben.
2350
2351         Fixes <http://webkit.org/b/30411>.
2352         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2353         
2354         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2355         building Chromium.
2356
2357         * Scripts/pdevenv:
2358
2359 2009-10-15  Robin Dunn  <robin@alldunn.com>
2360
2361         Reviewed by Kevin Ollivier.
2362
2363         Add Mac package building scripts for wx.
2364         
2365         https://bugs.webkit.org/show_bug.cgi?id=30405
2366
2367         * wx/build/build_utils.py:
2368         * wx/build/settings.py:
2369         * wx/packaging/build-mac-installer.py: Added.
2370
2371 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2372
2373         Reviewed by Gustavo Noronha.
2374
2375         Enable Web Sockets support when running layout tests.
2376
2377         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2378         (resetDefaultsToConsistentValues):
2379
2380 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2381
2382         Reviewed by Gustavo Noronha.
2383
2384         Need to initialize event.button.button, since in most cases a
2385         button number is not passed as an argument.
2386
2387         * DumpRenderTree/gtk/EventSender.cpp:
2388         (mouseDownCallback):
2389         (mouseUpCallback):
2390
2391 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2392
2393         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2394         the OS if none was explicitly set.
2395
2396         * wx/build/settings.py:
2397
2398 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2399
2400         Reviewed by Timothy Hatcher.
2401
2402         Web Inspector: enable developers extras within inspector layout tests.
2403
2404         https://bugs.webkit.org/show_bug.cgi?id=30014
2405
2406         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2407         (LayoutTestController::showWebInspector):
2408         (LayoutTestController::closeWebInspector):
2409         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2410         (LayoutTestController::showWebInspector):
2411         (LayoutTestController::closeWebInspector):
2412
2413 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2414
2415         Reviewed by Jan Alonzo.
2416
2417         GtkLauncher is using a deprecated signal
2418         https://bugs.webkit.org/show_bug.cgi?id=30364
2419
2420         Modified GtkLauncher to use notify::title signal instead of
2421         deprecated title-changed signal
2422
2423         * GtkLauncher/main.c:
2424         (notify_title_cb):
2425         (create_browser):
2426
2427 2009-10-14  Brady Eidson  <beidson@apple.com>
2428
2429         Reviewed by Sam Weinig.
2430
2431         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2432         1 - Disables WebHistory
2433         2 - Doesn't make sense in that context anyway.
2434
2435         * DumpRenderTree/win/DumpRenderTree.cpp:
2436         (createWebViewAndOffscreenWindow):
2437
2438 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2439
2440         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2441         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2442
2443         * wx/build/settings.py:
2444         * wx/install-unix-extras:
2445
2446 2009-10-14  Brady Eidson  <beidson@apple.com>
2447
2448         Reviewed by Sam Weinig.
2449
2450         WebKit Win API should provide a delegate interface for global history.
2451         https://bugs.webkit.org/show_bug.cgi?id=29905
2452
2453         * DumpRenderTree/LayoutTestController.cpp:
2454         (LayoutTestController::LayoutTestController):
2455         * DumpRenderTree/LayoutTestController.h:
2456         (LayoutTestController::dumpHistoryDelegateCallbacks):
2457         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2458                 
2459         * DumpRenderTree/win/DumpRenderTree.cpp:
2460         (shouldLogHistoryDelegates):
2461         (runTest):
2462         (createWebViewAndOffscreenWindow):
2463         (main):
2464         * DumpRenderTree/win/DumpRenderTree.vcproj:
2465         
2466         Add the IWebHistoryDelegate to DRT Windows:
2467         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2468         (wstringFromBSTR):
2469         (HistoryDelegate::HistoryDelegate):
2470         (HistoryDelegate::~HistoryDelegate):
2471         (HistoryDelegate::QueryInterface):
2472         (HistoryDelegate::AddRef):
2473         (HistoryDelegate::Release):
2474         (HistoryDelegate::didNavigateWithNavigationData):
2475         (HistoryDelegate::didPerformClientRedirectFromURL):
2476         (HistoryDelegate::didPerformServerRedirectFromURL):
2477         (HistoryDelegate::updateHistoryTitle):
2478         (HistoryDelegate::populateVisitedLinksForWebView):
2479         * DumpRenderTree/win/HistoryDelegate.h: Added.
2480
2481         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2482         (LayoutTestController::removeAllVisitedLinks):
2483
2484 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2485
2486         Reviewed by Simon Hausmann.
2487
2488         [Qt] Implement support for setPOSIXLocale on Qt.
2489         https://bugs.webkit.org/show_bug.cgi?id=30268 
2490  
2491         * DumpRenderTree/qt/DumpRenderTree.cpp:
2492         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2493         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2494         (LayoutTestController::setPOSIXLocale):
2495         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2496
2497 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2498
2499         Unreviewed, adding myself to reviewers list.
2500
2501         * Scripts/modules/committers.py:
2502
2503 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2504
2505         Reviewed by Mark Rowe.
2506
2507         Fix null assignment so root tests work again.
2508
2509         * Scripts/webkitdirs.pm:
2510
2511 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2512
2513         Reviewed by Simon Hausmann.
2514
2515         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
2516         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
2517         This is done in preparation of implementing missing features in DRT.
2518         No functionality changes made yet.
2519
2520         * DumpRenderTree/qt/DumpRenderTree.cpp:
2521         * DumpRenderTree/qt/DumpRenderTree.pro:
2522         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
2523         (EventSender::EventSender):
2524         (EventSender::mouseDown):
2525         (EventSender::mouseUp):
2526         (EventSender::mouseMoveTo):
2527         (EventSender::leapForward):
2528         (EventSender::keyDown):
2529         (EventSender::contextClick):
2530         (EventSender::scheduleAsynchronousClick):
2531         (EventSender::frameUnderMouse):
2532         * DumpRenderTree/qt/EventSenderQt.h: Added.
2533         (EventSender::clearKillRing):
2534         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
2535         (LayoutTestController::LayoutTestController):
2536         (LayoutTestController::reset):
2537         (LayoutTestController::processWork):
2538         (LayoutTestController::maybeDump):
2539         (LayoutTestController::waitUntilDone):
2540         (LayoutTestController::notifyDone):
2541         (LayoutTestController::windowCount):
2542         (LayoutTestController::clearBackForwardList):
2543         (LayoutTestController::dumpEditingCallbacks):
2544         (LayoutTestController::dumpResourceLoadCallbacks):
2545         (LayoutTestController::queueBackNavigation):
2546         (LayoutTestController::queueForwardNavigation):
2547         (LayoutTestController::queueLoad):
2548         (LayoutTestController::queueReload):
2549         (LayoutTestController::queueScript):
2550         (LayoutTestController::provisionalLoad):
2551         (LayoutTestController::timerEvent):
2552         (LayoutTestController::encodeHostName):
2553         (LayoutTestController::decodeHostName):
2554         (LayoutTestController::setJavaScriptProfilingEnabled):
2555         (LayoutTestController::setFixedContentsSize):
2556         (LayoutTestController::setPrivateBrowsingEnabled):
2557         (LayoutTestController::setPopupBlockingEnabled):
2558         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2559         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2560         (LayoutTestController::numberOfActiveAnimations):
2561         (LayoutTestController::disableImageLoading):
2562         (LayoutTestController::dispatchPendingLoadRequests):
2563         (LayoutTestController::setDatabaseQuota):
2564         (LayoutTestController::clearAllDatabases):
2565         (LayoutTestController::whiteListAccessFromOrigin):
2566         (LayoutTestController::waitForPolicyDelegate):
2567         (LayoutTestController::overridePreference):
2568         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
2569         (LayoutTestController::isLoading):
2570         (LayoutTestController::setLoading):
2571         (LayoutTestController::shouldDumpAsText):
2572         (LayoutTestController::shouldDumpBackForwardList):
2573         (LayoutTestController::shouldDumpChildrenAsText):
2574         (LayoutTestController::shouldDumpDatabaseCallbacks):
2575         (LayoutTestController::shouldDumpStatusCallbacks):
2576         (LayoutTestController::shouldWaitUntilDone):
2577         (LayoutTestController::canOpenWindows):
2578         (LayoutTestController::shouldDumpTitleChanges):
2579         (LayoutTestController::waitForPolicy):
2580         (LayoutTestController::dumpAsText):
2581         (LayoutTestController::dumpChildFramesAsText):
2582         (LayoutTestController::dumpDatabaseCallbacks):
2583         (LayoutTestController::dumpStatusCallbacks):
2584         (LayoutTestController::setCanOpenWindows):
2585         (LayoutTestController::dumpBackForwardList):
2586         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2587         (LayoutTestController::display):
2588         (LayoutTestController::dumpTitleChanges):
2589         (LayoutTestController::dumpSelectionRect):
2590         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
2591         (TextInputController::TextInputController):
2592         (TextInputController::doCommand):
2593         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
2594         * DumpRenderTree/qt/WorkQueue.cpp:
2595         * DumpRenderTree/qt/WorkQueue.h:
2596         * DumpRenderTree/qt/WorkQueueItem.h:
2597         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
2598         (findFrameNamed):
2599         (LoadItem::invoke):
2600         (ReloadItem::invoke):
2601         (ScriptItem::invoke):
2602         (BackForwardItem::invoke):
2603         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
2604         * DumpRenderTree/qt/jsobjects.h:
2605
2606 2009-10-13  Dmitry Titov  <dimich@chromium.org>
2607
2608         Not reviewed, adding myself to the list of reviewers.
2609
2610         * Scripts/modules/committers.py:
2611
2612 2009-10-13  Anders Carlsson  <andersca@apple.com>
2613
2614         Reviewed by Sam Weinig.
2615
2616         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
2617
2618         Make the private browsing mode testable by the test plug-in.
2619         
2620         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2621         (pluginGetProperty):
2622         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2623         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2624         (NPP_New):
2625         (NPP_SetValue):
2626
2627 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
2628
2629         No review, just adding self to the list of reviewers.
2630
2631         * Scripts/modules/committers.py:
2632
2633 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
2634
2635         Reviewed by Adam Roben.
2636
2637         Web Inspector: Use proper web view in inspector layout
2638         tests for windows.
2639
2640         https://bugs.webkit.org/show_bug.cgi?id=30298
2641
2642         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2643         (LayoutTestController::showWebInspector):
2644         (LayoutTestController::closeWebInspector):
2645         (LayoutTestController::evaluateInWebInspector):
2646
2647 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
2648
2649         Reviewed by Sam Weinig.
2650
2651         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
2652         https://bugs.webkit.org/show_bug.cgi?id=29841
2653
2654         * DumpRenderTree/mac/DumpRenderTree.mm:
2655         (resetDefaultsToConsistentValues):
2656         * DumpRenderTree/win/DumpRenderTree.cpp:
2657         (resetDefaultsToConsistentValues):
2658
2659 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
2660
2661         Reviewed by Dimitri Glazkov.
2662
2663         Chromium Port - Windows
2664         https://bugs.webkit.org/show_bug.cgi?id=29969
2665
2666         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
2667         * Scripts/webkitdirs.pm:
2668
2669 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
2670
2671         Reviewed by Darin Adler.
2672
2673         jsc scripts cleanup and Qt/GTK fix
2674         https://bugs.webkit.org/show_bug.cgi?id=30288
2675
2676         Duplicated jscPath() moved to webkitdirs.pm.
2677         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
2678         Configuration added (release/debug) to path for Qt-port on Windows.
2679
2680         * Scripts/run-javascriptcore-tests:
2681         * Scripts/run-jsc:
2682         * Scripts/run-sunspider:
2683         * Scripts/sunspider-compare-results:
2684         * Scripts/webkitdirs.pm:
2685
2686 2009-10-11  Adam Barth  <abarth@webkit.org>
2687
2688         Unreviewed.  Add Collin to committers.py.
2689
2690         * Scripts/modules/committers.py:
2691
2692 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
2693
2694         wx build fix, add bindings to source/include dirs now that there are sources there.
2695
2696         * wx/build/settings.py:
2697
2698 2009-10-09  Mark Rowe  <mrowe@apple.com>
2699
2700         Reviewed by Brady Eidson.
2701
2702         Enable plug-in halting in DumpRenderTree.
2703
2704         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
2705         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
2706
2707         * DumpRenderTree/mac/DumpRenderTree.mm:
2708         (resetDefaultsToConsistentValues):
2709         * DumpRenderTree/mac/UIDelegate.mm:
2710         (-[UIDelegate webView:shouldHaltPlugin:]):
2711
2712 2009-10-08  Brady Eidson  <beidson@apple.com>
2713
2714         Reviewed by Dan Bernstein.
2715
2716         Ask the History Delegate to populate the visited links hash.
2717         <rdar://problem/7285293> and https://webkit.org/b/29904
2718
2719         Add the ability for LayoutTestController to clear all visited links.
2720         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
2721
2722         * DumpRenderTree/LayoutTestController.cpp:
2723         (LayoutTestController::LayoutTestController):
2724         (removeAllVisitedLinksCallback):
2725         (LayoutTestController::staticFunctions):
2726         * DumpRenderTree/LayoutTestController.h:
2727         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2728         (LayoutTestController::removeAllVisitedLinks):
2729
2730         * DumpRenderTree/mac/HistoryDelegate.mm:
2731         (-[HistoryDelegate populateVisitedLinksForWebView:]):
2732
2733         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2734         (LayoutTestController::removeAllVisitedLinks):
2735         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2736         (LayoutTestController::removeAllVisitedLinks):
2737         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2738         (LayoutTestController::removeAllVisitedLinks):
2739
2740
2741 2009-10-08  Daniel Bates  <dbates@webkit.org>
2742
2743         Reviewed by Adam Roben.
2744
2745         https://bugs.webkit.org/show_bug.cgi?id=30175
2746         
2747         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
2748         the OLE drag-and-drop return value like the function it emulates. Currently, 
2749         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
2750         whether the drag-and-drop operation was successful or was cancelled.
2751         
2752         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
2753         return value according to whether the drop operation was successful or not.
2754
2755         * DumpRenderTree/win/EventSender.cpp:
2756         (doMouseUp): Added parameter oleDragAndDropReturnValue.
2757         (replaySavedEvents): Ditto.
2758         * DumpRenderTree/win/EventSender.h:
2759         * DumpRenderTree/win/UIDelegate.cpp:
2760         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
2761
2762 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2763
2764         Reviewed by Xan Lopez.
2765
2766         [GTK] Added support for a parameter setting the button that was
2767         pressed in the mouseDown function.
2768         https://bugs.webkit.org/show_bug.cgi?id=30220
2769
2770         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2771
2772 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2773
2774         Reviewed by Xan Lopez.
2775
2776         [GTK] Added a line to the bottom of the expected result to match
2777         the output of the test.
2778         https://bugs.webkit.org/show_bug.cgi?id=30220
2779
2780         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
2781         expected.txt:
2782
2783 2009-10-08  Adam Roben  <aroben@apple.com>
2784
2785         Use QueryInterface to get IWebInspectorPrivate
2786
2787         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
2788         accessed in a more standard way
2789
2790         Reviewed by John Sullivan and Tim Hatcher.
2791
2792         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2793         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
2794         by calling IWebViewPrivate::inspector, then use QueryInterface to get
2795         to the IWebInspectorPrivate interface.
2796
2797 2009-10-07  Adam Roben  <aroben@apple.com>
2798
2799         Implement DRT support for origin whitelisting
2800
2801         Fixes <http://webkit.org/b/30185>.
2802
2803         Reviewed by Eric Seidel.
2804
2805         * DumpRenderTree/win/DumpRenderTree.cpp:
2806         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
2807         whitelist, to match Mac DRT.
2808         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2809         (LayoutTestController::whiteListAccessFromOrigin): Call through to
2810         IWebViewPrivate::whiteListAccessFromOrigin.
2811
2812 2009-10-07  Brady Eidson  <beidson@apple.com>
2813
2814         Reviewed by Darin Adler.
2815
2816         Send title changes to the global history delegate.
2817         <rdar://problem/7285293> and https://webkit.org/b/29904
2818
2819         * DumpRenderTree/mac/HistoryDelegate.mm:
2820         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
2821
2822 2009-10-07  Adam Barth  <abarth@webkit.org>
2823
2824         Unreviewed.  Remove some folks from committers.py who were listed on
2825         the WebKit Team wiki page but who weren't actually listed as commit+.
2826         At some point, we should coorelate this list with the committers
2827         mailing list.
2828
2829         * Scripts/modules/committers.py:
2830
2831 2009-10-07  Adam Barth  <abarth@webkit.org>
2832
2833         Unreviewed.  Import a bunch of committers from the WebKit Team page on
2834         the wiki into committers.py.
2835
2836         * Scripts/modules/committers.py:
2837
2838 2009-10-07  Adam Barth  <abarth@webkit.org>
2839
2840         Unreviewed.  Added Aaron Boodman to committers.py.
2841
2842         * Scripts/modules/committers.py:
2843
2844 2009-10-07  Evan Martin  <evan@chromium.org>
2845
2846         Reviewed by Darin Adler.
2847
2848         Add API to LayoutTestController for re/setting the system locale.
2849         https://bugs.webkit.org/show_bug.cgi?id=18994
2850
2851         * DumpRenderTree/LayoutTestController.cpp:
2852         (setLocaleCallback):
2853         (LayoutTestController::staticFunctions):
2854         (LayoutTestController::setLocale):
2855         * DumpRenderTree/LayoutTestController.h:
2856
2857 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
2858
2859         Reviewed by Jan Alonzo.
2860
2861         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
2862         https://bugs.webkit.org/show_bug.cgi?id=29689
2863
2864         Build fix by adding -lfontconfig for DumpRenderTree.
2865
2866         * GNUmakefile.am:
2867
2868 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2869
2870         Reviewed by Simon Hausmann.
2871
2872         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
2873
2874         * Scripts/run-webkit-tests:
2875
2876 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2877
2878         Reviewed by Gustavo Noronha.
2879
2880         "delete" in EventSender is the backspace key, not the delete one.
2881
2882         * DumpRenderTree/gtk/EventSender.cpp:
2883         (keyDownCallback):
2884
2885 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2886
2887         Reviewed by Gustavo Noronha.
2888
2889         getChildrenWithRange expects as last parameter the end index, not
2890         the length of the range. Correct this and clarify the variable
2891         names to reflect how the code works.
2892
2893         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2894         (AccessibilityUIElement::getChildrenWithRange):
2895         (AccessibilityUIElement::getChildAtIndex):
2896
2897 2009-10-06  Mark Rowe  <mrowe@apple.com>
2898
2899         Reviewed by Simon Fraser.
2900
2901         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
2902
2903         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
2904         the fact we have already changed the working directory to the top of the open source tree.
2905
2906 2009-10-06  Julie Parent  <jparent@chromium.org>
2907
2908         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
2909         rather than my committer email.
2910
2911         * Scripts/modules/committers.py:
2912
2913 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2914
2915         Reviewed by Eric Seidel.
2916
2917         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
2918
2919         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
2920         it after each layout test as it should do, making the DRT dump additional output
2921         for all of the subsequent layout tests.
2922
2923         * DumpRenderTree/qt/jsobjects.cpp:
2924         (LayoutTestController::reset):
2925
2926 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2927
2928         Reviewed by Simon Hausmann.
2929
2930         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
2931         fast/dom/assign-to-window-status.html test, which is passing as a result.
2932
2933         https://bugs.webkit.org/show_bug.cgi?id=30127
2934
2935         * DumpRenderTree/qt/DumpRenderTree.cpp:
2936         (WebCore::DumpRenderTree::DumpRenderTree):
2937         (WebCore::DumpRenderTree::statusBarMessage):
2938         * DumpRenderTree/qt/DumpRenderTree.h:
2939         * DumpRenderTree/qt/jsobjects.h:
2940         (LayoutTestController::shouldDumpStatusCallbacks):
2941         (LayoutTestController::dumpStatusCallbacks):
2942
2943 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2944
2945         Reviewed by Simon Hausmann.
2946
2947         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
2948         ignores the argument indicating which mouse button to trigger.
2949         https://bugs.webkit.org/show_bug.cgi?id=30048
2950
2951         This affects the fast/events/mouse-click-events.html layout test.
2952
2953         * DumpRenderTree/qt/jsobjects.cpp:
2954         (EventSender::mouseDown):
2955         (EventSender::mouseUp):
2956         * DumpRenderTree/qt/jsobjects.h:
2957
2958 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2959
2960         Reviewed by Simon Hausmann.
2961
2962         [Qt] Fix the EventSender::keyDown() implementation
2963         https://bugs.webkit.org/show_bug.cgi?id=30043
2964
2965         It should post both a key press event and a key release event,
2966         just like other ports do.
2967
2968         * DumpRenderTree/qt/jsobjects.cpp:
2969         (EventSender::keyDown):
2970
2971 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
2972
2973         wx build fix. Add jpeg to the list of libs to link against.
2974
2975         * wx/build/settings.py:
2976
2977 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
2978
2979         Reviewed by Simon Hausmann.
2980
2981         [Qt] EventSender::keyDown() cannot send function-key events.
2982         https://bugs.webkit.org/show_bug.cgi?id=30044
2983
2984         This affects the fast/events/keydown-function-keys.html layout test.
2985
2986         * DumpRenderTree/qt/jsobjects.cpp:
2987         (EventSender::keyDown):
2988
2989 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
2990
2991         Added --wx-compiler-prefix waf option to allow building wxWebKit with
2992         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
2993
2994         * wx/build/settings.py:
2995         * wx/build/wxpresets.py:
2996
2997 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
2998
2999         Reviewed by Timothy Hatcher.
3000
3001         Web Inspector: add testing harness for Web Inspector.
3002
3003         https://bugs.webkit.org/show_bug.cgi?id=30010
3004
3005         * DumpRenderTree/LayoutTestController.cpp:
3006         (showWebInspectorCallback):
3007         (closeWebInspectorCallback):
3008         (evaluateInWebInspectorCallback):
3009         (LayoutTestController::staticFunctions):
3010         * DumpRenderTree/LayoutTestController.h:
3011         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3012         (LayoutTestController::showWebInspector):
3013         (LayoutTestController::closeWebInspector):
3014         (LayoutTestController::evaluateInWebInspector):
3015         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3016         (LayoutTestController::showWebInspector):
3017         (LayoutTestController::closeWebInspector):
3018         (LayoutTestController::evaluateInWebInspector):
3019         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3020         (LayoutTestController::showWebInspector):
3021         (LayoutTestController::closeWebInspector):
3022         (LayoutTestController::evaluateInWebInspector):
3023         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3024         (LayoutTestController::showWebInspector):
3025         (LayoutTestController::closeWebInspector):
3026         (LayoutTestController::evaluateInWebInspector):
3027
3028 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3029
3030         Reviewed by Ariyha Hidayat.
3031
3032         Pass arguments to system() as a string instead of array
3033
3034         When passed as an array entries with a space fail to translate
3035         to two arguments to the child process, so instead of manually
3036         splitting all the entries in @buildArgs we pass the whole thing
3037         as a string instead.
3038
3039         * Scripts/webkitdirs.pm:
3040
3041 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3042
3043         Reviewed by David Levin.
3044
3045         check-webkit-style misses whitespace errors for operators:
3046         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3047         https://bugs.webkit.org/show_bug.cgi?id=30021
3048
3049         * Scripts/modules/cpp_style.py:
3050         Added the operators mentioned above to the same list as == and !=.
3051
3052 2009-10-02  Julie Parent  <jparent@chromium.org>
3053
3054         Unreviewed.
3055
3056         Adding myself and Ojan Vafai as committers, because we are committers.
3057
3058         * Scripts/modules/committers.py:
3059
3060 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3061
3062         Reviewed by Adam Roben.
3063
3064         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3065         this will help the patch merging process when TryBots are used.
3066
3067         * Scripts/svn-create-patch:
3068
3069 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3070
3071         Reviewed by Simon Hausmann.
3072
3073         [Qt] Implement layoutTestController.overridePreference().
3074         https://bugs.webkit.org/show_bug.cgi?id=29970
3075
3076         * DumpRenderTree/qt/DumpRenderTree.cpp:
3077         (WebCore::WebPage::WebPage):
3078         (WebCore::WebPage::resetSettings):
3079         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3080         * DumpRenderTree/qt/jsobjects.cpp:
3081         (LayoutTestController::reset):
3082         (LayoutTestController::setPrivateBrowsingEnabled):
3083         (LayoutTestController::setPopupBlockingEnabled):
3084         (LayoutTestController::overridePreference):
3085         * DumpRenderTree/qt/jsobjects.h:
3086
3087 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3088
3089         Reviewed by Oliver Hunt.
3090
3091         Turn on ENABLE_3D_CANVAS in TOT
3092         https://bugs.webkit.org/show_bug.cgi?id=29906
3093
3094         * Scripts/build-webkit:
3095
3096 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3097
3098         Rubberstamped by Simon Hausmann.
3099
3100         Enable HTTP tests for Qt
3101
3102         * Scripts/run-webkit-tests:
3103
3104 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3105
3106         Reviewed by Dimitri Glazkov.
3107
3108         build-webkit --chromium now also works on cygwin.
3109
3110         https://bugs.webkit.org/show_bug.cgi?id=29973
3111
3112         * Scripts/webkitdirs.pm:
3113
3114 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3115
3116         Reviewed by Simon Hausmann.
3117
3118         [Qt] Don't use TCmalloc in DumpRenderTree
3119         https://bugs.webkit.org/show_bug.cgi?id=27029
3120
3121         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3122
3123         * DumpRenderTree/qt/DumpRenderTree.pro:
3124
3125 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3126
3127         Reviewed by Simon Hausmann.
3128
3129         [Qt] Implement eventSender.scheduleAsynchronousClick().
3130
3131         https://bugs.webkit.org/show_bug.cgi?id=29931
3132
3133         * DumpRenderTree/qt/jsobjects.cpp:
3134         (EventSender::scheduleAsynchronousClick):
3135         * DumpRenderTree/qt/jsobjects.h:
3136
3137 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3138
3139         Reviewed by Simon Hausmann.
3140
3141         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3142         fast/events/open-window-from-another-frame.html from the Skipped list.
3143
3144         https://bugs.webkit.org/show_bug.cgi?id=29930
3145
3146         * DumpRenderTree/qt/jsobjects.cpp:
3147         (LayoutTestController::setPopupBlockingEnabled):
3148         * DumpRenderTree/qt/jsobjects.h:
3149
3150 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3151
3152         Unreviewed.
3153
3154         Added myself to the list of committers.
3155
3156         * Scripts/modules/committers.py:
3157
3158 2009-09-30  Eric Seidel  <eric@webkit.org>
3159
3160         No review, just adding Geoff to the list of reviewers.
3161
3162         * Scripts/modules/committers.py:
3163
3164 2009-09-30  Dan Bernstein  <mitz@apple.com>
3165
3166         Reviewed by Sam Weinig.
3167
3168         Added the WebKit Layout Tests fonts that are referenced in
3169         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3170
3171         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3172         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3173
3174 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3175
3176         Reviewed by David Kilzer.
3177
3178         Make sunspider scripts work on Windows platform.
3179         https://bugs.webkit.org/show_bug.cgi?id=29656
3180
3181         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3182         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3183         * Scripts/webkitdirs.pm: currentPerlPath() added.
3184
3185 2009-09-29  Brady Eidson  <beidson@apple.com>
3186
3187         Rubberstamped by Dan Bernstein.
3188
3189         Fix license and some sorting in new files.
3190
3191         * DumpRenderTree/mac/HistoryDelegate.h:
3192         * DumpRenderTree/mac/HistoryDelegate.mm:
3193
3194 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3195
3196         Reviewed by David Kilzer.
3197
3198         Fixed how error codes are handled.
3199         https://bugs.webkit.org/show_bug.cgi?id=29898
3200
3201         * Scripts/update-webkit:
3202         * Scripts/update-webkit-chromium:
3203
3204 2009-09-29  Brady Eidson  <beidson@apple.com>
3205
3206         Reviewed by John Sullivan.
3207
3208         Updated way-out-of-date sorting throughout the dump methods/flags.
3209
3210         * DumpRenderTree/LayoutTestController.cpp:
3211         (LayoutTestController::LayoutTestController):
3212         (dumpAsPDFCallback):
3213         (dumpAsTextCallback):
3214         (dumpFrameLoadCallbacksCallback):
3215         (dumpResourceLoadCallbacksCallback):
3216         (LayoutTestController::staticFunctions):
3217
3218         * DumpRenderTree/LayoutTestController.h:
3219         (LayoutTestController::dumpAsText):
3220         (LayoutTestController::setDumpAsText):
3221         (LayoutTestController::dumpFrameLoadCallbacks):
3222         (LayoutTestController::setDumpFrameLoadCallbacks):
3223         (LayoutTestController::dumpSelectionRect):
3224         (LayoutTestController::setDumpSelectionRect):
3225         (LayoutTestController::dumpSourceAsWebArchive):
3226         (LayoutTestController::setDumpSourceAsWebArchive):
3227         (LayoutTestController::dumpStatusCallbacks):
3228         (LayoutTestController::setDumpStatusCallbacks):
3229         (LayoutTestController::dumpTitleChanges):
3230         (LayoutTestController::setDumpTitleChanges):
3231         (LayoutTestController::dumpWillCacheResponse):
3232         (LayoutTestController::setDumpWillCacheResponse):
3233
3234 2009-09-29  Brady Eidson  <beidson@apple.com>
3235
3236         Reviewed by John Sullivan.
3237
3238         WebKit Mac API should provide a delegate interface for global history.
3239         <rdar://problem/7042773> and https://webkit.org/b/29904
3240
3241         Adding the dumping of global history delegate callbacks.
3242
3243         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3244
3245         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3246         * DumpRenderTree/mac/DumpRenderTree.mm:
3247         (createWebViewAndOffscreenWindow):
3248         (allocateGlobalControllers):
3249         (shouldLogFrameLoadDelegates):
3250         (shouldLogHistoryDelegates):
3251         (runTest):
3252
3253         Dump history delegate callbacks:
3254         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3255         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3256         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3257         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3258         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3259
3260 2009-09-29  Daniel Bates  <dbates@webkit.org>
3261
3262         Reviewed by Adam Roben.
3263
3264         https://bugs.webkit.org/show_bug.cgi?id=28902
3265         
3266         Fixes an issue where the drop effect returned by Window Dump Render Tree 
3267         was always DROPEFFECT_NONE (since it was hard coded to do so).
3268         
3269         This patch corrects this issue by determining the actual drop effect 
3270         performed by the corresponding drag-and-drop operation so that we can 
3271         return it.
3272
3273         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3274         (DraggingInfo::DraggingInfo):
3275         (DraggingInfo::performedDropEffect): Added method.
3276         (DraggingInfo::setPerformedDropEffect): Added method.
3277         * DumpRenderTree/win/EventSender.cpp:
3278         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3279         Moved delete draggingInfo to UIDelegate::doDragDrop.
3280         * DumpRenderTree/win/UIDelegate.cpp:
3281         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3282
3283 2009-09-29  Dan Bernstein  <mitz@apple.com>
3284
3285         Reviewed by Adam Roben.
3286
3287         Remove copying of unnecessary or nonexistent files from the ImageDiff
3288         post-build event.
3289
3290         * DumpRenderTree/win/ImageDiff.vcproj:
3291
3292 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3293
3294         Reviewed by David Kilzer.
3295
3296         [Qt] Make build-webkit script work on Windows
3297         https://bugs.webkit.org/show_bug.cgi?id=29802
3298
3299         * Scripts/run-webkit-tests:
3300         * Scripts/webkitdirs.pm:
3301          - Removed unnecessary -p switch for mkdir on Windows.
3302          - Use canonical path, which uses slashes or backslashes depends on platform.
3303          - isWindows() only test for Windows and not for Cyqwin.
3304
3305 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3306
3307         Reviewed by Simon Hausmann.
3308
3309         Fix time measurement in build-webkit after refactoring done in r48853.
3310
3311         * Scripts/build-webkit:
3312
3313 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3314
3315         Reviewed by Tor Arne Vestbø.
3316
3317         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
3318         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
3319
3320         * DumpRenderTree/qt/DumpRenderTree.cpp:
3321         (WebCore::WebPage::WebPage):
3322
3323 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
3324
3325         Reviewed by Simon Hausmann.
3326
3327         [Qt] Implement eventSender.contextClick().
3328         https://bugs.webkit.org/show_bug.cgi?id=29821
3329
3330         * DumpRenderTree/qt/jsobjects.cpp:
3331         (EventSender::contextClick):
3332         * DumpRenderTree/qt/jsobjects.h:
3333
3334 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3335
3336         Reviewed by Eric Seidel.
3337
3338         Add experimentalWebSocketsEnabled in WebPreferences.
3339         https://bugs.webkit.org/show_bug.cgi?id=28941
3340
3341         * DumpRenderTree/mac/DumpRenderTree.mm:
3342         (resetDefaultsToConsistentValues):
3343         * DumpRenderTree/win/DumpRenderTree.cpp:
3344         (resetDefaultsToConsistentValues):
3345
3346 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
3347
3348         Reviewed by David Kilzer.
3349
3350         Integrated chromium port building into webkit tools update-webkit and
3351         build-webkit.
3352
3353         https://bugs.webkit.org/show_bug.cgi?id=29749
3354
3355         * Scripts/build-webkit: When --chromium is specified, will build
3356           the chromium port (currently only Mac is supported).
3357         * Scripts/update-webkit: When --chromium is specified, delegates to
3358           update-webkit-chromium.
3359         * Scripts/webkitdirs.pm: Added chromium specific defs.
3360         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
3361           chromium port's dependencies and update its project files.
3362
3363 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3364
3365         Unreviewed.
3366
3367         Add myself to list of committers.
3368
3369         * Scripts/modules/committers.py:
3370
3371 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3372
3373         Reviewed by Darin Adler.
3374
3375         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
3376         https://bugs.webkit.org/show_bug.cgi?id=29771
3377
3378         * Scripts/run-webkit-tests:
3379
3380 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3381
3382         Reviewed by Simon Hausmann.
3383
3384         [Qt] Implement layoutTestController.waitForPolicyDelegate.
3385         https://bugs.webkit.org/show_bug.cgi?id=25037
3386
3387         * DumpRenderTree/qt/DumpRenderTree.cpp:
3388         (WebCore::WebPage::acceptNavigationRequest):
3389         * DumpRenderTree/qt/DumpRenderTree.pro:
3390         * DumpRenderTree/qt/jsobjects.cpp:
3391         (LayoutTestController::reset):
3392         (LayoutTestController::notifyDone):
3393         (LayoutTestController::waitForPolicyDelegate):
3394         * DumpRenderTree/qt/jsobjects.h:
3395         (LayoutTestController::waitForPolicy):
3396
3397 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3398
3399         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
3400
3401         Reviewed by Eric Seidel.
3402
3403         The -o|--open switch uses the open(1) command on Mac OS X to
3404         open the bug URL in the default web browser.  If there are
3405         similar mechanisms on other platforms, they may be added later.
3406
3407         * Scripts/mark-bug-fixed:
3408         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
3409         options.
3410         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
3411         code into main() and extracted prompting code into
3412         _prompt_user_for_correctness().
3413         (MarkBugFixed._open_bug_in_web_browser): Added.
3414         (MarkBugFixed._prompt_user_for_correctness): Added.
3415         (MarkBugFixed.main): Added logging code from
3416         _determine_bug_id_and_svn_revision().  Added code to call
3417         _open_bug_in_web_browser() if the switch is set.  Added code to
3418         call _prompt_user_for_correctness() when needed.
3419         * Scripts/modules/bugzilla.py:
3420         (Bugzilla.short_bug_url_for_bug_id): Added.
3421
3422 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3423
3424         svn-unapply and svn-apply don't work when used outside multiple svn working directories
3425
3426         <http://webkit.org/b/29744>
3427         <rdar://problem/7252905>
3428
3429         Reviewed by Eric Seidel.
3430
3431         Some users have a workflow where svn-create-patch, svn-apply and
3432         svn-unapply are used outside of multiple svn working
3433         directories.  Instead of aborting the scripts in these cases,
3434         print a warning and assume that Subversion is being used.
3435
3436         * Scripts/VCSUtils.pm:
3437         (determineVCSRoot): Call warn() instead of die() if both isGit()
3438         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
3439         to enforce the assumption about Subversion, then return
3440         determineSVNRoot().
3441         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
3442         VCSUtils.pm.  They both already cache their values and checking
3443         here is redundant since determineVCSRoot() is called later.
3444
3445 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
3446
3447         Reviewed by Gustavo Noronha.
3448
3449         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3450         https://bugs.webkit.org/show_bug.cgi?id=29689
3451
3452         Load test fonts through FontConfig before each test.
3453         This ensures a more proper rendering of the tests.
3454
3455         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3456         (initializeFonts):
3457         (runTest):
3458         (main):
3459         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
3460         * GNUmakefile.am:
3461
3462 2009-09-25  David Kilzer  <ddkilzer@apple.com>
3463
3464         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
3465
3466         Reviewed by Eric Seidel.
3467
3468         * Scripts/mark-bug-fixed:
3469         (MarkBugFixed.__init__): Added -u|--update-only switch to list
3470         of parse options.
3471         (MarkBugFixed.main): When -u|--update-only is specified, add a
3472         comment to the bug without marking it Resolved/Fixed.
3473
3474 2009-09-25  Darin Adler  <darin@apple.com>
3475
3476         Reviewed by Geoffrey Garen.
3477
3478         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
3479         out, just as we do for the resources directory.
3480
3481 2009-09-25  Adam Barth  <abarth@webkit.org>
3482
3483         Unreviewed.  Added Tony to committers.py because he's a
3484         committer now.
3485
3486         * Scripts/modules/committers.py:
3487
3488 2009-09-25  Eric Seidel  <eric@webkit.org>
3489
3490         Reviewed by Simon Fraser.
3491
3492         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
3493         https://bugs.webkit.org/show_bug.cgi?id=28624
3494
3495         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
3496
3497         * DumpRenderTree/mac/DumpRenderTree.mm:
3498         (resetDefaultsToConsistentValues):
3499
3500 2009-09-25  Eric Seidel  <eric@webkit.org>
3501
3502         Reviewed by Adam Barth.
3503
3504         commit-queue should auto-retry patches which fail to commit due to out of date files
3505         https://bugs.webkit.org/show_bug.cgi?id=28316
3506
3507         * Scripts/bugzilla-tool:
3508          - Handle new CheckoutNeedsUpdate exception.
3509         * Scripts/modules/logging_unittest.py:
3510          - Call the ScriptError constructor correctly (this test had regressed).
3511         * Scripts/modules/scm.py:
3512          - Added the ability to define custom error handlers for run_command
3513            and added a commit_error_handler which throws CheckoutNeedsUpdate
3514            instead of ScriptError.
3515          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
3516         * Scripts/modules/scm_unittest.py:
3517          - Added tests of new error handlers.
3518
3519 2009-09-25  Eric Seidel  <eric@webkit.org>
3520
3521         Reviewed by Adam Barth.
3522
3523         commit-queue should give better feedback when failing a patch
3524         https://bugs.webkit.org/show_bug.cgi?id=29316
3525
3526         * Scripts/bugzilla-tool:
3527          - Update ScriptError uses to the new constructor format.
3528          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
3529            so that we can print to both stdout as well as an output buffer for error reporting.
3530          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
3531          - Use e.message_with_output() when failing a patch (this is the real fix here).
3532            I also removed use of "This patch will require manual commit." as that's not always true.
3533          - Add missing word "bug" from log message.
3534         * Scripts/modules/scm.py:
3535          - Make ScriptError save a bunch more data so that error messages can be nicer.
3536          - Update ScriptError callers.
3537
3538 2009-09-24  John Gregg  <johnnyg@google.com>
3539
3540         Reviewed by Eric Seidel.
3541
3542         Enable switch for notifications (experimental) in Page Settings
3543         https://bugs.webkit.org/show_bug.cgi?id=28930
3544
3545         Now that desktop notifications are controlled by run-time switch,
3546         set that switch to true for DumpRenderTree.
3547
3548         * DumpRenderTree/mac/DumpRenderTree.mm:
3549         (resetDefaultsToConsistentValues):
3550         * DumpRenderTree/win/DumpRenderTree.cpp:
3551         (resetDefaultsToConsistentValues):
3552         * DumpRenderTree/win/UIDelegate.cpp:
3553         (UIDelegate::QueryInterface):
3554
3555 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
3556
3557         wx build fix. SnowLeopard fixes for Mac dependencies.
3558
3559         * wx/build/build_utils.py:
3560         * wx/build/settings.py:
3561         * wx/install-unix-extras:
3562
3563 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3564
3565         Reviewed by Oliver Hunt.
3566
3567         Add support for DRT to send mouse wheel events.
3568
3569         https://bugs.webkit.org/show_bug.cgi?id=29348
3570         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
3571
3572         * DumpRenderTree/gtk/EventSender.cpp:
3573         (mouseWheelToCallback):
3574
3575 2009-09-17  Eric Seidel  <eric@webkit.org>
3576
3577         Reviewed by David Levin.
3578
3579         commit-queue needs web-based status reporting
3580         https://bugs.webkit.org/show_bug.cgi?id=29307
3581
3582         Add a first-pass web-based status for the commit-queue.
3583         The bot is currently reachable at:
3584         http://webkit-commit-queue.appspot.com/
3585
3586         * CommitQueueStatus/app.yaml: Added.
3587          - Application description file required by App Engine.
3588         * CommitQueueStatus/filters/__init__.py: Added.
3589          - Required by python to treat 'filters' as a module.
3590         * CommitQueueStatus/filters/webkit_extras.py: Added.
3591          - Support for turning 'bug 123' and 'patch 123' into links.
3592            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
3593         * CommitQueueStatus/index.html: Added.
3594         * CommitQueueStatus/index.yaml: Added.
3595          - Some auto-generated file from app engine.
3596         * CommitQueueStatus/queue_status.py: Added.
3597          - The core logic of this bot.  We could eventually split this file out into pieces.
3598         * CommitQueueStatus/stylesheets/main.css: Added.
3599          - Some basic lame-o CSS to make the page look less awful.
3600         * CommitQueueStatus/update_status.html: Added.
3601          - The form that the commit-queue (or a human) can use to update the status.
3602         * Scripts/bugzilla-tool:
3603          - Add some very basic update_status calls.
3604         * Scripts/modules/statusbot.py: Added.
3605          - Knows how to post to the CommitQueueStatus web application.
3606
3607 2009-09-24  David Kilzer  <ddkilzer@apple.com>
3608
3609         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
3610
3611         Reviewed by Adam Roben.
3612
3613         * Scripts/mark-bug-fixed:
3614         (MarkBugFixed.__init__): Added -m|--comment switch to list of
3615         parse options.
3616         (MarkBugFixed.main): When specified, prepend comment from
3617         -m|--comment command-line switch to the bug comment.
3618
3619 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3620
3621         Reviewed by Jan Alonzo.
3622
3623         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
3624         https://bugs.webkit.org/show_bug.cgi?id=29693
3625
3626         Show the window, to be able to synthesize events correctly.
3627
3628         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3629         (runTest):
3630         (main):
3631
3632 2009-09-24  Oliver Hunt  <oliver@apple.com>
3633
3634         Reviewed by NOBODY(rollout)
3635
3636         Roll out r48712 as it is incorrect.
3637
3638         * DumpRenderTree/mac/ObjCController.m:
3639         (+[ObjCController isSelectorExcludedFromWebScript:]):
3640         (+[ObjCController webScriptNameForSelector:]):
3641
3642 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
3643
3644         Reviewed by Eric Seidel.
3645
3646         https://bugs.webkit.org/show_bug.cgi?id=29005
3647         The indices of RuntimeArray should be enumerated like for a regular array.
3648
3649         * DumpRenderTree/mac/ObjCController.m:
3650         (+[ObjCController isSelectorExcludedFromWebScript:]):
3651         (+[ObjCController webScriptNameForSelector:]):
3652         (-[ObjCController arrayOfString]):
3653
3654 2009-09-23  David Kilzer  <ddkilzer@apple.com>
3655
3656         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
3657
3658         Reviewed by Darin Adler.
3659
3660         Also fixed a bug where specifying a revision on the command-line
3661         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
3662
3663         * Scripts/bugzilla-tool: Updated module import statements.
3664         (parse_bug_id): Removed.  Moved to bugzilla.py.
3665         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
3666         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
3667         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
3668         (BugzillaTool.__init__): Removed mark-fixed subcommand.
3669         * Scripts/mark-bug-fixed: Added.
3670         * Scripts/modules/bugzilla.py:
3671         (parse_bug_id): Added.  Moved from bugzilla-tool.
3672         * Scripts/modules/comments.py: Added.
3673         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
3674         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
3675
3676 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
3677
3678         Reviewed by Eric Seidel.
3679         
3680          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
3681          "false" in non-implemented stub for setAlwaysAcceptCookies.
3682          https://bugs.webkit.org/show_bug.cgi?id=29661
3683
3684         * DumpRenderTree/win/DumpRenderTree.vcproj:
3685         * DumpRenderTree/win/DumpRenderTree.cpp:
3686
3687 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3688
3689         Reviewed by Xan Lopez.
3690
3691         [GTK] need to dump number of pending unload handlers
3692         https://bugs.webkit.org/show_bug.cgi?id=29685
3693
3694         Implement dumping of the number of pending unload handlers.
3695
3696         The following tests will pass:
3697
3698           fast/loader/unload-form-about-blank.html
3699           fast/loader/unload-form-post-about-blank.html
3700           fast/loader/unload-form-post.html
3701           fast/loader/unload-form.html
3702           fast/loader/unload-hyperlink.html
3703           fast/loader/unload-javascript-url.html
3704           fast/loader/unload-reload.html
3705           fast/loader/unload-window-location.html
3706
3707         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3708         (getFrameNameSuitableForTestResult):
3709         (webViewLoadFinished):
3710
3711 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
3712
3713         Reviewed by Eric Seidel.
3714
3715         js tests should move into jstests subdirectory instead of resources/
3716         https://bugs.webkit.org/show_bug.cgi?id=25880
3717
3718         Remove support of resources directory.
3719
3720         * Scripts/make-script-test-wrappers:
3721
3722 2009-09-22  Eric Seidel  <eric@webkit.org>
3723
3724         No review, only fixing typo (missing space character).
3725
3726         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
3727
3728         * Scripts/run-webkit-tests:
3729
3730 2009-09-22  Eric Seidel  <eric@webkit.org>
3731
3732         Reviewed by Darin Adler.
3733
3734         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
3735         https://bugs.webkit.org/show_bug.cgi?id=29220
3736
3737         * Scripts/run-webkit-tests:
3738
3739 2009-09-22  Eric Seidel  <eric@webkit.org>
3740
3741         Reviewed by David Kilzer.
3742
3743         svn-apply can't handle single-line binary file additions
3744         https://bugs.webkit.org/show_bug.cgi?id=29100
3745
3746         Fixed the regexp and added a unit test.
3747
3748         * Scripts/modules/scm_unittest.py:
3749         * Scripts/svn-apply:
3750
3751 2009-09-11  Eric Seidel  <eric@webkit.org>
3752
3753         Reviewed by David Kilzer.
3754
3755         post-diff and post-commits should be able to find bug urls in ChangeLogs.
3756         https://bugs.webkit.org/show_bug.cgi?id=29206
3757
3758         * Scripts/bugzilla-tool:
3759          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
3760          - Rename --no-comment to --add-log-as-comment and reverse behavior.
3761            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
3762          - Split out code into helper functions to try and make execute() more legible.
3763          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
3764          - Fallback to bug urls in commit diffs, instead of just in commit messages,
3765            meaning post-commits will now find bug urls in ChangeLogs.
3766
3767 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3768
3769         Reviewed by Maciej Stachowiak.
3770
3771         --parse-only parameter wasn't passed to SunSpider/sunspider script.
3772         https://bugs.webkit.org/show_bug.cgi?id=29611
3773
3774         * Scripts/run-sunspider: Missing parameter passing added.
3775
3776 2009-09-20  David Kilzer  <ddkilzer@apple.com>
3777
3778         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
3779
3780         Reviewed by Mark Rowe.
3781
3782         The require statement is like the use statement, except that it
3783         is run during script execution instead of during the 'BEGIN'
3784         phase.  This makes it possible to change @INC before the require
3785         statement is run.  See 'require' and 'use' in the perlfunc(1)
3786         manpage and 'BEGIN' in perlmod(1) manpage.
3787
3788         * Scripts/run-webkit-tests: Replace eval statement with require
3789         statement.
3790
3791 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
3792
3793         wx build fixes. Fix the config name under git and allow users to specify
3794         their own waf install for experimenting with new versions.
3795
3796         * Scripts/webkitdirs.pm:
3797         * wx/build/settings.py:
3798
3799 2009-09-18  Alex Milowski  <alex@milowski.com>
3800
3801         Reviewed by Maciej Stachowiak.
3802
3803         Added checkWebCoreMathMLSupport and hasMathMLSupport to support 
3804         checking for whether MathML tests should be run
3805
3806         * Scripts/run-webkit-tests:
3807         * Scripts/webkitdirs.pm:
3808
3809 2009-08-28  Darin Adler  <darin@apple.com>
3810
3811         Reviewed by Mark Rowe.
3812
3813         Break more of run-webkit-tests into separate functions
3814         https://bugs.webkit.org/show_bug.cgi?id=29497
3815
3816         Some small steps toward improving run-webkit-tests. My goal is to
3817         refactor much more of the script into functions. Later we can add
3818         parallel test running to the tool. But better structure may help
3819         even if someone decides to translate this into another scripting
3820         language instead.
3821
3822         * Scripts/run-webkit-tests: Break more pieces of the script into
3823         seprate functions. Added readSkippedFiles, findTestsToRun, and
3824         printResults functions. Removed custom code to skip results.html
3825         and instead just put it into the ignoredFiles hash. Fixed some
3826         indentation. Sorted function declarations, global variables,
3827         and options at the top of the file alphabetically so they're not
3828         in a semi-random order.
3829
3830 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
3831
3832         wx build fix, add missing dependency.
3833
3834         * wx/browser/wscript:
3835
3836 2009-09-16  Mark Rowe  <mrowe@apple.com>
3837
3838         Split the SnowLeopard build across a few machines.
3839
3840         * BuildSlaveSupport/build.webkit.org-config/config.json:
3841
3842 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
3843
3844         wx build fix to support monolithic builds on Windows.
3845
3846         * wx/build/wxpresets.py:
3847
3848 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
3849
3850         wx build fix, improve debug support and 2.9 support on MSW.
3851
3852         * wx/build/settings.py:
3853         * wx/build/wxpresets.py:
3854
3855 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3856
3857         Blind try at fixing new test failure on Windows.
3858
3859         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3860         (FrameLoadDelegate::didReceiveTitle):
3861
3862 2009-09-15  Alex Milowski  <alex@milowski.com>
3863
3864         Reviewed by Tor Arne Vestbø.
3865
3866         Added mathml toggle
3867
3868         * Scripts/build-webkit:
3869
3870 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
3871
3872         wx build fix. Allow waf build to support Python < 2.6.
3873
3874         * wx/build/waf_extensions.py:
3875
3876 2009-09-14  Chris Marrin  <cmarrin@apple.com>
3877
3878         Reviewed by Oliver Hunt.
3879
3880         Add LayoutTests infrastructure to enable and disable webgl tests.
3881         https://bugs.webkit.org/show_bug.cgi?id=29254
3882
3883         * Scripts/run-webkit-tests:
3884         * Scripts/webkitdirs.pm:
3885
3886 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
3887
3888         Reviewed by Darin Adler.
3889         
3890         Add --iterations option to run-webkit-tests to repeat the tests N times
3891         https://bugs.webkit.org/show_bug.cgi?id=29263
3892
3893         When run with --iterations N, run-webkit-tests will repeat the tests N times.
3894
3895         * Scripts/run-webkit-tests:
3896
3897 2009-09-14  Brady Eidson  <beidson@apple.com>
3898
3899         Not reviewed, maybe should've been:
3900
3901         Cleaning up more Windows-specific fallout from the fix for:
3902         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
3903
3904         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3905         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter, 
3906           and call the correct method to get the Sender.
3907
3908 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
3909
3910         GTK build fix.
3911
3912         Unreviewed.
3913
3914         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3915         (AccessibilityController::setLogScrollingStartEvents):
3916
3917 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
3918
3919         DRT/test part of
3920         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
3921         jumping to a named anchor
3922
3923         https://bugs.webkit.org/show_bug.cgi?id=28899
3924
3925         Reviewed by Adam Roben.
3926
3927         * DumpRenderTree/AccessibilityController.cpp:
3928         (logScrollingStartEventsCallback):
3929         Turn on logging of scrolling start events.
3930         (AccessibilityController::getJSClass):
3931         Add a "logScrollingStartEvents" to the AccessibilityController's JS
3932         class definition.
3933         (AccessibilityController::resetToConsistentState):
3934         Turn off logging of scrolling start events.
3935
3936         * DumpRenderTree/AccessibilityController.h:
3937         Declare setLogScrollingStartEvents(). Add a member for the scrolling
3938         start event hook.
3939
3940         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
3941         (AccessibilityController::setLogScrollingStartEvents):
3942         Stubbed.
3943
3944         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3945         (AccessibilityController::AccessibilityController):
3946         Initialize the handle to 0.
3947         (logEventProc):
3948         Renamed from logFocusEventProc; now logs scrolling start events, too.
3949         Removed the assertion that the event is a focus event. Added a switch
3950         to print a message for focus, scrolling start, and other, unknown
3951         events.
3952         (AccessibilityController::setLogFocusEvents):
3953         Changed to use logEventProc.
3954         (AccessibilityController::setLogScrollingStartEvents):
3955         If turning logging off, unhook the scrolling start event hook, and clear
3956         the member holding the handle. If turning on, query for the root
3957         accessible, so that accessibility is enabled for the WebView, and call
3958         SetWinEventHook to setup an event hook using logEventProc as the
3959         callback function.
3960
3961 2009-09-14  Brady Eidson  <beidson@apple.com>
3962
3963         Windows build fix.
3964
3965         * DumpRenderTree/LayoutTestController.cpp:
3966         (setAuthenticationPasswordCallback):
3967         (setAuthenticationUsernameCallback):
3968         
3969         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3970         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3971
3972 2009-09-14  Brady Eidson  <beidson@apple.com>
3973
3974         Reviewed by Alexey Proskuryakov.
3975
3976         Safari 4 cannot be used to update firmware on Linksys routers.
3977         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
3978
3979         Add the ability for DRT to handle authentication challenges.
3980
3981         * DumpRenderTree/LayoutTestController.cpp:
3982         (setAuthenticationPasswordCallback):
3983         (setAuthenticationUsernameCallback):
3984         (setHandlesAuthenticationChallengesCallback):
3985         (LayoutTestController::staticFunctions):
3986
3987         * DumpRenderTree/LayoutTestController.h:
3988         (LayoutTestController::handlesAuthenticationChallenges):
3989         (LayoutTestController::setHandlesAuthenticationChallenges):
3990         (LayoutTestController::authenticationUsername):
3991         (LayoutTestController::setAuthenticationUsername):
3992         (LayoutTestController::authenticationPassword):
3993         (LayoutTestController::setAuthenticationPassword):
3994
3995         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3996         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
3997
3998         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3999         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
4000         * DumpRenderTree/win/ResourceLoadDelegate.h:
4001
4002 2009-09-12  Mark Rowe  <mrowe@apple.com>
4003
4004         Reviewed by Dan Bernstein.
4005
4006         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
4007
4008         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
4009         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
4010
4011         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
4012         (NPP_New):
4013
4014 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
4015
4016         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
4017
4018         * wx/build/build_utils.py:
4019         * wx/build/settings.py:
4020
4021 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
4022
4023         Reviewed by Tor Arne Vestbø.
4024
4025         [Qt] Build fix for windows build.
4026
4027         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
4028
4029 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
4030
4031         Fix typo accidently landed in last commit.
4032
4033         * wx/build/settings.py:
4034
4035 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
4036
4037         wx build fix, error out if using the wrong Python.
4038
4039         * wx/build/settings.py:
4040
4041 2009-09-13  Xan Lopez  <xlopez@igalia.com>
4042
4043         Build fix for GTK+ < 2.14.
4044
4045         Do not use gtk_widget_get_window, access the window directly
4046         through the struct.
4047
4048         * DumpRenderTree/gtk/EventSender.cpp:
4049         (contextClickCallback):
4050         (mouseDownCallback):
4051         (mouseUpCallback):
4052         (mouseMoveToCallback):
4053         (keyDownCallback):
4054
4055 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
4056
4057         Reviewed by Xan Lopez and Jan Alonzo.
4058
4059         [GTK] EventSender does not set 'window' property on synthesized GDK events
4060         https://bugs.webkit.org/show_bug.cgi?id=29169
4061
4062         Set the window property on synthesized GDK events in the GTK+ EventSender.
4063
4064         * DumpRenderTree/gtk/EventSender.cpp:
4065         (contextClickCallback):
4066         (mouseDownCallback):
4067         (mouseUpCallback):
4068         (mouseMoveToCallback):
4069         (keyDownCallback):
4070
4071 2009-09-12  Drew Wilson  <atwilson@google.com>
4072
4073         Reviewed by Mark Rowe.
4074
4075         run-webkit-tests has a timeout value that is too low
4076         https://bugs.webkit.org/show_bug.cgi?id=29223
4077
4078         * Scripts/run-webkit-tests:
4079         Changed timeout value to 20 seconds to avoid timing out too early.
4080
4081 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
4082
4083         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
4084         architectures are supported for building wxWebKit.
4085
4086         * wx/build/settings.py:
4087
4088 2009-09-11  Eric Seidel  <eric@webkit.org>
4089
4090         Reviewed by David Levin.
4091
4092         bugzilla-tool rollout threw exception under svn
4093         https://bugs.webkit.org/show_bug.cgi?id=29211
4094
4095         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
4096         * Scripts/modules/scm_unittest.py: add testing for this fix.
4097
4098 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
4099
4100         Add myself to the committers list.
4101
4102         * Scripts/modules/committers.py:
4103
4104 2009-09-11  Eric Seidel  <eric@webkit.org>
4105
4106         Reviewed by Adam Barth.
4107
4108         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
4109         https://bugs.webkit.org/show_bug.cgi?id=29201
4110
4111         * Scripts/bugzilla-tool:
4112
4113 2009-09-11  Adam Roben  <aroben@apple.com>
4114
4115         Make commit-log-editor move common prefixes to the top of the log
4116
4117         Fies <http://webkit.org/b/29190> commit-log-editor should move common
4118         prefixes to the top of the commit log
4119
4120         Reviewed by Darin Adler.
4121
4122         * Scripts/commit-log-editor: Find and remove the longest common prefix
4123         ending in a double newline from each ChangeLog entry, then put that
4124         common prefix at the top of the commit log.
4125         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
4126         removes, and returns the longest common prefix ending in a double
4127         newline from a hash of strings
4128
4129 2009-09-11  Eric Seidel  <eric@webkit.org>
4130
4131         Fix obvious typo in previous commit, no review.
4132
4133         bugzilla-tool should automate rollouts
4134         https://bugs.webkit.org/show_bug.cgi?id=26715
4135
4136         * Scripts/bugzilla-tool: add back missing "scm" argument.
4137
4138 2009-09-11  Eric Seidel  <eric@webkit.org>
4139
4140         Reviewed by Adam Barth.
4141
4142         bugzilla-tool should automate rollouts
4143         https://bugs.webkit.org/show_bug.cgi?id=26715
4144
4145         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
4146         The --complete-rollout option will automatically land and update the bug.
4147         Eventually --complete-rollout will be default, but that will require more testing.
4148
4149         This first pass is good enough for others to try and file bugs about.
4150
4151         * Scripts/bugzilla-tool:
4152          - Move modified_changelogs into scm.py.
4153          - Move svn_revision_from_commit_text logic into scm.py.
4154          - Add RolloutCommit command.
4155         * Scripts/modules/bugzilla.py:
4156          - Add reopen_bug command used by RolloutCommit.
4157         * Scripts/modules/scm.py:
4158          - Add functions to support RolloutCommit.
4159          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
4160          - Add a str() call so that svn_commit_log can take a numeric argument.
4161          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
4162          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
4163         * Scripts/modules/scm_unittest.py:
4164          - Add read_from_path for easy file reading.
4165          - Put test4 on a new line to make reverts work w/o conflict.
4166          - Add an "svn update" call so that the checkout revision matches the server revision.
4167          - Add tests for svn_revision_from_commit_text.
4168          - Add a simple test for apply_reverse_diff.
4169          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
4170          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
4171
4172 2009-09-11  Adam Roben  <aroben@apple.com>
4173
4174         Get user script/stylesheet tests running on Windows
4175
4176         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
4177         skipped on Windows
4178
4179         Reviewed by John Sullivan.
4180
4181         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
4182         against comsuppw.lib so we can use _bstr_t.
4183
4184         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
4185         order, added #include of comutil.h for _bstr_t.
4186
4187         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
4188         (LayoutTestController::addUserScript):
4189         (LayoutTestController::addUserStyleSheet):
4190         Implemented. Implementations were based on those in
4191         LayoutTestControllerMac.mm.
4192
4193 2009-09-10  David Kilzer  <ddkilzer@apple.com>
4194
4195         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help 
4196
4197         Reviewed by Mark Rowe.
4198
4199         * Scripts/run-webkit-tests: Updated to make -h switch show help.
4200
4201 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
4202
4203         Reviewed by Alexey Proskuryakov.
4204
4205         Add WebCore/websockets directory in wx build system.
4206         https://bugs.webkit.org/show_bug.cgi?id=28038
4207
4208         * wx/build/settings.py:
4209
4210 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
4211
4212         [GTK] EventSender does not properly convert some keyDown strings
4213         https://bugs.webkit.org/show_bug.cgi?id=29119
4214
4215         Add more keyDown string to character code conversions for GTK+ EventSender.
4216
4217         * DumpRenderTree/gtk/EventSender.cpp:
4218         (keyDownCallback):
4219
4220 2009-09-09  Steve Block  <steveblock@google.com>
4221
4222         Reviewed by Maciej Stachowiak.
4223
4224         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
4225         https://bugs.webkit.org/show_bug.cgi?id=29080
4226
4227         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
4228
4229 2009-09-09  Eric Seidel  <eric@webkit.org>
4230
4231         Reviewed by Eric Carlson.
4232
4233         reviewer/committer lookups are backwards
4234         https://bugs.webkit.org/show_bug.cgi?id=29113
4235
4236         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
4237
4238         * Scripts/modules/bugzilla.py:
4239         * Scripts/modules/committers.py:
4240
4241 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
4242
4243         Reviewed by Eric Seidel.
4244
4245         svn-unapply doesn't revert directories correctly
4246         https://bugs.webkit.org/show_bug.cgi?id=29065
4247
4248         * Scripts/svn-unapply: Make svnStatus consistently return status
4249         lines including a newline.
4250         * Scripts/svn-apply: Keep svnStatus in sync with the one in
4251         svn-unapply, in lieu of moving it to a common file.
4252
4253 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
4254
4255         Reviewed by Eric Seidel.
4256
4257         svn-apply doesn't handle changes to files copied to new directories properly
4258         https://bugs.webkit.org/show_bug.cgi?id=29059
4259
4260         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
4261         additions if we know that we've just copied a file to this name.
4262
4263 2009-09-09  Eric Seidel  <eric@webkit.org>
4264
4265         Reviewed by David Levin.
4266
4267         commit-queue hangs if a builder has never built
4268         https://bugs.webkit.org/show_bug.cgi?id=29091
4269
4270         * Scripts/modules/buildbot.py:
4271         * Scripts/modules/buildbot_unittest.py:
4272
4273 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
4274
4275         Reviewed by Gustavo Noronha.
4276
4277         [GTK] DumpRenderTree needs eventSender object and implementation
4278         https://bugs.webkit.org/show_bug.cgi?id=25990
4279
4280         Implements most of the EventSender object's functionality for
4281         the DumpRenderTree tool. Implementation still lacks support
4282         for drag and drop tests and forward leaps.
4283
4284         Based on work by Holger Hans Peter Freyther.
4285
4286         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4287         (runTest): Focus on the view before loading a new test.
4288         (webViewWindowObjectCleared):
4289         * DumpRenderTree/gtk/EventSender.cpp: Added.
4290         (getDragModeCallback):
4291         (setDragModeCallback):
4292         (leapForwardCallback):
4293         (contextClickCallback):
4294         (updateClickCount):
4295         (mouseDownCallback):
4296         (mouseUpCallback):
4297         (mouseMoveToCallback):
4298         (beginDragWithFilesCallback):
4299         (replaySavedEvents):
4300         (keyDownCallback):
4301         (textZoomInCallback):
4302         (textZoomOutCallback):
4303         (zoomPageInCallback):
4304         (zoomPageOutCallback):
4305         (getClass):
4306         (makeEventSender):
4307         * DumpRenderTree/gtk/EventSender.h: Added.
4308         * GNUmakefile.am: Add build rules for EventSender.
4309
4310 2009-09-09  Daniel Bates  <dbates@webkit.org>
4311
4312         Reviewed by Adam Roben.
4313         
4314         https://bugs.webkit.org/show_bug.cgi?id=28953
4315
4316         Added pre- and post- build events so that on build failure, the file 
4317         buildfailed is written to the directory $(WebKitOutputDir).
4318
4319         * WinLauncher/WinLauncher.vcproj:
4320
4321 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4322
4323         Unreviewed.
4324
4325         Add myself to list of committers.
4326
4327         * Scripts/modules/committers.py:
4328
4329 2009-09-08  Eric Seidel  <eric@webkit.org>
4330
4331         Reviewed by David Levin.
4332
4333         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
4334         https://bugs.webkit.org/show_bug.cgi?id=28605
4335         https://bugs.webkit.org/show_bug.cgi?id=28916
4336
4337         * Scripts/bugzilla-tool:
4338          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
4339            comment now that it's used for rejecting patches for invalid committers too.
4340          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
4341          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
4342         * Scripts/modules/bugzilla.py:
4343          - Make _parse_attachment_element not validate reviewer/committer.
4344          - Share flag parsing code in _parse_attachment_flag.
4345          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
4346          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
4347          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
4348         * Scripts/modules/bugzilla_unittest.py:
4349          - Update this test to no longer expect committer/reviewer validation.
4350         * Scripts/modules/committers.py:
4351          - Return None on failed lookups instead of raising Exceptions.
4352    &nb