afc65aaad0c411db1e3ec85a4bc6c9e042c08975
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-12-15  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Anders Carlsson.
4
5         WebKit2: Can't add files to an <input type=file>
6         https://bugs.webkit.org/show_bug.cgi?id=51087
7
8         * MiniBrowser/mac/BrowserWindowController.m:
9         (runOpenPanel):
10         (-[BrowserWindowController awakeFromNib]):
11         Add simple implementation of runOpenPanel callback.
12
13         * MiniBrowser/win/BrowserView.cpp:
14         (BrowserView::create):
15         * WebKitTestRunner/TestController.cpp:
16         (WTR::createOtherPage):
17         (WTR::TestController::initialize):
18         Stub out runOpenPanel callback. 
19
20 2010-12-14  Eric Seidel  <eric@webkit.org>
21
22         Reviewed by Adam Barth.
23
24         commit-queue should upload failure diffs when tests flake
25         https://bugs.webkit.org/show_bug.cgi?id=51051
26
27         To make this testable I needed to pipe FileSystem down onto tool.
28         We've wanted it there for a long time anyway.
29
30         This patch is kinda a big hack.  But we don't have a nice
31         way to read results.html files.  I think this will need further
32         revision before this code actually feels clean.
33
34         As part of testing this change, I had to make MockBugzilla.create_bug
35         actually return an id (like it should) which required updating
36         a few other unit test results (for the better).
37
38         The results_matching_keys change in layouttestresults/rebasline
39         was an alternate path which I decided not to use in the end, but
40         I left the change as it seemed an improvement.
41
42         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
43         * Scripts/webkitpy/common/net/layouttestresults.py:
44         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
45         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
46         * Scripts/webkitpy/tool/commands/queues.py:
47         * Scripts/webkitpy/tool/commands/rebaseline.py:
48         * Scripts/webkitpy/tool/main.py:
49         * Scripts/webkitpy/tool/mocktool.py:
50
51 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
52
53         Reviewed by James Robinson.
54
55         new-run-webkit-tests ignores trailing EOL differences in text tests
56         https://bugs.webkit.org/show_bug.cgi?id=36983
57
58         Changed the handling of new-line characters within new-run-webkit-tests
59         to match old-run-webkit-tests.  Differences in leading and trailing empty
60         lines in text expectation files are no longer ignored.
61
62         * Scripts/webkitpy/layout_tests/port/base.py:
63         * Scripts/webkitpy/layout_tests/port/test.py:
64         Added unit tests.  Removed old duplicate unit test entries.
65         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
66
67 2010-12-15  Ojan Vafai  <ojan@chromium.org>
68
69         Reviewed by Adam Barth.
70
71         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
72         https://bugs.webkit.org/show_bug.cgi?id=51125
73
74         * QueueStatusServer/templates/statusbubble.html:
75
76 2010-12-15  Darin Adler  <darin@apple.com>
77
78         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
79
80 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
81
82         Unreviewed, rolling out r74117.
83         http://trac.webkit.org/changeset/74117
84         https://bugs.webkit.org/show_bug.cgi?id=51113
85
86         This broke the GTK1 build. (Requested by mrobinson on
87         #webkit).
88
89         * Scripts/webkitdirs.pm:
90
91 2010-12-15  Lucas Forschler  <lforschler@apple.com>
92
93         Reviewed by Stephanie Lewis.
94
95         https://bugs.webkit.org/show_bug.cgi?id=51117
96         Add a new leopard WK2 test bot
97
98         * BuildSlaveSupport/build.webkit.org-config/config.json:
99
100 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
101
102         Reviewed by Martin Robinson.
103
104         Change generate-forwarding-headers.pl for GTK port usage 
105         (https://bugs.webkit.org/show_bug.cgi?id=37369)
106
107         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
108
109 2010-12-14  Kent Tamura  <tkent@chromium.org>
110
111         Reviewed by Jian Li.
112
113         [DRT/Chromium] Remove another unnecessary error message
114         https://bugs.webkit.org/show_bug.cgi?id=51083
115
116         * DumpRenderTree/chromium/WebViewHost.cpp:
117         (WebViewHost::didInvalidateRect):
118
119 2010-12-14  Lucas Forschler  <lforschler@apple.com>
120
121         Reviewed by Stephanie Lewis.
122
123         Add a new Leopard Debug Test WK2 Bot
124
125         * BuildSlaveSupport/build.webkit.org-config/config.json:
126
127 2010-12-14  Ojan Vafai  <ojan@chromium.org>
128
129         Fix python unittests after http://trac.webkit.org/changeset/74070.
130
131         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
132
133 2010-12-14  Kent Tamura  <tkent@chromium.org>
134
135         Reviewed by Jian Li.
136
137         [DRT/Chromium] Remove a unnecessary error message
138         https://bugs.webkit.org/show_bug.cgi?id=51069
139
140         * DumpRenderTree/chromium/WebViewHost.cpp:
141         (WebViewHost::paintInvalidatedRegion):
142
143 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
144
145         Reviewed by Ojan Vafai.
146
147         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
148         https://bugs.webkit.org/show_bug.cgi?id=48926
149
150         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
151         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
152
153 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
154
155         Reviewed by Eric Seidel.
156
157         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
158         https://bugs.webkit.org/show_bug.cgi?id=50231
159
160         Guard CONFIG+=link_pkgconfig with !symbian.
161
162         * DumpRenderTree/qt/DumpRenderTree.pro:
163         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
164         * WebKitTestRunner/qt/WebKitTestRunner.pro:
165
166 2010-12-14  Philippe Normand  <pnormand@igalia.com>
167
168         Reviewed by Ojan Vafai.
169
170         [new-run-webkit-tests] expectations parsing is slow
171         https://bugs.webkit.org/show_bug.cgi?id=50635
172
173         Avoid expensive iteration of all the tests when checking if a test
174         file is to be skipped or not.
175
176         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
177         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
178         * Scripts/webkitpy/layout_tests/port/test.py:
179
180 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
181
182         Reviewed by Xan Lopez.
183
184         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
185         https://bugs.webkit.org/show_bug.cgi?id=27048
186
187         Add support in DRT for checking whether an accessibility UI
188         element is focusable and/or focused. Implemented for GTK.
189
190         * DumpRenderTree/AccessibilityUIElement.cpp:
191         (getIsFocusedCallback): New.
192         (getIsFocusableCallback): New.
193         (AccessibilityUIElement::getJSClass): Add the new available
194         callbacks for isFocused and isFocusable.
195         * DumpRenderTree/AccessibilityUIElement.h:
196         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
197         (AccessibilityUIElement::isFocused): New, implemented by checking
198         whether the related AtkState value is in the object's state set.
199         (AccessibilityUIElement::isFocusable): Ditto.
200         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
201         (AccessibilityUIElement::isFocused): New, dummy implementation.
202         (AccessibilityUIElement::isFocusable): Ditto.
203         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
204         (AccessibilityUIElement::isFocused): Ditto.
205         (AccessibilityUIElement::isFocusable): Ditto.
206
207 2010-12-14  Eric Seidel  <eric@webkit.org>
208
209         Reviewed by Ojan Vafai.
210
211         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
212         https://bugs.webkit.org/show_bug.cgi?id=50715
213
214         This patch makes webkit-patch print the following:
215
216         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
217         Install a 64-bit git for better performance, see:
218         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
219
220         I wrote this mostly because I have approximately 8 machines that I use
221         and making sure each one is using a good Git install seemed folly.
222         webkit-patch makes a lot of git calls, so using a fast git can shave
223         several seconds in every invocation.  See the webkit-dev thread for more info.
224
225         This message will print twice during 'webkit-patch upload',
226         once from webkit-patch and once from check-webkit-style.
227
228         Unfortunately there is no good way to test this due to how machine-dependent
229         the code is.  I considered writing a test for the log message, but it seemed not worth it.
230
231         * Scripts/webkitpy/common/checkout/scm.py:
232
233 2010-12-13  Eric Seidel  <eric@webkit.org>
234
235         Reviewed by Adam Barth.
236
237         FlakyTestReporter doesn't understand bots running from multiple email addresses
238         https://bugs.webkit.org/show_bug.cgi?id=50960
239
240         This explains at least one of the dupes of:
241         https://bugs.webkit.org/show_bug.cgi?id=50863
242         that we saw filed by the commit-queue this morning.
243         I think the other one was explained by my previous fix to result counting code.
244
245         Since this is really hard to test with a unit test, instead I
246         create a new (possibly useful in the future) command
247         which given a layout test path will return you
248         the one bug which our tools would assume it the flaky test bug.
249         If some other script wants to use bug-for-test we'll
250         need to extend it with some options like --create-if-missing or similar.
251
252         * Scripts/webkitpy/common/net/bugzilla/bug.py:
253         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
254         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
255         * Scripts/webkitpy/tool/commands/__init__.py:
256         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
257
258 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
259
260         Reviewed by James Robinson.
261
262         Add option to build-webkit to not build WebKit2
263         https://bugs.webkit.org/show_bug.cgi?id=50988
264         
265         Add support for a --no-webkit2 option to build-webkit. It seems to save
266         ~1 minute from clean builds and ~10 seconds from no-op builds.
267
268         * Scripts/build-webkit:
269
270 2010-12-13  Lucas Forschler  <lforschler@apple.com>
271
272         Reviewed by Dave Kilzer.
273
274         Update iexploder from 1.3.2 to 1.7.2
275         Move 1.3.2 into its own subdir
276         Add 1.7.2 into its own subdir
277         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
278
279         * Scripts/run-iexploder-tests:
280         * Scripts/update-iexploder-cssproperties:
281         * iExploder/CHANGELOG.txt: Removed.
282         * iExploder/LICENSE.txt: Removed.
283         * iExploder/README.txt: Removed.
284         * iExploder/htdocs: Removed.
285         * iExploder/iexploder-1.3.2: Added.
286         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
287         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
288         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
289         * iExploder/iexploder-1.3.2/htdocs: Added.
290         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
291         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
292         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
293         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
294         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
295         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
296         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
297         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
298         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
299         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
300         * iExploder/iexploder-1.3.2/tools: Added.
301         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
302         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
303         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
304         * iExploder/iexploder-1.7.2: Added.
305         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
306         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
307         * iExploder/iexploder-1.7.2/README.txt: Added.
308         * iExploder/iexploder-1.7.2/output: Added.
309         * iExploder/iexploder-1.7.2/src: Added.
310         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
311         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
312         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
313         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
314         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
315         * iExploder/iexploder-1.7.2/src/css-properties: Added.
316         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
317         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
318         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
319         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
320         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
321         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
322         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
323         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
324         * iExploder/iexploder-1.7.2/src/css-values: Added.
325         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
326         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
327         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
328         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
329         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
330         * iExploder/iexploder-1.7.2/src/headers: Added.
331         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
332         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
333         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
334         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
335         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
336         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
337         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
338         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
339         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
340         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
341         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
342         * iExploder/iexploder-1.7.2/src/html-tags: Added.
343         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
344         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
345         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
346         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
347         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
348         * iExploder/iexploder-1.7.2/src/html-values: Added.
349         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
350         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
351         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
352         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
353         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
354         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
355         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
356         * iExploder/iexploder-1.7.2/src/index.html: Added.
357         * iExploder/iexploder-1.7.2/src/media: Added.
358         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
359         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
360         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
361         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
362         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
363         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
364         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
365         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
366         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
367         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
368         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
369         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
370         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
371         * iExploder/iexploder-1.7.2/src/mime-types: Added.
372         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
373         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
374         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
375         * iExploder/iexploder-1.7.2/src/protocols: Added.
376         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
377         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
378         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
379         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
380         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
381         * iExploder/iexploder-1.7.2/src/version.rb: Added.
382         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
383         * iExploder/iexploder-1.7.2/testcases: Added.
384         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
385         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
386         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
387         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
388         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
389         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
390         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
391         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
392         * iExploder/iexploder-1.7.2/tools: Added.
393         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
394         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
395         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
396         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
397         * iExploder/tools: Removed.
398
399 2010-12-13  Sam Weinig  <sam@webkit.org>
400
401         Reviewed by Anders Carlsson.
402
403         Remove associated page concept from WKView constructor
404         https://bugs.webkit.org/show_bug.cgi?id=50983
405
406         Step 1: Remove associate page constructors from WKView and make
407         all views use the shared namespace for the context.
408
409         * TestWebKitAPI/PlatformWebView.h:
410         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
411         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
412         * WebKitTestRunner/PlatformWebView.h:
413         * WebKitTestRunner/TestController.cpp:
414         (WTR::createOtherPage):
415         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
416         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
417         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
418
419 2010-12-13  Sam Weinig  <sam@webkit.org>
420
421         Reviewed by Anders Carlsson.
422
423         Change the WebKit2 public API so there is no explicit WKPageNamespace object
424         https://bugs.webkit.org/show_bug.cgi?id=50898
425
426         * MiniBrowser/mac/AppDelegate.h:
427         * MiniBrowser/mac/AppDelegate.m:
428         * MiniBrowser/mac/BrowserWindowController.h:
429         * MiniBrowser/mac/BrowserWindowController.m:
430         * MiniBrowser/win/BrowserView.cpp:
431         Convert MiniBrowser to not use PageNamespaces.
432
433         * TestWebKitAPI/PlatformWebView.h:
434         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
435         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
436         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
437         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
438         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
439         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
440         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
441         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
442         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
443         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
444         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
445         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
446         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
447         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
448         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
449         Convert TestWebKitAPI to not use PageNamespaces.
450
451         * WebKitTestRunner/PlatformWebView.h:
452         * WebKitTestRunner/TestController.cpp:
453         * WebKitTestRunner/TestController.h:
454         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
455         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
456         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
457         Convert WebKitTestRunner to not use PageNamespaces.
458
459 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
460
461         Reviewed by Eric Seidel.
462
463         webkit-patch rollout should be able to do multi-revision rollouts
464         https://bugs.webkit.org/show_bug.cgi?id=33336
465
466         Make it possible to pass more than one revision to webkit-patch.
467
468         * Scripts/webkitpy/common/checkout/api.py:
469         * Scripts/webkitpy/common/checkout/changelog.py:
470         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
471         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
472         * Scripts/webkitpy/tool/commands/download.py:
473         * Scripts/webkitpy/tool/commands/download_unittest.py:
474         * Scripts/webkitpy/tool/mocktool.py:
475         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
476         * Scripts/webkitpy/tool/steps/revertrevision.py:
477
478 2010-12-13  Eric Seidel  <eric@webkit.org>
479
480         Unreviewed.
481
482         Teach webkit-patch how to search bugzilla
483         https://bugs.webkit.org/show_bug.cgi?id=50500
484
485         webkit-patch bug-search fails when there is only one result.
486         Turns out we needed a bit more logic in our result count parsing code.
487
488         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
489         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
490
491 2010-12-13  Antti Koivisto  <antti@apple.com>
492
493         Reviewed by Alexey Proskuryakov.
494
495         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
496         https://bugs.webkit.org/show_bug.cgi?id=50758
497
498         * DumpRenderTree/LayoutTestController.cpp:
499         (setSerializeHTTPLoadsCallback):
500         (LayoutTestController::staticFunctions):
501         * DumpRenderTree/LayoutTestController.h:
502         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
503         (LayoutTestController::setSerializeHTTPLoads):
504         * DumpRenderTree/mac/DumpRenderTree.mm:
505         (resetDefaultsToConsistentValues):
506         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
507         (LayoutTestController::setSerializeHTTPLoads):
508         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
509         (LayoutTestController::setSerializeHTTPLoads):
510
511 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
512
513         Reviewed by Ojan Vafai.
514
515         Remove "use-drt" option from test step command line, since the option was removed in r73748.
516         https://bugs.webkit.org/show_bug.cgi?id=50936
517
518         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
519
520 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
521
522         Reviewed by Csaba Osztrogonác.
523
524         Add revlink to BuildBot status
525         https://bugs.webkit.org/show_bug.cgi?id=50914
526
527         This adds a hyperlink to trac changeset on the revision numbers. 
528
529         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
530
531 2010-12-13  Andras Becsi  <abecsi@webkit.org>
532
533         Reviewed by Csaba Osztrogonác.
534
535         [Qt][WK2] Fix build if WebKitTools are not available
536         https://bugs.webkit.org/show_bug.cgi?id=50242
537
538         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
539         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
540         * MiniBrowser/DerivedSources.pro: Added.
541
542 2010-12-13  Eric Seidel  <eric@webkit.org>
543
544         Reviewed by Adam Barth.
545
546         EWS Queues should remove orpahned pyc files before starting
547         https://bugs.webkit.org/show_bug.cgi?id=50904
548
549         A previous check added a platform.py which caused
550         EWS bots on some platforms to hit an import exception.
551         The platform.py file was removed in a subsequent commit, but
552         the EWS bots in question stayed stuck.  This change will
553         fix those bots once restarted (and prevent this in the future).
554
555         I also went ahead and unified start-queue and start-commit-queue
556         since they were nearly identical.  I also added bot_id support
557         to both force all EWSes to have bot ids as well as get rid of the one
558         remaining reason why I had my own copies of these scripts.
559         Hopefully this will be enough to get all the other bot admins
560         (ahem, Adam, ahem) to move to using these checked in copies as well.
561
562         * EWSTools/start-commit-queue.sh: Removed.
563         * EWSTools/start-queue.sh:
564
565 2010-10-28  MORITA Hajime  <morrita@google.com>
566
567         Reviewed by Ojan Vafai.
568
569         spellcheck does not check pasted text
570         https://bugs.webkit.org/show_bug.cgi?id=40092
571
572         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
573         to control the setting.
574
575         * DumpRenderTree/LayoutTestController.cpp:
576         (setAsynchronousSpellCheckingEnabledCallback):
577         (LayoutTestController::staticFunctions):
578         * DumpRenderTree/LayoutTestController.h:
579         * DumpRenderTree/chromium/LayoutTestController.h:
580         * DumpRenderTree/chromium/LayoutTestController.cpp:
581         (LayoutTestController::LayoutTestController):
582         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
583         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
584         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
585         * DumpRenderTree/mac/DumpRenderTree.mm:
586         (resetDefaultsToConsistentValues):
587         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
588         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
589         * DumpRenderTree/qt/LayoutTestControllerQt.h:
590         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
591         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
592         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
593         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
594         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
595         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
596
597 2010-12-12  Sam Weinig  <sam@webkit.org>
598
599         Reviewed by Anders Carlsson.
600
601         Fix failing API test. It turns out that a pop-state event
602         is sent before every fragment navigation, so we have to test
603         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
604
605         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
606         (TestWebKitAPI::didSameDocumentNavigationForFrame):
607
608 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
609
610         Reviewed by Eric Seidel.
611
612         [GTK] Add new-run-webkit-tests support to gtk
613         https://bugs.webkit.org/show_bug.cgi?id=50681
614
615         Adding the basic support to run the new-run-webkit-tests.
616
617         * Scripts/webkitpy/layout_tests/port/gtk.py:
618
619 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
620
621         Reviewed by Kenneth Rohde Christiansen.
622
623         [Qt] Mock DeviceOrientation client for DRT
624         https://bugs.webkit.org/show_bug.cgi?id=47490
625
626         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
627         (WebCore::DumpRenderTree::DumpRenderTree):
628         (WebCore::DumpRenderTree::~DumpRenderTree):
629         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
630         (LayoutTestController::setMockDeviceOrientation):
631
632 2010-12-11  Philippe Normand  <pnormand@igalia.com>
633
634         Reviewed by Gustavo Noronha Silva.
635
636         [GTK] launcher: disable the Mozilla-style fullscreen API
637         https://bugs.webkit.org/show_bug.cgi?id=50874
638
639         Disabling the fullscreen API until its implementation for GTK is
640         mature enough. The webview setting for it is already FALSE by
641         default.
642
643         * GtkLauncher/main.c:
644         (createWindow):
645
646 2010-12-10  Eric Seidel  <eric@webkit.org>
647
648         Reviewed by Adam Barth.
649
650         commit-queue flaky test messages show cryptic version information for mac os x
651         https://bugs.webkit.org/show_bug.cgi?id=50864
652
653         Turns out platform.platform() returns kernel version information
654         which isn't helpful, and just plain confusing on Mac
655         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
656
657         So I've updated PlatformInfo.display_name() to special case
658         mac.  I also found a bad use of sys.platform in the process
659         and fixed that.  (sys.platform always returns 'darwin' on mac).
660
661         * Scripts/webkitpy/common/system/platforminfo.py:
662         * Scripts/webkitpy/common/system/user.py:
663         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
664         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
665         * Scripts/webkitpy/tool/commands/queues_unittest.py:
666
667 2010-12-10  Eric Seidel  <eric@webkit.org>
668
669         Unreviewed.
670
671         Exception seen while reporting flaky test with commit-queue.
672         Just a missing include.
673
674         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
675         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
676
677 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
678
679         Reviewed by Eric Seidel.
680
681         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
682         https://bugs.webkit.org/show_bug.cgi?id=50796
683
684         Also updating the test code to use JSONResultsGeneratorBase and
685         to improve test coverage for incremental cases.
686
687         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
688         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
689
690 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
691
692         Reviewed by Darin Adler.
693
694         prepare-ChangeLog --help doesn't mention --bug shorthand -b
695         https://bugs.webkit.org/show_bug.cgi?id=50835
696
697         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
698
699 2010-12-10  Eric Seidel  <eric@webkit.org>
700
701         Reviewed by Adam Barth.
702
703         Bugs created by the commit-queue should all block on a master bug
704         https://bugs.webkit.org/show_bug.cgi?id=50857
705
706         This makes all bugs created by the commit-queue block on:
707         https://bugs.webkit.org/show_bug.cgi?id=50856
708
709         In the process of testing this, I found that the existing
710         create_bug code was wrong.  I also found that existing
711         unit tests for create-rollout used invalid values
712         for options.blocks.  I fixed both issues and tested.
713
714         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
715         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
716         * Scripts/webkitpy/tool/commands/commandtest.py:
717         * Scripts/webkitpy/tool/commands/download_unittest.py:
718         * Scripts/webkitpy/tool/commands/upload_unittest.py:
719         * Scripts/webkitpy/tool/mocktool.py:
720         * Scripts/webkitpy/tool/steps/options.py:
721
722 2010-12-10  Eric Seidel  <eric@webkit.org>
723
724         Reviewed by Adam Barth.
725
726         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
727         https://bugs.webkit.org/show_bug.cgi?id=50853
728
729         I also discovered when doing this that the code was posting
730         the comment on the wrong bug, but that's fixed here too.
731
732         * Scripts/webkitpy/common/net/bugzilla/bug.py:
733         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
734         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
735         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
736         * Scripts/webkitpy/tool/commands/queues_unittest.py:
737         * Scripts/webkitpy/tool/mocktool.py:
738
739 2010-12-10  Anders Carlsson  <andersca@apple.com>
740
741         Reviewed by John Sullivan.
742
743         Make WKContextGetStatistics gather global statistics
744         https://bugs.webkit.org/show_bug.cgi?id=50850
745
746         Remove the code that gets the statistics and fills in the per context
747         statistics information for now.
748
749         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
750         (-[BrowserStatisticsWindowController refreshStatistics:]):
751
752 2010-12-10  Eric Seidel  <eric@webkit.org>
753
754         Unreviewed.
755
756         commit-queue should report port/platform information when commenting on flaky test bugs
757         https://bugs.webkit.org/show_bug.cgi?id=50839
758
759         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
760         which was only used by new run webkit tests (and clearly not unit tested).
761
762         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
763         * Scripts/webkitpy/tool/main.py:
764         * Scripts/webkitpy/tool/mocktool.py:
765
766 2010-12-10  Eric Seidel  <eric@webkit.org>
767
768         Reviewed by Tony Chang.
769
770         commit-queue should report port/platform information when commenting on flaky test bugs
771         https://bugs.webkit.org/show_bug.cgi?id=50839
772
773         This was a suggestion from Tony Chang this morning.
774         I added a platform.py class so I could easily mock the platform call,
775         but that may not be the final solution for this mocking.
776         We'll try it and see.
777
778         * Scripts/webkitpy/common/system/platform.py: Added.
779         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
780         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
781         * Scripts/webkitpy/tool/commands/queues_unittest.py:
782         * Scripts/webkitpy/tool/main.py:
783         * Scripts/webkitpy/tool/mocktool.py:
784
785 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
786
787         Reviewed by Joseph Pecoraro.
788
789         Bug 43455 - [Qt]: Implement Application Cache Quotas
790         https://bugs.webkit.org/show_bug.cgi?id=43455
791
792         Introduce functions to allow new appcache layout test origin-quota.html
793         to work correctly under Qt.
794
795         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
796         (WebCore::DumpRenderTree::DumpRenderTree):
797         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
798         * DumpRenderTree/qt/DumpRenderTreeQt.h:
799
800         Introduce functions to allow new appcache layout test origin-quota.html
801         to be successful under qt. Changes required because LayoutTestControllerQt
802         does not inherit from LayoutController.
803
804         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
805         (LayoutTestController::reset):
806         (LayoutTestController::clearAllApplicationCaches):
807         (LayoutTestController::setApplicationCacheOriginQuota):
808         * DumpRenderTree/qt/LayoutTestControllerQt.h:
809         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
810         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
811
812 2010-12-10  Eric Seidel  <eric@webkit.org>
813
814         Reviewed by Adam Barth.
815
816         Move buildbot.py into its own module so we can split it out into one-file-per-class
817         https://bugs.webkit.org/show_bug.cgi?id=50806
818
819         We're adding more buildbot logic these days, so it makes sense
820         to give buildbot its own module.
821
822         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
823         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
824         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
825         * Scripts/webkitpy/common/net/failuremap.py:
826         * Scripts/webkitpy/common/net/regressionwindow.py:
827         * Scripts/webkitpy/tool/commands/rebaseline.py:
828
829 2010-12-10  Tony Chang  <tony@chromium.org>
830
831         Reviewed by Eric Seidel.
832
833         Use FileSystem::remove when cleaning up http lock files
834         https://bugs.webkit.org/show_bug.cgi?id=50830
835
836         * Scripts/webkitpy/layout_tests/port/http_lock.py:
837
838 2010-12-10  Joone Hur  <joone@kldp.org>
839
840         Reviewed by Martin Robinson.
841
842         [GTK] DRT needs layoutTestController.setCacheModel
843         https://bugs.webkit.org/show_bug.cgi?id=50705
844         
845         webkit_set_cache_mode() is called to set the cache model.
846         
847         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
848         (LayoutTestController::setCacheModel): Set the cache model. 
849
850 2010-12-10  Tony Chang  <tony@chromium.org>
851
852         Reviewed by Ojan Vafai.
853
854         [chromium] remove --use-drt and add --use-test-shell
855         https://bugs.webkit.org/show_bug.cgi?id=50701
856
857         * Scripts/webkitpy/common/config/ports.py:
858         * Scripts/webkitpy/common/config/ports_unittest.py:
859         * Scripts/webkitpy/layout_tests/port/chromium.py:
860         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
861         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
862         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
863         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
864         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
865         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
866         * Scripts/webkitpy/layout_tests/port/webkit.py:
867         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
868         * Scripts/webkitpy/style/checkers/test_expectations.py:
869         * Scripts/webkitpy/tool/commands/queries.py:
870
871 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
872
873         Reviewed by Steve Block.
874
875         [Chromium] Implement mocks for client-based geolocation
876         https://bugs.webkit.org/show_bug.cgi?id=46895
877
878         * DumpRenderTree/chromium/LayoutTestController.cpp:
879         (LayoutTestController::setGeolocationPermission):
880         (LayoutTestController::setMockGeolocationPosition):
881         (LayoutTestController::setMockGeolocationError):
882         * DumpRenderTree/chromium/LayoutTestController.h:
883         * DumpRenderTree/chromium/WebViewHost.cpp:
884         (WebViewHost::geolocationClient):
885         (WebViewHost::geolocationClientMock):
886         (WebViewHost::reset):
887         * DumpRenderTree/chromium/WebViewHost.h:
888
889 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
890
891         Reviewed by Martin Robinson.
892
893         [GTK] Add hasSpellingMarker support to the DRT
894         https://bugs.webkit.org/show_bug.cgi?id=50739
895
896         Implemented the hasSpellingMarker to support spelling tests.
897
898         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
899         (LayoutTestController::hasSpellingMarker):
900
901 2010-12-10  Eric Seidel  <eric@webkit.org>
902
903         Reviewed by Ojan Vafai.
904
905         webkit-patch: not possible to use build-and-test with local commits
906         https://bugs.webkit.org/show_bug.cgi?id=33378
907
908         Make --no-clean not even check if we have local commits.
909         It's unclear to me why the code was originally written this way.
910         I was unable to dig up a reason from svn history.
911
912         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
913         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
914
915 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
916
917         Reviewed by Martin Robinson.
918
919         [GTK] AX: implement isEnabled in DRT
920         https://bugs.webkit.org/show_bug.cgi?id=50814
921
922         Implement AccessibilityUIElement::isEnabled() for GTK.
923
924         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
925         (checkElementState): New function to refactor common code.
926         (AccessibilityUIElement::isEnabled): Implement this by checking
927         the current state of the AtkObject.
928         (AccessibilityUIElement::isSelected): Use the new
929         checkElementState function.
930
931 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
932
933         Reviewed by Kenneth Rohde Christiansen.
934
935         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
936         https://bugs.webkit.org/show_bug.cgi?id=50750
937
938         * MiniBrowser/qt/BrowserView.cpp:
939         (BrowserView::BrowserView):
940         * MiniBrowser/qt/BrowserView.h:
941         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
942         (WTR::WebView::WebView):
943
944 2010-12-10  Joone Hur  <joone@kldp.org>
945
946         Reviewed by Xan Lopez.
947
948         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
949         https://bugs.webkit.org/show_bug.cgi?id=50808
950
951         Unskipping the following test cases:
952         userscripts/mixed-case-stylesheet.html
953         userscripts/simple-stylesheet.html
954         userscripts/user-style-all-frames.html
955
956         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
957         (LayoutTestController::addUserStyleSheet):
958
959 2010-12-10  Joone Hur  <joone@kldp.org>
960
961         Reviewed by Eric Seidel.
962
963         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
964         https://bugs.webkit.org/show_bug.cgi?id=50783
965
966         This patch allows to unskip the following test cases:
967         printing/page-rule-selection.html
968         printing/page-format-data.html
969
970         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
971         (LayoutTestController::pageProperty): Added.
972         (LayoutTestController::isPageBoxVisible): Ditto.
973         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
974         (LayoutTestController::addUserStyleSheet): Ditto.
975
976 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
977
978         Reviewed by Kenneth Rohde Christiansen.
979
980         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
981
982         A menu allows to switch QNAM back to the same thread.
983
984         * QtTestBrowser/launcherwindow.cpp:
985         (LauncherWindow::initializeView):
986         (LauncherWindow::createChrome):
987         (LauncherWindow::toggleThreadedQnam):
988         * QtTestBrowser/launcherwindow.h:
989         (WindowOptions::WindowOptions):
990         * QtTestBrowser/webpage.cpp:
991         (WebPage::WebPage):
992         (WebPage::setQnamThreaded):
993         * QtTestBrowser/webpage.h:
994         (QnamThread::QnamThread):
995         (QnamThread::~QnamThread):
996         (QnamThread::networkAccessManager):
997         (QnamThread::run):
998
999 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1000
1001         Reviewed by Xan Lopez.
1002
1003         [Gtk] style="font-family: courier" makes text disappear
1004         https://bugs.webkit.org/show_bug.cgi?id=47452
1005
1006         Add a test that verifies that fonts without valid charmaps are
1007         never selected.
1008
1009         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1010         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1011         that has no valid charmap.
1012         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1013         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1014         settings which may disable selection of bitmap fonts.
1015
1016 2010-12-10  Eric Seidel  <eric@webkit.org>
1017
1018         Unreviewed.
1019
1020         The commit-queue should file bugs about flaky tests it encounters
1021         https://bugs.webkit.org/show_bug.cgi?id=50803
1022
1023         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1024         Now it's tested.
1025
1026         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1027         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1028
1029 2010-12-10  Eric Seidel  <eric@webkit.org>
1030
1031         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1032
1033         The commit-queue should file bugs about flaky tests it encounters
1034         https://bugs.webkit.org/show_bug.cgi?id=50803
1035
1036         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1037
1038 2010-12-09  Eric Seidel  <eric@webkit.org>
1039
1040         Reviewed by Adam Barth.
1041
1042         The commit-queue should file bugs about flaky tests it encounters
1043         https://bugs.webkit.org/show_bug.cgi?id=50803
1044
1045         This change got a bit big.  I also added a new config.urls file
1046         because I needed to share the view_source_url code with committervalidator.py.
1047
1048         This adds a new class FlakyTestReporter which holds all the logic about
1049         reporting flaky tests to bugzilla.
1050
1051         Right now this code knows how to look up bugs for flaky tests.
1052         If it can't find a bug filed from the commit-queue, it will open a new
1053         one, ccing the relevant people and adding information about the failure.
1054
1055         It is not yet smart enough to chase down duplicate chains, or to include
1056         the actual failure diff.  But those can be added in later iterations.
1057
1058         * Scripts/webkitpy/common/checkout/api.py:
1059         * Scripts/webkitpy/common/checkout/changelog.py:
1060         * Scripts/webkitpy/common/checkout/commitinfo.py:
1061         * Scripts/webkitpy/common/config/committervalidator.py:
1062         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1063         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1064         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1065         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1066         * Scripts/webkitpy/tool/bot/irc_command.py:
1067         * Scripts/webkitpy/tool/bot/sheriff.py:
1068         * Scripts/webkitpy/tool/commands/download.py:
1069         * Scripts/webkitpy/tool/commands/queues.py:
1070         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1071         * Scripts/webkitpy/tool/comments.py:
1072         * Scripts/webkitpy/tool/mocktool.py:
1073         * Scripts/webkitpy/tool/steps/commit.py:
1074
1075 2010-12-09  Eric Seidel  <eric@webkit.org>
1076
1077         Reviewed by Adam Barth.
1078
1079         Teach webkit-patch how to search bugzilla
1080         https://bugs.webkit.org/show_bug.cgi?id=50500
1081
1082         This is a step towards teaching webkitpy how to file
1083         new bugs for flaky tests and update them when new flakes occur.
1084
1085         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1086         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1087         * Scripts/webkitpy/tool/commands/__init__.py:
1088         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1089
1090 2010-12-09  Adam Barth  <abarth@webkit.org>
1091
1092         Reviewed by Ojan Vafai.
1093
1094         commit-queue errors out due to local commits
1095         https://bugs.webkit.org/show_bug.cgi?id=50766
1096
1097         We seem to be tripping over having local commits in the working copy a
1098         lot recently.  I don't quite fully understand what the issue is, but
1099         this patch attempts to solve the problem by adding an explicit clean
1100         step before processing a patch.  Previously, we did the cleaning as
1101         part of the apply-attachment step, so this might not actually fix the
1102         problem.
1103
1104         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1105         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1106         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1107
1108 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1109
1110         Reviewed by Ojan Vafai.
1111
1112         Make new-run-webkit-tests --lint-test-files log slightly better
1113         messages and return -1 if lint fails. Remove the
1114         'suppress_errors' keyword param to the TestExpectationsFile
1115         class, and clean up logging and exception raising for error
1116         handling. Also add more unit tests and clean up the unit test code a bit.
1117
1118         https://bugs.webkit.org/show_bug.cgi?id=50205
1119
1120         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1121         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1122         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1123         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1124         * Scripts/webkitpy/layout_tests/port/chromium.py:
1125         * Scripts/webkitpy/style/checkers/test_expectations.py:
1126         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1127
1128 2010-12-09  Tony Chang  <tony@chromium.org>
1129
1130         Unreviewed, fix for windows code.  We were catching the wrong
1131         exception in Windows.
1132
1133         * Scripts/webkitpy/common/system/filesystem.py:
1134
1135 2010-12-09  Antonio Gomes  <agomes@rim.com>
1136
1137         Reviewed by Martin Robinson.
1138
1139         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1140         https://bugs.webkit.org/show_bug.cgi?id=48429
1141
1142         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1143
1144         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1145         (LayoutTestController::workerThreadCount):
1146
1147 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1148
1149         Reviewed by Martin Robinson.
1150
1151         [GTK] Support the Mozilla-style Fullscreen Javascript API
1152         https://bugs.webkit.org/show_bug.cgi?id=50572
1153
1154         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1155         make DRT update the Chrome when the WebView settings have been
1156         reset to consistent values.
1157
1158         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1159         (resetDefaultsToConsistentValues):
1160         * GtkLauncher/main.c:
1161         (create_window):
1162         * Scripts/build-webkit:
1163
1164 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1165
1166         Reviewed by Tor Arne Vestbø
1167
1168         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1169         https://bugs.webkit.org/show_bug.cgi?id=50742
1170
1171         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1172
1173         * Scripts/webkitdirs.pm:
1174
1175 2010-12-09  Joone Hur  <joone@kldp.org>
1176
1177          Reviewed by Martin Robinson.
1178
1179          [GTK] Support for viewport meta tag
1180          https://bugs.webkit.org/show_bug.cgi?id=45443
1181
1182          Add support for testing the viewport properties for WebKitGtk.
1183
1184          * DumpRenderTree/LayoutTestController.cpp:
1185          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1186          (LayoutTestController::staticFunctions):
1187          * DumpRenderTree/LayoutTestController.h:
1188          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1189          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1190          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1191          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1192          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1193          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1194          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1195          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1196          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1197          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1198
1199 2010-12-08  William Siegrist <wsiegrist@apple.com>
1200
1201         Reviewed by Eric Seidel.
1202
1203         Migrate buildbot.py from xmlrpc to json.
1204         https://bugs.webkit.org/show_bug.cgi?id=50647
1205
1206         * Scripts/webkitpy/common/net/buildbot.py:
1207
1208 2010-12-08  Tony Chang  <tony@chromium.org>
1209
1210         Reviewed by Eric Seidel.
1211
1212         make starting the websocket server more reliable on windows
1213         https://bugs.webkit.org/show_bug.cgi?id=50712
1214
1215         * Scripts/webkitpy/common/system/filesystem.py:
1216         (remove): Substitute method for os.remove to retry on error on Windows
1217         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1218         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1219
1220 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1221
1222         Reviewed by Adam Roben.
1223
1224         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1225         https://bugs.webkit.org/show_bug.cgi?id=50656
1226
1227         * MiniBrowser/mac/BrowserWindowController.m:
1228         (-[BrowserWindowController awakeFromNib]):
1229         Indicate that exceededDatabaseQuota is not implemented.
1230         * MiniBrowser/win/BrowserView.cpp:
1231         (BrowserView::create):
1232         Ditto.
1233         * WebKitTestRunner/TestController.cpp:
1234         (WTR::createOtherPage):
1235         Ditto.
1236         (WTR::TestController::initialize):
1237         Ditto.
1238
1239 2010-12-08  Antonio Gomes  <agomes@rim.com>
1240
1241         Reviewed by Martin Robinson.
1242
1243         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1244         https://bugs.webkit.org/show_bug.cgi?id=48429
1245
1246         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1247         * webkit_gc_collect_javascript_objects;
1248         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1249         * webkit_gc_count_javascript_objects;
1250         * webkit_web_frame_layout.
1251
1252         These were all only used by GTK+ DRT.
1253
1254         * DumpRenderTree/gtk/EventSender.cpp:
1255         (dispatchEvent):
1256         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1257         (GCController::collect):
1258         (GCController::collectOnAlternateThread):
1259         (GCController::getJSObjectCount):
1260
1261 2010-12-07  Tony Chang  <tony@chromium.org>
1262
1263         Reviewed by Ojan Vafai.
1264
1265         [chromium] force NRWT to use DRT
1266         https://bugs.webkit.org/show_bug.cgi?id=50359
1267
1268         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1269
1270 2010-12-06  Sam Weinig  <sam@webkit.org>
1271
1272         Reviewed by Anders Carlsson.
1273
1274         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1275         https://bugs.webkit.org/show_bug.cgi?id=50584
1276
1277         * MiniBrowser/mac/BrowserWindowController.m:
1278         (didSameDocumentNavigationForFrame):
1279         (-[BrowserWindowController awakeFromNib]):
1280         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1281         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1282         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1283         (TestWebKitAPI::TEST):
1284         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1285         (WTR::InjectedBundlePage::InjectedBundlePage):
1286         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1287         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1288         * WebKitTestRunner/TestController.cpp:
1289         (WTR::TestController::initialize):
1290
1291 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1292
1293         Reviewed by Ojan Vafai.
1294
1295         Make TestResultsServer return 404 for non-existing results files.
1296         https://bugs.webkit.org/show_bug.cgi?id=50581
1297
1298         * TestResultServer/handlers/testfilehandler.py:
1299
1300 2010-12-06  Tony Chang  <tony@chromium.org>
1301
1302         Reviewed by Ojan Vafai.
1303
1304         [chromium] fix an assert hit in DRT
1305         https://bugs.webkit.org/show_bug.cgi?id=50575
1306
1307         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
1308         semantics.
1309
1310         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
1311         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
1312         WTF::RefCountedBase::ref()).
1313
1314         * DumpRenderTree/chromium/TestWebWorker.h:
1315         (TestWebWorker::TestWebWorker):
1316
1317 2010-12-02  Ojan Vafai  <ojan@chromium.org>
1318
1319         Reviewed by Eric Seidel.
1320
1321         make webkit-patch command work when the git branch is not synced to the remote svn branch
1322         https://bugs.webkit.org/show_bug.cgi?id=50424
1323
1324         * Scripts/webkitpy/common/checkout/scm.py:
1325         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1326
1327 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
1328
1329         Reviewed by Andreas Kling.
1330
1331         [WINCE] Add build system
1332         https://bugs.webkit.org/show_bug.cgi?id=50522
1333
1334         * CMakeListsWinCE.txt: Added.
1335
1336 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1337
1338         Reviewed by Tony Chang.
1339
1340         Allow the Chromium port to have Leopard-specific baselines
1341         https://bugs.webkit.org/show_bug.cgi?id=50506
1342
1343         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1344
1345 2010-12-03  Tony Chang  <tony@chromium.org>
1346
1347         Reviewed by Kent Tamura.
1348
1349         [chromium] fix 2 bugs with inspector tests in DRT
1350         https://bugs.webkit.org/show_bug.cgi?id=50492
1351
1352         Tasks can outlive the tasklist (even when canceled) so this was
1353         causing a crash when ~WebTask() ran.  Avoid this by unregistering
1354         when a task is canceled.
1355
1356         Also fix an assert when closing devtool windows by copying some
1357         logic from test_shell.
1358
1359         * DumpRenderTree/chromium/Task.cpp:
1360         (WebTask::~WebTask):
1361         (TaskList::revokeAll):
1362         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
1363             the tasklist (since the task can outlive the tasklist).
1364         * DumpRenderTree/chromium/TestShell.h:
1365         (TestShell::devToolsWebView):
1366         * DumpRenderTree/chromium/WebViewHost.cpp:
1367         (WebViewHost::~WebViewHost): Don't load about:blank when closing
1368             a window if the window has devtools loaded.  This avoids an
1369             ASSERT and matches test_shell.
1370
1371 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
1372
1373         Reviewed by Martin Robinson.
1374
1375         [GTK] Fix GtkLauncher.c style, use webkit style
1376         https://bugs.webkit.org/show_bug.cgi?id=50542
1377
1378         * GtkLauncher/main.c:
1379         (activateUriEntryCb):
1380         (updateTitle):
1381         (linkHoverCb):
1382         (notifyTitleCb):
1383         (notifyLoadStatusCb):
1384         (notifyProgressCb):
1385         (destroyCb):
1386         (goBackCb):
1387         (goForwardCb):
1388         (create_webViewCb):
1389         (webViewReadyCb):
1390         (closeWebViewCb):
1391         (createBrowser):
1392         (createStatusbar):
1393         (createToolbar):
1394         (createWindow):
1395         (main):
1396
1397 2010-12-04  Antonio Gomes  <agomes@rim.com>
1398
1399         Reviewed by Martin Robinson.
1400
1401         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
1402         https://bugs.webkit.org/show_bug.cgi?id=48429
1403
1404         Moved more private method declared with WEBKIT_API to
1405         DumpRenderTreeSupportGtk, since they were only being used by DRT.
1406
1407         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1408         (resetDefaultsToConsistentValues):
1409         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1410         (LayoutTestController::addOriginAccessWhitelistEntry):
1411         (LayoutTestController::execCommand):
1412         (LayoutTestController::isCommandEnabled):
1413
1414 2010-12-04  Antonio Gomes  <agomes@rim.com>
1415
1416         Reviewed by Andreas Kling.
1417
1418         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
1419
1420         Method was removed by http://trac.webkit.org/changeset/71604
1421
1422         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1423
1424 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
1425
1426         Reviewed by Xan Lopez.
1427
1428         [GTK] Fix compilation warnings reported by clang
1429         https://bugs.webkit.org/show_bug.cgi?id=50252
1430
1431         * GtkLauncher/main.c:
1432         (create_window): The create_statusbar function does not have
1433         parameters.
1434
1435 2010-12-05  Robert Hogan  <robert@webkit.org>
1436
1437         Reviewed by Andreas Kling.
1438
1439         [Qt] Zero-sized font does not yet work
1440
1441         Fix fast/text/font-size-zero.html
1442
1443         Copy other ports by setting minimumFontSize to 0 for DRT runs.
1444
1445         https://bugs.webkit.org/show_bug.cgi?id=49759
1446
1447         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1448         (WebCore::WebPage::WebPage):
1449
1450 2010-12-04  Sam Weinig  <sam@webkit.org>
1451
1452         Reviewed by Jon Honeycutt.
1453
1454         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
1455         https://bugs.webkit.org/show_bug.cgi?id=50511
1456
1457         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
1458         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
1459
1460         * MiniBrowser/mac/BrowserWindowController.m:
1461         (didChangeLocationWithinPageForFrame):
1462         (-[BrowserWindowController awakeFromNib]):
1463         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
1464         * TestWebKitAPI/PlatformUtilities.cpp:
1465         (TestWebKitAPI::Util::toWK):
1466         * TestWebKitAPI/PlatformUtilities.h:
1467         (TestWebKitAPI::Util::adoptWK):
1468         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1469         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
1470         (TestWebKitAPI::nullJavaScriptCallback):
1471         (TestWebKitAPI::didFinishLoadForFrame):
1472         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
1473         (TestWebKitAPI::TEST):
1474         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
1475         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1476         * TestWebKitAPI/win/copy-resources.cmd:
1477         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1478         (WTR::InjectedBundlePage::InjectedBundlePage):
1479         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
1480         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1481         * WebKitTestRunner/TestController.cpp:
1482         (WTR::TestController::initialize):
1483
1484 2010-11-08  Antonio Gomes  <agomes@rim.com>
1485
1486         Reviewed by Martin Robinson.
1487
1488         [Gtk] Populate DumpRenderTreeSupportGtk
1489         https://bugs.webkit.org/show_bug.cgi?id=48429
1490
1491         Made the previous calls to webkit_web_frame* functions defined as private
1492         APIs in webkitprivate.h go through DRTSupportGtk.
1493
1494         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1495         (AccessibilityController::focusedElement):
1496         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1497         (dumpFramesAsText):
1498         (resetDefaultsToConsistentValues):
1499         (dump):
1500         (webViewDocumentLoadFinished):
1501         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1502         (LayoutTestController::counterValueForElementById):
1503         (LayoutTestController::pageNumberForElementById):
1504         (LayoutTestController::numberOfPages):
1505         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1506         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1507         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1508         (LayoutTestController::numberOfActiveAnimations):
1509         (LayoutTestController::suspendAnimations):
1510         (LayoutTestController::resumeAnimations):
1511         (LayoutTestController::markerTextForListItem):
1512
1513 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1514
1515         Reviewed by Tony Chang.
1516
1517         Rebaseline server: use pretty text diff output
1518         https://bugs.webkit.org/show_bug.cgi?id=50484
1519         
1520         Serve *-pretty-diff.html for text diff output.
1521
1522         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1523         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1524         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1525         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1526
1527 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1528
1529         Unreviewed, rolling out r73302.
1530         http://trac.webkit.org/changeset/73302
1531         https://bugs.webkit.org/show_bug.cgi?id=50499
1532
1533         Causes crashes in debug LayoutTests (Requested by xan_ on
1534         #webkit).
1535
1536         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1537         (AccessibilityUIElement::AccessibilityUIElement):
1538         (AccessibilityUIElement::parentElementCallback):
1539         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1540         * DumpRenderTree/chromium/CppBoundClass.cpp:
1541         * DumpRenderTree/chromium/CppBoundClass.h:
1542
1543 2010-12-03  Sam Weinig  <sam@webkit.org>
1544
1545         Reviewed by Maciej Stachowiak.
1546
1547         Enable <a ping> for Mac/Windows/WebKit2 builds
1548         <rdar://problem/8504473>
1549         https://bugs.webkit.org/show_bug.cgi?id=50488
1550
1551         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1552         (TestWebKitAPI::TEST): Test that the default value of
1553         WKPreferencesGetHyperlinkAuditingEnabled is true.
1554
1555 2010-12-03  Chris Guillory  <chris.guillory@google.com>
1556
1557         Reviewed by Chris Fleizach.
1558
1559         Include the FrameView widget of a RenderWidget in the accessibility tree.
1560         https://bugs.webkit.org/show_bug.cgi?id=49106
1561
1562         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1563         (AccessibilityUIElement::AccessibilityUIElement):
1564         (AccessibilityUIElement::parentElementCallback):
1565         (AccessibilityUIElement::isEqualCallback):
1566         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1567         * DumpRenderTree/chromium/CppBoundClass.cpp:
1568         (CppBoundClass::getFromCppVariant):
1569         * DumpRenderTree/chromium/CppBoundClass.h:
1570
1571 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1572
1573         Reviewed by Tony Chang.
1574
1575         Rebaseline server: organize tests by state, add dry run mode
1576         https://bugs.webkit.org/show_bug.cgi?id=50473
1577         
1578         Group tests in the menu by state, so that it's easier to see after
1579         processing the queue which failed.
1580         
1581         Add support for the --dry-run flag so that it's easier to test changes
1582         such as this (stubs out filesystem and SCM operations).
1583
1584         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1585         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1586         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1587
1588 2010-12-03  Brady Eidson  <beidson@apple.com>
1589
1590         Reviewed by Anders Carlsson.
1591
1592         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
1593         WebKit2 Authentication Support
1594
1595         Keep these builds working:
1596         * MiniBrowser/mac/BrowserWindowController.m:
1597         (-[BrowserWindowController awakeFromNib]):
1598
1599         * WebKitTestRunner/TestController.cpp:
1600         (WTR::TestController::initialize):
1601
1602 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
1603
1604         Reviewed by Tony Chang.
1605
1606         Rebaseline server: move existing baselines
1607         https://bugs.webkit.org/show_bug.cgi?id=50421
1608         
1609         Implement moving of existing baselines: move all files that are about
1610         to be overwriten by update baselines.
1611         
1612         Also fix a typo in the UI JS.
1613
1614         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1615         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1616         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
1617
1618 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1619
1620         Unreviewed, rolling out r73211.
1621         http://trac.webkit.org/changeset/73211
1622         https://bugs.webkit.org/show_bug.cgi?id=50450
1623
1624         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
1625         yutak on #webkit).
1626
1627         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1628
1629 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1630
1631         Unreviewed, rolling out r73222.
1632         http://trac.webkit.org/changeset/73222
1633         https://bugs.webkit.org/show_bug.cgi?id=50449
1634
1635         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
1636         (Requested by yutak on #webkit).
1637
1638         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1639         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1640         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1641         * Scripts/webkitpy/layout_tests/port/base.py:
1642         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1643         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1644
1645 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1646
1647         Unreviewed, rolling out r73228.
1648         http://trac.webkit.org/changeset/73228
1649         https://bugs.webkit.org/show_bug.cgi?id=50448
1650
1651         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
1652         (Requested by yutak on #webkit).
1653
1654         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1655         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1656         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1657         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
1658         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1659
1660 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1661
1662         Unreviewed, rolling out r73231.
1663         http://trac.webkit.org/changeset/73231
1664         https://bugs.webkit.org/show_bug.cgi?id=50443
1665
1666         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
1667         (Requested by yutak on #webkit).
1668
1669         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1670         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1671         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1672         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1673
1674 2010-12-03  David Levin  <levin@chromium.org>
1675
1676         Reviewed by Shinichiro Hamaji.
1677
1678         check-webkit-style: false positive reported for #if macro
1679         https://bugs.webkit.org/show_bug.cgi?id=48242
1680
1681         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
1682           all preprocessor commands.
1683         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
1684
1685 2010-12-02  Eric Seidel  <eric@webkit.org>
1686
1687         Reviewed by Adam Barth.
1688
1689         Update the EWSTools scripts to use modern-style git repos
1690         https://bugs.webkit.org/show_bug.cgi?id=50402
1691
1692         * EWSTools/create-webkit-git:
1693         * EWSTools/start-commit-queue.sh:
1694         * EWSTools/start-queue.sh:
1695
1696 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
1697
1698         Fix Chromium Linux plugin tests by not logging
1699         unconditionally from the event handling code.
1700
1701         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1702         (handleEventX11):
1703
1704 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
1705
1706         Reviewed by Tony Chang.
1707
1708         nrwt multiprocessing - move logic back into run_webkit_tests
1709
1710         This change moves a bunch of logic that I had put into
1711         message_broker back into run_webkit_tests, in a slightly
1712         different format. WorkerMessageBroker needed to become less aware of
1713         the logic the TestRunner class uses, and more generic.
1714         Eventually the MessageBroker will only do generic messaging and
1715         thread/process-pooling, and (almost) all of the
1716         run-webkit-tests-specific logic will be moved to
1717         run_webkit_tests.py and dump_render_tree_thread.py.
1718         
1719         The biggest changes are that the Broker can now start a single
1720         worker, but the responsibility for starting all of them is pushed
1721         back to the TestRunner (Manager), and the logic for checking if
1722         the threads are done or wedged is moved back to TestRunner. We
1723         also remove WorkerMessageBroker.cleanup (not needed) and
1724         cancel_workers (they have to be cancelled individually).
1725         
1726         The  message_broker is now encapsulated inside
1727         TestRunner._run_tests(); it only needs to exist while actually
1728         running the tests.
1729
1730         Also, delete a bunch of tests in message_broker_unittest that no
1731         longer make much sense.
1732
1733         This patch depends on bug 50372.
1734
1735         https://bugs.webkit.org/show_bug.cgi?id=50374
1736
1737         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1738         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1739         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1740         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1741         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1742
1743 2010-12-02  Hayato Ito  <hayato@chromium.org>
1744
1745         Reviewed by Eric Seidel.
1746
1747         Refactor test_types's compare_output() method so that it takes a
1748         TestInput object.
1749
1750         compare_output() will need additional information included in a TestInput
1751         object to support reftests. This change is a pre-requirement of that.
1752
1753         https://bugs.webkit.org/show_bug.cgi?id=50362
1754
1755         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1756         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1757         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1758         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
1759         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1760
1761 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
1762
1763         Reviewed by Anders Carlsson.
1764
1765         Add the ability to run script on 'new' and 'paint' in the test plugin
1766         https://bugs.webkit.org/show_bug.cgi?id=50425
1767         
1768         Add "onnew" and "onpaintevent" attributes to the test plugin,
1769         so that tests can run JS at these times.
1770
1771         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1772         (pluginAllocate):
1773         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1774         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1775         (NPP_New):
1776         (NPP_Destroy):
1777         (handleEventCarbon):
1778         (handleEventCocoa):
1779         (NPP_HandleEvent):
1780
1781 2010-12-02  Sam Weinig  <sam@webkit.org>
1782
1783         Fix Qt build.
1784
1785         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1786         (WTR::PlatformWebView::PlatformWebView):
1787
1788 2010-12-02  Sam Weinig  <sam@webkit.org>
1789
1790         Reviewed by Anders Carlsson.
1791
1792         WebKit2 Preferences should be held off the PageGroup, not the Context
1793         https://bugs.webkit.org/show_bug.cgi?id=50414
1794
1795         Update for API changes.
1796
1797         * WebKitTestRunner/PlatformWebView.h:
1798         * WebKitTestRunner/TestController.cpp:
1799         (WTR::createOtherPage):
1800         (WTR::TestController::initialize):
1801         (WTR::TestController::resetStateToConsistentValues):
1802         * WebKitTestRunner/TestController.h:
1803         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1804         (WTR::PlatformWebView::PlatformWebView):
1805         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1806         (WTR::PlatformWebView::PlatformWebView):
1807
1808 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
1809
1810         Reviewed by Tony Chang.
1811
1812         new-run-webkit-tests: minor cleanup for multiprocessing work
1813
1814         This change:
1815         * moves worker naming into TestShellThread, eliminating a
1816           parameter to the constructor and putting the responsibility in
1817           the correct place.
1818         * eliminates the _WorkerState() class in message_broker, because
1819           it turns out that state really needs to be in run_webkit_tests
1820         * renames the Broker classes to be module-private.
1821         * fixes a bunch of minor commenting and whitespace issues to
1822           make subsequent patches a bit clearer.
1823         * Adds a Port hook for default_worker_model() so that we can
1824           accomodate the potential for different worker models on
1825           different ports.
1826         * merge in the fix from 50420 for the brokenness introduced in
1827           bug 50367.
1828
1829         This patch depends on bug 50367.
1830
1831         https://bugs.webkit.org/show_bug.cgi?id=50372
1832
1833         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1834         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1835         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1836         * Scripts/webkitpy/layout_tests/port/base.py:
1837         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1838         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1839
1840 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
1841
1842         Reviewed by Tony Chang.
1843
1844         This change is a bunch of cleanup / refactoring of the file
1845         below. It moves a bunch of free functions to methods on the
1846         TestShellThread class, and restructures other methods to be
1847         closer to the structure we'll need for the multiprocessing
1848         rewrite.
1849
1850         It also makes the logic of --run-singly a *lot* easier to follow
1851         by nestling all of the separate-thread logic into a single
1852         routine.
1853
1854         There should be no semantic changes in this patch, just cleanup.
1855
1856         https://bugs.webkit.org/show_bug.cgi?id=50367
1857
1858         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1859
1860 2010-12-02  Tony Chang  <tony@chromium.org>
1861
1862         Unreviewed, rolling out r73164.
1863         http://trac.webkit.org/changeset/73164
1864         https://bugs.webkit.org/show_bug.cgi?id=50359
1865
1866         broke debugger tests on win
1867
1868         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1869
1870 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
1871
1872         Reviewed by Tony Chang.
1873
1874         Rebaseline server: add updating of baselines
1875         https://bugs.webkit.org/show_bug.cgi?id=50305
1876         
1877         Implements updating of baselines, where we copy -actual.* files over
1878         the current -expected.* files. To do this, we need a
1879         _get_actual_result_files method to get test results files and a
1880         _rebaseline_test method to actually do the file copy and SCM operation.
1881         _rebaseline_test logs output into a buffer, this is useful for both
1882         showing result in the UI and for unit tests.
1883         
1884         To make passing around of the various test environment properties
1885         (results directory, filesystem, SCM, etc) easier, add a TestConfig
1886         class for them.
1887         
1888         Moving of existing baselines is not implemented yet, this patch is big
1889         enough as it is.
1890
1891         * Scripts/webkitpy/common/system/filesystem.py:
1892         * Scripts/webkitpy/common/system/filesystem_mock.py:
1893         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1894         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1895         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
1896         * Scripts/webkitpy/tool/mocktool.py:
1897
1898 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
1899
1900         Unreviewed build fix after vcproj updates.
1901
1902         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
1903         that WIN_CAIRO is defined for this build.
1904         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
1905         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
1906         (these were previously 'Debug_Cairo' and 'Release_Cairo'
1907
1908 2010-12-02  Sam Weinig  <sam@webkit.org>
1909
1910         Reviewed by Anders Carlsson.
1911
1912         WebKit2 needs API to turn on popup blocking
1913         https://bugs.webkit.org/show_bug.cgi?id=50407
1914
1915         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1916         (TestWebKitAPI::TEST):
1917         * WebKitTestRunner/TestController.cpp:
1918         (WTR::TestController::resetStateToConsistentValues):
1919
1920 2010-12-01  Tony Chang  <tony@chromium.org>
1921
1922         Reviewed by Ojan Vafai.
1923
1924         [chromium] force NRWT to use DRT
1925         https://bugs.webkit.org/show_bug.cgi?id=50359
1926
1927         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1928
1929 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
1930
1931         Reviewed by Xan Lopez.
1932
1933         [GTK] DumpRenderTree has two copies of JavaScriptCore
1934         https://bugs.webkit.org/show_bug.cgi?id=49877
1935
1936         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
1937         LDADD list for DumpRenderTree.
1938
1939 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
1940
1941         Unreviewed: Added myself to list of Committers.
1942
1943         * Scripts/webkitpy/common/config/committers.py:
1944
1945 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
1946
1947         Reviewed by Adam Barth.
1948
1949         build-webkit --chromium always updates DEPS and re-generates project files
1950         https://bugs.webkit.org/show_bug.cgi?id=50340
1951         
1952         Make build-webkit --chromium invoke update-webkit-chromium only when
1953         --update-chromium is passed in, so that we don't add 20 seconds to all
1954         builds.
1955         
1956         Making all invocations update was added with r61883, with the goal of
1957         making EWS bots always update. The bots will switch to using this flag
1958         (as will all other webkit-patch build steps) so nothing should change
1959         for them.
1960
1961         * Scripts/webkitdirs.pm:
1962         * Scripts/webkitpy/common/config/ports.py:
1963         * Scripts/webkitpy/common/config/ports_unittest.py:
1964
1965 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
1966
1967         Reviewed by Tony Chang.
1968
1969         new-run-webkit-tests: add a --dry-run / -n flag
1970         https://bugs.webkit.org/show_bug.cgi?id=50045
1971
1972         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1973         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1974
1975 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
1976
1977         Reviewed by Adam Roben.
1978
1979         WinCairo build should not use link-time code generation (LTCG)
1980         https://bugs.webkit.org/show_bug.cgi?id=50353
1981
1982         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1983         * DumpRenderTree/win/DumpRenderTree.vcproj:
1984         * DumpRenderTree/win/ImageDiff.vcproj:
1985         * FindSafari/FindSafari.vcproj:
1986         * MiniBrowser/MiniBrowser.vcproj:
1987         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1988         * WebKitAPITest/WebKitAPITest.vcproj:
1989         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1990         * WebKitTestRunner/win/InjectedBundle.vcproj:
1991         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1992         * WinLauncher/WinLauncher.vcproj:
1993         * record-memory-win/record-memory-win.vcproj:
1994
1995 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
1996
1997         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
1998         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
1999         adding the file to the sources list was not enough to force the rebuild.
2000
2001         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2002         Remove an empty line at the end of this file to force a rebuild.
2003
2004 2010-12-01  Sam Weinig  <sam@webkit.org>
2005
2006         Fix windows build.
2007
2008         * MiniBrowser/win/BrowserView.cpp:
2009         (BrowserView::create):
2010
2011 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2012
2013         Add missing file to the TestNetscapePlugin sources list after r73057.
2014
2015         * GNUmakefile.am: Add missing file.
2016
2017 2010-12-01  Sam Weinig  <sam@webkit.org>
2018
2019         Reviewed by Anders Carlsson.
2020
2021         Add PageGrouping to WebKit2 API
2022         https://bugs.webkit.org/show_bug.cgi?id=50332
2023
2024         - Update testing harnesses to deal with new PageGroup API.
2025
2026         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2027         (WKBundleInitialize):
2028         * TestWebKitAPI/InjectedBundleController.cpp:
2029         (TestWebKitAPI::InjectedBundleController::initialize):
2030         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2031         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2032         * TestWebKitAPI/InjectedBundleController.h:
2033         * TestWebKitAPI/InjectedBundleTest.h:
2034         (TestWebKitAPI::InjectedBundleTest::initialize):
2035         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2036         * TestWebKitAPI/PlatformUtilities.cpp:
2037         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2038         * TestWebKitAPI/PlatformUtilities.h:
2039         * TestWebKitAPI/PlatformWebView.h:
2040         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2041         (TestWebKitAPI::TEST):
2042         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2043         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2044         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2045         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2046         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2047         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2048         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2049         (WTR::InjectedBundle::didInitializePageGroup):
2050         (WTR::InjectedBundle::initialize):
2051         (WTR::InjectedBundle::beginTesting):
2052         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2053         (WTR::InjectedBundle::pageGroup):
2054         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2055         (WTR::LayoutTestController::addUserScript):
2056         (WTR::LayoutTestController::addUserStyleSheet):
2057         (WTR::LayoutTestController::setXSSAuditorEnabled):
2058         * WebKitTestRunner/TestController.cpp:
2059         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2060         (WTR::PlatformWebView::PlatformWebView):
2061
2062 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2063
2064         Reviewed by Adam Roben.
2065
2066         vcproj changes can't be applied cleanly by the Windows EWS bot
2067         https://bugs.webkit.org/show_bug.cgi?id=50328
2068
2069         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2070         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2071         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2072         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2073         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2074         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2075         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2076         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2077         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2078         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2079         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2080         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2081         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2082         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2083         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2084         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2085         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2086         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2087         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2088         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2089         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2090         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2091         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2092         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2093         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2094         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2095         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2096         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2097         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2098         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2099         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2100         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2101         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2102         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2103         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2104         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2105         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2106         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2107         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2108         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2109         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2110         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2111         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2112         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2113         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2114
2115 2010-12-01  Anders Carlsson  <andersca@apple.com>
2116
2117         Reviewed by Darin Adler.
2118
2119         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2120         https://bugs.webkit.org/show_bug.cgi?id=50336
2121
2122         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2123         Add new test.
2124
2125         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2126         (PluginTest::NPP_New):
2127         Add default implementation/
2128
2129         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2130         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2131         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2132         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2133         Get the user agent.
2134
2135         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2136         (NPP_New):
2137         Call PluginTest::NPP_New.
2138
2139         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2140         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2141         Add new files.
2142
2143         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2144         (webkit_test_plugin_new_instance):
2145         Call PluginTest::NPP_New.
2146
2147 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2148
2149         [wx] Build fixes after recent trunk changes.
2150
2151         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2152         (LayoutTestController::findString):
2153         * wx/build/settings.py:
2154
2155 2010-12-01  Dan Bernstein  <mitz@apple.com>
2156
2157         Reviewed by Darin Adler.
2158
2159         WebKitTestRunner needs layoutTestController.findString
2160         https://bugs.webkit.org/show_bug.cgi?id=50238
2161
2162         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2163         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2164         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2165         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2166
2167 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2168
2169         Try using svn:eol-style native on a vcproj file.
2170
2171         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2172
2173 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2174
2175         Reviewed by Adam Roben.
2176
2177         [WINCE] Add WinCELauncher
2178         https://bugs.webkit.org/show_bug.cgi?id=50217
2179
2180         * WinCELauncher/main.cpp: Added.
2181
2182 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2183
2184         Reviewed by Kenneth Rohde Christiansen.
2185
2186         [Qt] Implement layoutTestController.findString
2187         https://bugs.webkit.org/show_bug.cgi?id=50236
2188
2189         Add the missing function to the LayoutTestController.
2190
2191         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2192         (LayoutTestController::findString):
2193         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2194
2195 2010-11-30  Tony Chang  <tony@chromium.org>
2196
2197         Reviewed by Adam Barth.
2198
2199         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2200         https://bugs.webkit.org/show_bug.cgi?id=49036
2201
2202         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2203             for CppVariants.
2204         (LayoutTestController::cppVariantToBool):
2205         (LayoutTestController::cppVariantToInt32):
2206         (LayoutTestController::setDatabaseQuota):
2207         (LayoutTestController::evaluateInWebInspector):
2208         (LayoutTestController::setMockGeolocationError):
2209
2210 2010-11-30  Eric Seidel  <eric@webkit.org>
2211
2212         Reviewed by Tony Chang.
2213
2214         update-webkit should call git fetch before git svn rebase
2215         https://bugs.webkit.org/show_bug.cgi?id=50273
2216
2217         After discussion on webkit-dev, we've decided to move the "default"
2218         git setup to pulling updates from git.webkit.org in preference
2219         to rebuilding the local svn index using git svn fetch every time.
2220
2221         This change should have no effect on people using the "old" git setup
2222         and should dramatically increase the speed of updates for those using
2223         the "new" git setup along with update-webkit.  I'm about to move the
2224         EWS and other queues over to this setup once this lands.
2225
2226         * Scripts/update-webkit:
2227
2228 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2229
2230         Reviewed by Xan Lopez.
2231
2232         GTK: AX: implement press in DRT
2233         https://bugs.webkit.org/show_bug.cgi?id=36146
2234
2235         Implement AccessibilityUIElement::press() for GTK.
2236
2237         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2238         (AccessibilityUIElement::press): Implemented.
2239
2240 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2241
2242         Reviewed by Tony Chang.
2243
2244         config.webkit_base_dir returns a path with a trailing slash
2245         https://bugs.webkit.org/show_bug.cgi?id=50197
2246         
2247         config.webkit_base_dir() should return a path without a trailing slash,
2248         like all the other methods that return paths.
2249         
2250         Undoes MockFileSytem changes by r72640, since they're no longer
2251         necessary for GetBaselinesTest to pass.
2252
2253         * Scripts/webkitpy/common/system/filesystem_mock.py:
2254         * Scripts/webkitpy/layout_tests/port/base.py:
2255         * Scripts/webkitpy/layout_tests/port/config.py:
2256         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2257
2258 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2259
2260         Reviewed by Tony Chang.
2261
2262         Rebaseline server: baseline display tweaks
2263         https://bugs.webkit.org/show_bug.cgi?id=50207
2264         
2265         Determine which baselines were used when running the tests and highlight
2266         them in the UI. Sort platform names alphabetically.
2267         
2268         Also makes the server URL be launched in the user's browser
2269         automatically.
2270
2271         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2272         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2273         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2274         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2275         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2276
2277 2010-11-30  Dan Bernstein  <mitz@apple.com>
2278
2279         Reviewed by Anders Carlsson.
2280
2281         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2282         https://bugs.webkit.org/show_bug.cgi?id=50238
2283
2284         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2285         (WTR::LayoutTestController::findString): Added.
2286         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2287
2288 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2289
2290         Reviewed by Adam Roben.
2291
2292         All projects on Windows should use cmd files for build events
2293         https://bugs.webkit.org/show_bug.cgi?id=50213
2294
2295         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2296         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2297         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2298         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2299         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
2300         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
2301         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2302         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
2303         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
2304         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
2305         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2306         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
2307         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
2308         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
2309         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2310         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
2311         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
2312         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2313         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
2314         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
2315         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2316         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2317         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
2318         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
2319         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
2320         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
2321         * WinLauncher/WinLauncherCommon.vsprops:
2322         * WinLauncher/WinLauncherPostBuild.cmd: Added.
2323         * WinLauncher/WinLauncherPreBuild.cmd: Added.
2324
2325 2010-11-29  Dan Bernstein  <mitz@apple.com>
2326
2327         GTK DumpRenderTree build fix after r72887.
2328
2329         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2330         (LayoutTestController::findString):
2331
2332 2010-11-29  Dan Bernstein  <mitz@apple.com>
2333
2334         Windows DumpRenderTree build fix after r72887.
2335
2336         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2337         (LayoutTestController::findString): Added empty implementation.
2338
2339 2010-11-29  Dan Bernstein  <mitz@apple.com>
2340
2341         Reviewed by Darin Adler.
2342
2343         DumpRenderTree changes for testing the text search API.
2344         https://bugs.webkit.org/show_bug.cgi?id=50038
2345
2346         * DumpRenderTree/LayoutTestController.cpp:
2347         (findStringCallback):
2348         (LayoutTestController::staticFunctions):
2349         * DumpRenderTree/LayoutTestController.h:
2350         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2351         (LayoutTestController::findString):
2352         * MiniBrowser/mac/BrowserWindowController.m:
2353         (-[BrowserWindowController find:]):
2354
2355 2010-11-29  Johnny Ding  <jnd@chromium.org>
2356
2357         Unreviewed: Add myself to the list of Committers.
2358
2359         * Scripts/webkitpy/common/config/committers.py:
2360
2361 2010-11-29  Mark Rowe  <mrowe@apple.com>
2362
2363         Reviewed by Adele Peterson.
2364
2365         <rdar://problem/8694997> DumpRenderTree fails to build.
2366
2367         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
2368
2369 2010-11-29  Mark Rowe  <mrowe@apple.com>
2370
2371         Reviewed by Adele Peterson.
2372
2373         <rdar://problem/8694997> DumpRenderTree fails to build.
2374
2375         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
2376         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
2377         * DumpRenderTree/mac/PerlSupport/Makefile:
2378
2379 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
2380
2381         Reviewed by Martin Robinson.
2382
2383         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
2384         https://bugs.webkit.org/show_bug.cgi?id=50154
2385
2386         Added missing checks to allAttributes().
2387
2388         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2389         (AccessibilityUIElement::allAttributes): Added missing checks.
2390
2391 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2392
2393         Reviewed by Kenneth Rohde Christiansen.
2394
2395         [Qt] Allow pre-generation for package builds for WebKit2
2396         https://bugs.webkit.org/show_bug.cgi?id=50139
2397
2398         Use a build variable for the generated directory path and set the
2399         value based on CONFIG just like for WebKit1.
2400
2401         For non-package builds use a relative base path for the
2402         genrated directory just like for WebKit1.
2403
2404         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2405         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2406
2407 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2408
2409         Reviewed by Kenneth Rohde Christiansen.
2410
2411         [Qt] Move some build logic from Qt to platform independent code
2412         https://bugs.webkit.org/show_bug.cgi?id=50134
2413
2414         Create target directories inside generate-forwarding-headers.pl.
2415
2416         * Scripts/generate-forwarding-headers.pl:
2417
2418 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2419
2420         Reviewed by Martin Robinson.
2421
2422         [GTK] Windowless plugins gets broken key input
2423         https://bugs.webkit.org/show_bug.cgi?id=49927
2424
2425         Convert the XEvent::keycode to ASCII before printing it. Not
2426         doing this was causing false positive in 
2427         plugins/keyboard-events.html.
2428
2429         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2430         (keycode_to_char):
2431         (webkit_test_plugin_handle_event):
2432
2433 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
2434
2435         Reviewed by Antonio Gomes.
2436
2437         [Qt] Html autofocus not working with QGraphicsWebView
2438         https://bugs.webkit.org/show_bug.cgi?id=43169
2439
2440         Tell the scene to set the webview item as the currently
2441         focused item. This makes the input field with autofocus get
2442         focus as it should.
2443
2444         * QtTestBrowser/webview.cpp:
2445         (WebViewGraphicsBased::WebViewGraphicsBased):
2446
2447 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2448
2449         Reviewed by Tony Chang.
2450
2451         nrwt - clean up create_driver interface and print out the
2452         command line used for DumpRenderTree/TestShell.
2453
2454         This patch adds a driver_cmd_line() call to the Port class in
2455         order to retrive the command line to print it out (as part of
2456         --print config).
2457
2458         In addition, this patch cleans up the Port.create_driver()
2459         signature and the Driver constructor interface to take a worker
2460         number and no longer require the image_path argument (Chromium's
2461         drivers now synthesize the image_path from the worker number
2462         internally).
2463
2464         https://bugs.webkit.org/show_bug.cgi?id=49934
2465
2466         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2467         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2468         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2469         * Scripts/webkitpy/layout_tests/port/base.py:
2470         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2471         * Scripts/webkitpy/layout_tests/port/chromium.py:
2472         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2473         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2474         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2475         * Scripts/webkitpy/layout_tests/port/test.py:
2476         * Scripts/webkitpy/layout_tests/port/webkit.py:
2477         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2478         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2479
2480 2010-11-24  Ojan Vafai  <ojan@chromium.org>
2481
2482         Reviewed by Tony Chang.
2483
2484         [chromium] improve memory usage for test results server and store fewer runs
2485         https://bugs.webkit.org/show_bug.cgi?id=50035
2486
2487         Store fewer runs and don't pass full files around when we only need bools.
2488         Greatly improves error rates on test-results.appspot.com.
2489
2490         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2491         * TestResultServer/handlers/testfilehandler.py:
2492         * TestResultServer/model/dashboardfile.py:
2493         * TestResultServer/model/jsonresults.py:
2494
2495 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2496
2497         Reviewed by Tony Chang.
2498
2499         This patch implements the first part of the manager side of the
2500         Broker objects - it handles creating threads, waiting for them
2501         to complete, and running a single-threaded loop as well.
2502
2503         https://bugs.webkit.org/show_bug.cgi?id=49779
2504
2505         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2506         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2507         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2508         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2509
2510 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
2511
2512         Reviewed by David Levin.
2513
2514         DRT should not generate pixel output for text/plain tests
2515         https://bugs.webkit.org/show_bug.cgi?id=50002
2516         
2517         Modify Mac, Windows and GTK DRT implementations to disable pixel output
2518         when encountering a text/plain response (the Chromium one already does
2519         this, and none of the other ports special-case text/plain output in
2520         the first place).
2521
2522         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2523         (dump):
2524         * DumpRenderTree/mac/DumpRenderTree.mm:
2525         (dump):
2526         * DumpRenderTree/win/DumpRenderTree.cpp:
2527         (dump):
2528
2529 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
2530
2531         Unreviewed.
2532
2533         Add my other email address to committers.py.
2534
2535         * Scripts/webkitpy/common/config/committers.py:
2536
2537 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
2538
2539         Reviewed by Csaba Osztrogonác.
2540
2541         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
2542         https://bugs.webkit.org/show_bug.cgi?id=49975
2543
2544         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
2545         to enable the script to define it 0 in case of a minimal build.
2546
2547 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
2548
2549         Reviewed by Xan Lopez.
2550
2551         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
2552         https://bugs.webkit.org/show_bug.cgi?id=49143
2553
2554         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2555         (createWebView): Call the new connectEditingCallbacks function.
2556         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
2557         (dumpNodePath):
2558         (dumpRange):
2559         (insertActionString):
2560         (selectionAffinityString):
2561         (shouldBeginEditing):
2562         (shouldEndEditing):
2563         (shouldInsertNode):
2564         (shouldInsertText):
2565         (shouldDeleteRange):
2566         (shouldShowDeleteInterfaceForElement):
2567         (shouldChangeSelectedRange):
2568         (shouldApplyStyle):
2569         (editingBegan):
2570         (userChangedContents):
2571         (editingEnded):
2572         (selectionChanged):
2573         (connectEditingCallbacks):
2574         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
2575         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
2576
2577 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
2578
2579         Reviewed by Andreas Kling.
2580
2581         [Qt] Make QtTestBrowser remember the selected user agent
2582         https://bugs.webkit.org/show_bug.cgi?id=50021
2583
2584         Set user agent for a new page by using the old page's
2585
2586         * QtTestBrowser/mainwindow.cpp:
2587         (MainWindow::setPage):
2588
2589 2010-11-24 Patrick Gansterer <paroga@webkit.org>
2590
2591         Reviewed by Csaba Osztrogonác.
2592
2593         Remove Bakefile build system files
2594         https://bugs.webkit.org/show_bug.cgi?id=49983
2595
2596         r53757 only removed the content, but not the files.
2597         This patch removes that empty files.
2598
2599         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
2600         * wx/browser/browser.bkl: Removed.
2601         * wx/build-wxwebkit: Removed.
2602
2603 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
2604
2605         Reviewed by Tony Chang.
2606
2607         This patch cleans up the logic used to shard tests into groups a
2608         bit and adds the --worker-model flag to NRWT. The flag is only
2609         used at the moment to control whether to run single-threaded or
2610         not, but eventually will also allow toggling between threads and
2611         processes.
2612
2613         Also add a minor cleanup with _test_is_slow(), which just
2614         eliminates some repetition and gives slightly better encapsulation.
2615
2616         https://bugs.webkit.org/show_bug.cgi?id=49773
2617
2618         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2619         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2620
2621 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
2622
2623         Reviewed by Tony Chang.
2624
2625         Rebaseline server: list current baselines and platforms
2626         https://bugs.webkit.org/show_bug.cgi?id=49991
2627         
2628         List existing baselines (with Trac links) for tests.
2629         
2630         Add dropdowns for choosing with platform baselines to target (and what
2631         to do with existing ones).
2632
2633         Also fix MockFileSystem.join to behave more like os.path.join (unit
2634         test was ending up with two consecutive slashes in a layout test
2635         path).        
2636
2637         * Scripts/webkitpy/common/system/filesystem_mock.py:
2638         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2639         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2640         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2641         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2642         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2643         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2644         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
2645
2646 2010-11-23  Ojan Vafai  <ojan@chromium.org>
2647
2648         Reviewed by Tony Chang.
2649
2650         remove timeout argument to urlopen
2651         https://bugs.webkit.org/show_bug.cgi?id=49995
2652
2653         Apparently the version of python we have on the bots doesn't accept a timeout argument.
2654
2655         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2656
2657 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2658
2659         Unreviewed, rolling out r72628.
2660         http://trac.webkit.org/changeset/72628
2661         https://bugs.webkit.org/show_bug.cgi?id=49994
2662
2663         This patch is causing layout-test failtures on GTK Linux
2664         64-bit Debug (Requested by ctguil on #webkit).
2665
2666         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2667         (AccessibilityUIElement::AccessibilityUIElement):
2668         (AccessibilityUIElement::parentElementCallback):
2669         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2670         * DumpRenderTree/chromium/CppBoundClass.cpp:
2671         * DumpRenderTree/chromium/CppBoundClass.h:
2672
2673 2010-11-22  Ojan Vafai  <ojan@chromium.org>
2674
2675         Reviewed by Tony Chang.
2676
2677         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
2678         https://bugs.webkit.org/show_bug.cgi?id=49944
2679
2680         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2681
2682 2010-11-23  Chris Guillory  <chris.guillory@google.com>
2683
2684         Reviewed by Dimitri Glazkov.
2685
2686         Include the FrameView widget of a RenderWidget in the accessibility tree.
2687         https://bugs.webkit.org/show_bug.cgi?id=49106
2688
2689         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2690         (AccessibilityUIElement::AccessibilityUIElement):
2691         (AccessibilityUIElement::parentElementCallback):
2692         (AccessibilityUIElement::isEqualCallback):
2693         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2694         * DumpRenderTree/chromium/CppBoundClass.cpp:
2695         (CppBoundClass::getFromCppVariant):
2696         * DumpRenderTree/chromium/CppBoundClass.h:
2697
2698 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
2699
2700         Reviewed by Kenneth Rohde Christiansen.
2701
2702         [EFL] Add tiled backing store to EWebLauncher
2703         https://bugs.webkit.org/show_bug.cgi?id=45777
2704
2705         Allow EWebLauncher to choose between single and tiled backing store
2706
2707         * EWebLauncher/main.c:
2708         (on_key_down):
2709         (browserCreate):
2710         (main):
2711
2712 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2713
2714         Reviewed by Tor Arne Vestbø.
2715
2716         [Qt] Review the setUserPermission & friends API
2717         https://bugs.webkit.org/show_bug.cgi?id=46810
2718
2719         Renamed requestPermissionFromUser to featurePermissionRequested
2720         and cancelRequestsForPermission to featurePermissionRequestCanceled.
2721
2722         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2723         (WebCore::WebPage::WebPage):
2724         * QtTestBrowser/webpage.cpp:
2725         (WebPage::WebPage):
2726         (WebPage::featurePermissionRequestCanceled):
2727         * QtTestBrowser/webpage.h:
2728
2729 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2730
2731         Reviewed by Tor Arne Vestbø.
2732
2733         [Qt] Review the setUserPermission & friends API
2734         https://bugs.webkit.org/show_bug.cgi?id=46810
2735
2736         Rename setUserPermission to setFeaturePermission
2737
2738         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2739         (WebCore::WebPage::requestPermission):
2740         (WebCore::WebPage::permissionSet):
2741         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2742         (LayoutTestController::grantDesktopNotificationPermission):
2743         * QtTestBrowser/webpage.cpp:
2744         (WebPage::requestPermission):
2745
2746 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2747
2748         Reviewed by Tor Arne Vestbø.
2749
2750         [Qt] Review the setUserPermission & friends API
2751         https://bugs.webkit.org/show_bug.cgi?id=46810
2752
2753         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
2754         and GeolocationPermissionDomain to Geolocation.
2755
2756         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2757         (WebCore::WebPage::WebPage):
2758         (WebCore::WebPage::requestPermission):
2759         (WebCore::WebPage::cancelPermission):
2760         (WebCore::WebPage::permissionSet):
2761         (WebCore::DumpRenderTree::geolocationPermissionSet):
2762         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2763         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2764         (LayoutTestController::grantDesktopNotificationPermission):
2765         * QtTestBrowser/webpage.cpp:
2766         (WebPage::WebPage):
2767         (WebPage::requestPermission):
2768         (WebPage::cancelRequestsForPermission):
2769         * QtTestBrowser/webpage.h:
2770
2771 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2772
2773         Reviewed by Tor Arne Vestbø.
2774
2775         [Qt] Review the setUserPermission & friends API
2776         https://bugs.webkit.org/show_bug.cgi?id=46810
2777
2778         Add a ByUser suffix to PermissionGranted/Denied. In the future
2779         we can add PermissionGrantedByDefault.
2780
2781
2782         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2783         (WebCore::WebPage::requestPermission):
2784         (WebCore::WebPage::permissionSet):
2785         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2786         (LayoutTestController::grantDesktopNotificationPermission):
2787         * QtTestBrowser/webpage.cpp:
2788         (WebPage::requestPermission):
2789
2790 2010-11-18  Satish Sampath  <satish@chromium.org>
2791
2792         Reviewed by Jeremy Orlow.
2793
2794         For speech input event, send an event object containing all the recognition results and metadata.
2795         https://bugs.webkit.org/show_bug.cgi?id=49736
2796
2797         Updated DRT by renaming the mock result method on all platforms to the new signature.
2798
2799         * DumpRenderTree/LayoutTestController.cpp:
2800         (addMockSpeechInputResultCallback):
2801         (LayoutTestController::staticFunctions):
2802         * DumpRenderTree/LayoutTestController.h:
2803         * DumpRenderTree/chromium/LayoutTestController.cpp:
2804         (LayoutTestController::LayoutTestController):
2805         (LayoutTestController::addMockSpeechInputResult):
2806         * DumpRenderTree/chromium/LayoutTestController.h:
2807         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2808         (LayoutTestController::addMockSpeechInputResult):
2809         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2810         (LayoutTestController::addMockSpeechInputResult):
2811         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2812         (LayoutTestController::addMockSpeechInputResult):
2813         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2814         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2815         (LayoutTestController::addMockSpeechInputResult):
2816         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2817         (LayoutTestController::addMockSpeechInputResult):
2818
2819 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
2820
2821         Reviewed by Tony Chang.
2822
2823         Fix some spacing issues with log messages with
2824         new-run-webkit-tests --verbose.
2825
2826         https://bugs.webkit.org/show_bug.cgi?id=49936
2827
2828         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2829
2830 2010-11-22  Ojan Vafai  <ojan@chromium.org>
2831
2832         Reviewed by Adam Barth.
2833
2834         update scm to work with different remote branches
2835         https://bugs.webkit.org/show_bug.cgi?id=49949
2836
2837         This works if there are multiple svn tracking branches
2838         and/or if the tracking branch is refs/remots/origin/master
2839         instead of refs/remotes/trunk which is the direction we're trying
2840         to head since that makes fetches faster.
2841
2842         * Scripts/webkitpy/common/checkout/scm.py:
2843         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2844
2845 2010-11-22  Hayato Ito  <hayato@chromium.org>
2846
2847         Reviewed by Shinichiro Hamaji.
2848
2849         Ignore reference files which will be used by reftests when collecting
2850         test cases.
2851         https://bugs.webkit.org/show_bug.cgi?id=49835
2852
2853         * Scripts/webkitpy/layout_tests/port/test_files.py:
2854         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2855
2856 2010-11-22  Adam Roben  <aroben@apple.com>
2857
2858         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
2859
2860         Apple's Windows build allows placing header files and import libraries for WebKit's
2861         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
2862         $WebKitLibrariesDir environment variable. This is both required for production builds and
2863         convenient for Apple-internal developer builds. Apple's production builds also require that
2864         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
2865         builds, the files are copied into that directory tree by the
2866         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
2867         copying is done by
2868         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
2869
2870         This .vsprops copying is problematic in one very important case: when a developer updates
2871         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
2872         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
2873         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
2874         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
2875         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
2876         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
2877
2878         To fix this, we now use normal relative paths to access the .vsprops files in the source
2879         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
2880         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
2881         unset, so the normal relative paths are used to read the .vsprops files out of the source
2882         tree directly. In production builds, this environment variable is set to a fake directory
2883         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
2884         is resolved.
2885         
2886         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
2887
2888         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
2889
2890         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
2891         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
2892         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
2893         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
2894         FeatureDefines.vsprops becomes:
2895
2896         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
2897
2898         which resolves to:
2899
2900         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
2901
2902         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
2903         actually exist since they are matched by an equal number of ".." path components.)
2904
2905         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
2906         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
2907
2908         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
2909         updated
2910
2911         Reviewed by Dave Hyatt.
2912
2913         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2914         * DumpRenderTree/win/DumpRenderTree.vcproj:
2915         * DumpRenderTree/win/ImageDiff.vcproj:
2916         * FindSafari/FindSafari.vcproj:
2917         * MiniBrowser/MiniBrowser.vcproj:
2918         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2919         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
2920         * WebKitAPITest/WebKitAPITest.vcproj:
2921         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2922         * WebKitTestRunner/win/InjectedBundle.vcproj:
2923         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2924         * WinLauncher/WinLauncher.vcproj:
2925         * record-memory-win/record-memory-win.vcproj:
2926         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
2927         files.
2928
2929 2010-11-22  Adam Roben  <aroben@apple.com>
2930
2931         Make it possible to run tests on Windows without Visual Studio or VC++
2932         Express installed
2933
2934         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
2935         are not installed. But this function doesn't need to be called when we
2936         already have a build available and are just trying to run the tests.
2937
2938         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
2939         because Visual Studio/VC++ Express aren't installed
2940
2941         Reviewed by Dave Hyatt.
2942
2943         * Scripts/webkitdirs.pm:
2944         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
2945         it is not needed by this function. Also added a FIXME.
2946
2947         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
2948         relying on determineConfigurationForVisualStudio doing it.
2949
2950 2010-11-19  Hayato Ito  <hayato@chromium.org>
2951
2952         Reviewed by Shinichiro Hamaji.
2953
2954         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
2955
2956         https://bugs.webkit.org/show_bug.cgi?id=49812
2957
2958         * Scripts/webkitpy/layout_tests/driver_test.py:
2959         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2960         * Scripts/webkitpy/layout_tests/port/base.py:
2961         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2962         * Scripts/webkitpy/layout_tests/port/chromium.py:
2963         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2964         * Scripts/webkitpy/layout_tests/port/test.py:
2965         * Scripts/webkitpy/layout_tests/port/webkit.py:
2966         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2967         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2968
2969 2010-11-22  Hayato Ito  <hayato@chromium.org>
2970
2971         Reviewed by Tony Chang.
2972
2973         [NRWT] Retry a few times in reading a png image to avoid a race condition.
2974
2975         https://bugs.webkit.org/show_bug.cgi?id=49924
2976
2977         * Scripts/webkitpy/layout_tests/port/chromium.py:
2978
2979 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
2980
2981         Reviewed by Kenneth Rohde Christiansen.
2982
2983         Fix EWebLauncher zoom discretization
2984         https://bugs.webkit.org/show_bug.cgi?id=49810
2985
2986         * EWebLauncher/main.c:
2987         (nearest_zoom_level_get):
2988         (zoom_level_set):
2989         (on_load_finished):
2990         (on_key_down):
2991
2992 2010-11-21  Sam Weinig  <sam@webkit.org>
2993
2994         Rubber-stamped by Dan Bernstein.
2995
2996         Fix ~300 WebKit2 tests by enabling developer extras preference.
2997
2998         * WebKitTestRunner/TestController.cpp:
2999         (WTR::TestController::resetStateToConsistentValues):
3000
3001 2010-11-21  Sam Weinig  <sam@webkit.org>
3002
3003         Reviewed by Dan Bernstein.
3004
3005         Textareas should be resizable by default
3006         https://bugs.webkit.org/show_bug.cgi?id=49892
3007
3008         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3009         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
3010         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3011         Add preferences test.
3012
3013 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
3014
3015         Reviewed by Tony Chang.
3016
3017         Rebaseline server: checksum-only differences and prefetching
3018         https://bugs.webkit.org/show_bug.cgi?id=49841
3019         
3020         Add support for image test results where the only difference is in the
3021         checksum.
3022         
3023         Add prefetching of the image results from the next test.
3024         
3025         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3026         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3027         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3028
3029 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3030
3031         Reviewed by Tony Chang.
3032
3033         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
3034
3035         Add the 'worker number' and 'worker name' concepts to the 
3036         TestShellThread objects, and move test_types and test_args from
3037         the TestRunner to the TestShellThread.
3038
3039         https://bugs.webkit.org/show_bug.cgi?id=49768
3040
3041         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3042         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3043
3044 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3045
3046         Reviewed by Ojan Vafai.
3047
3048         Do some minor cleanup and bug fixing.
3049
3050         https://bugs.webkit.org/show_bug.cgi?id=49777
3051
3052         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3053         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3054
3055 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3056
3057         Reviewed by Ojan Vafai.
3058
3059         nrwt - config.build_directory() is busted
3060
3061         Fixes a typo that was causing us to usually return the top level
3062         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
3063         bug was hidden by test stubs that were too simplistic :(.
3064
3065         https://bugs.webkit.org/show_bug.cgi?id=49815
3066
3067         * Scripts/webkitpy/common/system/executive_mock.py:
3068         * Scripts/webkitpy/layout_tests/port/config.py:
3069         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3070
3071 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3072
3073         Reviewed by Adam Roben.
3074
3075         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3076         https://bugs.webkit.org/show_bug.cgi?id=49819
3077
3078         * DumpRenderTree/DumpRenderTree.sln:
3079         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3080         * DumpRenderTree/win/DumpRenderTree.vcproj:
3081         * DumpRenderTree/win/ImageDiff.vcproj:
3082         * FindSafari/FindSafari.vcproj:
3083         * MiniBrowser/MiniBrowser.vcproj:
3084         * TestWebKitAPI/win/TestWebKitAPI.sln:
3085         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3086         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3087         * WebKitAPITest/WebKitAPITest.vcproj:
3088         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3089         * WebKitTestRunner/win/InjectedBundle.vcproj:
3090         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3091         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3092         * WinLauncher/WinLauncher.vcproj:
3093         * record-memory-win/record-memory-win.vcproj:
3094
3095 2010-11-19  Adam Roben  <aroben@apple.com>
3096
3097         Add some more Windows slaves
3098
3099         This is probably more than we will be using in the immediate future,
3100         but having some extra slave names makes experimenting with different
3101         configurations easier.
3102
3103         Reviewed by Jon Honeycutt.
3104
3105         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
3106         Windows slaves and distributed them among the three different Test
3107         builders.
3108
3109 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
3110
3111         Reviewed by Ojan Vafai.
3112
3113         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3114         https://bugs.webkit.org/show_bug.cgi?id=49702
3115
3116         Re-landing r72357 with a test fix.
3117
3118         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3119         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3120         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3121
3122 2010-11-19  Avi Drissman  <avi@google.com>
3123
3124         Reviewed by Antonio Gomes.
3125
3126         Complete support for Unix editing mode
3127         https://bugs.webkit.org/show_bug.cgi?id=49757
3128
3129         * DumpRenderTree/LayoutTestController.cpp:
3130         (setEditingBehaviorCallback):
3131         * DumpRenderTree/chromium/LayoutTestController.cpp:
3132         (LayoutTestController::setEditingBehavior):
3133
3134 2010-11-19  Adam Roben  <aroben@apple.com>
3135
3136         Fix run-javascriptcore-tests when there's a space in the path to
3137         testapi
3138
3139         Reviewed by Sam Weinig.
3140
3141         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
3142         system() to force it to interpret spaces in the path correctly.
3143
3144 2010-11-19  Adam Roben  <aroben@apple.com>
3145
3146         Update scripts for .exe name changes after r72327
3147
3148         As of r72327, the "_debug" suffix is only used in Debug_All builds.
3149
3150         Reviewed by Sam Weinig.
3151
3152         * Scripts/run-javascriptcore-tests:
3153         (testapiPath):
3154
3155         * Scripts/sunspider-compare-results:
3156         (pathToBuiltJSC):
3157
3158         * Scripts/webkitdirs.pm:
3159         (jscPath):
3160         (safariPath):
3161
3162 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3163
3164         Reviewed by Darin Adler.
3165
3166         Normalize Cairo/CFLite project/solution configuration names
3167         https://bugs.webkit.org/show_bug.cgi?id=49818
3168
3169         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3170         * DumpRenderTree/win/DumpRenderTree.vcproj:
3171         * DumpRenderTree/win/ImageDiff.vcproj:
3172         * MiniBrowser/MiniBrowser.vcproj:
3173         * TestWebKitAPI/win/TestWebKitAPI.sln:
3174         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3175         * WebKitAPITest/WebKitAPITest.vcproj:
3176         * WebKitTestRunner/win/InjectedBundle.vcproj:
3177         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3178         * WinLauncher/WinLauncher.vcproj:
3179         * Scripts/webkitdirs.pm: Updated cairo build configs.
3180
3181 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3182
3183         Reviewed by Adam Roben.
3184
3185         Windows vcproj configuration names should be normalized across projects
3186         https://bugs.webkit.org/show_bug.cgi?id=49776
3187
3188         * DumpRenderTree/DumpRenderTree.sln:
3189         * FindSafari/FindSafari.vcproj:
3190         * TestWebKitAPI/win/TestWebKitAPI.sln:
3191         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3192         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
3193         * WebKitAPITest/WebKitAPITest.vcproj:
3194         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3195         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3196         * WebKitTestRunner/WebKitTestRunner.sln:
3197         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3198         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
3199         * record-memory-win/record-memory-win.vcproj:
3200
3201 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3202
3203         Build fix - as per DRT-mac, always enabled developer extras,
3204         in win/qt/gtk DRT.
3205
3206         This is necessary to enable rich exception messages to be generated
3207         following https://bugs.webkit.org/show_bug.cgi?id=49708.
3208
3209         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3210         (shouldEnableDeveloperExtras):
3211         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3212         (WebCore::shouldEnableDeveloperExtras):
3213         * DumpRenderTree/win/DumpRenderTree.cpp:
3214         (shouldEnableDeveloperExtras):
3215
3216 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3217
3218         Unreviewed, rolling out r72357.
3219         http://trac.webkit.org/changeset/72357
3220         https://bugs.webkit.org/show_bug.cgi?id=49784
3221
3222         It broke test-webkitpy tests since the patch didn't have the
3223         corresponding test update (Requested by kinuko on #webkit).
3224
3225         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3226         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3227
3228 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
3229
3230         Reviewed by Tony Chang.
3231
3232         Rebaseline server: add rebaseline queue
3233         https://bugs.webkit.org/show_bug.cgi?id=49763
3234         
3235         Add a UI queue (a multi-item <select>) where tests to be baselined
3236         can be enqueued (also supports basic removal). A queue is used instead
3237         of immediately doing rebaselines since SCM operations can take a while.
3238         It's better to go through lots of tests quickly to mark them as
3239         needing rebaselining and then batch the SCM operations.
3240         
3241         Also adds a simple log where results can be displayed.
3242
3243         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3244         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3245         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3246         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
3247         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3248         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3249
3250 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3251
3252         Reviewed by Oliver Hunt.
3253
3254         Bug 49708 - Stop recompiling functions to regenerate exception info.
3255
3256         Instead only hold info as necessary – keep divot info is the inspector
3257         is enabled, line number info is debugging or profiling, and handler
3258         info for functions with try/catch.
3259
3260         * DumpRenderTree/mac/DumpRenderTree.mm:
3261         (shouldEnableDeveloperExtras):
3262             - always enable the developer tools from DRT, to ensure we
3263               produce rich error messages on JavaScript exceptions.
3264
3265 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
3266
3267         Reviewed by Ojan Vafai.
3268
3269         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3270         https://bugs.webkit.org/show_bug.cgi?id=49702
3271
3272         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3273         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3274
3275 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
3276
3277         Reviewed by Tony Chang.
3278
3279         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
3280
3281         Create the first version of the 'message_broker' package. This
3282         class will encapsulate all of the threading/multiprocessing and
3283         message-sending details for the communication between the
3284         'manager' object and the 'worker' objects. For the moment, it
3285         just holds some routines and tests for logging thread stacks.
3286
3287         There should be no functional changes in this patch, just moving stuff
3288         around.
3289
3290         https://bugs.webkit.org/show_bug.cgi?id=49707
3291
3292         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3293         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
3294         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
3295         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
3296         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3297         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3298
3299 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3300
3301         Reviewed by Adam Roben.
3302
3303         Remove leftover Windows Debug_Internal configurations
3304         https://bugs.webkit.org/show_bug.cgi?id=49758
3305
3306         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3307         * DumpRenderTree/win/DumpRenderTree.vcproj:
3308         * DumpRenderTree/win/ImageDiff.vcproj:
3309         * MiniBrowser/MiniBrowser.vcproj:
3310         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3311         * WebKitAPITest/WebKitAPITest.vcproj:
3312         * WebKitTestRunner/win/InjectedBundle.vcproj:
3313         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3314         * WinLauncher/WinLauncher.vcproj:
3315
3316 2010-11-18  Adam Roben  <aroben@apple.com>
3317
3318         Add three new Windows XP build slaves
3319
3320         Reviewed by Steve Falkenburg.
3321
3322         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
3323         new slaves, and added them to the Windows XP Debug (Tests) builder.
3324
3325 2010-11-18  Daniel Bates  <dbates@rim.com>
3326
3327         Reviewed by Adam Roben.
3328
3329         update-webkit-support-libs should fall back to existing
3330         WebKitSupportLibrary version if there is no internet connectivity
3331         https://bugs.webkit.org/show_bug.cgi?id=49503
3332
3333         Fall back to existing support libraries (if present) when there is
3334         no internet connection.
3335
3336         Currently, update-webkit-support-libs dies with an "out-of-date"
3337         error when there is no internet connection because it cannot
3338         retrieve versioning information from developer.apple.com. Because
3339         update-webkit-support-libs fails, build-webkit fails. Instead,
3340         if there is no internet connection and the support libraries are
3341         present then we should warn the user and exit() with success so
3342         that build-webkit can work without an internet connection.
3343
3344         * Scripts/update-webkit-support-libs:
3345
3346 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3347
3348         Reviewed by Adam Roben.
3349
3350         Debug_Internal Windows configuration is unnecessary, should be removed
3351         https://bugs.webkit.org/show_bug.cgi?id=49753
3352
3353         * DumpRenderTree/win/DumpRenderTree.cpp:
3354         * MiniBrowser/win/stdafx.h:
3355         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3356         * WebKitTestRunner/win/TestControllerWin.cpp:
3357
3358 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3359
3360         Reviewed by Adam Roben.
3361
3362         Clean up vcproj errors
3363         https://bugs.webkit.org/show_bug.cgi?id=49741
3364
3365         * MiniBrowser/MiniBrowser.vcproj:
3366         * WebKitAPITest/WebKitAPITest.vcproj:
3367         * WebKitTestRunner/win/InjectedBundle.vcproj:
3368         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3369
3370 2010-11-18  Hayato Ito  <hayato@chromium.org>
3371
3372         Reviewed by Shinichiro Hamaji.
3373
3374         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
3375         which is caused by r72249.
3376
3377         https://bugs.webkit.org/show_bug.cgi?id=49751
3378
3379         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3380
3381 2010-11-18  Adam Roben  <aroben@apple.com>
3382
3383         Implement layoutTestController.waitForPolicyDelegate on Windows
3384
3385         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
3386
3387         Reviewed by Simon Fraser.
3388
3389         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3390         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
3391         code from LayoutTestControllerMac.mm.
3392
3393 2010-11-18  Hayato Ito  <hayato@chromium.org>
3394
3395         Reviewed by Shinichiro Hamaji.
3396
3397         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
3398
3399         https://bugs.webkit.org/show_bug.cgi?id=49740
3400
3401         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3402
3403 2010-11-18  Tony Chang  <tony@chromium.org>
3404
3405         Reviewed by Adam Barth.
3406
3407         run platform/chromium/plugins/refcount-leaks.html on all platforms
3408         https://bugs.webkit.org/show_bug.cgi?id=49485
3409
3410         Add PluginObject.testObjectCount which returns the number of allocated
3411         TestObjects. Add PluginObject.testCreateTestObject which allocates
3412         and returns a TestObject.
3413
3414         Add TestObject.refCount which returns the number of refs on the
3415         TestObject.
3416
3417         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3418         (pluginGetProperty):
3419         (pluginInvoke):
3420         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3421         (getTestObjectCount):
3422         (testAllocate):
3423         (testDeallocate):
3424         (testGetProperty):
3425         (testScriptObjectInvoke): Release a ref to a plugin object that was
3426             previously leaked.
3427         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
3428
3429 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3430
3431         Reviewed by Adam Roben.
3432
3433         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
3434         https://bugs.webkit.org/show_bug.cgi?id=49711
3435
3436         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
3437         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
3438         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
3439         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3440         * record-memory-win/record-memory-win-common.vsprops: Added.
3441         * record-memory-win/record-memory-win.vcproj:
3442
3443 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
3444
3445         Reviewed by Csaba Osztrogonác.
3446
3447         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
3448
3449         * MiniBrowser/qt/BrowserWindow.cpp:
3450         (BrowserWindow::updateUserAgentList):
3451
3452 2010-11-17  Adam Roben  <aroben@apple.com>
3453
3454         Don't trigger Windows builds when chromium-win test results change
3455
3456         Reviewed by Mark Rowe.
3457
3458         * Scripts/webkitpy/common/config/build.py:
3459         (_should_file_trigger_build): Changed the regular expression used to
3460         search for directory names to only consider full directory names,
3461         rather than matching directory names where the string we care about is
3462         a suffix of the name.
3463
3464         * Scripts/webkitpy/common/config/build_unittest.py:
3465         (ShouldBuildTest): Added a test.
3466
3467 2010-11-17  Hayato Ito  <hayato@chromium.org>
3468
3469         Reviewed by Shinichiro Hamaji.
3470
3471         Remove a uri member from TestInput class.
3472
3473         https://bugs.webkit.org/show_bug.cgi?id=49691
3474
3475         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3476         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3477
3478 2010-11-17  Adam Roben  <aroben@apple.com>
3479
3480         Move FindSafari's settings into a vsprops file
3481
3482         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
3483
3484         Reviewed by Steve Falkenburg.
3485
3486         * FindSafari/FindSafari.vcproj:
3487         * FindSafari/FindSafariCommon.vsprops: Added.
3488
3489 2010-11-17  Adam Roben  <aroben@apple.com>
3490
3491         Use a minimum font size of 0 in DRT on Windows
3492
3493         This is the Windows equivalent of r72164.
3494
3495         Rubber-stamped by Dave Hyatt.
3496
3497         * DumpRenderTree/win/DumpRenderTree.cpp:
3498         (resetDefaultsToConsistentValues):
3499
3500 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
3501
3502         Reviewed by Andreas Kling.
3503
3504         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
3505         https://bugs.webkit.org/show_bug.cgi?id=49639
3506
3507         * Scripts/webkitpy/common/checkout/scm.py:
3508
3509 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
3510
3511         Reviewed by Tony Chang.
3512
3513         Rebaseline server: add loupe for image diffs
3514         https://bugs.webkit.org/show_bug.cgi?id=49692
3515         
3516         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
3517         enlarged area of the expected, actual and diff images side by side.
3518
3519         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3520         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
3521         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3522         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3523
3524 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3525
3526         Reviewed by Adam Roben.
3527
3528         WebKitLauncherWin should use vsprops for shared build settings
3529         https://bugs.webkit.org/show_bug.cgi?id=49696
3530
3531         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3532         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
3533
3534 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3535
3536         Reviewed by Adam Roben.
3537
3538         WinLauncher should use vsprops for shared build settings
3539         https://bugs.webkit.org/show_bug.cgi?id=49695
3540
3541         * WinLauncher/WinLauncher.cpp:
3542         (_tWinMain):
3543         (PrintView):
3544         (WndProc):
3545         (MyEditProc):
3546         * WinLauncher/WinLauncher.vcproj:
3547         * WinLauncher/WinLauncherCommon.vsprops: Added.
3548
3549 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3550
3551         Delete unused file unintentionally added in last change.
3552
3553         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
3554
3555 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3556
3557         Reviewed by Adam Roben.
3558
3559         DumpRenderTree on Windows should use a vsprops file for shared project settings
3560         https://bugs.webkit.org/show_bug.cgi?id=49690
3561
3562         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3563         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
3564         * DumpRenderTree/win/DumpRenderTree.vcproj:
3565         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
3566         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
3567         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
3568         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
3569         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
3570         * DumpRenderTree/win/ImageDiff.vcproj:
3571         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
3572
3573 2010-11-17  Hayato Ito  <hayato@chromium.org>
3574
3575         Refactor TestTypeBase.compare_output().
3576
3577         Introduce a TestOutput class and update compare_output() of each test
3578         types so that they can take both actual and expected TestOutput objects.
3579
3580         https://bugs.webkit.org/show_bug.cgi?id=49431
3581
3582         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3583         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
3584         * Scripts/webkitpy/layout_tests/port/base.py:
3585         * Scripts/webkitpy/layout_tests/port/chromium.py:
3586         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3587         * Scripts/webkitpy/layout_tests/port/test.py:
3588         * Scripts/webkitpy/layout_tests/port/webkit.py:
3589         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3590         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3591         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3592         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3593
3594 2010-11-17  Adam Roben  <aroben@apple.com>
3595
3596         Make each Windows Test builder use the same OS for all its slaves
3597
3598         Currently each WebKit1 Windows Test builder has one Windows XP slave
3599         and one Windows 7 slave. Having different OSes in a single builder
3600         meant that the builders would alternate between red and green when
3601         there were OS-specific failures.
3602
3603         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
3604         between red and green because of multiple OS versions
3605
3606         Reviewed by Mark Rowe.
3607
3608         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
3609         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
3610         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
3611         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
3612         builders for the two WebKit1 builders so that they would all use the
3613         appropriate OS.
3614
3615 2010-11-17  James Robinson  <jamesr@chromium.org>
3616
3617         Reviewed by Dan Bernstein.
3618
3619         [chromium] Set minimum font size to 0 for DRT
3620         https://bugs.webkit.org/show_bug.cgi?id=49677
3621
3622         Followup for http://trac.webkit.org/changeset/72141.
3623
3624         Test: http/tests/misc/acid3.html
3625
3626         * DumpRenderTree/chromium/WebPreferences.cpp:
3627         (WebPreferences::reset):
3628
3629 2010-11-17  Andras Becsi  <abecsi@webkit.org>
3630
3631         Unreviewed build fix.
3632
3633         [Qt] Add missing file I forgot in r72220.
3634
3635         * MiniBrowser/MiniBrowser.qrc: Added.
3636
3637 2010-11-17  Andras Becsi  <abecsi@webkit.org>
3638
3639         Reviewed by Andreas Kling.
3640
3641         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
3642         https://bugs.webkit.org/show_bug.cgi?id=49627
3643
3644         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
3645
3646         * MiniBrowser/MiniBrowser.qrc: Added.
3647         Add it here to prevent qmake from detecting it
3648         since it needs to be copied to the build directory.
3649         * MiniBrowser/qt/BrowserWindow.cpp:
3650         (BrowserWindow::BrowserWindow):
3651         (BrowserWindow::updateUserAgentList):
3652         (BrowserWindow::showUserAgentDialog):
3653         * MiniBrowser/qt/BrowserWindow.h:
3654         * MiniBrowser/qt/MiniBrowser.pro:
3655
3656 2010-11-17  Adam Roben  <aroben@apple.com>
3657
3658         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
3659
3660         We use that file on Windows!
3661
3662         Fixes <http://webkit.org/b/49643> Changes to
3663         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
3664
3665         Reviewed by Steve Falkenburg.
3666
3667         * Scripts/webkitpy/common/config/build.py:
3668         (_should_file_trigger_build): Added the mac-wk2 directory and make it
3669         trigger builds on SnowLeopard and Windows.
3670
3671         * Scripts/webkitpy/common/config/build_unittest.py:
3672         (ShouldBuildTest.test_should_build): Added a test.
3673
3674 2010-11-17  Satish Sampath  <satish@chromium.org>
3675
3676         Reviewed by Jeremy Orlow.
3677
3678         Clear the speech input mock explicitly before each test.
3679         https://bugs.webkit.org/show_bug.cgi?id=49660
3680
3681         * DumpRenderTree/chromium/LayoutTestController.cpp:
3682         (LayoutTestController::setMockSpeechInputResult):
3683         * DumpRenderTree/chromium/LayoutTestController.h:
3684         * DumpRenderTree/chromium/WebViewHost.cpp:
3685         (WebViewHost::speechInputController):
3686         (WebViewHost::reset): Invoke speech input mock's clearResults method.
3687         * DumpRenderTree/chromium/WebViewHost.h:
3688         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
3689
3690 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
3691
3692         Unreviewed, specify IRC nickname in committers.py.
3693
3694         * Scripts/webkitpy/common/config/committers.py:
3695
3696 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3697
3698         Reviewed by Tony Chang.
3699
3700         [NRWT] Make http locking similar to perl implementation
3701         https://bugs.webkit.org/show_bug.cgi?id=49187
3702
3703         * Scripts/webkitpy/common/system/file_lock.py: Added.
3704         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
3705         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3706
3707 2010-11-17  MORITA Hajime  <morrita@google.com>
3708
3709         Reviewed by Kent Tamura.
3710
3711         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
3712         https://bugs.webkit.org/show_bug.cgi?id=49366
3713
3714         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
3715           according to the spellchecker suggestion
3716         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
3717
3718         test_expectations.txt will be changed after this change is ported to test_shell.
3719         
3720         * DumpRenderTree/chromium/EventSender.cpp:
3721         (makeMenuItemStringsFor):
3722         (EventSender::contextClick):
3723         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3724         (MockSpellCheck::fillSuggestionList):
3725         (MockSpellCheck::initializeIfNeeded):
3726         * DumpRenderTree/chromium/MockSpellCheck.h:
3727         * DumpRenderTree/chromium/WebViewHost.cpp:
3728         (WebViewHost::mockSpellCheck):
3729         * DumpRenderTree/chromium/WebViewHost.h:
3730
3731 2010-11-16  Dave Hyatt  <hyatt@apple.com>
3732
3733         Reviewed by Sam Weinig.
3734
3735         Make sure the pref for minimum font size is just explicitly set to 0 every time,
3736         since the bots have 1 stuck in their plist otherwise.
3737
3738         * DumpRenderTree/mac/DumpRenderTree.mm:
3739         (resetDefaultsToConsistentValues):
3740
3741 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
3742
3743         Reviewed by Tony Chang.
3744
3745         Rebaseline server: compute diffs client-side
3746         https://bugs.webkit.org/show_bug.cgi?id=49640
3747         
3748         The image diff output from the DRT is pretty bad on some ports (at
3749         least the Mac one), so it's better to compute diffs on the client by
3750         using <canvas>.
3751
3752         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3753         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3754         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3755
3756 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
3757
3758         Reviewed by Tony Chang.
3759
3760         Rebaseline server: display test results
3761         https://bugs.webkit.org/show_bug.cgi?id=49626
3762         
3763         Adds basic result display to the rebaseline server. On the Python side
3764         this involves:
3765         - Parsing the unexpected_results.json into a dictionary.
3766         - Serving it as JSON under /results.json.
3767         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
3768         but I'll need to have access to the parsed results on the Python side
3769         for follow-up changes).
3770         
3771         On the web UI side this adds:
3772         - Markup for display image and text results (expected, actual, diff),
3773           and JS for populating it.
3774         - Markup for breaking down test results by failure type and directory,
3775           and JS for populating it.
3776
3777         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3778         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3779         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3780         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
3781         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3782
3783 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
3784
3785         Reviewed by Ojan Vafai.
3786
3787         See Chromium issue http://codereview.chromium.org/5133001/ - we
3788         are modifying the build bots to pass in the builder name with
3789         the "GPU" string appended instead of appending it in the code.
3790
3791         https://bugs.webkit.org/show_bug.cgi?id=49636
3792
3793         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3794
3795 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
3796
3797         Reviewed by Adam Roben.
3798
3799         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
3800         https://bugs.webkit.org/show_bug.cgi?id=49632
3801
3802         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3803         * DumpRenderTree/win/DumpRenderTree.vcproj:
3804         * DumpRenderTree/win/ImageDiff.vcproj:
3805         * MiniBrowser/MiniBrowser.vcproj:
3806         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3807         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3808         * WebKitTestRunner/win/InjectedBundle.vcproj:
3809         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3810         * WinLauncher/WinLauncher.vcproj:
3811         * record-memory-win/record-memory-win.vcproj:
3812
3813 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
3814
3815         Reviewed by Ojan Vafai.
3816
3817         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
3818
3819         Rename the TestInfo class to TestInput to be clearer about its
3820         function, and move the checksum-reading code into dump_render_tree_thread
3821         to avoid cross-thread access.
3822
3823         https://bugs.webkit.org/show_bug.cgi?id=49573
3824
3825         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3826         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3827         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3828
3829 2010-11-16  Dave Hyatt  <hyatt@apple.com>
3830
3831         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
3832
3833         * DumpRenderTree/mac/DumpRenderTree.mm:
3834         (resetDefaultsToConsistentValues):
3835
3836 2010-11-16  Stephanie Lewis  <slewis@apple.com>
3837
3838         Reviewed by Geoff Garen.
3839
3840         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
3841
3842         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
3843         for every WebView, and the WebKit API doesn't support that ownership model.
3844
3845         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
3846
3847         * DumpRenderTree/mac/DumpRenderTree.mm:
3848         (createWebViewAndOffscreenWindow):
3849         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3850         (LayoutTestController::setMockDeviceOrientation):
3851
3852 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
3853
3854         Reviewed by Ojan Vafai.
3855
3856         new-run-webkit-tests: log the process id in --verbose mode
3857
3858         As part of the switch to multi-process mode, we should log the
3859         process id when running w/ --verbose.
3860
3861         https://bugs.webkit.org/show_bug.cgi?id=49571
3862
3863         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3864
3865 2010-11-16  Adam Roben  <aroben@apple.com>
3866
3867         Only trigger Windows builds when files that we actually use on Windows
3868         are changed
3869
3870         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
3871         It uses the new webkitpy.common.config.build module to determine
3872         whether a particular change should trigger a build on a particular
3873         platform. The Windows builders have been switched to use a
3874         PlatformSpecificScheduler.
3875
3876         The logic to determine whether or not a particular change should
3877         trigger a build on a given platform has only been implemented/tested
3878         for Windows. I tried to make it easy to add more platforms in the
3879         future, but I don't have enough familiarity with all platforms to be
3880         able to implement it for them.
3881
3882         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
3883         lots irrelevant changes (e.g., rebaselining Chromium test results)
3884
3885         Reviewed by Eric Seidel.
3886
3887         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
3888         PlatformSpecificScheduler for the Windows builders.
3889
3890         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3891         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
3892         up a ChangeFilter that filters to our branch and will call through to
3893         our filter method, and calls up to our base class.
3894         (PlatformSpecificScheduler.filter): Calls through to
3895         build.should_build to find out whether we should trigger a build for
3896         this change.
3897
3898         * Scripts/webkitpy/common/net/build.py: Added.
3899         (_should_file_trigger_build): Uses a set of directories and regexp
3900         patterns to determine whether the given file should trigger a build on
3901         the given platform. As mentioned earlier, this has only been
3902         implemented for Windows, though I did try to make some guesses about
3903         other platforms.
3904         (should_build): Returns true if any of the files should trigger a
3905         build on the given platform.
3906
3907         * Scripts/webkitpy/common/net/build_unittest.py: Added.
3908         (ShouldBuildTest.test_should_build): Does some basic testing to make
3909         sure we're triggering builds for the right files. It only tests
3910         Windows for now, though I tried to make some guesses about other
3911         platforms.
3912
3913 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
3914
3915         Reviewed by Andreas Kling.
3916
3917         [Qt] Remove synchronous QWebPage::checkPermissions signal
3918         https://bugs.webkit.org/show_bug.cgi?id=46810
3919
3920         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3921         (WebCore::WebPage::WebPage):
3922         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3923         (LayoutTestController::grantDesktopNotificationPermission): When granting
3924         permission, grant it directly on the QWebPage/Frame, that will remember it.
3925         * QtTestBrowser/webpage.cpp:
3926         (WebPage::WebPage):
3927         * QtTestBrowser/webpage.h:
3928
3929
3930 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
3931
3932         Reviewed by Csaba Osztrogonác.
3933
3934         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
3935
3936         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3937         (LayoutTestController::reset):
3938         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3939         (LayoutTestController::isPrinting):
3940         (LayoutTestController::setPrinting):
3941
3942 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
3943
3944         Reviewed by Andreas Kling.
3945
3946         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
3947         https://bugs.webkit.org/show_bug.cgi?id=49587
3948
3949         * MiniBrowser/qt/BrowserView.cpp:
3950         (BrowserView::BrowserView): Added BackingStoreType
3951         argument to ctor. Propagating it to the QGraphicsWKView.
3952         * MiniBrowser/qt/BrowserView.h:
3953         * MiniBrowser/qt/BrowserWindow.cpp:
3954         (BrowserWindow::BrowserWindow):
3955         (BrowserWindow::newWindow): Create the new BrowserWindow
3956         with the same BackingStoreType that this instance has.
3957         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
3958         * MiniBrowser/qt/main.cpp:
3959         (main): Use tiled backing store if got -tiled command line argument.
3960         Avoid redundant copy of command line args.
3961
3962 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
3963
3964         Reviewed by Jeremy Orlow.
3965
3966         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
3967         https://bugs.webkit.org/show_bug.cgi?id=48506
3968
3969         This ensures that there is one mock per page WebView / WebViewHost. This is a
3970         design constraint of the DeviceOrientationClientMock because the m_controller
3971         field can only store a pointer to a single instance of the corresponding
3972         DeviceOrientationController.
3973
3974         Test: fast/dom/DeviceOrientation/no-page-cache.html
3975
3976         * DumpRenderTree/chromium/LayoutTestController.cpp:
3977         (LayoutTestController::setMockDeviceOrientation):
3978         (LayoutTestController::deviceOrientationClientMock):
3979         * DumpRenderTree/chromium/LayoutTestController.h:
3980         * DumpRenderTree/chromium/WebViewHost.cpp:
3981         (WebViewHost::deviceOrientationClientMock):
3982         (WebViewHost::deviceOrientationClient):
3983         (WebViewHost::reset):
3984         * DumpRenderTree/chromium/WebViewHost.h:
3985
3986 2010-11-15  Andras Becsi  <abecsi@webkit.org>
3987
3988         Reviewed by Andreas Kling.
3989
3990         [Qt][WK2] Avoid polling in WebKitTestRunner.
3991         https://bugs.webkit.org/show_bug.cgi?id=49542
3992
3993         Make the WK2 testing session about 10-15% faster and decrease random flakiness
3994         resulting from timing skew by removing the millisecond polling from TestControllerQt.
3995
3996         * WebKitTestRunner/TestController.cpp:
3997         (WTR::TestController::didFinishLoadForFrame):
3998         * WebKitTestRunner/TestController.h:
3999         * WebKitTestRunner/TestInvocation.cpp:
4000         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4001         * WebKitTestRunner/mac/TestControllerMac.mm:
4002         (WTR::TestController::notifyDone): Add method stub.
4003         * WebKitTestRunner/qt/TestControllerQt.cpp:
4004         (WTR::TestControllerRunLoop::instance):
4005         (WTR::TestControllerRunLoop::start):
4006         (WTR::TestControllerRunLoop::stop):
4007         (WTR::TestControllerRunLoop::TestControllerRunLoop):
4008         (WTR::TestControllerRunLoop::timerEvent):
4009         (WTR::TestController::notifyDone):
4010         (WTR::TestController::platformRunUntil):
4011         * WebKitTestRunner/win/TestControllerWin.cpp:
4012         (WTR::TestController::notifyDone): Add method stub.
4013
4014 2010-11-15  Darin Adler  <darin@apple.com>
4015
4016         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
4017
4018 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
4019
4020         Reviewed by Andreas Kling.
4021
4022         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
4023         https://bugs.webkit.org/show_bug.cgi?id=49544
4024
4025         Add the shortcut to BrowserWindow.
4026
4027         * MiniBrowser/qt/BrowserWindow.cpp:
4028         (BrowserWindow::BrowserWindow):
4029         (BrowserWindow::openLocation):
4030         * MiniBrowser/qt/BrowserWindow.h:
4031
4032 2010-11-14  David Levin  <levin@chromium.org>
4033
4034         Reviewed by Daniel Bates.
4035
4036         check-webkit-style should detect PassRefPtr usage in functions.
4037         https://bugs.webkit.org/show_bug.cgi?id=49513
4038
4039         * Scripts/webkitpy/style/checkers/cpp.py:
4040         (check_for_function_lengths): Revert a comment change that I
4041          accidentally made in r71986.
4042         (check_pass_ptr_usage): Added the code to do the check.
4043         (process_line): Added the call to check_pass_ptr_usage.
4044         (CppChecker): Added the new error category.
4045         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4046         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
4047          testing purposes.
4048         (PassPtrTest::*): The class/functions to unit test the new
4049          functionality.
4050
4051 2010-11-14  David Levin  <levin@chromium.org>
4052
4053         Reviewed by Shinichiro Hamaji.
4054
4055         check-webkit-style function detection and the line count style checks should be separate.
4056         https://bugs.webkit.org/show_bug.cgi?id=49512
4057
4058         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
4059         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
4060           call the detection function and fix line counts in two places now that
4061           the code really only counts the lines in the body of the function.
4062
4063 2010-11-14  Andreas Kling  <kling@webkit.org>
4064
4065         Reviewed by Antonio Gomes.
4066
4067         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
4068         https://bugs.webkit.org/show_bug.cgi?id=33438
4069
4070         Stifle "Unhandled variable" warning to match what the other
4071         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
4072         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
4073
4074         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
4075         (webkit_test_plugin_get_value):
4076
4077 2010-11-13  David Levin  <levin@chromium.org>
4078
4079         Reviewed by Eric Seidel.
4080
4081         check-webkit-style function detection crashes on functions in templates.
4082         https://bugs.webkit.org/show_bug.cgi?id=49504
4083
4084         For example "template <bool shouldClose(const Element*)>".
4085
4086         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
4087         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
4088           function detection test to expose this issue.
4089
4090 2010-11-12  David Levin  <levin@chromium.org>
4091
4092         Reviewed by Shinichiro Hamaji.
4093
4094         check-webkit-style function detection doesn't detect indented functions declaractions.
4095         https://bugs.webkit.org/show_bug.cgi?id=49446
4096
4097         Indented function declarations occur inside class definitions, so
4098         they are a pretty common (and worth detecting).
4099
4100         * Scripts/webkitpy/style/checkers/cpp.py:
4101           Changed regex to allow indentation.
4102           Changed the function start detection to only happen when not in a
4103           function.
4104           Changed function end detection to work based on matching braces
4105           instead of finding a close brace at the beginning of the line.
4106           Fixed close_expression to do what it says when it doesn't find
4107           the close.
4108         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
4109
4110 2010-11-12  Daniel Bates  <dbates@rim.com>
4111
4112         Rubber-stamped by Nikolas Zimmermann.
4113
4114         Make do-file-rename rename files in the directory WebKit2.
4115
4116         This also makes the list of searched directories in do-file-rename
4117         consistent with the list of searched directories in the script do-webcore-rename.
4118
4119         * Scripts/do-file-rename:
4120
4121 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
4122
4123         Reviewed by James Robinson.
4124
4125         Attempt yet again to land the fix for bug 49360 (respecting
4126         set-webkit-configuration). We need to handle the cases where
4127         trying to run webkit-build-directory to find out where the
4128         default configuration might be fails (that shows up on some
4129         Chromium bots that apparently don't have perl installed).
4130
4131         https://bugs.webkit.org/show_bug.cgi?id=49360
4132
4133         * Scripts/webkitpy/layout_tests/port/config.py:
4134         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
4135         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
4136
4137 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
4138
4139         Reviewed by Adam Barth.
4140
4141         webkit-patch land logs commit message twice
4142         https://bugs.webkit.org/show_bug.cgi?id=49482
4143         
4144         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
4145         that's just the commit message, which we now output following the
4146         actual commit.
4147
4148         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4149
4150 2010-11-12  Tony Chang  <tony@chromium.org>
4151
4152         Reviewed by Adam Barth.
4153
4154         run platform/chromium/plugins/script-object-invoke.html on all platforms
4155         https://bugs.webkit.org/show_bug.cgi?id=49280
4156
4157         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
4158         (testScriptObjectInvoke):
4159         (pluginInvoke):
4160
4161 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
4162
4163         Reviewed by Adam Barth.
4164
4165         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
4166         https://bugs.webkit.org/show_bug.cgi?id=49471
4167
4168         Right now there's no indication of a successful commit.
4169         
4170         * Scripts/webkitpy/tool/commands/download_unittest.py:
4171         * Scripts/webkitpy/tool/steps/commit.py:
4172
4173 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
4174
4175         Reviewed by Ojan Vafai.
4176
4177         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
4178         https://bugs.webkit.org/show_bug.cgi?id=49354
4179
4180         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
4181
4182         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
4183         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4184         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4185         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4186
4187 2010-11-12  Tony Chang  <tony@chromium.org>
4188
4189         Reviewed by Kent Tamura.
4190
4191         [chromium] Load a blank page when closing DRT WebViewHosts
4192         https://bugs.webkit.org/show_bug.cgi?id=49417
4193
4194         In test_shell, when we close a window, we first load about:blank
4195         and run GC to fire the destruction logic of the page.  In test_shell,
4196         this happens in ~TestShell.  In DRT, we manage virtual windows as
4197         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
4198
4199         Managing focus is a bit trickier, since normally you would get window
4200         events to reset the focus to the right window.  We do it manually
4201         instead.
4202
4203         This fixes 2 plugin tests on DRT.
4204
4205         * DumpRenderTree/chromium/TestShell.cpp:
4206         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
4207         (TestShell::closeWindow): Move widget close() to WVH destructor and
4208             manage focus manually.
4209         (TestShell::closeRemainingWindows): Comment typo.
4210         * DumpRenderTree/chromium/WebViewHost.cpp:
4211         (WebViewHost::closeWidget):
4212         (invokeCloseWidget):
4213         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
4214             test_shell).
4215         (WebViewHost::~WebViewHost):
4216         *