WebKitTools/ChangeLog

   1 2009-12-01  Adam Barth  <abarth@webkit.org>
   2
   3         Reviewed by Eric Seidel.
   4
   5         check-webkit-style complains about #imports with / in them
   6         https://bugs.webkit.org/show_bug.cgi?id=32022
   7
   8         We need to exclude #import directives in addition to #include from the
   9         binary operator whitespace checks.
  10
  11         * Scripts/modules/cpp_style.py:
  12         * Scripts/modules/cpp_style_unittest.py:
  13
  14 2009-11-30  Adam Barth  <abarth@webkit.org>
  15
  16         Reviewed by Eric Seidel.
  17
  18         check-webkit-style is slightly too verbose
  19         https://bugs.webkit.org/show_bug.cgi?id=32010
  20
  21         check-webkit-style prints out a bunch of "done" lines that seem redundant,
  22         especially for the style-queue.
  23
  24         * Scripts/modules/cpp_style.py:
  25
  26 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
  27
  28         Reviewed by Eric Seidel.
  29
  30         [GTK] Moved the functions that are closing the result log of the
  31         tests to the last line of the runTest function, this avoids
  32         reporting crashes in the wrong test if there is a problem when
  33         reseting the state after the test.
  34
  35         * DumpRenderTree/gtk/DumpRenderTree.cpp:
  36         (dump):
  37         (runTest):
  38
  39 2009-11-30  Sam Weinig  <sam@webkit.org>
  40
  41         Reviewed by Geoffrey Garen.
  42
  43         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
  44         fast/js/date-proto-generic-invocation breaks another test
  45
  46         Don't cache JSClassRefs, a change to the prototype chain will
  47         last between tests.
  48
  49         * DumpRenderTree/AccessibilityController.cpp:
  50         (AccessibilityController::getJSClass):
  51         * DumpRenderTree/GCController.cpp:
  52         (GCController::getJSClass):
  53         * DumpRenderTree/GCController.h:
  54         * DumpRenderTree/LayoutTestController.cpp:
  55         (LayoutTestController::getJSClass):
  56
  57 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
  58
  59         Reviewed by Alexey Proskuryakov.
  60
  61         Update pywebsocket to 0.4.2.1.
  62         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
  63         https://bugs.webkit.org/show_bug.cgi?id=31976
  64
  65         * pywebsocket/mod_pywebsocket/standalone.py:
  66         * pywebsocket/setup.py:
  67
  68 2009-11-30  Adam Barth  <abarth@webkit.org>
  69
  70         Reviewed by Eric Seidel.
  71
  72         [bzt] Generate pass messages for style-queue
  73         https://bugs.webkit.org/show_bug.cgi?id=31995
  74
  75         With this change, the style-queue posts "pass" messages to bugs as
  76         well.  Also, added more information to the state store w.r.t. passing
  77         and failing.
  78
  79         * Scripts/modules/commands/queues.py:
  80         * Scripts/modules/patchcollection.py:
  81
  82 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
  83
  84         Reviewed by Simon Fraser.
  85
  86         Check for WEBKIT_TESTFONTS environment variable in
  87         run-webkit-tests, for GTK+, to have a more prominent error
  88         message.
  89
  90         * Scripts/run-webkit-tests:
  91
  92 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
  93
  94         Reviewed by Dimitri Glazkov.
  95
  96         update-webkit --chromium forces gclient sync
  97
  98         https://bugs.webkit.org/show_bug.cgi?id=31967
  99
 100         * Scripts/update-webkit-chromium:
 101
 102 2009-11-29  Eric Seidel  <eric@webkit.org>
 103
 104         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
 105
 106         * Scripts/modules/committers.py:
 107
 108 2009-11-29  Eric Seidel  <eric@webkit.org>
 109
 110         No review, just adding missing svn property.
 111
 112         Set svn:executable property on new scripts.
 113         These were added by commit-queue commits, but the executable
 114         property was lost due to a bug in svn-apply:
 115         https://bugs.webkit.org/show_bug.cgi?id=27204
 116
 117         * Scripts/update-webkit-chromium: Added property svn:executable.
 118         * Scripts/validate-committer-lists: Added property svn:executable.
 119
 120 2009-11-29  Eric Seidel  <eric@webkit.org>
 121
 122         Reviewed by Adam Barth.
 123
 124         Need a way to validate that committers.py includes all committers/reviewers
 125         https://bugs.webkit.org/show_bug.cgi?id=30970
 126
 127         Add a script which knows how to compare our public committer/reviewer
 128         lists and show discrepancies between them.
 129
 130         Validates mailing lists vs. committers.py:
 131         - committers.py committers missing from webkit-committers@lists
 132         - webkit-committers@lists members missing from committers.py
 133         - committers.py reviewers missing from webkit-reviewers@lists
 134         - webkit-reviewers@lists members missing from committers.py
 135         - webkit-reviewers@lists members missing from committers.py reviewer list
 136
 137         Validates committers.py vs. trunk/ SVN history:
 138         - committers who have not committed in over a year
 139         - SVN committers missing from committers.py
 140         - committers.py members who have no record in SVN.
 141
 142         All of these lists still show "false positives" until a few more committers.py updates are made, like:
 143         https://bugs.webkit.org/show_bug.cgi?id=31366
 144
 145         * Scripts/validate-committer-lists: Added.
 146
 147 2009-11-28  Adam Barth  <abarth@webkit.org>
 148
 149         Reviewed by Eric Seidel.
 150
 151         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
 152         https://bugs.webkit.org/show_bug.cgi?id=31950
 153
 154         Now we cache the last status that we get back from QueueStatusServer.
 155         Eventually we'll have to do something more fancy if we want to support
 156         a "try again" button on QueueStatusServer, but we can cross that bridge
 157         when we come to it.
 158
 159         * Scripts/modules/patchcollection.py:
 160
 161 2009-11-28  Adam Barth  <abarth@webkit.org>
 162
 163         Reviewed by Eric Seidel.
 164
 165         StyleQueue scans ~100 bug pages every 5 minutes
 166         https://bugs.webkit.org/show_bug.cgi?id=31947
 167
 168         Instead of getting the pending-review attachment ids by scanning each
 169         bug (which results in a network request), we should just get them all
 170         from webkit.org/pending-review in one shot.
 171
 172         * Scripts/modules/bugzilla.py:
 173         * Scripts/modules/bugzilla_unittest.py:
 174         * Scripts/modules/commands/queries.py:
 175         * Scripts/modules/commands/queries_unittest.py:
 176         * Scripts/modules/commands/queues.py:
 177         * Scripts/modules/mock_bugzillatool.py:
 178         * Scripts/modules/patchcollection.py:
 179
 180 2009-11-28  Adam Barth  <abarth@webkit.org>
 181
 182         Reviewed by Eric Seidel.
 183
 184         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
 185         https://bugs.webkit.org/show_bug.cgi?id=31952
 186
 187         The mailing list is open for anyone to subscribe.
 188
 189         * Scripts/modules/bugzilla.py:
 190         * Scripts/modules/commands/queues.py:
 191
 192 2009-11-28  Adam Barth  <abarth@webkit.org>
 193
 194         Reviewed by Eric Seidel.
 195
 196         [bzt] style-queue should report style errors to bugzilla
 197         https://bugs.webkit.org/show_bug.cgi?id=31945
 198
 199         Currently, we're just logging the style errors locally.  With this
 200         patch we'll actually log the errors to bugzilla.  Note: I plan to run
 201         with the "local-only" logging during development.
 202
 203         * Scripts/modules/commands/queues.py:
 204         * Scripts/modules/scm.py:
 205
 206 2009-11-28  Adam Barth  <abarth@webkit.org>
 207
 208         Reviewed by Eric Seidel.
 209
 210         [bzt] style-queue shouldn't reject patches from the commit-queue
 211         https://bugs.webkit.org/show_bug.cgi?id=31944
 212
 213         Currently the style-queue subprocess gets confused and thinks its the
 214         commit-queue.  If the patch has an error, it rejects it from the
 215         commit-queue.  Instead, we should have style-queue specific logic.
 216         This patch doesn't add that logic, but it gives us a callback we can
 217         use to add that logic.
 218
 219         * Scripts/modules/buildsteps.py:
 220         * Scripts/modules/commands/queues.py:
 221         * Scripts/modules/landingsequence.py:
 222
 223 2009-11-27  Adam Barth  <abarth@webkit.org>
 224
 225         Rubber stamped by Eric Seidel.
 226
 227         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
 228
 229         * CommitQueueStatus: Removed.
 230         * CommitQueueStatus/app.yaml: Removed.
 231         * CommitQueueStatus/filters: Removed.
 232         * CommitQueueStatus/filters/__init__.py: Removed.
 233         * CommitQueueStatus/filters/webkit_extras.py: Removed.
 234         * CommitQueueStatus/index.html: Removed.
 235         * CommitQueueStatus/index.yaml: Removed.
 236         * CommitQueueStatus/queue_status.py: Removed.
 237         * CommitQueueStatus/stylesheets: Removed.
 238         * CommitQueueStatus/stylesheets/main.css: Removed.
 239         * CommitQueueStatus/update_status.html: Removed.
 240         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
 241
 242 2009-11-27  Adam Barth  <abarth@webkit.org>
 243
 244         Reviewed by Eric Seidel.
 245
 246         style-queue should only process each patch once
 247         https://bugs.webkit.org/show_bug.cgi?id=31939
 248
 249         Actually address reviewer comments!
 250
 251         * Scripts/bugzilla-tool:
 252
 253 2009-11-27  Adam Barth  <abarth@webkit.org>
 254
 255         Reviewed by Eric Seidel.
 256
 257         [bzt] style-queue fails to apply a bunch of patches for no reason
 258         https://bugs.webkit.org/show_bug.cgi?id=31942
 259
 260         By passing --non-interactive to check-style, we convince check-style
 261         to pass --force to svn-apply, which lets it apply more patches.
 262
 263         * Scripts/modules/commands/queues.py:
 264
 265 2009-11-27  Adam Barth  <abarth@webkit.org>
 266
 267         Reviewed by Eric Seidel.
 268
 269         [bzt] Support --status-host in style-queue
 270         https://bugs.webkit.org/show_bug.cgi?id=31941
 271
 272         * Scripts/modules/commands/queues.py:
 273         * Scripts/modules/statusbot.py:
 274
 275 2009-11-27  Adam Barth  <abarth@webkit.org>
 276
 277         Reviewed by Eric Seidel.
 278
 279         style-queue should only process each patch once
 280         https://bugs.webkit.org/show_bug.cgi?id=31939
 281
 282         Before processing a patch, the try-queues now ask the web service
 283         whether they have already processed the patch.  This is an initial cut
 284         of this functionality.  I expect we're make it richer over time.
 285
 286         * Scripts/bugzilla-tool:
 287         * Scripts/modules/commands/queues.py:
 288         * Scripts/modules/patchcollection.py:
 289
 290 2009-11-27  Adam Barth  <abarth@webkit.org>
 291
 292         Reviewed by Eric Seidel.
 293
 294         PatchStatus does not return status
 295         https://bugs.webkit.org/show_bug.cgi?id=31938
 296
 297         We need to parse attachment_id as an int.  Otherwise, we can't find
 298         anything in the datastore.
 299
 300         * CommitQueueStatus/queue_status.py:
 301
 302 2009-11-27  Adam Barth  <abarth@webkit.org>
 303
 304         Reviewed by Eric Seidel.
 305
 306         Make commit-queue status not throw an exception where there is not
 307         status
 308         https://bugs.webkit.org/show_bug.cgi?id=31936
 309
 310         We need to actually fetch the results of the query to see what's in the
 311         datastore.
 312
 313         * CommitQueueStatus/queue_status.py:
 314
 315 2009-11-27  Adam Barth  <abarth@webkit.org>
 316
 317         Reviewed by Eric Seidel.
 318
 319         [bzt] unit test ApplyPatches and ApplyAttachment
 320         https://bugs.webkit.org/show_bug.cgi?id=31935
 321
 322         * Scripts/modules/commands/download.py:
 323         * Scripts/modules/commands/download_unittest.py:
 324
 325 2009-11-27  Adam Barth  <abarth@webkit.org>
 326
 327         Reviewed by Eric Seidel.
 328
 329         [bzt] Unit test download commands
 330         https://bugs.webkit.org/show_bug.cgi?id=31923
 331
 332         Adds download_unittest and fixes a bug found while testing.
 333
 334         * Scripts/modules/commands/commandtest.py:
 335         * Scripts/modules/commands/download.py:
 336             Fixed a bug where we'd throw an error because [].append returns
 337             None.
 338         * Scripts/modules/commands/download_unittest.py: Added.
 339         * Scripts/modules/mock_bugzillatool.py:
 340         * Scripts/run-webkit-unittests:
 341
 342 2009-11-27  Adam Barth  <abarth@webkit.org>
 343
 344         Unreviewed "build" fix found while writing unit tests.
 345
 346         * Scripts/modules/commands/download.py:
 347
 348 2009-11-27  Adam Barth  <abarth@webkit.org>
 349
 350         Reviewed by Eric Seidel.
 351
 352         [bzt] Kill WebKitLandingScripts
 353         https://bugs.webkit.org/show_bug.cgi?id=31904
 354
 355         Step 6: Kill the rest.
 356
 357         * Scripts/modules/buildsteps.py:
 358         * Scripts/modules/commands/download.py:
 359         * Scripts/modules/commands/queries.py:
 360         * Scripts/modules/commands/upload.py:
 361         * Scripts/modules/landingsequence.py:
 362         * Scripts/modules/scm.py:
 363         * Scripts/modules/webkitlandingscripts.py: Removed.
 364
 365 2009-11-27  Adam Barth  <abarth@webkit.org>
 366
 367         Reviewed by Eric Seidel.
 368
 369         [bzt] Unit test upload commands
 370         https://bugs.webkit.org/show_bug.cgi?id=31903
 371
 372         Adds unit tests for all but two of the upload commands.  The two
 373         remaining ones are more difficult.  I'll return to them later.  The
 374         goal of these tests is just to run the commands.  We can test more
 375         detailed behavior later.
 376
 377         * Scripts/modules/commands/commandtest.py:
 378         * Scripts/modules/commands/upload.py:
 379         * Scripts/modules/commands/upload_unittest.py:
 380         * Scripts/modules/mock.py: Added.
 381         * Scripts/modules/mock_bugzillatool.py:
 382
 383 2009-11-26  Adam Barth  <abarth@webkit.org>
 384
 385         Reviewed by Eric Seidel.
 386
 387         [bzt] Kill WebKitLandingScripts
 388         https://bugs.webkit.org/show_bug.cgi?id=31904
 389
 390         Step 5: Kill run_and_throw_if_fail.
 391
 392         * Scripts/modules/buildsteps.py:
 393         * Scripts/modules/processutils.py: Added.
 394         * Scripts/modules/webkitlandingscripts.py:
 395
 396 2009-11-26  Adam Barth  <abarth@webkit.org>
 397
 398         Reviewed by Eric Seidel.
 399
 400         [bzt] Kill WebKitLandingScripts
 401         https://bugs.webkit.org/show_bug.cgi?id=31904
 402
 403         Step 4: Kill run_webkit_script.
 404
 405         * Scripts/modules/buildsteps.py:
 406         * Scripts/modules/commands/download.py:
 407         * Scripts/modules/webkitlandingscripts.py:
 408
 409 2009-11-26  Adam Barth  <abarth@webkit.org>
 410
 411         Reviewed by Eric Seidel.
 412
 413         [bzt] Kill WebKitLandingScripts
 414         https://bugs.webkit.org/show_bug.cgi?id=31904
 415
 416         Step 3: Kill build_webkit.
 417
 418         * Scripts/modules/buildsteps.py:
 419         * Scripts/modules/landingsequence.py:
 420         * Scripts/modules/webkitlandingscripts.py:
 421
 422 2009-11-26  Adam Barth  <abarth@webkit.org>
 423
 424         Reviewed by Eric Seidel.
 425
 426         [bzt] Kill WebKitLandingScripts
 427         https://bugs.webkit.org/show_bug.cgi?id=31904
 428
 429         Step 2: Kill ensure_builders_are_green.
 430
 431         * Scripts/modules/buildsteps.py:
 432         * Scripts/modules/commands/download.py:
 433         * Scripts/modules/landingsequence.py:
 434         * Scripts/modules/webkitlandingscripts.py:
 435
 436 2009-11-26  Adam Barth  <abarth@webkit.org>
 437
 438         Reviewed by Eric Seidel.
 439
 440         [bzt] Kill WebKitLandingScripts
 441         https://bugs.webkit.org/show_bug.cgi?id=31904
 442
 443         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
 444
 445         * Scripts/bugzilla-tool:
 446         * Scripts/modules/buildsteps.py: Added.
 447         * Scripts/modules/commands/download.py:
 448         * Scripts/modules/landingsequence.py:
 449         * Scripts/modules/webkitlandingscripts.py:
 450
 451 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
 452
 453         Reviewed by Adam Barth.
 454
 455         Remove directory prefixes from linux commands
 456
 457         SCM unittests can cause errors on some systems if we use absolute reference to
 458         the commands, so directory prefixes have been removed.
 459
 460         * Scripts/modules/scm_unittest.py:
 461
 462 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
 463
 464         Reviewed by Kenneth Rohde Christiansen.
 465
 466         Link DumpRenderTree to the Qt Ui Tools
 467         https://bugs.webkit.org/show_bug.cgi?id=31203
 468
 469         Implement QWebPage::createPlugin using the Qt Ui Tools
 470         to be able to create classes like QProgressBar from within
 471         the <object></object> tags This is required for the
 472         new automatic test of Qt Plugins.
 473
 474         * DumpRenderTree/qt/DumpRenderTree.cpp:
 475         (WebCore::WebPage::createPlugin):
 476         * DumpRenderTree/qt/DumpRenderTree.h:
 477         * DumpRenderTree/qt/DumpRenderTree.pro:
 478
 479 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
 480
 481         Reviewed by Eric Seidel.
 482
 483         Update pywebsocket to 0.4.2
 484
 485         Update pywebsocket to 0.4.2
 486         https://bugs.webkit.org/show_bug.cgi?id=31861
 487
 488         * pywebsocket/example/echo_client.py:
 489         * pywebsocket/example/echo_wsh.py:
 490         * pywebsocket/mod_pywebsocket/__init__.py:
 491         * pywebsocket/mod_pywebsocket/dispatch.py:
 492         * pywebsocket/mod_pywebsocket/msgutil.py:
 493         * pywebsocket/mod_pywebsocket/standalone.py:
 494         * pywebsocket/setup.py:
 495         * pywebsocket/test/test_dispatch.py:
 496         * pywebsocket/test/test_msgutil.py:
 497
 498 2009-11-25  Adam Barth  <abarth@webkit.org>
 499
 500         Reviewed by Eric Seidel.
 501
 502         Add unit test for mark-fixed
 503         https://bugs.webkit.org/show_bug.cgi?id=31896
 504
 505         * Scripts/modules/commands/commandtest.py: Added.
 506         * Scripts/modules/commands/queries_unittest.py:
 507         * Scripts/modules/commands/upload_unittest.py: Added.
 508         * Scripts/modules/mock_bugzillatool.py:
 509         * Scripts/run-webkit-unittests:
 510
 511 2009-11-25  Adam Barth  <abarth@webkit.org>
 512
 513         Reviewed by Eric Seidel.
 514
 515         bugzilla-tool should have a mark-fixed command
 516         https://bugs.webkit.org/show_bug.cgi?id=31853
 517
 518         Pretty simple stuff.
 519
 520         * Scripts/modules/commands/upload.py:
 521
 522 2009-11-25  Eric Seidel  <eric@webkit.org>
 523
 524         Reviewed by Adam Barth.
 525
 526         'bugzilla-tool help' should only show common commands like how 'git help' does
 527         https://bugs.webkit.org/show_bug.cgi?id=31772
 528
 529         I also took this opportunity to make 'help' a real Command.
 530         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
 531
 532         * Scripts/bugzilla-tool:
 533          - change should_show_command_help to should_show_in_main_help
 534         * Scripts/modules/commands/download.py:
 535          - Mark commands as being shown in main help or not.
 536          - show_in_main_help = False is not required (default is false),
 537            but it seemed to make the commands more self-documenting.
 538         * Scripts/modules/commands/queries.py: ditto
 539         * Scripts/modules/commands/queues.py: ditto
 540         * Scripts/modules/commands/upload.py: ditto
 541         * Scripts/modules/multicommandtool.py:
 542          - Make Command hold a pointer to tool in self.tool.  Most Command
 543            subclasses do not take advantage of this yet, but it was required
 544            for HelpCommand to be able to reach the tool from _help_epilog().
 545          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
 546          - Move MultiCommandTool._help_epilog to Command._help_epilog
 547          - Move "help" logic into HelpCommand.execute()
 548          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
 549         * Scripts/modules/multicommandtool_unittest.py:
 550          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
 551
 552 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
 553
 554         Reviewed by Dan Bernstein.
 555
 556         Patch by Mark Rowe.
 557
 558         The buildbots are failing on Windows because when they were upgraded
 559         to 4.0.4, Apple Application Support was not in their path. Add it to
 560         the path to fix the buildots.
 561
 562         * Scripts/webkitdirs.pm:
 563
 564 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
 565
 566         Reviewed by David Kilzer.
 567
 568         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
 569         https://bugs.webkit.org/show_bug.cgi?id=31799
 570
 571         * Scripts/run-webkit-tests: Fixed.
 572
 573 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
 574
 575         Reviewed by Eric Seidel.
 576
 577         Change run_command to give back stderr by default
 578         https://bugs.webkit.org/show_bug.cgi?id=31734
 579
 580         Change run_command to give back stderr by default.
 581         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
 582         Change the related unittest call.
 583
 584         * Scripts/modules/scm.py:
 585         * Scripts/modules/scm_unittest.py:
 586
 587 2009-11-25  Eric Seidel  <eric@webkit.org>
 588
 589         Reviewed by Adam Barth.
 590
 591         Centralize required argument parsing in Command
 592         https://bugs.webkit.org/show_bug.cgi?id=31872
 593
 594         * Scripts/modules/commands/download.py: remove custom required arg message.
 595         * Scripts/modules/commands/upload.py: ditto.
 596         * Scripts/modules/multicommandtool.py:
 597          - Add _parse_required_arguments.
 598          - Pass program name off to OptionParser.
 599          - Add name() for access to tool name.
 600          - Add check_arguments_and_execute and make it return a return code.
 601          - Replace a couple uses of + with %.
 602         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
 603
 604 2009-11-25  Eric Seidel  <eric@webkit.org>
 605
 606         Reviewed by Adam Barth.
 607
 608         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
 609         https://bugs.webkit.org/show_bug.cgi?id=31870
 610
 611         * Scripts/modules/commands/queries_unittest.py: Use the new class.
 612         * Scripts/modules/multicommandtool_unittest.py: Ditto.
 613         * Scripts/modules/outputcapture.py: Added.
 614
 615 2009-11-24  Dmitry Titov  <dimich@chromium.org>
 616
 617         Reviewed by Eric Seidel.
 618
 619         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
 620         https://bugs.webkit.org/show_bug.cgi?id=31444
 621
 622         * Scripts/build-webkit:
 623
 624 2009-11-24  Chris Marrin  <cmarrin@apple.com>
 625
 626         Reviewed by Simon Fraser.
 627
 628         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
 629         https://bugs.webkit.org/show_bug.cgi?id=27314
 630
 631         Now the script allows the directories with these tests to be included on all
 632         platforms but Mac, where they behave the same as always. For all other platforms
 633         the tests need to be excluded using the Skipped files, which is currently done
 634         for all platforms (including win since we're not turned on yet)
 635
 636         * Scripts/webkitdirs.pm:
 637
 638 2009-11-24  Eric Seidel  <eric@webkit.org>
 639
 640         Reviewed by Adam Barth.
 641
 642         queries_unittest.py should test command output
 643         https://bugs.webkit.org/show_bug.cgi?id=31845
 644
 645         * Scripts/modules/commands/queries_unittest.py:
 646          - Capture stdout and stderr and compare with expected strings.
 647
 648 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
 649
 650         No Review.
 651
 652         Fix spelling error ("depenedencies").
 653
 654         * Scripts/build-webkit:
 655
 656 2009-11-24  Mark Rowe  <mrowe@apple.com>
 657
 658         Land the configuration that includes the two debug GTK Linux builders.
 659
 660         * BuildSlaveSupport/build.webkit.org-config/config.json:
 661
 662 2009-11-24  David Kilzer  <ddkilzer@apple.com>
 663
 664         <http://webkit.org/b/31840> bisect-builds broke after r50080
 665
 666         Reviewed by Dan Bernstein.
 667
 668         * Scripts/bisect-builds:
 669         (mountAndRunNightly): Switched back to using backticks to run
 670         the hdiutil command since exec() will terminate the existing
 671         script, which is not what we want.  Store the output of
 672         File::Spec->devnull() in a variable for use in the hdiutil
 673         detach commands.
 674
 675 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 676
 677         Reviewed by Kenneth Rohde Christiansen.
 678
 679         Include "config.h" to meet Coding Style Guidelines
 680         https://bugs.webkit.org/show_bug.cgi?id=31792
 681
 682         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
 683         * DumpRenderTree/qt/jsobjects.cpp:
 684         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
 685
 686 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 687
 688         Reviewed by Oliver Hunt.
 689
 690         Implement new required function to pass test we used to pass. This
 691         change is required since r51294.
 692
 693         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 694         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 695
 696 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
 697
 698         Reviewed by Kenneth Rohde Christiansen.
 699
 700         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
 701         https://bugs.webkit.org/show_bug.cgi?id=31775
 702
 703         LayoutTestController::dumpBackForwardList() should work with local URLs
 704         as well as with normal URLs (in http tests for instance).
 705         Currently it does not output the latter properly.
 706
 707         Unskip a bunch of passing http/navigation tests.
 708
 709         * DumpRenderTree/qt/DumpRenderTree.cpp:
 710         (WebCore::dumpHistoryItem):
 711
 712 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
 713
 714         Reviewed by Oliver Hunt.
 715
 716         ARIA: support aria-flowto
 717         https://bugs.webkit.org/show_bug.cgi?id=31762
 718
 719         * DumpRenderTree/AccessibilityUIElement.cpp:
 720         (ariaFlowToElementAtIndexCallback):
 721         (AccessibilityUIElement::getJSClass):
 722         * DumpRenderTree/AccessibilityUIElement.h:
 723         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 724         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 725         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 726         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 727         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 728         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 729
 730 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
 731
 732         Reviewed by Kenneth Christiansen.
 733
 734         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
 735         https://bugs.webkit.org/show_bug.cgi?id=31638
 736
 737         Unfreeze WorkQueue after each test execution.
 738
 739         * DumpRenderTree/qt/DumpRenderTree.cpp:
 740         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 741
 742 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
 743
 744         Reviewed by Adam Barth.
 745
 746         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
 747         for localhost and 127.0.0.1.
 748         https://bugs.webkit.org/show_bug.cgi?id=31783
 749
 750         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
 751
 752         * DumpRenderTree/qt/DumpRenderTree.cpp:
 753         (WebCore::NetworkAccessManager::NetworkAccessManager):
 754         (WebCore::NetworkAccessManager::sslErrorsEncountered):
 755         (WebCore::WebPage::WebPage):
 756         * DumpRenderTree/qt/DumpRenderTree.h:
 757
 758 2009-11-22  Chris Evans  <cevans@chromium.org>
 759
 760         Reviewed by Adam Barth.
 761
 762         Disable access to file:/// directory listings
 763         https://bugs.webkit.org/show_bug.cgi?id=31329
 764
 765         Implemented setAllowUniversalAccessFromFileURLs to support testing of
 766         file URL security.
 767
 768         * DumpRenderTree/LayoutTestController.cpp:
 769         (setAllowUniversalAccessFromFileURLsCallback):
 770         (LayoutTestController::staticFunctions):
 771         * DumpRenderTree/LayoutTestController.h:
 772         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 773         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 774         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 775         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 776         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 777         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 778         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 779         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 780
 781 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
 782
 783         Reviewed by Kenneth Rohde Christiansen.
 784
 785         [Qt] Fix the timeout of fast/frames/frame-navigation.html
 786         https://bugs.webkit.org/show_bug.cgi?id=31638
 787
 788         The test is timeouting, because it uses the WorkQueue to load a document in one
 789         of the child frames and once the loading is finished, the DRT does not dump the
 790         tree. This is because it waits for the QWebFrame::loadFinished() signal from
 791         the main frame, while it should connect to QWebPage::loadFinished().
 792
 793         * DumpRenderTree/qt/DumpRenderTree.cpp:
 794         (WebCore::DumpRenderTree::DumpRenderTree):
 795
 796 2009-11-21  Eric Seidel  <eric@webkit.org>
 797
 798         Reviewed by Adam Barth.
 799
 800         bugzilla-tool --help spews way too much text
 801         https://bugs.webkit.org/show_bug.cgi?id=31771
 802
 803         * Scripts/bugzilla-tool:
 804          - Remove self.cached_scm initialization hack.
 805         * Scripts/modules/buildbot.py:
 806          - Make default_host accessible to callers.
 807         * Scripts/modules/commands/download.py:
 808          - Phrase help for all commands consistently and remove spurious help text punctuation.
 809         * Scripts/modules/commands/queries.py: Ditto.
 810         * Scripts/modules/commands/queues.py: Ditto.
 811         * Scripts/modules/commands/upload.py: Ditto.
 812         * Scripts/modules/multicommandtool.py:
 813          - Add HelpPrintingOptionParser.format_epilog to replace
 814            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
 815            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
 816          - Make --help only show a list of commands like "svn help" and "git help" do --
 817            previously --help was listing all commands and options.
 818          - Sort list of commands alphabetically.
 819
 820 2009-11-21  Eric Seidel  <eric@webkit.org>
 821
 822         No review.  Fixing a typo from the previous patch for bug 31767.
 823
 824         AbstractQueue.run_bugzilla_tool throws an exception
 825         https://bugs.webkit.org/show_bug.cgi?id=31769
 826
 827         * Scripts/modules/commands/queues.py:
 828
 829 2009-11-21  Eric Seidel  <eric@webkit.org>
 830
 831         Reviewed by Adam Barth.
 832
 833         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
 834         https://bugs.webkit.org/show_bug.cgi?id=31767
 835
 836         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
 837         Since we don't have a good way to test BugzillaTool pieces, I've
 838         left out a test for now.
 839
 840         * Scripts/bugzilla-tool:
 841          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
 842         * Scripts/modules/commands/queues.py:
 843          - Use tool.path() instead of __file__.
 844         * Scripts/modules/multicommandtool.py:
 845          - Add a new path() method to MultiComandTool.
 846         * Scripts/modules/multicommandtool_unittest.py:
 847          - Provide a path() method.  Little point in testing this mock implementation.
 848
 849 2009-11-21  Adam Barth  <abarth@webkit.org>
 850
 851         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
 852         WebKitTools.
 853
 854         * Scripts/modules/commands/download.py:
 855
 856 2009-11-21  Adam Barth  <abarth@webkit.org>
 857
 858         Reviewed by Eric Seidel.
 859
 860         Convert check-style to use LandingSequence
 861         https://bugs.webkit.org/show_bug.cgi?id=31763
 862
 863         Instead of manipulating the working copy by hand, we should use the
 864         LandingSequence in CheckStyle.  This will make this code eaiser to
 865         test.
 866
 867         * Scripts/modules/commands/download.py:
 868
 869 2009-11-20  Adam Barth  <abarth@webkit.org>
 870
 871         Reviewed by Eric Seidel.
 872
 873         Unit test query commands
 874         https://bugs.webkit.org/show_bug.cgi?id=31755
 875
 876         These tests are pretty rough, but hopefully they'll grow.
 877
 878         * Scripts/modules/commands/queries_unittest.py: Added.
 879         * Scripts/modules/mock_bugzillatool.py: Added.
 880         * Scripts/run-webkit-unittests:
 881
 882 2009-11-20  Eric Seidel  <eric@webkit.org>
 883
 884         Reviewed by Adam Barth.
 885
 886         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
 887         https://bugs.webkit.org/show_bug.cgi?id=31758
 888
 889         * Scripts/modules/multicommandtool.py:
 890          - Allow passing of explicit commands to MultiCommandTool.__init__
 891         * Scripts/modules/multicommandtool_unittest.py:
 892          - Use new Command.name naming system.
 893          - Test Command auto-discovery.
 894         * Scripts/modules/workqueue.py:
 895          - bug_id no longer exists, use patch['bug_id'] instead.
 896         * Scripts/modules/workqueue_unittest.py:
 897          - WorkQueues require names now.
 898          - should_proceed_with_work_item must return a patch object.
 899
 900 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
 901
 902         Reviewed by Beth Dakin.
 903
 904         WAI-ARIA: add support for aria-owns
 905         https://bugs.webkit.org/show_bug.cgi?id=31702
 906
 907         * DumpRenderTree/AccessibilityUIElement.cpp:
 908         (ariaOwnsElementAtIndexCallback):
 909         (AccessibilityUIElement::getJSClass):
 910         * DumpRenderTree/AccessibilityUIElement.h:
 911         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 912         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 913         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 914         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 915         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 916         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 917
 918 2009-11-20  Eric Seidel  <eric@webkit.org>
 919
 920         Reviewed by Adam Barth.
 921
 922         Fix exception thrown when running the commit-queue.
 923
 924         * Scripts/modules/statusbot.py: patch is optional.
 925         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
 926
 927 2009-11-20  Eric Seidel  <eric@webkit.org>
 928
 929         Reviewed by Adam Barth.
 930
 931         Teach the StatusBot how to support more than just the commit-queue
 932         https://bugs.webkit.org/show_bug.cgi?id=31754
 933
 934         * Scripts/modules/workqueue.py: Another typo.
 935
 936 2009-11-20  Eric Seidel  <eric@webkit.org>
 937
 938         Reviewed by Adam Barth.
 939
 940         Teach the StatusBot how to support more than just the commit-queue
 941         https://bugs.webkit.org/show_bug.cgi?id=31754
 942
 943         * Scripts/modules/commands/queues.py: Fix silly typo.
 944
 945 2009-11-20  Eric Seidel  <eric@webkit.org>
 946
 947         Reviewed by Adam Barth.
 948
 949         Teach the StatusBot how to support more than just the commit-queue
 950         https://bugs.webkit.org/show_bug.cgi?id=31754
 951
 952         * CommitQueueStatus/index.yaml:
 953          - Add indices required for the new queries.
 954         * CommitQueueStatus/queue_status.py:
 955          - Add a patch-status page and move update_status to update-status.
 956          - Only display "commit-queue" status records for the commit-queue.
 957          - Add support for a queue_name property on status records.
 958          - Fix _int_from_request to actually work.
 959         * CommitQueueStatus/update_status.html:
 960          - Add support for a queue_name on status records.
 961          - Remove unused list of bug ids.
 962          * Scripts/modules/commands/queues.py
 963           - Make the queues pass the patch instead of the bug_id to StatusBot.
 964         * Scripts/modules/statusbot.py:
 965          - Support passing the queue_name to the status updates.
 966          - Support fetching patch status with patch_status().
 967         * Scripts/modules/workqueue.py:
 968          - Pass the patch to the StatusBot instead of the bug_id.
 969          - Let WorkQueues have a name.
 970
 971 2009-11-20  Adam Barth  <abarth@webkit.org>
 972
 973         Reviewed by Eric Seidel.
 974
 975         Move bugzilla-tool commands into their own file
 976         https://bugs.webkit.org/show_bug.cgi?id=31752
 977
 978         This will let us write unit tests.
 979
 980         * Scripts/bugzilla-tool:
 981         * Scripts/modules/commands/__init__.py: Added.
 982         * Scripts/modules/commands/download.py: Added.
 983         * Scripts/modules/commands/queries.py: Added.
 984         * Scripts/modules/commands/queues.py: Added.
 985         * Scripts/modules/commands/upload.py: Added.
 986         * Scripts/modules/grammar.py: Added.
 987
 988 2009-11-20  Adam Barth  <abarth@webkit.org>
 989
 990         Reviewed by Eric Seidel.
 991
 992         BuildQueue should check if the tree is currently buildable
 993         https://bugs.webkit.org/show_bug.cgi?id=31744
 994
 995         * Scripts/bugzilla-tool:
 996         * Scripts/modules/landingsequence.py:
 997         * Scripts/modules/webkitlandingscripts.py:
 998
 999 2009-11-20  Adam Barth  <abarth@webkit.org>
1000
1001         Reviewed by Eric Seidel.
1002
1003         Move prepare_clean_working_directory into the LandingSequence
1004         https://bugs.webkit.org/show_bug.cgi?id=31743
1005
1006         * Scripts/bugzilla-tool:
1007         * Scripts/modules/landingsequence.py:
1008
1009 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
1010
1011         Reviewed by Kenneth Rohde Christiansen.
1012
1013         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
1014         https://bugs.webkit.org/show_bug.cgi?id=30460
1015
1016         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
1017
1018         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1019         (pluginInvoke):
1020
1021 2009-11-20  Adam Barth  <abarth@webkit.org>
1022
1023         Reviewed by Eric Seidel.
1024
1025         Pass the port information to the child process
1026         https://bugs.webkit.org/show_bug.cgi?id=31736
1027
1028         We need to do this so the child process knows what to build!
1029
1030         * Scripts/bugzilla-tool:
1031         * Scripts/modules/landingsequence.py:
1032         * Scripts/modules/webkitport.py:
1033         * Scripts/modules/webkitport_unittest.py:
1034
1035 2009-11-20  Adam Barth  <abarth@webkit.org>
1036
1037         Reviewed by Eric Seidel.
1038
1039         Support Qt port in build-queue
1040         https://bugs.webkit.org/show_bug.cgi?id=31733
1041
1042         * Scripts/bugzilla-tool:
1043
1044 2009-11-20  Adam Barth  <abarth@webkit.org>
1045
1046         Reviewed by Eric Seidel.
1047
1048         Implement a build-queue
1049         https://bugs.webkit.org/show_bug.cgi?id=31725
1050
1051         Currently this just builds the first 10 patches in the review queue.
1052         We'll want to do something smarter soon.
1053
1054         * Scripts/bugzilla-tool:
1055
1056 2009-11-20  Adam Barth  <abarth@webkit.org>
1057
1058         Reviewed by Eric Seidel.
1059
1060         Make commit-queue and style-queue show up in help
1061         https://bugs.webkit.org/show_bug.cgi?id=31724
1062
1063         We need to store their names on their class to make these commands
1064         properly register themselves with MultiCommandTool.
1065
1066         * Scripts/bugzilla-tool:
1067
1068 2009-11-20  Adam Barth  <abarth@webkit.org>
1069
1070         Reviewed by Eric Seidel.
1071
1072         Implement bugzilla-tool build-attachment
1073         https://bugs.webkit.org/show_bug.cgi?id=31722
1074
1075         This command builds an attachment from bugzilla.  It leaves the built
1076         patch in the working copy.
1077
1078         * Scripts/bugzilla-tool:
1079         * Scripts/modules/landingsequence.py:
1080         * Scripts/modules/webkitlandingscripts.py:
1081
1082 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
1083
1084         Reviewed by Xan Lopez.
1085
1086         [GTK] DRT release event does not create the state correctly
1087         https://bugs.webkit.org/show_bug.cgi?id=31717
1088
1089         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1090
1091 2009-11-20  Eric Seidel  <eric@webkit.org>
1092
1093         Reviewed by Adam Barth.
1094
1095         MultiCommandTool should find Command objects automatically instead of with a manual list
1096         https://bugs.webkit.org/show_bug.cgi?id=31710
1097
1098         * Scripts/bugzilla-tool:
1099         * Scripts/modules/multicommandtool.py:
1100          - Use some wild python-fu to crawl all the known subclasses of Command.
1101
1102 2009-11-20  Adam Barth  <abarth@webkit.org>
1103
1104         Unreviewed "build" fix.  Added missing import.
1105
1106         * Scripts/bugzilla-tool:
1107
1108 2009-11-20  Adam Barth  <abarth@webkit.org>
1109
1110         Unreviewed "build" fix.  I failed to update LandingSequence.test
1111         properly.
1112
1113         * Scripts/modules/landingsequence.py:
1114
1115 2009-11-20  Adam Barth  <abarth@webkit.org>
1116
1117         Reviewed by Eric Seidel.
1118
1119         Create LandingSequence as the all-sing, all-dance landing class
1120         https://bugs.webkit.org/show_bug.cgi?id=31709
1121
1122         Client can inherit from this class to carefully control exactly which
1123         steps they wish to have happen in the landing sequence.
1124
1125         * Scripts/bugzilla-tool:
1126         * Scripts/modules/landingsequence.py: Added.
1127         * Scripts/modules/webkitlandingscripts.py: Added.
1128
1129 2009-11-19  Adam Barth  <abarth@webkit.org>
1130
1131         Reviewed by Eric Seidel.
1132
1133         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
1134         https://bugs.webkit.org/show_bug.cgi?id=31707
1135
1136         This is to help when we implement build-attachment.
1137
1138         * Scripts/bugzilla-tool:
1139
1140 2009-11-19  Adam Barth  <abarth@webkit.org>
1141
1142         Reviewed by Eric Seidel.
1143
1144         Support Qt port in bugzilla-tool
1145         https://bugs.webkit.org/show_bug.cgi?id=31701
1146
1147         Now we support building with Qt!
1148
1149         * Scripts/bugzilla-tool:
1150         * Scripts/modules/webkitport.py: Added.
1151         * Scripts/modules/webkitport_unittest.py: Added.
1152         * Scripts/run-webkit-unittests:
1153
1154 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
1155
1156         Reviewed by Adam Barth.
1157
1158         Remove inserting stderr into patch in bugzilla-tool
1159         https://bugs.webkit.org/show_bug.cgi?id=29914
1160
1161         Modify SCM python module's run_command function to avoid return of stderr
1162         by default, so stderr won't be inserted into the patches.
1163         Modify the related unit test.
1164
1165         * Scripts/modules/scm.py:
1166         * Scripts/modules/scm_unittest.py:
1167
1168 2009-11-19  Eric Seidel  <eric@webkit.org>
1169
1170         Reviewed by Adam Barth.
1171
1172         bugzilla-tool needs per-command help
1173         https://bugs.webkit.org/show_bug.cgi?id=31697
1174
1175         Added support for "bugzilla-tool help command-name"
1176         and a unit test to make sure it works.
1177
1178         * Scripts/modules/multicommandtool.py:
1179         * Scripts/modules/multicommandtool_unittest.py:
1180
1181 2009-11-19  Eric Seidel  <eric@webkit.org>
1182
1183         Reviewed by Adam Barth.
1184
1185         Move MultiCommandTool and Command into a separate file and add some basic unit tests
1186         https://bugs.webkit.org/show_bug.cgi?id=31695
1187
1188         * Scripts/bugzilla-tool:
1189         * Scripts/modules/multicommandtool.py: Added.
1190         * Scripts/modules/multicommandtool_unittest.py: Added.
1191         * Scripts/run-webkit-unittests:
1192
1193 2009-11-19  Eric Seidel  <eric@webkit.org>
1194
1195         No review, just adding a FIXME.
1196
1197         Split out command parsing and help printing from BugzillaTool
1198         https://bugs.webkit.org/show_bug.cgi?id=31688
1199
1200         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
1201
1202 2009-11-19  Eric Seidel  <eric@webkit.org>
1203
1204         Reviewed by Adam Barth.
1205
1206         Split out command parsing and help printing from BugzillaTool
1207         https://bugs.webkit.org/show_bug.cgi?id=31688
1208
1209         * Scripts/bugzilla-tool:
1210          - Add new MultiCommandTool class to contain option parsing and help printing logic.
1211          - Rename private methods to use _ pattern.
1212          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
1213          -
1214
1215 2009-11-19  Eric Seidel  <eric@webkit.org>
1216
1217         Reviewed by Adam Barth.
1218
1219         Re-factor help printing to use modern python idioms
1220         https://bugs.webkit.org/show_bug.cgi?id=31685
1221
1222         * Scripts/bugzilla-tool:
1223
1224 2009-11-19  Eric Seidel  <eric@webkit.org>
1225
1226         Reviewed by Darin Adler.
1227
1228         commit-queue empty queue logs twice
1229         https://bugs.webkit.org/show_bug.cgi?id=31679
1230
1231         * Scripts/bugzilla-tool:
1232
1233 2009-11-19  Eric Seidel  <eric@webkit.org>
1234
1235         Reviewed by Darin Adler.
1236
1237         bugzilla-tool's reviewer/committer rejection message should be clearer
1238         https://bugs.webkit.org/show_bug.cgi?id=31126
1239
1240         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1241
1242         * Scripts/modules/bugzilla.py:
1243
1244 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1245
1246         Reviewed by Pavel Feldman.
1247
1248         Forces a WM_PAINT event on calling layoutTestController.display()
1249         in order to enable the timeline-paint.html test on Windows.
1250         ::UpdateWindow() does not force an event becaue the window is
1251         not visible.
1252
1253         https://bugs.webkit.org/show_bug.cgi?id=31402
1254
1255         * DumpRenderTree/win/DumpRenderTree.cpp:
1256         (displayWebView):
1257
1258 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1259
1260         No review needed.
1261
1262         Added myself to committers list.
1263
1264         * Scripts/modules/committers.py:
1265
1266 2009-11-19  Adam Barth  <abarth@webkit.org>
1267
1268         Reviewed by Eric Seidel.
1269
1270         Bugzilla-tool command classes should match command names
1271         https://bugs.webkit.org/show_bug.cgi?id=31666
1272
1273         I renamed all the commands except CommitMessageForCurrentDiff because
1274         the new name would conflict with an existing class.
1275
1276         * Scripts/bugzilla-tool:
1277
1278 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1279
1280         Reviewed by Gustavo Noronha Silva.
1281
1282         Web Inspector: Implement "show inspector" in WebKit GTK
1283         API and enable console tests.
1284
1285         https://bugs.webkit.org/show_bug.cgi?id=31669
1286
1287         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1288         (LayoutTestController::showWebInspector):
1289
1290 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1291
1292         Reviewed by Simon Hausmann.
1293
1294         Minor refactoring + more documentation.
1295
1296         * DumpRenderTree/qt/DumpRenderTree.cpp:
1297         (WebCore::clearHistory):
1298         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1299
1300 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1301
1302         Reviewed by Eric Seidel.
1303
1304         Ignore websocket tests when --no-http is specified.
1305         https://bugs.webkit.org/show_bug.cgi?id=31662
1306
1307         * Scripts/run-webkit-tests:
1308
1309 2009-11-18  Adam Barth  <abarth@webkit.org>
1310
1311         Reviewed by Eric Seidel.
1312
1313         Normalize ' and " in bugzilla-tool
1314         https://bugs.webkit.org/show_bug.cgi?id=31655
1315
1316         We decided " is better than ' and we should be consistent.
1317
1318         * Scripts/bugzilla-tool:
1319
1320 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1321
1322         Reviewed by Kenneth Rohde Christiansen.
1323
1324         [Qt] Remove support for Qt v4.3 or older versions
1325         https://bugs.webkit.org/show_bug.cgi?id=29469
1326
1327         * DumpRenderTree/qt/DumpRenderTree.pro:
1328         * DumpRenderTree/qt/ImageDiff.pro:
1329
1330 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1331
1332         Reviewed by Eric Seidel.
1333
1334         GitTest.test_create_binary_patch fails if /tmp is symlink
1335         https://bugs.webkit.org/show_bug.cgi?id=31536
1336
1337         * Scripts/modules/scm_unittest.py:
1338
1339 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1340
1341         Reviewed by Darin Adler.
1342
1343         Configuration for Chromium Build Slaves.
1344
1345         https://bugs.webkit.org/show_bug.cgi?id=31442
1346
1347         * BuildSlaveSupport/build.webkit.org-config/config.json:
1348         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1349
1350 2009-11-18  Eric Seidel  <eric@webkit.org>
1351
1352         Reviewed by Darin Adler.
1353
1354         workqueue.py results in totally broken commit-queue UI
1355         https://bugs.webkit.org/show_bug.cgi?id=31645
1356
1357         * Scripts/bugzilla-tool:
1358          - Remove unneeded use of PatchCollection.
1359          - Grab a new copy of the cq'd patches every run of the queue.
1360
1361 2009-11-18  Sam Weinig  <sam@webkit.org>
1362
1363         Reviewed by Anders Carlsson.
1364
1365         Make the Mac Geolocation API async.
1366
1367         Update DRT to use the new async Mac Geolocation API.
1368
1369         * DumpRenderTree/mac/UIDelegate.mm:
1370         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1371
1372 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1373
1374         Reviewed by Kenneth Rohde Christiansen.
1375
1376         Add and option to toggle HTML5 datalist support to build-webkit
1377         https://bugs.webkit.org/show_bug.cgi?id=31599
1378
1379         * Scripts/build-webkit:
1380
1381 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1382
1383         Reviewed by Kevin Ollivier.
1384
1385         Enable wx plugin support using the Windows implementation as a base.
1386
1387         https://bugs.webkit.org/show_bug.cgi?id=31636
1388
1389         * wx/build/settings.py:
1390
1391 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1392
1393         Reviewed by Simon Hausmann.
1394
1395         Change the initialization order so that the controllers
1396         will be created before exporting them to the JS DOM window.
1397
1398         * DumpRenderTree/qt/DumpRenderTree.cpp:
1399         (WebCore::DumpRenderTree::DumpRenderTree):
1400
1401 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1402
1403         Reviewed by Simon Hausmann.
1404
1405         Fix a code copy and paste error. m_page should be page.
1406
1407         * DumpRenderTree/qt/DumpRenderTree.cpp:
1408         (WebCore::DumpRenderTree::createWindow):
1409
1410 2009-11-17  Mark Rowe  <mrowe@apple.com>
1411
1412         Reviewed by Alexey Proskuryakov.
1413
1414         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1415
1416         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1417         This prevents symlinks from confusing the descendant check.
1418
1419 2009-11-17  Mark Rowe  <mrowe@apple.com>
1420
1421         Reviewed by Alexey Proskuryakov.
1422
1423         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1424
1425         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1426         server to be up rather than having run-webkit-tests abort immediately.
1427
1428         * Scripts/run-webkit-tests:
1429
1430 2009-11-17  Eric Seidel  <eric@webkit.org>
1431
1432         Reviewed by Darin Adler.
1433
1434         commit-queue is failing to set reviewer in ChangeLogs
1435         https://bugs.webkit.org/show_bug.cgi?id=31592
1436
1437         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1438         * Scripts/modules/bugzilla.py:
1439          - Add a new _validate_committer_and_reviewer function as a
1440            temporary solution until we can make a real Attachment object
1441            which knows how to fill in its committer/reviewer fields automatically.
1442
1443 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1444
1445         Unreviewed buildbot fix.
1446
1447         Revert part of earlier patch and add comment, as it
1448         was causing timeouts on the buildbot.
1449
1450         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1451         (LayoutTestController::notifyDone):
1452
1453 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1454
1455         Reviewed by Oliver Hunt.
1456
1457         Make the timeout 15 sec as for the other DRT's and make
1458         it print out the same output when a test timeout.
1459
1460         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1461         (LayoutTestController::waitUntilDone):
1462         (LayoutTestController::notifyDone):
1463         (LayoutTestController::timerEvent):
1464
1465 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1466
1467         Reviewed by Timothy Hatcher.
1468
1469         Fixed typos in comments.
1470
1471         * Scripts/modules/committers.py:
1472
1473 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1474
1475         Reviewed by Timothy Hatcher.
1476
1477         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1478         - Updated DRT to show/close inspector for all tests under /inspector
1479         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1480           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1481         - Removed reload on each inspector test
1482         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1483         inspector for those.
1484         - Reimplemented timeline tests in order to get rid of reload there.
1485         - Moved tests that don't require harness into the fast group.
1486
1487         https://bugs.webkit.org/show_bug.cgi?id=31472
1488
1489         * DumpRenderTree/LayoutTestController.cpp:
1490         (setTimelineProfilingEnabledCallback):
1491         (closeWebInspectorCallback):
1492         (LayoutTestController::staticFunctions):
1493         * DumpRenderTree/LayoutTestController.h:
1494         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1495         (shouldOpenWebInspector):
1496         (runTest):
1497         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1498         (LayoutTestController::setTimelineProfilingEnabled):
1499         * DumpRenderTree/mac/DumpRenderTree.mm:
1500         (shouldOpenWebInspector):
1501         (runTest):
1502         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1503         (LayoutTestController::setTimelineProfilingEnabled):
1504         * DumpRenderTree/win/DumpRenderTree.cpp:
1505         (shouldOpenWebInspector):
1506         (runTest):
1507         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1508         (LayoutTestController::setTimelineProfilingEnabled):
1509
1510 2009-11-17  Oliver Hunt  <oliver@apple.com>
1511
1512         Reviewed by Maciej Stachowiak.
1513
1514         Incorrect use of JavaScriptCore API in DumpRenderTree
1515         https://bugs.webkit.org/show_bug.cgi?id=31577
1516
1517         Return undefined rather than a literal null.
1518
1519         * DumpRenderTree/AccessibilityUIElement.cpp:
1520         (setSelectedTextRangeCallback):
1521         (incrementCallback):
1522         (decrementCallback):
1523         (showMenuCallback):
1524
1525 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1526
1527         Reviewed by Beth Dakin.
1528
1529         AX: aria-labelledby duplicates some of its WAI-ARIA label
1530         https://bugs.webkit.org/show_bug.cgi?id=31565
1531
1532         * DumpRenderTree/AccessibilityUIElement.cpp:
1533         (titleUIElementCallback):
1534         (getIsValidCallback):
1535         (AccessibilityUIElement::getJSClass):
1536
1537 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1538
1539         Reviewed by Simon Hausmann.
1540
1541         r50942 broke output from created windows. Make the
1542         m_enableTextOutput a member of the DRT and not the
1543         WebPage.
1544
1545         * DumpRenderTree/qt/DumpRenderTree.cpp:
1546         (WebCore::WebPage::WebPage):
1547         (WebCore::WebPage::javaScriptAlert):
1548         (WebCore::WebPage::javaScriptConsoleMessage):
1549         (WebCore::WebPage::javaScriptConfirm):
1550         (WebCore::WebPage::javaScriptPrompt):
1551         (WebCore::WebPage::acceptNavigationRequest):
1552         (WebCore::DumpRenderTree::DumpRenderTree):
1553         (WebCore::DumpRenderTree::open):
1554         (WebCore::DumpRenderTree::createWindow):
1555         * DumpRenderTree/qt/DumpRenderTree.h:
1556         (WebCore::DumpRenderTree::setTextOutputEnabled):
1557         (WebCore::DumpRenderTree::isTextOutputEnabled):
1558         (WebCore::WebPage::shouldInterruptJavaScript):
1559         (WebCore::WebPage::isTextOutputEnabled):
1560         (WebCore::WebPage::setViewGeometry):
1561
1562 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1563
1564         Reviewed by Gustavo Noronha Silva.
1565
1566         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1567         as the implementation is being used by at least Qt and Gtk+.
1568
1569         Update buildsystems as well.
1570
1571         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1572         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1573         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1574         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1575         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1576         * GNUmakefile.am:
1577
1578 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1579
1580         Reviewed by Alexey Proskuryakov.
1581
1582         Disable wss until all platforms support pyOpenSSL
1583
1584         https://bugs.webkit.org/show_bug.cgi?id=31479
1585
1586         * Scripts/run-webkit-tests:
1587
1588 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1589
1590         Reviewed by Kenneth Christiansen.
1591
1592         [Qt] Implement load error pages support for Qt's DRT.
1593         https://bugs.webkit.org/show_bug.cgi?id=31509
1594
1595         For now, it will not be a default feature, and layout tests
1596         that want to make use of this have to explicitily call
1597         'handleErrorPages();' for the test source.
1598
1599         Any of the other DumpRenderTree's (mac, win and gtk)
1600         support handling error pages. Qt's will be the first.
1601
1602         * DumpRenderTree/qt/DumpRenderTree.cpp:
1603         (WebCore::WebPage::supportsExtension):
1604         (WebCore::WebPage::extension):
1605         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1606         (LayoutTestController::reset):
1607         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1608         (LayoutTestController::shouldHandleErrorPages):
1609         (LayoutTestController::handleErrorPages):
1610
1611 2009-11-16  Eric Seidel  <eric@webkit.org>
1612
1613         Reviewed by Adam Barth.
1614
1615         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1616         https://bugs.webkit.org/show_bug.cgi?id=31549
1617
1618         Renamed --commit-queue to --non-interactive in most places
1619         and remove the code in land-patches which is no longer needed.
1620
1621         * Scripts/bugzilla-tool:
1622
1623 2009-11-16  Eric Seidel  <eric@webkit.org>
1624
1625         Reviewed by Adam Barth.
1626
1627         The commit-queue should use land-attachment
1628         https://bugs.webkit.org/show_bug.cgi?id=31548
1629
1630         * Scripts/bugzilla-tool:
1631
1632 2009-11-16  Adam Barth  <abarth@webkit.org>
1633
1634         Reviewed by Eric Seidel.
1635
1636         Convert CommitQueue over to PatchCollection
1637         https://bugs.webkit.org/show_bug.cgi?id=31547
1638
1639         Also fixes a bug in workqueue and adds a test!
1640
1641         * Scripts/bugzilla-tool:
1642         * Scripts/modules/workqueue.py:
1643         * Scripts/modules/workqueue_unittest.py:
1644
1645 2009-11-16  Adam Barth  <abarth@webkit.org>
1646
1647         Reviewed by Eric Seidel.
1648
1649         Move StyleQueue over to using PatchCollection
1650         https://bugs.webkit.org/show_bug.cgi?id=31544
1651
1652         That's what the class it's for.
1653
1654         * Scripts/bugzilla-tool:
1655         * Scripts/modules/patchcollection.py:
1656         * Scripts/modules/patchcollection_unittest.py:
1657
1658 2009-11-16  Eric Seidel  <eric@webkit.org>
1659
1660         Reviewed by Adam Barth.
1661
1662         bugzilla-tool needs a land-attachment command
1663         https://bugs.webkit.org/show_bug.cgi?id=31546
1664
1665         * Scripts/bugzilla-tool:
1666          - Move all the logic into AbstractLandingCommand and
1667            add a new LandAttachment command subclass.
1668          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1669
1670 2009-11-16  Eric Seidel  <eric@webkit.org>
1671
1672         Reviewed by Adam Barth.
1673
1674         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1675         https://bugs.webkit.org/show_bug.cgi?id=31543
1676
1677         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1678
1679         * Scripts/bugzilla-tool:
1680
1681 2009-11-16  Eric Seidel  <eric@webkit.org>
1682
1683         Reviewed by Adam Barth.
1684
1685         Disable the style queue from posting to the commit queue status page.
1686
1687         * Scripts/bugzilla-tool:
1688
1689 2009-11-16  Adam Barth  <abarth@webkit.org>
1690
1691         Reviewed by Eric Seidel.
1692
1693         Implement PatchCollection
1694         https://bugs.webkit.org/show_bug.cgi?id=31541
1695
1696         This class holds a set of patches and lets clients iterate through
1697         them.  Optionally, clients can install a filter.
1698
1699         * Scripts/modules/patchcollection.py: Added.
1700         * Scripts/modules/patchcollection_unittest.py: Added.
1701         * Scripts/run-webkit-unittests:
1702
1703 2009-11-16  Eric Seidel  <eric@webkit.org>
1704
1705         Reviewed by Adam Barth.
1706
1707         bugzilla-tool land-patches will close bugs with patches r=?
1708         https://bugs.webkit.org/show_bug.cgi?id=28230
1709
1710         The commit-queue shouldn't close patches with outstanding reviews on them,
1711         even if many reviewers seem to be against multi-patch bugs.
1712
1713         * Scripts/bugzilla-tool:
1714
1715 2009-11-16  Eric Seidel  <eric@webkit.org>
1716
1717         Reviewed by Adam Barth.
1718
1719         bugzilla-tool check-style should work with attachment ids instead of bug ids
1720         https://bugs.webkit.org/show_bug.cgi?id=31540
1721
1722         * Scripts/bugzilla-tool:
1723
1724 2009-11-16  Eric Seidel  <eric@webkit.org>
1725
1726         Reviewed by Adam Barth.
1727
1728         WorkQueue is the only place that should know about special exit codes
1729         https://bugs.webkit.org/show_bug.cgi?id=31534
1730
1731         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1732         and add tests for handling exit codes.
1733         I also cleaned up workqueue_unittest.py more.
1734
1735         * Scripts/bugzilla-tool:
1736         * Scripts/modules/workqueue.py:
1737         * Scripts/modules/workqueue_unittest.py:
1738
1739 2009-11-16  Eric Seidel  <eric@webkit.org>
1740
1741         Reviewed by Adam Barth.
1742
1743         Re-factor workqueue_unittest to allow for more than one test.
1744         https://bugs.webkit.org/show_bug.cgi?id=31535
1745
1746         * Scripts/modules/workqueue_unittest.py:
1747
1748 2009-11-16  Eric Seidel  <eric@webkit.org>
1749
1750         Reviewed by Adam Barth.
1751
1752         land-patches needs to be re-factored into smaller chunks
1753         https://bugs.webkit.org/show_bug.cgi?id=31532
1754
1755         * Scripts/bugzilla-tool: fix a couple obvious typos.
1756
1757 2009-11-16  Eric Seidel  <eric@webkit.org>
1758
1759         Reviewed by Adam Barth.
1760
1761         land-patches needs to be re-factored into smaller chunks
1762         https://bugs.webkit.org/show_bug.cgi?id=31532
1763
1764         The next patch will move these methods into WebKitLandingScripts.
1765
1766         * Scripts/bugzilla-tool:
1767          - Split out _land_patch and _close_bug_if_no_active_patches.
1768
1769 2009-11-16  Adam Barth  <abarth@webkit.org>
1770
1771         Reviewed by Eric Seidel.
1772
1773         Fix silly copy-and-paste code.  I am a terrible coder.
1774
1775         * Scripts/modules/bugzilla.py:
1776
1777 2009-11-16  Adam Barth  <abarth@webkit.org>
1778
1779         Reviewed by Eric Seidel.
1780
1781         Implement a StyleQueue
1782         https://bugs.webkit.org/show_bug.cgi?id=31537
1783
1784         The first iteration of the style queue only produces output locally.
1785         There is also a limit of 10 patches because it's not that useful to
1786         iterate through the entire review queue at this point.  We can remove
1787         the limit later.
1788
1789         * Scripts/bugzilla-tool:
1790         * Scripts/modules/bugzilla.py:
1791
1792 2009-11-16  Adam Barth  <abarth@webkit.org>
1793
1794         Reviewed by Eric Seidel.
1795
1796         Unit test WorkQueue
1797         https://bugs.webkit.org/show_bug.cgi?id=31531
1798
1799         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1800
1801         * Scripts/bugzilla-tool:
1802         * Scripts/modules/statusbot.py:
1803         * Scripts/modules/workqueue.py:
1804         * Scripts/modules/workqueue_unittest.py: Added.
1805         * Scripts/run-webkit-unittests:
1806
1807 2009-11-16  Eric Seidel  <eric@webkit.org>
1808
1809         Reviewed by Adam Barth.
1810
1811         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1812         https://bugs.webkit.org/show_bug.cgi?id=31530
1813
1814         * Scripts/bugzilla-tool:
1815
1816 2009-11-16  Eric Seidel  <eric@webkit.org>
1817
1818         Reviewed by Adam Barth.
1819
1820         bugzilla-tool needs apply-attachment
1821         https://bugs.webkit.org/show_bug.cgi?id=31528
1822
1823         * Scripts/bugzilla-tool:
1824          - Add ApplyAttachment command.
1825          - Abstract applying code into WebKitApplyingScripts.
1826          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1827         * Scripts/modules/bugzilla.py:
1828          - Add fetch_attachment and bug_id_for_attachment_id.
1829         * Scripts/modules/bugzilla_unittest.py:
1830          - Add test for new parsing.
1831          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1832
1833 2009-11-16  Eric Seidel  <eric@webkit.org>
1834
1835         Reviewed by Adam Barth.
1836
1837         Document check-style's use of force_clean.
1838
1839         * Scripts/bugzilla-tool:
1840         * Scripts/modules/scm.py:
1841
1842 2009-11-16  Adam Barth  <abarth@webkit.org>
1843
1844         Reviewed by Eric Seidel.
1845
1846         Move WorkQueue to its own file
1847         https://bugs.webkit.org/show_bug.cgi?id=31529
1848
1849         WorkQueue and WorkQueueDelegate are separate concerns from
1850         bugzilla-tool.  Also added a missing include to logging.py.
1851
1852         * Scripts/bugzilla-tool:
1853         * Scripts/modules/logging.py:
1854         * Scripts/modules/workqueue.py:
1855
1856 2009-11-16  Adam Barth  <abarth@webkit.org>
1857
1858         Reviewed by Eric Seidel.
1859
1860         Move OutputTee to logging.py.
1861
1862         * Scripts/bugzilla-tool:
1863         * Scripts/modules/logging.py:
1864
1865 2009-11-15  Adam Barth  <abarth@webkit.org>
1866
1867         Reviewed by Eric Seidel.
1868
1869         Refactor bugzilla-tool to allow for multiple queues
1870         https://bugs.webkit.org/show_bug.cgi?id=31513
1871
1872         Divide the commit queue class into three class to make creating
1873         additional queues easier.
1874
1875         * Scripts/bugzilla-tool:
1876
1877 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1878
1879         Reviewed by Eric Seidel.
1880
1881         svn-apply may not handle git patches created by bugzilla-tool
1882         https://bugs.webkit.org/show_bug.cgi?id=31457
1883
1884         * Scripts/modules/scm.py:
1885         * Scripts/modules/scm_unittest.py:
1886
1887 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1888
1889         Reviewed by Eric Seidel.
1890
1891         bugzilla-tool should post git binary diff
1892         https://bugs.webkit.org/show_bug.cgi?id=31458
1893
1894         Add --binary option to Git.create_patch.
1895
1896         * Scripts/modules/scm.py:
1897         * Scripts/modules/scm_unittest.py:
1898
1899 2009-11-15  Adam Barth  <abarth@webkit.org>
1900
1901         Reviewed by Darin Adler.
1902
1903         Add bugzilla-tool check-style
1904         https://bugs.webkit.org/show_bug.cgi?id=31515
1905
1906         * Scripts/bugzilla-tool:
1907         * Scripts/modules/bugzilla.py:
1908
1909 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1910
1911         Reviewed by Simon Hausmann.
1912
1913         Make the Qt Linux only --valgrind feature, suppress errors
1914         defined in the SuppressedValgrindErrors file.
1915
1916         * Scripts/run-webkit-tests:
1917
1918 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1919
1920         Reviewed by Simon Hausmann.
1921
1922         Set the locale to C and not to the current one in use on the system.
1923
1924         * DumpRenderTree/qt/DumpRenderTree.cpp:
1925         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1926
1927 2009-11-13  Adam Roben  <aroben@apple.com>
1928
1929         Add support for
1930         http/tests/security/isolatedWorld/didClearWindowObject.html
1931
1932         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1933         window objects in isolated worlds are cleared
1934
1935         Reviewed by Dave Hyatt.
1936
1937         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1938
1939         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1940         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1941         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1942         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1943         Added. Sets a __worldID property on the global object whose value is
1944         the ID of this world.
1945         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1946         Respond to this new delegate callback by calling through to one of the
1947         above new methods.
1948         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1949         (worldMap): Added. Returns a HashMap containing all the worlds we've
1950         created.
1951         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1952         haven't kept track of this world.
1953         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1954         instead of declaring our own.
1955
1956         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1957
1958         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1959         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1960         didClearWindowObjectForFrameInStandardWorld.
1961         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1962         Respond to this new delegate callback by calling through to one of the
1963         below new methods.
1964         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1965         Added. Sets a __worldID property on the gobal object whose value is
1966         the ID of this world.
1967         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1968         Added. Moved code here from didClearWindowObject.
1969
1970         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1971         didClearWindowObjectForFrame* functions.
1972
1973         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1974         (worldMap): Added. Returns a HashMap containing all the worlds we've
1975         created.
1976         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1977         haven't kept track of this world.
1978         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1979         instead of declaring our own.
1980
1981 2009-11-13  Adam Roben  <aroben@apple.com>
1982
1983         Finish replacing worldIDs with world objects
1984
1985         The only remaining use of worldIDs was in a method only used by DRT
1986         for the isolated worlds tests.
1987
1988         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1989
1990         Reviewed by Mark Rowe.
1991
1992         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1993         (LayoutTestController::evaluateScriptInIsolatedWorld):
1994         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1995         (LayoutTestController::evaluateScriptInIsolatedWorld):
1996         Updated for changes to WebFrame. Now holds the map of worldID -> world
1997         at this level instead of making WebKit do it.
1998
1999 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2000
2001         Reviewed by Simon Hausmann.
2002
2003         [Qt] Ensure the DRT does not output anything until first test is run
2004
2005         * DumpRenderTree/qt/DumpRenderTree.cpp:
2006         * DumpRenderTree/qt/DumpRenderTree.h:
2007
2008 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2009
2010         Reviewed by Tor Arne Vestbø.
2011
2012         Clear the undo stack in before each new test run.
2013
2014         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
2015
2016         * DumpRenderTree/qt/DumpRenderTree.cpp:
2017         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2018
2019 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2020
2021         Reviewed by Kenneth Rohde Christiansen.
2022
2023         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
2024
2025         * DumpRenderTree/qt/DumpRenderTree.cpp:
2026         (WebCore::WebPage::resetSettings):
2027         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2028         (LayoutTestController::overridePreference):
2029
2030 2009-11-13  Eric Seidel  <eric@webkit.org>
2031
2032         Reviewed by Adam Barth.
2033
2034         Update committers.py based on svn records
2035         https://bugs.webkit.org/show_bug.cgi?id=31366
2036
2037         This list was generated using validate-committer-lists from
2038         https://bugs.webkit.org/show_bug.cgi?id=30970
2039         and makes committers.py current for committers who have
2040         committed in the last 3 years.
2041
2042         * Scripts/modules/committers.py:
2043
2044 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
2045
2046         Reviewed by Adam Barth.
2047
2048         The document-open.html test was flaky at times. The test invokes the layout test plugin
2049         which in its destroy stream handler opens a new document. This basically tears down the
2050         stream and the associated plugin instance. The pluginLog function in the layout test
2051         plugin attempts to retrieve the window script object on a torn down plugin instance
2052         which crashed consistently on windows in the debugger. The functions which issue
2053         these logs already have a valid window script object. We now have variants of the pluginLog
2054         function which take in a window script object with and without variable arguments.
2055
2056         https://bugs.webkit.org/show_bug.cgi?id=31067
2057
2058         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2059         (pluginLogWithWindowObject):
2060         (pluginLogWithWindowObjectVariableArgs):
2061         (pluginLog):
2062         (notifyTestCompletion):
2063         (testDocumentOpen):
2064         (testWindowOpen):
2065
2066 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2067
2068         Reviewed by Gustavo Noronha Silva.
2069
2070         https://bugs.webkit.org/show_bug.cgi?id=30997
2071         [Gtk] Implemment AtkDocument
2072
2073         Added testing support.
2074
2075         * DumpRenderTree/AccessibilityUIElement.cpp:
2076         * DumpRenderTree/AccessibilityUIElement.h:
2077         (getDocumentEncodingCallback):
2078         (getDocumentURICallback):
2079         (AccessibilityUIElement::getJSClass):
2080         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2081         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2082         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2083         (AccessibilityUIElement::documentEncoding):
2084         (AccessibilityUIElement::documentURI):
2085
2086 2009-11-12  Adam Roben  <aroben@apple.com>
2087
2088         Replace worldIDs with world objects
2089
2090         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
2091         user scripts/stylesheets and isolated worlds
2092
2093         Reviewed by Sam Weinig.
2094
2095         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2096         (LayoutTestController::addUserScript):
2097         (LayoutTestController::addUserStyleSheet):
2098         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2099         (LayoutTestController::addUserScript):
2100         (LayoutTestController::addUserStyleSheet):
2101         Changed these functions to create a new WebJSWorld each time they're
2102         called and to pass that world to WebKit.
2103
2104 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
2105
2106         Reviewed by Oliver Hunt.
2107
2108         need to implement aria tree roles
2109         https://bugs.webkit.org/show_bug.cgi?id=31284
2110
2111         * DumpRenderTree/AccessibilityUIElement.cpp:
2112         (disclosedRowAtIndexCallback):
2113         (selectedRowAtIndexCallback):
2114         (isEqualCallback):
2115         (isAttributeSettableCallback):
2116         (isActionSupportedCallback):
2117         (disclosedByRowCallback):
2118         (hierarchicalLevelCallback):
2119         (AccessibilityUIElement::getJSClass):
2120         * DumpRenderTree/AccessibilityUIElement.h:
2121         (AccessibilityUIElement::isEqual):
2122         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2123         (AccessibilityUIElement::hierarchicalLevel):
2124         (AccessibilityUIElement::disclosedRowAtIndex):
2125         (AccessibilityUIElement::selectedRowAtIndex):
2126         (AccessibilityUIElement::disclosedByRow):
2127         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2128         (AccessibilityUIElement::getChildAtIndex):
2129         (AccessibilityUIElement::disclosedRowAtIndex):
2130         (AccessibilityUIElement::selectedRowAtIndex):
2131         (AccessibilityUIElement::titleUIElement):
2132         (AccessibilityUIElement::parentElement):
2133         (AccessibilityUIElement::disclosedByRow):
2134         (AccessibilityUIElement::hierarchicalLevel):
2135         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2136         (AccessibilityUIElement::hierarchicalLevel):
2137         (AccessibilityUIElement::disclosedRowAtIndex):
2138         (AccessibilityUIElement::selectedRowAtIndex):
2139         (AccessibilityUIElement::disclosedByRow):
2140
2141 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
2142
2143         Reviewed by Darin Adler.
2144
2145         svn-apply can not handle git binary diffs
2146         https://bugs.webkit.org/show_bug.cgi?id=26830
2147
2148         Support "literal" type git binary diffs.
2149
2150         * Scripts/VCSUtils.pm:
2151         * Scripts/modules/scm_unittest.py:
2152         * Scripts/svn-apply:
2153
2154 2009-11-11  Dmitry Titov  <dimich@chromium.org>
2155
2156         Not reviewed, removing duplicate entry for myself in committers.py.
2157
2158         * Scripts/modules/committers.py:
2159
2160 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
2161
2162         Reviewed by Darin Adler and Mark Rowe.
2163
2164         https://bugs.webkit.org/show_bug.cgi?id=31200
2165         Tests in http/tests/security/mixedContent start to fail when new tests are added
2166
2167         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
2168
2169 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2170
2171         Reviewed by Jan Alonzo.
2172
2173         Create, and display a window for the inspector, for inspector
2174         tests.
2175
2176         Need to also show/hide the inspector window to avoid having
2177         problems with code assuming it is realized
2178         https://bugs.webkit.org/show_bug.cgi?id=31347
2179
2180         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2181         (webInspectorShowWindow):
2182         (webInspectorCloseWindow):
2183         (webInspectorInspectWebView):
2184         (createWebView):
2185
2186 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2187
2188         Unreviewed Qt buildbot fix.
2189
2190         My previous fix was wrong, so revert that change and fix it by
2191         returning when the document of the frame has no document element.
2192         Idea is borrowed from mac and win DRT.
2193
2194         * DumpRenderTree/qt/DumpRenderTree.cpp:
2195         (WebCore::DumpRenderTree::dumpFramesAsText):
2196
2197 2009-11-11  Eric Seidel  <eric@webkit.org>
2198
2199         Reviewed byg Kenneth Rohde Christiansen.
2200
2201         Update Kenneth's committer record to include the email he
2202         uses on lists.webkit.org.
2203
2204         * Scripts/modules/committers.py:
2205
2206 2009-11-11  Eric Seidel  <eric@webkit.org>
2207
2208         Reviewed by Gustavo Noronha Silva.
2209
2210         Several committers use separate email addresses for bugzilla and svn.webkit.org
2211         https://bugs.webkit.org/show_bug.cgi?id=31364
2212
2213         Update records for existing committers to include email addresses
2214         used in svn.webkit.org and lists.webkit.org.
2215         Most committers use the same email address in all 3 places, but some use
2216         separate addresses.  committers.py needs record of each of these addresses.
2217
2218         * Scripts/modules/committers.py:
2219
2220 2009-11-11  Eric Seidel  <eric@webkit.org>
2221
2222         No review, adding second email address for an existing committer.
2223
2224         Add Yong Li's second bugzilla account to his committer record.
2225         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
2226
2227         * Scripts/modules/committers.py:
2228
2229 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2230
2231         Reviewed by Simon Hausmann.
2232
2233         If the frame has no innerText don't append it, and
2234         do not add a newline which breaks some cross platform
2235         results.
2236
2237         * DumpRenderTree/qt/DumpRenderTree.cpp:
2238         (WebCore::DumpRenderTree::dumpFramesAsText):
2239
2240 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2241
2242         Reviewed by Simon Hausmann.
2243
2244         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2245
2246         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2247         (webkit_test_plugin_new_instance):
2248         (webkit_test_plugin_destroy_instance):
2249         (webkit_test_plugin_destroy_stream):
2250
2251 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2252
2253         Reviewed by Mark Rowe.
2254
2255         Implement the functionality needed by plugins/window-open.html
2256
2257         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2258         (webkit_test_plugin_new_instance):
2259         (webkit_test_plugin_set_window):
2260
2261 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2262
2263         Reviewed by Simon Hausmann.
2264
2265         [Qt] Force -graphicssystem raster and -style windows when running DRT
2266
2267         * DumpRenderTree/qt/main.cpp:
2268         * Scripts/run-webkit-tests:
2269
2270 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2271
2272         Reviewed by Simon Hausmann.
2273
2274         Compute correct library paths for Qt
2275
2276         * Scripts/webkitdirs.pm:
2277
2278 2009-11-10  Mark Rowe  <mrowe@apple.com>
2279
2280         Reviewed by Sam Weinig.
2281
2282         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2283
2284         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2285         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2286         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2287         that had enabled frame load delegate logging this would result in extra log messages being generated,
2288         causing the test to fail.
2289
2290         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2291         tests.
2292
2293         * DumpRenderTree/mac/DumpRenderTree.mm:
2294         (dumpRenderTree):
2295         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2296         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2297
2298 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2299
2300         Reviewed by Kenneth Rohde Christiansen.
2301
2302         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2303
2304         * DumpRenderTree/qt/DumpRenderTree.cpp:
2305         (WebCore::DumpRenderTree::DumpRenderTree):
2306
2307 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2308
2309         Reviewed by Jan Alonzo.
2310
2311         [GTK] Remove WebSocket configuration from WebKitWebSettings
2312         https://bugs.webkit.org/show_bug.cgi?id=31244
2313
2314         Follow-up of r50724. Don't set the enable-web-socket property
2315         anymore.
2316
2317         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2318         (resetDefaultsToConsistentValues):
2319
2320 2009-11-10  Oliver Hunt  <oliver@apple.com>
2321
2322         Reviewed by Maciej Stachowiak.
2323
2324         Rename 3D Canvas related classes to use WebGL prefix
2325         https://bugs.webkit.org/show_bug.cgi?id=29095
2326
2327         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2328         and upate webkitdirs script to new method of testing for WebGL.
2329
2330         * Scripts/do-webcore-rename:
2331         * Scripts/webkitdirs.pm:
2332
2333 2009-11-09  Oliver Hunt  <oliver@apple.com>
2334
2335         Reviewed by Geoff Garen.
2336
2337         Make do-webcore-rename work with git.
2338
2339         * Scripts/do-webcore-rename:
2340
2341 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2342
2343         Adding Kenneth to the reviewers list.
2344
2345         * Scripts/modules/committers.py:
2346
2347 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2348
2349         Reviewed by Jan Alonzo.
2350
2351         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2352         https://bugs.webkit.org/show_bug.cgi?id=30482
2353
2354         LayoutTestControllerGtk now uses the exposed
2355         Page::tabKeyCyclesThroughElements API
2356
2357         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2358         (LayoutTestController::setTabKeyCyclesThroughElements):
2359
2360 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2361
2362         Reviewed by Holger Freyther.
2363
2364         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2365         This helps to pass the test case below. Also replaced hardcoded
2366         code numbers with defined constants.
2367         https://bugs.webkit.org/show_bug.cgi?id=31185
2368
2369         Test: editing/undo/undo-deleteWord.html
2370
2371         * DumpRenderTree/qt/EventSenderQt.cpp:
2372         (EventSender::keyDown):
2373
2374 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2375
2376         Reviewed by Holger Freyther.
2377
2378         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2379         https://bugs.webkit.org/show_bug.cgi?id=31164
2380
2381         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2382
2383         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2384         (LayoutTestController::processWork):
2385
2386 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2387
2388         Reviewed by Holger Freyther.
2389
2390         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2391         https://bugs.webkit.org/show_bug.cgi?id=31158
2392
2393         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2394         always, which from WorkQueue prospective means that a load has been started
2395         and the queue processing should stop and wait for the load to finish.
2396         Spinning it off into a loading and a non-loading variants was the solution
2397         adopted by Mac's DRT to work around this problem. The former keeps returning
2398         'true' while the later executes the script synchronously and returns 'false'
2399         making it possible to the WorkQueue to proceed right away.
2400
2401         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2402         (LayoutTestController::processWork):
2403         (LayoutTestController::queueLoadingScript):
2404         (LayoutTestController::queueNonLoadingScript):
2405         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2406         * DumpRenderTree/qt/WorkQueueItem.h:
2407         (LoadingScriptItem::LoadingScriptItem):
2408         (LoadingScriptItem::invoke):
2409         (NonLoadingScriptItem::NonLoadingScriptItem):
2410         (NonLoadingScriptItem::invoke):
2411
2412 2009-11-07  Mark Rowe  <mrowe@apple.com>
2413
2414         Rubber-stamped by Cameron Zwarich.
2415
2416         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2417
2418         * Scripts/commit-log-editor:
2419
2420 2009-11-07  Mark Rowe  <mrowe@apple.com>
2421
2422         Reviewed by Darin Adler.
2423
2424         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2425         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2426
2427         Move logic for determining the name and email address to use in a ChangeLog entry from
2428         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2429         whether the author of the patch matches committer, and therefore needs access to the
2430         email address that would be used in a ChangeLog entry.
2431
2432         Based on a patch by Pierre d'Herbemont.
2433
2434         * Scripts/VCSUtils.pm:
2435         * Scripts/commit-log-editor:
2436         * Scripts/prepare-ChangeLog:
2437         * Scripts/webkitdirs.pm:
2438
2439 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2440
2441         Reviewed by Adam Barth.
2442
2443         Added functionality to the layout test plugin to invoke document.open and
2444         window.open with default arguments. The associated webkit bug is
2445         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2446         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2447         work in Chromium (V8) if there is no calling javascript context. To achieve this
2448         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2449         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2450
2451         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2452         (testDocumentOpen):
2453         (testWindowOpen):
2454         (pluginAllocate):
2455         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2456         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2457         (NPP_New):
2458         (NPP_SetWindow):
2459         (NPP_DestroyStream):
2460         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2461         (NPP_New):
2462         (NPP_SetWindow):
2463         (NPP_NewStream):
2464         (NPP_DestroyStream):
2465
2466 2009-11-06  Eric Seidel  <eric@webkit.org>
2467
2468         Reviewed by Adam Barth.
2469
2470         bugzilla-tool crashed with exception
2471         https://bugs.webkit.org/show_bug.cgi?id=31092
2472
2473         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2474
2475 2009-11-04  Eric Seidel  <eric@webkit.org>
2476
2477         No review, just add a line which got left out of the patch uploaded for commit.
2478
2479         commit-queue is crashing when trying to reject patches after unknown failures
2480         https://bugs.webkit.org/show_bug.cgi?id=31091
2481
2482         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2483
2484 2009-11-04  Adam Roben  <aroben@apple.com>
2485
2486         Remove bogus else clause in bugzilla-tool
2487
2488         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2489         create-bug raises exception after entering bug description
2490
2491         Reviewed by David Kilzer.
2492
2493         * Scripts/bugzilla-tool:
2494         (CreateBug): else clauses are only hit if no exception is raised, so
2495         it makes no sense to try to re-raise the exception in an else clause.
2496         The exception will automatically be re-raised if it doesn't match any
2497         of the except clauses, so we don't have to do anything special here at
2498         all to get the desired behavior.
2499
2500 2009-11-04  Eric Seidel  <eric@webkit.org>
2501
2502         Reviewed by David Kilzer.
2503
2504         svn-apply's fixChangeLogPatch function seems broken
2505         https://bugs.webkit.org/show_bug.cgi?id=30683
2506
2507         Update fixChangeLogPatch to be able to handle patches which
2508         don't start at line 1.
2509         Add unit tests for svn-apply to scm_unittest.py.
2510
2511         * Scripts/VCSUtils.pm:
2512         * Scripts/modules/scm_unittest.py:
2513
2514 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2515
2516         Reviewed by Beth Dakin.
2517
2518         Need to implement ARIA role="combobox"
2519         https://bugs.webkit.org/show_bug.cgi?id=31096
2520
2521         * DumpRenderTree/AccessibilityUIElement.cpp:
2522         (showMenuCallback):
2523         (getIsExpandedCallback):
2524         (AccessibilityUIElement::getJSClass):
2525         * DumpRenderTree/AccessibilityUIElement.h:
2526         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2527         (AccessibilityUIElement::isExpanded):
2528         (AccessibilityUIElement::showMenu):
2529         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2530         (AccessibilityUIElement::isExpanded):
2531         (AccessibilityUIElement::showMenu):
2532         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2533         (AccessibilityUIElement::isSelected):
2534         (AccessibilityUIElement::isExpanded):
2535         (AccessibilityUIElement::showMenu):
2536
2537 2009-11-04  Eric Seidel  <eric@webkit.org>
2538
2539         Reviewed by Adam Barth.
2540
2541         commit-queue is crashing when trying to reject patches after unknown failures
2542         https://bugs.webkit.org/show_bug.cgi?id=31091
2543
2544         * Scripts/bugzilla-tool:
2545          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2546            so we have to find out what the current patch is by asking bugzilla again.
2547          - Discovered that this code was also leaking file descriptors, so fixed that.
2548
2549 2009-11-04  Adam Roben  <aroben@apple.com>
2550
2551         Make run-webkit-tests work for the Debug_Internal Windows
2552         configuration
2553
2554         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2555         suffix.
2556
2557         Fixes <http://webkit.org/b/31123>.
2558
2559         Reviewed by Sam Weinig.
2560
2561         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2562         Debug_Internal, either.
2563
2564 2009-11-04  Eric Seidel  <eric@webkit.org>
2565
2566         Reviewed by Adam Barth.
2567
2568         committers.py needs a way to store non-bugzilla email addresses
2569         https://bugs.webkit.org/show_bug.cgi?id=31037
2570
2571         Make Committer and Reviewer constructors take a single email or a list of emails.
2572         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2573         Expose reviewers(), used by validate-committer-lists on bug 30970.
2574
2575         * Scripts/modules/committers.py:
2576         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2577
2578 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2579
2580         Reviewed by David Levin.
2581
2582         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2583         https://bugs.webkit.org/show_bug.cgi?id=27491
2584
2585         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2586         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2587
2588         Functions to start or stop Web Socket servers are added.
2589
2590         * Scripts/run-webkit-tests:
2591
2592 2009-11-03  Eric Seidel  <eric@webkit.org>
2593
2594         No review, just changing wording of log message.
2595
2596         Change log string to say "failed" instead of "rejected"
2597         when a commit fails due to an out of date checkout.
2598         This makes grepping the commit-queue log for rejected patches easier.
2599
2600         * Scripts/bugzilla-tool:
2601
2602 2009-11-03  Eric Seidel  <eric@webkit.org>
2603
2604         No review, adding commonly known committers missing from the file.
2605
2606         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2607
2608 2009-11-03  Eric Seidel  <eric@webkit.org>
2609
2610         No review, just sort-order cleanup.
2611
2612         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2613
2614 2009-11-03  Stephen White  <senorblanco@chromium.org>
2615
2616         (Unreviewed).
2617
2618         Add myself to committers.py.
2619
2620         * Scripts/modules/committers.py:
2621
2622 2009-11-03  Robin Dunn  <robin@alldunn.com>
2623
2624         Reviewed by Kevin Ollviier.
2625
2626         Add packaging scripts for Debian-based Linux distros.
2627
2628         https://bugs.webkit.org/show_bug.cgi?id=31075
2629
2630         * wx/packaging/build-debian-installer.py: Added.
2631         * wx/packaging/debian: Added.
2632
2633 2009-11-03  Dan Bernstein  <mitz@apple.com>
2634
2635         Reviewed by Anders Carlsson and Beth Dakin.
2636
2637         https://bugs.webkit.org/show_bug.cgi?id=31070
2638
2639         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2640         destroyed, it executes the value of the 'ondestroy' parameter as a
2641         script.
2642
2643         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2644         (pluginAllocate): Initialize onDestroy.
2645         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2646         onDestroy.
2647         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2648         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2649         specified.
2650         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2651
2652 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2653
2654         Reviewed by Xan Lopez.
2655
2656         https://bugs.webkit.org/show_bug.cgi?id=31035
2657         [GTK] some accessibility tests hitting assertion in debug builds
2658
2659         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2660
2661         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2662         (AccessibilityController::rootElement):
2663
2664 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2665
2666         Reviewed by Beth Dakin.
2667
2668         Support ARIA "tab" roles
2669         https://bugs.webkit.org/show_bug.cgi?id=30842
2670
2671         * DumpRenderTree/AccessibilityUIElement.cpp:
2672         * DumpRenderTree/AccessibilityUIElement.h:
2673         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2674         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2675         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2676
2677 2009-11-01  Eric Seidel  <eric@webkit.org>
2678
2679         Reviewed by David Levin.
2680
2681         buildbots should use --exit-after-N-failures
2682         https://bugs.webkit.org/show_bug.cgi?id=30809
2683
2684         Make the bots exit after 20 failures to prevent never-ending
2685         test runs where every test spends a minute crashing.
2686
2687         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2688
2689 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2690
2691         Reviewed by Eric Seidel.
2692
2693         Turn on warnings for QtWebKit for gcc
2694         https://bugs.webkit.org/show_bug.cgi?id=30958
2695
2696         * DumpRenderTree/qt/main.cpp:
2697         (crashHandler): Mark function NO_RETURN
2698
2699 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2700
2701         Adding myself to the committers list.
2702
2703         * Scripts/modules/committers.py:
2704
2705 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2706
2707         Fix an issue that Adam noticed in DRT.
2708
2709         Reviewed by Darin Adler.
2710
2711         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2712         (AccessibilityUIElement::role):
2713         Get the length of the role text, and create a buffer dynamically.
2714
2715 2009-10-30  Eric Seidel  <eric@webkit.org>
2716
2717         No review, rolling out r50105.
2718         http://trac.webkit.org/changeset/50105
2719
2720         This commit was causing:
2721         https://bugs.webkit.org/show_bug.cgi?id=30869
2722         We'll re-implement the feature a different way.
2723
2724         * Scripts/bugzilla-tool:
2725
2726 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2727
2728         Test for MSAA: Accessibility of headings is not correct
2729
2730         https://bugs.webkit.org/show_bug.cgi?id=30937
2731
2732         Reviewed by Adam Roben.
2733
2734         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2735         (AccessibilityUIElement::role):
2736         Allow the role returned to be a BSTR.
2737         (AccessibilityUIElement::description):
2738         Fix a copy/paste error.
2739
2740 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2741
2742         Test for MSAA: Accessibility of links is wrong
2743
2744         https://bugs.webkit.org/show_bug.cgi?id=30928
2745
2746         Reviewed by Darin Adler.
2747
2748         * DumpRenderTree/AccessibilityUIElement.cpp:
2749         (getAccessibilityValueCallback):
2750         Return the accessibility value.
2751         (AccessibilityUIElement::getJSClass):
2752         Added "accessibilityValue" value.
2753
2754         * DumpRenderTree/AccessibilityUIElement.h:
2755
2756         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2757         (AccessibilityUIElement::accessibilityValue):
2758         Stubbed.
2759
2760         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2761         (AccessibilityUIElement::accessibilityValue):
2762         Stubbed.
2763
2764         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2765         (AccessibilityUIElement::accessibilityValue):
2766         Get the object's value, and return it as a JS string.
2767
2768 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2769
2770         Fix typo in command name used by wx build system.
2771
2772         * wx/build/build_utils.py:
2773
2774 2009-10-30  Adam Barth  <abarth@webkit.org>
2775
2776         Reviewed by Darin Adler.
2777
2778         Patch v1 is a dumb default name for patches
2779         https://bugs.webkit.org/show_bug.cgi?id=30952
2780
2781         Let's use "Patch" instead.
2782
2783         * Scripts/bugzilla-tool:
2784
2785 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2786
2787         Unreviewed trivial buildfix.
2788
2789         [Qt] Buildfix for r50333.
2790
2791         * DumpRenderTree/qt/DumpRenderTree.pro:
2792
2793 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2794
2795         Reviewed by Holger Freyther.
2796
2797         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2798         https://bugs.webkit.org/show_bug.cgi?id=30953
2799
2800         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2801         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2802         makes qt DRT to share this implementation (as gtk and mac ports do).
2803
2804         * DumpRenderTree/qt/DumpRenderTree.pro:
2805         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2806         * DumpRenderTree/qt/WorkQueue.h: Removed.
2807
2808 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2809
2810         Unreviewed potential buildbot fix.
2811
2812         Second try: Reset page history before running each test.
2813
2814         Apparently the QWebHistory::clear() keeps the current page
2815         in history which is not what we want, so we not additionally
2816         sets the history capacity to 0 (forces removing everything)
2817         and then sets it back to its original value.
2818
2819         * DumpRenderTree/qt/DumpRenderTree.cpp:
2820         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2821
2822 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2823
2824         Unreviewed potential buildbot fix.
2825
2826         Reset page history before running each test.
2827
2828         * DumpRenderTree/qt/DumpRenderTree.cpp:
2829         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2830
2831 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2832
2833         Reviewed by Eric Seidel.
2834
2835         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2836
2837         Bug 28420 -  Implement HTML5 <ruby> rendering
2838         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2839
2840         No new tests (no functional change).
2841
2842         * Scripts/build-webkit:
2843
2844 2009-10-29  Dan Bernstein  <mitz@apple.com>
2845
2846         Reviewed by Mark Rowe.
2847
2848         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2849         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2850         define it.
2851
2852         * Scripts/VCSUtils.pm:
2853         * Scripts/svn-apply:
2854         * Scripts/svn-unapply:
2855
2856 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2857
2858         Reviewed by Gustavo Noronha.
2859
2860         Use the GTK+ main loop instead of rolling our own mini-version of
2861         it.
2862
2863         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2864         (dump):
2865         (runTest):
2866         (webViewLoadFinished):
2867
2868 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2869
2870         Reviewed by Oliver Hunt.
2871
2872         Implement the Qt version of DRT dumpBackForwardList().
2873
2874         * DumpRenderTree/qt/DumpRenderTree.cpp:
2875         (WebCore::dumpHistoryItem):
2876         (WebCore::DumpRenderTree::dumpBackForwardList):
2877
2878 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2879
2880         Reviewed by Adam Roben.
2881
2882         Implement DRT functionality for Qt introduced in
2883         r28690 and r28705.
2884
2885         - Implemented pathToLocalResource which exposes the functionality of
2886         converting a given unix path to the correct location on Windows.
2887         - Implemented a way to remove machine-dependent information from paths
2888         in layout test results.
2889
2890         * DumpRenderTree/qt/DumpRenderTree.cpp:
2891         (WebCore::urlSuitableForTestResult):
2892         (WebCore::WebPage::javaScriptConsoleMessage):
2893         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2894         (LayoutTestController::pathToLocalResource):
2895         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2896
2897 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2898
2899         Adding myself to the committers list.
2900
2901         * Scripts/modules/committers.py:
2902
2903 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2904
2905         Adding myself to the committers list.
2906
2907         * Scripts/modules/committers.py:
2908
2909 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2910
2911         Reviewed by Jan Alonzo.
2912
2913         [GTK] API to start inspector for a WebView
2914         https://bugs.webkit.org/show_bug.cgi?id=22551
2915
2916         Use the new inspector API to implement the LayoutTestController
2917         interfaces used to test the inspector.
2918
2919         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2920         (webInspectorInspectWebView):
2921         (createWebView):
2922         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2923         (LayoutTestController::showWebInspector):
2924         (LayoutTestController::closeWebInspector):
2925         (LayoutTestController::evaluateInWebInspector):
2926
2927 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2928
2929         Reviewed by Eric Seidel.
2930
2931         [Qt] WebFrame::counterValueForElementById must not be exposed
2932         https://bugs.webkit.org/show_bug.cgi?id=30882
2933
2934         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2935         (LayoutTestController::counterValueForElementById):
2936
2937 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2938
2939         Rubberstamped by Oliver Hunt.
2940
2941         Fix the warning:
2942
2943         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2944         declared with attribute warn_unused_result".
2945
2946         by actually checking the result. In the case it is null, an
2947         error has occoured, so treat it as the other fatal errors.
2948
2949         * DumpRenderTree/qt/DumpRenderTree.cpp:
2950         (WebCore::DumpRenderTree::initializeFonts):
2951
2952 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2953
2954         Reviewed by Darin Adler.
2955
2956         Provide a way to get counter values with layoutTestContoller
2957         https://bugs.webkit.org/show_bug.cgi?id=30555
2958
2959         Define layoutTestContoller.counterValueForElementById.
2960
2961         * DumpRenderTree/LayoutTestController.cpp:
2962         (counterValueForElementByIdCallback):
2963         (LayoutTestController::staticFunctions):
2964         * DumpRenderTree/LayoutTestController.h:
2965         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2966         (LayoutTestController::counterValueForElementById):
2967
2968 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2969
2970         Rubberstamped by Oliver Hunt.
2971
2972         Change two methods to be internal for DRT use only.
2973
2974         Part of [Qt] Review all new API in Qt 4.6
2975         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2976
2977         * DumpRenderTree/qt/DumpRenderTree.cpp:
2978         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2979         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2980         (LayoutTestController::whiteListAccessFromOrigin):
2981
2982 2009-10-27  Eric Seidel  <eric@webkit.org>
2983
2984         Reviewed by Adam Barth.
2985
2986         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2987         https://bugs.webkit.org/show_bug.cgi?id=30826
2988
2989         * Scripts/svn-apply:
2990          - Add () around all system() calls.
2991          - Use the correct system() == 0 or die instead of system() or die
2992          - Add descriptive messages to all die statements.
2993
2994 2009-10-27  Steve Block  <steveblock@google.com>
2995
2996         Reviewed by NOBODY.
2997
2998         Adds steveblock@google.com to list of committers.
2999
3000         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
3001
3002 2009-10-27  Eric Seidel  <eric@webkit.org>
3003
3004         Reviewed by Adam Barth.
3005
3006         svn-apply can exit(0) even on patch failure
3007         https://bugs.webkit.org/show_bug.cgi?id=29622
3008
3009         * Scripts/svn-apply:
3010          - Add a bunch of "or die" statements, hopefully catching all
3011            possible cases where failure could still exit(0).
3012
3013 2009-10-27  Eric Seidel  <eric@webkit.org>
3014
3015         Reviewed by Adam Barth.
3016
3017         svn-* scripts should share code through VCSUtils.pm
3018         https://bugs.webkit.org/show_bug.cgi?id=30791
3019
3020         Just moving code into a shared location.
3021
3022         * Scripts/VCSUtils.pm:
3023         * Scripts/prepare-ChangeLog:
3024         * Scripts/resolve-ChangeLogs:
3025         * Scripts/svn-apply:
3026         * Scripts/svn-create-patch:
3027         * Scripts/svn-unapply:
3028         * Scripts/update-webkit:
3029
3030 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
3031
3032         Suppress a huge number of MSVC warnings when building wxWebKit.
3033
3034         * wx/build/settings.py:
3035
3036 2009-10-26  Eric Seidel  <eric@webkit.org>
3037
3038         No review, just adding Mike Belshe to the committers list.
3039
3040         * Scripts/modules/committers.py:
3041
3042 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3043
3044         Reviewed by Darin Adler.
3045
3046         Make .rc files compile on Windows without depending on MFC headers
3047         https://bugs.webkit.org/show_bug.cgi?id=30750
3048
3049         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
3050         windows.h instead of afxres.h because it exists even when MFC is not
3051         installed, and is all that's needed here.
3052
3053         * FindSafari/FindSafari.rc: Ditto
3054
3055 2009-10-24  Eric Seidel  <eric@webkit.org>
3056
3057         Reviewed by Adam Barth.
3058
3059         bugzilla-tool post-diff should know how to mark commit-queue=?
3060         https://bugs.webkit.org/show_bug.cgi?id=29202
3061
3062         * Scripts/bugzilla-tool:
3063          - Add --commit-queue option to post-diff, post-commits and create-bug.
3064         * Scripts/modules/bugzilla.py:
3065          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
3066          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
3067
3068 2009-10-23  Eric Seidel  <eric@webkit.org>
3069
3070         Reviewed by Adam Barth.
3071
3072         bugzilla-tool commit-queue does not notice modifications to committers.py
3073         https://bugs.webkit.org/show_bug.cgi?id=30084
3074
3075         * Scripts/bugzilla-tool:
3076          - Make commit-queue re-exec itself instead of using while(1).
3077          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
3078          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
3079
3080 2009-10-22  Eric Seidel  <eric@webkit.org>
3081
3082         Reviewed by Adam Barth.
3083
3084         commit-queue will get stuck on patches if land-patches terminates unexpectedly
3085         https://bugs.webkit.org/show_bug.cgi?id=30634
3086
3087         * Scripts/bugzilla-tool:
3088          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
3089          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
3090
3091 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
3092
3093         Reviewed by Eric Seidel.
3094
3095         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
3096
3097         https://bugs.webkit.org/show_bug.cgi?id=30763
3098
3099         * pywebsocket/mod_pywebsocket/__init__.py:
3100         * pywebsocket/mod_pywebsocket/dispatch.py:
3101         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
3102         * pywebsocket/mod_pywebsocket/standalone.py:
3103         * pywebsocket/setup.py:
3104         * pywebsocket/test/test_dispatch.py:
3105
3106 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
3107
3108         Reviewed by David Levin.
3109
3110         REGRESSION: 2 failures in run-webkit-unittests
3111         https://bugs.webkit.org/show_bug.cgi?id=30645
3112
3113         * Scripts/modules/cpp_style_unittest.py:
3114         Fixed a few test scenarios which apparently lost some spaces from
3115         text literals.
3116
3117 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
3118
3119         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
3120
3121         * Scripts/webkitdirs.pm:
3122
3123 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
3124
3125         Reviewed by Darin Adler.
3126
3127         Unification of using null device in perl scripts.
3128         https://bugs.webkit.org/show_bug.cgi?id=30572
3129
3130         * Scripts/VCSUtils.pm:
3131         * Scripts/bisect-builds:
3132         * Scripts/resolve-ChangeLogs:
3133         * Scripts/run-iexploder-tests:
3134         * Scripts/run-jsc:
3135         * Scripts/run-mangleme-tests:
3136         * Scripts/run-webkit-tests:
3137         * Scripts/webkitdirs.pm:
3138         Using File::Spec->devnull() instead of hard coded /dev/null.
3139
3140 2009-10-26  Eric Seidel  <eric@webkit.org>
3141
3142         Reviewed by Holger Freyther.
3143
3144         Reviewers are missing from committers.py
3145         https://bugs.webkit.org/show_bug.cgi?id=30733
3146
3147         * Scripts/modules/committers.py:
3148
3149 2009-10-23  Eric Seidel  <eric@webkit.org>
3150
3151         No review, only adding Alice to the list of reviewers.
3152
3153         * Scripts/modules/committers.py:
3154
3155 2009-10-23  Eric Seidel  <eric@webkit.org>
3156
3157         Reviewed by Eric Carlson.
3158
3159         fast/media/mq-transform-02.html failed on Leopard Commit Bot
3160         https://bugs.webkit.org/show_bug.cgi?id=30700
3161
3162         * DumpRenderTree/mac/DumpRenderTree.mm:
3163         (resetDefaultsToConsistentValues): Update QuickTime version check.
3164
3165 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
3166
3167         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
3168         character measurement APIs that are private on Tiger.
3169
3170         * wx/build/settings.py:
3171
3172 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3173
3174         Reviewed by NOBODY (build fix).
3175         Build fix following bug #30696.
3176
3177         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3178         (LayoutTestController::evaluateScriptInIsolatedWorld):
3179
3180 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3181
3182         Reviewed by Sam Weinig & Geoff Garen.
3183
3184         https://bugs.webkit.org/show_bug.cgi?id=30696
3185         Enable isolated-worlds tests on mac.
3186
3187         Add private interface for DRT to invoke execution in a given world.
3188
3189         * DumpRenderTree/LayoutTestController.cpp:
3190         (evaluateScriptInIsolatedWorldCallback):
3191         (LayoutTestController::staticFunctions):
3192         * DumpRenderTree/LayoutTestController.h:
3193         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3194         (LayoutTestController::evaluateScriptInIsolatedWorld):
3195         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3196         (LayoutTestController::evaluateScriptInIsolatedWorld):
3197
3198 2009-10-21  Eric Seidel  <eric@webkit.org>
3199
3200         Reviewed by Adam Barth.
3201
3202         bugzilla-tool's "patch failed to download an apply" error should give more information
3203         https://bugs.webkit.org/show_bug.cgi?id=30632
3204
3205         * Scripts/modules/scm.py:
3206          - Use the common run_command method instead of custom POpen code.
3207          - Make run_command know how to take pipes as input.
3208         * Scripts/modules/scm_unittest.py:
3209          - Add new tests to cover change.
3210          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
3211
3212 2009-10-21  Kent Tamura  <tkent@chromium.org>
3213
3214         Unreviewed.  Adding myself to the committers list.
3215
3216         * Scripts/modules/committers.py:
3217
3218 2009-10-21  Robin Dunn  <robin@alldunn.com>
3219
3220         Reviewed by Kevin Ollivier.
3221
3222         Update the Windows installer builder to work with Vista / Win 7 and with git.
3223
3224         https://bugs.webkit.org/show_bug.cgi?id=30649
3225
3226         * wx/build/build_utils.py:
3227         * wx/packaging/build-mac-installer.py:
3228         * wx/packaging/build-win-installer.py:
3229         * wx/packaging/wxWebKitInstaller.iss.in:
3230
3231 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3232
3233         Reviewed by Gustavo Noronha.
3234
3235         [GTK] Added conditional code to avoid using
3236         gdk_window_get_root_coords if we do not have a gtk+ release newer
3237         than 2.17.3.
3238         https://bugs.webkit.org/show_bug.cgi?id=30636
3239
3240         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3241
3242 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3243
3244         Reviewed by Eric Seidel.
3245
3246         [Qt] Added dummy implementation for keepWebHistory()
3247         https://bugs.webkit.org/show_bug.cgi?id=30592
3248
3249         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3250         (LayoutTestController::keepWebHistory):
3251         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3252
3253 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3254
3255         Reviewed by Xan Lopez.
3256
3257         [GTK] Fixed the double click condition, it is not double click if
3258         we move in just in one direction.
3259         https://bugs.webkit.org/show_bug.cgi?id=30636
3260
3261         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3262
3263 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3264
3265         Reviewed by Xan Lopez.
3266
3267         [GTK] Initialize the events completly before emitting them.
3268         https://bugs.webkit.org/show_bug.cgi?id=30633
3269
3270         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3271
3272 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3273
3274         wx build fix. Fix for when linking using --as-needed with gcc.
3275
3276         * wx/browser/wscript:
3277
3278 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3279
3280         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3281         to support all the features used by CURL backend.
3282
3283         * wx/build/settings.py:
3284         * wx/install-unix-extras:
3285
3286 2009-10-20  Anton Muhin  <antonm@chromium.org>
3287
3288         Reviewed by Adam Barth.
3289
3290         Add {ager,antonm,yurys}@chromium.org into committers.py
3291         https://bugs.webkit.org/show_bug.cgi?id=30560
3292
3293         * Scripts/modules/committers.py:
3294
3295 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3296
3297         Reviewed by Tor Arne Vestbø.
3298
3299         Make the Netscape Test plugin available to the Qt launcher.
3300
3301         * Scripts/run-launcher:
3302
3303 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3304
3305         Reviewed by David Levin.
3306
3307         Removed WebSocket runtime settings.
3308         https://bugs.webkit.org/show_bug.cgi?id=29896
3309
3310         WebSocket runtime configuration is supported by chromium/v8 only.
3311
3312         * DumpRenderTree/mac/DumpRenderTree.mm:
3313         (resetDefaultsToConsistentValues):
3314         * DumpRenderTree/win/DumpRenderTree.cpp:
3315         (resetDefaultsToConsistentValues):
3316
3317 2009-10-19  Nate Chapin  <japhet@chromium.org>
3318
3319         Reviewed by Adam Barth.
3320
3321         Add testFail() to test plugin so we can test our handling of a
3322         plugin invoke call returning false.
3323
3324         https://bugs.webkit.org/show_bug.cgi?id=30239
3325
3326         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3327         (pluginInvoke):
3328         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3329
3330 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3331
3332         Reviewed by Gustavo Noronha.
3333
3334         Enable DOM pasting when running layout tests.
3335
3336         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3337         (resetDefaultsToConsistentValues):
3338
3339 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3340
3341         Reviewed by Simon Hausmann.
3342
3343         Use the setPreferredContentsSize method instead
3344         of setFixedContentsSize, as the method has been renamed.
3345
3346         * DumpRenderTree/qt/DumpRenderTree.cpp:
3347         (WebCore::DumpRenderTree::open):
3348         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3349         (LayoutTestController::setFixedContentsSize):
3350
3351 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3352
3353         Reviewed by Dan Bernstein.
3354
3355         https://bugs.webkit.org/show_bug.cgi?id=30456
3356         Fixes for new Debug_All Windows build configuration.
3357
3358         * DumpRenderTree/win/DumpRenderTree.cpp:
3359         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3360         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3361
3362 2009-10-16  Eric Seidel  <eric@webkit.org>
3363
3364         Reviewed by Adam Barth.
3365
3366         commit-queue status bot should list which buildbot is blocking the queue
3367         https://bugs.webkit.org/show_bug.cgi?id=30452
3368
3369         Add new methods and testing.
3370
3371         * Scripts/bugzilla-tool:
3372         * Scripts/modules/buildbot.py:
3373         * Scripts/modules/buildbot_unittest.py:
3374
3375 2009-10-16  Eric Seidel  <eric@webkit.org>
3376
3377         Reviewed by Adam Barth.
3378
3379         run-webkit-tests fails when CWD is not inside a WebKit checkout
3380         https://bugs.webkit.org/show_bug.cgi?id=30451
3381
3382         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3383         * Scripts/modules/scm_unittest.py:
3384           - Remove use of original_path (we don't need to restore the CWD).
3385           - Don't use '.' to find the webkit checkout, use __file__ instead.
3386
3387 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3388
3389         Reviewed by Adam Roben.
3390
3391         Add a Debug_All configuration to build entire stack as debug.
3392         Change Debug_Internal to:
3393         - stop using _debug suffix for all WebKit/Safari binaries
3394         - not use _debug as a DLL naming suffix
3395         - use non-debug C runtime lib.
3396
3397         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3398         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3399         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3400         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3401         Add missing debug.vsprops inherited property sheet.
3402         Add Debug_All configuration.
3403         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3404         * WinLauncher/WinLauncher.vcproj:
3405         Removed extraneous definitions inherited from vsprops.
3406         Add Debug_All configuration.
3407
3408 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3409
3410         Reviewed by David Levin.
3411
3412         check-webkit-style is wrong about indent checking in namespaces
3413         in header files and a few other things
3414         https://bugs.webkit.org/show_bug.cgi?id=30362
3415
3416         The few other things include:
3417         + check-webkit-style does not require spaces around the equal sign
3418           inside 'if' statements and around binary operators that take
3419           numeric literals.
3420         + check-webkit-style reports false errors for the / operator
3421           when part of a filename in the #include directive.
3422
3423         * Scripts/modules/cpp_style.py:
3424         Improved indentation checking and space checking around
3425         binary operators. While the checks are still not perfect,
3426         they are clearly better than before.
3427         * Scripts/modules/cpp_style_unittest.py:
3428         Added test cases for the newly supported checks and modified old
3429         test cases to match the new guidelines
3430
3431 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3432
3433         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3434
3435         * wx/build/settings.py:
3436
3437 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3438
3439         Reviewed by David Levin.
3440
3441         Add mod_pywebsocket to test Web Sockets.
3442         http://code.google.com/p/pywebsocket/
3443         https://bugs.webkit.org/show_bug.cgi?id=27490
3444
3445         * pywebsocket/COPYING: Added.
3446         * pywebsocket/MANIFEST.in: Added.
3447         * pywebsocket/README: Added.
3448         * pywebsocket/example/echo_client.py: Added.
3449         * pywebsocket/example/echo_wsh.py: Added.
3450         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3451         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3452         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3453         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3454         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3455         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3456         * pywebsocket/mod_pywebsocket/util.py: Added.
3457         * pywebsocket/setup.py: Added.
3458         * pywebsocket/test/config.py: Added.
3459         * pywebsocket/test/mock.py: Added.
3460         * pywebsocket/test/run_all.py: Added.
3461         * pywebsocket/test/test_dispatch.py: Added.
3462         * pywebsocket/test/test_handshake.py: Added.
3463         * pywebsocket/test/test_mock.py: Added.
3464         * pywebsocket/test/test_msgutil.py: Added.
3465         * pywebsocket/test/test_util.py: Added.
3466         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3467         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3468         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3469         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3470         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3471         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3472         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3473         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3474
3475 2009-10-15  James Robinson  <jamesr@google.com>
3476
3477         Reviewed by David Levin.
3478
3479         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3480
3481         https://bugs.webkit.org/show_bug.cgi?id=30426
3482
3483         * Scripts/modules/cpp_style.py:
3484         * Scripts/modules/cpp_style_unittest.py:
3485
3486 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3487
3488         Reviewed by Adam Roben.
3489
3490         Fixes <http://webkit.org/b/30411>.
3491         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3492
3493         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3494         building Chromium.
3495
3496         * Scripts/pdevenv:
3497
3498 2009-10-15  Robin Dunn  <robin@alldunn.com>
3499
3500         Reviewed by Kevin Ollivier.
3501
3502         Add Mac package building scripts for wx.
3503
3504         https://bugs.webkit.org/show_bug.cgi?id=30405
3505
3506         * wx/build/build_utils.py:
3507         * wx/build/settings.py:
3508         * wx/packaging/build-mac-installer.py: Added.
3509
3510 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3511
3512         Reviewed by Gustavo Noronha.
3513
3514         Enable Web Sockets support when running layout tests.
3515
3516         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3517         (resetDefaultsToConsistentValues):
3518
3519 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3520
3521         Reviewed by Gustavo Noronha.
3522
3523         Need to initialize event.button.button, since in most cases a
3524         button number is not passed as an argument.
3525
3526         * DumpRenderTree/gtk/EventSender.cpp:
3527         (mouseDownCallback):
3528         (mouseUpCallback):
3529
3530 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3531
3532         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3533         the OS if none was explicitly set.
3534
3535         * wx/build/settings.py:
3536
3537 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3538
3539         Reviewed by Timothy Hatcher.
3540
3541         Web Inspector: enable developers extras within inspector layout tests.
3542
3543         https://bugs.webkit.org/show_bug.cgi?id=30014
3544
3545         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3546         (LayoutTestController::showWebInspector):
3547         (LayoutTestController::closeWebInspector):
3548         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3549         (LayoutTestController::showWebInspector):
3550         (LayoutTestController::closeWebInspector):
3551
3552 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3553
3554         Reviewed by Jan Alonzo.
3555
3556         GtkLauncher is using a deprecated signal
3557         https://bugs.webkit.org/show_bug.cgi?id=30364
3558
3559         Modified GtkLauncher to use notify::title signal instead of
3560         deprecated title-changed signal
3561
3562         * GtkLauncher/main.c:
3563         (notify_title_cb):
3564         (create_browser):
3565
3566 2009-10-14  Brady Eidson  <beidson@apple.com>
3567
3568         Reviewed by Sam Weinig.
3569
3570         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3571         1 - Disables WebHistory
3572         2 - Doesn't make sense in that context anyway.
3573
3574         * DumpRenderTree/win/DumpRenderTree.cpp:
3575         (createWebViewAndOffscreenWindow):
3576
3577 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3578
3579         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3580         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3581
3582         * wx/build/settings.py:
3583         * wx/install-unix-extras:
3584
3585 2009-10-14  Brady Eidson  <beidson@apple.com>
3586
3587         Reviewed by Sam Weinig.
3588
3589         WebKit Win API should provide a delegate interface for global history.
3590         https://bugs.webkit.org/show_bug.cgi?id=29905
3591
3592         * DumpRenderTree/LayoutTestController.cpp:
3593         (LayoutTestController::LayoutTestController):
3594         * DumpRenderTree/LayoutTestController.h:
3595         (LayoutTestController::dumpHistoryDelegateCallbacks):
3596         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3597
3598         * DumpRenderTree/win/DumpRenderTree.cpp:
3599         (shouldLogHistoryDelegates):
3600         (runTest):
3601         (createWebViewAndOffscreenWindow):
3602         (main):
3603         * DumpRenderTree/win/DumpRenderTree.vcproj:
3604
3605         Add the IWebHistoryDelegate to DRT Windows:
3606         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3607         (wstringFromBSTR):
3608         (HistoryDelegate::HistoryDelegate):
3609         (HistoryDelegate::~HistoryDelegate):
3610         (HistoryDelegate::QueryInterface):
3611         (HistoryDelegate::AddRef):
3612         (HistoryDelegate::Release):
3613         (HistoryDelegate::didNavigateWithNavigationData):
3614         (HistoryDelegate::didPerformClientRedirectFromURL):
3615         (HistoryDelegate::didPerformServerRedirectFromURL):
3616         (HistoryDelegate::updateHistoryTitle):
3617         (HistoryDelegate::populateVisitedLinksForWebView):
3618         * DumpRenderTree/win/HistoryDelegate.h: Added.
3619
3620         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3621         (LayoutTestController::removeAllVisitedLinks):
3622
3623 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3624
3625         Reviewed by Simon Hausmann.
3626
3627         [Qt] Implement support for setPOSIXLocale on Qt.
3628         https://bugs.webkit.org/show_bug.cgi?id=30268
3629
3630         * DumpRenderTree/qt/DumpRenderTree.cpp:
3631         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3632         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3633         (LayoutTestController::setPOSIXLocale):
3634         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3635
3636 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3637
3638         Unreviewed, adding myself to reviewers list.
3639
3640         * Scripts/modules/committers.py:
3641
3642 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3643
3644         Reviewed by Mark Rowe.
3645
3646         Fix null assignment so root tests work again.
3647
3648         * Scripts/webkitdirs.pm:
3649
3650 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3651
3652         Reviewed by Simon Hausmann.
3653
3654         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3655         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3656         This is done in preparation of implementing missing features in DRT.
3657         No functionality changes made yet.
3658
3659         * DumpRenderTree/qt/DumpRenderTree.cpp:
3660         * DumpRenderTree/qt/DumpRenderTree.pro:
3661         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3662         (EventSender::EventSender):
3663         (EventSender::mouseDown):
3664         (EventSender::mouseUp):
3665         (EventSender::mouseMoveTo):
3666         (EventSender::leapForward):
3667         (EventSender::keyDown):
3668         (EventSender::contextClick):
3669         (EventSender::scheduleAsynchronousClick):
3670         (EventSender::frameUnderMouse):
3671         * DumpRenderTree/qt/EventSenderQt.h: Added.
3672         (EventSender::clearKillRing):
3673         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3674         (LayoutTestController::LayoutTestController):
3675         (LayoutTestController::reset):
3676         (LayoutTestController::processWork):
3677         (LayoutTestController::maybeDump):
3678         (LayoutTestController::waitUntilDone):
3679         (LayoutTestController::notifyDone):
3680         (LayoutTestController::windowCount):
3681         (LayoutTestController::clearBackForwardList):
3682         (LayoutTestController::dumpEditingCallbacks):
3683         (LayoutTestController::dumpResourceLoadCallbacks):
3684         (LayoutTestController::queueBackNavigation):
3685         (LayoutTestController::queueForwardNavigation):
3686         (LayoutTestController::queueLoad):
3687         (LayoutTestController::queueReload):
3688         (LayoutTestController::queueScript):