ac532b80b0edb0aa235499f4d92e5daba808e91d
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-11-14  Anders Carlsson  <andersca@apple.com>
2
3         Reviewed by Adam.
4
5         <rdar://problem/5309081>
6         In DRT, "plugin.logDestroy = true" not working on Windows.
7         
8         * DumpRenderTree/win/TestNetscapePlugin/main.c:
9         (NPP_Destroy):
10
11 2007-11-14  Eric Seidel  <eric@webkit.org>
12
13         Reviewed by Sam.
14
15         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
16
17 2007-11-14  Anders Carlsson  <andersca@apple.com>
18
19         Reviewed by Adam.
20
21         <rdar://problem/5141186>
22         window.layoutTestController.setWindowIsKey is not implemented in DRT.
23         
24         Implement setWindowIsKey.
25         
26         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
27         (LayoutTestController::setWindowIsKey):
28
29 2007-11-13  Sam Weinig  <sam@webkit.org>
30
31         Reviewed by Adam Roben.
32
33         Fix for <rdar://problem/5382579>
34         http/tests/security/cross-frame-access-put.html reports large 
35         negative numbers for screenLeft and screenTop (Mac reports "0")
36
37         * DumpRenderTree/win/UIDelegate.cpp:
38         (UIDelegate::UIDelegate): Initialize the RECT.
39         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
40         (UIDelegate::webViewFrame): ditto.
41         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
42
43 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
44
45         Reviewed by Adam.
46
47         - Make Drosera show source, source URLs, and function stack on Windows,
48         and some minor fixes.
49
50         * Drosera/DebuggerDocument.cpp: Force source to always update display.
51         (DebuggerDocument::updateFileSource):
52         * Drosera/debugger.js: Force source to always update display.
53         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
54         menu controls.
55         (DebuggerClient::resume):
56         (DebuggerClient::pause):
57         (DebuggerClient::stepInto):
58         (DebuggerClient::stepOver):
59         (DebuggerClient::stepOut):
60         (DebuggerClient::showConsole):
61         (DebuggerClient::closeCurrentFile):
62         * Drosera/win/DebuggerClient.h: Ditto.
63         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
64         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
65         removed two bugs.  1) caller could be in a bad state when asked to
66         assign into it. 2) BSTRs were not created correctly.
67         (DebuggerDocument::getPlatformCurrentFunctionStack):
68         * Drosera/win/Drosera.cpp: Hook up the menu controls.
69         (droseraWndProc):
70         (handleCommand):
71         (Drosera::resume):
72         (Drosera::pause):
73         (Drosera::stepInto):
74         (Drosera::stepOver):
75         (Drosera::stepOut):
76         (Drosera::showConsole):
77         (Drosera::closeCurrentFile):
78         * Drosera/win/Drosera.h: Hook up the menu controls.
79         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
80         functions, added a null check, and fixed another bug where caller could
81         be in a bad state when asked to assign into it.
82         (ServerConnection::didLoadMainResourceForDataSource):
83         (ServerConnection::getCallerFrame):
84         * Drosera/win/ServerConnection.h: Safety first.
85
86 2007-11-13  Dan Bernstein  <mitz@apple.com>
87
88         Reviewed by Darin Adler.
89
90         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
91           DumpRenderTree --pixel-tests renders each test twice
92
93         * DumpRenderTree/mac/DumpRenderTree.mm:
94         (dumpRenderTree): Removed the --paint option because the painting code
95         is always exercised as a result of
96         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
97         calling -displayIfNeeded.
98         (dump): Changed to always grab the image from the window since the view
99         is always displayed.
100         (runTest):
101         (displayWebView):
102         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
103         because it always paints.
104
105 2007-11-12  Antti Koivisto  <antti@apple.com>
106
107         Reviewed by Adele.
108         
109         Add support for http media tests
110
111         * Scripts/run-webkit-tests:
112
113 2007-11-12  Sam Weinig  <sam@webkit.org>
114
115         Reviewed by Adam Roben.
116
117         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
118
119         * DumpRenderTree/win/DumpRenderTree.cpp:
120         (runTest):
121         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
122         (LayoutTestController::setPrivateBrowsingEnabled):
123
124 2007-11-12  Adam Roben  <aroben@apple.com>
125
126         * Scripts/update-webkit-localizable-strings: Changed to only scan the
127         mac and win subdirectories.
128
129 2007-11-11  Adam Roben  <aroben@apple.com>
130
131         Fix <rdar://5133816> keepWebHistory is not implemented
132
133         Fixes fast/history/clicked-link-is-visited.html.
134
135         Reviewed by Darin.
136
137         * DumpRenderTree/win/DumpRenderTree.cpp:
138         (runTest): Clear the optionalSharedHistory.
139         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
140         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
141
142 2007-11-10  Sam Weinig  <sam@webkit.org>
143
144         Reviewed by Tim Hatcher.
145
146         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
147         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
148         is turned on)
149
150         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
151
152         Added test: http/tests/security/cross-frame-access-private-browsing.html
153
154         * DumpRenderTree/LayoutTestController.cpp:
155         (setPrivateBrowsingEnabledCallback):
156         (LayoutTestController::staticFunctions):
157         * DumpRenderTree/LayoutTestController.h:
158         * DumpRenderTree/mac/DumpRenderTree.mm:
159         (runTest): Default to private browsing disabled.
160         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
161         (LayoutTestController::setPrivateBrowsingEnabled):
162         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
163         (LayoutTestController::setPrivateBrowsingEnabled):
164
165 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
166
167         Reviewed by Adam.
168
169         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
170         WebCore's!
171
172         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
173         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
174         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
175         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
176         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
177         * Drosera/win/Drosera.cpp:
178         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
179
180 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
181
182         Reviewed by Sam.
183
184         - Use the new IWebFrame [local] function signature and get the shared
185         server correctly.
186
187         * Drosera/win/DebuggerClient.cpp:
188         (DebuggerClient::didFinishLoadForFrame):
189         * Drosera/win/ServerConnection.cpp:
190         (ServerConnection::attemptToCreateServerConnection):
191
192 2007-11-07  Dan Bernstein  <mitz@apple.com>
193
194         Reviewed by Darin Adler.
195
196         - add an option to run-webkit-tests to ignore pixel test failures where
197           all pixels differ by no more than a specified threshold
198
199         * DumpRenderTree/mac/ImageDiff.m:
200         (main):
201         (compareImages):
202         (computePercentageDifferent):
203         * Scripts/run-webkit-tests:
204
205 2007-11-07  Simon Hausmann  <hausmann@kde.org>
206
207         Reviewed by Lars.
208
209         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
210
211         * DumpRenderTree/qt/DumpRenderTree.cpp:
212
213 2007-11-07  Simon Hausmann  <hausmann@kde.org>
214
215         Reviewed by Lars.
216
217         Reworked the QWebSettings API.
218         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
219
220         * DumpRenderTree/qt/DumpRenderTree.cpp:
221
222 2007-11-07  Simon Hausmann  <hausmann@kde.org>
223
224         Reviewed by Lars.
225
226         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
227
228         * DumpRenderTree/qt/jsobjects.cpp:
229
230 2007-11-07  Simon Hausmann  <hausmann@kde.org>
231
232         Reviewed by Lars Knoll <lars@trolltech.com>.
233
234         Add a QWebPage::frameCreated() signal and fix DRT
235         
236         The removal of createFrame in QWebPage broke the re-implementation
237         in DumpRenderTree. Instead emit a frameCreated() signal and
238         connect to it in DumpRenderTree.
239         
240
241         * DumpRenderTree/qt/DumpRenderTree.cpp:
242         (WebCore::WebPage::WebPage):
243         (WebCore::DumpRenderTree::dump):
244         (WebCore::DumpRenderTree::connectFrame):
245         * DumpRenderTree/qt/DumpRenderTree.h:
246
247 2007-11-07  Simon Hausmann  <hausmann@kde.org>
248
249         Reviewed by Lars Knoll <lars@trolltech.com>.
250
251         Moved all the event handlers from QWebFrame into QWebPage.
252         
253         This cleans up the public API and allows us to remove the
254         HackWebFrame hack in DumpRenderTree.
255         
256
257         * DumpRenderTree/qt/jsobjects.cpp:
258         (EventSender::mouseDown):
259         (EventSender::mouseUp):
260         (EventSender::mouseMoveTo):
261
262 2007-11-07  Simon Hausmann  <hausmann@kde.org>
263
264         Reviewed by Mark.
265
266         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
267         to prevent the default implementation from popping up messageboxes.
268
269         * DumpRenderTree/qt/DumpRenderTree.cpp:
270         (WebCore::WebPage::javaScriptConfirm):
271         (WebCore::WebPage::javaScriptPrompt):
272
273 2007-11-06  Eric Seidel  <eric@webkit.org>
274
275         * Scripts/build-testkjs: build fix... too many $$
276
277 2007-11-06  Eric Seidel  <eric@webkit.org>
278
279         Reviewed by Mark Rowe.
280
281         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
282
283 2007-11-05  Adam Roben  <aroben@apple.com>
284
285         Add support on Windows for WEBKIT_TESTFONTS
286
287         This environment variable lets you specify where the fonts to be used
288         by DumpRenderTree reside. The Qt port is already using this, so I'm
289         just following their lead.
290
291         Reviewed by Darin.
292
293         * DumpRenderTree/win/DumpRenderTree.cpp:
294         (exePath): Refactored code out of initialize().
295         (fontsPath): Returns either $WEBKIT_TESTFONTS or
296         DumpRenderTree.resources.
297         (initialize): Use the new fontsPath function.
298         (main): Use the new exePath function.
299         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
300         variable to DRT, like Qt does.
301
302 2007-11-05  Mark Rowe  <mrowe@apple.com>
303
304         Rubber-stamped by Alp Toker.
305
306         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
307
308         * GtkLauncher/main.cpp:
309         (goToURLBarText):
310         (main):
311
312 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
313
314         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
315         <http://bugs.webkit.org/show_bug.cgi?id=15830>
316
317         Reviewed by Timothy.
318
319         Restrict the range of nightly builds used by the bisect-builds script
320         based on the version of Safari and the version of Mac OS X being used.
321
322         Mac OS X 10.4: Safari 2.0: r11976 or newer
323         Mac OS X 10.4: Safari 3.0: r19992 or newer
324
325         Mac OS X 10.5: Safari 2.0: r19594 or newer
326         Mac OS X 10.5: Safari 3.0: r25124 or newer
327
328         * Scripts/bisect-builds:
329         (findMacOSXVersion): Added.
330         (makeNightlyList): Added argument to provide version of Mac OS X.
331         Restrict range of nightly builds based on Safari and Mac OS X versions.
332
333 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
334
335         Reviewed by Maciej.
336
337         - This patch involves several changes, all of them were noticed that
338         they were needed by the work being done in WebKit to get Drosera and
339         WebKit working together on Windows.
340         - The changes are:
341         1) Added a debugger console for output messages.
342         2) Drosera now listens for the WebKit server (before, the server would
343         have to be running before Drosera was started.)
344         3) Fixed a bug where the WebView started out as 0x0 pixels.
345         4) Fixed a bug when there is no scope.
346         5) Added the HTML, JS, and CSS to the project file to make them easy to
347         find.
348         6) Made the ServerConnection functions virtual.
349
350         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
351         for the WebKit server.
352         (DebuggerClient::DebuggerClient):
353         (DebuggerClient::~DebuggerClient):
354         (DebuggerClient::didFinishLoadForFrame):
355         (DebuggerClient::serverConnected):
356         (DebuggerClient::attemptToCreateServerConnection):
357         * Drosera/win/DebuggerClient.h: Ditto.
358         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
359         scope.
360         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
361         (DebuggerDocument::platformValueForScopeVariableNamed):
362         * Drosera/win/Drosera.cpp:
363         (_tWinMain): Added a console in debug for output messages.
364         (Drosera::Drosera): Listen for server.
365         (Drosera::initUI): The server now Initializes COM.
366         (Drosera::serverConnected): Part of the listening for the server.
367         (Drosera::attemptToCreateServerConnection): Ditto.
368         * Drosera/win/Drosera.h: New interface for listening for the server.
369         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
370         files to the VS project.
371         * Drosera/win/ServerConnection.cpp: Part of listening for the server
372         connection.
373         (ServerConnection::ServerConnection):
374         (ServerConnection::attemptToCreateServerConnection):
375         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
376         methods.
377         (ServerConnection::serverConnected):
378
379 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
380
381         Reviewed by Maciej.
382
383         http://bugs.webkit.org/show_bug.cgi?id=15832
384         fast/dom/gc-10.html crashes when run alone
385
386         Check for !done before using objects that can be already deallocated.
387
388         * DumpRenderTree/mac/EditingDelegate.mm:
389         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
390         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
391         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
392         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
393         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
394         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
395         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
396         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
397         (-[EditingDelegate webViewDidBeginEditing:]):
398         (-[EditingDelegate webViewDidChange:]):
399         (-[EditingDelegate webViewDidEndEditing:]):
400         (-[EditingDelegate webViewDidChangeTypingStyle:]):
401         (-[EditingDelegate webViewDidChangeSelection:]):
402         * DumpRenderTree/mac/FrameLoadDelegate.mm:
403         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
404         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
405         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
406         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
407         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
408         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
409         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
410         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
411         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
412         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
413         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
414         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
415         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
416         (-[FrameLoadDelegate webView:willCloseFrame:]):
417         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
418         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
419         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
420         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
421         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
422         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
423         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
424         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
425         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
426
427 2007-11-04  Mark Rowe  <mrowe@apple.com>
428
429         Build fix.  Don't use Carbon.h as the prefix header as it triggers
430         warnings that would otherwise be suppressed due to it being a system header.
431
432         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
433
434 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
435
436         Rubber stamped by Adam.
437         
438         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
439
440         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
441
442 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
443
444         Sort files(...); sections of Xcode project files.
445
446         Rubber-stamped by Darin.
447
448         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
449         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
450         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
451         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
452
453 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
454
455         Script to sort "files(...);" sections in Xcode project.pbxproj files.
456
457         Reviewed by Darin.
458
459         * Scripts/sort-Xcode-project-file: Added.
460
461 2007-11-02  Darin Adler  <darin@apple.com>
462
463         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
464
465 2007-11-02  Darin Adler  <darin@apple.com>
466
467         Reviewed by Maciej.
468
469         * Scripts/run-sunspider: Pass the "--base" option through.
470
471         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
472         the real script do that. Default configuration to Release to match run-sunspider
473         so we don't end up building Debug just to compare results.
474
475 2007-11-01  Adam Roben  <aroben@apple.com>
476
477         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
478
479         Reviewed by Sam.
480
481         * Scripts/commit-log-editor: Show all the directories beneath the
482         source root, instead of just the last one.
483
484 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
485
486         Reviewed by Adam Roben.
487
488         Print out an error message when the Windows build fails
489         and provide guidance on how to find out what went wrong.
490
491         * Scripts/build-webkit:
492         * Scripts/webkitdirs.pm:
493
494 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
495
496         Rubber-stamped by Adam Roben.
497
498         Rolled out r27326 - debug CRT seems to cause no problems after all.
499
500         * DumpRenderTree/win/DumpRenderTree.vcproj:
501
502 2007-10-31  Adam Roben  <aroben@apple.com>
503
504         Switch the Debug configuration to using the non-debug CRT
505
506         This matches WebKit.
507
508         Reviewed by Steve.
509
510         * DumpRenderTree/win/DumpRenderTree.vcproj:
511
512 2007-10-31  Antti Koivisto  <antti@apple.com>
513
514         Reviewed by bdash.
515         
516         Disable media tests when doing leak checking on Tiger.
517         They crash in QuickTime (rdar://problem/5537157).
518
519         * Scripts/run-webkit-tests:
520
521 2007-10-29  Antti Koivisto  <antti@apple.com>
522
523         Reviewed by Maciej.
524         
525         Build media support by default on OSX only.
526
527         * Scripts/build-webkit:
528
529 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
530
531         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
532         get caught by the pre-commit hooks.
533
534 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
535
536         Reviewed by Adam.
537
538         - This is a collection of relatively unrelated changes and cleanups
539         to Drosera to prepare it for interacting with WebKit.  A lot of these
540         changes are just correcting mistakes, for example removing included
541         headers that are no longer needed.
542
543         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
544         this will be needed by the DebuggerClient.
545         (DebuggerDocument::server):
546         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
547         * Drosera/win/DebuggerClient.cpp: 
548         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
549         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
550         (DebuggerClient::createWebViewWithRequest): Added comment about its
551         purpose. 
552         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
553         declarations.
554         (DebuggerClient::webViewLoaded): Moved.
555         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
556         file, since this was the only place it was used.
557         (cfStringToBSTR):
558         * Drosera/win/Drosera.h: Cleaned up the includes.
559         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
560         * Drosera/win/HelperFunctions.h: Removed.
561
562 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
563
564         Reviewed by Adam.
565
566         - Small cleanup in the ServerConnection class.
567
568         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
569         and added an include.
570         (ServerConnection::currentFrame):
571         (ServerConnection::getCallerFrame):
572         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
573         made a pointer into a COMPtr, and cleaned up the includes.
574
575 2007-10-29  Timothy Hatcher  <timothy@apple.com>
576
577         Reviewed by John Sullivan.
578         
579         - Place the Localizable.strings file in mac or win directories
580           if that location exists.
581         - Also look for UI_STRING in .c files.
582
583         * Scripts/extract-localizable-strings:
584
585 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
586
587         Reviewed by Adam.
588
589         - Set the eol-style to native and made all the line endings the same
590         so that I avoid messy diffs that show eol changes.
591
592         * Drosera/win/ServerConnection.cpp:
593         (ServerConnection::didParseSource):
594         (ServerConnection::didEnterCallFrame):
595         (ServerConnection::willExecuteStatement):
596         (ServerConnection::willLeaveCallFrame):
597         (ServerConnection::exceptionWasRaised):
598
599 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
600
601         Reviewed by Adam.
602
603         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
604         functionality that could not have existed previously without the new
605         interfaces.
606         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
607         from a BSTR to a JSValueRef.
608         (DebuggerDocument::platformEvaluateScript): Implemented.
609         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
610         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
611         Implemented.
612         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
613         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
614         * Drosera/win/ServerConnection.cpp: Added a helper function.
615         (ServerConnection::getCallerFrame):
616         * Drosera/win/ServerConnection.h: Added a helper function.
617
618 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
619
620         updated reviewers for my previous changelog.
621
622 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
623         Reviewed by Maciej and Adam and Geoff.
624
625         - Minor mac-side improvements including moving a function to a more
626         appropriate location, fixing a warning, and correctly checking
627         exceptions.
628
629         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
630         (DebuggerDocument::willExecuteStatement):
631         (DebuggerDocument::didEnterCallFrame):
632         (DebuggerDocument::willLeaveCallFrame):
633         (DebuggerDocument::windowScriptObjectAvailable):
634         (DebuggerDocument::callFunctionOnObject):
635         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
636         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
637         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
638         because it doesn't require the ServerConnection at all.
639         (NSStringCreateWithJSStringRef): Made an argument const.
640         (JSValueRefCreateWithNSString): Made an argument const.
641         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
642         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
643         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
644         * Drosera/mac/ServerConnection.mm: Ditto.
645         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
646
647 2007-10-29  Sam Weinig  <sam@webkit.org>
648
649         Reviewed by Adam Roben.
650
651         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
652
653         * DumpRenderTree/LayoutTestController.cpp:
654         (LayoutTestController::LayoutTestController):
655         (getGlobalFlagCallback):
656         (setGlobalFlagCallback):
657         (LayoutTestController::getJSClass):
658         (LayoutTestController::staticValues):
659         * DumpRenderTree/LayoutTestController.h:
660         (LayoutTestController::globalFlag):
661         (LayoutTestController::setGlobalFlag):
662
663 2007-10-29  Darin Adler  <darin@apple.com>
664
665         Reviewed by Maciej.
666
667         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
668         resolution instead of its default.
669
670 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
671
672         Fixed showStatus() to print status for successfully resolved conflicts when using git.
673
674         Reviewed by Mark Rowe.
675
676         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
677         was successfully resolved, but this would not show any status because the change had
678         already been cached in the index using "git add".  The solution is to add an optional
679         second argument to showStatus() which adds the "--cached" switch to the command.
680
681         * Scripts/resolve-ChangeLogs:
682         (showStatus):
683
684 2007-10-28  Eric Seidel  <eric@webkit.org>
685
686         Reviewed by Maciej and Geoff, in unison.
687
688         * Scripts/run-webkit-tests: remove broken --svg option
689
690 2007-10-28  Darin Adler  <darin@apple.com>
691
692         Reviewed by Adam.
693
694         * Scripts/run-sunspider: Default to "Release" configuration rather than
695         defaulting to the last configuration used as other scripts do. This can
696         still be overriden on the command line with "--debug" if there's some
697         reason to do so. Also fix a typo.
698
699         * Scripts/sunspider-compare-results: Fix a typo.
700
701 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
702
703         Reviewed by Adam.
704
705         - Implemented the WebScriptDebugListener functions now that the
706         WebScriptDebugServer exists
707
708         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
709         functions.
710         (ServerConnection::currentFrame):
711         (ServerConnection::didLoadMainResourceForDataSource):
712         (ServerConnection::didParseSource):
713         (ServerConnection::failedToParseSource):
714         (ServerConnection::didEnterCallFrame):
715         (ServerConnection::willExecuteStatement):
716         (ServerConnection::willLeaveCallFrame):
717         (ServerConnection::exceptionWasRaised):
718         * Drosera/win/ServerConnection.h: Removed unused arguments from the
719         members arguments list.
720
721 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
722
723         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
724         <http://bugs.webkit.org/show_bug.cgi?id=15600>
725
726         Reviewed by Darin.
727
728         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
729         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
730         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
731         file.  Note that it may also be used as a stand-alone script.
732
733         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
734         * Scripts/resolve-ChangeLogs: Added.
735         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
736
737 2007-10-26  Mark Rowe  <mrowe@apple.com>
738
739         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
740         to the Qt port on the assumption that it was an implementation of the cross-platform
741         LayoutTestController class.  It is not, so it did not need to be changed.
742
743         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
744
745 2007-10-25  Mark Rowe  <mrowe@apple.com>
746
747         Reviewed by Maciej.
748
749         Fix builds with code coverage enabled.
750
751         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
752
753 2007-10-25  Darin Adler  <darin@apple.com>
754
755         Reviewed by Mark Rowe.
756
757         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
758         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
759
760 2007-10-25  Stephanie  <slewis@apple.com>
761
762         build Fix
763
764         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
765
766 2007-10-25  Stephanie  <slewis@apple.com>
767
768         Reviewed by Mark Rowe, Adam Roben.
769
770         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
771
772         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
773
774 2007-10-25  Alice Liu  <alice.liu@apple.com>
775
776         Reviewed by Adam.
777
778         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
779
780         Moving destructor into platform-specific files
781         * DumpRenderTree/LayoutTestController.cpp:
782         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
783         (LayoutTestController::~LayoutTestController):
784         * DumpRenderTree/qt/jsobjects.cpp:
785         (LayoutTestController::~LayoutTestController):
786
787         LayoutTestController wasn't being destroyed
788         * DumpRenderTree/win/DumpRenderTree.cpp:
789         (runTest):
790
791         Added declspec
792         * DumpRenderTree/win/EditingDelegate.h:
793
794         Reset certain values on the webview (or related delegate) that might 
795         have changed while running a test
796         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
797         (LayoutTestController::~LayoutTestController):
798
799 2007-10-25  Adam Roben  <aroben@apple.com>
800
801         Make sunspider-compare-results work with relative paths
802
803         Reviewed by Sam.
804
805         * Scripts/sunspider-compare-results: Convert arguments to absolute
806         paths before we chdir.
807
808 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
809
810         Reviewed by Sam.
811
812         - Implemented server calls now the WebScriptDebugServer exists.
813         - Also removed no longer needed call to initialize CG.
814
815         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
816         automatically now.
817         (_tWinMain):
818         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
819         (ServerConnection::ServerConnection):
820         (ServerConnection::~ServerConnection):
821         (ServerConnection::pause):
822         (ServerConnection::resume):
823         (ServerConnection::stepInto):
824         (ServerConnection::applicationTerminating):
825         (ServerConnection::serverConnectionDidDie):
826         * Drosera/win/ServerConnection.h: Now uses the COM class.
827
828 2007-10-24  George Staikos  <staikos@kde.org>
829
830         Unbreak Qt build.
831
832         * Scripts/build-webkit:
833
834 2007-10-24  Adam Roben  <aroben@apple.com>
835
836         Remove now-unnecessary call to InitializeCoreGraphics
837
838         WebKit takes care of this now.
839
840         Reviewed by Ada.
841
842         * DumpRenderTree/win/DumpRenderTree.cpp:
843         (initialize):
844
845 2007-10-24  Adam Roben  <aroben@apple.com>
846
847         Use WebTextRenderer in DRT
848
849         Reviewed by Ada.
850
851         * DumpRenderTree/win/DumpRenderTree.cpp:
852         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
853
854 2007-10-24  Sven Herzberg  <sven@imendio.com>
855
856         Reviewed by Mark Rowe.
857
858         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
859         Bug 15614: [GTK] qmake based backends don't build on OS X
860
861         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
862         GTK backend on a Mac
863         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
864         isDarwin() to make it reusable in other places (like the workaround-
865         for-prebuilt-qmake in build-webkit)
866
867 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
868
869         Refurbish update-webkit script.
870
871         Reviewed by Adam.
872
873         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
874         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
875         multi-argument version of system() for flexibility and security.  Check for existence
876         of Internal directory using -d test instead of -x.
877
878 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
879
880         Minor clean-up of prepare-ChangeLog script.
881
882         Reviewed by Adam.
883
884         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
885         of a string.  Use multi-argument versions of open() and system() for flexibility and
886         security.
887
888 2007-10-24  Alice Liu  <alice.liu@apple.com>
889
890         Reviewed by Oliver.
891
892         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
893
894         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
895         replay the saved events when we're still processing the mousedown that starts the drag
896         * DumpRenderTree/win/EventSender.cpp:
897         (doMouseMove):
898         * DumpRenderTree/win/UIDelegate.cpp:
899         (UIDelegate::doDragDrop):
900
901 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
902
903         Reviewed by Sam, Steve and Darin.
904
905         - Stubbed out the WebScriptDebugListener functionality in the Server
906         Connection class to prepare it for receiving those callbacks.
907         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
908         and the ServerConnection to not need to be initialized with a server
909         name, since that is not the way we connect to the WebKit server. 
910
911         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
912         no exception.  Now it only loggs when there is an exception
913         (DebuggerDocument::willExecuteStatement):
914         (DebuggerDocument::didEnterCallFrame):
915         (DebuggerDocument::willLeaveCallFrame):
916         (DebuggerDocument::windowScriptObjectAvailable):
917         (DebuggerDocument::callFunctionOnObject):
918         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
919         to be instantiated with a server's name.
920         (DebuggerClient::DebuggerClient):
921         (DebuggerClient::didFinishLoadForFrame):
922         * Drosera/win/DebuggerClient.h: Removed unsued variable.
923         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
924         a server name.
925         (Drosera::init):
926         (Drosera::initServer):
927         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
928         instantiated with a server's name.
929         * Drosera/win/ServerConnection.cpp: 
930         (ServerConnection::ServerConnection): No longer needs a server name
931         (ServerConnection::~ServerConnection): Only release the global context
932         if there is one.
933         (ServerConnection::serverConnectionDidDie): Stub for
934         IWebScriptDebugListener
935         (ServerConnection::QueryInterface): ditto
936         (ServerConnection::AddRef): ditto
937         (ServerConnection::Release): ditto
938         (ServerConnection::didLoadMainResourceForDataSource): ditto
939         (ServerConnection::didParseSource): ditto
940         (ServerConnection::failedToParseSource): ditto
941         (ServerConnection::didEnterCallFrame): ditto
942         (ServerConnection::willExecuteStatement): ditto
943         (ServerConnection::willLeaveCallFrame): ditto
944         (ServerConnection::exceptionWasRaised): ditto
945         * Drosera/win/ServerConnection.h: Stubbed out the
946         IWebScriptDebugListener functions, and this class no longer needs to be
947         instantiated with a server name.
948
949 2007-10-24  Lars Knoll  <lars@trolltech.com>
950
951         Reviewed by Simon.
952
953         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
954
955         * DumpRenderTree/qt/jsobjects.h:
956
957 2007-10-24  Lars Knoll  <lars@trolltech.com>
958
959         Reviewed by Simon.
960
961         add another command.
962
963         * DumpRenderTree/qt/jsobjects.cpp:
964         (TextInputController::doCommand):
965
966 2007-10-24  Lars Knoll  <lars@trolltech.com>
967
968         Reviewed by Simon.
969
970         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
971
972         * DumpRenderTree/qt/jsobjects.cpp:
973         (EventSender::keyDown):
974         * DumpRenderTree/qt/jsobjects.h:
975
976 2007-10-24  Lars Knoll  <lars@trolltech.com>
977
978         Reviewed by Simon.
979
980         implement eventSender.keyDown().
981
982         * DumpRenderTree/qt/jsobjects.cpp:
983         (EventSender::keyDown):
984
985 2007-10-24  Lars Knoll  <lars@trolltech.com>
986
987         Reviewed by Simon.
988
989         some smaller fixes to the editing support in DRT. Makes another few tests pass.
990
991         * DumpRenderTree/qt/DumpRenderTree.cpp:
992         (WebCore::DumpRenderTree::DumpRenderTree):
993         (WebCore::DumpRenderTree::initJSObjects):
994         * DumpRenderTree/qt/jsobjects.cpp:
995         (TextInputController::doCommand):
996
997 2007-10-24  Lars Knoll  <lars@trolltech.com>
998
999         Reviewed by Simon.
1000
1001         first bit of implementation for the textinputcontroller.
1002
1003         * DumpRenderTree/qt/DumpRenderTree.cpp:
1004         (WebCore::DumpRenderTree::DumpRenderTree):
1005         * DumpRenderTree/qt/DumpRenderTree.h:
1006         * DumpRenderTree/qt/jsobjects.cpp:
1007         (TextInputController::TextInputController):
1008         (TextInputController::doCommand):
1009         * DumpRenderTree/qt/jsobjects.h:
1010
1011 2007-10-24  Lars Knoll  <lars@trolltech.com>
1012
1013         Reviewed by Simon.
1014
1015         make the man webpage believe it has focus, so the editing tests work correctly.
1016
1017         * DumpRenderTree/qt/DumpRenderTree.cpp:
1018         (WebCore::DumpRenderTree::DumpRenderTree):
1019
1020 2007-10-24  Lars Knoll  <lars@trolltech.com>
1021
1022         Reviewed by Simon.
1023
1024         implement layoutTestController.dumpEditingCallbacks() correctly.
1025
1026         * DumpRenderTree/qt/DumpRenderTree.cpp:
1027         (WebCore::DumpRenderTree::DumpRenderTree):
1028         * DumpRenderTree/qt/jsobjects.cpp:
1029         (LayoutTestController::reset):
1030         (LayoutTestController::dumpEditingCallbacks):
1031
1032 2007-10-24  Lars Knoll  <lars@trolltech.com>
1033
1034         Reviewed by Simon.
1035
1036         Implement support for testing editing.
1037
1038         * DumpRenderTree/qt/DumpRenderTree.cpp:
1039         (WebCore::DumpRenderTree::DumpRenderTree):
1040
1041 2007-10-23  Sam Weinig  <sam@webkit.org>
1042
1043         Check for null BSTR that can be passed to the UIDelegate methods
1044         from javascript null and undefined.  Fixes a failing test case on
1045         Windows (fast/dom/Window/alert-undefined.html)
1046
1047         Reviewed by Eric Seidel.
1048
1049         * DumpRenderTree/win/UIDelegate.cpp:
1050         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1051         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1052         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1053         (UIDelegate::webViewAddMessageToConsole):
1054
1055 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1056
1057         Reviewed by Darin.
1058         
1059         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1060
1061         * Scripts/build-testkjs:
1062
1063 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1064
1065         Reviewed by Darin.
1066
1067         - add wrapper that finds the right copy of testkjs
1068         
1069         * Scripts/sunspider-compare-results: Added.
1070
1071 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1072
1073         Reviewed by Sam.
1074
1075         - After talking with Steve I now see that the WebKit server must be
1076         running for DCOM to create the distributed objects, which makes sense
1077         and currently WebKit only allows one instance to be running at a time
1078         which avoids accidentally connecting to the wrong server
1079         - In light of this I have removed the code for the attach box and
1080         NotificationServer and known server names, since they are all extranious
1081         now.
1082
1083         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1084         names.
1085         (_tWinMain): Uses init instead of initUI.
1086         (droseraWndProc): No longer creats an attach dialog box.
1087         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1088         it's not manditory to call init before doing COM stuff.
1089         (Drosera::init): calls initUI and will call attach when the
1090         functionality exists. 
1091         (Drosera::initUI): Has changed very little.
1092         (Drosera::attach): Changed the signature to reflect that we no longer
1093         need the dictionary of known server names.
1094         * Drosera/win/Drosera.h: Removed notification classes and known server
1095         names.  Also renamed and moved some functions.
1096         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1097         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1098         headers to the resources folder. 
1099         * Drosera/win/resource.h: Removed the Attach box.
1100
1101 2007-10-22  Adam Roben  <aroben@apple.com>
1102
1103         Windows build fix
1104
1105         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1106
1107 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1108
1109         - Removed a leak that was fixed.
1110
1111         * Scripts/run-webkit-tests:
1112
1113 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1114
1115         Reviewed by Darin.
1116
1117         - Changed the Client so that the DebuggerDocument now own the
1118         ServerConnection.  This simplifies ownership and cleanup. 
1119
1120         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1121         ServerConnection.
1122         (DebuggerClient::initWithServerName):
1123         (DebuggerClient::didFinishLoadForFrame):
1124         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
1125         ServerConnection.
1126         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1127         until after we have a server which we are attached to.
1128         (Drosera::initUI):
1129         (Drosera::attach):
1130         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1131         out previously.
1132
1133 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1134
1135         Reviewed by Nikolas.
1136
1137         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1138
1139         * Scripts/run-javascriptcore-tests:
1140
1141 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1142
1143         Reviewed by Nikolas.
1144
1145         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1146
1147         * Scripts/build-drosera:
1148         * Scripts/build-dumprendertree:
1149         * Scripts/build-testkjs:
1150         * Scripts/build-webkit:
1151         * Scripts/run-javascriptcore-tests:
1152         * Scripts/run-sunspider:
1153         * Scripts/run-webkit-tests:
1154         * Scripts/webkitdirs.pm:
1155
1156 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1157
1158         Reviewed by Mark Rowe.
1159         
1160         Fix for local database support after r26879
1161         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1162
1163         * Scripts/build-webkit:
1164
1165 2007-10-22  Holger Freyther  <zecke@selfish.org>
1166
1167         Reviewed by Simon Hausmann <hausmann@kde.org>.
1168
1169         - Do not build testkjs as an application bundle. This is
1170         needed for run-javascriptcore-tests on OSX.
1171         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1172         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1173         as we do not have -rpath on OSX.
1174
1175         * DumpRenderTree/qt/DumpRenderTree.pro:
1176         * Scripts/run-webkit-tests:
1177
1178 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1179
1180         Reviewed by aroben.
1181
1182         Fix support for Signed-off-by detection in prepare-ChangeLog
1183         --git-commit. The Signed-off-by tag does not appear in the header
1184         but usually at the end.
1185
1186         * Scripts/prepare-ChangeLog:
1187
1188 2007-10-21  Mark Rowe  <mrowe@apple.com>
1189
1190         Reviewed by Eric.
1191
1192         Fix run-javascriptcore-tests for Gtk.
1193
1194         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1195
1196 2007-10-20  Eric Seidel  <eric@webkit.org>
1197
1198         Reviewed by aroben.
1199
1200         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1201
1202 2007-10-20  Eric Seidel  <eric@webkit.org>
1203
1204         Reviewed by darin.
1205         
1206         Add improved argument handling to run-sunspider, including
1207         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1208         Also re-factor code into subroutines
1209
1210         * Scripts/build-dumprendertree: removed bogus comments
1211         * Scripts/build-testkjs: Added.
1212         * Scripts/run-javascriptcore-tests: use build-testkjs
1213         * Scripts/run-sunspider: improved argument handling, abstraction
1214         * Scripts/run-webkit-tests: improved abstraction
1215
1216 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1217
1218         Not reviewed, Windows build fix.
1219
1220         * DumpRenderTree/win/EventSender.cpp:
1221         (keyDownCallback):
1222
1223 2007-10-20  Darin Adler  <darin@apple.com>
1224
1225         Reviewed by Tim Hatcher.
1226
1227         - http://bugs.webkit.org/show_bug.cgi?id=15544
1228           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
1229           not rely on Apple-specific key codes
1230
1231         * DumpRenderTree/mac/EventSendingController.mm:
1232         (-[EventSendingController keyDown:withModifiers:]):
1233         Added named key "rightArrow". Later we could have a whole table of these.
1234         Also tweaked modifiers code a little.
1235
1236         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
1237
1238 2007-10-19  Darin Adler  <darin@apple.com>
1239
1240         Reviewed by Eric.
1241
1242         - http://bugs.webkit.org/show_bug.cgi?id=15566
1243           possible fix for leak seen in DumpRenderTree
1244
1245         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
1246         Delete the item if it's not put on the queue, since the caller has
1247         no way of knowing that. Would be better to have the parameter type
1248         be auto_ptr to express the fact that we take ownership.
1249
1250         - unrelated change
1251
1252         * Drosera/mac/main.m: Add missing include.
1253
1254 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1255
1256         Reviewed by Adam.
1257
1258         - This change should be identical but for some reason was not working
1259         on my machine.
1260
1261         * Scripts/prepare-ChangeLog:
1262
1263 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1264
1265         Reviewed by Oliver and Tim.
1266
1267         - Made use of RetainPtr to avoid retain and release issues and moved the
1268         log function to DebuggerDocumentPlatform, which seems to be a more
1269         logical place for it to live.
1270         - Also moved knownServers from the ServerConnection to
1271         DebuggerApplication to match the Windows code and because it makes sense
1272         that a connection knows its own server but not all of them.
1273
1274         * Drosera/mac/DebuggerClient.h: Moved the log function to
1275           DebuggerDocumentPlatform.
1276         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
1277           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
1278           call for the server name up from the ServerConnection class.
1279         (-[DebuggerClient dealloc]):
1280         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
1281           for the server name up from the ServerConnection.
1282         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
1283         (DebuggerDocument::platformPause):
1284         (DebuggerDocument::platformResume):
1285         (DebuggerDocument::platformStepInto):
1286         (DebuggerDocument::platformEvaluateScript):
1287         (DebuggerDocument::getPlatformCurrentFunctionStack):
1288         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1289         (DebuggerDocument::platformValueForScopeVariableNamed):
1290         (DebuggerDocument::platformLog): Log directly from here. No need to call
1291           DebuggerClient.
1292         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
1293           way I see it, a ServerConnection should only know about its connection
1294           and the group of all possible servers should be kept by the
1295           application.
1296         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
1297           currentServerName, it makes sense that the connection should know that
1298           name.
1299         (-[ServerConnection currentServerName]):
1300
1301 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1302
1303         Reviewed by Adam.
1304
1305         - Integrated changes from mac drosera.  Recently I've encapsulated
1306         out the server connection object from the rest of Drosera because
1307         it is very platform dependent right now and RPC is not implemented on
1308         windows.  This functionality, of communicating with the WebKit server
1309         is the next area I will be focusing on in Windows.
1310
1311         - Other changes and cleanup were made to organize the code and add notes
1312         on which parts still need work.  Also some mac code is added and
1313         commented out, to act as pseudocode for the logic of those parts.
1314
1315         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
1316           pointer.
1317         * Drosera/config.h: Added whitespace.
1318         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
1319           these files got moved into Drosera.h/cpp
1320         * Drosera/win/DebuggerApplication.h: Removed.
1321         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
1322           happened here to better match the logic flow of the same code on the 
1323           mac side and to use the new ServerConnection class.
1324         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
1325         (DebuggerClient::initWithServerName): Initializer that will set up the
1326           class to use a ServerConnection object.  This was necessary so I could
1327           create a DebuggerClient without having to initilaize it at
1328           construction.
1329         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
1330           will be the UIDelegate and FrameLoadDelegate.
1331         (DebuggerClient::AddRef): For IUnknown.
1332         (DebuggerClient::Release): For IUnknown.
1333         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
1334           this still needs to set the global context of the server, but
1335           IWebFrame does not have an accessor for the global context yet. 
1336         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
1337           this is a pass through for the same function in the document.
1338         (DebuggerClient::didReceiveTitle): Unimplemented part of
1339           FrameLoadDelegate this would change the title of the window.
1340         (DebuggerClient::createWebViewWithRequest): Part of the
1341           FrameLoadDelegate.  This is about new windows via Window.open() and
1342           how their delegates are set.
1343         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
1344           UIDelegate.  Just a debug function for printing messages.
1345         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
1346           because the Client should be the UIDelegate and FrameLoadDelegate
1347           to match the delegates on mac.
1348         (DebuggerClient::webViewLoaded): Added accessor method.
1349         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
1350           forgotten to add this file before.  This is where the platform
1351           dependent versions of the Documents functions live. Most of these are
1352           unimplemented because some piece of functionality does not exist on
1353           Windows yet.
1354         (DebuggerDocument::platformPause):
1355         (DebuggerDocument::platformResume):
1356         (DebuggerDocument::platformStepInto):
1357         (DebuggerDocument::platformEvaluateScript):
1358         (DebuggerDocument::getPlatformCurrentFunctionStack):
1359         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1360         (DebuggerDocument::platformValueForScopeVariableNamed):
1361         (DebuggerDocument::platformLog):
1362         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
1363           responsibilities becaue they belong in the Client. Also I laid the
1364           groundwork for attaching Drosera to a WebKit process
1365         (attachWndProc): Now if a server is selected the Client becomes it's
1366           delegate.
1367         (Drosera::Drosera): Added the construction of the Client and dictionary
1368           of server names. 
1369         (Drosera::initUI): This is no longer the delegates, the Client is.
1370         (Drosera::webViewLoaded): Now asks the Client instead of holding local
1371           state. 
1372         (Drosera::applicationDidFinishLaunching): Placeholder for needed
1373           notification registration when it's possible to implement.
1374         (Drosera::serverLoaded): Ditto
1375         (Drosera::serverUnloaded): Ditto
1376         (Drosera::attach): Attach Drosera to the WebKit server.
1377         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
1378         (Drosera::getInst): 
1379         (Drosera::setInst):
1380         (Drosera::knownServers):
1381         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
1382           and added the ServerConnection.
1383         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
1384         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
1385           Most of the functions are completely unimlemented because they cannot
1386           connect with the WebKit server, because one does not exist on Windows
1387           yet.
1388         (ServerConnection::initWithServerName): 
1389         (ServerConnection::~ServerConnection):
1390         (ServerConnection::setGlobalContext):
1391         (ServerConnection::pause):
1392         (ServerConnection::resume):
1393         (ServerConnection::stepInto):
1394         (ServerConnection::switchToServerNamed):
1395         (ServerConnection::applicationTerminating):
1396         (ServerConnection::serverConnectionDidDie):
1397         (ServerConnection::currentFrame):
1398         * Drosera/win/ServerConnection.h: Added. Ditto.
1399         (ServerConnection::ServerConnection):
1400
1401 2007-10-19  Alice Liu  <alice.liu@apple.com>
1402
1403         Reviewed by Darin.
1404
1405         Fix for these broken layout tests on Windows:
1406         
1407         fast/forms/focus-selection-input.html
1408         fast/forms/focus-selection-textarea.html
1409         fast/forms/select-accesskey.html
1410         
1411         * DumpRenderTree/win/EventSender.cpp:
1412         (keyDownCallback):
1413         correct the VK code for alt key.
1414         
1415 2007-10-19  Eric Seidel  <eric@webkit.org>
1416
1417         Reviewed by Mark Rowe.
1418         
1419         Make the GtkLauncher code slightly more readable.
1420
1421         * GtkLauncher/main.cpp:
1422         (setupMainMenu): Added.
1423         (setupMainWindowUI): Added.
1424         (main):
1425
1426 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
1427
1428         Rubber stamped by Adam.
1429         
1430         - don't delay-load WebKit in DumpRenderTree.
1431
1432         * DumpRenderTree/win/DumpRenderTree.vcproj:
1433
1434 2007-10-18  Dan Bernstein  <mitz@apple.com>
1435
1436         Reviewed by Adam Roben.
1437
1438         - fix <rdar://problem/5313523>
1439         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
1440
1441         * DumpRenderTree/mac/DumpRenderTree.mm:
1442         (dump): Changed to use _responseMIMEType.
1443
1444 2007-10-17  Adam Roben  <aroben@apple.com>
1445
1446         Make it possible to have Windows-specific tests and results
1447
1448         When searching for tests to run and the Skipped file, we will only
1449         look in platform/win and the cross-platform directory. When looking
1450         for expected results, we will look in platform/win, then
1451         platform/mac-leopard, then platform/mac, then finally the
1452         cross-platform directory.
1453
1454         Reviewed by Sam.
1455
1456         * Scripts/run-webkit-tests:
1457         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
1458         searching in the cross-platform directory.
1459         (sub buildPlatformHierarchy): Removed some unneeded calls to
1460         dirname/basename.
1461
1462 2007-10-17  Adam Roben  <aroben@apple.com>
1463
1464         Add back the call to register WebKit that we had before WebKitInitializer existed
1465
1466         This is needed to ensure that the right WebKit is used when
1467         instantiating COM objects.
1468
1469         Reviewed by Oliver.
1470
1471         * DumpRenderTree/win/debug_internal.vsprops: Define
1472         DEBUG_WEBKIT_HAS_SUFFIX.
1473         * DumpRenderTree/win/DumpRenderTree.cpp:
1474         (initialize):
1475
1476 2007-10-17  Adam Roben  <aroben@apple.com>
1477
1478         Import File::Basename in webkitdirs since we use it
1479
1480         * Scripts/webkitdirs.pm:
1481
1482 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
1483
1484         - Updated the tiger leaks list to make the internal bots green.
1485
1486         * Scripts/run-webkit-tests:
1487
1488 2007-10-17  Adam Roben  <aroben@apple.com>
1489
1490         Build fix for VC++ Express
1491
1492         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
1493         and ole32.lib.
1494
1495 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1496
1497         Reviewed by Sam.
1498
1499         - Minor mac improvements based on observations I made while implementing the
1500         Windows code.
1501
1502         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
1503         then hand it to the Client who will retain it, it should just be the client who
1504         creates and owns the server.
1505         (-[DebuggerApplication attach:]):
1506         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
1507         * Drosera/mac/DebuggerClient.mm: Creates the server.
1508         (-[DebuggerClient initWithServerName:]):
1509         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
1510         can instead forward declare what it needs.
1511
1512 2007-10-16  Darin Adler  <darin@apple.com>
1513
1514         Reviewed by Geoff Garen.
1515
1516         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
1517         want to turn failing tests into platform-specific test results. Also did a
1518         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
1519         would take the type of results into account only some of the time.
1520
1521 2007-10-16  Adam Roben  <aroben@apple.com>
1522
1523         Add a new nightly launcher script for Windows
1524
1525         This new script is for versions of Safari that don't delay-load
1526         WebKit. I had to make FindSafari be able to print out the nightly
1527         launcher script on stdout because Windows shell scripts can't capture
1528         the output from a command into an environment variable.
1529
1530         Reviewed by Steve.
1531
1532         * FindSafari/FindSafari.cpp:
1533         (_tmain): Added /printSafariLauncher option.
1534         * Scripts/run-webkit-nightly.cmd: Added.
1535
1536 2007-10-16  Adam Roben  <aroben@apple.com>
1537
1538         Replace WebKitInitializer with FindSafari
1539
1540         We now rely on setting the PATH environment variable to tell Windows
1541         where to find WebKit and its dependencies (similar to
1542         DYLD_FRAMEWORK_PATH on Mac).
1543
1544         This change also make DumpRenderTree no longer delay-load WebKit.
1545
1546         Reviewed by Sam.
1547
1548         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
1549         FindSafari.
1550         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
1551         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
1552         WebKitInitializer, don't delay-load WebKit.
1553         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
1554         * Scripts/run-webkit-tests: Ditto.
1555         * Scripts/webkitdirs.pm:
1556         (sub setPathForRunningWebKitApp): Added.
1557         * WebKitInitializer/WebKitInitializer.cpp: Removed.
1558         * WebKitInitializer/WebKitInitializer.h: Removed.
1559         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
1560         * WebKitInitializer/debug.vsprops: Removed.
1561         * WebKitInitializer/debug_internal.vsprops: Removed.
1562         * WebKitInitializer/release.vsprops: Removed.
1563
1564 2007-10-16  Adam Roben  <aroben@apple.com>
1565
1566         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
1567
1568         http://bugs.webkit.org/show_bug.cgi?id=15532
1569
1570         FindSafari simply prints the location of an installed Safari.exe on
1571         stdout.
1572
1573         Reviewed by Darin.
1574
1575         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
1576         (getStringValue):
1577         (getWebViewCLSID):
1578         (getInstalledWebKitDirectory):
1579         (_tmain):
1580         * FindSafari/FindSafari.vcproj: Added.
1581         * Scripts/webkitdirs.pm:
1582         (sub installedSafariPath): Added. Calls FindSafari on Windows.
1583
1584 2007-10-16  Adam Roben  <aroben@apple.com>
1585
1586         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
1587
1588         Reviewed by Kevin McCullough.
1589
1590         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
1591         when referring to WebKit.dll.
1592         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
1593         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
1594         * DumpRenderTree/win/release.vsprops: Ditto.
1595         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
1596         never have a _debug suffix on WebKit.dll.
1597         * WebKitInitializer/WebKitInitializer.cpp:
1598         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
1599         specified.
1600         * WebKitInitializer/debug_internal.vsprops: Added
1601         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
1602
1603 2007-10-16  Darin Adler  <darin@apple.com>
1604
1605         Reviewed by Adele.
1606
1607         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1608         Remove now-unneeded control/alt key hack; the tests have been updated.
1609
1610 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1611
1612         - Updated leaks list because our internal bot upgraded it's version of leopard and 
1613         one of the leaks was fixed between that revision and the bot's previous version of
1614         leopard.
1615
1616         * Scripts/run-webkit-tests:
1617
1618 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
1619
1620         Reviewed by Tim.
1621
1622         - I encapsulated out the server connecton functionality because it is a specific part
1623         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
1624         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
1625         Windows.  So the majority of this patch is moving preexisting functionality.
1626
1627         - Also I removed the prefix header and changed to use config.h because it is more
1628         standard on how we use config.h in windows and it didn't make much sense to keep
1629         the prefix header and the config.h
1630
1631         * Drosera/DebuggerDocument.cpp:
1632         (DebuggerDocument::DebuggerDocument):
1633         * Drosera/DebuggerDocument.h:
1634         * Drosera/config.h:
1635         * Drosera/mac/DebuggerApplication.mm:
1636         (-[DebuggerApplication attach:]):
1637         * Drosera/mac/DebuggerClient.h:
1638         * Drosera/mac/DebuggerClient.mm:
1639         (-[DebuggerClient initWithServerConnection:]):
1640         (-[DebuggerClient dealloc]):
1641         (-[DebuggerClient windowDidLoad]):
1642         (-[DebuggerClient windowWillClose:]):
1643         (-[DebuggerClient webView:didFinishLoadForFrame:]):
1644         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
1645         * Drosera/mac/DebuggerDocumentPlatform.mm:
1646         (DebuggerDocument::platformPause):
1647         (DebuggerDocument::platformResume):
1648         (DebuggerDocument::platformStepInto):
1649         (DebuggerDocument::platformEvaluateScript):
1650         (DebuggerDocument::getPlatformCurrentFunctionStack):
1651         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1652         (DebuggerDocument::platformValueForScopeVariableNamed):
1653         (DebuggerDocument::platformLog):
1654         * Drosera/mac/Drosera.pch: Removed.
1655         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1656         * Drosera/mac/ServerConnection.h: Added.
1657         * Drosera/mac/ServerConnection.mm: Added.
1658         (-[ServerConnection initWithServerName:]):
1659         (-[ServerConnection dealloc]):
1660         (-[ServerConnection setGlobalContext:]):
1661         (-[ServerConnection pause]):
1662         (-[ServerConnection resume]):
1663         (-[ServerConnection stepInto]):
1664         (-[ServerConnection switchToServerNamed:]):
1665         (-[ServerConnection applicationTerminating:]):
1666         (-[ServerConnection serverConnectionDidDie:]):
1667         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1668         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1669         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1670         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1671         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1672         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1673         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1674         (-[ServerConnection currentFrame]):
1675         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1676         (-[ServerConnection knownServers]):
1677
1678 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1679
1680         Reviewed by Eric.
1681
1682         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1683           Script to automatically search nightly builds for regressions (bisect-builds)
1684
1685         * Scripts/bisect-builds: Added.
1686
1687 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1688
1689         Reviewed by Darin.
1690
1691         - New JavaScript benchmark
1692         http://bugs.webkit.org/show_bug.cgi?id=15515
1693
1694         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1695         current development or release build of JavaScriptCore.
1696
1697 2007-10-15  Mark Rowe  <mrowe@apple.com>
1698
1699         Reviewed by Sam.
1700
1701         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1702
1703         * Scripts/webkitdirs.pm:
1704         - Change checkArgv to remove the options from @ARGV to prevent
1705         them from interfering with further option processing.
1706         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1707         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1708         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1709         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1710
1711 2007-10-15  Darin Adler  <darin@apple.com>
1712
1713         Reviewed by Sam.
1714
1715         - added logging of window.prompt and window.confirm
1716
1717         * DumpRenderTree/mac/UIDelegate.mm:
1718         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1719         Implement the recommended delegate rather than the deprecated one.
1720         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1721         Added.
1722         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1723         Added.
1724
1725         * DumpRenderTree/win/UIDelegate.h:
1726         * DumpRenderTree/win/UIDelegate.cpp:
1727         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1728         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1729         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
1730         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
1731
1732 2007-10-15  Alice Liu  <alice.liu@apple.com>
1733
1734         Reviewed by Sam Weinig.
1735
1736         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
1737
1738         * DumpRenderTree/win/DumpRenderTree.cpp:
1739         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
1740         (main): allocate the global policy delegate for DRT's custom use
1741         * DumpRenderTree/win/DumpRenderTree.vcproj:
1742         Adding files to project
1743         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
1744         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1745         (LayoutTestController::setCustomPolicyDelegate):
1746         set the webview's policy delegate to DRT's custom one if the test requests it.
1747         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
1748         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
1749         (PolicyDelegate::PolicyDelegate):
1750         (PolicyDelegate::QueryInterface):
1751         (PolicyDelegate::AddRef):
1752         (PolicyDelegate::Release):
1753         (PolicyDelegate::decidePolicyForNavigationAction):
1754         * DumpRenderTree/win/PolicyDelegate.h: Added.
1755         (PolicyDelegate::decidePolicyForNewWindowAction):
1756         (PolicyDelegate::decidePolicyForMIMEType):
1757         (PolicyDelegate::unableToImplementPolicyWithError):
1758
1759 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1760
1761         Reviewed by Mark.
1762
1763         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
1764         when querying for QMAKE_MKSPECS.
1765
1766 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
1767
1768         Reviewed by Adam Roben.
1769         
1770         Fix run-webkit-tests is too greedy calculating platform hierarchy
1771         http://bugs.webkit.org/show_bug.cgi?id=15465
1772         
1773         Fix run-webkit-tests being too greedy in trying to split the platform name up
1774         causing it to try and find tests in every directory above the first "-" in the
1775         path to the LayoutTests
1776
1777         * Scripts/run-webkit-tests:
1778
1779 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
1780
1781         Reviewed by Darin.
1782
1783         http://bugs.webkit.org/show_bug.cgi?id=15006
1784         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
1785         to reduce code duplication.
1786
1787         * Scripts/build-webkit:
1788         * Scripts/webkitdirs.pm:
1789         buildQMakeProject() renamed to buildQMakeQtProject().
1790         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
1791         unused $colorize has been removed.
1792
1793 === Start merge of feature-branch 2007-10-12 ===
1794
1795 2007-10-08  Eric Seidel  <eric@webkit.org>
1796
1797         Reviewed by Mark Rowe.
1798
1799         * Scripts/build-webkit: add --help, remove unused --color
1800
1801 2007-10-07  Eric Seidel  <eric@webkit.org>
1802
1803         Reviewed by darin.
1804
1805         * Drosera/mac/DebuggerDocumentPlatform.mm:
1806         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
1807
1808 2007-10-03  Rob Buis  <buis@kde.org>
1809
1810         Reviewed by Olliej.
1811
1812         Adapt to changed location of Ahem font.
1813
1814         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1815
1816 2007-10-02  Eric Seidel  <eric@webkit.org>
1817
1818         Reviewed by Adam Roben.
1819         
1820         Make pixel tests more useful!
1821         Finally fix the image diff 0.00% mystery problem
1822         Highlight any image differences in the image diff.
1823         Add a link from image diffs back to original test file.
1824
1825         * DumpRenderTree/mac/ImageDiff.m:
1826         (compareImages): highlight any differences
1827         (computePercentageDifferent): round to two decimal places
1828         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
1829
1830 2007-10-02  Eric Seidel  <eric@webkit.org>
1831
1832         Reviewed by Alexey Proskuryakov.
1833
1834         * Scripts/run-webkit-tests: print the % image difference on main results page
1835
1836 2007-10-02  Mark Rowe  <mrowe@apple.com>
1837
1838         Reviewed by Oliver.
1839
1840         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1841
1842         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1843         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1844
1845 2007-10-01  Mark Rowe  <mrowe@apple.com>
1846
1847         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1848
1849 2007-09-25  Eric Seidel  <eric@webkit.org>
1850
1851         Reviewed by Mark Rowe.
1852         
1853         DerivedSources.make was finding "ENABLE_SVG" in the string
1854         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
1855         quite correctly.
1856
1857         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
1858
1859 2007-09-25  Mark Rowe  <mrowe@apple.com>
1860
1861         Rubber-stamped by Eric.
1862
1863         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1864         This makes it possible to automate nightly builds for the feature-branch.
1865
1866 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
1867
1868         Rubber stamped by Mark.
1869
1870         Enable svg experimental features as default here in feature-branch.
1871
1872         * Scripts/build-webkit:
1873
1874 2007-06-29  Antti Koivisto  <antti@apple.com>
1875
1876         Reviewed by Weinig.
1877         
1878         Add VIDEO flag for timed media features
1879
1880         * Scripts/build-webkit
1881         
1882 === End merge of feature-branch 2007-10-12 ===
1883
1884 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1885
1886         Reviewed by Darin.
1887
1888         - Updated rational for the leaks list to be more clear.
1889
1890         * Scripts/run-webkit-tests:
1891
1892 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1893
1894         Rubber Stamp by Sam.
1895
1896         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
1897         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
1898
1899         * Scripts/run-webkit-tests:
1900
1901 2007-10-10  Simon Hausmann  <hausmann@kde.org>
1902
1903         Reviewed by Lars.
1904
1905         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
1906         includes are needed for INT_MAX, std::auto_ptr and the like.
1907
1908         * DumpRenderTree/qt/main.cpp:
1909
1910 2007-10-09  Lars Knoll  <lars@trolltech.com>
1911
1912         Reviewed by Simon.
1913
1914         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
1915
1916         * DumpRenderTree/qt/jsobjects.cpp:
1917         (LayoutTestController::encodeHostName):
1918         (LayoutTestController::decodeHostName):
1919         * DumpRenderTree/qt/jsobjects.h:
1920
1921 2007-10-09  Lars Knoll  <lars@trolltech.com>
1922
1923         Reviewed by Simon.
1924
1925         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
1926
1927         * DumpRenderTree/qt/DumpRenderTree.cpp:
1928         (WebCore::WebPage::createFrame):
1929         (WebCore::DumpRenderTree::DumpRenderTree):
1930         (WebCore::DumpRenderTree::titleChanged):
1931         * DumpRenderTree/qt/DumpRenderTree.h:
1932         * DumpRenderTree/qt/jsobjects.cpp:
1933         (LayoutTestController::reset):
1934         * DumpRenderTree/qt/jsobjects.h:
1935
1936 2007-10-09  Lars Knoll  <lars@trolltech.com>
1937
1938         Reviewed by Simon.
1939
1940         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
1941
1942         * DumpRenderTree/qt/DumpRenderTree.h:
1943         * DumpRenderTree/qt/jsobjects.cpp:
1944         (LayoutTestController::clearBackForwardList):
1945         * DumpRenderTree/qt/jsobjects.h:
1946
1947 2007-10-09  Lars Knoll  <lars@trolltech.com>
1948
1949         Reviewed by Simon.
1950
1951         make --git-reviewer work again.
1952
1953         * Scripts/prepare-ChangeLog:
1954
1955 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
1956
1957         Rubber stamped by Eric.
1958
1959         Connect to the "hovering-over-link" signal emitted by WebKitPage and
1960         show the current link inside the statusbar.
1961         This shows how to make use of this signal and allows to easily test
1962         http://bugs.webkit.org/show_bug.cgi?id=15299.
1963
1964         * GtkLauncher/main.cpp:
1965         (hoveringOverLink):
1966         (main):
1967
1968 2007-10-05  Lars Knoll  <lars@trolltech.com>
1969
1970         add proper error messages to the FrameLoaderClient.
1971         Implement ChromeClientQt::closeWindowSoon and
1972         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
1973         Some fixes in DRT to make it work correctly with multiple windows.
1974
1975         Reviewed by Maciej.
1976
1977         * DumpRenderTree/qt/DumpRenderTree.cpp:
1978         (WebCore::DumpRenderTree::DumpRenderTree):
1979         (WebCore::DumpRenderTree::createWindow):
1980         (WebCore::DumpRenderTree::windowCount):
1981         * DumpRenderTree/qt/DumpRenderTree.h:
1982         * DumpRenderTree/qt/jsobjects.cpp:
1983         (LayoutTestController::maybeDump):
1984         (LayoutTestController::windowCount):
1985         * DumpRenderTree/qt/jsobjects.h:
1986
1987 2007-10-05  Lars Knoll  <lars@trolltech.com>
1988
1989         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
1990         Add support for layoutTextController.setCanOpenWindows() to DRT
1991         fixing another 2 test cases in fast/dom/Window.
1992
1993         Reviewed by Maciej.
1994
1995         * DumpRenderTree/qt/DumpRenderTree.cpp:
1996         (WebCore::WebPage::WebPage):
1997         (WebCore::WebPage::createWindow):
1998         (WebCore::DumpRenderTree::resetJSObjects):
1999         (WebCore::DumpRenderTree::createWindow):
2000         * DumpRenderTree/qt/DumpRenderTree.h:
2001         * DumpRenderTree/qt/DumpRenderTree.pro:
2002         * DumpRenderTree/qt/jsobjects.cpp:
2003         (LayoutTestController::LayoutTestController):
2004         (LayoutTestController::reset):
2005         * DumpRenderTree/qt/jsobjects.h:
2006         * DumpRenderTree/qt/main.cpp:
2007         * DumpRenderTree/qt/testplugin.cpp: Added.
2008         * DumpRenderTree/qt/testplugin.h: Added.
2009
2010 2007-10-04  Sam Weinig  <sam@webkit.org>
2011
2012         Rubber stamped by Adam.
2013
2014         Remove empty directories.
2015
2016         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2017         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2018
2019 2007-10-03  Darin Adler  <darin@apple.com>
2020
2021         Reviewed by Adam.
2022
2023         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2024         we find the internal libraries in the libraries directory. This
2025         is helpful for Safari team engineers at Apple.
2026
2027 2007-10-03  Adam Roben  <aroben@apple.com>
2028
2029         Update the location of AHEM___.TTF after r25968
2030
2031         Reviewed by Sam.
2032
2033         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2034
2035 2007-10-03  Alp Toker  <alp@atoker.com>
2036
2037         Reviewed by Adam.
2038
2039         http://bugs.webkit.org/show_bug.cgi?id=14726
2040         [gtk] API design. Mapping the WebView delegates to signals.
2041
2042         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2043
2044         * GtkLauncher/main.cpp:
2045         (goToURLBarText):
2046         (titleChanged):
2047         (progressChanged):
2048         (menuMainBackCallback):
2049         (menuMainForwardCallback):
2050         (main):
2051
2052 2007-10-03  Lars Knoll  <lars@trolltech.com>
2053
2054         Reviewed by Rob.
2055
2056         This fixes --strict mode in run-webkit-tests again after
2057         the platform dependent test results have been moved.
2058
2059         * Scripts/run-webkit-tests:
2060
2061 2007-10-03  Lars Knoll  <lars@trolltech.com>
2062
2063         Reviewed by bdash.
2064
2065         remove the hack in run-webkit-tests that forced text only test
2066         to be taken from the platform independent dir. It was only left
2067         there from early days.
2068         
2069         Remove platform dependent results for tests that are text only nowadays,
2070         and add one platform dependent result for a text only test that requires it.
2071
2072         * Scripts/run-webkit-tests:
2073
2074 2007-10-03  Lars Knoll  <lars@trolltech.com>
2075
2076         Reviewed by olliej.
2077
2078         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2079
2080         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2081         (WebCore::WebFrame::WebFrame):
2082         (WebCore::WebPage::WebPage):
2083         (WebCore::WebPage::createFrame):
2084         (WebCore::WebPage::javaScriptAlert):
2085         (WebCore::WebPage::javaScriptConsoleMessage):
2086         (WebCore::DumpRenderTree::DumpRenderTree):
2087         (WebCore::DumpRenderTree::~DumpRenderTree):
2088         (WebCore::DumpRenderTree::open):
2089         (WebCore::DumpRenderTree::readStdin):
2090         (WebCore::DumpRenderTree::resetJSObjects):
2091         (WebCore::DumpRenderTree::initJSObjects):
2092         (WebCore::DumpRenderTree::dumpFramesAsText):
2093         (WebCore::DumpRenderTree::dump):
2094         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2095         (WebCore::DumpRenderTree::layoutTestController):
2096         (WebCore::DumpRenderTree::eventSender):
2097         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2098         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2099         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2100         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2101         (HackWebFrame::mousePressEvent):
2102         (HackWebFrame::mouseReleaseEvent):
2103         (HackWebFrame::mouseMoveEvent):
2104         (HackWebFrame::HackWebFrame):
2105         (HackWebFrame::~HackWebFrame):
2106         (LayoutTestController::LayoutTestController):
2107         (LayoutTestController::reset):
2108         (LayoutTestController::maybeDump):
2109         (LayoutTestController::waitUntilDone):
2110         (LayoutTestController::notifyDone):
2111         (LayoutTestController::dumpEditingCallbacks):
2112         (LayoutTestController::queueReload):
2113         (LayoutTestController::provisionalLoad):
2114         (LayoutTestController::timerEvent):
2115         (EventSender::EventSender):
2116         (EventSender::mouseDown):
2117         (EventSender::mouseUp):
2118         (EventSender::mouseMoveTo):
2119         (EventSender::leapForward):
2120         (EventSender::keyDown):
2121         (EventSender::frameUnderMouse):
2122         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2123         (LayoutTestController::isLoading):
2124         (LayoutTestController::setLoading):
2125         (LayoutTestController::shouldDumpAsText):
2126         (LayoutTestController::shouldDumpChildrenAsText):
2127         (LayoutTestController::shouldWaitUntilDone):
2128         (LayoutTestController::dumpAsText):
2129         (LayoutTestController::dumpChildFramesAsText):
2130         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2131         (messageHandler):
2132         (crashHandler):
2133         (main):
2134         * Scripts/run-webkit-tests:
2135
2136 2007-10-03  Mark Rowe  <mrowe@apple.com>
2137
2138         Reviewed by Alp Toker.
2139
2140         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2141         should take precedence over QTDIR when determining which port we are working with.
2142
2143         * Scripts/webkitdirs.pm: 
2144
2145 2007-10-02  Adam Roben  <aroben@apple.com>
2146
2147         Add keychain to the list of default packages to install
2148
2149         Rubberstamped by Sam.
2150
2151         * CygwinDownloader/cygwin-downloader.py:
2152         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2153
2154 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2155
2156         Reviewed by Adam.
2157
2158         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2159         Also makes WebCore regression test case logic work when using git.
2160
2161         * Scripts/prepare-ChangeLog:
2162         (reviewerAndDescriptionForGitCommit): Added.
2163
2164 2007-10-02  Lars Knoll  <lars@trolltech.com>
2165
2166         Reviewed by bdash.
2167
2168         Add API to retrieve the frame name from QWebFrame.
2169         Implement support for DRT::dumpChildrenAsText.
2170
2171         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2172         (WebCore::DumpRenderTree::dumpFramesAsText):
2173         (WebCore::DumpRenderTree::dump):
2174         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2175         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2176         (LayoutTestController::LayoutTestController):
2177         (LayoutTestController::reset):
2178         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2179
2180 2007-10-02  Lars Knoll  <lars@trolltech.com>
2181
2182         Reviewed by bdash.
2183
2184         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2185
2186         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2187         (WebCore::DumpRenderTree::readStdin):
2188
2189 2007-10-02  Mark Rowe  <mrowe@apple.com>
2190
2191         Reviewed by Oliver.
2192
2193         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2194
2195         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2196         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2197
2198 2007-10-02  Mark Rowe  <mrowe@apple.com>
2199
2200         Rubber-stamped by Maciej.
2201
2202         Configuration changes from build.webkit.org.  The major change is refactoring to work
2203         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2204         last few weeks.
2205
2206         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2207         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2208         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2209         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2210         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2211         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2212         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2213         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2214
2215 2007-10-02  Lars Knoll  <lars@trolltech.com>
2216
2217         Reviewed by Maciej.
2218
2219         Add support for eventSender.mouseMove to DRT.
2220         Fixes fast/css/hover-affects-child.html
2221
2222         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2223         (EventSender::mouseMoveTo):
2224
2225 2007-10-01  Mark Rowe  <mrowe@apple.com>
2226
2227         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2228
2229 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
2230
2231         Reviewed by Hyatt.
2232
2233         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
2234
2235         * Scripts/svn-apply:
2236         (gitdiff2svndiff): Ignore lines beginning with "new file".
2237         * Scripts/svn-unapply:
2238         (gitdiff2svndiff): Ditto.
2239
2240 2007-09-30  George Staikos  <staikos@kde.org>
2241
2242         Qt build fix (Mac OS X specific)
2243
2244         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2245
2246 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2247
2248         Reviewed by Mark.
2249
2250         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
2251         Remove Bakefiles from svn.
2252
2253         * GtkLauncher/Bakefiles.bkgen: Removed.
2254         * GtkLauncher/ENV: Removed.
2255         * GtkLauncher/gdklauncher.bkl: Removed.
2256         * GtkLauncher/mk: Removed.
2257         * Scripts/regenerate-makefiles: Removed.
2258
2259 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
2260
2261         Reviewed by John.
2262
2263         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
2264
2265         * Scripts/run-webkit-tests:
2266
2267 2007-09-26  Adam Roben  <aroben@apple.com>
2268
2269         Make not finding an installed WebKit non-fatal
2270
2271         What really matters is that we are able to load WebKit and its
2272         dependencies, not whether we think we've found an installed WebKit.
2273
2274         Reviewed by Sam.
2275
2276         * WebKitInitializer/WebKitInitializer.cpp:
2277         (getWebViewCLSID): Use new LOG_WARNING macro.
2278         (getInstalledWebKitDirectory): Ditto.
2279         (initializeWebKit): Don't die if we didn't find an installed WebKit,
2280         and use new macros.
2281         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
2282
2283 2007-09-26  Adam Roben  <aroben@apple.com>
2284
2285         Committed this file before saving it
2286
2287         * WebKitInitializer/debug_internal.vsprops:
2288
2289 2007-09-26  Adam Roben  <aroben@apple.com>
2290
2291         Load WebKit and its dependencies manually so they come from DllDirectory
2292
2293         I had to change WebKitInitializer to use malloc/free instead of
2294         new/delete to avoid pulling in WebKit (and its dependencies) early
2295         through use of fastMalloc.
2296
2297         Reviewed by Oliver.
2298
2299         * WebKitInitializer/WebKitInitializer.cpp:
2300         (getStringValue): Changed to use malloc/free.
2301         (getInstalledWebKitDirectory): Ditto.
2302         (initializeWebKit): Call SetDllDirectory first, then load all of
2303         WebKit's dependencies manually, finally followed by WebKit itself.
2304         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
2305         configuration to match our other projects.
2306         * WebKitInitializer/debug_internal.vsprops: Added.
2307
2308 2007-09-25  Adam Roben  <aroben@apple.com>
2309
2310         Actually define DEBUG/NDEBUG so that we load WebKit correctly
2311
2312         Rubberstamped by Sam.
2313
2314         * WebKitInitializer/WebKitInitializer.vcproj:
2315
2316 2007-09-25  Adam Roben  <aroben@apple.com>
2317
2318         Make DumpRenderTree delay-load its dependencies
2319
2320         This lets WebKitInitializer re-route the dependencies to be loaded out
2321         of the Safari installation directory.
2322
2323         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
2324         same thing), since we can't import the kCFAllocatorDefault symbol when
2325         delay-loading CoreFoundation.dll.
2326
2327         Rubberstamped by Sam.
2328
2329         * DumpRenderTree/win/DumpRenderTree.cpp:
2330         (runTest):
2331         (javaScriptThreads):
2332         * DumpRenderTree/win/DumpRenderTree.vcproj:
2333         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2334         (LayoutTestController::setWaitToDump):
2335
2336 2007-09-25  Adam Roben  <aroben@apple.com>
2337
2338         Pull ole32.lib into WebKitInitializer
2339
2340         Rubberstamped by Sam.
2341
2342         * WebKitInitializer/WebKitInitializer.vcproj:
2343
2344 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2345
2346         Reviewed by Adam.
2347
2348         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
2349           LGPL'ed files contain incorrect FSF address
2350
2351         * Drosera/config.h:
2352
2353 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2354
2355         Reviewed by Adam.
2356
2357         Make svn-apply and svn-unapply work with git-diff formatted patches.
2358
2359         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
2360         (gitdiff2svndiff): Added.
2361         * Scripts/svn-unapply: Ditto.
2362         (gitdiff2svndiff): Added.
2363
2364 2007-09-25  Adam Roben  <aroben@apple.com>
2365
2366         Pull advapi32.lib into WebKitInitializer
2367
2368         This is needed to get the registry functions we use.
2369
2370         Rubberstamped by Sam.
2371
2372         * WebKitInitializer/WebKitInitializer.vcproj:
2373
2374 2007-09-25  Adam Roben  <aroben@apple.com>
2375
2376         Add python and rsync to cygwin-downloader
2377
2378         Our build slaves need this, and it can't hurt for everyone else to
2379         have it, too.
2380
2381         Reviewed by Sam.
2382
2383         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
2384         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2385
2386 2007-09-25  Adam Roben  <aroben@apple.com>
2387
2388         Add WebKitInitializer and use it in DumpRenderTree
2389
2390         WebKitInitializer is a static library that has one function,
2391         initializeWebKit(). This registers WebKit and sets up the DLL search
2392         path so that WebKit's dependencies that are installed with Safari can
2393         be found.
2394
2395         Reviewed by Sam.
2396
2397         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
2398         DumpRenderTree depend on it.
2399         * DumpRenderTree/win/DumpRenderTree.cpp:
2400         (initialize): Call initializeWebKit.
2401         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
2402         WebKitInitializer.lib.
2403         * WebKitInitializer/WebKitInitializer.cpp: Added.
2404         (getStringValue):
2405         (getWebViewCLSID):
2406         (getInstalledWebKitDirectory):
2407         (initializeWebKit):
2408         * WebKitInitializer/WebKitInitializer.h: Added.
2409         * WebKitInitializer/WebKitInitializer.vcproj: Added.
2410         * WebKitInitializer/debug.vsprops: Added.
2411         * WebKitInitializer/release.vsprops: Added.
2412
2413 2007-09-25  Adam Roben  <aroben@apple.com>
2414
2415         Make run-webkit-tests respect set-webkit-configuration
2416
2417         Reviewed by Sam.
2418
2419         * Scripts/run-webkit-tests: Initialize $configuration to whatever
2420         set-webkit-configuration was last set to.
2421
2422 2007-09-25  Mark Rowe  <mrowe@apple.com>
2423
2424         Rubber-stamped by Eric.
2425
2426         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2427         This makes it possible to automate nightly builds for the feature-branch.
2428
2429 2007-09-25  Adam Roben  <aroben@apple.com>
2430
2431         A couple of fixes/enhancements to update-webkit-*-libs
2432
2433         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
2434         to tell update-webkit-support-libraries where it should find the
2435         WebKitSupportLibrary.zip file you downloaded.
2436
2437         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
2438         Windows-style path.
2439
2440         Reviewed by Sam.
2441
2442         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
2443         to $auxiliaryLibsURL and removed an irrelevant comment.
2444         * Scripts/update-webkit-support-libs:
2445
2446 2007-09-25  Adam Treat  <treat@kde.org>
2447
2448         Reviewed by Simon and Lars.
2449
2450         Refactors and cleans up Qt DRT member variable names, member variable
2451         initialization, style fixes and general code cleanup.
2452
2453         Adds queueReload slot to LayoutTestController that some tests require.
2454
2455         Subclasses QWebFrame to make sure that all frames have an associated
2456         LayoutTestController JS window object.
2457
2458         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
2459         aren't dumped twice.
2460
2461         EOF fixes.
2462
2463         Together, this patch fixes some 20+ layout tests in QtWebKit.
2464
2465         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2466         (WebCore::WebFrame::WebFrame):
2467         (WebCore::WebPage::WebPage):
2468         (WebCore::WebPage::createFrame):
2469         (WebCore::DumpRenderTree::DumpRenderTree):
2470         (WebCore::DumpRenderTree::open):
2471         (WebCore::DumpRenderTree::readStdin):
2472         (WebCore::DumpRenderTree::initJSObjects):
2473         (WebCore::DumpRenderTree::dump):
2474         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2475         (WebCore::DumpRenderTree::layoutTestController):
2476         (WebCore::DumpRenderTree::eventSender):
2477         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2478         (LayoutTestController::LayoutTestController):
2479         (LayoutTestController::reset):
2480         (LayoutTestController::maybeDump):
2481         (LayoutTestController::waitUntilDone):
2482         (LayoutTestController::notifyDone):
2483         (LayoutTestController::queueReload):
2484         (LayoutTestController::provisionalLoad):
2485         (EventSender::EventSender):
2486         (EventSender::mouseDown):
2487         (EventSender::mouseUp):
2488         (EventSender::mouseMoveTo):
2489         (EventSender::frameUnderMouse):
2490         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2491         (LayoutTestController::isLoading):
2492         (LayoutTestController::setLoading):
2493         (LayoutTestController::dumpAsText):
2494         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2495         (main):
2496
2497 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2498
2499
2500         - Reverted an accidentally checked in file.
2501
2502         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
2503
2504 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2505         Reviewed by Sam.
2506
2507         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
2508
2509         * DumpRenderTree/win/DumpRenderTree.vcproj:
2510         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2511
2512 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2513
2514         Rubber stamped by Adam.
2515
2516         * GdkLauncher: Removed.
2517         * GdkLauncher/Bakefiles.bkgen: Removed.
2518         * GdkLauncher/ENV: Removed.
2519         * GdkLauncher/GdkLauncher.pro: Removed.
2520         * GdkLauncher/gdklauncher.bkl: Removed.
2521         * GdkLauncher/main.cpp: Removed.
2522         * GdkLauncher/mk: Removed.
2523         * GdkLauncher/simple.svg: Removed.
2524         * GdkLauncher/text.html: Removed.
2525         * GtkLauncher: Added.
2526         * GtkLauncher/GdkLauncher.pro: Removed.
2527         * GtkLauncher/GtkLauncher.pro: Added.
2528         * GtkLauncher/main.cpp:
2529         (updateWindowTitle):
2530         (main):
2531         * Scripts/build-webkit:
2532         * Scripts/regenerate-makefiles:
2533         * Scripts/run-javascriptcore-tests:
2534         * Scripts/run-launcher:
2535         * Scripts/run-webkit-tests:
2536         * Scripts/webkitdirs.pm:
2537
2538 2007-09-21  Timothy Hatcher  <timothy@apple.com>
2539
2540         Reviewed by Darin.
2541
2542         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
2543
2544         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
2545         This is tested by plugins/root-object-premature-delete-crash.html.
2546
2547         * DumpRenderTree/mac/ObjCController.m:
2548         (-[ObjCController accessStoredWebScriptObject]):
2549
2550 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
2551
2552         Reviewed by Oliver.
2553
2554         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
2555
2556         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2557         (FrameLoadDelegate::FrameLoadDelegate):
2558
2559 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
2560
2561         Reviewed by Adam.
2562
2563         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
2564         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
2565
2566         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
2567         Now isQt() and isGdk() use global variables that are only set once.
2568
2569         An array of all the parameters is now given to build-dumprender which includes
2570         the platform on linux.
2571
2572         * Scripts/build-dumprendertree:
2573         * Scripts/run-webkit-tests:
2574         * Scripts/webkitdirs.pm:
2575
2576 2007-09-19  Adam Roben  <aroben@apple.com>
2577
2578         Rubberstamped by Hyatt.
2579
2580         * Spinneret: Removed.
2581
2582 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
2583
2584         Reviewed by David Kilzer.
2585
2586         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
2587
2588 2007-09-18  Sam Weinig  <sam@webkit.org>
2589
2590         Add JSRetainPtr.h #include to fix some builds.
2591
2592         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2593
2594 2007-09-18  Mike Hommey  <glandium@debian.org>
2595
2596         Reviewed by Adam.
2597
2598         * Scripts/prepare-ChangeLog:
2599         - Properly parse GECOS field.
2600         - Use git configuration for user name and email when appropriate.
2601
2602 2007-09-17  Sam Weinig  <sam@webkit.org>
2603
2604         Build fix.
2605
2606         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2607
2608 2007-09-17  Sam Weinig  <sam@webkit.org>
2609
2610         Reviewed by Adam Roben.
2611
2612         Share more code between mac and windows DRT.
2613             - GCController is now shared.
2614             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
2615
2616         * DumpRenderTree/GCController.cpp:
2617         * DumpRenderTree/win/DumpRenderTree.cpp:
2618         * DumpRenderTree/win/DumpRenderTree.vcproj:
2619         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
2620         (FrameLoadDelegate::FrameLoadDelegate):
2621         (FrameLoadDelegate::~FrameLoadDelegate):
2622         (FrameLoadDelegate::windowScriptObjectAvailable):
2623         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
2624         * DumpRenderTree/win/GCController.cpp: Removed.
2625         * DumpRenderTree/win/GCController.h: Removed.
2626         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
2627         (GCController::collect):
2628         (GCController::collectOnAlternateThread):
2629         (GCController::getJSObjectCount):
2630         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
2631         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
2632
2633 2007-09-17  Sam Weinig  <sam@webkit.org>
2634
2635         Reviewed by Adam Roben.
2636
2637         Begin sharing code between mac and windows DRT.
2638             - both now share LayoutTestController.h/cpp and implement platform dependant 
2639               operations in LayoutTestControllerMac/Win.
2640             - DumpRenderTree.h is now shared.
2641             - WorkQueue and WorkQueueItem are also shared.
2642
2643         * DumpRenderTree/DumpRenderTree.h:
2644         * DumpRenderTree/LayoutTestController.cpp:
2645         * DumpRenderTree/win/DumpRenderTree.cpp:
2646         (displayWebView):
2647         (dumpFrameScrollPosition):
2648         (dumpFramesAsText):
2649         (dump):
2650         (runTest):
2651         * DumpRenderTree/win/DumpRenderTree.h: Removed.
2652         * DumpRenderTree/win/DumpRenderTree.vcproj:
2653         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
2654         * DumpRenderTree/win/EditingDelegate.cpp:
2655         (EditingDelegate::shouldBeginEditingInDOMRange):
2656         (EditingDelegate::shouldEndEditingInDOMRange):
2657         (EditingDelegate::shouldInsertNode):
2658         (EditingDelegate::shouldInsertText):
2659         (EditingDelegate::shouldDeleteDOMRange):
2660         (EditingDelegate::shouldChangeSelectedDOMRange):
2661         (EditingDelegate::shouldApplyStyle):
2662         (EditingDelegate::shouldChangeTypingStyle):
2663         (EditingDelegate::doPlatformCommand):
2664         (EditingDelegate::webViewDidBeginEditing):
2665         (EditingDelegate::webViewDidChange):
2666         (EditingDelegate::webViewDidEndEditing):
2667         (EditingDelegate::webViewDidChangeTypingStyle):
2668         (EditingDelegate::webViewDidChangeSelection):
2669         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2670         * DumpRenderTree/win/LayoutTestController.h: Removed.
2671         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2672         (LayoutTestController::addDisallowedURL):
2673         (LayoutTestController::clearBackForwardList):
2674         (LayoutTestController::copyDecodedHostName):
2675         (LayoutTestController::copyEncodedHostName):
2676         (LayoutTestController::display):
2677         (LayoutTestController::keepWebHistory):
2678         (LayoutTestController::notifyDone):
2679         (LayoutTestController::queueBackNavigation):
2680         (LayoutTestController::queueForwardNavigation):
2681         (jsStringRefToWString):
2682         (LayoutTestController::queueLoad):
2683         (LayoutTestController::queueReload):
2684         (LayoutTestController::queueScript):
2685         (LayoutTestController::setAcceptsEditing):
2686         (LayoutTestController::setCustomPolicyDelegate):
2687         (LayoutTestController::setMainFrameIsFirstResponder):
2688         (LayoutTestController::setTabKeyCyclesThroughElements):
2689         (LayoutTestController::setUseDashboardCompatibilityMode):
2690         (LayoutTestController::setUserStyleSheetEnabled):
2691         (LayoutTestController::setUserStyleSheetLocation):
2692         (LayoutTestController::setWindowIsKey):
2693         (waitUntilDoneWatchdogFired):
2694         (LayoutTestController::setWaitToDump):
2695         (LayoutTestController::windowCount):
2696         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2697         (FrameLoadDelegate::didReceiveTitle):
2698         (FrameLoadDelegate::processWork):
2699         (FrameLoadDelegate::locationChangeDone):
2700         (FrameLoadDelegate::windowScriptObjectAvailable):
2701         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2702         * DumpRenderTree/win/WorkQueue.h: Removed.
2703         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2704         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2705         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2706         (jsStringRefToWString):
2707         (LoadItem::invoke):
2708         (ScriptItem::invoke):
2709
2710 2007-09-17  Sam Weinig  <sam@webkit.org>
2711
2712         Reviewed by Adam Roben.
2713
2714         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2715
2716         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2717         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2718         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2719         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2720         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2721         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2722         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2723         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2724         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2725         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2726         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2727         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2728         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2729         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
2730         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
2731         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
2732         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
2733         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
2734         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
2735         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
2736         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
2737         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
2738         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
2739         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
2740         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
2741         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
2742         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
2743         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
2744         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2745         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2746         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2747         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
2748         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
2749         * DumpRenderTree/win: Added.
2750         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
2751         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
2752         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
2753         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
2754         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
2755         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
2756         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
2757         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
2758         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
2759         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
2760         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
2761         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
2762         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
2763         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2764         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
2765         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
2766         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
2767         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
2768         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2769         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2770         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
2771         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2772         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
2773         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
2774         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
2775         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
2776
2777 2007-09-15  Mark Rowe  <mrowe@apple.com>
2778
2779         Build fix for DumpRenderTree.
2780
2781         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
2782
2783 2007-09-14  Sam Weinig  <sam@webkit.org>
2784
2785         Rubber stamped by Adam Roben.
2786
2787         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
2788           - The UIDelegate was put into a new file while the FrameLoadDelegate was
2789             kept in the WaitUntilDoneDelegate file for the time being.
2790
2791         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2792         (main):
2793         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
2794         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
2795         (UIDelegate::QueryInterface):
2796         (UIDelegate::AddRef):
2797         (UIDelegate::Release):
2798         (UIDelegate::hasCustomMenuImplementation):
2799         (UIDelegate::setFrame):
2800         (UIDelegate::webViewFrame):
2801         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2802         (UIDelegate::webViewAddMessageToConsole):
2803         (UIDelegate::doDragDrop):
2804         (UIDelegate::webViewGetDlgCode):
2805         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
2806         (UIDelegate::UIDelegate):
2807         (UIDelegate::createWebViewWithRequest):
2808         (UIDelegate::webViewShow):
2809         (UIDelegate::webViewClose):
2810         (UIDelegate::webViewFocus):
2811         (UIDelegate::webViewUnfocus):
2812         (UIDelegate::webViewFirstResponder):
2813         (UIDelegate::makeFirstResponder):
2814         (UIDelegate::setStatusText):
2815         (UIDelegate::webViewStatusText):
2816         (UIDelegate::webViewAreToolbarsVisible):
2817         (UIDelegate::setToolbarsVisible):
2818         (UIDelegate::webViewIsStatusBarVisible):
2819         (UIDelegate::setStatusBarVisible):
2820         (UIDelegate::webViewIsResizable):
2821         (UIDelegate::setResizable):
2822         (UIDelegate::setContentRect):
2823         (UIDelegate::webViewContentRect):
2824         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2825         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2826         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2827         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
2828         (UIDelegate::mouseDidMoveOverElement):
2829         (UIDelegate::contextMenuItemsForElement):
2830         (UIDelegate::validateUserInterfaceItem):
2831         (UIDelegate::shouldPerformAction):
2832         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
2833         (UIDelegate::willPerformDragDestinationAction):
2834         (UIDelegate::dragSourceActionMaskForPoint):
2835         (UIDelegate::willPerformDragSourceAction):
2836         (UIDelegate::contextMenuItemSelected):
2837         (UIDelegate::trackCustomPopupMenu):
2838         (UIDelegate::measureCustomMenuItem):
2839         (UIDelegate::drawCustomMenuItem):
2840         (UIDelegate::addCustomMenuDrawingData):
2841         (UIDelegate::cleanUpCustomMenuDrawingData):
2842         (UIDelegate::canTakeFocus):
2843         (UIDelegate::takeFocus):
2844         (UIDelegate::registerUndoWithTarget):
2845         (UIDelegate::removeAllActionsWithTarget):
2846         (UIDelegate::setActionTitle):
2847         (UIDelegate::undo):
2848         (UIDelegate::redo):
2849         (UIDelegate::canUndo):
2850         (UIDelegate::canRedo):
2851         (UIDelegate::webViewResizerRect):
2852         (UIDelegate::webViewDrawResizer):
2853         (UIDelegate::webViewScrolled):
2854         (UIDelegate::webViewShouldInterruptJavaScript):
2855         (UIDelegate::webViewReceivedFocus):
2856         (UIDelegate::webViewLostFocus):
2857         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
2858         (FrameLoadDelegate::QueryInterface):
2859         (FrameLoadDelegate::AddRef):
2860         (FrameLoadDelegate::Release):
2861         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2862         (FrameLoadDelegate::didCommitLoadForFrame):
2863         (FrameLoadDelegate::didReceiveTitle):
2864         (FrameLoadDelegate::processWork):
2865         (processWorkTimer):
2866         (FrameLoadDelegate::locationChangeDone):
2867         (FrameLoadDelegate::didFinishLoadForFrame):
2868         (FrameLoadDelegate::didFailLoadWithError):
2869         (FrameLoadDelegate::windowScriptObjectAvailable):
2870         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
2871         (FrameLoadDelegate::FrameLoadDelegate):
2872
2873 2007-09-14  Sam Weinig  <sam@webkit.org>
2874
2875         Reviewed by Kevin McCullough.
2876
2877         Move mac specific globals in to mac/DumpRenderTreeMac.h
2878
2879         * DumpRenderTree/DumpRenderTree.h:
2880         * DumpRenderTree/DumpRenderTree.mm: Removed.
2881         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2882         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
2883         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
2884
2885 2007-09-14  Brady Eidson  <beidson@apple.com>
2886
2887         Rubberstamped by Weinig
2888
2889         You know, Sam, some of us use case-sensitve filesystems...
2890
2891         * DumpRenderTree/DumpRenderTree.h:
2892         * DumpRenderTree/mac/UIDelegate.mm:
2893
2894 2007-09-14  Sam Weinig  <sam@webkit.org>
2895
2896         Rubber stamped by Adam Roben.
2897
2898         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
2899         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
2900
2901         * DumpRenderTree/AppleScriptController.h: Removed.
2902         * DumpRenderTree/AppleScriptController.m: Removed.
2903         * DumpRenderTree/DumpRenderTree.h:
2904         * DumpRenderTree/DumpRenderTree.mm:
2905         (startJavaScriptThreads):
2906         (stopJavaScriptThreads):
2907         (activateAhemFont):
2908         (setDefaultColorProfileToRGB):
2909         (makeLargeMallocFailSilently):
2910         (dumpFrameScrollPosition):
2911         (dumpFramesAsText):
2912         (dump):
2913         (runTest):
2914         (-[DumpRenderTreeWindow isKeyWindow]):
2915         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2916         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
2917         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
2918         * DumpRenderTree/EditingDelegate.h: Removed.
2919         * DumpRenderTree/EditingDelegate.m: Removed.
2920         * DumpRenderTree/EventSendingController.h: Removed.
2921         * DumpRenderTree/EventSendingController.m: Removed.
2922         * DumpRenderTree/FrameLoadDelegate.h: Removed.
2923         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
2924         * DumpRenderTree/GCController.mm: Removed.
2925         * DumpRenderTree/ImageDiff.m: Removed.
2926         * DumpRenderTree/LayoutTestController.cpp:
2927         (LayoutTestController::LayoutTestController):
2928         (dumpAsTextCallback):
2929         (dumpBackForwardListCallback):
2930         (dumpChildFramesAsTextCallback):
2931         (dumpChildFrameScrollPositionsCallback):
2932         (dumpDOMAsWebArchiveCallback):
2933         (dumpEditingCallbacksCallback):
2934         (dumpFrameLoadCallbacksCallback):
2935         (dumpResourceLoadCallbacksCallback):
2936         (dumpSelectionRectCallback):
2937         (dumpSourceAsWebArchiveCallback):
2938         (dumpTitleChangesCallback):
2939         (repaintSweepHorizontallyCallback):
2940         (setCallCloseOnWebViewsCallback):
2941         (setCanOpenWindowsCallback):
2942         (setCloseRemainingWindowsWhenCompleteCallback):
2943         (testRepaintCallback):
2944         (addFileToPasteboardOnDragCallback):
2945         (waitUntilDoneCallback):
2946         * DumpRenderTree/LayoutTestController.h:
2947         (LayoutTestController::dumpAsText):
2948         (LayoutTestController::setDumpAsText):
2949         (LayoutTestController::dumpBackForwardList):
2950         (LayoutTestController::setDumpBackForwardList):
2951         (LayoutTestController::dumpChildFrameScrollPositions):
2952         (LayoutTestController::setDumpChildFrameScrollPositions):
2953         (LayoutTestController::dumpChildFramesAsText):
2954         (LayoutTestController::setDumpChildFramesAsText):
2955         (LayoutTestController::dumpDOMAsWebArchive):
2956         (LayoutTestController::setDumpDOMAsWebArchive):
2957         (LayoutTestController::dumpSelectionRect):
2958         (LayoutTestController::setDumpSelectionRect):
2959         (LayoutTestController::dumpSourceAsWebArchive):
2960         (LayoutTestController::setDumpSourceAsWebArchive):
2961         (LayoutTestController::dumpTitleChanges):
2962         (LayoutTestController::setDumpTitleChanges):
2963         (LayoutTestController::dumpEditingCallbacks):
2964         (LayoutTestController::setDumpEditingCallbacks):
2965         (LayoutTestController::dumpResourceLoadCallbacks):
2966         (LayoutTestController::setDumpResourceLoadCallbacks):
2967         (LayoutTestController::dumpFrameLoadCallbacks):
2968         (LayoutTestController::setDumpFrameLoadCallbacks):
2969         (LayoutTestController::addFileToPasteboardOnDrag):
2970         (LayoutTestController::setAddFileToPasteboardOnDrag):
2971         (LayoutTestController::callCloseOnWebViews):
2972         (LayoutTestController::setCallCloseOnWebViews):
2973         (LayoutTestController::canOpenWindows):
2974         (LayoutTestController::setCanOpenWindows):
2975         (LayoutTestController::closeRemainingWindowsWhenComplete):
2976         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2977         (LayoutTestController::testRepaint):
2978         (LayoutTestController::setTestRepaint):
2979         (LayoutTestController::testRepaintSweepHorizontally):
2980         (LayoutTestController::setTestRepaintSweepHorizontally):
2981         (LayoutTestController::waitToDump):
2982         (LayoutTestController::windowIsKey):
2983         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
2984         * DumpRenderTree/NavigationController.h: Removed.
2985         * DumpRenderTree/NavigationController.m: Removed.
2986         * DumpRenderTree/ObjCController.h: Removed.
2987         * DumpRenderTree/ObjCController.m: Removed.
2988         * DumpRenderTree/ObjCPlugin.h: Removed.
2989         * DumpRenderTree/ObjCPlugin.m: Removed.
2990         * DumpRenderTree/ObjCPluginFunction.h: Removed.
2991         * DumpRenderTree/ObjCPluginFunction.m: Removed.
2992         * DumpRenderTree/PolicyDelegate.h: Removed.
2993         * DumpRenderTree/PolicyDelegate.m: Removed.
2994         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
2995         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
2996         * DumpRenderTree/TextInputController.h: Removed.
2997         * DumpRenderTree/TextInputController.m: Removed.
2998         * DumpRenderTree/UIDelegate.h: Removed.
2999         * DumpRenderTree/UIDelegate.mm: Removed.
3000         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
3001         * DumpRenderTree/mac: Added.
3002         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
3003         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
3004         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
3005         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
3006         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
3007         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
3008         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3009         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3010         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3011         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3012         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3013         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3014         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3015         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3016         (-[EditingDelegate webViewDidBeginEditing:]):
3017         (-[EditingDelegate webViewDidChange:]):
3018         (-[EditingDelegate webViewDidEndEditing:]):
3019         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3020         (-[EditingDelegate webViewDidChangeSelection:]):
3021         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
3022         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
3023         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
3024         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
3025         (-[FrameLoadDelegate init]):
3026         (-[FrameLoadDelegate dealloc]):
3027         (-[FrameLoadDelegate processWork:]):
3028         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3029         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3030         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3031         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3032         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3033         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3034         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3035         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3036         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3037         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3038         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3039         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3040         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3041         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3042         (-[FrameLoadDelegate webView:willCloseFrame:]):
3043         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3044         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3045         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
3046         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
3047         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
3048         (LayoutTestController::notifyDone):
3049         (LayoutTestController::setWindowIsKey):
3050         (LayoutTestController::setWaitToDump):
3051         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
3052         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
3053         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
3054         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
3055         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
3056         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
3057         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
3058         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
3059         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
3060         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
3061         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
3062         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
3063         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3064         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3065         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3066         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3067         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3068         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3069         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
3070         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
3071         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
3072         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
3073         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
3074         (-[UIDelegate webViewFocus:]):
3075         (-[UIDelegate webView:createWebViewWithRequest:]):
3076         (-[UIDelegate webViewClose:]):
3077         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
3078
3079 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
3080
3081         Reviewed by Adam.
3082
3083         - Changing Win version of Drosera work with recent changes.
3084
3085         * Drosera/DebuggerDocument.cpp:
3086         * Drosera/DebuggerDocument.h:
3087         * Drosera/mac/DebuggerDocumentPlatform.mm:
3088         (NSStringCreateWithJSStringRef):
3089         (JSValueRefCreateWithNSString):
3090         * Drosera/win/DebuggerClient.cpp:
3091         (DebuggerClient::stepInto):
3092         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3093
3094 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
3095
3096         Reviewed by Tim.
3097
3098         - Moved isPaused into the JS for efficiency and simplicity.
3099
3100         * Drosera/DebuggerDocument.cpp:
3101         (DebuggerDocument::DebuggerDocument):
3102         (DebuggerDocument::pauseCallback):
3103         (DebuggerDocument::resumeCallback):
3104         (DebuggerDocument::isPaused):
3105         (DebuggerDocument::staticFunctions):
3106         * Drosera/DebuggerDocument.h:
3107         * Drosera/console.js:
3108         * Drosera/debugger.js:
3109         * Drosera/mac/DebuggerClient.mm:
3110         (-[DebuggerClient validateUserInterfaceItem:]):
3111
3112 2007-09-13  Sam Weinig  <sam@webkit.org>
3113
3114         Rubber stamped by Darin.
3115
3116         Make DumpRenderTree more cross platform ready.
3117         - Convert GCController to use the JSCore API instead of the WebScriptObject.
3118         - Use CF types instead of NS objects.
3119         - General cleanup.
3120
3121         * DumpRenderTree/DumpRenderTree.h:
3122         * DumpRenderTree/DumpRenderTree.mm:
3123         (dumpRenderTree):
3124         (dump):
3125         (runTest):
3126         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3127         * DumpRenderTree/EditingDelegate.m:
3128         * DumpRenderTree/FrameLoadDelegate.h:
3129         * DumpRenderTree/FrameLoadDelegate.mm:
3130         (-[FrameLoadDelegate init]):
3131         (-[FrameLoadDelegate dealloc]):
3132         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3133         * DumpRenderTree/GCController.cpp: Added.
3134         (GCController::GCController):
3135         (GCController::~GCController):
3136         (collectCallback):
3137         (collectOnAlternateThreadCallback):
3138         (getJSObjectCountCallback):
3139         (GCController::makeWindowObject):
3140         (GCController::getJSClass):
3141         (GCController::staticFunctions):
3142         * DumpRenderTree/GCController.h:
3143         * DumpRenderTree/GCController.mm:
3144         (GCController::collect):
3145         (GCController::collectOnAlternateThread):
3146         (GCController::getJSObjectCount):
3147         * DumpRenderTree/LayoutTestController.cpp:
3148         (LayoutTestController::makeWindowObject):
3149         (LayoutTestController::getJSClass):
3150         * DumpRenderTree/LayoutTestController.h:
3151         * DumpRenderTree/LayoutTestControllerMac.mm:
3152         (LayoutTestController::addDisallowedURL):
3153         (waitUntilDoneWatchdogFired):
3154         (LayoutTestController::waitUntilDone):
3155         * DumpRenderTree/ResourceLoadDelegate.m:
3156         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3157
3158 2007-09-12  Sam Weinig  <sam@webkit.org>
3159
3160         Reviewed by Stephanie.
3161
3162         Fix leaks in mac DumpRenderTree.
3163
3164         * DumpRenderTree/FrameLoadDelegate.mm:
3165         (-[FrameLoadDelegate init]): Initalize in the correct order.
3166         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
3167         * DumpRenderTree/LayoutTestController.cpp:
3168         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
3169         (encodeHostNameCallback): ditto.
3170         * DumpRenderTree/LayoutTestController.h:
3171         * DumpRenderTree/LayoutTestControllerMac.mm:
3172         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
3173         (LayoutTestController::copyEncodedHostName): ditto
3174         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
3175
3176 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3177
3178         Reviewed by Geof.
3179
3180         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
3181
3182         * Scripts/run-webkit-tests:
3183
3184 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3185
3186         Reviewed by Darin.
3187
3188         - Simplified code paths and extracted out functions to increase encapsulation.
3189
3190         * Drosera/DebuggerDocument.cpp:
3191         (DebuggerDocument::breakpointEditorHTMLCallback):
3192         (DebuggerDocument::isPausedCallback):
3193         (DebuggerDocument::pauseCallback):
3194         (DebuggerDocument::resumeCallback):
3195         (DebuggerDocument::stepIntoCallback):
3196         (DebuggerDocument::evaluateScriptCallback):
3197         (DebuggerDocument::currentFunctionStackCallback):
3198         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3199         (DebuggerDocument::valueForScopeVariableNamedCallback):
3200         (DebuggerDocument::logCallback):
3201         * Drosera/DebuggerDocument.h:
3202         (DebuggerDocument::getPaused):
3203         * Drosera/mac/DebuggerClient.mm:
3204         (-[DebuggerClient pause:]):
3205         (-[DebuggerClient resume:]):
3206         (-[DebuggerClient stepInto:]):
3207         (-[DebuggerClient stepOver:]):
3208         (-[DebuggerClient stepOut:]):
3209         (-[DebuggerClient showConsole:]):
3210         (-[DebuggerClient closeCurrentFile:]):
3211         (-[DebuggerClient validateUserInterfaceItem:]):
3212         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
3213         (+[NSString stringOrNilFromWebScriptResult:]):
3214         (DebuggerDocument::platformPause):
3215         (DebuggerDocument::platformResume):
3216         (DebuggerDocument::platformStepInto):
3217         (DebuggerDocument::platformEvaluateScript):
3218         (DebuggerDocument::getPlatformCurrentFunctionStack):
3219         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3220         (DebuggerDocument::platformValueForScopeVariableNamed):
3221         (DebuggerDocument::platformLog):
3222         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3223
3224 2007-09-12  Sam Weinig  <sam@webkit.org>
3225
3226         Build fix for Buildbot.
3227
3228         * DumpRenderTree/DumpRenderTree.mm:
3229         (dump):
3230
3231 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3232
3233         Reviewed by Geoff.
3234
3235         - Updated the leaks list for leopard to help identify regressions.
3236
3237         * Scripts/run-webkit-tests:
3238
3239 2007-09-12  Sam Weinig  <sam@webkit.org>
3240
3241         Rubber stamped by Darin.
3242
3243         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
3244
3245         * DumpRenderTree/DumpRenderTree.h: Re-order variables. 
3246         * DumpRenderTree/DumpRenderTree.m: Removed.
3247         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
3248         (stopJavaScriptThreads): Fix initialization.
3249         (setDefaultColorProfileToRGB): Add explicit cast from void*.
3250         (dumpRenderTree): Ditto.
3251         (runTest):
3252         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
3253
3254         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3255         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
3256         * DumpRenderTree/FrameLoadDelegate.m: Removed.
3257         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
3258         (-[FrameLoadDelegate init]):
3259         (-[FrameLoadDelegate dealloc]):
3260         (-[FrameLoadDelegate processWork:]):
3261         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3262         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3263         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
3264         
3265         * DumpRenderTree/LayoutTestController.cpp: Added.
3266         (LayoutTestController::LayoutTestController):
3267         (LayoutTestController::~LayoutTestController):
3268         (dumpAsTextCallback):
3269         (dumpBackForwardListCallback):
3270         (dumpChildFramesAsTextCallback):
3271         (dumpChildFrameScrollPositionsCallback):
3272         (dumpDOMAsWebArchiveCallback):
3273         (dumpEditingCallbacksCallback):
3274         (dumpFrameLoadCallbacksCallback):
3275         (dumpResourceLoadCallbacksCallback):
3276         (dumpSelectionRectCallback):
3277         (dumpSourceAsWebArchiveCallback):
3278         (dumpTitleChangesCallback):
3279         (repaintSweepHorizontallyCallback):
3280         (setCallCloseOnWebViewsCallback):
3281         (setCanOpenWindowsCallback):
3282         (setCloseRemainingWindowsWhenCompleteCallback):
3283         (testRepaintCallback):
3284         (addFileToPasteboardOnDragCallback):
3285         (addDisallowedURLCallback):
3286         (clearBackForwardListCallback):
3287         (decodeHostNameCallback):
3288         (displayCallback):
3289         (encodeHostNameCallback):
3290         (keepWebHistoryCallback):
3291         (notifyDoneCallback):
3292         (queueBackNavigationCallback):
3293         (queueForwardNavigationCallback):
3294         (queueLoadCallback):
3295         (queueReloadCallback):
3296         (queueScriptCallback):
3297         (setAcceptsEditingCallback):
3298         (setCustomPolicyDelegateCallback):
3299         (setMainFrameIsFirstResponderCallback):
3300         (setTabKeyCyclesThroughElementsCallback):
3301         (setUseDashboardCompatibilityModeCallback):
3302         (setUserStyleSheetEnabledCallback):
3303         (setUserStyleSheetLocationCallback):
3304         (setWindowIsKeyCallback):
3305         (waitUntilDoneCallback):
3306         (windowCountCallback):
3307         (LayoutTestController::makeWindowObject):
3308         (LayoutTestController::getLayoutTestControllerJSClass):
3309         (LayoutTestController::staticFunctions):
3310         * DumpRenderTree/LayoutTestController.h: Replaced.
3311         * DumpRenderTree/LayoutTestController.m: Removed.
3312         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
3313         (LayoutTestController::dumpAsText):
3314         (LayoutTestController::dumpBackForwardList):
3315         (LayoutTestController::dumpChildFramesAsText):
3316         (LayoutTestController::dumpChildFrameScrollPositions):
3317         (LayoutTestController::dumpDOMAsWebArchive):
3318         (LayoutTestController::dumpEditingCallbacks):
3319         (LayoutTestController::dumpFrameLoadCallbacks):
3320         (LayoutTestController::dumpResourceLoadCallbacks):
3321         (LayoutTestController::dumpSelectionRect):
3322         (LayoutTestController::dumpSourceAsWebArchive):
3323         (LayoutTestController::dumpTitleChanges):
3324         (LayoutTestController::repaintSweepHorizontally):
3325         (LayoutTestController::setCallCloseOnWebViews):
3326         (LayoutTestController::setCanOpenWindows):
3327         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3328         (LayoutTestController::testRepaint):
3329         (LayoutTestController::addFileToPasteboardOnDrag):
3330         (LayoutTestController::addDisallowedURL):
3331         (LayoutTestController::clearBackForwardList):
3332         (LayoutTestController::decodeHostName):
3333         (LayoutTestController::encodeHostName):
3334         (LayoutTestController::display):
3335         (LayoutTestController::keepWebHistory):
3336         (LayoutTestController::notifyDone):
3337         (LayoutTestController::queueBackNavigation):
3338         (LayoutTestController::queueForwardNavigation):
3339         (LayoutTestController::queueLoad):
3340         (LayoutTestController::queueReload):
3341         (LayoutTestController::queueScript):
3342         (LayoutTestController::setAcceptsEditing):
3343         (LayoutTestController::setCustomPolicyDelegate):
3344         (LayoutTestController::setMainFrameIsFirstResponder):
3345         (LayoutTestController::setTabKeyCyclesThroughElements):
3346         (LayoutTestController::setUseDashboardCompatibilityMode):
3347         (LayoutTestController::setUserStyleSheetEnabled):
3348         (LayoutTestController::setUserStyleSheetLocation):
3349         (LayoutTestController::setWindowIsKey):
3350         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
3351         (LayoutTestController::waitUntilDone):
3352         (LayoutTestController::windowCount):
3353         Use the JSCore API to implement the LayoutTestController.
3354
3355         * DumpRenderTree/ObjCController.h:
3356         * DumpRenderTree/ObjCController.m:
3357         (+[ObjCController isSelectorExcludedFromWebScript:]):
3358         (+[ObjCController webScriptNameForSelector:]):
3359         (-[ObjCController accessStoredWebScriptObject]):
3360         (-[ObjCController storeWebScriptObject:]):
3361         (-[ObjCController dealloc]):
3362         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
3363         Move WebScriptObject tests to ObjCController.
3364
3365         * DumpRenderTree/UIDelegate.m: Removed.
3366         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
3367
3368         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3369         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3370         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3371         (WorkQueueItem::~WorkQueueItem):
3372         (LoadItem::LoadItem):
3373         (LoadItem::url):
3374         (LoadItem::target):
3375         (ScriptItem::ScriptItem):
3376         (ScriptItem::script):
3377         * DumpRenderTree/WorkQueueItemMac.mm: Added.
3378         (LoadItem::invoke):
3379         (ReloadItem::invoke):
3380         (ScriptItem::invoke):
3381         (BackForwardItem::invoke):
3382         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
3383         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
3384         sharing code.
3385
3386 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3387
3388         Reviewed by Maciej.
3389
3390         - Updated Win side to take advantage of the platform separating changes.
3391
3392         * Drosera/DebuggerDocument.cpp:
3393         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3394         * Drosera/DebuggerDocument.h:
3395         * Drosera/win/DebuggerClient.cpp:
3396         (DebuggerClient::pause):
3397         (DebuggerClient::resume):
3398         (DebuggerClient::stepInto):
3399         (DebuggerDocument::platformPause):
3400         (DebuggerDocument::platformResume):
3401         (DebuggerDocument::platformStepInto):
3402         (DebuggerDocument::platformEvaluateScript):
3403         (DebuggerDocument::getPlatformCurrentFunctionStack):
3404         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3405         (DebuggerDocument::platformValueForScopeVariableNamed):
3406         (DebuggerDocument::platformLog):
3407         * Drosera/win/DebuggerClient.h:
3408         * Drosera/win/Drosera.cpp:
3409         (Drosera::Drosera):
3410         (Drosera::windowScriptObjectAvailable):
3411         (Drosera::initWithServerName):
3412         (Drosera::switchToServerNamed):
3413         * Drosera/win/Drosera.h:
3414         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3415
3416 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3417
3418         Reviewed by Adam.
3419
3420         - Just doing the moves in a separate patch so the changes are easier to see.
3421
3422         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
3423         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
3424         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
3425         * Drosera/win/DebuggerDocumentWin.h: Removed.
3426         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3427
3428 2007-09-11  Sven Herzberg  <sven@imendio.com>
3429
3430         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
3431         http://bugs.webkit.org/show_bug.cgi?id=15176
3432
3433         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
3434         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
3435         other paths eg. from jhbuild)
3436
3437 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3438
3439         Reviewed by Adam.
3440
3441         - Made an order-of-deletion mistake.
3442
3443         * Drosera/DebuggerDocument.h:
3444         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
3445         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
3446         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
3447         * Drosera/mac/DebuggerClient.mm:
3448         (DebuggerDocument::platformPause):
3449         (DebuggerDocument::platformResume):
3450         (DebuggerDocument::platformStepInto):
3451         (DebuggerDocument::platformEvaluateScript):
3452         (DebuggerDocument::getPlatformCurrentFunctionStack):
3453         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3454         (DebuggerDocument::platformValueForScopeVariableNamed):
3455         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3456
3457 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3458
3459         Reviewed by Darin.
3460
3461         - Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
3462
3463         * Drosera/DebuggerDocument.cpp:
3464         (DebuggerDocument::DebuggerDocument):
3465         * Drosera/DebuggerDocument.h:
3466         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3467         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3468         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3469         * Drosera/mac/DebuggerApplication.mm:
3470         (-[DebuggerApplication attach:]):
3471         * Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
3472         * Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm.
3473         (DebuggerDocument::platformPause):
3474         (DebuggerDocument::platformResume):
3475         (DebuggerDocument::platformStepInto):
3476         (DebuggerDocument::platformEvaluateScript):
3477         (DebuggerDocument::getPlatformCurrentFunctionStack):
3478         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3479         (DebuggerDocument::platformValueForScopeVariableNamed):
3480         (DebuggerDocument::platformLog):
3481         * Drosera/mac/DebuggerDocumentMac.h: Removed.
3482         * Drosera/mac/DebuggerDocumentMac.mm: Removed.
3483         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3484
3485 2007-09-09  Sam Weinig  <sam@webkit.org>
3486
3487         Reviewed by Mark Rowe.
3488
3489         Remove 'objC' prefix from methods now in the ObjCController. 
3490
3491         * DumpRenderTree/ObjCController.m:
3492         (+[ObjCController isSelectorExcludedFromWebScript:]):
3493         (+[ObjCController webScriptNameForSelector:]):
3494         (-[ObjCController classNameOf:]):
3495         (-[ObjCController objectOfClass:]):
3496         (-[ObjCController identityIsEqual::]):
3497         (-[ObjCController longLongRoundTrip:]):
3498         (-[ObjCController unsignedLongLongRoundTrip:]):
3499
3500 2007-09-09  Sam Weinig  <sam@webkit.org>
3501
3502         Reviewed by Oliver.
3503
3504         Initial refactor of DumpRenderTree in preparation of making it more platform independent. 
3505         - Move LayoutTestController into its own file.
3506         - Move Objective-C only functions on LayoutTestController into a new controller called the
3507           ObjCController. 
3508
3509         * DumpRenderTree/DumpRenderTree.h:
3510         * DumpRenderTree/DumpRenderTree.m:
3511         (displayWebView):
3512         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3513         * DumpRenderTree/FrameLoadDelegate.m:
3514         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3515         * DumpRenderTree/LayoutTestController.h: Added.
3516         * DumpRenderTree/LayoutTestController.m: Added.
3517         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3518         (+[LayoutTestController webScriptNameForSelector:]):
3519         (-[LayoutTestController clearBackForwardList]):
3520         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
3521         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
3522         (-[LayoutTestController setCustomPolicyDelegate:]):
3523         (-[LayoutTestController keepWebHistory]):
3524         (-[LayoutTestController setCallCloseOnWebViews:]):
3525         (-[LayoutTestController setCanOpenWindows]):
3526         (-[LayoutTestController waitUntilDone]):
3527         (-[LayoutTestController waitUntilDoneWatchdogFired]):
3528         (-[LayoutTestController notifyDone]):
3529         (-[LayoutTestController dumpAsText]):
3530         (-[LayoutTestController addFileToPasteboardOnDrag]):
3531         (-[LayoutTestController addDisallowedURL:]):
3532         (-[LayoutTestController setUserStyleSheetLocation:]):
3533         (-[LayoutTestController setUserStyleSheetEnabled:]):
3534         (-[LayoutTestController dumpDOMAsWebArchive]):
3535         (-[LayoutTestController dumpSourceAsWebArchive]):
3536         (-[LayoutTestController dumpSelectionRect]):
3537         (-[LayoutTestController dumpTitleChanges]):
3538         (-[LayoutTestController dumpBackForwardList]):
3539         (-[LayoutTestController windowCount]):
3540         (-[LayoutTestController dumpChildFrameScrollPositions]):
3541         (-[LayoutTestController dumpChildFramesAsText]):
3542         (-[LayoutTestController dumpEditingCallbacks]):
3543         (-[LayoutTestController dumpResourceLoadCallbacks]):
3544         (-[LayoutTestController dumpFrameLoadCallbacks]):
3545         (-[LayoutTestController setWindowIsKey:]):
3546         (-[LayoutTestController setMainFrameIsFirstResponder:]):
3547         (-[LayoutTestController display]):
3548         (-[LayoutTestController testRepaint]):
3549         (-[LayoutTestController repaintSweepHorizontally]):
3550         (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
3551         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
3552         (-[LayoutTestController _doLoad:target:]):
3553         (-[LayoutTestController _doBackOrForwardNavigation:]):
3554         (-[LayoutTestController queueBackNavigation:]):
3555         (-[LayoutTestController queueForwardNavigation:]):
3556         (-[LayoutTestController queueReload]):
3557         (-[LayoutTestController queueScript:]):
3558         (-[LayoutTestController queueLoad:target:]):
3559         (-[LayoutTestController setAcceptsEditing:]):
3560         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
3561         (-[LayoutTestController storeWebScriptObject:]):
3562         (-[LayoutTestController accessStoredWebScriptObject]):
3563         (-[LayoutTestController dealloc]):
3564         (-[LayoutTestController decodeHostName:]):
3565         (-[LayoutTestController encodeHostName:]):
3566         * DumpRenderTree/ObjCController.h: Added.
3567         * DumpRenderTree/ObjCController.m: Added.
3568         (+[ObjCController isSelectorExcludedFromWebScript:]):
3569         (+[ObjCController webScriptNameForSelector:]):
3570         (-[ObjCController objCClassNameOf:]):
3571         (-[ObjCController objCObjectOfClass:]):
3572         (-[ObjCController objCIdentityIsEqual::]):
3573         (-[ObjCController objCLongLongRoundTrip:]):
3574         (-[ObjCController objCUnsignedLongLongRoundTrip:]):
3575         (-[ObjCController testWrapperRoundTripping:]):
3576
3577 2007-09-07  Sam Weinig  <sam@webkit.org>
3578
3579         Reviewed by Alice.
3580
3581         Strip trailing and leading space/newline characters from skiplist file names.
3582
3583         * Scripts/run-webkit-tests:
3584
3585 2007-09-06  Kevin McCullough  <kmccullough@apple.com>
3586
3587         Reviewed by Maciej.
3588
3589         - Changed Drosera to take advantage of the JSRetainPtr changes.
3590
3591         * Drosera/DebuggerDocument.cpp:
3592         (DebuggerDocument::breakpointEditorHTML):
3593         (DebuggerDocument::evaluateScript):
3594         (DebuggerDocument::valueForScopeVariableNamed):
3595         (DebuggerDocument::log):
3596         (DebuggerDocument::windowScriptObjectAvailable):
3597         (DebuggerDocument::toJSArray):
3598         (DebuggerDocument::callFunctionOnObject):
3599         (DebuggerDocument::logException):
3600         * Drosera/mac/DebuggerDocumentMac.mm:
3601         (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
3602         (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3603         (DebuggerDocument::platformEvaluateScript):
3604         (DebuggerDocument::getPlatformCurrentFunctionStack):
3605         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3606         (DebuggerDocument::platformValueForScopeVariableNamed):
3607
3608 2007-09-05  Kevin McCullough  <kmccullough@apple.com>
3609
3610         Reviewed by Adam, Sam, Darin.
3611
3612         - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.
3613
3614         * Drosera/Debugger.h: Added.
3615         * Drosera/DebuggerDocument.cpp:
3616         (DebuggerDocument::breakpointEditorHTMLCallback):
3617         (DebuggerDocument::isPausedCallback):
3618         (DebuggerDocument::pauseCallback):
3619         (DebuggerDocument::resumeCallback):
3620         (DebuggerDocument::stepIntoCallback):
3621         (DebuggerDocument::evaluateScriptCallback):
3622         (DebuggerDocument::currentFunctionStackCallback):
3623         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3624         (DebuggerDocument::valueForScopeVariableNamedCallback):
3625         (DebuggerDocument::logCallback):
3626         (DebuggerDocument::breakpointEditorHTML):
3627         (DebuggerDocument::isPaused):
3628         (DebuggerDocument::pause):
3629         (DebuggerDocument::resume):
3630         (DebuggerDocument::stepInto):
3631         (DebuggerDocument::evaluateScript):
3632         (DebuggerDocument::currentFunctionStack):
3633         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3634         (DebuggerDocument::valueForScopeVariableNamed):
3635         (DebuggerDocument::log):
3636         (DebuggerDocument::toolbarPause):
3637         (DebuggerDocument::toolbarResume):
3638         (DebuggerDocument::toolbarStepInto):
3639         (DebuggerDocument::toolbarStepOver):
3640         (DebuggerDocument::toolbarStepOut):
3641         (DebuggerDocument::toolbarShowConsole):
3642         (DebuggerDocument::toolbarCloseCurrentFile):
3643         (DebuggerDocument::updateFileSource):
3644         (DebuggerDocument::didParseScript):
3645         (DebuggerDocument::willExecuteStatement):
3646         (DebuggerDocument::didEnterCallFrame):
3647         (DebuggerDocument::willLeaveCallFrame):
3648         (DebuggerDocument::exceptionWasRaised):
3649         (DebuggerDocument::windowScriptObjectAvailable):
3650         (DebuggerDocument::toJSArray):
3651         (DebuggerDocument::callGlobalFunction):
3652         (DebuggerDocument::callFunctionOnObject):
3653         (DebuggerDocument::getDroseraJSClass):
3654         (DebuggerDocument::staticFunctions):
3655         (DebuggerDocument::logException):
3656         * Drosera/DebuggerDocument.h:
3657         (DebuggerDocument::DebuggerDocument):
3658         * Drosera/ForwardingHeaders: Added.
3659         * Drosera/ForwardingHeaders/wtf: Added.
3660         * Drosera/ForwardingHeaders/wtf/Platform.h: Added.
3661         * Drosera/config.h:
3662         * Drosera/console.html:
3663         * Drosera/console.js:
3664         * Drosera/debugger.js:
3665         * Drosera/mac/DebuggerApplication.mm:
3666         (-[DebuggerApplication attach:]):
3667         * Drosera/mac/DebuggerDocumentMac.h:
3668         * Drosera/mac/DebuggerDocumentMac.mm:
3669         (+[NSString stringOrNilFromWebScriptResult:]):
3670         (+[DebuggerClientMac log:]):
3671         (-[DebuggerClientMac initWithServerName:]):
3672         (-[DebuggerClientMac dealloc]):
3673         (-[DebuggerClientMac pause]):
3674         (-[DebuggerClientMac resume]):
3675         (-[DebuggerClientMac pause:]):
3676         (-[DebuggerClientMac resume:]):
3677         (-[DebuggerClientMac stepInto:]):
3678         (-[DebuggerClientMac stepOver:]):
3679         (-[DebuggerClientMac stepOut:]):
3680         (-[DebuggerClientMac showConsole:]):
3681         (-[DebuggerClientMac closeCurrentFile:]):
3682         (-[DebuggerClientMac validateUserInterfaceItem:]):
3683         (-[DebuggerClientMac webView:windowScriptObjectAvailable:]):
3684         (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3685         (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3686         (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3687         (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3688         (DebuggerDocument::platformPause):
3689         (DebuggerDocument::platformResume):
3690         (DebuggerDocument::platformStepInto):
3691         (DebuggerDocument::platformEvaluateScript):
3692         (DebuggerDocument::platformCurrentFunctionStack):
3693         (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame):
3694         (DebuggerDocument::platformValueForScopeVariableNamed):
3695         (DebuggerDocument::platformLog):
3696         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3697
3698 2007-09-06  Sam Weinig  <sam@webkit.org>
3699
3700         Reviewed by Adam Roben.
3701
3702         Register the WebKit DLL on initialization of the DumpRenderTree.
3703
3704         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3705         (initialize):
3706
3707 2007-09-05  Sam Weinig  <sam@webkit.org>
3708
3709         Reviewed by Oliver.
3710
3711         Fix many layout test failures caused by r25364.
3712         Set text size to standand size at the begining of each test matching the mac.
3713
3714         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3715         (runTest):
3716
3717 2007-09-04  Sam Weinig  <sam@webkit.org>
3718
3719         Reviewed by Adam.
3720
3721         Fix for <rdar://problem/5382277>
3722         Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.
3723
3724         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
3725         (textZoomInCallback):
3726         (textZoomOutCallback):
3727
3728 2007-08-29  David Kilzer  <ddkilzer@apple.com>
3729
3730         Reviewed by Adam.
3731
3732         Added case-insensitivity to checks for adding regression tests.
3733
3734         * Scripts/prepare-ChangeLog:
3735         (generateFileList):
3736
3737 2007-08-28  David Kilzer  <ddkilzer@apple.com>
3738
3739         Reviewed by Maciej.
3740
3741         Ignore files in /resources/ subdirectories when creating a list of added tests.
3742
3743         * Scripts/prepare-ChangeLog:
3744         (generateFileList):
3745
3746 2007-08-27  Kevin McCullough  <kmccullough@apple.com>
3747
3748         Reviewed by John.
3749
3750         - Removed Leopard leaks list since all of those radars were fixed.
3751
3752         * Scripts/run-webkit-tests:
3753
3754 2007-08-27  Adam Roben  <aroben@apple.com>
3755
3756         Rubberstamped by Mark.
3757
3758         * Scripts/pdevenv: Pass arguments along to devenv.com.
3759
3760 2007-08-26  David Kilzer  <ddkilzer@webkit.org>
3761
3762         Reviewed by Mark Rowe.
3763
3764         Update prepare-ChangeLog to generate the datestamp in the correct timezone.
3765
3766         * Scripts/prepare-ChangeLog:
3767         (changeLogDate): Added.
3768
3769 2007-08-24  Sam Weinig  <sam@webkit.org>
3770
3771         Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.
3772
3773 2007-08-24  Sam Weinig  <sam@webkit.org>
3774
3775         Rubber-stamped by Adam Roben.
3776
3777         <rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration
3778
3779         Rename COM DOM bindings to use Deprecated prefix.
3780
3781         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3782         (dumpFramesAsText):
3783         (dump):
3784         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp:
3785         (dumpPath):
3786         (dump):
3787         (EditingDelegate::shouldBeginEditingInDOMRange):
3788         (EditingDelegate::shouldEndEditingInDOMRange):
3789         (EditingDelegate::shouldInsertNode):
3790         (EditingDelegate::shouldInsertText):
3791         (EditingDelegate::shouldDeleteDOMRange):
3792         (EditingDelegate::shouldChangeSelectedDOMRange):
3793         (EditingDelegate::shouldApplyStyle):
3794         (EditingDelegate::shouldChangeTypingStyle):
3795         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h:
3796
3797 2007-08-24  Oliver Hunt  <oliver@apple.com>
3798
3799         Reviewed by John H.
3800
3801         WebDataSource::response can legitimately have a null response, so we
3802         must check that case.
3803
3804         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3805         (queueLoadCallback):
3806
3807 2007-08-23  Mitz Pettel  <mitz@webkit.org>
3808
3809         Reviewed by Darin and Adam.
3810
3811         - DumpRenderTree changes to allow testing for
3812           http://bugs.webkit.org/show_bug.cgi?id=11756
3813           REGRESSION: link targeting a frame in another window does not work
3814           <rdar://problem/5286420>
3815
3816         Use a frame group name for all WebViews created by DumpRenderTree to
3817         allow testing of cross-page frame lookup.
3818
3819         * DumpRenderTree/DumpRenderTree.m:
3820         (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
3821         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3822         (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).
3823
3824 2007-08-23  David Kilzer  <ddkilzer@webkit.org>
3825
3826         Reviewed by Adam.
3827
3828         Quote the $sslCertificate path in case it contains a space.
3829
3830         * Scripts/run-webkit-httpd:
3831         * Scripts/run-webkit-tests:
3832
3833 2007-08-22  Oliver Hunt  <oliver@apple.com>
3834
3835         Reviewed by John and Adam.
3836         
3837         WebDataSource::response can legitimately have a null response, so we
3838         must check that case.
3839
3840         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3841         (dump):
3842
3843 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
3844
3845         Reviewed by Geof.
3846
3847         - Changing the usage to be more clear.
3848
3849         * Scripts/run-testkjs:
3850
3851 2007-08-20  John Sullivan  <sullivan@apple.com>
3852
3853         Reviewed by Adam Roben
3854
3855         * DumpRenderTree/DumpRenderTree.m:
3856         (runTest):
3857         call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors
3858         in layout tests on Tiger and Leopard
3859
3860 2007-08-20  Adam Roben  <aroben@apple.com>
3861
3862         Put LayoutTests after all other ChangeLogs in commit logs
3863
3864         We use "~" to sort LayoutTests after all the other ChangeLogs because
3865         "~" is the last ASCII character (other than "DEL").
3866
3867         Reviewed by Sam.
3868
3869         * Scripts/commit-log-editor:
3870
3871 2007-08-20  Adam Roben  <aroben@apple.com>
3872
3873         Detect that DRT crashed even if a crash dialog is running
3874
3875         On Windows, when DRT crashes a crash dialog commonly appears. The DRT
3876         process is still running at this point, so run-webkit-tests wouldn't
3877         detect that DRT had crashed. We now record the crash in our SIGPIPE
3878         handler so that we know if DRT crashed even if the crash dialog is up.
3879
3880         Reviewed by Sam.
3881
3882         * Scripts/run-webkit-tests:
3883         (sub catch_pipe): Set the crashed bit.
3884         (sub openDumpTool): Reset the crashed bit.
3885         (sub dumpToolDidCrash): Check the crashed bit.
3886
3887 2007-08-20  Adam Roben  <aroben@apple.com>
3888
3889         Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog
3890
3891         http://bugs.webkit.org/show_bug.cgi?id=15026
3892
3893         Reviewed by David Kilzer and Darin Adler.
3894
3895         * Scripts/prepare-ChangeLog:
3896         (sub isModifiedStatus): Split out from isModifiedOrAddedStatus.
3897         (sub isAddedStatus): Ditto.
3898         (sub testListForChangeLog): Added.
3899
3900 2007-08-19  Oleg Sukhodolsky  <son.two@gmail.com>
3901
3902         Reviewed by Mark.
3903
3904         -fixes http://bugs.webkit.org/show_bug.cgi?id=14632
3905
3906         * Scripts/webkitdirs.pm:
3907         qt and gtk ports now explicitly pass debug (or release) mode to qmake.
3908
3909 2007-08-17  Darin Adler  <darin@apple.com>
3910
3911         Reviewed by Oliver Hunt.
3912
3913         - don't look for Apple-style localizable strings in the GTK version of WebKit
3914
3915         * Scripts/extract-localizable-strings: Add a feature where you can pass in the
3916         name of subdirectories to skip.
3917         * Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory
3918         to skip.
3919
3920 2007-08-17  Anders Carlsson  <andersca@apple.com>
3921
3922         Build fix.
3923         
3924         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3925         (NPP_SetWindow):
3926
3927 2007-08-17  Anders Carlsson  <andersca@apple.com>
3928
3929         Reviewed by Dave Hyatt.
3930
3931         <rdar://problem/5379040>
3932         REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes
3933
3934         Add a way for the plug-in to dump the width and height when it gets its  NPP_SetWindow call.
3935         
3936         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
3937         (pluginAllocate):
3938         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3939         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3940         (NPP_New):
3941         (NPP_SetWindow):
3942
3943 2007-08-16  Alice Liu  <alice.liu@apple.com>
3944
3945         Reviewed by Maciej.
3946
3947         Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail
3948
3949         * DumpRenderTree/DumpRenderTree.m:
3950         (createWebView):
3951         Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow.
3952         (dumpRenderTree):
3953         Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow. 
3954
3955 2007-08-16  Kevin McCullough  <kmccullough@apple.com>
3956
3957         Reviewed by Adam.
3958
3959         - Added tests for regressions in other components.  In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
3960
3961         * Scripts/run-webkit-tests:
3962
3963 2007-08-15  Timothy Hatcher  <timothy@apple.com>
3964
3965         Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
3966         The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.
3967
3968         Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
3969         this prevents making "build" directories in each project folder.
3970
3971         * Scripts/webkitdirs.pm:
3972
3973 2007-08-14  Geoffrey Garen  <ggaren@apple.com>
3974
3975         Reviewed by Kevin Mccullough.
3976         
3977         Removed special case that didn't belong. (It would allow a global 
3978         initializer to sneak into production builds, which would cause a 
3979         system-wide performance regression on Mac OS X.)
3980
3981         * Scripts/check-for-global-initializers:
3982
3983 2007-08-14  Justin Garcia  <justin.garcia@apple.com>
3984
3985         Reviewed by Tim.
3986         
3987         <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
3988
3989         * DumpRenderTree/EditingDelegate.m:
3990         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES
3991         only for elements with the class needsDeletionUI.
3992
3993 2007-08-14  David Kilzer  <ddkilzer@webkit.org>
3994
3995         Reviewed by Darin.
3996
3997         - fix http://bugs.webkit.org/show_bug.cgi?id=14965
3998           svn-create-patch uses deprecated tail switch
3999
4000         * Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.
4001
4002 2007-08-13  Sam Weinig  <sam@webkit.org>
4003
4004         Reviewed by Adam Roben.
4005
4006         Use the cygwin specific Apache config file under cygwin.
4007
4008         * Scripts/run-webkit-httpd:
4009
4010 2007-08-12  Adam Roben  <aroben@apple.com>
4011
4012         Generate results for new tests in a more logical location
4013
4014         New platform-specific tests always have their results generated right
4015         next to the test. New cross-platform tests will have their results
4016         generated a) in the cross-platform directory, if they are text-only,
4017         or b) in the least-specific platform directory, if they are render
4018         tree dumps.
4019
4020         Reviewed by Lars.
4021
4022         * Scripts/run-webkit-tests:
4023
4024 2007-08-12  Adam Roben  <aroben@apple.com>
4025
4026         Print the actual directory where new results are generated.
4027
4028         Before, we were printing an unpredictable, context-specific substring
4029         of the directory.
4030
4031         Reviewed by Lars.
4032
4033         * Scripts/run-webkit-tests:
4034
4035 2007-08-12  Adam Roben  <aroben@apple.com>
4036
4037         Factor some common code into a stripExtension() subroutine.
4038
4039         Reviewed by Lars.
4040
4041         * Scripts/run-webkit-tests: Also removed some debugging output.
4042
4043 2007-08-11  Matt Lilek  <pewtermoose@gmail.com>
4044
4045         Reviewed over and over and over by Adam Roben.
4046
4047         Bug 14740: Hierarchical layout tests and platform organization
4048         http://bugs.webkit.org/show_bug.cgi?id=14740
4049
4050         Add support for platform-specific layout tests and results.
4051
4052         * Scripts/run-webkit-tests:
4053
4054 2007-08-11  David Kilzer  <ddkilzer@webkit.org>
4055
4056         Reviewed by Adam.
4057
4058         Refactored svn-create-path to use a hash-of-hashes data structure to keep
4059         track of changed files.  In the top level hash, keys are paths to files and
4060         values are 'fileData' hashes with the following keys and values:
4061
4062         - isBinary: boolean value (set to true for non-text files like images, etc.)
4063         - isTestFile: boolean value (set to true if file exists within a known test
4064           directory)
4065         - modificationType: string equal to one of 'addition', 'additionWithHistory',
4066           'modification' or 'deletion'
4067         - path: string equal to the path to the file (this may seem redundant, but it
4068           is required to use the second-level 'fileData' hash independent of the
4069           top-level hash)
4070         - sourceFile: [optional] string equal to the path of the original file that was
4071           copied or moved
4072         - sourceRevision: [optional] string equal to the revision of the original file
4073           that was copied or moved
4074
4075         * Scripts/svn-create-patch: Moved call to GetOptions() to its own statement
4076         that saves the return value in $result, then checks it before printing help.
4077         Combined sourceFiles, %testFiles, and %binaryFiles into single %diffFiles hash
4078         and eliminated two for() loops.
4079         (binarycmp): Added.  Used with sort() to order non-binary files before binary
4080         files.
4081         (findBaseUrl): Added.  Extracted from findSourceFileAndRevision().
4082         (findMimeType): Added optional second argument that takes a revision number.
4083         (generateDiff): Updated to take one fileData argument instead of three ($file,
4084         $modificationType, $isBinary).
4085         (generateFileList): Updated to take one hash ref argument (%diffFiles)
4086         instead of three (%sourceFiles, %testFiles, %binaryFiles).  Populates
4087         %diffFiles using paths for keys and fileData hashes for values.
4088         (manufacturePatchForAdditionWithHistory): Updated to take one fileData
4089         argument.
4090         (pathcmp): Updated to take two fileData arguments instead of two strings.
4091         (testfilecmp): Added.  Used with sort() to order non-test files before test
4092         files.
4093
4094 2007-08-11  Darin Adler  <darin@apple.com>
4095
4096         * Scripts/run-webkit-tests: Give a different message when only the pixel test failed.
4097
4098 2007-08-06  Nigel Tao  <nigeltao@gnome.org>
4099
4100         Reviewed by David Kilzer.
4101
4102         Fix bug 14745: WebKitTools/Scripts/run-launcher doesn't speak --gdk
4103         http://bugs.webkit.org/show_bug.cgi?id=14745
4104
4105         * Scripts/run-launcher:
4106         Scrub the "--gdk" out of the command line args, if given, so that
4107         GdkLauncher doesn't try to interpret it as a URL.
4108
4109 2007-08-03  Adam Roben  <aroben@apple.com>
4110
4111         Catch SIGPIPE on Windows so that run-webkit-tests doesn't quit when DRT crashes
4112
4113         Reviewed by Sam.
4114
4115         * Scripts/run-webkit-tests: Also close ERROR when we finish running the tests.
4116
4117 2007-08-03  Sam Weinig  <sam@webkit.org>
4118
4119         Reviewed by Darin.
4120
4121         Recursively dump all frames as text using new
4122         layoutTestController.dumpChildFramesAsText() function.
4123
4124         * DumpRenderTree/DumpRenderTree.m:
4125         (dumpFramesAsText):
4126         (dump):
4127         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
4128         (-[LayoutTestController dumpChildFramesAsText]):
4129         (runTest):
4130         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
4131         (dumpFramesAsText):
4132         (dump):
4133         (runTest):
4134         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
4135         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
4136         (dumpChildFramesAsTextCallback):
4137         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4138
4139 2007-08-02  Adam Roben  <aroben@apple.com>
4140
4141         Fix fast/dom/Window/alert-undefined.html
4142
4143         Reviewed by Sam.
4144
4145         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
4146         (WaitUntilDoneDelegate::runJavaScriptAlertPanelWithMessage): Don't let
4147         Windows translate a null BSTR into "(null)"
4148
4149 2007-08-02  Kevin McCullough  <kmccullough@apple.com>
4150
4151         Reviewed by Tim. 
4152
4153         - It would help if I actually called the right function.
4154
4155         * Drosera/DebuggerDocument.cpp:
4156         (DebuggerDocument::showConsole):
4157
4158 2007-08-02  Adam Roben  <aroben@apple.com>
4159
4160         Don't delete the stderr file right after creating it
4161
4162         * Scripts/run-webkit-tests:
4163
4164 2007-08-01  Adam Roben  <aroben@apple.com>
4165
4166         When DRT crashes, record stderr and restart DRT
4167
4168         This prevents a DRT crash from causing the next few hundred tests to
4169         "fail" because DRT is no longer running. 
4170
4171         I also changed the terminology that run-webkit-tests uses in its
4172         output a bit, so that crashing tests are referred to as "crashes"
4173         instead of "failures".
4174
4175         Reviewed by Mark.
4176
4177         * Scripts/run-webkit-tests: Detect a crash and record it as a tool
4178         failure.
4179         (sub openDumpTool): Use open3 so that we can access stderr.
4180         (sub dumpToolCrashed): Added.
4181         (sub printFailureMessageForTest): Added.