Reviewed by Kevin Ollivier.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-10-21  Robin Dunn  <robin@alldunn.com>
2
3         Reviewed by Kevin Ollivier.
4
5         Update the Windows installer builder to work with Vista / Win 7 and with git.
6         
7         https://bugs.webkit.org/show_bug.cgi?id=30649
8
9         * wx/build/build_utils.py:
10         * wx/packaging/build-mac-installer.py:
11         * wx/packaging/build-win-installer.py:
12         * wx/packaging/wxWebKitInstaller.iss.in:
13
14 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
15
16         Reviewed by Gustavo Noronha.
17
18         [GTK] Added conditional code to avoid using
19         gdk_window_get_root_coords if we do not have a gtk+ release newer
20         than 2.17.3.
21         https://bugs.webkit.org/show_bug.cgi?id=30636
22
23         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
24
25 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
26
27         Reviewed by Eric Seidel.
28
29         [Qt] Added dummy implementation for keepWebHistory()
30         https://bugs.webkit.org/show_bug.cgi?id=30592
31
32         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
33         (LayoutTestController::keepWebHistory):
34         * DumpRenderTree/qt/LayoutTestControllerQt.h:
35
36 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
37
38         Reviewed by Xan Lopez.
39
40         [GTK] Fixed the double click condition, it is not double click if
41         we move in just in one direction.
42         https://bugs.webkit.org/show_bug.cgi?id=30636
43
44         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
45
46 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
47
48         Reviewed by Xan Lopez.
49
50         [GTK] Initialize the events completly before emitting them.
51         https://bugs.webkit.org/show_bug.cgi?id=30633
52
53         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
54
55 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
56
57         wx build fix. Fix for when linking using --as-needed with gcc.
58
59         * wx/browser/wscript:
60
61 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
62
63         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
64         to support all the features used by CURL backend.
65         
66         * wx/build/settings.py:
67         * wx/install-unix-extras:
68
69 2009-10-20  Anton Muhin  <antonm@chromium.org>
70
71         Reviewed by Adam Barth.
72
73         Add {ager,antonm,yurys}@chromium.org into committers.py
74         https://bugs.webkit.org/show_bug.cgi?id=30560
75
76         * Scripts/modules/committers.py:
77
78 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
79
80         Reviewed by Tor Arne Vestbø.
81
82         Make the Netscape Test plugin available to the Qt launcher.
83
84         * Scripts/run-launcher:
85
86 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
87
88         Reviewed by David Levin.
89
90         Removed WebSocket runtime settings.
91         https://bugs.webkit.org/show_bug.cgi?id=29896
92
93         WebSocket runtime configuration is supported by chromium/v8 only.
94
95         * DumpRenderTree/mac/DumpRenderTree.mm:
96         (resetDefaultsToConsistentValues):
97         * DumpRenderTree/win/DumpRenderTree.cpp:
98         (resetDefaultsToConsistentValues):
99
100 2009-10-19  Nate Chapin  <japhet@chromium.org>
101
102         Reviewed by Adam Barth.
103
104         Add testFail() to test plugin so we can test our handling of a
105         plugin invoke call returning false.
106
107         https://bugs.webkit.org/show_bug.cgi?id=30239
108
109         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
110         (pluginInvoke):
111         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
112
113 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
114
115         Reviewed by Gustavo Noronha.
116
117         Enable DOM pasting when running layout tests.
118
119         * DumpRenderTree/gtk/DumpRenderTree.cpp:
120         (resetDefaultsToConsistentValues):
121
122 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
123
124         Reviewed by Simon Hausmann.
125
126         Use the setPreferredContentsSize method instead
127         of setFixedContentsSize, as the method has been renamed.
128
129         * DumpRenderTree/qt/DumpRenderTree.cpp:
130         (WebCore::DumpRenderTree::open):
131         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
132         (LayoutTestController::setFixedContentsSize):
133
134 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
135
136         Reviewed by Dan Bernstein.
137
138         https://bugs.webkit.org/show_bug.cgi?id=30456
139         Fixes for new Debug_All Windows build configuration.
140
141         * DumpRenderTree/win/DumpRenderTree.cpp:
142         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
143         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
144
145 2009-10-16  Eric Seidel  <eric@webkit.org>
146
147         Reviewed by Adam Barth.
148
149         commit-queue status bot should list which buildbot is blocking the queue
150         https://bugs.webkit.org/show_bug.cgi?id=30452
151
152         Add new methods and testing.
153
154         * Scripts/bugzilla-tool:
155         * Scripts/modules/buildbot.py:
156         * Scripts/modules/buildbot_unittest.py:
157
158 2009-10-16  Eric Seidel  <eric@webkit.org>
159
160         Reviewed by Adam Barth.
161
162         run-webkit-tests fails when CWD is not inside a WebKit checkout
163         https://bugs.webkit.org/show_bug.cgi?id=30451
164
165         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
166         * Scripts/modules/scm_unittest.py:
167           - Remove use of original_path (we don't need to restore the CWD).
168           - Don't use '.' to find the webkit checkout, use __file__ instead.
169
170 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
171
172         Reviewed by Adam Roben.
173
174         Add a Debug_All configuration to build entire stack as debug.
175         Change Debug_Internal to:
176         - stop using _debug suffix for all WebKit/Safari binaries
177         - not use _debug as a DLL naming suffix
178         - use non-debug C runtime lib.
179
180         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
181         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
182         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
183         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
184         Add missing debug.vsprops inherited property sheet.
185         Add Debug_All configuration.
186         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
187         * WinLauncher/WinLauncher.vcproj:
188         Removed extraneous definitions inherited from vsprops.
189         Add Debug_All configuration.
190
191 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
192
193         Reviewed by David Levin.
194
195         check-webkit-style is wrong about indent checking in namespaces
196         in header files and a few other things
197         https://bugs.webkit.org/show_bug.cgi?id=30362
198
199         The few other things include:
200         + check-webkit-style does not require spaces around the equal sign
201           inside 'if' statements and around binary operators that take 
202           numeric literals.
203         + check-webkit-style reports false errors for the / operator
204           when part of a filename in the #include directive.
205
206         * Scripts/modules/cpp_style.py:
207         Improved indentation checking and space checking around
208         binary operators. While the checks are still not perfect,
209         they are clearly better than before.
210         * Scripts/modules/cpp_style_unittest.py:
211         Added test cases for the newly supported checks and modified old
212         test cases to match the new guidelines
213
214 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
215
216         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
217
218         * wx/build/settings.py:
219
220 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
221
222         Reviewed by David Levin.
223
224         Add mod_pywebsocket to test Web Sockets.
225         http://code.google.com/p/pywebsocket/
226         https://bugs.webkit.org/show_bug.cgi?id=27490
227
228         * pywebsocket/COPYING: Added.
229         * pywebsocket/MANIFEST.in: Added.
230         * pywebsocket/README: Added.
231         * pywebsocket/example/echo_client.py: Added.
232         * pywebsocket/example/echo_wsh.py: Added.
233         * pywebsocket/mod_pywebsocket/__init__.py: Added.
234         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
235         * pywebsocket/mod_pywebsocket/handshake.py: Added.
236         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
237         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
238         * pywebsocket/mod_pywebsocket/standalone.py: Added.
239         * pywebsocket/mod_pywebsocket/util.py: Added.
240         * pywebsocket/setup.py: Added.
241         * pywebsocket/test/config.py: Added.
242         * pywebsocket/test/mock.py: Added.
243         * pywebsocket/test/run_all.py: Added.
244         * pywebsocket/test/test_dispatch.py: Added.
245         * pywebsocket/test/test_handshake.py: Added.
246         * pywebsocket/test/test_mock.py: Added.
247         * pywebsocket/test/test_msgutil.py: Added.
248         * pywebsocket/test/test_util.py: Added.
249         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
250         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
251         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
252         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
253         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
254         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
255         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
256         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
257
258 2009-10-15  James Robinson  <jamesr@google.com>
259
260         Reviewed by David Levin.
261
262         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
263
264         https://bugs.webkit.org/show_bug.cgi?id=30426
265
266         * Scripts/modules/cpp_style.py:
267         * Scripts/modules/cpp_style_unittest.py:
268
269 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
270
271         Reviewed by Adam Roben.
272
273         Fixes <http://webkit.org/b/30411>.
274         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
275         
276         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
277         building Chromium.
278
279         * Scripts/pdevenv:
280
281 2009-10-15  Robin Dunn  <robin@alldunn.com>
282
283         Reviewed by Kevin Ollivier.
284
285         Add Mac package building scripts for wx.
286         
287         https://bugs.webkit.org/show_bug.cgi?id=30405
288
289         * wx/build/build_utils.py:
290         * wx/build/settings.py:
291         * wx/packaging/build-mac-installer.py: Added.
292
293 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
294
295         Reviewed by Gustavo Noronha.
296
297         Enable Web Sockets support when running layout tests.
298
299         * DumpRenderTree/gtk/DumpRenderTree.cpp:
300         (resetDefaultsToConsistentValues):
301
302 2009-10-15  Xan Lopez  <xlopez@igalia.com>
303
304         Reviewed by Gustavo Noronha.
305
306         Need to initialize event.button.button, since in most cases a
307         button number is not passed as an argument.
308
309         * DumpRenderTree/gtk/EventSender.cpp:
310         (mouseDownCallback):
311         (mouseUpCallback):
312
313 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
314
315         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
316         the OS if none was explicitly set.
317
318         * wx/build/settings.py:
319
320 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
321
322         Reviewed by Timothy Hatcher.
323
324         Web Inspector: enable developers extras within inspector layout tests.
325
326         https://bugs.webkit.org/show_bug.cgi?id=30014
327
328         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
329         (LayoutTestController::showWebInspector):
330         (LayoutTestController::closeWebInspector):
331         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
332         (LayoutTestController::showWebInspector):
333         (LayoutTestController::closeWebInspector):
334
335 2009-10-14  José Millán Soto  <jmillan@igalia.com>
336
337         Reviewed by Jan Alonzo.
338
339         GtkLauncher is using a deprecated signal
340         https://bugs.webkit.org/show_bug.cgi?id=30364
341
342         Modified GtkLauncher to use notify::title signal instead of
343         deprecated title-changed signal
344
345         * GtkLauncher/main.c:
346         (notify_title_cb):
347         (create_browser):
348
349 2009-10-14  Brady Eidson  <beidson@apple.com>
350
351         Reviewed by Sam Weinig.
352
353         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
354         1 - Disables WebHistory
355         2 - Doesn't make sense in that context anyway.
356
357         * DumpRenderTree/win/DumpRenderTree.cpp:
358         (createWebViewAndOffscreenWindow):
359
360 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
361
362         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
363         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
364
365         * wx/build/settings.py:
366         * wx/install-unix-extras:
367
368 2009-10-14  Brady Eidson  <beidson@apple.com>
369
370         Reviewed by Sam Weinig.
371
372         WebKit Win API should provide a delegate interface for global history.
373         https://bugs.webkit.org/show_bug.cgi?id=29905
374
375         * DumpRenderTree/LayoutTestController.cpp:
376         (LayoutTestController::LayoutTestController):
377         * DumpRenderTree/LayoutTestController.h:
378         (LayoutTestController::dumpHistoryDelegateCallbacks):
379         (LayoutTestController::setDumpHistoryDelegateCallbacks):
380                 
381         * DumpRenderTree/win/DumpRenderTree.cpp:
382         (shouldLogHistoryDelegates):
383         (runTest):
384         (createWebViewAndOffscreenWindow):
385         (main):
386         * DumpRenderTree/win/DumpRenderTree.vcproj:
387         
388         Add the IWebHistoryDelegate to DRT Windows:
389         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
390         (wstringFromBSTR):
391         (HistoryDelegate::HistoryDelegate):
392         (HistoryDelegate::~HistoryDelegate):
393         (HistoryDelegate::QueryInterface):
394         (HistoryDelegate::AddRef):
395         (HistoryDelegate::Release):
396         (HistoryDelegate::didNavigateWithNavigationData):
397         (HistoryDelegate::didPerformClientRedirectFromURL):
398         (HistoryDelegate::didPerformServerRedirectFromURL):
399         (HistoryDelegate::updateHistoryTitle):
400         (HistoryDelegate::populateVisitedLinksForWebView):
401         * DumpRenderTree/win/HistoryDelegate.h: Added.
402
403         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
404         (LayoutTestController::removeAllVisitedLinks):
405
406 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
407
408         Reviewed by Simon Hausmann.
409
410         [Qt] Implement support for setPOSIXLocale on Qt.
411         https://bugs.webkit.org/show_bug.cgi?id=30268 
412  
413         * DumpRenderTree/qt/DumpRenderTree.cpp:
414         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
415         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
416         (LayoutTestController::setPOSIXLocale):
417         * DumpRenderTree/qt/LayoutTestControllerQt.h:
418
419 2009-10-13  Stephanie Lewis  <slewis@apple.com>
420
421         Unreviewed, adding myself to reviewers list.
422
423         * Scripts/modules/committers.py:
424
425 2009-10-13  Stephanie Lewis  <slewis@apple.com>
426
427         Reviewed by Mark Rowe.
428
429         Fix null assignment so root tests work again.
430
431         * Scripts/webkitdirs.pm:
432
433 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
434
435         Reviewed by Simon Hausmann.
436
437         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
438         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
439         This is done in preparation of implementing missing features in DRT.
440         No functionality changes made yet.
441
442         * DumpRenderTree/qt/DumpRenderTree.cpp:
443         * DumpRenderTree/qt/DumpRenderTree.pro:
444         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
445         (EventSender::EventSender):
446         (EventSender::mouseDown):
447         (EventSender::mouseUp):
448         (EventSender::mouseMoveTo):
449         (EventSender::leapForward):
450         (EventSender::keyDown):
451         (EventSender::contextClick):
452         (EventSender::scheduleAsynchronousClick):
453         (EventSender::frameUnderMouse):
454         * DumpRenderTree/qt/EventSenderQt.h: Added.
455         (EventSender::clearKillRing):
456         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
457         (LayoutTestController::LayoutTestController):
458         (LayoutTestController::reset):
459         (LayoutTestController::processWork):
460         (LayoutTestController::maybeDump):
461         (LayoutTestController::waitUntilDone):
462         (LayoutTestController::notifyDone):
463         (LayoutTestController::windowCount):
464         (LayoutTestController::clearBackForwardList):
465         (LayoutTestController::dumpEditingCallbacks):
466         (LayoutTestController::dumpResourceLoadCallbacks):
467         (LayoutTestController::queueBackNavigation):
468         (LayoutTestController::queueForwardNavigation):
469         (LayoutTestController::queueLoad):
470         (LayoutTestController::queueReload):
471         (LayoutTestController::queueScript):
472         (LayoutTestController::provisionalLoad):
473         (LayoutTestController::timerEvent):
474         (LayoutTestController::encodeHostName):
475         (LayoutTestController::decodeHostName):
476         (LayoutTestController::setJavaScriptProfilingEnabled):
477         (LayoutTestController::setFixedContentsSize):
478         (LayoutTestController::setPrivateBrowsingEnabled):
479         (LayoutTestController::setPopupBlockingEnabled):
480         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
481         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
482         (LayoutTestController::numberOfActiveAnimations):
483         (LayoutTestController::disableImageLoading):
484         (LayoutTestController::dispatchPendingLoadRequests):
485         (LayoutTestController::setDatabaseQuota):
486         (LayoutTestController::clearAllDatabases):
487         (LayoutTestController::whiteListAccessFromOrigin):
488         (LayoutTestController::waitForPolicyDelegate):
489         (LayoutTestController::overridePreference):
490         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
491         (LayoutTestController::isLoading):
492         (LayoutTestController::setLoading):
493         (LayoutTestController::shouldDumpAsText):
494         (LayoutTestController::shouldDumpBackForwardList):
495         (LayoutTestController::shouldDumpChildrenAsText):
496         (LayoutTestController::shouldDumpDatabaseCallbacks):
497         (LayoutTestController::shouldDumpStatusCallbacks):
498         (LayoutTestController::shouldWaitUntilDone):
499         (LayoutTestController::canOpenWindows):
500         (LayoutTestController::shouldDumpTitleChanges):
501         (LayoutTestController::waitForPolicy):
502         (LayoutTestController::dumpAsText):
503         (LayoutTestController::dumpChildFramesAsText):
504         (LayoutTestController::dumpDatabaseCallbacks):
505         (LayoutTestController::dumpStatusCallbacks):
506         (LayoutTestController::setCanOpenWindows):
507         (LayoutTestController::dumpBackForwardList):
508         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
509         (LayoutTestController::display):
510         (LayoutTestController::dumpTitleChanges):
511         (LayoutTestController::dumpSelectionRect):
512         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
513         (TextInputController::TextInputController):
514         (TextInputController::doCommand):
515         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
516         * DumpRenderTree/qt/WorkQueue.cpp:
517         * DumpRenderTree/qt/WorkQueue.h:
518         * DumpRenderTree/qt/WorkQueueItem.h:
519         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
520         (findFrameNamed):
521         (LoadItem::invoke):
522         (ReloadItem::invoke):
523         (ScriptItem::invoke):
524         (BackForwardItem::invoke):
525         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
526         * DumpRenderTree/qt/jsobjects.h:
527
528 2009-10-13  Dmitry Titov  <dimich@chromium.org>
529
530         Not reviewed, adding myself to the list of reviewers.
531
532         * Scripts/modules/committers.py:
533
534 2009-10-13  Anders Carlsson  <andersca@apple.com>
535
536         Reviewed by Sam Weinig.
537
538         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
539
540         Make the private browsing mode testable by the test plug-in.
541         
542         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
543         (pluginGetProperty):
544         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
545         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
546         (NPP_New):
547         (NPP_SetValue):
548
549 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
550
551         No review, just adding self to the list of reviewers.
552
553         * Scripts/modules/committers.py:
554
555 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
556
557         Reviewed by Adam Roben.
558
559         Web Inspector: Use proper web view in inspector layout
560         tests for windows.
561
562         https://bugs.webkit.org/show_bug.cgi?id=30298
563
564         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
565         (LayoutTestController::showWebInspector):
566         (LayoutTestController::closeWebInspector):
567         (LayoutTestController::evaluateInWebInspector):
568
569 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
570
571         Reviewed by Sam Weinig.
572
573         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
574         https://bugs.webkit.org/show_bug.cgi?id=29841
575
576         * DumpRenderTree/mac/DumpRenderTree.mm:
577         (resetDefaultsToConsistentValues):
578         * DumpRenderTree/win/DumpRenderTree.cpp:
579         (resetDefaultsToConsistentValues):
580
581 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
582
583         Reviewed by Dimitri Glazkov.
584
585         Chromium Port - Windows
586         https://bugs.webkit.org/show_bug.cgi?id=29969
587
588         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
589         * Scripts/webkitdirs.pm:
590
591 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
592
593         Reviewed by Darin Adler.
594
595         jsc scripts cleanup and Qt/GTK fix
596         https://bugs.webkit.org/show_bug.cgi?id=30288
597
598         Duplicated jscPath() moved to webkitdirs.pm.
599         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
600         Configuration added (release/debug) to path for Qt-port on Windows.
601
602         * Scripts/run-javascriptcore-tests:
603         * Scripts/run-jsc:
604         * Scripts/run-sunspider:
605         * Scripts/sunspider-compare-results:
606         * Scripts/webkitdirs.pm:
607
608 2009-10-11  Adam Barth  <abarth@webkit.org>
609
610         Unreviewed.  Add Collin to committers.py.
611
612         * Scripts/modules/committers.py:
613
614 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
615
616         wx build fix, add bindings to source/include dirs now that there are sources there.
617
618         * wx/build/settings.py:
619
620 2009-10-09  Mark Rowe  <mrowe@apple.com>
621
622         Reviewed by Brady Eidson.
623
624         Enable plug-in halting in DumpRenderTree.
625
626         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
627         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
628
629         * DumpRenderTree/mac/DumpRenderTree.mm:
630         (resetDefaultsToConsistentValues):
631         * DumpRenderTree/mac/UIDelegate.mm:
632         (-[UIDelegate webView:shouldHaltPlugin:]):
633
634 2009-10-08  Brady Eidson  <beidson@apple.com>
635
636         Reviewed by Dan Bernstein.
637
638         Ask the History Delegate to populate the visited links hash.
639         <rdar://problem/7285293> and https://webkit.org/b/29904
640
641         Add the ability for LayoutTestController to clear all visited links.
642         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
643
644         * DumpRenderTree/LayoutTestController.cpp:
645         (LayoutTestController::LayoutTestController):
646         (removeAllVisitedLinksCallback):
647         (LayoutTestController::staticFunctions):
648         * DumpRenderTree/LayoutTestController.h:
649         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
650         (LayoutTestController::removeAllVisitedLinks):
651
652         * DumpRenderTree/mac/HistoryDelegate.mm:
653         (-[HistoryDelegate populateVisitedLinksForWebView:]):
654
655         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
656         (LayoutTestController::removeAllVisitedLinks):
657         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
658         (LayoutTestController::removeAllVisitedLinks):
659         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
660         (LayoutTestController::removeAllVisitedLinks):
661
662
663 2009-10-08  Daniel Bates  <dbates@webkit.org>
664
665         Reviewed by Adam Roben.
666
667         https://bugs.webkit.org/show_bug.cgi?id=30175
668         
669         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
670         the OLE drag-and-drop return value like the function it emulates. Currently, 
671         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
672         whether the drag-and-drop operation was successful or was cancelled.
673         
674         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
675         return value according to whether the drop operation was successful or not.
676
677         * DumpRenderTree/win/EventSender.cpp:
678         (doMouseUp): Added parameter oleDragAndDropReturnValue.
679         (replaySavedEvents): Ditto.
680         * DumpRenderTree/win/EventSender.h:
681         * DumpRenderTree/win/UIDelegate.cpp:
682         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
683
684 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
685
686         Reviewed by Xan Lopez.
687
688         [GTK] Added support for a parameter setting the button that was
689         pressed in the mouseDown function.
690         https://bugs.webkit.org/show_bug.cgi?id=30220
691
692         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
693
694 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
695
696         Reviewed by Xan Lopez.
697
698         [GTK] Added a line to the bottom of the expected result to match
699         the output of the test.
700         https://bugs.webkit.org/show_bug.cgi?id=30220
701
702         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
703         expected.txt:
704
705 2009-10-08  Adam Roben  <aroben@apple.com>
706
707         Use QueryInterface to get IWebInspectorPrivate
708
709         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
710         accessed in a more standard way
711
712         Reviewed by John Sullivan and Tim Hatcher.
713
714         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
715         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
716         by calling IWebViewPrivate::inspector, then use QueryInterface to get
717         to the IWebInspectorPrivate interface.
718
719 2009-10-07  Adam Roben  <aroben@apple.com>
720
721         Implement DRT support for origin whitelisting
722
723         Fixes <http://webkit.org/b/30185>.
724
725         Reviewed by Eric Seidel.
726
727         * DumpRenderTree/win/DumpRenderTree.cpp:
728         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
729         whitelist, to match Mac DRT.
730         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
731         (LayoutTestController::whiteListAccessFromOrigin): Call through to
732         IWebViewPrivate::whiteListAccessFromOrigin.
733
734 2009-10-07  Brady Eidson  <beidson@apple.com>
735
736         Reviewed by Darin Adler.
737
738         Send title changes to the global history delegate.
739         <rdar://problem/7285293> and https://webkit.org/b/29904
740
741         * DumpRenderTree/mac/HistoryDelegate.mm:
742         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
743
744 2009-10-07  Adam Barth  <abarth@webkit.org>
745
746         Unreviewed.  Remove some folks from committers.py who were listed on
747         the WebKit Team wiki page but who weren't actually listed as commit+.
748         At some point, we should coorelate this list with the committers
749         mailing list.
750
751         * Scripts/modules/committers.py:
752
753 2009-10-07  Adam Barth  <abarth@webkit.org>
754
755         Unreviewed.  Import a bunch of committers from the WebKit Team page on
756         the wiki into committers.py.
757
758         * Scripts/modules/committers.py:
759
760 2009-10-07  Adam Barth  <abarth@webkit.org>
761
762         Unreviewed.  Added Aaron Boodman to committers.py.
763
764         * Scripts/modules/committers.py:
765
766 2009-10-07  Evan Martin  <evan@chromium.org>
767
768         Reviewed by Darin Adler.
769
770         Add API to LayoutTestController for re/setting the system locale.
771         https://bugs.webkit.org/show_bug.cgi?id=18994
772
773         * DumpRenderTree/LayoutTestController.cpp:
774         (setLocaleCallback):
775         (LayoutTestController::staticFunctions):
776         (LayoutTestController::setLocale):
777         * DumpRenderTree/LayoutTestController.h:
778
779 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
780
781         Reviewed by Jan Alonzo.
782
783         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
784         https://bugs.webkit.org/show_bug.cgi?id=29689
785
786         Build fix by adding -lfontconfig for DumpRenderTree.
787
788         * GNUmakefile.am:
789
790 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
791
792         Reviewed by Simon Hausmann.
793
794         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
795
796         * Scripts/run-webkit-tests:
797
798 2009-10-07  Xan Lopez  <xlopez@igalia.com>
799
800         Reviewed by Gustavo Noronha.
801
802         "delete" in EventSender is the backspace key, not the delete one.
803
804         * DumpRenderTree/gtk/EventSender.cpp:
805         (keyDownCallback):
806
807 2009-10-07  Xan Lopez  <xlopez@igalia.com>
808
809         Reviewed by Gustavo Noronha.
810
811         getChildrenWithRange expects as last parameter the end index, not
812         the length of the range. Correct this and clarify the variable
813         names to reflect how the code works.
814
815         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
816         (AccessibilityUIElement::getChildrenWithRange):
817         (AccessibilityUIElement::getChildAtIndex):
818
819 2009-10-06  Mark Rowe  <mrowe@apple.com>
820
821         Reviewed by Simon Fraser.
822
823         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
824
825         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
826         the fact we have already changed the working directory to the top of the open source tree.
827
828 2009-10-06  Julie Parent  <jparent@chromium.org>
829
830         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
831         rather than my committer email.
832
833         * Scripts/modules/committers.py:
834
835 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
836
837         Reviewed by Eric Seidel.
838
839         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
840
841         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
842         it after each layout test as it should do, making the DRT dump additional output
843         for all of the subsequent layout tests.
844
845         * DumpRenderTree/qt/jsobjects.cpp:
846         (LayoutTestController::reset):
847
848 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
849
850         Reviewed by Simon Hausmann.
851
852         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
853         fast/dom/assign-to-window-status.html test, which is passing as a result.
854
855         https://bugs.webkit.org/show_bug.cgi?id=30127
856
857         * DumpRenderTree/qt/DumpRenderTree.cpp:
858         (WebCore::DumpRenderTree::DumpRenderTree):
859         (WebCore::DumpRenderTree::statusBarMessage):
860         * DumpRenderTree/qt/DumpRenderTree.h:
861         * DumpRenderTree/qt/jsobjects.h:
862         (LayoutTestController::shouldDumpStatusCallbacks):
863         (LayoutTestController::dumpStatusCallbacks):
864
865 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
866
867         Reviewed by Simon Hausmann.
868
869         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
870         ignores the argument indicating which mouse button to trigger.
871         https://bugs.webkit.org/show_bug.cgi?id=30048
872
873         This affects the fast/events/mouse-click-events.html layout test.
874
875         * DumpRenderTree/qt/jsobjects.cpp:
876         (EventSender::mouseDown):
877         (EventSender::mouseUp):
878         * DumpRenderTree/qt/jsobjects.h:
879
880 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
881
882         Reviewed by Simon Hausmann.
883
884         [Qt] Fix the EventSender::keyDown() implementation
885         https://bugs.webkit.org/show_bug.cgi?id=30043
886
887         It should post both a key press event and a key release event,
888         just like other ports do.
889
890         * DumpRenderTree/qt/jsobjects.cpp:
891         (EventSender::keyDown):
892
893 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
894
895         wx build fix. Add jpeg to the list of libs to link against.
896
897         * wx/build/settings.py:
898
899 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
900
901         Reviewed by Simon Hausmann.
902
903         [Qt] EventSender::keyDown() cannot send function-key events.
904         https://bugs.webkit.org/show_bug.cgi?id=30044
905
906         This affects the fast/events/keydown-function-keys.html layout test.
907
908         * DumpRenderTree/qt/jsobjects.cpp:
909         (EventSender::keyDown):
910
911 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
912
913         Added --wx-compiler-prefix waf option to allow building wxWebKit with
914         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
915
916         * wx/build/settings.py:
917         * wx/build/wxpresets.py:
918
919 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
920
921         Reviewed by Timothy Hatcher.
922
923         Web Inspector: add testing harness for Web Inspector.
924
925         https://bugs.webkit.org/show_bug.cgi?id=30010
926
927         * DumpRenderTree/LayoutTestController.cpp:
928         (showWebInspectorCallback):
929         (closeWebInspectorCallback):
930         (evaluateInWebInspectorCallback):
931         (LayoutTestController::staticFunctions):
932         * DumpRenderTree/LayoutTestController.h:
933         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
934         (LayoutTestController::showWebInspector):
935         (LayoutTestController::closeWebInspector):
936         (LayoutTestController::evaluateInWebInspector):
937         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
938         (LayoutTestController::showWebInspector):
939         (LayoutTestController::closeWebInspector):
940         (LayoutTestController::evaluateInWebInspector):
941         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
942         (LayoutTestController::showWebInspector):
943         (LayoutTestController::closeWebInspector):
944         (LayoutTestController::evaluateInWebInspector):
945         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
946         (LayoutTestController::showWebInspector):
947         (LayoutTestController::closeWebInspector):
948         (LayoutTestController::evaluateInWebInspector):
949
950 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
951
952         Reviewed by Ariyha Hidayat.
953
954         Pass arguments to system() as a string instead of array
955
956         When passed as an array entries with a space fail to translate
957         to two arguments to the child process, so instead of manually
958         splitting all the entries in @buildArgs we pass the whole thing
959         as a string instead.
960
961         * Scripts/webkitdirs.pm:
962
963 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
964
965         Reviewed by David Levin.
966
967         check-webkit-style misses whitespace errors for operators:
968         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
969         https://bugs.webkit.org/show_bug.cgi?id=30021
970
971         * Scripts/modules/cpp_style.py:
972         Added the operators mentioned above to the same list as == and !=.
973
974 2009-10-02  Julie Parent  <jparent@chromium.org>
975
976         Unreviewed.
977
978         Adding myself and Ojan Vafai as committers, because we are committers.
979
980         * Scripts/modules/committers.py:
981
982 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
983
984         Reviewed by Adam Roben.
985
986         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
987         this will help the patch merging process when TryBots are used.
988
989         * Scripts/svn-create-patch:
990
991 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
992
993         Reviewed by Simon Hausmann.
994
995         [Qt] Implement layoutTestController.overridePreference().
996         https://bugs.webkit.org/show_bug.cgi?id=29970
997
998         * DumpRenderTree/qt/DumpRenderTree.cpp:
999         (WebCore::WebPage::WebPage):
1000         (WebCore::WebPage::resetSettings):
1001         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1002         * DumpRenderTree/qt/jsobjects.cpp:
1003         (LayoutTestController::reset):
1004         (LayoutTestController::setPrivateBrowsingEnabled):
1005         (LayoutTestController::setPopupBlockingEnabled):
1006         (LayoutTestController::overridePreference):
1007         * DumpRenderTree/qt/jsobjects.h:
1008
1009 2009-10-01  Chris Marrin  <cmarrin@apple.com>
1010
1011         Reviewed by Oliver Hunt.
1012
1013         Turn on ENABLE_3D_CANVAS in TOT
1014         https://bugs.webkit.org/show_bug.cgi?id=29906
1015
1016         * Scripts/build-webkit:
1017
1018 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1019
1020         Rubberstamped by Simon Hausmann.
1021
1022         Enable HTTP tests for Qt
1023
1024         * Scripts/run-webkit-tests:
1025
1026 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
1027
1028         Reviewed by Dimitri Glazkov.
1029
1030         build-webkit --chromium now also works on cygwin.
1031
1032         https://bugs.webkit.org/show_bug.cgi?id=29973
1033
1034         * Scripts/webkitdirs.pm:
1035
1036 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
1037
1038         Reviewed by Simon Hausmann.
1039
1040         [Qt] Don't use TCmalloc in DumpRenderTree
1041         https://bugs.webkit.org/show_bug.cgi?id=27029
1042
1043         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
1044
1045         * DumpRenderTree/qt/DumpRenderTree.pro:
1046
1047 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
1048
1049         Reviewed by Simon Hausmann.
1050
1051         [Qt] Implement eventSender.scheduleAsynchronousClick().
1052
1053         https://bugs.webkit.org/show_bug.cgi?id=29931
1054
1055         * DumpRenderTree/qt/jsobjects.cpp:
1056         (EventSender::scheduleAsynchronousClick):
1057         * DumpRenderTree/qt/jsobjects.h:
1058
1059 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
1060
1061         Reviewed by Simon Hausmann.
1062
1063         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
1064         fast/events/open-window-from-another-frame.html from the Skipped list.
1065
1066         https://bugs.webkit.org/show_bug.cgi?id=29930
1067
1068         * DumpRenderTree/qt/jsobjects.cpp:
1069         (LayoutTestController::setPopupBlockingEnabled):
1070         * DumpRenderTree/qt/jsobjects.h:
1071
1072 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
1073
1074         Unreviewed.
1075
1076         Added myself to the list of committers.
1077
1078         * Scripts/modules/committers.py:
1079
1080 2009-09-30  Eric Seidel  <eric@webkit.org>
1081
1082         No review, just adding Geoff to the list of reviewers.
1083
1084         * Scripts/modules/committers.py:
1085
1086 2009-09-30  Dan Bernstein  <mitz@apple.com>
1087
1088         Reviewed by Sam Weinig.
1089
1090         Added the WebKit Layout Tests fonts that are referenced in
1091         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
1092
1093         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
1094         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
1095
1096 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1097
1098         Reviewed by David Kilzer.
1099
1100         Make sunspider scripts work on Windows platform.
1101         https://bugs.webkit.org/show_bug.cgi?id=29656
1102
1103         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
1104         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
1105         * Scripts/webkitdirs.pm: currentPerlPath() added.
1106
1107 2009-09-29  Brady Eidson  <beidson@apple.com>
1108
1109         Rubberstamped by Dan Bernstein.
1110
1111         Fix license and some sorting in new files.
1112
1113         * DumpRenderTree/mac/HistoryDelegate.h:
1114         * DumpRenderTree/mac/HistoryDelegate.mm:
1115
1116 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
1117
1118         Reviewed by David Kilzer.
1119
1120         Fixed how error codes are handled.
1121         https://bugs.webkit.org/show_bug.cgi?id=29898
1122
1123         * Scripts/update-webkit:
1124         * Scripts/update-webkit-chromium:
1125
1126 2009-09-29  Brady Eidson  <beidson@apple.com>
1127
1128         Reviewed by John Sullivan.
1129
1130         Updated way-out-of-date sorting throughout the dump methods/flags.
1131
1132         * DumpRenderTree/LayoutTestController.cpp:
1133         (LayoutTestController::LayoutTestController):
1134         (dumpAsPDFCallback):
1135         (dumpAsTextCallback):
1136         (dumpFrameLoadCallbacksCallback):
1137         (dumpResourceLoadCallbacksCallback):
1138         (LayoutTestController::staticFunctions):
1139
1140         * DumpRenderTree/LayoutTestController.h:
1141         (LayoutTestController::dumpAsText):
1142         (LayoutTestController::setDumpAsText):
1143         (LayoutTestController::dumpFrameLoadCallbacks):
1144         (LayoutTestController::setDumpFrameLoadCallbacks):
1145         (LayoutTestController::dumpSelectionRect):
1146         (LayoutTestController::setDumpSelectionRect):
1147         (LayoutTestController::dumpSourceAsWebArchive):
1148         (LayoutTestController::setDumpSourceAsWebArchive):
1149         (LayoutTestController::dumpStatusCallbacks):
1150         (LayoutTestController::setDumpStatusCallbacks):
1151         (LayoutTestController::dumpTitleChanges):
1152         (LayoutTestController::setDumpTitleChanges):
1153         (LayoutTestController::dumpWillCacheResponse):
1154         (LayoutTestController::setDumpWillCacheResponse):
1155
1156 2009-09-29  Brady Eidson  <beidson@apple.com>
1157
1158         Reviewed by John Sullivan.
1159
1160         WebKit Mac API should provide a delegate interface for global history.
1161         <rdar://problem/7042773> and https://webkit.org/b/29904
1162
1163         Adding the dumping of global history delegate callbacks.
1164
1165         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1166
1167         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
1168         * DumpRenderTree/mac/DumpRenderTree.mm:
1169         (createWebViewAndOffscreenWindow):
1170         (allocateGlobalControllers):
1171         (shouldLogFrameLoadDelegates):
1172         (shouldLogHistoryDelegates):
1173         (runTest):
1174
1175         Dump history delegate callbacks:
1176         * DumpRenderTree/mac/HistoryDelegate.h: Added.
1177         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
1178         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
1179         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
1180         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
1181
1182 2009-09-29  Daniel Bates  <dbates@webkit.org>
1183
1184         Reviewed by Adam Roben.
1185
1186         https://bugs.webkit.org/show_bug.cgi?id=28902
1187         
1188         Fixes an issue where the drop effect returned by Window Dump Render Tree 
1189         was always DROPEFFECT_NONE (since it was hard coded to do so).
1190         
1191         This patch corrects this issue by determining the actual drop effect 
1192         performed by the corresponding drag-and-drop operation so that we can 
1193         return it.
1194
1195         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
1196         (DraggingInfo::DraggingInfo):
1197         (DraggingInfo::performedDropEffect): Added method.
1198         (DraggingInfo::setPerformedDropEffect): Added method.
1199         * DumpRenderTree/win/EventSender.cpp:
1200         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
1201         Moved delete draggingInfo to UIDelegate::doDragDrop.
1202         * DumpRenderTree/win/UIDelegate.cpp:
1203         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
1204
1205 2009-09-29  Dan Bernstein  <mitz@apple.com>
1206
1207         Reviewed by Adam Roben.
1208
1209         Remove copying of unnecessary or nonexistent files from the ImageDiff
1210         post-build event.
1211
1212         * DumpRenderTree/win/ImageDiff.vcproj:
1213
1214 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1215
1216         Reviewed by David Kilzer.
1217
1218         [Qt] Make build-webkit script work on Windows
1219         https://bugs.webkit.org/show_bug.cgi?id=29802
1220
1221         * Scripts/run-webkit-tests:
1222         * Scripts/webkitdirs.pm:
1223          - Removed unnecessary -p switch for mkdir on Windows.
1224          - Use canonical path, which uses slashes or backslashes depends on platform.
1225          - isWindows() only test for Windows and not for Cyqwin.
1226
1227 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1228
1229         Reviewed by Simon Hausmann.
1230
1231         Fix time measurement in build-webkit after refactoring done in r48853.
1232
1233         * Scripts/build-webkit:
1234
1235 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1236
1237         Reviewed by Tor Arne Vestbø.
1238
1239         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
1240         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
1241
1242         * DumpRenderTree/qt/DumpRenderTree.cpp:
1243         (WebCore::WebPage::WebPage):
1244
1245 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
1246
1247         Reviewed by Simon Hausmann.
1248
1249         [Qt] Implement eventSender.contextClick().
1250         https://bugs.webkit.org/show_bug.cgi?id=29821
1251
1252         * DumpRenderTree/qt/jsobjects.cpp:
1253         (EventSender::contextClick):
1254         * DumpRenderTree/qt/jsobjects.h:
1255
1256 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1257
1258         Reviewed by Eric Seidel.
1259
1260         Add experimentalWebSocketsEnabled in WebPreferences.
1261         https://bugs.webkit.org/show_bug.cgi?id=28941
1262
1263         * DumpRenderTree/mac/DumpRenderTree.mm:
1264         (resetDefaultsToConsistentValues):
1265         * DumpRenderTree/win/DumpRenderTree.cpp:
1266         (resetDefaultsToConsistentValues):
1267
1268 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
1269
1270         Reviewed by David Kilzer.
1271
1272         Integrated chromium port building into webkit tools update-webkit and
1273         build-webkit.
1274
1275         https://bugs.webkit.org/show_bug.cgi?id=29749
1276
1277         * Scripts/build-webkit: When --chromium is specified, will build
1278           the chromium port (currently only Mac is supported).
1279         * Scripts/update-webkit: When --chromium is specified, delegates to
1280           update-webkit-chromium.
1281         * Scripts/webkitdirs.pm: Added chromium specific defs.
1282         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
1283           chromium port's dependencies and update its project files.
1284
1285 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1286
1287         Unreviewed.
1288
1289         Add myself to list of committers.
1290
1291         * Scripts/modules/committers.py:
1292
1293 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1294
1295         Reviewed by Darin Adler.
1296
1297         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
1298         https://bugs.webkit.org/show_bug.cgi?id=29771
1299
1300         * Scripts/run-webkit-tests:
1301
1302 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1303
1304         Reviewed by Simon Hausmann.
1305
1306         [Qt] Implement layoutTestController.waitForPolicyDelegate.
1307         https://bugs.webkit.org/show_bug.cgi?id=25037
1308
1309         * DumpRenderTree/qt/DumpRenderTree.cpp:
1310         (WebCore::WebPage::acceptNavigationRequest):
1311         * DumpRenderTree/qt/DumpRenderTree.pro:
1312         * DumpRenderTree/qt/jsobjects.cpp:
1313         (LayoutTestController::reset):
1314         (LayoutTestController::notifyDone):
1315         (LayoutTestController::waitForPolicyDelegate):
1316         * DumpRenderTree/qt/jsobjects.h:
1317         (LayoutTestController::waitForPolicy):
1318
1319 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1320
1321         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
1322
1323         Reviewed by Eric Seidel.
1324
1325         The -o|--open switch uses the open(1) command on Mac OS X to
1326         open the bug URL in the default web browser.  If there are
1327         similar mechanisms on other platforms, they may be added later.
1328
1329         * Scripts/mark-bug-fixed:
1330         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
1331         options.
1332         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
1333         code into main() and extracted prompting code into
1334         _prompt_user_for_correctness().
1335         (MarkBugFixed._open_bug_in_web_browser): Added.
1336         (MarkBugFixed._prompt_user_for_correctness): Added.
1337         (MarkBugFixed.main): Added logging code from
1338         _determine_bug_id_and_svn_revision().  Added code to call
1339         _open_bug_in_web_browser() if the switch is set.  Added code to
1340         call _prompt_user_for_correctness() when needed.
1341         * Scripts/modules/bugzilla.py:
1342         (Bugzilla.short_bug_url_for_bug_id): Added.
1343
1344 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1345
1346         svn-unapply and svn-apply don't work when used outside multiple svn working directories
1347
1348         <http://webkit.org/b/29744>
1349         <rdar://problem/7252905>
1350
1351         Reviewed by Eric Seidel.
1352
1353         Some users have a workflow where svn-create-patch, svn-apply and
1354         svn-unapply are used outside of multiple svn working
1355         directories.  Instead of aborting the scripts in these cases,
1356         print a warning and assume that Subversion is being used.
1357
1358         * Scripts/VCSUtils.pm:
1359         (determineVCSRoot): Call warn() instead of die() if both isGit()
1360         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
1361         to enforce the assumption about Subversion, then return
1362         determineSVNRoot().
1363         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
1364         VCSUtils.pm.  They both already cache their values and checking
1365         here is redundant since determineVCSRoot() is called later.
1366
1367 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
1368
1369         Reviewed by Gustavo Noronha.
1370
1371         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
1372         https://bugs.webkit.org/show_bug.cgi?id=29689
1373
1374         Load test fonts through FontConfig before each test.
1375         This ensures a more proper rendering of the tests.
1376
1377         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1378         (initializeFonts):
1379         (runTest):
1380         (main):
1381         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
1382         * GNUmakefile.am:
1383
1384 2009-09-25  David Kilzer  <ddkilzer@apple.com>
1385
1386         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
1387
1388         Reviewed by Eric Seidel.
1389
1390         * Scripts/mark-bug-fixed:
1391         (MarkBugFixed.__init__): Added -u|--update-only switch to list
1392         of parse options.
1393         (MarkBugFixed.main): When -u|--update-only is specified, add a
1394         comment to the bug without marking it Resolved/Fixed.
1395
1396 2009-09-25  Darin Adler  <darin@apple.com>
1397
1398         Reviewed by Geoffrey Garen.
1399
1400         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
1401         out, just as we do for the resources directory.
1402
1403 2009-09-25  Adam Barth  <abarth@webkit.org>
1404
1405         Unreviewed.  Added Tony to committers.py because he's a
1406         committer now.
1407
1408         * Scripts/modules/committers.py:
1409
1410 2009-09-25  Eric Seidel  <eric@webkit.org>
1411
1412         Reviewed by Simon Fraser.
1413
1414         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
1415         https://bugs.webkit.org/show_bug.cgi?id=28624
1416
1417         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
1418
1419         * DumpRenderTree/mac/DumpRenderTree.mm:
1420         (resetDefaultsToConsistentValues):
1421
1422 2009-09-25  Eric Seidel  <eric@webkit.org>
1423
1424         Reviewed by Adam Barth.
1425
1426         commit-queue should auto-retry patches which fail to commit due to out of date files
1427         https://bugs.webkit.org/show_bug.cgi?id=28316
1428
1429         * Scripts/bugzilla-tool:
1430          - Handle new CheckoutNeedsUpdate exception.
1431         * Scripts/modules/logging_unittest.py:
1432          - Call the ScriptError constructor correctly (this test had regressed).
1433         * Scripts/modules/scm.py:
1434          - Added the ability to define custom error handlers for run_command
1435            and added a commit_error_handler which throws CheckoutNeedsUpdate
1436            instead of ScriptError.
1437          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
1438         * Scripts/modules/scm_unittest.py:
1439          - Added tests of new error handlers.
1440
1441 2009-09-25  Eric Seidel  <eric@webkit.org>
1442
1443         Reviewed by Adam Barth.
1444
1445         commit-queue should give better feedback when failing a patch
1446         https://bugs.webkit.org/show_bug.cgi?id=29316
1447
1448         * Scripts/bugzilla-tool:
1449          - Update ScriptError uses to the new constructor format.
1450          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
1451            so that we can print to both stdout as well as an output buffer for error reporting.
1452          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
1453          - Use e.message_with_output() when failing a patch (this is the real fix here).
1454            I also removed use of "This patch will require manual commit." as that's not always true.
1455          - Add missing word "bug" from log message.
1456         * Scripts/modules/scm.py:
1457          - Make ScriptError save a bunch more data so that error messages can be nicer.
1458          - Update ScriptError callers.
1459
1460 2009-09-24  John Gregg  <johnnyg@google.com>
1461
1462         Reviewed by Eric Seidel.
1463
1464         Enable switch for notifications (experimental) in Page Settings
1465         https://bugs.webkit.org/show_bug.cgi?id=28930
1466
1467         Now that desktop notifications are controlled by run-time switch,
1468         set that switch to true for DumpRenderTree.
1469
1470         * DumpRenderTree/mac/DumpRenderTree.mm:
1471         (resetDefaultsToConsistentValues):
1472         * DumpRenderTree/win/DumpRenderTree.cpp:
1473         (resetDefaultsToConsistentValues):
1474         * DumpRenderTree/win/UIDelegate.cpp:
1475         (UIDelegate::QueryInterface):
1476
1477 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
1478
1479         wx build fix. SnowLeopard fixes for Mac dependencies.
1480
1481         * wx/build/build_utils.py:
1482         * wx/build/settings.py:
1483         * wx/install-unix-extras:
1484
1485 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1486
1487         Reviewed by Oliver Hunt.
1488
1489         Add support for DRT to send mouse wheel events.
1490
1491         https://bugs.webkit.org/show_bug.cgi?id=29348
1492         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
1493
1494         * DumpRenderTree/gtk/EventSender.cpp:
1495         (mouseWheelToCallback):
1496
1497 2009-09-17  Eric Seidel  <eric@webkit.org>
1498
1499         Reviewed by David Levin.
1500
1501         commit-queue needs web-based status reporting
1502         https://bugs.webkit.org/show_bug.cgi?id=29307
1503
1504         Add a first-pass web-based status for the commit-queue.
1505         The bot is currently reachable at:
1506         http://webkit-commit-queue.appspot.com/
1507
1508         * CommitQueueStatus/app.yaml: Added.
1509          - Application description file required by App Engine.
1510         * CommitQueueStatus/filters/__init__.py: Added.
1511          - Required by python to treat 'filters' as a module.
1512         * CommitQueueStatus/filters/webkit_extras.py: Added.
1513          - Support for turning 'bug 123' and 'patch 123' into links.
1514            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
1515         * CommitQueueStatus/index.html: Added.
1516         * CommitQueueStatus/index.yaml: Added.
1517          - Some auto-generated file from app engine.
1518         * CommitQueueStatus/queue_status.py: Added.
1519          - The core logic of this bot.  We could eventually split this file out into pieces.
1520         * CommitQueueStatus/stylesheets/main.css: Added.
1521          - Some basic lame-o CSS to make the page look less awful.
1522         * CommitQueueStatus/update_status.html: Added.
1523          - The form that the commit-queue (or a human) can use to update the status.
1524         * Scripts/bugzilla-tool:
1525          - Add some very basic update_status calls.
1526         * Scripts/modules/statusbot.py: Added.
1527          - Knows how to post to the CommitQueueStatus web application.
1528
1529 2009-09-24  David Kilzer  <ddkilzer@apple.com>
1530
1531         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
1532
1533         Reviewed by Adam Roben.
1534
1535         * Scripts/mark-bug-fixed:
1536         (MarkBugFixed.__init__): Added -m|--comment switch to list of
1537         parse options.
1538         (MarkBugFixed.main): When specified, prepend comment from
1539         -m|--comment command-line switch to the bug comment.
1540
1541 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1542
1543         Reviewed by Jan Alonzo.
1544
1545         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
1546         https://bugs.webkit.org/show_bug.cgi?id=29693
1547
1548         Show the window, to be able to synthesize events correctly.
1549
1550         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1551         (runTest):
1552         (main):
1553
1554 2009-09-24  Oliver Hunt  <oliver@apple.com>
1555
1556         Reviewed by NOBODY(rollout)
1557
1558         Roll out r48712 as it is incorrect.
1559
1560         * DumpRenderTree/mac/ObjCController.m:
1561         (+[ObjCController isSelectorExcludedFromWebScript:]):
1562         (+[ObjCController webScriptNameForSelector:]):
1563
1564 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
1565
1566         Reviewed by Eric Seidel.
1567
1568         https://bugs.webkit.org/show_bug.cgi?id=29005
1569         The indices of RuntimeArray should be enumerated like for a regular array.
1570
1571         * DumpRenderTree/mac/ObjCController.m:
1572         (+[ObjCController isSelectorExcludedFromWebScript:]):
1573         (+[ObjCController webScriptNameForSelector:]):
1574         (-[ObjCController arrayOfString]):
1575
1576 2009-09-23  David Kilzer  <ddkilzer@apple.com>
1577
1578         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
1579
1580         Reviewed by Darin Adler.
1581
1582         Also fixed a bug where specifying a revision on the command-line
1583         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
1584
1585         * Scripts/bugzilla-tool: Updated module import statements.
1586         (parse_bug_id): Removed.  Moved to bugzilla.py.
1587         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
1588         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
1589         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
1590         (BugzillaTool.__init__): Removed mark-fixed subcommand.
1591         * Scripts/mark-bug-fixed: Added.
1592         * Scripts/modules/bugzilla.py:
1593         (parse_bug_id): Added.  Moved from bugzilla-tool.
1594         * Scripts/modules/comments.py: Added.
1595         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
1596         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
1597
1598 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
1599
1600         Reviewed by Eric Seidel.
1601         
1602          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
1603          "false" in non-implemented stub for setAlwaysAcceptCookies.
1604          https://bugs.webkit.org/show_bug.cgi?id=29661
1605
1606         * DumpRenderTree/win/DumpRenderTree.vcproj:
1607         * DumpRenderTree/win/DumpRenderTree.cpp:
1608
1609 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1610
1611         Reviewed by Xan Lopez.
1612
1613         [GTK] need to dump number of pending unload handlers
1614         https://bugs.webkit.org/show_bug.cgi?id=29685
1615
1616         Implement dumping of the number of pending unload handlers.
1617
1618         The following tests will pass:
1619
1620           fast/loader/unload-form-about-blank.html
1621           fast/loader/unload-form-post-about-blank.html
1622           fast/loader/unload-form-post.html
1623           fast/loader/unload-form.html
1624           fast/loader/unload-hyperlink.html
1625           fast/loader/unload-javascript-url.html
1626           fast/loader/unload-reload.html
1627           fast/loader/unload-window-location.html
1628
1629         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1630         (getFrameNameSuitableForTestResult):
1631         (webViewLoadFinished):
1632
1633 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
1634
1635         Reviewed by Eric Seidel.
1636
1637         js tests should move into jstests subdirectory instead of resources/
1638         https://bugs.webkit.org/show_bug.cgi?id=25880
1639
1640         Remove support of resources directory.
1641
1642         * Scripts/make-script-test-wrappers:
1643
1644 2009-09-22  Eric Seidel  <eric@webkit.org>
1645
1646         No review, only fixing typo (missing space character).
1647
1648         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
1649
1650         * Scripts/run-webkit-tests:
1651
1652 2009-09-22  Eric Seidel  <eric@webkit.org>
1653
1654         Reviewed by Darin Adler.
1655
1656         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
1657         https://bugs.webkit.org/show_bug.cgi?id=29220
1658
1659         * Scripts/run-webkit-tests:
1660
1661 2009-09-22  Eric Seidel  <eric@webkit.org>
1662
1663         Reviewed by David Kilzer.
1664
1665         svn-apply can't handle single-line binary file additions
1666         https://bugs.webkit.org/show_bug.cgi?id=29100
1667
1668         Fixed the regexp and added a unit test.
1669
1670         * Scripts/modules/scm_unittest.py:
1671         * Scripts/svn-apply:
1672
1673 2009-09-11  Eric Seidel  <eric@webkit.org>
1674
1675         Reviewed by David Kilzer.
1676
1677         post-diff and post-commits should be able to find bug urls in ChangeLogs.
1678         https://bugs.webkit.org/show_bug.cgi?id=29206
1679
1680         * Scripts/bugzilla-tool:
1681          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
1682          - Rename --no-comment to --add-log-as-comment and reverse behavior.
1683            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
1684          - Split out code into helper functions to try and make execute() more legible.
1685          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
1686          - Fallback to bug urls in commit diffs, instead of just in commit messages,
1687            meaning post-commits will now find bug urls in ChangeLogs.
1688
1689 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1690
1691         Reviewed by Maciej Stachowiak.
1692
1693         --parse-only parameter wasn't passed to SunSpider/sunspider script.
1694         https://bugs.webkit.org/show_bug.cgi?id=29611
1695
1696         * Scripts/run-sunspider: Missing parameter passing added.
1697
1698 2009-09-20  David Kilzer  <ddkilzer@apple.com>
1699
1700         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
1701
1702         Reviewed by Mark Rowe.
1703
1704         The require statement is like the use statement, except that it
1705         is run during script execution instead of during the 'BEGIN'
1706         phase.  This makes it possible to change @INC before the require
1707         statement is run.  See 'require' and 'use' in the perlfunc(1)
1708         manpage and 'BEGIN' in perlmod(1) manpage.
1709
1710         * Scripts/run-webkit-tests: Replace eval statement with require
1711         statement.
1712
1713 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
1714
1715         wx build fixes. Fix the config name under git and allow users to specify
1716         their own waf install for experimenting with new versions.
1717
1718         * Scripts/webkitdirs.pm:
1719         * wx/build/settings.py:
1720
1721 2009-09-18  Alex Milowski  <alex@milowski.com>
1722
1723         Reviewed by Maciej Stachowiak.
1724
1725         Added checkWebCoreMathMLSupport and hasMathMLSupport to support 
1726         checking for whether MathML tests should be run
1727
1728         * Scripts/run-webkit-tests:
1729         * Scripts/webkitdirs.pm:
1730
1731 2009-08-28  Darin Adler  <darin@apple.com>
1732
1733         Reviewed by Mark Rowe.
1734
1735         Break more of run-webkit-tests into separate functions
1736         https://bugs.webkit.org/show_bug.cgi?id=29497
1737
1738         Some small steps toward improving run-webkit-tests. My goal is to
1739         refactor much more of the script into functions. Later we can add
1740         parallel test running to the tool. But better structure may help
1741         even if someone decides to translate this into another scripting
1742         language instead.
1743
1744         * Scripts/run-webkit-tests: Break more pieces of the script into
1745         seprate functions. Added readSkippedFiles, findTestsToRun, and
1746         printResults functions. Removed custom code to skip results.html
1747         and instead just put it into the ignoredFiles hash. Fixed some
1748         indentation. Sorted function declarations, global variables,
1749         and options at the top of the file alphabetically so they're not
1750         in a semi-random order.
1751
1752 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
1753
1754         wx build fix, add missing dependency.
1755
1756         * wx/browser/wscript:
1757
1758 2009-09-16  Mark Rowe  <mrowe@apple.com>
1759
1760         Split the SnowLeopard build across a few machines.
1761
1762         * BuildSlaveSupport/build.webkit.org-config/config.json:
1763
1764 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
1765
1766         wx build fix to support monolithic builds on Windows.
1767
1768         * wx/build/wxpresets.py:
1769
1770 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
1771
1772         wx build fix, improve debug support and 2.9 support on MSW.
1773
1774         * wx/build/settings.py:
1775         * wx/build/wxpresets.py:
1776
1777 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1778
1779         Blind try at fixing new test failure on Windows.
1780
1781         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1782         (FrameLoadDelegate::didReceiveTitle):
1783
1784 2009-09-15  Alex Milowski  <alex@milowski.com>
1785
1786         Reviewed by Tor Arne Vestbø.
1787
1788         Added mathml toggle
1789
1790         * Scripts/build-webkit:
1791
1792 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
1793
1794         wx build fix. Allow waf build to support Python < 2.6.
1795
1796         * wx/build/waf_extensions.py:
1797
1798 2009-09-14  Chris Marrin  <cmarrin@apple.com>
1799
1800         Reviewed by Oliver Hunt.
1801
1802         Add LayoutTests infrastructure to enable and disable webgl tests.
1803         https://bugs.webkit.org/show_bug.cgi?id=29254
1804
1805         * Scripts/run-webkit-tests:
1806         * Scripts/webkitdirs.pm:
1807
1808 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
1809
1810         Reviewed by Darin Adler.
1811         
1812         Add --iterations option to run-webkit-tests to repeat the tests N times
1813         https://bugs.webkit.org/show_bug.cgi?id=29263
1814
1815         When run with --iterations N, run-webkit-tests will repeat the tests N times.
1816
1817         * Scripts/run-webkit-tests:
1818
1819 2009-09-14  Brady Eidson  <beidson@apple.com>
1820
1821         Not reviewed, maybe should've been:
1822
1823         Cleaning up more Windows-specific fallout from the fix for:
1824         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
1825
1826         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1827         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter, 
1828           and call the correct method to get the Sender.
1829
1830 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
1831
1832         GTK build fix.
1833
1834         Unreviewed.
1835
1836         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1837         (AccessibilityController::setLogScrollingStartEvents):
1838
1839 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
1840
1841         DRT/test part of
1842         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
1843         jumping to a named anchor
1844
1845         https://bugs.webkit.org/show_bug.cgi?id=28899
1846
1847         Reviewed by Adam Roben.
1848
1849         * DumpRenderTree/AccessibilityController.cpp:
1850         (logScrollingStartEventsCallback):
1851         Turn on logging of scrolling start events.
1852         (AccessibilityController::getJSClass):
1853         Add a "logScrollingStartEvents" to the AccessibilityController's JS
1854         class definition.
1855         (AccessibilityController::resetToConsistentState):
1856         Turn off logging of scrolling start events.
1857
1858         * DumpRenderTree/AccessibilityController.h:
1859         Declare setLogScrollingStartEvents(). Add a member for the scrolling
1860         start event hook.
1861
1862         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
1863         (AccessibilityController::setLogScrollingStartEvents):
1864         Stubbed.
1865
1866         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1867         (AccessibilityController::AccessibilityController):
1868         Initialize the handle to 0.
1869         (logEventProc):
1870         Renamed from logFocusEventProc; now logs scrolling start events, too.
1871         Removed the assertion that the event is a focus event. Added a switch
1872         to print a message for focus, scrolling start, and other, unknown
1873         events.
1874         (AccessibilityController::setLogFocusEvents):
1875         Changed to use logEventProc.
1876         (AccessibilityController::setLogScrollingStartEvents):
1877         If turning logging off, unhook the scrolling start event hook, and clear
1878         the member holding the handle. If turning on, query for the root
1879         accessible, so that accessibility is enabled for the WebView, and call
1880         SetWinEventHook to setup an event hook using logEventProc as the
1881         callback function.
1882
1883 2009-09-14  Brady Eidson  <beidson@apple.com>
1884
1885         Windows build fix.
1886
1887         * DumpRenderTree/LayoutTestController.cpp:
1888         (setAuthenticationPasswordCallback):
1889         (setAuthenticationUsernameCallback):
1890         
1891         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1892         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1893
1894 2009-09-14  Brady Eidson  <beidson@apple.com>
1895
1896         Reviewed by Alexey Proskuryakov.
1897
1898         Safari 4 cannot be used to update firmware on Linksys routers.
1899         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
1900
1901         Add the ability for DRT to handle authentication challenges.
1902
1903         * DumpRenderTree/LayoutTestController.cpp:
1904         (setAuthenticationPasswordCallback):
1905         (setAuthenticationUsernameCallback):
1906         (setHandlesAuthenticationChallengesCallback):
1907         (LayoutTestController::staticFunctions):
1908
1909         * DumpRenderTree/LayoutTestController.h:
1910         (LayoutTestController::handlesAuthenticationChallenges):
1911         (LayoutTestController::setHandlesAuthenticationChallenges):
1912         (LayoutTestController::authenticationUsername):
1913         (LayoutTestController::setAuthenticationUsername):
1914         (LayoutTestController::authenticationPassword):
1915         (LayoutTestController::setAuthenticationPassword):
1916
1917         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1918         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1919
1920         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1921         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1922         * DumpRenderTree/win/ResourceLoadDelegate.h:
1923
1924 2009-09-12  Mark Rowe  <mrowe@apple.com>
1925
1926         Reviewed by Dan Bernstein.
1927
1928         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
1929
1930         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
1931         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
1932
1933         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1934         (NPP_New):
1935
1936 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
1937
1938         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
1939
1940         * wx/build/build_utils.py:
1941         * wx/build/settings.py:
1942
1943 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1944
1945         Reviewed by Tor Arne Vestbø.
1946
1947         [Qt] Build fix for windows build.
1948
1949         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
1950
1951 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
1952
1953         Fix typo accidently landed in last commit.
1954
1955         * wx/build/settings.py:
1956
1957 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
1958
1959         wx build fix, error out if using the wrong Python.
1960
1961         * wx/build/settings.py:
1962
1963 2009-09-13  Xan Lopez  <xlopez@igalia.com>
1964
1965         Build fix for GTK+ < 2.14.
1966
1967         Do not use gtk_widget_get_window, access the window directly
1968         through the struct.
1969
1970         * DumpRenderTree/gtk/EventSender.cpp:
1971         (contextClickCallback):
1972         (mouseDownCallback):
1973         (mouseUpCallback):
1974         (mouseMoveToCallback):
1975         (keyDownCallback):
1976
1977 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
1978
1979         Reviewed by Xan Lopez and Jan Alonzo.
1980
1981         [GTK] EventSender does not set 'window' property on synthesized GDK events
1982         https://bugs.webkit.org/show_bug.cgi?id=29169
1983
1984         Set the window property on synthesized GDK events in the GTK+ EventSender.
1985
1986         * DumpRenderTree/gtk/EventSender.cpp:
1987         (contextClickCallback):
1988         (mouseDownCallback):
1989         (mouseUpCallback):
1990         (mouseMoveToCallback):
1991         (keyDownCallback):
1992
1993 2009-09-12  Drew Wilson  <atwilson@google.com>
1994
1995         Reviewed by Mark Rowe.
1996
1997         run-webkit-tests has a timeout value that is too low
1998         https://bugs.webkit.org/show_bug.cgi?id=29223
1999
2000         * Scripts/run-webkit-tests:
2001         Changed timeout value to 20 seconds to avoid timing out too early.
2002
2003 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
2004
2005         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
2006         architectures are supported for building wxWebKit.
2007
2008         * wx/build/settings.py:
2009
2010 2009-09-11  Eric Seidel  <eric@webkit.org>
2011
2012         Reviewed by David Levin.
2013
2014         bugzilla-tool rollout threw exception under svn
2015         https://bugs.webkit.org/show_bug.cgi?id=29211
2016
2017         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
2018         * Scripts/modules/scm_unittest.py: add testing for this fix.
2019
2020 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
2021
2022         Add myself to the committers list.
2023
2024         * Scripts/modules/committers.py:
2025
2026 2009-09-11  Eric Seidel  <eric@webkit.org>
2027
2028         Reviewed by Adam Barth.
2029
2030         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
2031         https://bugs.webkit.org/show_bug.cgi?id=29201
2032
2033         * Scripts/bugzilla-tool:
2034
2035 2009-09-11  Adam Roben  <aroben@apple.com>
2036
2037         Make commit-log-editor move common prefixes to the top of the log
2038
2039         Fies <http://webkit.org/b/29190> commit-log-editor should move common
2040         prefixes to the top of the commit log
2041
2042         Reviewed by Darin Adler.
2043
2044         * Scripts/commit-log-editor: Find and remove the longest common prefix
2045         ending in a double newline from each ChangeLog entry, then put that
2046         common prefix at the top of the commit log.
2047         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
2048         removes, and returns the longest common prefix ending in a double
2049         newline from a hash of strings
2050
2051 2009-09-11  Eric Seidel  <eric@webkit.org>
2052
2053         Fix obvious typo in previous commit, no review.
2054
2055         bugzilla-tool should automate rollouts
2056         https://bugs.webkit.org/show_bug.cgi?id=26715
2057
2058         * Scripts/bugzilla-tool: add back missing "scm" argument.
2059
2060 2009-09-11  Eric Seidel  <eric@webkit.org>
2061
2062         Reviewed by Adam Barth.
2063
2064         bugzilla-tool should automate rollouts
2065         https://bugs.webkit.org/show_bug.cgi?id=26715
2066
2067         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
2068         The --complete-rollout option will automatically land and update the bug.
2069         Eventually --complete-rollout will be default, but that will require more testing.
2070
2071         This first pass is good enough for others to try and file bugs about.
2072
2073         * Scripts/bugzilla-tool:
2074          - Move modified_changelogs into scm.py.
2075          - Move svn_revision_from_commit_text logic into scm.py.
2076          - Add RolloutCommit command.
2077         * Scripts/modules/bugzilla.py:
2078          - Add reopen_bug command used by RolloutCommit.
2079         * Scripts/modules/scm.py:
2080          - Add functions to support RolloutCommit.
2081          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
2082          - Add a str() call so that svn_commit_log can take a numeric argument.
2083          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
2084          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
2085         * Scripts/modules/scm_unittest.py:
2086          - Add read_from_path for easy file reading.
2087          - Put test4 on a new line to make reverts work w/o conflict.
2088          - Add an "svn update" call so that the checkout revision matches the server revision.
2089          - Add tests for svn_revision_from_commit_text.
2090          - Add a simple test for apply_reverse_diff.
2091          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
2092          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
2093
2094 2009-09-11  Adam Roben  <aroben@apple.com>
2095
2096         Get user script/stylesheet tests running on Windows
2097
2098         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
2099         skipped on Windows
2100
2101         Reviewed by John Sullivan.
2102
2103         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
2104         against comsuppw.lib so we can use _bstr_t.
2105
2106         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
2107         order, added #include of comutil.h for _bstr_t.
2108
2109         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
2110         (LayoutTestController::addUserScript):
2111         (LayoutTestController::addUserStyleSheet):
2112         Implemented. Implementations were based on those in
2113         LayoutTestControllerMac.mm.
2114
2115 2009-09-10  David Kilzer  <ddkilzer@apple.com>
2116
2117         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help 
2118
2119         Reviewed by Mark Rowe.
2120
2121         * Scripts/run-webkit-tests: Updated to make -h switch show help.
2122
2123 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
2124
2125         Reviewed by Alexey Proskuryakov.
2126
2127         Add WebCore/websockets directory in wx build system.
2128         https://bugs.webkit.org/show_bug.cgi?id=28038
2129
2130         * wx/build/settings.py:
2131
2132 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
2133
2134         [GTK] EventSender does not properly convert some keyDown strings
2135         https://bugs.webkit.org/show_bug.cgi?id=29119
2136
2137         Add more keyDown string to character code conversions for GTK+ EventSender.
2138
2139         * DumpRenderTree/gtk/EventSender.cpp:
2140         (keyDownCallback):
2141
2142 2009-09-09  Steve Block  <steveblock@google.com>
2143
2144         Reviewed by Maciej Stachowiak.
2145
2146         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
2147         https://bugs.webkit.org/show_bug.cgi?id=29080
2148
2149         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
2150
2151 2009-09-09  Eric Seidel  <eric@webkit.org>
2152
2153         Reviewed by Eric Carlson.
2154
2155         reviewer/committer lookups are backwards
2156         https://bugs.webkit.org/show_bug.cgi?id=29113
2157
2158         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
2159
2160         * Scripts/modules/bugzilla.py:
2161         * Scripts/modules/committers.py:
2162
2163 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2164
2165         Reviewed by Eric Seidel.
2166
2167         svn-unapply doesn't revert directories correctly
2168         https://bugs.webkit.org/show_bug.cgi?id=29065
2169
2170         * Scripts/svn-unapply: Make svnStatus consistently return status
2171         lines including a newline.
2172         * Scripts/svn-apply: Keep svnStatus in sync with the one in
2173         svn-unapply, in lieu of moving it to a common file.
2174
2175 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2176
2177         Reviewed by Eric Seidel.
2178
2179         svn-apply doesn't handle changes to files copied to new directories properly
2180         https://bugs.webkit.org/show_bug.cgi?id=29059
2181
2182         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
2183         additions if we know that we've just copied a file to this name.
2184
2185 2009-09-09  Eric Seidel  <eric@webkit.org>
2186
2187         Reviewed by David Levin.
2188
2189         commit-queue hangs if a builder has never built
2190         https://bugs.webkit.org/show_bug.cgi?id=29091
2191
2192         * Scripts/modules/buildbot.py:
2193         * Scripts/modules/buildbot_unittest.py:
2194
2195 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
2196
2197         Reviewed by Gustavo Noronha.
2198
2199         [GTK] DumpRenderTree needs eventSender object and implementation
2200         https://bugs.webkit.org/show_bug.cgi?id=25990
2201
2202         Implements most of the EventSender object's functionality for
2203         the DumpRenderTree tool. Implementation still lacks support
2204         for drag and drop tests and forward leaps.
2205
2206         Based on work by Holger Hans Peter Freyther.
2207
2208         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2209         (runTest): Focus on the view before loading a new test.
2210         (webViewWindowObjectCleared):
2211         * DumpRenderTree/gtk/EventSender.cpp: Added.
2212         (getDragModeCallback):
2213         (setDragModeCallback):
2214         (leapForwardCallback):
2215         (contextClickCallback):
2216         (updateClickCount):
2217         (mouseDownCallback):
2218         (mouseUpCallback):
2219         (mouseMoveToCallback):
2220         (beginDragWithFilesCallback):
2221         (replaySavedEvents):
2222         (keyDownCallback):
2223         (textZoomInCallback):
2224         (textZoomOutCallback):
2225         (zoomPageInCallback):
2226         (zoomPageOutCallback):
2227         (getClass):
2228         (makeEventSender):
2229         * DumpRenderTree/gtk/EventSender.h: Added.
2230         * GNUmakefile.am: Add build rules for EventSender.
2231
2232 2009-09-09  Daniel Bates  <dbates@webkit.org>
2233
2234         Reviewed by Adam Roben.
2235         
2236         https://bugs.webkit.org/show_bug.cgi?id=28953
2237
2238         Added pre- and post- build events so that on build failure, the file 
2239         buildfailed is written to the directory $(WebKitOutputDir).
2240
2241         * WinLauncher/WinLauncher.vcproj:
2242
2243 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2244
2245         Unreviewed.
2246
2247         Add myself to list of committers.
2248
2249         * Scripts/modules/committers.py:
2250
2251 2009-09-08  Eric Seidel  <eric@webkit.org>
2252
2253         Reviewed by David Levin.
2254
2255         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
2256         https://bugs.webkit.org/show_bug.cgi?id=28605
2257         https://bugs.webkit.org/show_bug.cgi?id=28916
2258
2259         * Scripts/bugzilla-tool:
2260          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
2261            comment now that it's used for rejecting patches for invalid committers too.
2262          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
2263          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
2264         * Scripts/modules/bugzilla.py:
2265          - Make _parse_attachment_element not validate reviewer/committer.
2266          - Share flag parsing code in _parse_attachment_flag.
2267          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
2268          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
2269          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
2270         * Scripts/modules/bugzilla_unittest.py:
2271          - Update this test to no longer expect committer/reviewer validation.
2272         * Scripts/modules/committers.py:
2273          - Return None on failed lookups instead of raising Exceptions.
2274         * Scripts/modules/committers_unittest.py:
2275          - Update tests to expect None returns instead of exceptions.
2276
2277 2009-09-09  David Kilzer  <ddkilzer@apple.com>
2278
2279         <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
2280
2281         Reviewed by Mark Rowe.
2282
2283         No change to layout test results.
2284
2285         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2286         (AccessibilityUIElement::clickPointY): Changed to return y value
2287         instead of x value.
2288
2289 2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>
2290
2291         Reviewed by Mark Rowe.
2292
2293         Reduce dglazkov's boboiness by properly concatenating revision value.
2294
2295         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
2296             rather than "+".
2297
2298 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2299
2300         wxWebKit Python extension build fix - get swig.py if it doesn't exist.
2301
2302         * wx/build/build_utils.py:
2303
2304 2009-09-08  Mark Rowe  <mrowe@apple.com>
2305
2306         Fix an incorrect variable name in UpdateChromiumSource.
2307
2308         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2309
2310 2009-09-08  Mark Rowe  <mrowe@apple.com>
2311
2312         Don't check for leaks on the release SnowLeopard builder.
2313
2314         * BuildSlaveSupport/build.webkit.org-config/config.json:
2315
2316 2009-09-08  Mark Rowe  <mrowe@apple.com>
2317
2318         Add a SnowLeopard release builder.
2319
2320         * BuildSlaveSupport/build.webkit.org-config/config.json:
2321
2322 2009-09-08  David Levin  <levin@chromium.org>
2323
2324         Reviewed by Darin Adler.
2325
2326         Remove end of line whitespace check from check-webkit-style.
2327         https://bugs.webkit.org/show_bug.cgi?id=29053
2328
2329         * Scripts/modules/cpp_style.py:
2330
2331 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2332
2333         Reviewed by Darin Adler.
2334
2335         Fix DumpRenderTree build from clean tree on Tiger
2336         https://bugs.webkit.org/show_bug.cgi?id=28927
2337
2338         * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
2339         DerivedSources/DumpRenderTree directory exists when
2340         building on Tiger.
2341
2342 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2343
2344         wx build fix after introduction of platform/mock directory.
2345
2346         * wx/build/settings.py:
2347
2348 2009-09-08  Yael Aharon  <yael.aharon@nokia.com>
2349
2350         Unreviewed.
2351
2352         Add myself to list of committers.
2353
2354         * Scripts/modules/committers.py:
2355
2356 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2357
2358         Unreviewed.
2359
2360         Add myself to list of committers.
2361
2362         * Scripts/modules/committers.py:
2363
2364 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2365
2366         Reviewed by Darin Adler.
2367
2368         prepare-ChangeLog too chatty on file additions
2369         https://bugs.webkit.org/show_bug.cgi?id=29019
2370
2371         * Scripts/prepare-ChangeLog: Omit description of added properties
2372         on newly added files.
2373
2374 2009-09-08  Steve Block  <steveblock@google.com>
2375
2376         Reviewed by Adam Barth.
2377
2378         Adds a LayoutTestController method to set the permission state for Geolocation.
2379         This is required to use the mock Geolocation service for testing.
2380         https://bugs.webkit.org/show_bug.cgi?id=29027
2381
2382         * DumpRenderTree/LayoutTestController.cpp: Modified.
2383         (setDatabaseQuotaCallback): Modified. Style fix.
2384         (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
2385         (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
2386         * DumpRenderTree/LayoutTestController.h: Modified.
2387         (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
2388         (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
2389         (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
2390         * DumpRenderTree/mac/UIDelegate.mm: Modified.
2391         (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
2392
2393 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2394
2395         Reviewed by Simon Hausmann.
2396
2397         [Qt] QtWebKit single API to enable persistency
2398         https://bugs.webkit.org/show_bug.cgi?id=28682
2399
2400         Use the new enablePersistentStorage API instead 
2401         of enabling all persistent features one-by-one.
2402
2403         * DumpRenderTree/qt/DumpRenderTree.cpp:
2404         (WebCore::WebPage::WebPage):
2405         (WebCore::DumpRenderTree::DumpRenderTree):
2406
2407 2009-09-07  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2408
2409         Reviewed by Tor Arne Vestbø.
2410
2411         Refactor --strict switch to --ignore-metrics and correct the
2412         implementation to make the feature usable on all platforms.
2413         https://bugs.webkit.org/show_bug.cgi?id=28907
2414
2415         run-webkit-tests --ignore-metrics strips the font related metrics from
2416         the actual and expected data before comparing them.
2417         In this way the render trees can be checked for obvious differences but
2418         a successful test implies by no means that the layout is actually correct.
2419
2420         * Scripts/run-webkit-tests:
2421
2422 2009-09-07  Steve Block  <steveblock@google.com>
2423
2424         Reviewed by Adam Barth.
2425
2426         Adds a mock Geolocation service. This will be used to provide predictable behavior of the
2427         Geolocation API for use in LayoutTests. Later changes will integrate the the mock
2428         Geolocation service with DumpRenderTree.
2429         https://bugs.webkit.org/show_bug.cgi?id=28264
2430
2431         * DumpRenderTree/LayoutTestController.cpp: Modified.
2432         (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
2433         (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
2434         (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
2435         * DumpRenderTree/LayoutTestController.h: Modified.
2436         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
2437         (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
2438         (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
2439
2440 2009-09-07  Drew Wilson  <atwilson@google.com>
2441
2442         Reviewed by David Levin.
2443
2444         Enable SHARED_WORKERS by default
2445         https://bugs.webkit.org/show_bug.cgi?id=28959
2446
2447         * Scripts/build-webkit:
2448
2449 2009-09-07  Kevin Ollivier  <kevino@theolliviers.com>
2450
2451         wx build fixes for wx SVN trunk.
2452
2453         * wx/build/settings.py:
2454
2455 2009-09-04  Kevin Ollivier  <kevino@theolliviers.com>
2456
2457         wx build fix. Switch USE_ defines over to the compiler so that they can be
2458         checked by files not including config.h (like WebCorePrefix.h).
2459
2460         * wx/build/settings.py:
2461
2462 2009-09-04  Adam Barth  <abarth@webkit.org>
2463
2464         Unreviewed build fix.
2465
2466         Update declaration of FrameLoadDelegate to reflect that
2467         IWebFrameLoadDelegatePrivate2 inherits from
2468         IWebFrameLoadDelegatePrivate.
2469
2470         * DumpRenderTree/win/FrameLoadDelegate.h:
2471
2472 2009-09-04  Adam Barth  <abarth@webkit.org>
2473
2474         Reviewed by Eric Seidel.
2475
2476         https://bugs.webkit.org/show_bug.cgi?id=24696
2477
2478         Add testing instrumentation for mixed content.
2479
2480         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2481         (-[FrameLoadDelegate webView:]):
2482         (-[FrameLoadDelegate webView:didRunInsecureContent:]):
2483         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2484         (descriptionSuitableForTestResult):
2485         (FrameLoadDelegate::QueryInterface):
2486         (FrameLoadDelegate::didDisplayInsecureContent):
2487         (FrameLoadDelegate::didRunInsecureContent):
2488         * DumpRenderTree/win/FrameLoadDelegate.h:
2489
2490 2009-09-03  Kevin Watters  <kevinwatters@gmail.com>
2491
2492         Reviewed by Kevin Ollivier.
2493
2494         [wx] Frames support
2495         https://bugs.webkit.org/show_bug.cgi?id=19041
2496
2497         * wx/build-wxwebkit:
2498
2499 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2500
2501         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
2502
2503         Reviewed by Eric Seidel.
2504
2505         This fixes "svn-apply --force" and adds unit tests for the
2506         scm.apply_patch() method which uses this script.
2507
2508         * Scripts/svn-apply: Created $globalExitCode variable that
2509         defaults to 0.  Exit with a value of $globalExitCode when the
2510         script is finished.
2511         (applyPatch): Ignore a non-zero $exitCode if $force is true, but
2512         set $globalExitCode to $exitCode so that svn-apply exits with a
2513         non-zero status if any patches did not apply cleanly.  Also
2514         print out the actual patch command if $force was not true.
2515
2516         * Scripts/modules/scm.py:
2517         (scripts_directory): Added.  Extracted from script_path().
2518         (script_path): Extracted scripts_directory().
2519         * Scripts/modules/scm_unittest.py: Import urllib.
2520         (SVNTestRepository.setup): Save the original working directory
2521         in test_object since this represents the WebKit repository from
2522         where the unit tests are run.
2523         (SCMTest): Created new super class to hold utility methods.
2524         (SCMTest._create_patch): Creates a patch file on disk and a
2525         dictionary for use with scm.svn_apply().
2526         (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink
2527         back to WebKitTools/Scripts in the test repository so that
2528         scm.apply_patch() is able to find the svn-apply script.
2529         (SVNTest): Inherit from SCMTest instead of unittest.TestCase.
2530         (SVNTest.tearDown): Make sure to change directories back to the
2531         original_path before the next test.
2532         (SVNTest.test_apply_svn_patch): New test case for applying an
2533         svn patch with scm.apply_patch().
2534         (SVNTest.test_apply_svn_patch_force): New test case for applying
2535         an svn patch with scm.apply_patch() that conflicts.
2536         (GitTest): Inherit from SCMTest instead of unittest.TestCase.
2537         (GitTest.tearDown): Make sure to change directories back to the
2538         original_path before the next test.
2539         (GitTest.test_apply_git_patch): New test case for applying a git
2540         patch with scm.apply_patch().
2541         (GitTest.test_apply_git_patch_force): New test case for applying
2542         a git patch with scm.apply_patch() that conflicts.
2543
2544 2009-09-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2545
2546         Reviewed by Mark Rowe.
2547
2548         [Qt] Add support for platform-spesific layout-test results
2549
2550         For the Qt port we use the qt-[mac|linux|win] directories and then fall
2551         back to the generic qt directory for both test results and skipped list.
2552
2553         * Scripts/run-webkit-tests:
2554         * Scripts/webkitdirs.pm:
2555
2556 2009-09-02  Laurent Cerveau  <lcerveau@me.com>
2557
2558         Reviewed by David Kilzer.
2559
2560         <http://webkit.org/b/25517> build-webkit script should print build time at end
2561
2562         * Scripts/build-webkit:
2563         Added startTime and endTime variable so that the build time is computed and printed as
2564         part of the build message; display formatting has been separated in a dedicated subroutine.
2565
2566 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2567
2568         <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root
2569
2570         Reviewed by Eric Seidel.
2571
2572         * Scripts/VCSUtils.pm:
2573         (determineSvnRoot): Added back check for repository root that
2574         was removed in r46134 when this code lived in svn-create-patch.
2575         It's necessary to check both the repository root and the
2576         repository UUID in case two different working directories are
2577         checked out from the same repository.
2578
2579 2009-09-02  Timothy Hatcher  <timothy@apple.com>
2580
2581         Use new 512x512 icons for nightly builds.
2582
2583         Rubber-stamped by Mark Rowe.
2584
2585         * WebKitLauncher/webkit.icns:
2586
2587 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
2588
2589         waf build fix. Remove local variable shadowing global.
2590
2591         * wx/build/settings.py:
2592
2593 2009-09-02  Zan Dobersek  <zandobersek@gmail.com>
2594
2595         Reviewed by David Kilzer.
2596
2597         Calls exitStatus function from the main package where it is also defined.
2598
2599         * Scripts/VCSUtils.pm:
2600
2601 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
2602
2603         waf build fixes for Windows/MSVC and Mac/Snow Leopard.
2604
2605         * wx/browser/wscript:
2606         * wx/build/build_utils.py:
2607         * wx/build/settings.py:
2608
2609 2009-08-10  Kevin Ollivier  <kevino@theolliviers.com>
2610
2611         Reviewed by Eric Seidel.
2612
2613         Changes needed for build-webkit to support the waf build system for the wx port.
2614         
2615         https://bugs.webkit.org/show_bug.cgi?id=27619
2616
2617         * Scripts/build-webkit:
2618         * Scripts/run-launcher:
2619         * Scripts/webkitdirs.pm:
2620
2621 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2622
2623         <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts
2624
2625         Reviewed by Eric Seidel.
2626
2627         * Scripts/update-webkit: Added "--accept postpone" to
2628         @svnOptions when running with svn-1.6 or newer.
2629
2630 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2631
2632         Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()
2633
2634         Reviewed by Eric Seidel.
2635
2636         * Scripts/VCSUtils.pm:
2637         (@EXPORT): Added &isSVNVersion16OrNewer.
2638         (svnVersion): Added.  Internal method that gets the SVN version
2639         and caches it.
2640         (isSVNVersion16OrNewer): Added.  Method that does the SVN 1.6
2641         version check.
2642         * Scripts/prepare-ChangeLog: Switched to use new
2643         isSVNVersion16OrNewer() method.
2644         * Scripts/resolve-ChangeLogs: Ditto.
2645         * Scripts/svn-create-patch: Ditto.
2646
2647 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2648
2649         Clean up VCSUtils.pm
2650
2651         Reviewed by Eric Seidel.
2652
2653         * Scripts/VCSUtils.pm: Added proper package statement.  Fixed
2654         indentation of BEGIN block.  Listed each exported method on a
2655         line by itself.  Added methods to the export list after adding
2656         the package statement.  Sorted module variables.  Moved
2657         definiton of $gitRoot next to other module variables.
2658
2659 2009-09-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2660
2661         Rubber-stamped by Simon Hausmann.
2662
2663         [Qt] Fix layout-test plugins/plugin-javascript-access.html
2664
2665         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2666
2667 2009-09-02  Shinichiro Hamaji  <hamaji@chromium.org>
2668
2669         Reviewed by Eric Seidel.
2670
2671         js tests should move into jstests subdirectory instead of resources/
2672         https://bugs.webkit.org/show_bug.cgi?id=25880
2673
2674         make-script-wrappers supports both resources and script-tests directories.
2675         run-webkit-tests ignores files in script-tests.
2676         Move script tests of animations to check the new script is working.
2677
2678         * Scripts/make-script-test-wrappers:
2679         * Scripts/run-webkit-tests:
2680
2681 2009-09-02  Szabo Carol  <carol.szabo@nokia.com>
2682
2683         Reviewed by David Levin.
2684
2685         check-webkit-style uses python from /usr/bin instead of the PATH
2686         https://bugs.webkit.org/show_bug.cgi?id=28225
2687
2688         * Scripts/bugzilla-tool:
2689         * Scripts/check-webkit-style:
2690         * Scripts/run-webkit-unittests:
2691         * Scripts/update-sources-list.py:
2692           Changed the first line from
2693           #!/usr/bin/python
2694           to
2695           #!/usr/bin/env python
2696           which causes python to be invoked from the path location returned
2697           by "which python" when any of these scripts are launched.
2698           these are currently all the python scripts in WebKitTools/Scripts.
2699
2700 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2701
2702         <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards
2703
2704         Reviewed by Adam Barth.
2705
2706         * Scripts/modules/scm.py:
2707         (Git.commit_ids_from_commitish_arguments): Reverse the list of
2708         commits returned from git-rev-list since we always want to post
2709         the oldest patches first to bugs.webkit.org.
2710         * Scripts/modules/scm_unittest.py:
2711         (run): Added return statement to return the output now that we
2712         want it sometimes.
2713         (SVNTestRepository._setup_test_commits): Added a fourth commit
2714         so the GitTest.test_commitish_order() test has more commits to
2715         work with.
2716         (GitTest.test_commitish_order): Added unit test for change to
2717         Git.commit_ids_from_commitish_arguments() in scm.py.
2718
2719 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2720
2721         <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed
2722
2723         Reviewed by David Levin.
2724
2725         The mark-fixed subcommand is for those times when you don't use
2726         bugzilla-tool to commit a patch, but you want to use it to close
2727         the bug with a committed-revision message.
2728
2729         * Scripts/bugzilla-tool:
2730         (bug_comment_from_svn_revision): Added.  Extracted from
2731         bug_comment_from_commit_text().
2732         (bug_comment_from_commit_text): Extracted
2733         bug_comment_from_svn_revision() from this method.
2734         (MarkBugFixed.__init__): Added.
2735         (MarkBugFixed._fetch_commit_log): Added.  Retrieves the commit
2736         log from the last commit if no svn revision is specified, else
2737         the commit log for the specified svn revision.
2738         (MarkBugFixed._determine_bug_id_and_svn_revision): Added.
2739         Attempts to determine the bug id and svn revision if one or both
2740         were not defined on the command line.
2741         (MarkBugFixed.execute): Added.  Adds a comment about the
2742         revision that fixed the bug and closes the bug.
2743         (BugzillaTool.__init__): Added mark-fixed subcommand.
2744         * Scripts/modules/bugzilla.py:
2745         (Bugzilla.fetch_title_from_bug): Added.  Returns the title of a
2746         bug given a bug id.
2747         * Scripts/modules/scm.py:
2748         (SCM.strip_r_from_svn_revision): Added.  Utility method to strip
2749         the leading 'r' from an svn revision.
2750         (SCM.svn_commit_log): Added.  Subclasses must override.
2751         (SCM.last_svn_commit_log): Added.  Subclasses must override.
2752         (SVN.svn_commit_log): Added.  Returns svn log for a given
2753         revision.
2754         (SVN.last_svn_commit_log): Added.  Uses svnversion to find the
2755         last commit in an svn working directory and then runs svn log.
2756         (Git.svn_commit_log): Added.  Returns svn log for a given
2757         revision.
2758         (Git.last_svn_commit_log): Added.  Runs git-svn-log with a limit
2759         of one log message.
2760
2761 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2762
2763         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
2764
2765         Reviewed by Brady Eidson.
2766
2767         * Scripts/svn-apply:
2768         (applyPatch): Add "--force" to $options arrayref if $force is
2769         set.
2770
2771 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2772
2773         <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch
2774
2775         Reviewed by Adam Roben.
2776
2777         When git-filter-branch has been invoked to rewrite ChangeLog
2778         files on series of git commits, it changes directories into
2779         .git-rewrite/t before re-running resolve-ChangeLogs.  This
2780         causes determineVCSRoot() in VCSUtils.pm to return
2781         ".git-rewrite/t", which causes that path to be prepended to all
2782         ChangeLog paths, which results in an error like this:
2783
2784             error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git.
2785             Died at WebKitTools/Scripts/resolve-ChangeLogs line 376.
2786
2787         The correct way to fix this is not to try to find the repository
2788         root when invoked by git-filter-branch.
2789
2790         * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true,
2791         set $relativePath to '.' instead of calling
2792         chdirReturningRelativePath(determineVCSRoot()).
2793         (isInGitFilterBranch): Added.  Checks for the existence of the
2794         MAPPED_PREVIOUS_COMMIT environment variable.
2795
2796 2009-09-01  Xan Lopez  <xlopez@igalia.com>
2797
2798         Reviewed by Gustavo Noronha.
2799
2800         Add support for Fedora distros in the http tests
2801         https://bugs.webkit.org/show_bug.cgi?id=28263
2802
2803         Add detection code for Fedora distribution, and use the proper
2804         httpd conf file when needed.
2805
2806         * Scripts/run-webkit-httpd:
2807         * Scripts/run-webkit-tests:
2808         * Scripts/webkitdirs.pm:
2809
2810 2009-09-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
2811
2812         Reviewed by Eric Seidel.
2813
2814         [Gtk] DRT needs implementation of overridePreference
2815         https://bugs.webkit.org/show_bug.cgi?id=28830
2816
2817         Implement overridePreference.
2818
2819         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2820         (resetDefaultsToConsistentValues):
2821         (setDefaultsToConsistentStateValuesForTesting):
2822         (runTest):
2823         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2824         (toWebSettingKey):
2825         (LayoutTestController::overridePreference):
2826
2827 2009-09-01  Joseph Pecoraro  <joepeck@webkit.org>
2828
2829         <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying
2830
2831         Reviewed by Eric Seidel.
2832
2833         Jump back and forth between the repository root directory (to apply) and the
2834         directory the script was run from (to find the patch).
2835
2836         * Scripts/svn-apply:
2837         * Scripts/svn-unapply:
2838
2839 2009-08-31  Adam Roben  <aroben@apple.com>
2840
2841         Fall back to a Release version of Safari if a Debug one doesn't exist
2842
2843         <http://webkit.org/b/28849>
2844
2845         Reviewed by Sam Weinig.
2846
2847         * Scripts/webkitdirs.pm:
2848         (safariPath): If the user is working with a Debug build, but there's
2849         no Debug version of Safari present, fall back to using a Release
2850         version of Safari.
2851
2852 2009-08-31  Adam Roben  <aroben@apple.com>
2853
2854         Make safariPath() work for Debug builds of Safari on Windows
2855
2856         <http://webkit.org/b/28849>
2857
2858         Reviewed by Sam Weinig.
2859
2860         * Scripts/webkitdirs.pm:
2861         (safariPath): If the user is working with a Debug build, add the
2862         _debug suffix to Safari.exe.
2863
2864 2009-08-28  Eric Seidel  <eric@webkit.org>
2865
2866         Reviewed by Adam Barth.
2867
2868         commit-queue needs a master process
2869         https://bugs.webkit.org/show_bug.cgi?id=28040
2870
2871         Add a bugzilla-tool commit-queue command
2872         Keeps per-bug logs, but doesn't yet upload them anywhere.
2873
2874         * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
2875         * Scripts/modules/buildbot.py: remove noisy log message
2876         * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
2877
2878 2009-08-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
2879
2880         Reviewed by Gustavo Noronha.
2881
2882         [GTK] Geolocation needs permission API before being enabled by default
2883
2884         Build the Gtk port with geolocation enabled. This option is only
2885         enabled for the buildbot. The autotools option will be enabled by
2886         default once the permissions API is implemented.
2887
2888         * Scripts/build-webkit:
2889
2890 2009-08-26  Cameron McCormack  <cam@mcc.id.au>
2891
2892         Reviewed by David Kilzer.
2893
2894         Make prepare-ChangeLog notice property changes
2895         https://bugs.webkit.org/show_bug.cgi?id=28675
2896
2897         Make the generated ChangeLog entry include a short description of
2898         property changes if there were such changes.  Also make
2899         prepare-ChangeLog not bail if the only changes are property changes.
2900
2901         * Scripts/prepare-ChangeLog:
2902
2903 2009-08-26  Adam Barth  <abarth@webkit.org>
2904
2905         Reviewed by Oliver Hunt.
2906
2907         Don't let local files access web URLs
2908         https://bugs.webkit.org/show_bug.cgi?id=28480
2909
2910         A bunch of our LayoutTests rely on our old behavior, so we explicitly
2911         grant local files universal access during testing.  Mainly, these tests
2912         involve making XMLHttpRequests for data URLs.
2913
2914         * DumpRenderTree/mac/DumpRenderTree.mm:
2915         (resetDefaultsToConsistentValues):
2916         * DumpRenderTree/qt/DumpRenderTree.cpp:
2917         (WebCore::WebPage::WebPage):
2918         * DumpRenderTree/win/DumpRenderTree.cpp:
2919         (resetDefaultsToConsistentValues):
2920
2921 2009-08-26  John Gregg  <johnnyg@google.com>
2922
2923         Reviewed by David Levin.
2924
2925         Minor style correction and include fix for notifications
2926         https://bugs.webkit.org/show_bug.cgi?id=28745
2927
2928         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2929           change to correct EnumStyle
2930         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2931
2932 2009-08-26  David Levin  <levin@chromium.org>
2933
2934         Reviewed by Alexey Proskuryakov.
2935
2936         XMLHttpRequest.withCredentials=false shouldn't save cookies.
2937         https://bugs.webkit.org/show_bug.cgi?id=28743
2938
2939         Added the support to the layout test controller on OSX and
2940         Windows (for CFNETWORK) to allow for changing the accept cookie
2941         policy.
2942
2943         * DumpRenderTree/LayoutTestController.cpp:
2944         (LayoutTestController::LayoutTestController): Added a bool
2945         to track the state of accepting cookies.
2946         (setAlwaysAcceptCookiesCallback): Standard wrapper method
2947         to go from js to a C++ method.
2948         (LayoutTestController::staticFunctions): Added the
2949         setAlwaysAcceptCookies method to the js layoutTestController.
2950         * DumpRenderTree/LayoutTestController.h:
2951         (LayoutTestController::alwaysAcceptCookies): Returns the value.
2952         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2953         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2954         * DumpRenderTree/mac/DumpRenderTree.mm:
2955         (resetDefaultsToConsistentValues): Reset the accept cookie to
2956         its default.
2957         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2958         (LayoutTestController::setAlwaysAcceptCookies): Does the work for
2959         OSX to change the cookie accept policy.
2960         * DumpRenderTree/win/DumpRenderTree.cpp:
2961         (setAlwaysAcceptCookies): Method to handle all the calls necessary
2962         to change the accept cookie policy on Windows.
2963         (resetDefaultsToConsistentValues): Reset the accept cookie to
2964         its default.
2965         * DumpRenderTree/win/DumpRenderTreeWin.h:
2966         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2967         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2968         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2969         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2970
2971 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2972
2973         Unreviewed.
2974
2975         Remove accidentally left in clobber option.
2976         https://bugs.webkit.org/show_bug.cgi?id=28400
2977
2978         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
2979
2980 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2981
2982         Reviewed by Mark Rowe.
2983
2984         Add canary-style Chromium WebKit build slave to the waterfall.
2985         https://bugs.webkit.org/show_bug.cgi?id=28400
2986
2987         * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
2988         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
2989
2990 2009-08-25  Cameron McCormack  <cam@mcc.id.au>
2991
2992         Reviewed by Darin Adler.
2993
2994         make-script-test-wrappers should be executable
2995         https://bugs.webkit.org/show_bug.cgi?id=28669
2996
2997         Make make-script-test-wrappers and update-sources-list.py both be
2998         executable.
2999
3000         * Scripts/update-sources-list.py:
3001         * Scripts/make-script-test-wrappers:
3002
3003 2009-08-25  Brent Fulgham  <bfulgham@webkit.org>
3004
3005         Build fix
3006
3007         Revise Debug_Cairo targets to point inherit from the 
3008         debug_wincairo.vsprops property sheet so that they link
3009         against the proper libraries in Debug build.
3010
3011         * DumpRenderTree/win/DumpRenderTree.vcproj:
3012         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3013         * WinLauncher/WinLauncher.vcproj:
3014
3015 2009-08-25  David Levin  <levin@chromium.org>
3016
3017         Reviewed by Adam Roben.
3018
3019         PLATFORM(CFNETWORK) should be USE(CFNETWORK).
3020         https://bugs.webkit.org/show_bug.cgi?id=28713
3021
3022         * DumpRenderTree/win/DumpRenderTree.cpp:
3023         (main):
3024
3025 2009-08-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3026
3027         Reviewed by Ariya Hidayat.
3028
3029         [Qt/Mac] Use CONFIG+=build_all only when building libraries
3030
3031         If no configuration is specified when building WebKit we pass the
3032         debug_and_release option to QMake which results in Makefiles for
3033         both configurations being generated.
3034
3035         Previously we built both of these configurations by default, for
3036         all targets (both the QtWebKit framework/dyldlib and the various
3037         executables such as QtLauncher and tests). This makes sense for
3038         the libraries, which get the _debug suffix and can be loaded on
3039         demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
3040         ended up building the same executable twice.
3041
3042         We now only build one instance of each executable, and since this
3043         is a developer build we build the debug-version. Passing either
3044         --debug or --release to build-webkit will override this, and
3045         even in the default case the release version can still be built
3046         by running 'make release' in the the build directory of each
3047         target.
3048
3049         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3050         * Scripts/webkitdirs.pm:
3051
3052 2009-08-24  Hironori Bono  <hbono@chromium.org>
3053
3054         Reviewed by Adam Barth.
3055
3056         Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
3057         <https://bugs.webkit.org/show_bug.cgi?id=27827>.
3058
3059         Because of the lack of mappings from GDK key-codes to WebKit key-codes,
3060         Chromium cannot send valid key-codes to JavaScript when a user types
3061         function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.
3062
3063         To write layout tests for this issue, added mappings from function-key
3064         names to platform-specific key-codes to EventSendingController objects
3065         so that eventSender.keyDown() can send function-key events without using
3066         platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
3067         is only for Mac. So this change adds this new test to Skipped tests for other
3068         platforms to prevent this change from crashing the build trees.)
3069
3070         * DumpRenderTree/mac/EventSendingController.mm:
3071         (-[EventSendingController keyDown:withModifiers:]):
3072
3073 2009-08-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
3074
3075         Reviewed by Xan Lopez.
3076
3077         [Gtk] API for disabling local file access to web URLs
3078         https://bugs.webkit.org/show_bug.cgi?id=28663
3079
3080         Enable this setting for DRT.
3081
3082         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3083         (resetWebViewToConsistentStateBeforeTesting):
3084
3085 2009-08-22  Adam Barth  <abarth@webkit.org>
3086
3087         Revert 47684.  We're going to do this later once clients have had a
3088         chance to opt into the setting they like.
3089
3090         * DumpRenderTree/mac/DumpRenderTree.mm:
3091         (resetDefaultsToConsistentValues):
3092         * DumpRenderTree/qt/DumpRenderTree.cpp:
3093         (WebCore::WebPage::WebPage):
3094         * DumpRenderTree/win/DumpRenderTree.cpp:
3095         (resetDefaultsToConsistentValues):
3096
3097 2009-08-22  Adam Barth  <abarth@webkit.org>
3098
3099         Reviewed by Eric Seidel.
3100
3101         Don't let local files access web URLs
3102         https://bugs.webkit.org/show_bug.cgi?id=28480
3103
3104         A bunch of our LayoutTests rely on our old behavior, so we explicitly
3105         grant local files universal access during testing.  Mainly, these tests
3106         involve making XMLHttpRequests for data URLs.
3107
3108         * DumpRenderTree/mac/DumpRenderTree.mm:
3109         (resetDefaultsToConsistentValues):
3110         * DumpRenderTree/qt/DumpRenderTree.cpp:
3111         (WebCore::WebPage::WebPage):
3112         * DumpRenderTree/win/DumpRenderTree.cpp:
3113         (resetDefaultsToConsistentValues):
3114
3115 2009-08-22  Mark Rowe  <mrowe@apple.com>
3116
3117         Rubber-stamped by Anders Carlsson.
3118
3119         Bring signed updates to the Mac nightly builds.
3120
3121         * WebKitLauncher/Info.plist:
3122         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3123         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
3124         (initializeSparkle):
3125         * WebKitLauncher/nightly.webkit.org.public.pem: Added.
3126
3127 2009-08-21  Jan Michael Alonzo  <jmalonzo@webkit.org>
3128
3129         Rubberstamped by Simon Fraser.
3130
3131         Remove GNOME keyring support in build-webkit. This dependency's
3132         already been removed in the Gtk port.
3133
3134         * Scripts/build-webkit:
3135
3136 2009-08-20  Brian Weinstein  <bweinstein@apple.com>
3137
3138         Reviewed by Adam Roben.
3139         Based on original patch by Stephanie Lewis.
3140
3141         Added support of the Windows malloc history format to parse-malloc history, so we can
3142         read and parse it.
3143
3144         * Scripts/parse-malloc-history:
3145
3146 2009-08-20  Chris Fleizach  <cfleizach@apple.com>
3147
3148         Reviewed by Darin Adler.
3149
3150         Enable various "grouping" ARIA roles
3151         https://bugs.webkit.org/show_bug.cgi?id=28486
3152
3153         Expose the ability to retrieve the subrole through accessibility for DRT.
3154
3155         * DumpRenderTree/AccessibilityUIElement.cpp:
3156         * DumpRenderTree/AccessibilityUIElement.h:
3157         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3158         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3159         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3160
3161 2009-08-20  Joseph Pecoraro  <joepeck@webkit.org>
3162
3163         Unreviewed.
3164
3165         Added myself as a committer.
3166
3167         * Scripts/modules/committers.py:
3168
3169 2009-08-20  Xan Lopez  <xlopez@igalia.com>
3170
3171         Reviewed by Gustavo Noronha.
3172
3173         Fix memory leaks.
3174
3175         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3176         (LayoutTestController::whiteListAccessFromOrigin):
3177         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3178         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3179
3180 2009-08-20  Eric Seidel  <eric@webkit.org>
3181
3182         Reviewed by Adam Barth.
3183
3184         bugzilla-tool post-diff can post partial diffs from SVN checkouts.
3185         https://bugs.webkit.org/show_bug.cgi?id=28445
3186
3187         Pass the checkout root as the cwd.  Also wrote a test to ensure this.
3188
3189         * Scripts/modules/scm.py:
3190         * Scripts/modules/scm_unittest.py:
3191
3192 2009-08-20  Mark Rowe  <mrowe@apple.com>
3193
3194         Reviewed by Adele Peterson.
3195
3196         Don't leak the JSStringRef returned by AccessibilityUIElement::attributeValue.
3197
3198         * DumpRenderTree/AccessibilityUIElement.cpp:
3199         (attributeValueCallback):
3200
3201 2009-08-20  Ariya Hidayat  <ariya.hidayat@nokia.com>
3202
3203         Unreviewed, build fix.
3204
3205         [Qt] The template-based qMax() compares two qreals.
3206
3207         * DumpRenderTree/qt/ImageDiff.cpp:
3208         (main):
3209
3210 2009-08-20  David Levin  <levin@chromium.org>
3211
3212         Reviewed by David Kilzer.
3213
3214         bugzilla-tool patch retrieval should handle 302 redirects.
3215         https://bugs.webkit.org/show_bug.cgi?id=28485
3216
3217         * Scripts/modules/scm.py: Pass the --location parameter to curl
3218         so that 302's are followed.
3219
3220 2009-08-20  Aaron Boodman  <aa@chromium.org>
3221
3222         One more speculative build for gtk.
3223
3224         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3225
3226 2009-08-20  Aaron Boodman  <aa@chromium.org>
3227
3228         Speculative build for gtk.
3229
3230         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3231         (LayoutTestController::whiteListAccessFromOrigin):
3232
3233 2009-08-20  Mark Rowe  <mrowe@apple.com>
3234
3235         Ignore some leaks that are known to originate from ImageIO.
3236
3237         * Scripts/run-webkit-tests:
3238
3239 2009-08-20  Aaron Boodman  <aa@chromium.org>
3240
3241         With David Levin.
3242
3243         Speculative build fix for qt.
3244
3245         * DumpRenderTree/qt/jsobjects.cpp:
3246         (LayoutTestController::whiteListAccessFromOrigin):
3247         * DumpRenderTree/qt/jsobjects.h:
3248
3249 2009-08-19  Mark Rowe  <mrowe@apple.com>
3250
3251         Reviewed by Dan Bernstein.
3252
3253         Fix <http://webkit.org/b/28484> Plug-in-related leaks seen on the build bot
3254
3255         Update check-for-global-initializers to accommodate the new uses of RefCountedLeakCounter in WebKit.
3256
3257         * Scripts/check-for-global-initializers:
3258
3259 2009-08-19  Aaron Boodman  <aa@chromium.org>
3260
3261         Reviewed by David Levin.
3262
3263         https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
3264         specify a more granular policy for cross-origin XHR access.
3265
3266         * DumpRenderTree/LayoutTestController.cpp: Expose whiteListAccessFromOrigin() to layout tests.
3267         (whiteListAccessFromOriginCallback): Ditto.
3268         (LayoutTestController::staticFunctions): Ditto.
3269         * DumpRenderTree/LayoutTestController.h: Ditto.
3270         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
3271         (LayoutTestController::whiteListAccessToOrigin): Ditto.
3272         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
3273         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
3274         * DumpRenderTree/qt/jsobjects.cpp: Ditto.
3275         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
3276         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Stub out whiteListAccessFromOrigin().
3277         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
3278         * DumpRenderTree/gtk/DumpRenderTree.cpp: Reset origin access lists before each test.
3279         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3280         * DumpRenderTree/mac/DumpRenderTree.mm: Ditto.
3281         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3282         * DumpRenderTree/qt/DumpRenderTree.cpp: Ditto.
3283         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Ditto.
3284
3285 2009-08-19  Mark Rowe  <mrowe@apple.com>
3286
3287         Rubber-stamped by Dan Bernstein.
3288
3289         Ignore some leaks that are known to originate from QTKit.
3290
3291         * Scripts/run-webkit-tests:
3292
3293 2009-08-19  Eric Seidel  <eric@webkit.org>
3294
3295         Reviewed by Adam Barth.
3296
3297         commit-queue/bugzilla-tool can get wedged if git is mid-rebase
3298         https://bugs.webkit.org/show_bug.cgi?id=28436
3299
3300         Make clean_working_directory cancel rebases too (even though that's a bit of a hack).
3301         This code will only ever be run when --force-clean is passed.
3302
3303         I also added a new unit test to make sure this code actually works. :)
3304
3305         * Scripts/modules/scm.py:
3306         * Scripts/modules/scm_unittest.py:
3307
3308 2009-08-19  Eric Seidel  <eric@webkit.org>
3309
3310         Reviewed by David Levin.
3311
3312         WebKit needs a changelogs.py to hold changelog-related code
3313         https://bugs.webkit.org/show_bug.cgi?id=28477
3314
3315         This is moving code and adding tests.  There was only one functional
3316         change (which was removing a trailing newline from the last_entry() result).
3317
3318         * Scripts/bugzilla-tool:
3319         * Scripts/modules/changelogs.py: Added.
3320         * Scripts/modules/changelogs_unittest.py: Added.
3321         * Scripts/run-webkit-unittests:
3322
3323 2009-08-20  Eric Seidel  <eric@webkit.org>
3324
3325         Reviewed by Adam Barth.
3326
3327         bugzilla-tool needs a way to ask build.webkit.org if the bots are passing
3328         https://bugs.webkit.org/show_bug.cgi?id=28222
3329
3330         Basic support for now.  This has been in testing for 24 hours now and worked great!
3331
3332         * Scripts/bugzilla-tool:
3333         * Scripts/modules/buildbot.py: Added.
3334         * Scripts/modules/buildbot_unittest.py: Added.
3335         * Scripts/run-webkit-unittests:
3336
3337 2009-08-19  Jan Michael Alonzo  <jmalonzo@webkit.org>
3338
3339         Reviewed by Gustavo Noronha.
3340
3341         [Gtk] Bump waitToDumpWatchdog interval to 15 seconds to match the
3342         default timeout used by run-webkit-tests. Mac and Win ports were
3343         recently bumped in http://trac.webkit.org/changeset/r47465.
3344
3345         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3346         (LayoutTestController::setWaitToDump):
3347
3348 2009-08-19  David D. Kilzer  <ddkilzer@webkit.org>
3349
3350         DumpRenderTreeSupport.pm: provide pre-generated swig source for Tiger
3351
3352         Reviewed by Mark Rowe.
3353
3354         Provide pre-generated swig source files for Tiger so it may
3355         benefit from the faster run-webkit-tests.
3356
3357         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm:
3358         Generated by swig.
3359         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c: Added.
3360         Generated by swig.
3361         (swig_type_info::SWIG_TypeNameComp):
3362         (swig_type_info::SWIG_TypeEquiv):
3363         (swig_type_info::SWIG_TypeRegisterTL):
3364         (swig_type_info::SWIG_TypeCheck):
3365         (swig_type_info::SWIG_TypeCast):
3366         (swig_type_info::SWIG_TypeDynamicCast):
3367         (swig_type_info::SWIG_TypeName):
3368         (swig_type_info::SWIG_TypePrettyName):
3369         (swig_type_info::SWIG_TypeQueryTL):
3370         (swig_type_info::SWIG_TypeClientDataTL):
3371         (swig_type_info::SWIG_PackData):
3372         (swig_type_info::SWIG_UnpackData):
3373         (swig_type_info::SWIG_PropagateClientDataTL):
3374         (swig_type_info::SWIG_PackVoidPtr):
3375         (swig_type_info::SWIG_UnpackVoidPtr):
3376         (swig_type_info::SWIG_PackDataName):
3377         (swig_type_info::SWIG_UnpackDataName):
3378         * DumpRenderTree/mac/PerlSupport/Makefile: Updated to build on
3379         Tiger using pre-generated files.
3380
3381 2009-08-18  Shinichiro Hamaji  <hamaji@chromium.org>
3382
3383         Reviewed by David Kilzer.
3384
3385         run-webkit-tests hangs when WebCore tries to log too much
3386         https://bugs.webkit.org/show_bug.cgi?id=15743
3387
3388         Read stdout and stderr in parallel.
3389
3390         * Scripts/run-webkit-tests:
3391
3392 2009-08-18  Mark Rowe  <mrowe@apple.com>
3393
3394         Rubber-stamped by Oliver Hunt.
3395
3396         Add a new build configuration that checks for leaks during the layout tests,
3397         and hook a new machine up to it.
3398
3399         * BuildSlaveSupport/build.webkit.org-config/config.json:
3400         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3401
3402 2009-08-18  Aaron Boodman  <aa@chromium.org>
3403
3404         Reviewed by Maciej Stachowiak.
3405
3406         https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests.
3407
3408         No new tests: Already covered by existing tests.
3409
3410         * Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest.
3411
3412 2009-08-18  Mark Rowe  <mrowe@apple.com>
3413
3414         Rubber-stamped by Geoff Garen.
3415
3416         Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests.
3417
3418         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3419         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3420
3421 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
3422
3423         Rubber-stamped by Adam Roben.
3424
3425         Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them,
3426         and removed include to fix building on VC++ Express.
3427
3428         * DumpRenderTree/win/UIDelegate.cpp:
3429         (UIDelegate::exceededDatabaseQuota):
3430
3431 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
3432
3433         Reviewed by Oliver Hunt.
3434
3435         Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support 
3436         LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
3437         
3438         Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface.
3439         Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac.
3440
3441         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3442         (LayoutTestController::setDatabaseQuota):
3443         * DumpRenderTree/win/UIDelegate.cpp:
3444         (UIDelegate::exceededDatabaseQuota):
3445
3446 2009-08-18  Peter Kasting  <pkasting@google.com>
3447
3448         Reviewed by Eric Seidel.
3449
3450         https://bugs.webkit.org/show_bug.cgi?id=28415
3451         Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
3452         have it.
3453
3454         * record-memory-win/record-memory-win.vcproj:
3455         * WinLauncher/WinLauncher.vcproj:
3456         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3457         * DumpRenderTree/win/ImageDiff.vcproj:
3458         * FindSafari/FindSafari.vcproj:
3459
3460 2009-08-18  Drew Wilson  <atwilson@google.com>
3461
3462         Reviewed by Eric Seidel.
3463
3464         Need to extend DumpRenderTree to expose number of worker threads
3465         https://bugs.webkit.org/show_bug.cgi?id=28292
3466
3467         Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit.
3468
3469         * DumpRenderTree/LayoutTestController.cpp:
3470         (getWorkerThreadCountCallback):
3471         (LayoutTestController::staticValues):
3472         * DumpRenderTree/LayoutTestController.h:
3473         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3474         (LayoutTestController::workerThreadCount):
3475         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3476         (LayoutTestController::workerThreadCount):
3477         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3478         (LayoutTestController::workerThreadCount):
3479         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3480         (LayoutTestController::workerThreadCount):
3481
3482 2009-08-18  Xan Lopez  <xlopez@igalia.com>
3483
3484         Reviewed by Jan Alonzo.
3485
3486         Initialize x and y in the GtkAllocation structure to shut up
3487         valgrind.
3488
3489         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3490         (runTest):
3491
3492 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
3493
3494         Reviewed by Darin Adler.
3495
3496         Some HTMLs are modified by make-script-test-wrappers
3497         https://bugs.webkit.org/show_bug.cgi?id=28213
3498
3499         Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
3500         the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
3501         re-generated wml/* and Geolocation/* .
3502
3503         * Scripts/make-script-test-wrappers:
3504
3505 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
3506
3507         Reviewed by Eric Seidel.
3508
3509         -webkit-box-orient:horizontal doesn't work on <button> tag
3510         https://bugs.webkit.org/show_bug.cgi?id=34445
3511
3512         Make a flexible button's anonymous child flexible and pass the
3513         parent's box-orient to the anonymous child.
3514
3515         Also, added a renderName for anonymous flexible boxes.
3516
3517         * Scripts/make-script-test-wrappers:
3518
3519 2009-08-17  Eric Seidel  <eric@webkit.org>
3520
3521         Reviewed by Darin Adler.
3522
3523         Can no longer --reset-results of a layout test directory
3524         https://bugs.webkit.org/show_bug.cgi?id=28336
3525
3526         --reset-results and --exit-after-n-failures are incompatible.
3527
3528         * Scripts/run-webkit-tests:
3529
3530 2009-08-17  David Kilzer  <ddkilzer@apple.com>
3531
3532         <http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git
3533
3534         Reviewed by Adam Roben.
3535
3536         New commit message:
3537             Committed r12345: <http://trac.webkit.org/changeset/12345>
3538
3539         * Scripts/bugzilla-tool:
3540         (bug_comment_from_commit_text): Print out a compact,
3541         standardized commit message for both git and svn.
3542
3543 2009-08-17  Peter Kasting  <pkasting@google.com>
3544
3545         Reviewed by Steve Falkenburg.
3546
3547         https://bugs.webkit.org/show_bug.cgi?id=27323
3548         Only add Cygwin to the path when it isn't already there.  This avoids
3549         causing problems for people who purposefully have non-Cygwin versions of
3550         executables like svn in front of the Cygwin ones in their paths.
3551
3552         * DumpRenderTree/win/DumpRenderTree.vcproj:
3553         * DumpRenderTree/win/ImageDiff.vcproj:
3554         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3555
3556 2009-08-17  David Kilzer  <ddkilzer@apple.com>
3557
3558         <http://webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()
3559
3560         Reviewed by David Levin.
3561
3562         * Scripts/modules/cpp_style.py:
3563         (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'.
3564         (check_max_min_macros): Added.  Returns level 4 error when MAX()
3565         and MIN() macros are used in header files and C++ source files.
3566         (check_style): Added call to check_max_min_macros().
3567         * Scripts/modules/cpp_style_unittest.py: Added unit tests.
3568         (test_max_macro): Added.
3569         (test_min_macro): Added.
3570
3571 2009-08-13  Mike Fenton  <mike.fenton@torchmobile.com>
3572
3573         Reviewed by Eric Seidel.
3574
3575         Move adjustLineToPixelBoundaries overlapping function to GraphicsContext.cpp
3576         and remove from GraphicsContextCairo.cpp and GraphicsContextQt.cpp.
3577
3578         https://bugs.webkit.org/show_bug.cgi?id=28268
3579
3580         * platform/graphics/GraphicsContext.cpp:
3581         (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
3582         * platform/graphics/GraphicsContext.h:
3583         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3584         * platform/graphics/qt/GraphicsContextQt.cpp:
3585
3586 2009-08-10  Mike Fenton  <mike.fenton@torchmobile.com>
3587
3588         Reviewed by Adam Treat.
3589
3590         Style fixes for DumpRenderTree/qt/jsobjects.cpp based on cpp_style.py and
3591         WebKit style guide.
3592
3593         https://bugs.webkit.org/show_bug.cgi?id=28161
3594
3595         * DumpRenderTree/qt/jsobjects.cpp:
3596         (findFrameNamed):
3597         (LoadItem::invoke):
3598         (LayoutTestController::provisionalLoad):
3599         (LayoutTestController::timerEvent):
3600         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3601         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3602         (LayoutTestController::numberOfActiveAnimations):
3603         (EventSender::keyDown):
3604         (EventSender::frameUnderMouse):
3605         (TextInputController::doCommand):
3606
3607 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3608
3609         <http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements
3610
3611         Reviewed by David Levin.
3612
3613         In <http://webkit.org/b/28355#c1>, it was noted that new source
3614         files use 'using namespace std;' instead of individual
3615         'using std::foo;' statements.  This adds a level 4 check for
3616         such statements.
3617
3618         * Scripts/modules/cpp_style.py:
3619         (_ERROR_CATEGORIES): Added 'build/using_std'.
3620         (check_using_std): Added.
3621         (check_style): Added call to check_using_std().
3622         * Scripts/modules/cpp_style_unittest.py:
3623         (WebKitStyleTest.test_using_std): Added unit test.
3624
3625 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3626
3627         Backed out r47343 which was mistakenly committed
3628
3629         * Scripts/bugzilla-tool:
3630         * Scripts/modules/scm.py:
3631
3632 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3633
3634         <http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class
3635
3636         Reviewed by David Levin.
3637
3638         The ScriptError class doesn't exist in bugzilla.py, so any
3639         errors print error messages about ScriptError instead of the
3640         actual error:
3641
3642             NameError: global name 'ScriptError' is not defined