ac1e16ef5bf5a29ba8cd2038c3a4a6bda9196ca1
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-20  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         Implement bugzilla-tool build-attachment
6         https://bugs.webkit.org/show_bug.cgi?id=31722
7
8         This command builds an attachment from bugzilla.  It leaves the built
9         patch in the working copy.
10
11         * Scripts/bugzilla-tool:
12         * Scripts/modules/landingsequence.py:
13         * Scripts/modules/webkitlandingscripts.py:
14
15 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
16
17         Reviewed by Xan Lopez.
18
19         [GTK] DRT release event does not create the state correctly
20         https://bugs.webkit.org/show_bug.cgi?id=31717
21
22         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
23
24 2009-11-20  Eric Seidel  <eric@webkit.org>
25
26         Reviewed by Adam Barth.
27
28         MultiCommandTool should find Command objects automatically instead of with a manual list
29         https://bugs.webkit.org/show_bug.cgi?id=31710
30
31         * Scripts/bugzilla-tool:
32         * Scripts/modules/multicommandtool.py:
33          - Use some wild python-fu to crawl all the known subclasses of Command.
34
35 2009-11-20  Adam Barth  <abarth@webkit.org>
36
37         Unreviewed "build" fix.  Added missing import.
38
39         * Scripts/bugzilla-tool:
40
41 2009-11-20  Adam Barth  <abarth@webkit.org>
42
43         Unreviewed "build" fix.  I failed to update LandingSequence.test
44         properly.
45
46         * Scripts/modules/landingsequence.py:
47
48 2009-11-20  Adam Barth  <abarth@webkit.org>
49
50         Reviewed by Eric Seidel.
51
52         Create LandingSequence as the all-sing, all-dance landing class
53         https://bugs.webkit.org/show_bug.cgi?id=31709
54
55         Client can inherit from this class to carefully control exactly which
56         steps they wish to have happen in the landing sequence.
57
58         * Scripts/bugzilla-tool:
59         * Scripts/modules/landingsequence.py: Added.
60         * Scripts/modules/webkitlandingscripts.py: Added.
61
62 2009-11-19  Adam Barth  <abarth@webkit.org>
63
64         Reviewed by Eric Seidel.
65
66         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
67         https://bugs.webkit.org/show_bug.cgi?id=31707
68
69         This is to help when we implement build-attachment.
70
71         * Scripts/bugzilla-tool:
72
73 2009-11-19  Adam Barth  <abarth@webkit.org>
74
75         Reviewed by Eric Seidel.
76
77         Support Qt port in bugzilla-tool
78         https://bugs.webkit.org/show_bug.cgi?id=31701
79
80         Now we support building with Qt!
81
82         * Scripts/bugzilla-tool:
83         * Scripts/modules/webkitport.py: Added.
84         * Scripts/modules/webkitport_unittest.py: Added.
85         * Scripts/run-webkit-unittests:
86
87 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
88
89         Reviewed by Adam Barth.
90
91         Remove inserting stderr into patch in bugzilla-tool
92         https://bugs.webkit.org/show_bug.cgi?id=29914
93
94         Modify SCM python module's run_command function to avoid return of stderr
95         by default, so stderr won't be inserted into the patches.
96         Modify the related unit test.
97
98         * Scripts/modules/scm.py:
99         * Scripts/modules/scm_unittest.py:
100
101 2009-11-19  Eric Seidel  <eric@webkit.org>
102
103         Reviewed by Adam Barth.
104
105         bugzilla-tool needs per-command help
106         https://bugs.webkit.org/show_bug.cgi?id=31697
107
108         Added support for "bugzilla-tool help command-name"
109         and a unit test to make sure it works.
110
111         * Scripts/modules/multicommandtool.py:
112         * Scripts/modules/multicommandtool_unittest.py:
113
114 2009-11-19  Eric Seidel  <eric@webkit.org>
115
116         Reviewed by Adam Barth.
117
118         Move MultiCommandTool and Command into a separate file and add some basic unit tests
119         https://bugs.webkit.org/show_bug.cgi?id=31695
120
121         * Scripts/bugzilla-tool:
122         * Scripts/modules/multicommandtool.py: Added.
123         * Scripts/modules/multicommandtool_unittest.py: Added.
124         * Scripts/run-webkit-unittests:
125
126 2009-11-19  Eric Seidel  <eric@webkit.org>
127
128         No review, just adding a FIXME.
129
130         Split out command parsing and help printing from BugzillaTool
131         https://bugs.webkit.org/show_bug.cgi?id=31688
132
133         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
134
135 2009-11-19  Eric Seidel  <eric@webkit.org>
136
137         Reviewed by Adam Barth.
138
139         Split out command parsing and help printing from BugzillaTool
140         https://bugs.webkit.org/show_bug.cgi?id=31688
141
142         * Scripts/bugzilla-tool:
143          - Add new MultiCommandTool class to contain option parsing and help printing logic.
144          - Rename private methods to use _ pattern.
145          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
146          - 
147
148 2009-11-19  Eric Seidel  <eric@webkit.org>
149
150         Reviewed by Adam Barth.
151
152         Re-factor help printing to use modern python idioms
153         https://bugs.webkit.org/show_bug.cgi?id=31685
154
155         * Scripts/bugzilla-tool:
156
157 2009-11-19  Eric Seidel  <eric@webkit.org>
158
159         Reviewed by Darin Adler.
160
161         commit-queue empty queue logs twice
162         https://bugs.webkit.org/show_bug.cgi?id=31679
163
164         * Scripts/bugzilla-tool:
165
166 2009-11-19  Eric Seidel  <eric@webkit.org>
167
168         Reviewed by Darin Adler.
169
170         bugzilla-tool's reviewer/committer rejection message should be clearer
171         https://bugs.webkit.org/show_bug.cgi?id=31126
172
173         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
174
175         * Scripts/modules/bugzilla.py:
176
177 2009-11-19  Eric Z. Ayers  <zundel@google.com>
178
179         Reviewed by Pavel Feldman.
180
181         Forces a WM_PAINT event on calling layoutTestController.display()
182         in order to enable the timeline-paint.html test on Windows.
183         ::UpdateWindow() does not force an event becaue the window is 
184         not visible.
185
186         https://bugs.webkit.org/show_bug.cgi?id=31402
187
188         * DumpRenderTree/win/DumpRenderTree.cpp:
189         (displayWebView):
190
191 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
192
193         No review needed.
194
195         Added myself to committers list.
196
197         * Scripts/modules/committers.py:
198
199 2009-11-19  Adam Barth  <abarth@webkit.org>
200
201         Reviewed by Eric Seidel.
202
203         Bugzilla-tool command classes should match command names
204         https://bugs.webkit.org/show_bug.cgi?id=31666
205
206         I renamed all the commands except CommitMessageForCurrentDiff because
207         the new name would conflict with an existing class.
208
209         * Scripts/bugzilla-tool:
210
211 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
212
213         Reviewed by Gustavo Noronha Silva.
214
215         Web Inspector: Implement "show inspector" in WebKit GTK
216         API and enable console tests.
217
218         https://bugs.webkit.org/show_bug.cgi?id=31669
219
220         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
221         (LayoutTestController::showWebInspector):
222
223 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
224
225         Reviewed by Simon Hausmann.
226
227         Minor refactoring + more documentation.
228
229         * DumpRenderTree/qt/DumpRenderTree.cpp:
230         (WebCore::clearHistory):
231         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
232
233 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
234
235         Reviewed by Eric Seidel.
236
237         Ignore websocket tests when --no-http is specified.
238         https://bugs.webkit.org/show_bug.cgi?id=31662
239
240         * Scripts/run-webkit-tests:
241
242 2009-11-18  Adam Barth  <abarth@webkit.org>
243
244         Reviewed by Eric Seidel.
245
246         Normalize ' and " in bugzilla-tool
247         https://bugs.webkit.org/show_bug.cgi?id=31655
248
249         We decided " is better than ' and we should be consistent.
250
251         * Scripts/bugzilla-tool:
252
253 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
254
255         Reviewed by Kenneth Rohde Christiansen.
256
257         [Qt] Remove support for Qt v4.3 or older versions
258         https://bugs.webkit.org/show_bug.cgi?id=29469
259
260         * DumpRenderTree/qt/DumpRenderTree.pro:
261         * DumpRenderTree/qt/ImageDiff.pro:
262
263 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
264
265         Reviewed by Eric Seidel.
266
267         GitTest.test_create_binary_patch fails if /tmp is symlink
268         https://bugs.webkit.org/show_bug.cgi?id=31536
269
270         * Scripts/modules/scm_unittest.py:
271
272 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
273
274         Reviewed by Darin Adler.
275
276         Configuration for Chromium Build Slaves.
277
278         https://bugs.webkit.org/show_bug.cgi?id=31442
279
280         * BuildSlaveSupport/build.webkit.org-config/config.json:
281         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
282
283 2009-11-18  Eric Seidel  <eric@webkit.org>
284
285         Reviewed by Darin Adler.
286
287         workqueue.py results in totally broken commit-queue UI
288         https://bugs.webkit.org/show_bug.cgi?id=31645
289
290         * Scripts/bugzilla-tool:
291          - Remove unneeded use of PatchCollection.
292          - Grab a new copy of the cq'd patches every run of the queue.
293
294 2009-11-18  Sam Weinig  <sam@webkit.org>
295
296         Reviewed by Anders Carlsson.
297
298         Make the Mac Geolocation API async.
299
300         Update DRT to use the new async Mac Geolocation API.
301
302         * DumpRenderTree/mac/UIDelegate.mm:
303         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
304
305 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
306
307         Reviewed by Kenneth Rohde Christiansen.
308
309         Add and option to toggle HTML5 datalist support to build-webkit
310         https://bugs.webkit.org/show_bug.cgi?id=31599
311
312         * Scripts/build-webkit:
313
314 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
315
316         Reviewed by Kevin Ollivier.
317
318         Enable wx plugin support using the Windows implementation as a base.
319         
320         https://bugs.webkit.org/show_bug.cgi?id=31636
321
322         * wx/build/settings.py:
323
324 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
325
326         Reviewed by Simon Hausmann.
327
328         Change the initialization order so that the controllers
329         will be created before exporting them to the JS DOM window.
330
331         * DumpRenderTree/qt/DumpRenderTree.cpp:
332         (WebCore::DumpRenderTree::DumpRenderTree):
333
334 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
335
336         Reviewed by Simon Hausmann.
337
338         Fix a code copy and paste error. m_page should be page.
339
340         * DumpRenderTree/qt/DumpRenderTree.cpp:
341         (WebCore::DumpRenderTree::createWindow):
342
343 2009-11-17  Mark Rowe  <mrowe@apple.com>
344
345         Reviewed by Alexey Proskuryakov.
346
347         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
348
349         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
350         This prevents symlinks from confusing the descendant check.
351
352 2009-11-17  Mark Rowe  <mrowe@apple.com>
353
354         Reviewed by Alexey Proskuryakov.
355
356         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
357
358         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
359         server to be up rather than having run-webkit-tests abort immediately.
360
361         * Scripts/run-webkit-tests:
362
363 2009-11-17  Eric Seidel  <eric@webkit.org>
364
365         Reviewed by Darin Adler.
366
367         commit-queue is failing to set reviewer in ChangeLogs
368         https://bugs.webkit.org/show_bug.cgi?id=31592
369
370         * Scripts/bugzilla-tool: Clarify the "applying" log message.
371         * Scripts/modules/bugzilla.py:
372          - Add a new _validate_committer_and_reviewer function as a
373            temporary solution until we can make a real Attachment object
374            which knows how to fill in its committer/reviewer fields automatically.
375
376 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
377
378         Unreviewed buildbot fix.
379
380         Revert part of earlier patch and add comment, as it
381         was causing timeouts on the buildbot.
382
383         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
384         (LayoutTestController::notifyDone):
385
386 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
387
388         Reviewed by Oliver Hunt.
389
390         Make the timeout 15 sec as for the other DRT's and make
391         it print out the same output when a test timeout.
392
393         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
394         (LayoutTestController::waitUntilDone):
395         (LayoutTestController::notifyDone):
396         (LayoutTestController::timerEvent):
397
398 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
399
400         Reviewed by Timothy Hatcher.
401
402         Fixed typos in comments.
403
404         * Scripts/modules/committers.py:
405
406 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
407
408         Reviewed by Timothy Hatcher.
409
410         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
411         - Updated DRT to show/close inspector for all tests under /inspector
412         - Introduced LayoutTestController::setTimelineProfilingEnabled and
413           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
414         - Removed reload on each inspector test
415         - Renamed fast/inspector to fast/inspector-support in order not to trigger
416         inspector for those.
417         - Reimplemented timeline tests in order to get rid of reload there.
418         - Moved tests that don't require harness into the fast group.
419
420         https://bugs.webkit.org/show_bug.cgi?id=31472
421
422         * DumpRenderTree/LayoutTestController.cpp:
423         (setTimelineProfilingEnabledCallback):
424         (closeWebInspectorCallback):
425         (LayoutTestController::staticFunctions):
426         * DumpRenderTree/LayoutTestController.h:
427         * DumpRenderTree/gtk/DumpRenderTree.cpp:
428         (shouldOpenWebInspector):
429         (runTest):
430         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
431         (LayoutTestController::setTimelineProfilingEnabled):
432         * DumpRenderTree/mac/DumpRenderTree.mm:
433         (shouldOpenWebInspector):
434         (runTest):
435         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
436         (LayoutTestController::setTimelineProfilingEnabled):
437         * DumpRenderTree/win/DumpRenderTree.cpp:
438         (shouldOpenWebInspector):
439         (runTest):
440         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
441         (LayoutTestController::setTimelineProfilingEnabled):
442
443 2009-11-17  Oliver Hunt  <oliver@apple.com>
444
445         Reviewed by Maciej Stachowiak.
446
447         Incorrect use of JavaScriptCore API in DumpRenderTree
448         https://bugs.webkit.org/show_bug.cgi?id=31577
449
450         Return undefined rather than a literal null.
451
452         * DumpRenderTree/AccessibilityUIElement.cpp:
453         (setSelectedTextRangeCallback):
454         (incrementCallback):
455         (decrementCallback):
456         (showMenuCallback):
457
458 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
459
460         Reviewed by Beth Dakin.
461
462         AX: aria-labelledby duplicates some of its WAI-ARIA label
463         https://bugs.webkit.org/show_bug.cgi?id=31565
464
465         * DumpRenderTree/AccessibilityUIElement.cpp:
466         (titleUIElementCallback):
467         (getIsValidCallback):
468         (AccessibilityUIElement::getJSClass):
469
470 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
471
472         Reviewed by Simon Hausmann.
473
474         r50942 broke output from created windows. Make the
475         m_enableTextOutput a member of the DRT and not the
476         WebPage.
477
478         * DumpRenderTree/qt/DumpRenderTree.cpp:
479         (WebCore::WebPage::WebPage):
480         (WebCore::WebPage::javaScriptAlert):
481         (WebCore::WebPage::javaScriptConsoleMessage):
482         (WebCore::WebPage::javaScriptConfirm):
483         (WebCore::WebPage::javaScriptPrompt):
484         (WebCore::WebPage::acceptNavigationRequest):
485         (WebCore::DumpRenderTree::DumpRenderTree):
486         (WebCore::DumpRenderTree::open):
487         (WebCore::DumpRenderTree::createWindow):
488         * DumpRenderTree/qt/DumpRenderTree.h:
489         (WebCore::DumpRenderTree::setTextOutputEnabled):
490         (WebCore::DumpRenderTree::isTextOutputEnabled):
491         (WebCore::WebPage::shouldInterruptJavaScript):
492         (WebCore::WebPage::isTextOutputEnabled):
493         (WebCore::WebPage::setViewGeometry):
494
495 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
496
497         Reviewed by Gustavo Noronha Silva.
498
499         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
500         as the implementation is being used by at least Qt and Gtk+.
501
502         Update buildsystems as well.
503
504         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
505         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
506         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
507         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
508         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
509         * GNUmakefile.am:
510
511 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
512
513         Reviewed by Alexey Proskuryakov.
514
515         Disable wss until all platforms support pyOpenSSL
516
517         https://bugs.webkit.org/show_bug.cgi?id=31479
518
519         * Scripts/run-webkit-tests:
520
521 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
522
523         Reviewed by Kenneth Christiansen.
524
525         [Qt] Implement load error pages support for Qt's DRT.
526         https://bugs.webkit.org/show_bug.cgi?id=31509
527
528         For now, it will not be a default feature, and layout tests
529         that want to make use of this have to explicitily call
530         'handleErrorPages();' for the test source.
531
532         Any of the other DumpRenderTree's (mac, win and gtk)
533         support handling error pages. Qt's will be the first.
534
535         * DumpRenderTree/qt/DumpRenderTree.cpp:
536         (WebCore::WebPage::supportsExtension):
537         (WebCore::WebPage::extension):
538         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
539         (LayoutTestController::reset):
540         * DumpRenderTree/qt/LayoutTestControllerQt.h:
541         (LayoutTestController::shouldHandleErrorPages):
542         (LayoutTestController::handleErrorPages):
543
544 2009-11-16  Eric Seidel  <eric@webkit.org>
545
546         Reviewed by Adam Barth.
547
548         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
549         https://bugs.webkit.org/show_bug.cgi?id=31549
550
551         Renamed --commit-queue to --non-interactive in most places
552         and remove the code in land-patches which is no longer needed.
553
554         * Scripts/bugzilla-tool:
555
556 2009-11-16  Eric Seidel  <eric@webkit.org>
557
558         Reviewed by Adam Barth.
559
560         The commit-queue should use land-attachment
561         https://bugs.webkit.org/show_bug.cgi?id=31548
562
563         * Scripts/bugzilla-tool:
564
565 2009-11-16  Adam Barth  <abarth@webkit.org>
566
567         Reviewed by Eric Seidel.
568
569         Convert CommitQueue over to PatchCollection
570         https://bugs.webkit.org/show_bug.cgi?id=31547
571
572         Also fixes a bug in workqueue and adds a test!
573
574         * Scripts/bugzilla-tool:
575         * Scripts/modules/workqueue.py:
576         * Scripts/modules/workqueue_unittest.py:
577
578 2009-11-16  Adam Barth  <abarth@webkit.org>
579
580         Reviewed by Eric Seidel.
581
582         Move StyleQueue over to using PatchCollection
583         https://bugs.webkit.org/show_bug.cgi?id=31544
584
585         That's what the class it's for.
586
587         * Scripts/bugzilla-tool:
588         * Scripts/modules/patchcollection.py:
589         * Scripts/modules/patchcollection_unittest.py:
590
591 2009-11-16  Eric Seidel  <eric@webkit.org>
592
593         Reviewed by Adam Barth.
594
595         bugzilla-tool needs a land-attachment command
596         https://bugs.webkit.org/show_bug.cgi?id=31546
597
598         * Scripts/bugzilla-tool:
599          - Move all the logic into AbstractLandingCommand and
600            add a new LandAttachment command subclass.
601          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
602
603 2009-11-16  Eric Seidel  <eric@webkit.org>
604
605         Reviewed by Adam Barth.
606
607         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
608         https://bugs.webkit.org/show_bug.cgi?id=31543
609
610         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
611
612         * Scripts/bugzilla-tool:
613
614 2009-11-16  Eric Seidel  <eric@webkit.org>
615
616         Reviewed by Adam Barth.
617
618         Disable the style queue from posting to the commit queue status page.
619
620         * Scripts/bugzilla-tool:
621
622 2009-11-16  Adam Barth  <abarth@webkit.org>
623
624         Reviewed by Eric Seidel.
625
626         Implement PatchCollection
627         https://bugs.webkit.org/show_bug.cgi?id=31541
628
629         This class holds a set of patches and lets clients iterate through
630         them.  Optionally, clients can install a filter.
631
632         * Scripts/modules/patchcollection.py: Added.
633         * Scripts/modules/patchcollection_unittest.py: Added.
634         * Scripts/run-webkit-unittests:
635
636 2009-11-16  Eric Seidel  <eric@webkit.org>
637
638         Reviewed by Adam Barth.
639
640         bugzilla-tool land-patches will close bugs with patches r=?
641         https://bugs.webkit.org/show_bug.cgi?id=28230
642
643         The commit-queue shouldn't close patches with outstanding reviews on them,
644         even if many reviewers seem to be against multi-patch bugs.
645
646         * Scripts/bugzilla-tool:
647
648 2009-11-16  Eric Seidel  <eric@webkit.org>
649
650         Reviewed by Adam Barth.
651
652         bugzilla-tool check-style should work with attachment ids instead of bug ids
653         https://bugs.webkit.org/show_bug.cgi?id=31540
654
655         * Scripts/bugzilla-tool:
656
657 2009-11-16  Eric Seidel  <eric@webkit.org>
658
659         Reviewed by Adam Barth.
660
661         WorkQueue is the only place that should know about special exit codes
662         https://bugs.webkit.org/show_bug.cgi?id=31534
663
664         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
665         and add tests for handling exit codes.
666         I also cleaned up workqueue_unittest.py more.
667
668         * Scripts/bugzilla-tool:
669         * Scripts/modules/workqueue.py:
670         * Scripts/modules/workqueue_unittest.py:
671
672 2009-11-16  Eric Seidel  <eric@webkit.org>
673
674         Reviewed by Adam Barth.
675
676         Re-factor workqueue_unittest to allow for more than one test.
677         https://bugs.webkit.org/show_bug.cgi?id=31535
678
679         * Scripts/modules/workqueue_unittest.py:
680
681 2009-11-16  Eric Seidel  <eric@webkit.org>
682
683         Reviewed by Adam Barth.
684
685         land-patches needs to be re-factored into smaller chunks
686         https://bugs.webkit.org/show_bug.cgi?id=31532
687
688         * Scripts/bugzilla-tool: fix a couple obvious typos.
689
690 2009-11-16  Eric Seidel  <eric@webkit.org>
691
692         Reviewed by Adam Barth.
693
694         land-patches needs to be re-factored into smaller chunks
695         https://bugs.webkit.org/show_bug.cgi?id=31532
696
697         The next patch will move these methods into WebKitLandingScripts.
698
699         * Scripts/bugzilla-tool:
700          - Split out _land_patch and _close_bug_if_no_active_patches.
701
702 2009-11-16  Adam Barth  <abarth@webkit.org>
703
704         Reviewed by Eric Seidel.
705
706         Fix silly copy-and-paste code.  I am a terrible coder.
707
708         * Scripts/modules/bugzilla.py:
709
710 2009-11-16  Adam Barth  <abarth@webkit.org>
711
712         Reviewed by Eric Seidel.
713
714         Implement a StyleQueue
715         https://bugs.webkit.org/show_bug.cgi?id=31537
716
717         The first iteration of the style queue only produces output locally.
718         There is also a limit of 10 patches because it's not that useful to
719         iterate through the entire review queue at this point.  We can remove
720         the limit later.
721
722         * Scripts/bugzilla-tool:
723         * Scripts/modules/bugzilla.py:
724
725 2009-11-16  Adam Barth  <abarth@webkit.org>
726
727         Reviewed by Eric Seidel.
728
729         Unit test WorkQueue
730         https://bugs.webkit.org/show_bug.cgi?id=31531
731
732         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
733
734         * Scripts/bugzilla-tool:
735         * Scripts/modules/statusbot.py:
736         * Scripts/modules/workqueue.py:
737         * Scripts/modules/workqueue_unittest.py: Added.
738         * Scripts/run-webkit-unittests:
739
740 2009-11-16  Eric Seidel  <eric@webkit.org>
741
742         Reviewed by Adam Barth.
743
744         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
745         https://bugs.webkit.org/show_bug.cgi?id=31530
746
747         * Scripts/bugzilla-tool:
748
749 2009-11-16  Eric Seidel  <eric@webkit.org>
750
751         Reviewed by Adam Barth.
752
753         bugzilla-tool needs apply-attachment
754         https://bugs.webkit.org/show_bug.cgi?id=31528
755
756         * Scripts/bugzilla-tool:
757          - Add ApplyAttachment command.
758          - Abstract applying code into WebKitApplyingScripts.
759          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
760         * Scripts/modules/bugzilla.py:
761          - Add fetch_attachment and bug_id_for_attachment_id.
762         * Scripts/modules/bugzilla_unittest.py:
763          - Add test for new parsing.
764          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
765
766 2009-11-16  Eric Seidel  <eric@webkit.org>
767
768         Reviewed by Adam Barth.
769
770         Document check-style's use of force_clean.
771
772         * Scripts/bugzilla-tool:
773         * Scripts/modules/scm.py:
774
775 2009-11-16  Adam Barth  <abarth@webkit.org>
776
777         Reviewed by Eric Seidel.
778
779         Move WorkQueue to its own file
780         https://bugs.webkit.org/show_bug.cgi?id=31529
781
782         WorkQueue and WorkQueueDelegate are separate concerns from
783         bugzilla-tool.  Also added a missing include to logging.py.
784
785         * Scripts/bugzilla-tool:
786         * Scripts/modules/logging.py:
787         * Scripts/modules/workqueue.py:
788
789 2009-11-16  Adam Barth  <abarth@webkit.org>
790
791         Reviewed by Eric Seidel.
792
793         Move OutputTee to logging.py.
794
795         * Scripts/bugzilla-tool:
796         * Scripts/modules/logging.py:
797
798 2009-11-15  Adam Barth  <abarth@webkit.org>
799
800         Reviewed by Eric Seidel.
801
802         Refactor bugzilla-tool to allow for multiple queues
803         https://bugs.webkit.org/show_bug.cgi?id=31513
804
805         Divide the commit queue class into three class to make creating
806         additional queues easier.
807
808         * Scripts/bugzilla-tool:
809
810 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
811
812         Reviewed by Eric Seidel.
813
814         svn-apply may not handle git patches created by bugzilla-tool
815         https://bugs.webkit.org/show_bug.cgi?id=31457
816
817         * Scripts/modules/scm.py:
818         * Scripts/modules/scm_unittest.py:
819
820 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
821
822         Reviewed by Eric Seidel.
823
824         bugzilla-tool should post git binary diff
825         https://bugs.webkit.org/show_bug.cgi?id=31458
826
827         Add --binary option to Git.create_patch.
828
829         * Scripts/modules/scm.py:
830         * Scripts/modules/scm_unittest.py:
831
832 2009-11-15  Adam Barth  <abarth@webkit.org>
833
834         Reviewed by Darin Adler.
835
836         Add bugzilla-tool check-style
837         https://bugs.webkit.org/show_bug.cgi?id=31515
838
839         * Scripts/bugzilla-tool:
840         * Scripts/modules/bugzilla.py:
841
842 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
843
844         Reviewed by Simon Hausmann.
845
846         Make the Qt Linux only --valgrind feature, suppress errors
847         defined in the SuppressedValgrindErrors file.
848
849         * Scripts/run-webkit-tests:
850
851 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
852
853         Reviewed by Simon Hausmann.
854
855         Set the locale to C and not to the current one in use on the system.
856
857         * DumpRenderTree/qt/DumpRenderTree.cpp:
858         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
859
860 2009-11-13  Adam Roben  <aroben@apple.com>
861
862         Add support for
863         http/tests/security/isolatedWorld/didClearWindowObject.html
864
865         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
866         window objects in isolated worlds are cleared
867
868         Reviewed by Dave Hyatt.
869
870         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
871
872         * DumpRenderTree/mac/FrameLoadDelegate.mm:
873         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
874         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
875         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
876         Added. Sets a __worldID property on the global object whose value is
877         the ID of this world.
878         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
879         Respond to this new delegate callback by calling through to one of the
880         above new methods.
881         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
882         (worldMap): Added. Returns a HashMap containing all the worlds we've
883         created.
884         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
885         haven't kept track of this world.
886         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
887         instead of declaring our own.
888
889         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
890
891         * DumpRenderTree/win/FrameLoadDelegate.cpp:
892         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
893         didClearWindowObjectForFrameInStandardWorld.
894         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
895         Respond to this new delegate callback by calling through to one of the
896         below new methods.
897         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
898         Added. Sets a __worldID property on the gobal object whose value is
899         the ID of this world.
900         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
901         Added. Moved code here from didClearWindowObject.
902
903         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
904         didClearWindowObjectForFrame* functions.
905
906         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
907         (worldMap): Added. Returns a HashMap containing all the worlds we've
908         created.
909         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
910         haven't kept track of this world.
911         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
912         instead of declaring our own.
913
914 2009-11-13  Adam Roben  <aroben@apple.com>
915
916         Finish replacing worldIDs with world objects
917
918         The only remaining use of worldIDs was in a method only used by DRT
919         for the isolated worlds tests.
920
921         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
922
923         Reviewed by Mark Rowe.
924
925         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
926         (LayoutTestController::evaluateScriptInIsolatedWorld):
927         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
928         (LayoutTestController::evaluateScriptInIsolatedWorld):
929         Updated for changes to WebFrame. Now holds the map of worldID -> world
930         at this level instead of making WebKit do it.
931
932 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
933
934         Reviewed by Simon Hausmann.
935
936         [Qt] Ensure the DRT does not output anything until first test is run
937
938         * DumpRenderTree/qt/DumpRenderTree.cpp:
939         * DumpRenderTree/qt/DumpRenderTree.h:
940
941 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
942
943         Reviewed by Tor Arne Vestbø.
944
945         Clear the undo stack in before each new test run.
946
947         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
948
949         * DumpRenderTree/qt/DumpRenderTree.cpp:
950         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
951
952 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
953
954         Reviewed by Kenneth Rohde Christiansen.
955
956         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
957
958         * DumpRenderTree/qt/DumpRenderTree.cpp:
959         (WebCore::WebPage::resetSettings):
960         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
961         (LayoutTestController::overridePreference):
962
963 2009-11-13  Eric Seidel  <eric@webkit.org>
964
965         Reviewed by Adam Barth.
966
967         Update committers.py based on svn records
968         https://bugs.webkit.org/show_bug.cgi?id=31366
969
970         This list was generated using validate-committer-lists from
971         https://bugs.webkit.org/show_bug.cgi?id=30970
972         and makes committers.py current for committers who have
973         committed in the last 3 years.
974
975         * Scripts/modules/committers.py:
976
977 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
978
979         Reviewed by Adam Barth.
980
981         The document-open.html test was flaky at times. The test invokes the layout test plugin
982         which in its destroy stream handler opens a new document. This basically tears down the
983         stream and the associated plugin instance. The pluginLog function in the layout test
984         plugin attempts to retrieve the window script object on a torn down plugin instance
985         which crashed consistently on windows in the debugger. The functions which issue
986         these logs already have a valid window script object. We now have variants of the pluginLog
987         function which take in a window script object with and without variable arguments. 
988
989         https://bugs.webkit.org/show_bug.cgi?id=31067
990
991         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
992         (pluginLogWithWindowObject):
993         (pluginLogWithWindowObjectVariableArgs):
994         (pluginLog):
995         (notifyTestCompletion):
996         (testDocumentOpen):
997         (testWindowOpen):
998
999 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1000
1001         Reviewed by Gustavo Noronha Silva.
1002
1003         https://bugs.webkit.org/show_bug.cgi?id=30997
1004         [Gtk] Implemment AtkDocument
1005
1006         Added testing support.
1007
1008         * DumpRenderTree/AccessibilityUIElement.cpp:
1009         * DumpRenderTree/AccessibilityUIElement.h:
1010         (getDocumentEncodingCallback):
1011         (getDocumentURICallback):
1012         (AccessibilityUIElement::getJSClass):
1013         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1014         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1015         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1016         (AccessibilityUIElement::documentEncoding):
1017         (AccessibilityUIElement::documentURI):
1018
1019 2009-11-12  Adam Roben  <aroben@apple.com>
1020
1021         Replace worldIDs with world objects
1022
1023         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1024         user scripts/stylesheets and isolated worlds
1025
1026         Reviewed by Sam Weinig.
1027
1028         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1029         (LayoutTestController::addUserScript):
1030         (LayoutTestController::addUserStyleSheet):
1031         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1032         (LayoutTestController::addUserScript):
1033         (LayoutTestController::addUserStyleSheet):
1034         Changed these functions to create a new WebJSWorld each time they're
1035         called and to pass that world to WebKit.
1036
1037 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1038
1039         Reviewed by Oliver Hunt.
1040
1041         need to implement aria tree roles
1042         https://bugs.webkit.org/show_bug.cgi?id=31284
1043
1044         * DumpRenderTree/AccessibilityUIElement.cpp:
1045         (disclosedRowAtIndexCallback):
1046         (selectedRowAtIndexCallback):
1047         (isEqualCallback):
1048         (isAttributeSettableCallback):
1049         (isActionSupportedCallback):
1050         (disclosedByRowCallback):
1051         (hierarchicalLevelCallback):
1052         (AccessibilityUIElement::getJSClass):
1053         * DumpRenderTree/AccessibilityUIElement.h:
1054         (AccessibilityUIElement::isEqual):
1055         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1056         (AccessibilityUIElement::hierarchicalLevel):
1057         (AccessibilityUIElement::disclosedRowAtIndex):
1058         (AccessibilityUIElement::selectedRowAtIndex):
1059         (AccessibilityUIElement::disclosedByRow):
1060         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1061         (AccessibilityUIElement::getChildAtIndex):
1062         (AccessibilityUIElement::disclosedRowAtIndex):
1063         (AccessibilityUIElement::selectedRowAtIndex):
1064         (AccessibilityUIElement::titleUIElement):
1065         (AccessibilityUIElement::parentElement):
1066         (AccessibilityUIElement::disclosedByRow):
1067         (AccessibilityUIElement::hierarchicalLevel):
1068         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1069         (AccessibilityUIElement::hierarchicalLevel):
1070         (AccessibilityUIElement::disclosedRowAtIndex):
1071         (AccessibilityUIElement::selectedRowAtIndex):
1072         (AccessibilityUIElement::disclosedByRow):
1073
1074 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1075
1076         Reviewed by Darin Adler.
1077
1078         svn-apply can not handle git binary diffs
1079         https://bugs.webkit.org/show_bug.cgi?id=26830
1080
1081         Support "literal" type git binary diffs.
1082
1083         * Scripts/VCSUtils.pm:
1084         * Scripts/modules/scm_unittest.py:
1085         * Scripts/svn-apply:
1086
1087 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1088
1089         Not reviewed, removing duplicate entry for myself in committers.py.
1090
1091         * Scripts/modules/committers.py:
1092
1093 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1094
1095         Reviewed by Darin Adler and Mark Rowe.
1096
1097         https://bugs.webkit.org/show_bug.cgi?id=31200
1098         Tests in http/tests/security/mixedContent start to fail when new tests are added
1099
1100         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1101
1102 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1103
1104         Reviewed by Jan Alonzo.
1105
1106         Create, and display a window for the inspector, for inspector
1107         tests.
1108
1109         Need to also show/hide the inspector window to avoid having
1110         problems with code assuming it is realized
1111         https://bugs.webkit.org/show_bug.cgi?id=31347
1112
1113         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1114         (webInspectorShowWindow):
1115         (webInspectorCloseWindow):
1116         (webInspectorInspectWebView):
1117         (createWebView):
1118
1119 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1120
1121         Unreviewed Qt buildbot fix.
1122
1123         My previous fix was wrong, so revert that change and fix it by
1124         returning when the document of the frame has no document element.
1125         Idea is borrowed from mac and win DRT.
1126
1127         * DumpRenderTree/qt/DumpRenderTree.cpp:
1128         (WebCore::DumpRenderTree::dumpFramesAsText):
1129
1130 2009-11-11  Eric Seidel  <eric@webkit.org>
1131
1132         Reviewed byg Kenneth Rohde Christiansen.
1133
1134         Update Kenneth's committer record to include the email he
1135         uses on lists.webkit.org.
1136
1137         * Scripts/modules/committers.py:
1138
1139 2009-11-11  Eric Seidel  <eric@webkit.org>
1140
1141         Reviewed by Gustavo Noronha Silva.
1142
1143         Several committers use separate email addresses for bugzilla and svn.webkit.org
1144         https://bugs.webkit.org/show_bug.cgi?id=31364
1145
1146         Update records for existing committers to include email addresses
1147         used in svn.webkit.org and lists.webkit.org.
1148         Most committers use the same email address in all 3 places, but some use
1149         separate addresses.  committers.py needs record of each of these addresses.
1150
1151         * Scripts/modules/committers.py:
1152
1153 2009-11-11  Eric Seidel  <eric@webkit.org>
1154
1155         No review, adding second email address for an existing committer.
1156
1157         Add Yong Li's second bugzilla account to his committer record.
1158         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1159
1160         * Scripts/modules/committers.py:
1161
1162 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1163
1164         Reviewed by Simon Hausmann.
1165
1166         If the frame has no innerText don't append it, and
1167         do not add a newline which breaks some cross platform
1168         results.
1169
1170         * DumpRenderTree/qt/DumpRenderTree.cpp:
1171         (WebCore::DumpRenderTree::dumpFramesAsText):
1172
1173 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1174
1175         Reviewed by Simon Hausmann.
1176
1177         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1178
1179         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1180         (webkit_test_plugin_new_instance):
1181         (webkit_test_plugin_destroy_instance):
1182         (webkit_test_plugin_destroy_stream):
1183
1184 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1185
1186         Reviewed by Mark Rowe.
1187
1188         Implement the functionality needed by plugins/window-open.html
1189
1190         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1191         (webkit_test_plugin_new_instance):
1192         (webkit_test_plugin_set_window):
1193
1194 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1195
1196         Reviewed by Simon Hausmann.
1197
1198         [Qt] Force -graphicssystem raster and -style windows when running DRT
1199
1200         * DumpRenderTree/qt/main.cpp:
1201         * Scripts/run-webkit-tests:
1202
1203 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1204
1205         Reviewed by Simon Hausmann.
1206
1207         Compute correct library paths for Qt
1208
1209         * Scripts/webkitdirs.pm:
1210
1211 2009-11-10  Mark Rowe  <mrowe@apple.com>
1212
1213         Reviewed by Sam Weinig.
1214
1215         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1216
1217         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1218         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1219         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1220         that had enabled frame load delegate logging this would result in extra log messages being generated,
1221         causing the test to fail.
1222
1223         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1224         tests.
1225
1226         * DumpRenderTree/mac/DumpRenderTree.mm:
1227         (dumpRenderTree):
1228         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1229         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1230
1231 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1232
1233         Reviewed by Kenneth Rohde Christiansen.
1234
1235         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1236
1237         * DumpRenderTree/qt/DumpRenderTree.cpp:
1238         (WebCore::DumpRenderTree::DumpRenderTree):
1239
1240 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1241
1242         Reviewed by Jan Alonzo.
1243
1244         [GTK] Remove WebSocket configuration from WebKitWebSettings
1245         https://bugs.webkit.org/show_bug.cgi?id=31244
1246
1247         Follow-up of r50724. Don't set the enable-web-socket property
1248         anymore.
1249
1250         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1251         (resetDefaultsToConsistentValues):
1252
1253 2009-11-10  Oliver Hunt  <oliver@apple.com>
1254
1255         Reviewed by Maciej Stachowiak.
1256
1257         Rename 3D Canvas related classes to use WebGL prefix
1258         https://bugs.webkit.org/show_bug.cgi?id=29095
1259
1260         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1261         and upate webkitdirs script to new method of testing for WebGL.
1262
1263         * Scripts/do-webcore-rename:
1264         * Scripts/webkitdirs.pm:
1265
1266 2009-11-09  Oliver Hunt  <oliver@apple.com>
1267
1268         Reviewed by Geoff Garen.
1269
1270         Make do-webcore-rename work with git.
1271
1272         * Scripts/do-webcore-rename:
1273
1274 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1275
1276         Adding Kenneth to the reviewers list.
1277
1278         * Scripts/modules/committers.py:
1279
1280 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1281
1282         Reviewed by Jan Alonzo.
1283
1284         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1285         https://bugs.webkit.org/show_bug.cgi?id=30482
1286
1287         LayoutTestControllerGtk now uses the exposed
1288         Page::tabKeyCyclesThroughElements API
1289
1290         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1291         (LayoutTestController::setTabKeyCyclesThroughElements):
1292
1293 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1294
1295         Reviewed by Holger Freyther.
1296
1297         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1298         This helps to pass the test case below. Also replaced hardcoded
1299         code numbers with defined constants.
1300         https://bugs.webkit.org/show_bug.cgi?id=31185
1301         
1302         Test: editing/undo/undo-deleteWord.html
1303
1304         * DumpRenderTree/qt/EventSenderQt.cpp:
1305         (EventSender::keyDown):
1306
1307 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1308
1309         Reviewed by Holger Freyther.
1310
1311         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1312         https://bugs.webkit.org/show_bug.cgi?id=31164
1313
1314         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1315
1316         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1317         (LayoutTestController::processWork):
1318
1319 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1320
1321         Reviewed by Holger Freyther.
1322
1323         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1324         https://bugs.webkit.org/show_bug.cgi?id=31158
1325
1326         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1327         always, which from WorkQueue prospective means that a load has been started
1328         and the queue processing should stop and wait for the load to finish.
1329         Spinning it off into a loading and a non-loading variants was the solution
1330         adopted by Mac's DRT to work around this problem. The former keeps returning
1331         'true' while the later executes the script synchronously and returns 'false'
1332         making it possible to the WorkQueue to proceed right away.
1333
1334         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1335         (LayoutTestController::processWork):
1336         (LayoutTestController::queueLoadingScript):
1337         (LayoutTestController::queueNonLoadingScript):
1338         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1339         * DumpRenderTree/qt/WorkQueueItem.h:
1340         (LoadingScriptItem::LoadingScriptItem):
1341         (LoadingScriptItem::invoke):
1342         (NonLoadingScriptItem::NonLoadingScriptItem):
1343         (NonLoadingScriptItem::invoke):
1344
1345 2009-11-07  Mark Rowe  <mrowe@apple.com>
1346
1347         Rubber-stamped by Cameron Zwarich.
1348
1349         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1350
1351         * Scripts/commit-log-editor:
1352
1353 2009-11-07  Mark Rowe  <mrowe@apple.com>
1354
1355         Reviewed by Darin Adler.
1356
1357         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1358         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1359
1360         Move logic for determining the name and email address to use in a ChangeLog entry from
1361         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1362         whether the author of the patch matches committer, and therefore needs access to the
1363         email address that would be used in a ChangeLog entry.
1364
1365         Based on a patch by Pierre d'Herbemont.
1366
1367         * Scripts/VCSUtils.pm:
1368         * Scripts/commit-log-editor:
1369         * Scripts/prepare-ChangeLog:
1370         * Scripts/webkitdirs.pm:
1371
1372 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1373
1374         Reviewed by Adam Barth.
1375
1376         Added functionality to the layout test plugin to invoke document.open and
1377         window.open with default arguments. The associated webkit bug is
1378         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1379         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1380         work in Chromium (V8) if there is no calling javascript context. To achieve this
1381         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1382         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1383
1384         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1385         (testDocumentOpen):
1386         (testWindowOpen):
1387         (pluginAllocate):
1388         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1389         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1390         (NPP_New):
1391         (NPP_SetWindow):
1392         (NPP_DestroyStream):
1393         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1394         (NPP_New):
1395         (NPP_SetWindow):
1396         (NPP_NewStream):
1397         (NPP_DestroyStream):
1398
1399 2009-11-06  Eric Seidel  <eric@webkit.org>
1400
1401         Reviewed by Adam Barth.
1402
1403         bugzilla-tool crashed with exception
1404         https://bugs.webkit.org/show_bug.cgi?id=31092
1405
1406         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1407
1408 2009-11-04  Eric Seidel  <eric@webkit.org>
1409
1410         No review, just add a line which got left out of the patch uploaded for commit.
1411
1412         commit-queue is crashing when trying to reject patches after unknown failures
1413         https://bugs.webkit.org/show_bug.cgi?id=31091
1414
1415         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1416
1417 2009-11-04  Adam Roben  <aroben@apple.com>
1418
1419         Remove bogus else clause in bugzilla-tool
1420
1421         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1422         create-bug raises exception after entering bug description
1423
1424         Reviewed by David Kilzer.
1425
1426         * Scripts/bugzilla-tool:
1427         (CreateBug): else clauses are only hit if no exception is raised, so
1428         it makes no sense to try to re-raise the exception in an else clause.
1429         The exception will automatically be re-raised if it doesn't match any
1430         of the except clauses, so we don't have to do anything special here at
1431         all to get the desired behavior.
1432
1433 2009-11-04  Eric Seidel  <eric@webkit.org>
1434
1435         Reviewed by David Kilzer.
1436
1437         svn-apply's fixChangeLogPatch function seems broken
1438         https://bugs.webkit.org/show_bug.cgi?id=30683
1439
1440         Update fixChangeLogPatch to be able to handle patches which
1441         don't start at line 1.
1442         Add unit tests for svn-apply to scm_unittest.py.
1443
1444         * Scripts/VCSUtils.pm:
1445         * Scripts/modules/scm_unittest.py:
1446
1447 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1448
1449         Reviewed by Beth Dakin.
1450
1451         Need to implement ARIA role="combobox"
1452         https://bugs.webkit.org/show_bug.cgi?id=31096
1453
1454         * DumpRenderTree/AccessibilityUIElement.cpp:
1455         (showMenuCallback):
1456         (getIsExpandedCallback):
1457         (AccessibilityUIElement::getJSClass):
1458         * DumpRenderTree/AccessibilityUIElement.h:
1459         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1460         (AccessibilityUIElement::isExpanded):
1461         (AccessibilityUIElement::showMenu):
1462         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1463         (AccessibilityUIElement::isExpanded):
1464         (AccessibilityUIElement::showMenu):
1465         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1466         (AccessibilityUIElement::isSelected):
1467         (AccessibilityUIElement::isExpanded):
1468         (AccessibilityUIElement::showMenu):
1469
1470 2009-11-04  Eric Seidel  <eric@webkit.org>
1471
1472         Reviewed by Adam Barth.
1473
1474         commit-queue is crashing when trying to reject patches after unknown failures
1475         https://bugs.webkit.org/show_bug.cgi?id=31091
1476
1477         * Scripts/bugzilla-tool:
1478          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1479            so we have to find out what the current patch is by asking bugzilla again.
1480          - Discovered that this code was also leaking file descriptors, so fixed that.
1481
1482 2009-11-04  Adam Roben  <aroben@apple.com>
1483
1484         Make run-webkit-tests work for the Debug_Internal Windows
1485         configuration
1486
1487         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1488         suffix.
1489
1490         Fixes <http://webkit.org/b/31123>.
1491
1492         Reviewed by Sam Weinig.
1493
1494         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1495         Debug_Internal, either.
1496
1497 2009-11-04  Eric Seidel  <eric@webkit.org>
1498
1499         Reviewed by Adam Barth.
1500
1501         committers.py needs a way to store non-bugzilla email addresses
1502         https://bugs.webkit.org/show_bug.cgi?id=31037
1503
1504         Make Committer and Reviewer constructors take a single email or a list of emails.
1505         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1506         Expose reviewers(), used by validate-committer-lists on bug 30970.
1507
1508         * Scripts/modules/committers.py:
1509         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1510
1511 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1512
1513         Reviewed by David Levin.
1514
1515         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1516         https://bugs.webkit.org/show_bug.cgi?id=27491
1517
1518         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1519         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1520
1521         Functions to start or stop Web Socket servers are added.
1522
1523         * Scripts/run-webkit-tests:
1524
1525 2009-11-03  Eric Seidel  <eric@webkit.org>
1526
1527         No review, just changing wording of log message.
1528
1529         Change log string to say "failed" instead of "rejected"
1530         when a commit fails due to an out of date checkout.
1531         This makes grepping the commit-queue log for rejected patches easier.
1532
1533         * Scripts/bugzilla-tool:
1534
1535 2009-11-03  Eric Seidel  <eric@webkit.org>
1536
1537         No review, adding commonly known committers missing from the file.
1538
1539         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1540
1541 2009-11-03  Eric Seidel  <eric@webkit.org>
1542
1543         No review, just sort-order cleanup.
1544
1545         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1546
1547 2009-11-03  Stephen White  <senorblanco@chromium.org>
1548
1549         (Unreviewed).
1550
1551         Add myself to committers.py.
1552
1553         * Scripts/modules/committers.py:
1554
1555 2009-11-03  Robin Dunn  <robin@alldunn.com>
1556
1557         Reviewed by Kevin Ollviier.
1558
1559         Add packaging scripts for Debian-based Linux distros.
1560         
1561         https://bugs.webkit.org/show_bug.cgi?id=31075
1562
1563         * wx/packaging/build-debian-installer.py: Added.
1564         * wx/packaging/debian: Added.
1565
1566 2009-11-03  Dan Bernstein  <mitz@apple.com>
1567
1568         Reviewed by Anders Carlsson and Beth Dakin.
1569
1570         https://bugs.webkit.org/show_bug.cgi?id=31070
1571
1572         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1573         destroyed, it executes the value of the 'ondestroy' parameter as a
1574         script.
1575
1576         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1577         (pluginAllocate): Initialize onDestroy.
1578         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1579         onDestroy.
1580         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1581         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
1582         specified.
1583         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
1584
1585 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1586
1587         Reviewed by Xan Lopez.
1588
1589         https://bugs.webkit.org/show_bug.cgi?id=31035
1590         [GTK] some accessibility tests hitting assertion in debug builds
1591
1592         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
1593
1594         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1595         (AccessibilityController::rootElement):
1596
1597 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
1598
1599         Reviewed by Beth Dakin.
1600
1601         Support ARIA "tab" roles
1602         https://bugs.webkit.org/show_bug.cgi?id=30842
1603
1604         * DumpRenderTree/AccessibilityUIElement.cpp:
1605         * DumpRenderTree/AccessibilityUIElement.h:
1606         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1607         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1608         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1609
1610 2009-11-01  Eric Seidel  <eric@webkit.org>
1611
1612         Reviewed by David Levin.
1613
1614         buildbots should use --exit-after-N-failures
1615         https://bugs.webkit.org/show_bug.cgi?id=30809
1616
1617         Make the bots exit after 20 failures to prevent never-ending
1618         test runs where every test spends a minute crashing.
1619
1620         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1621
1622 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1623
1624         Reviewed by Eric Seidel.
1625
1626         Turn on warnings for QtWebKit for gcc
1627         https://bugs.webkit.org/show_bug.cgi?id=30958
1628
1629         * DumpRenderTree/qt/main.cpp: 
1630         (crashHandler): Mark function NO_RETURN
1631
1632 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
1633
1634         Adding myself to the committers list.
1635
1636         * Scripts/modules/committers.py:
1637
1638 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
1639
1640         Fix an issue that Adam noticed in DRT.
1641
1642         Reviewed by Darin Adler.
1643
1644         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1645         (AccessibilityUIElement::role):
1646         Get the length of the role text, and create a buffer dynamically.
1647
1648 2009-10-30  Eric Seidel  <eric@webkit.org>
1649
1650         No review, rolling out r50105.
1651         http://trac.webkit.org/changeset/50105
1652
1653         This commit was causing:
1654         https://bugs.webkit.org/show_bug.cgi?id=30869
1655         We'll re-implement the feature a different way.
1656
1657         * Scripts/bugzilla-tool:
1658
1659 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1660
1661         Test for MSAA: Accessibility of headings is not correct
1662
1663         https://bugs.webkit.org/show_bug.cgi?id=30937
1664
1665         Reviewed by Adam Roben.
1666
1667         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1668         (AccessibilityUIElement::role):
1669         Allow the role returned to be a BSTR.
1670         (AccessibilityUIElement::description):
1671         Fix a copy/paste error.
1672
1673 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1674
1675         Test for MSAA: Accessibility of links is wrong
1676
1677         https://bugs.webkit.org/show_bug.cgi?id=30928
1678
1679         Reviewed by Darin Adler.
1680
1681         * DumpRenderTree/AccessibilityUIElement.cpp:
1682         (getAccessibilityValueCallback):
1683         Return the accessibility value.
1684         (AccessibilityUIElement::getJSClass):
1685         Added "accessibilityValue" value.
1686
1687         * DumpRenderTree/AccessibilityUIElement.h:
1688
1689         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1690         (AccessibilityUIElement::accessibilityValue):
1691         Stubbed.
1692
1693         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1694         (AccessibilityUIElement::accessibilityValue):
1695         Stubbed.
1696
1697         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1698         (AccessibilityUIElement::accessibilityValue):
1699         Get the object's value, and return it as a JS string.
1700
1701 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
1702
1703         Fix typo in command name used by wx build system.
1704
1705         * wx/build/build_utils.py:
1706
1707 2009-10-30  Adam Barth  <abarth@webkit.org>
1708
1709         Reviewed by Darin Adler.
1710
1711         Patch v1 is a dumb default name for patches
1712         https://bugs.webkit.org/show_bug.cgi?id=30952
1713
1714         Let's use "Patch" instead.
1715
1716         * Scripts/bugzilla-tool:
1717
1718 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1719
1720         Unreviewed trivial buildfix.
1721
1722         [Qt] Buildfix for r50333.
1723
1724         * DumpRenderTree/qt/DumpRenderTree.pro:
1725
1726 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
1727
1728         Reviewed by Holger Freyther.
1729
1730         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
1731         https://bugs.webkit.org/show_bug.cgi?id=30953
1732
1733         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
1734         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
1735         makes qt DRT to share this implementation (as gtk and mac ports do).
1736
1737         * DumpRenderTree/qt/DumpRenderTree.pro:
1738         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
1739         * DumpRenderTree/qt/WorkQueue.h: Removed.
1740
1741 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1742
1743         Unreviewed potential buildbot fix.
1744
1745         Second try: Reset page history before running each test.
1746
1747         Apparently the QWebHistory::clear() keeps the current page
1748         in history which is not what we want, so we not additionally
1749         sets the history capacity to 0 (forces removing everything)
1750         and then sets it back to its original value.
1751
1752         * DumpRenderTree/qt/DumpRenderTree.cpp:
1753         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1754
1755 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1756
1757         Unreviewed potential buildbot fix.
1758
1759         Reset page history before running each test.
1760
1761         * DumpRenderTree/qt/DumpRenderTree.cpp:
1762         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1763
1764 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
1765
1766         Reviewed by Eric Seidel.
1767
1768         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
1769
1770         Bug 28420 -  Implement HTML5 <ruby> rendering
1771         (https://bugs.webkit.org/show_bug.cgi?id=28420)
1772
1773         No new tests (no functional change).
1774
1775         * Scripts/build-webkit:
1776
1777 2009-10-29  Dan Bernstein  <mitz@apple.com>
1778
1779         Reviewed by Mark Rowe.
1780
1781         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
1782         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
1783         define it.
1784
1785         * Scripts/VCSUtils.pm:
1786         * Scripts/svn-apply:
1787         * Scripts/svn-unapply:
1788
1789 2009-10-29  Xan Lopez  <xlopez@igalia.com>
1790
1791         Reviewed by Gustavo Noronha.
1792
1793         Use the GTK+ main loop instead of rolling our own mini-version of
1794         it.
1795
1796         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1797         (dump):
1798         (runTest):
1799         (webViewLoadFinished):
1800
1801 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1802
1803         Reviewed by Oliver Hunt.
1804
1805         Implement the Qt version of DRT dumpBackForwardList().
1806
1807         * DumpRenderTree/qt/DumpRenderTree.cpp:
1808         (WebCore::dumpHistoryItem):
1809         (WebCore::DumpRenderTree::dumpBackForwardList):
1810
1811 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1812
1813         Reviewed by Adam Roben.
1814
1815         Implement DRT functionality for Qt introduced in
1816         r28690 and r28705.
1817
1818         - Implemented pathToLocalResource which exposes the functionality of
1819         converting a given unix path to the correct location on Windows.
1820         - Implemented a way to remove machine-dependent information from paths
1821         in layout test results.
1822
1823         * DumpRenderTree/qt/DumpRenderTree.cpp:
1824         (WebCore::urlSuitableForTestResult):
1825         (WebCore::WebPage::javaScriptConsoleMessage):
1826         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1827         (LayoutTestController::pathToLocalResource):
1828         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1829
1830 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
1831
1832         Adding myself to the committers list.
1833
1834         * Scripts/modules/committers.py:
1835
1836 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
1837
1838         Adding myself to the committers list.
1839
1840         * Scripts/modules/committers.py:
1841
1842 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1843
1844         Reviewed by Jan Alonzo.
1845
1846         [GTK] API to start inspector for a WebView
1847         https://bugs.webkit.org/show_bug.cgi?id=22551
1848
1849         Use the new inspector API to implement the LayoutTestController
1850         interfaces used to test the inspector.
1851
1852         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1853         (webInspectorInspectWebView):
1854         (createWebView):
1855         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1856         (LayoutTestController::showWebInspector):
1857         (LayoutTestController::closeWebInspector):
1858         (LayoutTestController::evaluateInWebInspector):
1859
1860 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
1861
1862         Reviewed by Eric Seidel.
1863
1864         [Qt] WebFrame::counterValueForElementById must not be exposed
1865         https://bugs.webkit.org/show_bug.cgi?id=30882
1866
1867         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1868         (LayoutTestController::counterValueForElementById):
1869
1870 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1871
1872         Rubberstamped by Oliver Hunt.
1873
1874         Fix the warning:
1875
1876         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
1877         declared with attribute warn_unused_result".
1878
1879         by actually checking the result. In the case it is null, an
1880         error has occoured, so treat it as the other fatal errors.
1881
1882         * DumpRenderTree/qt/DumpRenderTree.cpp:
1883         (WebCore::DumpRenderTree::initializeFonts):
1884
1885 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
1886
1887         Reviewed by Darin Adler.
1888
1889         Provide a way to get counter values with layoutTestContoller
1890         https://bugs.webkit.org/show_bug.cgi?id=30555
1891
1892         Define layoutTestContoller.counterValueForElementById.
1893
1894         * DumpRenderTree/LayoutTestController.cpp:
1895         (counterValueForElementByIdCallback):
1896         (LayoutTestController::staticFunctions):
1897         * DumpRenderTree/LayoutTestController.h:
1898         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1899         (LayoutTestController::counterValueForElementById):
1900
1901 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1902
1903         Rubberstamped by Oliver Hunt.
1904
1905         Change two methods to be internal for DRT use only.
1906
1907         Part of [Qt] Review all new API in Qt 4.6
1908         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
1909
1910         * DumpRenderTree/qt/DumpRenderTree.cpp:
1911         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1912         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1913         (LayoutTestController::whiteListAccessFromOrigin):
1914
1915 2009-10-27  Eric Seidel  <eric@webkit.org>
1916
1917         Reviewed by Adam Barth.
1918
1919         REGRESSION: svn-apply exits(1) when applying a patch with a file add
1920         https://bugs.webkit.org/show_bug.cgi?id=30826
1921
1922         * Scripts/svn-apply:
1923          - Add () around all system() calls.
1924          - Use the correct system() == 0 or die instead of system() or die
1925          - Add descriptive messages to all die statements.
1926
1927 2009-10-27  Steve Block  <steveblock@google.com>
1928
1929         Reviewed by NOBODY.
1930
1931         Adds steveblock@google.com to list of committers.
1932
1933         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
1934
1935 2009-10-27  Eric Seidel  <eric@webkit.org>
1936
1937         Reviewed by Adam Barth.
1938
1939         svn-apply can exit(0) even on patch failure
1940         https://bugs.webkit.org/show_bug.cgi?id=29622
1941
1942         * Scripts/svn-apply:
1943          - Add a bunch of "or die" statements, hopefully catching all
1944            possible cases where failure could still exit(0).
1945
1946 2009-10-27  Eric Seidel  <eric@webkit.org>
1947
1948         Reviewed by Adam Barth.
1949
1950         svn-* scripts should share code through VCSUtils.pm
1951         https://bugs.webkit.org/show_bug.cgi?id=30791
1952
1953         Just moving code into a shared location.
1954
1955         * Scripts/VCSUtils.pm:
1956         * Scripts/prepare-ChangeLog:
1957         * Scripts/resolve-ChangeLogs:
1958         * Scripts/svn-apply:
1959         * Scripts/svn-create-patch:
1960         * Scripts/svn-unapply:
1961         * Scripts/update-webkit:
1962
1963 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
1964
1965         Suppress a huge number of MSVC warnings when building wxWebKit.
1966
1967         * wx/build/settings.py:
1968
1969 2009-10-26  Eric Seidel  <eric@webkit.org>
1970
1971         No review, just adding Mike Belshe to the committers list.
1972
1973         * Scripts/modules/committers.py:
1974
1975 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1976
1977         Reviewed by Darin Adler.
1978
1979         Make .rc files compile on Windows without depending on MFC headers
1980         https://bugs.webkit.org/show_bug.cgi?id=30750
1981
1982         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
1983         windows.h instead of afxres.h because it exists even when MFC is not 
1984         installed, and is all that's needed here.
1985
1986         * FindSafari/FindSafari.rc: Ditto
1987
1988 2009-10-24  Eric Seidel  <eric@webkit.org>
1989
1990         Reviewed by Adam Barth.
1991
1992         bugzilla-tool post-diff should know how to mark commit-queue=?
1993         https://bugs.webkit.org/show_bug.cgi?id=29202
1994
1995         * Scripts/bugzilla-tool:
1996          - Add --commit-queue option to post-diff, post-commits and create-bug.
1997         * Scripts/modules/bugzilla.py:
1998          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
1999          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2000
2001 2009-10-23  Eric Seidel  <eric@webkit.org>
2002
2003         Reviewed by Adam Barth.
2004
2005         bugzilla-tool commit-queue does not notice modifications to committers.py
2006         https://bugs.webkit.org/show_bug.cgi?id=30084
2007
2008         * Scripts/bugzilla-tool:
2009          - Make commit-queue re-exec itself instead of using while(1).
2010          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2011          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2012
2013 2009-10-22  Eric Seidel  <eric@webkit.org>
2014
2015         Reviewed by Adam Barth.
2016
2017         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2018         https://bugs.webkit.org/show_bug.cgi?id=30634
2019
2020         * Scripts/bugzilla-tool:
2021          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2022          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2023
2024 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2025
2026         Reviewed by Eric Seidel.
2027
2028         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2029
2030         https://bugs.webkit.org/show_bug.cgi?id=30763
2031
2032         * pywebsocket/mod_pywebsocket/__init__.py:
2033         * pywebsocket/mod_pywebsocket/dispatch.py:
2034         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2035         * pywebsocket/mod_pywebsocket/standalone.py:
2036         * pywebsocket/setup.py:
2037         * pywebsocket/test/test_dispatch.py:
2038
2039 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2040
2041         Reviewed by David Levin.
2042
2043         REGRESSION: 2 failures in run-webkit-unittests
2044         https://bugs.webkit.org/show_bug.cgi?id=30645
2045
2046         * Scripts/modules/cpp_style_unittest.py:
2047         Fixed a few test scenarios which apparently lost some spaces from 
2048         text literals.
2049
2050 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2051
2052         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2053
2054         * Scripts/webkitdirs.pm:
2055
2056 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2057
2058         Reviewed by Darin Adler.
2059
2060         Unification of using null device in perl scripts.
2061         https://bugs.webkit.org/show_bug.cgi?id=30572
2062
2063         * Scripts/VCSUtils.pm:
2064         * Scripts/bisect-builds:
2065         * Scripts/resolve-ChangeLogs:
2066         * Scripts/run-iexploder-tests:
2067         * Scripts/run-jsc:
2068         * Scripts/run-mangleme-tests:
2069         * Scripts/run-webkit-tests:
2070         * Scripts/webkitdirs.pm:
2071         Using File::Spec->devnull() instead of hard coded /dev/null.
2072
2073 2009-10-26  Eric Seidel  <eric@webkit.org>
2074
2075         Reviewed by Holger Freyther.
2076
2077         Reviewers are missing from committers.py
2078         https://bugs.webkit.org/show_bug.cgi?id=30733
2079
2080         * Scripts/modules/committers.py:
2081
2082 2009-10-23  Eric Seidel  <eric@webkit.org>
2083
2084         No review, only adding Alice to the list of reviewers.
2085
2086         * Scripts/modules/committers.py:
2087
2088 2009-10-23  Eric Seidel  <eric@webkit.org>
2089
2090         Reviewed by Eric Carlson.
2091
2092         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2093         https://bugs.webkit.org/show_bug.cgi?id=30700
2094
2095         * DumpRenderTree/mac/DumpRenderTree.mm:
2096         (resetDefaultsToConsistentValues): Update QuickTime version check.
2097
2098 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2099
2100         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2101         character measurement APIs that are private on Tiger.
2102
2103         * wx/build/settings.py:
2104
2105 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2106
2107         Reviewed by NOBODY (build fix).
2108         Build fix following bug #30696.
2109
2110         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2111         (LayoutTestController::evaluateScriptInIsolatedWorld):
2112
2113 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2114
2115         Reviewed by Sam Weinig & Geoff Garen.
2116
2117         https://bugs.webkit.org/show_bug.cgi?id=30696
2118         Enable isolated-worlds tests on mac.
2119
2120         Add private interface for DRT to invoke execution in a given world.
2121
2122         * DumpRenderTree/LayoutTestController.cpp:
2123         (evaluateScriptInIsolatedWorldCallback):
2124         (LayoutTestController::staticFunctions):
2125         * DumpRenderTree/LayoutTestController.h:
2126         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2127         (LayoutTestController::evaluateScriptInIsolatedWorld):
2128         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2129         (LayoutTestController::evaluateScriptInIsolatedWorld):
2130
2131 2009-10-21  Eric Seidel  <eric@webkit.org>
2132
2133         Reviewed by Adam Barth.
2134
2135         bugzilla-tool's "patch failed to download an apply" error should give more information
2136         https://bugs.webkit.org/show_bug.cgi?id=30632
2137
2138         * Scripts/modules/scm.py:
2139          - Use the common run_command method instead of custom POpen code.
2140          - Make run_command know how to take pipes as input.
2141         * Scripts/modules/scm_unittest.py:
2142          - Add new tests to cover change.
2143          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2144
2145 2009-10-21  Kent Tamura  <tkent@chromium.org>
2146
2147         Unreviewed.  Adding myself to the committers list.
2148
2149         * Scripts/modules/committers.py:
2150
2151 2009-10-21  Robin Dunn  <robin@alldunn.com>
2152
2153         Reviewed by Kevin Ollivier.
2154
2155         Update the Windows installer builder to work with Vista / Win 7 and with git.
2156         
2157         https://bugs.webkit.org/show_bug.cgi?id=30649
2158
2159         * wx/build/build_utils.py:
2160         * wx/packaging/build-mac-installer.py:
2161         * wx/packaging/build-win-installer.py:
2162         * wx/packaging/wxWebKitInstaller.iss.in:
2163
2164 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2165
2166         Reviewed by Gustavo Noronha.
2167
2168         [GTK] Added conditional code to avoid using
2169         gdk_window_get_root_coords if we do not have a gtk+ release newer
2170         than 2.17.3.
2171         https://bugs.webkit.org/show_bug.cgi?id=30636
2172
2173         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2174
2175 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2176
2177         Reviewed by Eric Seidel.
2178
2179         [Qt] Added dummy implementation for keepWebHistory()
2180         https://bugs.webkit.org/show_bug.cgi?id=30592
2181
2182         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2183         (LayoutTestController::keepWebHistory):
2184         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2185
2186 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2187
2188         Reviewed by Xan Lopez.
2189
2190         [GTK] Fixed the double click condition, it is not double click if
2191         we move in just in one direction.
2192         https://bugs.webkit.org/show_bug.cgi?id=30636
2193
2194         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2195
2196 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2197
2198         Reviewed by Xan Lopez.
2199
2200         [GTK] Initialize the events completly before emitting them.
2201         https://bugs.webkit.org/show_bug.cgi?id=30633
2202
2203         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2204
2205 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2206
2207         wx build fix. Fix for when linking using --as-needed with gcc.
2208
2209         * wx/browser/wscript:
2210
2211 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2212
2213         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2214         to support all the features used by CURL backend.
2215         
2216         * wx/build/settings.py:
2217         * wx/install-unix-extras:
2218
2219 2009-10-20  Anton Muhin  <antonm@chromium.org>
2220
2221         Reviewed by Adam Barth.
2222
2223         Add {ager,antonm,yurys}@chromium.org into committers.py
2224         https://bugs.webkit.org/show_bug.cgi?id=30560
2225
2226         * Scripts/modules/committers.py:
2227
2228 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2229
2230         Reviewed by Tor Arne Vestbø.
2231
2232         Make the Netscape Test plugin available to the Qt launcher.
2233
2234         * Scripts/run-launcher:
2235
2236 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2237
2238         Reviewed by David Levin.
2239
2240         Removed WebSocket runtime settings.
2241         https://bugs.webkit.org/show_bug.cgi?id=29896
2242
2243         WebSocket runtime configuration is supported by chromium/v8 only.
2244
2245         * DumpRenderTree/mac/DumpRenderTree.mm:
2246         (resetDefaultsToConsistentValues):
2247         * DumpRenderTree/win/DumpRenderTree.cpp:
2248         (resetDefaultsToConsistentValues):
2249
2250 2009-10-19  Nate Chapin  <japhet@chromium.org>
2251
2252         Reviewed by Adam Barth.
2253
2254         Add testFail() to test plugin so we can test our handling of a
2255         plugin invoke call returning false.
2256
2257         https://bugs.webkit.org/show_bug.cgi?id=30239
2258
2259         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2260         (pluginInvoke):
2261         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2262
2263 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2264
2265         Reviewed by Gustavo Noronha.
2266
2267         Enable DOM pasting when running layout tests.
2268
2269         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2270         (resetDefaultsToConsistentValues):
2271
2272 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2273
2274         Reviewed by Simon Hausmann.
2275
2276         Use the setPreferredContentsSize method instead
2277         of setFixedContentsSize, as the method has been renamed.
2278
2279         * DumpRenderTree/qt/DumpRenderTree.cpp:
2280         (WebCore::DumpRenderTree::open):
2281         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2282         (LayoutTestController::setFixedContentsSize):
2283
2284 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2285
2286         Reviewed by Dan Bernstein.
2287
2288         https://bugs.webkit.org/show_bug.cgi?id=30456
2289         Fixes for new Debug_All Windows build configuration.
2290
2291         * DumpRenderTree/win/DumpRenderTree.cpp:
2292         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2293         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2294
2295 2009-10-16  Eric Seidel  <eric@webkit.org>
2296
2297         Reviewed by Adam Barth.
2298
2299         commit-queue status bot should list which buildbot is blocking the queue
2300         https://bugs.webkit.org/show_bug.cgi?id=30452
2301
2302         Add new methods and testing.
2303
2304         * Scripts/bugzilla-tool:
2305         * Scripts/modules/buildbot.py:
2306         * Scripts/modules/buildbot_unittest.py:
2307
2308 2009-10-16  Eric Seidel  <eric@webkit.org>
2309
2310         Reviewed by Adam Barth.
2311
2312         run-webkit-tests fails when CWD is not inside a WebKit checkout
2313         https://bugs.webkit.org/show_bug.cgi?id=30451
2314
2315         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2316         * Scripts/modules/scm_unittest.py:
2317           - Remove use of original_path (we don't need to restore the CWD).
2318           - Don't use '.' to find the webkit checkout, use __file__ instead.
2319
2320 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2321
2322         Reviewed by Adam Roben.
2323
2324         Add a Debug_All configuration to build entire stack as debug.
2325         Change Debug_Internal to:
2326         - stop using _debug suffix for all WebKit/Safari binaries
2327         - not use _debug as a DLL naming suffix
2328         - use non-debug C runtime lib.
2329
2330         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2331         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2332         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2333         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2334         Add missing debug.vsprops inherited property sheet.
2335         Add Debug_All configuration.
2336         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2337         * WinLauncher/WinLauncher.vcproj:
2338         Removed extraneous definitions inherited from vsprops.
2339         Add Debug_All configuration.
2340
2341 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2342
2343         Reviewed by David Levin.
2344
2345         check-webkit-style is wrong about indent checking in namespaces
2346         in header files and a few other things
2347         https://bugs.webkit.org/show_bug.cgi?id=30362
2348
2349         The few other things include:
2350         + check-webkit-style does not require spaces around the equal sign
2351           inside 'if' statements and around binary operators that take 
2352           numeric literals.
2353         + check-webkit-style reports false errors for the / operator
2354           when part of a filename in the #include directive.
2355
2356         * Scripts/modules/cpp_style.py:
2357         Improved indentation checking and space checking around
2358         binary operators. While the checks are still not perfect,
2359         they are clearly better than before.
2360         * Scripts/modules/cpp_style_unittest.py:
2361         Added test cases for the newly supported checks and modified old
2362         test cases to match the new guidelines
2363
2364 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2365
2366         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2367
2368         * wx/build/settings.py:
2369
2370 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2371
2372         Reviewed by David Levin.
2373
2374         Add mod_pywebsocket to test Web Sockets.
2375         http://code.google.com/p/pywebsocket/
2376         https://bugs.webkit.org/show_bug.cgi?id=27490
2377
2378         * pywebsocket/COPYING: Added.
2379         * pywebsocket/MANIFEST.in: Added.
2380         * pywebsocket/README: Added.
2381         * pywebsocket/example/echo_client.py: Added.
2382         * pywebsocket/example/echo_wsh.py: Added.
2383         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2384         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2385         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2386         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2387         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2388         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2389         * pywebsocket/mod_pywebsocket/util.py: Added.
2390         * pywebsocket/setup.py: Added.
2391         * pywebsocket/test/config.py: Added.
2392         * pywebsocket/test/mock.py: Added.
2393         * pywebsocket/test/run_all.py: Added.
2394         * pywebsocket/test/test_dispatch.py: Added.
2395         * pywebsocket/test/test_handshake.py: Added.
2396         * pywebsocket/test/test_mock.py: Added.
2397         * pywebsocket/test/test_msgutil.py: Added.
2398         * pywebsocket/test/test_util.py: Added.
2399         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2400         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2401         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2402         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2403         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2404         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2405         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2406         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2407
2408 2009-10-15  James Robinson  <jamesr@google.com>
2409
2410         Reviewed by David Levin.
2411
2412         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2413
2414         https://bugs.webkit.org/show_bug.cgi?id=30426
2415
2416         * Scripts/modules/cpp_style.py:
2417         * Scripts/modules/cpp_style_unittest.py:
2418
2419 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2420
2421         Reviewed by Adam Roben.
2422
2423         Fixes <http://webkit.org/b/30411>.
2424         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2425         
2426         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2427         building Chromium.
2428
2429         * Scripts/pdevenv:
2430
2431 2009-10-15  Robin Dunn  <robin@alldunn.com>
2432
2433         Reviewed by Kevin Ollivier.
2434
2435         Add Mac package building scripts for wx.
2436         
2437         https://bugs.webkit.org/show_bug.cgi?id=30405
2438
2439         * wx/build/build_utils.py:
2440         * wx/build/settings.py:
2441         * wx/packaging/build-mac-installer.py: Added.
2442
2443 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2444
2445         Reviewed by Gustavo Noronha.
2446
2447         Enable Web Sockets support when running layout tests.
2448
2449         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2450         (resetDefaultsToConsistentValues):
2451
2452 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2453
2454         Reviewed by Gustavo Noronha.
2455
2456         Need to initialize event.button.button, since in most cases a
2457         button number is not passed as an argument.
2458
2459         * DumpRenderTree/gtk/EventSender.cpp:
2460         (mouseDownCallback):
2461         (mouseUpCallback):
2462
2463 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2464
2465         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2466         the OS if none was explicitly set.
2467
2468         * wx/build/settings.py:
2469
2470 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2471
2472         Reviewed by Timothy Hatcher.
2473
2474         Web Inspector: enable developers extras within inspector layout tests.
2475
2476         https://bugs.webkit.org/show_bug.cgi?id=30014
2477
2478         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2479         (LayoutTestController::showWebInspector):
2480         (LayoutTestController::closeWebInspector):
2481         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2482         (LayoutTestController::showWebInspector):
2483         (LayoutTestController::closeWebInspector):
2484
2485 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2486
2487         Reviewed by Jan Alonzo.
2488
2489         GtkLauncher is using a deprecated signal
2490         https://bugs.webkit.org/show_bug.cgi?id=30364
2491
2492         Modified GtkLauncher to use notify::title signal instead of
2493         deprecated title-changed signal
2494
2495         * GtkLauncher/main.c:
2496         (notify_title_cb):
2497         (create_browser):
2498
2499 2009-10-14  Brady Eidson  <beidson@apple.com>
2500
2501         Reviewed by Sam Weinig.
2502
2503         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2504         1 - Disables WebHistory
2505         2 - Doesn't make sense in that context anyway.
2506
2507         * DumpRenderTree/win/DumpRenderTree.cpp:
2508         (createWebViewAndOffscreenWindow):
2509
2510 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2511
2512         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2513         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2514
2515         * wx/build/settings.py:
2516         * wx/install-unix-extras:
2517
2518 2009-10-14  Brady Eidson  <beidson@apple.com>
2519
2520         Reviewed by Sam Weinig.
2521
2522         WebKit Win API should provide a delegate interface for global history.
2523         https://bugs.webkit.org/show_bug.cgi?id=29905
2524
2525         * DumpRenderTree/LayoutTestController.cpp:
2526         (LayoutTestController::LayoutTestController):
2527         * DumpRenderTree/LayoutTestController.h:
2528         (LayoutTestController::dumpHistoryDelegateCallbacks):
2529         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2530                 
2531         * DumpRenderTree/win/DumpRenderTree.cpp:
2532         (shouldLogHistoryDelegates):
2533         (runTest):
2534         (createWebViewAndOffscreenWindow):
2535         (main):
2536         * DumpRenderTree/win/DumpRenderTree.vcproj:
2537         
2538         Add the IWebHistoryDelegate to DRT Windows:
2539         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2540         (wstringFromBSTR):
2541         (HistoryDelegate::HistoryDelegate):
2542         (HistoryDelegate::~HistoryDelegate):
2543         (HistoryDelegate::QueryInterface):
2544         (HistoryDelegate::AddRef):
2545         (HistoryDelegate::Release):
2546         (HistoryDelegate::didNavigateWithNavigationData):
2547         (HistoryDelegate::didPerformClientRedirectFromURL):
2548         (HistoryDelegate::didPerformServerRedirectFromURL):
2549         (HistoryDelegate::updateHistoryTitle):
2550         (HistoryDelegate::populateVisitedLinksForWebView):
2551         * DumpRenderTree/win/HistoryDelegate.h: Added.
2552
2553         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2554         (LayoutTestController::removeAllVisitedLinks):
2555
2556 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2557
2558         Reviewed by Simon Hausmann.
2559
2560         [Qt] Implement support for setPOSIXLocale on Qt.
2561         https://bugs.webkit.org/show_bug.cgi?id=30268 
2562  
2563         * DumpRenderTree/qt/DumpRenderTree.cpp:
2564         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2565         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2566         (LayoutTestController::setPOSIXLocale):
2567         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2568
2569 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2570
2571         Unreviewed, adding myself to reviewers list.
2572
2573         * Scripts/modules/committers.py:
2574
2575 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2576
2577         Reviewed by Mark Rowe.
2578
2579         Fix null assignment so root tests work again.
2580
2581         * Scripts/webkitdirs.pm:
2582
2583 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2584
2585         Reviewed by Simon Hausmann.
2586
2587         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
2588         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
2589         This is done in preparation of implementing missing features in DRT.
2590         No functionality changes made yet.
2591
2592         * DumpRenderTree/qt/DumpRenderTree.cpp:
2593         * DumpRenderTree/qt/DumpRenderTree.pro:
2594         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
2595         (EventSender::EventSender):
2596         (EventSender::mouseDown):
2597         (EventSender::mouseUp):
2598         (EventSender::mouseMoveTo):
2599         (EventSender::leapForward):
2600         (EventSender::keyDown):
2601         (EventSender::contextClick):
2602         (EventSender::scheduleAsynchronousClick):
2603         (EventSender::frameUnderMouse):
2604         * DumpRenderTree/qt/EventSenderQt.h: Added.
2605         (EventSender::clearKillRing):
2606         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
2607         (LayoutTestController::LayoutTestController):
2608         (LayoutTestController::reset):
2609         (LayoutTestController::processWork):
2610         (LayoutTestController::maybeDump):
2611         (LayoutTestController::waitUntilDone):
2612         (LayoutTestController::notifyDone):
2613         (LayoutTestController::windowCount):
2614         (LayoutTestController::clearBackForwardList):
2615         (LayoutTestController::dumpEditingCallbacks):
2616         (LayoutTestController::dumpResourceLoadCallbacks):
2617         (LayoutTestController::queueBackNavigation):
2618         (LayoutTestController::queueForwardNavigation):
2619         (LayoutTestController::queueLoad):
2620         (LayoutTestController::queueReload):
2621         (LayoutTestController::queueScript):
2622         (LayoutTestController::provisionalLoad):
2623         (LayoutTestController::timerEvent):
2624         (LayoutTestController::encodeHostName):
2625         (LayoutTestController::decodeHostName):
2626         (LayoutTestController::setJavaScriptProfilingEnabled):
2627         (LayoutTestController::setFixedContentsSize):
2628         (LayoutTestController::setPrivateBrowsingEnabled):
2629         (LayoutTestController::setPopupBlockingEnabled):
2630         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2631         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2632         (LayoutTestController::numberOfActiveAnimations):
2633         (LayoutTestController::disableImageLoading):
2634         (LayoutTestController::dispatchPendingLoadRequests):
2635         (LayoutTestController::setDatabaseQuota):
2636         (LayoutTestController::clearAllDatabases):
2637         (LayoutTestController::whiteListAccessFromOrigin):
2638         (LayoutTestController::waitForPolicyDelegate):
2639         (LayoutTestController::overridePreference):
2640         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
2641         (LayoutTestController::isLoading):
2642         (LayoutTestController::setLoading):
2643         (LayoutTestController::shouldDumpAsText):
2644         (LayoutTestController::shouldDumpBackForwardList):
2645         (LayoutTestController::shouldDumpChildrenAsText):
2646         (LayoutTestController::shouldDumpDatabaseCallbacks):
2647         (LayoutTestController::shouldDumpStatusCallbacks):
2648         (LayoutTestController::shouldWaitUntilDone):
2649         (LayoutTestController::canOpenWindows):
2650         (LayoutTestController::shouldDumpTitleChanges):
2651         (LayoutTestController::waitForPolicy):
2652         (LayoutTestController::dumpAsText):
2653         (LayoutTestController::dumpChildFramesAsText):
2654         (LayoutTestController::dumpDatabaseCallbacks):
2655         (LayoutTestController::dumpStatusCallbacks):
2656         (LayoutTestController::setCanOpenWindows):
2657         (LayoutTestController::dumpBackForwardList):
2658         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2659         (LayoutTestController::display):
2660         (LayoutTestController::dumpTitleChanges):
2661         (LayoutTestController::dumpSelectionRect):
2662         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
2663         (TextInputController::TextInputController):
2664         (TextInputController::doCommand):
2665         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
2666         * DumpRenderTree/qt/WorkQueue.cpp:
2667         * DumpRenderTree/qt/WorkQueue.h:
2668         * DumpRenderTree/qt/WorkQueueItem.h:
2669         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
2670         (findFrameNamed):
2671         (LoadItem::invoke):
2672         (ReloadItem::invoke):
2673         (ScriptItem::invoke):
2674         (BackForwardItem::invoke):
2675         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
2676         * DumpRenderTree/qt/jsobjects.h:
2677
2678 2009-10-13  Dmitry Titov  <dimich@chromium.org>
2679
2680         Not reviewed, adding myself to the list of reviewers.
2681
2682         * Scripts/modules/committers.py:
2683
2684 2009-10-13  Anders Carlsson  <andersca@apple.com>
2685
2686         Reviewed by Sam Weinig.
2687
2688         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
2689
2690         Make the private browsing mode testable by the test plug-in.
2691         
2692         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2693         (pluginGetProperty):
2694         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2695         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2696         (NPP_New):
2697         (NPP_SetValue):
2698
2699 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
2700
2701         No review, just adding self to the list of reviewers.
2702
2703         * Scripts/modules/committers.py:
2704
2705 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
2706
2707         Reviewed by Adam Roben.
2708
2709         Web Inspector: Use proper web view in inspector layout
2710         tests for windows.
2711
2712         https://bugs.webkit.org/show_bug.cgi?id=30298
2713
2714         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2715         (LayoutTestController::showWebInspector):
2716         (LayoutTestController::closeWebInspector):
2717         (LayoutTestController::evaluateInWebInspector):
2718
2719 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
2720
2721         Reviewed by Sam Weinig.
2722
2723         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
2724         https://bugs.webkit.org/show_bug.cgi?id=29841
2725
2726         * DumpRenderTree/mac/DumpRenderTree.mm:
2727         (resetDefaultsToConsistentValues):
2728         * DumpRenderTree/win/DumpRenderTree.cpp:
2729         (resetDefaultsToConsistentValues):
2730
2731 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
2732
2733         Reviewed by Dimitri Glazkov.
2734
2735         Chromium Port - Windows
2736         https://bugs.webkit.org/show_bug.cgi?id=29969
2737
2738         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
2739         * Scripts/webkitdirs.pm:
2740
2741 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
2742
2743         Reviewed by Darin Adler.
2744
2745         jsc scripts cleanup and Qt/GTK fix
2746         https://bugs.webkit.org/show_bug.cgi?id=30288
2747
2748         Duplicated jscPath() moved to webkitdirs.pm.
2749         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
2750         Configuration added (release/debug) to path for Qt-port on Windows.
2751
2752         * Scripts/run-javascriptcore-tests:
2753         * Scripts/run-jsc:
2754         * Scripts/run-sunspider:
2755         * Scripts/sunspider-compare-results:
2756         * Scripts/webkitdirs.pm:
2757
2758 2009-10-11  Adam Barth  <abarth@webkit.org>
2759
2760         Unreviewed.  Add Collin to committers.py.
2761
2762         * Scripts/modules/committers.py:
2763
2764 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
2765
2766         wx build fix, add bindings to source/include dirs now that there are sources there.
2767
2768         * wx/build/settings.py:
2769
2770 2009-10-09  Mark Rowe  <mrowe@apple.com>
2771
2772         Reviewed by Brady Eidson.
2773
2774         Enable plug-in halting in DumpRenderTree.
2775
2776         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
2777         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
2778
2779         * DumpRenderTree/mac/DumpRenderTree.mm:
2780         (resetDefaultsToConsistentValues):
2781         * DumpRenderTree/mac/UIDelegate.mm:
2782         (-[UIDelegate webView:shouldHaltPlugin:]):
2783
2784 2009-10-08  Brady Eidson  <beidson@apple.com>
2785
2786         Reviewed by Dan Bernstein.
2787
2788         Ask the History Delegate to populate the visited links hash.
2789         <rdar://problem/7285293> and https://webkit.org/b/29904
2790
2791         Add the ability for LayoutTestController to clear all visited links.
2792         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
2793
2794         * DumpRenderTree/LayoutTestController.cpp:
2795         (LayoutTestController::LayoutTestController):
2796         (removeAllVisitedLinksCallback):
2797         (LayoutTestController::staticFunctions):
2798         * DumpRenderTree/LayoutTestController.h:
2799         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2800         (LayoutTestController::removeAllVisitedLinks):
2801
2802         * DumpRenderTree/mac/HistoryDelegate.mm:
2803         (-[HistoryDelegate populateVisitedLinksForWebView:]):
2804
2805         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2806         (LayoutTestController::removeAllVisitedLinks):
2807         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2808         (LayoutTestController::removeAllVisitedLinks):
2809         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2810         (LayoutTestController::removeAllVisitedLinks):
2811
2812
2813 2009-10-08  Daniel Bates  <dbates@webkit.org>
2814
2815         Reviewed by Adam Roben.
2816
2817         https://bugs.webkit.org/show_bug.cgi?id=30175
2818         
2819         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
2820         the OLE drag-and-drop return value like the function it emulates. Currently, 
2821         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
2822         whether the drag-and-drop operation was successful or was cancelled.
2823         
2824         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
2825         return value according to whether the drop operation was successful or not.
2826
2827         * DumpRenderTree/win/EventSender.cpp:
2828         (doMouseUp): Added parameter oleDragAndDropReturnValue.
2829         (replaySavedEvents): Ditto.
2830         * DumpRenderTree/win/EventSender.h:
2831         * DumpRenderTree/win/UIDelegate.cpp:
2832         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
2833
2834 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2835
2836         Reviewed by Xan Lopez.
2837
2838         [GTK] Added support for a parameter setting the button that was
2839         pressed in the mouseDown function.
2840         https://bugs.webkit.org/show_bug.cgi?id=30220
2841
2842         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2843
2844 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2845
2846         Reviewed by Xan Lopez.
2847
2848         [GTK] Added a line to the bottom of the expected result to match
2849         the output of the test.
2850         https://bugs.webkit.org/show_bug.cgi?id=30220
2851
2852         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
2853         expected.txt:
2854
2855 2009-10-08  Adam Roben  <aroben@apple.com>
2856
2857         Use QueryInterface to get IWebInspectorPrivate
2858
2859         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
2860         accessed in a more standard way
2861
2862         Reviewed by John Sullivan and Tim Hatcher.
2863
2864         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2865         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
2866         by calling IWebViewPrivate::inspector, then use QueryInterface to get
2867         to the IWebInspectorPrivate interface.
2868
2869 2009-10-07  Adam Roben  <aroben@apple.com>
2870
2871         Implement DRT support for origin whitelisting
2872
2873         Fixes <http://webkit.org/b/30185>.
2874
2875         Reviewed by Eric Seidel.
2876
2877         * DumpRenderTree/win/DumpRenderTree.cpp:
2878         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
2879         whitelist, to match Mac DRT.
2880         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2881         (LayoutTestController::whiteListAccessFromOrigin): Call through to
2882         IWebViewPrivate::whiteListAccessFromOrigin.
2883
2884 2009-10-07  Brady Eidson  <beidson@apple.com>
2885
2886         Reviewed by Darin Adler.
2887
2888         Send title changes to the global history delegate.
2889         <rdar://problem/7285293> and https://webkit.org/b/29904
2890
2891         * DumpRenderTree/mac/HistoryDelegate.mm:
2892         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
2893
2894 2009-10-07  Adam Barth  <abarth@webkit.org>
2895
2896         Unreviewed.  Remove some folks from committers.py who were listed on
2897         the WebKit Team wiki page but who weren't actually listed as commit+.
2898         At some point, we should coorelate this list with the committers
2899         mailing list.
2900
2901         * Scripts/modules/committers.py:
2902
2903 2009-10-07  Adam Barth  <abarth@webkit.org>
2904
2905         Unreviewed.  Import a bunch of committers from the WebKit Team page on
2906         the wiki into committers.py.
2907
2908         * Scripts/modules/committers.py:
2909
2910 2009-10-07  Adam Barth  <abarth@webkit.org>
2911
2912         Unreviewed.  Added Aaron Boodman to committers.py.
2913
2914         * Scripts/modules/committers.py:
2915
2916 2009-10-07  Evan Martin  <evan@chromium.org>
2917
2918         Reviewed by Darin Adler.
2919
2920         Add API to LayoutTestController for re/setting the system locale.
2921         https://bugs.webkit.org/show_bug.cgi?id=18994
2922
2923         * DumpRenderTree/LayoutTestController.cpp:
2924         (setLocaleCallback):
2925         (LayoutTestController::staticFunctions):
2926         (LayoutTestController::setLocale):
2927         * DumpRenderTree/LayoutTestController.h:
2928
2929 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
2930
2931         Reviewed by Jan Alonzo.
2932
2933         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
2934         https://bugs.webkit.org/show_bug.cgi?id=29689
2935
2936         Build fix by adding -lfontconfig for DumpRenderTree.
2937
2938         * GNUmakefile.am:
2939
2940 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2941
2942         Reviewed by Simon Hausmann.
2943
2944         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
2945
2946         * Scripts/run-webkit-tests:
2947
2948 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2949
2950         Reviewed by Gustavo Noronha.
2951
2952         "delete" in EventSender is the backspace key, not the delete one.
2953
2954         * DumpRenderTree/gtk/EventSender.cpp:
2955         (keyDownCallback):
2956
2957 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2958
2959         Reviewed by Gustavo Noronha.
2960
2961         getChildrenWithRange expects as last parameter the end index, not
2962         the length of the range. Correct this and clarify the variable
2963         names to reflect how the code works.
2964
2965         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2966         (AccessibilityUIElement::getChildrenWithRange):
2967         (AccessibilityUIElement::getChildAtIndex):
2968
2969 2009-10-06  Mark Rowe  <mrowe@apple.com>
2970
2971         Reviewed by Simon Fraser.
2972
2973         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
2974
2975         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
2976         the fact we have already changed the working directory to the top of the open source tree.
2977
2978 2009-10-06  Julie Parent  <jparent@chromium.org>
2979
2980         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
2981         rather than my committer email.
2982
2983         * Scripts/modules/committers.py:
2984
2985 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2986
2987         Reviewed by Eric Seidel.
2988
2989         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
2990
2991         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
2992         it after each layout test as it should do, making the DRT dump additional output
2993         for all of the subsequent layout tests.
2994
2995         * DumpRenderTree/qt/jsobjects.cpp:
2996         (LayoutTestController::reset):
2997
2998 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2999
3000         Reviewed by Simon Hausmann.
3001
3002         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3003         fast/dom/assign-to-window-status.html test, which is passing as a result.
3004
3005         https://bugs.webkit.org/show_bug.cgi?id=30127
3006
3007         * DumpRenderTree/qt/DumpRenderTree.cpp:
3008         (WebCore::DumpRenderTree::DumpRenderTree):
3009         (WebCore::DumpRenderTree::statusBarMessage):
3010         * DumpRenderTree/qt/DumpRenderTree.h:
3011         * DumpRenderTree/qt/jsobjects.h:
3012         (LayoutTestController::shouldDumpStatusCallbacks):
3013         (LayoutTestController::dumpStatusCallbacks):
3014
3015 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3016
3017         Reviewed by Simon Hausmann.
3018
3019         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3020         ignores the argument indicating which mouse button to trigger.
3021         https://bugs.webkit.org/show_bug.cgi?id=30048
3022
3023         This affects the fast/events/mouse-click-events.html layout test.
3024
3025         * DumpRenderTree/qt/jsobjects.cpp:
3026         (EventSender::mouseDown):
3027         (EventSender::mouseUp):
3028         * DumpRenderTree/qt/jsobjects.h:
3029
3030 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3031
3032         Reviewed by Simon Hausmann.
3033
3034         [Qt] Fix the EventSender::keyDown() implementation
3035         https://bugs.webkit.org/show_bug.cgi?id=30043
3036
3037         It should post both a key press event and a key release event,
3038         just like other ports do.
3039
3040         * DumpRenderTree/qt/jsobjects.cpp:
3041         (EventSender::keyDown):
3042
3043 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3044
3045         wx build fix. Add jpeg to the list of libs to link against.
3046
3047         * wx/build/settings.py:
3048
3049 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3050
3051         Reviewed by Simon Hausmann.
3052
3053         [Qt] EventSender::keyDown() cannot send function-key events.
3054         https://bugs.webkit.org/show_bug.cgi?id=30044
3055
3056         This affects the fast/events/keydown-function-keys.html layout test.
3057
3058         * DumpRenderTree/qt/jsobjects.cpp:
3059         (EventSender::keyDown):
3060
3061 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3062
3063         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3064         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3065
3066         * wx/build/settings.py:
3067         * wx/build/wxpresets.py:
3068
3069 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3070
3071         Reviewed by Timothy Hatcher.
3072
3073         Web Inspector: add testing harness for Web Inspector.
3074
3075         https://bugs.webkit.org/show_bug.cgi?id=30010
3076
3077         * DumpRenderTree/LayoutTestController.cpp:
3078         (showWebInspectorCallback):
3079         (closeWebInspectorCallback):
3080         (evaluateInWebInspectorCallback):
3081         (LayoutTestController::staticFunctions):
3082         * DumpRenderTree/LayoutTestController.h:
3083         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3084         (LayoutTestController::showWebInspector):
3085         (LayoutTestController::closeWebInspector):
3086         (LayoutTestController::evaluateInWebInspector):
3087         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3088         (LayoutTestController::showWebInspector):
3089         (LayoutTestController::closeWebInspector):
3090         (LayoutTestController::evaluateInWebInspector):
3091         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3092         (LayoutTestController::showWebInspector):
3093         (LayoutTestController::closeWebInspector):
3094         (LayoutTestController::evaluateInWebInspector):
3095         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3096         (LayoutTestController::showWebInspector):
3097         (LayoutTestController::closeWebInspector):
3098         (LayoutTestController::evaluateInWebInspector):
3099
3100 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3101
3102         Reviewed by Ariyha Hidayat.
3103
3104         Pass arguments to system() as a string instead of array
3105
3106         When passed as an array entries with a space fail to translate
3107         to two arguments to the child process, so instead of manually
3108         splitting all the entries in @buildArgs we pass the whole thing
3109         as a string instead.
3110
3111         * Scripts/webkitdirs.pm:
3112
3113 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3114
3115         Reviewed by David Levin.
3116
3117         check-webkit-style misses whitespace errors for operators:
3118         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3119         https://bugs.webkit.org/show_bug.cgi?id=30021
3120
3121         * Scripts/modules/cpp_style.py:
3122         Added the operators mentioned above to the same list as == and !=.
3123
3124 2009-10-02  Julie Parent  <jparent@chromium.org>
3125
3126         Unreviewed.
3127
3128         Adding myself and Ojan Vafai as committers, because we are committers.
3129
3130         * Scripts/modules/committers.py:
3131
3132 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3133
3134         Reviewed by Adam Roben.
3135
3136         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3137         this will help the patch merging process when TryBots are used.
3138
3139         * Scripts/svn-create-patch:
3140
3141 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3142
3143         Reviewed by Simon Hausmann.
3144
3145         [Qt] Implement layoutTestController.overridePreference().
3146         https://bugs.webkit.org/show_bug.cgi?id=29970
3147
3148         * DumpRenderTree/qt/DumpRenderTree.cpp:
3149         (WebCore::WebPage::WebPage):
3150         (WebCore::WebPage::resetSettings):
3151         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3152         * DumpRenderTree/qt/jsobjects.cpp:
3153         (LayoutTestController::reset):
3154         (LayoutTestController::setPrivateBrowsingEnabled):
3155         (LayoutTestController::setPopupBlockingEnabled):
3156         (LayoutTestController::overridePreference):
3157         * DumpRenderTree/qt/jsobjects.h:
3158
3159 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3160
3161         Reviewed by Oliver Hunt.
3162
3163         Turn on ENABLE_3D_CANVAS in TOT
3164         https://bugs.webkit.org/show_bug.cgi?id=29906
3165
3166         * Scripts/build-webkit:
3167
3168 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3169
3170         Rubberstamped by Simon Hausmann.
3171
3172         Enable HTTP tests for Qt
3173
3174         * Scripts/run-webkit-tests:
3175
3176 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3177
3178         Reviewed by Dimitri Glazkov.
3179
3180         build-webkit --chromium now also works on cygwin.
3181
3182         https://bugs.webkit.org/show_bug.cgi?id=29973
3183
3184         * Scripts/webkitdirs.pm:
3185
3186 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3187
3188         Reviewed by Simon Hausmann.
3189
3190         [Qt] Don't use TCmalloc in DumpRenderTree
3191         https://bugs.webkit.org/show_bug.cgi?id=27029
3192
3193         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3194
3195         * DumpRenderTree/qt/DumpRenderTree.pro:
3196
3197 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3198
3199         Reviewed by Simon Hausmann.
3200
3201         [Qt] Implement eventSender.scheduleAsynchronousClick().
3202
3203         https://bugs.webkit.org/show_bug.cgi?id=29931
3204
3205         * DumpRenderTree/qt/jsobjects.cpp:
3206         (EventSender::scheduleAsynchronousClick):
3207         * DumpRenderTree/qt/jsobjects.h:
3208
3209 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3210
3211         Reviewed by Simon Hausmann.
3212
3213         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3214         fast/events/open-window-from-another-frame.html from the Skipped list.
3215
3216         https://bugs.webkit.org/show_bug.cgi?id=29930
3217
3218         * DumpRenderTree/qt/jsobjects.cpp:
3219         (LayoutTestController::setPopupBlockingEnabled):
3220         * DumpRenderTree/qt/jsobjects.h:
3221
3222 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3223
3224         Unreviewed.
3225
3226         Added myself to the list of committers.
3227
3228         * Scripts/modules/committers.py:
3229
3230 2009-09-30  Eric Seidel  <eric@webkit.org>
3231
3232         No review, just adding Geoff to the list of reviewers.
3233
3234         * Scripts/modules/committers.py:
3235
3236 2009-09-30  Dan Bernstein  <mitz@apple.com>
3237
3238         Reviewed by Sam Weinig.
3239
3240         Added the WebKit Layout Tests fonts that are referenced in
3241         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3242
3243         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3244         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3245
3246 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3247
3248         Reviewed by David Kilzer.
3249
3250         Make sunspider scripts work on Windows platform.
3251         https://bugs.webkit.org/show_bug.cgi?id=29656
3252
3253         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3254         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3255         * Scripts/webkitdirs.pm: currentPerlPath() added.
3256
3257 2009-09-29  Brady Eidson  <beidson@apple.com>
3258
3259         Rubberstamped by Dan Bernstein.
3260
3261         Fix license and some sorting in new files.
3262
3263         * DumpRenderTree/mac/HistoryDelegate.h:
3264         * DumpRenderTree/mac/HistoryDelegate.mm:
3265
3266 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3267
3268         Reviewed by David Kilzer.
3269
3270         Fixed how error codes are handled.
3271         https://bugs.webkit.org/show_bug.cgi?id=29898
3272
3273         * Scripts/update-webkit:
3274         * Scripts/update-webkit-chromium:
3275
3276 2009-09-29  Brady Eidson  <beidson@apple.com>
3277
3278         Reviewed by John Sullivan.
3279
3280         Updated way-out-of-date sorting throughout the dump methods/flags.
3281
3282         * DumpRenderTree/LayoutTestController.cpp:
3283         (LayoutTestController::LayoutTestController):
3284         (dumpAsPDFCallback):
3285         (dumpAsTextCallback):
3286         (dumpFrameLoadCallbacksCallback):
3287         (dumpResourceLoadCallbacksCallback):
3288         (LayoutTestController::staticFunctions):
3289
3290         * DumpRenderTree/LayoutTestController.h:
3291         (LayoutTestController::dumpAsText):
3292         (LayoutTestController::setDumpAsText):
3293         (LayoutTestController::dumpFrameLoadCallbacks):
3294         (LayoutTestController::setDumpFrameLoadCallbacks):
3295         (LayoutTestController::dumpSelectionRect):
3296         (LayoutTestController::setDumpSelectionRect):
3297         (LayoutTestController::dumpSourceAsWebArchive):
3298         (LayoutTestController::setDumpSourceAsWebArchive):
3299         (LayoutTestController::dumpStatusCallbacks):
3300         (LayoutTestController::setDumpStatusCallbacks):
3301         (LayoutTestController::dumpTitleChanges):
3302         (LayoutTestController::setDumpTitleChanges):
3303         (LayoutTestController::dumpWillCacheResponse):
3304         (LayoutTestController::setDumpWillCacheResponse):
3305
3306 2009-09-29  Brady Eidson  <beidson@apple.com>
3307
3308         Reviewed by John Sullivan.
3309
3310         WebKit Mac API should provide a delegate interface for global history.
3311         <rdar://problem/7042773> and https://webkit.org/b/29904
3312
3313         Adding the dumping of global history delegate callbacks.
3314
3315         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3316
3317         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3318         * DumpRenderTree/mac/DumpRenderTree.mm:
3319         (createWebViewAndOffscreenWindow):
3320         (allocateGlobalControllers):
3321         (shouldLogFrameLoadDelegates):
3322         (shouldLogHistoryDelegates):
3323         (runTest):
3324
3325         Dump history delegate callbacks:
3326         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3327         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3328         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3329         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3330         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3331
3332 2009-09-29  Daniel Bates  <dbates@webkit.org>
3333
3334         Reviewed by Adam Roben.
3335
3336         https://bugs.webkit.org/show_bug.cgi?id=28902
3337         
3338         Fixes an issue where the drop effect returned by Window Dump Render Tree 
3339         was always DROPEFFECT_NONE (since it was hard coded to do so).
3340         
3341         This patch corrects this issue by determining the actual drop effect 
3342         performed by the corresponding drag-and-drop operation so that we can 
3343         return it.
3344
3345         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3346         (DraggingInfo::DraggingInfo):
3347         (DraggingInfo::performedDropEffect): Added method.
3348         (DraggingInfo::setPerformedDropEffect): Added method.
3349         * DumpRenderTree/win/EventSender.cpp:
3350         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3351         Moved delete draggingInfo to UIDelegate::doDragDrop.
3352         * DumpRenderTree/win/UIDelegate.cpp:
3353         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3354
3355 2009-09-29  Dan Bernstein  <mitz@apple.com>
3356
3357         Reviewed by Adam Roben.
3358
3359         Remove copying of unnecessary or nonexistent files from the ImageDiff
3360         post-build event.
3361
3362         * DumpRenderTree/win/ImageDiff.vcproj:
3363
3364 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3365
3366         Reviewed by David Kilzer.
3367
3368         [Qt] Make build-webkit script work on Windows
3369         https://bugs.webkit.org/show_bug.cgi?id=29802
3370
3371         * Scripts/run-webkit-tests:
3372         * Scripts/webkitdirs.pm:
3373          - Removed unnecessary -p switch for mkdir on Windows.
3374          - Use canonical path, which uses slashes or backslashes depends on platform.
3375          - isWindows() only test for Windows and not for Cyqwin.
3376
3377 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3378
3379         Reviewed by Simon Hausmann.
3380
3381         Fix time measurement in build-webkit after refactoring done in r48853.
3382
3383         * Scripts/build-webkit:
3384
3385 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3386
3387         Reviewed by Tor Arne Vestbø.
3388
3389         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
3390         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
3391
3392         * DumpRenderTree/qt/DumpRenderTree.cpp:
3393         (WebCore::WebPage::WebPage):
3394
3395 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
3396
3397         Reviewed by Simon Hausmann.
3398
3399         [Qt] Implement eventSender.contextClick().
3400         https://bugs.webkit.org/show_bug.cgi?id=29821
3401
3402         * DumpRenderTree/qt/jsobjects.cpp:
3403         (EventSender::contextClick):
3404         * DumpRenderTree/qt/jsobjects.h:
3405
3406 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3407
3408         Reviewed by Eric Seidel.
3409
3410         Add experimentalWebSocketsEnabled in WebPreferences.
3411         https://bugs.webkit.org/show_bug.cgi?id=28941
3412
3413         * DumpRenderTree/mac/DumpRenderTree.mm:
3414         (resetDefaultsToConsistentValues):
3415         * DumpRenderTree/win/DumpRenderTree.cpp:
3416         (resetDefaultsToConsistentValues):
3417
3418 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
3419
3420         Reviewed by David Kilzer.
3421
3422         Integrated chromium port building into webkit tools update-webkit and
3423         build-webkit.
3424
3425         https://bugs.webkit.org/show_bug.cgi?id=29749
3426
3427         * Scripts/build-webkit: When --chromium is specified, will build
3428           the chromium port (currently only Mac is supported).
3429         * Scripts/update-webkit: When --chromium is specified, delegates to
3430           update-webkit-chromium.
3431         * Scripts/webkitdirs.pm: Added chromium specific defs.
3432         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
3433           chromium port's dependencies and update its project files.
3434
3435 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3436
3437         Unreviewed.
3438
3439         Add myself to list of committers.
3440
3441         * Scripts/modules/committers.py:
3442
3443 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3444
3445         Reviewed by Darin Adler.
3446
3447         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
3448         https://bugs.webkit.org/show_bug.cgi?id=29771
3449
3450         * Scripts/run-webkit-tests:
3451
3452 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3453
3454         Reviewed by Simon Hausmann.
3455
3456         [Qt] Implement layoutTestController.waitForPolicyDelegate.
3457         https://bugs.webkit.org/show_bug.cgi?id=25037
3458
3459         * DumpRenderTree/qt/DumpRenderTree.cpp:
3460         (WebCore::WebPage::acceptNavigationRequest):
3461         * DumpRenderTree/qt/DumpRenderTree.pro:
3462         * DumpRenderTree/qt/jsobjects.cpp:
3463         (LayoutTestController::reset):
3464         (LayoutTestController::notifyDone):
3465         (LayoutTestController::waitForPolicyDelegate):
3466         * DumpRenderTree/qt/jsobjects.h:
3467         (LayoutTestController::waitForPolicy):
3468
3469 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3470
3471         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
3472
3473         Reviewed by Eric Seidel.
3474
3475         The -o|--open switch uses the open(1) command on Mac OS X to
3476         open the bug URL in the default web browser.  If there are
3477         similar mechanisms on other platforms, they may be added later.
3478
3479         * Scripts/mark-bug-fixed:
3480         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
3481         options.
3482         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
3483         code into main() and extracted prompting code into
3484         _prompt_user_for_correctness().
3485         (MarkBugFixed._open_bug_in_web_browser): Added.
3486         (MarkBugFixed._prompt_user_for_correctness): Added.
3487         (MarkBugFixed.main): Added logging code from
3488         _determine_bug_id_and_svn_revision().  Added code to call
3489         _open_bug_in_web_browser() if the switch is set.  Added code to
3490         call _prompt_user_for_correctness() when needed.
3491         * Scripts/modules/bugzilla.py:
3492         (Bugzilla.short_bug_url_for_bug_id): Added.
3493
3494 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3495
3496         svn-unapply and svn-apply don't work when used outside multiple svn working directories
3497
3498         <http://webkit.org/b/29744>
3499         <rdar://problem/7252905>
3500
3501         Reviewed by Eric Seidel.
3502
3503         Some users have a workflow where svn-create-patch, svn-apply and
3504         svn-unapply are used outside of multiple svn working
3505         directories.  Instead of aborting the scripts in these cases,
3506         print a warning and assume that Subversion is being used.
3507
3508         * Scripts/VCSUtils.pm:
3509         (determineVCSRoot): Call warn() instead of die() if both isGit()
3510         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
3511         to enforce the assumption about Subversion, then return
3512         determineSVNRoot().
3513         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
3514         VCSUtils.pm.  They both already cache their values and checking
3515         here is redundant since determineVCSRoot() is called later.
3516
3517 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
3518
3519         Reviewed by Gustavo Noronha.
3520
3521         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3522         https://bugs.webkit.org/show_bug.cgi?id=29689
3523
3524         Load test fonts through FontConfig before each test.
3525         This ensures a more proper rendering of the tests.
3526
3527         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3528         (initializeFonts):
3529         (runTest):
3530         (main):
3531         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
3532         * GNUmakefile.am:
3533
3534 2009-09-25  David Kilzer  <ddkilzer@apple.com>
3535
3536         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
3537
3538         Reviewed by Eric Seidel.
3539
3540         * Scripts/mark-bug-fixed:
3541         (MarkBugFixed.__init__): Added -u|--update-only switch to list
3542         of parse options.
3543         (MarkBugFixed.main): When -u|--update-only is specified, add a
3544         comment to the bug without marking it Resolved/Fixed.
3545
3546 2009-09-25  Darin Adler  <darin@apple.com>
3547
3548         Reviewed by Geoffrey Garen.
3549
3550         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
3551         out, just as we do for the resources directory.
3552
3553 2009-09-25  Adam Barth  <abarth@webkit.org>
3554
3555         Unreviewed.  Added Tony to committers.py because he's a
3556         committer now.
3557
3558         * Scripts/modules/committers.py:
3559
3560 2009-09-25  Eric Seidel  <eric@webkit.org>
3561
3562         Reviewed by Simon Fraser.
3563
3564         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
3565         https://bugs.webkit.org/show_bug.cgi?id=28624
3566
3567         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
3568
3569         * DumpRenderTree/mac/DumpRenderTree.mm:
3570         (resetDefaultsToConsistentValues):
3571
3572 2009-09-25  Eric Seidel  <eric@webkit.org>
3573
3574         Reviewed by Adam Barth.
3575
3576         commit-queue should auto-retry patches which fail to commit due to out of date files
3577         https://bugs.webkit.org/show_bug.cgi?id=28316
3578
3579         * Scripts/bugzilla-tool:
3580          - Handle new CheckoutNeedsUpdate exception.
3581         * Scripts/modules/logging_unittest.py:
3582          - Call the ScriptError constructor correctly (this test had regressed).
3583         * Scripts/modules/scm.py:
3584          - Added the ability to define custom error handlers for run_command
3585            and added a commit_error_handler which throws CheckoutNeedsUpdate
3586            instead of ScriptError.
3587          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
3588         * Scripts/modules/scm_unittest.py:
3589          - Added tests of new error handlers.
3590
3591 2009-09-25  Eric Seidel  <eric@webkit.org>
3592
3593         Reviewed by Adam Barth.
3594
3595         commit-queue should give better feedback when failing a patch
3596         https://bugs.webkit.org/show_bug.cgi?id=29316
3597
3598         * Scripts/bugzilla-tool:
3599          - Update ScriptError uses to the new constructor format.
3600          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
3601            so that we can print to both stdout as well as an output buffer for error reporting.
3602          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
3603          - Use e.message_with_output() when failing a patch (this is the real fix here).
3604            I also removed use of "This patch will require manual commit." as that's not always true.
3605          - Add missing word "bug" from log message.
3606         * Scripts/modules/scm.py:
3607          - Make ScriptError save a bunch more data so that error messages can be nicer.
3608          - Update ScriptError callers.
3609
3610 2009-09-24  John Gregg  <johnnyg@google.com>
3611
3612         Reviewed by Eric Seidel.
3613
3614         Enable switch for notifications (experimental) in Page Settings
3615         https://bugs.webkit.org/show_bug.cgi?id=28930
3616
3617         Now that desktop notifications are controlled by run-time switch,
3618         set that switch to true for DumpRenderTree.
3619
3620         * DumpRenderTree/mac/DumpRenderTree.mm:
3621         (resetDefaultsToConsistentValues):
3622         * DumpRenderTree/win/DumpRenderTree.cpp:
3623         (resetDefaultsToConsistentValues):
3624         * DumpRenderTree/win/UIDelegate.cpp:
3625         (UIDelegate::QueryInterface):
3626
3627 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
3628
3629         wx build fix. SnowLeopard fixes for Mac dependencies.
3630
3631         * wx/build/build_utils.py:
3632         * wx/build/settings.py:
3633         * wx/install-unix-extras:
3634
3635 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3636
3637         Reviewed by Oliver Hunt.
3638
3639         Add support for DRT to send mouse wheel events.
3640
3641         https://bugs.webkit.org/show_bug.cgi?id=29348
3642         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
3643
3644         * DumpRenderTree/gtk/EventSender.cpp:
3645         (mouseWheelToCallback):
3646
3647 2009-09-17  Eric Seidel  <eric@webkit.org>
3648
3649         Reviewed by David Levin.
3650
3651         commit-queue needs web-based status reporting
3652         https://bugs.webkit.org/show_bug.cgi?id=29307
3653
3654         Add a first-pass web-based status for the commit-queue.
3655         The bot is currently reachable at:
3656         http://webkit-commit-queue.appspot.com/
3657
3658         * CommitQueueStatus/app.yaml: Added.
3659          - Application description file required by App Engine.
3660         * CommitQueueStatus/filters/__init__.py: Added.
3661          - Required by python to treat 'filters' as a module.
3662         * CommitQueueStatus/filters/webkit_extras.py: Added.
3663          - Support for turning 'bug 123' and 'patch 123' into links.
3664            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
3665         * CommitQueueStatus/index.html: Added.
3666         * CommitQueueStatus/index.yaml: Added.
3667          - Some auto-generated file from app engine.
3668         * CommitQueueStatus/queue_status.py: Added.
3669          - The core logic of this bot.  We could eventually split this file out into pieces.
3670         * CommitQueueStatus/stylesheets/main.css: Added.
3671          - Some basic lame-o CSS to make the page look less awful.
3672         * CommitQueueStatus/update_status.html: Added.
3673          - The form that the commit-queue (or a human) can use to update the status.
3674         * Scripts/bugzilla-tool:
3675          - Add some very basic update_status calls.
3676         * Scripts/modules/statusbot.py: Added.
3677          - Knows how to post to the CommitQueueStatus web application.
3678
3679 2009-09-24  David Kilzer  <ddkilzer@apple.com>
3680
3681         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
3682
3683         Reviewed by Adam Roben.
3684
3685         * Scripts/mark-bug-fixed:
3686         (MarkBugFixed.__init__): Added -m|--comment switch to list of
3687         parse options.
3688         (MarkBugFixed.main): When specified, prepend comment from
3689         -m|--comment command-line switch to the bug comment.