WebKitTools/ChangeLog

   1 2007-11-29  Anders Carlsson  <andersca@apple.com>
   2
   3         * DumpRenderTree/win/DumpRenderTree.vcproj:
   4         Add shlwapi.lib to all configurations.
   5
   6 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
   7
   8         - Build fix.  Added additional includes for VS Express to the Release
   9         project.
  10
  11         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
  12
  13 2007-11-29  Anders Carlsson  <andersca@apple.com>
  14
  15         Reviewed by Adam.
  16
  17         <rdar://problem/5132005>
  18         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
  19
  20         * DumpRenderTree/win/DumpRenderTree.vcproj:
  21         Add shlwapi.lib
  22
  23         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  24         (LayoutTestController::setUserStyleSheetEnabled):
  25         Implement this.
  26
  27         (appendComponentToPath):
  28         New method which wraps the Win32 API PathAppend.
  29
  30         (followShortcuts):
  31         New method which checks if a file points to a shortcut and
  32         follows the shortcut.
  33
  34         (resolveCygwinPath):
  35         New method that takes a cygwin unix-style path and returns the Win32 path.
  36
  37         (cfStringRefToWString):
  38
  39         (LayoutTestController::setUserStyleSheetLocation):
  40         Implement this.
  41
  42 2007-11-29  Alice Liu  <alice.liu@apple.com>
  43
  44         Reviewed by Adam.
  45
  46         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
  47
  48         * DumpRenderTree/win/EventSender.cpp:
  49         (keyDownCallback):
  50         uppercase letters were being sent as lowercase letters without the shift key down.
  51
  52 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
  53
  54         - Windows build fix. VS express needs some love.
  55
  56         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
  57
  58 2007-11-28  Darin Adler  <darin@apple.com>
  59
  60         Reviewed by Adam Roben.
  61
  62         * DumpRenderTree/mac/EventSendingController.mm:
  63         (-[EventSendingController keyDown:withModifiers:]):
  64         Send capital letters through as lowercase letters with the shift key down
  65         rather than sending them as if they were highly unusual "capital letter keys".
  66
  67         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
  68         where you need to update results and more tests are failing than before.
  69
  70 2007-11-28  Anders Carlsson  <andersca@apple.com>
  71
  72         Reviewed by Darin.
  73
  74         <rdar://problem/5132001>
  75         contextClick is not implemented in DRT on Windows.
  76
  77         * DumpRenderTree/win/EventSender.cpp:
  78         (contextClickCallback):
  79         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
  80         by a WM_RBUTTONUP message.
  81
  82         * DumpRenderTree/win/UIDelegate.cpp:
  83         (UIDelegate::hasCustomMenuImplementation):
  84         (UIDelegate::trackCustomPopupMenu):
  85         * DumpRenderTree/win/UIDelegate.h:
  86         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
  87         menu from being shown (and causing the DRT to hang).
  88
  89 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
  90
  91         Reviewed by Darin.
  92
  93         Fix DumpRenderTree ObjC bug comparing strings.
  94
  95         * DumpRenderTree/mac/ObjCController.m:
  96         (-[ObjCController identityIsEqual::]): Compare strings with string
  97         equality instead of identiy equality.
  98
  99 2007-11-27  Timothy Hatcher  <timothy@apple.com>
 100
 101         Reviewed by Sam.
 102
 103         Reset the authorAndUserStylesEnabled preference
 104         back to YES for each test. Fixes the broken tests.
 105
 106         * DumpRenderTree/mac/DumpRenderTree.mm:
 107         (resetWebViewToConsistentStateBeforeTesting):
 108
 109 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
 110
 111         Reviewed by Adam.
 112
 113         - Drosera now displays the console window, although it cannot currently
 114         process JavaScript.
 115
 116         * Drosera/win/DebuggerClient.cpp: Shows the console window.
 117         (registerConsoleClass): Implemented.
 118         (consoleWndProc): Implemented.
 119         (DebuggerClient::onSize): Implemented.
 120         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
 121         new window.
 122         * Drosera/win/DebuggerClient.h: Added needed method and members for
 123         creating and maintaining a new window.
 124         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
 125         lines of code to more appropriate places.
 126         (Drosera::handleCommand):
 127         (Drosera::initUI):
 128         (Drosera::onSize):
 129         (Drosera::attach):
 130
 131 2007-11-27  Timothy Hatcher  <timothy@apple.com>
 132
 133         Reviewed by Dave Hyatt.
 134
 135         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
 136
 137         Add support for disabling author and user styles for testing.
 138
 139         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 140         * DumpRenderTree/LayoutTestController.cpp:
 141         (setAuthorAndUserStylesEnabledCallback):
 142         (LayoutTestController::staticFunctions):
 143         * DumpRenderTree/LayoutTestController.h:
 144         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 145         (LayoutTestController::setAuthorAndUserStylesEnabled):
 146         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 147         (LayoutTestController::setAuthorAndUserStylesEnabled):
 148
 149 2007-11-26  Dan Bernstein  <mitz@apple.com>
 150
 151         - Tiger build fix.
 152
 153         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 154
 155 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
 156
 157         Reviewed by Maciej.
 158
 159         - Implemented displaying variables for Drosera on Win.
 160
 161         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
 162         that retrieve variables to not hold onto the return value since it's
 163         not returned.  Also changed to use the new signatures of the retrieval
 164         functions.
 165         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 166         (DebuggerDocument::platformValueForScopeVariableNamed):
 167         * Drosera/win/Drosera.cpp: Removed a needless TODO.
 168         (droseraWndProc):
 169
 170 2007-11-26  Sam Weinig  <sam@webkit.org>
 171
 172         Cleanup names of painting and repainting functions.
 173
 174         Reviewed by Adam Roben.
 175
 176         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 177         (drawSelectionRect): was drawSelectionRectIntoContext.
 178         (dumpWebViewAsPixelsAndCompareWithExpected):
 179         * DumpRenderTree/cg/PixelDumpSupportCG.h:
 180         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
 181         (paintWebView): was drawWebViewIntoContext.
 182         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
 183
 184 2007-11-26  Sam Weinig  <sam@webkit.org>
 185
 186         Reviewed by Dan Bernstein.
 187
 188         - Leopard build fix
 189
 190         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 191
 192 2007-11-26  Sam Weinig  <sam@webkit.org>
 193
 194         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
 195         Use shared PixelDumpSupport for Mac DRT
 196
 197         Reviewed by Adam Roben.
 198
 199         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 200         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
 201         * DumpRenderTree/cg/ImageDiffCG.cpp:
 202         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 203         (drawSelectionRectIntoContext):
 204         (dumpWebViewAsPixelsAndCompareWithExpected):
 205         * DumpRenderTree/cg/PixelDumpSupportCG.h:
 206         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 207         * DumpRenderTree/mac/DumpRenderTree.mm:
 208         (dump):
 209         * DumpRenderTree/mac/ImageDiff.m: Removed.
 210         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
 211         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
 212         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
 213         (setDefaultColorProfileToRGB):
 214         (getBitmapContextFromWebView):
 215         (drawWebViewIntoContext):
 216         (repaintWithVerticalSweep):
 217         (repaintWithHorizontalSweep):
 218         (getSelectionRect):
 219         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
 220
 221 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
 222
 223         Bug 16052: prepare-ChangeLog doesn't report deleted files
 224         <http://bugs.webkit.org/show_bug.cgi?id=16052>
 225
 226         Reviewed by Sam.
 227
 228         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
 229
 230 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
 231
 232         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
 233         <http://bugs.webkit.org/show_bug.cgi?id=15864>
 234
 235         Reviewed by Adam.
 236
 237         Roll functionality of merge-changelog into resolve-ChangeLogs
 238         script.  The script now checks for ChangeLog.rej and
 239         ChangeLog.orig files first.  If it finds them, it uses the
 240         ChangeLog.rej file as a patch (in old contextual diff format) to
 241         apply with --fuzz=3.
 242
 243         * Scripts/merge-changelog: Removed.
 244         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
 245
 246 2007-11-25  Sam Weinig  <sam@webkit.org>
 247
 248         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
 249
 250         Reviewed by Mark Rowe.
 251
 252         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 253         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 254         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
 255         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
 256         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
 257
 258 2007-11-25  Sam Weinig  <sam@webkit.org>
 259
 260         Convert DumpRenderTree to ues .xcconfig files.
 261
 262         Reviewed by Mark Rowe.
 263
 264         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 265         * DumpRenderTree/mac/Configurations: Added.
 266         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
 267         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
 268         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
 269
 270 2007-11-25  Sam Weinig  <sam@webkit.org>
 271
 272         Add ForwardingHeaders to wtf for DumpRenderTree.
 273
 274         Reviewed by Mark Rowe.
 275
 276         * DumpRenderTree/DumpRenderTree.h:
 277         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 278         * DumpRenderTree/ForwardingHeaders: Added.
 279         * DumpRenderTree/ForwardingHeaders/wtf: Added.
 280         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
 281         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
 282         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
 283         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
 284         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
 285         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
 286         * DumpRenderTree/LayoutTestController.cpp:
 287         * DumpRenderTree/WorkQueue.cpp:
 288         * DumpRenderTree/mac/DumpRenderTree.mm:
 289         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 290         * DumpRenderTree/mac/JavaScriptThreading.cpp:
 291         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 292         * DumpRenderTree/mac/ObjCController.m:
 293         * DumpRenderTree/mac/UIDelegate.mm:
 294         * DumpRenderTree/mac/WorkQueueItemMac.mm:
 295
 296 2007-11-25  Adam Roben  <aroben@apple.com>
 297
 298         Fix some test failures caused by r28019
 299
 300         Now that stdout is in binary mode, we need to always use printf
 301         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
 302         the output.
 303
 304         Reviewed by Sam.
 305
 306         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
 307         printf.
 308         (UIDelegate::runJavaScriptAlertPanelWithMessage):
 309         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
 310         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
 311         (UIDelegate::webViewAddMessageToConsole):
 312
 313 2007-11-25  Adam Roben  <aroben@apple.com>
 314
 315         Set the font smoothing preference in DRT
 316
 317         This makes the pixel results on Windows closer to the Mac results.
 318
 319         Reviewed by Mitz.
 320
 321         * DumpRenderTree/win/DumpRenderTree.cpp:
 322         (initializePreferences):
 323
 324 2007-11-25  Adam Roben  <aroben@apple.com>
 325
 326         Port ImageDiff to CG and C++
 327
 328         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
 329         <rdar://5071708>
 330
 331         Reviewed by Sam.
 332
 333         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
 334         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
 335         (main):
 336         (createImageFromStdin):
 337         (compareImages):
 338         (getDifferenceBitmap):
 339         (computePercentageDifferent):
 340         * DumpRenderTree/win/ImageDiff.vcproj: Added.
 341
 342 2007-11-25  Adam Roben  <aroben@apple.com>
 343
 344         Fix image diff link generation on Windows
 345
 346         Reviewed by Sam.
 347
 348         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
 349         to toURL.
 350
 351 2007-11-25  Adam Roben  <aroben@apple.com>
 352
 353         Implement pixel dumping in Windows DRT
 354
 355         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
 356         <rdar://5071708>
 357
 358         Reviewed by Sam.
 359
 360         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
 361         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
 362         Content-Length header.
 363         (getMD5HashStringForBitmap):
 364         (dumpWebViewAsPixelsAndCompareWithExpected):
 365         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
 366         * DumpRenderTree/win/DumpRenderTree.cpp:
 367         (dump): Do a pixel dump if requested.
 368         (main): Parse pixel test options.
 369         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
 370         the cg/ subdirectory to the include path.
 371         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
 372         available in a header or import library, so we have to go through this
 373         LoadLibrary/GetProcAddress dance to use them.
 374         (cryptDLL):
 375         (init):
 376         (update):
 377         (final):
 378         (MD5_Init):
 379         (MD5_Update):
 380         (MD5_Final):
 381         * DumpRenderTree/win/MD5.h: Added.
 382         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
 383         moved up to the top level to share it with Mac eventually.
 384         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
 385         (getBitmapContextFromWebView): Forces the WebView to paint using a
 386         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
 387
 388 2007-11-25  Adam Roben  <aroben@apple.com>
 389
 390         Clean up Windows DRT's option parsing a little bit
 391
 392         Reviewed by Sam.
 393
 394         * DumpRenderTree/win/DumpRenderTree.cpp:
 395         (main): Put non-option arguments into a Vector.
 396
 397 2007-11-25  Adam Roben  <aroben@apple.com>
 398
 399         Make Windows DRT stop changing LF into CRLF
 400
 401         Reviewed by Sam.
 402
 403         * DumpRenderTree/win/DumpRenderTree.cpp:
 404         (main): Put stdout in binary mode.
 405         * Scripts/run-webkit-tests: Remove the CRLF hack.
 406
 407 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
 408
 409         Removed empty directory.
 410
 411         * Scripts/resources: Removed.
 412
 413 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
 414
 415         Fix bisect-builds to work with recent WebKit nightly builds.
 416
 417         Reviewed by Dan.
 418
 419         * Scripts/bisect-builds: Check for the
 420         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
 421         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
 422         to WebKit.app/Contents/Resources.
 423
 424 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
 425
 426         Reviewed by Maciej.
 427
 428         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
 429         not closed (affects digg.com)
 430
 431         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
 432         one after finishing with a test to avoid having its delayed onload handler firing when
 433         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
 434         but it helps somewhat.
 435
 436 2007-11-22  Mark Rowe  <mrowe@apple.com>
 437
 438         Reviewed by Alp Toker.
 439
 440         Fix build-webkit to propagate make's exit status if it fails.
 441
 442         * Scripts/webkitdirs.pm:
 443
 444 2007-11-22  Dan Bernstein  <mitz@apple.com>
 445
 446         Reviewed by Mark Rowe.
 447
 448         - fix crash when running pixel tests
 449
 450         * DumpRenderTree/mac/DumpRenderTree.mm:
 451         (dumpRenderTree): Parse the command line options before setting up the
 452         environment so that we know if we need to set up the pixel dump
 453         machinery.
 454
 455 2007-11-21  Eric Seidel  <eric@webkit.org>
 456
 457         Speculative build fix for Tiger.
 458
 459         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
 460
 461 2007-11-21  Eric Seidel  <eric@webkit.org>
 462
 463         Reviewed by Tim Hatcher.
 464
 465         Break out more of DumpRenderTree.mm into individual files
 466
 467         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 468         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
 469         (checkedMalloc):
 470         (checkedRealloc):
 471         (makeLargeMallocFailSilently):
 472         * DumpRenderTree/mac/CheckedMalloc.h: Added.
 473         * DumpRenderTree/mac/DumpRenderTree.mm:
 474         (crashHandler):
 475         (dump):
 476         * DumpRenderTree/mac/DumpRenderTreeMac.h:
 477         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
 478         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
 479         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
 480         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
 481         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
 482         (javaScriptThreads):
 483         (runJavaScriptThread):
 484         (startJavaScriptThreads):
 485         (stopJavaScriptThreads):
 486         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
 487         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
 488         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
 489         (restoreColorSpace):
 490         (setDefaultColorProfileToRGB):
 491         (initializeColorSpaceAndScreeBufferForPixelTests):
 492         (md5HashStringForBitmap):
 493         (dumpWebViewAsPixelsAndCompareWithExpected):
 494
 495 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
 496
 497         Move install-unix-extras to wx directory as it seems only to be used by that
 498         port now. It now supports universal binaries on Mac and adds libpng and libjpeg.
 499         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
 500         have install-unix-extras install into WebKitLibraries as per
 501         convention.
 502
 503         Reviewed by Mark Rowe.
 504
 505         * Scripts/install-unix-extras: Removed.
 506         * wx/build-wxwebkit:
 507         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
 508
 509 2007-11-21  Eric Seidel  <eric@webkit.org>
 510
 511         Reviewed by Adam.
 512
 513         More refactoring for greater code readability
 514
 515         * DumpRenderTree/mac/DumpRenderTree.mm:
 516         (initializeGlobalsFromCommandLineOptions):
 517         (initializeColorSpaceAndScreeBufferForPixelTests):
 518         (addTestPluginsToPluginSearchPath):
 519         (useLongRunningServerMode):
 520         (runTestingServerLoop):
 521         (prepareConsistentTestingEnvironment):
 522         (dumpRenderTree):
 523         (main):
 524         (dumpFramesAsText):
 525         (dumpBackForwardListForWebView):
 526         (sizeWebViewForCurrentTest):
 527         (methodNameStringForFailedTest):
 528         (dumpBackForwardListForAllWindows):
 529         (dumpWebViewAsPixelsAndCompareWithExpected):
 530         (invalidateAnyPreviousWaitToDumpWatchdog):
 531         (dump):
 532         * DumpRenderTree/mac/DumpRenderTreeMac.h:
 533         * DumpRenderTree/mac/UIDelegate.mm:
 534         (-[UIDelegate webView:createWebViewWithRequest:]):
 535
 536 2007-11-21  Eric Seidel  <eric@webkit.org>
 537
 538         Reviewed by Tim Hatcher.
 539
 540         Abstract more of DRT into static methods
 541
 542         * DumpRenderTree/mac/DumpRenderTree.mm:
 543         (setDefaultsToConsistentValuesForTesting):
 544         (setupSignalHandlers):
 545         (allocateGlobalControllers):
 546         (releaseAndZero):
 547         (releaseGlobalControllers):
 548         (dumpRenderTree):
 549         (shouldLogFrameLoadDelegates):
 550         (createCFURLFromPathOrURL):
 551         (resetWebViewToConsistentStateBeforeTesting):
 552         (runTest):
 553
 554 2007-11-21  Eric Seidel  <eric@webkit.org>
 555
 556         Reviewed by Tim Hatcher.
 557
 558         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
 559
 560         * DumpRenderTree/DumpRenderTree.h:
 561         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 562         * DumpRenderTree/mac/DumpRenderTree.mm:
 563         (dumpRenderTree):
 564         (dump):
 565         (runTest):
 566         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
 567         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
 568         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
 569         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
 570         (-[DumpRenderTreePasteboard declareType:owner:]):
 571         (+[LocalPasteboard alloc]):
 572         (-[LocalPasteboard init]):
 573         (-[LocalPasteboard dealloc]):
 574         (-[LocalPasteboard name]):
 575         (-[LocalPasteboard releaseGlobally]):
 576         (-[LocalPasteboard declareTypes:owner:]):
 577         (-[LocalPasteboard addTypes:owner:]):
 578         (-[LocalPasteboard changeCount]):
 579         (-[LocalPasteboard types]):
 580         (-[LocalPasteboard availableTypeFromArray:]):
 581         (-[LocalPasteboard setData:forType:]):
 582         (-[LocalPasteboard dataForType:]):
 583         (-[LocalPasteboard setPropertyList:forType:]):
 584         (-[LocalPasteboard setString:forType:]):
 585         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
 586         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
 587         (+[DumpRenderTreeWindow allWindows]):
 588         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
 589         (-[DumpRenderTreeWindow dealloc]):
 590         (-[DumpRenderTreeWindow isKeyWindow]):
 591         (-[DumpRenderTreeWindow keyDown:]):
 592
 593 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
 594
 595         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
 596         it indiscriminately copies any headers inside JavaScriptCore,
 597         which includes Tiger ICU headers.
 598
 599         * wx/build-wxwebkit:
 600         Don't run WebCore/move-js-headers.sh any longer.
 601
 602 2007-11-20  Adam Treat  <treat@kde.org>
 603
 604         Reviewed by David Kilzer.
 605
 606         * Prepend git branch name to $baseProductDir
 607
 608         * Scripts/VCSUtils.pm:
 609         * Scripts/webkitdirs.pm:
 610
 611 2007-11-20  Mark Rowe  <mrowe@apple.com>
 612
 613         Reviewed by Simon Hausmann.
 614
 615         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
 616         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
 617         Have it trigger a "make distclean" rather than "make clean" to ensure that the
 618         built product and generated Makefile's are removed.
 619
 620 2007-11-19  Alp Toker  <alp@atoker.com>
 621
 622         Reviewed by Mark Rowe.
 623
 624         http://bugs.webkit.org/show_bug.cgi?id=16040
 625         [GTK] GtkLauncher should be written in C
 626
 627         Port GtkLauncher to plain C.
 628
 629         Use a more conventional GTK+ coding style.
 630
 631         Use a toolbar instead of menus.
 632
 633         Various signature fixes and cleanups.
 634
 635         Add a license header. Assume all previous modifications were copyright
 636         assigned to Apple Inc. by default.
 637
 638         * GtkLauncher/GtkLauncher.pro:
 639         * GtkLauncher/main.c: Added.
 640         (activate_url_entry_cb):
 641         (update_title):
 642         (link_hover_cb):
 643         (title_change_cb):
 644         (progress_change_cb):
 645         (destroy_cb):
 646         (go_back_cb):
 647         (go_forward_cb):
 648         (create_browser):
 649         (create_statusbar):
 650         (create_toolbar):
 651         (create_window):
 652         (main):
 653         * GtkLauncher/main.cpp: Removed.
 654
 655 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
 656
 657         Build script fixes to ensure they do the right thing for the
 658         wx port, and update build-wxwebkit to reflect the way the
 659         build scripts now work.
 660
 661         Reviewed by Adam.
 662
 663         * Scripts/build-testkjs:
 664         * Scripts/build-webkit:
 665         * Scripts/run-javascriptcore-tests:
 666         * Scripts/webkitdirs.pm:
 667         * wx/build-wxwebkit:
 668
 669 2007-11-18  Eric Seidel  <eric@webkit.org>
 670
 671         Reviewed by Anders.
 672
 673         Make run-javascriptcore-tests report failures on exit (to support git bisect)
 674
 675         * Scripts/run-javascriptcore-tests:
 676
 677 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
 678
 679         Reviewed by Adam Roben.
 680
 681         Make run-webkit-tests work with Windows debug build.
 682
 683         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
 684         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
 685         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
 686         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
 687         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
 688
 689 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
 690
 691         Add wxWebKit sample and build script, and integrate it with
 692         build-webkit. Also make build-webkit --clean work for all
 693         ports.
 694
 695         Reviewed by Darin Adler.
 696
 697         * Scripts/build-webkit:
 698         * Scripts/webkitdirs.pm:
 699         * wx: Added.
 700         * wx/browser: Added.
 701         * wx/browser/browser.bkl: Added.
 702         * wx/browser/browser.cpp: Added.
 703         * wx/build-wxwebkit: Added.
 704
 705 2007-11-17  Adam Roben  <aroben@apple.com>
 706
 707         Make it easy to run Safari in the debugger on Windows
 708
 709         I've added a new script, debug-safari, which launches Safari in the
 710         debugger. On OS X it just calls gdb-safari.
 711
 712         Reviewed by Mark Rowe.
 713
 714         * FindSafari/FindSafari.cpp:
 715         (_tmain): Added a /debugger flag, which in combination with
 716         /printSafariLauncher will print a script that launches Safari in the
 717         debugger.
 718         * Scripts/debug-safari: Added.
 719         * Scripts/run-safari: Changed to call runSafari().
 720         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
 721         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
 722         first argument along to FindSafari.
 723         * Scripts/webkitdirs.pm:
 724         (sub runSafari): Added.
 725
 726 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
 727
 728         Reviewed by Adam Roben.
 729
 730         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.
 731
 732 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
 733
 734         Reviewed by David Kilzer.
 735
 736         The git config command was renamed to repo-config at some point. This
 737         change tries git config and then git repo-config if the first fails.
 738
 739         * Scripts/prepare-ChangeLog:
 740         (gitConfig):
 741
 742 2007-11-16  Dan Bernstein  <mitz@apple.com>
 743
 744         Reviewed by Darin Adler and Sam Weinig.
 745
 746         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
 747
 748         * DumpRenderTree/win/EventSender.cpp:
 749         (keyDownCallback): For characters that cannot be entered on the active
 750         keyboard layout, send a WM_CHAR message with the character along with
 751         a WM_KEYDOWN message with a virtual key code of 255.
 752
 753 2007-11-16  Mark Rowe  <mrowe@apple.com>
 754
 755         Reviewed by Tim Hatcher.
 756
 757         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
 758
 759         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
 760         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 761
 762 2007-11-15  Adam Roben  <aroben@apple.com>
 763
 764         Make run-safari actually work on Windows
 765
 766         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
 767         chdir call.
 768
 769 2007-11-14  Adam Roben  <aroben@apple.com>
 770
 771         Updates to Safari launching now that 3.0.4 is released
 772
 773         Reviewed by Sam.
 774
 775         * FindSafari/FindSafari.cpp:
 776         (getWebViewCLSID): Use version-independent ProgID.
 777         * Scripts/run-safari: Use run-webkit-nightly.cmd.
 778
 779 2007-11-14  Anders Carlsson  <andersca@apple.com>
 780
 781         Reviewed by Adam.
 782
 783         <rdar://problem/5309081>
 784         In DRT, "plugin.logDestroy = true" not working on Windows.
 785
 786         * DumpRenderTree/win/TestNetscapePlugin/main.c:
 787         (NPP_Destroy):
 788
 789 2007-11-14  Eric Seidel  <eric@webkit.org>
 790
 791         Reviewed by Sam.
 792
 793         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
 794
 795 2007-11-14  Anders Carlsson  <andersca@apple.com>
 796
 797         Reviewed by Adam.
 798
 799         <rdar://problem/5141186>
 800         window.layoutTestController.setWindowIsKey is not implemented in DRT.
 801
 802         Implement setWindowIsKey.
 803
 804         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 805         (LayoutTestController::setWindowIsKey):
 806
 807 2007-11-13  Sam Weinig  <sam@webkit.org>
 808
 809         Reviewed by Adam Roben.
 810
 811         Fix for <rdar://problem/5382579>
 812         http/tests/security/cross-frame-access-put.html reports large
 813         negative numbers for screenLeft and screenTop (Mac reports "0")
 814
 815         * DumpRenderTree/win/UIDelegate.cpp:
 816         (UIDelegate::UIDelegate): Initialize the RECT.
 817         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
 818         (UIDelegate::webViewFrame): ditto.
 819         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
 820
 821 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
 822
 823         Reviewed by Adam.
 824
 825         - Make Drosera show source, source URLs, and function stack on Windows,
 826         and some minor fixes.
 827
 828         * Drosera/DebuggerDocument.cpp: Force source to always update display.
 829         (DebuggerDocument::updateFileSource):
 830         * Drosera/debugger.js: Force source to always update display.
 831         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
 832         menu controls.
 833         (DebuggerClient::resume):
 834         (DebuggerClient::pause):
 835         (DebuggerClient::stepInto):
 836         (DebuggerClient::stepOver):
 837         (DebuggerClient::stepOut):
 838         (DebuggerClient::showConsole):
 839         (DebuggerClient::closeCurrentFile):
 840         * Drosera/win/DebuggerClient.h: Ditto.
 841         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
 842         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
 843         removed two bugs.  1) caller could be in a bad state when asked to
 844         assign into it. 2) BSTRs were not created correctly.
 845         (DebuggerDocument::getPlatformCurrentFunctionStack):
 846         * Drosera/win/Drosera.cpp: Hook up the menu controls.
 847         (droseraWndProc):
 848         (handleCommand):
 849         (Drosera::resume):
 850         (Drosera::pause):
 851         (Drosera::stepInto):
 852         (Drosera::stepOver):
 853         (Drosera::stepOut):
 854         (Drosera::showConsole):
 855         (Drosera::closeCurrentFile):
 856         * Drosera/win/Drosera.h: Hook up the menu controls.
 857         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
 858         functions, added a null check, and fixed another bug where caller could
 859         be in a bad state when asked to assign into it.
 860         (ServerConnection::didLoadMainResourceForDataSource):
 861         (ServerConnection::getCallerFrame):
 862         * Drosera/win/ServerConnection.h: Safety first.
 863
 864 2007-11-13  Dan Bernstein  <mitz@apple.com>
 865
 866         Reviewed by Darin Adler.
 867
 868         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
 869           DumpRenderTree --pixel-tests renders each test twice
 870
 871         * DumpRenderTree/mac/DumpRenderTree.mm:
 872         (dumpRenderTree): Removed the --paint option because the painting code
 873         is always exercised as a result of
 874         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
 875         calling -displayIfNeeded.
 876         (dump): Changed to always grab the image from the window since the view
 877         is always displayed.
 878         (runTest):
 879         (displayWebView):
 880         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
 881         because it always paints.
 882
 883 2007-11-12  Antti Koivisto  <antti@apple.com>
 884
 885         Reviewed by Adele.
 886
 887         Add support for http media tests
 888
 889         * Scripts/run-webkit-tests:
 890
 891 2007-11-12  Sam Weinig  <sam@webkit.org>
 892
 893         Reviewed by Adam Roben.
 894
 895         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
 896
 897         * DumpRenderTree/win/DumpRenderTree.cpp:
 898         (runTest):
 899         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 900         (LayoutTestController::setPrivateBrowsingEnabled):
 901
 902 2007-11-12  Adam Roben  <aroben@apple.com>
 903
 904         * Scripts/update-webkit-localizable-strings: Changed to only scan the
 905         mac and win subdirectories.
 906
 907 2007-11-11  Adam Roben  <aroben@apple.com>
 908
 909         Fix <rdar://5133816> keepWebHistory is not implemented
 910
 911         Fixes fast/history/clicked-link-is-visited.html.
 912
 913         Reviewed by Darin.
 914
 915         * DumpRenderTree/win/DumpRenderTree.cpp:
 916         (runTest): Clear the optionalSharedHistory.
 917         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 918         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
 919
 920 2007-11-10  Sam Weinig  <sam@webkit.org>
 921
 922         Reviewed by Tim Hatcher.
 923
 924         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
 925         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
 926         is turned on)
 927
 928         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
 929
 930         Added test: http/tests/security/cross-frame-access-private-browsing.html
 931
 932         * DumpRenderTree/LayoutTestController.cpp:
 933         (setPrivateBrowsingEnabledCallback):
 934         (LayoutTestController::staticFunctions):
 935         * DumpRenderTree/LayoutTestController.h:
 936         * DumpRenderTree/mac/DumpRenderTree.mm:
 937         (runTest): Default to private browsing disabled.
 938         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 939         (LayoutTestController::setPrivateBrowsingEnabled):
 940         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 941         (LayoutTestController::setPrivateBrowsingEnabled):
 942
 943 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
 944
 945         Reviewed by Adam.
 946
 947         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
 948         WebCore's!
 949
 950         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
 951         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
 952         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
 953         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
 954         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
 955         * Drosera/win/Drosera.cpp:
 956         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 957
 958 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
 959
 960         Reviewed by Sam.
 961
 962         - Use the new IWebFrame [local] function signature and get the shared
 963         server correctly.
 964
 965         * Drosera/win/DebuggerClient.cpp:
 966         (DebuggerClient::didFinishLoadForFrame):
 967         * Drosera/win/ServerConnection.cpp:
 968         (ServerConnection::attemptToCreateServerConnection):
 969
 970 2007-11-07  Dan Bernstein  <mitz@apple.com>
 971
 972         Reviewed by Darin Adler.
 973
 974         - add an option to run-webkit-tests to ignore pixel test failures where
 975           all pixels differ by no more than a specified threshold
 976
 977         * DumpRenderTree/mac/ImageDiff.m:
 978         (main):
 979         (compareImages):
 980         (computePercentageDifferent):
 981         * Scripts/run-webkit-tests:
 982
 983 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 984
 985         Reviewed by Lars.
 986
 987         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
 988
 989         * DumpRenderTree/qt/DumpRenderTree.cpp:
 990
 991 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 992
 993         Reviewed by Lars.
 994
 995         Reworked the QWebSettings API.
 996         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
 997
 998         * DumpRenderTree/qt/DumpRenderTree.cpp:
 999
1000 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1001
1002         Reviewed by Lars.
1003
1004         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1005
1006         * DumpRenderTree/qt/jsobjects.cpp:
1007
1008 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1009
1010         Reviewed by Lars Knoll <lars@trolltech.com>.
1011
1012         Add a QWebPage::frameCreated() signal and fix DRT
1013
1014         The removal of createFrame in QWebPage broke the re-implementation
1015         in DumpRenderTree. Instead emit a frameCreated() signal and
1016         connect to it in DumpRenderTree.
1017
1018
1019         * DumpRenderTree/qt/DumpRenderTree.cpp:
1020         (WebCore::WebPage::WebPage):
1021         (WebCore::DumpRenderTree::dump):
1022         (WebCore::DumpRenderTree::connectFrame):
1023         * DumpRenderTree/qt/DumpRenderTree.h:
1024
1025 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1026
1027         Reviewed by Lars Knoll <lars@trolltech.com>.
1028
1029         Moved all the event handlers from QWebFrame into QWebPage.
1030
1031         This cleans up the public API and allows us to remove the
1032         HackWebFrame hack in DumpRenderTree.
1033
1034
1035         * DumpRenderTree/qt/jsobjects.cpp:
1036         (EventSender::mouseDown):
1037         (EventSender::mouseUp):
1038         (EventSender::mouseMoveTo):
1039
1040 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1041
1042         Reviewed by Mark.
1043
1044         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1045         to prevent the default implementation from popping up messageboxes.
1046
1047         * DumpRenderTree/qt/DumpRenderTree.cpp:
1048         (WebCore::WebPage::javaScriptConfirm):
1049         (WebCore::WebPage::javaScriptPrompt):
1050
1051 2007-11-06  Eric Seidel  <eric@webkit.org>
1052
1053         * Scripts/build-testkjs: build fix... too many $$
1054
1055 2007-11-06  Eric Seidel  <eric@webkit.org>
1056
1057         Reviewed by Mark Rowe.
1058
1059         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1060
1061 2007-11-05  Adam Roben  <aroben@apple.com>
1062
1063         Add support on Windows for WEBKIT_TESTFONTS
1064
1065         This environment variable lets you specify where the fonts to be used
1066         by DumpRenderTree reside. The Qt port is already using this, so I'm
1067         just following their lead.
1068
1069         Reviewed by Darin.
1070
1071         * DumpRenderTree/win/DumpRenderTree.cpp:
1072         (exePath): Refactored code out of initialize().
1073         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1074         DumpRenderTree.resources.
1075         (initialize): Use the new fontsPath function.
1076         (main): Use the new exePath function.
1077         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1078         variable to DRT, like Qt does.
1079
1080 2007-11-05  Mark Rowe  <mrowe@apple.com>
1081
1082         Rubber-stamped by Alp Toker.
1083
1084         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1085
1086         * GtkLauncher/main.cpp:
1087         (goToURLBarText):
1088         (main):
1089
1090 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1091
1092         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1093         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1094
1095         Reviewed by Timothy.
1096
1097         Restrict the range of nightly builds used by the bisect-builds script
1098         based on the version of Safari and the version of Mac OS X being used.
1099
1100         Mac OS X 10.4: Safari 2.0: r11976 or newer
1101         Mac OS X 10.4: Safari 3.0: r19992 or newer
1102
1103         Mac OS X 10.5: Safari 2.0: r19594 or newer
1104         Mac OS X 10.5: Safari 3.0: r25124 or newer
1105
1106         * Scripts/bisect-builds:
1107         (findMacOSXVersion): Added.
1108         (makeNightlyList): Added argument to provide version of Mac OS X.
1109         Restrict range of nightly builds based on Safari and Mac OS X versions.
1110
1111 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1112
1113         Reviewed by Maciej.
1114
1115         - This patch involves several changes, all of them were noticed that
1116         they were needed by the work being done in WebKit to get Drosera and
1117         WebKit working together on Windows.
1118         - The changes are:
1119         1) Added a debugger console for output messages.
1120         2) Drosera now listens for the WebKit server (before, the server would
1121         have to be running before Drosera was started.)
1122         3) Fixed a bug where the WebView started out as 0x0 pixels.
1123         4) Fixed a bug when there is no scope.
1124         5) Added the HTML, JS, and CSS to the project file to make them easy to
1125         find.
1126         6) Made the ServerConnection functions virtual.
1127
1128         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1129         for the WebKit server.
1130         (DebuggerClient::DebuggerClient):
1131         (DebuggerClient::~DebuggerClient):
1132         (DebuggerClient::didFinishLoadForFrame):
1133         (DebuggerClient::serverConnected):
1134         (DebuggerClient::attemptToCreateServerConnection):
1135         * Drosera/win/DebuggerClient.h: Ditto.
1136         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1137         scope.
1138         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1139         (DebuggerDocument::platformValueForScopeVariableNamed):
1140         * Drosera/win/Drosera.cpp:
1141         (_tWinMain): Added a console in debug for output messages.
1142         (Drosera::Drosera): Listen for server.
1143         (Drosera::initUI): The server now Initializes COM.
1144         (Drosera::serverConnected): Part of the listening for the server.
1145         (Drosera::attemptToCreateServerConnection): Ditto.
1146         * Drosera/win/Drosera.h: New interface for listening for the server.
1147         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1148         files to the VS project.
1149         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1150         connection.
1151         (ServerConnection::ServerConnection):
1152         (ServerConnection::attemptToCreateServerConnection):
1153         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1154         methods.
1155         (ServerConnection::serverConnected):
1156
1157 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1158
1159         Reviewed by Maciej.
1160
1161         http://bugs.webkit.org/show_bug.cgi?id=15832
1162         fast/dom/gc-10.html crashes when run alone
1163
1164         Check for !done before using objects that can be already deallocated.
1165
1166         * DumpRenderTree/mac/EditingDelegate.mm:
1167         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1168         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1169         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1170         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1171         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1172         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1173         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1174         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1175         (-[EditingDelegate webViewDidBeginEditing:]):
1176         (-[EditingDelegate webViewDidChange:]):
1177         (-[EditingDelegate webViewDidEndEditing:]):
1178         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1179         (-[EditingDelegate webViewDidChangeSelection:]):
1180         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1181         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1182         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1183         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1184         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1185         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1186         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1187         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1188         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1189         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1190         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1191         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1192         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1193         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1194         (-[FrameLoadDelegate webView:willCloseFrame:]):
1195         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1196         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1197         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1198         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1199         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1200         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1201         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1202         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1203         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1204
1205 2007-11-04  Mark Rowe  <mrowe@apple.com>
1206
1207         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1208         warnings that would otherwise be suppressed due to it being a system header.
1209
1210         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1211
1212 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1213
1214         Rubber stamped by Adam.
1215
1216         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1217
1218         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1219
1220 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1221
1222         Sort files(...); sections of Xcode project files.
1223
1224         Rubber-stamped by Darin.
1225
1226         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1227         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1228         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1229         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1230
1231 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1232
1233         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1234
1235         Reviewed by Darin.
1236
1237         * Scripts/sort-Xcode-project-file: Added.
1238
1239 2007-11-02  Darin Adler  <darin@apple.com>
1240
1241         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1242
1243 2007-11-02  Darin Adler  <darin@apple.com>
1244
1245         Reviewed by Maciej.
1246
1247         * Scripts/run-sunspider: Pass the "--base" option through.
1248
1249         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1250         the real script do that. Default configuration to Release to match run-sunspider
1251         so we don't end up building Debug just to compare results.
1252
1253 2007-11-01  Adam Roben  <aroben@apple.com>
1254
1255         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1256
1257         Reviewed by Sam.
1258
1259         * Scripts/commit-log-editor: Show all the directories beneath the
1260         source root, instead of just the last one.
1261
1262 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1263
1264         Reviewed by Adam Roben.
1265
1266         Print out an error message when the Windows build fails
1267         and provide guidance on how to find out what went wrong.
1268
1269         * Scripts/build-webkit:
1270         * Scripts/webkitdirs.pm:
1271
1272 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1273
1274         Rubber-stamped by Adam Roben.
1275
1276         Rolled out r27326 - debug CRT seems to cause no problems after all.
1277
1278         * DumpRenderTree/win/DumpRenderTree.vcproj:
1279
1280 2007-10-31  Adam Roben  <aroben@apple.com>
1281
1282         Switch the Debug configuration to using the non-debug CRT
1283
1284         This matches WebKit.
1285
1286         Reviewed by Steve.
1287
1288         * DumpRenderTree/win/DumpRenderTree.vcproj:
1289
1290 2007-10-31  Antti Koivisto  <antti@apple.com>
1291
1292         Reviewed by bdash.
1293
1294         Disable media tests when doing leak checking on Tiger.
1295         They crash in QuickTime (rdar://problem/5537157).
1296
1297         * Scripts/run-webkit-tests:
1298
1299 2007-10-29  Antti Koivisto  <antti@apple.com>
1300
1301         Reviewed by Maciej.
1302
1303         Build media support by default on OSX only.
1304
1305         * Scripts/build-webkit:
1306
1307 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1308
1309         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1310         get caught by the pre-commit hooks.
1311
1312 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1313
1314         Reviewed by Adam.
1315
1316         - This is a collection of relatively unrelated changes and cleanups
1317         to Drosera to prepare it for interacting with WebKit.  A lot of these
1318         changes are just correcting mistakes, for example removing included
1319         headers that are no longer needed.
1320
1321         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1322         this will be needed by the DebuggerClient.
1323         (DebuggerDocument::server):
1324         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1325         * Drosera/win/DebuggerClient.cpp:
1326         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1327         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1328         (DebuggerClient::createWebViewWithRequest): Added comment about its
1329         purpose.
1330         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1331         declarations.
1332         (DebuggerClient::webViewLoaded): Moved.
1333         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1334         file, since this was the only place it was used.
1335         (cfStringToBSTR):
1336         * Drosera/win/Drosera.h: Cleaned up the includes.
1337         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1338         * Drosera/win/HelperFunctions.h: Removed.
1339
1340 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1341
1342         Reviewed by Adam.
1343
1344         - Small cleanup in the ServerConnection class.
1345
1346         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1347         and added an include.
1348         (ServerConnection::currentFrame):
1349         (ServerConnection::getCallerFrame):
1350         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1351         made a pointer into a COMPtr, and cleaned up the includes.
1352
1353 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1354
1355         Reviewed by John Sullivan.
1356
1357         - Place the Localizable.strings file in mac or win directories
1358           if that location exists.
1359         - Also look for UI_STRING in .c files.
1360
1361         * Scripts/extract-localizable-strings:
1362
1363 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1364
1365         Reviewed by Adam.
1366
1367         - Set the eol-style to native and made all the line endings the same
1368         so that I avoid messy diffs that show eol changes.
1369
1370         * Drosera/win/ServerConnection.cpp:
1371         (ServerConnection::didParseSource):
1372         (ServerConnection::didEnterCallFrame):
1373         (ServerConnection::willExecuteStatement):
1374         (ServerConnection::willLeaveCallFrame):
1375         (ServerConnection::exceptionWasRaised):
1376
1377 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1378
1379         Reviewed by Adam.
1380
1381         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1382         functionality that could not have existed previously without the new
1383         interfaces.
1384         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1385         from a BSTR to a JSValueRef.
1386         (DebuggerDocument::platformEvaluateScript): Implemented.
1387         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1388         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1389         Implemented.
1390         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1391         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1392         * Drosera/win/ServerConnection.cpp: Added a helper function.
1393         (ServerConnection::getCallerFrame):
1394         * Drosera/win/ServerConnection.h: Added a helper function.
1395
1396 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1397
1398         updated reviewers for my previous changelog.
1399
1400 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1401         Reviewed by Maciej and Adam and Geoff.
1402
1403         - Minor mac-side improvements including moving a function to a more
1404         appropriate location, fixing a warning, and correctly checking
1405         exceptions.
1406
1407         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1408         (DebuggerDocument::willExecuteStatement):
1409         (DebuggerDocument::didEnterCallFrame):
1410         (DebuggerDocument::willLeaveCallFrame):
1411         (DebuggerDocument::windowScriptObjectAvailable):
1412         (DebuggerDocument::callFunctionOnObject):
1413         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1414         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1415         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1416         because it doesn't require the ServerConnection at all.
1417         (NSStringCreateWithJSStringRef): Made an argument const.
1418         (JSValueRefCreateWithNSString): Made an argument const.
1419         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1420         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1421         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1422         * Drosera/mac/ServerConnection.mm: Ditto.
1423         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1424
1425 2007-10-29  Sam Weinig  <sam@webkit.org>
1426
1427         Reviewed by Adam Roben.
1428
1429         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1430
1431         * DumpRenderTree/LayoutTestController.cpp:
1432         (LayoutTestController::LayoutTestController):
1433         (getGlobalFlagCallback):
1434         (setGlobalFlagCallback):
1435         (LayoutTestController::getJSClass):
1436         (LayoutTestController::staticValues):
1437         * DumpRenderTree/LayoutTestController.h:
1438         (LayoutTestController::globalFlag):
1439         (LayoutTestController::setGlobalFlag):
1440
1441 2007-10-29  Darin Adler  <darin@apple.com>
1442
1443         Reviewed by Maciej.
1444
1445         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1446         resolution instead of its default.
1447
1448 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1449
1450         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1451
1452         Reviewed by Mark Rowe.
1453
1454         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1455         was successfully resolved, but this would not show any status because the change had
1456         already been cached in the index using "git add".  The solution is to add an optional
1457         second argument to showStatus() which adds the "--cached" switch to the command.
1458
1459         * Scripts/resolve-ChangeLogs:
1460         (showStatus):
1461
1462 2007-10-28  Eric Seidel  <eric@webkit.org>
1463
1464         Reviewed by Maciej and Geoff, in unison.
1465
1466         * Scripts/run-webkit-tests: remove broken --svg option
1467
1468 2007-10-28  Darin Adler  <darin@apple.com>
1469
1470         Reviewed by Adam.
1471
1472         * Scripts/run-sunspider: Default to "Release" configuration rather than
1473         defaulting to the last configuration used as other scripts do. This can
1474         still be overriden on the command line with "--debug" if there's some
1475         reason to do so. Also fix a typo.
1476
1477         * Scripts/sunspider-compare-results: Fix a typo.
1478
1479 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1480
1481         Reviewed by Adam.
1482
1483         - Implemented the WebScriptDebugListener functions now that the
1484         WebScriptDebugServer exists
1485
1486         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1487         functions.
1488         (ServerConnection::currentFrame):
1489         (ServerConnection::didLoadMainResourceForDataSource):
1490         (ServerConnection::didParseSource):
1491         (ServerConnection::failedToParseSource):
1492         (ServerConnection::didEnterCallFrame):
1493         (ServerConnection::willExecuteStatement):
1494         (ServerConnection::willLeaveCallFrame):
1495         (ServerConnection::exceptionWasRaised):
1496         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1497         members arguments list.
1498
1499 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1500
1501         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1502         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1503
1504         Reviewed by Darin.
1505
1506         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1507         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1508         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1509         file.  Note that it may also be used as a stand-alone script.
1510
1511         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1512         * Scripts/resolve-ChangeLogs: Added.
1513         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1514
1515 2007-10-26  Mark Rowe  <mrowe@apple.com>
1516
1517         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1518         to the Qt port on the assumption that it was an implementation of the cross-platform
1519         LayoutTestController class.  It is not, so it did not need to be changed.
1520
1521         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1522
1523 2007-10-25  Mark Rowe  <mrowe@apple.com>
1524
1525         Reviewed by Maciej.
1526
1527         Fix builds with code coverage enabled.
1528
1529         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1530
1531 2007-10-25  Darin Adler  <darin@apple.com>
1532
1533         Reviewed by Mark Rowe.
1534
1535         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1536         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1537
1538 2007-10-25  Stephanie  <slewis@apple.com>
1539
1540         build Fix
1541
1542         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1543
1544 2007-10-25  Stephanie  <slewis@apple.com>
1545
1546         Reviewed by Mark Rowe, Adam Roben.
1547
1548         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1549
1550         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1551
1552 2007-10-25  Alice Liu  <alice.liu@apple.com>
1553
1554         Reviewed by Adam.
1555
1556         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1557
1558         Moving destructor into platform-specific files
1559         * DumpRenderTree/LayoutTestController.cpp:
1560         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1561         (LayoutTestController::~LayoutTestController):
1562         * DumpRenderTree/qt/jsobjects.cpp:
1563         (LayoutTestController::~LayoutTestController):
1564
1565         LayoutTestController wasn't being destroyed
1566         * DumpRenderTree/win/DumpRenderTree.cpp:
1567         (runTest):
1568
1569         Added declspec
1570         * DumpRenderTree/win/EditingDelegate.h:
1571
1572         Reset certain values on the webview (or related delegate) that might
1573         have changed while running a test
1574         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1575         (LayoutTestController::~LayoutTestController):
1576
1577 2007-10-25  Adam Roben  <aroben@apple.com>
1578
1579         Make sunspider-compare-results work with relative paths
1580
1581         Reviewed by Sam.
1582
1583         * Scripts/sunspider-compare-results: Convert arguments to absolute
1584         paths before we chdir.
1585
1586 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1587
1588         Reviewed by Sam.
1589
1590         - Implemented server calls now the WebScriptDebugServer exists.
1591         - Also removed no longer needed call to initialize CG.
1592
1593         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1594         automatically now.
1595         (_tWinMain):
1596         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1597         (ServerConnection::ServerConnection):
1598         (ServerConnection::~ServerConnection):
1599         (ServerConnection::pause):
1600         (ServerConnection::resume):
1601         (ServerConnection::stepInto):
1602         (ServerConnection::applicationTerminating):
1603         (ServerConnection::serverConnectionDidDie):
1604         * Drosera/win/ServerConnection.h: Now uses the COM class.
1605
1606 2007-10-24  George Staikos  <staikos@kde.org>
1607
1608         Unbreak Qt build.
1609
1610         * Scripts/build-webkit:
1611
1612 2007-10-24  Adam Roben  <aroben@apple.com>
1613
1614         Remove now-unnecessary call to InitializeCoreGraphics
1615
1616         WebKit takes care of this now.
1617
1618         Reviewed by Ada.
1619
1620         * DumpRenderTree/win/DumpRenderTree.cpp:
1621         (initialize):
1622
1623 2007-10-24  Adam Roben  <aroben@apple.com>
1624
1625         Use WebTextRenderer in DRT
1626
1627         Reviewed by Ada.
1628
1629         * DumpRenderTree/win/DumpRenderTree.cpp:
1630         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1631
1632 2007-10-24  Sven Herzberg  <sven@imendio.com>
1633
1634         Reviewed by Mark Rowe.
1635
1636         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1637         Bug 15614: [GTK] qmake based backends don't build on OS X
1638
1639         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1640         GTK backend on a Mac
1641         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1642         isDarwin() to make it reusable in other places (like the workaround-
1643         for-prebuilt-qmake in build-webkit)
1644
1645 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1646
1647         Refurbish update-webkit script.
1648
1649         Reviewed by Adam.
1650
1651         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
1652         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
1653         multi-argument version of system() for flexibility and security.  Check for existence
1654         of Internal directory using -d test instead of -x.
1655
1656 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1657
1658         Minor clean-up of prepare-ChangeLog script.
1659
1660         Reviewed by Adam.
1661
1662         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1663         of a string.  Use multi-argument versions of open() and system() for flexibility and
1664         security.
1665
1666 2007-10-24  Alice Liu  <alice.liu@apple.com>
1667
1668         Reviewed by Oliver.
1669
1670         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1671
1672         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
1673         replay the saved events when we're still processing the mousedown that starts the drag
1674         * DumpRenderTree/win/EventSender.cpp:
1675         (doMouseMove):
1676         * DumpRenderTree/win/UIDelegate.cpp:
1677         (UIDelegate::doDragDrop):
1678
1679 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1680
1681         Reviewed by Sam, Steve and Darin.
1682
1683         - Stubbed out the WebScriptDebugListener functionality in the Server
1684         Connection class to prepare it for receiving those callbacks.
1685         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1686         and the ServerConnection to not need to be initialized with a server
1687         name, since that is not the way we connect to the WebKit server.
1688
1689         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1690         no exception.  Now it only loggs when there is an exception
1691         (DebuggerDocument::willExecuteStatement):
1692         (DebuggerDocument::didEnterCallFrame):
1693         (DebuggerDocument::willLeaveCallFrame):
1694         (DebuggerDocument::windowScriptObjectAvailable):
1695         (DebuggerDocument::callFunctionOnObject):
1696         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1697         to be instantiated with a server's name.
1698         (DebuggerClient::DebuggerClient):
1699         (DebuggerClient::didFinishLoadForFrame):
1700         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1701         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1702         a server name.
1703         (Drosera::init):
1704         (Drosera::initServer):
1705         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1706         instantiated with a server's name.
1707         * Drosera/win/ServerConnection.cpp:
1708         (ServerConnection::ServerConnection): No longer needs a server name
1709         (ServerConnection::~ServerConnection): Only release the global context
1710         if there is one.
1711         (ServerConnection::serverConnectionDidDie): Stub for
1712         IWebScriptDebugListener
1713         (ServerConnection::QueryInterface): ditto
1714         (ServerConnection::AddRef): ditto
1715         (ServerConnection::Release): ditto
1716         (ServerConnection::didLoadMainResourceForDataSource): ditto
1717         (ServerConnection::didParseSource): ditto
1718         (ServerConnection::failedToParseSource): ditto
1719         (ServerConnection::didEnterCallFrame): ditto
1720         (ServerConnection::willExecuteStatement): ditto
1721         (ServerConnection::willLeaveCallFrame): ditto
1722         (ServerConnection::exceptionWasRaised): ditto
1723         * Drosera/win/ServerConnection.h: Stubbed out the
1724         IWebScriptDebugListener functions, and this class no longer needs to be
1725         instantiated with a server name.
1726
1727 2007-10-24  Lars Knoll  <lars@trolltech.com>
1728
1729         Reviewed by Simon.
1730
1731         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1732
1733         * DumpRenderTree/qt/jsobjects.h:
1734
1735 2007-10-24  Lars Knoll  <lars@trolltech.com>
1736
1737         Reviewed by Simon.
1738
1739         add another command.
1740
1741         * DumpRenderTree/qt/jsobjects.cpp:
1742         (TextInputController::doCommand):
1743
1744 2007-10-24  Lars Knoll  <lars@trolltech.com>
1745
1746         Reviewed by Simon.
1747
1748         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1749
1750         * DumpRenderTree/qt/jsobjects.cpp:
1751         (EventSender::keyDown):
1752         * DumpRenderTree/qt/jsobjects.h:
1753
1754 2007-10-24  Lars Knoll  <lars@trolltech.com>
1755
1756         Reviewed by Simon.
1757
1758         implement eventSender.keyDown().
1759
1760         * DumpRenderTree/qt/jsobjects.cpp:
1761         (EventSender::keyDown):
1762
1763 2007-10-24  Lars Knoll  <lars@trolltech.com>
1764
1765         Reviewed by Simon.
1766
1767         some smaller fixes to the editing support in DRT. Makes another few tests pass.
1768
1769         * DumpRenderTree/qt/DumpRenderTree.cpp:
1770         (WebCore::DumpRenderTree::DumpRenderTree):
1771         (WebCore::DumpRenderTree::initJSObjects):
1772         * DumpRenderTree/qt/jsobjects.cpp:
1773         (TextInputController::doCommand):
1774
1775 2007-10-24  Lars Knoll  <lars@trolltech.com>
1776
1777         Reviewed by Simon.
1778
1779         first bit of implementation for the textinputcontroller.
1780
1781         * DumpRenderTree/qt/DumpRenderTree.cpp:
1782         (WebCore::DumpRenderTree::DumpRenderTree):
1783         * DumpRenderTree/qt/DumpRenderTree.h:
1784         * DumpRenderTree/qt/jsobjects.cpp:
1785         (TextInputController::TextInputController):
1786         (TextInputController::doCommand):
1787         * DumpRenderTree/qt/jsobjects.h:
1788
1789 2007-10-24  Lars Knoll  <lars@trolltech.com>
1790
1791         Reviewed by Simon.
1792
1793         make the man webpage believe it has focus, so the editing tests work correctly.
1794
1795         * DumpRenderTree/qt/DumpRenderTree.cpp:
1796         (WebCore::DumpRenderTree::DumpRenderTree):
1797
1798 2007-10-24  Lars Knoll  <lars@trolltech.com>
1799
1800         Reviewed by Simon.
1801
1802         implement layoutTestController.dumpEditingCallbacks() correctly.
1803
1804         * DumpRenderTree/qt/DumpRenderTree.cpp:
1805         (WebCore::DumpRenderTree::DumpRenderTree):
1806         * DumpRenderTree/qt/jsobjects.cpp:
1807         (LayoutTestController::reset):
1808         (LayoutTestController::dumpEditingCallbacks):
1809
1810 2007-10-24  Lars Knoll  <lars@trolltech.com>
1811
1812         Reviewed by Simon.
1813
1814         Implement support for testing editing.
1815
1816         * DumpRenderTree/qt/DumpRenderTree.cpp:
1817         (WebCore::DumpRenderTree::DumpRenderTree):
1818
1819 2007-10-23  Sam Weinig  <sam@webkit.org>
1820
1821         Check for null BSTR that can be passed to the UIDelegate methods
1822         from javascript null and undefined.  Fixes a failing test case on
1823         Windows (fast/dom/Window/alert-undefined.html)
1824
1825         Reviewed by Eric Seidel.
1826
1827         * DumpRenderTree/win/UIDelegate.cpp:
1828         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1829         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1830         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1831         (UIDelegate::webViewAddMessageToConsole):
1832
1833 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1834
1835         Reviewed by Darin.
1836
1837         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1838
1839         * Scripts/build-testkjs:
1840
1841 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1842
1843         Reviewed by Darin.
1844
1845         - add wrapper that finds the right copy of testkjs
1846
1847         * Scripts/sunspider-compare-results: Added.
1848
1849 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1850
1851         Reviewed by Sam.
1852
1853         - After talking with Steve I now see that the WebKit server must be
1854         running for DCOM to create the distributed objects, which makes sense
1855         and currently WebKit only allows one instance to be running at a time
1856         which avoids accidentally connecting to the wrong server
1857         - In light of this I have removed the code for the attach box and
1858         NotificationServer and known server names, since they are all extranious
1859         now.
1860
1861         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1862         names.
1863         (_tWinMain): Uses init instead of initUI.
1864         (droseraWndProc): No longer creats an attach dialog box.
1865         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1866         it's not manditory to call init before doing COM stuff.
1867         (Drosera::init): calls initUI and will call attach when the
1868         functionality exists.
1869         (Drosera::initUI): Has changed very little.
1870         (Drosera::attach): Changed the signature to reflect that we no longer
1871         need the dictionary of known server names.
1872         * Drosera/win/Drosera.h: Removed notification classes and known server
1873         names.  Also renamed and moved some functions.
1874         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1875         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1876         headers to the resources folder.
1877         * Drosera/win/resource.h: Removed the Attach box.
1878
1879 2007-10-22  Adam Roben  <aroben@apple.com>
1880
1881         Windows build fix
1882
1883         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1884
1885 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1886
1887         - Removed a leak that was fixed.
1888
1889         * Scripts/run-webkit-tests:
1890
1891 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1892
1893         Reviewed by Darin.
1894
1895         - Changed the Client so that the DebuggerDocument now own the
1896         ServerConnection.  This simplifies ownership and cleanup.
1897
1898         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1899         ServerConnection.
1900         (DebuggerClient::initWithServerName):
1901         (DebuggerClient::didFinishLoadForFrame):
1902         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
1903         ServerConnection.
1904         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1905         until after we have a server which we are attached to.
1906         (Drosera::initUI):
1907         (Drosera::attach):
1908         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1909         out previously.
1910
1911 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1912
1913         Reviewed by Nikolas.
1914
1915         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1916
1917         * Scripts/run-javascriptcore-tests:
1918
1919 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1920
1921         Reviewed by Nikolas.
1922
1923         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1924
1925         * Scripts/build-drosera:
1926         * Scripts/build-dumprendertree:
1927         * Scripts/build-testkjs:
1928         * Scripts/build-webkit:
1929         * Scripts/run-javascriptcore-tests:
1930         * Scripts/run-sunspider:
1931         * Scripts/run-webkit-tests:
1932         * Scripts/webkitdirs.pm:
1933
1934 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1935
1936         Reviewed by Mark Rowe.
1937
1938         Fix for local database support after r26879
1939         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1940
1941         * Scripts/build-webkit:
1942
1943 2007-10-22  Holger Freyther  <zecke@selfish.org>
1944
1945         Reviewed by Simon Hausmann <hausmann@kde.org>.
1946
1947         - Do not build testkjs as an application bundle. This is
1948         needed for run-javascriptcore-tests on OSX.
1949         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1950         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1951         as we do not have -rpath on OSX.
1952
1953         * DumpRenderTree/qt/DumpRenderTree.pro:
1954         * Scripts/run-webkit-tests:
1955
1956 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1957
1958         Reviewed by aroben.
1959
1960         Fix support for Signed-off-by detection in prepare-ChangeLog
1961         --git-commit. The Signed-off-by tag does not appear in the header
1962         but usually at the end.
1963
1964         * Scripts/prepare-ChangeLog:
1965
1966 2007-10-21  Mark Rowe  <mrowe@apple.com>
1967
1968         Reviewed by Eric.
1969
1970         Fix run-javascriptcore-tests for Gtk.
1971
1972         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1973
1974 2007-10-20  Eric Seidel  <eric@webkit.org>
1975
1976         Reviewed by aroben.
1977
1978         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1979
1980 2007-10-20  Eric Seidel  <eric@webkit.org>
1981
1982         Reviewed by darin.
1983
1984         Add improved argument handling to run-sunspider, including
1985         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1986         Also re-factor code into subroutines
1987
1988         * Scripts/build-dumprendertree: removed bogus comments
1989         * Scripts/build-testkjs: Added.
1990         * Scripts/run-javascriptcore-tests: use build-testkjs
1991         * Scripts/run-sunspider: improved argument handling, abstraction
1992         * Scripts/run-webkit-tests: improved abstraction
1993
1994 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1995
1996         Not reviewed, Windows build fix.
1997
1998         * DumpRenderTree/win/EventSender.cpp:
1999         (keyDownCallback):
2000
2001 2007-10-20  Darin Adler  <darin@apple.com>
2002
2003         Reviewed by Tim Hatcher.
2004
2005         - http://bugs.webkit.org/show_bug.cgi?id=15544
2006           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2007           not rely on Apple-specific key codes
2008
2009         * DumpRenderTree/mac/EventSendingController.mm:
2010         (-[EventSendingController keyDown:withModifiers:]):
2011         Added named key "rightArrow". Later we could have a whole table of these.
2012         Also tweaked modifiers code a little.
2013
2014         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2015
2016 2007-10-19  Darin Adler  <darin@apple.com>
2017
2018         Reviewed by Eric.
2019
2020         - http://bugs.webkit.org/show_bug.cgi?id=15566
2021           possible fix for leak seen in DumpRenderTree
2022
2023         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2024         Delete the item if it's not put on the queue, since the caller has
2025         no way of knowing that. Would be better to have the parameter type
2026         be auto_ptr to express the fact that we take ownership.
2027
2028         - unrelated change
2029
2030         * Drosera/mac/main.m: Add missing include.
2031
2032 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2033
2034         Reviewed by Adam.
2035
2036         - This change should be identical but for some reason was not working
2037         on my machine.
2038
2039         * Scripts/prepare-ChangeLog:
2040
2041 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2042
2043         Reviewed by Oliver and Tim.
2044
2045         - Made use of RetainPtr to avoid retain and release issues and moved the
2046         log function to DebuggerDocumentPlatform, which seems to be a more
2047         logical place for it to live.
2048         - Also moved knownServers from the ServerConnection to
2049         DebuggerApplication to match the Windows code and because it makes sense
2050         that a connection knows its own server but not all of them.
2051
2052         * Drosera/mac/DebuggerClient.h: Moved the log function to
2053           DebuggerDocumentPlatform.
2054         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2055           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2056           call for the server name up from the ServerConnection class.
2057         (-[DebuggerClient dealloc]):
2058         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2059           for the server name up from the ServerConnection.
2060         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2061         (DebuggerDocument::platformPause):
2062         (DebuggerDocument::platformResume):
2063         (DebuggerDocument::platformStepInto):
2064         (DebuggerDocument::platformEvaluateScript):
2065         (DebuggerDocument::getPlatformCurrentFunctionStack):
2066         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2067         (DebuggerDocument::platformValueForScopeVariableNamed):
2068         (DebuggerDocument::platformLog): Log directly from here. No need to call
2069           DebuggerClient.
2070         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2071           way I see it, a ServerConnection should only know about its connection
2072           and the group of all possible servers should be kept by the
2073           application.
2074         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2075           currentServerName, it makes sense that the connection should know that
2076           name.
2077         (-[ServerConnection currentServerName]):
2078
2079 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2080
2081         Reviewed by Adam.
2082
2083         - Integrated changes from mac drosera.  Recently I've encapsulated
2084         out the server connection object from the rest of Drosera because
2085         it is very platform dependent right now and RPC is not implemented on
2086         windows.  This functionality, of communicating with the WebKit server
2087         is the next area I will be focusing on in Windows.
2088
2089         - Other changes and cleanup were made to organize the code and add notes
2090         on which parts still need work.  Also some mac code is added and
2091         commented out, to act as pseudocode for the logic of those parts.
2092
2093         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2094           pointer.
2095         * Drosera/config.h: Added whitespace.
2096         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2097           these files got moved into Drosera.h/cpp
2098         * Drosera/win/DebuggerApplication.h: Removed.
2099         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
2100           happened here to better match the logic flow of the same code on the
2101           mac side and to use the new ServerConnection class.
2102         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2103         (DebuggerClient::initWithServerName): Initializer that will set up the
2104           class to use a ServerConnection object.  This was necessary so I could
2105           create a DebuggerClient without having to initilaize it at
2106           construction.
2107         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2108           will be the UIDelegate and FrameLoadDelegate.
2109         (DebuggerClient::AddRef): For IUnknown.
2110         (DebuggerClient::Release): For IUnknown.
2111         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2112           this still needs to set the global context of the server, but
2113           IWebFrame does not have an accessor for the global context yet.
2114         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2115           this is a pass through for the same function in the document.
2116         (DebuggerClient::didReceiveTitle): Unimplemented part of
2117           FrameLoadDelegate this would change the title of the window.
2118         (DebuggerClient::createWebViewWithRequest): Part of the
2119           FrameLoadDelegate.  This is about new windows via Window.open() and
2120           how their delegates are set.
2121         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2122           UIDelegate.  Just a debug function for printing messages.
2123         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2124           because the Client should be the UIDelegate and FrameLoadDelegate
2125           to match the delegates on mac.
2126         (DebuggerClient::webViewLoaded): Added accessor method.
2127         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2128           forgotten to add this file before.  This is where the platform
2129           dependent versions of the Documents functions live. Most of these are
2130           unimplemented because some piece of functionality does not exist on
2131           Windows yet.
2132         (DebuggerDocument::platformPause):
2133         (DebuggerDocument::platformResume):
2134         (DebuggerDocument::platformStepInto):
2135         (DebuggerDocument::platformEvaluateScript):
2136         (DebuggerDocument::getPlatformCurrentFunctionStack):
2137         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2138         (DebuggerDocument::platformValueForScopeVariableNamed):
2139         (DebuggerDocument::platformLog):
2140         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2141           responsibilities becaue they belong in the Client. Also I laid the
2142           groundwork for attaching Drosera to a WebKit process
2143         (attachWndProc): Now if a server is selected the Client becomes it's
2144           delegate.
2145         (Drosera::Drosera): Added the construction of the Client and dictionary
2146           of server names.
2147         (Drosera::initUI): This is no longer the delegates, the Client is.
2148         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2149           state.
2150         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2151           notification registration when it's possible to implement.
2152         (Drosera::serverLoaded): Ditto
2153         (Drosera::serverUnloaded): Ditto
2154         (Drosera::attach): Attach Drosera to the WebKit server.
2155         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2156         (Drosera::getInst):
2157         (Drosera::setInst):
2158         (Drosera::knownServers):
2159         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2160           and added the ServerConnection.
2161         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2162         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2163           Most of the functions are completely unimlemented because they cannot
2164           connect with the WebKit server, because one does not exist on Windows
2165           yet.
2166         (ServerConnection::initWithServerName):
2167         (ServerConnection::~ServerConnection):
2168         (ServerConnection::setGlobalContext):
2169         (ServerConnection::pause):
2170         (ServerConnection::resume):
2171         (ServerConnection::stepInto):
2172         (ServerConnection::switchToServerNamed):
2173         (ServerConnection::applicationTerminating):
2174         (ServerConnection::serverConnectionDidDie):
2175         (ServerConnection::currentFrame):
2176         * Drosera/win/ServerConnection.h: Added. Ditto.
2177         (ServerConnection::ServerConnection):
2178
2179 2007-10-19  Alice Liu  <alice.liu@apple.com>
2180
2181         Reviewed by Darin.
2182
2183         Fix for these broken layout tests on Windows:
2184
2185         fast/forms/focus-selection-input.html
2186         fast/forms/focus-selection-textarea.html
2187         fast/forms/select-accesskey.html
2188
2189         * DumpRenderTree/win/EventSender.cpp:
2190         (keyDownCallback):
2191         correct the VK code for alt key.
2192
2193 2007-10-19  Eric Seidel  <eric@webkit.org>
2194
2195         Reviewed by Mark Rowe.
2196
2197         Make the GtkLauncher code slightly more readable.
2198
2199         * GtkLauncher/main.cpp:
2200         (setupMainMenu): Added.
2201         (setupMainWindowUI): Added.
2202         (main):
2203
2204 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2205
2206         Rubber stamped by Adam.
2207
2208         - don't delay-load WebKit in DumpRenderTree.
2209
2210         * DumpRenderTree/win/DumpRenderTree.vcproj:
2211
2212 2007-10-18  Dan Bernstein  <mitz@apple.com>
2213
2214         Reviewed by Adam Roben.
2215
2216         - fix <rdar://problem/5313523>
2217         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2218
2219         * DumpRenderTree/mac/DumpRenderTree.mm:
2220         (dump): Changed to use _responseMIMEType.
2221
2222 2007-10-17  Adam Roben  <aroben@apple.com>
2223
2224         Make it possible to have Windows-specific tests and results
2225
2226         When searching for tests to run and the Skipped file, we will only
2227         look in platform/win and the cross-platform directory. When looking
2228         for expected results, we will look in platform/win, then
2229         platform/mac-leopard, then platform/mac, then finally the
2230         cross-platform directory.
2231
2232         Reviewed by Sam.
2233
2234         * Scripts/run-webkit-tests:
2235         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2236         searching in the cross-platform directory.
2237         (sub buildPlatformHierarchy): Removed some unneeded calls to
2238         dirname/basename.
2239
2240 2007-10-17  Adam Roben  <aroben@apple.com>
2241
2242         Add back the call to register WebKit that we had before WebKitInitializer existed
2243
2244         This is needed to ensure that the right WebKit is used when
2245         instantiating COM objects.
2246
2247         Reviewed by Oliver.
2248
2249         * DumpRenderTree/win/debug_internal.vsprops: Define
2250         DEBUG_WEBKIT_HAS_SUFFIX.
2251         * DumpRenderTree/win/DumpRenderTree.cpp:
2252         (initialize):
2253
2254 2007-10-17  Adam Roben  <aroben@apple.com>
2255
2256         Import File::Basename in webkitdirs since we use it
2257
2258         * Scripts/webkitdirs.pm:
2259
2260 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2261
2262         - Updated the tiger leaks list to make the internal bots green.
2263
2264         * Scripts/run-webkit-tests:
2265
2266 2007-10-17  Adam Roben  <aroben@apple.com>
2267
2268         Build fix for VC++ Express
2269
2270         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2271         and ole32.lib.
2272
2273 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2274
2275         Reviewed by Sam.
2276
2277         - Minor mac improvements based on observations I made while implementing the
2278         Windows code.
2279
2280         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2281         then hand it to the Client who will retain it, it should just be the client who
2282         creates and owns the server.
2283         (-[DebuggerApplication attach:]):
2284         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2285         * Drosera/mac/DebuggerClient.mm: Creates the server.
2286         (-[DebuggerClient initWithServerName:]):
2287         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2288         can instead forward declare what it needs.
2289
2290 2007-10-16  Darin Adler  <darin@apple.com>
2291
2292         Reviewed by Geoff Garen.
2293
2294         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2295         want to turn failing tests into platform-specific test results. Also did a
2296         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2297         would take the type of results into account only some of the time.
2298
2299 2007-10-16  Adam Roben  <aroben@apple.com>
2300
2301         Add a new nightly launcher script for Windows
2302
2303         This new script is for versions of Safari that don't delay-load
2304         WebKit. I had to make FindSafari be able to print out the nightly
2305         launcher script on stdout because Windows shell scripts can't capture
2306         the output from a command into an environment variable.
2307
2308         Reviewed by Steve.
2309
2310         * FindSafari/FindSafari.cpp:
2311         (_tmain): Added /printSafariLauncher option.
2312         * Scripts/run-webkit-nightly.cmd: Added.
2313
2314 2007-10-16  Adam Roben  <aroben@apple.com>
2315
2316         Replace WebKitInitializer with FindSafari
2317
2318         We now rely on setting the PATH environment variable to tell Windows
2319         where to find WebKit and its dependencies (similar to
2320         DYLD_FRAMEWORK_PATH on Mac).
2321
2322         This change also make DumpRenderTree no longer delay-load WebKit.
2323
2324         Reviewed by Sam.
2325
2326         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2327         FindSafari.
2328         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2329         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2330         WebKitInitializer, don't delay-load WebKit.
2331         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2332         * Scripts/run-webkit-tests: Ditto.
2333         * Scripts/webkitdirs.pm:
2334         (sub setPathForRunningWebKitApp): Added.
2335         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2336         * WebKitInitializer/WebKitInitializer.h: Removed.
2337         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2338         * WebKitInitializer/debug.vsprops: Removed.
2339         * WebKitInitializer/debug_internal.vsprops: Removed.
2340         * WebKitInitializer/release.vsprops: Removed.
2341
2342 2007-10-16  Adam Roben  <aroben@apple.com>
2343
2344         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2345
2346         http://bugs.webkit.org/show_bug.cgi?id=15532
2347
2348         FindSafari simply prints the location of an installed Safari.exe on
2349         stdout.
2350
2351         Reviewed by Darin.
2352
2353         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2354         (getStringValue):
2355         (getWebViewCLSID):
2356         (getInstalledWebKitDirectory):
2357         (_tmain):
2358         * FindSafari/FindSafari.vcproj: Added.
2359         * Scripts/webkitdirs.pm:
2360         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2361
2362 2007-10-16  Adam Roben  <aroben@apple.com>
2363
2364         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2365
2366         Reviewed by Kevin McCullough.
2367
2368         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2369         when referring to WebKit.dll.
2370         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2371         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2372         * DumpRenderTree/win/release.vsprops: Ditto.
2373         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2374         never have a _debug suffix on WebKit.dll.
2375         * WebKitInitializer/WebKitInitializer.cpp:
2376         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2377         specified.
2378         * WebKitInitializer/debug_internal.vsprops: Added
2379         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2380
2381 2007-10-16  Darin Adler  <darin@apple.com>
2382
2383         Reviewed by Adele.
2384
2385         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2386         Remove now-unneeded control/alt key hack; the tests have been updated.
2387
2388 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2389
2390         - Updated leaks list because our internal bot upgraded it's version of leopard and
2391         one of the leaks was fixed between that revision and the bot's previous version of
2392         leopard.
2393
2394         * Scripts/run-webkit-tests:
2395
2396 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2397
2398         Reviewed by Tim.
2399
2400         - I encapsulated out the server connecton functionality because it is a specific part
2401         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2402         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2403         Windows.  So the majority of this patch is moving preexisting functionality.
2404
2405         - Also I removed the prefix header and changed to use config.h because it is more
2406         standard on how we use config.h in windows and it didn't make much sense to keep
2407         the prefix header and the config.h
2408
2409         * Drosera/DebuggerDocument.cpp:
2410         (DebuggerDocument::DebuggerDocument):
2411         * Drosera/DebuggerDocument.h:
2412         * Drosera/config.h:
2413         * Drosera/mac/DebuggerApplication.mm:
2414         (-[DebuggerApplication attach:]):
2415         * Drosera/mac/DebuggerClient.h:
2416         * Drosera/mac/DebuggerClient.mm:
2417         (-[DebuggerClient initWithServerConnection:]):
2418         (-[DebuggerClient dealloc]):
2419         (-[DebuggerClient windowDidLoad]):
2420         (-[DebuggerClient windowWillClose:]):
2421         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2422         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2423         * Drosera/mac/DebuggerDocumentPlatform.mm:
2424         (DebuggerDocument::platformPause):
2425         (DebuggerDocument::platformResume):
2426         (DebuggerDocument::platformStepInto):
2427         (DebuggerDocument::platformEvaluateScript):
2428         (DebuggerDocument::getPlatformCurrentFunctionStack):
2429         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2430         (DebuggerDocument::platformValueForScopeVariableNamed):
2431         (DebuggerDocument::platformLog):
2432         * Drosera/mac/Drosera.pch: Removed.
2433         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2434         * Drosera/mac/ServerConnection.h: Added.
2435         * Drosera/mac/ServerConnection.mm: Added.
2436         (-[ServerConnection initWithServerName:]):
2437         (-[ServerConnection dealloc]):
2438         (-[ServerConnection setGlobalContext:]):
2439         (-[ServerConnection pause]):
2440         (-[ServerConnection resume]):
2441         (-[ServerConnection stepInto]):
2442         (-[ServerConnection switchToServerNamed:]):
2443         (-[ServerConnection applicationTerminating:]):
2444         (-[ServerConnection serverConnectionDidDie:]):
2445         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2446         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2447         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2448         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2449         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2450         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2451         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2452         (-[ServerConnection currentFrame]):
2453         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2454         (-[ServerConnection knownServers]):
2455
2456 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2457
2458         Reviewed by Eric.
2459
2460         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2461           Script to automatically search nightly builds for regressions (bisect-builds)
2462
2463         * Scripts/bisect-builds: Added.
2464
2465 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2466
2467         Reviewed by Darin.
2468
2469         - New JavaScript benchmark
2470         http://bugs.webkit.org/show_bug.cgi?id=15515
2471
2472         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2473         current development or release build of JavaScriptCore.
2474
2475 2007-10-15  Mark Rowe  <mrowe@apple.com>
2476
2477         Reviewed by Sam.
2478
2479         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2480
2481         * Scripts/webkitdirs.pm:
2482         - Change checkArgv to remove the options from @ARGV to prevent
2483         them from interfering with further option processing.
2484         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2485         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2486         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2487         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2488
2489 2007-10-15  Darin Adler  <darin@apple.com>
2490
2491         Reviewed by Sam.
2492
2493         - added logging of window.prompt and window.confirm
2494
2495         * DumpRenderTree/mac/UIDelegate.mm:
2496         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2497         Implement the recommended delegate rather than the deprecated one.
2498         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2499         Added.
2500         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2501         Added.
2502
2503         * DumpRenderTree/win/UIDelegate.h:
2504         * DumpRenderTree/win/UIDelegate.cpp:
2505         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2506         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2507         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2508         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2509
2510 2007-10-15  Alice Liu  <alice.liu@apple.com>
2511
2512         Reviewed by Sam Weinig.
2513
2514         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2515
2516         * DumpRenderTree/win/DumpRenderTree.cpp:
2517         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2518         (main): allocate the global policy delegate for DRT's custom use
2519         * DumpRenderTree/win/DumpRenderTree.vcproj:
2520         Adding files to project
2521         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2522         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2523         (LayoutTestController::setCustomPolicyDelegate):
2524         set the webview's policy delegate to DRT's custom one if the test requests it.
2525         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2526         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2527         (PolicyDelegate::PolicyDelegate):
2528         (PolicyDelegate::QueryInterface):
2529         (PolicyDelegate::AddRef):
2530         (PolicyDelegate::Release):
2531         (PolicyDelegate::decidePolicyForNavigationAction):
2532         * DumpRenderTree/win/PolicyDelegate.h: Added.
2533         (PolicyDelegate::decidePolicyForNewWindowAction):
2534         (PolicyDelegate::decidePolicyForMIMEType):
2535         (PolicyDelegate::unableToImplementPolicyWithError):
2536
2537 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2538
2539         Reviewed by Mark.
2540
2541         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2542         when querying for QMAKE_MKSPECS.
2543
2544 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2545
2546         Reviewed by Adam Roben.
2547
2548         Fix run-webkit-tests is too greedy calculating platform hierarchy
2549         http://bugs.webkit.org/show_bug.cgi?id=15465
2550
2551         Fix run-webkit-tests being too greedy in trying to split the platform name up
2552         causing it to try and find tests in every directory above the first "-" in the
2553         path to the LayoutTests
2554
2555         * Scripts/run-webkit-tests:
2556
2557 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2558
2559         Reviewed by Darin.
2560
2561         http://bugs.webkit.org/show_bug.cgi?id=15006
2562         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2563         to reduce code duplication.
2564
2565         * Scripts/build-webkit:
2566         * Scripts/webkitdirs.pm:
2567         buildQMakeProject() renamed to buildQMakeQtProject().
2568         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2569         unused $colorize has been removed.
2570
2571 === Start merge of feature-branch 2007-10-12 ===
2572
2573 2007-10-08  Eric Seidel  <eric@webkit.org>
2574
2575         Reviewed by Mark Rowe.
2576
2577         * Scripts/build-webkit: add --help, remove unused --color
2578
2579 2007-10-07  Eric Seidel  <eric@webkit.org>
2580
2581         Reviewed by darin.
2582
2583         * Drosera/mac/DebuggerDocumentPlatform.mm:
2584         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2585
2586 2007-10-03  Rob Buis  <buis@kde.org>
2587
2588         Reviewed by Olliej.
2589
2590         Adapt to changed location of Ahem font.
2591
2592         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2593
2594 2007-10-02  Eric Seidel  <eric@webkit.org>
2595
2596         Reviewed by Adam Roben.
2597
2598         Make pixel tests more useful!
2599         Finally fix the image diff 0.00% mystery problem
2600         Highlight any image differences in the image diff.
2601         Add a link from image diffs back to original test file.
2602
2603         * DumpRenderTree/mac/ImageDiff.m:
2604         (compareImages): highlight any differences
2605         (computePercentageDifferent): round to two decimal places
2606         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2607
2608 2007-10-02  Eric Seidel  <eric@webkit.org>
2609
2610         Reviewed by Alexey Proskuryakov.
2611
2612         * Scripts/run-webkit-tests: print the % image difference on main results page
2613
2614 2007-10-02  Mark Rowe  <mrowe@apple.com>
2615
2616         Reviewed by Oliver.
2617
2618         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2619
2620         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2621         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2622
2623 2007-10-01  Mark Rowe  <mrowe@apple.com>
2624
2625         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2626
2627 2007-09-25  Eric Seidel  <eric@webkit.org>
2628
2629         Reviewed by Mark Rowe.
2630
2631         DerivedSources.make was finding "ENABLE_SVG" in the string
2632         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2633         quite correctly.
2634
2635         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2636
2637 2007-09-25  Mark Rowe  <mrowe@apple.com>
2638
2639         Rubber-stamped by Eric.
2640
2641         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2642         This makes it possible to automate nightly builds for the feature-branch.
2643
2644 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2645
2646         Rubber stamped by Mark.
2647
2648         Enable svg experimental features as default here in feature-branch.
2649
2650         * Scripts/build-webkit:
2651
2652 2007-06-29  Antti Koivisto  <antti@apple.com>
2653
2654         Reviewed by Weinig.
2655
2656         Add VIDEO flag for timed media features
2657
2658         * Scripts/build-webkit
2659
2660 === End merge of feature-branch 2007-10-12 ===
2661
2662 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2663
2664         Reviewed by Darin.
2665
2666         - Updated rational for the leaks list to be more clear.
2667
2668         * Scripts/run-webkit-tests:
2669
2670 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2671
2672         Rubber Stamp by Sam.
2673
2674         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2675         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2676
2677         * Scripts/run-webkit-tests:
2678
2679 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2680
2681         Reviewed by Lars.
2682
2683         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2684         includes are needed for INT_MAX, std::auto_ptr and the like.
2685
2686         * DumpRenderTree/qt/main.cpp:
2687
2688 2007-10-09  Lars Knoll  <lars@trolltech.com>
2689
2690         Reviewed by Simon.
2691
2692         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2693
2694         * DumpRenderTree/qt/jsobjects.cpp:
2695         (LayoutTestController::encodeHostName):
2696         (LayoutTestController::decodeHostName):
2697         * DumpRenderTree/qt/jsobjects.h:
2698
2699 2007-10-09  Lars Knoll  <lars@trolltech.com>
2700
2701         Reviewed by Simon.
2702
2703         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2704
2705         * DumpRenderTree/qt/DumpRenderTree.cpp:
2706         (WebCore::WebPage::createFrame):
2707         (WebCore::DumpRenderTree::DumpRenderTree):
2708         (WebCore::DumpRenderTree::titleChanged):
2709         * DumpRenderTree/qt/DumpRenderTree.h:
2710         * DumpRenderTree/qt/jsobjects.cpp:
2711         (LayoutTestController::reset):
2712         * DumpRenderTree/qt/jsobjects.h:
2713
2714 2007-10-09  Lars Knoll  <lars@trolltech.com>
2715
2716         Reviewed by Simon.
2717
2718         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2719
2720         * DumpRenderTree/qt/DumpRenderTree.h:
2721         * DumpRenderTree/qt/jsobjects.cpp:
2722         (LayoutTestController::clearBackForwardList):
2723         * DumpRenderTree/qt/jsobjects.h:
2724
2725 2007-10-09  Lars Knoll  <lars@trolltech.com>
2726
2727         Reviewed by Simon.
2728
2729         make --git-reviewer work again.
2730
2731         * Scripts/prepare-ChangeLog:
2732
2733 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2734
2735         Rubber stamped by Eric.
2736
2737         Connect to the "hovering-over-link" signal emitted by WebKitPage and
2738         show the current link inside the statusbar.
2739         This shows how to make use of this signal and allows to easily test
2740         http://bugs.webkit.org/show_bug.cgi?id=15299.
2741
2742         * GtkLauncher/main.cpp:
2743         (hoveringOverLink):
2744         (main):
2745
2746 2007-10-05  Lars Knoll  <lars@trolltech.com>
2747
2748         add proper error messages to the FrameLoaderClient.
2749         Implement ChromeClientQt::closeWindowSoon and
2750         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2751         Some fixes in DRT to make it work correctly with multiple windows.
2752
2753         Reviewed by Maciej.
2754
2755         * DumpRenderTree/qt/DumpRenderTree.cpp:
2756         (WebCore::DumpRenderTree::DumpRenderTree):
2757         (WebCore::DumpRenderTree::createWindow):
2758         (WebCore::DumpRenderTree::windowCount):
2759         * DumpRenderTree/qt/DumpRenderTree.h:
2760         * DumpRenderTree/qt/jsobjects.cpp:
2761         (LayoutTestController::maybeDump):
2762         (LayoutTestController::windowCount):
2763         * DumpRenderTree/qt/jsobjects.h:
2764
2765 2007-10-05  Lars Knoll  <lars@trolltech.com>
2766
2767         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
2768         Add support for layoutTextController.setCanOpenWindows() to DRT
2769         fixing another 2 test cases in fast/dom/Window.
2770
2771         Reviewed by Maciej.
2772
2773         * DumpRenderTree/qt/DumpRenderTree.cpp:
2774         (WebCore::WebPage::WebPage):
2775         (WebCore::WebPage::createWindow):
2776         (WebCore::DumpRenderTree::resetJSObjects):
2777         (WebCore::DumpRenderTree::createWindow):
2778         * DumpRenderTree/qt/DumpRenderTree.h:
2779         * DumpRenderTree/qt/DumpRenderTree.pro:
2780         * DumpRenderTree/qt/jsobjects.cpp:
2781         (LayoutTestController::LayoutTestController):
2782         (LayoutTestController::reset):
2783         * DumpRenderTree/qt/jsobjects.h:
2784         * DumpRenderTree/qt/main.cpp:
2785         * DumpRenderTree/qt/testplugin.cpp: Added.
2786         * DumpRenderTree/qt/testplugin.h: Added.
2787
2788 2007-10-04  Sam Weinig  <sam@webkit.org>
2789
2790         Rubber stamped by Adam.
2791
2792         Remove empty directories.
2793
2794         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2795         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2796
2797 2007-10-03  Darin Adler  <darin@apple.com>
2798
2799         Reviewed by Adam.
2800
2801         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2802         we find the internal libraries in the libraries directory. This
2803         is helpful for Safari team engineers at Apple.
2804
2805 2007-10-03  Adam Roben  <aroben@apple.com>
2806
2807         Update the location of AHEM___.TTF after r25968
2808
2809         Reviewed by Sam.
2810
2811         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2812
2813 2007-10-03  Alp Toker  <alp@atoker.com>
2814
2815         Reviewed by Adam.
2816
2817         http://bugs.webkit.org/show_bug.cgi?id=14726
2818         [gtk] API design. Mapping the WebView delegates to signals.
2819
2820         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2821
2822         * GtkLauncher/main.cpp:
2823         (goToURLBarText):
2824         (titleChanged):
2825         (progressChanged):
2826         (menuMainBackCallback):
2827         (menuMainForwardCallback):
2828         (main):
2829
2830 2007-10-03  Lars Knoll  <lars@trolltech.com>
2831
2832         Reviewed by Rob.
2833
2834         This fixes --strict mode in run-webkit-tests again after
2835         the platform dependent test results have been moved.
2836
2837         * Scripts/run-webkit-tests:
2838
2839 2007-10-03  Lars Knoll  <lars@trolltech.com>
2840
2841         Reviewed by bdash.
2842
2843         remove the hack in run-webkit-tests that forced text only test
2844         to be taken from the platform independent dir. It was only left
2845         there from early days.
2846
2847         Remove platform dependent results for tests that are text only nowadays,
2848         and add one platform dependent result for a text only test that requires it.
2849
2850         * Scripts/run-webkit-tests:
2851
2852 2007-10-03  Lars Knoll  <lars@trolltech.com>
2853
2854         Reviewed by olliej.
2855
2856         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2857
2858         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2859         (WebCore::WebFrame::WebFrame):
2860         (WebCore::WebPage::WebPage):
2861         (WebCore::WebPage::createFrame):
2862         (WebCore::WebPage::javaScriptAlert):
2863         (WebCore::WebPage::javaScriptConsoleMessage):
2864         (WebCore::DumpRenderTree::DumpRenderTree):
2865         (WebCore::DumpRenderTree::~DumpRenderTree):
2866         (WebCore::DumpRenderTree::open):
2867         (WebCore::DumpRenderTree::readStdin):
2868         (WebCore::DumpRenderTree::resetJSObjects):
2869         (WebCore::DumpRenderTree::initJSObjects):
2870         (WebCore::DumpRenderTree::dumpFramesAsText):
2871         (WebCore::DumpRenderTree::dump):
2872         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2873         (WebCore::DumpRenderTree::layoutTestController):
2874         (WebCore::DumpRenderTree::eventSender):
2875         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2876         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2877         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2878         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2879         (HackWebFrame::mousePressEvent):
2880         (HackWebFrame::mouseReleaseEvent):
2881         (HackWebFrame::mouseMoveEvent):
2882         (HackWebFrame::HackWebFrame):
2883         (HackWebFrame::~HackWebFrame):
2884         (LayoutTestController::LayoutTestController):
2885         (LayoutTestController::reset):
2886         (LayoutTestController::maybeDump):
2887         (LayoutTestController::waitUntilDone):
2888         (LayoutTestController::notifyDone):
2889         (LayoutTestController::dumpEditingCallbacks):
2890         (LayoutTestController::queueReload):
2891         (LayoutTestController::provisionalLoad):
2892         (LayoutTestController::timerEvent):
2893         (EventSender::EventSender):
2894         (EventSender::mouseDown):
2895         (EventSender::mouseUp):
2896         (EventSender::mouseMoveTo):
2897         (EventSender::leapForward):
2898         (EventSender::keyDown):
2899         (EventSender::frameUnderMouse):
2900         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2901         (LayoutTestController::isLoading):
2902         (LayoutTestController::setLoading):
2903         (LayoutTestController::shouldDumpAsText):
2904         (LayoutTestController::shouldDumpChildrenAsText):
2905         (LayoutTestController::shouldWaitUntilDone):
2906         (LayoutTestController::dumpAsText):
2907         (LayoutTestController::dumpChildFramesAsText):
2908         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2909         (messageHandler):
2910         (crashHandler):
2911         (main):
2912         * Scripts/run-webkit-tests:
2913
2914 2007-10-03  Mark Rowe  <mrowe@apple.com>
2915
2916         Reviewed by Alp Toker.
2917
2918         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2919         should take precedence over QTDIR when determining which port we are working with.
2920
2921         * Scripts/webkitdirs.pm:
2922
2923 2007-10-02  Adam Roben  <aroben@apple.com>
2924
2925         Add keychain to the list of default packages to install
2926
2927         Rubberstamped by Sam.
2928
2929         * CygwinDownloader/cygwin-downloader.py:
2930         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2931
2932 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2933
2934         Reviewed by Adam.
2935
2936         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2937         Also makes WebCore regression test case logic work when using git.
2938
2939         * Scripts/prepare-ChangeLog:
2940         (reviewerAndDescriptionForGitCommit): Added.
2941
2942 2007-10-02  Lars Knoll  <lars@trolltech.com>
2943
2944         Reviewed by bdash.
2945
2946         Add API to retrieve the frame name from QWebFrame.
2947         Implement support for DRT::dumpChildrenAsText.
2948
2949         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2950         (WebCore::DumpRenderTree::dumpFramesAsText):
2951         (WebCore::DumpRenderTree::dump):
2952         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2953         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2954         (LayoutTestController::LayoutTestController):
2955         (LayoutTestController::reset):
2956         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2957
2958 2007-10-02  Lars Knoll  <lars@trolltech.com>
2959
2960         Reviewed by bdash.
2961
2962         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2963
2964         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2965         (WebCore::DumpRenderTree::readStdin):
2966
2967 2007-10-02  Mark Rowe  <mrowe@apple.com>
2968
2969         Reviewed by Oliver.
2970
2971         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2972
2973         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2974         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2975
2976 2007-10-02  Mark Rowe  <mrowe@apple.com>
2977
2978         Rubber-stamped by Maciej.
2979
2980         Configuration changes from build.webkit.org.  The major change is refactoring to work
2981         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2982         last few weeks.
2983
2984         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2985         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2986         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2987         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2988         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2989         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2990         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2991         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2992
2993 2007-10-02  Lars Knoll  <lars@trolltech.com>
2994
2995         Reviewed by Maciej.
2996
2997         Add support for eventSender.mouseMove to DRT.
2998         Fixes fast/css/hover-affects-child.html
2999
3000         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3001         (EventSender::mouseMoveTo):
3002
3003 2007-10-01  Mark Rowe  <mrowe@apple.com>
3004
3005         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3006
3007 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3008
3009         Reviewed by Hyatt.
3010
3011         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3012
3013         * Scripts/svn-apply:
3014         (gitdiff2svndiff): Ignore lines beginning with "new file".
3015         * Scripts/svn-unapply:
3016         (gitdiff2svndiff): Ditto.
3017
3018 2007-09-30  George Staikos  <staikos@kde.org>
3019
3020         Qt build fix (Mac OS X specific)
3021
3022         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3023
3024 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3025
3026         Reviewed by Mark.
3027
3028         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3029         Remove Bakefiles from svn.
3030
3031         * GtkLauncher/Bakefiles.bkgen: Removed.
3032         * GtkLauncher/ENV: Removed.
3033         * GtkLauncher/gdklauncher.bkl: Removed.
3034         * GtkLauncher/mk: Removed.
3035         * Scripts/regenerate-makefiles: Removed.
3036
3037 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3038
3039         Reviewed by John.
3040
3041         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3042
3043         * Scripts/run-webkit-tests:
3044
3045 2007-09-26  Adam Roben  <aroben@apple.com>
3046
3047         Make not finding an installed WebKit non-fatal
3048
3049         What really matters is that we are able to load WebKit and its
3050         dependencies, not whether we think we've found an installed WebKit.
3051
3052         Reviewed by Sam.
3053
3054         * WebKitInitializer/WebKitInitializer.cpp:
3055         (getWebViewCLSID): Use new LOG_WARNING macro.
3056         (getInstalledWebKitDirectory): Ditto.
3057         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3058         and use new macros.
3059         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3060
3061 2007-09-26  Adam Roben  <aroben@apple.com>
3062
3063         Committed this file before saving it
3064
3065         * WebKitInitializer/debug_internal.vsprops:
3066
3067 2007-09-26  Adam Roben  <aroben@apple.com>
3068
3069         Load WebKit and its dependencies manually so they come from DllDirectory
3070
3071         I had to change WebKitInitializer to use malloc/free instead of
3072         new/delete to avoid pulling in WebKit (and its dependencies) early
3073         through use of fastMalloc.
3074
3075         Reviewed by Oliver.
3076
3077         * WebKitInitializer/WebKitInitializer.cpp:
3078         (getStringValue): Changed to use malloc/free.
3079         (getInstalledWebKitDirectory): Ditto.
3080         (initializeWebKit): Call SetDllDirectory first, then load all of
3081         WebKit's dependencies manually, finally followed by WebKit itself.
3082         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3083         configuration to match our other projects.
3084         * WebKitInitializer/debug_internal.vsprops: Added.
3085
3086 2007-09-25  Adam Roben  <aroben@apple.com>
3087
3088         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3089
3090         Rubberstamped by Sam.
3091
3092         * WebKitInitializer/WebKitInitializer.vcproj:
3093
3094 2007-09-25  Adam Roben  <aroben@apple.com>
3095
3096         Make DumpRenderTree delay-load its dependencies
3097
3098         This lets WebKitInitializer re-route the dependencies to be loaded out
3099         of the Safari installation directory.
3100
3101         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3102         same thing), since we can't import the kCFAllocatorDefault symbol when
3103         delay-loading CoreFoundation.dll.
3104
3105         Rubberstamped by Sam.
3106
3107         * DumpRenderTree/win/DumpRenderTree.cpp:
3108         (runTest):
3109         (javaScriptThreads):
3110         * DumpRenderTree/win/DumpRenderTree.vcproj:
3111         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3112         (LayoutTestController::setWaitToDump):
3113
3114 2007-09-25  Adam Roben  <aroben@apple.com>
3115
3116         Pull ole32.lib into WebKitInitializer
3117
3118         Rubberstamped by Sam.
3119
3120         * WebKitInitializer/WebKitInitializer.vcproj:
3121
3122 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3123
3124         Reviewed by Adam.
3125
3126         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3127           LGPL'ed files contain incorrect FSF address
3128
3129         * Drosera/config.h:
3130
3131 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3132
3133         Reviewed by Adam.
3134
3135         Make svn-apply and svn-unapply work with git-diff formatted patches.
3136
3137         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3138         (gitdiff2svndiff): Added.
3139         * Scripts/svn-unapply: Ditto.
3140         (gitdiff2svndiff): Added.
3141
3142 2007-09-25  Adam Roben  <aroben@apple.com>
3143
3144         Pull advapi32.lib into WebKitInitializer
3145
3146         This is needed to get the registry functions we use.
3147
3148         Rubberstamped by Sam.
3149
3150         * WebKitInitializer/WebKitInitializer.vcproj:
3151
3152 2007-09-25  Adam Roben  <aroben@apple.com>
3153
3154         Add python and rsync to cygwin-downloader
3155
3156         Our build slaves need this, and it can't hurt for everyone else to
3157         have it, too.
3158
3159         Reviewed by Sam.
3160
3161         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3162         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3163
3164 2007-09-25  Adam Roben  <aroben@apple.com>
3165
3166         Add WebKitInitializer and use it in DumpRenderTree
3167
3168         WebKitInitializer is a static library that has one function,
3169         initializeWebKit(). This registers WebKit and sets up the DLL search
3170         path so that WebKit's dependencies that are installed with Safari can
3171         be found.
3172
3173         Reviewed by Sam.
3174
3175         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3176         DumpRenderTree depend on it.
3177         * DumpRenderTree/win/DumpRenderTree.cpp:
3178         (initialize): Call initializeWebKit.
3179         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
3180         WebKitInitializer.lib.
3181         * WebKitInitializer/WebKitInitializer.cpp: Added.
3182         (getStringValue):
3183         (getWebViewCLSID):
3184         (getInstalledWebKitDirectory):
3185         (initializeWebKit):
3186         * WebKitInitializer/WebKitInitializer.h: Added.
3187         * WebKitInitializer/WebKitInitializer.vcproj: Added.
3188         * WebKitInitializer/debug.vsprops: Added.
3189         * WebKitInitializer/release.vsprops: Added.
3190
3191 2007-09-25  Adam Roben  <aroben@apple.com>
3192
3193         Make run-webkit-tests respect set-webkit-configuration
3194
3195         Reviewed by Sam.
3196
3197         * Scripts/run-webkit-tests: Initialize $configuration to whatever
3198         set-webkit-configuration was last set to.
3199
3200 2007-09-25  Mark Rowe  <mrowe@apple.com>
3201
3202         Rubber-stamped by Eric.
3203
3204         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3205         This makes it possible to automate nightly builds for the feature-branch.
3206
3207 2007-09-25  Adam Roben  <aroben@apple.com>
3208
3209         A couple of fixes/enhancements to update-webkit-*-libs
3210
3211         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
3212         to tell update-webkit-support-libraries where it should find the
3213         WebKitSupportLibrary.zip file you downloaded.
3214
3215         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
3216         Windows-style path.
3217
3218         Reviewed by Sam.
3219
3220         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
3221         to $auxiliaryLibsURL and removed an irrelevant comment.
3222         * Scripts/update-webkit-support-libs:
3223
3224 2007-09-25  Adam Treat  <treat@kde.org>
3225
3226         Reviewed by Simon and Lars.
3227
3228         Refactors and cleans up Qt DRT member variable names, member variable
3229         initialization, style fixes and general code cleanup.
3230
3231         Adds queueReload slot to LayoutTestController that some tests require.
3232
3233         Subclasses QWebFrame to make sure that all frames have an associated
3234         LayoutTestController JS window object.
3235
3236         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
3237         aren't dumped twice.
3238
3239         EOF fixes.
3240
3241         Together, this patch fixes some 20+ layout tests in QtWebKit.
3242
3243         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3244         (WebCore::WebFrame::WebFrame):
3245         (WebCore::WebPage::WebPage):
3246         (WebCore::WebPage::createFrame):
3247         (WebCore::DumpRenderTree::DumpRenderTree):
3248         (WebCore::DumpRenderTree::open):
3249         (WebCore::DumpRenderTree::readStdin):
3250         (WebCore::DumpRenderTree::initJSObjects):
3251         (WebCore::DumpRenderTree::dump):
3252         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3253         (WebCore::DumpRenderTree::layoutTestController):
3254         (WebCore::DumpRenderTree::eventSender):
3255         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3256         (LayoutTestController::LayoutTestController):
3257         (LayoutTestController::reset):
3258         (LayoutTestController::maybeDump):
3259         (LayoutTestController::waitUntilDone):
3260         (LayoutTestController::notifyDone):
3261         (LayoutTestController::queueReload):
3262         (LayoutTestController::provisionalLoad):
3263         (EventSender::EventSender):
3264         (EventSender::mouseDown):
3265         (EventSender::mouseUp):
3266         (EventSender::mouseMoveTo):
3267         (EventSender::frameUnderMouse):
3268         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3269         (LayoutTestController::isLoading):
3270         (LayoutTestController::setLoading):
3271         (LayoutTestController::dumpAsText):
3272         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3273         (main):
3274
3275 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3276
3277
3278         - Reverted an accidentally checked in file.
3279
3280         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3281
3282 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3283         Reviewed by Sam.
3284
3285         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
3286
3287         * DumpRenderTree/win/DumpRenderTree.vcproj:
3288         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3289
3290 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3291
3292         Rubber stamped by Adam.
3293
3294         * GdkLauncher: Removed.
3295         * GdkLauncher/Bakefiles.bkgen: Removed.
3296         * GdkLauncher/ENV: Removed.
3297         * GdkLauncher/GdkLauncher.pro: Removed.
3298         * GdkLauncher/gdklauncher.bkl: Removed.
3299         * GdkLauncher/main.cpp: Removed.
3300         * GdkLauncher/mk: Removed.
3301         * GdkLauncher/simple.svg: Removed.
3302         * GdkLauncher/text.html: Removed.
3303         * GtkLauncher: Added.
3304         * GtkLauncher/GdkLauncher.pro: Removed.
3305         * GtkLauncher/GtkLauncher.pro: Added.
3306         * GtkLauncher/main.cpp:
3307         (updateWindowTitle):
3308         (main):
3309         * Scripts/build-webkit:
3310         * Scripts/regenerate-makefiles:
3311         * Scripts/run-javascriptcore-tests:
3312         * Scripts/run-launcher:
3313         * Scripts/run-webkit-tests:
3314         * Scripts/webkitdirs.pm:
3315
3316 2007-09-21  Timothy Hatcher  <timothy@apple.com>
3317
3318         Reviewed by Darin.
3319
3320         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3321
3322         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
3323         This is tested by plugins/root-object-premature-delete-crash.html.
3324
3325         * DumpRenderTree/mac/ObjCController.m:
3326         (-[ObjCController accessStoredWebScriptObject]):
3327
3328 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
3329
3330         Reviewed by Oliver.
3331
3332         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
3333
3334         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3335         (FrameLoadDelegate::FrameLoadDelegate):
3336
3337 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
3338
3339         Reviewed by Adam.
3340
3341         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
3342         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
3343
3344         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
3345         Now isQt() and isGdk() use global variables that are only set once.
3346
3347         An array of all the parameters is now given to build-dumprender which includes
3348         the platform on linux.
3349
3350         * Scripts/build-dumprendertree:
3351         * Scripts/run-webkit-tests:
3352         * Scripts/webkitdirs.pm:
3353
3354 2007-09-19  Adam Roben  <aroben@apple.com>
3355
3356         Rubberstamped by Hyatt.
3357
3358         * Spinneret: Removed.
3359
3360 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
3361
3362         Reviewed by David Kilzer.
3363
3364         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
3365
3366 2007-09-18  Sam Weinig  <sam@webkit.org>
3367
3368         Add JSRetainPtr.h #include to fix some builds.
3369
3370         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3371
3372 2007-09-18  Mike Hommey  <glandium@debian.org>
3373
3374         Reviewed by Adam.
3375
3376         * Scripts/prepare-ChangeLog:
3377         - Properly parse GECOS field.
3378         - Use git configuration for user name and email when appropriate.
3379
3380 2007-09-17  Sam Weinig  <sam@webkit.org>
3381
3382         Build fix.
3383
3384         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3385
3386 2007-09-17  Sam Weinig  <sam@webkit.org>
3387
3388         Reviewed by Adam Roben.
3389
3390         Share more code between mac and windows DRT.
3391             - GCController is now shared.
3392             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
3393
3394         * DumpRenderTree/GCController.cpp:
3395         * DumpRenderTree/win/DumpRenderTree.cpp:
3396         * DumpRenderTree/win/DumpRenderTree.vcproj:
3397         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
3398         (FrameLoadDelegate::FrameLoadDelegate):
3399         (FrameLoadDelegate::~FrameLoadDelegate):
3400         (FrameLoadDelegate::windowScriptObjectAvailable):
3401         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
3402         * DumpRenderTree/win/GCController.cpp: Removed.
3403         * DumpRenderTree/win/GCController.h: Removed.
3404         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
3405         (GCController::collect):
3406         (GCController::collectOnAlternateThread):
3407         (GCController::getJSObjectCount):
3408         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
3409         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
3410
3411 2007-09-17  Sam Weinig  <sam@webkit.org>
3412
3413         Reviewed by Adam Roben.
3414
3415         Begin sharing code between mac and windows DRT.
3416             - both now share LayoutTestController.h/cpp and implement platform dependant
3417               operations in LayoutTestControllerMac/Win.
3418             - DumpRenderTree.h is now shared.
3419             - WorkQueue and WorkQueueItem are also shared.
3420
3421         * DumpRenderTree/DumpRenderTree.h:
3422         * DumpRenderTree/LayoutTestController.cpp:
3423         * DumpRenderTree/win/DumpRenderTree.cpp:
3424         (displayWebView):
3425         (dumpFrameScrollPosition):
3426         (dumpFramesAsText):
3427         (dump):
3428         (runTest):
3429         * DumpRenderTree/win/DumpRenderTree.h: Removed.
3430         * DumpRenderTree/win/DumpRenderTree.vcproj:
3431         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
3432         * DumpRenderTree/win/EditingDelegate.cpp:
3433         (EditingDelegate::shouldBeginEditingInDOMRange):
3434         (EditingDelegate::shouldEndEditingInDOMRange):
3435         (EditingDelegate::shouldInsertNode):
3436         (EditingDelegate::shouldInsertText):
3437         (EditingDelegate::shouldDeleteDOMRange):
3438         (EditingDelegate::shouldChangeSelectedDOMRange):
3439         (EditingDelegate::shouldApplyStyle):
3440         (EditingDelegate::shouldChangeTypingStyle):
3441         (EditingDelegate::doPlatformCommand):
3442         (EditingDelegate::webViewDidBeginEditing):
3443         (EditingDelegate::webViewDidChange):
3444         (EditingDelegate::webViewDidEndEditing):
3445         (EditingDelegate::webViewDidChangeTypingStyle):
3446         (EditingDelegate::webViewDidChangeSelection):
3447         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
3448         * DumpRenderTree/win/LayoutTestController.h: Removed.
3449         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
3450         (LayoutTestController::addDisallowedURL):
3451         (LayoutTestController::clearBackForwardList):
3452         (LayoutTestController::copyDecodedHostName):
3453         (LayoutTestController::copyEncodedHostName):
3454         (LayoutTestController::display):
3455         (LayoutTestController::keepWebHistory):
3456         (LayoutTestController::notifyDone):
3457         (LayoutTestController::queueBackNavigation):
3458         (LayoutTestController::queueForwardNavigation):
3459         (jsStringRefToWString):
3460         (LayoutTestController::queueLoad):
3461         (LayoutTestController::queueReload):
3462         (LayoutTestController::queueScript):
3463         (LayoutTestController::setAcceptsEditing):
3464         (LayoutTestController::setCustomPolicyDelegate):
3465         (LayoutTestController::setMainFrameIsFirstResponder):
3466         (LayoutTestController::setTabKeyCyclesThroughElements):
3467         (LayoutTestController::setUseDashboardCompatibilityMode):
3468         (LayoutTestController::setUserStyleSheetEnabled):
3469         (LayoutTestController::setUserStyleSheetLocation):
3470         (LayoutTestController::setWindowIsKey):
3471         (waitUntilDoneWatchdogFired):
3472         (LayoutTestController::setWaitToDump):
3473         (LayoutTestController::windowCount):
3474         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
3475         (FrameLoadDelegate::didReceiveTitle):
3476         (FrameLoadDelegate::processWork):
3477         (FrameLoadDelegate::locationChangeDone):
3478         (FrameLoadDelegate::windowScriptObjectAvailable):
3479         * DumpRenderTree/win/WorkQueue.cpp: Removed.
3480         * DumpRenderTree/win/WorkQueue.h: Removed.
3481         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
3482         * DumpRenderTree/win/WorkQueueItem.h: Removed.
3483         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
3484         (jsStringRefToWString):
3485         (LoadItem::invoke):
3486         (ScriptItem::invoke):
3487
3488 2007-09-17  Sam Weinig  <sam@webkit.org>
3489
3490         Reviewed by Adam Roben.
3491
3492         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
3493
3494         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
3495         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
3496         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
3497         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
3498         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
3499         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
3500         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
3501         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
3502         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
3503         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
3504         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
3505         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
3506         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
3507         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
3508         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
3509         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
3510         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
3511         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
3512         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
3513         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
3514         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
3515         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
3516         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
3517         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
3518         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
3519         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
3520         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
3521         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
3522         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
3523         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
3524         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
3525         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
3526         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
3527         * DumpRenderTree/win: Added.
3528         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
3529         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
3530         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
3531         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
3532         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
3533         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
3534         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
3535         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
3536         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
3537         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
3538         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
3539         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
3540         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
3541         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3542         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
3543         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
3544         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
3545         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
3546         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3547         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3548         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
3549         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3550         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
3551         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
3552         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
3553         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
3554
3555 2007-09-15  Mark Rowe  <mrowe@apple.com>
3556
3557         Build fix for DumpRenderTree.
3558
3559         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
3560
3561 2007-09-14  Sam Weinig  <sam@webkit.org>
3562
3563         Rubber stamped by Adam Roben.
3564
3565         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
3566           - The UIDelegate was put into a new file while the FrameLoadDelegate was
3567             kept in the WaitUntilDoneDelegate file for the time being.
3568
3569         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3570         (main):
3571         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
3572         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
3573         (UIDelegate::QueryInterface):
3574         (UIDelegate::AddRef):
3575         (UIDelegate::Release):
3576         (UIDelegate::hasCustomMenuImplementation):
3577         (UIDelegate::setFrame):
3578         (UIDelegate::webViewFrame):
3579         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3580         (UIDelegate::webViewAddMessageToConsole):
3581         (UIDelegate::doDragDrop):
3582         (UIDelegate::webViewGetDlgCode):
3583         * DumpRenderTree/DumpRenderTree.vcproj/DumpRender