2009-11-16 Eric Seidel <eric@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-16  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Adam Barth.
4
5         Document check-style's use of force_clean.
6
7         * Scripts/bugzilla-tool:
8         * Scripts/modules/scm.py:
9
10 2009-11-16  Adam Barth  <abarth@webkit.org>
11
12         Reviewed by Eric Seidel.
13
14         Move WorkQueue to its own file
15         https://bugs.webkit.org/show_bug.cgi?id=31529
16
17         WorkQueue and WorkQueueDelegate are separate concerns from
18         bugzilla-tool.  Also added a missing include to logging.py.
19
20         * Scripts/bugzilla-tool:
21         * Scripts/modules/logging.py:
22         * Scripts/modules/workqueue.py:
23
24 2009-11-16  Adam Barth  <abarth@webkit.org>
25
26         Reviewed by Eric Seidel.
27
28         Move OutputTee to logging.py.
29
30         * Scripts/bugzilla-tool:
31         * Scripts/modules/logging.py:
32
33 2009-11-15  Adam Barth  <abarth@webkit.org>
34
35         Reviewed by Eric Seidel.
36
37         Refactor bugzilla-tool to allow for multiple queues
38         https://bugs.webkit.org/show_bug.cgi?id=31513
39
40         Divide the commit queue class into three class to make creating
41         additional queues easier.
42
43         * Scripts/bugzilla-tool:
44
45 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
46
47         Reviewed by Eric Seidel.
48
49         svn-apply may not handle git patches created by bugzilla-tool
50         https://bugs.webkit.org/show_bug.cgi?id=31457
51
52         * Scripts/modules/scm.py:
53         * Scripts/modules/scm_unittest.py:
54
55 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
56
57         Reviewed by Eric Seidel.
58
59         bugzilla-tool should post git binary diff
60         https://bugs.webkit.org/show_bug.cgi?id=31458
61
62         Add --binary option to Git.create_patch.
63
64         * Scripts/modules/scm.py:
65         * Scripts/modules/scm_unittest.py:
66
67 2009-11-15  Adam Barth  <abarth@webkit.org>
68
69         Reviewed by Darin Adler.
70
71         Add bugzilla-tool check-style
72         https://bugs.webkit.org/show_bug.cgi?id=31515
73
74         * Scripts/bugzilla-tool:
75         * Scripts/modules/bugzilla.py:
76
77 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
78
79         Reviewed by Simon Hausmann.
80
81         Make the Qt Linux only --valgrind feature, suppress errors
82         defined in the SuppressedValgrindErrors file.
83
84         * Scripts/run-webkit-tests:
85
86 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
87
88         Reviewed by Simon Hausmann.
89
90         Set the locale to C and not to the current one in use on the system.
91
92         * DumpRenderTree/qt/DumpRenderTree.cpp:
93         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
94
95 2009-11-13  Adam Roben  <aroben@apple.com>
96
97         Add support for
98         http/tests/security/isolatedWorld/didClearWindowObject.html
99
100         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
101         window objects in isolated worlds are cleared
102
103         Reviewed by Dave Hyatt.
104
105         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
106
107         * DumpRenderTree/mac/FrameLoadDelegate.mm:
108         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
109         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
110         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
111         Added. Sets a __worldID property on the global object whose value is
112         the ID of this world.
113         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
114         Respond to this new delegate callback by calling through to one of the
115         above new methods.
116         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
117         (worldMap): Added. Returns a HashMap containing all the worlds we've
118         created.
119         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
120         haven't kept track of this world.
121         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
122         instead of declaring our own.
123
124         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
125
126         * DumpRenderTree/win/FrameLoadDelegate.cpp:
127         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
128         didClearWindowObjectForFrameInStandardWorld.
129         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
130         Respond to this new delegate callback by calling through to one of the
131         below new methods.
132         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
133         Added. Sets a __worldID property on the gobal object whose value is
134         the ID of this world.
135         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
136         Added. Moved code here from didClearWindowObject.
137
138         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
139         didClearWindowObjectForFrame* functions.
140
141         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
142         (worldMap): Added. Returns a HashMap containing all the worlds we've
143         created.
144         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
145         haven't kept track of this world.
146         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
147         instead of declaring our own.
148
149 2009-11-13  Adam Roben  <aroben@apple.com>
150
151         Finish replacing worldIDs with world objects
152
153         The only remaining use of worldIDs was in a method only used by DRT
154         for the isolated worlds tests.
155
156         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
157
158         Reviewed by Mark Rowe.
159
160         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
161         (LayoutTestController::evaluateScriptInIsolatedWorld):
162         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
163         (LayoutTestController::evaluateScriptInIsolatedWorld):
164         Updated for changes to WebFrame. Now holds the map of worldID -> world
165         at this level instead of making WebKit do it.
166
167 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
168
169         Reviewed by Simon Hausmann.
170
171         [Qt] Ensure the DRT does not output anything until first test is run
172
173         * DumpRenderTree/qt/DumpRenderTree.cpp:
174         * DumpRenderTree/qt/DumpRenderTree.h:
175
176 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
177
178         Reviewed by Tor Arne Vestbø.
179
180         Clear the undo stack in before each new test run.
181
182         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
183
184         * DumpRenderTree/qt/DumpRenderTree.cpp:
185         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
186
187 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
188
189         Reviewed by Kenneth Rohde Christiansen.
190
191         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
192
193         * DumpRenderTree/qt/DumpRenderTree.cpp:
194         (WebCore::WebPage::resetSettings):
195         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
196         (LayoutTestController::overridePreference):
197
198 2009-11-13  Eric Seidel  <eric@webkit.org>
199
200         Reviewed by Adam Barth.
201
202         Update committers.py based on svn records
203         https://bugs.webkit.org/show_bug.cgi?id=31366
204
205         This list was generated using validate-committer-lists from
206         https://bugs.webkit.org/show_bug.cgi?id=30970
207         and makes committers.py current for committers who have
208         committed in the last 3 years.
209
210         * Scripts/modules/committers.py:
211
212 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
213
214         Reviewed by Adam Barth.
215
216         The document-open.html test was flaky at times. The test invokes the layout test plugin
217         which in its destroy stream handler opens a new document. This basically tears down the
218         stream and the associated plugin instance. The pluginLog function in the layout test
219         plugin attempts to retrieve the window script object on a torn down plugin instance
220         which crashed consistently on windows in the debugger. The functions which issue
221         these logs already have a valid window script object. We now have variants of the pluginLog
222         function which take in a window script object with and without variable arguments. 
223
224         https://bugs.webkit.org/show_bug.cgi?id=31067
225
226         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
227         (pluginLogWithWindowObject):
228         (pluginLogWithWindowObjectVariableArgs):
229         (pluginLog):
230         (notifyTestCompletion):
231         (testDocumentOpen):
232         (testWindowOpen):
233
234 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
235
236         Reviewed by Gustavo Noronha Silva.
237
238         https://bugs.webkit.org/show_bug.cgi?id=30997
239         [Gtk] Implemment AtkDocument
240
241         Added testing support.
242
243         * DumpRenderTree/AccessibilityUIElement.cpp:
244         * DumpRenderTree/AccessibilityUIElement.h:
245         (getDocumentEncodingCallback):
246         (getDocumentURICallback):
247         (AccessibilityUIElement::getJSClass):
248         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
249         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
250         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
251         (AccessibilityUIElement::documentEncoding):
252         (AccessibilityUIElement::documentURI):
253
254 2009-11-12  Adam Roben  <aroben@apple.com>
255
256         Replace worldIDs with world objects
257
258         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
259         user scripts/stylesheets and isolated worlds
260
261         Reviewed by Sam Weinig.
262
263         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
264         (LayoutTestController::addUserScript):
265         (LayoutTestController::addUserStyleSheet):
266         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
267         (LayoutTestController::addUserScript):
268         (LayoutTestController::addUserStyleSheet):
269         Changed these functions to create a new WebJSWorld each time they're
270         called and to pass that world to WebKit.
271
272 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
273
274         Reviewed by Oliver Hunt.
275
276         need to implement aria tree roles
277         https://bugs.webkit.org/show_bug.cgi?id=31284
278
279         * DumpRenderTree/AccessibilityUIElement.cpp:
280         (disclosedRowAtIndexCallback):
281         (selectedRowAtIndexCallback):
282         (isEqualCallback):
283         (isAttributeSettableCallback):
284         (isActionSupportedCallback):
285         (disclosedByRowCallback):
286         (hierarchicalLevelCallback):
287         (AccessibilityUIElement::getJSClass):
288         * DumpRenderTree/AccessibilityUIElement.h:
289         (AccessibilityUIElement::isEqual):
290         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
291         (AccessibilityUIElement::hierarchicalLevel):
292         (AccessibilityUIElement::disclosedRowAtIndex):
293         (AccessibilityUIElement::selectedRowAtIndex):
294         (AccessibilityUIElement::disclosedByRow):
295         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
296         (AccessibilityUIElement::getChildAtIndex):
297         (AccessibilityUIElement::disclosedRowAtIndex):
298         (AccessibilityUIElement::selectedRowAtIndex):
299         (AccessibilityUIElement::titleUIElement):
300         (AccessibilityUIElement::parentElement):
301         (AccessibilityUIElement::disclosedByRow):
302         (AccessibilityUIElement::hierarchicalLevel):
303         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
304         (AccessibilityUIElement::hierarchicalLevel):
305         (AccessibilityUIElement::disclosedRowAtIndex):
306         (AccessibilityUIElement::selectedRowAtIndex):
307         (AccessibilityUIElement::disclosedByRow):
308
309 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
310
311         Reviewed by Darin Adler.
312
313         svn-apply can not handle git binary diffs
314         https://bugs.webkit.org/show_bug.cgi?id=26830
315
316         Support "literal" type git binary diffs.
317
318         * Scripts/VCSUtils.pm:
319         * Scripts/modules/scm_unittest.py:
320         * Scripts/svn-apply:
321
322 2009-11-11  Dmitry Titov  <dimich@chromium.org>
323
324         Not reviewed, removing duplicate entry for myself in committers.py.
325
326         * Scripts/modules/committers.py:
327
328 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
329
330         Reviewed by Darin Adler and Mark Rowe.
331
332         https://bugs.webkit.org/show_bug.cgi?id=31200
333         Tests in http/tests/security/mixedContent start to fail when new tests are added
334
335         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
336
337 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
338
339         Reviewed by Jan Alonzo.
340
341         Create, and display a window for the inspector, for inspector
342         tests.
343
344         Need to also show/hide the inspector window to avoid having
345         problems with code assuming it is realized
346         https://bugs.webkit.org/show_bug.cgi?id=31347
347
348         * DumpRenderTree/gtk/DumpRenderTree.cpp:
349         (webInspectorShowWindow):
350         (webInspectorCloseWindow):
351         (webInspectorInspectWebView):
352         (createWebView):
353
354 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
355
356         Unreviewed Qt buildbot fix.
357
358         My previous fix was wrong, so revert that change and fix it by
359         returning when the document of the frame has no document element.
360         Idea is borrowed from mac and win DRT.
361
362         * DumpRenderTree/qt/DumpRenderTree.cpp:
363         (WebCore::DumpRenderTree::dumpFramesAsText):
364
365 2009-11-11  Eric Seidel  <eric@webkit.org>
366
367         Reviewed byg Kenneth Rohde Christiansen.
368
369         Update Kenneth's committer record to include the email he
370         uses on lists.webkit.org.
371
372         * Scripts/modules/committers.py:
373
374 2009-11-11  Eric Seidel  <eric@webkit.org>
375
376         Reviewed by Gustavo Noronha Silva.
377
378         Several committers use separate email addresses for bugzilla and svn.webkit.org
379         https://bugs.webkit.org/show_bug.cgi?id=31364
380
381         Update records for existing committers to include email addresses
382         used in svn.webkit.org and lists.webkit.org.
383         Most committers use the same email address in all 3 places, but some use
384         separate addresses.  committers.py needs record of each of these addresses.
385
386         * Scripts/modules/committers.py:
387
388 2009-11-11  Eric Seidel  <eric@webkit.org>
389
390         No review, adding second email address for an existing committer.
391
392         Add Yong Li's second bugzilla account to his committer record.
393         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
394
395         * Scripts/modules/committers.py:
396
397 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
398
399         Reviewed by Simon Hausmann.
400
401         If the frame has no innerText don't append it, and
402         do not add a newline which breaks some cross platform
403         results.
404
405         * DumpRenderTree/qt/DumpRenderTree.cpp:
406         (WebCore::DumpRenderTree::dumpFramesAsText):
407
408 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
409
410         Reviewed by Simon Hausmann.
411
412         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
413
414         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
415         (webkit_test_plugin_new_instance):
416         (webkit_test_plugin_destroy_instance):
417         (webkit_test_plugin_destroy_stream):
418
419 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
420
421         Reviewed by Mark Rowe.
422
423         Implement the functionality needed by plugins/window-open.html
424
425         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
426         (webkit_test_plugin_new_instance):
427         (webkit_test_plugin_set_window):
428
429 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
430
431         Reviewed by Simon Hausmann.
432
433         [Qt] Force -graphicssystem raster and -style windows when running DRT
434
435         * DumpRenderTree/qt/main.cpp:
436         * Scripts/run-webkit-tests:
437
438 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
439
440         Reviewed by Simon Hausmann.
441
442         Compute correct library paths for Qt
443
444         * Scripts/webkitdirs.pm:
445
446 2009-11-10  Mark Rowe  <mrowe@apple.com>
447
448         Reviewed by Sam Weinig.
449
450         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
451
452         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
453         about the validity of the self-signed certificates used in the regression tests.  We would then add the
454         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
455         that had enabled frame load delegate logging this would result in extra log messages being generated,
456         causing the test to fail.
457
458         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
459         tests.
460
461         * DumpRenderTree/mac/DumpRenderTree.mm:
462         (dumpRenderTree):
463         * DumpRenderTree/mac/FrameLoadDelegate.mm:
464         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
465
466 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
467
468         Reviewed by Kenneth Rohde Christiansen.
469
470         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
471
472         * DumpRenderTree/qt/DumpRenderTree.cpp:
473         (WebCore::DumpRenderTree::DumpRenderTree):
474
475 2009-11-10  Philippe Normand  <pnormand@igalia.com>
476
477         Reviewed by Jan Alonzo.
478
479         [GTK] Remove WebSocket configuration from WebKitWebSettings
480         https://bugs.webkit.org/show_bug.cgi?id=31244
481
482         Follow-up of r50724. Don't set the enable-web-socket property
483         anymore.
484
485         * DumpRenderTree/gtk/DumpRenderTree.cpp:
486         (resetDefaultsToConsistentValues):
487
488 2009-11-10  Oliver Hunt  <oliver@apple.com>
489
490         Reviewed by Maciej Stachowiak.
491
492         Rename 3D Canvas related classes to use WebGL prefix
493         https://bugs.webkit.org/show_bug.cgi?id=29095
494
495         Checkin new version of do-webcore-rename used to do the WebGL type rename,
496         and upate webkitdirs script to new method of testing for WebGL.
497
498         * Scripts/do-webcore-rename:
499         * Scripts/webkitdirs.pm:
500
501 2009-11-09  Oliver Hunt  <oliver@apple.com>
502
503         Reviewed by Geoff Garen.
504
505         Make do-webcore-rename work with git.
506
507         * Scripts/do-webcore-rename:
508
509 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
510
511         Adding Kenneth to the reviewers list.
512
513         * Scripts/modules/committers.py:
514
515 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
516
517         Reviewed by Jan Alonzo.
518
519         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
520         https://bugs.webkit.org/show_bug.cgi?id=30482
521
522         LayoutTestControllerGtk now uses the exposed
523         Page::tabKeyCyclesThroughElements API
524
525         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
526         (LayoutTestController::setTabKeyCyclesThroughElements):
527
528 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
529
530         Reviewed by Holger Freyther.
531
532         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
533         This helps to pass the test case below. Also replaced hardcoded
534         code numbers with defined constants.
535         https://bugs.webkit.org/show_bug.cgi?id=31185
536         
537         Test: editing/undo/undo-deleteWord.html
538
539         * DumpRenderTree/qt/EventSenderQt.cpp:
540         (EventSender::keyDown):
541
542 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
543
544         Reviewed by Holger Freyther.
545
546         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
547         https://bugs.webkit.org/show_bug.cgi?id=31164
548
549         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
550
551         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
552         (LayoutTestController::processWork):
553
554 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
555
556         Reviewed by Holger Freyther.
557
558         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
559         https://bugs.webkit.org/show_bug.cgi?id=31158
560
561         By invoking a script queue'd by queueScript(), 'true' was beeing returned
562         always, which from WorkQueue prospective means that a load has been started
563         and the queue processing should stop and wait for the load to finish.
564         Spinning it off into a loading and a non-loading variants was the solution
565         adopted by Mac's DRT to work around this problem. The former keeps returning
566         'true' while the later executes the script synchronously and returns 'false'
567         making it possible to the WorkQueue to proceed right away.
568
569         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
570         (LayoutTestController::processWork):
571         (LayoutTestController::queueLoadingScript):
572         (LayoutTestController::queueNonLoadingScript):
573         * DumpRenderTree/qt/LayoutTestControllerQt.h:
574         * DumpRenderTree/qt/WorkQueueItem.h:
575         (LoadingScriptItem::LoadingScriptItem):
576         (LoadingScriptItem::invoke):
577         (NonLoadingScriptItem::NonLoadingScriptItem):
578         (NonLoadingScriptItem::invoke):
579
580 2009-11-07  Mark Rowe  <mrowe@apple.com>
581
582         Rubber-stamped by Cameron Zwarich.
583
584         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
585
586         * Scripts/commit-log-editor:
587
588 2009-11-07  Mark Rowe  <mrowe@apple.com>
589
590         Reviewed by Darin Adler.
591
592         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
593         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
594
595         Move logic for determining the name and email address to use in a ChangeLog entry from
596         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
597         whether the author of the patch matches committer, and therefore needs access to the
598         email address that would be used in a ChangeLog entry.
599
600         Based on a patch by Pierre d'Herbemont.
601
602         * Scripts/VCSUtils.pm:
603         * Scripts/commit-log-editor:
604         * Scripts/prepare-ChangeLog:
605         * Scripts/webkitdirs.pm:
606
607 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
608
609         Reviewed by Adam Barth.
610
611         Added functionality to the layout test plugin to invoke document.open and
612         window.open with default arguments. The associated webkit bug is
613         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
614         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
615         work in Chromium (V8) if there is no calling javascript context. To achieve this
616         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
617         for the window.open test case and in NPP_DestroyStream for the document.open test case.
618
619         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
620         (testDocumentOpen):
621         (testWindowOpen):
622         (pluginAllocate):
623         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
624         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
625         (NPP_New):
626         (NPP_SetWindow):
627         (NPP_DestroyStream):
628         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
629         (NPP_New):
630         (NPP_SetWindow):
631         (NPP_NewStream):
632         (NPP_DestroyStream):
633
634 2009-11-06  Eric Seidel  <eric@webkit.org>
635
636         Reviewed by Adam Barth.
637
638         bugzilla-tool crashed with exception
639         https://bugs.webkit.org/show_bug.cgi?id=31092
640
641         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
642
643 2009-11-04  Eric Seidel  <eric@webkit.org>
644
645         No review, just add a line which got left out of the patch uploaded for commit.
646
647         commit-queue is crashing when trying to reject patches after unknown failures
648         https://bugs.webkit.org/show_bug.cgi?id=31091
649
650         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
651
652 2009-11-04  Adam Roben  <aroben@apple.com>
653
654         Remove bogus else clause in bugzilla-tool
655
656         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
657         create-bug raises exception after entering bug description
658
659         Reviewed by David Kilzer.
660
661         * Scripts/bugzilla-tool:
662         (CreateBug): else clauses are only hit if no exception is raised, so
663         it makes no sense to try to re-raise the exception in an else clause.
664         The exception will automatically be re-raised if it doesn't match any
665         of the except clauses, so we don't have to do anything special here at
666         all to get the desired behavior.
667
668 2009-11-04  Eric Seidel  <eric@webkit.org>
669
670         Reviewed by David Kilzer.
671
672         svn-apply's fixChangeLogPatch function seems broken
673         https://bugs.webkit.org/show_bug.cgi?id=30683
674
675         Update fixChangeLogPatch to be able to handle patches which
676         don't start at line 1.
677         Add unit tests for svn-apply to scm_unittest.py.
678
679         * Scripts/VCSUtils.pm:
680         * Scripts/modules/scm_unittest.py:
681
682 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
683
684         Reviewed by Beth Dakin.
685
686         Need to implement ARIA role="combobox"
687         https://bugs.webkit.org/show_bug.cgi?id=31096
688
689         * DumpRenderTree/AccessibilityUIElement.cpp:
690         (showMenuCallback):
691         (getIsExpandedCallback):
692         (AccessibilityUIElement::getJSClass):
693         * DumpRenderTree/AccessibilityUIElement.h:
694         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
695         (AccessibilityUIElement::isExpanded):
696         (AccessibilityUIElement::showMenu):
697         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
698         (AccessibilityUIElement::isExpanded):
699         (AccessibilityUIElement::showMenu):
700         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
701         (AccessibilityUIElement::isSelected):
702         (AccessibilityUIElement::isExpanded):
703         (AccessibilityUIElement::showMenu):
704
705 2009-11-04  Eric Seidel  <eric@webkit.org>
706
707         Reviewed by Adam Barth.
708
709         commit-queue is crashing when trying to reject patches after unknown failures
710         https://bugs.webkit.org/show_bug.cgi?id=31091
711
712         * Scripts/bugzilla-tool:
713          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
714            so we have to find out what the current patch is by asking bugzilla again.
715          - Discovered that this code was also leaking file descriptors, so fixed that.
716
717 2009-11-04  Adam Roben  <aroben@apple.com>
718
719         Make run-webkit-tests work for the Debug_Internal Windows
720         configuration
721
722         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
723         suffix.
724
725         Fixes <http://webkit.org/b/31123>.
726
727         Reviewed by Sam Weinig.
728
729         * Scripts/run-webkit-tests: Don't add the _debug suffix in
730         Debug_Internal, either.
731
732 2009-11-04  Eric Seidel  <eric@webkit.org>
733
734         Reviewed by Adam Barth.
735
736         committers.py needs a way to store non-bugzilla email addresses
737         https://bugs.webkit.org/show_bug.cgi?id=31037
738
739         Make Committer and Reviewer constructors take a single email or a list of emails.
740         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
741         Expose reviewers(), used by validate-committer-lists on bug 30970.
742
743         * Scripts/modules/committers.py:
744         * Scripts/modules/committers_unittest.py: Added tests for the new code.
745
746 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
747
748         Reviewed by David Levin.
749
750         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
751         https://bugs.webkit.org/show_bug.cgi?id=27491
752
753         The test path determination logic is changed to handle websocket and websocket/ssl cases.
754         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
755
756         Functions to start or stop Web Socket servers are added.
757
758         * Scripts/run-webkit-tests:
759
760 2009-11-03  Eric Seidel  <eric@webkit.org>
761
762         No review, just changing wording of log message.
763
764         Change log string to say "failed" instead of "rejected"
765         when a commit fails due to an out of date checkout.
766         This makes grepping the commit-queue log for rejected patches easier.
767
768         * Scripts/bugzilla-tool:
769
770 2009-11-03  Eric Seidel  <eric@webkit.org>
771
772         No review, adding commonly known committers missing from the file.
773
774         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
775
776 2009-11-03  Eric Seidel  <eric@webkit.org>
777
778         No review, just sort-order cleanup.
779
780         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
781
782 2009-11-03  Stephen White  <senorblanco@chromium.org>
783
784         (Unreviewed).
785
786         Add myself to committers.py.
787
788         * Scripts/modules/committers.py:
789
790 2009-11-03  Robin Dunn  <robin@alldunn.com>
791
792         Reviewed by Kevin Ollviier.
793
794         Add packaging scripts for Debian-based Linux distros.
795         
796         https://bugs.webkit.org/show_bug.cgi?id=31075
797
798         * wx/packaging/build-debian-installer.py: Added.
799         * wx/packaging/debian: Added.
800
801 2009-11-03  Dan Bernstein  <mitz@apple.com>
802
803         Reviewed by Anders Carlsson and Beth Dakin.
804
805         https://bugs.webkit.org/show_bug.cgi?id=31070
806
807         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
808         destroyed, it executes the value of the 'ondestroy' parameter as a
809         script.
810
811         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
812         (pluginAllocate): Initialize onDestroy.
813         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
814         onDestroy.
815         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
816         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
817         specified.
818         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
819
820 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
821
822         Reviewed by Xan Lopez.
823
824         https://bugs.webkit.org/show_bug.cgi?id=31035
825         [GTK] some accessibility tests hitting assertion in debug builds
826
827         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
828
829         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
830         (AccessibilityController::rootElement):
831
832 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
833
834         Reviewed by Beth Dakin.
835
836         Support ARIA "tab" roles
837         https://bugs.webkit.org/show_bug.cgi?id=30842
838
839         * DumpRenderTree/AccessibilityUIElement.cpp:
840         * DumpRenderTree/AccessibilityUIElement.h:
841         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
842         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
843         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
844
845 2009-11-01  Eric Seidel  <eric@webkit.org>
846
847         Reviewed by David Levin.
848
849         buildbots should use --exit-after-N-failures
850         https://bugs.webkit.org/show_bug.cgi?id=30809
851
852         Make the bots exit after 20 failures to prevent never-ending
853         test runs where every test spends a minute crashing.
854
855         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
856
857 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
858
859         Reviewed by Eric Seidel.
860
861         Turn on warnings for QtWebKit for gcc
862         https://bugs.webkit.org/show_bug.cgi?id=30958
863
864         * DumpRenderTree/qt/main.cpp: 
865         (crashHandler): Mark function NO_RETURN
866
867 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
868
869         Adding myself to the committers list.
870
871         * Scripts/modules/committers.py:
872
873 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
874
875         Fix an issue that Adam noticed in DRT.
876
877         Reviewed by Darin Adler.
878
879         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
880         (AccessibilityUIElement::role):
881         Get the length of the role text, and create a buffer dynamically.
882
883 2009-10-30  Eric Seidel  <eric@webkit.org>
884
885         No review, rolling out r50105.
886         http://trac.webkit.org/changeset/50105
887
888         This commit was causing:
889         https://bugs.webkit.org/show_bug.cgi?id=30869
890         We'll re-implement the feature a different way.
891
892         * Scripts/bugzilla-tool:
893
894 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
895
896         Test for MSAA: Accessibility of headings is not correct
897
898         https://bugs.webkit.org/show_bug.cgi?id=30937
899
900         Reviewed by Adam Roben.
901
902         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
903         (AccessibilityUIElement::role):
904         Allow the role returned to be a BSTR.
905         (AccessibilityUIElement::description):
906         Fix a copy/paste error.
907
908 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
909
910         Test for MSAA: Accessibility of links is wrong
911
912         https://bugs.webkit.org/show_bug.cgi?id=30928
913
914         Reviewed by Darin Adler.
915
916         * DumpRenderTree/AccessibilityUIElement.cpp:
917         (getAccessibilityValueCallback):
918         Return the accessibility value.
919         (AccessibilityUIElement::getJSClass):
920         Added "accessibilityValue" value.
921
922         * DumpRenderTree/AccessibilityUIElement.h:
923
924         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
925         (AccessibilityUIElement::accessibilityValue):
926         Stubbed.
927
928         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
929         (AccessibilityUIElement::accessibilityValue):
930         Stubbed.
931
932         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
933         (AccessibilityUIElement::accessibilityValue):
934         Get the object's value, and return it as a JS string.
935
936 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
937
938         Fix typo in command name used by wx build system.
939
940         * wx/build/build_utils.py:
941
942 2009-10-30  Adam Barth  <abarth@webkit.org>
943
944         Reviewed by Darin Adler.
945
946         Patch v1 is a dumb default name for patches
947         https://bugs.webkit.org/show_bug.cgi?id=30952
948
949         Let's use "Patch" instead.
950
951         * Scripts/bugzilla-tool:
952
953 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
954
955         Unreviewed trivial buildfix.
956
957         [Qt] Buildfix for r50333.
958
959         * DumpRenderTree/qt/DumpRenderTree.pro:
960
961 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
962
963         Reviewed by Holger Freyther.
964
965         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
966         https://bugs.webkit.org/show_bug.cgi?id=30953
967
968         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
969         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
970         makes qt DRT to share this implementation (as gtk and mac ports do).
971
972         * DumpRenderTree/qt/DumpRenderTree.pro:
973         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
974         * DumpRenderTree/qt/WorkQueue.h: Removed.
975
976 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
977
978         Unreviewed potential buildbot fix.
979
980         Second try: Reset page history before running each test.
981
982         Apparently the QWebHistory::clear() keeps the current page
983         in history which is not what we want, so we not additionally
984         sets the history capacity to 0 (forces removing everything)
985         and then sets it back to its original value.
986
987         * DumpRenderTree/qt/DumpRenderTree.cpp:
988         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
989
990 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
991
992         Unreviewed potential buildbot fix.
993
994         Reset page history before running each test.
995
996         * DumpRenderTree/qt/DumpRenderTree.cpp:
997         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
998
999 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
1000
1001         Reviewed by Eric Seidel.
1002
1003         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
1004
1005         Bug 28420 -  Implement HTML5 <ruby> rendering
1006         (https://bugs.webkit.org/show_bug.cgi?id=28420)
1007
1008         No new tests (no functional change).
1009
1010         * Scripts/build-webkit:
1011
1012 2009-10-29  Dan Bernstein  <mitz@apple.com>
1013
1014         Reviewed by Mark Rowe.
1015
1016         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
1017         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
1018         define it.
1019
1020         * Scripts/VCSUtils.pm:
1021         * Scripts/svn-apply:
1022         * Scripts/svn-unapply:
1023
1024 2009-10-29  Xan Lopez  <xlopez@igalia.com>
1025
1026         Reviewed by Gustavo Noronha.
1027
1028         Use the GTK+ main loop instead of rolling our own mini-version of
1029         it.
1030
1031         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1032         (dump):
1033         (runTest):
1034         (webViewLoadFinished):
1035
1036 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1037
1038         Reviewed by Oliver Hunt.
1039
1040         Implement the Qt version of DRT dumpBackForwardList().
1041
1042         * DumpRenderTree/qt/DumpRenderTree.cpp:
1043         (WebCore::dumpHistoryItem):
1044         (WebCore::DumpRenderTree::dumpBackForwardList):
1045
1046 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1047
1048         Reviewed by Adam Roben.
1049
1050         Implement DRT functionality for Qt introduced in
1051         r28690 and r28705.
1052
1053         - Implemented pathToLocalResource which exposes the functionality of
1054         converting a given unix path to the correct location on Windows.
1055         - Implemented a way to remove machine-dependent information from paths
1056         in layout test results.
1057
1058         * DumpRenderTree/qt/DumpRenderTree.cpp:
1059         (WebCore::urlSuitableForTestResult):
1060         (WebCore::WebPage::javaScriptConsoleMessage):
1061         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1062         (LayoutTestController::pathToLocalResource):
1063         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1064
1065 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
1066
1067         Adding myself to the committers list.
1068
1069         * Scripts/modules/committers.py:
1070
1071 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
1072
1073         Adding myself to the committers list.
1074
1075         * Scripts/modules/committers.py:
1076
1077 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1078
1079         Reviewed by Jan Alonzo.
1080
1081         [GTK] API to start inspector for a WebView
1082         https://bugs.webkit.org/show_bug.cgi?id=22551
1083
1084         Use the new inspector API to implement the LayoutTestController
1085         interfaces used to test the inspector.
1086
1087         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1088         (webInspectorInspectWebView):
1089         (createWebView):
1090         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1091         (LayoutTestController::showWebInspector):
1092         (LayoutTestController::closeWebInspector):
1093         (LayoutTestController::evaluateInWebInspector):
1094
1095 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
1096
1097         Reviewed by Eric Seidel.
1098
1099         [Qt] WebFrame::counterValueForElementById must not be exposed
1100         https://bugs.webkit.org/show_bug.cgi?id=30882
1101
1102         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1103         (LayoutTestController::counterValueForElementById):
1104
1105 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1106
1107         Rubberstamped by Oliver Hunt.
1108
1109         Fix the warning:
1110
1111         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
1112         declared with attribute warn_unused_result".
1113
1114         by actually checking the result. In the case it is null, an
1115         error has occoured, so treat it as the other fatal errors.
1116
1117         * DumpRenderTree/qt/DumpRenderTree.cpp:
1118         (WebCore::DumpRenderTree::initializeFonts):
1119
1120 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
1121
1122         Reviewed by Darin Adler.
1123
1124         Provide a way to get counter values with layoutTestContoller
1125         https://bugs.webkit.org/show_bug.cgi?id=30555
1126
1127         Define layoutTestContoller.counterValueForElementById.
1128
1129         * DumpRenderTree/LayoutTestController.cpp:
1130         (counterValueForElementByIdCallback):
1131         (LayoutTestController::staticFunctions):
1132         * DumpRenderTree/LayoutTestController.h:
1133         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1134         (LayoutTestController::counterValueForElementById):
1135
1136 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1137
1138         Rubberstamped by Oliver Hunt.
1139
1140         Change two methods to be internal for DRT use only.
1141
1142         Part of [Qt] Review all new API in Qt 4.6
1143         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
1144
1145         * DumpRenderTree/qt/DumpRenderTree.cpp:
1146         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1147         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1148         (LayoutTestController::whiteListAccessFromOrigin):
1149
1150 2009-10-27  Eric Seidel  <eric@webkit.org>
1151
1152         Reviewed by Adam Barth.
1153
1154         REGRESSION: svn-apply exits(1) when applying a patch with a file add
1155         https://bugs.webkit.org/show_bug.cgi?id=30826
1156
1157         * Scripts/svn-apply:
1158          - Add () around all system() calls.
1159          - Use the correct system() == 0 or die instead of system() or die
1160          - Add descriptive messages to all die statements.
1161
1162 2009-10-27  Steve Block  <steveblock@google.com>
1163
1164         Reviewed by NOBODY.
1165
1166         Adds steveblock@google.com to list of committers.
1167
1168         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
1169
1170 2009-10-27  Eric Seidel  <eric@webkit.org>
1171
1172         Reviewed by Adam Barth.
1173
1174         svn-apply can exit(0) even on patch failure
1175         https://bugs.webkit.org/show_bug.cgi?id=29622
1176
1177         * Scripts/svn-apply:
1178          - Add a bunch of "or die" statements, hopefully catching all
1179            possible cases where failure could still exit(0).
1180
1181 2009-10-27  Eric Seidel  <eric@webkit.org>
1182
1183         Reviewed by Adam Barth.
1184
1185         svn-* scripts should share code through VCSUtils.pm
1186         https://bugs.webkit.org/show_bug.cgi?id=30791
1187
1188         Just moving code into a shared location.
1189
1190         * Scripts/VCSUtils.pm:
1191         * Scripts/prepare-ChangeLog:
1192         * Scripts/resolve-ChangeLogs:
1193         * Scripts/svn-apply:
1194         * Scripts/svn-create-patch:
1195         * Scripts/svn-unapply:
1196         * Scripts/update-webkit:
1197
1198 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
1199
1200         Suppress a huge number of MSVC warnings when building wxWebKit.
1201
1202         * wx/build/settings.py:
1203
1204 2009-10-26  Eric Seidel  <eric@webkit.org>
1205
1206         No review, just adding Mike Belshe to the committers list.
1207
1208         * Scripts/modules/committers.py:
1209
1210 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1211
1212         Reviewed by Darin Adler.
1213
1214         Make .rc files compile on Windows without depending on MFC headers
1215         https://bugs.webkit.org/show_bug.cgi?id=30750
1216
1217         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
1218         windows.h instead of afxres.h because it exists even when MFC is not 
1219         installed, and is all that's needed here.
1220
1221         * FindSafari/FindSafari.rc: Ditto
1222
1223 2009-10-24  Eric Seidel  <eric@webkit.org>
1224
1225         Reviewed by Adam Barth.
1226
1227         bugzilla-tool post-diff should know how to mark commit-queue=?
1228         https://bugs.webkit.org/show_bug.cgi?id=29202
1229
1230         * Scripts/bugzilla-tool:
1231          - Add --commit-queue option to post-diff, post-commits and create-bug.
1232         * Scripts/modules/bugzilla.py:
1233          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
1234          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
1235
1236 2009-10-23  Eric Seidel  <eric@webkit.org>
1237
1238         Reviewed by Adam Barth.
1239
1240         bugzilla-tool commit-queue does not notice modifications to committers.py
1241         https://bugs.webkit.org/show_bug.cgi?id=30084
1242
1243         * Scripts/bugzilla-tool:
1244          - Make commit-queue re-exec itself instead of using while(1).
1245          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
1246          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
1247
1248 2009-10-22  Eric Seidel  <eric@webkit.org>
1249
1250         Reviewed by Adam Barth.
1251
1252         commit-queue will get stuck on patches if land-patches terminates unexpectedly
1253         https://bugs.webkit.org/show_bug.cgi?id=30634
1254
1255         * Scripts/bugzilla-tool:
1256          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
1257          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
1258
1259 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
1260
1261         Reviewed by Eric Seidel.
1262
1263         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
1264
1265         https://bugs.webkit.org/show_bug.cgi?id=30763
1266
1267         * pywebsocket/mod_pywebsocket/__init__.py:
1268         * pywebsocket/mod_pywebsocket/dispatch.py:
1269         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
1270         * pywebsocket/mod_pywebsocket/standalone.py:
1271         * pywebsocket/setup.py:
1272         * pywebsocket/test/test_dispatch.py:
1273
1274 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
1275
1276         Reviewed by David Levin.
1277
1278         REGRESSION: 2 failures in run-webkit-unittests
1279         https://bugs.webkit.org/show_bug.cgi?id=30645
1280
1281         * Scripts/modules/cpp_style_unittest.py:
1282         Fixed a few test scenarios which apparently lost some spaces from 
1283         text literals.
1284
1285 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
1286
1287         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
1288
1289         * Scripts/webkitdirs.pm:
1290
1291 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
1292
1293         Reviewed by Darin Adler.
1294
1295         Unification of using null device in perl scripts.
1296         https://bugs.webkit.org/show_bug.cgi?id=30572
1297
1298         * Scripts/VCSUtils.pm:
1299         * Scripts/bisect-builds:
1300         * Scripts/resolve-ChangeLogs:
1301         * Scripts/run-iexploder-tests:
1302         * Scripts/run-jsc:
1303         * Scripts/run-mangleme-tests:
1304         * Scripts/run-webkit-tests:
1305         * Scripts/webkitdirs.pm:
1306         Using File::Spec->devnull() instead of hard coded /dev/null.
1307
1308 2009-10-26  Eric Seidel  <eric@webkit.org>
1309
1310         Reviewed by Holger Freyther.
1311
1312         Reviewers are missing from committers.py
1313         https://bugs.webkit.org/show_bug.cgi?id=30733
1314
1315         * Scripts/modules/committers.py:
1316
1317 2009-10-23  Eric Seidel  <eric@webkit.org>
1318
1319         No review, only adding Alice to the list of reviewers.
1320
1321         * Scripts/modules/committers.py:
1322
1323 2009-10-23  Eric Seidel  <eric@webkit.org>
1324
1325         Reviewed by Eric Carlson.
1326
1327         fast/media/mq-transform-02.html failed on Leopard Commit Bot
1328         https://bugs.webkit.org/show_bug.cgi?id=30700
1329
1330         * DumpRenderTree/mac/DumpRenderTree.mm:
1331         (resetDefaultsToConsistentValues): Update QuickTime version check.
1332
1333 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
1334
1335         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
1336         character measurement APIs that are private on Tiger.
1337
1338         * wx/build/settings.py:
1339
1340 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
1341
1342         Reviewed by NOBODY (build fix).
1343         Build fix following bug #30696.
1344
1345         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1346         (LayoutTestController::evaluateScriptInIsolatedWorld):
1347
1348 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
1349
1350         Reviewed by Sam Weinig & Geoff Garen.
1351
1352         https://bugs.webkit.org/show_bug.cgi?id=30696
1353         Enable isolated-worlds tests on mac.
1354
1355         Add private interface for DRT to invoke execution in a given world.
1356
1357         * DumpRenderTree/LayoutTestController.cpp:
1358         (evaluateScriptInIsolatedWorldCallback):
1359         (LayoutTestController::staticFunctions):
1360         * DumpRenderTree/LayoutTestController.h:
1361         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1362         (LayoutTestController::evaluateScriptInIsolatedWorld):
1363         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1364         (LayoutTestController::evaluateScriptInIsolatedWorld):
1365
1366 2009-10-21  Eric Seidel  <eric@webkit.org>
1367
1368         Reviewed by Adam Barth.
1369
1370         bugzilla-tool's "patch failed to download an apply" error should give more information
1371         https://bugs.webkit.org/show_bug.cgi?id=30632
1372
1373         * Scripts/modules/scm.py:
1374          - Use the common run_command method instead of custom POpen code.
1375          - Make run_command know how to take pipes as input.
1376         * Scripts/modules/scm_unittest.py:
1377          - Add new tests to cover change.
1378          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
1379
1380 2009-10-21  Kent Tamura  <tkent@chromium.org>
1381
1382         Unreviewed.  Adding myself to the committers list.
1383
1384         * Scripts/modules/committers.py:
1385
1386 2009-10-21  Robin Dunn  <robin@alldunn.com>
1387
1388         Reviewed by Kevin Ollivier.
1389
1390         Update the Windows installer builder to work with Vista / Win 7 and with git.
1391         
1392         https://bugs.webkit.org/show_bug.cgi?id=30649
1393
1394         * wx/build/build_utils.py:
1395         * wx/packaging/build-mac-installer.py:
1396         * wx/packaging/build-win-installer.py:
1397         * wx/packaging/wxWebKitInstaller.iss.in:
1398
1399 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
1400
1401         Reviewed by Gustavo Noronha.
1402
1403         [GTK] Added conditional code to avoid using
1404         gdk_window_get_root_coords if we do not have a gtk+ release newer
1405         than 2.17.3.
1406         https://bugs.webkit.org/show_bug.cgi?id=30636
1407
1408         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1409
1410 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
1411
1412         Reviewed by Eric Seidel.
1413
1414         [Qt] Added dummy implementation for keepWebHistory()
1415         https://bugs.webkit.org/show_bug.cgi?id=30592
1416
1417         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1418         (LayoutTestController::keepWebHistory):
1419         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1420
1421 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
1422
1423         Reviewed by Xan Lopez.
1424
1425         [GTK] Fixed the double click condition, it is not double click if
1426         we move in just in one direction.
1427         https://bugs.webkit.org/show_bug.cgi?id=30636
1428
1429         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1430
1431 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
1432
1433         Reviewed by Xan Lopez.
1434
1435         [GTK] Initialize the events completly before emitting them.
1436         https://bugs.webkit.org/show_bug.cgi?id=30633
1437
1438         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1439
1440 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
1441
1442         wx build fix. Fix for when linking using --as-needed with gcc.
1443
1444         * wx/browser/wscript:
1445
1446 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
1447
1448         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
1449         to support all the features used by CURL backend.
1450         
1451         * wx/build/settings.py:
1452         * wx/install-unix-extras:
1453
1454 2009-10-20  Anton Muhin  <antonm@chromium.org>
1455
1456         Reviewed by Adam Barth.
1457
1458         Add {ager,antonm,yurys}@chromium.org into committers.py
1459         https://bugs.webkit.org/show_bug.cgi?id=30560
1460
1461         * Scripts/modules/committers.py:
1462
1463 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1464
1465         Reviewed by Tor Arne Vestbø.
1466
1467         Make the Netscape Test plugin available to the Qt launcher.
1468
1469         * Scripts/run-launcher:
1470
1471 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
1472
1473         Reviewed by David Levin.
1474
1475         Removed WebSocket runtime settings.
1476         https://bugs.webkit.org/show_bug.cgi?id=29896
1477
1478         WebSocket runtime configuration is supported by chromium/v8 only.
1479
1480         * DumpRenderTree/mac/DumpRenderTree.mm:
1481         (resetDefaultsToConsistentValues):
1482         * DumpRenderTree/win/DumpRenderTree.cpp:
1483         (resetDefaultsToConsistentValues):
1484
1485 2009-10-19  Nate Chapin  <japhet@chromium.org>
1486
1487         Reviewed by Adam Barth.
1488
1489         Add testFail() to test plugin so we can test our handling of a
1490         plugin invoke call returning false.
1491
1492         https://bugs.webkit.org/show_bug.cgi?id=30239
1493
1494         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
1495         (pluginInvoke):
1496         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
1497
1498 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
1499
1500         Reviewed by Gustavo Noronha.
1501
1502         Enable DOM pasting when running layout tests.
1503
1504         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1505         (resetDefaultsToConsistentValues):
1506
1507 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1508
1509         Reviewed by Simon Hausmann.
1510
1511         Use the setPreferredContentsSize method instead
1512         of setFixedContentsSize, as the method has been renamed.
1513
1514         * DumpRenderTree/qt/DumpRenderTree.cpp:
1515         (WebCore::DumpRenderTree::open):
1516         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1517         (LayoutTestController::setFixedContentsSize):
1518
1519 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
1520
1521         Reviewed by Dan Bernstein.
1522
1523         https://bugs.webkit.org/show_bug.cgi?id=30456
1524         Fixes for new Debug_All Windows build configuration.
1525
1526         * DumpRenderTree/win/DumpRenderTree.cpp:
1527         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
1528         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
1529
1530 2009-10-16  Eric Seidel  <eric@webkit.org>
1531
1532         Reviewed by Adam Barth.
1533
1534         commit-queue status bot should list which buildbot is blocking the queue
1535         https://bugs.webkit.org/show_bug.cgi?id=30452
1536
1537         Add new methods and testing.
1538
1539         * Scripts/bugzilla-tool:
1540         * Scripts/modules/buildbot.py:
1541         * Scripts/modules/buildbot_unittest.py:
1542
1543 2009-10-16  Eric Seidel  <eric@webkit.org>
1544
1545         Reviewed by Adam Barth.
1546
1547         run-webkit-tests fails when CWD is not inside a WebKit checkout
1548         https://bugs.webkit.org/show_bug.cgi?id=30451
1549
1550         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
1551         * Scripts/modules/scm_unittest.py:
1552           - Remove use of original_path (we don't need to restore the CWD).
1553           - Don't use '.' to find the webkit checkout, use __file__ instead.
1554
1555 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
1556
1557         Reviewed by Adam Roben.
1558
1559         Add a Debug_All configuration to build entire stack as debug.
1560         Change Debug_Internal to:
1561         - stop using _debug suffix for all WebKit/Safari binaries
1562         - not use _debug as a DLL naming suffix
1563         - use non-debug C runtime lib.
1564
1565         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
1566         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
1567         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
1568         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1569         Add missing debug.vsprops inherited property sheet.
1570         Add Debug_All configuration.
1571         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
1572         * WinLauncher/WinLauncher.vcproj:
1573         Removed extraneous definitions inherited from vsprops.
1574         Add Debug_All configuration.
1575
1576 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
1577
1578         Reviewed by David Levin.
1579
1580         check-webkit-style is wrong about indent checking in namespaces
1581         in header files and a few other things
1582         https://bugs.webkit.org/show_bug.cgi?id=30362
1583
1584         The few other things include:
1585         + check-webkit-style does not require spaces around the equal sign
1586           inside 'if' statements and around binary operators that take 
1587           numeric literals.
1588         + check-webkit-style reports false errors for the / operator
1589           when part of a filename in the #include directive.
1590
1591         * Scripts/modules/cpp_style.py:
1592         Improved indentation checking and space checking around
1593         binary operators. While the checks are still not perfect,
1594         they are clearly better than before.
1595         * Scripts/modules/cpp_style_unittest.py:
1596         Added test cases for the newly supported checks and modified old
1597         test cases to match the new guidelines
1598
1599 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
1600
1601         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
1602
1603         * wx/build/settings.py:
1604
1605 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
1606
1607         Reviewed by David Levin.
1608
1609         Add mod_pywebsocket to test Web Sockets.
1610         http://code.google.com/p/pywebsocket/
1611         https://bugs.webkit.org/show_bug.cgi?id=27490
1612
1613         * pywebsocket/COPYING: Added.
1614         * pywebsocket/MANIFEST.in: Added.
1615         * pywebsocket/README: Added.
1616         * pywebsocket/example/echo_client.py: Added.
1617         * pywebsocket/example/echo_wsh.py: Added.
1618         * pywebsocket/mod_pywebsocket/__init__.py: Added.
1619         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
1620         * pywebsocket/mod_pywebsocket/handshake.py: Added.
1621         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
1622         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
1623         * pywebsocket/mod_pywebsocket/standalone.py: Added.
1624         * pywebsocket/mod_pywebsocket/util.py: Added.
1625         * pywebsocket/setup.py: Added.
1626         * pywebsocket/test/config.py: Added.
1627         * pywebsocket/test/mock.py: Added.
1628         * pywebsocket/test/run_all.py: Added.
1629         * pywebsocket/test/test_dispatch.py: Added.
1630         * pywebsocket/test/test_handshake.py: Added.
1631         * pywebsocket/test/test_mock.py: Added.
1632         * pywebsocket/test/test_msgutil.py: Added.
1633         * pywebsocket/test/test_util.py: Added.
1634         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
1635         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
1636         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
1637         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
1638         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
1639         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
1640         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
1641         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
1642
1643 2009-10-15  James Robinson  <jamesr@google.com>
1644
1645         Reviewed by David Levin.
1646
1647         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
1648
1649         https://bugs.webkit.org/show_bug.cgi?id=30426
1650
1651         * Scripts/modules/cpp_style.py:
1652         * Scripts/modules/cpp_style_unittest.py:
1653
1654 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
1655
1656         Reviewed by Adam Roben.
1657
1658         Fixes <http://webkit.org/b/30411>.
1659         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
1660         
1661         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
1662         building Chromium.
1663
1664         * Scripts/pdevenv:
1665
1666 2009-10-15  Robin Dunn  <robin@alldunn.com>
1667
1668         Reviewed by Kevin Ollivier.
1669
1670         Add Mac package building scripts for wx.
1671         
1672         https://bugs.webkit.org/show_bug.cgi?id=30405
1673
1674         * wx/build/build_utils.py:
1675         * wx/build/settings.py:
1676         * wx/packaging/build-mac-installer.py: Added.
1677
1678 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
1679
1680         Reviewed by Gustavo Noronha.
1681
1682         Enable Web Sockets support when running layout tests.
1683
1684         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1685         (resetDefaultsToConsistentValues):
1686
1687 2009-10-15  Xan Lopez  <xlopez@igalia.com>
1688
1689         Reviewed by Gustavo Noronha.
1690
1691         Need to initialize event.button.button, since in most cases a
1692         button number is not passed as an argument.
1693
1694         * DumpRenderTree/gtk/EventSender.cpp:
1695         (mouseDownCallback):
1696         (mouseUpCallback):
1697
1698 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
1699
1700         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
1701         the OS if none was explicitly set.
1702
1703         * wx/build/settings.py:
1704
1705 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
1706
1707         Reviewed by Timothy Hatcher.
1708
1709         Web Inspector: enable developers extras within inspector layout tests.
1710
1711         https://bugs.webkit.org/show_bug.cgi?id=30014
1712
1713         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1714         (LayoutTestController::showWebInspector):
1715         (LayoutTestController::closeWebInspector):
1716         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1717         (LayoutTestController::showWebInspector):
1718         (LayoutTestController::closeWebInspector):
1719
1720 2009-10-14  José Millán Soto  <jmillan@igalia.com>
1721
1722         Reviewed by Jan Alonzo.
1723
1724         GtkLauncher is using a deprecated signal
1725         https://bugs.webkit.org/show_bug.cgi?id=30364
1726
1727         Modified GtkLauncher to use notify::title signal instead of
1728         deprecated title-changed signal
1729
1730         * GtkLauncher/main.c:
1731         (notify_title_cb):
1732         (create_browser):
1733
1734 2009-10-14  Brady Eidson  <beidson@apple.com>
1735
1736         Reviewed by Sam Weinig.
1737
1738         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
1739         1 - Disables WebHistory
1740         2 - Doesn't make sense in that context anyway.
1741
1742         * DumpRenderTree/win/DumpRenderTree.cpp:
1743         (createWebViewAndOffscreenWindow):
1744
1745 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
1746
1747         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
1748         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
1749
1750         * wx/build/settings.py:
1751         * wx/install-unix-extras:
1752
1753 2009-10-14  Brady Eidson  <beidson@apple.com>
1754
1755         Reviewed by Sam Weinig.
1756
1757         WebKit Win API should provide a delegate interface for global history.
1758         https://bugs.webkit.org/show_bug.cgi?id=29905
1759
1760         * DumpRenderTree/LayoutTestController.cpp:
1761         (LayoutTestController::LayoutTestController):
1762         * DumpRenderTree/LayoutTestController.h:
1763         (LayoutTestController::dumpHistoryDelegateCallbacks):
1764         (LayoutTestController::setDumpHistoryDelegateCallbacks):
1765                 
1766         * DumpRenderTree/win/DumpRenderTree.cpp:
1767         (shouldLogHistoryDelegates):
1768         (runTest):
1769         (createWebViewAndOffscreenWindow):
1770         (main):
1771         * DumpRenderTree/win/DumpRenderTree.vcproj:
1772         
1773         Add the IWebHistoryDelegate to DRT Windows:
1774         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
1775         (wstringFromBSTR):
1776         (HistoryDelegate::HistoryDelegate):
1777         (HistoryDelegate::~HistoryDelegate):
1778         (HistoryDelegate::QueryInterface):
1779         (HistoryDelegate::AddRef):
1780         (HistoryDelegate::Release):
1781         (HistoryDelegate::didNavigateWithNavigationData):
1782         (HistoryDelegate::didPerformClientRedirectFromURL):
1783         (HistoryDelegate::didPerformServerRedirectFromURL):
1784         (HistoryDelegate::updateHistoryTitle):
1785         (HistoryDelegate::populateVisitedLinksForWebView):
1786         * DumpRenderTree/win/HistoryDelegate.h: Added.
1787
1788         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1789         (LayoutTestController::removeAllVisitedLinks):
1790
1791 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
1792
1793         Reviewed by Simon Hausmann.
1794
1795         [Qt] Implement support for setPOSIXLocale on Qt.
1796         https://bugs.webkit.org/show_bug.cgi?id=30268 
1797  
1798         * DumpRenderTree/qt/DumpRenderTree.cpp:
1799         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1800         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1801         (LayoutTestController::setPOSIXLocale):
1802         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1803
1804 2009-10-13  Stephanie Lewis  <slewis@apple.com>
1805
1806         Unreviewed, adding myself to reviewers list.
1807
1808         * Scripts/modules/committers.py:
1809
1810 2009-10-13  Stephanie Lewis  <slewis@apple.com>
1811
1812         Reviewed by Mark Rowe.
1813
1814         Fix null assignment so root tests work again.
1815
1816         * Scripts/webkitdirs.pm:
1817
1818 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1819
1820         Reviewed by Simon Hausmann.
1821
1822         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
1823         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
1824         This is done in preparation of implementing missing features in DRT.
1825         No functionality changes made yet.
1826
1827         * DumpRenderTree/qt/DumpRenderTree.cpp:
1828         * DumpRenderTree/qt/DumpRenderTree.pro:
1829         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
1830         (EventSender::EventSender):
1831         (EventSender::mouseDown):
1832         (EventSender::mouseUp):
1833         (EventSender::mouseMoveTo):
1834         (EventSender::leapForward):
1835         (EventSender::keyDown):
1836         (EventSender::contextClick):
1837         (EventSender::scheduleAsynchronousClick):
1838         (EventSender::frameUnderMouse):
1839         * DumpRenderTree/qt/EventSenderQt.h: Added.
1840         (EventSender::clearKillRing):
1841         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
1842         (LayoutTestController::LayoutTestController):
1843         (LayoutTestController::reset):
1844         (LayoutTestController::processWork):
1845         (LayoutTestController::maybeDump):
1846         (LayoutTestController::waitUntilDone):
1847         (LayoutTestController::notifyDone):
1848         (LayoutTestController::windowCount):
1849         (LayoutTestController::clearBackForwardList):
1850         (LayoutTestController::dumpEditingCallbacks):
1851         (LayoutTestController::dumpResourceLoadCallbacks):
1852         (LayoutTestController::queueBackNavigation):
1853         (LayoutTestController::queueForwardNavigation):
1854         (LayoutTestController::queueLoad):
1855         (LayoutTestController::queueReload):
1856         (LayoutTestController::queueScript):
1857         (LayoutTestController::provisionalLoad):
1858         (LayoutTestController::timerEvent):
1859         (LayoutTestController::encodeHostName):
1860         (LayoutTestController::decodeHostName):
1861         (LayoutTestController::setJavaScriptProfilingEnabled):
1862         (LayoutTestController::setFixedContentsSize):
1863         (LayoutTestController::setPrivateBrowsingEnabled):
1864         (LayoutTestController::setPopupBlockingEnabled):
1865         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1866         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1867         (LayoutTestController::numberOfActiveAnimations):
1868         (LayoutTestController::disableImageLoading):
1869         (LayoutTestController::dispatchPendingLoadRequests):
1870         (LayoutTestController::setDatabaseQuota):
1871         (LayoutTestController::clearAllDatabases):
1872         (LayoutTestController::whiteListAccessFromOrigin):
1873         (LayoutTestController::waitForPolicyDelegate):
1874         (LayoutTestController::overridePreference):
1875         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
1876         (LayoutTestController::isLoading):
1877         (LayoutTestController::setLoading):
1878         (LayoutTestController::shouldDumpAsText):
1879         (LayoutTestController::shouldDumpBackForwardList):
1880         (LayoutTestController::shouldDumpChildrenAsText):
1881         (LayoutTestController::shouldDumpDatabaseCallbacks):
1882         (LayoutTestController::shouldDumpStatusCallbacks):
1883         (LayoutTestController::shouldWaitUntilDone):
1884         (LayoutTestController::canOpenWindows):
1885         (LayoutTestController::shouldDumpTitleChanges):
1886         (LayoutTestController::waitForPolicy):
1887         (LayoutTestController::dumpAsText):
1888         (LayoutTestController::dumpChildFramesAsText):
1889         (LayoutTestController::dumpDatabaseCallbacks):
1890         (LayoutTestController::dumpStatusCallbacks):
1891         (LayoutTestController::setCanOpenWindows):
1892         (LayoutTestController::dumpBackForwardList):
1893         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
1894         (LayoutTestController::display):
1895         (LayoutTestController::dumpTitleChanges):
1896         (LayoutTestController::dumpSelectionRect):
1897         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
1898         (TextInputController::TextInputController):
1899         (TextInputController::doCommand):
1900         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
1901         * DumpRenderTree/qt/WorkQueue.cpp:
1902         * DumpRenderTree/qt/WorkQueue.h:
1903         * DumpRenderTree/qt/WorkQueueItem.h:
1904         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
1905         (findFrameNamed):
1906         (LoadItem::invoke):
1907         (ReloadItem::invoke):
1908         (ScriptItem::invoke):
1909         (BackForwardItem::invoke):
1910         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
1911         * DumpRenderTree/qt/jsobjects.h:
1912
1913 2009-10-13  Dmitry Titov  <dimich@chromium.org>
1914
1915         Not reviewed, adding myself to the list of reviewers.
1916
1917         * Scripts/modules/committers.py:
1918
1919 2009-10-13  Anders Carlsson  <andersca@apple.com>
1920
1921         Reviewed by Sam Weinig.
1922
1923         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
1924
1925         Make the private browsing mode testable by the test plug-in.
1926         
1927         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1928         (pluginGetProperty):
1929         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1930         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1931         (NPP_New):
1932         (NPP_SetValue):
1933
1934 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
1935
1936         No review, just adding self to the list of reviewers.
1937
1938         * Scripts/modules/committers.py:
1939
1940 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
1941
1942         Reviewed by Adam Roben.
1943
1944         Web Inspector: Use proper web view in inspector layout
1945         tests for windows.
1946
1947         https://bugs.webkit.org/show_bug.cgi?id=30298
1948
1949         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1950         (LayoutTestController::showWebInspector):
1951         (LayoutTestController::closeWebInspector):
1952         (LayoutTestController::evaluateInWebInspector):
1953
1954 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
1955
1956         Reviewed by Sam Weinig.
1957
1958         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
1959         https://bugs.webkit.org/show_bug.cgi?id=29841
1960
1961         * DumpRenderTree/mac/DumpRenderTree.mm:
1962         (resetDefaultsToConsistentValues):
1963         * DumpRenderTree/win/DumpRenderTree.cpp:
1964         (resetDefaultsToConsistentValues):
1965
1966 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
1967
1968         Reviewed by Dimitri Glazkov.
1969
1970         Chromium Port - Windows
1971         https://bugs.webkit.org/show_bug.cgi?id=29969
1972
1973         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
1974         * Scripts/webkitdirs.pm:
1975
1976 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
1977
1978         Reviewed by Darin Adler.
1979
1980         jsc scripts cleanup and Qt/GTK fix
1981         https://bugs.webkit.org/show_bug.cgi?id=30288
1982
1983         Duplicated jscPath() moved to webkitdirs.pm.
1984         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
1985         Configuration added (release/debug) to path for Qt-port on Windows.
1986
1987         * Scripts/run-javascriptcore-tests:
1988         * Scripts/run-jsc:
1989         * Scripts/run-sunspider:
1990         * Scripts/sunspider-compare-results:
1991         * Scripts/webkitdirs.pm:
1992
1993 2009-10-11  Adam Barth  <abarth@webkit.org>
1994
1995         Unreviewed.  Add Collin to committers.py.
1996
1997         * Scripts/modules/committers.py:
1998
1999 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
2000
2001         wx build fix, add bindings to source/include dirs now that there are sources there.
2002
2003         * wx/build/settings.py:
2004
2005 2009-10-09  Mark Rowe  <mrowe@apple.com>
2006
2007         Reviewed by Brady Eidson.
2008
2009         Enable plug-in halting in DumpRenderTree.
2010
2011         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
2012         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
2013
2014         * DumpRenderTree/mac/DumpRenderTree.mm:
2015         (resetDefaultsToConsistentValues):
2016         * DumpRenderTree/mac/UIDelegate.mm:
2017         (-[UIDelegate webView:shouldHaltPlugin:]):
2018
2019 2009-10-08  Brady Eidson  <beidson@apple.com>
2020
2021         Reviewed by Dan Bernstein.
2022
2023         Ask the History Delegate to populate the visited links hash.
2024         <rdar://problem/7285293> and https://webkit.org/b/29904
2025
2026         Add the ability for LayoutTestController to clear all visited links.
2027         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
2028
2029         * DumpRenderTree/LayoutTestController.cpp:
2030         (LayoutTestController::LayoutTestController):
2031         (removeAllVisitedLinksCallback):
2032         (LayoutTestController::staticFunctions):
2033         * DumpRenderTree/LayoutTestController.h:
2034         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2035         (LayoutTestController::removeAllVisitedLinks):
2036
2037         * DumpRenderTree/mac/HistoryDelegate.mm:
2038         (-[HistoryDelegate populateVisitedLinksForWebView:]):
2039
2040         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2041         (LayoutTestController::removeAllVisitedLinks):
2042         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2043         (LayoutTestController::removeAllVisitedLinks):
2044         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2045         (LayoutTestController::removeAllVisitedLinks):
2046
2047
2048 2009-10-08  Daniel Bates  <dbates@webkit.org>
2049
2050         Reviewed by Adam Roben.
2051
2052         https://bugs.webkit.org/show_bug.cgi?id=30175
2053         
2054         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
2055         the OLE drag-and-drop return value like the function it emulates. Currently, 
2056         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
2057         whether the drag-and-drop operation was successful or was cancelled.
2058         
2059         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
2060         return value according to whether the drop operation was successful or not.
2061
2062         * DumpRenderTree/win/EventSender.cpp:
2063         (doMouseUp): Added parameter oleDragAndDropReturnValue.
2064         (replaySavedEvents): Ditto.
2065         * DumpRenderTree/win/EventSender.h:
2066         * DumpRenderTree/win/UIDelegate.cpp:
2067         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
2068
2069 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2070
2071         Reviewed by Xan Lopez.
2072
2073         [GTK] Added support for a parameter setting the button that was
2074         pressed in the mouseDown function.
2075         https://bugs.webkit.org/show_bug.cgi?id=30220
2076
2077         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2078
2079 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2080
2081         Reviewed by Xan Lopez.
2082
2083         [GTK] Added a line to the bottom of the expected result to match
2084         the output of the test.
2085         https://bugs.webkit.org/show_bug.cgi?id=30220
2086
2087         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
2088         expected.txt:
2089
2090 2009-10-08  Adam Roben  <aroben@apple.com>
2091
2092         Use QueryInterface to get IWebInspectorPrivate
2093
2094         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
2095         accessed in a more standard way
2096
2097         Reviewed by John Sullivan and Tim Hatcher.
2098
2099         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2100         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
2101         by calling IWebViewPrivate::inspector, then use QueryInterface to get
2102         to the IWebInspectorPrivate interface.
2103
2104 2009-10-07  Adam Roben  <aroben@apple.com>
2105
2106         Implement DRT support for origin whitelisting
2107
2108         Fixes <http://webkit.org/b/30185>.
2109
2110         Reviewed by Eric Seidel.
2111
2112         * DumpRenderTree/win/DumpRenderTree.cpp:
2113         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
2114         whitelist, to match Mac DRT.
2115         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2116         (LayoutTestController::whiteListAccessFromOrigin): Call through to
2117         IWebViewPrivate::whiteListAccessFromOrigin.
2118
2119 2009-10-07  Brady Eidson  <beidson@apple.com>
2120
2121         Reviewed by Darin Adler.
2122
2123         Send title changes to the global history delegate.
2124         <rdar://problem/7285293> and https://webkit.org/b/29904
2125
2126         * DumpRenderTree/mac/HistoryDelegate.mm:
2127         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
2128
2129 2009-10-07  Adam Barth  <abarth@webkit.org>
2130
2131         Unreviewed.  Remove some folks from committers.py who were listed on
2132         the WebKit Team wiki page but who weren't actually listed as commit+.
2133         At some point, we should coorelate this list with the committers
2134         mailing list.
2135
2136         * Scripts/modules/committers.py:
2137
2138 2009-10-07  Adam Barth  <abarth@webkit.org>
2139
2140         Unreviewed.  Import a bunch of committers from the WebKit Team page on
2141         the wiki into committers.py.
2142
2143         * Scripts/modules/committers.py:
2144
2145 2009-10-07  Adam Barth  <abarth@webkit.org>
2146
2147         Unreviewed.  Added Aaron Boodman to committers.py.
2148
2149         * Scripts/modules/committers.py:
2150
2151 2009-10-07  Evan Martin  <evan@chromium.org>
2152
2153         Reviewed by Darin Adler.
2154
2155         Add API to LayoutTestController for re/setting the system locale.
2156         https://bugs.webkit.org/show_bug.cgi?id=18994
2157
2158         * DumpRenderTree/LayoutTestController.cpp:
2159         (setLocaleCallback):
2160         (LayoutTestController::staticFunctions):
2161         (LayoutTestController::setLocale):
2162         * DumpRenderTree/LayoutTestController.h:
2163
2164 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
2165
2166         Reviewed by Jan Alonzo.
2167
2168         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
2169         https://bugs.webkit.org/show_bug.cgi?id=29689
2170
2171         Build fix by adding -lfontconfig for DumpRenderTree.
2172
2173         * GNUmakefile.am:
2174
2175 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2176
2177         Reviewed by Simon Hausmann.
2178
2179         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
2180
2181         * Scripts/run-webkit-tests:
2182
2183 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2184
2185         Reviewed by Gustavo Noronha.
2186
2187         "delete" in EventSender is the backspace key, not the delete one.
2188
2189         * DumpRenderTree/gtk/EventSender.cpp:
2190         (keyDownCallback):
2191
2192 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2193
2194         Reviewed by Gustavo Noronha.
2195
2196         getChildrenWithRange expects as last parameter the end index, not
2197         the length of the range. Correct this and clarify the variable
2198         names to reflect how the code works.
2199
2200         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2201         (AccessibilityUIElement::getChildrenWithRange):
2202         (AccessibilityUIElement::getChildAtIndex):
2203
2204 2009-10-06  Mark Rowe  <mrowe@apple.com>
2205
2206         Reviewed by Simon Fraser.
2207
2208         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
2209
2210         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
2211         the fact we have already changed the working directory to the top of the open source tree.
2212
2213 2009-10-06  Julie Parent  <jparent@chromium.org>
2214
2215         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
2216         rather than my committer email.
2217
2218         * Scripts/modules/committers.py:
2219
2220 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2221
2222         Reviewed by Eric Seidel.
2223
2224         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
2225
2226         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
2227         it after each layout test as it should do, making the DRT dump additional output
2228         for all of the subsequent layout tests.
2229
2230         * DumpRenderTree/qt/jsobjects.cpp:
2231         (LayoutTestController::reset):
2232
2233 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2234
2235         Reviewed by Simon Hausmann.
2236
2237         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
2238         fast/dom/assign-to-window-status.html test, which is passing as a result.
2239
2240         https://bugs.webkit.org/show_bug.cgi?id=30127
2241
2242         * DumpRenderTree/qt/DumpRenderTree.cpp:
2243         (WebCore::DumpRenderTree::DumpRenderTree):
2244         (WebCore::DumpRenderTree::statusBarMessage):
2245         * DumpRenderTree/qt/DumpRenderTree.h:
2246         * DumpRenderTree/qt/jsobjects.h:
2247         (LayoutTestController::shouldDumpStatusCallbacks):
2248         (LayoutTestController::dumpStatusCallbacks):
2249
2250 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2251
2252         Reviewed by Simon Hausmann.
2253
2254         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
2255         ignores the argument indicating which mouse button to trigger.
2256         https://bugs.webkit.org/show_bug.cgi?id=30048
2257
2258         This affects the fast/events/mouse-click-events.html layout test.
2259
2260         * DumpRenderTree/qt/jsobjects.cpp:
2261         (EventSender::mouseDown):
2262         (EventSender::mouseUp):
2263         * DumpRenderTree/qt/jsobjects.h:
2264
2265 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2266
2267         Reviewed by Simon Hausmann.
2268
2269         [Qt] Fix the EventSender::keyDown() implementation
2270         https://bugs.webkit.org/show_bug.cgi?id=30043
2271
2272         It should post both a key press event and a key release event,
2273         just like other ports do.
2274
2275         * DumpRenderTree/qt/jsobjects.cpp:
2276         (EventSender::keyDown):
2277
2278 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
2279
2280         wx build fix. Add jpeg to the list of libs to link against.
2281
2282         * wx/build/settings.py:
2283
2284 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
2285
2286         Reviewed by Simon Hausmann.
2287
2288         [Qt] EventSender::keyDown() cannot send function-key events.
2289         https://bugs.webkit.org/show_bug.cgi?id=30044
2290
2291         This affects the fast/events/keydown-function-keys.html layout test.
2292
2293         * DumpRenderTree/qt/jsobjects.cpp:
2294         (EventSender::keyDown):
2295
2296 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
2297
2298         Added --wx-compiler-prefix waf option to allow building wxWebKit with
2299         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
2300
2301         * wx/build/settings.py:
2302         * wx/build/wxpresets.py:
2303
2304 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
2305
2306         Reviewed by Timothy Hatcher.
2307
2308         Web Inspector: add testing harness for Web Inspector.
2309
2310         https://bugs.webkit.org/show_bug.cgi?id=30010
2311
2312         * DumpRenderTree/LayoutTestController.cpp:
2313         (showWebInspectorCallback):
2314         (closeWebInspectorCallback):
2315         (evaluateInWebInspectorCallback):
2316         (LayoutTestController::staticFunctions):
2317         * DumpRenderTree/LayoutTestController.h:
2318         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2319         (LayoutTestController::showWebInspector):
2320         (LayoutTestController::closeWebInspector):
2321         (LayoutTestController::evaluateInWebInspector):
2322         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2323         (LayoutTestController::showWebInspector):
2324         (LayoutTestController::closeWebInspector):
2325         (LayoutTestController::evaluateInWebInspector):
2326         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2327         (LayoutTestController::showWebInspector):
2328         (LayoutTestController::closeWebInspector):
2329         (LayoutTestController::evaluateInWebInspector):
2330         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2331         (LayoutTestController::showWebInspector):
2332         (LayoutTestController::closeWebInspector):
2333         (LayoutTestController::evaluateInWebInspector):
2334
2335 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2336
2337         Reviewed by Ariyha Hidayat.
2338
2339         Pass arguments to system() as a string instead of array
2340
2341         When passed as an array entries with a space fail to translate
2342         to two arguments to the child process, so instead of manually
2343         splitting all the entries in @buildArgs we pass the whole thing
2344         as a string instead.
2345
2346         * Scripts/webkitdirs.pm:
2347
2348 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
2349
2350         Reviewed by David Levin.
2351
2352         check-webkit-style misses whitespace errors for operators:
2353         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
2354         https://bugs.webkit.org/show_bug.cgi?id=30021
2355
2356         * Scripts/modules/cpp_style.py:
2357         Added the operators mentioned above to the same list as == and !=.
2358
2359 2009-10-02  Julie Parent  <jparent@chromium.org>
2360
2361         Unreviewed.
2362
2363         Adding myself and Ojan Vafai as committers, because we are committers.
2364
2365         * Scripts/modules/committers.py:
2366
2367 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
2368
2369         Reviewed by Adam Roben.
2370
2371         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
2372         this will help the patch merging process when TryBots are used.
2373
2374         * Scripts/svn-create-patch:
2375
2376 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
2377
2378         Reviewed by Simon Hausmann.
2379
2380         [Qt] Implement layoutTestController.overridePreference().
2381         https://bugs.webkit.org/show_bug.cgi?id=29970
2382
2383         * DumpRenderTree/qt/DumpRenderTree.cpp:
2384         (WebCore::WebPage::WebPage):
2385         (WebCore::WebPage::resetSettings):
2386         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2387         * DumpRenderTree/qt/jsobjects.cpp:
2388         (LayoutTestController::reset):
2389         (LayoutTestController::setPrivateBrowsingEnabled):
2390         (LayoutTestController::setPopupBlockingEnabled):
2391         (LayoutTestController::overridePreference):
2392         * DumpRenderTree/qt/jsobjects.h:
2393
2394 2009-10-01  Chris Marrin  <cmarrin@apple.com>
2395
2396         Reviewed by Oliver Hunt.
2397
2398         Turn on ENABLE_3D_CANVAS in TOT
2399         https://bugs.webkit.org/show_bug.cgi?id=29906
2400
2401         * Scripts/build-webkit:
2402
2403 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2404
2405         Rubberstamped by Simon Hausmann.
2406
2407         Enable HTTP tests for Qt
2408
2409         * Scripts/run-webkit-tests:
2410
2411 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
2412
2413         Reviewed by Dimitri Glazkov.
2414
2415         build-webkit --chromium now also works on cygwin.
2416
2417         https://bugs.webkit.org/show_bug.cgi?id=29973
2418
2419         * Scripts/webkitdirs.pm:
2420
2421 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
2422
2423         Reviewed by Simon Hausmann.
2424
2425         [Qt] Don't use TCmalloc in DumpRenderTree
2426         https://bugs.webkit.org/show_bug.cgi?id=27029
2427
2428         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
2429
2430         * DumpRenderTree/qt/DumpRenderTree.pro:
2431
2432 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
2433
2434         Reviewed by Simon Hausmann.
2435
2436         [Qt] Implement eventSender.scheduleAsynchronousClick().
2437
2438         https://bugs.webkit.org/show_bug.cgi?id=29931
2439
2440         * DumpRenderTree/qt/jsobjects.cpp:
2441         (EventSender::scheduleAsynchronousClick):
2442         * DumpRenderTree/qt/jsobjects.h:
2443
2444 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
2445
2446         Reviewed by Simon Hausmann.
2447
2448         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
2449         fast/events/open-window-from-another-frame.html from the Skipped list.
2450
2451         https://bugs.webkit.org/show_bug.cgi?id=29930
2452
2453         * DumpRenderTree/qt/jsobjects.cpp:
2454         (LayoutTestController::setPopupBlockingEnabled):
2455         * DumpRenderTree/qt/jsobjects.h:
2456
2457 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
2458
2459         Unreviewed.
2460
2461         Added myself to the list of committers.
2462
2463         * Scripts/modules/committers.py:
2464
2465 2009-09-30  Eric Seidel  <eric@webkit.org>
2466
2467         No review, just adding Geoff to the list of reviewers.
2468
2469         * Scripts/modules/committers.py:
2470
2471 2009-09-30  Dan Bernstein  <mitz@apple.com>
2472
2473         Reviewed by Sam Weinig.
2474
2475         Added the WebKit Layout Tests fonts that are referenced in
2476         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
2477
2478         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
2479         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
2480
2481 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2482
2483         Reviewed by David Kilzer.
2484
2485         Make sunspider scripts work on Windows platform.
2486         https://bugs.webkit.org/show_bug.cgi?id=29656
2487
2488         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
2489         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
2490         * Scripts/webkitdirs.pm: currentPerlPath() added.
2491
2492 2009-09-29  Brady Eidson  <beidson@apple.com>
2493
2494         Rubberstamped by Dan Bernstein.
2495
2496         Fix license and some sorting in new files.
2497
2498         * DumpRenderTree/mac/HistoryDelegate.h:
2499         * DumpRenderTree/mac/HistoryDelegate.mm:
2500
2501 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
2502
2503         Reviewed by David Kilzer.
2504
2505         Fixed how error codes are handled.
2506         https://bugs.webkit.org/show_bug.cgi?id=29898
2507
2508         * Scripts/update-webkit:
2509         * Scripts/update-webkit-chromium:
2510
2511 2009-09-29  Brady Eidson  <beidson@apple.com>
2512
2513         Reviewed by John Sullivan.
2514
2515         Updated way-out-of-date sorting throughout the dump methods/flags.
2516
2517         * DumpRenderTree/LayoutTestController.cpp:
2518         (LayoutTestController::LayoutTestController):
2519         (dumpAsPDFCallback):
2520         (dumpAsTextCallback):
2521         (dumpFrameLoadCallbacksCallback):
2522         (dumpResourceLoadCallbacksCallback):
2523         (LayoutTestController::staticFunctions):
2524
2525         * DumpRenderTree/LayoutTestController.h:
2526         (LayoutTestController::dumpAsText):
2527         (LayoutTestController::setDumpAsText):
2528         (LayoutTestController::dumpFrameLoadCallbacks):
2529         (LayoutTestController::setDumpFrameLoadCallbacks):
2530         (LayoutTestController::dumpSelectionRect):
2531         (LayoutTestController::setDumpSelectionRect):
2532         (LayoutTestController::dumpSourceAsWebArchive):
2533         (LayoutTestController::setDumpSourceAsWebArchive):
2534         (LayoutTestController::dumpStatusCallbacks):
2535         (LayoutTestController::setDumpStatusCallbacks):
2536         (LayoutTestController::dumpTitleChanges):
2537         (LayoutTestController::setDumpTitleChanges):
2538         (LayoutTestController::dumpWillCacheResponse):
2539         (LayoutTestController::setDumpWillCacheResponse):
2540
2541 2009-09-29  Brady Eidson  <beidson@apple.com>
2542
2543         Reviewed by John Sullivan.
2544
2545         WebKit Mac API should provide a delegate interface for global history.
2546         <rdar://problem/7042773> and https://webkit.org/b/29904
2547
2548         Adding the dumping of global history delegate callbacks.
2549
2550         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2551
2552         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
2553         * DumpRenderTree/mac/DumpRenderTree.mm:
2554         (createWebViewAndOffscreenWindow):
2555         (allocateGlobalControllers):
2556         (shouldLogFrameLoadDelegates):
2557         (shouldLogHistoryDelegates):
2558         (runTest):
2559
2560         Dump history delegate callbacks:
2561         * DumpRenderTree/mac/HistoryDelegate.h: Added.
2562         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
2563         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
2564         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
2565         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
2566
2567 2009-09-29  Daniel Bates  <dbates@webkit.org>
2568
2569         Reviewed by Adam Roben.
2570
2571         https://bugs.webkit.org/show_bug.cgi?id=28902
2572         
2573         Fixes an issue where the drop effect returned by Window Dump Render Tree 
2574         was always DROPEFFECT_NONE (since it was hard coded to do so).
2575         
2576         This patch corrects this issue by determining the actual drop effect 
2577         performed by the corresponding drag-and-drop operation so that we can 
2578         return it.
2579
2580         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
2581         (DraggingInfo::DraggingInfo):
2582         (DraggingInfo::performedDropEffect): Added method.
2583         (DraggingInfo::setPerformedDropEffect): Added method.
2584         * DumpRenderTree/win/EventSender.cpp:
2585         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
2586         Moved delete draggingInfo to UIDelegate::doDragDrop.
2587         * DumpRenderTree/win/UIDelegate.cpp:
2588         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
2589
2590 2009-09-29  Dan Bernstein  <mitz@apple.com>
2591
2592         Reviewed by Adam Roben.
2593
2594         Remove copying of unnecessary or nonexistent files from the ImageDiff
2595         post-build event.
2596
2597         * DumpRenderTree/win/ImageDiff.vcproj:
2598
2599 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2600
2601         Reviewed by David Kilzer.
2602
2603         [Qt] Make build-webkit script work on Windows
2604         https://bugs.webkit.org/show_bug.cgi?id=29802
2605
2606         * Scripts/run-webkit-tests:
2607         * Scripts/webkitdirs.pm:
2608          - Removed unnecessary -p switch for mkdir on Windows.
2609          - Use canonical path, which uses slashes or backslashes depends on platform.
2610          - isWindows() only test for Windows and not for Cyqwin.
2611
2612 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2613
2614         Reviewed by Simon Hausmann.
2615
2616         Fix time measurement in build-webkit after refactoring done in r48853.
2617
2618         * Scripts/build-webkit:
2619
2620 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2621
2622         Reviewed by Tor Arne Vestbø.
2623
2624         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
2625         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
2626
2627         * DumpRenderTree/qt/DumpRenderTree.cpp:
2628         (WebCore::WebPage::WebPage):
2629
2630 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
2631
2632         Reviewed by Simon Hausmann.
2633
2634         [Qt] Implement eventSender.contextClick().
2635         https://bugs.webkit.org/show_bug.cgi?id=29821
2636
2637         * DumpRenderTree/qt/jsobjects.cpp:
2638         (EventSender::contextClick):
2639         * DumpRenderTree/qt/jsobjects.h:
2640
2641 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
2642
2643         Reviewed by Eric Seidel.
2644
2645         Add experimentalWebSocketsEnabled in WebPreferences.
2646         https://bugs.webkit.org/show_bug.cgi?id=28941
2647
2648         * DumpRenderTree/mac/DumpRenderTree.mm:
2649         (resetDefaultsToConsistentValues):
2650         * DumpRenderTree/win/DumpRenderTree.cpp:
2651         (resetDefaultsToConsistentValues):
2652
2653 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
2654
2655         Reviewed by David Kilzer.
2656
2657         Integrated chromium port building into webkit tools update-webkit and
2658         build-webkit.
2659
2660         https://bugs.webkit.org/show_bug.cgi?id=29749
2661
2662         * Scripts/build-webkit: When --chromium is specified, will build
2663           the chromium port (currently only Mac is supported).
2664         * Scripts/update-webkit: When --chromium is specified, delegates to
2665           update-webkit-chromium.
2666         * Scripts/webkitdirs.pm: Added chromium specific defs.
2667         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
2668           chromium port's dependencies and update its project files.
2669
2670 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
2671
2672         Unreviewed.
2673
2674         Add myself to list of committers.
2675
2676         * Scripts/modules/committers.py:
2677
2678 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
2679
2680         Reviewed by Darin Adler.
2681
2682         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
2683         https://bugs.webkit.org/show_bug.cgi?id=29771
2684
2685         * Scripts/run-webkit-tests:
2686
2687 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
2688
2689         Reviewed by Simon Hausmann.
2690
2691         [Qt] Implement layoutTestController.waitForPolicyDelegate.
2692         https://bugs.webkit.org/show_bug.cgi?id=25037
2693
2694         * DumpRenderTree/qt/DumpRenderTree.cpp:
2695         (WebCore::WebPage::acceptNavigationRequest):
2696         * DumpRenderTree/qt/DumpRenderTree.pro:
2697         * DumpRenderTree/qt/jsobjects.cpp:
2698         (LayoutTestController::reset):
2699         (LayoutTestController::notifyDone):
2700         (LayoutTestController::waitForPolicyDelegate):
2701         * DumpRenderTree/qt/jsobjects.h:
2702         (LayoutTestController::waitForPolicy):
2703
2704 2009-09-26  David Kilzer  <ddkilzer@apple.com>
2705
2706         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
2707
2708         Reviewed by Eric Seidel.
2709
2710         The -o|--open switch uses the open(1) command on Mac OS X to
2711         open the bug URL in the default web browser.  If there are
2712         similar mechanisms on other platforms, they may be added later.
2713
2714         * Scripts/mark-bug-fixed:
2715         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
2716         options.
2717         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
2718         code into main() and extracted prompting code into
2719         _prompt_user_for_correctness().
2720         (MarkBugFixed._open_bug_in_web_browser): Added.
2721         (MarkBugFixed._prompt_user_for_correctness): Added.
2722         (MarkBugFixed.main): Added logging code from
2723         _determine_bug_id_and_svn_revision().  Added code to call
2724         _open_bug_in_web_browser() if the switch is set.  Added code to
2725         call _prompt_user_for_correctness() when needed.
2726         * Scripts/modules/bugzilla.py:
2727         (Bugzilla.short_bug_url_for_bug_id): Added.
2728
2729 2009-09-26  David Kilzer  <ddkilzer@apple.com>
2730
2731         svn-unapply and svn-apply don't work when used outside multiple svn working directories
2732
2733         <http://webkit.org/b/29744>
2734         <rdar://problem/7252905>
2735
2736         Reviewed by Eric Seidel.
2737
2738         Some users have a workflow where svn-create-patch, svn-apply and
2739         svn-unapply are used outside of multiple svn working
2740         directories.  Instead of aborting the scripts in these cases,
2741         print a warning and assume that Subversion is being used.
2742
2743         * Scripts/VCSUtils.pm:
2744         (determineVCSRoot): Call warn() instead of die() if both isGit()
2745         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
2746         to enforce the assumption about Subversion, then return
2747         determineSVNRoot().
2748         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
2749         VCSUtils.pm.  They both already cache their values and checking
2750         here is redundant since determineVCSRoot() is called later.
2751
2752 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
2753
2754         Reviewed by Gustavo Noronha.
2755
2756         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
2757         https://bugs.webkit.org/show_bug.cgi?id=29689
2758
2759         Load test fonts through FontConfig before each test.
2760         This ensures a more proper rendering of the tests.
2761
2762         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2763         (initializeFonts):
2764         (runTest):
2765         (main):
2766         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
2767         * GNUmakefile.am:
2768
2769 2009-09-25  David Kilzer  <ddkilzer@apple.com>
2770
2771         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
2772
2773         Reviewed by Eric Seidel.
2774
2775         * Scripts/mark-bug-fixed:
2776         (MarkBugFixed.__init__): Added -u|--update-only switch to list
2777         of parse options.
2778         (MarkBugFixed.main): When -u|--update-only is specified, add a
2779         comment to the bug without marking it Resolved/Fixed.
2780
2781 2009-09-25  Darin Adler  <darin@apple.com>
2782
2783         Reviewed by Geoffrey Garen.
2784
2785         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
2786         out, just as we do for the resources directory.
2787
2788 2009-09-25  Adam Barth  <abarth@webkit.org>
2789
2790         Unreviewed.  Added Tony to committers.py because he's a
2791         committer now.
2792
2793         * Scripts/modules/committers.py:
2794
2795 2009-09-25  Eric Seidel  <eric@webkit.org>
2796
2797         Reviewed by Simon Fraser.
2798
2799         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
2800         https://bugs.webkit.org/show_bug.cgi?id=28624
2801
2802         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
2803
2804         * DumpRenderTree/mac/DumpRenderTree.mm:
2805         (resetDefaultsToConsistentValues):
2806
2807 2009-09-25  Eric Seidel  <eric@webkit.org>
2808
2809         Reviewed by Adam Barth.
2810
2811         commit-queue should auto-retry patches which fail to commit due to out of date files
2812         https://bugs.webkit.org/show_bug.cgi?id=28316
2813
2814         * Scripts/bugzilla-tool:
2815          - Handle new CheckoutNeedsUpdate exception.
2816         * Scripts/modules/logging_unittest.py:
2817          - Call the ScriptError constructor correctly (this test had regressed).
2818         * Scripts/modules/scm.py:
2819          - Added the ability to define custom error handlers for run_command
2820            and added a commit_error_handler which throws CheckoutNeedsUpdate
2821            instead of ScriptError.
2822          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
2823         * Scripts/modules/scm_unittest.py:
2824          - Added tests of new error handlers.
2825
2826 2009-09-25  Eric Seidel  <eric@webkit.org>
2827
2828         Reviewed by Adam Barth.
2829
2830         commit-queue should give better feedback when failing a patch
2831         https://bugs.webkit.org/show_bug.cgi?id=29316
2832
2833         * Scripts/bugzilla-tool:
2834          - Update ScriptError uses to the new constructor format.
2835          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
2836            so that we can print to both stdout as well as an output buffer for error reporting.
2837          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
2838          - Use e.message_with_output() when failing a patch (this is the real fix here).
2839            I also removed use of "This patch will require manual commit." as that's not always true.
2840          - Add missing word "bug" from log message.
2841         * Scripts/modules/scm.py:
2842          - Make ScriptError save a bunch more data so that error messages can be nicer.
2843          - Update ScriptError callers.
2844
2845 2009-09-24  John Gregg  <johnnyg@google.com>
2846
2847         Reviewed by Eric Seidel.
2848
2849         Enable switch for notifications (experimental) in Page Settings
2850         https://bugs.webkit.org/show_bug.cgi?id=28930
2851
2852         Now that desktop notifications are controlled by run-time switch,
2853         set that switch to true for DumpRenderTree.
2854
2855         * DumpRenderTree/mac/DumpRenderTree.mm:
2856         (resetDefaultsToConsistentValues):
2857         * DumpRenderTree/win/DumpRenderTree.cpp:
2858         (resetDefaultsToConsistentValues):
2859         * DumpRenderTree/win/UIDelegate.cpp:
2860         (UIDelegate::QueryInterface):
2861
2862 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
2863
2864         wx build fix. SnowLeopard fixes for Mac dependencies.
2865
2866         * wx/build/build_utils.py:
2867         * wx/build/settings.py:
2868         * wx/install-unix-extras:
2869
2870 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2871
2872         Reviewed by Oliver Hunt.
2873
2874         Add support for DRT to send mouse wheel events.
2875
2876         https://bugs.webkit.org/show_bug.cgi?id=29348
2877         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
2878
2879         * DumpRenderTree/gtk/EventSender.cpp:
2880         (mouseWheelToCallback):
2881
2882 2009-09-17  Eric Seidel  <eric@webkit.org>
2883
2884         Reviewed by David Levin.
2885
2886         commit-queue needs web-based status reporting
2887         https://bugs.webkit.org/show_bug.cgi?id=29307
2888
2889         Add a first-pass web-based status for the commit-queue.
2890         The bot is currently reachable at:
2891         http://webkit-commit-queue.appspot.com/
2892
2893         * CommitQueueStatus/app.yaml: Added.
2894          - Application description file required by App Engine.
2895         * CommitQueueStatus/filters/__init__.py: Added.
2896          - Required by python to treat 'filters' as a module.
2897         * CommitQueueStatus/filters/webkit_extras.py: Added.
2898          - Support for turning 'bug 123' and 'patch 123' into links.
2899            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
2900         * CommitQueueStatus/index.html: Added.
2901         * CommitQueueStatus/index.yaml: Added.
2902          - Some auto-generated file from app engine.
2903         * CommitQueueStatus/queue_status.py: Added.
2904          - The core logic of this bot.  We could eventually split this file out into pieces.
2905         * CommitQueueStatus/stylesheets/main.css: Added.
2906          - Some basic lame-o CSS to make the page look less awful.
2907         * CommitQueueStatus/update_status.html: Added.
2908          - The form that the commit-queue (or a human) can use to update the status.
2909         * Scripts/bugzilla-tool:
2910          - Add some very basic update_status calls.
2911         * Scripts/modules/statusbot.py: Added.
2912          - Knows how to post to the CommitQueueStatus web application.
2913
2914 2009-09-24  David Kilzer  <ddkilzer@apple.com>
2915
2916         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
2917
2918         Reviewed by Adam Roben.
2919
2920         * Scripts/mark-bug-fixed:
2921         (MarkBugFixed.__init__): Added -m|--comment switch to list of
2922         parse options.
2923         (MarkBugFixed.main): When specified, prepend comment from
2924         -m|--comment command-line switch to the bug comment.
2925
2926 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2927
2928         Reviewed by Jan Alonzo.
2929
2930         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
2931         https://bugs.webkit.org/show_bug.cgi?id=29693
2932
2933         Show the window, to be able to synthesize events correctly.
2934
2935         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2936         (runTest):
2937         (main):
2938
2939 2009-09-24  Oliver Hunt  <oliver@apple.com>
2940
2941         Reviewed by NOBODY(rollout)
2942
2943         Roll out r48712 as it is incorrect.
2944
2945         * DumpRenderTree/mac/ObjCController.m:
2946         (+[ObjCController isSelectorExcludedFromWebScript:]):
2947         (+[ObjCController webScriptNameForSelector:]):
2948
2949 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
2950
2951         Reviewed by Eric Seidel.
2952
2953         https://bugs.webkit.org/show_bug.cgi?id=29005
2954         The indices of RuntimeArray should be enumerated like for a regular array.
2955
2956         * DumpRenderTree/mac/ObjCController.m:
2957         (+[ObjCController isSelectorExcludedFromWebScript:]):
2958         (+[ObjCController webScriptNameForSelector:]):
2959         (-[ObjCController arrayOfString]):
2960
2961 2009-09-23  David Kilzer  <ddkilzer@apple.com>
2962
2963         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
2964
2965         Reviewed by Darin Adler.
2966
2967         Also fixed a bug where specifying a revision on the command-line
2968         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
2969
2970         * Scripts/bugzilla-tool: Updated module import statements.
2971         (parse_bug_id): Removed.  Moved to bugzilla.py.
2972         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
2973         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
2974         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
2975         (BugzillaTool.__init__): Removed mark-fixed subcommand.
2976         * Scripts/mark-bug-fixed: Added.
2977         * Scripts/modules/bugzilla.py:
2978         (parse_bug_id): Added.  Moved from bugzilla-tool.
2979         * Scripts/modules/comments.py: Added.
2980         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
2981         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
2982
2983 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
2984
2985         Reviewed by Eric Seidel.
2986         
2987          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
2988          "false" in non-implemented stub for setAlwaysAcceptCookies.
2989          https://bugs.webkit.org/show_bug.cgi?id=29661
2990
2991         * DumpRenderTree/win/DumpRenderTree.vcproj:
2992         * DumpRenderTree/win/DumpRenderTree.cpp:
2993
2994 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2995
2996         Reviewed by Xan Lopez.
2997
2998         [GTK] need to dump number of pending unload handlers
2999         https://bugs.webkit.org/show_bug.cgi?id=29685
3000
3001         Implement dumping of the number of pending unload handlers.
3002
3003         The following tests will pass:
3004
3005           fast/loader/unload-form-about-blank.html
3006           fast/loader/unload-form-post-about-blank.html
3007           fast/loader/unload-form-post.html
3008           fast/loader/unload-form.html
3009           fast/loader/unload-hyperlink.html
3010           fast/loader/unload-javascript-url.html
3011           fast/loader/unload-reload.html
3012           fast/loader/unload-window-location.html
3013
3014         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3015         (getFrameNameSuitableForTestResult):
3016         (webViewLoadFinished):
3017
3018 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
3019
3020         Reviewed by Eric Seidel.
3021
3022         js tests should move into jstests subdirectory instead of resources/
3023         https://bugs.webkit.org/show_bug.cgi?id=25880
3024
3025         Remove support of resources directory.
3026
3027         * Scripts/make-script-test-wrappers:
3028
3029 2009-09-22  Eric Seidel  <eric@webkit.org>
3030
3031         No review, only fixing typo (missing space character).
3032
3033         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
3034
3035         * Scripts/run-webkit-tests:
3036
3037 2009-09-22  Eric Seidel  <eric@webkit.org>
3038
3039         Reviewed by Darin Adler.
3040
3041         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
3042         https://bugs.webkit.org/show_bug.cgi?id=29220
3043
3044         * Scripts/run-webkit-tests:
3045
3046 2009-09-22  Eric Seidel  <eric@webkit.org>
3047
3048         Reviewed by David Kilzer.
3049
3050         svn-apply can't handle single-line binary file additions
3051         https://bugs.webkit.org/show_bug.cgi?id=29100
3052
3053         Fixed the regexp and added a unit test.
3054
3055         * Scripts/modules/scm_unittest.py:
3056         * Scripts/svn-apply:
3057
3058 2009-09-11  Eric Seidel  <eric@webkit.org>
3059
3060         Reviewed by David Kilzer.
3061
3062         post-diff and post-commits should be able to find bug urls in ChangeLogs.
3063         https://bugs.webkit.org/show_bug.cgi?id=29206
3064
3065         * Scripts/bugzilla-tool:
3066          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
3067          - Rename --no-comment to --add-log-as-comment and reverse behavior.
3068            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
3069          - Split out code into helper functions to try and make execute() more legible.
3070          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
3071          - Fallback to bug urls in commit diffs, instead of just in commit messages,
3072            meaning post-commits will now find bug urls in ChangeLogs.
3073
3074 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3075
3076         Reviewed by Maciej Stachowiak.
3077
3078         --parse-only parameter wasn't passed to SunSpider/sunspider script.
3079         https://bugs.webkit.org/show_bug.cgi?id=29611
3080
3081         * Scripts/run-sunspider: Missing parameter passing added.
3082
3083 2009-09-20  David Kilzer  <ddkilzer@apple.com>
3084
3085         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
3086
3087         Reviewed by Mark Rowe.
3088
3089         The require statement is like the use statement, except that it
3090         is run during script execution instead of during the 'BEGIN'
3091         phase.  This makes it possible to change @INC before the require
3092         statement is run.  See 'require' and 'use' in the perlfunc(1)
3093         manpage and 'BEGIN' in perlmod(1) manpage.
3094
3095         * Scripts/run-webkit-tests: Replace eval statement with require
3096         statement.
3097
3098 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
3099
3100         wx build fixes. Fix the config name under git and allow users to specify
3101         their own waf install for experimenting with new versions.
3102
3103         * Scripts/webkitdirs.pm:
3104         * wx/build/settings.py:
3105
3106 2009-09-18  Alex Milowski  <alex@milowski.com>
3107
3108         Reviewed by Maciej Stachowiak.
3109
3110         Added checkWebCoreMathMLSupport and hasMathMLSupport to support 
3111         checking for whether MathML tests should be run
3112
3113         * Scripts/run-webkit-tests:
3114         * Scripts/webkitdirs.pm:
3115
3116 2009-08-28  Darin Adler  <darin@apple.com>
3117
3118         Reviewed by Mark Rowe.
3119
3120         Break more of run-webkit-tests into separate functions
3121         https://bugs.webkit.org/show_bug.cgi?id=29497
3122
3123         Some small steps toward improving run-webkit-tests. My goal is to
3124         refactor much more of the script into functions. Later we can add
3125         parallel test running to the tool. But better structure may help
3126         even if someone decides to translate this into another scripting
3127         language instead.
3128
3129         * Scripts/run-webkit-tests: Break more pieces of the script into
3130         seprate functions. Added readSkippedFiles, findTestsToRun, and
3131         printResults functions. Removed custom code to skip results.html
3132         and instead just put it into the ignoredFiles hash. Fixed some
3133         indentation. Sorted function declarations, global variables,
3134         and options at the top of the file alphabetically so they're not
3135         in a semi-random order.
3136
3137 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
3138
3139         wx build fix, add missing dependency.
3140
3141         * wx/browser/wscript:
3142
3143 2009-09-16  Mark Rowe  <mrowe@apple.com>
3144
3145         Split the SnowLeopard build across a few machines.
3146
3147         * BuildSlaveSupport/build.webkit.org-config/config.json:
3148
3149 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
3150
3151         wx build fix to support monolithic builds on Windows.
3152
3153         * wx/build/wxpresets.py:
3154
3155 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
3156
3157         wx build fix, improve debug support and 2.9 support on MSW.
3158
3159         * wx/build/settings.py:
3160         * wx/build/wxpresets.py:
3161
3162 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3163
3164         Blind try at fixing new test failure on Windows.
3165
3166         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3167         (FrameLoadDelegate::didReceiveTitle):
3168
3169 2009-09-15  Alex Milowski  <alex@milowski.com>
3170
3171         Reviewed by Tor Arne Vestbø.
3172
3173         Added mathml toggle
3174
3175         * Scripts/build-webkit:
3176
3177 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
3178
3179         wx build fix. Allow waf build to support Python < 2.6.
3180
3181         * wx/build/waf_extensions.py:
3182
3183 2009-09-14  Chris Marrin  <cmarrin@apple.com>
3184
3185         Reviewed by Oliver Hunt.
3186
3187         Add LayoutTests infrastructure to enable and disable webgl tests.
3188         https://bugs.webkit.org/show_bug.cgi?id=29254
3189
3190         * Scripts/run-webkit-tests:
3191         * Scripts/webkitdirs.pm:
3192
3193 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
3194
3195         Reviewed by Darin Adler.
3196         
3197         Add --iterations option to run-webkit-tests to repeat the tests N times
3198         https://bugs.webkit.org/show_bug.cgi?id=29263
3199
3200         When run with --iterations N, run-webkit-tests will repeat the tests N times.
3201
3202         * Scripts/run-webkit-tests:
3203
3204 2009-09-14  Brady Eidson  <beidson@apple.com>
3205
3206         Not reviewed, maybe should've been:
3207
3208         Cleaning up more Windows-specific fallout from the fix for:
3209         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
3210
3211         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3212         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter, 
3213           and call the correct method to get the Sender.
3214
3215 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
3216
3217         GTK build fix.
3218
3219         Unreviewed.
3220
3221         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3222         (AccessibilityController::setLogScrollingStartEvents):
3223
3224 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
3225
3226         DRT/test part of
3227         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
3228         jumping to a named anchor
3229
3230         https://bugs.webkit.org/show_bug.cgi?id=28899
3231
3232         Reviewed by Adam Roben.
3233
3234         * DumpRenderTree/AccessibilityController.cpp:
3235         (logScrollingStartEventsCallback):
3236         Turn on logging of scrolling start events.
3237         (AccessibilityController::getJSClass):
3238         Add a "logScrollingStartEvents" to the AccessibilityController's JS
3239         class definition.
3240         (AccessibilityController::resetToConsistentState):
3241         Turn off logging of scrolling start events.
3242
3243         * DumpRenderTree/AccessibilityController.h:
3244         Declare setLogScrollingStartEvents(). Add a member for the scrolling
3245         start event hook.
3246
3247         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
3248         (AccessibilityController::setLogScrollingStartEvents):
3249         Stubbed.
3250
3251         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3252         (AccessibilityController::AccessibilityController):
3253         Initialize the handle to 0.
3254         (logEventProc):
3255         Renamed from logFocusEventProc; now logs scrolling start events, too.
3256         Removed the assertion that the event is a focus event. Added a switch
3257         to print a message for focus, scrolling start, and other, unknown
3258         events.
3259         (AccessibilityController::setLogFocusEvents):
3260         Changed to use logEventProc.
3261         (AccessibilityController::setLogScrollingStartEvents):
3262         If turning logging off, unhook the scrolling start event hook, and clear
3263         the member holding the handle. If turning on, query for the root
3264         accessible, so that accessibility is enabled for the WebView, and call
3265         SetWinEventHook to setup an event hook using logEventProc as the
3266         callback function.
3267
3268 2009-09-14  Brady Eidson  <beidson@apple.com>
3269
3270         Windows build fix.
3271
3272         * DumpRenderTree/LayoutTestController.cpp:
3273         (setAuthenticationPasswordCallback):
3274         (setAuthenticationUsernameCallback):
3275         
3276         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3277         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3278
3279 2009-09-14  Brady Eidson  <beidson@apple.com>
3280
3281         Reviewed by Alexey Proskuryakov.
3282
3283         Safari 4 cannot be used to update firmware on Linksys routers.
3284         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
3285
3286         Add the ability for DRT to handle authentication challenges.
3287
3288         * DumpRenderTree/LayoutTestController.cpp:
3289         (setAuthenticationPasswordCallback):
3290         (setAuthenticationUsernameCallback):
3291         (setHandlesAuthenticationChallengesCallback):
3292         (LayoutTestController::staticFunctions):
3293
3294         * DumpRenderTree/LayoutTestController.h:
3295         (LayoutTestController::handlesAuthenticationChallenges):
3296         (LayoutTestController::setHandlesAuthenticationChallenges):
3297         (LayoutTestController::authenticationUsername):
3298         (LayoutTestController::setAuthenticationUsername):
3299         (LayoutTestController::authenticationPassword):
3300         (LayoutTestController::setAuthenticationPassword):
3301
3302         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3303         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
3304
3305         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3306         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3307         * DumpRenderTree/win/ResourceLoadDelegate.h:
3308
3309 2009-09-12  Mark Rowe  <mrowe@apple.com>
3310
3311         Reviewed by Dan Bernstein.
3312
3313         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
3314
3315         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
3316         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
3317
3318         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3319         (NPP_New):
3320
3321 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
3322
3323         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
3324
3325         * wx/build/build_utils.py:
3326         * wx/build/settings.py:
3327
3328 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3329
3330         Reviewed by Tor Arne Vestbø.
3331
3332         [Qt] Build fix for windows build.
3333
3334         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
3335
3336 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
3337
3338         Fix typo accidently landed in last commit.
3339
3340         * wx/build/settings.py:
3341
3342 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
3343
3344         wx build fix, error out if using the wrong Python.
3345
3346         * wx/build/settings.py:
3347
3348 2009-09-13  Xan Lopez  <xlopez@igalia.com>
3349
3350         Build fix for GTK+ < 2.14.
3351
3352         Do not use gtk_widget_get_window, access the window directly
3353         through the struct.
3354
3355         * DumpRenderTree/gtk/EventSender.cpp:
3356         (contextClickCallback):
3357         (mouseDownCallback):
3358         (mouseUpCallback):
3359         (mouseMoveToCallback):
3360         (keyDownCallback):
3361
3362 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
3363
3364         Reviewed by Xan Lopez and Jan Alonzo.
3365
3366         [GTK] EventSender does not set 'window' property on synthesized GDK events
3367         https://bugs.webkit.org/show_bug.cgi?id=29169
3368
3369         Set the window property on synthesized GDK events in the GTK+ EventSender.
3370
3371         * DumpRenderTree/gtk/EventSender.cpp:
3372         (contextClickCallback):
3373         (mouseDownCallback):
3374         (mouseUpCallback):
3375         (mouseMoveToCallback):
3376         (keyDownCallback):
3377
3378 2009-09-12  Drew Wilson  <atwilson@google.com>
3379
3380         Reviewed by Mark Rowe.
3381
3382         run-webkit-tests has a timeout value that is too low
3383         https://bugs.webkit.org/show_bug.cgi?id=29223
3384
3385         * Scripts/run-webkit-tests:
3386         Changed timeout value to 20 seconds to avoid timing out too early.
3387
3388 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
3389
3390         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
3391         architectures are supported for building wxWebKit.
3392
3393         * wx/build/settings.py:
3394
3395 2009-09-11  Eric Seidel  <eric@webkit.org>
3396
3397         Reviewed by David Levin.
3398
3399         bugzilla-tool rollout threw exception under svn
3400         https://bugs.webkit.org/show_bug.cgi?id=29211
3401
3402         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
3403         * Scripts/modules/scm_unittest.py: add testing for this fix.
3404
3405 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
3406
3407         Add myself to the committers list.
3408
3409         * Scripts/modules/committers.py:
3410
3411 2009-09-11  Eric Seidel  <eric@webkit.org>
3412
3413         Reviewed by Adam Barth.
3414
3415         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
3416         https://bugs.webkit.org/show_bug.cgi?id=29201
3417
3418         * Scripts/bugzilla-tool:
3419
3420 2009-09-11  Adam Roben  <aroben@apple.com>
3421
3422         Make commit-log-editor move common prefixes to the top of the log
3423
3424         Fies <http://webkit.org/b/29190> commit-log-editor should move common
3425         prefixes to the top of the commit log
3426
3427         Reviewed by Darin Adler.
3428
3429         * Scripts/commit-log-editor: Find and remove the longest common prefix
3430         ending in a double newline from each ChangeLog entry, then put that
3431         common prefix at the top of the commit log.
3432         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
3433         removes, and returns the longest common prefix ending in a double
3434         newline from a hash of strings
3435
3436 2009-09-11  Eric Seidel  <eric@webkit.org>
3437
3438         Fix obvious typo in previous commit, no review.
3439
3440         bugzilla-tool should automate rollouts
3441         https://bugs.webkit.org/show_bug.cgi?id=26715
3442
3443         * Scripts/bugzilla-tool: add back missing "scm" argument.
3444
3445 2009-09-11  Eric Seidel  <eric@webkit.org>
3446
3447         Reviewed by Adam Barth.
3448
3449         bugzilla-tool should automate rollouts
3450         https://bugs.webkit.org/show_bug.cgi?id=26715
3451
3452         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
3453         The --complete-rollout option will automatically land and update the bug.
3454         Eventually --complete-rollout will be default, but that will require more testing.
3455
3456         This first pass is good enough for others to try and file bugs about.
3457
3458         * Scripts/bugzilla-tool:
3459          - Move modified_changelogs into scm.py.
3460          - Move svn_revision_from_commit_text logic into scm.py.
3461          - Add RolloutCommit command.
3462         * Scripts/modules/bugzilla.py:
3463          - Add reopen_bug command used by RolloutCommit.
3464         * Scripts/modules/scm.py:
3465          - Add functions to support RolloutCommit.
3466          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
3467          - Add a str() call so that svn_commit_log can take a numeric argument.
3468          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
3469          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
3470         * Scripts/modules/scm_unittest.py:
3471          - Add read_from_path for easy file reading.
3472          - Put test4 on a new line to make reverts work w/o conflict.
3473          - Add an "svn update" call so that the checkout revision matches the server revision.
3474          - Add tests for svn_revision_from_commit_text.
3475          - Add a simple test for apply_reverse_diff.
3476          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
3477          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
3478
3479 2009-09-11  Adam Roben  <aroben@apple.com>
3480
3481         Get user script/stylesheet tests running on Windows
3482
3483         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
3484         skipped on Windows
3485
3486         Reviewed by John Sullivan.
3487
3488         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
3489         against comsuppw.lib so we can use _bstr_t.
3490
3491         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
3492         order, added #include of comutil.h for _bstr_t.
3493
3494         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
3495         (LayoutTestController::addUserScript):
3496         (LayoutTestController::addUserStyleSheet):
3497         Implemented. Implementations were based on those in
3498         LayoutTestControllerMac.mm.
3499
3500 2009-09-10  David Kilzer  <ddkilzer@apple.com>
3501
3502         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help 
3503
3504         Reviewed by Mark Rowe.
3505
3506         * Scripts/run-webkit-tests: Updated to make -h switch show help.
3507
3508 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
3509
3510         Reviewed by Alexey Proskuryakov.
3511
3512         Add WebCore/websockets directory in wx build system.
3513         https://bugs.webkit.org/show_bug.cgi?id=28038
3514
3515         * wx/build/settings.py:
3516
3517 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
3518
3519         [GTK] EventSender does not properly convert some keyDown strings
3520         https://bugs.webkit.org/show_bug.cgi?id=29119
3521
3522         Add more keyDown string to character code conversions for GTK+ EventSender.
3523
3524         * DumpRenderTree/gtk/EventSender.cpp:
3525         (keyDownCallback):
3526
3527 2009-09-09  Steve Block  <steveblock@google.com>
3528
3529         Reviewed by Maciej Stachowiak.
3530
3531         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
3532         https://bugs.webkit.org/show_bug.cgi?id=29080
3533
3534         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
3535
3536 2009-09-09  Eric Seidel  <eric@webkit.org>
3537
3538         Reviewed by Eric Carlson.
3539
3540         reviewer/committer lookups are backwards
3541         https://bugs.webkit.org/show_bug.cgi?id=29113
3542
3543         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
3544
3545         * Scripts/modules/bugzilla.py:
3546         * Scripts/modules/committers.py:
3547
3548 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
3549
3550         Reviewed by Eric Seidel.
3551
3552         svn-unapply doesn't revert directories correctly
3553         https://bugs.webkit.org/show_bug.cgi?id=29065
3554
3555         * Scripts/svn-unapply: Make svnStatus consistently return status
3556         lines including a newline.
3557         * Scripts/svn-apply: Keep svnStatus in sync with the one in
3558         svn-unapply, in lieu of moving it to a common file.
3559
3560 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
3561
3562         Reviewed by Eric Seidel.
3563
3564         svn-apply doesn't handle changes to files copied to new directories properly
3565         https://bugs.webkit.org/show_bug.cgi?id=29059
3566
3567         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
3568         additions if we know that we've just copied a file to this name.
3569
3570 2009-09-09  Eric Seidel  <eric@webkit.org>
3571
3572         Reviewed by David Levin.
3573
3574         commit-queue hangs if a builder has never built
3575         https://bugs.webkit.org/show_bug.cgi?id=29091
3576
3577         * Scripts/modules/buildbot.py:
3578         * Scripts/modules/buildbot_unittest.py:
3579
3580 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
3581
3582         Reviewed by Gustavo Noronha.
3583
3584         [GTK] DumpRenderTree needs eventSender object and implementation
3585         https://bugs.webkit.org/show_bug.cgi?id=25990
3586
3587         Implements most of the EventSender object's functionality for
3588         the DumpRenderTree tool. Implementation still lacks support
3589         for drag and drop tests and forward leaps.
3590
3591         Based on work by Holger Hans Peter Freyther.
3592
3593         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3594         (runTest): Focus on the view before loading a new test.
3595         (webViewWindowObjectCleared):
3596         * DumpRenderTree/gtk/EventSender.cpp: Added.
3597         (getDragModeCallback):
3598         (setDragModeCallback):
3599         (leapForwardCallback):
3600         (contextClickCallback):
3601         (updateClickCount):
3602         (mouseDownCallback):
3603         (mouseUpCallback):
3604         (mouseMoveToCallback):
3605         (beginDragWithFilesCallback):
3606         (replaySavedEvents):
3607         (keyDownCallback):
3608         (textZoomInCallback):
3609         (textZoomOutCallback):
3610         (zoomPageInCallback):
3611         (zoomPageOutCallback):
3612         (getClass):
3613         (makeEventSender):
3614         * DumpRenderTree/gtk/EventSender.h: Added.
3615         * GNUmakefile.am: Add build rules for EventSender.
3616
3617 2009-09-09  Daniel Bates  <dbates@webkit.org>
3618
3619         Reviewed by Adam Roben.
3620         
3621         https://bugs.webkit.org/show_bug.cgi?id=28953
3622
3623         Added pre- and post- build events so that on build failure, the file 
3624         buildfailed is written to the directory $(WebKitOutputDir).
3625
3626         * WinLauncher/WinLauncher.vcproj:
3627
3628 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3629
3630         Unreviewed.
3631
3632         Add myself to list of committers.
3633
3634         * Scripts/modules/committers.py:
3635
3636 2009-09-08  Eric Seidel  <eric@webkit.org>
3637
3638         Reviewed by David Levin.
3639
3640         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
3641         https://bugs.webkit.org/show_bug.cgi?id=28605
3642         https://bugs.webkit.org/show_bug.cgi?id=28916
3643
3644         * Scripts/bugzilla-tool:
3645          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
3646            comment now that it's used for rejecting patches for invalid committers too.
3647          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
3648          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
3649         * Scripts/modules/bugzilla.py:
3650          - Make _parse_attachment_element not validate reviewer/committer.
3651          - Share flag parsing code in _parse_attachment_flag.
3652          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
3653          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
3654          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
3655         * Scripts/modules/bugzilla_unittest.py:
3656          - Update this test to no longer expect committer/reviewer validation.
3657         * Scripts/modules/committers.py:
3658          - Return None on failed lookups instead of raising Exceptions.
3659         * Scripts/modules/committers_unittest.py:
3660          - Update tests to expect None returns instead of exceptions.
3661
3662 2009-09-09  David Kilzer  <ddkilzer@apple.com>
3663