WebKitTools/ChangeLog

   1 2009-11-21  Adam Barth  <abarth@webkit.org>
   2
   3         Reviewed by Eric Seidel.
   4
   5         Convert check-style to use LandingSequence
   6         https://bugs.webkit.org/show_bug.cgi?id=31763
   7
   8         Instead of manipulating the working copy by hand, we should use the
   9         LandingSequence in CheckStyle.  This will make this code eaiser to
  10         test.
  11
  12         * Scripts/modules/commands/download.py:
  13
  14 2009-11-20  Adam Barth  <abarth@webkit.org>
  15
  16         Reviewed by Eric Seidel.
  17
  18         Unit test query commands
  19         https://bugs.webkit.org/show_bug.cgi?id=31755
  20
  21         These tests are pretty rough, but hopefully they'll grow.
  22
  23         * Scripts/modules/commands/queries_unittest.py: Added.
  24         * Scripts/modules/mock_bugzillatool.py: Added.
  25         * Scripts/run-webkit-unittests:
  26
  27 2009-11-20  Eric Seidel  <eric@webkit.org>
  28
  29         Reviewed by Adam Barth.
  30
  31         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
  32         https://bugs.webkit.org/show_bug.cgi?id=31758
  33
  34         * Scripts/modules/multicommandtool.py:
  35          - Allow passing of explicit commands to MultiCommandTool.__init__
  36         * Scripts/modules/multicommandtool_unittest.py:
  37          - Use new Command.name naming system.
  38          - Test Command auto-discovery.
  39         * Scripts/modules/workqueue.py:
  40          - bug_id no longer exists, use patch['bug_id'] instead.
  41         * Scripts/modules/workqueue_unittest.py:
  42          - WorkQueues require names now.
  43          - should_proceed_with_work_item must return a patch object.
  44
  45 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
  46
  47         Reviewed by Beth Dakin.
  48
  49         WAI-ARIA: add support for aria-owns
  50         https://bugs.webkit.org/show_bug.cgi?id=31702
  51
  52         * DumpRenderTree/AccessibilityUIElement.cpp:
  53         (ariaOwnsElementAtIndexCallback):
  54         (AccessibilityUIElement::getJSClass):
  55         * DumpRenderTree/AccessibilityUIElement.h:
  56         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  57         (AccessibilityUIElement::ariaOwnsElementAtIndex):
  58         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  59         (AccessibilityUIElement::ariaOwnsElementAtIndex):
  60         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  61         (AccessibilityUIElement::ariaOwnsElementAtIndex):
  62
  63 2009-11-20  Eric Seidel  <eric@webkit.org>
  64
  65         Reviewed by Adam Barth.
  66
  67         Fix exception thrown when running the commit-queue.
  68
  69         * Scripts/modules/statusbot.py: patch is optional.
  70         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
  71
  72 2009-11-20  Eric Seidel  <eric@webkit.org>
  73
  74         Reviewed by Adam Barth.
  75
  76         Teach the StatusBot how to support more than just the commit-queue
  77         https://bugs.webkit.org/show_bug.cgi?id=31754
  78
  79         * Scripts/modules/workqueue.py: Another typo.
  80
  81 2009-11-20  Eric Seidel  <eric@webkit.org>
  82
  83         Reviewed by Adam Barth.
  84
  85         Teach the StatusBot how to support more than just the commit-queue
  86         https://bugs.webkit.org/show_bug.cgi?id=31754
  87
  88         * Scripts/modules/commands/queues.py: Fix silly typo.
  89
  90 2009-11-20  Eric Seidel  <eric@webkit.org>
  91
  92         Reviewed by Adam Barth.
  93
  94         Teach the StatusBot how to support more than just the commit-queue
  95         https://bugs.webkit.org/show_bug.cgi?id=31754
  96
  97         * CommitQueueStatus/index.yaml:
  98          - Add indices required for the new queries.
  99         * CommitQueueStatus/queue_status.py:
 100          - Add a patch-status page and move update_status to update-status.
 101          - Only display "commit-queue" status records for the commit-queue.
 102          - Add support for a queue_name property on status records.
 103          - Fix _int_from_request to actually work.
 104         * CommitQueueStatus/update_status.html:
 105          - Add support for a queue_name on status records.
 106          - Remove unused list of bug ids.
 107          * Scripts/modules/commands/queues.py
 108           - Make the queues pass the patch instead of the bug_id to StatusBot.
 109         * Scripts/modules/statusbot.py:
 110          - Support passing the queue_name to the status updates.
 111          - Support fetching patch status with patch_status().
 112         * Scripts/modules/workqueue.py:
 113          - Pass the patch to the StatusBot instead of the bug_id.
 114          - Let WorkQueues have a name.
 115
 116 2009-11-20  Adam Barth  <abarth@webkit.org>
 117
 118         Reviewed by Eric Seidel.
 119
 120         Move bugzilla-tool commands into their own file
 121         https://bugs.webkit.org/show_bug.cgi?id=31752
 122
 123         This will let us write unit tests.
 124
 125         * Scripts/bugzilla-tool:
 126         * Scripts/modules/commands/__init__.py: Added.
 127         * Scripts/modules/commands/download.py: Added.
 128         * Scripts/modules/commands/queries.py: Added.
 129         * Scripts/modules/commands/queues.py: Added.
 130         * Scripts/modules/commands/upload.py: Added.
 131         * Scripts/modules/grammar.py: Added.
 132
 133 2009-11-20  Adam Barth  <abarth@webkit.org>
 134
 135         Reviewed by Eric Seidel.
 136
 137         BuildQueue should check if the tree is currently buildable
 138         https://bugs.webkit.org/show_bug.cgi?id=31744
 139
 140         * Scripts/bugzilla-tool:
 141         * Scripts/modules/landingsequence.py:
 142         * Scripts/modules/webkitlandingscripts.py:
 143
 144 2009-11-20  Adam Barth  <abarth@webkit.org>
 145
 146         Reviewed by Eric Seidel.
 147
 148         Move prepare_clean_working_directory into the LandingSequence
 149         https://bugs.webkit.org/show_bug.cgi?id=31743
 150
 151         * Scripts/bugzilla-tool:
 152         * Scripts/modules/landingsequence.py:
 153
 154 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
 155
 156         Reviewed by Kenneth Rohde Christiansen.
 157
 158         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
 159         https://bugs.webkit.org/show_bug.cgi?id=30460
 160
 161         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
 162
 163         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 164         (pluginInvoke):
 165
 166 2009-11-20  Adam Barth  <abarth@webkit.org>
 167
 168         Reviewed by Eric Seidel.
 169
 170         Pass the port information to the child process
 171         https://bugs.webkit.org/show_bug.cgi?id=31736
 172
 173         We need to do this so the child process knows what to build!
 174
 175         * Scripts/bugzilla-tool:
 176         * Scripts/modules/landingsequence.py:
 177         * Scripts/modules/webkitport.py:
 178         * Scripts/modules/webkitport_unittest.py:
 179
 180 2009-11-20  Adam Barth  <abarth@webkit.org>
 181
 182         Reviewed by Eric Seidel.
 183
 184         Support Qt port in build-queue
 185         https://bugs.webkit.org/show_bug.cgi?id=31733
 186
 187         * Scripts/bugzilla-tool:
 188
 189 2009-11-20  Adam Barth  <abarth@webkit.org>
 190
 191         Reviewed by Eric Seidel.
 192
 193         Implement a build-queue
 194         https://bugs.webkit.org/show_bug.cgi?id=31725
 195
 196         Currently this just builds the first 10 patches in the review queue.
 197         We'll want to do something smarter soon.
 198
 199         * Scripts/bugzilla-tool:
 200
 201 2009-11-20  Adam Barth  <abarth@webkit.org>
 202
 203         Reviewed by Eric Seidel.
 204
 205         Make commit-queue and style-queue show up in help
 206         https://bugs.webkit.org/show_bug.cgi?id=31724
 207
 208         We need to store their names on their class to make these commands
 209         properly register themselves with MultiCommandTool.
 210
 211         * Scripts/bugzilla-tool:
 212
 213 2009-11-20  Adam Barth  <abarth@webkit.org>
 214
 215         Reviewed by Eric Seidel.
 216
 217         Implement bugzilla-tool build-attachment
 218         https://bugs.webkit.org/show_bug.cgi?id=31722
 219
 220         This command builds an attachment from bugzilla.  It leaves the built
 221         patch in the working copy.
 222
 223         * Scripts/bugzilla-tool:
 224         * Scripts/modules/landingsequence.py:
 225         * Scripts/modules/webkitlandingscripts.py:
 226
 227 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
 228
 229         Reviewed by Xan Lopez.
 230
 231         [GTK] DRT release event does not create the state correctly
 232         https://bugs.webkit.org/show_bug.cgi?id=31717
 233
 234         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
 235
 236 2009-11-20  Eric Seidel  <eric@webkit.org>
 237
 238         Reviewed by Adam Barth.
 239
 240         MultiCommandTool should find Command objects automatically instead of with a manual list
 241         https://bugs.webkit.org/show_bug.cgi?id=31710
 242
 243         * Scripts/bugzilla-tool:
 244         * Scripts/modules/multicommandtool.py:
 245          - Use some wild python-fu to crawl all the known subclasses of Command.
 246
 247 2009-11-20  Adam Barth  <abarth@webkit.org>
 248
 249         Unreviewed "build" fix.  Added missing import.
 250
 251         * Scripts/bugzilla-tool:
 252
 253 2009-11-20  Adam Barth  <abarth@webkit.org>
 254
 255         Unreviewed "build" fix.  I failed to update LandingSequence.test
 256         properly.
 257
 258         * Scripts/modules/landingsequence.py:
 259
 260 2009-11-20  Adam Barth  <abarth@webkit.org>
 261
 262         Reviewed by Eric Seidel.
 263
 264         Create LandingSequence as the all-sing, all-dance landing class
 265         https://bugs.webkit.org/show_bug.cgi?id=31709
 266
 267         Client can inherit from this class to carefully control exactly which
 268         steps they wish to have happen in the landing sequence.
 269
 270         * Scripts/bugzilla-tool:
 271         * Scripts/modules/landingsequence.py: Added.
 272         * Scripts/modules/webkitlandingscripts.py: Added.
 273
 274 2009-11-19  Adam Barth  <abarth@webkit.org>
 275
 276         Reviewed by Eric Seidel.
 277
 278         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
 279         https://bugs.webkit.org/show_bug.cgi?id=31707
 280
 281         This is to help when we implement build-attachment.
 282
 283         * Scripts/bugzilla-tool:
 284
 285 2009-11-19  Adam Barth  <abarth@webkit.org>
 286
 287         Reviewed by Eric Seidel.
 288
 289         Support Qt port in bugzilla-tool
 290         https://bugs.webkit.org/show_bug.cgi?id=31701
 291
 292         Now we support building with Qt!
 293
 294         * Scripts/bugzilla-tool:
 295         * Scripts/modules/webkitport.py: Added.
 296         * Scripts/modules/webkitport_unittest.py: Added.
 297         * Scripts/run-webkit-unittests:
 298
 299 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
 300
 301         Reviewed by Adam Barth.
 302
 303         Remove inserting stderr into patch in bugzilla-tool
 304         https://bugs.webkit.org/show_bug.cgi?id=29914
 305
 306         Modify SCM python module's run_command function to avoid return of stderr
 307         by default, so stderr won't be inserted into the patches.
 308         Modify the related unit test.
 309
 310         * Scripts/modules/scm.py:
 311         * Scripts/modules/scm_unittest.py:
 312
 313 2009-11-19  Eric Seidel  <eric@webkit.org>
 314
 315         Reviewed by Adam Barth.
 316
 317         bugzilla-tool needs per-command help
 318         https://bugs.webkit.org/show_bug.cgi?id=31697
 319
 320         Added support for "bugzilla-tool help command-name"
 321         and a unit test to make sure it works.
 322
 323         * Scripts/modules/multicommandtool.py:
 324         * Scripts/modules/multicommandtool_unittest.py:
 325
 326 2009-11-19  Eric Seidel  <eric@webkit.org>
 327
 328         Reviewed by Adam Barth.
 329
 330         Move MultiCommandTool and Command into a separate file and add some basic unit tests
 331         https://bugs.webkit.org/show_bug.cgi?id=31695
 332
 333         * Scripts/bugzilla-tool:
 334         * Scripts/modules/multicommandtool.py: Added.
 335         * Scripts/modules/multicommandtool_unittest.py: Added.
 336         * Scripts/run-webkit-unittests:
 337
 338 2009-11-19  Eric Seidel  <eric@webkit.org>
 339
 340         No review, just adding a FIXME.
 341
 342         Split out command parsing and help printing from BugzillaTool
 343         https://bugs.webkit.org/show_bug.cgi?id=31688
 344
 345         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
 346
 347 2009-11-19  Eric Seidel  <eric@webkit.org>
 348
 349         Reviewed by Adam Barth.
 350
 351         Split out command parsing and help printing from BugzillaTool
 352         https://bugs.webkit.org/show_bug.cgi?id=31688
 353
 354         * Scripts/bugzilla-tool:
 355          - Add new MultiCommandTool class to contain option parsing and help printing logic.
 356          - Rename private methods to use _ pattern.
 357          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
 358          -
 359
 360 2009-11-19  Eric Seidel  <eric@webkit.org>
 361
 362         Reviewed by Adam Barth.
 363
 364         Re-factor help printing to use modern python idioms
 365         https://bugs.webkit.org/show_bug.cgi?id=31685
 366
 367         * Scripts/bugzilla-tool:
 368
 369 2009-11-19  Eric Seidel  <eric@webkit.org>
 370
 371         Reviewed by Darin Adler.
 372
 373         commit-queue empty queue logs twice
 374         https://bugs.webkit.org/show_bug.cgi?id=31679
 375
 376         * Scripts/bugzilla-tool:
 377
 378 2009-11-19  Eric Seidel  <eric@webkit.org>
 379
 380         Reviewed by Darin Adler.
 381
 382         bugzilla-tool's reviewer/committer rejection message should be clearer
 383         https://bugs.webkit.org/show_bug.cgi?id=31126
 384
 385         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
 386
 387         * Scripts/modules/bugzilla.py:
 388
 389 2009-11-19  Eric Z. Ayers  <zundel@google.com>
 390
 391         Reviewed by Pavel Feldman.
 392
 393         Forces a WM_PAINT event on calling layoutTestController.display()
 394         in order to enable the timeline-paint.html test on Windows.
 395         ::UpdateWindow() does not force an event becaue the window is
 396         not visible.
 397
 398         https://bugs.webkit.org/show_bug.cgi?id=31402
 399
 400         * DumpRenderTree/win/DumpRenderTree.cpp:
 401         (displayWebView):
 402
 403 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
 404
 405         No review needed.
 406
 407         Added myself to committers list.
 408
 409         * Scripts/modules/committers.py:
 410
 411 2009-11-19  Adam Barth  <abarth@webkit.org>
 412
 413         Reviewed by Eric Seidel.
 414
 415         Bugzilla-tool command classes should match command names
 416         https://bugs.webkit.org/show_bug.cgi?id=31666
 417
 418         I renamed all the commands except CommitMessageForCurrentDiff because
 419         the new name would conflict with an existing class.
 420
 421         * Scripts/bugzilla-tool:
 422
 423 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
 424
 425         Reviewed by Gustavo Noronha Silva.
 426
 427         Web Inspector: Implement "show inspector" in WebKit GTK
 428         API and enable console tests.
 429
 430         https://bugs.webkit.org/show_bug.cgi?id=31669
 431
 432         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 433         (LayoutTestController::showWebInspector):
 434
 435 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 436
 437         Reviewed by Simon Hausmann.
 438
 439         Minor refactoring + more documentation.
 440
 441         * DumpRenderTree/qt/DumpRenderTree.cpp:
 442         (WebCore::clearHistory):
 443         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 444
 445 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
 446
 447         Reviewed by Eric Seidel.
 448
 449         Ignore websocket tests when --no-http is specified.
 450         https://bugs.webkit.org/show_bug.cgi?id=31662
 451
 452         * Scripts/run-webkit-tests:
 453
 454 2009-11-18  Adam Barth  <abarth@webkit.org>
 455
 456         Reviewed by Eric Seidel.
 457
 458         Normalize ' and " in bugzilla-tool
 459         https://bugs.webkit.org/show_bug.cgi?id=31655
 460
 461         We decided " is better than ' and we should be consistent.
 462
 463         * Scripts/bugzilla-tool:
 464
 465 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 466
 467         Reviewed by Kenneth Rohde Christiansen.
 468
 469         [Qt] Remove support for Qt v4.3 or older versions
 470         https://bugs.webkit.org/show_bug.cgi?id=29469
 471
 472         * DumpRenderTree/qt/DumpRenderTree.pro:
 473         * DumpRenderTree/qt/ImageDiff.pro:
 474
 475 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
 476
 477         Reviewed by Eric Seidel.
 478
 479         GitTest.test_create_binary_patch fails if /tmp is symlink
 480         https://bugs.webkit.org/show_bug.cgi?id=31536
 481
 482         * Scripts/modules/scm_unittest.py:
 483
 484 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
 485
 486         Reviewed by Darin Adler.
 487
 488         Configuration for Chromium Build Slaves.
 489
 490         https://bugs.webkit.org/show_bug.cgi?id=31442
 491
 492         * BuildSlaveSupport/build.webkit.org-config/config.json:
 493         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 494
 495 2009-11-18  Eric Seidel  <eric@webkit.org>
 496
 497         Reviewed by Darin Adler.
 498
 499         workqueue.py results in totally broken commit-queue UI
 500         https://bugs.webkit.org/show_bug.cgi?id=31645
 501
 502         * Scripts/bugzilla-tool:
 503          - Remove unneeded use of PatchCollection.
 504          - Grab a new copy of the cq'd patches every run of the queue.
 505
 506 2009-11-18  Sam Weinig  <sam@webkit.org>
 507
 508         Reviewed by Anders Carlsson.
 509
 510         Make the Mac Geolocation API async.
 511
 512         Update DRT to use the new async Mac Geolocation API.
 513
 514         * DumpRenderTree/mac/UIDelegate.mm:
 515         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
 516
 517 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 518
 519         Reviewed by Kenneth Rohde Christiansen.
 520
 521         Add and option to toggle HTML5 datalist support to build-webkit
 522         https://bugs.webkit.org/show_bug.cgi?id=31599
 523
 524         * Scripts/build-webkit:
 525
 526 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
 527
 528         Reviewed by Kevin Ollivier.
 529
 530         Enable wx plugin support using the Windows implementation as a base.
 531
 532         https://bugs.webkit.org/show_bug.cgi?id=31636
 533
 534         * wx/build/settings.py:
 535
 536 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 537
 538         Reviewed by Simon Hausmann.
 539
 540         Change the initialization order so that the controllers
 541         will be created before exporting them to the JS DOM window.
 542
 543         * DumpRenderTree/qt/DumpRenderTree.cpp:
 544         (WebCore::DumpRenderTree::DumpRenderTree):
 545
 546 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 547
 548         Reviewed by Simon Hausmann.
 549
 550         Fix a code copy and paste error. m_page should be page.
 551
 552         * DumpRenderTree/qt/DumpRenderTree.cpp:
 553         (WebCore::DumpRenderTree::createWindow):
 554
 555 2009-11-17  Mark Rowe  <mrowe@apple.com>
 556
 557         Reviewed by Alexey Proskuryakov.
 558
 559         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
 560
 561         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
 562         This prevents symlinks from confusing the descendant check.
 563
 564 2009-11-17  Mark Rowe  <mrowe@apple.com>
 565
 566         Reviewed by Alexey Proskuryakov.
 567
 568         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
 569
 570         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
 571         server to be up rather than having run-webkit-tests abort immediately.
 572
 573         * Scripts/run-webkit-tests:
 574
 575 2009-11-17  Eric Seidel  <eric@webkit.org>
 576
 577         Reviewed by Darin Adler.
 578
 579         commit-queue is failing to set reviewer in ChangeLogs
 580         https://bugs.webkit.org/show_bug.cgi?id=31592
 581
 582         * Scripts/bugzilla-tool: Clarify the "applying" log message.
 583         * Scripts/modules/bugzilla.py:
 584          - Add a new _validate_committer_and_reviewer function as a
 585            temporary solution until we can make a real Attachment object
 586            which knows how to fill in its committer/reviewer fields automatically.
 587
 588 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 589
 590         Unreviewed buildbot fix.
 591
 592         Revert part of earlier patch and add comment, as it
 593         was causing timeouts on the buildbot.
 594
 595         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 596         (LayoutTestController::notifyDone):
 597
 598 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 599
 600         Reviewed by Oliver Hunt.
 601
 602         Make the timeout 15 sec as for the other DRT's and make
 603         it print out the same output when a test timeout.
 604
 605         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 606         (LayoutTestController::waitUntilDone):
 607         (LayoutTestController::notifyDone):
 608         (LayoutTestController::timerEvent):
 609
 610 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
 611
 612         Reviewed by Timothy Hatcher.
 613
 614         Fixed typos in comments.
 615
 616         * Scripts/modules/committers.py:
 617
 618 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
 619
 620         Reviewed by Timothy Hatcher.
 621
 622         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
 623         - Updated DRT to show/close inspector for all tests under /inspector
 624         - Introduced LayoutTestController::setTimelineProfilingEnabled and
 625           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
 626         - Removed reload on each inspector test
 627         - Renamed fast/inspector to fast/inspector-support in order not to trigger
 628         inspector for those.
 629         - Reimplemented timeline tests in order to get rid of reload there.
 630         - Moved tests that don't require harness into the fast group.
 631
 632         https://bugs.webkit.org/show_bug.cgi?id=31472
 633
 634         * DumpRenderTree/LayoutTestController.cpp:
 635         (setTimelineProfilingEnabledCallback):
 636         (closeWebInspectorCallback):
 637         (LayoutTestController::staticFunctions):
 638         * DumpRenderTree/LayoutTestController.h:
 639         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 640         (shouldOpenWebInspector):
 641         (runTest):
 642         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 643         (LayoutTestController::setTimelineProfilingEnabled):
 644         * DumpRenderTree/mac/DumpRenderTree.mm:
 645         (shouldOpenWebInspector):
 646         (runTest):
 647         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 648         (LayoutTestController::setTimelineProfilingEnabled):
 649         * DumpRenderTree/win/DumpRenderTree.cpp:
 650         (shouldOpenWebInspector):
 651         (runTest):
 652         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 653         (LayoutTestController::setTimelineProfilingEnabled):
 654
 655 2009-11-17  Oliver Hunt  <oliver@apple.com>
 656
 657         Reviewed by Maciej Stachowiak.
 658
 659         Incorrect use of JavaScriptCore API in DumpRenderTree
 660         https://bugs.webkit.org/show_bug.cgi?id=31577
 661
 662         Return undefined rather than a literal null.
 663
 664         * DumpRenderTree/AccessibilityUIElement.cpp:
 665         (setSelectedTextRangeCallback):
 666         (incrementCallback):
 667         (decrementCallback):
 668         (showMenuCallback):
 669
 670 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
 671
 672         Reviewed by Beth Dakin.
 673
 674         AX: aria-labelledby duplicates some of its WAI-ARIA label
 675         https://bugs.webkit.org/show_bug.cgi?id=31565
 676
 677         * DumpRenderTree/AccessibilityUIElement.cpp:
 678         (titleUIElementCallback):
 679         (getIsValidCallback):
 680         (AccessibilityUIElement::getJSClass):
 681
 682 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 683
 684         Reviewed by Simon Hausmann.
 685
 686         r50942 broke output from created windows. Make the
 687         m_enableTextOutput a member of the DRT and not the
 688         WebPage.
 689
 690         * DumpRenderTree/qt/DumpRenderTree.cpp:
 691         (WebCore::WebPage::WebPage):
 692         (WebCore::WebPage::javaScriptAlert):
 693         (WebCore::WebPage::javaScriptConsoleMessage):
 694         (WebCore::WebPage::javaScriptConfirm):
 695         (WebCore::WebPage::javaScriptPrompt):
 696         (WebCore::WebPage::acceptNavigationRequest):
 697         (WebCore::DumpRenderTree::DumpRenderTree):
 698         (WebCore::DumpRenderTree::open):
 699         (WebCore::DumpRenderTree::createWindow):
 700         * DumpRenderTree/qt/DumpRenderTree.h:
 701         (WebCore::DumpRenderTree::setTextOutputEnabled):
 702         (WebCore::DumpRenderTree::isTextOutputEnabled):
 703         (WebCore::WebPage::shouldInterruptJavaScript):
 704         (WebCore::WebPage::isTextOutputEnabled):
 705         (WebCore::WebPage::setViewGeometry):
 706
 707 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 708
 709         Reviewed by Gustavo Noronha Silva.
 710
 711         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
 712         as the implementation is being used by at least Qt and Gtk+.
 713
 714         Update buildsystems as well.
 715
 716         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 717         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
 718         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
 719         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
 720         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
 721         * GNUmakefile.am:
 722
 723 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
 724
 725         Reviewed by Alexey Proskuryakov.
 726
 727         Disable wss until all platforms support pyOpenSSL
 728
 729         https://bugs.webkit.org/show_bug.cgi?id=31479
 730
 731         * Scripts/run-webkit-tests:
 732
 733 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
 734
 735         Reviewed by Kenneth Christiansen.
 736
 737         [Qt] Implement load error pages support for Qt's DRT.
 738         https://bugs.webkit.org/show_bug.cgi?id=31509
 739
 740         For now, it will not be a default feature, and layout tests
 741         that want to make use of this have to explicitily call
 742         'handleErrorPages();' for the test source.
 743
 744         Any of the other DumpRenderTree's (mac, win and gtk)
 745         support handling error pages. Qt's will be the first.
 746
 747         * DumpRenderTree/qt/DumpRenderTree.cpp:
 748         (WebCore::WebPage::supportsExtension):
 749         (WebCore::WebPage::extension):
 750         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 751         (LayoutTestController::reset):
 752         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 753         (LayoutTestController::shouldHandleErrorPages):
 754         (LayoutTestController::handleErrorPages):
 755
 756 2009-11-16  Eric Seidel  <eric@webkit.org>
 757
 758         Reviewed by Adam Barth.
 759
 760         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
 761         https://bugs.webkit.org/show_bug.cgi?id=31549
 762
 763         Renamed --commit-queue to --non-interactive in most places
 764         and remove the code in land-patches which is no longer needed.
 765
 766         * Scripts/bugzilla-tool:
 767
 768 2009-11-16  Eric Seidel  <eric@webkit.org>
 769
 770         Reviewed by Adam Barth.
 771
 772         The commit-queue should use land-attachment
 773         https://bugs.webkit.org/show_bug.cgi?id=31548
 774
 775         * Scripts/bugzilla-tool:
 776
 777 2009-11-16  Adam Barth  <abarth@webkit.org>
 778
 779         Reviewed by Eric Seidel.
 780
 781         Convert CommitQueue over to PatchCollection
 782         https://bugs.webkit.org/show_bug.cgi?id=31547
 783
 784         Also fixes a bug in workqueue and adds a test!
 785
 786         * Scripts/bugzilla-tool:
 787         * Scripts/modules/workqueue.py:
 788         * Scripts/modules/workqueue_unittest.py:
 789
 790 2009-11-16  Adam Barth  <abarth@webkit.org>
 791
 792         Reviewed by Eric Seidel.
 793
 794         Move StyleQueue over to using PatchCollection
 795         https://bugs.webkit.org/show_bug.cgi?id=31544
 796
 797         That's what the class it's for.
 798
 799         * Scripts/bugzilla-tool:
 800         * Scripts/modules/patchcollection.py:
 801         * Scripts/modules/patchcollection_unittest.py:
 802
 803 2009-11-16  Eric Seidel  <eric@webkit.org>
 804
 805         Reviewed by Adam Barth.
 806
 807         bugzilla-tool needs a land-attachment command
 808         https://bugs.webkit.org/show_bug.cgi?id=31546
 809
 810         * Scripts/bugzilla-tool:
 811          - Move all the logic into AbstractLandingCommand and
 812            add a new LandAttachment command subclass.
 813          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
 814
 815 2009-11-16  Eric Seidel  <eric@webkit.org>
 816
 817         Reviewed by Adam Barth.
 818
 819         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
 820         https://bugs.webkit.org/show_bug.cgi?id=31543
 821
 822         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
 823
 824         * Scripts/bugzilla-tool:
 825
 826 2009-11-16  Eric Seidel  <eric@webkit.org>
 827
 828         Reviewed by Adam Barth.
 829
 830         Disable the style queue from posting to the commit queue status page.
 831
 832         * Scripts/bugzilla-tool:
 833
 834 2009-11-16  Adam Barth  <abarth@webkit.org>
 835
 836         Reviewed by Eric Seidel.
 837
 838         Implement PatchCollection
 839         https://bugs.webkit.org/show_bug.cgi?id=31541
 840
 841         This class holds a set of patches and lets clients iterate through
 842         them.  Optionally, clients can install a filter.
 843
 844         * Scripts/modules/patchcollection.py: Added.
 845         * Scripts/modules/patchcollection_unittest.py: Added.
 846         * Scripts/run-webkit-unittests:
 847
 848 2009-11-16  Eric Seidel  <eric@webkit.org>
 849
 850         Reviewed by Adam Barth.
 851
 852         bugzilla-tool land-patches will close bugs with patches r=?
 853         https://bugs.webkit.org/show_bug.cgi?id=28230
 854
 855         The commit-queue shouldn't close patches with outstanding reviews on them,
 856         even if many reviewers seem to be against multi-patch bugs.
 857
 858         * Scripts/bugzilla-tool:
 859
 860 2009-11-16  Eric Seidel  <eric@webkit.org>
 861
 862         Reviewed by Adam Barth.
 863
 864         bugzilla-tool check-style should work with attachment ids instead of bug ids
 865         https://bugs.webkit.org/show_bug.cgi?id=31540
 866
 867         * Scripts/bugzilla-tool:
 868
 869 2009-11-16  Eric Seidel  <eric@webkit.org>
 870
 871         Reviewed by Adam Barth.
 872
 873         WorkQueue is the only place that should know about special exit codes
 874         https://bugs.webkit.org/show_bug.cgi?id=31534
 875
 876         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
 877         and add tests for handling exit codes.
 878         I also cleaned up workqueue_unittest.py more.
 879
 880         * Scripts/bugzilla-tool:
 881         * Scripts/modules/workqueue.py:
 882         * Scripts/modules/workqueue_unittest.py:
 883
 884 2009-11-16  Eric Seidel  <eric@webkit.org>
 885
 886         Reviewed by Adam Barth.
 887
 888         Re-factor workqueue_unittest to allow for more than one test.
 889         https://bugs.webkit.org/show_bug.cgi?id=31535
 890
 891         * Scripts/modules/workqueue_unittest.py:
 892
 893 2009-11-16  Eric Seidel  <eric@webkit.org>
 894
 895         Reviewed by Adam Barth.
 896
 897         land-patches needs to be re-factored into smaller chunks
 898         https://bugs.webkit.org/show_bug.cgi?id=31532
 899
 900         * Scripts/bugzilla-tool: fix a couple obvious typos.
 901
 902 2009-11-16  Eric Seidel  <eric@webkit.org>
 903
 904         Reviewed by Adam Barth.
 905
 906         land-patches needs to be re-factored into smaller chunks
 907         https://bugs.webkit.org/show_bug.cgi?id=31532
 908
 909         The next patch will move these methods into WebKitLandingScripts.
 910
 911         * Scripts/bugzilla-tool:
 912          - Split out _land_patch and _close_bug_if_no_active_patches.
 913
 914 2009-11-16  Adam Barth  <abarth@webkit.org>
 915
 916         Reviewed by Eric Seidel.
 917
 918         Fix silly copy-and-paste code.  I am a terrible coder.
 919
 920         * Scripts/modules/bugzilla.py:
 921
 922 2009-11-16  Adam Barth  <abarth@webkit.org>
 923
 924         Reviewed by Eric Seidel.
 925
 926         Implement a StyleQueue
 927         https://bugs.webkit.org/show_bug.cgi?id=31537
 928
 929         The first iteration of the style queue only produces output locally.
 930         There is also a limit of 10 patches because it's not that useful to
 931         iterate through the entire review queue at this point.  We can remove
 932         the limit later.
 933
 934         * Scripts/bugzilla-tool:
 935         * Scripts/modules/bugzilla.py:
 936
 937 2009-11-16  Adam Barth  <abarth@webkit.org>
 938
 939         Reviewed by Eric Seidel.
 940
 941         Unit test WorkQueue
 942         https://bugs.webkit.org/show_bug.cgi?id=31531
 943
 944         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
 945
 946         * Scripts/bugzilla-tool:
 947         * Scripts/modules/statusbot.py:
 948         * Scripts/modules/workqueue.py:
 949         * Scripts/modules/workqueue_unittest.py: Added.
 950         * Scripts/run-webkit-unittests:
 951
 952 2009-11-16  Eric Seidel  <eric@webkit.org>
 953
 954         Reviewed by Adam Barth.
 955
 956         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
 957         https://bugs.webkit.org/show_bug.cgi?id=31530
 958
 959         * Scripts/bugzilla-tool:
 960
 961 2009-11-16  Eric Seidel  <eric@webkit.org>
 962
 963         Reviewed by Adam Barth.
 964
 965         bugzilla-tool needs apply-attachment
 966         https://bugs.webkit.org/show_bug.cgi?id=31528
 967
 968         * Scripts/bugzilla-tool:
 969          - Add ApplyAttachment command.
 970          - Abstract applying code into WebKitApplyingScripts.
 971          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
 972         * Scripts/modules/bugzilla.py:
 973          - Add fetch_attachment and bug_id_for_attachment_id.
 974         * Scripts/modules/bugzilla_unittest.py:
 975          - Add test for new parsing.
 976          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
 977
 978 2009-11-16  Eric Seidel  <eric@webkit.org>
 979
 980         Reviewed by Adam Barth.
 981
 982         Document check-style's use of force_clean.
 983
 984         * Scripts/bugzilla-tool:
 985         * Scripts/modules/scm.py:
 986
 987 2009-11-16  Adam Barth  <abarth@webkit.org>
 988
 989         Reviewed by Eric Seidel.
 990
 991         Move WorkQueue to its own file
 992         https://bugs.webkit.org/show_bug.cgi?id=31529
 993
 994         WorkQueue and WorkQueueDelegate are separate concerns from
 995         bugzilla-tool.  Also added a missing include to logging.py.
 996
 997         * Scripts/bugzilla-tool:
 998         * Scripts/modules/logging.py:
 999         * Scripts/modules/workqueue.py:
1000
1001 2009-11-16  Adam Barth  <abarth@webkit.org>
1002
1003         Reviewed by Eric Seidel.
1004
1005         Move OutputTee to logging.py.
1006
1007         * Scripts/bugzilla-tool:
1008         * Scripts/modules/logging.py:
1009
1010 2009-11-15  Adam Barth  <abarth@webkit.org>
1011
1012         Reviewed by Eric Seidel.
1013
1014         Refactor bugzilla-tool to allow for multiple queues
1015         https://bugs.webkit.org/show_bug.cgi?id=31513
1016
1017         Divide the commit queue class into three class to make creating
1018         additional queues easier.
1019
1020         * Scripts/bugzilla-tool:
1021
1022 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1023
1024         Reviewed by Eric Seidel.
1025
1026         svn-apply may not handle git patches created by bugzilla-tool
1027         https://bugs.webkit.org/show_bug.cgi?id=31457
1028
1029         * Scripts/modules/scm.py:
1030         * Scripts/modules/scm_unittest.py:
1031
1032 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1033
1034         Reviewed by Eric Seidel.
1035
1036         bugzilla-tool should post git binary diff
1037         https://bugs.webkit.org/show_bug.cgi?id=31458
1038
1039         Add --binary option to Git.create_patch.
1040
1041         * Scripts/modules/scm.py:
1042         * Scripts/modules/scm_unittest.py:
1043
1044 2009-11-15  Adam Barth  <abarth@webkit.org>
1045
1046         Reviewed by Darin Adler.
1047
1048         Add bugzilla-tool check-style
1049         https://bugs.webkit.org/show_bug.cgi?id=31515
1050
1051         * Scripts/bugzilla-tool:
1052         * Scripts/modules/bugzilla.py:
1053
1054 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1055
1056         Reviewed by Simon Hausmann.
1057
1058         Make the Qt Linux only --valgrind feature, suppress errors
1059         defined in the SuppressedValgrindErrors file.
1060
1061         * Scripts/run-webkit-tests:
1062
1063 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1064
1065         Reviewed by Simon Hausmann.
1066
1067         Set the locale to C and not to the current one in use on the system.
1068
1069         * DumpRenderTree/qt/DumpRenderTree.cpp:
1070         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1071
1072 2009-11-13  Adam Roben  <aroben@apple.com>
1073
1074         Add support for
1075         http/tests/security/isolatedWorld/didClearWindowObject.html
1076
1077         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1078         window objects in isolated worlds are cleared
1079
1080         Reviewed by Dave Hyatt.
1081
1082         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1083
1084         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1085         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1086         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1087         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1088         Added. Sets a __worldID property on the global object whose value is
1089         the ID of this world.
1090         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1091         Respond to this new delegate callback by calling through to one of the
1092         above new methods.
1093         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1094         (worldMap): Added. Returns a HashMap containing all the worlds we've
1095         created.
1096         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1097         haven't kept track of this world.
1098         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1099         instead of declaring our own.
1100
1101         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1102
1103         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1104         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1105         didClearWindowObjectForFrameInStandardWorld.
1106         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1107         Respond to this new delegate callback by calling through to one of the
1108         below new methods.
1109         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1110         Added. Sets a __worldID property on the gobal object whose value is
1111         the ID of this world.
1112         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1113         Added. Moved code here from didClearWindowObject.
1114
1115         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1116         didClearWindowObjectForFrame* functions.
1117
1118         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1119         (worldMap): Added. Returns a HashMap containing all the worlds we've
1120         created.
1121         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1122         haven't kept track of this world.
1123         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1124         instead of declaring our own.
1125
1126 2009-11-13  Adam Roben  <aroben@apple.com>
1127
1128         Finish replacing worldIDs with world objects
1129
1130         The only remaining use of worldIDs was in a method only used by DRT
1131         for the isolated worlds tests.
1132
1133         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1134
1135         Reviewed by Mark Rowe.
1136
1137         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1138         (LayoutTestController::evaluateScriptInIsolatedWorld):
1139         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1140         (LayoutTestController::evaluateScriptInIsolatedWorld):
1141         Updated for changes to WebFrame. Now holds the map of worldID -> world
1142         at this level instead of making WebKit do it.
1143
1144 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1145
1146         Reviewed by Simon Hausmann.
1147
1148         [Qt] Ensure the DRT does not output anything until first test is run
1149
1150         * DumpRenderTree/qt/DumpRenderTree.cpp:
1151         * DumpRenderTree/qt/DumpRenderTree.h:
1152
1153 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1154
1155         Reviewed by Tor Arne Vestbø.
1156
1157         Clear the undo stack in before each new test run.
1158
1159         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1160
1161         * DumpRenderTree/qt/DumpRenderTree.cpp:
1162         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1163
1164 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1165
1166         Reviewed by Kenneth Rohde Christiansen.
1167
1168         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1169
1170         * DumpRenderTree/qt/DumpRenderTree.cpp:
1171         (WebCore::WebPage::resetSettings):
1172         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1173         (LayoutTestController::overridePreference):
1174
1175 2009-11-13  Eric Seidel  <eric@webkit.org>
1176
1177         Reviewed by Adam Barth.
1178
1179         Update committers.py based on svn records
1180         https://bugs.webkit.org/show_bug.cgi?id=31366
1181
1182         This list was generated using validate-committer-lists from
1183         https://bugs.webkit.org/show_bug.cgi?id=30970
1184         and makes committers.py current for committers who have
1185         committed in the last 3 years.
1186
1187         * Scripts/modules/committers.py:
1188
1189 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1190
1191         Reviewed by Adam Barth.
1192
1193         The document-open.html test was flaky at times. The test invokes the layout test plugin
1194         which in its destroy stream handler opens a new document. This basically tears down the
1195         stream and the associated plugin instance. The pluginLog function in the layout test
1196         plugin attempts to retrieve the window script object on a torn down plugin instance
1197         which crashed consistently on windows in the debugger. The functions which issue
1198         these logs already have a valid window script object. We now have variants of the pluginLog
1199         function which take in a window script object with and without variable arguments.
1200
1201         https://bugs.webkit.org/show_bug.cgi?id=31067
1202
1203         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1204         (pluginLogWithWindowObject):
1205         (pluginLogWithWindowObjectVariableArgs):
1206         (pluginLog):
1207         (notifyTestCompletion):
1208         (testDocumentOpen):
1209         (testWindowOpen):
1210
1211 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1212
1213         Reviewed by Gustavo Noronha Silva.
1214
1215         https://bugs.webkit.org/show_bug.cgi?id=30997
1216         [Gtk] Implemment AtkDocument
1217
1218         Added testing support.
1219
1220         * DumpRenderTree/AccessibilityUIElement.cpp:
1221         * DumpRenderTree/AccessibilityUIElement.h:
1222         (getDocumentEncodingCallback):
1223         (getDocumentURICallback):
1224         (AccessibilityUIElement::getJSClass):
1225         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1226         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1227         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1228         (AccessibilityUIElement::documentEncoding):
1229         (AccessibilityUIElement::documentURI):
1230
1231 2009-11-12  Adam Roben  <aroben@apple.com>
1232
1233         Replace worldIDs with world objects
1234
1235         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1236         user scripts/stylesheets and isolated worlds
1237
1238         Reviewed by Sam Weinig.
1239
1240         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1241         (LayoutTestController::addUserScript):
1242         (LayoutTestController::addUserStyleSheet):
1243         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1244         (LayoutTestController::addUserScript):
1245         (LayoutTestController::addUserStyleSheet):
1246         Changed these functions to create a new WebJSWorld each time they're
1247         called and to pass that world to WebKit.
1248
1249 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1250
1251         Reviewed by Oliver Hunt.
1252
1253         need to implement aria tree roles
1254         https://bugs.webkit.org/show_bug.cgi?id=31284
1255
1256         * DumpRenderTree/AccessibilityUIElement.cpp:
1257         (disclosedRowAtIndexCallback):
1258         (selectedRowAtIndexCallback):
1259         (isEqualCallback):
1260         (isAttributeSettableCallback):
1261         (isActionSupportedCallback):
1262         (disclosedByRowCallback):
1263         (hierarchicalLevelCallback):
1264         (AccessibilityUIElement::getJSClass):
1265         * DumpRenderTree/AccessibilityUIElement.h:
1266         (AccessibilityUIElement::isEqual):
1267         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1268         (AccessibilityUIElement::hierarchicalLevel):
1269         (AccessibilityUIElement::disclosedRowAtIndex):
1270         (AccessibilityUIElement::selectedRowAtIndex):
1271         (AccessibilityUIElement::disclosedByRow):
1272         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1273         (AccessibilityUIElement::getChildAtIndex):
1274         (AccessibilityUIElement::disclosedRowAtIndex):
1275         (AccessibilityUIElement::selectedRowAtIndex):
1276         (AccessibilityUIElement::titleUIElement):
1277         (AccessibilityUIElement::parentElement):
1278         (AccessibilityUIElement::disclosedByRow):
1279         (AccessibilityUIElement::hierarchicalLevel):
1280         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1281         (AccessibilityUIElement::hierarchicalLevel):
1282         (AccessibilityUIElement::disclosedRowAtIndex):
1283         (AccessibilityUIElement::selectedRowAtIndex):
1284         (AccessibilityUIElement::disclosedByRow):
1285
1286 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1287
1288         Reviewed by Darin Adler.
1289
1290         svn-apply can not handle git binary diffs
1291         https://bugs.webkit.org/show_bug.cgi?id=26830
1292
1293         Support "literal" type git binary diffs.
1294
1295         * Scripts/VCSUtils.pm:
1296         * Scripts/modules/scm_unittest.py:
1297         * Scripts/svn-apply:
1298
1299 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1300
1301         Not reviewed, removing duplicate entry for myself in committers.py.
1302
1303         * Scripts/modules/committers.py:
1304
1305 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1306
1307         Reviewed by Darin Adler and Mark Rowe.
1308
1309         https://bugs.webkit.org/show_bug.cgi?id=31200
1310         Tests in http/tests/security/mixedContent start to fail when new tests are added
1311
1312         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1313
1314 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1315
1316         Reviewed by Jan Alonzo.
1317
1318         Create, and display a window for the inspector, for inspector
1319         tests.
1320
1321         Need to also show/hide the inspector window to avoid having
1322         problems with code assuming it is realized
1323         https://bugs.webkit.org/show_bug.cgi?id=31347
1324
1325         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1326         (webInspectorShowWindow):
1327         (webInspectorCloseWindow):
1328         (webInspectorInspectWebView):
1329         (createWebView):
1330
1331 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1332
1333         Unreviewed Qt buildbot fix.
1334
1335         My previous fix was wrong, so revert that change and fix it by
1336         returning when the document of the frame has no document element.
1337         Idea is borrowed from mac and win DRT.
1338
1339         * DumpRenderTree/qt/DumpRenderTree.cpp:
1340         (WebCore::DumpRenderTree::dumpFramesAsText):
1341
1342 2009-11-11  Eric Seidel  <eric@webkit.org>
1343
1344         Reviewed byg Kenneth Rohde Christiansen.
1345
1346         Update Kenneth's committer record to include the email he
1347         uses on lists.webkit.org.
1348
1349         * Scripts/modules/committers.py:
1350
1351 2009-11-11  Eric Seidel  <eric@webkit.org>
1352
1353         Reviewed by Gustavo Noronha Silva.
1354
1355         Several committers use separate email addresses for bugzilla and svn.webkit.org
1356         https://bugs.webkit.org/show_bug.cgi?id=31364
1357
1358         Update records for existing committers to include email addresses
1359         used in svn.webkit.org and lists.webkit.org.
1360         Most committers use the same email address in all 3 places, but some use
1361         separate addresses.  committers.py needs record of each of these addresses.
1362
1363         * Scripts/modules/committers.py:
1364
1365 2009-11-11  Eric Seidel  <eric@webkit.org>
1366
1367         No review, adding second email address for an existing committer.
1368
1369         Add Yong Li's second bugzilla account to his committer record.
1370         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1371
1372         * Scripts/modules/committers.py:
1373
1374 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1375
1376         Reviewed by Simon Hausmann.
1377
1378         If the frame has no innerText don't append it, and
1379         do not add a newline which breaks some cross platform
1380         results.
1381
1382         * DumpRenderTree/qt/DumpRenderTree.cpp:
1383         (WebCore::DumpRenderTree::dumpFramesAsText):
1384
1385 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1386
1387         Reviewed by Simon Hausmann.
1388
1389         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1390
1391         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1392         (webkit_test_plugin_new_instance):
1393         (webkit_test_plugin_destroy_instance):
1394         (webkit_test_plugin_destroy_stream):
1395
1396 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1397
1398         Reviewed by Mark Rowe.
1399
1400         Implement the functionality needed by plugins/window-open.html
1401
1402         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1403         (webkit_test_plugin_new_instance):
1404         (webkit_test_plugin_set_window):
1405
1406 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1407
1408         Reviewed by Simon Hausmann.
1409
1410         [Qt] Force -graphicssystem raster and -style windows when running DRT
1411
1412         * DumpRenderTree/qt/main.cpp:
1413         * Scripts/run-webkit-tests:
1414
1415 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1416
1417         Reviewed by Simon Hausmann.
1418
1419         Compute correct library paths for Qt
1420
1421         * Scripts/webkitdirs.pm:
1422
1423 2009-11-10  Mark Rowe  <mrowe@apple.com>
1424
1425         Reviewed by Sam Weinig.
1426
1427         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1428
1429         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1430         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1431         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1432         that had enabled frame load delegate logging this would result in extra log messages being generated,
1433         causing the test to fail.
1434
1435         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1436         tests.
1437
1438         * DumpRenderTree/mac/DumpRenderTree.mm:
1439         (dumpRenderTree):
1440         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1441         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1442
1443 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1444
1445         Reviewed by Kenneth Rohde Christiansen.
1446
1447         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1448
1449         * DumpRenderTree/qt/DumpRenderTree.cpp:
1450         (WebCore::DumpRenderTree::DumpRenderTree):
1451
1452 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1453
1454         Reviewed by Jan Alonzo.
1455
1456         [GTK] Remove WebSocket configuration from WebKitWebSettings
1457         https://bugs.webkit.org/show_bug.cgi?id=31244
1458
1459         Follow-up of r50724. Don't set the enable-web-socket property
1460         anymore.
1461
1462         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1463         (resetDefaultsToConsistentValues):
1464
1465 2009-11-10  Oliver Hunt  <oliver@apple.com>
1466
1467         Reviewed by Maciej Stachowiak.
1468
1469         Rename 3D Canvas related classes to use WebGL prefix
1470         https://bugs.webkit.org/show_bug.cgi?id=29095
1471
1472         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1473         and upate webkitdirs script to new method of testing for WebGL.
1474
1475         * Scripts/do-webcore-rename:
1476         * Scripts/webkitdirs.pm:
1477
1478 2009-11-09  Oliver Hunt  <oliver@apple.com>
1479
1480         Reviewed by Geoff Garen.
1481
1482         Make do-webcore-rename work with git.
1483
1484         * Scripts/do-webcore-rename:
1485
1486 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1487
1488         Adding Kenneth to the reviewers list.
1489
1490         * Scripts/modules/committers.py:
1491
1492 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1493
1494         Reviewed by Jan Alonzo.
1495
1496         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1497         https://bugs.webkit.org/show_bug.cgi?id=30482
1498
1499         LayoutTestControllerGtk now uses the exposed
1500         Page::tabKeyCyclesThroughElements API
1501
1502         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1503         (LayoutTestController::setTabKeyCyclesThroughElements):
1504
1505 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1506
1507         Reviewed by Holger Freyther.
1508
1509         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1510         This helps to pass the test case below. Also replaced hardcoded
1511         code numbers with defined constants.
1512         https://bugs.webkit.org/show_bug.cgi?id=31185
1513
1514         Test: editing/undo/undo-deleteWord.html
1515
1516         * DumpRenderTree/qt/EventSenderQt.cpp:
1517         (EventSender::keyDown):
1518
1519 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1520
1521         Reviewed by Holger Freyther.
1522
1523         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1524         https://bugs.webkit.org/show_bug.cgi?id=31164
1525
1526         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1527
1528         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1529         (LayoutTestController::processWork):
1530
1531 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1532
1533         Reviewed by Holger Freyther.
1534
1535         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1536         https://bugs.webkit.org/show_bug.cgi?id=31158
1537
1538         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1539         always, which from WorkQueue prospective means that a load has been started
1540         and the queue processing should stop and wait for the load to finish.
1541         Spinning it off into a loading and a non-loading variants was the solution
1542         adopted by Mac's DRT to work around this problem. The former keeps returning
1543         'true' while the later executes the script synchronously and returns 'false'
1544         making it possible to the WorkQueue to proceed right away.
1545
1546         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1547         (LayoutTestController::processWork):
1548         (LayoutTestController::queueLoadingScript):
1549         (LayoutTestController::queueNonLoadingScript):
1550         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1551         * DumpRenderTree/qt/WorkQueueItem.h:
1552         (LoadingScriptItem::LoadingScriptItem):
1553         (LoadingScriptItem::invoke):
1554         (NonLoadingScriptItem::NonLoadingScriptItem):
1555         (NonLoadingScriptItem::invoke):
1556
1557 2009-11-07  Mark Rowe  <mrowe@apple.com>
1558
1559         Rubber-stamped by Cameron Zwarich.
1560
1561         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1562
1563         * Scripts/commit-log-editor:
1564
1565 2009-11-07  Mark Rowe  <mrowe@apple.com>
1566
1567         Reviewed by Darin Adler.
1568
1569         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1570         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1571
1572         Move logic for determining the name and email address to use in a ChangeLog entry from
1573         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1574         whether the author of the patch matches committer, and therefore needs access to the
1575         email address that would be used in a ChangeLog entry.
1576
1577         Based on a patch by Pierre d'Herbemont.
1578
1579         * Scripts/VCSUtils.pm:
1580         * Scripts/commit-log-editor:
1581         * Scripts/prepare-ChangeLog:
1582         * Scripts/webkitdirs.pm:
1583
1584 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1585
1586         Reviewed by Adam Barth.
1587
1588         Added functionality to the layout test plugin to invoke document.open and
1589         window.open with default arguments. The associated webkit bug is
1590         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1591         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1592         work in Chromium (V8) if there is no calling javascript context. To achieve this
1593         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1594         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1595
1596         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1597         (testDocumentOpen):
1598         (testWindowOpen):
1599         (pluginAllocate):
1600         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1601         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1602         (NPP_New):
1603         (NPP_SetWindow):
1604         (NPP_DestroyStream):
1605         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1606         (NPP_New):
1607         (NPP_SetWindow):
1608         (NPP_NewStream):
1609         (NPP_DestroyStream):
1610
1611 2009-11-06  Eric Seidel  <eric@webkit.org>
1612
1613         Reviewed by Adam Barth.
1614
1615         bugzilla-tool crashed with exception
1616         https://bugs.webkit.org/show_bug.cgi?id=31092
1617
1618         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1619
1620 2009-11-04  Eric Seidel  <eric@webkit.org>
1621
1622         No review, just add a line which got left out of the patch uploaded for commit.
1623
1624         commit-queue is crashing when trying to reject patches after unknown failures
1625         https://bugs.webkit.org/show_bug.cgi?id=31091
1626
1627         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1628
1629 2009-11-04  Adam Roben  <aroben@apple.com>
1630
1631         Remove bogus else clause in bugzilla-tool
1632
1633         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1634         create-bug raises exception after entering bug description
1635
1636         Reviewed by David Kilzer.
1637
1638         * Scripts/bugzilla-tool:
1639         (CreateBug): else clauses are only hit if no exception is raised, so
1640         it makes no sense to try to re-raise the exception in an else clause.
1641         The exception will automatically be re-raised if it doesn't match any
1642         of the except clauses, so we don't have to do anything special here at
1643         all to get the desired behavior.
1644
1645 2009-11-04  Eric Seidel  <eric@webkit.org>
1646
1647         Reviewed by David Kilzer.
1648
1649         svn-apply's fixChangeLogPatch function seems broken
1650         https://bugs.webkit.org/show_bug.cgi?id=30683
1651
1652         Update fixChangeLogPatch to be able to handle patches which
1653         don't start at line 1.
1654         Add unit tests for svn-apply to scm_unittest.py.
1655
1656         * Scripts/VCSUtils.pm:
1657         * Scripts/modules/scm_unittest.py:
1658
1659 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1660
1661         Reviewed by Beth Dakin.
1662
1663         Need to implement ARIA role="combobox"
1664         https://bugs.webkit.org/show_bug.cgi?id=31096
1665
1666         * DumpRenderTree/AccessibilityUIElement.cpp:
1667         (showMenuCallback):
1668         (getIsExpandedCallback):
1669         (AccessibilityUIElement::getJSClass):
1670         * DumpRenderTree/AccessibilityUIElement.h:
1671         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1672         (AccessibilityUIElement::isExpanded):
1673         (AccessibilityUIElement::showMenu):
1674         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1675         (AccessibilityUIElement::isExpanded):
1676         (AccessibilityUIElement::showMenu):
1677         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1678         (AccessibilityUIElement::isSelected):
1679         (AccessibilityUIElement::isExpanded):
1680         (AccessibilityUIElement::showMenu):
1681
1682 2009-11-04  Eric Seidel  <eric@webkit.org>
1683
1684         Reviewed by Adam Barth.
1685
1686         commit-queue is crashing when trying to reject patches after unknown failures
1687         https://bugs.webkit.org/show_bug.cgi?id=31091
1688
1689         * Scripts/bugzilla-tool:
1690          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1691            so we have to find out what the current patch is by asking bugzilla again.
1692          - Discovered that this code was also leaking file descriptors, so fixed that.
1693
1694 2009-11-04  Adam Roben  <aroben@apple.com>
1695
1696         Make run-webkit-tests work for the Debug_Internal Windows
1697         configuration
1698
1699         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1700         suffix.
1701
1702         Fixes <http://webkit.org/b/31123>.
1703
1704         Reviewed by Sam Weinig.
1705
1706         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1707         Debug_Internal, either.
1708
1709 2009-11-04  Eric Seidel  <eric@webkit.org>
1710
1711         Reviewed by Adam Barth.
1712
1713         committers.py needs a way to store non-bugzilla email addresses
1714         https://bugs.webkit.org/show_bug.cgi?id=31037
1715
1716         Make Committer and Reviewer constructors take a single email or a list of emails.
1717         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1718         Expose reviewers(), used by validate-committer-lists on bug 30970.
1719
1720         * Scripts/modules/committers.py:
1721         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1722
1723 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1724
1725         Reviewed by David Levin.
1726
1727         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1728         https://bugs.webkit.org/show_bug.cgi?id=27491
1729
1730         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1731         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1732
1733         Functions to start or stop Web Socket servers are added.
1734
1735         * Scripts/run-webkit-tests:
1736
1737 2009-11-03  Eric Seidel  <eric@webkit.org>
1738
1739         No review, just changing wording of log message.
1740
1741         Change log string to say "failed" instead of "rejected"
1742         when a commit fails due to an out of date checkout.
1743         This makes grepping the commit-queue log for rejected patches easier.
1744
1745         * Scripts/bugzilla-tool:
1746
1747 2009-11-03  Eric Seidel  <eric@webkit.org>
1748
1749         No review, adding commonly known committers missing from the file.
1750
1751         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1752
1753 2009-11-03  Eric Seidel  <eric@webkit.org>
1754
1755         No review, just sort-order cleanup.
1756
1757         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1758
1759 2009-11-03  Stephen White  <senorblanco@chromium.org>
1760
1761         (Unreviewed).
1762
1763         Add myself to committers.py.
1764
1765         * Scripts/modules/committers.py:
1766
1767 2009-11-03  Robin Dunn  <robin@alldunn.com>
1768
1769         Reviewed by Kevin Ollviier.
1770
1771         Add packaging scripts for Debian-based Linux distros.
1772
1773         https://bugs.webkit.org/show_bug.cgi?id=31075
1774
1775         * wx/packaging/build-debian-installer.py: Added.
1776         * wx/packaging/debian: Added.
1777
1778 2009-11-03  Dan Bernstein  <mitz@apple.com>
1779
1780         Reviewed by Anders Carlsson and Beth Dakin.
1781
1782         https://bugs.webkit.org/show_bug.cgi?id=31070
1783
1784         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1785         destroyed, it executes the value of the 'ondestroy' parameter as a
1786         script.
1787
1788         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1789         (pluginAllocate): Initialize onDestroy.
1790         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1791         onDestroy.
1792         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1793         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
1794         specified.
1795         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
1796
1797 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1798
1799         Reviewed by Xan Lopez.
1800
1801         https://bugs.webkit.org/show_bug.cgi?id=31035
1802         [GTK] some accessibility tests hitting assertion in debug builds
1803
1804         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
1805
1806         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1807         (AccessibilityController::rootElement):
1808
1809 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
1810
1811         Reviewed by Beth Dakin.
1812
1813         Support ARIA "tab" roles
1814         https://bugs.webkit.org/show_bug.cgi?id=30842
1815
1816         * DumpRenderTree/AccessibilityUIElement.cpp:
1817         * DumpRenderTree/AccessibilityUIElement.h:
1818         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1819         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1820         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1821
1822 2009-11-01  Eric Seidel  <eric@webkit.org>
1823
1824         Reviewed by David Levin.
1825
1826         buildbots should use --exit-after-N-failures
1827         https://bugs.webkit.org/show_bug.cgi?id=30809
1828
1829         Make the bots exit after 20 failures to prevent never-ending
1830         test runs where every test spends a minute crashing.
1831
1832         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1833
1834 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1835
1836         Reviewed by Eric Seidel.
1837
1838         Turn on warnings for QtWebKit for gcc
1839         https://bugs.webkit.org/show_bug.cgi?id=30958
1840
1841         * DumpRenderTree/qt/main.cpp:
1842         (crashHandler): Mark function NO_RETURN
1843
1844 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
1845
1846         Adding myself to the committers list.
1847
1848         * Scripts/modules/committers.py:
1849
1850 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
1851
1852         Fix an issue that Adam noticed in DRT.
1853
1854         Reviewed by Darin Adler.
1855
1856         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1857         (AccessibilityUIElement::role):
1858         Get the length of the role text, and create a buffer dynamically.
1859
1860 2009-10-30  Eric Seidel  <eric@webkit.org>
1861
1862         No review, rolling out r50105.
1863         http://trac.webkit.org/changeset/50105
1864
1865         This commit was causing:
1866         https://bugs.webkit.org/show_bug.cgi?id=30869
1867         We'll re-implement the feature a different way.
1868
1869         * Scripts/bugzilla-tool:
1870
1871 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1872
1873         Test for MSAA: Accessibility of headings is not correct
1874
1875         https://bugs.webkit.org/show_bug.cgi?id=30937
1876
1877         Reviewed by Adam Roben.
1878
1879         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1880         (AccessibilityUIElement::role):
1881         Allow the role returned to be a BSTR.
1882         (AccessibilityUIElement::description):
1883         Fix a copy/paste error.
1884
1885 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1886
1887         Test for MSAA: Accessibility of links is wrong
1888
1889         https://bugs.webkit.org/show_bug.cgi?id=30928
1890
1891         Reviewed by Darin Adler.
1892
1893         * DumpRenderTree/AccessibilityUIElement.cpp:
1894         (getAccessibilityValueCallback):
1895         Return the accessibility value.
1896         (AccessibilityUIElement::getJSClass):
1897         Added "accessibilityValue" value.
1898
1899         * DumpRenderTree/AccessibilityUIElement.h:
1900
1901         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1902         (AccessibilityUIElement::accessibilityValue):
1903         Stubbed.
1904
1905         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1906         (AccessibilityUIElement::accessibilityValue):
1907         Stubbed.
1908
1909         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1910         (AccessibilityUIElement::accessibilityValue):
1911         Get the object's value, and return it as a JS string.
1912
1913 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
1914
1915         Fix typo in command name used by wx build system.
1916
1917         * wx/build/build_utils.py:
1918
1919 2009-10-30  Adam Barth  <abarth@webkit.org>
1920
1921         Reviewed by Darin Adler.
1922
1923         Patch v1 is a dumb default name for patches
1924         https://bugs.webkit.org/show_bug.cgi?id=30952
1925
1926         Let's use "Patch" instead.
1927
1928         * Scripts/bugzilla-tool:
1929
1930 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1931
1932         Unreviewed trivial buildfix.
1933
1934         [Qt] Buildfix for r50333.
1935
1936         * DumpRenderTree/qt/DumpRenderTree.pro:
1937
1938 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
1939
1940         Reviewed by Holger Freyther.
1941
1942         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
1943         https://bugs.webkit.org/show_bug.cgi?id=30953
1944
1945         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
1946         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
1947         makes qt DRT to share this implementation (as gtk and mac ports do).
1948
1949         * DumpRenderTree/qt/DumpRenderTree.pro:
1950         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
1951         * DumpRenderTree/qt/WorkQueue.h: Removed.
1952
1953 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1954
1955         Unreviewed potential buildbot fix.
1956
1957         Second try: Reset page history before running each test.
1958
1959         Apparently the QWebHistory::clear() keeps the current page
1960         in history which is not what we want, so we not additionally
1961         sets the history capacity to 0 (forces removing everything)
1962         and then sets it back to its original value.
1963
1964         * DumpRenderTree/qt/DumpRenderTree.cpp:
1965         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1966
1967 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1968
1969         Unreviewed potential buildbot fix.
1970
1971         Reset page history before running each test.
1972
1973         * DumpRenderTree/qt/DumpRenderTree.cpp:
1974         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1975
1976 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
1977
1978         Reviewed by Eric Seidel.
1979
1980         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
1981
1982         Bug 28420 -  Implement HTML5 <ruby> rendering
1983         (https://bugs.webkit.org/show_bug.cgi?id=28420)
1984
1985         No new tests (no functional change).
1986
1987         * Scripts/build-webkit:
1988
1989 2009-10-29  Dan Bernstein  <mitz@apple.com>
1990
1991         Reviewed by Mark Rowe.
1992
1993         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
1994         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
1995         define it.
1996
1997         * Scripts/VCSUtils.pm:
1998         * Scripts/svn-apply:
1999         * Scripts/svn-unapply:
2000
2001 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2002
2003         Reviewed by Gustavo Noronha.
2004
2005         Use the GTK+ main loop instead of rolling our own mini-version of
2006         it.
2007
2008         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2009         (dump):
2010         (runTest):
2011         (webViewLoadFinished):
2012
2013 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2014
2015         Reviewed by Oliver Hunt.
2016
2017         Implement the Qt version of DRT dumpBackForwardList().
2018
2019         * DumpRenderTree/qt/DumpRenderTree.cpp:
2020         (WebCore::dumpHistoryItem):
2021         (WebCore::DumpRenderTree::dumpBackForwardList):
2022
2023 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2024
2025         Reviewed by Adam Roben.
2026
2027         Implement DRT functionality for Qt introduced in
2028         r28690 and r28705.
2029
2030         - Implemented pathToLocalResource which exposes the functionality of
2031         converting a given unix path to the correct location on Windows.
2032         - Implemented a way to remove machine-dependent information from paths
2033         in layout test results.
2034
2035         * DumpRenderTree/qt/DumpRenderTree.cpp:
2036         (WebCore::urlSuitableForTestResult):
2037         (WebCore::WebPage::javaScriptConsoleMessage):
2038         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2039         (LayoutTestController::pathToLocalResource):
2040         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2041
2042 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2043
2044         Adding myself to the committers list.
2045
2046         * Scripts/modules/committers.py:
2047
2048 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2049
2050         Adding myself to the committers list.
2051
2052         * Scripts/modules/committers.py:
2053
2054 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2055
2056         Reviewed by Jan Alonzo.
2057
2058         [GTK] API to start inspector for a WebView
2059         https://bugs.webkit.org/show_bug.cgi?id=22551
2060
2061         Use the new inspector API to implement the LayoutTestController
2062         interfaces used to test the inspector.
2063
2064         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2065         (webInspectorInspectWebView):
2066         (createWebView):
2067         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2068         (LayoutTestController::showWebInspector):
2069         (LayoutTestController::closeWebInspector):
2070         (LayoutTestController::evaluateInWebInspector):
2071
2072 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2073
2074         Reviewed by Eric Seidel.
2075
2076         [Qt] WebFrame::counterValueForElementById must not be exposed
2077         https://bugs.webkit.org/show_bug.cgi?id=30882
2078
2079         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2080         (LayoutTestController::counterValueForElementById):
2081
2082 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2083
2084         Rubberstamped by Oliver Hunt.
2085
2086         Fix the warning:
2087
2088         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2089         declared with attribute warn_unused_result".
2090
2091         by actually checking the result. In the case it is null, an
2092         error has occoured, so treat it as the other fatal errors.
2093
2094         * DumpRenderTree/qt/DumpRenderTree.cpp:
2095         (WebCore::DumpRenderTree::initializeFonts):
2096
2097 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2098
2099         Reviewed by Darin Adler.
2100
2101         Provide a way to get counter values with layoutTestContoller
2102         https://bugs.webkit.org/show_bug.cgi?id=30555
2103
2104         Define layoutTestContoller.counterValueForElementById.
2105
2106         * DumpRenderTree/LayoutTestController.cpp:
2107         (counterValueForElementByIdCallback):
2108         (LayoutTestController::staticFunctions):
2109         * DumpRenderTree/LayoutTestController.h:
2110         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2111         (LayoutTestController::counterValueForElementById):
2112
2113 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2114
2115         Rubberstamped by Oliver Hunt.
2116
2117         Change two methods to be internal for DRT use only.
2118
2119         Part of [Qt] Review all new API in Qt 4.6
2120         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2121
2122         * DumpRenderTree/qt/DumpRenderTree.cpp:
2123         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2124         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2125         (LayoutTestController::whiteListAccessFromOrigin):
2126
2127 2009-10-27  Eric Seidel  <eric@webkit.org>
2128
2129         Reviewed by Adam Barth.
2130
2131         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2132         https://bugs.webkit.org/show_bug.cgi?id=30826
2133
2134         * Scripts/svn-apply:
2135          - Add () around all system() calls.
2136          - Use the correct system() == 0 or die instead of system() or die
2137          - Add descriptive messages to all die statements.
2138
2139 2009-10-27  Steve Block  <steveblock@google.com>
2140
2141         Reviewed by NOBODY.
2142
2143         Adds steveblock@google.com to list of committers.
2144
2145         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2146
2147 2009-10-27  Eric Seidel  <eric@webkit.org>
2148
2149         Reviewed by Adam Barth.
2150
2151         svn-apply can exit(0) even on patch failure
2152         https://bugs.webkit.org/show_bug.cgi?id=29622
2153
2154         * Scripts/svn-apply:
2155          - Add a bunch of "or die" statements, hopefully catching all
2156            possible cases where failure could still exit(0).
2157
2158 2009-10-27  Eric Seidel  <eric@webkit.org>
2159
2160         Reviewed by Adam Barth.
2161
2162         svn-* scripts should share code through VCSUtils.pm
2163         https://bugs.webkit.org/show_bug.cgi?id=30791
2164
2165         Just moving code into a shared location.
2166
2167         * Scripts/VCSUtils.pm:
2168         * Scripts/prepare-ChangeLog:
2169         * Scripts/resolve-ChangeLogs:
2170         * Scripts/svn-apply:
2171         * Scripts/svn-create-patch:
2172         * Scripts/svn-unapply:
2173         * Scripts/update-webkit:
2174
2175 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2176
2177         Suppress a huge number of MSVC warnings when building wxWebKit.
2178
2179         * wx/build/settings.py:
2180
2181 2009-10-26  Eric Seidel  <eric@webkit.org>
2182
2183         No review, just adding Mike Belshe to the committers list.
2184
2185         * Scripts/modules/committers.py:
2186
2187 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2188
2189         Reviewed by Darin Adler.
2190
2191         Make .rc files compile on Windows without depending on MFC headers
2192         https://bugs.webkit.org/show_bug.cgi?id=30750
2193
2194         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2195         windows.h instead of afxres.h because it exists even when MFC is not
2196         installed, and is all that's needed here.
2197
2198         * FindSafari/FindSafari.rc: Ditto
2199
2200 2009-10-24  Eric Seidel  <eric@webkit.org>
2201
2202         Reviewed by Adam Barth.
2203
2204         bugzilla-tool post-diff should know how to mark commit-queue=?
2205         https://bugs.webkit.org/show_bug.cgi?id=29202
2206
2207         * Scripts/bugzilla-tool:
2208          - Add --commit-queue option to post-diff, post-commits and create-bug.
2209         * Scripts/modules/bugzilla.py:
2210          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2211          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2212
2213 2009-10-23  Eric Seidel  <eric@webkit.org>
2214
2215         Reviewed by Adam Barth.
2216
2217         bugzilla-tool commit-queue does not notice modifications to committers.py
2218         https://bugs.webkit.org/show_bug.cgi?id=30084
2219
2220         * Scripts/bugzilla-tool:
2221          - Make commit-queue re-exec itself instead of using while(1).
2222          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2223          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2224
2225 2009-10-22  Eric Seidel  <eric@webkit.org>
2226
2227         Reviewed by Adam Barth.
2228
2229         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2230         https://bugs.webkit.org/show_bug.cgi?id=30634
2231
2232         * Scripts/bugzilla-tool:
2233          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2234          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2235
2236 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2237
2238         Reviewed by Eric Seidel.
2239
2240         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2241
2242         https://bugs.webkit.org/show_bug.cgi?id=30763
2243
2244         * pywebsocket/mod_pywebsocket/__init__.py:
2245         * pywebsocket/mod_pywebsocket/dispatch.py:
2246         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2247         * pywebsocket/mod_pywebsocket/standalone.py:
2248         * pywebsocket/setup.py:
2249         * pywebsocket/test/test_dispatch.py:
2250
2251 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2252
2253         Reviewed by David Levin.
2254
2255         REGRESSION: 2 failures in run-webkit-unittests
2256         https://bugs.webkit.org/show_bug.cgi?id=30645
2257
2258         * Scripts/modules/cpp_style_unittest.py:
2259         Fixed a few test scenarios which apparently lost some spaces from
2260         text literals.
2261
2262 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2263
2264         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2265
2266         * Scripts/webkitdirs.pm:
2267
2268 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2269
2270         Reviewed by Darin Adler.
2271
2272         Unification of using null device in perl scripts.
2273         https://bugs.webkit.org/show_bug.cgi?id=30572
2274
2275         * Scripts/VCSUtils.pm:
2276         * Scripts/bisect-builds:
2277         * Scripts/resolve-ChangeLogs:
2278         * Scripts/run-iexploder-tests:
2279         * Scripts/run-jsc:
2280         * Scripts/run-mangleme-tests:
2281         * Scripts/run-webkit-tests:
2282         * Scripts/webkitdirs.pm:
2283         Using File::Spec->devnull() instead of hard coded /dev/null.
2284
2285 2009-10-26  Eric Seidel  <eric@webkit.org>
2286
2287         Reviewed by Holger Freyther.
2288
2289         Reviewers are missing from committers.py
2290         https://bugs.webkit.org/show_bug.cgi?id=30733
2291
2292         * Scripts/modules/committers.py:
2293
2294 2009-10-23  Eric Seidel  <eric@webkit.org>
2295
2296         No review, only adding Alice to the list of reviewers.
2297
2298         * Scripts/modules/committers.py:
2299
2300 2009-10-23  Eric Seidel  <eric@webkit.org>
2301
2302         Reviewed by Eric Carlson.
2303
2304         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2305         https://bugs.webkit.org/show_bug.cgi?id=30700
2306
2307         * DumpRenderTree/mac/DumpRenderTree.mm:
2308         (resetDefaultsToConsistentValues): Update QuickTime version check.
2309
2310 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2311
2312         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
2313         character measurement APIs that are private on Tiger.
2314
2315         * wx/build/settings.py:
2316
2317 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2318
2319         Reviewed by NOBODY (build fix).
2320         Build fix following bug #30696.
2321
2322         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2323         (LayoutTestController::evaluateScriptInIsolatedWorld):
2324
2325 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2326
2327         Reviewed by Sam Weinig & Geoff Garen.
2328
2329         https://bugs.webkit.org/show_bug.cgi?id=30696
2330         Enable isolated-worlds tests on mac.
2331
2332         Add private interface for DRT to invoke execution in a given world.
2333
2334         * DumpRenderTree/LayoutTestController.cpp:
2335         (evaluateScriptInIsolatedWorldCallback):
2336         (LayoutTestController::staticFunctions):
2337         * DumpRenderTree/LayoutTestController.h:
2338         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2339         (LayoutTestController::evaluateScriptInIsolatedWorld):
2340         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2341         (LayoutTestController::evaluateScriptInIsolatedWorld):
2342
2343 2009-10-21  Eric Seidel  <eric@webkit.org>
2344
2345         Reviewed by Adam Barth.
2346
2347         bugzilla-tool's "patch failed to download an apply" error should give more information
2348         https://bugs.webkit.org/show_bug.cgi?id=30632
2349
2350         * Scripts/modules/scm.py:
2351          - Use the common run_command method instead of custom POpen code.
2352          - Make run_command know how to take pipes as input.
2353         * Scripts/modules/scm_unittest.py:
2354          - Add new tests to cover change.
2355          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2356
2357 2009-10-21  Kent Tamura  <tkent@chromium.org>
2358
2359         Unreviewed.  Adding myself to the committers list.
2360
2361         * Scripts/modules/committers.py:
2362
2363 2009-10-21  Robin Dunn  <robin@alldunn.com>
2364
2365         Reviewed by Kevin Ollivier.
2366
2367         Update the Windows installer builder to work with Vista / Win 7 and with git.
2368
2369         https://bugs.webkit.org/show_bug.cgi?id=30649
2370
2371         * wx/build/build_utils.py:
2372         * wx/packaging/build-mac-installer.py:
2373         * wx/packaging/build-win-installer.py:
2374         * wx/packaging/wxWebKitInstaller.iss.in:
2375
2376 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2377
2378         Reviewed by Gustavo Noronha.
2379
2380         [GTK] Added conditional code to avoid using
2381         gdk_window_get_root_coords if we do not have a gtk+ release newer
2382         than 2.17.3.
2383         https://bugs.webkit.org/show_bug.cgi?id=30636
2384
2385         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2386
2387 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2388
2389         Reviewed by Eric Seidel.
2390
2391         [Qt] Added dummy implementation for keepWebHistory()
2392         https://bugs.webkit.org/show_bug.cgi?id=30592
2393
2394         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2395         (LayoutTestController::keepWebHistory):
2396         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2397
2398 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2399
2400         Reviewed by Xan Lopez.
2401
2402         [GTK] Fixed the double click condition, it is not double click if
2403         we move in just in one direction.
2404         https://bugs.webkit.org/show_bug.cgi?id=30636
2405
2406         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2407
2408 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2409
2410         Reviewed by Xan Lopez.
2411
2412         [GTK] Initialize the events completly before emitting them.
2413         https://bugs.webkit.org/show_bug.cgi?id=30633
2414
2415         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2416
2417 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2418
2419         wx build fix. Fix for when linking using --as-needed with gcc.
2420
2421         * wx/browser/wscript:
2422
2423 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2424
2425         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2426         to support all the features used by CURL backend.
2427
2428         * wx/build/settings.py:
2429         * wx/install-unix-extras:
2430
2431 2009-10-20  Anton Muhin  <antonm@chromium.org>
2432
2433         Reviewed by Adam Barth.
2434
2435         Add {ager,antonm,yurys}@chromium.org into committers.py
2436         https://bugs.webkit.org/show_bug.cgi?id=30560
2437
2438         * Scripts/modules/committers.py:
2439
2440 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2441
2442         Reviewed by Tor Arne Vestbø.
2443
2444         Make the Netscape Test plugin available to the Qt launcher.
2445
2446         * Scripts/run-launcher:
2447
2448 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2449
2450         Reviewed by David Levin.
2451
2452         Removed WebSocket runtime settings.
2453         https://bugs.webkit.org/show_bug.cgi?id=29896
2454
2455         WebSocket runtime configuration is supported by chromium/v8 only.
2456
2457         * DumpRenderTree/mac/DumpRenderTree.mm:
2458         (resetDefaultsToConsistentValues):
2459         * DumpRenderTree/win/DumpRenderTree.cpp:
2460         (resetDefaultsToConsistentValues):
2461
2462 2009-10-19  Nate Chapin  <japhet@chromium.org>
2463
2464         Reviewed by Adam Barth.
2465
2466         Add testFail() to test plugin so we can test our handling of a
2467         plugin invoke call returning false.
2468
2469         https://bugs.webkit.org/show_bug.cgi?id=30239
2470
2471         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2472         (pluginInvoke):
2473         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2474
2475 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2476
2477         Reviewed by Gustavo Noronha.
2478
2479         Enable DOM pasting when running layout tests.
2480
2481         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2482         (resetDefaultsToConsistentValues):
2483
2484 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2485
2486         Reviewed by Simon Hausmann.
2487
2488         Use the setPreferredContentsSize method instead
2489         of setFixedContentsSize, as the method has been renamed.
2490
2491         * DumpRenderTree/qt/DumpRenderTree.cpp:
2492         (WebCore::DumpRenderTree::open):
2493         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2494         (LayoutTestController::setFixedContentsSize):
2495
2496 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2497
2498         Reviewed by Dan Bernstein.
2499
2500         https://bugs.webkit.org/show_bug.cgi?id=30456
2501         Fixes for new Debug_All Windows build configuration.
2502
2503         * DumpRenderTree/win/DumpRenderTree.cpp:
2504         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2505         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2506
2507 2009-10-16  Eric Seidel  <eric@webkit.org>
2508
2509         Reviewed by Adam Barth.
2510
2511         commit-queue status bot should list which buildbot is blocking the queue
2512         https://bugs.webkit.org/show_bug.cgi?id=30452
2513
2514         Add new methods and testing.
2515
2516         * Scripts/bugzilla-tool:
2517         * Scripts/modules/buildbot.py:
2518         * Scripts/modules/buildbot_unittest.py:
2519
2520 2009-10-16  Eric Seidel  <eric@webkit.org>
2521
2522         Reviewed by Adam Barth.
2523
2524         run-webkit-tests fails when CWD is not inside a WebKit checkout
2525         https://bugs.webkit.org/show_bug.cgi?id=30451
2526
2527         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2528         * Scripts/modules/scm_unittest.py:
2529           - Remove use of original_path (we don't need to restore the CWD).
2530           - Don't use '.' to find the webkit checkout, use __file__ instead.
2531
2532 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2533
2534         Reviewed by Adam Roben.
2535
2536         Add a Debug_All configuration to build entire stack as debug.
2537         Change Debug_Internal to:
2538         - stop using _debug suffix for all WebKit/Safari binaries
2539         - not use _debug as a DLL naming suffix
2540         - use non-debug C runtime lib.
2541
2542         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2543         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2544         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2545         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2546         Add missing debug.vsprops inherited property sheet.
2547         Add Debug_All configuration.
2548         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2549         * WinLauncher/WinLauncher.vcproj:
2550         Removed extraneous definitions inherited from vsprops.
2551         Add Debug_All configuration.
2552
2553 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2554
2555         Reviewed by David Levin.
2556
2557         check-webkit-style is wrong about indent checking in namespaces
2558         in header files and a few other things
2559         https://bugs.webkit.org/show_bug.cgi?id=30362
2560
2561         The few other things include:
2562         + check-webkit-style does not require spaces around the equal sign
2563           inside 'if' statements and around binary operators that take
2564           numeric literals.
2565         + check-webkit-style reports false errors for the / operator
2566           when part of a filename in the #include directive.
2567
2568         * Scripts/modules/cpp_style.py:
2569         Improved indentation checking and space checking around
2570         binary operators. While the checks are still not perfect,
2571         they are clearly better than before.
2572         * Scripts/modules/cpp_style_unittest.py:
2573         Added test cases for the newly supported checks and modified old
2574         test cases to match the new guidelines
2575
2576 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2577
2578         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2579
2580         * wx/build/settings.py:
2581
2582 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2583
2584         Reviewed by David Levin.
2585
2586         Add mod_pywebsocket to test Web Sockets.
2587         http://code.google.com/p/pywebsocket/
2588         https://bugs.webkit.org/show_bug.cgi?id=27490
2589
2590         * pywebsocket/COPYING: Added.
2591         * pywebsocket/MANIFEST.in: Added.
2592         * pywebsocket/README: Added.
2593         * pywebsocket/example/echo_client.py: Added.
2594         * pywebsocket/example/echo_wsh.py: Added.
2595         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2596         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2597         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2598         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2599         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2600         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2601         * pywebsocket/mod_pywebsocket/util.py: Added.
2602         * pywebsocket/setup.py: Added.
2603         * pywebsocket/test/config.py: Added.
2604         * pywebsocket/test/mock.py: Added.
2605         * pywebsocket/test/run_all.py: Added.
2606         * pywebsocket/test/test_dispatch.py: Added.
2607         * pywebsocket/test/test_handshake.py: Added.
2608         * pywebsocket/test/test_mock.py: Added.
2609         * pywebsocket/test/test_msgutil.py: Added.
2610         * pywebsocket/test/test_util.py: Added.
2611         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2612         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2613         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2614         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2615         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2616         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2617         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2618         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2619
2620 2009-10-15  James Robinson  <jamesr@google.com>
2621
2622         Reviewed by David Levin.
2623
2624         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2625
2626         https://bugs.webkit.org/show_bug.cgi?id=30426
2627
2628         * Scripts/modules/cpp_style.py:
2629         * Scripts/modules/cpp_style_unittest.py:
2630
2631 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2632
2633         Reviewed by Adam Roben.
2634
2635         Fixes <http://webkit.org/b/30411>.
2636         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2637
2638         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2639         building Chromium.
2640
2641         * Scripts/pdevenv:
2642
2643 2009-10-15  Robin Dunn  <robin@alldunn.com>
2644
2645         Reviewed by Kevin Ollivier.
2646
2647         Add Mac package building scripts for wx.
2648
2649         https://bugs.webkit.org/show_bug.cgi?id=30405
2650
2651         * wx/build/build_utils.py:
2652         * wx/build/settings.py:
2653         * wx/packaging/build-mac-installer.py: Added.
2654
2655 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2656
2657         Reviewed by Gustavo Noronha.
2658
2659         Enable Web Sockets support when running layout tests.
2660
2661         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2662         (resetDefaultsToConsistentValues):
2663
2664 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2665
2666         Reviewed by Gustavo Noronha.
2667
2668         Need to initialize event.button.button, since in most cases a
2669         button number is not passed as an argument.
2670
2671         * DumpRenderTree/gtk/EventSender.cpp:
2672         (mouseDownCallback):
2673         (mouseUpCallback):
2674
2675 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2676
2677         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2678         the OS if none was explicitly set.
2679
2680         * wx/build/settings.py:
2681
2682 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2683
2684         Reviewed by Timothy Hatcher.
2685
2686         Web Inspector: enable developers extras within inspector layout tests.
2687
2688         https://bugs.webkit.org/show_bug.cgi?id=30014
2689
2690         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2691         (LayoutTestController::showWebInspector):
2692         (LayoutTestController::closeWebInspector):
2693         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2694         (LayoutTestController::showWebInspector):
2695         (LayoutTestController::closeWebInspector):
2696
2697 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2698
2699         Reviewed by Jan Alonzo.
2700
2701         GtkLauncher is using a deprecated signal
2702         https://bugs.webkit.org/show_bug.cgi?id=30364
2703
2704         Modified GtkLauncher to use notify::title signal instead of
2705         deprecated title-changed signal
2706
2707         * GtkLauncher/main.c:
2708         (notify_title_cb):
2709         (create_browser):
2710
2711 2009-10-14  Brady Eidson  <beidson@apple.com>
2712
2713         Reviewed by Sam Weinig.
2714
2715         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2716         1 - Disables WebHistory
2717         2 - Doesn't make sense in that context anyway.
2718
2719         * DumpRenderTree/win/DumpRenderTree.cpp:
2720         (createWebViewAndOffscreenWindow):
2721
2722 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2723
2724         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2725         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2726
2727         * wx/build/settings.py:
2728         * wx/install-unix-extras:
2729
2730 2009-10-14  Brady Eidson  <beidson@apple.com>
2731
2732         Reviewed by Sam Weinig.
2733
2734         WebKit Win API should provide a delegate interface for global history.
2735         https://bugs.webkit.org/show_bug.cgi?id=29905
2736
2737         * DumpRenderTree/LayoutTestController.cpp:
2738         (LayoutTestController::LayoutTestController):
2739         * DumpRenderTree/LayoutTestController.h:
2740         (LayoutTestController::dumpHistoryDelegateCallbacks):
2741         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2742
2743         * DumpRenderTree/win/DumpRenderTree.cpp:
2744         (shouldLogHistoryDelegates):
2745         (runTest):
2746         (createWebViewAndOffscreenWindow):
2747         (main):
2748         * DumpRenderTree/win/DumpRenderTree.vcproj:
2749
2750         Add the IWebHistoryDelegate to DRT Windows:
2751         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2752         (wstringFromBSTR):
2753         (HistoryDelegate::HistoryDelegate):
2754         (HistoryDelegate::~HistoryDelegate):
2755         (HistoryDelegate::QueryInterface):
2756         (HistoryDelegate::AddRef):
2757         (HistoryDelegate::Release):
2758         (HistoryDelegate::didNavigateWithNavigationData):
2759         (HistoryDelegate::didPerformClientRedirectFromURL):
2760         (HistoryDelegate::didPerformServerRedirectFromURL):
2761         (HistoryDelegate::updateHistoryTitle):
2762         (HistoryDelegate::populateVisitedLinksForWebView):
2763         * DumpRenderTree/win/HistoryDelegate.h: Added.
2764
2765         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2766         (LayoutTestController::removeAllVisitedLinks):
2767
2768 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2769
2770         Reviewed by Simon Hausmann.
2771
2772         [Qt] Implement support for setPOSIXLocale on Qt.
2773         https://bugs.webkit.org/show_bug.cgi?id=30268
2774
2775         * DumpRenderTree/qt/DumpRenderTree.cpp:
2776         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2777         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2778         (LayoutTestController::setPOSIXLocale):
2779         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2780
2781 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2782
2783         Unreviewed, adding myself to reviewers list.
2784
2785         * Scripts/modules/committers.py:
2786
2787 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2788
2789         Reviewed by Mark Rowe.
2790
2791         Fix null assignment so root tests work again.
2792
2793         * Scripts/webkitdirs.pm:
2794
2795 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2796
2797         Reviewed by Simon Hausmann.
2798
2799         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
2800         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
2801         This is done in preparation of implementing missing features in DRT.
2802         No functionality changes made yet.
2803
2804         * DumpRenderTree/qt/DumpRenderTree.cpp:
2805         * DumpRenderTree/qt/DumpRenderTree.pro:
2806         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
2807         (EventSender::EventSender):
2808         (EventSender::mouseDown):
2809         (EventSender::mouseUp):
2810         (EventSender::mouseMoveTo):
2811         (EventSender::leapForward):
2812         (EventSender::keyDown):
2813         (EventSender::contextClick):
2814         (EventSender::scheduleAsynchronousClick):
2815         (EventSender::frameUnderMouse):
2816         * DumpRenderTree/qt/EventSenderQt.h: Added.
2817         (EventSender::clearKillRing):
2818         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
2819         (LayoutTestController::LayoutTestController):
2820         (LayoutTestController::reset):
2821         (LayoutTestController::processWork):
2822         (LayoutTestController::maybeDump):
2823         (LayoutTestController::waitUntilDone):
2824         (LayoutTestController::notifyDone):
2825         (LayoutTestController::windowCount):
2826         (LayoutTestController::clearBackForwardList):
2827         (LayoutTestController::dumpEditingCallbacks):
2828         (LayoutTestController::dumpResourceLoadCallbacks):
2829         (LayoutTestController::queueBackNavigation):
2830         (LayoutTestController::queueForwardNavigation):
2831         (LayoutTestController::queueLoad):
2832         (LayoutTestController::queueReload):
2833         (LayoutTestController::queueScript):
2834         (LayoutTestController::provisionalLoad):
2835         (LayoutTestController::timerEvent):
2836         (LayoutTestController::encodeHostName):
2837         (LayoutTestController::decodeHostName):
2838         (LayoutTestController::setJavaScriptProfilingEnabled):
2839         (LayoutTestController::setFixedContentsSize):
2840         (LayoutTestController::setPrivateBrowsingEnabled):
2841         (LayoutTestController::setPopupBlockingEnabled):
2842         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2843         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2844         (LayoutTestController::numberOfActiveAnimations):
2845         (LayoutTestController::disableImageLoading):
2846         (LayoutTestController::dispatchPendingLoadRequests):
2847         (LayoutTestController::setDatabaseQuota):
2848         (LayoutTestController::clearAllDatabases):
2849         (LayoutTestController::whiteListAccessFromOrigin):
2850         (LayoutTestController::waitForPolicyDelegate):
2851         (LayoutTestController::overridePreference):
2852         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
2853         (LayoutTestController::isLoading):
2854         (LayoutTestController::setLoading):
2855         (LayoutTestController::shouldDumpAsText):
2856         (LayoutTestController::shouldDumpBackForwardList):
2857         (LayoutTestController::shouldDumpChildrenAsText):
2858         (LayoutTestController::shouldDumpDatabaseCallbacks):
2859         (LayoutTestController::shouldDumpStatusCallbacks):
2860         (LayoutTestController::shouldWaitUntilDone):
2861         (LayoutTestController::canOpenWindows):
2862         (LayoutTestController::shouldDumpTitleChanges):
2863         (LayoutTestController::waitForPolicy):
2864         (LayoutTestController::dumpAsText):
2865         (LayoutTestController::dumpChildFramesAsText):
2866         (LayoutTestController::dumpDatabaseCallbacks):
2867         (LayoutTestController::dumpStatusCallbacks):
2868         (LayoutTestController::setCanOpenWindows):
2869         (LayoutTestController::dumpBackForwardList):
2870         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2871         (LayoutTestController::display):
2872         (LayoutTestController::dumpTitleChanges):
2873         (LayoutTestController::dumpSelectionRect):
2874         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
2875         (TextInputController::TextInputController):
2876         (TextInputController::doCommand):
2877         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
2878         * DumpRenderTree/qt/WorkQueue.cpp:
2879         * DumpRenderTree/qt/WorkQueue.h:
2880         * DumpRenderTree/qt/WorkQueueItem.h:
2881         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
2882         (findFrameNamed):
2883         (LoadItem::invoke):
2884         (ReloadItem::invoke):
2885         (ScriptItem::invoke):
2886         (BackForwardItem::invoke):
2887         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
2888         * DumpRenderTree/qt/jsobjects.h:
2889
2890 2009-10-13  Dmitry Titov  <dimich@chromium.org>
2891
2892         Not reviewed, adding myself to the list of reviewers.
2893
2894         * Scripts/modules/committers.py:
2895
2896 2009-10-13  Anders Carlsson  <andersca@apple.com>
2897
2898         Reviewed by Sam Weinig.
2899
2900         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
2901
2902         Make the private browsing mode testable by the test plug-in.
2903
2904         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2905         (pluginGetProperty):
2906         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2907         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2908         (NPP_New):
2909         (NPP_SetValue):
2910
2911 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
2912
2913         No review, just adding self to the list of reviewers.
2914
2915         * Scripts/modules/committers.py:
2916
2917 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
2918
2919         Reviewed by Adam Roben.
2920
2921         Web Inspector: Use proper web view in inspector layout
2922         tests for windows.
2923
2924         https://bugs.webkit.org/show_bug.cgi?id=30298
2925
2926         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2927         (LayoutTestController::showWebInspector):
2928         (LayoutTestController::closeWebInspector):
2929         (LayoutTestController::evaluateInWebInspector):
2930
2931 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
2932
2933         Reviewed by Sam Weinig.
2934
2935         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
2936         https://bugs.webkit.org/show_bug.cgi?id=29841
2937
2938         * DumpRenderTree/mac/DumpRenderTree.mm:
2939         (resetDefaultsToConsistentValues):
2940         * DumpRenderTree/win/DumpRenderTree.cpp:
2941         (resetDefaultsToConsistentValues):
2942
2943 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
2944
2945         Reviewed by Dimitri Glazkov.
2946
2947         Chromium Port - Windows
2948         https://bugs.webkit.org/show_bug.cgi?id=29969
2949
2950         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
2951         * Scripts/webkitdirs.pm:
2952
2953 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
2954
2955         Reviewed by Darin Adler.
2956
2957         jsc scripts cleanup and Qt/GTK fix
2958         https://bugs.webkit.org/show_bug.cgi?id=30288
2959
2960         Duplicated jscPath() moved to webkitdirs.pm.
2961         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
2962         Configuration added (release/debug) to path for Qt-port on Windows.
2963
2964         * Scripts/run-javascriptcore-tests:
2965         * Scripts/run-jsc:
2966         * Scripts/run-sunspider:
2967         * Scripts/sunspider-compare-results:
2968         * Scripts/webkitdirs.pm:
2969
2970 2009-10-11  Adam Barth  <abarth@webkit.org>
2971
2972         Unreviewed.  Add Collin to committers.py.
2973
2974         * Scripts/modules/committers.py:
2975
2976 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
2977
2978         wx build fix, add bindings to source/include dirs now that there are sources there.
2979
2980         * wx/build/settings.py:
2981
2982 2009-10-09  Mark Rowe  <mrowe@apple.com>
2983
2984         Reviewed by Brady Eidson.
2985
2986         Enable plug-in halting in DumpRenderTree.
2987
2988         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
2989         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
2990
2991         * DumpRenderTree/mac/DumpRenderTree.mm:
2992         (resetDefaultsToConsistentValues):
2993         * DumpRenderTree/mac/UIDelegate.mm:
2994         (-[UIDelegate webView:shouldHaltPlugin:]):
2995
2996 2009-10-08  Brady Eidson  <beidson@apple.com>
2997
2998         Reviewed by Dan Bernstein.
2999
3000         Ask the History Delegate to populate the visited links hash.
3001         <rdar://problem/7285293> and https://webkit.org/b/29904
3002
3003         Add the ability for LayoutTestController to clear all visited links.
3004         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3005
3006         * DumpRenderTree/LayoutTestController.cpp:
3007         (LayoutTestController::LayoutTestController):
3008         (removeAllVisitedLinksCallback):
3009         (LayoutTestController::staticFunctions):
3010         * DumpRenderTree/LayoutTestController.h:
3011         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3012         (LayoutTestController::removeAllVisitedLinks):
3013
3014         * DumpRenderTree/mac/HistoryDelegate.mm:
3015         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3016
3017         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3018         (LayoutTestController::removeAllVisitedLinks):
3019         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3020         (LayoutTestController::removeAllVisitedLinks):
3021         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3022         (LayoutTestController::removeAllVisitedLinks):
3023
3024
3025 2009-10-08  Daniel Bates  <dbates@webkit.org>
3026
3027         Reviewed by Adam Roben.
3028
3029         https://bugs.webkit.org/show_bug.cgi?id=30175
3030
3031         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3032         the OLE drag-and-drop return value like the function it emulates. Currently,
3033         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
3034         whether the drag-and-drop operation was successful or was cancelled.
3035
3036         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
3037         return value according to whether the drop operation was successful or not.
3038
3039         * DumpRenderTree/win/EventSender.cpp:
3040         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3041         (replaySavedEvents): Ditto.
3042         * DumpRenderTree/win/EventSender.h:
3043         * DumpRenderTree/win/UIDelegate.cpp:
3044         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3045
3046 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3047
3048         Reviewed by Xan Lopez.
3049
3050         [GTK] Added support for a parameter setting the button that was
3051         pressed in the mouseDown function.
3052         https://bugs.webkit.org/show_bug.cgi?id=30220
3053
3054         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3055
3056 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3057
3058         Reviewed by Xan Lopez.
3059
3060         [GTK] Added a line to the bottom of the expected result to match
3061         the output of the test.
3062         https://bugs.webkit.org/show_bug.cgi?id=30220
3063
3064         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3065         expected.txt:
3066
3067 2009-10-08  Adam Roben  <aroben@apple.com>
3068
3069         Use QueryInterface to get IWebInspectorPrivate
3070
3071         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3072         accessed in a more standard way
3073
3074         Reviewed by John Sullivan and Tim Hatcher.
3075
3076         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3077         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3078         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3079         to the IWebInspectorPrivate interface.
3080
3081 2009-10-07  Adam Roben  <aroben@apple.com>
3082
3083         Implement DRT support for origin whitelisting
3084
3085         Fixes <http://webkit.org/b/30185>.
3086
3087         Reviewed by Eric Seidel.
3088
3089         * DumpRenderTree/win/DumpRenderTree.cpp:
3090         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3091         whitelist, to match Mac DRT.
3092         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3093         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3094         IWebViewPrivate::whiteListAccessFromOrigin.
3095
3096 2009-10-07  Brady Eidson  <beidson@apple.com>
3097
3098         Reviewed by Darin Adler.
3099
3100         Send title changes to the global history delegate.
3101         <rdar://problem/7285293> and https://webkit.org/b/29904
3102
3103         * DumpRenderTree/mac/HistoryDelegate.mm:
3104         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3105
3106 2009-10-07  Adam Barth  <abarth@webkit.org>
3107
3108         Unreviewed.  Remove some folks from committers.py who were listed on
3109         the WebKit Team wiki page but who weren't actually listed as commit+.
3110         At some point, we should coorelate this list with the committers
3111         mailing list.
3112
3113         * Scripts/modules/committers.py:
3114
3115 2009-10-07  Adam Barth  <abarth@webkit.org>
3116
3117         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3118         the wiki into committers.py.
3119
3120         * Scripts/modules/committers.py:
3121
3122 2009-10-07  Adam Barth  <abarth@webkit.org>
3123
3124         Unreviewed.  Added Aaron Boodman to committers.py.
3125
3126         * Scripts/modules/committers.py:
3127
3128 2009-10-07  Evan Martin  <evan@chromium.org>
3129
3130         Reviewed by Darin Adler.
3131
3132         Add API to LayoutTestController for re/setting the system locale.
3133         https://bugs.webkit.org/show_bug.cgi?id=18994
3134
3135         * DumpRenderTree/LayoutTestController.cpp:
3136         (setLocaleCallback):
3137         (LayoutTestController::staticFunctions):
3138         (LayoutTestController::setLocale):
3139         * DumpRenderTree/LayoutTestController.h:
3140
3141 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3142
3143         Reviewed by Jan Alonzo.
3144
3145         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3146         https://bugs.webkit.org/show_bug.cgi?id=29689
3147
3148         Build fix by adding -lfontconfig for DumpRenderTree.
3149
3150         * GNUmakefile.am:
3151
3152 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3153
3154         Reviewed by Simon Hausmann.
3155
3156         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3157
3158         * Scripts/run-webkit-tests:
3159
3160 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3161
3162         Reviewed by Gustavo Noronha.
3163
3164         "delete" in EventSender is the backspace key, not the delete one.
3165
3166         * DumpRenderTree/gtk/EventSender.cpp:
3167         (keyDownCallback):
3168
3169 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3170
3171         Reviewed by Gustavo Noronha.
3172
3173         getChildrenWithRange expects as last parameter the end index, not
3174         the length of the range. Correct this and clarify the variable
3175         names to reflect how the code works.
3176
3177         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3178         (AccessibilityUIElement::getChildrenWithRange):
3179         (AccessibilityUIElement::getChildAtIndex):
3180
3181 2009-10-06  Mark Rowe  <mrowe@apple.com>
3182
3183         Reviewed by Simon Fraser.
3184
3185         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3186
3187         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3188         the fact we have already changed the working directory to the top of the open source tree.
3189
3190 2009-10-06  Julie Parent  <jparent@chromium.org>
3191
3192         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3193         rather than my committer email.
3194
3195         * Scripts/modules/committers.py:
3196
3197 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3198
3199         Reviewed by Eric Seidel.
3200
3201         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3202
3203         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3204         it after each layout test as it should do, making the DRT dump additional output
3205         for all of the subsequent layout tests.
3206
3207         * DumpRenderTree/qt/jsobjects.cpp:
3208         (LayoutTestController::reset):
3209
3210 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3211
3212         Reviewed by Simon Hausmann.
3213
3214         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3215         fast/dom/assign-to-window-status.html test, which is passing as a result.
3216
3217         https://bugs.webkit.org/show_bug.cgi?id=30127
3218
3219         * DumpRenderTree/qt/DumpRenderTree.cpp:
3220         (WebCore::DumpRenderTree::DumpRenderTree):
3221         (WebCore::DumpRenderTree::statusBarMessage):
3222         * DumpRenderTree/qt/DumpRenderTree.h:
3223         * DumpRenderTree/qt/jsobjects.h:
3224         (LayoutTestController::shouldDumpStatusCallbacks):
3225         (LayoutTestController::dumpStatusCallbacks):
3226
3227 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3228
3229         Reviewed by Simon Hausmann.
3230
3231         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3232         ignores the argument indicating which mouse button to trigger.
3233         https://bugs.webkit.org/show_bug.cgi?id=30048
3234
3235         This affects the fast/events/mouse-click-events.html layout test.
3236
3237         * DumpRenderTree/qt/jsobjects.cpp:
3238         (EventSender::mouseDown):
3239         (EventSender::mouseUp):
3240         * DumpRenderTree/qt/jsobjects.h:
3241
3242 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3243
3244         Reviewed by Simon Hausmann.
3245
3246         [Qt] Fix the EventSender::keyDown() implementation
3247         https://bugs.webkit.org/show_bug.cgi?id=30043
3248
3249         It should post both a key press event and a key release event,
3250         just like other ports do.
3251
3252         * DumpRenderTree/qt/jsobjects.cpp:
3253         (EventSender::keyDown):
3254
3255 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3256
3257         wx build fix. Add jpeg to the list of libs to link against.
3258
3259         * wx/build/settings.py:
3260
3261 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3262
3263         Reviewed by Simon Hausmann.
3264
3265         [Qt] EventSender::keyDown() cannot send function-key events.
3266         https://bugs.webkit.org/show_bug.cgi?id=30044
3267
3268         This affects the fast/events/keydown-function-keys.html layout test.
3269
3270         * DumpRenderTree/qt/jsobjects.cpp:
3271         (EventSender::keyDown):
3272
3273 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3274
3275         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3276         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3277
3278         * wx/build/settings.py:
3279         * wx/build/wxpresets.py:
3280
3281 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3282
3283         Reviewed by Timothy Hatcher.
3284
3285         Web Inspector: add testing harness for Web Inspector.
3286
3287         https://bugs.webkit.org/show_bug.cgi?id=30010
3288
3289         * DumpRenderTree/LayoutTestController.cpp:
3290         (showWebInspectorCallback):
3291         (closeWebInspectorCallback):
3292         (evaluateInWebInspectorCallback):
3293         (LayoutTestController::staticFunctions):
3294         * DumpRenderTree/LayoutTestController.h:
3295         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3296         (LayoutTestController::showWebInspector):
3297         (LayoutTestController::closeWebInspector):
3298         (LayoutTestController::evaluateInWebInspector):
3299         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3300         (LayoutTestController::showWebInspector):
3301         (LayoutTestController::closeWebInspector):
3302         (LayoutTestController::evaluateInWebInspector):
3303         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3304         (LayoutTestController::showWebInspector):
3305         (LayoutTestController::closeWebInspector):
3306         (LayoutTestController::evaluateInWebInspector):
3307         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3308         (LayoutTestController::showWebInspector):
3309         (LayoutTestController::closeWebInspector):
3310         (LayoutTestController::evaluateInWebInspector):
3311
3312 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3313
3314         Reviewed by Ariyha Hidayat.
3315
3316         Pass arguments to system() as a string instead of array
3317
3318         When passed as an array entries with a space fail to translate
3319         to two arguments to the child process, so instead of manually
3320         splitting all the entries in @buildArgs we pass the whole thing
3321         as a string instead.
3322
3323         * Scripts/webkitdirs.pm:
3324
3325 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3326
3327         Reviewed by David Levin.
3328
3329         check-webkit-style misses whitespace errors for operators:
3330         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3331         https://bugs.webkit.org/show_bug.cgi?id=30021
3332
3333         * Scripts/modules/cpp_style.py:
3334         Added the operators mentioned above to the same list as == and !=.
3335
3336 2009-10-02  Julie Parent  <jparent@chromium.org>
3337
3338         Unreviewed.
3339
3340         Adding myself and Ojan Vafai as committers, because we are committers.
3341
3342         * Scripts/modules/committers.py:
3343
3344 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3345
3346         Reviewed by Adam Roben.
3347
3348         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3349         this will help the patch merging process when TryBots are used.
3350
3351         * Scripts/svn-create-patch:
3352
3353 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3354
3355         Reviewed by Simon Hausmann.
3356
3357         [Qt] Implement layoutTestController.overridePreference().
3358         https://bugs.webkit.org/show_bug.cgi?id=29970
3359
3360         * DumpRenderTree/qt/DumpRenderTree.cpp:
3361         (WebCore::WebPage::WebPage):
3362         (WebCore::WebPage::resetSettings):
3363         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3364         * DumpRenderTree/qt/jsobjects.cpp:
3365         (LayoutTestController::reset):
3366         (LayoutTestController::setPrivateBrowsingEnabled):
3367         (LayoutTestController::setPopupBlockingEnabled):
3368         (LayoutTestController::overridePreference):
3369         * DumpRenderTree/qt/jsobjects.h:
3370
3371 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3372
3373         Reviewed by Oliver Hunt.
3374
3375         Turn on ENABLE_3D_CANVAS in TOT
3376         https://bugs.webkit.org/show_bug.cgi?id=29906
3377
3378         * Scripts/build-webkit:
3379
3380 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3381
3382         Rubberstamped by Simon Hausmann.
3383
3384         Enable HTTP tests for Qt
3385
3386         * Scripts/run-webkit-tests:
3387
3388 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3389
3390         Reviewed by Dimitri Glazkov.
3391
3392         build-webkit --chromium now also works on cygwin.
3393
3394         https://bugs.webkit.org/show_bug.cgi?id=29973
3395
3396         * Scripts/webkitdirs.pm:
3397
3398 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3399
3400         Reviewed by Simon Hausmann.
3401
3402         [Qt] Don't use TCmalloc in DumpRenderTree
3403         https://bugs.webkit.org/show_bug.cgi?id=27029
3404
3405         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3406
3407         * DumpRenderTree/qt/DumpRenderTree.pro:
3408
3409 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3410
3411         Reviewed by Simon Hausmann.
3412
3413         [Qt] Implement eventSender.scheduleAsynchronousClick().
3414
3415         https://bugs.webkit.org/show_bug.cgi?id=29931
3416
3417         * DumpRenderTree/qt/jsobjects.cpp:
3418         (EventSender::scheduleAsynchronousClick):
3419         * DumpRenderTree/qt/jsobjects.h:
3420
3421 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3422
3423         Reviewed by Simon Hausmann.
3424
3425         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3426         fast/events/open-window-from-another-frame.html from the Skipped list.
3427
3428         https://bugs.webkit.org/show_bug.cgi?id=29930
3429
3430         * DumpRenderTree/qt/jsobjects.cpp:
3431         (LayoutTestController::setPopupBlockingEnabled):
3432         * DumpRenderTree/qt/jsobjects.h:
3433
3434 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3435
3436         Unreviewed.
3437
3438         Added myself to the list of committers.
3439
3440         * Scripts/modules/committers.py:
3441
3442 2009-09-30  Eric Seidel  <eric@webkit.org>
3443
3444         No review, just adding Geoff to the list of reviewers.
3445
3446         * Scripts/modules/committers.py:
3447
3448 2009-09-30  Dan Bernstein  <mitz@apple.com>
3449
3450         Reviewed by Sam Weinig.
3451
3452         Added the WebKit Layout Tests fonts that are referenced in
3453         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3454
3455         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3456         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3457
3458 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3459
3460         Reviewed by David Kilzer.
3461
3462         Make sunspider scripts work on Windows platform.
3463         https://bugs.webkit.org/show_bug.cgi?id=29656
3464
3465         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3466         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3467         * Scripts/webkitdirs.pm: currentPerlPath() added.
3468
3469 2009-09-29  Brady Eidson  <beidson@apple.com>
3470
3471         Rubberstamped by Dan Bernstein.
3472
3473         Fix license and some sorting in new files.
3474
3475         * DumpRenderTree/mac/HistoryDelegate.h:
3476         * DumpRenderTree/mac/HistoryDelegate.mm:
3477
3478 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3479
3480         Reviewed by David Kilzer.
3481
3482         Fixed how error codes are handled.
3483         https://bugs.webkit.org/show_bug.cgi?id=29898
3484
3485         * Scripts/update-webkit:
3486         * Scripts/update-webkit-chromium:
3487
3488 2009-09-29  Brady Eidson  <beidson@apple.com>
3489
3490         Reviewed by John Sullivan.
3491
3492         Updated way-out-of-date sorting throughout the dump methods/flags.
3493
3494         * DumpRenderTree/LayoutTestController.cpp:
3495         (LayoutTestController::LayoutTestController):
3496         (dumpAsPDFCallback):
3497         (dumpAsTextCallback):
3498         (dumpFrameLoadCallbacksCallback):
3499         (dumpResourceLoadCallbacksCallback):
3500         (LayoutTestController::staticFunctions):
3501
3502         * DumpRenderTree/LayoutTestController.h:
3503         (LayoutTestController::dumpAsText):
3504         (LayoutTestController::setDumpAsText):
3505         (LayoutTestController::dumpFrameLoadCallbacks):
3506         (LayoutTestController::setDumpFrameLoadCallbacks):
3507         (LayoutTestController::dumpSelectionRect):
3508         (LayoutTestController::setDumpSelectionRect):
3509         (LayoutTestController::dumpSourceAsWebArchive):
3510         (LayoutTestController::setDumpSourceAsWebArchive):
3511         (LayoutTestController::dumpStatusCallbacks):
3512         (LayoutTestController::setDumpStatusCallbacks):
3513         (LayoutTestController::dumpTitleChanges):
3514         (LayoutTestController::setDumpTitleChanges):
3515         (LayoutTestController::dumpWillCacheResponse):
3516         (LayoutTestController::setDumpWillCacheResponse):
3517
3518 2009-09-29  Brady Eidson  <beidson@apple.com>
3519
3520         Reviewed by John Sullivan.
3521
3522         WebKit Mac API should provide a delegate interface for global history.
3523         <rdar://problem/7042773> and https://webkit.org/b/29904
3524
3525         Adding the dumping of global history delegate callbacks.
3526
3527         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3528
3529         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3530         * DumpRenderTree/mac/DumpRenderTree.mm:
3531         (createWebViewAndOffscreenWindow):
3532         (allocateGlobalControllers):
3533         (shouldLogFrameLoadDelegates):
3534         (shouldLogHistoryDelegates):
3535         (runTest):
3536
3537         Dump history delegate callbacks:
3538         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3539         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3540         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3541         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3542         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3543
3544 2009-09-29  Daniel Bates  <dbates@webkit.org>
3545
3546         Reviewed by Adam Roben.
3547
3548         https://bugs.webkit.org/show_bug.cgi?id=28902
3549
3550         Fixes an issue where the drop effect returned by Window Dump Render Tree
3551         was always DROPEFFECT_NONE (since it was hard coded to do so).
3552
3553         This patch corrects this issue by determining the actual drop effect
3554         performed by the corresponding drag-and-drop operation so that we can
3555         return it.
3556
3557         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3558         (DraggingInfo::DraggingInfo):
3559         (DraggingInfo::performedDropEffect): Added method.
3560         (DraggingInfo::setPerformedDropEffect): Added method.
3561         * DumpRenderTree/win/EventSender.cpp:
3562         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3563         Moved delete draggingInfo to UIDelegate::doDragDrop.
3564         * DumpRenderTree/win/UIDelegate.cpp:
3565         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3566
3567 2009-09-29  Dan Bernstein  <mitz@apple.com>
3568
3569         Reviewed by Adam Roben.
3570
3571         Remove copying of unnecessary or nonexistent files from the ImageDiff
3572         post-build event.
3573
3574         * DumpRenderTree/win/ImageDiff.vcproj:
3575
3576 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3577
3578         Reviewed by David Kilzer.
3579
3580         [Qt] Make build-webkit script work on Windows
3581         https://bugs.webkit.org/show_bug.cgi?id=29802
3582
3583         * Scripts/run-webkit-tests:
3584         * Scripts/webkitdirs.pm:
3585          - Removed unnecessary -p switch for mkdir on Windows.
3586          - Use canonical path, which uses slashes or backslashes depends on platform.
3587          - isWindows() only test for Windows and not for Cyqwin.
3588
3589 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3590
3591         Reviewed by Simon Hausmann.
3592
3593         Fix time measurement in build-webkit after refactoring done in r48853.
3594
3595         * Scripts/build-webkit:
3596
3597 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3598
3599         Reviewed by Tor Arne Vestbø.
3600
3601         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
3602         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
3603
3604         * DumpRenderTree/qt/DumpRenderTree.cpp:
3605         (WebCore::WebPage::WebPage):
3606
3607 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
3608
3609         Reviewed by Simon Hausmann.
3610
3611         [Qt] Implement eventSender.contextClick().
3612         https://bugs.webkit.org/show_bug.cgi?id=29821
3613
3614         * DumpRenderTree/qt/jsobjects.cpp:
3615         (EventSender::contextClick):
3616         * DumpRenderTree/qt/jsobjects.h:
3617
3618 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3619
3620         Reviewed by Eric Seidel.
3621
3622         Add experimentalWebSocketsEnabled in WebPreferences.
3623         https://bugs.webkit.org/show_bug.cgi?id=28941
3624
3625         * DumpRenderTree/mac/DumpRenderTree.mm:
3626         (resetDefaultsToConsistentValues):
3627         * DumpRenderTree/win/DumpRenderTree.cpp:
3628         (resetDefaultsToConsistentValues):
3629
3630 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
3631
3632         Reviewed by David Kilzer.
3633
3634         Integrated chromium port building into webkit tools update-webkit and
3635         build-webkit.
3636
3637         https://bugs.webkit.org/show_bug.cgi?id=29749
3638
3639         * Scripts/build-webkit: When --chromium is specified, will build
3640           the chromium port (currently only Mac is supported).
3641         * Scripts/update-webkit: When --chromium is specified, delegates to
3642           update-webkit-chromium.
3643         * Scripts/webkitdirs.pm: Added chromium specific defs.
3644         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
3645           chromium port's dependencies and update its project files.
3646
3647 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3648
3649         Unreviewed.
3650
3651         Add myself to list of committers.
3652
3653         * Scripts/modules/committers.py:
3654
3655 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3656
3657         Reviewed by Darin Adler.
3658
3659         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
3660         https://bugs.webkit.org/show_bug.cgi?id=29771
3661
3662         * Scripts/run-webkit-tests:
3663
3664 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3665
3666         Reviewed by Simon Hausmann.
3667
3668         [Qt] Implement layoutTestController.waitForPolicyDelegate.
3669         https://bugs.webkit.org/show_bug.cgi?id=25037
3670
3671         * DumpRenderTree/qt/DumpRenderTree.cpp:
3672         (WebCore::WebPage::acceptNavigationRequest):
3673         * DumpRenderTree/qt/DumpRenderTree.pro:
3674         * DumpRenderTree/qt/jsobjects.cpp:
3675         (LayoutTestController::reset):
3676         (LayoutTestController::notifyDone):
3677         (LayoutTestController::waitForPolicyDelegate):
3678         * DumpRenderTree/qt/jsobjects.h:
3679         (LayoutTestController::waitForPolicy):
3680
3681 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3682
3683         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
3684
3685         Reviewed by Eric Seidel.
3686
3687         The -o|--open switch uses the open(1) command on Mac OS X to
3688         open the bug URL in the default web browser.  If there are
3689         similar mechanisms on other platforms, they may be added later.
3690
3691         * Scripts/mark-bug-fixed:
3692         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
3693         options.
3694         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
3695         code into main() and extracted prompting code into
3696         _prompt_user_for_correctness().
3697         (MarkBugFixed._open_bug_in_web_browser