a69a7047688bdb3cd60bc08962e74136a23f545c
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-11-13  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Adam Roben.
4
5         Fix for <rdar://problem/5382579>
6         http/tests/security/cross-frame-access-put.html reports large 
7         negative numbers for screenLeft and screenTop (Mac reports "0")
8
9         * DumpRenderTree/win/UIDelegate.cpp:
10         (UIDelegate::UIDelegate): Initialize the RECT.
11         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
12         (UIDelegate::webViewFrame): ditto.
13         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
14
15 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
16
17         Reviewed by Adam.
18
19         - Make Drosera show source, source URLs, and function stack on Windows,
20         and some minor fixes.
21
22         * Drosera/DebuggerDocument.cpp: Force source to always update display.
23         (DebuggerDocument::updateFileSource):
24         * Drosera/debugger.js: Force source to always update display.
25         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
26         menu controls.
27         (DebuggerClient::resume):
28         (DebuggerClient::pause):
29         (DebuggerClient::stepInto):
30         (DebuggerClient::stepOver):
31         (DebuggerClient::stepOut):
32         (DebuggerClient::showConsole):
33         (DebuggerClient::closeCurrentFile):
34         * Drosera/win/DebuggerClient.h: Ditto.
35         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
36         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
37         removed two bugs.  1) caller could be in a bad state when asked to
38         assign into it. 2) BSTRs were not created correctly.
39         (DebuggerDocument::getPlatformCurrentFunctionStack):
40         * Drosera/win/Drosera.cpp: Hook up the menu controls.
41         (droseraWndProc):
42         (handleCommand):
43         (Drosera::resume):
44         (Drosera::pause):
45         (Drosera::stepInto):
46         (Drosera::stepOver):
47         (Drosera::stepOut):
48         (Drosera::showConsole):
49         (Drosera::closeCurrentFile):
50         * Drosera/win/Drosera.h: Hook up the menu controls.
51         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
52         functions, added a null check, and fixed another bug where caller could
53         be in a bad state when asked to assign into it.
54         (ServerConnection::didLoadMainResourceForDataSource):
55         (ServerConnection::getCallerFrame):
56         * Drosera/win/ServerConnection.h: Safety first.
57
58 2007-11-13  Dan Bernstein  <mitz@apple.com>
59
60         Reviewed by Darin Adler.
61
62         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
63           DumpRenderTree --pixel-tests renders each test twice
64
65         * DumpRenderTree/mac/DumpRenderTree.mm:
66         (dumpRenderTree): Removed the --paint option because the painting code
67         is always exercised as a result of
68         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
69         calling -displayIfNeeded.
70         (dump): Changed to always grab the image from the window since the view
71         is always displayed.
72         (runTest):
73         (displayWebView):
74         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
75         because it always paints.
76
77 2007-11-12  Antti Koivisto  <antti@apple.com>
78
79         Reviewed by Adele.
80         
81         Add support for http media tests
82
83         * Scripts/run-webkit-tests:
84
85 2007-11-12  Sam Weinig  <sam@webkit.org>
86
87         Reviewed by Adam Roben.
88
89         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
90
91         * DumpRenderTree/win/DumpRenderTree.cpp:
92         (runTest):
93         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
94         (LayoutTestController::setPrivateBrowsingEnabled):
95
96 2007-11-12  Adam Roben  <aroben@apple.com>
97
98         * Scripts/update-webkit-localizable-strings: Changed to only scan the
99         mac and win subdirectories.
100
101 2007-11-11  Adam Roben  <aroben@apple.com>
102
103         Fix <rdar://5133816> keepWebHistory is not implemented
104
105         Fixes fast/history/clicked-link-is-visited.html.
106
107         Reviewed by Darin.
108
109         * DumpRenderTree/win/DumpRenderTree.cpp:
110         (runTest): Clear the optionalSharedHistory.
111         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
112         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
113
114 2007-11-10  Sam Weinig  <sam@webkit.org>
115
116         Reviewed by Tim Hatcher.
117
118         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
119         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
120         is turned on)
121
122         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
123
124         Added test: http/tests/security/cross-frame-access-private-browsing.html
125
126         * DumpRenderTree/LayoutTestController.cpp:
127         (setPrivateBrowsingEnabledCallback):
128         (LayoutTestController::staticFunctions):
129         * DumpRenderTree/LayoutTestController.h:
130         * DumpRenderTree/mac/DumpRenderTree.mm:
131         (runTest): Default to private browsing disabled.
132         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
133         (LayoutTestController::setPrivateBrowsingEnabled):
134         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
135         (LayoutTestController::setPrivateBrowsingEnabled):
136
137 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
138
139         Reviewed by Adam.
140
141         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
142         WebCore's!
143
144         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
145         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
146         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
147         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
148         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
149         * Drosera/win/Drosera.cpp:
150         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
151
152 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
153
154         Reviewed by Sam.
155
156         - Use the new IWebFrame [local] function signature and get the shared
157         server correctly.
158
159         * Drosera/win/DebuggerClient.cpp:
160         (DebuggerClient::didFinishLoadForFrame):
161         * Drosera/win/ServerConnection.cpp:
162         (ServerConnection::attemptToCreateServerConnection):
163
164 2007-11-07  Dan Bernstein  <mitz@apple.com>
165
166         Reviewed by Darin Adler.
167
168         - add an option to run-webkit-tests to ignore pixel test failures where
169           all pixels differ by no more than a specified threshold
170
171         * DumpRenderTree/mac/ImageDiff.m:
172         (main):
173         (compareImages):
174         (computePercentageDifferent):
175         * Scripts/run-webkit-tests:
176
177 2007-11-07  Simon Hausmann  <hausmann@kde.org>
178
179         Reviewed by Lars.
180
181         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
182
183         * DumpRenderTree/qt/DumpRenderTree.cpp:
184
185 2007-11-07  Simon Hausmann  <hausmann@kde.org>
186
187         Reviewed by Lars.
188
189         Reworked the QWebSettings API.
190         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
191
192         * DumpRenderTree/qt/DumpRenderTree.cpp:
193
194 2007-11-07  Simon Hausmann  <hausmann@kde.org>
195
196         Reviewed by Lars.
197
198         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
199
200         * DumpRenderTree/qt/jsobjects.cpp:
201
202 2007-11-07  Simon Hausmann  <hausmann@kde.org>
203
204         Reviewed by Lars Knoll <lars@trolltech.com>.
205
206         Add a QWebPage::frameCreated() signal and fix DRT
207         
208         The removal of createFrame in QWebPage broke the re-implementation
209         in DumpRenderTree. Instead emit a frameCreated() signal and
210         connect to it in DumpRenderTree.
211         
212
213         * DumpRenderTree/qt/DumpRenderTree.cpp:
214         (WebCore::WebPage::WebPage):
215         (WebCore::DumpRenderTree::dump):
216         (WebCore::DumpRenderTree::connectFrame):
217         * DumpRenderTree/qt/DumpRenderTree.h:
218
219 2007-11-07  Simon Hausmann  <hausmann@kde.org>
220
221         Reviewed by Lars Knoll <lars@trolltech.com>.
222
223         Moved all the event handlers from QWebFrame into QWebPage.
224         
225         This cleans up the public API and allows us to remove the
226         HackWebFrame hack in DumpRenderTree.
227         
228
229         * DumpRenderTree/qt/jsobjects.cpp:
230         (EventSender::mouseDown):
231         (EventSender::mouseUp):
232         (EventSender::mouseMoveTo):
233
234 2007-11-07  Simon Hausmann  <hausmann@kde.org>
235
236         Reviewed by Mark.
237
238         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
239         to prevent the default implementation from popping up messageboxes.
240
241         * DumpRenderTree/qt/DumpRenderTree.cpp:
242         (WebCore::WebPage::javaScriptConfirm):
243         (WebCore::WebPage::javaScriptPrompt):
244
245 2007-11-06  Eric Seidel  <eric@webkit.org>
246
247         * Scripts/build-testkjs: build fix... too many $$
248
249 2007-11-06  Eric Seidel  <eric@webkit.org>
250
251         Reviewed by Mark Rowe.
252
253         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
254
255 2007-11-05  Adam Roben  <aroben@apple.com>
256
257         Add support on Windows for WEBKIT_TESTFONTS
258
259         This environment variable lets you specify where the fonts to be used
260         by DumpRenderTree reside. The Qt port is already using this, so I'm
261         just following their lead.
262
263         Reviewed by Darin.
264
265         * DumpRenderTree/win/DumpRenderTree.cpp:
266         (exePath): Refactored code out of initialize().
267         (fontsPath): Returns either $WEBKIT_TESTFONTS or
268         DumpRenderTree.resources.
269         (initialize): Use the new fontsPath function.
270         (main): Use the new exePath function.
271         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
272         variable to DRT, like Qt does.
273
274 2007-11-05  Mark Rowe  <mrowe@apple.com>
275
276         Rubber-stamped by Alp Toker.
277
278         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
279
280         * GtkLauncher/main.cpp:
281         (goToURLBarText):
282         (main):
283
284 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
285
286         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
287         <http://bugs.webkit.org/show_bug.cgi?id=15830>
288
289         Reviewed by Timothy.
290
291         Restrict the range of nightly builds used by the bisect-builds script
292         based on the version of Safari and the version of Mac OS X being used.
293
294         Mac OS X 10.4: Safari 2.0: r11976 or newer
295         Mac OS X 10.4: Safari 3.0: r19992 or newer
296
297         Mac OS X 10.5: Safari 2.0: r19594 or newer
298         Mac OS X 10.5: Safari 3.0: r25124 or newer
299
300         * Scripts/bisect-builds:
301         (findMacOSXVersion): Added.
302         (makeNightlyList): Added argument to provide version of Mac OS X.
303         Restrict range of nightly builds based on Safari and Mac OS X versions.
304
305 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
306
307         Reviewed by Maciej.
308
309         - This patch involves several changes, all of them were noticed that
310         they were needed by the work being done in WebKit to get Drosera and
311         WebKit working together on Windows.
312         - The changes are:
313         1) Added a debugger console for output messages.
314         2) Drosera now listens for the WebKit server (before, the server would
315         have to be running before Drosera was started.)
316         3) Fixed a bug where the WebView started out as 0x0 pixels.
317         4) Fixed a bug when there is no scope.
318         5) Added the HTML, JS, and CSS to the project file to make them easy to
319         find.
320         6) Made the ServerConnection functions virtual.
321
322         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
323         for the WebKit server.
324         (DebuggerClient::DebuggerClient):
325         (DebuggerClient::~DebuggerClient):
326         (DebuggerClient::didFinishLoadForFrame):
327         (DebuggerClient::serverConnected):
328         (DebuggerClient::attemptToCreateServerConnection):
329         * Drosera/win/DebuggerClient.h: Ditto.
330         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
331         scope.
332         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
333         (DebuggerDocument::platformValueForScopeVariableNamed):
334         * Drosera/win/Drosera.cpp:
335         (_tWinMain): Added a console in debug for output messages.
336         (Drosera::Drosera): Listen for server.
337         (Drosera::initUI): The server now Initializes COM.
338         (Drosera::serverConnected): Part of the listening for the server.
339         (Drosera::attemptToCreateServerConnection): Ditto.
340         * Drosera/win/Drosera.h: New interface for listening for the server.
341         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
342         files to the VS project.
343         * Drosera/win/ServerConnection.cpp: Part of listening for the server
344         connection.
345         (ServerConnection::ServerConnection):
346         (ServerConnection::attemptToCreateServerConnection):
347         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
348         methods.
349         (ServerConnection::serverConnected):
350
351 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
352
353         Reviewed by Maciej.
354
355         http://bugs.webkit.org/show_bug.cgi?id=15832
356         fast/dom/gc-10.html crashes when run alone
357
358         Check for !done before using objects that can be already deallocated.
359
360         * DumpRenderTree/mac/EditingDelegate.mm:
361         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
362         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
363         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
364         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
365         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
366         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
367         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
368         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
369         (-[EditingDelegate webViewDidBeginEditing:]):
370         (-[EditingDelegate webViewDidChange:]):
371         (-[EditingDelegate webViewDidEndEditing:]):
372         (-[EditingDelegate webViewDidChangeTypingStyle:]):
373         (-[EditingDelegate webViewDidChangeSelection:]):
374         * DumpRenderTree/mac/FrameLoadDelegate.mm:
375         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
376         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
377         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
378         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
379         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
380         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
381         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
382         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
383         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
384         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
385         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
386         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
387         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
388         (-[FrameLoadDelegate webView:willCloseFrame:]):
389         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
390         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
391         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
392         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
393         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
394         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
395         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
396         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
397         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
398
399 2007-11-04  Mark Rowe  <mrowe@apple.com>
400
401         Build fix.  Don't use Carbon.h as the prefix header as it triggers
402         warnings that would otherwise be suppressed due to it being a system header.
403
404         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
405
406 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
407
408         Rubber stamped by Adam.
409         
410         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
411
412         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
413
414 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
415
416         Sort files(...); sections of Xcode project files.
417
418         Rubber-stamped by Darin.
419
420         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
421         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
422         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
423         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
424
425 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
426
427         Script to sort "files(...);" sections in Xcode project.pbxproj files.
428
429         Reviewed by Darin.
430
431         * Scripts/sort-Xcode-project-file: Added.
432
433 2007-11-02  Darin Adler  <darin@apple.com>
434
435         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
436
437 2007-11-02  Darin Adler  <darin@apple.com>
438
439         Reviewed by Maciej.
440
441         * Scripts/run-sunspider: Pass the "--base" option through.
442
443         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
444         the real script do that. Default configuration to Release to match run-sunspider
445         so we don't end up building Debug just to compare results.
446
447 2007-11-01  Adam Roben  <aroben@apple.com>
448
449         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
450
451         Reviewed by Sam.
452
453         * Scripts/commit-log-editor: Show all the directories beneath the
454         source root, instead of just the last one.
455
456 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
457
458         Reviewed by Adam Roben.
459
460         Print out an error message when the Windows build fails
461         and provide guidance on how to find out what went wrong.
462
463         * Scripts/build-webkit:
464         * Scripts/webkitdirs.pm:
465
466 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
467
468         Rubber-stamped by Adam Roben.
469
470         Rolled out r27326 - debug CRT seems to cause no problems after all.
471
472         * DumpRenderTree/win/DumpRenderTree.vcproj:
473
474 2007-10-31  Adam Roben  <aroben@apple.com>
475
476         Switch the Debug configuration to using the non-debug CRT
477
478         This matches WebKit.
479
480         Reviewed by Steve.
481
482         * DumpRenderTree/win/DumpRenderTree.vcproj:
483
484 2007-10-31  Antti Koivisto  <antti@apple.com>
485
486         Reviewed by bdash.
487         
488         Disable media tests when doing leak checking on Tiger.
489         They crash in QuickTime (rdar://problem/5537157).
490
491         * Scripts/run-webkit-tests:
492
493 2007-10-29  Antti Koivisto  <antti@apple.com>
494
495         Reviewed by Maciej.
496         
497         Build media support by default on OSX only.
498
499         * Scripts/build-webkit:
500
501 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
502
503         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
504         get caught by the pre-commit hooks.
505
506 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
507
508         Reviewed by Adam.
509
510         - This is a collection of relatively unrelated changes and cleanups
511         to Drosera to prepare it for interacting with WebKit.  A lot of these
512         changes are just correcting mistakes, for example removing included
513         headers that are no longer needed.
514
515         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
516         this will be needed by the DebuggerClient.
517         (DebuggerDocument::server):
518         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
519         * Drosera/win/DebuggerClient.cpp: 
520         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
521         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
522         (DebuggerClient::createWebViewWithRequest): Added comment about its
523         purpose. 
524         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
525         declarations.
526         (DebuggerClient::webViewLoaded): Moved.
527         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
528         file, since this was the only place it was used.
529         (cfStringToBSTR):
530         * Drosera/win/Drosera.h: Cleaned up the includes.
531         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
532         * Drosera/win/HelperFunctions.h: Removed.
533
534 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
535
536         Reviewed by Adam.
537
538         - Small cleanup in the ServerConnection class.
539
540         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
541         and added an include.
542         (ServerConnection::currentFrame):
543         (ServerConnection::getCallerFrame):
544         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
545         made a pointer into a COMPtr, and cleaned up the includes.
546
547 2007-10-29  Timothy Hatcher  <timothy@apple.com>
548
549         Reviewed by John Sullivan.
550         
551         - Place the Localizable.strings file in mac or win directories
552           if that location exists.
553         - Also look for UI_STRING in .c files.
554
555         * Scripts/extract-localizable-strings:
556
557 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
558
559         Reviewed by Adam.
560
561         - Set the eol-style to native and made all the line endings the same
562         so that I avoid messy diffs that show eol changes.
563
564         * Drosera/win/ServerConnection.cpp:
565         (ServerConnection::didParseSource):
566         (ServerConnection::didEnterCallFrame):
567         (ServerConnection::willExecuteStatement):
568         (ServerConnection::willLeaveCallFrame):
569         (ServerConnection::exceptionWasRaised):
570
571 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
572
573         Reviewed by Adam.
574
575         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
576         functionality that could not have existed previously without the new
577         interfaces.
578         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
579         from a BSTR to a JSValueRef.
580         (DebuggerDocument::platformEvaluateScript): Implemented.
581         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
582         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
583         Implemented.
584         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
585         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
586         * Drosera/win/ServerConnection.cpp: Added a helper function.
587         (ServerConnection::getCallerFrame):
588         * Drosera/win/ServerConnection.h: Added a helper function.
589
590 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
591
592         updated reviewers for my previous changelog.
593
594 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
595         Reviewed by Maciej and Adam and Geoff.
596
597         - Minor mac-side improvements including moving a function to a more
598         appropriate location, fixing a warning, and correctly checking
599         exceptions.
600
601         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
602         (DebuggerDocument::willExecuteStatement):
603         (DebuggerDocument::didEnterCallFrame):
604         (DebuggerDocument::willLeaveCallFrame):
605         (DebuggerDocument::windowScriptObjectAvailable):
606         (DebuggerDocument::callFunctionOnObject):
607         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
608         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
609         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
610         because it doesn't require the ServerConnection at all.
611         (NSStringCreateWithJSStringRef): Made an argument const.
612         (JSValueRefCreateWithNSString): Made an argument const.
613         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
614         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
615         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
616         * Drosera/mac/ServerConnection.mm: Ditto.
617         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
618
619 2007-10-29  Sam Weinig  <sam@webkit.org>
620
621         Reviewed by Adam Roben.
622
623         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
624
625         * DumpRenderTree/LayoutTestController.cpp:
626         (LayoutTestController::LayoutTestController):
627         (getGlobalFlagCallback):
628         (setGlobalFlagCallback):
629         (LayoutTestController::getJSClass):
630         (LayoutTestController::staticValues):
631         * DumpRenderTree/LayoutTestController.h:
632         (LayoutTestController::globalFlag):
633         (LayoutTestController::setGlobalFlag):
634
635 2007-10-29  Darin Adler  <darin@apple.com>
636
637         Reviewed by Maciej.
638
639         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
640         resolution instead of its default.
641
642 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
643
644         Fixed showStatus() to print status for successfully resolved conflicts when using git.
645
646         Reviewed by Mark Rowe.
647
648         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
649         was successfully resolved, but this would not show any status because the change had
650         already been cached in the index using "git add".  The solution is to add an optional
651         second argument to showStatus() which adds the "--cached" switch to the command.
652
653         * Scripts/resolve-ChangeLogs:
654         (showStatus):
655
656 2007-10-28  Eric Seidel  <eric@webkit.org>
657
658         Reviewed by Maciej and Geoff, in unison.
659
660         * Scripts/run-webkit-tests: remove broken --svg option
661
662 2007-10-28  Darin Adler  <darin@apple.com>
663
664         Reviewed by Adam.
665
666         * Scripts/run-sunspider: Default to "Release" configuration rather than
667         defaulting to the last configuration used as other scripts do. This can
668         still be overriden on the command line with "--debug" if there's some
669         reason to do so. Also fix a typo.
670
671         * Scripts/sunspider-compare-results: Fix a typo.
672
673 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
674
675         Reviewed by Adam.
676
677         - Implemented the WebScriptDebugListener functions now that the
678         WebScriptDebugServer exists
679
680         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
681         functions.
682         (ServerConnection::currentFrame):
683         (ServerConnection::didLoadMainResourceForDataSource):
684         (ServerConnection::didParseSource):
685         (ServerConnection::failedToParseSource):
686         (ServerConnection::didEnterCallFrame):
687         (ServerConnection::willExecuteStatement):
688         (ServerConnection::willLeaveCallFrame):
689         (ServerConnection::exceptionWasRaised):
690         * Drosera/win/ServerConnection.h: Removed unused arguments from the
691         members arguments list.
692
693 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
694
695         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
696         <http://bugs.webkit.org/show_bug.cgi?id=15600>
697
698         Reviewed by Darin.
699
700         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
701         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
702         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
703         file.  Note that it may also be used as a stand-alone script.
704
705         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
706         * Scripts/resolve-ChangeLogs: Added.
707         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
708
709 2007-10-26  Mark Rowe  <mrowe@apple.com>
710
711         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
712         to the Qt port on the assumption that it was an implementation of the cross-platform
713         LayoutTestController class.  It is not, so it did not need to be changed.
714
715         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
716
717 2007-10-25  Mark Rowe  <mrowe@apple.com>
718
719         Reviewed by Maciej.
720
721         Fix builds with code coverage enabled.
722
723         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
724
725 2007-10-25  Darin Adler  <darin@apple.com>
726
727         Reviewed by Mark Rowe.
728
729         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
730         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
731
732 2007-10-25  Stephanie  <slewis@apple.com>
733
734         build Fix
735
736         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
737
738 2007-10-25  Stephanie  <slewis@apple.com>
739
740         Reviewed by Mark Rowe, Adam Roben.
741
742         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
743
744         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
745
746 2007-10-25  Alice Liu  <alice.liu@apple.com>
747
748         Reviewed by Adam.
749
750         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
751
752         Moving destructor into platform-specific files
753         * DumpRenderTree/LayoutTestController.cpp:
754         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
755         (LayoutTestController::~LayoutTestController):
756         * DumpRenderTree/qt/jsobjects.cpp:
757         (LayoutTestController::~LayoutTestController):
758
759         LayoutTestController wasn't being destroyed
760         * DumpRenderTree/win/DumpRenderTree.cpp:
761         (runTest):
762
763         Added declspec
764         * DumpRenderTree/win/EditingDelegate.h:
765
766         Reset certain values on the webview (or related delegate) that might 
767         have changed while running a test
768         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
769         (LayoutTestController::~LayoutTestController):
770
771 2007-10-25  Adam Roben  <aroben@apple.com>
772
773         Make sunspider-compare-results work with relative paths
774
775         Reviewed by Sam.
776
777         * Scripts/sunspider-compare-results: Convert arguments to absolute
778         paths before we chdir.
779
780 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
781
782         Reviewed by Sam.
783
784         - Implemented server calls now the WebScriptDebugServer exists.
785         - Also removed no longer needed call to initialize CG.
786
787         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
788         automatically now.
789         (_tWinMain):
790         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
791         (ServerConnection::ServerConnection):
792         (ServerConnection::~ServerConnection):
793         (ServerConnection::pause):
794         (ServerConnection::resume):
795         (ServerConnection::stepInto):
796         (ServerConnection::applicationTerminating):
797         (ServerConnection::serverConnectionDidDie):
798         * Drosera/win/ServerConnection.h: Now uses the COM class.
799
800 2007-10-24  George Staikos  <staikos@kde.org>
801
802         Unbreak Qt build.
803
804         * Scripts/build-webkit:
805
806 2007-10-24  Adam Roben  <aroben@apple.com>
807
808         Remove now-unnecessary call to InitializeCoreGraphics
809
810         WebKit takes care of this now.
811
812         Reviewed by Ada.
813
814         * DumpRenderTree/win/DumpRenderTree.cpp:
815         (initialize):
816
817 2007-10-24  Adam Roben  <aroben@apple.com>
818
819         Use WebTextRenderer in DRT
820
821         Reviewed by Ada.
822
823         * DumpRenderTree/win/DumpRenderTree.cpp:
824         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
825
826 2007-10-24  Sven Herzberg  <sven@imendio.com>
827
828         Reviewed by Mark Rowe.
829
830         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
831         Bug 15614: [GTK] qmake based backends don't build on OS X
832
833         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
834         GTK backend on a Mac
835         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
836         isDarwin() to make it reusable in other places (like the workaround-
837         for-prebuilt-qmake in build-webkit)
838
839 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
840
841         Refurbish update-webkit script.
842
843         Reviewed by Adam.
844
845         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
846         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
847         multi-argument version of system() for flexibility and security.  Check for existence
848         of Internal directory using -d test instead of -x.
849
850 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
851
852         Minor clean-up of prepare-ChangeLog script.
853
854         Reviewed by Adam.
855
856         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
857         of a string.  Use multi-argument versions of open() and system() for flexibility and
858         security.
859
860 2007-10-24  Alice Liu  <alice.liu@apple.com>
861
862         Reviewed by Oliver.
863
864         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
865
866         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
867         replay the saved events when we're still processing the mousedown that starts the drag
868         * DumpRenderTree/win/EventSender.cpp:
869         (doMouseMove):
870         * DumpRenderTree/win/UIDelegate.cpp:
871         (UIDelegate::doDragDrop):
872
873 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
874
875         Reviewed by Sam, Steve and Darin.
876
877         - Stubbed out the WebScriptDebugListener functionality in the Server
878         Connection class to prepare it for receiving those callbacks.
879         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
880         and the ServerConnection to not need to be initialized with a server
881         name, since that is not the way we connect to the WebKit server. 
882
883         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
884         no exception.  Now it only loggs when there is an exception
885         (DebuggerDocument::willExecuteStatement):
886         (DebuggerDocument::didEnterCallFrame):
887         (DebuggerDocument::willLeaveCallFrame):
888         (DebuggerDocument::windowScriptObjectAvailable):
889         (DebuggerDocument::callFunctionOnObject):
890         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
891         to be instantiated with a server's name.
892         (DebuggerClient::DebuggerClient):
893         (DebuggerClient::didFinishLoadForFrame):
894         * Drosera/win/DebuggerClient.h: Removed unsued variable.
895         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
896         a server name.
897         (Drosera::init):
898         (Drosera::initServer):
899         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
900         instantiated with a server's name.
901         * Drosera/win/ServerConnection.cpp: 
902         (ServerConnection::ServerConnection): No longer needs a server name
903         (ServerConnection::~ServerConnection): Only release the global context
904         if there is one.
905         (ServerConnection::serverConnectionDidDie): Stub for
906         IWebScriptDebugListener
907         (ServerConnection::QueryInterface): ditto
908         (ServerConnection::AddRef): ditto
909         (ServerConnection::Release): ditto
910         (ServerConnection::didLoadMainResourceForDataSource): ditto
911         (ServerConnection::didParseSource): ditto
912         (ServerConnection::failedToParseSource): ditto
913         (ServerConnection::didEnterCallFrame): ditto
914         (ServerConnection::willExecuteStatement): ditto
915         (ServerConnection::willLeaveCallFrame): ditto
916         (ServerConnection::exceptionWasRaised): ditto
917         * Drosera/win/ServerConnection.h: Stubbed out the
918         IWebScriptDebugListener functions, and this class no longer needs to be
919         instantiated with a server name.
920
921 2007-10-24  Lars Knoll  <lars@trolltech.com>
922
923         Reviewed by Simon.
924
925         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
926
927         * DumpRenderTree/qt/jsobjects.h:
928
929 2007-10-24  Lars Knoll  <lars@trolltech.com>
930
931         Reviewed by Simon.
932
933         add another command.
934
935         * DumpRenderTree/qt/jsobjects.cpp:
936         (TextInputController::doCommand):
937
938 2007-10-24  Lars Knoll  <lars@trolltech.com>
939
940         Reviewed by Simon.
941
942         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
943
944         * DumpRenderTree/qt/jsobjects.cpp:
945         (EventSender::keyDown):
946         * DumpRenderTree/qt/jsobjects.h:
947
948 2007-10-24  Lars Knoll  <lars@trolltech.com>
949
950         Reviewed by Simon.
951
952         implement eventSender.keyDown().
953
954         * DumpRenderTree/qt/jsobjects.cpp:
955         (EventSender::keyDown):
956
957 2007-10-24  Lars Knoll  <lars@trolltech.com>
958
959         Reviewed by Simon.
960
961         some smaller fixes to the editing support in DRT. Makes another few tests pass.
962
963         * DumpRenderTree/qt/DumpRenderTree.cpp:
964         (WebCore::DumpRenderTree::DumpRenderTree):
965         (WebCore::DumpRenderTree::initJSObjects):
966         * DumpRenderTree/qt/jsobjects.cpp:
967         (TextInputController::doCommand):
968
969 2007-10-24  Lars Knoll  <lars@trolltech.com>
970
971         Reviewed by Simon.
972
973         first bit of implementation for the textinputcontroller.
974
975         * DumpRenderTree/qt/DumpRenderTree.cpp:
976         (WebCore::DumpRenderTree::DumpRenderTree):
977         * DumpRenderTree/qt/DumpRenderTree.h:
978         * DumpRenderTree/qt/jsobjects.cpp:
979         (TextInputController::TextInputController):
980         (TextInputController::doCommand):
981         * DumpRenderTree/qt/jsobjects.h:
982
983 2007-10-24  Lars Knoll  <lars@trolltech.com>
984
985         Reviewed by Simon.
986
987         make the man webpage believe it has focus, so the editing tests work correctly.
988
989         * DumpRenderTree/qt/DumpRenderTree.cpp:
990         (WebCore::DumpRenderTree::DumpRenderTree):
991
992 2007-10-24  Lars Knoll  <lars@trolltech.com>
993
994         Reviewed by Simon.
995
996         implement layoutTestController.dumpEditingCallbacks() correctly.
997
998         * DumpRenderTree/qt/DumpRenderTree.cpp:
999         (WebCore::DumpRenderTree::DumpRenderTree):
1000         * DumpRenderTree/qt/jsobjects.cpp:
1001         (LayoutTestController::reset):
1002         (LayoutTestController::dumpEditingCallbacks):
1003
1004 2007-10-24  Lars Knoll  <lars@trolltech.com>
1005
1006         Reviewed by Simon.
1007
1008         Implement support for testing editing.
1009
1010         * DumpRenderTree/qt/DumpRenderTree.cpp:
1011         (WebCore::DumpRenderTree::DumpRenderTree):
1012
1013 2007-10-23  Sam Weinig  <sam@webkit.org>
1014
1015         Check for null BSTR that can be passed to the UIDelegate methods
1016         from javascript null and undefined.  Fixes a failing test case on
1017         Windows (fast/dom/Window/alert-undefined.html)
1018
1019         Reviewed by Eric Seidel.
1020
1021         * DumpRenderTree/win/UIDelegate.cpp:
1022         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1023         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1024         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1025         (UIDelegate::webViewAddMessageToConsole):
1026
1027 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1028
1029         Reviewed by Darin.
1030         
1031         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1032
1033         * Scripts/build-testkjs:
1034
1035 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1036
1037         Reviewed by Darin.
1038
1039         - add wrapper that finds the right copy of testkjs
1040         
1041         * Scripts/sunspider-compare-results: Added.
1042
1043 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1044
1045         Reviewed by Sam.
1046
1047         - After talking with Steve I now see that the WebKit server must be
1048         running for DCOM to create the distributed objects, which makes sense
1049         and currently WebKit only allows one instance to be running at a time
1050         which avoids accidentally connecting to the wrong server
1051         - In light of this I have removed the code for the attach box and
1052         NotificationServer and known server names, since they are all extranious
1053         now.
1054
1055         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1056         names.
1057         (_tWinMain): Uses init instead of initUI.
1058         (droseraWndProc): No longer creats an attach dialog box.
1059         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1060         it's not manditory to call init before doing COM stuff.
1061         (Drosera::init): calls initUI and will call attach when the
1062         functionality exists. 
1063         (Drosera::initUI): Has changed very little.
1064         (Drosera::attach): Changed the signature to reflect that we no longer
1065         need the dictionary of known server names.
1066         * Drosera/win/Drosera.h: Removed notification classes and known server
1067         names.  Also renamed and moved some functions.
1068         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1069         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1070         headers to the resources folder. 
1071         * Drosera/win/resource.h: Removed the Attach box.
1072
1073 2007-10-22  Adam Roben  <aroben@apple.com>
1074
1075         Windows build fix
1076
1077         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1078
1079 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1080
1081         - Removed a leak that was fixed.
1082
1083         * Scripts/run-webkit-tests:
1084
1085 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1086
1087         Reviewed by Darin.
1088
1089         - Changed the Client so that the DebuggerDocument now own the
1090         ServerConnection.  This simplifies ownership and cleanup. 
1091
1092         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1093         ServerConnection.
1094         (DebuggerClient::initWithServerName):
1095         (DebuggerClient::didFinishLoadForFrame):
1096         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
1097         ServerConnection.
1098         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1099         until after we have a server which we are attached to.
1100         (Drosera::initUI):
1101         (Drosera::attach):
1102         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1103         out previously.
1104
1105 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1106
1107         Reviewed by Nikolas.
1108
1109         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1110
1111         * Scripts/run-javascriptcore-tests:
1112
1113 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1114
1115         Reviewed by Nikolas.
1116
1117         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1118
1119         * Scripts/build-drosera:
1120         * Scripts/build-dumprendertree:
1121         * Scripts/build-testkjs:
1122         * Scripts/build-webkit:
1123         * Scripts/run-javascriptcore-tests:
1124         * Scripts/run-sunspider:
1125         * Scripts/run-webkit-tests:
1126         * Scripts/webkitdirs.pm:
1127
1128 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1129
1130         Reviewed by Mark Rowe.
1131         
1132         Fix for local database support after r26879
1133         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1134
1135         * Scripts/build-webkit:
1136
1137 2007-10-22  Holger Freyther  <zecke@selfish.org>
1138
1139         Reviewed by Simon Hausmann <hausmann@kde.org>.
1140
1141         - Do not build testkjs as an application bundle. This is
1142         needed for run-javascriptcore-tests on OSX.
1143         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1144         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1145         as we do not have -rpath on OSX.
1146
1147         * DumpRenderTree/qt/DumpRenderTree.pro:
1148         * Scripts/run-webkit-tests:
1149
1150 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1151
1152         Reviewed by aroben.
1153
1154         Fix support for Signed-off-by detection in prepare-ChangeLog
1155         --git-commit. The Signed-off-by tag does not appear in the header
1156         but usually at the end.
1157
1158         * Scripts/prepare-ChangeLog:
1159
1160 2007-10-21  Mark Rowe  <mrowe@apple.com>
1161
1162         Reviewed by Eric.
1163
1164         Fix run-javascriptcore-tests for Gtk.
1165
1166         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1167
1168 2007-10-20  Eric Seidel  <eric@webkit.org>
1169
1170         Reviewed by aroben.
1171
1172         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1173
1174 2007-10-20  Eric Seidel  <eric@webkit.org>
1175
1176         Reviewed by darin.
1177         
1178         Add improved argument handling to run-sunspider, including
1179         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1180         Also re-factor code into subroutines
1181
1182         * Scripts/build-dumprendertree: removed bogus comments
1183         * Scripts/build-testkjs: Added.
1184         * Scripts/run-javascriptcore-tests: use build-testkjs
1185         * Scripts/run-sunspider: improved argument handling, abstraction
1186         * Scripts/run-webkit-tests: improved abstraction
1187
1188 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1189
1190         Not reviewed, Windows build fix.
1191
1192         * DumpRenderTree/win/EventSender.cpp:
1193         (keyDownCallback):
1194
1195 2007-10-20  Darin Adler  <darin@apple.com>
1196
1197         Reviewed by Tim Hatcher.
1198
1199         - http://bugs.webkit.org/show_bug.cgi?id=15544
1200           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
1201           not rely on Apple-specific key codes
1202
1203         * DumpRenderTree/mac/EventSendingController.mm:
1204         (-[EventSendingController keyDown:withModifiers:]):
1205         Added named key "rightArrow". Later we could have a whole table of these.
1206         Also tweaked modifiers code a little.
1207
1208         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
1209
1210 2007-10-19  Darin Adler  <darin@apple.com>
1211
1212         Reviewed by Eric.
1213
1214         - http://bugs.webkit.org/show_bug.cgi?id=15566
1215           possible fix for leak seen in DumpRenderTree
1216
1217         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
1218         Delete the item if it's not put on the queue, since the caller has
1219         no way of knowing that. Would be better to have the parameter type
1220         be auto_ptr to express the fact that we take ownership.
1221
1222         - unrelated change
1223
1224         * Drosera/mac/main.m: Add missing include.
1225
1226 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1227
1228         Reviewed by Adam.
1229
1230         - This change should be identical but for some reason was not working
1231         on my machine.
1232
1233         * Scripts/prepare-ChangeLog:
1234
1235 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1236
1237         Reviewed by Oliver and Tim.
1238
1239         - Made use of RetainPtr to avoid retain and release issues and moved the
1240         log function to DebuggerDocumentPlatform, which seems to be a more
1241         logical place for it to live.
1242         - Also moved knownServers from the ServerConnection to
1243         DebuggerApplication to match the Windows code and because it makes sense
1244         that a connection knows its own server but not all of them.
1245
1246         * Drosera/mac/DebuggerClient.h: Moved the log function to
1247           DebuggerDocumentPlatform.
1248         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
1249           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
1250           call for the server name up from the ServerConnection class.
1251         (-[DebuggerClient dealloc]):
1252         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
1253           for the server name up from the ServerConnection.
1254         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
1255         (DebuggerDocument::platformPause):
1256         (DebuggerDocument::platformResume):
1257         (DebuggerDocument::platformStepInto):
1258         (DebuggerDocument::platformEvaluateScript):
1259         (DebuggerDocument::getPlatformCurrentFunctionStack):
1260         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1261         (DebuggerDocument::platformValueForScopeVariableNamed):
1262         (DebuggerDocument::platformLog): Log directly from here. No need to call
1263           DebuggerClient.
1264         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
1265           way I see it, a ServerConnection should only know about its connection
1266           and the group of all possible servers should be kept by the
1267           application.
1268         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
1269           currentServerName, it makes sense that the connection should know that
1270           name.
1271         (-[ServerConnection currentServerName]):
1272
1273 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1274
1275         Reviewed by Adam.
1276
1277         - Integrated changes from mac drosera.  Recently I've encapsulated
1278         out the server connection object from the rest of Drosera because
1279         it is very platform dependent right now and RPC is not implemented on
1280         windows.  This functionality, of communicating with the WebKit server
1281         is the next area I will be focusing on in Windows.
1282
1283         - Other changes and cleanup were made to organize the code and add notes
1284         on which parts still need work.  Also some mac code is added and
1285         commented out, to act as pseudocode for the logic of those parts.
1286
1287         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
1288           pointer.
1289         * Drosera/config.h: Added whitespace.
1290         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
1291           these files got moved into Drosera.h/cpp
1292         * Drosera/win/DebuggerApplication.h: Removed.
1293         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
1294           happened here to better match the logic flow of the same code on the 
1295           mac side and to use the new ServerConnection class.
1296         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
1297         (DebuggerClient::initWithServerName): Initializer that will set up the
1298           class to use a ServerConnection object.  This was necessary so I could
1299           create a DebuggerClient without having to initilaize it at
1300           construction.
1301         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
1302           will be the UIDelegate and FrameLoadDelegate.
1303         (DebuggerClient::AddRef): For IUnknown.
1304         (DebuggerClient::Release): For IUnknown.
1305         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
1306           this still needs to set the global context of the server, but
1307           IWebFrame does not have an accessor for the global context yet. 
1308         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
1309           this is a pass through for the same function in the document.
1310         (DebuggerClient::didReceiveTitle): Unimplemented part of
1311           FrameLoadDelegate this would change the title of the window.
1312         (DebuggerClient::createWebViewWithRequest): Part of the
1313           FrameLoadDelegate.  This is about new windows via Window.open() and
1314           how their delegates are set.
1315         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
1316           UIDelegate.  Just a debug function for printing messages.
1317         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
1318           because the Client should be the UIDelegate and FrameLoadDelegate
1319           to match the delegates on mac.
1320         (DebuggerClient::webViewLoaded): Added accessor method.
1321         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
1322           forgotten to add this file before.  This is where the platform
1323           dependent versions of the Documents functions live. Most of these are
1324           unimplemented because some piece of functionality does not exist on
1325           Windows yet.
1326         (DebuggerDocument::platformPause):
1327         (DebuggerDocument::platformResume):
1328         (DebuggerDocument::platformStepInto):
1329         (DebuggerDocument::platformEvaluateScript):
1330         (DebuggerDocument::getPlatformCurrentFunctionStack):
1331         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1332         (DebuggerDocument::platformValueForScopeVariableNamed):
1333         (DebuggerDocument::platformLog):
1334         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
1335           responsibilities becaue they belong in the Client. Also I laid the
1336           groundwork for attaching Drosera to a WebKit process
1337         (attachWndProc): Now if a server is selected the Client becomes it's
1338           delegate.
1339         (Drosera::Drosera): Added the construction of the Client and dictionary
1340           of server names. 
1341         (Drosera::initUI): This is no longer the delegates, the Client is.
1342         (Drosera::webViewLoaded): Now asks the Client instead of holding local
1343           state. 
1344         (Drosera::applicationDidFinishLaunching): Placeholder for needed
1345           notification registration when it's possible to implement.
1346         (Drosera::serverLoaded): Ditto
1347         (Drosera::serverUnloaded): Ditto
1348         (Drosera::attach): Attach Drosera to the WebKit server.
1349         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
1350         (Drosera::getInst): 
1351         (Drosera::setInst):
1352         (Drosera::knownServers):
1353         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
1354           and added the ServerConnection.
1355         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
1356         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
1357           Most of the functions are completely unimlemented because they cannot
1358           connect with the WebKit server, because one does not exist on Windows
1359           yet.
1360         (ServerConnection::initWithServerName): 
1361         (ServerConnection::~ServerConnection):
1362         (ServerConnection::setGlobalContext):
1363         (ServerConnection::pause):
1364         (ServerConnection::resume):
1365         (ServerConnection::stepInto):
1366         (ServerConnection::switchToServerNamed):
1367         (ServerConnection::applicationTerminating):
1368         (ServerConnection::serverConnectionDidDie):
1369         (ServerConnection::currentFrame):
1370         * Drosera/win/ServerConnection.h: Added. Ditto.
1371         (ServerConnection::ServerConnection):
1372
1373 2007-10-19  Alice Liu  <alice.liu@apple.com>
1374
1375         Reviewed by Darin.
1376
1377         Fix for these broken layout tests on Windows:
1378         
1379         fast/forms/focus-selection-input.html
1380         fast/forms/focus-selection-textarea.html
1381         fast/forms/select-accesskey.html
1382         
1383         * DumpRenderTree/win/EventSender.cpp:
1384         (keyDownCallback):
1385         correct the VK code for alt key.
1386         
1387 2007-10-19  Eric Seidel  <eric@webkit.org>
1388
1389         Reviewed by Mark Rowe.
1390         
1391         Make the GtkLauncher code slightly more readable.
1392
1393         * GtkLauncher/main.cpp:
1394         (setupMainMenu): Added.
1395         (setupMainWindowUI): Added.
1396         (main):
1397
1398 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
1399
1400         Rubber stamped by Adam.
1401         
1402         - don't delay-load WebKit in DumpRenderTree.
1403
1404         * DumpRenderTree/win/DumpRenderTree.vcproj:
1405
1406 2007-10-18  Dan Bernstein  <mitz@apple.com>
1407
1408         Reviewed by Adam Roben.
1409
1410         - fix <rdar://problem/5313523>
1411         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
1412
1413         * DumpRenderTree/mac/DumpRenderTree.mm:
1414         (dump): Changed to use _responseMIMEType.
1415
1416 2007-10-17  Adam Roben  <aroben@apple.com>
1417
1418         Make it possible to have Windows-specific tests and results
1419
1420         When searching for tests to run and the Skipped file, we will only
1421         look in platform/win and the cross-platform directory. When looking
1422         for expected results, we will look in platform/win, then
1423         platform/mac-leopard, then platform/mac, then finally the
1424         cross-platform directory.
1425
1426         Reviewed by Sam.
1427
1428         * Scripts/run-webkit-tests:
1429         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
1430         searching in the cross-platform directory.
1431         (sub buildPlatformHierarchy): Removed some unneeded calls to
1432         dirname/basename.
1433
1434 2007-10-17  Adam Roben  <aroben@apple.com>
1435
1436         Add back the call to register WebKit that we had before WebKitInitializer existed
1437
1438         This is needed to ensure that the right WebKit is used when
1439         instantiating COM objects.
1440
1441         Reviewed by Oliver.
1442
1443         * DumpRenderTree/win/debug_internal.vsprops: Define
1444         DEBUG_WEBKIT_HAS_SUFFIX.
1445         * DumpRenderTree/win/DumpRenderTree.cpp:
1446         (initialize):
1447
1448 2007-10-17  Adam Roben  <aroben@apple.com>
1449
1450         Import File::Basename in webkitdirs since we use it
1451
1452         * Scripts/webkitdirs.pm:
1453
1454 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
1455
1456         - Updated the tiger leaks list to make the internal bots green.
1457
1458         * Scripts/run-webkit-tests:
1459
1460 2007-10-17  Adam Roben  <aroben@apple.com>
1461
1462         Build fix for VC++ Express
1463
1464         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
1465         and ole32.lib.
1466
1467 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1468
1469         Reviewed by Sam.
1470
1471         - Minor mac improvements based on observations I made while implementing the
1472         Windows code.
1473
1474         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
1475         then hand it to the Client who will retain it, it should just be the client who
1476         creates and owns the server.
1477         (-[DebuggerApplication attach:]):
1478         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
1479         * Drosera/mac/DebuggerClient.mm: Creates the server.
1480         (-[DebuggerClient initWithServerName:]):
1481         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
1482         can instead forward declare what it needs.
1483
1484 2007-10-16  Darin Adler  <darin@apple.com>
1485
1486         Reviewed by Geoff Garen.
1487
1488         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
1489         want to turn failing tests into platform-specific test results. Also did a
1490         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
1491         would take the type of results into account only some of the time.
1492
1493 2007-10-16  Adam Roben  <aroben@apple.com>
1494
1495         Add a new nightly launcher script for Windows
1496
1497         This new script is for versions of Safari that don't delay-load
1498         WebKit. I had to make FindSafari be able to print out the nightly
1499         launcher script on stdout because Windows shell scripts can't capture
1500         the output from a command into an environment variable.
1501
1502         Reviewed by Steve.
1503
1504         * FindSafari/FindSafari.cpp:
1505         (_tmain): Added /printSafariLauncher option.
1506         * Scripts/run-webkit-nightly.cmd: Added.
1507
1508 2007-10-16  Adam Roben  <aroben@apple.com>
1509
1510         Replace WebKitInitializer with FindSafari
1511
1512         We now rely on setting the PATH environment variable to tell Windows
1513         where to find WebKit and its dependencies (similar to
1514         DYLD_FRAMEWORK_PATH on Mac).
1515
1516         This change also make DumpRenderTree no longer delay-load WebKit.
1517
1518         Reviewed by Sam.
1519
1520         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
1521         FindSafari.
1522         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
1523         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
1524         WebKitInitializer, don't delay-load WebKit.
1525         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
1526         * Scripts/run-webkit-tests: Ditto.
1527         * Scripts/webkitdirs.pm:
1528         (sub setPathForRunningWebKitApp): Added.
1529         * WebKitInitializer/WebKitInitializer.cpp: Removed.
1530         * WebKitInitializer/WebKitInitializer.h: Removed.
1531         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
1532         * WebKitInitializer/debug.vsprops: Removed.
1533         * WebKitInitializer/debug_internal.vsprops: Removed.
1534         * WebKitInitializer/release.vsprops: Removed.
1535
1536 2007-10-16  Adam Roben  <aroben@apple.com>
1537
1538         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
1539
1540         http://bugs.webkit.org/show_bug.cgi?id=15532
1541
1542         FindSafari simply prints the location of an installed Safari.exe on
1543         stdout.
1544
1545         Reviewed by Darin.
1546
1547         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
1548         (getStringValue):
1549         (getWebViewCLSID):
1550         (getInstalledWebKitDirectory):
1551         (_tmain):
1552         * FindSafari/FindSafari.vcproj: Added.
1553         * Scripts/webkitdirs.pm:
1554         (sub installedSafariPath): Added. Calls FindSafari on Windows.
1555
1556 2007-10-16  Adam Roben  <aroben@apple.com>
1557
1558         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
1559
1560         Reviewed by Kevin McCullough.
1561
1562         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
1563         when referring to WebKit.dll.
1564         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
1565         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
1566         * DumpRenderTree/win/release.vsprops: Ditto.
1567         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
1568         never have a _debug suffix on WebKit.dll.
1569         * WebKitInitializer/WebKitInitializer.cpp:
1570         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
1571         specified.
1572         * WebKitInitializer/debug_internal.vsprops: Added
1573         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
1574
1575 2007-10-16  Darin Adler  <darin@apple.com>
1576
1577         Reviewed by Adele.
1578
1579         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1580         Remove now-unneeded control/alt key hack; the tests have been updated.
1581
1582 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1583
1584         - Updated leaks list because our internal bot upgraded it's version of leopard and 
1585         one of the leaks was fixed between that revision and the bot's previous version of
1586         leopard.
1587
1588         * Scripts/run-webkit-tests:
1589
1590 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
1591
1592         Reviewed by Tim.
1593
1594         - I encapsulated out the server connecton functionality because it is a specific part
1595         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
1596         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
1597         Windows.  So the majority of this patch is moving preexisting functionality.
1598
1599         - Also I removed the prefix header and changed to use config.h because it is more
1600         standard on how we use config.h in windows and it didn't make much sense to keep
1601         the prefix header and the config.h
1602
1603         * Drosera/DebuggerDocument.cpp:
1604         (DebuggerDocument::DebuggerDocument):
1605         * Drosera/DebuggerDocument.h:
1606         * Drosera/config.h:
1607         * Drosera/mac/DebuggerApplication.mm:
1608         (-[DebuggerApplication attach:]):
1609         * Drosera/mac/DebuggerClient.h:
1610         * Drosera/mac/DebuggerClient.mm:
1611         (-[DebuggerClient initWithServerConnection:]):
1612         (-[DebuggerClient dealloc]):
1613         (-[DebuggerClient windowDidLoad]):
1614         (-[DebuggerClient windowWillClose:]):
1615         (-[DebuggerClient webView:didFinishLoadForFrame:]):
1616         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
1617         * Drosera/mac/DebuggerDocumentPlatform.mm:
1618         (DebuggerDocument::platformPause):
1619         (DebuggerDocument::platformResume):
1620         (DebuggerDocument::platformStepInto):
1621         (DebuggerDocument::platformEvaluateScript):
1622         (DebuggerDocument::getPlatformCurrentFunctionStack):
1623         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1624         (DebuggerDocument::platformValueForScopeVariableNamed):
1625         (DebuggerDocument::platformLog):
1626         * Drosera/mac/Drosera.pch: Removed.
1627         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1628         * Drosera/mac/ServerConnection.h: Added.
1629         * Drosera/mac/ServerConnection.mm: Added.
1630         (-[ServerConnection initWithServerName:]):
1631         (-[ServerConnection dealloc]):
1632         (-[ServerConnection setGlobalContext:]):
1633         (-[ServerConnection pause]):
1634         (-[ServerConnection resume]):
1635         (-[ServerConnection stepInto]):
1636         (-[ServerConnection switchToServerNamed:]):
1637         (-[ServerConnection applicationTerminating:]):
1638         (-[ServerConnection serverConnectionDidDie:]):
1639         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1640         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1641         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1642         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1643         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1644         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1645         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1646         (-[ServerConnection currentFrame]):
1647         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1648         (-[ServerConnection knownServers]):
1649
1650 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1651
1652         Reviewed by Eric.
1653
1654         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1655           Script to automatically search nightly builds for regressions (bisect-builds)
1656
1657         * Scripts/bisect-builds: Added.
1658
1659 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1660
1661         Reviewed by Darin.
1662
1663         - New JavaScript benchmark
1664         http://bugs.webkit.org/show_bug.cgi?id=15515
1665
1666         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1667         current development or release build of JavaScriptCore.
1668
1669 2007-10-15  Mark Rowe  <mrowe@apple.com>
1670
1671         Reviewed by Sam.
1672
1673         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1674
1675         * Scripts/webkitdirs.pm:
1676         - Change checkArgv to remove the options from @ARGV to prevent
1677         them from interfering with further option processing.
1678         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1679         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1680         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1681         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1682
1683 2007-10-15  Darin Adler  <darin@apple.com>
1684
1685         Reviewed by Sam.
1686
1687         - added logging of window.prompt and window.confirm
1688
1689         * DumpRenderTree/mac/UIDelegate.mm:
1690         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1691         Implement the recommended delegate rather than the deprecated one.
1692         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1693         Added.
1694         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1695         Added.
1696
1697         * DumpRenderTree/win/UIDelegate.h:
1698         * DumpRenderTree/win/UIDelegate.cpp:
1699         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1700         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1701         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
1702         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
1703
1704 2007-10-15  Alice Liu  <alice.liu@apple.com>
1705
1706         Reviewed by Sam Weinig.
1707
1708         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
1709
1710         * DumpRenderTree/win/DumpRenderTree.cpp:
1711         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
1712         (main): allocate the global policy delegate for DRT's custom use
1713         * DumpRenderTree/win/DumpRenderTree.vcproj:
1714         Adding files to project
1715         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
1716         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1717         (LayoutTestController::setCustomPolicyDelegate):
1718         set the webview's policy delegate to DRT's custom one if the test requests it.
1719         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
1720         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
1721         (PolicyDelegate::PolicyDelegate):
1722         (PolicyDelegate::QueryInterface):
1723         (PolicyDelegate::AddRef):
1724         (PolicyDelegate::Release):
1725         (PolicyDelegate::decidePolicyForNavigationAction):
1726         * DumpRenderTree/win/PolicyDelegate.h: Added.
1727         (PolicyDelegate::decidePolicyForNewWindowAction):
1728         (PolicyDelegate::decidePolicyForMIMEType):
1729         (PolicyDelegate::unableToImplementPolicyWithError):
1730
1731 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1732
1733         Reviewed by Mark.
1734
1735         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
1736         when querying for QMAKE_MKSPECS.
1737
1738 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
1739
1740         Reviewed by Adam Roben.
1741         
1742         Fix run-webkit-tests is too greedy calculating platform hierarchy
1743         http://bugs.webkit.org/show_bug.cgi?id=15465
1744         
1745         Fix run-webkit-tests being too greedy in trying to split the platform name up
1746         causing it to try and find tests in every directory above the first "-" in the
1747         path to the LayoutTests
1748
1749         * Scripts/run-webkit-tests:
1750
1751 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
1752
1753         Reviewed by Darin.
1754
1755         http://bugs.webkit.org/show_bug.cgi?id=15006
1756         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
1757         to reduce code duplication.
1758
1759         * Scripts/build-webkit:
1760         * Scripts/webkitdirs.pm:
1761         buildQMakeProject() renamed to buildQMakeQtProject().
1762         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
1763         unused $colorize has been removed.
1764
1765 === Start merge of feature-branch 2007-10-12 ===
1766
1767 2007-10-08  Eric Seidel  <eric@webkit.org>
1768
1769         Reviewed by Mark Rowe.
1770
1771         * Scripts/build-webkit: add --help, remove unused --color
1772
1773 2007-10-07  Eric Seidel  <eric@webkit.org>
1774
1775         Reviewed by darin.
1776
1777         * Drosera/mac/DebuggerDocumentPlatform.mm:
1778         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
1779
1780 2007-10-03  Rob Buis  <buis@kde.org>
1781
1782         Reviewed by Olliej.
1783
1784         Adapt to changed location of Ahem font.
1785
1786         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1787
1788 2007-10-02  Eric Seidel  <eric@webkit.org>
1789
1790         Reviewed by Adam Roben.
1791         
1792         Make pixel tests more useful!
1793         Finally fix the image diff 0.00% mystery problem
1794         Highlight any image differences in the image diff.
1795         Add a link from image diffs back to original test file.
1796
1797         * DumpRenderTree/mac/ImageDiff.m:
1798         (compareImages): highlight any differences
1799         (computePercentageDifferent): round to two decimal places
1800         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
1801
1802 2007-10-02  Eric Seidel  <eric@webkit.org>
1803
1804         Reviewed by Alexey Proskuryakov.
1805
1806         * Scripts/run-webkit-tests: print the % image difference on main results page
1807
1808 2007-10-02  Mark Rowe  <mrowe@apple.com>
1809
1810         Reviewed by Oliver.
1811
1812         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1813
1814         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1815         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1816
1817 2007-10-01  Mark Rowe  <mrowe@apple.com>
1818
1819         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1820
1821 2007-09-25  Eric Seidel  <eric@webkit.org>
1822
1823         Reviewed by Mark Rowe.
1824         
1825         DerivedSources.make was finding "ENABLE_SVG" in the string
1826         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
1827         quite correctly.
1828
1829         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
1830
1831 2007-09-25  Mark Rowe  <mrowe@apple.com>
1832
1833         Rubber-stamped by Eric.
1834
1835         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1836         This makes it possible to automate nightly builds for the feature-branch.
1837
1838 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
1839
1840         Rubber stamped by Mark.
1841
1842         Enable svg experimental features as default here in feature-branch.
1843
1844         * Scripts/build-webkit:
1845
1846 2007-06-29  Antti Koivisto  <antti@apple.com>
1847
1848         Reviewed by Weinig.
1849         
1850         Add VIDEO flag for timed media features
1851
1852         * Scripts/build-webkit
1853         
1854 === End merge of feature-branch 2007-10-12 ===
1855
1856 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1857
1858         Reviewed by Darin.
1859
1860         - Updated rational for the leaks list to be more clear.
1861
1862         * Scripts/run-webkit-tests:
1863
1864 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1865
1866         Rubber Stamp by Sam.
1867
1868         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
1869         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
1870
1871         * Scripts/run-webkit-tests:
1872
1873 2007-10-10  Simon Hausmann  <hausmann@kde.org>
1874
1875         Reviewed by Lars.
1876
1877         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
1878         includes are needed for INT_MAX, std::auto_ptr and the like.
1879
1880         * DumpRenderTree/qt/main.cpp:
1881
1882 2007-10-09  Lars Knoll  <lars@trolltech.com>
1883
1884         Reviewed by Simon.
1885
1886         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
1887
1888         * DumpRenderTree/qt/jsobjects.cpp:
1889         (LayoutTestController::encodeHostName):
1890         (LayoutTestController::decodeHostName):
1891         * DumpRenderTree/qt/jsobjects.h:
1892
1893 2007-10-09  Lars Knoll  <lars@trolltech.com>
1894
1895         Reviewed by Simon.
1896
1897         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
1898
1899         * DumpRenderTree/qt/DumpRenderTree.cpp:
1900         (WebCore::WebPage::createFrame):
1901         (WebCore::DumpRenderTree::DumpRenderTree):
1902         (WebCore::DumpRenderTree::titleChanged):
1903         * DumpRenderTree/qt/DumpRenderTree.h:
1904         * DumpRenderTree/qt/jsobjects.cpp:
1905         (LayoutTestController::reset):
1906         * DumpRenderTree/qt/jsobjects.h:
1907
1908 2007-10-09  Lars Knoll  <lars@trolltech.com>
1909
1910         Reviewed by Simon.
1911
1912         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
1913
1914         * DumpRenderTree/qt/DumpRenderTree.h:
1915         * DumpRenderTree/qt/jsobjects.cpp:
1916         (LayoutTestController::clearBackForwardList):
1917         * DumpRenderTree/qt/jsobjects.h:
1918
1919 2007-10-09  Lars Knoll  <lars@trolltech.com>
1920
1921         Reviewed by Simon.
1922
1923         make --git-reviewer work again.
1924
1925         * Scripts/prepare-ChangeLog:
1926
1927 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
1928
1929         Rubber stamped by Eric.
1930
1931         Connect to the "hovering-over-link" signal emitted by WebKitPage and
1932         show the current link inside the statusbar.
1933         This shows how to make use of this signal and allows to easily test
1934         http://bugs.webkit.org/show_bug.cgi?id=15299.
1935
1936         * GtkLauncher/main.cpp:
1937         (hoveringOverLink):
1938         (main):
1939
1940 2007-10-05  Lars Knoll  <lars@trolltech.com>
1941
1942         add proper error messages to the FrameLoaderClient.
1943         Implement ChromeClientQt::closeWindowSoon and
1944         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
1945         Some fixes in DRT to make it work correctly with multiple windows.
1946
1947         Reviewed by Maciej.
1948
1949         * DumpRenderTree/qt/DumpRenderTree.cpp:
1950         (WebCore::DumpRenderTree::DumpRenderTree):
1951         (WebCore::DumpRenderTree::createWindow):
1952         (WebCore::DumpRenderTree::windowCount):
1953         * DumpRenderTree/qt/DumpRenderTree.h:
1954         * DumpRenderTree/qt/jsobjects.cpp:
1955         (LayoutTestController::maybeDump):
1956         (LayoutTestController::windowCount):
1957         * DumpRenderTree/qt/jsobjects.h:
1958
1959 2007-10-05  Lars Knoll  <lars@trolltech.com>
1960
1961         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
1962         Add support for layoutTextController.setCanOpenWindows() to DRT
1963         fixing another 2 test cases in fast/dom/Window.
1964
1965         Reviewed by Maciej.
1966
1967         * DumpRenderTree/qt/DumpRenderTree.cpp:
1968         (WebCore::WebPage::WebPage):
1969         (WebCore::WebPage::createWindow):
1970         (WebCore::DumpRenderTree::resetJSObjects):
1971         (WebCore::DumpRenderTree::createWindow):
1972         * DumpRenderTree/qt/DumpRenderTree.h:
1973         * DumpRenderTree/qt/DumpRenderTree.pro:
1974         * DumpRenderTree/qt/jsobjects.cpp:
1975         (LayoutTestController::LayoutTestController):
1976         (LayoutTestController::reset):
1977         * DumpRenderTree/qt/jsobjects.h:
1978         * DumpRenderTree/qt/main.cpp:
1979         * DumpRenderTree/qt/testplugin.cpp: Added.
1980         * DumpRenderTree/qt/testplugin.h: Added.
1981
1982 2007-10-04  Sam Weinig  <sam@webkit.org>
1983
1984         Rubber stamped by Adam.
1985
1986         Remove empty directories.
1987
1988         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
1989         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
1990
1991 2007-10-03  Darin Adler  <darin@apple.com>
1992
1993         Reviewed by Adam.
1994
1995         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
1996         we find the internal libraries in the libraries directory. This
1997         is helpful for Safari team engineers at Apple.
1998
1999 2007-10-03  Adam Roben  <aroben@apple.com>
2000
2001         Update the location of AHEM___.TTF after r25968
2002
2003         Reviewed by Sam.
2004
2005         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2006
2007 2007-10-03  Alp Toker  <alp@atoker.com>
2008
2009         Reviewed by Adam.
2010
2011         http://bugs.webkit.org/show_bug.cgi?id=14726
2012         [gtk] API design. Mapping the WebView delegates to signals.
2013
2014         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2015
2016         * GtkLauncher/main.cpp:
2017         (goToURLBarText):
2018         (titleChanged):
2019         (progressChanged):
2020         (menuMainBackCallback):
2021         (menuMainForwardCallback):
2022         (main):
2023
2024 2007-10-03  Lars Knoll  <lars@trolltech.com>
2025
2026         Reviewed by Rob.
2027
2028         This fixes --strict mode in run-webkit-tests again after
2029         the platform dependent test results have been moved.
2030
2031         * Scripts/run-webkit-tests:
2032
2033 2007-10-03  Lars Knoll  <lars@trolltech.com>
2034
2035         Reviewed by bdash.
2036
2037         remove the hack in run-webkit-tests that forced text only test
2038         to be taken from the platform independent dir. It was only left
2039         there from early days.
2040         
2041         Remove platform dependent results for tests that are text only nowadays,
2042         and add one platform dependent result for a text only test that requires it.
2043
2044         * Scripts/run-webkit-tests:
2045
2046 2007-10-03  Lars Knoll  <lars@trolltech.com>
2047
2048         Reviewed by olliej.
2049
2050         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2051
2052         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2053         (WebCore::WebFrame::WebFrame):
2054         (WebCore::WebPage::WebPage):
2055         (WebCore::WebPage::createFrame):
2056         (WebCore::WebPage::javaScriptAlert):
2057         (WebCore::WebPage::javaScriptConsoleMessage):
2058         (WebCore::DumpRenderTree::DumpRenderTree):
2059         (WebCore::DumpRenderTree::~DumpRenderTree):
2060         (WebCore::DumpRenderTree::open):
2061         (WebCore::DumpRenderTree::readStdin):
2062         (WebCore::DumpRenderTree::resetJSObjects):
2063         (WebCore::DumpRenderTree::initJSObjects):
2064         (WebCore::DumpRenderTree::dumpFramesAsText):
2065         (WebCore::DumpRenderTree::dump):
2066         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2067         (WebCore::DumpRenderTree::layoutTestController):
2068         (WebCore::DumpRenderTree::eventSender):
2069         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2070         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2071         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2072         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2073         (HackWebFrame::mousePressEvent):
2074         (HackWebFrame::mouseReleaseEvent):
2075         (HackWebFrame::mouseMoveEvent):
2076         (HackWebFrame::HackWebFrame):
2077         (HackWebFrame::~HackWebFrame):
2078         (LayoutTestController::LayoutTestController):
2079         (LayoutTestController::reset):
2080         (LayoutTestController::maybeDump):
2081         (LayoutTestController::waitUntilDone):
2082         (LayoutTestController::notifyDone):
2083         (LayoutTestController::dumpEditingCallbacks):
2084         (LayoutTestController::queueReload):
2085         (LayoutTestController::provisionalLoad):
2086         (LayoutTestController::timerEvent):
2087         (EventSender::EventSender):
2088         (EventSender::mouseDown):
2089         (EventSender::mouseUp):
2090         (EventSender::mouseMoveTo):
2091         (EventSender::leapForward):
2092         (EventSender::keyDown):
2093         (EventSender::frameUnderMouse):
2094         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2095         (LayoutTestController::isLoading):
2096         (LayoutTestController::setLoading):
2097         (LayoutTestController::shouldDumpAsText):
2098         (LayoutTestController::shouldDumpChildrenAsText):
2099         (LayoutTestController::shouldWaitUntilDone):
2100         (LayoutTestController::dumpAsText):
2101         (LayoutTestController::dumpChildFramesAsText):
2102         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2103         (messageHandler):
2104         (crashHandler):
2105         (main):
2106         * Scripts/run-webkit-tests:
2107
2108 2007-10-03  Mark Rowe  <mrowe@apple.com>
2109
2110         Reviewed by Alp Toker.
2111
2112         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2113         should take precedence over QTDIR when determining which port we are working with.
2114
2115         * Scripts/webkitdirs.pm: 
2116
2117 2007-10-02  Adam Roben  <aroben@apple.com>
2118
2119         Add keychain to the list of default packages to install
2120
2121         Rubberstamped by Sam.
2122
2123         * CygwinDownloader/cygwin-downloader.py:
2124         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2125
2126 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2127
2128         Reviewed by Adam.
2129
2130         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2131         Also makes WebCore regression test case logic work when using git.
2132
2133         * Scripts/prepare-ChangeLog:
2134         (reviewerAndDescriptionForGitCommit): Added.
2135
2136 2007-10-02  Lars Knoll  <lars@trolltech.com>
2137
2138         Reviewed by bdash.
2139
2140         Add API to retrieve the frame name from QWebFrame.
2141         Implement support for DRT::dumpChildrenAsText.
2142
2143         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2144         (WebCore::DumpRenderTree::dumpFramesAsText):
2145         (WebCore::DumpRenderTree::dump):
2146         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2147         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2148         (LayoutTestController::LayoutTestController):
2149         (LayoutTestController::reset):
2150         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2151
2152 2007-10-02  Lars Knoll  <lars@trolltech.com>
2153
2154         Reviewed by bdash.
2155
2156         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2157
2158         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2159         (WebCore::DumpRenderTree::readStdin):
2160
2161 2007-10-02  Mark Rowe  <mrowe@apple.com>
2162
2163         Reviewed by Oliver.
2164
2165         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2166
2167         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2168         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2169
2170 2007-10-02  Mark Rowe  <mrowe@apple.com>
2171
2172         Rubber-stamped by Maciej.
2173
2174         Configuration changes from build.webkit.org.  The major change is refactoring to work
2175         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2176         last few weeks.
2177
2178         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2179         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2180         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2181         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2182         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2183         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2184         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2185         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2186
2187 2007-10-02  Lars Knoll  <lars@trolltech.com>
2188
2189         Reviewed by Maciej.
2190
2191         Add support for eventSender.mouseMove to DRT.
2192         Fixes fast/css/hover-affects-child.html
2193
2194         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2195         (EventSender::mouseMoveTo):
2196
2197 2007-10-01  Mark Rowe  <mrowe@apple.com>
2198
2199         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2200
2201 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
2202
2203         Reviewed by Hyatt.
2204
2205         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
2206
2207         * Scripts/svn-apply:
2208         (gitdiff2svndiff): Ignore lines beginning with "new file".
2209         * Scripts/svn-unapply:
2210         (gitdiff2svndiff): Ditto.
2211
2212 2007-09-30  George Staikos  <staikos@kde.org>
2213
2214         Qt build fix (Mac OS X specific)
2215
2216         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2217
2218 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2219
2220         Reviewed by Mark.
2221
2222         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
2223         Remove Bakefiles from svn.
2224
2225         * GtkLauncher/Bakefiles.bkgen: Removed.
2226         * GtkLauncher/ENV: Removed.
2227         * GtkLauncher/gdklauncher.bkl: Removed.
2228         * GtkLauncher/mk: Removed.
2229         * Scripts/regenerate-makefiles: Removed.
2230
2231 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
2232
2233         Reviewed by John.
2234
2235         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
2236
2237         * Scripts/run-webkit-tests:
2238
2239 2007-09-26  Adam Roben  <aroben@apple.com>
2240
2241         Make not finding an installed WebKit non-fatal
2242
2243         What really matters is that we are able to load WebKit and its
2244         dependencies, not whether we think we've found an installed WebKit.
2245
2246         Reviewed by Sam.
2247
2248         * WebKitInitializer/WebKitInitializer.cpp:
2249         (getWebViewCLSID): Use new LOG_WARNING macro.
2250         (getInstalledWebKitDirectory): Ditto.
2251         (initializeWebKit): Don't die if we didn't find an installed WebKit,
2252         and use new macros.
2253         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
2254
2255 2007-09-26  Adam Roben  <aroben@apple.com>
2256
2257         Committed this file before saving it
2258
2259         * WebKitInitializer/debug_internal.vsprops:
2260
2261 2007-09-26  Adam Roben  <aroben@apple.com>
2262
2263         Load WebKit and its dependencies manually so they come from DllDirectory
2264
2265         I had to change WebKitInitializer to use malloc/free instead of
2266         new/delete to avoid pulling in WebKit (and its dependencies) early
2267         through use of fastMalloc.
2268
2269         Reviewed by Oliver.
2270
2271         * WebKitInitializer/WebKitInitializer.cpp:
2272         (getStringValue): Changed to use malloc/free.
2273         (getInstalledWebKitDirectory): Ditto.
2274         (initializeWebKit): Call SetDllDirectory first, then load all of
2275         WebKit's dependencies manually, finally followed by WebKit itself.
2276         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
2277         configuration to match our other projects.
2278         * WebKitInitializer/debug_internal.vsprops: Added.
2279
2280 2007-09-25  Adam Roben  <aroben@apple.com>
2281
2282         Actually define DEBUG/NDEBUG so that we load WebKit correctly
2283
2284         Rubberstamped by Sam.
2285
2286         * WebKitInitializer/WebKitInitializer.vcproj:
2287
2288 2007-09-25  Adam Roben  <aroben@apple.com>
2289
2290         Make DumpRenderTree delay-load its dependencies
2291
2292         This lets WebKitInitializer re-route the dependencies to be loaded out
2293         of the Safari installation directory.
2294
2295         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
2296         same thing), since we can't import the kCFAllocatorDefault symbol when
2297         delay-loading CoreFoundation.dll.
2298
2299         Rubberstamped by Sam.
2300
2301         * DumpRenderTree/win/DumpRenderTree.cpp:
2302         (runTest):
2303         (javaScriptThreads):
2304         * DumpRenderTree/win/DumpRenderTree.vcproj:
2305         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2306         (LayoutTestController::setWaitToDump):
2307
2308 2007-09-25  Adam Roben  <aroben@apple.com>
2309
2310         Pull ole32.lib into WebKitInitializer
2311
2312         Rubberstamped by Sam.
2313
2314         * WebKitInitializer/WebKitInitializer.vcproj:
2315
2316 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2317
2318         Reviewed by Adam.
2319
2320         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
2321           LGPL'ed files contain incorrect FSF address
2322
2323         * Drosera/config.h:
2324
2325 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2326
2327         Reviewed by Adam.
2328
2329         Make svn-apply and svn-unapply work with git-diff formatted patches.
2330
2331         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
2332         (gitdiff2svndiff): Added.
2333         * Scripts/svn-unapply: Ditto.
2334         (gitdiff2svndiff): Added.
2335
2336 2007-09-25  Adam Roben  <aroben@apple.com>
2337
2338         Pull advapi32.lib into WebKitInitializer
2339
2340         This is needed to get the registry functions we use.
2341
2342         Rubberstamped by Sam.
2343
2344         * WebKitInitializer/WebKitInitializer.vcproj:
2345
2346 2007-09-25  Adam Roben  <aroben@apple.com>
2347
2348         Add python and rsync to cygwin-downloader
2349
2350         Our build slaves need this, and it can't hurt for everyone else to
2351         have it, too.
2352
2353         Reviewed by Sam.
2354
2355         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
2356         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2357
2358 2007-09-25  Adam Roben  <aroben@apple.com>
2359
2360         Add WebKitInitializer and use it in DumpRenderTree
2361
2362         WebKitInitializer is a static library that has one function,
2363         initializeWebKit(). This registers WebKit and sets up the DLL search
2364         path so that WebKit's dependencies that are installed with Safari can
2365         be found.
2366
2367         Reviewed by Sam.
2368
2369         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
2370         DumpRenderTree depend on it.
2371         * DumpRenderTree/win/DumpRenderTree.cpp:
2372         (initialize): Call initializeWebKit.
2373         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
2374         WebKitInitializer.lib.
2375         * WebKitInitializer/WebKitInitializer.cpp: Added.
2376         (getStringValue):
2377         (getWebViewCLSID):
2378         (getInstalledWebKitDirectory):
2379         (initializeWebKit):
2380         * WebKitInitializer/WebKitInitializer.h: Added.
2381         * WebKitInitializer/WebKitInitializer.vcproj: Added.
2382         * WebKitInitializer/debug.vsprops: Added.
2383         * WebKitInitializer/release.vsprops: Added.
2384
2385 2007-09-25  Adam Roben  <aroben@apple.com>
2386
2387         Make run-webkit-tests respect set-webkit-configuration
2388
2389         Reviewed by Sam.
2390
2391         * Scripts/run-webkit-tests: Initialize $configuration to whatever
2392         set-webkit-configuration was last set to.
2393
2394 2007-09-25  Mark Rowe  <mrowe@apple.com>
2395
2396         Rubber-stamped by Eric.
2397
2398         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2399         This makes it possible to automate nightly builds for the feature-branch.
2400
2401 2007-09-25  Adam Roben  <aroben@apple.com>
2402
2403         A couple of fixes/enhancements to update-webkit-*-libs
2404
2405         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
2406         to tell update-webkit-support-libraries where it should find the
2407         WebKitSupportLibrary.zip file you downloaded.
2408
2409         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
2410         Windows-style path.
2411
2412         Reviewed by Sam.
2413
2414         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
2415         to $auxiliaryLibsURL and removed an irrelevant comment.
2416         * Scripts/update-webkit-support-libs:
2417
2418 2007-09-25  Adam Treat  <treat@kde.org>
2419
2420         Reviewed by Simon and Lars.
2421
2422         Refactors and cleans up Qt DRT member variable names, member variable
2423         initialization, style fixes and general code cleanup.
2424
2425         Adds queueReload slot to LayoutTestController that some tests require.
2426
2427         Subclasses QWebFrame to make sure that all frames have an associated
2428         LayoutTestController JS window object.
2429
2430         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
2431         aren't dumped twice.
2432
2433         EOF fixes.
2434
2435         Together, this patch fixes some 20+ layout tests in QtWebKit.
2436
2437         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2438         (WebCore::WebFrame::WebFrame):
2439         (WebCore::WebPage::WebPage):
2440         (WebCore::WebPage::createFrame):
2441         (WebCore::DumpRenderTree::DumpRenderTree):
2442         (WebCore::DumpRenderTree::open):
2443         (WebCore::DumpRenderTree::readStdin):
2444         (WebCore::DumpRenderTree::initJSObjects):
2445         (WebCore::DumpRenderTree::dump):
2446         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2447         (WebCore::DumpRenderTree::layoutTestController):
2448         (WebCore::DumpRenderTree::eventSender):
2449         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2450         (LayoutTestController::LayoutTestController):
2451         (LayoutTestController::reset):
2452         (LayoutTestController::maybeDump):
2453         (LayoutTestController::waitUntilDone):
2454         (LayoutTestController::notifyDone):
2455         (LayoutTestController::queueReload):
2456         (LayoutTestController::provisionalLoad):
2457         (EventSender::EventSender):
2458         (EventSender::mouseDown):
2459         (EventSender::mouseUp):
2460         (EventSender::mouseMoveTo):
2461         (EventSender::frameUnderMouse):
2462         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2463         (LayoutTestController::isLoading):
2464         (LayoutTestController::setLoading):
2465         (LayoutTestController::dumpAsText):
2466         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2467         (main):
2468
2469 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2470
2471
2472         - Reverted an accidentally checked in file.
2473
2474         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
2475
2476 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2477         Reviewed by Sam.
2478
2479         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
2480
2481         * DumpRenderTree/win/DumpRenderTree.vcproj:
2482         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2483
2484 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2485
2486         Rubber stamped by Adam.
2487
2488         * GdkLauncher: Removed.
2489         * GdkLauncher/Bakefiles.bkgen: Removed.
2490         * GdkLauncher/ENV: Removed.
2491         * GdkLauncher/GdkLauncher.pro: Removed.
2492         * GdkLauncher/gdklauncher.bkl: Removed.
2493         * GdkLauncher/main.cpp: Removed.
2494         * GdkLauncher/mk: Removed.
2495         * GdkLauncher/simple.svg: Removed.
2496         * GdkLauncher/text.html: Removed.
2497         * GtkLauncher: Added.
2498         * GtkLauncher/GdkLauncher.pro: Removed.
2499         * GtkLauncher/GtkLauncher.pro: Added.
2500         * GtkLauncher/main.cpp:
2501         (updateWindowTitle):
2502         (main):
2503         * Scripts/build-webkit:
2504         * Scripts/regenerate-makefiles:
2505         * Scripts/run-javascriptcore-tests:
2506         * Scripts/run-launcher:
2507         * Scripts/run-webkit-tests:
2508         * Scripts/webkitdirs.pm:
2509
2510 2007-09-21  Timothy Hatcher  <timothy@apple.com>
2511
2512         Reviewed by Darin.
2513
2514         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
2515
2516         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
2517         This is tested by plugins/root-object-premature-delete-crash.html.
2518
2519         * DumpRenderTree/mac/ObjCController.m:
2520         (-[ObjCController accessStoredWebScriptObject]):
2521
2522 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
2523
2524         Reviewed by Oliver.
2525
2526         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
2527
2528         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2529         (FrameLoadDelegate::FrameLoadDelegate):
2530
2531 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
2532
2533         Reviewed by Adam.
2534
2535         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
2536         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
2537
2538         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
2539         Now isQt() and isGdk() use global variables that are only set once.
2540
2541         An array of all the parameters is now given to build-dumprender which includes
2542         the platform on linux.
2543
2544         * Scripts/build-dumprendertree:
2545         * Scripts/run-webkit-tests:
2546         * Scripts/webkitdirs.pm:
2547
2548 2007-09-19  Adam Roben  <aroben@apple.com>
2549
2550         Rubberstamped by Hyatt.
2551
2552         * Spinneret: Removed.
2553
2554 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
2555
2556         Reviewed by David Kilzer.
2557
2558         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
2559
2560 2007-09-18  Sam Weinig  <sam@webkit.org>
2561
2562         Add JSRetainPtr.h #include to fix some builds.
2563
2564         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2565
2566 2007-09-18  Mike Hommey  <glandium@debian.org>
2567
2568         Reviewed by Adam.
2569
2570         * Scripts/prepare-ChangeLog:
2571         - Properly parse GECOS field.
2572         - Use git configuration for user name and email when appropriate.
2573
2574 2007-09-17  Sam Weinig  <sam@webkit.org>
2575
2576         Build fix.
2577
2578         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2579
2580 2007-09-17  Sam Weinig  <sam@webkit.org>
2581
2582         Reviewed by Adam Roben.
2583
2584         Share more code between mac and windows DRT.
2585             - GCController is now shared.
2586             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
2587
2588         * DumpRenderTree/GCController.cpp:
2589         * DumpRenderTree/win/DumpRenderTree.cpp:
2590         * DumpRenderTree/win/DumpRenderTree.vcproj:
2591         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
2592         (FrameLoadDelegate::FrameLoadDelegate):
2593         (FrameLoadDelegate::~FrameLoadDelegate):
2594         (FrameLoadDelegate::windowScriptObjectAvailable):
2595         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
2596         * DumpRenderTree/win/GCController.cpp: Removed.
2597         * DumpRenderTree/win/GCController.h: Removed.
2598         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
2599         (GCController::collect):
2600         (GCController::collectOnAlternateThread):
2601         (GCController::getJSObjectCount):
2602         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
2603         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
2604
2605 2007-09-17  Sam Weinig  <sam@webkit.org>
2606
2607         Reviewed by Adam Roben.
2608
2609         Begin sharing code between mac and windows DRT.
2610             - both now share LayoutTestController.h/cpp and implement platform dependant 
2611               operations in LayoutTestControllerMac/Win.
2612             - DumpRenderTree.h is now shared.
2613             - WorkQueue and WorkQueueItem are also shared.
2614
2615         * DumpRenderTree/DumpRenderTree.h:
2616         * DumpRenderTree/LayoutTestController.cpp:
2617         * DumpRenderTree/win/DumpRenderTree.cpp:
2618         (displayWebView):
2619         (dumpFrameScrollPosition):
2620         (dumpFramesAsText):
2621         (dump):
2622         (runTest):
2623         * DumpRenderTree/win/DumpRenderTree.h: Removed.
2624         * DumpRenderTree/win/DumpRenderTree.vcproj:
2625         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
2626         * DumpRenderTree/win/EditingDelegate.cpp:
2627         (EditingDelegate::shouldBeginEditingInDOMRange):
2628         (EditingDelegate::shouldEndEditingInDOMRange):
2629         (EditingDelegate::shouldInsertNode):
2630         (EditingDelegate::shouldInsertText):
2631         (EditingDelegate::shouldDeleteDOMRange):
2632         (EditingDelegate::shouldChangeSelectedDOMRange):
2633         (EditingDelegate::shouldApplyStyle):
2634         (EditingDelegate::shouldChangeTypingStyle):
2635         (EditingDelegate::doPlatformCommand):
2636         (EditingDelegate::webViewDidBeginEditing):
2637         (EditingDelegate::webViewDidChange):
2638         (EditingDelegate::webViewDidEndEditing):
2639         (EditingDelegate::webViewDidChangeTypingStyle):
2640         (EditingDelegate::webViewDidChangeSelection):
2641         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2642         * DumpRenderTree/win/LayoutTestController.h: Removed.
2643         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2644         (LayoutTestController::addDisallowedURL):
2645         (LayoutTestController::clearBackForwardList):
2646         (LayoutTestController::copyDecodedHostName):
2647         (LayoutTestController::copyEncodedHostName):
2648         (LayoutTestController::display):
2649         (LayoutTestController::keepWebHistory):
2650         (LayoutTestController::notifyDone):
2651         (LayoutTestController::queueBackNavigation):
2652         (LayoutTestController::queueForwardNavigation):
2653         (jsStringRefToWString):
2654         (LayoutTestController::queueLoad):
2655         (LayoutTestController::queueReload):
2656         (LayoutTestController::queueScript):
2657         (LayoutTestController::setAcceptsEditing):
2658         (LayoutTestController::setCustomPolicyDelegate):
2659         (LayoutTestController::setMainFrameIsFirstResponder):
2660         (LayoutTestController::setTabKeyCyclesThroughElements):
2661         (LayoutTestController::setUseDashboardCompatibilityMode):
2662         (LayoutTestController::setUserStyleSheetEnabled):
2663         (LayoutTestController::setUserStyleSheetLocation):
2664         (LayoutTestController::setWindowIsKey):
2665         (waitUntilDoneWatchdogFired):
2666         (LayoutTestController::setWaitToDump):
2667         (LayoutTestController::windowCount):
2668         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2669         (FrameLoadDelegate::didReceiveTitle):
2670         (FrameLoadDelegate::processWork):
2671         (FrameLoadDelegate::locationChangeDone):
2672         (FrameLoadDelegate::windowScriptObjectAvailable):
2673         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2674         * DumpRenderTree/win/WorkQueue.h: Removed.
2675         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2676         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2677         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2678         (jsStringRefToWString):
2679         (LoadItem::invoke):
2680         (ScriptItem::invoke):
2681
2682 2007-09-17  Sam Weinig  <sam@webkit.org>
2683
2684         Reviewed by Adam Roben.
2685
2686         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2687
2688         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2689         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2690         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2691         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2692         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2693         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2694         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2695         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2696         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2697         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2698         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2699         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2700         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2701         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
2702         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
2703         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
2704         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
2705         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
2706         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
2707         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
2708         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
2709         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
2710         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
2711         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
2712         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
2713         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
2714         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
2715         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
2716         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2717         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2718         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2719         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
2720         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
2721         * DumpRenderTree/win: Added.
2722         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
2723         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
2724         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
2725         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
2726         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
2727         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
2728         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
2729         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
2730         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
2731         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
2732         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
2733         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
2734         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
2735         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2736         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
2737         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
2738         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
2739         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
2740         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2741         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2742         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
2743         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2744         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
2745         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
2746         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
2747         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
2748
2749 2007-09-15  Mark Rowe  <mrowe@apple.com>
2750
2751         Build fix for DumpRenderTree.
2752
2753         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
2754
2755 2007-09-14  Sam Weinig  <sam@webkit.org>
2756
2757         Rubber stamped by Adam Roben.
2758
2759         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
2760           - The UIDelegate was put into a new file while the FrameLoadDelegate was
2761             kept in the WaitUntilDoneDelegate file for the time being.
2762
2763         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2764         (main):
2765         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
2766         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
2767         (UIDelegate::QueryInterface):
2768         (UIDelegate::AddRef):
2769         (UIDelegate::Release):
2770         (UIDelegate::hasCustomMenuImplementation):
2771         (UIDelegate::setFrame):
2772         (UIDelegate::webViewFrame):
2773         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2774         (UIDelegate::webViewAddMessageToConsole):
2775         (UIDelegate::doDragDrop):
2776         (UIDelegate::webViewGetDlgCode):
2777         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
2778         (UIDelegate::UIDelegate):
2779         (UIDelegate::createWebViewWithRequest):
2780         (UIDelegate::webViewShow):
2781         (UIDelegate::webViewClose):
2782         (UIDelegate::webViewFocus):
2783         (UIDelegate::webViewUnfocus):
2784         (UIDelegate::webViewFirstResponder):
2785         (UIDelegate::makeFirstResponder):
2786         (UIDelegate::setStatusText):
2787         (UIDelegate::webViewStatusText):
2788         (UIDelegate::webViewAreToolbarsVisible):
2789         (UIDelegate::setToolbarsVisible):
2790         (UIDelegate::webViewIsStatusBarVisible):
2791         (UIDelegate::setStatusBarVisible):
2792         (UIDelegate::webViewIsResizable):
2793         (UIDelegate::setResizable):
2794         (UIDelegate::setContentRect):
2795         (UIDelegate::webViewContentRect):
2796         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2797         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2798         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2799         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
2800         (UIDelegate::mouseDidMoveOverElement):
2801         (UIDelegate::contextMenuItemsForElement):
2802         (UIDelegate::validateUserInterfaceItem):
2803         (UIDelegate::shouldPerformAction):
2804         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
2805         (UIDelegate::willPerformDragDestinationAction):
2806         (UIDelegate::dragSourceActionMaskForPoint):
2807         (UIDelegate::willPerformDragSourceAction):
2808         (UIDelegate::contextMenuItemSelected):
2809         (UIDelegate::trackCustomPopupMenu):
2810         (UIDelegate::measureCustomMenuItem):
2811         (UIDelegate::drawCustomMenuItem):
2812         (UIDelegate::addCustomMenuDrawingData):
2813         (UIDelegate::cleanUpCustomMenuDrawingData):
2814         (UIDelegate::canTakeFocus):
2815         (UIDelegate::takeFocus):
2816         (UIDelegate::registerUndoWithTarget):
2817         (UIDelegate::removeAllActionsWithTarget):
2818         (UIDelegate::setActionTitle):
2819         (UIDelegate::undo):
2820         (UIDelegate::redo):
2821         (UIDelegate::canUndo):
2822         (UIDelegate::canRedo):
2823         (UIDelegate::webViewResizerRect):
2824         (UIDelegate::webViewDrawResizer):
2825         (UIDelegate::webViewScrolled):
2826         (UIDelegate::webViewShouldInterruptJavaScript):
2827         (UIDelegate::webViewReceivedFocus):
2828         (UIDelegate::webViewLostFocus):
2829         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
2830         (FrameLoadDelegate::QueryInterface):
2831         (FrameLoadDelegate::AddRef):
2832         (FrameLoadDelegate::Release):
2833         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2834         (FrameLoadDelegate::didCommitLoadForFrame):
2835         (FrameLoadDelegate::didReceiveTitle):
2836         (FrameLoadDelegate::processWork):
2837         (processWorkTimer):
2838         (FrameLoadDelegate::locationChangeDone):
2839         (FrameLoadDelegate::didFinishLoadForFrame):
2840         (FrameLoadDelegate::didFailLoadWithError):
2841         (FrameLoadDelegate::windowScriptObjectAvailable):
2842         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
2843         (FrameLoadDelegate::FrameLoadDelegate):
2844
2845 2007-09-14  Sam Weinig  <sam@webkit.org>
2846
2847         Reviewed by Kevin McCullough.
2848
2849         Move mac specific globals in to mac/DumpRenderTreeMac.h
2850
2851         * DumpRenderTree/DumpRenderTree.h:
2852         * DumpRenderTree/DumpRenderTree.mm: Removed.
2853         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2854         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
2855         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
2856
2857 2007-09-14  Brady Eidson  <beidson@apple.com>
2858
2859         Rubberstamped by Weinig
2860
2861         You know, Sam, some of us use case-sensitve filesystems...
2862
2863         * DumpRenderTree/DumpRenderTree.h:
2864         * DumpRenderTree/mac/UIDelegate.mm:
2865
2866 2007-09-14  Sam Weinig  <sam@webkit.org>
2867
2868         Rubber stamped by Adam Roben.
2869
2870         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
2871         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
2872
2873         * DumpRenderTree/AppleScriptController.h: Removed.
2874         * DumpRenderTree/AppleScriptController.m: Removed.
2875         * DumpRenderTree/DumpRenderTree.h:
2876         * DumpRenderTree/DumpRenderTree.mm:
2877         (startJavaScriptThreads):
2878         (stopJavaScriptThreads):
2879         (activateAhemFont):
2880         (setDefaultColorProfileToRGB):
2881         (makeLargeMallocFailSilently):
2882         (dumpFrameScrollPosition):
2883         (dumpFramesAsText):
2884         (dump):
2885         (runTest):
2886         (-[DumpRenderTreeWindow isKeyWindow]):
2887         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2888         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
2889         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
2890         * DumpRenderTree/EditingDelegate.h: Removed.
2891         * DumpRenderTree/EditingDelegate.m: Removed.
2892         * DumpRenderTree/EventSendingController.h: Removed.
2893         * DumpRenderTree/EventSendingController.m: Removed.
2894         * DumpRenderTree/FrameLoadDelegate.h: Removed.
2895         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
2896         * DumpRenderTree/GCController.mm: Removed.
2897         * DumpRenderTree/ImageDiff.m: Removed.
2898         * DumpRenderTree/LayoutTestController.cpp:
2899         (LayoutTestController::LayoutTestController):
2900         (dumpAsTextCallback):
2901         (dumpBackForwardListCallback):
2902         (dumpChildFramesAsTextCallback):
2903         (dumpChildFrameScrollPositionsCallback):
2904         (dumpDOMAsWebArchiveCallback):
2905         (dumpEditingCallbacksCallback):
2906         (dumpFrameLoadCallbacksCallback):
2907         (dumpResourceLoadCallbacksCallback):
2908         (dumpSelectionRectCallback):
2909         (dumpSourceAsWebArchiveCallback):
2910         (dumpTitleChangesCallback):
2911         (repaintSweepHorizontallyCallback):
2912         (setCallCloseOnWebViewsCallback):
2913         (setCanOpenWindowsCallback):
2914         (setCloseRemainingWindowsWhenCompleteCallback):
2915         (testRepaintCallback):
2916         (addFileToPasteboardOnDragCallback):
2917         (waitUntilDoneCallback):
2918         * DumpRenderTree/LayoutTestController.h:
2919         (LayoutTestController::dumpAsText):
2920         (LayoutTestController::setDumpAsText):
2921         (LayoutTestController::dumpBackForwardList):
2922         (LayoutTestController::setDumpBackForwardList):
2923         (LayoutTestController::dumpChildFrameScrollPositions):
2924         (LayoutTestController::setDumpChildFrameScrollPositions):
2925         (LayoutTestController::dumpChildFramesAsText):
2926         (LayoutTestController::setDumpChildFramesAsText):
2927         (LayoutTestController::dumpDOMAsWebArchive):
2928         (LayoutTestController::setDumpDOMAsWebArchive):
2929         (LayoutTestController::dumpSelectionRect):
2930         (LayoutTestController::setDumpSelectionRect):
2931         (LayoutTestController::dumpSourceAsWebArchive):
2932         (LayoutTestController::setDumpSourceAsWebArchive):
2933         (LayoutTestController::dumpTitleChanges):
2934         (LayoutTestController::setDumpTitleChanges):
2935         (LayoutTestController::dumpEditingCallbacks):
2936         (LayoutTestController::setDumpEditingCallbacks):
2937         (LayoutTestController::dumpResourceLoadCallbacks):
2938         (LayoutTestController::setDumpResourceLoadCallbacks):
2939         (LayoutTestController::dumpFrameLoadCallbacks):
2940         (LayoutTestController::setDumpFrameLoadCallbacks):
2941         (LayoutTestController::addFileToPasteboardOnDrag):
2942         (LayoutTestController::setAddFileToPasteboardOnDrag):
2943         (LayoutTestController::callCloseOnWebViews):
2944         (LayoutTestController::setCallCloseOnWebViews):
2945         (LayoutTestController::canOpenWindows):
2946         (LayoutTestController::setCanOpenWindows):
2947         (LayoutTestController::closeRemainingWindowsWhenComplete):
2948         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2949         (LayoutTestController::testRepaint):
2950         (LayoutTestController::setTestRepaint):
2951         (LayoutTestController::testRepaintSweepHorizontally):
2952         (LayoutTestController::setTestRepaintSweepHorizontally):
2953         (LayoutTestController::waitToDump):
2954         (LayoutTestController::windowIsKey):
2955         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
2956         * DumpRenderTree/NavigationController.h: Removed.
2957         * DumpRenderTree/NavigationController.m: Removed.
2958         * DumpRenderTree/ObjCController.h: Removed.
2959         * DumpRenderTree/ObjCController.m: Removed.
2960         * DumpRenderTree/ObjCPlugin.h: Removed.
2961         * DumpRenderTree/ObjCPlugin.m: Removed.
2962         * DumpRenderTree/ObjCPluginFunction.h: Removed.
2963         * DumpRenderTree/ObjCPluginFunction.m: Removed.
2964         * DumpRenderTree/PolicyDelegate.h: Removed.
2965         * DumpRenderTree/PolicyDelegate.m: Removed.
2966         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
2967         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
2968         * DumpRenderTree/TextInputController.h: Removed.
2969         * DumpRenderTree/TextInputController.m: Removed.
2970         * DumpRenderTree/UIDelegate.h: Removed.
2971         * DumpRenderTree/UIDelegate.mm: Removed.
2972         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
2973         * DumpRenderTree/mac: Added.
2974         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
2975         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
2976         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
2977         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
2978         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
2979         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
2980         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2981         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2982         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2983         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2984         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2985         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2986         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2987         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2988         (-[EditingDelegate webViewDidBeginEditing:]):
2989         (-[EditingDelegate webViewDidChange:]):
2990         (-[EditingDelegate webViewDidEndEditing:]):
2991         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2992         (-[EditingDelegate webViewDidChangeSelection:]):
2993         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
2994         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
2995         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
2996         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
2997         (-[FrameLoadDelegate init]):
2998         (-[FrameLoadDelegate dealloc]):
2999         (-[FrameLoadDelegate processWork:]):
3000         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3001         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3002         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3003         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3004         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3005         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3006         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3007         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3008         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3009         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3010         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3011         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3012         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3013         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3014         (-[FrameLoadDelegate webView:willCloseFrame:]):
3015         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3016         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3017         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
3018         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
3019         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
3020         (LayoutTestController::notifyDone):
3021         (LayoutTestController::setWindowIsKey):
3022         (LayoutTestController::setWaitToDump):
3023         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
3024         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
3025         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
3026         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
3027         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
3028         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
3029         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
3030         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
3031         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
3032         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
3033         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
3034         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
3035         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3036         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3037         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3038         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3039         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3040         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3041         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
3042         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
3043         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
3044         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
3045         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
3046         (-[UIDelegate webViewFocus:]):
3047         (-[UIDelegate webView:createWebViewWithRequest:]):
3048         (-[UIDelegate webViewClose:]):
3049         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
3050
3051 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
3052
3053         Reviewed by Adam.
3054
3055         - Changing Win version of Drosera work with recent changes.
3056
3057         * Drosera/DebuggerDocument.cpp:
3058         * Drosera/DebuggerDocument.h:
3059         * Drosera/mac/DebuggerDocumentPlatform.mm:
3060         (NSStringCreateWithJSStringRef):
3061         (JSValueRefCreateWithNSString):
3062         * Drosera/win/DebuggerClient.cpp:
3063         (DebuggerClient::stepInto):
3064         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3065
3066 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
3067
3068         Reviewed by Tim.
3069
3070         - Moved isPaused into the JS for efficiency and simplicity.
3071
3072         * Drosera/DebuggerDocument.cpp:
3073         (DebuggerDocument::DebuggerDocument):
3074         (DebuggerDocument::pauseCallback):
3075         (DebuggerDocument::resumeCallback):
3076         (DebuggerDocument::isPaused):
3077         (DebuggerDocument::staticFunctions):
3078         * Drosera/DebuggerDocument.h:
3079         * Drosera/console.js:
3080         * Drosera/debugger.js:
3081         * Drosera/mac/DebuggerClient.mm:
3082         (-[DebuggerClient validateUserInterfaceItem:]):
3083
3084 2007-09-13  Sam Weinig  <sam@webkit.org>
3085
3086         Rubber stamped by Darin.
3087
3088         Make DumpRenderTree more cross platform ready.
3089         - Convert GCController to use the JSCore API instead of the WebScriptObject.
3090         - Use CF types instead of NS objects.
3091         - General cleanup.
3092
3093         * DumpRenderTree/DumpRenderTree.h:
3094         * DumpRenderTree/DumpRenderTree.mm:
3095         (dumpRenderTree):
3096         (dump):
3097         (runTest):
3098         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3099         * DumpRenderTree/EditingDelegate.m:
3100         * DumpRenderTree/FrameLoadDelegate.h:
3101         * DumpRenderTree/FrameLoadDelegate.mm:
3102         (-[FrameLoadDelegate init]):
3103         (-[FrameLoadDelegate dealloc]):
3104         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3105         * DumpRenderTree/GCController.cpp: Added.
3106         (GCController::GCController):
3107         (GCController::~GCController):
3108         (collectCallback):
3109         (collectOnAlternateThreadCallback):
3110         (getJSObjectCountCallback):
3111         (GCController::makeWindowObject):
3112         (GCController::getJSClass):
3113         (GCController::staticFunctions):
3114         * DumpRenderTree/GCController.h:
3115         * DumpRenderTree/GCController.mm:
3116         (GCController::collect):
3117         (GCController::collectOnAlternateThread):
3118         (GCController::getJSObjectCount):
3119         * DumpRenderTree/LayoutTestController.cpp:
3120         (LayoutTestController::makeWindowObject):
3121         (LayoutTestController::getJSClass):
3122         * DumpRenderTree/LayoutTestController.h:
3123         * DumpRenderTree/LayoutTestControllerMac.mm:
3124         (LayoutTestController::addDisallowedURL):
3125         (waitUntilDoneWatchdogFired):
3126         (LayoutTestController::waitUntilDone):
3127         * DumpRenderTree/ResourceLoadDelegate.m:
3128         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3129
3130 2007-09-12  Sam Weinig  <sam@webkit.org>
3131
3132         Reviewed by Stephanie.
3133
3134         Fix leaks in mac DumpRenderTree.
3135
3136         * DumpRenderTree/FrameLoadDelegate.mm:
3137         (-[FrameLoadDelegate init]): Initalize in the correct order.
3138         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
3139         * DumpRenderTree/LayoutTestController.cpp:
3140         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
3141         (encodeHostNameCallback): ditto.
3142         * DumpRenderTree/LayoutTestController.h:
3143         * DumpRenderTree/LayoutTestControllerMac.mm:
3144         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
3145         (LayoutTestController::copyEncodedHostName): ditto
3146         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
3147
3148 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3149
3150         Reviewed by Geof.
3151
3152         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
3153
3154         * Scripts/run-webkit-tests:
3155
3156 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3157
3158         Reviewed by Darin.
3159
3160         - Simplified code paths and extracted out functions to increase encapsulation.
3161
3162         * Drosera/DebuggerDocument.cpp:
3163         (DebuggerDocument::breakpointEditorHTMLCallback):
3164         (DebuggerDocument::isPausedCallback):
3165         (DebuggerDocument::pauseCallback):
3166         (DebuggerDocument::resumeCallback):
3167         (DebuggerDocument::stepIntoCallback):
3168         (DebuggerDocument::evaluateScriptCallback):
3169         (DebuggerDocument::currentFunctionStackCallback):
3170         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3171         (DebuggerDocument::valueForScopeVariableNamedCallback):
3172         (DebuggerDocument::logCallback):
3173         * Drosera/DebuggerDocument.h:
3174         (DebuggerDocument::getPaused):
3175         * Drosera/mac/DebuggerClient.mm:
3176         (-[DebuggerClient pause:]):
3177         (-[DebuggerClient resume:]):
3178         (-[DebuggerClient stepInto:]):
3179         (-[DebuggerClient stepOver:]):
3180         (-[DebuggerClient stepOut:]):
3181         (-[DebuggerClient showConsole:]):
3182         (-[DebuggerClient closeCurrentFile:]):
3183         (-[DebuggerClient validateUserInterfaceItem:]):
3184         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
3185         (+[NSString stringOrNilFromWebScriptResult:]):
3186         (DebuggerDocument::platformPause):
3187         (DebuggerDocument::platformResume):
3188         (DebuggerDocument::platformStepInto):
3189         (DebuggerDocument::platformEvaluateScript):
3190         (DebuggerDocument::getPlatformCurrentFunctionStack):
3191         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3192         (DebuggerDocument::platformValueForScopeVariableNamed):
3193         (DebuggerDocument::platformLog):
3194         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3195
3196 2007-09-12  Sam Weinig  <sam@webkit.org>
3197
3198         Build fix for Buildbot.
3199
3200         * DumpRenderTree/DumpRenderTree.mm:
3201         (dump):
3202
3203 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3204
3205         Reviewed by Geoff.
3206
3207         - Updated the leaks list for leopard to help identify regressions.
3208
3209         * Scripts/run-webkit-tests:
3210
3211 2007-09-12  Sam Weinig  <sam@webkit.org>
3212
3213         Rubber stamped by Darin.
3214
3215         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
3216
3217         * DumpRenderTree/DumpRenderTree.h: Re-order variables. 
3218         * DumpRenderTree/DumpRenderTree.m: Removed.
3219         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
3220         (stopJavaScriptThreads): Fix initialization.
3221         (setDefaultColorProfileToRGB): Add explicit cast from void*.
3222         (dumpRenderTree): Ditto.
3223         (runTest):
3224         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
3225
3226         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3227         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
3228         * DumpRenderTree/FrameLoadDelegate.m: Removed.
3229         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
3230         (-[FrameLoadDelegate init]):
3231         (-[FrameLoadDelegate dealloc]):
3232         (-[FrameLoadDelegate processWork:]):
3233         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3234         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3235         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
3236         
3237         * DumpRenderTree/LayoutTestController.cpp: Added.
3238         (LayoutTestController::LayoutTestController):
3239         (LayoutTestController::~LayoutTestController):
3240         (dumpAsTextCallback):
3241         (dumpBackForwardListCallback):
3242         (dumpChildFramesAsTextCallback):
3243         (dumpChildFrameScrollPositionsCallback):
3244         (dumpDOMAsWebArchiveCallback):
3245         (dumpEditingCallbacksCallback):
3246         (dumpFrameLoadCallbacksCallback):
3247         (dumpResourceLoadCallbacksCallback):
3248         (dumpSelectionRectCallback):
3249         (dumpSourceAsWebArchiveCallback):
3250         (dumpTitleChangesCallback):
3251         (repaintSweepHorizontallyCallback):
3252         (setCallCloseOnWebViewsCallback):
3253         (setCanOpenWindowsCallback):
3254         (setCloseRemainingWindowsWhenCompleteCallback):
3255         (testRepaintCallback):
3256         (addFileToPasteboardOnDragCallback):
3257         (addDisallowedURLCallback):
3258         (clearBackForwardListCallback):
3259         (decodeHostNameCallback):
3260         (displayCallback):
3261         (encodeHostNameCallback):
3262         (keepWebHistoryCallback):
3263         (notifyDoneCallback):
3264         (queueBackNavigationCallback):
3265         (queueForwardNavigationCallback):
3266         (queueLoadCallback):
3267         (queueReloadCallback):
3268         (queueScriptCallback):
3269         (setAcceptsEditingCallback):
3270         (setCustomPolicyDelegateCallback):
3271         (setMainFrameIsFirstResponderCallback):
3272         (setTabKeyCyclesThroughElementsCallback):
3273         (setUseDashboardCompatibilityModeCallback):
3274         (setUserStyleSheetEnabledCallback):
3275         (setUserStyleSheetLocationCallback):
3276         (setWindowIsKeyCallback):
3277         (waitUntilDoneCallback):
3278         (windowCountCallback):
3279         (LayoutTestController::makeWindowObject):
3280         (LayoutTestController::getLayoutTestControllerJSClass):
3281         (LayoutTestController::staticFunctions):
3282         * DumpRenderTree/LayoutTestController.h: Replaced.
3283         * DumpRenderTree/LayoutTestController.m: Removed.
3284         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
3285         (LayoutTestController::dumpAsText):
3286         (LayoutTestController::dumpBackForwardList):
3287         (LayoutTestController::dumpChildFramesAsText):
3288         (LayoutTestController::dumpChildFrameScrollPositions):
3289         (LayoutTestController::dumpDOMAsWebArchive):
3290         (LayoutTestController::dumpEditingCallbacks):
3291         (LayoutTestController::dumpFrameLoadCallbacks):
3292         (LayoutTestController::dumpResourceLoadCallbacks):
3293         (LayoutTestController::dumpSelectionRect):
3294         (LayoutTestController::dumpSourceAsWebArchive):
3295         (LayoutTestController::dumpTitleChanges):
3296         (LayoutTestController::repaintSweepHorizontally):
3297         (LayoutTestController::setCallCloseOnWebViews):
3298         (LayoutTestController::setCanOpenWindows):
3299         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3300         (LayoutTestController::testRepaint):
3301         (LayoutTestController::addFileToPasteboardOnDrag):
3302         (LayoutTestController::addDisallowedURL):
3303         (LayoutTestController::clearBackForwardList):
3304         (LayoutTestController::decodeHostName):
3305         (LayoutTestController::encodeHostName):
3306         (LayoutTestController::display):
3307         (LayoutTestController::keepWebHistory):
3308         (LayoutTestController::notifyDone):
3309         (LayoutTestController::queueBackNavigation):
3310         (LayoutTestController::queueForwardNavigation):
3311         (LayoutTestController::queueLoad):
3312         (LayoutTestController::queueReload):
3313         (LayoutTestController::queueScript):
3314         (LayoutTestController::setAcceptsEditing):
3315         (LayoutTestController::setCustomPolicyDelegate):
3316         (LayoutTestController::setMainFrameIsFirstResponder):
3317         (LayoutTestController::setTabKeyCyclesThroughElements):
3318         (LayoutTestController::setUseDashboardCompatibilityMode):
3319         (LayoutTestController::setUserStyleSheetEnabled):
3320         (LayoutTestController::setUserStyleSheetLocation):
3321         (LayoutTestController::setWindowIsKey):
3322         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
3323         (LayoutTestController::waitUntilDone):
3324         (LayoutTestController::windowCount):
3325         Use the JSCore API to implement the LayoutTestController.
3326
3327         * DumpRenderTree/ObjCController.h:
3328         * DumpRenderTree/ObjCController.m:
3329         (+[ObjCController isSelectorExcludedFromWebScript:]):
3330         (+[ObjCController webScriptNameForSelector:]):
3331         (-[ObjCController accessStoredWebScriptObject]):
3332         (-[ObjCController storeWebScriptObject:]):
3333         (-[ObjCController dealloc]):
3334         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
3335         Move WebScriptObject tests to ObjCController.
3336
3337         * DumpRenderTree/UIDelegate.m: Removed.
3338         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
3339
3340         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3341         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3342         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3343         (WorkQueueItem::~WorkQueueItem):
3344         (LoadItem::LoadItem):
3345         (LoadItem::url):
3346         (LoadItem::target):
3347         (ScriptItem::ScriptItem):
3348         (ScriptItem::script):
3349         * DumpRenderTree/WorkQueueItemMac.mm: Added.
3350         (LoadItem::invoke):
3351         (ReloadItem::invoke):
3352         (ScriptItem::invoke):
3353         (BackForwardItem::invoke):
3354         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
3355         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
3356         sharing code.
3357
3358 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3359
3360         Reviewed by Maciej.
3361
3362         - Updated Win side to take advantage of the platform separating changes.
3363
3364         * Drosera/DebuggerDocument.cpp:
3365         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3366         * Drosera/DebuggerDocument.h:
3367         * Drosera/win/DebuggerClient.cpp:
3368         (DebuggerClient::pause):
3369         (DebuggerClient::resume):
3370         (DebuggerClient::stepInto):
3371         (DebuggerDocument::platformPause):
3372         (DebuggerDocument::platformResume):
3373         (DebuggerDocument::platformStepInto):
3374         (DebuggerDocument::platformEvaluateScript):
3375         (DebuggerDocument::getPlatformCurrentFunctionStack):
3376         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3377         (DebuggerDocument::platformValueForScopeVariableNamed):
3378         (DebuggerDocument::platformLog):
3379         * Drosera/win/DebuggerClient.h:
3380         * Drosera/win/Drosera.cpp:
3381         (Drosera::Drosera):
3382         (Drosera::windowScriptObjectAvailable):
3383         (Drosera::initWithServerName):
3384         (Drosera::switchToServerNamed):
3385         * Drosera/win/Drosera.h:
3386         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3387
3388 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3389
3390         Reviewed by Adam.
3391
3392         - Just doing the moves in a separate patch so the changes are easier to see.
3393
3394         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
3395         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
3396         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
3397         * Drosera/win/DebuggerDocumentWin.h: Removed.
3398         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3399
3400 2007-09-11  Sven Herzberg  <sven@imendio.com>
3401
3402         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
3403         http://bugs.webkit.org/show_bug.cgi?id=15176
3404
3405         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
3406         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
3407         other paths eg. from jhbuild)
3408
3409 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3410
3411         Reviewed by Adam.
3412
3413         - Made an order-of-deletion mistake.
3414
3415         * Drosera/DebuggerDocument.h:
3416         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
3417         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
3418         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
3419         * Drosera/mac/DebuggerClient.mm:
3420         (DebuggerDocument::platformPause):
3421         (DebuggerDocument::platformResume):
3422         (DebuggerDocument::platformStepInto):
3423         (DebuggerDocument::platformEvaluateScript):
3424         (DebuggerDocument::getPlatformCurrentFunctionStack):
3425         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3426         (DebuggerDocument::platformValueForScopeVariableNamed):
3427         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3428
3429 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3430
3431         Reviewed by Darin.
3432
3433         - Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
3434
3435         * Drosera/DebuggerDocument.cpp:
3436         (DebuggerDocument::DebuggerDocument):
3437         * Drosera/DebuggerDocument.h:
3438         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3439         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3440         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3441         * Drosera/mac/DebuggerApplication.mm:
3442         (-[DebuggerApplication attach:]):
3443         * Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
3444         * Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm.
3445         (DebuggerDocument::platformPause):
3446         (DebuggerDocument::platformResume):
3447         (DebuggerDocument::platformStepInto):
3448         (DebuggerDocument::platformEvaluateScript):
3449         (DebuggerDocument::getPlatformCurrentFunctionStack):
3450         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3451         (DebuggerDocument::platformValueForScopeVariableNamed):
3452         (DebuggerDocument::platformLog):
3453         * Drosera/mac/DebuggerDocumentMac.h: Removed.
3454         * Drosera/mac/DebuggerDocumentMac.mm: Removed.
3455         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3456
3457 2007-09-09  Sam Weinig  <sam@webkit.org>
3458
3459         Reviewed by Mark Rowe.
3460
3461         Remove 'objC' prefix from methods now in the ObjCController. 
3462
3463         * DumpRenderTree/ObjCController.m:
3464         (+[ObjCController isSelectorExcludedFromWebScript:]):
3465         (+[ObjCController webScriptNameForSelector:]):
3466         (-[ObjCController classNameOf:]):
3467         (-[ObjCController objectOfClass:]):
3468         (-[ObjCController identityIsEqual::]):
3469         (-[ObjCController longLongRoundTrip:]):
3470         (-[ObjCController unsignedLongLongRoundTrip:]):
3471
3472 2007-09-09  Sam Weinig  <sam@webkit.org>
3473
3474         Reviewed by Oliver.
3475
3476         Initial refactor of DumpRenderTree in preparation of making it more platform independent. 
3477         - Move LayoutTestController into its own file.
3478         - Move Objective-C only functions on LayoutTestController into a new controller called the
3479           ObjCController. 
3480
3481         * DumpRenderTree/DumpRenderTree.h:
3482         * DumpRenderTree/DumpRenderTree.m:
3483         (displayWebView):
3484         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3485         * DumpRenderTree/FrameLoadDelegate.m:
3486         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3487         * DumpRenderTree/LayoutTestController.h: Added.
3488         * DumpRenderTree/LayoutTestController.m: Added.
3489         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3490         (+[LayoutTestController webScriptNameForSelector:]):
3491         (-[LayoutTestController clearBackForwardList]):
3492         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
3493         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
3494         (-[LayoutTestController setCustomPolicyDelegate:]):
3495         (-[LayoutTestController keepWebHistory]):
3496         (-[LayoutTestController setCallCloseOnWebViews:]):
3497         (-[LayoutTestController setCanOpenWindows]):
3498         (-[LayoutTestController waitUntilDone]):
3499         (-[LayoutTestController waitUntilDoneWatchdogFired]):
3500         (-[LayoutTestController notifyDone]):
3501         (-[LayoutTestController dumpAsText]):
3502         (-[LayoutTestController addFileToPasteboardOnDrag]):
3503         (-[LayoutTestController addDisallowedURL:]):
3504         (-[LayoutTestController setUserStyleSheetLocation:]):
3505         (-[LayoutTestController setUserStyleSheetEnabled:]):
3506         (-[LayoutTestController dumpDOMAsWebArchive]):
3507         (-[LayoutTestController dumpSourceAsWebArchive]):
3508         (-[LayoutTestController dumpSelectionRect]):
3509         (-[LayoutTestController dumpTitleChanges]):
3510         (-[LayoutTestController dumpBackForwardList]):
3511         (-[LayoutTestController windowCount]):
3512         (-[LayoutTestController dumpChildFrameScrollPositions]):
3513         (-[LayoutTestController dumpChildFramesAsText]):
3514         (-[LayoutTestController dumpEditingCallbacks]):
3515         (-[LayoutTestController dumpResourceLoadCallbacks]):
3516         (-[LayoutTestController dumpFrameLoadCallbacks]):
3517         (-[LayoutTestController setWindowIsKey:]):
3518         (-[LayoutTestController setMainFrameIsFirstResponder:]):
3519         (-[LayoutTestController display]):
3520         (-[LayoutTestController testRepaint]):
3521         (-[LayoutTestController repaintSweepHorizontally]):
3522         (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
3523         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
3524         (-[LayoutTestController _doLoad:target:]):
3525         (-[LayoutTestController _doBackOrForwardNavigation:]):
3526         (-[LayoutTestController queueBackNavigation:]):
3527         (-[LayoutTestController queueForwardNavigation:]):
3528         (-[LayoutTestController queueReload]):
3529         (-[LayoutTestController queueScript:]):
3530         (-[LayoutTestController queueLoad:target:]):
3531         (-[LayoutTestController setAcceptsEditing:]):
3532         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
3533         (-[LayoutTestController storeWebScriptObject:]):
3534         (-[LayoutTestController accessStoredWebScriptObject]):
3535         (-[LayoutTestController dealloc]):
3536         (-[LayoutTestController decodeHostName:]):
3537         (-[LayoutTestController encodeHostName:]):
3538         * DumpRenderTree/ObjCController.h: Added.
3539         * DumpRenderTree/ObjCController.m: Added.
3540         (+[ObjCController isSelectorExcludedFromWebScript:]):
3541         (+[ObjCController webScriptNameForSelector:]):
3542         (-[ObjCController objCClassNameOf:]):
3543         (-[ObjCController objCObjectOfClass:]):
3544         (-[ObjCController objCIdentityIsEqual::]):
3545         (-[ObjCController objCLongLongRoundTrip:]):
3546         (-[ObjCController objCUnsignedLongLongRoundTrip:]):
3547         (-[ObjCController testWrapperRoundTripping:]):
3548
3549 2007-09-07  Sam Weinig  <sam@webkit.org>
3550
3551         Reviewed by Alice.
3552
3553         Strip trailing and leading space/newline characters from skiplist file names.
3554
3555         * Scripts/run-webkit-tests:
3556
3557 2007-09-06  Kevin McCullough  <kmccullough@apple.com>
3558
3559         Reviewed by Maciej.
3560
3561         - Changed Drosera to take advantage of the JSRetainPtr changes.
3562
3563         * Drosera/DebuggerDocument.cpp:
3564         (DebuggerDocument::breakpointEditorHTML):
3565         (DebuggerDocument::evaluateScript):
3566         (DebuggerDocument::valueForScopeVariableNamed):
3567         (DebuggerDocument::log):
3568         (DebuggerDocument::windowScriptObjectAvailable):
3569         (DebuggerDocument::toJSArray):
3570         (DebuggerDocument::callFunctionOnObject):
3571         (DebuggerDocument::logException):
3572         * Drosera/mac/DebuggerDocumentMac.mm:
3573         (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
3574         (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3575         (DebuggerDocument::platformEvaluateScript):
3576         (DebuggerDocument::getPlatformCurrentFunctionStack):
3577         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3578         (DebuggerDocument::platformValueForScopeVariableNamed):
3579
3580 2007-09-05  Kevin McCullough  <kmccullough@apple.com>
3581
3582         Reviewed by Adam, Sam, Darin.
3583
3584         - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.
3585
3586         * Drosera/Debugger.h: Added.
3587         * Drosera/DebuggerDocument.cpp:
3588         (DebuggerDocument::breakpointEditorHTMLCallback):
3589         (DebuggerDocument::isPausedCallback):
3590         (DebuggerDocument::pauseCallback):
3591         (DebuggerDocument::resumeCallback):
3592         (DebuggerDocument::stepIntoCallback):
3593         (DebuggerDocument::evaluateScriptCallback):
3594         (DebuggerDocument::currentFunctionStackCallback):
3595         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3596         (DebuggerDocument::valueForScopeVariableNamedCallback):
3597         (DebuggerDocument::logCallback):
3598         (DebuggerDocument::breakpointEditorHTML):
3599         (DebuggerDocument::isPaused):
3600         (DebuggerDocument::pause):
3601         (DebuggerDocument::resume):
3602         (DebuggerDocument::stepInto):
3603         (DebuggerDocument::evaluateScript):
3604         (DebuggerDocument::currentFunctionStack):
3605         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3606         (DebuggerDocument::valueForScopeVariableNamed):
3607         (DebuggerDocument::log):
3608         (DebuggerDocument::toolbarPause):
3609         (DebuggerDocument::toolbarResume):
3610         (DebuggerDocument::toolbarStepInto):
3611         (DebuggerDocument::toolbarStepOver):
3612         (DebuggerDocument::toolbarStepOut):
3613         (DebuggerDocument::toolbarShowConsole):
3614         (DebuggerDocument::toolbarCloseCurrentFile):
3615         (DebuggerDocument::updateFileSource):
3616         (DebuggerDocument::didParseScript):
3617         (DebuggerDocument::willExecuteStatement):
3618         (DebuggerDocument::didEnterCallFrame):
3619         (DebuggerDocument::willLeaveCallFrame):
3620         (DebuggerDocument::exceptionWasRaised):
3621         (DebuggerDocument::windowScriptObjectAvailable):
3622         (DebuggerDocument::toJSArray):
3623         (DebuggerDocument::callGlobalFunction):
3624         (DebuggerDocument::callFunctionOnObject):
3625         (DebuggerDocument::getDroseraJSClass):
3626         (DebuggerDocument::staticFunctions):
3627         (DebuggerDocument::logException):
3628         * Drosera/DebuggerDocument.h:
3629         (DebuggerDocument::DebuggerDocument):
3630         * Drosera/ForwardingHeaders: Added.
3631         * Drosera/ForwardingHeaders/wtf: Added.
3632         * Drosera/ForwardingHeaders/wtf/Platform.h: Added.
3633         * Drosera/config.h:
3634         * Drosera/console.html:
3635         * Drosera/console.js:
3636         * Drosera/debugger.js:
3637         * Drosera/mac/DebuggerApplication.mm:
3638         (-[DebuggerApplication attach:]):
3639         * Drosera/mac/DebuggerDocumentMac.h:
3640         * Drosera/mac/DebuggerDocumentMac.mm:
3641         (+[NSString stringOrNilFromWebScriptResult:]):
3642         (+[DebuggerClientMac log:]):
3643         (-[DebuggerClientMac initWithServerName:]):
3644         (-[DebuggerClientMac dealloc]):
3645         (-[DebuggerClientMac pause]):
3646         (-[DebuggerClientMac resume]):
3647         (-[DebuggerClientMac pause:]):
3648         (-[DebuggerClientMac resume:]):
3649         (-[DebuggerClientMac stepInto:]):
3650         (-[DebuggerClientMac stepOver:]):
3651         (-[DebuggerClientMac stepOut:]):
3652         (-[DebuggerClientMac showConsole:]):
3653         (-[DebuggerClientMac closeCurrentFile:]):
3654         (-[DebuggerClientMac validateUserInterfaceItem:]):
3655         (-[DebuggerClientMac webView:windowScriptObjectAvailable:]):
3656         (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3657         (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3658         (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3659         (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3660         (DebuggerDocument::platformPause):
3661         (DebuggerDocument::platformResume):
3662         (DebuggerDocument::platformStepInto):
3663         (DebuggerDocument::platformEvaluateScript):
3664         (DebuggerDocument::platformCurrentFunctionStack):
3665         (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame):
3666         (DebuggerDocument::platformValueForScopeVariableNamed):
3667         (DebuggerDocument::platformLog):
3668         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3669
3670 2007-09-06  Sam Weinig  <sam@webkit.org>
3671
3672         Reviewed by Adam Roben.
3673
3674         Register the WebKit DLL on initialization of the DumpRenderTree.
3675
3676         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3677         (initialize):
3678
3679 2007-09-05  Sam Weinig  <sam@webkit.org>
3680
3681         Reviewed by Oliver.
3682
3683         Fix many layout test failures caused by r25364.
3684         Set text size to standand size at the begining of each test matching the mac.
3685
3686         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3687         (runTest):
3688
3689 2007-09-04  Sam Weinig  <sam@webkit.org>
3690
3691         Reviewed by Adam.
3692
3693         Fix for <rdar://problem/5382277>
3694         Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.
3695
3696         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
3697         (textZoomInCallback):
3698         (textZoomOutCallback):
3699
3700 2007-08-29  David Kilzer  <ddkilzer@apple.com>
3701
3702         Reviewed by Adam.
3703
3704         Added case-insensitivity to checks for adding regression tests.
3705
3706         * Scripts/prepare-ChangeLog:
3707         (generateFileList):
3708
3709 2007-08-28  David Kilzer  <ddkilzer@apple.com>
3710
3711         Reviewed by Maciej.
3712
3713         Ignore files in /resources/ subdirectories when creating a list of added tests.
3714
3715         * Scripts/prepare-ChangeLog:
3716         (generateFileList):
3717
3718 2007-08-27  Kevin McCullough  <kmccullough@apple.com>
3719
3720         Reviewed by John.
3721
3722         - Removed Leopard leaks list since all of those radars were fixed.
3723
3724         * Scripts/run-webkit-tests:
3725
3726 2007-08-27  Adam Roben  <aroben@apple.com>
3727
3728         Rubberstamped by Mark.
3729
3730         * Scripts/pdevenv: Pass arguments along to devenv.com.
3731
3732 2007-08-26  David Kilzer  <ddkilzer@webkit.org>
3733
3734         Reviewed by Mark Rowe.
3735
3736         Update prepare-ChangeLog to generate the datestamp in the correct timezone.
3737
3738         * Scripts/prepare-ChangeLog:
3739         (changeLogDate): Added.
3740
3741 2007-08-24  Sam Weinig  <sam@webkit.org>
3742
3743         Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.
3744
3745 2007-08-24  Sam Weinig  <sam@webkit.org>
3746
3747         Rubber-stamped by Adam Roben.
3748
3749         <rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration
3750
3751         Rename COM DOM bindings to use Deprecated prefix.
3752
3753         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3754         (dumpFramesAsText):
3755         (dump):
3756         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp:
3757         (dumpPath):
3758         (dump):
3759         (EditingDelegate::shouldBeginEditingInDOMRange):
3760         (EditingDelegate::shouldEndEditingInDOMRange):
3761         (EditingDelegate::shouldInsertNode):
3762         (EditingDelegate::shouldInsertText):
3763         (EditingDelegate::shouldDeleteDOMRange):
3764         (EditingDelegate::shouldChangeSelectedDOMRange):
3765         (EditingDelegate::shouldApplyStyle):
3766         (EditingDelegate::shouldChangeTypingStyle):
3767         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h:
3768
3769 2007-08-24  Oliver Hunt  <oliver@apple.com>
3770
3771         Reviewed by John H.
3772
3773         WebDataSource::response can legitimately have a null response, so we
3774         must check that case.
3775
3776         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3777         (queueLoadCallback):
3778
3779 2007-08-23  Mitz Pettel  <mitz@webkit.org>
3780
3781         Reviewed by Darin and Adam.
3782
3783         - DumpRenderTree changes to allow testing for
3784           http://bugs.webkit.org/show_bug.cgi?id=11756
3785           REGRESSION: link targeting a frame in another window does not work
3786           <rdar://problem/5286420>
3787
3788         Use a frame group name for all WebViews created by DumpRenderTree to
3789         allow testing of cross-page frame lookup.
3790
3791         * DumpRenderTree/DumpRenderTree.m:
3792         (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
3793         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3794         (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).
3795
3796 2007-08-23  David Kilzer  <ddkilzer@webkit.org>
3797
3798         Reviewed by Adam.
3799
3800         Quote the $sslCertificate path in case it contains a space.
3801
3802         * Scripts/run-webkit-httpd:
3803         * Scripts/run-webkit-tests:
3804
3805 2007-08-22  Oliver Hunt  <oliver@apple.com>
3806
3807         Reviewed by John and Adam.
3808         
3809         WebDataSource::response can legitimately have a null response, so we
3810         must check that case.
3811
3812         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3813         (dump):
3814
3815 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
3816
3817         Reviewed by Geof.
3818
3819         - Changing the usage to be more clear.
3820
3821         * Scripts/run-testkjs:
3822
3823 2007-08-20  John Sullivan  <sullivan@apple.com>
3824
3825         Reviewed by Adam Roben
3826
3827         * DumpRenderTree/DumpRenderTree.m:
3828         (runTest):
3829         call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors
3830         in layout tests on Tiger and Leopard
3831
3832 2007-08-20  Adam Roben  <aroben@apple.com>
3833
3834         Put LayoutTests after all other ChangeLogs in commit logs
3835
3836         We use "~" to sort LayoutTests after all the other ChangeLogs because
3837         "~" is the last ASCII character (other than "DEL").
3838
3839         Reviewed by Sam.
3840
3841         * Scripts/commit-log-editor:
3842
3843 2007-08-20  Adam Roben  <aroben@apple.com>
3844
3845         Detect that DRT crashed even if a crash dialog is running
3846
3847         On Windows, when DRT crashes a crash dialog commonly appears. The DRT
3848         process is still running at this point, so run-webkit-tests wouldn't
3849         detect that DRT had crashed. We now record the crash in our SIGPIPE
3850         handler so that we know if DRT crashed even if the crash dialog is up.
3851
3852         Reviewed by Sam.
3853
3854         * Scripts/run-webkit-tests:
3855         (sub catch_pipe): Set the crashed bit.
3856         (sub openDumpTool): Reset the crashed bit.
3857         (sub dumpToolDidCrash): Check the crashed bit.
3858
3859 2007-08-20  Adam Roben  <aroben@apple.com>
3860
3861         Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog
3862
3863         http://bugs.webkit.org/show_bug.cgi?id=15026
3864
3865         Reviewed by David Kilzer and Darin Adler.
3866
3867         * Scripts/prepare-ChangeLog:
3868         (sub isModifiedStatus): Split out from isModifiedOrAddedStatus.
3869         (sub isAddedStatus): Ditto.
3870         (sub testListForChangeLog): Added.
3871
3872 2007-08-19  Oleg Sukhodolsky  <son.two@gmail.com>
3873
3874         Reviewed by Mark.
3875
3876         -fixes http://bugs.webkit.org/show_bug.cgi?id=14632
3877
3878         * Scripts/webkitdirs.pm:
3879         qt and gtk ports now explicitly pass debug (or release) mode to qmake.
3880
3881 2007-08-17  Darin Adler  <darin@apple.com>
3882
3883         Reviewed by Oliver Hunt.
3884
3885         - don't look for Apple-style localizable strings in the GTK version of WebKit
3886
3887         * Scripts/extract-localizable-strings: Add a feature where you can pass in the
3888         name of subdirectories to skip.
3889         * Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory
3890         to skip.
3891
3892 2007-08-17  Anders Carlsson  <andersca@apple.com>
3893
3894         Build fix.
3895         
3896         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3897         (NPP_SetWindow):
3898
3899 2007-08-17  Anders Carlsson  <andersca@apple.com>
3900
3901         Reviewed by Dave Hyatt.
3902
3903         <rdar://problem/5379040>
3904         REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes
3905
3906         Add a way for the plug-in to dump the width and height when it gets its  NPP_SetWindow call.
3907         
3908         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
3909         (pluginAllocate):
3910         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3911         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3912         (NPP_New):
3913         (NPP_SetWindow):
3914
3915 2007-08-16  Alice Liu  <alice.liu@apple.com>
3916
3917         Reviewed by Maciej.
3918
3919         Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail
3920
3921         * DumpRenderTree/DumpRenderTree.m:
3922         (createWebView):
3923         Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow.
3924         (dumpRenderTree):
3925         Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow. 
3926
3927 2007-08-16  Kevin McCullough  <kmccullough@apple.com>
3928
3929         Reviewed by Adam.
3930
3931         - Added tests for regressions in other components.  In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
3932
3933         * Scripts/run-webkit-tests:
3934
3935 2007-08-15  Timothy Hatcher  <timothy@apple.com>
3936
3937         Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
3938         The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.
3939
3940         Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
3941         this prevents making "build" directories in each project folder.
3942
3943         * Scripts/webkitdirs.pm:
3944
3945 2007-08-14  Geoffrey Garen  <ggaren@apple.com>
3946
3947         Reviewed by Kevin Mccullough.
3948         
3949         Removed special case that didn't belong. (It would allow a global 
3950         initializer to sneak into production builds, which would cause a 
3951         system-wide performance regression on Mac OS X.)
3952
3953         * Scripts/check-for-global-initializers:
3954
3955 2007-08-14  Justin Garcia  <justin.garcia@apple.com>
3956
3957         Reviewed by Tim.
3958         
3959         <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
3960
3961         * DumpRenderTree/EditingDelegate.m:
3962         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES
3963         only for elements with the class needsDeletionUI.
3964
3965 2007-08-14  David Kilzer  <ddkilzer@webkit.org>
3966
3967         Reviewed by Darin.
3968
3969         - fix http://bugs.webkit.org/show_bug.cgi?id=14965
3970           svn-create-patch uses deprecated tail switch
3971
3972         * Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.
3973
3974 2007-08-13  Sam Weinig  <sam@webkit.org>
3975
3976         Reviewed by Adam Roben.
3977
3978         Use the cygwin specific Apache config file under cygwin.
3979
3980         * Scripts/run-webkit-httpd:
3981
3982 2007-08-12  Adam Roben  <aroben@apple.com>
3983
3984         Generate results for new tests in a more logical location
3985
3986         New platform-specific tests always have their results generated right
3987         next to the test. New cross-platform tests will have their results
3988         generated a) in the cross-platform directory, if they are text-only,
3989         or b) in the least-specific platform directory, if they are render
3990         tree dumps.
3991
3992         Reviewed by Lars.
3993
3994         * Scripts/run-webkit-tests:
3995
3996 2007-08-12  Adam Roben  <aroben@apple.com>
3997
3998         Print the actual directory where new results are generated.
3999
4000         Before, we were printing an unpredictable, context-specific substring
4001         of the directory.
4002
4003         Reviewed by Lars.
4004
4005         * Scripts/run-webkit-tests:
4006
4007 2007-08-12  Adam Roben  <aroben@apple.com>
4008
4009         Factor some common code into a stripExtension() subroutine.
4010
4011         Reviewed by Lars.
4012
4013         * Scripts/run-webkit-tests: Also removed some debugging output.
4014
4015 2007-08-11  Matt Lilek  <pewtermoose@gmail.com>
4016
4017         Reviewed over and over and over by Adam Roben.
4018
4019         Bug 14740: Hierarchical layout tests and platform organization
4020         http://bugs.webkit.org/show_bug.cgi?id=14740
4021
4022         Add support for platform-specific layout tests and results.
4023
4024         * Scripts/run-webkit-tests:
4025
4026 2007-08-11  David Kilzer  <ddkilzer@webkit.org>
4027
4028         Reviewed by Adam.
4029
4030         Refactored svn-create-path to use a hash-of-hashes data structure to keep
4031         track of changed files.  In the top level hash, keys are paths to files and
4032         values are 'fileData' hashes with the following keys and values:
4033
4034         - isBinary: boolean value (set to true for non-text files like images, etc.)
4035         - isTestFile: boolean value (set to true if file exists within a known test
4036           directory)
4037         - modificationType: string equal to one of 'addition', 'additionWithHistory',
4038           'modification' or 'deletion'
4039         - path: string equal to the path to the file (this may seem redundant, but it
4040           is required to use the second-level 'fileData' hash independent of the
4041           top-level hash)
4042         - sourceFile: [optional] string equal to the path of the original file that was
4043           copied or moved
4044         - sourceRevision: [optional] string equal to the revision of the original file
4045           that was copied or moved
4046
4047         * Scripts/svn-create-patch: Moved call to GetOptions() to its own statement
4048         that saves the return value in $result, then checks it before printing help.
4049         Combined sourceFiles, %testFiles, and %binaryFiles into single %diffFiles hash
4050         and eliminated two for() loops.
4051         (binarycmp): Added.  Used with sort() to order non-binary files before binary
4052         files.
4053         (findBaseUrl): Added.  Extracted from findSourceFileAndRevision().
4054         (findMimeType): Added optional second argument that takes a revision number.
4055         (generateDiff): Updated to take one fileData argument instead of three ($file,
4056         $modificationType, $isBinary).
4057         (generateFileList): Updated to take one hash ref argument (%diffFiles)
4058         instead of three (%sourceFiles, %testFiles, %binaryFiles).  Populates
4059         %diffFiles using paths for keys and fileData hashes for values.
4060         (manufacturePatchForAdditionWithHistory): Updated to take one fileData
4061         argument.
4062         (pathcmp): Updated to take two fileData arguments instead of two strings.
4063         (testfilecmp): Added.  Used with sort() to order non-test files before test
4064         files.
4065
4066 2007-08-11  Darin Adler  <darin@apple.com>
4067
4068         * Scripts/run-webkit-tests: Give a different message when only the pixel test failed.
4069
4070 2007-08-06  Nigel Tao  <nigeltao@gnome.org>
4071
4072         Reviewed by David Kilzer.
4073
4074         Fix bug 14745: WebKitTools/Scripts/run-launcher doesn't speak --gdk
4075         http://bugs.webkit.org/show_bug.cgi?id=14745
4076
4077         * Scripts/run-launcher:
4078         Scrub the "--gdk" out of the command line args, if given, so that
4079         GdkLauncher doesn't try to interpret it as a URL.
4080
4081 2007-08-03  Adam Roben  <aroben@apple.com>
4082
4083         Catch SIGPIPE on Windows so that run-webkit-tests doesn't quit when DRT crashes
4084
4085         Reviewed by Sam.
4086
4087         * Scripts/run-webkit-tests: Also close ERROR when we finish running the tests.
4088
4089 2007-08-03  Sam Weinig  <sam@webkit.org>
4090
4091         Reviewed by Darin.
4092
4093         Recursively dump all frames as text using new
4094         layoutTestController.dumpChildFramesAsText() function.
4095
4096         * DumpRenderTree/DumpRenderTree.m:
4097         (dumpFramesAsText):
4098         (dump):
4099         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
4100         (-[LayoutTestController dumpChildFramesAsText]):
4101         (runTest):
4102         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
4103         (dumpFramesAsText):
4104         (dump):
4105         (runTest):
4106         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
4107         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
4108         (dumpChildFramesAsTextCallback):
4109         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4110
4111 2007-08-02  Adam Roben  <aroben@apple.com>
4112
4113         Fix fast/dom/Window/alert-undefined.html
4114
4115         Reviewed by Sam.
4116
4117         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
4118         (WaitUntilDoneDelegate::runJavaScriptAlertPanelWithMessage): Don't let
4119         Windows translate a null BSTR into "(null)"
4120
4121 2007-08-02  Kevin McCullough  <kmccullough@apple.com>
4122
4123         Reviewed by Tim. 
4124
4125         - It would help if I actually called the right function.
4126
4127         * Drosera/DebuggerDocument.cpp:
4128         (DebuggerDocument::showConsole):
4129
4130 2007-08-02  Adam Roben  <aroben@apple.com>
4131
4132         Don't delete the stderr file right after creating it
4133
4134         * Scripts/run-webkit-tests:
4135
4136 2007-08-01  Adam Roben  <aroben@apple.com>
4137
4138         When DRT crashes, record stderr and restart DRT
4139
4140         This prevents a DRT crash from causing the next few hundred tests to
4141         "fail" because DRT is no longer running. 
4142
4143         I also changed the terminology that run-webkit-tests uses in its
4144         output a bit, so that crashing tests are referred to as "crashes"
4145         instead of "failures".
4146
4147         Reviewed by Mark.
4148
4149         * Scripts/run-webkit-tests: Detect a crash and record it as a tool
4150         failure.
4151         (sub openDumpTool): Use open3 so that we can access stderr.
4152         (sub dumpToolCrashed): Added.
4153         (sub printFailureMessageForTest): Added.
4154         (sub htmlForExpectedAndActualResults): Added.
4155         (sub deleteExpectedAndActualResults): Added.
4156         (sub recordActualResultsAndDiff): Added.
4157
4158 2007-07-30  Darin Adler  <darin@apple.com>
4159
4160         Reviewed by Tim Hatcher.
4161
4162         * DumpRenderTree/DumpRenderTree.m: (dump): Fix dumping for documents that include null
4163         characters. This turned out not to be needed for the test case that motivated me to
4164         do it, but it's nice to have this for the future.
4165
4166 2007-07-30  Simon Hausmann  <hausmann@kde.org>
4167
4168         Reviewed by Lars.
4169
4170         Link QtLauncher into $$OUTPUT_DIR/bin
4171
4172         * Scripts/run-launcher:
4173
4174 2007-07-27  David Kilzer  <ddkilzer@apple.com>
4175
4176         Reviewed by Geoff and Darin.
4177
4178         Use a subroutine for validating the --skipped switch.
4179
4180         * Scripts/run-webkit-tests:
4181