- Tiger build fix.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-11-26  Dan Bernstein  <mitz@apple.com>
2
3         - Tiger build fix.
4
5         * DumpRenderTree/mac/Configurations/Base.xcconfig:
6
7 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
8
9         Reviewed by Maciej.
10
11         - Implemented displaying variables for Drosera on Win.
12
13         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
14         that retrieve variables to not hold onto the return value since it's
15         not returned.  Also changed to use the new signatures of the retrieval
16         functions.
17         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
18         (DebuggerDocument::platformValueForScopeVariableNamed):
19         * Drosera/win/Drosera.cpp: Removed a needless TODO.
20         (droseraWndProc):
21
22 2007-11-26  Sam Weinig  <sam@webkit.org>
23
24         Cleanup names of painting and repainting functions.
25
26         Reviewed by Adam Roben.
27
28         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
29         (drawSelectionRect): was drawSelectionRectIntoContext.
30         (dumpWebViewAsPixelsAndCompareWithExpected):
31         * DumpRenderTree/cg/PixelDumpSupportCG.h:
32         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
33         (paintWebView): was drawWebViewIntoContext.
34         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
35
36 2007-11-26  Sam Weinig  <sam@webkit.org>
37
38         Reviewed by Dan Bernstein.
39
40         - Leopard build fix
41
42         * DumpRenderTree/mac/Configurations/Base.xcconfig:
43
44 2007-11-26  Sam Weinig  <sam@webkit.org>
45
46         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
47         Use shared PixelDumpSupport for Mac DRT
48
49         Reviewed by Adam Roben.
50
51         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
52         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
53         * DumpRenderTree/cg/ImageDiffCG.cpp:
54         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
55         (drawSelectionRectIntoContext):
56         (dumpWebViewAsPixelsAndCompareWithExpected):
57         * DumpRenderTree/cg/PixelDumpSupportCG.h:
58         * DumpRenderTree/mac/Configurations/Base.xcconfig:
59         * DumpRenderTree/mac/DumpRenderTree.mm:
60         (dump):
61         * DumpRenderTree/mac/ImageDiff.m: Removed.
62         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
63         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
64         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
65         (setDefaultColorProfileToRGB):
66         (getBitmapContextFromWebView):
67         (drawWebViewIntoContext):
68         (repaintWithVerticalSweep):
69         (repaintWithHorizontalSweep):
70         (getSelectionRect):
71         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
72
73 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
74
75         Bug 16052: prepare-ChangeLog doesn't report deleted files
76         <http://bugs.webkit.org/show_bug.cgi?id=16052>
77
78         Reviewed by Sam.
79
80         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
81
82 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
83
84         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
85         <http://bugs.webkit.org/show_bug.cgi?id=15864>
86
87         Reviewed by Adam.
88
89         Roll functionality of merge-changelog into resolve-ChangeLogs
90         script.  The script now checks for ChangeLog.rej and
91         ChangeLog.orig files first.  If it finds them, it uses the
92         ChangeLog.rej file as a patch (in old contextual diff format) to
93         apply with --fuzz=3.
94
95         * Scripts/merge-changelog: Removed.
96         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
97
98 2007-11-25  Sam Weinig  <sam@webkit.org>
99
100         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
101
102         Reviewed by Mark Rowe.
103
104         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
105         * DumpRenderTree/mac/Configurations/Base.xcconfig:
106         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
107         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
108         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
109
110 2007-11-25  Sam Weinig  <sam@webkit.org>
111
112         Convert DumpRenderTree to ues .xcconfig files.
113
114         Reviewed by Mark Rowe.
115
116         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
117         * DumpRenderTree/mac/Configurations: Added.
118         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
119         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
120         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
121
122 2007-11-25  Sam Weinig  <sam@webkit.org>
123
124         Add ForwardingHeaders to wtf for DumpRenderTree.
125
126         Reviewed by Mark Rowe.
127
128         * DumpRenderTree/DumpRenderTree.h:
129         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
130         * DumpRenderTree/ForwardingHeaders: Added.
131         * DumpRenderTree/ForwardingHeaders/wtf: Added.
132         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
133         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
134         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
135         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
136         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
137         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
138         * DumpRenderTree/LayoutTestController.cpp:
139         * DumpRenderTree/WorkQueue.cpp:
140         * DumpRenderTree/mac/DumpRenderTree.mm:
141         * DumpRenderTree/mac/FrameLoadDelegate.mm:
142         * DumpRenderTree/mac/JavaScriptThreading.cpp:
143         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
144         * DumpRenderTree/mac/ObjCController.m:
145         * DumpRenderTree/mac/UIDelegate.mm:
146         * DumpRenderTree/mac/WorkQueueItemMac.mm:
147
148 2007-11-25  Adam Roben  <aroben@apple.com>
149
150         Fix some test failures caused by r28019
151
152         Now that stdout is in binary mode, we need to always use printf
153         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
154         the output.
155
156         Reviewed by Sam.
157
158         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
159         printf.
160         (UIDelegate::runJavaScriptAlertPanelWithMessage):
161         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
162         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
163         (UIDelegate::webViewAddMessageToConsole):
164
165 2007-11-25  Adam Roben  <aroben@apple.com>
166
167         Set the font smoothing preference in DRT
168
169         This makes the pixel results on Windows closer to the Mac results.
170
171         Reviewed by Mitz.
172
173         * DumpRenderTree/win/DumpRenderTree.cpp:
174         (initializePreferences):
175
176 2007-11-25  Adam Roben  <aroben@apple.com>
177
178         Port ImageDiff to CG and C++
179
180         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
181         <rdar://5071708>
182
183         Reviewed by Sam.
184
185         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
186         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
187         (main):
188         (createImageFromStdin):
189         (compareImages):
190         (getDifferenceBitmap):
191         (computePercentageDifferent):
192         * DumpRenderTree/win/ImageDiff.vcproj: Added.
193
194 2007-11-25  Adam Roben  <aroben@apple.com>
195
196         Fix image diff link generation on Windows
197
198         Reviewed by Sam.
199
200         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
201         to toURL.
202
203 2007-11-25  Adam Roben  <aroben@apple.com>
204
205         Implement pixel dumping in Windows DRT
206
207         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
208         <rdar://5071708>
209
210         Reviewed by Sam.
211
212         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
213         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
214         Content-Length header.
215         (getMD5HashStringForBitmap):
216         (dumpWebViewAsPixelsAndCompareWithExpected):
217         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
218         * DumpRenderTree/win/DumpRenderTree.cpp:
219         (dump): Do a pixel dump if requested.
220         (main): Parse pixel test options.
221         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
222         the cg/ subdirectory to the include path.
223         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
224         available in a header or import library, so we have to go through this
225         LoadLibrary/GetProcAddress dance to use them.
226         (cryptDLL):
227         (init):
228         (update):
229         (final):
230         (MD5_Init):
231         (MD5_Update):
232         (MD5_Final):
233         * DumpRenderTree/win/MD5.h: Added.
234         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
235         moved up to the top level to share it with Mac eventually.
236         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
237         (getBitmapContextFromWebView): Forces the WebView to paint using a
238         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
239
240 2007-11-25  Adam Roben  <aroben@apple.com>
241
242         Clean up Windows DRT's option parsing a little bit
243
244         Reviewed by Sam.
245
246         * DumpRenderTree/win/DumpRenderTree.cpp:
247         (main): Put non-option arguments into a Vector.
248
249 2007-11-25  Adam Roben  <aroben@apple.com>
250
251         Make Windows DRT stop changing LF into CRLF
252
253         Reviewed by Sam.
254
255         * DumpRenderTree/win/DumpRenderTree.cpp:
256         (main): Put stdout in binary mode.
257         * Scripts/run-webkit-tests: Remove the CRLF hack.
258
259 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
260
261         Removed empty directory.
262
263         * Scripts/resources: Removed.
264
265 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
266
267         Fix bisect-builds to work with recent WebKit nightly builds.
268
269         Reviewed by Dan.
270
271         * Scripts/bisect-builds: Check for the 
272         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
273         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
274         to WebKit.app/Contents/Resources.
275
276 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
277
278         Reviewed by Maciej.
279
280         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
281         not closed (affects digg.com)
282
283         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
284         one after finishing with a test to avoid having its delayed onload handler firing when
285         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
286         but it helps somewhat.
287
288 2007-11-22  Mark Rowe  <mrowe@apple.com>
289
290         Reviewed by Alp Toker.
291
292         Fix build-webkit to propagate make's exit status if it fails.
293
294         * Scripts/webkitdirs.pm:
295
296 2007-11-22  Dan Bernstein  <mitz@apple.com>
297
298         Reviewed by Mark Rowe.
299
300         - fix crash when running pixel tests
301
302         * DumpRenderTree/mac/DumpRenderTree.mm:
303         (dumpRenderTree): Parse the command line options before setting up the
304         environment so that we know if we need to set up the pixel dump
305         machinery.
306
307 2007-11-21  Eric Seidel  <eric@webkit.org>
308
309         Speculative build fix for Tiger.
310
311         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
312
313 2007-11-21  Eric Seidel  <eric@webkit.org>
314
315         Reviewed by Tim Hatcher.
316
317         Break out more of DumpRenderTree.mm into individual files
318
319         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
320         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
321         (checkedMalloc):
322         (checkedRealloc):
323         (makeLargeMallocFailSilently):
324         * DumpRenderTree/mac/CheckedMalloc.h: Added.
325         * DumpRenderTree/mac/DumpRenderTree.mm:
326         (crashHandler):
327         (dump):
328         * DumpRenderTree/mac/DumpRenderTreeMac.h:
329         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
330         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
331         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
332         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
333         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
334         (javaScriptThreads):
335         (runJavaScriptThread):
336         (startJavaScriptThreads):
337         (stopJavaScriptThreads):
338         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
339         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
340         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
341         (restoreColorSpace):
342         (setDefaultColorProfileToRGB):
343         (initializeColorSpaceAndScreeBufferForPixelTests):
344         (md5HashStringForBitmap):
345         (dumpWebViewAsPixelsAndCompareWithExpected):
346
347 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
348
349         Move install-unix-extras to wx directory as it seems only to be used by that 
350         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
351         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
352         have install-unix-extras install into WebKitLibraries as per
353         convention.
354         
355         Reviewed by Mark Rowe.
356
357         * Scripts/install-unix-extras: Removed.
358         * wx/build-wxwebkit:
359         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
360
361 2007-11-21  Eric Seidel  <eric@webkit.org>
362
363         Reviewed by Adam.
364
365         More refactoring for greater code readability
366
367         * DumpRenderTree/mac/DumpRenderTree.mm:
368         (initializeGlobalsFromCommandLineOptions):
369         (initializeColorSpaceAndScreeBufferForPixelTests):
370         (addTestPluginsToPluginSearchPath):
371         (useLongRunningServerMode):
372         (runTestingServerLoop):
373         (prepareConsistentTestingEnvironment):
374         (dumpRenderTree):
375         (main):
376         (dumpFramesAsText):
377         (dumpBackForwardListForWebView):
378         (sizeWebViewForCurrentTest):
379         (methodNameStringForFailedTest):
380         (dumpBackForwardListForAllWindows):
381         (dumpWebViewAsPixelsAndCompareWithExpected):
382         (invalidateAnyPreviousWaitToDumpWatchdog):
383         (dump):
384         * DumpRenderTree/mac/DumpRenderTreeMac.h:
385         * DumpRenderTree/mac/UIDelegate.mm:
386         (-[UIDelegate webView:createWebViewWithRequest:]):
387
388 2007-11-21  Eric Seidel  <eric@webkit.org>
389
390         Reviewed by Tim Hatcher.
391
392         Abstract more of DRT into static methods
393
394         * DumpRenderTree/mac/DumpRenderTree.mm:
395         (setDefaultsToConsistentValuesForTesting):
396         (setupSignalHandlers):
397         (allocateGlobalControllers):
398         (releaseAndZero):
399         (releaseGlobalControllers):
400         (dumpRenderTree):
401         (shouldLogFrameLoadDelegates):
402         (createCFURLFromPathOrURL):
403         (resetWebViewToConsistentStateBeforeTesting):
404         (runTest):
405
406 2007-11-21  Eric Seidel  <eric@webkit.org>
407
408         Reviewed by Tim Hatcher.
409
410         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
411
412         * DumpRenderTree/DumpRenderTree.h:
413         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
414         * DumpRenderTree/mac/DumpRenderTree.mm:
415         (dumpRenderTree):
416         (dump):
417         (runTest):
418         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
419         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
420         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
421         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
422         (-[DumpRenderTreePasteboard declareType:owner:]):
423         (+[LocalPasteboard alloc]):
424         (-[LocalPasteboard init]):
425         (-[LocalPasteboard dealloc]):
426         (-[LocalPasteboard name]):
427         (-[LocalPasteboard releaseGlobally]):
428         (-[LocalPasteboard declareTypes:owner:]):
429         (-[LocalPasteboard addTypes:owner:]):
430         (-[LocalPasteboard changeCount]):
431         (-[LocalPasteboard types]):
432         (-[LocalPasteboard availableTypeFromArray:]):
433         (-[LocalPasteboard setData:forType:]):
434         (-[LocalPasteboard dataForType:]):
435         (-[LocalPasteboard setPropertyList:forType:]):
436         (-[LocalPasteboard setString:forType:]):
437         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
438         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
439         (+[DumpRenderTreeWindow allWindows]):
440         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
441         (-[DumpRenderTreeWindow dealloc]):
442         (-[DumpRenderTreeWindow isKeyWindow]):
443         (-[DumpRenderTreeWindow keyDown:]):
444
445 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
446
447         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
448         it indiscriminately copies any headers inside JavaScriptCore,
449         which includes Tiger ICU headers. 
450
451         * wx/build-wxwebkit:
452         Don't run WebCore/move-js-headers.sh any longer.
453
454 2007-11-20  Adam Treat  <treat@kde.org>
455
456         Reviewed by David Kilzer.
457
458         * Prepend git branch name to $baseProductDir
459
460         * Scripts/VCSUtils.pm:
461         * Scripts/webkitdirs.pm:
462
463 2007-11-20  Mark Rowe  <mrowe@apple.com>
464
465         Reviewed by Simon Hausmann.
466
467         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
468         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
469         Have it trigger a "make distclean" rather than "make clean" to ensure that the
470         built product and generated Makefile's are removed.
471
472 2007-11-19  Alp Toker  <alp@atoker.com>
473
474         Reviewed by Mark Rowe.
475
476         http://bugs.webkit.org/show_bug.cgi?id=16040
477         [GTK] GtkLauncher should be written in C
478
479         Port GtkLauncher to plain C.
480
481         Use a more conventional GTK+ coding style.
482
483         Use a toolbar instead of menus.
484
485         Various signature fixes and cleanups.
486
487         Add a license header. Assume all previous modifications were copyright
488         assigned to Apple Inc. by default.
489
490         * GtkLauncher/GtkLauncher.pro:
491         * GtkLauncher/main.c: Added.
492         (activate_url_entry_cb):
493         (update_title):
494         (link_hover_cb):
495         (title_change_cb):
496         (progress_change_cb):
497         (destroy_cb):
498         (go_back_cb):
499         (go_forward_cb):
500         (create_browser):
501         (create_statusbar):
502         (create_toolbar):
503         (create_window):
504         (main):
505         * GtkLauncher/main.cpp: Removed.
506
507 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
508
509         Build script fixes to ensure they do the right thing for the 
510         wx port, and update build-wxwebkit to reflect the way the
511         build scripts now work.
512
513         Reviewed by Adam.
514
515         * Scripts/build-testkjs:
516         * Scripts/build-webkit:
517         * Scripts/run-javascriptcore-tests:
518         * Scripts/webkitdirs.pm:
519         * wx/build-wxwebkit:
520
521 2007-11-18  Eric Seidel  <eric@webkit.org>
522
523         Reviewed by Anders.
524
525         Make run-javascriptcore-tests report failures on exit (to support git bisect)
526
527         * Scripts/run-javascriptcore-tests:
528
529 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
530
531         Reviewed by Adam Roben.
532
533         Make run-webkit-tests work with Windows debug build.
534
535         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
536         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
537         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
538         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
539         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
540
541 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
542
543         Add wxWebKit sample and build script, and integrate it with 
544         build-webkit. Also make build-webkit --clean work for all
545         ports.
546
547         Reviewed by Darin Adler.
548
549         * Scripts/build-webkit:
550         * Scripts/webkitdirs.pm:
551         * wx: Added.
552         * wx/browser: Added.
553         * wx/browser/browser.bkl: Added.
554         * wx/browser/browser.cpp: Added.
555         * wx/build-wxwebkit: Added.
556
557 2007-11-17  Adam Roben  <aroben@apple.com>
558
559         Make it easy to run Safari in the debugger on Windows
560
561         I've added a new script, debug-safari, which launches Safari in the
562         debugger. On OS X it just calls gdb-safari.
563
564         Reviewed by Mark Rowe.
565
566         * FindSafari/FindSafari.cpp:
567         (_tmain): Added a /debugger flag, which in combination with
568         /printSafariLauncher will print a script that launches Safari in the
569         debugger.
570         * Scripts/debug-safari: Added.
571         * Scripts/run-safari: Changed to call runSafari().
572         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
573         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
574         first argument along to FindSafari.
575         * Scripts/webkitdirs.pm:
576         (sub runSafari): Added.
577
578 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
579
580         Reviewed by Adam Roben.
581
582         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
583
584 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
585
586         Reviewed by David Kilzer.
587
588         The git config command was renamed to repo-config at some point. This
589         change tries git config and then git repo-config if the first fails.
590
591         * Scripts/prepare-ChangeLog:
592         (gitConfig):
593
594 2007-11-16  Dan Bernstein  <mitz@apple.com>
595
596         Reviewed by Darin Adler and Sam Weinig.
597
598         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
599
600         * DumpRenderTree/win/EventSender.cpp:
601         (keyDownCallback): For characters that cannot be entered on the active
602         keyboard layout, send a WM_CHAR message with the character along with
603         a WM_KEYDOWN message with a virtual key code of 255.
604
605 2007-11-16  Mark Rowe  <mrowe@apple.com>
606
607         Reviewed by Tim Hatcher.
608
609         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
610
611         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
612         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
613
614 2007-11-15  Adam Roben  <aroben@apple.com>
615
616         Make run-safari actually work on Windows
617
618         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
619         chdir call.
620
621 2007-11-14  Adam Roben  <aroben@apple.com>
622
623         Updates to Safari launching now that 3.0.4 is released
624
625         Reviewed by Sam.
626
627         * FindSafari/FindSafari.cpp:
628         (getWebViewCLSID): Use version-independent ProgID.
629         * Scripts/run-safari: Use run-webkit-nightly.cmd.
630
631 2007-11-14  Anders Carlsson  <andersca@apple.com>
632
633         Reviewed by Adam.
634
635         <rdar://problem/5309081>
636         In DRT, "plugin.logDestroy = true" not working on Windows.
637         
638         * DumpRenderTree/win/TestNetscapePlugin/main.c:
639         (NPP_Destroy):
640
641 2007-11-14  Eric Seidel  <eric@webkit.org>
642
643         Reviewed by Sam.
644
645         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
646
647 2007-11-14  Anders Carlsson  <andersca@apple.com>
648
649         Reviewed by Adam.
650
651         <rdar://problem/5141186>
652         window.layoutTestController.setWindowIsKey is not implemented in DRT.
653         
654         Implement setWindowIsKey.
655         
656         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
657         (LayoutTestController::setWindowIsKey):
658
659 2007-11-13  Sam Weinig  <sam@webkit.org>
660
661         Reviewed by Adam Roben.
662
663         Fix for <rdar://problem/5382579>
664         http/tests/security/cross-frame-access-put.html reports large 
665         negative numbers for screenLeft and screenTop (Mac reports "0")
666
667         * DumpRenderTree/win/UIDelegate.cpp:
668         (UIDelegate::UIDelegate): Initialize the RECT.
669         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
670         (UIDelegate::webViewFrame): ditto.
671         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
672
673 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
674
675         Reviewed by Adam.
676
677         - Make Drosera show source, source URLs, and function stack on Windows,
678         and some minor fixes.
679
680         * Drosera/DebuggerDocument.cpp: Force source to always update display.
681         (DebuggerDocument::updateFileSource):
682         * Drosera/debugger.js: Force source to always update display.
683         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
684         menu controls.
685         (DebuggerClient::resume):
686         (DebuggerClient::pause):
687         (DebuggerClient::stepInto):
688         (DebuggerClient::stepOver):
689         (DebuggerClient::stepOut):
690         (DebuggerClient::showConsole):
691         (DebuggerClient::closeCurrentFile):
692         * Drosera/win/DebuggerClient.h: Ditto.
693         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
694         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
695         removed two bugs.  1) caller could be in a bad state when asked to
696         assign into it. 2) BSTRs were not created correctly.
697         (DebuggerDocument::getPlatformCurrentFunctionStack):
698         * Drosera/win/Drosera.cpp: Hook up the menu controls.
699         (droseraWndProc):
700         (handleCommand):
701         (Drosera::resume):
702         (Drosera::pause):
703         (Drosera::stepInto):
704         (Drosera::stepOver):
705         (Drosera::stepOut):
706         (Drosera::showConsole):
707         (Drosera::closeCurrentFile):
708         * Drosera/win/Drosera.h: Hook up the menu controls.
709         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
710         functions, added a null check, and fixed another bug where caller could
711         be in a bad state when asked to assign into it.
712         (ServerConnection::didLoadMainResourceForDataSource):
713         (ServerConnection::getCallerFrame):
714         * Drosera/win/ServerConnection.h: Safety first.
715
716 2007-11-13  Dan Bernstein  <mitz@apple.com>
717
718         Reviewed by Darin Adler.
719
720         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
721           DumpRenderTree --pixel-tests renders each test twice
722
723         * DumpRenderTree/mac/DumpRenderTree.mm:
724         (dumpRenderTree): Removed the --paint option because the painting code
725         is always exercised as a result of
726         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
727         calling -displayIfNeeded.
728         (dump): Changed to always grab the image from the window since the view
729         is always displayed.
730         (runTest):
731         (displayWebView):
732         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
733         because it always paints.
734
735 2007-11-12  Antti Koivisto  <antti@apple.com>
736
737         Reviewed by Adele.
738         
739         Add support for http media tests
740
741         * Scripts/run-webkit-tests:
742
743 2007-11-12  Sam Weinig  <sam@webkit.org>
744
745         Reviewed by Adam Roben.
746
747         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
748
749         * DumpRenderTree/win/DumpRenderTree.cpp:
750         (runTest):
751         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
752         (LayoutTestController::setPrivateBrowsingEnabled):
753
754 2007-11-12  Adam Roben  <aroben@apple.com>
755
756         * Scripts/update-webkit-localizable-strings: Changed to only scan the
757         mac and win subdirectories.
758
759 2007-11-11  Adam Roben  <aroben@apple.com>
760
761         Fix <rdar://5133816> keepWebHistory is not implemented
762
763         Fixes fast/history/clicked-link-is-visited.html.
764
765         Reviewed by Darin.
766
767         * DumpRenderTree/win/DumpRenderTree.cpp:
768         (runTest): Clear the optionalSharedHistory.
769         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
770         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
771
772 2007-11-10  Sam Weinig  <sam@webkit.org>
773
774         Reviewed by Tim Hatcher.
775
776         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
777         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
778         is turned on)
779
780         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
781
782         Added test: http/tests/security/cross-frame-access-private-browsing.html
783
784         * DumpRenderTree/LayoutTestController.cpp:
785         (setPrivateBrowsingEnabledCallback):
786         (LayoutTestController::staticFunctions):
787         * DumpRenderTree/LayoutTestController.h:
788         * DumpRenderTree/mac/DumpRenderTree.mm:
789         (runTest): Default to private browsing disabled.
790         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
791         (LayoutTestController::setPrivateBrowsingEnabled):
792         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
793         (LayoutTestController::setPrivateBrowsingEnabled):
794
795 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
796
797         Reviewed by Adam.
798
799         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
800         WebCore's!
801
802         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
803         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
804         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
805         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
806         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
807         * Drosera/win/Drosera.cpp:
808         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
809
810 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
811
812         Reviewed by Sam.
813
814         - Use the new IWebFrame [local] function signature and get the shared
815         server correctly.
816
817         * Drosera/win/DebuggerClient.cpp:
818         (DebuggerClient::didFinishLoadForFrame):
819         * Drosera/win/ServerConnection.cpp:
820         (ServerConnection::attemptToCreateServerConnection):
821
822 2007-11-07  Dan Bernstein  <mitz@apple.com>
823
824         Reviewed by Darin Adler.
825
826         - add an option to run-webkit-tests to ignore pixel test failures where
827           all pixels differ by no more than a specified threshold
828
829         * DumpRenderTree/mac/ImageDiff.m:
830         (main):
831         (compareImages):
832         (computePercentageDifferent):
833         * Scripts/run-webkit-tests:
834
835 2007-11-07  Simon Hausmann  <hausmann@kde.org>
836
837         Reviewed by Lars.
838
839         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
840
841         * DumpRenderTree/qt/DumpRenderTree.cpp:
842
843 2007-11-07  Simon Hausmann  <hausmann@kde.org>
844
845         Reviewed by Lars.
846
847         Reworked the QWebSettings API.
848         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
849
850         * DumpRenderTree/qt/DumpRenderTree.cpp:
851
852 2007-11-07  Simon Hausmann  <hausmann@kde.org>
853
854         Reviewed by Lars.
855
856         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
857
858         * DumpRenderTree/qt/jsobjects.cpp:
859
860 2007-11-07  Simon Hausmann  <hausmann@kde.org>
861
862         Reviewed by Lars Knoll <lars@trolltech.com>.
863
864         Add a QWebPage::frameCreated() signal and fix DRT
865         
866         The removal of createFrame in QWebPage broke the re-implementation
867         in DumpRenderTree. Instead emit a frameCreated() signal and
868         connect to it in DumpRenderTree.
869         
870
871         * DumpRenderTree/qt/DumpRenderTree.cpp:
872         (WebCore::WebPage::WebPage):
873         (WebCore::DumpRenderTree::dump):
874         (WebCore::DumpRenderTree::connectFrame):
875         * DumpRenderTree/qt/DumpRenderTree.h:
876
877 2007-11-07  Simon Hausmann  <hausmann@kde.org>
878
879         Reviewed by Lars Knoll <lars@trolltech.com>.
880
881         Moved all the event handlers from QWebFrame into QWebPage.
882         
883         This cleans up the public API and allows us to remove the
884         HackWebFrame hack in DumpRenderTree.
885         
886
887         * DumpRenderTree/qt/jsobjects.cpp:
888         (EventSender::mouseDown):
889         (EventSender::mouseUp):
890         (EventSender::mouseMoveTo):
891
892 2007-11-07  Simon Hausmann  <hausmann@kde.org>
893
894         Reviewed by Mark.
895
896         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
897         to prevent the default implementation from popping up messageboxes.
898
899         * DumpRenderTree/qt/DumpRenderTree.cpp:
900         (WebCore::WebPage::javaScriptConfirm):
901         (WebCore::WebPage::javaScriptPrompt):
902
903 2007-11-06  Eric Seidel  <eric@webkit.org>
904
905         * Scripts/build-testkjs: build fix... too many $$
906
907 2007-11-06  Eric Seidel  <eric@webkit.org>
908
909         Reviewed by Mark Rowe.
910
911         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
912
913 2007-11-05  Adam Roben  <aroben@apple.com>
914
915         Add support on Windows for WEBKIT_TESTFONTS
916
917         This environment variable lets you specify where the fonts to be used
918         by DumpRenderTree reside. The Qt port is already using this, so I'm
919         just following their lead.
920
921         Reviewed by Darin.
922
923         * DumpRenderTree/win/DumpRenderTree.cpp:
924         (exePath): Refactored code out of initialize().
925         (fontsPath): Returns either $WEBKIT_TESTFONTS or
926         DumpRenderTree.resources.
927         (initialize): Use the new fontsPath function.
928         (main): Use the new exePath function.
929         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
930         variable to DRT, like Qt does.
931
932 2007-11-05  Mark Rowe  <mrowe@apple.com>
933
934         Rubber-stamped by Alp Toker.
935
936         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
937
938         * GtkLauncher/main.cpp:
939         (goToURLBarText):
940         (main):
941
942 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
943
944         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
945         <http://bugs.webkit.org/show_bug.cgi?id=15830>
946
947         Reviewed by Timothy.
948
949         Restrict the range of nightly builds used by the bisect-builds script
950         based on the version of Safari and the version of Mac OS X being used.
951
952         Mac OS X 10.4: Safari 2.0: r11976 or newer
953         Mac OS X 10.4: Safari 3.0: r19992 or newer
954
955         Mac OS X 10.5: Safari 2.0: r19594 or newer
956         Mac OS X 10.5: Safari 3.0: r25124 or newer
957
958         * Scripts/bisect-builds:
959         (findMacOSXVersion): Added.
960         (makeNightlyList): Added argument to provide version of Mac OS X.
961         Restrict range of nightly builds based on Safari and Mac OS X versions.
962
963 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
964
965         Reviewed by Maciej.
966
967         - This patch involves several changes, all of them were noticed that
968         they were needed by the work being done in WebKit to get Drosera and
969         WebKit working together on Windows.
970         - The changes are:
971         1) Added a debugger console for output messages.
972         2) Drosera now listens for the WebKit server (before, the server would
973         have to be running before Drosera was started.)
974         3) Fixed a bug where the WebView started out as 0x0 pixels.
975         4) Fixed a bug when there is no scope.
976         5) Added the HTML, JS, and CSS to the project file to make them easy to
977         find.
978         6) Made the ServerConnection functions virtual.
979
980         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
981         for the WebKit server.
982         (DebuggerClient::DebuggerClient):
983         (DebuggerClient::~DebuggerClient):
984         (DebuggerClient::didFinishLoadForFrame):
985         (DebuggerClient::serverConnected):
986         (DebuggerClient::attemptToCreateServerConnection):
987         * Drosera/win/DebuggerClient.h: Ditto.
988         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
989         scope.
990         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
991         (DebuggerDocument::platformValueForScopeVariableNamed):
992         * Drosera/win/Drosera.cpp:
993         (_tWinMain): Added a console in debug for output messages.
994         (Drosera::Drosera): Listen for server.
995         (Drosera::initUI): The server now Initializes COM.
996         (Drosera::serverConnected): Part of the listening for the server.
997         (Drosera::attemptToCreateServerConnection): Ditto.
998         * Drosera/win/Drosera.h: New interface for listening for the server.
999         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1000         files to the VS project.
1001         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1002         connection.
1003         (ServerConnection::ServerConnection):
1004         (ServerConnection::attemptToCreateServerConnection):
1005         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1006         methods.
1007         (ServerConnection::serverConnected):
1008
1009 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1010
1011         Reviewed by Maciej.
1012
1013         http://bugs.webkit.org/show_bug.cgi?id=15832
1014         fast/dom/gc-10.html crashes when run alone
1015
1016         Check for !done before using objects that can be already deallocated.
1017
1018         * DumpRenderTree/mac/EditingDelegate.mm:
1019         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1020         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1021         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1022         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1023         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1024         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1025         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1026         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1027         (-[EditingDelegate webViewDidBeginEditing:]):
1028         (-[EditingDelegate webViewDidChange:]):
1029         (-[EditingDelegate webViewDidEndEditing:]):
1030         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1031         (-[EditingDelegate webViewDidChangeSelection:]):
1032         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1033         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1034         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1035         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1036         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1037         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1038         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1039         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1040         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1041         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1042         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1043         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1044         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1045         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1046         (-[FrameLoadDelegate webView:willCloseFrame:]):
1047         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1048         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1049         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1050         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1051         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1052         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1053         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1054         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1055         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1056
1057 2007-11-04  Mark Rowe  <mrowe@apple.com>
1058
1059         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1060         warnings that would otherwise be suppressed due to it being a system header.
1061
1062         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1063
1064 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1065
1066         Rubber stamped by Adam.
1067         
1068         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1069
1070         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1071
1072 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1073
1074         Sort files(...); sections of Xcode project files.
1075
1076         Rubber-stamped by Darin.
1077
1078         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1079         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1080         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1081         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1082
1083 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1084
1085         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1086
1087         Reviewed by Darin.
1088
1089         * Scripts/sort-Xcode-project-file: Added.
1090
1091 2007-11-02  Darin Adler  <darin@apple.com>
1092
1093         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1094
1095 2007-11-02  Darin Adler  <darin@apple.com>
1096
1097         Reviewed by Maciej.
1098
1099         * Scripts/run-sunspider: Pass the "--base" option through.
1100
1101         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1102         the real script do that. Default configuration to Release to match run-sunspider
1103         so we don't end up building Debug just to compare results.
1104
1105 2007-11-01  Adam Roben  <aroben@apple.com>
1106
1107         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1108
1109         Reviewed by Sam.
1110
1111         * Scripts/commit-log-editor: Show all the directories beneath the
1112         source root, instead of just the last one.
1113
1114 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1115
1116         Reviewed by Adam Roben.
1117
1118         Print out an error message when the Windows build fails
1119         and provide guidance on how to find out what went wrong.
1120
1121         * Scripts/build-webkit:
1122         * Scripts/webkitdirs.pm:
1123
1124 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1125
1126         Rubber-stamped by Adam Roben.
1127
1128         Rolled out r27326 - debug CRT seems to cause no problems after all.
1129
1130         * DumpRenderTree/win/DumpRenderTree.vcproj:
1131
1132 2007-10-31  Adam Roben  <aroben@apple.com>
1133
1134         Switch the Debug configuration to using the non-debug CRT
1135
1136         This matches WebKit.
1137
1138         Reviewed by Steve.
1139
1140         * DumpRenderTree/win/DumpRenderTree.vcproj:
1141
1142 2007-10-31  Antti Koivisto  <antti@apple.com>
1143
1144         Reviewed by bdash.
1145         
1146         Disable media tests when doing leak checking on Tiger.
1147         They crash in QuickTime (rdar://problem/5537157).
1148
1149         * Scripts/run-webkit-tests:
1150
1151 2007-10-29  Antti Koivisto  <antti@apple.com>
1152
1153         Reviewed by Maciej.
1154         
1155         Build media support by default on OSX only.
1156
1157         * Scripts/build-webkit:
1158
1159 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1160
1161         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1162         get caught by the pre-commit hooks.
1163
1164 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1165
1166         Reviewed by Adam.
1167
1168         - This is a collection of relatively unrelated changes and cleanups
1169         to Drosera to prepare it for interacting with WebKit.  A lot of these
1170         changes are just correcting mistakes, for example removing included
1171         headers that are no longer needed.
1172
1173         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1174         this will be needed by the DebuggerClient.
1175         (DebuggerDocument::server):
1176         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1177         * Drosera/win/DebuggerClient.cpp: 
1178         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1179         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1180         (DebuggerClient::createWebViewWithRequest): Added comment about its
1181         purpose. 
1182         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1183         declarations.
1184         (DebuggerClient::webViewLoaded): Moved.
1185         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1186         file, since this was the only place it was used.
1187         (cfStringToBSTR):
1188         * Drosera/win/Drosera.h: Cleaned up the includes.
1189         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1190         * Drosera/win/HelperFunctions.h: Removed.
1191
1192 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1193
1194         Reviewed by Adam.
1195
1196         - Small cleanup in the ServerConnection class.
1197
1198         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1199         and added an include.
1200         (ServerConnection::currentFrame):
1201         (ServerConnection::getCallerFrame):
1202         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1203         made a pointer into a COMPtr, and cleaned up the includes.
1204
1205 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1206
1207         Reviewed by John Sullivan.
1208         
1209         - Place the Localizable.strings file in mac or win directories
1210           if that location exists.
1211         - Also look for UI_STRING in .c files.
1212
1213         * Scripts/extract-localizable-strings:
1214
1215 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1216
1217         Reviewed by Adam.
1218
1219         - Set the eol-style to native and made all the line endings the same
1220         so that I avoid messy diffs that show eol changes.
1221
1222         * Drosera/win/ServerConnection.cpp:
1223         (ServerConnection::didParseSource):
1224         (ServerConnection::didEnterCallFrame):
1225         (ServerConnection::willExecuteStatement):
1226         (ServerConnection::willLeaveCallFrame):
1227         (ServerConnection::exceptionWasRaised):
1228
1229 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1230
1231         Reviewed by Adam.
1232
1233         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1234         functionality that could not have existed previously without the new
1235         interfaces.
1236         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1237         from a BSTR to a JSValueRef.
1238         (DebuggerDocument::platformEvaluateScript): Implemented.
1239         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1240         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1241         Implemented.
1242         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1243         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1244         * Drosera/win/ServerConnection.cpp: Added a helper function.
1245         (ServerConnection::getCallerFrame):
1246         * Drosera/win/ServerConnection.h: Added a helper function.
1247
1248 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1249
1250         updated reviewers for my previous changelog.
1251
1252 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1253         Reviewed by Maciej and Adam and Geoff.
1254
1255         - Minor mac-side improvements including moving a function to a more
1256         appropriate location, fixing a warning, and correctly checking
1257         exceptions.
1258
1259         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1260         (DebuggerDocument::willExecuteStatement):
1261         (DebuggerDocument::didEnterCallFrame):
1262         (DebuggerDocument::willLeaveCallFrame):
1263         (DebuggerDocument::windowScriptObjectAvailable):
1264         (DebuggerDocument::callFunctionOnObject):
1265         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1266         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1267         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1268         because it doesn't require the ServerConnection at all.
1269         (NSStringCreateWithJSStringRef): Made an argument const.
1270         (JSValueRefCreateWithNSString): Made an argument const.
1271         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1272         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1273         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1274         * Drosera/mac/ServerConnection.mm: Ditto.
1275         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1276
1277 2007-10-29  Sam Weinig  <sam@webkit.org>
1278
1279         Reviewed by Adam Roben.
1280
1281         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1282
1283         * DumpRenderTree/LayoutTestController.cpp:
1284         (LayoutTestController::LayoutTestController):
1285         (getGlobalFlagCallback):
1286         (setGlobalFlagCallback):
1287         (LayoutTestController::getJSClass):
1288         (LayoutTestController::staticValues):
1289         * DumpRenderTree/LayoutTestController.h:
1290         (LayoutTestController::globalFlag):
1291         (LayoutTestController::setGlobalFlag):
1292
1293 2007-10-29  Darin Adler  <darin@apple.com>
1294
1295         Reviewed by Maciej.
1296
1297         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1298         resolution instead of its default.
1299
1300 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1301
1302         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1303
1304         Reviewed by Mark Rowe.
1305
1306         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1307         was successfully resolved, but this would not show any status because the change had
1308         already been cached in the index using "git add".  The solution is to add an optional
1309         second argument to showStatus() which adds the "--cached" switch to the command.
1310
1311         * Scripts/resolve-ChangeLogs:
1312         (showStatus):
1313
1314 2007-10-28  Eric Seidel  <eric@webkit.org>
1315
1316         Reviewed by Maciej and Geoff, in unison.
1317
1318         * Scripts/run-webkit-tests: remove broken --svg option
1319
1320 2007-10-28  Darin Adler  <darin@apple.com>
1321
1322         Reviewed by Adam.
1323
1324         * Scripts/run-sunspider: Default to "Release" configuration rather than
1325         defaulting to the last configuration used as other scripts do. This can
1326         still be overriden on the command line with "--debug" if there's some
1327         reason to do so. Also fix a typo.
1328
1329         * Scripts/sunspider-compare-results: Fix a typo.
1330
1331 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1332
1333         Reviewed by Adam.
1334
1335         - Implemented the WebScriptDebugListener functions now that the
1336         WebScriptDebugServer exists
1337
1338         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1339         functions.
1340         (ServerConnection::currentFrame):
1341         (ServerConnection::didLoadMainResourceForDataSource):
1342         (ServerConnection::didParseSource):
1343         (ServerConnection::failedToParseSource):
1344         (ServerConnection::didEnterCallFrame):
1345         (ServerConnection::willExecuteStatement):
1346         (ServerConnection::willLeaveCallFrame):
1347         (ServerConnection::exceptionWasRaised):
1348         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1349         members arguments list.
1350
1351 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1352
1353         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1354         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1355
1356         Reviewed by Darin.
1357
1358         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1359         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1360         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1361         file.  Note that it may also be used as a stand-alone script.
1362
1363         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1364         * Scripts/resolve-ChangeLogs: Added.
1365         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1366
1367 2007-10-26  Mark Rowe  <mrowe@apple.com>
1368
1369         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1370         to the Qt port on the assumption that it was an implementation of the cross-platform
1371         LayoutTestController class.  It is not, so it did not need to be changed.
1372
1373         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1374
1375 2007-10-25  Mark Rowe  <mrowe@apple.com>
1376
1377         Reviewed by Maciej.
1378
1379         Fix builds with code coverage enabled.
1380
1381         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1382
1383 2007-10-25  Darin Adler  <darin@apple.com>
1384
1385         Reviewed by Mark Rowe.
1386
1387         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1388         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1389
1390 2007-10-25  Stephanie  <slewis@apple.com>
1391
1392         build Fix
1393
1394         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1395
1396 2007-10-25  Stephanie  <slewis@apple.com>
1397
1398         Reviewed by Mark Rowe, Adam Roben.
1399
1400         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1401
1402         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1403
1404 2007-10-25  Alice Liu  <alice.liu@apple.com>
1405
1406         Reviewed by Adam.
1407
1408         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1409
1410         Moving destructor into platform-specific files
1411         * DumpRenderTree/LayoutTestController.cpp:
1412         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1413         (LayoutTestController::~LayoutTestController):
1414         * DumpRenderTree/qt/jsobjects.cpp:
1415         (LayoutTestController::~LayoutTestController):
1416
1417         LayoutTestController wasn't being destroyed
1418         * DumpRenderTree/win/DumpRenderTree.cpp:
1419         (runTest):
1420
1421         Added declspec
1422         * DumpRenderTree/win/EditingDelegate.h:
1423
1424         Reset certain values on the webview (or related delegate) that might 
1425         have changed while running a test
1426         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1427         (LayoutTestController::~LayoutTestController):
1428
1429 2007-10-25  Adam Roben  <aroben@apple.com>
1430
1431         Make sunspider-compare-results work with relative paths
1432
1433         Reviewed by Sam.
1434
1435         * Scripts/sunspider-compare-results: Convert arguments to absolute
1436         paths before we chdir.
1437
1438 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1439
1440         Reviewed by Sam.
1441
1442         - Implemented server calls now the WebScriptDebugServer exists.
1443         - Also removed no longer needed call to initialize CG.
1444
1445         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1446         automatically now.
1447         (_tWinMain):
1448         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1449         (ServerConnection::ServerConnection):
1450         (ServerConnection::~ServerConnection):
1451         (ServerConnection::pause):
1452         (ServerConnection::resume):
1453         (ServerConnection::stepInto):
1454         (ServerConnection::applicationTerminating):
1455         (ServerConnection::serverConnectionDidDie):
1456         * Drosera/win/ServerConnection.h: Now uses the COM class.
1457
1458 2007-10-24  George Staikos  <staikos@kde.org>
1459
1460         Unbreak Qt build.
1461
1462         * Scripts/build-webkit:
1463
1464 2007-10-24  Adam Roben  <aroben@apple.com>
1465
1466         Remove now-unnecessary call to InitializeCoreGraphics
1467
1468         WebKit takes care of this now.
1469
1470         Reviewed by Ada.
1471
1472         * DumpRenderTree/win/DumpRenderTree.cpp:
1473         (initialize):
1474
1475 2007-10-24  Adam Roben  <aroben@apple.com>
1476
1477         Use WebTextRenderer in DRT
1478
1479         Reviewed by Ada.
1480
1481         * DumpRenderTree/win/DumpRenderTree.cpp:
1482         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1483
1484 2007-10-24  Sven Herzberg  <sven@imendio.com>
1485
1486         Reviewed by Mark Rowe.
1487
1488         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1489         Bug 15614: [GTK] qmake based backends don't build on OS X
1490
1491         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1492         GTK backend on a Mac
1493         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1494         isDarwin() to make it reusable in other places (like the workaround-
1495         for-prebuilt-qmake in build-webkit)
1496
1497 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1498
1499         Refurbish update-webkit script.
1500
1501         Reviewed by Adam.
1502
1503         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
1504         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
1505         multi-argument version of system() for flexibility and security.  Check for existence
1506         of Internal directory using -d test instead of -x.
1507
1508 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1509
1510         Minor clean-up of prepare-ChangeLog script.
1511
1512         Reviewed by Adam.
1513
1514         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1515         of a string.  Use multi-argument versions of open() and system() for flexibility and
1516         security.
1517
1518 2007-10-24  Alice Liu  <alice.liu@apple.com>
1519
1520         Reviewed by Oliver.
1521
1522         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1523
1524         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
1525         replay the saved events when we're still processing the mousedown that starts the drag
1526         * DumpRenderTree/win/EventSender.cpp:
1527         (doMouseMove):
1528         * DumpRenderTree/win/UIDelegate.cpp:
1529         (UIDelegate::doDragDrop):
1530
1531 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1532
1533         Reviewed by Sam, Steve and Darin.
1534
1535         - Stubbed out the WebScriptDebugListener functionality in the Server
1536         Connection class to prepare it for receiving those callbacks.
1537         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1538         and the ServerConnection to not need to be initialized with a server
1539         name, since that is not the way we connect to the WebKit server. 
1540
1541         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1542         no exception.  Now it only loggs when there is an exception
1543         (DebuggerDocument::willExecuteStatement):
1544         (DebuggerDocument::didEnterCallFrame):
1545         (DebuggerDocument::willLeaveCallFrame):
1546         (DebuggerDocument::windowScriptObjectAvailable):
1547         (DebuggerDocument::callFunctionOnObject):
1548         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1549         to be instantiated with a server's name.
1550         (DebuggerClient::DebuggerClient):
1551         (DebuggerClient::didFinishLoadForFrame):
1552         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1553         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1554         a server name.
1555         (Drosera::init):
1556         (Drosera::initServer):
1557         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1558         instantiated with a server's name.
1559         * Drosera/win/ServerConnection.cpp: 
1560         (ServerConnection::ServerConnection): No longer needs a server name
1561         (ServerConnection::~ServerConnection): Only release the global context
1562         if there is one.
1563         (ServerConnection::serverConnectionDidDie): Stub for
1564         IWebScriptDebugListener
1565         (ServerConnection::QueryInterface): ditto
1566         (ServerConnection::AddRef): ditto
1567         (ServerConnection::Release): ditto
1568         (ServerConnection::didLoadMainResourceForDataSource): ditto
1569         (ServerConnection::didParseSource): ditto
1570         (ServerConnection::failedToParseSource): ditto
1571         (ServerConnection::didEnterCallFrame): ditto
1572         (ServerConnection::willExecuteStatement): ditto
1573         (ServerConnection::willLeaveCallFrame): ditto
1574         (ServerConnection::exceptionWasRaised): ditto
1575         * Drosera/win/ServerConnection.h: Stubbed out the
1576         IWebScriptDebugListener functions, and this class no longer needs to be
1577         instantiated with a server name.
1578
1579 2007-10-24  Lars Knoll  <lars@trolltech.com>
1580
1581         Reviewed by Simon.
1582
1583         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1584
1585         * DumpRenderTree/qt/jsobjects.h:
1586
1587 2007-10-24  Lars Knoll  <lars@trolltech.com>
1588
1589         Reviewed by Simon.
1590
1591         add another command.
1592
1593         * DumpRenderTree/qt/jsobjects.cpp:
1594         (TextInputController::doCommand):
1595
1596 2007-10-24  Lars Knoll  <lars@trolltech.com>
1597
1598         Reviewed by Simon.
1599
1600         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1601
1602         * DumpRenderTree/qt/jsobjects.cpp:
1603         (EventSender::keyDown):
1604         * DumpRenderTree/qt/jsobjects.h:
1605
1606 2007-10-24  Lars Knoll  <lars@trolltech.com>
1607
1608         Reviewed by Simon.
1609
1610         implement eventSender.keyDown().
1611
1612         * DumpRenderTree/qt/jsobjects.cpp:
1613         (EventSender::keyDown):
1614
1615 2007-10-24  Lars Knoll  <lars@trolltech.com>
1616
1617         Reviewed by Simon.
1618
1619         some smaller fixes to the editing support in DRT. Makes another few tests pass.
1620
1621         * DumpRenderTree/qt/DumpRenderTree.cpp:
1622         (WebCore::DumpRenderTree::DumpRenderTree):
1623         (WebCore::DumpRenderTree::initJSObjects):
1624         * DumpRenderTree/qt/jsobjects.cpp:
1625         (TextInputController::doCommand):
1626
1627 2007-10-24  Lars Knoll  <lars@trolltech.com>
1628
1629         Reviewed by Simon.
1630
1631         first bit of implementation for the textinputcontroller.
1632
1633         * DumpRenderTree/qt/DumpRenderTree.cpp:
1634         (WebCore::DumpRenderTree::DumpRenderTree):
1635         * DumpRenderTree/qt/DumpRenderTree.h:
1636         * DumpRenderTree/qt/jsobjects.cpp:
1637         (TextInputController::TextInputController):
1638         (TextInputController::doCommand):
1639         * DumpRenderTree/qt/jsobjects.h:
1640
1641 2007-10-24  Lars Knoll  <lars@trolltech.com>
1642
1643         Reviewed by Simon.
1644
1645         make the man webpage believe it has focus, so the editing tests work correctly.
1646
1647         * DumpRenderTree/qt/DumpRenderTree.cpp:
1648         (WebCore::DumpRenderTree::DumpRenderTree):
1649
1650 2007-10-24  Lars Knoll  <lars@trolltech.com>
1651
1652         Reviewed by Simon.
1653
1654         implement layoutTestController.dumpEditingCallbacks() correctly.
1655
1656         * DumpRenderTree/qt/DumpRenderTree.cpp:
1657         (WebCore::DumpRenderTree::DumpRenderTree):
1658         * DumpRenderTree/qt/jsobjects.cpp:
1659         (LayoutTestController::reset):
1660         (LayoutTestController::dumpEditingCallbacks):
1661
1662 2007-10-24  Lars Knoll  <lars@trolltech.com>
1663
1664         Reviewed by Simon.
1665
1666         Implement support for testing editing.
1667
1668         * DumpRenderTree/qt/DumpRenderTree.cpp:
1669         (WebCore::DumpRenderTree::DumpRenderTree):
1670
1671 2007-10-23  Sam Weinig  <sam@webkit.org>
1672
1673         Check for null BSTR that can be passed to the UIDelegate methods
1674         from javascript null and undefined.  Fixes a failing test case on
1675         Windows (fast/dom/Window/alert-undefined.html)
1676
1677         Reviewed by Eric Seidel.
1678
1679         * DumpRenderTree/win/UIDelegate.cpp:
1680         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1681         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1682         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1683         (UIDelegate::webViewAddMessageToConsole):
1684
1685 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1686
1687         Reviewed by Darin.
1688         
1689         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1690
1691         * Scripts/build-testkjs:
1692
1693 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1694
1695         Reviewed by Darin.
1696
1697         - add wrapper that finds the right copy of testkjs
1698         
1699         * Scripts/sunspider-compare-results: Added.
1700
1701 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1702
1703         Reviewed by Sam.
1704
1705         - After talking with Steve I now see that the WebKit server must be
1706         running for DCOM to create the distributed objects, which makes sense
1707         and currently WebKit only allows one instance to be running at a time
1708         which avoids accidentally connecting to the wrong server
1709         - In light of this I have removed the code for the attach box and
1710         NotificationServer and known server names, since they are all extranious
1711         now.
1712
1713         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1714         names.
1715         (_tWinMain): Uses init instead of initUI.
1716         (droseraWndProc): No longer creats an attach dialog box.
1717         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1718         it's not manditory to call init before doing COM stuff.
1719         (Drosera::init): calls initUI and will call attach when the
1720         functionality exists. 
1721         (Drosera::initUI): Has changed very little.
1722         (Drosera::attach): Changed the signature to reflect that we no longer
1723         need the dictionary of known server names.
1724         * Drosera/win/Drosera.h: Removed notification classes and known server
1725         names.  Also renamed and moved some functions.
1726         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1727         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1728         headers to the resources folder. 
1729         * Drosera/win/resource.h: Removed the Attach box.
1730
1731 2007-10-22  Adam Roben  <aroben@apple.com>
1732
1733         Windows build fix
1734
1735         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1736
1737 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1738
1739         - Removed a leak that was fixed.
1740
1741         * Scripts/run-webkit-tests:
1742
1743 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1744
1745         Reviewed by Darin.
1746
1747         - Changed the Client so that the DebuggerDocument now own the
1748         ServerConnection.  This simplifies ownership and cleanup. 
1749
1750         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1751         ServerConnection.
1752         (DebuggerClient::initWithServerName):
1753         (DebuggerClient::didFinishLoadForFrame):
1754         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
1755         ServerConnection.
1756         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1757         until after we have a server which we are attached to.
1758         (Drosera::initUI):
1759         (Drosera::attach):
1760         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1761         out previously.
1762
1763 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1764
1765         Reviewed by Nikolas.
1766
1767         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1768
1769         * Scripts/run-javascriptcore-tests:
1770
1771 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1772
1773         Reviewed by Nikolas.
1774
1775         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1776
1777         * Scripts/build-drosera:
1778         * Scripts/build-dumprendertree:
1779         * Scripts/build-testkjs:
1780         * Scripts/build-webkit:
1781         * Scripts/run-javascriptcore-tests:
1782         * Scripts/run-sunspider:
1783         * Scripts/run-webkit-tests:
1784         * Scripts/webkitdirs.pm:
1785
1786 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1787
1788         Reviewed by Mark Rowe.
1789         
1790         Fix for local database support after r26879
1791         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1792
1793         * Scripts/build-webkit:
1794
1795 2007-10-22  Holger Freyther  <zecke@selfish.org>
1796
1797         Reviewed by Simon Hausmann <hausmann@kde.org>.
1798
1799         - Do not build testkjs as an application bundle. This is
1800         needed for run-javascriptcore-tests on OSX.
1801         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1802         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1803         as we do not have -rpath on OSX.
1804
1805         * DumpRenderTree/qt/DumpRenderTree.pro:
1806         * Scripts/run-webkit-tests:
1807
1808 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1809
1810         Reviewed by aroben.
1811
1812         Fix support for Signed-off-by detection in prepare-ChangeLog
1813         --git-commit. The Signed-off-by tag does not appear in the header
1814         but usually at the end.
1815
1816         * Scripts/prepare-ChangeLog:
1817
1818 2007-10-21  Mark Rowe  <mrowe@apple.com>
1819
1820         Reviewed by Eric.
1821
1822         Fix run-javascriptcore-tests for Gtk.
1823
1824         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1825
1826 2007-10-20  Eric Seidel  <eric@webkit.org>
1827
1828         Reviewed by aroben.
1829
1830         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1831
1832 2007-10-20  Eric Seidel  <eric@webkit.org>
1833
1834         Reviewed by darin.
1835         
1836         Add improved argument handling to run-sunspider, including
1837         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1838         Also re-factor code into subroutines
1839
1840         * Scripts/build-dumprendertree: removed bogus comments
1841         * Scripts/build-testkjs: Added.
1842         * Scripts/run-javascriptcore-tests: use build-testkjs
1843         * Scripts/run-sunspider: improved argument handling, abstraction
1844         * Scripts/run-webkit-tests: improved abstraction
1845
1846 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1847
1848         Not reviewed, Windows build fix.
1849
1850         * DumpRenderTree/win/EventSender.cpp:
1851         (keyDownCallback):
1852
1853 2007-10-20  Darin Adler  <darin@apple.com>
1854
1855         Reviewed by Tim Hatcher.
1856
1857         - http://bugs.webkit.org/show_bug.cgi?id=15544
1858           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
1859           not rely on Apple-specific key codes
1860
1861         * DumpRenderTree/mac/EventSendingController.mm:
1862         (-[EventSendingController keyDown:withModifiers:]):
1863         Added named key "rightArrow". Later we could have a whole table of these.
1864         Also tweaked modifiers code a little.
1865
1866         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
1867
1868 2007-10-19  Darin Adler  <darin@apple.com>
1869
1870         Reviewed by Eric.
1871
1872         - http://bugs.webkit.org/show_bug.cgi?id=15566
1873           possible fix for leak seen in DumpRenderTree
1874
1875         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
1876         Delete the item if it's not put on the queue, since the caller has
1877         no way of knowing that. Would be better to have the parameter type
1878         be auto_ptr to express the fact that we take ownership.
1879
1880         - unrelated change
1881
1882         * Drosera/mac/main.m: Add missing include.
1883
1884 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1885
1886         Reviewed by Adam.
1887
1888         - This change should be identical but for some reason was not working
1889         on my machine.
1890
1891         * Scripts/prepare-ChangeLog:
1892
1893 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1894
1895         Reviewed by Oliver and Tim.
1896
1897         - Made use of RetainPtr to avoid retain and release issues and moved the
1898         log function to DebuggerDocumentPlatform, which seems to be a more
1899         logical place for it to live.
1900         - Also moved knownServers from the ServerConnection to
1901         DebuggerApplication to match the Windows code and because it makes sense
1902         that a connection knows its own server but not all of them.
1903
1904         * Drosera/mac/DebuggerClient.h: Moved the log function to
1905           DebuggerDocumentPlatform.
1906         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
1907           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
1908           call for the server name up from the ServerConnection class.
1909         (-[DebuggerClient dealloc]):
1910         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
1911           for the server name up from the ServerConnection.
1912         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
1913         (DebuggerDocument::platformPause):
1914         (DebuggerDocument::platformResume):
1915         (DebuggerDocument::platformStepInto):
1916         (DebuggerDocument::platformEvaluateScript):
1917         (DebuggerDocument::getPlatformCurrentFunctionStack):
1918         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1919         (DebuggerDocument::platformValueForScopeVariableNamed):
1920         (DebuggerDocument::platformLog): Log directly from here. No need to call
1921           DebuggerClient.
1922         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
1923           way I see it, a ServerConnection should only know about its connection
1924           and the group of all possible servers should be kept by the
1925           application.
1926         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
1927           currentServerName, it makes sense that the connection should know that
1928           name.
1929         (-[ServerConnection currentServerName]):
1930
1931 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1932
1933         Reviewed by Adam.
1934
1935         - Integrated changes from mac drosera.  Recently I've encapsulated
1936         out the server connection object from the rest of Drosera because
1937         it is very platform dependent right now and RPC is not implemented on
1938         windows.  This functionality, of communicating with the WebKit server
1939         is the next area I will be focusing on in Windows.
1940
1941         - Other changes and cleanup were made to organize the code and add notes
1942         on which parts still need work.  Also some mac code is added and
1943         commented out, to act as pseudocode for the logic of those parts.
1944
1945         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
1946           pointer.
1947         * Drosera/config.h: Added whitespace.
1948         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
1949           these files got moved into Drosera.h/cpp
1950         * Drosera/win/DebuggerApplication.h: Removed.
1951         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
1952           happened here to better match the logic flow of the same code on the 
1953           mac side and to use the new ServerConnection class.
1954         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
1955         (DebuggerClient::initWithServerName): Initializer that will set up the
1956           class to use a ServerConnection object.  This was necessary so I could
1957           create a DebuggerClient without having to initilaize it at
1958           construction.
1959         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
1960           will be the UIDelegate and FrameLoadDelegate.
1961         (DebuggerClient::AddRef): For IUnknown.
1962         (DebuggerClient::Release): For IUnknown.
1963         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
1964           this still needs to set the global context of the server, but
1965           IWebFrame does not have an accessor for the global context yet. 
1966         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
1967           this is a pass through for the same function in the document.
1968         (DebuggerClient::didReceiveTitle): Unimplemented part of
1969           FrameLoadDelegate this would change the title of the window.
1970         (DebuggerClient::createWebViewWithRequest): Part of the
1971           FrameLoadDelegate.  This is about new windows via Window.open() and
1972           how their delegates are set.
1973         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
1974           UIDelegate.  Just a debug function for printing messages.
1975         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
1976           because the Client should be the UIDelegate and FrameLoadDelegate
1977           to match the delegates on mac.
1978         (DebuggerClient::webViewLoaded): Added accessor method.
1979         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
1980           forgotten to add this file before.  This is where the platform
1981           dependent versions of the Documents functions live. Most of these are
1982           unimplemented because some piece of functionality does not exist on
1983           Windows yet.
1984         (DebuggerDocument::platformPause):
1985         (DebuggerDocument::platformResume):
1986         (DebuggerDocument::platformStepInto):
1987         (DebuggerDocument::platformEvaluateScript):
1988         (DebuggerDocument::getPlatformCurrentFunctionStack):
1989         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1990         (DebuggerDocument::platformValueForScopeVariableNamed):
1991         (DebuggerDocument::platformLog):
1992         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
1993           responsibilities becaue they belong in the Client. Also I laid the
1994           groundwork for attaching Drosera to a WebKit process
1995         (attachWndProc): Now if a server is selected the Client becomes it's
1996           delegate.
1997         (Drosera::Drosera): Added the construction of the Client and dictionary
1998           of server names. 
1999         (Drosera::initUI): This is no longer the delegates, the Client is.
2000         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2001           state. 
2002         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2003           notification registration when it's possible to implement.
2004         (Drosera::serverLoaded): Ditto
2005         (Drosera::serverUnloaded): Ditto
2006         (Drosera::attach): Attach Drosera to the WebKit server.
2007         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2008         (Drosera::getInst): 
2009         (Drosera::setInst):
2010         (Drosera::knownServers):
2011         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2012           and added the ServerConnection.
2013         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2014         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2015           Most of the functions are completely unimlemented because they cannot
2016           connect with the WebKit server, because one does not exist on Windows
2017           yet.
2018         (ServerConnection::initWithServerName): 
2019         (ServerConnection::~ServerConnection):
2020         (ServerConnection::setGlobalContext):
2021         (ServerConnection::pause):
2022         (ServerConnection::resume):
2023         (ServerConnection::stepInto):
2024         (ServerConnection::switchToServerNamed):
2025         (ServerConnection::applicationTerminating):
2026         (ServerConnection::serverConnectionDidDie):
2027         (ServerConnection::currentFrame):
2028         * Drosera/win/ServerConnection.h: Added. Ditto.
2029         (ServerConnection::ServerConnection):
2030
2031 2007-10-19  Alice Liu  <alice.liu@apple.com>
2032
2033         Reviewed by Darin.
2034
2035         Fix for these broken layout tests on Windows:
2036         
2037         fast/forms/focus-selection-input.html
2038         fast/forms/focus-selection-textarea.html
2039         fast/forms/select-accesskey.html
2040         
2041         * DumpRenderTree/win/EventSender.cpp:
2042         (keyDownCallback):
2043         correct the VK code for alt key.
2044         
2045 2007-10-19  Eric Seidel  <eric@webkit.org>
2046
2047         Reviewed by Mark Rowe.
2048         
2049         Make the GtkLauncher code slightly more readable.
2050
2051         * GtkLauncher/main.cpp:
2052         (setupMainMenu): Added.
2053         (setupMainWindowUI): Added.
2054         (main):
2055
2056 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2057
2058         Rubber stamped by Adam.
2059         
2060         - don't delay-load WebKit in DumpRenderTree.
2061
2062         * DumpRenderTree/win/DumpRenderTree.vcproj:
2063
2064 2007-10-18  Dan Bernstein  <mitz@apple.com>
2065
2066         Reviewed by Adam Roben.
2067
2068         - fix <rdar://problem/5313523>
2069         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2070
2071         * DumpRenderTree/mac/DumpRenderTree.mm:
2072         (dump): Changed to use _responseMIMEType.
2073
2074 2007-10-17  Adam Roben  <aroben@apple.com>
2075
2076         Make it possible to have Windows-specific tests and results
2077
2078         When searching for tests to run and the Skipped file, we will only
2079         look in platform/win and the cross-platform directory. When looking
2080         for expected results, we will look in platform/win, then
2081         platform/mac-leopard, then platform/mac, then finally the
2082         cross-platform directory.
2083
2084         Reviewed by Sam.
2085
2086         * Scripts/run-webkit-tests:
2087         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2088         searching in the cross-platform directory.
2089         (sub buildPlatformHierarchy): Removed some unneeded calls to
2090         dirname/basename.
2091
2092 2007-10-17  Adam Roben  <aroben@apple.com>
2093
2094         Add back the call to register WebKit that we had before WebKitInitializer existed
2095
2096         This is needed to ensure that the right WebKit is used when
2097         instantiating COM objects.
2098
2099         Reviewed by Oliver.
2100
2101         * DumpRenderTree/win/debug_internal.vsprops: Define
2102         DEBUG_WEBKIT_HAS_SUFFIX.
2103         * DumpRenderTree/win/DumpRenderTree.cpp:
2104         (initialize):
2105
2106 2007-10-17  Adam Roben  <aroben@apple.com>
2107
2108         Import File::Basename in webkitdirs since we use it
2109
2110         * Scripts/webkitdirs.pm:
2111
2112 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2113
2114         - Updated the tiger leaks list to make the internal bots green.
2115
2116         * Scripts/run-webkit-tests:
2117
2118 2007-10-17  Adam Roben  <aroben@apple.com>
2119
2120         Build fix for VC++ Express
2121
2122         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2123         and ole32.lib.
2124
2125 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2126
2127         Reviewed by Sam.
2128
2129         - Minor mac improvements based on observations I made while implementing the
2130         Windows code.
2131
2132         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2133         then hand it to the Client who will retain it, it should just be the client who
2134         creates and owns the server.
2135         (-[DebuggerApplication attach:]):
2136         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2137         * Drosera/mac/DebuggerClient.mm: Creates the server.
2138         (-[DebuggerClient initWithServerName:]):
2139         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2140         can instead forward declare what it needs.
2141
2142 2007-10-16  Darin Adler  <darin@apple.com>
2143
2144         Reviewed by Geoff Garen.
2145
2146         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2147         want to turn failing tests into platform-specific test results. Also did a
2148         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2149         would take the type of results into account only some of the time.
2150
2151 2007-10-16  Adam Roben  <aroben@apple.com>
2152
2153         Add a new nightly launcher script for Windows
2154
2155         This new script is for versions of Safari that don't delay-load
2156         WebKit. I had to make FindSafari be able to print out the nightly
2157         launcher script on stdout because Windows shell scripts can't capture
2158         the output from a command into an environment variable.
2159
2160         Reviewed by Steve.
2161
2162         * FindSafari/FindSafari.cpp:
2163         (_tmain): Added /printSafariLauncher option.
2164         * Scripts/run-webkit-nightly.cmd: Added.
2165
2166 2007-10-16  Adam Roben  <aroben@apple.com>
2167
2168         Replace WebKitInitializer with FindSafari
2169
2170         We now rely on setting the PATH environment variable to tell Windows
2171         where to find WebKit and its dependencies (similar to
2172         DYLD_FRAMEWORK_PATH on Mac).
2173
2174         This change also make DumpRenderTree no longer delay-load WebKit.
2175
2176         Reviewed by Sam.
2177
2178         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2179         FindSafari.
2180         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2181         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2182         WebKitInitializer, don't delay-load WebKit.
2183         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2184         * Scripts/run-webkit-tests: Ditto.
2185         * Scripts/webkitdirs.pm:
2186         (sub setPathForRunningWebKitApp): Added.
2187         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2188         * WebKitInitializer/WebKitInitializer.h: Removed.
2189         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2190         * WebKitInitializer/debug.vsprops: Removed.
2191         * WebKitInitializer/debug_internal.vsprops: Removed.
2192         * WebKitInitializer/release.vsprops: Removed.
2193
2194 2007-10-16  Adam Roben  <aroben@apple.com>
2195
2196         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2197
2198         http://bugs.webkit.org/show_bug.cgi?id=15532
2199
2200         FindSafari simply prints the location of an installed Safari.exe on
2201         stdout.
2202
2203         Reviewed by Darin.
2204
2205         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2206         (getStringValue):
2207         (getWebViewCLSID):
2208         (getInstalledWebKitDirectory):
2209         (_tmain):
2210         * FindSafari/FindSafari.vcproj: Added.
2211         * Scripts/webkitdirs.pm:
2212         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2213
2214 2007-10-16  Adam Roben  <aroben@apple.com>
2215
2216         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2217
2218         Reviewed by Kevin McCullough.
2219
2220         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2221         when referring to WebKit.dll.
2222         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2223         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2224         * DumpRenderTree/win/release.vsprops: Ditto.
2225         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2226         never have a _debug suffix on WebKit.dll.
2227         * WebKitInitializer/WebKitInitializer.cpp:
2228         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2229         specified.
2230         * WebKitInitializer/debug_internal.vsprops: Added
2231         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2232
2233 2007-10-16  Darin Adler  <darin@apple.com>
2234
2235         Reviewed by Adele.
2236
2237         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2238         Remove now-unneeded control/alt key hack; the tests have been updated.
2239
2240 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2241
2242         - Updated leaks list because our internal bot upgraded it's version of leopard and 
2243         one of the leaks was fixed between that revision and the bot's previous version of
2244         leopard.
2245
2246         * Scripts/run-webkit-tests:
2247
2248 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2249
2250         Reviewed by Tim.
2251
2252         - I encapsulated out the server connecton functionality because it is a specific part
2253         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2254         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2255         Windows.  So the majority of this patch is moving preexisting functionality.
2256
2257         - Also I removed the prefix header and changed to use config.h because it is more
2258         standard on how we use config.h in windows and it didn't make much sense to keep
2259         the prefix header and the config.h
2260
2261         * Drosera/DebuggerDocument.cpp:
2262         (DebuggerDocument::DebuggerDocument):
2263         * Drosera/DebuggerDocument.h:
2264         * Drosera/config.h:
2265         * Drosera/mac/DebuggerApplication.mm:
2266         (-[DebuggerApplication attach:]):
2267         * Drosera/mac/DebuggerClient.h:
2268         * Drosera/mac/DebuggerClient.mm:
2269         (-[DebuggerClient initWithServerConnection:]):
2270         (-[DebuggerClient dealloc]):
2271         (-[DebuggerClient windowDidLoad]):
2272         (-[DebuggerClient windowWillClose:]):
2273         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2274         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2275         * Drosera/mac/DebuggerDocumentPlatform.mm:
2276         (DebuggerDocument::platformPause):
2277         (DebuggerDocument::platformResume):
2278         (DebuggerDocument::platformStepInto):
2279         (DebuggerDocument::platformEvaluateScript):
2280         (DebuggerDocument::getPlatformCurrentFunctionStack):
2281         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2282         (DebuggerDocument::platformValueForScopeVariableNamed):
2283         (DebuggerDocument::platformLog):
2284         * Drosera/mac/Drosera.pch: Removed.
2285         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2286         * Drosera/mac/ServerConnection.h: Added.
2287         * Drosera/mac/ServerConnection.mm: Added.
2288         (-[ServerConnection initWithServerName:]):
2289         (-[ServerConnection dealloc]):
2290         (-[ServerConnection setGlobalContext:]):
2291         (-[ServerConnection pause]):
2292         (-[ServerConnection resume]):
2293         (-[ServerConnection stepInto]):
2294         (-[ServerConnection switchToServerNamed:]):
2295         (-[ServerConnection applicationTerminating:]):
2296         (-[ServerConnection serverConnectionDidDie:]):
2297         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2298         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2299         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2300         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2301         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2302         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2303         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2304         (-[ServerConnection currentFrame]):
2305         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2306         (-[ServerConnection knownServers]):
2307
2308 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2309
2310         Reviewed by Eric.
2311
2312         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2313           Script to automatically search nightly builds for regressions (bisect-builds)
2314
2315         * Scripts/bisect-builds: Added.
2316
2317 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2318
2319         Reviewed by Darin.
2320
2321         - New JavaScript benchmark
2322         http://bugs.webkit.org/show_bug.cgi?id=15515
2323
2324         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2325         current development or release build of JavaScriptCore.
2326
2327 2007-10-15  Mark Rowe  <mrowe@apple.com>
2328
2329         Reviewed by Sam.
2330
2331         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2332
2333         * Scripts/webkitdirs.pm:
2334         - Change checkArgv to remove the options from @ARGV to prevent
2335         them from interfering with further option processing.
2336         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2337         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2338         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2339         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2340
2341 2007-10-15  Darin Adler  <darin@apple.com>
2342
2343         Reviewed by Sam.
2344
2345         - added logging of window.prompt and window.confirm
2346
2347         * DumpRenderTree/mac/UIDelegate.mm:
2348         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2349         Implement the recommended delegate rather than the deprecated one.
2350         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2351         Added.
2352         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2353         Added.
2354
2355         * DumpRenderTree/win/UIDelegate.h:
2356         * DumpRenderTree/win/UIDelegate.cpp:
2357         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2358         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2359         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2360         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2361
2362 2007-10-15  Alice Liu  <alice.liu@apple.com>
2363
2364         Reviewed by Sam Weinig.
2365
2366         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2367
2368         * DumpRenderTree/win/DumpRenderTree.cpp:
2369         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2370         (main): allocate the global policy delegate for DRT's custom use
2371         * DumpRenderTree/win/DumpRenderTree.vcproj:
2372         Adding files to project
2373         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2374         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2375         (LayoutTestController::setCustomPolicyDelegate):
2376         set the webview's policy delegate to DRT's custom one if the test requests it.
2377         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2378         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2379         (PolicyDelegate::PolicyDelegate):
2380         (PolicyDelegate::QueryInterface):
2381         (PolicyDelegate::AddRef):
2382         (PolicyDelegate::Release):
2383         (PolicyDelegate::decidePolicyForNavigationAction):
2384         * DumpRenderTree/win/PolicyDelegate.h: Added.
2385         (PolicyDelegate::decidePolicyForNewWindowAction):
2386         (PolicyDelegate::decidePolicyForMIMEType):
2387         (PolicyDelegate::unableToImplementPolicyWithError):
2388
2389 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2390
2391         Reviewed by Mark.
2392
2393         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2394         when querying for QMAKE_MKSPECS.
2395
2396 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2397
2398         Reviewed by Adam Roben.
2399         
2400         Fix run-webkit-tests is too greedy calculating platform hierarchy
2401         http://bugs.webkit.org/show_bug.cgi?id=15465
2402         
2403         Fix run-webkit-tests being too greedy in trying to split the platform name up
2404         causing it to try and find tests in every directory above the first "-" in the
2405         path to the LayoutTests
2406
2407         * Scripts/run-webkit-tests:
2408
2409 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2410
2411         Reviewed by Darin.
2412
2413         http://bugs.webkit.org/show_bug.cgi?id=15006
2414         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2415         to reduce code duplication.
2416
2417         * Scripts/build-webkit:
2418         * Scripts/webkitdirs.pm:
2419         buildQMakeProject() renamed to buildQMakeQtProject().
2420         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2421         unused $colorize has been removed.
2422
2423 === Start merge of feature-branch 2007-10-12 ===
2424
2425 2007-10-08  Eric Seidel  <eric@webkit.org>
2426
2427         Reviewed by Mark Rowe.
2428
2429         * Scripts/build-webkit: add --help, remove unused --color
2430
2431 2007-10-07  Eric Seidel  <eric@webkit.org>
2432
2433         Reviewed by darin.
2434
2435         * Drosera/mac/DebuggerDocumentPlatform.mm:
2436         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2437
2438 2007-10-03  Rob Buis  <buis@kde.org>
2439
2440         Reviewed by Olliej.
2441
2442         Adapt to changed location of Ahem font.
2443
2444         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2445
2446 2007-10-02  Eric Seidel  <eric@webkit.org>
2447
2448         Reviewed by Adam Roben.
2449         
2450         Make pixel tests more useful!
2451         Finally fix the image diff 0.00% mystery problem
2452         Highlight any image differences in the image diff.
2453         Add a link from image diffs back to original test file.
2454
2455         * DumpRenderTree/mac/ImageDiff.m:
2456         (compareImages): highlight any differences
2457         (computePercentageDifferent): round to two decimal places
2458         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2459
2460 2007-10-02  Eric Seidel  <eric@webkit.org>
2461
2462         Reviewed by Alexey Proskuryakov.
2463
2464         * Scripts/run-webkit-tests: print the % image difference on main results page
2465
2466 2007-10-02  Mark Rowe  <mrowe@apple.com>
2467
2468         Reviewed by Oliver.
2469
2470         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2471
2472         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2473         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2474
2475 2007-10-01  Mark Rowe  <mrowe@apple.com>
2476
2477         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2478
2479 2007-09-25  Eric Seidel  <eric@webkit.org>
2480
2481         Reviewed by Mark Rowe.
2482         
2483         DerivedSources.make was finding "ENABLE_SVG" in the string
2484         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2485         quite correctly.
2486
2487         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2488
2489 2007-09-25  Mark Rowe  <mrowe@apple.com>
2490
2491         Rubber-stamped by Eric.
2492
2493         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2494         This makes it possible to automate nightly builds for the feature-branch.
2495
2496 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2497
2498         Rubber stamped by Mark.
2499
2500         Enable svg experimental features as default here in feature-branch.
2501
2502         * Scripts/build-webkit:
2503
2504 2007-06-29  Antti Koivisto  <antti@apple.com>
2505
2506         Reviewed by Weinig.
2507         
2508         Add VIDEO flag for timed media features
2509
2510         * Scripts/build-webkit
2511         
2512 === End merge of feature-branch 2007-10-12 ===
2513
2514 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2515
2516         Reviewed by Darin.
2517
2518         - Updated rational for the leaks list to be more clear.
2519
2520         * Scripts/run-webkit-tests:
2521
2522 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2523
2524         Rubber Stamp by Sam.
2525
2526         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2527         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2528
2529         * Scripts/run-webkit-tests:
2530
2531 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2532
2533         Reviewed by Lars.
2534
2535         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2536         includes are needed for INT_MAX, std::auto_ptr and the like.
2537
2538         * DumpRenderTree/qt/main.cpp:
2539
2540 2007-10-09  Lars Knoll  <lars@trolltech.com>
2541
2542         Reviewed by Simon.
2543
2544         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2545
2546         * DumpRenderTree/qt/jsobjects.cpp:
2547         (LayoutTestController::encodeHostName):
2548         (LayoutTestController::decodeHostName):
2549         * DumpRenderTree/qt/jsobjects.h:
2550
2551 2007-10-09  Lars Knoll  <lars@trolltech.com>
2552
2553         Reviewed by Simon.
2554
2555         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2556
2557         * DumpRenderTree/qt/DumpRenderTree.cpp:
2558         (WebCore::WebPage::createFrame):
2559         (WebCore::DumpRenderTree::DumpRenderTree):
2560         (WebCore::DumpRenderTree::titleChanged):
2561         * DumpRenderTree/qt/DumpRenderTree.h:
2562         * DumpRenderTree/qt/jsobjects.cpp:
2563         (LayoutTestController::reset):
2564         * DumpRenderTree/qt/jsobjects.h:
2565
2566 2007-10-09  Lars Knoll  <lars@trolltech.com>
2567
2568         Reviewed by Simon.
2569
2570         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2571
2572         * DumpRenderTree/qt/DumpRenderTree.h:
2573         * DumpRenderTree/qt/jsobjects.cpp:
2574         (LayoutTestController::clearBackForwardList):
2575         * DumpRenderTree/qt/jsobjects.h:
2576
2577 2007-10-09  Lars Knoll  <lars@trolltech.com>
2578
2579         Reviewed by Simon.
2580
2581         make --git-reviewer work again.
2582
2583         * Scripts/prepare-ChangeLog:
2584
2585 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2586
2587         Rubber stamped by Eric.
2588
2589         Connect to the "hovering-over-link" signal emitted by WebKitPage and
2590         show the current link inside the statusbar.
2591         This shows how to make use of this signal and allows to easily test
2592         http://bugs.webkit.org/show_bug.cgi?id=15299.
2593
2594         * GtkLauncher/main.cpp:
2595         (hoveringOverLink):
2596         (main):
2597
2598 2007-10-05  Lars Knoll  <lars@trolltech.com>
2599
2600         add proper error messages to the FrameLoaderClient.
2601         Implement ChromeClientQt::closeWindowSoon and
2602         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2603         Some fixes in DRT to make it work correctly with multiple windows.
2604
2605         Reviewed by Maciej.
2606
2607         * DumpRenderTree/qt/DumpRenderTree.cpp:
2608         (WebCore::DumpRenderTree::DumpRenderTree):
2609         (WebCore::DumpRenderTree::createWindow):
2610         (WebCore::DumpRenderTree::windowCount):
2611         * DumpRenderTree/qt/DumpRenderTree.h:
2612         * DumpRenderTree/qt/jsobjects.cpp:
2613         (LayoutTestController::maybeDump):
2614         (LayoutTestController::windowCount):
2615         * DumpRenderTree/qt/jsobjects.h:
2616
2617 2007-10-05  Lars Knoll  <lars@trolltech.com>
2618
2619         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
2620         Add support for layoutTextController.setCanOpenWindows() to DRT
2621         fixing another 2 test cases in fast/dom/Window.
2622
2623         Reviewed by Maciej.
2624
2625         * DumpRenderTree/qt/DumpRenderTree.cpp:
2626         (WebCore::WebPage::WebPage):
2627         (WebCore::WebPage::createWindow):
2628         (WebCore::DumpRenderTree::resetJSObjects):
2629         (WebCore::DumpRenderTree::createWindow):
2630         * DumpRenderTree/qt/DumpRenderTree.h:
2631         * DumpRenderTree/qt/DumpRenderTree.pro:
2632         * DumpRenderTree/qt/jsobjects.cpp:
2633         (LayoutTestController::LayoutTestController):
2634         (LayoutTestController::reset):
2635         * DumpRenderTree/qt/jsobjects.h:
2636         * DumpRenderTree/qt/main.cpp:
2637         * DumpRenderTree/qt/testplugin.cpp: Added.
2638         * DumpRenderTree/qt/testplugin.h: Added.
2639
2640 2007-10-04  Sam Weinig  <sam@webkit.org>
2641
2642         Rubber stamped by Adam.
2643
2644         Remove empty directories.
2645
2646         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2647         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2648
2649 2007-10-03  Darin Adler  <darin@apple.com>
2650
2651         Reviewed by Adam.
2652
2653         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2654         we find the internal libraries in the libraries directory. This
2655         is helpful for Safari team engineers at Apple.
2656
2657 2007-10-03  Adam Roben  <aroben@apple.com>
2658
2659         Update the location of AHEM___.TTF after r25968
2660
2661         Reviewed by Sam.
2662
2663         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2664
2665 2007-10-03  Alp Toker  <alp@atoker.com>
2666
2667         Reviewed by Adam.
2668
2669         http://bugs.webkit.org/show_bug.cgi?id=14726
2670         [gtk] API design. Mapping the WebView delegates to signals.
2671
2672         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2673
2674         * GtkLauncher/main.cpp:
2675         (goToURLBarText):
2676         (titleChanged):
2677         (progressChanged):
2678         (menuMainBackCallback):
2679         (menuMainForwardCallback):
2680         (main):
2681
2682 2007-10-03  Lars Knoll  <lars@trolltech.com>
2683
2684         Reviewed by Rob.
2685
2686         This fixes --strict mode in run-webkit-tests again after
2687         the platform dependent test results have been moved.
2688
2689         * Scripts/run-webkit-tests:
2690
2691 2007-10-03  Lars Knoll  <lars@trolltech.com>
2692
2693         Reviewed by bdash.
2694
2695         remove the hack in run-webkit-tests that forced text only test
2696         to be taken from the platform independent dir. It was only left
2697         there from early days.
2698         
2699         Remove platform dependent results for tests that are text only nowadays,
2700         and add one platform dependent result for a text only test that requires it.
2701
2702         * Scripts/run-webkit-tests:
2703
2704 2007-10-03  Lars Knoll  <lars@trolltech.com>
2705
2706         Reviewed by olliej.
2707
2708         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2709
2710         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2711         (WebCore::WebFrame::WebFrame):
2712         (WebCore::WebPage::WebPage):
2713         (WebCore::WebPage::createFrame):
2714         (WebCore::WebPage::javaScriptAlert):
2715         (WebCore::WebPage::javaScriptConsoleMessage):
2716         (WebCore::DumpRenderTree::DumpRenderTree):
2717         (WebCore::DumpRenderTree::~DumpRenderTree):
2718         (WebCore::DumpRenderTree::open):
2719         (WebCore::DumpRenderTree::readStdin):
2720         (WebCore::DumpRenderTree::resetJSObjects):
2721         (WebCore::DumpRenderTree::initJSObjects):
2722         (WebCore::DumpRenderTree::dumpFramesAsText):
2723         (WebCore::DumpRenderTree::dump):
2724         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2725         (WebCore::DumpRenderTree::layoutTestController):
2726         (WebCore::DumpRenderTree::eventSender):
2727         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2728         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2729         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2730         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2731         (HackWebFrame::mousePressEvent):
2732         (HackWebFrame::mouseReleaseEvent):
2733         (HackWebFrame::mouseMoveEvent):
2734         (HackWebFrame::HackWebFrame):
2735         (HackWebFrame::~HackWebFrame):
2736         (LayoutTestController::LayoutTestController):
2737         (LayoutTestController::reset):
2738         (LayoutTestController::maybeDump):
2739         (LayoutTestController::waitUntilDone):
2740         (LayoutTestController::notifyDone):
2741         (LayoutTestController::dumpEditingCallbacks):
2742         (LayoutTestController::queueReload):
2743         (LayoutTestController::provisionalLoad):
2744         (LayoutTestController::timerEvent):
2745         (EventSender::EventSender):
2746         (EventSender::mouseDown):
2747         (EventSender::mouseUp):
2748         (EventSender::mouseMoveTo):
2749         (EventSender::leapForward):
2750         (EventSender::keyDown):
2751         (EventSender::frameUnderMouse):
2752         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2753         (LayoutTestController::isLoading):
2754         (LayoutTestController::setLoading):
2755         (LayoutTestController::shouldDumpAsText):
2756         (LayoutTestController::shouldDumpChildrenAsText):
2757         (LayoutTestController::shouldWaitUntilDone):
2758         (LayoutTestController::dumpAsText):
2759         (LayoutTestController::dumpChildFramesAsText):
2760         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2761         (messageHandler):
2762         (crashHandler):
2763         (main):
2764         * Scripts/run-webkit-tests:
2765
2766 2007-10-03  Mark Rowe  <mrowe@apple.com>
2767
2768         Reviewed by Alp Toker.
2769
2770         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2771         should take precedence over QTDIR when determining which port we are working with.
2772
2773         * Scripts/webkitdirs.pm: 
2774
2775 2007-10-02  Adam Roben  <aroben@apple.com>
2776
2777         Add keychain to the list of default packages to install
2778
2779         Rubberstamped by Sam.
2780
2781         * CygwinDownloader/cygwin-downloader.py:
2782         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2783
2784 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2785
2786         Reviewed by Adam.
2787
2788         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2789         Also makes WebCore regression test case logic work when using git.
2790
2791         * Scripts/prepare-ChangeLog:
2792         (reviewerAndDescriptionForGitCommit): Added.
2793
2794 2007-10-02  Lars Knoll  <lars@trolltech.com>
2795
2796         Reviewed by bdash.
2797
2798         Add API to retrieve the frame name from QWebFrame.
2799         Implement support for DRT::dumpChildrenAsText.
2800
2801         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2802         (WebCore::DumpRenderTree::dumpFramesAsText):
2803         (WebCore::DumpRenderTree::dump):
2804         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2805         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2806         (LayoutTestController::LayoutTestController):
2807         (LayoutTestController::reset):
2808         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2809
2810 2007-10-02  Lars Knoll  <lars@trolltech.com>
2811
2812         Reviewed by bdash.
2813
2814         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2815
2816         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2817         (WebCore::DumpRenderTree::readStdin):
2818
2819 2007-10-02  Mark Rowe  <mrowe@apple.com>
2820
2821         Reviewed by Oliver.
2822
2823         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2824
2825         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2826         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2827
2828 2007-10-02  Mark Rowe  <mrowe@apple.com>
2829
2830         Rubber-stamped by Maciej.
2831
2832         Configuration changes from build.webkit.org.  The major change is refactoring to work
2833         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2834         last few weeks.
2835
2836         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2837         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2838         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2839         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2840         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2841         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2842         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2843         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2844
2845 2007-10-02  Lars Knoll  <lars@trolltech.com>
2846
2847         Reviewed by Maciej.
2848
2849         Add support for eventSender.mouseMove to DRT.
2850         Fixes fast/css/hover-affects-child.html
2851
2852         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2853         (EventSender::mouseMoveTo):
2854
2855 2007-10-01  Mark Rowe  <mrowe@apple.com>
2856
2857         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2858
2859 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
2860
2861         Reviewed by Hyatt.
2862
2863         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
2864
2865         * Scripts/svn-apply:
2866         (gitdiff2svndiff): Ignore lines beginning with "new file".
2867         * Scripts/svn-unapply:
2868         (gitdiff2svndiff): Ditto.
2869
2870 2007-09-30  George Staikos  <staikos@kde.org>
2871
2872         Qt build fix (Mac OS X specific)
2873
2874         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2875
2876 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2877
2878         Reviewed by Mark.
2879
2880         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
2881         Remove Bakefiles from svn.
2882
2883         * GtkLauncher/Bakefiles.bkgen: Removed.
2884         * GtkLauncher/ENV: Removed.
2885         * GtkLauncher/gdklauncher.bkl: Removed.
2886         * GtkLauncher/mk: Removed.
2887         * Scripts/regenerate-makefiles: Removed.
2888
2889 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
2890
2891         Reviewed by John.
2892
2893         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
2894
2895         * Scripts/run-webkit-tests:
2896
2897 2007-09-26  Adam Roben  <aroben@apple.com>
2898
2899         Make not finding an installed WebKit non-fatal
2900
2901         What really matters is that we are able to load WebKit and its
2902         dependencies, not whether we think we've found an installed WebKit.
2903
2904         Reviewed by Sam.
2905
2906         * WebKitInitializer/WebKitInitializer.cpp:
2907         (getWebViewCLSID): Use new LOG_WARNING macro.
2908         (getInstalledWebKitDirectory): Ditto.
2909         (initializeWebKit): Don't die if we didn't find an installed WebKit,
2910         and use new macros.
2911         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
2912
2913 2007-09-26  Adam Roben  <aroben@apple.com>
2914
2915         Committed this file before saving it
2916
2917         * WebKitInitializer/debug_internal.vsprops:
2918
2919 2007-09-26  Adam Roben  <aroben@apple.com>
2920
2921         Load WebKit and its dependencies manually so they come from DllDirectory
2922
2923         I had to change WebKitInitializer to use malloc/free instead of
2924         new/delete to avoid pulling in WebKit (and its dependencies) early
2925         through use of fastMalloc.
2926
2927         Reviewed by Oliver.
2928
2929         * WebKitInitializer/WebKitInitializer.cpp:
2930         (getStringValue): Changed to use malloc/free.
2931         (getInstalledWebKitDirectory): Ditto.
2932         (initializeWebKit): Call SetDllDirectory first, then load all of
2933         WebKit's dependencies manually, finally followed by WebKit itself.
2934         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
2935         configuration to match our other projects.
2936         * WebKitInitializer/debug_internal.vsprops: Added.
2937
2938 2007-09-25  Adam Roben  <aroben@apple.com>
2939
2940         Actually define DEBUG/NDEBUG so that we load WebKit correctly
2941
2942         Rubberstamped by Sam.
2943
2944         * WebKitInitializer/WebKitInitializer.vcproj:
2945
2946 2007-09-25  Adam Roben  <aroben@apple.com>
2947
2948         Make DumpRenderTree delay-load its dependencies
2949
2950         This lets WebKitInitializer re-route the dependencies to be loaded out
2951         of the Safari installation directory.
2952
2953         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
2954         same thing), since we can't import the kCFAllocatorDefault symbol when
2955         delay-loading CoreFoundation.dll.
2956
2957         Rubberstamped by Sam.
2958
2959         * DumpRenderTree/win/DumpRenderTree.cpp:
2960         (runTest):
2961         (javaScriptThreads):
2962         * DumpRenderTree/win/DumpRenderTree.vcproj:
2963         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2964         (LayoutTestController::setWaitToDump):
2965
2966 2007-09-25  Adam Roben  <aroben@apple.com>
2967
2968         Pull ole32.lib into WebKitInitializer
2969
2970         Rubberstamped by Sam.
2971
2972         * WebKitInitializer/WebKitInitializer.vcproj:
2973
2974 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2975
2976         Reviewed by Adam.
2977
2978         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
2979           LGPL'ed files contain incorrect FSF address
2980
2981         * Drosera/config.h:
2982
2983 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2984
2985         Reviewed by Adam.
2986
2987         Make svn-apply and svn-unapply work with git-diff formatted patches.
2988
2989         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
2990         (gitdiff2svndiff): Added.
2991         * Scripts/svn-unapply: Ditto.
2992         (gitdiff2svndiff): Added.
2993
2994 2007-09-25  Adam Roben  <aroben@apple.com>
2995
2996         Pull advapi32.lib into WebKitInitializer
2997
2998         This is needed to get the registry functions we use.
2999
3000         Rubberstamped by Sam.
3001
3002         * WebKitInitializer/WebKitInitializer.vcproj:
3003
3004 2007-09-25  Adam Roben  <aroben@apple.com>
3005
3006         Add python and rsync to cygwin-downloader
3007
3008         Our build slaves need this, and it can't hurt for everyone else to
3009         have it, too.
3010
3011         Reviewed by Sam.
3012
3013         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3014         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3015
3016 2007-09-25  Adam Roben  <aroben@apple.com>
3017
3018         Add WebKitInitializer and use it in DumpRenderTree
3019
3020         WebKitInitializer is a static library that has one function,
3021         initializeWebKit(). This registers WebKit and sets up the DLL search
3022         path so that WebKit's dependencies that are installed with Safari can
3023         be found.
3024
3025         Reviewed by Sam.
3026
3027         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3028         DumpRenderTree depend on it.
3029         * DumpRenderTree/win/DumpRenderTree.cpp:
3030         (initialize): Call initializeWebKit.
3031         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
3032         WebKitInitializer.lib.
3033         * WebKitInitializer/WebKitInitializer.cpp: Added.
3034         (getStringValue):
3035         (getWebViewCLSID):
3036         (getInstalledWebKitDirectory):
3037         (initializeWebKit):
3038         * WebKitInitializer/WebKitInitializer.h: Added.
3039         * WebKitInitializer/WebKitInitializer.vcproj: Added.
3040         * WebKitInitializer/debug.vsprops: Added.
3041         * WebKitInitializer/release.vsprops: Added.
3042
3043 2007-09-25  Adam Roben  <aroben@apple.com>
3044
3045         Make run-webkit-tests respect set-webkit-configuration
3046
3047         Reviewed by Sam.
3048
3049         * Scripts/run-webkit-tests: Initialize $configuration to whatever
3050         set-webkit-configuration was last set to.
3051
3052 2007-09-25  Mark Rowe  <mrowe@apple.com>
3053
3054         Rubber-stamped by Eric.
3055
3056         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3057         This makes it possible to automate nightly builds for the feature-branch.
3058
3059 2007-09-25  Adam Roben  <aroben@apple.com>
3060
3061         A couple of fixes/enhancements to update-webkit-*-libs
3062
3063         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
3064         to tell update-webkit-support-libraries where it should find the
3065         WebKitSupportLibrary.zip file you downloaded.
3066
3067         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
3068         Windows-style path.
3069
3070         Reviewed by Sam.
3071
3072         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
3073         to $auxiliaryLibsURL and removed an irrelevant comment.
3074         * Scripts/update-webkit-support-libs:
3075
3076 2007-09-25  Adam Treat  <treat@kde.org>
3077
3078         Reviewed by Simon and Lars.
3079
3080         Refactors and cleans up Qt DRT member variable names, member variable
3081         initialization, style fixes and general code cleanup.
3082
3083         Adds queueReload slot to LayoutTestController that some tests require.
3084
3085         Subclasses QWebFrame to make sure that all frames have an associated
3086         LayoutTestController JS window object.
3087
3088         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
3089         aren't dumped twice.
3090
3091         EOF fixes.
3092
3093         Together, this patch fixes some 20+ layout tests in QtWebKit.
3094
3095         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3096         (WebCore::WebFrame::WebFrame):
3097         (WebCore::WebPage::WebPage):
3098         (WebCore::WebPage::createFrame):
3099         (WebCore::DumpRenderTree::DumpRenderTree):
3100         (WebCore::DumpRenderTree::open):
3101         (WebCore::DumpRenderTree::readStdin):
3102         (WebCore::DumpRenderTree::initJSObjects):
3103         (WebCore::DumpRenderTree::dump):
3104         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3105         (WebCore::DumpRenderTree::layoutTestController):
3106         (WebCore::DumpRenderTree::eventSender):
3107         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3108         (LayoutTestController::LayoutTestController):
3109         (LayoutTestController::reset):
3110         (LayoutTestController::maybeDump):
3111         (LayoutTestController::waitUntilDone):
3112         (LayoutTestController::notifyDone):
3113         (LayoutTestController::queueReload):
3114         (LayoutTestController::provisionalLoad):
3115         (EventSender::EventSender):
3116         (EventSender::mouseDown):
3117         (EventSender::mouseUp):
3118         (EventSender::mouseMoveTo):
3119         (EventSender::frameUnderMouse):
3120         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3121         (LayoutTestController::isLoading):
3122         (LayoutTestController::setLoading):
3123         (LayoutTestController::dumpAsText):
3124         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3125         (main):
3126
3127 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3128
3129
3130         - Reverted an accidentally checked in file.
3131
3132         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3133
3134 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3135         Reviewed by Sam.
3136
3137         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
3138
3139         * DumpRenderTree/win/DumpRenderTree.vcproj:
3140         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3141
3142 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3143
3144         Rubber stamped by Adam.
3145
3146         * GdkLauncher: Removed.
3147         * GdkLauncher/Bakefiles.bkgen: Removed.
3148         * GdkLauncher/ENV: Removed.
3149         * GdkLauncher/GdkLauncher.pro: Removed.
3150         * GdkLauncher/gdklauncher.bkl: Removed.
3151         * GdkLauncher/main.cpp: Removed.
3152         * GdkLauncher/mk: Removed.
3153         * GdkLauncher/simple.svg: Removed.
3154         * GdkLauncher/text.html: Removed.
3155         * GtkLauncher: Added.
3156         * GtkLauncher/GdkLauncher.pro: Removed.
3157         * GtkLauncher/GtkLauncher.pro: Added.
3158         * GtkLauncher/main.cpp:
3159         (updateWindowTitle):
3160         (main):
3161         * Scripts/build-webkit:
3162         * Scripts/regenerate-makefiles:
3163         * Scripts/run-javascriptcore-tests:
3164         * Scripts/run-launcher:
3165         * Scripts/run-webkit-tests:
3166         * Scripts/webkitdirs.pm:
3167
3168 2007-09-21  Timothy Hatcher  <timothy@apple.com>
3169
3170         Reviewed by Darin.
3171
3172         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3173
3174         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
3175         This is tested by plugins/root-object-premature-delete-crash.html.
3176
3177         * DumpRenderTree/mac/ObjCController.m:
3178         (-[ObjCController accessStoredWebScriptObject]):
3179
3180 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
3181
3182         Reviewed by Oliver.
3183
3184         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
3185
3186         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3187         (FrameLoadDelegate::FrameLoadDelegate):
3188
3189 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
3190
3191         Reviewed by Adam.
3192
3193         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
3194         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
3195
3196         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
3197         Now isQt() and isGdk() use global variables that are only set once.
3198
3199         An array of all the parameters is now given to build-dumprender which includes
3200         the platform on linux.
3201
3202         * Scripts/build-dumprendertree:
3203         * Scripts/run-webkit-tests:
3204         * Scripts/webkitdirs.pm:
3205
3206 2007-09-19  Adam Roben  <aroben@apple.com>
3207
3208         Rubberstamped by Hyatt.
3209
3210         * Spinneret: Removed.
3211
3212 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
3213
3214         Reviewed by David Kilzer.
3215
3216         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
3217
3218 2007-09-18  Sam Weinig  <sam@webkit.org>
3219
3220         Add JSRetainPtr.h #include to fix some builds.
3221
3222         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3223
3224 2007-09-18  Mike Hommey  <glandium@debian.org>
3225
3226         Reviewed by Adam.
3227
3228         * Scripts/prepare-ChangeLog:
3229         - Properly parse GECOS field.
3230         - Use git configuration for user name and email when appropriate.
3231
3232 2007-09-17  Sam Weinig  <sam@webkit.org>
3233
3234         Build fix.
3235
3236         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3237
3238 2007-09-17  Sam Weinig  <sam@webkit.org>
3239
3240         Reviewed by Adam Roben.
3241
3242         Share more code between mac and windows DRT.
3243             - GCController is now shared.
3244             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
3245
3246         * DumpRenderTree/GCController.cpp:
3247         * DumpRenderTree/win/DumpRenderTree.cpp:
3248         * DumpRenderTree/win/DumpRenderTree.vcproj:
3249         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
3250         (FrameLoadDelegate::FrameLoadDelegate):
3251         (FrameLoadDelegate::~FrameLoadDelegate):
3252         (FrameLoadDelegate::windowScriptObjectAvailable):
3253         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
3254         * DumpRenderTree/win/GCController.cpp: Removed.
3255         * DumpRenderTree/win/GCController.h: Removed.
3256         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
3257         (GCController::collect):
3258         (GCController::collectOnAlternateThread):
3259         (GCController::getJSObjectCount):
3260         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
3261         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
3262
3263 2007-09-17  Sam Weinig  <sam@webkit.org>
3264
3265         Reviewed by Adam Roben.
3266
3267         Begin sharing code between mac and windows DRT.
3268             - both now share LayoutTestController.h/cpp and implement platform dependant 
3269               operations in LayoutTestControllerMac/Win.
3270             - DumpRenderTree.h is now shared.
3271             - WorkQueue and WorkQueueItem are also shared.
3272
3273         * DumpRenderTree/DumpRenderTree.h:
3274         * DumpRenderTree/LayoutTestController.cpp:
3275         * DumpRenderTree/win/DumpRenderTree.cpp:
3276         (displayWebView):
3277         (dumpFrameScrollPosition):
3278         (dumpFramesAsText):
3279         (dump):
3280         (runTest):
3281         * DumpRenderTree/win/DumpRenderTree.h: Removed.
3282         * DumpRenderTree/win/DumpRenderTree.vcproj:
3283         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
3284         * DumpRenderTree/win/EditingDelegate.cpp:
3285         (EditingDelegate::shouldBeginEditingInDOMRange):
3286         (EditingDelegate::shouldEndEditingInDOMRange):
3287         (EditingDelegate::shouldInsertNode):
3288         (EditingDelegate::shouldInsertText):
3289         (EditingDelegate::shouldDeleteDOMRange):
3290         (EditingDelegate::shouldChangeSelectedDOMRange):
3291         (EditingDelegate::shouldApplyStyle):
3292         (EditingDelegate::shouldChangeTypingStyle):
3293         (EditingDelegate::doPlatformCommand):
3294         (EditingDelegate::webViewDidBeginEditing):
3295         (EditingDelegate::webViewDidChange):
3296         (EditingDelegate::webViewDidEndEditing):
3297         (EditingDelegate::webViewDidChangeTypingStyle):
3298         (EditingDelegate::webViewDidChangeSelection):
3299         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
3300         * DumpRenderTree/win/LayoutTestController.h: Removed.
3301         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
3302         (LayoutTestController::addDisallowedURL):
3303         (LayoutTestController::clearBackForwardList):
3304         (LayoutTestController::copyDecodedHostName):
3305         (LayoutTestController::copyEncodedHostName):
3306         (LayoutTestController::display):
3307         (LayoutTestController::keepWebHistory):
3308         (LayoutTestController::notifyDone):
3309         (LayoutTestController::queueBackNavigation):
3310         (LayoutTestController::queueForwardNavigation):
3311         (jsStringRefToWString):
3312         (LayoutTestController::queueLoad):
3313         (LayoutTestController::queueReload):
3314         (LayoutTestController::queueScript):
3315         (LayoutTestController::setAcceptsEditing):
3316         (LayoutTestController::setCustomPolicyDelegate):
3317         (LayoutTestController::setMainFrameIsFirstResponder):
3318         (LayoutTestController::setTabKeyCyclesThroughElements):
3319         (LayoutTestController::setUseDashboardCompatibilityMode):
3320         (LayoutTestController::setUserStyleSheetEnabled):
3321         (LayoutTestController::setUserStyleSheetLocation):
3322         (LayoutTestController::setWindowIsKey):
3323         (waitUntilDoneWatchdogFired):
3324         (LayoutTestController::setWaitToDump):
3325         (LayoutTestController::windowCount):
3326         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
3327         (FrameLoadDelegate::didReceiveTitle):
3328         (FrameLoadDelegate::processWork):
3329         (FrameLoadDelegate::locationChangeDone):
3330         (FrameLoadDelegate::windowScriptObjectAvailable):
3331         * DumpRenderTree/win/WorkQueue.cpp: Removed.
3332         * DumpRenderTree/win/WorkQueue.h: Removed.
3333         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
3334         * DumpRenderTree/win/WorkQueueItem.h: Removed.
3335         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
3336         (jsStringRefToWString):
3337         (LoadItem::invoke):
3338         (ScriptItem::invoke):
3339
3340 2007-09-17  Sam Weinig  <sam@webkit.org>
3341
3342         Reviewed by Adam Roben.
3343
3344         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
3345
3346         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
3347         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
3348         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
3349         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
3350         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
3351         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
3352         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
3353         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
3354         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
3355         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
3356         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
3357         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
3358         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
3359         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
3360         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
3361         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
3362         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
3363         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
3364         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
3365         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
3366         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
3367         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
3368         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
3369         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
3370         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
3371         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
3372         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
3373         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
3374         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
3375         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
3376         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
3377         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
3378         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
3379         * DumpRenderTree/win: Added.
3380         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
3381         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
3382         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
3383         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
3384         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
3385         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
3386         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
3387         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
3388         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
3389         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
3390         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
3391         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
3392         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
3393         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3394         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
3395         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
3396         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
3397         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
3398         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3399         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3400         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
3401         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3402         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
3403         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
3404         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
3405         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
3406
3407 2007-09-15  Mark Rowe  <mrowe@apple.com>
3408
3409         Build fix for DumpRenderTree.
3410
3411         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
3412
3413 2007-09-14  Sam Weinig  <sam@webkit.org>
3414
3415         Rubber stamped by Adam Roben.
3416
3417         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
3418           - The UIDelegate was put into a new file while the FrameLoadDelegate was
3419             kept in the WaitUntilDoneDelegate file for the time being.
3420
3421         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3422         (main):
3423         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
3424         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
3425         (UIDelegate::QueryInterface):
3426         (UIDelegate::AddRef):
3427         (UIDelegate::Release):
3428         (UIDelegate::hasCustomMenuImplementation):
3429         (UIDelegate::setFrame):
3430         (UIDelegate::webViewFrame):
3431         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3432         (UIDelegate::webViewAddMessageToConsole):
3433         (UIDelegate::doDragDrop):
3434         (UIDelegate::webViewGetDlgCode):
3435         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
3436         (UIDelegate::UIDelegate):
3437         (UIDelegate::createWebViewWithRequest):
3438         (UIDelegate::webViewShow):
3439         (UIDelegate::webViewClose):
3440         (UIDelegate::webViewFocus):
3441         (UIDelegate::webViewUnfocus):
3442         (UIDelegate::webViewFirstResponder):
3443         (UIDelegate::makeFirstResponder):
3444         (UIDelegate::setStatusText):
3445         (UIDelegate::webViewStatusText):
3446         (UIDelegate::webViewAreToolbarsVisible):
3447         (UIDelegate::setToolbarsVisible):
3448         (UIDelegate::webViewIsStatusBarVisible):
3449         (UIDelegate::setStatusBarVisible):
3450         (UIDelegate::webViewIsResizable):
3451         (UIDelegate::setResizable):
3452         (UIDelegate::setContentRect):
3453         (UIDelegate::webViewContentRect):
3454         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3455         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3456         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3457         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
3458         (UIDelegate::mouseDidMoveOverElement):
3459         (UIDelegate::contextMenuItemsForElement):
3460         (UIDelegate::validateUserInterfaceItem):
3461         (UIDelegate::shouldPerformAction):
3462         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
3463         (UIDelegate::willPerformDragDestinationAction):
3464         (UIDelegate::dragSourceActionMaskForPoint):
3465         (UIDelegate::willPerformDragSourceAction):
3466         (UIDelegate::contextMenuItemSelected):
3467         (UIDelegate::trackCustomPopupMenu):
3468         (UIDelegate::measureCustomMenuItem):
3469         (UIDelegate::drawCustomMenuItem):
3470         (UIDelegate::addCustomMenuDrawingData):
3471         (UIDelegate::cleanUpCustomMenuDrawingData):
3472         (UIDelegate::canTakeFocus):
3473         (UIDelegate::takeFocus):
3474         (UIDelegate::registerUndoWithTarget):
3475         (UIDelegate::removeAllActionsWithTarget):
3476         (UIDelegate::setActionTitle):
3477         (UIDelegate::undo):
3478         (UIDelegate::redo):
3479         (UIDelegate::canUndo):
3480         (UIDelegate::canRedo):
3481         (UIDelegate::webViewResizerRect):
3482         (UIDelegate::webViewDrawResizer):
3483         (UIDelegate::webViewScrolled):
3484         (UIDelegate::webViewShouldInterruptJavaScript):
3485         (UIDelegate::webViewReceivedFocus):
3486         (UIDelegate::webViewLostFocus):
3487         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
3488         (FrameLoadDelegate::QueryInterface):
3489         (FrameLoadDelegate::AddRef):
3490         (FrameLoadDelegate::Release):
3491         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3492         (FrameLoadDelegate::didCommitLoadForFrame):
3493         (FrameLoadDelegate::didReceiveTitle):
3494         (FrameLoadDelegate::processWork):
3495         (processWorkTimer):
3496         (FrameLoadDelegate::locationChangeDone):
3497         (FrameLoadDelegate::didFinishLoadForFrame):
3498         (FrameLoadDelegate::didFailLoadWithError):
3499         (FrameLoadDelegate::windowScriptObjectAvailable):
3500         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
3501         (FrameLoadDelegate::FrameLoadDelegate):
3502
3503 2007-09-14  Sam Weinig  <sam@webkit.org>
3504
3505         Reviewed by Kevin McCullough.
3506
3507         Move mac specific globals in to mac/DumpRenderTreeMac.h
3508
3509         * DumpRenderTree/DumpRenderTree.h:
3510         * DumpRenderTree/DumpRenderTree.mm: Removed.
3511         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3512         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
3513         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
3514
3515 2007-09-14  Brady Eidson  <beidson@apple.com>
3516
3517         Rubberstamped by Weinig
3518
3519         You know, Sam, some of us use case-sensitve filesystems...
3520
3521         * DumpRenderTree/DumpRenderTree.h:
3522         * DumpRenderTree/mac/UIDelegate.mm:
3523
3524 2007-09-14  Sam Weinig  <sam@webkit.org>
3525
3526         Rubber stamped by Adam Roben.
3527
3528         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
3529         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
3530
3531         * DumpRenderTree/AppleScriptController.h: Removed.
3532         * DumpRenderTree/AppleScriptController.m: Removed.
3533         * DumpRenderTree/DumpRenderTree.h:
3534         * DumpRenderTree/DumpRenderTree.mm:
3535         (startJavaScriptThreads):
3536         (stopJavaScriptThreads):
3537         (activateAhemFont):
3538         (setDefaultColorProfileToRGB):
3539         (makeLargeMallocFailSilently):
3540         (dumpFrameScrollPosition):
3541         (dumpFramesAsText):
3542         (dump):
3543         (runTest):
3544         (-[DumpRenderTreeWindow isKeyWindow]):
3545         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3546         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
3547         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
3548         * DumpRenderTree/EditingDelegate.h: Removed.
3549         * DumpRenderTree/EditingDelegate.m: Removed.
3550         * DumpRenderTree/EventSendingController.h: Removed.
3551         * DumpRenderTree/EventSendingController.m: Removed.
3552         * DumpRenderTree/FrameLoadDelegate.h: Removed.
3553         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
3554         * DumpRenderTree/GCController.mm: Removed.
3555         * DumpRenderTree/ImageDiff.m: Removed.
3556         * DumpRenderTree/LayoutTestController.cpp:
3557         (LayoutTestController::LayoutTestController):
3558         (dumpAsTextCallback):
3559         (dumpBackForwardListCallback):
3560         (dumpChildFramesAsTextCallback):
3561         (dumpChildFrameScrollPositionsCallback):
3562         (dumpDOMAsWebArchiveCallback):
3563         (dumpEditingCallbacksCallback):
3564         (dumpFrameLoadCallbacksCallback):
3565         (dumpResourceLoadCallbacksCallback):
3566         (dumpSelectionRectCallback):
3567         (dumpSourceAsWebArchiveCallback):
3568         (dumpTitleChangesCallback):
3569         (repaintSweepHorizontallyCallback):
3570         (setCallCloseOnWebViewsCallback):
3571         (setCanOpenWindowsCallback):
3572         (setCloseRemainingWindowsWhenCompleteCallback):
3573         (testRepaintCallback):
3574         (addFileToPasteboardOnDragCallback):
3575         (waitUntilDoneCallback):
3576         * DumpRenderTree/LayoutTestController.h:
3577         (LayoutTestController::dumpAsText):
3578         (LayoutTestController::setDumpAsText):
3579         (LayoutTestController::dumpBackForwardList):