a0f705dfcdfe669dbf59182323a0f7cfc8b62b78
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-12-01  Adam Roben  <aroben@apple.com>
2
3         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
4
5         Reviewed by Ada Chan.
6
7         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
8         TestNetscapePlugin fail in Debug_Internal builds
9
10         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
11         directory in Debug and Debug_All builds, but not in Debug_Internal
12         builds.
13
14 2009-12-01  Adam Roben  <aroben@apple.com>
15
16         Re-enable DRT's watchdog timer on Windows
17
18         It was accidentally disabled in r50907.
19
20         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
21         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
22         into an if condition.
23
24 2009-12-01  Adam Barth  <abarth@webkit.org>
25
26         Reviewed by Eric Seidel.
27
28         check-webkit-style complains about #imports with / in them
29         https://bugs.webkit.org/show_bug.cgi?id=32022
30
31         We need to exclude #import directives in addition to #include from the
32         binary operator whitespace checks.
33
34         * Scripts/modules/cpp_style.py:
35         * Scripts/modules/cpp_style_unittest.py:
36
37 2009-11-30  Adam Barth  <abarth@webkit.org>
38
39         Reviewed by Eric Seidel.
40
41         check-webkit-style is slightly too verbose
42         https://bugs.webkit.org/show_bug.cgi?id=32010
43
44         check-webkit-style prints out a bunch of "done" lines that seem redundant,
45         especially for the style-queue.
46
47         * Scripts/modules/cpp_style.py:
48
49 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
50
51         Reviewed by Eric Seidel.
52
53         [GTK] Moved the functions that are closing the result log of the
54         tests to the last line of the runTest function, this avoids
55         reporting crashes in the wrong test if there is a problem when
56         reseting the state after the test.
57
58         * DumpRenderTree/gtk/DumpRenderTree.cpp:
59         (dump):
60         (runTest):
61
62 2009-11-30  Sam Weinig  <sam@webkit.org>
63
64         Reviewed by Geoffrey Garen.
65
66         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
67         fast/js/date-proto-generic-invocation breaks another test
68
69         Don't cache JSClassRefs, a change to the prototype chain will
70         last between tests.
71
72         * DumpRenderTree/AccessibilityController.cpp:
73         (AccessibilityController::getJSClass):
74         * DumpRenderTree/GCController.cpp:
75         (GCController::getJSClass):
76         * DumpRenderTree/GCController.h:
77         * DumpRenderTree/LayoutTestController.cpp:
78         (LayoutTestController::getJSClass):
79
80 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
81
82         Reviewed by Alexey Proskuryakov.
83
84         Update pywebsocket to 0.4.2.1.
85         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
86         https://bugs.webkit.org/show_bug.cgi?id=31976
87
88         * pywebsocket/mod_pywebsocket/standalone.py:
89         * pywebsocket/setup.py:
90
91 2009-11-30  Adam Barth  <abarth@webkit.org>
92
93         Reviewed by Eric Seidel.
94
95         [bzt] Generate pass messages for style-queue
96         https://bugs.webkit.org/show_bug.cgi?id=31995
97
98         With this change, the style-queue posts "pass" messages to bugs as
99         well.  Also, added more information to the state store w.r.t. passing
100         and failing.
101
102         * Scripts/modules/commands/queues.py:
103         * Scripts/modules/patchcollection.py:
104
105 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
106
107         Reviewed by Simon Fraser.
108
109         Check for WEBKIT_TESTFONTS environment variable in
110         run-webkit-tests, for GTK+, to have a more prominent error
111         message.
112
113         * Scripts/run-webkit-tests:
114
115 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
116
117         Reviewed by Dimitri Glazkov.
118
119         update-webkit --chromium forces gclient sync
120
121         https://bugs.webkit.org/show_bug.cgi?id=31967
122
123         * Scripts/update-webkit-chromium:
124
125 2009-11-29  Eric Seidel  <eric@webkit.org>
126
127         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
128
129         * Scripts/modules/committers.py:
130
131 2009-11-29  Eric Seidel  <eric@webkit.org>
132
133         No review, just adding missing svn property.
134
135         Set svn:executable property on new scripts.
136         These were added by commit-queue commits, but the executable
137         property was lost due to a bug in svn-apply:
138         https://bugs.webkit.org/show_bug.cgi?id=27204
139
140         * Scripts/update-webkit-chromium: Added property svn:executable.
141         * Scripts/validate-committer-lists: Added property svn:executable.
142
143 2009-11-29  Eric Seidel  <eric@webkit.org>
144
145         Reviewed by Adam Barth.
146
147         Need a way to validate that committers.py includes all committers/reviewers
148         https://bugs.webkit.org/show_bug.cgi?id=30970
149
150         Add a script which knows how to compare our public committer/reviewer
151         lists and show discrepancies between them.
152
153         Validates mailing lists vs. committers.py:
154         - committers.py committers missing from webkit-committers@lists
155         - webkit-committers@lists members missing from committers.py
156         - committers.py reviewers missing from webkit-reviewers@lists
157         - webkit-reviewers@lists members missing from committers.py
158         - webkit-reviewers@lists members missing from committers.py reviewer list
159
160         Validates committers.py vs. trunk/ SVN history:
161         - committers who have not committed in over a year
162         - SVN committers missing from committers.py
163         - committers.py members who have no record in SVN.
164
165         All of these lists still show "false positives" until a few more committers.py updates are made, like:
166         https://bugs.webkit.org/show_bug.cgi?id=31366
167
168         * Scripts/validate-committer-lists: Added.
169
170 2009-11-28  Adam Barth  <abarth@webkit.org>
171
172         Reviewed by Eric Seidel.
173
174         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
175         https://bugs.webkit.org/show_bug.cgi?id=31950
176
177         Now we cache the last status that we get back from QueueStatusServer.
178         Eventually we'll have to do something more fancy if we want to support
179         a "try again" button on QueueStatusServer, but we can cross that bridge
180         when we come to it.
181
182         * Scripts/modules/patchcollection.py:
183
184 2009-11-28  Adam Barth  <abarth@webkit.org>
185
186         Reviewed by Eric Seidel.
187
188         StyleQueue scans ~100 bug pages every 5 minutes
189         https://bugs.webkit.org/show_bug.cgi?id=31947
190
191         Instead of getting the pending-review attachment ids by scanning each
192         bug (which results in a network request), we should just get them all
193         from webkit.org/pending-review in one shot.
194
195         * Scripts/modules/bugzilla.py:
196         * Scripts/modules/bugzilla_unittest.py:
197         * Scripts/modules/commands/queries.py:
198         * Scripts/modules/commands/queries_unittest.py:
199         * Scripts/modules/commands/queues.py:
200         * Scripts/modules/mock_bugzillatool.py:
201         * Scripts/modules/patchcollection.py:
202
203 2009-11-28  Adam Barth  <abarth@webkit.org>
204
205         Reviewed by Eric Seidel.
206
207         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
208         https://bugs.webkit.org/show_bug.cgi?id=31952
209
210         The mailing list is open for anyone to subscribe.
211
212         * Scripts/modules/bugzilla.py:
213         * Scripts/modules/commands/queues.py:
214
215 2009-11-28  Adam Barth  <abarth@webkit.org>
216
217         Reviewed by Eric Seidel.
218
219         [bzt] style-queue should report style errors to bugzilla
220         https://bugs.webkit.org/show_bug.cgi?id=31945
221
222         Currently, we're just logging the style errors locally.  With this
223         patch we'll actually log the errors to bugzilla.  Note: I plan to run
224         with the "local-only" logging during development.
225
226         * Scripts/modules/commands/queues.py:
227         * Scripts/modules/scm.py:
228
229 2009-11-28  Adam Barth  <abarth@webkit.org>
230
231         Reviewed by Eric Seidel.
232
233         [bzt] style-queue shouldn't reject patches from the commit-queue
234         https://bugs.webkit.org/show_bug.cgi?id=31944
235
236         Currently the style-queue subprocess gets confused and thinks its the
237         commit-queue.  If the patch has an error, it rejects it from the
238         commit-queue.  Instead, we should have style-queue specific logic.
239         This patch doesn't add that logic, but it gives us a callback we can
240         use to add that logic.
241
242         * Scripts/modules/buildsteps.py:
243         * Scripts/modules/commands/queues.py:
244         * Scripts/modules/landingsequence.py:
245
246 2009-11-27  Adam Barth  <abarth@webkit.org>
247
248         Rubber stamped by Eric Seidel.
249
250         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
251
252         * CommitQueueStatus: Removed.
253         * CommitQueueStatus/app.yaml: Removed.
254         * CommitQueueStatus/filters: Removed.
255         * CommitQueueStatus/filters/__init__.py: Removed.
256         * CommitQueueStatus/filters/webkit_extras.py: Removed.
257         * CommitQueueStatus/index.html: Removed.
258         * CommitQueueStatus/index.yaml: Removed.
259         * CommitQueueStatus/queue_status.py: Removed.
260         * CommitQueueStatus/stylesheets: Removed.
261         * CommitQueueStatus/stylesheets/main.css: Removed.
262         * CommitQueueStatus/update_status.html: Removed.
263         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
264
265 2009-11-27  Adam Barth  <abarth@webkit.org>
266
267         Reviewed by Eric Seidel.
268
269         style-queue should only process each patch once
270         https://bugs.webkit.org/show_bug.cgi?id=31939
271
272         Actually address reviewer comments!
273
274         * Scripts/bugzilla-tool:
275
276 2009-11-27  Adam Barth  <abarth@webkit.org>
277
278         Reviewed by Eric Seidel.
279
280         [bzt] style-queue fails to apply a bunch of patches for no reason
281         https://bugs.webkit.org/show_bug.cgi?id=31942
282
283         By passing --non-interactive to check-style, we convince check-style
284         to pass --force to svn-apply, which lets it apply more patches.
285
286         * Scripts/modules/commands/queues.py:
287
288 2009-11-27  Adam Barth  <abarth@webkit.org>
289
290         Reviewed by Eric Seidel.
291
292         [bzt] Support --status-host in style-queue
293         https://bugs.webkit.org/show_bug.cgi?id=31941
294
295         * Scripts/modules/commands/queues.py:
296         * Scripts/modules/statusbot.py:
297
298 2009-11-27  Adam Barth  <abarth@webkit.org>
299
300         Reviewed by Eric Seidel.
301
302         style-queue should only process each patch once
303         https://bugs.webkit.org/show_bug.cgi?id=31939
304
305         Before processing a patch, the try-queues now ask the web service
306         whether they have already processed the patch.  This is an initial cut
307         of this functionality.  I expect we're make it richer over time.
308
309         * Scripts/bugzilla-tool:
310         * Scripts/modules/commands/queues.py:
311         * Scripts/modules/patchcollection.py:
312
313 2009-11-27  Adam Barth  <abarth@webkit.org>
314
315         Reviewed by Eric Seidel.
316
317         PatchStatus does not return status
318         https://bugs.webkit.org/show_bug.cgi?id=31938
319
320         We need to parse attachment_id as an int.  Otherwise, we can't find
321         anything in the datastore.
322
323         * CommitQueueStatus/queue_status.py:
324
325 2009-11-27  Adam Barth  <abarth@webkit.org>
326
327         Reviewed by Eric Seidel.
328
329         Make commit-queue status not throw an exception where there is not
330         status
331         https://bugs.webkit.org/show_bug.cgi?id=31936
332
333         We need to actually fetch the results of the query to see what's in the
334         datastore.
335
336         * CommitQueueStatus/queue_status.py:
337
338 2009-11-27  Adam Barth  <abarth@webkit.org>
339
340         Reviewed by Eric Seidel.
341
342         [bzt] unit test ApplyPatches and ApplyAttachment
343         https://bugs.webkit.org/show_bug.cgi?id=31935
344
345         * Scripts/modules/commands/download.py:
346         * Scripts/modules/commands/download_unittest.py:
347
348 2009-11-27  Adam Barth  <abarth@webkit.org>
349
350         Reviewed by Eric Seidel.
351
352         [bzt] Unit test download commands
353         https://bugs.webkit.org/show_bug.cgi?id=31923
354
355         Adds download_unittest and fixes a bug found while testing.
356
357         * Scripts/modules/commands/commandtest.py:
358         * Scripts/modules/commands/download.py:
359             Fixed a bug where we'd throw an error because [].append returns
360             None.
361         * Scripts/modules/commands/download_unittest.py: Added.
362         * Scripts/modules/mock_bugzillatool.py:
363         * Scripts/run-webkit-unittests:
364
365 2009-11-27  Adam Barth  <abarth@webkit.org>
366
367         Unreviewed "build" fix found while writing unit tests.
368
369         * Scripts/modules/commands/download.py:
370
371 2009-11-27  Adam Barth  <abarth@webkit.org>
372
373         Reviewed by Eric Seidel.
374
375         [bzt] Kill WebKitLandingScripts
376         https://bugs.webkit.org/show_bug.cgi?id=31904
377
378         Step 6: Kill the rest.
379
380         * Scripts/modules/buildsteps.py:
381         * Scripts/modules/commands/download.py:
382         * Scripts/modules/commands/queries.py:
383         * Scripts/modules/commands/upload.py:
384         * Scripts/modules/landingsequence.py:
385         * Scripts/modules/scm.py:
386         * Scripts/modules/webkitlandingscripts.py: Removed.
387
388 2009-11-27  Adam Barth  <abarth@webkit.org>
389
390         Reviewed by Eric Seidel.
391
392         [bzt] Unit test upload commands
393         https://bugs.webkit.org/show_bug.cgi?id=31903
394
395         Adds unit tests for all but two of the upload commands.  The two
396         remaining ones are more difficult.  I'll return to them later.  The
397         goal of these tests is just to run the commands.  We can test more
398         detailed behavior later.
399
400         * Scripts/modules/commands/commandtest.py:
401         * Scripts/modules/commands/upload.py:
402         * Scripts/modules/commands/upload_unittest.py:
403         * Scripts/modules/mock.py: Added.
404         * Scripts/modules/mock_bugzillatool.py:
405
406 2009-11-26  Adam Barth  <abarth@webkit.org>
407
408         Reviewed by Eric Seidel.
409
410         [bzt] Kill WebKitLandingScripts
411         https://bugs.webkit.org/show_bug.cgi?id=31904
412
413         Step 5: Kill run_and_throw_if_fail.
414
415         * Scripts/modules/buildsteps.py:
416         * Scripts/modules/processutils.py: Added.
417         * Scripts/modules/webkitlandingscripts.py:
418
419 2009-11-26  Adam Barth  <abarth@webkit.org>
420
421         Reviewed by Eric Seidel.
422
423         [bzt] Kill WebKitLandingScripts
424         https://bugs.webkit.org/show_bug.cgi?id=31904
425
426         Step 4: Kill run_webkit_script.
427
428         * Scripts/modules/buildsteps.py:
429         * Scripts/modules/commands/download.py:
430         * Scripts/modules/webkitlandingscripts.py:
431
432 2009-11-26  Adam Barth  <abarth@webkit.org>
433
434         Reviewed by Eric Seidel.
435
436         [bzt] Kill WebKitLandingScripts
437         https://bugs.webkit.org/show_bug.cgi?id=31904
438
439         Step 3: Kill build_webkit.
440
441         * Scripts/modules/buildsteps.py:
442         * Scripts/modules/landingsequence.py:
443         * Scripts/modules/webkitlandingscripts.py:
444
445 2009-11-26  Adam Barth  <abarth@webkit.org>
446
447         Reviewed by Eric Seidel.
448
449         [bzt] Kill WebKitLandingScripts
450         https://bugs.webkit.org/show_bug.cgi?id=31904
451
452         Step 2: Kill ensure_builders_are_green.
453
454         * Scripts/modules/buildsteps.py:
455         * Scripts/modules/commands/download.py:
456         * Scripts/modules/landingsequence.py:
457         * Scripts/modules/webkitlandingscripts.py:
458
459 2009-11-26  Adam Barth  <abarth@webkit.org>
460
461         Reviewed by Eric Seidel.
462
463         [bzt] Kill WebKitLandingScripts
464         https://bugs.webkit.org/show_bug.cgi?id=31904
465
466         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
467
468         * Scripts/bugzilla-tool:
469         * Scripts/modules/buildsteps.py: Added.
470         * Scripts/modules/commands/download.py:
471         * Scripts/modules/landingsequence.py:
472         * Scripts/modules/webkitlandingscripts.py:
473
474 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
475
476         Reviewed by Adam Barth.
477
478         Remove directory prefixes from linux commands
479
480         SCM unittests can cause errors on some systems if we use absolute reference to
481         the commands, so directory prefixes have been removed.
482
483         * Scripts/modules/scm_unittest.py:
484
485 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
486
487         Reviewed by Kenneth Rohde Christiansen.
488
489         Link DumpRenderTree to the Qt Ui Tools
490         https://bugs.webkit.org/show_bug.cgi?id=31203
491
492         Implement QWebPage::createPlugin using the Qt Ui Tools
493         to be able to create classes like QProgressBar from within
494         the <object></object> tags This is required for the
495         new automatic test of Qt Plugins.
496
497         * DumpRenderTree/qt/DumpRenderTree.cpp:
498         (WebCore::WebPage::createPlugin):
499         * DumpRenderTree/qt/DumpRenderTree.h:
500         * DumpRenderTree/qt/DumpRenderTree.pro:
501
502 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
503
504         Reviewed by Eric Seidel.
505
506         Update pywebsocket to 0.4.2
507
508         Update pywebsocket to 0.4.2
509         https://bugs.webkit.org/show_bug.cgi?id=31861
510
511         * pywebsocket/example/echo_client.py:
512         * pywebsocket/example/echo_wsh.py:
513         * pywebsocket/mod_pywebsocket/__init__.py:
514         * pywebsocket/mod_pywebsocket/dispatch.py:
515         * pywebsocket/mod_pywebsocket/msgutil.py:
516         * pywebsocket/mod_pywebsocket/standalone.py:
517         * pywebsocket/setup.py:
518         * pywebsocket/test/test_dispatch.py:
519         * pywebsocket/test/test_msgutil.py:
520
521 2009-11-25  Adam Barth  <abarth@webkit.org>
522
523         Reviewed by Eric Seidel.
524
525         Add unit test for mark-fixed
526         https://bugs.webkit.org/show_bug.cgi?id=31896
527
528         * Scripts/modules/commands/commandtest.py: Added.
529         * Scripts/modules/commands/queries_unittest.py:
530         * Scripts/modules/commands/upload_unittest.py: Added.
531         * Scripts/modules/mock_bugzillatool.py:
532         * Scripts/run-webkit-unittests:
533
534 2009-11-25  Adam Barth  <abarth@webkit.org>
535
536         Reviewed by Eric Seidel.
537
538         bugzilla-tool should have a mark-fixed command
539         https://bugs.webkit.org/show_bug.cgi?id=31853
540
541         Pretty simple stuff.
542
543         * Scripts/modules/commands/upload.py:
544
545 2009-11-25  Eric Seidel  <eric@webkit.org>
546
547         Reviewed by Adam Barth.
548
549         'bugzilla-tool help' should only show common commands like how 'git help' does
550         https://bugs.webkit.org/show_bug.cgi?id=31772
551
552         I also took this opportunity to make 'help' a real Command.
553         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
554
555         * Scripts/bugzilla-tool:
556          - change should_show_command_help to should_show_in_main_help
557         * Scripts/modules/commands/download.py:
558          - Mark commands as being shown in main help or not.
559          - show_in_main_help = False is not required (default is false),
560            but it seemed to make the commands more self-documenting.
561         * Scripts/modules/commands/queries.py: ditto
562         * Scripts/modules/commands/queues.py: ditto
563         * Scripts/modules/commands/upload.py: ditto
564         * Scripts/modules/multicommandtool.py:
565          - Make Command hold a pointer to tool in self.tool.  Most Command
566            subclasses do not take advantage of this yet, but it was required
567            for HelpCommand to be able to reach the tool from _help_epilog().
568          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
569          - Move MultiCommandTool._help_epilog to Command._help_epilog
570          - Move "help" logic into HelpCommand.execute()
571          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
572         * Scripts/modules/multicommandtool_unittest.py:
573          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
574
575 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
576
577         Reviewed by Dan Bernstein.
578         
579         Patch by Mark Rowe.
580
581         The buildbots are failing on Windows because when they were upgraded
582         to 4.0.4, Apple Application Support was not in their path. Add it to
583         the path to fix the buildots.
584
585         * Scripts/webkitdirs.pm:
586
587 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
588
589         Reviewed by David Kilzer.
590
591         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
592         https://bugs.webkit.org/show_bug.cgi?id=31799
593
594         * Scripts/run-webkit-tests: Fixed.
595
596 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
597
598         Reviewed by Eric Seidel.
599
600         Change run_command to give back stderr by default
601         https://bugs.webkit.org/show_bug.cgi?id=31734
602
603         Change run_command to give back stderr by default.
604         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
605         Change the related unittest call.
606
607         * Scripts/modules/scm.py:
608         * Scripts/modules/scm_unittest.py:
609
610 2009-11-25  Eric Seidel  <eric@webkit.org>
611
612         Reviewed by Adam Barth.
613
614         Centralize required argument parsing in Command
615         https://bugs.webkit.org/show_bug.cgi?id=31872
616
617         * Scripts/modules/commands/download.py: remove custom required arg message.
618         * Scripts/modules/commands/upload.py: ditto.
619         * Scripts/modules/multicommandtool.py:
620          - Add _parse_required_arguments.
621          - Pass program name off to OptionParser.
622          - Add name() for access to tool name.
623          - Add check_arguments_and_execute and make it return a return code.
624          - Replace a couple uses of + with %.
625         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
626
627 2009-11-25  Eric Seidel  <eric@webkit.org>
628
629         Reviewed by Adam Barth.
630
631         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
632         https://bugs.webkit.org/show_bug.cgi?id=31870
633
634         * Scripts/modules/commands/queries_unittest.py: Use the new class.
635         * Scripts/modules/multicommandtool_unittest.py: Ditto.
636         * Scripts/modules/outputcapture.py: Added.
637
638 2009-11-24  Dmitry Titov  <dimich@chromium.org>
639
640         Reviewed by Eric Seidel.
641
642         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
643         https://bugs.webkit.org/show_bug.cgi?id=31444
644
645         * Scripts/build-webkit:
646
647 2009-11-24  Chris Marrin  <cmarrin@apple.com>
648
649         Reviewed by Simon Fraser.
650
651         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
652         https://bugs.webkit.org/show_bug.cgi?id=27314
653         
654         Now the script allows the directories with these tests to be included on all
655         platforms but Mac, where they behave the same as always. For all other platforms
656         the tests need to be excluded using the Skipped files, which is currently done
657         for all platforms (including win since we're not turned on yet)
658
659         * Scripts/webkitdirs.pm:
660
661 2009-11-24  Eric Seidel  <eric@webkit.org>
662
663         Reviewed by Adam Barth.
664
665         queries_unittest.py should test command output
666         https://bugs.webkit.org/show_bug.cgi?id=31845
667
668         * Scripts/modules/commands/queries_unittest.py:
669          - Capture stdout and stderr and compare with expected strings.
670
671 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
672
673         No Review.
674
675         Fix spelling error ("depenedencies").
676
677         * Scripts/build-webkit:
678
679 2009-11-24  Mark Rowe  <mrowe@apple.com>
680
681         Land the configuration that includes the two debug GTK Linux builders.
682
683         * BuildSlaveSupport/build.webkit.org-config/config.json:
684
685 2009-11-24  David Kilzer  <ddkilzer@apple.com>
686
687         <http://webkit.org/b/31840> bisect-builds broke after r50080
688
689         Reviewed by Dan Bernstein.
690
691         * Scripts/bisect-builds:
692         (mountAndRunNightly): Switched back to using backticks to run
693         the hdiutil command since exec() will terminate the existing
694         script, which is not what we want.  Store the output of
695         File::Spec->devnull() in a variable for use in the hdiutil
696         detach commands.
697
698 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
699
700         Reviewed by Kenneth Rohde Christiansen.
701
702         Include "config.h" to meet Coding Style Guidelines
703         https://bugs.webkit.org/show_bug.cgi?id=31792
704
705         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
706         * DumpRenderTree/qt/jsobjects.cpp:
707         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
708
709 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
710
711         Reviewed by Oliver Hunt.
712
713         Implement new required function to pass test we used to pass. This
714         change is required since r51294.
715
716         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
717         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
718
719 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
720
721         Reviewed by Kenneth Rohde Christiansen.
722
723         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
724         https://bugs.webkit.org/show_bug.cgi?id=31775
725
726         LayoutTestController::dumpBackForwardList() should work with local URLs
727         as well as with normal URLs (in http tests for instance).
728         Currently it does not output the latter properly.
729
730         Unskip a bunch of passing http/navigation tests.
731
732         * DumpRenderTree/qt/DumpRenderTree.cpp:
733         (WebCore::dumpHistoryItem):
734
735 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
736
737         Reviewed by Oliver Hunt.
738
739         ARIA: support aria-flowto
740         https://bugs.webkit.org/show_bug.cgi?id=31762
741
742         * DumpRenderTree/AccessibilityUIElement.cpp:
743         (ariaFlowToElementAtIndexCallback):
744         (AccessibilityUIElement::getJSClass):
745         * DumpRenderTree/AccessibilityUIElement.h:
746         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
747         (AccessibilityUIElement::ariaFlowToElementAtIndex):
748         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
749         (AccessibilityUIElement::ariaFlowToElementAtIndex):
750         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
751         (AccessibilityUIElement::ariaFlowToElementAtIndex):
752
753 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
754
755         Reviewed by Kenneth Christiansen.
756
757         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
758         https://bugs.webkit.org/show_bug.cgi?id=31638
759
760         Unfreeze WorkQueue after each test execution.
761
762         * DumpRenderTree/qt/DumpRenderTree.cpp:
763         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
764
765 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
766
767         Reviewed by Adam Barth.
768
769         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
770         for localhost and 127.0.0.1.
771         https://bugs.webkit.org/show_bug.cgi?id=31783
772
773         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
774
775         * DumpRenderTree/qt/DumpRenderTree.cpp:
776         (WebCore::NetworkAccessManager::NetworkAccessManager):
777         (WebCore::NetworkAccessManager::sslErrorsEncountered):
778         (WebCore::WebPage::WebPage):
779         * DumpRenderTree/qt/DumpRenderTree.h:
780
781 2009-11-22  Chris Evans  <cevans@chromium.org>
782
783         Reviewed by Adam Barth.
784
785         Disable access to file:/// directory listings
786         https://bugs.webkit.org/show_bug.cgi?id=31329
787
788         Implemented setAllowUniversalAccessFromFileURLs to support testing of
789         file URL security.
790
791         * DumpRenderTree/LayoutTestController.cpp:
792         (setAllowUniversalAccessFromFileURLsCallback):
793         (LayoutTestController::staticFunctions):
794         * DumpRenderTree/LayoutTestController.h:
795         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
796         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
797         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
798         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
799         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
800         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
801         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
802         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
803
804 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
805
806         Reviewed by Kenneth Rohde Christiansen.
807
808         [Qt] Fix the timeout of fast/frames/frame-navigation.html
809         https://bugs.webkit.org/show_bug.cgi?id=31638
810
811         The test is timeouting, because it uses the WorkQueue to load a document in one
812         of the child frames and once the loading is finished, the DRT does not dump the
813         tree. This is because it waits for the QWebFrame::loadFinished() signal from
814         the main frame, while it should connect to QWebPage::loadFinished().
815
816         * DumpRenderTree/qt/DumpRenderTree.cpp:
817         (WebCore::DumpRenderTree::DumpRenderTree):
818
819 2009-11-21  Eric Seidel  <eric@webkit.org>
820
821         Reviewed by Adam Barth.
822
823         bugzilla-tool --help spews way too much text
824         https://bugs.webkit.org/show_bug.cgi?id=31771
825
826         * Scripts/bugzilla-tool:
827          - Remove self.cached_scm initialization hack.
828         * Scripts/modules/buildbot.py:
829          - Make default_host accessible to callers.
830         * Scripts/modules/commands/download.py:
831          - Phrase help for all commands consistently and remove spurious help text punctuation.
832         * Scripts/modules/commands/queries.py: Ditto.
833         * Scripts/modules/commands/queues.py: Ditto.
834         * Scripts/modules/commands/upload.py: Ditto.
835         * Scripts/modules/multicommandtool.py:
836          - Add HelpPrintingOptionParser.format_epilog to replace
837            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
838            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
839          - Make --help only show a list of commands like "svn help" and "git help" do --
840            previously --help was listing all commands and options.
841          - Sort list of commands alphabetically.
842
843 2009-11-21  Eric Seidel  <eric@webkit.org>
844
845         No review.  Fixing a typo from the previous patch for bug 31767.
846
847         AbstractQueue.run_bugzilla_tool throws an exception
848         https://bugs.webkit.org/show_bug.cgi?id=31769
849
850         * Scripts/modules/commands/queues.py:
851
852 2009-11-21  Eric Seidel  <eric@webkit.org>
853
854         Reviewed by Adam Barth.
855
856         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
857         https://bugs.webkit.org/show_bug.cgi?id=31767
858
859         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
860         Since we don't have a good way to test BugzillaTool pieces, I've
861         left out a test for now.
862
863         * Scripts/bugzilla-tool:
864          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
865         * Scripts/modules/commands/queues.py:
866          - Use tool.path() instead of __file__.
867         * Scripts/modules/multicommandtool.py:
868          - Add a new path() method to MultiComandTool.
869         * Scripts/modules/multicommandtool_unittest.py:
870          - Provide a path() method.  Little point in testing this mock implementation.
871
872 2009-11-21  Adam Barth  <abarth@webkit.org>
873
874         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
875         WebKitTools.
876
877         * Scripts/modules/commands/download.py:
878
879 2009-11-21  Adam Barth  <abarth@webkit.org>
880
881         Reviewed by Eric Seidel.
882
883         Convert check-style to use LandingSequence
884         https://bugs.webkit.org/show_bug.cgi?id=31763
885
886         Instead of manipulating the working copy by hand, we should use the
887         LandingSequence in CheckStyle.  This will make this code eaiser to
888         test.
889
890         * Scripts/modules/commands/download.py:
891
892 2009-11-20  Adam Barth  <abarth@webkit.org>
893
894         Reviewed by Eric Seidel.
895
896         Unit test query commands
897         https://bugs.webkit.org/show_bug.cgi?id=31755
898
899         These tests are pretty rough, but hopefully they'll grow.
900
901         * Scripts/modules/commands/queries_unittest.py: Added.
902         * Scripts/modules/mock_bugzillatool.py: Added.
903         * Scripts/run-webkit-unittests:
904
905 2009-11-20  Eric Seidel  <eric@webkit.org>
906
907         Reviewed by Adam Barth.
908
909         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
910         https://bugs.webkit.org/show_bug.cgi?id=31758
911
912         * Scripts/modules/multicommandtool.py:
913          - Allow passing of explicit commands to MultiCommandTool.__init__
914         * Scripts/modules/multicommandtool_unittest.py:
915          - Use new Command.name naming system.
916          - Test Command auto-discovery.
917         * Scripts/modules/workqueue.py:
918          - bug_id no longer exists, use patch['bug_id'] instead.
919         * Scripts/modules/workqueue_unittest.py:
920          - WorkQueues require names now.
921          - should_proceed_with_work_item must return a patch object.
922
923 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
924
925         Reviewed by Beth Dakin.
926
927         WAI-ARIA: add support for aria-owns
928         https://bugs.webkit.org/show_bug.cgi?id=31702
929
930         * DumpRenderTree/AccessibilityUIElement.cpp:
931         (ariaOwnsElementAtIndexCallback):
932         (AccessibilityUIElement::getJSClass):
933         * DumpRenderTree/AccessibilityUIElement.h:
934         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
935         (AccessibilityUIElement::ariaOwnsElementAtIndex):
936         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
937         (AccessibilityUIElement::ariaOwnsElementAtIndex):
938         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
939         (AccessibilityUIElement::ariaOwnsElementAtIndex):
940
941 2009-11-20  Eric Seidel  <eric@webkit.org>
942
943         Reviewed by Adam Barth.
944
945         Fix exception thrown when running the commit-queue.
946
947         * Scripts/modules/statusbot.py: patch is optional.
948         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
949
950 2009-11-20  Eric Seidel  <eric@webkit.org>
951
952         Reviewed by Adam Barth.
953
954         Teach the StatusBot how to support more than just the commit-queue
955         https://bugs.webkit.org/show_bug.cgi?id=31754
956
957         * Scripts/modules/workqueue.py: Another typo.
958
959 2009-11-20  Eric Seidel  <eric@webkit.org>
960
961         Reviewed by Adam Barth.
962
963         Teach the StatusBot how to support more than just the commit-queue
964         https://bugs.webkit.org/show_bug.cgi?id=31754
965
966         * Scripts/modules/commands/queues.py: Fix silly typo.
967
968 2009-11-20  Eric Seidel  <eric@webkit.org>
969
970         Reviewed by Adam Barth.
971
972         Teach the StatusBot how to support more than just the commit-queue
973         https://bugs.webkit.org/show_bug.cgi?id=31754
974
975         * CommitQueueStatus/index.yaml:
976          - Add indices required for the new queries.
977         * CommitQueueStatus/queue_status.py:
978          - Add a patch-status page and move update_status to update-status.
979          - Only display "commit-queue" status records for the commit-queue.
980          - Add support for a queue_name property on status records.
981          - Fix _int_from_request to actually work.
982         * CommitQueueStatus/update_status.html:
983          - Add support for a queue_name on status records.
984          - Remove unused list of bug ids.
985          * Scripts/modules/commands/queues.py
986           - Make the queues pass the patch instead of the bug_id to StatusBot.
987         * Scripts/modules/statusbot.py:
988          - Support passing the queue_name to the status updates.
989          - Support fetching patch status with patch_status().
990         * Scripts/modules/workqueue.py:
991          - Pass the patch to the StatusBot instead of the bug_id.
992          - Let WorkQueues have a name.
993
994 2009-11-20  Adam Barth  <abarth@webkit.org>
995
996         Reviewed by Eric Seidel.
997
998         Move bugzilla-tool commands into their own file
999         https://bugs.webkit.org/show_bug.cgi?id=31752
1000
1001         This will let us write unit tests.
1002
1003         * Scripts/bugzilla-tool:
1004         * Scripts/modules/commands/__init__.py: Added.
1005         * Scripts/modules/commands/download.py: Added.
1006         * Scripts/modules/commands/queries.py: Added.
1007         * Scripts/modules/commands/queues.py: Added.
1008         * Scripts/modules/commands/upload.py: Added.
1009         * Scripts/modules/grammar.py: Added.
1010
1011 2009-11-20  Adam Barth  <abarth@webkit.org>
1012
1013         Reviewed by Eric Seidel.
1014
1015         BuildQueue should check if the tree is currently buildable
1016         https://bugs.webkit.org/show_bug.cgi?id=31744
1017
1018         * Scripts/bugzilla-tool:
1019         * Scripts/modules/landingsequence.py:
1020         * Scripts/modules/webkitlandingscripts.py:
1021
1022 2009-11-20  Adam Barth  <abarth@webkit.org>
1023
1024         Reviewed by Eric Seidel.
1025
1026         Move prepare_clean_working_directory into the LandingSequence
1027         https://bugs.webkit.org/show_bug.cgi?id=31743
1028
1029         * Scripts/bugzilla-tool:
1030         * Scripts/modules/landingsequence.py:
1031
1032 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
1033
1034         Reviewed by Kenneth Rohde Christiansen.
1035
1036         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
1037         https://bugs.webkit.org/show_bug.cgi?id=30460
1038
1039         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
1040
1041         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1042         (pluginInvoke):
1043
1044 2009-11-20  Adam Barth  <abarth@webkit.org>
1045
1046         Reviewed by Eric Seidel.
1047
1048         Pass the port information to the child process
1049         https://bugs.webkit.org/show_bug.cgi?id=31736
1050
1051         We need to do this so the child process knows what to build!
1052
1053         * Scripts/bugzilla-tool:
1054         * Scripts/modules/landingsequence.py:
1055         * Scripts/modules/webkitport.py:
1056         * Scripts/modules/webkitport_unittest.py:
1057
1058 2009-11-20  Adam Barth  <abarth@webkit.org>
1059
1060         Reviewed by Eric Seidel.
1061
1062         Support Qt port in build-queue
1063         https://bugs.webkit.org/show_bug.cgi?id=31733
1064
1065         * Scripts/bugzilla-tool:
1066
1067 2009-11-20  Adam Barth  <abarth@webkit.org>
1068
1069         Reviewed by Eric Seidel.
1070
1071         Implement a build-queue
1072         https://bugs.webkit.org/show_bug.cgi?id=31725
1073
1074         Currently this just builds the first 10 patches in the review queue.
1075         We'll want to do something smarter soon.
1076
1077         * Scripts/bugzilla-tool:
1078
1079 2009-11-20  Adam Barth  <abarth@webkit.org>
1080
1081         Reviewed by Eric Seidel.
1082
1083         Make commit-queue and style-queue show up in help
1084         https://bugs.webkit.org/show_bug.cgi?id=31724
1085
1086         We need to store their names on their class to make these commands
1087         properly register themselves with MultiCommandTool.
1088
1089         * Scripts/bugzilla-tool:
1090
1091 2009-11-20  Adam Barth  <abarth@webkit.org>
1092
1093         Reviewed by Eric Seidel.
1094
1095         Implement bugzilla-tool build-attachment
1096         https://bugs.webkit.org/show_bug.cgi?id=31722
1097
1098         This command builds an attachment from bugzilla.  It leaves the built
1099         patch in the working copy.
1100
1101         * Scripts/bugzilla-tool:
1102         * Scripts/modules/landingsequence.py:
1103         * Scripts/modules/webkitlandingscripts.py:
1104
1105 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
1106
1107         Reviewed by Xan Lopez.
1108
1109         [GTK] DRT release event does not create the state correctly
1110         https://bugs.webkit.org/show_bug.cgi?id=31717
1111
1112         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1113
1114 2009-11-20  Eric Seidel  <eric@webkit.org>
1115
1116         Reviewed by Adam Barth.
1117
1118         MultiCommandTool should find Command objects automatically instead of with a manual list
1119         https://bugs.webkit.org/show_bug.cgi?id=31710
1120
1121         * Scripts/bugzilla-tool:
1122         * Scripts/modules/multicommandtool.py:
1123          - Use some wild python-fu to crawl all the known subclasses of Command.
1124
1125 2009-11-20  Adam Barth  <abarth@webkit.org>
1126
1127         Unreviewed "build" fix.  Added missing import.
1128
1129         * Scripts/bugzilla-tool:
1130
1131 2009-11-20  Adam Barth  <abarth@webkit.org>
1132
1133         Unreviewed "build" fix.  I failed to update LandingSequence.test
1134         properly.
1135
1136         * Scripts/modules/landingsequence.py:
1137
1138 2009-11-20  Adam Barth  <abarth@webkit.org>
1139
1140         Reviewed by Eric Seidel.
1141
1142         Create LandingSequence as the all-sing, all-dance landing class
1143         https://bugs.webkit.org/show_bug.cgi?id=31709
1144
1145         Client can inherit from this class to carefully control exactly which
1146         steps they wish to have happen in the landing sequence.
1147
1148         * Scripts/bugzilla-tool:
1149         * Scripts/modules/landingsequence.py: Added.
1150         * Scripts/modules/webkitlandingscripts.py: Added.
1151
1152 2009-11-19  Adam Barth  <abarth@webkit.org>
1153
1154         Reviewed by Eric Seidel.
1155
1156         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
1157         https://bugs.webkit.org/show_bug.cgi?id=31707
1158
1159         This is to help when we implement build-attachment.
1160
1161         * Scripts/bugzilla-tool:
1162
1163 2009-11-19  Adam Barth  <abarth@webkit.org>
1164
1165         Reviewed by Eric Seidel.
1166
1167         Support Qt port in bugzilla-tool
1168         https://bugs.webkit.org/show_bug.cgi?id=31701
1169
1170         Now we support building with Qt!
1171
1172         * Scripts/bugzilla-tool:
1173         * Scripts/modules/webkitport.py: Added.
1174         * Scripts/modules/webkitport_unittest.py: Added.
1175         * Scripts/run-webkit-unittests:
1176
1177 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
1178
1179         Reviewed by Adam Barth.
1180
1181         Remove inserting stderr into patch in bugzilla-tool
1182         https://bugs.webkit.org/show_bug.cgi?id=29914
1183
1184         Modify SCM python module's run_command function to avoid return of stderr
1185         by default, so stderr won't be inserted into the patches.
1186         Modify the related unit test.
1187
1188         * Scripts/modules/scm.py:
1189         * Scripts/modules/scm_unittest.py:
1190
1191 2009-11-19  Eric Seidel  <eric@webkit.org>
1192
1193         Reviewed by Adam Barth.
1194
1195         bugzilla-tool needs per-command help
1196         https://bugs.webkit.org/show_bug.cgi?id=31697
1197
1198         Added support for "bugzilla-tool help command-name"
1199         and a unit test to make sure it works.
1200
1201         * Scripts/modules/multicommandtool.py:
1202         * Scripts/modules/multicommandtool_unittest.py:
1203
1204 2009-11-19  Eric Seidel  <eric@webkit.org>
1205
1206         Reviewed by Adam Barth.
1207
1208         Move MultiCommandTool and Command into a separate file and add some basic unit tests
1209         https://bugs.webkit.org/show_bug.cgi?id=31695
1210
1211         * Scripts/bugzilla-tool:
1212         * Scripts/modules/multicommandtool.py: Added.
1213         * Scripts/modules/multicommandtool_unittest.py: Added.
1214         * Scripts/run-webkit-unittests:
1215
1216 2009-11-19  Eric Seidel  <eric@webkit.org>
1217
1218         No review, just adding a FIXME.
1219
1220         Split out command parsing and help printing from BugzillaTool
1221         https://bugs.webkit.org/show_bug.cgi?id=31688
1222
1223         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
1224
1225 2009-11-19  Eric Seidel  <eric@webkit.org>
1226
1227         Reviewed by Adam Barth.
1228
1229         Split out command parsing and help printing from BugzillaTool
1230         https://bugs.webkit.org/show_bug.cgi?id=31688
1231
1232         * Scripts/bugzilla-tool:
1233          - Add new MultiCommandTool class to contain option parsing and help printing logic.
1234          - Rename private methods to use _ pattern.
1235          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
1236          - 
1237
1238 2009-11-19  Eric Seidel  <eric@webkit.org>
1239
1240         Reviewed by Adam Barth.
1241
1242         Re-factor help printing to use modern python idioms
1243         https://bugs.webkit.org/show_bug.cgi?id=31685
1244
1245         * Scripts/bugzilla-tool:
1246
1247 2009-11-19  Eric Seidel  <eric@webkit.org>
1248
1249         Reviewed by Darin Adler.
1250
1251         commit-queue empty queue logs twice
1252         https://bugs.webkit.org/show_bug.cgi?id=31679
1253
1254         * Scripts/bugzilla-tool:
1255
1256 2009-11-19  Eric Seidel  <eric@webkit.org>
1257
1258         Reviewed by Darin Adler.
1259
1260         bugzilla-tool's reviewer/committer rejection message should be clearer
1261         https://bugs.webkit.org/show_bug.cgi?id=31126
1262
1263         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1264
1265         * Scripts/modules/bugzilla.py:
1266
1267 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1268
1269         Reviewed by Pavel Feldman.
1270
1271         Forces a WM_PAINT event on calling layoutTestController.display()
1272         in order to enable the timeline-paint.html test on Windows.
1273         ::UpdateWindow() does not force an event becaue the window is 
1274         not visible.
1275
1276         https://bugs.webkit.org/show_bug.cgi?id=31402
1277
1278         * DumpRenderTree/win/DumpRenderTree.cpp:
1279         (displayWebView):
1280
1281 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1282
1283         No review needed.
1284
1285         Added myself to committers list.
1286
1287         * Scripts/modules/committers.py:
1288
1289 2009-11-19  Adam Barth  <abarth@webkit.org>
1290
1291         Reviewed by Eric Seidel.
1292
1293         Bugzilla-tool command classes should match command names
1294         https://bugs.webkit.org/show_bug.cgi?id=31666
1295
1296         I renamed all the commands except CommitMessageForCurrentDiff because
1297         the new name would conflict with an existing class.
1298
1299         * Scripts/bugzilla-tool:
1300
1301 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1302
1303         Reviewed by Gustavo Noronha Silva.
1304
1305         Web Inspector: Implement "show inspector" in WebKit GTK
1306         API and enable console tests.
1307
1308         https://bugs.webkit.org/show_bug.cgi?id=31669
1309
1310         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1311         (LayoutTestController::showWebInspector):
1312
1313 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1314
1315         Reviewed by Simon Hausmann.
1316
1317         Minor refactoring + more documentation.
1318
1319         * DumpRenderTree/qt/DumpRenderTree.cpp:
1320         (WebCore::clearHistory):
1321         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1322
1323 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1324
1325         Reviewed by Eric Seidel.
1326
1327         Ignore websocket tests when --no-http is specified.
1328         https://bugs.webkit.org/show_bug.cgi?id=31662
1329
1330         * Scripts/run-webkit-tests:
1331
1332 2009-11-18  Adam Barth  <abarth@webkit.org>
1333
1334         Reviewed by Eric Seidel.
1335
1336         Normalize ' and " in bugzilla-tool
1337         https://bugs.webkit.org/show_bug.cgi?id=31655
1338
1339         We decided " is better than ' and we should be consistent.
1340
1341         * Scripts/bugzilla-tool:
1342
1343 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1344
1345         Reviewed by Kenneth Rohde Christiansen.
1346
1347         [Qt] Remove support for Qt v4.3 or older versions
1348         https://bugs.webkit.org/show_bug.cgi?id=29469
1349
1350         * DumpRenderTree/qt/DumpRenderTree.pro:
1351         * DumpRenderTree/qt/ImageDiff.pro:
1352
1353 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1354
1355         Reviewed by Eric Seidel.
1356
1357         GitTest.test_create_binary_patch fails if /tmp is symlink
1358         https://bugs.webkit.org/show_bug.cgi?id=31536
1359
1360         * Scripts/modules/scm_unittest.py:
1361
1362 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1363
1364         Reviewed by Darin Adler.
1365
1366         Configuration for Chromium Build Slaves.
1367
1368         https://bugs.webkit.org/show_bug.cgi?id=31442
1369
1370         * BuildSlaveSupport/build.webkit.org-config/config.json:
1371         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1372
1373 2009-11-18  Eric Seidel  <eric@webkit.org>
1374
1375         Reviewed by Darin Adler.
1376
1377         workqueue.py results in totally broken commit-queue UI
1378         https://bugs.webkit.org/show_bug.cgi?id=31645
1379
1380         * Scripts/bugzilla-tool:
1381          - Remove unneeded use of PatchCollection.
1382          - Grab a new copy of the cq'd patches every run of the queue.
1383
1384 2009-11-18  Sam Weinig  <sam@webkit.org>
1385
1386         Reviewed by Anders Carlsson.
1387
1388         Make the Mac Geolocation API async.
1389
1390         Update DRT to use the new async Mac Geolocation API.
1391
1392         * DumpRenderTree/mac/UIDelegate.mm:
1393         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1394
1395 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1396
1397         Reviewed by Kenneth Rohde Christiansen.
1398
1399         Add and option to toggle HTML5 datalist support to build-webkit
1400         https://bugs.webkit.org/show_bug.cgi?id=31599
1401
1402         * Scripts/build-webkit:
1403
1404 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1405
1406         Reviewed by Kevin Ollivier.
1407
1408         Enable wx plugin support using the Windows implementation as a base.
1409         
1410         https://bugs.webkit.org/show_bug.cgi?id=31636
1411
1412         * wx/build/settings.py:
1413
1414 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1415
1416         Reviewed by Simon Hausmann.
1417
1418         Change the initialization order so that the controllers
1419         will be created before exporting them to the JS DOM window.
1420
1421         * DumpRenderTree/qt/DumpRenderTree.cpp:
1422         (WebCore::DumpRenderTree::DumpRenderTree):
1423
1424 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1425
1426         Reviewed by Simon Hausmann.
1427
1428         Fix a code copy and paste error. m_page should be page.
1429
1430         * DumpRenderTree/qt/DumpRenderTree.cpp:
1431         (WebCore::DumpRenderTree::createWindow):
1432
1433 2009-11-17  Mark Rowe  <mrowe@apple.com>
1434
1435         Reviewed by Alexey Proskuryakov.
1436
1437         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1438
1439         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1440         This prevents symlinks from confusing the descendant check.
1441
1442 2009-11-17  Mark Rowe  <mrowe@apple.com>
1443
1444         Reviewed by Alexey Proskuryakov.
1445
1446         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1447
1448         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1449         server to be up rather than having run-webkit-tests abort immediately.
1450
1451         * Scripts/run-webkit-tests:
1452
1453 2009-11-17  Eric Seidel  <eric@webkit.org>
1454
1455         Reviewed by Darin Adler.
1456
1457         commit-queue is failing to set reviewer in ChangeLogs
1458         https://bugs.webkit.org/show_bug.cgi?id=31592
1459
1460         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1461         * Scripts/modules/bugzilla.py:
1462          - Add a new _validate_committer_and_reviewer function as a
1463            temporary solution until we can make a real Attachment object
1464            which knows how to fill in its committer/reviewer fields automatically.
1465
1466 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1467
1468         Unreviewed buildbot fix.
1469
1470         Revert part of earlier patch and add comment, as it
1471         was causing timeouts on the buildbot.
1472
1473         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1474         (LayoutTestController::notifyDone):
1475
1476 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1477
1478         Reviewed by Oliver Hunt.
1479
1480         Make the timeout 15 sec as for the other DRT's and make
1481         it print out the same output when a test timeout.
1482
1483         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1484         (LayoutTestController::waitUntilDone):
1485         (LayoutTestController::notifyDone):
1486         (LayoutTestController::timerEvent):
1487
1488 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1489
1490         Reviewed by Timothy Hatcher.
1491
1492         Fixed typos in comments.
1493
1494         * Scripts/modules/committers.py:
1495
1496 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1497
1498         Reviewed by Timothy Hatcher.
1499
1500         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1501         - Updated DRT to show/close inspector for all tests under /inspector
1502         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1503           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1504         - Removed reload on each inspector test
1505         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1506         inspector for those.
1507         - Reimplemented timeline tests in order to get rid of reload there.
1508         - Moved tests that don't require harness into the fast group.
1509
1510         https://bugs.webkit.org/show_bug.cgi?id=31472
1511
1512         * DumpRenderTree/LayoutTestController.cpp:
1513         (setTimelineProfilingEnabledCallback):
1514         (closeWebInspectorCallback):
1515         (LayoutTestController::staticFunctions):
1516         * DumpRenderTree/LayoutTestController.h:
1517         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1518         (shouldOpenWebInspector):
1519         (runTest):
1520         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1521         (LayoutTestController::setTimelineProfilingEnabled):
1522         * DumpRenderTree/mac/DumpRenderTree.mm:
1523         (shouldOpenWebInspector):
1524         (runTest):
1525         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1526         (LayoutTestController::setTimelineProfilingEnabled):
1527         * DumpRenderTree/win/DumpRenderTree.cpp:
1528         (shouldOpenWebInspector):
1529         (runTest):
1530         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1531         (LayoutTestController::setTimelineProfilingEnabled):
1532
1533 2009-11-17  Oliver Hunt  <oliver@apple.com>
1534
1535         Reviewed by Maciej Stachowiak.
1536
1537         Incorrect use of JavaScriptCore API in DumpRenderTree
1538         https://bugs.webkit.org/show_bug.cgi?id=31577
1539
1540         Return undefined rather than a literal null.
1541
1542         * DumpRenderTree/AccessibilityUIElement.cpp:
1543         (setSelectedTextRangeCallback):
1544         (incrementCallback):
1545         (decrementCallback):
1546         (showMenuCallback):
1547
1548 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1549
1550         Reviewed by Beth Dakin.
1551
1552         AX: aria-labelledby duplicates some of its WAI-ARIA label
1553         https://bugs.webkit.org/show_bug.cgi?id=31565
1554
1555         * DumpRenderTree/AccessibilityUIElement.cpp:
1556         (titleUIElementCallback):
1557         (getIsValidCallback):
1558         (AccessibilityUIElement::getJSClass):
1559
1560 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1561
1562         Reviewed by Simon Hausmann.
1563
1564         r50942 broke output from created windows. Make the
1565         m_enableTextOutput a member of the DRT and not the
1566         WebPage.
1567
1568         * DumpRenderTree/qt/DumpRenderTree.cpp:
1569         (WebCore::WebPage::WebPage):
1570         (WebCore::WebPage::javaScriptAlert):
1571         (WebCore::WebPage::javaScriptConsoleMessage):
1572         (WebCore::WebPage::javaScriptConfirm):
1573         (WebCore::WebPage::javaScriptPrompt):
1574         (WebCore::WebPage::acceptNavigationRequest):
1575         (WebCore::DumpRenderTree::DumpRenderTree):
1576         (WebCore::DumpRenderTree::open):
1577         (WebCore::DumpRenderTree::createWindow):
1578         * DumpRenderTree/qt/DumpRenderTree.h:
1579         (WebCore::DumpRenderTree::setTextOutputEnabled):
1580         (WebCore::DumpRenderTree::isTextOutputEnabled):
1581         (WebCore::WebPage::shouldInterruptJavaScript):
1582         (WebCore::WebPage::isTextOutputEnabled):
1583         (WebCore::WebPage::setViewGeometry):
1584
1585 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1586
1587         Reviewed by Gustavo Noronha Silva.
1588
1589         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1590         as the implementation is being used by at least Qt and Gtk+.
1591
1592         Update buildsystems as well.
1593
1594         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1595         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1596         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1597         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1598         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1599         * GNUmakefile.am:
1600
1601 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1602
1603         Reviewed by Alexey Proskuryakov.
1604
1605         Disable wss until all platforms support pyOpenSSL
1606
1607         https://bugs.webkit.org/show_bug.cgi?id=31479
1608
1609         * Scripts/run-webkit-tests:
1610
1611 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1612
1613         Reviewed by Kenneth Christiansen.
1614
1615         [Qt] Implement load error pages support for Qt's DRT.
1616         https://bugs.webkit.org/show_bug.cgi?id=31509
1617
1618         For now, it will not be a default feature, and layout tests
1619         that want to make use of this have to explicitily call
1620         'handleErrorPages();' for the test source.
1621
1622         Any of the other DumpRenderTree's (mac, win and gtk)
1623         support handling error pages. Qt's will be the first.
1624
1625         * DumpRenderTree/qt/DumpRenderTree.cpp:
1626         (WebCore::WebPage::supportsExtension):
1627         (WebCore::WebPage::extension):
1628         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1629         (LayoutTestController::reset):
1630         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1631         (LayoutTestController::shouldHandleErrorPages):
1632         (LayoutTestController::handleErrorPages):
1633
1634 2009-11-16  Eric Seidel  <eric@webkit.org>
1635
1636         Reviewed by Adam Barth.
1637
1638         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1639         https://bugs.webkit.org/show_bug.cgi?id=31549
1640
1641         Renamed --commit-queue to --non-interactive in most places
1642         and remove the code in land-patches which is no longer needed.
1643
1644         * Scripts/bugzilla-tool:
1645
1646 2009-11-16  Eric Seidel  <eric@webkit.org>
1647
1648         Reviewed by Adam Barth.
1649
1650         The commit-queue should use land-attachment
1651         https://bugs.webkit.org/show_bug.cgi?id=31548
1652
1653         * Scripts/bugzilla-tool:
1654
1655 2009-11-16  Adam Barth  <abarth@webkit.org>
1656
1657         Reviewed by Eric Seidel.
1658
1659         Convert CommitQueue over to PatchCollection
1660         https://bugs.webkit.org/show_bug.cgi?id=31547
1661
1662         Also fixes a bug in workqueue and adds a test!
1663
1664         * Scripts/bugzilla-tool:
1665         * Scripts/modules/workqueue.py:
1666         * Scripts/modules/workqueue_unittest.py:
1667
1668 2009-11-16  Adam Barth  <abarth@webkit.org>
1669
1670         Reviewed by Eric Seidel.
1671
1672         Move StyleQueue over to using PatchCollection
1673         https://bugs.webkit.org/show_bug.cgi?id=31544
1674
1675         That's what the class it's for.
1676
1677         * Scripts/bugzilla-tool:
1678         * Scripts/modules/patchcollection.py:
1679         * Scripts/modules/patchcollection_unittest.py:
1680
1681 2009-11-16  Eric Seidel  <eric@webkit.org>
1682
1683         Reviewed by Adam Barth.
1684
1685         bugzilla-tool needs a land-attachment command
1686         https://bugs.webkit.org/show_bug.cgi?id=31546
1687
1688         * Scripts/bugzilla-tool:
1689          - Move all the logic into AbstractLandingCommand and
1690            add a new LandAttachment command subclass.
1691          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1692
1693 2009-11-16  Eric Seidel  <eric@webkit.org>
1694
1695         Reviewed by Adam Barth.
1696
1697         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1698         https://bugs.webkit.org/show_bug.cgi?id=31543
1699
1700         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1701
1702         * Scripts/bugzilla-tool:
1703
1704 2009-11-16  Eric Seidel  <eric@webkit.org>
1705
1706         Reviewed by Adam Barth.
1707
1708         Disable the style queue from posting to the commit queue status page.
1709
1710         * Scripts/bugzilla-tool:
1711
1712 2009-11-16  Adam Barth  <abarth@webkit.org>
1713
1714         Reviewed by Eric Seidel.
1715
1716         Implement PatchCollection
1717         https://bugs.webkit.org/show_bug.cgi?id=31541
1718
1719         This class holds a set of patches and lets clients iterate through
1720         them.  Optionally, clients can install a filter.
1721
1722         * Scripts/modules/patchcollection.py: Added.
1723         * Scripts/modules/patchcollection_unittest.py: Added.
1724         * Scripts/run-webkit-unittests:
1725
1726 2009-11-16  Eric Seidel  <eric@webkit.org>
1727
1728         Reviewed by Adam Barth.
1729
1730         bugzilla-tool land-patches will close bugs with patches r=?
1731         https://bugs.webkit.org/show_bug.cgi?id=28230
1732
1733         The commit-queue shouldn't close patches with outstanding reviews on them,
1734         even if many reviewers seem to be against multi-patch bugs.
1735
1736         * Scripts/bugzilla-tool:
1737
1738 2009-11-16  Eric Seidel  <eric@webkit.org>
1739
1740         Reviewed by Adam Barth.
1741
1742         bugzilla-tool check-style should work with attachment ids instead of bug ids
1743         https://bugs.webkit.org/show_bug.cgi?id=31540
1744
1745         * Scripts/bugzilla-tool:
1746
1747 2009-11-16  Eric Seidel  <eric@webkit.org>
1748
1749         Reviewed by Adam Barth.
1750
1751         WorkQueue is the only place that should know about special exit codes
1752         https://bugs.webkit.org/show_bug.cgi?id=31534
1753
1754         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1755         and add tests for handling exit codes.
1756         I also cleaned up workqueue_unittest.py more.
1757
1758         * Scripts/bugzilla-tool:
1759         * Scripts/modules/workqueue.py:
1760         * Scripts/modules/workqueue_unittest.py:
1761
1762 2009-11-16  Eric Seidel  <eric@webkit.org>
1763
1764         Reviewed by Adam Barth.
1765
1766         Re-factor workqueue_unittest to allow for more than one test.
1767         https://bugs.webkit.org/show_bug.cgi?id=31535
1768
1769         * Scripts/modules/workqueue_unittest.py:
1770
1771 2009-11-16  Eric Seidel  <eric@webkit.org>
1772
1773         Reviewed by Adam Barth.
1774
1775         land-patches needs to be re-factored into smaller chunks
1776         https://bugs.webkit.org/show_bug.cgi?id=31532
1777
1778         * Scripts/bugzilla-tool: fix a couple obvious typos.
1779
1780 2009-11-16  Eric Seidel  <eric@webkit.org>
1781
1782         Reviewed by Adam Barth.
1783
1784         land-patches needs to be re-factored into smaller chunks
1785         https://bugs.webkit.org/show_bug.cgi?id=31532
1786
1787         The next patch will move these methods into WebKitLandingScripts.
1788
1789         * Scripts/bugzilla-tool:
1790          - Split out _land_patch and _close_bug_if_no_active_patches.
1791
1792 2009-11-16  Adam Barth  <abarth@webkit.org>
1793
1794         Reviewed by Eric Seidel.
1795
1796         Fix silly copy-and-paste code.  I am a terrible coder.
1797
1798         * Scripts/modules/bugzilla.py:
1799
1800 2009-11-16  Adam Barth  <abarth@webkit.org>
1801
1802         Reviewed by Eric Seidel.
1803
1804         Implement a StyleQueue
1805         https://bugs.webkit.org/show_bug.cgi?id=31537
1806
1807         The first iteration of the style queue only produces output locally.
1808         There is also a limit of 10 patches because it's not that useful to
1809         iterate through the entire review queue at this point.  We can remove
1810         the limit later.
1811
1812         * Scripts/bugzilla-tool:
1813         * Scripts/modules/bugzilla.py:
1814
1815 2009-11-16  Adam Barth  <abarth@webkit.org>
1816
1817         Reviewed by Eric Seidel.
1818
1819         Unit test WorkQueue
1820         https://bugs.webkit.org/show_bug.cgi?id=31531
1821
1822         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1823
1824         * Scripts/bugzilla-tool:
1825         * Scripts/modules/statusbot.py:
1826         * Scripts/modules/workqueue.py:
1827         * Scripts/modules/workqueue_unittest.py: Added.
1828         * Scripts/run-webkit-unittests:
1829
1830 2009-11-16  Eric Seidel  <eric@webkit.org>
1831
1832         Reviewed by Adam Barth.
1833
1834         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1835         https://bugs.webkit.org/show_bug.cgi?id=31530
1836
1837         * Scripts/bugzilla-tool:
1838
1839 2009-11-16  Eric Seidel  <eric@webkit.org>
1840
1841         Reviewed by Adam Barth.
1842
1843         bugzilla-tool needs apply-attachment
1844         https://bugs.webkit.org/show_bug.cgi?id=31528
1845
1846         * Scripts/bugzilla-tool:
1847          - Add ApplyAttachment command.
1848          - Abstract applying code into WebKitApplyingScripts.
1849          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1850         * Scripts/modules/bugzilla.py:
1851          - Add fetch_attachment and bug_id_for_attachment_id.
1852         * Scripts/modules/bugzilla_unittest.py:
1853          - Add test for new parsing.
1854          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1855
1856 2009-11-16  Eric Seidel  <eric@webkit.org>
1857
1858         Reviewed by Adam Barth.
1859
1860         Document check-style's use of force_clean.
1861
1862         * Scripts/bugzilla-tool:
1863         * Scripts/modules/scm.py:
1864
1865 2009-11-16  Adam Barth  <abarth@webkit.org>
1866
1867         Reviewed by Eric Seidel.
1868
1869         Move WorkQueue to its own file
1870         https://bugs.webkit.org/show_bug.cgi?id=31529
1871
1872         WorkQueue and WorkQueueDelegate are separate concerns from
1873         bugzilla-tool.  Also added a missing include to logging.py.
1874
1875         * Scripts/bugzilla-tool:
1876         * Scripts/modules/logging.py:
1877         * Scripts/modules/workqueue.py:
1878
1879 2009-11-16  Adam Barth  <abarth@webkit.org>
1880
1881         Reviewed by Eric Seidel.
1882
1883         Move OutputTee to logging.py.
1884
1885         * Scripts/bugzilla-tool:
1886         * Scripts/modules/logging.py:
1887
1888 2009-11-15  Adam Barth  <abarth@webkit.org>
1889
1890         Reviewed by Eric Seidel.
1891
1892         Refactor bugzilla-tool to allow for multiple queues
1893         https://bugs.webkit.org/show_bug.cgi?id=31513
1894
1895         Divide the commit queue class into three class to make creating
1896         additional queues easier.
1897
1898         * Scripts/bugzilla-tool:
1899
1900 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1901
1902         Reviewed by Eric Seidel.
1903
1904         svn-apply may not handle git patches created by bugzilla-tool
1905         https://bugs.webkit.org/show_bug.cgi?id=31457
1906
1907         * Scripts/modules/scm.py:
1908         * Scripts/modules/scm_unittest.py:
1909
1910 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1911
1912         Reviewed by Eric Seidel.
1913
1914         bugzilla-tool should post git binary diff
1915         https://bugs.webkit.org/show_bug.cgi?id=31458
1916
1917         Add --binary option to Git.create_patch.
1918
1919         * Scripts/modules/scm.py:
1920         * Scripts/modules/scm_unittest.py:
1921
1922 2009-11-15  Adam Barth  <abarth@webkit.org>
1923
1924         Reviewed by Darin Adler.
1925
1926         Add bugzilla-tool check-style
1927         https://bugs.webkit.org/show_bug.cgi?id=31515
1928
1929         * Scripts/bugzilla-tool:
1930         * Scripts/modules/bugzilla.py:
1931
1932 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1933
1934         Reviewed by Simon Hausmann.
1935
1936         Make the Qt Linux only --valgrind feature, suppress errors
1937         defined in the SuppressedValgrindErrors file.
1938
1939         * Scripts/run-webkit-tests:
1940
1941 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1942
1943         Reviewed by Simon Hausmann.
1944
1945         Set the locale to C and not to the current one in use on the system.
1946
1947         * DumpRenderTree/qt/DumpRenderTree.cpp:
1948         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1949
1950 2009-11-13  Adam Roben  <aroben@apple.com>
1951
1952         Add support for
1953         http/tests/security/isolatedWorld/didClearWindowObject.html
1954
1955         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1956         window objects in isolated worlds are cleared
1957
1958         Reviewed by Dave Hyatt.
1959
1960         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1961
1962         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1963         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1964         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1965         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1966         Added. Sets a __worldID property on the global object whose value is
1967         the ID of this world.
1968         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1969         Respond to this new delegate callback by calling through to one of the
1970         above new methods.
1971         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1972         (worldMap): Added. Returns a HashMap containing all the worlds we've
1973         created.
1974         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1975         haven't kept track of this world.
1976         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1977         instead of declaring our own.
1978
1979         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1980
1981         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1982         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1983         didClearWindowObjectForFrameInStandardWorld.
1984         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1985         Respond to this new delegate callback by calling through to one of the
1986         below new methods.
1987         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1988         Added. Sets a __worldID property on the gobal object whose value is
1989         the ID of this world.
1990         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1991         Added. Moved code here from didClearWindowObject.
1992
1993         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1994         didClearWindowObjectForFrame* functions.
1995
1996         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1997         (worldMap): Added. Returns a HashMap containing all the worlds we've
1998         created.
1999         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
2000         haven't kept track of this world.
2001         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2002         instead of declaring our own.
2003
2004 2009-11-13  Adam Roben  <aroben@apple.com>
2005
2006         Finish replacing worldIDs with world objects
2007
2008         The only remaining use of worldIDs was in a method only used by DRT
2009         for the isolated worlds tests.
2010
2011         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
2012
2013         Reviewed by Mark Rowe.
2014
2015         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2016         (LayoutTestController::evaluateScriptInIsolatedWorld):
2017         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2018         (LayoutTestController::evaluateScriptInIsolatedWorld):
2019         Updated for changes to WebFrame. Now holds the map of worldID -> world
2020         at this level instead of making WebKit do it.
2021
2022 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2023
2024         Reviewed by Simon Hausmann.
2025
2026         [Qt] Ensure the DRT does not output anything until first test is run
2027
2028         * DumpRenderTree/qt/DumpRenderTree.cpp:
2029         * DumpRenderTree/qt/DumpRenderTree.h:
2030
2031 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2032
2033         Reviewed by Tor Arne Vestbø.
2034
2035         Clear the undo stack in before each new test run.
2036
2037         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
2038
2039         * DumpRenderTree/qt/DumpRenderTree.cpp:
2040         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2041
2042 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2043
2044         Reviewed by Kenneth Rohde Christiansen.
2045
2046         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
2047
2048         * DumpRenderTree/qt/DumpRenderTree.cpp:
2049         (WebCore::WebPage::resetSettings):
2050         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2051         (LayoutTestController::overridePreference):
2052
2053 2009-11-13  Eric Seidel  <eric@webkit.org>
2054
2055         Reviewed by Adam Barth.
2056
2057         Update committers.py based on svn records
2058         https://bugs.webkit.org/show_bug.cgi?id=31366
2059
2060         This list was generated using validate-committer-lists from
2061         https://bugs.webkit.org/show_bug.cgi?id=30970
2062         and makes committers.py current for committers who have
2063         committed in the last 3 years.
2064
2065         * Scripts/modules/committers.py:
2066
2067 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
2068
2069         Reviewed by Adam Barth.
2070
2071         The document-open.html test was flaky at times. The test invokes the layout test plugin
2072         which in its destroy stream handler opens a new document. This basically tears down the
2073         stream and the associated plugin instance. The pluginLog function in the layout test
2074         plugin attempts to retrieve the window script object on a torn down plugin instance
2075         which crashed consistently on windows in the debugger. The functions which issue
2076         these logs already have a valid window script object. We now have variants of the pluginLog
2077         function which take in a window script object with and without variable arguments. 
2078
2079         https://bugs.webkit.org/show_bug.cgi?id=31067
2080
2081         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2082         (pluginLogWithWindowObject):
2083         (pluginLogWithWindowObjectVariableArgs):
2084         (pluginLog):
2085         (notifyTestCompletion):
2086         (testDocumentOpen):
2087         (testWindowOpen):
2088
2089 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2090
2091         Reviewed by Gustavo Noronha Silva.
2092
2093         https://bugs.webkit.org/show_bug.cgi?id=30997
2094         [Gtk] Implemment AtkDocument
2095
2096         Added testing support.
2097
2098         * DumpRenderTree/AccessibilityUIElement.cpp:
2099         * DumpRenderTree/AccessibilityUIElement.h:
2100         (getDocumentEncodingCallback):
2101         (getDocumentURICallback):
2102         (AccessibilityUIElement::getJSClass):
2103         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2104         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2105         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2106         (AccessibilityUIElement::documentEncoding):
2107         (AccessibilityUIElement::documentURI):
2108
2109 2009-11-12  Adam Roben  <aroben@apple.com>
2110
2111         Replace worldIDs with world objects
2112
2113         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
2114         user scripts/stylesheets and isolated worlds
2115
2116         Reviewed by Sam Weinig.
2117
2118         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2119         (LayoutTestController::addUserScript):
2120         (LayoutTestController::addUserStyleSheet):
2121         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2122         (LayoutTestController::addUserScript):
2123         (LayoutTestController::addUserStyleSheet):
2124         Changed these functions to create a new WebJSWorld each time they're
2125         called and to pass that world to WebKit.
2126
2127 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
2128
2129         Reviewed by Oliver Hunt.
2130
2131         need to implement aria tree roles
2132         https://bugs.webkit.org/show_bug.cgi?id=31284
2133
2134         * DumpRenderTree/AccessibilityUIElement.cpp:
2135         (disclosedRowAtIndexCallback):
2136         (selectedRowAtIndexCallback):
2137         (isEqualCallback):
2138         (isAttributeSettableCallback):
2139         (isActionSupportedCallback):
2140         (disclosedByRowCallback):
2141         (hierarchicalLevelCallback):
2142         (AccessibilityUIElement::getJSClass):
2143         * DumpRenderTree/AccessibilityUIElement.h:
2144         (AccessibilityUIElement::isEqual):
2145         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2146         (AccessibilityUIElement::hierarchicalLevel):
2147         (AccessibilityUIElement::disclosedRowAtIndex):
2148         (AccessibilityUIElement::selectedRowAtIndex):
2149         (AccessibilityUIElement::disclosedByRow):
2150         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2151         (AccessibilityUIElement::getChildAtIndex):
2152         (AccessibilityUIElement::disclosedRowAtIndex):
2153         (AccessibilityUIElement::selectedRowAtIndex):
2154         (AccessibilityUIElement::titleUIElement):
2155         (AccessibilityUIElement::parentElement):
2156         (AccessibilityUIElement::disclosedByRow):
2157         (AccessibilityUIElement::hierarchicalLevel):
2158         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2159         (AccessibilityUIElement::hierarchicalLevel):
2160         (AccessibilityUIElement::disclosedRowAtIndex):
2161         (AccessibilityUIElement::selectedRowAtIndex):
2162         (AccessibilityUIElement::disclosedByRow):
2163
2164 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
2165
2166         Reviewed by Darin Adler.
2167
2168         svn-apply can not handle git binary diffs
2169         https://bugs.webkit.org/show_bug.cgi?id=26830
2170
2171         Support "literal" type git binary diffs.
2172
2173         * Scripts/VCSUtils.pm:
2174         * Scripts/modules/scm_unittest.py:
2175         * Scripts/svn-apply:
2176
2177 2009-11-11  Dmitry Titov  <dimich@chromium.org>
2178
2179         Not reviewed, removing duplicate entry for myself in committers.py.
2180
2181         * Scripts/modules/committers.py:
2182
2183 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
2184
2185         Reviewed by Darin Adler and Mark Rowe.
2186
2187         https://bugs.webkit.org/show_bug.cgi?id=31200
2188         Tests in http/tests/security/mixedContent start to fail when new tests are added
2189
2190         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
2191
2192 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2193
2194         Reviewed by Jan Alonzo.
2195
2196         Create, and display a window for the inspector, for inspector
2197         tests.
2198
2199         Need to also show/hide the inspector window to avoid having
2200         problems with code assuming it is realized
2201         https://bugs.webkit.org/show_bug.cgi?id=31347
2202
2203         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2204         (webInspectorShowWindow):
2205         (webInspectorCloseWindow):
2206         (webInspectorInspectWebView):
2207         (createWebView):
2208
2209 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2210
2211         Unreviewed Qt buildbot fix.
2212
2213         My previous fix was wrong, so revert that change and fix it by
2214         returning when the document of the frame has no document element.
2215         Idea is borrowed from mac and win DRT.
2216
2217         * DumpRenderTree/qt/DumpRenderTree.cpp:
2218         (WebCore::DumpRenderTree::dumpFramesAsText):
2219
2220 2009-11-11  Eric Seidel  <eric@webkit.org>
2221
2222         Reviewed byg Kenneth Rohde Christiansen.
2223
2224         Update Kenneth's committer record to include the email he
2225         uses on lists.webkit.org.
2226
2227         * Scripts/modules/committers.py:
2228
2229 2009-11-11  Eric Seidel  <eric@webkit.org>
2230
2231         Reviewed by Gustavo Noronha Silva.
2232
2233         Several committers use separate email addresses for bugzilla and svn.webkit.org
2234         https://bugs.webkit.org/show_bug.cgi?id=31364
2235
2236         Update records for existing committers to include email addresses
2237         used in svn.webkit.org and lists.webkit.org.
2238         Most committers use the same email address in all 3 places, but some use
2239         separate addresses.  committers.py needs record of each of these addresses.
2240
2241         * Scripts/modules/committers.py:
2242
2243 2009-11-11  Eric Seidel  <eric@webkit.org>
2244
2245         No review, adding second email address for an existing committer.
2246
2247         Add Yong Li's second bugzilla account to his committer record.
2248         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
2249
2250         * Scripts/modules/committers.py:
2251
2252 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2253
2254         Reviewed by Simon Hausmann.
2255
2256         If the frame has no innerText don't append it, and
2257         do not add a newline which breaks some cross platform
2258         results.
2259
2260         * DumpRenderTree/qt/DumpRenderTree.cpp:
2261         (WebCore::DumpRenderTree::dumpFramesAsText):
2262
2263 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2264
2265         Reviewed by Simon Hausmann.
2266
2267         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2268
2269         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2270         (webkit_test_plugin_new_instance):
2271         (webkit_test_plugin_destroy_instance):
2272         (webkit_test_plugin_destroy_stream):
2273
2274 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2275
2276         Reviewed by Mark Rowe.
2277
2278         Implement the functionality needed by plugins/window-open.html
2279
2280         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2281         (webkit_test_plugin_new_instance):
2282         (webkit_test_plugin_set_window):
2283
2284 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2285
2286         Reviewed by Simon Hausmann.
2287
2288         [Qt] Force -graphicssystem raster and -style windows when running DRT
2289
2290         * DumpRenderTree/qt/main.cpp:
2291         * Scripts/run-webkit-tests:
2292
2293 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2294
2295         Reviewed by Simon Hausmann.
2296
2297         Compute correct library paths for Qt
2298
2299         * Scripts/webkitdirs.pm:
2300
2301 2009-11-10  Mark Rowe  <mrowe@apple.com>
2302
2303         Reviewed by Sam Weinig.
2304
2305         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2306
2307         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2308         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2309         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2310         that had enabled frame load delegate logging this would result in extra log messages being generated,
2311         causing the test to fail.
2312
2313         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2314         tests.
2315
2316         * DumpRenderTree/mac/DumpRenderTree.mm:
2317         (dumpRenderTree):
2318         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2319         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2320
2321 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2322
2323         Reviewed by Kenneth Rohde Christiansen.
2324
2325         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2326
2327         * DumpRenderTree/qt/DumpRenderTree.cpp:
2328         (WebCore::DumpRenderTree::DumpRenderTree):
2329
2330 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2331
2332         Reviewed by Jan Alonzo.
2333
2334         [GTK] Remove WebSocket configuration from WebKitWebSettings
2335         https://bugs.webkit.org/show_bug.cgi?id=31244
2336
2337         Follow-up of r50724. Don't set the enable-web-socket property
2338         anymore.
2339
2340         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2341         (resetDefaultsToConsistentValues):
2342
2343 2009-11-10  Oliver Hunt  <oliver@apple.com>
2344
2345         Reviewed by Maciej Stachowiak.
2346
2347         Rename 3D Canvas related classes to use WebGL prefix
2348         https://bugs.webkit.org/show_bug.cgi?id=29095
2349
2350         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2351         and upate webkitdirs script to new method of testing for WebGL.
2352
2353         * Scripts/do-webcore-rename:
2354         * Scripts/webkitdirs.pm:
2355
2356 2009-11-09  Oliver Hunt  <oliver@apple.com>
2357
2358         Reviewed by Geoff Garen.
2359
2360         Make do-webcore-rename work with git.
2361
2362         * Scripts/do-webcore-rename:
2363
2364 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2365
2366         Adding Kenneth to the reviewers list.
2367
2368         * Scripts/modules/committers.py:
2369
2370 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2371
2372         Reviewed by Jan Alonzo.
2373
2374         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2375         https://bugs.webkit.org/show_bug.cgi?id=30482
2376
2377         LayoutTestControllerGtk now uses the exposed
2378         Page::tabKeyCyclesThroughElements API
2379
2380         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2381         (LayoutTestController::setTabKeyCyclesThroughElements):
2382
2383 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2384
2385         Reviewed by Holger Freyther.
2386
2387         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2388         This helps to pass the test case below. Also replaced hardcoded
2389         code numbers with defined constants.
2390         https://bugs.webkit.org/show_bug.cgi?id=31185
2391         
2392         Test: editing/undo/undo-deleteWord.html
2393
2394         * DumpRenderTree/qt/EventSenderQt.cpp:
2395         (EventSender::keyDown):
2396
2397 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2398
2399         Reviewed by Holger Freyther.
2400
2401         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2402         https://bugs.webkit.org/show_bug.cgi?id=31164
2403
2404         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2405
2406         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2407         (LayoutTestController::processWork):
2408
2409 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2410
2411         Reviewed by Holger Freyther.
2412
2413         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2414         https://bugs.webkit.org/show_bug.cgi?id=31158
2415
2416         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2417         always, which from WorkQueue prospective means that a load has been started
2418         and the queue processing should stop and wait for the load to finish.
2419         Spinning it off into a loading and a non-loading variants was the solution
2420         adopted by Mac's DRT to work around this problem. The former keeps returning
2421         'true' while the later executes the script synchronously and returns 'false'
2422         making it possible to the WorkQueue to proceed right away.
2423
2424         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2425         (LayoutTestController::processWork):
2426         (LayoutTestController::queueLoadingScript):
2427         (LayoutTestController::queueNonLoadingScript):
2428         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2429         * DumpRenderTree/qt/WorkQueueItem.h:
2430         (LoadingScriptItem::LoadingScriptItem):
2431         (LoadingScriptItem::invoke):
2432         (NonLoadingScriptItem::NonLoadingScriptItem):
2433         (NonLoadingScriptItem::invoke):
2434
2435 2009-11-07  Mark Rowe  <mrowe@apple.com>
2436
2437         Rubber-stamped by Cameron Zwarich.
2438
2439         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2440
2441         * Scripts/commit-log-editor:
2442
2443 2009-11-07  Mark Rowe  <mrowe@apple.com>
2444
2445         Reviewed by Darin Adler.
2446
2447         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2448         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2449
2450         Move logic for determining the name and email address to use in a ChangeLog entry from
2451         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2452         whether the author of the patch matches committer, and therefore needs access to the
2453         email address that would be used in a ChangeLog entry.
2454
2455         Based on a patch by Pierre d'Herbemont.
2456
2457         * Scripts/VCSUtils.pm:
2458         * Scripts/commit-log-editor:
2459         * Scripts/prepare-ChangeLog:
2460         * Scripts/webkitdirs.pm:
2461
2462 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2463
2464         Reviewed by Adam Barth.
2465
2466         Added functionality to the layout test plugin to invoke document.open and
2467         window.open with default arguments. The associated webkit bug is
2468         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2469         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2470         work in Chromium (V8) if there is no calling javascript context. To achieve this
2471         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2472         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2473
2474         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2475         (testDocumentOpen):
2476         (testWindowOpen):
2477         (pluginAllocate):
2478         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2479         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2480         (NPP_New):
2481         (NPP_SetWindow):
2482         (NPP_DestroyStream):
2483         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2484         (NPP_New):
2485         (NPP_SetWindow):
2486         (NPP_NewStream):
2487         (NPP_DestroyStream):
2488
2489 2009-11-06  Eric Seidel  <eric@webkit.org>
2490
2491         Reviewed by Adam Barth.
2492
2493         bugzilla-tool crashed with exception
2494         https://bugs.webkit.org/show_bug.cgi?id=31092
2495
2496         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2497
2498 2009-11-04  Eric Seidel  <eric@webkit.org>
2499
2500         No review, just add a line which got left out of the patch uploaded for commit.
2501
2502         commit-queue is crashing when trying to reject patches after unknown failures
2503         https://bugs.webkit.org/show_bug.cgi?id=31091
2504
2505         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2506
2507 2009-11-04  Adam Roben  <aroben@apple.com>
2508
2509         Remove bogus else clause in bugzilla-tool
2510
2511         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2512         create-bug raises exception after entering bug description
2513
2514         Reviewed by David Kilzer.
2515
2516         * Scripts/bugzilla-tool:
2517         (CreateBug): else clauses are only hit if no exception is raised, so
2518         it makes no sense to try to re-raise the exception in an else clause.
2519         The exception will automatically be re-raised if it doesn't match any
2520         of the except clauses, so we don't have to do anything special here at
2521         all to get the desired behavior.
2522
2523 2009-11-04  Eric Seidel  <eric@webkit.org>
2524
2525         Reviewed by David Kilzer.
2526
2527         svn-apply's fixChangeLogPatch function seems broken
2528         https://bugs.webkit.org/show_bug.cgi?id=30683
2529
2530         Update fixChangeLogPatch to be able to handle patches which
2531         don't start at line 1.
2532         Add unit tests for svn-apply to scm_unittest.py.
2533
2534         * Scripts/VCSUtils.pm:
2535         * Scripts/modules/scm_unittest.py:
2536
2537 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2538
2539         Reviewed by Beth Dakin.
2540
2541         Need to implement ARIA role="combobox"
2542         https://bugs.webkit.org/show_bug.cgi?id=31096
2543
2544         * DumpRenderTree/AccessibilityUIElement.cpp:
2545         (showMenuCallback):
2546         (getIsExpandedCallback):
2547         (AccessibilityUIElement::getJSClass):
2548         * DumpRenderTree/AccessibilityUIElement.h:
2549         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2550         (AccessibilityUIElement::isExpanded):
2551         (AccessibilityUIElement::showMenu):
2552         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2553         (AccessibilityUIElement::isExpanded):
2554         (AccessibilityUIElement::showMenu):
2555         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2556         (AccessibilityUIElement::isSelected):
2557         (AccessibilityUIElement::isExpanded):
2558         (AccessibilityUIElement::showMenu):
2559
2560 2009-11-04  Eric Seidel  <eric@webkit.org>
2561
2562         Reviewed by Adam Barth.
2563
2564         commit-queue is crashing when trying to reject patches after unknown failures
2565         https://bugs.webkit.org/show_bug.cgi?id=31091
2566
2567         * Scripts/bugzilla-tool:
2568          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2569            so we have to find out what the current patch is by asking bugzilla again.
2570          - Discovered that this code was also leaking file descriptors, so fixed that.
2571
2572 2009-11-04  Adam Roben  <aroben@apple.com>
2573
2574         Make run-webkit-tests work for the Debug_Internal Windows
2575         configuration
2576
2577         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2578         suffix.
2579
2580         Fixes <http://webkit.org/b/31123>.
2581
2582         Reviewed by Sam Weinig.
2583
2584         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2585         Debug_Internal, either.
2586
2587 2009-11-04  Eric Seidel  <eric@webkit.org>
2588
2589         Reviewed by Adam Barth.
2590
2591         committers.py needs a way to store non-bugzilla email addresses
2592         https://bugs.webkit.org/show_bug.cgi?id=31037
2593
2594         Make Committer and Reviewer constructors take a single email or a list of emails.
2595         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2596         Expose reviewers(), used by validate-committer-lists on bug 30970.
2597
2598         * Scripts/modules/committers.py:
2599         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2600
2601 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2602
2603         Reviewed by David Levin.
2604
2605         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2606         https://bugs.webkit.org/show_bug.cgi?id=27491
2607
2608         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2609         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2610
2611         Functions to start or stop Web Socket servers are added.
2612
2613         * Scripts/run-webkit-tests:
2614
2615 2009-11-03  Eric Seidel  <eric@webkit.org>
2616
2617         No review, just changing wording of log message.
2618
2619         Change log string to say "failed" instead of "rejected"
2620         when a commit fails due to an out of date checkout.
2621         This makes grepping the commit-queue log for rejected patches easier.
2622
2623         * Scripts/bugzilla-tool:
2624
2625 2009-11-03  Eric Seidel  <eric@webkit.org>
2626
2627         No review, adding commonly known committers missing from the file.
2628
2629         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2630
2631 2009-11-03  Eric Seidel  <eric@webkit.org>
2632
2633         No review, just sort-order cleanup.
2634
2635         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2636
2637 2009-11-03  Stephen White  <senorblanco@chromium.org>
2638
2639         (Unreviewed).
2640
2641         Add myself to committers.py.
2642
2643         * Scripts/modules/committers.py:
2644
2645 2009-11-03  Robin Dunn  <robin@alldunn.com>
2646
2647         Reviewed by Kevin Ollviier.
2648
2649         Add packaging scripts for Debian-based Linux distros.
2650         
2651         https://bugs.webkit.org/show_bug.cgi?id=31075
2652
2653         * wx/packaging/build-debian-installer.py: Added.
2654         * wx/packaging/debian: Added.
2655
2656 2009-11-03  Dan Bernstein  <mitz@apple.com>
2657
2658         Reviewed by Anders Carlsson and Beth Dakin.
2659
2660         https://bugs.webkit.org/show_bug.cgi?id=31070
2661
2662         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2663         destroyed, it executes the value of the 'ondestroy' parameter as a
2664         script.
2665
2666         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2667         (pluginAllocate): Initialize onDestroy.
2668         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2669         onDestroy.
2670         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2671         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2672         specified.
2673         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2674
2675 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2676
2677         Reviewed by Xan Lopez.
2678
2679         https://bugs.webkit.org/show_bug.cgi?id=31035
2680         [GTK] some accessibility tests hitting assertion in debug builds
2681
2682         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2683
2684         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2685         (AccessibilityController::rootElement):
2686
2687 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2688
2689         Reviewed by Beth Dakin.
2690
2691         Support ARIA "tab" roles
2692         https://bugs.webkit.org/show_bug.cgi?id=30842
2693
2694         * DumpRenderTree/AccessibilityUIElement.cpp:
2695         * DumpRenderTree/AccessibilityUIElement.h:
2696         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2697         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2698         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2699
2700 2009-11-01  Eric Seidel  <eric@webkit.org>
2701
2702         Reviewed by David Levin.
2703
2704         buildbots should use --exit-after-N-failures
2705         https://bugs.webkit.org/show_bug.cgi?id=30809
2706
2707         Make the bots exit after 20 failures to prevent never-ending
2708         test runs where every test spends a minute crashing.
2709
2710         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2711
2712 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2713
2714         Reviewed by Eric Seidel.
2715
2716         Turn on warnings for QtWebKit for gcc
2717         https://bugs.webkit.org/show_bug.cgi?id=30958
2718
2719         * DumpRenderTree/qt/main.cpp: 
2720         (crashHandler): Mark function NO_RETURN
2721
2722 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2723
2724         Adding myself to the committers list.
2725
2726         * Scripts/modules/committers.py:
2727
2728 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2729
2730         Fix an issue that Adam noticed in DRT.
2731
2732         Reviewed by Darin Adler.
2733
2734         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2735         (AccessibilityUIElement::role):
2736         Get the length of the role text, and create a buffer dynamically.
2737
2738 2009-10-30  Eric Seidel  <eric@webkit.org>
2739
2740         No review, rolling out r50105.
2741         http://trac.webkit.org/changeset/50105
2742
2743         This commit was causing:
2744         https://bugs.webkit.org/show_bug.cgi?id=30869
2745         We'll re-implement the feature a different way.
2746
2747         * Scripts/bugzilla-tool:
2748
2749 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2750
2751         Test for MSAA: Accessibility of headings is not correct
2752
2753         https://bugs.webkit.org/show_bug.cgi?id=30937
2754
2755         Reviewed by Adam Roben.
2756
2757         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2758         (AccessibilityUIElement::role):
2759         Allow the role returned to be a BSTR.
2760         (AccessibilityUIElement::description):
2761         Fix a copy/paste error.
2762
2763 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2764
2765         Test for MSAA: Accessibility of links is wrong
2766
2767         https://bugs.webkit.org/show_bug.cgi?id=30928
2768
2769         Reviewed by Darin Adler.
2770
2771         * DumpRenderTree/AccessibilityUIElement.cpp:
2772         (getAccessibilityValueCallback):
2773         Return the accessibility value.
2774         (AccessibilityUIElement::getJSClass):
2775         Added "accessibilityValue" value.
2776
2777         * DumpRenderTree/AccessibilityUIElement.h:
2778
2779         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2780         (AccessibilityUIElement::accessibilityValue):
2781         Stubbed.
2782
2783         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2784         (AccessibilityUIElement::accessibilityValue):
2785         Stubbed.
2786
2787         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2788         (AccessibilityUIElement::accessibilityValue):
2789         Get the object's value, and return it as a JS string.
2790
2791 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2792
2793         Fix typo in command name used by wx build system.
2794
2795         * wx/build/build_utils.py:
2796
2797 2009-10-30  Adam Barth  <abarth@webkit.org>
2798
2799         Reviewed by Darin Adler.
2800
2801         Patch v1 is a dumb default name for patches
2802         https://bugs.webkit.org/show_bug.cgi?id=30952
2803
2804         Let's use "Patch" instead.
2805
2806         * Scripts/bugzilla-tool:
2807
2808 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2809
2810         Unreviewed trivial buildfix.
2811
2812         [Qt] Buildfix for r50333.
2813
2814         * DumpRenderTree/qt/DumpRenderTree.pro:
2815
2816 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2817
2818         Reviewed by Holger Freyther.
2819
2820         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2821         https://bugs.webkit.org/show_bug.cgi?id=30953
2822
2823         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2824         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2825         makes qt DRT to share this implementation (as gtk and mac ports do).
2826
2827         * DumpRenderTree/qt/DumpRenderTree.pro:
2828         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2829         * DumpRenderTree/qt/WorkQueue.h: Removed.
2830
2831 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2832
2833         Unreviewed potential buildbot fix.
2834
2835         Second try: Reset page history before running each test.
2836
2837         Apparently the QWebHistory::clear() keeps the current page
2838         in history which is not what we want, so we not additionally
2839         sets the history capacity to 0 (forces removing everything)
2840         and then sets it back to its original value.
2841
2842         * DumpRenderTree/qt/DumpRenderTree.cpp:
2843         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2844
2845 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2846
2847         Unreviewed potential buildbot fix.
2848
2849         Reset page history before running each test.
2850
2851         * DumpRenderTree/qt/DumpRenderTree.cpp:
2852         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2853
2854 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2855
2856         Reviewed by Eric Seidel.
2857
2858         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2859
2860         Bug 28420 -  Implement HTML5 <ruby> rendering
2861         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2862
2863         No new tests (no functional change).
2864
2865         * Scripts/build-webkit:
2866
2867 2009-10-29  Dan Bernstein  <mitz@apple.com>
2868
2869         Reviewed by Mark Rowe.
2870
2871         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2872         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2873         define it.
2874
2875         * Scripts/VCSUtils.pm:
2876         * Scripts/svn-apply:
2877         * Scripts/svn-unapply:
2878
2879 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2880
2881         Reviewed by Gustavo Noronha.
2882
2883         Use the GTK+ main loop instead of rolling our own mini-version of
2884         it.
2885
2886         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2887         (dump):
2888         (runTest):
2889         (webViewLoadFinished):
2890
2891 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2892
2893         Reviewed by Oliver Hunt.
2894
2895         Implement the Qt version of DRT dumpBackForwardList().
2896
2897         * DumpRenderTree/qt/DumpRenderTree.cpp:
2898         (WebCore::dumpHistoryItem):
2899         (WebCore::DumpRenderTree::dumpBackForwardList):
2900
2901 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2902
2903         Reviewed by Adam Roben.
2904
2905         Implement DRT functionality for Qt introduced in
2906         r28690 and r28705.
2907
2908         - Implemented pathToLocalResource which exposes the functionality of
2909         converting a given unix path to the correct location on Windows.
2910         - Implemented a way to remove machine-dependent information from paths
2911         in layout test results.
2912
2913         * DumpRenderTree/qt/DumpRenderTree.cpp:
2914         (WebCore::urlSuitableForTestResult):
2915         (WebCore::WebPage::javaScriptConsoleMessage):
2916         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2917         (LayoutTestController::pathToLocalResource):
2918         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2919
2920 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2921
2922         Adding myself to the committers list.
2923
2924         * Scripts/modules/committers.py:
2925
2926 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2927
2928         Adding myself to the committers list.
2929
2930         * Scripts/modules/committers.py:
2931
2932 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2933
2934         Reviewed by Jan Alonzo.
2935
2936         [GTK] API to start inspector for a WebView
2937         https://bugs.webkit.org/show_bug.cgi?id=22551
2938
2939         Use the new inspector API to implement the LayoutTestController
2940         interfaces used to test the inspector.
2941
2942         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2943         (webInspectorInspectWebView):
2944         (createWebView):
2945         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2946         (LayoutTestController::showWebInspector):
2947         (LayoutTestController::closeWebInspector):
2948         (LayoutTestController::evaluateInWebInspector):
2949
2950 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2951
2952         Reviewed by Eric Seidel.
2953
2954         [Qt] WebFrame::counterValueForElementById must not be exposed
2955         https://bugs.webkit.org/show_bug.cgi?id=30882
2956
2957         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2958         (LayoutTestController::counterValueForElementById):
2959
2960 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2961
2962         Rubberstamped by Oliver Hunt.
2963
2964         Fix the warning:
2965
2966         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2967         declared with attribute warn_unused_result".
2968
2969         by actually checking the result. In the case it is null, an
2970         error has occoured, so treat it as the other fatal errors.
2971
2972         * DumpRenderTree/qt/DumpRenderTree.cpp:
2973         (WebCore::DumpRenderTree::initializeFonts):
2974
2975 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2976
2977         Reviewed by Darin Adler.
2978
2979         Provide a way to get counter values with layoutTestContoller
2980         https://bugs.webkit.org/show_bug.cgi?id=30555
2981
2982         Define layoutTestContoller.counterValueForElementById.
2983
2984         * DumpRenderTree/LayoutTestController.cpp:
2985         (counterValueForElementByIdCallback):
2986         (LayoutTestController::staticFunctions):
2987         * DumpRenderTree/LayoutTestController.h:
2988         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2989         (LayoutTestController::counterValueForElementById):
2990
2991 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2992
2993         Rubberstamped by Oliver Hunt.
2994
2995         Change two methods to be internal for DRT use only.
2996
2997         Part of [Qt] Review all new API in Qt 4.6
2998         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2999
3000         * DumpRenderTree/qt/DumpRenderTree.cpp:
3001         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3002         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3003         (LayoutTestController::whiteListAccessFromOrigin):
3004
3005 2009-10-27  Eric Seidel  <eric@webkit.org>
3006
3007         Reviewed by Adam Barth.
3008
3009         REGRESSION: svn-apply exits(1) when applying a patch with a file add
3010         https://bugs.webkit.org/show_bug.cgi?id=30826
3011
3012         * Scripts/svn-apply:
3013          - Add () around all system() calls.
3014          - Use the correct system() == 0 or die instead of system() or die
3015          - Add descriptive messages to all die statements.
3016
3017 2009-10-27  Steve Block  <steveblock@google.com>
3018
3019         Reviewed by NOBODY.
3020
3021         Adds steveblock@google.com to list of committers.
3022
3023         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
3024
3025 2009-10-27  Eric Seidel  <eric@webkit.org>
3026
3027         Reviewed by Adam Barth.
3028
3029         svn-apply can exit(0) even on patch failure
3030         https://bugs.webkit.org/show_bug.cgi?id=29622
3031
3032         * Scripts/svn-apply:
3033          - Add a bunch of "or die" statements, hopefully catching all
3034            possible cases where failure could still exit(0).
3035
3036 2009-10-27  Eric Seidel  <eric@webkit.org>
3037
3038         Reviewed by Adam Barth.
3039
3040         svn-* scripts should share code through VCSUtils.pm
3041         https://bugs.webkit.org/show_bug.cgi?id=30791
3042
3043         Just moving code into a shared location.
3044
3045         * Scripts/VCSUtils.pm:
3046         * Scripts/prepare-ChangeLog:
3047         * Scripts/resolve-ChangeLogs:
3048         * Scripts/svn-apply:
3049         * Scripts/svn-create-patch:
3050         * Scripts/svn-unapply:
3051         * Scripts/update-webkit:
3052
3053 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
3054
3055         Suppress a huge number of MSVC warnings when building wxWebKit.
3056
3057         * wx/build/settings.py:
3058
3059 2009-10-26  Eric Seidel  <eric@webkit.org>
3060
3061         No review, just adding Mike Belshe to the committers list.
3062
3063         * Scripts/modules/committers.py:
3064
3065 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3066
3067         Reviewed by Darin Adler.
3068
3069         Make .rc files compile on Windows without depending on MFC headers
3070         https://bugs.webkit.org/show_bug.cgi?id=30750
3071
3072         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
3073         windows.h instead of afxres.h because it exists even when MFC is not 
3074         installed, and is all that's needed here.
3075
3076         * FindSafari/FindSafari.rc: Ditto
3077
3078 2009-10-24  Eric Seidel  <eric@webkit.org>
3079
3080         Reviewed by Adam Barth.
3081
3082         bugzilla-tool post-diff should know how to mark commit-queue=?
3083         https://bugs.webkit.org/show_bug.cgi?id=29202
3084
3085         * Scripts/bugzilla-tool:
3086          - Add --commit-queue option to post-diff, post-commits and create-bug.
3087         * Scripts/modules/bugzilla.py:
3088          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
3089          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
3090
3091 2009-10-23  Eric Seidel  <eric@webkit.org>
3092
3093         Reviewed by Adam Barth.
3094
3095         bugzilla-tool commit-queue does not notice modifications to committers.py
3096         https://bugs.webkit.org/show_bug.cgi?id=30084
3097
3098         * Scripts/bugzilla-tool:
3099          - Make commit-queue re-exec itself instead of using while(1).
3100          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
3101          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
3102
3103 2009-10-22  Eric Seidel  <eric@webkit.org>
3104
3105         Reviewed by Adam Barth.
3106
3107         commit-queue will get stuck on patches if land-patches terminates unexpectedly
3108         https://bugs.webkit.org/show_bug.cgi?id=30634
3109
3110         * Scripts/bugzilla-tool:
3111          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
3112          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
3113
3114 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
3115
3116         Reviewed by Eric Seidel.
3117
3118         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
3119
3120         https://bugs.webkit.org/show_bug.cgi?id=30763
3121
3122         * pywebsocket/mod_pywebsocket/__init__.py:
3123         * pywebsocket/mod_pywebsocket/dispatch.py:
3124         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
3125         * pywebsocket/mod_pywebsocket/standalone.py:
3126         * pywebsocket/setup.py:
3127         * pywebsocket/test/test_dispatch.py:
3128
3129 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
3130
3131         Reviewed by David Levin.
3132
3133         REGRESSION: 2 failures in run-webkit-unittests
3134         https://bugs.webkit.org/show_bug.cgi?id=30645
3135
3136         * Scripts/modules/cpp_style_unittest.py:
3137         Fixed a few test scenarios which apparently lost some spaces from 
3138         text literals.
3139
3140 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
3141
3142         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
3143
3144         * Scripts/webkitdirs.pm:
3145
3146 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
3147
3148         Reviewed by Darin Adler.
3149
3150         Unification of using null device in perl scripts.
3151         https://bugs.webkit.org/show_bug.cgi?id=30572
3152
3153         * Scripts/VCSUtils.pm:
3154         * Scripts/bisect-builds:
3155         * Scripts/resolve-ChangeLogs:
3156         * Scripts/run-iexploder-tests:
3157         * Scripts/run-jsc:
3158         * Scripts/run-mangleme-tests:
3159         * Scripts/run-webkit-tests:
3160         * Scripts/webkitdirs.pm:
3161         Using File::Spec->devnull() instead of hard coded /dev/null.
3162
3163 2009-10-26  Eric Seidel  <eric@webkit.org>
3164
3165         Reviewed by Holger Freyther.
3166
3167         Reviewers are missing from committers.py
3168         https://bugs.webkit.org/show_bug.cgi?id=30733
3169
3170         * Scripts/modules/committers.py:
3171
3172 2009-10-23  Eric Seidel  <eric@webkit.org>
3173
3174         No review, only adding Alice to the list of reviewers.
3175
3176         * Scripts/modules/committers.py:
3177
3178 2009-10-23  Eric Seidel  <eric@webkit.org>
3179
3180         Reviewed by Eric Carlson.
3181
3182         fast/media/mq-transform-02.html failed on Leopard Commit Bot
3183         https://bugs.webkit.org/show_bug.cgi?id=30700
3184
3185         * DumpRenderTree/mac/DumpRenderTree.mm:
3186         (resetDefaultsToConsistentValues): Update QuickTime version check.
3187
3188 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
3189
3190         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
3191         character measurement APIs that are private on Tiger.
3192
3193         * wx/build/settings.py:
3194
3195 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3196
3197         Reviewed by NOBODY (build fix).
3198         Build fix following bug #30696.
3199
3200         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3201         (LayoutTestController::evaluateScriptInIsolatedWorld):
3202
3203 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3204
3205         Reviewed by Sam Weinig & Geoff Garen.
3206
3207         https://bugs.webkit.org/show_bug.cgi?id=30696
3208         Enable isolated-worlds tests on mac.
3209
3210         Add private interface for DRT to invoke execution in a given world.
3211
3212         * DumpRenderTree/LayoutTestController.cpp:
3213         (evaluateScriptInIsolatedWorldCallback):
3214         (LayoutTestController::staticFunctions):
3215         * DumpRenderTree/LayoutTestController.h:
3216         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3217         (LayoutTestController::evaluateScriptInIsolatedWorld):
3218         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3219         (LayoutTestController::evaluateScriptInIsolatedWorld):
3220
3221 2009-10-21  Eric Seidel  <eric@webkit.org>
3222
3223         Reviewed by Adam Barth.
3224
3225         bugzilla-tool's "patch failed to download an apply" error should give more information
3226         https://bugs.webkit.org/show_bug.cgi?id=30632
3227
3228         * Scripts/modules/scm.py:
3229          - Use the common run_command method instead of custom POpen code.
3230          - Make run_command know how to take pipes as input.
3231         * Scripts/modules/scm_unittest.py:
3232          - Add new tests to cover change.
3233          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
3234
3235 2009-10-21  Kent Tamura  <tkent@chromium.org>
3236
3237         Unreviewed.  Adding myself to the committers list.
3238
3239         * Scripts/modules/committers.py:
3240
3241 2009-10-21  Robin Dunn  <robin@alldunn.com>
3242
3243         Reviewed by Kevin Ollivier.
3244
3245         Update the Windows installer builder to work with Vista / Win 7 and with git.
3246         
3247         https://bugs.webkit.org/show_bug.cgi?id=30649
3248
3249         * wx/build/build_utils.py:
3250         * wx/packaging/build-mac-installer.py:
3251         * wx/packaging/build-win-installer.py:
3252         * wx/packaging/wxWebKitInstaller.iss.in:
3253
3254 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3255
3256         Reviewed by Gustavo Noronha.
3257
3258         [GTK] Added conditional code to avoid using
3259         gdk_window_get_root_coords if we do not have a gtk+ release newer
3260         than 2.17.3.
3261         https://bugs.webkit.org/show_bug.cgi?id=30636
3262
3263         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3264
3265 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3266
3267         Reviewed by Eric Seidel.
3268
3269         [Qt] Added dummy implementation for keepWebHistory()
3270         https://bugs.webkit.org/show_bug.cgi?id=30592
3271
3272         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3273         (LayoutTestController::keepWebHistory):
3274         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3275
3276 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3277
3278         Reviewed by Xan Lopez.
3279
3280         [GTK] Fixed the double click condition, it is not double click if
3281         we move in just in one direction.
3282         https://bugs.webkit.org/show_bug.cgi?id=30636
3283
3284         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3285
3286 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3287
3288         Reviewed by Xan Lopez.
3289
3290         [GTK] Initialize the events completly before emitting them.
3291         https://bugs.webkit.org/show_bug.cgi?id=30633
3292
3293         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3294
3295 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3296
3297         wx build fix. Fix for when linking using --as-needed with gcc.
3298
3299         * wx/browser/wscript:
3300
3301 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3302
3303         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3304         to support all the features used by CURL backend.
3305         
3306         * wx/build/settings.py:
3307         * wx/install-unix-extras:
3308
3309 2009-10-20  Anton Muhin  <antonm@chromium.org>
3310
3311         Reviewed by Adam Barth.
3312
3313         Add {ager,antonm,yurys}@chromium.org into committers.py
3314         https://bugs.webkit.org/show_bug.cgi?id=30560
3315
3316         * Scripts/modules/committers.py:
3317
3318 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3319
3320         Reviewed by Tor Arne Vestbø.
3321
3322         Make the Netscape Test plugin available to the Qt launcher.
3323
3324         * Scripts/run-launcher:
3325
3326 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3327
3328         Reviewed by David Levin.
3329
3330         Removed WebSocket runtime settings.
3331         https://bugs.webkit.org/show_bug.cgi?id=29896
3332
3333         WebSocket runtime configuration is supported by chromium/v8 only.
3334
3335         * DumpRenderTree/mac/DumpRenderTree.mm:
3336         (resetDefaultsToConsistentValues):
3337         * DumpRenderTree/win/DumpRenderTree.cpp:
3338         (resetDefaultsToConsistentValues):
3339
3340 2009-10-19  Nate Chapin  <japhet@chromium.org>
3341
3342         Reviewed by Adam Barth.
3343
3344         Add testFail() to test plugin so we can test our handling of a
3345         plugin invoke call returning false.
3346
3347         https://bugs.webkit.org/show_bug.cgi?id=30239
3348
3349         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3350         (pluginInvoke):
3351         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3352
3353 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3354
3355         Reviewed by Gustavo Noronha.
3356
3357         Enable DOM pasting when running layout tests.
3358
3359         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3360         (resetDefaultsToConsistentValues):
3361
3362 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3363
3364         Reviewed by Simon Hausmann.
3365
3366         Use the setPreferredContentsSize method instead
3367         of setFixedContentsSize, as the method has been renamed.
3368
3369         * DumpRenderTree/qt/DumpRenderTree.cpp:
3370         (WebCore::DumpRenderTree::open):
3371         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3372         (LayoutTestController::setFixedContentsSize):
3373
3374 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3375
3376         Reviewed by Dan Bernstein.
3377
3378         https://bugs.webkit.org/show_bug.cgi?id=30456
3379         Fixes for new Debug_All Windows build configuration.
3380
3381         * DumpRenderTree/win/DumpRenderTree.cpp:
3382         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3383         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3384
3385 2009-10-16  Eric Seidel  <eric@webkit.org>
3386
3387         Reviewed by Adam Barth.
3388
3389         commit-queue status bot should list which buildbot is blocking the queue
3390         https://bugs.webkit.org/show_bug.cgi?id=30452
3391
3392         Add new methods and testing.
3393
3394         * Scripts/bugzilla-tool:
3395         * Scripts/modules/buildbot.py:
3396         * Scripts/modules/buildbot_unittest.py:
3397
3398 2009-10-16  Eric Seidel  <eric@webkit.org>
3399
3400         Reviewed by Adam Barth.
3401
3402         run-webkit-tests fails when CWD is not inside a WebKit checkout
3403         https://bugs.webkit.org/show_bug.cgi?id=30451
3404
3405         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3406         * Scripts/modules/scm_unittest.py:
3407           - Remove use of original_path (we don't need to restore the CWD).
3408           - Don't use '.' to find the webkit checkout, use __file__ instead.
3409
3410 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3411
3412         Reviewed by Adam Roben.
3413
3414         Add a Debug_All configuration to build entire stack as debug.
3415         Change Debug_Internal to:
3416         - stop using _debug suffix for all WebKit/Safari binaries
3417         - not use _debug as a DLL naming suffix
3418         - use non-debug C runtime lib.
3419
3420         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3421         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3422         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3423         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3424         Add missing debug.vsprops inherited property sheet.
3425         Add Debug_All configuration.
3426         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3427         * WinLauncher/WinLauncher.vcproj:
3428         Removed extraneous definitions inherited from vsprops.
3429         Add Debug_All configuration.
3430
3431 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3432
3433         Reviewed by David Levin.
3434
3435         check-webkit-style is wrong about indent checking in namespaces
3436         in header files and a few other things
3437         https://bugs.webkit.org/show_bug.cgi?id=30362
3438
3439         The few other things include:
3440         + check-webkit-style does not require spaces around the equal sign
3441           inside 'if' statements and around binary operators that take 
3442           numeric literals.
3443         + check-webkit-style reports false errors for the / operator
3444           when part of a filename in the #include directive.
3445
3446         * Scripts/modules/cpp_style.py:
3447         Improved indentation checking and space checking around
3448         binary operators. While the checks are still not perfect,
3449         they are clearly better than before.
3450         * Scripts/modules/cpp_style_unittest.py:
3451         Added test cases for the newly supported checks and modified old
3452         test cases to match the new guidelines
3453
3454 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3455
3456         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3457
3458         * wx/build/settings.py:
3459
3460 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3461
3462         Reviewed by David Levin.
3463
3464         Add mod_pywebsocket to test Web Sockets.
3465         http://code.google.com/p/pywebsocket/
3466         https://bugs.webkit.org/show_bug.cgi?id=27490
3467
3468         * pywebsocket/COPYING: Added.
3469         * pywebsocket/MANIFEST.in: Added.
3470         * pywebsocket/README: Added.
3471         * pywebsocket/example/echo_client.py: Added.
3472         * pywebsocket/example/echo_wsh.py: Added.
3473         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3474         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3475         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3476         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3477         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3478         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3479         * pywebsocket/mod_pywebsocket/util.py: Added.
3480         * pywebsocket/setup.py: Added.
3481         * pywebsocket/test/config.py: Added.
3482         * pywebsocket/test/mock.py: Added.
3483         * pywebsocket/test/run_all.py: Added.
3484         * pywebsocket/test/test_dispatch.py: Added.
3485         * pywebsocket/test/test_handshake.py: Added.
3486         * pywebsocket/test/test_mock.py: Added.
3487         * pywebsocket/test/test_msgutil.py: Added.
3488         * pywebsocket/test/test_util.py: Added.
3489         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3490         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3491         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3492         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3493         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3494         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3495         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3496         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3497
3498 2009-10-15  James Robinson  <jamesr@google.com>
3499
3500         Reviewed by David Levin.
3501
3502         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3503
3504         https://bugs.webkit.org/show_bug.cgi?id=30426
3505
3506         * Scripts/modules/cpp_style.py:
3507         * Scripts/modules/cpp_style_unittest.py:
3508
3509 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3510
3511         Reviewed by Adam Roben.
3512
3513         Fixes <http://webkit.org/b/30411>.
3514         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3515         
3516         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3517         building Chromium.
3518
3519         * Scripts/pdevenv:
3520
3521 2009-10-15  Robin Dunn  <robin@alldunn.com>
3522
3523         Reviewed by Kevin Ollivier.
3524
3525         Add Mac package building scripts for wx.
3526         
3527         https://bugs.webkit.org/show_bug.cgi?id=30405
3528
3529         * wx/build/build_utils.py:
3530         * wx/build/settings.py:
3531         * wx/packaging/build-mac-installer.py: Added.
3532
3533 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3534
3535         Reviewed by Gustavo Noronha.
3536
3537         Enable Web Sockets support when running layout tests.
3538
3539         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3540         (resetDefaultsToConsistentValues):
3541
3542 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3543
3544         Reviewed by Gustavo Noronha.
3545
3546         Need to initialize event.button.button, since in most cases a
3547         button number is not passed as an argument.
3548
3549         * DumpRenderTree/gtk/EventSender.cpp:
3550         (mouseDownCallback):
3551         (mouseUpCallback):
3552
3553 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3554
3555         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3556         the OS if none was explicitly set.
3557
3558         * wx/build/settings.py:
3559
3560 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3561
3562         Reviewed by Timothy Hatcher.
3563
3564         Web Inspector: enable developers extras within inspector layout tests.
3565
3566         https://bugs.webkit.org/show_bug.cgi?id=30014
3567
3568         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3569         (LayoutTestController::showWebInspector):
3570         (LayoutTestController::closeWebInspector):
3571         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3572         (LayoutTestController::showWebInspector):
3573         (LayoutTestController::closeWebInspector):
3574
3575 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3576
3577         Reviewed by Jan Alonzo.
3578
3579         GtkLauncher is using a deprecated signal
3580         https://bugs.webkit.org/show_bug.cgi?id=30364
3581
3582         Modified GtkLauncher to use notify::title signal instead of
3583         deprecated title-changed signal
3584
3585         * GtkLauncher/main.c:
3586         (notify_title_cb):
3587         (create_browser):
3588
3589 2009-10-14  Brady Eidson  <beidson@apple.com>
3590
3591         Reviewed by Sam Weinig.
3592
3593         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3594         1 - Disables WebHistory
3595         2 - Doesn't make sense in that context anyway.
3596
3597         * DumpRenderTree/win/DumpRenderTree.cpp:
3598         (createWebViewAndOffscreenWindow):
3599
3600 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3601
3602         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3603         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3604
3605         * wx/build/settings.py:
3606         * wx/install-unix-extras:
3607
3608 2009-10-14  Brady Eidson  <beidson@apple.com>
3609
3610         Reviewed by Sam Weinig.
3611
3612         WebKit Win API should provide a delegate interface for global history.
3613         https://bugs.webkit.org/show_bug.cgi?id=29905
3614
3615         * DumpRenderTree/LayoutTestController.cpp:
3616         (LayoutTestController::LayoutTestController):
3617         * DumpRenderTree/LayoutTestController.h:
3618         (LayoutTestController::dumpHistoryDelegateCallbacks):
3619         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3620                 
3621         * DumpRenderTree/win/DumpRenderTree.cpp:
3622         (shouldLogHistoryDelegates):
3623         (runTest):
3624         (createWebViewAndOffscreenWindow):
3625         (main):
3626         * DumpRenderTree/win/DumpRenderTree.vcproj:
3627         
3628         Add the IWebHistoryDelegate to DRT Windows:
3629         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3630         (wstringFromBSTR):
3631         (HistoryDelegate::HistoryDelegate):
3632         (HistoryDelegate::~HistoryDelegate):
3633         (HistoryDelegate::QueryInterface):
3634         (HistoryDelegate::AddRef):
3635         (HistoryDelegate::Release):
3636         (HistoryDelegate::didNavigateWithNavigationData):
3637         (HistoryDelegate::didPerformClientRedirectFromURL):
3638         (HistoryDelegate::didPerformServerRedirectFromURL):
3639         (HistoryDelegate::updateHistoryTitle):
3640         (HistoryDelegate::populateVisitedLinksForWebView):
3641         * DumpRenderTree/win/HistoryDelegate.h: Added.
3642
3643         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3644         (LayoutTestController::removeAllVisitedLinks):
3645
3646 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3647
3648         Reviewed by Simon Hausmann.
3649
3650         [Qt] Implement support for setPOSIXLocale on Qt.
3651         https://bugs.webkit.org/show_bug.cgi?id=30268 
3652  
3653         * DumpRenderTree/qt/DumpRenderTree.cpp:
3654         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3655         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3656         (LayoutTestController::setPOSIXLocale):
3657         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3658
3659 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3660
3661         Unreviewed, adding myself to reviewers list.
3662
3663         * Scripts/modules/committers.py:
3664
3665 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3666
3667         Reviewed by Mark Rowe.
3668
3669         Fix null assignment so root tests work again.
3670
3671         * Scripts/webkitdirs.pm:
3672
3673 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3674
3675         Reviewed by Simon Hausmann.
3676
3677         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3678         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3679         This is done in preparation of implementing missing features in DRT.
3680         No functionality changes made yet.
3681
3682         * DumpRenderTree/qt/DumpRenderTree.cpp:
3683         * DumpRenderTree/qt/DumpRenderTree.pro:
3684         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3685         (EventSender::EventSender):
3686         (EventSender::mouseDown):
3687         (EventSender::mouseUp):
3688         (EventSender::mouseMoveTo):
3689         (EventSender::leapForward):
3690         (EventSender::keyDown):
3691         (EventSender::contextClick):
3692         (EventSender::scheduleAsynchronousClick):
3693         (EventSender::frameUnderMouse):
3694         * DumpRenderTree/qt/EventSenderQt.h: Added.
3695         (EventSender::clearKillRing):
3696         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3697         (LayoutTestController::LayoutTestController):
3698         (LayoutTestController::reset):
3699         (LayoutTestController::processWork):
3700         (LayoutTestController::maybeDump):
3701         (LayoutTestController::waitUntilDone):
3702         (LayoutTestController::notifyDone):
3703         (LayoutTestController::windowCount):
3704         (LayoutTestController::clearBackForwardList):
3705         (LayoutTestController::dumpEditingCallbacks):
3706         (LayoutTestController::dumpResourceLoadCallbacks):
3707         (LayoutTestController::queueBackNavigation):
3708         (LayoutTestController::queueForwardNavigation):
3709         (LayoutTestController::queueLoad):
3710         (LayoutTestController::queueReload):
3711         (LayoutTestController::queueScript):
3712         (LayoutTestController::provisionalLoad):
3713         (LayoutTestController::timerEvent):
3714         (LayoutTestController::encodeHostName):
3715         (LayoutTestController::decodeHostName):
3716         (LayoutTestController::setJavaScriptProfilingEnabled):
3717         (LayoutTestController::setFixedContentsSize):
3718         (LayoutTestController::setPrivateBrowsingEnabled):
3719         (LayoutTestController::setPopupBlockingEnabled):
3720         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3721         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3722         (LayoutTestController::numberOfActiveAnimations):
3723         (LayoutTestController::disableImageLoading):
3724         (LayoutTestController::dispatchPendingLoadRequests):
3725         (LayoutTestController::setDatabaseQuota):
3726         (LayoutTestController::clearAllDatabases):
3727         (LayoutTestController::whiteListAccessFromOrigin):
3728         (LayoutTestController::waitForPolicyDelegate):
3729         (LayoutTestController::overridePreference):
3730         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3731         (LayoutTestController::isLoading):
3732         (LayoutTestController::setLoading):
3733         (LayoutTestController::shouldDumpAsText):
3734         (LayoutTestController::shouldDumpBackForwardList):
3735         (LayoutTestController::shouldDumpChildrenAsText):
3736         (LayoutTestController::shouldDumpDatabaseCallbacks):
3737         (LayoutTestController::shouldDumpStatusCallbacks):
3738         (LayoutTestController::shouldWaitUntilDone):
3739         (LayoutTestController::canOpenWindows):
3740         (LayoutTestController::shouldDumpTitleChanges):
3741         (LayoutTestController::waitForPolicy):
3742         (LayoutTestController::dumpAsText):
3743         (LayoutTestController::dumpChildFramesAsText):
3744         (LayoutTestController::dumpDatabaseCallbacks):
3745         (LayoutTestController::dumpStatusCallbacks):
3746         (LayoutTestController::setCanOpenWindows):
3747         (LayoutTestController::dumpBackForwardList):
3748         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3749         (LayoutTestController::display):
3750         (LayoutTestController::dumpTitleChanges):
3751         (LayoutTestController::dumpSelectionRect):
3752         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3753         (TextInputController::TextInputController):
3754         (TextInputController::doCommand):
3755         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3756         * DumpRenderTree/qt/WorkQueue.cpp:
3757         * DumpRenderTree/qt/WorkQueue.h:
3758         * DumpRenderTree/qt/WorkQueueItem.h:
3759         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3760         (findFrameNamed):
3761         (LoadItem::invoke):
3762         (ReloadItem::invoke):
3763         (ScriptItem::invoke):
3764         (BackForwardItem::invoke):
3765         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3766         * DumpRenderTree/qt/jsobjects.h:
3767
3768 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3769
3770         Not reviewed, adding myself to the list of reviewers.
3771
3772         * Scripts/modules/committers.py:
3773
3774 2009-10-13  Anders Carlsson  <andersca@apple.com>
3775
3776         Reviewed by Sam Weinig.
3777
3778         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3779
3780         Make the private browsing mode testable by the test plug-in.
3781         
3782         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3783         (pluginGetProperty):
3784         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3785         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3786         (NPP_New):
3787         (NPP_SetValue):
3788
3789 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3790
3791         No review, just adding self to the list of reviewers.
3792
3793         * Scripts/modules/committers.py:
3794
3795 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3796
3797         Reviewed by Adam Roben.
3798
3799         Web Inspector: Use proper web view in inspector layout
3800         tests for windows.
3801
3802         https://bugs.webkit.org/show_bug.cgi?id=30298
3803
3804         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3805         (LayoutTestController::showWebInspector):
3806         (LayoutTestController::closeWebInspector):
3807         (LayoutTestController::evaluateInWebInspector):
3808
3809 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3810
3811         Reviewed by Sam Weinig.
3812
3813         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3814         https://bugs.webkit.org/show_bug.cgi?id=29841
3815
3816         * DumpRenderTree/mac/DumpRenderTree.mm:
3817         (resetDefaultsToConsistentValues):
3818         * DumpRenderTree/win/DumpRenderTree.cpp:
3819         (resetDefaultsToConsistentValues):
3820
3821 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3822
3823         Reviewed by Dimitri Glazkov.
3824
3825         Chromium Port - Windows
3826         https://bugs.webkit.org/show_bug.cgi?id=29969
3827
3828         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3829         * Scripts/webkitdirs.pm:
3830
3831 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3832
3833         Reviewed by Darin Adler.
3834
3835         jsc scripts cleanup and Qt/GTK fix
3836         https://bugs.webkit.org/show_bug.cgi?id=30288
3837
3838         Duplicated jscPath() moved to webkitdirs.pm.
3839         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3840         Configuration added (release/debug) to path for Qt-port on Windows.
3841
3842         * Scripts/run-javascriptcore-tests:
3843         * Scripts/run-jsc:
3844         * Scripts/run-sunspider:
3845         * Scripts/sunspider-compare-results:
3846         * Scripts/webkitdirs.pm:
3847
3848 2009-10-11  Adam Barth  <abarth@webkit.org>
3849
3850         Unreviewed.  Add Collin to committers.py.
3851
3852         * Scripts/modules/committers.py:
3853
3854 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3855
3856         wx build fix, add bindings to source/include dirs now that there are sources there.
3857
3858         * wx/build/settings.py:
3859
3860 2009-10-09  Mark Rowe  <mrowe@apple.com>
3861
3862         Reviewed by Brady Eidson.
3863
3864         Enable plug-in halting in DumpRenderTree.
3865
3866         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3867         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3868
3869         * DumpRenderTree/mac/DumpRenderTree.mm:
3870         (resetDefaultsToConsistentValues):
3871         * DumpRenderTree/mac/UIDelegate.mm:
3872         (-[UIDelegate webView:shouldHaltPlugin:]):
3873
3874 2009-10-08  Brady Eidson  <beidson@apple.com>
3875
3876         Reviewed by Dan Bernstein.
3877
3878         Ask the History Delegate to populate the visited links hash.
3879         <rdar://problem/7285293> and https://webkit.org/b/29904
3880
3881         Add the ability for LayoutTestController to clear all visited links.
3882         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3883
3884         * DumpRenderTree/LayoutTestController.cpp:
3885         (LayoutTestController::LayoutTestController):
3886         (removeAllVisitedLinksCallback):
3887         (LayoutTestController::staticFunctions):
3888         * DumpRenderTree/LayoutTestController.h:
3889         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3890         (LayoutTestController::removeAllVisitedLinks):
3891
3892         * DumpRenderTree/mac/HistoryDelegate.mm:
3893         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3894
3895         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3896         (LayoutTestController::removeAllVisitedLinks):
3897         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3898         (LayoutTestController::removeAllVisitedLinks):
3899         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3900         (LayoutTestController::removeAllVisitedLinks):
3901
3902
3903 2009-10-08  Daniel Bates  <dbates@webkit.org>
3904
3905         Reviewed by Adam Roben.
3906
3907         https://bugs.webkit.org/show_bug.cgi?id=30175
3908         
3909         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3910         the OLE drag-and-drop return value like the function it emulates. Currently, 
3911         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3912         whether the drag-and-drop operation was successful or was cancelled.
3913         
3914         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3915         return value according to whether the drop operation was successful or not.
3916
3917         * DumpRenderTree/win/EventSender.cpp:
3918         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3919         (replaySavedEvents): Ditto.
3920         * DumpRenderTree/win/EventSender.h:
3921         * DumpRenderTree/win/UIDelegate.cpp:
3922         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3923
3924 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3925
3926         Reviewed by Xan Lopez.
3927
3928         [GTK] Added support for a parameter setting the button that was
3929         pressed in the mouseDown function.
3930         https://bugs.webkit.org/show_bug.cgi?id=30220
3931
3932         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3933
3934 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3935
3936         Reviewed by Xan Lopez.
3937
3938         [GTK] Added a line to the bottom of the expected result to match
3939         the output of the test.
3940         https://bugs.webkit.org/show_bug.cgi?id=30220
3941
3942         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3943         expected.txt:
3944
3945 2009-10-08  Adam Roben  <aroben@apple.com>
3946
3947         Use QueryInterface to get IWebInspectorPrivate
3948
3949         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3950         accessed in a more standard way
3951
3952         Reviewed by John Sullivan and Tim Hatcher.
3953
3954         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3955         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3956         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3957         to the IWebInspectorPrivate interface.
3958
3959 2009-10-07  Adam Roben  <aroben@apple.com>
3960
3961         Implement DRT support for origin whitelisting
3962
3963         Fixes <http://webkit.org/b/30185>.
3964
3965         Reviewed by Eric Seidel.
3966
3967         * DumpRenderTree/win/DumpRenderTree.cpp:
3968         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3969         whitelist, to match Mac DRT.
3970         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3971         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3972         IWebViewPrivate::whiteListAccessFromOrigin.
3973
3974 2009-10-07  Brady Eidson  <beidson@apple.com>
3975
3976         Reviewed by Darin Adler.
3977
3978         Send title changes to the global history delegate.
3979         <rdar://problem/7285293> and https://webkit.org/b/29904
3980
3981         * DumpRenderTree/mac/HistoryDelegate.mm:
3982         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3983
3984 2009-10-07  Adam Barth  <abarth@webkit.org>
3985
3986         Unreviewed.  Remove some folks from committers.py who were listed on
3987         the WebKit Team wiki page but who weren't actually listed as commit+.
3988         At some point, we should coorelate this list with the committers
3989         mailing list.
3990
3991         * Scripts/modules/committers.py:
3992
3993 2009-10-07  Adam Barth  <abarth@webkit.org>
3994
3995         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3996         the wiki into committers.py.
3997
3998         * Scripts/modules/committers.py:
3999
4000 2009-10-07  Adam Barth  <abarth@webkit.org>
4001
4002         Unreviewed.  Added Aaron Boodman to committers.py.
4003
4004         * Scripts/modules/committers.py:
4005
4006 2009-10-07  Evan Martin  <evan@chromium.org>
4007
4008         Reviewed by Darin Adler.
4009
4010         Add API to LayoutTestController for re/setting the system locale.
4011         https://bugs.webkit.org/show_bug.cgi?id=18994
4012
4013         * DumpRenderTree/LayoutTestController.cpp:
4014         (setLocaleCallback):
4015         (LayoutTestController::staticFunctions):
4016         (LayoutTestController::setLocale):
4017         * DumpRenderTree/LayoutTestController.h:
4018
4019 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
4020
4021         Reviewed by Jan Alonzo.
4022
4023         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
4024         https://bugs.webkit.org/show_bug.cgi?id=29689
4025
4026         Build fix by adding -lfontconfig for DumpRenderTree.
4027
4028         * GNUmakefile.am:
4029
4030 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
4031
4032         Reviewed by Simon Hausmann.
4033
4034         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
4035
4036         * Scripts/run-webkit-tests:
4037
4038 2009-10-07  Xan Lopez  <xlopez@igalia.com>
4039
4040         Reviewed by Gustavo Noronha.
4041
4042         "delete" in EventSender is the backspace key, not the delete one.
4043
4044         * DumpRenderTree/gtk/EventSender.cpp:
4045         (keyDownCallback):
4046
4047 2009-10-07  Xan Lopez  <xlopez@igalia.com>
4048
4049         Reviewed by Gustavo Noronha.
4050
4051         getChildrenWithRange expects as last parameter the end index, not
4052         the length of the range. Correct this and clarify the variable
4053         names to reflect how the code works.
4054
4055         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4056         (AccessibilityUIElement::getChildrenWithRange):
4057         (AccessibilityUIElement::getChildAtIndex):
4058
4059 2009-10-06  Mark Rowe  <mrowe@apple.com>
4060
4061         Reviewed by Simon Fraser.
4062
4063         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
4064
4065         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
4066         the fact we have already changed the working directory to the top of the open source tree.
4067
4068 2009-10-06  Julie Parent  <jparent@chromium.org>
4069
4070         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
4071         rather than my committer email.
4072
4073         * Scripts/modules/committers.py:
4074
4075 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4076
4077         Reviewed by Eric Seidel.
4078
4079         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
4080
4081         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
4082         it after each layout test as it should do, making the DRT dump additional output
4083         for all of the subsequent layout tests.
4084
4085         * DumpRenderTree/qt/jsobjects.cpp:
4086         (LayoutTestController::reset):
4087
4088 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4089
4090         Reviewed by Simon Hausmann.
4091
4092         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
4093         fast/dom/assign-to-window-status.html test, which is passing as a result.
4094
4095         https://bugs.webkit.org/show_bug.cgi?id=30127
4096
4097         * DumpRenderTree/qt/DumpRenderTree.cpp:
4098         (WebCore::DumpRenderTree::DumpRenderTree):
4099         (WebCore::DumpRenderTree::statusBarMessage):
4100         * DumpRenderTree/qt/DumpRenderTree.h:
4101         * DumpRenderTree/qt/jsobjects.h:
4102         (LayoutTestController::shouldDumpStatusCallbacks):
4103         (LayoutTestController::dumpStatusCallbacks):
4104
4105 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4106
4107         Reviewed by Simon Hausmann.
4108
4109         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
4110         ignores the argument indicating which mouse button to trigger.
4111         https://bugs.webkit.org/show_bug.cgi?id=30048
4112
4113         This affects the fast/events/mouse-click-events.html layout test.
4114
4115         * DumpRenderTree/qt/jsobjects.cpp:
4116         (EventSender::mouseDown):
4117         (EventSender::mouseUp):
4118         * DumpRenderTree/qt/jsobjects.h:
4119
4120 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4121
4122         Reviewed by Simon Hausmann.
4123
4124         [Qt] Fix the EventSender::keyDown() implementation
4125         https://bugs.webkit.org/show_bug.cgi?id=30043
4126
4127         It should post both a key press event and a key release event,
4128         just like other ports do.
4129
4130         * DumpRenderTree/qt/jsobjects.cpp:
4131         (EventSender::keyDown):
4132
4133 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
4134
4135         wx build fix. Add jpeg to the list of libs to link against.
4136
4137         * wx/build/settings.py:
4138
4139 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
4140
4141         Reviewed by Simon Hausmann.
4142
4143         [Qt] EventSender::keyDown() cannot send function-key events.
4144         https://bugs.webkit.org/show_bug.cgi?id=30044
4145
4146         This affects the fast/events/keydown-function-keys.html layout test.
4147
4148         * DumpRenderTree/qt/jsobjects.cpp:
4149         (EventSender::keyDown):
4150
4151 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
4152
4153         Added --wx-compiler-prefix waf option to allow building wxWebKit with
4154         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
4155
4156         * wx/build/settings.py:
4157         * wx/build/wxpresets.py:
4158
4159 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
4160
4161         Reviewed by Timothy Hatcher.
4162
4163         Web Inspector: add testing harness for Web Inspector.
4164
4165         https://bugs.webkit.org/show_bug.cgi?id=30010
4166
4167         * DumpRenderTree/LayoutTestController.cpp:
4168         (showWebInspectorCallback):
4169         (closeWebInspectorCallback):
4170         (evaluateInWebInspectorCallback):
4171         (LayoutTestController::staticFunctions):
4172         * DumpRenderTree/LayoutTestController.h:
4173         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4174         (LayoutTestController::showWebInspector):
4175         (LayoutTestController::closeWebInspector):
4176         (LayoutTestController::evaluateInWebInspector):
4177         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4178         (LayoutTestController::showWebInspector):
4179         (LayoutTestController::closeWebInspector):
4180         (LayoutTestController::evaluateInWebInspector):
4181         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4182         (LayoutTestController::showWebInspector):
4183         (LayoutTestController::closeWebInspector):
4184         (LayoutTestController::evaluateInWebInspector):
4185         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4186         (LayoutTestController::showWebInspector):
4187         (LayoutTestController::closeWebInspector):
4188         (LayoutTestController::evaluateInWebInspector):
4189
4190 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4191
4192         Reviewed by Ariyha Hidayat.
4193
4194         Pass arguments to system() as a string instead of array
4195
4196         When passed as an array entries with a space fail to translate
4197         to two arguments to the child process, so instead of manually
4198         splitting all the entries in @buildArgs we pass the whole thing
4199         as a string instead.
4200
4201         * Scripts/webkitdirs.pm:
4202
4203 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
4204
4205         Reviewed by David Levin.
4206
4207         check-webkit-style misses whitespace errors for operators:
4208         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
4209         https://bugs.webkit.org/show_bug.cgi?id=30021
4210
4211         * Scripts/modules/cpp_style.py:
4212         Added the operators mentioned above to the same list as == and !=.
4213
4214 2009-10-02  Julie Parent  <jparent@chromium.org>
4215
4216         Unreviewed.
4217
4218         Adding myself and Ojan Vafai as committers, because we are committers.
4219
4220         * Scripts/modules/committers.py:
4221
4222 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
4223
4224         Reviewed by Adam Roben.
4225
4226         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
4227         this will help the patch merging process when TryBots are used.
4228
4229         * Scripts/svn-create-patch:
4230
4231 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
4232
4233         Reviewed by Simon Hausmann.
4234
4235         [Qt] Implement layoutTestController.overridePreference().
4236         https://bugs.webkit.org/show_bug.cgi?id=29970
4237
4238         * DumpRenderTree/qt/DumpRenderTree.cpp:
4239         (WebCore::WebPage::WebPage):
4240         (WebCore::WebPage::resetSettings):
4241         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4242         * DumpRenderTree/qt/jsobjects.cpp:
4243         (LayoutTestController::reset):
4244         (LayoutTestController::setPrivateBrowsingEnabled):
4245         (LayoutTestController::setPopupBlockingEnabled):
4246         (LayoutTestController::overridePreference):
4247         * DumpRenderTree/qt/jsobjects.h:
4248
4249 2009-10-01  Chris Marrin  <cmarrin@apple.com>
4250
4251         Reviewed by Oliver Hunt.
4252
4253         Turn on ENABLE_3D_CANVAS in TOT
4254         https://bugs.webkit.org/show_bug.cgi?id=29906
4255
4256         * Scripts/build-webkit:
4257
4258 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4259
4260         Rubberstamped by Simon Hausmann.
4261
4262         Enable HTTP tests for Qt
4263
4264         * Scripts/run-webkit-tests:
4265
4266 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
4267
4268         Reviewed by Dimitri Glazkov.
4269
4270         build-webkit --chromium now also works on cygwin.
4271
4272         https://bugs.webkit.org/show_bug.cgi?id=29973
4273
4274         * Scripts/webkitdirs.pm:
4275
4276 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
4277
4278         Reviewed by Simon Hausmann.
4279
4280         [Qt] Don't use TCmalloc in DumpRenderTree
4281         https://bugs.webkit.org/show_bug.cgi?id=27029
4282
4283         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
4284
4285         * DumpRenderTree/qt/DumpRenderTree.pro:
4286
4287 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
4288
4289         Reviewed by Simon Hausmann.
4290
4291         [Qt] Implement eventSender.scheduleAsynchronousClick().
4292
4293         https://bugs.webkit.org/show_bug.cgi?id=29931
4294
4295         * DumpRenderTree/qt/jsobjects.cpp:
4296         (EventSender::scheduleAsynchronousClick):
4297         * DumpRenderTree/qt/jsobjects.h:
4298
4299 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
4300
4301         Reviewed by Simon Hausmann.
4302
4303         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
4304         fast/events/open-window-from-another-frame.html from the Skipped list.
4305
4306         https://bugs.webkit.org/show_bug.cgi?id=29930
4307
4308         * DumpRenderTree/qt/jsobjects.cpp:
4309         (LayoutTestController::setPopupBlockingEnabled):
4310         * DumpRenderTree/qt/jsobjects.h:
4311
4312 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
4313
4314         Unreviewed.
4315
4316         Added myself to the list of committers.
4317
4318         * Scripts/modules/committers.py:
4319
4320 2009-09-30  Eric Seidel  <eric@webkit.org>
4321
4322         No review, just adding Geoff to the list of reviewers.
4323
4324         * Scripts/modules/committers.py:
4325
4326 2009-09-30  Dan Bernstein  <mitz@apple.com>
4327
4328         Reviewed by Sam Weinig.
4329
4330         Added the WebKit Layout Tests fonts that are referenced in
4331         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
4332
4333         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
4334         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
4335
4336 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
4337
4338         Reviewed by David Kilzer.
4339
4340         Make sunspider scripts work on Windows platform.
4341         https://bugs.webkit.org/show_bug.cgi?id=29656
4342
4343         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
4344         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
4345         * Scripts/webkitdirs.pm: currentPerlPath() added.
4346
4347 2009-09-29  Brady Eidson  <beidson@apple.com>
4348
4349         Rubberstamped by Dan Bernstein.
4350
4351         Fix license and some sorting in new files.
4352
4353         * DumpRenderTree/mac/HistoryDelegate.h:
4354         * DumpRenderTree/mac/HistoryDelegate.mm:
4355
4356 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
4357
4358         Reviewed by David Kilzer.
4359
4360         Fixed how error codes are handled.
4361         https://bugs.webkit.org/show_bug.cgi?id=29898
4362
4363         * Scripts/update-webkit:
4364         * Scripts/update-webkit-chromium:
4365
4366 2009-09-29  Brady Eidson  <beidson@apple.com>
4367
4368         Reviewed by John Sullivan.
4369
4370         Updated way-out-of-date sorting throughout the dump methods/flags.
4371
4372         * DumpRenderTree/LayoutTestController.cpp:
4373         (LayoutTestController::LayoutTestController):
4374         (dumpAsPDFCallback):
4375