WebKitTools/ChangeLog

   1 2009-03-02  Sam Weinig  <sam@webkit.org>
   2
   3         Reviewed by Mark Rowe.
   4
   5         Enable Geolocation (except on Tiger and Leopard).
   6
   7         * Scripts/build-webkit:
   8
   9 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
  10
  11         Build fixes for wxWidgets Mac trunk build.
  12
  13         * wx/build-wxwebkit:
  14
  15 2009-03-02  Timothy Hatcher  <timothy@apple.com>
  16
  17         Allow for multiline quoted text in JavaScript files when looking for function names.
  18
  19         https://bugs.webkit.org/show_bug.cgi?id=24296
  20
  21         Reviewed by David Kilzer.
  22
  23         * Scripts/prepare-ChangeLog:
  24
  25 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
  26
  27         Reviewed by Eric Seidel.
  28
  29         Add three new drt helper functions that enable all of the tests in
  30         LayoutTests/animation/* and LayoutTests/transitions/* to now pass.
  31
  32         * DumpRenderTree/qt/jsobjects.cpp:
  33         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
  34         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
  35         (LayoutTestController::numberOfActiveAnimations):
  36         * DumpRenderTree/qt/jsobjects.h:
  37
  38 2009-03-02  Adam Roben  <aroben@apple.com>
  39
  40         Windows build fix after r41349
  41
  42         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  43         (AccessibilityUIElement::getChildrenWithRange):
  44
  45 2009-03-01  Chris Fleizach  <cfleizach@apple.com>
  46
  47         Reviewed by Oliver Hunt.
  48
  49         Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
  50
  51         Change getChildAtIndex() to get a range of children instead of all the children.
  52         This exercises code in WebCore that returns elements when asked for from a range.
  53
  54         * DumpRenderTree/AccessibilityUIElement.h:
  55         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  56         (AccessibilityUIElement::getChildrenWithRange):
  57         (AccessibilityUIElement::getChildAtIndex):
  58         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  59         (AccessibilityUIElement::getChildrenWithRange):
  60
  61 2009-03-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
  62
  63         Reviewed by Holger Freyther.
  64
  65          [Gtk] get the HTTP layout tests going
  66          https://bugs.webkit.org/show_bug.cgi?id=24259
  67
  68         Determine the frame's response and decide whether to dump as text
  69         or the render tree
  70
  71         * DumpRenderTree/gtk/DumpRenderTree.cpp:
  72         (dump):
  73
  74 2009-03-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
  75
  76         Reviewed by Holger Freyther.
  77
  78         [Gtk] get the HTTP layout tests going
  79         https://bugs.webkit.org/show_bug.cgi?id=24259
  80
  81          Implement dumping of WebKitWebBackForwardList and its history
  82          items.
  83
  84         * DumpRenderTree/gtk/DumpRenderTree.cpp:
  85         (compareHistoryItems):
  86         (dumpHistoryItem):
  87         (dumpBackForwardListForWebView):
  88         (dump):
  89         (runTest):
  90         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  91         (LayoutTestController::clearBackForwardList):
  92         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
  93         (BackForwardItem::invoke):
  94
  95 2009-02-28  Zan Dobersek  <zandobersek@gmail.com>
  96
  97          Reviewed by Holger Freyther.
  98
  99          Set the resolution for the default screen to 72.0.
 100          This way, setting font sizes results in expected values.
 101
 102          * DumpRenderTree/gtk/DumpRenderTree.cpp:
 103          (setDefaultsToConsistentStateValuesForTesting):
 104
 105 2009-02-28  Gustavo Noronha Silva  <gns@gnome.org>
 106
 107         Reviewed by Holger Freyther.
 108
 109         Adds a WebKitMakeArguments environment variable to enable passing
 110         of arguments such as '-j2' to make for the autotools build.
 111
 112         * Scripts/webkitdirs.pm:
 113
 114 2009-02-28  Gustavo Noronha Silva  <gns@gnome.org>
 115
 116         Reviewed by Holger Freyther.
 117
 118         Add a GTK+-only option to enable GNOME Keyring when building.
 119
 120         * Scripts/build-webkit:
 121
 122 2009-02-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
 123
 124         Reviewed by Holger Freyther.
 125
 126         [Gtk] webkitdirs.pm modify path in when detecting 3D transforms and accelerated compositing
 127         https://bugs.webkit.org/show_bug.cgi?id=24076
 128
 129         Refactor gtk lib detection and put it in builtDylibPathForName
 130
 131         * Scripts/webkitdirs.pm:
 132
 133 2009-02-28  Christian Dywan  <christian@twotoasts.de>
 134
 135         Rubber-stamped by Holger Freyther.
 136
 137         * GtkLauncher/main.c:
 138         (activate_uri_entry_cb):
 139         (main): Use the new webkit_web_view_load_uri to open URIs.
 140
 141 2009-02-27  Xan Lopez  <xan@gnome.org>
 142
 143         Rubber-stamped by Alexey Proskuryakov.
 144
 145         https://bugs.webkit.org/show_bug.cgi?id=24222
 146         [GTK] Remove checks for old glib versions
 147
 148         libsoup, which is a hard dependency, needs at least glib 2.15.3,
 149         so remove all glib checks for versions older than that.
 150
 151         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 152         (LayoutTestController::setWaitToDump):
 153
 154 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
 155
 156         Reviewed by Eric Seidel
 157
 158         Fix spew about a WebView being deallocated while key value observers are
 159         still registered with it by making sure that we always stop observing
 160         _isUsingAcceleratedCompositing in -[DumpRenderTreeWindow close].
 161
 162         * DumpRenderTree/mac/DumpRenderTree.mm:
 163         (dumpRenderTree):
 164         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
 165         (-[DumpRenderTreeWindow close]):
 166
 167 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
 168
 169         Reviewed by Alexey Proskuryakov.
 170
 171         Do not queue the calls to 'DumpRenderTree::dump()' as this can result
 172         in more than one call as a test that calls 'notifyDone()' can then be
 173         subsequently fully loaded and initiate a second dump.  Also make sure
 174         to stop any existing page load that is happening before running the next
 175         test.  Combined this serves to produce 217 more passing tests for the
 176         Qt port or roughly 5% at this point.
 177
 178         * DumpRenderTree/qt/DumpRenderTree.cpp:
 179         (WebCore::DumpRenderTree::DumpRenderTree):
 180         (WebCore::DumpRenderTree::open):
 181
 182 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
 183
 184         Reviewed by Dan Bernstein
 185
 186         https://bugs.webkit.org/show_bug.cgi?id=23854
 187
 188         Have the DumpRenderTreeWindow observe the -_isUsingAcceleratedCompositing
 189         property of the WebView, and use that to turn -autodisplay on and off.
 190         This is necessary so that accelerated animations start correctly.
 191         We can thus remove the -display hack in createBitmapContextFromWebView().
 192
 193         * DumpRenderTree/mac/DumpRenderTree.mm:
 194         (createWebViewAndOffscreenWindow):
 195         (dumpRenderTree):
 196         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
 197         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
 198         (-[DumpRenderTreeWindow close]):
 199         (-[DumpRenderTreeWindow webView]):
 200         (-[DumpRenderTreeWindow startObservingWebView]):
 201         (-[DumpRenderTreeWindow stopObservingWebView]):
 202         (-[DumpRenderTreeWindow observeValueForKeyPath:ofObject:change:context:]):
 203         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
 204         (createBitmapContextFromWebView):
 205
 206 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
 207
 208         Reviewed by Zack Rusin.
 209
 210         https://bugs.webkit.org/show_bug.cgi?id=24158
 211         Implement the queue*() methods of the layoutTestController and begin
 212         implementing the dump of the back/forward list.  This results in 2% more
 213         tests passing as well as 23 currently skipped tests now passing.
 214
 215         * DumpRenderTree/qt/DumpRenderTree.cpp:
 216         (WebCore::DumpRenderTree::dumpBackForwardList):
 217         (WebCore::DumpRenderTree::dump):
 218         * DumpRenderTree/qt/DumpRenderTree.h:
 219         * DumpRenderTree/qt/DumpRenderTree.pro:
 220         * DumpRenderTree/qt/jsobjects.cpp:
 221         (findFrameNamed):
 222         (LoadItem::invoke):
 223         (ReloadItem::invoke):
 224         (ScriptItem::invoke):
 225         (BackForwardItem::invoke):
 226         (LayoutTestController::reset):
 227         (LayoutTestController::processWork):
 228         (LayoutTestController::maybeDump):
 229         (LayoutTestController::queueBackNavigation):
 230         (LayoutTestController::queueForwardNavigation):
 231         (LayoutTestController::queueLoad):
 232         (LayoutTestController::queueReload):
 233         (LayoutTestController::queueScript):
 234         * DumpRenderTree/qt/jsobjects.h:
 235         (LayoutTestController::shouldDumpBackForwardList):
 236         (LayoutTestController::dumpBackForwardList):
 237
 238 2009-02-24  Adam Treat  <adam.treat@torchmobile.com>
 239
 240         Reviewed by Alexey Proskuryakov.
 241
 242         Don't print out that you are generating new results if you are not in fact
 243         generating new results and disable generating new results by default for
 244         the all ports other than the canonical Apple Mac port since this can litter
 245         the source directory with hundreds of new results since other ports
 246         are not as up to date.
 247
 248         * Scripts/run-webkit-tests:
 249
 250 2009-02-24  Adam Treat  <adam.treat@torchmobile.com>
 251
 252         Reviewed by Cameron Zwarich.
 253
 254         The Qt port does not support these yet nor does the nm check work with
 255         QMake based build.
 256
 257         * Scripts/webkitdirs.pm:
 258
 259 2009-02-24  Jan Michael Alonzo  <jmalonzo@webkit.org>
 260
 261         Reviewed by Alexey Proskuryakov.
 262
 263         [Gtk] add options for 3D transforms and HTML5 channel messaging to the build
 264         https://bugs.webkit.org/show_bug.cgi?id=24072
 265
 266         Allow toggling of 3D transforms and HTML5 channel messaging
 267         support for the Autotools (Gtk) build.
 268
 269         Also add '--gtk' in the build-webkit help doc and fix autotools
 270         option for web-workers support.
 271
 272         * Scripts/build-webkit:
 273
 274 2009-02-23  Xan Lopez  <xan@gnome.org>
 275
 276         Reviewed by Alexey Proskuryakov.
 277
 278         https://bugs.webkit.org/show_bug.cgi?id=22624
 279         [SOUP][GTK] Need API to get SoupSession from WebKit.
 280
 281         Add soup flags now that dependency is explicit.
 282
 283         * GNUmakefile.am:
 284
 285 2009-02-22  Mark Rowe  <mrowe@apple.com>
 286
 287         Reviewed by Oliver Hunt.
 288
 289         Fix assertion failures in editing/pasteboard/paste-RTFD.html and editing/pasteboard/paste-TIFF.html in 64-bit.
 290
 291         * DumpRenderTree/mac/DumpRenderTree.mm:
 292         (swizzleAllMethods): When adding a new method to a class, use the implementation and type of the new method rather
 293         than of an arbitrary existing method on the class.
 294
 295 2009-02-13  Eric Seidel  <eric@webkit.org>
 296
 297         Rubber-stamped by Alexey Proskuryakov.
 298
 299         Add a few ignores to make-js-test-wrappers.
 300
 301         * Scripts/make-js-test-wrappers:
 302
 303 2009-02-17  Holger Hans Peter Freyther  <zecke@selfish.org>
 304
 305         Reviewed by Alexey Proskuryakov.
 306
 307         Prepend file:// to the test result filename to make
 308         GtkLauncher display the result page.
 309
 310         * Scripts/run-webkit-tests:
 311
 312 2009-02-16  Gustavo Noronha Silva  <gns@gnome.org>
 313
 314         Reviewed by Adam Roben
 315
 316         Actually use the installation prefix defined in WebKitInstallationPrefix,
 317         in autotools builds.
 318
 319         * Scripts/webkitdirs.pm:
 320
 321 2009-02-12  Simon Fraser  <simon.fraser@apple.com>
 322
 323         No review.
 324
 325         Remove debugging code which was committed by mistake.
 326
 327         * Scripts/run-webkit-tests:
 328
 329 2009-02-12  Simon Fraser  <simon.fraser@apple.com>
 330
 331         Reviewed by Adam Roben
 332
 333         https://bugs.webkit.org/show_bug.cgi?id=23928
 334
 335         Add detection of accelerated compositing and 3d transforms,
 336         and add various directories to $ignoredDirectories when these
 337         features are off.
 338
 339         * Scripts/run-webkit-tests:
 340         * Scripts/webkitdirs.pm:
 341
 342 2009-02-12  Adam Roben  <aroben@apple.com>
 343
 344         Fix Bug 23922: Warning message from run-webkit-tests when Skipped file
 345         contains non-existent tests is confusing and is given for disabled
 346         tests
 347
 348         <https://bugs.webkit.org/show_bug.cgi?id=23922>
 349
 350         We now no longer warn about disabled tests. The warning now reads:
 351
 352         Skipped list contained '$item', but no file of that name could be
 353         found
 354
 355         Reviewed by John Sullivan.
 356
 357         * Scripts/run-webkit-tests:
 358         (top level): Pass the list name to processIgnoreTests so it can print
 359         out a reasonable warning message.
 360         (processIgnoreTests): Take a list name as a second parameter and use
 361         it to display a better warning message. Also check for a "-disabled"
 362         version of the test before warning about it not existing.
 363
 364 2009-02-11  Adam Roben  <aroben@apple.com>
 365
 366         Windows fix for Bug 22239: Implement missing animation & transition
 367         APIs on LayoutTestController for non-mac platforms
 368
 369         <https://bugs.webkit.org/show_bug.cgi?id=22239>
 370
 371         Reviewed by Simon Fraser.
 372
 373         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 374         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
 375         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
 376         (LayoutTestController::numberOfActiveAnimations):
 377         Implemented these by calling through to IWebFramePrivate.
 378
 379 2009-02-10  Chris Marrin  <cmarrin@apple.com>
 380
 381         Reviewed by Simon Fraser.
 382
 383         * Scripts/build-webkit:
 384
 385         https://bugs.webkit.org/show_bug.cgi?id=23883
 386
 387         Added support --3d-transforms. Defaults to off
 388
 389 2009-02-11  Adam Roben  <aroben@apple.com>
 390
 391         Fix crashes in http/tests/history/redirect-301.pl and friends on
 392         Windows
 393
 394         Reviewed by Alexey Proskuryakov.
 395
 396         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 397         (LayoutTestController::webHistoryItemCount): Null-check the shared
 398         WebHistory instance before dereferencing it.
 399
 400 2009-02-10  Adam Roben  <aroben@apple.com>
 401
 402         Fix Bug 23869: Pixel tests can't be run on Windows
 403
 404         <https://bugs.webkit.org/show_bug.cgi?id=23869>
 405
 406         This patch gets the pixel tests limping along on Windows again.
 407
 408         Reviewed by Dan Bernstein.
 409
 410         * DumpRenderTree/DumpRenderTree.sln: Changed to use the new
 411         Debug_Internal configuration of ImageDiff in the Debug_Internal
 412         configuration of this solution.
 413
 414         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 415         (printPNG): Changed to call fwrite in a loop, since this call was
 416         failing due to the buffer being too large on Windows.
 417         (dumpWebViewAsPixelsAndCompareWithExpected): Removed an unnecessary
 418         #if PLATFORM(MAC)/#endif.
 419
 420         * DumpRenderTree/win/ImageDiff.vcproj: Added a Debug_Internal
 421         configuration that matches the Debug configuration but also references
 422         debug_internal.vsprops.
 423
 424         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
 425         (createBitmapContextFromWebView): Renamed from
 426         getBitmapContextFromWebView to match the name used in the
 427         cross-platform code.
 428
 429 2009-02-10  Adam Roben  <aroben@apple.com>
 430
 431         Robustify DumpRenderTree/win a little
 432
 433         DumpRenderTree was previously not holding a ref to the WebViews it
 434         created via window.open. It was getting away with this because
 435         WebViews get reffed by being preference notification observers and by
 436         registering for drag-n-drop messages. Now DRT does hold a ref, in case
 437         this situation changes in the future.
 438
 439         Reviewed by Alexey Proskuryakov.
 440
 441         * DumpRenderTree/win/DumpRenderTree.cpp:
 442         (dumpBackForwardListForAllWindows): Added a .get().
 443         (windowToWebViewMap): Changed to use the WindowToWebViewMap typedef.
 444         * DumpRenderTree/win/DumpRenderTreeWin.h: Changed the
 445         windowToWebViewMap() to hold a ref to the WebViews it contains.
 446
 447 2009-02-05  Simon Fraser  <simon.fraser@apple.com>
 448
 449         Fix the #include file order, per review comments.
 450
 451         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
 452
 453 2009-02-05  Simon Fraser  <simon.fraser@apple.com>
 454
 455         Reviewed by Dan Bernstein
 456
 457         https://bugs.webkit.org/show_bug.cgi?id=23362
 458
 459         If the WebHTMLView uses accelerated compositing, we need for force
 460         the on-screen capture path and also force animations to start with -display
 461         since the DRT window has autodisplay disabled.
 462
 463         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
 464         (createBitmapContextFromWebView):
 465
 466 2009-02-03  miggilin  <mr.diggilin@gmail.com>
 467
 468         Reviewed by Darin Adler.
 469
 470         Change the way wxWidgets build gets arguments.
 471         Change "checkForArgumentAndRemoveFromARGV" in build-webkit to check if the
 472         argument passed matches one in ARGV exactly (allows, ie, --wx-args not to be
 473         removed when --wx is checked for).
 474
 475         https://bugs.webkit.org/show_bug.cgi?id=23701
 476
 477         * Scripts/build-webkit:
 478         * Scripts/webkitdirs.pm:
 479
 480 2009-01-30  Chris Fleizach  <cfleizach@apple.com>
 481
 482         Reviewed by Oliver Hunt.
 483
 484         Catch exceptions thrown by AppKit when accessing an attribute than an element
 485         doesn't return.
 486
 487         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 488         (attributesOfElement):
 489
 490 2009-01-29  David Kilzer  <ddkilzer@apple.com>
 491
 492         Remove semi-colons from the end of ObjC method implementations
 493
 494         Rubber-stamped by Adam Roben.
 495
 496         $ find WebKitTools -name \*.m -o -name \*.mm -exec perl -e 'undef $/; $s = <>; while ($s =~ m/[\n\r][-+].*;[\s\r\n]+\{/g) { print "$ARGV: $&\n"; }' {} \;
 497
 498         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 499         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
 500         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
 501         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
 502         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
 503         * DumpRenderTree/mac/UIDelegate.mm:
 504         (-[UIDelegate webViewFrame:]):
 505
 506 2009-01-28  Geoffrey Garen  <ggaren@apple.com>
 507
 508         Build fix for GTK.
 509
 510         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 511         (LayoutTestController::webHistoryItemCount):
 512
 513 2009-01-28  Geoffrey Garen  <ggaren@apple.com>
 514
 515         Reviewed by Sam Weinig.
 516
 517         Added support for querying how many history items were created during a
 518         layout test.
 519
 520         * DumpRenderTree/LayoutTestController.cpp:
 521         (getWebHistoryItemCountCallback):
 522         (LayoutTestController::staticValues):
 523         * DumpRenderTree/LayoutTestController.h:
 524         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 525         (LayoutTestController::webHistoryItemCount):
 526         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 527         (LayoutTestController::webHistoryItemCount):
 528
 529 2009-01-26  Pierre-Olivier Latour  <pol@apple.com>
 530
 531         Tweaked again earlier fix, this time just to print a warning and not abort if
 532         attempting to generate pixel results and Perian is installed.
 533
 534         https://bugs.webkit.org/show_bug.cgi?id=22615
 535
 536         * Scripts/run-webkit-tests:
 537
 538 2009-01-26  Christian Dywan  <christian@twotoasts.de>
 539
 540         Rubber stamped by Holger Freyther.
 541
 542         * GtkLauncher/main.c:
 543         (main): Initialize threads, which is required for libSoup.
 544
 545 2009-01-23  David Kilzer  <ddkilzer@apple.com>
 546
 547         * Scripts/do-webcore-rename: Removed 10 header guard renames that
 548         had already been fixed, and updated 4 renames whose original values
 549         had changed.
 550
 551 2009-01-22  Anders Carlsson  <andersca@apple.com>
 552
 553         Fix Windows build.
 554
 555         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
 556
 557 2009-01-22  Anders Carlsson  <andersca@apple.com>
 558
 559         Reviewed by Sam Weinig.
 560
 561         Clean up the test plug-in code. We now always use the CG drawing model and the
 562         Cocoa event model. It is however possible to revert to the old Carbon event model by
 563         specifying forcecarbon=true in the embed/object tag.
 564
 565         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
 566         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
 567         (NPP_New):
 568         (handleEventCarbon):
 569         (handleEventCocoa):
 570         (NPP_HandleEvent):
 571
 572 2009-01-21  Pierre-Olivier Latour  <pol@apple.com>
 573
 574         Tweaked earlier fix to only print a warning when Perian is installed,
 575         and fail completely only if attempting to generate new pixel test results.
 576
 577         https://bugs.webkit.org/show_bug.cgi?id=23392
 578
 579         * Scripts/run-webkit-tests:
 580
 581 2009-01-20  Darin Adler  <darin@apple.com>
 582
 583         Reviewed by Alexey Proskuryakov.
 584
 585         Bug 23450: string leaks seen in DumpRenderTree accessibility test code
 586         https://bugs.webkit.org/show_bug.cgi?id=23450
 587
 588         * DumpRenderTree/AccessibilityUIElement.cpp:
 589         (isAttributeSettableCallback): Add the missing JSStringRelease call.
 590         (attributeValueCallback): Ditto.
 591
 592 2009-01-20  Pierre-Olivier Latour  <pol@apple.com>
 593
 594         Reviewed by Darin Adler.
 595
 596         Print warning regarding display color profile change in run-webkit-tests instead of DRT.
 597
 598         https://bugs.webkit.org/show_bug.cgi?id=23392
 599
 600         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
 601         (setupMainDisplayColorProfile):
 602         * Scripts/run-webkit-tests:
 603
 604 2009-01-20  Pierre-Olivier Latour  <pol@apple.com>
 605
 606         Reviewed by Darin Adler.
 607
 608         Changed run-webkit-tests to abort on the Mac if pixel tests are enabled and Perian is installed,
 609         in order to avoid result differences in some media tests.
 610
 611         https://bugs.webkit.org/show_bug.cgi?id=22615
 612
 613         * Scripts/run-webkit-tests:
 614         * Scripts/webkitdirs.pm:
 615
 616 2009-01-19  Sam Weinig  <sam@webkit.org>
 617
 618         * Scripts/do-webcore-rename: Add JSValuePtr and ProtectedJSValuePtr.
 619
 620 2009-01-16  Gabor Loki  <loki@inf.u-szeged.hu>
 621
 622         Reviewed by Darin Adler.
 623
 624         * Scripts/webkitdirs.pm: Added '--makeargs' parameter which can pass additional
 625         parameters to make command in QMake projects.
 626
 627 2009-01-16  Chris Fleizach  <cfleizach@apple.com>
 628
 629         Reviewed by Beth Dakin.
 630
 631         Add AX methods to retrieve the parent of an element.
 632
 633         * DumpRenderTree/AccessibilityUIElement.cpp:
 634         (parentElementCallback):
 635         (AccessibilityUIElement::getJSClass):
 636         * DumpRenderTree/AccessibilityUIElement.h:
 637         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 638         (AccessibilityUIElement::parentElement):
 639         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 640         (AccessibilityUIElement::parentElement):
 641
 642 2009-01-16  Anders Carlsson  <andersca@apple.com>
 643
 644         Reviewed by Adam Roben.
 645
 646         Set the count to the right number of elements.
 647
 648         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
 649         (testEnumerate):
 650
 651 2009-01-14  David Kilzer  <ddkilzer@apple.com>
 652
 653         BUILD FIX: Use COM API on Windows in LayoutTestController::setIconDatabaseEnabled()
 654
 655         Rubber-stamped by Alice Liu.
 656
 657         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 658         (LayoutTestController::setIconDatabaseEnabled): Use COM API
 659         to get the shared WebIconDatabase.
 660
 661 2009-01-14  Jeremy Moskovich  <jeremy@chromium.org>
 662
 663         Reviewed by Eric Seidel.
 664
 665         <https://bugs.webkit.org/show_bug.cgi?id=16829>
 666         Implement NPN_SetException()
 667
 668         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 669         (pluginInvoke):
 670         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
 671         (initializeIdentifiers):
 672         (testHasMethod):
 673         (testInvoke):
 674
 675 2009-01-13  Dmitry Titov  <dimich@chromium.org>
 676
 677         Reviewed by David Kilzer.
 678
 679         https://bugs.webkit.org/show_bug.cgi?id=23304
 680         Fix svn-apply to match svn-unapply to recognize added files in 'git diff' patches.
 681
 682         * Scripts/svn-apply: Added a check (similar to svn-unapply) to recognize added files.
 683
 684 2009-01-14  David Kilzer  <ddkilzer@apple.com>
 685
 686         BUILD FIX: Implement LayoutTestController::setIconDatabaseEnabled(bool) for GTK
 687
 688         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 689         (runTest): Added call to reset the icon database to match Mac
 690         and Windows ports.
 691         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 692         (LayoutTestController::setIconDatabaseEnabled): Implemented
 693         stub method.
 694
 695 2009-01-14  David Kilzer  <ddkilzer@apple.com>
 696
 697         Bug 22795: favicons should be saved to webarchives
 698
 699         <https://bugs.webkit.org/show_bug.cgi?id=22795>
 700
 701         Reviewed by Darin Adler.
 702
 703         * DumpRenderTree/LayoutTestController.cpp:
 704         (setIconDatabaseEnabledCallback): Added.
 705         (setJavaScriptProfilingEnabledCallback): Realphabetized.
 706         (LayoutTestController::staticFunctions): Added entry for calling
 707         LayoutTestController.setIconDatabaseEnabled(bool) from JavaScript.
 708         * DumpRenderTree/LayoutTestController.h:
 709         (setIconDatabaseEnabledCallback): Added declaration.
 710         (setJavaScriptProfilingEnabledCallback): Realphabetized.
 711
 712         * DumpRenderTree/mac/DumpRenderTree.mm:
 713         (runTest): Disable the icon database before each test.
 714         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 715         (LayoutTestController::setIconDatabaseEnabled): Added.
 716         (LayoutTestController::setJavaScriptProfilingEnabled): Realphabetized.
 717
 718         * DumpRenderTree/win/DumpRenderTree.cpp:
 719         (runTest): Disable the icon database before each test.
 720         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 721         (LayoutTestController::setIconDatabaseEnabled): Added.
 722
 723 2009-01-14  Steve Falkenburg  <sfalken@apple.com>
 724
 725         Update copyright year in version resources.
 726
 727         Reviewed by Adam Roben.
 728
 729         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
 730
 731 2009-01-14  Dan Bernstein  <mitz@apple.com>
 732
 733         Reviewed by John Sullivan.
 734
 735         - update copyright
 736
 737         * DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist:
 738         * WebKitLauncher/Info.plist:
 739
 740 2009-01-13  Anders Carlsson  <andersca@apple.com>
 741
 742         Reviewed by Sam Weinig.
 743
 744         Add NPRuntime test.
 745
 746         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 747         (testNPRuntime):
 748         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
 749         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
 750         (NPP_New):
 751         (NPP_GetValue):
 752
 753 2009-01-12  Mark Rowe  <mrowe@apple.com>
 754
 755         Use the modern spelling of WebKit.
 756
 757         * Scripts/find-extra-includes:
 758         * Scripts/report-include-statistics:
 759         * Scripts/run-webkit-app:
 760         * Scripts/svn-unapply:
 761         * Scripts/update-webkit:
 762
 763 2009-01-11  Darin Adler  <darin@apple.com>
 764
 765         * Scripts/make-js-test-wrappers: Updated so it won't overwrite tests in the svg/dom
 766         directory that aren't using standard wrappers.
 767
 768 2009-01-11  Robert Blaut  <webkit@blaut.biz>
 769
 770         Reviewed by Eric Seidel.
 771
 772         <https://bugs.webkit.org/show_bug.cgi?id=23134>
 773         Update bisect-builds for Safari 3.2 to prevent crashes
 774
 775         * Scripts/bisect-builds: Added Safari 3.2 and the corresponding minimal revision, r37348.
 776
 777 2009-01-08  Adam Treat  <adam.treat@torchmobile.com>
 778
 779         Reviewed by Simon Hausmann.
 780
 781         Explicitly set these so that the layout tests do not break.
 782
 783         * DumpRenderTree/qt/DumpRenderTree.cpp:
 784         (WebCore::WebPage::WebPage):
 785
 786 2009-01-07  Glenn Wilson  <gwilson@chromium.org>
 787
 788         Reviewed by Eric Seidel.
 789
 790         Changed DumpRenderTree to re-enable Javascript in web preferences on every test.
 791         This fixes the case when a user mistakenly disables Javascript, and all layout tests crash.
 792
 793         * DumpRenderTree/mac/DumpRenderTree.mm:
 794         (testStringByEvaluatingJavaScriptFromString):
 795         (setDefaultsToConsistentValuesForTesting):
 796
 797 2009-01-07  Holger Hans Peter Freyther  <zecke@selfish.org>
 798
 799         Reviewed by Maciej Stachowiak.
 800
 801         Implement numberOfActiveAnimations to fix the build
 802
 803         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 804         (LayoutTestController::numberOfActiveAnimations):
 805
 806 2009-01-07  Adam Treat  <adam.treat@torchmobile.com>
 807
 808         Reviewed by George Staikos.
 809
 810         Fix unused variable warnings
 811
 812         * DumpRenderTree/qt/DumpRenderTree.cpp:
 813         (WebCore::WebPage::javaScriptAlert):
 814         (WebCore::WebPage::javaScriptConfirm):
 815         (WebCore::WebPage::javaScriptPrompt):
 816         * DumpRenderTree/qt/jsobjects.cpp:
 817         (LayoutTestController::maybeDump):
 818         * DumpRenderTree/qt/main.cpp:
 819         (get_backtrace):
 820         * DumpRenderTree/qt/testplugin.cpp:
 821         (TestPlugin::create):
 822
 823 2009-01-06  Pierre-Olivier Latour  <pol@apple.com>
 824
 825         Reviewed by Darin Adler.
 826
 827         Added new JS API numberOfActiveAnimations() that returns the number of active CSS transitions & animations.
 828         This effectively exposes the new AnimationController::numberOfActiveAnimations() API from WebCore.
 829
 830         https://bugs.webkit.org/show_bug.cgi?id=23126
 831
 832         * DumpRenderTree/LayoutTestController.cpp:
 833         (numberOfActiveAnimationsCallback):
 834         (LayoutTestController::staticFunctions):
 835         * DumpRenderTree/LayoutTestController.h:
 836         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 837         (LayoutTestController::numberOfActiveAnimations):
 838         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 839         (LayoutTestController::numberOfActiveAnimations):
 840
 841 2009-01-04  David Kilzer  <ddkilzer@apple.com>
 842
 843         Don't install internal headers in WebKit framework
 844
 845         Reviewed by Darin Adler.
 846
 847         Since WebHTMLRepresentationInternal.h and WebTypesInternal.h are
 848         no longer installed in WebKit.framework/PrivateHeaders, use the
 849         special relationship of DumpRenderTree within the WebKit source
 850         tree to include the internal headers through relative paths.
 851         Created the concept of mac/InternalHeaders to hide the ugly
 852         paths.
 853
 854         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added
 855         mac/InternalHeaders to HEADER_SEARCH_PATHS.
 856         * DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Added.
 857         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h: Added.
 858
 859 2009-01-02  Adam Treat  <treat@kde.org>
 860
 861         Reviewed by George Staikos.
 862
 863         Add support for fixedLayoutSize to the qt DRT
 864
 865         * DumpRenderTree/qt/jsobjects.cpp:
 866         (LayoutTestController::setFixedLayoutSize):
 867         (LayoutTestController::setUseFixedLayout):
 868         * DumpRenderTree/qt/jsobjects.h:
 869
 870 2009-01-03  David D. Kilzer  <ddkilzer@webkit.org>
 871
 872         Bug 23091: Some webarchive http tests intermittently fail due to Connection/Keep-Alive header differences
 873
 874         <https://bugs.webkit.org/show_bug.cgi?id=23091>
 875
 876         Reviewed by Darin Adler.
 877
 878         * DumpRenderTree/mac/DumpRenderTree.mm:
 879         (normalizeHTTPResponseHeaderFields): Remove Keep-Alive and
 880         Connection headers from webarchive results.
 881
 882 2008-12-31  Zan Dobersek  <zandobersek@gmail.com>
 883
 884         Reviewed by Holger Freyther.
 885
 886         https://bugs.webkit.org/show_bug.cgi?id=22812
 887
 888         Prevent TestNetscapePlugin from installing system-wide.
 889
 890         * GNUmakefile.am:
 891
 892 2008-12-31  Zan Dobersek  <zandobersek@gmail.com>
 893
 894         Reviewed by Holger Freyther.
 895
 896         https://bugs.webkit.org/show_bug.cgi?id=22842
 897
 898         Move WebKitWebView's size allocation into a proper place.
 899
 900         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 901         (dump):
 902         (runTest):
 903
 904 2008-12-24  Mark Rowe  <mrowe@apple.com>
 905
 906         Reviewed by Timothy Hatcher.
 907
 908         Move the guts of determineCurrentSVNRevision to VCSUtils as svnRevisionForDirectory,
 909         and make it work for git too.
 910
 911         * Scripts/VCSUtils.pm:
 912         * Scripts/webkitdirs.pm:
 913
 914 2008-12-22  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
 915
 916         Reviewed by George Staikos.
 917
 918         Ignore http/tests/wml, if no WML support is present.
 919         Add http/tests/wml to list of HTTP tests, allowed to access local resources.
 920
 921         * Scripts/run-webkit-tests:
 922
 923 2008-12-19  David Levin  <levin@chromium.org>
 924
 925         Reviewed by Mark Rowe.
 926
 927         https://bugs.webkit.org/show_bug.cgi?id=22930
 928
 929         Make the git diff command used for preparing the change log avoid using any external diff tools.
 930
 931         * Scripts/prepare-ChangeLog:
 932
 933 2008-12-19  Gustavo Noronha Silva  <gns@gnome.org>
 934
 935         Reviewed by Holger Freyther.
 936
 937         https://bugs.webkit.org/show_bug.cgi?id=22686
 938
 939         Added files which were missing from the TestNetscapePlugin
 940         directory to the SOURCES variable, so that they will be
 941         distributed in a make dist.
 942
 943         * GNUMakefile.am:
 944
 945 2008-12-18  Cameron Zwarich  <zwarich@apple.com>
 946
 947         Reviewed by Geoff Garen.
 948
 949         Add tests for bug 21855: REGRESSION (r37323): Gmail complains about popup blocking when opening a link
 950         <https://bugs.webkit.org/show_bug.cgi?id=21855>
 951         <rdar://problem/6278244>
 952
 953         Add support for scheduling asynchronous clicks to DumpRenderTree, but
 954         only on the Mac.
 955
 956         * DumpRenderTree/mac/EventSendingController.h:
 957         * DumpRenderTree/mac/EventSendingController.mm:
 958         (+[EventSendingController isSelectorExcludedFromWebScript:]): Expose
 959         scheduleAsynchronousClick to JavaScript.
 960         (-[EventSendingController scheduleAsynchronousClick]): Add.
 961
 962 2008-12-15  Darin Adler  <darin@apple.com>
 963
 964         * Scripts/make-js-test-wrappers: Added another exception to avoid overwriting
 965         a custom-written test.
 966
 967 2008-12-15  Simon Hausmann  <hausmann@webkit.org>
 968
 969         Reviewed by Holger Freyther.
 970
 971         Implement setJavaScriptProfilingEnabled in the Qt DRT to pass fast/profiler.
 972
 973         * DumpRenderTree/qt/jsobjects.cpp:
 974         (LayoutTestController::setJavaScriptProfilingEnabled):
 975         * DumpRenderTree/qt/jsobjects.h:
 976
 977 2008-12-13  Zan Dobersek  <zandobersek@gmail.com>
 978
 979         Reviewed by Darin Adler.
 980
 981         https://bugs.webkit.org/show_bug.cgi?id=22039
 982
 983         Implement animation and transition pausing.
 984
 985         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 986         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
 987         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
 988
 989 2008-12-12  Brent Fulgham  <bfulgham@gmail.com>
 990
 991         Reviewed by Adam Roben.
 992
 993         https://bugs.webkit.org/show_bug.cgi?id=22809
 994
 995         Increase timeout in call to initWithURL so that people actually see
 996         new web pages when they type URLs rather than a blank screen.
 997
 998         * WinLauncher/WinLauncher.cpp:
 999         (loadURL):  Increase timeout in initWithURL from 0 to 60 seconds.
1000
1001 2008-12-12  Darin Adler  <darin@apple.com>
1002
1003         * Scripts/do-webcore-rename: Add a renaming idea.
1004
1005 2008-12-12  Holger Hans Peter Freyther  <zecke@selfish.org>
1006
1007         Reviewed by Simon Hausmann.
1008
1009         Update the WebKit.qrc and add a script to automatically generate the file.
1010
1011         With the way rcc and qmake work this can not be done at build time
1012         as the WebKit.qrc must sit inside the directory that contains the files
1013         and at build time we may not change the content of the source directory.
1014
1015         * Scripts/generate-qt-inspector-resource: Added.
1016
1017 2008-12-11  Cameron Zwarich  <zwarich@apple.com>
1018
1019         Rubber-stamped by Mark Rowe.
1020
1021         Roll out r39212 due to assertion failures during layout tests, multiple
1022         layout test failures, memory leaks, and obvious incorrectness.
1023
1024         * DumpRenderTree/LayoutTestController.cpp:
1025         (LayoutTestController::staticFunctions):
1026         * DumpRenderTree/LayoutTestController.h:
1027         * DumpRenderTree/mac/DumpRenderTree.mm:
1028         (resetWebViewToConsistentStateBeforeTesting):
1029         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1030         * DumpRenderTree/win/DumpRenderTree.cpp:
1031         (resetWebViewToConsistentStateBeforeTesting):
1032         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1033         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1034
1035 2008-12-10  Glenn Wilson  <gwilson@google.com>
1036
1037         Reviewed by Adam Roben.
1038
1039         Changed LayoutTestController and DumpRenderTree to allow for manual
1040         overriding of default preferences at test time.  Also added support for
1041         resetting the preferences after each test.
1042         https://bugs.webkit.org/show_bug.cgi?id=20534
1043
1044         * DumpRenderTree/LayoutTestController.cpp: Added callback method for overriding preferences
1045         * DumpRenderTree/LayoutTestController.h: Added signature for callback
1046         * DumpRenderTree/win/DumpRenderTree.cpp: Added calls to reset preferences after each test if necessary
1047         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added JS override function
1048         * DumpRenderTree/mac/DumpRenderTree.mm: Added calls to reset preferences after each test if necessary
1049         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Added JS override function
1050
1051 2008-12-10  Brady Eidson  <beidson@apple.com>
1052
1053         Reviewed by Darin Adler.
1054
1055         Implement the new policy delegate (including navigation type and permissive mode) for DRT/win
1056
1057         * DumpRenderTree/win/DumpRenderTree.cpp:
1058         * DumpRenderTree/win/DumpRenderTreeWin.h:
1059
1060         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1061         (LayoutTestController::setCustomPolicyDelegate):
1062
1063         * DumpRenderTree/win/PolicyDelegate.cpp:
1064         (PolicyDelegate::PolicyDelegate):
1065         (PolicyDelegate::decidePolicyForNavigationAction):
1066         * DumpRenderTree/win/PolicyDelegate.h:
1067         (PolicyDelegate::setPermissive):
1068
1069 2008-12-10  Brady Eidson  <beidson@apple.com>
1070
1071         Reviewed by Darin
1072
1073         Change the custom policy delegate to actually allow navigation for tests that need it.
1074         The new behavior is opt-in and doesn't require any changes in old tests.
1075
1076         * DumpRenderTree/LayoutTestController.cpp:
1077         (setCustomPolicyDelegateCallback):  Allow for a second boolean argument to set the permissive flag on the custom
1078           policy delegate, which will be false by default to maintain original behavior.
1079         * DumpRenderTree/LayoutTestController.h:
1080         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1081         (LayoutTestController::setCustomPolicyDelegate):
1082
1083         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1084         (LayoutTestController::setCustomPolicyDelegate):  Partially stubbed out for now.
1085         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1086         (LayoutTestController::setCustomPolicyDelegate):  Still stubbed out, but with new param.
1087
1088         * DumpRenderTree/mac/PolicyDelegate.h:
1089         * DumpRenderTree/mac/PolicyDelegate.mm:
1090         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):  If the permissive flag
1091           is set, allow the navigation.
1092         (-[PolicyDelegate setPermissive:]):  Change the behavior between "use" and "ignore" - allowing navigation or not.
1093
1094 2008-12-09  Mark Rowe  <mrowe@apple.com>
1095
1096         Rubber-stamped by Ada Chan.
1097
1098         Fix gdb-safari on Tiger.
1099
1100         gdb on Tiger does not take the -arch flag, so do not pass it.
1101
1102         * Scripts/gdb-safari:
1103
1104 2008-12-09  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
1105
1106         Reviewed by Alexey Proskuryakov.
1107
1108         Ignore WML tests, if no WML support available.
1109
1110         * Scripts/run-webkit-tests:
1111
1112 2008-12-08  Geoffrey Garen  <ggaren@apple.com>
1113
1114         Reviewed by Oliver Hunt.
1115
1116         Added a shortcut for --jsDriver-args, which I use a lot.
1117
1118         * Scripts/run-javascriptcore-tests:
1119
1120 2008-12-08  Stephanie Lewis  <slewis@apple.com>
1121
1122         Fix Tiger build.
1123
1124         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1125
1126 2008-12-08  Darin Adler  <darin@apple.com>
1127
1128         Reviewed by John Sullivan.
1129
1130         - test machinery for https://bugs.webkit.org/show_bug.cgi?id=22409
1131           REGRESSION: cmd-shift-left/right don't switch tabs, instead select text
1132
1133         * DumpRenderTree/LayoutTestController.cpp:
1134         (isCommandEnabledCallback): Added.
1135         (LayoutTestController::staticFunctions): Added "isCommandEnabled".
1136         * DumpRenderTree/LayoutTestController.h: Ditto.
1137         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1138         (LayoutTestController::isCommandEnabled): Ditto.
1139         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1140         (-[CommandValidationTarget initWithAction:]): Added. Used to get the
1141         command validation system to tell us if a comment is enabled.
1142         (-[CommandValidationTarget action]): Ditto.
1143         (-[CommandValidationTarget tag]): Ditto.
1144         (LayoutTestController::isCommandEnabled): Ditto.
1145         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1146         (LayoutTestController::isCommandEnabled): Ditto.
1147
1148 2008-12-08  David Kilzer  <ddkilzer@apple.com>
1149
1150         Bug 22555: Sort "children" sections in Xcode project files
1151
1152         <https://bugs.webkit.org/show_bug.cgi?id=22555>
1153
1154         Reviewed by Eric Seidel.
1155
1156         * DrawTest/DrawTest.xcodeproj/project.pbxproj: Sorted.
1157         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Sorted.
1158         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Sorted.
1159
1160 2008-12-08  David Kilzer  <ddkilzer@apple.com>
1161
1162         Bug 22555: Sort "children" sections in Xcode project files
1163
1164         <https://bugs.webkit.org/show_bug.cgi?id=22555>
1165
1166         Reviewed by Timothy Hatcher.
1167
1168         * Scripts/sort-Xcode-project-file: By popular request, don't sort
1169         the mainGroup in the project (the list of items below the top-level
1170         project file).
1171
1172 2008-12-05  David Kilzer  <ddkilzer@apple.com>
1173
1174         Bug 22555: Sort "children" sections in Xcode project files
1175
1176         <https://bugs.webkit.org/show_bug.cgi?id=22555>
1177
1178         Reviewed by Darin Adler.
1179
1180         Sort "children" sections alphabetically, moving groups (folders) to
1181         the top of each of the lists.  Files are assumed to have extensions,
1182         so %isFile is used to override this behavior.
1183
1184         * Scripts/sort-Xcode-project-file:
1185         (sortChildrenByFileName): Added.
1186         (sortFilesByFileName): Renamed from sortByFileName().
1187
1188 2008-12-05  Eric Seidel  <eric@webkit.org>
1189
1190         Reviewed by Geoff Garen.
1191
1192         https://bugs.webkit.org/show_bug.cgi?id=22683
1193         Fix gtk and qt builds which depend on --qt and --gtk being removed from ARGV
1194         Add a new argumentsForConfiguration() function and clean up some old code to use it.
1195         Rename checkArgV to checkForArgumentAndRemoveFromARGV to be more self-documenting.
1196
1197         * Scripts/run-javascriptcore-tests:
1198         * Scripts/run-launcher:
1199         * Scripts/run-webkit-tests:
1200         * Scripts/webkitdirs.pm:
1201
1202 2008-12-03  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
1203
1204         Reviewed by Cameron Zwarich.
1205
1206         Further preparations for WML layout tests.
1207         Ignore WMLTestCase.js, that's going to be in trunk soon.
1208
1209         * Scripts/make-js-test-wrappers:
1210
1211 2008-12-03  Eric Seidel  <eric@webkit.org>
1212
1213         Build fix for --gtk and --chromium, no review.
1214
1215         Fix run-javascriptcore-tests to pass --gtk, --qt, --chromium, etc.
1216         through to build-jsc.
1217
1218         * Scripts/build-jsc:
1219         * Scripts/webkitdirs.pm:
1220
1221 2008-12-03  Eric Seidel  <eric@webkit.org>
1222
1223         Build fix only, no review.
1224
1225         Remove support for build-webkit --svg-experimental.
1226         All of the "experimental" svg features have their own toggles anyway.
1227         I broke --svg-experimental in my last commit (which then broke clean builds)
1228         I can't find any use of --svg-experimental in our source tree, so removing it.
1229
1230         * Scripts/build-webkit:
1231
1232 2008-12-02  Eric Seidel  <eric@webkit.org>
1233
1234         Reviewed by David Hyatt (and Mark Rowe).
1235
1236         Move --coverage support from build-webkit to webkitdirs.pm to share it with build-jsc
1237         Move --coverage support out of run-javascriptcore-tests and into build-jsc
1238
1239         Finally add a buildXCodeProject function to webkitdirs.pm and move --clean support
1240         there from build-webkit (to allow future sharing with other build-* scripts)
1241
1242         Change run-javascriptcore-tests to expect a --jsDriver-args= argument instead of
1243         picking through ARGV with a blacklist of what arguments weren't jsDriver args
1244         this makes run-javascriptcore-tests transparently support all arguments which
1245         webkitdirs.pm gives it support for.
1246
1247         Make run-javascriptcore-tests actually print what commands it's running before running them.
1248
1249         Add --help support to build-jsc and run-javascriptcore-tests!
1250
1251         Make code to support --svg-experimental defaults take up half as many lines.
1252
1253         * Scripts/build-jsc:
1254         * Scripts/build-webkit:
1255         * Scripts/run-javascriptcore-tests:
1256         * Scripts/webkitdirs.pm:
1257
1258 2008-12-03  Adam Roben  <aroben@apple.com>
1259
1260         Fix a leak in WinLauncher shutdown
1261
1262         Reviewed by Sam Weinig.
1263
1264         * WinLauncher/WinLauncher.cpp:
1265         (_tWinMain): Replaced a delete with a Release. We can't delete the
1266         WebView properly since we only have a pointer to one of its
1267         interfaces. We also shouldn't be deleting COM objects directly anyway,
1268         for a number of reasons.
1269
1270 2008-12-03  Adam Roben  <aroben@apple.com>
1271
1272         Fix a crash on exit in WinLauncher
1273
1274         Reviewed by Sam Weinig.
1275
1276         * WinLauncher/WinLauncher.cpp:
1277         (_tWinMain): Call shutDownWebKit before exiting.
1278
1279 2008-12-03  Adam Roben  <aroben@apple.com>
1280
1281         Add a Debug_Internal configuration to WinLauncher
1282
1283         This matches our other projects.
1284
1285         Reviewed by Sam Weinig.
1286
1287         * WinLauncher/WinLauncher.vcproj: Added a Debug_Internal
1288         configuration, which is identical to Debug except that it also
1289         references debug_internal.vsprops. Also removed some settings that we
1290         should be picking up from the .vsprops files.
1291
1292 2008-12-02  Eric Seidel  <eric@webkit.org>
1293
1294         Reviewed by David Kilzer.
1295
1296         Hack build-webkit --chromium to use Win32 python instead
1297         of using the default cygwin python.  Scons + CYGWIN tries
1298         to build with GCC by default, we force MSVC in our file
1299         but that just results in errors from Scons.  Until we can fix
1300         this latest round of errors, at least make build-webkit --chromium
1301         actually "work" under CYGWIN instead of forcing users to use
1302         a cmd shell directly.
1303
1304         This is working around a Scons bug:
1305         http://scons.tigris.org/issues/show_bug.cgi?id=2266
1306
1307         * Scripts/webkitdirs.pm:
1308
1309 2008-12-01  David Kilzer  <ddkilzer@apple.com>
1310
1311         Bug 22466: REGRESSION (35867): Many resources missing when saving webarchive of webkit.org
1312
1313         <https://bugs.webkit.org/show_bug.cgi?id=22466>
1314         <rdar://problem/6403593>
1315
1316         Reviewed by Brady Eidson.
1317
1318         * DumpRenderTree/mac/DumpRenderTree.mm:
1319         (normalizeHTTPResponseHeaderFields): Added.  Normalizes Date, Etag,
1320         Keep-Alive, Last-Modified and Server header fields to prevent false
1321         positive test failures.
1322         (convertWebResourceResponseToDictionary): Call
1323         normalizeHTTPResponseHeaderFields() to noramlize HTTP response
1324         header fields.
1325
1326 2008-12-01  David D. Kilzer  <ddkilzer@webkit.org>
1327
1328         Bug 22559: Report builds left to test in bisect-builds (like git-bisect)
1329
1330         <https://bugs.webkit.org/show_bug.cgi?id=22559>
1331
1332         Reviewed by Adam Roben.
1333
1334         * Scripts/bisect-builds: Updated status message to report the
1335         maximum number of builds left to test after the current one.
1336         (max): Added.
1337
1338 2008-11-27  Alp Toker  <alp@nuanti.com>
1339
1340         Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
1341         API header breakage at build time.
1342
1343         * GNUmakefile.am:
1344
1345 2008-11-26  Eric Seidel  <eric@webkit.org>
1346
1347         Reviewed by Nikolas Zimmermann and Mark Rowe.
1348
1349         Add support for build-webkit --chromium
1350         https://bugs.webkit.org/show_bug.cgi?id=22515
1351         More cleanups changing isCygwin calls to isAppleWinWebKit and deploying isAppleWebKit where necessary.
1352
1353         * Scripts/build-dumprendertree:
1354         * Scripts/build-jsc:
1355         * Scripts/build-webkit:
1356         * Scripts/gdb-safari:
1357         * Scripts/run-webkit-tests:
1358         * Scripts/webkitdirs.pm:
1359
1360 2008-11-26  Eric Seidel  <eric@webkit.org>
1361
1362         Reviewed by Nikolas Zimmermann.
1363
1364         Add support for build-webkit --chromium (tested on mac)
1365         https://bugs.webkit.org/show_bug.cgi?id=22515
1366         Also simplified some code using checkArgv
1367
1368         * Scripts/build-webkit:
1369         * Scripts/webkitdirs.pm:
1370
1371 2008-11-26  Eric Seidel  <eric@webkit.org>
1372
1373         Reviewed by Nikolas Zimmermann.
1374
1375         More pre-work for adding a build-webkit --chromium which works on Mac and Windows
1376         https://bugs.webkit.org/show_bug.cgi?id=22515
1377         Change a few calls to isCygwin to isAppleWinWebKit and a few calls to isAppleMacWebKit to isDarwin
1378         in preparation for having a chromium cygwin and chromium mac build
1379
1380         * Scripts/build-webkit:
1381         * Scripts/webkitdirs.pm:
1382
1383 2008-11-26  Eric Seidel  <eric@webkit.org>
1384
1385         Reviewed by Nikolas Zimmermann.
1386
1387         Pre-work for getting build-webkit --chromium to work
1388         https://bugs.webkit.org/show_bug.cgi?id=22515
1389         Rename isOSX to isAppleMacWebKit to match what the code does, and add isChromium()
1390
1391         * Scripts/build-dumprendertree:
1392         * Scripts/build-jsc:
1393         * Scripts/build-webkit:
1394         * Scripts/gdb-safari:
1395         * Scripts/run-javascriptcore-tests:
1396         * Scripts/run-webkit-tests:
1397         * Scripts/webkitdirs.pm:
1398
1399 2008-11-26  David Kilzer  <ddkilzer@apple.com>
1400
1401         Bug 22488: Make DRT smarter about charset encoding when post-processing webarchive content
1402
1403         <https://bugs.webkit.org/show_bug.cgi?id=22488>
1404
1405         Reviewed by Brady Eidson.
1406
1407         * DumpRenderTree/mac/DumpRenderTree.mm:
1408         (convertWebResourceDataToString): If an IANA charset encoding string
1409         is provided, convert it to a CFStringEncoding value and then to an
1410         NSStringEncoding value, else fall back to NSUTF8StringEncoding.  We
1411         also nil-check dataAsString, so the worst-case scenario is that the
1412         data won't be decoded to a string (versus crashing DumpRenderTree).
1413
1414 2008-11-26  Jan Michael Alonzo  <jmalonzo@webkit.org>
1415
1416         Reviewed by Holger Freyther.
1417
1418         [Gtk] add/remove tests from Skipped and fix netscape plugin test
1419         https://bugs.webkit.org/show_bug.cgi?id=22484
1420
1421         Remove print'ing to stderr
1422
1423         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1424         (NP_Initialize):
1425         (NP_Shutdown):
1426
1427 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
1428
1429         Windows build fix.
1430
1431         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1432
1433 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
1434
1435         Windows build fix.
1436
1437         * DumpRenderTree/cg/ImageDiffCG.cpp:
1438
1439 2008-11-24  Darin Fisher  <darin@chromium.org>
1440
1441         Fix bustage.
1442
1443         https://bugs.webkit.org/show_bug.cgi?id=15643
1444
1445         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1446         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
1447
1448 2008-11-24  Glenn Wilson  <gwilson@chromium.org>
1449
1450         Reviewed by Alexey Proskuryakov.
1451
1452         http://bugs.webkit.org/show_bug.cgi?id=15643
1453
1454         Added support for changing the "trailing whitespace" work-around
1455         in LayoutTestController (so layout tests can verify this functionality)
1456
1457         * DumpRenderTree/LayoutTestController.cpp:
1458         (setSelectTrailingWhitespaceEnabledCallback):
1459         (LayoutTestController::staticFunctions):
1460         * DumpRenderTree/LayoutTestController.h:
1461         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1462         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
1463         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1464         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
1465
1466 2008-11-24  Simon Fraser  <simon.fraser@apple.com>
1467
1468         Reviewed by Darin Adler
1469
1470         https://bugs.webkit.org/show_bug.cgi?id=22433
1471
1472         Add script that attempts to detect virtual methods
1473         whose signatures differ only by constness (which can
1474         indicate a programming error).
1475
1476         * Scripts/detect-mismatched-virtual-const: Added.
1477
1478 2008-11-24  Zan Dobersek  <zandobersek@gmail.com>
1479
1480         Reviewed by Holger Freyther.
1481
1482         https://bugs.webkit.org/show_bug.cgi?id=22039
1483
1484         [Gtk+] Implement TestNetscapePlugin for Gtk+ port and add it to the
1485         build.
1486
1487         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1488         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
1489         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1490         (setDefaultsToConsistentStateValuesForTesting):
1491         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: Added.
1492         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: Added.
1493         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: Added.
1494         * GNUmakefile.am:
1495
1496 2008-11-24  Holger Hans Peter Freyther  <zecke@selfish.org>
1497
1498         Reviewed by Mark Rowe.
1499
1500         [Gtk+] Add configure option to enable Web Workers and enable it by default
1501
1502         Add --enable-workers to the buildsystem (used by build-webkit) add
1503         the to be build files to the GNUmakefile.am and change build-webkit
1504         to enable Web Workers by default.
1505
1506         * Scripts/build-webkit:
1507
1508 2008-11-24  Mark Rowe  <mrowe@apple.com>
1509
1510         Reviewed by Alexey Proskuryakov.
1511
1512         Let gdb-safari accept the --debug and --release options once more.
1513
1514         * Scripts/gdb-safari:
1515
1516 2008-11-23  Zan Dobersek  <zandobersek@gmail.com>
1517
1518         Reviewed by Holger Freyther. Landed by Jan Alonzo.
1519
1520         Get SVG tests tested on GTK port.
1521
1522         * Scripts/webkitdirs.pm:
1523
1524 2008-11-19  Greg Bolsinga  <bolsinga@apple.com>
1525
1526         Reviewed by Darin Adler.
1527
1528         https://bugs.webkit.org/show_bug.cgi?id=21810
1529         Remove use of static C++ objects that are destroyed at exit time (destructors)
1530
1531         All static C++ objects that create atexit calls are gone. Update script
1532         to indicate how to fix the problem should a new one appear.
1533
1534         * Scripts/check-for-exit-time-destructors:
1535
1536 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
1537
1538         Reviewed by Darin Adler.
1539
1540         https://bugs.webkit.org/show_bug.cgi?id=22337
1541         Enable workers by default
1542
1543         * Scripts/build-webkit: Changed the default to enabled.
1544
1545 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
1546
1547         Rubber-stamped by Darin Adler.
1548
1549         https://bugs.webkit.org/show_bug.cgi?id=22306
1550         Disable channel messaging support
1551
1552         * Scripts/build-webkit: Add an option to enable channel messaging.
1553
1554 2008-11-17  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
1555
1556         Reviewed by George Staikos.
1557
1558         Add --(no-)wml build flags.
1559
1560         * Scripts/build-webkit:
1561         * Scripts/run-webkit-tests:
1562         * Scripts/webkitdirs.pm:
1563
1564 2008-11-17  Geoffrey Garen  <ggaren@apple.com>
1565
1566         Not reviewed.
1567
1568         Try to fix gtk build.
1569
1570         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1571         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1572         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1573
1574 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
1575
1576         Reviewed by Maciej.
1577
1578         Pixel tests should use a default tolerance of 0.1% on Leopard and 1.0%
1579         on Tiger.
1580
1581         https://bugs.webkit.org/show_bug.cgi?id=22271
1582
1583         * Scripts/run-webkit-tests:
1584
1585 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
1586
1587         Reviewed by Sam Weinig.
1588
1589         Added new JavaScript API on LayoutController to pause a running
1590         CSS transition or animation at a given time.
1591
1592         https://bugs.webkit.org/show_bug.cgi?id=21261
1593
1594         * DumpRenderTree/LayoutTestController.cpp:
1595         (pauseAnimationAtTimeOnElementWithIdCallback):
1596         (pauseTransitionAtTimeOnElementWithIdCallback):
1597         (LayoutTestController::staticFunctions):
1598         * DumpRenderTree/LayoutTestController.h:
1599         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1600         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1601         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1602         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1603         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1604         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1605
1606 2008-11-17  Gabor Loki  <loki@inf.u-szeged.hu>
1607
1608         Reviewed by Darin Adler.
1609
1610         <https://bugs.webkit.org/show_bug.cgi?id=22309>
1611         Pass the remaining options to build system on Qt-port
1612
1613         * Scripts/build-webkit:
1614         * Scripts/webkitdirs.pm:
1615
1616 2008-11-16  Greg Bolsinga  <bolsinga@apple.com>
1617
1618         Reviewed by Darin Adler.
1619
1620         https://bugs.webkit.org/show_bug.cgi?id=21810
1621         Remove use of static C++ objects that are destroyed at exit time (destructors)
1622
1623         Remove .o files from the exclude list that have had their exit-time destructors removed.
1624         Handle case when there is no current symbol.
1625
1626         * Scripts/check-for-exit-time-destructors:
1627
1628 2008-11-16  Sam Weinig  <sam@webkit.org>
1629
1630         * Scripts/do-webcore-rename: Remove now fixed renames.
1631
1632 2008-11-16  Darin Adler  <darin@apple.com>
1633
1634         * Scripts/do-webcore-rename: Plan some future renames.
1635
1636 2008-11-15  Darin Adler  <darin@apple.com>
1637
1638         Rubber stamped by Geoff Garen.
1639
1640         - do the long-planned StructureID -> Structure rename
1641
1642         * Scripts/check-for-global-initializers: Update name of StructureID.o.
1643         * Scripts/do-webcore-rename: Renaming script that I used.
1644
1645 2008-11-15  Greg Bolsinga  <bolsinga@apple.com>
1646
1647         Reviewed by Darin Adler.
1648
1649         https://bugs.webkit.org/show_bug.cgi?id=21810
1650         Remove use of static C++ objects that are destroyed at exit time (destructors)
1651
1652         Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
1653         exit-time destructor. Update code that was changed to fix this issue that ran
1654         into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
1655         in gcc build 5465). Also typdefs for template types needed to be added in some
1656         cases so the type could make it through the macro successfully.
1657
1658         Basically code of the form:
1659         static T m;
1660         becomes:
1661         DEFINE_STATIC_LOCAL(T, m, ());
1662
1663         Also any code of the form:
1664         static T& m = *new T;
1665         also becomes:
1666         DEFINE_STATIC_LOCAL(T, m, ());
1667
1668         Remove .o files from the exclude list that have had their exit-time destructors removed.
1669
1670         * Scripts/check-for-exit-time-destructors:
1671
1672 2008-11-14  Kevin Ollivier  <kevino@theolliviers.com>
1673
1674         wx mac buildbot fix. Also, make sure we don't keep hitting this problem.
1675
1676         * wx/install-unix-extras:
1677
1678 2008-11-14  Alp Toker  <alp@nuanti.com>
1679
1680         GTK DRT build fix for gcc 4.4 snapshot. Add missing stdio include.
1681
1682         Fixes Debian bug #505723
1683         http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505723
1684
1685         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1686
1687 2008-11-14  Krishna <krishnamurty.podipireddy@nokia.com>
1688
1689         Reviewed by Simon Hausmann.
1690
1691         Fix hanging DRT with Qt.
1692
1693         https://bugs.webkit.org/show_bug.cgi?id=22209
1694
1695         * DumpRenderTree/qt/DumpRenderTree.cpp:
1696         (WebCore::DumpRenderTree::dump):
1697         Send empty pixel test data 'block', which is now
1698         expected by run-layout-tests.
1699
1700 2008-11-12  Dmitry Titov  <dimich@chromium.org>
1701
1702         Reviewed by Alexey Proskuryakov.
1703
1704         https://bugs.webkit.org/show_bug.cgi?id=22216
1705
1706         * Scripts/build-webkit:
1707         Addes ENABLE_WORKERS to build-webkit so it's possible to build with workers enabled.
1708
1709 2008-11-06  David Kilzer  <ddkilzer@apple.com>
1710
1711         BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
1712
1713         Apparently older versions of gcc have issues with this patch.
1714         Backing out a second time until the issues are resolved.
1715
1716 2008-11-06  David Kilzer  <ddkilzer@apple.com>
1717
1718         BUILD WAS NOT BROKEN: Rolling r38189 back in.
1719
1720         Please perform a clean build if you see crashes.
1721
1722 2008-11-06  David Kilzer  <ddkilzer@apple.com>
1723
1724         BUILD FIX: Backed out r38189 since it apparently broke the world.
1725
1726 2008-11-06  Chris Fleizach  <cfleizach@apple.com>
1727
1728         Reviewed by Beth Dakin.
1729
1730         Add ability to query an attribute's settable status and the
1731         ability to retrieve a single attribute from an AXObject
1732
1733         * DumpRenderTree/AccessibilityUIElement.cpp:
1734         (isAttributeSettableCallback):
1735         (attributeValueCallback):
1736         (AccessibilityUIElement::getJSClass):
1737         * DumpRenderTree/AccessibilityUIElement.h:
1738         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1739         (+[NSString stringWithJSStringRef:]):
1740         (AccessibilityUIElement::attributeValue):
1741         (AccessibilityUIElement::isAttributeSettable):
1742         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1743         (AccessibilityUIElement::attributeValue):
1744         (AccessibilityUIElement::isAttributeSettable):
1745
1746 2008-11-06  Greg Bolsinga  <bolsinga@apple.com>
1747
1748         Reviewed by Darin Adler.
1749
1750         Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
1751         https://bugs.webkit.org/show_bug.cgi?id=21810
1752
1753         Remove .o files from the exclude list that have had their exit-time destructors removed.
1754
1755         * Scripts/check-for-exit-time-destructors:
1756
1757 2008-11-05  Alp Toker  <alp@nuanti.com>
1758
1759         GTK build script tweak.
1760
1761         Make the path relative since it will appear in all -I compiler flags.
1762         Long argument lists cause bizarre slowdowns in libtool and result
1763         in huge build logs.
1764
1765         * Scripts/webkitdirs.pm:
1766
1767 2008-11-05  Anders Carlsson  <andersca@apple.com>
1768
1769         Fix 64-bit build.
1770
1771         * DumpRenderTree/mac/DumpRenderTree.mm:
1772         (setDefaultsToConsistentValuesForTesting):
1773
1774 2008-11-04  Simon Fraser  <simon.fraser@apple.com>
1775
1776         Add AccessibilityObject.o to the exclude list for the
1777         check for global destructors.
1778
1779         * Scripts/check-for-exit-time-destructors:
1780
1781 2008-11-04  Darin Adler  <darin@apple.com>
1782
1783         * Scripts/check-for-exit-time-destructors: Fix failures seen on the
1784         bot, but for some reason not on my computer.
1785
1786 2008-11-03  Darin Adler  <darin@apple.com>
1787
1788         Reviewed by Tim Hatcher.
1789
1790         - https://bugs.webkit.org/show_bug.cgi?id=22061
1791           create script to check for exit-time destructors
1792
1793         * Scripts/check-for-exit-time-destructors: Added.
1794         Started as a copy of check-for-global-initializers.
1795
1796         * Scripts/check-for-global-initializers: Added code to make
1797         this script rerun any time it's modified, and also to properly
1798         run again after the first time it reports an error.
1799
1800 2008-11-03  Pierre-Olivier Latour  <pol@apple.com>
1801
1802         Reviewed by Dan Bernstein.
1803
1804         Fixed the override of the "AppleScrollBarVariant" system setting to also work with HIToolbox.
1805
1806         https://bugs.webkit.org/show_bug.cgi?id=22054
1807
1808         * DumpRenderTree/mac/DumpRenderTree.mm:
1809         (setDefaultsToConsistentValuesForTesting):
1810
1811 2008-10-31  Cameron Zwarich  <zwarich@apple.com>
1812
1813         Not reviewed.
1814
1815         * Scripts/do-webcore-rename:
1816
1817         Add some renames to contemplate for the future.
1818
1819 2008-10-31  Darin Adler  <darin@apple.com>
1820
1821         Requested by Mark Rowe.
1822
1823         * Scripts/check-for-global-initializers: s/Web Kit/WebKit/.
1824
1825 2008-10-31  David Kilzer  <ddkilzer@apple.com>
1826
1827         Bug 21997: prepare-ChangeLog should filter out ChangeLog files
1828
1829         <https://bugs.webkit.org/show_bug.cgi?id=21997>
1830
1831         Reviewed by Darin Adler.
1832
1833         * Scripts/prepare-ChangeLog:
1834         (generateFileList): Don't add ChangeLog files to %{$functionLists}.
1835         This prevents them from showing up in the new ChangeLog entry.  They
1836         were already excluded from @{$changedFiles}.
1837
1838 2008-10-30  Mark Rowe  <mrowe@apple.com>
1839
1840         Reviewed by Jon Homeycutt.
1841
1842         Explicitly default to building for only the native architecture in debug and release builds.
1843
1844         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1845
1846 2008-10-30  Pierre-Olivier Latour  <pol@apple.com>
1847
1848         Reviewed by Dan Bernstein.
1849
1850         Fixed 64 bit build failure.
1851
1852         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1853         (setupMainDisplayColorProfile):
1854         (createBitmapContextFromWebView):
1855
1856 2008-10-28  Alp Toker  <alp@nuanti.com>
1857
1858         Fix GTK DRT following build breakage in r37928.
1859
1860         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1861         (dump):
1862         (runTest):
1863         (main):
1864
1865 2008-10-28  Alp Toker  <alp@nuanti.com>
1866
1867         Reviewed by Mark Rowe.
1868
1869         Fix recently introduced double-free crashes in GTK DRT.
1870
1871         LayoutTestController was made ref-counted in r36606 and Mac/Win DRT
1872         were updated to call ->deref() but GTK DRT was still deleting
1873         gLayoutTestController manually. This patch updates GTK to match the
1874         other ports and resolves the memory allocation issues.
1875
1876         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1877         (runTest):
1878
1879 2008-10-28  Alp Toker  <alp@nuanti.com>
1880
1881         Reviewed by Mark Rowe.
1882
1883         Fix GTK DRT hang when running the tests.
1884
1885         Update output from the DRT tool to print an additional '#EOF' to match
1886         breaking changes that were made in r37434.
1887
1888         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1889         (dump):
1890
1891 2008-10-28  Adele Peterson  <adele@apple.com>
1892
1893         Reviewed by Sam Weinig.
1894
1895         Specify which Localizable.strings to update since we don't always want to update the file in the same
1896         directory where we're searching for the strings to localize.
1897
1898         * Scripts/extract-localizable-strings:
1899         * Scripts/update-webkit-localizable-strings:
1900
1901 2008-10-28  Timothy Hatcher  <timothy@apple.com>
1902
1903         Add support for enabling the profiler, so the profiling tests can continue
1904         work now that the profiler is not always enabled.
1905
1906         https://bugs.webkit.org/show_bug.cgi?id=21927
1907
1908         <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
1909         not slow down JavaScript all the time
1910
1911         Reviewed by Darin Adler and Kevin McCullough.
1912
1913         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
1914         * DumpRenderTree/LayoutTestController.cpp:
1915         (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled.
1916         (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
1917         * DumpRenderTree/LayoutTestController.h:
1918         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1919         (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
1920         * DumpRenderTree/mac/DumpRenderTree.mm:
1921         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
1922         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1923         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
1924         * DumpRenderTree/win/DumpRenderTree.cpp:
1925         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
1926         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1927         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
1928
1929 2008-10-28  Pierre-Olivier Latour  <pol@apple.com>
1930
1931         Reviewed by Dan Bernstein
1932
1933         Primary changes in DumpRenderTree:
1934         - Ensure font smoothing is disabled (this is also called LCD anti-aliasing and
1935         is different from regular font CG anti-aliasing) as font-smoothing settings
1936         depends on the display and can also be changed by the user
1937         - Use a new cleared buffer for each test instead of the reusing same one to
1938         avoid potential result corruption across tests
1939         - Can now receive the expected pixel hash as a suffix to the test path or
1940         url as "path'hash"
1941         - Make sure hash is computed in a endian-independent way
1942         - Improve the code that sets/restores the screen color profile
1943         - Make the code more cross-platformy with std::string goodness
1944         - Added an "on-screen" mode where the snapshot will take into account surfaces
1945         on the window (like OpenGL content): this uses the new CG APIs on 10.5 or
1946         reading from the display framebuffer on 10.4. This mode is not active by
1947         default for performance reason, but must be explicitly activated from the test
1948         file using the new "testOnscreen()" JS API.
1949
1950         Primary changes in ImageDiff:
1951         - Provide a new comparison algorithm that is more tolerant to "acceptable"
1952         failures (i.e. very small differences in font rendering, which --threshold is
1953         not really good at handling)
1954         - Generate normalized intensity-only diff images
1955
1956         Primary changes in run-webkit-tests:
1957         - Take advantage of hashes for pixel tests which makes them much faster by
1958         minimizing image comparisons
1959         - Removed repaint options as these should be set from within test files using
1960         JS API
1961         - Replaced "threshold" option in  by "tolerance" expressed in percents
1962         - Added more logging when in "verbose" mode
1963
1964         https://bugs.webkit.org/show_bug.cgi?id=21322
1965         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1966         * DumpRenderTree/ForwardingHeaders/wtf/PassRefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h.
1967         * DumpRenderTree/ForwardingHeaders/wtf/RefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h.
1968         * DumpRenderTree/LayoutTestController.cpp:
1969         (LayoutTestController::LayoutTestController):
1970         (testOnscreenCallback):
1971         (LayoutTestController::staticFunctions):
1972         * DumpRenderTree/LayoutTestController.h:
1973         (LayoutTestController::testOnscreen):
1974         (LayoutTestController::setTestOnscreen):
1975         (LayoutTestController::testPathOrURL):
1976         (LayoutTestController::expectedPixelHash):
1977         * DumpRenderTree/PixelDumpSupport.h:
1978         * DumpRenderTree/cg/ImageDiffCG.cpp:
1979         (strtof):
1980         (releaseMallocBuffer):
1981         (createDifferenceImage):
1982         (imageHasAlpha):
1983         (main):
1984         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1985         (computeMD5HashStringForBitmapContext):
1986         (dumpWebViewAsPixelsAndCompareWithExpected):
1987         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1988         (BitmapContext::createByAdoptingBitmapAndContext):
1989         (BitmapContext::~BitmapContext):
1990         (BitmapContext::cgContext):
1991         (BitmapContext::BitmapContext):
1992         * DumpRenderTree/mac/DumpRenderTree.mm:
1993         (shouldIgnoreWebCoreNodeLeaks):
1994         (setDefaultsToConsistentValuesForTesting):
1995         (crashHandler):
1996         (initializeGlobalsFromCommandLineOptions):
1997         (prepareConsistentTestingEnvironment):
1998         (dumpRenderTree):
1999         (sizeWebViewForCurrentTest):
2000         (dump):
2001         (runTest):
2002         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2003         (restoreMainDisplayColorProfile):
2004         (setupMainDisplayColorProfile):
2005         (createBitmapContextFromWebView):
2006         * DumpRenderTree/win/DumpRenderTree.cpp:
2007         (dump):
2008         (runTest):
2009         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2010         (getBitmapContextFromWebView):
2011         * Scripts/run-webkit-tests:
2012
2013 2008-10-27  Kevin Ollivier  <kevino@theolliviers.com>
2014
2015         wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.
2016
2017         * wx/build-wxwebkit:
2018
2019 2008-10-24  Anders Carlsson  <andersca@apple.com>
2020
2021         Try fixing the 64-bit build.
2022
2023         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
2024         (testGetProperty):
2025
2026 2008-10-24  Anders Carlsson  <andersca@apple.com>
2027
2028         Reviewed by Sam Weinig.
2029
2030         <rdar://problem/5440917> Support NPN_Construct
2031
2032         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2033         (testCallback):
2034         Fix a memory leak.
2035
2036         (testConstruct):
2037         New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.
2038
2039         (pluginInvoke):
2040         Handle testConstruct.
2041
2042         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
2043         (testGetProperty):
2044         Add objectPointer property.
2045
2046         (testEnumerate):
2047         Only enumerate the two first properties.
2048
2049         (testConstruct):
2050         Add a simple construct implementation that just returns the test object.
2051
2052 2008-10-24  David Kilzer  <ddkilzer@apple.com>
2053
2054         Bug 21850: svn-apply and svn-unapply should preserve patch line endings
2055
2056         <https://bugs.webkit.org/show_bug.cgi?id=21850>
2057
2058         Reviewed by Adam Roben.
2059
2060         * Scripts/svn-apply: Save end-of-line characters when stripping them
2061         off each line of a patch so that they may be restored after
2062         processing the line.
2063         * Scripts/svn-unapply: Ditto.
2064
2065 2008-10-23  David Kilzer  <ddkilzer@apple.com>
2066
2067         Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
2068
2069         <https://bugs.webkit.org/show_bug.cgi?id=21832>
2070
2071         Reviewed by Sam Weinig.
2072
2073         * Scripts/bisect-builds: Use imported tempfile() from File::Temp
2074         instead of 'new File::Temp' to make the script work with Perl 5.10.
2075         * Scripts/sort-Xcode-project-file: Ditto.
2076
2077 2008-10-22  Brady Eidson  <beidson@apple.com>
2078
2079         Reviewed by Adam Roben
2080
2081         <rdar://6261773> - autocomplete="off" doesn't work on Windows
2082
2083         Implement LayoutTestController::elementDoesAutoCompleteForElementWithId() on Windows
2084
2085         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2086
2087 2008-10-22  Darin Adler  <darin@apple.com>
2088
2089         * Scripts/do-webcore-rename: More renaming plans.
2090
2091 2008-10-21  Steve Falkenburg  <sfalken@apple.com>
2092
2093         Exclude strings marked with UNLOCALIZED_STRING or UNLOCALIZED_LPCTSTR.
2094
2095         * Scripts/extract-localizable-strings:
2096
2097 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
2098
2099         Reviewed by Mark Rowe.
2100
2101         - default to 1000 tests per dump tool instance again, now that CTI no longer causes
2102         excess different stack logs.
2103
2104         (Also fix a small bug in my last change.)
2105
2106         * Scripts/run-webkit-tests:
2107
2108 2008-10-17  Stephanie Lewis  <slewis@apple.com>
2109
2110         Reviewed by Mark Rowe.
2111
2112         Fix layout tests that use prologues and epilogues.
2113
2114         * Scripts/run-webkit-tests:
2115
2116 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
2117
2118         Reviewed by Mark Rowe.
2119
2120         - make sure MallocStackLogging is only on for tools we want to
2121         leak check, not other random stuff as well.
2122
2123         * Scripts/run-webkit-tests:
2124
2125 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
2126
2127         Reviewed by Stephanie Lewis.
2128
2129         - make run-webkit-tests --leaks default to 100 tests per run instead of 1000
2130
2131         This should reduce or eliminate crashes on the buildbot due to
2132         running out of memory while stack logging.
2133
2134         * Scripts/run-webkit-tests:
2135
2136 2008-10-16  Jan Michael Alonzo  <jmalonzo@webkit.org>
2137
2138         Gtk build fix. Not reviewed.
2139
2140         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2141         (LayoutTestController::setSmartInsertDeleteEnabled):
2142
2143 2008-10-15  Glenn Wilson  <gwilson@google.com>
2144
2145         Added new method to allow tests to disable smart editing in the course of a test.
2146         This is a possible solution to bug .20655
2147
2148         Reviewed by Tim Hatcher.
2149
2150         * DumpRenderTree/LayoutTestController.cpp:
2151         (setSmartInsertDeleteEnabledCallback): new method
2152         (LayoutTestController::staticFunctions): added new method to static list of callbacks
2153         * DumpRenderTree/LayoutTestController.h: added signature of new method
2154         * DumpRenderTree/mac/DumpRenderTree.mm:
2155         (resetWebViewToConsistentStateBeforeTesting): added state resetting
2156         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2157         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
2158         * DumpRenderTree/win/DumpRenderTree.cpp:
2159         (resetWebViewToConsistentStateBeforeTesting): added state resetting
2160         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2161         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
2162
2163 2008-10-14  Ada Chan  <adachan@apple.com>
2164
2165         Fix windows build.
2166
2167         Reviewed by Sam Weinig.
2168
2169         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2170         * DumpRenderTree/config.h:
2171         * DumpRenderTree/win/DumpRenderTreeWin.h:
2172         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2173         * DumpRenderTree/win/UIDelegate.cpp:
2174
2175 2008-10-13  Timothy Hatcher  <timothy@apple.com>
2176
2177         Make prepare-ChangeLog populate the changed functions for JavaScript files.
2178
2179         https://bugs.webkit.org/show_bug.cgi?id=21567
2180
2181         Reviewed by David Kilzer.
2182
2183         * Scripts/prepare-ChangeLog:
2184         (get_function_line_ranges): Call get_function_line_ranges_for_javascript for
2185         files that end with ".js".
2186         (get_function_line_ranges_for_javascript): Find functions, anonymous functions
2187         and getters/setters.
2188
2189 2008-10-14  Alp Toker  <alp@nuanti.com>
2190
2191         Reviewed by Sam Weinig.
2192
2193         https://bugs.webkit.org/show_bug.cgi?id=16299
2194         Add a config.h file to DRT
2195
2196         Add a config.h to DumpRenderTree and reduce use of DumpRenderTree.h as
2197         an ad-hoc config header.
2198
2199         * DumpRenderTree/AccessibilityController.cpp:
2200         * DumpRenderTree/AccessibilityUIElement.cpp:
2201         * DumpRenderTree/AccessibilityUIElement.h:
2202         * DumpRenderTree/DumpRenderTree.h:
2203         * DumpRenderTree/GCController.cpp:
2204         * DumpRenderTree/LayoutTestController.cpp:
2205         * DumpRenderTree/WorkQueue.cpp:
2206         * DumpRenderTree/config.h: Added.
2207         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2208         * DumpRenderTree/gtk/GCControllerGtk.cpp:
2209         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2210         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2211         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2212         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2213         * DumpRenderTree/win/DumpRenderTree.cpp:
2214         * DumpRenderTree/win/DumpRenderTreeWin.h:
2215         * DumpRenderTree/win/EditingDelegate.cpp:
2216         * DumpRenderTree/win/EventSender.cpp:
2217         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2218         * DumpRenderTree/win/GCControllerWin.cpp:
2219         * DumpRenderTree/win/MD5.cpp:
2220         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2221         * DumpRenderTree/win/PolicyDelegate.cpp:
2222         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2223         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2224         * GNUmakefile.am:
2225
2226 2008-10-13  Chris Fleizach  <cfleizach@apple.com>
2227
2228         Reviewed by Beth Dakin.
2229
2230         Added a method to get the links in a webpage
2231
2232         * DumpRenderTree/AccessibilityUIElement.cpp:
2233         (attributesOfDocumentLinksCallback):
2234         (AccessibilityUIElement::getJSClass):
2235         * DumpRenderTree/AccessibilityUIElement.h:
2236         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2237         (AccessibilityUIElement::getDocumentLinks):
2238         (AccessibilityUIElement::attributesOfDocumentLinks):
2239         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2240         (AccessibilityUIElement::getDocumentLinks):
2241         (AccessibilityUIElement::attributesOfDocumentLinks):
2242
2243 2008-10-13  David Kilzer  <ddkilzer@apple.com>
2244
2245         Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range
2246
2247         <https://bugs.webkit.org/show_bug.cgi?id=21457>
2248
2249         Reviewed by Adam.
2250
2251         * Scripts/resolve-ChangeLogs: Added optional parameter to
2252         -f|--fix-merged switch to run the script on a revision range.
2253         Updated command-line validation checks.
2254         (findChangeLog): Fixed long-standing bug that should have used
2255         $_[0] instead of $_.
2256         (fixMergedChangeLog): Renamed to fixOneMergedChangeLog($).  Updated
2257         to work when called from git filter-branch.  It always restores a
2258         copy of the previous revision before reapplying the patch.
2259         (fixMergedChangeLogs): Added.  Calls itself through git filter-branch
2260         to re-merge ChangeLog files across a revision range.  Removes
2261         .git/refs/original directory on success.
2262         (parseFixMerged): Added.  Custom method to parse the -f|--fix-merged
2263         switch.
2264         (removeChangeLogArguments): Added.  Removes items from @ARGV when
2265         they are ChangeLog paths, and return a list of paths.  This makes it
2266         easier to validate the command-line.
2267         (resolveChangeLog): Added.  Extracted from main code block.  Runs
2268         the traditional single-file merge algorithm.
2269         (usageAndExit): Added.  Extracted from main code block.  Prints
2270         usage statement and exits with error status.
2271
2272 2008-10-12  Darin Adler  <darin@apple.com>
2273
2274         * Scripts/make-js-test-wrappers: Update exceptions list so the script
2275         won't overwrite files and mangle tests.
2276
2277 2008-10-11  Dan Bernstein  <mitz@apple.com>
2278
2279         Reviewed by Sam Weinig and Anders Carlsson.
2280
2281         - update Mac DumpRenderTree to use the new WebView SPI for forcing the
2282           complex text code path
2283         - add --complex-text support to Windows DumpRenderTree
2284
2285         * DumpRenderTree/mac/DumpRenderTree.mm:
2286         (dumpRenderTree):
2287         * DumpRenderTree/win/DumpRenderTree.cpp:
2288         (createWebViewAndOffscreenWindow):
2289         (main):
2290         * Scripts/run-webkit-tests:
2291
2292 2008-10-09  Eric Seidel  <eric@webkit.org>
2293
2294         Reviewed by Oliver Hunt.
2295
2296         https://bugs.webkit.org/show_bug.cgi?id=21498
2297
2298         * Scripts/make-js-test-wrappers: ignore resources/shadow-offset.js
2299
2300 2008-10-09  Cameron Zwarich  <zwarich@apple.com>
2301
2302         Not reviewed.
2303
2304         Add StructureID.o to the exclusion list in the global initializers
2305         script to fix the Debug build.
2306
2307         * Scripts/check-for-global-initializers:
2308
2309 2008-10-08  Mark Rowe  <mrowe@apple.com>
2310
2311         Fix the Windows build after r37434.
2312
2313         * DumpRenderTree/win/DumpRenderTree.cpp:
2314         (dump): Update code to approximate valid C++ syntax.
2315
2316 2008-10-08  Timothy Hatcher  <timothy@apple.com>
2317
2318         Add SVGElementInstance to the list of exceptions that have
2319         global initializers in debug builds.
2320
2321         Rubber-stamped by Mark Rowe.
2322
2323         * Scripts/check-for-global-initializers: Add SVGElementInstance.o.
2324
2325 2008-10-08  Simon Fraser  <simon.fraser@apple.com>
2326
2327         Reviewed by Dan Bernstein
2328
2329         Avoid disconnect between DRT and run-webkit-tests
2330         about whether to expect PNG dumps by having DRT always
2331         print two blocks terminated by #EOF, the second of which
2332         may be empty.
2333
2334         https://bugs.webkit.org/show_bug.cgi?id=21483
2335
2336         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2337         (printPNG):
2338         (dumpWebViewAsPixelsAndCompareWithExpected):
2339         * DumpRenderTree/mac/DumpRenderTree.mm:
2340         (dump):
2341         * DumpRenderTree/win/DumpRenderTree.cpp:
2342         (dump):
2343         * Scripts/run-webkit-tests:
2344
2345 2008-10-07  Adam Roben  <aroben@apple.com>
2346
2347         Make sure short functions get included in ChangeLog output for git
2348         repositories
2349
2350         Reviewed by Dave Kilzer.
2351
2352         * Scripts/prepare-ChangeLog:
2353         (sub diffCommand): Pass -U0 to git diff so that each contiguous change
2354         will get its own chunk without any surrounding context.
2355         (sub extractLineRange): Use the line numbers from the chunk header
2356         without modifying them now that they're accurate.
2357
2358 2008-10-04  Mark Rowe  <mrowe@apple.com>
2359
2360         Reviewed by Tim Hatcher.
2361
2362         Update check-for-weak-vtables to check only the final linked image for weak vtables.
2363         This gives more useful results than checking each object file independently.
2364
2365         * Scripts/check-for-weak-vtables:
2366
2367 2008-10-03  Pierre-Olivier Latour <pol@apple.com>
2368
2369         Reviewed by Darin Adler
2370
2371         Render images to RGBA8 bitmaps independently of platform endianness.
2372
2373         Create image difference bitmap in reference image colorspace instead of device colorspace
2374         (which depends on the main display profile), so that no color matching happens.
2375
2376         https://bugs.webkit.org/show_bug.cgi?id=21336
2377
2378         * DumpRenderTree/cg/ImageDiffCG.cpp:
2379         (createDifferenceBitmap):
2380         (computePercentageDifferent):
2381         (compareImages):
2382
2383 2008-10-02  Simon Fraser  <simon.fraser@apple.com>
2384
2385         Reviewed by Darin Adler
2386
2387         Fix hang when running with --pixel --reset, which occurs
2388         because DRT spews PNG data when the script does not expect it.
2389
2390         https://bugs.webkit.org/show_bug.cgi?id=21323
2391
2392         * Scripts/run-webkit-tests:
2393
2394 2008-09-30  Mark Rowe  <mrowe@apple.com>
2395
2396         Reviewed by Dan Bernstein.
2397
2398         Add a leak counter for CachedResources since we've had two recent leaks involving them.
2399
2400         * Scripts/check-for-global-initializers:
2401
2402 2008-09-30  Mark Rowe  <mrowe@apple.com>
2403
2404         Rubber-stamped by Dan Bernstein.
2405
2406         Fix many leaks seen on fast/backgrounds/svg-as-background-1.html.
2407
2408         JavaScript wrappers were keeping DOM objects alive, which was leading to the SVG background image
2409         being kept alive in the memory cache past our last attempt to empty the cache prior to quitting.
2410         We need to empty the memory cache after forcing a JavaScript garbage collection to ensure that
2411         any live JavaScript wrappers are collected and their corresponding DOM objects have a chance to be
2412         torn down before we exit.
2413
2414         * DumpRenderTree/mac/DumpRenderTree.mm:
2415         (dumpRenderTree):
2416         (main):
2417
2418 2008-09-30  Simon Fraser  <simon.fraser@apple.com>
2419
2420         Reviewed by Dan Bernstein
2421
2422         Don't run pixel comparison for text-only tests.
2423         https://bugs.webkit.org/show_bug.cgi?id=21124
2424
2425         * DumpRenderTree/mac/DumpRenderTree.mm:
2426         (dump):
2427         * Scripts/run-webkit-tests:
2428
2429 2008-09-29  Thiago Macieira  <thiago.macieira@nokia.com>
2430
2431         Reviewed by Simon.
2432
2433         Changed copyright from Trolltech ASA to Nokia.
2434
2435         Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
2436
2437
2438         * DumpRenderTree/qt/DumpRenderTree.cpp:
2439         * DumpRenderTree/qt/jsobjects.cpp:
2440         * DumpRenderTree/qt/jsobjects.h:
2441         * DumpRenderTree/qt/main.cpp:
2442         * DumpRenderTree/qt/testplugin.cpp:
2443         * DumpRenderTree/qt/testplugin.h:
2444
2445 2008-09-28  David Kilzer  <ddkilzer@apple.com>
2446
2447         Bug 21185: resolve-ChangeLogs should be able to fix poorly merged ChangeLog entries after a git svn rebase
2448
2449         <https://bugs.webkit.org/show_bug.cgi?id=21185>
2450
2451         Reviewed by Adam.
2452
2453         * Scripts/resolve-ChangeLogs: Added new -f|--fix-merge switch that
2454         will attempt to reapply the last commit to a ChangeLog file such
2455         that the ChangeLog entry appears at the top of the file.
2456         (findChangeLog): Added prototype and moved method below the exit
2457         statement.
2458         (fixMergedChangeLog): Added.  Method to fix incorrectly merged
2459         ChangeLog entries.
2460
2461 2008-09-27  Anders Carlsson  <andersca@apple.com>
2462
2463         Reviewed by Sam Weinig.
2464
2465         https://bugs.webkit.org/show_bug.cgi?id=21178
2466         <rdar://problem/6248651>
2467
2468         Return the result value from getURL.
2469
2470         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2471         (getURL):
2472
2473 2008-09-26  Matt Lilek  <webkit@mattlilek.com>
2474
2475         Reviewed by Tim Hatcher.
2476
2477         Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.
2478
2479         * Scripts/build-webkit:
2480
2481 2008-09-26  Alice Liu  <alice.liu@apple.com>
2482
2483         Remove usage of atlstr.h and CString for VCExpress compatibility
2484
2485         Reviewed by Stephanie Lewis.
2486
2487         * record-memory-win/main.cpp:
2488         (ProcessArgs):
2489         (UseImage):
2490         (QueryContinuously):
2491         (OneQuery):
2492         (OneQueryMP):
2493
2494 2008-09-26  Kevin Ollivier  <kevino@theolliviers.com>
2495
2496         wx build fix. Update the version of libpng.
2497
2498         * wx/install-unix-extras:
2499
2500 2008-09-24  Sam Weinig  <sam@webkit.org>
2501
2502         Reviewed by Darin Adler.
2503
2504         Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
2505         <rdar://problem/6243534>
2506         Crash below Function.apply when using a runtime array as the argument list
2507
2508         Add method to ObjCController to return a runtime array.
2509
2510         * DumpRenderTree/mac/ObjCController.m:
2511         (+[ObjCController isSelectorExcludedFromWebScript:]):
2512         (+[ObjCController webScriptNameForSelector:]):
2513         (-[ObjCController testArray]):
2514
2515 2008-09-24  Beth Dakin  <bdakin@apple.com>
2516
2517         Reviewed by Sam Weinig.
2518
2519         Speculative build fix.
2520
2521         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2522         (AccessibilityUIElement::supportsPressAction):
2523
2524 2008-09-23  Beth Dakin  <bdakin@apple.com>
2525
2526         Reviewed by Sam Weinig.
2527
2528         This patch extends DumpRenderTree's AccessibilityController to ask
2529         if the focused element supports the press action.
2530
2531         * DumpRenderTree/AccessibilityUIElement.cpp:
2532         (getSupportsPressActionCallback):
2533         (AccessibilityUIElement::getJSClass):
2534         * DumpRenderTree/AccessibilityUIElement.h:
2535         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2536         (AccessibilityUIElement::supportsPressAction):
2537
2538 2008-09-22  Alice Liu  <alice.liu@apple.com>
2539
2540         Adding a stand-alone Windows console application to record a process's memory usage
2541
2542         Reviewed by Steve Falkenburg.
2543
2544         * record-memory-win: Added.
2545         * record-memory-win/main.cpp: Added.
2546         * record-memory-win/record-memory-win.vcproj: Added.
2547
2548 2008-09-22  Chris Fleizach  <cfleizach@apple.com>
2549
2550         Reviewed by Darin Adler.
2551
2552         Support ability to get/set selected text ranges for text controls through AX.
2553
2554         * DumpRenderTree/AccessibilityUIElement.cpp:
2555         (setSelectedTextRangeCallback):
2556         (getSelectedTextRangeCallback):
2557         (AccessibilityUIElement::getJSClass):
2558         * DumpRenderTree/AccessibilityUIElement.h:
2559         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2560         (AccessibilityUIElement::attributesOfRowHeaders):
2561         (AccessibilityUIElement::attributesOfVisibleCells):
2562         (AccessibilityUIElement::rowIndexRange):
2563         (AccessibilityUIElement::columnIndexRange):
2564         (AccessibilityUIElement::cellForColumnAndRow):
2565         (AccessibilityUIElement::selectedTextRange):
2566         (AccessibilityUIElement::setSelectedTextRange):
2567         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2568         (AccessibilityUIElement::selectedTextRange):
2569         (AccessibilityUIElement::setSelectedTextRange):
2570
2571 2008-09-20  Darin Adler  <darin@apple.com>
2572
2573         * DumpRenderTree/mac/DumpRenderTree.mm:
2574         (convertMIMEType): Turn on Stephanie's workaround for Tiger too.
2575
2576 2008-09-19  Alp Toker  <alp@nuanti.com>
2577
2578         Build fix for the 'gold' linker and recent binutils. New behaviour
2579         requires that we link to used libraries explicitly.
2580
2581         * GNUmakefile.am:
2582
2583 2008-09-19  Stephanie Lewis  <slewis@apple.com>
2584
2585         Reviewed by Oliver Hunt.
2586
2587         Implement a workaround for an incorrect mime-type on machines with
2588         Dashcode 2.0.1.  Dashcode is overriding the UTI type for .js files.
2589         See radar <rdar://problem/6234318>.
2590
2591         * DumpRenderTree/mac/DumpRenderTree.mm:
2592         (convertMIMEType):
2593
2594 2008-09-19  Chris Fleizach  <cfleizach@apple.com>
2595
2596         Fixed Windows bustage
2597
2598         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2599         (AccessibilityUIElement::titleUIElement):
2600
2601 2008-09-18  Chris Fleizach  <cfleizach@apple.com>
2602
2603         Reviewed by Darin Adler.
2604
2605         Expose titleUIElement call for DumpRenderTree
2606
2607         * ChangeLog:
2608         * DumpRenderTree/AccessibilityUIElement.cpp:
2609         (titleUIElementCallback):
2610         (AccessibilityUIElement::getJSClass):
2611         * DumpRenderTree/AccessibilityUIElement.h:
2612         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2613         (AccessibilityUIElement::titleUIElement):
2614
2615 2008-09-18  Darin Adler  <darin@apple.com>
2616
2617         * Scripts/do-webcore-rename: More renaming plans.
2618
2619 2008-09-18  Mark Rowe  <mrowe@apple.com>
2620
2621         Reviewed by Dan Bernstein.
2622
2623         Clear the main frame's name between tests to get more consistent test results
2624         when running the WebKit tests with --nthly.
2625
2626         * DumpRenderTree/mac/DumpRenderTree.mm:
2627         (resetWebViewToConsistentStateBeforeTesting):
2628         * DumpRenderTree/win/DumpRenderTree.cpp:
2629         (resetWebViewToConsistentStateBeforeTesting):
2630
2631 2008-09-18  Stephanie Lewis  <slewis@apple.com>
2632
2633         Really fix tiger jsc tests.
2634
2635         * Scripts/run-javascriptcore-tests:
2636
2637 2008-09-18  Stephanie Lewis  <slewis@apple.com>
2638
2639         Reviewed by Maciej Stachowiak.
2640
2641         Fix jsc tests on Tiger.  Make jsc tests smarter about when to use the arch flag.
2642
2643         * Scripts/run-javascriptcore-tests:
2644         * Scripts/webkitdirs.pm:
2645
2646 2008-09-18  Mark Rowe  <mrowe@apple.com>
2647
2648         Rubber-stamped by Sam Weinig.
2649
2650         Print warning to stdout rather than stderr when a test attempts to access a remote resource.
2651         This should make it more obvious when a test does this, as stderr output tends to be obscured
2652         by noise in the test results.
2653
2654         Also fixes some coding style issues in ResourceLoadDelegate.mm.
2655
2656         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2657         (-[NSError _drt_descriptionSuitableForTestResult]):
2658         (-[NSURL _drt_descriptionSuitableForTestResult]):
2659         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2660         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2661         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2662         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2663         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2664         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2665
2666 2008-09-18  Stephanie Lewis  <slewis@apple.com>
2667
2668         Reviewed by Mark Rowe and Maciej Stachowiak..
2669
2670         add a --64-bit option and specify which architecture to run on Mac.
2671
2672         * Scripts/run-javascriptcore-tests:
2673
2674 2008-09-17  Mark Rowe  <mrowe@apple.com>
2675
2676         Reviewed by Sam Weinig.
2677
2678         Fix a crash seen running DumpRenderTree on fast/dom/null-document-window-open-crash.html under guard malloc.
2679
2680         The JS wrapper for LayoutTestController could outlive the wrapped instance, and would crash when
2681         attempting to access the wrapped instance within layoutTestControllerObjectFinalize. We fix this by making
2682         LayoutTestController ref-counted to ensure that it is not outlived by the JS wrapper.
2683
2684         * DumpRenderTree/ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h.
2685         * DumpRenderTree/LayoutTestController.cpp:
2686         (LayoutTestController::LayoutTestController):
2687         (notifyDoneCallback): Remove code that is no longer needed now that we must always have a wrapped instance.
2688         (layoutTestControllerObjectFinalize): Deref the wrapped object.
2689         (LayoutTestController::makeWindowObject): Ref the wrapped object.
2690         * DumpRenderTree/LayoutTestController.h: Make LayoutTestController RefCounted.
2691         * DumpRenderTree/mac/DumpRenderTree.mm:
2692         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
2693         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Remove code that is no longer needed.
2694         * DumpRenderTree/win/DumpRenderTree.cpp:
2695         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
2696
2697 2008-09-16  Sam Weinig  <sam@webkit.org>
2698
2699         Reviewed by Mark Rowe.
2700
2701         Add flag to disable running sample on tests that timeout.
2702
2703         * Scripts/run-webkit-tests:
2704
2705 2008-09-16  Adam Roben  <aroben@apple.com>
2706
2707         Windows build fix after r36511
2708
2709         Update for rename of layoutTestController to gLayoutTestController.
2710
2711         * DumpRenderTree/LayoutTestController.cpp:
2712         * DumpRenderTree/win/EditingDelegate.cpp:
2713         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2714         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2715         * DumpRenderTree/win/UIDelegate.cpp:
2716
2717 2008-09-16  Adam Roben  <aroben@apple.com>
2718
2719         Add a script to print out the dependency tree of a Visual Studio
2720         solution file
2721
2722         * Scripts/print-msvc-project-dependencies: Added.
2723
2724 2008-09-16  Mark Rowe  <mrowe@apple.com>
2725
2726         Fix the build.
2727
2728         * DumpRenderTree/LayoutTestController.cpp:
2729         (notifyDoneCallback): Call fprintf in a safer manner.
2730
2731 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
2732
2733         Reviewed by Eric Seidel
2734
2735         Protect against tests that call layoutTestController.notifyDone()
2736         more than once, which would lead to memory corruption, by nulling
2737         out the LayoutTestController on the JSObjectRef on destruction. Also
2738         add a finalize callback on the class so that if the LTC outlives
2739         the JSObjectRef, the JSObjectRef backpointer on the LTC can be
2740         nulled out.
2741
2742         https://bugs.webkit.org/show_bug.cgi?id=20875
2743
2744         * DumpRenderTree/LayoutTestController.cpp:
2745         (LayoutTestController::LayoutTestController):
2746         (notifyDoneCallback):
2747         (layoutTestControllerObjectFinalize):
2748         (LayoutTestController::makeWindowObject):
2749         (LayoutTestController::getJSClass):
2750         * DumpRenderTree/LayoutTestController.h:
2751         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2752         (LayoutTestController::~LayoutTestController):
2753
2754 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
2755
2756         Reviewed by Eric Seidel
2757
2758         Step 1 patch: rename global variable for clarity.
2759         https://bugs.webkit.org/show_bug.cgi?id=20875
2760
2761         * DumpRenderTree/DumpRenderTree.h:
2762         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2763         (dumpWebViewAsPixelsAndCompareWithExpected):
2764         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2765         (dumpFramesAsText):
2766         (dump):
2767         (runTest):
2768         (processWork):
2769         (webViewLoadFinished):
2770         (webViewWindowObjectCleared):
2771         * DumpRenderTree/mac/DumpRenderTree.mm:
2772         (allocateGlobalControllers):
2773         (dumpFrameScrollPosition):
2774         (dumpFramesAsText):
2775         (methodNameStringForFailedTest):
2776         (dump):
2777         (runTest):
2778         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2779         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2780         * DumpRenderTree/mac/EditingDelegate.mm:
2781         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2782         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2783         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2784         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2785         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2786         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2787         (-[EditingDelegate webViewDidBeginEditing:]):
2788         (-[EditingDelegate webViewDidChange:]):
2789         (-[EditingDelegate webViewDidEndEditing:]):
2790         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2791         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2792         (-[FrameLoadDelegate processWork:]):
2793         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2794         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2795         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2796         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2797         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2798         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2799         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2800         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2801         * DumpRenderTree/mac/UIDelegate.mm:
2802         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
2803         (-[UIDelegate webViewFocus:]):
2804         (-[UIDelegate webViewUnfocus:]):
2805         (-[UIDelegate webView:createWebViewWithRequest:]):
2806         (-[UIDelegate webViewClose:]):
2807         * DumpRenderTree/win/DumpRenderTree.cpp:
2808         (dumpFrameScrollPosition):
2809         (dumpFramesAsText):
2810         (dump):
2811         (runTest):
2812
2813 2008-09-15  Alice Liu  <alice.liu@apple.com>
2814
2815         A change needed to make PPC bots pass accessibility/table-cell-spans.html layout test
2816
2817         Reviewed by Stephanie Lewis.
2818
2819         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2820         Calling -[NSValue rangeValue] on nil object was returning bogus results on PPC,
2821         but not Intel.  Add a check for nil before calling.
2822         (AccessibilityUIElement::rowIndexRange):
2823         (AccessibilityUIElement::columnIndexRange):
2824
2825 2008-09-14  Mark Rowe  <mrowe@apple.com>
2826
2827         Build fix.
2828
2829         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2830         (waitUntilDoneWatchdogFired):
2831         * DumpRenderTree/mac/ObjCPlugin.m:
2832
2833 2008-09-08  Dan Bernstein  <mitz@apple.com>
2834
2835         Reviewed by Mark Rowe.
2836
2837         - add an option to run-webkit-tests to always use the complex text code path
2838
2839         * DumpRenderTree/mac/DumpRenderTree.mm:
2840         (initializeGlobalsFromCommandLineOptions):
2841         (dumpRenderTree):
2842         * Scripts/run-webkit-tests:
2843
2844 2008-09-08  Steve Falkenburg  <sfalken@apple.com>
2845
2846         Another Windows nightly build fix.
2847
2848         Reviewed by Sam Weinig.
2849
2850         * FindSafari/FindSafari.cpp:
2851         (_tmain): Delete existing WebKitNightly directory in temp.
2852         * FindSafari/Safari.exe.manifest: Add PROGIDs for each COM class. Remove non-production classes.
2853
2854 2008-09-07  Stephanie Lewis  <slewis@apple.com>
2855
2856         Reviewed by Mark Rowe.
2857
2858         Fix DRT build
2859
2860         * DumpRenderTree/DumpRenderTreePrefix.h:
2861         * DumpRenderTree/win/DumpRenderTree.vcproj:
2862
2863 2008-09-06  Steve Falkenburg  <sfalken@apple.com>
2864
2865         Fix Windows nightlies.
2866
2867         Copy WebKit.dll alongside application so registry-free COM can find it.
2868         Update embedded manifest to force use registry-free COM.
2869
2870         Reviewed by Dave Hyatt.
2871
2872         * FindSafari/FindSafari.cpp:
2873         (copyManifest):
2874         (replaceManifest):
2875         (_tmain):
2876         * FindSafari/FindSafari.rc: Added.
2877         * FindSafari/FindSafari.vcproj:
2878         * FindSafari/Safari.exe.manifest: Added.
2879         * FindSafari/resource.h: Added.
2880
2881 === End merge of squirrelfish-extreme ===
2882
2883 2008-08-31  Mark Rowe  <mrowe@apple.com>
2884
2885         Reviewed by Maciej Stachowiak.
2886
2887         Add a --profile flag to run-sunspider.
2888
2889         * Scripts/webkitdirs.pm: Detect --profile or --profiling passed as a command-line argument
2890         to build scripts as indicating that we should use the "Profiling" configuration.  At present
2891         this is only supported by JavaScriptCore, so using this argument to build any other project
2892         will likely result in unexpected behaviour.
2893
2894 2008-08-27  Mark Rowe  <mrowe@apple.com>
2895
2896         Reviewed by Oliver Hunt.
2897
2898         Fix run-webkit-tests to handle DRT exiting early.
2899
2900         * Scripts/run-webkit-tests: Initialize $expectedResultPaths{$base} before it will be used.
2901
2902 === Start merge of squirrelfish-extreme ===
2903
2904 2008-09-04  Mark Rowe  <mrowe@apple.com>
2905
2906         Reviewed by Eric Seidel.
2907
2908         Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
2909         Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
2910
2911         * Scripts/build-webkit: Remove ENABLE_DASHBOARD_SUPPORT-related code.
2912
2913 2008-09-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2914
2915         Reviewed by Oliver Hunt.
2916
2917         Bug 20616: Incorporate V8 benchmarks in testing
2918         <https://bugs.webkit.org/show_bug.cgi?id=20616>
2919
2920         Add support for the --v8 option to run-sunspider.
2921
2922         * Scripts/run-sunspider:
2923
2924 2008-09-04  Kevin Ollivier  <kevino@theolliviers.com>
2925
2926         wx buildbot fix. More robust handling of clean when makefiles are not built or
2927         are not completely made.
2928
2929         * wx/build-wxwebkit:
2930
2931 2008-09-03  Mark Rowe  <mrowe@apple.com>
2932
2933         More Mac build fixes.
2934
2935         Set ENABLE_DASHBOARD_SUPPORT when building for Mac via build-webkit.
2936         Also set ENABLE_CROSS_DOCUMENT_MESSAGING in order to match the
2937         default configuration specified in the .xcconfig files.
2938
2939         * Scripts/build-webkit:
2940
2941 2008-09-03  Mark Rowe  <mrowe@apple.com>
2942
2943         Mac build fix.  Ensure that dashboard support is enabled.
2944
2945         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2946
2947 2008-08-25  Steve Falkenburg  <sfalken@apple.com>
2948
2949         Build fix. Copy correct version of ICU.
2950
2951         * DumpRenderTree/win/DumpRenderTree.vcproj:
2952
2953 2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>
2954
2955         Reviewed by Simon.
2956
2957         [run-webkit-tests] Use QtLauncher to show the results of the tests
2958         konqueror might not be installed, xdg-open might not be installed but the
2959         QtLauncher should be present.
2960
2961         * Scripts/run-webkit-tests:
2962
2963 2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>
2964
2965         Initial support for accessibility layout tests on Windows.
2966         https://bugs.webkit.org/show_bug.cgi?id=20497
2967
2968         Reviewed by Sam Weinig.
2969
2970         * DumpRenderTree/AccessibilityController.h: Fix typos.
2971         * DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
2972         * DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to
2973         prevent oleacc.h, which includes windows.h, from including winsock.h.
2974         Fixed typos.
2975         * DumpRenderTree/win/AccessibilityControllerWin.cpp: Added.
2976         (AccessibilityController::AccessibilityController):
2977         (AccessibilityController::~AccessibilityController):
2978         (AccessibilityController::focusedElement): Get the root element, and
2979         request its focused object.
2980         (AccessibilityController::rootElement): Query Windows for the
2981         accessible client object for the WebView's window.
2982         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added.
2983         (AccessibilityUIElement::AccessibilityUIElement):
2984         (AccessibilityUIElement::~AccessibilityUIElement):
2985         (AccessibilityUIElement::getLinkedUIElements): Not implemented.
2986         (AccessibilityUIElement::getChildren): Get the child count, and append
2987         each child.
2988         (AccessibilityUIElement::getChildAtIndex): Get the child at the given
2989         index offset by 1. In MSAA, child 0 is the object itself.
2990         (AccessibilityUIElement::allAttributes): Not implemented.
2991         (AccessibilityUIElement::attributesOfLinkedUIElements): Same.
2992         (AccessibilityUIElement::attributesOfChildren): Same.
2993         (AccessibilityUIElement::parameterizedAttributeNames): Same.
2994         (self): Return a VARIANT representing the "self" object. This is used
2995         when calling methods that require a child variant.
2996         (AccessibilityUIElement::role): Get the MSAA role, a long value, and
2997         convert it into a string with GetRoleText().
2998         (AccessibilityUIElement::title): Get the element's title, and convert
2999         it to a JS String.
3000         (AccessibilityUIElement::description): Same, for description.
3001         (AccessibilityUIElement::width):
3002         (AccessibilityUIElement::height):
3003         (AccessibilityUIElement::intValue): Get the object's value as a string,
3004         and convert the string to a double.
3005         (AccessibilityUIElement::minValue): Not implemented.
3006         (AccessibilityUIElement::maxValue): Same.
3007         (AccessibilityUIElement::insertionPointLineNumber): Same.
3008         (AccessibilityUIElement::attributesOfColumnHeaders): Same.
3009         (AccessibilityUIElement::attributesOfRowHeaders): Same.
3010         (AccessibilityUIElement::attributesOfColumns): Same.
3011         (AccessibilityUIElement::attributesOfRows): Same.
3012         (AccessibilityUIElement::attributesOfVisibleCells): Same.
3013         (AccessibilityUIElement::attributesOfHeader): Same.
3014         (AccessibilityUIElement::indexInTable): Same.
3015         (AccessibilityUIElement::rowIndexRange): Same.
3016         (AccessibilityUIElement::columnIndexRange): Same.
3017         (AccessibilityUIElement::lineForIndex): Same.
3018         (AccessibilityUIElement::boundsForRange): Same.
3019         (AccessibilityUIElement::cellForColumnAndRow): Same.
3020         * DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to
3021         project.  Link to oleacc.lib, the MSAA library.
3022         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3023         (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility
3024         controller.
3025         (FrameLoadDelegate::didClearWindowObject): Create a new window object
3026         for the accessibility controller.
3027         * DumpRenderTree/win/FrameLoadDelegate.h:
3028
3029 2008-08-21  Simon Fraser  <simon.fraser@apple.com>
3030
3031         Reviewed by Mark Rowe
3032
3033         Make build-launcher-app work when run from a git repository.
3034         https://bugs.webkit.org/show_bug.cgi?id=20478
3035
3036         * BuildSlaveSupport/build-launcher-app:
3037
3038 2008-08-20  Maxime Britto  <britto@apple.com>
3039
3040         Reviewed by Ada Chan.
3041
3042          rdar://5259746
3043         Mouse events are sent to page while resizing window (affects Gmail)
3044
3045         * DumpRenderTree/win/UIDelegate.h:
3046         (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.
3047
3048 2008-08-19  Chris Fleizach  <cfleizach@apple.com>
3049
3050         Reviewed by Beth Dakin.
3051
3052         Add snowleopard platform in layout tests
3053
3054         Added support for accessing the attributes of
3055         accessibility tables through the accessibility controller
3056         in DumpRenderTree
3057
3058         * DumpRenderTree/AccessibilityUIElement.cpp:
3059         (attributesOfColumnHeadersCallback):
3060         (attributesOfRowHeadersCallback):
3061         (attributesOfColumnsCallback):
3062         (attributesOfRowsCallback):
3063         (attributesOfVisibleCellsCallback):
3064         (attributesOfHeaderCallback):
3065         (indexInTableCallback):
3066         (rowIndexRangeCallback):
3067         (columnIndexRangeCallback):
3068         (childAtIndexCallback):
3069         (cellForColumnAndRowCallback):
3070         (AccessibilityUIElement::getJSClass):
3071         * DumpRenderTree/AccessibilityUIElement.h:
3072         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3073         (convertNSArrayToVector):
3074         (descriptionOfElements):
3075         (AccessibilityUIElement::getLinkedUIElements):
3076         (AccessibilityUIElement::getChildren):
3077         (AccessibilityUIElement::attributesOfLinkedUIElements):
3078         (AccessibilityUIElement::attributesOfChildren):
3079         (AccessibilityUIElement::attributesOfColumnHeaders):
3080         (AccessibilityUIElement::attributesOfRowHeaders):
3081         (AccessibilityUIElement::attributesOfColumns):
3082         (AccessibilityUIElement::attributesOfRows):
3083         (AccessibilityUIElement::attributesOfVisibleCells):
3084         (AccessibilityUIElement::attributesOfHeader):
3085         (AccessibilityUIElement::indexInTable):
3086         (AccessibilityUIElement::rowIndexRange):
3087         (AccessibilityUIElement::columnIndexRange):
3088         (AccessibilityUIElement::cellForColumnAndRow):
3089         * Scripts/run-webkit-tests:
3090
3091 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
3092
3093         Reviewed by Darin Adler.
3094
3095         Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
3096         is waiting for crash reporter to let it exit.
3097
3098         The fix does not work on Tiger, because the state of the process is indistinguishable from
3099         other waiting processes, at least not with this technique.
3100
3101         * Scripts/run-webkit-tests:
3102
3103 2008-08-18  Alp Toker  <alp@nuanti.com>
3104
3105         Reviewed by Holger Freyther.
3106
3107         https://bugs.webkit.org/show_bug.cgi?id=20350
3108         [GTK] Get DumpRenderTree working
3109
3110         Fixes and enhancements to DumpRenderTree. With these changes, the test
3111         suite can now complete a run producing text and render tree dumps.
3112
3113         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3114         (dumpFramesAsText):
3115         (dump):
3116         (runTest):
3117         (webViewLoadFinished):
3118         (webViewWindowObjectCleared):
3119         (webViewConsoleMessage):
3120         (webViewScriptAlert):
3121         (webViewScriptPrompt):
3122         (webViewScriptConfirm):
3123         (webViewTitleChanged):
3124         (main):
3125         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3126         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3127         (LayoutTestController::clearBackForwardList):
3128         (LayoutTestController::pathToLocalResource):
3129         (LayoutTestController::setAcceptsEditing):
3130         (LayoutTestController::setUserStyleSheetEnabled):
3131         (LayoutTestController::setUserStyleSheetLocation):
3132         (waitToDumpWatchdogFired):
3133         (LayoutTestController::windowCount):
3134         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
3135         (JSStringCopyUTF8CString):
3136         (ScriptItem::invoke):
3137
3138 2008-08-17  Geoffrey Garen  <ggaren@apple.com>
3139
3140         Reviewed by Cameron Zwarich.
3141
3142         Updated project files to XCode 3.1.
3143
3144         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3145         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3146
3147 2008-08-15  Mark Rowe  <mrowe@apple.com>
3148
3149         Rubber-stamped by Geoff Garen.
3150
3151         <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
3152
3153         * Scripts/check-for-global-initializers: Ignore initializers when building the debug variant.
3154
3155 2008-08-13  Simon Hausmann  <hausmann@webkit.org>
3156
3157         Rubber-stamped by Holger.
3158
3159         Revert r31585 and disable http tests for the Qt build again unless
3160         explicitly enabled.
3161
3162         Running the http tests unfortunately currently still triggers
3163         failures in non-http tests due to side-effects. Disable them by default for
3164         now, for more reliable results.
3165
3166         * Scripts/run-webkit-tests:
3167
3168 2008-08-10  Jan Michael Alonzo  <jmalonzo@webkit.org>
3169
3170         Reviewed (and updated) by Alp Toker.
3171
3172         https://bugs.webkit.org/show_bug.cgi?id=16620
3173         [GTK] Autotools make dist and make check support
3174
3175         Get make dist working.
3176
3177         Note that not all possible configurations have been tested yet.
3178
3179         * GNUmakefile.am:
3180
3181 2008-08-10  Alp Toker  <alp@nuanti.com>
3182
3183         Remove leftover qmake/GTK+ build files.
3184
3185         * DumpRenderTree/gtk/DumpRenderTree.pro: Removed.
3186         * GtkLauncher/GtkLauncher.pro: Removed.
3187
3188 2008-08-06  Chris Fleizach  <cfleizach@apple.com>
3189
3190         Reviewed by Beth Dakin
3191
3192         AX functions shouldn't return position information because it changes
3193         based on the platform
3194
3195         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3196         (AccessibilityUIElement::boundsForRange):
3197
3198 2008-08-06  Eric Seidel  <eric@webkit.org>
3199
3200         Reviewed by darin.
3201
3202         Fix leaks seen on build-bot by fixing memory management of AccessibilityUIElement.
3203         <https://bugs.webkit.org/show_bug.cgi?id=20297>
3204         <rdar://problem/6093153>
3205
3206         I've made AccessibilityUIElement a stack object for now.  It could be
3207         made RefCounted, but I figured that might be overkill for the moment.
3208         Essentially it's just a RefPtr itself. :)
3209
3210         I also fixed a few typos, such as AccessibilityUIElement() instead of ~AccessibilityUIElement()
3211         which was causing additional leaks. :)
3212
3213         I added toAXElement to remove a bunch of copy/paste code.
3214
3215         * DumpRenderTree/AccessibilityController.h:
3216         * DumpRenderTree/AccessibilityUIElement.cpp:
3217         (toAXElement):
3218         (allAttributesCallback):
3219         (attributesOfLinkedUIElementsCallback):
3220         (attributesOfChildrenCallback):
3221         (lineForIndexCallback):
3222         (boundsForRangeCallback):
3223         (childAtIndexCallback):
3224         (getRoleCallback):
3225         (getTitleCallback):
3226         (getDescriptionCallback):
3227         (getWidthCallback):
3228         (getHeightCallback):
3229         (getIntValueCallback):
3230         (getMinValueCallback):
3231         (getMaxValueCallback):
3232         (getInsertionPointLineNumberCallback):
3233         (finalize):
3234         * DumpRenderTree/AccessibilityUIElement.h:
3235         (AccessibilityUIElement::platformUIElement):
3236         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3237         (AccessibilityController::focusedElement):
3238         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3239         (AccessibilityUIElement::AccessibilityUIElement):
3240         (AccessibilityUIElement::getLinkedUIElements):
3241         (AccessibilityUIElement::getChildren):
3242         (AccessibilityUIElement::getChildAtIndex):
3243         (AccessibilityUIElement::attributesOfLinkedUIElements):
3244         (AccessibilityUIElement::attributesOfChildren):
3245
3246 2008-08-06  Eric Seidel  <eric@webkit.org>
3247
3248         Reviewed by Cameron Zwarich.
3249
3250         Speculative fix for an error I keep seeing in my Cygwin build
3251
3252         * Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin
3253
3254 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
3255
3256         Forgot to commit licensing correction in last commit.
3257
3258         * wx/packaging/wxWebKitInstaller.iss.in:
3259
3260 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
3261
3262         Reviewed by Eric Seidel.
3263
3264         Scripts for building a wxWebKit installer for wxPython on Win, eventually will
3265         be used for nightlies.
3266
3267         https://bugs.webkit.org/show_bug.cgi?id=20036
3268
3269         * wx/packaging: Added.
3270         * wx/packaging/build-win-installer.py: Added.
3271         * wx/packaging/wxWebKitInstaller.iss.in: Added.
3272
3273 2008-07-31  Adam Roben  <aroben@apple.com>
3274
3275         Follow-up to r35500
3276
3277         * WinLauncher/WinLauncher.vcproj: Set the manifest properties for the
3278         Release configuration, too.
3279
3280 2008-07-31  Stefan Landvogt <stefan.landvogt@gmail.com>
3281
3282         Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of
3283         the box
3284
3285         <https://bugs.webkit.org/show_bug.cgi?id=20245>
3286
3287         Reviewed by Adam Roben.
3288
3289         * WinLauncher/WinLauncher.vcproj: adding the following properties to
3290         WinLauncher > Properties > Manifest Tool > Isolated COM
3291         Type Library File: $(WebKitOutputDir)\lib\WebKit.tlb
3292         Component File Name: WebKit$(WebKitDLLConfigSuffix)
3293         Doing the change on "All Configurations"
3294
3295 2008-07-31  Adam Roben  <aroben@apple.com>
3296
3297         Windows build bot fix
3298
3299         * DumpRenderTree/win/ImageDiff.vcproj: Don't fail if files that only
3300         exist for people at Apple can't be found. Also updated the ICU version
3301         to 3.8.
3302
3303 2008-07-31  David Kilzer  <ddkilzer@apple.com>
3304
3305         Fix layout test results for webarchive/test-xml-stylesheet.xml
3306
3307         Reviewed by Darin Adler.
3308
3309         * DumpRenderTree/mac/DumpRenderTree.mm:
3310         (convertMIMEType): Work around the "text/xml" local file type
3311         regression in Leopard using the BUILDING_ON_LEOPARD macro.  Also
3312         stop mangling "application/x-javascript" into "text/javascript".
3313         (convertWebResourceDataToString): When checking whether to dump a
3314         resource as text, also check to see if the MIME type is in the
3315         -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
3316         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD
3317         macro.
3318
3319 2008-07-31  Chris Fleizach  <cfleizach@apple.com>
3320
3321         Reviewed by Alice Liu
3322
3323         Add AX support to get the bounds for a range of text
3324         Add AX support to get the child of an element
3325         Add AX support to get all the parameterized attribute names of an element
3326
3327         * DumpRenderTree/AccessibilityUIElement.cpp:
3328         (parameterizedAttributeNamesCallback):
3329         (boundsForRangeCallback):
3330         (childAtIndexCallback):
3331         (AccessibilityUIElement::getJSClass):
3332         * DumpRenderTree/AccessibilityUIElement.h:
3333         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3334         (AccessibilityUIElement::getChildAtIndex):
3335         (AccessibilityUIElement::parameterizedAttributeNames):
3336         (AccessibilityUIElement::boundsForRange):
3337
3338 2008-07-31  Erik Bunce  <elbunce@thehive.com>
3339
3340         Reviewed by Simon.
3341
3342         Make run-launcher set DYLD_LIBRARY_PATH to make things work on Mac OS X.
3343
3344         * Scripts/run-launcher:
3345
3346 2008-07-30  Jessica Kahn  <jess@apple.com>
3347
3348         Reviewed by Adam Roben.
3349
3350         Slightly stricter checking for previous change, suggested by Adam.
3351
3352         * Scripts/extract-localizable-strings:
3353
3354 2008-07-30  Jessica Kahn  <jess@apple.com>
3355
3356         Reviewed by Darin Adler.
3357
3358         Added support for UI_STRING and UI_STRING_KEY macros with flexible prefixes.
3359
3360         * Scripts/extract-localizable-strings:
3361
3362 2008-07-30  Anders Carlsson  <andersca@apple.com>
3363
3364         Reviewed by Adam.
3365
3366         Copy icu38* files instead of icu36* files.
3367
3368         * DumpRenderTree/win/DumpRenderTree.vcproj:
3369
3370 2008-07-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
3371
3372         DRT/Gtk build fix for r35362
3373
3374         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3375         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
3376
3377 2008-07-25  Brady Eidson  <beidson@apple.com>
3378
3379         Reviewed by Sam
3380
3381         Add the ability to dump whether-or-not an element should have autocomplete enabled,
3382         from the perspective of the WebKit API
3383
3384         * DumpRenderTree/LayoutTestController.cpp:
3385         (elementDoesAutoCompleteForElementWithIdCallback):
3386         (LayoutTestController::staticFunctions):
3387
3388         * DumpRenderTree/LayoutTestController.h:
3389         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3390         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
3391         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3392         (LayoutTestController::elementDoesAutoCompleteForElementWithId): Stub for now until I can get on Windows
3393
3394 2008-07-25  Chris Fleizach  <cfleizach@apple.com>
3395
3396         Reviewed by Beth Dakin
3397
3398         Add support for AXLineForIndex and AXInsertionPointIndex through the
3399         accessibility controller
3400
3401         * DumpRenderTree/AccessibilityUIElement.cpp:
3402         (lineForIndexCallback):
3403         (getInsertionPointLineNumberCallback):
3404         (AccessibilityUIElement::getJSClass):
3405         * DumpRenderTree/AccessibilityUIElement.h:
3406         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3407         (AccessibilityUIElement::insertionPointLineNumber):
3408         (AccessibilityUIElement::lineForIndex):
3409
3410 2008-07-25  Adam Roben  <aroben@apple.com>
3411
3412         Try to fix the Windows build bot
3413
3414         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't try to copy files
3415         that don't exist for people outside of Apple.
3416
3417 2008-07-18  Landry Breuil  <landry@openbsd.org>
3418
3419         Bug 19975: [OpenBSD] Patches to enable build of WebKit
3420
3421         <https://bugs.webkit.org/show_bug.cgi?id=19975>
3422
3423         Reviewed by David Kilzer.
3424
3425         * DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.
3426
3427 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
3428
3429         CygwinDownloader fails to install necessary packages
3430         https://bugs.webkit.org/show_bug.cgi?id=20075
3431
3432         Reviewed by Mark Rowe.
3433
3434         * CygwinDownloader/cygwin-downloader.zip: Rebuilt after two broken
3435         mirrors removed in r34116. Set MIME type to application/octet-stream.
3436
3437 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
3438
3439         CygwinDownloader's make-zip.sh script fails
3440         https://bugs.webkit.org/show_bug.cgi?id=20074
3441
3442         Reviewed by Mark Rowe.
3443
3444         * CygwinDownloader/cygwin-downloader.py:
3445
3446 2008-07-15  Sam Weinig  <sam@webkit.org>
3447
3448         Reviewed by Anders Carlsson.
3449
3450         Refactor accessibility testing code.
3451
3452         We now have:
3453         - AccessibilityController
3454           Controller which has access to the WebView and can provide the focused element, root element
3455           and in the future, elementAtPoint.
3456
3457         - AccessibilityUIElement
3458           Object which provides access to the data provided by the Accessibility APIs.
3459
3460         * DumpRenderTree/AccessibilityController.cpp:
3461         (getFocusedElementCallback):
3462         (getRootElementCallback):
3463         (AccessibilityController::getJSClass):
3464         * DumpRenderTree/AccessibilityController.h:
3465         * DumpRenderTree/AccessibilityUIElement.cpp: Added.
3466         (allAttributesCallback):
3467         (attributesOfLinkedUIElementsCallback):
3468         (attributesOfChildrenCallback):
3469         (getRoleCallback):
3470         (getTitleCallback):
3471         (getDescriptionCallback):
3472         (getWidthCallback):
3473         (getHeightCallback):
3474         (getIntValueCallback):
3475         (getMinValueCallback):
3476         (getMaxValueCallback):
3477         (finalize):
3478         (AccessibilityUIElement::makeJSAccessibilityUIElement):
3479         (AccessibilityUIElement::getJSClass):
3480         * DumpRenderTree/AccessibilityUIElement.h: Added.
3481         (AccessibilityUIElement::platformUIElement):
3482         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3483         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3484         (AccessibilityController::AccessibilityController):
3485         (AccessibilityController::~AccessibilityController):
3486         (AccessibilityController::focusedElement):
3487         (AccessibilityController::rootElement):
3488         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added.
3489         (AccessibilityUIElement::AccessibilityUIElement):
3490         (descriptionOfValue):
3491         (attributesOfElement):
3492         (nsStringToJSStringRef):
3493         (concatenateAttributeAndValue):
3494         (AccessibilityUIElement::getLinkedUIElements):
3495         (AccessibilityUIElement::getChildren):
3496         (AccessibilityUIElement::attributesOfLinkedUIElements):
3497         (AccessibilityUIElement::attributesOfChildren):
3498         (AccessibilityUIElement::allAttributes):
3499         (AccessibilityUIElement::role):
3500         (AccessibilityUIElement::title):
3501         (AccessibilityUIElement::description):
3502         (AccessibilityUIElement::width):
3503         (AccessibilityUIElement::height):
3504         (AccessibilityUIElement::intValue):
3505         (AccessibilityUIElement::minValue):
3506         (AccessibilityUIElement::maxValue):
3507
3508 2008-07-14  Chris Fleizach  <cfleizach@apple.com>
3509
3510         Reviewed by Beth Dakin
3511
3512         Add support to get attributes of the AXChildren of an objecty
3513
3514         * DumpRenderTree/AccessibilityController.cpp:
3515         (attributesOfChildrenForFocusedElementCallback):
3516         (AccessibilityController::staticFunctions):
3517         * DumpRenderTree/AccessibilityController.h:
3518         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3519         (descriptionOfValue):
3520         (AccessibilityController::attributesOfChildrenForFocusedElement):
3521
3522 2008-07-14  Steve Falkenburg  <sfalken@apple.com>
3523
3524         Build fix.
3525
3526         * DumpRenderTree/win/DumpRenderTree.vcproj:
3527
3528 2008-07-14  Adam Roben  <aroben@apple.com>
3529
3530         Attempted Windows build fix
3531
3532         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add
3533         CoreFoundation/OSXCompatibilityHeaders[/GNUCompatibility] to the
3534         include path.
3535
3536 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
3537
3538         Reviewed by Geoff Garen.
3539
3540         Eliminate per-thread JavaScript global data instance support and make arbitrary
3541         global data/global object combinations possible.
3542
3543         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
3544         (runJavaScriptThread): Don't pass a released context reference to JSGarbageCollect.
3545         In this scenario, it was causing crashes after each 10-20 tests, because there was a large
3546         chance for a different thread to cause GC after the context was released.
3547
3548 2008-07-11  Stephanie Lewis  <slewis@apple.com>
3549
3550         Reviewed by Darin Adler.
3551
3552         Make sure we read WebCore Leak messages.  Force full document teardown for DumpRenderTree.
3553
3554         Up timeout limit, some slower machines were timing out before crashtracer finished writing out to disk and quitting DRT.
3555
3556         * DumpRenderTree/mac/DumpRenderTree.mm:
3557         (setDefaultsToConsistentValuesForTesting):
3558         (resetWebViewToConsistentStateBeforeTesting):
3559         * Scripts/run-webkit-tests:
3560
3561 2008-07-10  Steve Falkenburg  <sfalken@apple.com>
3562
3563         Build fix.
3564
3565         * DumpRenderTree/win/DumpRenderTree.vcproj:
3566
3567 2008-07-09  Eric Seidel  <eric@webkit.org>
3568
3569         Reviewed by Mark Rowe.
3570
3571         Print <div> backgrounds when printing from DRT.
3572
3573         * DumpRenderTree/mac/DumpRenderTree.mm:
3574         (setDefaultsToConsistentValuesForTesting):
3575
3576 2008-07-09  Eric Seidel  <eric@webkit.org>
3577
3578         Reviewed by Mark Rowe.
3579
3580         Fix copying of expected results to correct location
3581
3582         * Scripts/run-webkit-tests:
3583
3584 2008-07-09  Eric Seidel  <eric@webkit.org>
3585
3586         Reviewed by aroben.
3587
3588         * DumpRenderTree/LayoutTestController.cpp:
3589         (LayoutTestController::LayoutTestController):
3590         (dumpAsPDFCallback):
3591         (LayoutTestController::staticFunctions):
3592         * DumpRenderTree/LayoutTestController.h:
3593         (LayoutTestController::dumpAsPDF):
3594         (LayoutTestController::setDumpAsPDF):
3595         * DumpRenderTree/mac/DumpRenderTree.mm:
3596         (dumpFrameAsPDF):
3597         (dump):
3598
3599 2008-07-09  Eric Seidel  <eric@webkit.org>
3600
3601         Reviewed by weinig.
3602
3603         Add Content-Type support to DumpRenderTree and run-webkit-tests
3604         and move expected.txt files to expected.webarchive
3605
3606         https://bugs.webkit.org/show_bug.cgi?id=15565
3607
3608         * DumpRenderTree/cg/ImageDiffCG.cpp:
3609         (compareImages):
3610         (main):
3611         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3612         (printPNG):
3613         * DumpRenderTree/mac/DumpRenderTree.mm:
3614         (dump):
3615         * Scripts/run-webkit-tests:
3616
3617 2008-07-08  Jon Honeycutt  <jhoneycutt@apple.com>
3618
3619         Reviewed by Anders.
3620
3621         Port r34988 to Mac: allow tests to define JavaScript to execute when
3622         NPP_DestroyStream or NPP_URLNotify is called.
3623
3624         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3625         (NPP_New): Remove initialization that happens in pluginAllocate. Look
3626         for new arguments onStreamDestroy and onURLNotify.
3627         (NPP_Destroy): Free onStreamDestroy and onURLNotify.
3628         (executeScript): Code moved from onStreamLoad.
3629         (NPP_NewStream): Call executeScript.
3630         (NPP_DestroyStream): Same.
3631         (NPP_URLNotify): Same.
3632
3633 2008-07-07  Beth Dakin  <bdakin@apple.com>
3634
3635         Reviewed by Anders.
3636
3637         This patch extends DRT accessibility tests to add the ability to
3638         query the intValue, minValue, and maxValue of the focused element.
3639
3640         * DumpRenderTree/AccessibilityController.cpp:
3641         (intValueOfFocusedElementCallback):
3642         (minValueOfFocusedElementCallback):
3643         (maxValueOfFocusedElementCallback):
3644         (AccessibilityController::staticFunctions):
3645         * DumpRenderTree/AccessibilityController.h:
3646         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3647         (AccessibilityController::intValueOfFocusedElement):
3648         (AccessibilityController::minValueOfFocusedElement):
3649         (AccessibilityController::maxValueOfFocusedElement):
3650
3651 2008-07-07  Steve Falkenburg  <sfalken@apple.com>
3652
3653         Fix build.
3654
3655         * DumpRenderTree/win/ImageDiff.vcproj:
3656
3657 2008-07-02  Jon Honeycutt  <jhoneycutt@apple.com>
3658
3659         Allow tests to define JavaScript to execute when NPP_DestroyStream or
3660         NPP_URLNotify is called.
3661
3662         Reviewed by Anders.
3663
3664         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add a new
3665         property, "returnErrorFromNewStream." This is to support the test for
3666         <rdar://5983747> Safari crashes trying to load the SilverLight plugin,
3667         caused by WebKit calling NPP_DestroyStream after a plug-in returns an
3668         error from NPP_NewStream.
3669         (pluginGetProperty):
3670         (pluginSetProperty):