Fixes <http://webkit.org/b/31699>.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
2
3         Reviewed by Xan Lopez.
4
5         [GTK] DRT release event does not create the state correctly
6         https://bugs.webkit.org/show_bug.cgi?id=31717
7
8         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
9
10 2009-11-20  Eric Seidel  <eric@webkit.org>
11
12         Reviewed by Adam Barth.
13
14         MultiCommandTool should find Command objects automatically instead of with a manual list
15         https://bugs.webkit.org/show_bug.cgi?id=31710
16
17         * Scripts/bugzilla-tool:
18         * Scripts/modules/multicommandtool.py:
19          - Use some wild python-fu to crawl all the known subclasses of Command.
20
21 2009-11-20  Adam Barth  <abarth@webkit.org>
22
23         Unreviewed "build" fix.  Added missing import.
24
25         * Scripts/bugzilla-tool:
26
27 2009-11-20  Adam Barth  <abarth@webkit.org>
28
29         Unreviewed "build" fix.  I failed to update LandingSequence.test
30         properly.
31
32         * Scripts/modules/landingsequence.py:
33
34 2009-11-20  Adam Barth  <abarth@webkit.org>
35
36         Reviewed by Eric Seidel.
37
38         Create LandingSequence as the all-sing, all-dance landing class
39         https://bugs.webkit.org/show_bug.cgi?id=31709
40
41         Client can inherit from this class to carefully control exactly which
42         steps they wish to have happen in the landing sequence.
43
44         * Scripts/bugzilla-tool:
45         * Scripts/modules/landingsequence.py: Added.
46         * Scripts/modules/webkitlandingscripts.py: Added.
47
48 2009-11-19  Adam Barth  <abarth@webkit.org>
49
50         Reviewed by Eric Seidel.
51
52         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
53         https://bugs.webkit.org/show_bug.cgi?id=31707
54
55         This is to help when we implement build-attachment.
56
57         * Scripts/bugzilla-tool:
58
59 2009-11-19  Adam Barth  <abarth@webkit.org>
60
61         Reviewed by Eric Seidel.
62
63         Support Qt port in bugzilla-tool
64         https://bugs.webkit.org/show_bug.cgi?id=31701
65
66         Now we support building with Qt!
67
68         * Scripts/bugzilla-tool:
69         * Scripts/modules/webkitport.py: Added.
70         * Scripts/modules/webkitport_unittest.py: Added.
71         * Scripts/run-webkit-unittests:
72
73 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
74
75         Reviewed by Adam Barth.
76
77         Remove inserting stderr into patch in bugzilla-tool
78         https://bugs.webkit.org/show_bug.cgi?id=29914
79
80         Modify SCM python module's run_command function to avoid return of stderr
81         by default, so stderr won't be inserted into the patches.
82         Modify the related unit test.
83
84         * Scripts/modules/scm.py:
85         * Scripts/modules/scm_unittest.py:
86
87 2009-11-19  Eric Seidel  <eric@webkit.org>
88
89         Reviewed by Adam Barth.
90
91         bugzilla-tool needs per-command help
92         https://bugs.webkit.org/show_bug.cgi?id=31697
93
94         Added support for "bugzilla-tool help command-name"
95         and a unit test to make sure it works.
96
97         * Scripts/modules/multicommandtool.py:
98         * Scripts/modules/multicommandtool_unittest.py:
99
100 2009-11-19  Eric Seidel  <eric@webkit.org>
101
102         Reviewed by Adam Barth.
103
104         Move MultiCommandTool and Command into a separate file and add some basic unit tests
105         https://bugs.webkit.org/show_bug.cgi?id=31695
106
107         * Scripts/bugzilla-tool:
108         * Scripts/modules/multicommandtool.py: Added.
109         * Scripts/modules/multicommandtool_unittest.py: Added.
110         * Scripts/run-webkit-unittests:
111
112 2009-11-19  Eric Seidel  <eric@webkit.org>
113
114         No review, just adding a FIXME.
115
116         Split out command parsing and help printing from BugzillaTool
117         https://bugs.webkit.org/show_bug.cgi?id=31688
118
119         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
120
121 2009-11-19  Eric Seidel  <eric@webkit.org>
122
123         Reviewed by Adam Barth.
124
125         Split out command parsing and help printing from BugzillaTool
126         https://bugs.webkit.org/show_bug.cgi?id=31688
127
128         * Scripts/bugzilla-tool:
129          - Add new MultiCommandTool class to contain option parsing and help printing logic.
130          - Rename private methods to use _ pattern.
131          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
132          - 
133
134 2009-11-19  Eric Seidel  <eric@webkit.org>
135
136         Reviewed by Adam Barth.
137
138         Re-factor help printing to use modern python idioms
139         https://bugs.webkit.org/show_bug.cgi?id=31685
140
141         * Scripts/bugzilla-tool:
142
143 2009-11-19  Eric Seidel  <eric@webkit.org>
144
145         Reviewed by Darin Adler.
146
147         commit-queue empty queue logs twice
148         https://bugs.webkit.org/show_bug.cgi?id=31679
149
150         * Scripts/bugzilla-tool:
151
152 2009-11-19  Eric Seidel  <eric@webkit.org>
153
154         Reviewed by Darin Adler.
155
156         bugzilla-tool's reviewer/committer rejection message should be clearer
157         https://bugs.webkit.org/show_bug.cgi?id=31126
158
159         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
160
161         * Scripts/modules/bugzilla.py:
162
163 2009-11-19  Eric Z. Ayers  <zundel@google.com>
164
165         Reviewed by Pavel Feldman.
166
167         Forces a WM_PAINT event on calling layoutTestController.display()
168         in order to enable the timeline-paint.html test on Windows.
169         ::UpdateWindow() does not force an event becaue the window is 
170         not visible.
171
172         https://bugs.webkit.org/show_bug.cgi?id=31402
173
174         * DumpRenderTree/win/DumpRenderTree.cpp:
175         (displayWebView):
176
177 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
178
179         No review needed.
180
181         Added myself to committers list.
182
183         * Scripts/modules/committers.py:
184
185 2009-11-19  Adam Barth  <abarth@webkit.org>
186
187         Reviewed by Eric Seidel.
188
189         Bugzilla-tool command classes should match command names
190         https://bugs.webkit.org/show_bug.cgi?id=31666
191
192         I renamed all the commands except CommitMessageForCurrentDiff because
193         the new name would conflict with an existing class.
194
195         * Scripts/bugzilla-tool:
196
197 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
198
199         Reviewed by Gustavo Noronha Silva.
200
201         Web Inspector: Implement "show inspector" in WebKit GTK
202         API and enable console tests.
203
204         https://bugs.webkit.org/show_bug.cgi?id=31669
205
206         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
207         (LayoutTestController::showWebInspector):
208
209 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
210
211         Reviewed by Simon Hausmann.
212
213         Minor refactoring + more documentation.
214
215         * DumpRenderTree/qt/DumpRenderTree.cpp:
216         (WebCore::clearHistory):
217         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
218
219 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
220
221         Reviewed by Eric Seidel.
222
223         Ignore websocket tests when --no-http is specified.
224         https://bugs.webkit.org/show_bug.cgi?id=31662
225
226         * Scripts/run-webkit-tests:
227
228 2009-11-18  Adam Barth  <abarth@webkit.org>
229
230         Reviewed by Eric Seidel.
231
232         Normalize ' and " in bugzilla-tool
233         https://bugs.webkit.org/show_bug.cgi?id=31655
234
235         We decided " is better than ' and we should be consistent.
236
237         * Scripts/bugzilla-tool:
238
239 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
240
241         Reviewed by Kenneth Rohde Christiansen.
242
243         [Qt] Remove support for Qt v4.3 or older versions
244         https://bugs.webkit.org/show_bug.cgi?id=29469
245
246         * DumpRenderTree/qt/DumpRenderTree.pro:
247         * DumpRenderTree/qt/ImageDiff.pro:
248
249 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
250
251         Reviewed by Eric Seidel.
252
253         GitTest.test_create_binary_patch fails if /tmp is symlink
254         https://bugs.webkit.org/show_bug.cgi?id=31536
255
256         * Scripts/modules/scm_unittest.py:
257
258 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
259
260         Reviewed by Darin Adler.
261
262         Configuration for Chromium Build Slaves.
263
264         https://bugs.webkit.org/show_bug.cgi?id=31442
265
266         * BuildSlaveSupport/build.webkit.org-config/config.json:
267         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
268
269 2009-11-18  Eric Seidel  <eric@webkit.org>
270
271         Reviewed by Darin Adler.
272
273         workqueue.py results in totally broken commit-queue UI
274         https://bugs.webkit.org/show_bug.cgi?id=31645
275
276         * Scripts/bugzilla-tool:
277          - Remove unneeded use of PatchCollection.
278          - Grab a new copy of the cq'd patches every run of the queue.
279
280 2009-11-18  Sam Weinig  <sam@webkit.org>
281
282         Reviewed by Anders Carlsson.
283
284         Make the Mac Geolocation API async.
285
286         Update DRT to use the new async Mac Geolocation API.
287
288         * DumpRenderTree/mac/UIDelegate.mm:
289         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
290
291 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
292
293         Reviewed by Kenneth Rohde Christiansen.
294
295         Add and option to toggle HTML5 datalist support to build-webkit
296         https://bugs.webkit.org/show_bug.cgi?id=31599
297
298         * Scripts/build-webkit:
299
300 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
301
302         Reviewed by Kevin Ollivier.
303
304         Enable wx plugin support using the Windows implementation as a base.
305         
306         https://bugs.webkit.org/show_bug.cgi?id=31636
307
308         * wx/build/settings.py:
309
310 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
311
312         Reviewed by Simon Hausmann.
313
314         Change the initialization order so that the controllers
315         will be created before exporting them to the JS DOM window.
316
317         * DumpRenderTree/qt/DumpRenderTree.cpp:
318         (WebCore::DumpRenderTree::DumpRenderTree):
319
320 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
321
322         Reviewed by Simon Hausmann.
323
324         Fix a code copy and paste error. m_page should be page.
325
326         * DumpRenderTree/qt/DumpRenderTree.cpp:
327         (WebCore::DumpRenderTree::createWindow):
328
329 2009-11-17  Mark Rowe  <mrowe@apple.com>
330
331         Reviewed by Alexey Proskuryakov.
332
333         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
334
335         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
336         This prevents symlinks from confusing the descendant check.
337
338 2009-11-17  Mark Rowe  <mrowe@apple.com>
339
340         Reviewed by Alexey Proskuryakov.
341
342         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
343
344         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
345         server to be up rather than having run-webkit-tests abort immediately.
346
347         * Scripts/run-webkit-tests:
348
349 2009-11-17  Eric Seidel  <eric@webkit.org>
350
351         Reviewed by Darin Adler.
352
353         commit-queue is failing to set reviewer in ChangeLogs
354         https://bugs.webkit.org/show_bug.cgi?id=31592
355
356         * Scripts/bugzilla-tool: Clarify the "applying" log message.
357         * Scripts/modules/bugzilla.py:
358          - Add a new _validate_committer_and_reviewer function as a
359            temporary solution until we can make a real Attachment object
360            which knows how to fill in its committer/reviewer fields automatically.
361
362 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
363
364         Unreviewed buildbot fix.
365
366         Revert part of earlier patch and add comment, as it
367         was causing timeouts on the buildbot.
368
369         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
370         (LayoutTestController::notifyDone):
371
372 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
373
374         Reviewed by Oliver Hunt.
375
376         Make the timeout 15 sec as for the other DRT's and make
377         it print out the same output when a test timeout.
378
379         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
380         (LayoutTestController::waitUntilDone):
381         (LayoutTestController::notifyDone):
382         (LayoutTestController::timerEvent):
383
384 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
385
386         Reviewed by Timothy Hatcher.
387
388         Fixed typos in comments.
389
390         * Scripts/modules/committers.py:
391
392 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
393
394         Reviewed by Timothy Hatcher.
395
396         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
397         - Updated DRT to show/close inspector for all tests under /inspector
398         - Introduced LayoutTestController::setTimelineProfilingEnabled and
399           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
400         - Removed reload on each inspector test
401         - Renamed fast/inspector to fast/inspector-support in order not to trigger
402         inspector for those.
403         - Reimplemented timeline tests in order to get rid of reload there.
404         - Moved tests that don't require harness into the fast group.
405
406         https://bugs.webkit.org/show_bug.cgi?id=31472
407
408         * DumpRenderTree/LayoutTestController.cpp:
409         (setTimelineProfilingEnabledCallback):
410         (closeWebInspectorCallback):
411         (LayoutTestController::staticFunctions):
412         * DumpRenderTree/LayoutTestController.h:
413         * DumpRenderTree/gtk/DumpRenderTree.cpp:
414         (shouldOpenWebInspector):
415         (runTest):
416         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
417         (LayoutTestController::setTimelineProfilingEnabled):
418         * DumpRenderTree/mac/DumpRenderTree.mm:
419         (shouldOpenWebInspector):
420         (runTest):
421         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
422         (LayoutTestController::setTimelineProfilingEnabled):
423         * DumpRenderTree/win/DumpRenderTree.cpp:
424         (shouldOpenWebInspector):
425         (runTest):
426         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
427         (LayoutTestController::setTimelineProfilingEnabled):
428
429 2009-11-17  Oliver Hunt  <oliver@apple.com>
430
431         Reviewed by Maciej Stachowiak.
432
433         Incorrect use of JavaScriptCore API in DumpRenderTree
434         https://bugs.webkit.org/show_bug.cgi?id=31577
435
436         Return undefined rather than a literal null.
437
438         * DumpRenderTree/AccessibilityUIElement.cpp:
439         (setSelectedTextRangeCallback):
440         (incrementCallback):
441         (decrementCallback):
442         (showMenuCallback):
443
444 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
445
446         Reviewed by Beth Dakin.
447
448         AX: aria-labelledby duplicates some of its WAI-ARIA label
449         https://bugs.webkit.org/show_bug.cgi?id=31565
450
451         * DumpRenderTree/AccessibilityUIElement.cpp:
452         (titleUIElementCallback):
453         (getIsValidCallback):
454         (AccessibilityUIElement::getJSClass):
455
456 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
457
458         Reviewed by Simon Hausmann.
459
460         r50942 broke output from created windows. Make the
461         m_enableTextOutput a member of the DRT and not the
462         WebPage.
463
464         * DumpRenderTree/qt/DumpRenderTree.cpp:
465         (WebCore::WebPage::WebPage):
466         (WebCore::WebPage::javaScriptAlert):
467         (WebCore::WebPage::javaScriptConsoleMessage):
468         (WebCore::WebPage::javaScriptConfirm):
469         (WebCore::WebPage::javaScriptPrompt):
470         (WebCore::WebPage::acceptNavigationRequest):
471         (WebCore::DumpRenderTree::DumpRenderTree):
472         (WebCore::DumpRenderTree::open):
473         (WebCore::DumpRenderTree::createWindow):
474         * DumpRenderTree/qt/DumpRenderTree.h:
475         (WebCore::DumpRenderTree::setTextOutputEnabled):
476         (WebCore::DumpRenderTree::isTextOutputEnabled):
477         (WebCore::WebPage::shouldInterruptJavaScript):
478         (WebCore::WebPage::isTextOutputEnabled):
479         (WebCore::WebPage::setViewGeometry):
480
481 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
482
483         Reviewed by Gustavo Noronha Silva.
484
485         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
486         as the implementation is being used by at least Qt and Gtk+.
487
488         Update buildsystems as well.
489
490         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
491         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
492         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
493         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
494         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
495         * GNUmakefile.am:
496
497 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
498
499         Reviewed by Alexey Proskuryakov.
500
501         Disable wss until all platforms support pyOpenSSL
502
503         https://bugs.webkit.org/show_bug.cgi?id=31479
504
505         * Scripts/run-webkit-tests:
506
507 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
508
509         Reviewed by Kenneth Christiansen.
510
511         [Qt] Implement load error pages support for Qt's DRT.
512         https://bugs.webkit.org/show_bug.cgi?id=31509
513
514         For now, it will not be a default feature, and layout tests
515         that want to make use of this have to explicitily call
516         'handleErrorPages();' for the test source.
517
518         Any of the other DumpRenderTree's (mac, win and gtk)
519         support handling error pages. Qt's will be the first.
520
521         * DumpRenderTree/qt/DumpRenderTree.cpp:
522         (WebCore::WebPage::supportsExtension):
523         (WebCore::WebPage::extension):
524         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
525         (LayoutTestController::reset):
526         * DumpRenderTree/qt/LayoutTestControllerQt.h:
527         (LayoutTestController::shouldHandleErrorPages):
528         (LayoutTestController::handleErrorPages):
529
530 2009-11-16  Eric Seidel  <eric@webkit.org>
531
532         Reviewed by Adam Barth.
533
534         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
535         https://bugs.webkit.org/show_bug.cgi?id=31549
536
537         Renamed --commit-queue to --non-interactive in most places
538         and remove the code in land-patches which is no longer needed.
539
540         * Scripts/bugzilla-tool:
541
542 2009-11-16  Eric Seidel  <eric@webkit.org>
543
544         Reviewed by Adam Barth.
545
546         The commit-queue should use land-attachment
547         https://bugs.webkit.org/show_bug.cgi?id=31548
548
549         * Scripts/bugzilla-tool:
550
551 2009-11-16  Adam Barth  <abarth@webkit.org>
552
553         Reviewed by Eric Seidel.
554
555         Convert CommitQueue over to PatchCollection
556         https://bugs.webkit.org/show_bug.cgi?id=31547
557
558         Also fixes a bug in workqueue and adds a test!
559
560         * Scripts/bugzilla-tool:
561         * Scripts/modules/workqueue.py:
562         * Scripts/modules/workqueue_unittest.py:
563
564 2009-11-16  Adam Barth  <abarth@webkit.org>
565
566         Reviewed by Eric Seidel.
567
568         Move StyleQueue over to using PatchCollection
569         https://bugs.webkit.org/show_bug.cgi?id=31544
570
571         That's what the class it's for.
572
573         * Scripts/bugzilla-tool:
574         * Scripts/modules/patchcollection.py:
575         * Scripts/modules/patchcollection_unittest.py:
576
577 2009-11-16  Eric Seidel  <eric@webkit.org>
578
579         Reviewed by Adam Barth.
580
581         bugzilla-tool needs a land-attachment command
582         https://bugs.webkit.org/show_bug.cgi?id=31546
583
584         * Scripts/bugzilla-tool:
585          - Move all the logic into AbstractLandingCommand and
586            add a new LandAttachment command subclass.
587          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
588
589 2009-11-16  Eric Seidel  <eric@webkit.org>
590
591         Reviewed by Adam Barth.
592
593         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
594         https://bugs.webkit.org/show_bug.cgi?id=31543
595
596         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
597
598         * Scripts/bugzilla-tool:
599
600 2009-11-16  Eric Seidel  <eric@webkit.org>
601
602         Reviewed by Adam Barth.
603
604         Disable the style queue from posting to the commit queue status page.
605
606         * Scripts/bugzilla-tool:
607
608 2009-11-16  Adam Barth  <abarth@webkit.org>
609
610         Reviewed by Eric Seidel.
611
612         Implement PatchCollection
613         https://bugs.webkit.org/show_bug.cgi?id=31541
614
615         This class holds a set of patches and lets clients iterate through
616         them.  Optionally, clients can install a filter.
617
618         * Scripts/modules/patchcollection.py: Added.
619         * Scripts/modules/patchcollection_unittest.py: Added.
620         * Scripts/run-webkit-unittests:
621
622 2009-11-16  Eric Seidel  <eric@webkit.org>
623
624         Reviewed by Adam Barth.
625
626         bugzilla-tool land-patches will close bugs with patches r=?
627         https://bugs.webkit.org/show_bug.cgi?id=28230
628
629         The commit-queue shouldn't close patches with outstanding reviews on them,
630         even if many reviewers seem to be against multi-patch bugs.
631
632         * Scripts/bugzilla-tool:
633
634 2009-11-16  Eric Seidel  <eric@webkit.org>
635
636         Reviewed by Adam Barth.
637
638         bugzilla-tool check-style should work with attachment ids instead of bug ids
639         https://bugs.webkit.org/show_bug.cgi?id=31540
640
641         * Scripts/bugzilla-tool:
642
643 2009-11-16  Eric Seidel  <eric@webkit.org>
644
645         Reviewed by Adam Barth.
646
647         WorkQueue is the only place that should know about special exit codes
648         https://bugs.webkit.org/show_bug.cgi?id=31534
649
650         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
651         and add tests for handling exit codes.
652         I also cleaned up workqueue_unittest.py more.
653
654         * Scripts/bugzilla-tool:
655         * Scripts/modules/workqueue.py:
656         * Scripts/modules/workqueue_unittest.py:
657
658 2009-11-16  Eric Seidel  <eric@webkit.org>
659
660         Reviewed by Adam Barth.
661
662         Re-factor workqueue_unittest to allow for more than one test.
663         https://bugs.webkit.org/show_bug.cgi?id=31535
664
665         * Scripts/modules/workqueue_unittest.py:
666
667 2009-11-16  Eric Seidel  <eric@webkit.org>
668
669         Reviewed by Adam Barth.
670
671         land-patches needs to be re-factored into smaller chunks
672         https://bugs.webkit.org/show_bug.cgi?id=31532
673
674         * Scripts/bugzilla-tool: fix a couple obvious typos.
675
676 2009-11-16  Eric Seidel  <eric@webkit.org>
677
678         Reviewed by Adam Barth.
679
680         land-patches needs to be re-factored into smaller chunks
681         https://bugs.webkit.org/show_bug.cgi?id=31532
682
683         The next patch will move these methods into WebKitLandingScripts.
684
685         * Scripts/bugzilla-tool:
686          - Split out _land_patch and _close_bug_if_no_active_patches.
687
688 2009-11-16  Adam Barth  <abarth@webkit.org>
689
690         Reviewed by Eric Seidel.
691
692         Fix silly copy-and-paste code.  I am a terrible coder.
693
694         * Scripts/modules/bugzilla.py:
695
696 2009-11-16  Adam Barth  <abarth@webkit.org>
697
698         Reviewed by Eric Seidel.
699
700         Implement a StyleQueue
701         https://bugs.webkit.org/show_bug.cgi?id=31537
702
703         The first iteration of the style queue only produces output locally.
704         There is also a limit of 10 patches because it's not that useful to
705         iterate through the entire review queue at this point.  We can remove
706         the limit later.
707
708         * Scripts/bugzilla-tool:
709         * Scripts/modules/bugzilla.py:
710
711 2009-11-16  Adam Barth  <abarth@webkit.org>
712
713         Reviewed by Eric Seidel.
714
715         Unit test WorkQueue
716         https://bugs.webkit.org/show_bug.cgi?id=31531
717
718         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
719
720         * Scripts/bugzilla-tool:
721         * Scripts/modules/statusbot.py:
722         * Scripts/modules/workqueue.py:
723         * Scripts/modules/workqueue_unittest.py: Added.
724         * Scripts/run-webkit-unittests:
725
726 2009-11-16  Eric Seidel  <eric@webkit.org>
727
728         Reviewed by Adam Barth.
729
730         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
731         https://bugs.webkit.org/show_bug.cgi?id=31530
732
733         * Scripts/bugzilla-tool:
734
735 2009-11-16  Eric Seidel  <eric@webkit.org>
736
737         Reviewed by Adam Barth.
738
739         bugzilla-tool needs apply-attachment
740         https://bugs.webkit.org/show_bug.cgi?id=31528
741
742         * Scripts/bugzilla-tool:
743          - Add ApplyAttachment command.
744          - Abstract applying code into WebKitApplyingScripts.
745          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
746         * Scripts/modules/bugzilla.py:
747          - Add fetch_attachment and bug_id_for_attachment_id.
748         * Scripts/modules/bugzilla_unittest.py:
749          - Add test for new parsing.
750          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
751
752 2009-11-16  Eric Seidel  <eric@webkit.org>
753
754         Reviewed by Adam Barth.
755
756         Document check-style's use of force_clean.
757
758         * Scripts/bugzilla-tool:
759         * Scripts/modules/scm.py:
760
761 2009-11-16  Adam Barth  <abarth@webkit.org>
762
763         Reviewed by Eric Seidel.
764
765         Move WorkQueue to its own file
766         https://bugs.webkit.org/show_bug.cgi?id=31529
767
768         WorkQueue and WorkQueueDelegate are separate concerns from
769         bugzilla-tool.  Also added a missing include to logging.py.
770
771         * Scripts/bugzilla-tool:
772         * Scripts/modules/logging.py:
773         * Scripts/modules/workqueue.py:
774
775 2009-11-16  Adam Barth  <abarth@webkit.org>
776
777         Reviewed by Eric Seidel.
778
779         Move OutputTee to logging.py.
780
781         * Scripts/bugzilla-tool:
782         * Scripts/modules/logging.py:
783
784 2009-11-15  Adam Barth  <abarth@webkit.org>
785
786         Reviewed by Eric Seidel.
787
788         Refactor bugzilla-tool to allow for multiple queues
789         https://bugs.webkit.org/show_bug.cgi?id=31513
790
791         Divide the commit queue class into three class to make creating
792         additional queues easier.
793
794         * Scripts/bugzilla-tool:
795
796 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
797
798         Reviewed by Eric Seidel.
799
800         svn-apply may not handle git patches created by bugzilla-tool
801         https://bugs.webkit.org/show_bug.cgi?id=31457
802
803         * Scripts/modules/scm.py:
804         * Scripts/modules/scm_unittest.py:
805
806 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
807
808         Reviewed by Eric Seidel.
809
810         bugzilla-tool should post git binary diff
811         https://bugs.webkit.org/show_bug.cgi?id=31458
812
813         Add --binary option to Git.create_patch.
814
815         * Scripts/modules/scm.py:
816         * Scripts/modules/scm_unittest.py:
817
818 2009-11-15  Adam Barth  <abarth@webkit.org>
819
820         Reviewed by Darin Adler.
821
822         Add bugzilla-tool check-style
823         https://bugs.webkit.org/show_bug.cgi?id=31515
824
825         * Scripts/bugzilla-tool:
826         * Scripts/modules/bugzilla.py:
827
828 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
829
830         Reviewed by Simon Hausmann.
831
832         Make the Qt Linux only --valgrind feature, suppress errors
833         defined in the SuppressedValgrindErrors file.
834
835         * Scripts/run-webkit-tests:
836
837 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
838
839         Reviewed by Simon Hausmann.
840
841         Set the locale to C and not to the current one in use on the system.
842
843         * DumpRenderTree/qt/DumpRenderTree.cpp:
844         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
845
846 2009-11-13  Adam Roben  <aroben@apple.com>
847
848         Add support for
849         http/tests/security/isolatedWorld/didClearWindowObject.html
850
851         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
852         window objects in isolated worlds are cleared
853
854         Reviewed by Dave Hyatt.
855
856         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
857
858         * DumpRenderTree/mac/FrameLoadDelegate.mm:
859         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
860         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
861         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
862         Added. Sets a __worldID property on the global object whose value is
863         the ID of this world.
864         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
865         Respond to this new delegate callback by calling through to one of the
866         above new methods.
867         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
868         (worldMap): Added. Returns a HashMap containing all the worlds we've
869         created.
870         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
871         haven't kept track of this world.
872         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
873         instead of declaring our own.
874
875         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
876
877         * DumpRenderTree/win/FrameLoadDelegate.cpp:
878         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
879         didClearWindowObjectForFrameInStandardWorld.
880         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
881         Respond to this new delegate callback by calling through to one of the
882         below new methods.
883         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
884         Added. Sets a __worldID property on the gobal object whose value is
885         the ID of this world.
886         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
887         Added. Moved code here from didClearWindowObject.
888
889         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
890         didClearWindowObjectForFrame* functions.
891
892         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
893         (worldMap): Added. Returns a HashMap containing all the worlds we've
894         created.
895         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
896         haven't kept track of this world.
897         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
898         instead of declaring our own.
899
900 2009-11-13  Adam Roben  <aroben@apple.com>
901
902         Finish replacing worldIDs with world objects
903
904         The only remaining use of worldIDs was in a method only used by DRT
905         for the isolated worlds tests.
906
907         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
908
909         Reviewed by Mark Rowe.
910
911         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
912         (LayoutTestController::evaluateScriptInIsolatedWorld):
913         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
914         (LayoutTestController::evaluateScriptInIsolatedWorld):
915         Updated for changes to WebFrame. Now holds the map of worldID -> world
916         at this level instead of making WebKit do it.
917
918 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
919
920         Reviewed by Simon Hausmann.
921
922         [Qt] Ensure the DRT does not output anything until first test is run
923
924         * DumpRenderTree/qt/DumpRenderTree.cpp:
925         * DumpRenderTree/qt/DumpRenderTree.h:
926
927 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
928
929         Reviewed by Tor Arne Vestbø.
930
931         Clear the undo stack in before each new test run.
932
933         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
934
935         * DumpRenderTree/qt/DumpRenderTree.cpp:
936         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
937
938 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
939
940         Reviewed by Kenneth Rohde Christiansen.
941
942         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
943
944         * DumpRenderTree/qt/DumpRenderTree.cpp:
945         (WebCore::WebPage::resetSettings):
946         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
947         (LayoutTestController::overridePreference):
948
949 2009-11-13  Eric Seidel  <eric@webkit.org>
950
951         Reviewed by Adam Barth.
952
953         Update committers.py based on svn records
954         https://bugs.webkit.org/show_bug.cgi?id=31366
955
956         This list was generated using validate-committer-lists from
957         https://bugs.webkit.org/show_bug.cgi?id=30970
958         and makes committers.py current for committers who have
959         committed in the last 3 years.
960
961         * Scripts/modules/committers.py:
962
963 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
964
965         Reviewed by Adam Barth.
966
967         The document-open.html test was flaky at times. The test invokes the layout test plugin
968         which in its destroy stream handler opens a new document. This basically tears down the
969         stream and the associated plugin instance. The pluginLog function in the layout test
970         plugin attempts to retrieve the window script object on a torn down plugin instance
971         which crashed consistently on windows in the debugger. The functions which issue
972         these logs already have a valid window script object. We now have variants of the pluginLog
973         function which take in a window script object with and without variable arguments. 
974
975         https://bugs.webkit.org/show_bug.cgi?id=31067
976
977         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
978         (pluginLogWithWindowObject):
979         (pluginLogWithWindowObjectVariableArgs):
980         (pluginLog):
981         (notifyTestCompletion):
982         (testDocumentOpen):
983         (testWindowOpen):
984
985 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
986
987         Reviewed by Gustavo Noronha Silva.
988
989         https://bugs.webkit.org/show_bug.cgi?id=30997
990         [Gtk] Implemment AtkDocument
991
992         Added testing support.
993
994         * DumpRenderTree/AccessibilityUIElement.cpp:
995         * DumpRenderTree/AccessibilityUIElement.h:
996         (getDocumentEncodingCallback):
997         (getDocumentURICallback):
998         (AccessibilityUIElement::getJSClass):
999         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1000         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1001         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1002         (AccessibilityUIElement::documentEncoding):
1003         (AccessibilityUIElement::documentURI):
1004
1005 2009-11-12  Adam Roben  <aroben@apple.com>
1006
1007         Replace worldIDs with world objects
1008
1009         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1010         user scripts/stylesheets and isolated worlds
1011
1012         Reviewed by Sam Weinig.
1013
1014         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1015         (LayoutTestController::addUserScript):
1016         (LayoutTestController::addUserStyleSheet):
1017         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1018         (LayoutTestController::addUserScript):
1019         (LayoutTestController::addUserStyleSheet):
1020         Changed these functions to create a new WebJSWorld each time they're
1021         called and to pass that world to WebKit.
1022
1023 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1024
1025         Reviewed by Oliver Hunt.
1026
1027         need to implement aria tree roles
1028         https://bugs.webkit.org/show_bug.cgi?id=31284
1029
1030         * DumpRenderTree/AccessibilityUIElement.cpp:
1031         (disclosedRowAtIndexCallback):
1032         (selectedRowAtIndexCallback):
1033         (isEqualCallback):
1034         (isAttributeSettableCallback):
1035         (isActionSupportedCallback):
1036         (disclosedByRowCallback):
1037         (hierarchicalLevelCallback):
1038         (AccessibilityUIElement::getJSClass):
1039         * DumpRenderTree/AccessibilityUIElement.h:
1040         (AccessibilityUIElement::isEqual):
1041         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1042         (AccessibilityUIElement::hierarchicalLevel):
1043         (AccessibilityUIElement::disclosedRowAtIndex):
1044         (AccessibilityUIElement::selectedRowAtIndex):
1045         (AccessibilityUIElement::disclosedByRow):
1046         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1047         (AccessibilityUIElement::getChildAtIndex):
1048         (AccessibilityUIElement::disclosedRowAtIndex):
1049         (AccessibilityUIElement::selectedRowAtIndex):
1050         (AccessibilityUIElement::titleUIElement):
1051         (AccessibilityUIElement::parentElement):
1052         (AccessibilityUIElement::disclosedByRow):
1053         (AccessibilityUIElement::hierarchicalLevel):
1054         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1055         (AccessibilityUIElement::hierarchicalLevel):
1056         (AccessibilityUIElement::disclosedRowAtIndex):
1057         (AccessibilityUIElement::selectedRowAtIndex):
1058         (AccessibilityUIElement::disclosedByRow):
1059
1060 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1061
1062         Reviewed by Darin Adler.
1063
1064         svn-apply can not handle git binary diffs
1065         https://bugs.webkit.org/show_bug.cgi?id=26830
1066
1067         Support "literal" type git binary diffs.
1068
1069         * Scripts/VCSUtils.pm:
1070         * Scripts/modules/scm_unittest.py:
1071         * Scripts/svn-apply:
1072
1073 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1074
1075         Not reviewed, removing duplicate entry for myself in committers.py.
1076
1077         * Scripts/modules/committers.py:
1078
1079 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1080
1081         Reviewed by Darin Adler and Mark Rowe.
1082
1083         https://bugs.webkit.org/show_bug.cgi?id=31200
1084         Tests in http/tests/security/mixedContent start to fail when new tests are added
1085
1086         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1087
1088 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1089
1090         Reviewed by Jan Alonzo.
1091
1092         Create, and display a window for the inspector, for inspector
1093         tests.
1094
1095         Need to also show/hide the inspector window to avoid having
1096         problems with code assuming it is realized
1097         https://bugs.webkit.org/show_bug.cgi?id=31347
1098
1099         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1100         (webInspectorShowWindow):
1101         (webInspectorCloseWindow):
1102         (webInspectorInspectWebView):
1103         (createWebView):
1104
1105 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1106
1107         Unreviewed Qt buildbot fix.
1108
1109         My previous fix was wrong, so revert that change and fix it by
1110         returning when the document of the frame has no document element.
1111         Idea is borrowed from mac and win DRT.
1112
1113         * DumpRenderTree/qt/DumpRenderTree.cpp:
1114         (WebCore::DumpRenderTree::dumpFramesAsText):
1115
1116 2009-11-11  Eric Seidel  <eric@webkit.org>
1117
1118         Reviewed byg Kenneth Rohde Christiansen.
1119
1120         Update Kenneth's committer record to include the email he
1121         uses on lists.webkit.org.
1122
1123         * Scripts/modules/committers.py:
1124
1125 2009-11-11  Eric Seidel  <eric@webkit.org>
1126
1127         Reviewed by Gustavo Noronha Silva.
1128
1129         Several committers use separate email addresses for bugzilla and svn.webkit.org
1130         https://bugs.webkit.org/show_bug.cgi?id=31364
1131
1132         Update records for existing committers to include email addresses
1133         used in svn.webkit.org and lists.webkit.org.
1134         Most committers use the same email address in all 3 places, but some use
1135         separate addresses.  committers.py needs record of each of these addresses.
1136
1137         * Scripts/modules/committers.py:
1138
1139 2009-11-11  Eric Seidel  <eric@webkit.org>
1140
1141         No review, adding second email address for an existing committer.
1142
1143         Add Yong Li's second bugzilla account to his committer record.
1144         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1145
1146         * Scripts/modules/committers.py:
1147
1148 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1149
1150         Reviewed by Simon Hausmann.
1151
1152         If the frame has no innerText don't append it, and
1153         do not add a newline which breaks some cross platform
1154         results.
1155
1156         * DumpRenderTree/qt/DumpRenderTree.cpp:
1157         (WebCore::DumpRenderTree::dumpFramesAsText):
1158
1159 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1160
1161         Reviewed by Simon Hausmann.
1162
1163         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1164
1165         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1166         (webkit_test_plugin_new_instance):
1167         (webkit_test_plugin_destroy_instance):
1168         (webkit_test_plugin_destroy_stream):
1169
1170 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1171
1172         Reviewed by Mark Rowe.
1173
1174         Implement the functionality needed by plugins/window-open.html
1175
1176         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1177         (webkit_test_plugin_new_instance):
1178         (webkit_test_plugin_set_window):
1179
1180 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1181
1182         Reviewed by Simon Hausmann.
1183
1184         [Qt] Force -graphicssystem raster and -style windows when running DRT
1185
1186         * DumpRenderTree/qt/main.cpp:
1187         * Scripts/run-webkit-tests:
1188
1189 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1190
1191         Reviewed by Simon Hausmann.
1192
1193         Compute correct library paths for Qt
1194
1195         * Scripts/webkitdirs.pm:
1196
1197 2009-11-10  Mark Rowe  <mrowe@apple.com>
1198
1199         Reviewed by Sam Weinig.
1200
1201         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1202
1203         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1204         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1205         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1206         that had enabled frame load delegate logging this would result in extra log messages being generated,
1207         causing the test to fail.
1208
1209         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1210         tests.
1211
1212         * DumpRenderTree/mac/DumpRenderTree.mm:
1213         (dumpRenderTree):
1214         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1215         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1216
1217 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1218
1219         Reviewed by Kenneth Rohde Christiansen.
1220
1221         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1222
1223         * DumpRenderTree/qt/DumpRenderTree.cpp:
1224         (WebCore::DumpRenderTree::DumpRenderTree):
1225
1226 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1227
1228         Reviewed by Jan Alonzo.
1229
1230         [GTK] Remove WebSocket configuration from WebKitWebSettings
1231         https://bugs.webkit.org/show_bug.cgi?id=31244
1232
1233         Follow-up of r50724. Don't set the enable-web-socket property
1234         anymore.
1235
1236         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1237         (resetDefaultsToConsistentValues):
1238
1239 2009-11-10  Oliver Hunt  <oliver@apple.com>
1240
1241         Reviewed by Maciej Stachowiak.
1242
1243         Rename 3D Canvas related classes to use WebGL prefix
1244         https://bugs.webkit.org/show_bug.cgi?id=29095
1245
1246         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1247         and upate webkitdirs script to new method of testing for WebGL.
1248
1249         * Scripts/do-webcore-rename:
1250         * Scripts/webkitdirs.pm:
1251
1252 2009-11-09  Oliver Hunt  <oliver@apple.com>
1253
1254         Reviewed by Geoff Garen.
1255
1256         Make do-webcore-rename work with git.
1257
1258         * Scripts/do-webcore-rename:
1259
1260 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1261
1262         Adding Kenneth to the reviewers list.
1263
1264         * Scripts/modules/committers.py:
1265
1266 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1267
1268         Reviewed by Jan Alonzo.
1269
1270         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1271         https://bugs.webkit.org/show_bug.cgi?id=30482
1272
1273         LayoutTestControllerGtk now uses the exposed
1274         Page::tabKeyCyclesThroughElements API
1275
1276         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1277         (LayoutTestController::setTabKeyCyclesThroughElements):
1278
1279 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1280
1281         Reviewed by Holger Freyther.
1282
1283         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1284         This helps to pass the test case below. Also replaced hardcoded
1285         code numbers with defined constants.
1286         https://bugs.webkit.org/show_bug.cgi?id=31185
1287         
1288         Test: editing/undo/undo-deleteWord.html
1289
1290         * DumpRenderTree/qt/EventSenderQt.cpp:
1291         (EventSender::keyDown):
1292
1293 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1294
1295         Reviewed by Holger Freyther.
1296
1297         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1298         https://bugs.webkit.org/show_bug.cgi?id=31164
1299
1300         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1301
1302         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1303         (LayoutTestController::processWork):
1304
1305 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1306
1307         Reviewed by Holger Freyther.
1308
1309         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1310         https://bugs.webkit.org/show_bug.cgi?id=31158
1311
1312         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1313         always, which from WorkQueue prospective means that a load has been started
1314         and the queue processing should stop and wait for the load to finish.
1315         Spinning it off into a loading and a non-loading variants was the solution
1316         adopted by Mac's DRT to work around this problem. The former keeps returning
1317         'true' while the later executes the script synchronously and returns 'false'
1318         making it possible to the WorkQueue to proceed right away.
1319
1320         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1321         (LayoutTestController::processWork):
1322         (LayoutTestController::queueLoadingScript):
1323         (LayoutTestController::queueNonLoadingScript):
1324         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1325         * DumpRenderTree/qt/WorkQueueItem.h:
1326         (LoadingScriptItem::LoadingScriptItem):
1327         (LoadingScriptItem::invoke):
1328         (NonLoadingScriptItem::NonLoadingScriptItem):
1329         (NonLoadingScriptItem::invoke):
1330
1331 2009-11-07  Mark Rowe  <mrowe@apple.com>
1332
1333         Rubber-stamped by Cameron Zwarich.
1334
1335         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1336
1337         * Scripts/commit-log-editor:
1338
1339 2009-11-07  Mark Rowe  <mrowe@apple.com>
1340
1341         Reviewed by Darin Adler.
1342
1343         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1344         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1345
1346         Move logic for determining the name and email address to use in a ChangeLog entry from
1347         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1348         whether the author of the patch matches committer, and therefore needs access to the
1349         email address that would be used in a ChangeLog entry.
1350
1351         Based on a patch by Pierre d'Herbemont.
1352
1353         * Scripts/VCSUtils.pm:
1354         * Scripts/commit-log-editor:
1355         * Scripts/prepare-ChangeLog:
1356         * Scripts/webkitdirs.pm:
1357
1358 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1359
1360         Reviewed by Adam Barth.
1361
1362         Added functionality to the layout test plugin to invoke document.open and
1363         window.open with default arguments. The associated webkit bug is
1364         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1365         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1366         work in Chromium (V8) if there is no calling javascript context. To achieve this
1367         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1368         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1369
1370         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1371         (testDocumentOpen):
1372         (testWindowOpen):
1373         (pluginAllocate):
1374         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1375         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1376         (NPP_New):
1377         (NPP_SetWindow):
1378         (NPP_DestroyStream):
1379         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1380         (NPP_New):
1381         (NPP_SetWindow):
1382         (NPP_NewStream):
1383         (NPP_DestroyStream):
1384
1385 2009-11-06  Eric Seidel  <eric@webkit.org>
1386
1387         Reviewed by Adam Barth.
1388
1389         bugzilla-tool crashed with exception
1390         https://bugs.webkit.org/show_bug.cgi?id=31092
1391
1392         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1393
1394 2009-11-04  Eric Seidel  <eric@webkit.org>
1395
1396         No review, just add a line which got left out of the patch uploaded for commit.
1397
1398         commit-queue is crashing when trying to reject patches after unknown failures
1399         https://bugs.webkit.org/show_bug.cgi?id=31091
1400
1401         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1402
1403 2009-11-04  Adam Roben  <aroben@apple.com>
1404
1405         Remove bogus else clause in bugzilla-tool
1406
1407         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1408         create-bug raises exception after entering bug description
1409
1410         Reviewed by David Kilzer.
1411
1412         * Scripts/bugzilla-tool:
1413         (CreateBug): else clauses are only hit if no exception is raised, so
1414         it makes no sense to try to re-raise the exception in an else clause.
1415         The exception will automatically be re-raised if it doesn't match any
1416         of the except clauses, so we don't have to do anything special here at
1417         all to get the desired behavior.
1418
1419 2009-11-04  Eric Seidel  <eric@webkit.org>
1420
1421         Reviewed by David Kilzer.
1422
1423         svn-apply's fixChangeLogPatch function seems broken
1424         https://bugs.webkit.org/show_bug.cgi?id=30683
1425
1426         Update fixChangeLogPatch to be able to handle patches which
1427         don't start at line 1.
1428         Add unit tests for svn-apply to scm_unittest.py.
1429
1430         * Scripts/VCSUtils.pm:
1431         * Scripts/modules/scm_unittest.py:
1432
1433 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1434
1435         Reviewed by Beth Dakin.
1436
1437         Need to implement ARIA role="combobox"
1438         https://bugs.webkit.org/show_bug.cgi?id=31096
1439
1440         * DumpRenderTree/AccessibilityUIElement.cpp:
1441         (showMenuCallback):
1442         (getIsExpandedCallback):
1443         (AccessibilityUIElement::getJSClass):
1444         * DumpRenderTree/AccessibilityUIElement.h:
1445         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1446         (AccessibilityUIElement::isExpanded):
1447         (AccessibilityUIElement::showMenu):
1448         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1449         (AccessibilityUIElement::isExpanded):
1450         (AccessibilityUIElement::showMenu):
1451         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1452         (AccessibilityUIElement::isSelected):
1453         (AccessibilityUIElement::isExpanded):
1454         (AccessibilityUIElement::showMenu):
1455
1456 2009-11-04  Eric Seidel  <eric@webkit.org>
1457
1458         Reviewed by Adam Barth.
1459
1460         commit-queue is crashing when trying to reject patches after unknown failures
1461         https://bugs.webkit.org/show_bug.cgi?id=31091
1462
1463         * Scripts/bugzilla-tool:
1464          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1465            so we have to find out what the current patch is by asking bugzilla again.
1466          - Discovered that this code was also leaking file descriptors, so fixed that.
1467
1468 2009-11-04  Adam Roben  <aroben@apple.com>
1469
1470         Make run-webkit-tests work for the Debug_Internal Windows
1471         configuration
1472
1473         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1474         suffix.
1475
1476         Fixes <http://webkit.org/b/31123>.
1477
1478         Reviewed by Sam Weinig.
1479
1480         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1481         Debug_Internal, either.
1482
1483 2009-11-04  Eric Seidel  <eric@webkit.org>
1484
1485         Reviewed by Adam Barth.
1486
1487         committers.py needs a way to store non-bugzilla email addresses
1488         https://bugs.webkit.org/show_bug.cgi?id=31037
1489
1490         Make Committer and Reviewer constructors take a single email or a list of emails.
1491         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1492         Expose reviewers(), used by validate-committer-lists on bug 30970.
1493
1494         * Scripts/modules/committers.py:
1495         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1496
1497 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1498
1499         Reviewed by David Levin.
1500
1501         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1502         https://bugs.webkit.org/show_bug.cgi?id=27491
1503
1504         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1505         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1506
1507         Functions to start or stop Web Socket servers are added.
1508
1509         * Scripts/run-webkit-tests:
1510
1511 2009-11-03  Eric Seidel  <eric@webkit.org>
1512
1513         No review, just changing wording of log message.
1514
1515         Change log string to say "failed" instead of "rejected"
1516         when a commit fails due to an out of date checkout.
1517         This makes grepping the commit-queue log for rejected patches easier.
1518
1519         * Scripts/bugzilla-tool:
1520
1521 2009-11-03  Eric Seidel  <eric@webkit.org>
1522
1523         No review, adding commonly known committers missing from the file.
1524
1525         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1526
1527 2009-11-03  Eric Seidel  <eric@webkit.org>
1528
1529         No review, just sort-order cleanup.
1530
1531         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1532
1533 2009-11-03  Stephen White  <senorblanco@chromium.org>
1534
1535         (Unreviewed).
1536
1537         Add myself to committers.py.
1538
1539         * Scripts/modules/committers.py:
1540
1541 2009-11-03  Robin Dunn  <robin@alldunn.com>
1542
1543         Reviewed by Kevin Ollviier.
1544
1545         Add packaging scripts for Debian-based Linux distros.
1546         
1547         https://bugs.webkit.org/show_bug.cgi?id=31075
1548
1549         * wx/packaging/build-debian-installer.py: Added.
1550         * wx/packaging/debian: Added.
1551
1552 2009-11-03  Dan Bernstein  <mitz@apple.com>
1553
1554         Reviewed by Anders Carlsson and Beth Dakin.
1555
1556         https://bugs.webkit.org/show_bug.cgi?id=31070
1557
1558         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1559         destroyed, it executes the value of the 'ondestroy' parameter as a
1560         script.
1561
1562         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1563         (pluginAllocate): Initialize onDestroy.
1564         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1565         onDestroy.
1566         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1567         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
1568         specified.
1569         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
1570
1571 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1572
1573         Reviewed by Xan Lopez.
1574
1575         https://bugs.webkit.org/show_bug.cgi?id=31035
1576         [GTK] some accessibility tests hitting assertion in debug builds
1577
1578         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
1579
1580         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1581         (AccessibilityController::rootElement):
1582
1583 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
1584
1585         Reviewed by Beth Dakin.
1586
1587         Support ARIA "tab" roles
1588         https://bugs.webkit.org/show_bug.cgi?id=30842
1589
1590         * DumpRenderTree/AccessibilityUIElement.cpp:
1591         * DumpRenderTree/AccessibilityUIElement.h:
1592         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1593         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1594         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1595
1596 2009-11-01  Eric Seidel  <eric@webkit.org>
1597
1598         Reviewed by David Levin.
1599
1600         buildbots should use --exit-after-N-failures
1601         https://bugs.webkit.org/show_bug.cgi?id=30809
1602
1603         Make the bots exit after 20 failures to prevent never-ending
1604         test runs where every test spends a minute crashing.
1605
1606         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1607
1608 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1609
1610         Reviewed by Eric Seidel.
1611
1612         Turn on warnings for QtWebKit for gcc
1613         https://bugs.webkit.org/show_bug.cgi?id=30958
1614
1615         * DumpRenderTree/qt/main.cpp: 
1616         (crashHandler): Mark function NO_RETURN
1617
1618 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
1619
1620         Adding myself to the committers list.
1621
1622         * Scripts/modules/committers.py:
1623
1624 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
1625
1626         Fix an issue that Adam noticed in DRT.
1627
1628         Reviewed by Darin Adler.
1629
1630         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1631         (AccessibilityUIElement::role):
1632         Get the length of the role text, and create a buffer dynamically.
1633
1634 2009-10-30  Eric Seidel  <eric@webkit.org>
1635
1636         No review, rolling out r50105.
1637         http://trac.webkit.org/changeset/50105
1638
1639         This commit was causing:
1640         https://bugs.webkit.org/show_bug.cgi?id=30869
1641         We'll re-implement the feature a different way.
1642
1643         * Scripts/bugzilla-tool:
1644
1645 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1646
1647         Test for MSAA: Accessibility of headings is not correct
1648
1649         https://bugs.webkit.org/show_bug.cgi?id=30937
1650
1651         Reviewed by Adam Roben.
1652
1653         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1654         (AccessibilityUIElement::role):
1655         Allow the role returned to be a BSTR.
1656         (AccessibilityUIElement::description):
1657         Fix a copy/paste error.
1658
1659 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1660
1661         Test for MSAA: Accessibility of links is wrong
1662
1663         https://bugs.webkit.org/show_bug.cgi?id=30928
1664
1665         Reviewed by Darin Adler.
1666
1667         * DumpRenderTree/AccessibilityUIElement.cpp:
1668         (getAccessibilityValueCallback):
1669         Return the accessibility value.
1670         (AccessibilityUIElement::getJSClass):
1671         Added "accessibilityValue" value.
1672
1673         * DumpRenderTree/AccessibilityUIElement.h:
1674
1675         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1676         (AccessibilityUIElement::accessibilityValue):
1677         Stubbed.
1678
1679         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1680         (AccessibilityUIElement::accessibilityValue):
1681         Stubbed.
1682
1683         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1684         (AccessibilityUIElement::accessibilityValue):
1685         Get the object's value, and return it as a JS string.
1686
1687 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
1688
1689         Fix typo in command name used by wx build system.
1690
1691         * wx/build/build_utils.py:
1692
1693 2009-10-30  Adam Barth  <abarth@webkit.org>
1694
1695         Reviewed by Darin Adler.
1696
1697         Patch v1 is a dumb default name for patches
1698         https://bugs.webkit.org/show_bug.cgi?id=30952
1699
1700         Let's use "Patch" instead.
1701
1702         * Scripts/bugzilla-tool:
1703
1704 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1705
1706         Unreviewed trivial buildfix.
1707
1708         [Qt] Buildfix for r50333.
1709
1710         * DumpRenderTree/qt/DumpRenderTree.pro:
1711
1712 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
1713
1714         Reviewed by Holger Freyther.
1715
1716         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
1717         https://bugs.webkit.org/show_bug.cgi?id=30953
1718
1719         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
1720         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
1721         makes qt DRT to share this implementation (as gtk and mac ports do).
1722
1723         * DumpRenderTree/qt/DumpRenderTree.pro:
1724         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
1725         * DumpRenderTree/qt/WorkQueue.h: Removed.
1726
1727 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1728
1729         Unreviewed potential buildbot fix.
1730
1731         Second try: Reset page history before running each test.
1732
1733         Apparently the QWebHistory::clear() keeps the current page
1734         in history which is not what we want, so we not additionally
1735         sets the history capacity to 0 (forces removing everything)
1736         and then sets it back to its original value.
1737
1738         * DumpRenderTree/qt/DumpRenderTree.cpp:
1739         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1740
1741 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1742
1743         Unreviewed potential buildbot fix.
1744
1745         Reset page history before running each test.
1746
1747         * DumpRenderTree/qt/DumpRenderTree.cpp:
1748         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1749
1750 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
1751
1752         Reviewed by Eric Seidel.
1753
1754         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
1755
1756         Bug 28420 -  Implement HTML5 <ruby> rendering
1757         (https://bugs.webkit.org/show_bug.cgi?id=28420)
1758
1759         No new tests (no functional change).
1760
1761         * Scripts/build-webkit:
1762
1763 2009-10-29  Dan Bernstein  <mitz@apple.com>
1764
1765         Reviewed by Mark Rowe.
1766
1767         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
1768         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
1769         define it.
1770
1771         * Scripts/VCSUtils.pm:
1772         * Scripts/svn-apply:
1773         * Scripts/svn-unapply:
1774
1775 2009-10-29  Xan Lopez  <xlopez@igalia.com>
1776
1777         Reviewed by Gustavo Noronha.
1778
1779         Use the GTK+ main loop instead of rolling our own mini-version of
1780         it.
1781
1782         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1783         (dump):
1784         (runTest):
1785         (webViewLoadFinished):
1786
1787 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1788
1789         Reviewed by Oliver Hunt.
1790
1791         Implement the Qt version of DRT dumpBackForwardList().
1792
1793         * DumpRenderTree/qt/DumpRenderTree.cpp:
1794         (WebCore::dumpHistoryItem):
1795         (WebCore::DumpRenderTree::dumpBackForwardList):
1796
1797 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1798
1799         Reviewed by Adam Roben.
1800
1801         Implement DRT functionality for Qt introduced in
1802         r28690 and r28705.
1803
1804         - Implemented pathToLocalResource which exposes the functionality of
1805         converting a given unix path to the correct location on Windows.
1806         - Implemented a way to remove machine-dependent information from paths
1807         in layout test results.
1808
1809         * DumpRenderTree/qt/DumpRenderTree.cpp:
1810         (WebCore::urlSuitableForTestResult):
1811         (WebCore::WebPage::javaScriptConsoleMessage):
1812         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1813         (LayoutTestController::pathToLocalResource):
1814         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1815
1816 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
1817
1818         Adding myself to the committers list.
1819
1820         * Scripts/modules/committers.py:
1821
1822 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
1823
1824         Adding myself to the committers list.
1825
1826         * Scripts/modules/committers.py:
1827
1828 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1829
1830         Reviewed by Jan Alonzo.
1831
1832         [GTK] API to start inspector for a WebView
1833         https://bugs.webkit.org/show_bug.cgi?id=22551
1834
1835         Use the new inspector API to implement the LayoutTestController
1836         interfaces used to test the inspector.
1837
1838         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1839         (webInspectorInspectWebView):
1840         (createWebView):
1841         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1842         (LayoutTestController::showWebInspector):
1843         (LayoutTestController::closeWebInspector):
1844         (LayoutTestController::evaluateInWebInspector):
1845
1846 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
1847
1848         Reviewed by Eric Seidel.
1849
1850         [Qt] WebFrame::counterValueForElementById must not be exposed
1851         https://bugs.webkit.org/show_bug.cgi?id=30882
1852
1853         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1854         (LayoutTestController::counterValueForElementById):
1855
1856 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1857
1858         Rubberstamped by Oliver Hunt.
1859
1860         Fix the warning:
1861
1862         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
1863         declared with attribute warn_unused_result".
1864
1865         by actually checking the result. In the case it is null, an
1866         error has occoured, so treat it as the other fatal errors.
1867
1868         * DumpRenderTree/qt/DumpRenderTree.cpp:
1869         (WebCore::DumpRenderTree::initializeFonts):
1870
1871 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
1872
1873         Reviewed by Darin Adler.
1874
1875         Provide a way to get counter values with layoutTestContoller
1876         https://bugs.webkit.org/show_bug.cgi?id=30555
1877
1878         Define layoutTestContoller.counterValueForElementById.
1879
1880         * DumpRenderTree/LayoutTestController.cpp:
1881         (counterValueForElementByIdCallback):
1882         (LayoutTestController::staticFunctions):
1883         * DumpRenderTree/LayoutTestController.h:
1884         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1885         (LayoutTestController::counterValueForElementById):
1886
1887 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1888
1889         Rubberstamped by Oliver Hunt.
1890
1891         Change two methods to be internal for DRT use only.
1892
1893         Part of [Qt] Review all new API in Qt 4.6
1894         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
1895
1896         * DumpRenderTree/qt/DumpRenderTree.cpp:
1897         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1898         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1899         (LayoutTestController::whiteListAccessFromOrigin):
1900
1901 2009-10-27  Eric Seidel  <eric@webkit.org>
1902
1903         Reviewed by Adam Barth.
1904
1905         REGRESSION: svn-apply exits(1) when applying a patch with a file add
1906         https://bugs.webkit.org/show_bug.cgi?id=30826
1907
1908         * Scripts/svn-apply:
1909          - Add () around all system() calls.
1910          - Use the correct system() == 0 or die instead of system() or die
1911          - Add descriptive messages to all die statements.
1912
1913 2009-10-27  Steve Block  <steveblock@google.com>
1914
1915         Reviewed by NOBODY.
1916
1917         Adds steveblock@google.com to list of committers.
1918
1919         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
1920
1921 2009-10-27  Eric Seidel  <eric@webkit.org>
1922
1923         Reviewed by Adam Barth.
1924
1925         svn-apply can exit(0) even on patch failure
1926         https://bugs.webkit.org/show_bug.cgi?id=29622
1927
1928         * Scripts/svn-apply:
1929          - Add a bunch of "or die" statements, hopefully catching all
1930            possible cases where failure could still exit(0).
1931
1932 2009-10-27  Eric Seidel  <eric@webkit.org>
1933
1934         Reviewed by Adam Barth.
1935
1936         svn-* scripts should share code through VCSUtils.pm
1937         https://bugs.webkit.org/show_bug.cgi?id=30791
1938
1939         Just moving code into a shared location.
1940
1941         * Scripts/VCSUtils.pm:
1942         * Scripts/prepare-ChangeLog:
1943         * Scripts/resolve-ChangeLogs:
1944         * Scripts/svn-apply:
1945         * Scripts/svn-create-patch:
1946         * Scripts/svn-unapply:
1947         * Scripts/update-webkit:
1948
1949 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
1950
1951         Suppress a huge number of MSVC warnings when building wxWebKit.
1952
1953         * wx/build/settings.py:
1954
1955 2009-10-26  Eric Seidel  <eric@webkit.org>
1956
1957         No review, just adding Mike Belshe to the committers list.
1958
1959         * Scripts/modules/committers.py:
1960
1961 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1962
1963         Reviewed by Darin Adler.
1964
1965         Make .rc files compile on Windows without depending on MFC headers
1966         https://bugs.webkit.org/show_bug.cgi?id=30750
1967
1968         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
1969         windows.h instead of afxres.h because it exists even when MFC is not 
1970         installed, and is all that's needed here.
1971
1972         * FindSafari/FindSafari.rc: Ditto
1973
1974 2009-10-24  Eric Seidel  <eric@webkit.org>
1975
1976         Reviewed by Adam Barth.
1977
1978         bugzilla-tool post-diff should know how to mark commit-queue=?
1979         https://bugs.webkit.org/show_bug.cgi?id=29202
1980
1981         * Scripts/bugzilla-tool:
1982          - Add --commit-queue option to post-diff, post-commits and create-bug.
1983         * Scripts/modules/bugzilla.py:
1984          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
1985          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
1986
1987 2009-10-23  Eric Seidel  <eric@webkit.org>
1988
1989         Reviewed by Adam Barth.
1990
1991         bugzilla-tool commit-queue does not notice modifications to committers.py
1992         https://bugs.webkit.org/show_bug.cgi?id=30084
1993
1994         * Scripts/bugzilla-tool:
1995          - Make commit-queue re-exec itself instead of using while(1).
1996          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
1997          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
1998
1999 2009-10-22  Eric Seidel  <eric@webkit.org>
2000
2001         Reviewed by Adam Barth.
2002
2003         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2004         https://bugs.webkit.org/show_bug.cgi?id=30634
2005
2006         * Scripts/bugzilla-tool:
2007          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2008          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2009
2010 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2011
2012         Reviewed by Eric Seidel.
2013
2014         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2015
2016         https://bugs.webkit.org/show_bug.cgi?id=30763
2017
2018         * pywebsocket/mod_pywebsocket/__init__.py:
2019         * pywebsocket/mod_pywebsocket/dispatch.py:
2020         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2021         * pywebsocket/mod_pywebsocket/standalone.py:
2022         * pywebsocket/setup.py:
2023         * pywebsocket/test/test_dispatch.py:
2024
2025 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2026
2027         Reviewed by David Levin.
2028
2029         REGRESSION: 2 failures in run-webkit-unittests
2030         https://bugs.webkit.org/show_bug.cgi?id=30645
2031
2032         * Scripts/modules/cpp_style_unittest.py:
2033         Fixed a few test scenarios which apparently lost some spaces from 
2034         text literals.
2035
2036 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2037
2038         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2039
2040         * Scripts/webkitdirs.pm:
2041
2042 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2043
2044         Reviewed by Darin Adler.
2045
2046         Unification of using null device in perl scripts.
2047         https://bugs.webkit.org/show_bug.cgi?id=30572
2048
2049         * Scripts/VCSUtils.pm:
2050         * Scripts/bisect-builds:
2051         * Scripts/resolve-ChangeLogs:
2052         * Scripts/run-iexploder-tests:
2053         * Scripts/run-jsc:
2054         * Scripts/run-mangleme-tests:
2055         * Scripts/run-webkit-tests:
2056         * Scripts/webkitdirs.pm:
2057         Using File::Spec->devnull() instead of hard coded /dev/null.
2058
2059 2009-10-26  Eric Seidel  <eric@webkit.org>
2060
2061         Reviewed by Holger Freyther.
2062
2063         Reviewers are missing from committers.py
2064         https://bugs.webkit.org/show_bug.cgi?id=30733
2065
2066         * Scripts/modules/committers.py:
2067
2068 2009-10-23  Eric Seidel  <eric@webkit.org>
2069
2070         No review, only adding Alice to the list of reviewers.
2071
2072         * Scripts/modules/committers.py:
2073
2074 2009-10-23  Eric Seidel  <eric@webkit.org>
2075
2076         Reviewed by Eric Carlson.
2077
2078         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2079         https://bugs.webkit.org/show_bug.cgi?id=30700
2080
2081         * DumpRenderTree/mac/DumpRenderTree.mm:
2082         (resetDefaultsToConsistentValues): Update QuickTime version check.
2083
2084 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2085
2086         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2087         character measurement APIs that are private on Tiger.
2088
2089         * wx/build/settings.py:
2090
2091 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2092
2093         Reviewed by NOBODY (build fix).
2094         Build fix following bug #30696.
2095
2096         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2097         (LayoutTestController::evaluateScriptInIsolatedWorld):
2098
2099 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2100
2101         Reviewed by Sam Weinig & Geoff Garen.
2102
2103         https://bugs.webkit.org/show_bug.cgi?id=30696
2104         Enable isolated-worlds tests on mac.
2105
2106         Add private interface for DRT to invoke execution in a given world.
2107
2108         * DumpRenderTree/LayoutTestController.cpp:
2109         (evaluateScriptInIsolatedWorldCallback):
2110         (LayoutTestController::staticFunctions):
2111         * DumpRenderTree/LayoutTestController.h:
2112         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2113         (LayoutTestController::evaluateScriptInIsolatedWorld):
2114         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2115         (LayoutTestController::evaluateScriptInIsolatedWorld):
2116
2117 2009-10-21  Eric Seidel  <eric@webkit.org>
2118
2119         Reviewed by Adam Barth.
2120
2121         bugzilla-tool's "patch failed to download an apply" error should give more information
2122         https://bugs.webkit.org/show_bug.cgi?id=30632
2123
2124         * Scripts/modules/scm.py:
2125          - Use the common run_command method instead of custom POpen code.
2126          - Make run_command know how to take pipes as input.
2127         * Scripts/modules/scm_unittest.py:
2128          - Add new tests to cover change.
2129          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2130
2131 2009-10-21  Kent Tamura  <tkent@chromium.org>
2132
2133         Unreviewed.  Adding myself to the committers list.
2134
2135         * Scripts/modules/committers.py:
2136
2137 2009-10-21  Robin Dunn  <robin@alldunn.com>
2138
2139         Reviewed by Kevin Ollivier.
2140
2141         Update the Windows installer builder to work with Vista / Win 7 and with git.
2142         
2143         https://bugs.webkit.org/show_bug.cgi?id=30649
2144
2145         * wx/build/build_utils.py:
2146         * wx/packaging/build-mac-installer.py:
2147         * wx/packaging/build-win-installer.py:
2148         * wx/packaging/wxWebKitInstaller.iss.in:
2149
2150 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2151
2152         Reviewed by Gustavo Noronha.
2153
2154         [GTK] Added conditional code to avoid using
2155         gdk_window_get_root_coords if we do not have a gtk+ release newer
2156         than 2.17.3.
2157         https://bugs.webkit.org/show_bug.cgi?id=30636
2158
2159         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2160
2161 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2162
2163         Reviewed by Eric Seidel.
2164
2165         [Qt] Added dummy implementation for keepWebHistory()
2166         https://bugs.webkit.org/show_bug.cgi?id=30592
2167
2168         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2169         (LayoutTestController::keepWebHistory):
2170         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2171
2172 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2173
2174         Reviewed by Xan Lopez.
2175
2176         [GTK] Fixed the double click condition, it is not double click if
2177         we move in just in one direction.
2178         https://bugs.webkit.org/show_bug.cgi?id=30636
2179
2180         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2181
2182 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2183
2184         Reviewed by Xan Lopez.
2185
2186         [GTK] Initialize the events completly before emitting them.
2187         https://bugs.webkit.org/show_bug.cgi?id=30633
2188
2189         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2190
2191 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2192
2193         wx build fix. Fix for when linking using --as-needed with gcc.
2194
2195         * wx/browser/wscript:
2196
2197 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2198
2199         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2200         to support all the features used by CURL backend.
2201         
2202         * wx/build/settings.py:
2203         * wx/install-unix-extras:
2204
2205 2009-10-20  Anton Muhin  <antonm@chromium.org>
2206
2207         Reviewed by Adam Barth.
2208
2209         Add {ager,antonm,yurys}@chromium.org into committers.py
2210         https://bugs.webkit.org/show_bug.cgi?id=30560
2211
2212         * Scripts/modules/committers.py:
2213
2214 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2215
2216         Reviewed by Tor Arne Vestbø.
2217
2218         Make the Netscape Test plugin available to the Qt launcher.
2219
2220         * Scripts/run-launcher:
2221
2222 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2223
2224         Reviewed by David Levin.
2225
2226         Removed WebSocket runtime settings.
2227         https://bugs.webkit.org/show_bug.cgi?id=29896
2228
2229         WebSocket runtime configuration is supported by chromium/v8 only.
2230
2231         * DumpRenderTree/mac/DumpRenderTree.mm:
2232         (resetDefaultsToConsistentValues):
2233         * DumpRenderTree/win/DumpRenderTree.cpp:
2234         (resetDefaultsToConsistentValues):
2235
2236 2009-10-19  Nate Chapin  <japhet@chromium.org>
2237
2238         Reviewed by Adam Barth.
2239
2240         Add testFail() to test plugin so we can test our handling of a
2241         plugin invoke call returning false.
2242
2243         https://bugs.webkit.org/show_bug.cgi?id=30239
2244
2245         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2246         (pluginInvoke):
2247         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2248
2249 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2250
2251         Reviewed by Gustavo Noronha.
2252
2253         Enable DOM pasting when running layout tests.
2254
2255         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2256         (resetDefaultsToConsistentValues):
2257
2258 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2259
2260         Reviewed by Simon Hausmann.
2261
2262         Use the setPreferredContentsSize method instead
2263         of setFixedContentsSize, as the method has been renamed.
2264
2265         * DumpRenderTree/qt/DumpRenderTree.cpp:
2266         (WebCore::DumpRenderTree::open):
2267         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2268         (LayoutTestController::setFixedContentsSize):
2269
2270 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2271
2272         Reviewed by Dan Bernstein.
2273
2274         https://bugs.webkit.org/show_bug.cgi?id=30456
2275         Fixes for new Debug_All Windows build configuration.
2276
2277         * DumpRenderTree/win/DumpRenderTree.cpp:
2278         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2279         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2280
2281 2009-10-16  Eric Seidel  <eric@webkit.org>
2282
2283         Reviewed by Adam Barth.
2284
2285         commit-queue status bot should list which buildbot is blocking the queue
2286         https://bugs.webkit.org/show_bug.cgi?id=30452
2287
2288         Add new methods and testing.
2289
2290         * Scripts/bugzilla-tool:
2291         * Scripts/modules/buildbot.py:
2292         * Scripts/modules/buildbot_unittest.py:
2293
2294 2009-10-16  Eric Seidel  <eric@webkit.org>
2295
2296         Reviewed by Adam Barth.
2297
2298         run-webkit-tests fails when CWD is not inside a WebKit checkout
2299         https://bugs.webkit.org/show_bug.cgi?id=30451
2300
2301         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2302         * Scripts/modules/scm_unittest.py:
2303           - Remove use of original_path (we don't need to restore the CWD).
2304           - Don't use '.' to find the webkit checkout, use __file__ instead.
2305
2306 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2307
2308         Reviewed by Adam Roben.
2309
2310         Add a Debug_All configuration to build entire stack as debug.
2311         Change Debug_Internal to:
2312         - stop using _debug suffix for all WebKit/Safari binaries
2313         - not use _debug as a DLL naming suffix
2314         - use non-debug C runtime lib.
2315
2316         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2317         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2318         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2319         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2320         Add missing debug.vsprops inherited property sheet.
2321         Add Debug_All configuration.
2322         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2323         * WinLauncher/WinLauncher.vcproj:
2324         Removed extraneous definitions inherited from vsprops.
2325         Add Debug_All configuration.
2326
2327 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2328
2329         Reviewed by David Levin.
2330
2331         check-webkit-style is wrong about indent checking in namespaces
2332         in header files and a few other things
2333         https://bugs.webkit.org/show_bug.cgi?id=30362
2334
2335         The few other things include:
2336         + check-webkit-style does not require spaces around the equal sign
2337           inside 'if' statements and around binary operators that take 
2338           numeric literals.
2339         + check-webkit-style reports false errors for the / operator
2340           when part of a filename in the #include directive.
2341
2342         * Scripts/modules/cpp_style.py:
2343         Improved indentation checking and space checking around
2344         binary operators. While the checks are still not perfect,
2345         they are clearly better than before.
2346         * Scripts/modules/cpp_style_unittest.py:
2347         Added test cases for the newly supported checks and modified old
2348         test cases to match the new guidelines
2349
2350 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2351
2352         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2353
2354         * wx/build/settings.py:
2355
2356 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2357
2358         Reviewed by David Levin.
2359
2360         Add mod_pywebsocket to test Web Sockets.
2361         http://code.google.com/p/pywebsocket/
2362         https://bugs.webkit.org/show_bug.cgi?id=27490
2363
2364         * pywebsocket/COPYING: Added.
2365         * pywebsocket/MANIFEST.in: Added.
2366         * pywebsocket/README: Added.
2367         * pywebsocket/example/echo_client.py: Added.
2368         * pywebsocket/example/echo_wsh.py: Added.
2369         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2370         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2371         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2372         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2373         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2374         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2375         * pywebsocket/mod_pywebsocket/util.py: Added.
2376         * pywebsocket/setup.py: Added.
2377         * pywebsocket/test/config.py: Added.
2378         * pywebsocket/test/mock.py: Added.
2379         * pywebsocket/test/run_all.py: Added.
2380         * pywebsocket/test/test_dispatch.py: Added.
2381         * pywebsocket/test/test_handshake.py: Added.
2382         * pywebsocket/test/test_mock.py: Added.
2383         * pywebsocket/test/test_msgutil.py: Added.
2384         * pywebsocket/test/test_util.py: Added.
2385         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2386         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2387         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2388         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2389         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2390         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2391         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2392         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2393
2394 2009-10-15  James Robinson  <jamesr@google.com>
2395
2396         Reviewed by David Levin.
2397
2398         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2399
2400         https://bugs.webkit.org/show_bug.cgi?id=30426
2401
2402         * Scripts/modules/cpp_style.py:
2403         * Scripts/modules/cpp_style_unittest.py:
2404
2405 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2406
2407         Reviewed by Adam Roben.
2408
2409         Fixes <http://webkit.org/b/30411>.
2410         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2411         
2412         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2413         building Chromium.
2414
2415         * Scripts/pdevenv:
2416
2417 2009-10-15  Robin Dunn  <robin@alldunn.com>
2418
2419         Reviewed by Kevin Ollivier.
2420
2421         Add Mac package building scripts for wx.
2422         
2423         https://bugs.webkit.org/show_bug.cgi?id=30405
2424
2425         * wx/build/build_utils.py:
2426         * wx/build/settings.py:
2427         * wx/packaging/build-mac-installer.py: Added.
2428
2429 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2430
2431         Reviewed by Gustavo Noronha.
2432
2433         Enable Web Sockets support when running layout tests.
2434
2435         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2436         (resetDefaultsToConsistentValues):
2437
2438 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2439
2440         Reviewed by Gustavo Noronha.
2441
2442         Need to initialize event.button.button, since in most cases a
2443         button number is not passed as an argument.
2444
2445         * DumpRenderTree/gtk/EventSender.cpp:
2446         (mouseDownCallback):
2447         (mouseUpCallback):
2448
2449 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2450
2451         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2452         the OS if none was explicitly set.
2453
2454         * wx/build/settings.py:
2455
2456 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2457
2458         Reviewed by Timothy Hatcher.
2459
2460         Web Inspector: enable developers extras within inspector layout tests.
2461
2462         https://bugs.webkit.org/show_bug.cgi?id=30014
2463
2464         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2465         (LayoutTestController::showWebInspector):
2466         (LayoutTestController::closeWebInspector):
2467         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2468         (LayoutTestController::showWebInspector):
2469         (LayoutTestController::closeWebInspector):
2470
2471 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2472
2473         Reviewed by Jan Alonzo.
2474
2475         GtkLauncher is using a deprecated signal
2476         https://bugs.webkit.org/show_bug.cgi?id=30364
2477
2478         Modified GtkLauncher to use notify::title signal instead of
2479         deprecated title-changed signal
2480
2481         * GtkLauncher/main.c:
2482         (notify_title_cb):
2483         (create_browser):
2484
2485 2009-10-14  Brady Eidson  <beidson@apple.com>
2486
2487         Reviewed by Sam Weinig.
2488
2489         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2490         1 - Disables WebHistory
2491         2 - Doesn't make sense in that context anyway.
2492
2493         * DumpRenderTree/win/DumpRenderTree.cpp:
2494         (createWebViewAndOffscreenWindow):
2495
2496 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2497
2498         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2499         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2500
2501         * wx/build/settings.py:
2502         * wx/install-unix-extras:
2503
2504 2009-10-14  Brady Eidson  <beidson@apple.com>
2505
2506         Reviewed by Sam Weinig.
2507
2508         WebKit Win API should provide a delegate interface for global history.
2509         https://bugs.webkit.org/show_bug.cgi?id=29905
2510
2511         * DumpRenderTree/LayoutTestController.cpp:
2512         (LayoutTestController::LayoutTestController):
2513         * DumpRenderTree/LayoutTestController.h:
2514         (LayoutTestController::dumpHistoryDelegateCallbacks):
2515         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2516                 
2517         * DumpRenderTree/win/DumpRenderTree.cpp:
2518         (shouldLogHistoryDelegates):
2519         (runTest):
2520         (createWebViewAndOffscreenWindow):
2521         (main):
2522         * DumpRenderTree/win/DumpRenderTree.vcproj:
2523         
2524         Add the IWebHistoryDelegate to DRT Windows:
2525         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2526         (wstringFromBSTR):
2527         (HistoryDelegate::HistoryDelegate):
2528         (HistoryDelegate::~HistoryDelegate):
2529         (HistoryDelegate::QueryInterface):
2530         (HistoryDelegate::AddRef):
2531         (HistoryDelegate::Release):
2532         (HistoryDelegate::didNavigateWithNavigationData):
2533         (HistoryDelegate::didPerformClientRedirectFromURL):
2534         (HistoryDelegate::didPerformServerRedirectFromURL):
2535         (HistoryDelegate::updateHistoryTitle):
2536         (HistoryDelegate::populateVisitedLinksForWebView):
2537         * DumpRenderTree/win/HistoryDelegate.h: Added.
2538
2539         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2540         (LayoutTestController::removeAllVisitedLinks):
2541
2542 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2543
2544         Reviewed by Simon Hausmann.
2545
2546         [Qt] Implement support for setPOSIXLocale on Qt.
2547         https://bugs.webkit.org/show_bug.cgi?id=30268 
2548  
2549         * DumpRenderTree/qt/DumpRenderTree.cpp:
2550         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2551         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2552         (LayoutTestController::setPOSIXLocale):
2553         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2554
2555 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2556
2557         Unreviewed, adding myself to reviewers list.
2558
2559         * Scripts/modules/committers.py:
2560
2561 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2562
2563         Reviewed by Mark Rowe.
2564
2565         Fix null assignment so root tests work again.
2566
2567         * Scripts/webkitdirs.pm:
2568
2569 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2570
2571         Reviewed by Simon Hausmann.
2572
2573         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
2574         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
2575         This is done in preparation of implementing missing features in DRT.
2576         No functionality changes made yet.
2577
2578         * DumpRenderTree/qt/DumpRenderTree.cpp:
2579         * DumpRenderTree/qt/DumpRenderTree.pro:
2580         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
2581         (EventSender::EventSender):
2582         (EventSender::mouseDown):
2583         (EventSender::mouseUp):
2584         (EventSender::mouseMoveTo):
2585         (EventSender::leapForward):
2586         (EventSender::keyDown):
2587         (EventSender::contextClick):
2588         (EventSender::scheduleAsynchronousClick):
2589         (EventSender::frameUnderMouse):
2590         * DumpRenderTree/qt/EventSenderQt.h: Added.
2591         (EventSender::clearKillRing):
2592         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
2593         (LayoutTestController::LayoutTestController):
2594         (LayoutTestController::reset):
2595         (LayoutTestController::processWork):
2596         (LayoutTestController::maybeDump):
2597         (LayoutTestController::waitUntilDone):
2598         (LayoutTestController::notifyDone):
2599         (LayoutTestController::windowCount):
2600         (LayoutTestController::clearBackForwardList):
2601         (LayoutTestController::dumpEditingCallbacks):
2602         (LayoutTestController::dumpResourceLoadCallbacks):
2603         (LayoutTestController::queueBackNavigation):
2604         (LayoutTestController::queueForwardNavigation):
2605         (LayoutTestController::queueLoad):
2606         (LayoutTestController::queueReload):
2607         (LayoutTestController::queueScript):
2608         (LayoutTestController::provisionalLoad):
2609         (LayoutTestController::timerEvent):
2610         (LayoutTestController::encodeHostName):
2611         (LayoutTestController::decodeHostName):
2612         (LayoutTestController::setJavaScriptProfilingEnabled):
2613         (LayoutTestController::setFixedContentsSize):
2614         (LayoutTestController::setPrivateBrowsingEnabled):
2615         (LayoutTestController::setPopupBlockingEnabled):
2616         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2617         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2618         (LayoutTestController::numberOfActiveAnimations):
2619         (LayoutTestController::disableImageLoading):
2620         (LayoutTestController::dispatchPendingLoadRequests):
2621         (LayoutTestController::setDatabaseQuota):
2622         (LayoutTestController::clearAllDatabases):
2623         (LayoutTestController::whiteListAccessFromOrigin):
2624         (LayoutTestController::waitForPolicyDelegate):
2625         (LayoutTestController::overridePreference):
2626         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
2627         (LayoutTestController::isLoading):
2628         (LayoutTestController::setLoading):
2629         (LayoutTestController::shouldDumpAsText):
2630         (LayoutTestController::shouldDumpBackForwardList):
2631         (LayoutTestController::shouldDumpChildrenAsText):
2632         (LayoutTestController::shouldDumpDatabaseCallbacks):
2633         (LayoutTestController::shouldDumpStatusCallbacks):
2634         (LayoutTestController::shouldWaitUntilDone):
2635         (LayoutTestController::canOpenWindows):
2636         (LayoutTestController::shouldDumpTitleChanges):
2637         (LayoutTestController::waitForPolicy):
2638         (LayoutTestController::dumpAsText):
2639         (LayoutTestController::dumpChildFramesAsText):
2640         (LayoutTestController::dumpDatabaseCallbacks):
2641         (LayoutTestController::dumpStatusCallbacks):
2642         (LayoutTestController::setCanOpenWindows):
2643         (LayoutTestController::dumpBackForwardList):
2644         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2645         (LayoutTestController::display):
2646         (LayoutTestController::dumpTitleChanges):
2647         (LayoutTestController::dumpSelectionRect):
2648         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
2649         (TextInputController::TextInputController):
2650         (TextInputController::doCommand):
2651         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
2652         * DumpRenderTree/qt/WorkQueue.cpp:
2653         * DumpRenderTree/qt/WorkQueue.h:
2654         * DumpRenderTree/qt/WorkQueueItem.h:
2655         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
2656         (findFrameNamed):
2657         (LoadItem::invoke):
2658         (ReloadItem::invoke):
2659         (ScriptItem::invoke):
2660         (BackForwardItem::invoke):
2661         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
2662         * DumpRenderTree/qt/jsobjects.h:
2663
2664 2009-10-13  Dmitry Titov  <dimich@chromium.org>
2665
2666         Not reviewed, adding myself to the list of reviewers.
2667
2668         * Scripts/modules/committers.py:
2669
2670 2009-10-13  Anders Carlsson  <andersca@apple.com>
2671
2672         Reviewed by Sam Weinig.
2673
2674         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
2675
2676         Make the private browsing mode testable by the test plug-in.
2677         
2678         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2679         (pluginGetProperty):
2680         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2681         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2682         (NPP_New):
2683         (NPP_SetValue):
2684
2685 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
2686
2687         No review, just adding self to the list of reviewers.
2688
2689         * Scripts/modules/committers.py:
2690
2691 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
2692
2693         Reviewed by Adam Roben.
2694
2695         Web Inspector: Use proper web view in inspector layout
2696         tests for windows.
2697
2698         https://bugs.webkit.org/show_bug.cgi?id=30298
2699
2700         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2701         (LayoutTestController::showWebInspector):
2702         (LayoutTestController::closeWebInspector):
2703         (LayoutTestController::evaluateInWebInspector):
2704
2705 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
2706
2707         Reviewed by Sam Weinig.
2708
2709         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
2710         https://bugs.webkit.org/show_bug.cgi?id=29841
2711
2712         * DumpRenderTree/mac/DumpRenderTree.mm:
2713         (resetDefaultsToConsistentValues):
2714         * DumpRenderTree/win/DumpRenderTree.cpp:
2715         (resetDefaultsToConsistentValues):
2716
2717 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
2718
2719         Reviewed by Dimitri Glazkov.
2720
2721         Chromium Port - Windows
2722         https://bugs.webkit.org/show_bug.cgi?id=29969
2723
2724         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
2725         * Scripts/webkitdirs.pm:
2726
2727 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
2728
2729         Reviewed by Darin Adler.
2730
2731         jsc scripts cleanup and Qt/GTK fix
2732         https://bugs.webkit.org/show_bug.cgi?id=30288
2733
2734         Duplicated jscPath() moved to webkitdirs.pm.
2735         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
2736         Configuration added (release/debug) to path for Qt-port on Windows.
2737
2738         * Scripts/run-javascriptcore-tests:
2739         * Scripts/run-jsc:
2740         * Scripts/run-sunspider:
2741         * Scripts/sunspider-compare-results:
2742         * Scripts/webkitdirs.pm:
2743
2744 2009-10-11  Adam Barth  <abarth@webkit.org>
2745
2746         Unreviewed.  Add Collin to committers.py.
2747
2748         * Scripts/modules/committers.py:
2749
2750 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
2751
2752         wx build fix, add bindings to source/include dirs now that there are sources there.
2753
2754         * wx/build/settings.py:
2755
2756 2009-10-09  Mark Rowe  <mrowe@apple.com>
2757
2758         Reviewed by Brady Eidson.
2759
2760         Enable plug-in halting in DumpRenderTree.
2761
2762         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
2763         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
2764
2765         * DumpRenderTree/mac/DumpRenderTree.mm:
2766         (resetDefaultsToConsistentValues):
2767         * DumpRenderTree/mac/UIDelegate.mm:
2768         (-[UIDelegate webView:shouldHaltPlugin:]):
2769
2770 2009-10-08  Brady Eidson  <beidson@apple.com>
2771
2772         Reviewed by Dan Bernstein.
2773
2774         Ask the History Delegate to populate the visited links hash.
2775         <rdar://problem/7285293> and https://webkit.org/b/29904
2776
2777         Add the ability for LayoutTestController to clear all visited links.
2778         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
2779
2780         * DumpRenderTree/LayoutTestController.cpp:
2781         (LayoutTestController::LayoutTestController):
2782         (removeAllVisitedLinksCallback):
2783         (LayoutTestController::staticFunctions):
2784         * DumpRenderTree/LayoutTestController.h:
2785         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2786         (LayoutTestController::removeAllVisitedLinks):
2787
2788         * DumpRenderTree/mac/HistoryDelegate.mm:
2789         (-[HistoryDelegate populateVisitedLinksForWebView:]):
2790
2791         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2792         (LayoutTestController::removeAllVisitedLinks):
2793         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2794         (LayoutTestController::removeAllVisitedLinks):
2795         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2796         (LayoutTestController::removeAllVisitedLinks):
2797
2798
2799 2009-10-08  Daniel Bates  <dbates@webkit.org>
2800
2801         Reviewed by Adam Roben.
2802
2803         https://bugs.webkit.org/show_bug.cgi?id=30175
2804         
2805         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
2806         the OLE drag-and-drop return value like the function it emulates. Currently, 
2807         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
2808         whether the drag-and-drop operation was successful or was cancelled.
2809         
2810         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
2811         return value according to whether the drop operation was successful or not.
2812
2813         * DumpRenderTree/win/EventSender.cpp:
2814         (doMouseUp): Added parameter oleDragAndDropReturnValue.
2815         (replaySavedEvents): Ditto.
2816         * DumpRenderTree/win/EventSender.h:
2817         * DumpRenderTree/win/UIDelegate.cpp:
2818         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
2819
2820 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2821
2822         Reviewed by Xan Lopez.
2823
2824         [GTK] Added support for a parameter setting the button that was
2825         pressed in the mouseDown function.
2826         https://bugs.webkit.org/show_bug.cgi?id=30220
2827
2828         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2829
2830 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2831
2832         Reviewed by Xan Lopez.
2833
2834         [GTK] Added a line to the bottom of the expected result to match
2835         the output of the test.
2836         https://bugs.webkit.org/show_bug.cgi?id=30220
2837
2838         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
2839         expected.txt:
2840
2841 2009-10-08  Adam Roben  <aroben@apple.com>
2842
2843         Use QueryInterface to get IWebInspectorPrivate
2844
2845         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
2846         accessed in a more standard way
2847
2848         Reviewed by John Sullivan and Tim Hatcher.
2849
2850         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2851         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
2852         by calling IWebViewPrivate::inspector, then use QueryInterface to get
2853         to the IWebInspectorPrivate interface.
2854
2855 2009-10-07  Adam Roben  <aroben@apple.com>
2856
2857         Implement DRT support for origin whitelisting
2858
2859         Fixes <http://webkit.org/b/30185>.
2860
2861         Reviewed by Eric Seidel.
2862
2863         * DumpRenderTree/win/DumpRenderTree.cpp:
2864         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
2865         whitelist, to match Mac DRT.
2866         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2867         (LayoutTestController::whiteListAccessFromOrigin): Call through to
2868         IWebViewPrivate::whiteListAccessFromOrigin.
2869
2870 2009-10-07  Brady Eidson  <beidson@apple.com>
2871
2872         Reviewed by Darin Adler.
2873
2874         Send title changes to the global history delegate.
2875         <rdar://problem/7285293> and https://webkit.org/b/29904
2876
2877         * DumpRenderTree/mac/HistoryDelegate.mm:
2878         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
2879
2880 2009-10-07  Adam Barth  <abarth@webkit.org>
2881
2882         Unreviewed.  Remove some folks from committers.py who were listed on
2883         the WebKit Team wiki page but who weren't actually listed as commit+.
2884         At some point, we should coorelate this list with the committers
2885         mailing list.
2886
2887         * Scripts/modules/committers.py:
2888
2889 2009-10-07  Adam Barth  <abarth@webkit.org>
2890
2891         Unreviewed.  Import a bunch of committers from the WebKit Team page on
2892         the wiki into committers.py.
2893
2894         * Scripts/modules/committers.py:
2895
2896 2009-10-07  Adam Barth  <abarth@webkit.org>
2897
2898         Unreviewed.  Added Aaron Boodman to committers.py.
2899
2900         * Scripts/modules/committers.py:
2901
2902 2009-10-07  Evan Martin  <evan@chromium.org>
2903
2904         Reviewed by Darin Adler.
2905
2906         Add API to LayoutTestController for re/setting the system locale.
2907         https://bugs.webkit.org/show_bug.cgi?id=18994
2908
2909         * DumpRenderTree/LayoutTestController.cpp:
2910         (setLocaleCallback):
2911         (LayoutTestController::staticFunctions):
2912         (LayoutTestController::setLocale):
2913         * DumpRenderTree/LayoutTestController.h:
2914
2915 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
2916
2917         Reviewed by Jan Alonzo.
2918
2919         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
2920         https://bugs.webkit.org/show_bug.cgi?id=29689
2921
2922         Build fix by adding -lfontconfig for DumpRenderTree.
2923
2924         * GNUmakefile.am:
2925
2926 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2927
2928         Reviewed by Simon Hausmann.
2929
2930         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
2931
2932         * Scripts/run-webkit-tests:
2933
2934 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2935
2936         Reviewed by Gustavo Noronha.
2937
2938         "delete" in EventSender is the backspace key, not the delete one.
2939
2940         * DumpRenderTree/gtk/EventSender.cpp:
2941         (keyDownCallback):
2942
2943 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2944
2945         Reviewed by Gustavo Noronha.
2946
2947         getChildrenWithRange expects as last parameter the end index, not
2948         the length of the range. Correct this and clarify the variable
2949         names to reflect how the code works.
2950
2951         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2952         (AccessibilityUIElement::getChildrenWithRange):
2953         (AccessibilityUIElement::getChildAtIndex):
2954
2955 2009-10-06  Mark Rowe  <mrowe@apple.com>
2956
2957         Reviewed by Simon Fraser.
2958
2959         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
2960
2961         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
2962         the fact we have already changed the working directory to the top of the open source tree.
2963
2964 2009-10-06  Julie Parent  <jparent@chromium.org>
2965
2966         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
2967         rather than my committer email.
2968
2969         * Scripts/modules/committers.py:
2970
2971 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2972
2973         Reviewed by Eric Seidel.
2974
2975         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
2976
2977         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
2978         it after each layout test as it should do, making the DRT dump additional output
2979         for all of the subsequent layout tests.
2980
2981         * DumpRenderTree/qt/jsobjects.cpp:
2982         (LayoutTestController::reset):
2983
2984 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2985
2986         Reviewed by Simon Hausmann.
2987
2988         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
2989         fast/dom/assign-to-window-status.html test, which is passing as a result.
2990
2991         https://bugs.webkit.org/show_bug.cgi?id=30127
2992
2993         * DumpRenderTree/qt/DumpRenderTree.cpp:
2994         (WebCore::DumpRenderTree::DumpRenderTree):
2995         (WebCore::DumpRenderTree::statusBarMessage):
2996         * DumpRenderTree/qt/DumpRenderTree.h:
2997         * DumpRenderTree/qt/jsobjects.h:
2998         (LayoutTestController::shouldDumpStatusCallbacks):
2999         (LayoutTestController::dumpStatusCallbacks):
3000
3001 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3002
3003         Reviewed by Simon Hausmann.
3004
3005         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3006         ignores the argument indicating which mouse button to trigger.
3007         https://bugs.webkit.org/show_bug.cgi?id=30048
3008
3009         This affects the fast/events/mouse-click-events.html layout test.
3010
3011         * DumpRenderTree/qt/jsobjects.cpp:
3012         (EventSender::mouseDown):
3013         (EventSender::mouseUp):
3014         * DumpRenderTree/qt/jsobjects.h:
3015
3016 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3017
3018         Reviewed by Simon Hausmann.
3019
3020         [Qt] Fix the EventSender::keyDown() implementation
3021         https://bugs.webkit.org/show_bug.cgi?id=30043
3022
3023         It should post both a key press event and a key release event,
3024         just like other ports do.
3025
3026         * DumpRenderTree/qt/jsobjects.cpp:
3027         (EventSender::keyDown):
3028
3029 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3030
3031         wx build fix. Add jpeg to the list of libs to link against.
3032
3033         * wx/build/settings.py:
3034
3035 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3036
3037         Reviewed by Simon Hausmann.
3038
3039         [Qt] EventSender::keyDown() cannot send function-key events.
3040         https://bugs.webkit.org/show_bug.cgi?id=30044
3041
3042         This affects the fast/events/keydown-function-keys.html layout test.
3043
3044         * DumpRenderTree/qt/jsobjects.cpp:
3045         (EventSender::keyDown):
3046
3047 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3048
3049         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3050         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3051
3052         * wx/build/settings.py:
3053         * wx/build/wxpresets.py:
3054
3055 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3056
3057         Reviewed by Timothy Hatcher.
3058
3059         Web Inspector: add testing harness for Web Inspector.
3060
3061         https://bugs.webkit.org/show_bug.cgi?id=30010
3062
3063         * DumpRenderTree/LayoutTestController.cpp:
3064         (showWebInspectorCallback):
3065         (closeWebInspectorCallback):
3066         (evaluateInWebInspectorCallback):
3067         (LayoutTestController::staticFunctions):
3068         * DumpRenderTree/LayoutTestController.h:
3069         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3070         (LayoutTestController::showWebInspector):
3071         (LayoutTestController::closeWebInspector):
3072         (LayoutTestController::evaluateInWebInspector):
3073         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3074         (LayoutTestController::showWebInspector):
3075         (LayoutTestController::closeWebInspector):
3076         (LayoutTestController::evaluateInWebInspector):
3077         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3078         (LayoutTestController::showWebInspector):
3079         (LayoutTestController::closeWebInspector):
3080         (LayoutTestController::evaluateInWebInspector):
3081         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3082         (LayoutTestController::showWebInspector):
3083         (LayoutTestController::closeWebInspector):
3084         (LayoutTestController::evaluateInWebInspector):
3085
3086 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3087
3088         Reviewed by Ariyha Hidayat.
3089
3090         Pass arguments to system() as a string instead of array
3091
3092         When passed as an array entries with a space fail to translate
3093         to two arguments to the child process, so instead of manually
3094         splitting all the entries in @buildArgs we pass the whole thing
3095         as a string instead.
3096
3097         * Scripts/webkitdirs.pm:
3098
3099 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3100
3101         Reviewed by David Levin.
3102
3103         check-webkit-style misses whitespace errors for operators:
3104         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3105         https://bugs.webkit.org/show_bug.cgi?id=30021
3106
3107         * Scripts/modules/cpp_style.py:
3108         Added the operators mentioned above to the same list as == and !=.
3109
3110 2009-10-02  Julie Parent  <jparent@chromium.org>
3111
3112         Unreviewed.
3113
3114         Adding myself and Ojan Vafai as committers, because we are committers.
3115
3116         * Scripts/modules/committers.py:
3117
3118 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3119
3120         Reviewed by Adam Roben.
3121
3122         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3123         this will help the patch merging process when TryBots are used.
3124
3125         * Scripts/svn-create-patch:
3126
3127 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3128
3129         Reviewed by Simon Hausmann.
3130
3131         [Qt] Implement layoutTestController.overridePreference().
3132         https://bugs.webkit.org/show_bug.cgi?id=29970
3133
3134         * DumpRenderTree/qt/DumpRenderTree.cpp:
3135         (WebCore::WebPage::WebPage):
3136         (WebCore::WebPage::resetSettings):
3137         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3138         * DumpRenderTree/qt/jsobjects.cpp:
3139         (LayoutTestController::reset):
3140         (LayoutTestController::setPrivateBrowsingEnabled):
3141         (LayoutTestController::setPopupBlockingEnabled):
3142         (LayoutTestController::overridePreference):
3143         * DumpRenderTree/qt/jsobjects.h:
3144
3145 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3146
3147         Reviewed by Oliver Hunt.
3148
3149         Turn on ENABLE_3D_CANVAS in TOT
3150         https://bugs.webkit.org/show_bug.cgi?id=29906
3151
3152         * Scripts/build-webkit:
3153
3154 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3155
3156         Rubberstamped by Simon Hausmann.
3157
3158         Enable HTTP tests for Qt
3159
3160         * Scripts/run-webkit-tests:
3161
3162 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3163
3164         Reviewed by Dimitri Glazkov.
3165
3166         build-webkit --chromium now also works on cygwin.
3167
3168         https://bugs.webkit.org/show_bug.cgi?id=29973
3169
3170         * Scripts/webkitdirs.pm:
3171
3172 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3173
3174         Reviewed by Simon Hausmann.
3175
3176         [Qt] Don't use TCmalloc in DumpRenderTree
3177         https://bugs.webkit.org/show_bug.cgi?id=27029
3178
3179         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3180
3181         * DumpRenderTree/qt/DumpRenderTree.pro:
3182
3183 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3184
3185         Reviewed by Simon Hausmann.
3186
3187         [Qt] Implement eventSender.scheduleAsynchronousClick().
3188
3189         https://bugs.webkit.org/show_bug.cgi?id=29931
3190
3191         * DumpRenderTree/qt/jsobjects.cpp:
3192         (EventSender::scheduleAsynchronousClick):
3193         * DumpRenderTree/qt/jsobjects.h:
3194
3195 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3196
3197         Reviewed by Simon Hausmann.
3198
3199         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3200         fast/events/open-window-from-another-frame.html from the Skipped list.
3201
3202         https://bugs.webkit.org/show_bug.cgi?id=29930
3203
3204         * DumpRenderTree/qt/jsobjects.cpp:
3205         (LayoutTestController::setPopupBlockingEnabled):
3206         * DumpRenderTree/qt/jsobjects.h:
3207
3208 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3209
3210         Unreviewed.
3211
3212         Added myself to the list of committers.
3213
3214         * Scripts/modules/committers.py:
3215
3216 2009-09-30  Eric Seidel  <eric@webkit.org>
3217
3218         No review, just adding Geoff to the list of reviewers.
3219
3220         * Scripts/modules/committers.py:
3221
3222 2009-09-30  Dan Bernstein  <mitz@apple.com>
3223
3224         Reviewed by Sam Weinig.
3225
3226         Added the WebKit Layout Tests fonts that are referenced in
3227         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3228
3229         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3230         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3231
3232 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3233
3234         Reviewed by David Kilzer.
3235
3236         Make sunspider scripts work on Windows platform.
3237         https://bugs.webkit.org/show_bug.cgi?id=29656
3238
3239         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3240         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3241         * Scripts/webkitdirs.pm: currentPerlPath() added.
3242
3243 2009-09-29  Brady Eidson  <beidson@apple.com>
3244
3245         Rubberstamped by Dan Bernstein.
3246
3247         Fix license and some sorting in new files.
3248
3249         * DumpRenderTree/mac/HistoryDelegate.h:
3250         * DumpRenderTree/mac/HistoryDelegate.mm:
3251
3252 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3253
3254         Reviewed by David Kilzer.
3255
3256         Fixed how error codes are handled.
3257         https://bugs.webkit.org/show_bug.cgi?id=29898
3258
3259         * Scripts/update-webkit:
3260         * Scripts/update-webkit-chromium:
3261
3262 2009-09-29  Brady Eidson  <beidson@apple.com>
3263
3264         Reviewed by John Sullivan.
3265
3266         Updated way-out-of-date sorting throughout the dump methods/flags.
3267
3268         * DumpRenderTree/LayoutTestController.cpp:
3269         (LayoutTestController::LayoutTestController):
3270         (dumpAsPDFCallback):
3271         (dumpAsTextCallback):
3272         (dumpFrameLoadCallbacksCallback):
3273         (dumpResourceLoadCallbacksCallback):
3274         (LayoutTestController::staticFunctions):
3275
3276         * DumpRenderTree/LayoutTestController.h:
3277         (LayoutTestController::dumpAsText):
3278         (LayoutTestController::setDumpAsText):
3279         (LayoutTestController::dumpFrameLoadCallbacks):
3280         (LayoutTestController::setDumpFrameLoadCallbacks):
3281         (LayoutTestController::dumpSelectionRect):
3282         (LayoutTestController::setDumpSelectionRect):
3283         (LayoutTestController::dumpSourceAsWebArchive):
3284         (LayoutTestController::setDumpSourceAsWebArchive):
3285         (LayoutTestController::dumpStatusCallbacks):
3286         (LayoutTestController::setDumpStatusCallbacks):
3287         (LayoutTestController::dumpTitleChanges):
3288         (LayoutTestController::setDumpTitleChanges):
3289         (LayoutTestController::dumpWillCacheResponse):
3290         (LayoutTestController::setDumpWillCacheResponse):
3291
3292 2009-09-29  Brady Eidson  <beidson@apple.com>
3293
3294         Reviewed by John Sullivan.
3295
3296         WebKit Mac API should provide a delegate interface for global history.
3297         <rdar://problem/7042773> and https://webkit.org/b/29904
3298
3299         Adding the dumping of global history delegate callbacks.
3300
3301         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3302
3303         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3304         * DumpRenderTree/mac/DumpRenderTree.mm:
3305         (createWebViewAndOffscreenWindow):
3306         (allocateGlobalControllers):
3307         (shouldLogFrameLoadDelegates):
3308         (shouldLogHistoryDelegates):
3309         (runTest):
3310
3311         Dump history delegate callbacks:
3312         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3313         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3314         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3315         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3316         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3317
3318 2009-09-29  Daniel Bates  <dbates@webkit.org>
3319
3320         Reviewed by Adam Roben.
3321
3322         https://bugs.webkit.org/show_bug.cgi?id=28902
3323         
3324         Fixes an issue where the drop effect returned by Window Dump Render Tree 
3325         was always DROPEFFECT_NONE (since it was hard coded to do so).
3326         
3327         This patch corrects this issue by determining the actual drop effect 
3328         performed by the corresponding drag-and-drop operation so that we can 
3329         return it.
3330
3331         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3332         (DraggingInfo::DraggingInfo):
3333         (DraggingInfo::performedDropEffect): Added method.
3334         (DraggingInfo::setPerformedDropEffect): Added method.
3335         * DumpRenderTree/win/EventSender.cpp:
3336         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3337         Moved delete draggingInfo to UIDelegate::doDragDrop.
3338         * DumpRenderTree/win/UIDelegate.cpp:
3339         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3340
3341 2009-09-29  Dan Bernstein  <mitz@apple.com>
3342
3343         Reviewed by Adam Roben.
3344
3345         Remove copying of unnecessary or nonexistent files from the ImageDiff
3346         post-build event.
3347
3348         * DumpRenderTree/win/ImageDiff.vcproj:
3349
3350 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3351
3352         Reviewed by David Kilzer.
3353
3354         [Qt] Make build-webkit script work on Windows
3355         https://bugs.webkit.org/show_bug.cgi?id=29802
3356
3357         * Scripts/run-webkit-tests:
3358         * Scripts/webkitdirs.pm:
3359          - Removed unnecessary -p switch for mkdir on Windows.
3360          - Use canonical path, which uses slashes or backslashes depends on platform.
3361          - isWindows() only test for Windows and not for Cyqwin.
3362
3363 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3364
3365         Reviewed by Simon Hausmann.
3366
3367         Fix time measurement in build-webkit after refactoring done in r48853.
3368
3369         * Scripts/build-webkit:
3370
3371 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3372
3373         Reviewed by Tor Arne Vestbø.
3374
3375         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
3376         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
3377
3378         * DumpRenderTree/qt/DumpRenderTree.cpp:
3379         (WebCore::WebPage::WebPage):
3380
3381 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
3382
3383         Reviewed by Simon Hausmann.
3384
3385         [Qt] Implement eventSender.contextClick().
3386         https://bugs.webkit.org/show_bug.cgi?id=29821
3387
3388         * DumpRenderTree/qt/jsobjects.cpp:
3389         (EventSender::contextClick):
3390         * DumpRenderTree/qt/jsobjects.h:
3391
3392 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3393
3394         Reviewed by Eric Seidel.
3395
3396         Add experimentalWebSocketsEnabled in WebPreferences.
3397         https://bugs.webkit.org/show_bug.cgi?id=28941
3398
3399         * DumpRenderTree/mac/DumpRenderTree.mm:
3400         (resetDefaultsToConsistentValues):
3401         * DumpRenderTree/win/DumpRenderTree.cpp:
3402         (resetDefaultsToConsistentValues):
3403
3404 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
3405
3406         Reviewed by David Kilzer.
3407
3408         Integrated chromium port building into webkit tools update-webkit and
3409         build-webkit.
3410
3411         https://bugs.webkit.org/show_bug.cgi?id=29749
3412
3413         * Scripts/build-webkit: When --chromium is specified, will build
3414           the chromium port (currently only Mac is supported).
3415         * Scripts/update-webkit: When --chromium is specified, delegates to
3416           update-webkit-chromium.
3417         * Scripts/webkitdirs.pm: Added chromium specific defs.
3418         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
3419           chromium port's dependencies and update its project files.
3420
3421 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3422
3423         Unreviewed.
3424
3425         Add myself to list of committers.
3426
3427         * Scripts/modules/committers.py:
3428
3429 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3430
3431         Reviewed by Darin Adler.
3432
3433         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
3434         https://bugs.webkit.org/show_bug.cgi?id=29771
3435
3436         * Scripts/run-webkit-tests:
3437
3438 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3439
3440         Reviewed by Simon Hausmann.
3441
3442         [Qt] Implement layoutTestController.waitForPolicyDelegate.
3443         https://bugs.webkit.org/show_bug.cgi?id=25037
3444
3445         * DumpRenderTree/qt/DumpRenderTree.cpp:
3446         (WebCore::WebPage::acceptNavigationRequest):
3447         * DumpRenderTree/qt/DumpRenderTree.pro:
3448         * DumpRenderTree/qt/jsobjects.cpp:
3449         (LayoutTestController::reset):
3450         (LayoutTestController::notifyDone):
3451         (LayoutTestController::waitForPolicyDelegate):
3452         * DumpRenderTree/qt/jsobjects.h:
3453         (LayoutTestController::waitForPolicy):
3454
3455 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3456
3457         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
3458
3459         Reviewed by Eric Seidel.
3460
3461         The -o|--open switch uses the open(1) command on Mac OS X to
3462         open the bug URL in the default web browser.  If there are
3463         similar mechanisms on other platforms, they may be added later.
3464
3465         * Scripts/mark-bug-fixed:
3466         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
3467         options.
3468         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
3469         code into main() and extracted prompting code into
3470         _prompt_user_for_correctness().
3471         (MarkBugFixed._open_bug_in_web_browser): Added.
3472         (MarkBugFixed._prompt_user_for_correctness): Added.
3473         (MarkBugFixed.main): Added logging code from
3474         _determine_bug_id_and_svn_revision().  Added code to call
3475         _open_bug_in_web_browser() if the switch is set.  Added code to
3476         call _prompt_user_for_correctness() when needed.
3477         * Scripts/modules/bugzilla.py:
3478         (Bugzilla.short_bug_url_for_bug_id): Added.
3479
3480 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3481
3482         svn-unapply and svn-apply don't work when used outside multiple svn working directories
3483
3484         <http://webkit.org/b/29744>
3485         <rdar://problem/7252905>
3486
3487         Reviewed by Eric Seidel.
3488
3489         Some users have a workflow where svn-create-patch, svn-apply and
3490         svn-unapply are used outside of multiple svn working
3491         directories.  Instead of aborting the scripts in these cases,
3492         print a warning and assume that Subversion is being used.
3493
3494         * Scripts/VCSUtils.pm:
3495         (determineVCSRoot): Call warn() instead of die() if both isGit()
3496         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
3497         to enforce the assumption about Subversion, then return
3498         determineSVNRoot().
3499         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
3500         VCSUtils.pm.  They both already cache their values and checking
3501         here is redundant since determineVCSRoot() is called later.
3502
3503 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
3504
3505         Reviewed by Gustavo Noronha.
3506
3507         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3508         https://bugs.webkit.org/show_bug.cgi?id=29689
3509
3510         Load test fonts through FontConfig before each test.
3511         This ensures a more proper rendering of the tests.
3512
3513         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3514         (initializeFonts):
3515         (runTest):
3516         (main):
3517         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
3518         * GNUmakefile.am:
3519
3520 2009-09-25  David Kilzer  <ddkilzer@apple.com>
3521
3522         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
3523
3524         Reviewed by Eric Seidel.
3525
3526         * Scripts/mark-bug-fixed:
3527         (MarkBugFixed.__init__): Added -u|--update-only switch to list
3528         of parse options.
3529         (MarkBugFixed.main): When -u|--update-only is specified, add a
3530         comment to the bug without marking it Resolved/Fixed.
3531
3532 2009-09-25  Darin Adler  <darin@apple.com>
3533
3534         Reviewed by Geoffrey Garen.
3535
3536         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
3537         out, just as we do for the resources directory.
3538
3539 2009-09-25  Adam Barth  <abarth@webkit.org>
3540
3541         Unreviewed.  Added Tony to committers.py because he's a
3542         committer now.
3543
3544         * Scripts/modules/committers.py:
3545
3546 2009-09-25  Eric Seidel  <eric@webkit.org>
3547
3548         Reviewed by Simon Fraser.
3549
3550         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
3551         https://bugs.webkit.org/show_bug.cgi?id=28624
3552
3553         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
3554
3555         * DumpRenderTree/mac/DumpRenderTree.mm:
3556         (resetDefaultsToConsistentValues):
3557
3558 2009-09-25  Eric Seidel  <eric@webkit.org>
3559
3560         Reviewed by Adam Barth.
3561
3562         commit-queue should auto-retry patches which fail to commit due to out of date files
3563         https://bugs.webkit.org/show_bug.cgi?id=28316
3564
3565         * Scripts/bugzilla-tool:
3566          - Handle new CheckoutNeedsUpdate exception.
3567         * Scripts/modules/logging_unittest.py:
3568          - Call the ScriptError constructor correctly (this test had regressed).
3569         * Scripts/modules/scm.py:
3570          - Added the ability to define custom error handlers for run_command
3571            and added a commit_error_handler which throws CheckoutNeedsUpdate
3572            instead of ScriptError.
3573          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
3574         * Scripts/modules/scm_unittest.py:
3575          - Added tests of new error handlers.
3576
3577 2009-09-25  Eric Seidel  <eric@webkit.org>
3578
3579         Reviewed by Adam Barth.
3580
3581         commit-queue should give better feedback when failing a patch
3582         https://bugs.webkit.org/show_bug.cgi?id=29316
3583
3584         * Scripts/bugzilla-tool:
3585          - Update ScriptError uses to the new constructor format.
3586          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
3587            so that we can print to both stdout as well as an output buffer for error reporting.
3588          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
3589          - Use e.message_with_output() when failing a patch (this is the real fix here).
3590            I also removed use of "This patch will require manual commit." as that's not always true.
3591          - Add missing word "bug" from log message.
3592         * Scripts/modules/scm.py:
3593          - Make ScriptError save a bunch more data so that error messages can be nicer.
3594          - Update ScriptError callers.
3595
3596 2009-09-24  John Gregg  <johnnyg@google.com>
3597
3598         Reviewed by Eric Seidel.
3599
3600         Enable switch for notifications (experimental) in Page Settings
3601         https://bugs.webkit.org/show_bug.cgi?id=28930
3602
3603         Now that desktop notifications are controlled by run-time switch,
3604         set that switch to true for DumpRenderTree.
3605
3606         * DumpRenderTree/mac/DumpRenderTree.mm:
3607         (resetDefaultsToConsistentValues):
3608         * DumpRenderTree/win/DumpRenderTree.cpp:
3609         (resetDefaultsToConsistentValues):
3610         * DumpRenderTree/win/UIDelegate.cpp:
3611         (UIDelegate::QueryInterface):
3612
3613 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
3614
3615         wx build fix. SnowLeopard fixes for Mac dependencies.
3616
3617         * wx/build/build_utils.py:
3618         * wx/build/settings.py:
3619         * wx/install-unix-extras:
3620
3621 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3622
3623         Reviewed by Oliver Hunt.
3624
3625         Add support for DRT to send mouse wheel events.
3626
3627         https://bugs.webkit.org/show_bug.cgi?id=29348
3628         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
3629
3630         * DumpRenderTree/gtk/EventSender.cpp:
3631         (mouseWheelToCallback):
3632
3633 2009-09-17  Eric Seidel  <eric@webkit.org>
3634
3635         Reviewed by David Levin.
3636
3637         commit-queue needs web-based status reporting
3638         https://bugs.webkit.org/show_bug.cgi?id=29307
3639
3640         Add a first-pass web-based status for the commit-queue.
3641         The bot is currently reachable at:
3642         http://webkit-commit-queue.appspot.com/
3643
3644         * CommitQueueStatus/app.yaml: Added.
3645          - Application description file required by App Engine.
3646         * CommitQueueStatus/filters/__init__.py: Added.
3647          - Required by python to treat 'filters' as a module.
3648         * CommitQueueStatus/filters/webkit_extras.py: Added.
3649          - Support for turning 'bug 123' and 'patch 123' into links.
3650            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
3651         * CommitQueueStatus/index.html: Added.
3652         * CommitQueueStatus/index.yaml: Added.
3653          - Some auto-generated file from app engine.
3654         * CommitQueueStatus/queue_status.py: Added.
3655          - The core logic of this bot.  We could eventually split this file out into pieces.
3656         * CommitQueueStatus/stylesheets/main.css: Added.
3657          - Some basic lame-o CSS to make the page look less awful.
3658         * CommitQueueStatus/update_status.html: Added.
3659          - The form that the commit-queue (or a human) can use to update the status.
3660         * Scripts/bugzilla-tool:
3661          - Add some very basic update_status calls.
3662         * Scripts/modules/statusbot.py: Added.
3663          - Knows how to post to the CommitQueueStatus web application.
3664
3665 2009-09-24  David Kilzer  <ddkilzer@apple.com>
3666
3667         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
3668
3669         Reviewed by Adam Roben.
3670
3671         * Scripts/mark-bug-fixed:
3672         (MarkBugFixed.__init__): Added -m|--comment switch to list of
3673         parse options.
3674         (MarkBugFixed.main): When specified, prepend comment from
3675         -m|--comment command-line switch to the bug comment.
3676
3677 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3678
3679         Reviewed by Jan Alonzo.
3680
3681         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
3682         https://bugs.webkit.org/show_bug.cgi?id=29693
3683
3684         Show the window, to be able to synthesize events correctly.
3685
3686         * Du