99fd754240b10508b7b772db5f756f57d0330eb2
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-02-04  Mark Rowe  <mrowe@apple.com>
2
3         Reviewed by Oliver Hunt.
4
5         Workaround for http://bugs.webkit.org/show_bug.cgi?id=16842
6         Bug 16842: Hang in DRT in leaks mode due to signal handler doing unsafe things
7
8         Don't install the signal handler unless we are running the pixel tests.
9         It is currently only used to restore the color profile, but by catching
10         signals we can trigger a deadlock in DRT while running leak tests.
11         The deadlock is tracked by http://bugs.webkit.org/show_bug.cgi?id=16842,
12         and a more complete fix will need to be developed to address this for
13         pixel tests as well.
14
15         * DumpRenderTree/mac/DumpRenderTree.mm:
16         (dumpRenderTree):
17
18 2008-02-04  Mark Rowe  <mrowe@apple.com>
19
20        Gtk qmake build fix.
21
22         * Scripts/webkitdirs.pm:  Fix perl's complaint about an odd number of elements in anonymous hash.
23
24 2008-02-04  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
25
26         Reviewed by Alp Toker and Mark Rowe.
27
28         http://bugs.webkit.org/show_bug.cgi?id=16618
29         [GTK] build-webkit and run-webkit-tests autootools support
30
31         * Scripts/build-webkit: added --database and --icon-database options
32         * Scripts/run-launcher:
33         * Scripts/run-webkit-tests:
34         * Scripts/webkitdirs.pm:
35
36 2008-02-04  Oliver Hunt  <oliver@apple.com>
37
38         Reviewed by Steve F.
39
40         Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT
41
42         Implement required DRT functionality to allow majority of Drag and Drop testcases to work.
43         Issues include:
44           * Uses Sleep() to implement leapForward reliably.
45           * 3 DND tests still fail for reasons that i have not yet determined
46           * Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain 
47
48         * DumpRenderTree/win/EventSender.cpp:
49         (leapForwardCallback):
50         (mouseDownCallback):
51         (doMouseUp):
52         (mouseUpCallback):
53         (doMouseMove):
54         (mouseMoveToCallback):
55           Minor updates to these functions to handle the different message queue structure.
56
57         (replaySavedEvents):
58           More complicated now.  Where possible we just use the old while-loop model of execution,
59           but when leapForward has been used we have to jump through some hoops and set up an 
60           inner event loop so that we can ensure messages get the correct time stamp.
61
62         * DumpRenderTree/win/UIDelegate.cpp:
63         (UIDelegate::doDragDrop):
64           Call replaySavedEvents directly to force synchronous handling of drag and drop.
65
66 2008-02-04  Rodney Dawes  <dobey@wayofthemonkey.com>
67
68         Reviewed by Alp Toker and Mark Rowe.
69
70         Fix http://bugs.webkit.org/show_bug.cgi?id=17175.
71         Bug 17175: Use of C++ compiler flags in CFLAGS
72
73         * GNUmakefile.am: Use global_cxxflags as well as global_cflags in CXXFLAGS.
74
75 2008-02-04  Darin Adler  <darin@apple.com>
76
77         Reviewed by Geoff.
78
79         * Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast
80         and svg subdirectories. Added some more exceptions for the benefit of the fast/dom
81         subdirectory.
82
83 2008-02-04  Adam Roben  <aroben@apple.com>
84
85         Windows Apple-only build fix
86
87         * DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include
88         directory.
89
90 2008-02-04  Alp Toker  <alp@atoker.com>
91
92         Rubber-stamped by Mark Rowe.
93
94         Remove all trailing whitespace in the GTK+ port and related
95         components.
96
97         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
98         * DumpRenderTree/gtk/GCControllerGtk.cpp:
99         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
100         * GNUmakefile.am:
101
102 2008-02-01  Eric Seidel  <eric@webkit.org>
103
104         Reviewed by Oliver.
105
106         Also search LayoutTests/svg for js-based tests.
107
108         * Scripts/make-js-test-wrappers:
109
110 2008-01-31  Alp Toker  <alp@atoker.com>
111
112         Rubber-stamped by Adam Roben.
113
114         http://bugs.webkit.org/show_bug.cgi?id=17006
115         [GTK] Header path should be webkit/webkit.h
116
117         Move the GTK+ API sources as needed and update the build systems.
118
119         * DumpRenderTree/gtk/DumpRenderTree.cpp:
120         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
121         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
122         * GNUmakefile.am:
123         * GtkLauncher/main.c:
124
125 2008-01-30  Stephanie  <slewis@apple.com>
126
127         Reviewed by Geoff.
128
129         Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
130
131         * Scripts/run-webkit-tests:
132
133 2008-01-30  Alexey Proskuryakov  <ap@webkit.org>
134
135         Reviewed by Adam Roben.
136
137         One more debug (external) fix.
138
139         * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
140         and Debug configurations. 
141
142 2008-01-29  Geoffrey Garen  <ggaren@apple.com>
143
144         Reviewed by Sam Weinig. Sam Weinig.
145         
146         Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
147         fails when run after fast/dom/Window/window-property-shadowing.html (16902)
148
149         Modified our policy delegates not to output window.name. Since a
150         previous test may have explicitly set window.name, we can't rely on its
151         implicit value in test results.
152
153         * DumpRenderTree/mac/PolicyDelegate.mm:
154         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
155
156         * DumpRenderTree/win/PolicyDelegate.cpp:
157         (PolicyDelegate::decidePolicyForNavigationAction):
158
159 2008-01-29  Mark Rowe  <mrowe@apple.com>
160
161         Reviewed by Tim Hatcher.
162
163         <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
164
165         * Scripts/build-webkit: Copy SQLite static library and headers into the build directory.
166
167 2008-01-29  David Kilzer  <ddkilzer@apple.com>
168
169         Refactor ChangeLog path code
170
171         Reviewed by Adam.
172
173         * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
174         duplicate code in another foreach() loop.
175
176 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
177
178         Reviewed by Darin.
179
180         <rdar://problem/5710692> All storage tests fail/crash
181
182         * DumpRenderTree/mac/UIDelegate.mm:
183         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an
184         arbitrary quota of 5 megabytes.
185
186         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
187         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
188         Removed unused (I think) code.
189         
190         * DumpRenderTree/win/UIDelegate.cpp:
191         (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported.
192         (UIDelegate::webViewPainted): A stub implementation.
193         (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
194         * DumpRenderTree/win/UIDelegate.h:
195
196 2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
197
198         GTK+ DRT build fix for breakage introduced in r29822.
199
200         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
201         (LayoutTestController::setPersistentUserStyleSheetLocation):
202         (LayoutTestController::clearPersistentUserStyleSheet):
203
204 2008-01-27  Dan Bernstein  <mitz@apple.com>
205
206         Reviewed by Darin Adler.
207
208         - add support for directory prologues and epilogues to run-webkit-tests
209         - allow setting a persistent user style sheet in DumpRenderTree
210         - activate the WebKit Layout Tests font in Windows DumpRenderTree
211
212         * DumpRenderTree/LayoutTestController.cpp:
213         (clearPersistentUserStyleSheetCallback): Added.
214         (setPersistentUserStyleSheetLocationCallback): Added.
215         (LayoutTestController::staticFunctions): Added.
216         clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
217         * DumpRenderTree/LayoutTestController.h:
218         * DumpRenderTree/mac/DumpRenderTree.mm:
219         (setPersistentUserStyleSheetLocation): Added.
220         (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
221         to the set of things this function resets. Now it either disables the
222         user style sheet or sets it to the persistent user style sheet and
223         enables it.
224         * DumpRenderTree/mac/DumpRenderTreeMac.h:
225         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
226         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
227         (LayoutTestController::clearPersistentUserStyleSheet): Added.
228         * DumpRenderTree/win/DumpRenderTree.cpp:
229         (setPersistentUserStyleSheetLocation): Added.
230         (initialize): Added the WebKit Layout Tests font to the set of fonts to
231         install.
232         (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
233         * DumpRenderTree/win/DumpRenderTreeWin.h:
234         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
235         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
236         (LayoutTestController::clearPersistentUserStyleSheet): Added.
237         * Scripts/run-webkit-tests: Changed to look for, and if found process in
238         DumpRenderTree, files named run-webkit-tests-prologue.html and
239         run-webkit-tests-epilogue.html in the resources subdirectory of any
240         test directory and platform test results directory. The prologues are
241         processed before the first test from the directory (and its
242         subdirectories) is run, and the epilogues are processed after the last
243         test from the directory is run. Platform-specific prologues and
244         epilogues are processed in order of specificity.
245
246 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
247
248         Reviewed by Mark Rowe.
249
250         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
251
252         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
253         (matching Mac DRT).
254         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
255
256 2008-01-24  Sam Weinig  <sam@webkit.org>
257
258         Reviewed by Ada Chan.
259
260         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
261
262         - Adds simplified UndoManager to windows DRT to allow testing the
263           undo/redo code paths in WebCore and WebKit.  This is a temporary
264           solution to an issue that should eventually be solved by having a
265           shared UndoManager in WebKit.
266
267         * DumpRenderTree/win/DumpRenderTree.cpp:
268         (runTest):
269         * DumpRenderTree/win/UIDelegate.cpp:
270         (DRTUndoObject::DRTUndoObject):
271         (DRTUndoObject::invoke):
272         (DRTUndoStack::~DRTUndoStack):
273         (DRTUndoStack::isEmpty):
274         (DRTUndoStack::clear):
275         (DRTUndoStack::push):
276         (DRTUndoStack::pop):
277         (DRTUndoManager::canRedo):
278         (DRTUndoManager::canUndo):
279         (DRTUndoManager::DRTUndoManager):
280         (DRTUndoManager::removeAllActions):
281         (DRTUndoManager::registerUndoWithTarget):
282         (DRTUndoManager::redo):
283         (DRTUndoManager::undo):
284         (UIDelegate::UIDelegate):
285         (UIDelegate::resetUndoManager):
286         (UIDelegate::registerUndoWithTarget):
287         (UIDelegate::removeAllActionsWithTarget):
288         (UIDelegate::setActionTitle):
289         (UIDelegate::undo):
290         (UIDelegate::redo):
291         (UIDelegate::canUndo):
292         (UIDelegate::canRedo):
293         * DumpRenderTree/win/UIDelegate.h:
294
295 2008-01-23  Adam Roben  <aroben@apple.com>
296
297         Allow directories containing ChangeLogs to be passed to
298         resolve-ChangeLogs
299
300         Reviewed by David Kilzer.
301
302         * Scripts/resolve-ChangeLogs:
303         (sub findChangeLog): Return a ChangeLog contained within the specified
304         directory if one exists.
305
306 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
307
308         <rdar://problem/5698732> Copyright strings should include 2008
309
310         Reviewed by Sam.
311
312         * Drosera/win/Drosera.vcproj/Drosera.rc:
313         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
314
315 2008-01-23  Alp Toker  <alp@atoker.com>
316
317         Rubber-stamped by Mark Rowe.
318
319         Remove whitespace after -I in automake include lists.
320
321         * GNUmakefile.am:
322
323 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
324
325         Reviewed by Lars Knoll <lars@trolltech.com>.
326
327         Reworked the JavaScriptCore Qt bindings:
328         
329         * Update JS DRT controller for Qt JS binding changes.
330         There were two functions that needed some changes
331         so that the layout tests would work, so this makes
332         a few tests pass again.
333         
334         * Bump the timeout for layout tests up to 11s.
335         At least some tests have an internal timeout of
336         10 seconds, so make the waitUntilDone approach
337         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
338         is one of these - now the failure message is more
339         accurate.
340         
341
342         * DumpRenderTree/qt/jsobjects.cpp:
343         (LayoutTestController::waitUntilDone):
344         * DumpRenderTree/qt/jsobjects.h:
345
346 2008-01-22  Anders Carlsson  <andersca@apple.com>
347
348         Reviewed by Darin and Adam.
349
350         <rdar://problem/5688975>
351         div element on microsoft site has wrong left offset.
352         
353         Add new method for testing the return vale of NPN_GetProperty.
354         
355         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
356         (pluginInvoke):
357
358 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
359
360         Reviewed by Adam Roben.
361
362         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
363
364         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
365
366 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
367
368         Reviewed by Alp Toker.
369
370         http://bugs.webkit.org/show_bug.cgi?id=16955
371         Get errors when cross-compile webkit-gtk
372
373         * GNUmakefile.am: Removed ICU_CFLAGS 
374
375 2008-01-21  Darin Adler  <darin@apple.com>
376
377         Reviewed by Mitz and Adam.
378
379         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
380         sorting speed by doing all sort criteria in a single pass instead of three sorts.
381
382 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
383
384         Reviewed by Holger.
385
386         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
387         
388         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
389         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
390         and make the return value depend on whether we successfully determined a focusable
391         node or not.
392         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
393         if we could not handle the focus chain ourselves.
394         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
395         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
396         used to control the situation of stepping out of the focus chain inside the page.
397         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
398         The layout tests expect this to be disabled but for the user it seems sensible to have it
399         on by default, hence the default in qwebsettings.cpp
400         
401
402         * DumpRenderTree/qt/DumpRenderTree.cpp:
403         (WebCore::WebPage::WebPage):
404
405 2008-01-19  Mark Rowe  <mrowe@apple.com>
406
407         Reviewed by Alp Toker.
408
409         Allow the --http flag to run-webkit-tests to override
410         the default behaviour of disabling HTTP tests for Qt,
411         Gtk and Wx.
412
413         * Scripts/run-webkit-tests:
414
415 2008-01-19  David Kilzer  <ddkilzer@apple.com>
416
417         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
418
419         Reviewed by Darin.
420
421         We now touch a check-for-global-initializers.timestamp file in
422         the TARGET_TEMP_DIR directory to determine when new object files
423         have been compiled and thus need to be checked.  If the timestamp
424         file doesn't exist, all object files will be checked.
425
426         Previously the modification time of the "executable" (the
427         framework binary, e.g., WebKit.framework/WebKit) was used, but
428         since this was the last file modified at the end of the compile
429         phase, no object files would ever get checked!
430
431         Also added JSCustomSQLTransactionCallback.o to the list of files
432         since it has static initializers in Debug builds of WebCore.
433
434         * Scripts/check-for-global-initializers:
435
436 2008-01-18  Adam Roben  <aroben@apple.com>
437
438         Build fix
439
440         * Scripts/build-webkit:
441
442 2008-01-18  Beth Dakin  <bdakin@apple.com>
443
444         Reviewed by Oliver.
445
446         Update build-webkit to account for foreign-object being disabled by 
447         default.
448
449         * Scripts/build-webkit:
450
451 2008-01-18  Adam Roben  <aroben@apple.com>
452
453         Updated for method renames
454
455         Reviewed by Adele.
456
457         * DumpRenderTree/mac/FrameLoadDelegate.mm:
458         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
459         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
460         (LayoutTestController::setMainFrameIsFirstResponder):
461         (LayoutTestController::setWindowIsKey):
462         * DumpRenderTree/mac/UIDelegate.mm:
463         (-[UIDelegate webViewFocus:]):
464         * DumpRenderTree/win/FrameLoadDelegate.cpp:
465         (FrameLoadDelegate::didCommitLoadForFrame):
466
467 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
468
469         Reviewed by Adam Roben.
470
471         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
472         between DRT and TestNetscapePlugin.
473
474         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
475         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
476
477 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
478
479         Reviewed by Holger.
480
481         Fix fast/dom/Window/window-resize.html
482         
483         In DRT connect the page's geometryChangeRequest signal to a slot that
484         sets the geometry of the view widget.
485         
486
487         * DumpRenderTree/qt/DumpRenderTree.cpp:
488         (WebCore::WebPage::setViewGeometry):
489         (WebCore::WebPage::WebPage):
490
491 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
492
493         Build fix.
494
495         * Drosera/DroseraWin.make:
496
497 2008-01-17  Darin Adler  <darin@apple.com>
498
499         * Scripts/run-webkit-tests: Fixed a bug number.
500
501 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
502
503         Reviewed by Adam Roben.
504
505         http://bugs.webkit.org/show_bug.cgi?id=16908
506         run-webkit-tests complains about missing FindSafari.exe
507
508         * Scripts/webkitdirs.pm: Append _debug as appropriate.
509
510 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
511
512         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
513         
514         Rubber-stamped by Jon Honeycutt.
515
516         * DumpRenderTree/win/DumpRenderTree.vcproj:
517
518 2008-01-16  Alp Toker  <alp@atoker.com>
519
520         Reviewed by Mark Rowe.
521
522         http://bugs.webkit.org/show_bug.cgi?id=16218
523         [GTK] API: Should this entry point be called go_back rather than go_backward?
524
525         Track back/forward API changes in the tools.
526
527         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
528         (BackForwardItem::invoke):
529         * GtkLauncher/main.c:
530         (go_back_cb):
531
532 2008-01-16  Adam Roben  <aroben@apple.com>
533
534         Windows build fix after r29488
535
536         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
537         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
538         expects to find the plugin.
539
540 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
541
542         Reviewed by Sam Weinig.
543         
544         Fixed the waitUntilDone watchdog timer -- the old code never added the
545         timer to the run loop, so it didn't do anything.
546
547         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
548         (LayoutTestController::setWaitToDump):
549         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
550         (LayoutTestController::setWaitToDump):
551
552 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
553
554         Use shared vsprops for most vcproj properties.
555         
556         Reviewed by Darin.
557
558         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
559         * DumpRenderTree/win/DumpRenderTree.vcproj:
560         * DumpRenderTree/win/ImageDiff.vcproj:
561         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
562         * FindSafari/FindSafari.vcproj:
563
564 2008-01-14  Stephanie  <slewis@apple.com>
565
566        Reviewed by NOBODY.
567   
568        revert accidental character.
569
570        * Scripts/run-webkit-tests:
571
572 2008-01-14  Stephanie  <slewis@apple.com>
573
574         RS=Oliver
575
576         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
577
578         * Scripts/run-webkit-tests:
579
580 2008-01-14  Darin Adler  <darin@apple.com>
581
582         * Scripts/do-webcore-rename: Queue up another rename.
583
584 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
585
586         Reviewed by Darin.
587
588         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
589         the tests were ran.
590         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
591
592         * Scripts/run-webkit-tests:
593
594 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
595
596         Reviewed by Darin.
597
598         * Randomize tests array to spot test cases where the results depends on the order
599         the tests are ran.
600         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
601
602         * Scripts/run-webkit-tests:
603
604 2008-01-14  Darin Adler  <darin@apple.com>
605
606         * Scripts/run-webkit-tests: More ignore list tweaking.
607
608 2008-01-14  Darin Adler  <darin@apple.com>
609
610         * Scripts/run-webkit-tests: Add another leak to the ignore list.
611
612 2008-01-14  Dan Bernstein  <mitz@apple.com>
613
614         Reviewed by Adam Roben.
615
616         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
617           build bots
618
619         * DumpRenderTree/win/DumpRenderTree.cpp:
620         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
621
622 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
623
624         Share common files across projects.
625         
626         Unify vsprops files
627         Debug:          common.vsprops, debug.vsprops
628         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
629         Release:        common.vsprops, release.vsprops
630         
631         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
632         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
633
634         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
635
636         Reviewed by Adam Roben.
637
638         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
639         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
640         * Drosera/win/Drosera.vcproj/VERSION: Removed.
641         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
642         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
643         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
644         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
645         * DumpRenderTree/win/DumpRenderTree.vcproj:
646         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
647         * DumpRenderTree/win/debug.vsprops: Removed.
648         * DumpRenderTree/win/debug_internal.vsprops: Removed.
649         * DumpRenderTree/win/release.vsprops: Removed.
650
651 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
652
653         Reviewed by Maciej.
654
655         - http://bugs.webkit.org/show_bug.cgi?id=16314
656           Script to launch Drosera
657
658         * Scripts/gdb-drosera: Added.
659         * Scripts/run-drosera: Added.
660         * Scripts/run-drosera-nightly.cmd: Added.
661         * Scripts/webkitdirs.pm: Added runDrosera function.
662
663 2008-01-13  Dan Bernstein  <mitz@apple.com>
664
665         - fix breakage due to last-minute change
666
667         * DumpRenderTree/win/DumpRenderTree.cpp:
668         (runTest): Declare the loop variable.
669
670 2008-01-13  Dan Bernstein  <mitz@apple.com>
671
672         Reviewed by Adam Roben.
673
674         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
675
676         * DumpRenderTree/win/DumpRenderTree.cpp:
677         (DumpRenderTreeWndProc):
678         (initialize):
679         (dumpBackForwardList):
680         (dumpBackForwardListForAllWindows):
681         (dump):
682         (resetWebViewToConsistentStateBeforeTesting): Factored out of
683         runTest().
684         (runTest):
685         (allWindows): Added. Returns a vector of all open windows.
686         (windowToWebViewMap): Added. Returns a map from open windows to their
687         WebViews.
688         (createWebViewAndOffscreenWindow): Factored out of main() to be
689         reusable for creating extra windows.
690         (main):
691         * DumpRenderTree/win/DumpRenderTreeWin.h:
692         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
693         (LayoutTestController::windowCount): Implemented.
694         * DumpRenderTree/win/UIDelegate.cpp:
695         (UIDelegate::createWebViewWithRequest): Implemented.
696         (UIDelegate::webViewClose): Implemented.
697         * DumpRenderTree/win/UIDelegate.h:
698
699 2008-01-12  Alp Toker  <alp@atoker.com>
700
701         Reviewed by Mark Rowe.
702
703         Hide non-public symbols in GTK+/autotools release builds.
704
705         * GNUmakefile.am:
706
707 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
708
709         Reviewed by Ap.
710
711         * Make launching of the WebKit httpd work on GNU/Debian/Linux
712         
713         The configuration of Apache2 and installation does not depend on
714         the kernel but on the distribution policy. Make launching of httpd
715         work for Debian derived distributions.
716
717         * Scripts/run-webkit-httpd:
718         * Scripts/run-webkit-tests:
719         * Scripts/webkitdirs.pm:
720
721 2008-01-12  Mark Rowe  <mrowe@apple.com>
722
723         Reviewed by Maciej Stachowiak.
724
725         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
726
727         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
728         match the callers expectations that it can take ownership of the string.
729
730 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
731
732         Reviewed by Adam Roben.
733
734         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
735
736         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
737         as these are only posted because the test window is not a normal visible one, and
738         they confuse drag&drop machinery.
739
740 2008-01-11  Adam Roben  <aroben@apple.com>
741
742         Fix a crash when pathToLocalResource fails and a leak
743
744         Reviewed by Darin.
745
746         * DumpRenderTree/LayoutTestController.cpp:
747         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
748         sure not to pass null to JSValueMakeString.
749         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
750         (LayoutTestController::pathToLocalResource): Print an error message if
751         the conversion fails so it's clear what happened.
752
753 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
754
755         Reviewed by John Sullivan.
756
757         * DumpRenderTree/mac/GCControllerMac.mm:
758         (GCController::collectOnAlternateThread): Updated for name change.
759
760 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
761
762         wx build fix. Don't build dftables any longer since it's now a Perl
763         script.
764
765         * wx/build-wxwebkit:
766
767 2008-01-10  Sam Weinig  <sam@webkit.org>
768
769         Reviewed by Anders Carlsson.
770
771         Make DRT track open windows instead of allocated windows so that
772         we can avoid ASSERTION due to late deallocs out of our control.
773
774         * DumpRenderTree/mac/DumpRenderTree.mm:
775         (dumpBackForwardListForAllWindows):
776         (runTest):
777         * DumpRenderTree/mac/DumpRenderTreeMac.h:
778         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
779         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
780         (+[DumpRenderTreeWindow openWindows]):
781         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
782         (-[DumpRenderTreeWindow close]):
783         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
784         (LayoutTestController::windowCount):
785
786 2008-01-10  Ada Chan  <adachan@apple.com>
787
788         Meta key is not the same as Alt key on windows.
789
790         Reviewed by Darin.
791
792         * DumpRenderTree/win/EventSender.cpp:
793         (keyDownCallback):
794
795 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
796
797         Reviewed by Darin, Sam and Adam.
798
799         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
800         link in gmail message displays JavaScript alert falsely complaining
801         about pop-up blocking.
802         - Added the ability to enable the pop-up blocker via the
803         LayoutTestController.
804
805         * DumpRenderTree/LayoutTestController.cpp:
806         (setPopupBlockingEnabledCallback):
807         (LayoutTestController::staticFunctions):
808         * DumpRenderTree/LayoutTestController.h:
809         * DumpRenderTree/mac/DumpRenderTree.mm:
810         (setDefaultsToConsistentValuesForTesting):
811         (resetWebViewToConsistentStateBeforeTesting):
812         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
813         (LayoutTestController::setPopupBlockingEnabled):
814
815 2008-01-10  Lars Knoll  <lars@trolltech.com>
816
817         Reviewed by Simon.
818
819         rename QWebPageHistory to QWebHistory.
820         
821
822         * DumpRenderTree/qt/jsobjects.cpp:
823
824 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
825
826         Reviewed by Darin.
827         
828         - add some more renames, adjust some
829
830         * Scripts/do-webcore-rename:
831
832 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
833
834         Reviewed by Oliver.
835
836         Enable SVG Fonts support by default.
837
838         * Scripts/build-webkit:
839
840 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
841
842         Reviewed by Adam.
843
844         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
845         DRT doesn't handle platform specific pixel test results correctly.
846
847         <test>-expected.txt files and <test>-expected.png files may now live
848         in different directories (ie. a cross-platform <test>-expected.txt file
849         and a platform-specific <test>-expected.png file).
850
851         * Scripts/run-webkit-tests:
852
853 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
854
855         Reviewed by Darin.
856
857         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
858         DRT did not correctly handle printing the '\0' char.  Now it does.
859
860         * DumpRenderTree/win/DumpRenderTree.cpp:
861         (dumpFramesAsText):
862         (dump):
863
864 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
865
866         Reviewed by Lars.
867
868         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
869         
870
871         * DumpRenderTree/qt/main.cpp:
872         * DumpRenderTree/qt/testplugin.cpp:
873         * DumpRenderTree/qt/testplugin.h:
874
875 2008-01-05  Mark Rowe  <mrowe@apple.com>
876
877         Reviewed by Alp Toker.
878
879         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
880
881         * DumpRenderTree/gtk/DumpRenderTree.cpp:
882         (processWork): Process pending work.
883         (webViewLoadFinished): Schedule processing of pending work.
884         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
885
886 2008-01-05  Darin Adler  <darin@apple.com>
887
888         * Scripts/do-webcore-rename: Some more renaming plans.
889
890 2008-01-04  Alice Liu  <alice.liu@apple.com>
891
892         Reviewed by Alexey and Darin.
893
894         Adding "home" and "end" to DRT's keydown since
895         DOM key events can't handle keyIdentifiers at this point. 
896
897         * DumpRenderTree/mac/EventSendingController.mm:
898         (-[EventSendingController keyDown:withModifiers:]):
899         * DumpRenderTree/win/EventSender.cpp:
900         (keyDownCallback):
901
902 2008-01-04  Lars Knoll  <lars@trolltech.com>
903
904         Reviewed by Simon.
905
906         fix DRT after the changes to QWebPage.
907         
908         The great thing is that we actually don't have
909         any regressions from the QWebPage change :)
910         
911
912         * DumpRenderTree/qt/DumpRenderTree.cpp:
913         (WebCore::DumpRenderTree::DumpRenderTree):
914
915 2008-01-04  Lars Knoll  <lars@trolltech.com>
916
917         Reviewed by Simon.
918
919         make QWebPage a QObject and get things to compile.
920         
921         Nothing works currently though.
922         
923
924         * DumpRenderTree/qt/DumpRenderTree.cpp:
925         (WebCore::DumpRenderTree::DumpRenderTree):
926
927 2008-01-04  Lars Knoll  <lars@trolltech.com>
928
929         Reviewed by Simon.
930
931         take a QString as identifier in QWebFrame::addToJSWindowObject.
932
933         * DumpRenderTree/qt/DumpRenderTree.cpp:
934         (WebCore::DumpRenderTree::initJSObjects):
935
936 2008-01-04  Alp Toker  <alp@atoker.com>
937
938         GTK+ DRT build fix for breakage introduced in r29149.
939
940         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
941         (LayoutTestController::execCommand):
942
943 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
944
945         Reviewed by Darin.
946
947         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
948
949         Added layoutTestController.execCommand to access editor commands that are not available
950         via document.execCommand.
951
952         * DumpRenderTree/LayoutTestController.cpp:
953         (execCommandCallback):
954         (LayoutTestController::staticFunctions):
955         * DumpRenderTree/LayoutTestController.h:
956         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
957         (LayoutTestController::execCommand):
958         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
959         (LayoutTestController::queueLoad):
960         (LayoutTestController::execCommand):
961
962 2008-01-03  Alice Liu  <alice.liu@apple.com>
963
964         Reviewed by Darin, Mitz.
965
966         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
967
968         the clickcount should not increase if the last click was at a different location.  it's a new click.
969
970         * DumpRenderTree/mac/DumpRenderTree.mm:
971         (runTest):
972         * DumpRenderTree/mac/EventSendingController.h:
973         * DumpRenderTree/mac/EventSendingController.mm:
974         (-[EventSendingController mouseDown]):
975         (-[EventSendingController mouseUp]):
976
977 2008-01-03  Darin Adler  <darin@apple.com>
978
979         Reviewed by Adam.
980
981         * Scripts/update-webkit: Make this work a little better for the people at Apple
982         who have a directory named Internal.
983
984 2008-01-03  Adam Roben  <aroben@apple.com>
985
986         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
987
988         Rubberstamped by Mark.
989
990         * Scripts/update-webkit-auxiliary-libs:
991
992 2008-01-03  Adam Roben  <aroben@apple.com>
993
994         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
995
996         http://bugs.webkit.org/show_bug.cgi?id=15663
997
998         Added a fuzz factor into the Last-Modified comparison for downloading
999         WebKitAuxiliaryLibrary.zip.
1000
1001         The zip file is served from a set of mirrors who give Last-Modified
1002         times that are off by 1-3 seconds from each other. This was causing
1003         the build bots to redownload WebKitAuxiliaryLibrary for every build,
1004         which would then cause all of WebCore to rebuild each time.
1005
1006         Reviewed by Mark.
1007
1008         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
1009         at least 30 seconds newer than the old one -- otherwise we assume that
1010         the difference in time is due to the mirrors being slightly offset
1011         from each other.
1012         (sub lastModifiedToUnixTime): Added.
1013
1014 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1015
1016         Windows build fix.
1017
1018         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
1019
1020 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1021
1022         Reviewed by Lars.
1023
1024         Moved QWebPage::open to QWebFrame::load and added setHtml.
1025         
1026
1027         * DumpRenderTree/qt/DumpRenderTree.cpp:
1028         (WebCore::DumpRenderTree::open):
1029
1030 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1031
1032         Reviewed by Lars.
1033
1034         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
1035         
1036
1037         * DumpRenderTree/qt/DumpRenderTree.cpp:
1038         (WebCore::DumpRenderTree::DumpRenderTree):
1039
1040 2008-01-02  Sam Weinig  <sam@webkit.org>
1041
1042         * Scripts/do-webcore-rename: Yet more renaming ideas.
1043
1044 2008-01-02  Darin Adler  <darin@apple.com>
1045
1046         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
1047
1048 2008-01-02  Alice Liu  <alice.liu@apple.com>
1049
1050         Reviewed by Sam Weinig.
1051
1052         fixing assertion hit with editing/selection/move-begin-end.html
1053
1054         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
1055         * DumpRenderTree/win/DumpRenderTree.vcproj:
1056         * DumpRenderTree/win/EventSender.cpp:
1057         (keyDownCallback):
1058         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
1059
1060 2008-01-02  Darin Adler  <darin@apple.com>
1061
1062         * Scripts/do-webcore-rename: Some more name change plans.
1063
1064 2008-01-02  Alice Liu  <alice.liu@apple.com>
1065
1066         Reviewed by Maciej.
1067
1068         Added handling for page up and page down in EventSender
1069
1070         * DumpRenderTree/mac/EventSendingController.mm:
1071         (-[EventSendingController keyDown:withModifiers:]):
1072         * DumpRenderTree/win/EventSender.cpp:
1073         (keyDownCallback):
1074
1075 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
1076
1077         Reviewed by Darin.
1078
1079         Fix fast/events/arrow-keys-on-body.html for real.
1080
1081         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
1082
1083 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
1084
1085         Reviewed by Darin.
1086
1087         http://bugs.webkit.org/show_bug.cgi?id=16674
1088         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
1089
1090         * Scripts/run-launcher:
1091
1092 2007-12-31  Darin Adler  <darin@apple.com>
1093
1094         Suggested by Antti.
1095
1096         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
1097         we get it installed on the build bots.
1098
1099 2007-12-30  Eric Seidel  <eric@webkit.org>
1100
1101         Reviewed by Sam.
1102
1103         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
1104
1105 2007-12-29  Darin Adler  <darin@apple.com>
1106
1107         Reviewed by Oliver.
1108
1109         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
1110           leak bot shows createCStringFromNPVariant result leaking
1111
1112         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1113         (pluginInvoke): Added a missing free.
1114
1115 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1116
1117         Reviewed by Alp Toker.
1118
1119         http://bugs.webkit.org/show_bug.cgi?id=16390
1120         Use autotools or GNU make as the build system for the GTK port
1121
1122         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
1123         * GNUmakefile.am: Added.
1124
1125 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
1126
1127         Reviewed by Oliver.
1128
1129         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
1130
1131         * DumpRenderTree/win/EventSender.cpp:
1132         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
1133         of 1, even though WebKit currently ignores it.
1134
1135 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
1136
1137         wx buildbot fix. Update libpng dl script to the latest version.
1138
1139         * wx/install-unix-extras:
1140
1141 2007-12-22  Antti Koivisto  <antti@apple.com>
1142
1143         Fix a typo.
1144
1145         * Scripts/webkitdirs.pm:
1146
1147 2007-12-21  Sam Weinig  <sam@webkit.org>
1148
1149         Reviewed by Mark Rowe.
1150
1151         - Disable the back/forward cache using the new WebPreferences API
1152           instead of through the BackForwardList.  This makes us match what
1153           we do on Windows.
1154
1155         * DumpRenderTree/mac/DumpRenderTree.mm:
1156         (createWebViewAndOffscreenWindow):
1157         (setDefaultsToConsistentValuesForTesting):
1158
1159 2007-12-21  Dan Bernstein  <mitz@apple.com>
1160
1161         Reviewed by Mark Rowe.
1162
1163         - disable the back/forward cache in Windows DumpRenderTree. It is
1164           already disabled in Mac DumpRenderTree.
1165
1166         * DumpRenderTree/win/DumpRenderTree.cpp:
1167         (initializePreferences):
1168
1169 2007-12-13  Antti Koivisto  <antti@apple.com>
1170
1171         Reviewed by Darin and Steve.
1172         
1173         - check for QuickTime SDK on Windows.
1174         - build media support on Windows by default
1175
1176         * Scripts/build-webkit:
1177         * Scripts/webkitdirs.pm:
1178
1179 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
1180
1181         Build script fix for buildbot.
1182
1183         * wx/build-wxwebkit:
1184
1185 2007-12-20  Eric Seidel  <eric@webkit.org>
1186
1187         Reviewed by mjs.
1188
1189         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
1190
1191 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1192
1193         Reviewed by Steve.
1194
1195         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
1196         WebKit.
1197
1198         - Drosera and Safari need to use the same ProgIDs in order for
1199         CoCreateInstance to work properly.  The most robust way to do this is
1200         for WebKit to dynamically publish those ProgIDs.
1201
1202         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
1203         (DebuggerClient::createWebViewWithRequest):
1204         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
1205         statics.
1206         (Drosera::initUI):
1207         (Drosera::attach):
1208         (Drosera::attemptToCreateServerConnection):
1209         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
1210         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
1211         make use of the published ProgIDs.
1212         (ServerConnection::attemptToCreateServerConnection):
1213
1214 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1215
1216         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
1217         - Build bot and leak fix.
1218
1219         * DumpRenderTree/LayoutTestController.cpp:
1220         (pathToLocalResourceCallback):
1221
1222 2007-12-19  David Kilzer  <ddkilzer@apple.com>
1223
1224         Make svn-apply/svn-unapply work with patches from git-format-patch.
1225
1226         Reviewed by Darin.
1227
1228         * Scripts/svn-apply:
1229         (patch): If 'Index:' can't be found in the text passed in, print it
1230         out with a warning and return early.
1231         * Scripts/svn-unapply:
1232         (patch): Ditto.
1233
1234 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
1235
1236         Reviewed by Alp Toker.
1237
1238         Build related fixes.
1239
1240         * wx/build-wxwebkit:
1241         - Check to make sure the user is running a supported wx port
1242         - More robust checks for Cygwin
1243         - Only run install-unix-extras on Mac, it's not the right solution
1244           for Linux distros.
1245         - Remove outdated Linux instructions after successful build
1246         - Clean Bakefile-generated files during a clean operation
1247
1248 2007-12-18  Darin Adler  <darin@apple.com>
1249
1250         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
1251
1252 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
1253
1254         Add script to run Drosera as part of the nightly.
1255         
1256         Reviewed by Kevin M.
1257
1258         * Scripts/run-drosera.cmd: Added.
1259
1260 2007-12-18  Darin Adler  <darin@apple.com>
1261
1262         * Scripts/do-webcore-rename: Remove a stray K.
1263
1264 2007-12-18  Darin Adler  <darin@apple.com>
1265
1266         * Scripts/do-webcore-rename: Plan more renaming.
1267
1268 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
1269
1270         Reviewed by Alp Toker.
1271
1272         http://bugs.webkit.org/show_bug.cgi?id=16042
1273         [GTK] Eliminate webkit_init()
1274
1275         Moving webkit initialization to WebView class init.
1276
1277         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1278         (main):
1279         * GtkLauncher/main.c:
1280         (main):
1281
1282 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
1283
1284         Reviewed by Alp Toker.
1285
1286         http://bugs.webkit.org/show_bug.cgi?id=13542
1287         gdklauncher doesnt change URL in adress GTKEntry.
1288
1289         * GtkLauncher/main.c:
1290         (load_commit_cb): added
1291         (title_change_cb):
1292         (create_browser):
1293
1294 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
1295
1296         Reviewed by Adam Roben.
1297
1298         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
1299
1300         * FindSafari/FindSafari.cpp:
1301         (_tmain):
1302
1303 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
1304
1305         Reviewed by Adam Roben.
1306
1307         http://bugs.webkit.org/show_bug.cgi?id=16315
1308         FindSafari needs a path-only option.
1309
1310         * FindSafari/FindSafari.cpp:
1311         (_tmain):
1312
1313 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
1314
1315         Reviewed by Darin.
1316
1317         http://bugs.webkit.org/show_bug.cgi?id=16462
1318         REGRESSION: access keys broken on Windows
1319
1320         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
1321         if Alt is pressed.
1322
1323 2007-12-15  Sam Weinig  <sam@webkit.org>
1324
1325         Reviewed by Mark Rowe.
1326
1327         Fix urlSuitableForTestResult to correctly identify wstring::npos as
1328         the case when wstring.find doesn't find anything.
1329
1330         * DumpRenderTree/win/DumpRenderTree.cpp:
1331         (urlSuitableForTestResult):
1332
1333 2007-12-15  Alp Toker  <alp@atoker.com>
1334
1335         GTK+ DRT build fix for GLib < 2.14.
1336
1337         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1338         (LayoutTestController::setWaitToDump):
1339
1340 2007-12-05  Mark Rowe  <mrowe@apple.com>
1341
1342         Reviewed by Alp Toker.
1343
1344         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
1345         many layout tests from hanging while waiting on user responses to dialogs.
1346
1347         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1348         (invalidateAnyPreviousWaitToDumpWatchdog):
1349         (webViewScriptAlert):
1350         (webViewScriptPrompt):
1351         (webViewScriptConfirm):
1352         (main):
1353         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1354         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1355         (waitToDumpWatchdogFired):
1356         (LayoutTestController::setWaitToDump):
1357
1358 2007-12-05  Mark Rowe  <mrowe@apple.com>
1359
1360         Reviewed by Alp Toker.
1361
1362         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
1363
1364         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1365         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1366         (dump):
1367         (runTest):
1368         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
1369         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
1370         work queue is empty.
1371         (webViewWindowObjectCleared): Set up window.layoutTestController.
1372         (webViewConsoleMessage): Match the console message format expected by the layout test results.
1373         (main): Hook up the new signals.
1374         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1375         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
1376         dumping multiple times.
1377         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
1378         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
1379
1380 2007-12-14  Anders Carlsson  <andersca@apple.com>
1381
1382         Reviewed by Brady.
1383
1384         Assert that a web frame that's loading a resource always has either a data source or 
1385         a provisional data source.
1386         
1387         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1388         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1389
1390 2007-12-14  Darin Adler  <darin@apple.com>
1391
1392         - fix mistake causing nearly all tests to fail on Windows
1393
1394         * DumpRenderTree/win/UIDelegate.cpp:
1395         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1396         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1397
1398         * DumpRenderTree/mac/UIDelegate.mm:
1399         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1400         than passing the entire message.
1401
1402 2007-12-14  Darin Adler  <darin@apple.com>
1403
1404         - fix Tiger build
1405
1406         * DumpRenderTree/mac/UIDelegate.mm:
1407         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1408         new-to-Leopard methods.
1409
1410 2007-12-14  Darin Adler  <darin@apple.com>
1411
1412         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1413         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1414         delegate methods here.
1415
1416 2007-12-14  Anders Carlsson  <andersca@apple.com>
1417
1418         Reviewed by Darin and Geoff.
1419
1420         <rdar://problem/5619295> 
1421         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1422         
1423         Add property getting methods to the plug-in.
1424         
1425         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1426         (pluginInvoke):
1427
1428 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1429
1430         Reviewed by Darin.
1431
1432         - Layout test fix for mac. When dumped to the console local file paths
1433         now only show the name of the resource not the whole path.  This is to
1434         make the results machine and OS independent.
1435
1436         * DumpRenderTree/mac/UIDelegate.mm:
1437         (-[UIDelegate webView:addMessageToConsole:]):
1438
1439 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1440
1441         Reviewed by Adam.
1442
1443         - Layout tests fix.  We need a way to remove machine-dependent
1444         information from paths in layout test results. The UIDelegate now does
1445         this.
1446
1447         * DumpRenderTree/DumpRenderTree.h:
1448         * DumpRenderTree/win/DumpRenderTree.cpp:
1449         (urlSuitableForTestResult):
1450         * DumpRenderTree/win/DumpRenderTreeWin.h:
1451         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1452         * DumpRenderTree/win/UIDelegate.cpp:
1453         (UIDelegate::webViewAddMessageToConsole):
1454
1455 2007-12-13  Alp Toker  <alp@atoker.com>
1456
1457         Build fix for DRT breakage introduced in r28690.
1458
1459         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1460         (LayoutTestController::pathToLocalResource):
1461
1462 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1463
1464         Reviewed by Alice and Sam.
1465
1466         - <rdar://5621435> Need a way to specify local resources (being loaded
1467         from HTTP tests) on Windows.
1468         - Implemented pathToLocalResource which exposes the functionality of
1469         converting a given unix path to the correct location on Windows.
1470
1471         * DumpRenderTree/LayoutTestController.cpp:
1472         (pathToLocalResourceCallback):
1473         (LayoutTestController::staticFunctions):
1474         * DumpRenderTree/LayoutTestController.h:
1475         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1476         (LayoutTestController::pathToLocalResource):
1477         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1478         (LayoutTestController::pathToLocalResource):
1479
1480 2007-12-12  Anders Carlsson  <andersca@apple.com>
1481
1482         Reviewed by Sam.
1483
1484         <rdar://problem/5132003>
1485         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1486
1487         * DumpRenderTree/win/DumpRenderTree.cpp:
1488         (main):
1489         Set the resource load delegate.
1490         
1491         * DumpRenderTree/win/DumpRenderTree.vcproj:
1492         
1493         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1494         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1495
1496 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1497
1498         Reviewed by Adam Roben.
1499
1500         Fix conversion from double to LPARAM in dispatchMessage().
1501
1502         * DumpRenderTree/win/EventSender.cpp:
1503         (dispatchMessageCallback):
1504
1505 2007-12-11  Dan Bernstein  <mitz@apple.com>
1506
1507         Reviewed by Mark Rowe and Sam Weinig too!
1508
1509         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1510           fonts DumpRenderTree registers.
1511
1512         * DumpRenderTree/win/DumpRenderTree.cpp:
1513         (initialize):
1514
1515 2007-12-11  Brady Eidson  <beidson@apple.com>
1516
1517         Reviewed by Anders
1518
1519         Make DumpRenderTree on mac use its own path for Databases testing
1520
1521         * DumpRenderTree/mac/DumpRenderTree.mm:
1522         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1523           for future DRT-only use, then use it to construct the Databases path and set that default
1524
1525 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1526
1527         Reviewed by Darin.
1528
1529         <rdar://problem/5535636>
1530         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1531
1532         http://bugs.webkit.org/show_bug.cgi?id=13916
1533         JavaScript detects Tab as a character input on a textfield validation
1534
1535         * DumpRenderTree/mac/EventSendingController.mm:
1536         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1537         Dispatch a keyup to better match what happens when a key is physically pressed.
1538
1539         * DumpRenderTree/win/EventSender.cpp:
1540         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1541         returning from keyDown().
1542         (getConstantCallback): Fixed a couple copy/paste mistakes.
1543
1544 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1545
1546         Reviewed by Oliver.
1547
1548         - <rdar://5599845> Drosera: Does not show loal files in the file list
1549         on the left side.
1550
1551         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1552         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1553         so the open source community can build.
1554
1555 2007-12-10  Brady Eidson  <beidson@apple.com>
1556
1557         Rubberstamped by Sam Weinig
1558
1559         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1560
1561         * DumpRenderTree/mac/UIDelegate.mm:
1562         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1563         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1564
1565 2007-12-08  Oliver Hunt  <oliver@apple.com>
1566
1567         Reviewed by Sam W.
1568
1569         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1570         
1571         Fixes <rdar://problem/5620249> Must disable SVG animation
1572         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1573         
1574         In order to allow finer grained control over the set of SVG features
1575         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1576         distinct flags:
1577         ENABLE_SVG_ANIMATION
1578         ENABLE_SVG_FILTERS
1579         ENABLE_SVG_FONTS
1580         ENABLE_SVG_AS_IMAGE
1581         ENABLE_SVG_USE
1582         
1583         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1584         
1585         Script handles all the new build flags, and allows --svg-experimental
1586         to automatically enable all features.
1587
1588         * Scripts/build-webkit:
1589
1590 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1591
1592         Fix version parsing.
1593
1594         Rubber-stamped by Oliver.
1595
1596         * Drosera/win/Drosera.vcproj/auto-version.sh:
1597
1598 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1599
1600         Build modifications for Drosera.
1601
1602         Reviewed by Adam.
1603
1604         * Drosera/DroseraWin.make: Added.
1605         * Drosera/win/Drosera.vcproj/Drosera.rc:
1606         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1607         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1608         * Drosera/win/Drosera.vcproj/VERSION: Added.
1609         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1610
1611 2007-12-06  Adam Roben  <aroben@apple.com>
1612
1613         Explicitly turn on the Mac font ascent hack on Windows
1614
1615         This keeps our font metrics matching those from Mac.
1616
1617         Reviewed by Hyatt.
1618
1619         * DumpRenderTree/win/DumpRenderTree.cpp:
1620         (main):
1621
1622 2007-12-06  Anders Carlsson  <andersca@apple.com>
1623
1624         Rename main.c to main.cpp here too.
1625         
1626         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1627
1628 2007-12-06  Sam Weinig  <sam@webkit.org>
1629
1630         Rubber stamped by Geoff.
1631
1632         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1633
1634 2007-12-06  Darin Adler  <darin@apple.com>
1635
1636         * Scripts/do-webcore-rename: Some more renaming plans.
1637
1638 2007-12-06  Anders Carlsson  <andersca@apple.com>
1639
1640         Restore implementation of testGetIntIdentifier that was accidentally
1641         removed somehow (possibly when I made PluginObject be a cpp file).
1642         
1643         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1644         (pluginInvoke):
1645
1646 2007-12-05  Anders Carlsson  <andersca@apple.com>
1647
1648         Make the entry points extern "C".
1649         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1650         
1651 2007-12-05  Anders Carlsson  <andersca@apple.com>
1652
1653         C++ warning fixes.
1654         
1655         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1656         (NPP_New):
1657         (NPP_Destroy):
1658         (NPP_SetWindow):
1659         (NPP_NewStream):
1660         (NPP_HandleEvent):
1661         (NPP_URLNotify):
1662         (NPP_GetValue):
1663
1664 2007-12-05  Anders Carlsson  <andersca@apple.com>
1665
1666         Add the .cpp files to the TestNetscapePlugIn target.
1667
1668         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1669
1670 2007-12-05  Anders Carlsson  <andersca@apple.com>
1671
1672         Reviewed by Geoff.
1673         
1674         Rename the TestNetscapePlugIn .c files to be .cpp.
1675
1676         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1677         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1678         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1679         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1680         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1681         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1682         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1683         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1684
1685 2007-12-05  Adam Roben  <aroben@apple.com>
1686
1687         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1688
1689         This fixes several regression tests.
1690
1691         Reviewed by Alice.
1692
1693         * DumpRenderTree/win/EventSender.cpp:
1694         (keyDownCallback): Virtual keycodes for ASCII characters are always
1695         uppercase, so we need to check the case of the original character
1696         passed in to eventSender.keyDown.
1697
1698 2007-12-05  Adam Roben  <aroben@apple.com>
1699
1700         Learn from Tim's mistakes
1701
1702         * DumpRenderTree/win/DumpRenderTree.cpp:
1703         (runTest): Reset the authorAndUserStylesEnabled preference for each
1704         test.
1705
1706 2007-12-05  Alp Toker  <alp@atoker.com>
1707
1708         Reviewed by Mark Rowe.
1709
1710         Initialize GTK+ and WebKit so the tests can run.
1711
1712         Reorganize the headers a little.
1713
1714         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1715         (main):
1716
1717 2007-12-04  Anders Carlsson  <andersca@apple.com>
1718
1719         Remove IWebScriptScope include.
1720         
1721         * Drosera/win/DebuggerDocumentPlatform.cpp:
1722
1723 2007-12-04  Sam Weinig  <sam@webkit.org>
1724
1725         Rubber stamped by Mark Rowe.
1726
1727         Define CF as platform for mac and revert r28409
1728
1729         * DumpRenderTree/DumpRenderTree.h:
1730         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1731
1732 2007-12-04  Sam Weinig  <sam@webkit.org>
1733
1734         Define CF as platform for windows.
1735
1736         Reviewed by Adam Roben.
1737
1738         * DumpRenderTree/win/DumpRenderTreeWin.h:
1739
1740 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1741
1742         Reviewed by Adam and Darin.
1743
1744         - Removed a needless BSTR cleanup.
1745
1746         * Drosera/win/DebuggerDocumentPlatform.cpp:
1747         (DebuggerDocument::getPlatformCurrentFunctionStack):
1748
1749 2007-11-27  Adam Roben  <aroben@apple.com>
1750
1751         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1752
1753         Reviewed by Maciej.
1754
1755         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1756         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1757
1758 2007-12-04  Alp Toker  <alp@atoker.com>
1759
1760         Prospective Win DRT build fix.
1761
1762         * DumpRenderTree/DumpRenderTree.h:
1763
1764 2007-12-04  Alp Toker  <alp@atoker.com>
1765
1766         Fix a clobbered copyright header.
1767
1768         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1769
1770 2007-12-04  Xan Lopez  <xan@gnome.org>
1771
1772         Reviewed by Alp Toker.
1773
1774         http://bugs.webkit.org/show_bug.cgi?id=15561
1775         GTK port needs DumpRenderTree implementation
1776
1777         Start work on the GTK+ DRT.
1778
1779         This does not work yet, and there are a few lingering style issues
1780         (nothing major) but this patch has been stuck in the bug tracker for
1781         too long already.
1782
1783         * DumpRenderTree/DumpRenderTree.h:
1784         * DumpRenderTree/gtk: Added.
1785         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1786         (autocorrectURL):
1787         (shouldLogFrameLoadDelegates):
1788         (dumpFrameScrollPosition):
1789         (displayWebView):
1790         (appendString):
1791         (dumpFramesAsText):
1792         (dumpRenderTreeAsText):
1793         (dump):
1794         (runTest):
1795         (main):
1796         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1797         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1798         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1799         (GCController::collect):
1800         (GCController::collectOnAlternateThread):
1801         (GCController::getJSObjectCount):
1802         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1803         (LayoutTestController::~LayoutTestController):
1804         (LayoutTestController::addDisallowedURL):
1805         (LayoutTestController::clearBackForwardList):
1806         (LayoutTestController::copyDecodedHostName):
1807         (LayoutTestController::copyEncodedHostName):
1808         (LayoutTestController::display):
1809         (LayoutTestController::keepWebHistory):
1810         (LayoutTestController::notifyDone):
1811         (LayoutTestController::queueBackNavigation):
1812         (LayoutTestController::queueForwardNavigation):
1813         (LayoutTestController::queueLoad):
1814         (LayoutTestController::queueReload):
1815         (LayoutTestController::queueScript):
1816         (LayoutTestController::setAcceptsEditing):
1817         (LayoutTestController::setCustomPolicyDelegate):
1818         (LayoutTestController::setMainFrameIsFirstResponder):
1819         (LayoutTestController::setTabKeyCyclesThroughElements):
1820         (LayoutTestController::setUseDashboardCompatibilityMode):
1821         (LayoutTestController::setUserStyleSheetEnabled):
1822         (LayoutTestController::setUserStyleSheetLocation):
1823         (LayoutTestController::setWindowIsKey):
1824         (LayoutTestController::setWaitToDump):
1825         (LayoutTestController::windowCount):
1826         (LayoutTestController::setPrivateBrowsingEnabled):
1827         (LayoutTestController::setAuthorAndUserStylesEnabled):
1828         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1829         (JSStringCopyUTF8CString):
1830         (LoadItem::invoke):
1831         (ReloadItem::invoke):
1832         (ScriptItem::invoke):
1833         (BackForwardItem::invoke):
1834
1835 2007-12-03  Sam Weinig  <sam@webkit.org>
1836
1837         Move JavaScriptCore thread testing code to pthread specific directory
1838         and remove the dependance on CoreFoundation by using WTF::HashSet.
1839
1840         Reviewed by Geoff and Oliver.
1841
1842         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1843         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1844         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1845         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1846         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1847         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1848         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1849         * DumpRenderTree/pthreads: Added.
1850         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1851         (javaScriptThreads):
1852         (runJavaScriptThread):
1853         (startJavaScriptThreads):
1854         (stopJavaScriptThreads):
1855
1856 2007-12-03  Andrew Bonventre  <andybons@google.com>
1857
1858         Reviewed by Darin Adler.
1859
1860         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1861         Symbol lookup menu broken in debugger view
1862
1863         * Drosera/debugger.js: Fixed javascript error where document property
1864         should have been used instead of contentDocument in switchFunction that
1865         was breaking the select symbol dropdown menu.  This is because
1866         window.frames will return a Window object and not a frame object like
1867         the author was originally expecting.
1868
1869 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1870
1871         Reviewed by Adam.
1872
1873         - <rdar://5618942> Drosera: Console window does not process everything
1874         correctly.
1875         - <rdar://5619005> Drosera: could be sped up by moving the 
1876         WebScriptScope stuff into the WebScriptCallFrame.
1877         - Now the console can correctly process objects and does not receive
1878         notifications from JavaScriptCore about the JavaScript in Drosera's
1879         own process.
1880
1881         * Drosera/win/DebuggerDocumentPlatform.cpp:
1882         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1883         (DebuggerDocument::platformValueForScopeVariableNamed):
1884
1885 2007-12-03  Stephanie  <slewis@apple.com>
1886
1887         Reviewed by Darin.
1888
1889         Check to see if we are building a debug root
1890
1891         * Scripts/check-for-global-initializers: 
1892
1893 2007-12-03  Dan Bernstein  <mitz@apple.com>
1894
1895         Reviewed by Darin Adler.
1896
1897         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1898
1899         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1900         (pluginInvoke):
1901
1902 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1903
1904         Reviewed by Oliver.
1905
1906         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1907         in a more fine-grained manner than eventSender.keyDown().
1908
1909         * DumpRenderTree/win/EventSender.cpp:
1910         (getConstantCallback):
1911         (dispatchMessageCallback):
1912
1913 2007-12-02  Darin Adler  <darin@apple.com>
1914
1915         * Scripts/do-webcore-rename: More planned renaming.
1916
1917 2007-12-02  Sam Weinig  <sam@webkit.org>
1918
1919         Rubber stamped by Anders.
1920
1921         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1922         more uniform results cross platform.
1923
1924         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1925         (-[NSURL _drt_descriptionSuitableForTestResult]):
1926
1927 2007-12-02  Sam Weinig  <sam@webkit.org>
1928
1929         Rubber stamped by Niko.
1930
1931         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1932
1933         * DumpRenderTree/win/DumpRenderTree.cpp:
1934         * DumpRenderTree/win/DumpRenderTree.vcproj:
1935         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1936         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1937         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1938         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1939
1940 2007-12-01  Alp Toker  <alp@atoker.com>
1941
1942         Reviewed by Adam Roben.
1943
1944         Make use of the newly introduced webkit.h convenience header.
1945
1946         * GtkLauncher/main.c:
1947
1948 2007-12-01  Adam Treat  <treat@kde.org>
1949
1950         Reviewed by Simon.
1951
1952         * Check to see if the directory exists and exit if not.
1953
1954         * DumpRenderTree/qt/main.cpp:
1955         (main):
1956
1957 2007-12-01  Adam Treat  <treat@kde.org>
1958
1959         Reviewed by Simon.
1960
1961         * Don't hide symbols when in Debug mode
1962         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1963
1964
1965         * DumpRenderTree/qt/main.cpp:
1966         (messageHandler):
1967
1968 2007-11-30  Alp Toker  <alp@atoker.com>
1969
1970         Reviewed by Adam Roben.
1971
1972         http://bugs.webkit.org/show_bug.cgi?id=15691
1973         [GTK] Public API does not follow GTK+ conventions
1974
1975         Refactor the WebKit/GTK+ public API. Changes:
1976           WebKitPage -> WebKitWebView
1977           WebKitFrame -> WebKitWebFrame
1978
1979         Public API source and header names have been updated to mirror the API
1980         changes.
1981
1982         The API is now kept in WebKit/gtk/WebView to match other ports in the
1983         same class such as Mac and Win.
1984
1985         * GtkLauncher/main.c:
1986         (activate_uri_entry_cb):
1987         (link_hover_cb):
1988         (title_change_cb):
1989         (progress_change_cb):
1990         (go_back_cb):
1991         (go_forward_cb):
1992         (create_browser):
1993         (main):
1994
1995 2007-11-30  Adam Roben  <aroben@apple.com>
1996
1997         Hopefully the final build fix
1998
1999         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
2000         pull in WTF's assertion/logging functions.
2001
2002 2007-11-30  Adam Roben  <aroben@apple.com>
2003
2004         Another build fix
2005
2006         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
2007         WebKit.lib.
2008
2009 2007-11-30  Adam Roben  <aroben@apple.com>
2010
2011         Debug build fix
2012
2013         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
2014         configuration.
2015         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
2016         projects.
2017         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
2018         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
2019         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
2020
2021 2007-11-30  Sam Weinig  <sam@webkit.org>
2022
2023         Reviewed by Adam Roben.
2024
2025         Fix drawSelectionRect to actually draw the selection rect.
2026
2027         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2028         (drawSelectionRect):
2029
2030 2007-11-30  Darin Adler  <darin@apple.com>
2031
2032         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
2033
2034 2007-11-30  Darin Adler  <darin@apple.com>
2035
2036         * Scripts/do-webcore-rename: Get ready for some future renaming.
2037
2038 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2039
2040         Reviewed by Adam.
2041
2042         - Removed some unnecessary functions and changed an unused return type. 
2043
2044         * Drosera/win/DebuggerClient.cpp:
2045         (registerConsoleClass):
2046         * Drosera/win/DebuggerClient.h:
2047         * Drosera/win/Drosera.cpp:
2048         (registerDroseraClass):
2049
2050 2007-11-28  Alp Toker  <alp@atoker.com>
2051
2052         Reviewed by Timothy Hatcher.
2053
2054         http://bugs.webkit.org/show_bug.cgi?id=16174
2055         [GTK] Use "URI" not "URL" in public API
2056
2057         Replace use of the term "URL" with "URI" in public headers,
2058         documentation and some internal code to match GLib/GTK+ convention.
2059
2060         This is now mentioned in the API guidelines:
2061           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
2062
2063         * GtkLauncher/main.c:
2064         (activate_uri_entry_cb):
2065         (title_change_cb):
2066         (create_toolbar):
2067         (main):
2068
2069 2007-11-29  Anders Carlsson  <andersca@apple.com>
2070
2071         Reviewed by Sam.
2072
2073         <rdar://problem/5230478>
2074         FrameLoadDelegate callbacks are not dumped in DRT.
2075         
2076         * DumpRenderTree/win/DumpRenderTree.cpp:
2077         (shouldLogFrameLoadDelegates):
2078         (runTest):
2079         (main):
2080         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2081         (BSTRtoString):
2082         (descriptionSuitableForTestResult):
2083         (FrameLoadDelegate::QueryInterface):
2084         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2085         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2086         (FrameLoadDelegate::didCommitLoadForFrame):
2087         (FrameLoadDelegate::didFinishLoadForFrame):
2088         (FrameLoadDelegate::willCloseFrame):
2089         (FrameLoadDelegate::didClearWindowObject):
2090         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2091         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2092         * DumpRenderTree/win/FrameLoaderDelegate.h:
2093         (FrameLoadDelegate::windowScriptObjectAvailable):
2094         (FrameLoadDelegate::didFirstLayoutInFrame):
2095
2096 2007-11-29  Sam Weinig  <sam@webkit.org>
2097
2098         Reviewed by Anders.
2099
2100         Add database quota UIDelegates methods to DRT UIDelegate.
2101
2102         * DumpRenderTree/mac/UIDelegate.mm:
2103         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2104         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
2105
2106 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2107
2108         Reviewed by Sam.
2109
2110         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
2111         dying and vice versa.
2112         - This fix will allow Drosera and Safari to reconnect if either of them
2113         closes correctly, but does not fix the case where one of them dies
2114         silently.
2115
2116         * Drosera/win/ServerConnection.cpp:
2117         (ServerConnection::attemptToCreateServerConnection): Added a safety
2118         check, because it's possilbe to try to connect to a server that's dying.
2119         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
2120         the server has died.
2121         * Drosera/win/ServerConnection.h: Added the new function and removed
2122         an unnecessary member.
2123
2124 2007-11-29  Anders Carlsson  <andersca@apple.com>
2125
2126         * DumpRenderTree/win/DumpRenderTree.vcproj:
2127         Add shlwapi.lib to all configurations.
2128
2129 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2130
2131         - Build fix.  Added additional includes for VS Express to the Release
2132         project.
2133
2134         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2135
2136 2007-11-29  Anders Carlsson  <andersca@apple.com>
2137
2138         Reviewed by Adam.
2139
2140         <rdar://problem/5132005>
2141         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
2142         
2143         * DumpRenderTree/win/DumpRenderTree.vcproj:
2144         Add shlwapi.lib
2145         
2146         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2147         (LayoutTestController::setUserStyleSheetEnabled):
2148         Implement this.
2149         
2150         (appendComponentToPath):
2151         New method which wraps the Win32 API PathAppend.
2152         
2153         (followShortcuts):
2154         New method which checks if a file points to a shortcut and
2155         follows the shortcut.
2156         
2157         (resolveCygwinPath):
2158         New method that takes a cygwin unix-style path and returns the Win32 path.
2159         
2160         (cfStringRefToWString):
2161         
2162         (LayoutTestController::setUserStyleSheetLocation):
2163         Implement this.
2164
2165 2007-11-29  Alice Liu  <alice.liu@apple.com>
2166
2167         Reviewed by Adam.
2168
2169         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
2170
2171         * DumpRenderTree/win/EventSender.cpp:
2172         (keyDownCallback):
2173         uppercase letters were being sent as lowercase letters without the shift key down.
2174
2175 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2176
2177         - Windows build fix. VS express needs some love.
2178
2179         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2180
2181 2007-11-28  Darin Adler  <darin@apple.com>
2182
2183         Reviewed by Adam Roben.
2184
2185         * DumpRenderTree/mac/EventSendingController.mm:
2186         (-[EventSendingController keyDown:withModifiers:]):
2187         Send capital letters through as lowercase letters with the shift key down
2188         rather than sending them as if they were highly unusual "capital letter keys".
2189
2190         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
2191         where you need to update results and more tests are failing than before.
2192
2193 2007-11-28  Anders Carlsson  <andersca@apple.com>
2194
2195         Reviewed by Darin.
2196
2197         <rdar://problem/5132001>
2198         contextClick is not implemented in DRT on Windows.
2199         
2200         * DumpRenderTree/win/EventSender.cpp:
2201         (contextClickCallback):
2202         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
2203         by a WM_RBUTTONUP message.
2204         
2205         * DumpRenderTree/win/UIDelegate.cpp:
2206         (UIDelegate::hasCustomMenuImplementation):
2207         (UIDelegate::trackCustomPopupMenu):
2208         * DumpRenderTree/win/UIDelegate.h:
2209         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
2210         menu from being shown (and causing the DRT to hang).
2211
2212 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
2213
2214         Reviewed by Darin.
2215
2216         Fix DumpRenderTree ObjC bug comparing strings.
2217
2218         * DumpRenderTree/mac/ObjCController.m:
2219         (-[ObjCController identityIsEqual::]): Compare strings with string
2220         equality instead of identiy equality.
2221
2222 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2223
2224         Reviewed by Sam.
2225
2226         Reset the authorAndUserStylesEnabled preference
2227         back to YES for each test. Fixes the broken tests.
2228
2229         * DumpRenderTree/mac/DumpRenderTree.mm:
2230         (resetWebViewToConsistentStateBeforeTesting):
2231
2232 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
2233
2234         Reviewed by Adam.
2235
2236         - Drosera now displays the console window, although it cannot currently
2237         process JavaScript.
2238
2239         * Drosera/win/DebuggerClient.cpp: Shows the console window.
2240         (registerConsoleClass): Implemented.
2241         (consoleWndProc): Implemented.
2242         (DebuggerClient::onSize): Implemented.
2243         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
2244         new window.
2245         * Drosera/win/DebuggerClient.h: Added needed method and members for 
2246         creating and maintaining a new window.
2247         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
2248         lines of code to more appropriate places.
2249         (Drosera::handleCommand):
2250         (Drosera::initUI):
2251         (Drosera::onSize):
2252         (Drosera::attach):
2253
2254 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2255
2256         Reviewed by Dave Hyatt.
2257
2258         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
2259         
2260         Add support for disabling author and user styles for testing.
2261
2262         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2263         * DumpRenderTree/LayoutTestController.cpp:
2264         (setAuthorAndUserStylesEnabledCallback):
2265         (LayoutTestController::staticFunctions):
2266         * DumpRenderTree/LayoutTestController.h:
2267         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2268         (LayoutTestController::setAuthorAndUserStylesEnabled):
2269         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2270         (LayoutTestController::setAuthorAndUserStylesEnabled):
2271
2272 2007-11-26  Dan Bernstein  <mitz@apple.com>
2273
2274         - Tiger build fix.
2275
2276         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2277
2278 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
2279
2280         Reviewed by Maciej.
2281
2282         - Implemented displaying variables for Drosera on Win.
2283
2284         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
2285         that retrieve variables to not hold onto the return value since it's
2286         not returned.  Also changed to use the new signatures of the retrieval
2287         functions.
2288         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2289         (DebuggerDocument::platformValueForScopeVariableNamed):
2290         * Drosera/win/Drosera.cpp: Removed a needless TODO.
2291         (droseraWndProc):
2292
2293 2007-11-26  Sam Weinig  <sam@webkit.org>
2294
2295         Cleanup names of painting and repainting functions.
2296
2297         Reviewed by Adam Roben.
2298
2299         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2300         (drawSelectionRect): was drawSelectionRectIntoContext.
2301         (dumpWebViewAsPixelsAndCompareWithExpected):
2302         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2303         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2304         (paintWebView): was drawWebViewIntoContext.
2305         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
2306
2307 2007-11-26  Sam Weinig  <sam@webkit.org>
2308
2309         Reviewed by Dan Bernstein.
2310
2311         - Leopard build fix
2312
2313         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2314
2315 2007-11-26  Sam Weinig  <sam@webkit.org>
2316
2317         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
2318         Use shared PixelDumpSupport for Mac DRT
2319
2320         Reviewed by Adam Roben.
2321
2322         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2323         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
2324         * DumpRenderTree/cg/ImageDiffCG.cpp:
2325         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2326         (drawSelectionRectIntoContext):
2327         (dumpWebViewAsPixelsAndCompareWithExpected):
2328         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2329         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2330         * DumpRenderTree/mac/DumpRenderTree.mm:
2331         (dump):
2332         * DumpRenderTree/mac/ImageDiff.m: Removed.
2333         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
2334         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
2335         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
2336         (setDefaultColorProfileToRGB):
2337         (getBitmapContextFromWebView):
2338         (drawWebViewIntoContext):
2339         (repaintWithVerticalSweep):
2340         (repaintWithHorizontalSweep):
2341         (getSelectionRect):
2342         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
2343
2344 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
2345
2346         Bug 16052: prepare-ChangeLog doesn't report deleted files
2347         <http://bugs.webkit.org/show_bug.cgi?id=16052>
2348
2349         Reviewed by Sam.
2350
2351         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
2352
2353 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
2354
2355         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
2356         <http://bugs.webkit.org/show_bug.cgi?id=15864>
2357
2358         Reviewed by Adam.
2359
2360         Roll functionality of merge-changelog into resolve-ChangeLogs
2361         script.  The script now checks for ChangeLog.rej and
2362         ChangeLog.orig files first.  If it finds them, it uses the
2363         ChangeLog.rej file as a patch (in old contextual diff format) to
2364         apply with --fuzz=3.
2365
2366         * Scripts/merge-changelog: Removed.
2367         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2368
2369 2007-11-25  Sam Weinig  <sam@webkit.org>
2370
2371         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
2372
2373         Reviewed by Mark Rowe.
2374
2375         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2376         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2377         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2378         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
2379         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
2380
2381 2007-11-25  Sam Weinig  <sam@webkit.org>
2382
2383         Convert DumpRenderTree to ues .xcconfig files.
2384
2385         Reviewed by Mark Rowe.
2386
2387         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2388         * DumpRenderTree/mac/Configurations: Added.
2389         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2390         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2391         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2392
2393 2007-11-25  Sam Weinig  <sam@webkit.org>
2394
2395         Add ForwardingHeaders to wtf for DumpRenderTree.
2396
2397         Reviewed by Mark Rowe.
2398
2399         * DumpRenderTree/DumpRenderTree.h:
2400         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2401         * DumpRenderTree/ForwardingHeaders: Added.
2402         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2403         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2404         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2405         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2406         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2407         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2408         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2409         * DumpRenderTree/LayoutTestController.cpp:
2410         * DumpRenderTree/WorkQueue.cpp:
2411         * DumpRenderTree/mac/DumpRenderTree.mm:
2412         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2413         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2414         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2415         * DumpRenderTree/mac/ObjCController.m:
2416         * DumpRenderTree/mac/UIDelegate.mm:
2417         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2418
2419 2007-11-25  Adam Roben  <aroben@apple.com>
2420
2421         Fix some test failures caused by r28019
2422
2423         Now that stdout is in binary mode, we need to always use printf
2424         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2425         the output.
2426
2427         Reviewed by Sam.
2428
2429         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2430         printf.
2431         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2432         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2433         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2434         (UIDelegate::webViewAddMessageToConsole):
2435
2436 2007-11-25  Adam Roben  <aroben@apple.com>
2437
2438         Set the font smoothing preference in DRT
2439
2440         This makes the pixel results on Windows closer to the Mac results.
2441
2442         Reviewed by Mitz.
2443
2444         * DumpRenderTree/win/DumpRenderTree.cpp:
2445         (initializePreferences):
2446
2447 2007-11-25  Adam Roben  <aroben@apple.com>
2448
2449         Port ImageDiff to CG and C++
2450
2451         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2452         <rdar://5071708>
2453
2454         Reviewed by Sam.
2455
2456         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2457         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2458         (main):
2459         (createImageFromStdin):
2460         (compareImages):
2461         (getDifferenceBitmap):
2462         (computePercentageDifferent):
2463         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2464
2465 2007-11-25  Adam Roben  <aroben@apple.com>
2466
2467         Fix image diff link generation on Windows
2468
2469         Reviewed by Sam.
2470
2471         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2472         to toURL.
2473
2474 2007-11-25  Adam Roben  <aroben@apple.com>
2475
2476         Implement pixel dumping in Windows DRT
2477
2478         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2479         <rdar://5071708>
2480
2481         Reviewed by Sam.
2482
2483         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2484         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2485         Content-Length header.
2486         (getMD5HashStringForBitmap):
2487         (dumpWebViewAsPixelsAndCompareWithExpected):
2488         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2489         * DumpRenderTree/win/DumpRenderTree.cpp:
2490         (dump): Do a pixel dump if requested.
2491         (main): Parse pixel test options.
2492         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2493         the cg/ subdirectory to the include path.
2494         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2495         available in a header or import library, so we have to go through this
2496         LoadLibrary/GetProcAddress dance to use them.
2497         (cryptDLL):
2498         (init):
2499         (update):
2500         (final):
2501         (MD5_Init):
2502         (MD5_Update):
2503         (MD5_Final):
2504         * DumpRenderTree/win/MD5.h: Added.
2505         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2506         moved up to the top level to share it with Mac eventually.
2507         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2508         (getBitmapContextFromWebView): Forces the WebView to paint using a
2509         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2510
2511 2007-11-25  Adam Roben  <aroben@apple.com>
2512
2513         Clean up Windows DRT's option parsing a little bit
2514
2515         Reviewed by Sam.
2516
2517         * DumpRenderTree/win/DumpRenderTree.cpp:
2518         (main): Put non-option arguments into a Vector.
2519
2520 2007-11-25  Adam Roben  <aroben@apple.com>
2521
2522         Make Windows DRT stop changing LF into CRLF
2523
2524         Reviewed by Sam.
2525
2526         * DumpRenderTree/win/DumpRenderTree.cpp:
2527         (main): Put stdout in binary mode.
2528         * Scripts/run-webkit-tests: Remove the CRLF hack.
2529
2530 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2531
2532         Removed empty directory.
2533
2534         * Scripts/resources: Removed.
2535
2536 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2537
2538         Fix bisect-builds to work with recent WebKit nightly builds.
2539
2540         Reviewed by Dan.
2541
2542         * Scripts/bisect-builds: Check for the 
2543         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2544         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2545         to WebKit.app/Contents/Resources.
2546
2547 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2548
2549         Reviewed by Maciej.
2550
2551         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2552         not closed (affects digg.com)
2553
2554         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2555         one after finishing with a test to avoid having its delayed onload handler firing when
2556         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2557         but it helps somewhat.
2558
2559 2007-11-22  Mark Rowe  <mrowe@apple.com>
2560
2561         Reviewed by Alp Toker.
2562
2563         Fix build-webkit to propagate make's exit status if it fails.
2564
2565         * Scripts/webkitdirs.pm:
2566
2567 2007-11-22  Dan Bernstein  <mitz@apple.com>
2568
2569         Reviewed by Mark Rowe.
2570
2571         - fix crash when running pixel tests
2572
2573         * DumpRenderTree/mac/DumpRenderTree.mm:
2574         (dumpRenderTree): Parse the command line options before setting up the
2575         environment so that we know if we need to set up the pixel dump
2576         machinery.
2577
2578 2007-11-21  Eric Seidel  <eric@webkit.org>
2579
2580         Speculative build fix for Tiger.
2581
2582         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2583
2584 2007-11-21  Eric Seidel  <eric@webkit.org>
2585
2586         Reviewed by Tim Hatcher.
2587
2588         Break out more of DumpRenderTree.mm into individual files
2589
2590         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2591         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2592         (checkedMalloc):
2593         (checkedRealloc):
2594         (makeLargeMallocFailSilently):
2595         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2596         * DumpRenderTree/mac/DumpRenderTree.mm:
2597         (crashHandler):
2598         (dump):
2599         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2600         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2601         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2602         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2603         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2604         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2605         (javaScriptThreads):
2606         (runJavaScriptThread):
2607         (startJavaScriptThreads):
2608         (stopJavaScriptThreads):
2609         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2610         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2611         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2612         (restoreColorSpace):
2613         (setDefaultColorProfileToRGB):
2614         (initializeColorSpaceAndScreeBufferForPixelTests):
2615         (md5HashStringForBitmap):
2616         (dumpWebViewAsPixelsAndCompareWithExpected):
2617
2618 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2619
2620         Move install-unix-extras to wx directory as it seems only to be used by that 
2621         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2622         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2623         have install-unix-extras install into WebKitLibraries as per
2624         convention.
2625         
2626         Reviewed by Mark Rowe.
2627
2628         * Scripts/install-unix-extras: Removed.
2629         * wx/build-wxwebkit:
2630         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2631
2632 2007-11-21  Eric Seidel  <eric@webkit.org>
2633
2634         Reviewed by Adam.
2635
2636         More refactoring for greater code readability
2637
2638         * DumpRenderTree/mac/DumpRenderTree.mm:
2639         (initializeGlobalsFromCommandLineOptions):
2640         (initializeColorSpaceAndScreeBufferForPixelTests):
2641         (addTestPluginsToPluginSearchPath):
2642         (useLongRunningServerMode):
2643         (runTestingServerLoop):
2644         (prepareConsistentTestingEnvironment):
2645         (dumpRenderTree):
2646         (main):
2647         (dumpFramesAsText):
2648         (dumpBackForwardListForWebView):
2649         (sizeWebViewForCurrentTest):
2650         (methodNameStringForFailedTest):
2651         (dumpBackForwardListForAllWindows):
2652         (dumpWebViewAsPixelsAndCompareWithExpected):
2653         (invalidateAnyPreviousWaitToDumpWatchdog):
2654         (dump):
2655         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2656         * DumpRenderTree/mac/UIDelegate.mm:
2657         (-[UIDelegate webView:createWebViewWithRequest:]):
2658
2659 2007-11-21  Eric Seidel  <eric@webkit.org>
2660
2661         Reviewed by Tim Hatcher.
2662
2663         Abstract more of DRT into static methods
2664
2665         * DumpRenderTree/mac/DumpRenderTree.mm:
2666         (setDefaultsToConsistentValuesForTesting):
2667         (setupSignalHandlers):
2668         (allocateGlobalControllers):
2669         (releaseAndZero):
2670         (releaseGlobalControllers):
2671         (dumpRenderTree):
2672         (shouldLogFrameLoadDelegates):
2673         (createCFURLFromPathOrURL):
2674         (resetWebViewToConsistentStateBeforeTesting):
2675         (runTest):
2676
2677 2007-11-21  Eric Seidel  <eric@webkit.org>
2678
2679         Reviewed by Tim Hatcher.
2680
2681         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2682
2683         * DumpRenderTree/DumpRenderTree.h:
2684         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2685         * DumpRenderTree/mac/DumpRenderTree.mm:
2686         (dumpRenderTree):
2687         (dump):
2688         (runTest):
2689         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2690         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2691         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2692         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2693         (-[DumpRenderTreePasteboard declareType:owner:]):
2694         (+[LocalPasteboard alloc]):
2695         (-[LocalPasteboard init]):
2696         (-[LocalPasteboard dealloc]):
2697         (-[LocalPasteboard name]):
2698         (-[LocalPasteboard releaseGlobally]):
2699         (-[LocalPasteboard declareTypes:owner:]):
2700         (-[LocalPasteboard addTypes:owner:]):
2701         (-[LocalPasteboard changeCount]):
2702         (-[LocalPasteboard types]):
2703         (-[LocalPasteboard availableTypeFromArray:]):
2704         (-[LocalPasteboard setData:forType:]):
2705         (-[LocalPasteboard dataForType:]):
2706         (-[LocalPasteboard setPropertyList:forType:]):
2707         (-[LocalPasteboard setString:forType:]):
2708         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2709         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2710         (+[DumpRenderTreeWindow allWindows]):
2711         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2712         (-[DumpRenderTreeWindow dealloc]):
2713         (-[DumpRenderTreeWindow isKeyWindow]):
2714         (-[DumpRenderTreeWindow keyDown:]):
2715
2716 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2717
2718         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2719         it indiscriminately copies any headers inside JavaScriptCore,
2720         which includes Tiger ICU headers. 
2721
2722         * wx/build-wxwebkit:
2723         Don't run WebCore/move-js-headers.sh any longer.
2724
2725 2007-11-20  Adam Treat  <treat@kde.org>
2726
2727         Reviewed by David Kilzer.
2728
2729         * Prepend git branch name to $baseProductDir
2730
2731         * Scripts/VCSUtils.pm:
2732         * Scripts/webkitdirs.pm:
2733
2734 2007-11-20  Mark Rowe  <mrowe@apple.com>
2735
2736         Reviewed by Simon Hausmann.
2737
2738         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2739         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2740         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2741         built product and generated Makefile's are removed.
2742
2743 2007-11-19  Alp Toker  <alp@atoker.com>
2744
2745         Reviewed by Mark Rowe.
2746
2747         http://bugs.webkit.org/show_bug.cgi?id=16040
2748         [GTK] GtkLauncher should be written in C
2749
2750         Port GtkLauncher to plain C.
2751
2752         Use a more conventional GTK+ coding style.
2753
2754         Use a toolbar instead of menus.
2755
2756         Various signature fixes and cleanups.
2757
2758         Add a license header. Assume all previous modifications were copyright
2759         assigned to Apple Inc. by default.
2760
2761         * GtkLauncher/GtkLauncher.pro:
2762         * GtkLauncher/main.c: Added.
2763         (activate_url_entry_cb):
2764         (update_title):
2765         (link_hover_cb):
2766         (title_change_cb):
2767         (progress_change_cb):
2768         (destroy_cb):
2769         (go_back_cb):
2770         (go_forward_cb):
2771         (create_browser):
2772         (create_statusbar):
2773         (create_toolbar):
2774         (create_window):
2775         (main):
2776         * GtkLauncher/main.cpp: Removed.
2777
2778 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2779
2780         Build script fixes to ensure they do the right thing for the 
2781         wx port, and update build-wxwebkit to reflect the way the
2782         build scripts now work.
2783
2784         Reviewed by Adam.
2785
2786         * Scripts/build-testkjs:
2787         * Scripts/build-webkit:
2788         * Scripts/run-javascriptcore-tests:
2789         * Scripts/webkitdirs.pm:
2790         * wx/build-wxwebkit:
2791
2792 2007-11-18  Eric Seidel  <eric@webkit.org>
2793
2794         Reviewed by Anders.
2795
2796         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2797
2798         * Scripts/run-javascriptcore-tests:
2799
2800 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2801
2802         Reviewed by Adam Roben.
2803
2804         Make run-webkit-tests work with Windows debug build.
2805
2806         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2807         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2808         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2809         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2810         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2811
2812 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2813
2814         Add wxWebKit sample and build script, and integrate it with 
2815         build-webkit. Also make build-webkit --clean work for all
2816         ports.
2817
2818         Reviewed by Darin Adler.
2819
2820         * Scripts/build-webkit:
2821         * Scripts/webkitdirs.pm:
2822         * wx: Added.
2823         * wx/browser: Added.
2824         * wx/browser/browser.bkl: Added.
2825         * wx/browser/browser.cpp: Added.
2826         * wx/build-wxwebkit: Added.
2827
2828 2007-11-17  Adam Roben  <aroben@apple.com>
2829
2830         Make it easy to run Safari in the debugger on Windows
2831
2832         I've added a new script, debug-safari, which launches Safari in the
2833         debugger. On OS X it just calls gdb-safari.
2834
2835         Reviewed by Mark Rowe.
2836
2837         * FindSafari/FindSafari.cpp:
2838         (_tmain): Added a /debugger flag, which in combination with
2839         /printSafariLauncher will print a script that launches Safari in the
2840         debugger.
2841         * Scripts/debug-safari: Added.
2842         * Scripts/run-safari: Changed to call runSafari().
2843         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2844         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2845         first argument along to FindSafari.
2846         * Scripts/webkitdirs.pm:
2847         (sub runSafari): Added.
2848
2849 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2850
2851         Reviewed by Adam Roben.
2852
2853         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2854
2855 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2856
2857         Reviewed by David Kilzer.
2858
2859         The git config command was renamed to repo-config at some point. This
2860         change tries git config and then git repo-config if the first fails.
2861
2862         * Scripts/prepare-ChangeLog:
2863         (gitConfig):
2864
2865 2007-11-16  Dan Bernstein  <mitz@apple.com>
2866
2867         Reviewed by Darin Adler and Sam Weinig.
2868
2869         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2870
2871         * DumpRenderTree/win/EventSender.cpp:
2872         (keyDownCallback): For characters that cannot be entered on the active
2873         keyboard layout, send a WM_CHAR message with the character along with
2874         a WM_KEYDOWN message with a virtual key code of 255.
2875
2876 2007-11-16  Mark Rowe  <mrowe@apple.com>
2877
2878         Reviewed by Tim Hatcher.
2879
2880         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2881
2882         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2883         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2884
2885 2007-11-15  Adam Roben  <aroben@apple.com>
2886
2887         Make run-safari actually work on Windows
2888
2889         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2890         chdir call.
2891
2892 2007-11-14  Adam Roben  <aroben@apple.com>
2893
2894         Updates to Safari launching now that 3.0.4 is released
2895
2896         Reviewed by Sam.
2897
2898         * FindSafari/FindSafari.cpp:
2899         (getWebViewCLSID): Use version-independent ProgID.
2900         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2901
2902 2007-11-14  Anders Carlsson  <andersca@apple.com>
2903
2904         Reviewed by Adam.
2905
2906         <rdar://problem/5309081>
2907         In DRT, "plugin.logDestroy = true" not working on Windows.
2908         
2909         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2910         (NPP_Destroy):
2911
2912 2007-11-14  Eric Seidel  <eric@webkit.org>
2913
2914         Reviewed by Sam.
2915
2916         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2917
2918 2007-11-14  Anders Carlsson  <andersca@apple.com>
2919
2920         Reviewed by Adam.
2921
2922         <rdar://problem/5141186>
2923         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2924         
2925         Implement setWindowIsKey.
2926         
2927         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2928         (LayoutTestController::setWindowIsKey):
2929
2930 2007-11-13  Sam Weinig  <sam@webkit.org>
2931
2932         Reviewed by Adam Roben.
2933
2934         Fix for <rdar://problem/5382579>
2935         http/tests/security/cross-frame-access-put.html reports large 
2936         negative numbers for screenLeft and screenTop (Mac reports "0")
2937
2938         * DumpRenderTree/win/UIDelegate.cpp:
2939         (UIDelegate::UIDelegate): Initialize the RECT.
2940         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2941         (UIDelegate::webViewFrame): ditto.
2942         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2943
2944 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2945
2946         Reviewed by Adam.
2947
2948         - Make Drosera show source, source URLs, and function stack on Windows,
2949         and some minor fixes.
2950
2951         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2952         (DebuggerDocument::updateFileSource):
2953         * Drosera/debugger.js: Force source to always update display.
2954         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2955         menu controls.
2956         (DebuggerClient::resume):
2957         (DebuggerClient::pause):
2958         (DebuggerClient::stepInto):
2959         (DebuggerClient::stepOver):
2960         (DebuggerClient::stepOut):
2961         (DebuggerClient::showConsole):
2962         (DebuggerClient::closeCurrentFile):
2963         * Drosera/win/DebuggerClient.h: Ditto.
2964         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2965         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2966         removed two bugs.  1) caller could be in a bad state when asked to
2967         assign into it. 2) BSTRs were not created correctly.
2968         (DebuggerDocument::getPlatformCurrentFunctionStack):
2969         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2970         (droseraWndProc):
2971         (handleCommand):
2972         (Drosera::resume):
2973         (Drosera::pause):
2974         (Drosera::stepInto):
2975         (Drosera::stepOver):
2976         (Drosera::stepOut):
2977         (Drosera::showConsole):
2978         (Drosera::closeCurrentFile):
2979         * Drosera/win/Drosera.h: Hook up the menu controls.
2980         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2981         functions, added a null check, and fixed another bug where caller could
2982         be in a bad state when asked to assign into it.
2983         (ServerConnection::didLoadMainResourceForDataSource):
2984         (ServerConnection::getCallerFrame):
2985         * Drosera/win/ServerConnection.h: Safety first.
2986
2987 2007-11-13  Dan Bernstein  <mitz@apple.com>
2988
2989         Reviewed by Darin Adler.
2990
2991         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2992           DumpRenderTree --pixel-tests renders each test twice
2993
2994         * DumpRenderTree/mac/DumpRenderTree.mm:
2995         (dumpRenderTree): Removed the --paint option because the painting code
2996         is always exercised as a result of
2997         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2998         calling -displayIfNeeded.
2999         (dump): Changed to always grab the image from the window since the view
3000         is always displayed.
3001         (runTest):
3002         (displayWebView):
3003         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
3004         because it always paints.
3005
3006 2007-11-12  Antti Koivisto  <antti@apple.com>
3007
3008         Reviewed by Adele.
3009         
3010         Add support for http media tests
3011
3012         * Scripts/run-webkit-tests:
3013
3014 2007-11-12  Sam Weinig  <sam@webkit.org>
3015
3016         Reviewed by Adam Roben.
3017
3018         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
3019
3020         * DumpRenderTree/win/DumpRenderTree.cpp:
3021         (runTest):
3022         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3023         (LayoutTestController::setPrivateBrowsingEnabled):
3024
3025 2007-11-12  Adam Roben  <aroben@apple.com>
3026
3027         * Scripts/update-webkit-localizable-strings: Changed to only scan the
3028         mac and win subdirectories.
3029
3030 2007-11-11  Adam Roben  <aroben@apple.com>
3031
3032         Fix <rdar://5133816> keepWebHistory is not implemented
3033
3034         Fixes fast/history/clicked-link-is-visited.html.
3035
3036         Reviewed by Darin.
3037
3038         * DumpRenderTree/win/DumpRenderTree.cpp:
3039         (runTest): Clear the optionalSharedHistory.
3040         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3041         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
3042
3043 2007-11-10  Sam Weinig  <sam@webkit.org>
3044
3045         Reviewed by Tim Hatcher.
3046
3047         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
3048         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
3049         is turned on)
3050
3051         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
3052
3053         Added test: http/tests/security/cross-frame-access-private-browsing.html
3054
3055         * DumpRenderTree/LayoutTestController.cpp:
3056         (setPrivateBrowsingEnabledCallback):
3057         (LayoutTestController::staticFunctions):
3058         * DumpRenderTree/LayoutTestController.h:
3059         * DumpRenderTree/mac/DumpRenderTree.mm:
3060         (runTest): Default to private browsing disabled.
3061         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3062         (LayoutTestController::setPrivateBrowsingEnabled):
3063         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3064         (LayoutTestController::setPrivateBrowsingEnabled):
3065
3066 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3067
3068         Reviewed by Adam.
3069
3070         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
3071         WebCore's!
3072
3073         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3074         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
3075         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3076         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3077         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
3078         * Drosera/win/Drosera.cpp:
3079         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3080
3081 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3082
3083         Reviewed by Sam.
3084
3085         - Use the new IWebFrame [local] function signature and get the shared
3086         server correctly.
3087
3088         * Drosera/win/DebuggerClient.cpp:
3089         (DebuggerClient::didFinishLoadForFrame):
3090         * Drosera/win/ServerConnection.cpp:
3091         (ServerConnection::attemptToCreateServerConnection):
3092
3093 2007-11-07  Dan Bernstein  <mitz@apple.com>
3094
3095         Reviewed by Darin Adler.
3096
3097         - add an option to run-webkit-tests to ignore pixel test failures where
3098           all pixels differ by no more than a specified threshold
3099
3100         * DumpRenderTree/mac/ImageDiff.m:
3101         (main):
3102         (compareImages):
3103         (computePercentageDifferent):
3104         * Scripts/run-webkit-tests:
3105
3106 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3107
3108         Reviewed by Lars.
3109
3110         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
3111
3112         * DumpRenderTree/qt/DumpRenderTree.cpp:
3113
3114 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3115
3116         Reviewed by Lars.
3117
3118         Reworked the QWebSettings API.
3119         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
3120
3121         * DumpRenderTree/qt/DumpRenderTree.cpp:
3122
3123 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3124
3125         Reviewed by Lars.
3126
3127         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
3128
3129         * DumpRenderTree/qt/jsobjects.cpp:
3130
3131 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3132
3133         Reviewed by Lars Knoll <lars@trolltech.com>.
3134
3135         Add a QWebPage::frameCreated() signal and fix DRT
3136         
3137         The removal of createFrame in QWebPage broke the re-implementation
3138         in DumpRenderTree. Instead emit a frameCreated() signal and
3139         connect to it in DumpRenderTree.
3140         
3141
3142         * DumpRenderTree/qt/DumpRenderTree.cpp:
3143         (WebCore::WebPage::WebPage):
3144         (WebCore::DumpRenderTree::dump):
3145         (WebCore::DumpRenderTree::connectFrame):
3146         * DumpRenderTree/qt/DumpRenderTree.h:
3147
3148 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3149
3150         Reviewed by Lars Knoll <lars@trolltech.com>.
3151
3152         Moved all the event handlers from QWebFrame into QWebPage.
3153         
3154         This cleans up the public API and allows us to remove the
3155         HackWebFrame hack in DumpRenderTree.
3156         
3157
3158         * DumpRenderTree/qt/jsobjects.cpp:
3159         (EventSender::mouseDown):
3160         (EventSender::mouseUp):
3161         (EventSender::mouseMoveTo):
3162
3163 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3164
3165         Reviewed by Mark.
3166
3167         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
3168         to prevent the default implementation from popping up messageboxes.
3169
3170         * DumpRenderTree/qt/DumpRenderTree.cpp:
3171         (WebCore::WebPage::javaScriptConfirm):
3172         (WebCore::WebPage::javaScriptPrompt):
3173
3174 2007-11-06  Eric Seidel  <eric@webkit.org>
3175
3176         * Scripts/build-testkjs: build fix... too many $$
3177
3178 2007-11-06  Eric Seidel  <eric@webkit.org>
3179
3180         Reviewed by Mark Rowe.
3181
3182         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
3183
3184 2007-11-05  Adam Roben  <aroben@apple.com>
3185
3186         Add support on Windows for WEBKIT_TESTFONTS
3187
3188         This environment variable lets you specify where the fonts to be used
3189         by DumpRenderTree reside. The Qt port is already using this, so I'm
3190         just following their lead.
3191
3192         Reviewed by Darin.
3193
3194         * DumpRenderTree/win/DumpRenderTree.cpp:
3195         (exePath): Refactored code out of initialize().
3196         (fontsPath): Returns either $WEBKIT_TESTFONTS or
3197         DumpRenderTree.resources.
3198         (initialize): Use the new fontsPath function.
3199         (main): Use the new exePath function.
3200         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
3201         variable to DRT, like Qt does.
3202
3203 2007-11-05  Mark Rowe  <mrowe@apple.com>
3204
3205         Rubber-stamped by Alp Toker.
3206
3207         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
3208
3209         * GtkLauncher/main.cpp:
3210         (goToURLBarText):
3211         (main):
3212
3213 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
3214
3215         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
3216         <http://bugs.webkit.org/show_bug.cgi?id=15830>
3217
3218         Reviewed by Timothy.
3219
3220         Restrict the range of nightly builds used by the bisect-builds script
3221         based on the version of Safari and the version of Mac OS X being used.
3222
3223         Mac OS X 10.4: Safari 2.0: r11976 or newer
3224         Mac OS X 10.4: Safari 3.0: r19992 or newer
3225
3226         Mac OS X 10.5: Safari 2.0: r19594 or newer
3227         Mac OS X 10.5: Safari 3.0: r25124 or newer
3228
3229         * Scripts/bisect-builds:
3230         (findMacOSXVersion): Added.
3231         (makeNightlyList): Added argument to provide version of Mac OS X.
3232         Restrict range of nightly builds based on Safari and Mac OS X versions.
3233
3234 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
3235
3236         Reviewed by Maciej.
3237
3238         - This patch involves several changes, all of them were noticed that
3239         they were needed by the work being done in WebKit to get Drosera and
3240         WebKit working together on Windows.
3241         - The changes are:
3242         1) Added a debugger console for output messages.
3243         2) Drosera now listens for the WebKit server (before, the server would
3244         have to be running before Drosera was started.)
3245         3) Fixed a bug where the WebView started out as 0x0 pixels.
3246         4) Fixed a bug when there is no scope.
3247         5) Added the HTML, JS, and CSS to the project file to make them easy to
3248         find.
3249         6) Made the ServerConnection functions virtual.
3250
3251         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
3252         for the WebKit server.
3253         (DebuggerClient::DebuggerClient):
3254         (DebuggerClient::~DebuggerClient):
3255         (DebuggerClient::didFinishLoadForFrame):
3256         (DebuggerClient::serverConnected):
3257         (DebuggerClient::attemptToCreateServerConnection):
3258         * Drosera/win/DebuggerClient.h: Ditto.
3259         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
3260         scope.
3261         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3262         (DebuggerDocument::platformValueForScopeVariableNamed):
3263         * Drosera/win/Drosera.cpp:
3264         (_tWinMain): Added a console in debug for output messages.
3265         (Drosera::Drosera): Listen for server.
3266         (Drosera::initUI): The server now Initializes COM.
3267         (Drosera::serverConnected): Part of the listening for the server.
3268         (Drosera::attemptToCreateServerConnection): Ditto.
3269         * Drosera/win/Drosera.h: New interface for listening for the server.
3270         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
3271         files to the VS project.
3272         * Drosera/win/ServerConnection.cpp: Part of listening for the server
3273         connection.
3274         (ServerConnection::ServerConnection):
3275         (ServerConnection::attemptToCreateServerConnection):
3276         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
3277         methods.
3278         (ServerConnection::serverConnected):
3279
3280 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
3281
3282         Reviewed by Maciej.
3283
3284         http://bugs.webkit.org/show_bug.cgi?id=15832
3285         fast/dom/gc-10.html crashes when run alone
3286
3287         Check for !done before using objects that can be already deallocated.
3288
3289         * DumpRenderTree/mac/EditingDelegate.mm:
3290         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3291         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3292         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3293         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3294         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3295         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3296         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3297         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3298         (-[EditingDelegate webViewDidBeginEditing:]):
3299         (-[EditingDelegate webViewDidChange:]):
3300         (-[EditingDelegate webViewDidEndEditing:]):
3301         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3302         (-[EditingDelegate webViewDidChangeSelection:]):
3303         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3304         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3305         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3306         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3307         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3308         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3309         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3310         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3311         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3312         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3313         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3314         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3315         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3316         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3317         (-[FrameLoadDelegate webView:willCloseFrame:]):
3318         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3319         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3320         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3321         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3322         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3323         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3324         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3325         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3326         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3327
3328 2007-11-04  Mark Rowe  <mrowe@apple.com>
3329
3330         Build fix.  Don't use Carbon.h as the prefix header as it triggers
3331         warnings that would otherwise be suppressed due to it being a system header.
3332
3333         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3334
3335 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
3336
3337         Rubber stamped by Adam.
3338         
3339         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
3340
3341         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3342
3343 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3344
3345         Sort files(...); sections of Xcode project files.
3346
3347         Rubber-stamped by Darin.
3348
3349         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3350         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3351         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3352         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3353
3354 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3355
3356         Script to sort "files(...);" sections in Xcode project.pbxproj files.
3357
3358         Reviewed by Darin.
3359
3360         * Scripts/sort-Xcode-project-file: Added.
3361
3362 2007-11-02  Darin Adler  <darin@apple.com>
3363
3364         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
3365
3366 2007-11-02  Darin Adler  <darin@apple.com>
3367
3368         Reviewed by Maciej.
3369
3370         * Scripts/run-sunspider: Pass the "--base" option through.
3371
3372         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
3373         the real script do that. Default configuration to Release to match run-sunspider
3374         so we don't end up building Debug just to compare results.
3375
3376 2007-11-01  Adam Roben  <aroben@apple.com>
3377
3378         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
3379
3380         Reviewed by Sam.
3381
3382         * Scripts/commit-log-editor: Show all the directories beneath the
3383         source root, instead of just the last one.
3384
3385 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
3386
3387         Reviewed by Adam Roben.
3388
3389         Print out an error message when the Windows build fails
3390         and provide guidance on how to find out what went wrong.
3391
3392         * Scripts/build-webkit:
3393         * Scripts/webkitdirs.pm:
3394
3395 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
3396
3397         Rubber-stamped by Adam Roben.
3398
3399         Rolled out r27326 - debug CRT seems to cause no problems after all.
3400
3401         * DumpRenderTree/win/DumpRenderTree.vcproj:
3402
3403 2007-10-31  Adam Roben  <aroben@apple.com>
3404
3405         Switch the Debug configuration to using the non-debug CRT
3406
3407         This matches WebKit.
3408
3409         Reviewed by Steve.
3410
3411         * DumpRenderTree/win/DumpRenderTree.vcproj:
3412
3413 2007-10-31  Antti Koivisto  <antti@apple.com>
3414
3415         Reviewed by bdash.
3416         
3417         Disable media tests when doing leak checking on Tiger.
3418         They crash in QuickTime (rdar://problem/5537157).
3419
3420         * Scripts/run-webkit-tests:
3421
3422 2007-10-29  Antti Koivisto  <antti@apple.com>
3423
3424         Reviewed by Maciej.
3425         
3426         Build media support by default on OSX only.
3427
3428         * Scripts/build-webkit:
3429
3430 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3431
3432         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
3433         get caught by the pre-commit hooks.
3434
3435 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3436
3437         Reviewed by Adam.
3438
3439         - This is a collection of relatively unrelated changes and cleanups
3440         to Drosera to prepare it for interacting with WebKit.  A lot of these
3441         changes are just correcting mistakes, for example removing included
3442         headers that are no longer needed.
3443
3444         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3445         this will be needed by the DebuggerClient.
3446         (DebuggerDocument::server):
3447         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3448         * Drosera/win/DebuggerClient.cpp: 
3449         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3450         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3451         (DebuggerClient::createWebViewWithRequest): Added comment about its
3452         purpose. 
3453         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3454         declarations.
3455         (DebuggerClient::webViewLoaded): Moved.
3456         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3457         file, since this was the only place it was used.
3458         (cfStringToBSTR):
3459         * Drosera/win/Drosera.h: Cleaned up the includes.
3460         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3461         * Drosera/win/HelperFunctions.h: Removed.
3462
3463 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3464
3465         Reviewed by Adam.
3466
3467         - Small cleanup in the ServerConnection class.
3468
3469         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3470         and added an include.
3471         (ServerConnection::currentFrame):
3472         (ServerConnection::getCallerFrame):
3473         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3474         made a pointer into a COMPtr, and cleaned up the includes.
3475
3476 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3477
3478         Reviewed by John Sullivan.
3479         
3480         - Place the Localizable.strings file in mac or win directories
3481           if that location exists.
3482         - Also look for UI_STRING in .c files.
3483
3484         * Scripts/extract-localizable-strings:
3485
3486 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3487
3488         Reviewed by Adam.
3489
3490         - Set the eol-style to native and made all the line endings the same
3491         so that I avoid messy diffs that show eol changes.
3492
3493         * Drosera/win/ServerConnection.cpp:
3494         (ServerConnection::didParseSource):
3495         (ServerConnection::didEnterCallFrame):
3496         (ServerConnection::willExecuteStatement):
3497         (ServerConnection::willLeaveCallFrame):
3498         (ServerConnection::exceptionWasRaised):
3499
3500 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3501
3502         Reviewed by Adam.
3503
3504         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3505         functionality that could not have existed previously without the new
3506         interfaces.
3507         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3508         from a BSTR to a JSValueRef.
3509         (DebuggerDocument::platformEvaluateScript): Implemented.
3510         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3511         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3512         Implemented.
3513         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3514         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3515         * Drosera/win/ServerConnection.cpp: Added a helper function.
3516         (ServerConnection::getCallerFrame):
3517         * Drosera/win/ServerConnection.h: Added a helper function.
3518
3519 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3520
3521         updated reviewers for my previous changelog.
3522
3523 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3524         Reviewed by Maciej and Adam and Geoff.
3525
3526         - Minor mac-side improvements including moving a function to a more
3527         appropriate location, fixing a warning, and correctly checking
3528         exceptions.
3529
3530         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3531         (DebuggerDocument::willExecuteStatement):
3532         (DebuggerDocument::didEnterCallFrame):
3533         (DebuggerDocument::willLeaveCallFrame):
3534         (DebuggerDocument::windowScriptObjectAvailable):
3535         (DebuggerDocument::callFunctionOnObject):
3536         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3537         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3538         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3539         because it doesn't require the ServerConnection at all.
3540         (NSStringCreateWithJSStringRef): Made an argument const.
3541         (JSValueRefCreateWithNSString): Made an argument const.
3542         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3543         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3544         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3545         * Drosera/mac/ServerConnection.mm: Ditto.
3546         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3547
3548 2007-10-29  Sam Weinig  <sam@webkit.org>
3549
3550         Reviewed by Adam Roben.
3551
3552         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3553
3554         * DumpRenderTree/LayoutTestController.cpp:
3555         (LayoutTestController::LayoutTestController):
3556         (getGlobalFlagCallback):
3557         (setGlobalFlagCallback):
3558         (LayoutTestController::getJSClass):
3559         (LayoutTestController::staticValues):
3560         * DumpRenderTree/LayoutTestController.h:
3561         (LayoutTestController::globalFlag):
3562         (LayoutTestController::setGlobalFlag):
3563
3564 2007-10-29  Darin Adler  <darin@apple.com>
3565
3566         Reviewed by Maciej.
3567
3568         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3569         resolution instead of its default.
3570
3571 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3572
3573         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3574
3575         Reviewed by Mark Rowe.
3576
3577         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3578         was successfully resolved, but this would not show any status because the change had
3579         already been cached in the index using "git add".  The solution is to add an optional
3580         second argument to showStatus() which adds the "--cached" switch to the command.
3581
3582         * Scripts/resolve-ChangeLogs:
3583         (showStatus):
3584
3585 2007-10-28  Eric Seidel  <eric@webkit.org>
3586
3587         Reviewed by Maciej and Geoff, in unison.
3588
3589         * Scripts/run-webkit-tests: remove broken --svg option
3590
3591 2007-10-28  Darin Adler  <darin@apple.com>
3592
3593         Reviewed by Adam.
3594
3595         * Scripts/run-sunspider: Default to "Release" configuration rather than
3596         defaulting to the last configuration used as other scripts do. This can
3597         still be overriden on the command line with "--debug" if there's some
3598         reason to do so. Also fix a typo.
3599
3600         * Scripts/sunspider-compare-results: Fix a typo.
3601
3602 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3603
3604         Reviewed by Adam.
3605
3606         - Implemented the WebScriptDebugListener functions now that the
3607         WebScriptDebugServer exists
3608
3609         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3610         functions.
3611         (ServerConnection::currentFrame):
3612         (ServerConnection::didLoadMainResourceForDataSource):
3613         (ServerConnection::didParseSource):
3614         (ServerConnection::failedToParseSource):
3615         (ServerConnection::didEnterCallFrame):
3616         (ServerConnection::willExecuteStatement):
3617         (ServerConnection::willLeaveCallFrame):
3618         (ServerConnection::exceptionWasRaised):
3619         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3620         members arguments list.
3621
3622 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3623
3624         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3625         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3626
3627         Reviewed by Darin.
3628
3629         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3630         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3631         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3632         file.  Note that it may also be used as a stand-alone script.
3633
3634         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3635         * Scripts/resolve-ChangeLogs: Added.
3636         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3637
3638 2007-10-26  Mark Rowe  <mrowe@apple.com>
3639
3640         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3641         to the Qt port on the assumption that it was an implementation of the cross-platform
3642         LayoutTestController class.  It is not, so it did not need to be changed.
3643
3644         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3645
3646 2007-10-25  Mark Rowe  <mrowe@apple.com>
3647
3648         Reviewed by Maciej.
3649
3650         Fix builds with code coverage enabled.
3651
3652         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3653
3654 2007-10-25  Darin Adler  <darin@apple.com>
3655
3656         Reviewed by Mark Rowe.
3657
3658         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3659         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3660
3661 2007-10-25  Stephanie  <slewis@apple.com>
3662
3663         build Fix
3664
3665         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3666
3667 2007-10-25  Stephanie  <slewis@apple.com>
3668
3669         Reviewed by Mark Rowe, Adam Roben.
3670
3671         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3672
3673         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
3674
3675 2007-10-25  Alice Liu  <alice.liu@apple.com>
3676
3677         Reviewed by Adam.
3678
3679         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3680
3681         Moving destructor into platform-specific files
3682         * DumpRenderTree/LayoutTestController.cpp:
3683         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3684         (LayoutTestController::~LayoutTestController):
3685         * DumpRenderTree/qt/jsobjects.cpp:
3686         (LayoutTestController::~LayoutTestController):
3687
3688         LayoutTestController wasn't being destroyed
3689         * DumpRenderTree/win/DumpRenderTree.cpp:
3690         (runTest):
3691
3692         Added declspec
3693         * DumpRenderTree/win/EditingDelegate.h:
3694
3695         Reset certain values on the webview (or related delegate) that might 
3696         have changed while running a test
3697         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3698         (LayoutTestController::~LayoutTestController):
3699
3700 2007-10-25  Adam Roben  <aroben@apple.com>
3701
3702         Make sunspider-compare-results work with relative paths
3703
3704         Reviewed by Sam.
3705
3706         * Scripts/sunspider-compare-results: Convert arguments to absolute
3707         paths before we chdir.
3708
3709 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3710
3711         Reviewed by Sam.
3712
3713         - Implemented server calls now the WebScriptDebugServer exists.
3714         - Also removed no longer needed call to initialize CG.
3715
3716         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3717         automatically now.
3718         (_tWinMain):
3719         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3720         (ServerConnection::ServerConnection):
3721         (ServerConnection::~ServerConnection):
3722         (ServerConnection::pause):
3723         (ServerConnection::resume):
3724         (ServerConnection::stepInto):
3725         (ServerConnection::applicationTerminating):
3726         (ServerConnection::serverConnectionDidDie):
3727         * Drosera/win/ServerConnection.h: Now uses the COM class.
3728
3729 2007-10-24  George Staikos  <staikos@kde.org>
3730
3731         Unbreak Qt build.
3732
3733         * Scripts/build-webkit:
3734
3735 2007-10-24  Adam Roben  <aroben@apple.com>
3736
3737         Remove now-unnecessary call to InitializeCoreGraphics
3738
3739         WebKit takes care of this now.
3740
3741         Reviewed by Ada.
3742
3743         * DumpRenderTree/win/DumpRenderTree.cpp:
3744         (initialize):
3745
3746 2007-10-24  Adam Roben  <aroben@apple.com>
3747
3748         Use WebTextRenderer in DRT
3749
3750         Reviewed by Ada.
3751
3752         * DumpRenderTree/win/DumpRenderTree.cpp:
3753         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3754
3755 2007-10-24  Sven Herzberg  <sven@imendio.com>
3756
3757         Reviewed by Mark Rowe.
3758
3759         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3760         Bug 15614: [GTK] qmake based backends don't build on OS X
3761
3762         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3763         GTK backend on a Mac
3764         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3765         isDarwin() to make it reusable in other places (like the workaround-
3766         for-prebuilt-qmake in build-webkit)
3767
3768 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3769
3770         Refurbish update-webkit script.
3771
3772         Reviewed by Adam.
3773
3774         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3775         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3776         multi-argument version of system() for flexibility and security.  Check for existence
3777         of Internal directory using -d test instead of -x.
3778
3779 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3780
3781         Minor clean-up of prepare-ChangeLog script.
3782
3783         Reviewed by Adam.
3784
3785         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3786         of a string.  Use multi-argument versions of open() and system() for flexibility and
3787         security.
3788
3789 2007-10-24  Alice Liu  <alice.liu@apple.com>
3790
3791         Reviewed by Oliver.
3792
3793         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3794
3795         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
3796         replay the saved events when we're still processing the mousedown that starts the drag
3797         * DumpRenderTree/win/EventSender.cpp:
3798         (doMouseMove):
3799         * DumpRenderTree/win/UIDelegate.cpp:
3800         (UIDelegate::doDragDrop):
3801
3802 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3803
3804         Reviewed by Sam, Steve and Darin.
3805
3806         - Stubbed out the WebScriptDebugListener functionality in the Server
3807         Connection class to prepare it for receiving those callbacks.
3808         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
3809         and the ServerConnection to not need to be initialized with a server
3810         name, since that is not the way we connect to the WebKit server. 
3811
3812         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
3813         no exception.  Now it only loggs when there is an exception
3814         (DebuggerDocument::willExecuteStatement):
3815         (DebuggerDocument::didEnterCallFrame):
3816         (DebuggerDocument::willLeaveCallFrame):
3817         (DebuggerDocument::windowScriptObjectAvailable):
3818         (DebuggerDocument::callFunctionOnObject):
3819         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
3820         to be instantiated with a server's name.
3821         (DebuggerClient::DebuggerClient):
3822         (DebuggerClient::didFinishLoadForFrame):
3823         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3824         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3825         a server name.
3826         (Drosera::init):
3827         (Drosera::initServer):
3828         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3829         instantiated with a server's name.
3830         * Drosera/win/ServerConnection.cpp: 
3831         (ServerConnection::ServerConnection): No longer needs a server name
3832         (ServerConnection::~ServerConnection): Only release the global context
3833         if there is one.
3834         (ServerConnection::serverConnectionDidDie): Stub for
3835         IWebScriptDebugListener
3836         (ServerConnection::QueryInterface): ditto
3837         (ServerConnection::AddRef): ditto
3838         (ServerConnection::Release): ditto
3839         (ServerConnection::didLoadMainResourceForDataSource): ditto
3840         (ServerConnection::didParseSource): ditto
3841         (ServerConnection::failedToParseSource): ditto
3842         (ServerConnection::didEnterCallFrame): ditto
3843         (ServerConnection::willExecuteStatement): ditto
3844         (ServerConnection::willLeaveCallFrame): ditto
3845         (ServerConnection::exceptionWasRaised): ditto
3846         * Drosera/win/ServerConnection.h: Stubbed out the
3847         IWebScriptDebugListener functions, and this class no longer needs to be
3848         instantiated with a server name.
3849
3850 2007-10-24  Lars Knoll  <lars@trolltech.com>
3851
3852         Reviewed by Simon.
3853
3854         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3855
3856         * DumpRenderTree/qt/jsobjects.h:
3857
3858 2007-10-24  Lars Knoll  <lars@trolltech.com>
3859
3860         Reviewed by Simon.
3861
3862         add another command.
3863
3864         * DumpRenderTree/qt/jsobjects.cpp:
3865         (TextInputController::doCommand):
3866
3867 2007-10-24  Lars Knoll  <lars@trolltech.com>
3868
3869         Reviewed by Simon.
3870
3871         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3872
3873         * DumpRenderTree/qt/jsobjects.cpp:
3874         (EventSender::keyDown):
3875         * DumpRenderTree/qt/jsobjects.h:
3876
3877 2007-10-24  Lars Knoll  <lars@trolltech.com>
3878
3879         Reviewed by Simon.
3880
3881         implement eventSender.keyDown().
3882
3883         * DumpRenderTree/qt/jsobjects.cpp:
3884         (EventSender::keyDown):
3885
3886 2007-10-24  Lars Knoll  <lars@trolltech.com>
3887
3888         Reviewed by Simon.
3889
3890         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3891
3892         * DumpRenderTree/qt/DumpRenderTree.cpp:
3893         (WebCore::DumpRenderTree::DumpRenderTree):
3894         (WebCore::DumpRenderTree::initJSObjects):
3895         * DumpRenderTree/qt/jsobjects.cpp:
3896         (TextInputController::doCommand):
3897
3898 2007-10-24  Lars Knoll  <lars@trolltech.com>
3899
3900         Reviewed by Simon.
3901
3902         first bit of implementation for the textinputcontroller.
3903
3904         * DumpRenderTree/qt/DumpRenderTree.cpp:
3905         (WebCore::DumpRenderTree::DumpRenderTree):
3906         * DumpRenderTree/qt/DumpRenderTree.h:
3907         * DumpRenderTree/qt/jsobjects.cpp:
3908         (TextInputController::TextInputController):
3909         (TextInputController::doCommand):
3910         * DumpRenderTree/qt/jsobjects.h:
3911
3912 2007-10-24  Lars Knoll  <lars@trolltech.com>
3913
3914         Reviewed by Simon.
3915
3916         make the man webpage believe it has focus, so the editing tests work correctly.
3917
3918         * DumpRenderTree/qt/DumpRenderTree.cpp:
3919         (WebCore::DumpRenderTree::DumpRenderTree):
3920
3921 2007-10-24  Lars Knoll  <lars@trolltech.com>
3922
3923         Reviewed by Simon.
3924
3925         implement layoutTestController.dumpEditingCallbacks() correctly.
3926
3927         * DumpRenderTree/qt/DumpRenderTree.cpp:
3928         (WebCore::DumpRenderTree::DumpRenderTree):
3929         * DumpRenderTree/qt/jsobjects.cpp:
3930         (LayoutTestController::reset):
3931         (LayoutTestController::dumpEditingCallbacks):
3932
3933 2007-10-24  Lars Knoll  <lars@trolltech.com>
3934
3935         Reviewed by Simon.
3936
3937         Implement support for testing editing.
3938
3939         * DumpRenderTree/qt/DumpRenderTree.cpp:
3940         (WebCore::DumpRenderTree::DumpRenderTree):
3941
3942 2007-10-23  Sam Weinig  <sam@webkit.org>
3943
3944         Check for null BSTR that can be passed to the UIDelegate methods
3945         from javascript null and undefined.  Fixes a failing test case on
3946         Windows (fast/dom/Window/alert-undefined.html)
3947
3948         Reviewed by Eric Seidel.
3949
3950         * DumpRenderTree/win/UIDelegate.cpp:
3951         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3952         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3953         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3954         (UIDelegate::webViewAddMessageToConsole):
3955
3956 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3957
3958         Reviewed by Darin.
3959         
3960         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3961
3962         * Scripts/build-testkjs:
3963
3964 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3965
3966         Reviewed by Darin.
3967
3968         - add wrapper that finds the right copy of testkjs
3969         
3970         * Scripts/sunspider-compare-results: Added.
3971
3972 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3973
3974         Reviewed by Sam.
3975
3976         - After talking with Steve I now see that the WebKit server must be
3977         running for DCOM to create the distributed objects, which makes sense
3978         and currently WebKit only allows one instance to be running at a time
3979         which avoids accidentally connecting to the wrong server
3980         - In light of this I have removed the code for the attach box and
3981         NotificationServer and known server names, since they are all extranious
3982         now.
3983
3984         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3985         names.
3986         (_tWinMain): Uses init instead of initUI.
3987         (droseraWndProc): No longer creats an attach dialog box.
3988         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3989         it's not manditory to call init before doing COM stuff.
3990         (Drosera::init): calls initUI and will call attach when the
3991         functionality exists. 
3992         (Drosera::initUI): Has changed very little.
3993         (Drosera::attach): Changed the signature to reflect that we no longer
3994         need the dictionary of known server names.
3995         * Drosera/win/Drosera.h: Removed notification classes and known server
3996         names.  Also renamed and moved some functions.
3997         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3998         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3999         headers to the resources folder. 
4000         * Drosera/win/resource.h: Removed the Attach box.
4001
4002 2007-10-22  Adam Roben  <aroben@apple.com>
4003
4004         Windows build fix
4005
4006         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
4007
4008 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
4009
4010         - Removed a leak that was fixed.
4011
4012         * Scripts/run-webkit-tests:
4013
4014 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
4015
4016         Reviewed by Darin.
4017
4018         - Changed the Client so that the DebuggerDocument now own the
4019         ServerConnection.  This simplifies ownership and cleanup. 
4020
4021         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
4022         ServerConnection.
4023         (DebuggerClient::initWithServerName):
4024         (DebuggerClient::didFinishLoadForFrame):
4025         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
4026         ServerConnection.
4027         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
4028         until after we have a server which we are attached to.
4029         (Drosera::initUI):
4030         (Drosera::attach):
4031         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
4032         out previously.
4033
4034 2007-10-22  Simon Hausmann  <hausmann@kde.org>
4035
4036         Reviewed by Nikolas.
4037
4038         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
4039
4040         * Scripts/run-javascriptcore-tests:
4041
4042 2007-10-22  Simon Hausmann  <hausmann@kde.org>
4043
4044         Reviewed by Nikolas.
4045
4046         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
4047
4048         * Scripts/build-drosera:
4049         * Scripts/build-dumprendertree:
4050         * Scripts/build-testkjs:
4051         * Scripts/build-webkit:
4052         * Scripts/run-javascriptcore-tests:
4053         * Scripts/run-sunspider:
4054         * Scripts/run-webkit-tests:
4055         * Scripts/webkitdirs.pm:
4056
4057 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
4058
4059         Reviewed by Mark Rowe.
4060         
4061         Fix for local database support after r26879
4062         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
4063
4064         * Scripts/build-webkit:
4065
4066 2007-10-22  Holger Freyther  <zecke@selfish.org>
4067
4068         Reviewed by Simon Hausmann <hausmann@kde.org>.
4069
4070         - Do not build testkjs as an application bundle. This is
4071         needed for run-javascriptcore-tests on OSX.
4072         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
4073         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
4074         as we do not have -rpath on OSX.
4075
4076         * DumpRenderTree/qt/DumpRenderTree.pro:
4077         * Scripts/run-webkit-tests:
4078
4079 2007-10-22  Simon Hausmann  <hausmann@kde.org>
4080
4081         Reviewed by aroben.
4082
4083         Fix support for Signed-off-by detection in prepare-ChangeLog
4084         --git-commit. The Signed-off-by tag does not appear in the header
4085         but usually at the end.
4086
4087         * Scripts/prepare-ChangeLog:
4088
4089 2007-10-21  Mark Rowe  <mrowe@apple.com>
4090
4091         Reviewed by Eric.
4092
4093         Fix run-javascriptcore-tests for Gtk.
4094
4095         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
4096
4097 2007-10-20  Eric Seidel  <eric@webkit.org>
4098
4099         Reviewed by aroben.
4100
4101         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
4102
4103 2007-10-20  Eric Seidel  <eric@webkit.org>
4104
4105         Reviewed by darin.
4106         
4107         Add improved argument handling to run-sunspider, including
4108         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
4109         Also re-factor code into subroutines
4110
4111         * Scripts/build-dumprendertree: removed bogus comments
4112         * Scripts/build-testkjs: Added.
4113         * Scripts/run-javascriptcore-tests: use build-testkjs
4114         * Scripts/run-sunspider: improved argument handling, abstraction
4115         * Scripts/run-webkit-tests: improved abstraction
4116
4117 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
4118
4119         Not reviewed, Windows build fix.
4120
4121         * DumpRenderTree/win/EventSender.cpp:
4122         (keyDownCallback):
4123
4124 2007-10-20  Darin Adler  <darin@apple.com>
4125
4126         Reviewed by Tim Hatcher.
4127
4128         - http://bugs.webkit.org/show_bug.cgi?id=15544
4129           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
4130           not rely on Apple-specific key codes
4131
4132         * DumpRenderTree/mac/EventSendingController.mm:
4133         (-[EventSendingController keyDown:withModifiers:]):
4134         Added named key "rightArrow". Later we could have a whole table of these.
4135         Also tweaked modifiers code a little.
4136
4137         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
4138
4139 2007-10-19  Darin Adler  <darin@apple.com>
4140
4141         Reviewed by Eric.
4142
4143         - http://bugs.webkit.org/show_bug.cgi?id=15566
4144           possible fix for leak seen in DumpRenderTree
4145
4146         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
4147         Delete the item if it's not put on the queue, since the caller has
4148         no way of knowing that. Would be better to have the parameter type
4149         be auto_ptr to express the fact that we take ownership.
4150
4151         - unrelated change
4152
4153         * Drosera/mac/main.m: Add missing include.
4154
4155 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
4156
4157         Reviewed by Adam.
4158
4159         - This change should be identical but for some reason was not working
4160         on my machine.
4161
4162         * Scripts/prepare-ChangeLog:
4163
4164 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
4165
4166         Reviewed by Oliver and Tim.
4167
4168         - Made use of RetainPtr to avoid retain and release issues and moved the
4169         log function to DebuggerDocumentPlatform, which seems to be a more
4170         logical place for it to live.
4171         - Also moved knownServers from the ServerConnection to
4172         DebuggerApplication to match the Windows code and because it makes sense
4173         that a connection knows its own server but not all of them.
4174
4175         * Drosera/mac/DebuggerClient.h: Moved the log function to
4176           DebuggerDocumentPlatform.
4177         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
4178           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
4179           call for the server name up from the ServerConnection class.
4180         (-[DebuggerClient dealloc]):
4181         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
4182           for the server name up from the ServerConnection.
4183         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
4184         (DebuggerDocument::platformPause):
4185         (DebuggerDocument::platformResume):
4186         (DebuggerDocument::platformStepInto):
4187         (DebuggerDocument::platformEvaluateScript):
4188         (DebuggerDocument::getPlatformCurrentFunctionStack):
4189         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
4190         (DebuggerDocument::platformValueForScopeVariableNamed):
4191         (DebuggerDocument::platformLog): Log directly from here. No need to call
4192           DebuggerClient.
4193         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
4194           way I see it, a ServerConnection should only know about its connection
4195           and the group of all possible servers should be kept by the
4196           application.
4197         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
4198           currentServerName, it makes sense that the connection should know that
4199           name.
4200         (-[ServerConnection currentServerName]):
4201
4202 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
4203
4204         Reviewed by Adam.
4205
4206         - Integrated changes from mac drosera.  Recently I've encapsulated
4207         out the server connection object from the rest of Drosera because
4208         it is very platform dependent right now and RPC is not implemented on
4209         windows.  This functionality, of communicating with the WebKit server
4210         is the next area I will be focusing on in Windows.
4211
4212         - Other changes and cleanup were made to organize the code and add notes
4213         on which parts still need work.  Also some mac code is added and
4214         commented out, to act as pseudocode for the logic of those parts.
4215
4216         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
4217           pointer.
4218         * Drosera/config.h: Added whitespace.
4219         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
4220           these files got moved into Drosera.h/cpp
4221         * Drosera/win/DebuggerApplication.h: Removed.
4222         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
4223           happened here to better match the logic flow of the same code on the 
4224           mac side and to use the new ServerConnection class.
4225         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
4226         (DebuggerClient::initWithServerName): Initializer that will set up the
4227           class to use a ServerConnection object.  This was necessary so I could
4228           create a DebuggerClient without having to initilaize it at
4229           construction.
4230         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
4231           will be the UIDelegate and FrameLoadDelegate.
4232         (DebuggerClient::AddRef): For IUnknown.
4233         (DebuggerClient::Release): For IUnknown.
4234         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
4235           this still needs to set the global context of the server, but
4236           IWebFrame does not have an accessor for the global context yet. 
4237         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
4238           this is a pass through for the same function in the document.
4239         (DebuggerClient::didReceiveTitle): Unimplemented part of
4240           FrameLoadDelegate this would change the title of the window.
4241         (DebuggerClient::createWebViewWithRequest): Part of the
4242           FrameLoadDelegate.  This is about new windows via Window.open() and
4243           how their delegates are set.
4244         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
4245           UIDelegate.  Just a debug function for printing messages.
4246         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
4247           because the Client should be the UIDelegate and FrameLoadDelegate
4248           to match the delegates on mac.
4249         (DebuggerClient::webViewLoaded): Added accessor method.
4250         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
4251           forgotten to add this file before.  This is where the platform
4252           dependent versions of the Documents functions live. Most of these are
4253           unimplemented because some piece of functionality does not exist on
4254           Windows yet.
4255         (DebuggerDocument::platformPause):
4256         (DebuggerDocument::platformResume):
4257         (DebuggerDocument::platformStepInto):
4258         (DebuggerDocument::platformEvaluateScript):
4259         (DebuggerDocument::getPlatformCurrentFunctionStack):
4260         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
4261         (DebuggerDocument::platformValueForScopeVariableNamed):
4262         (DebuggerDocument::platformLog):
4263         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
4264           responsibilities becaue they belong in the Client. Also I laid the
4265           groundwork for attaching Drosera to a WebKit process
4266         (attachWndProc): Now if a server is selected the Client becomes it's
4267           delegate.
4268         (Drosera::Drosera): Added the construction of the Client and dictionary
4269           of server names. 
4270         (Drosera::initUI): This is no longer the delegates, the Client is.
4271         (Drosera::webViewLoaded): Now asks the Client instead of holding local
4272           state. 
4273         (Drosera::applicationDidFinishLaunching): Placeholder for needed
4274           notification registration when it's possible to implement.
4275         (Drosera::serverLoaded): Ditto
4276         (Drosera::serverUnloaded): Ditto
4277         (Drosera::attach): Attach Drosera to the WebKit server.
4278         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
4279         (Drosera::getInst): 
4280         (Drosera::setInst):
4281         (Drosera::knownServers):
4282         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
4283           and added the ServerConnection.
4284         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
4285         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
4286           Most of the functions are completely unimlemented because they cannot
4287           connect with the WebKit server, because one does not exist on Windows
4288           yet.
4289         (ServerConnection::initWithServerName): 
4290         (ServerConnection::~ServerConnection):
4291         (ServerConnection::setGlobalContext):
4292         (ServerConnection::pause):
4293         (ServerConnection::resume):
4294         (ServerConnection::stepInto):
4295         (ServerConnection::switchToServerNamed):
4296