2010-09-20 Kwang Yul Seo <skyul@company100.net>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-09-20  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         The tool member variable should be called _tool
6         https://bugs.webkit.org/show_bug.cgi?id=46160
7
8         Created by find-and-replace.
9
10         * Scripts/webkitpy/tool/commands/download.py:
11         * Scripts/webkitpy/tool/commands/openbugs.py:
12         * Scripts/webkitpy/tool/commands/queries.py:
13         * Scripts/webkitpy/tool/commands/queues.py:
14         * Scripts/webkitpy/tool/commands/queues_unittest.py:
15         * Scripts/webkitpy/tool/commands/rebaseline.py:
16         * Scripts/webkitpy/tool/commands/sheriffbot.py:
17         * Scripts/webkitpy/tool/commands/upload.py:
18         * Scripts/webkitpy/tool/multicommandtool.py:
19
20 2010-09-20  Adam Barth  <abarth@webkit.org>
21
22         I ran the tests before landing but ignored the fact that they failed.  :(
23
24         * Scripts/webkitpy/tool/commands/queues.py:
25
26 2010-09-20  Adam Barth  <abarth@webkit.org>
27
28         Reviewed by Eric Seidel.
29
30         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
31         https://bugs.webkit.org/show_bug.cgi?id=46141
32
33         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
34         list of work items on the status server.  The individual commit-cluster
35         nodes then grab the patches from the server and process them.
36
37         * Scripts/webkitpy/tool/bot/feeders.py: Added.
38         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
39         * Scripts/webkitpy/tool/commands/queues.py:
40         * Scripts/webkitpy/tool/commands/queues_unittest.py:
41         * Scripts/webkitpy/tool/commands/queuestest.py:
42
43 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
44
45         Reviewed by Darin Adler.
46
47         build-webkit: Add support for CMake build system
48         https://bugs.webkit.org/show_bug.cgi?id=44979
49
50         * Scripts/build-webkit: Add "--efl" command-line option to build the
51         EFL port of WebKit.
52         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
53         buildEflCMakeProject() subroutines.
54
55 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
56
57         Reviewed by Ojan Vafai.
58
59         new-run-webkit-tests: refactor command line args getting passed to DRT
60
61         This change cleans up some argument parsing between functions to get
62         rid of some overlapping data structures. There should be no functional
63         changes in this patch; it is pure refactoring in preparation for
64         landing the Chrome GPU port and adding a generic way to pass
65         args to DRT/TestShell.
66
67         https://bugs.webkit.org/show_bug.cgi?id=46135
68
69         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
70           - pass the options argument explicitly to the threads and drivers,
71             also consolidate the passing of options to the driver.
72           - pass options directly to process_output() to remove a couple
73             parameters (minor cleanup).
74         * Scripts/webkitpy/layout_tests/port/base.py:
75           - pass the options argument to Port.create_driver().
76         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
77           - update Port.create_driver() test
78         * Scripts/webkitpy/layout_tests/port/chromium.py:
79           - pass the options argument to Port.create_driver(), and clean up
80             building of the cmd line for DRT.
81         * Scripts/webkitpy/layout_tests/port/dryrun.py:
82           - pass the options argument to Port.create_driver()
83         * Scripts/webkitpy/layout_tests/port/test.py:
84           - pass the options argument to Port.create_driver()
85         * Scripts/webkitpy/layout_tests/port/webkit.py:
86           - pass the options argument to Port.create_driver(), and clean up
87             building of the cmd line for DRT.
88         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
89           - consolidate args in _get_dump_render_tree_args and rename to
90             _get_test_args(); move all of the command-line args to the
91             Port implementations.
92
93 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
94
95         Revert change which was accidentally committed along with some expectation changes.
96
97         * Scripts/webkitpy/layout_tests/port/base.py:
98
99 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
100
101         Reviewed by Adam Barth.
102
103         Add explicit --force-patch flag to webkitpy tools
104         https://bugs.webkit.org/show_bug.cgi?id=46103
105         
106         It wasn't obvious until I read the applypatch.py source code that
107         --non-interfactive implies passing --force to patch. Add --force-patch
108         as an alias to the flag, so that this behavior is more discoverable.
109
110         * Scripts/webkitpy/tool/steps/applypatch.py:
111         * Scripts/webkitpy/tool/steps/options.py:
112
113 2010-09-20  Eric Seidel  <eric@webkit.org>
114
115         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
116
117         commit-queue can't land patches
118         https://bugs.webkit.org/show_bug.cgi?id=46138
119
120         Add a line of code I forgot in my last commit.
121
122         * Scripts/webkitpy/common/net/bugzilla.py:
123         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
124
125 2010-09-20  Adam Barth  <abarth@webkit.org>
126
127         Reviewed by Eric Seidel.
128
129         The commit-cluster bots still race to lock patch_ids
130         https://bugs.webkit.org/show_bug.cgi?id=46130
131
132         It turns out we need to use a transaction object to make the
133         read/modify/write lock operation atomic.  From reading the AppEngine
134         documentation, I think this patch should do what we want.  It's hard to
135         test locally because the test instance isn't distributed in the same
136         way the production instance is.
137
138         * QueueStatusServer/handlers/nextpatch.py:
139         * QueueStatusServer/model/activeworkitems.py: Added.
140
141 2010-09-20  Andy Estes  <aestes@apple.com>
142
143         Reviewed by Adam Barth.
144
145         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
146         https://bugs.webkit.org/show_bug.cgi?id=40961
147
148         Implement WebKitUsePreHTML5ParserQuirks preference.
149
150         * DumpRenderTree/mac/DumpRenderTree.mm:
151         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
152         to false after a test finishes.
153
154 2010-09-20  Adam Roben  <aroben@apple.com>
155
156         Windows build fix
157
158         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
159         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
160         we'll pick up the most recent versions of the headers.
161
162 2010-09-20  Eric Seidel  <eric@webkit.org>
163
164         Reviewed by Adam Barth.
165
166         commit-queue should check commit-queue+ again just before committing
167         https://bugs.webkit.org/show_bug.cgi?id=32679
168
169         Added a _revalidate_patch check, right before landing.
170
171         Since _revalidate_patch passes the patch_id from the work item
172         back to bugzilla, I had to fix all of the previous queue tests to
173         use valid attachment ids (that's the majority of this change).
174
175         In order to validate that the bug was still open, I had to teach
176         bugzilla.Bug about open/closed states.
177
178         * Scripts/webkitpy/common/net/bugzilla.py:
179         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
180         * Scripts/webkitpy/tool/commands/queues.py:
181         * Scripts/webkitpy/tool/commands/queues_unittest.py:
182         * Scripts/webkitpy/tool/commands/queuestest.py:
183         * Scripts/webkitpy/tool/mocktool.py:
184
185 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
186
187         Unreviewed.
188
189         Adding myself as a comitter.
190
191         * Scripts/webkitpy/common/config/committers.py:
192
193 2010-09-20  Adam Barth  <abarth@webkit.org>
194
195         Reviewed by Eric Seidel.
196
197         Two instances of commit-queue try to process the same patch
198         https://bugs.webkit.org/show_bug.cgi?id=46113
199
200         This patch makes next-patch atomic so that the server won't vend the
201         same patch twice in the same hour.
202
203         * QueueStatusServer/handlers/nextpatch.py:
204
205 2010-09-20  Adam Roben  <aroben@apple.com>
206
207         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
208
209         We were previously trying to use a CFRunLoopTimer, but since Windows
210         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
211         Windows-style timer on Windows.
212
213         I also replaced all uses of "watchdog" with "watchdog timer".
214
215         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
216         watchdog timer doesn't work on Windows
217
218         Reviewed by Anders Carlsson.
219
220         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
221         (WTR::InjectedBundlePage::dump): Updated for rename.
222
223         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
224         platform-specific functions.
225         (WTR::LayoutTestController::LayoutTestController): Added call to
226         platformInitialize.
227         (WTR::LayoutTestController::waitUntilDone): Changed to call
228         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
229         right in this function.
230         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
231         rename.
232
233         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
234         members needed to support the watchdog timer abstraction. Replaced
235         some "watchdog"s with "watchdog timer".
236
237         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
238         Added.
239         (WTR::LayoutTestController::platformInitialize): Does nothing on this
240         platform.
241         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
242         from LayoutTestController.cpp and changed to use an early return.
243         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
244         LayoutTestController.cpp.
245         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
246         Moved code here from LayoutTestController::waitUntilDone and changed
247         to use an early return.
248
249         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
250         Added.
251         (WTR::LayoutTestController::platformInitialize): Initialize our
252         watchdog timer.
253         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
254         Kills and clears the watchdog timer.
255         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
256         LayoutTestController member function of the same name.
257         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
258         Added. Sets up the timer if it isn't already set.
259
260         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
261         LayoutTestControllerMac.mm.
262
263         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
264         LayoutTestControllerWin.cpp.
265
266 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
267
268         Reviewed by Daniel Bates.
269
270         [GTK] fast/forms/listbox-selection.html fails
271         https://bugs.webkit.org/show_bug.cgi?id=45942
272
273         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
274         strings in keyDownCallback.
275
276         * DumpRenderTree/gtk/EventSender.cpp:
277         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
278         modifier parsing logic.
279
280 2010-09-19  Sam Weinig  <sam@webkit.org>
281
282         Reviewed by Anders Carlsson.
283
284         WebKit2 decidePolicyForNavigationAction should include mouse button information
285         <rdar://problem/8413165>
286         https://bugs.webkit.org/show_bug.cgi?id=46060
287
288         * MiniBrowser/mac/BrowserWindowController.m:
289         (decidePolicyForNavigationAction):
290         (decidePolicyForNewWindowAction):
291
292 2010-09-19  Daniel Bates  <dbates@rim.com>
293
294         Reviewed by Martin Robinson.
295
296         Add unit tests for diffs that delete or modify a change log entry
297         or describe changes that are far apart
298         https://bugs.webkit.org/show_bug.cgi?id=46046
299
300         Add additional unit tests to test change log diffs that contain
301         deletions or changes that are far apart from each other in the
302         ChangeLog file.
303
304         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
305           - Added the following unit tests:
306           "fixChangeLogPatch: [no change] In-place change."
307           "fixChangeLogPatch: [no change] Remove first entry."
308           "fixChangeLogPatch: [no change] Remove entry in the middle."
309           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
310
311 2010-09-19  Sam Weinig  <sam@webkit.org>
312
313         Reviewed by Anders Carlsson.
314
315         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
316         https://bugs.webkit.org/show_bug.cgi?id=46054
317
318         The new one acts like WKBundleNodeHandleRef and allows for getting a
319         wrapper in a specific world for the handle.
320
321         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
322         (WTR::propertyValue):
323         (WTR::propertyValueDouble):
324         (WTR::propertyValueInt):
325         (WTR::numericWindowPropertyValue):
326         (WTR::toStr):
327         (WTR::InjectedBundlePage::shouldBeginEditing):
328         (WTR::InjectedBundlePage::shouldEndEditing):
329         (WTR::InjectedBundlePage::shouldInsertNode):
330         (WTR::InjectedBundlePage::shouldInsertText):
331         (WTR::InjectedBundlePage::shouldDeleteRange):
332         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
333         (WTR::InjectedBundlePage::shouldApplyStyle):
334         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
335
336 2010-09-19  Kent Tamura  <tkent@chromium.org>
337
338         Unreviewed. Fix WebGL test regressions by r67809.
339
340         * DumpRenderTree/chromium/WebPreferences.cpp:
341         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
342
343 2010-09-19  Kent Tamura  <tkent@chromium.org>
344
345         Reviewed by Adam Barth.
346
347         [DRT/Chromium] Fix a WebSettings handling bug
348         https://bugs.webkit.org/show_bug.cgi?id=45945
349
350         Before this change, Chromium DRT reset WebSettings for every new
351         window. It was wrong.
352         If new window is not the first one, we have to apply the same
353         settings as the first window.  So, we introduce WebPreference to
354         store the current settings, and apply it to new windows. It's same
355         as test_shell's behavior.
356
357         * DumpRenderTree/DumpRenderTree.gypi:
358         * DumpRenderTree/chromium/LayoutTestController.cpp:
359           Use WebPreferences instead of WebSettings.
360         (LayoutTestController::setUserStyleSheetEnabled):
361         (LayoutTestController::setUserStyleSheetLocation):
362         (LayoutTestController::setAuthorAndUserStylesEnabled):
363         (LayoutTestController::setPopupBlockingEnabled):
364         (LayoutTestController::disableImageLoading):
365         (LayoutTestController::setJavaScriptCanAccessClipboard):
366         (LayoutTestController::setXSSAuditorEnabled):
367         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
368         (LayoutTestController::setAllowFileAccessFromFileURLs):
369         (LayoutTestController::overridePreference):
370         (LayoutTestController::setEditingBehavior):
371         * DumpRenderTree/chromium/TestShell.cpp:
372         (TestShell::resetWebSettings): Use WebPreferences.
373         (TestShell::runFileTest): ditto.
374         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
375         * DumpRenderTree/chromium/TestShell.h:
376         (TestShell::preferences):
377         (TestShell::applyPreferences):
378         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
379         * DumpRenderTree/chromium/WebPreferences.h: Added.
380
381 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
382
383         Reviewed by David Levin.
384
385         update-webkit --chromium spitting out a spurious error
386         https://bugs.webkit.org/show_bug.cgi?id=45868
387
388         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
389
390 2010-09-18  Sam Weinig  <sam@webkit.org>
391
392         Reviewed by Dan Bernstein.
393
394         Improve/unify the PageLoadClient interfaces
395         https://bugs.webkit.org/show_bug.cgi?id=46043
396
397         * MiniBrowser/mac/BrowserWindowController.m:
398         (didStartProvisionalLoadForFrame):
399         (didReceiveServerRedirectForProvisionalLoadForFrame):
400         (didFailProvisionalLoadWithErrorForFrame):
401         (didCommitLoadForFrame):
402         (didFinishDocumentLoadForFrame):
403         (didFinishLoadForFrame):
404         (didFailLoadWithErrorForFrame):
405         (didReceiveTitleForFrame):
406         (didFirstLayoutForFrame):
407         (didFirstVisuallyNonEmptyLayoutForFrame):
408         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
409         (WTR::InjectedBundlePage::InjectedBundlePage):
410         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
411         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
412         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
413         (WTR::InjectedBundlePage::didCommitLoadForFrame):
414         (WTR::InjectedBundlePage::didFinishLoadForFrame):
415         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
416         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
417         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
418         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
419         * WebKitTestRunner/TestController.cpp:
420         (WTR::TestController::didReceiveMessageFromInjectedBundle):
421         (WTR::TestController::didFinishLoadForFrame):
422         * WebKitTestRunner/TestController.h:
423
424 2010-09-17  Eric Seidel  <eric@webkit.org>
425
426         Unreviewed.  Adding a shell script I use to run the
427         commit-queue. Now that multiple machines run the cq,
428         it makes sense to share the script between them.
429
430         * EWSTools/start-commit-queue.sh: Added.
431
432 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
433
434         Reviewed by Jon Honeycutt.
435
436         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
437         slightly harder to read, so this reverts the previous background colors for various
438         states, making it easier to read.
439
440         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
441         (.success):
442         (.failure):
443         (.warnings):
444         (.exception):
445         (.start,.running,td.building):
446         (.offline,td.offline):
447
448 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
449
450         Unreviewed, rolling out r67692.
451         http://trac.webkit.org/changeset/67692
452         https://bugs.webkit.org/show_bug.cgi?id=46011
453
454         broke layout test dashboard (Requested by johnny_g on
455         #webkit).
456
457         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
458         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
459         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
460
461 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
462
463         Reviewed by Oliver Hunt.
464
465         Style bot complains about cairo forward declaration naming
466         https://bugs.webkit.org/show_bug.cgi?id=45867
467
468         Exclude Cairo forward declarations from indentifiers with underscores checks.
469
470         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
471         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
472
473 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
474
475         Reviewed by Ojan Vafai.
476
477         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
478         https://bugs.webkit.org/show_bug.cgi?id=45408
479
480         This change also tries to remove duplicated upload_results_json methods
481         in run_webkit_tests.py and json_results_generator.py.
482
483         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
484         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
485         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
486
487 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
488
489         Reviewed by Andreas Kling.
490
491         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
492
493         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
494         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
495         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
496         all page specific stuff to the UI.
497
498         * QtTestBrowser/launcherwindow.cpp:
499         (LauncherWindow::initializeView):
500         * QtTestBrowser/mainwindow.cpp:
501         (MainWindow::MainWindow):
502         (MainWindow::buildUI):
503         (MainWindow::setPage):
504         * QtTestBrowser/mainwindow.h:
505
506 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
507
508         Reviewed by Andreas Kling.
509
510         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
511
512         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
513         object will move to the qgraphicsscene instead of the qgraphicsview.
514
515         * QtTestBrowser/webview.cpp:
516         (WebViewGraphicsBased::setPage):
517         (WebViewGraphicsBased::setResizesToContents):
518         (WebViewGraphicsBased::resizeEvent):
519         (WebViewGraphicsBased::animatedFlip):
520         * QtTestBrowser/webview.h:
521         (WebViewGraphicsBased::setItemCacheMode):
522         (WebViewGraphicsBased::itemCacheMode):
523
524 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
525
526         Reviewed by Andreas Kling.
527
528         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
529
530         We usually separate methods whose body are larger than a few lines from the class definition.
531
532         * QtTestBrowser/webview.h:
533         (WebViewGraphicsBased::yRotation):
534         (WebViewGraphicsBased::setYRotation):
535
536 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
537
538         Reviewed by Andreas Kling.
539
540         Make initializeView method of LauncherWindow private.
541
542         No one else needs to be able to call it but LauncherWindow.
543         Also moving the declation of isGraphicsBased method down in the same file, in order
544         to better group related methods.
545
546         * QtTestBrowser/launcherwindow.h:
547
548 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
549
550         Reviewed by Andreas Kling.
551
552         Make the getter 'page' method of MainWindow const.
553
554         * QtTestBrowser/mainwindow.cpp:
555         (MainWindow::page):
556         * QtTestBrowser/mainwindow.h:
557
558 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
559
560         Reviewed by Andreas Kling.
561
562         Remove useless parameter from MainWindow class' constructor.
563
564         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
565         not referred in the constructor body and does not make much sense.
566
567         * QtTestBrowser/mainwindow.cpp:
568         (MainWindow::MainWindow):
569         * QtTestBrowser/mainwindow.h:
570
571 2010-09-15  Tony Chang  <tony@chromium.org>
572
573         Reviewed by Kent Tamura.
574
575         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
576         https://bugs.webkit.org/show_bug.cgi?id=42151
577
578         * DumpRenderTree/chromium/LayoutTestController.cpp:
579         (LayoutTestController::LayoutTestController):
580         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
581         (WorkItemLoadHTMLString::run):
582         (LayoutTestController::queueLoadHTMLString):
583         (LayoutTestController::reset):
584         (LayoutTestController::setDeferMainResourceDataLoad):
585         * DumpRenderTree/chromium/LayoutTestController.h:
586         (LayoutTestController::deferMainResourceDataLoad):
587         * DumpRenderTree/chromium/WebViewHost.cpp:
588         (WebViewHost::didCreateDataSource):
589
590 2010-09-16  Adrienne Walker  <enne@google.com>
591
592         Reviewed by Kenneth Russell.
593
594         Add script to synchronize WebKit and Khronos WebGL tests
595         https://bugs.webkit.org/show_bug.cgi?id=42336
596
597         * Scripts/update-webgl-conformance-tests: Added.
598         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
599         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
600
601 2010-09-16  Sam Weinig  <sam@webkit.org>
602
603         Reviewed by Anders Carlsson.
604
605         Add support for sending synchronous messages from the InjectedBundle to the WKContext
606         <rdar://problem/8365320>
607         https://bugs.webkit.org/show_bug.cgi?id=44785
608
609         * MiniBrowser/mac/AppDelegate.m:
610         (didReceiveSynchronousMessageFromInjectedBundle):
611         (-[BrowserAppDelegate init]):
612         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
613         (didCreatePage):
614         * WebKitTestRunner/TestController.cpp:
615         (WTR::TestController::initialize):
616
617 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
618
619         Reviewed by Andreas Kling.
620
621         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
622         https://bugs.webkit.org/show_bug.cgi?id=45885
623
624         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
625
626         * QtTestBrowser/launcherwindow.cpp:
627         (LauncherWindow::screenshot):
628
629 2010-09-16  Anders Carlsson  <andersca@apple.com>
630
631         Fix clang++ build.
632
633         * MiniBrowser/mac/BrowserWindowController.m:
634         (-[BrowserWindowController zoomIn:]):
635         (-[BrowserWindowController zoomOut:]):
636         (-[BrowserWindowController resetZoom:]):
637         Remove trailing semicolons.
638
639 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
640
641         Unreviewed, rolling out r67628.
642         http://trac.webkit.org/changeset/67628
643         https://bugs.webkit.org/show_bug.cgi?id=45904
644
645         broke the build (Requested by eric_carlson on #webkit).
646
647         * DumpRenderTree/gtk/EventSender.cpp:
648         (contextClickCallback):
649
650 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
651
652         Unreviewed.
653
654         Adding myself as a comitter.
655
656         * Scripts/webkitpy/common/config/committers.py:
657
658 2010-09-15  Philippe Normand  <pnormand@igalia.com>
659
660         Reviewed by Eric Carlson.
661
662         [GTK] enhanced context menu for media elements
663         https://bugs.webkit.org/show_bug.cgi?id=45021
664
665         EventSender::contextClick() now returns an array of js
666         objects. Each object has a title property and a click() method.
667
668         * DumpRenderTree/gtk/EventSender.cpp:
669         (getMenuItemTitleCallback):
670         (setMenuItemTitleCallback):
671         (menuItemClickCallback):
672         (getMenuItemClass):
673         (contextClickCallback):
674
675 2010-09-14  Philippe Normand  <pnormand@igalia.com>
676
677         Reviewed by Eric Carlson and Martin Robinson.
678
679         [GTK] eventSender.contextClick() should return the contents of the context menu
680         https://bugs.webkit.org/show_bug.cgi?id=39102
681
682         Make the eventSender use the new private WebKitGtk+ API to
683         retrieve the context-menu item titles and store them in an array.
684
685         * DumpRenderTree/gtk/EventSender.cpp:
686         (contextClickCallback):
687
688 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
689
690         Reviewed by Jian Li.
691
692         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
693         https://bugs.webkit.org/show_bug.cgi?id=45798
694
695         * Scripts/build-webkit:
696
697 2010-09-16  Robert Hogan  <robert@webkit.org>
698
699         Reviewed by Antonio Gomes.
700
701         [Qt] Support globalhistory tests
702         https://bugs.webkit.org/show_bug.cgi?id=45774
703
704         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
705         (WebCore::isGlobalHistoryTest):
706         (WebCore::DumpRenderTree::open):
707         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
708         (LayoutTestController::reset):
709         (LayoutTestController::dumpHistoryCallbacks):
710         (LayoutTestController::removeAllVisitedLinks):
711         * DumpRenderTree/qt/LayoutTestControllerQt.h:
712
713 2010-09-10  Tony Chang  <tony@chromium.org>
714
715         Reviewed by Eric Seidel.
716
717         deduplicate-tests should be runnable from any WebKit directory
718         https://bugs.webkit.org/show_bug.cgi?id=44709
719
720         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
721         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
722
723 2010-09-15  Tony Chang  <tony@chromium.org>
724
725         Reviewed by Kent Tamura.
726
727         [chromium] sort testing methods in DRT
728         https://bugs.webkit.org/show_bug.cgi?id=45850
729
730         * DumpRenderTree/chromium/EventSender.cpp:
731         (EventSender::EventSender):
732         * DumpRenderTree/chromium/LayoutTestController.cpp:
733         (LayoutTestController::LayoutTestController):
734         * DumpRenderTree/chromium/TextInputController.cpp:
735         (TextInputController::TextInputController):
736
737 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
738
739         Reviewed by Adam Barth.
740
741         CQ status shows items out of order
742         https://bugs.webkit.org/show_bug.cgi?id=45846
743         
744         Only group consecutive status items with the same patch ID into the same
745         group, so that overall item ordering is preserved.
746         
747         Also don't indent status items that only have a single item in their
748         group.
749
750         * QueueStatusServer/handlers/queuestatus.py:
751         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
752         * QueueStatusServer/templates/queuestatus.html:
753
754 2010-09-15  Eric Seidel  <eric@webkit.org>
755
756         Reviewed by Adam Barth.
757
758         Add queue start/stop messages
759         https://bugs.webkit.org/show_bug.cgi?id=45853
760
761         I ended up needing to clean up a bunch of our unit testing
762         in order to test this new code path nicely.
763
764         There are also a few PEP8 changes needed to pass check-webkit-style.
765
766         * Scripts/webkitpy/tool/bot/queueengine.py:
767         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
768         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
769         * Scripts/webkitpy/tool/commands/queues.py:
770         * Scripts/webkitpy/tool/commands/queues_unittest.py:
771         * Scripts/webkitpy/tool/commands/queuestest.py:
772         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
773
774 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
775
776         https://bugs.webkit.org/show_bug.cgi?id=45849
777         WKURLCreateWithCFURL crashes with null url
778         
779         Fix MiniBrowser crash when the url is not parseable.
780
781         * MiniBrowser/mac/BrowserWindowController.m:
782         (-[BrowserWindowController fetch:]):
783
784 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
785
786         Unreviewed.
787
788         Adding myself to the committers list.
789
790         * Scripts/webkitpy/common/config/committers.py:
791
792 2010-09-14  Eric Seidel  <eric@webkit.org>
793
794         Reviewed by Adam Barth.
795
796         Make it possible to run more than one commit-queue instance
797         https://bugs.webkit.org/show_bug.cgi?id=45786
798
799         Mostly we need to make sure the two (or more) instances get
800         different patches to work on.  To do this, I re-worked
801         the code responsible for getting the next work item to
802         round trip through the status server.  The status server only
803         vends patches from the work items list, only if those patches
804         have not had status reported for them in the last hour.
805
806         This is another step towards making all queues go through the
807         status server, thus making it possible to run more than one
808         instance of various EWS bots (as requested in bug 44292).
809
810         The webkitpy changes are already covered by existing unit tests.
811         The QueueStatusSever sadly has no testing infrastructure yet. :(
812
813         * QueueStatusServer/handlers/nextpatch.py: Added.
814         * QueueStatusServer/index.yaml:
815         * QueueStatusServer/main.py:
816         * Scripts/webkitpy/tool/commands/queues.py:
817
818 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
819
820         Reviewed by Tony Chang.
821
822         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
823         https://bugs.webkit.org/show_bug.cgi?id=45791
824
825         Force filenames to be raw bytes before running difflib.unified_diff.
826
827         * Scripts/webkitpy/layout_tests/port/base.py:
828         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
829
830 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
831
832         Reviewed by Tor Arne Vestbø.
833
834         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
835         https://bugs.webkit.org/show_bug.cgi?id=35247
836
837         The main issue when changing the views is that the plugins and any other components that
838         depend on view specific attributes such as the native window id are not teared down.
839         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
840         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
841         we decided to work around this in QtTestBrowser by making toggling between QWebView
842         and QGraphicsWebView also re-create the page.
843
844         * QtTestBrowser/launcherwindow.cpp:
845         (LauncherWindow::initializeView):
846         * QtTestBrowser/mainwindow.h:
847
848 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
849
850         Reviewed by Adam Barth.
851
852         Send webkit accessibility notifications to Chromium
853         https://bugs.webkit.org/show_bug.cgi?id=45156
854
855         Move printf inside shouldDumpAccessibilityNotifications check.
856
857         * DumpRenderTree/chromium/WebViewHost.cpp:
858         (WebViewHost::postAccessibilityNotification):
859
860 2010-09-14  Tony Chang  <tony@chromium.org>
861
862         Reviewed by Kent Tamura.
863
864         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
865         https://bugs.webkit.org/show_bug.cgi?id=45788
866
867         * DumpRenderTree/chromium/LayoutTestController.cpp:
868         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
869
870 2010-09-14  Tony Chang  <tony@chromium.org>
871
872         Reviewed by Ojan Vafai.
873
874         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
875         https://bugs.webkit.org/show_bug.cgi?id=45768
876
877         * DumpRenderTree/chromium/TestShell.cpp:
878         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
879
880 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
881
882         [wx] Build fix, add newly added directories to the directory list.
883
884         * wx/build/settings.py:
885
886 2010-09-14  Sam Weinig  <sam@webkit.org>
887
888         Reviewed by Anders Carlsson.
889
890         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
891         https://bugs.webkit.org/show_bug.cgi?id=45785
892
893         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
894         (WTR::propertyValue):
895         (WTR::numericWindowPropertyValue):
896         (WTR::dumpPath):
897         (WTR::toStr):
898         (WTR::operator<<):
899         (WTR::InjectedBundlePage::InjectedBundlePage):
900         (WTR::InjectedBundlePage::shouldInsertNode):
901         (WTR::InjectedBundlePage::shouldBeginEditing):
902         (WTR::InjectedBundlePage::shouldEndEditing):
903         (WTR::InjectedBundlePage::shouldInsertText):
904         (WTR::InjectedBundlePage::shouldDeleteRange):
905         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
906         (WTR::InjectedBundlePage::shouldApplyStyle):
907         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
908
909 2010-09-14  Adam Barth  <abarth@webkit.org>
910
911         Fix two typos in commit-queue.  The first is harmless.  The second
912         causes the queue to reject patches when the build is broken.  :(
913
914         * Scripts/webkitpy/tool/commands/queues.py:
915         * Scripts/webkitpy/tool/commands/queues_unittest.py:
916
917 2010-09-14  Chris Guillory   <chris.guillory@google.com>
918
919         Reviewed by Chris Fleizach.
920
921         Send all accessibility notifications to Chromium.
922         https://bugs.webkit.org/show_bug.cgi?id=45156
923
924         * DumpRenderTree/chromium/WebViewHost.cpp:
925         (WebViewHost::postAccessibilityNotification):
926         * DumpRenderTree/chromium/WebViewHost.h:
927
928 2010-09-14  Adam Barth  <abarth@webkit.org>
929
930         Reviewed by Eric Seidel.
931
932         commit-queue is slow during the day
933         https://bugs.webkit.org/show_bug.cgi?id=45780
934
935         Thanks to the new logging, we've noticed that checkout-is-out-of-date
936         errors in the first pass of landing don't retry the land.  Instead,
937         they're treated as failures and cause the commit-queue to do two more
938         builds before really trying to land the patch.  Worse, in the second
939         build, we can get bitten by a flaky test.
940
941         This patch takes a slightly different approach to the commit-queue's
942         main control logic.  We now use a separate subprocess for building and
943         testing and for landing.  This means we should very rarely see the
944         checkout-is-out-of-date error, and when we do see it, we should retry
945         more quickly.  If my understanding is correct, this should be a big
946         speed win for the commit-queue.
947
948         * Scripts/webkitpy/tool/commands/download.py:
949         * Scripts/webkitpy/tool/commands/queues.py:
950         * Scripts/webkitpy/tool/commands/queues_unittest.py:
951
952 2010-09-14  Tony Chang  <tony@chromium.org>
953
954         Reviewed by Dimitri Glazkov.
955
956         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
957         https://bugs.webkit.org/show_bug.cgi?id=45762
958
959         * DumpRenderTree/chromium/LayoutTestController.cpp:
960         (LayoutTestController::LayoutTestController):
961         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
962         * DumpRenderTree/chromium/LayoutTestController.h:
963
964 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
965
966         Adding myself as a reviewer.
967
968         * Scripts/webkitpy/common/config/committers.py:
969
970 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
971
972         Reviewed by Kenneth Rohde Christiansen.
973
974         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
975         https://bugs.webkit.org/show_bug.cgi?id=45736
976
977         Build-webkit has showed a warning when WebKitBuild didn't exist, add
978         an additional condition to avoid it.
979
980         * Scripts/build-webkit:
981
982 2010-09-13  Eric Seidel  <eric@webkit.org>
983
984         Reviewed by Adam Barth.
985
986         commit-queue should log when it's retrying due to checkout out of date error
987         https://bugs.webkit.org/show_bug.cgi?id=45725
988
989         This will allow us to better track how often we see these errors
990         and how long it takes the queue to recover from them.
991
992         In order to pass the tests, I had to correct an error
993         from a previous change.  The UnitTestPort should not have
994         ever been using the base port method as that will read
995         a file from disk.  If the unit tests haven't passed the contents
996         it should raise an IOError as though the file doesn't exist.
997
998         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
999         * Scripts/webkitpy/tool/commands/queues.py:
1000         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1001
1002 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
1003
1004         Reviewed by Adam Barth.
1005
1006         Upload results when cq patch landing fails
1007         https://bugs.webkit.org/show_bug.cgi?id=45683
1008         
1009         Include script errors when CommitQueue._land fails.
1010
1011         * Scripts/webkitpy/tool/commands/queues.py:
1012
1013 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
1014
1015         Reviewed by David Kilzer.
1016
1017         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
1018         https://bugs.webkit.org/show_bug.cgi?id=45548
1019
1020         * DumpRenderTree/AccessibilityUIElement.cpp:
1021         (isIgnoredCallback):
1022         (AccessibilityUIElement::getJSClass):
1023         * DumpRenderTree/AccessibilityUIElement.h:
1024         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1025         (AccessibilityUIElement::isIgnored):
1026         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1027         (AccessibilityUIElement::isIgnored):
1028         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1029         (AccessibilityUIElement::isIgnored):
1030
1031 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1032
1033         Reviewed by Andreas Kling.
1034
1035         jscPath() is incorrect in Windows' cmd.exe shell
1036         https://bugs.webkit.org/show_bug.cgi?id=45651
1037
1038         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
1039
1040 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
1041
1042         Reviewed by Darin Adler.
1043
1044         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
1045         https://bugs.webkit.org/show_bug.cgi?id=43807
1046
1047         * DumpRenderTree/AccessibilityUIElement.cpp:
1048         (textMarkerForPointCallback):
1049         (AccessibilityUIElement::textMarkerForPoint):
1050         (AccessibilityUIElement::getJSClass):
1051         * DumpRenderTree/AccessibilityUIElement.h:
1052         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1053         (AccessibilityUIElement::textMarkerForPoint):
1054
1055 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
1056
1057         Reviewed by Kenneth Rohde Christiansen.
1058
1059         [Qt] build-webkit: Add --v8 option to build against V8
1060
1061         Note that V8 is picked up from QtScript, so this currently requires building
1062         against the experimental qt-script-v8 branch.
1063
1064         * Scripts/build-webkit:
1065
1066 2010-09-13  Hans Wennborg  <hans@chromium.org>
1067
1068         Reviewed by Jeremy Orlow.
1069
1070         Add WebDeviceOrientationClientMock::create() and use it from DRT.
1071         https://bugs.webkit.org/show_bug.cgi?id=45650
1072
1073         Do not use the WebDeviceOrientationClientMock constructor directly,
1074         but use the create() member function.
1075
1076         This should fix the linker errors for the multi-DLL Chromium DRT build.
1077
1078         * DumpRenderTree/chromium/LayoutTestController.cpp:
1079         (LayoutTestController::setMockDeviceOrientation):
1080         (LayoutTestController::deviceOrientationClient):
1081
1082 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
1083
1084         Reviewed by Antti Koivisto.
1085
1086         Add support for testing the viewport meta tag algorithm,
1087         based on the following draft spec:
1088
1089         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
1090
1091         Add common handling of viewport meta tag based on new Opera spec
1092         https://bugs.webkit.org/show_bug.cgi?id=44201
1093
1094         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1095         (LayoutTestController::dumpConfigurationForViewport):
1096         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1097
1098 2010-09-12  Kent Tamura  <tkent@chromium.org>
1099
1100         Reviewed by Tony Chang.
1101
1102         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
1103         https://bugs.webkit.org/show_bug.cgi?id=45517
1104
1105         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
1106
1107         * DumpRenderTree/chromium/ImageDiff.cpp:
1108         (Image::craeteFromStdin):
1109         (Image::createFromFilename):
1110         (diffImages):
1111         * DumpRenderTree/chromium/TestShell.cpp:
1112         (TestShell::dumpImage):
1113
1114 2010-09-10  MORITA Hajime  <morrita@google.com>
1115
1116         Reviewed by Tony Chang.
1117
1118         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
1119         https://bugs.webkit.org/show_bug.cgi?id=45441
1120
1121         Added TextInputController::hasSpellingMarker().
1122         
1123         * DumpRenderTree/chromium/TextInputController.cpp:
1124         (TextInputController::TextInputController):
1125         (TextInputController::hasSpellingMarker):
1126         * DumpRenderTree/chromium/TextInputController.h:
1127
1128 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
1129
1130         Unreviewed, build fix.
1131
1132         My last change accidentally contained a local change to the
1133         rebaselinig script; webkit-patch land picked it up without telling
1134         me and committed it :(
1135
1136         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1137
1138 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
1139
1140         Reviewed by Anders Carlsson.
1141
1142         Attempt to fix Windows MiniBrowser build (untested)
1143         https://bugs.webkit.org/show_bug.cgi?id=45609
1144
1145         * MiniBrowser/win/BrowserView.cpp:
1146         (runJavaScriptConfirm):
1147         (runJavaScriptPrompt):
1148
1149 2010-09-11  Sam Weinig  <sam@webkit.org>
1150
1151         Reviewed by Maciej Stachowiak.
1152
1153         Fix zoom related tests when testing WebKit2.
1154
1155         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1156         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
1157
1158 2010-09-11  Sam Weinig  <sam@webkit.org>
1159
1160         Reviewed by Dan Bernstein.
1161
1162         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
1163         <rdar://problem/8359252>
1164         https://bugs.webkit.org/show_bug.cgi?id=45605
1165
1166         * MiniBrowser/mac/BrowserWindowController.m:
1167         (setStatusText):
1168         (contentsSizeChanged):
1169         (-[BrowserWindowController awakeFromNib]):
1170         * MiniBrowser/win/BrowserView.cpp:
1171         (runJavaScriptConfirm):
1172         (runJavaScriptPrompt):
1173         (setStatusText):
1174         (contentsSizeChanged):
1175         (BrowserView::create):
1176         * WebKitTestRunner/TestController.cpp:
1177         (WTR::createOtherPage):
1178         (WTR::TestController::initialize):
1179
1180 2010-09-11  Sam Weinig  <sam@webkit.org>
1181
1182         Reviewed by Dan Bernstein.
1183
1184         Add callback mechanism for the getting the source of a frame
1185         <rdar://problem/8364681>
1186         https://bugs.webkit.org/show_bug.cgi?id=45604
1187
1188         Add ability to dump the main frame's source to the console.
1189
1190         * MiniBrowser/mac/BrowserWindowController.h:
1191         * MiniBrowser/mac/BrowserWindowController.m:
1192         (-[BrowserWindowController dumpSourceToConsole:]):
1193         * MiniBrowser/mac/MainMenu.xib:
1194
1195 2010-09-11  Eric Seidel  <eric@webkit.org>
1196
1197         Reviewed by Adam Barth.
1198
1199         Remove unneeded Empty Queue messages
1200         https://bugs.webkit.org/show_bug.cgi?id=45602
1201
1202         We already have a /gc job to delete these.
1203         recentstatus.py is already smart enough to use the
1204         most recent of the workitems last update or the most recent status,
1205         so removing these should not change the _last_status_date() return
1206         value more than a few milliseconds.
1207
1208         These messages just spam the recent status log.
1209
1210         * Scripts/webkitpy/tool/commands/queues.py:
1211
1212 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
1213
1214         Reviewed by Adam Barth.
1215
1216         Fix Python exception when generating synthetic patch IDs
1217         https://bugs.webkit.org/show_bug.cgi?id=45592
1218
1219         Can't concatenate strings and numbers directly.
1220
1221         * QueueStatusServer/handlers/queuestatus.py:
1222
1223 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
1224
1225         Reviewed by Adam Barth.
1226
1227         Group statuses in queue status by patch ID
1228         https://bugs.webkit.org/show_bug.cgi?id=45588
1229
1230         Group statuses by patch ID so that the status page is easier
1231         to scan.
1232
1233         * QueueStatusServer/handlers/queuestatus.py:
1234         * QueueStatusServer/stylesheets/dashboard.css:
1235         (.status-group):
1236         (.status-bug):
1237         (.status-group ul):
1238         (.status-group ul li):
1239         (.status-group ul li:hover):
1240         (.status-cell):
1241         (.status-cell:hover):
1242         (.status-cell.pass):
1243         (.status-cell.fail):
1244         (.status-cell.pending):
1245         (.status-cell.error):
1246         * QueueStatusServer/templates/dashboard.html:
1247         * QueueStatusServer/templates/queuestatus.html:
1248
1249 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
1250
1251         Reviewed by Tony Chang.
1252
1253         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
1254         https://bugs.webkit.org/show_bug.cgi?id=45479
1255
1256         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
1257         implementation in ResourceLoadDelegate in the Mac port).
1258
1259         * DumpRenderTree/chromium/LayoutTestController.cpp:
1260         (LayoutTestController::LayoutTestController):
1261         (LayoutTestController::dumpResourceResponseMIMETypes):
1262         (LayoutTestController::reset):
1263         * DumpRenderTree/chromium/LayoutTestController.h:
1264         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
1265         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
1266         * DumpRenderTree/chromium/TestShell.h:
1267         (TestShell::shouldDumpResourceResponseMIMETypes):
1268         * DumpRenderTree/chromium/WebViewHost.cpp:
1269         (WebViewHost::didReceiveResponse):
1270
1271 2010-09-11  Eric Seidel  <eric@webkit.org>
1272
1273         Reviewed by Adam Barth.
1274
1275         queues.webkit.org should expose /remote_api for data upload/download
1276         https://bugs.webkit.org/show_bug.cgi?id=45559
1277
1278         * QueueStatusServer/app.yaml:
1279          - /remote_api is a standard app-engine service which allows use of
1280            the bulk uploader for data upload/download.  Exposing this
1281            (for admin access only) allows us to use 
1282
1283 2010-09-10  Sam Weinig  <sam@webkit.org>
1284
1285         Reviewed by Dan Bernstein.
1286
1287         Add zoom support to WebKit2 API
1288         <rdar://problem/7660657>
1289         https://bugs.webkit.org/show_bug.cgi?id=45585
1290
1291         - Add zoom options to MiniBrowser that mimic Safari's options using
1292           the new WebKit2 zoom APIs.
1293         - Switch uses of float for the zoom APIs to use double.
1294
1295         * MiniBrowser/mac/BrowserWindowController.h:
1296         * MiniBrowser/mac/BrowserWindowController.m:
1297         (-[BrowserWindowController initWithPageNamespace:]):
1298         (-[BrowserWindowController validateMenuItem:]):
1299         (-[BrowserWindowController validateUserInterfaceItem:]):
1300         (-[BrowserWindowController currentZoomFactor]):
1301         (-[BrowserWindowController setCurrentZoomFactor:]):
1302         (-[BrowserWindowController canZoomIn]):
1303         (-[BrowserWindowController zoomIn:]):
1304         (-[BrowserWindowController canZoomOut]):
1305         (-[BrowserWindowController zoomOut:]):
1306         (-[BrowserWindowController canResetZoom]):
1307         (-[BrowserWindowController resetZoom:]):
1308         (-[BrowserWindowController toggleZoomMode:]):
1309         * MiniBrowser/mac/MainMenu.xib:
1310         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1311         (WTR::EventSendingController::textZoomIn):
1312         (WTR::EventSendingController::textZoomOut):
1313         (WTR::EventSendingController::zoomPageIn):
1314         (WTR::EventSendingController::zoomPageOut):
1315
1316 2010-09-10  Robert Hogan  <robert@webkit.org>
1317
1318         Reviewed by Andreas Kling.
1319
1320         [Qt] Fix crash in DRT in standalone mode
1321
1322         https://bugs.webkit.org/show_bug.cgi?id=45454
1323
1324         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1325         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1326
1327 2010-09-10  Sam Weinig  <sam@webkit.org>
1328
1329         Reviewed by Darin Adler.
1330
1331         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
1332         Precursor to <rdar://problem/7660657>
1333         https://bugs.webkit.org/show_bug.cgi?id=45522
1334
1335         Update for changes to the Bundle API to allow separate control of page and text zoom
1336         levels.
1337
1338         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1339         (WTR::EventSendingController::textZoomIn):
1340         (WTR::EventSendingController::textZoomOut):
1341         (WTR::EventSendingController::zoomPageIn):
1342         (WTR::EventSendingController::zoomPageOut):
1343         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1344         (WTR::InjectedBundlePage::reset):
1345
1346 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
1347
1348         Reviewed by Andreas Kling.
1349
1350         [Qt] Support click event for notifications
1351         https://bugs.webkit.org/show_bug.cgi?id=44836
1352
1353         Add support for simulateDesktopNotificationClick by calling
1354         back to DumpRenderTreeSupportQt.cpp.
1355
1356         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1357         (LayoutTestController::simulateDesktopNotificationClick):
1358         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1359
1360 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
1361
1362         Reviewed by Eric Seidel.
1363
1364         Update queue status when patches fail their first land attempt
1365         https://bugs.webkit.org/show_bug.cgi?id=45583
1366
1367         Add a few more _update_status calls to make it more obvious if a patch is 
1368         being retried because tests failed.
1369
1370         * Scripts/webkitpy/tool/commands/queues.py:
1371
1372 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
1373
1374         Reviewed by Andreas Kling.
1375
1376         [Qt] MiniBrowser crashes with multiply windows when closing one of them
1377         https://bugs.webkit.org/show_bug.cgi?id=45536
1378
1379         * MiniBrowser/qt/BrowserView.cpp:
1380         (BrowserView::BrowserView): Reference the context instead of adopting it
1381         because it can be shared across different views.
1382
1383 2010-09-10  Tony Chang  <tony@chromium.org>
1384
1385         Unreviewed, rolling out r67241.
1386         http://trac.webkit.org/changeset/67241
1387         https://bugs.webkit.org/show_bug.cgi?id=44709
1388
1389         Accidentally committed.
1390
1391         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1392         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1393
1394 2010-09-10  Tony Chang  <tony@chromium.org>
1395
1396         Reviewed by Ojan Vafai.
1397
1398         deduplicate-tests should be runnable from any WebKit directory
1399         https://bugs.webkit.org/show_bug.cgi?id=44709
1400
1401         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1402         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1403
1404 2010-09-10  Tony Chang  <tony@chromium.org>
1405
1406         Unreviewed, rolling out r67216.
1407         http://trac.webkit.org/changeset/67216
1408         https://bugs.webkit.org/show_bug.cgi?id=44709
1409
1410         Broke
1411
1412         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1413         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1414
1415 2010-09-10  Tony Chang  <tony@chromium.org>
1416
1417         Reviewed by Ojan Vafai.
1418
1419         deduplicate-tests should be runnable from any WebKit directory
1420         https://bugs.webkit.org/show_bug.cgi?id=44709
1421
1422         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1423         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1424
1425 2010-09-09  Hans Wennborg  <hans@chromium.org>
1426
1427         Reviewed by Jeremy Orlow.
1428
1429         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
1430         https://bugs.webkit.org/show_bug.cgi?id=45460
1431
1432         This enables DumpRenderTree to run layout tests for DeviceOrientation.
1433
1434         Also declare the LayoutTestController destructor out-of-line.
1435         Otherwise the implicit destructor would cause compiler errors because
1436         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
1437
1438         * DumpRenderTree/chromium/LayoutTestController.cpp:
1439         (LayoutTestController::~LayoutTestController):
1440         (LayoutTestController::setMockDeviceOrientation):
1441         (LayoutTestController::deviceOrientationClient):
1442         * DumpRenderTree/chromium/LayoutTestController.h:
1443         * DumpRenderTree/chromium/WebViewHost.cpp:
1444         (WebViewHost::deviceOrientationClient):
1445         * DumpRenderTree/chromium/WebViewHost.h:
1446
1447 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1448
1449         Unreviewed, rolling out r67119.
1450         http://trac.webkit.org/changeset/67119
1451         https://bugs.webkit.org/show_bug.cgi?id=45505
1452
1453         Extra newlines in results (Requested by tony^work on #webkit).
1454
1455         * DumpRenderTree/chromium/LayoutTestController.cpp:
1456         (LayoutTestController::LayoutTestController):
1457         (LayoutTestController::reset):
1458         * DumpRenderTree/chromium/LayoutTestController.h:
1459         * DumpRenderTree/chromium/TestShell.h:
1460         * DumpRenderTree/chromium/WebViewHost.cpp:
1461         (printResponseDescription):
1462         (printNodeDescription):
1463         (printRangeDescription):
1464         (WebViewHost::shouldBeginEditing):
1465         (WebViewHost::shouldEndEditing):
1466         (WebViewHost::shouldInsertNode):
1467         (WebViewHost::shouldChangeSelectedRange):
1468         (WebViewHost::shouldDeleteRange):
1469         (WebViewHost::shouldApplyStyle):
1470         (WebViewHost::didBeginEditing):
1471         (WebViewHost::didChangeSelection):
1472         (WebViewHost::didChangeContents):
1473         (WebViewHost::didEndEditing):
1474         (WebViewHost::decidePolicyForNavigation):
1475         (WebViewHost::didCancelClientRedirect):
1476         (WebViewHost::didStartProvisionalLoad):
1477         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
1478         (WebViewHost::didFailProvisionalLoad):
1479         (WebViewHost::didCommitProvisionalLoad):
1480         (WebViewHost::didFinishDocumentLoad):
1481         (WebViewHost::didHandleOnloadEvents):
1482         (WebViewHost::didFailLoad):
1483         (WebViewHost::didFinishLoad):
1484         (WebViewHost::didChangeLocationWithinPage):
1485         (WebViewHost::willSendRequest):
1486         (WebViewHost::didReceiveResponse):
1487         (WebViewHost::didFinishResourceLoad):
1488         (WebViewHost::didFailResourceLoad):
1489         (WebViewHost::didDisplayInsecureContent):
1490         (WebViewHost::didRunInsecureContent):
1491         (WebViewHost::printFrameDescription):
1492
1493 2010-09-09  Michael Saboff  <msaboff@apple.com>
1494
1495         Unreviewed, adding myself to committers list.
1496
1497         * Scripts/webkitpy/common/config/committers.py:
1498
1499 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
1500
1501         Reviewed by Tony Chang.
1502
1503         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
1504         https://bugs.webkit.org/show_bug.cgi?id=45479
1505
1506         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
1507         implementation in ResourceLoadDelegate in the Mac port).
1508
1509         * DumpRenderTree/chromium/LayoutTestController.cpp:
1510         (LayoutTestController::LayoutTestController):
1511         (LayoutTestController::dumpResourceResponseMIMETypes):
1512         (LayoutTestController::reset):
1513         * DumpRenderTree/chromium/LayoutTestController.h:
1514         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
1515         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
1516         * DumpRenderTree/chromium/TestShell.h:
1517         (TestShell::shouldDumpResourceResponseMIMETypes):
1518         * DumpRenderTree/chromium/WebViewHost.cpp:
1519         (WebViewHost::didReceiveResponse):
1520
1521 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
1522
1523         Reviewed by Daniel Bates.
1524
1525         svn-apply tries to delete directories it shouldn't
1526         https://bugs.webkit.org/show_bug.cgi?id=45424
1527
1528         isDirectoryEmptyForRemoval had the wrong check. If an item in the
1529         directory is itself a directory, then the directory is definitely
1530         not empty.
1531
1532         * Scripts/svn-apply:
1533
1534 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
1535
1536         Fixing GTK and windows build failure.
1537
1538         AX: Support AccessibilityTextMarkers in DRT
1539         https://bugs.webkit.org/show_bug.cgi?id=44778
1540
1541         * DumpRenderTree/AccessibilityTextMarker.h:
1542         (AccessibilityTextMarker::platformTextMarker):
1543         (AccessibilityTextMarkerRange::platformTextMarkerRange):
1544         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1545         (AccessibilityTextMarker::platformTextMarker):
1546         (AccessibilityTextMarkerRange::platformTextMarkerRange):
1547
1548 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
1549
1550         Reviewed by David Kilzer.
1551
1552         AX: Support AccessibilityTextMarkers in DRT
1553         https://bugs.webkit.org/show_bug.cgi?id=44778
1554
1555         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
1556         that WebCore uses when vending information about its VisiblePositions through AX.
1557
1558         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
1559         methods for encapsulating and checking equality.
1560
1561         This will allow future bug fixes in the text marker system to be adequately tested.
1562
1563         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
1564         (toTextMarker):
1565         (isMarkerEqualCallback):
1566         (markerFinalize):
1567         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
1568         (AccessibilityTextMarker::getJSClass):
1569         (toTextMarkerRange):
1570         (isMarkerRangeEqualCallback):
1571         (markerRangeFinalize):
1572         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
1573         (AccessibilityTextMarkerRange::getJSClass):
1574         * DumpRenderTree/AccessibilityTextMarker.h: Added.
1575         (AccessibilityTextMarker::platformTextMarker):
1576         (AccessibilityTextMarkerRange::platformTextMarkerRange):
1577         (AccessibilityTextMarker::AccessibilityTextMarker):
1578         (AccessibilityTextMarker::~AccessibilityTextMarker):
1579         (AccessibilityTextMarker::isEqual):
1580         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
1581         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
1582         (AccessibilityTextMarkerRange::isEqual):
1583         * DumpRenderTree/AccessibilityUIElement.cpp:
1584         (textMarkerRangeForElementCallback):
1585         (textMarkerRangeLengthCallback):
1586         (textMarkerRangeForMarkersCallback):
1587         (startTextMarkerForTextMarkerRangeCallback):
1588         (endTextMarkerForTextMarkerRangeCallback):
1589         (accessibilityElementForTextMarkerCallback):
1590         (AccessibilityUIElement::textMarkerRangeForElement):
1591         (AccessibilityUIElement::textMarkerRangeLength):
1592         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1593         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1594         (AccessibilityUIElement::accessibilityElementForTextMarker):
1595         (AccessibilityUIElement::getJSClass):
1596         * DumpRenderTree/AccessibilityUIElement.h:
1597         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1598         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
1599         (AccessibilityTextMarker::AccessibilityTextMarker):
1600         (AccessibilityTextMarker::~AccessibilityTextMarker):
1601         (AccessibilityTextMarker::isEqual):
1602         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
1603         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
1604         (AccessibilityTextMarkerRange::isEqual):
1605         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1606         (AccessibilityUIElement::textMarkerRangeForElement):
1607         (AccessibilityUIElement::textMarkerRangeLength):
1608         (AccessibilityUIElement::textMarkerRangeForMarkers):
1609         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1610         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1611         (AccessibilityUIElement::accessibilityElementForTextMarker):
1612         * DumpRenderTree/win/DumpRenderTree.vcproj:
1613
1614 2010-08-25  Tony Chang  <tony@chromium.org>
1615
1616         Reviewed by Ojan Vafai.
1617
1618         don't delete duplicates needed because of intermediate results
1619         https://bugs.webkit.org/show_bug.cgi?id=44653
1620
1621         Also, output the full path so we can pipe the output to rm.
1622
1623         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1624         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1625
1626 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
1627
1628         Reviewed by Andreas Kling.
1629
1630         [Qt] MiniBrowser does not starts properly
1631         https://bugs.webkit.org/show_bug.cgi?id=45459
1632
1633         Do not try set up the first window by calling newWindow on a
1634         newly created BrowserWindow since it creates a new object.
1635         * MiniBrowser/qt/BrowserWindow.cpp:
1636         (BrowserWindow::BrowserWindow):
1637         * MiniBrowser/qt/main.cpp:
1638         (main):
1639
1640 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
1641
1642         Reviewed by Xan Lopez.
1643
1644         [GTK] Get ImageDiff building on Win32
1645         https://bugs.webkit.org/show_bug.cgi?id=45353
1646
1647         * DumpRenderTree/gtk/ImageDiff.cpp:
1648         (main): Switch from using strtok to g_strsplit.
1649
1650 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
1651
1652         Reviewed by Andreas Kling.
1653
1654         [Qt] Modify load method of MiniBrowser's BrowserView class
1655         https://bugs.webkit.org/show_bug.cgi?id=45442
1656
1657         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
1658
1659         * MiniBrowser/qt/BrowserView.cpp:
1660         (BrowserView::load):
1661         * MiniBrowser/qt/BrowserView.h:
1662         * MiniBrowser/qt/BrowserWindow.cpp:
1663         (BrowserWindow::load):
1664
1665 2010-09-09  Tony Chang  <tony@chromium.org>
1666
1667         Reviewed by Ojan Vafai.
1668
1669         fix show_results in new-run-webkit-tests
1670         https://bugs.webkit.org/show_bug.cgi?id=45413
1671
1672         * Scripts/webkitpy/layout_tests/port/chromium.py:
1673
1674 2010-09-08  Victor Wang  <victorw@chromium.org>
1675
1676         Reviewed by Ojan Vafai.
1677
1678         [Chromium] Fix test results server to make sure
1679         it does not have corrupted data.
1680
1681         results.json file size coulbe be >1M and we split
1682         the data into multiple data store entries in this
1683         case. This patch fixes the issue that the data may
1684         be corrupted if data store error happens in the middle
1685         of saving multiple entries.
1686
1687         https://bugs.webkit.org/show_bug.cgi?id=45063
1688
1689         * TestResultServer/model/datastorefile.py:
1690
1691 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
1692
1693         Reviewed by Kenneth Rohde Christiansen.
1694
1695         Fix ignoring return value warning in case of gcc 4.4.4
1696         https://bugs.webkit.org/show_bug.cgi?id=45384
1697
1698         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1699         (testPostURLFile):
1700         If fwrite have written zero byte then the testPostURLFile function
1701         returns with false as tempFile can't be opened.
1702         * DumpRenderTree/qt/ImageDiff.cpp:
1703         (main):
1704         Put fwrite function into an if condition without body to avoid
1705         warning. It is safe because this function writes to the stdout.
1706
1707 2010-09-08  Satish Sampath  <satish@chromium.org>
1708
1709         Unreviewed, adding myself to committers list.
1710
1711         * Scripts/webkitpy/common/config/committers.py:
1712
1713 2010-09-08  Hans Wennborg  <hans@chromium.org>
1714
1715         Unreviewed.
1716
1717         Adding myself as a committer in committers.py.
1718
1719         * Scripts/webkitpy/common/config/committers.py:
1720
1721 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
1722
1723         Reviewed by Simon Hausmann.
1724
1725         [Qt] Refactor MiniBrowser 
1726         https://bugs.webkit.org/show_bug.cgi?id=45173
1727
1728         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
1729
1730         * MiniBrowser/qt/BrowserView.cpp: Added.
1731         (createNewPage):
1732         (BrowserView::BrowserView):
1733         (BrowserView::resizeEvent):
1734         (BrowserView::load):
1735         (BrowserView::view):
1736         * MiniBrowser/qt/BrowserView.h: Added.
1737         (BrowserView::~BrowserView):
1738         * MiniBrowser/qt/BrowserWindow.cpp:
1739         * MiniBrowser/qt/BrowserWindow.h:
1740         * MiniBrowser/qt/MiniBrowser.pro:
1741
1742 2010-09-08  Adam Barth  <abarth@webkit.org>
1743
1744         Rubber-stamped by Eric Seidel.
1745
1746         Rename DocLoader to CachedResourceLoader because that's what it does.
1747
1748         * Scripts/do-webcore-rename:
1749
1750 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
1751
1752         Reviewed by Ojan Vafai.
1753
1754         Enable incremental results.json generation for non-layout tests.
1755         https://bugs.webkit.org/show_bug.cgi?id=45315
1756
1757         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
1758
1759         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
1760
1761
1762 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
1763
1764         Unreviewed, build fix
1765
1766         Missed one test in mac_unittest.py in previous change; for some
1767         reason the method is listed twice. I will fix both for now, but will
1768         figure this out in a later, not-time-sensitive patch.
1769
1770         https://bugs.webkit.org/show_bug.cgi?id=45357
1771
1772         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1773
1774 2010-09-07  Kent Tamura  <tkent@chromium.org>
1775
1776         Reviewed by Tony Chang.
1777
1778         test-webkitpy: Fix load error of
1779         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
1780         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
1781
1782         * Scripts/webkitpy/layout_tests/port/server_process.py:
1783           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
1784           and we don't use server_process.py on Win32 Python. However
1785           unittest.py tries to load everything in a module.
1786
1787 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
1788
1789         Reviewed by Kent Tamura.
1790
1791         Fix regression introduced in previous change to new-run-webkit-tests
1792         (bug 45090) to not try to run unittests for the Mac implementation
1793         of the Port interface if we aren't running on a Mac.
1794
1795         Also fix the overrides implementation mock in the chromium unittests
1796         to fix the case where there are overrides checked in that cause
1797         problems.
1798
1799         https://bugs.webkit.org/show_bug.cgi?id=45357
1800
1801         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1802         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1803         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1804
1805 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
1806
1807         Reviewed by Ojan Vafai.
1808
1809         new-run-webkit-tests: still more unit tests
1810
1811         Clean up and remove unnecessary code. Biggest notable change is
1812         moving the chromium-specific imagediff code from port/base to
1813         port/chromium.
1814
1815         Add more unit tests for run_webkit_tests.py, port/base.py,
1816         port/factory.py, port/dryrun.py, and
1817         layout_package/dump_render_tree_thread.py
1818
1819         This covers almost all of the generic and test code paths except for
1820         a few error paths involving invalid or port-specific command line
1821         arguments, and the code path for uploading results files to the
1822         buildbots.
1823         
1824         https://bugs.webkit.org/show_bug.cgi?id=45090
1825
1826         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
1827         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
1828         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
1829         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
1830         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
1831         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1832         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
1833         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
1834         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1835         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
1836         * Scripts/webkitpy/layout_tests/port/base.py:
1837         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1838         * Scripts/webkitpy/layout_tests/port/chromium.py:
1839         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1840         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1841         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1842         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
1843         * Scripts/webkitpy/layout_tests/port/server_process.py:
1844         * Scripts/webkitpy/layout_tests/port/test.py:
1845         * Scripts/webkitpy/layout_tests/port/webkit.py:
1846         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1847         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1848
1849 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
1850
1851         Reviewed by Darin Adler.
1852
1853         Provide a way to trigger a <select multiple> onchange event on changes
1854         https://bugs.webkit.org/show_bug.cgi?id=45192
1855
1856         Adds a selector on ObjCController for testing
1857         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
1858         its different uses.
1859
1860         * DumpRenderTree/mac/ObjCController.m:
1861         (+[ObjCController isSelectorExcludedFromWebScript:]):
1862         (+[ObjCController webScriptNameForSelector:]):
1863         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
1864
1865 2010-09-07  James Robinson  <jamesr@chromium.org>
1866
1867         Rubber-stamped by Dimitri Glazkov.
1868
1869         Move myself from the committer to the reviewer list.
1870
1871         * Scripts/webkitpy/common/config/committers.py:
1872
1873 2010-09-07  Tony Chang  <tony@chromium.org>
1874
1875         Reviewed by Darin Fisher.
1876
1877         [chromium] Make a public flag for how DRT generates bitmaps on Linux
1878         https://bugs.webkit.org/show_bug.cgi?id=45133
1879
1880         * DumpRenderTree/chromium/TestShell.cpp:
1881         (TestShell::dumpImage):
1882
1883 2010-09-07  Kent Tamura  <tkent@chromium.org>
1884
1885         Reviewed by Dimitri Glazkov.
1886
1887         [DRT/Chromium] Implement --check-layout-test-sys-deps
1888         https://bugs.webkit.org/show_bug.cgi?id=45283
1889
1890         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1891         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
1892         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
1893         * DumpRenderTree/chromium/TestShellGtk.cpp:
1894         (checkLayoutTestSystemDependencies): Add an empty implementation.
1895         * DumpRenderTree/chromium/TestShellMac.mm:
1896         (checkLayoutTestSystemDependencies): Add an empty implementation.
1897         * DumpRenderTree/chromium/TestShellWin.cpp:
1898         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
1899
1900 2010-09-07  Jessie Berlin  <jberlin@apple.com>
1901
1902         Unreviewed. Mac build fix.
1903
1904         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1905         (didClearWindowObjectForFrame):
1906
1907 2010-09-07  Jessie Berlin  <jberlin@apple.com>
1908
1909         Reviewed by Darin Adler.
1910
1911         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
1912         https://bugs.webkit.org/show_bug.cgi?id=45217
1913         
1914         Make WebKitTestRunner work with this change.
1915
1916         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1917         (WTR::InjectedBundlePage::didClearWindowForFrame):
1918         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
1919         WebFrameLoaderClient.
1920         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1921
1922 2010-09-07  Philippe Normand  <pnormand@igalia.com>
1923
1924         Unreviewed, build fix.
1925
1926         webkit-patch command to find the ports covering a specific layout test
1927         https://bugs.webkit.org/show_bug.cgi?id=42832
1928
1929         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
1930         tests are present when building the expectations. This is needed
1931         for the unittests.
1932
1933 2010-09-06  Philippe Normand  <pnormand@igalia.com>
1934
1935         Reviewed by Adam Barth.
1936
1937         webkit-patch command to find the ports covering a specific layout test
1938         https://bugs.webkit.org/show_bug.cgi?id=42832
1939
1940         To use it: webkit-patch skipped-ports some/layout/test.html
1941
1942         * Scripts/webkitpy/layout_tests/port/base.py:
1943         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1944         * Scripts/webkitpy/layout_tests/port/chromium.py:
1945         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1946         * Scripts/webkitpy/layout_tests/port/factory.py:
1947         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1948         * Scripts/webkitpy/layout_tests/port/test.py:
1949         * Scripts/webkitpy/layout_tests/port/webkit.py:
1950         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1951         * Scripts/webkitpy/tool/commands/queries.py:
1952         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1953         * Scripts/webkitpy/tool/main.py:
1954         * Scripts/webkitpy/tool/mocktool.py:
1955
1956 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1957
1958         Reviewed by Eric Seidel.
1959
1960         [NRWT] Add temp directory to all running drivers.
1961         https://bugs.webkit.org/show_bug.cgi?id=45261
1962
1963         * Scripts/webkitpy/layout_tests/port/webkit.py:
1964
1965 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
1966
1967         Reviewed by Kent Tamura.
1968
1969         [Chromium/DRT] Empty out user stylesheet after each test run.
1970         https://bugs.webkit.org/show_bug.cgi?id=45282
1971
1972         This should significantly cut down on the number of the mysterious flaky tests
1973         whose diffs looked like the page was blown up to a very lage size. This
1974         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
1975         which set the base body font to 100px.
1976
1977         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
1978         the same thread failed.
1979
1980         * DumpRenderTree/chromium/TestShell.cpp:
1981         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
1982
1983 2010-09-06  Kent Tamura  <tkent@chromium.org>
1984
1985         Reviewed by Dimitri Glazkov.
1986
1987         [DRT/Chromium] Do not generate pixel results for text/plain resources
1988         https://bugs.webkit.org/show_bug.cgi?id=45253
1989
1990         * DumpRenderTree/chromium/TestShell.cpp:
1991         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
1992
1993 2010-09-06  Ojan Vafai  <ojan@chromium.org>
1994
1995         Reviewed by Kent Tamura.
1996
1997         print out correct error when a DRT thread dies in NRWT
1998         https://bugs.webkit.org/show_bug.cgi?id=45281
1999
2000         Not sure why, but with the parens, python 2.6.5 on Linux
2001         gives an error that raise takes 5 arguments and 0 were given.
2002         Didn't test other platforms or python versions, but putting it
2003         all on one line fixes it and correctly prints the exception
2004         from the DRT thread.
2005
2006         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2007
2008 2010-09-06  Eric Seidel  <eric@webkit.org>
2009
2010         Unreviewed, just adding some emails from lists.webkit.org.
2011
2012         Update committers.py to include emails from lists.webkit.org
2013         as found by the validate-committer-lists script.
2014
2015         * Scripts/webkitpy/common/config/committers.py:
2016
2017 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
2018
2019         Reviewed by Xan Lopez.
2020
2021         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
2022         https://bugs.webkit.org/show_bug.cgi?id=45213
2023
2024         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2025         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
2026         have to surround the invocation with #ifdefs.
2027         (useLongRunningServerMode): Added.
2028         (runTestingServerLoop): Added.
2029         (initializeGlobalsFromCommandLineOptions): Added.
2030         (runTest): Removed ifdefs.
2031         (main): Use new helper functions.
2032
2033 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
2034
2035         Reviewed by Xan Lopez.
2036
2037         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
2038         https://bugs.webkit.org/show_bug.cgi?id=45235
2039
2040         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
2041         methods of the EventSender.
2042
2043         * DumpRenderTree/gtk/EventSender.cpp:
2044         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
2045         with the current modifiers.
2046         (contextClickCallback): Always send no modifiers when preparing the mouse event.
2047         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
2048         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
2049         (mouseUpCallback): Ditto.
2050
2051 2010-09-05  Peter Kasting  <pkasting@google.com>
2052
2053         Reviewed by Adam Barth.
2054
2055         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
2056         https://bugs.webkit.org/show_bug.cgi?id=45155
2057
2058         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
2059         (EventSender::handleMouseWheel):
2060
2061 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
2062
2063         Reviewed by Joseph Pecoraro.
2064
2065         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
2066         https://bugs.webkit.org/show_bug.cgi?id=45179
2067
2068         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2069         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2070
2071 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
2072
2073         Rubber-stamped by Daniel Bates.
2074
2075         Adding myself as reviewer.
2076
2077         * Scripts/webkitpy/common/config/committers.py:
2078
2079 2010-09-04  Daniel Bates  <dbates@rim.com>
2080
2081         Reviewed by Martin Robinson.
2082
2083         Teach svn-apply/unapply about svn:mergeinfo
2084         https://bugs.webkit.org/show_bug.cgi?id=45236
2085
2086         Recognize the svn:mergeinfo property and ignore it for now.
2087
2088         Currently, svn-apply/unapply recognize only '+' and '-'
2089         property changes within a diff. We should add support
2090         to recognize "Merged" and "Reverse-merged" changes as well.
2091         Because svn:mergeinfo is metadata that is used only by SVN
2092         and tends to be error-prone and/or nuisance (*), we will ignore
2093         it for now.
2094         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
2095
2096         * Scripts/VCSUtils.pm:
2097           - Modified parseSvnProperty() to recognize "Merged" and
2098             "Reverse-merged" as the start of a property value.
2099         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
2100           - Added the following unit tests:
2101             "simple: add svn:mergeinfo"
2102             "simple: delete svn:mergeinfo"
2103             "simple: modified svn:mergeinfo"
2104         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2105           - Added the following unit tests:
2106             "simple: add svn:mergeinfo"
2107             "simple: delete svn:mergeinfo"
2108             "simple: modified svn:mergeinfo"
2109             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
2110             "'Merged' change followed by 'Merged' change"
2111             "'Reverse-merged' change followed by 'Reverse-merged' change"
2112         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2113           - Added the following unit tests:
2114             "'Merged' change"
2115             "'Reverse-merged' change"
2116             "'Reverse-merged' change followed by 'Merge' change"
2117             "'Merged' change followed by 'Merge' change"
2118             "'Reverse-merged' change followed by 'Reverse-merged' change"
2119             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
2120
2121 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2122
2123         Reviewed by Kenneth Rohde Christiansen.
2124
2125         [EFL] Move test browser to WebKitTools directory
2126         https://bugs.webkit.org/show_bug.cgi?id=45212
2127
2128         Follow other ports like QT and GTK which moved the test browser to
2129         WebKitTools directory.
2130
2131         * CMakeListsEfl.txt: Added.
2132         * EWebLauncher/main.c: Added.
2133         (print_history):
2134         (zoom_level_set):
2135         (on_ecore_evas_resize):
2136         (title_set):
2137         (viewport_set):
2138         (on_title_changed):
2139         (on_progress):
2140         (on_load_finished):
2141         (on_toolbars_visible_set):
2142         (on_toolbars_visible_get):
2143         (on_statusbar_visible_set):
2144         (on_statusbar_visible_get):
2145         (on_scrollbars_visible_set):
2146         (on_scrollbars_visible_get):
2147         (on_menubar_visible_set):
2148         (on_menubar_visible_get):
2149         (on_tooltip_text_set):
2150         (on_inputmethod_changed):
2151         (on_viewport_changed):
2152         (on_mouse_down):
2153         (on_focus_out):
2154         (on_focus_in):
2155         (on_resized):
2156         (on_key_down):
2157         (on_browser_del):
2158         (on_closeWindow):
2159         (quit):
2160         (browserCreate):
2161         (browserDestroy):
2162         (closeWindow):
2163         (main_signal_exit):
2164         (findThemePath):
2165         (main):
2166
2167 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
2168
2169         Reviewed by Adam Roben.
2170
2171         Set project dependencies so that they build serially. This fixes
2172         issues when running run-webkit-tests if DRT is not built yet.
2173
2174         * DumpRenderTree/DumpRenderTree.sln:
2175
2176 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
2177
2178         Reviewed by Adam Barth.
2179
2180         Fix reading configuraiton in NWRT to work on Windows.
2181         https://bugs.webkit.org/show_bug.cgi?id=45180
2182
2183         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
2184             with the file otherwise.
2185
2186 2010-09-03  Chris Rogers  <crogers@google.com>
2187
2188         Unreviewed
2189
2190         Add myself to the committers list
2191         https://bugs.webkit.org/show_bug.cgi?id=45189
2192
2193         * Scripts/webkitpy/common/config/committers.py:
2194
2195 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
2196
2197         Reviewed by Yury Semikhatsky.
2198
2199         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
2200         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
2201         https://bugs.webkit.org/show_bug.cgi?id=45137
2202
2203         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
2204
2205 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2206
2207         Reviewed by Eric Seidel.
2208
2209         Add feature detection support to NRWT.
2210         https://bugs.webkit.org/show_bug.cgi?id=41842
2211
2212         * Scripts/webkitpy/layout_tests/port/base.py:
2213         * Scripts/webkitpy/layout_tests/port/qt.py:
2214         * Scripts/webkitpy/layout_tests/port/webkit.py:
2215         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
2216
2217 2010-09-03  Hironori Bono  <hbono@chromium.org>
2218
2219         Reviewed by Kent Tamura.
2220
2221         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
2222         and implements it for Mac.
2223         https://bugs.webkit.org/show_bug.cgi?id=41832
2224
2225         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
2226         and bind it so we can call it from JavaScript.
2227         (+[TextInputController isSelectorExcludedFromWebScript:]):
2228         (+[TextInputController webScriptNameForSelector:]):
2229         (-[TextInputController hasSpellingMarker:length:]):
2230
2231 2010-09-02  Eric Seidel  <eric@webkit.org>
2232
2233         Reviewed by Adam Barth.
2234
2235         Add a unit test for commit-queue retries
2236         https://bugs.webkit.org/show_bug.cgi?id=45162
2237
2238         I think commit-queue retries are not correctly avoiding
2239         build and test on retries.  So I started testing the code.
2240         Unfortunately this test did not find the bug.  But now
2241         that we have the test we might as well keep it.
2242         I also fixed a broken import in validate-committer-lists.
2243
2244         * Scripts/validate-committer-lists:
2245         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2246
2247 2010-09-02  Kent Tamura  <tkent@chromium.org>
2248
2249         Reviewed by Dimitri Glazkov.
2250
2251         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
2252         https://bugs.webkit.org/show_bug.cgi?id=45091
2253
2254         Task.{cpp,h} introduces a simpler version of Chromium
2255         base/task.h. It doesn't have TupleN and Method.
2256
2257         * DumpRenderTree/DumpRenderTree.gypi:
2258          Add Task.cpp and Task.h
2259         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2260         (DRTDevToolsAgent::DRTDevToolsAgent):
2261         (DRTDevToolsAgent::reset):
2262         (DRTDevToolsAgent::asyncCall):
2263         (DRTDevToolsAgent::frontendLoaded):
2264         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2265         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
2266         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2267         (DRTDevToolsClient::DRTDevToolsClient):
2268         (DRTDevToolsClient::~DRTDevToolsClient):
2269         (DRTDevToolsClient::reset):
2270         (DRTDevToolsClient::asyncCall):
2271         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2272         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
2273         * DumpRenderTree/chromium/EventSender.cpp:
2274         (EventSender::EventSender):
2275         (EventSender::reset):
2276         (EventSender::scheduleAsynchronousClick):
2277         * DumpRenderTree/chromium/EventSender.h:
2278         (EventSender::taskList): Added to use MethodTask<T>.
2279         * DumpRenderTree/chromium/LayoutTestController.cpp:
2280         (LayoutTestController::LayoutTestController):
2281         (LayoutTestController::WorkQueue::processWorkSoon):
2282         (LayoutTestController::waitUntilDone):
2283         (LayoutTestController::notifyDone):
2284         (LayoutTestController::reset):
2285         * DumpRenderTree/chromium/LayoutTestController.h:
2286         (LayoutTestController::taskList): Added to use MethodTask<T>.
2287         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
2288         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2289         (deferredDisplayDispatch):
2290         (NotificationPresenter::show):
2291         * DumpRenderTree/chromium/Task.cpp: Added.
2292         * DumpRenderTree/chromium/Task.h: Added.
2293
2294 2010-09-02  Steve Block  <steveblock@google.com>
2295
2296         Reviewed by Adam Barth.
2297
2298         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
2299         https://bugs.webkit.org/show_bug.cgi?id=43181
2300
2301         * DumpRenderTree/mac/DumpRenderTree.mm:
2302         (createWebViewAndOffscreenWindow):
2303         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2304         (LayoutTestController::setMockDeviceOrientation):
2305
2306 2010-08-31  Adam Roben  <aroben@apple.com>
2307
2308         Fix flashiness when resizing the browser window on Windows
2309
2310         Reviewed by Sam Weinig.
2311
2312         * MiniBrowser/win/BrowserWindow.cpp:
2313         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
2314         periodically fill the window with white.
2315
2316 2010-09-02  Peter Kasting  <pkasting@google.com>
2317
2318         Reviewed by Dimitri Glazkov.
2319
2320         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
2321         https://bugs.webkit.org/show_bug.cgi?id=45073
2322
2323         * DumpRenderTree/chromium/EventSender.cpp:
2324         (EventSender::EventSender):
2325         (EventSender::mouseScrollBy):
2326         (EventSender::continuousMouseScrollBy):
2327         (EventSender::sendCurrentTouchEvent):
2328         (EventSender::handleMouseWheel):
2329         * DumpRenderTree/chromium/EventSender.h:
2330         * DumpRenderTree/gtk/EventSender.cpp:
2331         (mouseScrollByCallback):
2332         (continuousMouseScrollByCallback):
2333
2334 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
2335
2336         Reviewed by Tony Chang.
2337
2338         Land a patched version of r66542 - change TestRunner to have an
2339         separate cleanup method and fix the ordering of cleanup between
2340         TestRunner and the printing module, and then wrap everything in a
2341         try/finally block to ensure reliable cleanup without needing to
2342         rely on stuff happening in the destructor of the TestRunner.
2343
2344         Also refactor run_webkit_tests.run() to be much smaller and cleaner
2345         by creating a bunch of helper methods and moving more stuff into
2346         the TestRunner class.
2347
2348         This fixes the crash at the end of the linux test run of
2349         new-run-webkit-tests (and undoes the rollout in 66547).
2350
2351         https://bugs.webkit.org/show_bug.cgi?id=44902
2352
2353         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
2354         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
2355         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
2356         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
2357         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2358         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2359         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2360         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2361         * Scripts/webkitpy/layout_tests/port/base.py:
2362         * Scripts/webkitpy/layout_tests/port/test.py:
2363         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2364         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2365
2366 2010-09-01  Mark Rowe  <mrowe@apple.com>
2367
2368         Reviewed by Adam Roben.
2369
2370         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
2371
2372         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2373
2374 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
2375
2376         Reviewed by Adam Roben.
2377
2378         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
2379         and WebKitTestRunner.
2380
2381         * BuildSlaveSupport/win/kill-old-processes:
2382
2383 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2384
2385         Reviewed by Antonio Gomes.
2386
2387         [Qt] Remove obsolete include path from DumpRenderTree.pro
2388
2389         * DumpRenderTree/qt/DumpRenderTree.pro:
2390
2391 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2392
2393         Reviewed by Laszlo Gombos.
2394
2395         [Qt] QWebPage::allowGeolocationRequest should be async API
2396         https://bugs.webkit.org/show_bug.cgi?id=41364
2397
2398         Implements new async API for geolocation permission similar to
2399         Notification. WebPage maintains list of geolocation permission request
2400         QtWebkit and set's when LayoutTestController gets the access from test JS
2401
2402         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2403         (WebCore::WebPage::WebPage):
2404         (WebCore::WebPage::resetSettings):
2405         (WebCore::WebPage::requestPermission):
2406         (WebCore::WebPage::cancelPermission):
2407         (WebCore::WebPage::permissionSet):
2408         (WebCore::DumpRenderTree::DumpRenderTree):
2409         (WebCore::DumpRenderTree::processLine):
2410         (WebCore::DumpRenderTree::geolocationPermissionSet):
2411         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2412         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2413         (LayoutTestController::reset):
2414         (LayoutTestController::setGeolocationPermission):
2415         (LayoutTestController::setGeolocationPermissionCommon):
2416         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2417
2418 2010-09-01  Andras Becsi  <abecsi@webkit.org>
2419
2420         Reviewed by Antti Koivisto.
2421
2422         [Qt] Auto-generate WebKit2 forwarding headers
2423         https://bugs.webkit.org/show_bug.cgi?id=44692
2424
2425         * MiniBrowser/qt/BrowserWindow.h: use source style includes
2426         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
2427         * Scripts/enumerate-included-framework-headers: Removed.
2428
2429 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2430
2431         Reviewed by Adam Barth.
2432
2433         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
2434         https://bugs.webkit.org/show_bug.cgi?id=44789
2435
2436         * Scripts/webkitpy/common/net/bugzilla.py:
2437
2438 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
2439
2440         Reviewed by Adam Barth.
2441
2442         ews: Add support for EFL-EWS
2443         https://bugs.webkit.org/show_bug.cgi?id=44982
2444
2445         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
2446         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
2447         and add it to the ports dict.
2448         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
2449         EflEWS class.
2450         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
2451         a test case for the EFL EWS.
2452
2453 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
2454
2455         Reviewed by Sam Weinig.
2456
2457         https://bugs.webkit.org/show_bug.cgi?id=42195
2458         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
2459
2460         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2461         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
2462         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2463         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
2464         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
2465
2466         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
2467         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
2468         which forgets its override.
2469
2470 2010-08-31  Sam Weinig  <sam@webkit.org>
2471
2472         Reviewed by Gavin Barraclough.
2473
2474         WebKitTestRunner needs layoutTestController.addUserStyleSheet
2475         https://bugs.webkit.org/show_bug.cgi?id=42680
2476
2477         WebKitTestRunner needs layoutTestController.addUserScript
2478         https://bugs.webkit.org/show_bug.cgi?id=42681
2479
2480         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2481         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2482         (WTR::InjectedBundle::beginTesting):
2483         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2484         (WTR::LayoutTestController::addUserScript):
2485         (WTR::LayoutTestController::addUserStyleSheet):
2486         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2487
2488 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
2489
2490         Unreviewed, rolling out r66542.
2491         http://trac.webkit.org/changeset/66542
2492         https://bugs.webkit.org/show_bug.cgi?id=44902
2493
2494         r66542 - the weird logging dependencies in Python stuck again ...
2495
2496         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
2497         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
2498         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
2499         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
2500         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2501         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2502         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2503         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2504         * Scripts/webkitpy/layout_tests/port/base.py:
2505         * Scripts/webkitpy/layout_tests/port/test.py:
2506         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2507         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2508
2509 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
2510
2511         Reviewed by Tony Chang.
2512
2513         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
2514
2515         * DumpRenderTree/chromium/LayoutTestController.cpp:
2516         (LayoutTestController::LayoutTestController):
2517         (LayoutTestController::markerTextForListItem):
2518         * DumpRenderTree/chromium/LayoutTestController.h:
2519
2520 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
2521
2522         Reviewed by Ojan Vafai.
2523
2524         new-run-webkit-tests: add more unit tests
2525
2526         Add more unit tests for new-run-webkit-tests; we now cover all but
2527         the most obscure code paths in the generic code. We still need to
2528         add coverage for the http server and web socket paths, and add better
2529         coverage of the platform-specific logic. Note that the rebaselining
2530         tool is still not well tested.
2531
2532         Also clean up some of the configuration logic for the printing
2533         module and the way it interacts with the Python logging module; that
2534         is a crufty interface, to be certain.
2535         
2536         https://bugs.webkit.org/show_bug.cgi?id=44902
2537
2538         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
2539         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
2540         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
2541         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
2542         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2543         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2544         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2545         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2546         * Scripts/webkitpy/layout_tests/port/base.py:
2547         * Scripts/webkitpy/layout_tests/port/test.py:
2548         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2549         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2550
2551 2010-08-31  Darin Adler  <darin@apple.com>
2552
2553         Reviewed by Anders Carlsson.
2554
2555         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
2556         in a debug build when built with certain compilers.
2557
2558 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
2559
2560         Reviewed by Gustavo Noronha Silva.
2561
2562         [GTK] Isolate all GTK+ typedefs into one file
2563         https://bugs.webkit.org/show_bug.cgi?id=44900
2564
2565         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
2566
2567 2010-08-31  Eric Seidel  <eric@webkit.org>
2568
2569         Reviewed by Adam Barth.
2570
2571         Show more status on queue status pages
2572         https://bugs.webkit.org/show_bug.cgi?id=44938
2573
2574         I upped the number of status lines from 6 to 15 --
2575         this has been bugging me for a while...
2576
2577         I also disabled showing the chromium-win EWS queue
2578         since it's been down for almost 5 months now.
2579
2580         * QueueStatusServer/handlers/dashboard.py:
2581         * QueueStatusServer/handlers/queuestatus.py:
2582         * QueueStatusServer/model/queues.py:
2583
2584 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
2585
2586         Reviewed by Antonio Gomes.
2587
2588         [Qt] Read command line arguments and open them as URLs in new windows
2589         https://bugs.webkit.org/show_bug.cgi?id=44944
2590
2591         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
2592
2593         * MiniBrowser/qt/main.cpp:
2594         (main):
2595
2596 2010-08-31  Adrian Perez  <aperez@igalia.com>
2597
2598         Reviewed by Martin Robinson.
2599
2600         Support scripts to run Buildbot slaves under daemontools (gtk related)
2601         https://bugs.webkit.org/show_bug.cgi?id=40053
2602
2603         * BuildSlaveSupport/gtk: Added.
2604         * BuildSlaveSupport/gtk/README: Added.
2605         * BuildSlaveSupport/gtk/buildbot: Added.
2606         * BuildSlaveSupport/gtk/buildbot/log: Added.
2607         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
2608         * BuildSlaveSupport/gtk/buildbot/run: Added.
2609         * BuildSlaveSupport/gtk/crashmon: Added.
2610         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
2611         * BuildSlaveSupport/gtk/crashmon/log: Added.
2612         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
2613         * BuildSlaveSupport/gtk/crashmon/run: Added.
2614         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
2615         * BuildSlaveSupport/gtk/pulseaudio: Added.
2616         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
2617         * BuildSlaveSupport/gtk/xvfb: Added.
2618         * BuildSlaveSupport/gtk/xvfb/log: Added.
2619         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
2620         * BuildSlaveSupport/gtk/xvfb/run: Added.
2621
2622 2010-08-27  John Gregg  <johnnyg@google.com>
2623
2624         Reviewed by David Levin.
2625
2626         Notifications should support a click event.
2627         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
2628         can be simulated during a layout test.  Requires storing a list of active
2629         notifications so that they can be referred to later for clicking.
2630         https://bugs.webkit.org/show_bug.cgi?id=44800
2631
2632         * DumpRenderTree/chromium/LayoutTestController.cpp:
2633         (LayoutTestController::LayoutTestController):
2634         (LayoutTestController::simulateDesktopNotificationClick):
2635         * DumpRenderTree/chromium/LayoutTestController.h:
2636         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2637         (NotificationPresenter::simulateClick):
2638         (NotificationPresenter::show):
2639         (NotificationPresenter::cancel):
2640         (NotificationPresenter::objectDestroyed):
2641         * DumpRenderTree/chromium/NotificationPresenter.h:
2642
2643 2010-08-30  Alice Liu  <alice.liu@apple.com>
2644
2645         Reviewed by Darin Adler.
2646
2647         Add missing parts of didFinishDocumentLoadForFrame
2648         https://bugs.webkit.org/show_bug.cgi?id=44913
2649
2650         * MiniBrowser/mac/BrowserWindowController.m:
2651         (didFinishDocumentLoadForFrame): Added
2652         (-[BrowserWindowController awakeFromNib]): Updated struct
2653         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2654         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
2655         * WebKitTestRunner/TestController.cpp:
2656         (WTR::TestController::initialize): Updated struct
2657
2658 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
2659
2660         Unreviewed: Add myself to the list of Committers.
2661
2662         * Scripts/webkitpy/common/config/committers.py:
2663
2664 2010-08-30  Kent Tamura  <tkent@chromium.org>
2665
2666         Reviewed by Adam Barth.
2667
2668         Fix fast/notifications/notifications-display-close-events.html failure
2669         https://bugs.webkit.org/show_bug.cgi?id=44585
2670
2671         Apply http://crrev.com/48893. We should dispatch display events
2672         asynchronously.
2673
2674         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2675         (deferredDisplayDispatch):
2676         (NotificationPresenter::show):
2677
2678 2010-08-30  Robert Hogan  <robert@webkit.org>
2679
2680         Reviewed by Simon Hausmann.
2681
2682         allow ports with windowed plugins to support windowless plugin tests
2683
2684         https://bugs.webkit.org/show_bug.cgi?id=40730
2685
2686         Ports that implement plugins windowed by default need to have a way of
2687         supporting plugin tests that assume the plugin is windowless. Add this
2688         feature to the tests and support it in the webkit test plugin. Also
2689         add mouse and keyboard event logging to the webkit-test plugin on Unix.
2690
2691         Unskip the following tests on Qt:
2692
2693         plugins/mouse-events.html
2694         plugins/keyboard-events.html
2695         plugins/mouse-events-fixedpos.html
2696
2697         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2698         (pluginSetProperty):
2699         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2700         (NPP_New):
2701         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2702         (webkit_test_plugin_handle_event):
2703
2704 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
2705
2706         [wx] Build fix after addition of fileapi directory in WebCore.
2707
2708         * wx/build/settings.py:
2709
2710 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
2711
2712         Reviewed by Xan Lopez.
2713
2714         Fixed compilation error, now that we have included the
2715         GtkVersioning.h we have to remove some version dependent code from
2716         EventSender.
2717
2718         * DumpRenderTree/gtk/EventSender.cpp:
2719
2720 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
2721
2722         Reviewed by Martin Robinson.
2723
2724         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
2725         are deprecated
2726         https://bugs.webkit.org/show_bug.cgi?id=44787
2727
2728         We have replaced GtkVersioning.cpp with GtkVersioning.c and
2729         created a function (getDefaultGDKPointerDevice) to get the pointer
2730         of the window with the new APIs. We added that function to DRT and
2731         copyandpaste unit test.
2732
2733         * DumpRenderTree/gtk/EventSender.cpp:
2734         (prepareMouseButtonEvent):
2735         (mouseMoveToCallback):
2736         (keyDownCallback):
2737         * GNUmakefile.am:
2738
2739 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
2740
2741         Reviewed by Kenneth Rohde Christiansen.
2742
2743         [Qt] Add new window menu to MiniBrowser
2744
2745         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
2746
2747         * MiniBrowser/qt/BrowserWindow.cpp:
2748         (BrowserWindow::BrowserWindow):
2749         (BrowserWindow::newWindow):
2750         * MiniBrowser/qt/BrowserWindow.h:
2751         * MiniBrowser/qt/main.cpp:
2752         (main):
2753
2754 2010-08-29  James Robinson  <jamesr@chromium.org>
2755
2756         Reviewed by David Levin.
2757
2758         Make failing the download step fail the build
2759         https://bugs.webkit.org/show_bug.cgi?id=44298
2760
2761         If the download step fails on a test bot, this ensures that
2762         the build goes red instead of only the download step going red
2763         and the overall build staying green.
2764
2765         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2766
2767 2010-08-29  Kent Tamura  <tkent@chromium.org>
2768
2769         Reviewed by Dimitri Glazkov.
2770
2771         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
2772         https://bugs.webkit.org/show_bug.cgi?id=44847
2773
2774         * DumpRenderTree/chromium/EventSender.cpp:
2775          Use webkit_support::VKEY_* instead of base::VKEY_*.
2776
2777 2010-08-29  Darin Adler  <darin@apple.com>
2778
2779         https://bugs.webkit.org/show_bug.cgi?id=40589
2780
2781         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
2782         function names.
2783
2784 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
2785
2786         Reviewed by Darin Adler.
2787
2788         [iExploder] Add new CSS Properties and HTML Attributes
2789         https://bugs.webkit.org/show_bug.cgi?id=44746
2790
2791         Updated the files with the update-iexploder-cssproperties script
2792         and manually readded the -webkit-binding CSS Property to the list.
2793
2794         * iExploder/htdocs/cssproperties.in:
2795         * iExploder/htdocs/htmlattrs.in:
2796         * iExploder/htdocs/htmltags.in:
2797
2798 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
2799
2800         Reviewed by Darin Adler.
2801
2802         Fix Coverage build after the addition of ANGLE
2803         https://bugs.webkit.org/show_bug.cgi?id=44744
2804
2805         ANGLE is using libtool to build a static library and the version of
2806         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
2807         parameters. The easiest way to handle this is to not build ANGLE with
2808         coverage information.
2809
2810         This is achieved by applying the XCode options for each project
2811         separately and exclude ANGLE.
2812
2813         * Scripts/build-webkit: Remove -framework AppKit due link errors.
2814         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
2815
2816 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
2817
2818         [wx] Build fix after directory addition.
2819
2820         * wx/build/settings.py:
2821
2822 2010-08-28  Chris Guillory   <chris.guillory@google.com>
2823
2824         Reviewed by Chris Fleizach.
2825
2826         Add AX notification for childrenChanged
2827         https://bugs.webkit.org/show_bug.cgi?id=44472
2828
2829         * DumpRenderTree/chromium/AccessibilityController.cpp:
2830         (AccessibilityController::AccessibilityController):
2831         (AccessibilityController::reset):
2832         (AccessibilityController::getRootElement):
2833         (AccessibilityController::dumpAccessibilityNotifications):
2834         * DumpRenderTree/chromium/AccessibilityController.h:
2835         (AccessibilityController::shouldDumpAccessibilityNotifications):
2836         * DumpRenderTree/chromium/WebViewHost.cpp:
2837         (WebViewHost::didChangeAccessibilityObjectChildren):
2838         * DumpRenderTree/chromium/WebViewHost.h:
2839
2840 2010-08-28  Eric Seidel  <eric@webkit.org>
2841
2842         Reviewed by Adam Barth.
2843
2844         Update commit-queue failure message
2845         https://bugs.webkit.org/show_bug.cgi?id=44798
2846
2847         The commit-queue auto-restarts itself and has for a very long time.
2848         No need for people to email me to request a restart anymore.
2849
2850         * Scripts/webkitpy/common/net/bugzilla.py:
2851         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2852         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2853
2854 2010-07-27  Jer Noble  <jer.noble@apple.com>
2855
2856         Reviewed by Eric Carlson.
2857
2858         Add JavaScript API to allow a page to go fullscreen.
2859         rdar://problem/6867795
2860         
2861         Added basic full screen support to DumpRenderTree: when a webView requests
2862         that DumpRenderTree go "full screen", just call the provided callback listener object's
2863         will/did Enter/Exit full screen methods.  Also, register a new user default which 
2864         enables full screen support.
2865
2866         * DumpRenderTree/mac/DumpRenderTree.mm:
2867         (resetDefaultsToConsistentValues):
2868         * DumpRenderTree/mac/UIDelegate.mm:
2869         (-[UIDelegate webView:supportsFullscreenForElement:]):
2870         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
2871         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
2872
2873 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
2874
2875         Unreviewed. Add myself to the committers list.
2876
2877         * Scripts/webkitpy/common/config/committers.py:
2878
2879 2010-08-27  Kent Tamura  <tkent@chromium.org>
2880
2881         Reviewed by Pavel Feldman.
2882
2883         [DRT/Chromium] Fix inspector test failures
2884         https://bugs.webkit.org/show_bug.cgi?id=44748
2885
2886         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2887         (DRTDevToolsAgent::createClientMessageLoop):
2888           Returns a valid WebKitClientMessageLoop instance
2889         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2890
2891 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
2892
2893         Add Windows WebKit2 Tester to buildbot
2894         <rdar://problem/7887703>
2895
2896         Reviewed by Dan Bernstein.
2897
2898         * BuildSlaveSupport/build.webkit.org-config/config.json:
2899
2900 2010-08-26  Philippe Normand  <pnormand@igalia.com>
2901
2902         Reviewed by Martin Robinson.
2903
2904         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
2905         https://bugs.webkit.org/show_bug.cgi?id=42152
2906
2907         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2908         (LoadHTMLStringItem::invoke): Implementation using
2909         webkit_web_frame_load_string().
2910
2911 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
2912
2913         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
2914         WebKitTestRunner (44331)
2915
2916         Reviewed by Darin Adler.
2917
2918         * WebKitTestRunner/TestController.cpp:
2919         (WTR::TestController::initialize):
2920         The hang occurs when WebKitTestRunner begins launching the WebKit2
2921         web process then exits before it finishes launching. Work around this by
2922         looking for the --print-supported-features argument and exiting without
2923         creating the web process.
2924
2925 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
2926
2927         Reviewed by Tony Chang.
2928
2929         new-run-webkit-tests: add rebaselining tests for test_expectations
2930         
2931         This patch adds more unit tests for the rebaselining code in the
2932         test_expectations module. It doesn't add any tests for
2933         rebaseline_chromium_webkit_tests itself; that will come some other
2934         time.
2935
2936         https://bugs.webkit.org/show_bug.cgi?id=44648
2937
2938         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2939         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2940
2941 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2942
2943         Reviewed by Martin Robinson.
2944
2945         [GTK] Add HTTP caching support
2946         https://bugs.webkit.org/show_bug.cgi?id=44261
2947
2948         Ignore new soup API that we decided to merge into the soup backend
2949         while it is being cooked. It follows the libsoup style, and will
2950         be removed from WebKit as soon as it is merged into libsoup.
2951
2952         * Scripts/webkitpy/style/checker.py:
2953
2954 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2955
2956         Reviewed by Kenneth Rohde Christiansen.
2957
2958         [Qt] DumpRenderTree runs only one test from command mode
2959         https://bugs.webkit.org/show_bug.cgi?id=44012
2960
2961         Enables support to run multiple test files and single
2962         folder containing html files in stand alone mode
2963
2964         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2965         (WebCore::DumpRenderTree::DumpRenderTree):
2966         (WebCore::DumpRenderTree::processArgsLine):
2967         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
2968         (WebCore::DumpRenderTree::processLine):
2969         (WebCore::DumpRenderTree::dump):
2970         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2971         (WebCore::DumpRenderTree::setStandAloneMode):
2972         (WebCore::DumpRenderTree::isStandAloneMode):
2973         * DumpRenderTree/qt/main.cpp:
2974         (main):
2975
2976 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
2977
2978         Updating webkitpy test expectations.
2979
2980         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2981
2982 2010-08-25  Ojan Vafai  <ojan@chromium.org>
2983
2984         Reviewed by Eric Seidel.
2985
2986         fix the always squash git config
2987         https://bugs.webkit.org/show_bug.cgi?id=44651
2988
2989         Fix help text and apparently underscores are not allowed
2990         in git config keys.
2991
2992         * Scripts/webkitpy/common/checkout/scm.py:
2993         * Scripts/webkitpy/tool/steps/commit.py:
2994
2995 2010-08-25  Darin Adler  <darin@apple.com>
2996
2997         Reviewed by John Sullivan.
2998
2999         * Scripts/commit-log-editor: Fix perl warning for people who have no
3000         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
3001
3002 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3003
3004         Reviewed by Eric Seidel.
3005
3006         stop blocking commits when the bots are red
3007         https://bugs.webkit.org/show_bug.cgi?id=44644
3008
3009         This check currently is just annoying. It doesn't actually
3010         help keep the tree green. We can always add it back later
3011         if we decide the tree is generally more green.
3012
3013         * Scripts/webkitpy/tool/commands/download_unittest.py:
3014         * Scripts/webkitpy/tool/mocktool.py:
3015         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
3016
3017 2010-08-25  Eric Seidel  <eric@webkit.org>
3018
3019         Reviewed by Simon Fraser.
3020
3021         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
3022         https://bugs.webkit.org/show_bug.cgi?id=38912
3023
3024         I know of nothing else to do but skip all media tests for the cq.
3025
3026         * Scripts/webkitpy/tool/steps/runtests.py:
3027
3028 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
3029
3030         Reviewed by Ojan Vafai.
3031
3032         new-run-webkit-tests: add more unit tests for test_expectations
3033         This adds unit tests to cover (almost?) all of the non-rebaselining
3034         functionality.
3035
3036         https://bugs.webkit.org/show_bug.cgi?id=44579
3037
3038         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3039         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3040
3041 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
3042
3043         Reviewed by Ojan Vafai.
3044
3045         new-run-webkit-tests: add more unit tests
3046
3047         This change adds more unit tests for the image_diff, test_failures,
3048         and test_files modules, bringing them to 100% coverage (and adds a
3049         couple tests to run_webkit_tests while we're at it).
3050
3051         This test also turns on the "dryrun" port for testing when run on
3052         the mac, increasing coverage in a few other places.
3053
3054         https://bugs.webkit.org/show_bug.cgi?id=44578
3055
3056         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
3057         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
3058         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
3059         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
3060         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
3061         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
3062         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
3063         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
3064         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
3065         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
3066         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
3067         * Scripts/webkitpy/layout_tests/port/test.py:
3068         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3069
3070 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
3071
3072         Reviewed by Ojan Vafai.
3073
3074         new-run-webkit-tests: add more unit tests for layout_package/printing.py
3075
3076         This change adds more unit tests to get the test coverage to 100%
3077         for the printing module. This code is actually pretty crufty and
3078         has some layering violations that need to be cleaned up but I'll
3079         save that for another CL after we get all the unit tests written and
3080         we fix the multithreading issues. At least now we'll be able to tell
3081         if we break things.
3082
3083         https://bugs.webkit.org/show_bug.cgi?id=44576
3084
3085         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3086         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3087
3088 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3089
3090         Reviewed by Adam Barth.
3091
3092         new-run-webkit-tests should respect set-webkit-configuration
3093         https://bugs.webkit.org/show_bug.cgi?id=44633
3094
3095         Moves the getting of the configuration into the base Port so that
3096         chromium ports use it as well. In the downstream chromium port,
3097         this should still just return Release.
3098
3099         * Scripts/webkitpy/layout_tests/port/base.py:
3100         * Scripts/webkitpy/layout_tests/port/webkit.py:
3101
3102 2010-08-25  Tony Chang  <tony@chromium.org>
3103
3104         Not reviewed, changing svn props for a script.
3105
3106         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
3107
3108 2010-08-25  Adam Barth  <abarth@webkit.org>
3109
3110         Reviewed by Eric Seidel.
3111
3112         Remove WebKit2 from core builders
3113         https://bugs.webkit.org/show_bug.cgi?id=44625
3114
3115         This builder was added to the core builders by accident.  It doesn't
3116         appear to be green enough to be a core builder yet.
3117
3118         * Scripts/webkitpy/common/net/buildbot.py:
3119         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3120
3121 2010-08-19  Adam Roben  <aroben@apple.com>
3122
3123         Test that NP_Initialize and NP_GetEntryPoints are called in the
3124         correct order
3125
3126         The order differs between Mac and Windows (see r38858).
3127
3128         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
3129         NP_Initialize when loading QuickTime when running
3130         plugins/embed-attributes-setting.html in WebKit2 on Windows
3131
3132         Reviewed by John Sullivan.
3133
3134         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
3135         a boolean to record whether NP_GetEntryPoints has been called.
3136         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
3137         called yet. This matches Flash and QuickTime's behavior.
3138         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
3139         yet. This matches Silverlight's behavior.
3140
3141 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
3142
3143         Reviewed by Gustavo Noronha Silva.
3144
3145         Cairo and EFL port shouldn't depend on glib.
3146         https://bugs.webkit.org/show_bug.cgi?id=44354
3147
3148         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
3149         adoptPlatformRef.
3150
3151         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3152         (AccessibilityUIElement::isSelected):
3153
3154 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3155
3156         Fix order of Timothy's email address. The script, and
3157         other tools all assume that the first email is the bugzilla address.
3158
3159         * Scripts/webkitpy/common/config/committers.py:
3160
3161 2010-08-24  Kent Tamura  <tkent@chromium.org>
3162
3163         Reviewed by Pavel Feldman.
3164
3165         [DRT/Chromium] Fix 26 inspector test crashes
3166         https://bugs.webkit.org/show_bug.cgi?id=44580
3167
3168         - DRTDevToolsAgent has a reference to the main WebView. So we
3169           should not clear it in closeDevTools() and should clear it in
3170           ~TestShell().
3171         - DRTDevToolsClient has a reference to a DevTools WebView and no
3172           way to update it. So we should delete DRTDevToolsClient instances
3173           in closeDevTools().
3174
3175         * DumpRenderTree/chromium/TestShell.cpp:
3176         (TestShell::~TestShell):
3177         (TestShell::closeDevTools):
3178
3179 2010-08-24  Eric Seidel  <eric@webkit.org>
3180
3181         Reviewed by Adam Barth.
3182
3183         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
3184         https://bugs.webkit.org/show_bug.cgi?id=44584
3185
3186         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3187
3188 2010-08-24  Eric Seidel  <eric@webkit.org>
3189
3190         Reviewed by Adam Barth.
3191
3192         commit-queue and EWS bots should report all failures
3193         https://bugs.webkit.org/show_bug.cgi?id=41820
3194
3195         Right now commit-queue/EWS only report failures when the
3196         patch under testing fails.  We should report all failures
3197         to the status server so that we can diagnose when the bots
3198         are wedged w/o needing to log into the machines.
3199
3200         I also reduced the amount of data we upload since we've seen
3201         timeouts during status upload.
3202
3203         * Scripts/webkitpy/common/system/executive.py:
3204         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3205         * Scripts/webkitpy/tool/commands/queues.py:
3206         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3207
3208 2010-08-24  Eric Seidel  <eric@webkit.org>
3209
3210         Reviewed by Adam Barth.
3211
3212         Remove HTML5 parser testing infrastructure now that we don't need it
3213         https://bugs.webkit.org/show_bug.cgi?id=44581
3214
3215         * DumpRenderTree/mac/DumpRenderTree.mm:
3216         (resetDefaultsToConsistentValues):
3217         (initializeGlobalsFromCommandLineOptions):
3218         * Scripts/old-run-webkit-tests:
3219         * Scripts/test-html5-parser: Removed.
3220
3221 2010-08-24  Kent Tamura  <tkent@chromium.org>
3222
3223         Reviewed by Dimitri Glazkov.
3224
3225         [DRT/Chromium] Fix 28 inspector test crashes
3226         https://bugs.webkit.org/show_bug.cgi?id=44574
3227
3228         Reset DevToolsClient and DevToolsAgent before closing a DevTools
3229         WebView in order to avoid accessing to a deleted WebView instance.
3230
3231         * DumpRenderTree/chromium/TestShell.cpp:
3232         (TestShell::closeDevTools):
3233
3234 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
3235
3236         Reviewed by Ojan Vafai.
3237
3238         new-run-webkit-tests: clean up code for test_types, test_failures
3239
3240         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
3241         webkitpy.layout_tests.layout_package.test_failures, and remove
3242         some dead code and otherwise clean up things.
3243
3244         https://bugs.webkit.org/show_bug.cgi?id=44559
3245
3246         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3247         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
3248         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3249         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3250         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3251         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
3252         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3253
3254 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
3255
3256         Reviewed by Eric Seidel.
3257
3258         new-run-webkit-tests: revise unit testing strategy for test failures
3259     
3260         This change revamps the way we store test data for new-run-webkit-tests.
3261         Previously we had a few copies of test files from the main test tree.
3262         Now we have a bunch of completely fake test data and use the test
3263         data to generate different kinds of test failures, getting
3264         much better coverage.
3265
3266         https://bugs.webkit.org/show_bug.cgi?id=44556
3267
3268         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
3269         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
3270         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
3271         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
3272         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
3273         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
3274         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
3275         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
3276         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
3277         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
3278         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
3279         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
3280         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
3281         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
3282         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
3283         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
3284         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
3285         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
3286         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
3287         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
3288         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
3289         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
3290         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
3291         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
3292         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
3293         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
3294         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
3295         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
3296         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
3297         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
3298         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
3299         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
3300         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
3301         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
3302         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
3303         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
3304         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
3305         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
3306         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
3307         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
3308         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
3309         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
3310         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
3311         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
3312         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
3313         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
3314         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3315         * Scripts/webkitpy/layout_tests/port/test.py:
3316         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3317         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3318
3319 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
3320
3321         Reviewed by Eric Seidel.
3322
3323         speed up new-run-webkit-tests unit tests
3324
3325         Add a --no-record-results flag that turns off generating the JSON
3326         results file on every test run. Generating the file requires us to
3327         fetch the old results down from the bots, which can be slow. This
3328         flag is off by default.
3329     
3330         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
3331     
3332         These changes together shorten the test cycle from ~4.5s to ~1.5s
3333         - a 3x speedup.
3334
3335         https://bugs.webkit.org/show_bug.cgi?id=44553
3336
3337         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3338         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3339
3340 2010-08-24  Tony Chang  <tony@chromium.org>
3341
3342         Reviewed by Eric Seidel.
3343
3344         [chromium] fix the platform result fallback order on mac/win
3345         https://bugs.webkit.org/show_bug.cgi?id=44483
3346
3347         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3348
3349 2010-08-24  Xan Lopez  <xlopez@igalia.com>
3350
3351         Reviewed by Martin Robinson.
3352
3353         Set a device to the event struct when building with GTK+ 3.x, it's
3354         mandatory.
3355
3356         * DumpRenderTree/gtk/EventSender.cpp:
3357         (keyDownCallback):
3358
3359 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
3360
3361         Reviewed by Xan Lopez.
3362
3363         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
3364         https://bugs.webkit.org/show_bug.cgi?id=44534
3365
3366         Fix two double-frees introduced in my previous commit.
3367
3368         * DumpRenderTree/gtk/EventSender.cpp:
3369         (contextClickCallback): Copy the event before using it again.
3370         (keyDownCallback): Ditto.
3371
3372 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
3373
3374         Reviewed by Xan Lopez.
3375
3376         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
3377         https://bugs.webkit.org/show_bug.cgi?id=44534
3378
3379         * DumpRenderTree/gtk/EventSender.cpp:
3380         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
3381         when setting it on the event. It is dereferenced by gdk_event_free(...).
3382         (contextClickCallback): Ditto.
3383         (mouseDownCallback): Ditto.
3384         (mouseUpCallback): Ditto.
3385         (mouseMoveToCallback): Ditto.
3386         (mouseWheelToCallback): Ditto.
3387         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
3388         (dispatchEvent): Ditto. Also free the event when we are done with it.
3389         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
3390
3391 2010-08-24  Andras Becsi  <abecsi@webkit.org>
3392
3393         [Qt] WebKit2 build fix.
3394
3395         * Scripts/enumerate-included-framework-headers:
3396         Remove stray global option form sed.
3397
3398 2010-08-24  Kent Tamura  <tkent@chromium.org>
3399
3400         Reviewed by Jeremy Orlow.
3401
3402         [DRT/Chromium] Support for IndexedDB tests
3403         https://bugs.webkit.org/show_bug.cgi?id=44490
3404
3405         * DumpRenderTree/chromium/TestShell.cpp:
3406         (TestShell::TestShell): Enable IndexedDB.
3407
3408 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
3409
3410         Reviewed by Gustavo Noronha Silva.
3411
3412         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
3413         https://bugs.webkit.org/show_bug.cgi?id=44465
3414
3415         Initialize the axes field of mouse button and motion events to null.
3416         This is the value that should be used for events originating from the
3417         mouse device.
3418
3419         * DumpRenderTree/gtk/EventSender.cpp:
3420         (prepareMouseButtonEvent): Initalize button event axes field to null.
3421         (mouseMoveToCallback): Initialize motion event axes field to null.
3422
3423 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3424
3425         Unreviewed, rolling out r65703.
3426         http://trac.webkit.org/changeset/65703
3427         https://bugs.webkit.org/show_bug.cgi?id=44460
3428
3429         "Causing lots of crashes on Snow Leopard when running the
3430         layout tests" (Requested by eseidel2 on #webkit).
3431
3432         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3433         (NP_Initialize):
3434         (NP_GetEntryPoints):
3435
3436 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
3437
3438         Layout tests do not run when using WebKitTestRunner in a Debug build.
3439         https://bugs.webkit.org/show_bug.cgi?id=44409
3440
3441         Reviewed by Dan Bernstein.
3442
3443         * WebKitTestRunner/win/TestControllerWin.cpp:
3444         (WTR::TestController::initializeInjectedBundlePath):
3445         Use InjectedBundle_debug.dll when building Debug.
3446
3447 2010-08-23  Xan Lopez  <xlopez@igalia.com>
3448
3449         Reviewed by Martin Robinson.
3450
3451         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
3452         https://bugs.webkit.org/show_bug.cgi?id=42026
3453
3454         If a GTK+ 3.x build is present return that as the library to use,
3455         otherwise fallback to the GTK+ 2.x build.
3456
3457         * Scripts/webkitdirs.pm:
3458
3459 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
3460
3461         Reviewed by Ariya Hidayat.
3462
3463         [Qt] Find needed forwarding headers for WebKit2 automatically
3464         https://bugs.webkit.org/show_bug.cgi?id=44336
3465
3466         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
3467         The new script does not satisfy the needs of this file however using normal includes
3468         is generally better here.
3469         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
3470         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
3471         given frameworks by files in the current directory (and subdirectories).
3472         In the future this needs to be rewritten in perl for being able to use on Windows.
3473
3474 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
3475
3476         Reviewed by Ariya Hidayat.
3477
3478         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
3479         https://bugs.webkit.org/show_bug.cgi?id=43010
3480
3481         * QtTestBrowser/launcherwindow.cpp:
3482         (LauncherWindow::applyPrefs):
3483         * QtTestBrowser/main.cpp:
3484         (LauncherApplication::handleUserOptions):
3485
3486 2010-08-21  Sam Weinig  <sam@webkit.org>
3487
3488         Reviewed by Dan Bernstein.
3489
3490         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
3491         https://bugs.webkit.org/show_bug.cgi?id=44386
3492
3493         * MiniBrowser/mac/AppDelegate.m:
3494         (didRecieveMessageFromInjectedBundle):
3495         (didNavigateWithNavigationData):
3496         (-[BrowserAppDelegate init]):
3497         (-[BrowserAppDelegate applicationWillTerminate:]):
3498         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3499         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
3500         (-[BrowserStatisticsWindowController dealloc]):
3501         * MiniBrowser/mac/BrowserWindowController.m:
3502         (-[BrowserWindowController initWithPageNamespace:]):
3503         (-[BrowserWindowController fetch:]):
3504         (-[BrowserWindowController windowWillClose:]):
3505         (-[BrowserWindowController applicationTerminating]):
3506         (closePage):
3507         (runJavaScriptAlert):
3508         (runJavaScriptConfirm):
3509         (runJavaScriptPrompt):
3510         (-[BrowserWindowController updateProvisionalURLForFrame:]):
3511         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3512         (didClearWindowObjectForFrame):
3513         * MiniBrowser/win/BrowserView.cpp:
3514         (BrowserView::goToURL):
3515         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3516         (WTR::PlatformWebView::~PlatformWebView):
3517
3518 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
3519
3520         Reviewed by Kenneth Rohde Christiansen.
3521
3522         WebKit does not build with Python 2.3
3523         https://bugs.webkit.org/show_bug.cgi?id=44373
3524
3525         Replaced the function sorted() by a call to sort()
3526         on the entry list.
3527         The function sorted() has been added to Python 2.4.
3528         The function method sort() of List works with older
3529         versions of Python.
3530
3531         * Scripts/create-html-entity-table:
3532
3533 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
3534
3535         Reviewed by Pavel Feldman.
3536
3537         Web Inspector: Inspector tests were disabled for GTK.
3538         https://bugs.webkit.org/show_bug.cgi?id=43977
3539
3540         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
3541         path before running tests.
3542
3543 2010-08-20  Daniel Bates  <dbates@rim.com>
3544
3545         Reviewed by Eric Seidel.
3546
3547         svn-apply doesn't detect empty line with Windows line endings
3548         after property value
3549         https://bugs.webkit.org/show_bug.cgi?id=43981
3550
3551         Part 2 of 2
3552
3553         Add unit tests that were not landed in the first commit.
3554
3555         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
3556           - Added the following test cases:
3557             "SVN: binary file (isBinary true) using Windows line endings"
3558             "SVN: property diff, followed by file change diff using Windows line endings"
3559             "SVN: two consecutive property diffs using Windows line endings"
3560             "SVN: binary file with executable bit change usng Windows line endings"
3561             "SVN: binary file followed by property change on different file using Windows line endings"
3562             "SVN: binary file followed by file change on different file using Windows line endings"
3563             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
3564             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
3565         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3566           - Added the following test cases:
3567             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
3568             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
3569             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
3570             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
3571             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
3572             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
3573             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
3574             "single-line '+' with trailing new line using Windows line endings"
3575             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
3576             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
3577             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
3578         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3579           - Added the following test cases:
3580             "single-line '-' change followed by empty line with Windows line endings"
3581             "multi-line '+' change and start of binary patch with Windows line endings"
3582
3583 2010-08-20  Daniel Bates  <dbates@rim.com>
3584
3585         Reviewed by Eric Seidel.
3586
3587         svn-apply doesn't detect empty line with Windows line endings
3588         after property value
3589         https://bugs.webkit.org/show_bug.cgi?id=43981
3590
3591         Fixes&nbs