2008-01-16 Alp Toker <alp@atoker.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-16  Alp Toker  <alp@atoker.com>
2
3         Reviewed by Mark Rowe.
4
5         http://bugs.webkit.org/show_bug.cgi?id=16218
6         [GTK] API: Should this entry point be called go_back rather than go_backward?
7
8         Track back/forward API changes in the tools.
9
10         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
11         (BackForwardItem::invoke):
12         * GtkLauncher/main.c:
13         (go_back_cb):
14
15 2008-01-16  Adam Roben  <aroben@apple.com>
16
17         Windows build fix after r29488
18
19         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
20         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
21         expects to find the plugin.
22
23 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
24
25         Reviewed by Sam Weinig.
26         
27         Fixed the waitUntilDone watchdog timer -- the old code never added the
28         timer to the run loop, so it didn't do anything.
29
30         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
31         (LayoutTestController::setWaitToDump):
32         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
33         (LayoutTestController::setWaitToDump):
34
35 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
36
37         Use shared vsprops for most vcproj properties.
38         
39         Reviewed by Darin.
40
41         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
42         * DumpRenderTree/win/DumpRenderTree.vcproj:
43         * DumpRenderTree/win/ImageDiff.vcproj:
44         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
45         * FindSafari/FindSafari.vcproj:
46
47 2008-01-14  Stephanie  <slewis@apple.com>
48
49        Reviewed by NOBODY.
50   
51        revert accidental character.
52
53        * Scripts/run-webkit-tests:
54
55 2008-01-14  Stephanie  <slewis@apple.com>
56
57         RS=Oliver
58
59         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
60
61         * Scripts/run-webkit-tests:
62
63 2008-01-14  Darin Adler  <darin@apple.com>
64
65         * Scripts/do-webcore-rename: Queue up another rename.
66
67 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
68
69         Reviewed by Darin.
70
71         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
72         the tests were ran.
73         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
74
75         * Scripts/run-webkit-tests:
76
77 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
78
79         Reviewed by Darin.
80
81         * Randomize tests array to spot test cases where the results depends on the order
82         the tests are ran.
83         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
84
85         * Scripts/run-webkit-tests:
86
87 2008-01-14  Darin Adler  <darin@apple.com>
88
89         * Scripts/run-webkit-tests: More ignore list tweaking.
90
91 2008-01-14  Darin Adler  <darin@apple.com>
92
93         * Scripts/run-webkit-tests: Add another leak to the ignore list.
94
95 2008-01-14  Dan Bernstein  <mitz@apple.com>
96
97         Reviewed by Adam Roben.
98
99         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
100           build bots
101
102         * DumpRenderTree/win/DumpRenderTree.cpp:
103         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
104
105 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
106
107         Share common files across projects.
108         
109         Unify vsprops files
110         Debug:          common.vsprops, debug.vsprops
111         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
112         Release:        common.vsprops, release.vsprops
113         
114         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
115         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
116
117         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
118
119         Reviewed by Adam Roben.
120
121         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
122         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
123         * Drosera/win/Drosera.vcproj/VERSION: Removed.
124         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
125         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
126         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
127         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
128         * DumpRenderTree/win/DumpRenderTree.vcproj:
129         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
130         * DumpRenderTree/win/debug.vsprops: Removed.
131         * DumpRenderTree/win/debug_internal.vsprops: Removed.
132         * DumpRenderTree/win/release.vsprops: Removed.
133
134 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
135
136         Reviewed by Maciej.
137
138         - http://bugs.webkit.org/show_bug.cgi?id=16314
139           Script to launch Drosera
140
141         * Scripts/gdb-drosera: Added.
142         * Scripts/run-drosera: Added.
143         * Scripts/run-drosera-nightly.cmd: Added.
144         * Scripts/webkitdirs.pm: Added runDrosera function.
145
146 2008-01-13  Dan Bernstein  <mitz@apple.com>
147
148         - fix breakage due to last-minute change
149
150         * DumpRenderTree/win/DumpRenderTree.cpp:
151         (runTest): Declare the loop variable.
152
153 2008-01-13  Dan Bernstein  <mitz@apple.com>
154
155         Reviewed by Adam Roben.
156
157         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
158
159         * DumpRenderTree/win/DumpRenderTree.cpp:
160         (DumpRenderTreeWndProc):
161         (initialize):
162         (dumpBackForwardList):
163         (dumpBackForwardListForAllWindows):
164         (dump):
165         (resetWebViewToConsistentStateBeforeTesting): Factored out of
166         runTest().
167         (runTest):
168         (allWindows): Added. Returns a vector of all open windows.
169         (windowToWebViewMap): Added. Returns a map from open windows to their
170         WebViews.
171         (createWebViewAndOffscreenWindow): Factored out of main() to be
172         reusable for creating extra windows.
173         (main):
174         * DumpRenderTree/win/DumpRenderTreeWin.h:
175         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
176         (LayoutTestController::windowCount): Implemented.
177         * DumpRenderTree/win/UIDelegate.cpp:
178         (UIDelegate::createWebViewWithRequest): Implemented.
179         (UIDelegate::webViewClose): Implemented.
180         * DumpRenderTree/win/UIDelegate.h:
181
182 2008-01-12  Alp Toker  <alp@atoker.com>
183
184         Reviewed by Mark Rowe.
185
186         Hide non-public symbols in GTK+/autotools release builds.
187
188         * GNUmakefile.am:
189
190 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
191
192         Reviewed by Ap.
193
194         * Make launching of the WebKit httpd work on GNU/Debian/Linux
195         
196         The configuration of Apache2 and installation does not depend on
197         the kernel but on the distribution policy. Make launching of httpd
198         work for Debian derived distributions.
199
200         * Scripts/run-webkit-httpd:
201         * Scripts/run-webkit-tests:
202         * Scripts/webkitdirs.pm:
203
204 2008-01-12  Mark Rowe  <mrowe@apple.com>
205
206         Reviewed by Maciej Stachowiak.
207
208         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
209
210         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
211         match the callers expectations that it can take ownership of the string.
212
213 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
214
215         Reviewed by Adam Roben.
216
217         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
218
219         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
220         as these are only posted because the test window is not a normal visible one, and
221         they confuse drag&drop machinery.
222
223 2008-01-11  Adam Roben  <aroben@apple.com>
224
225         Fix a crash when pathToLocalResource fails and a leak
226
227         Reviewed by Darin.
228
229         * DumpRenderTree/LayoutTestController.cpp:
230         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
231         sure not to pass null to JSValueMakeString.
232         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
233         (LayoutTestController::pathToLocalResource): Print an error message if
234         the conversion fails so it's clear what happened.
235
236 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
237
238         Reviewed by John Sullivan.
239
240         * DumpRenderTree/mac/GCControllerMac.mm:
241         (GCController::collectOnAlternateThread): Updated for name change.
242
243 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
244
245         wx build fix. Don't build dftables any longer since it's now a Perl
246         script.
247
248         * wx/build-wxwebkit:
249
250 2008-01-10  Sam Weinig  <sam@webkit.org>
251
252         Reviewed by Anders Carlsson.
253
254         Make DRT track open windows instead of allocated windows so that
255         we can avoid ASSERTION due to late deallocs out of our control.
256
257         * DumpRenderTree/mac/DumpRenderTree.mm:
258         (dumpBackForwardListForAllWindows):
259         (runTest):
260         * DumpRenderTree/mac/DumpRenderTreeMac.h:
261         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
262         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
263         (+[DumpRenderTreeWindow openWindows]):
264         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
265         (-[DumpRenderTreeWindow close]):
266         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
267         (LayoutTestController::windowCount):
268
269 2008-01-10  Ada Chan  <adachan@apple.com>
270
271         Meta key is not the same as Alt key on windows.
272
273         Reviewed by Darin.
274
275         * DumpRenderTree/win/EventSender.cpp:
276         (keyDownCallback):
277
278 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
279
280         Reviewed by Darin, Sam and Adam.
281
282         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
283         link in gmail message displays JavaScript alert falsely complaining
284         about pop-up blocking.
285         - Added the ability to enable the pop-up blocker via the
286         LayoutTestController.
287
288         * DumpRenderTree/LayoutTestController.cpp:
289         (setPopupBlockingEnabledCallback):
290         (LayoutTestController::staticFunctions):
291         * DumpRenderTree/LayoutTestController.h:
292         * DumpRenderTree/mac/DumpRenderTree.mm:
293         (setDefaultsToConsistentValuesForTesting):
294         (resetWebViewToConsistentStateBeforeTesting):
295         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
296         (LayoutTestController::setPopupBlockingEnabled):
297
298 2008-01-10  Lars Knoll  <lars@trolltech.com>
299
300         Reviewed by Simon.
301
302         rename QWebPageHistory to QWebHistory.
303         
304
305         * DumpRenderTree/qt/jsobjects.cpp:
306
307 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
308
309         Reviewed by Darin.
310         
311         - add some more renames, adjust some
312
313         * Scripts/do-webcore-rename:
314
315 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
316
317         Reviewed by Oliver.
318
319         Enable SVG Fonts support by default.
320
321         * Scripts/build-webkit:
322
323 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
324
325         Reviewed by Adam.
326
327         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
328         DRT doesn't handle platform specific pixel test results correctly.
329
330         <test>-expected.txt files and <test>-expected.png files may now live
331         in different directories (ie. a cross-platform <test>-expected.txt file
332         and a platform-specific <test>-expected.png file).
333
334         * Scripts/run-webkit-tests:
335
336 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
337
338         Reviewed by Darin.
339
340         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
341         DRT did not correctly handle printing the '\0' char.  Now it does.
342
343         * DumpRenderTree/win/DumpRenderTree.cpp:
344         (dumpFramesAsText):
345         (dump):
346
347 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
348
349         Reviewed by Lars.
350
351         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
352         
353
354         * DumpRenderTree/qt/main.cpp:
355         * DumpRenderTree/qt/testplugin.cpp:
356         * DumpRenderTree/qt/testplugin.h:
357
358 2008-01-05  Mark Rowe  <mrowe@apple.com>
359
360         Reviewed by Alp Toker.
361
362         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
363
364         * DumpRenderTree/gtk/DumpRenderTree.cpp:
365         (processWork): Process pending work.
366         (webViewLoadFinished): Schedule processing of pending work.
367         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
368
369 2008-01-05  Darin Adler  <darin@apple.com>
370
371         * Scripts/do-webcore-rename: Some more renaming plans.
372
373 2008-01-04  Alice Liu  <alice.liu@apple.com>
374
375         Reviewed by Alexey and Darin.
376
377         Adding "home" and "end" to DRT's keydown since
378         DOM key events can't handle keyIdentifiers at this point. 
379
380         * DumpRenderTree/mac/EventSendingController.mm:
381         (-[EventSendingController keyDown:withModifiers:]):
382         * DumpRenderTree/win/EventSender.cpp:
383         (keyDownCallback):
384
385 2008-01-04  Lars Knoll  <lars@trolltech.com>
386
387         Reviewed by Simon.
388
389         fix DRT after the changes to QWebPage.
390         
391         The great thing is that we actually don't have
392         any regressions from the QWebPage change :)
393         
394
395         * DumpRenderTree/qt/DumpRenderTree.cpp:
396         (WebCore::DumpRenderTree::DumpRenderTree):
397
398 2008-01-04  Lars Knoll  <lars@trolltech.com>
399
400         Reviewed by Simon.
401
402         make QWebPage a QObject and get things to compile.
403         
404         Nothing works currently though.
405         
406
407         * DumpRenderTree/qt/DumpRenderTree.cpp:
408         (WebCore::DumpRenderTree::DumpRenderTree):
409
410 2008-01-04  Lars Knoll  <lars@trolltech.com>
411
412         Reviewed by Simon.
413
414         take a QString as identifier in QWebFrame::addToJSWindowObject.
415
416         * DumpRenderTree/qt/DumpRenderTree.cpp:
417         (WebCore::DumpRenderTree::initJSObjects):
418
419 2008-01-04  Alp Toker  <alp@atoker.com>
420
421         GTK+ DRT build fix for breakage introduced in r29149.
422
423         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
424         (LayoutTestController::execCommand):
425
426 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
427
428         Reviewed by Darin.
429
430         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
431
432         Added layoutTestController.execCommand to access editor commands that are not available
433         via document.execCommand.
434
435         * DumpRenderTree/LayoutTestController.cpp:
436         (execCommandCallback):
437         (LayoutTestController::staticFunctions):
438         * DumpRenderTree/LayoutTestController.h:
439         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
440         (LayoutTestController::execCommand):
441         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
442         (LayoutTestController::queueLoad):
443         (LayoutTestController::execCommand):
444
445 2008-01-03  Alice Liu  <alice.liu@apple.com>
446
447         Reviewed by Darin, Mitz.
448
449         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
450
451         the clickcount should not increase if the last click was at a different location.  it's a new click.
452
453         * DumpRenderTree/mac/DumpRenderTree.mm:
454         (runTest):
455         * DumpRenderTree/mac/EventSendingController.h:
456         * DumpRenderTree/mac/EventSendingController.mm:
457         (-[EventSendingController mouseDown]):
458         (-[EventSendingController mouseUp]):
459
460 2008-01-03  Darin Adler  <darin@apple.com>
461
462         Reviewed by Adam.
463
464         * Scripts/update-webkit: Make this work a little better for the people at Apple
465         who have a directory named Internal.
466
467 2008-01-03  Adam Roben  <aroben@apple.com>
468
469         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
470
471         Rubberstamped by Mark.
472
473         * Scripts/update-webkit-auxiliary-libs:
474
475 2008-01-03  Adam Roben  <aroben@apple.com>
476
477         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
478
479         http://bugs.webkit.org/show_bug.cgi?id=15663
480
481         Added a fuzz factor into the Last-Modified comparison for downloading
482         WebKitAuxiliaryLibrary.zip.
483
484         The zip file is served from a set of mirrors who give Last-Modified
485         times that are off by 1-3 seconds from each other. This was causing
486         the build bots to redownload WebKitAuxiliaryLibrary for every build,
487         which would then cause all of WebCore to rebuild each time.
488
489         Reviewed by Mark.
490
491         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
492         at least 30 seconds newer than the old one -- otherwise we assume that
493         the difference in time is due to the mirrors being slightly offset
494         from each other.
495         (sub lastModifiedToUnixTime): Added.
496
497 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
498
499         Windows build fix.
500
501         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
502
503 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
504
505         Reviewed by Lars.
506
507         Moved QWebPage::open to QWebFrame::load and added setHtml.
508         
509
510         * DumpRenderTree/qt/DumpRenderTree.cpp:
511         (WebCore::DumpRenderTree::open):
512
513 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
514
515         Reviewed by Lars.
516
517         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
518         
519
520         * DumpRenderTree/qt/DumpRenderTree.cpp:
521         (WebCore::DumpRenderTree::DumpRenderTree):
522
523 2008-01-02  Sam Weinig  <sam@webkit.org>
524
525         * Scripts/do-webcore-rename: Yet more renaming ideas.
526
527 2008-01-02  Darin Adler  <darin@apple.com>
528
529         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
530
531 2008-01-02  Alice Liu  <alice.liu@apple.com>
532
533         Reviewed by Sam Weinig.
534
535         fixing assertion hit with editing/selection/move-begin-end.html
536
537         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
538         * DumpRenderTree/win/DumpRenderTree.vcproj:
539         * DumpRenderTree/win/EventSender.cpp:
540         (keyDownCallback):
541         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
542
543 2008-01-02  Darin Adler  <darin@apple.com>
544
545         * Scripts/do-webcore-rename: Some more name change plans.
546
547 2008-01-02  Alice Liu  <alice.liu@apple.com>
548
549         Reviewed by Maciej.
550
551         Added handling for page up and page down in EventSender
552
553         * DumpRenderTree/mac/EventSendingController.mm:
554         (-[EventSendingController keyDown:withModifiers:]):
555         * DumpRenderTree/win/EventSender.cpp:
556         (keyDownCallback):
557
558 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
559
560         Reviewed by Darin.
561
562         Fix fast/events/arrow-keys-on-body.html for real.
563
564         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
565
566 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
567
568         Reviewed by Darin.
569
570         http://bugs.webkit.org/show_bug.cgi?id=16674
571         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
572
573         * Scripts/run-launcher:
574
575 2007-12-31  Darin Adler  <darin@apple.com>
576
577         Suggested by Antti.
578
579         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
580         we get it installed on the build bots.
581
582 2007-12-30  Eric Seidel  <eric@webkit.org>
583
584         Reviewed by Sam.
585
586         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
587
588 2007-12-29  Darin Adler  <darin@apple.com>
589
590         Reviewed by Oliver.
591
592         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
593           leak bot shows createCStringFromNPVariant result leaking
594
595         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
596         (pluginInvoke): Added a missing free.
597
598 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
599
600         Reviewed by Alp Toker.
601
602         http://bugs.webkit.org/show_bug.cgi?id=16390
603         Use autotools or GNU make as the build system for the GTK port
604
605         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
606         * GNUmakefile.am: Added.
607
608 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
609
610         Reviewed by Oliver.
611
612         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
613
614         * DumpRenderTree/win/EventSender.cpp:
615         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
616         of 1, even though WebKit currently ignores it.
617
618 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
619
620         wx buildbot fix. Update libpng dl script to the latest version.
621
622         * wx/install-unix-extras:
623
624 2007-12-22  Antti Koivisto  <antti@apple.com>
625
626         Fix a typo.
627
628         * Scripts/webkitdirs.pm:
629
630 2007-12-21  Sam Weinig  <sam@webkit.org>
631
632         Reviewed by Mark Rowe.
633
634         - Disable the back/forward cache using the new WebPreferences API
635           instead of through the BackForwardList.  This makes us match what
636           we do on Windows.
637
638         * DumpRenderTree/mac/DumpRenderTree.mm:
639         (createWebViewAndOffscreenWindow):
640         (setDefaultsToConsistentValuesForTesting):
641
642 2007-12-21  Dan Bernstein  <mitz@apple.com>
643
644         Reviewed by Mark Rowe.
645
646         - disable the back/forward cache in Windows DumpRenderTree. It is
647           already disabled in Mac DumpRenderTree.
648
649         * DumpRenderTree/win/DumpRenderTree.cpp:
650         (initializePreferences):
651
652 2007-12-13  Antti Koivisto  <antti@apple.com>
653
654         Reviewed by Darin and Steve.
655         
656         - check for QuickTime SDK on Windows.
657         - build media support on Windows by default
658
659         * Scripts/build-webkit:
660         * Scripts/webkitdirs.pm:
661
662 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
663
664         Build script fix for buildbot.
665
666         * wx/build-wxwebkit:
667
668 2007-12-20  Eric Seidel  <eric@webkit.org>
669
670         Reviewed by mjs.
671
672         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
673
674 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
675
676         Reviewed by Steve.
677
678         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
679         WebKit.
680
681         - Drosera and Safari need to use the same ProgIDs in order for
682         CoCreateInstance to work properly.  The most robust way to do this is
683         for WebKit to dynamically publish those ProgIDs.
684
685         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
686         (DebuggerClient::createWebViewWithRequest):
687         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
688         statics.
689         (Drosera::initUI):
690         (Drosera::attach):
691         (Drosera::attemptToCreateServerConnection):
692         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
693         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
694         make use of the published ProgIDs.
695         (ServerConnection::attemptToCreateServerConnection):
696
697 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
698
699         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
700         - Build bot and leak fix.
701
702         * DumpRenderTree/LayoutTestController.cpp:
703         (pathToLocalResourceCallback):
704
705 2007-12-19  David Kilzer  <ddkilzer@apple.com>
706
707         Make svn-apply/svn-unapply work with patches from git-format-patch.
708
709         Reviewed by Darin.
710
711         * Scripts/svn-apply:
712         (patch): If 'Index:' can't be found in the text passed in, print it
713         out with a warning and return early.
714         * Scripts/svn-unapply:
715         (patch): Ditto.
716
717 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
718
719         Reviewed by Alp Toker.
720
721         Build related fixes.
722
723         * wx/build-wxwebkit:
724         - Check to make sure the user is running a supported wx port
725         - More robust checks for Cygwin
726         - Only run install-unix-extras on Mac, it's not the right solution
727           for Linux distros.
728         - Remove outdated Linux instructions after successful build
729         - Clean Bakefile-generated files during a clean operation
730
731 2007-12-18  Darin Adler  <darin@apple.com>
732
733         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
734
735 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
736
737         Add script to run Drosera as part of the nightly.
738         
739         Reviewed by Kevin M.
740
741         * Scripts/run-drosera.cmd: Added.
742
743 2007-12-18  Darin Adler  <darin@apple.com>
744
745         * Scripts/do-webcore-rename: Remove a stray K.
746
747 2007-12-18  Darin Adler  <darin@apple.com>
748
749         * Scripts/do-webcore-rename: Plan more renaming.
750
751 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
752
753         Reviewed by Alp Toker.
754
755         http://bugs.webkit.org/show_bug.cgi?id=16042
756         [GTK] Eliminate webkit_init()
757
758         Moving webkit initialization to WebView class init.
759
760         * DumpRenderTree/gtk/DumpRenderTree.cpp:
761         (main):
762         * GtkLauncher/main.c:
763         (main):
764
765 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
766
767         Reviewed by Alp Toker.
768
769         http://bugs.webkit.org/show_bug.cgi?id=13542
770         gdklauncher doesnt change URL in adress GTKEntry.
771
772         * GtkLauncher/main.c:
773         (load_commit_cb): added
774         (title_change_cb):
775         (create_browser):
776
777 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
778
779         Reviewed by Adam Roben.
780
781         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
782
783         * FindSafari/FindSafari.cpp:
784         (_tmain):
785
786 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
787
788         Reviewed by Adam Roben.
789
790         http://bugs.webkit.org/show_bug.cgi?id=16315
791         FindSafari needs a path-only option.
792
793         * FindSafari/FindSafari.cpp:
794         (_tmain):
795
796 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
797
798         Reviewed by Darin.
799
800         http://bugs.webkit.org/show_bug.cgi?id=16462
801         REGRESSION: access keys broken on Windows
802
803         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
804         if Alt is pressed.
805
806 2007-12-15  Sam Weinig  <sam@webkit.org>
807
808         Reviewed by Mark Rowe.
809
810         Fix urlSuitableForTestResult to correctly identify wstring::npos as
811         the case when wstring.find doesn't find anything.
812
813         * DumpRenderTree/win/DumpRenderTree.cpp:
814         (urlSuitableForTestResult):
815
816 2007-12-15  Alp Toker  <alp@atoker.com>
817
818         GTK+ DRT build fix for GLib < 2.14.
819
820         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
821         (LayoutTestController::setWaitToDump):
822
823 2007-12-05  Mark Rowe  <mrowe@apple.com>
824
825         Reviewed by Alp Toker.
826
827         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
828         many layout tests from hanging while waiting on user responses to dialogs.
829
830         * DumpRenderTree/gtk/DumpRenderTree.cpp:
831         (invalidateAnyPreviousWaitToDumpWatchdog):
832         (webViewScriptAlert):
833         (webViewScriptPrompt):
834         (webViewScriptConfirm):
835         (main):
836         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
837         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
838         (waitToDumpWatchdogFired):
839         (LayoutTestController::setWaitToDump):
840
841 2007-12-05  Mark Rowe  <mrowe@apple.com>
842
843         Reviewed by Alp Toker.
844
845         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
846
847         * DumpRenderTree/gtk/DumpRenderTree.cpp:
848         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
849         (dump):
850         (runTest):
851         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
852         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
853         work queue is empty.
854         (webViewWindowObjectCleared): Set up window.layoutTestController.
855         (webViewConsoleMessage): Match the console message format expected by the layout test results.
856         (main): Hook up the new signals.
857         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
858         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
859         dumping multiple times.
860         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
861         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
862
863 2007-12-14  Anders Carlsson  <andersca@apple.com>
864
865         Reviewed by Brady.
866
867         Assert that a web frame that's loading a resource always has either a data source or 
868         a provisional data source.
869         
870         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
871         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
872
873 2007-12-14  Darin Adler  <darin@apple.com>
874
875         - fix mistake causing nearly all tests to fail on Windows
876
877         * DumpRenderTree/win/UIDelegate.cpp:
878         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
879         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
880
881         * DumpRenderTree/mac/UIDelegate.mm:
882         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
883         than passing the entire message.
884
885 2007-12-14  Darin Adler  <darin@apple.com>
886
887         - fix Tiger build
888
889         * DumpRenderTree/mac/UIDelegate.mm:
890         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
891         new-to-Leopard methods.
892
893 2007-12-14  Darin Adler  <darin@apple.com>
894
895         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
896         since it now triggers unwanted icon loading. We only had it because we implemented "all"
897         delegate methods here.
898
899 2007-12-14  Anders Carlsson  <andersca@apple.com>
900
901         Reviewed by Darin and Geoff.
902
903         <rdar://problem/5619295> 
904         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
905         
906         Add property getting methods to the plug-in.
907         
908         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
909         (pluginInvoke):
910
911 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
912
913         Reviewed by Darin.
914
915         - Layout test fix for mac. When dumped to the console local file paths
916         now only show the name of the resource not the whole path.  This is to
917         make the results machine and OS independent.
918
919         * DumpRenderTree/mac/UIDelegate.mm:
920         (-[UIDelegate webView:addMessageToConsole:]):
921
922 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
923
924         Reviewed by Adam.
925
926         - Layout tests fix.  We need a way to remove machine-dependent
927         information from paths in layout test results. The UIDelegate now does
928         this.
929
930         * DumpRenderTree/DumpRenderTree.h:
931         * DumpRenderTree/win/DumpRenderTree.cpp:
932         (urlSuitableForTestResult):
933         * DumpRenderTree/win/DumpRenderTreeWin.h:
934         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
935         * DumpRenderTree/win/UIDelegate.cpp:
936         (UIDelegate::webViewAddMessageToConsole):
937
938 2007-12-13  Alp Toker  <alp@atoker.com>
939
940         Build fix for DRT breakage introduced in r28690.
941
942         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
943         (LayoutTestController::pathToLocalResource):
944
945 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
946
947         Reviewed by Alice and Sam.
948
949         - <rdar://5621435> Need a way to specify local resources (being loaded
950         from HTTP tests) on Windows.
951         - Implemented pathToLocalResource which exposes the functionality of
952         converting a given unix path to the correct location on Windows.
953
954         * DumpRenderTree/LayoutTestController.cpp:
955         (pathToLocalResourceCallback):
956         (LayoutTestController::staticFunctions):
957         * DumpRenderTree/LayoutTestController.h:
958         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
959         (LayoutTestController::pathToLocalResource):
960         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
961         (LayoutTestController::pathToLocalResource):
962
963 2007-12-12  Anders Carlsson  <andersca@apple.com>
964
965         Reviewed by Sam.
966
967         <rdar://problem/5132003>
968         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
969
970         * DumpRenderTree/win/DumpRenderTree.cpp:
971         (main):
972         Set the resource load delegate.
973         
974         * DumpRenderTree/win/DumpRenderTree.vcproj:
975         
976         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
977         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
978
979 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
980
981         Reviewed by Adam Roben.
982
983         Fix conversion from double to LPARAM in dispatchMessage().
984
985         * DumpRenderTree/win/EventSender.cpp:
986         (dispatchMessageCallback):
987
988 2007-12-11  Dan Bernstein  <mitz@apple.com>
989
990         Reviewed by Mark Rowe and Sam Weinig too!
991
992         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
993           fonts DumpRenderTree registers.
994
995         * DumpRenderTree/win/DumpRenderTree.cpp:
996         (initialize):
997
998 2007-12-11  Brady Eidson  <beidson@apple.com>
999
1000         Reviewed by Anders
1001
1002         Make DumpRenderTree on mac use its own path for Databases testing
1003
1004         * DumpRenderTree/mac/DumpRenderTree.mm:
1005         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1006           for future DRT-only use, then use it to construct the Databases path and set that default
1007
1008 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1009
1010         Reviewed by Darin.
1011
1012         <rdar://problem/5535636>
1013         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1014
1015         http://bugs.webkit.org/show_bug.cgi?id=13916
1016         JavaScript detects Tab as a character input on a textfield validation
1017
1018         * DumpRenderTree/mac/EventSendingController.mm:
1019         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1020         Dispatch a keyup to better match what happens when a key is physically pressed.
1021
1022         * DumpRenderTree/win/EventSender.cpp:
1023         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1024         returning from keyDown().
1025         (getConstantCallback): Fixed a couple copy/paste mistakes.
1026
1027 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1028
1029         Reviewed by Oliver.
1030
1031         - <rdar://5599845> Drosera: Does not show loal files in the file list
1032         on the left side.
1033
1034         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1035         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1036         so the open source community can build.
1037
1038 2007-12-10  Brady Eidson  <beidson@apple.com>
1039
1040         Rubberstamped by Sam Weinig
1041
1042         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1043
1044         * DumpRenderTree/mac/UIDelegate.mm:
1045         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1046         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1047
1048 2007-12-08  Oliver Hunt  <oliver@apple.com>
1049
1050         Reviewed by Sam W.
1051
1052         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1053         
1054         Fixes <rdar://problem/5620249> Must disable SVG animation
1055         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1056         
1057         In order to allow finer grained control over the set of SVG features
1058         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1059         distinct flags:
1060         ENABLE_SVG_ANIMATION
1061         ENABLE_SVG_FILTERS
1062         ENABLE_SVG_FONTS
1063         ENABLE_SVG_AS_IMAGE
1064         ENABLE_SVG_USE
1065         
1066         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1067         
1068         Script handles all the new build flags, and allows --svg-experimental
1069         to automatically enable all features.
1070
1071         * Scripts/build-webkit:
1072
1073 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1074
1075         Fix version parsing.
1076
1077         Rubber-stamped by Oliver.
1078
1079         * Drosera/win/Drosera.vcproj/auto-version.sh:
1080
1081 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1082
1083         Build modifications for Drosera.
1084
1085         Reviewed by Adam.
1086
1087         * Drosera/DroseraWin.make: Added.
1088         * Drosera/win/Drosera.vcproj/Drosera.rc:
1089         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1090         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1091         * Drosera/win/Drosera.vcproj/VERSION: Added.
1092         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1093
1094 2007-12-06  Adam Roben  <aroben@apple.com>
1095
1096         Explicitly turn on the Mac font ascent hack on Windows
1097
1098         This keeps our font metrics matching those from Mac.
1099
1100         Reviewed by Hyatt.
1101
1102         * DumpRenderTree/win/DumpRenderTree.cpp:
1103         (main):
1104
1105 2007-12-06  Anders Carlsson  <andersca@apple.com>
1106
1107         Rename main.c to main.cpp here too.
1108         
1109         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1110
1111 2007-12-06  Sam Weinig  <sam@webkit.org>
1112
1113         Rubber stamped by Geoff.
1114
1115         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1116
1117 2007-12-06  Darin Adler  <darin@apple.com>
1118
1119         * Scripts/do-webcore-rename: Some more renaming plans.
1120
1121 2007-12-06  Anders Carlsson  <andersca@apple.com>
1122
1123         Restore implementation of testGetIntIdentifier that was accidentally
1124         removed somehow (possibly when I made PluginObject be a cpp file).
1125         
1126         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1127         (pluginInvoke):
1128
1129 2007-12-05  Anders Carlsson  <andersca@apple.com>
1130
1131         Make the entry points extern "C".
1132         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1133         
1134 2007-12-05  Anders Carlsson  <andersca@apple.com>
1135
1136         C++ warning fixes.
1137         
1138         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1139         (NPP_New):
1140         (NPP_Destroy):
1141         (NPP_SetWindow):
1142         (NPP_NewStream):
1143         (NPP_HandleEvent):
1144         (NPP_URLNotify):
1145         (NPP_GetValue):
1146
1147 2007-12-05  Anders Carlsson  <andersca@apple.com>
1148
1149         Add the .cpp files to the TestNetscapePlugIn target.
1150
1151         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1152
1153 2007-12-05  Anders Carlsson  <andersca@apple.com>
1154
1155         Reviewed by Geoff.
1156         
1157         Rename the TestNetscapePlugIn .c files to be .cpp.
1158
1159         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1160         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1161         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1162         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1163         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1164         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1165         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1166         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1167
1168 2007-12-05  Adam Roben  <aroben@apple.com>
1169
1170         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1171
1172         This fixes several regression tests.
1173
1174         Reviewed by Alice.
1175
1176         * DumpRenderTree/win/EventSender.cpp:
1177         (keyDownCallback): Virtual keycodes for ASCII characters are always
1178         uppercase, so we need to check the case of the original character
1179         passed in to eventSender.keyDown.
1180
1181 2007-12-05  Adam Roben  <aroben@apple.com>
1182
1183         Learn from Tim's mistakes
1184
1185         * DumpRenderTree/win/DumpRenderTree.cpp:
1186         (runTest): Reset the authorAndUserStylesEnabled preference for each
1187         test.
1188
1189 2007-12-05  Alp Toker  <alp@atoker.com>
1190
1191         Reviewed by Mark Rowe.
1192
1193         Initialize GTK+ and WebKit so the tests can run.
1194
1195         Reorganize the headers a little.
1196
1197         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1198         (main):
1199
1200 2007-12-04  Anders Carlsson  <andersca@apple.com>
1201
1202         Remove IWebScriptScope include.
1203         
1204         * Drosera/win/DebuggerDocumentPlatform.cpp:
1205
1206 2007-12-04  Sam Weinig  <sam@webkit.org>
1207
1208         Rubber stamped by Mark Rowe.
1209
1210         Define CF as platform for mac and revert r28409
1211
1212         * DumpRenderTree/DumpRenderTree.h:
1213         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1214
1215 2007-12-04  Sam Weinig  <sam@webkit.org>
1216
1217         Define CF as platform for windows.
1218
1219         Reviewed by Adam Roben.
1220
1221         * DumpRenderTree/win/DumpRenderTreeWin.h:
1222
1223 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1224
1225         Reviewed by Adam and Darin.
1226
1227         - Removed a needless BSTR cleanup.
1228
1229         * Drosera/win/DebuggerDocumentPlatform.cpp:
1230         (DebuggerDocument::getPlatformCurrentFunctionStack):
1231
1232 2007-11-27  Adam Roben  <aroben@apple.com>
1233
1234         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1235
1236         Reviewed by Maciej.
1237
1238         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1239         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1240
1241 2007-12-04  Alp Toker  <alp@atoker.com>
1242
1243         Prospective Win DRT build fix.
1244
1245         * DumpRenderTree/DumpRenderTree.h:
1246
1247 2007-12-04  Alp Toker  <alp@atoker.com>
1248
1249         Fix a clobbered copyright header.
1250
1251         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1252
1253 2007-12-04  Xan Lopez  <xan@gnome.org>
1254
1255         Reviewed by Alp Toker.
1256
1257         http://bugs.webkit.org/show_bug.cgi?id=15561
1258         GTK port needs DumpRenderTree implementation
1259
1260         Start work on the GTK+ DRT.
1261
1262         This does not work yet, and there are a few lingering style issues
1263         (nothing major) but this patch has been stuck in the bug tracker for
1264         too long already.
1265
1266         * DumpRenderTree/DumpRenderTree.h:
1267         * DumpRenderTree/gtk: Added.
1268         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1269         (autocorrectURL):
1270         (shouldLogFrameLoadDelegates):
1271         (dumpFrameScrollPosition):
1272         (displayWebView):
1273         (appendString):
1274         (dumpFramesAsText):
1275         (dumpRenderTreeAsText):
1276         (dump):
1277         (runTest):
1278         (main):
1279         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1280         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1281         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1282         (GCController::collect):
1283         (GCController::collectOnAlternateThread):
1284         (GCController::getJSObjectCount):
1285         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1286         (LayoutTestController::~LayoutTestController):
1287         (LayoutTestController::addDisallowedURL):
1288         (LayoutTestController::clearBackForwardList):
1289         (LayoutTestController::copyDecodedHostName):
1290         (LayoutTestController::copyEncodedHostName):
1291         (LayoutTestController::display):
1292         (LayoutTestController::keepWebHistory):
1293         (LayoutTestController::notifyDone):
1294         (LayoutTestController::queueBackNavigation):
1295         (LayoutTestController::queueForwardNavigation):
1296         (LayoutTestController::queueLoad):
1297         (LayoutTestController::queueReload):
1298         (LayoutTestController::queueScript):
1299         (LayoutTestController::setAcceptsEditing):
1300         (LayoutTestController::setCustomPolicyDelegate):
1301         (LayoutTestController::setMainFrameIsFirstResponder):
1302         (LayoutTestController::setTabKeyCyclesThroughElements):
1303         (LayoutTestController::setUseDashboardCompatibilityMode):
1304         (LayoutTestController::setUserStyleSheetEnabled):
1305         (LayoutTestController::setUserStyleSheetLocation):
1306         (LayoutTestController::setWindowIsKey):
1307         (LayoutTestController::setWaitToDump):
1308         (LayoutTestController::windowCount):
1309         (LayoutTestController::setPrivateBrowsingEnabled):
1310         (LayoutTestController::setAuthorAndUserStylesEnabled):
1311         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1312         (JSStringCopyUTF8CString):
1313         (LoadItem::invoke):
1314         (ReloadItem::invoke):
1315         (ScriptItem::invoke):
1316         (BackForwardItem::invoke):
1317
1318 2007-12-03  Sam Weinig  <sam@webkit.org>
1319
1320         Move JavaScriptCore thread testing code to pthread specific directory
1321         and remove the dependance on CoreFoundation by using WTF::HashSet.
1322
1323         Reviewed by Geoff and Oliver.
1324
1325         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1326         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1327         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1328         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1329         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1330         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1331         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1332         * DumpRenderTree/pthreads: Added.
1333         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1334         (javaScriptThreads):
1335         (runJavaScriptThread):
1336         (startJavaScriptThreads):
1337         (stopJavaScriptThreads):
1338
1339 2007-12-03  Andrew Bonventre  <andybons@google.com>
1340
1341         Reviewed by Darin Adler.
1342
1343         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1344         Symbol lookup menu broken in debugger view
1345
1346         * Drosera/debugger.js: Fixed javascript error where document property
1347         should have been used instead of contentDocument in switchFunction that
1348         was breaking the select symbol dropdown menu.  This is because
1349         window.frames will return a Window object and not a frame object like
1350         the author was originally expecting.
1351
1352 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1353
1354         Reviewed by Adam.
1355
1356         - <rdar://5618942> Drosera: Console window does not process everything
1357         correctly.
1358         - <rdar://5619005> Drosera: could be sped up by moving the 
1359         WebScriptScope stuff into the WebScriptCallFrame.
1360         - Now the console can correctly process objects and does not receive
1361         notifications from JavaScriptCore about the JavaScript in Drosera's
1362         own process.
1363
1364         * Drosera/win/DebuggerDocumentPlatform.cpp:
1365         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1366         (DebuggerDocument::platformValueForScopeVariableNamed):
1367
1368 2007-12-03  Stephanie  <slewis@apple.com>
1369
1370         Reviewed by Darin.
1371
1372         Check to see if we are building a debug root
1373
1374         * Scripts/check-for-global-initializers: 
1375
1376 2007-12-03  Dan Bernstein  <mitz@apple.com>
1377
1378         Reviewed by Darin Adler.
1379
1380         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1381
1382         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1383         (pluginInvoke):
1384
1385 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1386
1387         Reviewed by Oliver.
1388
1389         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1390         in a more fine-grained manner than eventSender.keyDown().
1391
1392         * DumpRenderTree/win/EventSender.cpp:
1393         (getConstantCallback):
1394         (dispatchMessageCallback):
1395
1396 2007-12-02  Darin Adler  <darin@apple.com>
1397
1398         * Scripts/do-webcore-rename: More planned renaming.
1399
1400 2007-12-02  Sam Weinig  <sam@webkit.org>
1401
1402         Rubber stamped by Anders.
1403
1404         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1405         more uniform results cross platform.
1406
1407         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1408         (-[NSURL _drt_descriptionSuitableForTestResult]):
1409
1410 2007-12-02  Sam Weinig  <sam@webkit.org>
1411
1412         Rubber stamped by Niko.
1413
1414         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1415
1416         * DumpRenderTree/win/DumpRenderTree.cpp:
1417         * DumpRenderTree/win/DumpRenderTree.vcproj:
1418         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1419         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1420         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1421         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1422
1423 2007-12-01  Alp Toker  <alp@atoker.com>
1424
1425         Reviewed by Adam Roben.
1426
1427         Make use of the newly introduced webkit.h convenience header.
1428
1429         * GtkLauncher/main.c:
1430
1431 2007-12-01  Adam Treat  <treat@kde.org>
1432
1433         Reviewed by Simon.
1434
1435         * Check to see if the directory exists and exit if not.
1436
1437         * DumpRenderTree/qt/main.cpp:
1438         (main):
1439
1440 2007-12-01  Adam Treat  <treat@kde.org>
1441
1442         Reviewed by Simon.
1443
1444         * Don't hide symbols when in Debug mode
1445         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1446
1447
1448         * DumpRenderTree/qt/main.cpp:
1449         (messageHandler):
1450
1451 2007-11-30  Alp Toker  <alp@atoker.com>
1452
1453         Reviewed by Adam Roben.
1454
1455         http://bugs.webkit.org/show_bug.cgi?id=15691
1456         [GTK] Public API does not follow GTK+ conventions
1457
1458         Refactor the WebKit/GTK+ public API. Changes:
1459           WebKitPage -> WebKitWebView
1460           WebKitFrame -> WebKitWebFrame
1461
1462         Public API source and header names have been updated to mirror the API
1463         changes.
1464
1465         The API is now kept in WebKit/gtk/WebView to match other ports in the
1466         same class such as Mac and Win.
1467
1468         * GtkLauncher/main.c:
1469         (activate_uri_entry_cb):
1470         (link_hover_cb):
1471         (title_change_cb):
1472         (progress_change_cb):
1473         (go_back_cb):
1474         (go_forward_cb):
1475         (create_browser):
1476         (main):
1477
1478 2007-11-30  Adam Roben  <aroben@apple.com>
1479
1480         Hopefully the final build fix
1481
1482         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1483         pull in WTF's assertion/logging functions.
1484
1485 2007-11-30  Adam Roben  <aroben@apple.com>
1486
1487         Another build fix
1488
1489         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1490         WebKit.lib.
1491
1492 2007-11-30  Adam Roben  <aroben@apple.com>
1493
1494         Debug build fix
1495
1496         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1497         configuration.
1498         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1499         projects.
1500         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1501         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1502         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1503
1504 2007-11-30  Sam Weinig  <sam@webkit.org>
1505
1506         Reviewed by Adam Roben.
1507
1508         Fix drawSelectionRect to actually draw the selection rect.
1509
1510         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1511         (drawSelectionRect):
1512
1513 2007-11-30  Darin Adler  <darin@apple.com>
1514
1515         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1516
1517 2007-11-30  Darin Adler  <darin@apple.com>
1518
1519         * Scripts/do-webcore-rename: Get ready for some future renaming.
1520
1521 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1522
1523         Reviewed by Adam.
1524
1525         - Removed some unnecessary functions and changed an unused return type. 
1526
1527         * Drosera/win/DebuggerClient.cpp:
1528         (registerConsoleClass):
1529         * Drosera/win/DebuggerClient.h:
1530         * Drosera/win/Drosera.cpp:
1531         (registerDroseraClass):
1532
1533 2007-11-28  Alp Toker  <alp@atoker.com>
1534
1535         Reviewed by Timothy Hatcher.
1536
1537         http://bugs.webkit.org/show_bug.cgi?id=16174
1538         [GTK] Use "URI" not "URL" in public API
1539
1540         Replace use of the term "URL" with "URI" in public headers,
1541         documentation and some internal code to match GLib/GTK+ convention.
1542
1543         This is now mentioned in the API guidelines:
1544           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1545
1546         * GtkLauncher/main.c:
1547         (activate_uri_entry_cb):
1548         (title_change_cb):
1549         (create_toolbar):
1550         (main):
1551
1552 2007-11-29  Anders Carlsson  <andersca@apple.com>
1553
1554         Reviewed by Sam.
1555
1556         <rdar://problem/5230478>
1557         FrameLoadDelegate callbacks are not dumped in DRT.
1558         
1559         * DumpRenderTree/win/DumpRenderTree.cpp:
1560         (shouldLogFrameLoadDelegates):
1561         (runTest):
1562         (main):
1563         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1564         (BSTRtoString):
1565         (descriptionSuitableForTestResult):
1566         (FrameLoadDelegate::QueryInterface):
1567         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1568         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1569         (FrameLoadDelegate::didCommitLoadForFrame):
1570         (FrameLoadDelegate::didFinishLoadForFrame):
1571         (FrameLoadDelegate::willCloseFrame):
1572         (FrameLoadDelegate::didClearWindowObject):
1573         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1574         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1575         * DumpRenderTree/win/FrameLoaderDelegate.h:
1576         (FrameLoadDelegate::windowScriptObjectAvailable):
1577         (FrameLoadDelegate::didFirstLayoutInFrame):
1578
1579 2007-11-29  Sam Weinig  <sam@webkit.org>
1580
1581         Reviewed by Anders.
1582
1583         Add database quota UIDelegates methods to DRT UIDelegate.
1584
1585         * DumpRenderTree/mac/UIDelegate.mm:
1586         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1587         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1588
1589 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1590
1591         Reviewed by Sam.
1592
1593         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1594         dying and vice versa.
1595         - This fix will allow Drosera and Safari to reconnect if either of them
1596         closes correctly, but does not fix the case where one of them dies
1597         silently.
1598
1599         * Drosera/win/ServerConnection.cpp:
1600         (ServerConnection::attemptToCreateServerConnection): Added a safety
1601         check, because it's possilbe to try to connect to a server that's dying.
1602         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1603         the server has died.
1604         * Drosera/win/ServerConnection.h: Added the new function and removed
1605         an unnecessary member.
1606
1607 2007-11-29  Anders Carlsson  <andersca@apple.com>
1608
1609         * DumpRenderTree/win/DumpRenderTree.vcproj:
1610         Add shlwapi.lib to all configurations.
1611
1612 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1613
1614         - Build fix.  Added additional includes for VS Express to the Release
1615         project.
1616
1617         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1618
1619 2007-11-29  Anders Carlsson  <andersca@apple.com>
1620
1621         Reviewed by Adam.
1622
1623         <rdar://problem/5132005>
1624         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1625         
1626         * DumpRenderTree/win/DumpRenderTree.vcproj:
1627         Add shlwapi.lib
1628         
1629         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1630         (LayoutTestController::setUserStyleSheetEnabled):
1631         Implement this.
1632         
1633         (appendComponentToPath):
1634         New method which wraps the Win32 API PathAppend.
1635         
1636         (followShortcuts):
1637         New method which checks if a file points to a shortcut and
1638         follows the shortcut.
1639         
1640         (resolveCygwinPath):
1641         New method that takes a cygwin unix-style path and returns the Win32 path.
1642         
1643         (cfStringRefToWString):
1644         
1645         (LayoutTestController::setUserStyleSheetLocation):
1646         Implement this.
1647
1648 2007-11-29  Alice Liu  <alice.liu@apple.com>
1649
1650         Reviewed by Adam.
1651
1652         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1653
1654         * DumpRenderTree/win/EventSender.cpp:
1655         (keyDownCallback):
1656         uppercase letters were being sent as lowercase letters without the shift key down.
1657
1658 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1659
1660         - Windows build fix. VS express needs some love.
1661
1662         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1663
1664 2007-11-28  Darin Adler  <darin@apple.com>
1665
1666         Reviewed by Adam Roben.
1667
1668         * DumpRenderTree/mac/EventSendingController.mm:
1669         (-[EventSendingController keyDown:withModifiers:]):
1670         Send capital letters through as lowercase letters with the shift key down
1671         rather than sending them as if they were highly unusual "capital letter keys".
1672
1673         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1674         where you need to update results and more tests are failing than before.
1675
1676 2007-11-28  Anders Carlsson  <andersca@apple.com>
1677
1678         Reviewed by Darin.
1679
1680         <rdar://problem/5132001>
1681         contextClick is not implemented in DRT on Windows.
1682         
1683         * DumpRenderTree/win/EventSender.cpp:
1684         (contextClickCallback):
1685         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1686         by a WM_RBUTTONUP message.
1687         
1688         * DumpRenderTree/win/UIDelegate.cpp:
1689         (UIDelegate::hasCustomMenuImplementation):
1690         (UIDelegate::trackCustomPopupMenu):
1691         * DumpRenderTree/win/UIDelegate.h:
1692         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1693         menu from being shown (and causing the DRT to hang).
1694
1695 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1696
1697         Reviewed by Darin.
1698
1699         Fix DumpRenderTree ObjC bug comparing strings.
1700
1701         * DumpRenderTree/mac/ObjCController.m:
1702         (-[ObjCController identityIsEqual::]): Compare strings with string
1703         equality instead of identiy equality.
1704
1705 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1706
1707         Reviewed by Sam.
1708
1709         Reset the authorAndUserStylesEnabled preference
1710         back to YES for each test. Fixes the broken tests.
1711
1712         * DumpRenderTree/mac/DumpRenderTree.mm:
1713         (resetWebViewToConsistentStateBeforeTesting):
1714
1715 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1716
1717         Reviewed by Adam.
1718
1719         - Drosera now displays the console window, although it cannot currently
1720         process JavaScript.
1721
1722         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1723         (registerConsoleClass): Implemented.
1724         (consoleWndProc): Implemented.
1725         (DebuggerClient::onSize): Implemented.
1726         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1727         new window.
1728         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1729         creating and maintaining a new window.
1730         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1731         lines of code to more appropriate places.
1732         (Drosera::handleCommand):
1733         (Drosera::initUI):
1734         (Drosera::onSize):
1735         (Drosera::attach):
1736
1737 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1738
1739         Reviewed by Dave Hyatt.
1740
1741         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1742         
1743         Add support for disabling author and user styles for testing.
1744
1745         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1746         * DumpRenderTree/LayoutTestController.cpp:
1747         (setAuthorAndUserStylesEnabledCallback):
1748         (LayoutTestController::staticFunctions):
1749         * DumpRenderTree/LayoutTestController.h:
1750         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1751         (LayoutTestController::setAuthorAndUserStylesEnabled):
1752         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1753         (LayoutTestController::setAuthorAndUserStylesEnabled):
1754
1755 2007-11-26  Dan Bernstein  <mitz@apple.com>
1756
1757         - Tiger build fix.
1758
1759         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1760
1761 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1762
1763         Reviewed by Maciej.
1764
1765         - Implemented displaying variables for Drosera on Win.
1766
1767         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1768         that retrieve variables to not hold onto the return value since it's
1769         not returned.  Also changed to use the new signatures of the retrieval
1770         functions.
1771         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1772         (DebuggerDocument::platformValueForScopeVariableNamed):
1773         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1774         (droseraWndProc):
1775
1776 2007-11-26  Sam Weinig  <sam@webkit.org>
1777
1778         Cleanup names of painting and repainting functions.
1779
1780         Reviewed by Adam Roben.
1781
1782         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1783         (drawSelectionRect): was drawSelectionRectIntoContext.
1784         (dumpWebViewAsPixelsAndCompareWithExpected):
1785         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1786         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1787         (paintWebView): was drawWebViewIntoContext.
1788         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1789
1790 2007-11-26  Sam Weinig  <sam@webkit.org>
1791
1792         Reviewed by Dan Bernstein.
1793
1794         - Leopard build fix
1795
1796         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1797
1798 2007-11-26  Sam Weinig  <sam@webkit.org>
1799
1800         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1801         Use shared PixelDumpSupport for Mac DRT
1802
1803         Reviewed by Adam Roben.
1804
1805         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1806         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1807         * DumpRenderTree/cg/ImageDiffCG.cpp:
1808         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1809         (drawSelectionRectIntoContext):
1810         (dumpWebViewAsPixelsAndCompareWithExpected):
1811         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1812         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1813         * DumpRenderTree/mac/DumpRenderTree.mm:
1814         (dump):
1815         * DumpRenderTree/mac/ImageDiff.m: Removed.
1816         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1817         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1818         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1819         (setDefaultColorProfileToRGB):
1820         (getBitmapContextFromWebView):
1821         (drawWebViewIntoContext):
1822         (repaintWithVerticalSweep):
1823         (repaintWithHorizontalSweep):
1824         (getSelectionRect):
1825         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1826
1827 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1828
1829         Bug 16052: prepare-ChangeLog doesn't report deleted files
1830         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1831
1832         Reviewed by Sam.
1833
1834         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1835
1836 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1837
1838         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1839         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1840
1841         Reviewed by Adam.
1842
1843         Roll functionality of merge-changelog into resolve-ChangeLogs
1844         script.  The script now checks for ChangeLog.rej and
1845         ChangeLog.orig files first.  If it finds them, it uses the
1846         ChangeLog.rej file as a patch (in old contextual diff format) to
1847         apply with --fuzz=3.
1848
1849         * Scripts/merge-changelog: Removed.
1850         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1851
1852 2007-11-25  Sam Weinig  <sam@webkit.org>
1853
1854         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1855
1856         Reviewed by Mark Rowe.
1857
1858         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1859         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1860         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1861         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1862         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1863
1864 2007-11-25  Sam Weinig  <sam@webkit.org>
1865
1866         Convert DumpRenderTree to ues .xcconfig files.
1867
1868         Reviewed by Mark Rowe.
1869
1870         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1871         * DumpRenderTree/mac/Configurations: Added.
1872         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1873         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1874         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1875
1876 2007-11-25  Sam Weinig  <sam@webkit.org>
1877
1878         Add ForwardingHeaders to wtf for DumpRenderTree.
1879
1880         Reviewed by Mark Rowe.
1881
1882         * DumpRenderTree/DumpRenderTree.h:
1883         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1884         * DumpRenderTree/ForwardingHeaders: Added.
1885         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1886         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1887         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1888         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1889         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1890         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1891         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1892         * DumpRenderTree/LayoutTestController.cpp:
1893         * DumpRenderTree/WorkQueue.cpp:
1894         * DumpRenderTree/mac/DumpRenderTree.mm:
1895         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1896         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1897         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1898         * DumpRenderTree/mac/ObjCController.m:
1899         * DumpRenderTree/mac/UIDelegate.mm:
1900         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1901
1902 2007-11-25  Adam Roben  <aroben@apple.com>
1903
1904         Fix some test failures caused by r28019
1905
1906         Now that stdout is in binary mode, we need to always use printf
1907         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1908         the output.
1909
1910         Reviewed by Sam.
1911
1912         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1913         printf.
1914         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1915         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1916         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1917         (UIDelegate::webViewAddMessageToConsole):
1918
1919 2007-11-25  Adam Roben  <aroben@apple.com>
1920
1921         Set the font smoothing preference in DRT
1922
1923         This makes the pixel results on Windows closer to the Mac results.
1924
1925         Reviewed by Mitz.
1926
1927         * DumpRenderTree/win/DumpRenderTree.cpp:
1928         (initializePreferences):
1929
1930 2007-11-25  Adam Roben  <aroben@apple.com>
1931
1932         Port ImageDiff to CG and C++
1933
1934         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1935         <rdar://5071708>
1936
1937         Reviewed by Sam.
1938
1939         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1940         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1941         (main):
1942         (createImageFromStdin):
1943         (compareImages):
1944         (getDifferenceBitmap):
1945         (computePercentageDifferent):
1946         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1947
1948 2007-11-25  Adam Roben  <aroben@apple.com>
1949
1950         Fix image diff link generation on Windows
1951
1952         Reviewed by Sam.
1953
1954         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1955         to toURL.
1956
1957 2007-11-25  Adam Roben  <aroben@apple.com>
1958
1959         Implement pixel dumping in Windows DRT
1960
1961         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1962         <rdar://5071708>
1963
1964         Reviewed by Sam.
1965
1966         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1967         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1968         Content-Length header.
1969         (getMD5HashStringForBitmap):
1970         (dumpWebViewAsPixelsAndCompareWithExpected):
1971         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1972         * DumpRenderTree/win/DumpRenderTree.cpp:
1973         (dump): Do a pixel dump if requested.
1974         (main): Parse pixel test options.
1975         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1976         the cg/ subdirectory to the include path.
1977         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1978         available in a header or import library, so we have to go through this
1979         LoadLibrary/GetProcAddress dance to use them.
1980         (cryptDLL):
1981         (init):
1982         (update):
1983         (final):
1984         (MD5_Init):
1985         (MD5_Update):
1986         (MD5_Final):
1987         * DumpRenderTree/win/MD5.h: Added.
1988         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1989         moved up to the top level to share it with Mac eventually.
1990         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1991         (getBitmapContextFromWebView): Forces the WebView to paint using a
1992         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1993
1994 2007-11-25  Adam Roben  <aroben@apple.com>
1995
1996         Clean up Windows DRT's option parsing a little bit
1997
1998         Reviewed by Sam.
1999
2000         * DumpRenderTree/win/DumpRenderTree.cpp:
2001         (main): Put non-option arguments into a Vector.
2002
2003 2007-11-25  Adam Roben  <aroben@apple.com>
2004
2005         Make Windows DRT stop changing LF into CRLF
2006
2007         Reviewed by Sam.
2008
2009         * DumpRenderTree/win/DumpRenderTree.cpp:
2010         (main): Put stdout in binary mode.
2011         * Scripts/run-webkit-tests: Remove the CRLF hack.
2012
2013 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2014
2015         Removed empty directory.
2016
2017         * Scripts/resources: Removed.
2018
2019 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2020
2021         Fix bisect-builds to work with recent WebKit nightly builds.
2022
2023         Reviewed by Dan.
2024
2025         * Scripts/bisect-builds: Check for the 
2026         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2027         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2028         to WebKit.app/Contents/Resources.
2029
2030 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2031
2032         Reviewed by Maciej.
2033
2034         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2035         not closed (affects digg.com)
2036
2037         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2038         one after finishing with a test to avoid having its delayed onload handler firing when
2039         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2040         but it helps somewhat.
2041
2042 2007-11-22  Mark Rowe  <mrowe@apple.com>
2043
2044         Reviewed by Alp Toker.
2045
2046         Fix build-webkit to propagate make's exit status if it fails.
2047
2048         * Scripts/webkitdirs.pm:
2049
2050 2007-11-22  Dan Bernstein  <mitz@apple.com>
2051
2052         Reviewed by Mark Rowe.
2053
2054         - fix crash when running pixel tests
2055
2056         * DumpRenderTree/mac/DumpRenderTree.mm:
2057         (dumpRenderTree): Parse the command line options before setting up the
2058         environment so that we know if we need to set up the pixel dump
2059         machinery.
2060
2061 2007-11-21  Eric Seidel  <eric@webkit.org>
2062
2063         Speculative build fix for Tiger.
2064
2065         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2066
2067 2007-11-21  Eric Seidel  <eric@webkit.org>
2068
2069         Reviewed by Tim Hatcher.
2070
2071         Break out more of DumpRenderTree.mm into individual files
2072
2073         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2074         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2075         (checkedMalloc):
2076         (checkedRealloc):
2077         (makeLargeMallocFailSilently):
2078         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2079         * DumpRenderTree/mac/DumpRenderTree.mm:
2080         (crashHandler):
2081         (dump):
2082         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2083         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2084         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2085         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2086         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2087         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2088         (javaScriptThreads):
2089         (runJavaScriptThread):
2090         (startJavaScriptThreads):
2091         (stopJavaScriptThreads):
2092         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2093         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2094         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2095         (restoreColorSpace):
2096         (setDefaultColorProfileToRGB):
2097         (initializeColorSpaceAndScreeBufferForPixelTests):
2098         (md5HashStringForBitmap):
2099         (dumpWebViewAsPixelsAndCompareWithExpected):
2100
2101 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2102
2103         Move install-unix-extras to wx directory as it seems only to be used by that 
2104         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2105         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2106         have install-unix-extras install into WebKitLibraries as per
2107         convention.
2108         
2109         Reviewed by Mark Rowe.
2110
2111         * Scripts/install-unix-extras: Removed.
2112         * wx/build-wxwebkit:
2113         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2114
2115 2007-11-21  Eric Seidel  <eric@webkit.org>
2116
2117         Reviewed by Adam.
2118
2119         More refactoring for greater code readability
2120
2121         * DumpRenderTree/mac/DumpRenderTree.mm:
2122         (initializeGlobalsFromCommandLineOptions):
2123         (initializeColorSpaceAndScreeBufferForPixelTests):
2124         (addTestPluginsToPluginSearchPath):
2125         (useLongRunningServerMode):
2126         (runTestingServerLoop):
2127         (prepareConsistentTestingEnvironment):
2128         (dumpRenderTree):
2129         (main):
2130         (dumpFramesAsText):
2131         (dumpBackForwardListForWebView):
2132         (sizeWebViewForCurrentTest):
2133         (methodNameStringForFailedTest):
2134         (dumpBackForwardListForAllWindows):
2135         (dumpWebViewAsPixelsAndCompareWithExpected):
2136         (invalidateAnyPreviousWaitToDumpWatchdog):
2137         (dump):
2138         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2139         * DumpRenderTree/mac/UIDelegate.mm:
2140         (-[UIDelegate webView:createWebViewWithRequest:]):
2141
2142 2007-11-21  Eric Seidel  <eric@webkit.org>
2143
2144         Reviewed by Tim Hatcher.
2145
2146         Abstract more of DRT into static methods
2147
2148         * DumpRenderTree/mac/DumpRenderTree.mm:
2149         (setDefaultsToConsistentValuesForTesting):
2150         (setupSignalHandlers):
2151         (allocateGlobalControllers):
2152         (releaseAndZero):
2153         (releaseGlobalControllers):
2154         (dumpRenderTree):
2155         (shouldLogFrameLoadDelegates):
2156         (createCFURLFromPathOrURL):
2157         (resetWebViewToConsistentStateBeforeTesting):
2158         (runTest):
2159
2160 2007-11-21  Eric Seidel  <eric@webkit.org>
2161
2162         Reviewed by Tim Hatcher.
2163
2164         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2165
2166         * DumpRenderTree/DumpRenderTree.h:
2167         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2168         * DumpRenderTree/mac/DumpRenderTree.mm:
2169         (dumpRenderTree):
2170         (dump):
2171         (runTest):
2172         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2173         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2174         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2175         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2176         (-[DumpRenderTreePasteboard declareType:owner:]):
2177         (+[LocalPasteboard alloc]):
2178         (-[LocalPasteboard init]):
2179         (-[LocalPasteboard dealloc]):
2180         (-[LocalPasteboard name]):
2181         (-[LocalPasteboard releaseGlobally]):
2182         (-[LocalPasteboard declareTypes:owner:]):
2183         (-[LocalPasteboard addTypes:owner:]):
2184         (-[LocalPasteboard changeCount]):
2185         (-[LocalPasteboard types]):
2186         (-[LocalPasteboard availableTypeFromArray:]):
2187         (-[LocalPasteboard setData:forType:]):
2188         (-[LocalPasteboard dataForType:]):
2189         (-[LocalPasteboard setPropertyList:forType:]):
2190         (-[LocalPasteboard setString:forType:]):
2191         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2192         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2193         (+[DumpRenderTreeWindow allWindows]):
2194         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2195         (-[DumpRenderTreeWindow dealloc]):
2196         (-[DumpRenderTreeWindow isKeyWindow]):
2197         (-[DumpRenderTreeWindow keyDown:]):
2198
2199 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2200
2201         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2202         it indiscriminately copies any headers inside JavaScriptCore,
2203         which includes Tiger ICU headers. 
2204
2205         * wx/build-wxwebkit:
2206         Don't run WebCore/move-js-headers.sh any longer.
2207
2208 2007-11-20  Adam Treat  <treat@kde.org>
2209
2210         Reviewed by David Kilzer.
2211
2212         * Prepend git branch name to $baseProductDir
2213
2214         * Scripts/VCSUtils.pm:
2215         * Scripts/webkitdirs.pm:
2216
2217 2007-11-20  Mark Rowe  <mrowe@apple.com>
2218
2219         Reviewed by Simon Hausmann.
2220
2221         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2222         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2223         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2224         built product and generated Makefile's are removed.
2225
2226 2007-11-19  Alp Toker  <alp@atoker.com>
2227
2228         Reviewed by Mark Rowe.
2229
2230         http://bugs.webkit.org/show_bug.cgi?id=16040
2231         [GTK] GtkLauncher should be written in C
2232
2233         Port GtkLauncher to plain C.
2234
2235         Use a more conventional GTK+ coding style.
2236
2237         Use a toolbar instead of menus.
2238
2239         Various signature fixes and cleanups.
2240
2241         Add a license header. Assume all previous modifications were copyright
2242         assigned to Apple Inc. by default.
2243
2244         * GtkLauncher/GtkLauncher.pro:
2245         * GtkLauncher/main.c: Added.
2246         (activate_url_entry_cb):
2247         (update_title):
2248         (link_hover_cb):
2249         (title_change_cb):
2250         (progress_change_cb):
2251         (destroy_cb):
2252         (go_back_cb):
2253         (go_forward_cb):
2254         (create_browser):
2255         (create_statusbar):
2256         (create_toolbar):
2257         (create_window):
2258         (main):
2259         * GtkLauncher/main.cpp: Removed.
2260
2261 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2262
2263         Build script fixes to ensure they do the right thing for the 
2264         wx port, and update build-wxwebkit to reflect the way the
2265         build scripts now work.
2266
2267         Reviewed by Adam.
2268
2269         * Scripts/build-testkjs:
2270         * Scripts/build-webkit:
2271         * Scripts/run-javascriptcore-tests:
2272         * Scripts/webkitdirs.pm:
2273         * wx/build-wxwebkit:
2274
2275 2007-11-18  Eric Seidel  <eric@webkit.org>
2276
2277         Reviewed by Anders.
2278
2279         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2280
2281         * Scripts/run-javascriptcore-tests:
2282
2283 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2284
2285         Reviewed by Adam Roben.
2286
2287         Make run-webkit-tests work with Windows debug build.
2288
2289         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2290         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2291         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2292         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2293         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2294
2295 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2296
2297         Add wxWebKit sample and build script, and integrate it with 
2298         build-webkit. Also make build-webkit --clean work for all
2299         ports.
2300
2301         Reviewed by Darin Adler.
2302
2303         * Scripts/build-webkit:
2304         * Scripts/webkitdirs.pm:
2305         * wx: Added.
2306         * wx/browser: Added.
2307         * wx/browser/browser.bkl: Added.
2308         * wx/browser/browser.cpp: Added.
2309         * wx/build-wxwebkit: Added.
2310
2311 2007-11-17  Adam Roben  <aroben@apple.com>
2312
2313         Make it easy to run Safari in the debugger on Windows
2314
2315         I've added a new script, debug-safari, which launches Safari in the
2316         debugger. On OS X it just calls gdb-safari.
2317
2318         Reviewed by Mark Rowe.
2319
2320         * FindSafari/FindSafari.cpp:
2321         (_tmain): Added a /debugger flag, which in combination with
2322         /printSafariLauncher will print a script that launches Safari in the
2323         debugger.
2324         * Scripts/debug-safari: Added.
2325         * Scripts/run-safari: Changed to call runSafari().
2326         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2327         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2328         first argument along to FindSafari.
2329         * Scripts/webkitdirs.pm:
2330         (sub runSafari): Added.
2331
2332 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2333
2334         Reviewed by Adam Roben.
2335
2336         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2337
2338 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2339
2340         Reviewed by David Kilzer.
2341
2342         The git config command was renamed to repo-config at some point. This
2343         change tries git config and then git repo-config if the first fails.
2344
2345         * Scripts/prepare-ChangeLog:
2346         (gitConfig):
2347
2348 2007-11-16  Dan Bernstein  <mitz@apple.com>
2349
2350         Reviewed by Darin Adler and Sam Weinig.
2351
2352         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2353
2354         * DumpRenderTree/win/EventSender.cpp:
2355         (keyDownCallback): For characters that cannot be entered on the active
2356         keyboard layout, send a WM_CHAR message with the character along with
2357         a WM_KEYDOWN message with a virtual key code of 255.
2358
2359 2007-11-16  Mark Rowe  <mrowe@apple.com>
2360
2361         Reviewed by Tim Hatcher.
2362
2363         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2364
2365         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2366         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2367
2368 2007-11-15  Adam Roben  <aroben@apple.com>
2369
2370         Make run-safari actually work on Windows
2371
2372         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2373         chdir call.
2374
2375 2007-11-14  Adam Roben  <aroben@apple.com>
2376
2377         Updates to Safari launching now that 3.0.4 is released
2378
2379         Reviewed by Sam.
2380
2381         * FindSafari/FindSafari.cpp:
2382         (getWebViewCLSID): Use version-independent ProgID.
2383         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2384
2385 2007-11-14  Anders Carlsson  <andersca@apple.com>
2386
2387         Reviewed by Adam.
2388
2389         <rdar://problem/5309081>
2390         In DRT, "plugin.logDestroy = true" not working on Windows.
2391         
2392         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2393         (NPP_Destroy):
2394
2395 2007-11-14  Eric Seidel  <eric@webkit.org>
2396
2397         Reviewed by Sam.
2398
2399         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2400
2401 2007-11-14  Anders Carlsson  <andersca@apple.com>
2402
2403         Reviewed by Adam.
2404
2405         <rdar://problem/5141186>
2406         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2407         
2408         Implement setWindowIsKey.
2409         
2410         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2411         (LayoutTestController::setWindowIsKey):
2412
2413 2007-11-13  Sam Weinig  <sam@webkit.org>
2414
2415         Reviewed by Adam Roben.
2416
2417         Fix for <rdar://problem/5382579>
2418         http/tests/security/cross-frame-access-put.html reports large 
2419         negative numbers for screenLeft and screenTop (Mac reports "0")
2420
2421         * DumpRenderTree/win/UIDelegate.cpp:
2422         (UIDelegate::UIDelegate): Initialize the RECT.
2423         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2424         (UIDelegate::webViewFrame): ditto.
2425         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2426
2427 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2428
2429         Reviewed by Adam.
2430
2431         - Make Drosera show source, source URLs, and function stack on Windows,
2432         and some minor fixes.
2433
2434         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2435         (DebuggerDocument::updateFileSource):
2436         * Drosera/debugger.js: Force source to always update display.
2437         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2438         menu controls.
2439         (DebuggerClient::resume):
2440         (DebuggerClient::pause):
2441         (DebuggerClient::stepInto):
2442         (DebuggerClient::stepOver):
2443         (DebuggerClient::stepOut):
2444         (DebuggerClient::showConsole):
2445         (DebuggerClient::closeCurrentFile):
2446         * Drosera/win/DebuggerClient.h: Ditto.
2447         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2448         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2449         removed two bugs.  1) caller could be in a bad state when asked to
2450         assign into it. 2) BSTRs were not created correctly.
2451         (DebuggerDocument::getPlatformCurrentFunctionStack):
2452         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2453         (droseraWndProc):
2454         (handleCommand):
2455         (Drosera::resume):
2456         (Drosera::pause):
2457         (Drosera::stepInto):
2458         (Drosera::stepOver):
2459         (Drosera::stepOut):
2460         (Drosera::showConsole):
2461         (Drosera::closeCurrentFile):
2462         * Drosera/win/Drosera.h: Hook up the menu controls.
2463         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2464         functions, added a null check, and fixed another bug where caller could
2465         be in a bad state when asked to assign into it.
2466         (ServerConnection::didLoadMainResourceForDataSource):
2467         (ServerConnection::getCallerFrame):
2468         * Drosera/win/ServerConnection.h: Safety first.
2469
2470 2007-11-13  Dan Bernstein  <mitz@apple.com>
2471
2472         Reviewed by Darin Adler.
2473
2474         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2475           DumpRenderTree --pixel-tests renders each test twice
2476
2477         * DumpRenderTree/mac/DumpRenderTree.mm:
2478         (dumpRenderTree): Removed the --paint option because the painting code
2479         is always exercised as a result of
2480         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2481         calling -displayIfNeeded.
2482         (dump): Changed to always grab the image from the window since the view
2483         is always displayed.
2484         (runTest):
2485         (displayWebView):
2486         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2487         because it always paints.
2488
2489 2007-11-12  Antti Koivisto  <antti@apple.com>
2490
2491         Reviewed by Adele.
2492         
2493         Add support for http media tests
2494
2495         * Scripts/run-webkit-tests:
2496
2497 2007-11-12  Sam Weinig  <sam@webkit.org>
2498
2499         Reviewed by Adam Roben.
2500
2501         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2502
2503         * DumpRenderTree/win/DumpRenderTree.cpp:
2504         (runTest):
2505         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2506         (LayoutTestController::setPrivateBrowsingEnabled):
2507
2508 2007-11-12  Adam Roben  <aroben@apple.com>
2509
2510         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2511         mac and win subdirectories.
2512
2513 2007-11-11  Adam Roben  <aroben@apple.com>
2514
2515         Fix <rdar://5133816> keepWebHistory is not implemented
2516
2517         Fixes fast/history/clicked-link-is-visited.html.
2518
2519         Reviewed by Darin.
2520
2521         * DumpRenderTree/win/DumpRenderTree.cpp:
2522         (runTest): Clear the optionalSharedHistory.
2523         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2524         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2525
2526 2007-11-10  Sam Weinig  <sam@webkit.org>
2527
2528         Reviewed by Tim Hatcher.
2529
2530         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2531         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2532         is turned on)
2533
2534         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2535
2536         Added test: http/tests/security/cross-frame-access-private-browsing.html
2537
2538         * DumpRenderTree/LayoutTestController.cpp:
2539         (setPrivateBrowsingEnabledCallback):
2540         (LayoutTestController::staticFunctions):
2541         * DumpRenderTree/LayoutTestController.h:
2542         * DumpRenderTree/mac/DumpRenderTree.mm:
2543         (runTest): Default to private browsing disabled.
2544         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2545         (LayoutTestController::setPrivateBrowsingEnabled):
2546         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2547         (LayoutTestController::setPrivateBrowsingEnabled):
2548
2549 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2550
2551         Reviewed by Adam.
2552
2553         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2554         WebCore's!
2555
2556         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2557         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2558         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2559         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2560         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2561         * Drosera/win/Drosera.cpp:
2562         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2563
2564 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2565
2566         Reviewed by Sam.
2567
2568         - Use the new IWebFrame [local] function signature and get the shared
2569         server correctly.
2570
2571         * Drosera/win/DebuggerClient.cpp:
2572         (DebuggerClient::didFinishLoadForFrame):
2573         * Drosera/win/ServerConnection.cpp:
2574         (ServerConnection::attemptToCreateServerConnection):
2575
2576 2007-11-07  Dan Bernstein  <mitz@apple.com>
2577
2578         Reviewed by Darin Adler.
2579
2580         - add an option to run-webkit-tests to ignore pixel test failures where
2581           all pixels differ by no more than a specified threshold
2582
2583         * DumpRenderTree/mac/ImageDiff.m:
2584         (main):
2585         (compareImages):
2586         (computePercentageDifferent):
2587         * Scripts/run-webkit-tests:
2588
2589 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2590
2591         Reviewed by Lars.
2592
2593         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2594
2595         * DumpRenderTree/qt/DumpRenderTree.cpp:
2596
2597 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2598
2599         Reviewed by Lars.
2600
2601         Reworked the QWebSettings API.
2602         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2603
2604         * DumpRenderTree/qt/DumpRenderTree.cpp:
2605
2606 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2607
2608         Reviewed by Lars.
2609
2610         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2611
2612         * DumpRenderTree/qt/jsobjects.cpp:
2613
2614 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2615
2616         Reviewed by Lars Knoll <lars@trolltech.com>.
2617
2618         Add a QWebPage::frameCreated() signal and fix DRT
2619         
2620         The removal of createFrame in QWebPage broke the re-implementation
2621         in DumpRenderTree. Instead emit a frameCreated() signal and
2622         connect to it in DumpRenderTree.
2623         
2624
2625         * DumpRenderTree/qt/DumpRenderTree.cpp:
2626         (WebCore::WebPage::WebPage):
2627         (WebCore::DumpRenderTree::dump):
2628         (WebCore::DumpRenderTree::connectFrame):
2629         * DumpRenderTree/qt/DumpRenderTree.h:
2630
2631 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2632
2633         Reviewed by Lars Knoll <lars@trolltech.com>.
2634
2635         Moved all the event handlers from QWebFrame into QWebPage.
2636         
2637         This cleans up the public API and allows us to remove the
2638         HackWebFrame hack in DumpRenderTree.
2639         
2640
2641         * DumpRenderTree/qt/jsobjects.cpp:
2642         (EventSender::mouseDown):
2643         (EventSender::mouseUp):
2644         (EventSender::mouseMoveTo):
2645
2646 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2647
2648         Reviewed by Mark.
2649
2650         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2651         to prevent the default implementation from popping up messageboxes.
2652
2653         * DumpRenderTree/qt/DumpRenderTree.cpp:
2654         (WebCore::WebPage::javaScriptConfirm):
2655         (WebCore::WebPage::javaScriptPrompt):
2656
2657 2007-11-06  Eric Seidel  <eric@webkit.org>
2658
2659         * Scripts/build-testkjs: build fix... too many $$
2660
2661 2007-11-06  Eric Seidel  <eric@webkit.org>
2662
2663         Reviewed by Mark Rowe.
2664
2665         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2666
2667 2007-11-05  Adam Roben  <aroben@apple.com>
2668
2669         Add support on Windows for WEBKIT_TESTFONTS
2670
2671         This environment variable lets you specify where the fonts to be used
2672         by DumpRenderTree reside. The Qt port is already using this, so I'm
2673         just following their lead.
2674
2675         Reviewed by Darin.
2676
2677         * DumpRenderTree/win/DumpRenderTree.cpp:
2678         (exePath): Refactored code out of initialize().
2679         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2680         DumpRenderTree.resources.
2681         (initialize): Use the new fontsPath function.
2682         (main): Use the new exePath function.
2683         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2684         variable to DRT, like Qt does.
2685
2686 2007-11-05  Mark Rowe  <mrowe@apple.com>
2687
2688         Rubber-stamped by Alp Toker.
2689
2690         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2691
2692         * GtkLauncher/main.cpp:
2693         (goToURLBarText):
2694         (main):
2695
2696 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2697
2698         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2699         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2700
2701         Reviewed by Timothy.
2702
2703         Restrict the range of nightly builds used by the bisect-builds script
2704         based on the version of Safari and the version of Mac OS X being used.
2705
2706         Mac OS X 10.4: Safari 2.0: r11976 or newer
2707         Mac OS X 10.4: Safari 3.0: r19992 or newer
2708
2709         Mac OS X 10.5: Safari 2.0: r19594 or newer
2710         Mac OS X 10.5: Safari 3.0: r25124 or newer
2711
2712         * Scripts/bisect-builds:
2713         (findMacOSXVersion): Added.
2714         (makeNightlyList): Added argument to provide version of Mac OS X.
2715         Restrict range of nightly builds based on Safari and Mac OS X versions.
2716
2717 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2718
2719         Reviewed by Maciej.
2720
2721         - This patch involves several changes, all of them were noticed that
2722         they were needed by the work being done in WebKit to get Drosera and
2723         WebKit working together on Windows.
2724         - The changes are:
2725         1) Added a debugger console for output messages.
2726         2) Drosera now listens for the WebKit server (before, the server would
2727         have to be running before Drosera was started.)
2728         3) Fixed a bug where the WebView started out as 0x0 pixels.
2729         4) Fixed a bug when there is no scope.
2730         5) Added the HTML, JS, and CSS to the project file to make them easy to
2731         find.
2732         6) Made the ServerConnection functions virtual.
2733
2734         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2735         for the WebKit server.
2736         (DebuggerClient::DebuggerClient):
2737         (DebuggerClient::~DebuggerClient):
2738         (DebuggerClient::didFinishLoadForFrame):
2739         (DebuggerClient::serverConnected):
2740         (DebuggerClient::attemptToCreateServerConnection):
2741         * Drosera/win/DebuggerClient.h: Ditto.
2742         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2743         scope.
2744         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2745         (DebuggerDocument::platformValueForScopeVariableNamed):
2746         * Drosera/win/Drosera.cpp:
2747         (_tWinMain): Added a console in debug for output messages.
2748         (Drosera::Drosera): Listen for server.
2749         (Drosera::initUI): The server now Initializes COM.
2750         (Drosera::serverConnected): Part of the listening for the server.
2751         (Drosera::attemptToCreateServerConnection): Ditto.
2752         * Drosera/win/Drosera.h: New interface for listening for the server.
2753         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2754         files to the VS project.
2755         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2756         connection.
2757         (ServerConnection::ServerConnection):
2758         (ServerConnection::attemptToCreateServerConnection):
2759         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2760         methods.
2761         (ServerConnection::serverConnected):
2762
2763 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2764
2765         Reviewed by Maciej.
2766
2767         http://bugs.webkit.org/show_bug.cgi?id=15832
2768         fast/dom/gc-10.html crashes when run alone
2769
2770         Check for !done before using objects that can be already deallocated.
2771
2772         * DumpRenderTree/mac/EditingDelegate.mm:
2773         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2774         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2775         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2776         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2777         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2778         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2779         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2780         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2781         (-[EditingDelegate webViewDidBeginEditing:]):
2782         (-[EditingDelegate webViewDidChange:]):
2783         (-[EditingDelegate webViewDidEndEditing:]):
2784         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2785         (-[EditingDelegate webViewDidChangeSelection:]):
2786         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2787         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2788         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2789         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2790         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2791         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2792         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2793         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2794         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2795         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2796         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2797         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2798         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2799         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2800         (-[FrameLoadDelegate webView:willCloseFrame:]):
2801         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2802         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2803         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2804         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2805         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2806         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2807         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2808         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2809         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2810
2811 2007-11-04  Mark Rowe  <mrowe@apple.com>
2812
2813         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2814         warnings that would otherwise be suppressed due to it being a system header.
2815
2816         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2817
2818 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2819
2820         Rubber stamped by Adam.
2821         
2822         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2823
2824         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2825
2826 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2827
2828         Sort files(...); sections of Xcode project files.
2829
2830         Rubber-stamped by Darin.
2831
2832         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2833         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2834         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2835         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2836
2837 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2838
2839         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2840
2841         Reviewed by Darin.
2842
2843         * Scripts/sort-Xcode-project-file: Added.
2844
2845 2007-11-02  Darin Adler  <darin@apple.com>
2846
2847         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2848
2849 2007-11-02  Darin Adler  <darin@apple.com>
2850
2851         Reviewed by Maciej.
2852
2853         * Scripts/run-sunspider: Pass the "--base" option through.
2854
2855         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2856         the real script do that. Default configuration to Release to match run-sunspider
2857         so we don't end up building Debug just to compare results.
2858
2859 2007-11-01  Adam Roben  <aroben@apple.com>
2860
2861         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2862
2863         Reviewed by Sam.
2864
2865         * Scripts/commit-log-editor: Show all the directories beneath the
2866         source root, instead of just the last one.
2867
2868 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2869
2870         Reviewed by Adam Roben.
2871
2872         Print out an error message when the Windows build fails
2873         and provide guidance on how to find out what went wrong.
2874
2875         * Scripts/build-webkit:
2876         * Scripts/webkitdirs.pm:
2877
2878 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2879
2880         Rubber-stamped by Adam Roben.
2881
2882         Rolled out r27326 - debug CRT seems to cause no problems after all.
2883
2884         * DumpRenderTree/win/DumpRenderTree.vcproj:
2885
2886 2007-10-31  Adam Roben  <aroben@apple.com>
2887
2888         Switch the Debug configuration to using the non-debug CRT
2889
2890         This matches WebKit.
2891
2892         Reviewed by Steve.
2893
2894         * DumpRenderTree/win/DumpRenderTree.vcproj:
2895
2896 2007-10-31  Antti Koivisto  <antti@apple.com>
2897
2898         Reviewed by bdash.
2899         
2900         Disable media tests when doing leak checking on Tiger.
2901         They crash in QuickTime (rdar://problem/5537157).
2902
2903         * Scripts/run-webkit-tests:
2904
2905 2007-10-29  Antti Koivisto  <antti@apple.com>
2906
2907         Reviewed by Maciej.
2908         
2909         Build media support by default on OSX only.
2910
2911         * Scripts/build-webkit:
2912
2913 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2914
2915         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2916         get caught by the pre-commit hooks.
2917
2918 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2919
2920         Reviewed by Adam.
2921
2922         - This is a collection of relatively unrelated changes and cleanups
2923         to Drosera to prepare it for interacting with WebKit.  A lot of these
2924         changes are just correcting mistakes, for example removing included
2925         headers that are no longer needed.
2926
2927         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2928         this will be needed by the DebuggerClient.
2929         (DebuggerDocument::server):
2930         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2931         * Drosera/win/DebuggerClient.cpp: 
2932         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2933         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2934         (DebuggerClient::createWebViewWithRequest): Added comment about its
2935         purpose. 
2936         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2937         declarations.
2938         (DebuggerClient::webViewLoaded): Moved.
2939         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2940         file, since this was the only place it was used.
2941         (cfStringToBSTR):
2942         * Drosera/win/Drosera.h: Cleaned up the includes.
2943         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2944         * Drosera/win/HelperFunctions.h: Removed.
2945
2946 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2947
2948         Reviewed by Adam.
2949
2950         - Small cleanup in the ServerConnection class.
2951
2952         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2953         and added an include.
2954         (ServerConnection::currentFrame):
2955         (ServerConnection::getCallerFrame):
2956         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2957         made a pointer into a COMPtr, and cleaned up the includes.
2958
2959 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2960
2961         Reviewed by John Sullivan.
2962         
2963         - Place the Localizable.strings file in mac or win directories
2964           if that location exists.
2965         - Also look for UI_STRING in .c files.
2966
2967         * Scripts/extract-localizable-strings:
2968
2969 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2970
2971         Reviewed by Adam.
2972
2973         - Set the eol-style to native and made all the line endings the same
2974         so that I avoid messy diffs that show eol changes.
2975
2976         * Drosera/win/ServerConnection.cpp:
2977         (ServerConnection::didParseSource):
2978         (ServerConnection::didEnterCallFrame):
2979         (ServerConnection::willExecuteStatement):
2980         (ServerConnection::willLeaveCallFrame):
2981         (ServerConnection::exceptionWasRaised):
2982
2983 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2984
2985         Reviewed by Adam.
2986
2987         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2988         functionality that could not have existed previously without the new
2989         interfaces.
2990         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2991         from a BSTR to a JSValueRef.
2992         (DebuggerDocument::platformEvaluateScript): Implemented.
2993         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2994         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2995         Implemented.
2996         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2997         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2998         * Drosera/win/ServerConnection.cpp: Added a helper function.
2999         (ServerConnection::getCallerFrame):
3000         * Drosera/win/ServerConnection.h: Added a helper function.
3001
3002 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3003
3004         updated reviewers for my previous changelog.
3005
3006 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3007         Reviewed by Maciej and Adam and Geoff.
3008
3009         - Minor mac-side improvements including moving a function to a more
3010         appropriate location, fixing a warning, and correctly checking
3011         exceptions.
3012
3013         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3014         (DebuggerDocument::willExecuteStatement):
3015         (DebuggerDocument::didEnterCallFrame):
3016         (DebuggerDocument::willLeaveCallFrame):
3017         (DebuggerDocument::windowScriptObjectAvailable):
3018         (DebuggerDocument::callFunctionOnObject):
3019         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3020         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3021         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3022         because it doesn't require the ServerConnection at all.
3023         (NSStringCreateWithJSStringRef): Made an argument const.
3024         (JSValueRefCreateWithNSString): Made an argument const.
3025         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3026         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3027         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3028         * Drosera/mac/ServerConnection.mm: Ditto.
3029         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3030
3031 2007-10-29  Sam Weinig  <sam@webkit.org>
3032
3033         Reviewed by Adam Roben.
3034
3035         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3036
3037         * DumpRenderTree/LayoutTestController.cpp:
3038         (LayoutTestController::LayoutTestController):
3039         (getGlobalFlagCallback):
3040         (setGlobalFlagCallback):
3041         (LayoutTestController::getJSClass):
3042         (LayoutTestController::staticValues):
3043         * DumpRenderTree/LayoutTestController.h:
3044         (LayoutTestController::globalFlag):
3045         (LayoutTestController::setGlobalFlag):
3046
3047 2007-10-29  Darin Adler  <darin@apple.com>
3048
3049         Reviewed by Maciej.
3050
3051         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3052         resolution instead of its default.
3053
3054 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3055
3056         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3057
3058         Reviewed by Mark Rowe.
3059
3060         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3061         was successfully resolved, but this would not show any status because the change had
3062         already been cached in the index using "git add".  The solution is to add an optional
3063         second argument to showStatus() which adds the "--cached" switch to the command.
3064
3065         * Scripts/resolve-ChangeLogs:
3066         (showStatus):
3067
3068 2007-10-28  Eric Seidel  <eric@webkit.org>
3069
3070         Reviewed by Maciej and Geoff, in unison.
3071
3072         * Scripts/run-webkit-tests: remove broken --svg option
3073
3074 2007-10-28  Darin Adler  <darin@apple.com>
3075
3076         Reviewed by Adam.
3077
3078         * Scripts/run-sunspider: Default to "Release" configuration rather than
3079         defaulting to the last configuration used as other scripts do. This can
3080         still be overriden on the command line with "--debug" if there's some
3081         reason to do so. Also fix a typo.
3082
3083         * Scripts/sunspider-compare-results: Fix a typo.
3084
3085 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3086
3087         Reviewed by Adam.
3088
3089         - Implemented the WebScriptDebugListener functions now that the
3090         WebScriptDebugServer exists
3091
3092         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3093         functions.
3094         (ServerConnection::currentFrame):
3095         (ServerConnection::didLoadMainResourceForDataSource):
3096         (ServerConnection::didParseSource):
3097         (ServerConnection::failedToParseSource):
3098         (ServerConnection::didEnterCallFrame):
3099         (ServerConnection::willExecuteStatement):
3100         (ServerConnection::willLeaveCallFrame):
3101         (ServerConnection::exceptionWasRaised):
3102         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3103         members arguments list.
3104
3105 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3106
3107         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3108         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3109
3110         Reviewed by Darin.
3111
3112         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3113         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3114         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3115         file.  Note that it may also be used as a stand-alone script.
3116
3117         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3118         * Scripts/resolve-ChangeLogs: Added.
3119         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3120
3121 2007-10-26  Mark Rowe  <mrowe@apple.com>
3122
3123         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3124         to the Qt port on the assumption that it was an implementation of the cross-platform
3125         LayoutTestController class.  It is not, so it did not need to be changed.
3126
3127         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3128
3129 2007-10-25  Mark Rowe  <mrowe@apple.com>
3130
3131         Reviewed by Maciej.
3132
3133         Fix builds with code coverage enabled.
3134
3135         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3136
3137 2007-10-25  Darin Adler  <darin@apple.com>
3138
3139         Reviewed by Mark Rowe.
3140
3141         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3142         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3143
3144 2007-10-25  Stephanie  <slewis@apple.com>
3145
3146         build Fix
3147
3148         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3149
3150 2007-10-25  Stephanie  <slewis@apple.com>
3151
3152         Reviewed by Mark Rowe, Adam Roben.
3153
3154         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3155
3156         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
3157
3158 2007-10-25  Alice Liu  <alice.liu@apple.com>
3159
3160         Reviewed by Adam.
3161
3162         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3163
3164         Moving destructor into platform-specific files
3165         * DumpRenderTree/LayoutTestController.cpp:
3166         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3167         (LayoutTestController::~LayoutTestController):
3168         * DumpRenderTree/qt/jsobjects.cpp:
3169         (LayoutTestController::~LayoutTestController):
3170
3171         LayoutTestController wasn't being destroyed
3172         * DumpRenderTree/win/DumpRenderTree.cpp:
3173         (runTest):
3174
3175         Added declspec
3176         * DumpRenderTree/win/EditingDelegate.h:
3177
3178         Reset certain values on the webview (or related delegate) that might 
3179         have changed while running a test
3180         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3181         (LayoutTestController::~LayoutTestController):
3182
3183 2007-10-25  Adam Roben  <aroben@apple.com>
3184
3185         Make sunspider-compare-results work with relative paths
3186
3187         Reviewed by Sam.
3188
3189         * Scripts/sunspider-compare-results: Convert arguments to absolute
3190         paths before we chdir.
3191
3192 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3193
3194         Reviewed by Sam.
3195
3196         - Implemented server calls now the WebScriptDebugServer exists.
3197         - Also removed no longer needed call to initialize CG.
3198
3199         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3200         automatically now.
3201         (_tWinMain):
3202         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3203         (ServerConnection::ServerConnection):
3204         (ServerConnection::~ServerConnection):
3205         (ServerConnection::pause):
3206         (ServerConnection::resume):
3207         (ServerConnection::stepInto):
3208         (ServerConnection::applicationTerminating):
3209         (ServerConnection::serverConnectionDidDie):
3210         * Drosera/win/ServerConnection.h: Now uses the COM class.
3211
3212 2007-10-24  George Staikos  <staikos@kde.org>
3213
3214         Unbreak Qt build.
3215
3216         * Scripts/build-webkit:
3217
3218 2007-10-24  Adam Roben  <aroben@apple.com>
3219
3220         Remove now-unnecessary call to InitializeCoreGraphics
3221
3222         WebKit takes care of this now.
3223
3224         Reviewed by Ada.
3225
3226         * DumpRenderTree/win/DumpRenderTree.cpp:
3227         (initialize):
3228
3229 2007-10-24  Adam Roben  <aroben@apple.com>
3230
3231         Use WebTextRenderer in DRT
3232
3233         Reviewed by Ada.
3234
3235         * DumpRenderTree/win/DumpRenderTree.cpp:
3236         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3237
3238 2007-10-24  Sven Herzberg  <sven@imendio.com>
3239
3240         Reviewed by Mark Rowe.
3241
3242         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3243         Bug 15614: [GTK] qmake based backends don't build on OS X
3244
3245         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3246         GTK backend on a Mac
3247         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3248         isDarwin() to make it reusable in other places (like the workaround-
3249         for-prebuilt-qmake in build-webkit)
3250
3251 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3252
3253         Refurbish update-webkit script.
3254
3255         Reviewed by Adam.
3256
3257         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3258         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3259         multi-argument version of system() for flexibility and security.  Check for existence
3260         of Internal directory using -d test instead of -x.
3261
3262 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3263
3264         Minor clean-up of prepare-ChangeLog script.
3265
3266         Reviewed by Adam.
3267
3268         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3269         of a string.  Use multi-argument versions of open() and system() for flexibility and
3270         security.
3271
3272 2007-10-24  Alice Liu  <alice.liu@apple.com>
3273
3274         Reviewed by Oliver.
3275
3276         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3277
3278         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
3279         replay the saved events when we're still processing the mousedown that starts the drag
3280         * DumpRenderTree/win/EventSender.cpp:
3281         (doMouseMove):
3282         * DumpRenderTree/win/UIDelegate.cpp:
3283         (UIDelegate::doDragDrop):
3284
3285 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3286
3287         Reviewed by Sam, Steve and Darin.
3288
3289         - Stubbed out the WebScriptDebugListener functionality in the Server
3290         Connection class to prepare it for receiving those callbacks.
3291         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
3292         and the ServerConnection to not need to be initialized with a server
3293         name, since that is not the way we connect to the WebKit server. 
3294
3295         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
3296         no exception.  Now it only loggs when there is an exception
3297         (DebuggerDocument::willExecuteStatement):
3298         (DebuggerDocument::didEnterCallFrame):
3299         (DebuggerDocument::willLeaveCallFrame):
3300         (DebuggerDocument::windowScriptObjectAvailable):
3301         (DebuggerDocument::callFunctionOnObject):
3302         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
3303         to be instantiated with a server's name.
3304         (DebuggerClient::DebuggerClient):
3305         (DebuggerClient::didFinishLoadForFrame):
3306         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3307         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3308         a server name.
3309         (Drosera::init):
3310         (Drosera::initServer):
3311         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3312         instantiated with a server's name.
3313         * Drosera/win/ServerConnection.cpp: 
3314         (ServerConnection::ServerConnection): No longer needs a server name
3315         (ServerConnection::~ServerConnection): Only release the global context
3316         if there is one.
3317         (ServerConnection::serverConnectionDidDie): Stub for
3318         IWebScriptDebugListener
3319         (ServerConnection::QueryInterface): ditto
3320         (ServerConnection::AddRef): ditto
3321         (ServerConnection::Release): ditto
3322         (ServerConnection::didLoadMainResourceForDataSource): ditto
3323         (ServerConnection::didParseSource): ditto
3324         (ServerConnection::failedToParseSource): ditto
3325         (ServerConnection::didEnterCallFrame): ditto
3326         (ServerConnection::willExecuteStatement): ditto
3327         (ServerConnection::willLeaveCallFrame): ditto
3328         (ServerConnection::exceptionWasRaised): ditto
3329         * Drosera/win/ServerConnection.h: Stubbed out the
3330         IWebScriptDebugListener functions, and this class no longer needs to be
3331         instantiated with a server name.
3332
3333 2007-10-24  Lars Knoll  <lars@trolltech.com>
3334
3335         Reviewed by Simon.
3336
3337         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3338
3339         * DumpRenderTree/qt/jsobjects.h:
3340
3341 2007-10-24  Lars Knoll  <lars@trolltech.com>
3342
3343         Reviewed by Simon.
3344
3345         add another command.
3346
3347         * DumpRenderTree/qt/jsobjects.cpp:
3348         (TextInputController::doCommand):
3349
3350 2007-10-24  Lars Knoll  <lars@trolltech.com>
3351
3352         Reviewed by Simon.
3353
3354         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3355
3356         * DumpRenderTree/qt/jsobjects.cpp:
3357         (EventSender::keyDown):
3358         * DumpRenderTree/qt/jsobjects.h:
3359
3360 2007-10-24  Lars Knoll  <lars@trolltech.com>
3361
3362         Reviewed by Simon.
3363
3364         implement eventSender.keyDown().
3365
3366         * DumpRenderTree/qt/jsobjects.cpp:
3367         (EventSender::keyDown):
3368
3369 2007-10-24  Lars Knoll  <lars@trolltech.com>
3370
3371         Reviewed by Simon.
3372
3373         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3374
3375         * DumpRenderTree/qt/DumpRenderTree.cpp:
3376         (WebCore::DumpRenderTree::DumpRenderTree):
3377         (WebCore::DumpRenderTree::initJSObjects):
3378         * DumpRenderTree/qt/jsobjects.cpp:
3379         (TextInputController::doCommand):
3380
3381 2007-10-24  Lars Knoll  <lars@trolltech.com>
3382
3383         Reviewed by Simon.
3384
3385         first bit of implementation for the textinputcontroller.
3386
3387         * DumpRenderTree/qt/DumpRenderTree.cpp:
3388         (WebCore::DumpRenderTree::DumpRenderTree):
3389         * DumpRenderTree/qt/DumpRenderTree.h:
3390         * DumpRenderTree/qt/jsobjects.cpp:
3391         (TextInputController::TextInputController):
3392         (TextInputController::doCommand):
3393         * DumpRenderTree/qt/jsobjects.h:
3394
3395 2007-10-24  Lars Knoll  <lars@trolltech.com>
3396
3397         Reviewed by Simon.
3398
3399         make the man webpage believe it has focus, so the editing tests work correctly.
3400
3401         * DumpRenderTree/qt/DumpRenderTree.cpp:
3402         (WebCore::DumpRenderTree::DumpRenderTree):
3403
3404 2007-10-24  Lars Knoll  <lars@trolltech.com>
3405
3406         Reviewed by Simon.
3407
3408         implement layoutTestController.dumpEditingCallbacks() correctly.
3409
3410         * DumpRenderTree/qt/DumpRenderTree.cpp:
3411         (WebCore::DumpRenderTree::DumpRenderTree):
3412         * DumpRenderTree/qt/jsobjects.cpp:
3413         (LayoutTestController::reset):
3414         (LayoutTestController::dumpEditingCallbacks):
3415
3416 2007-10-24  Lars Knoll  <lars@trolltech.com>
3417
3418         Reviewed by Simon.
3419
3420         Implement support for testing editing.
3421
3422         * DumpRenderTree/qt/DumpRenderTree.cpp:
3423         (WebCore::DumpRenderTree::DumpRenderTree):
3424
3425 2007-10-23  Sam Weinig  <sam@webkit.org>
3426
3427         Check for null BSTR that can be passed to the UIDelegate methods
3428         from javascript null and undefined.  Fixes a failing test case on
3429         Windows (fast/dom/Window/alert-undefined.html)
3430
3431         Reviewed by Eric Seidel.
3432
3433         * DumpRenderTree/win/UIDelegate.cpp:
3434         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3435         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3436         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3437         (UIDelegate::webViewAddMessageToConsole):
3438
3439 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3440
3441         Reviewed by Darin.
3442         
3443         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3444
3445         * Scripts/build-testkjs:
3446
3447 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3448
3449         Reviewed by Darin.
3450
3451         - add wrapper that finds the right copy of testkjs
3452         
3453         * Scripts/sunspider-compare-results: Added.
3454
3455 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3456
3457         Reviewed by Sam.
3458
3459         - After talking with Steve I now see that the WebKit server must be
3460         running for DCOM to create the distributed objects, which makes sense
3461         and currently WebKit only allows one instance to be running at a time
3462         which avoids accidentally connecting to the wrong server
3463         - In light of this I have removed the code for the attach box and
3464         NotificationServer and known server names, since they are all extranious
3465         now.
3466
3467         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3468         names.
3469         (_tWinMain): Uses init instead of initUI.
3470         (droseraWndProc): No longer creats an attach dialog box.
3471         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3472         it's not manditory to call init before doing COM stuff.
3473         (Drosera::init): calls initUI and will call attach when the
3474         functionality exists. 
3475         (Drosera::initUI): Has changed very little.
3476         (Drosera::attach): Changed the signature to reflect that we no longer
3477         need the dictionary of known server names.
3478         * Drosera/win/Drosera.h: Removed notification classes and known server
3479         names.  Also renamed and moved some functions.
3480         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3481         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3482         headers to the resources folder. 
3483         * Drosera/win/resource.h: Removed the Attach box.
3484
3485 2007-10-22  Adam Roben  <aroben@apple.com>
3486
3487         Windows build fix
3488
3489         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3490
3491 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3492
3493         - Removed a leak that was fixed.
3494
3495         * Scripts/run-webkit-tests:
3496
3497 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3498
3499         Reviewed by Darin.
3500
3501         - Changed the Client so that the DebuggerDocument now own the
3502         ServerConnection.  This simplifies ownership and cleanup. 
3503
3504         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3505         ServerConnection.
3506         (DebuggerClient::initWithServerName):
3507         (DebuggerClient::didFinishLoadForFrame):
3508         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
3509         ServerConnection.
3510         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
3511         until after we have a server which we are attached to.
3512         (Drosera::initUI):
3513         (Drosera::attach):
3514         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
3515         out previously.
3516
3517 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3518
3519         Reviewed by Nikolas.
3520
3521         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
3522
3523         * Scripts/run-javascriptcore-tests:
3524
3525 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3526
3527         Reviewed by Nikolas.
3528
3529         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
3530
3531         * Scripts/build-drosera:
3532         * Scripts/build-dumprendertree:
3533         * Scripts/build-testkjs:
3534         * Scripts/build-webkit:
3535         * Scripts/run-javascriptcore-tests:
3536         * Scripts/run-sunspider:
3537         * Scripts/run-webkit-tests:
3538         * Scripts/webkitdirs.pm:
3539
3540 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
3541
3542         Reviewed by Mark Rowe.
3543         
3544         Fix for local database support after r26879
3545         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
3546
3547         * Scripts/build-webkit:
3548
3549 2007-10-22  Holger Freyther  <zecke@selfish.org>
3550
3551         Reviewed by Simon Hausmann <hausmann@kde.org>.
3552
3553         - Do not build testkjs as an application bundle. This is
3554         needed for run-javascriptcore-tests on OSX.
3555         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
3556         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
3557         as we do not have -rpath on OSX.
3558
3559         * DumpRenderTree/qt/DumpRenderTree.pro:
3560         * Scripts/run-webkit-tests:
3561
3562 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3563
3564         Reviewed by aroben.
3565
3566         Fix support for Signed-off-by detection in prepare-ChangeLog
3567         --git-commit. The Signed-off-by tag does not appear in the header
3568         but usually at the end.
3569
3570         * Scripts/prepare-ChangeLog:
3571
3572 2007-10-21  Mark Rowe  <mrowe@apple.com>
3573
3574         Reviewed by Eric.
3575
3576         Fix run-javascriptcore-tests for Gtk.
3577
3578         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
3579
3580 2007-10-20  Eric Seidel  <eric@webkit.org>
3581
3582         Reviewed by aroben.
3583
3584         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
3585
3586 2007-10-20  Eric Seidel  <eric@webkit.org>
3587
3588         Reviewed by darin.
3589         
3590         Add improved argument handling to run-sunspider, including
3591         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
3592         Also re-factor code into subroutines
3593
3594         * Scripts/build-dumprendertree: removed bogus comments
3595         * Scripts/build-testkjs: Added.
3596         * Scripts/run-javascriptcore-tests: use build-testkjs
3597         * Scripts/run-sunspider: improved argument handling, abstraction
3598         * Scripts/run-webkit-tests: improved abstraction
3599
3600 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
3601
3602         Not reviewed, Windows build fix.
3603
3604         * DumpRenderTree/win/EventSender.cpp:
3605         (keyDownCallback):
3606
3607 2007-10-20  Darin Adler  <darin@apple.com>
3608
3609         Reviewed by Tim Hatcher.
3610
3611         - http://bugs.webkit.org/show_bug.cgi?id=15544
3612           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
3613           not rely on Apple-specific key codes
3614
3615         * DumpRenderTree/mac/EventSendingController.mm:
3616         (-[EventSendingController keyDown:withModifiers:]):
3617         Added named key "rightArrow". Later we could have a whole table of these.
3618         Also tweaked modifiers code a little.
3619
3620         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
3621
3622 2007-10-19  Darin Adler  <darin@apple.com>
3623
3624         Reviewed by Eric.
3625
3626         - http://bugs.webkit.org/show_bug.cgi?id=15566
3627           possible fix for leak seen in DumpRenderTree
3628
3629         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
3630         Delete the item if it's not put on the queue, since the caller has
3631         no way of knowing that. Would be better to have the parameter type
3632         be auto_ptr to express the fact that we take ownership.
3633
3634         - unrelated change
3635
3636         * Drosera/mac/main.m: Add missing include.
3637
3638 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3639
3640         Reviewed by Adam.
3641
3642         - This change should be identical but for some reason was not working
3643         on my machine.
3644
3645         * Scripts/prepare-ChangeLog:
3646
3647 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3648
3649         Reviewed by Oliver and Tim.
3650
3651         - Made use of RetainPtr to avoid retain and release issues and moved the
3652         log function to DebuggerDocumentPlatform, which seems to be a more
3653         logical place for it to live.
3654         - Also moved knownServers from the ServerConnection to
3655         DebuggerApplication to match the Windows code and because it makes sense
3656         that a connection knows its own server but not all of them.
3657
3658         * Drosera/mac/DebuggerClient.h: Moved the log function to
3659