.:
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
2
3         Rubber-stamped by Darin.
4
5         * GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
6
7 2008-02-23  David Kilzer  <ddkilzer@apple.com>
8
9         Please clarify licensing for some files
10         <http://bugs.webkit.org/show_bug.cgi?id=14970>
11
12         Reviewed by Darin.
13
14         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Added
15         copyright statement.  Replaced license with newer Apple BSD-style license.
16         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Ditto.
17         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Ditto.
18         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Ditto.
19         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Ditto.
20         * DumpRenderTree/win/TestNetscapePlugin/main.c: Ditto.
21         * mangleme/LICENSE: Added (LGPL).
22
23 2008-02-22  Anders Carlsson  <andersca@apple.com>
24
25         Reviewed by Adam.
26
27         <rdar://problem/5748781> 
28         https://bugs.webkit.org/show_bug.cgi?id=17413
29         REGRESSION: Latest Nightly doesn't load Java plugin w/Safari 3.1b
30         
31         Copy the Java plug-in over to the new location.
32         
33         * FindSafari/FindSafari.cpp:
34         (_tmain):
35
36 2008-02-22  Anders Carlsson  <andersca@apple.com>
37
38         Reviewed by Adam.
39
40         <rdar://problem/5747325> REGRESSION: HTTP layout tests hang
41         
42         * DumpRenderTree/win/DumpRenderTree.cpp:
43         (runTest):
44         Init the URL request with the correct timeout.
45
46 2008-02-21  Mike Auty  <mike.auty@gmail.com>
47
48         Reviewed by Alp Toker.
49
50         http://bugs.webkit.org/show_bug.cgi?id=17445
51         [GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed"
52
53         GTK+/autotools build system improvements
54
55         The GNUmakefile.am files make use of the LDFLAGS variable to include library
56         additions such as -ljpeg etc.  Unfortunately, if these inclusions aren't made
57         in LIBADD/LDADD variables, then they are mis-ordered during the linking.
58
59         The as-needed flag discards libraries whose functions have not been needed by
60         earlier libraries, which therefore makes the ordering important.
61
62         This moves all -l library inclusion statements from LDFLAGS variables to
63         LIBADD/LDADD variables.
64
65         * GNUmakefile.am:
66
67 2008-02-20  Brent Fulgham  <bfulgham@gmail.com>
68
69         Reviewed by Alp.
70
71         - http://bugs.webkit.org/show_bug.cgi?id=17428
72           Reenable a Windows-based launcher
73
74         This patch reenables the venerable Spinneret application,
75         changing its name to match the other lanch applications.
76
77         * WinLauncher: Added.
78         * WinLauncher/WinLauncher.cpp: Added.
79         (WinLauncherWebHost::updateAddressBar):
80         (WinLauncherWebHost::QueryInterface):
81         (WinLauncherWebHost::AddRef):
82         (WinLauncherWebHost::Release):
83         (resizeSubViews):
84         (_tWinMain):
85         (MyRegisterClass):
86         (InitInstance):
87         (WndProc):
88         (MyEditProc):
89         (About):
90         (loadURL):
91         * WinLauncher/WinLauncher.h: Added.
92         (WinLauncherWebHost::WinLauncherWebHost):
93         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
94         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
95         (WinLauncherWebHost::didFailProvisionalLoadWithError):
96         (WinLauncherWebHost::didCommitLoadForFrame):
97         (WinLauncherWebHost::didReceiveTitle):
98         (WinLauncherWebHost::didReceiveIcon):
99         (WinLauncherWebHost::didFinishLoadForFrame):
100         (WinLauncherWebHost::didFailLoadWithError):
101         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
102         (WinLauncherWebHost::willPerformClientRedirectToURL):
103         (WinLauncherWebHost::didCancelClientRedirectForFrame):
104         (WinLauncherWebHost::willCloseFrame):
105         (WinLauncherWebHost::windowScriptObjectAvailable):
106         * WinLauncher/WinLauncher.ico: Added.
107         * WinLauncher/WinLauncher.rc: Added.
108         * WinLauncher/WinLauncher.vcproj: Added.
109         * WinLauncher/resource.h: Added.
110         * WinLauncher/small.ico: Added.
111         * WinLauncher/stdafx.cpp: Added.
112         * WinLauncher/stdafx.h: Added.
113
114 2008-02-19  Brady Eidson  <beidson@apple.com>
115
116         Reviewed by Geoff
117
118         Fixed a bug in DRT --threaded mode
119
120         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
121         (startJavaScriptThreads): Don't detach the newly created thread.  The later call to stopJavaScriptThreads() tries
122           to pthread_join() each thread that had been created, but you can't join a detached thread!
123
124 2008-02-18  Brady Eidson  <beidson@apple.com>
125
126         Changes by Geoff Garen, Reviewed by Darin
127
128         Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
129
130         DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html
131
132         [WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
133         This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread.  If the lock has leaked,
134         this series of method calls will deadlock.  If things are good, it will complete successfully.
135
136         * DumpRenderTree/mac/ObjCController.m:
137         (runJavaScriptThread):
138         (+[ObjCController isSelectorExcludedFromWebScript:]):
139         (+[ObjCController webScriptNameForSelector:]):
140         (-[ObjCController testValueForKey]):
141
142 2008-02-18  Matt Lilek  <webkit@mattlilek.com>
143
144         Reviewed by Adam.
145
146         Remove FindSafari's Release configuration.
147
148         * FindSafari/FindSafari.vcproj:
149
150 2008-02-15  Adam Roben  <aroben@apple.com>
151
152         Fix a typo that broke the Mac build
153
154         Reviewed by Mark.
155
156         * Scripts/build-webkit:
157
158 2008-02-14  Adam Roben  <aroben@apple.com>
159
160         Turn on cross-document messaging support by default
161
162         Reviewed by Darin.
163
164         * Scripts/build-webkit:
165
166 2008-02-14  Adam Roben  <aroben@apple.com>
167
168         Conditionalize cross-document messaging support
169
170         The cross-document messaging parts of HTML 5 are in flux and we want
171         ports to be able to turn off the support as needed.
172
173         Note that the support is turned off by default right now. A subsequent
174         commit will turn it on by default.
175
176         Reviewed by Darin.
177
178         * Scripts/build-webkit:
179
180 2008-02-14  Darin Adler  <darin@apple.com>
181
182        - fix Windows build
183
184         * DumpRenderTree/win/UIDelegate.cpp:
185         (UIDelegate::setStatusText): Update parameter types to match declaration.
186
187 2008-02-14  Oliver Hunt  <oliver@apple.com>
188
189         Reviewed by Geoff G and Weinig.
190
191         Add ability for DRT to report tests setting the status text.
192
193         * DumpRenderTree/LayoutTestController.cpp:
194         (LayoutTestController::LayoutTestController):
195         (dumpStatusCallbacksCallback):
196         (LayoutTestController::staticFunctions):
197         * DumpRenderTree/LayoutTestController.h:
198         * DumpRenderTree/mac/UIDelegate.mm:
199         (-[UIDelegate webView:setStatusText:]):
200         * DumpRenderTree/win/UIDelegate.cpp:
201         * DumpRenderTree/win/UIDelegate.h:
202
203 2008-02-13  Adam Roben  <aroben@apple.com>
204
205         Windows build fix
206
207         * DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.
208
209 2008-02-13  Adam Roben  <aroben@apple.com>
210
211         Windows/GTK+ build fix
212
213         * DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to
214         get isnan.
215
216 2008-02-13  Brady Eidson  <beidson@apple.com>
217
218         Reviewed by Darin Adler
219
220         Add some much needed Database support to DRT
221
222         * DumpRenderTree/LayoutTestController.cpp:
223         (LayoutTestController::LayoutTestController):
224         (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to
225           databases are called
226         (clearAllDatabasesCallback): Allow a test to delete all databases
227         (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get
228         (LayoutTestController::staticFunctions):
229
230         * DumpRenderTree/LayoutTestController.h:
231         (LayoutTestController::dumpDatabaseCallbacks):
232         (LayoutTestController::setDumpDatabaseCallbacks):
233
234         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
235         (LayoutTestController::clearAllDatabases):
236         (LayoutTestController::setDatabaseQuota):
237
238         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
239         (LayoutTestController::clearAllDatabases): Stubbed out
240         (LayoutTestController::setDatabaseQuota): Ditto
241         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
242         (LayoutTestController::clearAllDatabases): Stubbed out with error message
243         (LayoutTestController::setDatabaseQuota): Ditto
244
245         * DumpRenderTree/mac/UIDelegate.mm:
246         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a
247           message with details about the event then return a 5mb quota like before
248
249
250 2008-02-12  Steve Falkenburg  <sfalken@apple.com>
251
252         Changes to support merged MIDL output.
253
254         All COM interfaces are now generated to WebKit.h.
255
256         Reviewed by Sam, Ada.
257
258         * Drosera/win/BaseDelegate.h:
259         * Drosera/win/DebuggerClient.cpp:
260         * Drosera/win/DebuggerDocumentPlatform.cpp:
261         * Drosera/win/Drosera.cpp:
262         * Drosera/win/ServerConnection.cpp:
263         * Drosera/win/ServerConnection.h:
264         * DumpRenderTree/win/DumpRenderTree.cpp:
265         * DumpRenderTree/win/EditingDelegate.h:
266         * DumpRenderTree/win/EventSender.cpp:
267         * DumpRenderTree/win/FrameLoadDelegate.cpp:
268         * DumpRenderTree/win/FrameLoadDelegate.h:
269         * DumpRenderTree/win/GCControllerWin.cpp:
270         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
271         * DumpRenderTree/win/PolicyDelegate.h:
272         * DumpRenderTree/win/ResourceLoadDelegate.h:
273         * DumpRenderTree/win/UIDelegate.cpp:
274         * DumpRenderTree/win/UIDelegate.h:
275         * DumpRenderTree/win/WorkQueueItemWin.cpp:
276
277 2008-02-10  Dan Bernstein  <mitz@apple.com>
278
279         Reviewed by Oliver Hunt.
280
281         - fix a memory leak
282
283         * DumpRenderTree/cg/ImageDiffCG.cpp:
284         (getDifferenceBitmap): Use a static CFMutableData instead of allocating
285         and leaking the buffer each time.
286
287 2008-02-07  Adam Roben  <aroben@apple.com>
288
289         Fix error in bisect-builds when responding "broken" for the first
290         build
291
292         Reviewed by Dave Kilzer.
293
294         * Scripts/bisect-builds: Only try to test the build if the nightly
295         info for the current index has not been deleted.
296
297 2008-02-07  Geoffrey Garen  <ggaren@apple.com>
298
299         Reviewed by Alexey Proskuryakov.
300
301         Fixed two minor typos in the --root option, to get it working.
302
303         * Scripts/run-sunspider:
304             1. Actually assign the function argument to our local variable.
305             2. Actually set the $root variable, so we don't try to build later.
306
307 2008-02-05  Oliver Hunt  <oliver@apple.com>
308
309         RS=Eric.
310
311         Re-enable foreignObject by default as it is needed for a number of non-fO
312         related SVG tests and none of the old known crashes occur anymore.
313
314         * Scripts/build-webkit:
315
316 2008-02-05  Steve Falkenburg  <sfalken@apple.com>
317
318         Build fix.  Don't override intermediate directory.
319
320         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
321
322 2008-02-05  Holger Hans Peter Freyther  <zecke@selfish.org>
323
324         Build fix for Windows. willCloseFrame is a pure virtual and we are
325         forced to have an implementation.
326         
327         This partially reverts r30014.
328
329         * DumpRenderTree/win/FrameLoadDelegate.cpp:
330         (FrameLoadDelegate::willCloseFrame):
331         * DumpRenderTree/win/FrameLoadDelegate.h:
332
333 2008-02-05  Nikolas Zimmermann  <zimmermann@kde.org>
334
335         Reviewed by Holger.
336
337         Don't build wrapper for SVGTestCase.js (special file for svg/dynamic-updates)
338
339         * Scripts/make-js-test-wrappers:
340
341 2008-02-05  Holger Freyther  <zecke@selfish.org>
342
343         Reviewed by Darin.
344
345         In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
346         the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
347         depends on the order the tests are executed.
348         
349         Propose to remove willCloseFrame and didlCearWindowObject output from the
350         FrameLoadDelegate and update the test results. The output of didClearWindowObject
351         is not interesting for any of the current tests and we have other ways to find
352         out if a frame was closed or not.
353
354         * DumpRenderTree/mac/FrameLoadDelegate.mm:
355         * DumpRenderTree/win/FrameLoadDelegate.cpp:
356         (FrameLoadDelegate::didClearWindowObject):
357         * DumpRenderTree/win/FrameLoadDelegate.h:
358
359 2008-02-04  Mark Rowe  <mrowe@apple.com>
360
361         Reviewed by Oliver Hunt.
362
363         Workaround for http://bugs.webkit.org/show_bug.cgi?id=16842
364         Bug 16842: Hang in DRT in leaks mode due to signal handler doing unsafe things
365
366         Don't install the signal handler unless we are running the pixel tests.
367         It is currently only used to restore the color profile, but by catching
368         signals we can trigger a deadlock in DRT while running leak tests.
369         The deadlock is tracked by http://bugs.webkit.org/show_bug.cgi?id=16842,
370         and a more complete fix will need to be developed to address this for
371         pixel tests as well.
372
373         * DumpRenderTree/mac/DumpRenderTree.mm:
374         (dumpRenderTree):
375
376 2008-02-04  Mark Rowe  <mrowe@apple.com>
377
378        Gtk qmake build fix.
379
380         * Scripts/webkitdirs.pm:  Fix perl's complaint about an odd number of elements in anonymous hash.
381
382 2008-02-04  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
383
384         Reviewed by Alp Toker and Mark Rowe.
385
386         http://bugs.webkit.org/show_bug.cgi?id=16618
387         [GTK] build-webkit and run-webkit-tests autootools support
388
389         * Scripts/build-webkit: added --database and --icon-database options
390         * Scripts/run-launcher:
391         * Scripts/run-webkit-tests:
392         * Scripts/webkitdirs.pm:
393
394 2008-02-04  Oliver Hunt  <oliver@apple.com>
395
396         Reviewed by Steve F.
397
398         Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT
399
400         Implement required DRT functionality to allow majority of Drag and Drop testcases to work.
401         Issues include:
402           * Uses Sleep() to implement leapForward reliably.
403           * 3 DND tests still fail for reasons that i have not yet determined
404           * Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain 
405
406         * DumpRenderTree/win/EventSender.cpp:
407         (leapForwardCallback):
408         (mouseDownCallback):
409         (doMouseUp):
410         (mouseUpCallback):
411         (doMouseMove):
412         (mouseMoveToCallback):
413           Minor updates to these functions to handle the different message queue structure.
414
415         (replaySavedEvents):
416           More complicated now.  Where possible we just use the old while-loop model of execution,
417           but when leapForward has been used we have to jump through some hoops and set up an 
418           inner event loop so that we can ensure messages get the correct time stamp.
419
420         * DumpRenderTree/win/UIDelegate.cpp:
421         (UIDelegate::doDragDrop):
422           Call replaySavedEvents directly to force synchronous handling of drag and drop.
423
424 2008-02-04  Rodney Dawes  <dobey@wayofthemonkey.com>
425
426         Reviewed by Alp Toker and Mark Rowe.
427
428         Fix http://bugs.webkit.org/show_bug.cgi?id=17175.
429         Bug 17175: Use of C++ compiler flags in CFLAGS
430
431         * GNUmakefile.am: Use global_cxxflags as well as global_cflags in CXXFLAGS.
432
433 2008-02-04  Darin Adler  <darin@apple.com>
434
435         Reviewed by Geoff.
436
437         * Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast
438         and svg subdirectories. Added some more exceptions for the benefit of the fast/dom
439         subdirectory.
440
441 2008-02-04  Adam Roben  <aroben@apple.com>
442
443         Windows Apple-only build fix
444
445         * DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include
446         directory.
447
448 2008-02-04  Alp Toker  <alp@atoker.com>
449
450         Rubber-stamped by Mark Rowe.
451
452         Remove all trailing whitespace in the GTK+ port and related
453         components.
454
455         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
456         * DumpRenderTree/gtk/GCControllerGtk.cpp:
457         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
458         * GNUmakefile.am:
459
460 2008-02-01  Eric Seidel  <eric@webkit.org>
461
462         Reviewed by Oliver.
463
464         Also search LayoutTests/svg for js-based tests.
465
466         * Scripts/make-js-test-wrappers:
467
468 2008-01-31  Alp Toker  <alp@atoker.com>
469
470         Rubber-stamped by Adam Roben.
471
472         http://bugs.webkit.org/show_bug.cgi?id=17006
473         [GTK] Header path should be webkit/webkit.h
474
475         Move the GTK+ API sources as needed and update the build systems.
476
477         * DumpRenderTree/gtk/DumpRenderTree.cpp:
478         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
479         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
480         * GNUmakefile.am:
481         * GtkLauncher/main.c:
482
483 2008-01-30  Stephanie  <slewis@apple.com>
484
485         Reviewed by Geoff.
486
487         Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
488
489         * Scripts/run-webkit-tests:
490
491 2008-01-30  Alexey Proskuryakov  <ap@webkit.org>
492
493         Reviewed by Adam Roben.
494
495         One more debug (external) fix.
496
497         * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
498         and Debug configurations. 
499
500 2008-01-29  Geoffrey Garen  <ggaren@apple.com>
501
502         Reviewed by Sam Weinig. Sam Weinig.
503         
504         Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
505         fails when run after fast/dom/Window/window-property-shadowing.html (16902)
506
507         Modified our policy delegates not to output window.name. Since a
508         previous test may have explicitly set window.name, we can't rely on its
509         implicit value in test results.
510
511         * DumpRenderTree/mac/PolicyDelegate.mm:
512         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
513
514         * DumpRenderTree/win/PolicyDelegate.cpp:
515         (PolicyDelegate::decidePolicyForNavigationAction):
516
517 2008-01-29  Mark Rowe  <mrowe@apple.com>
518
519         Reviewed by Tim Hatcher.
520
521         <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
522
523         * Scripts/build-webkit: Copy SQLite static library and headers into the build directory.
524
525 2008-01-29  David Kilzer  <ddkilzer@apple.com>
526
527         Refactor ChangeLog path code
528
529         Reviewed by Adam.
530
531         * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
532         duplicate code in another foreach() loop.
533
534 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
535
536         Reviewed by Darin.
537
538         <rdar://problem/5710692> All storage tests fail/crash
539
540         * DumpRenderTree/mac/UIDelegate.mm:
541         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an
542         arbitrary quota of 5 megabytes.
543
544         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
545         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
546         Removed unused (I think) code.
547         
548         * DumpRenderTree/win/UIDelegate.cpp:
549         (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported.
550         (UIDelegate::webViewPainted): A stub implementation.
551         (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
552         * DumpRenderTree/win/UIDelegate.h:
553
554 2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
555
556         GTK+ DRT build fix for breakage introduced in r29822.
557
558         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
559         (LayoutTestController::setPersistentUserStyleSheetLocation):
560         (LayoutTestController::clearPersistentUserStyleSheet):
561
562 2008-01-27  Dan Bernstein  <mitz@apple.com>
563
564         Reviewed by Darin Adler.
565
566         - add support for directory prologues and epilogues to run-webkit-tests
567         - allow setting a persistent user style sheet in DumpRenderTree
568         - activate the WebKit Layout Tests font in Windows DumpRenderTree
569
570         * DumpRenderTree/LayoutTestController.cpp:
571         (clearPersistentUserStyleSheetCallback): Added.
572         (setPersistentUserStyleSheetLocationCallback): Added.
573         (LayoutTestController::staticFunctions): Added.
574         clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
575         * DumpRenderTree/LayoutTestController.h:
576         * DumpRenderTree/mac/DumpRenderTree.mm:
577         (setPersistentUserStyleSheetLocation): Added.
578         (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
579         to the set of things this function resets. Now it either disables the
580         user style sheet or sets it to the persistent user style sheet and
581         enables it.
582         * DumpRenderTree/mac/DumpRenderTreeMac.h:
583         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
584         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
585         (LayoutTestController::clearPersistentUserStyleSheet): Added.
586         * DumpRenderTree/win/DumpRenderTree.cpp:
587         (setPersistentUserStyleSheetLocation): Added.
588         (initialize): Added the WebKit Layout Tests font to the set of fonts to
589         install.
590         (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
591         * DumpRenderTree/win/DumpRenderTreeWin.h:
592         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
593         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
594         (LayoutTestController::clearPersistentUserStyleSheet): Added.
595         * Scripts/run-webkit-tests: Changed to look for, and if found process in
596         DumpRenderTree, files named run-webkit-tests-prologue.html and
597         run-webkit-tests-epilogue.html in the resources subdirectory of any
598         test directory and platform test results directory. The prologues are
599         processed before the first test from the directory (and its
600         subdirectories) is run, and the epilogues are processed after the last
601         test from the directory is run. Platform-specific prologues and
602         epilogues are processed in order of specificity.
603
604 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
605
606         Reviewed by Mark Rowe.
607
608         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
609
610         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
611         (matching Mac DRT).
612         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
613
614 2008-01-24  Sam Weinig  <sam@webkit.org>
615
616         Reviewed by Ada Chan.
617
618         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
619
620         - Adds simplified UndoManager to windows DRT to allow testing the
621           undo/redo code paths in WebCore and WebKit.  This is a temporary
622           solution to an issue that should eventually be solved by having a
623           shared UndoManager in WebKit.
624
625         * DumpRenderTree/win/DumpRenderTree.cpp:
626         (runTest):
627         * DumpRenderTree/win/UIDelegate.cpp:
628         (DRTUndoObject::DRTUndoObject):
629         (DRTUndoObject::invoke):
630         (DRTUndoStack::~DRTUndoStack):
631         (DRTUndoStack::isEmpty):
632         (DRTUndoStack::clear):
633         (DRTUndoStack::push):
634         (DRTUndoStack::pop):
635         (DRTUndoManager::canRedo):
636         (DRTUndoManager::canUndo):
637         (DRTUndoManager::DRTUndoManager):
638         (DRTUndoManager::removeAllActions):
639         (DRTUndoManager::registerUndoWithTarget):
640         (DRTUndoManager::redo):
641         (DRTUndoManager::undo):
642         (UIDelegate::UIDelegate):
643         (UIDelegate::resetUndoManager):
644         (UIDelegate::registerUndoWithTarget):
645         (UIDelegate::removeAllActionsWithTarget):
646         (UIDelegate::setActionTitle):
647         (UIDelegate::undo):
648         (UIDelegate::redo):
649         (UIDelegate::canUndo):
650         (UIDelegate::canRedo):
651         * DumpRenderTree/win/UIDelegate.h:
652
653 2008-01-23  Adam Roben  <aroben@apple.com>
654
655         Allow directories containing ChangeLogs to be passed to
656         resolve-ChangeLogs
657
658         Reviewed by David Kilzer.
659
660         * Scripts/resolve-ChangeLogs:
661         (sub findChangeLog): Return a ChangeLog contained within the specified
662         directory if one exists.
663
664 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
665
666         <rdar://problem/5698732> Copyright strings should include 2008
667
668         Reviewed by Sam.
669
670         * Drosera/win/Drosera.vcproj/Drosera.rc:
671         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
672
673 2008-01-23  Alp Toker  <alp@atoker.com>
674
675         Rubber-stamped by Mark Rowe.
676
677         Remove whitespace after -I in automake include lists.
678
679         * GNUmakefile.am:
680
681 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
682
683         Reviewed by Lars Knoll <lars@trolltech.com>.
684
685         Reworked the JavaScriptCore Qt bindings:
686         
687         * Update JS DRT controller for Qt JS binding changes.
688         There were two functions that needed some changes
689         so that the layout tests would work, so this makes
690         a few tests pass again.
691         
692         * Bump the timeout for layout tests up to 11s.
693         At least some tests have an internal timeout of
694         10 seconds, so make the waitUntilDone approach
695         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
696         is one of these - now the failure message is more
697         accurate.
698         
699
700         * DumpRenderTree/qt/jsobjects.cpp:
701         (LayoutTestController::waitUntilDone):
702         * DumpRenderTree/qt/jsobjects.h:
703
704 2008-01-22  Anders Carlsson  <andersca@apple.com>
705
706         Reviewed by Darin and Adam.
707
708         <rdar://problem/5688975>
709         div element on microsoft site has wrong left offset.
710         
711         Add new method for testing the return vale of NPN_GetProperty.
712         
713         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
714         (pluginInvoke):
715
716 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
717
718         Reviewed by Adam Roben.
719
720         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
721
722         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
723
724 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
725
726         Reviewed by Alp Toker.
727
728         http://bugs.webkit.org/show_bug.cgi?id=16955
729         Get errors when cross-compile webkit-gtk
730
731         * GNUmakefile.am: Removed ICU_CFLAGS 
732
733 2008-01-21  Darin Adler  <darin@apple.com>
734
735         Reviewed by Mitz and Adam.
736
737         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
738         sorting speed by doing all sort criteria in a single pass instead of three sorts.
739
740 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
741
742         Reviewed by Holger.
743
744         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
745         
746         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
747         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
748         and make the return value depend on whether we successfully determined a focusable
749         node or not.
750         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
751         if we could not handle the focus chain ourselves.
752         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
753         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
754         used to control the situation of stepping out of the focus chain inside the page.
755         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
756         The layout tests expect this to be disabled but for the user it seems sensible to have it
757         on by default, hence the default in qwebsettings.cpp
758         
759
760         * DumpRenderTree/qt/DumpRenderTree.cpp:
761         (WebCore::WebPage::WebPage):
762
763 2008-01-19  Mark Rowe  <mrowe@apple.com>
764
765         Reviewed by Alp Toker.
766
767         Allow the --http flag to run-webkit-tests to override
768         the default behaviour of disabling HTTP tests for Qt,
769         Gtk and Wx.
770
771         * Scripts/run-webkit-tests:
772
773 2008-01-19  David Kilzer  <ddkilzer@apple.com>
774
775         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
776
777         Reviewed by Darin.
778
779         We now touch a check-for-global-initializers.timestamp file in
780         the TARGET_TEMP_DIR directory to determine when new object files
781         have been compiled and thus need to be checked.  If the timestamp
782         file doesn't exist, all object files will be checked.
783
784         Previously the modification time of the "executable" (the
785         framework binary, e.g., WebKit.framework/WebKit) was used, but
786         since this was the last file modified at the end of the compile
787         phase, no object files would ever get checked!
788
789         Also added JSCustomSQLTransactionCallback.o to the list of files
790         since it has static initializers in Debug builds of WebCore.
791
792         * Scripts/check-for-global-initializers:
793
794 2008-01-18  Adam Roben  <aroben@apple.com>
795
796         Build fix
797
798         * Scripts/build-webkit:
799
800 2008-01-18  Beth Dakin  <bdakin@apple.com>
801
802         Reviewed by Oliver.
803
804         Update build-webkit to account for foreign-object being disabled by 
805         default.
806
807         * Scripts/build-webkit:
808
809 2008-01-18  Adam Roben  <aroben@apple.com>
810
811         Updated for method renames
812
813         Reviewed by Adele.
814
815         * DumpRenderTree/mac/FrameLoadDelegate.mm:
816         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
817         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
818         (LayoutTestController::setMainFrameIsFirstResponder):
819         (LayoutTestController::setWindowIsKey):
820         * DumpRenderTree/mac/UIDelegate.mm:
821         (-[UIDelegate webViewFocus:]):
822         * DumpRenderTree/win/FrameLoadDelegate.cpp:
823         (FrameLoadDelegate::didCommitLoadForFrame):
824
825 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
826
827         Reviewed by Adam Roben.
828
829         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
830         between DRT and TestNetscapePlugin.
831
832         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
833         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
834
835 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
836
837         Reviewed by Holger.
838
839         Fix fast/dom/Window/window-resize.html
840         
841         In DRT connect the page's geometryChangeRequest signal to a slot that
842         sets the geometry of the view widget.
843         
844
845         * DumpRenderTree/qt/DumpRenderTree.cpp:
846         (WebCore::WebPage::setViewGeometry):
847         (WebCore::WebPage::WebPage):
848
849 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
850
851         Build fix.
852
853         * Drosera/DroseraWin.make:
854
855 2008-01-17  Darin Adler  <darin@apple.com>
856
857         * Scripts/run-webkit-tests: Fixed a bug number.
858
859 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
860
861         Reviewed by Adam Roben.
862
863         http://bugs.webkit.org/show_bug.cgi?id=16908
864         run-webkit-tests complains about missing FindSafari.exe
865
866         * Scripts/webkitdirs.pm: Append _debug as appropriate.
867
868 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
869
870         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
871         
872         Rubber-stamped by Jon Honeycutt.
873
874         * DumpRenderTree/win/DumpRenderTree.vcproj:
875
876 2008-01-16  Alp Toker  <alp@atoker.com>
877
878         Reviewed by Mark Rowe.
879
880         http://bugs.webkit.org/show_bug.cgi?id=16218
881         [GTK] API: Should this entry point be called go_back rather than go_backward?
882
883         Track back/forward API changes in the tools.
884
885         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
886         (BackForwardItem::invoke):
887         * GtkLauncher/main.c:
888         (go_back_cb):
889
890 2008-01-16  Adam Roben  <aroben@apple.com>
891
892         Windows build fix after r29488
893
894         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
895         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
896         expects to find the plugin.
897
898 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
899
900         Reviewed by Sam Weinig.
901         
902         Fixed the waitUntilDone watchdog timer -- the old code never added the
903         timer to the run loop, so it didn't do anything.
904
905         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
906         (LayoutTestController::setWaitToDump):
907         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
908         (LayoutTestController::setWaitToDump):
909
910 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
911
912         Use shared vsprops for most vcproj properties.
913         
914         Reviewed by Darin.
915
916         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
917         * DumpRenderTree/win/DumpRenderTree.vcproj:
918         * DumpRenderTree/win/ImageDiff.vcproj:
919         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
920         * FindSafari/FindSafari.vcproj:
921
922 2008-01-14  Stephanie  <slewis@apple.com>
923
924        Reviewed by NOBODY.
925   
926        revert accidental character.
927
928        * Scripts/run-webkit-tests:
929
930 2008-01-14  Stephanie  <slewis@apple.com>
931
932         RS=Oliver
933
934         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
935
936         * Scripts/run-webkit-tests:
937
938 2008-01-14  Darin Adler  <darin@apple.com>
939
940         * Scripts/do-webcore-rename: Queue up another rename.
941
942 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
943
944         Reviewed by Darin.
945
946         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
947         the tests were ran.
948         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
949
950         * Scripts/run-webkit-tests:
951
952 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
953
954         Reviewed by Darin.
955
956         * Randomize tests array to spot test cases where the results depends on the order
957         the tests are ran.
958         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
959
960         * Scripts/run-webkit-tests:
961
962 2008-01-14  Darin Adler  <darin@apple.com>
963
964         * Scripts/run-webkit-tests: More ignore list tweaking.
965
966 2008-01-14  Darin Adler  <darin@apple.com>
967
968         * Scripts/run-webkit-tests: Add another leak to the ignore list.
969
970 2008-01-14  Dan Bernstein  <mitz@apple.com>
971
972         Reviewed by Adam Roben.
973
974         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
975           build bots
976
977         * DumpRenderTree/win/DumpRenderTree.cpp:
978         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
979
980 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
981
982         Share common files across projects.
983         
984         Unify vsprops files
985         Debug:          common.vsprops, debug.vsprops
986         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
987         Release:        common.vsprops, release.vsprops
988         
989         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
990         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
991
992         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
993
994         Reviewed by Adam Roben.
995
996         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
997         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
998         * Drosera/win/Drosera.vcproj/VERSION: Removed.
999         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
1000         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
1001         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
1002         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
1003         * DumpRenderTree/win/DumpRenderTree.vcproj:
1004         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1005         * DumpRenderTree/win/debug.vsprops: Removed.
1006         * DumpRenderTree/win/debug_internal.vsprops: Removed.
1007         * DumpRenderTree/win/release.vsprops: Removed.
1008
1009 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
1010
1011         Reviewed by Maciej.
1012
1013         - http://bugs.webkit.org/show_bug.cgi?id=16314
1014           Script to launch Drosera
1015
1016         * Scripts/gdb-drosera: Added.
1017         * Scripts/run-drosera: Added.
1018         * Scripts/run-drosera-nightly.cmd: Added.
1019         * Scripts/webkitdirs.pm: Added runDrosera function.
1020
1021 2008-01-13  Dan Bernstein  <mitz@apple.com>
1022
1023         - fix breakage due to last-minute change
1024
1025         * DumpRenderTree/win/DumpRenderTree.cpp:
1026         (runTest): Declare the loop variable.
1027
1028 2008-01-13  Dan Bernstein  <mitz@apple.com>
1029
1030         Reviewed by Adam Roben.
1031
1032         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
1033
1034         * DumpRenderTree/win/DumpRenderTree.cpp:
1035         (DumpRenderTreeWndProc):
1036         (initialize):
1037         (dumpBackForwardList):
1038         (dumpBackForwardListForAllWindows):
1039         (dump):
1040         (resetWebViewToConsistentStateBeforeTesting): Factored out of
1041         runTest().
1042         (runTest):
1043         (allWindows): Added. Returns a vector of all open windows.
1044         (windowToWebViewMap): Added. Returns a map from open windows to their
1045         WebViews.
1046         (createWebViewAndOffscreenWindow): Factored out of main() to be
1047         reusable for creating extra windows.
1048         (main):
1049         * DumpRenderTree/win/DumpRenderTreeWin.h:
1050         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1051         (LayoutTestController::windowCount): Implemented.
1052         * DumpRenderTree/win/UIDelegate.cpp:
1053         (UIDelegate::createWebViewWithRequest): Implemented.
1054         (UIDelegate::webViewClose): Implemented.
1055         * DumpRenderTree/win/UIDelegate.h:
1056
1057 2008-01-12  Alp Toker  <alp@atoker.com>
1058
1059         Reviewed by Mark Rowe.
1060
1061         Hide non-public symbols in GTK+/autotools release builds.
1062
1063         * GNUmakefile.am:
1064
1065 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1066
1067         Reviewed by Ap.
1068
1069         * Make launching of the WebKit httpd work on GNU/Debian/Linux
1070         
1071         The configuration of Apache2 and installation does not depend on
1072         the kernel but on the distribution policy. Make launching of httpd
1073         work for Debian derived distributions.
1074
1075         * Scripts/run-webkit-httpd:
1076         * Scripts/run-webkit-tests:
1077         * Scripts/webkitdirs.pm:
1078
1079 2008-01-12  Mark Rowe  <mrowe@apple.com>
1080
1081         Reviewed by Maciej Stachowiak.
1082
1083         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
1084
1085         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
1086         match the callers expectations that it can take ownership of the string.
1087
1088 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
1089
1090         Reviewed by Adam Roben.
1091
1092         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
1093
1094         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
1095         as these are only posted because the test window is not a normal visible one, and
1096         they confuse drag&drop machinery.
1097
1098 2008-01-11  Adam Roben  <aroben@apple.com>
1099
1100         Fix a crash when pathToLocalResource fails and a leak
1101
1102         Reviewed by Darin.
1103
1104         * DumpRenderTree/LayoutTestController.cpp:
1105         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
1106         sure not to pass null to JSValueMakeString.
1107         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1108         (LayoutTestController::pathToLocalResource): Print an error message if
1109         the conversion fails so it's clear what happened.
1110
1111 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
1112
1113         Reviewed by John Sullivan.
1114
1115         * DumpRenderTree/mac/GCControllerMac.mm:
1116         (GCController::collectOnAlternateThread): Updated for name change.
1117
1118 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
1119
1120         wx build fix. Don't build dftables any longer since it's now a Perl
1121         script.
1122
1123         * wx/build-wxwebkit:
1124
1125 2008-01-10  Sam Weinig  <sam@webkit.org>
1126
1127         Reviewed by Anders Carlsson.
1128
1129         Make DRT track open windows instead of allocated windows so that
1130         we can avoid ASSERTION due to late deallocs out of our control.
1131
1132         * DumpRenderTree/mac/DumpRenderTree.mm:
1133         (dumpBackForwardListForAllWindows):
1134         (runTest):
1135         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1136         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1137         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1138         (+[DumpRenderTreeWindow openWindows]):
1139         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1140         (-[DumpRenderTreeWindow close]):
1141         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1142         (LayoutTestController::windowCount):
1143
1144 2008-01-10  Ada Chan  <adachan@apple.com>
1145
1146         Meta key is not the same as Alt key on windows.
1147
1148         Reviewed by Darin.
1149
1150         * DumpRenderTree/win/EventSender.cpp:
1151         (keyDownCallback):
1152
1153 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
1154
1155         Reviewed by Darin, Sam and Adam.
1156
1157         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
1158         link in gmail message displays JavaScript alert falsely complaining
1159         about pop-up blocking.
1160         - Added the ability to enable the pop-up blocker via the
1161         LayoutTestController.
1162
1163         * DumpRenderTree/LayoutTestController.cpp:
1164         (setPopupBlockingEnabledCallback):
1165         (LayoutTestController::staticFunctions):
1166         * DumpRenderTree/LayoutTestController.h:
1167         * DumpRenderTree/mac/DumpRenderTree.mm:
1168         (setDefaultsToConsistentValuesForTesting):
1169         (resetWebViewToConsistentStateBeforeTesting):
1170         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1171         (LayoutTestController::setPopupBlockingEnabled):
1172
1173 2008-01-10  Lars Knoll  <lars@trolltech.com>
1174
1175         Reviewed by Simon.
1176
1177         rename QWebPageHistory to QWebHistory.
1178         
1179
1180         * DumpRenderTree/qt/jsobjects.cpp:
1181
1182 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
1183
1184         Reviewed by Darin.
1185         
1186         - add some more renames, adjust some
1187
1188         * Scripts/do-webcore-rename:
1189
1190 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1191
1192         Reviewed by Oliver.
1193
1194         Enable SVG Fonts support by default.
1195
1196         * Scripts/build-webkit:
1197
1198 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1199
1200         Reviewed by Adam.
1201
1202         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
1203         DRT doesn't handle platform specific pixel test results correctly.
1204
1205         <test>-expected.txt files and <test>-expected.png files may now live
1206         in different directories (ie. a cross-platform <test>-expected.txt file
1207         and a platform-specific <test>-expected.png file).
1208
1209         * Scripts/run-webkit-tests:
1210
1211 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
1212
1213         Reviewed by Darin.
1214
1215         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
1216         DRT did not correctly handle printing the '\0' char.  Now it does.
1217
1218         * DumpRenderTree/win/DumpRenderTree.cpp:
1219         (dumpFramesAsText):
1220         (dump):
1221
1222 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
1223
1224         Reviewed by Lars.
1225
1226         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
1227         
1228
1229         * DumpRenderTree/qt/main.cpp:
1230         * DumpRenderTree/qt/testplugin.cpp:
1231         * DumpRenderTree/qt/testplugin.h:
1232
1233 2008-01-05  Mark Rowe  <mrowe@apple.com>
1234
1235         Reviewed by Alp Toker.
1236
1237         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
1238
1239         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1240         (processWork): Process pending work.
1241         (webViewLoadFinished): Schedule processing of pending work.
1242         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
1243
1244 2008-01-05  Darin Adler  <darin@apple.com>
1245
1246         * Scripts/do-webcore-rename: Some more renaming plans.
1247
1248 2008-01-04  Alice Liu  <alice.liu@apple.com>
1249
1250         Reviewed by Alexey and Darin.
1251
1252         Adding "home" and "end" to DRT's keydown since
1253         DOM key events can't handle keyIdentifiers at this point. 
1254
1255         * DumpRenderTree/mac/EventSendingController.mm:
1256         (-[EventSendingController keyDown:withModifiers:]):
1257         * DumpRenderTree/win/EventSender.cpp:
1258         (keyDownCallback):
1259
1260 2008-01-04  Lars Knoll  <lars@trolltech.com>
1261
1262         Reviewed by Simon.
1263
1264         fix DRT after the changes to QWebPage.
1265         
1266         The great thing is that we actually don't have
1267         any regressions from the QWebPage change :)
1268         
1269
1270         * DumpRenderTree/qt/DumpRenderTree.cpp:
1271         (WebCore::DumpRenderTree::DumpRenderTree):
1272
1273 2008-01-04  Lars Knoll  <lars@trolltech.com>
1274
1275         Reviewed by Simon.
1276
1277         make QWebPage a QObject and get things to compile.
1278         
1279         Nothing works currently though.
1280         
1281
1282         * DumpRenderTree/qt/DumpRenderTree.cpp:
1283         (WebCore::DumpRenderTree::DumpRenderTree):
1284
1285 2008-01-04  Lars Knoll  <lars@trolltech.com>
1286
1287         Reviewed by Simon.
1288
1289         take a QString as identifier in QWebFrame::addToJSWindowObject.
1290
1291         * DumpRenderTree/qt/DumpRenderTree.cpp:
1292         (WebCore::DumpRenderTree::initJSObjects):
1293
1294 2008-01-04  Alp Toker  <alp@atoker.com>
1295
1296         GTK+ DRT build fix for breakage introduced in r29149.
1297
1298         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1299         (LayoutTestController::execCommand):
1300
1301 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1302
1303         Reviewed by Darin.
1304
1305         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
1306
1307         Added layoutTestController.execCommand to access editor commands that are not available
1308         via document.execCommand.
1309
1310         * DumpRenderTree/LayoutTestController.cpp:
1311         (execCommandCallback):
1312         (LayoutTestController::staticFunctions):
1313         * DumpRenderTree/LayoutTestController.h:
1314         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1315         (LayoutTestController::execCommand):
1316         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1317         (LayoutTestController::queueLoad):
1318         (LayoutTestController::execCommand):
1319
1320 2008-01-03  Alice Liu  <alice.liu@apple.com>
1321
1322         Reviewed by Darin, Mitz.
1323
1324         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
1325
1326         the clickcount should not increase if the last click was at a different location.  it's a new click.
1327
1328         * DumpRenderTree/mac/DumpRenderTree.mm:
1329         (runTest):
1330         * DumpRenderTree/mac/EventSendingController.h:
1331         * DumpRenderTree/mac/EventSendingController.mm:
1332         (-[EventSendingController mouseDown]):
1333         (-[EventSendingController mouseUp]):
1334
1335 2008-01-03  Darin Adler  <darin@apple.com>
1336
1337         Reviewed by Adam.
1338
1339         * Scripts/update-webkit: Make this work a little better for the people at Apple
1340         who have a directory named Internal.
1341
1342 2008-01-03  Adam Roben  <aroben@apple.com>
1343
1344         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
1345
1346         Rubberstamped by Mark.
1347
1348         * Scripts/update-webkit-auxiliary-libs:
1349
1350 2008-01-03  Adam Roben  <aroben@apple.com>
1351
1352         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
1353
1354         http://bugs.webkit.org/show_bug.cgi?id=15663
1355
1356         Added a fuzz factor into the Last-Modified comparison for downloading
1357         WebKitAuxiliaryLibrary.zip.
1358
1359         The zip file is served from a set of mirrors who give Last-Modified
1360         times that are off by 1-3 seconds from each other. This was causing
1361         the build bots to redownload WebKitAuxiliaryLibrary for every build,
1362         which would then cause all of WebCore to rebuild each time.
1363
1364         Reviewed by Mark.
1365
1366         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
1367         at least 30 seconds newer than the old one -- otherwise we assume that
1368         the difference in time is due to the mirrors being slightly offset
1369         from each other.
1370         (sub lastModifiedToUnixTime): Added.
1371
1372 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1373
1374         Windows build fix.
1375
1376         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
1377
1378 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1379
1380         Reviewed by Lars.
1381
1382         Moved QWebPage::open to QWebFrame::load and added setHtml.
1383         
1384
1385         * DumpRenderTree/qt/DumpRenderTree.cpp:
1386         (WebCore::DumpRenderTree::open):
1387
1388 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1389
1390         Reviewed by Lars.
1391
1392         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
1393         
1394
1395         * DumpRenderTree/qt/DumpRenderTree.cpp:
1396         (WebCore::DumpRenderTree::DumpRenderTree):
1397
1398 2008-01-02  Sam Weinig  <sam@webkit.org>
1399
1400         * Scripts/do-webcore-rename: Yet more renaming ideas.
1401
1402 2008-01-02  Darin Adler  <darin@apple.com>
1403
1404         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
1405
1406 2008-01-02  Alice Liu  <alice.liu@apple.com>
1407
1408         Reviewed by Sam Weinig.
1409
1410         fixing assertion hit with editing/selection/move-begin-end.html
1411
1412         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
1413         * DumpRenderTree/win/DumpRenderTree.vcproj:
1414         * DumpRenderTree/win/EventSender.cpp:
1415         (keyDownCallback):
1416         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
1417
1418 2008-01-02  Darin Adler  <darin@apple.com>
1419
1420         * Scripts/do-webcore-rename: Some more name change plans.
1421
1422 2008-01-02  Alice Liu  <alice.liu@apple.com>
1423
1424         Reviewed by Maciej.
1425
1426         Added handling for page up and page down in EventSender
1427
1428         * DumpRenderTree/mac/EventSendingController.mm:
1429         (-[EventSendingController keyDown:withModifiers:]):
1430         * DumpRenderTree/win/EventSender.cpp:
1431         (keyDownCallback):
1432
1433 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
1434
1435         Reviewed by Darin.
1436
1437         Fix fast/events/arrow-keys-on-body.html for real.
1438
1439         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
1440
1441 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
1442
1443         Reviewed by Darin.
1444
1445         http://bugs.webkit.org/show_bug.cgi?id=16674
1446         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
1447
1448         * Scripts/run-launcher:
1449
1450 2007-12-31  Darin Adler  <darin@apple.com>
1451
1452         Suggested by Antti.
1453
1454         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
1455         we get it installed on the build bots.
1456
1457 2007-12-30  Eric Seidel  <eric@webkit.org>
1458
1459         Reviewed by Sam.
1460
1461         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
1462
1463 2007-12-29  Darin Adler  <darin@apple.com>
1464
1465         Reviewed by Oliver.
1466
1467         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
1468           leak bot shows createCStringFromNPVariant result leaking
1469
1470         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1471         (pluginInvoke): Added a missing free.
1472
1473 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1474
1475         Reviewed by Alp Toker.
1476
1477         http://bugs.webkit.org/show_bug.cgi?id=16390
1478         Use autotools or GNU make as the build system for the GTK port
1479
1480         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
1481         * GNUmakefile.am: Added.
1482
1483 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
1484
1485         Reviewed by Oliver.
1486
1487         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
1488
1489         * DumpRenderTree/win/EventSender.cpp:
1490         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
1491         of 1, even though WebKit currently ignores it.
1492
1493 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
1494
1495         wx buildbot fix. Update libpng dl script to the latest version.
1496
1497         * wx/install-unix-extras:
1498
1499 2007-12-22  Antti Koivisto  <antti@apple.com>
1500
1501         Fix a typo.
1502
1503         * Scripts/webkitdirs.pm:
1504
1505 2007-12-21  Sam Weinig  <sam@webkit.org>
1506
1507         Reviewed by Mark Rowe.
1508
1509         - Disable the back/forward cache using the new WebPreferences API
1510           instead of through the BackForwardList.  This makes us match what
1511           we do on Windows.
1512
1513         * DumpRenderTree/mac/DumpRenderTree.mm:
1514         (createWebViewAndOffscreenWindow):
1515         (setDefaultsToConsistentValuesForTesting):
1516
1517 2007-12-21  Dan Bernstein  <mitz@apple.com>
1518
1519         Reviewed by Mark Rowe.
1520
1521         - disable the back/forward cache in Windows DumpRenderTree. It is
1522           already disabled in Mac DumpRenderTree.
1523
1524         * DumpRenderTree/win/DumpRenderTree.cpp:
1525         (initializePreferences):
1526
1527 2007-12-13  Antti Koivisto  <antti@apple.com>
1528
1529         Reviewed by Darin and Steve.
1530         
1531         - check for QuickTime SDK on Windows.
1532         - build media support on Windows by default
1533
1534         * Scripts/build-webkit:
1535         * Scripts/webkitdirs.pm:
1536
1537 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
1538
1539         Build script fix for buildbot.
1540
1541         * wx/build-wxwebkit:
1542
1543 2007-12-20  Eric Seidel  <eric@webkit.org>
1544
1545         Reviewed by mjs.
1546
1547         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
1548
1549 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1550
1551         Reviewed by Steve.
1552
1553         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
1554         WebKit.
1555
1556         - Drosera and Safari need to use the same ProgIDs in order for
1557         CoCreateInstance to work properly.  The most robust way to do this is
1558         for WebKit to dynamically publish those ProgIDs.
1559
1560         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
1561         (DebuggerClient::createWebViewWithRequest):
1562         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
1563         statics.
1564         (Drosera::initUI):
1565         (Drosera::attach):
1566         (Drosera::attemptToCreateServerConnection):
1567         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
1568         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
1569         make use of the published ProgIDs.
1570         (ServerConnection::attemptToCreateServerConnection):
1571
1572 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1573
1574         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
1575         - Build bot and leak fix.
1576
1577         * DumpRenderTree/LayoutTestController.cpp:
1578         (pathToLocalResourceCallback):
1579
1580 2007-12-19  David Kilzer  <ddkilzer@apple.com>
1581
1582         Make svn-apply/svn-unapply work with patches from git-format-patch.
1583
1584         Reviewed by Darin.
1585
1586         * Scripts/svn-apply:
1587         (patch): If 'Index:' can't be found in the text passed in, print it
1588         out with a warning and return early.
1589         * Scripts/svn-unapply:
1590         (patch): Ditto.
1591
1592 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
1593
1594         Reviewed by Alp Toker.
1595
1596         Build related fixes.
1597
1598         * wx/build-wxwebkit:
1599         - Check to make sure the user is running a supported wx port
1600         - More robust checks for Cygwin
1601         - Only run install-unix-extras on Mac, it's not the right solution
1602           for Linux distros.
1603         - Remove outdated Linux instructions after successful build
1604         - Clean Bakefile-generated files during a clean operation
1605
1606 2007-12-18  Darin Adler  <darin@apple.com>
1607
1608         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
1609
1610 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
1611
1612         Add script to run Drosera as part of the nightly.
1613         
1614         Reviewed by Kevin M.
1615
1616         * Scripts/run-drosera.cmd: Added.
1617
1618 2007-12-18  Darin Adler  <darin@apple.com>
1619
1620         * Scripts/do-webcore-rename: Remove a stray K.
1621
1622 2007-12-18  Darin Adler  <darin@apple.com>
1623
1624         * Scripts/do-webcore-rename: Plan more renaming.
1625
1626 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
1627
1628         Reviewed by Alp Toker.
1629
1630         http://bugs.webkit.org/show_bug.cgi?id=16042
1631         [GTK] Eliminate webkit_init()
1632
1633         Moving webkit initialization to WebView class init.
1634
1635         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1636         (main):
1637         * GtkLauncher/main.c:
1638         (main):
1639
1640 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
1641
1642         Reviewed by Alp Toker.
1643
1644         http://bugs.webkit.org/show_bug.cgi?id=13542
1645         gdklauncher doesnt change URL in adress GTKEntry.
1646
1647         * GtkLauncher/main.c:
1648         (load_commit_cb): added
1649         (title_change_cb):
1650         (create_browser):
1651
1652 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
1653
1654         Reviewed by Adam Roben.
1655
1656         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
1657
1658         * FindSafari/FindSafari.cpp:
1659         (_tmain):
1660
1661 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
1662
1663         Reviewed by Adam Roben.
1664
1665         http://bugs.webkit.org/show_bug.cgi?id=16315
1666         FindSafari needs a path-only option.
1667
1668         * FindSafari/FindSafari.cpp:
1669         (_tmain):
1670
1671 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
1672
1673         Reviewed by Darin.
1674
1675         http://bugs.webkit.org/show_bug.cgi?id=16462
1676         REGRESSION: access keys broken on Windows
1677
1678         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
1679         if Alt is pressed.
1680
1681 2007-12-15  Sam Weinig  <sam@webkit.org>
1682
1683         Reviewed by Mark Rowe.
1684
1685         Fix urlSuitableForTestResult to correctly identify wstring::npos as
1686         the case when wstring.find doesn't find anything.
1687
1688         * DumpRenderTree/win/DumpRenderTree.cpp:
1689         (urlSuitableForTestResult):
1690
1691 2007-12-15  Alp Toker  <alp@atoker.com>
1692
1693         GTK+ DRT build fix for GLib < 2.14.
1694
1695         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1696         (LayoutTestController::setWaitToDump):
1697
1698 2007-12-05  Mark Rowe  <mrowe@apple.com>
1699
1700         Reviewed by Alp Toker.
1701
1702         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
1703         many layout tests from hanging while waiting on user responses to dialogs.
1704
1705         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1706         (invalidateAnyPreviousWaitToDumpWatchdog):
1707         (webViewScriptAlert):
1708         (webViewScriptPrompt):
1709         (webViewScriptConfirm):
1710         (main):
1711         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1712         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1713         (waitToDumpWatchdogFired):
1714         (LayoutTestController::setWaitToDump):
1715
1716 2007-12-05  Mark Rowe  <mrowe@apple.com>
1717
1718         Reviewed by Alp Toker.
1719
1720         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
1721
1722         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1723         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1724         (dump):
1725         (runTest):
1726         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
1727         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
1728         work queue is empty.
1729         (webViewWindowObjectCleared): Set up window.layoutTestController.
1730         (webViewConsoleMessage): Match the console message format expected by the layout test results.
1731         (main): Hook up the new signals.
1732         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1733         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
1734         dumping multiple times.
1735         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
1736         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
1737
1738 2007-12-14  Anders Carlsson  <andersca@apple.com>
1739
1740         Reviewed by Brady.
1741
1742         Assert that a web frame that's loading a resource always has either a data source or 
1743         a provisional data source.
1744         
1745         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1746         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1747
1748 2007-12-14  Darin Adler  <darin@apple.com>
1749
1750         - fix mistake causing nearly all tests to fail on Windows
1751
1752         * DumpRenderTree/win/UIDelegate.cpp:
1753         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1754         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1755
1756         * DumpRenderTree/mac/UIDelegate.mm:
1757         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1758         than passing the entire message.
1759
1760 2007-12-14  Darin Adler  <darin@apple.com>
1761
1762         - fix Tiger build
1763
1764         * DumpRenderTree/mac/UIDelegate.mm:
1765         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1766         new-to-Leopard methods.
1767
1768 2007-12-14  Darin Adler  <darin@apple.com>
1769
1770         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1771         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1772         delegate methods here.
1773
1774 2007-12-14  Anders Carlsson  <andersca@apple.com>
1775
1776         Reviewed by Darin and Geoff.
1777
1778         <rdar://problem/5619295> 
1779         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1780         
1781         Add property getting methods to the plug-in.
1782         
1783         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1784         (pluginInvoke):
1785
1786 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1787
1788         Reviewed by Darin.
1789
1790         - Layout test fix for mac. When dumped to the console local file paths
1791         now only show the name of the resource not the whole path.  This is to
1792         make the results machine and OS independent.
1793
1794         * DumpRenderTree/mac/UIDelegate.mm:
1795         (-[UIDelegate webView:addMessageToConsole:]):
1796
1797 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1798
1799         Reviewed by Adam.
1800
1801         - Layout tests fix.  We need a way to remove machine-dependent
1802         information from paths in layout test results. The UIDelegate now does
1803         this.
1804
1805         * DumpRenderTree/DumpRenderTree.h:
1806         * DumpRenderTree/win/DumpRenderTree.cpp:
1807         (urlSuitableForTestResult):
1808         * DumpRenderTree/win/DumpRenderTreeWin.h:
1809         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1810         * DumpRenderTree/win/UIDelegate.cpp:
1811         (UIDelegate::webViewAddMessageToConsole):
1812
1813 2007-12-13  Alp Toker  <alp@atoker.com>
1814
1815         Build fix for DRT breakage introduced in r28690.
1816
1817         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1818         (LayoutTestController::pathToLocalResource):
1819
1820 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1821
1822         Reviewed by Alice and Sam.
1823
1824         - <rdar://5621435> Need a way to specify local resources (being loaded
1825         from HTTP tests) on Windows.
1826         - Implemented pathToLocalResource which exposes the functionality of
1827         converting a given unix path to the correct location on Windows.
1828
1829         * DumpRenderTree/LayoutTestController.cpp:
1830         (pathToLocalResourceCallback):
1831         (LayoutTestController::staticFunctions):
1832         * DumpRenderTree/LayoutTestController.h:
1833         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1834         (LayoutTestController::pathToLocalResource):
1835         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1836         (LayoutTestController::pathToLocalResource):
1837
1838 2007-12-12  Anders Carlsson  <andersca@apple.com>
1839
1840         Reviewed by Sam.
1841
1842         <rdar://problem/5132003>
1843         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1844
1845         * DumpRenderTree/win/DumpRenderTree.cpp:
1846         (main):
1847         Set the resource load delegate.
1848         
1849         * DumpRenderTree/win/DumpRenderTree.vcproj:
1850         
1851         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1852         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1853
1854 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1855
1856         Reviewed by Adam Roben.
1857
1858         Fix conversion from double to LPARAM in dispatchMessage().
1859
1860         * DumpRenderTree/win/EventSender.cpp:
1861         (dispatchMessageCallback):
1862
1863 2007-12-11  Dan Bernstein  <mitz@apple.com>
1864
1865         Reviewed by Mark Rowe and Sam Weinig too!
1866
1867         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1868           fonts DumpRenderTree registers.
1869
1870         * DumpRenderTree/win/DumpRenderTree.cpp:
1871         (initialize):
1872
1873 2007-12-11  Brady Eidson  <beidson@apple.com>
1874
1875         Reviewed by Anders
1876
1877         Make DumpRenderTree on mac use its own path for Databases testing
1878
1879         * DumpRenderTree/mac/DumpRenderTree.mm:
1880         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1881           for future DRT-only use, then use it to construct the Databases path and set that default
1882
1883 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1884
1885         Reviewed by Darin.
1886
1887         <rdar://problem/5535636>
1888         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1889
1890         http://bugs.webkit.org/show_bug.cgi?id=13916
1891         JavaScript detects Tab as a character input on a textfield validation
1892
1893         * DumpRenderTree/mac/EventSendingController.mm:
1894         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1895         Dispatch a keyup to better match what happens when a key is physically pressed.
1896
1897         * DumpRenderTree/win/EventSender.cpp:
1898         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1899         returning from keyDown().
1900         (getConstantCallback): Fixed a couple copy/paste mistakes.
1901
1902 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1903
1904         Reviewed by Oliver.
1905
1906         - <rdar://5599845> Drosera: Does not show loal files in the file list
1907         on the left side.
1908
1909         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1910         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1911         so the open source community can build.
1912
1913 2007-12-10  Brady Eidson  <beidson@apple.com>
1914
1915         Rubberstamped by Sam Weinig
1916
1917         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1918
1919         * DumpRenderTree/mac/UIDelegate.mm:
1920         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1921         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1922
1923 2007-12-08  Oliver Hunt  <oliver@apple.com>
1924
1925         Reviewed by Sam W.
1926
1927         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1928         
1929         Fixes <rdar://problem/5620249> Must disable SVG animation
1930         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1931         
1932         In order to allow finer grained control over the set of SVG features
1933         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1934         distinct flags:
1935         ENABLE_SVG_ANIMATION
1936         ENABLE_SVG_FILTERS
1937         ENABLE_SVG_FONTS
1938         ENABLE_SVG_AS_IMAGE
1939         ENABLE_SVG_USE
1940         
1941         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1942         
1943         Script handles all the new build flags, and allows --svg-experimental
1944         to automatically enable all features.
1945
1946         * Scripts/build-webkit:
1947
1948 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1949
1950         Fix version parsing.
1951
1952         Rubber-stamped by Oliver.
1953
1954         * Drosera/win/Drosera.vcproj/auto-version.sh:
1955
1956 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1957
1958         Build modifications for Drosera.
1959
1960         Reviewed by Adam.
1961
1962         * Drosera/DroseraWin.make: Added.
1963         * Drosera/win/Drosera.vcproj/Drosera.rc:
1964         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1965         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1966         * Drosera/win/Drosera.vcproj/VERSION: Added.
1967         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1968
1969 2007-12-06  Adam Roben  <aroben@apple.com>
1970
1971         Explicitly turn on the Mac font ascent hack on Windows
1972
1973         This keeps our font metrics matching those from Mac.
1974
1975         Reviewed by Hyatt.
1976
1977         * DumpRenderTree/win/DumpRenderTree.cpp:
1978         (main):
1979
1980 2007-12-06  Anders Carlsson  <andersca@apple.com>
1981
1982         Rename main.c to main.cpp here too.
1983         
1984         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1985
1986 2007-12-06  Sam Weinig  <sam@webkit.org>
1987
1988         Rubber stamped by Geoff.
1989
1990         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1991
1992 2007-12-06  Darin Adler  <darin@apple.com>
1993
1994         * Scripts/do-webcore-rename: Some more renaming plans.
1995
1996 2007-12-06  Anders Carlsson  <andersca@apple.com>
1997
1998         Restore implementation of testGetIntIdentifier that was accidentally
1999         removed somehow (possibly when I made PluginObject be a cpp file).
2000         
2001         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2002         (pluginInvoke):
2003
2004 2007-12-05  Anders Carlsson  <andersca@apple.com>
2005
2006         Make the entry points extern "C".
2007         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2008         
2009 2007-12-05  Anders Carlsson  <andersca@apple.com>
2010
2011         C++ warning fixes.
2012         
2013         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2014         (NPP_New):
2015         (NPP_Destroy):
2016         (NPP_SetWindow):
2017         (NPP_NewStream):
2018         (NPP_HandleEvent):
2019         (NPP_URLNotify):
2020         (NPP_GetValue):
2021
2022 2007-12-05  Anders Carlsson  <andersca@apple.com>
2023
2024         Add the .cpp files to the TestNetscapePlugIn target.
2025
2026         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2027
2028 2007-12-05  Anders Carlsson  <andersca@apple.com>
2029
2030         Reviewed by Geoff.
2031         
2032         Rename the TestNetscapePlugIn .c files to be .cpp.
2033
2034         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2035         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
2036         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
2037         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
2038         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
2039         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
2040         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
2041         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2042
2043 2007-12-05  Adam Roben  <aroben@apple.com>
2044
2045         Fix case of keypresses from the Windows implementation of eventSender.keyDown
2046
2047         This fixes several regression tests.
2048
2049         Reviewed by Alice.
2050
2051         * DumpRenderTree/win/EventSender.cpp:
2052         (keyDownCallback): Virtual keycodes for ASCII characters are always
2053         uppercase, so we need to check the case of the original character
2054         passed in to eventSender.keyDown.
2055
2056 2007-12-05  Adam Roben  <aroben@apple.com>
2057
2058         Learn from Tim's mistakes
2059
2060         * DumpRenderTree/win/DumpRenderTree.cpp:
2061         (runTest): Reset the authorAndUserStylesEnabled preference for each
2062         test.
2063
2064 2007-12-05  Alp Toker  <alp@atoker.com>
2065
2066         Reviewed by Mark Rowe.
2067
2068         Initialize GTK+ and WebKit so the tests can run.
2069
2070         Reorganize the headers a little.
2071
2072         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2073         (main):
2074
2075 2007-12-04  Anders Carlsson  <andersca@apple.com>
2076
2077         Remove IWebScriptScope include.
2078         
2079         * Drosera/win/DebuggerDocumentPlatform.cpp:
2080
2081 2007-12-04  Sam Weinig  <sam@webkit.org>
2082
2083         Rubber stamped by Mark Rowe.
2084
2085         Define CF as platform for mac and revert r28409
2086
2087         * DumpRenderTree/DumpRenderTree.h:
2088         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2089
2090 2007-12-04  Sam Weinig  <sam@webkit.org>
2091
2092         Define CF as platform for windows.
2093
2094         Reviewed by Adam Roben.
2095
2096         * DumpRenderTree/win/DumpRenderTreeWin.h:
2097
2098 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
2099
2100         Reviewed by Adam and Darin.
2101
2102         - Removed a needless BSTR cleanup.
2103
2104         * Drosera/win/DebuggerDocumentPlatform.cpp:
2105         (DebuggerDocument::getPlatformCurrentFunctionStack):
2106
2107 2007-11-27  Adam Roben  <aroben@apple.com>
2108
2109         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
2110
2111         Reviewed by Maciej.
2112
2113         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2114         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
2115
2116 2007-12-04  Alp Toker  <alp@atoker.com>
2117
2118         Prospective Win DRT build fix.
2119
2120         * DumpRenderTree/DumpRenderTree.h:
2121
2122 2007-12-04  Alp Toker  <alp@atoker.com>
2123
2124         Fix a clobbered copyright header.
2125
2126         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2127
2128 2007-12-04  Xan Lopez  <xan@gnome.org>
2129
2130         Reviewed by Alp Toker.
2131
2132         http://bugs.webkit.org/show_bug.cgi?id=15561
2133         GTK port needs DumpRenderTree implementation
2134
2135         Start work on the GTK+ DRT.
2136
2137         This does not work yet, and there are a few lingering style issues
2138         (nothing major) but this patch has been stuck in the bug tracker for
2139         too long already.
2140
2141         * DumpRenderTree/DumpRenderTree.h:
2142         * DumpRenderTree/gtk: Added.
2143         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
2144         (autocorrectURL):
2145         (shouldLogFrameLoadDelegates):
2146         (dumpFrameScrollPosition):
2147         (displayWebView):
2148         (appendString):
2149         (dumpFramesAsText):
2150         (dumpRenderTreeAsText):
2151         (dump):
2152         (runTest):
2153         (main):
2154         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
2155         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
2156         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
2157         (GCController::collect):
2158         (GCController::collectOnAlternateThread):
2159         (GCController::getJSObjectCount):
2160         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
2161         (LayoutTestController::~LayoutTestController):
2162         (LayoutTestController::addDisallowedURL):
2163         (LayoutTestController::clearBackForwardList):
2164         (LayoutTestController::copyDecodedHostName):
2165         (LayoutTestController::copyEncodedHostName):
2166         (LayoutTestController::display):
2167         (LayoutTestController::keepWebHistory):
2168         (LayoutTestController::notifyDone):
2169         (LayoutTestController::queueBackNavigation):
2170         (LayoutTestController::queueForwardNavigation):
2171         (LayoutTestController::queueLoad):
2172         (LayoutTestController::queueReload):
2173         (LayoutTestController::queueScript):
2174         (LayoutTestController::setAcceptsEditing):
2175         (LayoutTestController::setCustomPolicyDelegate):
2176         (LayoutTestController::setMainFrameIsFirstResponder):
2177         (LayoutTestController::setTabKeyCyclesThroughElements):
2178         (LayoutTestController::setUseDashboardCompatibilityMode):
2179         (LayoutTestController::setUserStyleSheetEnabled):
2180         (LayoutTestController::setUserStyleSheetLocation):
2181         (LayoutTestController::setWindowIsKey):
2182         (LayoutTestController::setWaitToDump):
2183         (LayoutTestController::windowCount):
2184         (LayoutTestController::setPrivateBrowsingEnabled):
2185         (LayoutTestController::setAuthorAndUserStylesEnabled):
2186         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
2187         (JSStringCopyUTF8CString):
2188         (LoadItem::invoke):
2189         (ReloadItem::invoke):
2190         (ScriptItem::invoke):
2191         (BackForwardItem::invoke):
2192
2193 2007-12-03  Sam Weinig  <sam@webkit.org>
2194
2195         Move JavaScriptCore thread testing code to pthread specific directory
2196         and remove the dependance on CoreFoundation by using WTF::HashSet.
2197
2198         Reviewed by Geoff and Oliver.
2199
2200         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2201         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
2202         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
2203         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
2204         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
2205         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
2206         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
2207         * DumpRenderTree/pthreads: Added.
2208         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
2209         (javaScriptThreads):
2210         (runJavaScriptThread):
2211         (startJavaScriptThreads):
2212         (stopJavaScriptThreads):
2213
2214 2007-12-03  Andrew Bonventre  <andybons@google.com>
2215
2216         Reviewed by Darin Adler.
2217
2218         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
2219         Symbol lookup menu broken in debugger view
2220
2221         * Drosera/debugger.js: Fixed javascript error where document property
2222         should have been used instead of contentDocument in switchFunction that
2223         was breaking the select symbol dropdown menu.  This is because
2224         window.frames will return a Window object and not a frame object like
2225         the author was originally expecting.
2226
2227 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
2228
2229         Reviewed by Adam.
2230
2231         - <rdar://5618942> Drosera: Console window does not process everything
2232         correctly.
2233         - <rdar://5619005> Drosera: could be sped up by moving the 
2234         WebScriptScope stuff into the WebScriptCallFrame.
2235         - Now the console can correctly process objects and does not receive
2236         notifications from JavaScriptCore about the JavaScript in Drosera's
2237         own process.
2238
2239         * Drosera/win/DebuggerDocumentPlatform.cpp:
2240         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2241         (DebuggerDocument::platformValueForScopeVariableNamed):
2242
2243 2007-12-03  Stephanie  <slewis@apple.com>
2244
2245         Reviewed by Darin.
2246
2247         Check to see if we are building a debug root
2248
2249         * Scripts/check-for-global-initializers: 
2250
2251 2007-12-03  Dan Bernstein  <mitz@apple.com>
2252
2253         Reviewed by Darin Adler.
2254
2255         - added a testGetIntIdentifier() method to TestNetscapePlugIn
2256
2257         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
2258         (pluginInvoke):
2259
2260 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
2261
2262         Reviewed by Oliver.
2263
2264         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
2265         in a more fine-grained manner than eventSender.keyDown().
2266
2267         * DumpRenderTree/win/EventSender.cpp:
2268         (getConstantCallback):
2269         (dispatchMessageCallback):
2270
2271 2007-12-02  Darin Adler  <darin@apple.com>
2272
2273         * Scripts/do-webcore-rename: More planned renaming.
2274
2275 2007-12-02  Sam Weinig  <sam@webkit.org>
2276
2277         Rubber stamped by Anders.
2278
2279         Use [NSURL absoluteString] instead of [NSURL description] in order to get
2280         more uniform results cross platform.
2281
2282         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2283         (-[NSURL _drt_descriptionSuitableForTestResult]):
2284
2285 2007-12-02  Sam Weinig  <sam@webkit.org>
2286
2287         Rubber stamped by Niko.
2288
2289         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
2290
2291         * DumpRenderTree/win/DumpRenderTree.cpp:
2292         * DumpRenderTree/win/DumpRenderTree.vcproj:
2293         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
2294         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
2295         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
2296         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
2297
2298 2007-12-01  Alp Toker  <alp@atoker.com>
2299
2300         Reviewed by Adam Roben.
2301
2302         Make use of the newly introduced webkit.h convenience header.
2303
2304         * GtkLauncher/main.c:
2305
2306 2007-12-01  Adam Treat  <treat@kde.org>
2307
2308         Reviewed by Simon.
2309
2310         * Check to see if the directory exists and exit if not.
2311
2312         * DumpRenderTree/qt/main.cpp:
2313         (main):
2314
2315 2007-12-01  Adam Treat  <treat@kde.org>
2316
2317         Reviewed by Simon.
2318
2319         * Don't hide symbols when in Debug mode
2320         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
2321
2322
2323         * DumpRenderTree/qt/main.cpp:
2324         (messageHandler):
2325
2326 2007-11-30  Alp Toker  <alp@atoker.com>
2327
2328         Reviewed by Adam Roben.
2329
2330         http://bugs.webkit.org/show_bug.cgi?id=15691
2331         [GTK] Public API does not follow GTK+ conventions
2332
2333         Refactor the WebKit/GTK+ public API. Changes:
2334           WebKitPage -> WebKitWebView
2335           WebKitFrame -> WebKitWebFrame
2336
2337         Public API source and header names have been updated to mirror the API
2338         changes.
2339
2340         The API is now kept in WebKit/gtk/WebView to match other ports in the
2341         same class such as Mac and Win.
2342
2343         * GtkLauncher/main.c:
2344         (activate_uri_entry_cb):
2345         (link_hover_cb):
2346         (title_change_cb):
2347         (progress_change_cb):
2348         (go_back_cb):
2349         (go_forward_cb):
2350         (create_browser):
2351         (main):
2352
2353 2007-11-30  Adam Roben  <aroben@apple.com>
2354
2355         Hopefully the final build fix
2356
2357         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
2358         pull in WTF's assertion/logging functions.
2359
2360 2007-11-30  Adam Roben  <aroben@apple.com>
2361
2362         Another build fix
2363
2364         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
2365         WebKit.lib.
2366
2367 2007-11-30  Adam Roben  <aroben@apple.com>
2368
2369         Debug build fix
2370
2371         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
2372         configuration.
2373         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
2374         projects.
2375         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
2376         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
2377         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
2378
2379 2007-11-30  Sam Weinig  <sam@webkit.org>
2380
2381         Reviewed by Adam Roben.
2382
2383         Fix drawSelectionRect to actually draw the selection rect.
2384
2385         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2386         (drawSelectionRect):
2387
2388 2007-11-30  Darin Adler  <darin@apple.com>
2389
2390         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
2391
2392 2007-11-30  Darin Adler  <darin@apple.com>
2393
2394         * Scripts/do-webcore-rename: Get ready for some future renaming.
2395
2396 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2397
2398         Reviewed by Adam.
2399
2400         - Removed some unnecessary functions and changed an unused return type. 
2401
2402         * Drosera/win/DebuggerClient.cpp:
2403         (registerConsoleClass):
2404         * Drosera/win/DebuggerClient.h:
2405         * Drosera/win/Drosera.cpp:
2406         (registerDroseraClass):
2407
2408 2007-11-28  Alp Toker  <alp@atoker.com>
2409
2410         Reviewed by Timothy Hatcher.
2411
2412         http://bugs.webkit.org/show_bug.cgi?id=16174
2413         [GTK] Use "URI" not "URL" in public API
2414
2415         Replace use of the term "URL" with "URI" in public headers,
2416         documentation and some internal code to match GLib/GTK+ convention.
2417
2418         This is now mentioned in the API guidelines:
2419           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
2420
2421         * GtkLauncher/main.c:
2422         (activate_uri_entry_cb):
2423         (title_change_cb):
2424         (create_toolbar):
2425         (main):
2426
2427 2007-11-29  Anders Carlsson  <andersca@apple.com>
2428
2429         Reviewed by Sam.
2430
2431         <rdar://problem/5230478>
2432         FrameLoadDelegate callbacks are not dumped in DRT.
2433         
2434         * DumpRenderTree/win/DumpRenderTree.cpp:
2435         (shouldLogFrameLoadDelegates):
2436         (runTest):
2437         (main):
2438         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2439         (BSTRtoString):
2440         (descriptionSuitableForTestResult):
2441         (FrameLoadDelegate::QueryInterface):
2442         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2443         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2444         (FrameLoadDelegate::didCommitLoadForFrame):
2445         (FrameLoadDelegate::didFinishLoadForFrame):
2446         (FrameLoadDelegate::willCloseFrame):
2447         (FrameLoadDelegate::didClearWindowObject):
2448         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2449         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2450         * DumpRenderTree/win/FrameLoaderDelegate.h:
2451         (FrameLoadDelegate::windowScriptObjectAvailable):
2452         (FrameLoadDelegate::didFirstLayoutInFrame):
2453
2454 2007-11-29  Sam Weinig  <sam@webkit.org>
2455
2456         Reviewed by Anders.
2457
2458         Add database quota UIDelegates methods to DRT UIDelegate.
2459
2460         * DumpRenderTree/mac/UIDelegate.mm:
2461         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2462         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
2463
2464 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2465
2466         Reviewed by Sam.
2467
2468         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
2469         dying and vice versa.
2470         - This fix will allow Drosera and Safari to reconnect if either of them
2471         closes correctly, but does not fix the case where one of them dies
2472         silently.
2473
2474         * Drosera/win/ServerConnection.cpp:
2475         (ServerConnection::attemptToCreateServerConnection): Added a safety
2476         check, because it's possilbe to try to connect to a server that's dying.
2477         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
2478         the server has died.
2479         * Drosera/win/ServerConnection.h: Added the new function and removed
2480         an unnecessary member.
2481
2482 2007-11-29  Anders Carlsson  <andersca@apple.com>
2483
2484         * DumpRenderTree/win/DumpRenderTree.vcproj:
2485         Add shlwapi.lib to all configurations.
2486
2487 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2488
2489         - Build fix.  Added additional includes for VS Express to the Release
2490         project.
2491
2492         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2493
2494 2007-11-29  Anders Carlsson  <andersca@apple.com>
2495
2496         Reviewed by Adam.
2497
2498         <rdar://problem/5132005>
2499         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
2500         
2501         * DumpRenderTree/win/DumpRenderTree.vcproj:
2502         Add shlwapi.lib
2503         
2504         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2505         (LayoutTestController::setUserStyleSheetEnabled):
2506         Implement this.
2507         
2508         (appendComponentToPath):
2509         New method which wraps the Win32 API PathAppend.
2510         
2511         (followShortcuts):
2512         New method which checks if a file points to a shortcut and
2513         follows the shortcut.
2514         
2515         (resolveCygwinPath):
2516         New method that takes a cygwin unix-style path and returns the Win32 path.
2517         
2518         (cfStringRefToWString):
2519         
2520         (LayoutTestController::setUserStyleSheetLocation):
2521         Implement this.
2522
2523 2007-11-29  Alice Liu  <alice.liu@apple.com>
2524
2525         Reviewed by Adam.
2526
2527         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
2528
2529         * DumpRenderTree/win/EventSender.cpp:
2530         (keyDownCallback):
2531         uppercase letters were being sent as lowercase letters without the shift key down.
2532
2533 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2534
2535         - Windows build fix. VS express needs some love.
2536
2537         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2538
2539 2007-11-28  Darin Adler  <darin@apple.com>
2540
2541         Reviewed by Adam Roben.
2542
2543         * DumpRenderTree/mac/EventSendingController.mm:
2544         (-[EventSendingController keyDown:withModifiers:]):
2545         Send capital letters through as lowercase letters with the shift key down
2546         rather than sending them as if they were highly unusual "capital letter keys".
2547
2548         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
2549         where you need to update results and more tests are failing than before.
2550
2551 2007-11-28  Anders Carlsson  <andersca@apple.com>
2552
2553         Reviewed by Darin.
2554
2555         <rdar://problem/5132001>
2556         contextClick is not implemented in DRT on Windows.
2557         
2558         * DumpRenderTree/win/EventSender.cpp:
2559         (contextClickCallback):
2560         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
2561         by a WM_RBUTTONUP message.
2562         
2563         * DumpRenderTree/win/UIDelegate.cpp:
2564         (UIDelegate::hasCustomMenuImplementation):
2565         (UIDelegate::trackCustomPopupMenu):
2566         * DumpRenderTree/win/UIDelegate.h:
2567         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
2568         menu from being shown (and causing the DRT to hang).
2569
2570 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
2571
2572         Reviewed by Darin.
2573
2574         Fix DumpRenderTree ObjC bug comparing strings.
2575
2576         * DumpRenderTree/mac/ObjCController.m:
2577         (-[ObjCController identityIsEqual::]): Compare strings with string
2578         equality instead of identiy equality.
2579
2580 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2581
2582         Reviewed by Sam.
2583
2584         Reset the authorAndUserStylesEnabled preference
2585         back to YES for each test. Fixes the broken tests.
2586
2587         * DumpRenderTree/mac/DumpRenderTree.mm:
2588         (resetWebViewToConsistentStateBeforeTesting):
2589
2590 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
2591
2592         Reviewed by Adam.
2593
2594         - Drosera now displays the console window, although it cannot currently
2595         process JavaScript.
2596
2597         * Drosera/win/DebuggerClient.cpp: Shows the console window.
2598         (registerConsoleClass): Implemented.
2599         (consoleWndProc): Implemented.
2600         (DebuggerClient::onSize): Implemented.
2601         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
2602         new window.
2603         * Drosera/win/DebuggerClient.h: Added needed method and members for 
2604         creating and maintaining a new window.
2605         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
2606         lines of code to more appropriate places.
2607         (Drosera::handleCommand):
2608         (Drosera::initUI):
2609         (Drosera::onSize):
2610         (Drosera::attach):
2611
2612 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2613
2614         Reviewed by Dave Hyatt.
2615
2616         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
2617         
2618         Add support for disabling author and user styles for testing.
2619
2620         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2621         * DumpRenderTree/LayoutTestController.cpp:
2622         (setAuthorAndUserStylesEnabledCallback):
2623         (LayoutTestController::staticFunctions):
2624         * DumpRenderTree/LayoutTestController.h:
2625         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2626         (LayoutTestController::setAuthorAndUserStylesEnabled):
2627         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2628         (LayoutTestController::setAuthorAndUserStylesEnabled):
2629
2630 2007-11-26  Dan Bernstein  <mitz@apple.com>
2631
2632         - Tiger build fix.
2633
2634         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2635
2636 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
2637
2638         Reviewed by Maciej.
2639
2640         - Implemented displaying variables for Drosera on Win.
2641
2642         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
2643         that retrieve variables to not hold onto the return value since it's
2644         not returned.  Also changed to use the new signatures of the retrieval
2645         functions.
2646         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2647         (DebuggerDocument::platformValueForScopeVariableNamed):
2648         * Drosera/win/Drosera.cpp: Removed a needless TODO.
2649         (droseraWndProc):
2650
2651 2007-11-26  Sam Weinig  <sam@webkit.org>
2652
2653         Cleanup names of painting and repainting functions.
2654
2655         Reviewed by Adam Roben.
2656
2657         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2658         (drawSelectionRect): was drawSelectionRectIntoContext.
2659         (dumpWebViewAsPixelsAndCompareWithExpected):
2660         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2661         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2662         (paintWebView): was drawWebViewIntoContext.
2663         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
2664
2665 2007-11-26  Sam Weinig  <sam@webkit.org>
2666
2667         Reviewed by Dan Bernstein.
2668
2669         - Leopard build fix
2670
2671         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2672
2673 2007-11-26  Sam Weinig  <sam@webkit.org>
2674
2675         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
2676         Use shared PixelDumpSupport for Mac DRT
2677
2678         Reviewed by Adam Roben.
2679
2680         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2681         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
2682         * DumpRenderTree/cg/ImageDiffCG.cpp:
2683         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2684         (drawSelectionRectIntoContext):
2685         (dumpWebViewAsPixelsAndCompareWithExpected):
2686         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2687         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2688         * DumpRenderTree/mac/DumpRenderTree.mm:
2689         (dump):
2690         * DumpRenderTree/mac/ImageDiff.m: Removed.
2691         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
2692         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
2693         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
2694         (setDefaultColorProfileToRGB):
2695         (getBitmapContextFromWebView):
2696         (drawWebViewIntoContext):
2697         (repaintWithVerticalSweep):
2698         (repaintWithHorizontalSweep):
2699         (getSelectionRect):
2700         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
2701
2702 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
2703
2704         Bug 16052: prepare-ChangeLog doesn't report deleted files
2705         <http://bugs.webkit.org/show_bug.cgi?id=16052>
2706
2707         Reviewed by Sam.
2708
2709         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
2710
2711 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
2712
2713         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
2714         <http://bugs.webkit.org/show_bug.cgi?id=15864>
2715
2716         Reviewed by Adam.
2717
2718         Roll functionality of merge-changelog into resolve-ChangeLogs
2719         script.  The script now checks for ChangeLog.rej and
2720         ChangeLog.orig files first.  If it finds them, it uses the
2721         ChangeLog.rej file as a patch (in old contextual diff format) to
2722         apply with --fuzz=3.
2723
2724         * Scripts/merge-changelog: Removed.
2725         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2726
2727 2007-11-25  Sam Weinig  <sam@webkit.org>
2728
2729         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
2730
2731         Reviewed by Mark Rowe.
2732
2733         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2734         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2735         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2736         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
2737         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
2738
2739 2007-11-25  Sam Weinig  <sam@webkit.org>
2740
2741         Convert DumpRenderTree to ues .xcconfig files.
2742
2743         Reviewed by Mark Rowe.
2744
2745         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2746         * DumpRenderTree/mac/Configurations: Added.
2747         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2748         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2749         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2750
2751 2007-11-25  Sam Weinig  <sam@webkit.org>
2752
2753         Add ForwardingHeaders to wtf for DumpRenderTree.
2754
2755         Reviewed by Mark Rowe.
2756
2757         * DumpRenderTree/DumpRenderTree.h:
2758         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2759         * DumpRenderTree/ForwardingHeaders: Added.
2760         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2761         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2762         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2763         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2764         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2765         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2766         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2767         * DumpRenderTree/LayoutTestController.cpp:
2768         * DumpRenderTree/WorkQueue.cpp:
2769         * DumpRenderTree/mac/DumpRenderTree.mm:
2770         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2771         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2772         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2773         * DumpRenderTree/mac/ObjCController.m:
2774         * DumpRenderTree/mac/UIDelegate.mm:
2775         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2776
2777 2007-11-25  Adam Roben  <aroben@apple.com>
2778
2779         Fix some test failures caused by r28019
2780
2781         Now that stdout is in binary mode, we need to always use printf
2782         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2783         the output.
2784
2785         Reviewed by Sam.
2786
2787         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2788         printf.
2789         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2790         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2791         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2792         (UIDelegate::webViewAddMessageToConsole):
2793
2794 2007-11-25  Adam Roben  <aroben@apple.com>
2795
2796         Set the font smoothing preference in DRT
2797
2798         This makes the pixel results on Windows closer to the Mac results.
2799
2800         Reviewed by Mitz.
2801
2802         * DumpRenderTree/win/DumpRenderTree.cpp:
2803         (initializePreferences):
2804
2805 2007-11-25  Adam Roben  <aroben@apple.com>
2806
2807         Port ImageDiff to CG and C++
2808
2809         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2810         <rdar://5071708>
2811
2812         Reviewed by Sam.
2813
2814         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2815         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2816         (main):
2817         (createImageFromStdin):
2818         (compareImages):
2819         (getDifferenceBitmap):
2820         (computePercentageDifferent):
2821         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2822
2823 2007-11-25  Adam Roben  <aroben@apple.com>
2824
2825         Fix image diff link generation on Windows
2826
2827         Reviewed by Sam.
2828
2829         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2830         to toURL.
2831
2832 2007-11-25  Adam Roben  <aroben@apple.com>
2833
2834         Implement pixel dumping in Windows DRT
2835
2836         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2837         <rdar://5071708>
2838
2839         Reviewed by Sam.
2840
2841         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2842         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2843         Content-Length header.
2844         (getMD5HashStringForBitmap):
2845         (dumpWebViewAsPixelsAndCompareWithExpected):
2846         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2847         * DumpRenderTree/win/DumpRenderTree.cpp:
2848         (dump): Do a pixel dump if requested.
2849         (main): Parse pixel test options.
2850         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2851         the cg/ subdirectory to the include path.
2852         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2853         available in a header or import library, so we have to go through this
2854         LoadLibrary/GetProcAddress dance to use them.
2855         (cryptDLL):
2856         (init):
2857         (update):
2858         (final):
2859         (MD5_Init):
2860         (MD5_Update):
2861         (MD5_Final):
2862         * DumpRenderTree/win/MD5.h: Added.
2863         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2864         moved up to the top level to share it with Mac eventually.
2865         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2866         (getBitmapContextFromWebView): Forces the WebView to paint using a
2867         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2868
2869 2007-11-25  Adam Roben  <aroben@apple.com>
2870
2871         Clean up Windows DRT's option parsing a little bit
2872
2873         Reviewed by Sam.
2874
2875         * DumpRenderTree/win/DumpRenderTree.cpp:
2876         (main): Put non-option arguments into a Vector.
2877
2878 2007-11-25  Adam Roben  <aroben@apple.com>
2879
2880         Make Windows DRT stop changing LF into CRLF
2881
2882         Reviewed by Sam.
2883
2884         * DumpRenderTree/win/DumpRenderTree.cpp:
2885         (main): Put stdout in binary mode.
2886         * Scripts/run-webkit-tests: Remove the CRLF hack.
2887
2888 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2889
2890         Removed empty directory.
2891
2892         * Scripts/resources: Removed.
2893
2894 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2895
2896         Fix bisect-builds to work with recent WebKit nightly builds.
2897
2898         Reviewed by Dan.
2899
2900         * Scripts/bisect-builds: Check for the 
2901         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2902         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2903         to WebKit.app/Contents/Resources.
2904
2905 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2906
2907         Reviewed by Maciej.
2908
2909         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2910         not closed (affects digg.com)
2911
2912         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2913         one after finishing with a test to avoid having its delayed onload handler firing when
2914         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2915         but it helps somewhat.
2916
2917 2007-11-22  Mark Rowe  <mrowe@apple.com>
2918
2919         Reviewed by Alp Toker.
2920
2921         Fix build-webkit to propagate make's exit status if it fails.
2922
2923         * Scripts/webkitdirs.pm:
2924
2925 2007-11-22  Dan Bernstein  <mitz@apple.com>
2926
2927         Reviewed by Mark Rowe.
2928
2929         - fix crash when running pixel tests
2930
2931         * DumpRenderTree/mac/DumpRenderTree.mm:
2932         (dumpRenderTree): Parse the command line options before setting up the
2933         environment so that we know if we need to set up the pixel dump
2934         machinery.
2935
2936 2007-11-21  Eric Seidel  <eric@webkit.org>
2937
2938         Speculative build fix for Tiger.
2939
2940         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2941
2942 2007-11-21  Eric Seidel  <eric@webkit.org>
2943
2944         Reviewed by Tim Hatcher.
2945
2946         Break out more of DumpRenderTree.mm into individual files
2947
2948         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2949         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2950         (checkedMalloc):
2951         (checkedRealloc):
2952         (makeLargeMallocFailSilently):
2953         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2954         * DumpRenderTree/mac/DumpRenderTree.mm:
2955         (crashHandler):
2956         (dump):
2957         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2958         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2959         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2960         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2961         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2962         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2963         (javaScriptThreads):
2964         (runJavaScriptThread):
2965         (startJavaScriptThreads):
2966         (stopJavaScriptThreads):
2967         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2968         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2969         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2970         (restoreColorSpace):
2971         (setDefaultColorProfileToRGB):
2972         (initializeColorSpaceAndScreeBufferForPixelTests):
2973         (md5HashStringForBitmap):
2974         (dumpWebViewAsPixelsAndCompareWithExpected):
2975
2976 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2977
2978         Move install-unix-extras to wx directory as it seems only to be used by that 
2979         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2980         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2981         have install-unix-extras install into WebKitLibraries as per
2982         convention.
2983         
2984         Reviewed by Mark Rowe.
2985
2986         * Scripts/install-unix-extras: Removed.
2987         * wx/build-wxwebkit:
2988         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2989
2990 2007-11-21  Eric Seidel  <eric@webkit.org>
2991
2992         Reviewed by Adam.
2993
2994         More refactoring for greater code readability
2995
2996         * DumpRenderTree/mac/DumpRenderTree.mm:
2997         (initializeGlobalsFromCommandLineOptions):
2998         (initializeColorSpaceAndScreeBufferForPixelTests):
2999         (addTestPluginsToPluginSearchPath):
3000         (useLongRunningServerMode):
3001         (runTestingServerLoop):
3002         (prepareConsistentTestingEnvironment):
3003         (dumpRenderTree):
3004         (main):
3005         (dumpFramesAsText):
3006         (dumpBackForwardListForWebView):
3007         (sizeWebViewForCurrentTest):
3008         (methodNameStringForFailedTest):
3009         (dumpBackForwardListForAllWindows):
3010         (dumpWebViewAsPixelsAndCompareWithExpected):
3011         (invalidateAnyPreviousWaitToDumpWatchdog):
3012         (dump):
3013         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3014         * DumpRenderTree/mac/UIDelegate.mm:
3015         (-[UIDelegate webView:createWebViewWithRequest:]):
3016
3017 2007-11-21  Eric Seidel  <eric@webkit.org>
3018
3019         Reviewed by Tim Hatcher.
3020
3021         Abstract more of DRT into static methods
3022
3023         * DumpRenderTree/mac/DumpRenderTree.mm:
3024         (setDefaultsToConsistentValuesForTesting):
3025         (setupSignalHandlers):
3026         (allocateGlobalControllers):
3027         (releaseAndZero):
3028         (releaseGlobalControllers):
3029         (dumpRenderTree):
3030         (shouldLogFrameLoadDelegates):
3031         (createCFURLFromPathOrURL):
3032         (resetWebViewToConsistentStateBeforeTesting):
3033         (runTest):
3034
3035 2007-11-21  Eric Seidel  <eric@webkit.org>
3036
3037         Reviewed by Tim Hatcher.
3038
3039         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
3040
3041         * DumpRenderTree/DumpRenderTree.h:
3042         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3043         * DumpRenderTree/mac/DumpRenderTree.mm:
3044         (dumpRenderTree):
3045         (dump):
3046         (runTest):
3047         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
3048         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
3049         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
3050         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
3051         (-[DumpRenderTreePasteboard declareType:owner:]):
3052         (+[LocalPasteboard alloc]):
3053         (-[LocalPasteboard init]):
3054         (-[LocalPasteboard dealloc]):
3055         (-[LocalPasteboard name]):
3056         (-[LocalPasteboard releaseGlobally]):
3057         (-[LocalPasteboard declareTypes:owner:]):
3058         (-[LocalPasteboard addTypes:owner:]):
3059         (-[LocalPasteboard changeCount]):
3060         (-[LocalPasteboard types]):
3061         (-[LocalPasteboard availableTypeFromArray:]):
3062         (-[LocalPasteboard setData:forType:]):
3063         (-[LocalPasteboard dataForType:]):
3064         (-[LocalPasteboard setPropertyList:forType:]):
3065         (-[LocalPasteboard setString:forType:]):
3066         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
3067         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
3068         (+[DumpRenderTreeWindow allWindows]):
3069         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
3070         (-[DumpRenderTreeWindow dealloc]):
3071         (-[DumpRenderTreeWindow isKeyWindow]):
3072         (-[DumpRenderTreeWindow keyDown:]):
3073
3074 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
3075
3076         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
3077         it indiscriminately copies any headers inside JavaScriptCore,
3078         which includes Tiger ICU headers. 
3079
3080         * wx/build-wxwebkit:
3081         Don't run WebCore/move-js-headers.sh any longer.
3082
3083 2007-11-20  Adam Treat  <treat@kde.org>
3084
3085         Reviewed by David Kilzer.
3086
3087         * Prepend git branch name to $baseProductDir
3088
3089         * Scripts/VCSUtils.pm:
3090         * Scripts/webkitdirs.pm:
3091
3092 2007-11-20  Mark Rowe  <mrowe@apple.com>
3093
3094         Reviewed by Simon Hausmann.
3095
3096         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
3097         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
3098         Have it trigger a "make distclean" rather than "make clean" to ensure that the
3099         built product and generated Makefile's are removed.
3100
3101 2007-11-19  Alp Toker  <alp@atoker.com>
3102
3103         Reviewed by Mark Rowe.
3104
3105         http://bugs.webkit.org/show_bug.cgi?id=16040
3106         [GTK] GtkLauncher should be written in C
3107
3108         Port GtkLauncher to plain C.
3109
3110         Use a more conventional GTK+ coding style.
3111
3112         Use a toolbar instead of menus.
3113
3114         Various signature fixes and cleanups.
3115
3116         Add a license header. Assume all previous modifications were copyright
3117         assigned to Apple Inc. by default.
3118
3119         * GtkLauncher/GtkLauncher.pro:
3120         * GtkLauncher/main.c: Added.
3121         (activate_url_entry_cb):
3122         (update_title):
3123         (link_hover_cb):
3124         (title_change_cb):
3125         (progress_change_cb):
3126         (destroy_cb):
3127         (go_back_cb):
3128         (go_forward_cb):
3129         (create_browser):
3130         (create_statusbar):
3131         (create_toolbar):
3132         (create_window):
3133         (main):
3134         * GtkLauncher/main.cpp: Removed.
3135
3136 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
3137
3138         Build script fixes to ensure they do the right thing for the 
3139         wx port, and update build-wxwebkit to reflect the way the
3140         build scripts now work.
3141
3142         Reviewed by Adam.
3143
3144         * Scripts/build-testkjs:
3145         * Scripts/build-webkit:
3146         * Scripts/run-javascriptcore-tests:
3147         * Scripts/webkitdirs.pm:
3148         * wx/build-wxwebkit:
3149
3150 2007-11-18  Eric Seidel  <eric@webkit.org>
3151
3152         Reviewed by Anders.
3153
3154         Make run-javascriptcore-tests report failures on exit (to support git bisect)
3155
3156         * Scripts/run-javascriptcore-tests:
3157
3158 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
3159
3160         Reviewed by Adam Roben.
3161
3162         Make run-webkit-tests work with Windows debug build.
3163
3164         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
3165         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
3166         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
3167         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
3168         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
3169
3170 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
3171
3172         Add wxWebKit sample and build script, and integrate it with 
3173         build-webkit. Also make build-webkit --clean work for all
3174         ports.
3175
3176         Reviewed by Darin Adler.
3177
3178         * Scripts/build-webkit:
3179         * Scripts/webkitdirs.pm:
3180         * wx: Added.
3181         * wx/browser: Added.
3182         * wx/browser/browser.bkl: Added.
3183         * wx/browser/browser.cpp: Added.
3184         * wx/build-wxwebkit: Added.
3185
3186 2007-11-17  Adam Roben  <aroben@apple.com>
3187
3188         Make it easy to run Safari in the debugger on Windows
3189
3190         I've added a new script, debug-safari, which launches Safari in the
3191         debugger. On OS X it just calls gdb-safari.
3192
3193         Reviewed by Mark Rowe.
3194
3195         * FindSafari/FindSafari.cpp:
3196         (_tmain): Added a /debugger flag, which in combination with
3197         /printSafariLauncher will print a script that launches Safari in the
3198         debugger.
3199         * Scripts/debug-safari: Added.
3200         * Scripts/run-safari: Changed to call runSafari().
3201         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
3202         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
3203         first argument along to FindSafari.
3204         * Scripts/webkitdirs.pm:
3205         (sub runSafari): Added.
3206
3207 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
3208
3209         Reviewed by Adam Roben.
3210
3211         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
3212
3213 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
3214
3215         Reviewed by David Kilzer.
3216
3217         The git config command was renamed to repo-config at some point. This
3218         change tries git config and then git repo-config if the first fails.
3219
3220         * Scripts/prepare-ChangeLog:
3221         (gitConfig):
3222
3223 2007-11-16  Dan Bernstein  <mitz@apple.com>
3224
3225         Reviewed by Darin Adler and Sam Weinig.
3226
3227         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
3228
3229         * DumpRenderTree/win/EventSender.cpp:
3230         (keyDownCallback): For characters that cannot be entered on the active
3231         keyboard layout, send a WM_CHAR message with the character along with
3232         a WM_KEYDOWN message with a virtual key code of 255.
3233
3234 2007-11-16  Mark Rowe  <mrowe@apple.com>
3235
3236         Reviewed by Tim Hatcher.
3237
3238         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
3239
3240         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3241         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3242
3243 2007-11-15  Adam Roben  <aroben@apple.com>
3244
3245         Make run-safari actually work on Windows
3246
3247         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
3248         chdir call.
3249
3250 2007-11-14  Adam Roben  <aroben@apple.com>
3251
3252         Updates to Safari launching now that 3.0.4 is released
3253
3254         Reviewed by Sam.
3255
3256         * FindSafari/FindSafari.cpp:
3257         (getWebViewCLSID): Use version-independent ProgID.
3258         * Scripts/run-safari: Use run-webkit-nightly.cmd.
3259
3260 2007-11-14  Anders Carlsson  <andersca@apple.com>
3261
3262         Reviewed by Adam.
3263
3264         <rdar://problem/5309081>
3265         In DRT, "plugin.logDestroy = true" not working on Windows.
3266         
3267         * DumpRenderTree/win/TestNetscapePlugin/main.c:
3268         (NPP_Destroy):
3269
3270 2007-11-14  Eric Seidel  <eric@webkit.org>
3271
3272         Reviewed by Sam.
3273
3274         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
3275
3276 2007-11-14  Anders Carlsson  <andersca@apple.com>
3277
3278         Reviewed by Adam.
3279
3280         <rdar://problem/5141186>
3281         window.layoutTestController.setWindowIsKey is not implemented in DRT.
3282         
3283         Implement setWindowIsKey.
3284         
3285         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3286         (LayoutTestController::setWindowIsKey):
3287
3288 2007-11-13  Sam Weinig  <sam@webkit.org>
3289
3290         Reviewed by Adam Roben.
3291
3292         Fix for <rdar://problem/5382579>
3293         http/tests/security/cross-frame-access-put.html reports large 
3294         negative numbers for screenLeft and screenTop (Mac reports "0")
3295
3296         * DumpRenderTree/win/UIDelegate.cpp:
3297         (UIDelegate::UIDelegate): Initialize the RECT.
3298         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
3299         (UIDelegate::webViewFrame): ditto.
3300         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
3301
3302 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
3303
3304         Reviewed by Adam.
3305
3306         - Make Drosera show source, source URLs, and function stack on Windows,
3307         and some minor fixes.
3308
3309         * Drosera/DebuggerDocument.cpp: Force source to always update display.
3310         (DebuggerDocument::updateFileSource):
3311         * Drosera/debugger.js: Force source to always update display.
3312         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
3313         menu controls.
3314         (DebuggerClient::resume):
3315         (DebuggerClient::pause):
3316         (DebuggerClient::stepInto):
3317         (DebuggerClient::stepOver):
3318         (DebuggerClient::stepOut):
3319         (DebuggerClient::showConsole):
3320         (DebuggerClient::closeCurrentFile):
3321         * Drosera/win/DebuggerClient.h: Ditto.
3322         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
3323         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
3324         removed two bugs.  1) caller could be in a bad state when asked to
3325         assign into it. 2) BSTRs were not created correctly.
3326         (DebuggerDocument::getPlatformCurrentFunctionStack):
3327         * Drosera/win/Drosera.cpp: Hook up the menu controls.
3328         (droseraWndProc):
3329         (handleCommand):
3330         (Drosera::resume):
3331         (Drosera::pause):
3332         (Drosera::stepInto):
3333         (Drosera::stepOver):
3334         (Drosera::stepOut):
3335         (Drosera::showConsole):
3336         (Drosera::closeCurrentFile):
3337         * Drosera/win/Drosera.h: Hook up the menu controls.
3338         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
3339         functions, added a null check, and fixed another bug where caller could
3340         be in a bad state when asked to assign into it.
3341         (ServerConnection::didLoadMainResourceForDataSource):
3342         (ServerConnection::getCallerFrame):
3343         * Drosera/win/ServerConnection.h: Safety first.
3344
3345 2007-11-13  Dan Bernstein  <mitz@apple.com>
3346
3347         Reviewed by Darin Adler.
3348
3349         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
3350           DumpRenderTree --pixel-tests renders each test twice
3351
3352         * DumpRenderTree/mac/DumpRenderTree.mm:
3353         (dumpRenderTree): Removed the --paint option because the painting code
3354         is always exercised as a result of
3355         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
3356         calling -displayIfNeeded.
3357         (dump): Changed to always grab the image from the window since the view
3358         is always displayed.
3359         (runTest):
3360         (displayWebView):
3361         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
3362         because it always paints.
3363
3364 2007-11-12  Antti Koivisto  <antti@apple.com>
3365
3366         Reviewed by Adele.
3367         
3368         Add support for http media tests
3369
3370         * Scripts/run-webkit-tests:
3371
3372 2007-11-12  Sam Weinig  <sam@webkit.org>
3373
3374         Reviewed by Adam Roben.
3375
3376         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
3377
3378         * DumpRenderTree/win/DumpRenderTree.cpp:
3379         (runTest):
3380         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3381         (LayoutTestController::setPrivateBrowsingEnabled):
3382
3383 2007-11-12  Adam Roben  <aroben@apple.com>
3384
3385         * Scripts/update-webkit-localizable-strings: Changed to only scan the
3386         mac and win subdirectories.
3387
3388 2007-11-11  Adam Roben  <aroben@apple.com>
3389
3390         Fix <rdar://5133816> keepWebHistory is not implemented
3391
3392         Fixes fast/history/clicked-link-is-visited.html.
3393
3394         Reviewed by Darin.
3395
3396         * DumpRenderTree/win/DumpRenderTree.cpp:
3397         (runTest): Clear the optionalSharedHistory.
3398         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3399         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
3400
3401 2007-11-10  Sam Weinig  <sam@webkit.org>
3402
3403         Reviewed by Tim Hatcher.
3404
3405         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
3406         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
3407         is turned on)
3408
3409         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
3410
3411         Added test: http/tests/security/cross-frame-access-private-browsing.html
3412
3413         * DumpRenderTree/LayoutTestController.cpp:
3414         (setPrivateBrowsingEnabledCallback):
3415         (LayoutTestController::staticFunctions):
3416         * DumpRenderTree/LayoutTestController.h:
3417         * DumpRenderTree/mac/DumpRenderTree.mm:
3418         (runTest): Default to private browsing disabled.
3419         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3420         (LayoutTestController::setPrivateBrowsingEnabled):
3421         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3422         (LayoutTestController::setPrivateBrowsingEnabled):
3423
3424 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3425
3426         Reviewed by Adam.
3427
3428         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
3429         WebCore's!
3430
3431         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3432         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
3433         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3434         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3435         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
3436         * Drosera/win/Drosera.cpp:
3437         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3438
3439 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3440
3441         Reviewed by Sam.
3442
3443         - Use the new IWebFrame [local] function signature and get the shared
3444         server correctly.
3445
3446         * Drosera/win/DebuggerClient.cpp:
3447         (DebuggerClient::didFinishLoadForFrame):
3448         * Drosera/win/ServerConnection.cpp:
3449         (ServerConnection::attemptToCreateServerConnection):
3450
3451 2007-11-07  Dan Bernstein  <mitz@apple.com>
3452
3453         Reviewed by Darin Adler.
3454
3455         - add an option to run-webkit-tests to ignore pixel test failures where
3456           all pixels differ by no more than a specified threshold
3457
3458         * DumpRenderTree/mac/ImageDiff.m:
3459         (main):
3460         (compareImages):
3461         (computePercentageDifferent):
3462         * Scripts/run-webkit-tests:
3463
3464 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3465
3466         Reviewed by Lars.
3467
3468         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
3469
3470         * DumpRenderTree/qt/DumpRenderTree.cpp:
3471
3472 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3473
3474         Reviewed by Lars.
3475
3476         Reworked the QWebSettings API.
3477         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
3478
3479         * DumpRenderTree/qt/DumpRenderTree.cpp:
3480
3481 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3482
3483         Reviewed by Lars.
3484
3485         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
3486
3487         * DumpRenderTree/qt/jsobjects.cpp:
3488
3489 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3490
3491         Reviewed by Lars Knoll <lars@trolltech.com>.
3492
3493         Add a QWebPage::frameCreated() signal and fix DRT
3494         
3495         The removal of createFrame in QWebPage broke the re-implementation
3496         in DumpRenderTree. Instead emit a frameCreated() signal and
3497         connect to it in DumpRenderTree.
3498         
3499
3500         * DumpRenderTree/qt/DumpRenderTree.cpp:
3501         (WebCore::WebPage::WebPage):
3502         (WebCore::DumpRenderTree::dump):
3503         (WebCore::DumpRenderTree::connectFrame):
3504         * DumpRenderTree/qt/DumpRenderTree.h:
3505
3506 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3507
3508         Reviewed by Lars Knoll <lars@trolltech.com>.
3509
3510         Moved all the event handlers from QWebFrame into QWebPage.
3511         
3512         This cleans up the public API and allows us to remove the
3513         HackWebFrame hack in DumpRenderTree.
3514         
3515
3516         * DumpRenderTree/qt/jsobjects.cpp:
3517         (EventSender::mouseDown):
3518         (EventSender::mouseUp):
3519         (EventSender::mouseMoveTo):
3520
3521 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3522
3523         Reviewed by Mark.
3524
3525         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
3526         to prevent the default implementation from popping up messageboxes.
3527
3528         * DumpRenderTree/qt/DumpRenderTree.cpp:
3529         (WebCore::WebPage::javaScriptConfirm):
3530         (WebCore::WebPage::javaScriptPrompt):
3531
3532 2007-11-06  Eric Seidel  <eric@webkit.org>
3533
3534         * Scripts/build-testkjs: build fix... too many $$
3535
3536 2007-11-06  Eric Seidel  <eric@webkit.org>
3537
3538         Reviewed by Mark Rowe.
3539
3540         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
3541
3542 2007-11-05  Adam Roben  <aroben@apple.com>
3543
3544         Add support on Windows for WEBKIT_TESTFONTS
3545
3546         This environment variable lets you specify where the fonts to be used
3547         by DumpRenderTree reside. The Qt port is already using this, so I'm
3548         just following their lead.
3549
3550         Reviewed by Darin.
3551
3552         * DumpRenderTree/win/DumpRenderTree.cpp:
3553         (exePath): Refactored code out of initialize().
3554         (fontsPath): Returns either $WEBKIT_TESTFONTS or
3555         DumpRenderTree.resources.
3556         (initialize): Use the new fontsPath function.
3557         (main): Use the new exePath function.
3558         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
3559         variable to DRT, like Qt does.
3560
3561 2007-11-05  Mark Rowe  <mrowe@apple.com>
3562
3563         Rubber-stamped by Alp Toker.
3564
3565         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
3566
3567         * GtkLauncher/main.cpp:
3568         (goToURLBarText):
3569         (main):
3570
3571 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
3572
3573         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
3574         <http://bugs.webkit.org/show_bug.cgi?id=15830>
3575
3576         Reviewed by Timothy.
3577
3578         Restrict the range of nightly builds used by the bisect-builds script
3579         based on the version of Safari and the version of Mac OS X being used.
3580
3581         Mac OS X 10.4: Safari 2.0: r11976 or newer
3582         Mac OS X 10.4: Safari 3.0: r19992 or newer
3583
3584         Mac OS X 10.5: Safari 2.0: r19594 or newer
3585         Mac OS X 10.5: Safari 3.0: r25124 or newer
3586
3587         * Scripts/bisect-builds:
3588         (findMacOSXVersion): Added.
3589         (makeNightlyList): Added argument to provide version of Mac OS X.
3590         Restrict range of nightly builds based on Safari and Mac OS X versions.
3591
3592 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
3593
3594         Reviewed by Maciej.
3595
3596         - This patch involves several changes, all of them were noticed that
3597         they were needed by the work being done in WebKit to get Drosera and
3598         WebKit working together on Windows.
3599         - The changes are:
3600         1) Added a debugger console for output messages.
3601         2) Drosera now listens for the WebKit server (before, the server would
3602         have to be running before Drosera was started.)
3603         3) Fixed a bug where the WebView started out as 0x0 pixels.
3604         4) Fixed a bug when there is no scope.
3605         5) Added the HTML, JS, and CSS to the project file to make them easy to
3606         find.
3607         6) Made the ServerConnection functions virtual.
3608
3609         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
3610         for the WebKit server.
3611         (DebuggerClient::DebuggerClient):
3612         (DebuggerClient::~DebuggerClient):
3613         (DebuggerClient::didFinishLoadForFrame):
3614         (DebuggerClient::serverConnected):
3615         (DebuggerClient::attemptToCreateServerConnection):
3616         * Drosera/win/DebuggerClient.h: Ditto.
3617         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
3618         scope.
3619         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3620         (DebuggerDocument::platformValueForScopeVariableNamed):
3621         * Drosera/win/Drosera.cpp:
3622         (_tWinMain): Added a console in debug for output messages.
3623         (Drosera::Drosera): Listen for server.
3624         (Drosera::initUI): The server now Initializes COM.
3625         (Drosera::serverConnected): Part of the listening for the server.
3626         (Drosera::attemptToCreateServerConnection): Ditto.
3627         * Drosera/win/Drosera.h: New interface for listening for the server.
3628         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
3629         files to the VS project.
3630         * Drosera/win/ServerConnection.cpp: Part of listening for the server
3631         connection.
3632         (ServerConnection::ServerConnection):
3633         (ServerConnection::attemptToCreateServerConnection):
3634         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
3635         methods.
3636         (ServerConnection::serverConnected):
3637
3638 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
3639
3640         Reviewed by Maciej.
3641
3642         http://bugs.webkit.org/show_bug.cgi?id=15832
3643         fast/dom/gc-10.html crashes when run alone
3644
3645         Check for !done before using objects that can be already deallocated.
3646
3647         * DumpRenderTree/mac/EditingDelegate.mm:
3648         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3649         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3650         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3651         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3652         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3653         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3654         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3655         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3656         (-[EditingDelegate webViewDidBeginEditing:]):
3657         (-[EditingDelegate webViewDidChange:]):
3658         (-[EditingDelegate webViewDidEndEditing:]):
3659         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3660         (-[EditingDelegate webViewDidChangeSelection:]):
3661         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3662         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):