9108e507796dc7e805fc483ec493f4dfc0f5a0bc
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2
3         Move install-unix-extras to wx directory as it seems only to be used by that 
4         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
5         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
6         have install-unix-extras install into WebKitLibraries as per
7         convention.
8         
9         Reviewed by Mark Rowe.
10
11         * Scripts/install-unix-extras: Removed.
12         * wx/build-wxwebkit:
13         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
14
15 2007-11-21  Eric Seidel  <eric@webkit.org>
16
17         Reviewed by Adam.
18
19         More refactoring for greater code readability
20
21         * DumpRenderTree/mac/DumpRenderTree.mm:
22         (initializeGlobalsFromCommandLineOptions):
23         (initializeColorSpaceAndScreeBufferForPixelTests):
24         (addTestPluginsToPluginSearchPath):
25         (useLongRunningServerMode):
26         (runTestingServerLoop):
27         (prepareConsistentTestingEnvironment):
28         (dumpRenderTree):
29         (main):
30         (dumpFramesAsText):
31         (dumpBackForwardListForWebView):
32         (sizeWebViewForCurrentTest):
33         (methodNameStringForFailedTest):
34         (dumpBackForwardListForAllWindows):
35         (dumpWebViewAsPixelsAndCompareWithExpected):
36         (invalidateAnyPreviousWaitToDumpWatchdog):
37         (dump):
38         * DumpRenderTree/mac/DumpRenderTreeMac.h:
39         * DumpRenderTree/mac/UIDelegate.mm:
40         (-[UIDelegate webView:createWebViewWithRequest:]):
41
42 2007-11-21  Eric Seidel  <eric@webkit.org>
43
44         Reviewed by Tim Hatcher.
45
46         Abstract more of DRT into static methods
47
48         * DumpRenderTree/mac/DumpRenderTree.mm:
49         (setDefaultsToConsistentValuesForTesting):
50         (setupSignalHandlers):
51         (allocateGlobalControllers):
52         (releaseAndZero):
53         (releaseGlobalControllers):
54         (dumpRenderTree):
55         (shouldLogFrameLoadDelegates):
56         (createCFURLFromPathOrURL):
57         (resetWebViewToConsistentStateBeforeTesting):
58         (runTest):
59
60 2007-11-21  Eric Seidel  <eric@webkit.org>
61
62         Reviewed by Tim Hatcher.
63
64         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
65
66         * DumpRenderTree/DumpRenderTree.h:
67         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
68         * DumpRenderTree/mac/DumpRenderTree.mm:
69         (dumpRenderTree):
70         (dump):
71         (runTest):
72         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
73         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
74         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
75         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
76         (-[DumpRenderTreePasteboard declareType:owner:]):
77         (+[LocalPasteboard alloc]):
78         (-[LocalPasteboard init]):
79         (-[LocalPasteboard dealloc]):
80         (-[LocalPasteboard name]):
81         (-[LocalPasteboard releaseGlobally]):
82         (-[LocalPasteboard declareTypes:owner:]):
83         (-[LocalPasteboard addTypes:owner:]):
84         (-[LocalPasteboard changeCount]):
85         (-[LocalPasteboard types]):
86         (-[LocalPasteboard availableTypeFromArray:]):
87         (-[LocalPasteboard setData:forType:]):
88         (-[LocalPasteboard dataForType:]):
89         (-[LocalPasteboard setPropertyList:forType:]):
90         (-[LocalPasteboard setString:forType:]):
91         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
92         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
93         (+[DumpRenderTreeWindow allWindows]):
94         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
95         (-[DumpRenderTreeWindow dealloc]):
96         (-[DumpRenderTreeWindow isKeyWindow]):
97         (-[DumpRenderTreeWindow keyDown:]):
98
99 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
100
101         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
102         it indiscriminately copies any headers inside JavaScriptCore,
103         which includes Tiger ICU headers. 
104
105         * wx/build-wxwebkit:
106         Don't run WebCore/move-js-headers.sh any longer.
107
108 2007-11-20  Adam Treat  <treat@kde.org>
109
110         Reviewed by David Kilzer.
111
112         * Prepend git branch name to $baseProductDir
113
114         * Scripts/VCSUtils.pm:
115         * Scripts/webkitdirs.pm:
116
117 2007-11-20  Mark Rowe  <mrowe@apple.com>
118
119         Reviewed by Simon Hausmann.
120
121         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
122         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
123         Have it trigger a "make distclean" rather than "make clean" to ensure that the
124         built product and generated Makefile's are removed.
125
126 2007-11-19  Alp Toker  <alp@atoker.com>
127
128         Reviewed by Mark Rowe.
129
130         http://bugs.webkit.org/show_bug.cgi?id=16040
131         [GTK] GtkLauncher should be written in C
132
133         Port GtkLauncher to plain C.
134
135         Use a more conventional GTK+ coding style.
136
137         Use a toolbar instead of menus.
138
139         Various signature fixes and cleanups.
140
141         Add a license header. Assume all previous modifications were copyright
142         assigned to Apple Inc. by default.
143
144         * GtkLauncher/GtkLauncher.pro:
145         * GtkLauncher/main.c: Added.
146         (activate_url_entry_cb):
147         (update_title):
148         (link_hover_cb):
149         (title_change_cb):
150         (progress_change_cb):
151         (destroy_cb):
152         (go_back_cb):
153         (go_forward_cb):
154         (create_browser):
155         (create_statusbar):
156         (create_toolbar):
157         (create_window):
158         (main):
159         * GtkLauncher/main.cpp: Removed.
160
161 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
162
163         Build script fixes to ensure they do the right thing for the 
164         wx port, and update build-wxwebkit to reflect the way the
165         build scripts now work.
166
167         Reviewed by Adam.
168
169         * Scripts/build-testkjs:
170         * Scripts/build-webkit:
171         * Scripts/run-javascriptcore-tests:
172         * Scripts/webkitdirs.pm:
173         * wx/build-wxwebkit:
174
175 2007-11-18  Eric Seidel  <eric@webkit.org>
176
177         Reviewed by Anders.
178
179         Make run-javascriptcore-tests report failures on exit (to support git bisect)
180
181         * Scripts/run-javascriptcore-tests:
182
183 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
184
185         Reviewed by Adam Roben.
186
187         Make run-webkit-tests work with Windows debug build.
188
189         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
190         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
191         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
192         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
193         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
194
195 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
196
197         Add wxWebKit sample and build script, and integrate it with 
198         build-webkit. Also make build-webkit --clean work for all
199         ports.
200
201         Reviewed by Darin Adler.
202
203         * Scripts/build-webkit:
204         * Scripts/webkitdirs.pm:
205         * wx: Added.
206         * wx/browser: Added.
207         * wx/browser/browser.bkl: Added.
208         * wx/browser/browser.cpp: Added.
209         * wx/build-wxwebkit: Added.
210
211 2007-11-17  Adam Roben  <aroben@apple.com>
212
213         Make it easy to run Safari in the debugger on Windows
214
215         I've added a new script, debug-safari, which launches Safari in the
216         debugger. On OS X it just calls gdb-safari.
217
218         Reviewed by Mark Rowe.
219
220         * FindSafari/FindSafari.cpp:
221         (_tmain): Added a /debugger flag, which in combination with
222         /printSafariLauncher will print a script that launches Safari in the
223         debugger.
224         * Scripts/debug-safari: Added.
225         * Scripts/run-safari: Changed to call runSafari().
226         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
227         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
228         first argument along to FindSafari.
229         * Scripts/webkitdirs.pm:
230         (sub runSafari): Added.
231
232 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
233
234         Reviewed by Adam Roben.
235
236         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
237
238 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
239
240         Reviewed by David Kilzer.
241
242         The git config command was renamed to repo-config at some point. This
243         change tries git config and then git repo-config if the first fails.
244
245         * Scripts/prepare-ChangeLog:
246         (gitConfig):
247
248 2007-11-16  Dan Bernstein  <mitz@apple.com>
249
250         Reviewed by Darin Adler and Sam Weinig.
251
252         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
253
254         * DumpRenderTree/win/EventSender.cpp:
255         (keyDownCallback): For characters that cannot be entered on the active
256         keyboard layout, send a WM_CHAR message with the character along with
257         a WM_KEYDOWN message with a virtual key code of 255.
258
259 2007-11-16  Mark Rowe  <mrowe@apple.com>
260
261         Reviewed by Tim Hatcher.
262
263         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
264
265         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
266         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
267
268 2007-11-15  Adam Roben  <aroben@apple.com>
269
270         Make run-safari actually work on Windows
271
272         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
273         chdir call.
274
275 2007-11-14  Adam Roben  <aroben@apple.com>
276
277         Updates to Safari launching now that 3.0.4 is released
278
279         Reviewed by Sam.
280
281         * FindSafari/FindSafari.cpp:
282         (getWebViewCLSID): Use version-independent ProgID.
283         * Scripts/run-safari: Use run-webkit-nightly.cmd.
284
285 2007-11-14  Anders Carlsson  <andersca@apple.com>
286
287         Reviewed by Adam.
288
289         <rdar://problem/5309081>
290         In DRT, "plugin.logDestroy = true" not working on Windows.
291         
292         * DumpRenderTree/win/TestNetscapePlugin/main.c:
293         (NPP_Destroy):
294
295 2007-11-14  Eric Seidel  <eric@webkit.org>
296
297         Reviewed by Sam.
298
299         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
300
301 2007-11-14  Anders Carlsson  <andersca@apple.com>
302
303         Reviewed by Adam.
304
305         <rdar://problem/5141186>
306         window.layoutTestController.setWindowIsKey is not implemented in DRT.
307         
308         Implement setWindowIsKey.
309         
310         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
311         (LayoutTestController::setWindowIsKey):
312
313 2007-11-13  Sam Weinig  <sam@webkit.org>
314
315         Reviewed by Adam Roben.
316
317         Fix for <rdar://problem/5382579>
318         http/tests/security/cross-frame-access-put.html reports large 
319         negative numbers for screenLeft and screenTop (Mac reports "0")
320
321         * DumpRenderTree/win/UIDelegate.cpp:
322         (UIDelegate::UIDelegate): Initialize the RECT.
323         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
324         (UIDelegate::webViewFrame): ditto.
325         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
326
327 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
328
329         Reviewed by Adam.
330
331         - Make Drosera show source, source URLs, and function stack on Windows,
332         and some minor fixes.
333
334         * Drosera/DebuggerDocument.cpp: Force source to always update display.
335         (DebuggerDocument::updateFileSource):
336         * Drosera/debugger.js: Force source to always update display.
337         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
338         menu controls.
339         (DebuggerClient::resume):
340         (DebuggerClient::pause):
341         (DebuggerClient::stepInto):
342         (DebuggerClient::stepOver):
343         (DebuggerClient::stepOut):
344         (DebuggerClient::showConsole):
345         (DebuggerClient::closeCurrentFile):
346         * Drosera/win/DebuggerClient.h: Ditto.
347         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
348         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
349         removed two bugs.  1) caller could be in a bad state when asked to
350         assign into it. 2) BSTRs were not created correctly.
351         (DebuggerDocument::getPlatformCurrentFunctionStack):
352         * Drosera/win/Drosera.cpp: Hook up the menu controls.
353         (droseraWndProc):
354         (handleCommand):
355         (Drosera::resume):
356         (Drosera::pause):
357         (Drosera::stepInto):
358         (Drosera::stepOver):
359         (Drosera::stepOut):
360         (Drosera::showConsole):
361         (Drosera::closeCurrentFile):
362         * Drosera/win/Drosera.h: Hook up the menu controls.
363         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
364         functions, added a null check, and fixed another bug where caller could
365         be in a bad state when asked to assign into it.
366         (ServerConnection::didLoadMainResourceForDataSource):
367         (ServerConnection::getCallerFrame):
368         * Drosera/win/ServerConnection.h: Safety first.
369
370 2007-11-13  Dan Bernstein  <mitz@apple.com>
371
372         Reviewed by Darin Adler.
373
374         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
375           DumpRenderTree --pixel-tests renders each test twice
376
377         * DumpRenderTree/mac/DumpRenderTree.mm:
378         (dumpRenderTree): Removed the --paint option because the painting code
379         is always exercised as a result of
380         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
381         calling -displayIfNeeded.
382         (dump): Changed to always grab the image from the window since the view
383         is always displayed.
384         (runTest):
385         (displayWebView):
386         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
387         because it always paints.
388
389 2007-11-12  Antti Koivisto  <antti@apple.com>
390
391         Reviewed by Adele.
392         
393         Add support for http media tests
394
395         * Scripts/run-webkit-tests:
396
397 2007-11-12  Sam Weinig  <sam@webkit.org>
398
399         Reviewed by Adam Roben.
400
401         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
402
403         * DumpRenderTree/win/DumpRenderTree.cpp:
404         (runTest):
405         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
406         (LayoutTestController::setPrivateBrowsingEnabled):
407
408 2007-11-12  Adam Roben  <aroben@apple.com>
409
410         * Scripts/update-webkit-localizable-strings: Changed to only scan the
411         mac and win subdirectories.
412
413 2007-11-11  Adam Roben  <aroben@apple.com>
414
415         Fix <rdar://5133816> keepWebHistory is not implemented
416
417         Fixes fast/history/clicked-link-is-visited.html.
418
419         Reviewed by Darin.
420
421         * DumpRenderTree/win/DumpRenderTree.cpp:
422         (runTest): Clear the optionalSharedHistory.
423         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
424         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
425
426 2007-11-10  Sam Weinig  <sam@webkit.org>
427
428         Reviewed by Tim Hatcher.
429
430         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
431         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
432         is turned on)
433
434         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
435
436         Added test: http/tests/security/cross-frame-access-private-browsing.html
437
438         * DumpRenderTree/LayoutTestController.cpp:
439         (setPrivateBrowsingEnabledCallback):
440         (LayoutTestController::staticFunctions):
441         * DumpRenderTree/LayoutTestController.h:
442         * DumpRenderTree/mac/DumpRenderTree.mm:
443         (runTest): Default to private browsing disabled.
444         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
445         (LayoutTestController::setPrivateBrowsingEnabled):
446         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
447         (LayoutTestController::setPrivateBrowsingEnabled):
448
449 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
450
451         Reviewed by Adam.
452
453         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
454         WebCore's!
455
456         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
457         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
458         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
459         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
460         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
461         * Drosera/win/Drosera.cpp:
462         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
463
464 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
465
466         Reviewed by Sam.
467
468         - Use the new IWebFrame [local] function signature and get the shared
469         server correctly.
470
471         * Drosera/win/DebuggerClient.cpp:
472         (DebuggerClient::didFinishLoadForFrame):
473         * Drosera/win/ServerConnection.cpp:
474         (ServerConnection::attemptToCreateServerConnection):
475
476 2007-11-07  Dan Bernstein  <mitz@apple.com>
477
478         Reviewed by Darin Adler.
479
480         - add an option to run-webkit-tests to ignore pixel test failures where
481           all pixels differ by no more than a specified threshold
482
483         * DumpRenderTree/mac/ImageDiff.m:
484         (main):
485         (compareImages):
486         (computePercentageDifferent):
487         * Scripts/run-webkit-tests:
488
489 2007-11-07  Simon Hausmann  <hausmann@kde.org>
490
491         Reviewed by Lars.
492
493         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
494
495         * DumpRenderTree/qt/DumpRenderTree.cpp:
496
497 2007-11-07  Simon Hausmann  <hausmann@kde.org>
498
499         Reviewed by Lars.
500
501         Reworked the QWebSettings API.
502         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
503
504         * DumpRenderTree/qt/DumpRenderTree.cpp:
505
506 2007-11-07  Simon Hausmann  <hausmann@kde.org>
507
508         Reviewed by Lars.
509
510         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
511
512         * DumpRenderTree/qt/jsobjects.cpp:
513
514 2007-11-07  Simon Hausmann  <hausmann@kde.org>
515
516         Reviewed by Lars Knoll <lars@trolltech.com>.
517
518         Add a QWebPage::frameCreated() signal and fix DRT
519         
520         The removal of createFrame in QWebPage broke the re-implementation
521         in DumpRenderTree. Instead emit a frameCreated() signal and
522         connect to it in DumpRenderTree.
523         
524
525         * DumpRenderTree/qt/DumpRenderTree.cpp:
526         (WebCore::WebPage::WebPage):
527         (WebCore::DumpRenderTree::dump):
528         (WebCore::DumpRenderTree::connectFrame):
529         * DumpRenderTree/qt/DumpRenderTree.h:
530
531 2007-11-07  Simon Hausmann  <hausmann@kde.org>
532
533         Reviewed by Lars Knoll <lars@trolltech.com>.
534
535         Moved all the event handlers from QWebFrame into QWebPage.
536         
537         This cleans up the public API and allows us to remove the
538         HackWebFrame hack in DumpRenderTree.
539         
540
541         * DumpRenderTree/qt/jsobjects.cpp:
542         (EventSender::mouseDown):
543         (EventSender::mouseUp):
544         (EventSender::mouseMoveTo):
545
546 2007-11-07  Simon Hausmann  <hausmann@kde.org>
547
548         Reviewed by Mark.
549
550         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
551         to prevent the default implementation from popping up messageboxes.
552
553         * DumpRenderTree/qt/DumpRenderTree.cpp:
554         (WebCore::WebPage::javaScriptConfirm):
555         (WebCore::WebPage::javaScriptPrompt):
556
557 2007-11-06  Eric Seidel  <eric@webkit.org>
558
559         * Scripts/build-testkjs: build fix... too many $$
560
561 2007-11-06  Eric Seidel  <eric@webkit.org>
562
563         Reviewed by Mark Rowe.
564
565         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
566
567 2007-11-05  Adam Roben  <aroben@apple.com>
568
569         Add support on Windows for WEBKIT_TESTFONTS
570
571         This environment variable lets you specify where the fonts to be used
572         by DumpRenderTree reside. The Qt port is already using this, so I'm
573         just following their lead.
574
575         Reviewed by Darin.
576
577         * DumpRenderTree/win/DumpRenderTree.cpp:
578         (exePath): Refactored code out of initialize().
579         (fontsPath): Returns either $WEBKIT_TESTFONTS or
580         DumpRenderTree.resources.
581         (initialize): Use the new fontsPath function.
582         (main): Use the new exePath function.
583         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
584         variable to DRT, like Qt does.
585
586 2007-11-05  Mark Rowe  <mrowe@apple.com>
587
588         Rubber-stamped by Alp Toker.
589
590         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
591
592         * GtkLauncher/main.cpp:
593         (goToURLBarText):
594         (main):
595
596 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
597
598         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
599         <http://bugs.webkit.org/show_bug.cgi?id=15830>
600
601         Reviewed by Timothy.
602
603         Restrict the range of nightly builds used by the bisect-builds script
604         based on the version of Safari and the version of Mac OS X being used.
605
606         Mac OS X 10.4: Safari 2.0: r11976 or newer
607         Mac OS X 10.4: Safari 3.0: r19992 or newer
608
609         Mac OS X 10.5: Safari 2.0: r19594 or newer
610         Mac OS X 10.5: Safari 3.0: r25124 or newer
611
612         * Scripts/bisect-builds:
613         (findMacOSXVersion): Added.
614         (makeNightlyList): Added argument to provide version of Mac OS X.
615         Restrict range of nightly builds based on Safari and Mac OS X versions.
616
617 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
618
619         Reviewed by Maciej.
620
621         - This patch involves several changes, all of them were noticed that
622         they were needed by the work being done in WebKit to get Drosera and
623         WebKit working together on Windows.
624         - The changes are:
625         1) Added a debugger console for output messages.
626         2) Drosera now listens for the WebKit server (before, the server would
627         have to be running before Drosera was started.)
628         3) Fixed a bug where the WebView started out as 0x0 pixels.
629         4) Fixed a bug when there is no scope.
630         5) Added the HTML, JS, and CSS to the project file to make them easy to
631         find.
632         6) Made the ServerConnection functions virtual.
633
634         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
635         for the WebKit server.
636         (DebuggerClient::DebuggerClient):
637         (DebuggerClient::~DebuggerClient):
638         (DebuggerClient::didFinishLoadForFrame):
639         (DebuggerClient::serverConnected):
640         (DebuggerClient::attemptToCreateServerConnection):
641         * Drosera/win/DebuggerClient.h: Ditto.
642         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
643         scope.
644         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
645         (DebuggerDocument::platformValueForScopeVariableNamed):
646         * Drosera/win/Drosera.cpp:
647         (_tWinMain): Added a console in debug for output messages.
648         (Drosera::Drosera): Listen for server.
649         (Drosera::initUI): The server now Initializes COM.
650         (Drosera::serverConnected): Part of the listening for the server.
651         (Drosera::attemptToCreateServerConnection): Ditto.
652         * Drosera/win/Drosera.h: New interface for listening for the server.
653         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
654         files to the VS project.
655         * Drosera/win/ServerConnection.cpp: Part of listening for the server
656         connection.
657         (ServerConnection::ServerConnection):
658         (ServerConnection::attemptToCreateServerConnection):
659         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
660         methods.
661         (ServerConnection::serverConnected):
662
663 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
664
665         Reviewed by Maciej.
666
667         http://bugs.webkit.org/show_bug.cgi?id=15832
668         fast/dom/gc-10.html crashes when run alone
669
670         Check for !done before using objects that can be already deallocated.
671
672         * DumpRenderTree/mac/EditingDelegate.mm:
673         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
674         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
675         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
676         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
677         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
678         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
679         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
680         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
681         (-[EditingDelegate webViewDidBeginEditing:]):
682         (-[EditingDelegate webViewDidChange:]):
683         (-[EditingDelegate webViewDidEndEditing:]):
684         (-[EditingDelegate webViewDidChangeTypingStyle:]):
685         (-[EditingDelegate webViewDidChangeSelection:]):
686         * DumpRenderTree/mac/FrameLoadDelegate.mm:
687         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
688         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
689         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
690         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
691         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
692         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
693         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
694         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
695         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
696         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
697         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
698         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
699         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
700         (-[FrameLoadDelegate webView:willCloseFrame:]):
701         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
702         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
703         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
704         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
705         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
706         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
707         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
708         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
709         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
710
711 2007-11-04  Mark Rowe  <mrowe@apple.com>
712
713         Build fix.  Don't use Carbon.h as the prefix header as it triggers
714         warnings that would otherwise be suppressed due to it being a system header.
715
716         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
717
718 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
719
720         Rubber stamped by Adam.
721         
722         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
723
724         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
725
726 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
727
728         Sort files(...); sections of Xcode project files.
729
730         Rubber-stamped by Darin.
731
732         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
733         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
734         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
735         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
736
737 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
738
739         Script to sort "files(...);" sections in Xcode project.pbxproj files.
740
741         Reviewed by Darin.
742
743         * Scripts/sort-Xcode-project-file: Added.
744
745 2007-11-02  Darin Adler  <darin@apple.com>
746
747         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
748
749 2007-11-02  Darin Adler  <darin@apple.com>
750
751         Reviewed by Maciej.
752
753         * Scripts/run-sunspider: Pass the "--base" option through.
754
755         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
756         the real script do that. Default configuration to Release to match run-sunspider
757         so we don't end up building Debug just to compare results.
758
759 2007-11-01  Adam Roben  <aroben@apple.com>
760
761         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
762
763         Reviewed by Sam.
764
765         * Scripts/commit-log-editor: Show all the directories beneath the
766         source root, instead of just the last one.
767
768 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
769
770         Reviewed by Adam Roben.
771
772         Print out an error message when the Windows build fails
773         and provide guidance on how to find out what went wrong.
774
775         * Scripts/build-webkit:
776         * Scripts/webkitdirs.pm:
777
778 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
779
780         Rubber-stamped by Adam Roben.
781
782         Rolled out r27326 - debug CRT seems to cause no problems after all.
783
784         * DumpRenderTree/win/DumpRenderTree.vcproj:
785
786 2007-10-31  Adam Roben  <aroben@apple.com>
787
788         Switch the Debug configuration to using the non-debug CRT
789
790         This matches WebKit.
791
792         Reviewed by Steve.
793
794         * DumpRenderTree/win/DumpRenderTree.vcproj:
795
796 2007-10-31  Antti Koivisto  <antti@apple.com>
797
798         Reviewed by bdash.
799         
800         Disable media tests when doing leak checking on Tiger.
801         They crash in QuickTime (rdar://problem/5537157).
802
803         * Scripts/run-webkit-tests:
804
805 2007-10-29  Antti Koivisto  <antti@apple.com>
806
807         Reviewed by Maciej.
808         
809         Build media support by default on OSX only.
810
811         * Scripts/build-webkit:
812
813 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
814
815         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
816         get caught by the pre-commit hooks.
817
818 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
819
820         Reviewed by Adam.
821
822         - This is a collection of relatively unrelated changes and cleanups
823         to Drosera to prepare it for interacting with WebKit.  A lot of these
824         changes are just correcting mistakes, for example removing included
825         headers that are no longer needed.
826
827         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
828         this will be needed by the DebuggerClient.
829         (DebuggerDocument::server):
830         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
831         * Drosera/win/DebuggerClient.cpp: 
832         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
833         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
834         (DebuggerClient::createWebViewWithRequest): Added comment about its
835         purpose. 
836         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
837         declarations.
838         (DebuggerClient::webViewLoaded): Moved.
839         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
840         file, since this was the only place it was used.
841         (cfStringToBSTR):
842         * Drosera/win/Drosera.h: Cleaned up the includes.
843         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
844         * Drosera/win/HelperFunctions.h: Removed.
845
846 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
847
848         Reviewed by Adam.
849
850         - Small cleanup in the ServerConnection class.
851
852         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
853         and added an include.
854         (ServerConnection::currentFrame):
855         (ServerConnection::getCallerFrame):
856         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
857         made a pointer into a COMPtr, and cleaned up the includes.
858
859 2007-10-29  Timothy Hatcher  <timothy@apple.com>
860
861         Reviewed by John Sullivan.
862         
863         - Place the Localizable.strings file in mac or win directories
864           if that location exists.
865         - Also look for UI_STRING in .c files.
866
867         * Scripts/extract-localizable-strings:
868
869 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
870
871         Reviewed by Adam.
872
873         - Set the eol-style to native and made all the line endings the same
874         so that I avoid messy diffs that show eol changes.
875
876         * Drosera/win/ServerConnection.cpp:
877         (ServerConnection::didParseSource):
878         (ServerConnection::didEnterCallFrame):
879         (ServerConnection::willExecuteStatement):
880         (ServerConnection::willLeaveCallFrame):
881         (ServerConnection::exceptionWasRaised):
882
883 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
884
885         Reviewed by Adam.
886
887         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
888         functionality that could not have existed previously without the new
889         interfaces.
890         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
891         from a BSTR to a JSValueRef.
892         (DebuggerDocument::platformEvaluateScript): Implemented.
893         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
894         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
895         Implemented.
896         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
897         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
898         * Drosera/win/ServerConnection.cpp: Added a helper function.
899         (ServerConnection::getCallerFrame):
900         * Drosera/win/ServerConnection.h: Added a helper function.
901
902 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
903
904         updated reviewers for my previous changelog.
905
906 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
907         Reviewed by Maciej and Adam and Geoff.
908
909         - Minor mac-side improvements including moving a function to a more
910         appropriate location, fixing a warning, and correctly checking
911         exceptions.
912
913         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
914         (DebuggerDocument::willExecuteStatement):
915         (DebuggerDocument::didEnterCallFrame):
916         (DebuggerDocument::willLeaveCallFrame):
917         (DebuggerDocument::windowScriptObjectAvailable):
918         (DebuggerDocument::callFunctionOnObject):
919         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
920         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
921         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
922         because it doesn't require the ServerConnection at all.
923         (NSStringCreateWithJSStringRef): Made an argument const.
924         (JSValueRefCreateWithNSString): Made an argument const.
925         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
926         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
927         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
928         * Drosera/mac/ServerConnection.mm: Ditto.
929         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
930
931 2007-10-29  Sam Weinig  <sam@webkit.org>
932
933         Reviewed by Adam Roben.
934
935         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
936
937         * DumpRenderTree/LayoutTestController.cpp:
938         (LayoutTestController::LayoutTestController):
939         (getGlobalFlagCallback):
940         (setGlobalFlagCallback):
941         (LayoutTestController::getJSClass):
942         (LayoutTestController::staticValues):
943         * DumpRenderTree/LayoutTestController.h:
944         (LayoutTestController::globalFlag):
945         (LayoutTestController::setGlobalFlag):
946
947 2007-10-29  Darin Adler  <darin@apple.com>
948
949         Reviewed by Maciej.
950
951         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
952         resolution instead of its default.
953
954 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
955
956         Fixed showStatus() to print status for successfully resolved conflicts when using git.
957
958         Reviewed by Mark Rowe.
959
960         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
961         was successfully resolved, but this would not show any status because the change had
962         already been cached in the index using "git add".  The solution is to add an optional
963         second argument to showStatus() which adds the "--cached" switch to the command.
964
965         * Scripts/resolve-ChangeLogs:
966         (showStatus):
967
968 2007-10-28  Eric Seidel  <eric@webkit.org>
969
970         Reviewed by Maciej and Geoff, in unison.
971
972         * Scripts/run-webkit-tests: remove broken --svg option
973
974 2007-10-28  Darin Adler  <darin@apple.com>
975
976         Reviewed by Adam.
977
978         * Scripts/run-sunspider: Default to "Release" configuration rather than
979         defaulting to the last configuration used as other scripts do. This can
980         still be overriden on the command line with "--debug" if there's some
981         reason to do so. Also fix a typo.
982
983         * Scripts/sunspider-compare-results: Fix a typo.
984
985 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
986
987         Reviewed by Adam.
988
989         - Implemented the WebScriptDebugListener functions now that the
990         WebScriptDebugServer exists
991
992         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
993         functions.
994         (ServerConnection::currentFrame):
995         (ServerConnection::didLoadMainResourceForDataSource):
996         (ServerConnection::didParseSource):
997         (ServerConnection::failedToParseSource):
998         (ServerConnection::didEnterCallFrame):
999         (ServerConnection::willExecuteStatement):
1000         (ServerConnection::willLeaveCallFrame):
1001         (ServerConnection::exceptionWasRaised):
1002         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1003         members arguments list.
1004
1005 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1006
1007         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1008         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1009
1010         Reviewed by Darin.
1011
1012         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1013         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1014         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1015         file.  Note that it may also be used as a stand-alone script.
1016
1017         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1018         * Scripts/resolve-ChangeLogs: Added.
1019         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1020
1021 2007-10-26  Mark Rowe  <mrowe@apple.com>
1022
1023         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1024         to the Qt port on the assumption that it was an implementation of the cross-platform
1025         LayoutTestController class.  It is not, so it did not need to be changed.
1026
1027         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1028
1029 2007-10-25  Mark Rowe  <mrowe@apple.com>
1030
1031         Reviewed by Maciej.
1032
1033         Fix builds with code coverage enabled.
1034
1035         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1036
1037 2007-10-25  Darin Adler  <darin@apple.com>
1038
1039         Reviewed by Mark Rowe.
1040
1041         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1042         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1043
1044 2007-10-25  Stephanie  <slewis@apple.com>
1045
1046         build Fix
1047
1048         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1049
1050 2007-10-25  Stephanie  <slewis@apple.com>
1051
1052         Reviewed by Mark Rowe, Adam Roben.
1053
1054         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1055
1056         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1057
1058 2007-10-25  Alice Liu  <alice.liu@apple.com>
1059
1060         Reviewed by Adam.
1061
1062         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1063
1064         Moving destructor into platform-specific files
1065         * DumpRenderTree/LayoutTestController.cpp:
1066         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1067         (LayoutTestController::~LayoutTestController):
1068         * DumpRenderTree/qt/jsobjects.cpp:
1069         (LayoutTestController::~LayoutTestController):
1070
1071         LayoutTestController wasn't being destroyed
1072         * DumpRenderTree/win/DumpRenderTree.cpp:
1073         (runTest):
1074
1075         Added declspec
1076         * DumpRenderTree/win/EditingDelegate.h:
1077
1078         Reset certain values on the webview (or related delegate) that might 
1079         have changed while running a test
1080         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1081         (LayoutTestController::~LayoutTestController):
1082
1083 2007-10-25  Adam Roben  <aroben@apple.com>
1084
1085         Make sunspider-compare-results work with relative paths
1086
1087         Reviewed by Sam.
1088
1089         * Scripts/sunspider-compare-results: Convert arguments to absolute
1090         paths before we chdir.
1091
1092 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1093
1094         Reviewed by Sam.
1095
1096         - Implemented server calls now the WebScriptDebugServer exists.
1097         - Also removed no longer needed call to initialize CG.
1098
1099         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1100         automatically now.
1101         (_tWinMain):
1102         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1103         (ServerConnection::ServerConnection):
1104         (ServerConnection::~ServerConnection):
1105         (ServerConnection::pause):
1106         (ServerConnection::resume):
1107         (ServerConnection::stepInto):
1108         (ServerConnection::applicationTerminating):
1109         (ServerConnection::serverConnectionDidDie):
1110         * Drosera/win/ServerConnection.h: Now uses the COM class.
1111
1112 2007-10-24  George Staikos  <staikos@kde.org>
1113
1114         Unbreak Qt build.
1115
1116         * Scripts/build-webkit:
1117
1118 2007-10-24  Adam Roben  <aroben@apple.com>
1119
1120         Remove now-unnecessary call to InitializeCoreGraphics
1121
1122         WebKit takes care of this now.
1123
1124         Reviewed by Ada.
1125
1126         * DumpRenderTree/win/DumpRenderTree.cpp:
1127         (initialize):
1128
1129 2007-10-24  Adam Roben  <aroben@apple.com>
1130
1131         Use WebTextRenderer in DRT
1132
1133         Reviewed by Ada.
1134
1135         * DumpRenderTree/win/DumpRenderTree.cpp:
1136         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1137
1138 2007-10-24  Sven Herzberg  <sven@imendio.com>
1139
1140         Reviewed by Mark Rowe.
1141
1142         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1143         Bug 15614: [GTK] qmake based backends don't build on OS X
1144
1145         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1146         GTK backend on a Mac
1147         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1148         isDarwin() to make it reusable in other places (like the workaround-
1149         for-prebuilt-qmake in build-webkit)
1150
1151 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1152
1153         Refurbish update-webkit script.
1154
1155         Reviewed by Adam.
1156
1157         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
1158         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
1159         multi-argument version of system() for flexibility and security.  Check for existence
1160         of Internal directory using -d test instead of -x.
1161
1162 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1163
1164         Minor clean-up of prepare-ChangeLog script.
1165
1166         Reviewed by Adam.
1167
1168         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1169         of a string.  Use multi-argument versions of open() and system() for flexibility and
1170         security.
1171
1172 2007-10-24  Alice Liu  <alice.liu@apple.com>
1173
1174         Reviewed by Oliver.
1175
1176         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1177
1178         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
1179         replay the saved events when we're still processing the mousedown that starts the drag
1180         * DumpRenderTree/win/EventSender.cpp:
1181         (doMouseMove):
1182         * DumpRenderTree/win/UIDelegate.cpp:
1183         (UIDelegate::doDragDrop):
1184
1185 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1186
1187         Reviewed by Sam, Steve and Darin.
1188
1189         - Stubbed out the WebScriptDebugListener functionality in the Server
1190         Connection class to prepare it for receiving those callbacks.
1191         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1192         and the ServerConnection to not need to be initialized with a server
1193         name, since that is not the way we connect to the WebKit server. 
1194
1195         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1196         no exception.  Now it only loggs when there is an exception
1197         (DebuggerDocument::willExecuteStatement):
1198         (DebuggerDocument::didEnterCallFrame):
1199         (DebuggerDocument::willLeaveCallFrame):
1200         (DebuggerDocument::windowScriptObjectAvailable):
1201         (DebuggerDocument::callFunctionOnObject):
1202         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1203         to be instantiated with a server's name.
1204         (DebuggerClient::DebuggerClient):
1205         (DebuggerClient::didFinishLoadForFrame):
1206         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1207         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1208         a server name.
1209         (Drosera::init):
1210         (Drosera::initServer):
1211         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1212         instantiated with a server's name.
1213         * Drosera/win/ServerConnection.cpp: 
1214         (ServerConnection::ServerConnection): No longer needs a server name
1215         (ServerConnection::~ServerConnection): Only release the global context
1216         if there is one.
1217         (ServerConnection::serverConnectionDidDie): Stub for
1218         IWebScriptDebugListener
1219         (ServerConnection::QueryInterface): ditto
1220         (ServerConnection::AddRef): ditto
1221         (ServerConnection::Release): ditto
1222         (ServerConnection::didLoadMainResourceForDataSource): ditto
1223         (ServerConnection::didParseSource): ditto
1224         (ServerConnection::failedToParseSource): ditto
1225         (ServerConnection::didEnterCallFrame): ditto
1226         (ServerConnection::willExecuteStatement): ditto
1227         (ServerConnection::willLeaveCallFrame): ditto
1228         (ServerConnection::exceptionWasRaised): ditto
1229         * Drosera/win/ServerConnection.h: Stubbed out the
1230         IWebScriptDebugListener functions, and this class no longer needs to be
1231         instantiated with a server name.
1232
1233 2007-10-24  Lars Knoll  <lars@trolltech.com>
1234
1235         Reviewed by Simon.
1236
1237         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1238
1239         * DumpRenderTree/qt/jsobjects.h:
1240
1241 2007-10-24  Lars Knoll  <lars@trolltech.com>
1242
1243         Reviewed by Simon.
1244
1245         add another command.
1246
1247         * DumpRenderTree/qt/jsobjects.cpp:
1248         (TextInputController::doCommand):
1249
1250 2007-10-24  Lars Knoll  <lars@trolltech.com>
1251
1252         Reviewed by Simon.
1253
1254         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1255
1256         * DumpRenderTree/qt/jsobjects.cpp:
1257         (EventSender::keyDown):
1258         * DumpRenderTree/qt/jsobjects.h:
1259
1260 2007-10-24  Lars Knoll  <lars@trolltech.com>
1261
1262         Reviewed by Simon.
1263
1264         implement eventSender.keyDown().
1265
1266         * DumpRenderTree/qt/jsobjects.cpp:
1267         (EventSender::keyDown):
1268
1269 2007-10-24  Lars Knoll  <lars@trolltech.com>
1270
1271         Reviewed by Simon.
1272
1273         some smaller fixes to the editing support in DRT. Makes another few tests pass.
1274
1275         * DumpRenderTree/qt/DumpRenderTree.cpp:
1276         (WebCore::DumpRenderTree::DumpRenderTree):
1277         (WebCore::DumpRenderTree::initJSObjects):
1278         * DumpRenderTree/qt/jsobjects.cpp:
1279         (TextInputController::doCommand):
1280
1281 2007-10-24  Lars Knoll  <lars@trolltech.com>
1282
1283         Reviewed by Simon.
1284
1285         first bit of implementation for the textinputcontroller.
1286
1287         * DumpRenderTree/qt/DumpRenderTree.cpp:
1288         (WebCore::DumpRenderTree::DumpRenderTree):
1289         * DumpRenderTree/qt/DumpRenderTree.h:
1290         * DumpRenderTree/qt/jsobjects.cpp:
1291         (TextInputController::TextInputController):
1292         (TextInputController::doCommand):
1293         * DumpRenderTree/qt/jsobjects.h:
1294
1295 2007-10-24  Lars Knoll  <lars@trolltech.com>
1296
1297         Reviewed by Simon.
1298
1299         make the man webpage believe it has focus, so the editing tests work correctly.
1300
1301         * DumpRenderTree/qt/DumpRenderTree.cpp:
1302         (WebCore::DumpRenderTree::DumpRenderTree):
1303
1304 2007-10-24  Lars Knoll  <lars@trolltech.com>
1305
1306         Reviewed by Simon.
1307
1308         implement layoutTestController.dumpEditingCallbacks() correctly.
1309
1310         * DumpRenderTree/qt/DumpRenderTree.cpp:
1311         (WebCore::DumpRenderTree::DumpRenderTree):
1312         * DumpRenderTree/qt/jsobjects.cpp:
1313         (LayoutTestController::reset):
1314         (LayoutTestController::dumpEditingCallbacks):
1315
1316 2007-10-24  Lars Knoll  <lars@trolltech.com>
1317
1318         Reviewed by Simon.
1319
1320         Implement support for testing editing.
1321
1322         * DumpRenderTree/qt/DumpRenderTree.cpp:
1323         (WebCore::DumpRenderTree::DumpRenderTree):
1324
1325 2007-10-23  Sam Weinig  <sam@webkit.org>
1326
1327         Check for null BSTR that can be passed to the UIDelegate methods
1328         from javascript null and undefined.  Fixes a failing test case on
1329         Windows (fast/dom/Window/alert-undefined.html)
1330
1331         Reviewed by Eric Seidel.
1332
1333         * DumpRenderTree/win/UIDelegate.cpp:
1334         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1335         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1336         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1337         (UIDelegate::webViewAddMessageToConsole):
1338
1339 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1340
1341         Reviewed by Darin.
1342         
1343         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1344
1345         * Scripts/build-testkjs:
1346
1347 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1348
1349         Reviewed by Darin.
1350
1351         - add wrapper that finds the right copy of testkjs
1352         
1353         * Scripts/sunspider-compare-results: Added.
1354
1355 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1356
1357         Reviewed by Sam.
1358
1359         - After talking with Steve I now see that the WebKit server must be
1360         running for DCOM to create the distributed objects, which makes sense
1361         and currently WebKit only allows one instance to be running at a time
1362         which avoids accidentally connecting to the wrong server
1363         - In light of this I have removed the code for the attach box and
1364         NotificationServer and known server names, since they are all extranious
1365         now.
1366
1367         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1368         names.
1369         (_tWinMain): Uses init instead of initUI.
1370         (droseraWndProc): No longer creats an attach dialog box.
1371         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1372         it's not manditory to call init before doing COM stuff.
1373         (Drosera::init): calls initUI and will call attach when the
1374         functionality exists. 
1375         (Drosera::initUI): Has changed very little.
1376         (Drosera::attach): Changed the signature to reflect that we no longer
1377         need the dictionary of known server names.
1378         * Drosera/win/Drosera.h: Removed notification classes and known server
1379         names.  Also renamed and moved some functions.
1380         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1381         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1382         headers to the resources folder. 
1383         * Drosera/win/resource.h: Removed the Attach box.
1384
1385 2007-10-22  Adam Roben  <aroben@apple.com>
1386
1387         Windows build fix
1388
1389         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1390
1391 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1392
1393         - Removed a leak that was fixed.
1394
1395         * Scripts/run-webkit-tests:
1396
1397 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1398
1399         Reviewed by Darin.
1400
1401         - Changed the Client so that the DebuggerDocument now own the
1402         ServerConnection.  This simplifies ownership and cleanup. 
1403
1404         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1405         ServerConnection.
1406         (DebuggerClient::initWithServerName):
1407         (DebuggerClient::didFinishLoadForFrame):
1408         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
1409         ServerConnection.
1410         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1411         until after we have a server which we are attached to.
1412         (Drosera::initUI):
1413         (Drosera::attach):
1414         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1415         out previously.
1416
1417 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1418
1419         Reviewed by Nikolas.
1420
1421         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1422
1423         * Scripts/run-javascriptcore-tests:
1424
1425 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1426
1427         Reviewed by Nikolas.
1428
1429         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1430
1431         * Scripts/build-drosera:
1432         * Scripts/build-dumprendertree:
1433         * Scripts/build-testkjs:
1434         * Scripts/build-webkit:
1435         * Scripts/run-javascriptcore-tests:
1436         * Scripts/run-sunspider:
1437         * Scripts/run-webkit-tests:
1438         * Scripts/webkitdirs.pm:
1439
1440 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1441
1442         Reviewed by Mark Rowe.
1443         
1444         Fix for local database support after r26879
1445         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1446
1447         * Scripts/build-webkit:
1448
1449 2007-10-22  Holger Freyther  <zecke@selfish.org>
1450
1451         Reviewed by Simon Hausmann <hausmann@kde.org>.
1452
1453         - Do not build testkjs as an application bundle. This is
1454         needed for run-javascriptcore-tests on OSX.
1455         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1456         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1457         as we do not have -rpath on OSX.
1458
1459         * DumpRenderTree/qt/DumpRenderTree.pro:
1460         * Scripts/run-webkit-tests:
1461
1462 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1463
1464         Reviewed by aroben.
1465
1466         Fix support for Signed-off-by detection in prepare-ChangeLog
1467         --git-commit. The Signed-off-by tag does not appear in the header
1468         but usually at the end.
1469
1470         * Scripts/prepare-ChangeLog:
1471
1472 2007-10-21  Mark Rowe  <mrowe@apple.com>
1473
1474         Reviewed by Eric.
1475
1476         Fix run-javascriptcore-tests for Gtk.
1477
1478         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1479
1480 2007-10-20  Eric Seidel  <eric@webkit.org>
1481
1482         Reviewed by aroben.
1483
1484         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1485
1486 2007-10-20  Eric Seidel  <eric@webkit.org>
1487
1488         Reviewed by darin.
1489         
1490         Add improved argument handling to run-sunspider, including
1491         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1492         Also re-factor code into subroutines
1493
1494         * Scripts/build-dumprendertree: removed bogus comments
1495         * Scripts/build-testkjs: Added.
1496         * Scripts/run-javascriptcore-tests: use build-testkjs
1497         * Scripts/run-sunspider: improved argument handling, abstraction
1498         * Scripts/run-webkit-tests: improved abstraction
1499
1500 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1501
1502         Not reviewed, Windows build fix.
1503
1504         * DumpRenderTree/win/EventSender.cpp:
1505         (keyDownCallback):
1506
1507 2007-10-20  Darin Adler  <darin@apple.com>
1508
1509         Reviewed by Tim Hatcher.
1510
1511         - http://bugs.webkit.org/show_bug.cgi?id=15544
1512           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
1513           not rely on Apple-specific key codes
1514
1515         * DumpRenderTree/mac/EventSendingController.mm:
1516         (-[EventSendingController keyDown:withModifiers:]):
1517         Added named key "rightArrow". Later we could have a whole table of these.
1518         Also tweaked modifiers code a little.
1519
1520         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
1521
1522 2007-10-19  Darin Adler  <darin@apple.com>
1523
1524         Reviewed by Eric.
1525
1526         - http://bugs.webkit.org/show_bug.cgi?id=15566
1527           possible fix for leak seen in DumpRenderTree
1528
1529         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
1530         Delete the item if it's not put on the queue, since the caller has
1531         no way of knowing that. Would be better to have the parameter type
1532         be auto_ptr to express the fact that we take ownership.
1533
1534         - unrelated change
1535
1536         * Drosera/mac/main.m: Add missing include.
1537
1538 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1539
1540         Reviewed by Adam.
1541
1542         - This change should be identical but for some reason was not working
1543         on my machine.
1544
1545         * Scripts/prepare-ChangeLog:
1546
1547 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1548
1549         Reviewed by Oliver and Tim.
1550
1551         - Made use of RetainPtr to avoid retain and release issues and moved the
1552         log function to DebuggerDocumentPlatform, which seems to be a more
1553         logical place for it to live.
1554         - Also moved knownServers from the ServerConnection to
1555         DebuggerApplication to match the Windows code and because it makes sense
1556         that a connection knows its own server but not all of them.
1557
1558         * Drosera/mac/DebuggerClient.h: Moved the log function to
1559           DebuggerDocumentPlatform.
1560         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
1561           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
1562           call for the server name up from the ServerConnection class.
1563         (-[DebuggerClient dealloc]):
1564         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
1565           for the server name up from the ServerConnection.
1566         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
1567         (DebuggerDocument::platformPause):
1568         (DebuggerDocument::platformResume):
1569         (DebuggerDocument::platformStepInto):
1570         (DebuggerDocument::platformEvaluateScript):
1571         (DebuggerDocument::getPlatformCurrentFunctionStack):
1572         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1573         (DebuggerDocument::platformValueForScopeVariableNamed):
1574         (DebuggerDocument::platformLog): Log directly from here. No need to call
1575           DebuggerClient.
1576         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
1577           way I see it, a ServerConnection should only know about its connection
1578           and the group of all possible servers should be kept by the
1579           application.
1580         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
1581           currentServerName, it makes sense that the connection should know that
1582           name.
1583         (-[ServerConnection currentServerName]):
1584
1585 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1586
1587         Reviewed by Adam.
1588
1589         - Integrated changes from mac drosera.  Recently I've encapsulated
1590         out the server connection object from the rest of Drosera because
1591         it is very platform dependent right now and RPC is not implemented on
1592         windows.  This functionality, of communicating with the WebKit server
1593         is the next area I will be focusing on in Windows.
1594
1595         - Other changes and cleanup were made to organize the code and add notes
1596         on which parts still need work.  Also some mac code is added and
1597         commented out, to act as pseudocode for the logic of those parts.
1598
1599         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
1600           pointer.
1601         * Drosera/config.h: Added whitespace.
1602         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
1603           these files got moved into Drosera.h/cpp
1604         * Drosera/win/DebuggerApplication.h: Removed.
1605         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
1606           happened here to better match the logic flow of the same code on the 
1607           mac side and to use the new ServerConnection class.
1608         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
1609         (DebuggerClient::initWithServerName): Initializer that will set up the
1610           class to use a ServerConnection object.  This was necessary so I could
1611           create a DebuggerClient without having to initilaize it at
1612           construction.
1613         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
1614           will be the UIDelegate and FrameLoadDelegate.
1615         (DebuggerClient::AddRef): For IUnknown.
1616         (DebuggerClient::Release): For IUnknown.
1617         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
1618           this still needs to set the global context of the server, but
1619           IWebFrame does not have an accessor for the global context yet. 
1620         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
1621           this is a pass through for the same function in the document.
1622         (DebuggerClient::didReceiveTitle): Unimplemented part of
1623           FrameLoadDelegate this would change the title of the window.
1624         (DebuggerClient::createWebViewWithRequest): Part of the
1625           FrameLoadDelegate.  This is about new windows via Window.open() and
1626           how their delegates are set.
1627         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
1628           UIDelegate.  Just a debug function for printing messages.
1629         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
1630           because the Client should be the UIDelegate and FrameLoadDelegate
1631           to match the delegates on mac.
1632         (DebuggerClient::webViewLoaded): Added accessor method.
1633         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
1634           forgotten to add this file before.  This is where the platform
1635           dependent versions of the Documents functions live. Most of these are
1636           unimplemented because some piece of functionality does not exist on
1637           Windows yet.
1638         (DebuggerDocument::platformPause):
1639         (DebuggerDocument::platformResume):
1640         (DebuggerDocument::platformStepInto):
1641         (DebuggerDocument::platformEvaluateScript):
1642         (DebuggerDocument::getPlatformCurrentFunctionStack):
1643         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1644         (DebuggerDocument::platformValueForScopeVariableNamed):
1645         (DebuggerDocument::platformLog):
1646         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
1647           responsibilities becaue they belong in the Client. Also I laid the
1648           groundwork for attaching Drosera to a WebKit process
1649         (attachWndProc): Now if a server is selected the Client becomes it's
1650           delegate.
1651         (Drosera::Drosera): Added the construction of the Client and dictionary
1652           of server names. 
1653         (Drosera::initUI): This is no longer the delegates, the Client is.
1654         (Drosera::webViewLoaded): Now asks the Client instead of holding local
1655           state. 
1656         (Drosera::applicationDidFinishLaunching): Placeholder for needed
1657           notification registration when it's possible to implement.
1658         (Drosera::serverLoaded): Ditto
1659         (Drosera::serverUnloaded): Ditto
1660         (Drosera::attach): Attach Drosera to the WebKit server.
1661         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
1662         (Drosera::getInst): 
1663         (Drosera::setInst):
1664         (Drosera::knownServers):
1665         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
1666           and added the ServerConnection.
1667         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
1668         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
1669           Most of the functions are completely unimlemented because they cannot
1670           connect with the WebKit server, because one does not exist on Windows
1671           yet.
1672         (ServerConnection::initWithServerName): 
1673         (ServerConnection::~ServerConnection):
1674         (ServerConnection::setGlobalContext):
1675         (ServerConnection::pause):
1676         (ServerConnection::resume):
1677         (ServerConnection::stepInto):
1678         (ServerConnection::switchToServerNamed):
1679         (ServerConnection::applicationTerminating):
1680         (ServerConnection::serverConnectionDidDie):
1681         (ServerConnection::currentFrame):
1682         * Drosera/win/ServerConnection.h: Added. Ditto.
1683         (ServerConnection::ServerConnection):
1684
1685 2007-10-19  Alice Liu  <alice.liu@apple.com>
1686
1687         Reviewed by Darin.
1688
1689         Fix for these broken layout tests on Windows:
1690         
1691         fast/forms/focus-selection-input.html
1692         fast/forms/focus-selection-textarea.html
1693         fast/forms/select-accesskey.html
1694         
1695         * DumpRenderTree/win/EventSender.cpp:
1696         (keyDownCallback):
1697         correct the VK code for alt key.
1698         
1699 2007-10-19  Eric Seidel  <eric@webkit.org>
1700
1701         Reviewed by Mark Rowe.
1702         
1703         Make the GtkLauncher code slightly more readable.
1704
1705         * GtkLauncher/main.cpp:
1706         (setupMainMenu): Added.
1707         (setupMainWindowUI): Added.
1708         (main):
1709
1710 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
1711
1712         Rubber stamped by Adam.
1713         
1714         - don't delay-load WebKit in DumpRenderTree.
1715
1716         * DumpRenderTree/win/DumpRenderTree.vcproj:
1717
1718 2007-10-18  Dan Bernstein  <mitz@apple.com>
1719
1720         Reviewed by Adam Roben.
1721
1722         - fix <rdar://problem/5313523>
1723         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
1724
1725         * DumpRenderTree/mac/DumpRenderTree.mm:
1726         (dump): Changed to use _responseMIMEType.
1727
1728 2007-10-17  Adam Roben  <aroben@apple.com>
1729
1730         Make it possible to have Windows-specific tests and results
1731
1732         When searching for tests to run and the Skipped file, we will only
1733         look in platform/win and the cross-platform directory. When looking
1734         for expected results, we will look in platform/win, then
1735         platform/mac-leopard, then platform/mac, then finally the
1736         cross-platform directory.
1737
1738         Reviewed by Sam.
1739
1740         * Scripts/run-webkit-tests:
1741         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
1742         searching in the cross-platform directory.
1743         (sub buildPlatformHierarchy): Removed some unneeded calls to
1744         dirname/basename.
1745
1746 2007-10-17  Adam Roben  <aroben@apple.com>
1747
1748         Add back the call to register WebKit that we had before WebKitInitializer existed
1749
1750         This is needed to ensure that the right WebKit is used when
1751         instantiating COM objects.
1752
1753         Reviewed by Oliver.
1754
1755         * DumpRenderTree/win/debug_internal.vsprops: Define
1756         DEBUG_WEBKIT_HAS_SUFFIX.
1757         * DumpRenderTree/win/DumpRenderTree.cpp:
1758         (initialize):
1759
1760 2007-10-17  Adam Roben  <aroben@apple.com>
1761
1762         Import File::Basename in webkitdirs since we use it
1763
1764         * Scripts/webkitdirs.pm:
1765
1766 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
1767
1768         - Updated the tiger leaks list to make the internal bots green.
1769
1770         * Scripts/run-webkit-tests:
1771
1772 2007-10-17  Adam Roben  <aroben@apple.com>
1773
1774         Build fix for VC++ Express
1775
1776         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
1777         and ole32.lib.
1778
1779 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1780
1781         Reviewed by Sam.
1782
1783         - Minor mac improvements based on observations I made while implementing the
1784         Windows code.
1785
1786         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
1787         then hand it to the Client who will retain it, it should just be the client who
1788         creates and owns the server.
1789         (-[DebuggerApplication attach:]):
1790         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
1791         * Drosera/mac/DebuggerClient.mm: Creates the server.
1792         (-[DebuggerClient initWithServerName:]):
1793         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
1794         can instead forward declare what it needs.
1795
1796 2007-10-16  Darin Adler  <darin@apple.com>
1797
1798         Reviewed by Geoff Garen.
1799
1800         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
1801         want to turn failing tests into platform-specific test results. Also did a
1802         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
1803         would take the type of results into account only some of the time.
1804
1805 2007-10-16  Adam Roben  <aroben@apple.com>
1806
1807         Add a new nightly launcher script for Windows
1808
1809         This new script is for versions of Safari that don't delay-load
1810         WebKit. I had to make FindSafari be able to print out the nightly
1811         launcher script on stdout because Windows shell scripts can't capture
1812         the output from a command into an environment variable.
1813
1814         Reviewed by Steve.
1815
1816         * FindSafari/FindSafari.cpp:
1817         (_tmain): Added /printSafariLauncher option.
1818         * Scripts/run-webkit-nightly.cmd: Added.
1819
1820 2007-10-16  Adam Roben  <aroben@apple.com>
1821
1822         Replace WebKitInitializer with FindSafari
1823
1824         We now rely on setting the PATH environment variable to tell Windows
1825         where to find WebKit and its dependencies (similar to
1826         DYLD_FRAMEWORK_PATH on Mac).
1827
1828         This change also make DumpRenderTree no longer delay-load WebKit.
1829
1830         Reviewed by Sam.
1831
1832         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
1833         FindSafari.
1834         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
1835         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
1836         WebKitInitializer, don't delay-load WebKit.
1837         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
1838         * Scripts/run-webkit-tests: Ditto.
1839         * Scripts/webkitdirs.pm:
1840         (sub setPathForRunningWebKitApp): Added.
1841         * WebKitInitializer/WebKitInitializer.cpp: Removed.
1842         * WebKitInitializer/WebKitInitializer.h: Removed.
1843         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
1844         * WebKitInitializer/debug.vsprops: Removed.
1845         * WebKitInitializer/debug_internal.vsprops: Removed.
1846         * WebKitInitializer/release.vsprops: Removed.
1847
1848 2007-10-16  Adam Roben  <aroben@apple.com>
1849
1850         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
1851
1852         http://bugs.webkit.org/show_bug.cgi?id=15532
1853
1854         FindSafari simply prints the location of an installed Safari.exe on
1855         stdout.
1856
1857         Reviewed by Darin.
1858
1859         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
1860         (getStringValue):
1861         (getWebViewCLSID):
1862         (getInstalledWebKitDirectory):
1863         (_tmain):
1864         * FindSafari/FindSafari.vcproj: Added.
1865         * Scripts/webkitdirs.pm:
1866         (sub installedSafariPath): Added. Calls FindSafari on Windows.
1867
1868 2007-10-16  Adam Roben  <aroben@apple.com>
1869
1870         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
1871
1872         Reviewed by Kevin McCullough.
1873
1874         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
1875         when referring to WebKit.dll.
1876         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
1877         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
1878         * DumpRenderTree/win/release.vsprops: Ditto.
1879         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
1880         never have a _debug suffix on WebKit.dll.
1881         * WebKitInitializer/WebKitInitializer.cpp:
1882         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
1883         specified.
1884         * WebKitInitializer/debug_internal.vsprops: Added
1885         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
1886
1887 2007-10-16  Darin Adler  <darin@apple.com>
1888
1889         Reviewed by Adele.
1890
1891         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1892         Remove now-unneeded control/alt key hack; the tests have been updated.
1893
1894 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1895
1896         - Updated leaks list because our internal bot upgraded it's version of leopard and 
1897         one of the leaks was fixed between that revision and the bot's previous version of
1898         leopard.
1899
1900         * Scripts/run-webkit-tests:
1901
1902 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
1903
1904         Reviewed by Tim.
1905
1906         - I encapsulated out the server connecton functionality because it is a specific part
1907         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
1908         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
1909         Windows.  So the majority of this patch is moving preexisting functionality.
1910
1911         - Also I removed the prefix header and changed to use config.h because it is more
1912         standard on how we use config.h in windows and it didn't make much sense to keep
1913         the prefix header and the config.h
1914
1915         * Drosera/DebuggerDocument.cpp:
1916         (DebuggerDocument::DebuggerDocument):
1917         * Drosera/DebuggerDocument.h:
1918         * Drosera/config.h:
1919         * Drosera/mac/DebuggerApplication.mm:
1920         (-[DebuggerApplication attach:]):
1921         * Drosera/mac/DebuggerClient.h:
1922         * Drosera/mac/DebuggerClient.mm:
1923         (-[DebuggerClient initWithServerConnection:]):
1924         (-[DebuggerClient dealloc]):
1925         (-[DebuggerClient windowDidLoad]):
1926         (-[DebuggerClient windowWillClose:]):
1927         (-[DebuggerClient webView:didFinishLoadForFrame:]):
1928         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
1929         * Drosera/mac/DebuggerDocumentPlatform.mm:
1930         (DebuggerDocument::platformPause):
1931         (DebuggerDocument::platformResume):
1932         (DebuggerDocument::platformStepInto):
1933         (DebuggerDocument::platformEvaluateScript):
1934         (DebuggerDocument::getPlatformCurrentFunctionStack):
1935         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1936         (DebuggerDocument::platformValueForScopeVariableNamed):
1937         (DebuggerDocument::platformLog):
1938         * Drosera/mac/Drosera.pch: Removed.
1939         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1940         * Drosera/mac/ServerConnection.h: Added.
1941         * Drosera/mac/ServerConnection.mm: Added.
1942         (-[ServerConnection initWithServerName:]):
1943         (-[ServerConnection dealloc]):
1944         (-[ServerConnection setGlobalContext:]):
1945         (-[ServerConnection pause]):
1946         (-[ServerConnection resume]):
1947         (-[ServerConnection stepInto]):
1948         (-[ServerConnection switchToServerNamed:]):
1949         (-[ServerConnection applicationTerminating:]):
1950         (-[ServerConnection serverConnectionDidDie:]):
1951         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1952         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1953         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1954         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1955         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1956         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1957         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1958         (-[ServerConnection currentFrame]):
1959         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1960         (-[ServerConnection knownServers]):
1961
1962 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1963
1964         Reviewed by Eric.
1965
1966         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1967           Script to automatically search nightly builds for regressions (bisect-builds)
1968
1969         * Scripts/bisect-builds: Added.
1970
1971 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1972
1973         Reviewed by Darin.
1974
1975         - New JavaScript benchmark
1976         http://bugs.webkit.org/show_bug.cgi?id=15515
1977
1978         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1979         current development or release build of JavaScriptCore.
1980
1981 2007-10-15  Mark Rowe  <mrowe@apple.com>
1982
1983         Reviewed by Sam.
1984
1985         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1986
1987         * Scripts/webkitdirs.pm:
1988         - Change checkArgv to remove the options from @ARGV to prevent
1989         them from interfering with further option processing.
1990         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1991         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1992         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1993         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1994
1995 2007-10-15  Darin Adler  <darin@apple.com>
1996
1997         Reviewed by Sam.
1998
1999         - added logging of window.prompt and window.confirm
2000
2001         * DumpRenderTree/mac/UIDelegate.mm:
2002         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2003         Implement the recommended delegate rather than the deprecated one.
2004         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2005         Added.
2006         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2007         Added.
2008
2009         * DumpRenderTree/win/UIDelegate.h:
2010         * DumpRenderTree/win/UIDelegate.cpp:
2011         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2012         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2013         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2014         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2015
2016 2007-10-15  Alice Liu  <alice.liu@apple.com>
2017
2018         Reviewed by Sam Weinig.
2019
2020         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2021
2022         * DumpRenderTree/win/DumpRenderTree.cpp:
2023         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2024         (main): allocate the global policy delegate for DRT's custom use
2025         * DumpRenderTree/win/DumpRenderTree.vcproj:
2026         Adding files to project
2027         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2028         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2029         (LayoutTestController::setCustomPolicyDelegate):
2030         set the webview's policy delegate to DRT's custom one if the test requests it.
2031         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2032         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2033         (PolicyDelegate::PolicyDelegate):
2034         (PolicyDelegate::QueryInterface):
2035         (PolicyDelegate::AddRef):
2036         (PolicyDelegate::Release):
2037         (PolicyDelegate::decidePolicyForNavigationAction):
2038         * DumpRenderTree/win/PolicyDelegate.h: Added.
2039         (PolicyDelegate::decidePolicyForNewWindowAction):
2040         (PolicyDelegate::decidePolicyForMIMEType):
2041         (PolicyDelegate::unableToImplementPolicyWithError):
2042
2043 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2044
2045         Reviewed by Mark.
2046
2047         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2048         when querying for QMAKE_MKSPECS.
2049
2050 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2051
2052         Reviewed by Adam Roben.
2053         
2054         Fix run-webkit-tests is too greedy calculating platform hierarchy
2055         http://bugs.webkit.org/show_bug.cgi?id=15465
2056         
2057         Fix run-webkit-tests being too greedy in trying to split the platform name up
2058         causing it to try and find tests in every directory above the first "-" in the
2059         path to the LayoutTests
2060
2061         * Scripts/run-webkit-tests:
2062
2063 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2064
2065         Reviewed by Darin.
2066
2067         http://bugs.webkit.org/show_bug.cgi?id=15006
2068         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2069         to reduce code duplication.
2070
2071         * Scripts/build-webkit:
2072         * Scripts/webkitdirs.pm:
2073         buildQMakeProject() renamed to buildQMakeQtProject().
2074         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2075         unused $colorize has been removed.
2076
2077 === Start merge of feature-branch 2007-10-12 ===
2078
2079 2007-10-08  Eric Seidel  <eric@webkit.org>
2080
2081         Reviewed by Mark Rowe.
2082
2083         * Scripts/build-webkit: add --help, remove unused --color
2084
2085 2007-10-07  Eric Seidel  <eric@webkit.org>
2086
2087         Reviewed by darin.
2088
2089         * Drosera/mac/DebuggerDocumentPlatform.mm:
2090         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2091
2092 2007-10-03  Rob Buis  <buis@kde.org>
2093
2094         Reviewed by Olliej.
2095
2096         Adapt to changed location of Ahem font.
2097
2098         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2099
2100 2007-10-02  Eric Seidel  <eric@webkit.org>
2101
2102         Reviewed by Adam Roben.
2103         
2104         Make pixel tests more useful!
2105         Finally fix the image diff 0.00% mystery problem
2106         Highlight any image differences in the image diff.
2107         Add a link from image diffs back to original test file.
2108
2109         * DumpRenderTree/mac/ImageDiff.m:
2110         (compareImages): highlight any differences
2111         (computePercentageDifferent): round to two decimal places
2112         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2113
2114 2007-10-02  Eric Seidel  <eric@webkit.org>
2115
2116         Reviewed by Alexey Proskuryakov.
2117
2118         * Scripts/run-webkit-tests: print the % image difference on main results page
2119
2120 2007-10-02  Mark Rowe  <mrowe@apple.com>
2121
2122         Reviewed by Oliver.
2123
2124         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2125
2126         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2127         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2128
2129 2007-10-01  Mark Rowe  <mrowe@apple.com>
2130
2131         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2132
2133 2007-09-25  Eric Seidel  <eric@webkit.org>
2134
2135         Reviewed by Mark Rowe.
2136         
2137         DerivedSources.make was finding "ENABLE_SVG" in the string
2138         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2139         quite correctly.
2140
2141         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2142
2143 2007-09-25  Mark Rowe  <mrowe@apple.com>
2144
2145         Rubber-stamped by Eric.
2146
2147         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2148         This makes it possible to automate nightly builds for the feature-branch.
2149
2150 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2151
2152         Rubber stamped by Mark.
2153
2154         Enable svg experimental features as default here in feature-branch.
2155
2156         * Scripts/build-webkit:
2157
2158 2007-06-29  Antti Koivisto  <antti@apple.com>
2159
2160         Reviewed by Weinig.
2161         
2162         Add VIDEO flag for timed media features
2163
2164         * Scripts/build-webkit
2165         
2166 === End merge of feature-branch 2007-10-12 ===
2167
2168 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2169
2170         Reviewed by Darin.
2171
2172         - Updated rational for the leaks list to be more clear.
2173
2174         * Scripts/run-webkit-tests:
2175
2176 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2177
2178         Rubber Stamp by Sam.
2179
2180         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2181         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2182
2183         * Scripts/run-webkit-tests:
2184
2185 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2186
2187         Reviewed by Lars.
2188
2189         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2190         includes are needed for INT_MAX, std::auto_ptr and the like.
2191
2192         * DumpRenderTree/qt/main.cpp:
2193
2194 2007-10-09  Lars Knoll  <lars@trolltech.com>
2195
2196         Reviewed by Simon.
2197
2198         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2199
2200         * DumpRenderTree/qt/jsobjects.cpp:
2201         (LayoutTestController::encodeHostName):
2202         (LayoutTestController::decodeHostName):
2203         * DumpRenderTree/qt/jsobjects.h:
2204
2205 2007-10-09  Lars Knoll  <lars@trolltech.com>
2206
2207         Reviewed by Simon.
2208
2209         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2210
2211         * DumpRenderTree/qt/DumpRenderTree.cpp:
2212         (WebCore::WebPage::createFrame):
2213         (WebCore::DumpRenderTree::DumpRenderTree):
2214         (WebCore::DumpRenderTree::titleChanged):
2215         * DumpRenderTree/qt/DumpRenderTree.h:
2216         * DumpRenderTree/qt/jsobjects.cpp:
2217         (LayoutTestController::reset):
2218         * DumpRenderTree/qt/jsobjects.h:
2219
2220 2007-10-09  Lars Knoll  <lars@trolltech.com>
2221
2222         Reviewed by Simon.
2223
2224         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2225
2226         * DumpRenderTree/qt/DumpRenderTree.h:
2227         * DumpRenderTree/qt/jsobjects.cpp:
2228         (LayoutTestController::clearBackForwardList):
2229         * DumpRenderTree/qt/jsobjects.h:
2230
2231 2007-10-09  Lars Knoll  <lars@trolltech.com>
2232
2233         Reviewed by Simon.
2234
2235         make --git-reviewer work again.
2236
2237         * Scripts/prepare-ChangeLog:
2238
2239 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2240
2241         Rubber stamped by Eric.
2242
2243         Connect to the "hovering-over-link" signal emitted by WebKitPage and
2244         show the current link inside the statusbar.
2245         This shows how to make use of this signal and allows to easily test
2246         http://bugs.webkit.org/show_bug.cgi?id=15299.
2247
2248         * GtkLauncher/main.cpp:
2249         (hoveringOverLink):
2250         (main):
2251
2252 2007-10-05  Lars Knoll  <lars@trolltech.com>
2253
2254         add proper error messages to the FrameLoaderClient.
2255         Implement ChromeClientQt::closeWindowSoon and
2256         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2257         Some fixes in DRT to make it work correctly with multiple windows.
2258
2259         Reviewed by Maciej.
2260
2261         * DumpRenderTree/qt/DumpRenderTree.cpp:
2262         (WebCore::DumpRenderTree::DumpRenderTree):
2263         (WebCore::DumpRenderTree::createWindow):
2264         (WebCore::DumpRenderTree::windowCount):
2265         * DumpRenderTree/qt/DumpRenderTree.h:
2266         * DumpRenderTree/qt/jsobjects.cpp:
2267         (LayoutTestController::maybeDump):
2268         (LayoutTestController::windowCount):
2269         * DumpRenderTree/qt/jsobjects.h:
2270
2271 2007-10-05  Lars Knoll  <lars@trolltech.com>
2272
2273         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
2274         Add support for layoutTextController.setCanOpenWindows() to DRT
2275         fixing another 2 test cases in fast/dom/Window.
2276
2277         Reviewed by Maciej.
2278
2279         * DumpRenderTree/qt/DumpRenderTree.cpp:
2280         (WebCore::WebPage::WebPage):
2281         (WebCore::WebPage::createWindow):
2282         (WebCore::DumpRenderTree::resetJSObjects):
2283         (WebCore::DumpRenderTree::createWindow):
2284         * DumpRenderTree/qt/DumpRenderTree.h:
2285         * DumpRenderTree/qt/DumpRenderTree.pro:
2286         * DumpRenderTree/qt/jsobjects.cpp:
2287         (LayoutTestController::LayoutTestController):
2288         (LayoutTestController::reset):
2289         * DumpRenderTree/qt/jsobjects.h:
2290         * DumpRenderTree/qt/main.cpp:
2291         * DumpRenderTree/qt/testplugin.cpp: Added.
2292         * DumpRenderTree/qt/testplugin.h: Added.
2293
2294 2007-10-04  Sam Weinig  <sam@webkit.org>
2295
2296         Rubber stamped by Adam.
2297
2298         Remove empty directories.
2299
2300         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2301         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2302
2303 2007-10-03  Darin Adler  <darin@apple.com>
2304
2305         Reviewed by Adam.
2306
2307         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2308         we find the internal libraries in the libraries directory. This
2309         is helpful for Safari team engineers at Apple.
2310
2311 2007-10-03  Adam Roben  <aroben@apple.com>
2312
2313         Update the location of AHEM___.TTF after r25968
2314
2315         Reviewed by Sam.
2316
2317         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2318
2319 2007-10-03  Alp Toker  <alp@atoker.com>
2320
2321         Reviewed by Adam.
2322
2323         http://bugs.webkit.org/show_bug.cgi?id=14726
2324         [gtk] API design. Mapping the WebView delegates to signals.
2325
2326         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2327
2328         * GtkLauncher/main.cpp:
2329         (goToURLBarText):
2330         (titleChanged):
2331         (progressChanged):
2332         (menuMainBackCallback):
2333         (menuMainForwardCallback):
2334         (main):
2335
2336 2007-10-03  Lars Knoll  <lars@trolltech.com>
2337
2338         Reviewed by Rob.
2339
2340         This fixes --strict mode in run-webkit-tests again after
2341         the platform dependent test results have been moved.
2342
2343         * Scripts/run-webkit-tests:
2344
2345 2007-10-03  Lars Knoll  <lars@trolltech.com>
2346
2347         Reviewed by bdash.
2348
2349         remove the hack in run-webkit-tests that forced text only test
2350         to be taken from the platform independent dir. It was only left
2351         there from early days.
2352         
2353         Remove platform dependent results for tests that are text only nowadays,
2354         and add one platform dependent result for a text only test that requires it.
2355
2356         * Scripts/run-webkit-tests:
2357
2358 2007-10-03  Lars Knoll  <lars@trolltech.com>
2359
2360         Reviewed by olliej.
2361
2362         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2363
2364         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2365         (WebCore::WebFrame::WebFrame):
2366         (WebCore::WebPage::WebPage):
2367         (WebCore::WebPage::createFrame):
2368         (WebCore::WebPage::javaScriptAlert):
2369         (WebCore::WebPage::javaScriptConsoleMessage):
2370         (WebCore::DumpRenderTree::DumpRenderTree):
2371         (WebCore::DumpRenderTree::~DumpRenderTree):
2372         (WebCore::DumpRenderTree::open):
2373         (WebCore::DumpRenderTree::readStdin):
2374         (WebCore::DumpRenderTree::resetJSObjects):
2375         (WebCore::DumpRenderTree::initJSObjects):
2376         (WebCore::DumpRenderTree::dumpFramesAsText):
2377         (WebCore::DumpRenderTree::dump):
2378         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2379         (WebCore::DumpRenderTree::layoutTestController):
2380         (WebCore::DumpRenderTree::eventSender):
2381         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2382         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2383         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2384         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2385         (HackWebFrame::mousePressEvent):
2386         (HackWebFrame::mouseReleaseEvent):
2387         (HackWebFrame::mouseMoveEvent):
2388         (HackWebFrame::HackWebFrame):
2389         (HackWebFrame::~HackWebFrame):
2390         (LayoutTestController::LayoutTestController):
2391         (LayoutTestController::reset):
2392         (LayoutTestController::maybeDump):
2393         (LayoutTestController::waitUntilDone):
2394         (LayoutTestController::notifyDone):
2395         (LayoutTestController::dumpEditingCallbacks):
2396         (LayoutTestController::queueReload):
2397         (LayoutTestController::provisionalLoad):
2398         (LayoutTestController::timerEvent):
2399         (EventSender::EventSender):
2400         (EventSender::mouseDown):
2401         (EventSender::mouseUp):
2402         (EventSender::mouseMoveTo):
2403         (EventSender::leapForward):
2404         (EventSender::keyDown):
2405         (EventSender::frameUnderMouse):
2406         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2407         (LayoutTestController::isLoading):
2408         (LayoutTestController::setLoading):
2409         (LayoutTestController::shouldDumpAsText):
2410         (LayoutTestController::shouldDumpChildrenAsText):
2411         (LayoutTestController::shouldWaitUntilDone):
2412         (LayoutTestController::dumpAsText):
2413         (LayoutTestController::dumpChildFramesAsText):
2414         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2415         (messageHandler):
2416         (crashHandler):
2417         (main):
2418         * Scripts/run-webkit-tests:
2419
2420 2007-10-03  Mark Rowe  <mrowe@apple.com>
2421
2422         Reviewed by Alp Toker.
2423
2424         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2425         should take precedence over QTDIR when determining which port we are working with.
2426
2427         * Scripts/webkitdirs.pm: 
2428
2429 2007-10-02  Adam Roben  <aroben@apple.com>
2430
2431         Add keychain to the list of default packages to install
2432
2433         Rubberstamped by Sam.
2434
2435         * CygwinDownloader/cygwin-downloader.py:
2436         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2437
2438 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2439
2440         Reviewed by Adam.
2441
2442         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2443         Also makes WebCore regression test case logic work when using git.
2444
2445         * Scripts/prepare-ChangeLog:
2446         (reviewerAndDescriptionForGitCommit): Added.
2447
2448 2007-10-02  Lars Knoll  <lars@trolltech.com>
2449
2450         Reviewed by bdash.
2451
2452         Add API to retrieve the frame name from QWebFrame.
2453         Implement support for DRT::dumpChildrenAsText.
2454
2455         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2456         (WebCore::DumpRenderTree::dumpFramesAsText):
2457         (WebCore::DumpRenderTree::dump):
2458         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2459         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2460         (LayoutTestController::LayoutTestController):
2461         (LayoutTestController::reset):
2462         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2463
2464 2007-10-02  Lars Knoll  <lars@trolltech.com>
2465
2466         Reviewed by bdash.
2467
2468         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2469
2470         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2471         (WebCore::DumpRenderTree::readStdin):
2472
2473 2007-10-02  Mark Rowe  <mrowe@apple.com>
2474
2475         Reviewed by Oliver.
2476
2477         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2478
2479         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2480         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2481
2482 2007-10-02  Mark Rowe  <mrowe@apple.com>
2483
2484         Rubber-stamped by Maciej.
2485
2486         Configuration changes from build.webkit.org.  The major change is refactoring to work
2487         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2488         last few weeks.
2489
2490         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2491         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2492         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2493         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2494         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2495         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2496         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2497         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2498
2499 2007-10-02  Lars Knoll  <lars@trolltech.com>
2500
2501         Reviewed by Maciej.
2502
2503         Add support for eventSender.mouseMove to DRT.
2504         Fixes fast/css/hover-affects-child.html
2505
2506         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2507         (EventSender::mouseMoveTo):
2508
2509 2007-10-01  Mark Rowe  <mrowe@apple.com>
2510
2511         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2512
2513 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
2514
2515         Reviewed by Hyatt.
2516
2517         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
2518
2519         * Scripts/svn-apply:
2520         (gitdiff2svndiff): Ignore lines beginning with "new file".
2521         * Scripts/svn-unapply:
2522         (gitdiff2svndiff): Ditto.
2523
2524 2007-09-30  George Staikos  <staikos@kde.org>
2525
2526         Qt build fix (Mac OS X specific)
2527
2528         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2529
2530 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2531
2532         Reviewed by Mark.
2533
2534         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
2535         Remove Bakefiles from svn.
2536
2537         * GtkLauncher/Bakefiles.bkgen: Removed.
2538         * GtkLauncher/ENV: Removed.
2539         * GtkLauncher/gdklauncher.bkl: Removed.
2540         * GtkLauncher/mk: Removed.
2541         * Scripts/regenerate-makefiles: Removed.
2542
2543 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
2544
2545         Reviewed by John.
2546
2547         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
2548
2549         * Scripts/run-webkit-tests:
2550
2551 2007-09-26  Adam Roben  <aroben@apple.com>
2552
2553         Make not finding an installed WebKit non-fatal
2554
2555         What really matters is that we are able to load WebKit and its
2556         dependencies, not whether we think we've found an installed WebKit.
2557
2558         Reviewed by Sam.
2559
2560         * WebKitInitializer/WebKitInitializer.cpp:
2561         (getWebViewCLSID): Use new LOG_WARNING macro.
2562         (getInstalledWebKitDirectory): Ditto.
2563         (initializeWebKit): Don't die if we didn't find an installed WebKit,
2564         and use new macros.
2565         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
2566
2567 2007-09-26  Adam Roben  <aroben@apple.com>
2568
2569         Committed this file before saving it
2570
2571         * WebKitInitializer/debug_internal.vsprops:
2572
2573 2007-09-26  Adam Roben  <aroben@apple.com>
2574
2575         Load WebKit and its dependencies manually so they come from DllDirectory
2576
2577         I had to change WebKitInitializer to use malloc/free instead of
2578         new/delete to avoid pulling in WebKit (and its dependencies) early
2579         through use of fastMalloc.
2580
2581         Reviewed by Oliver.
2582
2583         * WebKitInitializer/WebKitInitializer.cpp:
2584         (getStringValue): Changed to use malloc/free.
2585         (getInstalledWebKitDirectory): Ditto.
2586         (initializeWebKit): Call SetDllDirectory first, then load all of
2587         WebKit's dependencies manually, finally followed by WebKit itself.
2588         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
2589         configuration to match our other projects.
2590         * WebKitInitializer/debug_internal.vsprops: Added.
2591
2592 2007-09-25  Adam Roben  <aroben@apple.com>
2593
2594         Actually define DEBUG/NDEBUG so that we load WebKit correctly
2595
2596         Rubberstamped by Sam.
2597
2598         * WebKitInitializer/WebKitInitializer.vcproj:
2599
2600 2007-09-25  Adam Roben  <aroben@apple.com>
2601
2602         Make DumpRenderTree delay-load its dependencies
2603
2604         This lets WebKitInitializer re-route the dependencies to be loaded out
2605         of the Safari installation directory.
2606
2607         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
2608         same thing), since we can't import the kCFAllocatorDefault symbol when
2609         delay-loading CoreFoundation.dll.
2610
2611         Rubberstamped by Sam.
2612
2613         * DumpRenderTree/win/DumpRenderTree.cpp:
2614         (runTest):
2615         (javaScriptThreads):
2616         * DumpRenderTree/win/DumpRenderTree.vcproj:
2617         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2618         (LayoutTestController::setWaitToDump):
2619
2620 2007-09-25  Adam Roben  <aroben@apple.com>
2621
2622         Pull ole32.lib into WebKitInitializer
2623
2624         Rubberstamped by Sam.
2625
2626         * WebKitInitializer/WebKitInitializer.vcproj:
2627
2628 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2629
2630         Reviewed by Adam.
2631
2632         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
2633           LGPL'ed files contain incorrect FSF address
2634
2635         * Drosera/config.h:
2636
2637 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2638
2639         Reviewed by Adam.
2640
2641         Make svn-apply and svn-unapply work with git-diff formatted patches.
2642
2643         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
2644         (gitdiff2svndiff): Added.
2645         * Scripts/svn-unapply: Ditto.
2646         (gitdiff2svndiff): Added.
2647
2648 2007-09-25  Adam Roben  <aroben@apple.com>
2649
2650         Pull advapi32.lib into WebKitInitializer
2651
2652         This is needed to get the registry functions we use.
2653
2654         Rubberstamped by Sam.
2655
2656         * WebKitInitializer/WebKitInitializer.vcproj:
2657
2658 2007-09-25  Adam Roben  <aroben@apple.com>
2659
2660         Add python and rsync to cygwin-downloader
2661
2662         Our build slaves need this, and it can't hurt for everyone else to
2663         have it, too.
2664
2665         Reviewed by Sam.
2666
2667         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
2668         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2669
2670 2007-09-25  Adam Roben  <aroben@apple.com>
2671
2672         Add WebKitInitializer and use it in DumpRenderTree
2673
2674         WebKitInitializer is a static library that has one function,
2675         initializeWebKit(). This registers WebKit and sets up the DLL search
2676         path so that WebKit's dependencies that are installed with Safari can
2677         be found.
2678
2679         Reviewed by Sam.
2680
2681         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
2682         DumpRenderTree depend on it.
2683         * DumpRenderTree/win/DumpRenderTree.cpp:
2684         (initialize): Call initializeWebKit.
2685         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
2686         WebKitInitializer.lib.
2687         * WebKitInitializer/WebKitInitializer.cpp: Added.
2688         (getStringValue):
2689         (getWebViewCLSID):
2690         (getInstalledWebKitDirectory):
2691         (initializeWebKit):
2692         * WebKitInitializer/WebKitInitializer.h: Added.
2693         * WebKitInitializer/WebKitInitializer.vcproj: Added.
2694         * WebKitInitializer/debug.vsprops: Added.
2695         * WebKitInitializer/release.vsprops: Added.
2696
2697 2007-09-25  Adam Roben  <aroben@apple.com>
2698
2699         Make run-webkit-tests respect set-webkit-configuration
2700
2701         Reviewed by Sam.
2702
2703         * Scripts/run-webkit-tests: Initialize $configuration to whatever
2704         set-webkit-configuration was last set to.
2705
2706 2007-09-25  Mark Rowe  <mrowe@apple.com>
2707
2708         Rubber-stamped by Eric.
2709
2710         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2711         This makes it possible to automate nightly builds for the feature-branch.
2712
2713 2007-09-25  Adam Roben  <aroben@apple.com>
2714
2715         A couple of fixes/enhancements to update-webkit-*-libs
2716
2717         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
2718         to tell update-webkit-support-libraries where it should find the
2719         WebKitSupportLibrary.zip file you downloaded.
2720
2721         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
2722         Windows-style path.
2723
2724         Reviewed by Sam.
2725
2726         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
2727         to $auxiliaryLibsURL and removed an irrelevant comment.
2728         * Scripts/update-webkit-support-libs:
2729
2730 2007-09-25  Adam Treat  <treat@kde.org>
2731
2732         Reviewed by Simon and Lars.
2733
2734         Refactors and cleans up Qt DRT member variable names, member variable
2735         initialization, style fixes and general code cleanup.
2736
2737         Adds queueReload slot to LayoutTestController that some tests require.
2738
2739         Subclasses QWebFrame to make sure that all frames have an associated
2740         LayoutTestController JS window object.
2741
2742         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
2743         aren't dumped twice.
2744
2745         EOF fixes.
2746
2747         Together, this patch fixes some 20+ layout tests in QtWebKit.
2748
2749         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2750         (WebCore::WebFrame::WebFrame):
2751         (WebCore::WebPage::WebPage):
2752         (WebCore::WebPage::createFrame):
2753         (WebCore::DumpRenderTree::DumpRenderTree):
2754         (WebCore::DumpRenderTree::open):
2755         (WebCore::DumpRenderTree::readStdin):
2756         (WebCore::DumpRenderTree::initJSObjects):
2757         (WebCore::DumpRenderTree::dump):
2758         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2759         (WebCore::DumpRenderTree::layoutTestController):
2760         (WebCore::DumpRenderTree::eventSender):
2761         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2762         (LayoutTestController::LayoutTestController):
2763         (LayoutTestController::reset):
2764         (LayoutTestController::maybeDump):
2765         (LayoutTestController::waitUntilDone):
2766         (LayoutTestController::notifyDone):
2767         (LayoutTestController::queueReload):
2768         (LayoutTestController::provisionalLoad):
2769         (EventSender::EventSender):
2770         (EventSender::mouseDown):
2771         (EventSender::mouseUp):
2772         (EventSender::mouseMoveTo):
2773         (EventSender::frameUnderMouse):
2774         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2775         (LayoutTestController::isLoading):
2776         (LayoutTestController::setLoading):
2777         (LayoutTestController::dumpAsText):
2778         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2779         (main):
2780
2781 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2782
2783
2784         - Reverted an accidentally checked in file.
2785
2786         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
2787
2788 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2789         Reviewed by Sam.
2790
2791         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
2792
2793         * DumpRenderTree/win/DumpRenderTree.vcproj:
2794         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2795
2796 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2797
2798         Rubber stamped by Adam.
2799
2800         * GdkLauncher: Removed.
2801         * GdkLauncher/Bakefiles.bkgen: Removed.
2802         * GdkLauncher/ENV: Removed.
2803         * GdkLauncher/GdkLauncher.pro: Removed.
2804         * GdkLauncher/gdklauncher.bkl: Removed.
2805         * GdkLauncher/main.cpp: Removed.
2806         * GdkLauncher/mk: Removed.
2807         * GdkLauncher/simple.svg: Removed.
2808         * GdkLauncher/text.html: Removed.
2809         * GtkLauncher: Added.
2810         * GtkLauncher/GdkLauncher.pro: Removed.
2811         * GtkLauncher/GtkLauncher.pro: Added.
2812         * GtkLauncher/main.cpp:
2813         (updateWindowTitle):
2814         (main):
2815         * Scripts/build-webkit:
2816         * Scripts/regenerate-makefiles:
2817         * Scripts/run-javascriptcore-tests:
2818         * Scripts/run-launcher:
2819         * Scripts/run-webkit-tests:
2820         * Scripts/webkitdirs.pm:
2821
2822 2007-09-21  Timothy Hatcher  <timothy@apple.com>
2823
2824         Reviewed by Darin.
2825
2826         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
2827
2828         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
2829         This is tested by plugins/root-object-premature-delete-crash.html.
2830
2831         * DumpRenderTree/mac/ObjCController.m:
2832         (-[ObjCController accessStoredWebScriptObject]):
2833
2834 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
2835
2836         Reviewed by Oliver.
2837
2838         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
2839
2840         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2841         (FrameLoadDelegate::FrameLoadDelegate):
2842
2843 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
2844
2845         Reviewed by Adam.
2846
2847         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
2848         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
2849
2850         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
2851         Now isQt() and isGdk() use global variables that are only set once.
2852
2853         An array of all the parameters is now given to build-dumprender which includes
2854         the platform on linux.
2855
2856         * Scripts/build-dumprendertree:
2857         * Scripts/run-webkit-tests:
2858         * Scripts/webkitdirs.pm:
2859
2860 2007-09-19  Adam Roben  <aroben@apple.com>
2861
2862         Rubberstamped by Hyatt.
2863
2864         * Spinneret: Removed.
2865
2866 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
2867
2868         Reviewed by David Kilzer.
2869
2870         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
2871
2872 2007-09-18  Sam Weinig  <sam@webkit.org>
2873
2874         Add JSRetainPtr.h #include to fix some builds.
2875
2876         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2877
2878 2007-09-18  Mike Hommey  <glandium@debian.org>
2879
2880         Reviewed by Adam.
2881
2882         * Scripts/prepare-ChangeLog:
2883         - Properly parse GECOS field.
2884         - Use git configuration for user name and email when appropriate.
2885
2886 2007-09-17  Sam Weinig  <sam@webkit.org>
2887
2888         Build fix.
2889
2890         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2891
2892 2007-09-17  Sam Weinig  <sam@webkit.org>
2893
2894         Reviewed by Adam Roben.
2895
2896         Share more code between mac and windows DRT.
2897             - GCController is now shared.
2898             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
2899
2900         * DumpRenderTree/GCController.cpp:
2901         * DumpRenderTree/win/DumpRenderTree.cpp:
2902         * DumpRenderTree/win/DumpRenderTree.vcproj:
2903         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
2904         (FrameLoadDelegate::FrameLoadDelegate):
2905         (FrameLoadDelegate::~FrameLoadDelegate):
2906         (FrameLoadDelegate::windowScriptObjectAvailable):
2907         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
2908         * DumpRenderTree/win/GCController.cpp: Removed.
2909         * DumpRenderTree/win/GCController.h: Removed.
2910         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
2911         (GCController::collect):
2912         (GCController::collectOnAlternateThread):
2913         (GCController::getJSObjectCount):
2914         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
2915         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
2916
2917 2007-09-17  Sam Weinig  <sam@webkit.org>
2918
2919         Reviewed by Adam Roben.
2920
2921         Begin sharing code between mac and windows DRT.
2922             - both now share LayoutTestController.h/cpp and implement platform dependant 
2923               operations in LayoutTestControllerMac/Win.
2924             - DumpRenderTree.h is now shared.
2925             - WorkQueue and WorkQueueItem are also shared.
2926
2927         * DumpRenderTree/DumpRenderTree.h:
2928         * DumpRenderTree/LayoutTestController.cpp:
2929         * DumpRenderTree/win/DumpRenderTree.cpp:
2930         (displayWebView):
2931         (dumpFrameScrollPosition):
2932         (dumpFramesAsText):
2933         (dump):
2934         (runTest):
2935         * DumpRenderTree/win/DumpRenderTree.h: Removed.
2936         * DumpRenderTree/win/DumpRenderTree.vcproj:
2937         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
2938         * DumpRenderTree/win/EditingDelegate.cpp:
2939         (EditingDelegate::shouldBeginEditingInDOMRange):
2940         (EditingDelegate::shouldEndEditingInDOMRange):
2941         (EditingDelegate::shouldInsertNode):
2942         (EditingDelegate::shouldInsertText):
2943         (EditingDelegate::shouldDeleteDOMRange):
2944         (EditingDelegate::shouldChangeSelectedDOMRange):
2945         (EditingDelegate::shouldApplyStyle):
2946         (EditingDelegate::shouldChangeTypingStyle):
2947         (EditingDelegate::doPlatformCommand):
2948         (EditingDelegate::webViewDidBeginEditing):
2949         (EditingDelegate::webViewDidChange):
2950         (EditingDelegate::webViewDidEndEditing):
2951         (EditingDelegate::webViewDidChangeTypingStyle):
2952         (EditingDelegate::webViewDidChangeSelection):
2953         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2954         * DumpRenderTree/win/LayoutTestController.h: Removed.
2955         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2956         (LayoutTestController::addDisallowedURL):
2957         (LayoutTestController::clearBackForwardList):
2958         (LayoutTestController::copyDecodedHostName):
2959         (LayoutTestController::copyEncodedHostName):
2960         (LayoutTestController::display):
2961         (LayoutTestController::keepWebHistory):
2962         (LayoutTestController::notifyDone):
2963         (LayoutTestController::queueBackNavigation):
2964         (LayoutTestController::queueForwardNavigation):
2965         (jsStringRefToWString):
2966         (LayoutTestController::queueLoad):
2967         (LayoutTestController::queueReload):
2968         (LayoutTestController::queueScript):
2969         (LayoutTestController::setAcceptsEditing):
2970         (LayoutTestController::setCustomPolicyDelegate):
2971         (LayoutTestController::setMainFrameIsFirstResponder):
2972         (LayoutTestController::setTabKeyCyclesThroughElements):
2973         (LayoutTestController::setUseDashboardCompatibilityMode):
2974         (LayoutTestController::setUserStyleSheetEnabled):
2975         (LayoutTestController::setUserStyleSheetLocation):
2976         (LayoutTestController::setWindowIsKey):
2977         (waitUntilDoneWatchdogFired):
2978         (LayoutTestController::setWaitToDump):
2979         (LayoutTestController::windowCount):
2980         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2981         (FrameLoadDelegate::didReceiveTitle):
2982         (FrameLoadDelegate::processWork):
2983         (FrameLoadDelegate::locationChangeDone):
2984         (FrameLoadDelegate::windowScriptObjectAvailable):
2985         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2986         * DumpRenderTree/win/WorkQueue.h: Removed.
2987         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2988         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2989         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2990         (jsStringRefToWString):
2991         (LoadItem::invoke):
2992         (ScriptItem::invoke):
2993
2994 2007-09-17  Sam Weinig  <sam@webkit.org>
2995
2996         Reviewed by Adam Roben.
2997
2998         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2999
3000         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
3001         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
3002         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
3003         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
3004         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
3005         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
3006         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
3007         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
3008         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
3009         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
3010         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
3011         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
3012         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
3013         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
3014         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
3015         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
3016         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
3017         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
3018         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
3019         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
3020         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
3021         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
3022         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
3023         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
3024         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
3025         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
3026         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
3027         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
3028         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
3029         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
3030         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
3031         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
3032         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
3033         * DumpRenderTree/win: Added.
3034         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
3035         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
3036         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
3037         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
3038         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
3039         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
3040         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
3041         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
3042         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
3043         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
3044         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
3045         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
3046         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
3047         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3048         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
3049         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
3050         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
3051         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
3052         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3053         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3054         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
3055         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3056         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
3057         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
3058         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
3059         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
3060
3061 2007-09-15  Mark Rowe  <mrowe@apple.com>
3062
3063         Build fix for DumpRenderTree.
3064
3065         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
3066
3067 2007-09-14  Sam Weinig  <sam@webkit.org>
3068
3069         Rubber stamped by Adam Roben.
3070
3071         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
3072           - The UIDelegate was put into a new file while the FrameLoadDelegate was
3073             kept in the WaitUntilDoneDelegate file for the time being.
3074
3075         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3076         (main):
3077         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
3078         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
3079         (UIDelegate::QueryInterface):
3080         (UIDelegate::AddRef):
3081         (UIDelegate::Release):
3082         (UIDelegate::hasCustomMenuImplementation):
3083         (UIDelegate::setFrame):
3084         (UIDelegate::webViewFrame):
3085         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3086         (UIDelegate::webViewAddMessageToConsole):
3087         (UIDelegate::doDragDrop):
3088         (UIDelegate::webViewGetDlgCode):
3089         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
3090         (UIDelegate::UIDelegate):
3091         (UIDelegate::createWebViewWithRequest):
3092         (UIDelegate::webViewShow):
3093         (UIDelegate::webViewClose):
3094         (UIDelegate::webViewFocus):
3095         (UIDelegate::webViewUnfocus):
3096         (UIDelegate::webViewFirstResponder):
3097         (UIDelegate::makeFirstResponder):
3098         (UIDelegate::setStatusText):
3099         (UIDelegate::webViewStatusText):
3100         (UIDelegate::webViewAreToolbarsVisible):
3101         (UIDelegate::setToolbarsVisible):
3102         (UIDelegate::webViewIsStatusBarVisible):
3103         (UIDelegate::setStatusBarVisible):
3104         (UIDelegate::webViewIsResizable):
3105         (UIDelegate::setResizable):
3106         (UIDelegate::setContentRect):
3107         (UIDelegate::webViewContentRect):
3108         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3109         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3110         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3111         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
3112         (UIDelegate::mouseDidMoveOverElement):
3113         (UIDelegate::contextMenuItemsForElement):
3114         (UIDelegate::validateUserInterfaceItem):
3115         (UIDelegate::shouldPerformAction):
3116         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
3117         (UIDelegate::willPerformDragDestinationAction):
3118         (UIDelegate::dragSourceActionMaskForPoint):
3119         (UIDelegate::willPerformDragSourceAction):
3120         (UIDelegate::contextMenuItemSelected):
3121         (UIDelegate::trackCustomPopupMenu):
3122         (UIDelegate::measureCustomMenuItem):
3123         (UIDelegate::drawCustomMenuItem):
3124         (UIDelegate::addCustomMenuDrawingData):
3125         (UIDelegate::cleanUpCustomMenuDrawingData):
3126         (UIDelegate::canTakeFocus):
3127         (UIDelegate::takeFocus):
3128         (UIDelegate::registerUndoWithTarget):
3129         (UIDelegate::removeAllActionsWithTarget):
3130         (UIDelegate::setActionTitle):
3131         (UIDelegate::undo):
3132         (UIDelegate::redo):
3133         (UIDelegate::canUndo):
3134         (UIDelegate::canRedo):
3135         (UIDelegate::webViewResizerRect):
3136         (UIDelegate::webViewDrawResizer):
3137         (UIDelegate::webViewScrolled):
3138         (UIDelegate::webViewShouldInterruptJavaScript):
3139         (UIDelegate::webViewReceivedFocus):
3140         (UIDelegate::webViewLostFocus):
3141         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
3142         (FrameLoadDelegate::QueryInterface):
3143         (FrameLoadDelegate::AddRef):
3144         (FrameLoadDelegate::Release):
3145         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3146         (FrameLoadDelegate::didCommitLoadForFrame):
3147         (FrameLoadDelegate::didReceiveTitle):
3148         (FrameLoadDelegate::processWork):
3149         (processWorkTimer):
3150         (FrameLoadDelegate::locationChangeDone):
3151         (FrameLoadDelegate::didFinishLoadForFrame):
3152         (FrameLoadDelegate::didFailLoadWithError):
3153         (FrameLoadDelegate::windowScriptObjectAvailable):
3154         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
3155         (FrameLoadDelegate::FrameLoadDelegate):
3156
3157 2007-09-14  Sam Weinig  <sam@webkit.org>
3158
3159         Reviewed by Kevin McCullough.
3160
3161         Move mac specific globals in to mac/DumpRenderTreeMac.h
3162
3163         * DumpRenderTree/DumpRenderTree.h:
3164         * DumpRenderTree/DumpRenderTree.mm: Removed.
3165         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3166         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
3167         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
3168
3169 2007-09-14  Brady Eidson  <beidson@apple.com>
3170
3171         Rubberstamped by Weinig
3172
3173         You know, Sam, some of us use case-sensitve filesystems...
3174
3175         * DumpRenderTree/DumpRenderTree.h:
3176         * DumpRenderTree/mac/UIDelegate.mm:
3177
3178 2007-09-14  Sam Weinig  <sam@webkit.org>
3179
3180         Rubber stamped by Adam Roben.
3181
3182         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
3183         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
3184
3185         * DumpRenderTree/AppleScriptController.h: Removed.
3186         * DumpRenderTree/AppleScriptController.m: Removed.
3187         * DumpRenderTree/DumpRenderTree.h:
3188         * DumpRenderTree/DumpRenderTree.mm:
3189         (startJavaScriptThreads):
3190         (stopJavaScriptThreads):
3191         (activateAhemFont):
3192         (setDefaultColorProfileToRGB):
3193         (makeLargeMallocFailSilently):
3194         (dumpFrameScrollPosition):
3195         (dumpFramesAsText):
3196         (dump):
3197         (runTest):
3198         (-[DumpRenderTreeWindow isKeyWindow]):
3199         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3200         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
3201         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
3202         * DumpRenderTree/EditingDelegate.h: Removed.
3203         * DumpRenderTree/EditingDelegate.m: Removed.
3204         * DumpRenderTree/EventSendingController.h: Removed.
3205         * DumpRenderTree/EventSendingController.m: Removed.
3206         * DumpRenderTree/FrameLoadDelegate.h: Removed.
3207         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
3208         * DumpRenderTree/GCController.mm: Removed.
3209         * DumpRenderTree/ImageDiff.m: Removed.
3210         * DumpRenderTree/LayoutTestController.cpp:
3211         (LayoutTestController::LayoutTestController):
3212         (dumpAsTextCallback):
3213         (dumpBackForwardListCallback):
3214         (dumpChildFramesAsTextCallback):
3215         (dumpChildFrameScrollPositionsCallback):
3216         (dumpDOMAsWebArchiveCallback):
3217         (dumpEditingCallbacksCallback):
3218         (dumpFrameLoadCallbacksCallback):
3219         (dumpResourceLoadCallbacksCallback):
3220         (dumpSelectionRectCallback):
3221         (dumpSourceAsWebArchiveCallback):
3222         (dumpTitleChangesCallback):
3223         (repaintSweepHorizontallyCallback):
3224         (setCallCloseOnWebViewsCallback):
3225         (setCanOpenWindowsCallback):
3226         (setCloseRemainingWindowsWhenCompleteCallback):
3227         (testRepaintCallback):
3228         (addFileToPasteboardOnDragCallback):
3229         (waitUntilDoneCallback):
3230         * DumpRenderTree/LayoutTestController.h:
3231         (LayoutTestController::dumpAsText):
3232         (LayoutTestController::setDumpAsText):
3233         (LayoutTestController::dumpBackForwardList):
3234         (LayoutTestController::setDumpBackForwardList):
3235         (LayoutTestController::dumpChildFrameScrollPositions):
3236         (LayoutTestController::setDumpChildFrameScrollPositions):
3237         (LayoutTestController::dumpChildFramesAsText):
3238         (LayoutTestController::setDumpChildFramesAsText):
3239         (LayoutTestController::dumpDOMAsWebArchive):
3240         (LayoutTestController::setDumpDOMAsWebArchive):
3241         (LayoutTestController::dumpSelectionRect):
3242         (LayoutTestController::setDumpSelectionRect):
3243         (LayoutTestController::dumpSourceAsWebArchive):
3244         (LayoutTestController::setDumpSourceAsWebArchive):
3245         (LayoutTestController::dumpTitleChanges):
3246         (LayoutTestController::setDumpTitleChanges):
3247         (LayoutTestController::dumpEditingCallbacks):
3248         (LayoutTestController::setDumpEditingCallbacks):
3249         (LayoutTestController::dumpResourceLoadCallbacks):
3250         (LayoutTestController::setDumpResourceLoadCallbacks):
3251         (LayoutTestController::dumpFrameLoadCallbacks):
3252         (LayoutTestController::setDumpFrameLoadCallbacks):
3253         (LayoutTestController::addFileToPasteboardOnDrag):
3254         (LayoutTestController::setAddFileToPasteboardOnDrag):
3255         (LayoutTestController::callCloseOnWebViews):
3256         (LayoutTestController::setCallCloseOnWebViews):
3257         (LayoutTestController::canOpenWindows):
3258         (LayoutTestController::setCanOpenWindows):
3259         (LayoutTestController::closeRemainingWindowsWhenComplete):
3260         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3261         (LayoutTestController::testRepaint):
3262         (LayoutTestController::setTestRepaint):
3263         (LayoutTestController::testRepaintSweepHorizontally):
3264         (LayoutTestController::setTestRepaintSweepHorizontally):
3265         (LayoutTestController::waitToDump):
3266         (LayoutTestController::windowIsKey):
3267         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
3268         * DumpRenderTree/NavigationController.h: Removed.
3269         * DumpRenderTree/NavigationController.m: Removed.
3270         * DumpRenderTree/ObjCController.h: Removed.
3271         * DumpRenderTree/ObjCController.m: Removed.
3272         * DumpRenderTree/ObjCPlugin.h: Removed.
3273         * DumpRenderTree/ObjCPlugin.m: Removed.
3274         * DumpRenderTree/ObjCPluginFunction.h: Removed.
3275         * DumpRenderTree/ObjCPluginFunction.m: Removed.
3276         * DumpRenderTree/PolicyDelegate.h: Removed.
3277         * DumpRenderTree/PolicyDelegate.m: Removed.
3278         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
3279         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
3280         * DumpRenderTree/TextInputController.h: Removed.
3281         * DumpRenderTree/TextInputController.m: Removed.
3282         * DumpRenderTree/UIDelegate.h: Removed.
3283         * DumpRenderTree/UIDelegate.mm: Removed.
3284         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
3285         * DumpRenderTree/mac: Added.
3286         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
3287         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
3288         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
3289         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
3290         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
3291         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
3292         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3293         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3294         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3295         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3296         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3297         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3298         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3299         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3300         (-[EditingDelegate webViewDidBeginEditing:]):
3301         (-[EditingDelegate webViewDidChange:]):
3302         (-[EditingDelegate webViewDidEndEditing:]):
3303         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3304         (-[EditingDelegate webViewDidChangeSelection:]):
3305         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
3306         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
3307         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
3308         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
3309         (-[FrameLoadDelegate init]):
3310         (-[FrameLoadDelegate dealloc]):
3311         (-[FrameLoadDelegate processWork:]):
3312         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3313         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3314         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3315         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3316         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3317         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3318         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3319         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3320         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3321         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3322         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3323         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3324         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3325         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3326         (-[FrameLoadDelegate webView:willCloseFrame:]):
3327         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3328         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3329         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
3330         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
3331         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
3332         (LayoutTestController::notifyDone):
3333         (LayoutTestController::setWindowIsKey):
3334         (LayoutTestController::setWaitToDump):
3335         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
3336         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
3337         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
3338         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
3339         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
3340         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
3341         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
3342         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
3343         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
3344         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
3345         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
3346         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
3347         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3348         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3349         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3350         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3351         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3352         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3353         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
3354         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
3355         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
3356         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
3357         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
3358         (-[UIDelegate webViewFocus:]):
3359         (-[UIDelegate webView:createWebViewWithRequest:]):
3360         (-[UIDelegate webViewClose:]):
3361         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
3362
3363 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
3364
3365         Reviewed by Adam.
3366
3367         - Changing Win version of Drosera work with recent changes.
3368
3369         * Drosera/DebuggerDocument.cpp:
3370         * Drosera/DebuggerDocument.h:
3371         * Drosera/mac/DebuggerDocumentPlatform.mm:
3372         (NSStringCreateWithJSStringRef):
3373         (JSValueRefCreateWithNSString):
3374         * Drosera/win/DebuggerClient.cpp:
3375         (DebuggerClient::stepInto):
3376         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3377
3378 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
3379
3380         Reviewed by Tim.
3381
3382         - Moved isPaused into the JS for efficiency and simplicity.
3383
3384         * Drosera/DebuggerDocument.cpp:
3385         (DebuggerDocument::DebuggerDocument):
3386         (DebuggerDocument::pauseCallback):
3387         (DebuggerDocument::resumeCallback):
3388         (DebuggerDocument::isPaused):
3389         (DebuggerDocument::staticFunctions):
3390         * Drosera/DebuggerDocument.h:
3391         * Drosera/console.js:
3392         * Drosera/debugger.js:
3393         * Drosera/mac/DebuggerClient.mm:
3394         (-[DebuggerClient validateUserInterfaceItem:]):
3395
3396 2007-09-13  Sam Weinig  <sam@webkit.org>
3397
3398         Rubber stamped by Darin.
3399
3400         Make DumpRenderTree more cross platform ready.
3401         - Convert GCController to use the JSCore API instead of the WebScriptObject.
3402         - Use CF types instead of NS objects.
3403         - General cleanup.
3404
3405         * DumpRenderTree/DumpRenderTree.h:
3406         * DumpRenderTree/DumpRenderTree.mm:
3407         (dumpRenderTree):
3408         (dump):
3409         (runTest):
3410         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3411         * DumpRenderTree/EditingDelegate.m:
3412         * DumpRenderTree/FrameLoadDelegate.h:
3413         * DumpRenderTree/FrameLoadDelegate.mm:
3414         (-[FrameLoadDelegate init]):
3415         (-[FrameLoadDelegate dealloc]):
3416         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3417         * DumpRenderTree/GCController.cpp: Added.
3418         (GCController::GCController):
3419         (GCController::~GCController):
3420         (collectCallback):
3421         (collectOnAlternateThreadCallback):
3422         (getJSObjectCountCallback):
3423         (GCController::makeWindowObject):
3424         (GCController::getJSClass):
3425         (GCController::staticFunctions):
3426         * DumpRenderTree/GCController.h:
3427         * DumpRenderTree/GCController.mm:
3428         (GCController::collect):
3429         (GCController::collectOnAlternateThread):
3430         (GCController::getJSObjectCount):
3431         * DumpRenderTree/LayoutTestController.cpp:
3432         (LayoutTestController::makeWindowObject):
3433         (LayoutTestController::getJSClass):
3434         * DumpRenderTree/LayoutTestController.h:
3435         * DumpRenderTree/LayoutTestControllerMac.mm:
3436         (LayoutTestController::addDisallowedURL):
3437         (waitUntilDoneWatchdogFired):
3438         (LayoutTestController::waitUntilDone):
3439         * DumpRenderTree/ResourceLoadDelegate.m:
3440         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3441
3442 2007-09-12  Sam Weinig  <sam@webkit.org>
3443
3444         Reviewed by Stephanie.
3445
3446         Fix leaks in mac DumpRenderTree.
3447
3448         * DumpRenderTree/FrameLoadDelegate.mm:
3449         (-[FrameLoadDelegate init]): Initalize in the correct order.
3450         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
3451         * DumpRenderTree/LayoutTestController.cpp:
3452         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
3453         (encodeHostNameCallback): ditto.
3454         * DumpRenderTree/LayoutTestController.h:
3455         * DumpRenderTree/LayoutTestControllerMac.mm:
3456         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
3457         (LayoutTestController::copyEncodedHostName): ditto
3458         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
3459
3460 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3461
3462         Reviewed by Geof.
3463
3464         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
3465
3466         * Scripts/run-webkit-tests:
3467
3468 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3469
3470         Reviewed by Darin.
3471
3472         - Simplified code paths and extracted out functions to increase encapsulation.
3473
3474         * Drosera/DebuggerDocument.cpp:
3475         (DebuggerDocument::breakpointEditorHTMLCallback):
3476         (DebuggerDocument::isPausedCallback):
3477         (DebuggerDocument::pauseCallback):
3478         (DebuggerDocument::resumeCallback):
3479         (DebuggerDocument::stepIntoCallback):
3480         (DebuggerDocument::evaluateScriptCallback):
3481         (DebuggerDocument::currentFunctionStackCallback):
3482         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3483         (DebuggerDocument::valueForScopeVariableNamedCallback):
3484         (DebuggerDocument::logCallback):
3485         * Drosera/DebuggerDocument.h:
3486         (DebuggerDocument::getPaused):
3487         * Drosera/mac/DebuggerClient.mm:
3488         (-[DebuggerClient pause:]):
3489         (-[DebuggerClient resume:]):
3490         (-[DebuggerClient stepInto:]):
3491         (-[DebuggerClient stepOver:]):
3492         (-[DebuggerClient stepOut:]):
3493         (-[DebuggerClient showConsole:]):
3494         (-[DebuggerClient closeCurrentFile:]):
3495         (-[DebuggerClient validateUserInterfaceItem:]):
3496         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
3497         (+[NSString stringOrNilFromWebScriptResult:]):
3498         (DebuggerDocument::platformPause):
3499         (DebuggerDocument::platformResume):
3500         (DebuggerDocument::platformStepInto):
3501         (DebuggerDocument::platformEvaluateScript):
3502         (DebuggerDocument::getPlatformCurrentFunctionStack):
3503         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3504         (DebuggerDocument::platformValueForScopeVariableNamed):
3505         (DebuggerDocument::platformLog):
3506         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3507
3508 2007-09-12  Sam Weinig  <sam@webkit.org>
3509
3510         Build fix for Buildbot.
3511
3512         * DumpRenderTree/DumpRenderTree.mm:
3513         (dump):
3514
3515 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3516
3517         Reviewed by Geoff.
3518
3519         - Updated the leaks list for leopard to help identify regressions.
3520
3521         * Scripts/run-webkit-tests:
3522
3523 2007-09-12  Sam Weinig  <sam@webkit.org>
3524
3525         Rubber stamped by Darin.
3526
3527         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
3528
3529         * DumpRenderTree/DumpRenderTree.h: Re-order variables. 
3530         * DumpRenderTree/DumpRenderTree.m: Removed.
3531         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
3532         (stopJavaScriptThreads): Fix initialization.
3533         (setDefaultColorProfileToRGB): Add explicit cast from void*.
3534         (dumpRenderTree): Ditto.
3535         (runTest):
3536         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
3537
3538         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3539         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
3540         * DumpRenderTree/FrameLoadDelegate.m: Removed.
3541         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
3542         (-[FrameLoadDelegate init]):
3543         (-[FrameLoadDelegate dealloc]):
3544         (-[FrameLoadDelegate processWork:]):
3545         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3546         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3547         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
3548         
3549         * DumpRenderTree/LayoutTestController.cpp: Added.
3550         (LayoutTestController::LayoutTestController):
3551         (LayoutTestController::~LayoutTestController):
3552         (dumpAsTextCallback):
3553         (dumpBackForwardListCallback):
3554         (dumpChildFramesAsTextCallback):
3555         (dumpChildFrameScrollPositionsCallback):
3556         (dumpDOMAsWebArchiveCallback):
3557         (dumpEditingCallbacksCallback):
3558         (dumpFrameLoadCallbacksCallback):