WebKitTools/ChangeLog

   1 2010-04-28  Sam Weinig  <sam@webkit.org>
   2
   3         Reviewed by Mark Rowe.
   4
   5         Add MiniBrowser to the lists of modules to build and only build it on
   6         SnowLeopard and later.
   7
   8         * Makefile:
   9         * MiniBrowser/Makefile:
  10
  11 2010-04-28  Sam Weinig  <sam@webkit.org>
  12
  13         Reviewed by Mark Rowe.
  14
  15         Make running MiniBrowser.app without explicitly setting DYLD_FRAMEWORK_PATH.
  16
  17         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  18         * MiniBrowser/mac/make-launchable.sh: Added.
  19
  20 2010-04-28  Eric Seidel  <eric@webkit.org>
  21
  22         Reviewed by David Levin.
  23
  24         Audit all uses of subprocess in webkitpy
  25         https://bugs.webkit.org/show_bug.cgi?id=38284
  26
  27         After further discussions with Jeffrey Yasskin
  28         about http://bugs.python.org/issue2320
  29         and related issues of using subprocess from
  30         multiple threads, I have learned that subprocess
  31         is known to be non-threadsafe through recent
  32         Python 2.7 builds.
  33
  34         I'm attempting to lessen our exposure to these
  35         subprocess bugs by auditing each use of subprocess
  36         in webkitpy.  I did not find any unsafe calls
  37         in my audit, but I did remove numerous unneeded
  38         import subprocess lines.
  39
  40         * Scripts/webkitpy/common/checkout/api.py:
  41         * Scripts/webkitpy/common/net/bugzilla.py:
  42         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
  43         * Scripts/webkitpy/common/system/user.py:
  44         * Scripts/webkitpy/layout_tests/port/base.py:
  45         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  46         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  47         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Added.
  48         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  49         * Scripts/webkitpy/layout_tests/port/gtk.py:
  50         * Scripts/webkitpy/layout_tests/port/mac.py:
  51         * Scripts/webkitpy/layout_tests/port/qt.py:
  52         * Scripts/webkitpy/layout_tests/port/webkit.py:
  53         * Scripts/webkitpy/layout_tests/port/win.py:
  54
  55 2010-04-28  Darin Adler  <darin@apple.com>
  56
  57         Ignore a directory the Python tools creates.
  58
  59         * Scripts/webkitpy/style: Modified property svn:ignore.
  60
  61 2010-04-28  Darin Adler  <darin@apple.com>
  62
  63         * Scripts/extract-localizable-strings: Fix minor mistake in
  64         argument checking.
  65
  66 2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>
  67
  68         Reviewed by Kenneth Rohde Christiansen.
  69
  70         [Qt] QWebPage viewMode property
  71         https://bugs.webkit.org/show_bug.cgi?id=38119
  72
  73         Replacing method qt_wrt_setViewMode by wrt_viewMode property.
  74
  75         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  76         (LayoutTestController::setViewModeMediaFeature):
  77
  78 2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>
  79
  80         Reviewed by Shinichiro Hamaji.
  81
  82         Adjusted check-webkit-style so that files with file type NONE
  83         are automatically skipped without warning.
  84
  85         https://bugs.webkit.org/show_bug.cgi?id=38197
  86
  87         This change simplifies configuring which files to skip.  It also
  88         addresses an issue whereby check-webkit-style was unintentionally
  89         checking .vcproj files for carriage returns.
  90
  91         * Scripts/webkitpy/style/checker.py:
  92           - Moved the C++, Python, and text file extensions to new
  93             module-level configuration variables.
  94           - Removed .pyc from the _SKIPPED_FILES_WITHOUT_WARNING configuration
  95             variable.
  96           - Changed the numeric values of the FileType enum so that
  97             FileType.NONE evaluates to False.
  98           - For ProcessorDispatcher.should_skip_without_warning():
  99             - Changed the method to return True for FileType.NONE files.
 100             - Made ChangeLog files an exception to getting skipped.
 101           - Changed the StyleProcessor.process() method to raise an
 102             exception if given a file path that should not be processed.
 103
 104         * Scripts/webkitpy/style/checker_unittest.py:
 105           - Updated the unit tests and added more test cases as necessary.
 106
 107 2010-04-28  Eric Seidel  <eric@webkit.org>
 108
 109         Reviewed by Jeremy Orlow.
 110
 111         webkitpy: ScriptError('Failed to run "[u\'taskkill.exe\', u\'/f\', u\'/im\', u\'httpd.exe\']" exit_code: 128',)
 112         https://bugs.webkit.org/show_bug.cgi?id=38248
 113
 114         The previous code did not check the return code of taskkill.
 115         When I moved that callsite from using subprocess.call to
 116         Executive.run_command having a non-zero return code became an error.
 117
 118         In this change I've centralized our killall handling in executive,
 119         and added tests for it to make sure it works.
 120
 121         Currently kill_process and kill_all swallow exceptions in the cases
 122         where the process(es) to be killed do(es) not exist.
 123
 124         * Scripts/webkitpy/common/system/executive.py:
 125         * Scripts/webkitpy/common/system/executive_unittest.py:
 126         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
 127         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 128         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 129         * Scripts/webkitpy/layout_tests/port/gtk.py:
 130         * Scripts/webkitpy/layout_tests/port/mac.py:
 131         * Scripts/webkitpy/layout_tests/port/qt.py:
 132         * Scripts/webkitpy/layout_tests/port/win.py:
 133
 134 2010-04-28  Eric Seidel  <eric@webkit.org>
 135
 136         Reviewed by Shinichiro Hamaji.
 137
 138         wdiff_text throws ScriptError because wdiff returns non-zero when files differ
 139         https://bugs.webkit.org/show_bug.cgi?id=38246
 140
 141         wdiff returns 0 when files are the same, 1 when they differ.
 142         run_command by default raises ScriptError if the return code is non-zero.
 143         Fixed this by adding a custom error handler which only raises if the
 144         return code is not 1.
 145
 146         I broke up the huge wdiff_text() method into little pieces
 147         for easier unit testing.  There is only one functional change here
 148         and that is the addition of the custom error handler.
 149
 150         * Scripts/webkitpy/layout_tests/port/base.py:
 151         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 152
 153 2010-04-28  Fumitoshi Ukai  <ukai@chromium.org>
 154
 155         Unreviewed build fix.
 156
 157         * DumpRenderTree/chromium/TestShell.cpp:
 158         (TestShell::dumpImage): format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'.
 159         * DumpRenderTree/chromium/WebViewHost.cpp:
 160         (WebViewHost::willSendRequest): too few arguments for format.
 161
 162 2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>
 163
 164         Reviewed by Darin Adler and Eric Seidel.
 165
 166         Add layoutTestController.setPrinting()
 167         https://bugs.webkit.org/show_bug.cgi?id=37203
 168
 169         * DumpRenderTree/LayoutTestController.cpp:
 170         (LayoutTestController::LayoutTestController):
 171         (setPrintingCallback):
 172         (LayoutTestController::staticFunctions):
 173         * DumpRenderTree/LayoutTestController.h:
 174         (LayoutTestController::isPrinting):
 175         (LayoutTestController::setIsPrinting):
 176         * DumpRenderTree/mac/DumpRenderTree.mm:
 177         (dump):
 178
 179 2010-04-27  Michael Nordman  <michaeln@google.com>
 180
 181         Reviewed by Dmitry Titov.
 182
 183         [Chromium] Add two things to the webkit API to support appcaches in workers.
 184         1) WebURLRequest TargetTypes for worker and shared worker main resources.
 185         2) Factory method on class WebCommonWorkerClient to
 186            createApplicationCacheHost() for the associated worker.
 187
 188         https://bugs.webkit.org/show_bug.cgi?id=38147
 189
 190         * DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method
 191         (TestWebWorker::createApplicationCacheHost):
 192
 193 2010-04-27  Adam Barth  <abarth@webkit.org>
 194
 195         Reviewed by Eric Seidel.
 196
 197         run-bindings-tests doesn't work in an SVN checkout
 198         https://bugs.webkit.org/show_bug.cgi?id=38225
 199
 200         Previously detect_scm_system needed an absolute path for SVN.  Now we
 201         accept a relative path.
 202
 203         * Scripts/webkitpy/common/checkout/scm.py:
 204         * Scripts/webkitpy/common/checkout/scm_unittest.py:
 205
 206 2010-04-27  Sam Weinig  <sam@webkit.org>
 207
 208         Reviewed by Stephanie Lewis.
 209
 210         Always build WebKit2 when building on SnowLeopard and later.
 211
 212         * Scripts/build-webkit:
 213
 214 2010-04-27  Sam Weinig  <sam@webkit.org>
 215
 216         Reviewed by Maciej Stachowiak.
 217
 218         Fix for https://bugs.webkit.org/show_bug.cgi?id=38238
 219         Allow both WebKit and WebKit2 to link to the same WebCore.framework
 220
 221         * Scripts/build-webkit: Remove the UMBRELLA_LDFLAGS override when building
 222         WebCore for WebKit2, it is no longer necessary.
 223
 224 2010-04-27  James Robinson  <jamesr@chromium.org>
 225
 226         Reviewed by David Levin.
 227
 228         Fix a typo in chromium.py that causes NRWT to fail in --verbose
 229         mode in a Chromium checkout.
 230         https://bugs.webkit.org/show_bug.cgi?id=38234
 231
 232         * Scripts/webkitpy/layout_tests/port/chromium.py:
 233
 234 2010-04-27  Darin Fisher  <darin@chromium.org>
 235
 236         Reviewed by Dimitri Glazkov.
 237
 238         [Chromium] Remove deprecated form of didChangeLocationWithinPage
 239         https://bugs.webkit.org/show_bug.cgi?id=38178
 240
 241         Switch over to implementing didNavigateWithinPage.
 242
 243         * DumpRenderTree/chromium/WebViewHost.cpp:
 244         (TestWebViewDelegate::didNavigateWithinPage):
 245         (WebViewHost::didChangeLocationWithinPage):
 246         * DumpRenderTree/chromium/WebViewHost.h:
 247
 248 2010-04-27  Evan Martin  <evan@chromium.org>
 249
 250         Unreviewed.
 251
 252         Adding myself to commmitters list.
 253
 254         * Scripts/webkitpy/common/config/committers.py:
 255
 256 2010-04-27  Adam Barth  <abarth@webkit.org>
 257
 258         Reviewed by Darin Adler.
 259
 260         run-bindings-tests should use --reset-results instead of --overwrite
 261         https://bugs.webkit.org/show_bug.cgi?id=38200
 262
 263         As requested by Ojan.
 264
 265         * Scripts/run-bindings-tests:
 266
 267 2010-04-27  Adam Barth  <abarth@webkit.org>
 268
 269         Reviewed by Eric Seidel.
 270
 271         REGRESSION(r58261): webkit-patch edit-changelogs is broken
 272         https://bugs.webkit.org/show_bug.cgi?id=38204
 273
 274         In 58261, we added code to abstract step that interrogates the squash
 275         and git_commit options, but it doesn't declare that it uses those
 276         options.  That means any command that doesn't happen to declare those
 277         options might be broken if it uses the cached_lookup mechanism.
 278
 279         * Scripts/webkitpy/tool/steps/abstractstep.py:
 280         * Scripts/webkitpy/tool/steps/applypatch.py:
 281         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
 282         * Scripts/webkitpy/tool/steps/build.py:
 283         * Scripts/webkitpy/tool/steps/checkstyle.py:
 284         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
 285         * Scripts/webkitpy/tool/steps/closebug.py:
 286         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
 287         * Scripts/webkitpy/tool/steps/commit.py:
 288         * Scripts/webkitpy/tool/steps/confirmdiff.py:
 289         * Scripts/webkitpy/tool/steps/createbug.py:
 290         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
 291         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
 292         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
 293         * Scripts/webkitpy/tool/steps/postcodereview.py:
 294         * Scripts/webkitpy/tool/steps/postdiff.py:
 295         * Scripts/webkitpy/tool/steps/preparechangelog.py:
 296         * Scripts/webkitpy/tool/steps/runtests.py:
 297         * Scripts/webkitpy/tool/steps/update.py:
 298         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
 299         * Scripts/webkitpy/tool/steps/validatereviewer.py:
 300
 301 2010-04-27  Eric Seidel  <eric@webkit.org>
 302
 303         Reviewed by David Levin.
 304
 305         prepare-ChangeLog --bug fails on some CYGWIN installs due to missing certs
 306         https://bugs.webkit.org/show_bug.cgi?id=38212
 307
 308         * Scripts/prepare-ChangeLog:
 309          - Pass --insecure to curl to work around CYGWIN missing certs.
 310
 311 2010-04-27  Sam Weinig  <sam@webkit.org>
 312
 313         Rubber-stamped by Beth Dakin.
 314
 315         It is no longer necessary to set ENABLE_EXPERIMENTAL_SINGLE_VIEW_MODE
 316         or WTF_USE_WEB_THREAD. Remove them.
 317
 318         * Scripts/build-webkit:
 319
 320 2010-04-27  Chris Jerdonek  <cjerdonek@webkit.org>
 321
 322         Reviewed by David Levin.
 323
 324         Changed Chris Jerdonek from committer to reviewer.
 325
 326         * Scripts/webkitpy/common/config/committers.py:
 327
 328 2010-04-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
 329
 330         Reviewed by Kenneth Rohde Christiansen.
 331
 332         [Qt] QGraphicsWebView: Arrow keys scroll the graphics-view instead of the web-page
 333         https://bugs.webkit.org/show_bug.cgi?id=35834
 334
 335         The scene should always have the size of the web view otherwhise it is
 336         possible to scroll the graphics view.
 337
 338         * QtLauncher/webview.cpp:
 339         (WebViewGraphicsBased::resizeEvent):
 340
 341 2010-04-27  Diego Gonzalez  <diegohcg@webkit.org>
 342
 343         Unreviewed.
 344
 345         Adding myself to committers.py
 346
 347         * Scripts/webkitpy/common/config/committers.py:
 348
 349 2010-04-27  Eric Seidel  <eric@webkit.org>
 350
 351         Reviewed by Adam Barth.
 352
 353         [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
 354         https://bugs.webkit.org/show_bug.cgi?id=37987
 355
 356         After further research, I believe the hang is caused by:
 357         http://bugs.python.org/issue2320
 358         Basically Popen() is not reentrant.
 359         The workaround is to pass close_fds=True to Popen() on Mac/Linux.
 360
 361         I fixed our main Popen wrapper "Executive.run_command" to use close_fds=True
 362         when appropriate.
 363
 364         I audited all places we call Popen() and either moved them to run_command
 365         or left a FIXME that they are not thread safe.  A few places I added the
 366         close_fds workaround there and left an explanitory note.
 367
 368         * Scripts/webkitpy/common/checkout/scm_unittest.py:
 369          - Added note that this Popen use is not threadsafe.
 370         * Scripts/webkitpy/common/system/executive.py:
 371          - Fixed our Executive.run_* to workaround python bug 2320.
 372         * Scripts/webkitpy/common/system/user.py:
 373          _ Added note that this Popen use is not threadsafe.
 374         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: ditto.
 375         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: ditto.
 376         * Scripts/webkitpy/layout_tests/port/base.py:
 377          - Change wdiff back to using run_command now that we believe it
 378            to be threadsafe.
 379         * Scripts/webkitpy/layout_tests/port/chromium.py:
 380          - Fix to use Executive in places.
 381          - Pass self._executive down to the Driver for easier unit testing.
 382         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 383          - Re-factor to use a _kill_all method.
 384          - Made the _kill_all method use run_command to be threadsafe.
 385         * Scripts/webkitpy/layout_tests/port/http_server.py:
 386          - Add FIXME about using Executive.
 387         * Scripts/webkitpy/layout_tests/port/server_process.py:
 388          - Use Executive to be threadsafe.
 389         * Scripts/webkitpy/layout_tests/port/webkit.py:
 390          - Pass self._executive down to the Driver.
 391         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
 392          - Add note about Popen not being threadsafe.
 393         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 394          - Move one caller to run_command add notes about moving others.
 395
 396 2010-04-27  Adam Barth  <abarth@webkit.org>
 397
 398         Reviewed by Maciej Stachowiak.
 399
 400         REGRESSION(r58261): webkit-patch upload does not work in an SVN checkout.
 401         https://bugs.webkit.org/show_bug.cgi?id=38186
 402
 403         Unfortunately, we don't have a good way of testing this change because
 404         our test coverage of the scm.py API is poor...
 405
 406         * Scripts/webkitpy/common/checkout/scm.py:
 407         * Scripts/webkitpy/tool/steps/preparechangelog.py:
 408
 409 2010-04-26  Eric Seidel  <eric@webkit.org>
 410
 411         Reviewed by Adam Barth.
 412
 413         Remove unused code from text_diff.py
 414         https://bugs.webkit.org/show_bug.cgi?id=38170
 415
 416         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
 417          - Remove is_render_tree_dump which appears unused.
 418
 419 2010-04-26  Adam Barth  <abarth@webkit.org>
 420
 421         Reviewed by Eric Seidel.
 422
 423         webkit-patch pretty-diff is broken
 424         https://bugs.webkit.org/show_bug.cgi?id=38172
 425
 426         We need to register for these options because they're used when we look
 427         up the diff.
 428
 429         * Scripts/webkitpy/tool/steps/confirmdiff.py:
 430
 431 2010-04-26  Adam Barth  <abarth@webkit.org>
 432
 433         Reviewed by Eric Seidel.
 434
 435         Add ObjC and GObject to run-bindings-test
 436         https://bugs.webkit.org/show_bug.cgi?id=38168
 437
 438         * Scripts/run-bindings-tests:
 439
 440 2010-04-26  Adam Barth  <abarth@webkit.org>
 441
 442         Reviewed by Eric Seidel.
 443
 444         Add testing infrastructure for JSC bindings generator
 445         https://bugs.webkit.org/show_bug.cgi?id=38167
 446
 447         Add support for testing more than one bindings.  Also, converted the
 448         script to PEP8 style.
 449
 450         * Scripts/run-bindings-tests:
 451
 452 2010-04-26  Eric Seidel  <eric@webkit.org>
 453
 454         Reviewed by Adam Barth.
 455
 456         Refactor results.html generation out into a new method and test it
 457         https://bugs.webkit.org/show_bug.cgi?id=38164
 458
 459         Hopefully this results in no change in functionality.
 460
 461         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 462         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 463
 464 2010-04-26  Adam Barth  <abarth@webkit.org>
 465
 466         Unreviewed, rolling out r58265.
 467         http://trac.webkit.org/changeset/58265
 468         https://bugs.webkit.org/show_bug.cgi?id=38021
 469
 470         This change prevents me from uploading patches.  It also breaks sheriff-bot.
 471
 472         * Scripts/webkitpy/tool/steps/options.py:
 473
 474 2010-04-26  Eric Seidel  <eric@webkit.org>
 475
 476         Reviewed by Adam Barth.
 477
 478         [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
 479         https://bugs.webkit.org/show_bug.cgi?id=37987
 480
 481         Rolled out:
 482         http://trac.webkit.org/changeset/58062
 483         http://trac.webkit.org/changeset/58060
 484         http://trac.webkit.org/changeset/58059
 485         http://trac.webkit.org/changeset/58055
 486         http://trac.webkit.org/changeset/58054
 487         and parts of:
 488         http://trac.webkit.org/changeset/58050
 489
 490         I also wrote some new comments and a tiny amount of new
 491         code to help make ChromiumDriver.run_test easier to read.
 492
 493         In order to unit-test my new code, I had to change ChromiumDriver
 494         to not automatically start itself when created.  That ended up
 495         being a lot of plumbing, but is hopefully easier to understand now.
 496
 497         There are no tests for the (restored) wdiff code.  wdiff does not
 498         exist on all systems, so for now we will assume it worked since
 499         it is just old code being reverted.
 500
 501          * Scripts/webkitpy/layout_tests/driver_test.py:
 502           - Use create_driver instead of start_driver, and be sure to call .stop()
 503          * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
 504           - Use create_driver instead of start_driver
 505          * Scripts/webkitpy/layout_tests/port/base.py:
 506           - Added a comment to explain that diffs are binary files.
 507           - Various patch reverts relating to wdiff
 508           - Add Driver._command_wrapper to share code between WebKitDriver and ChromiumDriver.
 509           - Made _command_wrapper use shlex.split to get rid of the FIXME.
 510          * Scripts/webkitpy/layout_tests/port/base_unittest.py: Added.
 511           - test the new _command_wrapper
 512          * Scripts/webkitpy/layout_tests/port/chromium.py:
 513          - Use _command_wrapper to get rid of a bunch of ugly code.
 514          - Make __init__ stop auto-starting.
 515          - Rename create_driver to start_driver.
 516          - Added _write_command_and_read_line to make it possible to
 517            put a FIXME next to read_line() w/o having to put it in two places.
 518          - Moved test_shell command building into _test_shell_command and tested it.
 519          - Fix comments to say test_shell since ChromiumDriver is test_shell only.
 520          * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Added.
 521           - Test the new test_shell_command method.
 522          * Scripts/webkitpy/layout_tests/port/dryrun.py:
 523           - Rename create_driver to start_driver.
 524          * Scripts/webkitpy/layout_tests/port/test.py:
 525           - Rename create_driver to start_driver.
 526          * Scripts/webkitpy/layout_tests/port/webkit.py:
 527           - Rename create_driver to start_driver.
 528           - Treat output as binary arrays.
 529          * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
 530           - Treat diff files as binary.
 531          * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
 532           - Treat diff files as binary.
 533
 534 2010-04-26  Adam Barth  <abarth@webkit.org>
 535
 536         Reviewed by Eric Seidel.
 537
 538         Move bindings test directory into the scripts directory
 539         https://bugs.webkit.org/show_bug.cgi?id=38161
 540
 541         Change script to point to the new location of these data files.
 542
 543         * Scripts/run-bindings-tests:
 544
 545 2010-04-26  Adam Barth  <abarth@webkit.org>
 546
 547         Unreviewed.  Mark run-bindings-tests executable so we can execute it.
 548
 549         * Scripts/run-bindings-tests:
 550
 551 2010-04-26  Tony Chang  <tony@chromium.org>
 552
 553         Reviewed by David Levin.
 554
 555         [chromium] build-webkit --chromium should build release by default
 556         https://bugs.webkit.org/show_bug.cgi?id=38028
 557
 558         * Scripts/build-dumprendertree: Also should build release by default
 559         * Scripts/build-webkit: Make sure to pass command line args through
 560         * Scripts/webkitdirs.pm: Build the right configuration
 561
 562 2010-04-26  Ojan Vafai  <ojan@chromium.org>
 563
 564         Reviewed by Eric Seidel.
 565
 566         complete rietveld bugzilla integration
 567         https://bugs.webkit.org/show_bug.cgi?id=38021
 568
 569         Makes --fancy-review the default. All this means is that the patch will
 570         be uploaded to rietveld in addition to bugs.webkit.org.
 571
 572         * Scripts/webkitpy/tool/steps/options.py:
 573
 574 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
 575
 576         Reviewed by Shinichiro Hamaji.
 577
 578         For check-webkit-style, renamed the style/processors/ directory
 579         to style/checkers/.
 580
 581         https://bugs.webkit.org/show_bug.cgi?id=38122
 582
 583         * Scripts/webkitpy/style/checker.py:
 584           - Updated import statements.
 585
 586         * Scripts/webkitpy/style/checker_unittest.py:
 587           - Updated import statements.
 588
 589         * Scripts/webkitpy/style/checkers: Copied from WebKitTools/Scripts/webkitpy/style/processors.
 590         * Scripts/webkitpy/style/processors: Removed.
 591         * Scripts/webkitpy/style/processors/__init__.py: Removed.
 592         * Scripts/webkitpy/style/processors/common.py: Removed.
 593         * Scripts/webkitpy/style/processors/common_unittest.py: Removed.
 594         * Scripts/webkitpy/style/processors/cpp.py: Removed.
 595         * Scripts/webkitpy/style/processors/cpp_unittest.py: Removed.
 596         * Scripts/webkitpy/style/processors/python.py: Removed.
 597         * Scripts/webkitpy/style/processors/python_unittest.py: Removed.
 598         * Scripts/webkitpy/style/processors/python_unittest_input.py: Removed.
 599         * Scripts/webkitpy/style/processors/text.py: Removed.
 600         * Scripts/webkitpy/style/processors/text_unittest.py: Removed.
 601
 602 2010-04-06  Ojan Vafai  <ojan@chromium.org>
 603
 604         Reviewed by Adam Barth.
 605
 606         Include git commits in the diff for webkit-patch upload/land.
 607         https://bugs.webkit.org/show_bug.cgi?id=36394
 608
 609         Adds --squash, --no-squash and --git-commit.
 610
 611         --git-commit will use a specific local commit for land/upload.
 612         If a commit-range is specified, then that range is treated as
 613         a single squashed commit.
 614
 615         --squash will squash all local changes including working copy changes
 616         into a single patch.
 617
 618         --no-squash is the legacy behavior (upload only considers the working copy,
 619         land commits the working copy and then each local commit separately to SVN)
 620
 621         If neither is specified, then an informative error is raised if there is
 622         more than one local commit or when there are local commit(s) and working
 623         copy changes.
 624
 625         If the webkit-patch.squash git config parameter is set, then
 626         that will be respected instead of raising an error.
 627
 628         * Scripts/check-webkit-style:
 629         * Scripts/webkitpy/common/checkout/api.py:
 630         * Scripts/webkitpy/common/checkout/api_unittest.py:
 631         * Scripts/webkitpy/common/checkout/scm.py:
 632         * Scripts/webkitpy/common/checkout/scm_unittest.py:
 633         * Scripts/webkitpy/style/optparser.py:
 634         --git-since is removed and --git-commit no longer implies commit_id..
 635         Instead, it treats that individual commit, but also supports commit ranges
 636         (e.g. commit_id..) as arguments.
 637         * Scripts/webkitpy/style/optparser_unittest.py:
 638         * Scripts/webkitpy/style_references.py:
 639         * Scripts/webkitpy/tool/commands/download.py:
 640         * Scripts/webkitpy/tool/commands/upload.py:
 641         * Scripts/webkitpy/tool/main.py:
 642         * Scripts/webkitpy/tool/mocktool.py:
 643         * Scripts/webkitpy/tool/steps/abstractstep.py:
 644         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
 645         * Scripts/webkitpy/tool/steps/checkstyle.py:
 646         * Scripts/webkitpy/tool/steps/commit.py:
 647         * Scripts/webkitpy/tool/steps/options.py:
 648         * Scripts/webkitpy/tool/steps/postdiff.py:
 649         * Scripts/webkitpy/tool/steps/preparechangelog.py:
 650         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
 651         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
 652         * Scripts/webkitpy/tool/steps/validatereviewer.py:
 653
 654 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
 655
 656         Reviewed by Shinichiro Hamaji.
 657
 658         Deleted the StyleChecker-related classes that are no longer
 659         being used.
 660
 661         https://bugs.webkit.org/show_bug.cgi?id=38118
 662
 663         * Scripts/webkitpy/style/checker.py:
 664           - Deleted the DeprecatedStyleChecker class.
 665
 666         * Scripts/webkitpy/style/checker_unittest.py:
 667           - Deleted the StyleCheckerTest, StyleCheckerCheckFileBase,
 668             StyleCheckerCheckFileTest, and StyleCheckerCheckPathsTest classes.
 669
 670 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
 671
 672         Reviewed by Shinichiro Hamaji.
 673
 674         Changed the StyleChecker class to use the new TextFileReader class.
 675
 676         https://bugs.webkit.org/show_bug.cgi?id=37066
 677
 678         This revision separates the code responsible for reading and iterating
 679         over text files from the rest of check-webkit-style.
 680
 681         * Scripts/check-webkit-style:
 682           - Changed the script to use the new StyleProcessor and
 683             TextFileReader classes instead of the StyleChecker class.
 684
 685         * Scripts/webkitpy/style/checker.py:
 686           - Added a FIXME to rename many of uses of the word "processor" to
 687             "checker".  We did this to clarify the difference between
 688             ProcessorBase instances passed to the TextFileReader and
 689             classes that process and check lines for style.
 690           - Added a FIXME to remove FileType.NONE as a possible return value
 691             of ProcessorDispatcher._file_type().  This will better consolidate
 692             the logic of which files should be skipped.
 693           - Added a FIXME to delete the StyleChecker class.
 694           - Added the StyleProcessor class which implements ProcessorBase.
 695             This class is responsible for processing lines to check style
 696             (but not for reading files).  For each file, this class creates
 697             creates both a carriage-return checker and a format-specific
 698             style checker (e.g. one of C++, Python, etc).
 699           - Updated the PatchChecker class to use a TextFileReader instance
 700             instead of a StyleChecker.
 701
 702         * Scripts/webkitpy/style/checker_unittest.py:
 703           - Added the StyleProcessor_EndToEndTest class to do "end-to-end"
 704             tests of the StyleProcessor class.
 705           - Added the StyleProcessor_CodeCoverageTest to test the
 706             StyleProcessor class with more complete code coverage.
 707             Unlike the StyleProcessor_EndToEndTest class, this class makes
 708             heavy use of mock parameters.
 709           - Added FIXME's to delete the unit test classes that are no
 710             longer needed.
 711           - Updated the PatchCheckerTest class to use a MockTextFileReader
 712             instead of a MockStyleChecker.
 713
 714         * Scripts/webkitpy/style/filereader.py:
 715           - Updated the TextFileReader class to use the preferred logic
 716             of checking file existence at the beginning of the process_file()
 717             method instead of in the except block, per
 718             https://bugs.webkit.org/show_bug.cgi?id=37122
 719
 720         * Scripts/webkitpy/style/filereader_unittest.py:
 721           - In the TextFileReaderTest class:
 722             - Moved the test_process_file__should_not_process() method.
 723             - Added a test_process_file__file_stdin() method to test
 724               the file path "-".
 725
 726 2010-04-20  Robert Hogan  <robert@webkit.org>
 727
 728         Reviewed by Simon Hausmann.
 729
 730         [Qt] Add more support for textInputController
 731
 732         Add support for selectedRange(), setMarkedText(), insertText(),
 733         and firstRectForCharacterRange().
 734
 735         Unskip tests:
 736
 737         fast/forms/input-maxlength-ime-preedit.html
 738         fast/forms/input-maxlength-ime-completed.html
 739         fast/text/international/thai-cursor-position.html
 740         fast/events/ime-composition-events-001.html
 741         editing/selection/5825350-1.html
 742         editing/selection/5825350-2.html
 743         editing/selection/mixed-editability-10.html
 744
 745         https://bugs.webkit.org/show_bug.cgi?id=35702
 746
 747         * DumpRenderTree/qt/TextInputControllerQt.cpp:
 748         (TextInputController::setMarkedText):
 749         (TextInputController::insertText):
 750         (TextInputController::selectedRange):
 751         (TextInputController::firstRectForCharacterRange):
 752         * DumpRenderTree/qt/TextInputControllerQt.h:
 753
 754 2010-04-23  Eric Seidel  <eric@webkit.org>
 755
 756         Reviewed by Adam Barth.
 757
 758         check-webkit-style complains about non-utf8 data in layout test result
 759         https://bugs.webkit.org/show_bug.cgi?id=38027
 760
 761         The problem was we were assuming patch files/diff output as utf-8.
 762         Turns out they're not.  We have to treat them as binary data because
 763         a single patch may have multiple text files in it with conflicting encodings!
 764
 765         * Scripts/webkitpy/common/checkout/api.py:
 766          - contents_at_revision returns a byte array, so decode it to unicode
 767            before passing it to parse_latest_entry_from_file
 768         * Scripts/webkitpy/common/checkout/api_unittest.py:
 769          - Update our mock mock_contents_at_revision to match the encoding
 770            semantics of the real one.
 771         * Scripts/webkitpy/common/checkout/scm.py:
 772          - Be careful not to decode output which may contain file contents
 773            (like diff, cat or show) as the encoding for that content is unknown.
 774         * Scripts/webkitpy/common/checkout/scm_unittest.py:
 775          - Update our tests to use both latin1 and utf-8 encoded data.
 776         * Scripts/webkitpy/common/net/bugzilla.py:
 777          - _fill_attachment_form should not assume unicode data.  Callers
 778            may wish to attach other types of files to bugs.
 779         * Scripts/webkitpy/common/prettypatch.py:
 780          - Diffs are byte arrays, deal with them as such.
 781         * Scripts/webkitpy/common/prettypatch_unittest.py:
 782          - Test to make sure we handle diffs with multiple conflicting encodings.
 783         * Scripts/webkitpy/common/system/executive_unittest.py:
 784          - Make sure that our unicode support does not break our
 785            byte array input support for run_command.
 786
 787 2010-04-23  Sam Weinig  <sam@webkit.org>
 788
 789         Reviewed by David Levin.
 790
 791         Fix for https://bugs.webkit.org/show_bug.cgi?id=38060
 792         Split up Threading.h
 793
 794         Add necessary forwarding headers.
 795
 796         * DumpRenderTree/ForwardingHeaders/wtf/Atomics.h: Added.
 797         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
 798         * DumpRenderTree/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
 799
 800 2010-04-23  Xiaomei Ji  <xji@chromium.org>
 801
 802         No need to review.
 803
 804         Add xji as committer.
 805
 806         * Scripts/webkitpy/common/config/committers.py:
 807
 808 2010-04-23  Kevin Ollivier  <kevino@theolliviers.com>
 809
 810         [wx] Build fix, add platform stub for new LayoutTestController method.
 811
 812         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 813         (LayoutTestController::markerTextForListItem):
 814
 815 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
 816
 817         Reviewed by Adam Barth.
 818
 819         new-run-webkit-tests: add a "--retry-failures" flag and a
 820         "--no-retry-failures" flag (the former is the default). Also, rename
 821         "--print-unexpected-results" and "--retry-unexpected-results" to
 822         "--print-last-failures" and "--retry-last-failures" because the
 823         retry flag was confusing. The new flag names aren't great, but
 824         hopefully they're less confusing.
 825
 826         https://bugs.webkit.org/show_bug.cgi?id=37838
 827
 828         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 829
 830 2010-04-22  Sam Weinig  <sam@webkit.org>
 831
 832         Reviewed by Anders Carlsson.
 833
 834         Fix for https://bugs.webkit.org/show_bug.cgi?id=38022
 835         Move isMainThread predicate function to MainThread.h
 836
 837         Added forwarding header for MainThread.h
 838
 839         * DumpRenderTree/ForwardingHeaders/wtf/MainThread.h: Added.
 840
 841 2010-04-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 842
 843         Reviewed by Kenneth Rohde Christiansen.
 844
 845         [Qt] Disable Netscape plugin support for minimal configuration
 846         https://bugs.webkit.org/show_bug.cgi?id=38026
 847
 848         Pass the minimal configuration option to Qt build system
 849         as part of the CONFIG variable.
 850
 851         * Scripts/build-webkit:
 852
 853 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
 854
 855         Unreviewed fix.
 856
 857         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
 858
 859 2010-04-22  James Robinson  <jamesr@chromium.org>
 860
 861         Reviewed by Adam Barth.
 862
 863         Revert 58077 and follow-ups.  It's broken.
 864         https://bugs.webkit.org/show_bug.cgi?id=37664
 865
 866         * Scripts/new-run-webkit-httpd:
 867         * Scripts/new-run-webkit-websocketserver:
 868         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 869         * Scripts/webkitpy/layout_tests/port/http_server.py:
 870         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
 871
 872 2010-04-22  Yaar Schnitman  <yaar@chromium.org>
 873
 874         Reviewed by Adam Barth.
 875
 876         Integrate v8 testing utility with webkit tests
 877         https://bugs.webkit.org/show_bug.cgi?id=37731
 878
 879         * Scripts/run-bindings-tests: Added.
 880
 881 2010-04-22  Eric Seidel  <eric@webkit.org>
 882
 883         Reviewed by Dimitri Glazkov.
 884
 885         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
 886         https://bugs.webkit.org/show_bug.cgi?id=37794
 887
 888         * Scripts/webkitpy/layout_tests/port/webkit.py:
 889          - Remove the assert() since our ServerProcess code does not always
 890            seem to be reading the full stderr output (or we're not waiting for it to).
 891
 892 2010-04-22  Eric Seidel  <eric@webkit.org>
 893
 894         Reviewed by Adam Barth.
 895
 896         Add code to help debug new-run-webkit-test hangs on the Chromium bots
 897         https://bugs.webkit.org/show_bug.cgi?id=38011
 898
 899         I can see no reasonable way to test this change.
 900         Stubbing out sys._current_frames() and traceback.extract_stack
 901         seems folly.  Dumping real data would have line number
 902         (and possibly other call stack) variance between runs.
 903
 904         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 905          - Add _dump_thread_states and _dump_thread_states_if_necessary
 906            to have our main thread dump the states of all threads every
 907            60 seconds when running in verbose mode.
 908          - Better document what is going on in our main loop.
 909
 910 2010-04-22  Sam Weinig  <sam@webkit.org>
 911
 912         Reviewed by Anders Carlsson.
 913
 914         Fix for https://bugs.webkit.org/show_bug.cgi?id=38002
 915         Add rudimentary statistics gathering for WebKit2
 916
 917         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
 918         * MiniBrowser/mac/AppDelegate.h:
 919         * MiniBrowser/mac/AppDelegate.m:
 920         (-[BrowserAppDelegate init]):
 921         (-[BrowserAppDelegate newWindow:]):
 922         (-[BrowserAppDelegate getCurrentPageNamespace]):
 923         (-[BrowserAppDelegate _setProcessModel:]):
 924         (-[BrowserAppDelegate showStatisticsWindow:]):
 925         (-[BrowserAppDelegate applicationWillTerminate:]):
 926         * MiniBrowser/mac/BrowserStatisticsWindow.xib: Added.
 927         * MiniBrowser/mac/BrowserStatisticsWindowController.h: Added.
 928         * MiniBrowser/mac/BrowserStatisticsWindowController.m: Added.
 929         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
 930         (-[BrowserStatisticsWindowController dealloc]):
 931         (-[BrowserStatisticsWindowController windowDidLoad]):
 932         (-[BrowserStatisticsWindowController refreshStatistics:]):
 933         * MiniBrowser/mac/BrowserWindowController.h:
 934         * MiniBrowser/mac/English.lproj/MainMenu.xib:
 935         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
 936
 937 2010-04-22  Dave Moore  <davemoore@chromium.org>
 938
 939         Reviewed by Dimitri Glazkov.
 940
 941         Add test support for icon changes.
 942
 943         https://bugs.webkit.org/show_bug.cgi?id=33812
 944
 945         * DumpRenderTree/LayoutTestController.cpp:
 946         (LayoutTestController::LayoutTestController):
 947         (dumpIconChangesCallback):
 948         (LayoutTestController::staticFunctions):
 949         * DumpRenderTree/LayoutTestController.h:
 950         (LayoutTestController::dumpIconChanges):
 951         (LayoutTestController::setDumpIconChanges):
 952         * DumpRenderTree/win/FrameLoadDelegate.cpp:
 953         (FrameLoadDelegate::didChangeIcons):
 954         * DumpRenderTree/win/FrameLoadDelegate.h:
 955         * WinLauncher/WinLauncher.h:
 956         (WinLauncherWebHost::didChangeIcons):
 957
 958 2010-04-22  Eric Seidel  <eric@webkit.org>
 959
 960         Unreviewed.  Script fix.  Will ask dpranke to look tomorrow.
 961
 962         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
 963         https://bugs.webkit.org/show_bug.cgi?id=37794
 964
 965         The bots are seeing cases where .error is sometimes empty.
 966         Lets make the code not crash in that case for now.
 967
 968         * Scripts/webkitpy/layout_tests/port/webkit.py:
 969
 970 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
 971
 972         Unreviewed fix.
 973
 974         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
 975
 976 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
 977
 978         Unreviewed fix.
 979
 980         * Scripts/new-run-webkit-websocketserver: PyWebSocket no longer takes keyword argument 'register_cygwin'.
 981
 982 2010-04-22  Eric Seidel  <eric@webkit.org>
 983
 984         Unreviewed.  Restore the Leopard bots to using
 985         old-run-webkit-tests for now.
 986
 987         * Scripts/run-webkit-tests:
 988
 989 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
 990
 991         Unreviewed fix.
 992
 993         * Scripts/webkitpy/layout_tests/port/http_server.py: fix NameError: global name 'env' is not defined.
 994
 995 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
 996
 997         Unreviewed fix.
 998
 999         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'env' is not defined.
1000
1001 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1002
1003         Reviewed by Adam Barth.
1004
1005         Chromium: Add --chromium option to new-run-webkit-websocketserver
1006         https://bugs.webkit.org/show_bug.cgi?id=37664
1007
1008         Move cygwin setup logic in chromium_win.py.
1009
1010         * Scripts/new-run-webkit-httpd: remove register_cygwin parameter to pass http_server.
1011         * Scripts/new-run-webkit-websocketserver: add --chromium flag
1012         * Scripts/webkitpy/layout_tests/port/chromium_win.py: setup for cygwin
1013         * Scripts/webkitpy/layout_tests/port/http_server.py: remove cygwin setup logic
1014         * Scripts/webkitpy/layout_tests/port/websocket_server.py: remove cygwin setup logic
1015
1016 2010-04-22  Eric Seidel  <eric@webkit.org>
1017
1018         Reviewed by Adam Barth.
1019
1020         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
1021         https://bugs.webkit.org/show_bug.cgi?id=37794
1022
1023         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1024          - Fix the log message to explain that this is stderr output, not test output.
1025         * Scripts/webkitpy/layout_tests/port/webkit.py:
1026          - Be sure to reset the server_process.error after reading (seems like the wrong
1027            place to do this, but at least this fixes the bug and dpranke and I can talk
1028            about better designs later).
1029          - Also remove the #EOF from the stderr output before returning it.
1030
1031 2010-04-22  Eric Seidel  <eric@webkit.org>
1032
1033         Unreviewed.  Fixing new-run-webkit-tests on the bots.
1034
1035         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1036          - Fixing _compat_shim_option to take variable keyword args.
1037          - Turns out that nargs + callback is ignored unless type is specified.
1038            So I added the type so that the option was properly consumed.
1039            This was why new-run-webkit-tests couldn't find any tests, it
1040            was looking for them under "20" because that was the argument
1041            which should have been consumed by --exit-after-n-failures.
1042
1043 2010-04-22  Tony Chang  <tony@chromium.org>
1044
1045         Not reviewed, build fix for chromium Windows.
1046
1047         [chromium] fix ImageDiff compile on windows
1048         https://bugs.webkit.org/show_bug.cgi?id=37979
1049
1050         * DumpRenderTree/chromium/ImageDiff.cpp:
1051
1052 2010-04-22  Adam Barth  <abarth@webkit.org>
1053
1054         Unreviewed, rolling out r58069.
1055         http://trac.webkit.org/changeset/58069
1056         https://bugs.webkit.org/show_bug.cgi?id=27751
1057
1058         Broke compile on Windows.
1059
1060         * DumpRenderTree/LayoutTestController.cpp:
1061         (LayoutTestController::staticFunctions):
1062         * DumpRenderTree/LayoutTestController.h:
1063         * DumpRenderTree/chromium/LayoutTestController.cpp:
1064         (LayoutTestController::LayoutTestController):
1065         (LayoutTestController::overridePreference):
1066         * DumpRenderTree/chromium/LayoutTestController.h:
1067         * DumpRenderTree/chromium/TestShell.cpp:
1068         (TestShell::resetWebSettings):
1069         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1070         * DumpRenderTree/mac/DumpRenderTree.mm:
1071         (resetDefaultsToConsistentValues):
1072         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1073         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1074         (WebCore::WebPage::WebPage):
1075         (WebCore::WebPage::resetSettings):
1076         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1077         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1078         * DumpRenderTree/win/DumpRenderTree.cpp:
1079         (resetDefaultsToConsistentValues):
1080         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1081         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1082
1083 2010-04-22  Eric Seidel  <eric@webkit.org>
1084
1085         Unreviewed.  Just adding logging.
1086
1087         Adding logging to help debug why the Leopard Bot
1088         can't find any tests to run.
1089
1090         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1091         * Scripts/webkitpy/layout_tests/port/base.py:
1092         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1093          - Make it a fatal error to have no tests to run.
1094
1095 2010-04-22  Abhishek Arya  <inferno@chromium.org>
1096
1097         Reviewed by Adam Barth.
1098
1099         Add support for controlling clipboard access from javascript.
1100         Clipboard access from javascript is enabled in test framework.
1101         https://bugs.webkit.org/show_bug.cgi?id=27751
1102
1103         * DumpRenderTree/LayoutTestController.cpp:
1104         (setJavaScriptCanAccessClipboardCallback):
1105         (LayoutTestController::staticFunctions):
1106         * DumpRenderTree/LayoutTestController.h:
1107         * DumpRenderTree/chromium/LayoutTestController.cpp:
1108         (LayoutTestController::LayoutTestController):
1109         (LayoutTestController::setJavaScriptCanAccessClipboard):
1110         (LayoutTestController::overridePreference):
1111         * DumpRenderTree/chromium/LayoutTestController.h:
1112         * DumpRenderTree/chromium/TestShell.cpp:
1113         (TestShell::resetWebSettings):
1114         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1115         (LayoutTestController::setJavaScriptCanAccessClipboard):
1116         * DumpRenderTree/mac/DumpRenderTree.mm:
1117         (resetDefaultsToConsistentValues):
1118         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1119         (LayoutTestController::setJavaScriptCanAccessClipboard):
1120         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1121         (WebCore::WebPage::WebPage):
1122         (WebCore::WebPage::resetSettings):
1123         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1124         (LayoutTestController::setJavaScriptCanAccessClipboard):
1125         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1126         * DumpRenderTree/win/DumpRenderTree.cpp:
1127         (resetDefaultsToConsistentValues):
1128         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1129         (LayoutTestController::setJavaScriptCanAccessClipboard):
1130         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1131         (LayoutTestController::setJavaScriptCanAccessClipboard):
1132
1133 2010-04-21  Adam Barth  <abarth@webkit.org>
1134
1135         Reviewed by Eric Seidel.
1136
1137         webkit-patch can't fetch attachments on security bugs
1138         https://bugs.webkit.org/show_bug.cgi?id=37975
1139
1140         Instead of calling CURL, we just need to use our Mechanize object,
1141         which understand bugs.webkit.org authentication.
1142
1143         * Scripts/webkitpy/common/checkout/api.py:
1144         * Scripts/webkitpy/common/net/bugzilla.py:
1145
1146 2010-04-21  Eric Seidel  <eric@webkit.org>
1147
1148         Unreviewed.  Temporary commit, will roll-out before morning.
1149
1150         Turning on new-run-webkit-tests for the Leopard build bot
1151         for testing of the harness.
1152         Users should not noctice (except for the results.html difference).
1153
1154         * Scripts/run-webkit-tests:
1155
1156 2010-04-21  Eric Seidel  <eric@webkit.org>
1157
1158         Unreviewed.  Fix typo in my previous fix attempt.
1159
1160         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1161         https://bugs.webkit.org/show_bug.cgi?id=37765
1162
1163         More on-the-bot debugging, sigh.  I wish I had a local build.
1164
1165         * Scripts/webkitpy/layout_tests/port/base.py:
1166
1167 2010-04-21  Eric Seidel  <eric@webkit.org>
1168
1169         Unreviewed.  Fix typo in my previous fix attempt.
1170
1171         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1172         https://bugs.webkit.org/show_bug.cgi?id=37765
1173
1174         * Scripts/webkitpy/layout_tests/port/base.py:
1175          - Add self. to class variable access.
1176
1177 2010-04-21  Eric Seidel  <eric@webkit.org>
1178
1179         Unreviewed.  Another attempt to fix NRWT for chromium.
1180
1181         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1182         https://bugs.webkit.org/show_bug.cgi?id=37765
1183
1184         * Scripts/webkitpy/layout_tests/port/base.py:
1185          - wdiff_text was returning a byte array instead of a
1186            unicode string.  The simple fix was to just decode
1187            the result.  However, seeing so much duplicated code
1188            with Executive made me cry, so I re-wrote the function
1189            to be more like pretty_patch_text and use run_command
1190            (which already knows how to handle unicode).
1191
1192 2010-04-21  Adam Barth  <abarth@webkit.org>
1193
1194         Reviewed by Eric Seidel.
1195
1196         Windows tests buildbots are too slow to be core builders
1197         https://bugs.webkit.org/show_bug.cgi?id=37970
1198
1199         It's 10:45.  The Windows test bots are still hours behind.  They're too
1200         slow to be core builders.  When they get fast, we can add them back.
1201
1202         * Scripts/webkitpy/common/net/buildbot.py:
1203         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1204
1205 2010-04-21  Eric Seidel  <eric@webkit.org>
1206
1207         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1208
1209         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1210         https://bugs.webkit.org/show_bug.cgi?id=37765
1211
1212         I'm debugging in the blind because I don't have a chromium
1213         build on this laptop.
1214
1215         * Scripts/webkitpy/layout_tests/port/chromium.py:
1216          - Apply the previous fix to a second caller.
1217
1218 2010-04-21  Eric Seidel  <eric@webkit.org>
1219
1220         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1221
1222         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1223         https://bugs.webkit.org/show_bug.cgi?id=37765
1224
1225         * Scripts/webkitpy/layout_tests/port/chromium.py:
1226          - Fix handling of test_shell output so that we always
1227            decode it as utf-8.
1228            Unlike DumpRenderTree test_shell does not ever return
1229            pixel data.  It spits out the pixel dumps in a separate
1230            file, thus all output over stdout is utf-8 text.
1231
1232 2010-04-21  Eric Seidel  <eric@webkit.org>
1233
1234         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1235
1236         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1237         https://bugs.webkit.org/show_bug.cgi?id=37765
1238
1239         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1240          - Pass encoding to _save_baseline_data and write_output_files
1241         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1242          - Make _save_baseline_data and write_output_files take an encoding.
1243         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1244         - Pass encoding to _save_baseline_data and write_output_files
1245
1246 2010-04-21  No'am Rosenthal  <noam.rosenthal@nokia.com>
1247
1248         Reviewed by Kenneth Rohde Christiansen.
1249
1250         [Qt] QtLauncher: make FPS measurement accurate
1251         https://bugs.webkit.org/show_bug.cgi?id=37934
1252
1253         Instead of counting paints, which are not interchangeable with frames that
1254         the user sees, we now set an arbitrary timer for FPS measurements. The idea is
1255         that if the main thread is delayed for any reason, that timer would be delayed
1256         as well.
1257
1258         * QtLauncher/QtLauncher.pro:
1259         * QtLauncher/fpstimer.cpp: Added.
1260         (FpsTimer::FpsTimer):
1261         (FpsTimer::numFrames):
1262         (FpsTimer::start):
1263         (FpsTimer::stop):
1264         (FpsTimer::timerEvent):
1265         * QtLauncher/fpstimer.h: Added.
1266         * QtLauncher/webview.cpp:
1267         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
1268         (WebViewGraphicsBased::updateFrameRate):
1269         (WebViewGraphicsBased::paintEvent):
1270         * QtLauncher/webview.h:
1271
1272 2010-04-21  Eric Seidel  <eric@webkit.org>
1273
1274         Unreviewed, just adding missing ":" in python file.
1275
1276         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1277         https://bugs.webkit.org/show_bug.cgi?id=37765
1278
1279         new-run-webkit-tests --chromium was borked.
1280
1281         * Scripts/webkitpy/layout_tests/port/chromium.py:
1282
1283 2010-04-21  Eric Seidel  <eric@webkit.org>
1284
1285         Reviewed by Adam Barth.
1286
1287         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1288         https://bugs.webkit.org/show_bug.cgi?id=37765
1289
1290         Third time is the charm.  I've fixed all the
1291         new-run-webkit-tests regressions from previous attempts.
1292
1293         I fixed the queue to not ignore Tor as a reviwer in r57531,
1294         but instead it throws an exception every time his name is in a patch.
1295
1296         This fixes our Executive.run_command code to work around a Popen
1297         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
1298         do not correctly handle unicode objects as input or output to
1299         Popen.communicate.
1300
1301         Following the advice of:
1302         http://farmdev.com/talks/unicode/
1303         I have changed all of webkitpy to use unicode() objects as strings
1304         instead of str objects (which in Python 3 are renamed "bytes").
1305
1306         String literals were left as "foo" instead of converting to u"foo"
1307         as u"foo" is only required if the string has a non-ascii code point.
1308         Python is smart about comparing str() and unicode() values and will
1309         log an error to the console if the comparison is ever invalid.
1310
1311         Executive.run* now correctly accept and return unicode() objects.
1312         I attempted to fix all the places that we call .write() to make sure we
1313         encode any unicode() objects into utf-8.
1314
1315         I removed several uses of StringIO.  StringIO should generally always be
1316         passed a unicode() value.
1317
1318         Likewise I replaced most calls to open() with codecs.open().
1319         codecs.open() matches Python 3 open semantics in requiring an encoding
1320         parameter.  Files opened with codecs.open() with a unicode-compatible
1321         encoding will vend unicode() objects from their read() calls, like how
1322         StringIO created with a unicode() object will do.
1323
1324         I also deployed "with" statements wider (now that the project has
1325         settled on Python 2.5) to close a bunch of file descriptor leaks.
1326
1327         * Scripts/webkitpy/common/checkout/api_unittest.py:
1328          - Read/write utf-8 files instead of ascii.
1329          - Update the tests to use test for proper unicode() handling.
1330         * Scripts/webkitpy/common/checkout/changelog.py:
1331          - Document that parse_latest_entry_from_file expects
1332            file-like objects which return unicode strings.
1333         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1334          - Use unicode() strings instead of str() byte arrays.
1335          - Deploy "with" to close file descriptor leaks.
1336         * Scripts/webkitpy/common/checkout/commitinfo.py:
1337          - Remove unneeded import.
1338         * Scripts/webkitpy/common/checkout/scm.py:
1339          - Remove use of str().
1340         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1341          - Read/write utf-8 files and use unicode() strings in testing.
1342         * Scripts/webkitpy/common/config/committers.py:
1343          - Use \u instead of \x to make slightly clearer what we're doing.
1344         * Scripts/webkitpy/common/net/bugzilla.py:
1345          - Add a new _string_contents() method and explain why
1346             we have to call unicode() on the result of soup.string
1347             and why it's safe to do so w/o needing to pass a codec name.
1348           - Remove the (unused) support for passing a file object to add_patch_to_bug().
1349         * Scripts/webkitpy/common/net/buildbot.py:
1350          - Use unicode() instead of str() when needing to coax a
1351             NavigableString object into a unicode() object.
1352         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1353          - Add a test which contains a unicode builder name.
1354         * Scripts/webkitpy/common/net/statusserver.py:
1355          - Remove use of str()
1356         * Scripts/webkitpy/common/prettypatch.py:
1357          - Write out the patch file as utf-8.
1358         * Scripts/webkitpy/common/system/autoinstall.py:
1359          - Write out files with a explicit encodings.
1360          - Deploy "with" to close file descriptor leaks.
1361         * Scripts/webkitpy/common/system/deprecated_logging.py:
1362          - Write out log files as utf-8.
1363         * Scripts/webkitpy/common/system/executive.py:
1364          - Make run* properly take and return unicode() objects.
1365          - Cleaned up input handling in run_command a little by adding
1366            a _compute_input() method which can return early instead of having
1367            such a long/cluttered if-block.
1368         * Scripts/webkitpy/common/system/executive_unittest.py:
1369          - Added a unit test to make sure we don't break Tor again!
1370         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1371          - Write out the test list as utf-8.
1372         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1373          - Write out json files as utf-8.
1374         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1375          - Deploy "with" to close file descriptor leaks.
1376         * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
1377         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
1378         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
1379         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
1380         * Scripts/webkitpy/layout_tests/port/mac.py: ditto.
1381         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1382          - Make the skipped file parsing test unicode.
1383         * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
1384         * Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
1385         * Scripts/webkitpy/layout_tests/port/webkit.py:
1386          - Deploy "with" to close file descriptor leaks.
1387         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1388          - Make explicit the encodings of log files and pid files.
1389         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1390          - Make encodings explicit and deploy "with".
1391         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
1392         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
1393         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
1394         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
1395         * Scripts/webkitpy/style/filereader_unittest.py: ditto.
1396         * Scripts/webkitpy/thirdparty/__init__.py: ditto.
1397         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1398          - Removed extra import.
1399         * Scripts/webkitpy/tool/commands/queues.py:
1400          - No need to map args to strings now that run_command does.
1401          - Update test results to match args changes.
1402          - Document our global argument hacks.
1403         * Scripts/webkitpy/tool/commands/upload.py:
1404          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1405         * Scripts/webkitpy/tool/mocktool.py:
1406          - Rename add_patch_to_bug argument to match bugzilla.py
1407         * Scripts/webkitpy/tool/steps/abstractstep.py:
1408          - Executive.run_* now require lists instead of strings.
1409            The lack of this change was what broke webkit-patch
1410            for svn users the first time this was landed.
1411         * Scripts/webkitpy/tool/steps/postdiff.py:
1412          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1413         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
1414         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
1415         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1416          - Fixed spurious logging seen when running test-webkitpy
1417
1418 2010-04-21  Chris Fleizach  <cfleizach@apple.com>
1419
1420         Reviewed by Alexey Proskuryakov.
1421
1422         aria-liveregion-notifications.html fails on leopard release bot
1423         https://bugs.webkit.org/show_bug.cgi?id=37112
1424
1425         Change the way that notifications are listened for by forcing clients
1426         to call a remove listener as well to match the add listener. DRT will
1427         assert if those are not done in the correct order.
1428
1429         * DumpRenderTree/AccessibilityUIElement.cpp:
1430         (removeNotificationListenerCallback):
1431         (AccessibilityUIElement::getJSClass):
1432         * DumpRenderTree/AccessibilityUIElement.h:
1433         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1434         (AccessibilityUIElement::removeNotificationListener):
1435         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1436         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
1437         (-[AccessibilityNotificationHandler dealloc]):
1438         (-[AccessibilityNotificationHandler _notificationReceived:]):
1439         (-[AccessibilityNotificationHandler setCallback:]):
1440         (AccessibilityUIElement::AccessibilityUIElement):
1441         (AccessibilityUIElement::~AccessibilityUIElement):
1442         (AccessibilityUIElement::addNotificationListener):
1443         (AccessibilityUIElement::removeNotificationListener):
1444         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1445         (AccessibilityUIElement::removeNotificationListener):
1446
1447 2010-04-21  Anders Carlsson  <andersca@apple.com>
1448
1449         Reviewed by Sam Weinig.
1450
1451         Add debug menu items to show/hide the Web View.
1452         https://bugs.webkit.org/show_bug.cgi?id=37958
1453
1454         * MiniBrowser/mac/BrowserWindowController.h:
1455         * MiniBrowser/mac/BrowserWindowController.m:
1456         (-[BrowserWindowController showHideWebView:]):
1457         (-[BrowserWindowController removeReinsertWebView:]):
1458         (-[BrowserWindowController validateMenuItem:]):
1459         * MiniBrowser/mac/English.lproj/MainMenu.xib:
1460
1461 2010-04-21  Eric Seidel  <eric@webkit.org>
1462
1463         Unreviewed.  Rolling out unicode() changes as they broke NRWT for chromium.
1464         Rolling out:
1465         http://trac.webkit.org/changeset/58014
1466         http://trac.webkit.org/changeset/58016
1467         http://trac.webkit.org/changeset/58020
1468
1469         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbo
1470         https://bugs.webkit.org/show_bug.cgi?id=37765
1471
1472         * Scripts/webkitpy/common/checkout/api_unittest.py:
1473         * Scripts/webkitpy/common/checkout/changelog.py:
1474         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1475         * Scripts/webkitpy/common/checkout/commitinfo.py:
1476         * Scripts/webkitpy/common/checkout/scm.py:
1477         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1478         * Scripts/webkitpy/common/config/committers.py:
1479         * Scripts/webkitpy/common/net/bugzilla.py:
1480         * Scripts/webkitpy/common/net/buildbot.py:
1481         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1482         * Scripts/webkitpy/common/net/statusserver.py:
1483         * Scripts/webkitpy/common/prettypatch.py:
1484         * Scripts/webkitpy/common/system/autoinstall.py:
1485         * Scripts/webkitpy/common/system/deprecated_logging.py:
1486         * Scripts/webkitpy/common/system/executive.py:
1487         * Scripts/webkitpy/common/system/executive_unittest.py:
1488         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1489         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1490         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1491         * Scripts/webkitpy/layout_tests/port/chromium.py:
1492         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1493         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1494         * Scripts/webkitpy/layout_tests/port/gtk.py:
1495         * Scripts/webkitpy/layout_tests/port/mac.py:
1496         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1497         * Scripts/webkitpy/layout_tests/port/qt.py:
1498         * Scripts/webkitpy/layout_tests/port/server_process.py:
1499         * Scripts/webkitpy/layout_tests/port/webkit.py:
1500         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1501         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1502         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1503         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1504         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1505         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1506         * Scripts/webkitpy/style/filereader_unittest.py:
1507         * Scripts/webkitpy/thirdparty/__init__.py:
1508         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1509         * Scripts/webkitpy/tool/commands/queues.py:
1510         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1511         * Scripts/webkitpy/tool/commands/upload.py:
1512         * Scripts/webkitpy/tool/mocktool.py:
1513         * Scripts/webkitpy/tool/steps/abstractstep.py:
1514         * Scripts/webkitpy/tool/steps/postdiff.py:
1515         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
1516         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1517         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1518
1519 2010-04-21  Eric Seidel  <eric@webkit.org>
1520
1521         Unreviewed, fixing NRWT for real this time.
1522
1523         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1524         https://bugs.webkit.org/show_bug.cgi?id=37765
1525
1526         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1527          - Add a hack to fix new-run-webkit-tests
1528            my understanding of codecs.open(encoding=None)
1529            must have been wrong.
1530
1531 2010-04-21  Eric Seidel  <eric@webkit.org>
1532
1533         Unreviewed, just fixing exception seen on builders.
1534
1535         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1536         https://bugs.webkit.org/show_bug.cgi?id=37765
1537
1538         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1539          - Pass and encoding to _write_into_file_at_path
1540
1541 2010-04-21  Eric Seidel  <eric@webkit.org>
1542
1543         Reviewed by Adam Barth.
1544
1545         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1546         https://bugs.webkit.org/show_bug.cgi?id=37765
1547
1548         I fixed the queue to not ignore Tor as a reviwer in r57531,
1549         but instead it throws an exception every time his name is in a patch.
1550
1551         This fixes our Executive.run_command code to work around a Popen
1552         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
1553         do not correctly handle unicode objects as input or output to
1554         Popen.communicate.
1555
1556         Following the advice of:
1557         http://farmdev.com/talks/unicode/
1558         I have changed all of webkitpy to use unicode() objects as strings
1559         instead of str objects (which in Python 3 are renamed "bytes").
1560
1561         String literals were left as "foo" instead of converting to u"foo"
1562         as u"foo" is only required if the string has a non-ascii code point.
1563         Python is smart about comparing str() and unicode() values and will
1564         log an error to the console if the comparison is ever invalid.
1565
1566         Executive.run* now correctly accept and return unicode() objects.
1567         I attempted to fix all the places that we call .write() to make sure we
1568         encode any unicode() objects into utf-8.
1569
1570         I removed several uses of StringIO.  StringIO should generally always be
1571         passed a unicode() value.
1572
1573         Likewise I replaced most calls to open() with codecs.open().
1574         codecs.open() matches Python 3 open semantics in requiring an encoding
1575         parameter.  Files opened with codecs.open() with a unicode-compatible
1576         encoding will vend unicode() objects from their read() calls, like how
1577         StringIO created with a unicode() object will do.
1578
1579         I also deployed "with" statements wider (now that the project has
1580         settled on Python 2.5) to close a bunch of file descriptor leaks.
1581
1582         * Scripts/webkitpy/common/checkout/api_unittest.py:
1583          - Read/write utf-8 files instead of ascii.
1584          - Update the tests to use test for proper unicode() handling.
1585         * Scripts/webkitpy/common/checkout/changelog.py:
1586          - Document that parse_latest_entry_from_file expects
1587            file-like objects which return unicode strings.
1588         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1589          - Use unicode() strings instead of str() byte arrays.
1590          - Deploy "with" to close file descriptor leaks.
1591         * Scripts/webkitpy/common/checkout/commitinfo.py:
1592          - Remove unneeded import.
1593         * Scripts/webkitpy/common/checkout/scm.py:
1594          - Remove use of str().
1595         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1596          - Read/write utf-8 files and use unicode() strings in testing.
1597         * Scripts/webkitpy/common/config/committers.py:
1598          - Use \u instead of \x to make slightly clearer what we're doing.
1599         * Scripts/webkitpy/common/net/bugzilla.py:
1600          - Add a new _string_contents() method and explain why
1601             we have to call unicode() on the result of soup.string
1602             and why it's safe to do so w/o needing to pass a codec name.
1603           - Remove the (unused) support for passing a file object to add_patch_to_bug().
1604         * Scripts/webkitpy/common/net/buildbot.py:
1605          - Use unicode() instead of str() when needing to coax a
1606             NavigableString object into a unicode() object.
1607         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1608          - Add a test which contains a unicode builder name.
1609         * Scripts/webkitpy/common/net/statusserver.py:
1610          - Remove use of str()
1611         * Scripts/webkitpy/common/prettypatch.py:
1612          - Write out the patch file as utf-8.
1613         * Scripts/webkitpy/common/system/autoinstall.py:
1614          - Write out files with a explicit encodings.
1615          - Deploy "with" to close file descriptor leaks.
1616         * Scripts/webkitpy/common/system/deprecated_logging.py:
1617          - Write out log files as utf-8.
1618         * Scripts/webkitpy/common/system/executive.py:
1619          - Make run* properly take and return unicode() objects.
1620          - Cleaned up input handling in run_command a little by adding
1621            a _compute_input() method which can return early instead of having
1622            such a long/cluttered if-block.
1623         * Scripts/webkitpy/common/system/executive_unittest.py:
1624          - Added a unit test to make sure we don't break Tor again!
1625         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1626          - Write out the test list as utf-8.
1627         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1628          - Write out json files as utf-8.
1629         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1630          - Deploy "with" to close file descriptor leaks.
1631         * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
1632         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
1633         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
1634         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
1635         * Scripts/webkitpy/layout_tests/port/mac.py: ditto.
1636         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1637          - Make the skipped file parsing test unicode.
1638         * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
1639         * Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
1640         * Scripts/webkitpy/layout_tests/port/webkit.py:
1641          - Deploy "with" to close file descriptor leaks.
1642         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1643          - Make explicit the encodings of log files and pid files.
1644         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1645          - Make encodings explicit and deploy "with".
1646         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
1647         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
1648         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
1649         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
1650         * Scripts/webkitpy/style/filereader_unittest.py: ditto.
1651         * Scripts/webkitpy/thirdparty/__init__.py: ditto.
1652         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1653          - Removed extra import.
1654         * Scripts/webkitpy/tool/commands/queues.py:
1655          - No need to map args to strings now that run_command does.
1656          - Update test results to match args changes.
1657          - Document our global argument hacks.
1658         * Scripts/webkitpy/tool/commands/upload.py:
1659          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1660         * Scripts/webkitpy/tool/mocktool.py:
1661          - Rename add_patch_to_bug argument to match bugzilla.py
1662         * Scripts/webkitpy/tool/steps/abstractstep.py:
1663          - Executive.run_* now require lists instead of strings.
1664            The lack of this change was what broke webkit-patch
1665            for svn users the first time this was landed.
1666         * Scripts/webkitpy/tool/steps/postdiff.py:
1667          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1668         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
1669         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
1670         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1671          - Fixed spurious logging seen when running test-webkitpy
1672
1673 2010-04-21  Kinuko Yasuda  <kinuko@chromium.org>
1674
1675         Unreviewed.
1676
1677         Add myself in committers.py.
1678
1679         * Scripts/webkitpy/common/config/committers.py:
1680
1681 2010-04-21  Dirk Pranke  <dpranke@chromium.org>
1682
1683         Reviewed by Dimitri Glazkov.
1684
1685         new-run-webkit-tests: fix a bug in the Chromium port where we would
1686         try to talk to a crashed test_shell and raise exceptions that weren't
1687         being caught.
1688
1689         https://bugs.webkit.org/show_bug.cgi?id=37941
1690
1691         * Scripts/webkitpy/layout_tests/port/chromium.py:
1692
1693 2010-04-21  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1694
1695         Unreviewed.
1696
1697         [Qt] [Symbian] Build fix.
1698
1699         Work around a Qt quirk. Some versions of Symbian port Qt
1700         QFontDatabase::removeAllApplicationFonts symbol is not available.
1701
1702         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1703         (WebCore::DumpRenderTree::open):
1704
1705 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
1706
1707         Unreviewed.
1708
1709         https://bugs.webkit.org/show_bug.cgi?id=37933
1710         <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
1711
1712         Adding stub implementation of authenticateSession(). Depending on platform loader behavior,
1713         a real implementation may or may not be necessary for the one test that currently uses it
1714         to pass.
1715
1716         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1717         (LayoutTestController::authenticateSession):
1718         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1719
1720 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
1721
1722         Reviewed by Brady Eidson.
1723
1724         https://bugs.webkit.org/show_bug.cgi?id=37933
1725         <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
1726
1727         Adding authenticateSession() method that adds credentials to per-process credential storage
1728         (for platforms that even have such). No Windows implementation, because writing another
1729         loader for DRT is painful.
1730
1731         * DumpRenderTree/LayoutTestController.cpp:
1732         (authenticateSessionCallback):
1733         (LayoutTestController::staticFunctions):
1734         * DumpRenderTree/LayoutTestController.h:
1735         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1736         (-[SynchronousLoader dealloc]):
1737         (-[SynchronousLoader connectionShouldUseCredentialStorage:]):
1738         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
1739         (-[SynchronousLoader connection:didFailWithError:]):
1740         (-[SynchronousLoader connectionDidFinishLoading:]):
1741         (+[SynchronousLoader makeRequest:withUsername:password:]):
1742         (LayoutTestController::authenticateSession):
1743
1744         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1745         (LayoutTestController::authenticateSession):
1746         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1747         (LayoutTestController::authenticateSession):
1748         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1749         (LayoutTestController::authenticateSession):
1750         Stub implementations.
1751
1752 2010-04-21  Kent Tamura  <tkent@chromium.org>
1753
1754         Reviewed by Dimitri Glazkov.
1755
1756         [DRT/Chromium] Make DRT compilable in Chromium tree
1757         https://bugs.webkit.org/show_bug.cgi?id=37923
1758
1759         We need to use different GYPs in a case of WebKit-only checkout
1760         and a case of whole Chromium checkout because the relative paths
1761         from webkit/ to WebKit/chromium/features.gypi are different in
1762         these cases and we can't use 'conditions' for 'includes' in GYPs.
1763
1764         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1765
1766 2010-04-21  Jakub Wieczorek  <jwieczorek@webkit.org>
1767
1768         Reviewed by Darin Adler.
1769
1770         List item markers are not always updated after changes in the DOM.
1771         https://bugs.webkit.org/show_bug.cgi?id=37060
1772
1773         * DumpRenderTree/LayoutTestController.cpp:
1774         (markerTextForListItemCallback): A function that returns the marker text for a given list item.
1775         (LayoutTestController::staticFunctions):
1776         * DumpRenderTree/LayoutTestController.h:
1777         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1778         (LayoutTestController::markerTextForListItem): Implement it in the GTK port.
1779         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1780         (LayoutTestController::markerTextForListItem): Add a stub.
1781         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1782         (LayoutTestController::LayoutTestController):
1783         (LayoutTestController::markerTextForListItem): Implement it in the Qt port.
1784         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1785         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1786         (LayoutTestController::markerTextForListItem): Add a stub.
1787
1788 2010-04-21  Adam Roben  <aroben@apple.com>
1789
1790         Exclude leaks in CGGradientCreateWithColorComponents from
1791         run-webkit-tests leaks output
1792
1793         The leak in CG is covered by <rdar://problem/7888492>.
1794
1795         Fixes <http://webkit.org/b/37927>.
1796
1797         Reviewed by Eric Carlson.
1798
1799         * Scripts/old-run-webkit-tests:
1800         (sub countAndPrintLeaks): Exclude leaks in
1801         CGGradientCreateWithColorComponents on certain OSs.
1802
1803 2010-04-21  Kent Tamura  <tkent@chromium.org>
1804
1805         Reviewed by Shinichiro Hamaji.
1806
1807         [DRT/Chromium] Import MockSpellCheck from Chromium
1808         https://bugs.webkit.org/show_bug.cgi?id=37910
1809
1810         Import webkit/tools/test_shell/mock_spellcheck.{cc,h} rev.37241 of Chromium.
1811
1812         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1813           Add ICU explicitly because WTFString.h includes ICU headers.
1814           Add MockSpellCheck.{cpp,h}.
1815         * DumpRenderTree/chromium/MockSpellCheck.cpp: Added.
1816         * DumpRenderTree/chromium/MockSpellCheck.h: Added.
1817         * DumpRenderTree/chromium/WebViewHost.cpp:
1818         (WebViewHost::spellCheck):
1819         * DumpRenderTree/chromium/WebViewHost.h:
1820         * DumpRenderTree/chromium/config.h: Define JS_EXPORTDATA, which is used
1821           by wtf/text/AtomicString.h included by wtf/text/WTFString.h.
1822
1823 2010-04-21  Adam Barth  <abarth@webkit.org>
1824
1825         Reviewed by Eric Seidel.
1826
1827         Add webkit-patch pretty-diff
1828         https://bugs.webkit.org/show_bug.cgi?id=37892
1829
1830         This is slightly lame because it asks you whether the diff is correct,
1831         but it's a starting point.
1832
1833         * Scripts/webkitpy/tool/commands/__init__.py:
1834         * Scripts/webkitpy/tool/commands/prettydiff.py: Added.
1835         * Scripts/webkitpy/tool/main.py:
1836
1837 2010-04-21  Adam Barth  <abarth@webkit.org>
1838
1839         Reviewed by Darin Adler.
1840
1841         Remove mention of non-existant --no-build option
1842         https://bugs.webkit.org/show_bug.cgi?id=37893
1843
1844         The option doesn't exist!
1845
1846         * Scripts/webkitpy/tool/commands/stepsequence.py:
1847
1848 2010-04-21  Balazs Kelemen  <kb@inf.u-szeged.hu>
1849
1850         Reviewed by Kenneth Rohde Christiansen.
1851
1852         [Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling.
1853         https://bugs.webkit.org/show_bug.cgi?id=37198
1854
1855         * QtLauncher/main.cpp:
1856         (LauncherWindow::toggleInterruptingJavaScriptEnabled):
1857         (LauncherWindow::newWindow):
1858         (LauncherWindow::cloneWindow):
1859         (LauncherWindow::createChrome):
1860         (main):
1861         * QtLauncher/webpage.cpp:
1862         (WebPage::WebPage):
1863         (WebPage::shouldInterruptJavaScript):
1864         * QtLauncher/webpage.h:
1865         (WebPage::setInterruptingJavaScriptEnabled):
1866
1867 2010-04-21  Eric Seidel  <eric@webkit.org>
1868
1869         Unreviewed, rolling out r57963.
1870         http://trac.webkit.org/changeset/57963
1871         https://bugs.webkit.org/show_bug.cgi?id=37759
1872
1873         Three tests started crashing on the Qt bot.
1874
1875         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1876         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1877
1878 2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1879
1880         Reviewed by Eric Seidel.
1881
1882         Make new-run-webkit-tests work for the Qt port
1883         https://bugs.webkit.org/show_bug.cgi?id=37588
1884
1885         * Scripts/webkitpy/layout_tests/port/qt.py:
1886
1887 2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1888
1889         Reviewed by Eric Seidel.
1890
1891         new-run-webkit-tests: try to detect alternate apache path
1892         https://bugs.webkit.org/show_bug.cgi?id=37587
1893
1894         _check_port_build() also needs to return true in the
1895         base implementation to not fail the check_build step.
1896
1897         * Scripts/webkitpy/layout_tests/port/webkit.py:
1898
1899 2010-04-21  Yi Shen  <yi.4.shen@nokia.com>
1900
1901         Reviewed by Simon Hausmann.
1902
1903         [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
1904         https://bugs.webkit.org/show_bug.cgi?id=37759
1905
1906         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1907         (LayoutTestController::computedStyleIncludingVisitedInfo):
1908         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1909
1910 2010-04-21  Eric Seidel  <eric@webkit.org>
1911
1912         Unreviewed, test fix only.
1913
1914         new-run-webkit-tests: implement a --log trace message to be able to display detailed output of an individual test run
1915         https://bugs.webkit.org/show_bug.cgi?id=37726
1916
1917         This change seems to have broken a test.
1918         Attempting to handle the case where we don't have any
1919         timing information.  Dirk may have to correct this change.
1920
1921         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1922
1923 2010-04-19  Eric Seidel  <eric@webkit.org>
1924
1925         Reviewed by Adam Barth.
1926
1927         new-run-webkit-tests has much higher startup latency than run-webkit-tests
1928         https://bugs.webkit.org/show_bug.cgi?id=37643
1929
1930         I got rid of the -expected.checksum reads during startup.
1931         This makes startup noticably better on my laptop.
1932
1933         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1934          - Use image_hash() instead of .image_hash now that expected.checksum
1935            file reads are done lazily.
1936         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1937          - Add debug logging for this sleep call.
1938            In my testing I never saw this sleep() hit.
1939         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1940          - Sleep a shorter interval to make websocket server
1941            startup more responsive.  On my machine startup was
1942            taking around 1 second.
1943          - Remove the unconditional .5s delay on startup.
1944         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1945          - Make image_hash file reads done lazily in a new image_hash() function.
1946          - Add a "Starting testing ..." meter update after DRT threads have
1947            been started, but before we get updates from the first one.
1948          - Rename variable "t" to a full english name to match WebKit style.
1949
1950 2010-04-20  Daniel Bates  <dbates@rim.com>
1951
1952         Reviewed by Eric Seidel.
1953
1954         https://bugs.webkit.org/show_bug.cgi?id=37748
1955
1956         Make Sheriffbot more inspirational.
1957
1958         * Scripts/webkitpy/common/net/bugzilla.py:
1959         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1960         * Scripts/webkitpy/tool/bot/irc_command.py:
1961         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1962         * Scripts/webkitpy/tool/mocktool.py:
1963
1964 2010-04-20  Kent Tamura  <tkent@chromium.org>
1965
1966         Reviewed by Dimitri Glazkov.
1967
1968         [DRT/Chromium] Import Chromium image_diff as ImageDiff
1969         https://bugs.webkit.org/show_bug.cgi?id=37790
1970
1971         ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium.
1972
1973         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1974         * DumpRenderTree/chromium/ImageDiff.cpp: Added.
1975         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1976
1977 2010-04-20  Dirk Pranke <dpranke@chromium.org>
1978
1979         This patch to new-run-webkit-tests adds a --log 'trace' option
1980         that prints out detailed info about a given test as it executes
1981         (where the baselines are, what the expectation is, what we got,
1982         how long it took).
1983
1984         https://bugs.webkit.org/show_bug.cgi?id=37726
1985
1986         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1987           - use the newly exposed TestResult class and implement
1988             --log trace
1989         * Scripts/webkitpy/layout_tests/layout_package/dump_render_thread.py:
1990           - rename TestStats to TestResult and make it more public, resulting
1991             in cleaner code
1992         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1993           - add expectation_to_string() as a separate callable function
1994
1995 2010-04-20  Eric Seidel  <eric@webkit.org>
1996
1997         Unreviewed, rolling out r57907.
1998         http://trac.webkit.org/changeset/57907
1999         https://bugs.webkit.org/show_bug.cgi?id=37765
2000
2001         Appears to have broken MacEWS and possibly webkit-patch upload
2002         for svn users.  Needs further investigation.
2003
2004         * Scripts/webkitpy/common/checkout/api.py:
2005         * Scripts/webkitpy/common/checkout/api_unittest.py:
2006         * Scripts/webkitpy/common/checkout/changelog.py:
2007         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2008         * Scripts/webkitpy/common/checkout/commitinfo.py:
2009         * Scripts/webkitpy/common/checkout/scm.py:
2010         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2011         * Scripts/webkitpy/common/config/committers.py:
2012         * Scripts/webkitpy/common/net/bugzilla.py:
2013         * Scripts/webkitpy/common/net/buildbot.py:
2014         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2015         * Scripts/webkitpy/common/net/statusserver.py:
2016         * Scripts/webkitpy/common/prettypatch.py:
2017         * Scripts/webkitpy/common/system/autoinstall.py:
2018         * Scripts/webkitpy/common/system/deprecated_logging.py:
2019         * Scripts/webkitpy/common/system/executive.py:
2020         * Scripts/webkitpy/common/system/executive_unittest.py:
2021         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2022         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2023         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2024         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2025         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2026         * Scripts/webkitpy/tool/commands/queues.py:
2027         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2028         * Scripts/webkitpy/tool/commands/upload.py:
2029         * Scripts/webkitpy/tool/mocktool.py:
2030         * Scripts/webkitpy/tool/steps/abstractstep.py:
2031         * Scripts/webkitpy/tool/steps/postdiff.py:
2032         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
2033         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2034         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2035
2036 2010-04-20  Nate Chapin  <japhet@chromium.org>
2037
2038         Unreviewed.
2039
2040         Update my irc handle in committers.py (natechapin -> japhet).
2041
2042         * Scripts/webkitpy/common/config/committers.py:
2043
2044 2010-04-20  Eric Seidel  <eric@webkit.org>
2045
2046         Reviewed by Adam Barth.
2047
2048         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
2049         https://bugs.webkit.org/show_bug.cgi?id=37765
2050
2051         I fixed the queue to not ignore Tor as a reviwer in r57531,
2052         but instead it throws an exception every time his name is in a patch.
2053
2054         This fixes our Executive.run_command code to work around a Popen
2055         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
2056         do not correctly handle unicode objects as input or output to
2057         Popen.communicate.
2058
2059         Following the advice of:
2060         http://farmdev.com/talks/unicode/
2061         I'm attempting to take the python unicode plunge and use unicode()
2062         objects as strings instead of str() objects everywhere in webkitpy.
2063
2064         We do not have to use u"" instead of "" because u"a" == "a" as expected
2065         in Python.  Python will generate a warning to the console in cases where
2066         a unicode() == str() operation cannot be performed.
2067
2068         I also cleaned up the input handling in run_command a little by adding
2069         a new _compute_input() method which can return early instead of having
2070         such a long/cluttered if-block.
2071
2072         Executive.run* now correctly accept and return unicode() objects.
2073         I attempted to fix all the places that we call .write() to make sure we
2074         encode any unicode() objects into utf-8.
2075
2076         All places which use StringIO need to be sure to pass StringIO a
2077         pre-encoded byte-array (str object) instead of unicode so that
2078         clients which read from the StringIO don't have encoding exceptions.
2079         To make this easier, I removed the patch_file_object support from
2080         add_patch_to_bug, and changed the 4 places which previously used
2081         StringIO to create a fake patch file.
2082
2083         I attempted to document any places where we are not correctly converting
2084         to/from bytes (str() objects) to strings (unicode() objects).
2085
2086         * Scripts/webkitpy/common/checkout/api_unittest.py:
2087          - Read/write utf-8 files instead of ascii.
2088          - Update the tests to use test for proper unicode() handling.
2089         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2090          - Use unicode() strings instead of str() byte arrays.
2091         * Scripts/webkitpy/common/checkout/scm.py:
2092          - Remove use of str().
2093         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2094          - Read/write utf-8 files and use unicode() strings in testing.
2095         * Scripts/webkitpy/common/config/committers.py:
2096          - Use \u instead of \x to make slightly clearer what we're doing.
2097         * Scripts/webkitpy/common/net/bugzilla.py:
2098          - Add a new _string_contents() method and explain why
2099            we have to call unicode() on the result of soup.string
2100            and why it's safe to do so w/o needing to pass a codec name.
2101          - Remove the (unused) support for passing a file object to add_patch_to_bug().
2102         * Scripts/webkitpy/common/net/buildbot.py:
2103          - Use unicode() instead of str() when needing to coax a
2104            NavigableString object into a unicode() object.
2105         * Scripts/webkitpy/common/net/statusserver.py:
2106          - Remove use of str()
2107         * Scripts/webkitpy/common/prettypatch.py:
2108          - Write out the patch file as utf-8.
2109         * Scripts/webkitpy/common/system/autoinstall.py:
2110          - Add a FIXME about encoding.
2111         * Scripts/webkitpy/common/system/deprecated_logging.py:
2112          - Document that tee() works on bytes, not strings.
2113         * Scripts/webkitpy/common/system/executive.py:
2114          - Make run* properly take and return unicode() objects.
2115         * Scripts/webkitpy/common/system/executive_unittest.py:
2116          - Added a unit test to make sure we don't break Tor again!
2117         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2118          - Write out the test list as utf-8.
2119         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2120          - Write out json files as utf-8.
2121         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2122          - Add FIXME about encoding handling.
2123         * Scripts/webkitpy/tool/commands/upload.py:
2124          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2125         * Scripts/webkitpy/tool/mocktool.py:
2126          - Rename add_patch_to_bug argument to match bugzilla.py
2127         * Scripts/webkitpy/tool/steps/postdiff.py:
2128          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2129         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto.
2130         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto.
2131         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2132          - Fixed spurious logging seen when running test-webkitpy
2133
2134 2010-04-20  Chris Jerdonek  <cjerdonek@webkit.org>
2135
2136         Reviewed by Shinichiro Hamaji.
2137
2138         For check-webkit-style, implemented __eq__() and __ne__() (the
2139         built-in equality and inequality methods) for the
2140         DefaultStyleErrorHandler class.
2141
2142         https://bugs.webkit.org/show_bug.cgi?id=37850
2143
2144         This will facilitate unit-testing for a subsequent patch,
2145         namely for https://bugs.webkit.org/show_bug.cgi?id=37850
2146
2147         * Scripts/webkitpy/style/error_handlers.py:
2148           - Added __eq__() and __ne__() to the DefaultStyleErrorHandler
2149             class.
2150
2151         * Scripts/webkitpy/style/error_handlers_unittest.py:
2152           - Added unit tests for __eq__() and __ne__().
2153           - Also included a minor clean-up refactoring of combining the
2154             StyleErrorHandlerTestBase class (which has not needed to
2155             be separate due to previous changes) into the
2156             DefaultStyleErrorHandlerTest class.
2157
2158 2010-04-20  Jakub Wieczorek  <jwieczorek@webkit.org>
2159
2160         Unreviewed.
2161
2162         Add my IRC nick to the committers.py list.
2163
2164         * Scripts/webkitpy/common/config/committers.py:
2165
2166 2010-04-20  Kim Grönholm  <kim.gronholm@nomovok.com>
2167
2168         Reviewed by Simon Hausmann.
2169
2170         [Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView
2171         https://bugs.webkit.org/show_bug.cgi?id=37816
2172
2173         Fix multi-touch mocking in QtLauncher when using QGraphicsView.
2174         Test: https://bug-32434-attachments.webkit.org/attachment.cgi?id=44955
2175
2176         * QtLauncher/main.cpp:
2177         (LauncherWindow::eventFilter):
2178         (LauncherWindow::initializeView):
2179
2180 2010-04-20  MORITA Hajime <morrita@google.com>
2181
2182         Unreviewed, add myself to the committers list.
2183
2184         * Scripts/webkitpy/common/config/committers.py:
2185
2186 2010-04-20  Kent Tamura  <tkent@chromium.org>
2187
2188         Reviewed by Shinichiro Hamaji.
2189
2190         [DRT/Chromium] Fix some unexpected results of editing
2191         https://bugs.webkit.org/show_bug.cgi?id=37843
2192
2193         This change fixes about 70 unexpected results.
2194         The original test_webview_delegate.cc doesn't have this bug.
2195         The bug was introduced when I ported it to WebKit tree.
2196
2197         * DumpRenderTree/chromium/WebViewHost.cpp:
2198         (printRangeDescription): Replace the latter startContainer() with endContainer().
2199
2200 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2201
2202         Unreviewed, build fix.
2203
2204         Turn off some unit tests for now - the new-run-webkit-tests dryrun
2205         tests for chromium won't work if you don't have a chromium checkout.
2206
2207         https://bugs.webkit.org/show_bug.cgi?id=37841
2208
2209         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2210
2211 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2212
2213         Unreviewed, build fix.
2214
2215         (Re-)add dryrun.py; this was renamed from passing.py in the previous
2216         CL but apparently somehow didn't get checked in.
2217
2218         https://bugs.webkit.org/show_bug.cgi?id=37841
2219
2220         * Scripts/webkitpy/layout_tests/port/dryrun.py: Added.
2221
2222 2010-04-19  Shinichiro Hamaji  <hamaji@chromium.org>
2223
2224         Reviewed by David Levin.
2225
2226         check-webkit-style: exits when encountering a deleted file
2227         https://bugs.webkit.org/show_bug.cgi?id=37122
2228
2229         This reverts the quick fix done by r57119 and makes check_patch
2230         not call check_file for deleted files.
2231
2232         Also this change fixes the behavior for "-", which should mean
2233         stdin.  Before this change, the style checker just ignored "-"
2234         with a warning message.
2235
2236         * Scripts/webkitpy/style/checker.py:
2237         * Scripts/webkitpy/style/checker_unittest.py:
2238
2239 2010-04-19  Daniel Bates  <dbates@rim.com>
2240
2241         No review, rolling out 57868.
2242         http://trac.webkit.org/changeset/57868
2243         https://bugs.webkit.org/show_bug.cgi?id=37748
2244
2245         Sheriffbot wasn't very inspirational after this patch.
2246         Instead, he was silent when you said hi :-(. Rolling
2247         out this patch so that I can debug/test this some more.
2248
2249         * Scripts/webkitpy/common/net/bugzilla.py:
2250         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2251         * Scripts/webkitpy/tool/bot/irc_command.py:
2252         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2253         * Scripts/webkitpy/tool/mocktool.py:
2254
2255 2010-04-19  Daniel Bates  <dbates@rim.com>
2256
2257         Reviewed by Adam Barth.
2258
2259         https://bugs.webkit.org/show_bug.cgi?id=37748
2260
2261         Make Sheriffbot more inspirational.
2262
2263         * Scripts/webkitpy/common/net/bugzilla.py:
2264         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2265         * Scripts/webkitpy/tool/bot/irc_command.py:
2266         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2267         * Scripts/webkitpy/tool/mocktool.py:
2268
2269 2010-04-19  Kevin Ollivier  <kevino@theolliviers.com>
2270
2271         [wx] Build fix, add missing header.
2272
2273         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2274
2275 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2276
2277          Reviewed by Adam Barth.
2278
2279          new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port
2280          that can be used to test platforms other than the one you are running
2281          on. This can be useful for checking baselines and testing code
2282          coverage.
2283
2284          Note that running the code on the "wrong" port requires each
2285          port-specific implementation to actually not require any
2286          platform-specific python code (e.g., the chromium-win port must
2287          test for the existence of windows functions before calling them).
2288
2289          https://bugs.webkit.org/show_bug.cgi?id=37782
2290
2291          * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2292          * Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py.
2293          * Scripts/webkitpy/layout_tests/port/factory.py:
2294          * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2295
2296 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2297
2298         Reviewed by Eric Seidel.
2299
2300         new-run-webkit-tests: add --build (default) and --no-build
2301         options to make that step optional. This flag modifies what happens
2302         in port.check_build().
2303
2304         https://bugs.webkit.org/show_bug.cgi?id=37786
2305
2306         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2307         * Scripts/webkitpy/layout_tests/port/chromium.py:
2308         * Scripts/webkitpy/layout_tests/port/webkit.py:
2309
2310 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2311
2312         Unreviewed, build fix.
2313
2314         new-run-webkit-tests - fix a typo in r57480 that caused us to stop
2315         logging the actual list of unexpected results.
2316
2317         https://bugs.webkit.org/show_bug.cgi?id=37831
2318
2319         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2320
2321 2010-04-19  Dirk Pranke <dpranke@chromium.org>
2322
2323         Reviewed by Adam Barth.
2324
2325         From a patch by Tor Arne Vestbo  <tor.arne.vestbo@nokia.com>
2326
2327         new-run-webkit-tests: make the retry step more explicit
2328         https://bugs.webkit.org/show_bug.cgi?id=37606
2329
2330         It might be confusing to see the test and percent counters
2331         reset without any notice of what's going on, so we make the
2332         message that a retry-run is started explicit.
2333
2334         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2335
2336 2010-04-19  Sam Weinig  <weinig@apple.com>
2337
2338         Reviewed by Anders Carlsson.
2339
2340         Add support for opening a new window (File->New Window) to
2341         Windows MiniBrowser. Accelerator doesn't work.
2342
2343         * MiniBrowser/win/BrowserView.cpp:
2344         (createNewPage): Use BrowserView::create.
2345         * MiniBrowser/win/BrowserWindow.cpp:
2346         (BrowserWindow::onCommand): Respond to ID_FILE_NEW_WINDOW
2347         by creating a new window.
2348         * MiniBrowser/win/BrowserWindow.h:
2349         (BrowserWindow::create): Added. Don't allow creating
2350         BrowserWindows on the stack by making constructor
2351         private and exposing the create function.
2352         * MiniBrowser/win/MiniBrowser.cpp:
2353         (MiniBrowser::createNewWindow): Move new window creation
2354         logic here.
2355         * MiniBrowser/win/MiniBrowser.h:
2356         * MiniBrowser/win/MiniBrowser.rc:
2357         * MiniBrowser/win/main.cpp:
2358         (_tWinMain): Use the new MiniBrowser::createNewWindow().
2359
2360 2010-04-19  Chris Fleizach  <cfleizach@apple.com>
2361
2362         Reviewed by Beth Dakin.
2363
2364         AX: aria-haspopup needs to be exposed
2365         https://bugs.webkit.org/show_bug.cgi?id=37808
2366
2367         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2368         (AccessibilityUIElement::hasPopup):
2369
2370 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2371
2372         Reviewed by Eric Seidel.
2373
2374         Submit a better workaround for r57806 than the one in r57831 - log
2375         an error and exit if you try to run new-run-webkit-tests with --use-drt
2376         on Windows.
2377
2378         https://bugs.webkit.org/show_bug.cgi?id=37822
2379
2380         * Scripts/webkitpy/layout_tests/port/chromium.py:
2381
2382 2010-04-19  Jesus Sanchez-Palencia  <jesus@webkit.org>
2383
2384         Unreviewed.
2385
2386         Just adding myself as a committer.
2387
2388         * Scripts/webkitpy/common/config/committers.py:
2389
2390 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2391
2392         Reviewed by Eric Seidel.
2393
2394         Add slightly better logging to the websocket python wrapper script,
2395         including a --verbose flag for debug output.
2396
2397         https://bugs.webkit.org/show_bug.cgi?id=37233
2398
2399         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2400         * Scripts/new-run-webkit-websocketserver:
2401
2402 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2403
2404         Reviewed by Eric Seidel.
2405
2406         new-run-webkit-tests: add a way (--print-unexpected-results) to
2407         (re-)print out the tests that produced unexpected results in the
2408         last run. Also add a way (--retry-unexpected-results) to
2409         automatically re-test them.
2410
2411         https://bugs.webkit.org/show_bug.cgi?id=37783
2412
2413         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2414
2415 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2416
2417         Reviewed by Eric Seidel.
2418
2419         Restructure the logging in new-run-webkit-tests so that many of log
2420         messages that were logged to the MeteredStream also get logged in
2421         --verbose mode.
2422
2423         https://bugs.webkit.org/show_bug.cgi?id=37780
2424
2425         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2426         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2427
2428 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2429
2430         Reviewed by Eric Seidel.
2431
2432         new-run-webkit-tests: add 'summary' and 'unexpected-results' options
2433         to the --log flag. Also add a 'progress' flag to enable the regular
2434         progress bar (as opposed to 'detailed-progress', which enables the
2435         dots). Also add a 'nothing' flag to allow you to be explicit that
2436         you don't want any logging on the command line.
2437
2438         The default is
2439         '--log detailed-progress,summary,unexpected,unexpected-results'
2440
2441         (The default logging is unchanged by this patch, this just makes things
2442         properly configurable).
2443
2444         Note that 'nothing' doesn't work properly yet; I need a couple other
2445         patches to land to avoid rewriting things several different ways.
2446
2447         https://bugs.webkit.org/show_bug.cgi?id=37785
2448
2449         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2450
2451 2010-04-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2452
2453         Reviewed by Simon Hausmann.
2454
2455         Make the URL change on committed load.
2456
2457         * QtLauncher/mainwindow.cpp:
2458         (MainWindow::buildUI):
2459         (MainWindow::setAddressUrl):
2460         * QtLauncher/mainwindow.h:
2461
2462 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2463
2464         Reviewed by Eric Seidel.
2465
2466         Fix a typo in the rebaselining tool that causes us to use "debug"
2467         instead of "Debug" in a directory path, which fails on platforms with
2468         case-sensitive filesystems.
2469
2470         https://bugs.webkit.org/show_bug.cgi?id=37819
2471
2472         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2473
2474 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2475
2476         Unreviewed, build fix.
2477
2478         Fix breakage of chromium-win canary bots caused by r57806. That patch
2479         introduced the option of using Chrome's new port of DumpRenderTree,
2480         but unfortunately that port relies on the webkit.py class
2481         implementation which uses non-blocking I/O that isn't available on
2482         Windows. This patch turns off that option and doesn't import the
2483         class if we're running on Windows.
2484
2485         https://bugs.webkit.org/show_bug.cgi?id=37817
2486
2487         * Scripts/webkitpy/layout_tests/port/chromium.py:
2488
2489 2010-04-19  James Robinson  <jamesr@chromium.org>
2490
2491         Reviewed by abarth.
2492
2493         Fix a typo
2494
2495         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2496
2497 2010-04-19  Adam Roben  <aroben@apple.com>
2498
2499         Fix run-webkit-tests when there are spaces in the path
2500
2501         Fixes <http://webkit.org/b/37809>
2502
2503         Reviewed by Adam Barth.
2504
2505         * Scripts/run-webkit-tests: Use an "indirect object" to specify the
2506         path to the harness to exec(). According to perldoc, this usage will
2507         prohibit perl from parsing the arguments to exec() via the shell,
2508         which would incorrectly split paths with spaces in them, etc.
2509
2510 2010-04-19  Dimitri Glazkov  <dglazkov@chromium.org>
2511
2512         Reviewed by Adam Roben.
2513
2514         WinLauncher.h should use LF line-endings and use native line-endings style.
2515         https://bugs.webkit.org/show_bug.cgi?id=37807
2516
2517         * WinLauncher/WinLauncher.h: Added property svn:eol-style, converted to LF line-endings.
2518
2519 2010-04-19  Kent Tamura  <tkent@chromium.org>
2520
2521         Reviewed by Shinichiro Hamaji.
2522
2523         [DRT/Chromium] Fix a test initialization problem
2524         https://bugs.webkit.org/show_bug.cgi?id=37791
2525
2526         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2527         (runTest): Call resetTestController() before runFileTest(). Some
2528           controllers initialize their fields in reset() and not in their
2529           constructors.
2530
2531 2010-04-19  Kent Tamura  <tkent@chromium.org>
2532
2533         Reviewed by Eric Seidel.
2534
2535         [Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt
2536         https://bugs.webkit.org/show_bug.cgi?id=37793
2537
2538         We need to use WebKitDriver instead of ChromiumDriver for Chromium
2539         DRT because its interface is different from test_shell.
2540
2541         Chromium DRT has no UI.  So we can't use it to show test results.
2542
2543         * Scripts/webkitpy/layout_tests/port/chromium.py:
2544
2545 2010-04-18  Eric Seidel  <eric@webkit.org>
2546
2547         Reviewed by Adam Roben.
2548
2549         Make failure-reason more forgiving
2550         https://bugs.webkit.org/show_bug.cgi?id=37525
2551
2552         Removed search_limit, which wasn't very useful anyway.
2553         Added a log about the long load time loading from the builders.
2554         Prompt the user for what revision to start walking from (makes it easy to restart upon failure).
2555
2556         * Scripts/webkitpy/common/net/buildbot.py:
2557         * Scripts/webkitpy/tool/commands/queries.py:
2558
2559 2010-04-18  Chris Jerdonek  <cjerdonek@webkit.org>
2560
2561         Reviewed by Shinichiro Hamaji.
2562
2563         Created a class for check-webkit-style that encapsulates iterating
2564         over text files and reading them.
2565
2566         https://bugs.webkit.org/show_bug.cgi?id=37754
2567
2568         This revision is an intermediate step towards separating our
2569         style-checking code from the logic of iterating over files and
2570         reading them.
2571
2572         * Scripts/webkitpy/common/system/logtesting.py:
2573           - Added a logMessages() method to the LoggingTestCase class.
2574             This method provides unit tests with access to the raw list
2575             of log messages in case the tester needs to do something more
2576             than simply assert the list of existing messages.
2577
2578         * Scripts/webkitpy/style/checker.py:
2579           - Added a ProcessorBase class that processors of lists of lines
2580             should eventually inherit from.
2581           - Also added a FIXME to use the ProcessorBase class and the
2582             TextFileReader class added below.
2583
2584         * Scripts/webkitpy/style/filereader.py: Added.
2585           - Created a TextFileReader class that encapsulates reading
2586             and iterating over text files.
2587
2588         * Scripts/webkitpy/style/filereader_unittest.py: Added.
2589           - Added a TextFileReaderTest class to unit-test the
2590             new TextFileReader class.
2591
2592 2010-04-15  Tony Chang  <tony@chromium.org>
2593
2594         Reviewed by Adam Barth.
2595
2596         [chromium] new-run-webkit-tests should be able to use chromium DRT
2597         https://bugs.webkit.org/show_bug.cgi?id=37645
2598
2599         Make sure that the lack of a chromium checkout doesn't cause the script to
2600         fail.
2601
2602         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2603         * Scripts/webkitpy/layout_tests/port/chromium.py:
2604         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths
2605             to be relative to an upstream output dir.
2606         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.
2607
2608 2010-04-18  Eric Seidel  <eric@webkit.org>
2609
2610         Unreviewed, fixing the Qt bot.
2611
2612         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
2613         https://bugs.webkit.org/show_bug.cgi?id=37632
2614
2615         * Scripts/run-webkit-tests:
2616          - Exit non-zero of launching the harness fails.
2617
2618 2010-04-18  Eric Seidel  <eric@webkit.org>
2619
2620         Unreviewed, fixing the Qt bot.
2621
2622         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
2623         https://bugs.webkit.org/show_bug.cgi?id=37632
2624
2625         * Scripts/run-webkit-tests:
2626          - Fix the wrapper to work for users who do not
2627            have WebKitTools/Scripts in their path.
2628
2629 2010-04-14  Eric Seidel  <eric@webkit.org>
2630
2631         Reviewed by Adam Barth.
2632
2633         Add a layer of indirection when calling run-webkit-tests to
2634         allow testing new-run-webkit-tests on various platforms.
2635         https://bugs.webkit.org/show_bug.cgi?id=37632
2636
2637         This will let us test and fix bugs in new-run-webkit-tests
2638         without needing to restart the buildbot master between tests.
2639
2640         Currently this change leaves run-webkit-tests as-is, but once
2641         its landed we will easily be able to turn on/off
2642         new-run-webkit-tests for various ports/configurations.
2643
2644         I will send a note out to webkit-dev about how we will
2645         be using this launcher script to test on the bots.
2646
2647         * Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
2648         * Scripts/run-webkit-tests:
2649          - A new script which decides whether to run new- or old-
2650            run-webkit-tests based on the platform.
2651         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2652          - Add some dummy argument handling for arguments which
2653            old-run-webkit-tests supports but new-run-webkit-tests
2654            does not yet.
2655
2656 2010-04-18  Eric Seidel  <eric@webkit.org>
2657
2658         Reviewed by Adam Barth.
2659
2660         Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
2661         https://bugs.webkit.org/show_bug.cgi?id=33295
2662
2663         The Gtk builders have been green every time I've looked
2664         at them in the last 5 days or so.  It would appear webkit
2665         is now keeping them green and we should update the core
2666         builder list to match reality.
2667
2668         * Scripts/webkitpy/common/net/buildbot.py:
2669         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2670
2671 2010-04-18  Robert Hogan  <robert@webkit.org>
2672
2673         Reviewed by Simon Hausmann.
2674
2675         [Qt] Add support for LayoutTestController commands:
2676                    setSmartInsertDeleteEnabled
2677                    setSelectTrailingWhitespaceEnabled
2678                    execCommand
2679                    isCommandEnabled
2680
2681         https://bugs.webkit.org/show_bug.cgi?id=35844
2682
2683         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2684         (WebCore::WebPage::resetSettings):
2685         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2686         (LayoutTestController::setSmartInsertDeleteEnabled):
2687         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
2688         (LayoutTestController::execCommand):
2689         (LayoutTestController::isCommandEnabled):
2690         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2691
2692 2010-04-17  Adam Barth  <abarth@webkit.org>
2693
2694         Reviewed by Eric Seidel.
2695
2696         Remove steps_references and commands_references
2697         https://bugs.webkit.org/show_bug.cgi?id=37758
2698
2699         We tried using the mumble_references convention to manage our
2700         dependencies, but it doesn't seem to be providing much value for the
2701         steps and commands module because these modules are small pieces of the
2702         larger tool module.  In this patch, I've removed the references file
2703         for these modules.
2704
2705         I've left the style_references file for the style module because that
2706         module seems better isolated from the rest of webkitpy and the
2707         style_references file appears to be providing some value.
2708
2709         * Scripts/webkitpy/tool/commands/commandtest.py:
2710         * Scripts/webkitpy/tool/commands/download_unittest.py:
2711         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2712         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2713         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2714         * Scripts/webkitpy/tool/commands/queuestest.py:
2715         * Scripts/webkitpy/tool/commands/upload.py:
2716         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2717         * Scripts/webkitpy/tool/commands_references.py: Removed.
2718         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2719         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2720         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2721         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
2722         * Scripts/webkitpy/tool/steps_references.py: Removed.
2723
2724 2010-04-17  Eric Seidel  <eric@webkit.org>
2725
2726         Reviewed by Adam Barth.
2727
2728         WebKit needs a Chromium Mac EWS Builder
2729         https://bugs.webkit.org/show_bug.cgi?id=37742
2730
2731         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2732
2733 2010-04-17  Adam Barth  <abarth@webkit.org>
2734
2735         Fix expected results for unit test broken by
2736         http://trac.webkit.org/changeset/57772
2737
2738         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2739
2740 2010-04-17  Sam Weinig  <weinig@apple.com>
2741
2742         Reviewed by Adam Roben.
2743
2744         Teach windows MiniBrowser how to work with window.open()
2745         and targeted links.
2746
2747         * MiniBrowser/win/BrowserView.cpp:
2748         (createNewPage): Create a new BrowserWindow and return its page.
2749         (showPage): Show the page.
2750         (closePage): Empty implementation.
2751         (runJavaScriptAlert): Empty implementation.
2752         (BrowserView::create): Register a UIClient.
2753         * MiniBrowser/win/BrowserView.h:
2754         (BrowserView::webView): Added.
2755         Change create to take a BrowserWindow instead of an HWND.
2756
2757         * MiniBrowser/win/BrowserWindow.cpp:
2758         (BrowserWindow::wndProc): Respond to WM_NCDESTROY.
2759         (BrowserWindow::goToURL): Added. Forwards to BrowserView.
2760         (BrowserWindow::onCreate): Don't always go to the default
2761         url. Let the caller do this.
2762         (BrowserWindow::onNCDestroy): Delete the window.
2763         * MiniBrowser/win/BrowserWindow.h:
2764         (BrowserWindow::view): Added.
2765         (BrowserWindow::window): Added.
2766
2767         * MiniBrowser/win/main.cpp:
2768         (_tWinMain):
2769         Go to the default URL for the initial page. Allocate the initial
2770         window on the heap for correctness.
2771
2772 2010-04-16  Adam Roben  <aroben@apple.com>
2773
2774         Add the Windows Debug (Test) builder to the list of core builders
2775
2776         It's been green for a few days now, and all the known Windows
2777         flakiness is Release-only.
2778
2779         Rubber-stamped by Mark Rowe.
2780
2781         * Scripts/webkitpy/common/net/buildbot.py:
2782         (BuildBot.core_builder_name_regexps): Added a regular expression to
2783         match the "Windows Debug (Test)" builder.
2784
2785 2010-04-16  Sam Weinig  <sam@webkit.org>
2786
2787         Reviewed by Anders Carlsson.
2788
2789         Fix window.open() and targeted links.
2790
2791         * MiniBrowser/mac/BrowserWindowController.m:
2792         (_createNewPage): Use the correct initializer to and load the window.
2793
2794 2010-04-16  Adam Roben  <aroben@apple.com>
2795
2796         Fix links to layout test results from build status pages
2797
2798         Reviewed by Mark Rowe.
2799
2800         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2801         (ExtractTestResults.finished): Prepend "/" on the URL of the test
2802         results page so that it is treated as an absolute URL.
2803
2804 2010-04-16  Tony Chang  <tony@chromium.org>
2805
2806         Reviewed by Dimitri Glazkov.
2807
2808         [chromium] build DRT on Linux
2809         https://bugs.webkit.org/show_bug.cgi?id=37690
2810
2811         * Scripts/build-dumprendertree: Add support for win and linux
2812
2813 2010-04-16  Sam Weinig  <weinig@apple.com>
2814
2815         Reviewed by Adam Roben.
2816
2817         Use the threaded process model for MiniBrowser if holding down
2818         the shift key on startup.
2819
2820         * MiniBrowser/win/BrowserView.cpp:
2821         (BrowserView::create):
2822
2823 2010-04-15  Tony Chang  <tony@chromium.org>
2824
2825         Reviewed by Dimitri Glazkov.
2826
2827         [chromium] Add TestShellGtk.cpp so we can link on Linux
2828         https://bugs.webkit.org/show_bug.cgi?id=37561
2829
2830         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add new file and
2831             add platform file exceptions.
2832         * DumpRenderTree/chromium/TestShellGtk.cpp: Added.
2833         (AlarmHandler):
2834         (TestShell::waitTestFinished):
2835
2836 2010-04-15  Tony Chang  <tony@chromium.org>
2837
2838         Reviewed by Dimitri Glazkov.
2839
2840         build DRT on chromium mac
2841         https://bugs.webkit.org/show_bug.cgi?id=37639
2842
2843         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2844         * Scripts/build-dumprendertree: enable build-dumprendertree --chromium
2845
2846 2010-04-15  Kent Tamura  <tkent@chromium.org>
2847
2848         Reviewed by Dimitri Glazkov.
2849
2850         [DRT/Chromium] Add LayoutTestHelper for Mac
2851         https://bugs.webkit.org/show_bug.cgi?id=37668
2852
2853         LayouTestHelper.mm is based on webkit/tools/test_shell/mac/layout_test_helper.mm
2854         of Chromium.
2855
2856         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2857         * DumpRenderTree/chromium/LayoutTestHelper.mm: Added.
2858
2859 2010-04-15  Alexey Proskuryakov  <ap@apple.com>
2860
2861         Reviewed by Geoff Garen.
2862
2863         https://bugs.webkit.org/show_bug.cgi?id=37494
2864         <rdar://problem/7857060> REGRESSION (r57340): fast/events/mouse-drag-from-frame-to-other-frame.html
2865         fails on Windows
2866
2867         * DumpRenderTree/win/EventSender.cpp: (makeEventSender):
2868         * DumpRenderTree/win/EventSender.h:
2869         Tell EventSender if it's being created for a top frame.
2870
2871         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2872         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): We only want to reset
2873         EventSender machinery when a new test is loaded, not when an iframe (or just its global
2874         object) is created.
2875
2876 2010-04-15  Adam Roben  <aroben@apple.com>
2877
2878         Fix Windows WebKit2 build.
2879
2880         * MiniBrowser/win/MiniBrowser.cpp:
2881
2882 2010-04-15  Ojan Vafai  <ojan@chromium.org>
2883
2884         Reviewed by Adam Barth.
2885
2886         Include codereview issue number in patch description
2887         https://bugs.webkit.org/show_bug.cgi?id=37677
2888
2889         This lets us know which rietveld issue this patch is tied to.
2890
2891         Also, make it so that --fancy-review overrides --no-review.
2892
2893         * Scripts/webkitpy/tool/steps/postcodereview.py:
2894         * Scripts/webkitpy/tool/steps/postdiff.py:
2895
2896 2010-04-15  Adam Roben  <aroben@apple.com>
2897
2898         Make --exit-after-n-failures work when all tests are timing out or crashing
2899
2900         Fixes <http://webkit.org/b/37679>.
2901
2902         Reviewed by Jon Honeycutt.
2903
2904         * Scripts/run-webkit-tests:
2905         (top level): When a test crashes or times out, break out of the main loop if
2906         stopRunningTestsEarlyIfNeeded returns true. Moved some code from the bottom of the main loop
2907         from here...
2908         (stopRunningTestsEarlyIfNeeded): ...to here.
2909
2910 2010-04-15  Sam Weinig  <sam@webkit.org>
2911
2912         Reviewed by Anders Carlsson.
2913
2914         Add WebHistoryClient support.
2915         https://bugs.webkit.org/show_bug.cgi?id=37671
2916
2917         Add HistoryClient logging.
2918
2919         * MiniBrowser/mac/BrowserWindowController.m:
2920         (_didNavigateWithNavigationData):
2921         (_didPerformClientRedirect):
2922         (_didPerformServerRedirect):
2923         (_didUpdateHistoryTitle):
2924         (-[BrowserWindowController awakeFromNib]):
2925
2926 2010-04-15  Anders Carlsson  <andersca@apple.com>
2927
2928         Reviewed by Sam Weinig.
2929
2930         Start the mini browser in threaded mode if shift is pressed during startup.
2931         https://bugs.webkit.org/show_bug.cgi?id=37670
2932
2933         * MiniBrowser/mac/AppDelegate.m:
2934         (-[BrowserAppDelegate init]):
2935
2936 2010-04-15  Chris Fleizach  <cfleizach@apple.com>
2937
2938         Reviewed by Beth Dakin.
2939
2940         AXHelp is being appended from ancestors incorrectly
2941         https://bugs.webkit.org/show_bug.cgi?id=37659
2942
2943         * DumpRenderTree/AccessibilityUIElement.cpp:
2944         (getHelpTextCallback):
2945         (AccessibilityUIElement::getJSClass):
2946         * DumpRenderTree/AccessibilityUIElement.h:
2947         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2948         (AccessibilityUIElement::helpText):
2949         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2950         (AccessibilityUIElement::helpText):
2951         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2952         (AccessibilityUIElement::helpText):
2953
2954 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
2955
2956         Reviewed by Adam Barth.
2957
2958         Re-format run-webkit-tests to fit in 80-columns for PEP-8 compliance.
2959         (broken by r57463 and r57381, at least). I've also filed bug 37477
2960         to fix check-webkit-style to catch these things.
2961
2962         https://bugs.webkit.org/show_bug.cgi?id=38586
2963
2964         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2965
2966 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
2967
2968         Reviewed by Dimitri Glazkov.
2969
2970         Add a way to override the user-visible name for the test binary since
2971         some ports don't call it DumpRenderTree (e.g., Chromium Win uses
2972         test_shell, Chromium Mac uses TestShell) by adding a driver_name()
2973         method to the Port interface.
2974
2975         https://bugs.webkit.org/show_bug.cgi?id=37631
2976
2977         * Scripts/webkitpy/layout_tests/port/base.py:
2978         * Scripts/webkitpy/layout_tests/port/chromium.py:
2979         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2980         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2981
2982 2010-04-14  Anders Carlsson  <andersca@apple.com>
2983
2984         Reviewed by Adam Roben.
2985
2986         Add "Force Repaint" to debug menu.
2987         https://bugs.webkit.org/show_bug.cgi?id=37627
2988
2989         * MiniBrowser/mac/BrowserWindowController.h:
2990         * MiniBrowser/mac/BrowserWindowController.m:
2991         (-[BrowserWindowController forceRepaint:]):
2992         * MiniBrowser/mac/English.lproj/MainMenu.xib:
2993
2994 2010-04-15  Sam Weinig  <sam@webkit.org>
2995
2996         Reviewed by Adam Roben.
2997
2998         Add debug-minibrowser script.
2999
3000         * Scripts/debug-minibrowser: Copied from Scripts/run-minibrowser.
3001         * Scripts/webkitdirs.pm:
3002
3003 2010-04-15  Roland Steiner  <rolandsteiner@chromium.org>
3004
3005         Reviewed by Dimitri Glazkov.
3006
3007         Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
3008         https://bugs.webkit.org/show_bug.cgi?id=37636
3009
3010         Second patch: add Windows-specific implementation parts
3011         of TestShell.
3012
3013         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3014         * DumpRenderTree/chromium/TestShell.h:
3015         (TestShell::finishedEvent):
3016         * DumpRenderTree/chromium/TestShellWin.cpp:
3017         (watchDogThread):
3018         (TestShell::waitTestFinished):
3019
3020 2010-04-15  Roland Steiner  <rolandsteiner@chromium.org>
3021
3022         Reviewed by Dimitri Glazkov.
3023
3024         Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
3025         https://bugs.webkit.org/show_bug.cgi?id=37636
3026
3027         First patch: fix compiler errors.
3028
3029         * DumpRenderTree/chromium/EventSender.cpp:
3030         (EventSender::reset):
3031         (EventSender::dispatchMessage):
3032         * DumpRenderTree/chromium/LayoutTestController.cpp:
3033         (LayoutTestController::pathToLocalResource):
3034         * DumpRenderTree/chromium/TestWebWorker.h:
3035         * DumpRenderTree/chromium/TextInputController.cpp:
3036         * DumpRenderTree/chromium/WebViewHost.h:
3037         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3038
3039 2010-04-14  Luiz Agostini  <luiz.agostini@openbossa.org>
3040
3041         Reviewed by Simon Hausmann.
3042
3043         [Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
3044         https://bugs.webkit.org/show_bug.cgi?id=37622
3045
3046         Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
3047         (bug 35844). Moving it back.
3048
3049         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3050         (LayoutTestController::setViewModeMediaFeature):
3051
3052 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
3053
3054         Reviewed by Adam Barth.
3055
3056         Add some very minimal unit tests for new-run-webkit-tests. This should
3057         be enough to catch egregious brokenness like syntax errors and import
3058         declaration issues.
3059
3060         https://bugs.webkit.org/show_bug.cgi?id=37432
3061
3062         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3063         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Added.
3064
3065 2010-04-14  Brian Weinstein  <bweinstein@apple.com>
3066
3067         Reviewed by Adam Roben.
3068
3069         Add a way for the buildbot to kill any old processes that are running. This
3070         is useful because the Windows bots can get in states where a process remains
3071         running (httpd.exe, DumpRenderTree.exe), which causes the bots to get in a red
3072         state, and the processes must be killed manually.
3073
3074         * BuildSlaveSupport/build.webkit.org-config/master.cfg: If we are on Windows, kill
3075             the old processes that might be running.
3076         * BuildSlaveSupport/win/kill-old-processes: Added.
3077
3078 2010-04-14  Sam Weinig  <sam@webkit.org>
3079
3080         Reviewed by Anders Carlsson.
3081
3082         Tear down WebKit more completely on window closing and application
3083         termination. We still don't block application termination for pending
3084         close, but this is a step in the right direction.
3085
3086         * MiniBrowser/mac/AppDelegate.m:
3087         (-[BrowserAppDelegate applicationWillTerminate:]):
3088         * MiniBrowser/mac/BrowserWindowController.h:
3089         * MiniBrowser/mac/BrowserWindowController.m:
3090         (-[BrowserWindowController dealloc]):
3091         (-[BrowserWindowController windowWillClose:]):
3092         (-[BrowserWindowController applicationTerminating]):
3093
3094 2010-04-14  Adam Barth  <abarth@webkit.org>
3095
3096         Reviewed by Eric Seidel.
3097
3098         Use pretty patch for confirming webkit-patch diffs
3099         https://bugs.webkit.org/show_bug.cgi?id=37489
3100
3101         * Scripts/webkitpy/common/prettypatch.py: Added.
3102         * Scripts/webkitpy/tool/commands/download_unittest.py:
3103         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3104         * Scripts/webkitpy/tool/mocktool.py:
3105         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3106
3107 2010-04-14  Eric Seidel  <eric@webkit.org>
3108
3109         Reviewed by Adam Barth.
3110
3111         Teach webkit-patch how to handle revisions missing ChangeLogs
3112         https://bugs.webkit.org/show_bug.cgi?id=37519
3113
3114         Make commit_info_for_revision return None when revision
3115         is missing a ChangeLog.  Previously we would throw an array index
3116         exception.
3117         Teach callers how to handle None.
3118
3119         * Scripts/webkitpy/common/checkout/api.py:
3120         * Scripts/webkitpy/common/checkout/api_unittest.py:
3121         * Scripts/webkitpy/tool/commands/download.py:
3122         * Scripts/webkitpy/tool/commands/queries.py:
3123         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3124
3125 2010-04-13  Eric Seidel  <eric@webkit.org>
3126
3127         Reviewed by Adam Roben.
3128
3129         Add Qt Bot to the list of "core builders" (builders which block the commit-queue when red)
3130         https://bugs.webkit.org/show_bug.cgi?id=33297
3131
3132         This is an experiment.  The bots have been green for
3133         a while.  We'll see if adding them under sheriff-bot protection
3134         will keep them green.
3135
3136         * Scripts/webkitpy/common/net/buildbot.py:
3137         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3138
3139 2010-04-13  Eric Seidel  <eric@webkit.org>
3140
3141         Unreviewed, just fixing a constant in the Rietveld unit test.
3142
3143         * Scripts/webkitpy/common/net/rietveld_unittest.py
3144
3145 2010-04-13  Eric Seidel  <eric@webkit.org>
3146
3147         Unreviewed, just adding missing Mock to fix python tests.
3148
3149         * Scripts/webkitpy/tool/mocktool.py:
3150
3151 2010-04-13  Ojan Vafai  <ojan@chromium.org>
3152
3153         Reviewed by David Levin.
3154
3155         Add experimental prototype Rietveld integration to webkit-patch upload
3156         https://bugs.webkit.org/show_bug.cgi?id=37418
3157
3158         This patch adds bare-bones integration with Rietveld for code reviews.
3159         The behavior is hidden behind the --fancy-review command line flag.
3160         Currently, there's no support for uploading more than one patch per
3161         issue (which is a nice feature of Rietveld).  The plan is to play with
3162         this for a bit and see if it's useful.
3163
3164         Modified from Adam's original patch to autoinstall the rietveld upload script.
3165
3166         * Scripts/webkitpy/common/config/__init__.py:
3167         * Scripts/webkitpy/common/net/rietveld.py: Added.
3168         * Scripts/webkitpy/common/net/rietveld_unitttest.py: Added.
3169         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3170         * Scripts/webkitpy/tool/commands/upload.py:
3171         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3172         * Scripts/webkitpy/tool/main.py:
3173         * Scripts/webkitpy/tool/mocktool.py:
3174         * Scripts/webkitpy/tool/steps/__init__.py:
3175         * Scripts/webkitpy/tool/steps/options.py:
3176         * Scripts/webkitpy/tool/steps/postcodereview.py: Added.
3177         * Scripts/webkitpy/tool/steps/postdiff.py:
3178
3179 2010-04-13  Sam Weinig  <sam@webkit.org>
3180
3181         Rubber-stamped by Mark Rowe.
3182
3183         Add Makefile to MiniBrowser.
3184
3185         * MiniBrowser/Makefile: Added.
3186
3187 2010-04-13  Eric Seidel  <eric@webkit.org>
3188
3189         Unreviewed, just adding a sanity check.
3190
3191         Add check to make sure commit-queue can never commit too short a message
3192         https://bugs.webkit.org/show_bug.cgi?id=37528
3193
3194         The commit-queue made bogus messages here:
3195         http://trac.webkit.org/changeset/57532
3196         http://trac.webkit.org/changeset/57534
3197
3198         This was a regression caused by adding unicode parsing for
3199         our ChangeLog files.  Popen does not seem to play nice with
3200         unicode strings.
3201
3202         I'm also adding an "assert" to make sure short ChangeLogs never happen again.
3203
3204         * Scripts/webkitpy/common/system/executive.py:
3205          - Cast input to strings before passing to POpen
3206         * Scripts/webkitpy/tool/steps/commit.py:
3207          - Validate that commit messages are not to short.
3208
3209 2010-04-13  Adam Roben  <aroben@apple.com>
3210
3211         Robustify new-run-webkit-tests against paths with spaces in them
3212
3213         Reviewed by Eric Seidel.
3214
3215         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3216         (LayoutTestApacheHttpd.__init__): Quote all paths that we pass to
3217         Apache to ensure that paths with spaces in them are interpreted
3218         correctly.
3219
3220 2010-04-13  Csaba Osztrogonác  <ossy@webkit.org>
3221
3222         Unreviewed buildfix after r57537.
3223
3224         * DumpRenderTree/qt/LayoutTestControllerQt.h: Declaration of removeOriginAccessWhitelistEntry() added.
3225
3226 2010-04-13  Sam Weinig  <sam@webkit.org>
3227
3228         Reviewed by Maciej Stachowiak.
3229
3230         Make building new webkit API and MiniBrowser a little easier.
3231
3232         * Scripts/build-webkit: Make building with --webkit2 build the
3233         MiniBrowser as well and tell you how to use it.
3234         * Scripts/run-minibrowser: Copied from Scripts/run-safari.
3235         * Scripts/webkitdirs.pm: Add runMiniBrowser function.
3236
3237 2010-04-12  Timothy Hatcher  <timothy@apple.com>
3238
3239         SecurityOrigin needs a way to remove individual OriginAccessEntries
3240         https://bugs.webkit.org/show_bug.cgi?id=37449
3241
3242         Reviewed by Dave Hyatt.
3243
3244         * DumpRenderTree/LayoutTestController.cpp:
3245         (removeOriginAccessWhitelistEntryCallback): Added. Call LayoutTestController::removeOriginAccessWhitelistEntry.
3246         (LayoutTestController::staticFunctions): Added removeOriginAccessWhitelistEntry.
3247         * DumpRenderTree/LayoutTestController.h:
3248         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3249         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3250         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3251         (LayoutTestController::removeOriginAccessWhitelistEntry): Added.
3252         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3253         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3254         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3255         (LayoutTestController::removeOriginAccessWhitelistEntry): Added.
3256         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3257         (LayoutTestController::whiteListAccessFromOrigin): FIXME to implement.
3258         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3259
3260 2010-04-13  Timothy Hatcher  <timothy@apple.com>
3261
3262         Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
3263         And LayoutTestController.whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
3264         And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
3265
3266         SecurityOrigin needs a way to remove individual OriginAccessEntries
3267         https://bugs.webkit.org/show_bug.cgi?id=37449
3268
3269         Reviewed by Dave Hyatt.
3270
3271         * DumpRenderTree/LayoutTestController.cpp:
3272         (addOriginAccessWhitelistEntryCallback):
3273         (LayoutTestController::staticFunctions):
3274         * DumpRenderTree/LayoutTestController.h:
3275         * DumpRenderTree/chromium/LayoutTestController.cpp:
3276         (LayoutTestController::LayoutTestController):
3277         (LayoutTestController::addOriginAccessWhitelistEntry):
3278         * DumpRenderTree/chromium/LayoutTestController.h:
3279         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3280         (LayoutTestController::addOriginAccessWhitelistEntry):
3281         * DumpRenderTree/mac/DumpRenderTree.mm:
3282         (resetWebViewToConsistentStateBeforeTesting):
3283         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3284         (LayoutTestController::addOriginAccessWhitelistEntry):
3285         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3286         (LayoutTestController::addOriginAccessWhitelistEntry):
3287         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3288         * DumpRenderTree/win/DumpRenderTree.cpp:
3289         (resetWebViewToConsistentStateBeforeTesting):
3290         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3291         (LayoutTestController::addOriginAccessWhitelistEntry):
3292         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3293         (LayoutTestController::addOriginAccessWhitelistEntry):
3294
3295 2010-04-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3296
3297         Reviewed by Eric Seidel.
3298
3299         Remove duplicate function for new-run-webkit-tests
3300         https://bugs.webkit.org/show_bug.cgi?id=37517
3301
3302         The version() function was already implemented.
3303
3304         * Scripts/webkitpy/layout_tests/port/webkit.py:
3305
3306 2010-04-13  Eric Seidel  <eric@webkit.org>
3307
3308         Reviewed by David Levin.
3309
3310         the commit-queue hates Tor Arne Vestbø
3311         https://bugs.webkit.org/show_bug.cgi?id=37511
3312
3313         We were failing to read reviewers out of ChangeLogs
3314         when the reviewer has unicode characters in his/her name.
3315         I fixed this by explicitly decoding from utf8 every time we
3316         read in a ChangeLog file (they are always UTF8).
3317
3318         * Scripts/webkitpy/common/checkout/changelog.py:
3319         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3320
3321 2010-04-13  Adam Roben  <aroben@apple.com>
3322
3323         Fix run-webkit-tests on Windows with spaces in the path
3324
3325         Fixes <http://webkit.org/b/37509>.
3326
3327         Reviewed by Steve Falkenburg.
3328
3329         * Scripts/run-webkit-tests:
3330         (convertPathUsingCygpath): Remove spaces from the path before passing
3331         them to cygpath, then add them back in after conversion, as some
3332         versions of cygpath seem to convert spaces into newlines.
3333
3334 2010-04-13  Adam Barth  <abarth@webkit.org>
3335
3336         Unreviewed, but approved by Dumitru Daniliuc.  (This patch is intended
3337         to fix the downstream Chromium build bots.  Hopefully it will work!)
3338
3339         Add a driver script for the new websocket server
3340         https://bugs.webkit.org/show_bug.cgi?id=37495
3341
3342         websocket_server.py can't be run directly because its a module and not
3343         a standalone script.  This used to work by accident because it didn't
3344         depend on any other modules.
3345
3346         * Scripts/new-run-webkit-websocketserver: Added.
3347         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3348
3349 2010-04-12  Eric Seidel  <eric@webkit.org>
3350
3351         Reviewed by Adam Barth.
3352
3353         Make new-run-webkit-test PrettyPatch failure reporting more awesome
3354         https://bugs.webkit.org/show_bug.cgi?id=37487
3355
3356         I also fixed an Executive/executive typo.
3357
3358         * Scripts/webkitpy/layout_tests/port/base.py:
3359
3360 2010-04-12  Eric Seidel  <eric@webkit.org>
3361
3362         Reviewed by Adam Barth.
3363
3364         new-run-webkit-tests should only build java support files on Mac
3365         https://bugs.webkit.org/show_bug.cgi?id=37482
3366
3367         Only the mac needs java support files, so I pushed _build_java
3368         down into the Mac port using a new hook "_check_port_build".
3369         In the process I noticed a bunch of code which could be shared
3370         between all ports and thus got rid of _tests_for_disabled_features
3371         and version() copy/paste between all webkit ports.
3372         I also made check_build only bother to check for ImageDiff if we're
3373         using pixel tests.
3374
3375         * Scripts/webkitpy/layout_tests/port/gtk.py:
3376         * Scripts/webkitpy/layout_tests/port/mac.py:
3377         * Scripts/webkitpy/layout_tests/port/qt.py:
3378         * Scripts/webkitpy/layout_tests/port/webkit.py:
3379         * Scripts/webkitpy/layout_tests/port/win.py:
3380
3381 2010-04-12  Dumitru Daniliuc  <dumi@chromium.org>
3382
3383         Unreviewed, trying to make scripts work on machines without
3384         Ruby...
3385
3386         * Scripts/webkitpy/layout_tests/port/base.py:
3387
3388 2010-04-12  Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3389
3390         Reviewed by Eric Seidel.
3391
3392         Add stub files for running new-run-webkit-tests for the Qt port
3393
3394         * Scripts/webkitpy/layout_tests/port/factory.py:
3395         * Scripts/webkitpy/layout_tests/port/qt.py: Added.
3396
3397 2010-04-12  Dirk Pranke  <dpranke@chromium.org>
3398
3399         Reviewed by Eric Seidel.
3400
3401         Modify run_webkit_tests.py to not call sys.exit() at the end of test
3402         run; doing so makes it more difficult to embed the routine for,
3403         among other things, unit tests. We push the exit calling up into
3404         new-run-webkit-tests.
3405
3406         https://bugs.webkit.org/show_bug.cgi?id=37464
3407
3408         * Scripts/new-run-webkit-tests:
3409         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3410
3411 2010-04-12  Eric Seidel  <eric@webkit.org>
3412
3413         Unreviewed.
3414
3415         Add stub Gtk implementation for new-run-webkit-tests.
3416
3417         * Scripts/webkitpy/layout_tests/port/factory.py:
3418         * Scripts/webkitpy/layout_tests/port/gtk.py: Added.
3419
3420 2010-04-12  Eric Seidel  <eric@webkit.org>
3421
3422         Reviewed by Adam Barth.
3423
3424         new-run-webkit-tests fails with exception on systems missing ruby
3425         https://bugs.webkit.org/show_bug.cgi?id=37441
3426
3427         * Scripts/webkitpy/layout_tests/port/base.py:
3428          - Catch failures similar to how wdiff code path does.
3429          - After one failure, stop trying.
3430
3431 2010-04-12  Tony Chang  <tony@chromium.org>
3432
3433         Reviewed by Eric Seidel.
3434
3435         Fix how we import simplejson based on how it's used in this file.
3436         This fixes exceptions raised when trying to write the simplejson output.
3437
3438         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3439
3440 2010-04-11  Chris Jerdonek  <cjerdonek@webkit.org>
3441
3442         Reviewed by Shinichiro Hamaji.
3443
3444         Refactored check-webkit-style so that the StyleChecker class
3445         has no dependencies on patch-related concepts.
3446
3447         https://bugs.webkit.org/show_bug.cgi?id=37065
3448
3449         This patch is an intermediate step towards making the StyleChecker
3450         class a generalized file processor that can do arbitary operations
3451         on the files corresponding to a list of paths.  This patch
3452         also simplifies the unit-testing of patch-checking code.
3453
3454         * Scripts/check-webkit-style:
3455           - Updated to use the new PatchChecker class.
3456
3457         * Scripts/webkitpy/style/checker.py:
3458           - Refactored the StyleChecker.check_patch() method into the
3459             check() method of a new PatchChecker class.
3460
3461         * Scripts/webkitpy/style/checker_unittest.py:
3462           - Refactored the unit tests as necessary, changing the
3463             StyleCheckerCheckPatchTest class to a PatchCheckerTest class.
3464
3465 2010-04-11  Adam Barth  <abarth@webkit.org>
3466
3467         Unreviewed.
3468
3469         Fix new-run-webkit-tests regressions cased by Eric's option parsing patch
3470         https://bugs.webkit.org/show_bug.cgi?id=37430
3471
3472         We need some basic unit testing of this script, or we're going to keep
3473         breaking it like this.  Added missing namespace qualifiers and
3474         propagated renaming of an option.
3475
3476         * Scripts/webkitpy/common/config/ports.py:
3477         * Scripts/webkitpy/layout_tests/driver_test.py:
3478         * Scripts/webkitpy/layout_tests/port/base.py:
3479         * Scripts/webkitpy/layout_tests/port/mac.py:
3480         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3481
3482 2010-04-11  Eric Seidel  <eric@webkit.org>
3483
3484         Reviewed by Adam Barth.
3485
3486         Break new-run-webkit-tests options into groups for easier re-use and possible relocation
3487         https://bugs.webkit.org/show_bug.cgi?id=37408
3488
3489         new-run-webkit-tests currently has one huge function for
3490         dealing with all options-parsing.
3491         This patch is a first attempt at trying to split that large
3492         function down into smaller (hopefully more readable?) chunks
3493         dealing with the different areas of options.
3494         For example, it would make sense to move configuration
3495         options off into some module which deals with the vagries of
3496         WebKit's configuration system.  It would also make sense to move
3497         Chromium options off onto the Chromium port object (where they are used).
3498         It may make sense to move results.json options over to the results.json code.
3499         This change is a first iteration, and we will certainly need more
3500         refinement to this code over time.  Hopefully I didn't make things
3501         harder to read here.
3502
3503         * Scripts/webkitpy/layout_tests/driver_test.py:
3504         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3505
3506 2010-04-11  Adam Barth  <abarth@webkit.org>
3507
3508         Reviewed by Eric Seidel.
3509
3510         create-rollout copy needs to be updated to reflect removal of --no-build
3511         https://bugs.webkit.org/show_bug.cgi?id=37425
3512
3513         Removed --no-build and --no-test from the instructions because these
3514         don't exist anymore.
3515
3516         * Scripts/webkitpy/tool/commands/download_unittest.py:
3517             - Updated the expected results to reflect the new copy.
3518         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
3519
3520 2010-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3521
3522         Unreviewed, rolling out r57460.
3523         http://trac.webkit.org/changeset/57460
3524         https://bugs.webkit.org/show_bug.cgi?id=37424
3525
3526         broke chromium builders (Requested by tony^work on #webkit).
3527
3528         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3529
3530 2010-04-11  Tony Chang  <tony@chromium.org>
3531
3532         Reviewed by Darin Fisher.
3533
3534         [chromium] update chromium DEPS for upstream compile
3535         https://bugs.webkit.org/show_bug.cgi?id=36578
3536
3537         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Small fix to avoid a circular dependency between
3538           WebKit.gyp and webkit.gyp.