WebKitTools/ChangeLog

   1 2007-12-11  Dan Bernstein  <mitz@apple.com>
   2
   3         Reviewed by Mark Rowe and Sam Weinig too!
   4
   5         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
   6           fonts DumpRenderTree registers.
   7
   8         * DumpRenderTree/win/DumpRenderTree.cpp:
   9         (initialize):
  10
  11 2007-12-11  Brady Eidson  <beidson@apple.com>
  12
  13         Reviewed by Anders
  14
  15         Make DumpRenderTree on mac use its own path for Databases testing
  16
  17         * DumpRenderTree/mac/DumpRenderTree.mm:
  18         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree
  19           for future DRT-only use, then use it to construct the Databases path and set that default
  20
  21 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
  22
  23         Reviewed by Darin.
  24
  25         <rdar://problem/5535636>
  26         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
  27
  28         http://bugs.webkit.org/show_bug.cgi?id=13916
  29         JavaScript detects Tab as a character input on a textfield validation
  30
  31         * DumpRenderTree/mac/EventSendingController.mm:
  32         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
  33         Dispatch a keyup to better match what happens when a key is physically pressed.
  34
  35         * DumpRenderTree/win/EventSender.cpp:
  36         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
  37         returning from keyDown().
  38         (getConstantCallback): Fixed a couple copy/paste mistakes.
  39
  40 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
  41
  42         Reviewed by Oliver.
  43
  44         - <rdar://5599845> Drosera: Does not show loal files in the file list
  45         on the left side.
  46
  47         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
  48         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
  49         so the open source community can build.
  50
  51 2007-12-10  Brady Eidson  <beidson@apple.com>
  52
  53         Rubberstamped by Sam Weinig
  54
  55         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
  56
  57         * DumpRenderTree/mac/UIDelegate.mm:
  58         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
  59         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
  60
  61 2007-12-08  Oliver Hunt  <oliver@apple.com>
  62
  63         Reviewed by Sam W.
  64
  65         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
  66
  67         Fixes <rdar://problem/5620249> Must disable SVG animation
  68         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
  69
  70         In order to allow finer grained control over the set of SVG features
  71         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
  72         distinct flags:
  73         ENABLE_SVG_ANIMATION
  74         ENABLE_SVG_FILTERS
  75         ENABLE_SVG_FONTS
  76         ENABLE_SVG_AS_IMAGE
  77         ENABLE_SVG_USE
  78
  79         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
  80
  81         Script handles all the new build flags, and allows --svg-experimental
  82         to automatically enable all features.
  83
  84         * Scripts/build-webkit:
  85
  86 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
  87
  88         Fix version parsing.
  89
  90         Rubber-stamped by Oliver.
  91
  92         * Drosera/win/Drosera.vcproj/auto-version.sh:
  93
  94 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
  95
  96         Build modifications for Drosera.
  97
  98         Reviewed by Adam.
  99
 100         * Drosera/DroseraWin.make: Added.
 101         * Drosera/win/Drosera.vcproj/Drosera.rc:
 102         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 103         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
 104         * Drosera/win/Drosera.vcproj/VERSION: Added.
 105         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
 106
 107 2007-12-06  Adam Roben  <aroben@apple.com>
 108
 109         Explicitly turn on the Mac font ascent hack on Windows
 110
 111         This keeps our font metrics matching those from Mac.
 112
 113         Reviewed by Hyatt.
 114
 115         * DumpRenderTree/win/DumpRenderTree.cpp:
 116         (main):
 117
 118 2007-12-06  Anders Carlsson  <andersca@apple.com>
 119
 120         Rename main.c to main.cpp here too.
 121
 122         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
 123
 124 2007-12-06  Sam Weinig  <sam@webkit.org>
 125
 126         Rubber stamped by Geoff.
 127
 128         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
 129
 130 2007-12-06  Darin Adler  <darin@apple.com>
 131
 132         * Scripts/do-webcore-rename: Some more renaming plans.
 133
 134 2007-12-06  Anders Carlsson  <andersca@apple.com>
 135
 136         Restore implementation of testGetIntIdentifier that was accidentally
 137         removed somehow (possibly when I made PluginObject be a cpp file).
 138
 139         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 140         (pluginInvoke):
 141
 142 2007-12-05  Anders Carlsson  <andersca@apple.com>
 143
 144         Make the entry points extern "C".
 145         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
 146
 147 2007-12-05  Anders Carlsson  <andersca@apple.com>
 148
 149         C++ warning fixes.
 150
 151         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
 152         (NPP_New):
 153         (NPP_Destroy):
 154         (NPP_SetWindow):
 155         (NPP_NewStream):
 156         (NPP_HandleEvent):
 157         (NPP_URLNotify):
 158         (NPP_GetValue):
 159
 160 2007-12-05  Anders Carlsson  <andersca@apple.com>
 161
 162         Add the .cpp files to the TestNetscapePlugIn target.
 163
 164         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 165
 166 2007-12-05  Anders Carlsson  <andersca@apple.com>
 167
 168         Reviewed by Geoff.
 169
 170         Rename the TestNetscapePlugIn .c files to be .cpp.
 171
 172         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 173         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
 174         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
 175         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
 176         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
 177         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
 178         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
 179         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
 180
 181 2007-12-05  Adam Roben  <aroben@apple.com>
 182
 183         Fix case of keypresses from the Windows implementation of eventSender.keyDown
 184
 185         This fixes several regression tests.
 186
 187         Reviewed by Alice.
 188
 189         * DumpRenderTree/win/EventSender.cpp:
 190         (keyDownCallback): Virtual keycodes for ASCII characters are always
 191         uppercase, so we need to check the case of the original character
 192         passed in to eventSender.keyDown.
 193
 194 2007-12-05  Adam Roben  <aroben@apple.com>
 195
 196         Learn from Tim's mistakes
 197
 198         * DumpRenderTree/win/DumpRenderTree.cpp:
 199         (runTest): Reset the authorAndUserStylesEnabled preference for each
 200         test.
 201
 202 2007-12-05  Alp Toker  <alp@atoker.com>
 203
 204         Reviewed by Mark Rowe.
 205
 206         Initialize GTK+ and WebKit so the tests can run.
 207
 208         Reorganize the headers a little.
 209
 210         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 211         (main):
 212
 213 2007-12-04  Anders Carlsson  <andersca@apple.com>
 214
 215         Remove IWebScriptScope include.
 216
 217         * Drosera/win/DebuggerDocumentPlatform.cpp:
 218
 219 2007-12-04  Sam Weinig  <sam@webkit.org>
 220
 221         Rubber stamped by Mark Rowe.
 222
 223         Define CF as platform for mac and revert r28409
 224
 225         * DumpRenderTree/DumpRenderTree.h:
 226         * DumpRenderTree/mac/DumpRenderTreeMac.h:
 227
 228 2007-12-04  Sam Weinig  <sam@webkit.org>
 229
 230         Define CF as platform for windows.
 231
 232         Reviewed by Adam Roben.
 233
 234         * DumpRenderTree/win/DumpRenderTreeWin.h:
 235
 236 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
 237
 238         Reviewed by Adam and Darin.
 239
 240         - Removed a needless BSTR cleanup.
 241
 242         * Drosera/win/DebuggerDocumentPlatform.cpp:
 243         (DebuggerDocument::getPlatformCurrentFunctionStack):
 244
 245 2007-11-27  Adam Roben  <aroben@apple.com>
 246
 247         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
 248
 249         Reviewed by Maciej.
 250
 251         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 252         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
 253
 254 2007-12-04  Alp Toker  <alp@atoker.com>
 255
 256         Prospective Win DRT build fix.
 257
 258         * DumpRenderTree/DumpRenderTree.h:
 259
 260 2007-12-04  Alp Toker  <alp@atoker.com>
 261
 262         Fix a clobbered copyright header.
 263
 264         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 265
 266 2007-12-04  Xan Lopez  <xan@gnome.org>
 267
 268         Reviewed by Alp Toker.
 269
 270         http://bugs.webkit.org/show_bug.cgi?id=15561
 271         GTK port needs DumpRenderTree implementation
 272
 273         Start work on the GTK+ DRT.
 274
 275         This does not work yet, and there are a few lingering style issues
 276         (nothing major) but this patch has been stuck in the bug tracker for
 277         too long already.
 278
 279         * DumpRenderTree/DumpRenderTree.h:
 280         * DumpRenderTree/gtk: Added.
 281         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
 282         (autocorrectURL):
 283         (shouldLogFrameLoadDelegates):
 284         (dumpFrameScrollPosition):
 285         (displayWebView):
 286         (appendString):
 287         (dumpFramesAsText):
 288         (dumpRenderTreeAsText):
 289         (dump):
 290         (runTest):
 291         (main):
 292         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
 293         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
 294         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
 295         (GCController::collect):
 296         (GCController::collectOnAlternateThread):
 297         (GCController::getJSObjectCount):
 298         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
 299         (LayoutTestController::~LayoutTestController):
 300         (LayoutTestController::addDisallowedURL):
 301         (LayoutTestController::clearBackForwardList):
 302         (LayoutTestController::copyDecodedHostName):
 303         (LayoutTestController::copyEncodedHostName):
 304         (LayoutTestController::display):
 305         (LayoutTestController::keepWebHistory):
 306         (LayoutTestController::notifyDone):
 307         (LayoutTestController::queueBackNavigation):
 308         (LayoutTestController::queueForwardNavigation):
 309         (LayoutTestController::queueLoad):
 310         (LayoutTestController::queueReload):
 311         (LayoutTestController::queueScript):
 312         (LayoutTestController::setAcceptsEditing):
 313         (LayoutTestController::setCustomPolicyDelegate):
 314         (LayoutTestController::setMainFrameIsFirstResponder):
 315         (LayoutTestController::setTabKeyCyclesThroughElements):
 316         (LayoutTestController::setUseDashboardCompatibilityMode):
 317         (LayoutTestController::setUserStyleSheetEnabled):
 318         (LayoutTestController::setUserStyleSheetLocation):
 319         (LayoutTestController::setWindowIsKey):
 320         (LayoutTestController::setWaitToDump):
 321         (LayoutTestController::windowCount):
 322         (LayoutTestController::setPrivateBrowsingEnabled):
 323         (LayoutTestController::setAuthorAndUserStylesEnabled):
 324         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
 325         (JSStringCopyUTF8CString):
 326         (LoadItem::invoke):
 327         (ReloadItem::invoke):
 328         (ScriptItem::invoke):
 329         (BackForwardItem::invoke):
 330
 331 2007-12-03  Sam Weinig  <sam@webkit.org>
 332
 333         Move JavaScriptCore thread testing code to pthread specific directory
 334         and remove the dependance on CoreFoundation by using WTF::HashSet.
 335
 336         Reviewed by Geoff and Oliver.
 337
 338         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 339         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
 340         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
 341         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
 342         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
 343         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
 344         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
 345         * DumpRenderTree/pthreads: Added.
 346         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
 347         (javaScriptThreads):
 348         (runJavaScriptThread):
 349         (startJavaScriptThreads):
 350         (stopJavaScriptThreads):
 351
 352 2007-12-03  Andrew Bonventre  <andybons@google.com>
 353
 354         Reviewed by Darin Adler.
 355
 356         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
 357         Symbol lookup menu broken in debugger view
 358
 359         * Drosera/debugger.js: Fixed javascript error where document property
 360         should have been used instead of contentDocument in switchFunction that
 361         was breaking the select symbol dropdown menu.  This is because
 362         window.frames will return a Window object and not a frame object like
 363         the author was originally expecting.
 364
 365 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
 366
 367         Reviewed by Adam.
 368
 369         - <rdar://5618942> Drosera: Console window does not process everything
 370         correctly.
 371         - <rdar://5619005> Drosera: could be sped up by moving the
 372         WebScriptScope stuff into the WebScriptCallFrame.
 373         - Now the console can correctly process objects and does not receive
 374         notifications from JavaScriptCore about the JavaScript in Drosera's
 375         own process.
 376
 377         * Drosera/win/DebuggerDocumentPlatform.cpp:
 378         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 379         (DebuggerDocument::platformValueForScopeVariableNamed):
 380
 381 2007-12-03  Stephanie  <slewis@apple.com>
 382
 383         Reviewed by Darin.
 384
 385         Check to see if we are building a debug root
 386
 387         * Scripts/check-for-global-initializers:
 388
 389 2007-12-03  Dan Bernstein  <mitz@apple.com>
 390
 391         Reviewed by Darin Adler.
 392
 393         - added a testGetIntIdentifier() method to TestNetscapePlugIn
 394
 395         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
 396         (pluginInvoke):
 397
 398 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
 399
 400         Reviewed by Oliver.
 401
 402         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
 403         in a more fine-grained manner than eventSender.keyDown().
 404
 405         * DumpRenderTree/win/EventSender.cpp:
 406         (getConstantCallback):
 407         (dispatchMessageCallback):
 408
 409 2007-12-02  Darin Adler  <darin@apple.com>
 410
 411         * Scripts/do-webcore-rename: More planned renaming.
 412
 413 2007-12-02  Sam Weinig  <sam@webkit.org>
 414
 415         Rubber stamped by Anders.
 416
 417         Use [NSURL absoluteString] instead of [NSURL description] in order to get
 418         more uniform results cross platform.
 419
 420         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 421         (-[NSURL _drt_descriptionSuitableForTestResult]):
 422
 423 2007-12-02  Sam Weinig  <sam@webkit.org>
 424
 425         Rubber stamped by Niko.
 426
 427         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
 428
 429         * DumpRenderTree/win/DumpRenderTree.cpp:
 430         * DumpRenderTree/win/DumpRenderTree.vcproj:
 431         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
 432         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
 433         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
 434         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
 435
 436 2007-12-01  Alp Toker  <alp@atoker.com>
 437
 438         Reviewed by Adam Roben.
 439
 440         Make use of the newly introduced webkit.h convenience header.
 441
 442         * GtkLauncher/main.c:
 443
 444 2007-12-01  Adam Treat  <treat@kde.org>
 445
 446         Reviewed by Simon.
 447
 448         * Check to see if the directory exists and exit if not.
 449
 450         * DumpRenderTree/qt/main.cpp:
 451         (main):
 452
 453 2007-12-01  Adam Treat  <treat@kde.org>
 454
 455         Reviewed by Simon.
 456
 457         * Don't hide symbols when in Debug mode
 458         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
 459
 460
 461         * DumpRenderTree/qt/main.cpp:
 462         (messageHandler):
 463
 464 2007-11-30  Alp Toker  <alp@atoker.com>
 465
 466         Reviewed by Adam Roben.
 467
 468         http://bugs.webkit.org/show_bug.cgi?id=15691
 469         [GTK] Public API does not follow GTK+ conventions
 470
 471         Refactor the WebKit/GTK+ public API. Changes:
 472           WebKitPage -> WebKitWebView
 473           WebKitFrame -> WebKitWebFrame
 474
 475         Public API source and header names have been updated to mirror the API
 476         changes.
 477
 478         The API is now kept in WebKit/gtk/WebView to match other ports in the
 479         same class such as Mac and Win.
 480
 481         * GtkLauncher/main.c:
 482         (activate_uri_entry_cb):
 483         (link_hover_cb):
 484         (title_change_cb):
 485         (progress_change_cb):
 486         (go_back_cb):
 487         (go_forward_cb):
 488         (create_browser):
 489         (main):
 490
 491 2007-11-30  Adam Roben  <aroben@apple.com>
 492
 493         Hopefully the final build fix
 494
 495         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
 496         pull in WTF's assertion/logging functions.
 497
 498 2007-11-30  Adam Roben  <aroben@apple.com>
 499
 500         Another build fix
 501
 502         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
 503         WebKit.lib.
 504
 505 2007-11-30  Adam Roben  <aroben@apple.com>
 506
 507         Debug build fix
 508
 509         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
 510         configuration.
 511         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
 512         projects.
 513         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
 514         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
 515         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
 516
 517 2007-11-30  Sam Weinig  <sam@webkit.org>
 518
 519         Reviewed by Adam Roben.
 520
 521         Fix drawSelectionRect to actually draw the selection rect.
 522
 523         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 524         (drawSelectionRect):
 525
 526 2007-11-30  Darin Adler  <darin@apple.com>
 527
 528         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
 529
 530 2007-11-30  Darin Adler  <darin@apple.com>
 531
 532         * Scripts/do-webcore-rename: Get ready for some future renaming.
 533
 534 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 535
 536         Reviewed by Adam.
 537
 538         - Removed some unnecessary functions and changed an unused return type.
 539
 540         * Drosera/win/DebuggerClient.cpp:
 541         (registerConsoleClass):
 542         * Drosera/win/DebuggerClient.h:
 543         * Drosera/win/Drosera.cpp:
 544         (registerDroseraClass):
 545
 546 2007-11-28  Alp Toker  <alp@atoker.com>
 547
 548         Reviewed by Timothy Hatcher.
 549
 550         http://bugs.webkit.org/show_bug.cgi?id=16174
 551         [GTK] Use "URI" not "URL" in public API
 552
 553         Replace use of the term "URL" with "URI" in public headers,
 554         documentation and some internal code to match GLib/GTK+ convention.
 555
 556         This is now mentioned in the API guidelines:
 557           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
 558
 559         * GtkLauncher/main.c:
 560         (activate_uri_entry_cb):
 561         (title_change_cb):
 562         (create_toolbar):
 563         (main):
 564
 565 2007-11-29  Anders Carlsson  <andersca@apple.com>
 566
 567         Reviewed by Sam.
 568
 569         <rdar://problem/5230478>
 570         FrameLoadDelegate callbacks are not dumped in DRT.
 571
 572         * DumpRenderTree/win/DumpRenderTree.cpp:
 573         (shouldLogFrameLoadDelegates):
 574         (runTest):
 575         (main):
 576         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
 577         (BSTRtoString):
 578         (descriptionSuitableForTestResult):
 579         (FrameLoadDelegate::QueryInterface):
 580         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
 581         (FrameLoadDelegate::didFailProvisionalLoadWithError):
 582         (FrameLoadDelegate::didCommitLoadForFrame):
 583         (FrameLoadDelegate::didFinishLoadForFrame):
 584         (FrameLoadDelegate::willCloseFrame):
 585         (FrameLoadDelegate::didClearWindowObject):
 586         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
 587         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
 588         * DumpRenderTree/win/FrameLoaderDelegate.h:
 589         (FrameLoadDelegate::windowScriptObjectAvailable):
 590         (FrameLoadDelegate::didFirstLayoutInFrame):
 591
 592 2007-11-29  Sam Weinig  <sam@webkit.org>
 593
 594         Reviewed by Anders.
 595
 596         Add database quota UIDelegates methods to DRT UIDelegate.
 597
 598         * DumpRenderTree/mac/UIDelegate.mm:
 599         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
 600         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
 601
 602 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 603
 604         Reviewed by Sam.
 605
 606         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
 607         dying and vice versa.
 608         - This fix will allow Drosera and Safari to reconnect if either of them
 609         closes correctly, but does not fix the case where one of them dies
 610         silently.
 611
 612         * Drosera/win/ServerConnection.cpp:
 613         (ServerConnection::attemptToCreateServerConnection): Added a safety
 614         check, because it's possilbe to try to connect to a server that's dying.
 615         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
 616         the server has died.
 617         * Drosera/win/ServerConnection.h: Added the new function and removed
 618         an unnecessary member.
 619
 620 2007-11-29  Anders Carlsson  <andersca@apple.com>
 621
 622         * DumpRenderTree/win/DumpRenderTree.vcproj:
 623         Add shlwapi.lib to all configurations.
 624
 625 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 626
 627         - Build fix.  Added additional includes for VS Express to the Release
 628         project.
 629
 630         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 631
 632 2007-11-29  Anders Carlsson  <andersca@apple.com>
 633
 634         Reviewed by Adam.
 635
 636         <rdar://problem/5132005>
 637         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
 638
 639         * DumpRenderTree/win/DumpRenderTree.vcproj:
 640         Add shlwapi.lib
 641
 642         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 643         (LayoutTestController::setUserStyleSheetEnabled):
 644         Implement this.
 645
 646         (appendComponentToPath):
 647         New method which wraps the Win32 API PathAppend.
 648
 649         (followShortcuts):
 650         New method which checks if a file points to a shortcut and
 651         follows the shortcut.
 652
 653         (resolveCygwinPath):
 654         New method that takes a cygwin unix-style path and returns the Win32 path.
 655
 656         (cfStringRefToWString):
 657
 658         (LayoutTestController::setUserStyleSheetLocation):
 659         Implement this.
 660
 661 2007-11-29  Alice Liu  <alice.liu@apple.com>
 662
 663         Reviewed by Adam.
 664
 665         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
 666
 667         * DumpRenderTree/win/EventSender.cpp:
 668         (keyDownCallback):
 669         uppercase letters were being sent as lowercase letters without the shift key down.
 670
 671 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 672
 673         - Windows build fix. VS express needs some love.
 674
 675         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 676
 677 2007-11-28  Darin Adler  <darin@apple.com>
 678
 679         Reviewed by Adam Roben.
 680
 681         * DumpRenderTree/mac/EventSendingController.mm:
 682         (-[EventSendingController keyDown:withModifiers:]):
 683         Send capital letters through as lowercase letters with the shift key down
 684         rather than sending them as if they were highly unusual "capital letter keys".
 685
 686         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
 687         where you need to update results and more tests are failing than before.
 688
 689 2007-11-28  Anders Carlsson  <andersca@apple.com>
 690
 691         Reviewed by Darin.
 692
 693         <rdar://problem/5132001>
 694         contextClick is not implemented in DRT on Windows.
 695
 696         * DumpRenderTree/win/EventSender.cpp:
 697         (contextClickCallback):
 698         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
 699         by a WM_RBUTTONUP message.
 700
 701         * DumpRenderTree/win/UIDelegate.cpp:
 702         (UIDelegate::hasCustomMenuImplementation):
 703         (UIDelegate::trackCustomPopupMenu):
 704         * DumpRenderTree/win/UIDelegate.h:
 705         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
 706         menu from being shown (and causing the DRT to hang).
 707
 708 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
 709
 710         Reviewed by Darin.
 711
 712         Fix DumpRenderTree ObjC bug comparing strings.
 713
 714         * DumpRenderTree/mac/ObjCController.m:
 715         (-[ObjCController identityIsEqual::]): Compare strings with string
 716         equality instead of identiy equality.
 717
 718 2007-11-27  Timothy Hatcher  <timothy@apple.com>
 719
 720         Reviewed by Sam.
 721
 722         Reset the authorAndUserStylesEnabled preference
 723         back to YES for each test. Fixes the broken tests.
 724
 725         * DumpRenderTree/mac/DumpRenderTree.mm:
 726         (resetWebViewToConsistentStateBeforeTesting):
 727
 728 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
 729
 730         Reviewed by Adam.
 731
 732         - Drosera now displays the console window, although it cannot currently
 733         process JavaScript.
 734
 735         * Drosera/win/DebuggerClient.cpp: Shows the console window.
 736         (registerConsoleClass): Implemented.
 737         (consoleWndProc): Implemented.
 738         (DebuggerClient::onSize): Implemented.
 739         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
 740         new window.
 741         * Drosera/win/DebuggerClient.h: Added needed method and members for
 742         creating and maintaining a new window.
 743         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
 744         lines of code to more appropriate places.
 745         (Drosera::handleCommand):
 746         (Drosera::initUI):
 747         (Drosera::onSize):
 748         (Drosera::attach):
 749
 750 2007-11-27  Timothy Hatcher  <timothy@apple.com>
 751
 752         Reviewed by Dave Hyatt.
 753
 754         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
 755
 756         Add support for disabling author and user styles for testing.
 757
 758         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 759         * DumpRenderTree/LayoutTestController.cpp:
 760         (setAuthorAndUserStylesEnabledCallback):
 761         (LayoutTestController::staticFunctions):
 762         * DumpRenderTree/LayoutTestController.h:
 763         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 764         (LayoutTestController::setAuthorAndUserStylesEnabled):
 765         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 766         (LayoutTestController::setAuthorAndUserStylesEnabled):
 767
 768 2007-11-26  Dan Bernstein  <mitz@apple.com>
 769
 770         - Tiger build fix.
 771
 772         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 773
 774 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
 775
 776         Reviewed by Maciej.
 777
 778         - Implemented displaying variables for Drosera on Win.
 779
 780         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
 781         that retrieve variables to not hold onto the return value since it's
 782         not returned.  Also changed to use the new signatures of the retrieval
 783         functions.
 784         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 785         (DebuggerDocument::platformValueForScopeVariableNamed):
 786         * Drosera/win/Drosera.cpp: Removed a needless TODO.
 787         (droseraWndProc):
 788
 789 2007-11-26  Sam Weinig  <sam@webkit.org>
 790
 791         Cleanup names of painting and repainting functions.
 792
 793         Reviewed by Adam Roben.
 794
 795         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 796         (drawSelectionRect): was drawSelectionRectIntoContext.
 797         (dumpWebViewAsPixelsAndCompareWithExpected):
 798         * DumpRenderTree/cg/PixelDumpSupportCG.h:
 799         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
 800         (paintWebView): was drawWebViewIntoContext.
 801         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
 802
 803 2007-11-26  Sam Weinig  <sam@webkit.org>
 804
 805         Reviewed by Dan Bernstein.
 806
 807         - Leopard build fix
 808
 809         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 810
 811 2007-11-26  Sam Weinig  <sam@webkit.org>
 812
 813         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
 814         Use shared PixelDumpSupport for Mac DRT
 815
 816         Reviewed by Adam Roben.
 817
 818         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 819         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
 820         * DumpRenderTree/cg/ImageDiffCG.cpp:
 821         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 822         (drawSelectionRectIntoContext):
 823         (dumpWebViewAsPixelsAndCompareWithExpected):
 824         * DumpRenderTree/cg/PixelDumpSupportCG.h:
 825         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 826         * DumpRenderTree/mac/DumpRenderTree.mm:
 827         (dump):
 828         * DumpRenderTree/mac/ImageDiff.m: Removed.
 829         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
 830         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
 831         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
 832         (setDefaultColorProfileToRGB):
 833         (getBitmapContextFromWebView):
 834         (drawWebViewIntoContext):
 835         (repaintWithVerticalSweep):
 836         (repaintWithHorizontalSweep):
 837         (getSelectionRect):
 838         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
 839
 840 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
 841
 842         Bug 16052: prepare-ChangeLog doesn't report deleted files
 843         <http://bugs.webkit.org/show_bug.cgi?id=16052>
 844
 845         Reviewed by Sam.
 846
 847         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
 848
 849 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
 850
 851         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
 852         <http://bugs.webkit.org/show_bug.cgi?id=15864>
 853
 854         Reviewed by Adam.
 855
 856         Roll functionality of merge-changelog into resolve-ChangeLogs
 857         script.  The script now checks for ChangeLog.rej and
 858         ChangeLog.orig files first.  If it finds them, it uses the
 859         ChangeLog.rej file as a patch (in old contextual diff format) to
 860         apply with --fuzz=3.
 861
 862         * Scripts/merge-changelog: Removed.
 863         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
 864
 865 2007-11-25  Sam Weinig  <sam@webkit.org>
 866
 867         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
 868
 869         Reviewed by Mark Rowe.
 870
 871         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 872         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 873         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
 874         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
 875         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
 876
 877 2007-11-25  Sam Weinig  <sam@webkit.org>
 878
 879         Convert DumpRenderTree to ues .xcconfig files.
 880
 881         Reviewed by Mark Rowe.
 882
 883         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 884         * DumpRenderTree/mac/Configurations: Added.
 885         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
 886         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
 887         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
 888
 889 2007-11-25  Sam Weinig  <sam@webkit.org>
 890
 891         Add ForwardingHeaders to wtf for DumpRenderTree.
 892
 893         Reviewed by Mark Rowe.
 894
 895         * DumpRenderTree/DumpRenderTree.h:
 896         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 897         * DumpRenderTree/ForwardingHeaders: Added.
 898         * DumpRenderTree/ForwardingHeaders/wtf: Added.
 899         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
 900         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
 901         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
 902         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
 903         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
 904         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
 905         * DumpRenderTree/LayoutTestController.cpp:
 906         * DumpRenderTree/WorkQueue.cpp:
 907         * DumpRenderTree/mac/DumpRenderTree.mm:
 908         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 909         * DumpRenderTree/mac/JavaScriptThreading.cpp:
 910         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 911         * DumpRenderTree/mac/ObjCController.m:
 912         * DumpRenderTree/mac/UIDelegate.mm:
 913         * DumpRenderTree/mac/WorkQueueItemMac.mm:
 914
 915 2007-11-25  Adam Roben  <aroben@apple.com>
 916
 917         Fix some test failures caused by r28019
 918
 919         Now that stdout is in binary mode, we need to always use printf
 920         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
 921         the output.
 922
 923         Reviewed by Sam.
 924
 925         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
 926         printf.
 927         (UIDelegate::runJavaScriptAlertPanelWithMessage):
 928         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
 929         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
 930         (UIDelegate::webViewAddMessageToConsole):
 931
 932 2007-11-25  Adam Roben  <aroben@apple.com>
 933
 934         Set the font smoothing preference in DRT
 935
 936         This makes the pixel results on Windows closer to the Mac results.
 937
 938         Reviewed by Mitz.
 939
 940         * DumpRenderTree/win/DumpRenderTree.cpp:
 941         (initializePreferences):
 942
 943 2007-11-25  Adam Roben  <aroben@apple.com>
 944
 945         Port ImageDiff to CG and C++
 946
 947         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
 948         <rdar://5071708>
 949
 950         Reviewed by Sam.
 951
 952         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
 953         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
 954         (main):
 955         (createImageFromStdin):
 956         (compareImages):
 957         (getDifferenceBitmap):
 958         (computePercentageDifferent):
 959         * DumpRenderTree/win/ImageDiff.vcproj: Added.
 960
 961 2007-11-25  Adam Roben  <aroben@apple.com>
 962
 963         Fix image diff link generation on Windows
 964
 965         Reviewed by Sam.
 966
 967         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
 968         to toURL.
 969
 970 2007-11-25  Adam Roben  <aroben@apple.com>
 971
 972         Implement pixel dumping in Windows DRT
 973
 974         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
 975         <rdar://5071708>
 976
 977         Reviewed by Sam.
 978
 979         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
 980         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
 981         Content-Length header.
 982         (getMD5HashStringForBitmap):
 983         (dumpWebViewAsPixelsAndCompareWithExpected):
 984         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
 985         * DumpRenderTree/win/DumpRenderTree.cpp:
 986         (dump): Do a pixel dump if requested.
 987         (main): Parse pixel test options.
 988         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
 989         the cg/ subdirectory to the include path.
 990         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
 991         available in a header or import library, so we have to go through this
 992         LoadLibrary/GetProcAddress dance to use them.
 993         (cryptDLL):
 994         (init):
 995         (update):
 996         (final):
 997         (MD5_Init):
 998         (MD5_Update):
 999         (MD5_Final):
1000         * DumpRenderTree/win/MD5.h: Added.
1001         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1002         moved up to the top level to share it with Mac eventually.
1003         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1004         (getBitmapContextFromWebView): Forces the WebView to paint using a
1005         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1006
1007 2007-11-25  Adam Roben  <aroben@apple.com>
1008
1009         Clean up Windows DRT's option parsing a little bit
1010
1011         Reviewed by Sam.
1012
1013         * DumpRenderTree/win/DumpRenderTree.cpp:
1014         (main): Put non-option arguments into a Vector.
1015
1016 2007-11-25  Adam Roben  <aroben@apple.com>
1017
1018         Make Windows DRT stop changing LF into CRLF
1019
1020         Reviewed by Sam.
1021
1022         * DumpRenderTree/win/DumpRenderTree.cpp:
1023         (main): Put stdout in binary mode.
1024         * Scripts/run-webkit-tests: Remove the CRLF hack.
1025
1026 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1027
1028         Removed empty directory.
1029
1030         * Scripts/resources: Removed.
1031
1032 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1033
1034         Fix bisect-builds to work with recent WebKit nightly builds.
1035
1036         Reviewed by Dan.
1037
1038         * Scripts/bisect-builds: Check for the
1039         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1040         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1041         to WebKit.app/Contents/Resources.
1042
1043 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1044
1045         Reviewed by Maciej.
1046
1047         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1048         not closed (affects digg.com)
1049
1050         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1051         one after finishing with a test to avoid having its delayed onload handler firing when
1052         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1053         but it helps somewhat.
1054
1055 2007-11-22  Mark Rowe  <mrowe@apple.com>
1056
1057         Reviewed by Alp Toker.
1058
1059         Fix build-webkit to propagate make's exit status if it fails.
1060
1061         * Scripts/webkitdirs.pm:
1062
1063 2007-11-22  Dan Bernstein  <mitz@apple.com>
1064
1065         Reviewed by Mark Rowe.
1066
1067         - fix crash when running pixel tests
1068
1069         * DumpRenderTree/mac/DumpRenderTree.mm:
1070         (dumpRenderTree): Parse the command line options before setting up the
1071         environment so that we know if we need to set up the pixel dump
1072         machinery.
1073
1074 2007-11-21  Eric Seidel  <eric@webkit.org>
1075
1076         Speculative build fix for Tiger.
1077
1078         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1079
1080 2007-11-21  Eric Seidel  <eric@webkit.org>
1081
1082         Reviewed by Tim Hatcher.
1083
1084         Break out more of DumpRenderTree.mm into individual files
1085
1086         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1087         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1088         (checkedMalloc):
1089         (checkedRealloc):
1090         (makeLargeMallocFailSilently):
1091         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1092         * DumpRenderTree/mac/DumpRenderTree.mm:
1093         (crashHandler):
1094         (dump):
1095         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1096         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1097         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1098         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1099         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1100         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1101         (javaScriptThreads):
1102         (runJavaScriptThread):
1103         (startJavaScriptThreads):
1104         (stopJavaScriptThreads):
1105         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1106         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1107         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1108         (restoreColorSpace):
1109         (setDefaultColorProfileToRGB):
1110         (initializeColorSpaceAndScreeBufferForPixelTests):
1111         (md5HashStringForBitmap):
1112         (dumpWebViewAsPixelsAndCompareWithExpected):
1113
1114 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1115
1116         Move install-unix-extras to wx directory as it seems only to be used by that
1117         port now. It now supports universal binaries on Mac and adds libpng and libjpeg.
1118         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1119         have install-unix-extras install into WebKitLibraries as per
1120         convention.
1121
1122         Reviewed by Mark Rowe.
1123
1124         * Scripts/install-unix-extras: Removed.
1125         * wx/build-wxwebkit:
1126         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1127
1128 2007-11-21  Eric Seidel  <eric@webkit.org>
1129
1130         Reviewed by Adam.
1131
1132         More refactoring for greater code readability
1133
1134         * DumpRenderTree/mac/DumpRenderTree.mm:
1135         (initializeGlobalsFromCommandLineOptions):
1136         (initializeColorSpaceAndScreeBufferForPixelTests):
1137         (addTestPluginsToPluginSearchPath):
1138         (useLongRunningServerMode):
1139         (runTestingServerLoop):
1140         (prepareConsistentTestingEnvironment):
1141         (dumpRenderTree):
1142         (main):
1143         (dumpFramesAsText):
1144         (dumpBackForwardListForWebView):
1145         (sizeWebViewForCurrentTest):
1146         (methodNameStringForFailedTest):
1147         (dumpBackForwardListForAllWindows):
1148         (dumpWebViewAsPixelsAndCompareWithExpected):
1149         (invalidateAnyPreviousWaitToDumpWatchdog):
1150         (dump):
1151         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1152         * DumpRenderTree/mac/UIDelegate.mm:
1153         (-[UIDelegate webView:createWebViewWithRequest:]):
1154
1155 2007-11-21  Eric Seidel  <eric@webkit.org>
1156
1157         Reviewed by Tim Hatcher.
1158
1159         Abstract more of DRT into static methods
1160
1161         * DumpRenderTree/mac/DumpRenderTree.mm:
1162         (setDefaultsToConsistentValuesForTesting):
1163         (setupSignalHandlers):
1164         (allocateGlobalControllers):
1165         (releaseAndZero):
1166         (releaseGlobalControllers):
1167         (dumpRenderTree):
1168         (shouldLogFrameLoadDelegates):
1169         (createCFURLFromPathOrURL):
1170         (resetWebViewToConsistentStateBeforeTesting):
1171         (runTest):
1172
1173 2007-11-21  Eric Seidel  <eric@webkit.org>
1174
1175         Reviewed by Tim Hatcher.
1176
1177         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1178
1179         * DumpRenderTree/DumpRenderTree.h:
1180         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1181         * DumpRenderTree/mac/DumpRenderTree.mm:
1182         (dumpRenderTree):
1183         (dump):
1184         (runTest):
1185         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1186         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1187         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1188         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1189         (-[DumpRenderTreePasteboard declareType:owner:]):
1190         (+[LocalPasteboard alloc]):
1191         (-[LocalPasteboard init]):
1192         (-[LocalPasteboard dealloc]):
1193         (-[LocalPasteboard name]):
1194         (-[LocalPasteboard releaseGlobally]):
1195         (-[LocalPasteboard declareTypes:owner:]):
1196         (-[LocalPasteboard addTypes:owner:]):
1197         (-[LocalPasteboard changeCount]):
1198         (-[LocalPasteboard types]):
1199         (-[LocalPasteboard availableTypeFromArray:]):
1200         (-[LocalPasteboard setData:forType:]):
1201         (-[LocalPasteboard dataForType:]):
1202         (-[LocalPasteboard setPropertyList:forType:]):
1203         (-[LocalPasteboard setString:forType:]):
1204         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1205         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1206         (+[DumpRenderTreeWindow allWindows]):
1207         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1208         (-[DumpRenderTreeWindow dealloc]):
1209         (-[DumpRenderTreeWindow isKeyWindow]):
1210         (-[DumpRenderTreeWindow keyDown:]):
1211
1212 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1213
1214         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1215         it indiscriminately copies any headers inside JavaScriptCore,
1216         which includes Tiger ICU headers.
1217
1218         * wx/build-wxwebkit:
1219         Don't run WebCore/move-js-headers.sh any longer.
1220
1221 2007-11-20  Adam Treat  <treat@kde.org>
1222
1223         Reviewed by David Kilzer.
1224
1225         * Prepend git branch name to $baseProductDir
1226
1227         * Scripts/VCSUtils.pm:
1228         * Scripts/webkitdirs.pm:
1229
1230 2007-11-20  Mark Rowe  <mrowe@apple.com>
1231
1232         Reviewed by Simon Hausmann.
1233
1234         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1235         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1236         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1237         built product and generated Makefile's are removed.
1238
1239 2007-11-19  Alp Toker  <alp@atoker.com>
1240
1241         Reviewed by Mark Rowe.
1242
1243         http://bugs.webkit.org/show_bug.cgi?id=16040
1244         [GTK] GtkLauncher should be written in C
1245
1246         Port GtkLauncher to plain C.
1247
1248         Use a more conventional GTK+ coding style.
1249
1250         Use a toolbar instead of menus.
1251
1252         Various signature fixes and cleanups.
1253
1254         Add a license header. Assume all previous modifications were copyright
1255         assigned to Apple Inc. by default.
1256
1257         * GtkLauncher/GtkLauncher.pro:
1258         * GtkLauncher/main.c: Added.
1259         (activate_url_entry_cb):
1260         (update_title):
1261         (link_hover_cb):
1262         (title_change_cb):
1263         (progress_change_cb):
1264         (destroy_cb):
1265         (go_back_cb):
1266         (go_forward_cb):
1267         (create_browser):
1268         (create_statusbar):
1269         (create_toolbar):
1270         (create_window):
1271         (main):
1272         * GtkLauncher/main.cpp: Removed.
1273
1274 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1275
1276         Build script fixes to ensure they do the right thing for the
1277         wx port, and update build-wxwebkit to reflect the way the
1278         build scripts now work.
1279
1280         Reviewed by Adam.
1281
1282         * Scripts/build-testkjs:
1283         * Scripts/build-webkit:
1284         * Scripts/run-javascriptcore-tests:
1285         * Scripts/webkitdirs.pm:
1286         * wx/build-wxwebkit:
1287
1288 2007-11-18  Eric Seidel  <eric@webkit.org>
1289
1290         Reviewed by Anders.
1291
1292         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1293
1294         * Scripts/run-javascriptcore-tests:
1295
1296 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1297
1298         Reviewed by Adam Roben.
1299
1300         Make run-webkit-tests work with Windows debug build.
1301
1302         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1303         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1304         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1305         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1306         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1307
1308 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1309
1310         Add wxWebKit sample and build script, and integrate it with
1311         build-webkit. Also make build-webkit --clean work for all
1312         ports.
1313
1314         Reviewed by Darin Adler.
1315
1316         * Scripts/build-webkit:
1317         * Scripts/webkitdirs.pm:
1318         * wx: Added.
1319         * wx/browser: Added.
1320         * wx/browser/browser.bkl: Added.
1321         * wx/browser/browser.cpp: Added.
1322         * wx/build-wxwebkit: Added.
1323
1324 2007-11-17  Adam Roben  <aroben@apple.com>
1325
1326         Make it easy to run Safari in the debugger on Windows
1327
1328         I've added a new script, debug-safari, which launches Safari in the
1329         debugger. On OS X it just calls gdb-safari.
1330
1331         Reviewed by Mark Rowe.
1332
1333         * FindSafari/FindSafari.cpp:
1334         (_tmain): Added a /debugger flag, which in combination with
1335         /printSafariLauncher will print a script that launches Safari in the
1336         debugger.
1337         * Scripts/debug-safari: Added.
1338         * Scripts/run-safari: Changed to call runSafari().
1339         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1340         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1341         first argument along to FindSafari.
1342         * Scripts/webkitdirs.pm:
1343         (sub runSafari): Added.
1344
1345 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1346
1347         Reviewed by Adam Roben.
1348
1349         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.
1350
1351 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1352
1353         Reviewed by David Kilzer.
1354
1355         The git config command was renamed to repo-config at some point. This
1356         change tries git config and then git repo-config if the first fails.
1357
1358         * Scripts/prepare-ChangeLog:
1359         (gitConfig):
1360
1361 2007-11-16  Dan Bernstein  <mitz@apple.com>
1362
1363         Reviewed by Darin Adler and Sam Weinig.
1364
1365         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1366
1367         * DumpRenderTree/win/EventSender.cpp:
1368         (keyDownCallback): For characters that cannot be entered on the active
1369         keyboard layout, send a WM_CHAR message with the character along with
1370         a WM_KEYDOWN message with a virtual key code of 255.
1371
1372 2007-11-16  Mark Rowe  <mrowe@apple.com>
1373
1374         Reviewed by Tim Hatcher.
1375
1376         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1377
1378         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1379         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1380
1381 2007-11-15  Adam Roben  <aroben@apple.com>
1382
1383         Make run-safari actually work on Windows
1384
1385         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1386         chdir call.
1387
1388 2007-11-14  Adam Roben  <aroben@apple.com>
1389
1390         Updates to Safari launching now that 3.0.4 is released
1391
1392         Reviewed by Sam.
1393
1394         * FindSafari/FindSafari.cpp:
1395         (getWebViewCLSID): Use version-independent ProgID.
1396         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1397
1398 2007-11-14  Anders Carlsson  <andersca@apple.com>
1399
1400         Reviewed by Adam.
1401
1402         <rdar://problem/5309081>
1403         In DRT, "plugin.logDestroy = true" not working on Windows.
1404
1405         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1406         (NPP_Destroy):
1407
1408 2007-11-14  Eric Seidel  <eric@webkit.org>
1409
1410         Reviewed by Sam.
1411
1412         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1413
1414 2007-11-14  Anders Carlsson  <andersca@apple.com>
1415
1416         Reviewed by Adam.
1417
1418         <rdar://problem/5141186>
1419         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1420
1421         Implement setWindowIsKey.
1422
1423         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1424         (LayoutTestController::setWindowIsKey):
1425
1426 2007-11-13  Sam Weinig  <sam@webkit.org>
1427
1428         Reviewed by Adam Roben.
1429
1430         Fix for <rdar://problem/5382579>
1431         http/tests/security/cross-frame-access-put.html reports large
1432         negative numbers for screenLeft and screenTop (Mac reports "0")
1433
1434         * DumpRenderTree/win/UIDelegate.cpp:
1435         (UIDelegate::UIDelegate): Initialize the RECT.
1436         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1437         (UIDelegate::webViewFrame): ditto.
1438         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1439
1440 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1441
1442         Reviewed by Adam.
1443
1444         - Make Drosera show source, source URLs, and function stack on Windows,
1445         and some minor fixes.
1446
1447         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1448         (DebuggerDocument::updateFileSource):
1449         * Drosera/debugger.js: Force source to always update display.
1450         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1451         menu controls.
1452         (DebuggerClient::resume):
1453         (DebuggerClient::pause):
1454         (DebuggerClient::stepInto):
1455         (DebuggerClient::stepOver):
1456         (DebuggerClient::stepOut):
1457         (DebuggerClient::showConsole):
1458         (DebuggerClient::closeCurrentFile):
1459         * Drosera/win/DebuggerClient.h: Ditto.
1460         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1461         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1462         removed two bugs.  1) caller could be in a bad state when asked to
1463         assign into it. 2) BSTRs were not created correctly.
1464         (DebuggerDocument::getPlatformCurrentFunctionStack):
1465         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1466         (droseraWndProc):
1467         (handleCommand):
1468         (Drosera::resume):
1469         (Drosera::pause):
1470         (Drosera::stepInto):
1471         (Drosera::stepOver):
1472         (Drosera::stepOut):
1473         (Drosera::showConsole):
1474         (Drosera::closeCurrentFile):
1475         * Drosera/win/Drosera.h: Hook up the menu controls.
1476         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1477         functions, added a null check, and fixed another bug where caller could
1478         be in a bad state when asked to assign into it.
1479         (ServerConnection::didLoadMainResourceForDataSource):
1480         (ServerConnection::getCallerFrame):
1481         * Drosera/win/ServerConnection.h: Safety first.
1482
1483 2007-11-13  Dan Bernstein  <mitz@apple.com>
1484
1485         Reviewed by Darin Adler.
1486
1487         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1488           DumpRenderTree --pixel-tests renders each test twice
1489
1490         * DumpRenderTree/mac/DumpRenderTree.mm:
1491         (dumpRenderTree): Removed the --paint option because the painting code
1492         is always exercised as a result of
1493         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1494         calling -displayIfNeeded.
1495         (dump): Changed to always grab the image from the window since the view
1496         is always displayed.
1497         (runTest):
1498         (displayWebView):
1499         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1500         because it always paints.
1501
1502 2007-11-12  Antti Koivisto  <antti@apple.com>
1503
1504         Reviewed by Adele.
1505
1506         Add support for http media tests
1507
1508         * Scripts/run-webkit-tests:
1509
1510 2007-11-12  Sam Weinig  <sam@webkit.org>
1511
1512         Reviewed by Adam Roben.
1513
1514         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1515
1516         * DumpRenderTree/win/DumpRenderTree.cpp:
1517         (runTest):
1518         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1519         (LayoutTestController::setPrivateBrowsingEnabled):
1520
1521 2007-11-12  Adam Roben  <aroben@apple.com>
1522
1523         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1524         mac and win subdirectories.
1525
1526 2007-11-11  Adam Roben  <aroben@apple.com>
1527
1528         Fix <rdar://5133816> keepWebHistory is not implemented
1529
1530         Fixes fast/history/clicked-link-is-visited.html.
1531
1532         Reviewed by Darin.
1533
1534         * DumpRenderTree/win/DumpRenderTree.cpp:
1535         (runTest): Clear the optionalSharedHistory.
1536         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1537         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1538
1539 2007-11-10  Sam Weinig  <sam@webkit.org>
1540
1541         Reviewed by Tim Hatcher.
1542
1543         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
1544         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
1545         is turned on)
1546
1547         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1548
1549         Added test: http/tests/security/cross-frame-access-private-browsing.html
1550
1551         * DumpRenderTree/LayoutTestController.cpp:
1552         (setPrivateBrowsingEnabledCallback):
1553         (LayoutTestController::staticFunctions):
1554         * DumpRenderTree/LayoutTestController.h:
1555         * DumpRenderTree/mac/DumpRenderTree.mm:
1556         (runTest): Default to private browsing disabled.
1557         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1558         (LayoutTestController::setPrivateBrowsingEnabled):
1559         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1560         (LayoutTestController::setPrivateBrowsingEnabled):
1561
1562 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1563
1564         Reviewed by Adam.
1565
1566         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1567         WebCore's!
1568
1569         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1570         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1571         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1572         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1573         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1574         * Drosera/win/Drosera.cpp:
1575         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1576
1577 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1578
1579         Reviewed by Sam.
1580
1581         - Use the new IWebFrame [local] function signature and get the shared
1582         server correctly.
1583
1584         * Drosera/win/DebuggerClient.cpp:
1585         (DebuggerClient::didFinishLoadForFrame):
1586         * Drosera/win/ServerConnection.cpp:
1587         (ServerConnection::attemptToCreateServerConnection):
1588
1589 2007-11-07  Dan Bernstein  <mitz@apple.com>
1590
1591         Reviewed by Darin Adler.
1592
1593         - add an option to run-webkit-tests to ignore pixel test failures where
1594           all pixels differ by no more than a specified threshold
1595
1596         * DumpRenderTree/mac/ImageDiff.m:
1597         (main):
1598         (compareImages):
1599         (computePercentageDifferent):
1600         * Scripts/run-webkit-tests:
1601
1602 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1603
1604         Reviewed by Lars.
1605
1606         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1607
1608         * DumpRenderTree/qt/DumpRenderTree.cpp:
1609
1610 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1611
1612         Reviewed by Lars.
1613
1614         Reworked the QWebSettings API.
1615         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1616
1617         * DumpRenderTree/qt/DumpRenderTree.cpp:
1618
1619 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1620
1621         Reviewed by Lars.
1622
1623         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1624
1625         * DumpRenderTree/qt/jsobjects.cpp:
1626
1627 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1628
1629         Reviewed by Lars Knoll <lars@trolltech.com>.
1630
1631         Add a QWebPage::frameCreated() signal and fix DRT
1632
1633         The removal of createFrame in QWebPage broke the re-implementation
1634         in DumpRenderTree. Instead emit a frameCreated() signal and
1635         connect to it in DumpRenderTree.
1636
1637
1638         * DumpRenderTree/qt/DumpRenderTree.cpp:
1639         (WebCore::WebPage::WebPage):
1640         (WebCore::DumpRenderTree::dump):
1641         (WebCore::DumpRenderTree::connectFrame):
1642         * DumpRenderTree/qt/DumpRenderTree.h:
1643
1644 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1645
1646         Reviewed by Lars Knoll <lars@trolltech.com>.
1647
1648         Moved all the event handlers from QWebFrame into QWebPage.
1649
1650         This cleans up the public API and allows us to remove the
1651         HackWebFrame hack in DumpRenderTree.
1652
1653
1654         * DumpRenderTree/qt/jsobjects.cpp:
1655         (EventSender::mouseDown):
1656         (EventSender::mouseUp):
1657         (EventSender::mouseMoveTo):
1658
1659 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1660
1661         Reviewed by Mark.
1662
1663         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1664         to prevent the default implementation from popping up messageboxes.
1665
1666         * DumpRenderTree/qt/DumpRenderTree.cpp:
1667         (WebCore::WebPage::javaScriptConfirm):
1668         (WebCore::WebPage::javaScriptPrompt):
1669
1670 2007-11-06  Eric Seidel  <eric@webkit.org>
1671
1672         * Scripts/build-testkjs: build fix... too many $$
1673
1674 2007-11-06  Eric Seidel  <eric@webkit.org>
1675
1676         Reviewed by Mark Rowe.
1677
1678         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1679
1680 2007-11-05  Adam Roben  <aroben@apple.com>
1681
1682         Add support on Windows for WEBKIT_TESTFONTS
1683
1684         This environment variable lets you specify where the fonts to be used
1685         by DumpRenderTree reside. The Qt port is already using this, so I'm
1686         just following their lead.
1687
1688         Reviewed by Darin.
1689
1690         * DumpRenderTree/win/DumpRenderTree.cpp:
1691         (exePath): Refactored code out of initialize().
1692         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1693         DumpRenderTree.resources.
1694         (initialize): Use the new fontsPath function.
1695         (main): Use the new exePath function.
1696         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1697         variable to DRT, like Qt does.
1698
1699 2007-11-05  Mark Rowe  <mrowe@apple.com>
1700
1701         Rubber-stamped by Alp Toker.
1702
1703         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1704
1705         * GtkLauncher/main.cpp:
1706         (goToURLBarText):
1707         (main):
1708
1709 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1710
1711         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1712         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1713
1714         Reviewed by Timothy.
1715
1716         Restrict the range of nightly builds used by the bisect-builds script
1717         based on the version of Safari and the version of Mac OS X being used.
1718
1719         Mac OS X 10.4: Safari 2.0: r11976 or newer
1720         Mac OS X 10.4: Safari 3.0: r19992 or newer
1721
1722         Mac OS X 10.5: Safari 2.0: r19594 or newer
1723         Mac OS X 10.5: Safari 3.0: r25124 or newer
1724
1725         * Scripts/bisect-builds:
1726         (findMacOSXVersion): Added.
1727         (makeNightlyList): Added argument to provide version of Mac OS X.
1728         Restrict range of nightly builds based on Safari and Mac OS X versions.
1729
1730 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1731
1732         Reviewed by Maciej.
1733
1734         - This patch involves several changes, all of them were noticed that
1735         they were needed by the work being done in WebKit to get Drosera and
1736         WebKit working together on Windows.
1737         - The changes are:
1738         1) Added a debugger console for output messages.
1739         2) Drosera now listens for the WebKit server (before, the server would
1740         have to be running before Drosera was started.)
1741         3) Fixed a bug where the WebView started out as 0x0 pixels.
1742         4) Fixed a bug when there is no scope.
1743         5) Added the HTML, JS, and CSS to the project file to make them easy to
1744         find.
1745         6) Made the ServerConnection functions virtual.
1746
1747         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1748         for the WebKit server.
1749         (DebuggerClient::DebuggerClient):
1750         (DebuggerClient::~DebuggerClient):
1751         (DebuggerClient::didFinishLoadForFrame):
1752         (DebuggerClient::serverConnected):
1753         (DebuggerClient::attemptToCreateServerConnection):
1754         * Drosera/win/DebuggerClient.h: Ditto.
1755         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1756         scope.
1757         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1758         (DebuggerDocument::platformValueForScopeVariableNamed):
1759         * Drosera/win/Drosera.cpp:
1760         (_tWinMain): Added a console in debug for output messages.
1761         (Drosera::Drosera): Listen for server.
1762         (Drosera::initUI): The server now Initializes COM.
1763         (Drosera::serverConnected): Part of the listening for the server.
1764         (Drosera::attemptToCreateServerConnection): Ditto.
1765         * Drosera/win/Drosera.h: New interface for listening for the server.
1766         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1767         files to the VS project.
1768         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1769         connection.
1770         (ServerConnection::ServerConnection):
1771         (ServerConnection::attemptToCreateServerConnection):
1772         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1773         methods.
1774         (ServerConnection::serverConnected):
1775
1776 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1777
1778         Reviewed by Maciej.
1779
1780         http://bugs.webkit.org/show_bug.cgi?id=15832
1781         fast/dom/gc-10.html crashes when run alone
1782
1783         Check for !done before using objects that can be already deallocated.
1784
1785         * DumpRenderTree/mac/EditingDelegate.mm:
1786         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1787         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1788         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1789         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1790         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1791         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1792         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1793         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1794         (-[EditingDelegate webViewDidBeginEditing:]):
1795         (-[EditingDelegate webViewDidChange:]):
1796         (-[EditingDelegate webViewDidEndEditing:]):
1797         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1798         (-[EditingDelegate webViewDidChangeSelection:]):
1799         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1800         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1801         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1802         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1803         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1804         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1805         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1806         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1807         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1808         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1809         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1810         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1811         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1812         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1813         (-[FrameLoadDelegate webView:willCloseFrame:]):
1814         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1815         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1816         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1817         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1818         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1819         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1820         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1821         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1822         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1823
1824 2007-11-04  Mark Rowe  <mrowe@apple.com>
1825
1826         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1827         warnings that would otherwise be suppressed due to it being a system header.
1828
1829         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1830
1831 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1832
1833         Rubber stamped by Adam.
1834
1835         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1836
1837         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1838
1839 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1840
1841         Sort files(...); sections of Xcode project files.
1842
1843         Rubber-stamped by Darin.
1844
1845         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1846         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1847         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1848         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1849
1850 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1851
1852         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1853
1854         Reviewed by Darin.
1855
1856         * Scripts/sort-Xcode-project-file: Added.
1857
1858 2007-11-02  Darin Adler  <darin@apple.com>
1859
1860         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1861
1862 2007-11-02  Darin Adler  <darin@apple.com>
1863
1864         Reviewed by Maciej.
1865
1866         * Scripts/run-sunspider: Pass the "--base" option through.
1867
1868         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1869         the real script do that. Default configuration to Release to match run-sunspider
1870         so we don't end up building Debug just to compare results.
1871
1872 2007-11-01  Adam Roben  <aroben@apple.com>
1873
1874         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1875
1876         Reviewed by Sam.
1877
1878         * Scripts/commit-log-editor: Show all the directories beneath the
1879         source root, instead of just the last one.
1880
1881 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1882
1883         Reviewed by Adam Roben.
1884
1885         Print out an error message when the Windows build fails
1886         and provide guidance on how to find out what went wrong.
1887
1888         * Scripts/build-webkit:
1889         * Scripts/webkitdirs.pm:
1890
1891 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1892
1893         Rubber-stamped by Adam Roben.
1894
1895         Rolled out r27326 - debug CRT seems to cause no problems after all.
1896
1897         * DumpRenderTree/win/DumpRenderTree.vcproj:
1898
1899 2007-10-31  Adam Roben  <aroben@apple.com>
1900
1901         Switch the Debug configuration to using the non-debug CRT
1902
1903         This matches WebKit.
1904
1905         Reviewed by Steve.
1906
1907         * DumpRenderTree/win/DumpRenderTree.vcproj:
1908
1909 2007-10-31  Antti Koivisto  <antti@apple.com>
1910
1911         Reviewed by bdash.
1912
1913         Disable media tests when doing leak checking on Tiger.
1914         They crash in QuickTime (rdar://problem/5537157).
1915
1916         * Scripts/run-webkit-tests:
1917
1918 2007-10-29  Antti Koivisto  <antti@apple.com>
1919
1920         Reviewed by Maciej.
1921
1922         Build media support by default on OSX only.
1923
1924         * Scripts/build-webkit:
1925
1926 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1927
1928         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1929         get caught by the pre-commit hooks.
1930
1931 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1932
1933         Reviewed by Adam.
1934
1935         - This is a collection of relatively unrelated changes and cleanups
1936         to Drosera to prepare it for interacting with WebKit.  A lot of these
1937         changes are just correcting mistakes, for example removing included
1938         headers that are no longer needed.
1939
1940         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1941         this will be needed by the DebuggerClient.
1942         (DebuggerDocument::server):
1943         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1944         * Drosera/win/DebuggerClient.cpp:
1945         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1946         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1947         (DebuggerClient::createWebViewWithRequest): Added comment about its
1948         purpose.
1949         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1950         declarations.
1951         (DebuggerClient::webViewLoaded): Moved.
1952         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1953         file, since this was the only place it was used.
1954         (cfStringToBSTR):
1955         * Drosera/win/Drosera.h: Cleaned up the includes.
1956         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1957         * Drosera/win/HelperFunctions.h: Removed.
1958
1959 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1960
1961         Reviewed by Adam.
1962
1963         - Small cleanup in the ServerConnection class.
1964
1965         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1966         and added an include.
1967         (ServerConnection::currentFrame):
1968         (ServerConnection::getCallerFrame):
1969         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1970         made a pointer into a COMPtr, and cleaned up the includes.
1971
1972 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1973
1974         Reviewed by John Sullivan.
1975
1976         - Place the Localizable.strings file in mac or win directories
1977           if that location exists.
1978         - Also look for UI_STRING in .c files.
1979
1980         * Scripts/extract-localizable-strings:
1981
1982 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1983
1984         Reviewed by Adam.
1985
1986         - Set the eol-style to native and made all the line endings the same
1987         so that I avoid messy diffs that show eol changes.
1988
1989         * Drosera/win/ServerConnection.cpp:
1990         (ServerConnection::didParseSource):
1991         (ServerConnection::didEnterCallFrame):
1992         (ServerConnection::willExecuteStatement):
1993         (ServerConnection::willLeaveCallFrame):
1994         (ServerConnection::exceptionWasRaised):
1995
1996 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1997
1998         Reviewed by Adam.
1999
2000         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2001         functionality that could not have existed previously without the new
2002         interfaces.
2003         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2004         from a BSTR to a JSValueRef.
2005         (DebuggerDocument::platformEvaluateScript): Implemented.
2006         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2007         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2008         Implemented.
2009         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2010         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2011         * Drosera/win/ServerConnection.cpp: Added a helper function.
2012         (ServerConnection::getCallerFrame):
2013         * Drosera/win/ServerConnection.h: Added a helper function.
2014
2015 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2016
2017         updated reviewers for my previous changelog.
2018
2019 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2020         Reviewed by Maciej and Adam and Geoff.
2021
2022         - Minor mac-side improvements including moving a function to a more
2023         appropriate location, fixing a warning, and correctly checking
2024         exceptions.
2025
2026         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2027         (DebuggerDocument::willExecuteStatement):
2028         (DebuggerDocument::didEnterCallFrame):
2029         (DebuggerDocument::willLeaveCallFrame):
2030         (DebuggerDocument::windowScriptObjectAvailable):
2031         (DebuggerDocument::callFunctionOnObject):
2032         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2033         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2034         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2035         because it doesn't require the ServerConnection at all.
2036         (NSStringCreateWithJSStringRef): Made an argument const.
2037         (JSValueRefCreateWithNSString): Made an argument const.
2038         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2039         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2040         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2041         * Drosera/mac/ServerConnection.mm: Ditto.
2042         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2043
2044 2007-10-29  Sam Weinig  <sam@webkit.org>
2045
2046         Reviewed by Adam Roben.
2047
2048         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2049
2050         * DumpRenderTree/LayoutTestController.cpp:
2051         (LayoutTestController::LayoutTestController):
2052         (getGlobalFlagCallback):
2053         (setGlobalFlagCallback):
2054         (LayoutTestController::getJSClass):
2055         (LayoutTestController::staticValues):
2056         * DumpRenderTree/LayoutTestController.h:
2057         (LayoutTestController::globalFlag):
2058         (LayoutTestController::setGlobalFlag):
2059
2060 2007-10-29  Darin Adler  <darin@apple.com>
2061
2062         Reviewed by Maciej.
2063
2064         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2065         resolution instead of its default.
2066
2067 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2068
2069         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2070
2071         Reviewed by Mark Rowe.
2072
2073         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2074         was successfully resolved, but this would not show any status because the change had
2075         already been cached in the index using "git add".  The solution is to add an optional
2076         second argument to showStatus() which adds the "--cached" switch to the command.
2077
2078         * Scripts/resolve-ChangeLogs:
2079         (showStatus):
2080
2081 2007-10-28  Eric Seidel  <eric@webkit.org>
2082
2083         Reviewed by Maciej and Geoff, in unison.
2084
2085         * Scripts/run-webkit-tests: remove broken --svg option
2086
2087 2007-10-28  Darin Adler  <darin@apple.com>
2088
2089         Reviewed by Adam.
2090
2091         * Scripts/run-sunspider: Default to "Release" configuration rather than
2092         defaulting to the last configuration used as other scripts do. This can
2093         still be overriden on the command line with "--debug" if there's some
2094         reason to do so. Also fix a typo.
2095
2096         * Scripts/sunspider-compare-results: Fix a typo.
2097
2098 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2099
2100         Reviewed by Adam.
2101
2102         - Implemented the WebScriptDebugListener functions now that the
2103         WebScriptDebugServer exists
2104
2105         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2106         functions.
2107         (ServerConnection::currentFrame):
2108         (ServerConnection::didLoadMainResourceForDataSource):
2109         (ServerConnection::didParseSource):
2110         (ServerConnection::failedToParseSource):
2111         (ServerConnection::didEnterCallFrame):
2112         (ServerConnection::willExecuteStatement):
2113         (ServerConnection::willLeaveCallFrame):
2114         (ServerConnection::exceptionWasRaised):
2115         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2116         members arguments list.
2117
2118 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2119
2120         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2121         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2122
2123         Reviewed by Darin.
2124
2125         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2126         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2127         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2128         file.  Note that it may also be used as a stand-alone script.
2129
2130         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2131         * Scripts/resolve-ChangeLogs: Added.
2132         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2133
2134 2007-10-26  Mark Rowe  <mrowe@apple.com>
2135
2136         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2137         to the Qt port on the assumption that it was an implementation of the cross-platform
2138         LayoutTestController class.  It is not, so it did not need to be changed.
2139
2140         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2141
2142 2007-10-25  Mark Rowe  <mrowe@apple.com>
2143
2144         Reviewed by Maciej.
2145
2146         Fix builds with code coverage enabled.
2147
2148         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2149
2150 2007-10-25  Darin Adler  <darin@apple.com>
2151
2152         Reviewed by Mark Rowe.
2153
2154         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2155         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2156
2157 2007-10-25  Stephanie  <slewis@apple.com>
2158
2159         build Fix
2160
2161         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2162
2163 2007-10-25  Stephanie  <slewis@apple.com>
2164
2165         Reviewed by Mark Rowe, Adam Roben.
2166
2167         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2168
2169         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2170
2171 2007-10-25  Alice Liu  <alice.liu@apple.com>
2172
2173         Reviewed by Adam.
2174
2175         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2176
2177         Moving destructor into platform-specific files
2178         * DumpRenderTree/LayoutTestController.cpp:
2179         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2180         (LayoutTestController::~LayoutTestController):
2181         * DumpRenderTree/qt/jsobjects.cpp:
2182         (LayoutTestController::~LayoutTestController):
2183
2184         LayoutTestController wasn't being destroyed
2185         * DumpRenderTree/win/DumpRenderTree.cpp:
2186         (runTest):
2187
2188         Added declspec
2189         * DumpRenderTree/win/EditingDelegate.h:
2190
2191         Reset certain values on the webview (or related delegate) that might
2192         have changed while running a test
2193         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2194         (LayoutTestController::~LayoutTestController):
2195
2196 2007-10-25  Adam Roben  <aroben@apple.com>
2197
2198         Make sunspider-compare-results work with relative paths
2199
2200         Reviewed by Sam.
2201
2202         * Scripts/sunspider-compare-results: Convert arguments to absolute
2203         paths before we chdir.
2204
2205 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2206
2207         Reviewed by Sam.
2208
2209         - Implemented server calls now the WebScriptDebugServer exists.
2210         - Also removed no longer needed call to initialize CG.
2211
2212         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2213         automatically now.
2214         (_tWinMain):
2215         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2216         (ServerConnection::ServerConnection):
2217         (ServerConnection::~ServerConnection):
2218         (ServerConnection::pause):
2219         (ServerConnection::resume):
2220         (ServerConnection::stepInto):
2221         (ServerConnection::applicationTerminating):
2222         (ServerConnection::serverConnectionDidDie):
2223         * Drosera/win/ServerConnection.h: Now uses the COM class.
2224
2225 2007-10-24  George Staikos  <staikos@kde.org>
2226
2227         Unbreak Qt build.
2228
2229         * Scripts/build-webkit:
2230
2231 2007-10-24  Adam Roben  <aroben@apple.com>
2232
2233         Remove now-unnecessary call to InitializeCoreGraphics
2234
2235         WebKit takes care of this now.
2236
2237         Reviewed by Ada.
2238
2239         * DumpRenderTree/win/DumpRenderTree.cpp:
2240         (initialize):
2241
2242 2007-10-24  Adam Roben  <aroben@apple.com>
2243
2244         Use WebTextRenderer in DRT
2245
2246         Reviewed by Ada.
2247
2248         * DumpRenderTree/win/DumpRenderTree.cpp:
2249         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2250
2251 2007-10-24  Sven Herzberg  <sven@imendio.com>
2252
2253         Reviewed by Mark Rowe.
2254
2255         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2256         Bug 15614: [GTK] qmake based backends don't build on OS X
2257
2258         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2259         GTK backend on a Mac
2260         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2261         isDarwin() to make it reusable in other places (like the workaround-
2262         for-prebuilt-qmake in build-webkit)
2263
2264 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2265
2266         Refurbish update-webkit script.
2267
2268         Reviewed by Adam.
2269
2270         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2271         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2272         multi-argument version of system() for flexibility and security.  Check for existence
2273         of Internal directory using -d test instead of -x.
2274
2275 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2276
2277         Minor clean-up of prepare-ChangeLog script.
2278
2279         Reviewed by Adam.
2280
2281         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2282         of a string.  Use multi-argument versions of open() and system() for flexibility and
2283         security.
2284
2285 2007-10-24  Alice Liu  <alice.liu@apple.com>
2286
2287         Reviewed by Oliver.
2288
2289         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2290
2291         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
2292         replay the saved events when we're still processing the mousedown that starts the drag
2293         * DumpRenderTree/win/EventSender.cpp:
2294         (doMouseMove):
2295         * DumpRenderTree/win/UIDelegate.cpp:
2296         (UIDelegate::doDragDrop):
2297
2298 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2299
2300         Reviewed by Sam, Steve and Darin.
2301
2302         - Stubbed out the WebScriptDebugListener functionality in the Server
2303         Connection class to prepare it for receiving those callbacks.
2304         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2305         and the ServerConnection to not need to be initialized with a server
2306         name, since that is not the way we connect to the WebKit server.
2307
2308         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2309         no exception.  Now it only loggs when there is an exception
2310         (DebuggerDocument::willExecuteStatement):
2311         (DebuggerDocument::didEnterCallFrame):
2312         (DebuggerDocument::willLeaveCallFrame):
2313         (DebuggerDocument::windowScriptObjectAvailable):
2314         (DebuggerDocument::callFunctionOnObject):
2315         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2316         to be instantiated with a server's name.
2317         (DebuggerClient::DebuggerClient):
2318         (DebuggerClient::didFinishLoadForFrame):
2319         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2320         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2321         a server name.
2322         (Drosera::init):
2323         (Drosera::initServer):
2324         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2325         instantiated with a server's name.
2326         * Drosera/win/ServerConnection.cpp:
2327         (ServerConnection::ServerConnection): No longer needs a server name
2328         (ServerConnection::~ServerConnection): Only release the global context
2329         if there is one.
2330         (ServerConnection::serverConnectionDidDie): Stub for
2331         IWebScriptDebugListener
2332         (ServerConnection::QueryInterface): ditto
2333         (ServerConnection::AddRef): ditto
2334         (ServerConnection::Release): ditto
2335         (ServerConnection::didLoadMainResourceForDataSource): ditto
2336         (ServerConnection::didParseSource): ditto
2337         (ServerConnection::failedToParseSource): ditto
2338         (ServerConnection::didEnterCallFrame): ditto
2339         (ServerConnection::willExecuteStatement): ditto
2340         (ServerConnection::willLeaveCallFrame): ditto
2341         (ServerConnection::exceptionWasRaised): ditto
2342         * Drosera/win/ServerConnection.h: Stubbed out the
2343         IWebScriptDebugListener functions, and this class no longer needs to be
2344         instantiated with a server name.
2345
2346 2007-10-24  Lars Knoll  <lars@trolltech.com>
2347
2348         Reviewed by Simon.
2349
2350         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2351
2352         * DumpRenderTree/qt/jsobjects.h:
2353
2354 2007-10-24  Lars Knoll  <lars@trolltech.com>
2355
2356         Reviewed by Simon.
2357
2358         add another command.
2359
2360         * DumpRenderTree/qt/jsobjects.cpp:
2361         (TextInputController::doCommand):
2362
2363 2007-10-24  Lars Knoll  <lars@trolltech.com>
2364
2365         Reviewed by Simon.
2366
2367         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2368
2369         * DumpRenderTree/qt/jsobjects.cpp:
2370         (EventSender::keyDown):
2371         * DumpRenderTree/qt/jsobjects.h:
2372
2373 2007-10-24  Lars Knoll  <lars@trolltech.com>
2374
2375         Reviewed by Simon.
2376
2377         implement eventSender.keyDown().
2378
2379         * DumpRenderTree/qt/jsobjects.cpp:
2380         (EventSender::keyDown):
2381
2382 2007-10-24  Lars Knoll  <lars@trolltech.com>
2383
2384         Reviewed by Simon.
2385
2386         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2387
2388         * DumpRenderTree/qt/DumpRenderTree.cpp:
2389         (WebCore::DumpRenderTree::DumpRenderTree):
2390         (WebCore::DumpRenderTree::initJSObjects):
2391         * DumpRenderTree/qt/jsobjects.cpp:
2392         (TextInputController::doCommand):
2393
2394 2007-10-24  Lars Knoll  <lars@trolltech.com>
2395
2396         Reviewed by Simon.
2397
2398         first bit of implementation for the textinputcontroller.
2399
2400         * DumpRenderTree/qt/DumpRenderTree.cpp:
2401         (WebCore::DumpRenderTree::DumpRenderTree):
2402         * DumpRenderTree/qt/DumpRenderTree.h:
2403         * DumpRenderTree/qt/jsobjects.cpp:
2404         (TextInputController::TextInputController):
2405         (TextInputController::doCommand):
2406         * DumpRenderTree/qt/jsobjects.h:
2407
2408 2007-10-24  Lars Knoll  <lars@trolltech.com>
2409
2410         Reviewed by Simon.
2411
2412         make the man webpage believe it has focus, so the editing tests work correctly.
2413
2414         * DumpRenderTree/qt/DumpRenderTree.cpp:
2415         (WebCore::DumpRenderTree::DumpRenderTree):
2416
2417 2007-10-24  Lars Knoll  <lars@trolltech.com>
2418
2419         Reviewed by Simon.
2420
2421         implement layoutTestController.dumpEditingCallbacks() correctly.
2422
2423         * DumpRenderTree/qt/DumpRenderTree.cpp:
2424         (WebCore::DumpRenderTree::DumpRenderTree):
2425         * DumpRenderTree/qt/jsobjects.cpp:
2426         (LayoutTestController::reset):
2427         (LayoutTestController::dumpEditingCallbacks):
2428
2429 2007-10-24  Lars Knoll  <lars@trolltech.com>
2430
2431         Reviewed by Simon.
2432
2433         Implement support for testing editing.
2434
2435         * DumpRenderTree/qt/DumpRenderTree.cpp:
2436         (WebCore::DumpRenderTree::DumpRenderTree):
2437
2438 2007-10-23  Sam Weinig  <sam@webkit.org>
2439
2440         Check for null BSTR that can be passed to the UIDelegate methods
2441         from javascript null and undefined.  Fixes a failing test case on
2442         Windows (fast/dom/Window/alert-undefined.html)
2443
2444         Reviewed by Eric Seidel.
2445
2446         * DumpRenderTree/win/UIDelegate.cpp:
2447         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2448         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2449         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2450         (UIDelegate::webViewAddMessageToConsole):
2451
2452 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2453
2454         Reviewed by Darin.
2455
2456         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2457
2458         * Scripts/build-testkjs:
2459
2460 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2461
2462         Reviewed by Darin.
2463
2464         - add wrapper that finds the right copy of testkjs
2465
2466         * Scripts/sunspider-compare-results: Added.
2467
2468 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2469
2470         Reviewed by Sam.
2471
2472         - After talking with Steve I now see that the WebKit server must be
2473         running for DCOM to create the distributed objects, which makes sense
2474         and currently WebKit only allows one instance to be running at a time
2475         which avoids accidentally connecting to the wrong server
2476         - In light of this I have removed the code for the attach box and
2477         NotificationServer and known server names, since they are all extranious
2478         now.
2479
2480         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2481         names.
2482         (_tWinMain): Uses init instead of initUI.
2483         (droseraWndProc): No longer creats an attach dialog box.
2484         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2485         it's not manditory to call init before doing COM stuff.
2486         (Drosera::init): calls initUI and will call attach when the
2487         functionality exists.
2488         (Drosera::initUI): Has changed very little.
2489         (Drosera::attach): Changed the signature to reflect that we no longer
2490         need the dictionary of known server names.
2491         * Drosera/win/Drosera.h: Removed notification classes and known server
2492         names.  Also renamed and moved some functions.
2493         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2494         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2495         headers to the resources folder.
2496         * Drosera/win/resource.h: Removed the Attach box.
2497
2498 2007-10-22  Adam Roben  <aroben@apple.com>
2499
2500         Windows build fix
2501
2502         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2503
2504 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2505
2506         - Removed a leak that was fixed.
2507
2508         * Scripts/run-webkit-tests:
2509
2510 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2511
2512         Reviewed by Darin.
2513
2514         - Changed the Client so that the DebuggerDocument now own the
2515         ServerConnection.  This simplifies ownership and cleanup.
2516
2517         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2518         ServerConnection.
2519         (DebuggerClient::initWithServerName):
2520         (DebuggerClient::didFinishLoadForFrame):
2521         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
2522         ServerConnection.
2523         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2524         until after we have a server which we are attached to.
2525         (Drosera::initUI):
2526         (Drosera::attach):
2527         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2528         out previously.
2529
2530 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2531
2532         Reviewed by Nikolas.
2533
2534         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2535
2536         * Scripts/run-javascriptcore-tests:
2537
2538 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2539
2540         Reviewed by Nikolas.
2541
2542         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2543
2544         * Scripts/build-drosera:
2545         * Scripts/build-dumprendertree:
2546         * Scripts/build-testkjs:
2547         * Scripts/build-webkit:
2548         * Scripts/run-javascriptcore-tests:
2549         * Scripts/run-sunspider:
2550         * Scripts/run-webkit-tests:
2551         * Scripts/webkitdirs.pm:
2552
2553 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2554
2555         Reviewed by Mark Rowe.
2556
2557         Fix for local database support after r26879
2558         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2559
2560         * Scripts/build-webkit:
2561
2562 2007-10-22  Holger Freyther  <zecke@selfish.org>
2563
2564         Reviewed by Simon Hausmann <hausmann@kde.org>.
2565
2566         - Do not build testkjs as an application bundle. This is
2567         needed for run-javascriptcore-tests on OSX.
2568         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2569         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2570         as we do not have -rpath on OSX.
2571
2572         * DumpRenderTree/qt/DumpRenderTree.pro:
2573         * Scripts/run-webkit-tests:
2574
2575 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2576
2577         Reviewed by aroben.
2578
2579         Fix support for Signed-off-by detection in prepare-ChangeLog
2580         --git-commit. The Signed-off-by tag does not appear in the header
2581         but usually at the end.
2582
2583         * Scripts/prepare-ChangeLog:
2584
2585 2007-10-21  Mark Rowe  <mrowe@apple.com>
2586
2587         Reviewed by Eric.
2588
2589         Fix run-javascriptcore-tests for Gtk.
2590
2591         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2592
2593 2007-10-20  Eric Seidel  <eric@webkit.org>
2594
2595         Reviewed by aroben.
2596
2597         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2598
2599 2007-10-20  Eric Seidel  <eric@webkit.org>
2600
2601         Reviewed by darin.
2602
2603         Add improved argument handling to run-sunspider, including
2604         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2605         Also re-factor code into subroutines
2606
2607         * Scripts/build-dumprendertree: removed bogus comments
2608         * Scripts/build-testkjs: Added.
2609         * Scripts/run-javascriptcore-tests: use build-testkjs
2610         * Scripts/run-sunspider: improved argument handling, abstraction
2611         * Scripts/run-webkit-tests: improved abstraction
2612
2613 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2614
2615         Not reviewed, Windows build fix.
2616
2617         * DumpRenderTree/win/EventSender.cpp:
2618         (keyDownCallback):
2619
2620 2007-10-20  Darin Adler  <darin@apple.com>
2621
2622         Reviewed by Tim Hatcher.
2623
2624         - http://bugs.webkit.org/show_bug.cgi?id=15544
2625           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2626           not rely on Apple-specific key codes
2627
2628         * DumpRenderTree/mac/EventSendingController.mm:
2629         (-[EventSendingController keyDown:withModifiers:]):
2630         Added named key "rightArrow". Later we could have a whole table of these.
2631         Also tweaked modifiers code a little.
2632
2633         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2634
2635 2007-10-19  Darin Adler  <darin@apple.com>
2636
2637         Reviewed by Eric.
2638
2639         - http://bugs.webkit.org/show_bug.cgi?id=15566
2640           possible fix for leak seen in DumpRenderTree
2641
2642         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2643         Delete the item if it's not put on the queue, since the caller has
2644         no way of knowing that. Would be better to have the parameter type
2645         be auto_ptr to express the fact that we take ownership.
2646
2647         - unrelated change
2648
2649         * Drosera/mac/main.m: Add missing include.
2650
2651 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2652
2653         Reviewed by Adam.
2654
2655         - This change should be identical but for some reason was not working
2656         on my machine.
2657
2658         * Scripts/prepare-ChangeLog:
2659
2660 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2661
2662         Reviewed by Oliver and Tim.
2663
2664         - Made use of RetainPtr to avoid retain and release issues and moved the
2665         log function to DebuggerDocumentPlatform, which seems to be a more
2666         logical place for it to live.
2667         - Also moved knownServers from the ServerConnection to
2668         DebuggerApplication to match the Windows code and because it makes sense
2669         that a connection knows its own server but not all of them.
2670
2671         * Drosera/mac/DebuggerClient.h: Moved the log function to
2672           DebuggerDocumentPlatform.
2673         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2674           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2675           call for the server name up from the ServerConnection class.
2676         (-[DebuggerClient dealloc]):
2677         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2678           for the server name up from the ServerConnection.
2679         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2680         (DebuggerDocument::platformPause):
2681         (DebuggerDocument::platformResume):
2682         (DebuggerDocument::platformStepInto):
2683         (DebuggerDocument::platformEvaluateScript):
2684         (DebuggerDocument::getPlatformCurrentFunctionStack):
2685         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2686         (DebuggerDocument::platformValueForScopeVariableNamed):
2687         (DebuggerDocument::platformLog): Log directly from here. No need to call
2688           DebuggerClient.
2689         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2690           way I see it, a ServerConnection should only know about its connection
2691           and the group of all possible servers should be kept by the
2692           application.
2693         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2694           currentServerName, it makes sense that the connection should know that
2695           name.
2696         (-[ServerConnection currentServerName]):
2697
2698 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2699
2700         Reviewed by Adam.
2701
2702         - Integrated changes from mac drosera.  Recently I've encapsulated
2703         out the server connection object from the rest of Drosera because
2704         it is very platform dependent right now and RPC is not implemented on
2705         windows.  This functionality, of communicating with the WebKit server
2706         is the next area I will be focusing on in Windows.
2707
2708         - Other changes and cleanup were made to organize the code and add notes
2709         on which parts still need work.  Also some mac code is added and
2710         commented out, to act as pseudocode for the logic of those parts.
2711
2712         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2713           pointer.
2714         * Drosera/config.h: Added whitespace.
2715         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2716           these files got moved into Drosera.h/cpp
2717         * Drosera/win/DebuggerApplication.h: Removed.
2718         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
2719           happened here to better match the logic flow of the same code on the
2720           mac side and to use the new ServerConnection class.
2721         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2722         (DebuggerClient::initWithServerName): Initializer that will set up the
2723           class to use a ServerConnection object.  This was necessary so I could
2724           create a DebuggerClient without having to initilaize it at
2725           construction.
2726         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2727           will be the UIDelegate and FrameLoadDelegate.
2728         (DebuggerClient::AddRef): For IUnknown.
2729         (DebuggerClient::Release): For IUnknown.
2730         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2731           this still needs to set the global context of the server, but
2732           IWebFrame does not have an accessor for the global context yet.
2733         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2734           this is a pass through for the same function in the document.
2735         (DebuggerClient::didReceiveTitle): Unimplemented part of
2736           FrameLoadDelegate this would change the title of the window.
2737         (DebuggerClient::createWebViewWithRequest): Part of the
2738           FrameLoadDelegate.  This is about new windows via Window.open() and
2739           how their delegates are set.
2740         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2741           UIDelegate.  Just a debug function for printing messages.
2742         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2743           because the Client should be the UIDelegate and FrameLoadDelegate
2744           to match the delegates on mac.
2745         (DebuggerClient::webViewLoaded): Added accessor method.
2746         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2747           forgotten to add this file before.  This is where the platform
2748           dependent versions of the Documents functions live. Most of these are
2749           unimplemented because some piece of functionality does not exist on
2750           Windows yet.
2751         (DebuggerDocument::platformPause):
2752         (DebuggerDocument::platformResume):
2753         (DebuggerDocument::platformStepInto):
2754         (DebuggerDocument::platformEvaluateScript):
2755         (DebuggerDocument::getPlatformCurrentFunctionStack):
2756         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2757         (DebuggerDocument::platformValueForScopeVariableNamed):
2758         (DebuggerDocument::platformLog):
2759         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2760           responsibilities becaue they belong in the Client. Also I laid the
2761           groundwork for attaching Drosera to a WebKit process
2762         (attachWndProc): Now if a server is selected the Client becomes it's
2763           delegate.
2764         (Drosera::Drosera): Added the construction of the Client and dictionary
2765           of server names.
2766         (Drosera::initUI): This is no longer the delegates, the Client is.
2767         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2768           state.
2769         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2770           notification registration when it's possible to implement.
2771         (Drosera::serverLoaded): Ditto
2772         (Drosera::serverUnloaded): Ditto
2773         (Drosera::attach): Attach Drosera to the WebKit server.
2774         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2775         (Drosera::getInst):
2776         (Drosera::setInst):
2777         (Drosera::knownServers):
2778         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2779           and added the ServerConnection.
2780         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2781         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2782           Most of the functions are completely unimlemented because they cannot
2783           connect with the WebKit server, because one does not exist on Windows
2784           yet.
2785         (ServerConnection::initWithServerName):
2786         (ServerConnection::~ServerConnection):
2787         (ServerConnection::setGlobalContext):
2788         (ServerConnection::pause):
2789         (ServerConnection::resume):
2790         (ServerConnection::stepInto):
2791         (ServerConnection::switchToServerNamed):
2792         (ServerConnection::applicationTerminating):
2793         (ServerConnection::serverConnectionDidDie):
2794         (ServerConnection::currentFrame):
2795         * Drosera/win/ServerConnection.h: Added. Ditto.
2796         (ServerConnection::ServerConnection):
2797
2798 2007-10-19  Alice Liu  <alice.liu@apple.com>
2799
2800         Reviewed by Darin.
2801
2802         Fix for these broken layout tests on Windows:
2803
2804         fast/forms/focus-selection-input.html
2805         fast/forms/focus-selection-textarea.html
2806         fast/forms/select-accesskey.html
2807
2808         * DumpRenderTree/win/EventSender.cpp:
2809         (keyDownCallback):
2810         correct the VK code for alt key.
2811
2812 2007-10-19  Eric Seidel  <eric@webkit.org>
2813
2814         Reviewed by Mark Rowe.
2815
2816         Make the GtkLauncher code slightly more readable.
2817
2818         * GtkLauncher/main.cpp:
2819         (setupMainMenu): Added.
2820         (setupMainWindowUI): Added.
2821         (main):
2822
2823 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2824
2825         Rubber stamped by Adam.
2826
2827         - don't delay-load WebKit in DumpRenderTree.
2828
2829         * DumpRenderTree/win/DumpRenderTree.vcproj:
2830
2831 2007-10-18  Dan Bernstein  <mitz@apple.com>
2832
2833         Reviewed by Adam Roben.
2834
2835         - fix <rdar://problem/5313523>
2836         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2837
2838         * DumpRenderTree/mac/DumpRenderTree.mm:
2839         (dump): Changed to use _responseMIMEType.
2840
2841 2007-10-17  Adam Roben  <aroben@apple.com>
2842
2843         Make it possible to have Windows-specific tests and results
2844
2845         When searching for tests to run and the Skipped file, we will only
2846         look in platform/win and the cross-platform directory. When looking
2847         for expected results, we will look in platform/win, then
2848         platform/mac-leopard, then platform/mac, then finally the
2849         cross-platform directory.
2850
2851         Reviewed by Sam.
2852
2853         * Scripts/run-webkit-tests:
2854         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2855         searching in the cross-platform directory.
2856         (sub buildPlatformHierarchy): Removed some unneeded calls to
2857         dirname/basename.
2858
2859 2007-10-17  Adam Roben  <aroben@apple.com>
2860
2861         Add back the call to register WebKit that we had before WebKitInitializer existed
2862
2863         This is needed to ensure that the right WebKit is used when
2864         instantiating COM objects.
2865
2866         Reviewed by Oliver.
2867
2868         * DumpRenderTree/win/debug_internal.vsprops: Define
2869         DEBUG_WEBKIT_HAS_SUFFIX.
2870         * DumpRenderTree/win/DumpRenderTree.cpp:
2871         (initialize):
2872
2873 2007-10-17  Adam Roben  <aroben@apple.com>
2874
2875         Import File::Basename in webkitdirs since we use it
2876
2877         * Scripts/webkitdirs.pm:
2878
2879 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2880
2881         - Updated the tiger leaks list to make the internal bots green.
2882
2883         * Scripts/run-webkit-tests:
2884
2885 2007-10-17  Adam Roben  <aroben@apple.com>
2886
2887         Build fix for VC++ Express
2888
2889         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2890         and ole32.lib.
2891
2892 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2893
2894         Reviewed by Sam.
2895
2896         - Minor mac improvements based on observations I made while implementing the
2897         Windows code.
2898
2899         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2900         then hand it to the Client who will retain it, it should just be the client who
2901         creates and owns the server.
2902         (-[DebuggerApplication attach:]):
2903         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2904         * Drosera/mac/DebuggerClient.mm: Creates the server.
2905         (-[DebuggerClient initWithServerName:]):
2906         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2907         can instead forward declare what it needs.
2908
2909 2007-10-16  Darin Adler  <darin@apple.com>
2910
2911         Reviewed by Geoff Garen.
2912
2913         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2914         want to turn failing tests into platform-specific test results. Also did a
2915         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2916         would take the type of results into account only some of the time.
2917
2918 2007-10-16  Adam Roben  <aroben@apple.com>
2919
2920         Add a new nightly launcher script for Windows
2921
2922         This new script is for versions of Safari that don't delay-load
2923         WebKit. I had to make FindSafari be able to print out the nightly
2924         launcher script on stdout because Windows shell scripts can't capture
2925         the output from a command into an environment variable.
2926
2927         Reviewed by Steve.
2928
2929         * FindSafari/FindSafari.cpp:
2930         (_tmain): Added /printSafariLauncher option.
2931         * Scripts/run-webkit-nightly.cmd: Added.
2932
2933 2007-10-16  Adam Roben  <aroben@apple.com>
2934
2935         Replace WebKitInitializer with FindSafari
2936
2937         We now rely on setting the PATH environment variable to tell Windows
2938         where to find WebKit and its dependencies (similar to
2939         DYLD_FRAMEWORK_PATH on Mac).
2940
2941         This change also make DumpRenderTree no longer delay-load WebKit.
2942
2943         Reviewed by Sam.
2944
2945         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2946         FindSafari.
2947         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2948         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2949         WebKitInitializer, don't delay-load WebKit.
2950         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2951         * Scripts/run-webkit-tests: Ditto.
2952         * Scripts/webkitdirs.pm:
2953         (sub setPathForRunningWebKitApp): Added.
2954         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2955         * WebKitInitializer/WebKitInitializer.h: Removed.
2956         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2957         * WebKitInitializer/debug.vsprops: Removed.
2958         * WebKitInitializer/debug_internal.vsprops: Removed.
2959         * WebKitInitializer/release.vsprops: Removed.
2960
2961 2007-10-16  Adam Roben  <aroben@apple.com>
2962
2963         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2964
2965         http://bugs.webkit.org/show_bug.cgi?id=15532
2966
2967         FindSafari simply prints the location of an installed Safari.exe on
2968         stdout.
2969
2970         Reviewed by Darin.
2971
2972         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2973         (getStringValue):
2974         (getWebViewCLSID):
2975         (getInstalledWebKitDirectory):
2976         (_tmain):
2977         * FindSafari/FindSafari.vcproj: Added.
2978         * Scripts/webkitdirs.pm:
2979         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2980
2981 2007-10-16  Adam Roben  <aroben@apple.com>
2982
2983         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2984
2985         Reviewed by Kevin McCullough.
2986
2987         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2988         when referring to WebKit.dll.
2989         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2990         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2991         * DumpRenderTree/win/release.vsprops: Ditto.
2992         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2993         never have a _debug suffix on WebKit.dll.
2994         * WebKitInitializer/WebKitInitializer.cpp:
2995         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2996         specified.
2997         * WebKitInitializer/debug_internal.vsprops: Added
2998         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2999
3000 2007-10-16  Darin Adler  <darin@apple.com>
3001
3002         Reviewed by Adele.
3003
3004         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3005         Remove now-unneeded control/alt key hack; the tests have been updated.
3006
3007 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3008
3009         - Updated leaks list because our internal bot upgraded it's version of leopard and
3010         one of the leaks was fixed between that revision and the bot's previous version of
3011         leopard.
3012
3013         * Scripts/run-webkit-tests:
3014
3015 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3016
3017         Reviewed by Tim.
3018
3019         - I encapsulated out the server connecton functionality because it is a specific part
3020         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3021         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3022         Windows.  So the majority of this patch is moving preexisting functionality.
3023
3024         - Also I removed the prefix header and changed to use config.h because it is more
3025         standard on how we use config.h in windows and it didn't make much sense to keep
3026         the prefix header and the config.h
3027
3028         * Drosera/DebuggerDocument.cpp:
3029         (DebuggerDocument::DebuggerDocument):
3030         * Drosera/DebuggerDocument.h:
3031         * Drosera/config.h:
3032         * Drosera/mac/DebuggerApplication.mm:
3033         (-[DebuggerApplication attach:]):
3034         * Drosera/mac/DebuggerClient.h:
3035         * Drosera/mac/DebuggerClient.mm:
3036         (-[DebuggerClient initWithServerConnection:]):
3037         (-[DebuggerClient dealloc]):
3038         (-[DebuggerClient windowDidLoad]):
3039         (-[DebuggerClient windowWillClose:]):
3040         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3041         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3042         * Drosera/mac/DebuggerDocumentPlatform.mm:
3043         (DebuggerDocument::platformPause):
3044         (DebuggerDocument::platformResume):
3045         (DebuggerDocument::platformStepInto):
3046         (DebuggerDocument::platformEvaluateScript):
3047         (DebuggerDocument::getPlatformCurrentFunctionStack):
3048         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3049         (DebuggerDocument::platformValueForScopeVariableNamed):
3050         (DebuggerDocument::platformLog):
3051         * Drosera/mac/Drosera.pch: Removed.
3052         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3053         * Drosera/mac/ServerConnection.h: Added.
3054         * Drosera/mac/ServerConnection.mm: Added.
3055         (-[ServerConnection initWithServerName:]):
3056         (-[ServerConnection dealloc]):
3057         (-[ServerConnection setGlobalContext:]):
3058         (-[ServerConnection pause]):
3059         (-[ServerConnection resume]):
3060         (-[ServerConnection stepInto]):
3061         (-[ServerConnection switchToServerNamed:]):
3062         (-[ServerConnection applicationTerminating:]):
3063         (-[ServerConnection serverConnectionDidDie:]):
3064         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3065         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3066         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3067         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3068         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3069         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3070         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3071         (-[ServerConnection currentFrame]):
3072         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3073         (-[ServerConnection knownServers]):
3074
3075 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3076
3077         Reviewed by Eric.
3078
3079         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3080           Script to automatically search nightly builds for regressions (bisect-builds)
3081
3082         * Scripts/bisect-builds: Added.
3083
3084 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3085
3086         Reviewed by Darin.
3087
3088         - New JavaScript benchmark
3089         http://bugs.webkit.org/show_bug.cgi?id=15515
3090
3091         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3092         current development or release build of JavaScriptCore.
3093
3094 2007-10-15  Mark Rowe  <mrowe@apple.com>
3095
3096         Reviewed by Sam.
3097
3098         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3099
3100         * Scripts/webkitdirs.pm:
3101         - Change checkArgv to remove the options from @ARGV to prevent
3102         them from interfering with further option processing.
3103         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3104         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3105         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3106         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3107
3108 2007-10-15  Darin Adler  <darin@apple.com>
3109
3110         Reviewed by Sam.
3111
3112         - added logging of window.prompt and window.confirm
3113
3114         * DumpRenderTree/mac/UIDelegate.mm:
3115         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3116         Implement the recommended delegate rather than the deprecated one.
3117         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3118         Added.
3119         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3120         Added.
3121
3122         * DumpRenderTree/win/UIDelegate.h:
3123         * DumpRenderTree/win/UIDelegate.cpp:
3124         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3125         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3126         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3127         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3128
3129 2007-10-15  Alice Liu  <alice.liu@apple.com>
3130
3131         Reviewed by Sam Weinig.
3132
3133         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3134
3135         * DumpRenderTree/win/DumpRenderTree.cpp:
3136         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3137         (main): allocate the global policy delegate for DRT's custom use
3138         * DumpRenderTree/win/DumpRenderTree.vcproj:
3139         Adding files to project
3140         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3141         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3142         (LayoutTestController::setCustomPolicyDelegate):
3143         set the webview's policy delegate to DRT's custom one if the test requests it.
3144         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3145         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3146         (PolicyDelegate::PolicyDelegate):
3147         (PolicyDelegate::QueryInterface):
3148         (PolicyDelegate::AddRef):
3149         (PolicyDelegate::Release):
3150         (PolicyDelegate::decidePolicyForNavigationAction):
3151         * DumpRenderTree/win/PolicyDelegate.h: Added.
3152         (PolicyDelegate::decidePolicyForNewWindowAction):
3153         (PolicyDelegate::decidePolicyForMIMEType):
3154         (PolicyDelegate::unableToImplementPolicyWithError):
3155
3156 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3157
3158         Reviewed by Mark.
3159
3160         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3161         when querying for QMAKE_MKSPECS.
3162
3163 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3164
3165         Reviewed by Adam Roben.
3166
3167         Fix run-webkit-tests is too greedy calculating platform hierarchy
3168         http://bugs.webkit.org/show_bug.cgi?id=15465
3169
3170         Fix run-webkit-tests being too greedy in trying to split the platform name up
3171         causing it to try and find tests in every directory above the first "-" in the
3172         path to the LayoutTests
3173
3174         * Scripts/run-webkit-tests:
3175
3176 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3177
3178         Reviewed by Darin.
3179
3180         http://bugs.webkit.org/show_bug.cgi?id=15006
3181         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3182         to reduce code duplication.
3183
3184         * Scripts/build-webkit:
3185         * Scripts/webkitdirs.pm:
3186         buildQMakeProject() renamed to buildQMakeQtProject().
3187         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3188         unused $colorize has been removed.
3189
3190 === Start merge of feature-branch 2007-10-12 ===
3191
3192 2007-10-08  Eric Seidel  <eric@webkit.org>
3193
3194         Reviewed by Mark Rowe.
3195
3196         * Scripts/build-webkit: add --help, remove unused --color
3197
3198 2007-10-07  Eric Seidel  <eric@webkit.org>
3199
3200         Reviewed by darin.
3201
3202         * Drosera/mac/DebuggerDocumentPlatform.mm:
3203         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3204
3205 2007-10-03  Rob Buis  <buis@kde.org>
3206
3207         Reviewed by Olliej.
3208
3209         Adapt to changed location of Ahem font.
3210
3211         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3212
3213 2007-10-02  Eric Seidel  <eric@webkit.org>
3214
3215         Reviewed by Adam Roben.
3216
3217         Make pixel tests more useful!
3218         Finally fix the image diff 0.00% mystery problem
3219         Highlight any image differences in the image diff.
3220         Add a link from image diffs back to original test file.
3221
3222         * DumpRenderTree/mac/ImageDiff.m:
3223         (compareImages): highlight any differences
3224         (computePercentageDifferent): round to two decimal places
3225         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3226
3227 2007-10-02  Eric Seidel  <eric@webkit.org>
3228
3229         Reviewed by Alexey Proskuryakov.
3230
3231         * Scripts/run-webkit-tests: print the % image difference on main results page
3232
3233 2007-10-02  Mark Rowe  <mrowe@apple.com>
3234
3235         Reviewed by Oliver.
3236
3237         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3238
3239         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3240         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3241
3242 2007-10-01  Mark Rowe  <mrowe@apple.com>
3243
3244         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3245
3246 2007-09-25  Eric Seidel  <eric@webkit.org>
3247
3248         Reviewed by Mark Rowe.
3249
3250         DerivedSources.make was finding "ENABLE_SVG" in the string
3251         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3252         quite correctly.
3253
3254         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3255
3256 2007-09-25  Mark Rowe  <mrowe@apple.com>
3257
3258         Rubber-stamped by Eric.
3259
3260         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3261         This makes it possible to automate nightly builds for the feature-branch.
3262
3263 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3264
3265         Rubber stamped by Mark.
3266
3267         Enable svg experimental features as default here in feature-branch.
3268
3269         * Scripts/build-webkit:
3270
3271 2007-06-29  Antti Koivisto  <antti@apple.com>
3272
3273         Reviewed by Weinig.
3274
3275         Add VIDEO flag for timed media features
3276
3277         * Scripts/build-webkit
3278
3279 === End merge of feature-branch 2007-10-12 ===
3280
3281 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3282
3283         Reviewed by Darin.
3284
3285         - Updated rational for the leaks list to be more clear.
3286
3287         * Scripts/run-webkit-tests:
3288
3289 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3290
3291         Rubber Stamp by Sam.
3292
3293         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3294         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3295
3296         * Scripts/run-webkit-tests:
3297
3298 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3299
3300         Reviewed by Lars.
3301
3302         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3303         includes are needed for INT_MAX, std::auto_ptr and the like.
3304
3305         * DumpRenderTree/qt/main.cpp:
3306
3307 2007-10-09  Lars Knoll  <lars@trolltech.com>
3308
3309         Reviewed by Simon.
3310
3311         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3312
3313         * DumpRenderTree/qt/jsobjects.cpp:
3314         (LayoutTestController::encodeHostName):
3315         (LayoutTestController::decodeHostName):
3316         * DumpRenderTree/qt/jsobjects.h:
3317
3318 2007-10-09  Lars Knoll  <lars@trolltech.com>
3319
3320         Reviewed by Simon.
3321
3322         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3323
3324         * DumpRenderTree/qt/DumpRenderTree.cpp:
3325         (WebCore::WebPage::createFrame):
3326         (WebCore::DumpRenderTree::DumpRenderTree):
3327         (WebCore::DumpRenderTree::titleChanged):
3328         * DumpRenderTree/qt/DumpRenderTree.h:
3329         * DumpRenderTree/qt/jsobjects.cpp:
3330         (LayoutTestController::reset):
3331         * DumpRenderTree/qt/jsobjects.h:
3332
3333 2007-10-09  Lars Knoll  <lars@trolltech.com>
3334
3335         Reviewed by Simon.
3336
3337         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3338
3339         * DumpRenderTree/qt/DumpRenderTree.h:
3340         * DumpRenderTree/qt/jsobjects.cpp:
3341         (LayoutTestController::clearBackForwardList):
3342         * DumpRenderTree/qt/jsobjects.h:
3343
3344 2007-10-09  Lars Knoll  <lars@trolltech.com>
3345
3346         Reviewed by Simon.
3347
3348         make --git-reviewer work again.
3349
3350         * Scripts/prepare-ChangeLog:
3351
3352 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3353
3354         Rubber stamped by Eric.
3355
3356         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3357         show the current link inside the statusbar.
3358         This shows how to make use of this signal and allows to easily test
3359         http://bugs.webkit.org/show_bug.cgi?id=15299.
3360
3361         * GtkLauncher/main.cpp:
3362         (hoveringOverLink):
3363         (main):
3364
3365 2007-10-05  Lars Knoll  <lars@trolltech.com>
3366
3367         add proper error messages to the FrameLoaderClient.
3368         Implement ChromeClientQt::closeWindowSoon and
3369         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3370         Some fixes in DRT to make it work correctly with multiple windows.
3371
3372         Reviewed by Maciej.
3373
3374         * DumpRenderTree/qt/DumpRenderTree.cpp:
3375         (WebCore::DumpRenderTree::DumpRenderTree):
3376         (WebCore::DumpRenderTree::createWindow):
3377         (WebCore::DumpRenderTree::windowCount):
3378         * DumpRenderTree/qt/DumpRenderTree.h:
3379         * DumpRenderTree/qt/jsobjects.cpp:
3380         (LayoutTestController::maybeDump):
3381         (LayoutTestController::windowCount):
3382         * DumpRenderTree/qt/jsobjects.h:
3383
3384 2007-10-05  Lars Knoll  <lars@trolltech.com>
3385
3386         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3387         Add support for layoutTextController.setCanOpenWindows() to DRT
3388         fixing another 2 test cases in fast/dom/Window.
3389
3390         Reviewed by Maciej.
3391
3392         * DumpRenderTree/qt/DumpRenderTree.cpp:
3393         (WebCore::WebPage::WebPage):
3394         (WebCore::WebPage::createWindow):
3395         (WebCore::DumpRenderTree::resetJSObjects):
3396         (WebCore::DumpRenderTree::createWindow):
3397         * DumpRenderTree/qt/DumpRenderTree.h:
3398         * DumpRenderTree/qt/DumpRenderTree.pro:
3399         * DumpRenderTree/qt/jsobjects.cpp:
3400         (LayoutTestController::LayoutTestController):
3401         (LayoutTestController::reset):
3402         * DumpRenderTree/qt/jsobjects.h:
3403         * DumpRenderTree/qt/main.cpp:
3404         * DumpRenderTree/qt/testplugin.cpp: Added.
3405         * DumpRenderTree/qt/testplugin.h: Added.
3406
3407 2007-10-04  Sam Weinig  <sam@webkit.org>
3408
3409         Rubber stamped by Adam.
3410
3411         Remove empty directories.
3412
3413         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3414         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3415
3416 2007-10-03  Darin Adler  <darin@apple.com>
3417
3418         Reviewed by Adam.
3419
3420         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3421         we find the internal libraries in the libraries directory. This
3422         is helpful for Safari team engineers at Apple.
3423
3424 2007-10-03  Adam Roben  <aroben@apple.com>
3425
3426         Update the location of AHEM___.TTF after r25968
3427
3428         Reviewed by Sam.
3429
3430         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3431
3432 2007-10-03  Alp Toker  <alp@atoker.com>
3433
3434         Reviewed by Adam.
3435
3436         http://bugs.webkit.org/show_bug.cgi?id=14726
3437         [gtk] API design. Mapping the WebView delegates to signals.
3438
3439         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3440
3441         * GtkLauncher/main.cpp:
3442         (goToURLBarText):
3443         (titleChanged):
3444         (progressChanged):
3445         (menuMainBackCallback):
3446         (menuMainForwardCallback):
3447         (main):
3448
3449 2007-10-03  Lars Knoll  <lars@trolltech.com>
3450
3451         Reviewed by Rob.
3452
3453         This fixes --strict mode in run-webkit-tests again after
3454         the platform dependent test results have been moved.
3455
3456         * Scripts/run-webkit-tests:
3457
3458 2007-10-03  Lars Knoll  <lars@trolltech.com>
3459
3460         Reviewed by bdash.
3461
3462         remove the hack in run-webkit-tests that forced text only test
3463         to be taken from the platform independent dir. It was only left
3464         there from early days.
3465
3466         Remove platform dependent results for tests that are text only nowadays,
3467         and add one platform dependent result for a text only test that requires it.
3468
3469         * Scripts/run-webkit-tests:
3470
3471 2007-10-03  Lars Knoll  <lars@trolltech.com>
3472
3473         Reviewed by olliej.
3474
3475         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3476
3477         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3478         (WebCore::WebFrame::WebFrame):
3479         (WebCore::WebPage::WebPage):
3480         (WebCore::WebPage::createFrame):
3481         (WebCore::WebPage::javaScriptAlert):
3482         (WebCore::WebPage::javaScriptConsoleMessage):
3483         (WebCore::DumpRenderTree::DumpRenderTree):
3484         (WebCore::DumpRenderTree::~DumpRenderTree):
3485         (WebCore::DumpRenderTree::open):
3486         (WebCore::DumpRenderTree::readStdin):
3487         (WebCore::DumpRenderTree::resetJSObjects):
3488         (WebCore::DumpRenderTree::initJSObjects):
3489         (WebCore::DumpRenderTree::dumpFramesAsText):
3490         (WebCore::DumpRenderTree::dump):
3491         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3492         (WebCore::DumpRenderTree::layoutTestController):
3493         (WebCore::DumpRenderTree::eventSender):
3494         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3495         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3496         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3497         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3498         (HackWebFrame::mousePressEvent):
3499         (HackWebFrame::mouseReleaseEvent):
3500         (HackWebFrame::mouseMoveEvent):
3501         (HackWebFrame::HackWebFrame):
3502         (HackWebFrame::~HackWebFrame):
3503         (LayoutTestController::LayoutTestController):
3504         (LayoutTestController::reset):
3505         (LayoutTestController::maybeDump):
3506         (LayoutTestController::waitUntilDone):
3507         (LayoutTestController::notifyDone):
3508         (LayoutTestController::dumpEditingCallbacks):
3509         (LayoutTestController::queueReload):
3510         (LayoutTestController::provisionalLoad):
3511         (LayoutTestController::timerEvent):
3512         (EventSender::EventSender):
3513         (EventSender::mouseDown):
3514         (EventSender::mouseUp):
3515         (EventSender::mouseMoveTo):
3516         (EventSender::leapForward):
3517         (EventSender::keyDown):
3518         (EventSender::frameUnderMouse):
3519         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3520         (LayoutTestController::isLoading):
3521         (LayoutTestController::setLoading):
3522         (LayoutTestController::shouldDumpAsText):
3523         (LayoutTestController::shouldDumpChildrenAsText):
3524         (LayoutTestController::shouldWaitUntilDone):
3525         (LayoutTestController::dumpAsText):
3526         (LayoutTestController::dumpChildFramesAsText):
3527         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3528         (messageHandler):
3529         (crashHandler):
3530         (main):
3531         * Scripts/run-webkit-tests:
3532
3533 2007-10-03  Mark Rowe  <mrowe@apple.com>
3534
3535         Reviewed by Alp Toker.
3536
3537         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3538         should take precedence over QTDIR when determining which port we are working with.
3539
3540         * Scripts/webkitdirs.pm:
3541
3542 2007-10-02  Adam Roben  <aroben@apple.com>
3543
3544         Add keychain to the list of default packages to install
3545
3546         Rubberstamped by Sam.
3547
3548         * CygwinDownloader/cygwin-downloader.py:
3549         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3550
3551 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3552
3553         Reviewed by Adam.
3554
3555         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3556         Also makes WebCore regression test case logic work when using git.
3557
3558         * Scripts/prepare-ChangeLog:
3559         (reviewerAndDescriptionForGitCommit): Added.
3560
3561 2007-10-02  Lars Knoll  <lars@trolltech.com>
3562
3563         Reviewed by bdash.
3564
3565         Add API to retrieve the frame name from QWebFrame.
3566         Implement support for DRT::dumpChildrenAsText.
3567
3568         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3569         (WebCore::DumpRenderTree::dumpFramesAsText):
3570         (WebCore::DumpRenderTree::dump):
3571         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3572         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3573         (LayoutTestController::LayoutTestController):
3574         (LayoutTestController::reset):
3575         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3576
3577 2007-10-02  Lars Knoll  <lars@trolltech.com>
3578
3579         Reviewed by bdash.
3580
3581         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3582
3583         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3584         (WebCore::DumpRenderTree::readStdin):
3585
3586 2007-10-02  Mark Rowe  <mrowe@apple.com>
3587
3588         Reviewed by Oliver.
3589
3590         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3591
3592         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3593         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3594
3595 2007-10-02  Mark Rowe  <mrowe@apple.com>
3596
3597         Rubber-stamped by Maciej.
3598
3599         Configuration changes from build.webkit.org.  The major change is refactoring to work
3600         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3601         last few weeks.
3602
3603         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3604         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3605         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3606         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3607         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3608         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3609         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3610