2010-04-01 Eric Seidel <eric@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-04-01  Eric Seidel  <eric@webkit.org>
2
3         Unreviewed, only ignoring chatty style errors.
4
5         check-webkit-style: WebKit needs a python style checker
6         https://bugs.webkit.org/show_bug.cgi?id=33639
7
8         Remove the 79 char line limit by ignoring 
9         pep8/E501.  Because we have our own report_error
10         implementation we have to ignore E501 by hand
11         instead of passing --ignore=E501.
12
13         Right now over 1400 lines of our existing python
14         fail E501 so this rule just generates needless noise.
15         The rest of WebKit has no wrapping rule so it makes
16         little sense for our Python to differ here.
17
18         * Scripts/webkitpy/style/processors/python.py:
19
20 2010-04-01  Adam Barth  <abarth@webkit.org>
21
22         Unreviewed.  Add cmarrin's IRC nickname.
23
24         * Scripts/webkitpy/common/config/committers.py:
25
26 2010-04-01  Adam Barth  <abarth@webkit.org>
27
28         Unreviewed.
29
30         EWS spins hot when unable to build
31         https://bugs.webkit.org/show_bug.cgi?id=36981
32
33         The problem is that the queue engine things we have more work to do,
34         but the bot isn't actually able to do anything.  After this change, we
35         back off the usual amount.
36
37         * Scripts/webkitpy/tool/bot/queueengine.py:
38         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
39         * Scripts/webkitpy/tool/commands/queues.py:
40         * Scripts/webkitpy/tool/commands/sheriffbot.py:
41
42 2010-04-01  Chris Marrin  <cmarrin@apple.com>
43
44         Reviewed by Simon Fraser.
45
46         Added layerTreeAsText function to DRT (for Mac)
47         https://bugs.webkit.org/show_bug.cgi?id=36782
48
49         This is the DRT side. It exposes the call to JavaScript
50         through the LayoutTestController.
51
52         * DumpRenderTree/LayoutTestController.cpp:Platform independent JavaScript shim
53         (layerTreeAsTextCallback):
54         (LayoutTestController::staticFunctions):
55         * DumpRenderTree/LayoutTestController.h:
56         * DumpRenderTree/mac/LayoutTestControllerMac.mm:Mac specific plumbing to WebKit
57         (LayoutTestController::layerTreeAsText):
58         * DumpRenderTree/win/LayoutTestControllerWin.cpp:Windows specific plumbing to WebKit
59         (LayoutTestController::layerTreeAsText):
60
61 2010-04-01  Kevin Ollivier  <kevino@theolliviers.com>
62
63         [wx] Build fix after addition of JavaScriptCore/wtf/text directory.
64
65         * wx/build/settings.py:
66
67 2010-04-01  Jian Li  <jianli@chromium.org>
68
69         Rubber-stamped by David Levin.
70
71         Add myself to the reviewers list.
72
73         * Scripts/webkitpy/common/config/committers.py:
74
75 2010-04-01  Adam Barth  <abarth@webkit.org>
76
77         Unreviewed.
78
79         Turns out the Chromium Windows bots don't have pdevenv installed.
80
81         * Scripts/webkitdirs.pm:
82
83 2010-04-01  Adam Barth  <abarth@webkit.org>
84
85         Reviewed by Dimitri Glazkov.
86
87         Let Chromium Windows build with Visual Studio Express
88         https://bugs.webkit.org/show_bug.cgi?id=36919
89
90         This is horrible, horrible copy/paste code, but that seems to be the
91         way of webkitdirs.pm.  :(
92
93         Someone needs to go through an cleanup this code, but I don't have the
94         heart to do it in this patch.
95
96         * Scripts/webkitdirs.pm:
97
98 2010-04-01  Ilya Tikhonovsky  <loislo@chromium.org>
99
100         Reviewed by Yury Semikhatsky.
101
102         Add myself to the committers list.
103         https://bugs.webkit.org/show_bug.cgi?id=36953
104
105         * Scripts/webkitpy/common/config/committers.py:
106
107 2010-04-01  Eric Seidel  <eric@webkit.org>
108
109         Rubber-stamped by Adam Barth.
110
111         Add Snow Leopard Release bot to the list of "core builders" (builders which stop the commit-queue when they turn red)
112         https://bugs.webkit.org/show_bug.cgi?id=33292
113
114         Just adding the "Build" builder for now.
115         We'll add the "Test" builders when the tests
116         are less flaky.
117
118         * Scripts/webkitpy/common/net/buildbot.py:
119         * Scripts/webkitpy/common/net/buildbot_unittest.py:
120
121 2010-04-01  Yury Semikhatsky  <yurys@chromium.org>
122
123         Reviewed by David Levin.
124
125         Add myself to the reviewers list.
126
127         https://bugs.webkit.org/show_bug.cgi?id=36935
128
129         * Scripts/webkitpy/common/config/committers.py:
130
131 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
132
133         Reviewed by Dave Levin.
134
135         Added Python style checking to check-webkit-style using
136         the third-party pep8 module (via autoinstall).
137
138         https://bugs.webkit.org/show_bug.cgi?id=33639
139
140         * Scripts/webkitpy/style/checker.py:
141           - Added PYTHON to FileType.
142           - Updated ProcessorDispatcher to return a PythonProcessor
143             for *.py files.
144
145         * Scripts/webkitpy/style/checker_unittest.py:
146           - Updated the ProcessorDispatcher unit tests for *.py files.
147
148         * Scripts/webkitpy/style/processors/python.py: Added.
149           - Added PythonProcessor class.
150
151         * Scripts/webkitpy/style/processors/python_unittest.py: Added.
152           - Added PythonProcessor unit tests.
153
154         * Scripts/webkitpy/style/processors/python_unittest_input.py: Added.
155           - Added a sample Python file to test the PythonProcessor.process()
156             code path (since pep8 accepts a file path).
157
158         * Scripts/webkitpy/style/unittests.py:
159           - Updated the style unit test file to import python_unittest.py.
160
161         * Scripts/webkitpy/style_references.py:
162           - Adjusted style references to import pep8.
163
164 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
165
166         Reviewed by Dave Levin.
167
168         Rewrote autoinstall.py to support unzipping *.zip files after
169         download, unzipping and extracting *.tar.gz files after download,
170         and copying installed files to a given destination directory.
171
172         https://bugs.webkit.org/show_bug.cgi?id=35163
173
174         These changes will let us autoinstall pep8.py from the web and put
175         our third-party autoinstalled code in an explicit directory like
176         webkitpy/thirdparty/autoinstalled. These changes should also speed
177         up the execution of autoinstalled *.zip packages slightly since
178         *.pyc files cannot be generated when importing from zipped
179         packages using the current autoinstall.
180
181         * Scripts/test-webkitpy:
182           - Addressed the FIXME to enable auto-install logging once
183             autoinstall was rewritten not to log as verbosely.
184
185         * Scripts/webkitpy/common/net/bugzilla.py:
186           - Updated mechanize import statement.
187
188         * Scripts/webkitpy/common/net/buildbot.py:
189           - Updated mechanize import statement.
190
191         * Scripts/webkitpy/common/net/irc/ircbot.py:
192           - Updated ircbot and irclib import statements.
193
194         * Scripts/webkitpy/common/net/networktransaction.py:
195           - Updated mechanize import statement.
196
197         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
198           - Updated mechanize import statement.
199
200         * Scripts/webkitpy/common/net/statusserver.py:
201           - Updated mechanize import statement.
202
203         * Scripts/webkitpy/common/system/autoinstall.py: Added.
204           - Added AutoInstaller class.
205           - Added sample/testing usage to the __main__ block.
206
207         * Scripts/webkitpy/thirdparty/__init__.py:
208           - Updated the autoinstall lines to use the new autoinstall methods.
209           - Added pep8.py to the list of auto-installed packages.
210           - Added a README file to the target autoinstallation directory
211             so users know that the directory is safe to delete.
212
213         * Scripts/webkitpy/thirdparty/autoinstall.py: Removed.
214           - This is replaced by the rewritten autoinstall
215             webkitpy/common/system/autoinstall.py.
216
217         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: Removed.
218           - The target autoinstallation directory is now auto-generated.
219
220 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
221
222         Reviewed by Shinichiro Hamaji.
223
224         Tweak webkitpy's logtesting.LogTesting class to get more mileage out
225         of our unit tests that test log messages.
226
227         https://bugs.webkit.org/show_bug.cgi?id=36886
228
229         This patch adds to the LogTesting class's tearDown() method a line
230         asserting that the array of remaining log messages is empty.  This
231         ensures that no extra log messages are getting logged that the caller
232         might not be aware of or may have forgotten to check for.
233
234         * Scripts/webkitpy/common/system/logtesting.py:
235           - Modified the tearDown() method as described above.
236           - Also modified the assertMessages() method to clear the array
237             of log messages after asserting.
238
239 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
240
241         Reviewed by Adam Barth.
242
243         Added support for a --verbose-logging flag to test-webkitpy.
244
245         https://bugs.webkit.org/show_bug.cgi?id=36429
246
247         Verbose logging is useful for debugging test-webkitpy code that
248         runs before the actual unit tests -- things like autoinstalling and
249         unit-test auto-detection logic.  This is different from verbose
250         logging of the unit tests themselves (which corresponds to the
251         unittest module's --verbose flag).
252
253         * Scripts/test-webkitpy:
254           - In the configure_logging() method--
255             - Added an is_verbose_logging parameter that sets the logging
256               level to logging.DEBUG instead of logging.INFO.
257             - Changed the method to throttle the logging level on the
258               root logger's handler instead of directly on the root logger
259               itself.
260             - Enabled logging of the autoinstall module when the flag is set.
261
262         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:
263           - Added a work-around for a bug in Python 2.6's logging module
264             that was discovered while working on this patch.
265
266 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
267
268         Reviewed by Adam Barth.
269
270         Enabled Python's logging module for webkit-patch, and replaced
271         deprecated_logging with Python logging in networktransaction.py.
272         This eliminates some spurious output when running test-webkitpy.
273
274         https://bugs.webkit.org/show_bug.cgi?id=36725
275
276         * Scripts/webkit-patch:
277           - Replaced the configure_logging() function with a call to
278             the new logutils.configure_logging() function.
279
280         * Scripts/webkitpy/common/net/networktransaction.py:
281           - Replaced the use of deprecated_logging with Python logging.
282
283         * Scripts/webkitpy/common/system/logutils.py:
284           - Added _default_handlers() which creates the default logging
285             handler for webkitpy.
286           - Added configure_logging() which configures default logging
287             for webkitpy.
288
289         * Scripts/webkitpy/common/system/logutils_unittest.py:
290           - Added unit tests for logutils.configure_logging().
291
292         * Scripts/webkitpy/style/checker.py:
293           - Refactored check-webkit-style's configure_logging() method
294             to call the new logutils.configure_logging().
295
296         * Scripts/webkitpy/style_references.py:
297           - Updated references as necessary.
298
299 2010-03-31  Eric Seidel  <eric@webkit.org>
300
301         Reviewed by Adam Barth.
302
303         webkit-patch land fails if not run from the root directory
304         https://bugs.webkit.org/show_bug.cgi?id=35822
305
306         The root of the problem was that ChangeLog.__init__ expects a path
307         relative to the current working directory, and SCM expects to
308         return paths relative to the SCM root.  Fix it by converting from
309         SCM-relative to absolute paths in Checkout.modified_changelogs
310
311         * Scripts/webkitpy/common/checkout/api.py:
312         * Scripts/webkitpy/common/checkout/api_unittest.py:
313
314 2010-03-31  Adam Barth  <abarth@webkit.org>
315
316         Reviewed by Eric Seidel.
317
318         Add more tests for webkitpy.common.checkout
319         https://bugs.webkit.org/show_bug.cgi?id=36926
320
321         We don't have a great way of testing checkout, sadly.
322
323         * Scripts/webkitpy/common/checkout/api_unittest.py:
324
325 2010-03-31  Adam Barth  <abarth@webkit.org>
326
327         Reviewed by Eric Seidel.
328
329         REGRESSION: EWS crashes on failure
330         https://bugs.webkit.org/show_bug.cgi?id=36924
331
332         Turns out we need to pass one more argument.  My test is kind of lame,
333         but at least it's there.
334
335         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
336         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
337
338 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
339
340         Unreviewed.
341
342         Fixed typo in WebKitTools/ChangeLog: opsys -> ospath.
343
344 2010-03-31  Adam Barth  <abarth@webkit.org>
345
346         Reviewed by Eric Seidel.
347
348         Make the EWS go faster by being optimistic
349         https://bugs.webkit.org/show_bug.cgi?id=36916
350
351         Have the EWS be optimistic that a patch will correctly build.  This
352         should speed up the common case by not requiring two builds for every
353         patch.
354
355         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
356         * Scripts/webkitpy/tool/commands/queues.py:
357
358 2010-03-31  Adam Barth  <abarth@webkit.org>
359
360         Reviewed by Eric Seidel.
361
362         Add the ability to restart sheriffbot from IRC
363         https://bugs.webkit.org/show_bug.cgi?id=36909
364
365         * Scripts/webkitpy/tool/bot/irc_command.py:
366         * Scripts/webkitpy/tool/bot/queueengine.py:
367         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
368         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
369
370 2010-03-31  Adam Barth  <abarth@webkit.org>
371
372         Reviewed by Eric Seidel.
373
374         Add win-ews to QueueStatusServer
375         https://bugs.webkit.org/show_bug.cgi?id=36876
376
377         The win-ews is still experimental, but it seems to be more or less
378         running.  We should show its results to the people.
379
380         * QueueStatusServer/model/queues.py:
381         * QueueStatusServer/templates/dashboard.html:
382         * QueueStatusServer/templates/statusbubble.html:
383
384 2010-03-30  Victor Wang  <victorw@chromium.org>
385
386         Reviewed by Eric Seidel.
387
388         Update rebaseline tool to check the release image diff binary and
389         fallback to debug if the release version does not exist.
390
391         https://bugs.webkit.org/show_bug.cgi?id=36245
392
393         * Scripts/webkitpy/layout_tests/port/base.py:
394         * Scripts/webkitpy/layout_tests/port/chromium.py:
395         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
396
397 2010-03-31  Eric Seidel  <eric@webkit.org>
398
399         Reviewed by Adam Barth.
400
401         Teach buildbot.py how to parse builder activity from /one_box_per_builder
402         https://bugs.webkit.org/show_bug.cgi?id=36898
403
404         I also removed some obsolete FIXMEs and
405         refactored one_box_per_builder parsing into multiple
406         methods for easier reading.
407
408         * Scripts/webkitpy/common/net/buildbot.py:
409         * Scripts/webkitpy/common/net/buildbot_unittest.py:
410
411 2010-03-31  Dirk Pranke  <dpranke@chromium.org>
412
413         Reviewed by Eric Seidel.
414
415         Fix logging in new-run-webkit-tests so that we don't report IMAGE
416         expected failures as unexpected passes when we run with pixel tests
417         disabled.
418
419         This change splits some of the logic embedded into the TestExpectations
420         classes out into separate pure functions (result_was_expected,
421         remove_image_failures) to make them easier to test. This also adds
422         a parameter to matches_an_expected_result() to indicate whether or
423         not pixel test results should be included in the expectations.
424
425         https://bugs.webkit.org/show_bug.cgi?id=36771
426
427         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
428         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py:
429         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
430
431 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
432
433         Reviewed by Eric Seidel.
434
435         In webkitpy, refactored two calls to os.path.relpath() replacements
436         to use a common method.
437
438         https://bugs.webkit.org/show_bug.cgi?id=36891
439
440         * Scripts/webkitpy/common/net/bugzilla.py:
441           - Replaced the relpath implementation with a call to
442             webkitpy.common.system.ospath.relpath().
443
444         * Scripts/webkitpy/common/system/ospath.py: Added.
445           - Moved the relpath() implementation from style/main.py.
446
447         * Scripts/webkitpy/common/system/ospath_unittest.py: Added.
448           - Moved the relpath() unit tests from style/main_unittest.py.
449
450         * Scripts/webkitpy/style/main.py:
451           - Replaced the relpath implementation with a call to
452             webkitpy.common.system.ospath.relpath().
453
454         * Scripts/webkitpy/style/main_unittest.py:
455           - Moved the relpath unit tests to ospath_unittest.py.
456
457 2010-03-31  Adam Barth  <abarth@webkit.org>
458
459         Reviewed by Eric Seidel.
460
461         Add a Builder.force_build method
462         https://bugs.webkit.org/show_bug.cgi?id=36875
463
464         We plan to eventually use this in SheriffBot to break deadlocks created
465         by flaky tests.
466
467         * Scripts/webkitpy/common/net/buildbot.py:
468
469 2010-03-31  Adam Barth  <abarth@webkit.org>
470
471         Reviewed by Eric Seidel.
472
473         webkit-patch reads wrong bug url from unified diff context
474         https://bugs.webkit.org/show_bug.cgi?id=36477
475
476         Instead of trying to figure out the bug_id from the diff, we should
477         just get the information from the Checkout object, which understands
478         these concepts.
479
480         * Scripts/webkitpy/common/checkout/api.py:
481         * Scripts/webkitpy/common/checkout/commitinfo.py:
482         * Scripts/webkitpy/tool/commands/download.py:
483         * Scripts/webkitpy/tool/commands/upload.py:
484         * Scripts/webkitpy/tool/mocktool.py:
485
486 2010-03-31  Adam Barth  <abarth@webkit.org>
487
488         Reviewed by Eric Seidel.
489
490         webkit-patch commit-queue should land patches optimistically
491         https://bugs.webkit.org/show_bug.cgi?id=34187
492
493         This patch adds an optimistic path to commit-queue and a "fail twice"
494         requirement for rejecting patches.  That means we'll land good patches
495         faster (via the optmistic first run) and we'll reject many fewer
496         patches due to flaky tests.
497
498         * Scripts/webkitpy/tool/commands/queues.py:
499
500 2010-03-31  Diego Gonzalez  <diego.gonzalez@openbossa.org>
501
502         Reviewed by Kenneth Rohde Christiansen.
503
504         [Qt] Custom user agent for user agent switcher
505         https://bugs.webkit.org/show_bug.cgi?id=36757
506
507         * QtLauncher/main.cpp:
508         (LauncherWindow::showUserAgentDialog):
509
510 2010-03-31  Eric Seidel  <eric@webkit.org>
511
512         Reviewed by Adam Barth.
513
514         path to committers.py in commit-queue rejection message is wrong
515         https://bugs.webkit.org/show_bug.cgi?id=36865
516
517         This fix would have only been 3 lines long if we had
518         1. Had access to an SCM object or tool to give us the checkout root
519         2. Been able to depend on Python 2.6
520         Instead I've added a bunch of hack code, but at least now
521         we should never have to update this string again as the location
522         of committers.py is fully dynamically discovered. :p
523
524         * Scripts/webkitpy/common/net/bugzilla.py:
525         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
526
527 2010-03-31  Shinichiro Hamaji  <hamaji@chromium.org>
528
529         Unreviewed test fix for r56809.
530
531         webkit-patch what-broke throws exception
532         https://bugs.webkit.org/show_bug.cgi?id=36852
533
534         * Scripts/webkitpy/common/checkout/api_unittest.py:
535
536 2010-03-30  Chris Jerdonek  <cjerdonek@webkit.org>
537
538         Rubber stamped by Dave Levin.
539
540         Made check-webkit-style less chatty.
541
542         Examples include:
543          - https://bugs.webkit.org/show_bug.cgi?id=36866#c4
544          - https://bugs.webkit.org/show_bug.cgi?id=36472#c9
545
546         * Scripts/webkitpy/style/checker.py:
547           - Changed unrecognized file type log message from info to debug.
548
549 2010-03-30  Kevin Ollivier  <kevino@theolliviers.com>
550
551         [wx] Build fix after new method added.
552
553         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
554         (LayoutTestController::callShouldCloseOnWebView):
555
556 2010-03-30  Eric Seidel  <eric@webkit.org>
557
558         Reviewed by Adam Barth.
559
560         webkit-patch what-broke throws exception
561         https://bugs.webkit.org/show_bug.cgi?id=36852
562
563         * Scripts/webkitpy/common/checkout/api.py: Add missing import StringIO.
564         * Scripts/webkitpy/common/checkout/api_unittest.py: Test the function which previously threw and exception.
565
566 2010-03-30  Alexey Proskuryakov  <ap@apple.com>
567
568         Reviewed by Darin Adler.
569
570         https://bugs.webkit.org/show_bug.cgi?id=36616
571         Dvorak-Qwerty keyboard layout gives unexpected results in javascript keydown
572
573         https://bugs.webkit.org/show_bug.cgi?id=36797
574         For non-Roman layouts, keydown Event.keyCode is always 0
575
576         * DumpRenderTree/mac/EventSendingController.mm:
577         (-[EventSendingController keyDown:withModifiers:withLocation:]): Generate a correct keyCode
578         for keys used in tests (we used to always pass 0 for 'A').
579
580 2010-03-30  Adam Barth  <abarth@webkit.org>
581
582         Reviewed by Eric Seidel.
583
584         Implement win-ews
585         https://bugs.webkit.org/show_bug.cgi?id=36809
586
587         * Scripts/webkitpy/common/config/ports.py:
588         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
589
590 2010-03-30  Chris Jerdonek  <cjerdonek@webkit.org>
591
592         Reviewed by Eric Seidel.
593
594         Adjusted test-webkitpy to delete all orphaned *.pyc files
595         from webkitpy/ prior to importing any modules from webkitpy.
596         This ensures that no import statements in webkitpy falsely
597         succeed because of leftover *.pyc files.
598
599         https://bugs.webkit.org/show_bug.cgi?id=36599
600
601         * Scripts/test-webkitpy:
602           - Added _clean_pyc_files() to delete orphaned *.pyc files
603             from a directory.
604           - Added _clean_webkitpy_with_test() to call and test
605             _clean_pyc_files().
606           - Moved the "import webkitpy.python24.versioning" statement
607             from the top of the module to the init() method -- immediately
608             after the call to _clean_webkitpy_with_test().
609
610 2010-03-30  Fumitoshi Ukai  <ukai@chromium.org>
611
612         Reviewed by Shinichiro Hamaji.
613
614         [Chromium-Win] subprocess.call should be called with stdin=open(os.devnull,'r')
615         https://bugs.webkit.org/show_bug.cgi?id=36811
616
617         subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
618         We don't need stdin, so use devnull as stdin.
619         Same as https://bugs.webkit.org/show_bug.cgi?id=36586
620
621         * Scripts/webkitpy/layout_tests/port/chromium_win.py: open os.devnull for stdin
622
623 2010-03-29  Eric Seidel  <eric@webkit.org>
624
625         Unreviewed, build fix only.
626
627         * Scripts/webkitpy/tool/steps/validatereviewer.py: Add missing import.
628
629 2010-03-29  Hayato Ito  <hayato@chromium.org>
630
631         Reviewed by Shinichiro Hamaji.
632
633         Remove '_flymake' suffix from base part of file name so that
634         check-webkit-style uses a correct header guard name when it is called from Emacs's flymake.
635
636         https://bugs.webkit.org/show_bug.cgi?id=36573
637
638         * Scripts/webkitpy/style/processors/cpp.py:
639         * Scripts/webkitpy/style/processors/cpp_unittest.py:
640
641 2010-03-29  Chris Jerdonek  <cjerdonek@webkit.org>
642
643         Reviewed by Eric Seidel.
644
645         Get the following test-webkitpy unit test working again:
646         scm_unittest.SVNTest.test_svn_apply().
647
648         https://bugs.webkit.org/show_bug.cgi?id=36696
649
650         * Scripts/webkitpy/common/checkout/scm_unittest.py:
651           - Add leading spaces to the empty lines of the ChangeLog strings.
652           - Manually set the _reviewer attribute on the Attachment object
653             to get the tests to pass.
654
655 2010-03-29  Martin Robinson  <mrobinson@webkit.org>
656
657         Reviewed by Holger Freyther.
658
659         [GTK] suppress (un)desired launcher output that can make layout test to fail with stderr
660         https://bugs.webkit.org/show_bug.cgi?id=36390
661
662         Suppress debugging messages sent to the GLib logger during DRT runs.
663
664         * DumpRenderTree/gtk/DumpRenderTree.cpp:
665         (logHandler): Added.
666         (main): Use logHandler as the default GLib log message handler.
667
668 2010-03-29  Eric Seidel  <eric@webkit.org>
669
670         Reviewed by Adam Barth.
671
672         sheriff-bot should comment on bugs when builders break
673         https://bugs.webkit.org/show_bug.cgi?id=36786
674
675         * Scripts/webkitpy/tool/commands/sheriffbot.py:
676          - Add a new _post_blame_comment_to_bug and all it from process_work_item
677          - Move commit-queue logic into _post_rollout_patch to make its api match the other _post commands.
678         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
679          - Test the new _post_blame_comment_to_bug call
680
681 2010-03-29  Eric Seidel  <eric@webkit.org>
682
683         Reviewed by Adam Barth.
684
685         sheriff-bot fails to get information about certain builds
686         https://bugs.webkit.org/show_bug.cgi?id=36768
687
688         This seems to be caused by:
689         http://buildbot.net/trac/ticket/753
690         I have no work-around, but for now at least we're logging
691         the error better.  I also added allow_none to our ServerProxy
692         creation in case that fixes things for other versions of python.
693
694         * Scripts/webkitpy/common/net/buildbot.py:
695
696 2010-03-29  Victor Wang  <victorw@chromium.org>
697
698         Reviewed by Adam Barth.
699
700         Add sign in/out link to TestResults appengine
701
702         Add a link to main menu for sign in/out to this appengine.
703         People signed in with admin privilege could perform
704         actions that are only allowed to admins like deleting files.
705
706         https://bugs.webkit.org/show_bug.cgi?id=36767
707
708         * TestResultServer/handlers/menu.py:
709         * TestResultServer/stylesheets/menu.css:
710         (.sign):
711         * TestResultServer/templates/menu.html:
712
713 2010-03-29  Eric Seidel  <eric@webkit.org>
714
715         Reviewed by Adam Barth.
716
717         ValidateReviewer step is draconian and un-tested
718         https://bugs.webkit.org/show_bug.cgi?id=36792
719
720         ValidateReviewer logic was commented out in
721         http://trac.webkit.org/changeset/56744
722         That was a symptom of the fact that validatereviewer.py
723         is too inflexible to be used when real humans are driving webkit-patch.
724         For now we just disable ValidateReviewer when humans are at the keyboard.
725
726         * Scripts/webkitpy/tool/steps/validatereviewer.py:
727          - Only run when in non-interactive mode.
728         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Added.
729          - Test our validation logic to make sure it's sane.
730
731 2010-03-29  Chris Jerdonek  <cjerdonek@webkit.org>
732
733         Reviewed by Shinichiro Hamaji.
734
735         Eliminate explicit slash characters from check-webkit-style's
736         _rel_path() method to make its implementation more platform
737         independent.
738
739         https://bugs.webkit.org/show_bug.cgi?id=36759
740
741         * Scripts/webkitpy/style/main.py:
742           - Changed to use os.sep instead of slash_chars "/\\".  This can
743             be done since os.path.abspath() converts slashes to os.sep.
744
745 2010-03-29  Dirk Pranke  <dpranke@chromium.org>
746
747         Reviewed by Dimitri Glazkov.
748
749         Change new-run-webkit-tests to not use more than four threads by
750         default on the mac port until
751         https://bugs.webkit.org/show_bug.cgi?id=36622 is fixed.
752
753         https://bugs.webkit.org/show_bug.cgi?id=36687
754
755         * Scripts/webkitpy/layout_tests/port/mac.py:
756
757 2010-03-29  Dirk Pranke  <dpranke@chromium.org>
758
759         Reviewed by Dimitri Glazkov.
760
761         Reformat port/mac.py to fit witin 80 columns for PEP-8 compliance.
762
763         https://bugs.webkit.org/show_bug.cgi?id=36691
764
765         * Scripts/webkitpy/layout_tests/port/mac.py:
766
767 2010-03-29  Eric Seidel  <eric@webkit.org>
768
769         Reviewed by Adam Barth.
770
771         new-run-webkit-tests fails java/lc3 on a clean checkout
772         https://bugs.webkit.org/show_bug.cgi?id=36078
773
774         * Scripts/webkitpy/layout_tests/port/mac.py:
775          - Build the java support files in check_build
776          - Unwrap a line which would still fit under 80col
777
778 2010-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
779
780         Reviewed by Simon Fraser.
781
782         Add support for Widgets 1.0: View Mode Media Feature
783         https://bugs.webkit.org/show_bug.cgi?id=35446
784
785         Add hooks to the Qt DRT for testing the view mode media feature.
786
787         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
788         (LayoutTestController::setViewModeMediaFeature):
789         * DumpRenderTree/qt/LayoutTestControllerQt.h:
790
791 2010-03-29  Adam Barth  <abarth@webkit.org>
792
793         Unreviewed.  Update expected results for unit tests.
794
795         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
796         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
797
798 2010-03-29  Adam Barth  <abarth@webkit.org>
799
800         Unreviewed.  I think Eric meant svn_revision.
801
802         * Scripts/webkitpy/tool/commands/sheriffbot.py:
803
804 2010-03-26  Eric Seidel  <eric@webkit.org>
805
806         Reviewed by Adam Barth.
807
808         webkit-patch commit-queue should notice if it breaks builders (and roll out its own changes)
809         https://bugs.webkit.org/show_bug.cgi?id=29311
810
811         Now that we have sheriff-bot watching the tree, it can post
812         rollout patches on behalf of the commit queue.
813
814         * Scripts/webkitpy/common/checkout/commitinfo.py: add responsible_parties()
815         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: test responsible_parties()
816         * Scripts/webkitpy/tool/commands/sheriffbot.py:
817          - Break IRC logic out into _post_irc_warning for easier testing.
818          - Add _post_rollout_patch for posting rollout patches to bugzilla.
819         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
820          - Test _rollout_reason
821         * Scripts/webkitpy/tool/grammar.py:
822          - Fix join_with_separators to not add Adam's "oxford comma" for two item lists.
823         * Scripts/webkitpy/tool/grammar_unittest.py:
824          - Test join_with_separators
825
826 2010-03-29  Adam Barth  <abarth@webkit.org>
827
828         Reviewed by Eric Seidel.
829
830         Sheriffbot should actually run commands
831         https://bugs.webkit.org/show_bug.cgi?id=36776
832
833         Some minor changes to Sheriffbot:
834
835         1) We should actually run commands (by giving control back to the
836         command processing object.
837
838         2) Use URLs instead of just numbers to represent SVN revisions (making
839         it easier to folks in IRC ot followup).
840
841         * Scripts/webkitpy/tool/bot/irc_command.py:
842         * Scripts/webkitpy/tool/bot/queueengine.py:
843         * Scripts/webkitpy/tool/commands/sheriffbot.py:
844
845 2010-03-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
846
847         Reviewed by Antti Koivisto.
848
849         Renaming of frame flattening LayoutTestController method
850         to setFrameFlatteningEnabled(bool)
851
852         * DumpRenderTree/LayoutTestController.cpp:
853         (setFrameFlatteningEnabledCallback):
854         (LayoutTestController::staticFunctions):
855         * DumpRenderTree/LayoutTestController.h:
856         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
857         (LayoutTestController::setFrameFlatteningEnabled):
858         * DumpRenderTree/mac/DumpRenderTree.mm:
859         (resetDefaultsToConsistentValues):
860         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
861         (LayoutTestController::setFrameFlatteningEnabled):
862         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
863         (WebCore::WebPage::resetSettings):
864         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
865         (LayoutTestController::setFrameFlatteningEnabled):
866         * DumpRenderTree/qt/LayoutTestControllerQt.h:
867         * DumpRenderTree/win/DumpRenderTree.cpp:
868         (resetDefaultsToConsistentValues):
869         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
870         (LayoutTestController::setFrameFlatteningEnabled):
871         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
872         (LayoutTestController::setFrameFlatteningEnabled):
873
874 2010-03-28  Gustavo Noronha Silva  <gns@gnome.org>
875
876         No review, rolling out r56679.
877         http://trac.webkit.org/changeset/56679
878         https://bugs.webkit.org/show_bug.cgi?id=36454
879
880         Lots of tests broken.
881
882         * DumpRenderTree/gtk/DumpRenderTree.cpp:
883         (createWebView):
884
885 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
886
887         Unreviewed.
888
889         Fixed typo in deprecated_logging_unittest.py, which is masking
890         sys.stderr while running test-webkitpy.
891
892         See also-- https://bugs.webkit.org/show_bug.cgi?id=36725#c3
893
894         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
895
896 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
897
898         Reviewed by Shinichiro Hamaji.
899
900         Renamed check-webkit-style's --debug flag to --verbose to be more
901         in line with other WebKit scripts.  Also renamed the current
902         --verbose flag to --min-confidence to allow the --debug rename.
903
904         https://bugs.webkit.org/show_bug.cgi?id=36521
905
906         We also renamed the internal "verbose" variables to "confidence" or
907         "min_confidence," as appropriate, to avoid confusion with the
908         --verbose flag, and because the new names are more accurate.
909
910         * Scripts/check-webkit-style:
911           - Renamed is_debug to is_verbose.
912
913         * Scripts/webkitpy/style/checker.py:
914           - Renamed _DEFAULT_VERBOSITY to _DEFAULT_CONFIDENCE.
915           - Renamed "verbosity" parameters to "min_confidence" throughout.
916           - Renamed configure_logging()'s is_debug parameter to is_verbose.
917
918         * Scripts/webkitpy/style/checker_unittest.py:
919           - Updated the unit tests as necessary.
920
921         * Scripts/webkitpy/style/error_handlers.py:
922           - Updated the call to StyleCheckerConfiguration.write_style_error().
923
924         * Scripts/webkitpy/style/error_handlers_unittest.py:
925           - Updated the unit tests as necessary.
926
927         * Scripts/webkitpy/style/optparser.py:
928           - Updated the usage string with the new flag names.
929           - Renamed the verbosity parameter to min_confidence throughout.
930           - Renamed the is_debug parameter to is_verbose throughout.
931
932         * Scripts/webkitpy/style/optparser_unittest.py:
933           - Updated the unit tests as necessary.
934
935         * Scripts/webkitpy/style/processors/cpp.py:
936           - Renamed the verbosity parameter to min_confidence throughout.
937
938         * Scripts/webkitpy/style/processors/cpp_unittest.py:
939           - Updated the unit tests as necessary.
940
941 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
942
943         Unreviewed.
944
945         Added back a line that accidentally got deleted in r56690.
946
947         * Scripts/check-webkit-style:
948
949 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
950
951         Reviewed by Shinichiro Hamaji.
952
953         Add to check-webkit-style support for checking directories.
954
955         https://bugs.webkit.org/show_bug.cgi?id=35234
956
957         * Scripts/check-webkit-style:
958           - Replaced the call to check_file() with a call to check_paths().
959
960         * Scripts/webkitpy/style/checker.py:
961           - In the StyleChecker class:
962             - Added a check_paths() method that accepts a list of paths
963               to files and directories.
964             - Added a _check_directory() method that checks the files
965               in a directory.
966
967         * Scripts/webkitpy/style/checker_unittest.py:
968           - Added a StyleCheckerCheckPathsTest to unit-test the new
969             check_paths() method.
970
971         * Scripts/webkitpy/style/optparser.py:
972           - Updated the usage string.
973
974 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
975
976         Reviewed by Shinichiro Hamaji.
977
978         Changed check-webkit-style to convert paths to paths relative to
979         the checkout root when invoking check-webkit-style with path
980         arguments.  Also added warning messages where appropriate.
981
982         https://bugs.webkit.org/show_bug.cgi?id=35498
983
984         Converting paths to paths relative to the checkout root ensures
985         that style checking will behave as expected (since path-specific
986         rules assume input paths are relative to a source root).
987
988         * Scripts/check-webkit-style:
989           - Added debug logging of whether the current directory was found
990             to be in a WebKit checkout.
991           - Added the found_checkout parameter to the call to parser.parse().
992           - Renamed the files variable to paths.
993           - Added a call to change_directory() prior to checking style.
994
995         * Scripts/webkitpy/style/checker.py:
996           - For StyleChecker.check_file():
997             - Updated the docstring.
998             - Added two log messages.
999
1000         * Scripts/webkitpy/style/checker_unittest.py:
1001           - Updated a call to parser.parse() with the found_checkout parameter.
1002
1003         * Scripts/webkitpy/style/main.py: Added.
1004           - Added a new file so the code in this patch could be unit-tested,
1005             as opposed to adding new code to check-webkit-style.
1006           - Added the method _rel_path() as a substitute for os.path.relpath(),
1007             which is available only in Python 2.6.
1008           - Added the method change_directory(), which contains most of the
1009             new functionality in this patch.
1010
1011         * Scripts/webkitpy/style/main_unittest.py: Added.
1012           - Added RelPathTest to test main._rel_path().
1013           - Added ChangeDirectoryTest to test main.change_directory().
1014
1015         * Scripts/webkitpy/style/optparser.py:
1016           - Updated check-webkit-style's usage string.
1017           - For the ArgumentParser.parse() method:
1018             - Added a found_checkout parameter.
1019             - Renamed filenames to paths.
1020             - Added logic so that an error is raised if no paths are passed
1021               if found_checkout is False.
1022
1023         * Scripts/webkitpy/style/optparser_unittest.py:
1024           - Updated the ArgumentParser.parse() unit tests to include
1025             coverage for the new found_checkout parameter.
1026
1027         * Scripts/webkitpy/style/unittests.py:
1028           - Added an import statement for main_unittest.
1029
1030         * Scripts/webkitpy/style_references.py:
1031           - Renamed SimpleScm to WebKitCheckout.
1032           - Added a detect_checkout() function to allow returning None
1033             instead of a WebKitCheckout instance if no checkout is found.
1034           - Renamed checkout_root to root_path.
1035
1036 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1037
1038         Reviewed by Eric Seidel.
1039
1040         Print didHandleOnloadEventsForFrame in the callback of
1041         onload-event signal comming from frame loader
1042
1043         [GTK] Improve reporting of frame loader callbacks in DRT
1044         https://bugs.webkit.org/show_bug.cgi?id=36454
1045
1046         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1047         (webViewOnloadEvent):
1048         (createWebView): added connection to signal::onload-event and
1049         signal callback
1050
1051 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1052
1053         Reviewed by Eric Seidel.
1054
1055         Print didCommitLoadForFrame in the callback of signal::load-committed
1056
1057         [GTK] Improve reporting of frame loader callbacks in DRT
1058         https://bugs.webkit.org/show_bug.cgi?id=36454
1059
1060         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1061         (webViewLoadCommitted):
1062         (createWebView): added connection to sinal::load-committed and
1063         signal callback
1064
1065 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1066
1067         Reviewed by Eric Seidel.
1068
1069         Print didStartProvisionalLoadForFrame in the callback of
1070         notify::load-status property change notification
1071
1072         [GTK] Improve reporting of frame loader callbacks in DRT
1073         https://bugs.webkit.org/show_bug.cgi?id=36454
1074
1075         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1076         (webInspectorCloseWindow):
1077         (webInspectorInspectWebView):
1078         (createWebView): added connection to notify::load-status and
1079         signal callback
1080
1081 2010-03-27  Chris Jerdonek  <cjerdonek@webkit.org>
1082
1083         Reviewed by Adam Barth.
1084
1085         In webkitpy/, deleted the /unittests.py files since test-webkitpy
1086         now auto-detects all *_unittest.py files.
1087
1088         https://bugs.webkit.org/show_bug.cgi?id=36712
1089
1090         * Scripts/webkitpy/common/net/irc/unittests.py: Removed.
1091         * Scripts/webkitpy/common/system/unittests.py: Removed.
1092         * Scripts/webkitpy/common/thread/unittests.py: Removed.
1093         * Scripts/webkitpy/common/unittests.py: Removed.
1094         * Scripts/webkitpy/python24/unittests.py: Removed.
1095         * Scripts/webkitpy/style/unittests.py: Removed.
1096         * Scripts/webkitpy/tool/unittests.py: Removed.
1097         * Scripts/webkitpy/unittests.py: Removed.
1098
1099 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1100
1101         Reviewed by Eric Seidel.
1102
1103         Add a CR after printing didFinishDocumentLoadForFrame
1104
1105         [GTK] Improve reporting of frame loader callbacks in DRT
1106         https://bugs.webkit.org/show_bug.cgi?id=36454
1107
1108         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1109         (webViewLoadFinished):
1110
1111 2010-03-27  Chris Jerdonek  <cjerdonek@webkit.org>
1112
1113         Rubber-stamped by Adam Barth.
1114
1115         Fixed the name of a unit test file in webkitpy.
1116
1117         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py.
1118         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: Removed.
1119
1120 2010-03-26  Chris Jerdonek  <cjerdonek@webkit.org>
1121
1122         Reviewed by Adam Barth.
1123
1124         The test-webkitpy script now automatically detects all unit-test
1125         files in webkitpy/.  This lets us eliminate the need to have and
1126         maintain all of the unittests.py files.
1127
1128         https://bugs.webkit.org/show_bug.cgi?id=36591
1129
1130         * Scripts/test-webkitpy:
1131           - Replaced the "from webkitpy.unittests import *" with a call
1132             to webkitpy.test.main.Tester().run_tests().
1133
1134         * Scripts/webkitpy/test/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
1135           - Required file for the new webkitpy/test/ directory.
1136
1137         * Scripts/webkitpy/test/main.py: Added.
1138           - Added a Tester class that contains the following methods:
1139             - _find_unittest_files() to detect all the unit-test files.
1140             - _modules_from_paths() to convert the paths to the unit-test
1141               files to fully-qualified module names.
1142             - run_tests() which calls the above two methods and then passes
1143               the module names to Python's unittest module.
1144
1145 2010-03-27  Robert Hogan  <robert@webkit.org>
1146
1147         Reviewed by Simon Fraser.
1148
1149         [Qt/Win] Add support to unix and windows NS plugin for executing scripts on setWindow.
1150
1151         https://bugs.webkit.org/show_bug.cgi?id=36701
1152
1153         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1154         (webkit_test_plugin_new_instance): Add onSetWindow.
1155         (webkit_test_plugin_destroy_instance): Add onSetWindow.
1156         (webkit_test_plugin_set_window): Add onSetWindow.
1157         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1158         (NPP_New): Add onSetWindow.
1159         (NPP_Destroy): Add onSetWindow.
1160         (NPP_SetWindow): Add onSetWindow.
1161
1162 2010-03-26  Robert Hogan  <robert@roberthogan.net>
1163
1164         Reviewed by Simon Hausmann.
1165
1166         Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',
1167          when pluginsEnabled is false.
1168
1169         Add support for LayoutTestController.WebKitPluginsEnabled
1170
1171         https://bugs.webkit.org/show_bug.cgi?id=32196
1172
1173         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1174         (resetDefaultsToConsistentValues):
1175         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1176         (copyWebSettingKey):
1177         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1178         (WebCore::WebPage::resetSettings):
1179         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1180         (LayoutTestController::overridePreference):
1181
1182 2010-03-26  Adam Barth  <abarth@webkit.org>
1183
1184         Reviewed by Eric Seidel.
1185
1186         Add some basic IRC commands to sheriffbot
1187         https://bugs.webkit.org/show_bug.cgi?id=36684
1188
1189         Adds support for sheriffbot to respond to a "hi" command and a
1190         "last-green-revision" command.  It's lame that we're rebuilding
1191         MultiCommandTool, but as discussed in person we'll intergrate the two
1192         once we see what the requirements are.
1193
1194         * Scripts/webkitpy/tool/bot/irc_command.py: Added.
1195         * Scripts/webkitpy/tool/bot/queueengine.py:
1196         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1197         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1198         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added.
1199         * Scripts/webkitpy/tool/commands/queues.py:
1200         * Scripts/webkitpy/tool/commands/queuestest.py:
1201         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1202         * Scripts/webkitpy/tool/main.py:
1203         * Scripts/webkitpy/tool/mocktool.py:
1204         * Scripts/webkitpy/tool/unittests.py:
1205
1206 2010-03-26  Adam Barth  <abarth@webkit.org>
1207
1208         Unreviewed.  More errors in the IRC module.  I have no idea how to test
1209         ircbot.py, which is too bad.  Hopefully we've abstracted it away enough
1210         that we don't have to touch it very much after this patch.
1211
1212         * Scripts/webkitpy/common/net/irc/ircbot.py:
1213
1214 2010-03-26  Adam Barth  <abarth@webkit.org>
1215
1216         Unreviewed.  Add a missing "_".
1217
1218         * Scripts/webkitpy/common/net/irc/ircproxy.py:
1219         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py: Added.
1220         * Scripts/webkitpy/common/net/irc/unittests.py:
1221
1222 2010-03-26  Adam Barth  <abarth@webkit.org>
1223
1224         Unreviewed.  Fix a the commit queue after my recent change.
1225
1226         * Scripts/webkitpy/tool/bot/queueengine.py:
1227
1228 2010-03-26  Dirk Pranke  <dpranke@chromium.org>
1229
1230         Unreviewed fix.
1231
1232         Fix the return value for port/base.diff_image (changed from 1/0 to
1233         True/False in bug 34826.
1234
1235         * Scripts/webkitpy/layout_tests/port/base.py:
1236
1237 2010-03-26  Dirk Pranke  <dpranke@chromium.org>
1238
1239         Reviewed by Eric Seidel.
1240
1241         Change the Mac port of new-run-webkit-tests to look for a
1242         test_expectations.txt file in addition to the Skipped files, so we
1243         can track pixel failures.
1244
1245         https://bugs.webkit.org/show_bug.cgi?id=36619
1246
1247         * Scripts/webkitpy/layout_tests/port/mac.py:
1248
1249 2010-03-26  Dirk Pranke  <dpranke@chromium.org>
1250
1251         Reviewed by Eric Seidel.
1252
1253         Implement pixel tests (image diff) properly on the Mac port.
1254
1255         This change introduces a new "ServerPocess" class that can be used
1256         to manage processes that the run-webkit-tests harness forks off and
1257         expects to stay up for longer than a single request/response session.
1258         Both DumpRenderTree and ImageDiff use this style of communication,
1259         although the current code forks off a new ImageDiff for each diff
1260         (We need to restructure other parts of the code to be able to do this
1261         safely in a multi-threaded environment).
1262
1263         Also, now that the ServerProcess abstraction exists, we can probably
1264         clean up and simplify some of the thread management logic in
1265         test_shell_thread as well.
1266
1267         https://bugs.webkit.org/show_bug.cgi?id=34826
1268
1269         * Scripts/webkitpy/layout_tests/port/mac.py:
1270         * Scripts/webkitpy/layout_tests/port/server_process.py:
1271         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1272
1273 2010-03-26  Sergio Villar Senin  <svillar@igalia.com>
1274
1275         Reviewed by Eric Seidel.
1276
1277         Print didFinishLoadForFrame outcome in DRT
1278
1279         [GTK] Improve reporting of frame loader callbacks in DRT
1280         https://bugs.webkit.org/show_bug.cgi?id=36454
1281
1282         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1283         (webViewLoadCommitted):
1284
1285 2010-03-26  Eric Seidel  <eric@webkit.org>
1286
1287         Unreviewed test fix.
1288         My change conflicted with one of Adam's causing test-webkitpy to fail.
1289
1290         Move commit_message_for_this_commit from scm to checkout
1291         https://bugs.webkit.org/show_bug.cgi?id=36629
1292
1293         * Scripts/webkitpy/common/checkout/api_unittest.py:
1294          - modified_changelogs is now on Checkout instead of scm.
1295
1296 2010-03-26  Adam Barth  <abarth@webkit.org>
1297
1298         Reviewed by Eric Seidel.
1299
1300         Refactor IRCBot controller logic to allow for commands
1301         https://bugs.webkit.org/show_bug.cgi?id=36676
1302
1303         We need to move the controller logic into the tool package so it can
1304         know about commands.  The changes to queueengine could go in a
1305         different patch, but we're going to need it anyway.
1306
1307         * Scripts/webkitpy/common/config/irc.py: Added.
1308         * Scripts/webkitpy/common/net/irc/ircbot.py:
1309         * Scripts/webkitpy/common/net/irc/ircproxy.py:
1310         * Scripts/webkitpy/tool/bot/queueengine.py:
1311         * Scripts/webkitpy/tool/bot/sheriffircbot.py: Added.
1312         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1313         * Scripts/webkitpy/tool/main.py:
1314         * Scripts/webkitpy/tool/mocktool.py:
1315
1316 2010-03-26  Adam Barth  <abarth@webkit.org>
1317
1318         Rubber stamped by Eric Seidel.
1319
1320         Move the threading code into its own module.  (It has nothing to do with IRC.)
1321
1322         * Scripts/webkitpy/common/net/irc/ircbot.py:
1323         * Scripts/webkitpy/common/net/irc/ircproxy.py:
1324         * Scripts/webkitpy/common/net/irc/messagepump.py: Removed.
1325         * Scripts/webkitpy/common/net/irc/messagepump_unittest.py: Removed.
1326         * Scripts/webkitpy/common/net/irc/threadedmessagequeue.py: Removed.
1327         * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py: Removed.
1328         * Scripts/webkitpy/common/net/irc/unittests.py:
1329         * Scripts/webkitpy/common/thread: Added.
1330         * Scripts/webkitpy/common/thread/__init__.py: Added.
1331         * Scripts/webkitpy/common/thread/messagepump.py: Copied from Scripts/webkitpy/common/net/irc/messagepump.py.
1332         * Scripts/webkitpy/common/thread/messagepump_unittest.py: Copied from Scripts/webkitpy/common/net/irc/messagepump_unittest.py.
1333         * Scripts/webkitpy/common/thread/threadedmessagequeue.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue.py.
1334         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py.
1335         * Scripts/webkitpy/common/thread/unittests.py: Added.
1336         * Scripts/webkitpy/common/unittests.py:
1337
1338 2010-03-26  Eric Seidel  <eric@webkit.org>
1339
1340         Reviewed by Adam Barth.
1341
1342         Move commit_message_for_this_commit from scm to checkout
1343         https://bugs.webkit.org/show_bug.cgi?id=36629
1344
1345         Finally add some basic unit testing for Checkout.commit_message_for_this_commit
1346
1347         * Scripts/webkitpy/common/checkout/api.py:
1348         * Scripts/webkitpy/common/checkout/api_unittest.py: Added.
1349         * Scripts/webkitpy/common/unittests.py:
1350
1351 2010-03-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1352
1353         [Qt] User Agent Switcher on QtLauncher
1354         https://bugs.webkit.org/show_bug.cgi?id=36451
1355
1356         Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-03-26
1357         Reviewed by Simon Hausmann.
1358
1359         Make possible to change the QtLauncher user agent via
1360         a predefined list.
1361
1362         * QtLauncher/QtLauncher.pro:
1363         * QtLauncher/QtLauncher.qrc: Added.
1364         * QtLauncher/main.cpp:
1365         (LauncherWindow::showUserAgentDialog):
1366         (LauncherWindow::createChrome):
1367         * QtLauncher/useragentlist.txt: Added.
1368         * QtLauncher/webpage.cpp:
1369         (WebPage::userAgentForUrl):
1370         * QtLauncher/webpage.h:
1371         (WebPage::setUserAgent):
1372
1373 2010-03-26  Victor Wang  <victorw@chromium.org>
1374
1375         Reviewed by Adam Barth.
1376
1377         Host layout test flakiness dashboard in TestResultServer appengine.
1378
1379         Flakiness dashboard is a tool to monitor layout test status and
1380         help layout test regression diagnostics.
1381
1382         https://bugs.webkit.org/show_bug.cgi?id=36195
1383
1384         * TestResultServer/handlers/dashboardhandler.py: Added.
1385          - New handler to handle dashboard request
1386         * TestResultServer/handlers/menu.py:
1387          - Add new dashboard links
1388         * TestResultServer/handlers/testfilehandler.py:
1389          - Request routes refactory
1390         * TestResultServer/index.yaml:
1391         * TestResultServer/main.py:
1392          - Add new dashboard request routes and refactor test result file rountes.
1393         * TestResultServer/model/dashboardfile.py: Added.
1394          - Model to access datastore for dashboard files
1395         * TestResultServer/model/testfile.py:
1396         * TestResultServer/stylesheets/dashboardfile.css: Added.
1397         * TestResultServer/templates/dashboardfilelist.html: Added.
1398         * TestResultServer/templates/showfilelist.html:
1399
1400 2010-03-26  Adam Barth  <abarth@webkit.org>
1401
1402         Reviewed by Eric Seidel.
1403
1404         Remove some evil statics from CommitInfo
1405         https://bugs.webkit.org/show_bug.cgi?id=36637
1406
1407         These methods should really be on checkout.  You can tell because they
1408         know about ChangeLogs and take an SCM as an argument.  :)
1409
1410         * Scripts/webkitpy/common/checkout/api.py:
1411         * Scripts/webkitpy/common/checkout/changelog.py:
1412         * Scripts/webkitpy/common/checkout/commitinfo.py:
1413         * Scripts/webkitpy/tool/commands/queries.py:
1414
1415 2010-03-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1416
1417         Reviewed by Simon Hausmann.
1418
1419         Add an option to QtLauncher to enable/disable a QGLWidget as Viewport
1420         of the QGraphicsView when the launcher is running on graphicsview mode.
1421
1422         [Qt] QtLauncher needs an option to Enable/Disable a QGLWidget as Viewport
1423         https://bugs.webkit.org/show_bug.cgi?id=36270
1424
1425         * QtLauncher/QtLauncher.pro:
1426         * QtLauncher/main.cpp:
1427         (LauncherWindow::toggleQGLWidgetViewport):
1428         (LauncherWindow::createChrome):
1429
1430 2010-03-26  Fumitoshi Ukai  <ukai@chromium.org>
1431
1432         Reviewed by Shinichiro Hamaji.
1433
1434         [Chromium-Win] websocket_server.py failed to start
1435         https://bugs.webkit.org/show_bug.cgi?id=36586
1436         
1437         subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
1438         We don't need stdin, so use devnull as stdin.
1439
1440         * Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin
1441
1442 2010-03-26  Kent Tamura  <tkent@chromium.org>
1443
1444         Reviewed by Dimitri Glazkov.
1445
1446         [DRT/Chromium] Add TestNavigationController and TestWebWorker
1447         https://bugs.webkit.org/show_bug.cgi?id=36520
1448
1449         Add LayoutTestController class, which is going to be used by
1450         DumpRenderTree Chromium port. These files are based on:
1451         - src/webkit/tools/test_shell/layout_test_controller.cc
1452         - src/webkit/tools/test_shell/layout_test_controller.h
1453         of Chromium rev.40492.
1454
1455         * DumpRenderTree/chromium/LayoutTestController.cpp: Added.
1456         * DumpRenderTree/chromium/LayoutTestController.h: Added.
1457
1458 2010-03-25  Charlie Reis  <creis@chromium.org>
1459
1460         Reviewed by Adam Barth.
1461
1462         onbeforeunload not called at window close + frame or iframe focused
1463         https://bugs.webkit.org/show_bug.cgi?id=27481
1464
1465         Adds a callShouldCloseOnWebView method to LayoutTestController,
1466         to allow automated testing for bug 27481.
1467
1468         * DumpRenderTree/LayoutTestController.cpp:
1469         (callShouldCloseOnWebViewCallback):
1470         (LayoutTestController::staticFunctions):
1471         * DumpRenderTree/LayoutTestController.h:
1472         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1473         (LayoutTestController::callShouldCloseOnWebView):
1474         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1475         (LayoutTestController::callShouldCloseOnWebView):
1476         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1477         (LayoutTestController::callShouldCloseOnWebView):
1478         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1479         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1480         (LayoutTestController::callShouldCloseOnWebView):
1481
1482 2010-03-25  Eric Seidel  <eric@webkit.org>
1483
1484         Reviewed by Adam Barth.
1485
1486         Add webkit-patch lkgr for finding last known good revision
1487         https://bugs.webkit.org/show_bug.cgi?id=36626
1488
1489         This is rather slow for now because the command
1490         has to compute this information from the buildbot.
1491         A better long-term solution would be to have a server
1492         somewhere store a pre-computed LKGR and then any
1493         script (like webkit-patch) could just fetch it.
1494
1495         * Scripts/webkitpy/common/net/buildbot.py:
1496         * Scripts/webkitpy/tool/commands/queries.py:
1497
1498 2010-03-25  Adam Barth  <abarth@webkit.org>
1499
1500         Reviewed by Eric Seidel.
1501
1502         Move modified_changelogs (and friends) from scm to checkout
1503         https://bugs.webkit.org/show_bug.cgi?id=36636
1504
1505         These functions know about ChangeLogs, which is forbidden knowledge in
1506         scm.py.
1507
1508         * Scripts/webkitpy/common/checkout/api.py:
1509         * Scripts/webkitpy/common/checkout/changelog.py:
1510         * Scripts/webkitpy/common/checkout/scm.py:
1511         * Scripts/webkitpy/tool/mocktool.py:
1512         * Scripts/webkitpy/tool/steps/abstractstep.py:
1513         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1514         * Scripts/webkitpy/tool/steps/revertrevision.py:
1515         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1516         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1517
1518 2010-03-25  Adam Barth  <abarth@webkit.org>
1519
1520         Reviewed by Eric Seidel.
1521
1522         Move apply_patch from scm to checkout
1523         https://bugs.webkit.org/show_bug.cgi?id=36635
1524
1525         SCM shouldn't have any knowledge of WebKit scripts.
1526
1527         * Scripts/webkitpy/common/checkout/api.py:
1528         * Scripts/webkitpy/common/checkout/scm.py:
1529         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1530         * Scripts/webkitpy/tool/mocktool.py:
1531         * Scripts/webkitpy/tool/steps/applypatch.py:
1532
1533 2010-03-25  Eric Seidel  <eric@webkit.org>
1534
1535         Unreviewed build fix to un-break webkit-patch land.
1536         Test-case coming in follow-up commit.
1537
1538         Move commit_message_for_this_commit from scm to checkout
1539         https://bugs.webkit.org/show_bug.cgi?id=36629
1540
1541         * Scripts/webkitpy/common/checkout/api.py: import scm.CommitMessage
1542
1543 2010-03-25  Dan Bernstein  <mitz@apple.com>
1544
1545         Reviewed by Darin Adler.
1546
1547         <rdar://problem/7728903> Support color bitmap fonts
1548
1549         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ColorBits.ttf
1550         and ColorBits-A.png.
1551         * DumpRenderTree/fonts/ColorBits-A.png: Copied from WebCore/inspector/front-end/Images/successGreenDot.png.
1552         * DumpRenderTree/fonts/ColorBits.ttf: Added.
1553         * DumpRenderTree/mac/DumpRenderTree.mm:
1554         (activateFonts): Activate ColorBits.ttf.
1555
1556 2010-03-25  Mark Rowe  <mrowe@apple.com>
1557
1558         Remove a printf that was causing commit-log-editor to spew the name of the editor
1559         to the terminal many times during a commit.
1560
1561         * Scripts/commit-log-editor:
1562
1563 2010-03-25  Adam Barth  <abarth@webkit.org>
1564
1565         Reviewed by Eric Seidel.
1566
1567         Move commit_message_for_this_commit from scm to checkout
1568         https://bugs.webkit.org/show_bug.cgi?id=36629
1569
1570         This function requires knowledge of ChangeLogs, but scm shouldn't know
1571         about ChangeLogs.
1572
1573         * Scripts/webkitpy/common/checkout/api.py:
1574         * Scripts/webkitpy/common/checkout/scm.py:
1575         * Scripts/webkitpy/tool/commands/upload.py:
1576         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1577         * Scripts/webkitpy/tool/mocktool.py:
1578         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
1579         * Scripts/webkitpy/tool/steps/commit.py:
1580
1581 2010-03-25  Adam Barth  <abarth@webkit.org>
1582
1583         Reviewed by Eric Seidel.
1584
1585         REGRESSION: webkit-patch land can't land "rubber-stamped" patches
1586         https://bugs.webkit.org/show_bug.cgi?id=36582
1587
1588         Allow a "-" in rubber stamped.
1589
1590         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1591
1592 2010-03-25  Adam Barth  <abarth@webkit.org>
1593
1594         Unreviewed.  Fix some copyright lines to remove extraneous comma and
1595         python directive.
1596
1597         * Scripts/webkitpy/tool/bot/patchcollection.py:
1598         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py:
1599         * Scripts/webkitpy/tool/bot/queueengine.py:
1600         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1601         * Scripts/webkitpy/tool/commands/download.py:
1602         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1603         * Scripts/webkitpy/tool/commands/queries.py:
1604         * Scripts/webkitpy/tool/commands/queues.py:
1605         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1606         * Scripts/webkitpy/tool/comments.py:
1607         * Scripts/webkitpy/tool/grammar.py:
1608         * Scripts/webkitpy/tool/multicommandtool.py:
1609         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1610
1611 2010-03-25  Simon Fraser  <simon.fraser@apple.com>
1612
1613         Reviewed by Darin Adler, Alexey Proskuryakov.
1614
1615         https://bugs.webkit.org/show_bug.cgi?id=36631
1616         Allow the test plugin to run scripts in response to NPP_SetWindow calls
1617         
1618         Hook up the ability for the TestNetscapePlugIn to run JavaScript in
1619         response to NPP_SetWindow.
1620         
1621         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1622         (pluginAllocate):
1623         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1624         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1625         (NPP_New):
1626         (NPP_Destroy):
1627         (NPP_SetWindow):
1628
1629 2010-03-25  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1630
1631         Unreviewed, build fix.
1632
1633         [Qt] Fix QtLauncher guards.
1634
1635         * QtLauncher/main.cpp:
1636         (LauncherWindow::showFPS):
1637         (LauncherWindow::updateFPS):
1638
1639 2010-03-25  Yury Semikhatsky  <yurys@chromium.org>
1640
1641         Reviewed by Pavel Feldman.
1642
1643         Allow running tests with enabled developer extras and closed Web Inspector. Tests that have inspector-enabled/ in their path/url will have developer extras enabled.
1644
1645         https://bugs.webkit.org/show_bug.cgi?id=36610
1646
1647         * DumpRenderTree/LayoutTestController.h:
1648         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1649         (shouldEnableDeveloperExtras):
1650         (runTest):
1651         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1652         (LayoutTestController::setJavaScriptProfilingEnabled):
1653         (LayoutTestController::setDeveloperExtrasEnabled):
1654         (LayoutTestController::showWebInspector):
1655         (LayoutTestController::closeWebInspector):
1656         * DumpRenderTree/mac/DumpRenderTree.mm:
1657         (shouldEnableDeveloperExtras):
1658         (runTest):
1659         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1660         (LayoutTestController::setJavaScriptProfilingEnabled):
1661         (LayoutTestController::setDeveloperExtrasEnabled):
1662         (LayoutTestController::showWebInspector):
1663         (LayoutTestController::closeWebInspector):
1664         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1665         (WebCore::shouldEnableDeveloperExtras):
1666         (WebCore::DumpRenderTree::open):
1667         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1668         (LayoutTestController::closeWebInspector):
1669         (LayoutTestController::setDeveloperExtrasEnabled):
1670         (LayoutTestController::showWebInspector):
1671         (LayoutTestController::setJavaScriptProfilingEnabled):
1672         * DumpRenderTree/win/DumpRenderTree.cpp:
1673         (shouldEnableDeveloperExtras):
1674         (runTest):
1675         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1676         (LayoutTestController::setJavaScriptProfilingEnabled):
1677         (LayoutTestController::setDeveloperExtrasEnabled):
1678         (LayoutTestController::showWebInspector):
1679         (LayoutTestController::closeWebInspector):
1680
1681 2010-03-25  Adam Barth  <abarth@webkit.org>
1682
1683         Rubber stamped by Eric Seidel.
1684
1685         Tweaks to sheriffbot to improve latency by keeping the working copy up
1686         to date even when there's no build break.  Also, officially move
1687         sheriffbot to #webkit.
1688
1689         (Also teach ValidateReviewer to understand rubber stamps.)
1690
1691         * Scripts/webkitpy/common/net/irc/ircbot.py:
1692         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1693         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1694
1695 2010-03-22  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1696
1697         Reviewed by Simon Hausmann.
1698
1699         Not displaying FPS info on the terminal. On S60 and Maemo the
1700         Window title will be used and Status bar will used on desktop.
1701
1702         [Qt] QtLauncher's FPS info should not be displayed on the terminal
1703         https://bugs.webkit.org/show_bug.cgi?id=36244
1704
1705         * QtLauncher/main.cpp:
1706         (LauncherWindow::initializeView):
1707         (LauncherWindow::showFPS):
1708         (LauncherWindow::updateFPS):
1709         * QtLauncher/webview.cpp:
1710         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
1711         (WebViewGraphicsBased::updateFrameRate):
1712         * QtLauncher/webview.h:
1713         (WebViewGraphicsBased::frameRateMeasurementEnabled):
1714
1715 2010-03-25  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1716
1717         Reviewed by Kenneth Christiansen.
1718
1719         Added missing frame flattening activation on
1720         fast/frames/flattening/frameset-flattening-grid.html;
1721         removed unnecessary CONSOLE MESSAGE from the expected file;
1722         reset the setFrameSetFlatteningEnabled for each test.
1723
1724         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1725         (WebCore::WebPage::resetSettings):
1726
1727 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
1728
1729         Reviewed by Adam Barth.
1730
1731         Moved deprecated_logging unit test import statement from
1732         webkitpy/unittests.py to webkitpy/common/system/unittests.py.
1733
1734         https://bugs.webkit.org/show_bug.cgi?id=36093
1735
1736         This is part of the master bug to reorganize webkitpy.
1737
1738         * Scripts/webkitpy/common/system/unittests.py:
1739         * Scripts/webkitpy/unittests.py:
1740
1741 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
1742
1743         Reviewed by Adam Barth.
1744
1745         Moved webkit_logging.py to common/system/deprecated_logging.py
1746         inside webkitpy.
1747
1748         https://bugs.webkit.org/show_bug.cgi?id=36093
1749
1750         This is part of the master bug to reorganize webkitpy.
1751
1752         * Scripts/validate-committer-lists:
1753         * Scripts/webkitpy/common/checkout/changelog.py:
1754         * Scripts/webkitpy/common/checkout/scm.py:
1755         * Scripts/webkitpy/common/net/bugzilla.py:
1756         * Scripts/webkitpy/common/net/buildbot.py:
1757         * Scripts/webkitpy/common/net/credentials.py:
1758         * Scripts/webkitpy/common/net/irc/ircproxy.py:
1759         * Scripts/webkitpy/common/net/networktransaction.py:
1760         * Scripts/webkitpy/common/net/statusserver.py:
1761         * Scripts/webkitpy/common/system/deprecated_logging.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging.py.
1762         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging_unittest.py.
1763         * Scripts/webkitpy/common/system/executive.py:
1764         * Scripts/webkitpy/tool/bot/queueengine.py:
1765         * Scripts/webkitpy/tool/commands/download.py:
1766         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1767         * Scripts/webkitpy/tool/commands/openbugs.py:
1768         * Scripts/webkitpy/tool/commands/queries.py:
1769         * Scripts/webkitpy/tool/commands/queues.py:
1770         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1771         * Scripts/webkitpy/tool/commands/stepsequence.py:
1772         * Scripts/webkitpy/tool/commands/upload.py:
1773         * Scripts/webkitpy/tool/main.py:
1774         * Scripts/webkitpy/tool/mocktool.py:
1775         * Scripts/webkitpy/tool/multicommandtool.py:
1776         * Scripts/webkitpy/tool/steps/abstractstep.py:
1777         * Scripts/webkitpy/tool/steps/applypatch.py:
1778         * Scripts/webkitpy/tool/steps/build.py:
1779         * Scripts/webkitpy/tool/steps/checkstyle.py:
1780         * Scripts/webkitpy/tool/steps/closebug.py:
1781         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
1782         * Scripts/webkitpy/tool/steps/confirmdiff.py:
1783         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1784         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
1785         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1786         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1787         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1788         * Scripts/webkitpy/tool/steps/runtests.py:
1789         * Scripts/webkitpy/tool/steps/update.py:
1790         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1791         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1792         * Scripts/webkitpy/unittests.py:
1793         * Scripts/webkitpy/webkit_logging.py: Removed.
1794         * Scripts/webkitpy/webkit_logging_unittest.py: Removed.
1795
1796 2010-03-25  Julien Chaffraix  <jchaffraix@webkit.org>
1797
1798         Reviewed by Kenneth Rohde Christiansen.
1799
1800         commit-log-editor can call itself in an infinite loop
1801         https://bugs.webkit.org/show_bug.cgi?id=35291
1802
1803         if $editor ends up being commit-log-editor, the script will exec itself
1804         in an infinite loop.
1805
1806         To avoid this, we now check that the $editor variable is not
1807         commit-log-editor to avoid this case.
1808
1809         * Scripts/commit-log-editor: Added an isCommitLogEditor method and
1810         reworked the $editor setting to add this check.
1811
1812 2010-03-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1813
1814         Reviewed by Kenneth Rohde Christiansen.
1815
1816         Add a Toggle Frame Flattening option to QtLauncher.
1817         It will be enabled by default on Maemo5 and S60 platforms.
1818
1819         [Qt] Add enable/disable Frame Flattening option to QtLauncher
1820         https://bugs.webkit.org/show_bug.cgi?id=36558
1821
1822         * QtLauncher/main.cpp:
1823         (LauncherWindow::applyPrefs):
1824         (LauncherWindow::toggleFrameFlattening):
1825         (LauncherWindow::createChrome):
1826
1827 2010-03-25  Zoltan Horvath  <zoltan@webkit.org>
1828
1829         Reviewed by Eric Seidel.
1830
1831         svn-create-patch prints a warning for large patches
1832         https://bugs.webkit.org/show_bug.cgi?id=32582
1833
1834         svn-create-patch prints a warning message for larger patches than 20k.
1835
1836         * Scripts/svn-create-patch:
1837
1838 2010-03-25  Adam Barth  <abarth@webkit.org>
1839
1840         Unreviewed.  Renamed early_warning_system.py to earlywarningsystem.py.
1841         https://bugs.webkit.org/show_bug.cgi?id=36093
1842
1843         * Scripts/webkitpy/tool/commands/early_warning_system.py: Removed.
1844         * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py: Removed.
1845         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system.py.
1846         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system_unittest.py.
1847         * Scripts/webkitpy/tool/main.py:
1848         * Scripts/webkitpy/tool/unittests.py:
1849
1850 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
1851
1852         Reviewed by Adam Barth.
1853
1854         In webkitpy, pushed the unit test import statements in
1855         webkitpy/unittests.py into appropriate unittests.py files in the
1856         new root-level packages beneath webkitpy.
1857
1858         https://bugs.webkit.org/show_bug.cgi?id=36093
1859
1860         This is part of the master bug to reorganize webkitpy.
1861
1862         * Scripts/webkitpy/common/system/unittests.py:
1863         * Scripts/webkitpy/common/unittests.py: Added.
1864         * Scripts/webkitpy/python24/unittests.py: Added.
1865         * Scripts/webkitpy/tool/unittests.py: Added.
1866         * Scripts/webkitpy/unittests.py:
1867
1868 2010-03-25  Adam Barth  <abarth@webkit.org>
1869
1870         Unreviewed.  Move WebKitCheckout into the webkitpy.common.checkout
1871         package.
1872         https://bugs.webkit.org/show_bug.cgi?id=36093
1873
1874         * Scripts/webkitpy/common/checkout/api.py: Copied from Scripts/webkitpy/webkitcheckout.py.
1875         * Scripts/webkitpy/tool/main.py:
1876         * Scripts/webkitpy/tool/mocktool.py:
1877         * Scripts/webkitpy/webkitcheckout.py: Removed.
1878
1879 2010-03-25  Adam Barth  <abarth@webkit.org>
1880
1881         Unreviewed.  Move OutputCapture to webkitpy.common.system.
1882         https://bugs.webkit.org/show_bug.cgi?id=36093
1883
1884         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1885         * Scripts/webkitpy/common/net/credentials_unittest.py:
1886         * Scripts/webkitpy/common/system/outputcapture.py: Copied from Scripts/webkitpy/outputcapture.py.
1887         * Scripts/webkitpy/outputcapture.py: Removed.
1888         * Scripts/webkitpy/tool/commands/commandtest.py:
1889         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1890         * Scripts/webkitpy/tool/commands/queuestest.py:
1891         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1892         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
1893         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1894         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
1895
1896 2010-03-25  Adam Barth  <abarth@webkit.org>
1897
1898         Unreviewed.  Move user.py to webkitpy.common.system.
1899
1900         * Scripts/webkitpy/common/checkout/scm.py:
1901         * Scripts/webkitpy/common/net/bugzilla.py:
1902         * Scripts/webkitpy/common/net/credentials.py:
1903         * Scripts/webkitpy/common/system/user.py: Copied from Scripts/webkitpy/user.py.
1904         * Scripts/webkitpy/common/system/user_unittest.py: Copied from Scripts/webkitpy/user_unittest.py.
1905         * Scripts/webkitpy/tool/commands/upload.py:
1906         * Scripts/webkitpy/tool/main.py:
1907         * Scripts/webkitpy/unittests.py:
1908         * Scripts/webkitpy/user.py: Removed.
1909         * Scripts/webkitpy/user_unittest.py: Removed.
1910
1911 2010-03-25  Adam Barth  <abarth@webkit.org>
1912
1913         Unreviewed.  Move executive.py to webkitpy.common.system.
1914         https://bugs.webkit.org/show_bug.cgi?id=36093
1915
1916         * Scripts/webkitpy/common/checkout/scm.py:
1917         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1918         * Scripts/webkitpy/common/config/ports.py:
1919         * Scripts/webkitpy/common/config/ports_unittest.py:
1920         * Scripts/webkitpy/common/net/credentials.py:
1921         * Scripts/webkitpy/common/net/credentials_unittest.py:
1922         * Scripts/webkitpy/common/system/executive.py: Copied from Scripts/webkitpy/executive.py.
1923         * Scripts/webkitpy/common/system/executive_unittest.py: Copied from Scripts/webkitpy/executive_unittest.py.
1924         * Scripts/webkitpy/executive.py: Removed.
1925         * Scripts/webkitpy/executive_unittest.py: Removed.
1926         * Scripts/webkitpy/layout_tests/port/mac.py:
1927         * Scripts/webkitpy/tool/bot/queueengine.py:
1928         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1929         * Scripts/webkitpy/tool/commands/download.py:
1930         * Scripts/webkitpy/tool/commands/early_warning_system.py:
1931         * Scripts/webkitpy/tool/commands/queues.py:
1932         * Scripts/webkitpy/tool/commands/stepsequence.py:
1933         * Scripts/webkitpy/tool/main.py:
1934         * Scripts/webkitpy/tool/steps/checkstyle.py:
1935         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1936         * Scripts/webkitpy/unittests.py:
1937         * Scripts/webkitpy/webkit_logging_unittest.py:
1938
1939 2010-03-25  Adam Barth  <abarth@webkit.org>
1940
1941         Unreviewed.  Move grammary.py into webkitpy.tool.
1942         https://bugs.webkit.org/show_bug.cgi?id=36093
1943
1944         * Scripts/webkitpy/grammar.py: Removed.
1945         * Scripts/webkitpy/grammar_unittest.py: Removed.
1946         * Scripts/webkitpy/tool/commands/download.py:
1947         * Scripts/webkitpy/tool/commands/queries.py:
1948         * Scripts/webkitpy/tool/commands/queues.py:
1949         * Scripts/webkitpy/tool/commands/upload.py:
1950         * Scripts/webkitpy/tool/grammar.py: Copied from Scripts/webkitpy/grammar.py.
1951         * Scripts/webkitpy/tool/grammar_unittest.py: Copied from Scripts/webkitpy/grammar_unittest.py.
1952         * Scripts/webkitpy/tool/multicommandtool.py:
1953         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1954         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1955         * Scripts/webkitpy/unittests.py:
1956
1957 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
1958
1959         Reviewed by Adam Barth.
1960
1961         In webkitpy, moved init/ to common/system/.
1962
1963         https://bugs.webkit.org/show_bug.cgi?id=36093
1964
1965         This is part of the master bug to reorganize webkitpy.
1966
1967         * Scripts/webkitpy/common/system: Copied from WebKitTools/Scripts/webkitpy/init.
1968         * Scripts/webkitpy/common/system/logutils.py:
1969         * Scripts/webkitpy/common/system/logutils_unittest.py:
1970         * Scripts/webkitpy/init: Removed.
1971         * Scripts/webkitpy/init/__init__.py: Removed.
1972         * Scripts/webkitpy/init/logtesting.py: Removed.
1973         * Scripts/webkitpy/init/logutils.py: Removed.
1974         * Scripts/webkitpy/init/logutils_unittest.py: Removed.
1975         * Scripts/webkitpy/init/unittests.py: Removed.
1976         * Scripts/webkitpy/python24/versioning_unittest.py:
1977         * Scripts/webkitpy/style_references.py:
1978         * Scripts/webkitpy/unittests.py:
1979
1980 2010-03-25  Adam Barth  <abarth@webkit.org>
1981
1982         Unreviewed.  Move stepsequence to webkitpy.tool.commands.
1983         https://bugs.webkit.org/show_bug.cgi?id=36093
1984
1985         * Scripts/webkitpy/stepsequence.py: Removed.
1986         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1987         * Scripts/webkitpy/tool/commands/download.py:
1988         * Scripts/webkitpy/tool/commands/queues.py:
1989         * Scripts/webkitpy/tool/commands/stepsequence.py: Copied from Scripts/webkitpy/stepsequence.py.
1990
1991 2010-03-25  Adam Barth  <abarth@webkit.org>
1992
1993         Unreviewed.  Create webkitpy.common.checkout as described in
1994         https://bugs.webkit.org/show_bug.cgi?id=36093
1995
1996         * Scripts/webkitpy/changelogs.py: Removed.
1997         * Scripts/webkitpy/changelogs_unittest.py: Removed.
1998         * Scripts/webkitpy/commitinfo.py: Removed.
1999         * Scripts/webkitpy/commitinfo_unittest.py: Removed.
2000         * Scripts/webkitpy/common/checkout: Added.
2001         * Scripts/webkitpy/common/checkout/__init__.py: Copied from Scripts/webkitpy/common/__init__.py.
2002         * Scripts/webkitpy/common/checkout/changelog.py: Copied from Scripts/webkitpy/changelogs.py.
2003         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Copied from Scripts/webkitpy/changelogs_unittest.py.
2004         * Scripts/webkitpy/common/checkout/commitinfo.py: Copied from Scripts/webkitpy/commitinfo.py.
2005         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: Copied from Scripts/webkitpy/commitinfo_unittest.py.
2006         * Scripts/webkitpy/common/checkout/diff_parser.py: Copied from Scripts/webkitpy/diff_parser.py.
2007         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Copied from Scripts/webkitpy/diff_parser_unittest.py.
2008         * Scripts/webkitpy/common/checkout/scm.py: Copied from Scripts/webkitpy/scm.py.
2009         * Scripts/webkitpy/common/checkout/scm_unittest.py: Copied from Scripts/webkitpy/scm_unittest.py.
2010         * Scripts/webkitpy/common/net/credentials.py:
2011         * Scripts/webkitpy/diff_parser.py: Removed.
2012         * Scripts/webkitpy/diff_parser_unittest.py: Removed.
2013         * Scripts/webkitpy/layout_tests/port/base.py:
2014         * Scripts/webkitpy/scm.py: Removed.
2015         * Scripts/webkitpy/scm_unittest.py: Removed.
2016         * Scripts/webkitpy/stepsequence.py:
2017         * Scripts/webkitpy/style_references.py:
2018         * Scripts/webkitpy/tool/commands/download.py:
2019         * Scripts/webkitpy/tool/commands/queries.py:
2020         * Scripts/webkitpy/tool/comments.py:
2021         * Scripts/webkitpy/tool/main.py:
2022         * Scripts/webkitpy/tool/mocktool.py:
2023         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2024         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2025         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2026         * Scripts/webkitpy/unittests.py:
2027         * Scripts/webkitpy/webkitcheckout.py:
2028
2029 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2030
2031         Reviewed by Adam Barth.
2032
2033         In webkitpy, moved init/versioning.py to python24/.
2034
2035         https://bugs.webkit.org/show_bug.cgi?id=36093
2036
2037         This is part of the master bug to reorganize webkitpy.
2038
2039         * Scripts/test-webkitpy:
2040         * Scripts/webkit-patch:
2041         * Scripts/webkitpy/init/unittests.py:
2042         * Scripts/webkitpy/init/versioning.py: Removed.
2043         * Scripts/webkitpy/init/versioning_unittest.py: Removed.
2044         * Scripts/webkitpy/python24: Added.
2045         * Scripts/webkitpy/python24/__init__.py: Copied from WebKitTools/Scripts/webkitpy/tool/__init__.py.
2046         * Scripts/webkitpy/python24/versioning.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning.py.
2047         * Scripts/webkitpy/python24/versioning_unittest.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning_unittest.py.
2048         * Scripts/webkitpy/unittests.py:
2049
2050 2010-03-25  Adam Barth  <abarth@webkit.org>
2051
2052         Unreviewed.
2053
2054         Create webkitpy.common.net as described in
2055         https://bugs.webkit.org/show_bug.cgi?id=36093
2056
2057         * Scripts/webkitpy/bugzilla.py: Removed.
2058         * Scripts/webkitpy/bugzilla_unittest.py: Removed.
2059         * Scripts/webkitpy/buildbot.py: Removed.
2060         * Scripts/webkitpy/buildbot_unittest.py: Removed.
2061         * Scripts/webkitpy/commitinfo.py:
2062         * Scripts/webkitpy/common/net: Added.
2063         * Scripts/webkitpy/common/net/__init__.py: Added.
2064         * Scripts/webkitpy/common/net/bugzilla.py: Copied from Scripts/webkitpy/bugzilla.py.
2065         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Copied from Scripts/webkitpy/bugzilla_unittest.py.
2066         * Scripts/webkitpy/common/net/buildbot.py: Copied from Scripts/webkitpy/buildbot.py.
2067         * Scripts/webkitpy/common/net/buildbot_unittest.py: Copied from Scripts/webkitpy/buildbot_unittest.py.
2068         * Scripts/webkitpy/common/net/credentials.py: Copied from Scripts/webkitpy/credentials.py.
2069         * Scripts/webkitpy/common/net/credentials_unittest.py: Copied from Scripts/webkitpy/credentials_unittest.py.
2070         * Scripts/webkitpy/common/net/irc: Copied from Scripts/webkitpy/irc.
2071         * Scripts/webkitpy/common/net/irc/ircbot.py:
2072         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2073         * Scripts/webkitpy/common/net/irc/messagepump_unittest.py:
2074         * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py:
2075         * Scripts/webkitpy/common/net/irc/unittests.py:
2076         * Scripts/webkitpy/common/net/networktransaction.py: Copied from Scripts/webkitpy/networktransaction.py.
2077         * Scripts/webkitpy/common/net/networktransaction_unittest.py: Copied from Scripts/webkitpy/networktransaction_unittest.py.
2078         * Scripts/webkitpy/common/net/statusserver.py: Copied from Scripts/webkitpy/statusserver.py.
2079         * Scripts/webkitpy/credentials.py: Removed.
2080         * Scripts/webkitpy/credentials_unittest.py: Removed.
2081         * Scripts/webkitpy/irc: Removed.
2082         * Scripts/webkitpy/irc/__init__.py: Removed.
2083         * Scripts/webkitpy/irc/ircbot.py: Removed.
2084         * Scripts/webkitpy/irc/ircproxy.py: Removed.
2085         * Scripts/webkitpy/irc/messagepump.py: Removed.
2086         * Scripts/webkitpy/irc/messagepump_unittest.py: Removed.
2087         * Scripts/webkitpy/irc/threadedmessagequeue.py: Removed.
2088         * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Removed.
2089         * Scripts/webkitpy/irc/unittests.py: Removed.
2090         * Scripts/webkitpy/networktransaction.py: Removed.
2091         * Scripts/webkitpy/networktransaction_unittest.py: Removed.
2092         * Scripts/webkitpy/scm_unittest.py:
2093         * Scripts/webkitpy/statusserver.py: Removed.
2094         * Scripts/webkitpy/tool/bot/queueengine.py:
2095         * Scripts/webkitpy/tool/commands/download.py:
2096         * Scripts/webkitpy/tool/commands/queries.py:
2097         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2098         * Scripts/webkitpy/tool/commands/queues.py:
2099         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2100         * Scripts/webkitpy/tool/commands/queuestest.py:
2101         * Scripts/webkitpy/tool/commands/upload.py:
2102         * Scripts/webkitpy/tool/main.py:
2103         * Scripts/webkitpy/tool/mocktool.py:
2104         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2105         * Scripts/webkitpy/unittests.py:
2106
2107 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2108
2109         Reviewed by Adam Barth.
2110
2111         In webkitpy, renamed MockBugzillaTool to MockTool.
2112
2113         * Scripts/webkitpy/tool/commands/commandtest.py:
2114         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2115         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2116         * Scripts/webkitpy/tool/commands/queuestest.py:
2117         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2118         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2119         * Scripts/webkitpy/tool/mocktool.py:
2120         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2121         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2122         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
2123
2124 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2125
2126         Reviewed by Adam Barth.
2127
2128         In Scripts/webkitpy, moved webkitport.py and committers.py into
2129         common/config/ (also creating common/config/).
2130
2131         https://bugs.webkit.org/show_bug.cgi?id=36093
2132
2133         This is part of the master bug to reorganize webkitpy.
2134
2135         * Scripts/validate-committer-lists:
2136         * Scripts/webkitpy/bugzilla.py:
2137         * Scripts/webkitpy/bugzilla_unittest.py:
2138         * Scripts/webkitpy/changelogs.py:
2139         * Scripts/webkitpy/commitinfo.py:
2140         * Scripts/webkitpy/commitinfo_unittest.py:
2141         * Scripts/webkitpy/committers.py: Removed.
2142         * Scripts/webkitpy/committers_unittest.py: Removed.
2143         * Scripts/webkitpy/common: Added.
2144         * Scripts/webkitpy/common/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
2145         * Scripts/webkitpy/common/config: Added.
2146         * Scripts/webkitpy/common/config/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
2147         * Scripts/webkitpy/common/config/committers.py: Copied from WebKitTools/Scripts/webkitpy/committers.py.
2148         * Scripts/webkitpy/common/config/committers_unittest.py: Copied from WebKitTools/Scripts/webkitpy/committers_unittest.py.
2149         * Scripts/webkitpy/common/config/ports.py: Copied from WebKitTools/Scripts/webkitpy/webkitport.py.
2150         * Scripts/webkitpy/common/config/ports_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkitport_unittest.py.
2151         * Scripts/webkitpy/mock_bugzillatool.py:
2152         * Scripts/webkitpy/tool/commands/early_warning_system.py:
2153         * Scripts/webkitpy/tool/commands/queries.py:
2154         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2155         * Scripts/webkitpy/tool/commands/upload.py:
2156         * Scripts/webkitpy/tool/steps/abstractstep.py:
2157         * Scripts/webkitpy/unittests.py:
2158         * Scripts/webkitpy/webkitport.py: Removed.
2159         * Scripts/webkitpy/webkitport_unittest.py: Removed.
2160
2161 2010-03-25  Adam Barth  <abarth@webkit.org>
2162
2163         Unreviewed.  Move mock_bugzillatool.py to tool/mocktool.py.
2164
2165         * Scripts/webkitpy/mock_bugzillatool.py: Removed.
2166         * Scripts/webkitpy/tool/commands/commandtest.py:
2167         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2168         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2169         * Scripts/webkitpy/tool/commands/queuestest.py:
2170         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2171         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2172         * Scripts/webkitpy/tool/mocktool.py: Copied from Scripts/webkitpy/mock_bugzillatool.py.
2173         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2174         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2175         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
2176
2177 2010-03-24  Adam Barth  <abarth@webkit.org>
2178
2179         Unreviewed.  Move comments.py and multicommandtool.py to their new
2180         home.
2181
2182         * Scripts/webkitpy/comments.py: Removed.
2183         * Scripts/webkitpy/multicommandtool.py: Removed.
2184         * Scripts/webkitpy/multicommandtool_unittest.py: Removed.
2185         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2186         * Scripts/webkitpy/tool/commands/download.py:
2187         * Scripts/webkitpy/tool/commands/openbugs.py:
2188         * Scripts/webkitpy/tool/commands/queries.py:
2189         * Scripts/webkitpy/tool/commands/queues.py:
2190         * Scripts/webkitpy/tool/commands/upload.py:
2191         * Scripts/webkitpy/tool/comments.py: Copied from Scripts/webkitpy/comments.py.
2192         * Scripts/webkitpy/tool/main.py:
2193         * Scripts/webkitpy/tool/multicommandtool.py: Copied from Scripts/webkitpy/multicommandtool.py.
2194         * Scripts/webkitpy/tool/multicommandtool_unittest.py: Copied from Scripts/webkitpy/multicommandtool_unittest.py.
2195         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
2196         * Scripts/webkitpy/tool/steps/closepatch.py:
2197         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2198         * Scripts/webkitpy/unittests.py:
2199
2200 2010-03-24  Adam Barth  <abarth@webkit.org>
2201
2202         Unreviewed.  Fixup one import statement I didn't find because the .pyc
2203         masked the error.
2204
2205         * Scripts/webkitpy/stepsequence.py:
2206
2207 2010-03-24  Adam Barth  <abarth@webkit.org>
2208
2209         Unreviewed.  Move queueengine.py to its new home.
2210
2211         * Scripts/webkitpy/queueengine.py: Removed.
2212         * Scripts/webkitpy/queueengine_unittest.py: Removed.
2213         * Scripts/webkitpy/tool/bot/queueengine.py: Copied from Scripts/webkitpy/queueengine.py.
2214         * Scripts/webkitpy/tool/bot/queueengine_unittest.py: Copied from Scripts/webkitpy/queueengine_unittest.py.
2215         * Scripts/webkitpy/tool/commands/early_warning_system.py:
2216         * Scripts/webkitpy/tool/commands/queues.py:
2217         * Scripts/webkitpy/unittests.py:
2218
2219 2010-03-24  Adam Barth  <abarth@webkit.org>
2220
2221         Unreviewed.  Move patchcollection.py to its new home.
2222
2223         * Scripts/webkitpy/patchcollection.py: Removed.
2224         * Scripts/webkitpy/patchcollection_unittest.py: Removed.
2225         * Scripts/webkitpy/tool/bot: Added.
2226         * Scripts/webkitpy/tool/bot/__init__.py: Added.
2227         * Scripts/webkitpy/tool/bot/patchcollection.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection.py.
2228         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection_unittest.py.
2229         * Scripts/webkitpy/tool/commands/queues.py:
2230         * Scripts/webkitpy/unittests.py:
2231
2232 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
2233
2234         Reviewed by Adam Barth.
2235
2236         In Scripts/webkitpy, moved steps_references.py and the steps
2237         folder into webkitpy/patch.
2238
2239         https://bugs.webkit.org/show_bug.cgi?id=36093
2240
2241         * Scripts/webkitpy/steps: Removed.
2242         * Scripts/webkitpy/steps/__init__.py: Removed.
2243         * Scripts/webkitpy/steps/abstractstep.py: Removed.
2244         * Scripts/webkitpy/steps/applypatch.py: Removed.
2245         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Removed.
2246         * Scripts/webkitpy/steps/build.py: Removed.
2247         * Scripts/webkitpy/steps/checkstyle.py: Removed.
2248         * Scripts/webkitpy/steps/cleanworkingdirectory.py: Removed.
2249         * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Removed.
2250         * Scripts/webkitpy/steps/closebug.py: Removed.
2251         * Scripts/webkitpy/steps/closebugforlanddiff.py: Removed.
2252         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Removed.
2253         * Scripts/webkitpy/steps/closepatch.py: Removed.
2254         * Scripts/webkitpy/steps/commit.py: Removed.
2255         * Scripts/webkitpy/steps/confirmdiff.py: Removed.
2256         * Scripts/webkitpy/steps/createbug.py: Removed.
2257         * Scripts/webkitpy/steps/editchangelog.py: Removed.
2258         * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Removed.
2259         * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Removed.
2260         * Scripts/webkitpy/steps/metastep.py: Removed.
2261         * Scripts/webkitpy/steps/obsoletepatches.py: Removed.
2262         * Scripts/webkitpy/steps/options.py: Removed.
2263         * Scripts/webkitpy/steps/postdiff.py: Removed.
2264         * Scripts/webkitpy/steps/postdiffforcommit.py: Removed.
2265         * Scripts/webkitpy/steps/postdiffforrevert.py: Removed.
2266         * Scripts/webkitpy/steps/preparechangelog.py: Removed.
2267         * Scripts/webkitpy/steps/preparechangelogforrevert.py: Removed.
2268         * Scripts/webkitpy/steps/promptforbugortitle.py: Removed.
2269         * Scripts/webkitpy/steps/reopenbugafterrollout.py: Removed.
2270         * Scripts/webkitpy/steps/revertrevision.py: Removed.
2271         * Scripts/webkitpy/steps/runtests.py: Removed.
2272         * Scripts/webkitpy/steps/steps_unittest.py: Removed.
2273         * Scripts/webkitpy/steps/update.py: Removed.
2274         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Removed.
2275         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Removed.
2276         * Scripts/webkitpy/steps/validatereviewer.py: Removed.
2277         * Scripts/webkitpy/steps_references.py: Removed.
2278         * Scripts/webkitpy/stepsequence.py:
2279         * Scripts/webkitpy/tool/commands/download.py:
2280         * Scripts/webkitpy/tool/commands/upload.py:
2281         * Scripts/webkitpy/tool/steps: Copied from WebKitTools/Scripts/webkitpy/steps.
2282         * Scripts/webkitpy/tool/steps/__init__.py:
2283         * Scripts/webkitpy/tool/steps/applypatch.py:
2284         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
2285         * Scripts/webkitpy/tool/steps/build.py:
2286         * Scripts/webkitpy/tool/steps/checkstyle.py:
2287         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2288         * Scripts/webkitpy/tool/steps/cleanworkingdirectorywithlocalcommits.py:
2289         * Scripts/webkitpy/tool/steps/closebug.py:
2290         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
2291         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2292         * Scripts/webkitpy/tool/steps/closepatch.py:
2293         * Scripts/webkitpy/tool/steps/commit.py:
2294         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2295         * Scripts/webkitpy/tool/steps/createbug.py:
2296         * Scripts/webkitpy/tool/steps/editchangelog.py:
2297         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
2298         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
2299         * Scripts/webkitpy/tool/steps/metastep.py:
2300         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
2301         * Scripts/webkitpy/tool/steps/postdiff.py:
2302         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
2303         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2304         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2305         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2306         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
2307         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2308         * Scripts/webkitpy/tool/steps/revertrevision.py:
2309         * Scripts/webkitpy/tool/steps/runtests.py:
2310         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2311         * Scripts/webkitpy/tool/steps/update.py:
2312         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
2313         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2314         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2315         * Scripts/webkitpy/tool/steps_references.py: Copied from WebKitTools/Scripts/webkitpy/steps_references.py.
2316         * Scripts/webkitpy/unittests.py:
2317
2318 2010-03-24  Eric Seidel  <eric@webkit.org>
2319
2320         Unreviewed, build fix only.
2321
2322         Abstract LayoutTestResults logic for easier reuse
2323         https://bugs.webkit.org/show_bug.cgi?id=36579
2324
2325         * Scripts/webkitpy/buildbot_unittest.py: Add a missing import.
2326
2327 2010-03-24  Adam Barth  <abarth@webkit.org>
2328
2329         Unreviewed.  Fix a stray comma to test landing an patch without review.
2330
2331         * Scripts/webkitpy/commitinfo.py:
2332
2333 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
2334
2335         Reviewed by Adam Barth.
2336
2337         In Scripts/webkitpy, moved commands_references.py and the commands
2338         folder into webkitpy/patch.
2339
2340         https://bugs.webkit.org/show_bug.cgi?id=36483
2341
2342         This is part of master bug 36093 to organize webkitpy.
2343
2344         * Scripts/webkitpy/commands: Removed.
2345         * Scripts/webkitpy/commands/__init__.py: Removed.
2346         * Scripts/webkitpy/commands/abstractsequencedcommand.py: Removed.
2347         * Scripts/webkitpy/commands/commandtest.py: Removed.
2348         * Scripts/webkitpy/commands/download.py: Removed.
2349         * Scripts/webkitpy/commands/download_unittest.py: Removed.
2350         * Scripts/webkitpy/commands/early_warning_system.py: Removed.
2351         * Scripts/webkitpy/commands/early_warning_system_unittest.py: Removed.
2352         * Scripts/webkitpy/commands/openbugs.py: Removed.
2353         * Scripts/webkitpy/commands/openbugs_unittest.py: Removed.
2354         * Scripts/webkitpy/commands/queries.py: Removed.
2355         * Scripts/webkitpy/commands/queries_unittest.py: Removed.
2356         * Scripts/webkitpy/commands/queues.py: Removed.
2357         * Scripts/webkitpy/commands/queues_unittest.py: Removed.
2358         * Scripts/webkitpy/commands/queuestest.py: Removed.
2359         * Scripts/webkitpy/commands/sheriffbot.py: Removed.
2360         * Scripts/webkitpy/commands/sheriffbot_unittest.py: Removed.
2361         * Scripts/webkitpy/commands/upload.py: Removed.
2362         * Scripts/webkitpy/commands/upload_unittest.py: Removed.
2363         * Scripts/webkitpy/commands_references.py: Removed.
2364         * Scripts/webkitpy/tool/commands: Copied from WebKitTools/Scripts/webkitpy/commands.
2365         * Scripts/webkitpy/tool/commands/commandtest.py:
2366         * Scripts/webkitpy/tool/commands/download.py:
2367         * Scripts/webkitpy/tool/commands/download_unittest.py:
2368         * Scripts/webkitpy/tool/commands/early_warning_system.py:
2369         * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py:
2370         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
2371         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2372         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2373         * Scripts/webkitpy/tool/commands/queuestest.py:
2374         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2375         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2376         * Scripts/webkitpy/tool/commands/upload.py:
2377         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2378         * Scripts/webkitpy/tool/commands_references.py: Copied from WebKitTools/Scripts/webkitpy/commands_references.py.
2379         * Scripts/webkitpy/tool/main.py:
2380         * Scripts/webkitpy/unittests.py:
2381
2382 2010-03-24  Adam Barth  <abarth@webkit.org>
2383
2384         Reviewed by Eric Seidel.
2385
2386         Rename webkitpy.patch to webkitpy.tool
2387         https://bugs.webkit.org/show_bug.cgi?id=36580
2388
2389         This is in preparation for the great webkitpy naming cleanup.
2390
2391         * Scripts/webkit-patch:
2392         * Scripts/webkitpy/patch: Removed.
2393         * Scripts/webkitpy/patch/__init__.py: Removed.
2394         * Scripts/webkitpy/patch/patcher.py: Removed.
2395         * Scripts/webkitpy/tool: Copied from WebKitTools/Scripts/webkitpy/patch.
2396         * Scripts/webkitpy/tool/main.py: Copied from WebKitTools/Scripts/webkitpy/patch/patcher.py.
2397         * Scripts/webkitpy/tool/patcher.py: Removed.
2398
2399 2010-03-24  Eric Seidel  <eric@webkit.org>
2400
2401         Reviewed by Adam Barth.
2402
2403         Abstract LayoutTestResults logic for easier reuse
2404         https://bugs.webkit.org/show_bug.cgi?id=36579
2405
2406         * Scripts/webkitpy/buildbot.py:
2407          - Split out logic into new LayoutTestResults class.
2408         * Scripts/webkitpy/buildbot_unittest.py:
2409          - Rename the testing class to match.
2410         * Scripts/webkitpy/commands/queries.py:
2411          - Use the new LayoutTestResults class.
2412
2413 2010-03-24  Eric Seidel  <eric@webkit.org>
2414
2415         Reviewed by Eric Seidel.
2416
2417         Move Bugzilla.prompt_for_component to User.prompt_with_list for re-use
2418         https://bugs.webkit.org/show_bug.cgi?id=36577
2419
2420         * Scripts/webkitpy/bugzilla.py:
2421          - Move prompt_for_component to User
2422         * Scripts/webkitpy/commands/queries.py:
2423          - Add a missing argument_names declaration.
2424         * Scripts/webkitpy/user.py:
2425          - Add prompt_with_list
2426          - Make staticmethods classmethods for easier mocking
2427
2428 2010-03-24  David Kilzer  <ddkilzer@apple.com>
2429
2430         <http://webkit.org/b/36572> commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLog file
2431
2432         Reviewed by Eric Seidel.
2433
2434         Fixes the following error when committing a file with
2435         "ChangeLog" in the name that isn't a ChangeLog (like
2436         mergeChangeLogs.pl from r56471 and r56472):
2437
2438             $ git commit .
2439             Can't open WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLog at commit-log-editor line 132.
2440             error: There was a problem with the editor 'commit-log-editor'.
2441             Please supply the message using either -m or -F option.
2442
2443         * Scripts/commit-log-editor: Added '$' to anchor "ChangeLog" to
2444         the end of the file name when searching for ChangeLog files in a
2445         commit.
2446
2447 2010-03-24  David Kilzer  <ddkilzer@apple.com>
2448
2449         <http://webkit.org/b/36570> resolve-ChangeLogs: fall back to git-merge-file if ChangeLog can't be merged
2450
2451         Reviewed by Eric Seidel.
2452
2453         * Scripts/resolve-ChangeLogs: Switched to exec git-merge-file if
2454         the merge attempt fails.
2455
2456 2010-03-24  Adam Barth  <abarth@webkit.org>
2457
2458         Reviewed by Eric Seidel.
2459
2460         webkit-patch or pre-commit hook should validate reviewer lines before committing
2461         https://bugs.webkit.org/show_bug.cgi?id=26927
2462
2463         Validate that patches have valid reivewers listed in their ChangeLogs
2464         before landing.  For patches without reviewers can be landed if their
2465         ChangeLogs state that they are unreviewed.
2466
2467         * Scripts/webkitpy/changelogs.py:
2468         * Scripts/webkitpy/commands/download.py:
2469         * Scripts/webkitpy/commitinfo.py:
2470         * Scripts/webkitpy/commitinfo_unittest.py:
2471         * Scripts/webkitpy/mock_bugzillatool.py:
2472         * Scripts/webkitpy/steps/__init__.py:
2473         * Scripts/webkitpy/steps/validatereviewer.py: Added.
2474
2475 2010-03-19  Holger Hans Peter Freyther  <zecke@selfish.org>
2476
2477         Reviewed by David Levin.
2478
2479         Undefined names reported by pyflakes in python scripts
2480         https://bugs.webkit.org/show_bug.cgi?id=36403
2481
2482         Attempt to use names that exist or can exist in the lexical
2483         scope instead of not being available at all.
2484
2485         * Scripts/webkitpy/changelogs.py: Use self._content.
2486         * Scripts/webkitpy/layout_tests/port/base.py: Use os.stat
2487         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Use self._port
2488         * Scripts/webkitpy/style/processors/cpp_unittest.py: Use expected_message_re
2489
2490 2010-03-24  David Kilzer  <ddkilzer@apple.com>
2491
2492         <http://webkit.org/b/36560> resolve-ChangeLogs: git-rebase fails when resolve-ChangeLogs can't merge
2493
2494         Reviewed by Eric Seidel.
2495
2496         When resolve-ChangeLogs fails to merge a patch while running as
2497         a git merge driver, it deletes the original file, which causes
2498         an internal failure and stops git mid-merge:
2499
2500             fatal: Failed to execute internal merge
2501
2502         The fix is to use the --force switch with patch so that it will
2503         always attempt to apply the patch.  (The change in
2504         mergeChangeLogs() for the previous commit also fixed this, but
2505         adding --force also prevents any potential user interaction that
2506         patch may want to display.)
2507
2508         * Scripts/VCSUtils.pm:
2509         (mergeChangeLogs): Added --force switch to patch command.  Also
2510         changed to use the exit status from the patch command to
2511         determine the return value for this method.
2512         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added
2513         test to cover this bug.
2514
2515 2010-03-24  David Kilzer  <ddkilzer@apple.com>
2516
2517         <http://webkit.org/b/36560> resolve-ChangeLogs: move mergeChanges() into VCSUtils package
2518
2519         Reviewed by Eric Seidel.
2520
2521         * Scripts/VCSUtils.pm:
2522         (mergeChangeLogs): Copied from mergeChanges() in
2523         resolve-ChangeLogs and renamed.  Added method documentation.
2524         Fixed bug found by new tests where the original file to be
2525         patched was deleted when cleaning up after a traditinal rejected
2526         patch failed to apply.
2527         * Scripts/resolve-ChangeLogs: Switched to using
2528         mergeChangeLogs().
2529         (mergeChanges): Moved to VCSUtils.pm and renamed to
2530         mergeChangeLogs().
2531         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added.
2532
2533 2010-03-24  Eric Seidel  <eric@webkit.org>
2534
2535         Reviewed by Adam Barth.
2536
2537         Add support for qt's unassigned list to webkit-patch assign-to-committer
2538         https://bugs.webkit.org/show_bug.cgi?id=36559
2539
2540         * Scripts/webkitpy/bugzilla.py:
2541          - Move Bugzilla.unassigned_email into Bug and make it a set.
2542         * Scripts/webkitpy/bugzilla_unittest.py:
2543          - Test the new Bug.is_unassigned method
2544         * Scripts/webkitpy/commands/upload.py:
2545          - Use the new Bug.is_unassigned method instead of an explicit ==
2546         * Scripts/webkitpy/mock_bugzillatool.py:
2547          - Bugzilla.unassigned_email no longer needs mocking
2548
2549 2010-03-24  Kent Hansen  <kent.hansen@nokia.com>
2550
2551         Reviewed by Simon Hausmann.
2552
2553         [Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled
2554         https://bugs.webkit.org/show_bug.cgi?id=36522
2555
2556         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2557         (LayoutTestController::setXSSAuditorEnabled): Use the new name.
2558
2559 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
2560
2561         Reviewed by Shinichiro Hamaji.
2562
2563         Added to check-webkit-style support for a --debug flag.
2564
2565         https://bugs.webkit.org/show_bug.cgi?id=36100
2566
2567         The --debug flag adjusts the logging level to DEBUG and
2568         includes the logger name and level in each log message.
2569
2570         * Scripts/check-webkit-style:
2571           - Changed the code to check for the --debug flag and pass
2572             the result to the configure_logging() method.
2573         * Scripts/webkitpy/style/checker.py:
2574           - Added an is_debug parameter to configure_logging().
2575           - Refactored configure_logging() by adding calls to
2576             the following two methods: _create_log_handlers() and
2577             _create_debug_log_handlers().
2578         * Scripts/webkitpy/style/checker_unittest.py:
2579           - Added unit tests for configure_logging() with is_debug True
2580             by splitting the ConfigureLoggingTest class into
2581             ConfigureLoggingTest and ConfigureLoggingTestBase, and
2582             adding ConfigureLoggingDebugTest.
2583         * Scripts/webkitpy/style/optparser.py:
2584           - Updated the usage string.
2585           - Added an is_debug data attribute to the CommandOptionValues
2586             class.
2587           - Added support for the --debug flag to the ArgumentParser.parse()
2588             method.
2589           - Also added extra error information to the parse() method in
2590             the case of an invalid flag.
2591         * Scripts/webkitpy/style/optparser_unittest.py:
2592           - Updated the unit tests as necessary.
2593           - Also fixed an issue with the CommandOptionValuesTest.test_eq()
2594             unit test.
2595
2596 2010-03-23  Kent Tamura  <tkent@chromium.org>
2597
2598         Reviewed by Dimitri Glazkov.
2599
2600         [DRT/Chromium] Add TestNavigationController and TestWebWorker
2601         https://bugs.webkit.org/show_bug.cgi?id=36489
2602
2603         Add TestNavigationController and TestWebWorker classes, which are
2604         going to be used by DumpRenderTree Chromium port. These files are
2605         based on:
2606         - src/webkit/tools/test_shell/test_navigation_controller.{cc,h}
2607         - src/webkit/tools/test_shell/test_web_worker.h
2608         of Chromium rev.40492.
2609
2610         TestNavigationController has non-style changes.
2611         - Change ContentState type: binary string -> WebHistoryItem
2612         - Remove TestShell dependency by introducing NavigationHost interface.
2613
2614         * DumpRenderTree/chromium/TestNavigationController.cpp: Added.
2615         * DumpRenderTree/chromium/TestNavigationController.h: Added.
2616         * DumpRenderTree/chromium/TestWebWorker.h: Added.
2617
2618 2010-03-23  Eric Seidel  <eric@webkit.org>
2619
2620         Reviewed by Adam Barth.
2621
2622         Add support for revision -> build lookup in buildbot.py and layout test result parsing
2623         https://bugs.webkit.org/show_bug.cgi?id=36474
2624
2625         * Scripts/webkitpy/bugzilla_unittest.py: Added a FIXME about sharing code.
2626         * Scripts/webkitpy/buildbot.py: 
2627          - Add support for looking up builds by revision number.
2628          - Add support for fetching and parsing results.html files from buildbot.
2629          - build_for_revision has an allow_failed_lookups option to work around the fact that
2630            our buildbot's xmlrpc calls return failure on old revision numbers.
2631          - Add parsing support for twisted directory listings.
2632         * Scripts/webkitpy/buildbot_unittest.py:
2633          - Unit test all the new code.
2634         * Scripts/webkitpy/commands/queries.py:
2635          - Add a new results-for command which prints all the results for a given revision (very slow due to slow revision lookup)
2636
2637 2010-03-23  Daniel Bates  <dbates@rim.com>
2638
2639         Reviewed by Adam Roben.
2640
2641         https://bugs.webkit.org/show_bug.cgi?id=36048
2642
2643         Detect if the Windows Platform SDK is missing when building with
2644         Visual C++ Express Edition and inform the user to download it.
2645
2646         * Scripts/webkitdirs.pm:
2647
2648 2010-03-23  Darin Adler  <darin@apple.com>
2649
2650         Tell Subversion about more directories that expect to have .pyc files.
2651
2652         * Scripts/webkitpy: Modified property svn:ignore.
2653         * Scripts/webkitpy/irc: Added property svn:ignore.
2654
2655 2010-03-23  Daniel Bates  <dbates@rim.com>
2656
2657         Reviewed by Adam Barth.
2658
2659         https://bugs.webkit.org/show_bug.cgi?id=36149
2660
2661         Import the GNU readline interface to modify the behavior
2662         of raw_input so as to provide line editing support. In
2663         particular this will prevent "delete" characters from
2664         appearing in the returned value for function raw_input.
2665
2666         * Scripts/webkitpy/user.py:
2667
2668 2010-03-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2669
2670         Reviewed by Kenneth Rohde Christiansen.
2671
2672         [Qt] Remove support for Qt v4.4
2673         https://bugs.webkit.org/show_bug.cgi?id=36389
2674
2675         * DumpRenderTree/qt/main.cpp:
2676         (main):
2677         * QtLauncher/mainwindow.cpp:
2678         (MainWindow::MainWindow):
2679
2680 2010-03-22  Csaba Osztrogon√°c  <ossy@webkit.org>
2681
2682         Reviewed by Adam Barth.
2683
2684         Make build_webkit_command() pass MAKEFLAGS environment variable to make.
2685         https://bugs.webkit.org/show_bug.cgi?id=36440
2686
2687         * Scripts/webkitpy/webkitport.py:
2688         * Scripts/webkitpy/webkitport_unittest.py:
2689
2690 2010-03-22  Dirk Pranke  <dpranke@chromium.org>
2691
2692         Reviewed by Dimitri Glazkov.
2693
2694         Change baseline_path() to point to the upstream locations for the
2695         Chromium ports. Also change the reabselining scripts to use the
2696         correct functions to get the baseline directories, and fix the
2697         script's sys.path to pull in simplejson correctly.
2698
2699         https://bugs.webkit.org/show_bug.cgi?id=36417
2700
2701         * Scripts/rebaseline-chromium-webkit-tests:
2702           - fix sys.path to pick up simplejson properly
2703         * Scripts/webkitpy/layout_tests/port/chromium.py:
2704           - change baseline_path() to use webkit_baseline_path()
2705           - error out correctly if we can't find the chromium base dir
2706         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2707           - call baseline_path(), not chromium_baseline_path()
2708
2709 2010-03-22  Chris Jerdonek  <cjerdonek@webkit.org>
2710
2711         Reviewed by Adam Barth.
2712
2713         Refactored the cpu_count() code in executive.py.
2714
2715         https://bugs.webkit.org/show_bug.cgi?id=36437
2716
2717         * Scripts/webkitpy/executive.py:
2718           - Moved the import of the multiprocessing module to the top
2719             of the file rather than importing from within a function.
2720
2721 2010-03-22 Antonio Gomes <tonikitoo@webkit.org>
2722
2723         Unreviewed.
2724
2725         Rolling out r56183: http://trac.webkit.org/changeset/56183
2726
2727         https://bugs.webkit.org/show_bug.cgi?id=36244
2728
2729         Need to roll out because this patch will be re-worked by the author
2730         and other reviewers agreed on it.
2731
2732 2010-03-22  Chris Jerdonek  <cjerdonek@webkit.org>
2733
2734         Reviewed by Adam Barth.
2735
2736         Created a function for getting a module-specific logging.logger
2737         based on the __file__ value of the module.
2738
2739         https://bugs.webkit.org/show_bug.cgi?id=35821
2740
2741         This function allows us to get the module-specific logger for
2742         a module without having to hard-code the fully-qualified name
2743         of the module in the module itself.  The code can be the same
2744         in every case: "_log = logutils.get_logger(__file__)".
2745
2746         * Scripts/webkitpy/init/logutils.py: Added.
2747           - Added a module with a get_logger() function to return
2748             a module-specific logger based on the module's __file__
2749             variable.
2750
2751         * Scripts/webkitpy/init/logutils_unittest.py: Added.
2752           - Added unit tests for logutils.py.
2753
2754         * Scripts/webkitpy/init/unittests.py:
2755           - Added logutils_unittest to the list of imports.
2756
2757 2010-03-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2758
2759         Reviewed by Simon Hausmann.
2760
2761         [Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
2762         https://bugs.webkit.org/show_bug.cgi?id=36386
2763
2764         Fix the regression by implementing a null printer for Qt DRT.
2765
2766         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2767         (WebCore::NullPrinter::NullPaintEngine::begin):
2768         (WebCore::NullPrinter::NullPaintEngine::end):
2769         (WebCore::NullPrinter::NullPaintEngine::type):
2770         (WebCore::NullPrinter::NullPaintEngine::drawPixmap):
2771         (WebCore::NullPrinter::NullPaintEngine::updateState):
2772         (WebCore::NullPrinter::paintEngine):
2773         (WebCore::DumpRenderTree::dryRunPrint):
2774
2775 2010-03-20  Martin Robinson  <mrobinson@webkit.org>
2776
2777         Reviewed by Xan Lopez.
2778
2779         [GTK] eventSender.zoomPageOut() bug?
2780         https://bugs.webkit.org/show_bug.cgi?id=30575
2781
2782         Make zoomPage{In/Out}Callback respect the 1.2f zoom factor that DRT should be using.
2783
2784         * DumpRenderTree/gtk/EventSender.cpp:
2785         (zoomIn): Added.
2786         (zoomOut): Added.
2787         (textZoomInCallback): Use zoomIn helper function.
2788         (textZoomOutCallback): Use zoomOut helper function.
2789         (zoomPageInCallback): Use zoomIn helper function, which respects zoom factor.
2790         (zoomPageOutCallback): Use zoomOut helper function, which respects zoom factor.
2791
2792 2010-03-20  Kevin Ollivier  <kevino@theolliviers.com>
2793
2794         [wx] Build fix after recent database API change.
2795
2796         * wx/browser/browser.cpp:
2797         (MyApp::OnInit):
2798
2799 2010-03-20  Chris Jerdonek  <cjerdonek@webkit.org>
2800
2801         Reviewed by Adam Barth.
2802
2803         Renamed UnitTestLogStream to TestLogStream in webkitpy.
2804
2805         https://bugs.webkit.org/show_bug.cgi?id=36099
2806
2807         TestLogStream is more concise and more consistent with the name of
2808         the module (logtesting rather than logunittesting) and its main
2809         class (LogTesting rather than LogUnitTesting).
2810
2811         * Scripts/webkitpy/init/logtesting.py:
2812           - Renamings.
2813
2814         * Scripts/webkitpy/style/checker_unittest.py:
2815           - Renamings.
2816
2817         * Scripts/webkitpy/style_references.py:
2818           - Renamings.
2819
2820 2010-03-20  Kevin Ollivier  <kevino@theolliviers.com>
2821
2822         [wx] Build fixes for new method in LayoutTestController.
2823
2824         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2825         (LayoutTestController::setSpatialNavigationEnabled):
2826         * wx/build/settings.py:
2827
2828 2010-03-20  Dimitri Glazkov  <dglazkov@chromium.org>
2829
2830         Unreviewed, tool fix.
2831
2832         Remove vestiges of downstream directory names to unbreak rebaselining tool.
2833
2834         * Scripts/webkitpy/layout_tests/port/chromium.py: Changed paths to use WebKit repo.
2835
2836 2010-03-20  Dirk Pranke  <dpranke@chromium.org>
2837
2838         Reviewed by Dimitri Glazkov.
2839
2840         Re-enable the downstream test_expectations overrides file that was
2841         disabled in bug 36396 / r56287.
2842
2843         https://bugs.chromium.org/show_bug.cgi?id=36401
2844
2845         * Scripts/webkitpy/layout_tests/port/chromium.py:
2846
2847 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
2848
2849         Reviewed by Dimitri Glazkov.
2850
2851         Disable the downstream override expectations temporarily to allow
2852         us to test that we've upstreamed everything correctly. Also, stop
2853         looking at the downstream baselines at all (now you will only be
2854         able to update baselines upstream). In theory this should work, but
2855         if we need to we can always add the downstream dirs back in.
2856
2857         https://bugs.webkit.org/show_bug.cgi?id=36396
2858
2859         * Scripts/webkitpy/layout_tests/port/chromium.py:
2860         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2861         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2862         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2863
2864 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
2865
2866         Reviewed by Dimitri Glazkov.
2867
2868         fix typo in chromium test expectations overrides routine
2869         https://bugs.webkit.org/show_bug.cgi?id=36397
2870
2871         * Scripts/webkitpy/layout_tests/port/chromium.py:
2872
2873 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
2874
2875         Reviewed by Dimitri Glazkov.
2876
2877         Flip the Chromium ports to look first for the test expectations
2878         in LayoutTests/platform/chromium and only afterwards look in the
2879         Chromium repo downstream for overrides.
2880
2881         https://bugs.webkit.org/show_bug.cgi?id=36326
2882
2883         * Scripts/webkitpy/layout_tests/port/chromium.py:
2884
2885 2010-03-19  James Hawkins  <jhawkins@chromium.org>
2886
2887         Unreviewed.
2888
2889         Add myself to the committers list.
2890
2891         * Scripts/webkitpy/committers.py:
2892
2893 2010-03-19  Adam Barth  <abarth@webkit.org>
2894
2895         Unreviewed.
2896
2897         Fix SheriffBot exception lock when we can't retrieve the first build
2898         from buildbot.  (I'll ask Eric to review this change after the fact,
2899         but he's at lunch and I want to get the bot unlocked.)
2900
2901         * Scripts/webkitpy/buildbot.py:
2902         * Scripts/webkitpy/buildbot_unittest.py:
2903
2904 2010-03-19  Alexey Proskuryakov  <ap@apple.com>
2905
2906         Reviewed by Darin Adler.
2907
2908         https://bugs.webkit.org/show_bug.cgi?id=36380
2909         websocket/tests/frame-lengths.html times out on Tiger bot
2910
2911         https://bugs.webkit.org/show_bug.cgi?id=35041
2912         websocket/tests/frame-lengths.html / websocket/tests/simple-stress.html fail on Windows bot
2913
2914         Double the timeout (from 15 seconds to 30 seconds). We can increase it more, if necessary -
2915         sampling the DRT process on Mac OS X takes much longer anyway, so it's better to avoid
2916         timing out than to detect it early.
2917
2918         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2919         (LayoutTestController::setWaitToDump):
2920         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2921         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2922         (LayoutTestController::waitUntilDone):
2923         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2924         * Scripts/run-webkit-tests:
2925
2926 2010-03-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2927
2928         Unreviewed.
2929
2930         Buildfix for Qt v4.5.
2931
2932         * QtLauncher/main.cpp:
2933         (LauncherWindow::LauncherWindow):
2934         (LauncherWindow::applyZoom):
2935
2936 2010-03-19  Adam Barth  <abarth@webkit.org>
2937
2938         Reviewed by Eric Seidel.
2939
2940         Operational tweaks to SheriffBot
2941         https://bugs.webkit.org/show_bug.cgi?id=36385
2942
2943         These changes aren't pretty, but they're helpful to make SheriffBot
2944         work operationally.  I plan to iterate in these areas, but I wanted to
2945         get this patch landed so I could be running the bot against TOT.
2946
2947         * Scripts/webkitpy/commands/sheriffbot.py:
2948         * Scripts/webkitpy/irc/ircbot.py:
2949         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:
2950
2951 2010-03-19  Eric Seidel  <eric@webkit.org>
2952
2953         Reviewed by Adam Barth.
2954
2955         Help sheriff-bot avoid warning about flaky tests (and add more unit testing)
2956         https://bugs.webkit.org/show_bug.cgi?id=36354
2957
2958         * Scripts/webkitpy/buildbot.py:
2959          - Make Build creation easier to Mock and test
2960         * Scripts/webkitpy/buildbot_unittest.py:
2961          - Test finding green to red transitions and suspect revisions
2962         * Scripts/webkitpy/commands/queries.py:
2963          - Make what-broke note when builders have only failed once.
2964
2965 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
2966
2967         Reviewed by Dimitri Glazkov.
2968
2969         Fix the rebaselining tool, which was broken by r36324 when I
2970         added the concept of overridding expectations.
2971
2972         https://bugs.webkit.org/show_bug.cgi?id=36374
2973
2974         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2975
2976 2010-03-19  Adam Barth  <abarth@webkit.org>
2977
2978         Reviewed by Eric Seidel.
2979
2980         Misc bug fixes to make the SheriffBot actually work
2981         https://bugs.webkit.org/show_bug.cgi?id=36355
2982
2983         With these changes, I can actually run the sheriff-bot from start to
2984         finish.
2985
2986         * Scripts/webkitpy/irc/ircproxy.py:
2987         * Scripts/webkitpy/patch/patcher.py:
2988         * Scripts/webkitpy/statusserver.py:
2989
2990 2010-03-19  Adam Barth  <abarth@webkit.org>
2991
2992         Unreviewed.
2993
2994         Actually import the sheriff-bot command so we can run it.  Also, move
2995         the bot to #webkit-test so it doesn't cause a ruckus while we test it.
2996
2997         * Scripts/webkitpy/patch/patcher.py:
2998         * Scripts/webkitpy/irc/ircbot.py:
2999
3000 2010-03-19  Adam Barth  <abarth@webkit.org>
3001
3002         Reviewed by Eric Seidel.
3003
3004         Second cut at SheriffBot
3005         https://bugs.webkit.org/show_bug.cgi?id=36353
3006
3007         This patch should contain a complete SheriffBot that's capable of
3008         saying reasonable things on IRC.  I had to refactor the use of
3009         CommitInfo to make the SheriffBot testable, but I did the minimum
3010         necessary.  We should grow webkitcheckout over time to contain the
3011         knowledge of ChangeLogs from scm.
3012
3013         * Scripts/webkitpy/commands/sheriffbot.py:
3014         * Scripts/webkitpy/commands/sheriffbot_unittest.py:
3015         * Scripts/webkitpy/mock_bugzillatool.py:
3016         * Scripts/webkitpy/patch/patcher.py:
3017         * Scripts/webkitpy/webkitcheckout.py: Added.
3018
3019 2010-03-19  Adam Barth  <abarth@webkit.org>
3020
3021         Unreviewed.
3022
3023         Fix Hyatt's IRC nickname.
3024
3025         * Scripts/webkitpy/committers.py:
3026
3027 2010-03-19  Adam Barth  <abarth@webkit.org>
3028
3029         Unreviewed.
3030
3031         Add IRC nicknames for the non-reviewer committers.
3032
3033         * Scripts/webkitpy/committers.py:
3034
3035 2010-03-19  Adam Barth  <abarth@webkit.org>
3036
3037         Unreviewed.
3038
3039         More reviewer IRC nicknames.
3040
3041         * Scripts/webkitpy/committers.py:
3042
3043 2010-03-19  Adam Barth  <abarth@webkit.org>
3044
3045         Unreviewed.
3046
3047         Add a bunch of IRC nicknames for reviewers.
3048
3049         * Scripts/webkitpy/committers.py:
3050
3051 2010-03-19  Zoltan Horvath  <zoltan@webkit.org>
3052
3053         Reviewed by Oliver Hunt.
3054
3055         Added USE_SYSTEM_MALLOC flag to build-webkit
3056         https://bugs.webkit.org/show_bug.cgi?id=21272
3057
3058         Add system-alloc flag to build-webkit. It makes easy to switch
3059         between system allocator and TCmalloc.
3060
3061         * Scripts/build-webkit:
3062
3063 2010-03-19  Adam Barth  <abarth@webkit.org>
3064
3065         Unreviewed "build" fix.
3066
3067         Of course, I caused a regression in the file that isn't tested.  :(
3068
3069         * Scripts/webkitpy/statusserver.py:
3070
3071 2010-03-19  Eric Seidel  <eric@webkit.org>
3072
3073         Reviewed by Adam Barth.
3074
3075         Add basic "who-broke-it" command and revision -> broken builder association code
3076         https://bugs.webkit.org/show_bug.cgi?id=36352
3077
3078         The "what-broke" command prints builders and what revisions we suspect
3079         broke them.  who-broke-it prints revisions and what builders we suspect
3080         they broke.  The sheriff-bot needs this revision to broken builder mapping
3081         so this change adds it!
3082
3083         * Scripts/webkitpy/buildbot.py:
3084         * Scripts/webkitpy/commands/queries.py:
3085
3086 2010-03-19  Eric Seidel  <eric@webkit.org>
3087
3088         Reviewed by Adam Barth.
3089
3090         Simplify BuildBot core builder code for easier re-use
3091         https://bugs.webkit.org/show_bug.cgi?id=36350
3092
3093         I simply couldn't see anything through all this Yak-hair.
3094
3095         * Scripts/webkitpy/buildbot.py:
3096         * Scripts/webkitpy/commands/queries.py:
3097
3098 2010-03-19  Adam Barth  <abarth@webkit.org>
3099
3100         Reviewed by Eric Seidel.
3101
3102         committers.py should know IRC nicknames
3103         https://bugs.webkit.org/show_bug.cgi?id=36349
3104
3105         I'll add the actual nicknames in another patch.
3106
3107         * Scripts/webkitpy/committers.py:
3108         * Scripts/webkitpy/committers_unittest.py:
3109
3110 2010-03-18  Anders Bakken  <agbakken@gmail.com>
3111
3112         Reviewed by Simon Hausmann.
3113
3114         https://bugs.webkit.org/show_bug.cgi?id=36318
3115
3116         QtLauncher runs as a GuiClient by default in Qt Embedded which will
3117         make it try to connect to an existing GuiServer. This patch makes it
3118         run like a stand-alone app.
3119
3120         * QtLauncher/main.cpp:
3121         (LauncherApplication::LauncherApplication):
3122
3123 2010-03-19  Eric Seidel  <eric@webkit.org>
3124
3125         Reviewed by Adam Barth.
3126
3127         Move find_green_to_red_transition out of "what-broke" onto Builder for easier re-use
3128         https://bugs.webkit.org/show_bug.cgi?id=36345
3129
3130         * Scripts/webkitpy/buildbot.py:
3131         * Scripts/webkitpy/commands/queries.py:
3132
3133 2010-03-19  Adam Barth  <abarth@webkit.org>
3134
3135         Reviewed by Adam Barth.
3136
3137         Actually pass the IRC password to the IRC object
3138         https://bugs.webkit.org/show_bug.cgi?id=36346
3139
3140         I wanted to do this before, but both patches were in flight.  This
3141         patch finally closes the loop and makes the IRCProxy system complete.
3142
3143         * Scripts/webkitpy/patch/patcher.py:
3144
3145 2010-03-18  Adam Barth  <abarth@webkit.org>
3146
3147         Reviewed by Eric Seidel.
3148
3149         Add a StatusServer front end to the SVNRevision table on QueueStatusServer
3150         https://bugs.webkit.org/show_bug.cgi?id=36344
3151
3152         No test because Browser was too hard to mock.  :(  I couldn't figure
3153         out how to make Mock be a dictionary as well as an object.
3154
3155         * Scripts/webkitpy/statusserver.py:
3156
3157 2010-03-18  Eric Seidel  <eric@webkit.org>
3158
3159         Reviewed by Adam Barth.
3160
3161         Split out CommitInfo class and add unit tests
3162         https://bugs.webkit.org/show_bug.cgi?id=36343
3163
3164         Move more logic out of "what-broke" into a shared CommitInfo
3165         class so that it can be used by other commands and unit tested.
3166
3167         * Scripts/webkitpy/commands/queries.py:
3168         * Scripts/webkitpy/commitinfo.py: Added.
3169         * Scripts/webkitpy/commitinfo_unittest.py: Added.
3170         * Scripts/webkitpy/unittests.py:
3171
3172 2010-03-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3173
3174         Reviewed by Kenneth Rohde Christiansen.
3175
3176         [Qt] Fix LayoutTests/http/tests/appcache/max-size.html
3177         https://bugs.webkit.org/show_bug.cgi?id=36207
3178
3179         Implement setAppCacheMaximumSize() for Qt.
3180
3181         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3182         (LayoutTestController::setAppCacheMaximumSize):
3183         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3184
3185 2010-03-18  Adam Barth  <abarth@webkit.org>
3186
3187         Reviewed by Eric Seidel.
3188
3189         QueueStatusServer should be able to log broken bots
3190         https://bugs.webkit.org/show_bug.cgi?id=36341
3191
3192         We need to add a new table to the QueueStatusServer to store persistent
3193         information for the SheriffBot.  The new table will keep track of which
3194         bots each SVN revision broke.
3195
3196         * QueueStatusServer/handlers/__init__.py:
3197         * QueueStatusServer/handlers/svnrevision.py: Added.
3198         * QueueStatusServer/handlers/updatebase.py: Added.
3199         * QueueStatusServer/handlers/updatestatus.py:
3200         * QueueStatusServer/handlers/updatesvnrevision.py: Added.
3201         * QueueStatusServer/index.yaml:
3202         * QueueStatusServer/main.py:
3203         * QueueStatusServer/model/__init__.py:
3204         * QueueStatusServer/model/svnrevision.py: Added.
3205         * QueueStatusServer/templates/updatesvnrevision.html: Added.
3206
3207 2010-03-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3208
3209         Reviewed by Darin Adler.
3210
3211         Add a new method to the Qt LayoutTestController for
3212         changing media type and make the DRT support dry-run printing.
3213
3214         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3215         (WebCore::DumpRenderTree::DumpRenderTree):
3216         (WebCore::DumpRenderTree::dryRunPrint):
3217         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3218         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3219         (LayoutTestController::setMediaType):
3220         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3221
3222 2010-03-18  Dirk Pranke  <dpranke@chromium.org>
3223
3224         Reviewed by Dimitri Glazkov.
3225
3226         Add upstream LayoutTests/platform/chromium* directories to the
3227         baseline search path for new-run-webkit-tests in preparation for
3228         upstreaming all of the Chromium baselines. Note that this does
3229         not actually create the directories themselves, but that's okay.
3230
3231         https://bugs.webkit.org/show_bug.cgi?id=36324
3232
3233         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3234         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3235         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3236
3237 2010-03-18  Alexey Proskuryakov  <ap@apple.com>
3238
3239         Reviewed by Anders Carlsson.
3240
3241         https://bugs.webkit.org/show_bug.cgi?id=36327
3242         Test that a plug-in can override Node methods of its element
3243
3244         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3245         (normalizeOverride):
3246         (pluginInvoke):
3247         Override "normalize", and call back to let a test know that the plug-in was called.
3248
3249 2010-03-17  Dirk Pranke  <dpranke@chromium.org>
3250
3251         Reviewed by Dimitri Glazkov.
3252
3253         Add the concept of an "overrides" file for expectations so that we
3254         can store test_expectations both upstream and downstream for a port
3255         that runs both in webkit.org and in a separate repository (like
3256         Chromium). Also add some unit tests for the expectations module.
3257
3258         https://bugs.webkit.org/show_bug.cgi?id=36249
3259
3260         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3261         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py: Added.
3262         * Scripts/webkitpy/layout_tests/port/base.py:
3263         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3264
3265 2010-03-18  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3266
3267         Reviewed by Kenneth Rohde Christiansen.
3268
3269         Add an overlay QGraphicsTextItem to QtLauncher so we can display FPS info
3270         on the launcher and not on the terminal anymore.
3271
3272         [Qt] QtLauncher's FPS info should be displayed on an overlay text item
3273         https://bugs.webkit.org/show_bug.cgi?id=36244
3274
3275         * QtLauncher/webview.cpp:
3276         (WebViewGraphicsBased::WebViewGraphicsBased):
3277         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
3278         (WebViewGraphicsBased::updateFrameRate):
3279         * QtLauncher/webview.h:
3280
3281 2010-03-18  Adam Barth  <abarth@webkit.org>
3282
3283         Reviewed by Eric Seidel.
3284
3285         First cut at SheriffBot
3286         https://bugs.webkit.org/show_bug.cgi?id=36253
3287
3288         This patch contains a first attempt at writing a sheriff bot.
3289         Currently, we're missing the logic that actually finds the SVN revision
3290         numbers to complain about, but once we have that, we'll have the rest
3291         of the infrustructure to ping IRC and to file bugs.
3292
3293         There's a lot to fill in for the SheriffBot, but this patch give us the
3294         framework in which to do it.
3295
3296         This patch required a bit of refactoring of AbstractQueue because
3297         SheriffBot is the first bot that doesn't process patches (it processes
3298         SVN revisions).  Accordingly, I've factored out AbstractPatchQueue to
3299         hold the parts of AbstractQueue that are specific to dealing with
3300         patches.  Some of the choices here might not be obvious yet, but we can
3301         tweak them as our needs become clearer.
3302
3303         * Scripts/webkitpy/commands/queues.py:
3304         * Scripts/webkitpy/commands/queues_unittest.py:
3305         * Scripts/webkitpy/commands/sheriffbot.py: Added.
3306         * Scripts/webkitpy/commands/sheriffbot_unittest.py: Added.
3307         * Scripts/webkitpy/mock_bugzillatool.py:
3308             Added a MockIRC object to the mock tool.
3309         * Scripts/webkitpy/multicommandtool.py:
3310             Added a finalize method so the tool can disconnect from IRC
3311             cleanly instead of just droping the socket.
3312         * Scripts/webkitpy/multicommandtool_unittest.py:
3313         * Scripts/webkitpy/patch/patcher.py:
3314             Added support for talking to IRC.
3315         * Scripts/webkitpy/unittests.py:
3316             We should add a commands/unittests.py file at some point to make
3317             the commands module more self-contained.
3318
3319 2010-03-18  Antti Koivisto  <koivisto@iki.fi>
3320
3321         Reviewed by Kenneth Rohde Christiansen.
3322
3323         https://bugs.webkit.org/show_bug.cgi?id=36102
3324         [Qt] Scaling control API for tiled backing store
3325         
3326         Add animated smooth zooming to Qt launcher when in tiled mode.
3327
3328         * QtLauncher/main.cpp:
3329         (LauncherWindow::LauncherWindow):
3330         (LauncherWindow::zoomAnimationFinished):
3331         (LauncherWindow::applyZoom):
3332         (LauncherWindow::zoomIn):
3333         (LauncherWindow::zoomOut):
3334         * QtLauncher/webview.h:
3335         (WebViewGraphicsBased::graphicsWebView):
3336
3337 2010-03-18  Adam Barth  <abarth@webkit.org>
3338
3339         Reviewed by Eric Seidel.
3340
3341         Support using IRC accounts with a password
3342         https://bugs.webkit.org/show_bug.cgi?id=36287
3343
3344         Add a global option to specify an IRC password so we can use the
3345         sheriffbot account (which needs a password).
3346
3347         * Scripts/webkitpy/irc/ircbot.py:
3348         * Scripts/webkitpy/irc/ircproxy.py:
3349         * Scripts/webkitpy/patch/patcher.py:
3350
3351 2010-03-18  Eric Seidel  <eric@webkit.org>
3352
3353         Just fixing missing parenthesis typo, no review.
3354
3355         * Scripts/webkitpy/commands/queries.py: '%' has higher precedence than 'or', use parentheses.
3356
3357 2010-03-18  Alexey Proskuryakov  <ap@apple.com>
3358
3359         Reviewed by Adam Roben and Anders Carlsson.
3360
3361         https://bugs.webkit.org/show_bug.cgi?id=36210
3362         plugins/resize-from-plugin.html fails on some platforms
3363
3364         Turns out that most platforms don't use "cross-platform" main.cpp. Copied code added for
3365         the test to their versions of the file.
3366
3367         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3368         (webkit_test_plugin_set_window):
3369         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3370         (NPP_SetWindow):
3371
3372 2010-03-18  Leandro Pereira  <leandro@profusion.mobi>
3373
3374         Reviewed by Kenneth Rohde Christiansen.
3375
3376         Add support to run-launcher to open the EFL example browser.
3377         http://webkit.org/b/36181
3378
3379         * Scripts/webkitdirs.pm:
3380         * Scripts/run-launcher:
3381
3382 2010-03-18  Sergio Villar Senin  <svillar@igalia.com>
3383
3384         Reviewed by Xan Lopez.
3385
3386         [GTK] Failing tests http/tests/misc/image-blocked-src-change.html
3387         & http/tests/misc/image-blocked-src-no-change.html
3388         https://bugs.webkit.org/show_bug.cgi?id=36227
3389
3390         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3391         (webViewConsoleMessage): print only the file name instead of the
3392         whole URI when printing messages with local URI's
3393
3394 2010-03-18  Eric Seidel  <eric@webkit.org>
3395
3396         Reviewed by Adam Barth.
3397
3398         Teach what-broke how to look up reviewer and author Committer objects by name
3399         https://bugs.webkit.org/show_bug.cgi?id=36264
3400
3401         * Scripts/webkitpy/commands/queries.py:
3402          - Add committer_by_name lookups for both reviewer and author
3403          - Improve printing in the cases where lookups fail.
3404         * Scripts/webkitpy/committers.py:
3405          - Add committer_by_name
3406         * Scripts/webkitpy/committers_unittest.py:
3407          - Test committer_by_name
3408
3409 2010-03-17  Adam Barth  <abarth@webkit.org>
3410
3411         Reviewed by Eric Seidel.
3412
3413         create-rollout should actually fill out the description
3414         https://bugs.webkit.org/show_bug.cgi?id=36261
3415
3416         * Scripts/webkitpy/commands/download.py:
3417             The % operator was applied to the wrong string.
3418         * Scripts/webkitpy/commands/download_unittest.py:
3419         * Scripts/webkitpy/commands/upload_unittest.py:
3420         * Scripts/webkitpy/mock_bugzillatool.py:
3421             Add support for seeing what we actually do with create_bug.
3422
3423 2010-03-17  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3424
3425         Reviewed by Kenneth Rohde Christiansen.
3426
3427         Accelerated Compositing is now default on QtWebKit so the option
3428         in QtLauncher must be true as default.
3429
3430         [Qt] QtLauncher's Accelerated Compositing option must be true as default
3431         https://bugs.webkit.org/show_bug.cgi?id=36234
3432
3433         * QtLauncher/main.cpp:
3434         (LauncherWindow::applyPrefs):
3435         (LauncherWindow::toggleAcceleratedCompositing):
3436         (LauncherApplication::handleUserOptions):
3437
3438 2010-03-17  Adam Barth  <abarth@webkit.org>
3439
3440         Reviewed by Eric Seidel.
3441
3442         Commit queue should ignore (probably red) builders when landing rollouts
3443         https://bugs.webkit.org/show_bug.cgi?id=36169
3444
3445         When landing a rollout, the builders are probably red, so we need to
3446         ignore them in the subprocess too.  Also, we might as well update the
3447         working copy because we haven't validated anything about the current
3448         revision prior to trying to land.
3449
3450         This change is testable, but it requires changing the mock executive to
3451         log its arguments.  That will generate a lot of expectation changes, so
3452         I'd like to do that in a separate patch.
3453
3454         * Scripts/webkitpy/commands/queues.py:
3455
3456 2010-03-17  Chang Shu  <chang.shu@nokia.com>
3457
3458         Reviewed by Laszlo Gombos.
3459
3460         https://bugs.webkit.org/show_bug.cgi?id=36139
3461         [Qt] Clean up cache each time DumpRenderTree starts. This behavior 
3462         matches other platforms, such as mac and gtk.
3463
3464         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3465         (WebCore::DumpRenderTree::DumpRenderTree):
3466
3467 2010-03-17  Adam Barth  <abarth@webkit.org>
3468
3469         Unreviewed.
3470
3471         Turns out this needs to be a string.
3472
3473         * Scripts/webkitpy/bugzilla.py:
3474
3475 2010-03-17  Eric Seidel  <eric@webkit.org>
3476
3477         Reviewed by Adam Barth.
3478
3479         Add more infrastructure for sheriff-bot, including making what-broke more awesome
3480         https://bugs.webkit.org/show_bug.cgi?id=36254
3481
3482         * Scripts/webkitpy/bugzilla.py:
3483          - Made the various URL methods return None when passed None.
3484         * Scripts/webkitpy/bugzilla_unittest.py:
3485          - Test that the url methods work as expected.
3486         * Scripts/webkitpy/buildbot.py:
3487          - Add a static Build.build_url so that its possible to generate a build url without a Build object.
3488          - Give users a URL in _fetch_xmlrpc_build_dictionary error message.
3489         * Scripts/webkitpy/changelogs.py:
3490          - Add a new ChangeLogEntry class to encapsulate entry-parsing logic.
3491          - Add is_path_to_changelog to greatly simplify SCM.modified_changelogs code.
3492          - Make ChangeLog.parse_latest_entry_from_file a public method.
3493         * Scripts/webkitpy/changelogs_unittest.py:
3494          - Add tests for new ChangeLog entry parsing.
3495         * Scripts/webkitpy/commands/queries.py:
3496          - Make "what-broke" not print "ok" builders, only failing ones.
3497          - Print much more information on failing builders, including links and authorship/reviewer information.
3498         * Scripts/webkitpy/commands/queues_unittest.py:
3499          - Use a fake_checkout path since fixing the cwd (as part of fixing scm_unittests.py) was breaking tests.
3500         * Scripts/webkitpy/mock_bugzillatool.py:
3501          - Move MockSCM away from using os.getcwd() as that was fragile (and wrong).
3502         * Scripts/webkitpy/patch/patcher.py:
3503          - Remove code which was broken now that this file has moved.
3504          - Code was also redundant now that SCM.find_checkout_root() exists.
3505         * Scripts/webkitpy/scm.py:
3506          - Greatly simplify modified_changelogs now that I understand list comprehensions.
3507          - Expect ChangeLogEntry objects instead of raw strings.
3508          - Add changed_files_for_revision, committer_email_for_revision and contents_at_revision
3509          - Add commit_with_message argument to all sites since someone half-added it before. :(
3510          - Get rid of copy/paste code using _status_regexp()
3511         * Scripts/webkitpy/scm_unittest.py:
3512          - Fix these tests!
3513          - Add new tests for new scm code.
3514          - Fix spelling of "awsome" to "awesome".
3515
3516 2010-03-17  Daniel Bates  <dbates@rim.com>
3517
3518         Rubber-stamped by David Levin.
3519
3520         Add myself to the list of reviewers.
3521
3522         * Scripts/webkitpy/committers.py:
3523
3524 2010-03-17  Adam Barth  <abarth@webkit.org>
3525
3526         Reviewed by Eric Seidel.
3527
3528         Change post-rollout to create-rollout and have it make a new bug
3529         instead of posting the rollout to the old bug.
3530         https://bugs.webkit.org/show_bug.cgi?id=36250
3531
3532         The new bug blocks the old bug instead of adding more complexity to the
3533         old bug.  One tricky question is whether to create the bug if we're
3534         unable to create a rollout patch.  In this patch, we do create the bug,
3535         but we might revist this question in the future.
3536
3537         * Scripts/webkitpy/bugzilla.py:
3538         * Scripts/webkitpy/commands/download.py:
3539         * Scripts/webkitpy/commands/download_unittest.py:
3540         * Scripts/webkitpy/steps/createbug.py:
3541
3542 2010-03-17  Adam Barth  <abarth@webkit.org>
3543
3544         Reviewed by Eric Seidel.
3545
3546         Add a way for the bots to send messages to IRC
3547         https://bugs.webkit.org/show_bug.cgi?id=36235
3548
3549         We'll use these classes to notify #webkit about bad SVN revisions.
3550         This patch just has some skeleton code for us to play with.
3551
3552         * Scripts/webkitpy/irc/__init__.py: Added.
3553         * Scripts/webkitpy/irc/ircbot.py: Added.
3554             A bot that knows how to talk to IRC.
3555         * Scripts/webkitpy/irc/ircproxy.py: Added.
3556             We need to run the bot on its own thread because the irclib needs
3557             its own mainloop.  This class provides an abstraction of the
3558             threading.
3559         * Scripts/webkitpy/irc/messagepump.py: Added.
3560         * Scripts/webkitpy/irc/messagepump_unittest.py: Added.
3561         * Scripts/webkitpy/irc/threadedmessagequeue.py: Added.
3562             A thread-safe message queue for sending messages from the main
3563             thread to the IRC thread.
3564         * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Added.
3565         * Scripts/webkitpy/irc/unittests.py: Added.
3566         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:
3567             Autoinstall irclib
3568         * Scripts/webkitpy/unittests.py: