1 2007-12-02 Sam Weinig <sam@webkit.org>
3 Rubber stamped by Niko.
5 Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
7 * DumpRenderTree/win/DumpRenderTree.cpp:
8 * DumpRenderTree/win/DumpRenderTree.vcproj:
9 * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
10 * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
11 * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
12 * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
14 2007-12-01 Alp Toker <alp@atoker.com>
16 Reviewed by Adam Roben.
18 Make use of the newly introduced webkit.h convenience header.
22 2007-12-01 Adam Treat <treat@kde.org>
26 * Check to see if the directory exists and exit if not.
28 * DumpRenderTree/qt/main.cpp:
31 2007-12-01 Adam Treat <treat@kde.org>
35 * Don't hide symbols when in Debug mode
36 * On Linux (glibc) provide a backtrace in the test output for debugging purposes
39 * DumpRenderTree/qt/main.cpp:
42 2007-11-30 Alp Toker <alp@atoker.com>
44 Reviewed by Adam Roben.
46 http://bugs.webkit.org/show_bug.cgi?id=15691
47 [GTK] Public API does not follow GTK+ conventions
49 Refactor the WebKit/GTK+ public API. Changes:
50 WebKitPage -> WebKitWebView
51 WebKitFrame -> WebKitWebFrame
53 Public API source and header names have been updated to mirror the API
56 The API is now kept in WebKit/gtk/WebView to match other ports in the
57 same class such as Mac and Win.
60 (activate_uri_entry_cb):
69 2007-11-30 Adam Roben <aroben@apple.com>
71 Hopefully the final build fix
73 * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
74 pull in WTF's assertion/logging functions.
76 2007-11-30 Adam Roben <aroben@apple.com>
80 * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
83 2007-11-30 Adam Roben <aroben@apple.com>
87 * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
89 * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
91 * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
92 * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
93 WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
95 2007-11-30 Sam Weinig <sam@webkit.org>
97 Reviewed by Adam Roben.
99 Fix drawSelectionRect to actually draw the selection rect.
101 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
104 2007-11-30 Darin Adler <darin@apple.com>
106 * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
108 2007-11-30 Darin Adler <darin@apple.com>
110 * Scripts/do-webcore-rename: Get ready for some future renaming.
112 2007-11-29 Kevin McCullough <kmccullough@apple.com>
116 - Removed some unnecessary functions and changed an unused return type.
118 * Drosera/win/DebuggerClient.cpp:
119 (registerConsoleClass):
120 * Drosera/win/DebuggerClient.h:
121 * Drosera/win/Drosera.cpp:
122 (registerDroseraClass):
124 2007-11-28 Alp Toker <alp@atoker.com>
126 Reviewed by Timothy Hatcher.
128 http://bugs.webkit.org/show_bug.cgi?id=16174
129 [GTK] Use "URI" not "URL" in public API
131 Replace use of the term "URL" with "URI" in public headers,
132 documentation and some internal code to match GLib/GTK+ convention.
134 This is now mentioned in the API guidelines:
135 http://trac.webkit.org/projects/webkit/wiki/HackingGtk
137 * GtkLauncher/main.c:
138 (activate_uri_entry_cb):
143 2007-11-29 Anders Carlsson <andersca@apple.com>
147 <rdar://problem/5230478>
148 FrameLoadDelegate callbacks are not dumped in DRT.
150 * DumpRenderTree/win/DumpRenderTree.cpp:
151 (shouldLogFrameLoadDelegates):
154 * DumpRenderTree/win/FrameLoaderDelegate.cpp:
156 (descriptionSuitableForTestResult):
157 (FrameLoadDelegate::QueryInterface):
158 (FrameLoadDelegate::didStartProvisionalLoadForFrame):
159 (FrameLoadDelegate::didFailProvisionalLoadWithError):
160 (FrameLoadDelegate::didCommitLoadForFrame):
161 (FrameLoadDelegate::didFinishLoadForFrame):
162 (FrameLoadDelegate::willCloseFrame):
163 (FrameLoadDelegate::didClearWindowObject):
164 (FrameLoadDelegate::didFinishDocumentLoadForFrame):
165 (FrameLoadDelegate::didHandleOnloadEventsForFrame):
166 * DumpRenderTree/win/FrameLoaderDelegate.h:
167 (FrameLoadDelegate::windowScriptObjectAvailable):
168 (FrameLoadDelegate::didFirstLayoutInFrame):
170 2007-11-29 Sam Weinig <sam@webkit.org>
174 Add database quota UIDelegates methods to DRT UIDelegate.
176 * DumpRenderTree/mac/UIDelegate.mm:
177 (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
178 (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
180 2007-11-29 Kevin McCullough <kmccullough@apple.com>
184 - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
185 dying and vice versa.
186 - This fix will allow Drosera and Safari to reconnect if either of them
187 closes correctly, but does not fix the case where one of them dies
190 * Drosera/win/ServerConnection.cpp:
191 (ServerConnection::attemptToCreateServerConnection): Added a safety
192 check, because it's possilbe to try to connect to a server that's dying.
193 (ServerConnection::serverDidDie): Implemented. This resets Drosera when
195 * Drosera/win/ServerConnection.h: Added the new function and removed
196 an unnecessary member.
198 2007-11-29 Anders Carlsson <andersca@apple.com>
200 * DumpRenderTree/win/DumpRenderTree.vcproj:
201 Add shlwapi.lib to all configurations.
203 2007-11-29 Kevin McCullough <kmccullough@apple.com>
205 - Build fix. Added additional includes for VS Express to the Release
208 * Drosera/win/Drosera.vcproj/Drosera.vcproj:
210 2007-11-29 Anders Carlsson <andersca@apple.com>
214 <rdar://problem/5132005>
215 setUserStyleSheetEnabled is not fully implemented in Windows DRT.
217 * DumpRenderTree/win/DumpRenderTree.vcproj:
220 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
221 (LayoutTestController::setUserStyleSheetEnabled):
224 (appendComponentToPath):
225 New method which wraps the Win32 API PathAppend.
228 New method which checks if a file points to a shortcut and
229 follows the shortcut.
232 New method that takes a cygwin unix-style path and returns the Win32 path.
234 (cfStringRefToWString):
236 (LayoutTestController::setUserStyleSheetLocation):
239 2007-11-29 Alice Liu <alice.liu@apple.com>
243 Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
245 * DumpRenderTree/win/EventSender.cpp:
247 uppercase letters were being sent as lowercase letters without the shift key down.
249 2007-11-29 Kevin McCullough <kmccullough@apple.com>
251 - Windows build fix. VS express needs some love.
253 * Drosera/win/Drosera.vcproj/Drosera.vcproj:
255 2007-11-28 Darin Adler <darin@apple.com>
257 Reviewed by Adam Roben.
259 * DumpRenderTree/mac/EventSendingController.mm:
260 (-[EventSendingController keyDown:withModifiers:]):
261 Send capital letters through as lowercase letters with the shift key down
262 rather than sending them as if they were highly unusual "capital letter keys".
264 * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
265 where you need to update results and more tests are failing than before.
267 2007-11-28 Anders Carlsson <andersca@apple.com>
271 <rdar://problem/5132001>
272 contextClick is not implemented in DRT on Windows.
274 * DumpRenderTree/win/EventSender.cpp:
275 (contextClickCallback):
276 Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
277 by a WM_RBUTTONUP message.
279 * DumpRenderTree/win/UIDelegate.cpp:
280 (UIDelegate::hasCustomMenuImplementation):
281 (UIDelegate::trackCustomPopupMenu):
282 * DumpRenderTree/win/UIDelegate.h:
283 Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
284 menu from being shown (and causing the DRT to hang).
286 2007-11-27 Maciej Stachowiak <mjs@apple.com>
290 Fix DumpRenderTree ObjC bug comparing strings.
292 * DumpRenderTree/mac/ObjCController.m:
293 (-[ObjCController identityIsEqual::]): Compare strings with string
294 equality instead of identiy equality.
296 2007-11-27 Timothy Hatcher <timothy@apple.com>
300 Reset the authorAndUserStylesEnabled preference
301 back to YES for each test. Fixes the broken tests.
303 * DumpRenderTree/mac/DumpRenderTree.mm:
304 (resetWebViewToConsistentStateBeforeTesting):
306 2007-11-27 Kevin McCullough <kmccullough@apple.com>
310 - Drosera now displays the console window, although it cannot currently
313 * Drosera/win/DebuggerClient.cpp: Shows the console window.
314 (registerConsoleClass): Implemented.
315 (consoleWndProc): Implemented.
316 (DebuggerClient::onSize): Implemented.
317 (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
319 * Drosera/win/DebuggerClient.h: Added needed method and members for
320 creating and maintaining a new window.
321 * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
322 lines of code to more appropriate places.
323 (Drosera::handleCommand):
328 2007-11-27 Timothy Hatcher <timothy@apple.com>
330 Reviewed by Dave Hyatt.
332 <rdar://problem/5569233> Add the ability to disable author and user CSS styles
334 Add support for disabling author and user styles for testing.
336 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
337 * DumpRenderTree/LayoutTestController.cpp:
338 (setAuthorAndUserStylesEnabledCallback):
339 (LayoutTestController::staticFunctions):
340 * DumpRenderTree/LayoutTestController.h:
341 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
342 (LayoutTestController::setAuthorAndUserStylesEnabled):
343 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
344 (LayoutTestController::setAuthorAndUserStylesEnabled):
346 2007-11-26 Dan Bernstein <mitz@apple.com>
350 * DumpRenderTree/mac/Configurations/Base.xcconfig:
352 2007-11-26 Kevin McCullough <kmccullough@apple.com>
356 - Implemented displaying variables for Drosera on Win.
358 * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
359 that retrieve variables to not hold onto the return value since it's
360 not returned. Also changed to use the new signatures of the retrieval
362 (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
363 (DebuggerDocument::platformValueForScopeVariableNamed):
364 * Drosera/win/Drosera.cpp: Removed a needless TODO.
367 2007-11-26 Sam Weinig <sam@webkit.org>
369 Cleanup names of painting and repainting functions.
371 Reviewed by Adam Roben.
373 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
374 (drawSelectionRect): was drawSelectionRectIntoContext.
375 (dumpWebViewAsPixelsAndCompareWithExpected):
376 * DumpRenderTree/cg/PixelDumpSupportCG.h:
377 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
378 (paintWebView): was drawWebViewIntoContext.
379 (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
381 2007-11-26 Sam Weinig <sam@webkit.org>
383 Reviewed by Dan Bernstein.
387 * DumpRenderTree/mac/Configurations/Base.xcconfig:
389 2007-11-26 Sam Weinig <sam@webkit.org>
391 Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
392 Use shared PixelDumpSupport for Mac DRT
394 Reviewed by Adam Roben.
396 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
397 * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
398 * DumpRenderTree/cg/ImageDiffCG.cpp:
399 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
400 (drawSelectionRectIntoContext):
401 (dumpWebViewAsPixelsAndCompareWithExpected):
402 * DumpRenderTree/cg/PixelDumpSupportCG.h:
403 * DumpRenderTree/mac/Configurations/Base.xcconfig:
404 * DumpRenderTree/mac/DumpRenderTree.mm:
406 * DumpRenderTree/mac/ImageDiff.m: Removed.
407 * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
408 * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
409 * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
410 (setDefaultColorProfileToRGB):
411 (getBitmapContextFromWebView):
412 (drawWebViewIntoContext):
413 (repaintWithVerticalSweep):
414 (repaintWithHorizontalSweep):
416 * DumpRenderTree/win/PixelDumpSupport.h: Removed.
418 2007-11-25 David D. Kilzer <ddkilzer@webkit.org>
420 Bug 16052: prepare-ChangeLog doesn't report deleted files
421 <http://bugs.webkit.org/show_bug.cgi?id=16052>
425 * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
427 2007-11-25 David Kilzer <ddkilzer@webkit.org>
429 Bug 15864: Replace merge-changelog with resolve-ChangeLogs
430 <http://bugs.webkit.org/show_bug.cgi?id=15864>
434 Roll functionality of merge-changelog into resolve-ChangeLogs
435 script. The script now checks for ChangeLog.rej and
436 ChangeLog.orig files first. If it finds them, it uses the
437 ChangeLog.rej file as a patch (in old contextual diff format) to
440 * Scripts/merge-changelog: Removed.
441 * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
443 2007-11-25 Sam Weinig <sam@webkit.org>
445 Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
447 Reviewed by Mark Rowe.
449 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
450 * DumpRenderTree/mac/Configurations/Base.xcconfig:
451 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
452 * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
453 * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
455 2007-11-25 Sam Weinig <sam@webkit.org>
457 Convert DumpRenderTree to ues .xcconfig files.
459 Reviewed by Mark Rowe.
461 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
462 * DumpRenderTree/mac/Configurations: Added.
463 * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
464 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
465 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
467 2007-11-25 Sam Weinig <sam@webkit.org>
469 Add ForwardingHeaders to wtf for DumpRenderTree.
471 Reviewed by Mark Rowe.
473 * DumpRenderTree/DumpRenderTree.h:
474 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
475 * DumpRenderTree/ForwardingHeaders: Added.
476 * DumpRenderTree/ForwardingHeaders/wtf: Added.
477 * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
478 * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
479 * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
480 * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
481 * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
482 * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
483 * DumpRenderTree/LayoutTestController.cpp:
484 * DumpRenderTree/WorkQueue.cpp:
485 * DumpRenderTree/mac/DumpRenderTree.mm:
486 * DumpRenderTree/mac/FrameLoadDelegate.mm:
487 * DumpRenderTree/mac/JavaScriptThreading.cpp:
488 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
489 * DumpRenderTree/mac/ObjCController.m:
490 * DumpRenderTree/mac/UIDelegate.mm:
491 * DumpRenderTree/mac/WorkQueueItemMac.mm:
493 2007-11-25 Adam Roben <aroben@apple.com>
495 Fix some test failures caused by r28019
497 Now that stdout is in binary mode, we need to always use printf
498 instead of wprintf. Otherwise we'll end up with UTF-16 characters in
503 * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
505 (UIDelegate::runJavaScriptAlertPanelWithMessage):
506 (UIDelegate::runJavaScriptConfirmPanelWithMessage):
507 (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
508 (UIDelegate::webViewAddMessageToConsole):
510 2007-11-25 Adam Roben <aroben@apple.com>
512 Set the font smoothing preference in DRT
514 This makes the pixel results on Windows closer to the Mac results.
518 * DumpRenderTree/win/DumpRenderTree.cpp:
519 (initializePreferences):
521 2007-11-25 Adam Roben <aroben@apple.com>
523 Port ImageDiff to CG and C++
525 Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
530 * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
531 * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
533 (createImageFromStdin):
535 (getDifferenceBitmap):
536 (computePercentageDifferent):
537 * DumpRenderTree/win/ImageDiff.vcproj: Added.
539 2007-11-25 Adam Roben <aroben@apple.com>
541 Fix image diff link generation on Windows
545 * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
548 2007-11-25 Adam Roben <aroben@apple.com>
550 Implement pixel dumping in Windows DRT
552 Part of http://bugs.webkit.org/show_bug.cgi?id=16133
557 * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
558 (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
559 Content-Length header.
560 (getMD5HashStringForBitmap):
561 (dumpWebViewAsPixelsAndCompareWithExpected):
562 * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
563 * DumpRenderTree/win/DumpRenderTree.cpp:
564 (dump): Do a pixel dump if requested.
565 (main): Parse pixel test options.
566 * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
567 the cg/ subdirectory to the include path.
568 * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
569 available in a header or import library, so we have to go through this
570 LoadLibrary/GetProcAddress dance to use them.
578 * DumpRenderTree/win/MD5.h: Added.
579 * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
580 moved up to the top level to share it with Mac eventually.
581 * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
582 (getBitmapContextFromWebView): Forces the WebView to paint using a
583 WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
585 2007-11-25 Adam Roben <aroben@apple.com>
587 Clean up Windows DRT's option parsing a little bit
591 * DumpRenderTree/win/DumpRenderTree.cpp:
592 (main): Put non-option arguments into a Vector.
594 2007-11-25 Adam Roben <aroben@apple.com>
596 Make Windows DRT stop changing LF into CRLF
600 * DumpRenderTree/win/DumpRenderTree.cpp:
601 (main): Put stdout in binary mode.
602 * Scripts/run-webkit-tests: Remove the CRLF hack.
604 2007-11-24 David Kilzer <ddkilzer@webkit.org>
606 Removed empty directory.
608 * Scripts/resources: Removed.
610 2007-11-23 David D. Kilzer <ddkilzer@webkit.org>
612 Fix bisect-builds to work with recent WebKit nightly builds.
616 * Scripts/bisect-builds: Check for the
617 WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
618 it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
619 to WebKit.app/Contents/Resources.
621 2007-11-23 Alexey Proskuryakov <ap@webkit.org>
625 <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
626 not closed (affects digg.com)
628 * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
629 one after finishing with a test to avoid having its delayed onload handler firing when
630 replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
631 but it helps somewhat.
633 2007-11-22 Mark Rowe <mrowe@apple.com>
635 Reviewed by Alp Toker.
637 Fix build-webkit to propagate make's exit status if it fails.
639 * Scripts/webkitdirs.pm:
641 2007-11-22 Dan Bernstein <mitz@apple.com>
643 Reviewed by Mark Rowe.
645 - fix crash when running pixel tests
647 * DumpRenderTree/mac/DumpRenderTree.mm:
648 (dumpRenderTree): Parse the command line options before setting up the
649 environment so that we know if we need to set up the pixel dump
652 2007-11-21 Eric Seidel <eric@webkit.org>
654 Speculative build fix for Tiger.
656 * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
658 2007-11-21 Eric Seidel <eric@webkit.org>
660 Reviewed by Tim Hatcher.
662 Break out more of DumpRenderTree.mm into individual files
664 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
665 * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
668 (makeLargeMallocFailSilently):
669 * DumpRenderTree/mac/CheckedMalloc.h: Added.
670 * DumpRenderTree/mac/DumpRenderTree.mm:
673 * DumpRenderTree/mac/DumpRenderTreeMac.h:
674 * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
675 * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
676 * DumpRenderTree/mac/DumpRenderTreeWindow.h:
677 * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
678 * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
680 (runJavaScriptThread):
681 (startJavaScriptThreads):
682 (stopJavaScriptThreads):
683 * DumpRenderTree/mac/JavaScriptThreading.h: Added.
684 * DumpRenderTree/mac/PixelDumpSupport.h: Added.
685 * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
687 (setDefaultColorProfileToRGB):
688 (initializeColorSpaceAndScreeBufferForPixelTests):
689 (md5HashStringForBitmap):
690 (dumpWebViewAsPixelsAndCompareWithExpected):
692 2007-11-21 Kevin Ollivier <kevino@theolliviers.com>
694 Move install-unix-extras to wx directory as it seems only to be used by that
695 port now. It now supports universal binaries on Mac and adds libpng and libjpeg.
696 Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
697 have install-unix-extras install into WebKitLibraries as per
700 Reviewed by Mark Rowe.
702 * Scripts/install-unix-extras: Removed.
704 * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
706 2007-11-21 Eric Seidel <eric@webkit.org>
710 More refactoring for greater code readability
712 * DumpRenderTree/mac/DumpRenderTree.mm:
713 (initializeGlobalsFromCommandLineOptions):
714 (initializeColorSpaceAndScreeBufferForPixelTests):
715 (addTestPluginsToPluginSearchPath):
716 (useLongRunningServerMode):
717 (runTestingServerLoop):
718 (prepareConsistentTestingEnvironment):
722 (dumpBackForwardListForWebView):
723 (sizeWebViewForCurrentTest):
724 (methodNameStringForFailedTest):
725 (dumpBackForwardListForAllWindows):
726 (dumpWebViewAsPixelsAndCompareWithExpected):
727 (invalidateAnyPreviousWaitToDumpWatchdog):
729 * DumpRenderTree/mac/DumpRenderTreeMac.h:
730 * DumpRenderTree/mac/UIDelegate.mm:
731 (-[UIDelegate webView:createWebViewWithRequest:]):
733 2007-11-21 Eric Seidel <eric@webkit.org>
735 Reviewed by Tim Hatcher.
737 Abstract more of DRT into static methods
739 * DumpRenderTree/mac/DumpRenderTree.mm:
740 (setDefaultsToConsistentValuesForTesting):
741 (setupSignalHandlers):
742 (allocateGlobalControllers):
744 (releaseGlobalControllers):
746 (shouldLogFrameLoadDelegates):
747 (createCFURLFromPathOrURL):
748 (resetWebViewToConsistentStateBeforeTesting):
751 2007-11-21 Eric Seidel <eric@webkit.org>
753 Reviewed by Tim Hatcher.
755 Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
757 * DumpRenderTree/DumpRenderTree.h:
758 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
759 * DumpRenderTree/mac/DumpRenderTree.mm:
763 * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
764 * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
765 (+[DumpRenderTreePasteboard _pasteboardWithName:]):
766 (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
767 (-[DumpRenderTreePasteboard declareType:owner:]):
768 (+[LocalPasteboard alloc]):
769 (-[LocalPasteboard init]):
770 (-[LocalPasteboard dealloc]):
771 (-[LocalPasteboard name]):
772 (-[LocalPasteboard releaseGlobally]):
773 (-[LocalPasteboard declareTypes:owner:]):
774 (-[LocalPasteboard addTypes:owner:]):
775 (-[LocalPasteboard changeCount]):
776 (-[LocalPasteboard types]):
777 (-[LocalPasteboard availableTypeFromArray:]):
778 (-[LocalPasteboard setData:forType:]):
779 (-[LocalPasteboard dataForType:]):
780 (-[LocalPasteboard setPropertyList:forType:]):
781 (-[LocalPasteboard setString:forType:]):
782 * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
783 * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
784 (+[DumpRenderTreeWindow allWindows]):
785 (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
786 (-[DumpRenderTreeWindow dealloc]):
787 (-[DumpRenderTreeWindow isKeyWindow]):
788 (-[DumpRenderTreeWindow keyDown:]):
790 2007-11-20 Kevin Ollivier <kevino@theolliviers.com>
792 wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
793 it indiscriminately copies any headers inside JavaScriptCore,
794 which includes Tiger ICU headers.
797 Don't run WebCore/move-js-headers.sh any longer.
799 2007-11-20 Adam Treat <treat@kde.org>
801 Reviewed by David Kilzer.
803 * Prepend git branch name to $baseProductDir
805 * Scripts/VCSUtils.pm:
806 * Scripts/webkitdirs.pm:
808 2007-11-20 Mark Rowe <mrowe@apple.com>
810 Reviewed by Simon Hausmann.
812 * Scripts/build-webkit: Pass "clean" flag down into buildQMakeProject.
813 * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
814 Have it trigger a "make distclean" rather than "make clean" to ensure that the
815 built product and generated Makefile's are removed.
817 2007-11-19 Alp Toker <alp@atoker.com>
819 Reviewed by Mark Rowe.
821 http://bugs.webkit.org/show_bug.cgi?id=16040
822 [GTK] GtkLauncher should be written in C
824 Port GtkLauncher to plain C.
826 Use a more conventional GTK+ coding style.
828 Use a toolbar instead of menus.
830 Various signature fixes and cleanups.
832 Add a license header. Assume all previous modifications were copyright
833 assigned to Apple Inc. by default.
835 * GtkLauncher/GtkLauncher.pro:
836 * GtkLauncher/main.c: Added.
837 (activate_url_entry_cb):
841 (progress_change_cb):
850 * GtkLauncher/main.cpp: Removed.
852 2007-11-19 Kevin Ollivier <kevino@theolliviers.com>
854 Build script fixes to ensure they do the right thing for the
855 wx port, and update build-wxwebkit to reflect the way the
856 build scripts now work.
860 * Scripts/build-testkjs:
861 * Scripts/build-webkit:
862 * Scripts/run-javascriptcore-tests:
863 * Scripts/webkitdirs.pm:
866 2007-11-18 Eric Seidel <eric@webkit.org>
870 Make run-javascriptcore-tests report failures on exit (to support git bisect)
872 * Scripts/run-javascriptcore-tests:
874 2007-11-18 Alexey Proskuryakov <ap@webkit.org>
876 Reviewed by Adam Roben.
878 Make run-webkit-tests work with Windows debug build.
880 * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
881 * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
882 as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
883 symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
884 and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
886 2007-11-18 Kevin Ollivier <kevino@theolliviers.com>
888 Add wxWebKit sample and build script, and integrate it with
889 build-webkit. Also make build-webkit --clean work for all
892 Reviewed by Darin Adler.
894 * Scripts/build-webkit:
895 * Scripts/webkitdirs.pm:
898 * wx/browser/browser.bkl: Added.
899 * wx/browser/browser.cpp: Added.
900 * wx/build-wxwebkit: Added.
902 2007-11-17 Adam Roben <aroben@apple.com>
904 Make it easy to run Safari in the debugger on Windows
906 I've added a new script, debug-safari, which launches Safari in the
907 debugger. On OS X it just calls gdb-safari.
909 Reviewed by Mark Rowe.
911 * FindSafari/FindSafari.cpp:
912 (_tmain): Added a /debugger flag, which in combination with
913 /printSafariLauncher will print a script that launches Safari in the
915 * Scripts/debug-safari: Added.
916 * Scripts/run-safari: Changed to call runSafari().
917 * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
918 vsvars32.bat, which will let us find VS/VC++ Express, and passes the
919 first argument along to FindSafari.
920 * Scripts/webkitdirs.pm:
921 (sub runSafari): Added.
923 2007-11-16 Alexey Proskuryakov <ap@webkit.org>
925 Reviewed by Adam Roben.
927 * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.
929 2007-11-16 Ryan Leavengood <leavengood@gmail.com>
931 Reviewed by David Kilzer.
933 The git config command was renamed to repo-config at some point. This
934 change tries git config and then git repo-config if the first fails.
936 * Scripts/prepare-ChangeLog:
939 2007-11-16 Dan Bernstein <mitz@apple.com>
941 Reviewed by Darin Adler and Sam Weinig.
943 - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
945 * DumpRenderTree/win/EventSender.cpp:
946 (keyDownCallback): For characters that cannot be entered on the active
947 keyboard layout, send a WM_CHAR message with the character along with
948 a WM_KEYDOWN message with a virtual key code of 255.
950 2007-11-16 Mark Rowe <mrowe@apple.com>
952 Reviewed by Tim Hatcher.
954 Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
956 * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
957 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
959 2007-11-15 Adam Roben <aroben@apple.com>
961 Make run-safari actually work on Windows
963 * Scripts/run-safari: Fixed the order of arguments to cp, and added a
966 2007-11-14 Adam Roben <aroben@apple.com>
968 Updates to Safari launching now that 3.0.4 is released
972 * FindSafari/FindSafari.cpp:
973 (getWebViewCLSID): Use version-independent ProgID.
974 * Scripts/run-safari: Use run-webkit-nightly.cmd.
976 2007-11-14 Anders Carlsson <andersca@apple.com>
980 <rdar://problem/5309081>
981 In DRT, "plugin.logDestroy = true" not working on Windows.
983 * DumpRenderTree/win/TestNetscapePlugin/main.c:
986 2007-11-14 Eric Seidel <eric@webkit.org>
990 * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
992 2007-11-14 Anders Carlsson <andersca@apple.com>
996 <rdar://problem/5141186>
997 window.layoutTestController.setWindowIsKey is not implemented in DRT.
999 Implement setWindowIsKey.
1001 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1002 (LayoutTestController::setWindowIsKey):
1004 2007-11-13 Sam Weinig <sam@webkit.org>
1006 Reviewed by Adam Roben.
1008 Fix for <rdar://problem/5382579>
1009 http/tests/security/cross-frame-access-put.html reports large
1010 negative numbers for screenLeft and screenTop (Mac reports "0")
1012 * DumpRenderTree/win/UIDelegate.cpp:
1013 (UIDelegate::UIDelegate): Initialize the RECT.
1014 (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1015 (UIDelegate::webViewFrame): ditto.
1016 * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1018 2007-11-13 Kevin McCullough <kmccullough@apple.com>
1022 - Make Drosera show source, source URLs, and function stack on Windows,
1023 and some minor fixes.
1025 * Drosera/DebuggerDocument.cpp: Force source to always update display.
1026 (DebuggerDocument::updateFileSource):
1027 * Drosera/debugger.js: Force source to always update display.
1028 * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1030 (DebuggerClient::resume):
1031 (DebuggerClient::pause):
1032 (DebuggerClient::stepInto):
1033 (DebuggerClient::stepOver):
1034 (DebuggerClient::stepOut):
1035 (DebuggerClient::showConsole):
1036 (DebuggerClient::closeCurrentFile):
1037 * Drosera/win/DebuggerClient.h: Ditto.
1038 * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1039 getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1040 removed two bugs. 1) caller could be in a bad state when asked to
1041 assign into it. 2) BSTRs were not created correctly.
1042 (DebuggerDocument::getPlatformCurrentFunctionStack):
1043 * Drosera/win/Drosera.cpp: Hook up the menu controls.
1048 (Drosera::stepInto):
1049 (Drosera::stepOver):
1051 (Drosera::showConsole):
1052 (Drosera::closeCurrentFile):
1053 * Drosera/win/Drosera.h: Hook up the menu controls.
1054 * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1055 functions, added a null check, and fixed another bug where caller could
1056 be in a bad state when asked to assign into it.
1057 (ServerConnection::didLoadMainResourceForDataSource):
1058 (ServerConnection::getCallerFrame):
1059 * Drosera/win/ServerConnection.h: Safety first.
1061 2007-11-13 Dan Bernstein <mitz@apple.com>
1063 Reviewed by Darin Adler.
1065 - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1066 DumpRenderTree --pixel-tests renders each test twice
1068 * DumpRenderTree/mac/DumpRenderTree.mm:
1069 (dumpRenderTree): Removed the --paint option because the painting code
1070 is always exercised as a result of
1071 -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1072 calling -displayIfNeeded.
1073 (dump): Changed to always grab the image from the window since the view
1074 is always displayed.
1077 * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1078 because it always paints.
1080 2007-11-12 Antti Koivisto <antti@apple.com>
1084 Add support for http media tests
1086 * Scripts/run-webkit-tests:
1088 2007-11-12 Sam Weinig <sam@webkit.org>
1090 Reviewed by Adam Roben.
1092 Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1094 * DumpRenderTree/win/DumpRenderTree.cpp:
1096 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1097 (LayoutTestController::setPrivateBrowsingEnabled):
1099 2007-11-12 Adam Roben <aroben@apple.com>
1101 * Scripts/update-webkit-localizable-strings: Changed to only scan the
1102 mac and win subdirectories.
1104 2007-11-11 Adam Roben <aroben@apple.com>
1106 Fix <rdar://5133816> keepWebHistory is not implemented
1108 Fixes fast/history/clicked-link-is-visited.html.
1112 * DumpRenderTree/win/DumpRenderTree.cpp:
1113 (runTest): Clear the optionalSharedHistory.
1114 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1115 (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1117 2007-11-10 Sam Weinig <sam@webkit.org>
1119 Reviewed by Tim Hatcher.
1121 Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
1122 attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
1125 - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1127 Added test: http/tests/security/cross-frame-access-private-browsing.html
1129 * DumpRenderTree/LayoutTestController.cpp:
1130 (setPrivateBrowsingEnabledCallback):
1131 (LayoutTestController::staticFunctions):
1132 * DumpRenderTree/LayoutTestController.h:
1133 * DumpRenderTree/mac/DumpRenderTree.mm:
1134 (runTest): Default to private browsing disabled.
1135 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1136 (LayoutTestController::setPrivateBrowsingEnabled):
1137 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1138 (LayoutTestController::setPrivateBrowsingEnabled):
1140 2007-11-08 Kevin McCullough <kmccullough@apple.com>
1144 - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1147 * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1148 * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1149 * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1150 * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1151 * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1152 * Drosera/win/Drosera.cpp:
1153 * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1155 2007-11-08 Kevin McCullough <kmccullough@apple.com>
1159 - Use the new IWebFrame [local] function signature and get the shared
1162 * Drosera/win/DebuggerClient.cpp:
1163 (DebuggerClient::didFinishLoadForFrame):
1164 * Drosera/win/ServerConnection.cpp:
1165 (ServerConnection::attemptToCreateServerConnection):
1167 2007-11-07 Dan Bernstein <mitz@apple.com>
1169 Reviewed by Darin Adler.
1171 - add an option to run-webkit-tests to ignore pixel test failures where
1172 all pixels differ by no more than a specified threshold
1174 * DumpRenderTree/mac/ImageDiff.m:
1177 (computePercentageDifferent):
1178 * Scripts/run-webkit-tests:
1180 2007-11-07 Simon Hausmann <hausmann@kde.org>
1184 Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1186 * DumpRenderTree/qt/DumpRenderTree.cpp:
1188 2007-11-07 Simon Hausmann <hausmann@kde.org>
1192 Reworked the QWebSettings API.
1193 QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1195 * DumpRenderTree/qt/DumpRenderTree.cpp:
1197 2007-11-07 Simon Hausmann <hausmann@kde.org>
1201 Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1203 * DumpRenderTree/qt/jsobjects.cpp:
1205 2007-11-07 Simon Hausmann <hausmann@kde.org>
1207 Reviewed by Lars Knoll <lars@trolltech.com>.
1209 Add a QWebPage::frameCreated() signal and fix DRT
1211 The removal of createFrame in QWebPage broke the re-implementation
1212 in DumpRenderTree. Instead emit a frameCreated() signal and
1213 connect to it in DumpRenderTree.
1216 * DumpRenderTree/qt/DumpRenderTree.cpp:
1217 (WebCore::WebPage::WebPage):
1218 (WebCore::DumpRenderTree::dump):
1219 (WebCore::DumpRenderTree::connectFrame):
1220 * DumpRenderTree/qt/DumpRenderTree.h:
1222 2007-11-07 Simon Hausmann <hausmann@kde.org>
1224 Reviewed by Lars Knoll <lars@trolltech.com>.
1226 Moved all the event handlers from QWebFrame into QWebPage.
1228 This cleans up the public API and allows us to remove the
1229 HackWebFrame hack in DumpRenderTree.
1232 * DumpRenderTree/qt/jsobjects.cpp:
1233 (EventSender::mouseDown):
1234 (EventSender::mouseUp):
1235 (EventSender::mouseMoveTo):
1237 2007-11-07 Simon Hausmann <hausmann@kde.org>
1241 Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1242 to prevent the default implementation from popping up messageboxes.
1244 * DumpRenderTree/qt/DumpRenderTree.cpp:
1245 (WebCore::WebPage::javaScriptConfirm):
1246 (WebCore::WebPage::javaScriptPrompt):
1248 2007-11-06 Eric Seidel <eric@webkit.org>
1250 * Scripts/build-testkjs: build fix... too many $$
1252 2007-11-06 Eric Seidel <eric@webkit.org>
1254 Reviewed by Mark Rowe.
1256 * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1258 2007-11-05 Adam Roben <aroben@apple.com>
1260 Add support on Windows for WEBKIT_TESTFONTS
1262 This environment variable lets you specify where the fonts to be used
1263 by DumpRenderTree reside. The Qt port is already using this, so I'm
1264 just following their lead.
1268 * DumpRenderTree/win/DumpRenderTree.cpp:
1269 (exePath): Refactored code out of initialize().
1270 (fontsPath): Returns either $WEBKIT_TESTFONTS or
1271 DumpRenderTree.resources.
1272 (initialize): Use the new fontsPath function.
1273 (main): Use the new exePath function.
1274 * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1275 variable to DRT, like Qt does.
1277 2007-11-05 Mark Rowe <mrowe@apple.com>
1279 Rubber-stamped by Alp Toker.
1281 Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1283 * GtkLauncher/main.cpp:
1287 2007-11-04 David D. Kilzer <ddkilzer@webkit.org>
1289 bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1290 <http://bugs.webkit.org/show_bug.cgi?id=15830>
1292 Reviewed by Timothy.
1294 Restrict the range of nightly builds used by the bisect-builds script
1295 based on the version of Safari and the version of Mac OS X being used.
1297 Mac OS X 10.4: Safari 2.0: r11976 or newer
1298 Mac OS X 10.4: Safari 3.0: r19992 or newer
1300 Mac OS X 10.5: Safari 2.0: r19594 or newer
1301 Mac OS X 10.5: Safari 3.0: r25124 or newer
1303 * Scripts/bisect-builds:
1304 (findMacOSXVersion): Added.
1305 (makeNightlyList): Added argument to provide version of Mac OS X.
1306 Restrict range of nightly builds based on Safari and Mac OS X versions.
1308 2007-11-04 Kevin McCullough <kmccullough@apple.com>
1312 - This patch involves several changes, all of them were noticed that
1313 they were needed by the work being done in WebKit to get Drosera and
1314 WebKit working together on Windows.
1316 1) Added a debugger console for output messages.
1317 2) Drosera now listens for the WebKit server (before, the server would
1318 have to be running before Drosera was started.)
1319 3) Fixed a bug where the WebView started out as 0x0 pixels.
1320 4) Fixed a bug when there is no scope.
1321 5) Added the HTML, JS, and CSS to the project file to make them easy to
1323 6) Made the ServerConnection functions virtual.
1325 * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1326 for the WebKit server.
1327 (DebuggerClient::DebuggerClient):
1328 (DebuggerClient::~DebuggerClient):
1329 (DebuggerClient::didFinishLoadForFrame):
1330 (DebuggerClient::serverConnected):
1331 (DebuggerClient::attemptToCreateServerConnection):
1332 * Drosera/win/DebuggerClient.h: Ditto.
1333 * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1335 (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1336 (DebuggerDocument::platformValueForScopeVariableNamed):
1337 * Drosera/win/Drosera.cpp:
1338 (_tWinMain): Added a console in debug for output messages.
1339 (Drosera::Drosera): Listen for server.
1340 (Drosera::initUI): The server now Initializes COM.
1341 (Drosera::serverConnected): Part of the listening for the server.
1342 (Drosera::attemptToCreateServerConnection): Ditto.
1343 * Drosera/win/Drosera.h: New interface for listening for the server.
1344 * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1345 files to the VS project.
1346 * Drosera/win/ServerConnection.cpp: Part of listening for the server
1348 (ServerConnection::ServerConnection):
1349 (ServerConnection::attemptToCreateServerConnection):
1350 * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1352 (ServerConnection::serverConnected):
1354 2007-11-04 Alexey Proskuryakov <ap@webkit.org>
1358 http://bugs.webkit.org/show_bug.cgi?id=15832
1359 fast/dom/gc-10.html crashes when run alone
1361 Check for !done before using objects that can be already deallocated.
1363 * DumpRenderTree/mac/EditingDelegate.mm:
1364 (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1365 (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1366 (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1367 (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1368 (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1369 (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1370 (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1371 (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1372 (-[EditingDelegate webViewDidBeginEditing:]):
1373 (-[EditingDelegate webViewDidChange:]):
1374 (-[EditingDelegate webViewDidEndEditing:]):
1375 (-[EditingDelegate webViewDidChangeTypingStyle:]):
1376 (-[EditingDelegate webViewDidChangeSelection:]):
1377 * DumpRenderTree/mac/FrameLoadDelegate.mm:
1378 (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1379 (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1380 (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1381 (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1382 (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1383 (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1384 (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1385 (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1386 (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1387 (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1388 (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1389 (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1390 (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1391 (-[FrameLoadDelegate webView:willCloseFrame:]):
1392 (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1393 (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1394 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1395 (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1396 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1397 (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1398 (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1399 (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1400 (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1402 2007-11-04 Mark Rowe <mrowe@apple.com>
1404 Build fix. Don't use Carbon.h as the prefix header as it triggers
1405 warnings that would otherwise be suppressed due to it being a system header.
1407 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1409 2007-11-03 Maciej Stachowiak <mjs@apple.com>
1411 Rubber stamped by Adam.
1413 - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1415 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1417 2007-11-03 David D. Kilzer <ddkilzer@webkit.org>
1419 Sort files(...); sections of Xcode project files.
1421 Rubber-stamped by Darin.
1423 * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1424 * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1425 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1426 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1428 2007-11-03 David D. Kilzer <ddkilzer@webkit.org>
1430 Script to sort "files(...);" sections in Xcode project.pbxproj files.
1434 * Scripts/sort-Xcode-project-file: Added.
1436 2007-11-02 Darin Adler <darin@apple.com>
1438 * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1440 2007-11-02 Darin Adler <darin@apple.com>
1444 * Scripts/run-sunspider: Pass the "--base" option through.
1446 * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1447 the real script do that. Default configuration to Release to match run-sunspider
1448 so we don't end up building Debug just to compare results.
1450 2007-11-01 Adam Roben <aroben@apple.com>
1452 Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1456 * Scripts/commit-log-editor: Show all the directories beneath the
1457 source root, instead of just the last one.
1459 2007-11-01 Kevin Ollivier <kevino@theolliviers.com>
1461 Reviewed by Adam Roben.
1463 Print out an error message when the Windows build fails
1464 and provide guidance on how to find out what went wrong.
1466 * Scripts/build-webkit:
1467 * Scripts/webkitdirs.pm:
1469 2007-11-01 Alexey Proskuryakov <ap@webkit.org>
1471 Rubber-stamped by Adam Roben.
1473 Rolled out r27326 - debug CRT seems to cause no problems after all.
1475 * DumpRenderTree/win/DumpRenderTree.vcproj:
1477 2007-10-31 Adam Roben <aroben@apple.com>
1479 Switch the Debug configuration to using the non-debug CRT
1481 This matches WebKit.
1485 * DumpRenderTree/win/DumpRenderTree.vcproj:
1487 2007-10-31 Antti Koivisto <antti@apple.com>
1491 Disable media tests when doing leak checking on Tiger.
1492 They crash in QuickTime (rdar://problem/5537157).
1494 * Scripts/run-webkit-tests:
1496 2007-10-29 Antti Koivisto <antti@apple.com>
1500 Build media support by default on OSX only.
1502 * Scripts/build-webkit:
1504 2007-10-30 Kevin McCullough <kmccullough@apple.com>
1506 - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1507 get caught by the pre-commit hooks.
1509 2007-10-30 Kevin McCullough <kmccullough@apple.com>
1513 - This is a collection of relatively unrelated changes and cleanups
1514 to Drosera to prepare it for interacting with WebKit. A lot of these
1515 changes are just correcting mistakes, for example removing included
1516 headers that are no longer needed.
1518 * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1519 this will be needed by the DebuggerClient.
1520 (DebuggerDocument::server):
1521 * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1522 * Drosera/win/DebuggerClient.cpp:
1523 (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1524 (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1525 (DebuggerClient::createWebViewWithRequest): Added comment about its
1527 * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1529 (DebuggerClient::webViewLoaded): Moved.
1530 * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1531 file, since this was the only place it was used.
1533 * Drosera/win/Drosera.h: Cleaned up the includes.
1534 * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1535 * Drosera/win/HelperFunctions.h: Removed.
1537 2007-10-30 Kevin McCullough <kmccullough@apple.com>
1541 - Small cleanup in the ServerConnection class.
1543 * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1544 and added an include.
1545 (ServerConnection::currentFrame):
1546 (ServerConnection::getCallerFrame):
1547 * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1548 made a pointer into a COMPtr, and cleaned up the includes.
1550 2007-10-29 Timothy Hatcher <timothy@apple.com>
1552 Reviewed by John Sullivan.
1554 - Place the Localizable.strings file in mac or win directories
1555 if that location exists.
1556 - Also look for UI_STRING in .c files.
1558 * Scripts/extract-localizable-strings:
1560 2007-10-30 Kevin McCullough <kmccullough@apple.com>
1564 - Set the eol-style to native and made all the line endings the same
1565 so that I avoid messy diffs that show eol changes.
1567 * Drosera/win/ServerConnection.cpp:
1568 (ServerConnection::didParseSource):
1569 (ServerConnection::didEnterCallFrame):
1570 (ServerConnection::willExecuteStatement):
1571 (ServerConnection::willLeaveCallFrame):
1572 (ServerConnection::exceptionWasRaised):
1574 2007-10-30 Kevin McCullough <kmccullough@apple.com>
1578 * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1579 functionality that could not have existed previously without the new
1581 (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1582 from a BSTR to a JSValueRef.
1583 (DebuggerDocument::platformEvaluateScript): Implemented.
1584 (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1585 (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1587 (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1588 * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1589 * Drosera/win/ServerConnection.cpp: Added a helper function.
1590 (ServerConnection::getCallerFrame):
1591 * Drosera/win/ServerConnection.h: Added a helper function.
1593 2007-10-29 Kevin McCullough <kmccullough@apple.com>
1595 updated reviewers for my previous changelog.
1597 2007-10-29 Kevin McCullough <kmccullough@apple.com>
1598 Reviewed by Maciej and Adam and Geoff.
1600 - Minor mac-side improvements including moving a function to a more
1601 appropriate location, fixing a warning, and correctly checking
1604 * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1605 (DebuggerDocument::willExecuteStatement):
1606 (DebuggerDocument::didEnterCallFrame):
1607 (DebuggerDocument::willLeaveCallFrame):
1608 (DebuggerDocument::windowScriptObjectAvailable):
1609 (DebuggerDocument::callFunctionOnObject):
1610 * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1611 * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1612 webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1613 because it doesn't require the ServerConnection at all.
1614 (NSStringCreateWithJSStringRef): Made an argument const.
1615 (JSValueRefCreateWithNSString): Made an argument const.
1616 (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1617 (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1618 * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1619 * Drosera/mac/ServerConnection.mm: Ditto.
1620 (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1622 2007-10-29 Sam Weinig <sam@webkit.org>
1624 Reviewed by Adam Roben.
1626 Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1628 * DumpRenderTree/LayoutTestController.cpp:
1629 (LayoutTestController::LayoutTestController):
1630 (getGlobalFlagCallback):
1631 (setGlobalFlagCallback):
1632 (LayoutTestController::getJSClass):
1633 (LayoutTestController::staticValues):
1634 * DumpRenderTree/LayoutTestController.h:
1635 (LayoutTestController::globalFlag):
1636 (LayoutTestController::setGlobalFlag):
1638 2007-10-29 Darin Adler <darin@apple.com>
1642 * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1643 resolution instead of its default.
1645 2007-10-29 David Kilzer <ddkilzer@webkit.org>
1647 Fixed showStatus() to print status for successfully resolved conflicts when using git.
1649 Reviewed by Mark Rowe.
1651 Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1652 was successfully resolved, but this would not show any status because the change had
1653 already been cached in the index using "git add". The solution is to add an optional
1654 second argument to showStatus() which adds the "--cached" switch to the command.
1656 * Scripts/resolve-ChangeLogs:
1659 2007-10-28 Eric Seidel <eric@webkit.org>
1661 Reviewed by Maciej and Geoff, in unison.
1663 * Scripts/run-webkit-tests: remove broken --svg option
1665 2007-10-28 Darin Adler <darin@apple.com>
1669 * Scripts/run-sunspider: Default to "Release" configuration rather than
1670 defaulting to the last configuration used as other scripts do. This can
1671 still be overriden on the command line with "--debug" if there's some
1672 reason to do so. Also fix a typo.
1674 * Scripts/sunspider-compare-results: Fix a typo.
1676 2007-10-26 Kevin McCullough <kmccullough@apple.com>
1680 - Implemented the WebScriptDebugListener functions now that the
1681 WebScriptDebugServer exists
1683 * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1685 (ServerConnection::currentFrame):
1686 (ServerConnection::didLoadMainResourceForDataSource):
1687 (ServerConnection::didParseSource):
1688 (ServerConnection::failedToParseSource):
1689 (ServerConnection::didEnterCallFrame):
1690 (ServerConnection::willExecuteStatement):
1691 (ServerConnection::willLeaveCallFrame):
1692 (ServerConnection::exceptionWasRaised):
1693 * Drosera/win/ServerConnection.h: Removed unused arguments from the
1694 members arguments list.
1696 2007-10-26 David Kilzer <ddkilzer@webkit.org>
1698 prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1699 <http://bugs.webkit.org/show_bug.cgi?id=15600>
1703 The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1704 a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1705 If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1706 file. Note that it may also be used as a stand-alone script.
1708 * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1709 * Scripts/resolve-ChangeLogs: Added.
1710 * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1712 2007-10-26 Mark Rowe <mrowe@apple.com>
1714 Qt build fix. r27084 added a destructor implementation for LayoutTestController
1715 to the Qt port on the assumption that it was an implementation of the cross-platform
1716 LayoutTestController class. It is not, so it did not need to be changed.
1718 * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1720 2007-10-25 Mark Rowe <mrowe@apple.com>
1724 Fix builds with code coverage enabled.
1726 * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1728 2007-10-25 Darin Adler <darin@apple.com>
1730 Reviewed by Mark Rowe.
1732 * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1733 * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1735 2007-10-25 Stephanie <slewis@apple.com>
1739 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1741 2007-10-25 Stephanie <slewis@apple.com>
1743 Reviewed by Mark Rowe, Adam Roben.
1745 Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1747 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1749 2007-10-25 Alice Liu <alice.liu@apple.com>
1753 Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1755 Moving destructor into platform-specific files
1756 * DumpRenderTree/LayoutTestController.cpp:
1757 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1758 (LayoutTestController::~LayoutTestController):
1759 * DumpRenderTree/qt/jsobjects.cpp:
1760 (LayoutTestController::~LayoutTestController):
1762 LayoutTestController wasn't being destroyed
1763 * DumpRenderTree/win/DumpRenderTree.cpp:
1767 * DumpRenderTree/win/EditingDelegate.h:
1769 Reset certain values on the webview (or related delegate) that might
1770 have changed while running a test
1771 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1772 (LayoutTestController::~LayoutTestController):
1774 2007-10-25 Adam Roben <aroben@apple.com>
1776 Make sunspider-compare-results work with relative paths
1780 * Scripts/sunspider-compare-results: Convert arguments to absolute
1781 paths before we chdir.
1783 2007-10-25 Kevin McCullough <kmccullough@apple.com>
1787 - Implemented server calls now the WebScriptDebugServer exists.
1788 - Also removed no longer needed call to initialize CG.
1790 * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1793 * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1794 (ServerConnection::ServerConnection):
1795 (ServerConnection::~ServerConnection):
1796 (ServerConnection::pause):
1797 (ServerConnection::resume):
1798 (ServerConnection::stepInto):
1799 (ServerConnection::applicationTerminating):
1800 (ServerConnection::serverConnectionDidDie):
1801 * Drosera/win/ServerConnection.h: Now uses the COM class.
1803 2007-10-24 George Staikos <staikos@kde.org>
1807 * Scripts/build-webkit:
1809 2007-10-24 Adam Roben <aroben@apple.com>
1811 Remove now-unnecessary call to InitializeCoreGraphics
1813 WebKit takes care of this now.
1817 * DumpRenderTree/win/DumpRenderTree.cpp:
1820 2007-10-24 Adam Roben <aroben@apple.com>
1822 Use WebTextRenderer in DRT
1826 * DumpRenderTree/win/DumpRenderTree.cpp:
1827 (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1829 2007-10-24 Sven Herzberg <sven@imendio.com>
1831 Reviewed by Mark Rowe.
1833 Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1834 Bug 15614: [GTK] qmake based backends don't build on OS X
1836 * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1837 GTK backend on a Mac
1838 * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1839 isDarwin() to make it reusable in other places (like the workaround-
1840 for-prebuilt-qmake in build-webkit)
1842 2007-10-24 David Kilzer <ddkilzer@webkit.org>
1844 Refurbish update-webkit script.
1848 * Scripts/update-webkit: Add -h|--help switch and usage statement. Check result of
1849 GetOptions() call. Fix -q|--quiet switch to be passed to svn command properly. Use
1850 multi-argument version of system() for flexibility and security. Check for existence
1851 of Internal directory using -d test instead of -x.
1853 2007-10-24 David Kilzer <ddkilzer@webkit.org>
1855 Minor clean-up of prepare-ChangeLog script.
1859 * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1860 of a string. Use multi-argument versions of open() and system() for flexibility and
1863 2007-10-24 Alice Liu <alice.liu@apple.com>
1867 Fix <rdar://5410959> editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1869 Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
1870 replay the saved events when we're still processing the mousedown that starts the drag
1871 * DumpRenderTree/win/EventSender.cpp:
1873 * DumpRenderTree/win/UIDelegate.cpp:
1874 (UIDelegate::doDragDrop):
1876 2007-10-24 Kevin McCullough <kmccullough@apple.com>
1878 Reviewed by Sam, Steve and Darin.
1880 - Stubbed out the WebScriptDebugListener functionality in the Server
1881 Connection class to prepare it for receiving those callbacks.
1882 - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1883 and the ServerConnection to not need to be initialized with a server
1884 name, since that is not the way we connect to the WebKit server.
1886 * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1887 no exception. Now it only loggs when there is an exception
1888 (DebuggerDocument::willExecuteStatement):
1889 (DebuggerDocument::didEnterCallFrame):
1890 (DebuggerDocument::willLeaveCallFrame):
1891 (DebuggerDocument::windowScriptObjectAvailable):
1892 (DebuggerDocument::callFunctionOnObject):
1893 * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1894 to be instantiated with a server's name.
1895 (DebuggerClient::DebuggerClient):
1896 (DebuggerClient::didFinishLoadForFrame):
1897 * Drosera/win/DebuggerClient.h: Removed unsued variable.
1898 * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1901 (Drosera::initServer):
1902 * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1903 instantiated with a server's name.
1904 * Drosera/win/ServerConnection.cpp:
1905 (ServerConnection::ServerConnection): No longer needs a server name
1906 (ServerConnection::~ServerConnection): Only release the global context
1908 (ServerConnection::serverConnectionDidDie): Stub for
1909 IWebScriptDebugListener
1910 (ServerConnection::QueryInterface): ditto
1911 (ServerConnection::AddRef): ditto
1912 (ServerConnection::Release): ditto
1913 (ServerConnection::didLoadMainResourceForDataSource): ditto
1914 (ServerConnection::didParseSource): ditto
1915 (ServerConnection::failedToParseSource): ditto
1916 (ServerConnection::didEnterCallFrame): ditto
1917 (ServerConnection::willExecuteStatement): ditto
1918 (ServerConnection::willLeaveCallFrame): ditto
1919 (ServerConnection::exceptionWasRaised): ditto
1920 * Drosera/win/ServerConnection.h: Stubbed out the
1921 IWebScriptDebugListener functions, and this class no longer needs to be
1922 instantiated with a server name.
1924 2007-10-24 Lars Knoll <lars@trolltech.com>
1928 add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1930 * DumpRenderTree/qt/jsobjects.h:
1932 2007-10-24 Lars Knoll <lars@trolltech.com>
1936 add another command.
1938 * DumpRenderTree/qt/jsobjects.cpp:
1939 (TextInputController::doCommand):
1941 2007-10-24 Lars Knoll <lars@trolltech.com>
1945 add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1947 * DumpRenderTree/qt/jsobjects.cpp:
1948 (EventSender::keyDown):
1949 * DumpRenderTree/qt/jsobjects.h:
1951 2007-10-24 Lars Knoll <lars@trolltech.com>
1955 implement eventSender.keyDown().
1957 * DumpRenderTree/qt/jsobjects.cpp:
1958 (EventSender::keyDown):
1960 2007-10-24 Lars Knoll <lars@trolltech.com>
1964 some smaller fixes to the editing support in DRT. Makes another few tests pass.
1966 * DumpRenderTree/qt/DumpRenderTree.cpp:
1967 (WebCore::DumpRenderTree::DumpRenderTree):
1968 (WebCore::DumpRenderTree::initJSObjects):
1969 * DumpRenderTree/qt/jsobjects.cpp:
1970 (TextInputController::doCommand):
1972 2007-10-24 Lars Knoll <lars@trolltech.com>
1976 first bit of implementation for the textinputcontroller.
1978 * DumpRenderTree/qt/DumpRenderTree.cpp:
1979 (WebCore::DumpRenderTree::DumpRenderTree):
1980 * DumpRenderTree/qt/DumpRenderTree.h:
1981 * DumpRenderTree/qt/jsobjects.cpp:
1982 (TextInputController::TextInputController):
1983 (TextInputController::doCommand):
1984 * DumpRenderTree/qt/jsobjects.h:
1986 2007-10-24 Lars Knoll <lars@trolltech.com>
1990 make the man webpage believe it has focus, so the editing tests work correctly.
1992 * DumpRenderTree/qt/DumpRenderTree.cpp:
1993 (WebCore::DumpRenderTree::DumpRenderTree):
1995 2007-10-24 Lars Knoll <lars@trolltech.com>
1999 implement layoutTestController.dumpEditingCallbacks() correctly.
2001 * DumpRenderTree/qt/DumpRenderTree.cpp:
2002 (WebCore::DumpRenderTree::DumpRenderTree):
2003 * DumpRenderTree/qt/jsobjects.cpp:
2004 (LayoutTestController::reset):
2005 (LayoutTestController::dumpEditingCallbacks):
2007 2007-10-24 Lars Knoll <lars@trolltech.com>
2011 Implement support for testing editing.
2013 * DumpRenderTree/qt/DumpRenderTree.cpp:
2014 (WebCore::DumpRenderTree::DumpRenderTree):
2016 2007-10-23 Sam Weinig <sam@webkit.org>
2018 Check for null BSTR that can be passed to the UIDelegate methods
2019 from javascript null and undefined. Fixes a failing test case on
2020 Windows (fast/dom/Window/alert-undefined.html)
2022 Reviewed by Eric Seidel.
2024 * DumpRenderTree/win/UIDelegate.cpp:
2025 (UIDelegate::runJavaScriptAlertPanelWithMessage):
2026 (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2027 (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2028 (UIDelegate::webViewAddMessageToConsole):
2030 2007-10-23 Maciej Stachowiak <mjs@apple.com>
2034 Don't print a massive pile of setenvs from tools that automatically build testkjs.
2036 * Scripts/build-testkjs:
2038 2007-10-23 Maciej Stachowiak <mjs@apple.com>
2042 - add wrapper that finds the right copy of testkjs
2044 * Scripts/sunspider-compare-results: Added.
2046 2007-10-23 Kevin McCullough <kmccullough@apple.com>
2050 - After talking with Steve I now see that the WebKit server must be
2051 running for DCOM to create the distributed objects, which makes sense
2052 and currently WebKit only allows one instance to be running at a time
2053 which avoids accidentally connecting to the wrong server
2054 - In light of this I have removed the code for the attach box and
2055 NotificationServer and known server names, since they are all extranious
2058 * Drosera/win/Drosera.cpp: Removed notification classes and known server
2060 (_tWinMain): Uses init instead of initUI.
2061 (droseraWndProc): No longer creats an attach dialog box.
2062 (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2063 it's not manditory to call init before doing COM stuff.
2064 (Drosera::init): calls initUI and will call attach when the
2065 functionality exists.
2066 (Drosera::initUI): Has changed very little.
2067 (Drosera::attach): Changed the signature to reflect that we no longer
2068 need the dictionary of known server names.
2069 * Drosera/win/Drosera.h: Removed notification classes and known server
2070 names. Also renamed and moved some functions.
2071 * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2072 * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2073 headers to the resources folder.
2074 * Drosera/win/resource.h: Removed the Attach box.
2076 2007-10-22 Adam Roben <aroben@apple.com>
2080 * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2082 2007-10-22 Kevin McCullough <kmccullough@apple.com>
2084 - Removed a leak that was fixed.
2086 * Scripts/run-webkit-tests:
2088 2007-10-19 Kevin McCullough <kmccullough@apple.com>
2092 - Changed the Client so that the DebuggerDocument now own the
2093 ServerConnection. This simplifies ownership and cleanup.
2095 * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2097 (DebuggerClient::initWithServerName):
2098 (DebuggerClient::didFinishLoadForFrame):
2099 * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
2101 * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2102 until after we have a server which we are attached to.
2105 * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2108 2007-10-22 Simon Hausmann <hausmann@kde.org>
2110 Reviewed by Nikolas.
2112 When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2114 * Scripts/run-javascriptcore-tests:
2116 2007-10-22 Simon Hausmann <hausmann@kde.org>
2118 Reviewed by Nikolas.
2120 Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2122 * Scripts/build-drosera:
2123 * Scripts/build-dumprendertree:
2124 * Scripts/build-testkjs:
2125 * Scripts/build-webkit:
2126 * Scripts/run-javascriptcore-tests:
2127 * Scripts/run-sunspider:
2128 * Scripts/run-webkit-tests:
2129 * Scripts/webkitdirs.pm:
2131 2007-10-22 Andrew Wellington <proton@wiretapped.net>
2133 Reviewed by Mark Rowe.
2135 Fix for local database support after r26879
2136 Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2138 * Scripts/build-webkit:
2140 2007-10-22 Holger Freyther <zecke@selfish.org>
2142 Reviewed by Simon Hausmann <hausmann@kde.org>.
2144 - Do not build testkjs as an application bundle. This is
2145 needed for run-javascriptcore-tests on OSX.
2146 - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2147 - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2148 as we do not have -rpath on OSX.
2150 * DumpRenderTree/qt/DumpRenderTree.pro:
2151 * Scripts/run-webkit-tests:
2153 2007-10-22 Simon Hausmann <hausmann@kde.org>
2157 Fix support for Signed-off-by detection in prepare-ChangeLog
2158 --git-commit. The Signed-off-by tag does not appear in the header
2159 but usually at the end.
2161 * Scripts/prepare-ChangeLog:
2163 2007-10-21 Mark Rowe <mrowe@apple.com>
2167 Fix run-javascriptcore-tests for Gtk.
2169 * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2171 2007-10-20 Eric Seidel <eric@webkit.org>
2175 * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2177 2007-10-20 Eric Seidel <eric@webkit.org>
2181 Add improved argument handling to run-sunspider, including
2182 --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2183 Also re-factor code into subroutines
2185 * Scripts/build-dumprendertree: removed bogus comments
2186 * Scripts/build-testkjs: Added.
2187 * Scripts/run-javascriptcore-tests: use build-testkjs
2188 * Scripts/run-sunspider: improved argument handling, abstraction
2189 * Scripts/run-webkit-tests: improved abstraction
2191 2007-10-20 Matt Lilek <webkit@mattlilek.com>
2193 Not reviewed, Windows build fix.
2195 * DumpRenderTree/win/EventSender.cpp:
2198 2007-10-20 Darin Adler <darin@apple.com>
2200 Reviewed by Tim Hatcher.
2202 - http://bugs.webkit.org/show_bug.cgi?id=15544
2203 <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2204 not rely on Apple-specific key codes
2206 * DumpRenderTree/mac/EventSendingController.mm:
2207 (-[EventSendingController keyDown:withModifiers:]):
2208 Added named key "rightArrow". Later we could have a whole table of these.
2209 Also tweaked modifiers code a little.
2211 * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2213 2007-10-19 Darin Adler <darin@apple.com>
2217 - http://bugs.webkit.org/show_bug.cgi?id=15566
2218 possible fix for leak seen in DumpRenderTree
2220 * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2221 Delete the item if it's not put on the queue, since the caller has
2222 no way of knowing that. Would be better to have the parameter type
2223 be auto_ptr to express the fact that we take ownership.
2227 * Drosera/mac/main.m: Add missing include.
2229 2007-10-19 Kevin McCullough <kmccullough@apple.com>
2233 - This change should be identical but for some reason was not working
2236 * Scripts/prepare-ChangeLog:
2238 2007-10-19 Kevin McCullough <kmccullough@apple.com>
2240 Reviewed by Oliver and Tim.
2242 - Made use of RetainPtr to avoid retain and release issues and moved the
2243 log function to DebuggerDocumentPlatform, which seems to be a more
2244 logical place for it to live.
2245 - Also moved knownServers from the ServerConnection to
2246 DebuggerApplication to match the Windows code and because it makes sense
2247 that a connection knows its own server but not all of them.
2249 * Drosera/mac/DebuggerClient.h: Moved the log function to
2250 DebuggerDocumentPlatform.
2251 * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2252 Because it's owned by an own Ptr in DebuggerDocument. Also moved the
2253 call for the server name up from the ServerConnection class.
2254 (-[DebuggerClient dealloc]):
2255 (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2256 for the server name up from the ServerConnection.
2257 * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2258 (DebuggerDocument::platformPause):
2259 (DebuggerDocument::platformResume):
2260 (DebuggerDocument::platformStepInto):
2261 (DebuggerDocument::platformEvaluateScript):
2262 (DebuggerDocument::getPlatformCurrentFunctionStack):
2263 (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2264 (DebuggerDocument::platformValueForScopeVariableNamed):
2265 (DebuggerDocument::platformLog): Log directly from here. No need to call
2267 * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2268 way I see it, a ServerConnection should only know about its connection
2269 and the group of all possible servers should be kept by the
2271 * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2272 currentServerName, it makes sense that the connection should know that
2274 (-[ServerConnection currentServerName]):
2276 2007-10-19 Kevin McCullough <kmccullough@apple.com>
2280 - Integrated changes from mac drosera. Recently I've encapsulated
2281 out the server connection object from the rest of Drosera because
2282 it is very platform dependent right now and RPC is not implemented on
2283 windows. This functionality, of communicating with the WebKit server
2284 is the next area I will be focusing on in Windows.
2286 - Other changes and cleanup were made to organize the code and add notes
2287 on which parts still need work. Also some mac code is added and
2288 commented out, to act as pseudocode for the logic of those parts.
2290 * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2292 * Drosera/config.h: Added whitespace.
2293 * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2294 these files got moved into Drosera.h/cpp
2295 * Drosera/win/DebuggerApplication.h: Removed.
2296 * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
2297 happened here to better match the logic flow of the same code on the
2298 mac side and to use the new ServerConnection class.
2299 (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2300 (DebuggerClient::initWithServerName): Initializer that will set up the
2301 class to use a ServerConnection object. This was necessary so I could
2302 create a DebuggerClient without having to initilaize it at
2304 (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2305 will be the UIDelegate and FrameLoadDelegate.
2306 (DebuggerClient::AddRef): For IUnknown.
2307 (DebuggerClient::Release): For IUnknown.
2308 (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2309 this still needs to set the global context of the server, but
2310 IWebFrame does not have an accessor for the global context yet.
2311 (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2312 this is a pass through for the same function in the document.
2313 (DebuggerClient::didReceiveTitle): Unimplemented part of
2314 FrameLoadDelegate this would change the title of the window.
2315 (DebuggerClient::createWebViewWithRequest): Part of the
2316 FrameLoadDelegate. This is about new windows via Window.open() and
2317 how their delegates are set.
2318 (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2319 UIDelegate. Just a debug function for printing messages.
2320 * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2321 because the Client should be the UIDelegate and FrameLoadDelegate
2322 to match the delegates on mac.
2323 (DebuggerClient::webViewLoaded): Added accessor method.
2324 * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2325 forgotten to add this file before. This is where the platform
2326 dependent versions of the Documents functions live. Most of these are
2327 unimplemented because some piece of functionality does not exist on
2329 (DebuggerDocument::platformPause):
2330 (DebuggerDocument::platformResume):
2331 (DebuggerDocument::platformStepInto):
2332 (DebuggerDocument::platformEvaluateScript):
2333 (DebuggerDocument::getPlatformCurrentFunctionStack):
2334 (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2335 (DebuggerDocument::platformValueForScopeVariableNamed):
2336 (DebuggerDocument::platformLog):
2337 * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2338 responsibilities becaue they belong in the Client. Also I laid the
2339 groundwork for attaching Drosera to a WebKit process
2340 (attachWndProc): Now if a server is selected the Client becomes it's
2342 (Drosera::Drosera): Added the construction of the Client and dictionary
2344 (Drosera::initUI): This is no longer the delegates, the Client is.
2345 (Drosera::webViewLoaded): Now asks the Client instead of holding local
2347 (Drosera::applicationDidFinishLaunching): Placeholder for needed
2348 notification registration when it's possible to implement.
2349 (Drosera::serverLoaded): Ditto
2350 (Drosera::serverUnloaded): Ditto
2351 (Drosera::attach): Attach Drosera to the WebKit server.
2352 * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2355 (Drosera::knownServers):
2356 * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2357 and added the ServerConnection.
2358 * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2359 * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2360 Most of the functions are completely unimlemented because they cannot
2361 connect with the WebKit server, because one does not exist on Windows
2363 (ServerConnection::initWithServerName):
2364 (ServerConnection::~ServerConnection):
2365 (ServerConnection::setGlobalContext):
2366 (ServerConnection::pause):
2367 (ServerConnection::resume):
2368 (ServerConnection::stepInto):
2369 (ServerConnection::switchToServerNamed):
2370 (ServerConnection::applicationTerminating):
2371 (ServerConnection::serverConnectionDidDie):
2372 (ServerConnection::currentFrame):
2373 * Drosera/win/ServerConnection.h: Added. Ditto.
2374 (ServerConnection::ServerConnection):
2376 2007-10-19 Alice Liu <alice.liu@apple.com>
2380 Fix for these broken layout tests on Windows:
2382 fast/forms/focus-selection-input.html
2383 fast/forms/focus-selection-textarea.html
2384 fast/forms/select-accesskey.html
2386 * DumpRenderTree/win/EventSender.cpp:
2388 correct the VK code for alt key.
2390 2007-10-19 Eric Seidel <eric@webkit.org>
2392 Reviewed by Mark Rowe.
2394 Make the GtkLauncher code slightly more readable.
2396 * GtkLauncher/main.cpp:
2397 (setupMainMenu): Added.
2398 (setupMainWindowUI): Added.
2401 2007-10-19 Maciej Stachowiak <mjs@apple.com>
2403 Rubber stamped by Adam.
2405 - don't delay-load WebKit in DumpRenderTree.
2407 * DumpRenderTree/win/DumpRenderTree.vcproj:
2409 2007-10-18 Dan Bernstein <mitz@apple.com>
2411 Reviewed by Adam Roben.
2413 - fix <rdar://problem/5313523>
2414 REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2416 * DumpRenderTree/mac/DumpRenderTree.mm:
2417 (dump): Changed to use _responseMIMEType.
2419 2007-10-17 Adam Roben <aroben@apple.com>
2421 Make it possible to have Windows-specific tests and results
2423 When searching for tests to run and the Skipped file, we will only
2424 look in platform/win and the cross-platform directory. When looking
2425 for expected results, we will look in platform/win, then
2426 platform/mac-leopard, then platform/mac, then finally the
2427 cross-platform directory.
2431 * Scripts/run-webkit-tests:
2432 (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2433 searching in the cross-platform directory.
2434 (sub buildPlatformHierarchy): Removed some unneeded calls to
2437 2007-10-17 Adam Roben <aroben@apple.com>
2439 Add back the call to register WebKit that we had before WebKitInitializer existed
2441 This is needed to ensure that the right WebKit is used when
2442 instantiating COM objects.
2446 * DumpRenderTree/win/debug_internal.vsprops: Define
2447 DEBUG_WEBKIT_HAS_SUFFIX.
2448 * DumpRenderTree/win/DumpRenderTree.cpp:
2451 2007-10-17 Adam Roben <aroben@apple.com>
2453 Import File::Basename in webkitdirs since we use it
2455 * Scripts/webkitdirs.pm:
2457 2007-10-17 Kevin McCullough <kmccullough@apple.com>
2459 - Updated the tiger leaks list to make the internal bots green.
2461 * Scripts/run-webkit-tests:
2463 2007-10-17 Adam Roben <aroben@apple.com>
2465 Build fix for VC++ Express
2467 * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2470 2007-10-16 Kevin McCullough <kmccullough@apple.com>
2474 - Minor mac improvements based on observations I made while implementing the
2477 * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2478 then hand it to the Client who will retain it, it should just be the client who
2479 creates and owns the server.
2480 (-[DebuggerApplication attach:]):
2481 * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2482 * Drosera/mac/DebuggerClient.mm: Creates the server.
2483 (-[DebuggerClient initWithServerName:]):
2484 * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2485 can instead forward declare what it needs.
2487 2007-10-16 Darin Adler <darin@apple.com>
2489 Reviewed by Geoff Garen.
2491 * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2492 want to turn failing tests into platform-specific test results. Also did a
2493 number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2494 would take the type of results into account only some of the time.
2496 2007-10-16 Adam Roben <aroben@apple.com>
2498 Add a new nightly launcher script for Windows
2500 This new script is for versions of Safari that don't delay-load
2501 WebKit. I had to make FindSafari be able to print out the nightly
2502 launcher script on stdout because Windows shell scripts can't capture
2503 the output from a command into an environment variable.
2507 * FindSafari/FindSafari.cpp:
2508 (_tmain): Added /printSafariLauncher option.
2509 * Scripts/run-webkit-nightly.cmd: Added.
2511 2007-10-16 Adam Roben <aroben@apple.com>
2513 Replace WebKitInitializer with FindSafari
2515 We now rely on setting the PATH environment variable to tell Windows
2516 where to find WebKit and its dependencies (similar to
2517 DYLD_FRAMEWORK_PATH on Mac).
2519 This change also make DumpRenderTree no longer delay-load WebKit.
2523 * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2525 * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2526 * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2527 WebKitInitializer, don't delay-load WebKit.
2528 * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2529 * Scripts/run-webkit-tests: Ditto.
2530 * Scripts/webkitdirs.pm:
2531 (sub setPathForRunningWebKitApp): Added.
2532 * WebKitInitializer/WebKitInitializer.cpp: Removed.
2533 * WebKitInitializer/WebKitInitializer.h: Removed.
2534 * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2535 * WebKitInitializer/debug.vsprops: Removed.
2536 * WebKitInitializer/debug_internal.vsprops: Removed.
2537 * WebKitInitializer/release.vsprops: Removed.
2539 2007-10-16 Adam Roben <aroben@apple.com>
2541 Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2543 http://bugs.webkit.org/show_bug.cgi?id=15532
2545 FindSafari simply prints the location of an installed Safari.exe on
2550 * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2553 (getInstalledWebKitDirectory):
2555 * FindSafari/FindSafari.vcproj: Added.
2556 * Scripts/webkitdirs.pm:
2557 (sub installedSafariPath): Added. Calls FindSafari on Windows.
2559 2007-10-16 Adam Roben <aroben@apple.com>
2561 Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2563 Reviewed by Kevin McCullough.
2565 * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2566 when referring to WebKit.dll.
2567 * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2568 * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2569 * DumpRenderTree/win/release.vsprops: Ditto.
2570 * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2571 never have a _debug suffix on WebKit.dll.
2572 * WebKitInitializer/WebKitInitializer.cpp:
2573 (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2575 * WebKitInitializer/debug_internal.vsprops: Added
2576 DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2578 2007-10-16 Darin Adler <darin@apple.com>
2582 * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2583 Remove now-unneeded control/alt key hack; the tests have been updated.
2585 2007-10-16 Kevin McCullough <kmccullough@apple.com>
2587 - Updated leaks list because our internal bot upgraded it's version of leopard and
2588 one of the leaks was fixed between that revision and the bot's previous version of
2591 * Scripts/run-webkit-tests:
2593 2007-10-15 Kevin McCullough <kmccullough@apple.com>
2597 - I encapsulated out the server connecton functionality because it is a specific part
2598 of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2599 into WebCore and C++. But if it is encapsulated out it can be easily replaced on
2600 Windows. So the majority of this patch is moving preexisting functionality.
2602 - Also I removed the prefix header and changed to use config.h because it is more
2603 standard on how we use config.h in windows and it didn't make much sense to keep
2604 the prefix header and the config.h
2606 * Drosera/DebuggerDocument.cpp:
2607 (DebuggerDocument::DebuggerDocument):
2608 * Drosera/DebuggerDocument.h:
2610 * Drosera/mac/DebuggerApplication.mm:
2611 (-[DebuggerApplication attach:]):
2612 * Drosera/mac/DebuggerClient.h:
2613 * Drosera/mac/DebuggerClient.mm:
2614 (-[DebuggerClient initWithServerConnection:]):
2615 (-[DebuggerClient dealloc]):
2616 (-[DebuggerClient windowDidLoad]):
2617 (-[DebuggerClient windowWillClose:]):
2618 (-[DebuggerClient webView:didFinishLoadForFrame:]):
2619 (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2620 * Drosera/mac/DebuggerDocumentPlatform.mm:
2621 (DebuggerDocument::platformPause):
2622 (DebuggerDocument::platformResume):
2623 (DebuggerDocument::platformStepInto):
2624 (DebuggerDocument::platformEvaluateScript):
2625 (DebuggerDocument::getPlatformCurrentFunctionStack):
2626 (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2627 (DebuggerDocument::platformValueForScopeVariableNamed):
2628 (DebuggerDocument::platformLog):
2629 * Drosera/mac/Drosera.pch: Removed.
2630 * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2631 * Drosera/mac/ServerConnection.h: Added.
2632 * Drosera/mac/ServerConnection.mm: Added.
2633 (-[ServerConnection initWithServerName:]):
2634 (-[ServerConnection dealloc]):
2635 (-[ServerConnection setGlobalContext:]):
2636 (-[ServerConnection pause]):
2637 (-[ServerConnection resume]):
2638 (-[ServerConnection stepInto]):
2639 (-[ServerConnection switchToServerNamed:]):
2640 (-[ServerConnection applicationTerminating:]):
2641 (-[ServerConnection serverConnectionDidDie:]):
2642 (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2643 (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2644 (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2645 (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2646 (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2647 (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2648 (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2649 (-[ServerConnection currentFrame]):
2650 (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2651 (-[ServerConnection knownServers]):
2653 2007-10-15 David Kilzer <ddkilzer@webkit.org>
2657 - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2658 Script to automatically search nightly builds for regressions (bisect-builds)
2660 * Scripts/bisect-builds: Added.
2662 2007-10-14 Maciej Stachowiak <mjs@apple.com>
2666 - New JavaScript benchmark
2667 http://bugs.webkit.org/show_bug.cgi?id=15515
2669 * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2670 current development or release build of JavaScriptCore.
2672 2007-10-15 Mark Rowe <mrowe@apple.com>
2676 Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2678 * Scripts/webkitdirs.pm:
2679 - Change checkArgv to remove the options from @ARGV to prevent
2680 them from interfering with further option processing.
2681 - Fix logic error in determineIsQt that would prevent it from bailing out early.
2682 - Change isOSX to mean OS X and not Qt or Gtk. Most of our uses of isOSX assume that this is the meaning
2683 already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2684 incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2686 2007-10-15 Darin Adler <darin@apple.com>
2690 - added logging of window.prompt and window.confirm
2692 * DumpRenderTree/mac/UIDelegate.mm:
2693 (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2694 Implement the recommended delegate rather than the deprecated one.
2695 (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2697 (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2700 * DumpRenderTree/win/UIDelegate.h:
2701 * DumpRenderTree/win/UIDelegate.cpp:
2702 (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2703 (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2704 (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2705 (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2707 2007-10-15 Alice Liu <alice.liu@apple.com>
2709 Reviewed by Sam Weinig.
2711 Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2713 * DumpRenderTree/win/DumpRenderTree.cpp:
2714 (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2715 (main): allocate the global policy delegate for DRT's custom use
2716 * DumpRenderTree/win/DumpRenderTree.vcproj:
2717 Adding files to project
2718 * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2719 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2720 (LayoutTestController::setCustomPolicyDelegate):
2721 set the webview's policy delegate to DRT's custom one if the test requests it.
2722 * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2723 Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2724 (PolicyDelegate::PolicyDelegate):
2725 (PolicyDelegate::QueryInterface):
2726 (PolicyDelegate::AddRef):
2727 (PolicyDelegate::Release):
2728 (PolicyDelegate::decidePolicyForNavigationAction):
2729 * DumpRenderTree/win/PolicyDelegate.h: Added.
2730 (PolicyDelegate::decidePolicyForNewWindowAction):
2731 (PolicyDelegate::decidePolicyForMIMEType):
2732 (PolicyDelegate::unableToImplementPolicyWithError):
2734 2007-10-14 Holger Hans Peter Freyther <zecke@selfish.org>
2738 * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2739 when querying for QMAKE_MKSPECS.
2741 2007-10-14 Andrew Wellington <proton@wiretapped.net>
2743 Reviewed by Adam Roben.
2745 Fix run-webkit-tests is too greedy calculating platform hierarchy
2746 http://bugs.webkit.org/show_bug.cgi?id=15465
2748 Fix run-webkit-tests being too greedy in trying to split the platform name up
2749 causing it to try and find tests in every directory above the first "-" in the
2750 path to the LayoutTests
2752 * Scripts/run-webkit-tests:
2754 2007-10-14 Oleg Sukhodolsky <son.two@gmail.com>
2758 http://bugs.webkit.org/show_bug.cgi?id=15006
2759 Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2760 to reduce code duplication.
2762 * Scripts/build-webkit:
2763 * Scripts/webkitdirs.pm:
2764 buildQMakeProject() renamed to buildQMakeQtProject().
2765 buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2766 unused $colorize has been removed.
2768 === Start merge of feature-branch 2007-10-12 ===
2770 2007-10-08 Eric Seidel <eric@webkit.org>
2772 Reviewed by Mark Rowe.
2774 * Scripts/build-webkit: add --help, remove unused --color
2776 2007-10-07 Eric Seidel <eric@webkit.org>
2780 * Drosera/mac/DebuggerDocumentPlatform.mm:
2781 (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2783 2007-10-03 Rob Buis <buis@kde.org>
2787 Adapt to changed location of Ahem font.
2789 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2791 2007-10-02 Eric Seidel <eric@webkit.org>
2793 Reviewed by Adam Roben.
2795 Make pixel tests more useful!
2796 Finally fix the image diff 0.00% mystery problem
2797 Highlight any image differences in the image diff.
2798 Add a link from image diffs back to original test file.
2800 * DumpRenderTree/mac/ImageDiff.m:
2801 (compareImages): highlight any differences
2802 (computePercentageDifferent): round to two decimal places
2803 * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2805 2007-10-02 Eric Seidel <eric@webkit.org>
2807 Reviewed by Alexey Proskuryakov.
2809 * Scripts/run-webkit-tests: print the % image difference on main results page
2811 2007-10-02 Mark Rowe <mrowe@apple.com>
2815 Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2817 * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2818 * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2820 2007-10-01 Mark Rowe <mrowe@apple.com>
2822 * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2824 2007-09-25 Eric Seidel <eric@webkit.org>
2826 Reviewed by Mark Rowe.
2828 DerivedSources.make was finding "ENABLE_SVG" in the string
2829 "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2832 * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2834 2007-09-25 Mark Rowe <mrowe@apple.com>
2836 Rubber-stamped by Eric.
2838 * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2839 This makes it possible to automate nightly builds for the feature-branch.
2841 2007-07-11 Nikolas Zimmermann <zimmermann@kde.org>
2843 Rubber stamped by Mark.
2845 Enable svg experimental features as default here in feature-branch.
2847 * Scripts/build-webkit:
2849 2007-06-29 Antti Koivisto <antti@apple.com>
2853 Add VIDEO flag for timed media features
2855 * Scripts/build-webkit
2857 === End merge of feature-branch 2007-10-12 ===
2859 2007-10-11 Kevin McCullough <kmccullough@apple.com>
2863 - Updated rational for the leaks list to be more clear.
2865 * Scripts/run-webkit-tests:
2867 2007-10-11 Kevin McCullough <kmccullough@apple.com>
2869 Rubber Stamp by Sam.
2871 Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2872 I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2874 * Scripts/run-webkit-tests:
2876 2007-10-10 Simon Hausmann <hausmann@kde.org>
2880 Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2881 includes are needed for INT_MAX, std::auto_ptr and the like.
2883 * DumpRenderTree/qt/main.cpp:
2885 2007-10-09 Lars Knoll <lars@trolltech.com>
2889 implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2891 * DumpRenderTree/qt/jsobjects.cpp:
2892 (LayoutTestController::encodeHostName):
2893 (LayoutTestController::decodeHostName):
2894 * DumpRenderTree/qt/jsobjects.h:
2896 2007-10-09 Lars Knoll <lars@trolltech.com>
2900 Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2902 * DumpRenderTree/qt/DumpRenderTree.cpp:
2903 (WebCore::WebPage::createFrame):
2904 (WebCore::DumpRenderTree::DumpRenderTree):
2905 (WebCore::DumpRenderTree::titleChanged):
2906 * DumpRenderTree/qt/DumpRenderTree.h:
2907 * DumpRenderTree/qt/jsobjects.cpp:
2908 (LayoutTestController::reset):
2909 * DumpRenderTree/qt/jsobjects.h:
2911 2007-10-09 Lars Knoll <lars@trolltech.com>
2915 add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2917 * DumpRenderTree/qt/DumpRenderTree.h:
2918 * DumpRenderTree/qt/jsobjects.cpp:
2919 (LayoutTestController::clearBackForwardList):
2920 * DumpRenderTree/qt/jsobjects.h:
2922 2007-10-09 Lars Knoll <lars@trolltech.com>
2926 make --git-reviewer work again.
2928 * Scripts/prepare-ChangeLog:
2930 2007-10-07 Holger Hans Peter Freyther <zecke@selfish.org>
2932 Rubber stamped by Eric.
2934 Connect to the "hovering-over-link" signal emitted by WebKitPage and
2935 show the current link inside the statusbar.
2936 This shows how to make use of this signal and allows to easily test
2937 http://bugs.webkit.org/show_bug.cgi?id=15299.
2939 * GtkLauncher/main.cpp:
2943 2007-10-05 Lars Knoll <lars@trolltech.com>
2945 add proper error messages to the FrameLoaderClient.
2946 Implement ChromeClientQt::closeWindowSoon and
2947 FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2948 Some fixes in DRT to make it work correctly with multiple windows.
2952 * DumpRenderTree/qt/DumpRenderTree.cpp:
2953 (WebCore::DumpRenderTree::DumpRenderTree):
2954 (WebCore::DumpRenderTree::createWindow):
2955 (WebCore::DumpRenderTree::windowCount):
2956 * DumpRenderTree/qt/DumpRenderTree.h:
2957 * DumpRenderTree/qt/jsobjects.cpp:
2958 (LayoutTestController::maybeDump):
2959 (LayoutTestController::windowCount):
2960 * DumpRenderTree/qt/jsobjects.h:
2962 2007-10-05 Lars Knoll <lars@trolltech.com>
2964 Add a dummy plugin to DRT to fix fast/dom/Window/Plug-Ins.html.
2965 Add support for layoutTextController.setCanOpenWindows() to DRT
2966 fixing another 2 test cases in fast/dom/Window.
2970 * DumpRenderTree/qt/DumpRenderTree.cpp:
2971 (WebCore::WebPage::WebPage):
2972 (WebCore::WebPage::createWindow):
2973 (WebCore::DumpRenderTree::resetJSObjects):
2974 (WebCore::DumpRenderTree::createWindow):
2975 * DumpRenderTree/qt/DumpRenderTree.h:
2976 * DumpRenderTree/qt/DumpRenderTree.pro:
2977 * DumpRenderTree/qt/jsobjects.cpp:
2978 (LayoutTestController::LayoutTestController):
2979 (LayoutTestController::reset):
2980 * DumpRenderTree/qt/jsobjects.h:
2981 * DumpRenderTree/qt/main.cpp:
2982 * DumpRenderTree/qt/testplugin.cpp: Added.
2983 * DumpRenderTree/qt/testplugin.h: Added.
2985 2007-10-04 Sam Weinig <sam@webkit.org>
2987 Rubber stamped by Adam.
2989 Remove empty directories.
2991 * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2992 * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2994 2007-10-03 Darin Adler <darin@apple.com>
2998 * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2999 we find the internal libraries in the libraries directory. This
3000 is helpful for Safari team engineers at Apple.
3002 2007-10-03 Adam Roben <aroben@apple.com>
3004 Update the location of AHEM___.TTF after r25968
3008 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3010 2007-10-03 Alp Toker <alp@atoker.com>
3014 http://bugs.webkit.org/show_bug.cgi?id=14726
3015 [gtk] API design. Mapping the WebView delegates to signals.
3017 Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3019 * GtkLauncher/main.cpp:
3023 (menuMainBackCallback):
3024 (menuMainForwardCallback):
3027 2007-10-03 Lars Knoll <lars@trolltech.com>
3031 This fixes --strict mode in run-webkit-tests again after
3032 the platform dependent test results have been moved.
3034 * Scripts/run-webkit-tests:
3036 2007-10-03 Lars Knoll <lars@trolltech.com>
3040 remove the hack in run-webkit-tests that forced text only test
3041 to be taken from the platform independent dir. It was only left
3042 there from early days.
3044 Remove platform dependent results for tests that are text only nowadays,
3045 and add one platform dependent result for a text only test that requires it.
3047 * Scripts/run-webkit-tests:
3049 2007-10-03 Lars Knoll <lars@trolltech.com>
3053 Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3055 * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3056 (WebCore::WebFrame::WebFrame):
3057 (WebCore::WebPage::WebPage):
3058 (WebCore::WebPage::createFrame):
3059 (WebCore::WebPage::javaScriptAlert):
3060 (WebCore::WebPage::javaScriptConsoleMessage):
3061 (WebCore::DumpRenderTree::DumpRenderTree):
3062 (WebCore::DumpRenderTree::~DumpRenderTree):
3063 (WebCore::DumpRenderTree::open):
3064 (WebCore::DumpRenderTree::readStdin):
3065 (WebCore::DumpRenderTree::resetJSObjects):
3066 (WebCore::DumpRenderTree::initJSObjects):
3067 (WebCore::DumpRenderTree::dumpFramesAsText):
3068 (WebCore::DumpRenderTree::dump):
3069 * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3070 (WebCore::DumpRenderTree::layoutTestController):
3071 (WebCore::DumpRenderTree::eventSender):
3072 * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3073 * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3074 * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3075 * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3076 (HackWebFrame::mousePressEvent):
3077 (HackWebFrame::mouseReleaseEvent):
3078 (HackWebFrame::mouseMoveEvent):
3079 (HackWebFrame::HackWebFrame):
3080 (HackWebFrame::~HackWebFrame):
3081 (LayoutTestController::LayoutTestController):
3082 (LayoutTestController::reset):
3083 (LayoutTestController::maybeDump):
3084 (LayoutTestController::waitUntilDone):
3085 (LayoutTestController::notifyDone):
3086 (LayoutTestController::dumpEditingCallbacks):
3087 (LayoutTestController::queueReload):
3088 (LayoutTestController::provisionalLoad):
3089 (LayoutTestController::timerEvent):
3090 (EventSender::EventSender):
3091 (EventSender::mouseDown):
3092 (EventSender::mouseUp):
3093 (EventSender::mouseMoveTo):
3094 (EventSender::leapForward):
3095 (EventSender::keyDown):
3096 (EventSender::frameUnderMouse):
3097 * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3098 (LayoutTestController::isLoading):
3099 (LayoutTestController::setLoading):
3100 (LayoutTestController::shouldDumpAsText):
3101 (LayoutTestController::shouldDumpChildrenAsText):
3102 (LayoutTestController::shouldWaitUntilDone):
3103 (LayoutTestController::dumpAsText):
3104 (LayoutTestController::dumpChildFramesAsText):
3105 * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3109 * Scripts/run-webkit-tests:
3111 2007-10-03 Mark Rowe <mrowe@apple.com>
3113 Reviewed by Alp Toker.
3115 Fix build-webkit when both QTDIR and --gtk are set. The presence of --gtk
3116 should take precedence over QTDIR when determining which port we are working with.
3118 * Scripts/webkitdirs.pm:
3120 2007-10-02 Adam Roben <aroben@apple.com>
3122 Add keychain to the list of default packages to install
3124 Rubberstamped by Sam.
3126 * CygwinDownloader/cygwin-downloader.py:
3127 * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3129 2007-10-02 David Kilzer <ddkilzer@webkit.org>
3133 Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3134 Also makes WebCore regression test case logic work when using git.
3136 * Scripts/prepare-ChangeLog:
3137 (reviewerAndDescriptionForGitCommit): Added.
3139 2007-10-02 Lars Knoll <lars@trolltech.com>
3143 Add API to retrieve the frame name from QWebFrame.
3144 Implement support for DRT::dumpChildrenAsText.
3146 * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3147 (WebCore::DumpRenderTree::dumpFramesAsText):
3148 (WebCore::DumpRenderTree::dump):
3149 * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3150 * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3151 (LayoutTestController::LayoutTestController):
3152 (LayoutTestController::reset):
3153 * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3155 2007-10-02 Lars Knoll <lars@trolltech.com>
3159 Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3161 * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3162 (WebCore::DumpRenderTree::readStdin):
3164 2007-10-02 Mark Rowe <mrowe@apple.com>
3168 Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3170 * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3171 * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3173 2007-10-02 Mark Rowe <mrowe@apple.com>
3175 Rubber-stamped by Maciej.
3177 Configuration changes from build.webkit.org. The major change is refactoring to work
3178 with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3181 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3182 * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3183 * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3184 * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3185 * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3186 * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3187 * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3188 * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3190 2007-10-02 Lars Knoll <lars@trolltech.com>
3194 Add support for eventSender.mouseMove to DRT.
3195 Fixes fast/css/hover-affects-child.html
3197 * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3198 (EventSender::mouseMoveTo):
3200 2007-10-01 Mark Rowe <mrowe@apple.com>
3202 * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3204 2007-10-01 David Kilzer <ddkilzer@webkit.org>
3208 Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3210 * Scripts/svn-apply:
3211 (gitdiff2svndiff): Ignore lines beginning with "new file".
3212 * Scripts/svn-unapply:
3213 (gitdiff2svndiff): Ditto.
3215 2007-09-30 George Staikos <staikos@kde.org>
3217 Qt build fix (Mac OS X specific)
3219 * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3221 2007-09-29 Holger Hans Peter Freyther <zecke@selfish.org>
3225 -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3226 Remove Bakefiles from svn.
3228 * GtkLauncher/Bakefiles.bkgen: Removed.
3229 * GtkLauncher/ENV: Removed.
3230 * GtkLauncher/gdklauncher.bkl: Removed.
3231 * GtkLauncher/mk: Removed.
3232 * Scripts/regenerate-makefiles: Removed.
3234 2007-09-25 Kevin McCullough <kmccullough@apple.com>
3238 - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3240 * Scripts/run-webkit-tests:
3242 2007-09-26 Adam Roben <aroben@apple.com>
3244 Make not finding an installed WebKit non-fatal
3246 What really matters is that we are able to load WebKit and its
3247 dependencies, not whether we think we've found an installed WebKit.
3251 * WebKitInitializer/WebKitInitializer.cpp:
3252 (getWebViewCLSID): Use new LOG_WARNING macro.
3253 (getInstalledWebKitDirectory): Ditto.
3254 (initializeWebKit): Don't die if we didn't find an installed WebKit,
3256 * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3258 2007-09-26 Adam Roben <aroben@apple.com>
3260 Committed this file before saving it
3262 * WebKitInitializer/debug_internal.vsprops:
3264 2007-09-26 Adam Roben <aroben@apple.com>
3266 Load WebKit and its dependencies manually so they come from DllDirectory
3268 I had to change WebKitInitializer to use malloc/free instead of
3269 new/delete to avoid pulling in WebKit (and its dependencies) early
3270 through use of fastMalloc.
3274 * WebKitInitializer/WebKitInitializer.cpp:
3275 (getStringValue): Changed to use malloc/free.
3276 (getInstalledWebKitDirectory): Ditto.
3277 (initializeWebKit): Call SetDllDirectory first, then load all of
3278 WebKit's dependencies manually, finally followed by WebKit itself.
3279 * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3280 configuration to match our other projects.
3281 * WebKitInitializer/debug_internal.vsprops: Added.
3283 2007-09-25 Adam Roben <aroben@apple.com>
3285 Actually define DEBUG/NDEBUG so that we load WebKit correctly
3287 Rubberstamped by Sam.
3289 * WebKitInitializer/WebKitInitializer.vcproj:
3291 2007-09-25 Adam Roben <aroben@apple.com>
3293 Make DumpRenderTree delay-load its dependencies
3295 This lets WebKitInitializer re-route the dependencies to be loaded out
3296 of the Safari installation directory.
3298 Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3299 same thing), since we can't import the kCFAllocatorDefault symbol when
3300 delay-loading CoreFoundation.dll.
3302 Rubberstamped by Sam.
3304 * DumpRenderTree/win/DumpRenderTree.cpp:
3306 (javaScriptThreads):
3307 * DumpRenderTree/win/DumpRenderTree.vcproj:
3308 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3309 (LayoutTestController::setWaitToDump):
3311 2007-09-25 Adam Roben <aroben@apple.com>
3313 Pull ole32.lib into WebKitInitializer
3315 Rubberstamped by Sam.
3317 * WebKitInitializer/WebKitInitializer.vcproj:
3319 2007-09-25 David Kilzer <ddkilzer@webkit.org>
3323 - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3324 LGPL'ed files contain incorrect FSF address
3328 2007-09-25 David Kilzer <ddkilzer@webkit.org>
3332 Make svn-apply and svn-unapply work with git-diff formatted patches.
3334 * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3335 (gitdiff2svndiff): Added.
3336 * Scripts/svn-unapply: Ditto.
3337 (gitdiff2svndiff): Added.
3339 2007-09-25 Adam Roben <aroben@apple.com>
3341 Pull advapi32.lib into WebKitInitializer
3343 This is needed to get the registry functions we use.
3345 Rubberstamped by Sam.
3347 * WebKitInitializer/WebKitInitializer.vcproj:
3349 2007-09-25 Adam Roben <aroben@apple.com>
3351 Add python and rsync to cygwin-downloader
3353 Our build slaves need this, and it can't hurt for everyone else to
3358 * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3359 * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3361 2007-09-25 Adam Roben <aroben@apple.com>
3363 Add WebKitInitializer and use it in DumpRenderTree
3365 WebKitInitializer is a static library that has one function,
3366 initializeWebKit(). This registers WebKit and sets up the DLL search
3367 path so that WebKit's dependencies that are installed with Safari can
3372 * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3373 DumpRenderTree depend on it.
3374 * DumpRenderTree/win/DumpRenderTree.cpp:
3375 (initialize): Call initializeWebKit.
3376 * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
3377 WebKitInitializer.lib.
3378 * WebKitInitializer/WebKitInitializer.cpp: Added.
3381 (getInstalledWebKitDirectory):
3383 * WebKitInitializer/WebKitInitializer.h: Added.
3384 * WebKitInitializer/WebKitInitializer.vcproj: Added.
3385 * WebKitInitializer/debug.vsprops: Added.
3386 * WebKitInitializer/release.vsprops: Added.
3388 2007-09-25 Adam Roben <aroben@apple.com>
3390 Make run-webkit-tests respect set-webkit-configuration
3394 * Scripts/run-webkit-tests: Initialize $configuration to whatever
3395 set-webkit-configuration was last set to.
3397 2007-09-25 Mark Rowe <mrowe@apple.com>
3399 Rubber-stamped by Eric.
3401 * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3402 This makes it possible to automate nightly builds for the feature-branch.
3404 2007-09-25 Adam Roben <aroben@apple.com>
3406 A couple of fixes/enhancements to update-webkit-*-libs
3408 You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
3409 to tell update-webkit-support-libraries where it should find the
3410 WebKitSupportLibrary.zip file you downloaded.
3412 These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
3417 * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
3418 to $auxiliaryLibsURL and removed an irrelevant comment.
3419 * Scripts/update-webkit-support-libs:
3421 2007-09-25 Adam Treat <treat@kde.org>
3423 Reviewed by Simon and Lars.
3425 Refactors and cleans up Qt DRT member variable names, member variable
3426 initialization, style fixes and general code cleanup.
3428 Adds queueReload slot to LayoutTestController that some tests require.
3430 Subclasses QWebFrame to make sure that all frames have an associated
3431 LayoutTestController JS window object.
3433 Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
3434 aren't dumped twice.
3438 Together, this patch fixes some 20+ layout tests in QtWebKit.
3440 * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3441 (WebCore::WebFrame::WebFrame):
3442 (WebCore::WebPage::WebPage):
3443 (WebCore::WebPage::createFrame):
3444 (WebCore::DumpRenderTree::DumpRenderTree):
3445 (WebCore::DumpRenderTree::open):
3446 (WebCore::DumpRenderTree::readStdin):
3447 (WebCore::DumpRenderTree::initJSObjects):
3448 (WebCore::DumpRenderTree::dump):
3449 * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3450 (WebCore::DumpRenderTree::layoutTestController):
3451 (WebCore::DumpRenderTree::eventSender):
3452 * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3453 (LayoutTestController::LayoutTestController):
3454 (LayoutTestController::reset):
3455 (LayoutTestController::maybeDump):
3456 (LayoutTestController::waitUntilDone):
3457 (LayoutTestController::notifyDone):
3458 (LayoutTestController::queueReload):
3459 (LayoutTestController::provisionalLoad):
3460 (EventSender::EventSender):
3461 (EventSender::mouseDown):
3462 (EventSender::mouseUp):
3463 (EventSender::mouseMoveTo):
3464 (EventSender::frameUnderMouse):
3465 * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3466 (LayoutTestController::isLoading):
3467 (LayoutTestController::setLoading):
3468 (LayoutTestController::dumpAsText):
3469 * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3472 2007-09-24 Kevin McCullough <kmccullough@apple.com>
3475 - Reverted an accidentally checked in file.
3477 * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3479 2007-09-24 Kevin McCullough <kmccullough@apple.com>
3482 - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
3484 * DumpRenderTree/win/DumpRenderTree.vcproj:
3485 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3487 2007-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
3489 Rubber stamped by Adam.
3491 * GdkLauncher: Removed.
3492 * GdkLauncher/Bakefiles.bkgen: Removed.
3493 * GdkLauncher/ENV: Removed.
3494 * GdkLauncher/GdkLauncher.pro: Removed.
3495 * GdkLauncher/gdklauncher.bkl: Removed.
3496 * GdkLauncher/main.cpp: Removed.
3497 * GdkLauncher/mk: Removed.
3498 * GdkLauncher/simple.svg: Removed.
3499 * GdkLauncher/text.html: Removed.
3500 * GtkLauncher: Added.
3501 * GtkLauncher/GdkLauncher.pro: Removed.
3502 * GtkLauncher/GtkLauncher.pro: Added.
3503 * GtkLauncher/main.cpp:
3504 (updateWindowTitle):
3506 * Scripts/build-webkit:
3507 * Scripts/regenerate-makefiles:
3508 * Scripts/run-javascriptcore-tests:
3509 * Scripts/run-launcher:
3510 * Scripts/run-webkit-tests:
3511 * Scripts/webkitdirs.pm:
3513 2007-09-21 Timothy Hatcher <timothy@apple.com>
3517 <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3519 Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
3520 This is tested by plugins/root-object-premature-delete-crash.html.
3522 * DumpRenderTree/mac/ObjCController.m:
3523 (-[ObjCController accessStoredWebScriptObject]):
3525 2007-09-21 Kevin McCullough <kmccullough@apple.com>
3529 - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
3531 * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3532 (FrameLoadDelegate::FrameLoadDelegate):
3534 2007-09-20 Julien Chaffraix <julien.chaffraix@gmail.com>
3538 Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
3539 webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
3541 Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
3542 Now isQt() and isGdk() use global variables that are only set once.
3544 An array of all the parameters is now given to build-dumprender which includes
3545 the platform on linux.
3547 * Scripts/build-dumprendertree:
3548 * Scripts/run-webkit-tests:
3549 * Scripts/webkitdirs.pm:
3551 2007-09-19 Adam Roben <aroben@apple.com>
3553 Rubberstamped by Hyatt.
3555 * Spinneret: Removed.
3557 2007-09-19 Tuukka Hastrup <Tuukka.Hastrup@iki.fi>
3559 Reviewed by David Kilzer.
3561 * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
3563 2007-09-18 Sam Weinig <sam@webkit.org>
3565 Add JSRetainPtr.h #include to fix some builds.
3567 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3569 2007-09-18 Mike Hommey <glandium@debian.org>
3573 * Scripts/prepare-ChangeLog:
3574 - Properly parse GECOS field.
3575 - Use git configuration for user name and email when appropriate.
3577 2007-09-17 Sam Weinig <sam@webkit.org>
3581 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3583 2007-09-17 Sam Weinig <sam@webkit.org>
3585 Reviewed by Adam Roben.
3587 Share more code between mac and windows DRT.
3588 - GCController is now shared.
3589 - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
3591 * DumpRenderTree/GCController.cpp:
3592 * DumpRenderTree/win/DumpRenderTree.cpp:
3593 * DumpRenderTree/win/DumpRenderTree.vcproj:
3594 * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
3595 (FrameLoadDelegate::FrameLoadDelegate):
3596 (FrameLoadDelegate::~FrameLoadDelegate):
3597 (FrameLoadDelegate::windowScriptObjectAvailable):
3598 * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
3599 * DumpRenderTree/win/GCController.cpp: Removed.
3600 * DumpRenderTree/win/GCController.h: Removed.
3601 * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
3602 (GCController::collect):
3603 (GCController::collectOnAlternateThread):
3604 (GCController::getJSObjectCount):
3605 * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
3606 * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
3608 2007-09-17 Sam Weinig <sam@webkit.org>
3610 Reviewed by Adam Roben.