2009-11-25 Zoltan Horvath <zoltan@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         Change run_command to give back stderr by default
6         https://bugs.webkit.org/show_bug.cgi?id=31734
7
8         Change run_command to give back stderr by default.
9         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
10         Change the related unittest call.
11
12         * Scripts/modules/scm.py:
13         * Scripts/modules/scm_unittest.py:
14
15 2009-11-25  Eric Seidel  <eric@webkit.org>
16
17         Reviewed by Adam Barth.
18
19         Centralize required argument parsing in Command
20         https://bugs.webkit.org/show_bug.cgi?id=31872
21
22         * Scripts/modules/commands/download.py: remove custom required arg message.
23         * Scripts/modules/commands/upload.py: ditto.
24         * Scripts/modules/multicommandtool.py:
25          - Add _parse_required_arguments.
26          - Pass program name off to OptionParser.
27          - Add name() for access to tool name.
28          - Add check_arguments_and_execute and make it return a return code.
29          - Replace a couple uses of + with %.
30         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
31
32 2009-11-25  Eric Seidel  <eric@webkit.org>
33
34         Reviewed by Adam Barth.
35
36         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
37         https://bugs.webkit.org/show_bug.cgi?id=31870
38
39         * Scripts/modules/commands/queries_unittest.py: Use the new class.
40         * Scripts/modules/multicommandtool_unittest.py: Ditto.
41         * Scripts/modules/outputcapture.py: Added.
42
43 2009-11-24  Dmitry Titov  <dimich@chromium.org>
44
45         Reviewed by Eric Seidel.
46
47         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
48         https://bugs.webkit.org/show_bug.cgi?id=31444
49
50         * Scripts/build-webkit:
51
52 2009-11-24  Chris Marrin  <cmarrin@apple.com>
53
54         Reviewed by Simon Fraser.
55
56         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
57         https://bugs.webkit.org/show_bug.cgi?id=27314
58         
59         Now the script allows the directories with these tests to be included on all
60         platforms but Mac, where they behave the same as always. For all other platforms
61         the tests need to be excluded using the Skipped files, which is currently done
62         for all platforms (including win since we're not turned on yet)
63
64         * Scripts/webkitdirs.pm:
65
66 2009-11-24  Eric Seidel  <eric@webkit.org>
67
68         Reviewed by Adam Barth.
69
70         queries_unittest.py should test command output
71         https://bugs.webkit.org/show_bug.cgi?id=31845
72
73         * Scripts/modules/commands/queries_unittest.py:
74          - Capture stdout and stderr and compare with expected strings.
75
76 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
77
78         No Review.
79
80         Fix spelling error ("depenedencies").
81
82         * Scripts/build-webkit:
83
84 2009-11-24  Mark Rowe  <mrowe@apple.com>
85
86         Land the configuration that includes the two debug GTK Linux builders.
87
88         * BuildSlaveSupport/build.webkit.org-config/config.json:
89
90 2009-11-24  David Kilzer  <ddkilzer@apple.com>
91
92         <http://webkit.org/b/31840> bisect-builds broke after r50080
93
94         Reviewed by Dan Bernstein.
95
96         * Scripts/bisect-builds:
97         (mountAndRunNightly): Switched back to using backticks to run
98         the hdiutil command since exec() will terminate the existing
99         script, which is not what we want.  Store the output of
100         File::Spec->devnull() in a variable for use in the hdiutil
101         detach commands.
102
103 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
104
105         Reviewed by Kenneth Rohde Christiansen.
106
107         Include "config.h" to meet Coding Style Guidelines
108         https://bugs.webkit.org/show_bug.cgi?id=31792
109
110         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
111         * DumpRenderTree/qt/jsobjects.cpp:
112         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
113
114 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
115
116         Reviewed by Oliver Hunt.
117
118         Implement new required function to pass test we used to pass. This
119         change is required since r51294.
120
121         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
122         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
123
124 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
125
126         Reviewed by Kenneth Rohde Christiansen.
127
128         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
129         https://bugs.webkit.org/show_bug.cgi?id=31775
130
131         LayoutTestController::dumpBackForwardList() should work with local URLs
132         as well as with normal URLs (in http tests for instance).
133         Currently it does not output the latter properly.
134
135         Unskip a bunch of passing http/navigation tests.
136
137         * DumpRenderTree/qt/DumpRenderTree.cpp:
138         (WebCore::dumpHistoryItem):
139
140 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
141
142         Reviewed by Oliver Hunt.
143
144         ARIA: support aria-flowto
145         https://bugs.webkit.org/show_bug.cgi?id=31762
146
147         * DumpRenderTree/AccessibilityUIElement.cpp:
148         (ariaFlowToElementAtIndexCallback):
149         (AccessibilityUIElement::getJSClass):
150         * DumpRenderTree/AccessibilityUIElement.h:
151         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
152         (AccessibilityUIElement::ariaFlowToElementAtIndex):
153         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
154         (AccessibilityUIElement::ariaFlowToElementAtIndex):
155         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
156         (AccessibilityUIElement::ariaFlowToElementAtIndex):
157
158 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
159
160         Reviewed by Kenneth Christiansen.
161
162         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
163         https://bugs.webkit.org/show_bug.cgi?id=31638
164
165         Unfreeze WorkQueue after each test execution.
166
167         * DumpRenderTree/qt/DumpRenderTree.cpp:
168         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
169
170 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
171
172         Reviewed by Adam Barth.
173
174         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
175         for localhost and 127.0.0.1.
176         https://bugs.webkit.org/show_bug.cgi?id=31783
177
178         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
179
180         * DumpRenderTree/qt/DumpRenderTree.cpp:
181         (WebCore::NetworkAccessManager::NetworkAccessManager):
182         (WebCore::NetworkAccessManager::sslErrorsEncountered):
183         (WebCore::WebPage::WebPage):
184         * DumpRenderTree/qt/DumpRenderTree.h:
185
186 2009-11-22  Chris Evans  <cevans@chromium.org>
187
188         Reviewed by Adam Barth.
189
190         Disable access to file:/// directory listings
191         https://bugs.webkit.org/show_bug.cgi?id=31329
192
193         Implemented setAllowUniversalAccessFromFileURLs to support testing of
194         file URL security.
195
196         * DumpRenderTree/LayoutTestController.cpp:
197         (setAllowUniversalAccessFromFileURLsCallback):
198         (LayoutTestController::staticFunctions):
199         * DumpRenderTree/LayoutTestController.h:
200         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
201         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
202         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
203         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
204         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
205         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
206         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
207         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
208
209 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
210
211         Reviewed by Kenneth Rohde Christiansen.
212
213         [Qt] Fix the timeout of fast/frames/frame-navigation.html
214         https://bugs.webkit.org/show_bug.cgi?id=31638
215
216         The test is timeouting, because it uses the WorkQueue to load a document in one
217         of the child frames and once the loading is finished, the DRT does not dump the
218         tree. This is because it waits for the QWebFrame::loadFinished() signal from
219         the main frame, while it should connect to QWebPage::loadFinished().
220
221         * DumpRenderTree/qt/DumpRenderTree.cpp:
222         (WebCore::DumpRenderTree::DumpRenderTree):
223
224 2009-11-21  Eric Seidel  <eric@webkit.org>
225
226         Reviewed by Adam Barth.
227
228         bugzilla-tool --help spews way too much text
229         https://bugs.webkit.org/show_bug.cgi?id=31771
230
231         * Scripts/bugzilla-tool:
232          - Remove self.cached_scm initialization hack.
233         * Scripts/modules/buildbot.py:
234          - Make default_host accessible to callers.
235         * Scripts/modules/commands/download.py:
236          - Phrase help for all commands consistently and remove spurious help text punctuation.
237         * Scripts/modules/commands/queries.py: Ditto.
238         * Scripts/modules/commands/queues.py: Ditto.
239         * Scripts/modules/commands/upload.py: Ditto.
240         * Scripts/modules/multicommandtool.py:
241          - Add HelpPrintingOptionParser.format_epilog to replace
242            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
243            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
244          - Make --help only show a list of commands like "svn help" and "git help" do --
245            previously --help was listing all commands and options.
246          - Sort list of commands alphabetically.
247
248 2009-11-21  Eric Seidel  <eric@webkit.org>
249
250         No review.  Fixing a typo from the previous patch for bug 31767.
251
252         AbstractQueue.run_bugzilla_tool throws an exception
253         https://bugs.webkit.org/show_bug.cgi?id=31769
254
255         * Scripts/modules/commands/queues.py:
256
257 2009-11-21  Eric Seidel  <eric@webkit.org>
258
259         Reviewed by Adam Barth.
260
261         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
262         https://bugs.webkit.org/show_bug.cgi?id=31767
263
264         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
265         Since we don't have a good way to test BugzillaTool pieces, I've
266         left out a test for now.
267
268         * Scripts/bugzilla-tool:
269          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
270         * Scripts/modules/commands/queues.py:
271          - Use tool.path() instead of __file__.
272         * Scripts/modules/multicommandtool.py:
273          - Add a new path() method to MultiComandTool.
274         * Scripts/modules/multicommandtool_unittest.py:
275          - Provide a path() method.  Little point in testing this mock implementation.
276
277 2009-11-21  Adam Barth  <abarth@webkit.org>
278
279         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
280         WebKitTools.
281
282         * Scripts/modules/commands/download.py:
283
284 2009-11-21  Adam Barth  <abarth@webkit.org>
285
286         Reviewed by Eric Seidel.
287
288         Convert check-style to use LandingSequence
289         https://bugs.webkit.org/show_bug.cgi?id=31763
290
291         Instead of manipulating the working copy by hand, we should use the
292         LandingSequence in CheckStyle.  This will make this code eaiser to
293         test.
294
295         * Scripts/modules/commands/download.py:
296
297 2009-11-20  Adam Barth  <abarth@webkit.org>
298
299         Reviewed by Eric Seidel.
300
301         Unit test query commands
302         https://bugs.webkit.org/show_bug.cgi?id=31755
303
304         These tests are pretty rough, but hopefully they'll grow.
305
306         * Scripts/modules/commands/queries_unittest.py: Added.
307         * Scripts/modules/mock_bugzillatool.py: Added.
308         * Scripts/run-webkit-unittests:
309
310 2009-11-20  Eric Seidel  <eric@webkit.org>
311
312         Reviewed by Adam Barth.
313
314         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
315         https://bugs.webkit.org/show_bug.cgi?id=31758
316
317         * Scripts/modules/multicommandtool.py:
318          - Allow passing of explicit commands to MultiCommandTool.__init__
319         * Scripts/modules/multicommandtool_unittest.py:
320          - Use new Command.name naming system.
321          - Test Command auto-discovery.
322         * Scripts/modules/workqueue.py:
323          - bug_id no longer exists, use patch['bug_id'] instead.
324         * Scripts/modules/workqueue_unittest.py:
325          - WorkQueues require names now.
326          - should_proceed_with_work_item must return a patch object.
327
328 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
329
330         Reviewed by Beth Dakin.
331
332         WAI-ARIA: add support for aria-owns
333         https://bugs.webkit.org/show_bug.cgi?id=31702
334
335         * DumpRenderTree/AccessibilityUIElement.cpp:
336         (ariaOwnsElementAtIndexCallback):
337         (AccessibilityUIElement::getJSClass):
338         * DumpRenderTree/AccessibilityUIElement.h:
339         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
340         (AccessibilityUIElement::ariaOwnsElementAtIndex):
341         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
342         (AccessibilityUIElement::ariaOwnsElementAtIndex):
343         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
344         (AccessibilityUIElement::ariaOwnsElementAtIndex):
345
346 2009-11-20  Eric Seidel  <eric@webkit.org>
347
348         Reviewed by Adam Barth.
349
350         Fix exception thrown when running the commit-queue.
351
352         * Scripts/modules/statusbot.py: patch is optional.
353         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
354
355 2009-11-20  Eric Seidel  <eric@webkit.org>
356
357         Reviewed by Adam Barth.
358
359         Teach the StatusBot how to support more than just the commit-queue
360         https://bugs.webkit.org/show_bug.cgi?id=31754
361
362         * Scripts/modules/workqueue.py: Another typo.
363
364 2009-11-20  Eric Seidel  <eric@webkit.org>
365
366         Reviewed by Adam Barth.
367
368         Teach the StatusBot how to support more than just the commit-queue
369         https://bugs.webkit.org/show_bug.cgi?id=31754
370
371         * Scripts/modules/commands/queues.py: Fix silly typo.
372
373 2009-11-20  Eric Seidel  <eric@webkit.org>
374
375         Reviewed by Adam Barth.
376
377         Teach the StatusBot how to support more than just the commit-queue
378         https://bugs.webkit.org/show_bug.cgi?id=31754
379
380         * CommitQueueStatus/index.yaml:
381          - Add indices required for the new queries.
382         * CommitQueueStatus/queue_status.py:
383          - Add a patch-status page and move update_status to update-status.
384          - Only display "commit-queue" status records for the commit-queue.
385          - Add support for a queue_name property on status records.
386          - Fix _int_from_request to actually work.
387         * CommitQueueStatus/update_status.html:
388          - Add support for a queue_name on status records.
389          - Remove unused list of bug ids.
390          * Scripts/modules/commands/queues.py
391           - Make the queues pass the patch instead of the bug_id to StatusBot.
392         * Scripts/modules/statusbot.py:
393          - Support passing the queue_name to the status updates.
394          - Support fetching patch status with patch_status().
395         * Scripts/modules/workqueue.py:
396          - Pass the patch to the StatusBot instead of the bug_id.
397          - Let WorkQueues have a name.
398
399 2009-11-20  Adam Barth  <abarth@webkit.org>
400
401         Reviewed by Eric Seidel.
402
403         Move bugzilla-tool commands into their own file
404         https://bugs.webkit.org/show_bug.cgi?id=31752
405
406         This will let us write unit tests.
407
408         * Scripts/bugzilla-tool:
409         * Scripts/modules/commands/__init__.py: Added.
410         * Scripts/modules/commands/download.py: Added.
411         * Scripts/modules/commands/queries.py: Added.
412         * Scripts/modules/commands/queues.py: Added.
413         * Scripts/modules/commands/upload.py: Added.
414         * Scripts/modules/grammar.py: Added.
415
416 2009-11-20  Adam Barth  <abarth@webkit.org>
417
418         Reviewed by Eric Seidel.
419
420         BuildQueue should check if the tree is currently buildable
421         https://bugs.webkit.org/show_bug.cgi?id=31744
422
423         * Scripts/bugzilla-tool:
424         * Scripts/modules/landingsequence.py:
425         * Scripts/modules/webkitlandingscripts.py:
426
427 2009-11-20  Adam Barth  <abarth@webkit.org>
428
429         Reviewed by Eric Seidel.
430
431         Move prepare_clean_working_directory into the LandingSequence
432         https://bugs.webkit.org/show_bug.cgi?id=31743
433
434         * Scripts/bugzilla-tool:
435         * Scripts/modules/landingsequence.py:
436
437 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
438
439         Reviewed by Kenneth Rohde Christiansen.
440
441         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
442         https://bugs.webkit.org/show_bug.cgi?id=30460
443
444         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
445
446         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
447         (pluginInvoke):
448
449 2009-11-20  Adam Barth  <abarth@webkit.org>
450
451         Reviewed by Eric Seidel.
452
453         Pass the port information to the child process
454         https://bugs.webkit.org/show_bug.cgi?id=31736
455
456         We need to do this so the child process knows what to build!
457
458         * Scripts/bugzilla-tool:
459         * Scripts/modules/landingsequence.py:
460         * Scripts/modules/webkitport.py:
461         * Scripts/modules/webkitport_unittest.py:
462
463 2009-11-20  Adam Barth  <abarth@webkit.org>
464
465         Reviewed by Eric Seidel.
466
467         Support Qt port in build-queue
468         https://bugs.webkit.org/show_bug.cgi?id=31733
469
470         * Scripts/bugzilla-tool:
471
472 2009-11-20  Adam Barth  <abarth@webkit.org>
473
474         Reviewed by Eric Seidel.
475
476         Implement a build-queue
477         https://bugs.webkit.org/show_bug.cgi?id=31725
478
479         Currently this just builds the first 10 patches in the review queue.
480         We'll want to do something smarter soon.
481
482         * Scripts/bugzilla-tool:
483
484 2009-11-20  Adam Barth  <abarth@webkit.org>
485
486         Reviewed by Eric Seidel.
487
488         Make commit-queue and style-queue show up in help
489         https://bugs.webkit.org/show_bug.cgi?id=31724
490
491         We need to store their names on their class to make these commands
492         properly register themselves with MultiCommandTool.
493
494         * Scripts/bugzilla-tool:
495
496 2009-11-20  Adam Barth  <abarth@webkit.org>
497
498         Reviewed by Eric Seidel.
499
500         Implement bugzilla-tool build-attachment
501         https://bugs.webkit.org/show_bug.cgi?id=31722
502
503         This command builds an attachment from bugzilla.  It leaves the built
504         patch in the working copy.
505
506         * Scripts/bugzilla-tool:
507         * Scripts/modules/landingsequence.py:
508         * Scripts/modules/webkitlandingscripts.py:
509
510 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
511
512         Reviewed by Xan Lopez.
513
514         [GTK] DRT release event does not create the state correctly
515         https://bugs.webkit.org/show_bug.cgi?id=31717
516
517         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
518
519 2009-11-20  Eric Seidel  <eric@webkit.org>
520
521         Reviewed by Adam Barth.
522
523         MultiCommandTool should find Command objects automatically instead of with a manual list
524         https://bugs.webkit.org/show_bug.cgi?id=31710
525
526         * Scripts/bugzilla-tool:
527         * Scripts/modules/multicommandtool.py:
528          - Use some wild python-fu to crawl all the known subclasses of Command.
529
530 2009-11-20  Adam Barth  <abarth@webkit.org>
531
532         Unreviewed "build" fix.  Added missing import.
533
534         * Scripts/bugzilla-tool:
535
536 2009-11-20  Adam Barth  <abarth@webkit.org>
537
538         Unreviewed "build" fix.  I failed to update LandingSequence.test
539         properly.
540
541         * Scripts/modules/landingsequence.py:
542
543 2009-11-20  Adam Barth  <abarth@webkit.org>
544
545         Reviewed by Eric Seidel.
546
547         Create LandingSequence as the all-sing, all-dance landing class
548         https://bugs.webkit.org/show_bug.cgi?id=31709
549
550         Client can inherit from this class to carefully control exactly which
551         steps they wish to have happen in the landing sequence.
552
553         * Scripts/bugzilla-tool:
554         * Scripts/modules/landingsequence.py: Added.
555         * Scripts/modules/webkitlandingscripts.py: Added.
556
557 2009-11-19  Adam Barth  <abarth@webkit.org>
558
559         Reviewed by Eric Seidel.
560
561         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
562         https://bugs.webkit.org/show_bug.cgi?id=31707
563
564         This is to help when we implement build-attachment.
565
566         * Scripts/bugzilla-tool:
567
568 2009-11-19  Adam Barth  <abarth@webkit.org>
569
570         Reviewed by Eric Seidel.
571
572         Support Qt port in bugzilla-tool
573         https://bugs.webkit.org/show_bug.cgi?id=31701
574
575         Now we support building with Qt!
576
577         * Scripts/bugzilla-tool:
578         * Scripts/modules/webkitport.py: Added.
579         * Scripts/modules/webkitport_unittest.py: Added.
580         * Scripts/run-webkit-unittests:
581
582 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
583
584         Reviewed by Adam Barth.
585
586         Remove inserting stderr into patch in bugzilla-tool
587         https://bugs.webkit.org/show_bug.cgi?id=29914
588
589         Modify SCM python module's run_command function to avoid return of stderr
590         by default, so stderr won't be inserted into the patches.
591         Modify the related unit test.
592
593         * Scripts/modules/scm.py:
594         * Scripts/modules/scm_unittest.py:
595
596 2009-11-19  Eric Seidel  <eric@webkit.org>
597
598         Reviewed by Adam Barth.
599
600         bugzilla-tool needs per-command help
601         https://bugs.webkit.org/show_bug.cgi?id=31697
602
603         Added support for "bugzilla-tool help command-name"
604         and a unit test to make sure it works.
605
606         * Scripts/modules/multicommandtool.py:
607         * Scripts/modules/multicommandtool_unittest.py:
608
609 2009-11-19  Eric Seidel  <eric@webkit.org>
610
611         Reviewed by Adam Barth.
612
613         Move MultiCommandTool and Command into a separate file and add some basic unit tests
614         https://bugs.webkit.org/show_bug.cgi?id=31695
615
616         * Scripts/bugzilla-tool:
617         * Scripts/modules/multicommandtool.py: Added.
618         * Scripts/modules/multicommandtool_unittest.py: Added.
619         * Scripts/run-webkit-unittests:
620
621 2009-11-19  Eric Seidel  <eric@webkit.org>
622
623         No review, just adding a FIXME.
624
625         Split out command parsing and help printing from BugzillaTool
626         https://bugs.webkit.org/show_bug.cgi?id=31688
627
628         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
629
630 2009-11-19  Eric Seidel  <eric@webkit.org>
631
632         Reviewed by Adam Barth.
633
634         Split out command parsing and help printing from BugzillaTool
635         https://bugs.webkit.org/show_bug.cgi?id=31688
636
637         * Scripts/bugzilla-tool:
638          - Add new MultiCommandTool class to contain option parsing and help printing logic.
639          - Rename private methods to use _ pattern.
640          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
641          - 
642
643 2009-11-19  Eric Seidel  <eric@webkit.org>
644
645         Reviewed by Adam Barth.
646
647         Re-factor help printing to use modern python idioms
648         https://bugs.webkit.org/show_bug.cgi?id=31685
649
650         * Scripts/bugzilla-tool:
651
652 2009-11-19  Eric Seidel  <eric@webkit.org>
653
654         Reviewed by Darin Adler.
655
656         commit-queue empty queue logs twice
657         https://bugs.webkit.org/show_bug.cgi?id=31679
658
659         * Scripts/bugzilla-tool:
660
661 2009-11-19  Eric Seidel  <eric@webkit.org>
662
663         Reviewed by Darin Adler.
664
665         bugzilla-tool's reviewer/committer rejection message should be clearer
666         https://bugs.webkit.org/show_bug.cgi?id=31126
667
668         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
669
670         * Scripts/modules/bugzilla.py:
671
672 2009-11-19  Eric Z. Ayers  <zundel@google.com>
673
674         Reviewed by Pavel Feldman.
675
676         Forces a WM_PAINT event on calling layoutTestController.display()
677         in order to enable the timeline-paint.html test on Windows.
678         ::UpdateWindow() does not force an event becaue the window is 
679         not visible.
680
681         https://bugs.webkit.org/show_bug.cgi?id=31402
682
683         * DumpRenderTree/win/DumpRenderTree.cpp:
684         (displayWebView):
685
686 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
687
688         No review needed.
689
690         Added myself to committers list.
691
692         * Scripts/modules/committers.py:
693
694 2009-11-19  Adam Barth  <abarth@webkit.org>
695
696         Reviewed by Eric Seidel.
697
698         Bugzilla-tool command classes should match command names
699         https://bugs.webkit.org/show_bug.cgi?id=31666
700
701         I renamed all the commands except CommitMessageForCurrentDiff because
702         the new name would conflict with an existing class.
703
704         * Scripts/bugzilla-tool:
705
706 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
707
708         Reviewed by Gustavo Noronha Silva.
709
710         Web Inspector: Implement "show inspector" in WebKit GTK
711         API and enable console tests.
712
713         https://bugs.webkit.org/show_bug.cgi?id=31669
714
715         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
716         (LayoutTestController::showWebInspector):
717
718 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
719
720         Reviewed by Simon Hausmann.
721
722         Minor refactoring + more documentation.
723
724         * DumpRenderTree/qt/DumpRenderTree.cpp:
725         (WebCore::clearHistory):
726         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
727
728 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
729
730         Reviewed by Eric Seidel.
731
732         Ignore websocket tests when --no-http is specified.
733         https://bugs.webkit.org/show_bug.cgi?id=31662
734
735         * Scripts/run-webkit-tests:
736
737 2009-11-18  Adam Barth  <abarth@webkit.org>
738
739         Reviewed by Eric Seidel.
740
741         Normalize ' and " in bugzilla-tool
742         https://bugs.webkit.org/show_bug.cgi?id=31655
743
744         We decided " is better than ' and we should be consistent.
745
746         * Scripts/bugzilla-tool:
747
748 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
749
750         Reviewed by Kenneth Rohde Christiansen.
751
752         [Qt] Remove support for Qt v4.3 or older versions
753         https://bugs.webkit.org/show_bug.cgi?id=29469
754
755         * DumpRenderTree/qt/DumpRenderTree.pro:
756         * DumpRenderTree/qt/ImageDiff.pro:
757
758 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
759
760         Reviewed by Eric Seidel.
761
762         GitTest.test_create_binary_patch fails if /tmp is symlink
763         https://bugs.webkit.org/show_bug.cgi?id=31536
764
765         * Scripts/modules/scm_unittest.py:
766
767 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
768
769         Reviewed by Darin Adler.
770
771         Configuration for Chromium Build Slaves.
772
773         https://bugs.webkit.org/show_bug.cgi?id=31442
774
775         * BuildSlaveSupport/build.webkit.org-config/config.json:
776         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
777
778 2009-11-18  Eric Seidel  <eric@webkit.org>
779
780         Reviewed by Darin Adler.
781
782         workqueue.py results in totally broken commit-queue UI
783         https://bugs.webkit.org/show_bug.cgi?id=31645
784
785         * Scripts/bugzilla-tool:
786          - Remove unneeded use of PatchCollection.
787          - Grab a new copy of the cq'd patches every run of the queue.
788
789 2009-11-18  Sam Weinig  <sam@webkit.org>
790
791         Reviewed by Anders Carlsson.
792
793         Make the Mac Geolocation API async.
794
795         Update DRT to use the new async Mac Geolocation API.
796
797         * DumpRenderTree/mac/UIDelegate.mm:
798         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
799
800 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
801
802         Reviewed by Kenneth Rohde Christiansen.
803
804         Add and option to toggle HTML5 datalist support to build-webkit
805         https://bugs.webkit.org/show_bug.cgi?id=31599
806
807         * Scripts/build-webkit:
808
809 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
810
811         Reviewed by Kevin Ollivier.
812
813         Enable wx plugin support using the Windows implementation as a base.
814         
815         https://bugs.webkit.org/show_bug.cgi?id=31636
816
817         * wx/build/settings.py:
818
819 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
820
821         Reviewed by Simon Hausmann.
822
823         Change the initialization order so that the controllers
824         will be created before exporting them to the JS DOM window.
825
826         * DumpRenderTree/qt/DumpRenderTree.cpp:
827         (WebCore::DumpRenderTree::DumpRenderTree):
828
829 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
830
831         Reviewed by Simon Hausmann.
832
833         Fix a code copy and paste error. m_page should be page.
834
835         * DumpRenderTree/qt/DumpRenderTree.cpp:
836         (WebCore::DumpRenderTree::createWindow):
837
838 2009-11-17  Mark Rowe  <mrowe@apple.com>
839
840         Reviewed by Alexey Proskuryakov.
841
842         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
843
844         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
845         This prevents symlinks from confusing the descendant check.
846
847 2009-11-17  Mark Rowe  <mrowe@apple.com>
848
849         Reviewed by Alexey Proskuryakov.
850
851         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
852
853         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
854         server to be up rather than having run-webkit-tests abort immediately.
855
856         * Scripts/run-webkit-tests:
857
858 2009-11-17  Eric Seidel  <eric@webkit.org>
859
860         Reviewed by Darin Adler.
861
862         commit-queue is failing to set reviewer in ChangeLogs
863         https://bugs.webkit.org/show_bug.cgi?id=31592
864
865         * Scripts/bugzilla-tool: Clarify the "applying" log message.
866         * Scripts/modules/bugzilla.py:
867          - Add a new _validate_committer_and_reviewer function as a
868            temporary solution until we can make a real Attachment object
869            which knows how to fill in its committer/reviewer fields automatically.
870
871 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
872
873         Unreviewed buildbot fix.
874
875         Revert part of earlier patch and add comment, as it
876         was causing timeouts on the buildbot.
877
878         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
879         (LayoutTestController::notifyDone):
880
881 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
882
883         Reviewed by Oliver Hunt.
884
885         Make the timeout 15 sec as for the other DRT's and make
886         it print out the same output when a test timeout.
887
888         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
889         (LayoutTestController::waitUntilDone):
890         (LayoutTestController::notifyDone):
891         (LayoutTestController::timerEvent):
892
893 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
894
895         Reviewed by Timothy Hatcher.
896
897         Fixed typos in comments.
898
899         * Scripts/modules/committers.py:
900
901 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
902
903         Reviewed by Timothy Hatcher.
904
905         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
906         - Updated DRT to show/close inspector for all tests under /inspector
907         - Introduced LayoutTestController::setTimelineProfilingEnabled and
908           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
909         - Removed reload on each inspector test
910         - Renamed fast/inspector to fast/inspector-support in order not to trigger
911         inspector for those.
912         - Reimplemented timeline tests in order to get rid of reload there.
913         - Moved tests that don't require harness into the fast group.
914
915         https://bugs.webkit.org/show_bug.cgi?id=31472
916
917         * DumpRenderTree/LayoutTestController.cpp:
918         (setTimelineProfilingEnabledCallback):
919         (closeWebInspectorCallback):
920         (LayoutTestController::staticFunctions):
921         * DumpRenderTree/LayoutTestController.h:
922         * DumpRenderTree/gtk/DumpRenderTree.cpp:
923         (shouldOpenWebInspector):
924         (runTest):
925         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
926         (LayoutTestController::setTimelineProfilingEnabled):
927         * DumpRenderTree/mac/DumpRenderTree.mm:
928         (shouldOpenWebInspector):
929         (runTest):
930         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
931         (LayoutTestController::setTimelineProfilingEnabled):
932         * DumpRenderTree/win/DumpRenderTree.cpp:
933         (shouldOpenWebInspector):
934         (runTest):
935         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
936         (LayoutTestController::setTimelineProfilingEnabled):
937
938 2009-11-17  Oliver Hunt  <oliver@apple.com>
939
940         Reviewed by Maciej Stachowiak.
941
942         Incorrect use of JavaScriptCore API in DumpRenderTree
943         https://bugs.webkit.org/show_bug.cgi?id=31577
944
945         Return undefined rather than a literal null.
946
947         * DumpRenderTree/AccessibilityUIElement.cpp:
948         (setSelectedTextRangeCallback):
949         (incrementCallback):
950         (decrementCallback):
951         (showMenuCallback):
952
953 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
954
955         Reviewed by Beth Dakin.
956
957         AX: aria-labelledby duplicates some of its WAI-ARIA label
958         https://bugs.webkit.org/show_bug.cgi?id=31565
959
960         * DumpRenderTree/AccessibilityUIElement.cpp:
961         (titleUIElementCallback):
962         (getIsValidCallback):
963         (AccessibilityUIElement::getJSClass):
964
965 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
966
967         Reviewed by Simon Hausmann.
968
969         r50942 broke output from created windows. Make the
970         m_enableTextOutput a member of the DRT and not the
971         WebPage.
972
973         * DumpRenderTree/qt/DumpRenderTree.cpp:
974         (WebCore::WebPage::WebPage):
975         (WebCore::WebPage::javaScriptAlert):
976         (WebCore::WebPage::javaScriptConsoleMessage):
977         (WebCore::WebPage::javaScriptConfirm):
978         (WebCore::WebPage::javaScriptPrompt):
979         (WebCore::WebPage::acceptNavigationRequest):
980         (WebCore::DumpRenderTree::DumpRenderTree):
981         (WebCore::DumpRenderTree::open):
982         (WebCore::DumpRenderTree::createWindow):
983         * DumpRenderTree/qt/DumpRenderTree.h:
984         (WebCore::DumpRenderTree::setTextOutputEnabled):
985         (WebCore::DumpRenderTree::isTextOutputEnabled):
986         (WebCore::WebPage::shouldInterruptJavaScript):
987         (WebCore::WebPage::isTextOutputEnabled):
988         (WebCore::WebPage::setViewGeometry):
989
990 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
991
992         Reviewed by Gustavo Noronha Silva.
993
994         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
995         as the implementation is being used by at least Qt and Gtk+.
996
997         Update buildsystems as well.
998
999         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1000         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1001         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1002         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1003         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1004         * GNUmakefile.am:
1005
1006 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1007
1008         Reviewed by Alexey Proskuryakov.
1009
1010         Disable wss until all platforms support pyOpenSSL
1011
1012         https://bugs.webkit.org/show_bug.cgi?id=31479
1013
1014         * Scripts/run-webkit-tests:
1015
1016 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1017
1018         Reviewed by Kenneth Christiansen.
1019
1020         [Qt] Implement load error pages support for Qt's DRT.
1021         https://bugs.webkit.org/show_bug.cgi?id=31509
1022
1023         For now, it will not be a default feature, and layout tests
1024         that want to make use of this have to explicitily call
1025         'handleErrorPages();' for the test source.
1026
1027         Any of the other DumpRenderTree's (mac, win and gtk)
1028         support handling error pages. Qt's will be the first.
1029
1030         * DumpRenderTree/qt/DumpRenderTree.cpp:
1031         (WebCore::WebPage::supportsExtension):
1032         (WebCore::WebPage::extension):
1033         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1034         (LayoutTestController::reset):
1035         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1036         (LayoutTestController::shouldHandleErrorPages):
1037         (LayoutTestController::handleErrorPages):
1038
1039 2009-11-16  Eric Seidel  <eric@webkit.org>
1040
1041         Reviewed by Adam Barth.
1042
1043         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1044         https://bugs.webkit.org/show_bug.cgi?id=31549
1045
1046         Renamed --commit-queue to --non-interactive in most places
1047         and remove the code in land-patches which is no longer needed.
1048
1049         * Scripts/bugzilla-tool:
1050
1051 2009-11-16  Eric Seidel  <eric@webkit.org>
1052
1053         Reviewed by Adam Barth.
1054
1055         The commit-queue should use land-attachment
1056         https://bugs.webkit.org/show_bug.cgi?id=31548
1057
1058         * Scripts/bugzilla-tool:
1059
1060 2009-11-16  Adam Barth  <abarth@webkit.org>
1061
1062         Reviewed by Eric Seidel.
1063
1064         Convert CommitQueue over to PatchCollection
1065         https://bugs.webkit.org/show_bug.cgi?id=31547
1066
1067         Also fixes a bug in workqueue and adds a test!
1068
1069         * Scripts/bugzilla-tool:
1070         * Scripts/modules/workqueue.py:
1071         * Scripts/modules/workqueue_unittest.py:
1072
1073 2009-11-16  Adam Barth  <abarth@webkit.org>
1074
1075         Reviewed by Eric Seidel.
1076
1077         Move StyleQueue over to using PatchCollection
1078         https://bugs.webkit.org/show_bug.cgi?id=31544
1079
1080         That's what the class it's for.
1081
1082         * Scripts/bugzilla-tool:
1083         * Scripts/modules/patchcollection.py:
1084         * Scripts/modules/patchcollection_unittest.py:
1085
1086 2009-11-16  Eric Seidel  <eric@webkit.org>
1087
1088         Reviewed by Adam Barth.
1089
1090         bugzilla-tool needs a land-attachment command
1091         https://bugs.webkit.org/show_bug.cgi?id=31546
1092
1093         * Scripts/bugzilla-tool:
1094          - Move all the logic into AbstractLandingCommand and
1095            add a new LandAttachment command subclass.
1096          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1097
1098 2009-11-16  Eric Seidel  <eric@webkit.org>
1099
1100         Reviewed by Adam Barth.
1101
1102         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1103         https://bugs.webkit.org/show_bug.cgi?id=31543
1104
1105         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1106
1107         * Scripts/bugzilla-tool:
1108
1109 2009-11-16  Eric Seidel  <eric@webkit.org>
1110
1111         Reviewed by Adam Barth.
1112
1113         Disable the style queue from posting to the commit queue status page.
1114
1115         * Scripts/bugzilla-tool:
1116
1117 2009-11-16  Adam Barth  <abarth@webkit.org>
1118
1119         Reviewed by Eric Seidel.
1120
1121         Implement PatchCollection
1122         https://bugs.webkit.org/show_bug.cgi?id=31541
1123
1124         This class holds a set of patches and lets clients iterate through
1125         them.  Optionally, clients can install a filter.
1126
1127         * Scripts/modules/patchcollection.py: Added.
1128         * Scripts/modules/patchcollection_unittest.py: Added.
1129         * Scripts/run-webkit-unittests:
1130
1131 2009-11-16  Eric Seidel  <eric@webkit.org>
1132
1133         Reviewed by Adam Barth.
1134
1135         bugzilla-tool land-patches will close bugs with patches r=?
1136         https://bugs.webkit.org/show_bug.cgi?id=28230
1137
1138         The commit-queue shouldn't close patches with outstanding reviews on them,
1139         even if many reviewers seem to be against multi-patch bugs.
1140
1141         * Scripts/bugzilla-tool:
1142
1143 2009-11-16  Eric Seidel  <eric@webkit.org>
1144
1145         Reviewed by Adam Barth.
1146
1147         bugzilla-tool check-style should work with attachment ids instead of bug ids
1148         https://bugs.webkit.org/show_bug.cgi?id=31540
1149
1150         * Scripts/bugzilla-tool:
1151
1152 2009-11-16  Eric Seidel  <eric@webkit.org>
1153
1154         Reviewed by Adam Barth.
1155
1156         WorkQueue is the only place that should know about special exit codes
1157         https://bugs.webkit.org/show_bug.cgi?id=31534
1158
1159         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1160         and add tests for handling exit codes.
1161         I also cleaned up workqueue_unittest.py more.
1162
1163         * Scripts/bugzilla-tool:
1164         * Scripts/modules/workqueue.py:
1165         * Scripts/modules/workqueue_unittest.py:
1166
1167 2009-11-16  Eric Seidel  <eric@webkit.org>
1168
1169         Reviewed by Adam Barth.
1170
1171         Re-factor workqueue_unittest to allow for more than one test.
1172         https://bugs.webkit.org/show_bug.cgi?id=31535
1173
1174         * Scripts/modules/workqueue_unittest.py:
1175
1176 2009-11-16  Eric Seidel  <eric@webkit.org>
1177
1178         Reviewed by Adam Barth.
1179
1180         land-patches needs to be re-factored into smaller chunks
1181         https://bugs.webkit.org/show_bug.cgi?id=31532
1182
1183         * Scripts/bugzilla-tool: fix a couple obvious typos.
1184
1185 2009-11-16  Eric Seidel  <eric@webkit.org>
1186
1187         Reviewed by Adam Barth.
1188
1189         land-patches needs to be re-factored into smaller chunks
1190         https://bugs.webkit.org/show_bug.cgi?id=31532
1191
1192         The next patch will move these methods into WebKitLandingScripts.
1193
1194         * Scripts/bugzilla-tool:
1195          - Split out _land_patch and _close_bug_if_no_active_patches.
1196
1197 2009-11-16  Adam Barth  <abarth@webkit.org>
1198
1199         Reviewed by Eric Seidel.
1200
1201         Fix silly copy-and-paste code.  I am a terrible coder.
1202
1203         * Scripts/modules/bugzilla.py:
1204
1205 2009-11-16  Adam Barth  <abarth@webkit.org>
1206
1207         Reviewed by Eric Seidel.
1208
1209         Implement a StyleQueue
1210         https://bugs.webkit.org/show_bug.cgi?id=31537
1211
1212         The first iteration of the style queue only produces output locally.
1213         There is also a limit of 10 patches because it's not that useful to
1214         iterate through the entire review queue at this point.  We can remove
1215         the limit later.
1216
1217         * Scripts/bugzilla-tool:
1218         * Scripts/modules/bugzilla.py:
1219
1220 2009-11-16  Adam Barth  <abarth@webkit.org>
1221
1222         Reviewed by Eric Seidel.
1223
1224         Unit test WorkQueue
1225         https://bugs.webkit.org/show_bug.cgi?id=31531
1226
1227         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1228
1229         * Scripts/bugzilla-tool:
1230         * Scripts/modules/statusbot.py:
1231         * Scripts/modules/workqueue.py:
1232         * Scripts/modules/workqueue_unittest.py: Added.
1233         * Scripts/run-webkit-unittests:
1234
1235 2009-11-16  Eric Seidel  <eric@webkit.org>
1236
1237         Reviewed by Adam Barth.
1238
1239         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1240         https://bugs.webkit.org/show_bug.cgi?id=31530
1241
1242         * Scripts/bugzilla-tool:
1243
1244 2009-11-16  Eric Seidel  <eric@webkit.org>
1245
1246         Reviewed by Adam Barth.
1247
1248         bugzilla-tool needs apply-attachment
1249         https://bugs.webkit.org/show_bug.cgi?id=31528
1250
1251         * Scripts/bugzilla-tool:
1252          - Add ApplyAttachment command.
1253          - Abstract applying code into WebKitApplyingScripts.
1254          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1255         * Scripts/modules/bugzilla.py:
1256          - Add fetch_attachment and bug_id_for_attachment_id.
1257         * Scripts/modules/bugzilla_unittest.py:
1258          - Add test for new parsing.
1259          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1260
1261 2009-11-16  Eric Seidel  <eric@webkit.org>
1262
1263         Reviewed by Adam Barth.
1264
1265         Document check-style's use of force_clean.
1266
1267         * Scripts/bugzilla-tool:
1268         * Scripts/modules/scm.py:
1269
1270 2009-11-16  Adam Barth  <abarth@webkit.org>
1271
1272         Reviewed by Eric Seidel.
1273
1274         Move WorkQueue to its own file
1275         https://bugs.webkit.org/show_bug.cgi?id=31529
1276
1277         WorkQueue and WorkQueueDelegate are separate concerns from
1278         bugzilla-tool.  Also added a missing include to logging.py.
1279
1280         * Scripts/bugzilla-tool:
1281         * Scripts/modules/logging.py:
1282         * Scripts/modules/workqueue.py:
1283
1284 2009-11-16  Adam Barth  <abarth@webkit.org>
1285
1286         Reviewed by Eric Seidel.
1287
1288         Move OutputTee to logging.py.
1289
1290         * Scripts/bugzilla-tool:
1291         * Scripts/modules/logging.py:
1292
1293 2009-11-15  Adam Barth  <abarth@webkit.org>
1294
1295         Reviewed by Eric Seidel.
1296
1297         Refactor bugzilla-tool to allow for multiple queues
1298         https://bugs.webkit.org/show_bug.cgi?id=31513
1299
1300         Divide the commit queue class into three class to make creating
1301         additional queues easier.
1302
1303         * Scripts/bugzilla-tool:
1304
1305 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1306
1307         Reviewed by Eric Seidel.
1308
1309         svn-apply may not handle git patches created by bugzilla-tool
1310         https://bugs.webkit.org/show_bug.cgi?id=31457
1311
1312         * Scripts/modules/scm.py:
1313         * Scripts/modules/scm_unittest.py:
1314
1315 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1316
1317         Reviewed by Eric Seidel.
1318
1319         bugzilla-tool should post git binary diff
1320         https://bugs.webkit.org/show_bug.cgi?id=31458
1321
1322         Add --binary option to Git.create_patch.
1323
1324         * Scripts/modules/scm.py:
1325         * Scripts/modules/scm_unittest.py:
1326
1327 2009-11-15  Adam Barth  <abarth@webkit.org>
1328
1329         Reviewed by Darin Adler.
1330
1331         Add bugzilla-tool check-style
1332         https://bugs.webkit.org/show_bug.cgi?id=31515
1333
1334         * Scripts/bugzilla-tool:
1335         * Scripts/modules/bugzilla.py:
1336
1337 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1338
1339         Reviewed by Simon Hausmann.
1340
1341         Make the Qt Linux only --valgrind feature, suppress errors
1342         defined in the SuppressedValgrindErrors file.
1343
1344         * Scripts/run-webkit-tests:
1345
1346 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1347
1348         Reviewed by Simon Hausmann.
1349
1350         Set the locale to C and not to the current one in use on the system.
1351
1352         * DumpRenderTree/qt/DumpRenderTree.cpp:
1353         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1354
1355 2009-11-13  Adam Roben  <aroben@apple.com>
1356
1357         Add support for
1358         http/tests/security/isolatedWorld/didClearWindowObject.html
1359
1360         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1361         window objects in isolated worlds are cleared
1362
1363         Reviewed by Dave Hyatt.
1364
1365         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1366
1367         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1368         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1369         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1370         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1371         Added. Sets a __worldID property on the global object whose value is
1372         the ID of this world.
1373         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1374         Respond to this new delegate callback by calling through to one of the
1375         above new methods.
1376         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1377         (worldMap): Added. Returns a HashMap containing all the worlds we've
1378         created.
1379         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1380         haven't kept track of this world.
1381         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1382         instead of declaring our own.
1383
1384         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1385
1386         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1387         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1388         didClearWindowObjectForFrameInStandardWorld.
1389         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1390         Respond to this new delegate callback by calling through to one of the
1391         below new methods.
1392         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1393         Added. Sets a __worldID property on the gobal object whose value is
1394         the ID of this world.
1395         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1396         Added. Moved code here from didClearWindowObject.
1397
1398         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1399         didClearWindowObjectForFrame* functions.
1400
1401         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1402         (worldMap): Added. Returns a HashMap containing all the worlds we've
1403         created.
1404         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1405         haven't kept track of this world.
1406         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1407         instead of declaring our own.
1408
1409 2009-11-13  Adam Roben  <aroben@apple.com>
1410
1411         Finish replacing worldIDs with world objects
1412
1413         The only remaining use of worldIDs was in a method only used by DRT
1414         for the isolated worlds tests.
1415
1416         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1417
1418         Reviewed by Mark Rowe.
1419
1420         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1421         (LayoutTestController::evaluateScriptInIsolatedWorld):
1422         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1423         (LayoutTestController::evaluateScriptInIsolatedWorld):
1424         Updated for changes to WebFrame. Now holds the map of worldID -> world
1425         at this level instead of making WebKit do it.
1426
1427 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1428
1429         Reviewed by Simon Hausmann.
1430
1431         [Qt] Ensure the DRT does not output anything until first test is run
1432
1433         * DumpRenderTree/qt/DumpRenderTree.cpp:
1434         * DumpRenderTree/qt/DumpRenderTree.h:
1435
1436 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1437
1438         Reviewed by Tor Arne Vestbø.
1439
1440         Clear the undo stack in before each new test run.
1441
1442         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1443
1444         * DumpRenderTree/qt/DumpRenderTree.cpp:
1445         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1446
1447 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1448
1449         Reviewed by Kenneth Rohde Christiansen.
1450
1451         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1452
1453         * DumpRenderTree/qt/DumpRenderTree.cpp:
1454         (WebCore::WebPage::resetSettings):
1455         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1456         (LayoutTestController::overridePreference):
1457
1458 2009-11-13  Eric Seidel  <eric@webkit.org>
1459
1460         Reviewed by Adam Barth.
1461
1462         Update committers.py based on svn records
1463         https://bugs.webkit.org/show_bug.cgi?id=31366
1464
1465         This list was generated using validate-committer-lists from
1466         https://bugs.webkit.org/show_bug.cgi?id=30970
1467         and makes committers.py current for committers who have
1468         committed in the last 3 years.
1469
1470         * Scripts/modules/committers.py:
1471
1472 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1473
1474         Reviewed by Adam Barth.
1475
1476         The document-open.html test was flaky at times. The test invokes the layout test plugin
1477         which in its destroy stream handler opens a new document. This basically tears down the
1478         stream and the associated plugin instance. The pluginLog function in the layout test
1479         plugin attempts to retrieve the window script object on a torn down plugin instance
1480         which crashed consistently on windows in the debugger. The functions which issue
1481         these logs already have a valid window script object. We now have variants of the pluginLog
1482         function which take in a window script object with and without variable arguments. 
1483
1484         https://bugs.webkit.org/show_bug.cgi?id=31067
1485
1486         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1487         (pluginLogWithWindowObject):
1488         (pluginLogWithWindowObjectVariableArgs):
1489         (pluginLog):
1490         (notifyTestCompletion):
1491         (testDocumentOpen):
1492         (testWindowOpen):
1493
1494 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1495
1496         Reviewed by Gustavo Noronha Silva.
1497
1498         https://bugs.webkit.org/show_bug.cgi?id=30997
1499         [Gtk] Implemment AtkDocument
1500
1501         Added testing support.
1502
1503         * DumpRenderTree/AccessibilityUIElement.cpp:
1504         * DumpRenderTree/AccessibilityUIElement.h:
1505         (getDocumentEncodingCallback):
1506         (getDocumentURICallback):
1507         (AccessibilityUIElement::getJSClass):
1508         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1509         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1510         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1511         (AccessibilityUIElement::documentEncoding):
1512         (AccessibilityUIElement::documentURI):
1513
1514 2009-11-12  Adam Roben  <aroben@apple.com>
1515
1516         Replace worldIDs with world objects
1517
1518         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1519         user scripts/stylesheets and isolated worlds
1520
1521         Reviewed by Sam Weinig.
1522
1523         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1524         (LayoutTestController::addUserScript):
1525         (LayoutTestController::addUserStyleSheet):
1526         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1527         (LayoutTestController::addUserScript):
1528         (LayoutTestController::addUserStyleSheet):
1529         Changed these functions to create a new WebJSWorld each time they're
1530         called and to pass that world to WebKit.
1531
1532 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1533
1534         Reviewed by Oliver Hunt.
1535
1536         need to implement aria tree roles
1537         https://bugs.webkit.org/show_bug.cgi?id=31284
1538
1539         * DumpRenderTree/AccessibilityUIElement.cpp:
1540         (disclosedRowAtIndexCallback):
1541         (selectedRowAtIndexCallback):
1542         (isEqualCallback):
1543         (isAttributeSettableCallback):
1544         (isActionSupportedCallback):
1545         (disclosedByRowCallback):
1546         (hierarchicalLevelCallback):
1547         (AccessibilityUIElement::getJSClass):
1548         * DumpRenderTree/AccessibilityUIElement.h:
1549         (AccessibilityUIElement::isEqual):
1550         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1551         (AccessibilityUIElement::hierarchicalLevel):
1552         (AccessibilityUIElement::disclosedRowAtIndex):
1553         (AccessibilityUIElement::selectedRowAtIndex):
1554         (AccessibilityUIElement::disclosedByRow):
1555         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1556         (AccessibilityUIElement::getChildAtIndex):
1557         (AccessibilityUIElement::disclosedRowAtIndex):
1558         (AccessibilityUIElement::selectedRowAtIndex):
1559         (AccessibilityUIElement::titleUIElement):
1560         (AccessibilityUIElement::parentElement):
1561         (AccessibilityUIElement::disclosedByRow):
1562         (AccessibilityUIElement::hierarchicalLevel):
1563         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1564         (AccessibilityUIElement::hierarchicalLevel):
1565         (AccessibilityUIElement::disclosedRowAtIndex):
1566         (AccessibilityUIElement::selectedRowAtIndex):
1567         (AccessibilityUIElement::disclosedByRow):
1568
1569 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1570
1571         Reviewed by Darin Adler.
1572
1573         svn-apply can not handle git binary diffs
1574         https://bugs.webkit.org/show_bug.cgi?id=26830
1575
1576         Support "literal" type git binary diffs.
1577
1578         * Scripts/VCSUtils.pm:
1579         * Scripts/modules/scm_unittest.py:
1580         * Scripts/svn-apply:
1581
1582 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1583
1584         Not reviewed, removing duplicate entry for myself in committers.py.
1585
1586         * Scripts/modules/committers.py:
1587
1588 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1589
1590         Reviewed by Darin Adler and Mark Rowe.
1591
1592         https://bugs.webkit.org/show_bug.cgi?id=31200
1593         Tests in http/tests/security/mixedContent start to fail when new tests are added
1594
1595         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1596
1597 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1598
1599         Reviewed by Jan Alonzo.
1600
1601         Create, and display a window for the inspector, for inspector
1602         tests.
1603
1604         Need to also show/hide the inspector window to avoid having
1605         problems with code assuming it is realized
1606         https://bugs.webkit.org/show_bug.cgi?id=31347
1607
1608         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1609         (webInspectorShowWindow):
1610         (webInspectorCloseWindow):
1611         (webInspectorInspectWebView):
1612         (createWebView):
1613
1614 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1615
1616         Unreviewed Qt buildbot fix.
1617
1618         My previous fix was wrong, so revert that change and fix it by
1619         returning when the document of the frame has no document element.
1620         Idea is borrowed from mac and win DRT.
1621
1622         * DumpRenderTree/qt/DumpRenderTree.cpp:
1623         (WebCore::DumpRenderTree::dumpFramesAsText):
1624
1625 2009-11-11  Eric Seidel  <eric@webkit.org>
1626
1627         Reviewed byg Kenneth Rohde Christiansen.
1628
1629         Update Kenneth's committer record to include the email he
1630         uses on lists.webkit.org.
1631
1632         * Scripts/modules/committers.py:
1633
1634 2009-11-11  Eric Seidel  <eric@webkit.org>
1635
1636         Reviewed by Gustavo Noronha Silva.
1637
1638         Several committers use separate email addresses for bugzilla and svn.webkit.org
1639         https://bugs.webkit.org/show_bug.cgi?id=31364
1640
1641         Update records for existing committers to include email addresses
1642         used in svn.webkit.org and lists.webkit.org.
1643         Most committers use the same email address in all 3 places, but some use
1644         separate addresses.  committers.py needs record of each of these addresses.
1645
1646         * Scripts/modules/committers.py:
1647
1648 2009-11-11  Eric Seidel  <eric@webkit.org>
1649
1650         No review, adding second email address for an existing committer.
1651
1652         Add Yong Li's second bugzilla account to his committer record.
1653         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1654
1655         * Scripts/modules/committers.py:
1656
1657 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1658
1659         Reviewed by Simon Hausmann.
1660
1661         If the frame has no innerText don't append it, and
1662         do not add a newline which breaks some cross platform
1663         results.
1664
1665         * DumpRenderTree/qt/DumpRenderTree.cpp:
1666         (WebCore::DumpRenderTree::dumpFramesAsText):
1667
1668 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1669
1670         Reviewed by Simon Hausmann.
1671
1672         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1673
1674         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1675         (webkit_test_plugin_new_instance):
1676         (webkit_test_plugin_destroy_instance):
1677         (webkit_test_plugin_destroy_stream):
1678
1679 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1680
1681         Reviewed by Mark Rowe.
1682
1683         Implement the functionality needed by plugins/window-open.html
1684
1685         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1686         (webkit_test_plugin_new_instance):
1687         (webkit_test_plugin_set_window):
1688
1689 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1690
1691         Reviewed by Simon Hausmann.
1692
1693         [Qt] Force -graphicssystem raster and -style windows when running DRT
1694
1695         * DumpRenderTree/qt/main.cpp:
1696         * Scripts/run-webkit-tests:
1697
1698 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1699
1700         Reviewed by Simon Hausmann.
1701
1702         Compute correct library paths for Qt
1703
1704         * Scripts/webkitdirs.pm:
1705
1706 2009-11-10  Mark Rowe  <mrowe@apple.com>
1707
1708         Reviewed by Sam Weinig.
1709
1710         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1711
1712         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1713         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1714         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1715         that had enabled frame load delegate logging this would result in extra log messages being generated,
1716         causing the test to fail.
1717
1718         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1719         tests.
1720
1721         * DumpRenderTree/mac/DumpRenderTree.mm:
1722         (dumpRenderTree):
1723         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1724         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1725
1726 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1727
1728         Reviewed by Kenneth Rohde Christiansen.
1729
1730         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1731
1732         * DumpRenderTree/qt/DumpRenderTree.cpp:
1733         (WebCore::DumpRenderTree::DumpRenderTree):
1734
1735 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1736
1737         Reviewed by Jan Alonzo.
1738
1739         [GTK] Remove WebSocket configuration from WebKitWebSettings
1740         https://bugs.webkit.org/show_bug.cgi?id=31244
1741
1742         Follow-up of r50724. Don't set the enable-web-socket property
1743         anymore.
1744
1745         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1746         (resetDefaultsToConsistentValues):
1747
1748 2009-11-10  Oliver Hunt  <oliver@apple.com>
1749
1750         Reviewed by Maciej Stachowiak.
1751
1752         Rename 3D Canvas related classes to use WebGL prefix
1753         https://bugs.webkit.org/show_bug.cgi?id=29095
1754
1755         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1756         and upate webkitdirs script to new method of testing for WebGL.
1757
1758         * Scripts/do-webcore-rename:
1759         * Scripts/webkitdirs.pm:
1760
1761 2009-11-09  Oliver Hunt  <oliver@apple.com>
1762
1763         Reviewed by Geoff Garen.
1764
1765         Make do-webcore-rename work with git.
1766
1767         * Scripts/do-webcore-rename:
1768
1769 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1770
1771         Adding Kenneth to the reviewers list.
1772
1773         * Scripts/modules/committers.py:
1774
1775 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1776
1777         Reviewed by Jan Alonzo.
1778
1779         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1780         https://bugs.webkit.org/show_bug.cgi?id=30482
1781
1782         LayoutTestControllerGtk now uses the exposed
1783         Page::tabKeyCyclesThroughElements API
1784
1785         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1786         (LayoutTestController::setTabKeyCyclesThroughElements):
1787
1788 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1789
1790         Reviewed by Holger Freyther.
1791
1792         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1793         This helps to pass the test case below. Also replaced hardcoded
1794         code numbers with defined constants.
1795         https://bugs.webkit.org/show_bug.cgi?id=31185
1796         
1797         Test: editing/undo/undo-deleteWord.html
1798
1799         * DumpRenderTree/qt/EventSenderQt.cpp:
1800         (EventSender::keyDown):
1801
1802 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1803
1804         Reviewed by Holger Freyther.
1805
1806         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1807         https://bugs.webkit.org/show_bug.cgi?id=31164
1808
1809         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1810
1811         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1812         (LayoutTestController::processWork):
1813
1814 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1815
1816         Reviewed by Holger Freyther.
1817
1818         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1819         https://bugs.webkit.org/show_bug.cgi?id=31158
1820
1821         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1822         always, which from WorkQueue prospective means that a load has been started
1823         and the queue processing should stop and wait for the load to finish.
1824         Spinning it off into a loading and a non-loading variants was the solution
1825         adopted by Mac's DRT to work around this problem. The former keeps returning
1826         'true' while the later executes the script synchronously and returns 'false'
1827         making it possible to the WorkQueue to proceed right away.
1828
1829         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1830         (LayoutTestController::processWork):
1831         (LayoutTestController::queueLoadingScript):
1832         (LayoutTestController::queueNonLoadingScript):
1833         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1834         * DumpRenderTree/qt/WorkQueueItem.h:
1835         (LoadingScriptItem::LoadingScriptItem):
1836         (LoadingScriptItem::invoke):
1837         (NonLoadingScriptItem::NonLoadingScriptItem):
1838         (NonLoadingScriptItem::invoke):
1839
1840 2009-11-07  Mark Rowe  <mrowe@apple.com>
1841
1842         Rubber-stamped by Cameron Zwarich.
1843
1844         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1845
1846         * Scripts/commit-log-editor:
1847
1848 2009-11-07  Mark Rowe  <mrowe@apple.com>
1849
1850         Reviewed by Darin Adler.
1851
1852         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1853         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1854
1855         Move logic for determining the name and email address to use in a ChangeLog entry from
1856         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1857         whether the author of the patch matches committer, and therefore needs access to the
1858         email address that would be used in a ChangeLog entry.
1859
1860         Based on a patch by Pierre d'Herbemont.
1861
1862         * Scripts/VCSUtils.pm:
1863         * Scripts/commit-log-editor:
1864         * Scripts/prepare-ChangeLog:
1865         * Scripts/webkitdirs.pm:
1866
1867 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1868
1869         Reviewed by Adam Barth.
1870
1871         Added functionality to the layout test plugin to invoke document.open and
1872         window.open with default arguments. The associated webkit bug is
1873         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1874         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1875         work in Chromium (V8) if there is no calling javascript context. To achieve this
1876         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1877         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1878
1879         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1880         (testDocumentOpen):
1881         (testWindowOpen):
1882         (pluginAllocate):
1883         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1884         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1885         (NPP_New):
1886         (NPP_SetWindow):
1887         (NPP_DestroyStream):
1888         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1889         (NPP_New):
1890         (NPP_SetWindow):
1891         (NPP_NewStream):
1892         (NPP_DestroyStream):
1893
1894 2009-11-06  Eric Seidel  <eric@webkit.org>
1895
1896         Reviewed by Adam Barth.
1897
1898         bugzilla-tool crashed with exception
1899         https://bugs.webkit.org/show_bug.cgi?id=31092
1900
1901         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1902
1903 2009-11-04  Eric Seidel  <eric@webkit.org>
1904
1905         No review, just add a line which got left out of the patch uploaded for commit.
1906
1907         commit-queue is crashing when trying to reject patches after unknown failures
1908         https://bugs.webkit.org/show_bug.cgi?id=31091
1909
1910         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1911
1912 2009-11-04  Adam Roben  <aroben@apple.com>
1913
1914         Remove bogus else clause in bugzilla-tool
1915
1916         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1917         create-bug raises exception after entering bug description
1918
1919         Reviewed by David Kilzer.
1920
1921         * Scripts/bugzilla-tool:
1922         (CreateBug): else clauses are only hit if no exception is raised, so
1923         it makes no sense to try to re-raise the exception in an else clause.
1924         The exception will automatically be re-raised if it doesn't match any
1925         of the except clauses, so we don't have to do anything special here at
1926         all to get the desired behavior.
1927
1928 2009-11-04  Eric Seidel  <eric@webkit.org>
1929
1930         Reviewed by David Kilzer.
1931
1932         svn-apply's fixChangeLogPatch function seems broken
1933         https://bugs.webkit.org/show_bug.cgi?id=30683
1934
1935         Update fixChangeLogPatch to be able to handle patches which
1936         don't start at line 1.
1937         Add unit tests for svn-apply to scm_unittest.py.
1938
1939         * Scripts/VCSUtils.pm:
1940         * Scripts/modules/scm_unittest.py:
1941
1942 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1943
1944         Reviewed by Beth Dakin.
1945
1946         Need to implement ARIA role="combobox"
1947         https://bugs.webkit.org/show_bug.cgi?id=31096
1948
1949         * DumpRenderTree/AccessibilityUIElement.cpp:
1950         (showMenuCallback):
1951         (getIsExpandedCallback):
1952         (AccessibilityUIElement::getJSClass):
1953         * DumpRenderTree/AccessibilityUIElement.h:
1954         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1955         (AccessibilityUIElement::isExpanded):
1956         (AccessibilityUIElement::showMenu):
1957         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1958         (AccessibilityUIElement::isExpanded):
1959         (AccessibilityUIElement::showMenu):
1960         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1961         (AccessibilityUIElement::isSelected):
1962         (AccessibilityUIElement::isExpanded):
1963         (AccessibilityUIElement::showMenu):
1964
1965 2009-11-04  Eric Seidel  <eric@webkit.org>
1966
1967         Reviewed by Adam Barth.
1968
1969         commit-queue is crashing when trying to reject patches after unknown failures
1970         https://bugs.webkit.org/show_bug.cgi?id=31091
1971
1972         * Scripts/bugzilla-tool:
1973          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1974            so we have to find out what the current patch is by asking bugzilla again.
1975          - Discovered that this code was also leaking file descriptors, so fixed that.
1976
1977 2009-11-04  Adam Roben  <aroben@apple.com>
1978
1979         Make run-webkit-tests work for the Debug_Internal Windows
1980         configuration
1981
1982         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1983         suffix.
1984
1985         Fixes <http://webkit.org/b/31123>.
1986
1987         Reviewed by Sam Weinig.
1988
1989         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1990         Debug_Internal, either.
1991
1992 2009-11-04  Eric Seidel  <eric@webkit.org>
1993
1994         Reviewed by Adam Barth.
1995
1996         committers.py needs a way to store non-bugzilla email addresses
1997         https://bugs.webkit.org/show_bug.cgi?id=31037
1998
1999         Make Committer and Reviewer constructors take a single email or a list of emails.
2000         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2001         Expose reviewers(), used by validate-committer-lists on bug 30970.
2002
2003         * Scripts/modules/committers.py:
2004         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2005
2006 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2007
2008         Reviewed by David Levin.
2009
2010         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2011         https://bugs.webkit.org/show_bug.cgi?id=27491
2012
2013         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2014         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2015
2016         Functions to start or stop Web Socket servers are added.
2017
2018         * Scripts/run-webkit-tests:
2019
2020 2009-11-03  Eric Seidel  <eric@webkit.org>
2021
2022         No review, just changing wording of log message.
2023
2024         Change log string to say "failed" instead of "rejected"
2025         when a commit fails due to an out of date checkout.
2026         This makes grepping the commit-queue log for rejected patches easier.
2027
2028         * Scripts/bugzilla-tool:
2029
2030 2009-11-03  Eric Seidel  <eric@webkit.org>
2031
2032         No review, adding commonly known committers missing from the file.
2033
2034         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2035
2036 2009-11-03  Eric Seidel  <eric@webkit.org>
2037
2038         No review, just sort-order cleanup.
2039
2040         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2041
2042 2009-11-03  Stephen White  <senorblanco@chromium.org>
2043
2044         (Unreviewed).
2045
2046         Add myself to committers.py.
2047
2048         * Scripts/modules/committers.py:
2049
2050 2009-11-03  Robin Dunn  <robin@alldunn.com>
2051
2052         Reviewed by Kevin Ollviier.
2053
2054         Add packaging scripts for Debian-based Linux distros.
2055         
2056         https://bugs.webkit.org/show_bug.cgi?id=31075
2057
2058         * wx/packaging/build-debian-installer.py: Added.
2059         * wx/packaging/debian: Added.
2060
2061 2009-11-03  Dan Bernstein  <mitz@apple.com>
2062
2063         Reviewed by Anders Carlsson and Beth Dakin.
2064
2065         https://bugs.webkit.org/show_bug.cgi?id=31070
2066
2067         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2068         destroyed, it executes the value of the 'ondestroy' parameter as a
2069         script.
2070
2071         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2072         (pluginAllocate): Initialize onDestroy.
2073         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2074         onDestroy.
2075         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2076         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2077         specified.
2078         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2079
2080 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2081
2082         Reviewed by Xan Lopez.
2083
2084         https://bugs.webkit.org/show_bug.cgi?id=31035
2085         [GTK] some accessibility tests hitting assertion in debug builds
2086
2087         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2088
2089         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2090         (AccessibilityController::rootElement):
2091
2092 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2093
2094         Reviewed by Beth Dakin.
2095
2096         Support ARIA "tab" roles
2097         https://bugs.webkit.org/show_bug.cgi?id=30842
2098
2099         * DumpRenderTree/AccessibilityUIElement.cpp:
2100         * DumpRenderTree/AccessibilityUIElement.h:
2101         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2102         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2103         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2104
2105 2009-11-01  Eric Seidel  <eric@webkit.org>
2106
2107         Reviewed by David Levin.
2108
2109         buildbots should use --exit-after-N-failures
2110         https://bugs.webkit.org/show_bug.cgi?id=30809
2111
2112         Make the bots exit after 20 failures to prevent never-ending
2113         test runs where every test spends a minute crashing.
2114
2115         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2116
2117 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2118
2119         Reviewed by Eric Seidel.
2120
2121         Turn on warnings for QtWebKit for gcc
2122         https://bugs.webkit.org/show_bug.cgi?id=30958
2123
2124         * DumpRenderTree/qt/main.cpp: 
2125         (crashHandler): Mark function NO_RETURN
2126
2127 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2128
2129         Adding myself to the committers list.
2130
2131         * Scripts/modules/committers.py:
2132
2133 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2134
2135         Fix an issue that Adam noticed in DRT.
2136
2137         Reviewed by Darin Adler.
2138
2139         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2140         (AccessibilityUIElement::role):
2141         Get the length of the role text, and create a buffer dynamically.
2142
2143 2009-10-30  Eric Seidel  <eric@webkit.org>
2144
2145         No review, rolling out r50105.
2146         http://trac.webkit.org/changeset/50105
2147
2148         This commit was causing:
2149         https://bugs.webkit.org/show_bug.cgi?id=30869
2150         We'll re-implement the feature a different way.
2151
2152         * Scripts/bugzilla-tool:
2153
2154 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2155
2156         Test for MSAA: Accessibility of headings is not correct
2157
2158         https://bugs.webkit.org/show_bug.cgi?id=30937
2159
2160         Reviewed by Adam Roben.
2161
2162         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2163         (AccessibilityUIElement::role):
2164         Allow the role returned to be a BSTR.
2165         (AccessibilityUIElement::description):
2166         Fix a copy/paste error.
2167
2168 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2169
2170         Test for MSAA: Accessibility of links is wrong
2171
2172         https://bugs.webkit.org/show_bug.cgi?id=30928
2173
2174         Reviewed by Darin Adler.
2175
2176         * DumpRenderTree/AccessibilityUIElement.cpp:
2177         (getAccessibilityValueCallback):
2178         Return the accessibility value.
2179         (AccessibilityUIElement::getJSClass):
2180         Added "accessibilityValue" value.
2181
2182         * DumpRenderTree/AccessibilityUIElement.h:
2183
2184         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2185         (AccessibilityUIElement::accessibilityValue):
2186         Stubbed.
2187
2188         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2189         (AccessibilityUIElement::accessibilityValue):
2190         Stubbed.
2191
2192         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2193         (AccessibilityUIElement::accessibilityValue):
2194         Get the object's value, and return it as a JS string.
2195
2196 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2197
2198         Fix typo in command name used by wx build system.
2199
2200         * wx/build/build_utils.py:
2201
2202 2009-10-30  Adam Barth  <abarth@webkit.org>
2203
2204         Reviewed by Darin Adler.
2205
2206         Patch v1 is a dumb default name for patches
2207         https://bugs.webkit.org/show_bug.cgi?id=30952
2208
2209         Let's use "Patch" instead.
2210
2211         * Scripts/bugzilla-tool:
2212
2213 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2214
2215         Unreviewed trivial buildfix.
2216
2217         [Qt] Buildfix for r50333.
2218
2219         * DumpRenderTree/qt/DumpRenderTree.pro:
2220
2221 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2222
2223         Reviewed by Holger Freyther.
2224
2225         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2226         https://bugs.webkit.org/show_bug.cgi?id=30953
2227
2228         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2229         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2230         makes qt DRT to share this implementation (as gtk and mac ports do).
2231
2232         * DumpRenderTree/qt/DumpRenderTree.pro:
2233         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2234         * DumpRenderTree/qt/WorkQueue.h: Removed.
2235
2236 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2237
2238         Unreviewed potential buildbot fix.
2239
2240         Second try: Reset page history before running each test.
2241
2242         Apparently the QWebHistory::clear() keeps the current page
2243         in history which is not what we want, so we not additionally
2244         sets the history capacity to 0 (forces removing everything)
2245         and then sets it back to its original value.
2246
2247         * DumpRenderTree/qt/DumpRenderTree.cpp:
2248         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2249
2250 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2251
2252         Unreviewed potential buildbot fix.
2253
2254         Reset page history before running each test.
2255
2256         * DumpRenderTree/qt/DumpRenderTree.cpp:
2257         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2258
2259 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2260
2261         Reviewed by Eric Seidel.
2262
2263         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2264
2265         Bug 28420 -  Implement HTML5 <ruby> rendering
2266         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2267
2268         No new tests (no functional change).
2269
2270         * Scripts/build-webkit:
2271
2272 2009-10-29  Dan Bernstein  <mitz@apple.com>
2273
2274         Reviewed by Mark Rowe.
2275
2276         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2277         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2278         define it.
2279
2280         * Scripts/VCSUtils.pm:
2281         * Scripts/svn-apply:
2282         * Scripts/svn-unapply:
2283
2284 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2285
2286         Reviewed by Gustavo Noronha.
2287
2288         Use the GTK+ main loop instead of rolling our own mini-version of
2289         it.
2290
2291         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2292         (dump):
2293         (runTest):
2294         (webViewLoadFinished):
2295
2296 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2297
2298         Reviewed by Oliver Hunt.
2299
2300         Implement the Qt version of DRT dumpBackForwardList().
2301
2302         * DumpRenderTree/qt/DumpRenderTree.cpp:
2303         (WebCore::dumpHistoryItem):
2304         (WebCore::DumpRenderTree::dumpBackForwardList):
2305
2306 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2307
2308         Reviewed by Adam Roben.
2309
2310         Implement DRT functionality for Qt introduced in
2311         r28690 and r28705.
2312
2313         - Implemented pathToLocalResource which exposes the functionality of
2314         converting a given unix path to the correct location on Windows.
2315         - Implemented a way to remove machine-dependent information from paths
2316         in layout test results.
2317
2318         * DumpRenderTree/qt/DumpRenderTree.cpp:
2319         (WebCore::urlSuitableForTestResult):
2320         (WebCore::WebPage::javaScriptConsoleMessage):
2321         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2322         (LayoutTestController::pathToLocalResource):
2323         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2324
2325 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2326
2327         Adding myself to the committers list.
2328
2329         * Scripts/modules/committers.py:
2330
2331 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2332
2333         Adding myself to the committers list.
2334
2335         * Scripts/modules/committers.py:
2336
2337 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2338
2339         Reviewed by Jan Alonzo.
2340
2341         [GTK] API to start inspector for a WebView
2342         https://bugs.webkit.org/show_bug.cgi?id=22551
2343
2344         Use the new inspector API to implement the LayoutTestController
2345         interfaces used to test the inspector.
2346
2347         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2348         (webInspectorInspectWebView):
2349         (createWebView):
2350         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2351         (LayoutTestController::showWebInspector):
2352         (LayoutTestController::closeWebInspector):
2353         (LayoutTestController::evaluateInWebInspector):
2354
2355 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2356
2357         Reviewed by Eric Seidel.
2358
2359         [Qt] WebFrame::counterValueForElementById must not be exposed
2360         https://bugs.webkit.org/show_bug.cgi?id=30882
2361
2362         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2363         (LayoutTestController::counterValueForElementById):
2364
2365 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2366
2367         Rubberstamped by Oliver Hunt.
2368
2369         Fix the warning:
2370
2371         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2372         declared with attribute warn_unused_result".
2373
2374         by actually checking the result. In the case it is null, an
2375         error has occoured, so treat it as the other fatal errors.
2376
2377         * DumpRenderTree/qt/DumpRenderTree.cpp:
2378         (WebCore::DumpRenderTree::initializeFonts):
2379
2380 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2381
2382         Reviewed by Darin Adler.
2383
2384         Provide a way to get counter values with layoutTestContoller
2385         https://bugs.webkit.org/show_bug.cgi?id=30555
2386
2387         Define layoutTestContoller.counterValueForElementById.
2388
2389         * DumpRenderTree/LayoutTestController.cpp:
2390         (counterValueForElementByIdCallback):
2391         (LayoutTestController::staticFunctions):
2392         * DumpRenderTree/LayoutTestController.h:
2393         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2394         (LayoutTestController::counterValueForElementById):
2395
2396 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2397
2398         Rubberstamped by Oliver Hunt.
2399
2400         Change two methods to be internal for DRT use only.
2401
2402         Part of [Qt] Review all new API in Qt 4.6
2403         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2404
2405         * DumpRenderTree/qt/DumpRenderTree.cpp:
2406         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2407         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2408         (LayoutTestController::whiteListAccessFromOrigin):
2409
2410 2009-10-27  Eric Seidel  <eric@webkit.org>
2411
2412         Reviewed by Adam Barth.
2413
2414         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2415         https://bugs.webkit.org/show_bug.cgi?id=30826
2416
2417         * Scripts/svn-apply:
2418          - Add () around all system() calls.
2419          - Use the correct system() == 0 or die instead of system() or die
2420          - Add descriptive messages to all die statements.
2421
2422 2009-10-27  Steve Block  <steveblock@google.com>
2423
2424         Reviewed by NOBODY.
2425
2426         Adds steveblock@google.com to list of committers.
2427
2428         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2429
2430 2009-10-27  Eric Seidel  <eric@webkit.org>
2431
2432         Reviewed by Adam Barth.
2433
2434         svn-apply can exit(0) even on patch failure
2435         https://bugs.webkit.org/show_bug.cgi?id=29622
2436
2437         * Scripts/svn-apply:
2438          - Add a bunch of "or die" statements, hopefully catching all
2439            possible cases where failure could still exit(0).
2440
2441 2009-10-27  Eric Seidel  <eric@webkit.org>
2442
2443         Reviewed by Adam Barth.
2444
2445         svn-* scripts should share code through VCSUtils.pm
2446         https://bugs.webkit.org/show_bug.cgi?id=30791
2447
2448         Just moving code into a shared location.
2449
2450         * Scripts/VCSUtils.pm:
2451         * Scripts/prepare-ChangeLog:
2452         * Scripts/resolve-ChangeLogs:
2453         * Scripts/svn-apply:
2454         * Scripts/svn-create-patch:
2455         * Scripts/svn-unapply:
2456         * Scripts/update-webkit:
2457
2458 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2459
2460         Suppress a huge number of MSVC warnings when building wxWebKit.
2461
2462         * wx/build/settings.py:
2463
2464 2009-10-26  Eric Seidel  <eric@webkit.org>
2465
2466         No review, just adding Mike Belshe to the committers list.
2467
2468         * Scripts/modules/committers.py:
2469
2470 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2471
2472         Reviewed by Darin Adler.
2473
2474         Make .rc files compile on Windows without depending on MFC headers
2475         https://bugs.webkit.org/show_bug.cgi?id=30750
2476
2477         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2478         windows.h instead of afxres.h because it exists even when MFC is not 
2479         installed, and is all that's needed here.
2480
2481         * FindSafari/FindSafari.rc: Ditto
2482
2483 2009-10-24  Eric Seidel  <eric@webkit.org>
2484
2485         Reviewed by Adam Barth.
2486
2487         bugzilla-tool post-diff should know how to mark commit-queue=?
2488         https://bugs.webkit.org/show_bug.cgi?id=29202
2489
2490         * Scripts/bugzilla-tool:
2491          - Add --commit-queue option to post-diff, post-commits and create-bug.
2492         * Scripts/modules/bugzilla.py:
2493          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2494          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2495
2496 2009-10-23  Eric Seidel  <eric@webkit.org>
2497
2498         Reviewed by Adam Barth.
2499
2500         bugzilla-tool commit-queue does not notice modifications to committers.py
2501         https://bugs.webkit.org/show_bug.cgi?id=30084
2502
2503         * Scripts/bugzilla-tool:
2504          - Make commit-queue re-exec itself instead of using while(1).
2505          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2506          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2507
2508 2009-10-22  Eric Seidel  <eric@webkit.org>
2509
2510         Reviewed by Adam Barth.
2511
2512         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2513         https://bugs.webkit.org/show_bug.cgi?id=30634
2514
2515         * Scripts/bugzilla-tool:
2516          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2517          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2518
2519 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2520
2521         Reviewed by Eric Seidel.
2522
2523         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2524
2525         https://bugs.webkit.org/show_bug.cgi?id=30763
2526
2527         * pywebsocket/mod_pywebsocket/__init__.py:
2528         * pywebsocket/mod_pywebsocket/dispatch.py:
2529         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2530         * pywebsocket/mod_pywebsocket/standalone.py:
2531         * pywebsocket/setup.py:
2532         * pywebsocket/test/test_dispatch.py:
2533
2534 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2535
2536         Reviewed by David Levin.
2537
2538         REGRESSION: 2 failures in run-webkit-unittests
2539         https://bugs.webkit.org/show_bug.cgi?id=30645
2540
2541         * Scripts/modules/cpp_style_unittest.py:
2542         Fixed a few test scenarios which apparently lost some spaces from 
2543         text literals.
2544
2545 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2546
2547         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2548
2549         * Scripts/webkitdirs.pm:
2550
2551 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2552
2553         Reviewed by Darin Adler.
2554
2555         Unification of using null device in perl scripts.
2556         https://bugs.webkit.org/show_bug.cgi?id=30572
2557
2558         * Scripts/VCSUtils.pm:
2559         * Scripts/bisect-builds:
2560         * Scripts/resolve-ChangeLogs:
2561         * Scripts/run-iexploder-tests:
2562         * Scripts/run-jsc:
2563         * Scripts/run-mangleme-tests:
2564         * Scripts/run-webkit-tests:
2565         * Scripts/webkitdirs.pm:
2566         Using File::Spec->devnull() instead of hard coded /dev/null.
2567
2568 2009-10-26  Eric Seidel  <eric@webkit.org>
2569
2570         Reviewed by Holger Freyther.
2571
2572         Reviewers are missing from committers.py
2573         https://bugs.webkit.org/show_bug.cgi?id=30733
2574
2575         * Scripts/modules/committers.py:
2576
2577 2009-10-23  Eric Seidel  <eric@webkit.org>
2578
2579         No review, only adding Alice to the list of reviewers.
2580
2581         * Scripts/modules/committers.py:
2582
2583 2009-10-23  Eric Seidel  <eric@webkit.org>
2584
2585         Reviewed by Eric Carlson.
2586
2587         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2588         https://bugs.webkit.org/show_bug.cgi?id=30700
2589
2590         * DumpRenderTree/mac/DumpRenderTree.mm:
2591         (resetDefaultsToConsistentValues): Update QuickTime version check.
2592
2593 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2594
2595         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2596         character measurement APIs that are private on Tiger.
2597
2598         * wx/build/settings.py:
2599
2600 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2601
2602         Reviewed by NOBODY (build fix).
2603         Build fix following bug #30696.
2604
2605         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2606         (LayoutTestController::evaluateScriptInIsolatedWorld):
2607
2608 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2609
2610         Reviewed by Sam Weinig & Geoff Garen.
2611
2612         https://bugs.webkit.org/show_bug.cgi?id=30696
2613         Enable isolated-worlds tests on mac.
2614
2615         Add private interface for DRT to invoke execution in a given world.
2616
2617         * DumpRenderTree/LayoutTestController.cpp:
2618         (evaluateScriptInIsolatedWorldCallback):
2619         (LayoutTestController::staticFunctions):
2620         * DumpRenderTree/LayoutTestController.h:
2621         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2622         (LayoutTestController::evaluateScriptInIsolatedWorld):
2623         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2624         (LayoutTestController::evaluateScriptInIsolatedWorld):
2625
2626 2009-10-21  Eric Seidel  <eric@webkit.org>
2627
2628         Reviewed by Adam Barth.
2629
2630         bugzilla-tool's "patch failed to download an apply" error should give more information
2631         https://bugs.webkit.org/show_bug.cgi?id=30632
2632
2633         * Scripts/modules/scm.py:
2634          - Use the common run_command method instead of custom POpen code.
2635          - Make run_command know how to take pipes as input.
2636         * Scripts/modules/scm_unittest.py:
2637          - Add new tests to cover change.
2638          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2639
2640 2009-10-21  Kent Tamura  <tkent@chromium.org>
2641
2642         Unreviewed.  Adding myself to the committers list.
2643
2644         * Scripts/modules/committers.py:
2645
2646 2009-10-21  Robin Dunn  <robin@alldunn.com>
2647
2648         Reviewed by Kevin Ollivier.
2649
2650         Update the Windows installer builder to work with Vista / Win 7 and with git.
2651         
2652         https://bugs.webkit.org/show_bug.cgi?id=30649
2653
2654         * wx/build/build_utils.py:
2655         * wx/packaging/build-mac-installer.py:
2656         * wx/packaging/build-win-installer.py:
2657         * wx/packaging/wxWebKitInstaller.iss.in:
2658
2659 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2660
2661         Reviewed by Gustavo Noronha.
2662
2663         [GTK] Added conditional code to avoid using
2664         gdk_window_get_root_coords if we do not have a gtk+ release newer
2665         than 2.17.3.
2666         https://bugs.webkit.org/show_bug.cgi?id=30636
2667
2668         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2669
2670 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2671
2672         Reviewed by Eric Seidel.
2673
2674         [Qt] Added dummy implementation for keepWebHistory()
2675         https://bugs.webkit.org/show_bug.cgi?id=30592
2676
2677         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2678         (LayoutTestController::keepWebHistory):
2679         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2680
2681 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2682
2683         Reviewed by Xan Lopez.
2684
2685         [GTK] Fixed the double click condition, it is not double click if
2686         we move in just in one direction.
2687         https://bugs.webkit.org/show_bug.cgi?id=30636
2688
2689         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2690
2691 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2692
2693         Reviewed by Xan Lopez.
2694
2695         [GTK] Initialize the events completly before emitting them.
2696         https://bugs.webkit.org/show_bug.cgi?id=30633
2697
2698         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2699
2700 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2701
2702         wx build fix. Fix for when linking using --as-needed with gcc.
2703
2704         * wx/browser/wscript:
2705
2706 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2707
2708         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2709         to support all the features used by CURL backend.
2710         
2711         * wx/build/settings.py:
2712         * wx/install-unix-extras:
2713
2714 2009-10-20  Anton Muhin  <antonm@chromium.org>
2715
2716         Reviewed by Adam Barth.
2717
2718         Add {ager,antonm,yurys}@chromium.org into committers.py
2719         https://bugs.webkit.org/show_bug.cgi?id=30560
2720
2721         * Scripts/modules/committers.py:
2722
2723 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2724
2725         Reviewed by Tor Arne Vestbø.
2726
2727         Make the Netscape Test plugin available to the Qt launcher.
2728
2729         * Scripts/run-launcher:
2730
2731 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2732
2733         Reviewed by David Levin.
2734
2735         Removed WebSocket runtime settings.
2736         https://bugs.webkit.org/show_bug.cgi?id=29896
2737
2738         WebSocket runtime configuration is supported by chromium/v8 only.
2739
2740         * DumpRenderTree/mac/DumpRenderTree.mm:
2741         (resetDefaultsToConsistentValues):
2742         * DumpRenderTree/win/DumpRenderTree.cpp:
2743         (resetDefaultsToConsistentValues):
2744
2745 2009-10-19  Nate Chapin  <japhet@chromium.org>
2746
2747         Reviewed by Adam Barth.
2748
2749         Add testFail() to test plugin so we can test our handling of a
2750         plugin invoke call returning false.
2751
2752         https://bugs.webkit.org/show_bug.cgi?id=30239
2753
2754         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2755         (pluginInvoke):
2756         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2757
2758 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2759
2760         Reviewed by Gustavo Noronha.
2761
2762         Enable DOM pasting when running layout tests.
2763
2764         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2765         (resetDefaultsToConsistentValues):
2766
2767 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2768
2769         Reviewed by Simon Hausmann.
2770
2771         Use the setPreferredContentsSize method instead
2772         of setFixedContentsSize, as the method has been renamed.
2773
2774         * DumpRenderTree/qt/DumpRenderTree.cpp:
2775         (WebCore::DumpRenderTree::open):
2776         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2777         (LayoutTestController::setFixedContentsSize):
2778
2779 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2780
2781         Reviewed by Dan Bernstein.
2782
2783         https://bugs.webkit.org/show_bug.cgi?id=30456
2784         Fixes for new Debug_All Windows build configuration.
2785
2786         * DumpRenderTree/win/DumpRenderTree.cpp:
2787         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2788         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2789
2790 2009-10-16  Eric Seidel  <eric@webkit.org>
2791
2792         Reviewed by Adam Barth.
2793
2794         commit-queue status bot should list which buildbot is blocking the queue
2795         https://bugs.webkit.org/show_bug.cgi?id=30452
2796
2797         Add new methods and testing.
2798
2799         * Scripts/bugzilla-tool:
2800         * Scripts/modules/buildbot.py:
2801         * Scripts/modules/buildbot_unittest.py:
2802
2803 2009-10-16  Eric Seidel  <eric@webkit.org>
2804
2805         Reviewed by Adam Barth.
2806
2807         run-webkit-tests fails when CWD is not inside a WebKit checkout
2808         https://bugs.webkit.org/show_bug.cgi?id=30451
2809
2810         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2811         * Scripts/modules/scm_unittest.py:
2812           - Remove use of original_path (we don't need to restore the CWD).
2813           - Don't use '.' to find the webkit checkout, use __file__ instead.
2814
2815 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2816
2817         Reviewed by Adam Roben.
2818
2819         Add a Debug_All configuration to build entire stack as debug.
2820         Change Debug_Internal to:
2821         - stop using _debug suffix for all WebKit/Safari binaries
2822         - not use _debug as a DLL naming suffix
2823         - use non-debug C runtime lib.
2824
2825         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2826         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2827         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2828         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2829         Add missing debug.vsprops inherited property sheet.
2830         Add Debug_All configuration.
2831         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2832         * WinLauncher/WinLauncher.vcproj:
2833         Removed extraneous definitions inherited from vsprops.
2834         Add Debug_All configuration.
2835
2836 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2837
2838         Reviewed by David Levin.
2839
2840         check-webkit-style is wrong about indent checking in namespaces
2841         in header files and a few other things
2842         https://bugs.webkit.org/show_bug.cgi?id=30362
2843
2844         The few other things include:
2845         + check-webkit-style does not require spaces around the equal sign
2846           inside 'if' statements and around binary operators that take 
2847           numeric literals.
2848         + check-webkit-style reports false errors for the / operator
2849           when part of a filename in the #include directive.
2850
2851         * Scripts/modules/cpp_style.py:
2852         Improved indentation checking and space checking around
2853         binary operators. While the checks are still not perfect,
2854         they are clearly better than before.
2855         * Scripts/modules/cpp_style_unittest.py:
2856         Added test cases for the newly supported checks and modified old
2857         test cases to match the new guidelines
2858
2859 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2860
2861         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2862
2863         * wx/build/settings.py:
2864
2865 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2866
2867         Reviewed by David Levin.
2868
2869         Add mod_pywebsocket to test Web Sockets.
2870         http://code.google.com/p/pywebsocket/
2871         https://bugs.webkit.org/show_bug.cgi?id=27490
2872
2873         * pywebsocket/COPYING: Added.
2874         * pywebsocket/MANIFEST.in: Added.
2875         * pywebsocket/README: Added.
2876         * pywebsocket/example/echo_client.py: Added.
2877         * pywebsocket/example/echo_wsh.py: Added.
2878         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2879         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2880         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2881         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2882         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2883         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2884         * pywebsocket/mod_pywebsocket/util.py: Added.
2885         * pywebsocket/setup.py: Added.
2886         * pywebsocket/test/config.py: Added.
2887         * pywebsocket/test/mock.py: Added.
2888         * pywebsocket/test/run_all.py: Added.
2889         * pywebsocket/test/test_dispatch.py: Added.
2890         * pywebsocket/test/test_handshake.py: Added.
2891         * pywebsocket/test/test_mock.py: Added.
2892         * pywebsocket/test/test_msgutil.py: Added.
2893         * pywebsocket/test/test_util.py: Added.
2894         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2895         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2896         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2897         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2898         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2899         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2900         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2901         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2902
2903 2009-10-15  James Robinson  <jamesr@google.com>
2904
2905         Reviewed by David Levin.
2906
2907         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2908
2909         https://bugs.webkit.org/show_bug.cgi?id=30426
2910
2911         * Scripts/modules/cpp_style.py:
2912         * Scripts/modules/cpp_style_unittest.py:
2913
2914 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2915
2916         Reviewed by Adam Roben.
2917
2918         Fixes <http://webkit.org/b/30411>.
2919         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2920         
2921         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2922         building Chromium.
2923
2924         * Scripts/pdevenv:
2925
2926 2009-10-15  Robin Dunn  <robin@alldunn.com>
2927
2928         Reviewed by Kevin Ollivier.
2929
2930         Add Mac package building scripts for wx.
2931         
2932         https://bugs.webkit.org/show_bug.cgi?id=30405
2933
2934         * wx/build/build_utils.py:
2935         * wx/build/settings.py:
2936         * wx/packaging/build-mac-installer.py: Added.
2937
2938 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2939
2940         Reviewed by Gustavo Noronha.
2941
2942         Enable Web Sockets support when running layout tests.
2943
2944         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2945         (resetDefaultsToConsistentValues):
2946
2947 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2948
2949         Reviewed by Gustavo Noronha.
2950
2951         Need to initialize event.button.button, since in most cases a
2952         button number is not passed as an argument.
2953
2954         * DumpRenderTree/gtk/EventSender.cpp:
2955         (mouseDownCallback):
2956         (mouseUpCallback):
2957
2958 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2959
2960         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2961         the OS if none was explicitly set.
2962
2963         * wx/build/settings.py:
2964
2965 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2966
2967         Reviewed by Timothy Hatcher.
2968
2969         Web Inspector: enable developers extras within inspector layout tests.
2970
2971         https://bugs.webkit.org/show_bug.cgi?id=30014
2972
2973         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2974         (LayoutTestController::showWebInspector):
2975         (LayoutTestController::closeWebInspector):
2976         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2977         (LayoutTestController::showWebInspector):
2978         (LayoutTestController::closeWebInspector):
2979
2980 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2981
2982         Reviewed by Jan Alonzo.
2983
2984         GtkLauncher is using a deprecated signal
2985         https://bugs.webkit.org/show_bug.cgi?id=30364
2986
2987         Modified GtkLauncher to use notify::title signal instead of
2988         deprecated title-changed signal
2989
2990         * GtkLauncher/main.c:
2991         (notify_title_cb):
2992         (create_browser):
2993
2994 2009-10-14  Brady Eidson  <beidson@apple.com>
2995
2996         Reviewed by Sam Weinig.
2997
2998         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2999         1 - Disables WebHistory
3000         2 - Doesn't make sense in that context anyway.
3001
3002         * DumpRenderTree/win/DumpRenderTree.cpp:
3003         (createWebViewAndOffscreenWindow):
3004
3005 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3006
3007         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3008         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3009
3010         * wx/build/settings.py:
3011         * wx/install-unix-extras:
3012
3013 2009-10-14  Brady Eidson  <beidson@apple.com>
3014
3015         Reviewed by Sam Weinig.
3016
3017         WebKit Win API should provide a delegate interface for global history.
3018         https://bugs.webkit.org/show_bug.cgi?id=29905
3019
3020         * DumpRenderTree/LayoutTestController.cpp:
3021         (LayoutTestController::LayoutTestController):
3022         * DumpRenderTree/LayoutTestController.h:
3023         (LayoutTestController::dumpHistoryDelegateCallbacks):
3024         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3025                 
3026         * DumpRenderTree/win/DumpRenderTree.cpp:
3027         (shouldLogHistoryDelegates):
3028         (runTest):
3029         (createWebViewAndOffscreenWindow):
3030         (main):
3031         * DumpRenderTree/win/DumpRenderTree.vcproj:
3032         
3033         Add the IWebHistoryDelegate to DRT Windows:
3034         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3035         (wstringFromBSTR):
3036         (HistoryDelegate::HistoryDelegate):
3037         (HistoryDelegate::~HistoryDelegate):
3038         (HistoryDelegate::QueryInterface):
3039         (HistoryDelegate::AddRef):
3040         (HistoryDelegate::Release):
3041         (HistoryDelegate::didNavigateWithNavigationData):
3042         (HistoryDelegate::didPerformClientRedirectFromURL):
3043         (HistoryDelegate::didPerformServerRedirectFromURL):
3044         (HistoryDelegate::updateHistoryTitle):
3045         (HistoryDelegate::populateVisitedLinksForWebView):
3046         * DumpRenderTree/win/HistoryDelegate.h: Added.
3047
3048         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3049         (LayoutTestController::removeAllVisitedLinks):
3050
3051 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3052
3053         Reviewed by Simon Hausmann.
3054
3055         [Qt] Implement support for setPOSIXLocale on Qt.
3056         https://bugs.webkit.org/show_bug.cgi?id=30268 
3057  
3058         * DumpRenderTree/qt/DumpRenderTree.cpp:
3059         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3060         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3061         (LayoutTestController::setPOSIXLocale):
3062         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3063
3064 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3065
3066         Unreviewed, adding myself to reviewers list.
3067
3068         * Scripts/modules/committers.py:
3069
3070 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3071
3072         Reviewed by Mark Rowe.
3073
3074         Fix null assignment so root tests work again.
3075
3076         * Scripts/webkitdirs.pm:
3077
3078 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3079
3080         Reviewed by Simon Hausmann.
3081
3082         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3083         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3084         This is done in preparation of implementing missing features in DRT.
3085         No functionality changes made yet.
3086
3087         * DumpRenderTree/qt/DumpRenderTree.cpp:
3088         * DumpRenderTree/qt/DumpRenderTree.pro:
3089         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3090         (EventSender::EventSender):
3091         (EventSender::mouseDown):
3092         (EventSender::mouseUp):
3093         (EventSender::mouseMoveTo):
3094         (EventSender::leapForward):
3095         (EventSender::keyDown):
3096         (EventSender::contextClick):
3097         (EventSender::scheduleAsynchronousClick):
3098         (EventSender::frameUnderMouse):
3099         * DumpRenderTree/qt/EventSenderQt.h: Added.
3100         (EventSender::clearKillRing):
3101         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3102         (LayoutTestController::LayoutTestController):
3103         (LayoutTestController::reset):
3104         (LayoutTestController::processWork):
3105         (LayoutTestController::maybeDump):
3106         (LayoutTestController::waitUntilDone):
3107         (LayoutTestController::notifyDone):
3108         (LayoutTestController::windowCount):
3109         (LayoutTestController::clearBackForwardList):
3110         (LayoutTestController::dumpEditingCallbacks):
3111         (LayoutTestController::dumpResourceLoadCallbacks):
3112         (LayoutTestController::queueBackNavigation):
3113         (LayoutTestController::queueForwardNavigation):
3114         (LayoutTestController::queueLoad):
3115         (LayoutTestController::queueReload):
3116         (LayoutTestController::queueScript):
3117         (LayoutTestController::provisionalLoad):
3118         (LayoutTestController::timerEvent):
3119         (LayoutTestController::encodeHostName):
3120         (LayoutTestController::decodeHostName):
3121         (LayoutTestController::setJavaScriptProfilingEnabled):
3122         (LayoutTestController::setFixedContentsSize):
3123         (LayoutTestController::setPrivateBrowsingEnabled):
3124         (LayoutTestController::setPopupBlockingEnabled):
3125         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3126         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3127         (LayoutTestController::numberOfActiveAnimations):
3128         (LayoutTestController::disableImageLoading):
3129         (LayoutTestController::dispatchPendingLoadRequests):
3130         (LayoutTestController::setDatabaseQuota):
3131         (LayoutTestController::clearAllDatabases):
3132         (LayoutTestController::whiteListAccessFromOrigin):
3133         (LayoutTestController::waitForPolicyDelegate):
3134         (LayoutTestController::overridePreference):
3135         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3136         (LayoutTestController::isLoading):
3137         (LayoutTestController::setLoading):
3138         (LayoutTestController::shouldDumpAsText):
3139         (LayoutTestController::shouldDumpBackForwardList):
3140         (LayoutTestController::shouldDumpChildrenAsText):
3141         (LayoutTestController::shouldDumpDatabaseCallbacks):
3142         (LayoutTestController::shouldDumpStatusCallbacks):
3143         (LayoutTestController::shouldWaitUntilDone):
3144         (LayoutTestController::canOpenWindows):
3145         (LayoutTestController::shouldDumpTitleChanges):
3146         (LayoutTestController::waitForPolicy):
3147         (LayoutTestController::dumpAsText):
3148         (LayoutTestController::dumpChildFramesAsText):
3149         (LayoutTestController::dumpDatabaseCallbacks):
3150         (LayoutTestController::dumpStatusCallbacks):
3151         (LayoutTestController::setCanOpenWindows):
3152         (LayoutTestController::dumpBackForwardList):
3153         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3154         (LayoutTestController::display):
3155         (LayoutTestController::dumpTitleChanges):
3156         (LayoutTestController::dumpSelectionRect):
3157         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3158         (TextInputController::TextInputController):
3159         (TextInputController::doCommand):
3160         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3161         * DumpRenderTree/qt/WorkQueue.cpp:
3162         * DumpRenderTree/qt/WorkQueue.h:
3163         * DumpRenderTree/qt/WorkQueueItem.h:
3164         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3165         (findFrameNamed):
3166         (LoadItem::invoke):
3167         (ReloadItem::invoke):
3168         (ScriptItem::invoke):
3169         (BackForwardItem::invoke):
3170         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3171         * DumpRenderTree/qt/jsobjects.h:
3172
3173 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3174
3175         Not reviewed, adding myself to the list of reviewers.
3176
3177         * Scripts/modules/committers.py:
3178
3179 2009-10-13  Anders Carlsson  <andersca@apple.com>
3180
3181         Reviewed by Sam Weinig.
3182
3183         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3184
3185         Make the private browsing mode testable by the test plug-in.
3186         
3187         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3188         (pluginGetProperty):
3189         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3190         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3191         (NPP_New):
3192         (NPP_SetValue):
3193
3194 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3195
3196         No review, just adding self to the list of reviewers.
3197
3198         * Scripts/modules/committers.py:
3199
3200 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3201
3202         Reviewed by Adam Roben.
3203
3204         Web Inspector: Use proper web view in inspector layout
3205         tests for windows.
3206
3207         https://bugs.webkit.org/show_bug.cgi?id=30298
3208
3209         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3210         (LayoutTestController::showWebInspector):
3211         (LayoutTestController::closeWebInspector):
3212         (LayoutTestController::evaluateInWebInspector):
3213
3214 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3215
3216         Reviewed by Sam Weinig.
3217
3218         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3219         https://bugs.webkit.org/show_bug.cgi?id=29841
3220
3221         * DumpRenderTree/mac/DumpRenderTree.mm:
3222         (resetDefaultsToConsistentValues):
3223         * DumpRenderTree/win/DumpRenderTree.cpp:
3224         (resetDefaultsToConsistentValues):
3225
3226 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3227
3228         Reviewed by Dimitri Glazkov.
3229
3230         Chromium Port - Windows
3231         https://bugs.webkit.org/show_bug.cgi?id=29969
3232
3233         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3234         * Scripts/webkitdirs.pm:
3235
3236 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3237
3238         Reviewed by Darin Adler.
3239
3240         jsc scripts cleanup and Qt/GTK fix
3241         https://bugs.webkit.org/show_bug.cgi?id=30288
3242
3243         Duplicated jscPath() moved to webkitdirs.pm.
3244         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3245         Configuration added (release/debug) to path for Qt-port on Windows.
3246
3247         * Scripts/run-javascriptcore-tests:
3248         * Scripts/run-jsc:
3249         * Scripts/run-sunspider:
3250         * Scripts/sunspider-compare-results:
3251         * Scripts/webkitdirs.pm:
3252
3253 2009-10-11  Adam Barth  <abarth@webkit.org>
3254
3255         Unreviewed.  Add Collin to committers.py.
3256
3257         * Scripts/modules/committers.py:
3258
3259 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3260
3261         wx build fix, add bindings to source/include dirs now that there are sources there.
3262
3263         * wx/build/settings.py:
3264
3265 2009-10-09  Mark Rowe  <mrowe@apple.com>
3266
3267         Reviewed by Brady Eidson.
3268
3269         Enable plug-in halting in DumpRenderTree.
3270
3271         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3272         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3273
3274         * DumpRenderTree/mac/DumpRenderTree.mm:
3275         (resetDefaultsToConsistentValues):
3276         * DumpRenderTree/mac/UIDelegate.mm:
3277         (-[UIDelegate webView:shouldHaltPlugin:]):
3278
3279 2009-10-08  Brady Eidson  <beidson@apple.com>
3280
3281         Reviewed by Dan Bernstein.
3282
3283         Ask the History Delegate to populate the visited links hash.
3284         <rdar://problem/7285293> and https://webkit.org/b/29904
3285
3286         Add the ability for LayoutTestController to clear all visited links.
3287         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3288
3289         * DumpRenderTree/LayoutTestController.cpp:
3290         (LayoutTestController::LayoutTestController):
3291         (removeAllVisitedLinksCallback):
3292         (LayoutTestController::staticFunctions):
3293         * DumpRenderTree/LayoutTestController.h:
3294         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3295         (LayoutTestController::removeAllVisitedLinks):
3296
3297         * DumpRenderTree/mac/HistoryDelegate.mm:
3298         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3299
3300         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3301         (LayoutTestController::removeAllVisitedLinks):
3302         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3303         (LayoutTestController::removeAllVisitedLinks):
3304         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3305         (LayoutTestController::removeAllVisitedLinks):
3306
3307
3308 2009-10-08  Daniel Bates  <dbates@webkit.org>
3309
3310         Reviewed by Adam Roben.
3311
3312         https://bugs.webkit.org/show_bug.cgi?id=30175
3313         
3314         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3315         the OLE drag-and-drop return value like the function it emulates. Currently, 
3316         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3317         whether the drag-and-drop operation was successful or was cancelled.
3318         
3319         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3320         return value according to whether the drop operation was successful or not.
3321
3322         * DumpRenderTree/win/EventSender.cpp:
3323         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3324         (replaySavedEvents): Ditto.
3325         * DumpRenderTree/win/EventSender.h:
3326         * DumpRenderTree/win/UIDelegate.cpp:
3327         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3328
3329 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3330
3331         Reviewed by Xan Lopez.
3332
3333         [GTK] Added support for a parameter setting the button that was
3334         pressed in the mouseDown function.
3335         https://bugs.webkit.org/show_bug.cgi?id=30220
3336
3337         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3338
3339 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3340
3341         Reviewed by Xan Lopez.
3342
3343         [GTK] Added a line to the bottom of the expected result to match
3344         the output of the test.
3345         https://bugs.webkit.org/show_bug.cgi?id=30220
3346
3347         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3348         expected.txt:
3349
3350 2009-10-08  Adam Roben  <aroben@apple.com>
3351
3352         Use QueryInterface to get IWebInspectorPrivate
3353
3354         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3355         accessed in a more standard way
3356
3357         Reviewed by John Sullivan and Tim Hatcher.
3358
3359         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3360         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3361         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3362         to the IWebInspectorPrivate interface.
3363
3364 2009-10-07  Adam Roben  <aroben@apple.com>
3365
3366         Implement DRT support for origin whitelisting
3367
3368         Fixes <http://webkit.org/b/30185>.
3369
3370         Reviewed by Eric Seidel.
3371
3372         * DumpRenderTree/win/DumpRenderTree.cpp:
3373         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3374         whitelist, to match Mac DRT.
3375         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3376         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3377         IWebViewPrivate::whiteListAccessFromOrigin.
3378
3379 2009-10-07  Brady Eidson  <beidson@apple.com>
3380
3381         Reviewed by Darin Adler.
3382
3383         Send title changes to the global history delegate.
3384         <rdar://problem/7285293> and https://webkit.org/b/29904
3385
3386         * DumpRenderTree/mac/HistoryDelegate.mm:
3387         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3388
3389 2009-10-07  Adam Barth  <abarth@webkit.org>
3390
3391         Unreviewed.  Remove some folks from committers.py who were listed on
3392         the WebKit Team wiki page but who weren't actually listed as commit+.
3393         At some point, we should coorelate this list with the committers
3394         mailing list.
3395
3396         * Scripts/modules/committers.py:
3397
3398 2009-10-07  Adam Barth  <abarth@webkit.org>
3399
3400         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3401         the wiki into committers.py.
3402
3403         * Scripts/modules/committers.py:
3404
3405 2009-10-07  Adam Barth  <abarth@webkit.org>
3406
3407         Unreviewed.  Added Aaron Boodman to committers.py.
3408
3409         * Scripts/modules/committers.py:
3410
3411 2009-10-07  Evan Martin  <evan@chromium.org>
3412
3413         Reviewed by Darin Adler.
3414
3415         Add API to LayoutTestController for re/setting the system locale.
3416         https://bugs.webkit.org/show_bug.cgi?id=18994
3417
3418         * DumpRenderTree/LayoutTestController.cpp:
3419         (setLocaleCallback):
3420         (LayoutTestController::staticFunctions):
3421         (LayoutTestController::setLocale):
3422         * DumpRenderTree/LayoutTestController.h:
3423
3424 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3425
3426         Reviewed by Jan Alonzo.
3427
3428         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3429         https://bugs.webkit.org/show_bug.cgi?id=29689
3430
3431         Build fix by adding -lfontconfig for DumpRenderTree.
3432
3433         * GNUmakefile.am:
3434
3435 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3436
3437         Reviewed by Simon Hausmann.
3438
3439         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3440
3441         * Scripts/run-webkit-tests:
3442
3443 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3444
3445         Reviewed by Gustavo Noronha.
3446
3447         "delete" in EventSender is the backspace key, not the delete one.
3448
3449         * DumpRenderTree/gtk/EventSender.cpp:
3450         (keyDownCallback):
3451
3452 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3453
3454         Reviewed by Gustavo Noronha.
3455
3456         getChildrenWithRange expects as last parameter the end index, not
3457         the length of the range. Correct this and clarify the variable
3458         names to reflect how the code works.
3459
3460         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3461         (AccessibilityUIElement::getChildrenWithRange):
3462         (AccessibilityUIElement::getChildAtIndex):
3463
3464 2009-10-06  Mark Rowe  <mrowe@apple.com>
3465
3466         Reviewed by Simon Fraser.
3467
3468         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3469
3470         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3471         the fact we have already changed the working directory to the top of the open source tree.
3472
3473 2009-10-06  Julie Parent  <jparent@chromium.org>
3474
3475         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3476         rather than my committer email.
3477
3478         * Scripts/modules/committers.py:
3479
3480 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3481
3482         Reviewed by Eric Seidel.
3483
3484         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3485
3486         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3487         it after each layout test as it should do, making the DRT dump additional output
3488         for all of the subsequent layout tests.
3489
3490         * DumpRenderTree/qt/jsobjects.cpp:
3491         (LayoutTestController::reset):
3492
3493 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3494
3495         Reviewed by Simon Hausmann.
3496
3497         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3498         fast/dom/assign-to-window-status.html test, which is passing as a result.
3499
3500         https://bugs.webkit.org/show_bug.cgi?id=30127
3501
3502         * DumpRenderTree/qt/DumpRenderTree.cpp:
3503         (WebCore::DumpRenderTree::DumpRenderTree):
3504         (WebCore::DumpRenderTree::statusBarMessage):
3505         * DumpRenderTree/qt/DumpRenderTree.h:
3506         * DumpRenderTree/qt/jsobjects.h:
3507         (LayoutTestController::shouldDumpStatusCallbacks):
3508         (LayoutTestController::dumpStatusCallbacks):
3509
3510 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3511
3512         Reviewed by Simon Hausmann.
3513
3514         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3515         ignores the argument indicating which mouse button to trigger.
3516         https://bugs.webkit.org/show_bug.cgi?id=30048
3517
3518         This affects the fast/events/mouse-click-events.html layout test.
3519
3520         * DumpRenderTree/qt/jsobjects.cpp:
3521         (EventSender::mouseDown):
3522         (EventSender::mouseUp):
3523         * DumpRenderTree/qt/jsobjects.h:
3524
3525 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3526
3527         Reviewed by Simon Hausmann.
3528
3529         [Qt] Fix the EventSender::keyDown() implementation
3530         https://bugs.webkit.org/show_bug.cgi?id=30043
3531
3532         It should post both a key press event and a key release event,
3533         just like other ports do.
3534
3535         * DumpRenderTree/qt/jsobjects.cpp:
3536         (EventSender::keyDown):
3537
3538 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3539
3540         wx build fix. Add jpeg to the list of libs to link against.
3541
3542         * wx/build/settings.py:
3543
3544 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3545
3546         Reviewed by Simon Hausmann.
3547
3548         [Qt] EventSender::keyDown() cannot send function-key events.
3549         https://bugs.webkit.org/show_bug.cgi?id=30044
3550
3551         This affects the fast/events/keydown-function-keys.html layout test.
3552
3553         * DumpRenderTree/qt/jsobjects.cpp:
3554         (EventSender::keyDown):
3555
3556 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3557
3558         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3559         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3560
3561         * wx/build/settings.py:
3562         * wx/build/wxpresets.py:
3563
3564 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3565
3566         Reviewed by Timothy Hatcher.
3567
3568         Web Inspector: add testing harness for Web Inspector.
3569
3570         https://bugs.webkit.org/show_bug.cgi?id=30010
3571
3572         * DumpRenderTree/LayoutTestController.cpp:
3573         (showWebInspectorCallback):
3574         (closeWebInspectorCallback):
3575         (evaluateInWebInspectorCallback):
3576         (LayoutTestController::staticFunctions):
3577         * DumpRenderTree/LayoutTestController.h:
3578         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3579         (LayoutTestController::showWebInspector):
3580         (LayoutTestController::closeWebInspector):
3581         (LayoutTestController::evaluateInWebInspector):
3582         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3583         (LayoutTestController::showWebInspector):
3584         (LayoutTestController::closeWebInspector):
3585         (LayoutTestController::evaluateInWebInspector):
3586         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3587         (LayoutTestController::showWebInspector):
3588         (LayoutTestController::closeWebInspector):
3589         (LayoutTestController::evaluateInWebInspector):
3590         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3591         (LayoutTestController::showWebInspector):
3592         (LayoutTestController::closeWebInspector):
3593         (LayoutTestController::evaluateInWebInspector):
3594
3595 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3596
3597         Reviewed by Ariyha Hidayat.
3598
3599         Pass arguments to system() as a string instead of array
3600
3601         When passed as an array entries with a space fail to translate
3602         to two arguments to the child process, so instead of manually
3603         splitting all the entries in @buildArgs we pass the whole thing
3604         as a string instead.
3605
3606         * Scripts/webkitdirs.pm:
3607
3608 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3609
3610         Reviewed by David Levin.
3611
3612         check-webkit-style misses whitespace errors for operators:
3613         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3614         https://bugs.webkit.org/show_bug.cgi?id=30021
3615
3616         * Scripts/modules/cpp_style.py:
3617         Added the operators mentioned above to the same list as == and !=.
3618
3619 2009-10-02  Julie Parent  <jparent@chromium.org>
3620
3621         Unreviewed.
3622
3623         Adding myself and Ojan Vafai as committers, because we are committers.
3624
3625         * Scripts/modules/committers.py:
3626
3627 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3628
3629         Reviewed by Adam Roben.
3630
3631         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3632         this will help the patch merging process when TryBots are used.
3633
3634         * Scripts/svn-create-patch:
3635
3636 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3637
3638         Reviewed by Simon Hausmann.
3639
3640         [Qt] Implement layoutTestController.overridePreference().
3641         https://bugs.webkit.org/show_bug.cgi?id=29970
3642
3643         * DumpRenderTree/qt/DumpRenderTree.cpp:
3644         (WebCore::WebPage::WebPage):
3645         (WebCore::WebPage::resetSettings):
3646         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3647         * DumpRenderTree/qt/jsobjects.cpp:
3648         (LayoutTestController::reset):
3649         (LayoutTestController::setPrivateBrowsingEnabled):
3650         (LayoutTestController::setPopupBlockingEnabled):
3651         (LayoutTestController::overridePreference):
3652         * DumpRenderTree/qt/jsobjects.h:
3653
3654 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3655
3656         Reviewed by Oliver Hunt.
3657
3658         Turn on ENABLE_3D_CANVAS in TOT
3659         https://bugs.webkit.org/show_bug.cgi?id=29906
3660
3661         * Scripts/build-webkit:
3662
3663 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3664
3665         Rubberstamped by Simon Hausmann.
3666
3667         Enable HTTP tests for Qt
3668
3669         * Scripts/run-webkit-tests:
3670
3671 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3672
3673         Reviewed by Dimitri Glazkov.
3674
3675         build-webkit --chromium now also works on cygwin.
3676
3677         https://bugs.webkit.org/show_bug.cgi?id=29973
3678
3679         * Scripts/webkitdirs.pm:
3680
3681 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3682
3683         Reviewed by Simon Hausmann.
3684
3685         [Qt] Don't use TCmalloc in DumpRenderTree
3686         https://bugs.webkit.org/show_bug.cgi?id=27029
3687
3688         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3689
3690<