2009-11-26 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-26  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         [bzt] Kill WebKitLandingScripts
6         https://bugs.webkit.org/show_bug.cgi?id=31904
7
8         Step 3: Kill build_webkit.
9
10         * Scripts/modules/buildsteps.py:
11         * Scripts/modules/landingsequence.py:
12         * Scripts/modules/webkitlandingscripts.py:
13
14 2009-11-26  Adam Barth  <abarth@webkit.org>
15
16         Reviewed by Eric Seidel.
17
18         [bzt] Kill WebKitLandingScripts
19         https://bugs.webkit.org/show_bug.cgi?id=31904
20
21         Step 2: Kill ensure_builders_are_green.
22
23         * Scripts/modules/buildsteps.py:
24         * Scripts/modules/commands/download.py:
25         * Scripts/modules/landingsequence.py:
26         * Scripts/modules/webkitlandingscripts.py:
27
28 2009-11-26  Adam Barth  <abarth@webkit.org>
29
30         Reviewed by Eric Seidel.
31
32         [bzt] Kill WebKitLandingScripts
33         https://bugs.webkit.org/show_bug.cgi?id=31904
34
35         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
36
37         * Scripts/bugzilla-tool:
38         * Scripts/modules/buildsteps.py: Added.
39         * Scripts/modules/commands/download.py:
40         * Scripts/modules/landingsequence.py:
41         * Scripts/modules/webkitlandingscripts.py:
42
43 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
44
45         Reviewed by Adam Barth.
46
47         Remove directory prefixes from linux commands
48
49         SCM unittests can cause errors on some systems if we use absolute reference to
50         the commands, so directory prefixes have been removed.
51
52         * Scripts/modules/scm_unittest.py:
53
54 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
55
56         Reviewed by Kenneth Rohde Christiansen.
57
58         Link DumpRenderTree to the Qt Ui Tools
59         https://bugs.webkit.org/show_bug.cgi?id=31203
60
61         Implement QWebPage::createPlugin using the Qt Ui Tools
62         to be able to create classes like QProgressBar from within
63         the <object></object> tags This is required for the
64         new automatic test of Qt Plugins.
65
66         * DumpRenderTree/qt/DumpRenderTree.cpp:
67         (WebCore::WebPage::createPlugin):
68         * DumpRenderTree/qt/DumpRenderTree.h:
69         * DumpRenderTree/qt/DumpRenderTree.pro:
70
71 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
72
73         Reviewed by Eric Seidel.
74
75         Update pywebsocket to 0.4.2
76
77         Update pywebsocket to 0.4.2
78         https://bugs.webkit.org/show_bug.cgi?id=31861
79
80         * pywebsocket/example/echo_client.py:
81         * pywebsocket/example/echo_wsh.py:
82         * pywebsocket/mod_pywebsocket/__init__.py:
83         * pywebsocket/mod_pywebsocket/dispatch.py:
84         * pywebsocket/mod_pywebsocket/msgutil.py:
85         * pywebsocket/mod_pywebsocket/standalone.py:
86         * pywebsocket/setup.py:
87         * pywebsocket/test/test_dispatch.py:
88         * pywebsocket/test/test_msgutil.py:
89
90 2009-11-25  Adam Barth  <abarth@webkit.org>
91
92         Reviewed by Eric Seidel.
93
94         Add unit test for mark-fixed
95         https://bugs.webkit.org/show_bug.cgi?id=31896
96
97         * Scripts/modules/commands/commandtest.py: Added.
98         * Scripts/modules/commands/queries_unittest.py:
99         * Scripts/modules/commands/upload_unittest.py: Added.
100         * Scripts/modules/mock_bugzillatool.py:
101         * Scripts/run-webkit-unittests:
102
103 2009-11-25  Adam Barth  <abarth@webkit.org>
104
105         Reviewed by Eric Seidel.
106
107         bugzilla-tool should have a mark-fixed command
108         https://bugs.webkit.org/show_bug.cgi?id=31853
109
110         Pretty simple stuff.
111
112         * Scripts/modules/commands/upload.py:
113
114 2009-11-25  Eric Seidel  <eric@webkit.org>
115
116         Reviewed by Adam Barth.
117
118         'bugzilla-tool help' should only show common commands like how 'git help' does
119         https://bugs.webkit.org/show_bug.cgi?id=31772
120
121         I also took this opportunity to make 'help' a real Command.
122         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
123
124         * Scripts/bugzilla-tool:
125          - change should_show_command_help to should_show_in_main_help
126         * Scripts/modules/commands/download.py:
127          - Mark commands as being shown in main help or not.
128          - show_in_main_help = False is not required (default is false),
129            but it seemed to make the commands more self-documenting.
130         * Scripts/modules/commands/queries.py: ditto
131         * Scripts/modules/commands/queues.py: ditto
132         * Scripts/modules/commands/upload.py: ditto
133         * Scripts/modules/multicommandtool.py:
134          - Make Command hold a pointer to tool in self.tool.  Most Command
135            subclasses do not take advantage of this yet, but it was required
136            for HelpCommand to be able to reach the tool from _help_epilog().
137          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
138          - Move MultiCommandTool._help_epilog to Command._help_epilog
139          - Move "help" logic into HelpCommand.execute()
140          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
141         * Scripts/modules/multicommandtool_unittest.py:
142          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
143
144 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
145
146         Reviewed by Dan Bernstein.
147         
148         Patch by Mark Rowe.
149
150         The buildbots are failing on Windows because when they were upgraded
151         to 4.0.4, Apple Application Support was not in their path. Add it to
152         the path to fix the buildots.
153
154         * Scripts/webkitdirs.pm:
155
156 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
157
158         Reviewed by David Kilzer.
159
160         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
161         https://bugs.webkit.org/show_bug.cgi?id=31799
162
163         * Scripts/run-webkit-tests: Fixed.
164
165 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
166
167         Reviewed by Eric Seidel.
168
169         Change run_command to give back stderr by default
170         https://bugs.webkit.org/show_bug.cgi?id=31734
171
172         Change run_command to give back stderr by default.
173         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
174         Change the related unittest call.
175
176         * Scripts/modules/scm.py:
177         * Scripts/modules/scm_unittest.py:
178
179 2009-11-25  Eric Seidel  <eric@webkit.org>
180
181         Reviewed by Adam Barth.
182
183         Centralize required argument parsing in Command
184         https://bugs.webkit.org/show_bug.cgi?id=31872
185
186         * Scripts/modules/commands/download.py: remove custom required arg message.
187         * Scripts/modules/commands/upload.py: ditto.
188         * Scripts/modules/multicommandtool.py:
189          - Add _parse_required_arguments.
190          - Pass program name off to OptionParser.
191          - Add name() for access to tool name.
192          - Add check_arguments_and_execute and make it return a return code.
193          - Replace a couple uses of + with %.
194         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
195
196 2009-11-25  Eric Seidel  <eric@webkit.org>
197
198         Reviewed by Adam Barth.
199
200         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
201         https://bugs.webkit.org/show_bug.cgi?id=31870
202
203         * Scripts/modules/commands/queries_unittest.py: Use the new class.
204         * Scripts/modules/multicommandtool_unittest.py: Ditto.
205         * Scripts/modules/outputcapture.py: Added.
206
207 2009-11-24  Dmitry Titov  <dimich@chromium.org>
208
209         Reviewed by Eric Seidel.
210
211         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
212         https://bugs.webkit.org/show_bug.cgi?id=31444
213
214         * Scripts/build-webkit:
215
216 2009-11-24  Chris Marrin  <cmarrin@apple.com>
217
218         Reviewed by Simon Fraser.
219
220         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
221         https://bugs.webkit.org/show_bug.cgi?id=27314
222         
223         Now the script allows the directories with these tests to be included on all
224         platforms but Mac, where they behave the same as always. For all other platforms
225         the tests need to be excluded using the Skipped files, which is currently done
226         for all platforms (including win since we're not turned on yet)
227
228         * Scripts/webkitdirs.pm:
229
230 2009-11-24  Eric Seidel  <eric@webkit.org>
231
232         Reviewed by Adam Barth.
233
234         queries_unittest.py should test command output
235         https://bugs.webkit.org/show_bug.cgi?id=31845
236
237         * Scripts/modules/commands/queries_unittest.py:
238          - Capture stdout and stderr and compare with expected strings.
239
240 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
241
242         No Review.
243
244         Fix spelling error ("depenedencies").
245
246         * Scripts/build-webkit:
247
248 2009-11-24  Mark Rowe  <mrowe@apple.com>
249
250         Land the configuration that includes the two debug GTK Linux builders.
251
252         * BuildSlaveSupport/build.webkit.org-config/config.json:
253
254 2009-11-24  David Kilzer  <ddkilzer@apple.com>
255
256         <http://webkit.org/b/31840> bisect-builds broke after r50080
257
258         Reviewed by Dan Bernstein.
259
260         * Scripts/bisect-builds:
261         (mountAndRunNightly): Switched back to using backticks to run
262         the hdiutil command since exec() will terminate the existing
263         script, which is not what we want.  Store the output of
264         File::Spec->devnull() in a variable for use in the hdiutil
265         detach commands.
266
267 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
268
269         Reviewed by Kenneth Rohde Christiansen.
270
271         Include "config.h" to meet Coding Style Guidelines
272         https://bugs.webkit.org/show_bug.cgi?id=31792
273
274         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
275         * DumpRenderTree/qt/jsobjects.cpp:
276         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
277
278 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
279
280         Reviewed by Oliver Hunt.
281
282         Implement new required function to pass test we used to pass. This
283         change is required since r51294.
284
285         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
286         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
287
288 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
289
290         Reviewed by Kenneth Rohde Christiansen.
291
292         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
293         https://bugs.webkit.org/show_bug.cgi?id=31775
294
295         LayoutTestController::dumpBackForwardList() should work with local URLs
296         as well as with normal URLs (in http tests for instance).
297         Currently it does not output the latter properly.
298
299         Unskip a bunch of passing http/navigation tests.
300
301         * DumpRenderTree/qt/DumpRenderTree.cpp:
302         (WebCore::dumpHistoryItem):
303
304 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
305
306         Reviewed by Oliver Hunt.
307
308         ARIA: support aria-flowto
309         https://bugs.webkit.org/show_bug.cgi?id=31762
310
311         * DumpRenderTree/AccessibilityUIElement.cpp:
312         (ariaFlowToElementAtIndexCallback):
313         (AccessibilityUIElement::getJSClass):
314         * DumpRenderTree/AccessibilityUIElement.h:
315         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
316         (AccessibilityUIElement::ariaFlowToElementAtIndex):
317         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
318         (AccessibilityUIElement::ariaFlowToElementAtIndex):
319         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
320         (AccessibilityUIElement::ariaFlowToElementAtIndex):
321
322 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
323
324         Reviewed by Kenneth Christiansen.
325
326         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
327         https://bugs.webkit.org/show_bug.cgi?id=31638
328
329         Unfreeze WorkQueue after each test execution.
330
331         * DumpRenderTree/qt/DumpRenderTree.cpp:
332         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
333
334 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
335
336         Reviewed by Adam Barth.
337
338         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
339         for localhost and 127.0.0.1.
340         https://bugs.webkit.org/show_bug.cgi?id=31783
341
342         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
343
344         * DumpRenderTree/qt/DumpRenderTree.cpp:
345         (WebCore::NetworkAccessManager::NetworkAccessManager):
346         (WebCore::NetworkAccessManager::sslErrorsEncountered):
347         (WebCore::WebPage::WebPage):
348         * DumpRenderTree/qt/DumpRenderTree.h:
349
350 2009-11-22  Chris Evans  <cevans@chromium.org>
351
352         Reviewed by Adam Barth.
353
354         Disable access to file:/// directory listings
355         https://bugs.webkit.org/show_bug.cgi?id=31329
356
357         Implemented setAllowUniversalAccessFromFileURLs to support testing of
358         file URL security.
359
360         * DumpRenderTree/LayoutTestController.cpp:
361         (setAllowUniversalAccessFromFileURLsCallback):
362         (LayoutTestController::staticFunctions):
363         * DumpRenderTree/LayoutTestController.h:
364         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
365         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
366         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
367         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
368         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
369         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
370         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
371         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
372
373 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
374
375         Reviewed by Kenneth Rohde Christiansen.
376
377         [Qt] Fix the timeout of fast/frames/frame-navigation.html
378         https://bugs.webkit.org/show_bug.cgi?id=31638
379
380         The test is timeouting, because it uses the WorkQueue to load a document in one
381         of the child frames and once the loading is finished, the DRT does not dump the
382         tree. This is because it waits for the QWebFrame::loadFinished() signal from
383         the main frame, while it should connect to QWebPage::loadFinished().
384
385         * DumpRenderTree/qt/DumpRenderTree.cpp:
386         (WebCore::DumpRenderTree::DumpRenderTree):
387
388 2009-11-21  Eric Seidel  <eric@webkit.org>
389
390         Reviewed by Adam Barth.
391
392         bugzilla-tool --help spews way too much text
393         https://bugs.webkit.org/show_bug.cgi?id=31771
394
395         * Scripts/bugzilla-tool:
396          - Remove self.cached_scm initialization hack.
397         * Scripts/modules/buildbot.py:
398          - Make default_host accessible to callers.
399         * Scripts/modules/commands/download.py:
400          - Phrase help for all commands consistently and remove spurious help text punctuation.
401         * Scripts/modules/commands/queries.py: Ditto.
402         * Scripts/modules/commands/queues.py: Ditto.
403         * Scripts/modules/commands/upload.py: Ditto.
404         * Scripts/modules/multicommandtool.py:
405          - Add HelpPrintingOptionParser.format_epilog to replace
406            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
407            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
408          - Make --help only show a list of commands like "svn help" and "git help" do --
409            previously --help was listing all commands and options.
410          - Sort list of commands alphabetically.
411
412 2009-11-21  Eric Seidel  <eric@webkit.org>
413
414         No review.  Fixing a typo from the previous patch for bug 31767.
415
416         AbstractQueue.run_bugzilla_tool throws an exception
417         https://bugs.webkit.org/show_bug.cgi?id=31769
418
419         * Scripts/modules/commands/queues.py:
420
421 2009-11-21  Eric Seidel  <eric@webkit.org>
422
423         Reviewed by Adam Barth.
424
425         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
426         https://bugs.webkit.org/show_bug.cgi?id=31767
427
428         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
429         Since we don't have a good way to test BugzillaTool pieces, I've
430         left out a test for now.
431
432         * Scripts/bugzilla-tool:
433          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
434         * Scripts/modules/commands/queues.py:
435          - Use tool.path() instead of __file__.
436         * Scripts/modules/multicommandtool.py:
437          - Add a new path() method to MultiComandTool.
438         * Scripts/modules/multicommandtool_unittest.py:
439          - Provide a path() method.  Little point in testing this mock implementation.
440
441 2009-11-21  Adam Barth  <abarth@webkit.org>
442
443         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
444         WebKitTools.
445
446         * Scripts/modules/commands/download.py:
447
448 2009-11-21  Adam Barth  <abarth@webkit.org>
449
450         Reviewed by Eric Seidel.
451
452         Convert check-style to use LandingSequence
453         https://bugs.webkit.org/show_bug.cgi?id=31763
454
455         Instead of manipulating the working copy by hand, we should use the
456         LandingSequence in CheckStyle.  This will make this code eaiser to
457         test.
458
459         * Scripts/modules/commands/download.py:
460
461 2009-11-20  Adam Barth  <abarth@webkit.org>
462
463         Reviewed by Eric Seidel.
464
465         Unit test query commands
466         https://bugs.webkit.org/show_bug.cgi?id=31755
467
468         These tests are pretty rough, but hopefully they'll grow.
469
470         * Scripts/modules/commands/queries_unittest.py: Added.
471         * Scripts/modules/mock_bugzillatool.py: Added.
472         * Scripts/run-webkit-unittests:
473
474 2009-11-20  Eric Seidel  <eric@webkit.org>
475
476         Reviewed by Adam Barth.
477
478         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
479         https://bugs.webkit.org/show_bug.cgi?id=31758
480
481         * Scripts/modules/multicommandtool.py:
482          - Allow passing of explicit commands to MultiCommandTool.__init__
483         * Scripts/modules/multicommandtool_unittest.py:
484          - Use new Command.name naming system.
485          - Test Command auto-discovery.
486         * Scripts/modules/workqueue.py:
487          - bug_id no longer exists, use patch['bug_id'] instead.
488         * Scripts/modules/workqueue_unittest.py:
489          - WorkQueues require names now.
490          - should_proceed_with_work_item must return a patch object.
491
492 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
493
494         Reviewed by Beth Dakin.
495
496         WAI-ARIA: add support for aria-owns
497         https://bugs.webkit.org/show_bug.cgi?id=31702
498
499         * DumpRenderTree/AccessibilityUIElement.cpp:
500         (ariaOwnsElementAtIndexCallback):
501         (AccessibilityUIElement::getJSClass):
502         * DumpRenderTree/AccessibilityUIElement.h:
503         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
504         (AccessibilityUIElement::ariaOwnsElementAtIndex):
505         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
506         (AccessibilityUIElement::ariaOwnsElementAtIndex):
507         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
508         (AccessibilityUIElement::ariaOwnsElementAtIndex):
509
510 2009-11-20  Eric Seidel  <eric@webkit.org>
511
512         Reviewed by Adam Barth.
513
514         Fix exception thrown when running the commit-queue.
515
516         * Scripts/modules/statusbot.py: patch is optional.
517         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
518
519 2009-11-20  Eric Seidel  <eric@webkit.org>
520
521         Reviewed by Adam Barth.
522
523         Teach the StatusBot how to support more than just the commit-queue
524         https://bugs.webkit.org/show_bug.cgi?id=31754
525
526         * Scripts/modules/workqueue.py: Another typo.
527
528 2009-11-20  Eric Seidel  <eric@webkit.org>
529
530         Reviewed by Adam Barth.
531
532         Teach the StatusBot how to support more than just the commit-queue
533         https://bugs.webkit.org/show_bug.cgi?id=31754
534
535         * Scripts/modules/commands/queues.py: Fix silly typo.
536
537 2009-11-20  Eric Seidel  <eric@webkit.org>
538
539         Reviewed by Adam Barth.
540
541         Teach the StatusBot how to support more than just the commit-queue
542         https://bugs.webkit.org/show_bug.cgi?id=31754
543
544         * CommitQueueStatus/index.yaml:
545          - Add indices required for the new queries.
546         * CommitQueueStatus/queue_status.py:
547          - Add a patch-status page and move update_status to update-status.
548          - Only display "commit-queue" status records for the commit-queue.
549          - Add support for a queue_name property on status records.
550          - Fix _int_from_request to actually work.
551         * CommitQueueStatus/update_status.html:
552          - Add support for a queue_name on status records.
553          - Remove unused list of bug ids.
554          * Scripts/modules/commands/queues.py
555           - Make the queues pass the patch instead of the bug_id to StatusBot.
556         * Scripts/modules/statusbot.py:
557          - Support passing the queue_name to the status updates.
558          - Support fetching patch status with patch_status().
559         * Scripts/modules/workqueue.py:
560          - Pass the patch to the StatusBot instead of the bug_id.
561          - Let WorkQueues have a name.
562
563 2009-11-20  Adam Barth  <abarth@webkit.org>
564
565         Reviewed by Eric Seidel.
566
567         Move bugzilla-tool commands into their own file
568         https://bugs.webkit.org/show_bug.cgi?id=31752
569
570         This will let us write unit tests.
571
572         * Scripts/bugzilla-tool:
573         * Scripts/modules/commands/__init__.py: Added.
574         * Scripts/modules/commands/download.py: Added.
575         * Scripts/modules/commands/queries.py: Added.
576         * Scripts/modules/commands/queues.py: Added.
577         * Scripts/modules/commands/upload.py: Added.
578         * Scripts/modules/grammar.py: Added.
579
580 2009-11-20  Adam Barth  <abarth@webkit.org>
581
582         Reviewed by Eric Seidel.
583
584         BuildQueue should check if the tree is currently buildable
585         https://bugs.webkit.org/show_bug.cgi?id=31744
586
587         * Scripts/bugzilla-tool:
588         * Scripts/modules/landingsequence.py:
589         * Scripts/modules/webkitlandingscripts.py:
590
591 2009-11-20  Adam Barth  <abarth@webkit.org>
592
593         Reviewed by Eric Seidel.
594
595         Move prepare_clean_working_directory into the LandingSequence
596         https://bugs.webkit.org/show_bug.cgi?id=31743
597
598         * Scripts/bugzilla-tool:
599         * Scripts/modules/landingsequence.py:
600
601 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
602
603         Reviewed by Kenneth Rohde Christiansen.
604
605         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
606         https://bugs.webkit.org/show_bug.cgi?id=30460
607
608         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
609
610         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
611         (pluginInvoke):
612
613 2009-11-20  Adam Barth  <abarth@webkit.org>
614
615         Reviewed by Eric Seidel.
616
617         Pass the port information to the child process
618         https://bugs.webkit.org/show_bug.cgi?id=31736
619
620         We need to do this so the child process knows what to build!
621
622         * Scripts/bugzilla-tool:
623         * Scripts/modules/landingsequence.py:
624         * Scripts/modules/webkitport.py:
625         * Scripts/modules/webkitport_unittest.py:
626
627 2009-11-20  Adam Barth  <abarth@webkit.org>
628
629         Reviewed by Eric Seidel.
630
631         Support Qt port in build-queue
632         https://bugs.webkit.org/show_bug.cgi?id=31733
633
634         * Scripts/bugzilla-tool:
635
636 2009-11-20  Adam Barth  <abarth@webkit.org>
637
638         Reviewed by Eric Seidel.
639
640         Implement a build-queue
641         https://bugs.webkit.org/show_bug.cgi?id=31725
642
643         Currently this just builds the first 10 patches in the review queue.
644         We'll want to do something smarter soon.
645
646         * Scripts/bugzilla-tool:
647
648 2009-11-20  Adam Barth  <abarth@webkit.org>
649
650         Reviewed by Eric Seidel.
651
652         Make commit-queue and style-queue show up in help
653         https://bugs.webkit.org/show_bug.cgi?id=31724
654
655         We need to store their names on their class to make these commands
656         properly register themselves with MultiCommandTool.
657
658         * Scripts/bugzilla-tool:
659
660 2009-11-20  Adam Barth  <abarth@webkit.org>
661
662         Reviewed by Eric Seidel.
663
664         Implement bugzilla-tool build-attachment
665         https://bugs.webkit.org/show_bug.cgi?id=31722
666
667         This command builds an attachment from bugzilla.  It leaves the built
668         patch in the working copy.
669
670         * Scripts/bugzilla-tool:
671         * Scripts/modules/landingsequence.py:
672         * Scripts/modules/webkitlandingscripts.py:
673
674 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
675
676         Reviewed by Xan Lopez.
677
678         [GTK] DRT release event does not create the state correctly
679         https://bugs.webkit.org/show_bug.cgi?id=31717
680
681         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
682
683 2009-11-20  Eric Seidel  <eric@webkit.org>
684
685         Reviewed by Adam Barth.
686
687         MultiCommandTool should find Command objects automatically instead of with a manual list
688         https://bugs.webkit.org/show_bug.cgi?id=31710
689
690         * Scripts/bugzilla-tool:
691         * Scripts/modules/multicommandtool.py:
692          - Use some wild python-fu to crawl all the known subclasses of Command.
693
694 2009-11-20  Adam Barth  <abarth@webkit.org>
695
696         Unreviewed "build" fix.  Added missing import.
697
698         * Scripts/bugzilla-tool:
699
700 2009-11-20  Adam Barth  <abarth@webkit.org>
701
702         Unreviewed "build" fix.  I failed to update LandingSequence.test
703         properly.
704
705         * Scripts/modules/landingsequence.py:
706
707 2009-11-20  Adam Barth  <abarth@webkit.org>
708
709         Reviewed by Eric Seidel.
710
711         Create LandingSequence as the all-sing, all-dance landing class
712         https://bugs.webkit.org/show_bug.cgi?id=31709
713
714         Client can inherit from this class to carefully control exactly which
715         steps they wish to have happen in the landing sequence.
716
717         * Scripts/bugzilla-tool:
718         * Scripts/modules/landingsequence.py: Added.
719         * Scripts/modules/webkitlandingscripts.py: Added.
720
721 2009-11-19  Adam Barth  <abarth@webkit.org>
722
723         Reviewed by Eric Seidel.
724
725         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
726         https://bugs.webkit.org/show_bug.cgi?id=31707
727
728         This is to help when we implement build-attachment.
729
730         * Scripts/bugzilla-tool:
731
732 2009-11-19  Adam Barth  <abarth@webkit.org>
733
734         Reviewed by Eric Seidel.
735
736         Support Qt port in bugzilla-tool
737         https://bugs.webkit.org/show_bug.cgi?id=31701
738
739         Now we support building with Qt!
740
741         * Scripts/bugzilla-tool:
742         * Scripts/modules/webkitport.py: Added.
743         * Scripts/modules/webkitport_unittest.py: Added.
744         * Scripts/run-webkit-unittests:
745
746 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
747
748         Reviewed by Adam Barth.
749
750         Remove inserting stderr into patch in bugzilla-tool
751         https://bugs.webkit.org/show_bug.cgi?id=29914
752
753         Modify SCM python module's run_command function to avoid return of stderr
754         by default, so stderr won't be inserted into the patches.
755         Modify the related unit test.
756
757         * Scripts/modules/scm.py:
758         * Scripts/modules/scm_unittest.py:
759
760 2009-11-19  Eric Seidel  <eric@webkit.org>
761
762         Reviewed by Adam Barth.
763
764         bugzilla-tool needs per-command help
765         https://bugs.webkit.org/show_bug.cgi?id=31697
766
767         Added support for "bugzilla-tool help command-name"
768         and a unit test to make sure it works.
769
770         * Scripts/modules/multicommandtool.py:
771         * Scripts/modules/multicommandtool_unittest.py:
772
773 2009-11-19  Eric Seidel  <eric@webkit.org>
774
775         Reviewed by Adam Barth.
776
777         Move MultiCommandTool and Command into a separate file and add some basic unit tests
778         https://bugs.webkit.org/show_bug.cgi?id=31695
779
780         * Scripts/bugzilla-tool:
781         * Scripts/modules/multicommandtool.py: Added.
782         * Scripts/modules/multicommandtool_unittest.py: Added.
783         * Scripts/run-webkit-unittests:
784
785 2009-11-19  Eric Seidel  <eric@webkit.org>
786
787         No review, just adding a FIXME.
788
789         Split out command parsing and help printing from BugzillaTool
790         https://bugs.webkit.org/show_bug.cgi?id=31688
791
792         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
793
794 2009-11-19  Eric Seidel  <eric@webkit.org>
795
796         Reviewed by Adam Barth.
797
798         Split out command parsing and help printing from BugzillaTool
799         https://bugs.webkit.org/show_bug.cgi?id=31688
800
801         * Scripts/bugzilla-tool:
802          - Add new MultiCommandTool class to contain option parsing and help printing logic.
803          - Rename private methods to use _ pattern.
804          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
805          - 
806
807 2009-11-19  Eric Seidel  <eric@webkit.org>
808
809         Reviewed by Adam Barth.
810
811         Re-factor help printing to use modern python idioms
812         https://bugs.webkit.org/show_bug.cgi?id=31685
813
814         * Scripts/bugzilla-tool:
815
816 2009-11-19  Eric Seidel  <eric@webkit.org>
817
818         Reviewed by Darin Adler.
819
820         commit-queue empty queue logs twice
821         https://bugs.webkit.org/show_bug.cgi?id=31679
822
823         * Scripts/bugzilla-tool:
824
825 2009-11-19  Eric Seidel  <eric@webkit.org>
826
827         Reviewed by Darin Adler.
828
829         bugzilla-tool's reviewer/committer rejection message should be clearer
830         https://bugs.webkit.org/show_bug.cgi?id=31126
831
832         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
833
834         * Scripts/modules/bugzilla.py:
835
836 2009-11-19  Eric Z. Ayers  <zundel@google.com>
837
838         Reviewed by Pavel Feldman.
839
840         Forces a WM_PAINT event on calling layoutTestController.display()
841         in order to enable the timeline-paint.html test on Windows.
842         ::UpdateWindow() does not force an event becaue the window is 
843         not visible.
844
845         https://bugs.webkit.org/show_bug.cgi?id=31402
846
847         * DumpRenderTree/win/DumpRenderTree.cpp:
848         (displayWebView):
849
850 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
851
852         No review needed.
853
854         Added myself to committers list.
855
856         * Scripts/modules/committers.py:
857
858 2009-11-19  Adam Barth  <abarth@webkit.org>
859
860         Reviewed by Eric Seidel.
861
862         Bugzilla-tool command classes should match command names
863         https://bugs.webkit.org/show_bug.cgi?id=31666
864
865         I renamed all the commands except CommitMessageForCurrentDiff because
866         the new name would conflict with an existing class.
867
868         * Scripts/bugzilla-tool:
869
870 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
871
872         Reviewed by Gustavo Noronha Silva.
873
874         Web Inspector: Implement "show inspector" in WebKit GTK
875         API and enable console tests.
876
877         https://bugs.webkit.org/show_bug.cgi?id=31669
878
879         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
880         (LayoutTestController::showWebInspector):
881
882 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
883
884         Reviewed by Simon Hausmann.
885
886         Minor refactoring + more documentation.
887
888         * DumpRenderTree/qt/DumpRenderTree.cpp:
889         (WebCore::clearHistory):
890         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
891
892 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
893
894         Reviewed by Eric Seidel.
895
896         Ignore websocket tests when --no-http is specified.
897         https://bugs.webkit.org/show_bug.cgi?id=31662
898
899         * Scripts/run-webkit-tests:
900
901 2009-11-18  Adam Barth  <abarth@webkit.org>
902
903         Reviewed by Eric Seidel.
904
905         Normalize ' and " in bugzilla-tool
906         https://bugs.webkit.org/show_bug.cgi?id=31655
907
908         We decided " is better than ' and we should be consistent.
909
910         * Scripts/bugzilla-tool:
911
912 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
913
914         Reviewed by Kenneth Rohde Christiansen.
915
916         [Qt] Remove support for Qt v4.3 or older versions
917         https://bugs.webkit.org/show_bug.cgi?id=29469
918
919         * DumpRenderTree/qt/DumpRenderTree.pro:
920         * DumpRenderTree/qt/ImageDiff.pro:
921
922 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
923
924         Reviewed by Eric Seidel.
925
926         GitTest.test_create_binary_patch fails if /tmp is symlink
927         https://bugs.webkit.org/show_bug.cgi?id=31536
928
929         * Scripts/modules/scm_unittest.py:
930
931 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
932
933         Reviewed by Darin Adler.
934
935         Configuration for Chromium Build Slaves.
936
937         https://bugs.webkit.org/show_bug.cgi?id=31442
938
939         * BuildSlaveSupport/build.webkit.org-config/config.json:
940         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
941
942 2009-11-18  Eric Seidel  <eric@webkit.org>
943
944         Reviewed by Darin Adler.
945
946         workqueue.py results in totally broken commit-queue UI
947         https://bugs.webkit.org/show_bug.cgi?id=31645
948
949         * Scripts/bugzilla-tool:
950          - Remove unneeded use of PatchCollection.
951          - Grab a new copy of the cq'd patches every run of the queue.
952
953 2009-11-18  Sam Weinig  <sam@webkit.org>
954
955         Reviewed by Anders Carlsson.
956
957         Make the Mac Geolocation API async.
958
959         Update DRT to use the new async Mac Geolocation API.
960
961         * DumpRenderTree/mac/UIDelegate.mm:
962         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
963
964 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
965
966         Reviewed by Kenneth Rohde Christiansen.
967
968         Add and option to toggle HTML5 datalist support to build-webkit
969         https://bugs.webkit.org/show_bug.cgi?id=31599
970
971         * Scripts/build-webkit:
972
973 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
974
975         Reviewed by Kevin Ollivier.
976
977         Enable wx plugin support using the Windows implementation as a base.
978         
979         https://bugs.webkit.org/show_bug.cgi?id=31636
980
981         * wx/build/settings.py:
982
983 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
984
985         Reviewed by Simon Hausmann.
986
987         Change the initialization order so that the controllers
988         will be created before exporting them to the JS DOM window.
989
990         * DumpRenderTree/qt/DumpRenderTree.cpp:
991         (WebCore::DumpRenderTree::DumpRenderTree):
992
993 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
994
995         Reviewed by Simon Hausmann.
996
997         Fix a code copy and paste error. m_page should be page.
998
999         * DumpRenderTree/qt/DumpRenderTree.cpp:
1000         (WebCore::DumpRenderTree::createWindow):
1001
1002 2009-11-17  Mark Rowe  <mrowe@apple.com>
1003
1004         Reviewed by Alexey Proskuryakov.
1005
1006         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1007
1008         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1009         This prevents symlinks from confusing the descendant check.
1010
1011 2009-11-17  Mark Rowe  <mrowe@apple.com>
1012
1013         Reviewed by Alexey Proskuryakov.
1014
1015         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1016
1017         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1018         server to be up rather than having run-webkit-tests abort immediately.
1019
1020         * Scripts/run-webkit-tests:
1021
1022 2009-11-17  Eric Seidel  <eric@webkit.org>
1023
1024         Reviewed by Darin Adler.
1025
1026         commit-queue is failing to set reviewer in ChangeLogs
1027         https://bugs.webkit.org/show_bug.cgi?id=31592
1028
1029         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1030         * Scripts/modules/bugzilla.py:
1031          - Add a new _validate_committer_and_reviewer function as a
1032            temporary solution until we can make a real Attachment object
1033            which knows how to fill in its committer/reviewer fields automatically.
1034
1035 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1036
1037         Unreviewed buildbot fix.
1038
1039         Revert part of earlier patch and add comment, as it
1040         was causing timeouts on the buildbot.
1041
1042         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1043         (LayoutTestController::notifyDone):
1044
1045 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1046
1047         Reviewed by Oliver Hunt.
1048
1049         Make the timeout 15 sec as for the other DRT's and make
1050         it print out the same output when a test timeout.
1051
1052         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1053         (LayoutTestController::waitUntilDone):
1054         (LayoutTestController::notifyDone):
1055         (LayoutTestController::timerEvent):
1056
1057 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1058
1059         Reviewed by Timothy Hatcher.
1060
1061         Fixed typos in comments.
1062
1063         * Scripts/modules/committers.py:
1064
1065 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1066
1067         Reviewed by Timothy Hatcher.
1068
1069         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1070         - Updated DRT to show/close inspector for all tests under /inspector
1071         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1072           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1073         - Removed reload on each inspector test
1074         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1075         inspector for those.
1076         - Reimplemented timeline tests in order to get rid of reload there.
1077         - Moved tests that don't require harness into the fast group.
1078
1079         https://bugs.webkit.org/show_bug.cgi?id=31472
1080
1081         * DumpRenderTree/LayoutTestController.cpp:
1082         (setTimelineProfilingEnabledCallback):
1083         (closeWebInspectorCallback):
1084         (LayoutTestController::staticFunctions):
1085         * DumpRenderTree/LayoutTestController.h:
1086         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1087         (shouldOpenWebInspector):
1088         (runTest):
1089         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1090         (LayoutTestController::setTimelineProfilingEnabled):
1091         * DumpRenderTree/mac/DumpRenderTree.mm:
1092         (shouldOpenWebInspector):
1093         (runTest):
1094         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1095         (LayoutTestController::setTimelineProfilingEnabled):
1096         * DumpRenderTree/win/DumpRenderTree.cpp:
1097         (shouldOpenWebInspector):
1098         (runTest):
1099         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1100         (LayoutTestController::setTimelineProfilingEnabled):
1101
1102 2009-11-17  Oliver Hunt  <oliver@apple.com>
1103
1104         Reviewed by Maciej Stachowiak.
1105
1106         Incorrect use of JavaScriptCore API in DumpRenderTree
1107         https://bugs.webkit.org/show_bug.cgi?id=31577
1108
1109         Return undefined rather than a literal null.
1110
1111         * DumpRenderTree/AccessibilityUIElement.cpp:
1112         (setSelectedTextRangeCallback):
1113         (incrementCallback):
1114         (decrementCallback):
1115         (showMenuCallback):
1116
1117 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1118
1119         Reviewed by Beth Dakin.
1120
1121         AX: aria-labelledby duplicates some of its WAI-ARIA label
1122         https://bugs.webkit.org/show_bug.cgi?id=31565
1123
1124         * DumpRenderTree/AccessibilityUIElement.cpp:
1125         (titleUIElementCallback):
1126         (getIsValidCallback):
1127         (AccessibilityUIElement::getJSClass):
1128
1129 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1130
1131         Reviewed by Simon Hausmann.
1132
1133         r50942 broke output from created windows. Make the
1134         m_enableTextOutput a member of the DRT and not the
1135         WebPage.
1136
1137         * DumpRenderTree/qt/DumpRenderTree.cpp:
1138         (WebCore::WebPage::WebPage):
1139         (WebCore::WebPage::javaScriptAlert):
1140         (WebCore::WebPage::javaScriptConsoleMessage):
1141         (WebCore::WebPage::javaScriptConfirm):
1142         (WebCore::WebPage::javaScriptPrompt):
1143         (WebCore::WebPage::acceptNavigationRequest):
1144         (WebCore::DumpRenderTree::DumpRenderTree):
1145         (WebCore::DumpRenderTree::open):
1146         (WebCore::DumpRenderTree::createWindow):
1147         * DumpRenderTree/qt/DumpRenderTree.h:
1148         (WebCore::DumpRenderTree::setTextOutputEnabled):
1149         (WebCore::DumpRenderTree::isTextOutputEnabled):
1150         (WebCore::WebPage::shouldInterruptJavaScript):
1151         (WebCore::WebPage::isTextOutputEnabled):
1152         (WebCore::WebPage::setViewGeometry):
1153
1154 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1155
1156         Reviewed by Gustavo Noronha Silva.
1157
1158         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1159         as the implementation is being used by at least Qt and Gtk+.
1160
1161         Update buildsystems as well.
1162
1163         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1164         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1165         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1166         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1167         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1168         * GNUmakefile.am:
1169
1170 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1171
1172         Reviewed by Alexey Proskuryakov.
1173
1174         Disable wss until all platforms support pyOpenSSL
1175
1176         https://bugs.webkit.org/show_bug.cgi?id=31479
1177
1178         * Scripts/run-webkit-tests:
1179
1180 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1181
1182         Reviewed by Kenneth Christiansen.
1183
1184         [Qt] Implement load error pages support for Qt's DRT.
1185         https://bugs.webkit.org/show_bug.cgi?id=31509
1186
1187         For now, it will not be a default feature, and layout tests
1188         that want to make use of this have to explicitily call
1189         'handleErrorPages();' for the test source.
1190
1191         Any of the other DumpRenderTree's (mac, win and gtk)
1192         support handling error pages. Qt's will be the first.
1193
1194         * DumpRenderTree/qt/DumpRenderTree.cpp:
1195         (WebCore::WebPage::supportsExtension):
1196         (WebCore::WebPage::extension):
1197         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1198         (LayoutTestController::reset):
1199         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1200         (LayoutTestController::shouldHandleErrorPages):
1201         (LayoutTestController::handleErrorPages):
1202
1203 2009-11-16  Eric Seidel  <eric@webkit.org>
1204
1205         Reviewed by Adam Barth.
1206
1207         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1208         https://bugs.webkit.org/show_bug.cgi?id=31549
1209
1210         Renamed --commit-queue to --non-interactive in most places
1211         and remove the code in land-patches which is no longer needed.
1212
1213         * Scripts/bugzilla-tool:
1214
1215 2009-11-16  Eric Seidel  <eric@webkit.org>
1216
1217         Reviewed by Adam Barth.
1218
1219         The commit-queue should use land-attachment
1220         https://bugs.webkit.org/show_bug.cgi?id=31548
1221
1222         * Scripts/bugzilla-tool:
1223
1224 2009-11-16  Adam Barth  <abarth@webkit.org>
1225
1226         Reviewed by Eric Seidel.
1227
1228         Convert CommitQueue over to PatchCollection
1229         https://bugs.webkit.org/show_bug.cgi?id=31547
1230
1231         Also fixes a bug in workqueue and adds a test!
1232
1233         * Scripts/bugzilla-tool:
1234         * Scripts/modules/workqueue.py:
1235         * Scripts/modules/workqueue_unittest.py:
1236
1237 2009-11-16  Adam Barth  <abarth@webkit.org>
1238
1239         Reviewed by Eric Seidel.
1240
1241         Move StyleQueue over to using PatchCollection
1242         https://bugs.webkit.org/show_bug.cgi?id=31544
1243
1244         That's what the class it's for.
1245
1246         * Scripts/bugzilla-tool:
1247         * Scripts/modules/patchcollection.py:
1248         * Scripts/modules/patchcollection_unittest.py:
1249
1250 2009-11-16  Eric Seidel  <eric@webkit.org>
1251
1252         Reviewed by Adam Barth.
1253
1254         bugzilla-tool needs a land-attachment command
1255         https://bugs.webkit.org/show_bug.cgi?id=31546
1256
1257         * Scripts/bugzilla-tool:
1258          - Move all the logic into AbstractLandingCommand and
1259            add a new LandAttachment command subclass.
1260          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1261
1262 2009-11-16  Eric Seidel  <eric@webkit.org>
1263
1264         Reviewed by Adam Barth.
1265
1266         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1267         https://bugs.webkit.org/show_bug.cgi?id=31543
1268
1269         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1270
1271         * Scripts/bugzilla-tool:
1272
1273 2009-11-16  Eric Seidel  <eric@webkit.org>
1274
1275         Reviewed by Adam Barth.
1276
1277         Disable the style queue from posting to the commit queue status page.
1278
1279         * Scripts/bugzilla-tool:
1280
1281 2009-11-16  Adam Barth  <abarth@webkit.org>
1282
1283         Reviewed by Eric Seidel.
1284
1285         Implement PatchCollection
1286         https://bugs.webkit.org/show_bug.cgi?id=31541
1287
1288         This class holds a set of patches and lets clients iterate through
1289         them.  Optionally, clients can install a filter.
1290
1291         * Scripts/modules/patchcollection.py: Added.
1292         * Scripts/modules/patchcollection_unittest.py: Added.
1293         * Scripts/run-webkit-unittests:
1294
1295 2009-11-16  Eric Seidel  <eric@webkit.org>
1296
1297         Reviewed by Adam Barth.
1298
1299         bugzilla-tool land-patches will close bugs with patches r=?
1300         https://bugs.webkit.org/show_bug.cgi?id=28230
1301
1302         The commit-queue shouldn't close patches with outstanding reviews on them,
1303         even if many reviewers seem to be against multi-patch bugs.
1304
1305         * Scripts/bugzilla-tool:
1306
1307 2009-11-16  Eric Seidel  <eric@webkit.org>
1308
1309         Reviewed by Adam Barth.
1310
1311         bugzilla-tool check-style should work with attachment ids instead of bug ids
1312         https://bugs.webkit.org/show_bug.cgi?id=31540
1313
1314         * Scripts/bugzilla-tool:
1315
1316 2009-11-16  Eric Seidel  <eric@webkit.org>
1317
1318         Reviewed by Adam Barth.
1319
1320         WorkQueue is the only place that should know about special exit codes
1321         https://bugs.webkit.org/show_bug.cgi?id=31534
1322
1323         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1324         and add tests for handling exit codes.
1325         I also cleaned up workqueue_unittest.py more.
1326
1327         * Scripts/bugzilla-tool:
1328         * Scripts/modules/workqueue.py:
1329         * Scripts/modules/workqueue_unittest.py:
1330
1331 2009-11-16  Eric Seidel  <eric@webkit.org>
1332
1333         Reviewed by Adam Barth.
1334
1335         Re-factor workqueue_unittest to allow for more than one test.
1336         https://bugs.webkit.org/show_bug.cgi?id=31535
1337
1338         * Scripts/modules/workqueue_unittest.py:
1339
1340 2009-11-16  Eric Seidel  <eric@webkit.org>
1341
1342         Reviewed by Adam Barth.
1343
1344         land-patches needs to be re-factored into smaller chunks
1345         https://bugs.webkit.org/show_bug.cgi?id=31532
1346
1347         * Scripts/bugzilla-tool: fix a couple obvious typos.
1348
1349 2009-11-16  Eric Seidel  <eric@webkit.org>
1350
1351         Reviewed by Adam Barth.
1352
1353         land-patches needs to be re-factored into smaller chunks
1354         https://bugs.webkit.org/show_bug.cgi?id=31532
1355
1356         The next patch will move these methods into WebKitLandingScripts.
1357
1358         * Scripts/bugzilla-tool:
1359          - Split out _land_patch and _close_bug_if_no_active_patches.
1360
1361 2009-11-16  Adam Barth  <abarth@webkit.org>
1362
1363         Reviewed by Eric Seidel.
1364
1365         Fix silly copy-and-paste code.  I am a terrible coder.
1366
1367         * Scripts/modules/bugzilla.py:
1368
1369 2009-11-16  Adam Barth  <abarth@webkit.org>
1370
1371         Reviewed by Eric Seidel.
1372
1373         Implement a StyleQueue
1374         https://bugs.webkit.org/show_bug.cgi?id=31537
1375
1376         The first iteration of the style queue only produces output locally.
1377         There is also a limit of 10 patches because it's not that useful to
1378         iterate through the entire review queue at this point.  We can remove
1379         the limit later.
1380
1381         * Scripts/bugzilla-tool:
1382         * Scripts/modules/bugzilla.py:
1383
1384 2009-11-16  Adam Barth  <abarth@webkit.org>
1385
1386         Reviewed by Eric Seidel.
1387
1388         Unit test WorkQueue
1389         https://bugs.webkit.org/show_bug.cgi?id=31531
1390
1391         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1392
1393         * Scripts/bugzilla-tool:
1394         * Scripts/modules/statusbot.py:
1395         * Scripts/modules/workqueue.py:
1396         * Scripts/modules/workqueue_unittest.py: Added.
1397         * Scripts/run-webkit-unittests:
1398
1399 2009-11-16  Eric Seidel  <eric@webkit.org>
1400
1401         Reviewed by Adam Barth.
1402
1403         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1404         https://bugs.webkit.org/show_bug.cgi?id=31530
1405
1406         * Scripts/bugzilla-tool:
1407
1408 2009-11-16  Eric Seidel  <eric@webkit.org>
1409
1410         Reviewed by Adam Barth.
1411
1412         bugzilla-tool needs apply-attachment
1413         https://bugs.webkit.org/show_bug.cgi?id=31528
1414
1415         * Scripts/bugzilla-tool:
1416          - Add ApplyAttachment command.
1417          - Abstract applying code into WebKitApplyingScripts.
1418          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1419         * Scripts/modules/bugzilla.py:
1420          - Add fetch_attachment and bug_id_for_attachment_id.
1421         * Scripts/modules/bugzilla_unittest.py:
1422          - Add test for new parsing.
1423          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1424
1425 2009-11-16  Eric Seidel  <eric@webkit.org>
1426
1427         Reviewed by Adam Barth.
1428
1429         Document check-style's use of force_clean.
1430
1431         * Scripts/bugzilla-tool:
1432         * Scripts/modules/scm.py:
1433
1434 2009-11-16  Adam Barth  <abarth@webkit.org>
1435
1436         Reviewed by Eric Seidel.
1437
1438         Move WorkQueue to its own file
1439         https://bugs.webkit.org/show_bug.cgi?id=31529
1440
1441         WorkQueue and WorkQueueDelegate are separate concerns from
1442         bugzilla-tool.  Also added a missing include to logging.py.
1443
1444         * Scripts/bugzilla-tool:
1445         * Scripts/modules/logging.py:
1446         * Scripts/modules/workqueue.py:
1447
1448 2009-11-16  Adam Barth  <abarth@webkit.org>
1449
1450         Reviewed by Eric Seidel.
1451
1452         Move OutputTee to logging.py.
1453
1454         * Scripts/bugzilla-tool:
1455         * Scripts/modules/logging.py:
1456
1457 2009-11-15  Adam Barth  <abarth@webkit.org>
1458
1459         Reviewed by Eric Seidel.
1460
1461         Refactor bugzilla-tool to allow for multiple queues
1462         https://bugs.webkit.org/show_bug.cgi?id=31513
1463
1464         Divide the commit queue class into three class to make creating
1465         additional queues easier.
1466
1467         * Scripts/bugzilla-tool:
1468
1469 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1470
1471         Reviewed by Eric Seidel.
1472
1473         svn-apply may not handle git patches created by bugzilla-tool
1474         https://bugs.webkit.org/show_bug.cgi?id=31457
1475
1476         * Scripts/modules/scm.py:
1477         * Scripts/modules/scm_unittest.py:
1478
1479 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1480
1481         Reviewed by Eric Seidel.
1482
1483         bugzilla-tool should post git binary diff
1484         https://bugs.webkit.org/show_bug.cgi?id=31458
1485
1486         Add --binary option to Git.create_patch.
1487
1488         * Scripts/modules/scm.py:
1489         * Scripts/modules/scm_unittest.py:
1490
1491 2009-11-15  Adam Barth  <abarth@webkit.org>
1492
1493         Reviewed by Darin Adler.
1494
1495         Add bugzilla-tool check-style
1496         https://bugs.webkit.org/show_bug.cgi?id=31515
1497
1498         * Scripts/bugzilla-tool:
1499         * Scripts/modules/bugzilla.py:
1500
1501 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1502
1503         Reviewed by Simon Hausmann.
1504
1505         Make the Qt Linux only --valgrind feature, suppress errors
1506         defined in the SuppressedValgrindErrors file.
1507
1508         * Scripts/run-webkit-tests:
1509
1510 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1511
1512         Reviewed by Simon Hausmann.
1513
1514         Set the locale to C and not to the current one in use on the system.
1515
1516         * DumpRenderTree/qt/DumpRenderTree.cpp:
1517         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1518
1519 2009-11-13  Adam Roben  <aroben@apple.com>
1520
1521         Add support for
1522         http/tests/security/isolatedWorld/didClearWindowObject.html
1523
1524         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1525         window objects in isolated worlds are cleared
1526
1527         Reviewed by Dave Hyatt.
1528
1529         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1530
1531         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1532         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1533         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1534         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1535         Added. Sets a __worldID property on the global object whose value is
1536         the ID of this world.
1537         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1538         Respond to this new delegate callback by calling through to one of the
1539         above new methods.
1540         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1541         (worldMap): Added. Returns a HashMap containing all the worlds we've
1542         created.
1543         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1544         haven't kept track of this world.
1545         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1546         instead of declaring our own.
1547
1548         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1549
1550         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1551         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1552         didClearWindowObjectForFrameInStandardWorld.
1553         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1554         Respond to this new delegate callback by calling through to one of the
1555         below new methods.
1556         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1557         Added. Sets a __worldID property on the gobal object whose value is
1558         the ID of this world.
1559         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1560         Added. Moved code here from didClearWindowObject.
1561
1562         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1563         didClearWindowObjectForFrame* functions.
1564
1565         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1566         (worldMap): Added. Returns a HashMap containing all the worlds we've
1567         created.
1568         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1569         haven't kept track of this world.
1570         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1571         instead of declaring our own.
1572
1573 2009-11-13  Adam Roben  <aroben@apple.com>
1574
1575         Finish replacing worldIDs with world objects
1576
1577         The only remaining use of worldIDs was in a method only used by DRT
1578         for the isolated worlds tests.
1579
1580         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1581
1582         Reviewed by Mark Rowe.
1583
1584         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1585         (LayoutTestController::evaluateScriptInIsolatedWorld):
1586         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1587         (LayoutTestController::evaluateScriptInIsolatedWorld):
1588         Updated for changes to WebFrame. Now holds the map of worldID -> world
1589         at this level instead of making WebKit do it.
1590
1591 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1592
1593         Reviewed by Simon Hausmann.
1594
1595         [Qt] Ensure the DRT does not output anything until first test is run
1596
1597         * DumpRenderTree/qt/DumpRenderTree.cpp:
1598         * DumpRenderTree/qt/DumpRenderTree.h:
1599
1600 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1601
1602         Reviewed by Tor Arne Vestbø.
1603
1604         Clear the undo stack in before each new test run.
1605
1606         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1607
1608         * DumpRenderTree/qt/DumpRenderTree.cpp:
1609         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1610
1611 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1612
1613         Reviewed by Kenneth Rohde Christiansen.
1614
1615         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1616
1617         * DumpRenderTree/qt/DumpRenderTree.cpp:
1618         (WebCore::WebPage::resetSettings):
1619         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1620         (LayoutTestController::overridePreference):
1621
1622 2009-11-13  Eric Seidel  <eric@webkit.org>
1623
1624         Reviewed by Adam Barth.
1625
1626         Update committers.py based on svn records
1627         https://bugs.webkit.org/show_bug.cgi?id=31366
1628
1629         This list was generated using validate-committer-lists from
1630         https://bugs.webkit.org/show_bug.cgi?id=30970
1631         and makes committers.py current for committers who have
1632         committed in the last 3 years.
1633
1634         * Scripts/modules/committers.py:
1635
1636 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1637
1638         Reviewed by Adam Barth.
1639
1640         The document-open.html test was flaky at times. The test invokes the layout test plugin
1641         which in its destroy stream handler opens a new document. This basically tears down the
1642         stream and the associated plugin instance. The pluginLog function in the layout test
1643         plugin attempts to retrieve the window script object on a torn down plugin instance
1644         which crashed consistently on windows in the debugger. The functions which issue
1645         these logs already have a valid window script object. We now have variants of the pluginLog
1646         function which take in a window script object with and without variable arguments. 
1647
1648         https://bugs.webkit.org/show_bug.cgi?id=31067
1649
1650         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1651         (pluginLogWithWindowObject):
1652         (pluginLogWithWindowObjectVariableArgs):
1653         (pluginLog):
1654         (notifyTestCompletion):
1655         (testDocumentOpen):
1656         (testWindowOpen):
1657
1658 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1659
1660         Reviewed by Gustavo Noronha Silva.
1661
1662         https://bugs.webkit.org/show_bug.cgi?id=30997
1663         [Gtk] Implemment AtkDocument
1664
1665         Added testing support.
1666
1667         * DumpRenderTree/AccessibilityUIElement.cpp:
1668         * DumpRenderTree/AccessibilityUIElement.h:
1669         (getDocumentEncodingCallback):
1670         (getDocumentURICallback):
1671         (AccessibilityUIElement::getJSClass):
1672         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1673         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1674         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1675         (AccessibilityUIElement::documentEncoding):
1676         (AccessibilityUIElement::documentURI):
1677
1678 2009-11-12  Adam Roben  <aroben@apple.com>
1679
1680         Replace worldIDs with world objects
1681
1682         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1683         user scripts/stylesheets and isolated worlds
1684
1685         Reviewed by Sam Weinig.
1686
1687         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1688         (LayoutTestController::addUserScript):
1689         (LayoutTestController::addUserStyleSheet):
1690         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1691         (LayoutTestController::addUserScript):
1692         (LayoutTestController::addUserStyleSheet):
1693         Changed these functions to create a new WebJSWorld each time they're
1694         called and to pass that world to WebKit.
1695
1696 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1697
1698         Reviewed by Oliver Hunt.
1699
1700         need to implement aria tree roles
1701         https://bugs.webkit.org/show_bug.cgi?id=31284
1702
1703         * DumpRenderTree/AccessibilityUIElement.cpp:
1704         (disclosedRowAtIndexCallback):
1705         (selectedRowAtIndexCallback):
1706         (isEqualCallback):
1707         (isAttributeSettableCallback):
1708         (isActionSupportedCallback):
1709         (disclosedByRowCallback):
1710         (hierarchicalLevelCallback):
1711         (AccessibilityUIElement::getJSClass):
1712         * DumpRenderTree/AccessibilityUIElement.h:
1713         (AccessibilityUIElement::isEqual):
1714         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1715         (AccessibilityUIElement::hierarchicalLevel):
1716         (AccessibilityUIElement::disclosedRowAtIndex):
1717         (AccessibilityUIElement::selectedRowAtIndex):
1718         (AccessibilityUIElement::disclosedByRow):
1719         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1720         (AccessibilityUIElement::getChildAtIndex):
1721         (AccessibilityUIElement::disclosedRowAtIndex):
1722         (AccessibilityUIElement::selectedRowAtIndex):
1723         (AccessibilityUIElement::titleUIElement):
1724         (AccessibilityUIElement::parentElement):
1725         (AccessibilityUIElement::disclosedByRow):
1726         (AccessibilityUIElement::hierarchicalLevel):
1727         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1728         (AccessibilityUIElement::hierarchicalLevel):
1729         (AccessibilityUIElement::disclosedRowAtIndex):
1730         (AccessibilityUIElement::selectedRowAtIndex):
1731         (AccessibilityUIElement::disclosedByRow):
1732
1733 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1734
1735         Reviewed by Darin Adler.
1736
1737         svn-apply can not handle git binary diffs
1738         https://bugs.webkit.org/show_bug.cgi?id=26830
1739
1740         Support "literal" type git binary diffs.
1741
1742         * Scripts/VCSUtils.pm:
1743         * Scripts/modules/scm_unittest.py:
1744         * Scripts/svn-apply:
1745
1746 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1747
1748         Not reviewed, removing duplicate entry for myself in committers.py.
1749
1750         * Scripts/modules/committers.py:
1751
1752 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1753
1754         Reviewed by Darin Adler and Mark Rowe.
1755
1756         https://bugs.webkit.org/show_bug.cgi?id=31200
1757         Tests in http/tests/security/mixedContent start to fail when new tests are added
1758
1759         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1760
1761 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1762
1763         Reviewed by Jan Alonzo.
1764
1765         Create, and display a window for the inspector, for inspector
1766         tests.
1767
1768         Need to also show/hide the inspector window to avoid having
1769         problems with code assuming it is realized
1770         https://bugs.webkit.org/show_bug.cgi?id=31347
1771
1772         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1773         (webInspectorShowWindow):
1774         (webInspectorCloseWindow):
1775         (webInspectorInspectWebView):
1776         (createWebView):
1777
1778 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1779
1780         Unreviewed Qt buildbot fix.
1781
1782         My previous fix was wrong, so revert that change and fix it by
1783         returning when the document of the frame has no document element.
1784         Idea is borrowed from mac and win DRT.
1785
1786         * DumpRenderTree/qt/DumpRenderTree.cpp:
1787         (WebCore::DumpRenderTree::dumpFramesAsText):
1788
1789 2009-11-11  Eric Seidel  <eric@webkit.org>
1790
1791         Reviewed byg Kenneth Rohde Christiansen.
1792
1793         Update Kenneth's committer record to include the email he
1794         uses on lists.webkit.org.
1795
1796         * Scripts/modules/committers.py:
1797
1798 2009-11-11  Eric Seidel  <eric@webkit.org>
1799
1800         Reviewed by Gustavo Noronha Silva.
1801
1802         Several committers use separate email addresses for bugzilla and svn.webkit.org
1803         https://bugs.webkit.org/show_bug.cgi?id=31364
1804
1805         Update records for existing committers to include email addresses
1806         used in svn.webkit.org and lists.webkit.org.
1807         Most committers use the same email address in all 3 places, but some use
1808         separate addresses.  committers.py needs record of each of these addresses.
1809
1810         * Scripts/modules/committers.py:
1811
1812 2009-11-11  Eric Seidel  <eric@webkit.org>
1813
1814         No review, adding second email address for an existing committer.
1815
1816         Add Yong Li's second bugzilla account to his committer record.
1817         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1818
1819         * Scripts/modules/committers.py:
1820
1821 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1822
1823         Reviewed by Simon Hausmann.
1824
1825         If the frame has no innerText don't append it, and
1826         do not add a newline which breaks some cross platform
1827         results.
1828
1829         * DumpRenderTree/qt/DumpRenderTree.cpp:
1830         (WebCore::DumpRenderTree::dumpFramesAsText):
1831
1832 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1833
1834         Reviewed by Simon Hausmann.
1835
1836         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1837
1838         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1839         (webkit_test_plugin_new_instance):
1840         (webkit_test_plugin_destroy_instance):
1841         (webkit_test_plugin_destroy_stream):
1842
1843 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1844
1845         Reviewed by Mark Rowe.
1846
1847         Implement the functionality needed by plugins/window-open.html
1848
1849         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1850         (webkit_test_plugin_new_instance):
1851         (webkit_test_plugin_set_window):
1852
1853 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1854
1855         Reviewed by Simon Hausmann.
1856
1857         [Qt] Force -graphicssystem raster and -style windows when running DRT
1858
1859         * DumpRenderTree/qt/main.cpp:
1860         * Scripts/run-webkit-tests:
1861
1862 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1863
1864         Reviewed by Simon Hausmann.
1865
1866         Compute correct library paths for Qt
1867
1868         * Scripts/webkitdirs.pm:
1869
1870 2009-11-10  Mark Rowe  <mrowe@apple.com>
1871
1872         Reviewed by Sam Weinig.
1873
1874         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1875
1876         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1877         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1878         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1879         that had enabled frame load delegate logging this would result in extra log messages being generated,
1880         causing the test to fail.
1881
1882         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1883         tests.
1884
1885         * DumpRenderTree/mac/DumpRenderTree.mm:
1886         (dumpRenderTree):
1887         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1888         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1889
1890 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1891
1892         Reviewed by Kenneth Rohde Christiansen.
1893
1894         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1895
1896         * DumpRenderTree/qt/DumpRenderTree.cpp:
1897         (WebCore::DumpRenderTree::DumpRenderTree):
1898
1899 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1900
1901         Reviewed by Jan Alonzo.
1902
1903         [GTK] Remove WebSocket configuration from WebKitWebSettings
1904         https://bugs.webkit.org/show_bug.cgi?id=31244
1905
1906         Follow-up of r50724. Don't set the enable-web-socket property
1907         anymore.
1908
1909         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1910         (resetDefaultsToConsistentValues):
1911
1912 2009-11-10  Oliver Hunt  <oliver@apple.com>
1913
1914         Reviewed by Maciej Stachowiak.
1915
1916         Rename 3D Canvas related classes to use WebGL prefix
1917         https://bugs.webkit.org/show_bug.cgi?id=29095
1918
1919         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1920         and upate webkitdirs script to new method of testing for WebGL.
1921
1922         * Scripts/do-webcore-rename:
1923         * Scripts/webkitdirs.pm:
1924
1925 2009-11-09  Oliver Hunt  <oliver@apple.com>
1926
1927         Reviewed by Geoff Garen.
1928
1929         Make do-webcore-rename work with git.
1930
1931         * Scripts/do-webcore-rename:
1932
1933 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1934
1935         Adding Kenneth to the reviewers list.
1936
1937         * Scripts/modules/committers.py:
1938
1939 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1940
1941         Reviewed by Jan Alonzo.
1942
1943         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1944         https://bugs.webkit.org/show_bug.cgi?id=30482
1945
1946         LayoutTestControllerGtk now uses the exposed
1947         Page::tabKeyCyclesThroughElements API
1948
1949         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1950         (LayoutTestController::setTabKeyCyclesThroughElements):
1951
1952 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1953
1954         Reviewed by Holger Freyther.
1955
1956         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1957         This helps to pass the test case below. Also replaced hardcoded
1958         code numbers with defined constants.
1959         https://bugs.webkit.org/show_bug.cgi?id=31185
1960         
1961         Test: editing/undo/undo-deleteWord.html
1962
1963         * DumpRenderTree/qt/EventSenderQt.cpp:
1964         (EventSender::keyDown):
1965
1966 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1967
1968         Reviewed by Holger Freyther.
1969
1970         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1971         https://bugs.webkit.org/show_bug.cgi?id=31164
1972
1973         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1974
1975         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1976         (LayoutTestController::processWork):
1977
1978 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1979
1980         Reviewed by Holger Freyther.
1981
1982         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1983         https://bugs.webkit.org/show_bug.cgi?id=31158
1984
1985         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1986         always, which from WorkQueue prospective means that a load has been started
1987         and the queue processing should stop and wait for the load to finish.
1988         Spinning it off into a loading and a non-loading variants was the solution
1989         adopted by Mac's DRT to work around this problem. The former keeps returning
1990         'true' while the later executes the script synchronously and returns 'false'
1991         making it possible to the WorkQueue to proceed right away.
1992
1993         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1994         (LayoutTestController::processWork):
1995         (LayoutTestController::queueLoadingScript):
1996         (LayoutTestController::queueNonLoadingScript):
1997         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1998         * DumpRenderTree/qt/WorkQueueItem.h:
1999         (LoadingScriptItem::LoadingScriptItem):
2000         (LoadingScriptItem::invoke):
2001         (NonLoadingScriptItem::NonLoadingScriptItem):
2002         (NonLoadingScriptItem::invoke):
2003
2004 2009-11-07  Mark Rowe  <mrowe@apple.com>
2005
2006         Rubber-stamped by Cameron Zwarich.
2007
2008         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2009
2010         * Scripts/commit-log-editor:
2011
2012 2009-11-07  Mark Rowe  <mrowe@apple.com>
2013
2014         Reviewed by Darin Adler.
2015
2016         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2017         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2018
2019         Move logic for determining the name and email address to use in a ChangeLog entry from
2020         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2021         whether the author of the patch matches committer, and therefore needs access to the
2022         email address that would be used in a ChangeLog entry.
2023
2024         Based on a patch by Pierre d'Herbemont.
2025
2026         * Scripts/VCSUtils.pm:
2027         * Scripts/commit-log-editor:
2028         * Scripts/prepare-ChangeLog:
2029         * Scripts/webkitdirs.pm:
2030
2031 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2032
2033         Reviewed by Adam Barth.
2034
2035         Added functionality to the layout test plugin to invoke document.open and
2036         window.open with default arguments. The associated webkit bug is
2037         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2038         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2039         work in Chromium (V8) if there is no calling javascript context. To achieve this
2040         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2041         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2042
2043         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2044         (testDocumentOpen):
2045         (testWindowOpen):
2046         (pluginAllocate):
2047         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2048         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2049         (NPP_New):
2050         (NPP_SetWindow):
2051         (NPP_DestroyStream):
2052         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2053         (NPP_New):
2054         (NPP_SetWindow):
2055         (NPP_NewStream):
2056         (NPP_DestroyStream):
2057
2058 2009-11-06  Eric Seidel  <eric@webkit.org>
2059
2060         Reviewed by Adam Barth.
2061
2062         bugzilla-tool crashed with exception
2063         https://bugs.webkit.org/show_bug.cgi?id=31092
2064
2065         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2066
2067 2009-11-04  Eric Seidel  <eric@webkit.org>
2068
2069         No review, just add a line which got left out of the patch uploaded for commit.
2070
2071         commit-queue is crashing when trying to reject patches after unknown failures
2072         https://bugs.webkit.org/show_bug.cgi?id=31091
2073
2074         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2075
2076 2009-11-04  Adam Roben  <aroben@apple.com>
2077
2078         Remove bogus else clause in bugzilla-tool
2079
2080         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2081         create-bug raises exception after entering bug description
2082
2083         Reviewed by David Kilzer.
2084
2085         * Scripts/bugzilla-tool:
2086         (CreateBug): else clauses are only hit if no exception is raised, so
2087         it makes no sense to try to re-raise the exception in an else clause.
2088         The exception will automatically be re-raised if it doesn't match any
2089         of the except clauses, so we don't have to do anything special here at
2090         all to get the desired behavior.
2091
2092 2009-11-04  Eric Seidel  <eric@webkit.org>
2093
2094         Reviewed by David Kilzer.
2095
2096         svn-apply's fixChangeLogPatch function seems broken
2097         https://bugs.webkit.org/show_bug.cgi?id=30683
2098
2099         Update fixChangeLogPatch to be able to handle patches which
2100         don't start at line 1.
2101         Add unit tests for svn-apply to scm_unittest.py.
2102
2103         * Scripts/VCSUtils.pm:
2104         * Scripts/modules/scm_unittest.py:
2105
2106 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2107
2108         Reviewed by Beth Dakin.
2109
2110         Need to implement ARIA role="combobox"
2111         https://bugs.webkit.org/show_bug.cgi?id=31096
2112
2113         * DumpRenderTree/AccessibilityUIElement.cpp:
2114         (showMenuCallback):
2115         (getIsExpandedCallback):
2116         (AccessibilityUIElement::getJSClass):
2117         * DumpRenderTree/AccessibilityUIElement.h:
2118         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2119         (AccessibilityUIElement::isExpanded):
2120         (AccessibilityUIElement::showMenu):
2121         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2122         (AccessibilityUIElement::isExpanded):
2123         (AccessibilityUIElement::showMenu):
2124         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2125         (AccessibilityUIElement::isSelected):
2126         (AccessibilityUIElement::isExpanded):
2127         (AccessibilityUIElement::showMenu):
2128
2129 2009-11-04  Eric Seidel  <eric@webkit.org>
2130
2131         Reviewed by Adam Barth.
2132
2133         commit-queue is crashing when trying to reject patches after unknown failures
2134         https://bugs.webkit.org/show_bug.cgi?id=31091
2135
2136         * Scripts/bugzilla-tool:
2137          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2138            so we have to find out what the current patch is by asking bugzilla again.
2139          - Discovered that this code was also leaking file descriptors, so fixed that.
2140
2141 2009-11-04  Adam Roben  <aroben@apple.com>
2142
2143         Make run-webkit-tests work for the Debug_Internal Windows
2144         configuration
2145
2146         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2147         suffix.
2148
2149         Fixes <http://webkit.org/b/31123>.
2150
2151         Reviewed by Sam Weinig.
2152
2153         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2154         Debug_Internal, either.
2155
2156 2009-11-04  Eric Seidel  <eric@webkit.org>
2157
2158         Reviewed by Adam Barth.
2159
2160         committers.py needs a way to store non-bugzilla email addresses
2161         https://bugs.webkit.org/show_bug.cgi?id=31037
2162
2163         Make Committer and Reviewer constructors take a single email or a list of emails.
2164         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2165         Expose reviewers(), used by validate-committer-lists on bug 30970.
2166
2167         * Scripts/modules/committers.py:
2168         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2169
2170 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2171
2172         Reviewed by David Levin.
2173
2174         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2175         https://bugs.webkit.org/show_bug.cgi?id=27491
2176
2177         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2178         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2179
2180         Functions to start or stop Web Socket servers are added.
2181
2182         * Scripts/run-webkit-tests:
2183
2184 2009-11-03  Eric Seidel  <eric@webkit.org>
2185
2186         No review, just changing wording of log message.
2187
2188         Change log string to say "failed" instead of "rejected"
2189         when a commit fails due to an out of date checkout.
2190         This makes grepping the commit-queue log for rejected patches easier.
2191
2192         * Scripts/bugzilla-tool:
2193
2194 2009-11-03  Eric Seidel  <eric@webkit.org>
2195
2196         No review, adding commonly known committers missing from the file.
2197
2198         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2199
2200 2009-11-03  Eric Seidel  <eric@webkit.org>
2201
2202         No review, just sort-order cleanup.
2203
2204         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2205
2206 2009-11-03  Stephen White  <senorblanco@chromium.org>
2207
2208         (Unreviewed).
2209
2210         Add myself to committers.py.
2211
2212         * Scripts/modules/committers.py:
2213
2214 2009-11-03  Robin Dunn  <robin@alldunn.com>
2215
2216         Reviewed by Kevin Ollviier.
2217
2218         Add packaging scripts for Debian-based Linux distros.
2219         
2220         https://bugs.webkit.org/show_bug.cgi?id=31075
2221
2222         * wx/packaging/build-debian-installer.py: Added.
2223         * wx/packaging/debian: Added.
2224
2225 2009-11-03  Dan Bernstein  <mitz@apple.com>
2226
2227         Reviewed by Anders Carlsson and Beth Dakin.
2228
2229         https://bugs.webkit.org/show_bug.cgi?id=31070
2230
2231         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2232         destroyed, it executes the value of the 'ondestroy' parameter as a
2233         script.
2234
2235         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2236         (pluginAllocate): Initialize onDestroy.
2237         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2238         onDestroy.
2239         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2240         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2241         specified.
2242         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2243
2244 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2245
2246         Reviewed by Xan Lopez.
2247
2248         https://bugs.webkit.org/show_bug.cgi?id=31035
2249         [GTK] some accessibility tests hitting assertion in debug builds
2250
2251         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2252
2253         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2254         (AccessibilityController::rootElement):
2255
2256 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2257
2258         Reviewed by Beth Dakin.
2259
2260         Support ARIA "tab" roles
2261         https://bugs.webkit.org/show_bug.cgi?id=30842
2262
2263         * DumpRenderTree/AccessibilityUIElement.cpp:
2264         * DumpRenderTree/AccessibilityUIElement.h:
2265         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2266         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2267         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2268
2269 2009-11-01  Eric Seidel  <eric@webkit.org>
2270
2271         Reviewed by David Levin.
2272
2273         buildbots should use --exit-after-N-failures
2274         https://bugs.webkit.org/show_bug.cgi?id=30809
2275
2276         Make the bots exit after 20 failures to prevent never-ending
2277         test runs where every test spends a minute crashing.
2278
2279         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2280
2281 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2282
2283         Reviewed by Eric Seidel.
2284
2285         Turn on warnings for QtWebKit for gcc
2286         https://bugs.webkit.org/show_bug.cgi?id=30958
2287
2288         * DumpRenderTree/qt/main.cpp: 
2289         (crashHandler): Mark function NO_RETURN
2290
2291 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2292
2293         Adding myself to the committers list.
2294
2295         * Scripts/modules/committers.py:
2296
2297 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2298
2299         Fix an issue that Adam noticed in DRT.
2300
2301         Reviewed by Darin Adler.
2302
2303         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2304         (AccessibilityUIElement::role):
2305         Get the length of the role text, and create a buffer dynamically.
2306
2307 2009-10-30  Eric Seidel  <eric@webkit.org>
2308
2309         No review, rolling out r50105.
2310         http://trac.webkit.org/changeset/50105
2311
2312         This commit was causing:
2313         https://bugs.webkit.org/show_bug.cgi?id=30869
2314         We'll re-implement the feature a different way.
2315
2316         * Scripts/bugzilla-tool:
2317
2318 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2319
2320         Test for MSAA: Accessibility of headings is not correct
2321
2322         https://bugs.webkit.org/show_bug.cgi?id=30937
2323
2324         Reviewed by Adam Roben.
2325
2326         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2327         (AccessibilityUIElement::role):
2328         Allow the role returned to be a BSTR.
2329         (AccessibilityUIElement::description):
2330         Fix a copy/paste error.
2331
2332 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2333
2334         Test for MSAA: Accessibility of links is wrong
2335
2336         https://bugs.webkit.org/show_bug.cgi?id=30928
2337
2338         Reviewed by Darin Adler.
2339
2340         * DumpRenderTree/AccessibilityUIElement.cpp:
2341         (getAccessibilityValueCallback):
2342         Return the accessibility value.
2343         (AccessibilityUIElement::getJSClass):
2344         Added "accessibilityValue" value.
2345
2346         * DumpRenderTree/AccessibilityUIElement.h:
2347
2348         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2349         (AccessibilityUIElement::accessibilityValue):
2350         Stubbed.
2351
2352         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2353         (AccessibilityUIElement::accessibilityValue):
2354         Stubbed.
2355
2356         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2357         (AccessibilityUIElement::accessibilityValue):
2358         Get the object's value, and return it as a JS string.
2359
2360 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2361
2362         Fix typo in command name used by wx build system.
2363
2364         * wx/build/build_utils.py:
2365
2366 2009-10-30  Adam Barth  <abarth@webkit.org>
2367
2368         Reviewed by Darin Adler.
2369
2370         Patch v1 is a dumb default name for patches
2371         https://bugs.webkit.org/show_bug.cgi?id=30952
2372
2373         Let's use "Patch" instead.
2374
2375         * Scripts/bugzilla-tool:
2376
2377 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2378
2379         Unreviewed trivial buildfix.
2380
2381         [Qt] Buildfix for r50333.
2382
2383         * DumpRenderTree/qt/DumpRenderTree.pro:
2384
2385 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2386
2387         Reviewed by Holger Freyther.
2388
2389         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2390         https://bugs.webkit.org/show_bug.cgi?id=30953
2391
2392         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2393         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2394         makes qt DRT to share this implementation (as gtk and mac ports do).
2395
2396         * DumpRenderTree/qt/DumpRenderTree.pro:
2397         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2398         * DumpRenderTree/qt/WorkQueue.h: Removed.
2399
2400 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2401
2402         Unreviewed potential buildbot fix.
2403
2404         Second try: Reset page history before running each test.
2405
2406         Apparently the QWebHistory::clear() keeps the current page
2407         in history which is not what we want, so we not additionally
2408         sets the history capacity to 0 (forces removing everything)
2409         and then sets it back to its original value.
2410
2411         * DumpRenderTree/qt/DumpRenderTree.cpp:
2412         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2413
2414 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2415
2416         Unreviewed potential buildbot fix.
2417
2418         Reset page history before running each test.
2419
2420         * DumpRenderTree/qt/DumpRenderTree.cpp:
2421         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2422
2423 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2424
2425         Reviewed by Eric Seidel.
2426
2427         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2428
2429         Bug 28420 -  Implement HTML5 <ruby> rendering
2430         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2431
2432         No new tests (no functional change).
2433
2434         * Scripts/build-webkit:
2435
2436 2009-10-29  Dan Bernstein  <mitz@apple.com>
2437
2438         Reviewed by Mark Rowe.
2439
2440         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2441         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2442         define it.
2443
2444         * Scripts/VCSUtils.pm:
2445         * Scripts/svn-apply:
2446         * Scripts/svn-unapply:
2447
2448 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2449
2450         Reviewed by Gustavo Noronha.
2451
2452         Use the GTK+ main loop instead of rolling our own mini-version of
2453         it.
2454
2455         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2456         (dump):
2457         (runTest):
2458         (webViewLoadFinished):
2459
2460 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2461
2462         Reviewed by Oliver Hunt.
2463
2464         Implement the Qt version of DRT dumpBackForwardList().
2465
2466         * DumpRenderTree/qt/DumpRenderTree.cpp:
2467         (WebCore::dumpHistoryItem):
2468         (WebCore::DumpRenderTree::dumpBackForwardList):
2469
2470 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2471
2472         Reviewed by Adam Roben.
2473
2474         Implement DRT functionality for Qt introduced in
2475         r28690 and r28705.
2476
2477         - Implemented pathToLocalResource which exposes the functionality of
2478         converting a given unix path to the correct location on Windows.
2479         - Implemented a way to remove machine-dependent information from paths
2480         in layout test results.
2481
2482         * DumpRenderTree/qt/DumpRenderTree.cpp:
2483         (WebCore::urlSuitableForTestResult):
2484         (WebCore::WebPage::javaScriptConsoleMessage):
2485         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2486         (LayoutTestController::pathToLocalResource):
2487         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2488
2489 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2490
2491         Adding myself to the committers list.
2492
2493         * Scripts/modules/committers.py:
2494
2495 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2496
2497         Adding myself to the committers list.
2498
2499         * Scripts/modules/committers.py:
2500
2501 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2502
2503         Reviewed by Jan Alonzo.
2504
2505         [GTK] API to start inspector for a WebView
2506         https://bugs.webkit.org/show_bug.cgi?id=22551
2507
2508         Use the new inspector API to implement the LayoutTestController
2509         interfaces used to test the inspector.
2510
2511         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2512         (webInspectorInspectWebView):
2513         (createWebView):
2514         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2515         (LayoutTestController::showWebInspector):
2516         (LayoutTestController::closeWebInspector):
2517         (LayoutTestController::evaluateInWebInspector):
2518
2519 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2520
2521         Reviewed by Eric Seidel.
2522
2523         [Qt] WebFrame::counterValueForElementById must not be exposed
2524         https://bugs.webkit.org/show_bug.cgi?id=30882
2525
2526         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2527         (LayoutTestController::counterValueForElementById):
2528
2529 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2530
2531         Rubberstamped by Oliver Hunt.
2532
2533         Fix the warning:
2534
2535         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2536         declared with attribute warn_unused_result".
2537
2538         by actually checking the result. In the case it is null, an
2539         error has occoured, so treat it as the other fatal errors.
2540
2541         * DumpRenderTree/qt/DumpRenderTree.cpp:
2542         (WebCore::DumpRenderTree::initializeFonts):
2543
2544 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2545
2546         Reviewed by Darin Adler.
2547
2548         Provide a way to get counter values with layoutTestContoller
2549         https://bugs.webkit.org/show_bug.cgi?id=30555
2550
2551         Define layoutTestContoller.counterValueForElementById.
2552
2553         * DumpRenderTree/LayoutTestController.cpp:
2554         (counterValueForElementByIdCallback):
2555         (LayoutTestController::staticFunctions):
2556         * DumpRenderTree/LayoutTestController.h:
2557         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2558         (LayoutTestController::counterValueForElementById):
2559
2560 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2561
2562         Rubberstamped by Oliver Hunt.
2563
2564         Change two methods to be internal for DRT use only.
2565
2566         Part of [Qt] Review all new API in Qt 4.6
2567         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2568
2569         * DumpRenderTree/qt/DumpRenderTree.cpp:
2570         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2571         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2572         (LayoutTestController::whiteListAccessFromOrigin):
2573
2574 2009-10-27  Eric Seidel  <eric@webkit.org>
2575
2576         Reviewed by Adam Barth.
2577
2578         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2579         https://bugs.webkit.org/show_bug.cgi?id=30826
2580
2581         * Scripts/svn-apply:
2582          - Add () around all system() calls.
2583          - Use the correct system() == 0 or die instead of system() or die
2584          - Add descriptive messages to all die statements.
2585
2586 2009-10-27  Steve Block  <steveblock@google.com>
2587
2588         Reviewed by NOBODY.
2589
2590         Adds steveblock@google.com to list of committers.
2591
2592         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2593
2594 2009-10-27  Eric Seidel  <eric@webkit.org>
2595
2596         Reviewed by Adam Barth.
2597
2598         svn-apply can exit(0) even on patch failure
2599         https://bugs.webkit.org/show_bug.cgi?id=29622
2600
2601         * Scripts/svn-apply:
2602          - Add a bunch of "or die" statements, hopefully catching all
2603            possible cases where failure could still exit(0).
2604
2605 2009-10-27  Eric Seidel  <eric@webkit.org>
2606
2607         Reviewed by Adam Barth.
2608
2609         svn-* scripts should share code through VCSUtils.pm
2610         https://bugs.webkit.org/show_bug.cgi?id=30791
2611
2612         Just moving code into a shared location.
2613
2614         * Scripts/VCSUtils.pm:
2615         * Scripts/prepare-ChangeLog:
2616         * Scripts/resolve-ChangeLogs:
2617         * Scripts/svn-apply:
2618         * Scripts/svn-create-patch:
2619         * Scripts/svn-unapply:
2620         * Scripts/update-webkit:
2621
2622 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2623
2624         Suppress a huge number of MSVC warnings when building wxWebKit.
2625
2626         * wx/build/settings.py:
2627
2628 2009-10-26  Eric Seidel  <eric@webkit.org>
2629
2630         No review, just adding Mike Belshe to the committers list.
2631
2632         * Scripts/modules/committers.py:
2633
2634 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2635
2636         Reviewed by Darin Adler.
2637
2638         Make .rc files compile on Windows without depending on MFC headers
2639         https://bugs.webkit.org/show_bug.cgi?id=30750
2640
2641         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2642         windows.h instead of afxres.h because it exists even when MFC is not 
2643         installed, and is all that's needed here.
2644
2645         * FindSafari/FindSafari.rc: Ditto
2646
2647 2009-10-24  Eric Seidel  <eric@webkit.org>
2648
2649         Reviewed by Adam Barth.
2650
2651         bugzilla-tool post-diff should know how to mark commit-queue=?
2652         https://bugs.webkit.org/show_bug.cgi?id=29202
2653
2654         * Scripts/bugzilla-tool:
2655          - Add --commit-queue option to post-diff, post-commits and create-bug.
2656         * Scripts/modules/bugzilla.py:
2657          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2658          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2659
2660 2009-10-23  Eric Seidel  <eric@webkit.org>
2661
2662         Reviewed by Adam Barth.
2663
2664         bugzilla-tool commit-queue does not notice modifications to committers.py
2665         https://bugs.webkit.org/show_bug.cgi?id=30084
2666
2667         * Scripts/bugzilla-tool:
2668          - Make commit-queue re-exec itself instead of using while(1).
2669          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2670          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2671
2672 2009-10-22  Eric Seidel  <eric@webkit.org>
2673
2674         Reviewed by Adam Barth.
2675
2676         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2677         https://bugs.webkit.org/show_bug.cgi?id=30634
2678
2679         * Scripts/bugzilla-tool:
2680          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2681          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2682
2683 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2684
2685         Reviewed by Eric Seidel.
2686
2687         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2688
2689         https://bugs.webkit.org/show_bug.cgi?id=30763
2690
2691         * pywebsocket/mod_pywebsocket/__init__.py:
2692         * pywebsocket/mod_pywebsocket/dispatch.py:
2693         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2694         * pywebsocket/mod_pywebsocket/standalone.py:
2695         * pywebsocket/setup.py:
2696         * pywebsocket/test/test_dispatch.py:
2697
2698 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2699
2700         Reviewed by David Levin.
2701
2702         REGRESSION: 2 failures in run-webkit-unittests
2703         https://bugs.webkit.org/show_bug.cgi?id=30645
2704
2705         * Scripts/modules/cpp_style_unittest.py:
2706         Fixed a few test scenarios which apparently lost some spaces from 
2707         text literals.
2708
2709 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2710
2711         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2712
2713         * Scripts/webkitdirs.pm:
2714
2715 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2716
2717         Reviewed by Darin Adler.
2718
2719         Unification of using null device in perl scripts.
2720         https://bugs.webkit.org/show_bug.cgi?id=30572
2721
2722         * Scripts/VCSUtils.pm:
2723         * Scripts/bisect-builds:
2724         * Scripts/resolve-ChangeLogs:
2725         * Scripts/run-iexploder-tests:
2726         * Scripts/run-jsc:
2727         * Scripts/run-mangleme-tests:
2728         * Scripts/run-webkit-tests:
2729         * Scripts/webkitdirs.pm:
2730         Using File::Spec->devnull() instead of hard coded /dev/null.
2731
2732 2009-10-26  Eric Seidel  <eric@webkit.org>
2733
2734         Reviewed by Holger Freyther.
2735
2736         Reviewers are missing from committers.py
2737         https://bugs.webkit.org/show_bug.cgi?id=30733
2738
2739         * Scripts/modules/committers.py:
2740
2741 2009-10-23  Eric Seidel  <eric@webkit.org>
2742
2743         No review, only adding Alice to the list of reviewers.
2744
2745         * Scripts/modules/committers.py:
2746
2747 2009-10-23  Eric Seidel  <eric@webkit.org>
2748
2749         Reviewed by Eric Carlson.
2750
2751         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2752         https://bugs.webkit.org/show_bug.cgi?id=30700
2753
2754         * DumpRenderTree/mac/DumpRenderTree.mm:
2755         (resetDefaultsToConsistentValues): Update QuickTime version check.
2756
2757 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2758
2759         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2760         character measurement APIs that are private on Tiger.
2761
2762         * wx/build/settings.py:
2763
2764 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2765
2766         Reviewed by NOBODY (build fix).
2767         Build fix following bug #30696.
2768
2769         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2770         (LayoutTestController::evaluateScriptInIsolatedWorld):
2771
2772 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2773
2774         Reviewed by Sam Weinig & Geoff Garen.
2775
2776         https://bugs.webkit.org/show_bug.cgi?id=30696
2777         Enable isolated-worlds tests on mac.
2778
2779         Add private interface for DRT to invoke execution in a given world.
2780
2781         * DumpRenderTree/LayoutTestController.cpp:
2782         (evaluateScriptInIsolatedWorldCallback):
2783         (LayoutTestController::staticFunctions):
2784         * DumpRenderTree/LayoutTestController.h:
2785         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2786         (LayoutTestController::evaluateScriptInIsolatedWorld):
2787         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2788         (LayoutTestController::evaluateScriptInIsolatedWorld):
2789
2790 2009-10-21  Eric Seidel  <eric@webkit.org>
2791
2792         Reviewed by Adam Barth.
2793
2794         bugzilla-tool's "patch failed to download an apply" error should give more information
2795         https://bugs.webkit.org/show_bug.cgi?id=30632
2796
2797         * Scripts/modules/scm.py:
2798          - Use the common run_command method instead of custom POpen code.
2799          - Make run_command know how to take pipes as input.
2800         * Scripts/modules/scm_unittest.py:
2801          - Add new tests to cover change.
2802          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2803
2804 2009-10-21  Kent Tamura  <tkent@chromium.org>
2805
2806         Unreviewed.  Adding myself to the committers list.
2807
2808         * Scripts/modules/committers.py:
2809
2810 2009-10-21  Robin Dunn  <robin@alldunn.com>
2811
2812         Reviewed by Kevin Ollivier.
2813
2814         Update the Windows installer builder to work with Vista / Win 7 and with git.
2815         
2816         https://bugs.webkit.org/show_bug.cgi?id=30649
2817
2818         * wx/build/build_utils.py:
2819         * wx/packaging/build-mac-installer.py:
2820         * wx/packaging/build-win-installer.py:
2821         * wx/packaging/wxWebKitInstaller.iss.in:
2822
2823 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2824
2825         Reviewed by Gustavo Noronha.
2826
2827         [GTK] Added conditional code to avoid using
2828         gdk_window_get_root_coords if we do not have a gtk+ release newer
2829         than 2.17.3.
2830         https://bugs.webkit.org/show_bug.cgi?id=30636
2831
2832         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2833
2834 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2835
2836         Reviewed by Eric Seidel.
2837
2838         [Qt] Added dummy implementation for keepWebHistory()
2839         https://bugs.webkit.org/show_bug.cgi?id=30592
2840
2841         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2842         (LayoutTestController::keepWebHistory):
2843         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2844
2845 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2846
2847         Reviewed by Xan Lopez.
2848
2849         [GTK] Fixed the double click condition, it is not double click if
2850         we move in just in one direction.
2851         https://bugs.webkit.org/show_bug.cgi?id=30636
2852
2853         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2854
2855 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2856
2857         Reviewed by Xan Lopez.
2858
2859         [GTK] Initialize the events completly before emitting them.
2860         https://bugs.webkit.org/show_bug.cgi?id=30633
2861
2862         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2863
2864 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2865
2866         wx build fix. Fix for when linking using --as-needed with gcc.
2867
2868         * wx/browser/wscript:
2869
2870 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2871
2872         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2873         to support all the features used by CURL backend.
2874         
2875         * wx/build/settings.py:
2876         * wx/install-unix-extras:
2877
2878 2009-10-20  Anton Muhin  <antonm@chromium.org>
2879
2880         Reviewed by Adam Barth.
2881
2882         Add {ager,antonm,yurys}@chromium.org into committers.py
2883         https://bugs.webkit.org/show_bug.cgi?id=30560
2884
2885         * Scripts/modules/committers.py:
2886
2887 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2888
2889         Reviewed by Tor Arne Vestbø.
2890
2891         Make the Netscape Test plugin available to the Qt launcher.
2892
2893         * Scripts/run-launcher:
2894
2895 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2896
2897         Reviewed by David Levin.
2898
2899         Removed WebSocket runtime settings.
2900         https://bugs.webkit.org/show_bug.cgi?id=29896
2901
2902         WebSocket runtime configuration is supported by chromium/v8 only.
2903
2904         * DumpRenderTree/mac/DumpRenderTree.mm:
2905         (resetDefaultsToConsistentValues):
2906         * DumpRenderTree/win/DumpRenderTree.cpp:
2907         (resetDefaultsToConsistentValues):
2908
2909 2009-10-19  Nate Chapin  <japhet@chromium.org>
2910
2911         Reviewed by Adam Barth.
2912
2913         Add testFail() to test plugin so we can test our handling of a
2914         plugin invoke call returning false.
2915
2916         https://bugs.webkit.org/show_bug.cgi?id=30239
2917
2918         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2919         (pluginInvoke):
2920         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2921
2922 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2923
2924         Reviewed by Gustavo Noronha.
2925
2926         Enable DOM pasting when running layout tests.
2927
2928         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2929         (resetDefaultsToConsistentValues):
2930
2931 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2932
2933         Reviewed by Simon Hausmann.
2934
2935         Use the setPreferredContentsSize method instead
2936         of setFixedContentsSize, as the method has been renamed.
2937
2938         * DumpRenderTree/qt/DumpRenderTree.cpp:
2939         (WebCore::DumpRenderTree::open):
2940         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2941         (LayoutTestController::setFixedContentsSize):
2942
2943 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2944
2945         Reviewed by Dan Bernstein.
2946
2947         https://bugs.webkit.org/show_bug.cgi?id=30456
2948         Fixes for new Debug_All Windows build configuration.
2949
2950         * DumpRenderTree/win/DumpRenderTree.cpp:
2951         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2952         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2953
2954 2009-10-16  Eric Seidel  <eric@webkit.org>
2955
2956         Reviewed by Adam Barth.
2957
2958         commit-queue status bot should list which buildbot is blocking the queue
2959         https://bugs.webkit.org/show_bug.cgi?id=30452
2960
2961         Add new methods and testing.
2962
2963         * Scripts/bugzilla-tool:
2964         * Scripts/modules/buildbot.py:
2965         * Scripts/modules/buildbot_unittest.py:
2966
2967 2009-10-16  Eric Seidel  <eric@webkit.org>
2968
2969         Reviewed by Adam Barth.
2970
2971         run-webkit-tests fails when CWD is not inside a WebKit checkout
2972         https://bugs.webkit.org/show_bug.cgi?id=30451
2973
2974         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2975         * Scripts/modules/scm_unittest.py:
2976           - Remove use of original_path (we don't need to restore the CWD).
2977           - Don't use '.' to find the webkit checkout, use __file__ instead.
2978
2979 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2980
2981         Reviewed by Adam Roben.
2982
2983         Add a Debug_All configuration to build entire stack as debug.
2984         Change Debug_Internal to:
2985         - stop using _debug suffix for all WebKit/Safari binaries
2986         - not use _debug as a DLL naming suffix
2987         - use non-debug C runtime lib.
2988
2989         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2990         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2991         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2992         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2993         Add missing debug.vsprops inherited property sheet.
2994         Add Debug_All configuration.
2995         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2996         * WinLauncher/WinLauncher.vcproj:
2997         Removed extraneous definitions inherited from vsprops.
2998         Add Debug_All configuration.
2999
3000 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3001
3002         Reviewed by David Levin.
3003
3004         check-webkit-style is wrong about indent checking in namespaces
3005         in header files and a few other things
3006         https://bugs.webkit.org/show_bug.cgi?id=30362
3007
3008         The few other things include:
3009         + check-webkit-style does not require spaces around the equal sign
3010           inside 'if' statements and around binary operators that take 
3011           numeric literals.
3012         + check-webkit-style reports false errors for the / operator
3013           when part of a filename in the #include directive.
3014
3015         * Scripts/modules/cpp_style.py:
3016         Improved indentation checking and space checking around
3017         binary operators. While the checks are still not perfect,
3018         they are clearly better than before.
3019         * Scripts/modules/cpp_style_unittest.py:
3020         Added test cases for the newly supported checks and modified old
3021         test cases to match the new guidelines
3022
3023 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3024
3025         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3026
3027         * wx/build/settings.py:
3028
3029 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3030
3031         Reviewed by David Levin.
3032
3033         Add mod_pywebsocket to test Web Sockets.
3034         http://code.google.com/p/pywebsocket/
3035         https://bugs.webkit.org/show_bug.cgi?id=27490
3036
3037         * pywebsocket/COPYING: Added.
3038         * pywebsocket/MANIFEST.in: Added.
3039         * pywebsocket/README: Added.
3040         * pywebsocket/example/echo_client.py: Added.
3041         * pywebsocket/example/echo_wsh.py: Added.
3042         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3043         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3044         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3045         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3046         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3047         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3048         * pywebsocket/mod_pywebsocket/util.py: Added.
3049         * pywebsocket/setup.py: Added.
3050         * pywebsocket/test/config.py: Added.
3051         * pywebsocket/test/mock.py: Added.
3052         * pywebsocket/test/run_all.py: Added.
3053         * pywebsocket/test/test_dispatch.py: Added.
3054         * pywebsocket/test/test_handshake.py: Added.
3055         * pywebsocket/test/test_mock.py: Added.
3056         * pywebsocket/test/test_msgutil.py: Added.
3057         * pywebsocket/test/test_util.py: Added.
3058         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3059         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3060         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3061         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3062         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3063         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3064         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3065         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3066
3067 2009-10-15  James Robinson  <jamesr@google.com>
3068
3069         Reviewed by David Levin.
3070
3071         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3072
3073         https://bugs.webkit.org/show_bug.cgi?id=30426
3074
3075         * Scripts/modules/cpp_style.py:
3076         * Scripts/modules/cpp_style_unittest.py:
3077
3078 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3079
3080         Reviewed by Adam Roben.
3081
3082         Fixes <http://webkit.org/b/30411>.
3083         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3084         
3085         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3086         building Chromium.
3087
3088         * Scripts/pdevenv:
3089
3090 2009-10-15  Robin Dunn  <robin@alldunn.com>
3091
3092         Reviewed by Kevin Ollivier.
3093
3094         Add Mac package building scripts for wx.
3095         
3096         https://bugs.webkit.org/show_bug.cgi?id=30405
3097
3098         * wx/build/build_utils.py:
3099         * wx/build/settings.py:
3100         * wx/packaging/build-mac-installer.py: Added.
3101
3102 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3103
3104         Reviewed by Gustavo Noronha.
3105
3106         Enable Web Sockets support when running layout tests.
3107
3108         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3109         (resetDefaultsToConsistentValues):
3110
3111 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3112
3113         Reviewed by Gustavo Noronha.
3114
3115         Need to initialize event.button.button, since in most cases a
3116         button number is not passed as an argument.
3117
3118         * DumpRenderTree/gtk/EventSender.cpp:
3119         (mouseDownCallback):
3120         (mouseUpCallback):
3121
3122 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3123
3124         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3125         the OS if none was explicitly set.
3126
3127         * wx/build/settings.py:
3128
3129 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3130
3131         Reviewed by Timothy Hatcher.
3132
3133         Web Inspector: enable developers extras within inspector layout tests.
3134
3135         https://bugs.webkit.org/show_bug.cgi?id=30014
3136
3137         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3138         (LayoutTestController::showWebInspector):
3139         (LayoutTestController::closeWebInspector):
3140         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3141         (LayoutTestController::showWebInspector):
3142         (LayoutTestController::closeWebInspector):
3143
3144 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3145
3146         Reviewed by Jan Alonzo.
3147
3148         GtkLauncher is using a deprecated signal
3149         https://bugs.webkit.org/show_bug.cgi?id=30364
3150
3151         Modified GtkLauncher to use notify::title signal instead of
3152         deprecated title-changed signal
3153
3154         * GtkLauncher/main.c:
3155         (notify_title_cb):
3156         (create_browser):
3157
3158 2009-10-14  Brady Eidson  <beidson@apple.com>
3159
3160         Reviewed by Sam Weinig.
3161
3162         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3163         1 - Disables WebHistory
3164         2 - Doesn't make sense in that context anyway.
3165
3166         * DumpRenderTree/win/DumpRenderTree.cpp:
3167         (createWebViewAndOffscreenWindow):
3168
3169 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3170
3171         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3172         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3173
3174         * wx/build/settings.py:
3175         * wx/install-unix-extras:
3176
3177 2009-10-14  Brady Eidson  <beidson@apple.com>
3178
3179         Reviewed by Sam Weinig.
3180
3181         WebKit Win API should provide a delegate interface for global history.
3182         https://bugs.webkit.org/show_bug.cgi?id=29905
3183
3184         * DumpRenderTree/LayoutTestController.cpp:
3185         (LayoutTestController::LayoutTestController):
3186         * DumpRenderTree/LayoutTestController.h:
3187         (LayoutTestController::dumpHistoryDelegateCallbacks):
3188         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3189                 
3190         * DumpRenderTree/win/DumpRenderTree.cpp:
3191         (shouldLogHistoryDelegates):
3192         (runTest):
3193         (createWebViewAndOffscreenWindow):
3194         (main):
3195         * DumpRenderTree/win/DumpRenderTree.vcproj:
3196         
3197         Add the IWebHistoryDelegate to DRT Windows:
3198         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3199         (wstringFromBSTR):
3200         (HistoryDelegate::HistoryDelegate):
3201         (HistoryDelegate::~HistoryDelegate):
3202         (HistoryDelegate::QueryInterface):
3203         (HistoryDelegate::AddRef):
3204         (HistoryDelegate::Release):
3205         (HistoryDelegate::didNavigateWithNavigationData):
3206         (HistoryDelegate::didPerformClientRedirectFromURL):
3207         (HistoryDelegate::didPerformServerRedirectFromURL):
3208         (HistoryDelegate::updateHistoryTitle):
3209         (HistoryDelegate::populateVisitedLinksForWebView):
3210         * DumpRenderTree/win/HistoryDelegate.h: Added.
3211
3212         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3213         (LayoutTestController::removeAllVisitedLinks):
3214
3215 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3216
3217         Reviewed by Simon Hausmann.
3218
3219         [Qt] Implement support for setPOSIXLocale on Qt.
3220         https://bugs.webkit.org/show_bug.cgi?id=30268 
3221  
3222         * DumpRenderTree/qt/DumpRenderTree.cpp:
3223         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3224         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3225         (LayoutTestController::setPOSIXLocale):
3226         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3227
3228 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3229
3230         Unreviewed, adding myself to reviewers list.
3231
3232         * Scripts/modules/committers.py:
3233
3234 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3235
3236         Reviewed by Mark Rowe.
3237
3238         Fix null assignment so root tests work again.
3239
3240         * Scripts/webkitdirs.pm:
3241
3242 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3243
3244         Reviewed by Simon Hausmann.
3245
3246         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3247         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3248         This is done in preparation of implementing missing features in DRT.
3249         No functionality changes made yet.
3250
3251         * DumpRenderTree/qt/DumpRenderTree.cpp:
3252         * DumpRenderTree/qt/DumpRenderTree.pro:
3253         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3254         (EventSender::EventSender):
3255         (EventSender::mouseDown):
3256         (EventSender::mouseUp):
3257         (EventSender::mouseMoveTo):
3258         (EventSender::leapForward):
3259         (EventSender::keyDown):
3260         (EventSender::contextClick):
3261         (EventSender::scheduleAsynchronousClick):
3262         (EventSender::frameUnderMouse):
3263         * DumpRenderTree/qt/EventSenderQt.h: Added.
3264         (EventSender::clearKillRing):
3265         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3266         (LayoutTestController::LayoutTestController):
3267         (LayoutTestController::reset):
3268         (LayoutTestController::processWork):
3269         (LayoutTestController::maybeDump):
3270         (LayoutTestController::waitUntilDone):
3271         (LayoutTestController::notifyDone):
3272         (LayoutTestController::windowCount):
3273         (LayoutTestController::clearBackForwardList):
3274         (LayoutTestController::dumpEditingCallbacks):
3275         (LayoutTestController::dumpResourceLoadCallbacks):
3276         (LayoutTestController::queueBackNavigation):
3277         (LayoutTestController::queueForwardNavigation):
3278         (LayoutTestController::queueLoad):
3279         (LayoutTestController::queueReload):
3280         (LayoutTestController::queueScript):
3281         (LayoutTestController::provisionalLoad):
3282         (LayoutTestController::timerEvent):
3283         (LayoutTestController::encodeHostName):
3284         (LayoutTestController::decodeHostName):
3285         (LayoutTestController::setJavaScriptProfilingEnabled):
3286         (LayoutTestController::setFixedContentsSize):
3287         (LayoutTestController::setPrivateBrowsingEnabled):
3288         (LayoutTestController::setPopupBlockingEnabled):
3289         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3290         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3291         (LayoutTestController::numberOfActiveAnimations):
3292         (LayoutTestController::disableImageLoading):
3293         (LayoutTestController::dispatchPendingLoadRequests):
3294         (LayoutTestController::setDatabaseQuota):
3295         (LayoutTestController::clearAllDatabases):
3296         (LayoutTestController::whiteListAccessFromOrigin):
3297         (LayoutTestController::waitForPolicyDelegate):
3298         (LayoutTestController::overridePreference):
3299         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3300         (LayoutTestController::isLoading):
3301         (LayoutTestController::setLoading):
3302         (LayoutTestController::shouldDumpAsText):
3303         (LayoutTestController::shouldDumpBackForwardList):
3304         (LayoutTestController::shouldDumpChildrenAsText):
3305         (LayoutTestController::shouldDumpDatabaseCallbacks):
3306         (LayoutTestController::shouldDumpStatusCallbacks):
3307         (LayoutTestController::shouldWaitUntilDone):
3308         (LayoutTestController::canOpenWindows):
3309         (LayoutTestController::shouldDumpTitleChanges):
3310         (LayoutTestController::waitForPolicy):
3311         (LayoutTestController::dumpAsText):
3312         (LayoutTestController::dumpChildFramesAsText):
3313         (LayoutTestController::dumpDatabaseCallbacks):
3314         (LayoutTestController::dumpStatusCallbacks):
3315         (LayoutTestController::setCanOpenWindows):
3316         (LayoutTestController::dumpBackForwardList):
3317         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3318         (LayoutTestController::display):
3319         (LayoutTestController::dumpTitleChanges):
3320         (LayoutTestController::dumpSelectionRect):
3321         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3322         (TextInputController::TextInputController):
3323         (TextInputController::doCommand):
3324         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3325         * DumpRenderTree/qt/WorkQueue.cpp:
3326         * DumpRenderTree/qt/WorkQueue.h:
3327         * DumpRenderTree/qt/WorkQueueItem.h:
3328         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3329         (findFrameNamed):
3330         (LoadItem::invoke):
3331         (ReloadItem::invoke):
3332         (ScriptItem::invoke):
3333         (BackForwardItem::invoke):
3334         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3335         * DumpRenderTree/qt/jsobjects.h:
3336
3337 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3338
3339         Not reviewed, adding myself to the list of reviewers.
3340
3341         * Scripts/modules/committers.py:
3342
3343 2009-10-13  Anders Carlsson  <andersca@apple.com>
3344
3345         Reviewed by Sam Weinig.
3346
3347         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3348
3349         Make the private browsing mode testable by the test plug-in.
3350         
3351         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3352         (pluginGetProperty):
3353         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3354         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3355         (NPP_New):
3356         (NPP_SetValue):
3357
3358 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3359
3360         No review, just adding self to the list of reviewers.
3361
3362         * Scripts/modules/committers.py:
3363
3364 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3365
3366         Reviewed by Adam Roben.
3367
3368         Web Inspector: Use proper web view in inspector layout
3369         tests for windows.
3370
3371         https://bugs.webkit.org/show_bug.cgi?id=30298
3372
3373         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3374         (LayoutTestController::showWebInspector):
3375         (LayoutTestController::closeWebInspector):
3376         (LayoutTestController::evaluateInWebInspector):
3377
3378 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3379
3380         Reviewed by Sam Weinig.
3381
3382         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3383         https://bugs.webkit.org/show_bug.cgi?id=29841
3384
3385         * DumpRenderTree/mac/DumpRenderTree.mm:
3386         (resetDefaultsToConsistentValues):
3387         * DumpRenderTree/win/DumpRenderTree.cpp:
3388         (resetDefaultsToConsistentValues):
3389
3390 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3391
3392         Reviewed by Dimitri Glazkov.
3393
3394         Chromium Port - Windows
3395         https://bugs.webkit.org/show_bug.cgi?id=29969
3396
3397         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3398         * Scripts/webkitdirs.pm:
3399
3400 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3401
3402         Reviewed by Darin Adler.
3403
3404         jsc scripts cleanup and Qt/GTK fix
3405         https://bugs.webkit.org/show_bug.cgi?id=30288
3406
3407         Duplicated jscPath() moved to webkitdirs.pm.
3408         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3409         Configuration added (release/debug) to path for Qt-port on Windows.
3410
3411         * Scripts/run-javascriptcore-tests:
3412         * Scripts/run-jsc:
3413         * Scripts/run-sunspider:
3414         * Scripts/sunspider-compare-results:
3415         * Scripts/webkitdirs.pm:
3416
3417 2009-10-11  Adam Barth  <abarth@webkit.org>
3418
3419         Unreviewed.  Add Collin to committers.py.
3420
3421         * Scripts/modules/committers.py:
3422
3423 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3424
3425         wx build fix, add bindings to source/include dirs now that there are sources there.
3426
3427         * wx/build/settings.py:
3428
3429 2009-10-09  Mark Rowe  <mrowe@apple.com>
3430
3431         Reviewed by Brady Eidson.
3432
3433         Enable plug-in halting in DumpRenderTree.
3434
3435         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3436         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3437
3438         * DumpRenderTree/mac/DumpRenderTree.mm:
3439         (resetDefaultsToConsistentValues):
3440         * DumpRenderTree/mac/UIDelegate.mm:
3441         (-[UIDelegate webView:shouldHaltPlugin:]):
3442
3443 2009-10-08  Brady Eidson  <beidson@apple.com>
3444
3445         Reviewed by Dan Bernstein.
3446
3447         Ask the History Delegate to populate the visited links hash.
3448         <rdar://problem/7285293> and https://webkit.org/b/29904
3449
3450         Add the ability for LayoutTestController to clear all visited links.
3451         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3452
3453         * DumpRenderTree/LayoutTestController.cpp:
3454         (LayoutTestController::LayoutTestController):
3455         (removeAllVisitedLinksCallback):
3456         (LayoutTestController::staticFunctions):
3457         * DumpRenderTree/LayoutTestController.h:
3458         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3459         (LayoutTestController::removeAllVisitedLinks):
3460
3461         * DumpRenderTree/mac/HistoryDelegate.mm:
3462         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3463
3464         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3465         (LayoutTestController::removeAllVisitedLinks):
3466         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3467         (LayoutTestController::removeAllVisitedLinks):
3468         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3469         (LayoutTestController::removeAllVisitedLinks):
3470
3471
3472 2009-10-08  Daniel Bates  <dbates@webkit.org>
3473
3474         Reviewed by Adam Roben.
3475
3476         https://bugs.webkit.org/show_bug.cgi?id=30175
3477         
3478         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3479         the OLE drag-and-drop return value like the function it emulates. Currently, 
3480         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3481         whether the drag-and-drop operation was successful or was cancelled.
3482         
3483         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3484         return value according to whether the drop operation was successful or not.
3485
3486         * DumpRenderTree/win/EventSender.cpp:
3487         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3488         (replaySavedEvents): Ditto.
3489         * DumpRenderTree/win/EventSender.h:
3490         * DumpRenderTree/win/UIDelegate.cpp:
3491         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3492
3493 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3494
3495         Reviewed by Xan Lopez.
3496
3497         [GTK] Added support for a parameter setting the button that was
3498         pressed in the mouseDown function.
3499         https://bugs.webkit.org/show_bug.cgi?id=30220
3500
3501         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3502
3503 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3504
3505         Reviewed by Xan Lopez.
3506
3507         [GTK] Added a line to the bottom of the expected result to match
3508         the output of the test.
3509         https://bugs.webkit.org/show_bug.cgi?id=30220
3510
3511         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3512         expected.txt:
3513
3514 2009-10-08  Adam Roben  <aroben@apple.com>
3515
3516         Use QueryInterface to get IWebInspectorPrivate
3517
3518         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3519         accessed in a more standard way
3520
3521         Reviewed by John Sullivan and Tim Hatcher.
3522
3523         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3524         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3525         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3526         to the IWebInspectorPrivate interface.
3527
3528 2009-10-07  Adam Roben  <aroben@apple.com>
3529
3530         Implement DRT support for origin whitelisting
3531
3532         Fixes <http://webkit.org/b/30185>.
3533
3534         Reviewed by Eric Seidel.
3535
3536         * DumpRenderTree/win/DumpRenderTree.cpp:
3537         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3538         whitelist, to match Mac DRT.
3539         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3540         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3541         IWebViewPrivate::whiteListAccessFromOrigin.
3542
3543 2009-10-07  Brady Eidson  <beidson@apple.com>
3544
3545         Reviewed by Darin Adler.
3546
3547         Send title changes to the global history delegate.
3548         <rdar://problem/7285293> and https://webkit.org/b/29904
3549
3550         * DumpRenderTree/mac/HistoryDelegate.mm:
3551         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3552
3553 2009-10-07  Adam Barth  <abarth@webkit.org>
3554
3555         Unreviewed.  Remove some folks from committers.py who were listed on
3556         the WebKit Team wiki page but who weren't actually listed as commit+.
3557         At some point, we should coorelate this list with the committers
3558         mailing list.
3559
3560         * Scripts/modules/committers.py:
3561
3562 2009-10-07  Adam Barth  <abarth@webkit.org>
3563
3564         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3565         the wiki into committers.py.
3566
3567         * Scripts/modules/committers.py:
3568
3569 2009-10-07  Adam Barth  <abarth@webkit.org>
3570
3571         Unreviewed.  Added Aaron Boodman to committers.py.
3572
3573         * Scripts/modules/committers.py:
3574
3575 2009-10-07  Evan Martin  <evan@chromium.org>
3576
3577         Reviewed by Darin Adler.
3578
3579         Add API to LayoutTestController for re/setting the system locale.
3580         https://bugs.webkit.org/show_bug.cgi?id=18994
3581
3582         * DumpRenderTree/LayoutTestController.cpp:
3583         (setLocaleCallback):
3584         (LayoutTestController::staticFunctions):
3585         (LayoutTestController::setLocale):
3586         * DumpRenderTree/LayoutTestController.h:
3587
3588 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3589
3590         Reviewed by Jan Alonzo.
3591
3592         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3593         https://bugs.webkit.org/show_bug.cgi?id=29689
3594
3595         Build fix by adding -lfontconfig for DumpRenderTree.
3596
3597         * GNUmakefile.am:
3598
3599 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3600
3601         Reviewed by Simon Hausmann.
3602
3603         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3604
3605         * Scripts/run-webkit-tests:
3606
3607 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3608
3609         Reviewed by Gustavo Noronha.
3610
3611         "delete" in EventSender is the backspace key, not the delete one.
3612
3613         * DumpRenderTree/gtk/EventSender.cpp:
3614         (keyDownCallback):
3615
3616 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3617
3618         Reviewed by Gustavo Noronha.
3619
3620         getChildrenWithRange expects as last parameter the end index, not
3621         the length of the range. Correct this and clarify the variable
3622         names to reflect how the code works.
3623
3624         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3625         (AccessibilityUIElement::getChildrenWithRange):
3626         (AccessibilityUIElement::getChildAtIndex):
3627
3628 2009-10-06  Mark Rowe  <mrowe@apple.com>
3629
3630         Reviewed by Simon Fraser.
3631
3632         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3633
3634         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3635         the fact we have already changed the working directory to the top of the open source tree.
3636
3637 2009-10-06  Julie Parent  <jparent@chromium.org>
3638
3639         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3640         rather than my committer email.
3641
3642         * Scripts/modules/committers.py:
3643
3644 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3645
3646         Reviewed by Eric Seidel.
3647
3648         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3649
3650         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3651         it after each layout test as it should do, making the DRT dump additional output
3652         for all of the subsequent layout tests.
3653
3654         * DumpRenderTree/qt/jsobjects.cpp:
3655         (LayoutTestController::reset):
3656
3657 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3658
3659         Reviewed by Simon Hausmann.
3660
3661         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3662         fast/dom/assign-to-window-status.html test, which is passing as a result.
3663
3664         https://bugs.webkit.org/show_bug.cgi?id=30127
3665
3666         * DumpRenderTree/qt/DumpRenderTree.cpp:
3667         (WebCore::DumpRenderTree::DumpRenderTree):
3668         (WebCore::DumpRenderTree::statusBarMessage):
3669         * DumpRenderTree/qt/DumpRenderTree.h:
3670         * DumpRenderTree/qt/jsobjects.h:
3671         (LayoutTestController::shouldDumpStatusCallbacks):
3672         (LayoutTestController::dumpStatusCallbacks):
3673
3674 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3675
3676         Reviewed by Simon Hausmann.
3677
3678         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3679         ignores the argument indicating which mouse button to trigger.
3680         https://bugs.webkit.org/show_bug.cgi?id=30048
3681
3682         This affects the fast/events/mouse-click-events.html layout test.
3683
3684         * DumpRenderTree/qt/jsobjects.cpp:
3685         (EventSender::mouseDown):