8d3a3da35871a84dc6035f43cab1f7da43f57d6c
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
2
3         build-webkit: Remove flex,bison,gperf check for chromium
4         https://bugs.webkit.org/show_bug.cgi?id=32043
5
6         * Scripts/webkitdirs.pm:
7
8 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
9
10         Build fixage for Windows/GTK for DumpRenderTree.
11
12         WAI-ARIA: implement support for ARIA drag and drop
13         https://bugs.webkit.org/show_bug.cgi?id=32007
14
15         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
16         (AccessibilityUIElement::ariaIsGrabbed):
17         (AccessibilityUIElement::ariaDropEffects):
18         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
19         (AccessibilityUIElement::ariaIsGrabbed):
20         (AccessibilityUIElement::ariaDropEffects):
21
22 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
23
24         Reviewed by Darin Adler.
25
26         WAI-ARIA: implement support for ARIA drag and drop
27         https://bugs.webkit.org/show_bug.cgi?id=32007
28
29         * DumpRenderTree/AccessibilityUIElement.cpp:
30         (getARIADropEffectsCallback):
31         (getARIAIsGrabbedCallback):
32         (AccessibilityUIElement::getJSClass):
33         * DumpRenderTree/AccessibilityUIElement.h:
34         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
35         (AccessibilityUIElement::ariaIsGrabbed):
36         (AccessibilityUIElement::ariaDropEffects):
37
38 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
39
40         Not reviewed. GTK DRT try 2.
41
42         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
43         (LayoutTestController::sampleSVGAnimationForElementAtTime):
44
45 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
46
47         Not reviewed. Try to fix gtk DRT build.
48
49         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
50
51 2009-12-01  David Levin  <levin@chromium.org>
52
53         Reviewed by Eric Seidel.
54
55         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
56         https://bugs.webkit.org/show_bug.cgi?id=32033
57
58         * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
59                                         instead of startswith.
60         * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
61
62 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
63
64         Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
65
66         * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature.
67
68 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
69
70         Reviewed by Simon Fraser.
71
72         Add SVG animation test framework with 'snapshot' functionality
73         https://bugs.webkit.org/show_bug.cgi?id=31897
74
75         Add new 'sampleSVGAnimationForElementAtTime' DRT method,
76         used by the new SVG animation testing framework, implemented
77         for qt/gtk/win/mac.
78
79         * DumpRenderTree/LayoutTestController.cpp:
80         (sampleSVGAnimationForElementAtTimeCallback):
81         (LayoutTestController::staticFunctions):
82         * DumpRenderTree/LayoutTestController.h:
83         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
84         (LayoutTestController::sampleSVGAnimationForElementAtTime):
85         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
86         (LayoutTestController::sampleSVGAnimationForElementAtTime):
87         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
88         (LayoutTestController::sampleSVGAnimationForElementAtTime):
89         * DumpRenderTree/qt/LayoutTestControllerQt.h:
90         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
91         (LayoutTestController::sampleSVGAnimationForElementAtTime):
92         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
93         (LayoutTestController::sampleSVGAnimationForElementAtTime):
94
95 2009-12-01  Adam Roben  <aroben@apple.com>
96
97         Remove user content before running each test on Windows
98
99         Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
100
101         Reviewed by Alexey Proskuryakov.
102
103         * DumpRenderTree/win/DumpRenderTree.cpp:
104         (resetWebViewToConsistentStateBeforeTesting): Remove all user content
105         before each test, which matches Mac.
106
107 2009-12-01  Yuzo Fujishima  <yuzo@google.com>
108
109         Reviewed by Alexey Proskuryakov.
110
111         Make pywebsocket log errors to a file
112         https://bugs.webkit.org/show_bug.cgi?id=31604
113
114         * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
115         (by passing the path to the server via a recently added -l option).
116
117 2009-12-01  Adam Roben  <aroben@apple.com>
118
119         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
120
121         Reviewed by Ada Chan.
122
123         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
124         TestNetscapePlugin fail in Debug_Internal builds
125
126         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
127         directory in Debug and Debug_All builds, but not in Debug_Internal
128         builds.
129
130 2009-12-01  Adam Roben  <aroben@apple.com>
131
132         Re-enable DRT's watchdog timer on Windows
133
134         It was accidentally disabled in r50907.
135
136         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
137         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
138         into an if condition.
139
140 2009-12-01  Adam Barth  <abarth@webkit.org>
141
142         Reviewed by Eric Seidel.
143
144         check-webkit-style complains about #imports with / in them
145         https://bugs.webkit.org/show_bug.cgi?id=32022
146
147         We need to exclude #import directives in addition to #include from the
148         binary operator whitespace checks.
149
150         * Scripts/modules/cpp_style.py:
151         * Scripts/modules/cpp_style_unittest.py:
152
153 2009-11-30  Adam Barth  <abarth@webkit.org>
154
155         Reviewed by Eric Seidel.
156
157         check-webkit-style is slightly too verbose
158         https://bugs.webkit.org/show_bug.cgi?id=32010
159
160         check-webkit-style prints out a bunch of "done" lines that seem redundant,
161         especially for the style-queue.
162
163         * Scripts/modules/cpp_style.py:
164
165 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
166
167         Reviewed by Eric Seidel.
168
169         [GTK] Moved the functions that are closing the result log of the
170         tests to the last line of the runTest function, this avoids
171         reporting crashes in the wrong test if there is a problem when
172         reseting the state after the test.
173
174         * DumpRenderTree/gtk/DumpRenderTree.cpp:
175         (dump):
176         (runTest):
177
178 2009-11-30  Sam Weinig  <sam@webkit.org>
179
180         Reviewed by Geoffrey Garen.
181
182         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
183         fast/js/date-proto-generic-invocation breaks another test
184
185         Don't cache JSClassRefs, a change to the prototype chain will
186         last between tests.
187
188         * DumpRenderTree/AccessibilityController.cpp:
189         (AccessibilityController::getJSClass):
190         * DumpRenderTree/GCController.cpp:
191         (GCController::getJSClass):
192         * DumpRenderTree/GCController.h:
193         * DumpRenderTree/LayoutTestController.cpp:
194         (LayoutTestController::getJSClass):
195
196 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
197
198         Reviewed by Alexey Proskuryakov.
199
200         Update pywebsocket to 0.4.2.1.
201         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
202         https://bugs.webkit.org/show_bug.cgi?id=31976
203
204         * pywebsocket/mod_pywebsocket/standalone.py:
205         * pywebsocket/setup.py:
206
207 2009-11-30  Adam Barth  <abarth@webkit.org>
208
209         Reviewed by Eric Seidel.
210
211         [bzt] Generate pass messages for style-queue
212         https://bugs.webkit.org/show_bug.cgi?id=31995
213
214         With this change, the style-queue posts "pass" messages to bugs as
215         well.  Also, added more information to the state store w.r.t. passing
216         and failing.
217
218         * Scripts/modules/commands/queues.py:
219         * Scripts/modules/patchcollection.py:
220
221 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
222
223         Reviewed by Simon Fraser.
224
225         Check for WEBKIT_TESTFONTS environment variable in
226         run-webkit-tests, for GTK+, to have a more prominent error
227         message.
228
229         * Scripts/run-webkit-tests:
230
231 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
232
233         Reviewed by Dimitri Glazkov.
234
235         update-webkit --chromium forces gclient sync
236
237         https://bugs.webkit.org/show_bug.cgi?id=31967
238
239         * Scripts/update-webkit-chromium:
240
241 2009-11-29  Eric Seidel  <eric@webkit.org>
242
243         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
244
245         * Scripts/modules/committers.py:
246
247 2009-11-29  Eric Seidel  <eric@webkit.org>
248
249         No review, just adding missing svn property.
250
251         Set svn:executable property on new scripts.
252         These were added by commit-queue commits, but the executable
253         property was lost due to a bug in svn-apply:
254         https://bugs.webkit.org/show_bug.cgi?id=27204
255
256         * Scripts/update-webkit-chromium: Added property svn:executable.
257         * Scripts/validate-committer-lists: Added property svn:executable.
258
259 2009-11-29  Eric Seidel  <eric@webkit.org>
260
261         Reviewed by Adam Barth.
262
263         Need a way to validate that committers.py includes all committers/reviewers
264         https://bugs.webkit.org/show_bug.cgi?id=30970
265
266         Add a script which knows how to compare our public committer/reviewer
267         lists and show discrepancies between them.
268
269         Validates mailing lists vs. committers.py:
270         - committers.py committers missing from webkit-committers@lists
271         - webkit-committers@lists members missing from committers.py
272         - committers.py reviewers missing from webkit-reviewers@lists
273         - webkit-reviewers@lists members missing from committers.py
274         - webkit-reviewers@lists members missing from committers.py reviewer list
275
276         Validates committers.py vs. trunk/ SVN history:
277         - committers who have not committed in over a year
278         - SVN committers missing from committers.py
279         - committers.py members who have no record in SVN.
280
281         All of these lists still show "false positives" until a few more committers.py updates are made, like:
282         https://bugs.webkit.org/show_bug.cgi?id=31366
283
284         * Scripts/validate-committer-lists: Added.
285
286 2009-11-28  Adam Barth  <abarth@webkit.org>
287
288         Reviewed by Eric Seidel.
289
290         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
291         https://bugs.webkit.org/show_bug.cgi?id=31950
292
293         Now we cache the last status that we get back from QueueStatusServer.
294         Eventually we'll have to do something more fancy if we want to support
295         a "try again" button on QueueStatusServer, but we can cross that bridge
296         when we come to it.
297
298         * Scripts/modules/patchcollection.py:
299
300 2009-11-28  Adam Barth  <abarth@webkit.org>
301
302         Reviewed by Eric Seidel.
303
304         StyleQueue scans ~100 bug pages every 5 minutes
305         https://bugs.webkit.org/show_bug.cgi?id=31947
306
307         Instead of getting the pending-review attachment ids by scanning each
308         bug (which results in a network request), we should just get them all
309         from webkit.org/pending-review in one shot.
310
311         * Scripts/modules/bugzilla.py:
312         * Scripts/modules/bugzilla_unittest.py:
313         * Scripts/modules/commands/queries.py:
314         * Scripts/modules/commands/queries_unittest.py:
315         * Scripts/modules/commands/queues.py:
316         * Scripts/modules/mock_bugzillatool.py:
317         * Scripts/modules/patchcollection.py:
318
319 2009-11-28  Adam Barth  <abarth@webkit.org>
320
321         Reviewed by Eric Seidel.
322
323         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
324         https://bugs.webkit.org/show_bug.cgi?id=31952
325
326         The mailing list is open for anyone to subscribe.
327
328         * Scripts/modules/bugzilla.py:
329         * Scripts/modules/commands/queues.py:
330
331 2009-11-28  Adam Barth  <abarth@webkit.org>
332
333         Reviewed by Eric Seidel.
334
335         [bzt] style-queue should report style errors to bugzilla
336         https://bugs.webkit.org/show_bug.cgi?id=31945
337
338         Currently, we're just logging the style errors locally.  With this
339         patch we'll actually log the errors to bugzilla.  Note: I plan to run
340         with the "local-only" logging during development.
341
342         * Scripts/modules/commands/queues.py:
343         * Scripts/modules/scm.py:
344
345 2009-11-28  Adam Barth  <abarth@webkit.org>
346
347         Reviewed by Eric Seidel.
348
349         [bzt] style-queue shouldn't reject patches from the commit-queue
350         https://bugs.webkit.org/show_bug.cgi?id=31944
351
352         Currently the style-queue subprocess gets confused and thinks its the
353         commit-queue.  If the patch has an error, it rejects it from the
354         commit-queue.  Instead, we should have style-queue specific logic.
355         This patch doesn't add that logic, but it gives us a callback we can
356         use to add that logic.
357
358         * Scripts/modules/buildsteps.py:
359         * Scripts/modules/commands/queues.py:
360         * Scripts/modules/landingsequence.py:
361
362 2009-11-27  Adam Barth  <abarth@webkit.org>
363
364         Rubber stamped by Eric Seidel.
365
366         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
367
368         * CommitQueueStatus: Removed.
369         * CommitQueueStatus/app.yaml: Removed.
370         * CommitQueueStatus/filters: Removed.
371         * CommitQueueStatus/filters/__init__.py: Removed.
372         * CommitQueueStatus/filters/webkit_extras.py: Removed.
373         * CommitQueueStatus/index.html: Removed.
374         * CommitQueueStatus/index.yaml: Removed.
375         * CommitQueueStatus/queue_status.py: Removed.
376         * CommitQueueStatus/stylesheets: Removed.
377         * CommitQueueStatus/stylesheets/main.css: Removed.
378         * CommitQueueStatus/update_status.html: Removed.
379         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
380
381 2009-11-27  Adam Barth  <abarth@webkit.org>
382
383         Reviewed by Eric Seidel.
384
385         style-queue should only process each patch once
386         https://bugs.webkit.org/show_bug.cgi?id=31939
387
388         Actually address reviewer comments!
389
390         * Scripts/bugzilla-tool:
391
392 2009-11-27  Adam Barth  <abarth@webkit.org>
393
394         Reviewed by Eric Seidel.
395
396         [bzt] style-queue fails to apply a bunch of patches for no reason
397         https://bugs.webkit.org/show_bug.cgi?id=31942
398
399         By passing --non-interactive to check-style, we convince check-style
400         to pass --force to svn-apply, which lets it apply more patches.
401
402         * Scripts/modules/commands/queues.py:
403
404 2009-11-27  Adam Barth  <abarth@webkit.org>
405
406         Reviewed by Eric Seidel.
407
408         [bzt] Support --status-host in style-queue
409         https://bugs.webkit.org/show_bug.cgi?id=31941
410
411         * Scripts/modules/commands/queues.py:
412         * Scripts/modules/statusbot.py:
413
414 2009-11-27  Adam Barth  <abarth@webkit.org>
415
416         Reviewed by Eric Seidel.
417
418         style-queue should only process each patch once
419         https://bugs.webkit.org/show_bug.cgi?id=31939
420
421         Before processing a patch, the try-queues now ask the web service
422         whether they have already processed the patch.  This is an initial cut
423         of this functionality.  I expect we're make it richer over time.
424
425         * Scripts/bugzilla-tool:
426         * Scripts/modules/commands/queues.py:
427         * Scripts/modules/patchcollection.py:
428
429 2009-11-27  Adam Barth  <abarth@webkit.org>
430
431         Reviewed by Eric Seidel.
432
433         PatchStatus does not return status
434         https://bugs.webkit.org/show_bug.cgi?id=31938
435
436         We need to parse attachment_id as an int.  Otherwise, we can't find
437         anything in the datastore.
438
439         * CommitQueueStatus/queue_status.py:
440
441 2009-11-27  Adam Barth  <abarth@webkit.org>
442
443         Reviewed by Eric Seidel.
444
445         Make commit-queue status not throw an exception where there is not
446         status
447         https://bugs.webkit.org/show_bug.cgi?id=31936
448
449         We need to actually fetch the results of the query to see what's in the
450         datastore.
451
452         * CommitQueueStatus/queue_status.py:
453
454 2009-11-27  Adam Barth  <abarth@webkit.org>
455
456         Reviewed by Eric Seidel.
457
458         [bzt] unit test ApplyPatches and ApplyAttachment
459         https://bugs.webkit.org/show_bug.cgi?id=31935
460
461         * Scripts/modules/commands/download.py:
462         * Scripts/modules/commands/download_unittest.py:
463
464 2009-11-27  Adam Barth  <abarth@webkit.org>
465
466         Reviewed by Eric Seidel.
467
468         [bzt] Unit test download commands
469         https://bugs.webkit.org/show_bug.cgi?id=31923
470
471         Adds download_unittest and fixes a bug found while testing.
472
473         * Scripts/modules/commands/commandtest.py:
474         * Scripts/modules/commands/download.py:
475             Fixed a bug where we'd throw an error because [].append returns
476             None.
477         * Scripts/modules/commands/download_unittest.py: Added.
478         * Scripts/modules/mock_bugzillatool.py:
479         * Scripts/run-webkit-unittests:
480
481 2009-11-27  Adam Barth  <abarth@webkit.org>
482
483         Unreviewed "build" fix found while writing unit tests.
484
485         * Scripts/modules/commands/download.py:
486
487 2009-11-27  Adam Barth  <abarth@webkit.org>
488
489         Reviewed by Eric Seidel.
490
491         [bzt] Kill WebKitLandingScripts
492         https://bugs.webkit.org/show_bug.cgi?id=31904
493
494         Step 6: Kill the rest.
495
496         * Scripts/modules/buildsteps.py:
497         * Scripts/modules/commands/download.py:
498         * Scripts/modules/commands/queries.py:
499         * Scripts/modules/commands/upload.py:
500         * Scripts/modules/landingsequence.py:
501         * Scripts/modules/scm.py:
502         * Scripts/modules/webkitlandingscripts.py: Removed.
503
504 2009-11-27  Adam Barth  <abarth@webkit.org>
505
506         Reviewed by Eric Seidel.
507
508         [bzt] Unit test upload commands
509         https://bugs.webkit.org/show_bug.cgi?id=31903
510
511         Adds unit tests for all but two of the upload commands.  The two
512         remaining ones are more difficult.  I'll return to them later.  The
513         goal of these tests is just to run the commands.  We can test more
514         detailed behavior later.
515
516         * Scripts/modules/commands/commandtest.py:
517         * Scripts/modules/commands/upload.py:
518         * Scripts/modules/commands/upload_unittest.py:
519         * Scripts/modules/mock.py: Added.
520         * Scripts/modules/mock_bugzillatool.py:
521
522 2009-11-26  Adam Barth  <abarth@webkit.org>
523
524         Reviewed by Eric Seidel.
525
526         [bzt] Kill WebKitLandingScripts
527         https://bugs.webkit.org/show_bug.cgi?id=31904
528
529         Step 5: Kill run_and_throw_if_fail.
530
531         * Scripts/modules/buildsteps.py:
532         * Scripts/modules/processutils.py: Added.
533         * Scripts/modules/webkitlandingscripts.py:
534
535 2009-11-26  Adam Barth  <abarth@webkit.org>
536
537         Reviewed by Eric Seidel.
538
539         [bzt] Kill WebKitLandingScripts
540         https://bugs.webkit.org/show_bug.cgi?id=31904
541
542         Step 4: Kill run_webkit_script.
543
544         * Scripts/modules/buildsteps.py:
545         * Scripts/modules/commands/download.py:
546         * Scripts/modules/webkitlandingscripts.py:
547
548 2009-11-26  Adam Barth  <abarth@webkit.org>
549
550         Reviewed by Eric Seidel.
551
552         [bzt] Kill WebKitLandingScripts
553         https://bugs.webkit.org/show_bug.cgi?id=31904
554
555         Step 3: Kill build_webkit.
556
557         * Scripts/modules/buildsteps.py:
558         * Scripts/modules/landingsequence.py:
559         * Scripts/modules/webkitlandingscripts.py:
560
561 2009-11-26  Adam Barth  <abarth@webkit.org>
562
563         Reviewed by Eric Seidel.
564
565         [bzt] Kill WebKitLandingScripts
566         https://bugs.webkit.org/show_bug.cgi?id=31904
567
568         Step 2: Kill ensure_builders_are_green.
569
570         * Scripts/modules/buildsteps.py:
571         * Scripts/modules/commands/download.py:
572         * Scripts/modules/landingsequence.py:
573         * Scripts/modules/webkitlandingscripts.py:
574
575 2009-11-26  Adam Barth  <abarth@webkit.org>
576
577         Reviewed by Eric Seidel.
578
579         [bzt] Kill WebKitLandingScripts
580         https://bugs.webkit.org/show_bug.cgi?id=31904
581
582         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
583
584         * Scripts/bugzilla-tool:
585         * Scripts/modules/buildsteps.py: Added.
586         * Scripts/modules/commands/download.py:
587         * Scripts/modules/landingsequence.py:
588         * Scripts/modules/webkitlandingscripts.py:
589
590 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
591
592         Reviewed by Adam Barth.
593
594         Remove directory prefixes from linux commands
595
596         SCM unittests can cause errors on some systems if we use absolute reference to
597         the commands, so directory prefixes have been removed.
598
599         * Scripts/modules/scm_unittest.py:
600
601 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
602
603         Reviewed by Kenneth Rohde Christiansen.
604
605         Link DumpRenderTree to the Qt Ui Tools
606         https://bugs.webkit.org/show_bug.cgi?id=31203
607
608         Implement QWebPage::createPlugin using the Qt Ui Tools
609         to be able to create classes like QProgressBar from within
610         the <object></object> tags This is required for the
611         new automatic test of Qt Plugins.
612
613         * DumpRenderTree/qt/DumpRenderTree.cpp:
614         (WebCore::WebPage::createPlugin):
615         * DumpRenderTree/qt/DumpRenderTree.h:
616         * DumpRenderTree/qt/DumpRenderTree.pro:
617
618 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
619
620         Reviewed by Eric Seidel.
621
622         Update pywebsocket to 0.4.2
623
624         Update pywebsocket to 0.4.2
625         https://bugs.webkit.org/show_bug.cgi?id=31861
626
627         * pywebsocket/example/echo_client.py:
628         * pywebsocket/example/echo_wsh.py:
629         * pywebsocket/mod_pywebsocket/__init__.py:
630         * pywebsocket/mod_pywebsocket/dispatch.py:
631         * pywebsocket/mod_pywebsocket/msgutil.py:
632         * pywebsocket/mod_pywebsocket/standalone.py:
633         * pywebsocket/setup.py:
634         * pywebsocket/test/test_dispatch.py:
635         * pywebsocket/test/test_msgutil.py:
636
637 2009-11-25  Adam Barth  <abarth@webkit.org>
638
639         Reviewed by Eric Seidel.
640
641         Add unit test for mark-fixed
642         https://bugs.webkit.org/show_bug.cgi?id=31896
643
644         * Scripts/modules/commands/commandtest.py: Added.
645         * Scripts/modules/commands/queries_unittest.py:
646         * Scripts/modules/commands/upload_unittest.py: Added.
647         * Scripts/modules/mock_bugzillatool.py:
648         * Scripts/run-webkit-unittests:
649
650 2009-11-25  Adam Barth  <abarth@webkit.org>
651
652         Reviewed by Eric Seidel.
653
654         bugzilla-tool should have a mark-fixed command
655         https://bugs.webkit.org/show_bug.cgi?id=31853
656
657         Pretty simple stuff.
658
659         * Scripts/modules/commands/upload.py:
660
661 2009-11-25  Eric Seidel  <eric@webkit.org>
662
663         Reviewed by Adam Barth.
664
665         'bugzilla-tool help' should only show common commands like how 'git help' does
666         https://bugs.webkit.org/show_bug.cgi?id=31772
667
668         I also took this opportunity to make 'help' a real Command.
669         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
670
671         * Scripts/bugzilla-tool:
672          - change should_show_command_help to should_show_in_main_help
673         * Scripts/modules/commands/download.py:
674          - Mark commands as being shown in main help or not.
675          - show_in_main_help = False is not required (default is false),
676            but it seemed to make the commands more self-documenting.
677         * Scripts/modules/commands/queries.py: ditto
678         * Scripts/modules/commands/queues.py: ditto
679         * Scripts/modules/commands/upload.py: ditto
680         * Scripts/modules/multicommandtool.py:
681          - Make Command hold a pointer to tool in self.tool.  Most Command
682            subclasses do not take advantage of this yet, but it was required
683            for HelpCommand to be able to reach the tool from _help_epilog().
684          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
685          - Move MultiCommandTool._help_epilog to Command._help_epilog
686          - Move "help" logic into HelpCommand.execute()
687          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
688         * Scripts/modules/multicommandtool_unittest.py:
689          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
690
691 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
692
693         Reviewed by Dan Bernstein.
694         
695         Patch by Mark Rowe.
696
697         The buildbots are failing on Windows because when they were upgraded
698         to 4.0.4, Apple Application Support was not in their path. Add it to
699         the path to fix the buildots.
700
701         * Scripts/webkitdirs.pm:
702
703 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
704
705         Reviewed by David Kilzer.
706
707         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
708         https://bugs.webkit.org/show_bug.cgi?id=31799
709
710         * Scripts/run-webkit-tests: Fixed.
711
712 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
713
714         Reviewed by Eric Seidel.
715
716         Change run_command to give back stderr by default
717         https://bugs.webkit.org/show_bug.cgi?id=31734
718
719         Change run_command to give back stderr by default.
720         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
721         Change the related unittest call.
722
723         * Scripts/modules/scm.py:
724         * Scripts/modules/scm_unittest.py:
725
726 2009-11-25  Eric Seidel  <eric@webkit.org>
727
728         Reviewed by Adam Barth.
729
730         Centralize required argument parsing in Command
731         https://bugs.webkit.org/show_bug.cgi?id=31872
732
733         * Scripts/modules/commands/download.py: remove custom required arg message.
734         * Scripts/modules/commands/upload.py: ditto.
735         * Scripts/modules/multicommandtool.py:
736          - Add _parse_required_arguments.
737          - Pass program name off to OptionParser.
738          - Add name() for access to tool name.
739          - Add check_arguments_and_execute and make it return a return code.
740          - Replace a couple uses of + with %.
741         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
742
743 2009-11-25  Eric Seidel  <eric@webkit.org>
744
745         Reviewed by Adam Barth.
746
747         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
748         https://bugs.webkit.org/show_bug.cgi?id=31870
749
750         * Scripts/modules/commands/queries_unittest.py: Use the new class.
751         * Scripts/modules/multicommandtool_unittest.py: Ditto.
752         * Scripts/modules/outputcapture.py: Added.
753
754 2009-11-24  Dmitry Titov  <dimich@chromium.org>
755
756         Reviewed by Eric Seidel.
757
758         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
759         https://bugs.webkit.org/show_bug.cgi?id=31444
760
761         * Scripts/build-webkit:
762
763 2009-11-24  Chris Marrin  <cmarrin@apple.com>
764
765         Reviewed by Simon Fraser.
766
767         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
768         https://bugs.webkit.org/show_bug.cgi?id=27314
769         
770         Now the script allows the directories with these tests to be included on all
771         platforms but Mac, where they behave the same as always. For all other platforms
772         the tests need to be excluded using the Skipped files, which is currently done
773         for all platforms (including win since we're not turned on yet)
774
775         * Scripts/webkitdirs.pm:
776
777 2009-11-24  Eric Seidel  <eric@webkit.org>
778
779         Reviewed by Adam Barth.
780
781         queries_unittest.py should test command output
782         https://bugs.webkit.org/show_bug.cgi?id=31845
783
784         * Scripts/modules/commands/queries_unittest.py:
785          - Capture stdout and stderr and compare with expected strings.
786
787 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
788
789         No Review.
790
791         Fix spelling error ("depenedencies").
792
793         * Scripts/build-webkit:
794
795 2009-11-24  Mark Rowe  <mrowe@apple.com>
796
797         Land the configuration that includes the two debug GTK Linux builders.
798
799         * BuildSlaveSupport/build.webkit.org-config/config.json:
800
801 2009-11-24  David Kilzer  <ddkilzer@apple.com>
802
803         <http://webkit.org/b/31840> bisect-builds broke after r50080
804
805         Reviewed by Dan Bernstein.
806
807         * Scripts/bisect-builds:
808         (mountAndRunNightly): Switched back to using backticks to run
809         the hdiutil command since exec() will terminate the existing
810         script, which is not what we want.  Store the output of
811         File::Spec->devnull() in a variable for use in the hdiutil
812         detach commands.
813
814 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
815
816         Reviewed by Kenneth Rohde Christiansen.
817
818         Include "config.h" to meet Coding Style Guidelines
819         https://bugs.webkit.org/show_bug.cgi?id=31792
820
821         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
822         * DumpRenderTree/qt/jsobjects.cpp:
823         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
824
825 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
826
827         Reviewed by Oliver Hunt.
828
829         Implement new required function to pass test we used to pass. This
830         change is required since r51294.
831
832         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
833         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
834
835 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
836
837         Reviewed by Kenneth Rohde Christiansen.
838
839         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
840         https://bugs.webkit.org/show_bug.cgi?id=31775
841
842         LayoutTestController::dumpBackForwardList() should work with local URLs
843         as well as with normal URLs (in http tests for instance).
844         Currently it does not output the latter properly.
845
846         Unskip a bunch of passing http/navigation tests.
847
848         * DumpRenderTree/qt/DumpRenderTree.cpp:
849         (WebCore::dumpHistoryItem):
850
851 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
852
853         Reviewed by Oliver Hunt.
854
855         ARIA: support aria-flowto
856         https://bugs.webkit.org/show_bug.cgi?id=31762
857
858         * DumpRenderTree/AccessibilityUIElement.cpp:
859         (ariaFlowToElementAtIndexCallback):
860         (AccessibilityUIElement::getJSClass):
861         * DumpRenderTree/AccessibilityUIElement.h:
862         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
863         (AccessibilityUIElement::ariaFlowToElementAtIndex):
864         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
865         (AccessibilityUIElement::ariaFlowToElementAtIndex):
866         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
867         (AccessibilityUIElement::ariaFlowToElementAtIndex):
868
869 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
870
871         Reviewed by Kenneth Christiansen.
872
873         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
874         https://bugs.webkit.org/show_bug.cgi?id=31638
875
876         Unfreeze WorkQueue after each test execution.
877
878         * DumpRenderTree/qt/DumpRenderTree.cpp:
879         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
880
881 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
882
883         Reviewed by Adam Barth.
884
885         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
886         for localhost and 127.0.0.1.
887         https://bugs.webkit.org/show_bug.cgi?id=31783
888
889         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
890
891         * DumpRenderTree/qt/DumpRenderTree.cpp:
892         (WebCore::NetworkAccessManager::NetworkAccessManager):
893         (WebCore::NetworkAccessManager::sslErrorsEncountered):
894         (WebCore::WebPage::WebPage):
895         * DumpRenderTree/qt/DumpRenderTree.h:
896
897 2009-11-22  Chris Evans  <cevans@chromium.org>
898
899         Reviewed by Adam Barth.
900
901         Disable access to file:/// directory listings
902         https://bugs.webkit.org/show_bug.cgi?id=31329
903
904         Implemented setAllowUniversalAccessFromFileURLs to support testing of
905         file URL security.
906
907         * DumpRenderTree/LayoutTestController.cpp:
908         (setAllowUniversalAccessFromFileURLsCallback):
909         (LayoutTestController::staticFunctions):
910         * DumpRenderTree/LayoutTestController.h:
911         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
912         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
913         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
914         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
915         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
916         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
917         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
918         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
919
920 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
921
922         Reviewed by Kenneth Rohde Christiansen.
923
924         [Qt] Fix the timeout of fast/frames/frame-navigation.html
925         https://bugs.webkit.org/show_bug.cgi?id=31638
926
927         The test is timeouting, because it uses the WorkQueue to load a document in one
928         of the child frames and once the loading is finished, the DRT does not dump the
929         tree. This is because it waits for the QWebFrame::loadFinished() signal from
930         the main frame, while it should connect to QWebPage::loadFinished().
931
932         * DumpRenderTree/qt/DumpRenderTree.cpp:
933         (WebCore::DumpRenderTree::DumpRenderTree):
934
935 2009-11-21  Eric Seidel  <eric@webkit.org>
936
937         Reviewed by Adam Barth.
938
939         bugzilla-tool --help spews way too much text
940         https://bugs.webkit.org/show_bug.cgi?id=31771
941
942         * Scripts/bugzilla-tool:
943          - Remove self.cached_scm initialization hack.
944         * Scripts/modules/buildbot.py:
945          - Make default_host accessible to callers.
946         * Scripts/modules/commands/download.py:
947          - Phrase help for all commands consistently and remove spurious help text punctuation.
948         * Scripts/modules/commands/queries.py: Ditto.
949         * Scripts/modules/commands/queues.py: Ditto.
950         * Scripts/modules/commands/upload.py: Ditto.
951         * Scripts/modules/multicommandtool.py:
952          - Add HelpPrintingOptionParser.format_epilog to replace
953            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
954            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
955          - Make --help only show a list of commands like "svn help" and "git help" do --
956            previously --help was listing all commands and options.
957          - Sort list of commands alphabetically.
958
959 2009-11-21  Eric Seidel  <eric@webkit.org>
960
961         No review.  Fixing a typo from the previous patch for bug 31767.
962
963         AbstractQueue.run_bugzilla_tool throws an exception
964         https://bugs.webkit.org/show_bug.cgi?id=31769
965
966         * Scripts/modules/commands/queues.py:
967
968 2009-11-21  Eric Seidel  <eric@webkit.org>
969
970         Reviewed by Adam Barth.
971
972         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
973         https://bugs.webkit.org/show_bug.cgi?id=31767
974
975         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
976         Since we don't have a good way to test BugzillaTool pieces, I've
977         left out a test for now.
978
979         * Scripts/bugzilla-tool:
980          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
981         * Scripts/modules/commands/queues.py:
982          - Use tool.path() instead of __file__.
983         * Scripts/modules/multicommandtool.py:
984          - Add a new path() method to MultiComandTool.
985         * Scripts/modules/multicommandtool_unittest.py:
986          - Provide a path() method.  Little point in testing this mock implementation.
987
988 2009-11-21  Adam Barth  <abarth@webkit.org>
989
990         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
991         WebKitTools.
992
993         * Scripts/modules/commands/download.py:
994
995 2009-11-21  Adam Barth  <abarth@webkit.org>
996
997         Reviewed by Eric Seidel.
998
999         Convert check-style to use LandingSequence
1000         https://bugs.webkit.org/show_bug.cgi?id=31763
1001
1002         Instead of manipulating the working copy by hand, we should use the
1003         LandingSequence in CheckStyle.  This will make this code eaiser to
1004         test.
1005
1006         * Scripts/modules/commands/download.py:
1007
1008 2009-11-20  Adam Barth  <abarth@webkit.org>
1009
1010         Reviewed by Eric Seidel.
1011
1012         Unit test query commands
1013         https://bugs.webkit.org/show_bug.cgi?id=31755
1014
1015         These tests are pretty rough, but hopefully they'll grow.
1016
1017         * Scripts/modules/commands/queries_unittest.py: Added.
1018         * Scripts/modules/mock_bugzillatool.py: Added.
1019         * Scripts/run-webkit-unittests:
1020
1021 2009-11-20  Eric Seidel  <eric@webkit.org>
1022
1023         Reviewed by Adam Barth.
1024
1025         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
1026         https://bugs.webkit.org/show_bug.cgi?id=31758
1027
1028         * Scripts/modules/multicommandtool.py:
1029          - Allow passing of explicit commands to MultiCommandTool.__init__
1030         * Scripts/modules/multicommandtool_unittest.py:
1031          - Use new Command.name naming system.
1032          - Test Command auto-discovery.
1033         * Scripts/modules/workqueue.py:
1034          - bug_id no longer exists, use patch['bug_id'] instead.
1035         * Scripts/modules/workqueue_unittest.py:
1036          - WorkQueues require names now.
1037          - should_proceed_with_work_item must return a patch object.
1038
1039 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
1040
1041         Reviewed by Beth Dakin.
1042
1043         WAI-ARIA: add support for aria-owns
1044         https://bugs.webkit.org/show_bug.cgi?id=31702
1045
1046         * DumpRenderTree/AccessibilityUIElement.cpp:
1047         (ariaOwnsElementAtIndexCallback):
1048         (AccessibilityUIElement::getJSClass):
1049         * DumpRenderTree/AccessibilityUIElement.h:
1050         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1051         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1052         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1053         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1054         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1055         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1056
1057 2009-11-20  Eric Seidel  <eric@webkit.org>
1058
1059         Reviewed by Adam Barth.
1060
1061         Fix exception thrown when running the commit-queue.
1062
1063         * Scripts/modules/statusbot.py: patch is optional.
1064         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
1065
1066 2009-11-20  Eric Seidel  <eric@webkit.org>
1067
1068         Reviewed by Adam Barth.
1069
1070         Teach the StatusBot how to support more than just the commit-queue
1071         https://bugs.webkit.org/show_bug.cgi?id=31754
1072
1073         * Scripts/modules/workqueue.py: Another typo.
1074
1075 2009-11-20  Eric Seidel  <eric@webkit.org>
1076
1077         Reviewed by Adam Barth.
1078
1079         Teach the StatusBot how to support more than just the commit-queue
1080         https://bugs.webkit.org/show_bug.cgi?id=31754
1081
1082         * Scripts/modules/commands/queues.py: Fix silly typo.
1083
1084 2009-11-20  Eric Seidel  <eric@webkit.org>
1085
1086         Reviewed by Adam Barth.
1087
1088         Teach the StatusBot how to support more than just the commit-queue
1089         https://bugs.webkit.org/show_bug.cgi?id=31754
1090
1091         * CommitQueueStatus/index.yaml:
1092          - Add indices required for the new queries.
1093         * CommitQueueStatus/queue_status.py:
1094          - Add a patch-status page and move update_status to update-status.
1095          - Only display "commit-queue" status records for the commit-queue.
1096          - Add support for a queue_name property on status records.
1097          - Fix _int_from_request to actually work.
1098         * CommitQueueStatus/update_status.html:
1099          - Add support for a queue_name on status records.
1100          - Remove unused list of bug ids.
1101          * Scripts/modules/commands/queues.py
1102           - Make the queues pass the patch instead of the bug_id to StatusBot.
1103         * Scripts/modules/statusbot.py:
1104          - Support passing the queue_name to the status updates.
1105          - Support fetching patch status with patch_status().
1106         * Scripts/modules/workqueue.py:
1107          - Pass the patch to the StatusBot instead of the bug_id.
1108          - Let WorkQueues have a name.
1109
1110 2009-11-20  Adam Barth  <abarth@webkit.org>
1111
1112         Reviewed by Eric Seidel.
1113
1114         Move bugzilla-tool commands into their own file
1115         https://bugs.webkit.org/show_bug.cgi?id=31752
1116
1117         This will let us write unit tests.
1118
1119         * Scripts/bugzilla-tool:
1120         * Scripts/modules/commands/__init__.py: Added.
1121         * Scripts/modules/commands/download.py: Added.
1122         * Scripts/modules/commands/queries.py: Added.
1123         * Scripts/modules/commands/queues.py: Added.
1124         * Scripts/modules/commands/upload.py: Added.
1125         * Scripts/modules/grammar.py: Added.
1126
1127 2009-11-20  Adam Barth  <abarth@webkit.org>
1128
1129         Reviewed by Eric Seidel.
1130
1131         BuildQueue should check if the tree is currently buildable
1132         https://bugs.webkit.org/show_bug.cgi?id=31744
1133
1134         * Scripts/bugzilla-tool:
1135         * Scripts/modules/landingsequence.py:
1136         * Scripts/modules/webkitlandingscripts.py:
1137
1138 2009-11-20  Adam Barth  <abarth@webkit.org>
1139
1140         Reviewed by Eric Seidel.
1141
1142         Move prepare_clean_working_directory into the LandingSequence
1143         https://bugs.webkit.org/show_bug.cgi?id=31743
1144
1145         * Scripts/bugzilla-tool:
1146         * Scripts/modules/landingsequence.py:
1147
1148 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
1149
1150         Reviewed by Kenneth Rohde Christiansen.
1151
1152         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
1153         https://bugs.webkit.org/show_bug.cgi?id=30460
1154
1155         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
1156
1157         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1158         (pluginInvoke):
1159
1160 2009-11-20  Adam Barth  <abarth@webkit.org>
1161
1162         Reviewed by Eric Seidel.
1163
1164         Pass the port information to the child process
1165         https://bugs.webkit.org/show_bug.cgi?id=31736
1166
1167         We need to do this so the child process knows what to build!
1168
1169         * Scripts/bugzilla-tool:
1170         * Scripts/modules/landingsequence.py:
1171         * Scripts/modules/webkitport.py:
1172         * Scripts/modules/webkitport_unittest.py:
1173
1174 2009-11-20  Adam Barth  <abarth@webkit.org>
1175
1176         Reviewed by Eric Seidel.
1177
1178         Support Qt port in build-queue
1179         https://bugs.webkit.org/show_bug.cgi?id=31733
1180
1181         * Scripts/bugzilla-tool:
1182
1183 2009-11-20  Adam Barth  <abarth@webkit.org>
1184
1185         Reviewed by Eric Seidel.
1186
1187         Implement a build-queue
1188         https://bugs.webkit.org/show_bug.cgi?id=31725
1189
1190         Currently this just builds the first 10 patches in the review queue.
1191         We'll want to do something smarter soon.
1192
1193         * Scripts/bugzilla-tool:
1194
1195 2009-11-20  Adam Barth  <abarth@webkit.org>
1196
1197         Reviewed by Eric Seidel.
1198
1199         Make commit-queue and style-queue show up in help
1200         https://bugs.webkit.org/show_bug.cgi?id=31724
1201
1202         We need to store their names on their class to make these commands
1203         properly register themselves with MultiCommandTool.
1204
1205         * Scripts/bugzilla-tool:
1206
1207 2009-11-20  Adam Barth  <abarth@webkit.org>
1208
1209         Reviewed by Eric Seidel.
1210
1211         Implement bugzilla-tool build-attachment
1212         https://bugs.webkit.org/show_bug.cgi?id=31722
1213
1214         This command builds an attachment from bugzilla.  It leaves the built
1215         patch in the working copy.
1216
1217         * Scripts/bugzilla-tool:
1218         * Scripts/modules/landingsequence.py:
1219         * Scripts/modules/webkitlandingscripts.py:
1220
1221 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
1222
1223         Reviewed by Xan Lopez.
1224
1225         [GTK] DRT release event does not create the state correctly
1226         https://bugs.webkit.org/show_bug.cgi?id=31717
1227
1228         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1229
1230 2009-11-20  Eric Seidel  <eric@webkit.org>
1231
1232         Reviewed by Adam Barth.
1233
1234         MultiCommandTool should find Command objects automatically instead of with a manual list
1235         https://bugs.webkit.org/show_bug.cgi?id=31710
1236
1237         * Scripts/bugzilla-tool:
1238         * Scripts/modules/multicommandtool.py:
1239          - Use some wild python-fu to crawl all the known subclasses of Command.
1240
1241 2009-11-20  Adam Barth  <abarth@webkit.org>
1242
1243         Unreviewed "build" fix.  Added missing import.
1244
1245         * Scripts/bugzilla-tool:
1246
1247 2009-11-20  Adam Barth  <abarth@webkit.org>
1248
1249         Unreviewed "build" fix.  I failed to update LandingSequence.test
1250         properly.
1251
1252         * Scripts/modules/landingsequence.py:
1253
1254 2009-11-20  Adam Barth  <abarth@webkit.org>
1255
1256         Reviewed by Eric Seidel.
1257
1258         Create LandingSequence as the all-sing, all-dance landing class
1259         https://bugs.webkit.org/show_bug.cgi?id=31709
1260
1261         Client can inherit from this class to carefully control exactly which
1262         steps they wish to have happen in the landing sequence.
1263
1264         * Scripts/bugzilla-tool:
1265         * Scripts/modules/landingsequence.py: Added.
1266         * Scripts/modules/webkitlandingscripts.py: Added.
1267
1268 2009-11-19  Adam Barth  <abarth@webkit.org>
1269
1270         Reviewed by Eric Seidel.
1271
1272         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
1273         https://bugs.webkit.org/show_bug.cgi?id=31707
1274
1275         This is to help when we implement build-attachment.
1276
1277         * Scripts/bugzilla-tool:
1278
1279 2009-11-19  Adam Barth  <abarth@webkit.org>
1280
1281         Reviewed by Eric Seidel.
1282
1283         Support Qt port in bugzilla-tool
1284         https://bugs.webkit.org/show_bug.cgi?id=31701
1285
1286         Now we support building with Qt!
1287
1288         * Scripts/bugzilla-tool:
1289         * Scripts/modules/webkitport.py: Added.
1290         * Scripts/modules/webkitport_unittest.py: Added.
1291         * Scripts/run-webkit-unittests:
1292
1293 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
1294
1295         Reviewed by Adam Barth.
1296
1297         Remove inserting stderr into patch in bugzilla-tool
1298         https://bugs.webkit.org/show_bug.cgi?id=29914
1299
1300         Modify SCM python module's run_command function to avoid return of stderr
1301         by default, so stderr won't be inserted into the patches.
1302         Modify the related unit test.
1303
1304         * Scripts/modules/scm.py:
1305         * Scripts/modules/scm_unittest.py:
1306
1307 2009-11-19  Eric Seidel  <eric@webkit.org>
1308
1309         Reviewed by Adam Barth.
1310
1311         bugzilla-tool needs per-command help
1312         https://bugs.webkit.org/show_bug.cgi?id=31697
1313
1314         Added support for "bugzilla-tool help command-name"
1315         and a unit test to make sure it works.
1316
1317         * Scripts/modules/multicommandtool.py:
1318         * Scripts/modules/multicommandtool_unittest.py:
1319
1320 2009-11-19  Eric Seidel  <eric@webkit.org>
1321
1322         Reviewed by Adam Barth.
1323
1324         Move MultiCommandTool and Command into a separate file and add some basic unit tests
1325         https://bugs.webkit.org/show_bug.cgi?id=31695
1326
1327         * Scripts/bugzilla-tool:
1328         * Scripts/modules/multicommandtool.py: Added.
1329         * Scripts/modules/multicommandtool_unittest.py: Added.
1330         * Scripts/run-webkit-unittests:
1331
1332 2009-11-19  Eric Seidel  <eric@webkit.org>
1333
1334         No review, just adding a FIXME.
1335
1336         Split out command parsing and help printing from BugzillaTool
1337         https://bugs.webkit.org/show_bug.cgi?id=31688
1338
1339         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
1340
1341 2009-11-19  Eric Seidel  <eric@webkit.org>
1342
1343         Reviewed by Adam Barth.
1344
1345         Split out command parsing and help printing from BugzillaTool
1346         https://bugs.webkit.org/show_bug.cgi?id=31688
1347
1348         * Scripts/bugzilla-tool:
1349          - Add new MultiCommandTool class to contain option parsing and help printing logic.
1350          - Rename private methods to use _ pattern.
1351          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
1352          - 
1353
1354 2009-11-19  Eric Seidel  <eric@webkit.org>
1355
1356         Reviewed by Adam Barth.
1357
1358         Re-factor help printing to use modern python idioms
1359         https://bugs.webkit.org/show_bug.cgi?id=31685
1360
1361         * Scripts/bugzilla-tool:
1362
1363 2009-11-19  Eric Seidel  <eric@webkit.org>
1364
1365         Reviewed by Darin Adler.
1366
1367         commit-queue empty queue logs twice
1368         https://bugs.webkit.org/show_bug.cgi?id=31679
1369
1370         * Scripts/bugzilla-tool:
1371
1372 2009-11-19  Eric Seidel  <eric@webkit.org>
1373
1374         Reviewed by Darin Adler.
1375
1376         bugzilla-tool's reviewer/committer rejection message should be clearer
1377         https://bugs.webkit.org/show_bug.cgi?id=31126
1378
1379         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1380
1381         * Scripts/modules/bugzilla.py:
1382
1383 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1384
1385         Reviewed by Pavel Feldman.
1386
1387         Forces a WM_PAINT event on calling layoutTestController.display()
1388         in order to enable the timeline-paint.html test on Windows.
1389         ::UpdateWindow() does not force an event becaue the window is 
1390         not visible.
1391
1392         https://bugs.webkit.org/show_bug.cgi?id=31402
1393
1394         * DumpRenderTree/win/DumpRenderTree.cpp:
1395         (displayWebView):
1396
1397 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1398
1399         No review needed.
1400
1401         Added myself to committers list.
1402
1403         * Scripts/modules/committers.py:
1404
1405 2009-11-19  Adam Barth  <abarth@webkit.org>
1406
1407         Reviewed by Eric Seidel.
1408
1409         Bugzilla-tool command classes should match command names
1410         https://bugs.webkit.org/show_bug.cgi?id=31666
1411
1412         I renamed all the commands except CommitMessageForCurrentDiff because
1413         the new name would conflict with an existing class.
1414
1415         * Scripts/bugzilla-tool:
1416
1417 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1418
1419         Reviewed by Gustavo Noronha Silva.
1420
1421         Web Inspector: Implement "show inspector" in WebKit GTK
1422         API and enable console tests.
1423
1424         https://bugs.webkit.org/show_bug.cgi?id=31669
1425
1426         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1427         (LayoutTestController::showWebInspector):
1428
1429 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1430
1431         Reviewed by Simon Hausmann.
1432
1433         Minor refactoring + more documentation.
1434
1435         * DumpRenderTree/qt/DumpRenderTree.cpp:
1436         (WebCore::clearHistory):
1437         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1438
1439 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1440
1441         Reviewed by Eric Seidel.
1442
1443         Ignore websocket tests when --no-http is specified.
1444         https://bugs.webkit.org/show_bug.cgi?id=31662
1445
1446         * Scripts/run-webkit-tests:
1447
1448 2009-11-18  Adam Barth  <abarth@webkit.org>
1449
1450         Reviewed by Eric Seidel.
1451
1452         Normalize ' and " in bugzilla-tool
1453         https://bugs.webkit.org/show_bug.cgi?id=31655
1454
1455         We decided " is better than ' and we should be consistent.
1456
1457         * Scripts/bugzilla-tool:
1458
1459 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1460
1461         Reviewed by Kenneth Rohde Christiansen.
1462
1463         [Qt] Remove support for Qt v4.3 or older versions
1464         https://bugs.webkit.org/show_bug.cgi?id=29469
1465
1466         * DumpRenderTree/qt/DumpRenderTree.pro:
1467         * DumpRenderTree/qt/ImageDiff.pro:
1468
1469 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1470
1471         Reviewed by Eric Seidel.
1472
1473         GitTest.test_create_binary_patch fails if /tmp is symlink
1474         https://bugs.webkit.org/show_bug.cgi?id=31536
1475
1476         * Scripts/modules/scm_unittest.py:
1477
1478 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1479
1480         Reviewed by Darin Adler.
1481
1482         Configuration for Chromium Build Slaves.
1483
1484         https://bugs.webkit.org/show_bug.cgi?id=31442
1485
1486         * BuildSlaveSupport/build.webkit.org-config/config.json:
1487         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1488
1489 2009-11-18  Eric Seidel  <eric@webkit.org>
1490
1491         Reviewed by Darin Adler.
1492
1493         workqueue.py results in totally broken commit-queue UI
1494         https://bugs.webkit.org/show_bug.cgi?id=31645
1495
1496         * Scripts/bugzilla-tool:
1497          - Remove unneeded use of PatchCollection.
1498          - Grab a new copy of the cq'd patches every run of the queue.
1499
1500 2009-11-18  Sam Weinig  <sam@webkit.org>
1501
1502         Reviewed by Anders Carlsson.
1503
1504         Make the Mac Geolocation API async.
1505
1506         Update DRT to use the new async Mac Geolocation API.
1507
1508         * DumpRenderTree/mac/UIDelegate.mm:
1509         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1510
1511 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1512
1513         Reviewed by Kenneth Rohde Christiansen.
1514
1515         Add and option to toggle HTML5 datalist support to build-webkit
1516         https://bugs.webkit.org/show_bug.cgi?id=31599
1517
1518         * Scripts/build-webkit:
1519
1520 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1521
1522         Reviewed by Kevin Ollivier.
1523
1524         Enable wx plugin support using the Windows implementation as a base.
1525         
1526         https://bugs.webkit.org/show_bug.cgi?id=31636
1527
1528         * wx/build/settings.py:
1529
1530 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1531
1532         Reviewed by Simon Hausmann.
1533
1534         Change the initialization order so that the controllers
1535         will be created before exporting them to the JS DOM window.
1536
1537         * DumpRenderTree/qt/DumpRenderTree.cpp:
1538         (WebCore::DumpRenderTree::DumpRenderTree):
1539
1540 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1541
1542         Reviewed by Simon Hausmann.
1543
1544         Fix a code copy and paste error. m_page should be page.
1545
1546         * DumpRenderTree/qt/DumpRenderTree.cpp:
1547         (WebCore::DumpRenderTree::createWindow):
1548
1549 2009-11-17  Mark Rowe  <mrowe@apple.com>
1550
1551         Reviewed by Alexey Proskuryakov.
1552
1553         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1554
1555         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1556         This prevents symlinks from confusing the descendant check.
1557
1558 2009-11-17  Mark Rowe  <mrowe@apple.com>
1559
1560         Reviewed by Alexey Proskuryakov.
1561
1562         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1563
1564         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1565         server to be up rather than having run-webkit-tests abort immediately.
1566
1567         * Scripts/run-webkit-tests:
1568
1569 2009-11-17  Eric Seidel  <eric@webkit.org>
1570
1571         Reviewed by Darin Adler.
1572
1573         commit-queue is failing to set reviewer in ChangeLogs
1574         https://bugs.webkit.org/show_bug.cgi?id=31592
1575
1576         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1577         * Scripts/modules/bugzilla.py:
1578          - Add a new _validate_committer_and_reviewer function as a
1579            temporary solution until we can make a real Attachment object
1580            which knows how to fill in its committer/reviewer fields automatically.
1581
1582 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1583
1584         Unreviewed buildbot fix.
1585
1586         Revert part of earlier patch and add comment, as it
1587         was causing timeouts on the buildbot.
1588
1589         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1590         (LayoutTestController::notifyDone):
1591
1592 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1593
1594         Reviewed by Oliver Hunt.
1595
1596         Make the timeout 15 sec as for the other DRT's and make
1597         it print out the same output when a test timeout.
1598
1599         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1600         (LayoutTestController::waitUntilDone):
1601         (LayoutTestController::notifyDone):
1602         (LayoutTestController::timerEvent):
1603
1604 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1605
1606         Reviewed by Timothy Hatcher.
1607
1608         Fixed typos in comments.
1609
1610         * Scripts/modules/committers.py:
1611
1612 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1613
1614         Reviewed by Timothy Hatcher.
1615
1616         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1617         - Updated DRT to show/close inspector for all tests under /inspector
1618         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1619           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1620         - Removed reload on each inspector test
1621         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1622         inspector for those.
1623         - Reimplemented timeline tests in order to get rid of reload there.
1624         - Moved tests that don't require harness into the fast group.
1625
1626         https://bugs.webkit.org/show_bug.cgi?id=31472
1627
1628         * DumpRenderTree/LayoutTestController.cpp:
1629         (setTimelineProfilingEnabledCallback):
1630         (closeWebInspectorCallback):
1631         (LayoutTestController::staticFunctions):
1632         * DumpRenderTree/LayoutTestController.h:
1633         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1634         (shouldOpenWebInspector):
1635         (runTest):
1636         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1637         (LayoutTestController::setTimelineProfilingEnabled):
1638         * DumpRenderTree/mac/DumpRenderTree.mm:
1639         (shouldOpenWebInspector):
1640         (runTest):
1641         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1642         (LayoutTestController::setTimelineProfilingEnabled):
1643         * DumpRenderTree/win/DumpRenderTree.cpp:
1644         (shouldOpenWebInspector):
1645         (runTest):
1646         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1647         (LayoutTestController::setTimelineProfilingEnabled):
1648
1649 2009-11-17  Oliver Hunt  <oliver@apple.com>
1650
1651         Reviewed by Maciej Stachowiak.
1652
1653         Incorrect use of JavaScriptCore API in DumpRenderTree
1654         https://bugs.webkit.org/show_bug.cgi?id=31577
1655
1656         Return undefined rather than a literal null.
1657
1658         * DumpRenderTree/AccessibilityUIElement.cpp:
1659         (setSelectedTextRangeCallback):
1660         (incrementCallback):
1661         (decrementCallback):
1662         (showMenuCallback):
1663
1664 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1665
1666         Reviewed by Beth Dakin.
1667
1668         AX: aria-labelledby duplicates some of its WAI-ARIA label
1669         https://bugs.webkit.org/show_bug.cgi?id=31565
1670
1671         * DumpRenderTree/AccessibilityUIElement.cpp:
1672         (titleUIElementCallback):
1673         (getIsValidCallback):
1674         (AccessibilityUIElement::getJSClass):
1675
1676 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1677
1678         Reviewed by Simon Hausmann.
1679
1680         r50942 broke output from created windows. Make the
1681         m_enableTextOutput a member of the DRT and not the
1682         WebPage.
1683
1684         * DumpRenderTree/qt/DumpRenderTree.cpp:
1685         (WebCore::WebPage::WebPage):
1686         (WebCore::WebPage::javaScriptAlert):
1687         (WebCore::WebPage::javaScriptConsoleMessage):
1688         (WebCore::WebPage::javaScriptConfirm):
1689         (WebCore::WebPage::javaScriptPrompt):
1690         (WebCore::WebPage::acceptNavigationRequest):
1691         (WebCore::DumpRenderTree::DumpRenderTree):
1692         (WebCore::DumpRenderTree::open):
1693         (WebCore::DumpRenderTree::createWindow):
1694         * DumpRenderTree/qt/DumpRenderTree.h:
1695         (WebCore::DumpRenderTree::setTextOutputEnabled):
1696         (WebCore::DumpRenderTree::isTextOutputEnabled):
1697         (WebCore::WebPage::shouldInterruptJavaScript):
1698         (WebCore::WebPage::isTextOutputEnabled):
1699         (WebCore::WebPage::setViewGeometry):
1700
1701 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1702
1703         Reviewed by Gustavo Noronha Silva.
1704
1705         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1706         as the implementation is being used by at least Qt and Gtk+.
1707
1708         Update buildsystems as well.
1709
1710         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1711         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1712         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1713         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1714         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1715         * GNUmakefile.am:
1716
1717 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1718
1719         Reviewed by Alexey Proskuryakov.
1720
1721         Disable wss until all platforms support pyOpenSSL
1722
1723         https://bugs.webkit.org/show_bug.cgi?id=31479
1724
1725         * Scripts/run-webkit-tests:
1726
1727 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1728
1729         Reviewed by Kenneth Christiansen.
1730
1731         [Qt] Implement load error pages support for Qt's DRT.
1732         https://bugs.webkit.org/show_bug.cgi?id=31509
1733
1734         For now, it will not be a default feature, and layout tests
1735         that want to make use of this have to explicitily call
1736         'handleErrorPages();' for the test source.
1737
1738         Any of the other DumpRenderTree's (mac, win and gtk)
1739         support handling error pages. Qt's will be the first.
1740
1741         * DumpRenderTree/qt/DumpRenderTree.cpp:
1742         (WebCore::WebPage::supportsExtension):
1743         (WebCore::WebPage::extension):
1744         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1745         (LayoutTestController::reset):
1746         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1747         (LayoutTestController::shouldHandleErrorPages):
1748         (LayoutTestController::handleErrorPages):
1749
1750 2009-11-16  Eric Seidel  <eric@webkit.org>
1751
1752         Reviewed by Adam Barth.
1753
1754         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1755         https://bugs.webkit.org/show_bug.cgi?id=31549
1756
1757         Renamed --commit-queue to --non-interactive in most places
1758         and remove the code in land-patches which is no longer needed.
1759
1760         * Scripts/bugzilla-tool:
1761
1762 2009-11-16  Eric Seidel  <eric@webkit.org>
1763
1764         Reviewed by Adam Barth.
1765
1766         The commit-queue should use land-attachment
1767         https://bugs.webkit.org/show_bug.cgi?id=31548
1768
1769         * Scripts/bugzilla-tool:
1770
1771 2009-11-16  Adam Barth  <abarth@webkit.org>
1772
1773         Reviewed by Eric Seidel.
1774
1775         Convert CommitQueue over to PatchCollection
1776         https://bugs.webkit.org/show_bug.cgi?id=31547
1777
1778         Also fixes a bug in workqueue and adds a test!
1779
1780         * Scripts/bugzilla-tool:
1781         * Scripts/modules/workqueue.py:
1782         * Scripts/modules/workqueue_unittest.py:
1783
1784 2009-11-16  Adam Barth  <abarth@webkit.org>
1785
1786         Reviewed by Eric Seidel.
1787
1788         Move StyleQueue over to using PatchCollection
1789         https://bugs.webkit.org/show_bug.cgi?id=31544
1790
1791         That's what the class it's for.
1792
1793         * Scripts/bugzilla-tool:
1794         * Scripts/modules/patchcollection.py:
1795         * Scripts/modules/patchcollection_unittest.py:
1796
1797 2009-11-16  Eric Seidel  <eric@webkit.org>
1798
1799         Reviewed by Adam Barth.
1800
1801         bugzilla-tool needs a land-attachment command
1802         https://bugs.webkit.org/show_bug.cgi?id=31546
1803
1804         * Scripts/bugzilla-tool:
1805          - Move all the logic into AbstractLandingCommand and
1806            add a new LandAttachment command subclass.
1807          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1808
1809 2009-11-16  Eric Seidel  <eric@webkit.org>
1810
1811         Reviewed by Adam Barth.
1812
1813         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1814         https://bugs.webkit.org/show_bug.cgi?id=31543
1815
1816         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1817
1818         * Scripts/bugzilla-tool:
1819
1820 2009-11-16  Eric Seidel  <eric@webkit.org>
1821
1822         Reviewed by Adam Barth.
1823
1824         Disable the style queue from posting to the commit queue status page.
1825
1826         * Scripts/bugzilla-tool:
1827
1828 2009-11-16  Adam Barth  <abarth@webkit.org>
1829
1830         Reviewed by Eric Seidel.
1831
1832         Implement PatchCollection
1833         https://bugs.webkit.org/show_bug.cgi?id=31541
1834
1835         This class holds a set of patches and lets clients iterate through
1836         them.  Optionally, clients can install a filter.
1837
1838         * Scripts/modules/patchcollection.py: Added.
1839         * Scripts/modules/patchcollection_unittest.py: Added.
1840         * Scripts/run-webkit-unittests:
1841
1842 2009-11-16  Eric Seidel  <eric@webkit.org>
1843
1844         Reviewed by Adam Barth.
1845
1846         bugzilla-tool land-patches will close bugs with patches r=?
1847         https://bugs.webkit.org/show_bug.cgi?id=28230
1848
1849         The commit-queue shouldn't close patches with outstanding reviews on them,
1850         even if many reviewers seem to be against multi-patch bugs.
1851
1852         * Scripts/bugzilla-tool:
1853
1854 2009-11-16  Eric Seidel  <eric@webkit.org>
1855
1856         Reviewed by Adam Barth.
1857
1858         bugzilla-tool check-style should work with attachment ids instead of bug ids
1859         https://bugs.webkit.org/show_bug.cgi?id=31540
1860
1861         * Scripts/bugzilla-tool:
1862
1863 2009-11-16  Eric Seidel  <eric@webkit.org>
1864
1865         Reviewed by Adam Barth.
1866
1867         WorkQueue is the only place that should know about special exit codes
1868         https://bugs.webkit.org/show_bug.cgi?id=31534
1869
1870         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1871         and add tests for handling exit codes.
1872         I also cleaned up workqueue_unittest.py more.
1873
1874         * Scripts/bugzilla-tool:
1875         * Scripts/modules/workqueue.py:
1876         * Scripts/modules/workqueue_unittest.py:
1877
1878 2009-11-16  Eric Seidel  <eric@webkit.org>
1879
1880         Reviewed by Adam Barth.
1881
1882         Re-factor workqueue_unittest to allow for more than one test.
1883         https://bugs.webkit.org/show_bug.cgi?id=31535
1884
1885         * Scripts/modules/workqueue_unittest.py:
1886
1887 2009-11-16  Eric Seidel  <eric@webkit.org>
1888
1889         Reviewed by Adam Barth.
1890
1891         land-patches needs to be re-factored into smaller chunks
1892         https://bugs.webkit.org/show_bug.cgi?id=31532
1893
1894         * Scripts/bugzilla-tool: fix a couple obvious typos.
1895
1896 2009-11-16  Eric Seidel  <eric@webkit.org>
1897
1898         Reviewed by Adam Barth.
1899
1900         land-patches needs to be re-factored into smaller chunks
1901         https://bugs.webkit.org/show_bug.cgi?id=31532
1902
1903         The next patch will move these methods into WebKitLandingScripts.
1904
1905         * Scripts/bugzilla-tool:
1906          - Split out _land_patch and _close_bug_if_no_active_patches.
1907
1908 2009-11-16  Adam Barth  <abarth@webkit.org>
1909
1910         Reviewed by Eric Seidel.
1911
1912         Fix silly copy-and-paste code.  I am a terrible coder.
1913
1914         * Scripts/modules/bugzilla.py:
1915
1916 2009-11-16  Adam Barth  <abarth@webkit.org>
1917
1918         Reviewed by Eric Seidel.
1919
1920         Implement a StyleQueue
1921         https://bugs.webkit.org/show_bug.cgi?id=31537
1922
1923         The first iteration of the style queue only produces output locally.
1924         There is also a limit of 10 patches because it's not that useful to
1925         iterate through the entire review queue at this point.  We can remove
1926         the limit later.
1927
1928         * Scripts/bugzilla-tool:
1929         * Scripts/modules/bugzilla.py:
1930
1931 2009-11-16  Adam Barth  <abarth@webkit.org>
1932
1933         Reviewed by Eric Seidel.
1934
1935         Unit test WorkQueue
1936         https://bugs.webkit.org/show_bug.cgi?id=31531
1937
1938         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1939
1940         * Scripts/bugzilla-tool:
1941         * Scripts/modules/statusbot.py:
1942         * Scripts/modules/workqueue.py:
1943         * Scripts/modules/workqueue_unittest.py: Added.
1944         * Scripts/run-webkit-unittests:
1945
1946 2009-11-16  Eric Seidel  <eric@webkit.org>
1947
1948         Reviewed by Adam Barth.
1949
1950         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1951         https://bugs.webkit.org/show_bug.cgi?id=31530
1952
1953         * Scripts/bugzilla-tool:
1954
1955 2009-11-16  Eric Seidel  <eric@webkit.org>
1956
1957         Reviewed by Adam Barth.
1958
1959         bugzilla-tool needs apply-attachment
1960         https://bugs.webkit.org/show_bug.cgi?id=31528
1961
1962         * Scripts/bugzilla-tool:
1963          - Add ApplyAttachment command.
1964          - Abstract applying code into WebKitApplyingScripts.
1965          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1966         * Scripts/modules/bugzilla.py:
1967          - Add fetch_attachment and bug_id_for_attachment_id.
1968         * Scripts/modules/bugzilla_unittest.py:
1969          - Add test for new parsing.
1970          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1971
1972 2009-11-16  Eric Seidel  <eric@webkit.org>
1973
1974         Reviewed by Adam Barth.
1975
1976         Document check-style's use of force_clean.
1977
1978         * Scripts/bugzilla-tool:
1979         * Scripts/modules/scm.py:
1980
1981 2009-11-16  Adam Barth  <abarth@webkit.org>
1982
1983         Reviewed by Eric Seidel.
1984
1985         Move WorkQueue to its own file
1986         https://bugs.webkit.org/show_bug.cgi?id=31529
1987
1988         WorkQueue and WorkQueueDelegate are separate concerns from
1989         bugzilla-tool.  Also added a missing include to logging.py.
1990
1991         * Scripts/bugzilla-tool:
1992         * Scripts/modules/logging.py:
1993         * Scripts/modules/workqueue.py:
1994
1995 2009-11-16  Adam Barth  <abarth@webkit.org>
1996
1997         Reviewed by Eric Seidel.
1998
1999         Move OutputTee to logging.py.
2000
2001         * Scripts/bugzilla-tool:
2002         * Scripts/modules/logging.py:
2003
2004 2009-11-15  Adam Barth  <abarth@webkit.org>
2005
2006         Reviewed by Eric Seidel.
2007
2008         Refactor bugzilla-tool to allow for multiple queues
2009         https://bugs.webkit.org/show_bug.cgi?id=31513
2010
2011         Divide the commit queue class into three class to make creating
2012         additional queues easier.
2013
2014         * Scripts/bugzilla-tool:
2015
2016 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2017
2018         Reviewed by Eric Seidel.
2019
2020         svn-apply may not handle git patches created by bugzilla-tool
2021         https://bugs.webkit.org/show_bug.cgi?id=31457
2022
2023         * Scripts/modules/scm.py:
2024         * Scripts/modules/scm_unittest.py:
2025
2026 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2027
2028         Reviewed by Eric Seidel.
2029
2030         bugzilla-tool should post git binary diff
2031         https://bugs.webkit.org/show_bug.cgi?id=31458
2032
2033         Add --binary option to Git.create_patch.
2034
2035         * Scripts/modules/scm.py:
2036         * Scripts/modules/scm_unittest.py:
2037
2038 2009-11-15  Adam Barth  <abarth@webkit.org>
2039
2040         Reviewed by Darin Adler.
2041
2042         Add bugzilla-tool check-style
2043         https://bugs.webkit.org/show_bug.cgi?id=31515
2044
2045         * Scripts/bugzilla-tool:
2046         * Scripts/modules/bugzilla.py:
2047
2048 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2049
2050         Reviewed by Simon Hausmann.
2051
2052         Make the Qt Linux only --valgrind feature, suppress errors
2053         defined in the SuppressedValgrindErrors file.
2054
2055         * Scripts/run-webkit-tests:
2056
2057 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2058
2059         Reviewed by Simon Hausmann.
2060
2061         Set the locale to C and not to the current one in use on the system.
2062
2063         * DumpRenderTree/qt/DumpRenderTree.cpp:
2064         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2065
2066 2009-11-13  Adam Roben  <aroben@apple.com>
2067
2068         Add support for
2069         http/tests/security/isolatedWorld/didClearWindowObject.html
2070
2071         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
2072         window objects in isolated worlds are cleared
2073
2074         Reviewed by Dave Hyatt.
2075
2076         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
2077
2078         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2079         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2080         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
2081         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
2082         Added. Sets a __worldID property on the global object whose value is
2083         the ID of this world.
2084         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
2085         Respond to this new delegate callback by calling through to one of the
2086         above new methods.
2087         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2088         (worldMap): Added. Returns a HashMap containing all the worlds we've
2089         created.
2090         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
2091         haven't kept track of this world.
2092         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2093         instead of declaring our own.
2094
2095         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
2096
2097         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2098         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
2099         didClearWindowObjectForFrameInStandardWorld.
2100         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
2101         Respond to this new delegate callback by calling through to one of the
2102         below new methods.
2103         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
2104         Added. Sets a __worldID property on the gobal object whose value is
2105         the ID of this world.
2106         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2107         Added. Moved code here from didClearWindowObject.
2108
2109         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
2110         didClearWindowObjectForFrame* functions.
2111
2112         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2113         (worldMap): Added. Returns a HashMap containing all the worlds we've
2114         created.
2115         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
2116         haven't kept track of this world.
2117         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2118         instead of declaring our own.
2119
2120 2009-11-13  Adam Roben  <aroben@apple.com>
2121
2122         Finish replacing worldIDs with world objects
2123
2124         The only remaining use of worldIDs was in a method only used by DRT
2125         for the isolated worlds tests.
2126
2127         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
2128
2129         Reviewed by Mark Rowe.
2130
2131         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2132         (LayoutTestController::evaluateScriptInIsolatedWorld):
2133         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2134         (LayoutTestController::evaluateScriptInIsolatedWorld):
2135         Updated for changes to WebFrame. Now holds the map of worldID -> world
2136         at this level instead of making WebKit do it.
2137
2138 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2139
2140         Reviewed by Simon Hausmann.
2141
2142         [Qt] Ensure the DRT does not output anything until first test is run
2143
2144         * DumpRenderTree/qt/DumpRenderTree.cpp:
2145         * DumpRenderTree/qt/DumpRenderTree.h:
2146
2147 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2148
2149         Reviewed by Tor Arne Vestbø.
2150
2151         Clear the undo stack in before each new test run.
2152
2153         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
2154
2155         * DumpRenderTree/qt/DumpRenderTree.cpp:
2156         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2157
2158 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2159
2160         Reviewed by Kenneth Rohde Christiansen.
2161
2162         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
2163
2164         * DumpRenderTree/qt/DumpRenderTree.cpp:
2165         (WebCore::WebPage::resetSettings):
2166         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2167         (LayoutTestController::overridePreference):
2168
2169 2009-11-13  Eric Seidel  <eric@webkit.org>
2170
2171         Reviewed by Adam Barth.
2172
2173         Update committers.py based on svn records
2174         https://bugs.webkit.org/show_bug.cgi?id=31366
2175
2176         This list was generated using validate-committer-lists from
2177         https://bugs.webkit.org/show_bug.cgi?id=30970
2178         and makes committers.py current for committers who have
2179         committed in the last 3 years.
2180
2181         * Scripts/modules/committers.py:
2182
2183 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
2184
2185         Reviewed by Adam Barth.
2186
2187         The document-open.html test was flaky at times. The test invokes the layout test plugin
2188         which in its destroy stream handler opens a new document. This basically tears down the
2189         stream and the associated plugin instance. The pluginLog function in the layout test
2190         plugin attempts to retrieve the window script object on a torn down plugin instance
2191         which crashed consistently on windows in the debugger. The functions which issue
2192         these logs already have a valid window script object. We now have variants of the pluginLog
2193         function which take in a window script object with and without variable arguments. 
2194
2195         https://bugs.webkit.org/show_bug.cgi?id=31067
2196
2197         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2198         (pluginLogWithWindowObject):
2199         (pluginLogWithWindowObjectVariableArgs):
2200         (pluginLog):
2201         (notifyTestCompletion):
2202         (testDocumentOpen):
2203         (testWindowOpen):
2204
2205 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2206
2207         Reviewed by Gustavo Noronha Silva.
2208
2209         https://bugs.webkit.org/show_bug.cgi?id=30997
2210         [Gtk] Implemment AtkDocument
2211
2212         Added testing support.
2213
2214         * DumpRenderTree/AccessibilityUIElement.cpp:
2215         * DumpRenderTree/AccessibilityUIElement.h:
2216         (getDocumentEncodingCallback):
2217         (getDocumentURICallback):
2218         (AccessibilityUIElement::getJSClass):
2219         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2220         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2221         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2222         (AccessibilityUIElement::documentEncoding):
2223         (AccessibilityUIElement::documentURI):
2224
2225 2009-11-12  Adam Roben  <aroben@apple.com>
2226
2227         Replace worldIDs with world objects
2228
2229         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
2230         user scripts/stylesheets and isolated worlds
2231
2232         Reviewed by Sam Weinig.
2233
2234         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2235         (LayoutTestController::addUserScript):
2236         (LayoutTestController::addUserStyleSheet):
2237         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2238         (LayoutTestController::addUserScript):
2239         (LayoutTestController::addUserStyleSheet):
2240         Changed these functions to create a new WebJSWorld each time they're
2241         called and to pass that world to WebKit.
2242
2243 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
2244
2245         Reviewed by Oliver Hunt.
2246
2247         need to implement aria tree roles
2248         https://bugs.webkit.org/show_bug.cgi?id=31284
2249
2250         * DumpRenderTree/AccessibilityUIElement.cpp:
2251         (disclosedRowAtIndexCallback):
2252         (selectedRowAtIndexCallback):
2253         (isEqualCallback):
2254         (isAttributeSettableCallback):
2255         (isActionSupportedCallback):
2256         (disclosedByRowCallback):
2257         (hierarchicalLevelCallback):
2258         (AccessibilityUIElement::getJSClass):
2259         * DumpRenderTree/AccessibilityUIElement.h:
2260         (AccessibilityUIElement::isEqual):
2261         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2262         (AccessibilityUIElement::hierarchicalLevel):
2263         (AccessibilityUIElement::disclosedRowAtIndex):
2264         (AccessibilityUIElement::selectedRowAtIndex):
2265         (AccessibilityUIElement::disclosedByRow):
2266         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2267         (AccessibilityUIElement::getChildAtIndex):
2268         (AccessibilityUIElement::disclosedRowAtIndex):
2269         (AccessibilityUIElement::selectedRowAtIndex):
2270         (AccessibilityUIElement::titleUIElement):
2271         (AccessibilityUIElement::parentElement):
2272         (AccessibilityUIElement::disclosedByRow):
2273         (AccessibilityUIElement::hierarchicalLevel):
2274         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2275         (AccessibilityUIElement::hierarchicalLevel):
2276         (AccessibilityUIElement::disclosedRowAtIndex):
2277         (AccessibilityUIElement::selectedRowAtIndex):
2278         (AccessibilityUIElement::disclosedByRow):
2279
2280 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
2281
2282         Reviewed by Darin Adler.
2283
2284         svn-apply can not handle git binary diffs
2285         https://bugs.webkit.org/show_bug.cgi?id=26830
2286
2287         Support "literal" type git binary diffs.
2288
2289         * Scripts/VCSUtils.pm:
2290         * Scripts/modules/scm_unittest.py:
2291         * Scripts/svn-apply:
2292
2293 2009-11-11  Dmitry Titov  <dimich@chromium.org>
2294
2295         Not reviewed, removing duplicate entry for myself in committers.py.
2296
2297         * Scripts/modules/committers.py:
2298
2299 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
2300
2301         Reviewed by Darin Adler and Mark Rowe.
2302
2303         https://bugs.webkit.org/show_bug.cgi?id=31200
2304         Tests in http/tests/security/mixedContent start to fail when new tests are added
2305
2306         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
2307
2308 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2309
2310         Reviewed by Jan Alonzo.
2311
2312         Create, and display a window for the inspector, for inspector
2313         tests.
2314
2315         Need to also show/hide the inspector window to avoid having
2316         problems with code assuming it is realized
2317         https://bugs.webkit.org/show_bug.cgi?id=31347
2318
2319         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2320         (webInspectorShowWindow):
2321         (webInspectorCloseWindow):
2322         (webInspectorInspectWebView):
2323         (createWebView):
2324
2325 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2326
2327         Unreviewed Qt buildbot fix.
2328
2329         My previous fix was wrong, so revert that change and fix it by
2330         returning when the document of the frame has no document element.
2331         Idea is borrowed from mac and win DRT.
2332
2333         * DumpRenderTree/qt/DumpRenderTree.cpp:
2334         (WebCore::DumpRenderTree::dumpFramesAsText):
2335
2336 2009-11-11  Eric Seidel  <eric@webkit.org>
2337
2338         Reviewed byg Kenneth Rohde Christiansen.
2339
2340         Update Kenneth's committer record to include the email he
2341         uses on lists.webkit.org.
2342
2343         * Scripts/modules/committers.py:
2344
2345 2009-11-11  Eric Seidel  <eric@webkit.org>
2346
2347         Reviewed by Gustavo Noronha Silva.
2348
2349         Several committers use separate email addresses for bugzilla and svn.webkit.org
2350         https://bugs.webkit.org/show_bug.cgi?id=31364
2351
2352         Update records for existing committers to include email addresses
2353         used in svn.webkit.org and lists.webkit.org.
2354         Most committers use the same email address in all 3 places, but some use
2355         separate addresses.  committers.py needs record of each of these addresses.
2356
2357         * Scripts/modules/committers.py:
2358
2359 2009-11-11  Eric Seidel  <eric@webkit.org>
2360
2361         No review, adding second email address for an existing committer.
2362
2363         Add Yong Li's second bugzilla account to his committer record.
2364         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
2365
2366         * Scripts/modules/committers.py:
2367
2368 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2369
2370         Reviewed by Simon Hausmann.
2371
2372         If the frame has no innerText don't append it, and
2373         do not add a newline which breaks some cross platform
2374         results.
2375
2376         * DumpRenderTree/qt/DumpRenderTree.cpp:
2377         (WebCore::DumpRenderTree::dumpFramesAsText):
2378
2379 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2380
2381         Reviewed by Simon Hausmann.
2382
2383         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2384
2385         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2386         (webkit_test_plugin_new_instance):
2387         (webkit_test_plugin_destroy_instance):
2388         (webkit_test_plugin_destroy_stream):
2389
2390 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2391
2392         Reviewed by Mark Rowe.
2393
2394         Implement the functionality needed by plugins/window-open.html
2395
2396         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2397         (webkit_test_plugin_new_instance):
2398         (webkit_test_plugin_set_window):
2399
2400 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2401
2402         Reviewed by Simon Hausmann.
2403
2404         [Qt] Force -graphicssystem raster and -style windows when running DRT
2405
2406         * DumpRenderTree/qt/main.cpp:
2407         * Scripts/run-webkit-tests:
2408
2409 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2410
2411         Reviewed by Simon Hausmann.
2412
2413         Compute correct library paths for Qt
2414
2415         * Scripts/webkitdirs.pm:
2416
2417 2009-11-10  Mark Rowe  <mrowe@apple.com>
2418
2419         Reviewed by Sam Weinig.
2420
2421         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2422
2423         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2424         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2425         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2426         that had enabled frame load delegate logging this would result in extra log messages being generated,
2427         causing the test to fail.
2428
2429         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2430         tests.
2431
2432         * DumpRenderTree/mac/DumpRenderTree.mm:
2433         (dumpRenderTree):
2434         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2435         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2436
2437 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2438
2439         Reviewed by Kenneth Rohde Christiansen.
2440
2441         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2442
2443         * DumpRenderTree/qt/DumpRenderTree.cpp:
2444         (WebCore::DumpRenderTree::DumpRenderTree):
2445
2446 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2447
2448         Reviewed by Jan Alonzo.
2449
2450         [GTK] Remove WebSocket configuration from WebKitWebSettings
2451         https://bugs.webkit.org/show_bug.cgi?id=31244
2452
2453         Follow-up of r50724. Don't set the enable-web-socket property
2454         anymore.
2455
2456         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2457         (resetDefaultsToConsistentValues):
2458
2459 2009-11-10  Oliver Hunt  <oliver@apple.com>
2460
2461         Reviewed by Maciej Stachowiak.
2462
2463         Rename 3D Canvas related classes to use WebGL prefix
2464         https://bugs.webkit.org/show_bug.cgi?id=29095
2465
2466         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2467         and upate webkitdirs script to new method of testing for WebGL.
2468
2469         * Scripts/do-webcore-rename:
2470         * Scripts/webkitdirs.pm:
2471
2472 2009-11-09  Oliver Hunt  <oliver@apple.com>
2473
2474         Reviewed by Geoff Garen.
2475
2476         Make do-webcore-rename work with git.
2477
2478         * Scripts/do-webcore-rename:
2479
2480 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2481
2482         Adding Kenneth to the reviewers list.
2483
2484         * Scripts/modules/committers.py:
2485
2486 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2487
2488         Reviewed by Jan Alonzo.
2489
2490         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2491         https://bugs.webkit.org/show_bug.cgi?id=30482
2492
2493         LayoutTestControllerGtk now uses the exposed
2494         Page::tabKeyCyclesThroughElements API
2495
2496         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2497         (LayoutTestController::setTabKeyCyclesThroughElements):
2498
2499 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2500
2501         Reviewed by Holger Freyther.
2502
2503         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2504         This helps to pass the test case below. Also replaced hardcoded
2505         code numbers with defined constants.
2506         https://bugs.webkit.org/show_bug.cgi?id=31185
2507         
2508         Test: editing/undo/undo-deleteWord.html
2509
2510         * DumpRenderTree/qt/EventSenderQt.cpp:
2511         (EventSender::keyDown):
2512
2513 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2514
2515         Reviewed by Holger Freyther.
2516
2517         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2518         https://bugs.webkit.org/show_bug.cgi?id=31164
2519
2520         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2521
2522         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2523         (LayoutTestController::processWork):
2524
2525 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2526
2527         Reviewed by Holger Freyther.
2528
2529         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2530         https://bugs.webkit.org/show_bug.cgi?id=31158
2531
2532         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2533         always, which from WorkQueue prospective means that a load has been started
2534         and the queue processing should stop and wait for the load to finish.
2535         Spinning it off into a loading and a non-loading variants was the solution
2536         adopted by Mac's DRT to work around this problem. The former keeps returning
2537         'true' while the later executes the script synchronously and returns 'false'
2538         making it possible to the WorkQueue to proceed right away.
2539
2540         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2541         (LayoutTestController::processWork):
2542         (LayoutTestController::queueLoadingScript):
2543         (LayoutTestController::queueNonLoadingScript):
2544         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2545         * DumpRenderTree/qt/WorkQueueItem.h:
2546         (LoadingScriptItem::LoadingScriptItem):
2547         (LoadingScriptItem::invoke):
2548         (NonLoadingScriptItem::NonLoadingScriptItem):
2549         (NonLoadingScriptItem::invoke):
2550
2551 2009-11-07  Mark Rowe  <mrowe@apple.com>
2552
2553         Rubber-stamped by Cameron Zwarich.
2554
2555         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2556
2557         * Scripts/commit-log-editor:
2558
2559 2009-11-07  Mark Rowe  <mrowe@apple.com>
2560
2561         Reviewed by Darin Adler.
2562
2563         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2564         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2565
2566         Move logic for determining the name and email address to use in a ChangeLog entry from
2567         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2568         whether the author of the patch matches committer, and therefore needs access to the
2569         email address that would be used in a ChangeLog entry.
2570
2571         Based on a patch by Pierre d'Herbemont.
2572
2573         * Scripts/VCSUtils.pm:
2574         * Scripts/commit-log-editor:
2575         * Scripts/prepare-ChangeLog:
2576         * Scripts/webkitdirs.pm:
2577
2578 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2579
2580         Reviewed by Adam Barth.
2581
2582         Added functionality to the layout test plugin to invoke document.open and
2583         window.open with default arguments. The associated webkit bug is
2584         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2585         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2586         work in Chromium (V8) if there is no calling javascript context. To achieve this
2587         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2588         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2589
2590         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2591         (testDocumentOpen):
2592         (testWindowOpen):
2593         (pluginAllocate):
2594         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2595         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2596         (NPP_New):
2597         (NPP_SetWindow):
2598         (NPP_DestroyStream):
2599         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2600         (NPP_New):
2601         (NPP_SetWindow):
2602         (NPP_NewStream):
2603         (NPP_DestroyStream):
2604
2605 2009-11-06  Eric Seidel  <eric@webkit.org>
2606
2607         Reviewed by Adam Barth.
2608
2609         bugzilla-tool crashed with exception
2610         https://bugs.webkit.org/show_bug.cgi?id=31092
2611
2612         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2613
2614 2009-11-04  Eric Seidel  <eric@webkit.org>
2615
2616         No review, just add a line which got left out of the patch uploaded for commit.
2617
2618         commit-queue is crashing when trying to reject patches after unknown failures
2619         https://bugs.webkit.org/show_bug.cgi?id=31091
2620
2621         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2622
2623 2009-11-04  Adam Roben  <aroben@apple.com>
2624
2625         Remove bogus else clause in bugzilla-tool
2626
2627         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2628         create-bug raises exception after entering bug description
2629
2630         Reviewed by David Kilzer.
2631
2632         * Scripts/bugzilla-tool:
2633         (CreateBug): else clauses are only hit if no exception is raised, so
2634         it makes no sense to try to re-raise the exception in an else clause.
2635         The exception will automatically be re-raised if it doesn't match any
2636         of the except clauses, so we don't have to do anything special here at
2637         all to get the desired behavior.
2638
2639 2009-11-04  Eric Seidel  <eric@webkit.org>
2640
2641         Reviewed by David Kilzer.
2642
2643         svn-apply's fixChangeLogPatch function seems broken
2644         https://bugs.webkit.org/show_bug.cgi?id=30683
2645
2646         Update fixChangeLogPatch to be able to handle patches which
2647         don't start at line 1.
2648         Add unit tests for svn-apply to scm_unittest.py.
2649
2650         * Scripts/VCSUtils.pm:
2651         * Scripts/modules/scm_unittest.py:
2652
2653 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2654
2655         Reviewed by Beth Dakin.
2656
2657         Need to implement ARIA role="combobox"
2658         https://bugs.webkit.org/show_bug.cgi?id=31096
2659
2660         * DumpRenderTree/AccessibilityUIElement.cpp:
2661         (showMenuCallback):
2662         (getIsExpandedCallback):
2663         (AccessibilityUIElement::getJSClass):
2664         * DumpRenderTree/AccessibilityUIElement.h:
2665         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2666         (AccessibilityUIElement::isExpanded):
2667         (AccessibilityUIElement::showMenu):
2668         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2669         (AccessibilityUIElement::isExpanded):
2670         (AccessibilityUIElement::showMenu):
2671         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2672         (AccessibilityUIElement::isSelected):
2673         (AccessibilityUIElement::isExpanded):
2674         (AccessibilityUIElement::showMenu):
2675
2676 2009-11-04  Eric Seidel  <eric@webkit.org>
2677
2678         Reviewed by Adam Barth.
2679
2680         commit-queue is crashing when trying to reject patches after unknown failures
2681         https://bugs.webkit.org/show_bug.cgi?id=31091
2682
2683         * Scripts/bugzilla-tool:
2684          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2685            so we have to find out what the current patch is by asking bugzilla again.
2686          - Discovered that this code was also leaking file descriptors, so fixed that.
2687
2688 2009-11-04  Adam Roben  <aroben@apple.com>
2689
2690         Make run-webkit-tests work for the Debug_Internal Windows
2691         configuration
2692
2693         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2694         suffix.
2695
2696         Fixes <http://webkit.org/b/31123>.
2697
2698         Reviewed by Sam Weinig.
2699
2700         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2701         Debug_Internal, either.
2702
2703 2009-11-04  Eric Seidel  <eric@webkit.org>
2704
2705         Reviewed by Adam Barth.
2706
2707         committers.py needs a way to store non-bugzilla email addresses
2708         https://bugs.webkit.org/show_bug.cgi?id=31037
2709
2710         Make Committer and Reviewer constructors take a single email or a list of emails.
2711         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2712         Expose reviewers(), used by validate-committer-lists on bug 30970.
2713
2714         * Scripts/modules/committers.py:
2715         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2716
2717 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2718
2719         Reviewed by David Levin.
2720
2721         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2722         https://bugs.webkit.org/show_bug.cgi?id=27491
2723
2724         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2725         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2726
2727         Functions to start or stop Web Socket servers are added.
2728
2729         * Scripts/run-webkit-tests:
2730
2731 2009-11-03  Eric Seidel  <eric@webkit.org>
2732
2733         No review, just changing wording of log message.
2734
2735         Change log string to say "failed" instead of "rejected"
2736         when a commit fails due to an out of date checkout.
2737         This makes grepping the commit-queue log for rejected patches easier.
2738
2739         * Scripts/bugzilla-tool:
2740
2741 2009-11-03  Eric Seidel  <eric@webkit.org>
2742
2743         No review, adding commonly known committers missing from the file.
2744
2745         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2746
2747 2009-11-03  Eric Seidel  <eric@webkit.org>
2748
2749         No review, just sort-order cleanup.
2750
2751         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2752
2753 2009-11-03  Stephen White  <senorblanco@chromium.org>
2754
2755         (Unreviewed).
2756
2757         Add myself to committers.py.
2758
2759         * Scripts/modules/committers.py:
2760
2761 2009-11-03  Robin Dunn  <robin@alldunn.com>
2762
2763         Reviewed by Kevin Ollviier.
2764
2765         Add packaging scripts for Debian-based Linux distros.
2766         
2767         https://bugs.webkit.org/show_bug.cgi?id=31075
2768
2769         * wx/packaging/build-debian-installer.py: Added.
2770         * wx/packaging/debian: Added.
2771
2772 2009-11-03  Dan Bernstein  <mitz@apple.com>
2773
2774         Reviewed by Anders Carlsson and Beth Dakin.
2775
2776         https://bugs.webkit.org/show_bug.cgi?id=31070
2777
2778         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2779         destroyed, it executes the value of the 'ondestroy' parameter as a
2780         script.
2781
2782         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2783         (pluginAllocate): Initialize onDestroy.
2784         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2785         onDestroy.
2786         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2787         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2788         specified.
2789         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2790
2791 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2792
2793         Reviewed by Xan Lopez.
2794
2795         https://bugs.webkit.org/show_bug.cgi?id=31035
2796         [GTK] some accessibility tests hitting assertion in debug builds
2797
2798         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2799
2800         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2801         (AccessibilityController::rootElement):
2802
2803 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2804
2805         Reviewed by Beth Dakin.
2806
2807         Support ARIA "tab" roles
2808         https://bugs.webkit.org/show_bug.cgi?id=30842
2809
2810         * DumpRenderTree/AccessibilityUIElement.cpp:
2811         * DumpRenderTree/AccessibilityUIElement.h:
2812         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2813         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2814         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2815
2816 2009-11-01  Eric Seidel  <eric@webkit.org>
2817
2818         Reviewed by David Levin.
2819
2820         buildbots should use --exit-after-N-failures
2821         https://bugs.webkit.org/show_bug.cgi?id=30809
2822
2823         Make the bots exit after 20 failures to prevent never-ending
2824         test runs where every test spends a minute crashing.
2825
2826         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2827
2828 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2829
2830         Reviewed by Eric Seidel.
2831
2832         Turn on warnings for QtWebKit for gcc
2833         https://bugs.webkit.org/show_bug.cgi?id=30958
2834
2835         * DumpRenderTree/qt/main.cpp: 
2836         (crashHandler): Mark function NO_RETURN
2837
2838 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2839
2840         Adding myself to the committers list.
2841
2842         * Scripts/modules/committers.py:
2843
2844 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2845
2846         Fix an issue that Adam noticed in DRT.
2847
2848         Reviewed by Darin Adler.
2849
2850         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2851         (AccessibilityUIElement::role):
2852         Get the length of the role text, and create a buffer dynamically.
2853
2854 2009-10-30  Eric Seidel  <eric@webkit.org>
2855
2856         No review, rolling out r50105.
2857         http://trac.webkit.org/changeset/50105
2858
2859         This commit was causing:
2860         https://bugs.webkit.org/show_bug.cgi?id=30869
2861         We'll re-implement the feature a different way.
2862
2863         * Scripts/bugzilla-tool:
2864
2865 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2866
2867         Test for MSAA: Accessibility of headings is not correct
2868
2869         https://bugs.webkit.org/show_bug.cgi?id=30937
2870
2871         Reviewed by Adam Roben.
2872
2873         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2874         (AccessibilityUIElement::role):
2875         Allow the role returned to be a BSTR.
2876         (AccessibilityUIElement::description):
2877         Fix a copy/paste error.
2878
2879 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2880
2881         Test for MSAA: Accessibility of links is wrong
2882
2883         https://bugs.webkit.org/show_bug.cgi?id=30928
2884
2885         Reviewed by Darin Adler.
2886
2887         * DumpRenderTree/AccessibilityUIElement.cpp:
2888         (getAccessibilityValueCallback):
2889         Return the accessibility value.
2890         (AccessibilityUIElement::getJSClass):
2891         Added "accessibilityValue" value.
2892
2893         * DumpRenderTree/AccessibilityUIElement.h:
2894
2895         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2896         (AccessibilityUIElement::accessibilityValue):
2897         Stubbed.
2898
2899         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2900         (AccessibilityUIElement::accessibilityValue):
2901         Stubbed.
2902
2903         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2904         (AccessibilityUIElement::accessibilityValue):
2905         Get the object's value, and return it as a JS string.
2906
2907 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2908
2909         Fix typo in command name used by wx build system.
2910
2911         * wx/build/build_utils.py:
2912
2913 2009-10-30  Adam Barth  <abarth@webkit.org>
2914
2915         Reviewed by Darin Adler.
2916
2917         Patch v1 is a dumb default name for patches
2918         https://bugs.webkit.org/show_bug.cgi?id=30952
2919
2920         Let's use "Patch" instead.
2921
2922         * Scripts/bugzilla-tool:
2923
2924 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2925
2926         Unreviewed trivial buildfix.
2927
2928         [Qt] Buildfix for r50333.
2929
2930         * DumpRenderTree/qt/DumpRenderTree.pro:
2931
2932 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2933
2934         Reviewed by Holger Freyther.
2935
2936         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2937         https://bugs.webkit.org/show_bug.cgi?id=30953
2938
2939         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2940         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2941         makes qt DRT to share this implementation (as gtk and mac ports do).
2942
2943         * DumpRenderTree/qt/DumpRenderTree.pro:
2944         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2945         * DumpRenderTree/qt/WorkQueue.h: Removed.
2946
2947 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2948
2949         Unreviewed potential buildbot fix.
2950
2951         Second try: Reset page history before running each test.
2952
2953         Apparently the QWebHistory::clear() keeps the current page
2954         in history which is not what we want, so we not additionally
2955         sets the history capacity to 0 (forces removing everything)
2956         and then sets it back to its original value.
2957
2958         * DumpRenderTree/qt/DumpRenderTree.cpp:
2959         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2960
2961 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2962
2963         Unreviewed potential buildbot fix.
2964
2965         Reset page history before running each test.
2966
2967         * DumpRenderTree/qt/DumpRenderTree.cpp:
2968         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2969
2970 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2971
2972         Reviewed by Eric Seidel.
2973
2974         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2975
2976         Bug 28420 -  Implement HTML5 <ruby> rendering
2977         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2978
2979         No new tests (no functional change).
2980
2981         * Scripts/build-webkit:
2982
2983 2009-10-29  Dan Bernstein  <mitz@apple.com>
2984
2985         Reviewed by Mark Rowe.
2986
2987         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2988         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2989         define it.
2990
2991         * Scripts/VCSUtils.pm:
2992         * Scripts/svn-apply:
2993         * Scripts/svn-unapply:
2994
2995 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2996
2997         Reviewed by Gustavo Noronha.
2998
2999         Use the GTK+ main loop instead of rolling our own mini-version of
3000         it.
3001
3002         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3003         (dump):
3004         (runTest):
3005         (webViewLoadFinished):
3006
3007 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3008
3009         Reviewed by Oliver Hunt.
3010
3011         Implement the Qt version of DRT dumpBackForwardList().
3012
3013         * DumpRenderTree/qt/DumpRenderTree.cpp:
3014         (WebCore::dumpHistoryItem):
3015         (WebCore::DumpRenderTree::dumpBackForwardList):
3016
3017 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3018
3019         Reviewed by Adam Roben.
3020
3021         Implement DRT functionality for Qt introduced in
3022         r28690 and r28705.
3023
3024         - Implemented pathToLocalResource which exposes the functionality of
3025         converting a given unix path to the correct location on Windows.
3026         - Implemented a way to remove machine-dependent information from paths
3027         in layout test results.
3028
3029         * DumpRenderTree/qt/DumpRenderTree.cpp:
3030         (WebCore::urlSuitableForTestResult):
3031         (WebCore::WebPage::javaScriptConsoleMessage):
3032         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3033         (LayoutTestController::pathToLocalResource):
3034         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3035
3036 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
3037
3038         Adding myself to the committers list.
3039
3040         * Scripts/modules/committers.py:
3041
3042 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
3043
3044         Adding myself to the committers list.
3045
3046         * Scripts/modules/committers.py:
3047
3048 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3049
3050         Reviewed by Jan Alonzo.
3051
3052         [GTK] API to start inspector for a WebView
3053         https://bugs.webkit.org/show_bug.cgi?id=22551
3054
3055         Use the new inspector API to implement the LayoutTestController
3056         interfaces used to test the inspector.
3057
3058         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3059         (webInspectorInspectWebView):
3060         (createWebView):
3061         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3062         (LayoutTestController::showWebInspector):
3063         (LayoutTestController::closeWebInspector):
3064         (LayoutTestController::evaluateInWebInspector):
3065
3066 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
3067
3068         Reviewed by Eric Seidel.
3069
3070         [Qt] WebFrame::counterValueForElementById must not be exposed
3071         https://bugs.webkit.org/show_bug.cgi?id=30882
3072
3073         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3074         (LayoutTestController::counterValueForElementById):
3075
3076 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3077
3078         Rubberstamped by Oliver Hunt.
3079
3080         Fix the warning:
3081
3082         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
3083         declared with attribute warn_unused_result".
3084
3085         by actually checking the result. In the case it is null, an
3086         error has occoured, so treat it as the other fatal errors.
3087
3088         * DumpRenderTree/qt/DumpRenderTree.cpp:
3089         (WebCore::DumpRenderTree::initializeFonts):
3090
3091 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
3092
3093         Reviewed by Darin Adler.
3094
3095         Provide a way to get counter values with layoutTestContoller
3096         https://bugs.webkit.org/show_bug.cgi?id=30555
3097
3098         Define layoutTestContoller.counterValueForElementById.
3099
3100         * DumpRenderTree/LayoutTestController.cpp:
3101         (counterValueForElementByIdCallback):
3102         (LayoutTestController::staticFunctions):
3103         * DumpRenderTree/LayoutTestController.h:
3104         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3105         (LayoutTestController::counterValueForElementById):
3106
3107 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3108
3109         Rubberstamped by Oliver Hunt.
3110
3111         Change two methods to be internal for DRT use only.
3112
3113         Part of [Qt] Review all new API in Qt 4.6
3114         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
3115
3116         * DumpRenderTree/qt/DumpRenderTree.cpp:
3117         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3118         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3119         (LayoutTestController::whiteListAccessFromOrigin):
3120
3121 2009-10-27  Eric Seidel  <eric@webkit.org>
3122
3123         Reviewed by Adam Barth.
3124
3125         REGRESSION: svn-apply exits(1) when applying a patch with a file add
3126         https://bugs.webkit.org/show_bug.cgi?id=30826
3127
3128         * Scripts/svn-apply:
3129          - Add () around all system() calls.
3130          - Use the correct system() == 0 or die instead of system() or die
3131          - Add descriptive messages to all die statements.
3132
3133 2009-10-27  Steve Block  <steveblock@google.com>
3134
3135         Reviewed by NOBODY.
3136
3137         Adds steveblock@google.com to list of committers.
3138
3139         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
3140
3141 2009-10-27  Eric Seidel  <eric@webkit.org>
3142
3143         Reviewed by Adam Barth.
3144
3145         svn-apply can exit(0) even on patch failure
3146         https://bugs.webkit.org/show_bug.cgi?id=29622
3147
3148         * Scripts/svn-apply:
3149          - Add a bunch of "or die" statements, hopefully catching all
3150            possible cases where failure could still exit(0).
3151
3152 2009-10-27  Eric Seidel  <eric@webkit.org>
3153
3154         Reviewed by Adam Barth.
3155
3156         svn-* scripts should share code through VCSUtils.pm
3157         https://bugs.webkit.org/show_bug.cgi?id=30791
3158
3159         Just moving code into a shared location.
3160
3161         * Scripts/VCSUtils.pm:
3162         * Scripts/prepare-ChangeLog:
3163         * Scripts/resolve-ChangeLogs:
3164         * Scripts/svn-apply:
3165         * Scripts/svn-create-patch:
3166         * Scripts/svn-unapply:
3167         * Scripts/update-webkit:
3168
3169 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
3170
3171         Suppress a huge number of MSVC warnings when building wxWebKit.
3172
3173         * wx/build/settings.py:
3174
3175 2009-10-26  Eric Seidel  <eric@webkit.org>
3176
3177         No review, just adding Mike Belshe to the committers list.
3178
3179         * Scripts/modules/committers.py:
3180
3181 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3182
3183         Reviewed by Darin Adler.
3184
3185         Make .rc files compile on Windows without depending on MFC headers
3186         https://bugs.webkit.org/show_bug.cgi?id=30750
3187
3188         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
3189         windows.h instead of afxres.h because it exists even when MFC is not 
3190         installed, and is all that's needed here.
3191
3192         * FindSafari/FindSafari.rc: Ditto
3193
3194 2009-10-24  Eric Seidel  <eric@webkit.org>
3195
3196         Reviewed by Adam Barth.
3197
3198         bugzilla-tool post-diff should know how to mark commit-queue=?
3199         https://bugs.webkit.org/show_bug.cgi?id=29202
3200
3201         * Scripts/bugzilla-tool:
3202          - Add --commit-queue option to post-diff, post-commits and create-bug.
3203         * Scripts/modules/bugzilla.py:
3204          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
3205          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
3206
3207 2009-10-23  Eric Seidel  <eric@webkit.org>
3208
3209         Reviewed by Adam Barth.
3210
3211         bugzilla-tool commit-queue does not notice modifications to committers.py
3212         https://bugs.webkit.org/show_bug.cgi?id=30084
3213
3214         * Scripts/bugzilla-tool:
3215          - Make commit-queue re-exec itself instead of using while(1).
3216          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
3217          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
3218
3219 2009-10-22  Eric Seidel  <eric@webkit.org>
3220
3221         Reviewed by Adam Barth.
3222
3223         commit-queue will get stuck on patches if land-patches terminates unexpectedly
3224         https://bugs.webkit.org/show_bug.cgi?id=30634
3225
3226         * Scripts/bugzilla-tool:
3227          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
3228          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
3229
3230 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
3231
3232         Reviewed by Eric Seidel.
3233
3234         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
3235
3236         https://bugs.webkit.org/show_bug.cgi?id=30763
3237
3238         * pywebsocket/mod_pywebsocket/__init__.py:
3239         * pywebsocket/mod_pywebsocket/dispatch.py:
3240         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
3241         * pywebsocket/mod_pywebsocket/standalone.py:
3242         * pywebsocket/setup.py:
3243         * pywebsocket/test/test_dispatch.py:
3244
3245 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
3246
3247         Reviewed by David Levin.
3248
3249         REGRESSION: 2 failures in run-webkit-unittests
3250         https://bugs.webkit.org/show_bug.cgi?id=30645
3251
3252         * Scripts/modules/cpp_style_unittest.py:
3253         Fixed a few test scenarios which apparently lost some spaces from 
3254         text literals.
3255
3256 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
3257
3258         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
3259
3260         * Scripts/webkitdirs.pm:
3261
3262 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
3263
3264         Reviewed by Darin Adler.
3265
3266         Unification of using null device in perl scripts.
3267         https://bugs.webkit.org/show_bug.cgi?id=30572
3268
3269         * Scripts/VCSUtils.pm:
3270         * Scripts/bisect-builds:
3271         * Scripts/resolve-ChangeLogs:
3272         * Scripts/run-iexploder-tests:
3273         * Scripts/run-jsc:
3274         * Scripts/run-mangleme-tests:
3275         * Scripts/run-webkit-tests:
3276         * Scripts/webkitdirs.pm:
3277         Using File::Spec->devnull() instead of hard coded /dev/null.
3278
3279 2009-10-26  Eric Seidel  <eric@webkit.org>
3280
3281         Reviewed by Holger Freyther.
3282
3283         Reviewers are missing from committers.py
3284         https://bugs.webkit.org/show_bug.cgi?id=30733
3285
3286         * Scripts/modules/committers.py:
3287
3288 2009-10-23  Eric Seidel  <eric@webkit.org>
3289
3290         No review, only adding Alice to the list of reviewers.
3291
3292         * Scripts/modules/committers.py:
3293
3294 2009-10-23  Eric Seidel  <eric@webkit.org>
3295
3296         Reviewed by Eric Carlson.
3297
3298         fast/media/mq-transform-02.html failed on Leopard Commit Bot
3299         https://bugs.webkit.org/show_bug.cgi?id=30700
3300
3301         * DumpRenderTree/mac/DumpRenderTree.mm:
3302         (resetDefaultsToConsistentValues): Update QuickTime version check.
3303
3304 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
3305
3306         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
3307         character measurement APIs that are private on Tiger.
3308
3309         * wx/build/settings.py:
3310
3311 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3312
3313         Reviewed by NOBODY (build fix).
3314         Build fix following bug #30696.
3315
3316         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3317         (LayoutTestController::evaluateScriptInIsolatedWorld):
3318
3319 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3320
3321         Reviewed by Sam Weinig & Geoff Garen.
3322
3323         https://bugs.webkit.org/show_bug.cgi?id=30696
3324         Enable isolated-worlds tests on mac.
3325
3326         Add private interface for DRT to invoke execution in a given world.
3327
3328         * DumpRenderTree/LayoutTestController.cpp:
3329         (evaluateScriptInIsolatedWorldCallback):
3330         (LayoutTestController::staticFunctions):
3331         * DumpRenderTree/LayoutTestController.h:
3332         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3333         (LayoutTestController::evaluateScriptInIsolatedWorld):
3334         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3335         (LayoutTestController::evaluateScriptInIsolatedWorld):
3336
3337 2009-10-21  Eric Seidel  <eric@webkit.org>
3338
3339         Reviewed by Adam Barth.
3340
3341         bugzilla-tool's "patch failed to download an apply" error should give more information
3342         https://bugs.webkit.org/show_bug.cgi?id=30632
3343
3344         * Scripts/modules/scm.py:
3345          - Use the common run_command method instead of custom POpen code.
3346          - Make run_command know how to take pipes as input.
3347         * Scripts/modules/scm_unittest.py:
3348          - Add new tests to cover change.
3349          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
3350
3351 2009-10-21  Kent Tamura  <tkent@chromium.org>
3352
3353         Unreviewed.  Adding myself to the committers list.
3354
3355         * Scripts/modules/committers.py:
3356
3357 2009-10-21  Robin Dunn  <robin@alldunn.com>
3358
3359         Reviewed by Kevin Ollivier.
3360
3361         Update the Windows installer builder to work with Vista / Win 7 and with git.
3362         
3363         https://bugs.webkit.org/show_bug.cgi?id=30649
3364
3365         * wx/build/build_utils.py:
3366         * wx/packaging/build-mac-installer.py:
3367         * wx/packaging/build-win-installer.py:
3368         * wx/packaging/wxWebKitInstaller.iss.in:
3369
3370 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3371
3372         Reviewed by Gustavo Noronha.
3373
3374         [GTK] Added conditional code to avoid using
3375         gdk_window_get_root_coords if we do not have a gtk+ release newer
3376         than 2.17.3.
3377         https://bugs.webkit.org/show_bug.cgi?id=30636
3378
3379         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3380
3381 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3382
3383         Reviewed by Eric Seidel.
3384
3385         [Qt] Added dummy implementation for keepWebHistory()
3386         https://bugs.webkit.org/show_bug.cgi?id=30592
3387
3388         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3389         (LayoutTestController::keepWebHistory):
3390         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3391
3392 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3393
3394         Reviewed by Xan Lopez.
3395
3396         [GTK] Fixed the double click condition, it is not double click if
3397         we move in just in one direction.
3398         https://bugs.webkit.org/show_bug.cgi?id=30636
3399
3400         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3401
3402 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3403
3404         Reviewed by Xan Lopez.
3405
3406         [GTK] Initialize the events completly before emitting them.
3407         https://bugs.webkit.org/show_bug.cgi?id=30633
3408
3409         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3410
3411 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3412
3413         wx build fix. Fix for when linking using --as-needed with gcc.
3414
3415         * wx/browser/wscript:
3416
3417 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3418
3419         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3420         to support all the features used by CURL backend.
3421         
3422         * wx/build/settings.py:
3423         * wx/install-unix-extras:
3424
3425 2009-10-20  Anton Muhin  <antonm@chromium.org>
3426
3427         Reviewed by Adam Barth.
3428
3429         Add {ager,antonm,yurys}@chromium.org into committers.py
3430         https://bugs.webkit.org/show_bug.cgi?id=30560
3431
3432         * Scripts/modules/committers.py:
3433
3434 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3435
3436         Reviewed by Tor Arne Vestbø.
3437
3438         Make the Netscape Test plugin available to the Qt launcher.
3439
3440         * Scripts/run-launcher:
3441
3442 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3443
3444         Reviewed by David Levin.
3445
3446         Removed WebSocket runtime settings.
3447         https://bugs.webkit.org/show_bug.cgi?id=29896
3448
3449         WebSocket runtime configuration is supported by chromium/v8 only.
3450
3451         * DumpRenderTree/mac/DumpRenderTree.mm:
3452         (resetDefaultsToConsistentValues):
3453         * DumpRenderTree/win/DumpRenderTree.cpp:
3454         (resetDefaultsToConsistentValues):
3455
3456 2009-10-19  Nate Chapin  <japhet@chromium.org>
3457
3458         Reviewed by Adam Barth.
3459
3460         Add testFail() to test plugin so we can test our handling of a
3461         plugin invoke call returning false.
3462
3463         https://bugs.webkit.org/show_bug.cgi?id=30239
3464
3465         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3466         (pluginInvoke):
3467         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3468
3469 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3470
3471         Reviewed by Gustavo Noronha.
3472
3473         Enable DOM pasting when running layout tests.
3474
3475         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3476         (resetDefaultsToConsistentValues):
3477
3478 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3479
3480         Reviewed by Simon Hausmann.
3481
3482         Use the setPreferredContentsSize method instead
3483         of setFixedContentsSize, as the method has been renamed.
3484
3485         * DumpRenderTree/qt/DumpRenderTree.cpp:
3486         (WebCore::DumpRenderTree::open):
3487         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3488         (LayoutTestController::setFixedContentsSize):
3489
3490 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3491
3492         Reviewed by Dan Bernstein.
3493
3494         https://bugs.webkit.org/show_bug.cgi?id=30456
3495         Fixes for new Debug_All Windows build configuration.
3496
3497         * DumpRenderTree/win/DumpRenderTree.cpp:
3498         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3499         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3500
3501 2009-10-16  Eric Seidel  <eric@webkit.org>
3502
3503         Reviewed by Adam Barth.
3504
3505         commit-queue status bot should list which buildbot is blocking the queue
3506         https://bugs.webkit.org/show_bug.cgi?id=30452
3507
3508         Add new methods and testing.
3509
3510         * Scripts/bugzilla-tool:
3511         * Scripts/modules/buildbot.py:
3512         * Scripts/modules/buildbot_unittest.py:
3513
3514 2009-10-16  Eric Seidel  <eric@webkit.org>
3515
3516         Reviewed by Adam Barth.
3517
3518         run-webkit-tests fails when CWD is not inside a WebKit checkout
3519         https://bugs.webkit.org/show_bug.cgi?id=30451
3520
3521         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3522         * Scripts/modules/scm_unittest.py:
3523           - Remove use of original_path (we don't need to restore the CWD).
3524           - Don't use '.' to find the webkit checkout, use __file__ instead.
3525
3526 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3527
3528         Reviewed by Adam Roben.
3529
3530         Add a Debug_All configuration to build entire stack as debug.
3531         Change Debug_Internal to:
3532         - stop using _debug suffix for all WebKit/Safari binaries
3533         - not use _debug as a DLL naming suffix
3534         - use non-debug C runtime lib.
3535
3536         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3537         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3538         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3539         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3540         Add missing debug.vsprops inherited property sheet.
3541         Add Debug_All configuration.
3542         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3543         * WinLauncher/WinLauncher.vcproj:
3544         Removed extraneous definitions inherited from vsprops.
3545         Add Debug_All configuration.
3546
3547 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3548
3549         Reviewed by David Levin.
3550
3551         check-webkit-style is wrong about indent checking in namespaces
3552         in header files and a few other things
3553         https://bugs.webkit.org/show_bug.cgi?id=30362
3554
3555         The few other things include:
3556         + check-webkit-style does not require spaces around the equal sign
3557           inside 'if' statements and around binary operators that take 
3558           numeric literals.
3559         + check-webkit-style reports false errors for the / operator
3560           when part of a filename in the #include directive.
3561
3562         * Scripts/modules/cpp_style.py:
3563         Improved indentation checking and space checking around
3564         binary operators. While the checks are still not perfect,
3565         they are clearly better than before.
3566         * Scripts/modules/cpp_style_unittest.py:
3567         Added test cases for the newly supported checks and modified old
3568         test cases to match the new guidelines
3569
3570 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3571
3572         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3573
3574         * wx/build/settings.py:
3575
3576 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3577
3578         Reviewed by David Levin.
3579
3580         Add mod_pywebsocket to test Web Sockets.
3581         http://code.google.com/p/pywebsocket/
3582         https://bugs.webkit.org/show_bug.cgi?id=27490
3583
3584         * pywebsocket/COPYING: Added.
3585         * pywebsocket/MANIFEST.in: Added.
3586         * pywebsocket/README: Added.
3587         * pywebsocket/example/echo_client.py: Added.
3588         * pywebsocket/example/echo_wsh.py: Added.
3589         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3590         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3591         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3592         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3593         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3594         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3595         * pywebsocket/mod_pywebsocket/util.py: Added.
3596         * pywebsocket/setup.py: Added.
3597         * pywebsocket/test/config.py: Added.
3598         * pywebsocket/test/mock.py: Added.
3599         * pywebsocket/test/run_all.py: Added.
3600         * pywebsocket/test/test_dispatch.py: Added.
3601         * pywebsocket/test/test_handshake.py: Added.
3602         * pywebsocket/test/test_mock.py: Added.
3603         * pywebsocket/test/test_msgutil.py: Added.
3604         * pywebsocket/test/test_util.py: Added.
3605         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3606         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3607         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3608         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3609         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3610         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3611         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3612         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3613
3614 2009-10-15  James Robinson  <jamesr@google.com>
3615
3616         Reviewed by David Levin.
3617
3618         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3619
3620         https://bugs.webkit.org/show_bug.cgi?id=30426
3621
3622         * Scripts/modules/cpp_style.py:
3623         * Scripts/modules/cpp_style_unittest.py:
3624
3625 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3626
3627         Reviewed by Adam Roben.
3628
3629         Fixes <http://webkit.org/b/30411>.
3630         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3631         
3632         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3633         building Chromium.
3634
3635         * Scripts/pdevenv:
3636
3637 2009-10-15  Robin Dunn  <robin@alldunn.com>
3638
3639         Reviewed by Kevin Ollivier.
3640
3641         Add Mac package building scripts for wx.
3642         
3643         https://bugs.webkit.org/show_bug.cgi?id=30405
3644
3645         * wx/build/build_utils.py:
3646         * wx/build/settings.py:
3647         * wx/packaging/build-mac-installer.py: Added.
3648
3649 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3650
3651         Reviewed by Gustavo Noronha.
3652
3653         Enable Web Sockets support when running layout tests.
3654
3655         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3656         (resetDefaultsToConsistentValues):
3657
3658 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3659
3660         Reviewed by Gustavo Noronha.
3661
3662         Need to initialize event.button.button, since in most cases a
3663         button number is not passed as an argument.
3664
3665         * DumpRenderTree/gtk/EventSender.cpp:
3666         (mouseDownCallback):
3667         (mouseUpCallback):
3668
3669 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3670
3671         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3672         the OS if none was explicitly set.
3673
3674         * wx/build/settings.py:
3675
3676 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3677
3678         Reviewed by Timothy Hatcher.
3679
3680         Web Inspector: enable developers extras within inspector layout tests.
3681
3682         https://bugs.webkit.org/show_bug.cgi?id=30014
3683
3684         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3685         (LayoutTestController::showWebInspector):
3686         (LayoutTestController::closeWebInspector):
3687         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3688         (LayoutTestController::showWebInspector):
3689         (LayoutTestController::closeWebInspector):
3690
3691 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3692
3693         Reviewed by Jan Alonzo.
3694
3695         GtkLauncher is using a deprecated signal
3696         https://bugs.webkit.org/show_bug.cgi?id=30364
3697
3698         Modified GtkLauncher to use notify::title signal instead of
3699         deprecated title-changed signal
3700
3701         * GtkLauncher/main.c:
3702         (notify_title_cb):
3703         (create_browser):
3704
3705 2009-10-14  Brady Eidson  <beidson@apple.com>
3706
3707         Reviewed by Sam Weinig.
3708
3709         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3710         1 - Disables WebHistory
3711         2 - Doesn't make sense in that context anyway.
3712
3713         * DumpRenderTree/win/DumpRenderTree.cpp:
3714         (createWebViewAndOffscreenWindow):
3715
3716 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3717
3718         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3719         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3720
3721         * wx/build/settings.py:
3722         * wx/install-unix-extras:
3723
3724 2009-10-14  Brady Eidson  <beidson@apple.com>
3725
3726         Reviewed by Sam Weinig.
3727
3728         WebKit Win API should provide a delegate interface for global history.
3729         https://bugs.webkit.org/show_bug.cgi?id=29905
3730
3731         * DumpRenderTree/LayoutTestController.cpp:
3732         (LayoutTestController::LayoutTestController):
3733         * DumpRenderTree/LayoutTestController.h:
3734         (LayoutTestController::dumpHistoryDelegateCallbacks):
3735         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3736                 
3737         * DumpRenderTree/win/DumpRenderTree.cpp:
3738         (shouldLogHistoryDelegates):
3739         (runTest):
3740         (createWebViewAndOffscreenWindow):
3741         (main):
3742         * DumpRenderTree/win/DumpRenderTree.vcproj:
3743         
3744         Add the IWebHistoryDelegate to DRT Windows:
3745         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3746         (wstringFromBSTR):
3747         (HistoryDelegate::HistoryDelegate):
3748         (HistoryDelegate::~HistoryDelegate):
3749         (HistoryDelegate::QueryInterface):
3750         (HistoryDelegate::AddRef):
3751         (HistoryDelegate::Release):
3752         (HistoryDelegate::didNavigateWithNavigationData):
3753         (HistoryDelegate::didPerformClientRedirectFromURL):
3754         (HistoryDelegate::didPerformServerRedirectFromURL):
3755         (HistoryDelegate::updateHistoryTitle):
3756         (HistoryDelegate::populateVisitedLinksForWebView):
3757         * DumpRenderTree/win/HistoryDelegate.h: Added.
3758
3759         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3760         (LayoutTestController::removeAllVisitedLinks):
3761
3762 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3763
3764         Reviewed by Simon Hausmann.
3765
3766         [Qt] Implement support for setPOSIXLocale on Qt.
3767         https://bugs.webkit.org/show_bug.cgi?id=30268 
3768  
3769         * DumpRenderTree/qt/DumpRenderTree.cpp:
3770         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3771         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3772         (LayoutTestController::setPOSIXLocale):
3773         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3774
3775 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3776
3777         Unreviewed, adding myself to reviewers list.
3778
3779         * Scripts/modules/committers.py:
3780
3781 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3782
3783         Reviewed by Mark Rowe.
3784
3785         Fix null assignment so root tests work again.
3786
3787         * Scripts/webkitdirs.pm:
3788
3789 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3790
3791         Reviewed by Simon Hausmann.
3792
3793         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3794         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3795         This is done in preparation of implementing missing features in DRT.
3796         No functionality changes made yet.
3797
3798         * DumpRenderTree/qt/DumpRenderTree.cpp:
3799         * DumpRenderTree/qt/DumpRenderTree.pro:
3800         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3801         (EventSender::EventSender):
3802         (EventSender::mouseDown):
3803         (EventSender::mouseUp):
3804         (EventSender::mouseMoveTo):
3805         (EventSender::leapForward):
3806         (EventSender::keyDown):
3807         (EventSender::contextClick):
3808         (EventSender::scheduleAsynchronousClick):
3809         (EventSender::frameUnderMouse):
3810         * DumpRenderTree/qt/EventSenderQt.h: Added.
3811         (EventSender::clearKillRing):
3812         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3813         (LayoutTestController::LayoutTestController):
3814         (LayoutTestController::reset):
3815         (LayoutTestController::processWork):
3816         (LayoutTestController::maybeDump):
3817         (LayoutTestController::waitUntilDone):
3818         (LayoutTestController::notifyDone):
3819         (LayoutTestController::windowCount):
3820         (LayoutTestController::clearBackForwardList):
3821         (LayoutTestController::dumpEditingCallbacks):
3822         (LayoutTestController::dumpResourceLoadCallbacks):
3823         (LayoutTestController::queueBackNavigation):
3824         (LayoutTestController::queueForwardNavigation):
3825         (LayoutTestController::queueLoad):
3826         (LayoutTestController::queueReload):
3827         (LayoutTestController::queueScript):
3828         (LayoutTestController::provisionalLoad):
3829         (LayoutTestController::timerEvent):
3830         (LayoutTestController::encodeHostName):
3831         (LayoutTestController::decodeHostName):
3832         (LayoutTestController::setJavaScriptProfilingEnabled):
3833         (LayoutTestController::setFixedContentsSize):
3834         (LayoutTestController::setPrivateBrowsingEnabled):
3835         (LayoutTestController::setPopupBlockingEnabled):
3836         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3837         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3838         (LayoutTestController::numberOfActiveAnimations):
3839         (LayoutTestController::disableImageLoading):
3840         (LayoutTestController::dispatchPendingLoadRequests):
3841         (LayoutTestController::setDatabaseQuota):
3842         (LayoutTestController::clearAllDatabases):
3843         (LayoutTestController::whiteListAccessFromOrigin):
3844         (LayoutTestController::waitForPolicyDelegate):
3845         (LayoutTestController::overridePreference):
3846         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3847         (LayoutTestController::isLoading):
3848         (LayoutTestController::setLoading):
3849         (LayoutTestController::shouldDumpAsText):
3850         (LayoutTestController::shouldDumpBackForwardList):
3851         (LayoutTestController::shouldDumpChildrenAsText):
3852         (LayoutTestController::shouldDumpDatabaseCallbacks):
3853         (LayoutTestController::shouldDumpStatusCallbacks):
3854         (LayoutTestController::shouldWaitUntilDone):
3855         (LayoutTestController::canOpenWindows):
3856         (LayoutTestController::shouldDumpTitleChanges):
3857         (LayoutTestController::waitForPolicy):
3858         (LayoutTestController::dumpAsText):
3859         (LayoutTestController::dumpChildFramesAsText):
3860         (LayoutTestController::dumpDatabaseCallbacks):
3861         (LayoutTestController::dumpStatusCallbacks):
3862         (LayoutTestController::setCanOpenWindows):
3863         (LayoutTestController::dumpBackForwardList):
3864         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3865         (LayoutTestController::display):
3866         (LayoutTestController::dumpTitleChanges):
3867         (LayoutTestController::dumpSelectionRect):
3868         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3869         (TextInputController::TextInputController):
3870         (TextInputController::doCommand):
3871         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3872         * DumpRenderTree/qt/WorkQueue.cpp:
3873         * DumpRenderTree/qt/WorkQueue.h:
3874         * DumpRenderTree/qt/WorkQueueItem.h:
3875         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3876         (findFrameNamed):
3877         (LoadItem::invoke):
3878         (ReloadItem::invoke):
3879         (ScriptItem::invoke):
3880         (BackForwardItem::invoke):
3881         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3882         * DumpRenderTree/qt/jsobjects.h:
3883
3884 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3885
3886         Not reviewed, adding myself to the list of reviewers.
3887
3888         * Scripts/modules/committers.py:
3889
3890 2009-10-13  Anders Carlsson  <andersca@apple.com>
3891
3892         Reviewed by Sam Weinig.
3893
3894         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3895
3896         Make the private browsing mode testable by the test plug-in.
3897         
3898         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3899         (pluginGetProperty):
3900         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3901         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3902         (NPP_New):
3903         (NPP_SetValue):
3904
3905 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3906
3907         No review, just adding self to the list of reviewers.
3908
3909         * Scripts/modules/committers.py:
3910
3911 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3912
3913         Reviewed by Adam Roben.
3914
3915         Web Inspector: Use proper web view in inspector layout
3916         tests for windows.
3917
3918         https://bugs.webkit.org/show_bug.cgi?id=30298
3919
3920         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3921         (LayoutTestController::showWebInspector):
3922         (LayoutTestController::closeWebInspector):
3923         (LayoutTestController::evaluateInWebInspector):
3924
3925 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3926
3927         Reviewed by Sam Weinig.
3928
3929         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3930         https://bugs.webkit.org/show_bug.cgi?id=29841
3931
3932         * DumpRenderTree/mac/DumpRenderTree.mm:
3933         (resetDefaultsToConsistentValues):
3934         * DumpRenderTree/win/DumpRenderTree.cpp:
3935         (resetDefaultsToConsistentValues):
3936
3937 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3938
3939         Reviewed by Dimitri Glazkov.
3940
3941         Chromium Port - Windows
3942         https://bugs.webkit.org/show_bug.cgi?id=29969
3943
3944         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3945         * Scripts/webkitdirs.pm:
3946
3947 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3948
3949         Reviewed by Darin Adler.
3950
3951         jsc scripts cleanup and Qt/GTK fix
3952         https://bugs.webkit.org/show_bug.cgi?id=30288
3953
3954         Duplicated jscPath() moved to webkitdirs.pm.
3955         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3956         Configuration added (release/debug) to path for Qt-port on Windows.
3957
3958         * Scripts/run-javascriptcore-tests:
3959         * Scripts/run-jsc:
3960         * Scripts/run-sunspider:
3961         * Scripts/sunspider-compare-results:
3962         * Scripts/webkitdirs.pm:
3963
3964 2009-10-11  Adam Barth  <abarth@webkit.org>
3965
3966         Unreviewed.  Add Collin to committers.py.
3967
3968         * Scripts/modules/committers.py:
3969
3970 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3971
3972         wx build fix, add bindings to source/include dirs now that there are sources there.
3973
3974         * wx/build/settings.py:
3975
3976 2009-10-09  Mark Rowe  <mrowe@apple.com>
3977
3978         Reviewed by Brady Eidson.
3979
3980         Enable plug-in halting in DumpRenderTree.
3981
3982         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3983         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3984
3985         * DumpRenderTree/mac/DumpRenderTree.mm:
3986         (resetDefaultsToConsistentValues):
3987         * DumpRenderTree/mac/UIDelegate.mm:
3988         (-[UIDelegate webView:shouldHaltPlugin:]):
3989
3990 2009-10-08  Brady Eidson  <beidson@apple.com>
3991
3992         Reviewed by Dan Bernstein.
3993
3994         Ask the History Delegate to populate the visited links hash.
3995         <rdar://problem/7285293> and https://webkit.org/b/29904
3996
3997         Add the ability for LayoutTestController to clear all visited links.
3998         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3999
4000         * DumpRenderTree/LayoutTestController.cpp:
4001         (LayoutTestController::LayoutTestController):
4002         (removeAllVisitedLinksCallback):
4003         (LayoutTestController::staticFunctions):
4004         * DumpRenderTree/LayoutTestController.h:
4005         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4006         (LayoutTestController::removeAllVisitedLinks):
4007
4008         * DumpRenderTree/mac/HistoryDelegate.mm:
4009         (-[HistoryDelegate populateVisitedLinksForWebView:]):
4010
4011         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4012         (LayoutTestController::removeAllVisitedLinks):
4013         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4014         (LayoutTestController::removeAllVisitedLinks):
4015         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4016         (LayoutTestController::removeAllVisitedLinks):
4017
4018
4019 2009-10-08  Daniel Bates  <dbates@webkit.org>
4020
4021         Reviewed by Adam Roben.
4022
4023         https://bugs.webkit.org/show_bug.cgi?id=30175
4024         
4025         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
4026         the OLE drag-and-drop return value like the function it emulates. Currently, 
4027         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
4028         whether the drag-and-drop operation was successful or was cancelled.
4029         
4030         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
4031         return value according to whether the drop operation was successful or not.
4032
4033         * DumpRenderTree/win/EventSender.cpp:
4034         (doMouseUp): Added parameter oleDragAndDropReturnValue.
4035         (replaySavedEvents): Ditto.
4036         * DumpRenderTree/win/EventSender.h:
4037         * DumpRenderTree/win/UIDelegate.cpp:
4038         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
4039
4040 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
4041
4042         Reviewed by Xan Lopez.
4043
4044         [GTK] Added support for a parameter setting the button that was
4045         pressed in the mouseDown function.
4046         https://bugs.webkit.org/show_bug.cgi?id=30220
4047
4048         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
4049
4050 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
4051
4052         Reviewed by Xan Lopez.
4053
4054         [GTK] Added a line to the bottom of the expected result to match
4055         the output of the test.
4056         https://bugs.webkit.org/show_bug.cgi?id=30220
4057
4058         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
4059         expected.txt:
4060
4061 2009-10-08  Adam Roben  <aroben@apple.com>
4062
4063         Use QueryInterface to get IWebInspectorPrivate
4064
4065         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
4066         accessed in a more standard way
4067
4068         Reviewed by John Sullivan and Tim Hatcher.
4069
4070         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4071         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
4072         by calling IWebViewPrivate::inspector, then use QueryInterface to get
4073         to the IWebInspectorPrivate interface.
4074
4075 2009-10-07  Adam Roben  <aroben@apple.com>
4076
4077         Implement DRT support for origin whitelisting
4078
4079         Fixes <http://webkit.org/b/30185>.
4080
4081         Reviewed by Eric Seidel.
4082
4083         * DumpRenderTree/win/DumpRenderTree.cpp:
4084         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
4085         whitelist, to match Mac DRT.
4086         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4087         (LayoutTestController::whiteListAccessFromOrigin): Call through to
4088         IWebViewPrivate::whiteListAccessFromOrigin.
4089
4090 2009-10-07  Brady Eidson  <beidson@apple.com>
4091
4092         Reviewed by Darin Adler.
4093
4094         Send title changes to the global history delegate.
4095         <rdar://problem/7285293> and https://webkit.org/b/29904
4096
4097         * DumpRenderTree/mac/HistoryDelegate.mm:
4098         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
4099
4100 2009-10-07  Adam Barth  <abarth@webkit.org>
4101
4102         Unreviewed.  Remove some folks from committers.py who were listed on
4103         the WebKit Team wiki page but who weren't actually listed as commit+.
4104         At some point, we should coorelate this list with the committers
4105         mailing list.
4106
4107         * Scripts/modules/committers.py:
4108
4109 2009-10-07  Adam Barth  <abarth@webkit.org>
4110
4111         Unreviewed.  Import a bunch of committers from the WebKit Team page on
4112         the wiki into committers.py.
4113
4114         * Scripts/modules/committers.py:
4115
4116 2009-10-07  Adam Barth  <abarth@webkit.org>
4117
4118         Unreviewed.  Added Aaron Boodman to committers.py.
4119
4120         * Scripts/modules/committers.py:
4121
4122 2009-10-07  Evan Martin  <evan@chromium.org>
4123
4124         Reviewed by Darin Adler.
4125
4126         Add API to LayoutTestController for re/setting the system locale.
4127         https://bugs.webkit.org/show_bug.cgi?id=18994
4128
4129         * DumpRenderTree/LayoutTestController.cpp:
4130         (setLocaleCallback):
4131         (LayoutTestController::staticFunctions):
4132         (LayoutTestController::setLocale):
4133         * DumpRenderTree/LayoutTestController.h:
4134
4135 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
4136
4137         Reviewed by Jan Alonzo.
4138
4139         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
4140         https://bugs.webkit.org/show_bug.cgi?id=29689
4141
4142         Build fix by adding -lfontconfig for DumpRenderTree.
4143
4144         * GNUmakefile.am:
4145
4146 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
4147
4148         Reviewed by Simon Hausmann.
4149
4150         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
4151
4152         * Scripts/run-webkit-tests:
4153
4154 2009-10-07  Xan Lopez  <xlopez@igalia.com>
4155
4156         Reviewed by Gustavo Noronha.
4157
4158         "delete" in EventSender is the backspace key, not the delete one.
4159
4160         * DumpRenderTree/gtk/EventSender.cpp:
4161         (keyDownCallback):
4162
4163 2009-10-07  Xan Lopez  <xlopez@igalia.com>
4164
4165         Reviewed by Gustavo Noronha.
4166
4167         getChildrenWithRange expects as last parameter the end index, not
4168         the length of the range. Correct this and clarify the variable
4169         names to reflect how the code works.
4170
4171         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4172         (AccessibilityUIElement::getChildrenWithRange):
4173         (AccessibilityUIElement::getChildAtIndex):
4174
4175 2009-10-06  Mark Rowe  <mrowe@apple.com>
4176
4177         Reviewed by Simon Fraser.
4178
4179         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
4180
4181         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
4182         the fact we have already changed the working directory to the top of the open source tree.
4183
4184 2009-10-06  Julie Parent  <jparent@chromium.org>
4185
4186         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
4187         rather than my committer email.
4188
4189         * Scripts/modules/committers.py:
4190
4191 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4192
4193         Reviewed by Eric Seidel.
4194
4195         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
4196
4197         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
4198         it after each layout test as it should do, making the DRT dump additional output
4199         for all of the subsequent layout tests.
4200
4201         * DumpRenderTree/qt/jsobjects.cpp:
4202         (LayoutTestController::reset):
4203
4204 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4205
4206         Reviewed by Simon Hausmann.
4207
4208         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
4209         fast/dom/assign-to-window-status.html test, which is passing as a result.
4210
4211         https://bugs.webkit.org/show_bug.cgi?id=30127
4212
4213         * DumpRenderTree/qt/DumpRenderTree.cpp:
4214         (WebCore::DumpRenderTree::DumpRenderTree):
4215         (WebCore::DumpRenderTree::statusBarMessage):
4216         * DumpRenderTree/qt/DumpRenderTree.h:
4217         * DumpRenderTree/qt/jsobjects.h:
4218         (LayoutTestController::shouldDumpStatusCallbacks):
4219         (LayoutTestController::dumpStatusCallbacks):
4220
4221 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4222
4223         Reviewed by Simon Hausmann.
4224
4225         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
4226         ignores the argument indicating which mouse button to trigger.
4227         https://bugs.webkit.org/show_bug.cgi?id=30048
4228
4229         This affects the fast/events/mouse-click-events.html layout test.
4230
4231         * DumpRenderTree/qt/jsobjects.cpp:
4232         (EventSender::mouseDown):
4233         (EventSender::mouseUp):
4234         * DumpRenderTree/qt/jsobjects.h:
4235
4236 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4237
4238         Reviewed by Simon Hausmann.
4239
4240         [Qt] Fix the EventSender::keyDown() implementation
4241         https://bugs.webkit.org/show_bug.cgi?id=30043
4242
4243         It should post both a key press event and a key release event,
4244         just like other ports do.
4245
4246         * DumpRenderTree/qt/jsobjects.cpp:
4247         (EventSender::keyDown):
4248
4249 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
4250
4251         wx build fix. Add jpeg to the list of libs to link against.
4252
4253         * wx/build/settings.py:
4254
4255 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
4256
4257         Reviewed by Simon Hausmann.
4258
4259         [Qt] EventSender::keyDown() cannot send function-key events.
4260         https://bugs.webkit.org/show_bug.cgi?id=30044
4261
4262         This affects the fast/events/keydown-function-keys.html layout test.
4263
4264         * DumpRenderTree/qt/jsobjects.cpp:
4265         (EventSender::keyDown):
4266
4267 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
4268
4269         Added --wx-compiler-prefix waf option to allow building wxWebKit with
4270         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
4271
4272         * wx/build/settings.py:
4273         * wx/build/wxpresets.py:
4274
4275 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
4276
4277         Reviewed by Timothy Hatcher.
4278
4279         Web Inspector: add testing harness for Web Inspector.
4280
4281         https://bugs.webkit.org/show_bug.cgi?id=30010
4282
4283         * DumpRenderTree/LayoutTestController.cpp:
4284         (showWebInspectorCallback):
4285         (closeWebInspectorCallback):
4286         (evaluateInWebInspectorCallback):
4287         (LayoutTestController::staticFunctions):
4288         * DumpRenderTree/LayoutTestController.h:
4289         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4290         (LayoutTestController::showWebInspector):
4291         (LayoutTestController::closeWebInspector):
4292         (LayoutTestController::evaluateInWebInspector):
4293         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4294         (LayoutTestController::showWebInspector):
4295         (LayoutTestController::closeWebInspector):
4296         (LayoutTestController::evaluateInWebInspector):
4297         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4298         (LayoutTestController::showWebInspector):
4299         (LayoutTestController::closeWebInspector):
4300         (LayoutTestController::evaluateInWebInspector):
4301         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4302         (LayoutTestController::showWebInspector):
4303         (LayoutTestController::closeWebInspector):
4304         (LayoutTestController::evaluateInWebInspector):
4305
4306 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4307
4308         Reviewed by Ariyha Hidayat.
4309
4310         Pass arguments to system() as a string instead of array
4311
4312         When passed as an array entries with a space fail to translate
4313         to two arguments to the child process, so instead of manually
4314         splitting all the entries in @buildArgs we pass the whole thing
4315         as a string instead.
4316
4317         * Scripts/webkitdirs.pm:
4318
4319 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
4320
4321         Reviewed by David Levin.
4322
4323         check-webkit-style misses whitespace errors for operators:
4324         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
4325         https://bugs.webkit.org/show_bug.cgi?id=30021
4326
4327         * Scripts/modules/cpp_style.py:
4328         Added the operators mentioned above to the same list as == and !=.
4329
4330 2009-10-02  Julie Parent  <jparent@chromium.org>
4331
4332         Unreviewed.
4333
4334         Adding myself and Ojan Vafai as committers, because we are committers.
4335
4336         * Scripts/modules/committers.py:
4337
4338 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
4339
4340         Reviewed by Adam Roben.
4341
4342         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
4343         this will help the patch merging process when TryBots are used.
4344
4345         * Scripts/svn-create-patch:
4346
4347 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
4348
4349         Reviewed by Simon Hausmann.
4350
4351         [Qt] Implement layoutTestController.overridePreference().
4352         https://bugs.webkit.org/show_bug.cgi?id=29970
4353
4354         * DumpRenderTree/qt/DumpRenderTree.cpp:
4355         (WebCore::WebPage::WebPage):
4356         (WebCore::WebPage::resetSettings):
4357         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4358         * DumpRenderTree/qt/jsobjects.cpp:
4359         (LayoutTestController::reset):
4360         (LayoutTestController::setPrivateBrowsingEnabled):
4361         (LayoutTestController::setPopupBlockingEnabled):
4362         (LayoutTestController::overridePreference):
4363         * DumpRenderTree/qt/jsobjects.h:
4364
4365 2009-10-01  Chris Marrin  <cmarrin@apple.com>
4366