8ae92beeff6b281f8fcbcc6e1a26f5591664af56
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-22  Chris Evans  <cevans@chromium.org>
2
3         Reviewed by Adam Barth.
4
5         Implemented setAllowUniversalAccessFromFileURLs to support testing of
6         file URL security.
7
8         * DumpRenderTree/LayoutTestController.cpp:
9         (setAllowUniversalAccessFromFileURLsCallback):
10         (LayoutTestController::staticFunctions):
11         * DumpRenderTree/LayoutTestController.h:
12         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
13         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
14         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
15         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
16         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
17         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
18         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
19         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
20
21 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
22
23         Reviewed by Kenneth Rohde Christiansen.
24
25         [Qt] Fix the timeout of fast/frames/frame-navigation.html
26         https://bugs.webkit.org/show_bug.cgi?id=31638
27
28         The test is timeouting, because it uses the WorkQueue to load a document in one
29         of the child frames and once the loading is finished, the DRT does not dump the
30         tree. This is because it waits for the QWebFrame::loadFinished() signal from
31         the main frame, while it should connect to QWebPage::loadFinished().
32
33         * DumpRenderTree/qt/DumpRenderTree.cpp:
34         (WebCore::DumpRenderTree::DumpRenderTree):
35
36 2009-11-21  Eric Seidel  <eric@webkit.org>
37
38         Reviewed by Adam Barth.
39
40         bugzilla-tool --help spews way too much text
41         https://bugs.webkit.org/show_bug.cgi?id=31771
42
43         * Scripts/bugzilla-tool:
44          - Remove self.cached_scm initialization hack.
45         * Scripts/modules/buildbot.py:
46          - Make default_host accessible to callers.
47         * Scripts/modules/commands/download.py:
48          - Phrase help for all commands consistently and remove spurious help text punctuation.
49         * Scripts/modules/commands/queries.py: Ditto.
50         * Scripts/modules/commands/queues.py: Ditto.
51         * Scripts/modules/commands/upload.py: Ditto.
52         * Scripts/modules/multicommandtool.py:
53          - Add HelpPrintingOptionParser.format_epilog to replace
54            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
55            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
56          - Make --help only show a list of commands like "svn help" and "git help" do --
57            previously --help was listing all commands and options.
58          - Sort list of commands alphabetically.
59
60 2009-11-21  Eric Seidel  <eric@webkit.org>
61
62         No review.  Fixing a typo from the previous patch for bug 31767.
63
64         AbstractQueue.run_bugzilla_tool throws an exception
65         https://bugs.webkit.org/show_bug.cgi?id=31769
66
67         * Scripts/modules/commands/queues.py:
68
69 2009-11-21  Eric Seidel  <eric@webkit.org>
70
71         Reviewed by Adam Barth.
72
73         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
74         https://bugs.webkit.org/show_bug.cgi?id=31767
75
76         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
77         Since we don't have a good way to test BugzillaTool pieces, I've
78         left out a test for now.
79
80         * Scripts/bugzilla-tool:
81          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
82         * Scripts/modules/commands/queues.py:
83          - Use tool.path() instead of __file__.
84         * Scripts/modules/multicommandtool.py:
85          - Add a new path() method to MultiComandTool.
86         * Scripts/modules/multicommandtool_unittest.py:
87          - Provide a path() method.  Little point in testing this mock implementation.
88
89 2009-11-21  Adam Barth  <abarth@webkit.org>
90
91         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
92         WebKitTools.
93
94         * Scripts/modules/commands/download.py:
95
96 2009-11-21  Adam Barth  <abarth@webkit.org>
97
98         Reviewed by Eric Seidel.
99
100         Convert check-style to use LandingSequence
101         https://bugs.webkit.org/show_bug.cgi?id=31763
102
103         Instead of manipulating the working copy by hand, we should use the
104         LandingSequence in CheckStyle.  This will make this code eaiser to
105         test.
106
107         * Scripts/modules/commands/download.py:
108
109 2009-11-20  Adam Barth  <abarth@webkit.org>
110
111         Reviewed by Eric Seidel.
112
113         Unit test query commands
114         https://bugs.webkit.org/show_bug.cgi?id=31755
115
116         These tests are pretty rough, but hopefully they'll grow.
117
118         * Scripts/modules/commands/queries_unittest.py: Added.
119         * Scripts/modules/mock_bugzillatool.py: Added.
120         * Scripts/run-webkit-unittests:
121
122 2009-11-20  Eric Seidel  <eric@webkit.org>
123
124         Reviewed by Adam Barth.
125
126         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
127         https://bugs.webkit.org/show_bug.cgi?id=31758
128
129         * Scripts/modules/multicommandtool.py:
130          - Allow passing of explicit commands to MultiCommandTool.__init__
131         * Scripts/modules/multicommandtool_unittest.py:
132          - Use new Command.name naming system.
133          - Test Command auto-discovery.
134         * Scripts/modules/workqueue.py:
135          - bug_id no longer exists, use patch['bug_id'] instead.
136         * Scripts/modules/workqueue_unittest.py:
137          - WorkQueues require names now.
138          - should_proceed_with_work_item must return a patch object.
139
140 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
141
142         Reviewed by Beth Dakin.
143
144         WAI-ARIA: add support for aria-owns
145         https://bugs.webkit.org/show_bug.cgi?id=31702
146
147         * DumpRenderTree/AccessibilityUIElement.cpp:
148         (ariaOwnsElementAtIndexCallback):
149         (AccessibilityUIElement::getJSClass):
150         * DumpRenderTree/AccessibilityUIElement.h:
151         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
152         (AccessibilityUIElement::ariaOwnsElementAtIndex):
153         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
154         (AccessibilityUIElement::ariaOwnsElementAtIndex):
155         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
156         (AccessibilityUIElement::ariaOwnsElementAtIndex):
157
158 2009-11-20  Eric Seidel  <eric@webkit.org>
159
160         Reviewed by Adam Barth.
161
162         Fix exception thrown when running the commit-queue.
163
164         * Scripts/modules/statusbot.py: patch is optional.
165         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
166
167 2009-11-20  Eric Seidel  <eric@webkit.org>
168
169         Reviewed by Adam Barth.
170
171         Teach the StatusBot how to support more than just the commit-queue
172         https://bugs.webkit.org/show_bug.cgi?id=31754
173
174         * Scripts/modules/workqueue.py: Another typo.
175
176 2009-11-20  Eric Seidel  <eric@webkit.org>
177
178         Reviewed by Adam Barth.
179
180         Teach the StatusBot how to support more than just the commit-queue
181         https://bugs.webkit.org/show_bug.cgi?id=31754
182
183         * Scripts/modules/commands/queues.py: Fix silly typo.
184
185 2009-11-20  Eric Seidel  <eric@webkit.org>
186
187         Reviewed by Adam Barth.
188
189         Teach the StatusBot how to support more than just the commit-queue
190         https://bugs.webkit.org/show_bug.cgi?id=31754
191
192         * CommitQueueStatus/index.yaml:
193          - Add indices required for the new queries.
194         * CommitQueueStatus/queue_status.py:
195          - Add a patch-status page and move update_status to update-status.
196          - Only display "commit-queue" status records for the commit-queue.
197          - Add support for a queue_name property on status records.
198          - Fix _int_from_request to actually work.
199         * CommitQueueStatus/update_status.html:
200          - Add support for a queue_name on status records.
201          - Remove unused list of bug ids.
202          * Scripts/modules/commands/queues.py
203           - Make the queues pass the patch instead of the bug_id to StatusBot.
204         * Scripts/modules/statusbot.py:
205          - Support passing the queue_name to the status updates.
206          - Support fetching patch status with patch_status().
207         * Scripts/modules/workqueue.py:
208          - Pass the patch to the StatusBot instead of the bug_id.
209          - Let WorkQueues have a name.
210
211 2009-11-20  Adam Barth  <abarth@webkit.org>
212
213         Reviewed by Eric Seidel.
214
215         Move bugzilla-tool commands into their own file
216         https://bugs.webkit.org/show_bug.cgi?id=31752
217
218         This will let us write unit tests.
219
220         * Scripts/bugzilla-tool:
221         * Scripts/modules/commands/__init__.py: Added.
222         * Scripts/modules/commands/download.py: Added.
223         * Scripts/modules/commands/queries.py: Added.
224         * Scripts/modules/commands/queues.py: Added.
225         * Scripts/modules/commands/upload.py: Added.
226         * Scripts/modules/grammar.py: Added.
227
228 2009-11-20  Adam Barth  <abarth@webkit.org>
229
230         Reviewed by Eric Seidel.
231
232         BuildQueue should check if the tree is currently buildable
233         https://bugs.webkit.org/show_bug.cgi?id=31744
234
235         * Scripts/bugzilla-tool:
236         * Scripts/modules/landingsequence.py:
237         * Scripts/modules/webkitlandingscripts.py:
238
239 2009-11-20  Adam Barth  <abarth@webkit.org>
240
241         Reviewed by Eric Seidel.
242
243         Move prepare_clean_working_directory into the LandingSequence
244         https://bugs.webkit.org/show_bug.cgi?id=31743
245
246         * Scripts/bugzilla-tool:
247         * Scripts/modules/landingsequence.py:
248
249 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
250
251         Reviewed by Kenneth Rohde Christiansen.
252
253         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
254         https://bugs.webkit.org/show_bug.cgi?id=30460
255
256         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
257
258         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
259         (pluginInvoke):
260
261 2009-11-20  Adam Barth  <abarth@webkit.org>
262
263         Reviewed by Eric Seidel.
264
265         Pass the port information to the child process
266         https://bugs.webkit.org/show_bug.cgi?id=31736
267
268         We need to do this so the child process knows what to build!
269
270         * Scripts/bugzilla-tool:
271         * Scripts/modules/landingsequence.py:
272         * Scripts/modules/webkitport.py:
273         * Scripts/modules/webkitport_unittest.py:
274
275 2009-11-20  Adam Barth  <abarth@webkit.org>
276
277         Reviewed by Eric Seidel.
278
279         Support Qt port in build-queue
280         https://bugs.webkit.org/show_bug.cgi?id=31733
281
282         * Scripts/bugzilla-tool:
283
284 2009-11-20  Adam Barth  <abarth@webkit.org>
285
286         Reviewed by Eric Seidel.
287
288         Implement a build-queue
289         https://bugs.webkit.org/show_bug.cgi?id=31725
290
291         Currently this just builds the first 10 patches in the review queue.
292         We'll want to do something smarter soon.
293
294         * Scripts/bugzilla-tool:
295
296 2009-11-20  Adam Barth  <abarth@webkit.org>
297
298         Reviewed by Eric Seidel.
299
300         Make commit-queue and style-queue show up in help
301         https://bugs.webkit.org/show_bug.cgi?id=31724
302
303         We need to store their names on their class to make these commands
304         properly register themselves with MultiCommandTool.
305
306         * Scripts/bugzilla-tool:
307
308 2009-11-20  Adam Barth  <abarth@webkit.org>
309
310         Reviewed by Eric Seidel.
311
312         Implement bugzilla-tool build-attachment
313         https://bugs.webkit.org/show_bug.cgi?id=31722
314
315         This command builds an attachment from bugzilla.  It leaves the built
316         patch in the working copy.
317
318         * Scripts/bugzilla-tool:
319         * Scripts/modules/landingsequence.py:
320         * Scripts/modules/webkitlandingscripts.py:
321
322 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
323
324         Reviewed by Xan Lopez.
325
326         [GTK] DRT release event does not create the state correctly
327         https://bugs.webkit.org/show_bug.cgi?id=31717
328
329         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
330
331 2009-11-20  Eric Seidel  <eric@webkit.org>
332
333         Reviewed by Adam Barth.
334
335         MultiCommandTool should find Command objects automatically instead of with a manual list
336         https://bugs.webkit.org/show_bug.cgi?id=31710
337
338         * Scripts/bugzilla-tool:
339         * Scripts/modules/multicommandtool.py:
340          - Use some wild python-fu to crawl all the known subclasses of Command.
341
342 2009-11-20  Adam Barth  <abarth@webkit.org>
343
344         Unreviewed "build" fix.  Added missing import.
345
346         * Scripts/bugzilla-tool:
347
348 2009-11-20  Adam Barth  <abarth@webkit.org>
349
350         Unreviewed "build" fix.  I failed to update LandingSequence.test
351         properly.
352
353         * Scripts/modules/landingsequence.py:
354
355 2009-11-20  Adam Barth  <abarth@webkit.org>
356
357         Reviewed by Eric Seidel.
358
359         Create LandingSequence as the all-sing, all-dance landing class
360         https://bugs.webkit.org/show_bug.cgi?id=31709
361
362         Client can inherit from this class to carefully control exactly which
363         steps they wish to have happen in the landing sequence.
364
365         * Scripts/bugzilla-tool:
366         * Scripts/modules/landingsequence.py: Added.
367         * Scripts/modules/webkitlandingscripts.py: Added.
368
369 2009-11-19  Adam Barth  <abarth@webkit.org>
370
371         Reviewed by Eric Seidel.
372
373         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
374         https://bugs.webkit.org/show_bug.cgi?id=31707
375
376         This is to help when we implement build-attachment.
377
378         * Scripts/bugzilla-tool:
379
380 2009-11-19  Adam Barth  <abarth@webkit.org>
381
382         Reviewed by Eric Seidel.
383
384         Support Qt port in bugzilla-tool
385         https://bugs.webkit.org/show_bug.cgi?id=31701
386
387         Now we support building with Qt!
388
389         * Scripts/bugzilla-tool:
390         * Scripts/modules/webkitport.py: Added.
391         * Scripts/modules/webkitport_unittest.py: Added.
392         * Scripts/run-webkit-unittests:
393
394 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
395
396         Reviewed by Adam Barth.
397
398         Remove inserting stderr into patch in bugzilla-tool
399         https://bugs.webkit.org/show_bug.cgi?id=29914
400
401         Modify SCM python module's run_command function to avoid return of stderr
402         by default, so stderr won't be inserted into the patches.
403         Modify the related unit test.
404
405         * Scripts/modules/scm.py:
406         * Scripts/modules/scm_unittest.py:
407
408 2009-11-19  Eric Seidel  <eric@webkit.org>
409
410         Reviewed by Adam Barth.
411
412         bugzilla-tool needs per-command help
413         https://bugs.webkit.org/show_bug.cgi?id=31697
414
415         Added support for "bugzilla-tool help command-name"
416         and a unit test to make sure it works.
417
418         * Scripts/modules/multicommandtool.py:
419         * Scripts/modules/multicommandtool_unittest.py:
420
421 2009-11-19  Eric Seidel  <eric@webkit.org>
422
423         Reviewed by Adam Barth.
424
425         Move MultiCommandTool and Command into a separate file and add some basic unit tests
426         https://bugs.webkit.org/show_bug.cgi?id=31695
427
428         * Scripts/bugzilla-tool:
429         * Scripts/modules/multicommandtool.py: Added.
430         * Scripts/modules/multicommandtool_unittest.py: Added.
431         * Scripts/run-webkit-unittests:
432
433 2009-11-19  Eric Seidel  <eric@webkit.org>
434
435         No review, just adding a FIXME.
436
437         Split out command parsing and help printing from BugzillaTool
438         https://bugs.webkit.org/show_bug.cgi?id=31688
439
440         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
441
442 2009-11-19  Eric Seidel  <eric@webkit.org>
443
444         Reviewed by Adam Barth.
445
446         Split out command parsing and help printing from BugzillaTool
447         https://bugs.webkit.org/show_bug.cgi?id=31688
448
449         * Scripts/bugzilla-tool:
450          - Add new MultiCommandTool class to contain option parsing and help printing logic.
451          - Rename private methods to use _ pattern.
452          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
453          - 
454
455 2009-11-19  Eric Seidel  <eric@webkit.org>
456
457         Reviewed by Adam Barth.
458
459         Re-factor help printing to use modern python idioms
460         https://bugs.webkit.org/show_bug.cgi?id=31685
461
462         * Scripts/bugzilla-tool:
463
464 2009-11-19  Eric Seidel  <eric@webkit.org>
465
466         Reviewed by Darin Adler.
467
468         commit-queue empty queue logs twice
469         https://bugs.webkit.org/show_bug.cgi?id=31679
470
471         * Scripts/bugzilla-tool:
472
473 2009-11-19  Eric Seidel  <eric@webkit.org>
474
475         Reviewed by Darin Adler.
476
477         bugzilla-tool's reviewer/committer rejection message should be clearer
478         https://bugs.webkit.org/show_bug.cgi?id=31126
479
480         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
481
482         * Scripts/modules/bugzilla.py:
483
484 2009-11-19  Eric Z. Ayers  <zundel@google.com>
485
486         Reviewed by Pavel Feldman.
487
488         Forces a WM_PAINT event on calling layoutTestController.display()
489         in order to enable the timeline-paint.html test on Windows.
490         ::UpdateWindow() does not force an event becaue the window is 
491         not visible.
492
493         https://bugs.webkit.org/show_bug.cgi?id=31402
494
495         * DumpRenderTree/win/DumpRenderTree.cpp:
496         (displayWebView):
497
498 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
499
500         No review needed.
501
502         Added myself to committers list.
503
504         * Scripts/modules/committers.py:
505
506 2009-11-19  Adam Barth  <abarth@webkit.org>
507
508         Reviewed by Eric Seidel.
509
510         Bugzilla-tool command classes should match command names
511         https://bugs.webkit.org/show_bug.cgi?id=31666
512
513         I renamed all the commands except CommitMessageForCurrentDiff because
514         the new name would conflict with an existing class.
515
516         * Scripts/bugzilla-tool:
517
518 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
519
520         Reviewed by Gustavo Noronha Silva.
521
522         Web Inspector: Implement "show inspector" in WebKit GTK
523         API and enable console tests.
524
525         https://bugs.webkit.org/show_bug.cgi?id=31669
526
527         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
528         (LayoutTestController::showWebInspector):
529
530 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
531
532         Reviewed by Simon Hausmann.
533
534         Minor refactoring + more documentation.
535
536         * DumpRenderTree/qt/DumpRenderTree.cpp:
537         (WebCore::clearHistory):
538         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
539
540 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
541
542         Reviewed by Eric Seidel.
543
544         Ignore websocket tests when --no-http is specified.
545         https://bugs.webkit.org/show_bug.cgi?id=31662
546
547         * Scripts/run-webkit-tests:
548
549 2009-11-18  Adam Barth  <abarth@webkit.org>
550
551         Reviewed by Eric Seidel.
552
553         Normalize ' and " in bugzilla-tool
554         https://bugs.webkit.org/show_bug.cgi?id=31655
555
556         We decided " is better than ' and we should be consistent.
557
558         * Scripts/bugzilla-tool:
559
560 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
561
562         Reviewed by Kenneth Rohde Christiansen.
563
564         [Qt] Remove support for Qt v4.3 or older versions
565         https://bugs.webkit.org/show_bug.cgi?id=29469
566
567         * DumpRenderTree/qt/DumpRenderTree.pro:
568         * DumpRenderTree/qt/ImageDiff.pro:
569
570 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
571
572         Reviewed by Eric Seidel.
573
574         GitTest.test_create_binary_patch fails if /tmp is symlink
575         https://bugs.webkit.org/show_bug.cgi?id=31536
576
577         * Scripts/modules/scm_unittest.py:
578
579 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
580
581         Reviewed by Darin Adler.
582
583         Configuration for Chromium Build Slaves.
584
585         https://bugs.webkit.org/show_bug.cgi?id=31442
586
587         * BuildSlaveSupport/build.webkit.org-config/config.json:
588         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
589
590 2009-11-18  Eric Seidel  <eric@webkit.org>
591
592         Reviewed by Darin Adler.
593
594         workqueue.py results in totally broken commit-queue UI
595         https://bugs.webkit.org/show_bug.cgi?id=31645
596
597         * Scripts/bugzilla-tool:
598          - Remove unneeded use of PatchCollection.
599          - Grab a new copy of the cq'd patches every run of the queue.
600
601 2009-11-18  Sam Weinig  <sam@webkit.org>
602
603         Reviewed by Anders Carlsson.
604
605         Make the Mac Geolocation API async.
606
607         Update DRT to use the new async Mac Geolocation API.
608
609         * DumpRenderTree/mac/UIDelegate.mm:
610         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
611
612 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
613
614         Reviewed by Kenneth Rohde Christiansen.
615
616         Add and option to toggle HTML5 datalist support to build-webkit
617         https://bugs.webkit.org/show_bug.cgi?id=31599
618
619         * Scripts/build-webkit:
620
621 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
622
623         Reviewed by Kevin Ollivier.
624
625         Enable wx plugin support using the Windows implementation as a base.
626         
627         https://bugs.webkit.org/show_bug.cgi?id=31636
628
629         * wx/build/settings.py:
630
631 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
632
633         Reviewed by Simon Hausmann.
634
635         Change the initialization order so that the controllers
636         will be created before exporting them to the JS DOM window.
637
638         * DumpRenderTree/qt/DumpRenderTree.cpp:
639         (WebCore::DumpRenderTree::DumpRenderTree):
640
641 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
642
643         Reviewed by Simon Hausmann.
644
645         Fix a code copy and paste error. m_page should be page.
646
647         * DumpRenderTree/qt/DumpRenderTree.cpp:
648         (WebCore::DumpRenderTree::createWindow):
649
650 2009-11-17  Mark Rowe  <mrowe@apple.com>
651
652         Reviewed by Alexey Proskuryakov.
653
654         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
655
656         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
657         This prevents symlinks from confusing the descendant check.
658
659 2009-11-17  Mark Rowe  <mrowe@apple.com>
660
661         Reviewed by Alexey Proskuryakov.
662
663         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
664
665         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
666         server to be up rather than having run-webkit-tests abort immediately.
667
668         * Scripts/run-webkit-tests:
669
670 2009-11-17  Eric Seidel  <eric@webkit.org>
671
672         Reviewed by Darin Adler.
673
674         commit-queue is failing to set reviewer in ChangeLogs
675         https://bugs.webkit.org/show_bug.cgi?id=31592
676
677         * Scripts/bugzilla-tool: Clarify the "applying" log message.
678         * Scripts/modules/bugzilla.py:
679          - Add a new _validate_committer_and_reviewer function as a
680            temporary solution until we can make a real Attachment object
681            which knows how to fill in its committer/reviewer fields automatically.
682
683 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
684
685         Unreviewed buildbot fix.
686
687         Revert part of earlier patch and add comment, as it
688         was causing timeouts on the buildbot.
689
690         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
691         (LayoutTestController::notifyDone):
692
693 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
694
695         Reviewed by Oliver Hunt.
696
697         Make the timeout 15 sec as for the other DRT's and make
698         it print out the same output when a test timeout.
699
700         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
701         (LayoutTestController::waitUntilDone):
702         (LayoutTestController::notifyDone):
703         (LayoutTestController::timerEvent):
704
705 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
706
707         Reviewed by Timothy Hatcher.
708
709         Fixed typos in comments.
710
711         * Scripts/modules/committers.py:
712
713 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
714
715         Reviewed by Timothy Hatcher.
716
717         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
718         - Updated DRT to show/close inspector for all tests under /inspector
719         - Introduced LayoutTestController::setTimelineProfilingEnabled and
720           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
721         - Removed reload on each inspector test
722         - Renamed fast/inspector to fast/inspector-support in order not to trigger
723         inspector for those.
724         - Reimplemented timeline tests in order to get rid of reload there.
725         - Moved tests that don't require harness into the fast group.
726
727         https://bugs.webkit.org/show_bug.cgi?id=31472
728
729         * DumpRenderTree/LayoutTestController.cpp:
730         (setTimelineProfilingEnabledCallback):
731         (closeWebInspectorCallback):
732         (LayoutTestController::staticFunctions):
733         * DumpRenderTree/LayoutTestController.h:
734         * DumpRenderTree/gtk/DumpRenderTree.cpp:
735         (shouldOpenWebInspector):
736         (runTest):
737         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
738         (LayoutTestController::setTimelineProfilingEnabled):
739         * DumpRenderTree/mac/DumpRenderTree.mm:
740         (shouldOpenWebInspector):
741         (runTest):
742         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
743         (LayoutTestController::setTimelineProfilingEnabled):
744         * DumpRenderTree/win/DumpRenderTree.cpp:
745         (shouldOpenWebInspector):
746         (runTest):
747         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
748         (LayoutTestController::setTimelineProfilingEnabled):
749
750 2009-11-17  Oliver Hunt  <oliver@apple.com>
751
752         Reviewed by Maciej Stachowiak.
753
754         Incorrect use of JavaScriptCore API in DumpRenderTree
755         https://bugs.webkit.org/show_bug.cgi?id=31577
756
757         Return undefined rather than a literal null.
758
759         * DumpRenderTree/AccessibilityUIElement.cpp:
760         (setSelectedTextRangeCallback):
761         (incrementCallback):
762         (decrementCallback):
763         (showMenuCallback):
764
765 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
766
767         Reviewed by Beth Dakin.
768
769         AX: aria-labelledby duplicates some of its WAI-ARIA label
770         https://bugs.webkit.org/show_bug.cgi?id=31565
771
772         * DumpRenderTree/AccessibilityUIElement.cpp:
773         (titleUIElementCallback):
774         (getIsValidCallback):
775         (AccessibilityUIElement::getJSClass):
776
777 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
778
779         Reviewed by Simon Hausmann.
780
781         r50942 broke output from created windows. Make the
782         m_enableTextOutput a member of the DRT and not the
783         WebPage.
784
785         * DumpRenderTree/qt/DumpRenderTree.cpp:
786         (WebCore::WebPage::WebPage):
787         (WebCore::WebPage::javaScriptAlert):
788         (WebCore::WebPage::javaScriptConsoleMessage):
789         (WebCore::WebPage::javaScriptConfirm):
790         (WebCore::WebPage::javaScriptPrompt):
791         (WebCore::WebPage::acceptNavigationRequest):
792         (WebCore::DumpRenderTree::DumpRenderTree):
793         (WebCore::DumpRenderTree::open):
794         (WebCore::DumpRenderTree::createWindow):
795         * DumpRenderTree/qt/DumpRenderTree.h:
796         (WebCore::DumpRenderTree::setTextOutputEnabled):
797         (WebCore::DumpRenderTree::isTextOutputEnabled):
798         (WebCore::WebPage::shouldInterruptJavaScript):
799         (WebCore::WebPage::isTextOutputEnabled):
800         (WebCore::WebPage::setViewGeometry):
801
802 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
803
804         Reviewed by Gustavo Noronha Silva.
805
806         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
807         as the implementation is being used by at least Qt and Gtk+.
808
809         Update buildsystems as well.
810
811         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
812         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
813         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
814         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
815         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
816         * GNUmakefile.am:
817
818 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
819
820         Reviewed by Alexey Proskuryakov.
821
822         Disable wss until all platforms support pyOpenSSL
823
824         https://bugs.webkit.org/show_bug.cgi?id=31479
825
826         * Scripts/run-webkit-tests:
827
828 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
829
830         Reviewed by Kenneth Christiansen.
831
832         [Qt] Implement load error pages support for Qt's DRT.
833         https://bugs.webkit.org/show_bug.cgi?id=31509
834
835         For now, it will not be a default feature, and layout tests
836         that want to make use of this have to explicitily call
837         'handleErrorPages();' for the test source.
838
839         Any of the other DumpRenderTree's (mac, win and gtk)
840         support handling error pages. Qt's will be the first.
841
842         * DumpRenderTree/qt/DumpRenderTree.cpp:
843         (WebCore::WebPage::supportsExtension):
844         (WebCore::WebPage::extension):
845         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
846         (LayoutTestController::reset):
847         * DumpRenderTree/qt/LayoutTestControllerQt.h:
848         (LayoutTestController::shouldHandleErrorPages):
849         (LayoutTestController::handleErrorPages):
850
851 2009-11-16  Eric Seidel  <eric@webkit.org>
852
853         Reviewed by Adam Barth.
854
855         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
856         https://bugs.webkit.org/show_bug.cgi?id=31549
857
858         Renamed --commit-queue to --non-interactive in most places
859         and remove the code in land-patches which is no longer needed.
860
861         * Scripts/bugzilla-tool:
862
863 2009-11-16  Eric Seidel  <eric@webkit.org>
864
865         Reviewed by Adam Barth.
866
867         The commit-queue should use land-attachment
868         https://bugs.webkit.org/show_bug.cgi?id=31548
869
870         * Scripts/bugzilla-tool:
871
872 2009-11-16  Adam Barth  <abarth@webkit.org>
873
874         Reviewed by Eric Seidel.
875
876         Convert CommitQueue over to PatchCollection
877         https://bugs.webkit.org/show_bug.cgi?id=31547
878
879         Also fixes a bug in workqueue and adds a test!
880
881         * Scripts/bugzilla-tool:
882         * Scripts/modules/workqueue.py:
883         * Scripts/modules/workqueue_unittest.py:
884
885 2009-11-16  Adam Barth  <abarth@webkit.org>
886
887         Reviewed by Eric Seidel.
888
889         Move StyleQueue over to using PatchCollection
890         https://bugs.webkit.org/show_bug.cgi?id=31544
891
892         That's what the class it's for.
893
894         * Scripts/bugzilla-tool:
895         * Scripts/modules/patchcollection.py:
896         * Scripts/modules/patchcollection_unittest.py:
897
898 2009-11-16  Eric Seidel  <eric@webkit.org>
899
900         Reviewed by Adam Barth.
901
902         bugzilla-tool needs a land-attachment command
903         https://bugs.webkit.org/show_bug.cgi?id=31546
904
905         * Scripts/bugzilla-tool:
906          - Move all the logic into AbstractLandingCommand and
907            add a new LandAttachment command subclass.
908          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
909
910 2009-11-16  Eric Seidel  <eric@webkit.org>
911
912         Reviewed by Adam Barth.
913
914         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
915         https://bugs.webkit.org/show_bug.cgi?id=31543
916
917         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
918
919         * Scripts/bugzilla-tool:
920
921 2009-11-16  Eric Seidel  <eric@webkit.org>
922
923         Reviewed by Adam Barth.
924
925         Disable the style queue from posting to the commit queue status page.
926
927         * Scripts/bugzilla-tool:
928
929 2009-11-16  Adam Barth  <abarth@webkit.org>
930
931         Reviewed by Eric Seidel.
932
933         Implement PatchCollection
934         https://bugs.webkit.org/show_bug.cgi?id=31541
935
936         This class holds a set of patches and lets clients iterate through
937         them.  Optionally, clients can install a filter.
938
939         * Scripts/modules/patchcollection.py: Added.
940         * Scripts/modules/patchcollection_unittest.py: Added.
941         * Scripts/run-webkit-unittests:
942
943 2009-11-16  Eric Seidel  <eric@webkit.org>
944
945         Reviewed by Adam Barth.
946
947         bugzilla-tool land-patches will close bugs with patches r=?
948         https://bugs.webkit.org/show_bug.cgi?id=28230
949
950         The commit-queue shouldn't close patches with outstanding reviews on them,
951         even if many reviewers seem to be against multi-patch bugs.
952
953         * Scripts/bugzilla-tool:
954
955 2009-11-16  Eric Seidel  <eric@webkit.org>
956
957         Reviewed by Adam Barth.
958
959         bugzilla-tool check-style should work with attachment ids instead of bug ids
960         https://bugs.webkit.org/show_bug.cgi?id=31540
961
962         * Scripts/bugzilla-tool:
963
964 2009-11-16  Eric Seidel  <eric@webkit.org>
965
966         Reviewed by Adam Barth.
967
968         WorkQueue is the only place that should know about special exit codes
969         https://bugs.webkit.org/show_bug.cgi?id=31534
970
971         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
972         and add tests for handling exit codes.
973         I also cleaned up workqueue_unittest.py more.
974
975         * Scripts/bugzilla-tool:
976         * Scripts/modules/workqueue.py:
977         * Scripts/modules/workqueue_unittest.py:
978
979 2009-11-16  Eric Seidel  <eric@webkit.org>
980
981         Reviewed by Adam Barth.
982
983         Re-factor workqueue_unittest to allow for more than one test.
984         https://bugs.webkit.org/show_bug.cgi?id=31535
985
986         * Scripts/modules/workqueue_unittest.py:
987
988 2009-11-16  Eric Seidel  <eric@webkit.org>
989
990         Reviewed by Adam Barth.
991
992         land-patches needs to be re-factored into smaller chunks
993         https://bugs.webkit.org/show_bug.cgi?id=31532
994
995         * Scripts/bugzilla-tool: fix a couple obvious typos.
996
997 2009-11-16  Eric Seidel  <eric@webkit.org>
998
999         Reviewed by Adam Barth.
1000
1001         land-patches needs to be re-factored into smaller chunks
1002         https://bugs.webkit.org/show_bug.cgi?id=31532
1003
1004         The next patch will move these methods into WebKitLandingScripts.
1005
1006         * Scripts/bugzilla-tool:
1007          - Split out _land_patch and _close_bug_if_no_active_patches.
1008
1009 2009-11-16  Adam Barth  <abarth@webkit.org>
1010
1011         Reviewed by Eric Seidel.
1012
1013         Fix silly copy-and-paste code.  I am a terrible coder.
1014
1015         * Scripts/modules/bugzilla.py:
1016
1017 2009-11-16  Adam Barth  <abarth@webkit.org>
1018
1019         Reviewed by Eric Seidel.
1020
1021         Implement a StyleQueue
1022         https://bugs.webkit.org/show_bug.cgi?id=31537
1023
1024         The first iteration of the style queue only produces output locally.
1025         There is also a limit of 10 patches because it's not that useful to
1026         iterate through the entire review queue at this point.  We can remove
1027         the limit later.
1028
1029         * Scripts/bugzilla-tool:
1030         * Scripts/modules/bugzilla.py:
1031
1032 2009-11-16  Adam Barth  <abarth@webkit.org>
1033
1034         Reviewed by Eric Seidel.
1035
1036         Unit test WorkQueue
1037         https://bugs.webkit.org/show_bug.cgi?id=31531
1038
1039         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1040
1041         * Scripts/bugzilla-tool:
1042         * Scripts/modules/statusbot.py:
1043         * Scripts/modules/workqueue.py:
1044         * Scripts/modules/workqueue_unittest.py: Added.
1045         * Scripts/run-webkit-unittests:
1046
1047 2009-11-16  Eric Seidel  <eric@webkit.org>
1048
1049         Reviewed by Adam Barth.
1050
1051         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1052         https://bugs.webkit.org/show_bug.cgi?id=31530
1053
1054         * Scripts/bugzilla-tool:
1055
1056 2009-11-16  Eric Seidel  <eric@webkit.org>
1057
1058         Reviewed by Adam Barth.
1059
1060         bugzilla-tool needs apply-attachment
1061         https://bugs.webkit.org/show_bug.cgi?id=31528
1062
1063         * Scripts/bugzilla-tool:
1064          - Add ApplyAttachment command.
1065          - Abstract applying code into WebKitApplyingScripts.
1066          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1067         * Scripts/modules/bugzilla.py:
1068          - Add fetch_attachment and bug_id_for_attachment_id.
1069         * Scripts/modules/bugzilla_unittest.py:
1070          - Add test for new parsing.
1071          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1072
1073 2009-11-16  Eric Seidel  <eric@webkit.org>
1074
1075         Reviewed by Adam Barth.
1076
1077         Document check-style's use of force_clean.
1078
1079         * Scripts/bugzilla-tool:
1080         * Scripts/modules/scm.py:
1081
1082 2009-11-16  Adam Barth  <abarth@webkit.org>
1083
1084         Reviewed by Eric Seidel.
1085
1086         Move WorkQueue to its own file
1087         https://bugs.webkit.org/show_bug.cgi?id=31529
1088
1089         WorkQueue and WorkQueueDelegate are separate concerns from
1090         bugzilla-tool.  Also added a missing include to logging.py.
1091
1092         * Scripts/bugzilla-tool:
1093         * Scripts/modules/logging.py:
1094         * Scripts/modules/workqueue.py:
1095
1096 2009-11-16  Adam Barth  <abarth@webkit.org>
1097
1098         Reviewed by Eric Seidel.
1099
1100         Move OutputTee to logging.py.
1101
1102         * Scripts/bugzilla-tool:
1103         * Scripts/modules/logging.py:
1104
1105 2009-11-15  Adam Barth  <abarth@webkit.org>
1106
1107         Reviewed by Eric Seidel.
1108
1109         Refactor bugzilla-tool to allow for multiple queues
1110         https://bugs.webkit.org/show_bug.cgi?id=31513
1111
1112         Divide the commit queue class into three class to make creating
1113         additional queues easier.
1114
1115         * Scripts/bugzilla-tool:
1116
1117 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1118
1119         Reviewed by Eric Seidel.
1120
1121         svn-apply may not handle git patches created by bugzilla-tool
1122         https://bugs.webkit.org/show_bug.cgi?id=31457
1123
1124         * Scripts/modules/scm.py:
1125         * Scripts/modules/scm_unittest.py:
1126
1127 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1128
1129         Reviewed by Eric Seidel.
1130
1131         bugzilla-tool should post git binary diff
1132         https://bugs.webkit.org/show_bug.cgi?id=31458
1133
1134         Add --binary option to Git.create_patch.
1135
1136         * Scripts/modules/scm.py:
1137         * Scripts/modules/scm_unittest.py:
1138
1139 2009-11-15  Adam Barth  <abarth@webkit.org>
1140
1141         Reviewed by Darin Adler.
1142
1143         Add bugzilla-tool check-style
1144         https://bugs.webkit.org/show_bug.cgi?id=31515
1145
1146         * Scripts/bugzilla-tool:
1147         * Scripts/modules/bugzilla.py:
1148
1149 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1150
1151         Reviewed by Simon Hausmann.
1152
1153         Make the Qt Linux only --valgrind feature, suppress errors
1154         defined in the SuppressedValgrindErrors file.
1155
1156         * Scripts/run-webkit-tests:
1157
1158 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1159
1160         Reviewed by Simon Hausmann.
1161
1162         Set the locale to C and not to the current one in use on the system.
1163
1164         * DumpRenderTree/qt/DumpRenderTree.cpp:
1165         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1166
1167 2009-11-13  Adam Roben  <aroben@apple.com>
1168
1169         Add support for
1170         http/tests/security/isolatedWorld/didClearWindowObject.html
1171
1172         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1173         window objects in isolated worlds are cleared
1174
1175         Reviewed by Dave Hyatt.
1176
1177         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1178
1179         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1180         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1181         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1182         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1183         Added. Sets a __worldID property on the global object whose value is
1184         the ID of this world.
1185         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1186         Respond to this new delegate callback by calling through to one of the
1187         above new methods.
1188         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1189         (worldMap): Added. Returns a HashMap containing all the worlds we've
1190         created.
1191         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1192         haven't kept track of this world.
1193         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1194         instead of declaring our own.
1195
1196         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1197
1198         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1199         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1200         didClearWindowObjectForFrameInStandardWorld.
1201         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1202         Respond to this new delegate callback by calling through to one of the
1203         below new methods.
1204         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1205         Added. Sets a __worldID property on the gobal object whose value is
1206         the ID of this world.
1207         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1208         Added. Moved code here from didClearWindowObject.
1209
1210         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1211         didClearWindowObjectForFrame* functions.
1212
1213         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1214         (worldMap): Added. Returns a HashMap containing all the worlds we've
1215         created.
1216         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1217         haven't kept track of this world.
1218         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1219         instead of declaring our own.
1220
1221 2009-11-13  Adam Roben  <aroben@apple.com>
1222
1223         Finish replacing worldIDs with world objects
1224
1225         The only remaining use of worldIDs was in a method only used by DRT
1226         for the isolated worlds tests.
1227
1228         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1229
1230         Reviewed by Mark Rowe.
1231
1232         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1233         (LayoutTestController::evaluateScriptInIsolatedWorld):
1234         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1235         (LayoutTestController::evaluateScriptInIsolatedWorld):
1236         Updated for changes to WebFrame. Now holds the map of worldID -> world
1237         at this level instead of making WebKit do it.
1238
1239 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1240
1241         Reviewed by Simon Hausmann.
1242
1243         [Qt] Ensure the DRT does not output anything until first test is run
1244
1245         * DumpRenderTree/qt/DumpRenderTree.cpp:
1246         * DumpRenderTree/qt/DumpRenderTree.h:
1247
1248 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1249
1250         Reviewed by Tor Arne Vestbø.
1251
1252         Clear the undo stack in before each new test run.
1253
1254         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1255
1256         * DumpRenderTree/qt/DumpRenderTree.cpp:
1257         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1258
1259 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1260
1261         Reviewed by Kenneth Rohde Christiansen.
1262
1263         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1264
1265         * DumpRenderTree/qt/DumpRenderTree.cpp:
1266         (WebCore::WebPage::resetSettings):
1267         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1268         (LayoutTestController::overridePreference):
1269
1270 2009-11-13  Eric Seidel  <eric@webkit.org>
1271
1272         Reviewed by Adam Barth.
1273
1274         Update committers.py based on svn records
1275         https://bugs.webkit.org/show_bug.cgi?id=31366
1276
1277         This list was generated using validate-committer-lists from
1278         https://bugs.webkit.org/show_bug.cgi?id=30970
1279         and makes committers.py current for committers who have
1280         committed in the last 3 years.
1281
1282         * Scripts/modules/committers.py:
1283
1284 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1285
1286         Reviewed by Adam Barth.
1287
1288         The document-open.html test was flaky at times. The test invokes the layout test plugin
1289         which in its destroy stream handler opens a new document. This basically tears down the
1290         stream and the associated plugin instance. The pluginLog function in the layout test
1291         plugin attempts to retrieve the window script object on a torn down plugin instance
1292         which crashed consistently on windows in the debugger. The functions which issue
1293         these logs already have a valid window script object. We now have variants of the pluginLog
1294         function which take in a window script object with and without variable arguments. 
1295
1296         https://bugs.webkit.org/show_bug.cgi?id=31067
1297
1298         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1299         (pluginLogWithWindowObject):
1300         (pluginLogWithWindowObjectVariableArgs):
1301         (pluginLog):
1302         (notifyTestCompletion):
1303         (testDocumentOpen):
1304         (testWindowOpen):
1305
1306 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1307
1308         Reviewed by Gustavo Noronha Silva.
1309
1310         https://bugs.webkit.org/show_bug.cgi?id=30997
1311         [Gtk] Implemment AtkDocument
1312
1313         Added testing support.
1314
1315         * DumpRenderTree/AccessibilityUIElement.cpp:
1316         * DumpRenderTree/AccessibilityUIElement.h:
1317         (getDocumentEncodingCallback):
1318         (getDocumentURICallback):
1319         (AccessibilityUIElement::getJSClass):
1320         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1321         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1322         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1323         (AccessibilityUIElement::documentEncoding):
1324         (AccessibilityUIElement::documentURI):
1325
1326 2009-11-12  Adam Roben  <aroben@apple.com>
1327
1328         Replace worldIDs with world objects
1329
1330         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1331         user scripts/stylesheets and isolated worlds
1332
1333         Reviewed by Sam Weinig.
1334
1335         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1336         (LayoutTestController::addUserScript):
1337         (LayoutTestController::addUserStyleSheet):
1338         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1339         (LayoutTestController::addUserScript):
1340         (LayoutTestController::addUserStyleSheet):
1341         Changed these functions to create a new WebJSWorld each time they're
1342         called and to pass that world to WebKit.
1343
1344 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1345
1346         Reviewed by Oliver Hunt.
1347
1348         need to implement aria tree roles
1349         https://bugs.webkit.org/show_bug.cgi?id=31284
1350
1351         * DumpRenderTree/AccessibilityUIElement.cpp:
1352         (disclosedRowAtIndexCallback):
1353         (selectedRowAtIndexCallback):
1354         (isEqualCallback):
1355         (isAttributeSettableCallback):
1356         (isActionSupportedCallback):
1357         (disclosedByRowCallback):
1358         (hierarchicalLevelCallback):
1359         (AccessibilityUIElement::getJSClass):
1360         * DumpRenderTree/AccessibilityUIElement.h:
1361         (AccessibilityUIElement::isEqual):
1362         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1363         (AccessibilityUIElement::hierarchicalLevel):
1364         (AccessibilityUIElement::disclosedRowAtIndex):
1365         (AccessibilityUIElement::selectedRowAtIndex):
1366         (AccessibilityUIElement::disclosedByRow):
1367         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1368         (AccessibilityUIElement::getChildAtIndex):
1369         (AccessibilityUIElement::disclosedRowAtIndex):
1370         (AccessibilityUIElement::selectedRowAtIndex):
1371         (AccessibilityUIElement::titleUIElement):
1372         (AccessibilityUIElement::parentElement):
1373         (AccessibilityUIElement::disclosedByRow):
1374         (AccessibilityUIElement::hierarchicalLevel):
1375         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1376         (AccessibilityUIElement::hierarchicalLevel):
1377         (AccessibilityUIElement::disclosedRowAtIndex):
1378         (AccessibilityUIElement::selectedRowAtIndex):
1379         (AccessibilityUIElement::disclosedByRow):
1380
1381 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1382
1383         Reviewed by Darin Adler.
1384
1385         svn-apply can not handle git binary diffs
1386         https://bugs.webkit.org/show_bug.cgi?id=26830
1387
1388         Support "literal" type git binary diffs.
1389
1390         * Scripts/VCSUtils.pm:
1391         * Scripts/modules/scm_unittest.py:
1392         * Scripts/svn-apply:
1393
1394 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1395
1396         Not reviewed, removing duplicate entry for myself in committers.py.
1397
1398         * Scripts/modules/committers.py:
1399
1400 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1401
1402         Reviewed by Darin Adler and Mark Rowe.
1403
1404         https://bugs.webkit.org/show_bug.cgi?id=31200
1405         Tests in http/tests/security/mixedContent start to fail when new tests are added
1406
1407         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1408
1409 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1410
1411         Reviewed by Jan Alonzo.
1412
1413         Create, and display a window for the inspector, for inspector
1414         tests.
1415
1416         Need to also show/hide the inspector window to avoid having
1417         problems with code assuming it is realized
1418         https://bugs.webkit.org/show_bug.cgi?id=31347
1419
1420         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1421         (webInspectorShowWindow):
1422         (webInspectorCloseWindow):
1423         (webInspectorInspectWebView):
1424         (createWebView):
1425
1426 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1427
1428         Unreviewed Qt buildbot fix.
1429
1430         My previous fix was wrong, so revert that change and fix it by
1431         returning when the document of the frame has no document element.
1432         Idea is borrowed from mac and win DRT.
1433
1434         * DumpRenderTree/qt/DumpRenderTree.cpp:
1435         (WebCore::DumpRenderTree::dumpFramesAsText):
1436
1437 2009-11-11  Eric Seidel  <eric@webkit.org>
1438
1439         Reviewed byg Kenneth Rohde Christiansen.
1440
1441         Update Kenneth's committer record to include the email he
1442         uses on lists.webkit.org.
1443
1444         * Scripts/modules/committers.py:
1445
1446 2009-11-11  Eric Seidel  <eric@webkit.org>
1447
1448         Reviewed by Gustavo Noronha Silva.
1449
1450         Several committers use separate email addresses for bugzilla and svn.webkit.org
1451         https://bugs.webkit.org/show_bug.cgi?id=31364
1452
1453         Update records for existing committers to include email addresses
1454         used in svn.webkit.org and lists.webkit.org.
1455         Most committers use the same email address in all 3 places, but some use
1456         separate addresses.  committers.py needs record of each of these addresses.
1457
1458         * Scripts/modules/committers.py:
1459
1460 2009-11-11  Eric Seidel  <eric@webkit.org>
1461
1462         No review, adding second email address for an existing committer.
1463
1464         Add Yong Li's second bugzilla account to his committer record.
1465         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1466
1467         * Scripts/modules/committers.py:
1468
1469 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1470
1471         Reviewed by Simon Hausmann.
1472
1473         If the frame has no innerText don't append it, and
1474         do not add a newline which breaks some cross platform
1475         results.
1476
1477         * DumpRenderTree/qt/DumpRenderTree.cpp:
1478         (WebCore::DumpRenderTree::dumpFramesAsText):
1479
1480 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1481
1482         Reviewed by Simon Hausmann.
1483
1484         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1485
1486         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1487         (webkit_test_plugin_new_instance):
1488         (webkit_test_plugin_destroy_instance):
1489         (webkit_test_plugin_destroy_stream):
1490
1491 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1492
1493         Reviewed by Mark Rowe.
1494
1495         Implement the functionality needed by plugins/window-open.html
1496
1497         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1498         (webkit_test_plugin_new_instance):
1499         (webkit_test_plugin_set_window):
1500
1501 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1502
1503         Reviewed by Simon Hausmann.
1504
1505         [Qt] Force -graphicssystem raster and -style windows when running DRT
1506
1507         * DumpRenderTree/qt/main.cpp:
1508         * Scripts/run-webkit-tests:
1509
1510 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1511
1512         Reviewed by Simon Hausmann.
1513
1514         Compute correct library paths for Qt
1515
1516         * Scripts/webkitdirs.pm:
1517
1518 2009-11-10  Mark Rowe  <mrowe@apple.com>
1519
1520         Reviewed by Sam Weinig.
1521
1522         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1523
1524         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1525         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1526         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1527         that had enabled frame load delegate logging this would result in extra log messages being generated,
1528         causing the test to fail.
1529
1530         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1531         tests.
1532
1533         * DumpRenderTree/mac/DumpRenderTree.mm:
1534         (dumpRenderTree):
1535         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1536         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1537
1538 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1539
1540         Reviewed by Kenneth Rohde Christiansen.
1541
1542         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1543
1544         * DumpRenderTree/qt/DumpRenderTree.cpp:
1545         (WebCore::DumpRenderTree::DumpRenderTree):
1546
1547 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1548
1549         Reviewed by Jan Alonzo.
1550
1551         [GTK] Remove WebSocket configuration from WebKitWebSettings
1552         https://bugs.webkit.org/show_bug.cgi?id=31244
1553
1554         Follow-up of r50724. Don't set the enable-web-socket property
1555         anymore.
1556
1557         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1558         (resetDefaultsToConsistentValues):
1559
1560 2009-11-10  Oliver Hunt  <oliver@apple.com>
1561
1562         Reviewed by Maciej Stachowiak.
1563
1564         Rename 3D Canvas related classes to use WebGL prefix
1565         https://bugs.webkit.org/show_bug.cgi?id=29095
1566
1567         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1568         and upate webkitdirs script to new method of testing for WebGL.
1569
1570         * Scripts/do-webcore-rename:
1571         * Scripts/webkitdirs.pm:
1572
1573 2009-11-09  Oliver Hunt  <oliver@apple.com>
1574
1575         Reviewed by Geoff Garen.
1576
1577         Make do-webcore-rename work with git.
1578
1579         * Scripts/do-webcore-rename:
1580
1581 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1582
1583         Adding Kenneth to the reviewers list.
1584
1585         * Scripts/modules/committers.py:
1586
1587 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1588
1589         Reviewed by Jan Alonzo.
1590
1591         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1592         https://bugs.webkit.org/show_bug.cgi?id=30482
1593
1594         LayoutTestControllerGtk now uses the exposed
1595         Page::tabKeyCyclesThroughElements API
1596
1597         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1598         (LayoutTestController::setTabKeyCyclesThroughElements):
1599
1600 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1601
1602         Reviewed by Holger Freyther.
1603
1604         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1605         This helps to pass the test case below. Also replaced hardcoded
1606         code numbers with defined constants.
1607         https://bugs.webkit.org/show_bug.cgi?id=31185
1608         
1609         Test: editing/undo/undo-deleteWord.html
1610
1611         * DumpRenderTree/qt/EventSenderQt.cpp:
1612         (EventSender::keyDown):
1613
1614 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1615
1616         Reviewed by Holger Freyther.
1617
1618         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1619         https://bugs.webkit.org/show_bug.cgi?id=31164
1620
1621         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1622
1623         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1624         (LayoutTestController::processWork):
1625
1626 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1627
1628         Reviewed by Holger Freyther.
1629
1630         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1631         https://bugs.webkit.org/show_bug.cgi?id=31158
1632
1633         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1634         always, which from WorkQueue prospective means that a load has been started
1635         and the queue processing should stop and wait for the load to finish.
1636         Spinning it off into a loading and a non-loading variants was the solution
1637         adopted by Mac's DRT to work around this problem. The former keeps returning
1638         'true' while the later executes the script synchronously and returns 'false'
1639         making it possible to the WorkQueue to proceed right away.
1640
1641         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1642         (LayoutTestController::processWork):
1643         (LayoutTestController::queueLoadingScript):
1644         (LayoutTestController::queueNonLoadingScript):
1645         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1646         * DumpRenderTree/qt/WorkQueueItem.h:
1647         (LoadingScriptItem::LoadingScriptItem):
1648         (LoadingScriptItem::invoke):
1649         (NonLoadingScriptItem::NonLoadingScriptItem):
1650         (NonLoadingScriptItem::invoke):
1651
1652 2009-11-07  Mark Rowe  <mrowe@apple.com>
1653
1654         Rubber-stamped by Cameron Zwarich.
1655
1656         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1657
1658         * Scripts/commit-log-editor:
1659
1660 2009-11-07  Mark Rowe  <mrowe@apple.com>
1661
1662         Reviewed by Darin Adler.
1663
1664         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1665         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1666
1667         Move logic for determining the name and email address to use in a ChangeLog entry from
1668         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1669         whether the author of the patch matches committer, and therefore needs access to the
1670         email address that would be used in a ChangeLog entry.
1671
1672         Based on a patch by Pierre d'Herbemont.
1673
1674         * Scripts/VCSUtils.pm:
1675         * Scripts/commit-log-editor:
1676         * Scripts/prepare-ChangeLog:
1677         * Scripts/webkitdirs.pm:
1678
1679 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1680
1681         Reviewed by Adam Barth.
1682
1683         Added functionality to the layout test plugin to invoke document.open and
1684         window.open with default arguments. The associated webkit bug is
1685         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1686         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1687         work in Chromium (V8) if there is no calling javascript context. To achieve this
1688         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1689         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1690
1691         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1692         (testDocumentOpen):
1693         (testWindowOpen):
1694         (pluginAllocate):
1695         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1696         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1697         (NPP_New):
1698         (NPP_SetWindow):
1699         (NPP_DestroyStream):
1700         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1701         (NPP_New):
1702         (NPP_SetWindow):
1703         (NPP_NewStream):
1704         (NPP_DestroyStream):
1705
1706 2009-11-06  Eric Seidel  <eric@webkit.org>
1707
1708         Reviewed by Adam Barth.
1709
1710         bugzilla-tool crashed with exception
1711         https://bugs.webkit.org/show_bug.cgi?id=31092
1712
1713         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1714
1715 2009-11-04  Eric Seidel  <eric@webkit.org>
1716
1717         No review, just add a line which got left out of the patch uploaded for commit.
1718
1719         commit-queue is crashing when trying to reject patches after unknown failures
1720         https://bugs.webkit.org/show_bug.cgi?id=31091
1721
1722         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1723
1724 2009-11-04  Adam Roben  <aroben@apple.com>
1725
1726         Remove bogus else clause in bugzilla-tool
1727
1728         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1729         create-bug raises exception after entering bug description
1730
1731         Reviewed by David Kilzer.
1732
1733         * Scripts/bugzilla-tool:
1734         (CreateBug): else clauses are only hit if no exception is raised, so
1735         it makes no sense to try to re-raise the exception in an else clause.
1736         The exception will automatically be re-raised if it doesn't match any
1737         of the except clauses, so we don't have to do anything special here at
1738         all to get the desired behavior.
1739
1740 2009-11-04  Eric Seidel  <eric@webkit.org>
1741
1742         Reviewed by David Kilzer.
1743
1744         svn-apply's fixChangeLogPatch function seems broken
1745         https://bugs.webkit.org/show_bug.cgi?id=30683
1746
1747         Update fixChangeLogPatch to be able to handle patches which
1748         don't start at line 1.
1749         Add unit tests for svn-apply to scm_unittest.py.
1750
1751         * Scripts/VCSUtils.pm:
1752         * Scripts/modules/scm_unittest.py:
1753
1754 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1755
1756         Reviewed by Beth Dakin.
1757
1758         Need to implement ARIA role="combobox"
1759         https://bugs.webkit.org/show_bug.cgi?id=31096
1760
1761         * DumpRenderTree/AccessibilityUIElement.cpp:
1762         (showMenuCallback):
1763         (getIsExpandedCallback):
1764         (AccessibilityUIElement::getJSClass):
1765         * DumpRenderTree/AccessibilityUIElement.h:
1766         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1767         (AccessibilityUIElement::isExpanded):
1768         (AccessibilityUIElement::showMenu):
1769         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1770         (AccessibilityUIElement::isExpanded):
1771         (AccessibilityUIElement::showMenu):
1772         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1773         (AccessibilityUIElement::isSelected):
1774         (AccessibilityUIElement::isExpanded):
1775         (AccessibilityUIElement::showMenu):
1776
1777 2009-11-04  Eric Seidel  <eric@webkit.org>
1778
1779         Reviewed by Adam Barth.
1780
1781         commit-queue is crashing when trying to reject patches after unknown failures
1782         https://bugs.webkit.org/show_bug.cgi?id=31091
1783
1784         * Scripts/bugzilla-tool:
1785          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1786            so we have to find out what the current patch is by asking bugzilla again.
1787          - Discovered that this code was also leaking file descriptors, so fixed that.
1788
1789 2009-11-04  Adam Roben  <aroben@apple.com>
1790
1791         Make run-webkit-tests work for the Debug_Internal Windows
1792         configuration
1793
1794         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1795         suffix.
1796
1797         Fixes <http://webkit.org/b/31123>.
1798
1799         Reviewed by Sam Weinig.
1800
1801         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1802         Debug_Internal, either.
1803
1804 2009-11-04  Eric Seidel  <eric@webkit.org>
1805
1806         Reviewed by Adam Barth.
1807
1808         committers.py needs a way to store non-bugzilla email addresses
1809         https://bugs.webkit.org/show_bug.cgi?id=31037
1810
1811         Make Committer and Reviewer constructors take a single email or a list of emails.
1812         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1813         Expose reviewers(), used by validate-committer-lists on bug 30970.
1814
1815         * Scripts/modules/committers.py:
1816         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1817
1818 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1819
1820         Reviewed by David Levin.
1821
1822         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1823         https://bugs.webkit.org/show_bug.cgi?id=27491
1824
1825         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1826         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1827
1828         Functions to start or stop Web Socket servers are added.
1829
1830         * Scripts/run-webkit-tests:
1831
1832 2009-11-03  Eric Seidel  <eric@webkit.org>
1833
1834         No review, just changing wording of log message.
1835
1836         Change log string to say "failed" instead of "rejected"
1837         when a commit fails due to an out of date checkout.
1838         This makes grepping the commit-queue log for rejected patches easier.
1839
1840         * Scripts/bugzilla-tool:
1841
1842 2009-11-03  Eric Seidel  <eric@webkit.org>
1843
1844         No review, adding commonly known committers missing from the file.
1845
1846         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1847
1848 2009-11-03  Eric Seidel  <eric@webkit.org>
1849
1850         No review, just sort-order cleanup.
1851
1852         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1853
1854 2009-11-03  Stephen White  <senorblanco@chromium.org>
1855
1856         (Unreviewed).
1857
1858         Add myself to committers.py.
1859
1860         * Scripts/modules/committers.py:
1861
1862 2009-11-03  Robin Dunn  <robin@alldunn.com>
1863
1864         Reviewed by Kevin Ollviier.
1865
1866         Add packaging scripts for Debian-based Linux distros.
1867         
1868         https://bugs.webkit.org/show_bug.cgi?id=31075
1869
1870         * wx/packaging/build-debian-installer.py: Added.
1871         * wx/packaging/debian: Added.
1872
1873 2009-11-03  Dan Bernstein  <mitz@apple.com>
1874
1875         Reviewed by Anders Carlsson and Beth Dakin.
1876
1877         https://bugs.webkit.org/show_bug.cgi?id=31070
1878
1879         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1880         destroyed, it executes the value of the 'ondestroy' parameter as a
1881         script.
1882
1883         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1884         (pluginAllocate): Initialize onDestroy.
1885         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1886         onDestroy.
1887         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1888         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
1889         specified.
1890         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
1891
1892 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1893
1894         Reviewed by Xan Lopez.
1895
1896         https://bugs.webkit.org/show_bug.cgi?id=31035
1897         [GTK] some accessibility tests hitting assertion in debug builds
1898
1899         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
1900
1901         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1902         (AccessibilityController::rootElement):
1903
1904 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
1905
1906         Reviewed by Beth Dakin.
1907
1908         Support ARIA "tab" roles
1909         https://bugs.webkit.org/show_bug.cgi?id=30842
1910
1911         * DumpRenderTree/AccessibilityUIElement.cpp:
1912         * DumpRenderTree/AccessibilityUIElement.h:
1913         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1914         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1915         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1916
1917 2009-11-01  Eric Seidel  <eric@webkit.org>
1918
1919         Reviewed by David Levin.
1920
1921         buildbots should use --exit-after-N-failures
1922         https://bugs.webkit.org/show_bug.cgi?id=30809
1923
1924         Make the bots exit after 20 failures to prevent never-ending
1925         test runs where every test spends a minute crashing.
1926
1927         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1928
1929 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1930
1931         Reviewed by Eric Seidel.
1932
1933         Turn on warnings for QtWebKit for gcc
1934         https://bugs.webkit.org/show_bug.cgi?id=30958
1935
1936         * DumpRenderTree/qt/main.cpp: 
1937         (crashHandler): Mark function NO_RETURN
1938
1939 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
1940
1941         Adding myself to the committers list.
1942
1943         * Scripts/modules/committers.py:
1944
1945 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
1946
1947         Fix an issue that Adam noticed in DRT.
1948
1949         Reviewed by Darin Adler.
1950
1951         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1952         (AccessibilityUIElement::role):
1953         Get the length of the role text, and create a buffer dynamically.
1954
1955 2009-10-30  Eric Seidel  <eric@webkit.org>
1956
1957         No review, rolling out r50105.
1958         http://trac.webkit.org/changeset/50105
1959
1960         This commit was causing:
1961         https://bugs.webkit.org/show_bug.cgi?id=30869
1962         We'll re-implement the feature a different way.
1963
1964         * Scripts/bugzilla-tool:
1965
1966 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1967
1968         Test for MSAA: Accessibility of headings is not correct
1969
1970         https://bugs.webkit.org/show_bug.cgi?id=30937
1971
1972         Reviewed by Adam Roben.
1973
1974         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1975         (AccessibilityUIElement::role):
1976         Allow the role returned to be a BSTR.
1977         (AccessibilityUIElement::description):
1978         Fix a copy/paste error.
1979
1980 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1981
1982         Test for MSAA: Accessibility of links is wrong
1983
1984         https://bugs.webkit.org/show_bug.cgi?id=30928
1985
1986         Reviewed by Darin Adler.
1987
1988         * DumpRenderTree/AccessibilityUIElement.cpp:
1989         (getAccessibilityValueCallback):
1990         Return the accessibility value.
1991         (AccessibilityUIElement::getJSClass):
1992         Added "accessibilityValue" value.
1993
1994         * DumpRenderTree/AccessibilityUIElement.h:
1995
1996         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1997         (AccessibilityUIElement::accessibilityValue):
1998         Stubbed.
1999
2000         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2001         (AccessibilityUIElement::accessibilityValue):
2002         Stubbed.
2003
2004         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2005         (AccessibilityUIElement::accessibilityValue):
2006         Get the object's value, and return it as a JS string.
2007
2008 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2009
2010         Fix typo in command name used by wx build system.
2011
2012         * wx/build/build_utils.py:
2013
2014 2009-10-30  Adam Barth  <abarth@webkit.org>
2015
2016         Reviewed by Darin Adler.
2017
2018         Patch v1 is a dumb default name for patches
2019         https://bugs.webkit.org/show_bug.cgi?id=30952
2020
2021         Let's use "Patch" instead.
2022
2023         * Scripts/bugzilla-tool:
2024
2025 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2026
2027         Unreviewed trivial buildfix.
2028
2029         [Qt] Buildfix for r50333.
2030
2031         * DumpRenderTree/qt/DumpRenderTree.pro:
2032
2033 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2034
2035         Reviewed by Holger Freyther.
2036
2037         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2038         https://bugs.webkit.org/show_bug.cgi?id=30953
2039
2040         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2041         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2042         makes qt DRT to share this implementation (as gtk and mac ports do).
2043
2044         * DumpRenderTree/qt/DumpRenderTree.pro:
2045         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2046         * DumpRenderTree/qt/WorkQueue.h: Removed.
2047
2048 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2049
2050         Unreviewed potential buildbot fix.
2051
2052         Second try: Reset page history before running each test.
2053
2054         Apparently the QWebHistory::clear() keeps the current page
2055         in history which is not what we want, so we not additionally
2056         sets the history capacity to 0 (forces removing everything)
2057         and then sets it back to its original value.
2058
2059         * DumpRenderTree/qt/DumpRenderTree.cpp:
2060         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2061
2062 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2063
2064         Unreviewed potential buildbot fix.
2065
2066         Reset page history before running each test.
2067
2068         * DumpRenderTree/qt/DumpRenderTree.cpp:
2069         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2070
2071 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2072
2073         Reviewed by Eric Seidel.
2074
2075         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2076
2077         Bug 28420 -  Implement HTML5 <ruby> rendering
2078         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2079
2080         No new tests (no functional change).
2081
2082         * Scripts/build-webkit:
2083
2084 2009-10-29  Dan Bernstein  <mitz@apple.com>
2085
2086         Reviewed by Mark Rowe.
2087
2088         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2089         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2090         define it.
2091
2092         * Scripts/VCSUtils.pm:
2093         * Scripts/svn-apply:
2094         * Scripts/svn-unapply:
2095
2096 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2097
2098         Reviewed by Gustavo Noronha.
2099
2100         Use the GTK+ main loop instead of rolling our own mini-version of
2101         it.
2102
2103         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2104         (dump):
2105         (runTest):
2106         (webViewLoadFinished):
2107
2108 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2109
2110         Reviewed by Oliver Hunt.
2111
2112         Implement the Qt version of DRT dumpBackForwardList().
2113
2114         * DumpRenderTree/qt/DumpRenderTree.cpp:
2115         (WebCore::dumpHistoryItem):
2116         (WebCore::DumpRenderTree::dumpBackForwardList):
2117
2118 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2119
2120         Reviewed by Adam Roben.
2121
2122         Implement DRT functionality for Qt introduced in
2123         r28690 and r28705.
2124
2125         - Implemented pathToLocalResource which exposes the functionality of
2126         converting a given unix path to the correct location on Windows.
2127         - Implemented a way to remove machine-dependent information from paths
2128         in layout test results.
2129
2130         * DumpRenderTree/qt/DumpRenderTree.cpp:
2131         (WebCore::urlSuitableForTestResult):
2132         (WebCore::WebPage::javaScriptConsoleMessage):
2133         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2134         (LayoutTestController::pathToLocalResource):
2135         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2136
2137 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2138
2139         Adding myself to the committers list.
2140
2141         * Scripts/modules/committers.py:
2142
2143 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2144
2145         Adding myself to the committers list.
2146
2147         * Scripts/modules/committers.py:
2148
2149 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2150
2151         Reviewed by Jan Alonzo.
2152
2153         [GTK] API to start inspector for a WebView
2154         https://bugs.webkit.org/show_bug.cgi?id=22551
2155
2156         Use the new inspector API to implement the LayoutTestController
2157         interfaces used to test the inspector.
2158
2159         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2160         (webInspectorInspectWebView):
2161         (createWebView):
2162         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2163         (LayoutTestController::showWebInspector):
2164         (LayoutTestController::closeWebInspector):
2165         (LayoutTestController::evaluateInWebInspector):
2166
2167 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2168
2169         Reviewed by Eric Seidel.
2170
2171         [Qt] WebFrame::counterValueForElementById must not be exposed
2172         https://bugs.webkit.org/show_bug.cgi?id=30882
2173
2174         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2175         (LayoutTestController::counterValueForElementById):
2176
2177 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2178
2179         Rubberstamped by Oliver Hunt.
2180
2181         Fix the warning:
2182
2183         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2184         declared with attribute warn_unused_result".
2185
2186         by actually checking the result. In the case it is null, an
2187         error has occoured, so treat it as the other fatal errors.
2188
2189         * DumpRenderTree/qt/DumpRenderTree.cpp:
2190         (WebCore::DumpRenderTree::initializeFonts):
2191
2192 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2193
2194         Reviewed by Darin Adler.
2195
2196         Provide a way to get counter values with layoutTestContoller
2197         https://bugs.webkit.org/show_bug.cgi?id=30555
2198
2199         Define layoutTestContoller.counterValueForElementById.
2200
2201         * DumpRenderTree/LayoutTestController.cpp:
2202         (counterValueForElementByIdCallback):
2203         (LayoutTestController::staticFunctions):
2204         * DumpRenderTree/LayoutTestController.h:
2205         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2206         (LayoutTestController::counterValueForElementById):
2207
2208 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2209
2210         Rubberstamped by Oliver Hunt.
2211
2212         Change two methods to be internal for DRT use only.
2213
2214         Part of [Qt] Review all new API in Qt 4.6
2215         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2216
2217         * DumpRenderTree/qt/DumpRenderTree.cpp:
2218         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2219         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2220         (LayoutTestController::whiteListAccessFromOrigin):
2221
2222 2009-10-27  Eric Seidel  <eric@webkit.org>
2223
2224         Reviewed by Adam Barth.
2225
2226         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2227         https://bugs.webkit.org/show_bug.cgi?id=30826
2228
2229         * Scripts/svn-apply:
2230          - Add () around all system() calls.
2231          - Use the correct system() == 0 or die instead of system() or die
2232          - Add descriptive messages to all die statements.
2233
2234 2009-10-27  Steve Block  <steveblock@google.com>
2235
2236         Reviewed by NOBODY.
2237
2238         Adds steveblock@google.com to list of committers.
2239
2240         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2241
2242 2009-10-27  Eric Seidel  <eric@webkit.org>
2243
2244         Reviewed by Adam Barth.
2245
2246         svn-apply can exit(0) even on patch failure
2247         https://bugs.webkit.org/show_bug.cgi?id=29622
2248
2249         * Scripts/svn-apply:
2250          - Add a bunch of "or die" statements, hopefully catching all
2251            possible cases where failure could still exit(0).
2252
2253 2009-10-27  Eric Seidel  <eric@webkit.org>
2254
2255         Reviewed by Adam Barth.
2256
2257         svn-* scripts should share code through VCSUtils.pm
2258         https://bugs.webkit.org/show_bug.cgi?id=30791
2259
2260         Just moving code into a shared location.
2261
2262         * Scripts/VCSUtils.pm:
2263         * Scripts/prepare-ChangeLog:
2264         * Scripts/resolve-ChangeLogs:
2265         * Scripts/svn-apply:
2266         * Scripts/svn-create-patch:
2267         * Scripts/svn-unapply:
2268         * Scripts/update-webkit:
2269
2270 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2271
2272         Suppress a huge number of MSVC warnings when building wxWebKit.
2273
2274         * wx/build/settings.py:
2275
2276 2009-10-26  Eric Seidel  <eric@webkit.org>
2277
2278         No review, just adding Mike Belshe to the committers list.
2279
2280         * Scripts/modules/committers.py:
2281
2282 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2283
2284         Reviewed by Darin Adler.
2285
2286         Make .rc files compile on Windows without depending on MFC headers
2287         https://bugs.webkit.org/show_bug.cgi?id=30750
2288
2289         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2290         windows.h instead of afxres.h because it exists even when MFC is not 
2291         installed, and is all that's needed here.
2292
2293         * FindSafari/FindSafari.rc: Ditto
2294
2295 2009-10-24  Eric Seidel  <eric@webkit.org>
2296
2297         Reviewed by Adam Barth.
2298
2299         bugzilla-tool post-diff should know how to mark commit-queue=?
2300         https://bugs.webkit.org/show_bug.cgi?id=29202
2301
2302         * Scripts/bugzilla-tool:
2303          - Add --commit-queue option to post-diff, post-commits and create-bug.
2304         * Scripts/modules/bugzilla.py:
2305          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2306          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2307
2308 2009-10-23  Eric Seidel  <eric@webkit.org>
2309
2310         Reviewed by Adam Barth.
2311
2312         bugzilla-tool commit-queue does not notice modifications to committers.py
2313         https://bugs.webkit.org/show_bug.cgi?id=30084
2314
2315         * Scripts/bugzilla-tool:
2316          - Make commit-queue re-exec itself instead of using while(1).
2317          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2318          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2319
2320 2009-10-22  Eric Seidel  <eric@webkit.org>
2321
2322         Reviewed by Adam Barth.
2323
2324         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2325         https://bugs.webkit.org/show_bug.cgi?id=30634
2326
2327         * Scripts/bugzilla-tool:
2328          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2329          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2330
2331 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2332
2333         Reviewed by Eric Seidel.
2334
2335         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2336
2337         https://bugs.webkit.org/show_bug.cgi?id=30763
2338
2339         * pywebsocket/mod_pywebsocket/__init__.py:
2340         * pywebsocket/mod_pywebsocket/dispatch.py:
2341         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2342         * pywebsocket/mod_pywebsocket/standalone.py:
2343         * pywebsocket/setup.py:
2344         * pywebsocket/test/test_dispatch.py:
2345
2346 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2347
2348         Reviewed by David Levin.
2349
2350         REGRESSION: 2 failures in run-webkit-unittests
2351         https://bugs.webkit.org/show_bug.cgi?id=30645
2352
2353         * Scripts/modules/cpp_style_unittest.py:
2354         Fixed a few test scenarios which apparently lost some spaces from 
2355         text literals.
2356
2357 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2358
2359         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2360
2361         * Scripts/webkitdirs.pm:
2362
2363 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2364
2365         Reviewed by Darin Adler.
2366
2367         Unification of using null device in perl scripts.
2368         https://bugs.webkit.org/show_bug.cgi?id=30572
2369
2370         * Scripts/VCSUtils.pm:
2371         * Scripts/bisect-builds:
2372         * Scripts/resolve-ChangeLogs:
2373         * Scripts/run-iexploder-tests:
2374         * Scripts/run-jsc:
2375         * Scripts/run-mangleme-tests:
2376         * Scripts/run-webkit-tests:
2377         * Scripts/webkitdirs.pm:
2378         Using File::Spec->devnull() instead of hard coded /dev/null.
2379
2380 2009-10-26  Eric Seidel  <eric@webkit.org>
2381
2382         Reviewed by Holger Freyther.
2383
2384         Reviewers are missing from committers.py
2385         https://bugs.webkit.org/show_bug.cgi?id=30733
2386
2387         * Scripts/modules/committers.py:
2388
2389 2009-10-23  Eric Seidel  <eric@webkit.org>
2390
2391         No review, only adding Alice to the list of reviewers.
2392
2393         * Scripts/modules/committers.py:
2394
2395 2009-10-23  Eric Seidel  <eric@webkit.org>
2396
2397         Reviewed by Eric Carlson.
2398
2399         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2400         https://bugs.webkit.org/show_bug.cgi?id=30700
2401
2402         * DumpRenderTree/mac/DumpRenderTree.mm:
2403         (resetDefaultsToConsistentValues): Update QuickTime version check.
2404
2405 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2406
2407         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2408         character measurement APIs that are private on Tiger.
2409
2410         * wx/build/settings.py:
2411
2412 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2413
2414         Reviewed by NOBODY (build fix).
2415         Build fix following bug #30696.
2416
2417         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2418         (LayoutTestController::evaluateScriptInIsolatedWorld):
2419
2420 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2421
2422         Reviewed by Sam Weinig & Geoff Garen.
2423
2424         https://bugs.webkit.org/show_bug.cgi?id=30696
2425         Enable isolated-worlds tests on mac.
2426
2427         Add private interface for DRT to invoke execution in a given world.
2428
2429         * DumpRenderTree/LayoutTestController.cpp:
2430         (evaluateScriptInIsolatedWorldCallback):
2431         (LayoutTestController::staticFunctions):
2432         * DumpRenderTree/LayoutTestController.h:
2433         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2434         (LayoutTestController::evaluateScriptInIsolatedWorld):
2435         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2436         (LayoutTestController::evaluateScriptInIsolatedWorld):
2437
2438 2009-10-21  Eric Seidel  <eric@webkit.org>
2439
2440         Reviewed by Adam Barth.
2441
2442         bugzilla-tool's "patch failed to download an apply" error should give more information
2443         https://bugs.webkit.org/show_bug.cgi?id=30632
2444
2445         * Scripts/modules/scm.py:
2446          - Use the common run_command method instead of custom POpen code.
2447          - Make run_command know how to take pipes as input.
2448         * Scripts/modules/scm_unittest.py:
2449          - Add new tests to cover change.
2450          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2451
2452 2009-10-21  Kent Tamura  <tkent@chromium.org>
2453
2454         Unreviewed.  Adding myself to the committers list.
2455
2456         * Scripts/modules/committers.py:
2457
2458 2009-10-21  Robin Dunn  <robin@alldunn.com>
2459
2460         Reviewed by Kevin Ollivier.
2461
2462         Update the Windows installer builder to work with Vista / Win 7 and with git.
2463         
2464         https://bugs.webkit.org/show_bug.cgi?id=30649
2465
2466         * wx/build/build_utils.py:
2467         * wx/packaging/build-mac-installer.py:
2468         * wx/packaging/build-win-installer.py:
2469         * wx/packaging/wxWebKitInstaller.iss.in:
2470
2471 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2472
2473         Reviewed by Gustavo Noronha.
2474
2475         [GTK] Added conditional code to avoid using
2476         gdk_window_get_root_coords if we do not have a gtk+ release newer
2477         than 2.17.3.
2478         https://bugs.webkit.org/show_bug.cgi?id=30636
2479
2480         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2481
2482 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2483
2484         Reviewed by Eric Seidel.
2485
2486         [Qt] Added dummy implementation for keepWebHistory()
2487         https://bugs.webkit.org/show_bug.cgi?id=30592
2488
2489         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2490         (LayoutTestController::keepWebHistory):
2491         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2492
2493 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2494
2495         Reviewed by Xan Lopez.
2496
2497         [GTK] Fixed the double click condition, it is not double click if
2498         we move in just in one direction.
2499         https://bugs.webkit.org/show_bug.cgi?id=30636
2500
2501         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2502
2503 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2504
2505         Reviewed by Xan Lopez.
2506
2507         [GTK] Initialize the events completly before emitting them.
2508         https://bugs.webkit.org/show_bug.cgi?id=30633
2509
2510         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2511
2512 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2513
2514         wx build fix. Fix for when linking using --as-needed with gcc.
2515
2516         * wx/browser/wscript:
2517
2518 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2519
2520         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2521         to support all the features used by CURL backend.
2522         
2523         * wx/build/settings.py:
2524         * wx/install-unix-extras:
2525
2526 2009-10-20  Anton Muhin  <antonm@chromium.org>
2527
2528         Reviewed by Adam Barth.
2529
2530         Add {ager,antonm,yurys}@chromium.org into committers.py
2531         https://bugs.webkit.org/show_bug.cgi?id=30560
2532
2533         * Scripts/modules/committers.py:
2534
2535 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2536
2537         Reviewed by Tor Arne Vestbø.
2538
2539         Make the Netscape Test plugin available to the Qt launcher.
2540
2541         * Scripts/run-launcher:
2542
2543 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2544
2545         Reviewed by David Levin.
2546
2547         Removed WebSocket runtime settings.
2548         https://bugs.webkit.org/show_bug.cgi?id=29896
2549
2550         WebSocket runtime configuration is supported by chromium/v8 only.
2551
2552         * DumpRenderTree/mac/DumpRenderTree.mm:
2553         (resetDefaultsToConsistentValues):
2554         * DumpRenderTree/win/DumpRenderTree.cpp:
2555         (resetDefaultsToConsistentValues):
2556
2557 2009-10-19  Nate Chapin  <japhet@chromium.org>
2558
2559         Reviewed by Adam Barth.
2560
2561         Add testFail() to test plugin so we can test our handling of a
2562         plugin invoke call returning false.
2563
2564         https://bugs.webkit.org/show_bug.cgi?id=30239
2565
2566         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2567         (pluginInvoke):
2568         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2569
2570 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2571
2572         Reviewed by Gustavo Noronha.
2573
2574         Enable DOM pasting when running layout tests.
2575
2576         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2577         (resetDefaultsToConsistentValues):
2578
2579 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2580
2581         Reviewed by Simon Hausmann.
2582
2583         Use the setPreferredContentsSize method instead
2584         of setFixedContentsSize, as the method has been renamed.
2585
2586         * DumpRenderTree/qt/DumpRenderTree.cpp:
2587         (WebCore::DumpRenderTree::open):
2588         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2589         (LayoutTestController::setFixedContentsSize):
2590
2591 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2592
2593         Reviewed by Dan Bernstein.
2594
2595         https://bugs.webkit.org/show_bug.cgi?id=30456
2596         Fixes for new Debug_All Windows build configuration.
2597
2598         * DumpRenderTree/win/DumpRenderTree.cpp:
2599         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2600         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2601
2602 2009-10-16  Eric Seidel  <eric@webkit.org>
2603
2604         Reviewed by Adam Barth.
2605
2606         commit-queue status bot should list which buildbot is blocking the queue
2607         https://bugs.webkit.org/show_bug.cgi?id=30452
2608
2609         Add new methods and testing.
2610
2611         * Scripts/bugzilla-tool:
2612         * Scripts/modules/buildbot.py:
2613         * Scripts/modules/buildbot_unittest.py:
2614
2615 2009-10-16  Eric Seidel  <eric@webkit.org>
2616
2617         Reviewed by Adam Barth.
2618
2619         run-webkit-tests fails when CWD is not inside a WebKit checkout
2620         https://bugs.webkit.org/show_bug.cgi?id=30451
2621
2622         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2623         * Scripts/modules/scm_unittest.py:
2624           - Remove use of original_path (we don't need to restore the CWD).
2625           - Don't use '.' to find the webkit checkout, use __file__ instead.
2626
2627 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2628
2629         Reviewed by Adam Roben.
2630
2631         Add a Debug_All configuration to build entire stack as debug.
2632         Change Debug_Internal to:
2633         - stop using _debug suffix for all WebKit/Safari binaries
2634         - not use _debug as a DLL naming suffix
2635         - use non-debug C runtime lib.
2636
2637         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2638         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2639         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2640         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2641         Add missing debug.vsprops inherited property sheet.
2642         Add Debug_All configuration.
2643         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2644         * WinLauncher/WinLauncher.vcproj:
2645         Removed extraneous definitions inherited from vsprops.
2646         Add Debug_All configuration.
2647
2648 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2649
2650         Reviewed by David Levin.
2651
2652         check-webkit-style is wrong about indent checking in namespaces
2653         in header files and a few other things
2654         https://bugs.webkit.org/show_bug.cgi?id=30362
2655
2656         The few other things include:
2657         + check-webkit-style does not require spaces around the equal sign
2658           inside 'if' statements and around binary operators that take 
2659           numeric literals.
2660         + check-webkit-style reports false errors for the / operator
2661           when part of a filename in the #include directive.
2662
2663         * Scripts/modules/cpp_style.py:
2664         Improved indentation checking and space checking around
2665         binary operators. While the checks are still not perfect,
2666         they are clearly better than before.
2667         * Scripts/modules/cpp_style_unittest.py:
2668         Added test cases for the newly supported checks and modified old
2669         test cases to match the new guidelines
2670
2671 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2672
2673         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2674
2675         * wx/build/settings.py:
2676
2677 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2678
2679         Reviewed by David Levin.
2680
2681         Add mod_pywebsocket to test Web Sockets.
2682         http://code.google.com/p/pywebsocket/
2683         https://bugs.webkit.org/show_bug.cgi?id=27490
2684
2685         * pywebsocket/COPYING: Added.
2686         * pywebsocket/MANIFEST.in: Added.
2687         * pywebsocket/README: Added.
2688         * pywebsocket/example/echo_client.py: Added.
2689         * pywebsocket/example/echo_wsh.py: Added.
2690         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2691         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2692         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2693         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2694         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2695         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2696         * pywebsocket/mod_pywebsocket/util.py: Added.
2697         * pywebsocket/setup.py: Added.
2698         * pywebsocket/test/config.py: Added.
2699         * pywebsocket/test/mock.py: Added.
2700         * pywebsocket/test/run_all.py: Added.
2701         * pywebsocket/test/test_dispatch.py: Added.
2702         * pywebsocket/test/test_handshake.py: Added.
2703         * pywebsocket/test/test_mock.py: Added.
2704         * pywebsocket/test/test_msgutil.py: Added.
2705         * pywebsocket/test/test_util.py: Added.
2706         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2707         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2708         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2709         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2710         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2711         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2712         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2713         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2714
2715 2009-10-15  James Robinson  <jamesr@google.com>
2716
2717         Reviewed by David Levin.
2718
2719         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2720
2721         https://bugs.webkit.org/show_bug.cgi?id=30426
2722
2723         * Scripts/modules/cpp_style.py:
2724         * Scripts/modules/cpp_style_unittest.py:
2725
2726 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2727
2728         Reviewed by Adam Roben.
2729
2730         Fixes <http://webkit.org/b/30411>.
2731         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2732         
2733         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2734         building Chromium.
2735
2736         * Scripts/pdevenv:
2737
2738 2009-10-15  Robin Dunn  <robin@alldunn.com>
2739
2740         Reviewed by Kevin Ollivier.
2741
2742         Add Mac package building scripts for wx.
2743         
2744         https://bugs.webkit.org/show_bug.cgi?id=30405
2745
2746         * wx/build/build_utils.py:
2747         * wx/build/settings.py:
2748         * wx/packaging/build-mac-installer.py: Added.
2749
2750 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2751
2752         Reviewed by Gustavo Noronha.
2753
2754         Enable Web Sockets support when running layout tests.
2755
2756         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2757         (resetDefaultsToConsistentValues):
2758
2759 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2760
2761         Reviewed by Gustavo Noronha.
2762
2763         Need to initialize event.button.button, since in most cases a
2764         button number is not passed as an argument.
2765
2766         * DumpRenderTree/gtk/EventSender.cpp:
2767         (mouseDownCallback):
2768         (mouseUpCallback):
2769
2770 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2771
2772         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2773         the OS if none was explicitly set.
2774
2775         * wx/build/settings.py:
2776
2777 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2778
2779         Reviewed by Timothy Hatcher.
2780
2781         Web Inspector: enable developers extras within inspector layout tests.
2782
2783         https://bugs.webkit.org/show_bug.cgi?id=30014
2784
2785         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2786         (LayoutTestController::showWebInspector):
2787         (LayoutTestController::closeWebInspector):
2788         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2789         (LayoutTestController::showWebInspector):
2790         (LayoutTestController::closeWebInspector):
2791
2792 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2793
2794         Reviewed by Jan Alonzo.
2795
2796         GtkLauncher is using a deprecated signal
2797         https://bugs.webkit.org/show_bug.cgi?id=30364
2798
2799         Modified GtkLauncher to use notify::title signal instead of
2800         deprecated title-changed signal
2801
2802         * GtkLauncher/main.c:
2803         (notify_title_cb):
2804         (create_browser):
2805
2806 2009-10-14  Brady Eidson  <beidson@apple.com>
2807
2808         Reviewed by Sam Weinig.
2809
2810         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2811         1 - Disables WebHistory
2812         2 - Doesn't make sense in that context anyway.
2813
2814         * DumpRenderTree/win/DumpRenderTree.cpp:
2815         (createWebViewAndOffscreenWindow):
2816
2817 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2818
2819         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2820         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2821
2822         * wx/build/settings.py:
2823         * wx/install-unix-extras:
2824
2825 2009-10-14  Brady Eidson  <beidson@apple.com>
2826
2827         Reviewed by Sam Weinig.
2828
2829         WebKit Win API should provide a delegate interface for global history.
2830         https://bugs.webkit.org/show_bug.cgi?id=29905
2831
2832         * DumpRenderTree/LayoutTestController.cpp:
2833         (LayoutTestController::LayoutTestController):
2834         * DumpRenderTree/LayoutTestController.h:
2835         (LayoutTestController::dumpHistoryDelegateCallbacks):
2836         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2837                 
2838         * DumpRenderTree/win/DumpRenderTree.cpp:
2839         (shouldLogHistoryDelegates):
2840         (runTest):
2841         (createWebViewAndOffscreenWindow):
2842         (main):
2843         * DumpRenderTree/win/DumpRenderTree.vcproj:
2844         
2845         Add the IWebHistoryDelegate to DRT Windows:
2846         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2847         (wstringFromBSTR):
2848         (HistoryDelegate::HistoryDelegate):
2849         (HistoryDelegate::~HistoryDelegate):
2850         (HistoryDelegate::QueryInterface):
2851         (HistoryDelegate::AddRef):
2852         (HistoryDelegate::Release):
2853         (HistoryDelegate::didNavigateWithNavigationData):
2854         (HistoryDelegate::didPerformClientRedirectFromURL):
2855         (HistoryDelegate::didPerformServerRedirectFromURL):
2856         (HistoryDelegate::updateHistoryTitle):
2857         (HistoryDelegate::populateVisitedLinksForWebView):
2858         * DumpRenderTree/win/HistoryDelegate.h: Added.
2859
2860         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2861         (LayoutTestController::removeAllVisitedLinks):
2862
2863 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2864
2865         Reviewed by Simon Hausmann.
2866
2867         [Qt] Implement support for setPOSIXLocale on Qt.
2868         https://bugs.webkit.org/show_bug.cgi?id=30268 
2869  
2870         * DumpRenderTree/qt/DumpRenderTree.cpp:
2871         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2872         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2873         (LayoutTestController::setPOSIXLocale):
2874         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2875
2876 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2877
2878         Unreviewed, adding myself to reviewers list.
2879
2880         * Scripts/modules/committers.py:
2881
2882 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2883
2884         Reviewed by Mark Rowe.
2885
2886         Fix null assignment so root tests work again.
2887
2888         * Scripts/webkitdirs.pm:
2889
2890 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2891
2892         Reviewed by Simon Hausmann.
2893
2894         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
2895         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
2896         This is done in preparation of implementing missing features in DRT.
2897         No functionality changes made yet.
2898
2899         * DumpRenderTree/qt/DumpRenderTree.cpp:
2900         * DumpRenderTree/qt/DumpRenderTree.pro:
2901         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
2902         (EventSender::EventSender):
2903         (EventSender::mouseDown):
2904         (EventSender::mouseUp):
2905         (EventSender::mouseMoveTo):
2906         (EventSender::leapForward):
2907         (EventSender::keyDown):
2908         (EventSender::contextClick):
2909         (EventSender::scheduleAsynchronousClick):
2910         (EventSender::frameUnderMouse):
2911         * DumpRenderTree/qt/EventSenderQt.h: Added.
2912         (EventSender::clearKillRing):
2913         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
2914         (LayoutTestController::LayoutTestController):
2915         (LayoutTestController::reset):
2916         (LayoutTestController::processWork):
2917         (LayoutTestController::maybeDump):
2918         (LayoutTestController::waitUntilDone):
2919         (LayoutTestController::notifyDone):
2920         (LayoutTestController::windowCount):
2921         (LayoutTestController::clearBackForwardList):
2922         (LayoutTestController::dumpEditingCallbacks):
2923         (LayoutTestController::dumpResourceLoadCallbacks):
2924         (LayoutTestController::queueBackNavigation):
2925         (LayoutTestController::queueForwardNavigation):
2926         (LayoutTestController::queueLoad):
2927         (LayoutTestController::queueReload):
2928         (LayoutTestController::queueScript):
2929         (LayoutTestController::provisionalLoad):
2930         (LayoutTestController::timerEvent):
2931         (LayoutTestController::encodeHostName):
2932         (LayoutTestController::decodeHostName):
2933         (LayoutTestController::setJavaScriptProfilingEnabled):
2934         (LayoutTestController::setFixedContentsSize):
2935         (LayoutTestController::setPrivateBrowsingEnabled):
2936         (LayoutTestController::setPopupBlockingEnabled):
2937         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2938         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2939         (LayoutTestController::numberOfActiveAnimations):
2940         (LayoutTestController::disableImageLoading):
2941         (LayoutTestController::dispatchPendingLoadRequests):
2942         (LayoutTestController::setDatabaseQuota):
2943         (LayoutTestController::clearAllDatabases):
2944         (LayoutTestController::whiteListAccessFromOrigin):
2945         (LayoutTestController::waitForPolicyDelegate):
2946         (LayoutTestController::overridePreference):
2947         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
2948         (LayoutTestController::isLoading):
2949         (LayoutTestController::setLoading):
2950         (LayoutTestController::shouldDumpAsText):
2951         (LayoutTestController::shouldDumpBackForwardList):
2952         (LayoutTestController::shouldDumpChildrenAsText):
2953         (LayoutTestController::shouldDumpDatabaseCallbacks):
2954         (LayoutTestController::shouldDumpStatusCallbacks):
2955         (LayoutTestController::shouldWaitUntilDone):
2956         (LayoutTestController::canOpenWindows):
2957         (LayoutTestController::shouldDumpTitleChanges):
2958         (LayoutTestController::waitForPolicy):
2959         (LayoutTestController::dumpAsText):
2960         (LayoutTestController::dumpChildFramesAsText):
2961         (LayoutTestController::dumpDatabaseCallbacks):
2962         (LayoutTestController::dumpStatusCallbacks):
2963         (LayoutTestController::setCanOpenWindows):
2964         (LayoutTestController::dumpBackForwardList):
2965         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2966         (LayoutTestController::display):
2967         (LayoutTestController::dumpTitleChanges):
2968         (LayoutTestController::dumpSelectionRect):
2969         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
2970         (TextInputController::TextInputController):
2971         (TextInputController::doCommand):
2972         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
2973         * DumpRenderTree/qt/WorkQueue.cpp:
2974         * DumpRenderTree/qt/WorkQueue.h:
2975         * DumpRenderTree/qt/WorkQueueItem.h:
2976         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
2977         (findFrameNamed):
2978         (LoadItem::invoke):
2979         (ReloadItem::invoke):
2980         (ScriptItem::invoke):
2981         (BackForwardItem::invoke):
2982         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
2983         * DumpRenderTree/qt/jsobjects.h:
2984
2985 2009-10-13  Dmitry Titov  <dimich@chromium.org>
2986
2987         Not reviewed, adding myself to the list of reviewers.
2988
2989         * Scripts/modules/committers.py:
2990
2991 2009-10-13  Anders Carlsson  <andersca@apple.com>
2992
2993         Reviewed by Sam Weinig.
2994
2995         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
2996
2997         Make the private browsing mode testable by the test plug-in.
2998         
2999         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3000         (pluginGetProperty):
3001         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3002         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3003         (NPP_New):
3004         (NPP_SetValue):
3005
3006 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3007
3008         No review, just adding self to the list of reviewers.
3009
3010         * Scripts/modules/committers.py:
3011
3012 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3013
3014         Reviewed by Adam Roben.
3015
3016         Web Inspector: Use proper web view in inspector layout
3017         tests for windows.
3018
3019         https://bugs.webkit.org/show_bug.cgi?id=30298
3020
3021         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3022         (LayoutTestController::showWebInspector):
3023         (LayoutTestController::closeWebInspector):
3024         (LayoutTestController::evaluateInWebInspector):
3025
3026 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3027
3028         Reviewed by Sam Weinig.
3029
3030         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3031         https://bugs.webkit.org/show_bug.cgi?id=29841
3032
3033         * DumpRenderTree/mac/DumpRenderTree.mm:
3034         (resetDefaultsToConsistentValues):
3035         * DumpRenderTree/win/DumpRenderTree.cpp:
3036         (resetDefaultsToConsistentValues):
3037
3038 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3039
3040         Reviewed by Dimitri Glazkov.
3041
3042         Chromium Port - Windows
3043         https://bugs.webkit.org/show_bug.cgi?id=29969
3044
3045         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3046         * Scripts/webkitdirs.pm:
3047
3048 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3049
3050         Reviewed by Darin Adler.
3051
3052         jsc scripts cleanup and Qt/GTK fix
3053         https://bugs.webkit.org/show_bug.cgi?id=30288
3054
3055         Duplicated jscPath() moved to webkitdirs.pm.
3056         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3057         Configuration added (release/debug) to path for Qt-port on Windows.
3058
3059         * Scripts/run-javascriptcore-tests:
3060         * Scripts/run-jsc:
3061         * Scripts/run-sunspider:
3062         * Scripts/sunspider-compare-results:
3063         * Scripts/webkitdirs.pm:
3064
3065 2009-10-11  Adam Barth  <abarth@webkit.org>
3066
3067         Unreviewed.  Add Collin to committers.py.
3068
3069         * Scripts/modules/committers.py:
3070
3071 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3072
3073         wx build fix, add bindings to source/include dirs now that there are sources there.
3074
3075         * wx/build/settings.py:
3076
3077 2009-10-09  Mark Rowe  <mrowe@apple.com>
3078
3079         Reviewed by Brady Eidson.
3080
3081         Enable plug-in halting in DumpRenderTree.
3082
3083         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3084         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3085
3086         * DumpRenderTree/mac/DumpRenderTree.mm:
3087         (resetDefaultsToConsistentValues):
3088         * DumpRenderTree/mac/UIDelegate.mm:
3089         (-[UIDelegate webView:shouldHaltPlugin:]):
3090
3091 2009-10-08  Brady Eidson  <beidson@apple.com>
3092
3093         Reviewed by Dan Bernstein.
3094
3095         Ask the History Delegate to populate the visited links hash.
3096         <rdar://problem/7285293> and https://webkit.org/b/29904
3097
3098         Add the ability for LayoutTestController to clear all visited links.
3099         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3100
3101         * DumpRenderTree/LayoutTestController.cpp:
3102         (LayoutTestController::LayoutTestController):
3103         (removeAllVisitedLinksCallback):
3104         (LayoutTestController::staticFunctions):
3105         * DumpRenderTree/LayoutTestController.h:
3106         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3107         (LayoutTestController::removeAllVisitedLinks):
3108
3109         * DumpRenderTree/mac/HistoryDelegate.mm:
3110         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3111
3112         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3113         (LayoutTestController::removeAllVisitedLinks):
3114         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3115         (LayoutTestController::removeAllVisitedLinks):
3116         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3117         (LayoutTestController::removeAllVisitedLinks):
3118
3119
3120 2009-10-08  Daniel Bates  <dbates@webkit.org>
3121
3122         Reviewed by Adam Roben.
3123
3124         https://bugs.webkit.org/show_bug.cgi?id=30175
3125         
3126         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3127         the OLE drag-and-drop return value like the function it emulates. Currently, 
3128         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3129         whether the drag-and-drop operation was successful or was cancelled.
3130         
3131         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3132         return value according to whether the drop operation was successful or not.
3133
3134         * DumpRenderTree/win/EventSender.cpp:
3135         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3136         (replaySavedEvents): Ditto.
3137         * DumpRenderTree/win/EventSender.h:
3138         * DumpRenderTree/win/UIDelegate.cpp:
3139         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3140
3141 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3142
3143         Reviewed by Xan Lopez.
3144
3145         [GTK] Added support for a parameter setting the button that was
3146         pressed in the mouseDown function.
3147         https://bugs.webkit.org/show_bug.cgi?id=30220
3148
3149         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3150
3151 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3152
3153         Reviewed by Xan Lopez.
3154
3155         [GTK] Added a line to the bottom of the expected result to match
3156         the output of the test.
3157         https://bugs.webkit.org/show_bug.cgi?id=30220
3158
3159         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3160         expected.txt:
3161
3162 2009-10-08  Adam Roben  <aroben@apple.com>
3163
3164         Use QueryInterface to get IWebInspectorPrivate
3165
3166         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3167         accessed in a more standard way
3168
3169         Reviewed by John Sullivan and Tim Hatcher.
3170
3171         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3172         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3173         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3174         to the IWebInspectorPrivate interface.
3175
3176 2009-10-07  Adam Roben  <aroben@apple.com>
3177
3178         Implement DRT support for origin whitelisting
3179
3180         Fixes <http://webkit.org/b/30185>.
3181
3182         Reviewed by Eric Seidel.
3183
3184         * DumpRenderTree/win/DumpRenderTree.cpp:
3185         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3186         whitelist, to match Mac DRT.
3187         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3188         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3189         IWebViewPrivate::whiteListAccessFromOrigin.
3190
3191 2009-10-07  Brady Eidson  <beidson@apple.com>
3192
3193         Reviewed by Darin Adler.
3194
3195         Send title changes to the global history delegate.
3196         <rdar://problem/7285293> and https://webkit.org/b/29904
3197
3198         * DumpRenderTree/mac/HistoryDelegate.mm:
3199         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3200
3201 2009-10-07  Adam Barth  <abarth@webkit.org>
3202
3203         Unreviewed.  Remove some folks from committers.py who were listed on
3204         the WebKit Team wiki page but who weren't actually listed as commit+.
3205         At some point, we should coorelate this list with the committers
3206         mailing list.
3207
3208         * Scripts/modules/committers.py:
3209
3210 2009-10-07  Adam Barth  <abarth@webkit.org>
3211
3212         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3213         the wiki into committers.py.
3214
3215         * Scripts/modules/committers.py:
3216
3217 2009-10-07  Adam Barth  <abarth@webkit.org>
3218
3219         Unreviewed.  Added Aaron Boodman to committers.py.
3220
3221         * Scripts/modules/committers.py:
3222
3223 2009-10-07  Evan Martin  <evan@chromium.org>
3224
3225         Reviewed by Darin Adler.
3226
3227         Add API to LayoutTestController for re/setting the system locale.
3228         https://bugs.webkit.org/show_bug.cgi?id=18994
3229
3230         * DumpRenderTree/LayoutTestController.cpp:
3231         (setLocaleCallback):
3232         (LayoutTestController::staticFunctions):
3233         (LayoutTestController::setLocale):
3234         * DumpRenderTree/LayoutTestController.h:
3235
3236 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3237
3238         Reviewed by Jan Alonzo.
3239
3240         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3241         https://bugs.webkit.org/show_bug.cgi?id=29689
3242
3243         Build fix by adding -lfontconfig for DumpRenderTree.
3244
3245         * GNUmakefile.am:
3246
3247 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3248
3249         Reviewed by Simon Hausmann.
3250
3251         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3252
3253         * Scripts/run-webkit-tests:
3254
3255 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3256
3257         Reviewed by Gustavo Noronha.
3258
3259         "delete" in EventSender is the backspace key, not the delete one.
3260
3261         * DumpRenderTree/gtk/EventSender.cpp:
3262         (keyDownCallback):
3263
3264 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3265
3266         Reviewed by Gustavo Noronha.
3267
3268         getChildrenWithRange expects as last parameter the end index, not
3269         the length of the range. Correct this and clarify the variable
3270         names to reflect how the code works.
3271
3272         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3273         (AccessibilityUIElement::getChildrenWithRange):
3274         (AccessibilityUIElement::getChildAtIndex):
3275
3276 2009-10-06  Mark Rowe  <mrowe@apple.com>
3277
3278         Reviewed by Simon Fraser.
3279
3280         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3281
3282         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3283         the fact we have already changed the working directory to the top of the open source tree.
3284
3285 2009-10-06  Julie Parent  <jparent@chromium.org>
3286
3287         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3288         rather than my committer email.
3289
3290         * Scripts/modules/committers.py:
3291
3292 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3293
3294         Reviewed by Eric Seidel.
3295
3296         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3297
3298         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3299         it after each layout test as it should do, making the DRT dump additional output
3300         for all of the subsequent layout tests.
3301
3302         * DumpRenderTree/qt/jsobjects.cpp:
3303         (LayoutTestController::reset):
3304
3305 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3306
3307         Reviewed by Simon Hausmann.
3308
3309         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3310         fast/dom/assign-to-window-status.html test, which is passing as a result.
3311
3312         https://bugs.webkit.org/show_bug.cgi?id=30127
3313
3314         * DumpRenderTree/qt/DumpRenderTree.cpp:
3315         (WebCore::DumpRenderTree::DumpRenderTree):
3316         (WebCore::DumpRenderTree::statusBarMessage):
3317         * DumpRenderTree/qt/DumpRenderTree.h:
3318         * DumpRenderTree/qt/jsobjects.h:
3319         (LayoutTestController::shouldDumpStatusCallbacks):
3320         (LayoutTestController::dumpStatusCallbacks):
3321
3322 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3323
3324         Reviewed by Simon Hausmann.
3325
3326         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3327         ignores the argument indicating which mouse button to trigger.
3328         https://bugs.webkit.org/show_bug.cgi?id=30048
3329
3330         This affects the fast/events/mouse-click-events.html layout test.
3331
3332         * DumpRenderTree/qt/jsobjects.cpp:
3333         (EventSender::mouseDown):
3334         (EventSender::mouseUp):
3335         * DumpRenderTree/qt/jsobjects.h:
3336
3337 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3338
3339         Reviewed by Simon Hausmann.
3340
3341         [Qt] Fix the EventSender::keyDown() implementation
3342         https://bugs.webkit.org/show_bug.cgi?id=30043
3343
3344         It should post both a key press event and a key release event,
3345         just like other ports do.
3346
3347         * DumpRenderTree/qt/jsobjects.cpp:
3348         (EventSender::keyDown):
3349
3350 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3351
3352         wx build fix. Add jpeg to the list of libs to link against.
3353
3354         * wx/build/settings.py:
3355
3356 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3357
3358         Reviewed by Simon Hausmann.
3359
3360         [Qt] EventSender::keyDown() cannot send function-key events.
3361         https://bugs.webkit.org/show_bug.cgi?id=30044
3362
3363         This affects the fast/events/keydown-function-keys.html layout test.
3364
3365         * DumpRenderTree/qt/jsobjects.cpp:
3366         (EventSender::keyDown):
3367
3368 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3369
3370         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3371         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3372
3373         * wx/build/settings.py:
3374         * wx/build/wxpresets.py:
3375
3376 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3377
3378         Reviewed by Timothy Hatcher.
3379
3380         Web Inspector: add testing harness for Web Inspector.
3381
3382         https://bugs.webkit.org/show_bug.cgi?id=30010
3383
3384         * DumpRenderTree/LayoutTestController.cpp:
3385         (showWebInspectorCallback):
3386         (closeWebInspectorCallback):
3387         (evaluateInWebInspectorCallback):
3388         (LayoutTestController::staticFunctions):
3389         * DumpRenderTree/LayoutTestController.h:
3390         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3391         (LayoutTestController::showWebInspector):
3392         (LayoutTestController::closeWebInspector):
3393         (LayoutTestController::evaluateInWebInspector):
3394         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3395         (LayoutTestController::showWebInspector):
3396         (LayoutTestController::closeWebInspector):
3397         (LayoutTestController::evaluateInWebInspector):
3398         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3399         (LayoutTestController::showWebInspector):
3400         (LayoutTestController::closeWebInspector):
3401         (LayoutTestController::evaluateInWebInspector):
3402         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3403         (LayoutTestController::showWebInspector):
3404         (LayoutTestController::closeWebInspector):
3405         (LayoutTestController::evaluateInWebInspector):
3406
3407 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3408
3409         Reviewed by Ariyha Hidayat.
3410
3411         Pass arguments to system() as a string instead of array
3412
3413         When passed as an array entries with a space fail to translate
3414         to two arguments to the child process, so instead of manually
3415         splitting all the entries in @buildArgs we pass the whole thing
3416         as a string instead.
3417
3418         * Scripts/webkitdirs.pm:
3419
3420 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3421
3422         Reviewed by David Levin.
3423
3424         check-webkit-style misses whitespace errors for operators:
3425         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3426         https://bugs.webkit.org/show_bug.cgi?id=30021
3427
3428         * Scripts/modules/cpp_style.py:
3429         Added the operators mentioned above to the same list as == and !=.
3430
3431 2009-10-02  Julie Parent  <jparent@chromium.org>
3432
3433         Unreviewed.
3434
3435         Adding myself and Ojan Vafai as committers, because we are committers.
3436
3437         * Scripts/modules/committers.py:
3438
3439 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3440
3441         Reviewed by Adam Roben.
3442
3443         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3444         this will help the patch merging process when TryBots are used.
3445
3446         * Scripts/svn-create-patch:
3447
3448 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3449
3450         Reviewed by Simon Hausmann.
3451
3452         [Qt] Implement layoutTestController.overridePreference().
3453         https://bugs.webkit.org/show_bug.cgi?id=29970
3454
3455         * DumpRenderTree/qt/DumpRenderTree.cpp:
3456         (WebCore::WebPage::WebPage):
3457         (WebCore::WebPage::resetSettings):
3458         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3459         * DumpRenderTree/qt/jsobjects.cpp:
3460         (LayoutTestController::reset):
3461         (LayoutTestController::setPrivateBrowsingEnabled):
3462         (LayoutTestController::setPopupBlockingEnabled):
3463         (LayoutTestController::overridePreference):
3464         * DumpRenderTree/qt/jsobjects.h:
3465
3466 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3467
3468         Reviewed by Oliver Hunt.
3469
3470         Turn on ENABLE_3D_CANVAS in TOT
3471         https://bugs.webkit.org/show_bug.cgi?id=29906
3472
3473         * Scripts/build-webkit:
3474
3475 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3476
3477         Rubberstamped by Simon Hausmann.
3478
3479         Enable HTTP tests for Qt
3480
3481         * Scripts/run-webkit-tests:
3482
3483 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3484
3485         Reviewed by Dimitri Glazkov.
3486
3487         build-webkit --chromium now also works on cygwin.
3488
3489         https://bugs.webkit.org/show_bug.cgi?id=29973
3490
3491         * Scripts/webkitdirs.pm:
3492
3493 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3494
3495         Reviewed by Simon Hausmann.
3496
3497         [Qt] Don't use TCmalloc in DumpRenderTree
3498         https://bugs.webkit.org/show_bug.cgi?id=27029
3499
3500         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3501
3502         * DumpRenderTree/qt/DumpRenderTree.pro:
3503
3504 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3505
3506         Reviewed by Simon Hausmann.
3507
3508         [Qt] Implement eventSender.scheduleAsynchronousClick().
3509
3510         https://bugs.webkit.org/show_bug.cgi?id=29931
3511
3512         * DumpRenderTree/qt/jsobjects.cpp:
3513         (EventSender::scheduleAsynchronousClick):
3514         * DumpRenderTree/qt/jsobjects.h:
3515
3516 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3517
3518         Reviewed by Simon Hausmann.
3519
3520         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3521         fast/events/open-window-from-another-frame.html from the Skipped list.
3522
3523         https://bugs.webkit.org/show_bug.cgi?id=29930
3524
3525         * DumpRenderTree/qt/jsobjects.cpp:
3526         (LayoutTestController::setPopupBlockingEnabled):
3527         * DumpRenderTree/qt/jsobjects.h:
3528
3529 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3530
3531         Unreviewed.
3532
3533         Added myself to the list of committers.
3534
3535         * Scripts/modules/committers.py:
3536
3537 2009-09-30  Eric Seidel  <eric@webkit.org>
3538
3539         No review, just adding Geoff to the list of reviewers.
3540
3541         * Scripts/modules/committers.py:
3542
3543 2009-09-30  Dan Bernstein  <mitz@apple.com>
3544
3545         Reviewed by Sam Weinig.
3546
3547         Added the WebKit Layout Tests fonts that are referenced in
3548         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3549
3550         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3551         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3552
3553 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3554
3555         Reviewed by David Kilzer.
3556
3557         Make sunspider scripts work on Windows platform.
3558         https://bugs.webkit.org/show_bug.cgi?id=29656
3559
3560         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3561         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3562         * Scripts/webkitdirs.pm: currentPerlPath() added.
3563
3564 2009-09-29  Brady Eidson  <beidson@apple.com>
3565
3566         Rubberstamped by Dan Bernstein.
3567
3568         Fix license and some sorting in new files.
3569
3570         * DumpRenderTree/mac/HistoryDelegate.h:
3571         * DumpRenderTree/mac/HistoryDelegate.mm:
3572
3573 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3574
3575         Reviewed by David Kilzer.
3576
3577         Fixed how error codes are handled.
3578         https://bugs.webkit.org/show_bug.cgi?id=29898
3579
3580         * Scripts/update-webkit:
3581         * Scripts/update-webkit-chromium:
3582
3583 2009-09-29  Brady Eidson  <beidson@apple.com>
3584
3585         Reviewed by John Sullivan.
3586
3587         Updated way-out-of-date sorting throughout the dump methods/flags.
3588
3589         * DumpRenderTree/LayoutTestController.cpp:
3590         (LayoutTestController::LayoutTestController):
3591         (dumpAsPDFCallback):
3592         (dumpAsTextCallback):
3593         (dumpFrameLoadCallbacksCallback):
3594         (dumpResourceLoadCallbacksCallback):
3595         (LayoutTestController::staticFunctions):
3596
3597         * DumpRenderTree/LayoutTestController.h:
3598         (LayoutTestController::dumpAsText):
3599         (LayoutTestController::setDumpAsText):
3600         (LayoutTestController::dumpFrameLoadCallbacks):
3601         (LayoutTestController::setDumpFrameLoadCallbacks):
3602         (LayoutTestController::dumpSelectionRect):
3603         (LayoutTestController::setDumpSelectionRect):
3604         (LayoutTestController::dumpSourceAsWebArchive):
3605         (LayoutTestController::setDumpSourceAsWebArchive):
3606         (LayoutTestController::dumpStatusCallbacks):
3607         (LayoutTestController::setDumpStatusCallbacks):
3608         (LayoutTestController::dumpTitleChanges):
3609         (LayoutTestController::setDumpTitleChanges):
3610         (LayoutTestController::dumpWillCacheResponse):
3611         (LayoutTestController::setDumpWillCacheResponse):
3612
3613 2009-09-29  Brady Eidson  <beidson@apple.com>
3614
3615         Reviewed by John Sullivan.
3616
3617         WebKit Mac API should provide a delegate interface for global history.
3618         <rdar://problem/7042773> and https://webkit.org/b/29904
3619
3620         Adding the dumping of global history delegate callbacks.
3621
3622         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3623
3624         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3625         * DumpRenderTree/mac/DumpRenderTree.mm:
3626         (createWebViewAndOffscreenWindow):
3627         (allocateGlobalControllers):
3628         (shouldLogFrameLoadDelegates):
3629         (shouldLogHistoryDelegates):
3630         (runTest):
3631
3632         Dump history delegate callbacks:
3633         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3634         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3635         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3636         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3637         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3638
3639 2009-09-29  Daniel Bates  <dbates@webkit.org>
3640
3641         Reviewed by Adam Roben.
3642
3643         https://bugs.webkit.org/show_bug.cgi?id=28902
3644         
3645         Fixes an issue where the drop effect returned by Window Dump Render Tree 
3646         was always DROPEFFECT_NONE (since it was hard coded to do so).
3647         
3648         This patch corrects this issue by determining the actual drop effect 
3649         performed by the corresponding drag-and-drop operation so that we can 
3650         return it.
3651
3652         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3653         (DraggingInfo::DraggingInfo):
3654         (DraggingInfo::performedDropEffect): Added method.
3655         (DraggingInfo::setPerformedDropEffect): Added method.
3656         * DumpRenderTree/win/EventSender.cpp:
3657         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3658         Moved delete draggingInfo to UIDelegate::doDragDrop.
3659         * DumpRenderTree/win/UIDelegate.cpp:
3660         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3661
3662 2009-09-29  Dan Bernstein  <mitz@apple.com>
3663
3664         Reviewed by Adam Roben.
3665
3666         Remove copying of unnecessary or nonexistent files from the ImageDiff
3667         post-build event.
3668
3669         * DumpRenderTree/win/ImageDiff.vcproj:
3670
3671 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3672
3673         Reviewed by David Kilzer.
3674
3675         [Qt] Make build-webkit script work on Windows
3676         https://bugs.webkit.org/show_bug.cgi?id=29802
3677
3678         * Scripts/run-webkit-tests:
3679         * Scripts/webkitdirs.pm:
3680          - Removed unnecessary -p switch for mkdir on Windows.
3681          - Use canonical path, which uses slashes or backslashes depends on platform.
3682          - isWindows() only test for Windows and not for Cyqwin.
3683
3684 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3685
3686         Reviewed by Simon Hausmann.
3687
3688         Fix time measurement in build-webkit after refactoring done in r48853.
3689
3690         * Scripts/build-webkit:
3691
3692 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3693
3694         Reviewed by Tor Arne Vestbø.
3695
3696         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
3697         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
3698
3699         * DumpRenderTree/qt/DumpRenderTree.cpp:
3700         (WebCore::WebPage::WebPage):
3701
3702 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
3703
3704         Reviewed by Simon Hausmann.
3705
3706         [Qt] Implement eventSender.contextClick().
3707         https://bugs.webkit.org/show_bug.cgi?id=29821
3708
3709         * DumpRenderTree/qt/jsobjects.cpp:
3710         (EventSender::contextClick):
3711         * DumpRenderTree/qt/jsobjects.h:
3712
3713 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3714
3715         Reviewed by Eric Seidel.
3716
3717         Add experimentalWebSocketsEnabled in WebPreferences.
3718         https://bugs.webkit.org/show_bug.cgi?id=28941
3719
3720         * DumpRenderTree/mac/DumpRenderTree.mm:
3721         (resetDefaultsToConsistentValues):
3722         * DumpRenderTree/win/DumpRenderTree.cpp:
3723         (resetDefaultsToConsistentValues):
3724
3725 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
3726
3727         Reviewed by David Kilzer.
3728
3729         Integrated chromium port building into webkit tools update-webkit and
3730         build-webkit.
3731
3732         https://bugs.webkit.org/show_bug.cgi?id=29749
3733
3734         * Scripts/build-webkit: When --chromium is specified, will build
3735           the chromium port (currently only Mac is supported).
3736         * Scripts/update-webkit: When --chromium is specified, delegates to
3737           update-webkit-chromium.
3738         * Scripts/webkitdirs.pm: Added chromium specific defs.
3739         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
3740           chromium port's dependencies and update its project files.
3741
3742 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3743
3744         Unreviewed.
3745
3746         Add myself to list of committers.
3747
3748         * Scripts/modules/committers.py:
3749
3750 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3751
3752         Reviewed by Darin Adler.
3753
3754         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
3755         https://bugs.webkit.org/show_bug.cgi?id=29771
3756
3757         * Scripts/run-webkit-tests:
3758
3759 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3760
3761         Reviewed by Simon Hausmann.
3762
3763         [Qt] Implement layoutTestController.waitForPolicyDelegate.
3764         https://bugs.webkit.org/show_bug.cgi?id=25037
3765
3766         * DumpRenderTree/qt/DumpRenderTree.cpp:
3767         (WebCore::WebPage::acceptNavigationRequest):
3768         * DumpRenderTree/qt/DumpRenderTree.pro:
3769         * DumpRenderTree/qt/jsobjects.cpp:
3770         (LayoutTestController::reset):
3771         (LayoutTestController::notifyDone):
3772         (LayoutTestController::waitForPolicyDelegate):
3773         * DumpRenderTree/qt/jsobjects.h:
3774         (LayoutTestController::waitForPolicy):
3775
3776 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3777
3778         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
3779
3780         Reviewed by Eric Seidel.
3781
3782         The -o|--open switch uses the open(1) command on Mac OS X to
3783         open the bug URL in the default web browser.  If there are
3784         similar mechanisms on other platforms, they may be added later.
3785
3786         * Scripts/mark-bug-fixed:
3787         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
3788         options.
3789         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
3790         code into main() and extracted prompting code into
3791         _prompt_user_for_correctness().
3792         (MarkBugFixed._open_bug_in_web_browser): Added.
3793         (MarkBugFixed._prompt_user_for_correctness): Added.
3794         (MarkBugFixed.main): Added logging code from
3795         _determine_bug_id_and_svn_revision().  Added code to call
3796         _open_bug_in_web_browser() if the switch is set.  Added code to
3797         call _prompt_user_for_correctness() when needed.
3798         * Scripts/modules/bugzilla.py:
3799         (Bugzilla.short_bug_url_for_bug_id): Added.
3800
3801 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3802
3803         svn-unapply and svn-apply don't work when used outside multiple svn working directories
3804
3805         <http://webkit.org/b/29744>
3806         <rdar://problem/7252905>
3807
3808         Reviewed by Eric Seidel.
3809
3810         Some users have a workflow where svn-create-patch, svn-apply and
3811         svn-unapply are used outside of multiple svn working
3812         directories.  Instead of aborting the scripts in these cases,
3813         print a warning and assume that Subversion is being used.
3814
3815         * Scripts/VCSUtils.pm:
3816         (determineVCSRoot): Call warn() instead of die() if both isGit()
3817         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
3818         to enforce the assumption about Subversion, then return
3819         determineSVNRoot().
3820         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
3821         VCSUtils.pm.  They both already cache their values and checking
3822         here is redundant since determineVCSRoot() is called later.
3823
3824 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
3825
3826         Reviewed by Gustavo Noronha.
3827
3828         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3829         https://bugs.webkit.org/show_bug.cgi?id=29689
3830
3831         Load test fonts through FontConfig before each test.
3832         This ensures a more proper rendering of the tests.
3833
3834         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3835         (initializeFonts):
3836         (runTest):
3837         (main):
3838         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
3839         * GNUmakefile.am:
3840
3841 2009-09-25  David Kilzer  <ddkilzer@apple.com>
3842
3843         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
3844
3845         Reviewed by Eric Seidel.
3846
3847         * Scripts/mark-bug-fixed:
3848         (MarkBugFixed.__init__): Added -u|--update-only switch to list
3849         of parse options.
3850         (MarkBugFixed.main): When -u|--update-only is specified, add a
3851         comment to the bug without marking it Resolved/Fixed.
3852
3853 2009-09-25  Darin Adler  <darin@apple.com>
3854
3855         Reviewed by Geoffrey Garen.
3856
3857         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
3858         out, just as we do for the resources directory.
3859
3860 2009-09-25  Adam Barth  <abarth@webkit.org>
3861
3862         Unreviewed.  Added Tony to committers.py because he's a
3863         committer now.
3864
3865         * Scripts/modules/committers.py:
3866
3867 2009-09-25  Eric Seidel  <eric@webkit.org>
3868
3869         Reviewed by Simon Fraser.
3870
3871         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
3872         https://bugs.webkit.org/show_bug.cgi?id=28624
3873
3874         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
3875
3876         * DumpRenderTree/mac/DumpRenderTree.mm:
3877         (resetDefaultsToConsistentValues):
3878
3879 2009-09-25  Eric Seidel  <eric@webkit.org>
3880
3881         Reviewed by Adam Barth.
3882
3883         commit-queue should auto-retry patches which fail to commit due to out of date files
3884         https://bugs.webkit.org/show_bug.cgi?id=28316
3885
3886         * Scripts/bugzilla-tool:
3887          - Handle new CheckoutNeedsUpdate exception.
3888         * Scripts/modules/logging_unittest.py:
3889          - Call the ScriptError constructor correctly (this test had regressed).
3890         * Scripts/modules/scm.py:
3891          - Added the ability to define custom error handlers for run_command
3892            and added a commit_error_handler which throws CheckoutNeedsUpdate
3893            instead of ScriptError.
3894          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
3895         * Scripts/modules/scm_unittest.py:
3896          - Added tests of new error handlers.
3897
3898 2009-09-25  Eric Seidel  <eric@webkit.org>
3899
3900         Reviewed by Adam Barth.
3901
3902         commit-queue should give better feedback when failing a patch
3903         https://bugs.webkit.org/show_bug.cgi?id=29316
3904
3905         * Scripts/bugzilla-tool:
3906          - Update ScriptError uses to the new constructor format.
3907          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
3908            so that we can print to both stdout as well as an output buffer for error reporting.
3909          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
3910          - Use e.message_with_output() when failing a patch (this is the real fix here).
3911            I also removed use of "This patch will require manual commit." as that's not always true.
3912          - Add missing word "bug" from log message.
3913         * Scripts/modules/scm.py:
3914          - Make ScriptError save a bunch more data so that error messages can be nicer.
3915          - Update ScriptError callers.
3916
3917 2009-09-24  John Gregg  <johnnyg@google.com>
3918
3919         Reviewed by Eric Seidel.
3920
3921         Enable switch for notifications (experimental) in Page Settings
3922         https://bugs.webkit.org/show_bug.cgi?id=28930
3923
3924         Now that desktop notifications are controlled by run-time switch,
3925         set that switch to true for DumpRenderTree.
3926
3927         * DumpRenderTree/mac/DumpRenderTree.mm:
3928         (resetDefaultsToConsistentValues):
3929         * DumpRenderTree/win/DumpRenderTree.cpp:
3930         (resetDefaultsToConsistentValues):
3931         * DumpRenderTree/win/UIDelegate.cpp:
3932         (UIDelegate::QueryInterface):
3933
3934 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
3935
3936         wx build fix. SnowLeopard fixes for Mac dependencies.
3937
3938         * wx/build/build_utils.py:
3939         * wx/build/settings.py:
3940         * wx/install-unix-extras:
3941
3942 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3943
3944         Reviewed by Oliver Hunt.
3945
3946         Add support for DRT to send mouse wheel events.
3947
3948         https://bugs.webkit.org/show_bug.cgi?id=29348
3949         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
3950
3951         * DumpRenderTree/gtk/EventSender.cpp:
3952         (mouseWheelToCallback):
3953
3954 2009-09-17  Eric Seidel  <eric@webkit.org>
3955
3956         Reviewed by David Levin.
3957
3958         commit-queue needs web-based status reporting
3959         https://bugs.webkit.org/show_bug.cgi?id=29307
3960
3961         Add a first-pass web-based status for the commit-queue.
3962         The bot is currently reachable at:
3963         http://webkit-commit-queue.appspot.com/
3964
3965         * CommitQueueStatus/app.yaml: Added.
3966          - Application description file required by App Engine.
3967         * CommitQueueStatus/filters/__init__.py: Added.
3968          - Required by python to treat 'filters' as a module.
3969         * CommitQueueStatus/filters/webkit_extras.py: Added.
3970          - Support for turning 'bug 123' and 'patch 123' into links.
3971            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
3972         * CommitQueueStatus/index.html: Added.
3973         * CommitQueueStatus/index.yaml: Added.
3974          - Some auto-generated file from app engine.
3975         * CommitQueueStatus/queue_status.py: Added.
3976          - The core logic of this bot.  We could eventually split this file out into pieces.
3977         * CommitQueueStatus/stylesheets/main.css: Added.
3978          - Some basic lame-o CSS to make the page look less awful.
3979         * CommitQueueStatus/update_status.html: Added.
3980          - The form that the commit-queue (or a human) can use to update the status.
3981         * Scripts/bugzilla-tool:
3982          - Add some very basic update_status calls.
3983         * Scripts/modules/statusbot.py: Added.
3984          - Knows how to post to the CommitQueueStatus web application.
3985
3986 2009-09-24  David Kilzer  <ddkilzer@apple.com>
3987
3988         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
3989
3990         Reviewed by Adam Roben.
3991
3992         * Scripts/mark-bug-fixed:
3993         (MarkBugFixed.__init__): Added -m|--comment switch to list of
3994         parse options.
3995         (MarkBugFixed.main): When specified, prepend comment from
3996         -m|--comment command-line switch to the bug comment.
3997
3998 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3999
4000         Reviewed by Jan Alonzo.
4001
4002         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
4003         https://bugs.webkit.org/show_bug.cgi?id=29693
4004
4005         Show the window, to be able to synthesize events correctly.
4006
4007         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4008         (runTest):
4009         (main):
4010
4011 2009-09-24  Oliver Hunt  <oliver@apple.com>
4012
4013         Reviewed by NOBODY(rollout)
4014
4015         Roll out r48712 as it is incorrect.
4016
4017         * DumpRenderTree/mac/ObjCController.m:
4018         (+[ObjCController isSelectorExcludedFromWebScript:]):
4019         (+[ObjCController webScriptNameForSelector:]):
4020
4021 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
4022
4023         Reviewed by Eric Seidel.
4024
4025         https://bugs.webkit.org/show_bug.cgi?id=29005
4026         The indices of RuntimeArray should be enumerated like for a regular array.
4027
4028         * DumpRenderTree/mac/ObjCController.m:
4029         (+[ObjCController isSelectorExcludedFromWebScript:]):
4030         (+[ObjCController webScriptNameForSelector:]):
4031         (-[ObjCController arrayOfString]):
4032
4033 2009-09-23  David Kilzer  <ddkilzer@apple.com>
4034
4035         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
4036
4037         Reviewed by Darin Adler.
4038
4039         Also fixed a bug where specifying a revision on the command-line
4040         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
4041
4042         * Scripts/bugzilla-tool: Updated module import statements.
4043         (parse_bug_id): Removed.  Moved to bugzilla.py.
4044         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
4045         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
4046         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
4047         (BugzillaTool.__init__): Removed mark-fixed subcommand.
4048         * Scripts/mark-bug-fixed: Added.
4049         * Scripts/modules/bugzilla.py:
4050         (parse_bug_id): Added.  Moved from bugzilla-tool.
4051         * Scripts/modules/comments.py: Added.
4052         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
4053         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
4054
4055 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
4056
4057         Reviewed by Eric Seidel.
4058         
4059          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
4060          "false" in non-implemented stub for setAlwaysAcceptCookies.
4061          https://bugs.webkit.org/show_bug.cgi?id=29661
4062
4063         * DumpRenderTree/win/DumpRenderTree.vcproj:
4064         * DumpRenderTree/win/DumpRenderTree.cpp:
4065
4066 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4067
4068         Reviewed by Xan Lopez.
4069
4070         [GTK] need to dump number of pending unload handlers
4071         https://bugs.webkit.org/show_bug.cgi?id=29685
4072
4073         Implement dumping of the number of pending unload handlers.
4074
4075         The following tests will pass:
4076
4077           fast/loader/unload-form-about-blank.html
4078           fast/loader/unload-form-post-about-blank.html
4079           fast/loader/unload-form-post.html
4080           fast/loader/unload-form.html
4081           fast/loader/unload-hyperlink.html
4082           fast/loader/unload-javascript-url.html
4083           fast/loader/unload-reload.html
4084           fast/loader/unload-window-location.html
4085
4086         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4087         (getFrameNameSuitableForTestResult):
4088         (webViewLoadFinished):
4089
4090 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
4091
4092         Reviewed by Eric Seidel.
4093
4094         js tests should move into jstests subdirectory instead of resources/
4095         https://bugs.webkit.org/show_bug.cgi?id=25880
4096
4097         Remove support of resources directory.
4098
4099         * Scripts/make-script-test-wrappers:
4100
4101 2009-09-22  Eric Seidel  <eric@webkit.org>
4102
4103         No review, only fixing typo (missing space character).
4104
4105         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
4106
4107         * Scripts/run-webkit-tests:
4108
4109 2009-09-22  Eric Seidel  <eric@webkit.org>
4110
4111         Reviewed by Darin Adler.
4112
4113         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
4114         https://bugs.webkit.org/show_bug.cgi?id=29220
4115
4116         * Scripts/run-webkit-tests:
4117
4118 2009-09-22  Eric Seidel  <eric@webkit.org>
4119
4120         Reviewed by David Kilzer.
4121
4122         svn-apply can't handle single-line binary file additions
4123         https://bugs.webkit.org/show_bug.cgi?id=29100
4124
4125         Fixed the regexp and added a unit test.
4126
4127         * Scripts/modules/scm_unittest.py:
4128         * Scripts/svn-apply:
4129
4130 2009-09-11  Eric Seidel  <eric@webkit.org>
4131
4132         Reviewed by David Kilzer.
4133
4134         post-diff and post-commits should be able to find bug urls in ChangeLogs.
4135         https://bugs.webkit.org/show_bug.cgi?id=29206
4136
4137         * Scripts/bugzilla-tool:
4138          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
4139          - Rename --no-comment to --add-log-as-comment and reverse behavior.
4140            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
4141          - Split out code into helper functions to try and make execute() more legible.
4142          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
4143          - Fallback to bug urls in commit diffs, instead of just in commit messages,
4144            meaning post-commits will now find bug urls in ChangeLogs.
4145
4146 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
4147
4148         Reviewed by Maciej Stachowiak.
4149
4150         --parse-only parameter wasn't passed to SunSpider/sunspider script.
4151         https://bugs.webkit.org/show_bug.cgi?id=29611
4152
4153         * Scripts/run-sunspider: Missing parameter passing added.
4154
4155 2009-09-20  David Kilzer  <ddkilzer@apple.com>
4156
4157         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
4158
4159         Reviewed by Mark Rowe.
4160
4161         The require statement is like the use statement, except that it
4162         is run during script execution instead of during the 'BEGIN'
4163         phase.  This makes it possible to change @INC before the require
4164         statement is run.  See 'require' and 'use' in the perlfunc(1)
4165         manpage and 'BEGIN' in perlmod(1) manpage.
4166
4167         * Scripts/run-webkit-tests: Replace eval statement with require
4168         statement.
4169
4170 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
4171
4172         wx build fixes. Fix the config name under git and allow users to specify
4173         their own waf install for experimenting with new versions.
4174
4175         * Scripts/webkitdirs.pm:
4176         * wx/build/settings.py:
4177
4178 2009-09-18  Alex Milowski  <alex@milowski.com>
4179
4180         Reviewed by Maciej Stachowiak.
4181
4182         Added checkWebCoreMathMLSupport and hasMathMLSupport to support 
4183         checking for whether MathML tests should be run
4184
4185         * Scripts/run-webkit-tests:
4186         * Scripts/webkitdirs.pm:
4187
4188 2009-08-28  Darin Adler  <darin@apple.com>
4189
4190         Reviewed by Mark Rowe.
4191
4192         Break more of run-webkit-tests into separate functions
4193         https://bugs.webkit.org/show_bug.cgi?id=29497
4194
4195         Some small steps toward improving run-webkit-tests. My goal is to
4196         refactor much more of the script into functions. Later we can add
4197         parallel test running to the tool. But better structure may help
4198         even if someone decides to translate this into another scripting
4199         language instead.
4200
4201         * Scripts/run-webkit-tests: Break more pieces of the script into
4202         seprate functions. Added readSkippedFiles, findTestsToRun, and
4203         printResults functions. Removed custom code to skip results.html
4204         and instead just put it into the ignoredFiles hash. Fixed some
4205         indentation. Sorted function declarations, global variables,
4206         and options at the top of the file alphabetically so they're not
4207         in a semi-random order.
4208
4209 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
4210
4211         wx build fix, add missing dependency.
4212
4213         * wx/browser/wscript:
4214
4215 2009-09-16  Mark Rowe  <mrowe@apple.com>
4216
4217         Split the SnowLeopard build across a few machines.
4218
4219         * BuildSlaveSupport/build.webkit.org-config/config.json:
4220
4221 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
4222
4223         wx build fix to support monolithic builds on Windows.
4224
4225         * wx/build/wxpresets.py:
4226
4227 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
4228
4229         wx build fix, improve debug support and 2.9 support on MSW.
4230
4231         * wx/build/settings.py:
4232         * wx/build/wxpresets.py:
4233
4234 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4235
4236         Blind try at fixing new test failure on Windows.
4237
4238         * DumpRenderTree/win/FrameLoadDelegate.cpp:
4239         (FrameLoadDelegate::didReceiveTitle):
4240
4241 2009-09-15  Alex Milowski  <alex@milowski.com>
4242
4243         Reviewed by Tor Arne Vestbø.
4244
4245         Added mathml toggle
4246
4247         * Scripts/build-webkit:
4248
4249 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
4250
4251         wx build fix. Allow waf build to support Python < 2.6.
4252
4253         * wx/build/waf_extensions.py:
4254
4255 2009-09-14  Chris Marrin  <cmarrin@apple.com>
4256
4257         Reviewed by Oliver Hunt.
4258
4259         Add LayoutTests infrastructure to enable and disable webgl tests.
4260         https://bugs.webkit.org/show_bug.cgi?id=29254
4261
4262         * Scripts/run-webkit-tests:
4263         * Scripts/webkitdirs.pm:
4264
4265 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
4266
4267         Reviewed by Darin Adler.
4268         
4269         Add --iterations option to run-webkit-tests to repeat the tests N times
4270         https://bugs.webkit.org/show_bug.cgi?id=29263
4271
4272         When run with --iterations N, run-webkit-tests will repeat the tests N times.
4273
4274         * Scripts/run-webkit-tests:
4275
4276 2009-09-14  Brady Eidson  <beidson@apple.com>
4277
4278         Not reviewed, maybe should've been:
4279
4280         Cleaning up more Windows-specific fallout from the fix for:
4281         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
4282
4283         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4284         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter, 
4285           and call the correct method to get the Sender.
4286
4287 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
4288
4289         GTK build fix.
4290
4291         Unreviewed.
4292
4293         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
4294         (AccessibilityController::setLogScrollingStartEvents):
4295
4296 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
4297
4298         DRT/test part of
4299         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
4300         jumping to a named anchor
4301
4302         https://bugs.webkit.org/show_bug.cgi?id=28899
4303
4304         Reviewed by Adam Roben.
4305
4306         * DumpRenderTree/AccessibilityController.cpp:
4307         (logScrollingStartEventsCallback):
4308         Turn on logging of scrolling start events.
4309         (AccessibilityController::getJSClass):
4310         Add a "logScrollingStartEvents" to the AccessibilityController's JS
4311         class definition.
4312         (AccessibilityController::resetToConsistentState):
4313         Turn off logging of scrolling start events.
4314
4315         * DumpRenderTree/AccessibilityController.h:
4316         Declare setLogScrollingStartEvents(). Add a member for the scrolling
4317         start event hook.
4318
4319         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
4320         (AccessibilityController::setLogScrollingStartEvents):
4321         Stubbed.
4322
4323         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4324         (AccessibilityController::AccessibilityController):
4325         Initialize the handle to 0.
4326         (logEventProc):
4327         Renamed from logFocusEventProc; now logs scrolling start events, too.
4328         Removed the assertion that the event is a focus event. Added a switch
4329         to print a message for focus, scrolling start, and other, unknown
4330         events.
4331         (AccessibilityController::setLogFocusEvents):
4332         Changed to use logEventProc.
4333         (AccessibilityController::setLogScrollingStartEvents):
4334         If turning logging off, unhook the scrolling start event hook, and clear
4335         the member holding the handle. If turning on, query for the root
4336         accessible, so that accessibility is enabled for the WebView, and call
4337         SetWinEventHook to setup an event hook using logEventProc as the
4338         callback function.
4339
4340 2009-09-14  Brady Eidson  <beidson@apple.com>
4341
4342         Windows build fix.
4343
4344         * DumpRenderTree/LayoutTestController.cpp:
4345         (setAuthenticationPasswordCallback):
4346         (setAuthenticationUsernameCallback):
4347         
4348         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4349         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
4350
4351 2009-09-14  Brady Eidson  <beidson@apple.com>
4352
4353         Reviewed by Alexey Proskuryakov.
4354
4355         Safari 4 cannot be used to update firmware on Linksys routers.
4356         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
4357