Add the .cpp files to the TestNetscapePlugIn target.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-05  Anders Carlsson  <andersca@apple.com>
2
3         Add the .cpp files to the TestNetscapePlugIn target.
4
5         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
6
7 2007-12-05  Anders Carlsson  <andersca@apple.com>
8
9         Reviewed by Geoff.
10         
11         Rename the TestNetscapePlugIn .c files to be .cpp.
12
13         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
14         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
15         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
16         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
17         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
18         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
19         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
20         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
21
22 2007-12-05  Adam Roben  <aroben@apple.com>
23
24         Fix case of keypresses from the Windows implementation of eventSender.keyDown
25
26         This fixes several regression tests.
27
28         Reviewed by Alice.
29
30         * DumpRenderTree/win/EventSender.cpp:
31         (keyDownCallback): Virtual keycodes for ASCII characters are always
32         uppercase, so we need to check the case of the original character
33         passed in to eventSender.keyDown.
34
35 2007-12-05  Adam Roben  <aroben@apple.com>
36
37         Learn from Tim's mistakes
38
39         * DumpRenderTree/win/DumpRenderTree.cpp:
40         (runTest): Reset the authorAndUserStylesEnabled preference for each
41         test.
42
43 2007-12-05  Alp Toker  <alp@atoker.com>
44
45         Reviewed by Mark Rowe.
46
47         Initialize GTK+ and WebKit so the tests can run.
48
49         Reorganize the headers a little.
50
51         * DumpRenderTree/gtk/DumpRenderTree.cpp:
52         (main):
53
54 2007-12-04  Anders Carlsson  <andersca@apple.com>
55
56         Remove IWebScriptScope include.
57         
58         * Drosera/win/DebuggerDocumentPlatform.cpp:
59
60 2007-12-04  Sam Weinig  <sam@webkit.org>
61
62         Rubber stamped by Mark Rowe.
63
64         Define CF as platform for mac and revert r28409
65
66         * DumpRenderTree/DumpRenderTree.h:
67         * DumpRenderTree/mac/DumpRenderTreeMac.h:
68
69 2007-12-04  Sam Weinig  <sam@webkit.org>
70
71         Define CF as platform for windows.
72
73         Reviewed by Adam Roben.
74
75         * DumpRenderTree/win/DumpRenderTreeWin.h:
76
77 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
78
79         Reviewed by Adam and Darin.
80
81         - Removed a needless BSTR cleanup.
82
83         * Drosera/win/DebuggerDocumentPlatform.cpp:
84         (DebuggerDocument::getPlatformCurrentFunctionStack):
85
86 2007-11-27  Adam Roben  <aroben@apple.com>
87
88         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
89
90         Reviewed by Maciej.
91
92         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
93         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
94
95 2007-12-04  Alp Toker  <alp@atoker.com>
96
97         Prospective Win DRT build fix.
98
99         * DumpRenderTree/DumpRenderTree.h:
100
101 2007-12-04  Alp Toker  <alp@atoker.com>
102
103         Fix a clobbered copyright header.
104
105         * DumpRenderTree/gtk/DumpRenderTree.cpp:
106
107 2007-12-04  Xan Lopez  <xan@gnome.org>
108
109         Reviewed by Alp Toker.
110
111         http://bugs.webkit.org/show_bug.cgi?id=15561
112         GTK port needs DumpRenderTree implementation
113
114         Start work on the GTK+ DRT.
115
116         This does not work yet, and there are a few lingering style issues
117         (nothing major) but this patch has been stuck in the bug tracker for
118         too long already.
119
120         * DumpRenderTree/DumpRenderTree.h:
121         * DumpRenderTree/gtk: Added.
122         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
123         (autocorrectURL):
124         (shouldLogFrameLoadDelegates):
125         (dumpFrameScrollPosition):
126         (displayWebView):
127         (appendString):
128         (dumpFramesAsText):
129         (dumpRenderTreeAsText):
130         (dump):
131         (runTest):
132         (main):
133         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
134         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
135         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
136         (GCController::collect):
137         (GCController::collectOnAlternateThread):
138         (GCController::getJSObjectCount):
139         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
140         (LayoutTestController::~LayoutTestController):
141         (LayoutTestController::addDisallowedURL):
142         (LayoutTestController::clearBackForwardList):
143         (LayoutTestController::copyDecodedHostName):
144         (LayoutTestController::copyEncodedHostName):
145         (LayoutTestController::display):
146         (LayoutTestController::keepWebHistory):
147         (LayoutTestController::notifyDone):
148         (LayoutTestController::queueBackNavigation):
149         (LayoutTestController::queueForwardNavigation):
150         (LayoutTestController::queueLoad):
151         (LayoutTestController::queueReload):
152         (LayoutTestController::queueScript):
153         (LayoutTestController::setAcceptsEditing):
154         (LayoutTestController::setCustomPolicyDelegate):
155         (LayoutTestController::setMainFrameIsFirstResponder):
156         (LayoutTestController::setTabKeyCyclesThroughElements):
157         (LayoutTestController::setUseDashboardCompatibilityMode):
158         (LayoutTestController::setUserStyleSheetEnabled):
159         (LayoutTestController::setUserStyleSheetLocation):
160         (LayoutTestController::setWindowIsKey):
161         (LayoutTestController::setWaitToDump):
162         (LayoutTestController::windowCount):
163         (LayoutTestController::setPrivateBrowsingEnabled):
164         (LayoutTestController::setAuthorAndUserStylesEnabled):
165         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
166         (JSStringCopyUTF8CString):
167         (LoadItem::invoke):
168         (ReloadItem::invoke):
169         (ScriptItem::invoke):
170         (BackForwardItem::invoke):
171
172 2007-12-03  Sam Weinig  <sam@webkit.org>
173
174         Move JavaScriptCore thread testing code to pthread specific directory
175         and remove the dependance on CoreFoundation by using WTF::HashSet.
176
177         Reviewed by Geoff and Oliver.
178
179         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
180         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
181         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
182         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
183         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
184         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
185         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
186         * DumpRenderTree/pthreads: Added.
187         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
188         (javaScriptThreads):
189         (runJavaScriptThread):
190         (startJavaScriptThreads):
191         (stopJavaScriptThreads):
192
193 2007-12-03  Andrew Bonventre  <andybons@google.com>
194
195         Reviewed by Darin Adler.
196
197         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
198         Symbol lookup menu broken in debugger view
199
200         * Drosera/debugger.js: Fixed javascript error where document property
201         should have been used instead of contentDocument in switchFunction that
202         was breaking the select symbol dropdown menu.  This is because
203         window.frames will return a Window object and not a frame object like
204         the author was originally expecting.
205
206 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
207
208         Reviewed by Adam.
209
210         - <rdar://5618942> Drosera: Console window does not process everything
211         correctly.
212         - <rdar://5619005> Drosera: could be sped up by moving the 
213         WebScriptScope stuff into the WebScriptCallFrame.
214         - Now the console can correctly process objects and does not receive
215         notifications from JavaScriptCore about the JavaScript in Drosera's
216         own process.
217
218         * Drosera/win/DebuggerDocumentPlatform.cpp:
219         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
220         (DebuggerDocument::platformValueForScopeVariableNamed):
221
222 2007-12-03  Stephanie  <slewis@apple.com>
223
224         Reviewed by Darin.
225
226         Check to see if we are building a debug root
227
228         * Scripts/check-for-global-initializers: 
229
230 2007-12-03  Dan Bernstein  <mitz@apple.com>
231
232         Reviewed by Darin Adler.
233
234         - added a testGetIntIdentifier() method to TestNetscapePlugIn
235
236         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
237         (pluginInvoke):
238
239 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
240
241         Reviewed by Oliver.
242
243         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
244         in a more fine-grained manner than eventSender.keyDown().
245
246         * DumpRenderTree/win/EventSender.cpp:
247         (getConstantCallback):
248         (dispatchMessageCallback):
249
250 2007-12-02  Darin Adler  <darin@apple.com>
251
252         * Scripts/do-webcore-rename: More planned renaming.
253
254 2007-12-02  Sam Weinig  <sam@webkit.org>
255
256         Rubber stamped by Anders.
257
258         Use [NSURL absoluteString] instead of [NSURL description] in order to get
259         more uniform results cross platform.
260
261         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
262         (-[NSURL _drt_descriptionSuitableForTestResult]):
263
264 2007-12-02  Sam Weinig  <sam@webkit.org>
265
266         Rubber stamped by Niko.
267
268         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
269
270         * DumpRenderTree/win/DumpRenderTree.cpp:
271         * DumpRenderTree/win/DumpRenderTree.vcproj:
272         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
273         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
274         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
275         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
276
277 2007-12-01  Alp Toker  <alp@atoker.com>
278
279         Reviewed by Adam Roben.
280
281         Make use of the newly introduced webkit.h convenience header.
282
283         * GtkLauncher/main.c:
284
285 2007-12-01  Adam Treat  <treat@kde.org>
286
287         Reviewed by Simon.
288
289         * Check to see if the directory exists and exit if not.
290
291         * DumpRenderTree/qt/main.cpp:
292         (main):
293
294 2007-12-01  Adam Treat  <treat@kde.org>
295
296         Reviewed by Simon.
297
298         * Don't hide symbols when in Debug mode
299         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
300
301
302         * DumpRenderTree/qt/main.cpp:
303         (messageHandler):
304
305 2007-11-30  Alp Toker  <alp@atoker.com>
306
307         Reviewed by Adam Roben.
308
309         http://bugs.webkit.org/show_bug.cgi?id=15691
310         [GTK] Public API does not follow GTK+ conventions
311
312         Refactor the WebKit/GTK+ public API. Changes:
313           WebKitPage -> WebKitWebView
314           WebKitFrame -> WebKitWebFrame
315
316         Public API source and header names have been updated to mirror the API
317         changes.
318
319         The API is now kept in WebKit/gtk/WebView to match other ports in the
320         same class such as Mac and Win.
321
322         * GtkLauncher/main.c:
323         (activate_uri_entry_cb):
324         (link_hover_cb):
325         (title_change_cb):
326         (progress_change_cb):
327         (go_back_cb):
328         (go_forward_cb):
329         (create_browser):
330         (main):
331
332 2007-11-30  Adam Roben  <aroben@apple.com>
333
334         Hopefully the final build fix
335
336         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
337         pull in WTF's assertion/logging functions.
338
339 2007-11-30  Adam Roben  <aroben@apple.com>
340
341         Another build fix
342
343         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
344         WebKit.lib.
345
346 2007-11-30  Adam Roben  <aroben@apple.com>
347
348         Debug build fix
349
350         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
351         configuration.
352         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
353         projects.
354         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
355         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
356         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
357
358 2007-11-30  Sam Weinig  <sam@webkit.org>
359
360         Reviewed by Adam Roben.
361
362         Fix drawSelectionRect to actually draw the selection rect.
363
364         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
365         (drawSelectionRect):
366
367 2007-11-30  Darin Adler  <darin@apple.com>
368
369         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
370
371 2007-11-30  Darin Adler  <darin@apple.com>
372
373         * Scripts/do-webcore-rename: Get ready for some future renaming.
374
375 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
376
377         Reviewed by Adam.
378
379         - Removed some unnecessary functions and changed an unused return type. 
380
381         * Drosera/win/DebuggerClient.cpp:
382         (registerConsoleClass):
383         * Drosera/win/DebuggerClient.h:
384         * Drosera/win/Drosera.cpp:
385         (registerDroseraClass):
386
387 2007-11-28  Alp Toker  <alp@atoker.com>
388
389         Reviewed by Timothy Hatcher.
390
391         http://bugs.webkit.org/show_bug.cgi?id=16174
392         [GTK] Use "URI" not "URL" in public API
393
394         Replace use of the term "URL" with "URI" in public headers,
395         documentation and some internal code to match GLib/GTK+ convention.
396
397         This is now mentioned in the API guidelines:
398           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
399
400         * GtkLauncher/main.c:
401         (activate_uri_entry_cb):
402         (title_change_cb):
403         (create_toolbar):
404         (main):
405
406 2007-11-29  Anders Carlsson  <andersca@apple.com>
407
408         Reviewed by Sam.
409
410         <rdar://problem/5230478>
411         FrameLoadDelegate callbacks are not dumped in DRT.
412         
413         * DumpRenderTree/win/DumpRenderTree.cpp:
414         (shouldLogFrameLoadDelegates):
415         (runTest):
416         (main):
417         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
418         (BSTRtoString):
419         (descriptionSuitableForTestResult):
420         (FrameLoadDelegate::QueryInterface):
421         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
422         (FrameLoadDelegate::didFailProvisionalLoadWithError):
423         (FrameLoadDelegate::didCommitLoadForFrame):
424         (FrameLoadDelegate::didFinishLoadForFrame):
425         (FrameLoadDelegate::willCloseFrame):
426         (FrameLoadDelegate::didClearWindowObject):
427         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
428         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
429         * DumpRenderTree/win/FrameLoaderDelegate.h:
430         (FrameLoadDelegate::windowScriptObjectAvailable):
431         (FrameLoadDelegate::didFirstLayoutInFrame):
432
433 2007-11-29  Sam Weinig  <sam@webkit.org>
434
435         Reviewed by Anders.
436
437         Add database quota UIDelegates methods to DRT UIDelegate.
438
439         * DumpRenderTree/mac/UIDelegate.mm:
440         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
441         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
442
443 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
444
445         Reviewed by Sam.
446
447         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
448         dying and vice versa.
449         - This fix will allow Drosera and Safari to reconnect if either of them
450         closes correctly, but does not fix the case where one of them dies
451         silently.
452
453         * Drosera/win/ServerConnection.cpp:
454         (ServerConnection::attemptToCreateServerConnection): Added a safety
455         check, because it's possilbe to try to connect to a server that's dying.
456         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
457         the server has died.
458         * Drosera/win/ServerConnection.h: Added the new function and removed
459         an unnecessary member.
460
461 2007-11-29  Anders Carlsson  <andersca@apple.com>
462
463         * DumpRenderTree/win/DumpRenderTree.vcproj:
464         Add shlwapi.lib to all configurations.
465
466 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
467
468         - Build fix.  Added additional includes for VS Express to the Release
469         project.
470
471         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
472
473 2007-11-29  Anders Carlsson  <andersca@apple.com>
474
475         Reviewed by Adam.
476
477         <rdar://problem/5132005>
478         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
479         
480         * DumpRenderTree/win/DumpRenderTree.vcproj:
481         Add shlwapi.lib
482         
483         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
484         (LayoutTestController::setUserStyleSheetEnabled):
485         Implement this.
486         
487         (appendComponentToPath):
488         New method which wraps the Win32 API PathAppend.
489         
490         (followShortcuts):
491         New method which checks if a file points to a shortcut and
492         follows the shortcut.
493         
494         (resolveCygwinPath):
495         New method that takes a cygwin unix-style path and returns the Win32 path.
496         
497         (cfStringRefToWString):
498         
499         (LayoutTestController::setUserStyleSheetLocation):
500         Implement this.
501
502 2007-11-29  Alice Liu  <alice.liu@apple.com>
503
504         Reviewed by Adam.
505
506         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
507
508         * DumpRenderTree/win/EventSender.cpp:
509         (keyDownCallback):
510         uppercase letters were being sent as lowercase letters without the shift key down.
511
512 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
513
514         - Windows build fix. VS express needs some love.
515
516         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
517
518 2007-11-28  Darin Adler  <darin@apple.com>
519
520         Reviewed by Adam Roben.
521
522         * DumpRenderTree/mac/EventSendingController.mm:
523         (-[EventSendingController keyDown:withModifiers:]):
524         Send capital letters through as lowercase letters with the shift key down
525         rather than sending them as if they were highly unusual "capital letter keys".
526
527         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
528         where you need to update results and more tests are failing than before.
529
530 2007-11-28  Anders Carlsson  <andersca@apple.com>
531
532         Reviewed by Darin.
533
534         <rdar://problem/5132001>
535         contextClick is not implemented in DRT on Windows.
536         
537         * DumpRenderTree/win/EventSender.cpp:
538         (contextClickCallback):
539         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
540         by a WM_RBUTTONUP message.
541         
542         * DumpRenderTree/win/UIDelegate.cpp:
543         (UIDelegate::hasCustomMenuImplementation):
544         (UIDelegate::trackCustomPopupMenu):
545         * DumpRenderTree/win/UIDelegate.h:
546         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
547         menu from being shown (and causing the DRT to hang).
548
549 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
550
551         Reviewed by Darin.
552
553         Fix DumpRenderTree ObjC bug comparing strings.
554
555         * DumpRenderTree/mac/ObjCController.m:
556         (-[ObjCController identityIsEqual::]): Compare strings with string
557         equality instead of identiy equality.
558
559 2007-11-27  Timothy Hatcher  <timothy@apple.com>
560
561         Reviewed by Sam.
562
563         Reset the authorAndUserStylesEnabled preference
564         back to YES for each test. Fixes the broken tests.
565
566         * DumpRenderTree/mac/DumpRenderTree.mm:
567         (resetWebViewToConsistentStateBeforeTesting):
568
569 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
570
571         Reviewed by Adam.
572
573         - Drosera now displays the console window, although it cannot currently
574         process JavaScript.
575
576         * Drosera/win/DebuggerClient.cpp: Shows the console window.
577         (registerConsoleClass): Implemented.
578         (consoleWndProc): Implemented.
579         (DebuggerClient::onSize): Implemented.
580         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
581         new window.
582         * Drosera/win/DebuggerClient.h: Added needed method and members for 
583         creating and maintaining a new window.
584         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
585         lines of code to more appropriate places.
586         (Drosera::handleCommand):
587         (Drosera::initUI):
588         (Drosera::onSize):
589         (Drosera::attach):
590
591 2007-11-27  Timothy Hatcher  <timothy@apple.com>
592
593         Reviewed by Dave Hyatt.
594
595         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
596         
597         Add support for disabling author and user styles for testing.
598
599         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
600         * DumpRenderTree/LayoutTestController.cpp:
601         (setAuthorAndUserStylesEnabledCallback):
602         (LayoutTestController::staticFunctions):
603         * DumpRenderTree/LayoutTestController.h:
604         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
605         (LayoutTestController::setAuthorAndUserStylesEnabled):
606         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
607         (LayoutTestController::setAuthorAndUserStylesEnabled):
608
609 2007-11-26  Dan Bernstein  <mitz@apple.com>
610
611         - Tiger build fix.
612
613         * DumpRenderTree/mac/Configurations/Base.xcconfig:
614
615 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
616
617         Reviewed by Maciej.
618
619         - Implemented displaying variables for Drosera on Win.
620
621         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
622         that retrieve variables to not hold onto the return value since it's
623         not returned.  Also changed to use the new signatures of the retrieval
624         functions.
625         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
626         (DebuggerDocument::platformValueForScopeVariableNamed):
627         * Drosera/win/Drosera.cpp: Removed a needless TODO.
628         (droseraWndProc):
629
630 2007-11-26  Sam Weinig  <sam@webkit.org>
631
632         Cleanup names of painting and repainting functions.
633
634         Reviewed by Adam Roben.
635
636         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
637         (drawSelectionRect): was drawSelectionRectIntoContext.
638         (dumpWebViewAsPixelsAndCompareWithExpected):
639         * DumpRenderTree/cg/PixelDumpSupportCG.h:
640         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
641         (paintWebView): was drawWebViewIntoContext.
642         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
643
644 2007-11-26  Sam Weinig  <sam@webkit.org>
645
646         Reviewed by Dan Bernstein.
647
648         - Leopard build fix
649
650         * DumpRenderTree/mac/Configurations/Base.xcconfig:
651
652 2007-11-26  Sam Weinig  <sam@webkit.org>
653
654         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
655         Use shared PixelDumpSupport for Mac DRT
656
657         Reviewed by Adam Roben.
658
659         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
660         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
661         * DumpRenderTree/cg/ImageDiffCG.cpp:
662         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
663         (drawSelectionRectIntoContext):
664         (dumpWebViewAsPixelsAndCompareWithExpected):
665         * DumpRenderTree/cg/PixelDumpSupportCG.h:
666         * DumpRenderTree/mac/Configurations/Base.xcconfig:
667         * DumpRenderTree/mac/DumpRenderTree.mm:
668         (dump):
669         * DumpRenderTree/mac/ImageDiff.m: Removed.
670         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
671         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
672         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
673         (setDefaultColorProfileToRGB):
674         (getBitmapContextFromWebView):
675         (drawWebViewIntoContext):
676         (repaintWithVerticalSweep):
677         (repaintWithHorizontalSweep):
678         (getSelectionRect):
679         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
680
681 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
682
683         Bug 16052: prepare-ChangeLog doesn't report deleted files
684         <http://bugs.webkit.org/show_bug.cgi?id=16052>
685
686         Reviewed by Sam.
687
688         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
689
690 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
691
692         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
693         <http://bugs.webkit.org/show_bug.cgi?id=15864>
694
695         Reviewed by Adam.
696
697         Roll functionality of merge-changelog into resolve-ChangeLogs
698         script.  The script now checks for ChangeLog.rej and
699         ChangeLog.orig files first.  If it finds them, it uses the
700         ChangeLog.rej file as a patch (in old contextual diff format) to
701         apply with --fuzz=3.
702
703         * Scripts/merge-changelog: Removed.
704         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
705
706 2007-11-25  Sam Weinig  <sam@webkit.org>
707
708         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
709
710         Reviewed by Mark Rowe.
711
712         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
713         * DumpRenderTree/mac/Configurations/Base.xcconfig:
714         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
715         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
716         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
717
718 2007-11-25  Sam Weinig  <sam@webkit.org>
719
720         Convert DumpRenderTree to ues .xcconfig files.
721
722         Reviewed by Mark Rowe.
723
724         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
725         * DumpRenderTree/mac/Configurations: Added.
726         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
727         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
728         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
729
730 2007-11-25  Sam Weinig  <sam@webkit.org>
731
732         Add ForwardingHeaders to wtf for DumpRenderTree.
733
734         Reviewed by Mark Rowe.
735
736         * DumpRenderTree/DumpRenderTree.h:
737         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
738         * DumpRenderTree/ForwardingHeaders: Added.
739         * DumpRenderTree/ForwardingHeaders/wtf: Added.
740         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
741         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
742         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
743         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
744         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
745         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
746         * DumpRenderTree/LayoutTestController.cpp:
747         * DumpRenderTree/WorkQueue.cpp:
748         * DumpRenderTree/mac/DumpRenderTree.mm:
749         * DumpRenderTree/mac/FrameLoadDelegate.mm:
750         * DumpRenderTree/mac/JavaScriptThreading.cpp:
751         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
752         * DumpRenderTree/mac/ObjCController.m:
753         * DumpRenderTree/mac/UIDelegate.mm:
754         * DumpRenderTree/mac/WorkQueueItemMac.mm:
755
756 2007-11-25  Adam Roben  <aroben@apple.com>
757
758         Fix some test failures caused by r28019
759
760         Now that stdout is in binary mode, we need to always use printf
761         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
762         the output.
763
764         Reviewed by Sam.
765
766         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
767         printf.
768         (UIDelegate::runJavaScriptAlertPanelWithMessage):
769         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
770         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
771         (UIDelegate::webViewAddMessageToConsole):
772
773 2007-11-25  Adam Roben  <aroben@apple.com>
774
775         Set the font smoothing preference in DRT
776
777         This makes the pixel results on Windows closer to the Mac results.
778
779         Reviewed by Mitz.
780
781         * DumpRenderTree/win/DumpRenderTree.cpp:
782         (initializePreferences):
783
784 2007-11-25  Adam Roben  <aroben@apple.com>
785
786         Port ImageDiff to CG and C++
787
788         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
789         <rdar://5071708>
790
791         Reviewed by Sam.
792
793         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
794         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
795         (main):
796         (createImageFromStdin):
797         (compareImages):
798         (getDifferenceBitmap):
799         (computePercentageDifferent):
800         * DumpRenderTree/win/ImageDiff.vcproj: Added.
801
802 2007-11-25  Adam Roben  <aroben@apple.com>
803
804         Fix image diff link generation on Windows
805
806         Reviewed by Sam.
807
808         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
809         to toURL.
810
811 2007-11-25  Adam Roben  <aroben@apple.com>
812
813         Implement pixel dumping in Windows DRT
814
815         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
816         <rdar://5071708>
817
818         Reviewed by Sam.
819
820         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
821         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
822         Content-Length header.
823         (getMD5HashStringForBitmap):
824         (dumpWebViewAsPixelsAndCompareWithExpected):
825         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
826         * DumpRenderTree/win/DumpRenderTree.cpp:
827         (dump): Do a pixel dump if requested.
828         (main): Parse pixel test options.
829         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
830         the cg/ subdirectory to the include path.
831         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
832         available in a header or import library, so we have to go through this
833         LoadLibrary/GetProcAddress dance to use them.
834         (cryptDLL):
835         (init):
836         (update):
837         (final):
838         (MD5_Init):
839         (MD5_Update):
840         (MD5_Final):
841         * DumpRenderTree/win/MD5.h: Added.
842         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
843         moved up to the top level to share it with Mac eventually.
844         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
845         (getBitmapContextFromWebView): Forces the WebView to paint using a
846         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
847
848 2007-11-25  Adam Roben  <aroben@apple.com>
849
850         Clean up Windows DRT's option parsing a little bit
851
852         Reviewed by Sam.
853
854         * DumpRenderTree/win/DumpRenderTree.cpp:
855         (main): Put non-option arguments into a Vector.
856
857 2007-11-25  Adam Roben  <aroben@apple.com>
858
859         Make Windows DRT stop changing LF into CRLF
860
861         Reviewed by Sam.
862
863         * DumpRenderTree/win/DumpRenderTree.cpp:
864         (main): Put stdout in binary mode.
865         * Scripts/run-webkit-tests: Remove the CRLF hack.
866
867 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
868
869         Removed empty directory.
870
871         * Scripts/resources: Removed.
872
873 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
874
875         Fix bisect-builds to work with recent WebKit nightly builds.
876
877         Reviewed by Dan.
878
879         * Scripts/bisect-builds: Check for the 
880         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
881         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
882         to WebKit.app/Contents/Resources.
883
884 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
885
886         Reviewed by Maciej.
887
888         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
889         not closed (affects digg.com)
890
891         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
892         one after finishing with a test to avoid having its delayed onload handler firing when
893         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
894         but it helps somewhat.
895
896 2007-11-22  Mark Rowe  <mrowe@apple.com>
897
898         Reviewed by Alp Toker.
899
900         Fix build-webkit to propagate make's exit status if it fails.
901
902         * Scripts/webkitdirs.pm:
903
904 2007-11-22  Dan Bernstein  <mitz@apple.com>
905
906         Reviewed by Mark Rowe.
907
908         - fix crash when running pixel tests
909
910         * DumpRenderTree/mac/DumpRenderTree.mm:
911         (dumpRenderTree): Parse the command line options before setting up the
912         environment so that we know if we need to set up the pixel dump
913         machinery.
914
915 2007-11-21  Eric Seidel  <eric@webkit.org>
916
917         Speculative build fix for Tiger.
918
919         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
920
921 2007-11-21  Eric Seidel  <eric@webkit.org>
922
923         Reviewed by Tim Hatcher.
924
925         Break out more of DumpRenderTree.mm into individual files
926
927         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
928         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
929         (checkedMalloc):
930         (checkedRealloc):
931         (makeLargeMallocFailSilently):
932         * DumpRenderTree/mac/CheckedMalloc.h: Added.
933         * DumpRenderTree/mac/DumpRenderTree.mm:
934         (crashHandler):
935         (dump):
936         * DumpRenderTree/mac/DumpRenderTreeMac.h:
937         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
938         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
939         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
940         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
941         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
942         (javaScriptThreads):
943         (runJavaScriptThread):
944         (startJavaScriptThreads):
945         (stopJavaScriptThreads):
946         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
947         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
948         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
949         (restoreColorSpace):
950         (setDefaultColorProfileToRGB):
951         (initializeColorSpaceAndScreeBufferForPixelTests):
952         (md5HashStringForBitmap):
953         (dumpWebViewAsPixelsAndCompareWithExpected):
954
955 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
956
957         Move install-unix-extras to wx directory as it seems only to be used by that 
958         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
959         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
960         have install-unix-extras install into WebKitLibraries as per
961         convention.
962         
963         Reviewed by Mark Rowe.
964
965         * Scripts/install-unix-extras: Removed.
966         * wx/build-wxwebkit:
967         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
968
969 2007-11-21  Eric Seidel  <eric@webkit.org>
970
971         Reviewed by Adam.
972
973         More refactoring for greater code readability
974
975         * DumpRenderTree/mac/DumpRenderTree.mm:
976         (initializeGlobalsFromCommandLineOptions):
977         (initializeColorSpaceAndScreeBufferForPixelTests):
978         (addTestPluginsToPluginSearchPath):
979         (useLongRunningServerMode):
980         (runTestingServerLoop):
981         (prepareConsistentTestingEnvironment):
982         (dumpRenderTree):
983         (main):
984         (dumpFramesAsText):
985         (dumpBackForwardListForWebView):
986         (sizeWebViewForCurrentTest):
987         (methodNameStringForFailedTest):
988         (dumpBackForwardListForAllWindows):
989         (dumpWebViewAsPixelsAndCompareWithExpected):
990         (invalidateAnyPreviousWaitToDumpWatchdog):
991         (dump):
992         * DumpRenderTree/mac/DumpRenderTreeMac.h:
993         * DumpRenderTree/mac/UIDelegate.mm:
994         (-[UIDelegate webView:createWebViewWithRequest:]):
995
996 2007-11-21  Eric Seidel  <eric@webkit.org>
997
998         Reviewed by Tim Hatcher.
999
1000         Abstract more of DRT into static methods
1001
1002         * DumpRenderTree/mac/DumpRenderTree.mm:
1003         (setDefaultsToConsistentValuesForTesting):
1004         (setupSignalHandlers):
1005         (allocateGlobalControllers):
1006         (releaseAndZero):
1007         (releaseGlobalControllers):
1008         (dumpRenderTree):
1009         (shouldLogFrameLoadDelegates):
1010         (createCFURLFromPathOrURL):
1011         (resetWebViewToConsistentStateBeforeTesting):
1012         (runTest):
1013
1014 2007-11-21  Eric Seidel  <eric@webkit.org>
1015
1016         Reviewed by Tim Hatcher.
1017
1018         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1019
1020         * DumpRenderTree/DumpRenderTree.h:
1021         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1022         * DumpRenderTree/mac/DumpRenderTree.mm:
1023         (dumpRenderTree):
1024         (dump):
1025         (runTest):
1026         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1027         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1028         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1029         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1030         (-[DumpRenderTreePasteboard declareType:owner:]):
1031         (+[LocalPasteboard alloc]):
1032         (-[LocalPasteboard init]):
1033         (-[LocalPasteboard dealloc]):
1034         (-[LocalPasteboard name]):
1035         (-[LocalPasteboard releaseGlobally]):
1036         (-[LocalPasteboard declareTypes:owner:]):
1037         (-[LocalPasteboard addTypes:owner:]):
1038         (-[LocalPasteboard changeCount]):
1039         (-[LocalPasteboard types]):
1040         (-[LocalPasteboard availableTypeFromArray:]):
1041         (-[LocalPasteboard setData:forType:]):
1042         (-[LocalPasteboard dataForType:]):
1043         (-[LocalPasteboard setPropertyList:forType:]):
1044         (-[LocalPasteboard setString:forType:]):
1045         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1046         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1047         (+[DumpRenderTreeWindow allWindows]):
1048         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1049         (-[DumpRenderTreeWindow dealloc]):
1050         (-[DumpRenderTreeWindow isKeyWindow]):
1051         (-[DumpRenderTreeWindow keyDown:]):
1052
1053 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1054
1055         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1056         it indiscriminately copies any headers inside JavaScriptCore,
1057         which includes Tiger ICU headers. 
1058
1059         * wx/build-wxwebkit:
1060         Don't run WebCore/move-js-headers.sh any longer.
1061
1062 2007-11-20  Adam Treat  <treat@kde.org>
1063
1064         Reviewed by David Kilzer.
1065
1066         * Prepend git branch name to $baseProductDir
1067
1068         * Scripts/VCSUtils.pm:
1069         * Scripts/webkitdirs.pm:
1070
1071 2007-11-20  Mark Rowe  <mrowe@apple.com>
1072
1073         Reviewed by Simon Hausmann.
1074
1075         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1076         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1077         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1078         built product and generated Makefile's are removed.
1079
1080 2007-11-19  Alp Toker  <alp@atoker.com>
1081
1082         Reviewed by Mark Rowe.
1083
1084         http://bugs.webkit.org/show_bug.cgi?id=16040
1085         [GTK] GtkLauncher should be written in C
1086
1087         Port GtkLauncher to plain C.
1088
1089         Use a more conventional GTK+ coding style.
1090
1091         Use a toolbar instead of menus.
1092
1093         Various signature fixes and cleanups.
1094
1095         Add a license header. Assume all previous modifications were copyright
1096         assigned to Apple Inc. by default.
1097
1098         * GtkLauncher/GtkLauncher.pro:
1099         * GtkLauncher/main.c: Added.
1100         (activate_url_entry_cb):
1101         (update_title):
1102         (link_hover_cb):
1103         (title_change_cb):
1104         (progress_change_cb):
1105         (destroy_cb):
1106         (go_back_cb):
1107         (go_forward_cb):
1108         (create_browser):
1109         (create_statusbar):
1110         (create_toolbar):
1111         (create_window):
1112         (main):
1113         * GtkLauncher/main.cpp: Removed.
1114
1115 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1116
1117         Build script fixes to ensure they do the right thing for the 
1118         wx port, and update build-wxwebkit to reflect the way the
1119         build scripts now work.
1120
1121         Reviewed by Adam.
1122
1123         * Scripts/build-testkjs:
1124         * Scripts/build-webkit:
1125         * Scripts/run-javascriptcore-tests:
1126         * Scripts/webkitdirs.pm:
1127         * wx/build-wxwebkit:
1128
1129 2007-11-18  Eric Seidel  <eric@webkit.org>
1130
1131         Reviewed by Anders.
1132
1133         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1134
1135         * Scripts/run-javascriptcore-tests:
1136
1137 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1138
1139         Reviewed by Adam Roben.
1140
1141         Make run-webkit-tests work with Windows debug build.
1142
1143         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1144         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1145         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1146         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1147         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1148
1149 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1150
1151         Add wxWebKit sample and build script, and integrate it with 
1152         build-webkit. Also make build-webkit --clean work for all
1153         ports.
1154
1155         Reviewed by Darin Adler.
1156
1157         * Scripts/build-webkit:
1158         * Scripts/webkitdirs.pm:
1159         * wx: Added.
1160         * wx/browser: Added.
1161         * wx/browser/browser.bkl: Added.
1162         * wx/browser/browser.cpp: Added.
1163         * wx/build-wxwebkit: Added.
1164
1165 2007-11-17  Adam Roben  <aroben@apple.com>
1166
1167         Make it easy to run Safari in the debugger on Windows
1168
1169         I've added a new script, debug-safari, which launches Safari in the
1170         debugger. On OS X it just calls gdb-safari.
1171
1172         Reviewed by Mark Rowe.
1173
1174         * FindSafari/FindSafari.cpp:
1175         (_tmain): Added a /debugger flag, which in combination with
1176         /printSafariLauncher will print a script that launches Safari in the
1177         debugger.
1178         * Scripts/debug-safari: Added.
1179         * Scripts/run-safari: Changed to call runSafari().
1180         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1181         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1182         first argument along to FindSafari.
1183         * Scripts/webkitdirs.pm:
1184         (sub runSafari): Added.
1185
1186 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1187
1188         Reviewed by Adam Roben.
1189
1190         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1191
1192 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1193
1194         Reviewed by David Kilzer.
1195
1196         The git config command was renamed to repo-config at some point. This
1197         change tries git config and then git repo-config if the first fails.
1198
1199         * Scripts/prepare-ChangeLog:
1200         (gitConfig):
1201
1202 2007-11-16  Dan Bernstein  <mitz@apple.com>
1203
1204         Reviewed by Darin Adler and Sam Weinig.
1205
1206         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1207
1208         * DumpRenderTree/win/EventSender.cpp:
1209         (keyDownCallback): For characters that cannot be entered on the active
1210         keyboard layout, send a WM_CHAR message with the character along with
1211         a WM_KEYDOWN message with a virtual key code of 255.
1212
1213 2007-11-16  Mark Rowe  <mrowe@apple.com>
1214
1215         Reviewed by Tim Hatcher.
1216
1217         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1218
1219         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1220         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1221
1222 2007-11-15  Adam Roben  <aroben@apple.com>
1223
1224         Make run-safari actually work on Windows
1225
1226         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1227         chdir call.
1228
1229 2007-11-14  Adam Roben  <aroben@apple.com>
1230
1231         Updates to Safari launching now that 3.0.4 is released
1232
1233         Reviewed by Sam.
1234
1235         * FindSafari/FindSafari.cpp:
1236         (getWebViewCLSID): Use version-independent ProgID.
1237         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1238
1239 2007-11-14  Anders Carlsson  <andersca@apple.com>
1240
1241         Reviewed by Adam.
1242
1243         <rdar://problem/5309081>
1244         In DRT, "plugin.logDestroy = true" not working on Windows.
1245         
1246         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1247         (NPP_Destroy):
1248
1249 2007-11-14  Eric Seidel  <eric@webkit.org>
1250
1251         Reviewed by Sam.
1252
1253         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1254
1255 2007-11-14  Anders Carlsson  <andersca@apple.com>
1256
1257         Reviewed by Adam.
1258
1259         <rdar://problem/5141186>
1260         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1261         
1262         Implement setWindowIsKey.
1263         
1264         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1265         (LayoutTestController::setWindowIsKey):
1266
1267 2007-11-13  Sam Weinig  <sam@webkit.org>
1268
1269         Reviewed by Adam Roben.
1270
1271         Fix for <rdar://problem/5382579>
1272         http/tests/security/cross-frame-access-put.html reports large 
1273         negative numbers for screenLeft and screenTop (Mac reports "0")
1274
1275         * DumpRenderTree/win/UIDelegate.cpp:
1276         (UIDelegate::UIDelegate): Initialize the RECT.
1277         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1278         (UIDelegate::webViewFrame): ditto.
1279         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1280
1281 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1282
1283         Reviewed by Adam.
1284
1285         - Make Drosera show source, source URLs, and function stack on Windows,
1286         and some minor fixes.
1287
1288         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1289         (DebuggerDocument::updateFileSource):
1290         * Drosera/debugger.js: Force source to always update display.
1291         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1292         menu controls.
1293         (DebuggerClient::resume):
1294         (DebuggerClient::pause):
1295         (DebuggerClient::stepInto):
1296         (DebuggerClient::stepOver):
1297         (DebuggerClient::stepOut):
1298         (DebuggerClient::showConsole):
1299         (DebuggerClient::closeCurrentFile):
1300         * Drosera/win/DebuggerClient.h: Ditto.
1301         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1302         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1303         removed two bugs.  1) caller could be in a bad state when asked to
1304         assign into it. 2) BSTRs were not created correctly.
1305         (DebuggerDocument::getPlatformCurrentFunctionStack):
1306         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1307         (droseraWndProc):
1308         (handleCommand):
1309         (Drosera::resume):
1310         (Drosera::pause):
1311         (Drosera::stepInto):
1312         (Drosera::stepOver):
1313         (Drosera::stepOut):
1314         (Drosera::showConsole):
1315         (Drosera::closeCurrentFile):
1316         * Drosera/win/Drosera.h: Hook up the menu controls.
1317         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1318         functions, added a null check, and fixed another bug where caller could
1319         be in a bad state when asked to assign into it.
1320         (ServerConnection::didLoadMainResourceForDataSource):
1321         (ServerConnection::getCallerFrame):
1322         * Drosera/win/ServerConnection.h: Safety first.
1323
1324 2007-11-13  Dan Bernstein  <mitz@apple.com>
1325
1326         Reviewed by Darin Adler.
1327
1328         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1329           DumpRenderTree --pixel-tests renders each test twice
1330
1331         * DumpRenderTree/mac/DumpRenderTree.mm:
1332         (dumpRenderTree): Removed the --paint option because the painting code
1333         is always exercised as a result of
1334         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1335         calling -displayIfNeeded.
1336         (dump): Changed to always grab the image from the window since the view
1337         is always displayed.
1338         (runTest):
1339         (displayWebView):
1340         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1341         because it always paints.
1342
1343 2007-11-12  Antti Koivisto  <antti@apple.com>
1344
1345         Reviewed by Adele.
1346         
1347         Add support for http media tests
1348
1349         * Scripts/run-webkit-tests:
1350
1351 2007-11-12  Sam Weinig  <sam@webkit.org>
1352
1353         Reviewed by Adam Roben.
1354
1355         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1356
1357         * DumpRenderTree/win/DumpRenderTree.cpp:
1358         (runTest):
1359         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1360         (LayoutTestController::setPrivateBrowsingEnabled):
1361
1362 2007-11-12  Adam Roben  <aroben@apple.com>
1363
1364         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1365         mac and win subdirectories.
1366
1367 2007-11-11  Adam Roben  <aroben@apple.com>
1368
1369         Fix <rdar://5133816> keepWebHistory is not implemented
1370
1371         Fixes fast/history/clicked-link-is-visited.html.
1372
1373         Reviewed by Darin.
1374
1375         * DumpRenderTree/win/DumpRenderTree.cpp:
1376         (runTest): Clear the optionalSharedHistory.
1377         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1378         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1379
1380 2007-11-10  Sam Weinig  <sam@webkit.org>
1381
1382         Reviewed by Tim Hatcher.
1383
1384         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1385         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1386         is turned on)
1387
1388         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1389
1390         Added test: http/tests/security/cross-frame-access-private-browsing.html
1391
1392         * DumpRenderTree/LayoutTestController.cpp:
1393         (setPrivateBrowsingEnabledCallback):
1394         (LayoutTestController::staticFunctions):
1395         * DumpRenderTree/LayoutTestController.h:
1396         * DumpRenderTree/mac/DumpRenderTree.mm:
1397         (runTest): Default to private browsing disabled.
1398         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1399         (LayoutTestController::setPrivateBrowsingEnabled):
1400         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1401         (LayoutTestController::setPrivateBrowsingEnabled):
1402
1403 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1404
1405         Reviewed by Adam.
1406
1407         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1408         WebCore's!
1409
1410         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1411         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1412         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1413         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1414         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1415         * Drosera/win/Drosera.cpp:
1416         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1417
1418 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1419
1420         Reviewed by Sam.
1421
1422         - Use the new IWebFrame [local] function signature and get the shared
1423         server correctly.
1424
1425         * Drosera/win/DebuggerClient.cpp:
1426         (DebuggerClient::didFinishLoadForFrame):
1427         * Drosera/win/ServerConnection.cpp:
1428         (ServerConnection::attemptToCreateServerConnection):
1429
1430 2007-11-07  Dan Bernstein  <mitz@apple.com>
1431
1432         Reviewed by Darin Adler.
1433
1434         - add an option to run-webkit-tests to ignore pixel test failures where
1435           all pixels differ by no more than a specified threshold
1436
1437         * DumpRenderTree/mac/ImageDiff.m:
1438         (main):
1439         (compareImages):
1440         (computePercentageDifferent):
1441         * Scripts/run-webkit-tests:
1442
1443 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1444
1445         Reviewed by Lars.
1446
1447         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1448
1449         * DumpRenderTree/qt/DumpRenderTree.cpp:
1450
1451 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1452
1453         Reviewed by Lars.
1454
1455         Reworked the QWebSettings API.
1456         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1457
1458         * DumpRenderTree/qt/DumpRenderTree.cpp:
1459
1460 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1461
1462         Reviewed by Lars.
1463
1464         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1465
1466         * DumpRenderTree/qt/jsobjects.cpp:
1467
1468 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1469
1470         Reviewed by Lars Knoll <lars@trolltech.com>.
1471
1472         Add a QWebPage::frameCreated() signal and fix DRT
1473         
1474         The removal of createFrame in QWebPage broke the re-implementation
1475         in DumpRenderTree. Instead emit a frameCreated() signal and
1476         connect to it in DumpRenderTree.
1477         
1478
1479         * DumpRenderTree/qt/DumpRenderTree.cpp:
1480         (WebCore::WebPage::WebPage):
1481         (WebCore::DumpRenderTree::dump):
1482         (WebCore::DumpRenderTree::connectFrame):
1483         * DumpRenderTree/qt/DumpRenderTree.h:
1484
1485 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1486
1487         Reviewed by Lars Knoll <lars@trolltech.com>.
1488
1489         Moved all the event handlers from QWebFrame into QWebPage.
1490         
1491         This cleans up the public API and allows us to remove the
1492         HackWebFrame hack in DumpRenderTree.
1493         
1494
1495         * DumpRenderTree/qt/jsobjects.cpp:
1496         (EventSender::mouseDown):
1497         (EventSender::mouseUp):
1498         (EventSender::mouseMoveTo):
1499
1500 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1501
1502         Reviewed by Mark.
1503
1504         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1505         to prevent the default implementation from popping up messageboxes.
1506
1507         * DumpRenderTree/qt/DumpRenderTree.cpp:
1508         (WebCore::WebPage::javaScriptConfirm):
1509         (WebCore::WebPage::javaScriptPrompt):
1510
1511 2007-11-06  Eric Seidel  <eric@webkit.org>
1512
1513         * Scripts/build-testkjs: build fix... too many $$
1514
1515 2007-11-06  Eric Seidel  <eric@webkit.org>
1516
1517         Reviewed by Mark Rowe.
1518
1519         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1520
1521 2007-11-05  Adam Roben  <aroben@apple.com>
1522
1523         Add support on Windows for WEBKIT_TESTFONTS
1524
1525         This environment variable lets you specify where the fonts to be used
1526         by DumpRenderTree reside. The Qt port is already using this, so I'm
1527         just following their lead.
1528
1529         Reviewed by Darin.
1530
1531         * DumpRenderTree/win/DumpRenderTree.cpp:
1532         (exePath): Refactored code out of initialize().
1533         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1534         DumpRenderTree.resources.
1535         (initialize): Use the new fontsPath function.
1536         (main): Use the new exePath function.
1537         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1538         variable to DRT, like Qt does.
1539
1540 2007-11-05  Mark Rowe  <mrowe@apple.com>
1541
1542         Rubber-stamped by Alp Toker.
1543
1544         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1545
1546         * GtkLauncher/main.cpp:
1547         (goToURLBarText):
1548         (main):
1549
1550 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1551
1552         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1553         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1554
1555         Reviewed by Timothy.
1556
1557         Restrict the range of nightly builds used by the bisect-builds script
1558         based on the version of Safari and the version of Mac OS X being used.
1559
1560         Mac OS X 10.4: Safari 2.0: r11976 or newer
1561         Mac OS X 10.4: Safari 3.0: r19992 or newer
1562
1563         Mac OS X 10.5: Safari 2.0: r19594 or newer
1564         Mac OS X 10.5: Safari 3.0: r25124 or newer
1565
1566         * Scripts/bisect-builds:
1567         (findMacOSXVersion): Added.
1568         (makeNightlyList): Added argument to provide version of Mac OS X.
1569         Restrict range of nightly builds based on Safari and Mac OS X versions.
1570
1571 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1572
1573         Reviewed by Maciej.
1574
1575         - This patch involves several changes, all of them were noticed that
1576         they were needed by the work being done in WebKit to get Drosera and
1577         WebKit working together on Windows.
1578         - The changes are:
1579         1) Added a debugger console for output messages.
1580         2) Drosera now listens for the WebKit server (before, the server would
1581         have to be running before Drosera was started.)
1582         3) Fixed a bug where the WebView started out as 0x0 pixels.
1583         4) Fixed a bug when there is no scope.
1584         5) Added the HTML, JS, and CSS to the project file to make them easy to
1585         find.
1586         6) Made the ServerConnection functions virtual.
1587
1588         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1589         for the WebKit server.
1590         (DebuggerClient::DebuggerClient):
1591         (DebuggerClient::~DebuggerClient):
1592         (DebuggerClient::didFinishLoadForFrame):
1593         (DebuggerClient::serverConnected):
1594         (DebuggerClient::attemptToCreateServerConnection):
1595         * Drosera/win/DebuggerClient.h: Ditto.
1596         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1597         scope.
1598         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1599         (DebuggerDocument::platformValueForScopeVariableNamed):
1600         * Drosera/win/Drosera.cpp:
1601         (_tWinMain): Added a console in debug for output messages.
1602         (Drosera::Drosera): Listen for server.
1603         (Drosera::initUI): The server now Initializes COM.
1604         (Drosera::serverConnected): Part of the listening for the server.
1605         (Drosera::attemptToCreateServerConnection): Ditto.
1606         * Drosera/win/Drosera.h: New interface for listening for the server.
1607         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1608         files to the VS project.
1609         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1610         connection.
1611         (ServerConnection::ServerConnection):
1612         (ServerConnection::attemptToCreateServerConnection):
1613         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1614         methods.
1615         (ServerConnection::serverConnected):
1616
1617 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1618
1619         Reviewed by Maciej.
1620
1621         http://bugs.webkit.org/show_bug.cgi?id=15832
1622         fast/dom/gc-10.html crashes when run alone
1623
1624         Check for !done before using objects that can be already deallocated.
1625
1626         * DumpRenderTree/mac/EditingDelegate.mm:
1627         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1628         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1629         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1630         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1631         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1632         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1633         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1634         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1635         (-[EditingDelegate webViewDidBeginEditing:]):
1636         (-[EditingDelegate webViewDidChange:]):
1637         (-[EditingDelegate webViewDidEndEditing:]):
1638         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1639         (-[EditingDelegate webViewDidChangeSelection:]):
1640         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1641         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1642         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1643         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1644         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1645         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1646         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1647         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1648         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1649         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1650         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1651         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1652         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1653         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1654         (-[FrameLoadDelegate webView:willCloseFrame:]):
1655         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1656         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1657         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1658         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1659         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1660         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1661         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1662         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1663         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1664
1665 2007-11-04  Mark Rowe  <mrowe@apple.com>
1666
1667         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1668         warnings that would otherwise be suppressed due to it being a system header.
1669
1670         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1671
1672 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1673
1674         Rubber stamped by Adam.
1675         
1676         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1677
1678         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1679
1680 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1681
1682         Sort files(...); sections of Xcode project files.
1683
1684         Rubber-stamped by Darin.
1685
1686         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1687         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1688         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1689         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1690
1691 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1692
1693         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1694
1695         Reviewed by Darin.
1696
1697         * Scripts/sort-Xcode-project-file: Added.
1698
1699 2007-11-02  Darin Adler  <darin@apple.com>
1700
1701         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1702
1703 2007-11-02  Darin Adler  <darin@apple.com>
1704
1705         Reviewed by Maciej.
1706
1707         * Scripts/run-sunspider: Pass the "--base" option through.
1708
1709         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1710         the real script do that. Default configuration to Release to match run-sunspider
1711         so we don't end up building Debug just to compare results.
1712
1713 2007-11-01  Adam Roben  <aroben@apple.com>
1714
1715         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1716
1717         Reviewed by Sam.
1718
1719         * Scripts/commit-log-editor: Show all the directories beneath the
1720         source root, instead of just the last one.
1721
1722 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1723
1724         Reviewed by Adam Roben.
1725
1726         Print out an error message when the Windows build fails
1727         and provide guidance on how to find out what went wrong.
1728
1729         * Scripts/build-webkit:
1730         * Scripts/webkitdirs.pm:
1731
1732 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1733
1734         Rubber-stamped by Adam Roben.
1735
1736         Rolled out r27326 - debug CRT seems to cause no problems after all.
1737
1738         * DumpRenderTree/win/DumpRenderTree.vcproj:
1739
1740 2007-10-31  Adam Roben  <aroben@apple.com>
1741
1742         Switch the Debug configuration to using the non-debug CRT
1743
1744         This matches WebKit.
1745
1746         Reviewed by Steve.
1747
1748         * DumpRenderTree/win/DumpRenderTree.vcproj:
1749
1750 2007-10-31  Antti Koivisto  <antti@apple.com>
1751
1752         Reviewed by bdash.
1753         
1754         Disable media tests when doing leak checking on Tiger.
1755         They crash in QuickTime (rdar://problem/5537157).
1756
1757         * Scripts/run-webkit-tests:
1758
1759 2007-10-29  Antti Koivisto  <antti@apple.com>
1760
1761         Reviewed by Maciej.
1762         
1763         Build media support by default on OSX only.
1764
1765         * Scripts/build-webkit:
1766
1767 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1768
1769         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1770         get caught by the pre-commit hooks.
1771
1772 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1773
1774         Reviewed by Adam.
1775
1776         - This is a collection of relatively unrelated changes and cleanups
1777         to Drosera to prepare it for interacting with WebKit.  A lot of these
1778         changes are just correcting mistakes, for example removing included
1779         headers that are no longer needed.
1780
1781         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1782         this will be needed by the DebuggerClient.
1783         (DebuggerDocument::server):
1784         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1785         * Drosera/win/DebuggerClient.cpp: 
1786         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1787         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1788         (DebuggerClient::createWebViewWithRequest): Added comment about its
1789         purpose. 
1790         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1791         declarations.
1792         (DebuggerClient::webViewLoaded): Moved.
1793         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1794         file, since this was the only place it was used.
1795         (cfStringToBSTR):
1796         * Drosera/win/Drosera.h: Cleaned up the includes.
1797         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1798         * Drosera/win/HelperFunctions.h: Removed.
1799
1800 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1801
1802         Reviewed by Adam.
1803
1804         - Small cleanup in the ServerConnection class.
1805
1806         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1807         and added an include.
1808         (ServerConnection::currentFrame):
1809         (ServerConnection::getCallerFrame):
1810         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1811         made a pointer into a COMPtr, and cleaned up the includes.
1812
1813 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1814
1815         Reviewed by John Sullivan.
1816         
1817         - Place the Localizable.strings file in mac or win directories
1818           if that location exists.
1819         - Also look for UI_STRING in .c files.
1820
1821         * Scripts/extract-localizable-strings:
1822
1823 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1824
1825         Reviewed by Adam.
1826
1827         - Set the eol-style to native and made all the line endings the same
1828         so that I avoid messy diffs that show eol changes.
1829
1830         * Drosera/win/ServerConnection.cpp:
1831         (ServerConnection::didParseSource):
1832         (ServerConnection::didEnterCallFrame):
1833         (ServerConnection::willExecuteStatement):
1834         (ServerConnection::willLeaveCallFrame):
1835         (ServerConnection::exceptionWasRaised):
1836
1837 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1838
1839         Reviewed by Adam.
1840
1841         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1842         functionality that could not have existed previously without the new
1843         interfaces.
1844         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1845         from a BSTR to a JSValueRef.
1846         (DebuggerDocument::platformEvaluateScript): Implemented.
1847         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1848         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1849         Implemented.
1850         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1851         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1852         * Drosera/win/ServerConnection.cpp: Added a helper function.
1853         (ServerConnection::getCallerFrame):
1854         * Drosera/win/ServerConnection.h: Added a helper function.
1855
1856 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1857
1858         updated reviewers for my previous changelog.
1859
1860 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1861         Reviewed by Maciej and Adam and Geoff.
1862
1863         - Minor mac-side improvements including moving a function to a more
1864         appropriate location, fixing a warning, and correctly checking
1865         exceptions.
1866
1867         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1868         (DebuggerDocument::willExecuteStatement):
1869         (DebuggerDocument::didEnterCallFrame):
1870         (DebuggerDocument::willLeaveCallFrame):
1871         (DebuggerDocument::windowScriptObjectAvailable):
1872         (DebuggerDocument::callFunctionOnObject):
1873         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1874         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1875         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1876         because it doesn't require the ServerConnection at all.
1877         (NSStringCreateWithJSStringRef): Made an argument const.
1878         (JSValueRefCreateWithNSString): Made an argument const.
1879         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1880         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1881         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1882         * Drosera/mac/ServerConnection.mm: Ditto.
1883         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1884
1885 2007-10-29  Sam Weinig  <sam@webkit.org>
1886
1887         Reviewed by Adam Roben.
1888
1889         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1890
1891         * DumpRenderTree/LayoutTestController.cpp:
1892         (LayoutTestController::LayoutTestController):
1893         (getGlobalFlagCallback):
1894         (setGlobalFlagCallback):
1895         (LayoutTestController::getJSClass):
1896         (LayoutTestController::staticValues):
1897         * DumpRenderTree/LayoutTestController.h:
1898         (LayoutTestController::globalFlag):
1899         (LayoutTestController::setGlobalFlag):
1900
1901 2007-10-29  Darin Adler  <darin@apple.com>
1902
1903         Reviewed by Maciej.
1904
1905         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1906         resolution instead of its default.
1907
1908 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1909
1910         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1911
1912         Reviewed by Mark Rowe.
1913
1914         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1915         was successfully resolved, but this would not show any status because the change had
1916         already been cached in the index using "git add".  The solution is to add an optional
1917         second argument to showStatus() which adds the "--cached" switch to the command.
1918
1919         * Scripts/resolve-ChangeLogs:
1920         (showStatus):
1921
1922 2007-10-28  Eric Seidel  <eric@webkit.org>
1923
1924         Reviewed by Maciej and Geoff, in unison.
1925
1926         * Scripts/run-webkit-tests: remove broken --svg option
1927
1928 2007-10-28  Darin Adler  <darin@apple.com>
1929
1930         Reviewed by Adam.
1931
1932         * Scripts/run-sunspider: Default to "Release" configuration rather than
1933         defaulting to the last configuration used as other scripts do. This can
1934         still be overriden on the command line with "--debug" if there's some
1935         reason to do so. Also fix a typo.
1936
1937         * Scripts/sunspider-compare-results: Fix a typo.
1938
1939 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1940
1941         Reviewed by Adam.
1942
1943         - Implemented the WebScriptDebugListener functions now that the
1944         WebScriptDebugServer exists
1945
1946         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1947         functions.
1948         (ServerConnection::currentFrame):
1949         (ServerConnection::didLoadMainResourceForDataSource):
1950         (ServerConnection::didParseSource):
1951         (ServerConnection::failedToParseSource):
1952         (ServerConnection::didEnterCallFrame):
1953         (ServerConnection::willExecuteStatement):
1954         (ServerConnection::willLeaveCallFrame):
1955         (ServerConnection::exceptionWasRaised):
1956         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1957         members arguments list.
1958
1959 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1960
1961         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1962         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1963
1964         Reviewed by Darin.
1965
1966         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1967         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1968         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1969         file.  Note that it may also be used as a stand-alone script.
1970
1971         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1972         * Scripts/resolve-ChangeLogs: Added.
1973         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1974
1975 2007-10-26  Mark Rowe  <mrowe@apple.com>
1976
1977         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1978         to the Qt port on the assumption that it was an implementation of the cross-platform
1979         LayoutTestController class.  It is not, so it did not need to be changed.
1980
1981         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1982
1983 2007-10-25  Mark Rowe  <mrowe@apple.com>
1984
1985         Reviewed by Maciej.
1986
1987         Fix builds with code coverage enabled.
1988
1989         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1990
1991 2007-10-25  Darin Adler  <darin@apple.com>
1992
1993         Reviewed by Mark Rowe.
1994
1995         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1996         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1997
1998 2007-10-25  Stephanie  <slewis@apple.com>
1999
2000         build Fix
2001
2002         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2003
2004 2007-10-25  Stephanie  <slewis@apple.com>
2005
2006         Reviewed by Mark Rowe, Adam Roben.
2007
2008         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2009
2010         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2011
2012 2007-10-25  Alice Liu  <alice.liu@apple.com>
2013
2014         Reviewed by Adam.
2015
2016         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2017
2018         Moving destructor into platform-specific files
2019         * DumpRenderTree/LayoutTestController.cpp:
2020         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2021         (LayoutTestController::~LayoutTestController):
2022         * DumpRenderTree/qt/jsobjects.cpp:
2023         (LayoutTestController::~LayoutTestController):
2024
2025         LayoutTestController wasn't being destroyed
2026         * DumpRenderTree/win/DumpRenderTree.cpp:
2027         (runTest):
2028
2029         Added declspec
2030         * DumpRenderTree/win/EditingDelegate.h:
2031
2032         Reset certain values on the webview (or related delegate) that might 
2033         have changed while running a test
2034         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2035         (LayoutTestController::~LayoutTestController):
2036
2037 2007-10-25  Adam Roben  <aroben@apple.com>
2038
2039         Make sunspider-compare-results work with relative paths
2040
2041         Reviewed by Sam.
2042
2043         * Scripts/sunspider-compare-results: Convert arguments to absolute
2044         paths before we chdir.
2045
2046 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2047
2048         Reviewed by Sam.
2049
2050         - Implemented server calls now the WebScriptDebugServer exists.
2051         - Also removed no longer needed call to initialize CG.
2052
2053         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2054         automatically now.
2055         (_tWinMain):
2056         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2057         (ServerConnection::ServerConnection):
2058         (ServerConnection::~ServerConnection):
2059         (ServerConnection::pause):
2060         (ServerConnection::resume):
2061         (ServerConnection::stepInto):
2062         (ServerConnection::applicationTerminating):
2063         (ServerConnection::serverConnectionDidDie):
2064         * Drosera/win/ServerConnection.h: Now uses the COM class.
2065
2066 2007-10-24  George Staikos  <staikos@kde.org>
2067
2068         Unbreak Qt build.
2069
2070         * Scripts/build-webkit:
2071
2072 2007-10-24  Adam Roben  <aroben@apple.com>
2073
2074         Remove now-unnecessary call to InitializeCoreGraphics
2075
2076         WebKit takes care of this now.
2077
2078         Reviewed by Ada.
2079
2080         * DumpRenderTree/win/DumpRenderTree.cpp:
2081         (initialize):
2082
2083 2007-10-24  Adam Roben  <aroben@apple.com>
2084
2085         Use WebTextRenderer in DRT
2086
2087         Reviewed by Ada.
2088
2089         * DumpRenderTree/win/DumpRenderTree.cpp:
2090         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2091
2092 2007-10-24  Sven Herzberg  <sven@imendio.com>
2093
2094         Reviewed by Mark Rowe.
2095
2096         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2097         Bug 15614: [GTK] qmake based backends don't build on OS X
2098
2099         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2100         GTK backend on a Mac
2101         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2102         isDarwin() to make it reusable in other places (like the workaround-
2103         for-prebuilt-qmake in build-webkit)
2104
2105 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2106
2107         Refurbish update-webkit script.
2108
2109         Reviewed by Adam.
2110
2111         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2112         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2113         multi-argument version of system() for flexibility and security.  Check for existence
2114         of Internal directory using -d test instead of -x.
2115
2116 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2117
2118         Minor clean-up of prepare-ChangeLog script.
2119
2120         Reviewed by Adam.
2121
2122         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2123         of a string.  Use multi-argument versions of open() and system() for flexibility and
2124         security.
2125
2126 2007-10-24  Alice Liu  <alice.liu@apple.com>
2127
2128         Reviewed by Oliver.
2129
2130         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2131
2132         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2133         replay the saved events when we're still processing the mousedown that starts the drag
2134         * DumpRenderTree/win/EventSender.cpp:
2135         (doMouseMove):
2136         * DumpRenderTree/win/UIDelegate.cpp:
2137         (UIDelegate::doDragDrop):
2138
2139 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2140
2141         Reviewed by Sam, Steve and Darin.
2142
2143         - Stubbed out the WebScriptDebugListener functionality in the Server
2144         Connection class to prepare it for receiving those callbacks.
2145         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2146         and the ServerConnection to not need to be initialized with a server
2147         name, since that is not the way we connect to the WebKit server. 
2148
2149         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2150         no exception.  Now it only loggs when there is an exception
2151         (DebuggerDocument::willExecuteStatement):
2152         (DebuggerDocument::didEnterCallFrame):
2153         (DebuggerDocument::willLeaveCallFrame):
2154         (DebuggerDocument::windowScriptObjectAvailable):
2155         (DebuggerDocument::callFunctionOnObject):
2156         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2157         to be instantiated with a server's name.
2158         (DebuggerClient::DebuggerClient):
2159         (DebuggerClient::didFinishLoadForFrame):
2160         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2161         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2162         a server name.
2163         (Drosera::init):
2164         (Drosera::initServer):
2165         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2166         instantiated with a server's name.
2167         * Drosera/win/ServerConnection.cpp: 
2168         (ServerConnection::ServerConnection): No longer needs a server name
2169         (ServerConnection::~ServerConnection): Only release the global context
2170         if there is one.
2171         (ServerConnection::serverConnectionDidDie): Stub for
2172         IWebScriptDebugListener
2173         (ServerConnection::QueryInterface): ditto
2174         (ServerConnection::AddRef): ditto
2175         (ServerConnection::Release): ditto
2176         (ServerConnection::didLoadMainResourceForDataSource): ditto
2177         (ServerConnection::didParseSource): ditto
2178         (ServerConnection::failedToParseSource): ditto
2179         (ServerConnection::didEnterCallFrame): ditto
2180         (ServerConnection::willExecuteStatement): ditto
2181         (ServerConnection::willLeaveCallFrame): ditto
2182         (ServerConnection::exceptionWasRaised): ditto
2183         * Drosera/win/ServerConnection.h: Stubbed out the
2184         IWebScriptDebugListener functions, and this class no longer needs to be
2185         instantiated with a server name.
2186
2187 2007-10-24  Lars Knoll  <lars@trolltech.com>
2188
2189         Reviewed by Simon.
2190
2191         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2192
2193         * DumpRenderTree/qt/jsobjects.h:
2194
2195 2007-10-24  Lars Knoll  <lars@trolltech.com>
2196
2197         Reviewed by Simon.
2198
2199         add another command.
2200
2201         * DumpRenderTree/qt/jsobjects.cpp:
2202         (TextInputController::doCommand):
2203
2204 2007-10-24  Lars Knoll  <lars@trolltech.com>
2205
2206         Reviewed by Simon.
2207
2208         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2209
2210         * DumpRenderTree/qt/jsobjects.cpp:
2211         (EventSender::keyDown):
2212         * DumpRenderTree/qt/jsobjects.h:
2213
2214 2007-10-24  Lars Knoll  <lars@trolltech.com>
2215
2216         Reviewed by Simon.
2217
2218         implement eventSender.keyDown().
2219
2220         * DumpRenderTree/qt/jsobjects.cpp:
2221         (EventSender::keyDown):
2222
2223 2007-10-24  Lars Knoll  <lars@trolltech.com>
2224
2225         Reviewed by Simon.
2226
2227         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2228
2229         * DumpRenderTree/qt/DumpRenderTree.cpp:
2230         (WebCore::DumpRenderTree::DumpRenderTree):
2231         (WebCore::DumpRenderTree::initJSObjects):
2232         * DumpRenderTree/qt/jsobjects.cpp:
2233         (TextInputController::doCommand):
2234
2235 2007-10-24  Lars Knoll  <lars@trolltech.com>
2236
2237         Reviewed by Simon.
2238
2239         first bit of implementation for the textinputcontroller.
2240
2241         * DumpRenderTree/qt/DumpRenderTree.cpp:
2242         (WebCore::DumpRenderTree::DumpRenderTree):
2243         * DumpRenderTree/qt/DumpRenderTree.h:
2244         * DumpRenderTree/qt/jsobjects.cpp:
2245         (TextInputController::TextInputController):
2246         (TextInputController::doCommand):
2247         * DumpRenderTree/qt/jsobjects.h:
2248
2249 2007-10-24  Lars Knoll  <lars@trolltech.com>
2250
2251         Reviewed by Simon.
2252
2253         make the man webpage believe it has focus, so the editing tests work correctly.
2254
2255         * DumpRenderTree/qt/DumpRenderTree.cpp:
2256         (WebCore::DumpRenderTree::DumpRenderTree):
2257
2258 2007-10-24  Lars Knoll  <lars@trolltech.com>
2259
2260         Reviewed by Simon.
2261
2262         implement layoutTestController.dumpEditingCallbacks() correctly.
2263
2264         * DumpRenderTree/qt/DumpRenderTree.cpp:
2265         (WebCore::DumpRenderTree::DumpRenderTree):
2266         * DumpRenderTree/qt/jsobjects.cpp:
2267         (LayoutTestController::reset):
2268         (LayoutTestController::dumpEditingCallbacks):
2269
2270 2007-10-24  Lars Knoll  <lars@trolltech.com>
2271
2272         Reviewed by Simon.
2273
2274         Implement support for testing editing.
2275
2276         * DumpRenderTree/qt/DumpRenderTree.cpp:
2277         (WebCore::DumpRenderTree::DumpRenderTree):
2278
2279 2007-10-23  Sam Weinig  <sam@webkit.org>
2280
2281         Check for null BSTR that can be passed to the UIDelegate methods
2282         from javascript null and undefined.  Fixes a failing test case on
2283         Windows (fast/dom/Window/alert-undefined.html)
2284
2285         Reviewed by Eric Seidel.
2286
2287         * DumpRenderTree/win/UIDelegate.cpp:
2288         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2289         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2290         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2291         (UIDelegate::webViewAddMessageToConsole):
2292
2293 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2294
2295         Reviewed by Darin.
2296         
2297         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2298
2299         * Scripts/build-testkjs:
2300
2301 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2302
2303         Reviewed by Darin.
2304
2305         - add wrapper that finds the right copy of testkjs
2306         
2307         * Scripts/sunspider-compare-results: Added.
2308
2309 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2310
2311         Reviewed by Sam.
2312
2313         - After talking with Steve I now see that the WebKit server must be
2314         running for DCOM to create the distributed objects, which makes sense
2315         and currently WebKit only allows one instance to be running at a time
2316         which avoids accidentally connecting to the wrong server
2317         - In light of this I have removed the code for the attach box and
2318         NotificationServer and known server names, since they are all extranious
2319         now.
2320
2321         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2322         names.
2323         (_tWinMain): Uses init instead of initUI.
2324         (droseraWndProc): No longer creats an attach dialog box.
2325         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2326         it's not manditory to call init before doing COM stuff.
2327         (Drosera::init): calls initUI and will call attach when the
2328         functionality exists. 
2329         (Drosera::initUI): Has changed very little.
2330         (Drosera::attach): Changed the signature to reflect that we no longer
2331         need the dictionary of known server names.
2332         * Drosera/win/Drosera.h: Removed notification classes and known server
2333         names.  Also renamed and moved some functions.
2334         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2335         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2336         headers to the resources folder. 
2337         * Drosera/win/resource.h: Removed the Attach box.
2338
2339 2007-10-22  Adam Roben  <aroben@apple.com>
2340
2341         Windows build fix
2342
2343         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2344
2345 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2346
2347         - Removed a leak that was fixed.
2348
2349         * Scripts/run-webkit-tests:
2350
2351 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2352
2353         Reviewed by Darin.
2354
2355         - Changed the Client so that the DebuggerDocument now own the
2356         ServerConnection.  This simplifies ownership and cleanup. 
2357
2358         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2359         ServerConnection.
2360         (DebuggerClient::initWithServerName):
2361         (DebuggerClient::didFinishLoadForFrame):
2362         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2363         ServerConnection.
2364         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2365         until after we have a server which we are attached to.
2366         (Drosera::initUI):
2367         (Drosera::attach):
2368         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2369         out previously.
2370
2371 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2372
2373         Reviewed by Nikolas.
2374
2375         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2376
2377         * Scripts/run-javascriptcore-tests:
2378
2379 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2380
2381         Reviewed by Nikolas.
2382
2383         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2384
2385         * Scripts/build-drosera:
2386         * Scripts/build-dumprendertree:
2387         * Scripts/build-testkjs:
2388         * Scripts/build-webkit:
2389         * Scripts/run-javascriptcore-tests:
2390         * Scripts/run-sunspider:
2391         * Scripts/run-webkit-tests:
2392         * Scripts/webkitdirs.pm:
2393
2394 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2395
2396         Reviewed by Mark Rowe.
2397         
2398         Fix for local database support after r26879
2399         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2400
2401         * Scripts/build-webkit:
2402
2403 2007-10-22  Holger Freyther  <zecke@selfish.org>
2404
2405         Reviewed by Simon Hausmann <hausmann@kde.org>.
2406
2407         - Do not build testkjs as an application bundle. This is
2408         needed for run-javascriptcore-tests on OSX.
2409         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2410         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2411         as we do not have -rpath on OSX.
2412
2413         * DumpRenderTree/qt/DumpRenderTree.pro:
2414         * Scripts/run-webkit-tests:
2415
2416 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2417
2418         Reviewed by aroben.
2419
2420         Fix support for Signed-off-by detection in prepare-ChangeLog
2421         --git-commit. The Signed-off-by tag does not appear in the header
2422         but usually at the end.
2423
2424         * Scripts/prepare-ChangeLog:
2425
2426 2007-10-21  Mark Rowe  <mrowe@apple.com>
2427
2428         Reviewed by Eric.
2429
2430         Fix run-javascriptcore-tests for Gtk.
2431
2432         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2433
2434 2007-10-20  Eric Seidel  <eric@webkit.org>
2435
2436         Reviewed by aroben.
2437
2438         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2439
2440 2007-10-20  Eric Seidel  <eric@webkit.org>
2441
2442         Reviewed by darin.
2443         
2444         Add improved argument handling to run-sunspider, including
2445         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2446         Also re-factor code into subroutines
2447
2448         * Scripts/build-dumprendertree: removed bogus comments
2449         * Scripts/build-testkjs: Added.
2450         * Scripts/run-javascriptcore-tests: use build-testkjs
2451         * Scripts/run-sunspider: improved argument handling, abstraction
2452         * Scripts/run-webkit-tests: improved abstraction
2453
2454 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2455
2456         Not reviewed, Windows build fix.
2457
2458         * DumpRenderTree/win/EventSender.cpp:
2459         (keyDownCallback):
2460
2461 2007-10-20  Darin Adler  <darin@apple.com>
2462
2463         Reviewed by Tim Hatcher.
2464
2465         - http://bugs.webkit.org/show_bug.cgi?id=15544
2466           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2467           not rely on Apple-specific key codes
2468
2469         * DumpRenderTree/mac/EventSendingController.mm:
2470         (-[EventSendingController keyDown:withModifiers:]):
2471         Added named key "rightArrow". Later we could have a whole table of these.
2472         Also tweaked modifiers code a little.
2473
2474         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2475
2476 2007-10-19  Darin Adler  <darin@apple.com>
2477
2478         Reviewed by Eric.
2479
2480         - http://bugs.webkit.org/show_bug.cgi?id=15566
2481           possible fix for leak seen in DumpRenderTree
2482
2483         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2484         Delete the item if it's not put on the queue, since the caller has
2485         no way of knowing that. Would be better to have the parameter type
2486         be auto_ptr to express the fact that we take ownership.
2487
2488         - unrelated change
2489
2490         * Drosera/mac/main.m: Add missing include.
2491
2492 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2493
2494         Reviewed by Adam.
2495
2496         - This change should be identical but for some reason was not working
2497         on my machine.
2498
2499         * Scripts/prepare-ChangeLog:
2500
2501 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2502
2503         Reviewed by Oliver and Tim.
2504
2505         - Made use of RetainPtr to avoid retain and release issues and moved the
2506         log function to DebuggerDocumentPlatform, which seems to be a more
2507         logical place for it to live.
2508         - Also moved knownServers from the ServerConnection to
2509         DebuggerApplication to match the Windows code and because it makes sense
2510         that a connection knows its own server but not all of them.
2511
2512         * Drosera/mac/DebuggerClient.h: Moved the log function to
2513           DebuggerDocumentPlatform.
2514         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2515           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2516           call for the server name up from the ServerConnection class.
2517         (-[DebuggerClient dealloc]):
2518         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2519           for the server name up from the ServerConnection.
2520         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2521         (DebuggerDocument::platformPause):
2522         (DebuggerDocument::platformResume):
2523         (DebuggerDocument::platformStepInto):
2524         (DebuggerDocument::platformEvaluateScript):
2525         (DebuggerDocument::getPlatformCurrentFunctionStack):
2526         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2527         (DebuggerDocument::platformValueForScopeVariableNamed):
2528         (DebuggerDocument::platformLog): Log directly from here. No need to call
2529           DebuggerClient.
2530         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2531           way I see it, a ServerConnection should only know about its connection
2532           and the group of all possible servers should be kept by the
2533           application.
2534         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2535           currentServerName, it makes sense that the connection should know that
2536           name.
2537         (-[ServerConnection currentServerName]):
2538
2539 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2540
2541         Reviewed by Adam.
2542
2543         - Integrated changes from mac drosera.  Recently I've encapsulated
2544         out the server connection object from the rest of Drosera because
2545         it is very platform dependent right now and RPC is not implemented on
2546         windows.  This functionality, of communicating with the WebKit server
2547         is the next area I will be focusing on in Windows.
2548
2549         - Other changes and cleanup were made to organize the code and add notes
2550         on which parts still need work.  Also some mac code is added and
2551         commented out, to act as pseudocode for the logic of those parts.
2552
2553         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2554           pointer.
2555         * Drosera/config.h: Added whitespace.
2556         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2557           these files got moved into Drosera.h/cpp
2558         * Drosera/win/DebuggerApplication.h: Removed.
2559         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2560           happened here to better match the logic flow of the same code on the 
2561           mac side and to use the new ServerConnection class.
2562         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2563         (DebuggerClient::initWithServerName): Initializer that will set up the
2564           class to use a ServerConnection object.  This was necessary so I could
2565           create a DebuggerClient without having to initilaize it at
2566           construction.
2567         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2568           will be the UIDelegate and FrameLoadDelegate.
2569         (DebuggerClient::AddRef): For IUnknown.
2570         (DebuggerClient::Release): For IUnknown.
2571         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2572           this still needs to set the global context of the server, but
2573           IWebFrame does not have an accessor for the global context yet. 
2574         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2575           this is a pass through for the same function in the document.
2576         (DebuggerClient::didReceiveTitle): Unimplemented part of
2577           FrameLoadDelegate this would change the title of the window.
2578         (DebuggerClient::createWebViewWithRequest): Part of the
2579           FrameLoadDelegate.  This is about new windows via Window.open() and
2580           how their delegates are set.
2581         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2582           UIDelegate.  Just a debug function for printing messages.
2583         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2584           because the Client should be the UIDelegate and FrameLoadDelegate
2585           to match the delegates on mac.
2586         (DebuggerClient::webViewLoaded): Added accessor method.
2587         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2588           forgotten to add this file before.  This is where the platform
2589           dependent versions of the Documents functions live. Most of these are
2590           unimplemented because some piece of functionality does not exist on
2591           Windows yet.
2592         (DebuggerDocument::platformPause):
2593         (DebuggerDocument::platformResume):
2594         (DebuggerDocument::platformStepInto):
2595         (DebuggerDocument::platformEvaluateScript):
2596         (DebuggerDocument::getPlatformCurrentFunctionStack):
2597         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2598         (DebuggerDocument::platformValueForScopeVariableNamed):
2599         (DebuggerDocument::platformLog):
2600         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2601           responsibilities becaue they belong in the Client. Also I laid the
2602           groundwork for attaching Drosera to a WebKit process
2603         (attachWndProc): Now if a server is selected the Client becomes it's
2604           delegate.
2605         (Drosera::Drosera): Added the construction of the Client and dictionary
2606           of server names. 
2607         (Drosera::initUI): This is no longer the delegates, the Client is.
2608         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2609           state. 
2610         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2611           notification registration when it's possible to implement.
2612         (Drosera::serverLoaded): Ditto
2613         (Drosera::serverUnloaded): Ditto
2614         (Drosera::attach): Attach Drosera to the WebKit server.
2615         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2616         (Drosera::getInst): 
2617         (Drosera::setInst):
2618         (Drosera::knownServers):
2619         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2620           and added the ServerConnection.
2621         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2622         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2623           Most of the functions are completely unimlemented because they cannot
2624           connect with the WebKit server, because one does not exist on Windows
2625           yet.
2626         (ServerConnection::initWithServerName): 
2627         (ServerConnection::~ServerConnection):
2628         (ServerConnection::setGlobalContext):
2629         (ServerConnection::pause):
2630         (ServerConnection::resume):
2631         (ServerConnection::stepInto):
2632         (ServerConnection::switchToServerNamed):
2633         (ServerConnection::applicationTerminating):
2634         (ServerConnection::serverConnectionDidDie):
2635         (ServerConnection::currentFrame):
2636         * Drosera/win/ServerConnection.h: Added. Ditto.
2637         (ServerConnection::ServerConnection):
2638
2639 2007-10-19  Alice Liu  <alice.liu@apple.com>
2640
2641         Reviewed by Darin.
2642
2643         Fix for these broken layout tests on Windows:
2644         
2645         fast/forms/focus-selection-input.html
2646         fast/forms/focus-selection-textarea.html
2647         fast/forms/select-accesskey.html
2648         
2649         * DumpRenderTree/win/EventSender.cpp:
2650         (keyDownCallback):
2651         correct the VK code for alt key.
2652         
2653 2007-10-19  Eric Seidel  <eric@webkit.org>
2654
2655         Reviewed by Mark Rowe.
2656         
2657         Make the GtkLauncher code slightly more readable.
2658
2659         * GtkLauncher/main.cpp:
2660         (setupMainMenu): Added.
2661         (setupMainWindowUI): Added.
2662         (main):
2663
2664 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2665
2666         Rubber stamped by Adam.
2667         
2668         - don't delay-load WebKit in DumpRenderTree.
2669
2670         * DumpRenderTree/win/DumpRenderTree.vcproj:
2671
2672 2007-10-18  Dan Bernstein  <mitz@apple.com>
2673
2674         Reviewed by Adam Roben.
2675
2676         - fix <rdar://problem/5313523>
2677         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2678
2679         * DumpRenderTree/mac/DumpRenderTree.mm:
2680         (dump): Changed to use _responseMIMEType.
2681
2682 2007-10-17  Adam Roben  <aroben@apple.com>
2683
2684         Make it possible to have Windows-specific tests and results
2685
2686         When searching for tests to run and the Skipped file, we will only
2687         look in platform/win and the cross-platform directory. When looking
2688         for expected results, we will look in platform/win, then
2689         platform/mac-leopard, then platform/mac, then finally the
2690         cross-platform directory.
2691
2692         Reviewed by Sam.
2693
2694         * Scripts/run-webkit-tests:
2695         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2696         searching in the cross-platform directory.
2697         (sub buildPlatformHierarchy): Removed some unneeded calls to
2698         dirname/basename.
2699
2700 2007-10-17  Adam Roben  <aroben@apple.com>
2701
2702         Add back the call to register WebKit that we had before WebKitInitializer existed
2703
2704         This is needed to ensure that the right WebKit is used when
2705         instantiating COM objects.
2706
2707         Reviewed by Oliver.
2708
2709         * DumpRenderTree/win/debug_internal.vsprops: Define
2710         DEBUG_WEBKIT_HAS_SUFFIX.
2711         * DumpRenderTree/win/DumpRenderTree.cpp:
2712         (initialize):
2713
2714 2007-10-17  Adam Roben  <aroben@apple.com>
2715
2716         Import File::Basename in webkitdirs since we use it
2717
2718         * Scripts/webkitdirs.pm:
2719
2720 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2721
2722         - Updated the tiger leaks list to make the internal bots green.
2723
2724         * Scripts/run-webkit-tests:
2725
2726 2007-10-17  Adam Roben  <aroben@apple.com>
2727
2728         Build fix for VC++ Express
2729
2730         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2731         and ole32.lib.
2732
2733 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2734
2735         Reviewed by Sam.
2736
2737         - Minor mac improvements based on observations I made while implementing the
2738         Windows code.
2739
2740         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2741         then hand it to the Client who will retain it, it should just be the client who
2742         creates and owns the server.
2743         (-[DebuggerApplication attach:]):
2744         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2745         * Drosera/mac/DebuggerClient.mm: Creates the server.
2746         (-[DebuggerClient initWithServerName:]):
2747         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2748         can instead forward declare what it needs.
2749
2750 2007-10-16  Darin Adler  <darin@apple.com>
2751
2752         Reviewed by Geoff Garen.
2753
2754         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2755         want to turn failing tests into platform-specific test results. Also did a
2756         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2757         would take the type of results into account only some of the time.
2758
2759 2007-10-16  Adam Roben  <aroben@apple.com>
2760
2761         Add a new nightly launcher script for Windows
2762
2763         This new script is for versions of Safari that don't delay-load
2764         WebKit. I had to make FindSafari be able to print out the nightly
2765         launcher script on stdout because Windows shell scripts can't capture
2766         the output from a command into an environment variable.
2767
2768         Reviewed by Steve.
2769
2770         * FindSafari/FindSafari.cpp:
2771         (_tmain): Added /printSafariLauncher option.
2772         * Scripts/run-webkit-nightly.cmd: Added.
2773
2774 2007-10-16  Adam Roben  <aroben@apple.com>
2775
2776         Replace WebKitInitializer with FindSafari
2777
2778         We now rely on setting the PATH environment variable to tell Windows
2779         where to find WebKit and its dependencies (similar to
2780         DYLD_FRAMEWORK_PATH on Mac).
2781
2782         This change also make DumpRenderTree no longer delay-load WebKit.
2783
2784         Reviewed by Sam.
2785
2786         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2787         FindSafari.
2788         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2789         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2790         WebKitInitializer, don't delay-load WebKit.
2791         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2792         * Scripts/run-webkit-tests: Ditto.
2793         * Scripts/webkitdirs.pm:
2794         (sub setPathForRunningWebKitApp): Added.
2795         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2796         * WebKitInitializer/WebKitInitializer.h: Removed.
2797         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2798         * WebKitInitializer/debug.vsprops: Removed.
2799         * WebKitInitializer/debug_internal.vsprops: Removed.
2800         * WebKitInitializer/release.vsprops: Removed.
2801
2802 2007-10-16  Adam Roben  <aroben@apple.com>
2803
2804         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2805
2806         http://bugs.webkit.org/show_bug.cgi?id=15532
2807
2808         FindSafari simply prints the location of an installed Safari.exe on
2809         stdout.
2810
2811         Reviewed by Darin.
2812
2813         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2814         (getStringValue):
2815         (getWebViewCLSID):
2816         (getInstalledWebKitDirectory):
2817         (_tmain):
2818         * FindSafari/FindSafari.vcproj: Added.
2819         * Scripts/webkitdirs.pm:
2820         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2821
2822 2007-10-16  Adam Roben  <aroben@apple.com>
2823
2824         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2825
2826         Reviewed by Kevin McCullough.
2827
2828         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2829         when referring to WebKit.dll.
2830         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2831         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2832         * DumpRenderTree/win/release.vsprops: Ditto.
2833         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2834         never have a _debug suffix on WebKit.dll.
2835         * WebKitInitializer/WebKitInitializer.cpp:
2836         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2837         specified.
2838         * WebKitInitializer/debug_internal.vsprops: Added
2839         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2840
2841 2007-10-16  Darin Adler  <darin@apple.com>
2842
2843         Reviewed by Adele.
2844
2845         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2846         Remove now-unneeded control/alt key hack; the tests have been updated.
2847
2848 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2849
2850         - Updated leaks list because our internal bot upgraded it's version of leopard and 
2851         one of the leaks was fixed between that revision and the bot's previous version of
2852         leopard.
2853
2854         * Scripts/run-webkit-tests:
2855
2856 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2857
2858         Reviewed by Tim.
2859
2860         - I encapsulated out the server connecton functionality because it is a specific part
2861         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2862         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2863         Windows.  So the majority of this patch is moving preexisting functionality.
2864
2865         - Also I removed the prefix header and changed to use config.h because it is more
2866         standard on how we use config.h in windows and it didn't make much sense to keep
2867         the prefix header and the config.h
2868
2869         * Drosera/DebuggerDocument.cpp:
2870         (DebuggerDocument::DebuggerDocument):
2871         * Drosera/DebuggerDocument.h:
2872         * Drosera/config.h:
2873         * Drosera/mac/DebuggerApplication.mm:
2874         (-[DebuggerApplication attach:]):
2875         * Drosera/mac/DebuggerClient.h:
2876         * Drosera/mac/DebuggerClient.mm:
2877         (-[DebuggerClient initWithServerConnection:]):
2878         (-[DebuggerClient dealloc]):
2879         (-[DebuggerClient windowDidLoad]):
2880         (-[DebuggerClient windowWillClose:]):
2881         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2882         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2883         * Drosera/mac/DebuggerDocumentPlatform.mm:
2884         (DebuggerDocument::platformPause):
2885         (DebuggerDocument::platformResume):
2886         (DebuggerDocument::platformStepInto):
2887         (DebuggerDocument::platformEvaluateScript):
2888         (DebuggerDocument::getPlatformCurrentFunctionStack):
2889         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2890         (DebuggerDocument::platformValueForScopeVariableNamed):
2891         (DebuggerDocument::platformLog):
2892         * Drosera/mac/Drosera.pch: Removed.
2893         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2894         * Drosera/mac/ServerConnection.h: Added.
2895         * Drosera/mac/ServerConnection.mm: Added.
2896         (-[ServerConnection initWithServerName:]):
2897         (-[ServerConnection dealloc]):
2898         (-[ServerConnection setGlobalContext:]):
2899         (-[ServerConnection pause]):
2900         (-[ServerConnection resume]):
2901         (-[ServerConnection stepInto]):
2902         (-[ServerConnection switchToServerNamed:]):
2903         (-[ServerConnection applicationTerminating:]):
2904         (-[ServerConnection serverConnectionDidDie:]):
2905         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2906         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2907         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2908         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2909         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2910         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2911         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2912         (-[ServerConnection currentFrame]):
2913         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2914         (-[ServerConnection knownServers]):
2915
2916 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2917
2918         Reviewed by Eric.
2919
2920         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2921           Script to automatically search nightly builds for regressions (bisect-builds)
2922
2923         * Scripts/bisect-builds: Added.
2924
2925 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2926
2927         Reviewed by Darin.
2928
2929         - New JavaScript benchmark
2930         http://bugs.webkit.org/show_bug.cgi?id=15515
2931
2932         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2933         current development or release build of JavaScriptCore.
2934
2935 2007-10-15  Mark Rowe  <mrowe@apple.com>
2936
2937         Reviewed by Sam.
2938
2939         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2940
2941         * Scripts/webkitdirs.pm:
2942         - Change checkArgv to remove the options from @ARGV to prevent
2943         them from interfering with further option processing.
2944         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2945         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2946         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2947         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2948
2949 2007-10-15  Darin Adler  <darin@apple.com>
2950
2951         Reviewed by Sam.
2952
2953         - added logging of window.prompt and window.confirm
2954
2955         * DumpRenderTree/mac/UIDelegate.mm:
2956         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2957         Implement the recommended delegate rather than the deprecated one.
2958         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2959         Added.
2960         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2961         Added.
2962
2963         * DumpRenderTree/win/UIDelegate.h:
2964         * DumpRenderTree/win/UIDelegate.cpp:
2965         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2966         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2967         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2968         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2969
2970 2007-10-15  Alice Liu  <alice.liu@apple.com>
2971
2972         Reviewed by Sam Weinig.
2973
2974         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2975
2976         * DumpRenderTree/win/DumpRenderTree.cpp:
2977         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2978         (main): allocate the global policy delegate for DRT's custom use
2979         * DumpRenderTree/win/DumpRenderTree.vcproj:
2980         Adding files to project
2981         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2982         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2983         (LayoutTestController::setCustomPolicyDelegate):
2984         set the webview's policy delegate to DRT's custom one if the test requests it.
2985         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2986         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2987         (PolicyDelegate::PolicyDelegate):
2988         (PolicyDelegate::QueryInterface):
2989         (PolicyDelegate::AddRef):
2990         (PolicyDelegate::Release):
2991         (PolicyDelegate::decidePolicyForNavigationAction):
2992         * DumpRenderTree/win/PolicyDelegate.h: Added.
2993         (PolicyDelegate::decidePolicyForNewWindowAction):
2994         (PolicyDelegate::decidePolicyForMIMEType):
2995         (PolicyDelegate::unableToImplementPolicyWithError):
2996
2997 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2998
2999         Reviewed by Mark.
3000
3001         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3002         when querying for QMAKE_MKSPECS.
3003
3004 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3005
3006         Reviewed by Adam Roben.
3007         
3008         Fix run-webkit-tests is too greedy calculating platform hierarchy
3009         http://bugs.webkit.org/show_bug.cgi?id=15465
3010         
3011         Fix run-webkit-tests being too greedy in trying to split the platform name up
3012         causing it to try and find tests in every directory above the first "-" in the
3013         path to the LayoutTests
3014
3015         * Scripts/run-webkit-tests:
3016
3017 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3018
3019         Reviewed by Darin.
3020
3021         http://bugs.webkit.org/show_bug.cgi?id=15006
3022         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3023         to reduce code duplication.
3024
3025         * Scripts/build-webkit:
3026         * Scripts/webkitdirs.pm:
3027         buildQMakeProject() renamed to buildQMakeQtProject().
3028         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3029         unused $colorize has been removed.
3030
3031 === Start merge of feature-branch 2007-10-12 ===
3032
3033 2007-10-08  Eric Seidel  <eric@webkit.org>
3034
3035         Reviewed by Mark Rowe.
3036
3037         * Scripts/build-webkit: add --help, remove unused --color
3038
3039 2007-10-07  Eric Seidel  <eric@webkit.org>
3040
3041         Reviewed by darin.
3042
3043         * Drosera/mac/DebuggerDocumentPlatform.mm:
3044         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3045
3046 2007-10-03  Rob Buis  <buis@kde.org>
3047
3048         Reviewed by Olliej.
3049
3050         Adapt to changed location of Ahem font.
3051
3052         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3053
3054 2007-10-02  Eric Seidel  <eric@webkit.org>
3055
3056         Reviewed by Adam Roben.
3057         
3058         Make pixel tests more useful!
3059         Finally fix the image diff 0.00% mystery problem
3060         Highlight any image differences in the image diff.
3061         Add a link from image diffs back to original test file.
3062
3063         * DumpRenderTree/mac/ImageDiff.m:
3064         (compareImages): highlight any differences
3065         (computePercentageDifferent): round to two decimal places
3066         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3067
3068 2007-10-02  Eric Seidel  <eric@webkit.org>
3069
3070         Reviewed by Alexey Proskuryakov.
3071
3072         * Scripts/run-webkit-tests: print the % image difference on main results page
3073
3074 2007-10-02  Mark Rowe  <mrowe@apple.com>
3075
3076         Reviewed by Oliver.
3077
3078         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3079
3080         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3081         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3082
3083 2007-10-01  Mark Rowe  <mrowe@apple.com>
3084
3085         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3086
3087 2007-09-25  Eric Seidel  <eric@webkit.org>
3088
3089         Reviewed by Mark Rowe.
3090         
3091         DerivedSources.make was finding "ENABLE_SVG" in the string
3092         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3093         quite correctly.
3094
3095         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3096
3097 2007-09-25  Mark Rowe  <mrowe@apple.com>
3098
3099         Rubber-stamped by Eric.
3100
3101         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3102         This makes it possible to automate nightly builds for the feature-branch.
3103
3104 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3105
3106         Rubber stamped by Mark.
3107
3108         Enable svg experimental features as default here in feature-branch.
3109
3110         * Scripts/build-webkit:
3111
3112 2007-06-29  Antti Koivisto  <antti@apple.com>
3113
3114         Reviewed by Weinig.
3115         
3116         Add VIDEO flag for timed media features
3117
3118         * Scripts/build-webkit
3119         
3120 === End merge of feature-branch 2007-10-12 ===
3121
3122 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3123
3124         Reviewed by Darin.
3125
3126         - Updated rational for the leaks list to be more clear.
3127
3128         * Scripts/run-webkit-tests:
3129
3130 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3131
3132         Rubber Stamp by Sam.
3133
3134         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3135         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3136
3137         * Scripts/run-webkit-tests:
3138
3139 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3140
3141         Reviewed by Lars.
3142
3143         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3144         includes are needed for INT_MAX, std::auto_ptr and the like.
3145
3146         * DumpRenderTree/qt/main.cpp:
3147
3148 2007-10-09  Lars Knoll  <lars@trolltech.com>
3149
3150         Reviewed by Simon.
3151
3152         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3153
3154         * DumpRenderTree/qt/jsobjects.cpp:
3155         (LayoutTestController::encodeHostName):
3156         (LayoutTestController::decodeHostName):
3157         * DumpRenderTree/qt/jsobjects.h:
3158
3159 2007-10-09  Lars Knoll  <lars@trolltech.com>
3160
3161         Reviewed by Simon.
3162
3163         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3164
3165         * DumpRenderTree/qt/DumpRenderTree.cpp:
3166         (WebCore::WebPage::createFrame):
3167         (WebCore::DumpRenderTree::DumpRenderTree):
3168         (WebCore::DumpRenderTree::titleChanged):
3169         * DumpRenderTree/qt/DumpRenderTree.h:
3170         * DumpRenderTree/qt/jsobjects.cpp:
3171         (LayoutTestController::reset):
3172         * DumpRenderTree/qt/jsobjects.h:
3173
3174 2007-10-09  Lars Knoll  <lars@trolltech.com>
3175
3176         Reviewed by Simon.
3177
3178         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3179
3180         * DumpRenderTree/qt/DumpRenderTree.h:
3181         * DumpRenderTree/qt/jsobjects.cpp:
3182         (LayoutTestController::clearBackForwardList):
3183         * DumpRenderTree/qt/jsobjects.h:
3184
3185 2007-10-09  Lars Knoll  <lars@trolltech.com>
3186
3187         Reviewed by Simon.
3188
3189         make --git-reviewer work again.
3190
3191         * Scripts/prepare-ChangeLog:
3192
3193 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3194
3195         Rubber stamped by Eric.
3196
3197         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3198         show the current link inside the statusbar.
3199         This shows how to make use of this signal and allows to easily test
3200         http://bugs.webkit.org/show_bug.cgi?id=15299.
3201
3202         * GtkLauncher/main.cpp:
3203         (hoveringOverLink):
3204         (main):
3205
3206 2007-10-05  Lars Knoll  <lars@trolltech.com>
3207
3208         add proper error messages to the FrameLoaderClient.
3209         Implement ChromeClientQt::closeWindowSoon and
3210         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3211         Some fixes in DRT to make it work correctly with multiple windows.
3212
3213         Reviewed by Maciej.
3214
3215         * DumpRenderTree/qt/DumpRenderTree.cpp:
3216         (WebCore::DumpRenderTree::DumpRenderTree):
3217         (WebCore::DumpRenderTree::createWindow):
3218         (WebCore::DumpRenderTree::windowCount):
3219         * DumpRenderTree/qt/DumpRenderTree.h:
3220         * DumpRenderTree/qt/jsobjects.cpp:
3221         (LayoutTestController::maybeDump):
3222         (LayoutTestController::windowCount):
3223         * DumpRenderTree/qt/jsobjects.h:
3224
3225 2007-10-05  Lars Knoll  <lars@trolltech.com>
3226
3227         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3228         Add support for layoutTextController.setCanOpenWindows() to DRT
3229         fixing another 2 test cases in fast/dom/Window.
3230
3231         Reviewed by Maciej.
3232
3233         * DumpRenderTree/qt/DumpRenderTree.cpp:
3234         (WebCore::WebPage::WebPage):
3235         (WebCore::WebPage::createWindow):
3236         (WebCore::DumpRenderTree::resetJSObjects):
3237         (WebCore::DumpRenderTree::createWindow):
3238         * DumpRenderTree/qt/DumpRenderTree.h:
3239         * DumpRenderTree/qt/DumpRenderTree.pro:
3240         * DumpRenderTree/qt/jsobjects.cpp:
3241         (LayoutTestController::LayoutTestController):
3242         (LayoutTestController::reset):
3243         * DumpRenderTree/qt/jsobjects.h:
3244         * DumpRenderTree/qt/main.cpp:
3245         * DumpRenderTree/qt/testplugin.cpp: Added.
3246         * DumpRenderTree/qt/testplugin.h: Added.
3247
3248 2007-10-04  Sam Weinig  <sam@webkit.org>
3249
3250         Rubber stamped by Adam.
3251
3252         Remove empty directories.
3253
3254         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3255         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3256
3257 2007-10-03  Darin Adler  <darin@apple.com>
3258
3259         Reviewed by Adam.
3260
3261         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3262         we find the internal libraries in the libraries directory. This
3263         is helpful for Safari team engineers at Apple.
3264
3265 2007-10-03  Adam Roben  <aroben@apple.com>
3266
3267         Update the location of AHEM___.TTF after r25968
3268
3269         Reviewed by Sam.
3270
3271         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3272
3273 2007-10-03  Alp Toker  <alp@atoker.com>
3274
3275         Reviewed by Adam.
3276
3277         http://bugs.webkit.org/show_bug.cgi?id=14726
3278         [gtk] API design. Mapping the WebView delegates to signals.
3279
3280         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3281
3282         * GtkLauncher/main.cpp:
3283         (goToURLBarText):
3284         (titleChanged):
3285         (progressChanged):
3286         (menuMainBackCallback):
3287         (menuMainForwardCallback):
3288         (main):
3289
3290 2007-10-03  Lars Knoll  <lars@trolltech.com>
3291
3292         Reviewed by Rob.
3293
3294         This fixes --strict mode in run-webkit-tests again after
3295         the platform dependent test results have been moved.
3296
3297         * Scripts/run-webkit-tests:
3298
3299 2007-10-03  Lars Knoll  <lars@trolltech.com>
3300
3301         Reviewed by bdash.
3302
3303         remove the hack in run-webkit-tests that forced text only test
3304         to be taken from the platform independent dir. It was only left
3305         there from early days.
3306         
3307         Remove platform dependent results for tests that are text only nowadays,
3308         and add one platform dependent result for a text only test that requires it.
3309
3310         * Scripts/run-webkit-tests:
3311
3312 2007-10-03  Lars Knoll  <lars@trolltech.com>
3313
3314         Reviewed by olliej.
3315
3316         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3317
3318         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3319         (WebCore::WebFrame::WebFrame):
3320         (WebCore::WebPage::WebPage):
3321         (WebCore::WebPage::createFrame):
3322         (WebCore::WebPage::javaScriptAlert):
3323         (WebCore::WebPage::javaScriptConsoleMessage):
3324         (WebCore::DumpRenderTree::DumpRenderTree):
3325         (WebCore::DumpRenderTree::~DumpRenderTree):
3326         (WebCore::DumpRenderTree::open):
3327         (WebCore::DumpRenderTree::readStdin):
3328         (WebCore::DumpRenderTree::resetJSObjects):
3329         (WebCore::DumpRenderTree::initJSObjects):
3330         (WebCore::DumpRenderTree::dumpFramesAsText):
3331         (WebCore::DumpRenderTree::dump):
3332         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3333         (WebCore::DumpRenderTree::layoutTestController):
3334         (WebCore::DumpRenderTree::eventSender):
3335         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3336         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3337         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3338         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3339         (HackWebFrame::mousePressEvent):
3340         (HackWebFrame::mouseReleaseEvent):
3341         (HackWebFrame::mouseMoveEvent):
3342         (HackWebFrame::HackWebFrame):
3343         (HackWebFrame::~HackWebFrame):
3344         (LayoutTestController::LayoutTestController):
3345         (LayoutTestController::reset):
3346         (LayoutTestController::maybeDump):
3347         (LayoutTestController::waitUntilDone):
3348         (LayoutTestController::notifyDone):
3349         (LayoutTestController::dumpEditingCallbacks):
3350         (LayoutTestController::queueReload):
3351         (LayoutTestController::provisionalLoad):
3352         (LayoutTestController::timerEvent):
3353         (EventSender::EventSender):
3354         (EventSender::mouseDown):
3355         (EventSender::mouseUp):
3356         (EventSender::mouseMoveTo):
3357         (EventSender::leapForward):
3358         (EventSender::keyDown):
3359         (EventSender::frameUnderMouse):
3360         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3361         (LayoutTestController::isLoading):
3362         (LayoutTestController::setLoading):
3363         (LayoutTestController::shouldDumpAsText):
3364         (LayoutTestController::shouldDumpChildrenAsText):
3365         (LayoutTestController::shouldWaitUntilDone):
3366         (LayoutTestController::dumpAsText):
3367         (LayoutTestController::dumpChildFramesAsText):
3368         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3369         (messageHandler):
3370         (crashHandler):
3371         (main):
3372         * Scripts/run-webkit-tests:
3373
3374 2007-10-03  Mark Rowe  <mrowe@apple.com>
3375
3376         Reviewed by Alp Toker.
3377
3378         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3379         should take precedence over QTDIR when determining which port we are working with.
3380
3381         * Scripts/webkitdirs.pm: 
3382
3383 2007-10-02  Adam Roben  <aroben@apple.com>
3384
3385         Add keychain to the list of default packages to install
3386
3387         Rubberstamped by Sam.
3388
3389         * CygwinDownloader/cygwin-downloader.py:
3390         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3391
3392 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3393
3394         Reviewed by Adam.
3395
3396         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3397         Also makes WebCore regression test case logic work when using git.
3398
3399         * Scripts/prepare-ChangeLog:
3400         (reviewerAndDescriptionForGitCommit): Added.
3401
3402 2007-10-02  Lars Knoll  <lars@trolltech.com>
3403
3404         Reviewed by bdash.
3405
3406         Add API to retrieve the frame name from QWebFrame.
3407         Implement support for DRT::dumpChildrenAsText.
3408
3409         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3410         (WebCore::DumpRenderTree::dumpFramesAsText):
3411         (WebCore::DumpRenderTree::dump):
3412         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3413         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3414         (LayoutTestController::LayoutTestController):
3415         (LayoutTestController::reset):
3416         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3417
3418 2007-10-02  Lars Knoll  <lars@trolltech.com>
3419
3420         Reviewed by bdash.
3421
3422         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3423
3424         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3425         (WebCore::DumpRenderTree::readStdin):
3426
3427 2007-10-02  Mark Rowe  <mrowe@apple.com>
3428
3429         Reviewed by Oliver.
3430
3431         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3432
3433         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3434         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3435
3436 2007-10-02  Mark Rowe  <mrowe@apple.com>
3437
3438         Rubber-stamped by Maciej.
3439
3440         Configuration changes from build.webkit.org.  The major change is refactoring to work
3441         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3442         last few weeks.
3443
3444         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3445         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3446         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3447         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3448         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3449         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3450         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3451         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3452
3453 2007-10-02  Lars Knoll  <lars@trolltech.com>
3454
3455         Reviewed by Maciej.
3456
3457         Add support for eventSender.mouseMove to DRT.
3458         Fixes fast/css/hover-affects-child.html
3459
3460         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3461         (EventSender::mouseMoveTo):
3462
3463 2007-10-01  Mark Rowe  <mrowe@apple.com>
3464
3465         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3466
3467 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3468
3469         Reviewed by Hyatt.
3470
3471         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3472
3473         * Scripts/svn-apply:
3474         (gitdiff2svndiff): Ignore lines beginning with "new file".
3475         * Scripts/svn-unapply:
3476         (gitdiff2svndiff): Ditto.
3477
3478 2007-09-30  George Staikos  <staikos@kde.org>
3479
3480         Qt build fix (Mac OS X specific)
3481
3482         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3483
3484 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3485
3486         Reviewed by Mark.
3487
3488         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3489         Remove Bakefiles from svn.
3490
3491         * GtkLauncher/Bakefiles.bkgen: Removed.
3492         * GtkLauncher/ENV: Removed.
3493         * GtkLauncher/gdklauncher.bkl: Removed.
3494         * GtkLauncher/mk: Removed.
3495         * Scripts/regenerate-makefiles: Removed.
3496
3497 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3498
3499         Reviewed by John.
3500
3501         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3502
3503         * Scripts/run-webkit-tests:
3504
3505 2007-09-26  Adam Roben  <aroben@apple.com>
3506
3507         Make not finding an installed WebKit non-fatal
3508
3509         What really matters is that we are able to load WebKit and its
3510         dependencies, not whether we think we've found an installed WebKit.
3511
3512         Reviewed by Sam.
3513
3514         * WebKitInitializer/WebKitInitializer.cpp:
3515         (getWebViewCLSID): Use new LOG_WARNING macro.
3516         (getInstalledWebKitDirectory): Ditto.
3517         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3518         and use new macros.
3519         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3520
3521 2007-09-26  Adam Roben  <aroben@apple.com>
3522
3523         Committed this file before saving it
3524
3525         * WebKitInitializer/debug_internal.vsprops:
3526
3527 2007-09-26  Adam Roben  <aroben@apple.com>
3528
3529         Load WebKit and its dependencies manually so they come from DllDirectory
3530
3531         I had to change WebKitInitializer to use malloc/free instead of
3532         new/delete to avoid pulling in WebKit (and its dependencies) early
3533         through use of fastMalloc.
3534
3535         Reviewed by Oliver.
3536
3537         * WebKitInitializer/WebKitInitializer.cpp:
3538         (getStringValue): Changed to use malloc/free.
3539         (getInstalledWebKitDirectory): Ditto.
3540         (initializeWebKit): Call SetDllDirectory first, then load all of
3541         WebKit's dependencies manually, finally followed by WebKit itself.
3542         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3543         configuration to match our other projects.
3544         * WebKitInitializer/debug_internal.vsprops: Added.
3545
3546 2007-09-25  Adam Roben  <aroben@apple.com>
3547
3548         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3549
3550         Rubberstamped by Sam.
3551
3552         * WebKitInitializer/WebKitInitializer.vcproj:
3553
3554 2007-09-25  Adam Roben  <aroben@apple.com>
3555
3556         Make DumpRenderTree delay-load its dependencies
3557
3558         This lets WebKitInitializer re-route the dependencies to be loaded out
3559         of the Safari installation directory.
3560
3561         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3562         same thing), since we can't import the kCFAllocatorDefault symbol when
3563         delay-loading CoreFoundation.dll.
3564
3565         Rubberstamped by Sam.
3566
3567         * DumpRenderTree/win/DumpRenderTree.cpp:
3568         (runTest):
3569         (javaScriptThreads):
3570         * DumpRenderTree/win/DumpRenderTree.vcproj:
3571         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3572         (LayoutTestController::setWaitToDump):
3573
3574 2007-09-25  Adam Roben  <aroben@apple.com>
3575
3576         Pull ole32.lib into WebKitInitializer
3577
3578         Rubberstamped by Sam.
3579
3580         * WebKitInitializer/WebKitInitializer.vcproj:
3581
3582 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3583
3584         Reviewed by Adam.
3585
3586         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3587           LGPL'ed files contain incorrect FSF address
3588
3589         * Drosera/config.h:
3590
3591 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3592
3593         Reviewed by Adam.
3594
3595         Make svn-apply and svn-unapply work with git-diff formatted patches.
3596
3597         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3598         (gitdiff2svndiff): Added.
3599         * Scripts/svn-unapply: Ditto.
3600         (gitdiff2svndiff): Added.
3601
3602 2007-09-25  Adam Roben  <aroben@apple.com>
3603
3604         Pull advapi32.lib into WebKitInitializer
3605
3606         This is needed to get the registry functions we use.
3607
3608         Rubberstamped by Sam.
3609
3610         * WebKitInitializer/WebKitInitializer.vcproj:
3611
3612 2007-09-25  Adam Roben  <aroben@apple.com>